Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6: (1446 commits) macvlan: fix panic if lowerdev in a bond tg3: Add braces around 5906 workaround. tg3: Fix NETIF_F_LOOPBACK error macvlan: remove one synchronize_rcu() call networking: NET_CLS_ROUTE4 depends on INET irda: Fix error propagation in ircomm_lmp_connect_response() irda: Kill set but unused variable 'bytes' in irlan_check_command_param() irda: Kill set but unused variable 'clen' in ircomm_connect_indication() rxrpc: Fix set but unused variable 'usage' in rxrpc_get_transport() be2net: Kill set but unused variable 'req' in lancer_fw_download() irda: Kill set but unused vars 'saddr' and 'daddr' in irlan_provider_connect_indication() atl1c: atl1c_resume() is only used when CONFIG_PM_SLEEP is defined. rxrpc: Fix set but unused variable 'usage' in rxrpc_get_peer(). rxrpc: Kill set but unused variable 'local' in rxrpc_UDP_error_handler() rxrpc: Kill set but unused variable 'sp' in rxrpc_process_connection() rxrpc: Kill set but unused variable 'sp' in rxrpc_rotate_tx_window() pkt_sched: Kill set but unused variable 'protocol' in tc_classify() isdn: capi: Use pr_debug() instead of ifdefs. tg3: Update version to 3.119 tg3: Apply rx_discards fix to 5719/5720 ... Fix up trivial conflicts in arch/x86/Kconfig and net/mac80211/agg-tx.c as per Davem.
author: Linus Torvalds <torvalds@linux-foundation.org> 2011-05-20 16:43:21 -0400
committer: Linus Torvalds <torvalds@linux-foundation.org> 2011-05-20 16:43:21 -0400
commit: 06f4e926d256d902dd9a53dcb400fd74974ce087 (patch)
tree: 0b438b67f5f0eff6fd617bc497a9dace6164a488 /drivers
parent: 8e7bfcbab3825d1b404d615cb1b54f44ff81f981 (diff)
parent: d93515611bbc70c2fe4db232e5feb448ed8e4cc9 (diff)
770 files changed, 71645 insertions, 33425 deletions
diff --git a/drivers/Kconfig b/drivers/Kconfig
index 557a469c7aa6..61631edfecc2 100644
--- a/drivers/Kconfig
+++ b/drivers/Kconfig
@@ -68,6 +68,8 @@ source "drivers/watchdog/Kconfig"
 source "drivers/ssb/Kconfig"
+source "drivers/bcma/Kconfig"
 source "drivers/mfd/Kconfig"
 source "drivers/regulator/Kconfig"
diff --git a/drivers/Makefile b/drivers/Makefile
index 3f135b6fb014..a29527f4ded6 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -110,6 +110,7 @@ obj-$(CONFIG_HID)		+= hid/
 obj-$(CONFIG_PPC_PS3)           += ps3/
 obj-$(CONFIG_OF)                += of/
 obj-$(CONFIG_SSB)               += ssb/
+obj-$(CONFIG_BCMA)              += bcma/
 obj-$(CONFIG_VHOST_NET)         += vhost/
 obj-$(CONFIG_VLYNQ)             += vlynq/
 obj-$(CONFIG_STAGING)           += staging/
diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index c495fae74200..3230ea0df83c 100644
--- a/drivers/atm/eni.c
+++ b/drivers/atm/eni.c
@@ -1469,10 +1469,7 @@ if (eni_boards) printk(KERN_INFO "loss: %ld\n",ENI_DEV(eni_boards)->lost);
 static void bug_int(struct atm_dev *dev,unsigned long reason)
 {
-        struct eni_dev *eni_dev;
        DPRINTK(">bug_int\n");
-        eni_dev = ENI_DEV(dev);
        if (reason & MID_DMA_ERR_ACK)
                printk(KERN_CRIT DEV_LABEL "(itf %d): driver error - DMA "
                    "error\n",dev->number);
@@ -1900,7 +1897,6 @@ static void eni_close(struct atm_vcc *vcc)
 static int eni_open(struct atm_vcc *vcc)
 {
-        struct eni_dev *eni_dev;
        struct eni_vcc *eni_vcc;
        int error;
        short vpi = vcc->vpi;
@@ -1910,7 +1906,6 @@ static int eni_open(struct atm_vcc *vcc)
        EVENT("eni_open\n",0,0);
        if (!test_bit(ATM_VF_PARTIAL,&vcc->flags))
                vcc->dev_data = NULL;
-        eni_dev = ENI_DEV(vcc->dev);
        if (vci != ATM_VPI_UNSPEC && vpi != ATM_VCI_UNSPEC)
                set_bit(ATM_VF_ADDR,&vcc->flags);
        if (vcc->qos.aal != ATM_AAL0 && vcc->qos.aal != ATM_AAL5)
diff --git a/drivers/atm/he.c b/drivers/atm/he.c
index 6cf59bf281dc..9a51df4f5b74 100644
--- a/drivers/atm/he.c
+++ b/drivers/atm/he.c
@@ -1801,7 +1801,7 @@ return_host_buffers:
 next_rbrq_entry:
                he_dev->rbrq_head = (struct he_rbrq *)
                                ((unsigned long) he_dev->rbrq_base |
-                                        RBRQ_MASK(++he_dev->rbrq_head));
+                                        RBRQ_MASK(he_dev->rbrq_head + 1));
        }
        read_unlock(&vcc_sklist_lock);
@@ -1884,7 +1884,7 @@ next_tbrq_entry:
                        pci_pool_free(he_dev->tpd_pool, tpd, TPD_ADDR(tpd->status));
                he_dev->tbrq_head = (struct he_tbrq *)
                                ((unsigned long) he_dev->tbrq_base |
-                                        TBRQ_MASK(++he_dev->tbrq_head));
+                                        TBRQ_MASK(he_dev->tbrq_head + 1));
        }
        if (updated) {
diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index 048f99fe6f83..1f8d724a18bf 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@ -1261,14 +1261,13 @@ idt77252_rx_raw(struct idt77252_dev *card)
                                    PCI_DMA_FROMDEVICE);
        while (head != tail) {
-                unsigned int vpi, vci, pti;
+                unsigned int vpi, vci;
                u32 header;
                header = le32_to_cpu(*(u32 *) &queue->data[0]);
                vpi = (header & ATM_HDR_VPI_MASK) >> ATM_HDR_VPI_SHIFT;
                vci = (header & ATM_HDR_VCI_MASK) >> ATM_HDR_VCI_SHIFT;
-                pti = (header & ATM_HDR_PTI_MASK) >> ATM_HDR_PTI_SHIFT;
 #ifdef CONFIG_ATM_IDT77252_DEBUG
                if (debug & DBG_RAW_CELL) {
@@ -2709,53 +2708,10 @@ idt77252_proc_read(struct atm_dev *dev, loff_t * pos, char *page)
 static void
 idt77252_collect_stat(struct idt77252_dev *card)
 {
-        u32 cdc, vpec, icc;
+        (void) readl(SAR_REG_CDC);
+        (void) readl(SAR_REG_VPEC);
+        (void) readl(SAR_REG_ICC);
-        cdc = readl(SAR_REG_CDC);
-        vpec = readl(SAR_REG_VPEC);
-        icc = readl(SAR_REG_ICC);
-#ifdef  NOTDEF
-        printk("%s:", card->name);
-        if (cdc & 0x7f0000) {
-                char *s = "";
-                printk(" [");
-                if (cdc & (1 << 22)) {
-                        printk("%sRM ID", s);
-                        s = " | ";
-                }
-                if (cdc & (1 << 21)) {
-                        printk("%sCON TAB", s);
-                        s = " | ";
-                }
-                if (cdc & (1 << 20)) {
-                        printk("%sNO FB", s);
-                        s = " | ";
-                }
-                if (cdc & (1 << 19)) {
-                        printk("%sOAM CRC", s);
-                        s = " | ";
-                }
-                if (cdc & (1 << 18)) {
-                        printk("%sRM CRC", s);
-                        s = " | ";
-                }
-                if (cdc & (1 << 17)) {
-                        printk("%sRM FIFO", s);
-                        s = " | ";
-                }
-                if (cdc & (1 << 16)) {
-                        printk("%sRX FIFO", s);
-                        s = " | ";
-                }
-                printk("]");
-        }
-        printk(" CDC %04x, VPEC %04x, ICC: %04x\n",
-               cdc & 0xffff, vpec & 0xffff, icc & 0xffff);
-#endif
 }
 static irqreturn_t
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 1c674a91f146..dee4f01a64d8 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -613,7 +613,6 @@ static int ia_que_tx (IADEV *iadev) {
   struct sk_buff *skb;
   int num_desc;
   struct atm_vcc *vcc;
-   struct ia_vcc *iavcc;
   num_desc = ia_avail_descs(iadev);
   while (num_desc && (skb = skb_dequeue(&iadev->tx_backlog))) {
@@ -627,7 +626,6 @@ static int ia_que_tx (IADEV *iadev) {
         printk("Free the SKB on closed vci %d \n", vcc->vci);
         break;
      }
-      iavcc = INPH_IA_VCC(vcc);
      if (ia_pkt_tx (vcc, skb)) {
         skb_queue_head(&iadev->tx_backlog, skb);
      }
@@ -823,8 +821,6 @@ static void IaFrontEndIntr(IADEV *iadev) {
  volatile IA_SUNI *suni;
  volatile ia_mb25_t *mb25;
  volatile suni_pm7345_t *suni_pm7345;
-  u32 intr_status;
-  u_int frmr_intr;
  if(iadev->phy_type & FE_25MBIT_PHY) {
     mb25 = (ia_mb25_t*)iadev->phy;
@@ -832,18 +828,18 @@ static void IaFrontEndIntr(IADEV *iadev) {
  } else if (iadev->phy_type & FE_DS3_PHY) {
     suni_pm7345 = (suni_pm7345_t *)iadev->phy;
     /* clear FRMR interrupts */
-     frmr_intr   = suni_pm7345->suni_ds3_frm_intr_stat; 
+     (void) suni_pm7345->suni_ds3_frm_intr_stat; 
     iadev->carrier_detect =  
           Boolean(!(suni_pm7345->suni_ds3_frm_stat & SUNI_DS3_LOSV));
  } else if (iadev->phy_type & FE_E3_PHY ) {
     suni_pm7345 = (suni_pm7345_t *)iadev->phy;
-     frmr_intr   = suni_pm7345->suni_e3_frm_maint_intr_ind;
+     (void) suni_pm7345->suni_e3_frm_maint_intr_ind;
     iadev->carrier_detect =
           Boolean(!(suni_pm7345->suni_e3_frm_fram_intr_ind_stat&SUNI_E3_LOS));
  }
  else { 
     suni = (IA_SUNI *)iadev->phy;
-     intr_status = suni->suni_rsop_status & 0xff;
+     (void) suni->suni_rsop_status;
     iadev->carrier_detect = Boolean(!(suni->suni_rsop_status & SUNI_LOSV));
  }
  if (iadev->carrier_detect)
@@ -2660,7 +2656,6 @@ static void ia_close(struct atm_vcc *vcc)
  
 static int ia_open(struct atm_vcc *vcc)
 {  
-        IADEV *iadev;  
        struct ia_vcc *ia_vcc;  
        int error;  
        if (!test_bit(ATM_VF_PARTIAL,&vcc->flags))  
@@ -2668,7 +2663,6 @@ static int ia_open(struct atm_vcc *vcc)
                IF_EVENT(printk("ia: not partially allocated resources\n");)  
                vcc->dev_data = NULL;
        }  
-        iadev = INPH_IA_DEV(vcc->dev);  
        if (vcc->vci != ATM_VPI_UNSPEC && vcc->vpi != ATM_VCI_UNSPEC)  
        {  
                IF_EVENT(printk("iphase open: unspec part\n");)  
@@ -3052,11 +3046,9 @@ static int ia_pkt_tx (struct atm_vcc *vcc, struct sk_buff *skb) {
 static int ia_send(struct atm_vcc *vcc, struct sk_buff *skb)
 {
        IADEV *iadev; 
-        struct ia_vcc *iavcc;
        unsigned long flags;
        iadev = INPH_IA_DEV(vcc->dev);
-        iavcc = INPH_IA_VCC(vcc); 
        if ((!skb)||(skb->len>(iadev->tx_buf_sz-sizeof(struct cpcs_trailer))))
        {
            if (!skb)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index cd0ff66469b2..5d1d07645132 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -527,7 +527,6 @@ static int flash_upgrade(struct solos_card *card, int chip)
 {
        const struct firmware *fw;
        const char *fw_name;
-        uint32_t data32 = 0;
        int blocksize = 0;
        int numblocks = 0;
        int offset;
@@ -576,7 +575,7 @@ static int flash_upgrade(struct solos_card *card, int chip)
        
        dev_info(&card->dev->dev, "Changing FPGA to Update mode\n");
        iowrite32(1, card->config_regs + FPGA_MODE);
-        data32 = ioread32(card->config_regs + FPGA_MODE); 
+        (void) ioread32(card->config_regs + FPGA_MODE); 
        /* Set mode to Chip Erase */
        if(chip == 0 || chip == 2)
diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
new file mode 100644
index 000000000000..353781b5b78b
--- /dev/null
+++ b/drivers/bcma/Kconfig
@@ -0,0 +1,33 @@
+config BCMA_POSSIBLE
+        bool
+        depends on HAS_IOMEM && HAS_DMA
+        default y
+menu "Broadcom specific AMBA"
+        depends on BCMA_POSSIBLE
+config BCMA
+        tristate "BCMA support"
+        depends on BCMA_POSSIBLE
+        help
+          Bus driver for Broadcom specific Advanced Microcontroller Bus
+          Architecture.
+config BCMA_HOST_PCI_POSSIBLE
+        bool
+        depends on BCMA && PCI = y
+        default y
+config BCMA_HOST_PCI
+        bool "Support for BCMA on PCI-host bus"
+        depends on BCMA_HOST_PCI_POSSIBLE
+config BCMA_DEBUG
+        bool "BCMA debugging"
+        depends on BCMA
+        help
+          This turns on additional debugging messages.
+          If unsure, say N
+endmenu
diff --git a/drivers/bcma/Makefile b/drivers/bcma/Makefile
new file mode 100644
index 000000000000..0d56245bcb79
--- /dev/null
+++ b/drivers/bcma/Makefile
@@ -0,0 +1,7 @@
+bcma-y                                  += main.o scan.o core.o
+bcma-y                                  += driver_chipcommon.o driver_chipcommon_pmu.o
+bcma-y                                  += driver_pci.o
+bcma-$(CONFIG_BCMA_HOST_PCI)            += host_pci.o
+obj-$(CONFIG_BCMA)                      += bcma.o
+ccflags-$(CONFIG_BCMA_DEBUG)            := -DDEBUG
diff --git a/drivers/bcma/README b/drivers/bcma/README
new file mode 100644
index 000000000000..f7e7ce46c603
--- /dev/null
+++ b/drivers/bcma/README
@@ -0,0 +1,19 @@
+Broadcom introduced new bus as replacement for older SSB. It is based on AMBA,
+however from programming point of view there is nothing AMBA specific we use.
+Standard AMBA drivers are platform specific, have hardcoded addresses and use
+AMBA standard fields like CID and PID.
+In case of Broadcom's cards every device consists of:
+1) Broadcom specific AMBA device. It is put on AMBA bus, but can not be treated
+   as standard AMBA device. Reading it's CID or PID can cause machine lockup.
+2) AMBA standard devices called ports or wrappers. They have CIDs (AMBA_CID)
+   and PIDs (0x103BB369), but we do not use that info for anything. One of that
+   devices is used for managing Broadcom specific core.
+Addresses of AMBA devices are not hardcoded in driver and have to be read from
+EPROM.
+In this situation we decided to introduce separated bus. It can contain up to
+16 devices identified by Broadcom specific fields: manufacturer, id, revision
+and class.
diff --git a/drivers/bcma/TODO b/drivers/bcma/TODO
new file mode 100644
index 000000000000..da7aa99fe81c
--- /dev/null
+++ b/drivers/bcma/TODO
@@ -0,0 +1,3 @@
+- Interrupts
+- Defines for PCI core driver
+- Create kernel Documentation (use info from README)
diff --git a/drivers/bcma/bcma_private.h b/drivers/bcma/bcma_private.h
new file mode 100644
index 000000000000..2f72e9c585fd
--- /dev/null
+++ b/drivers/bcma/bcma_private.h
@@ -0,0 +1,28 @@
+#ifndef LINUX_BCMA_PRIVATE_H_
+#define LINUX_BCMA_PRIVATE_H_
+#ifndef pr_fmt
+#define pr_fmt(fmt)             KBUILD_MODNAME ": " fmt
+#endif
+#include <linux/bcma/bcma.h>
+#include <linux/delay.h>
+#define BCMA_CORE_SIZE          0x1000
+struct bcma_bus;
+/* main.c */
+extern int bcma_bus_register(struct bcma_bus *bus);
+extern void bcma_bus_unregister(struct bcma_bus *bus);
+/* scan.c */
+int bcma_bus_scan(struct bcma_bus *bus);
+#ifdef CONFIG_BCMA_HOST_PCI
+/* host_pci.c */
+extern int __init bcma_host_pci_init(void);
+extern void __exit bcma_host_pci_exit(void);
+#endif /* CONFIG_BCMA_HOST_PCI */
+#endif
diff --git a/drivers/bcma/core.c b/drivers/bcma/core.c
new file mode 100644
index 000000000000..ced379f7b371
--- /dev/null
+++ b/drivers/bcma/core.c
@@ -0,0 +1,51 @@
+/*
+ * Broadcom specific AMBA
+ * Core ops
+ *
+ * Licensed under the GNU/GPL. See COPYING for details.
+ */
+#include "bcma_private.h"
+#include <linux/bcma/bcma.h>
+bool bcma_core_is_enabled(struct bcma_device *core)
+{
+        if ((bcma_aread32(core, BCMA_IOCTL) & (BCMA_IOCTL_CLK | BCMA_IOCTL_FGC))
+            != BCMA_IOCTL_CLK)
+                return false;
+        if (bcma_aread32(core, BCMA_RESET_CTL) & BCMA_RESET_CTL_RESET)
+                return false;
+        return true;
+}
+EXPORT_SYMBOL_GPL(bcma_core_is_enabled);
+static void bcma_core_disable(struct bcma_device *core, u32 flags)
+{
+        if (bcma_aread32(core, BCMA_RESET_CTL) & BCMA_RESET_CTL_RESET)
+                return;
+        bcma_awrite32(core, BCMA_IOCTL, flags);
+        bcma_aread32(core, BCMA_IOCTL);
+        udelay(10);
+        bcma_awrite32(core, BCMA_RESET_CTL, BCMA_RESET_CTL_RESET);
+        udelay(1);
+}
+int bcma_core_enable(struct bcma_device *core, u32 flags)
+{
+        bcma_core_disable(core, flags);
+        bcma_awrite32(core, BCMA_IOCTL, (BCMA_IOCTL_CLK | BCMA_IOCTL_FGC | flags));
+        bcma_aread32(core, BCMA_IOCTL);
+        bcma_awrite32(core, BCMA_RESET_CTL, 0);
+        udelay(1);
+        bcma_awrite32(core, BCMA_IOCTL, (BCMA_IOCTL_CLK | flags));
+        bcma_aread32(core, BCMA_IOCTL);
+        udelay(1);
+        return 0;
+}
+EXPORT_SYMBOL_GPL(bcma_core_enable);
diff --git a/drivers/bcma/driver_chipcommon.c b/drivers/bcma/driver_chipcommon.c
new file mode 100644
index 000000000000..606102256b44
--- /dev/null
+++ b/drivers/bcma/driver_chipcommon.c
@@ -0,0 +1,89 @@
+/*
+ * Broadcom specific AMBA
+ * ChipCommon core driver
+ *
+ * Copyright 2005, Broadcom Corporation
+ * Copyright 2006, 2007, Michael Buesch <mb@bu3sch.de>
+ *
+ * Licensed under the GNU/GPL. See COPYING for details.
+ */
+#include "bcma_private.h"
+#include <linux/bcma/bcma.h>
+static inline u32 bcma_cc_write32_masked(struct bcma_drv_cc *cc, u16 offset,
+                                         u32 mask, u32 value)
+{
+        value &= mask;
+        value |= bcma_cc_read32(cc, offset) & ~mask;
+        bcma_cc_write32(cc, offset, value);
+        return value;
+}
+void bcma_core_chipcommon_init(struct bcma_drv_cc *cc)
+{
+        if (cc->core->id.rev >= 11)
+                cc->status = bcma_cc_read32(cc, BCMA_CC_CHIPSTAT);
+        cc->capabilities = bcma_cc_read32(cc, BCMA_CC_CAP);
+        if (cc->core->id.rev >= 35)
+                cc->capabilities_ext = bcma_cc_read32(cc, BCMA_CC_CAP_EXT);
+        if (cc->core->id.rev >= 20) {
+                bcma_cc_write32(cc, BCMA_CC_GPIOPULLUP, 0);
+                bcma_cc_write32(cc, BCMA_CC_GPIOPULLDOWN, 0);
+        }
+        if (cc->capabilities & BCMA_CC_CAP_PMU)
+                bcma_pmu_init(cc);
+        if (cc->capabilities & BCMA_CC_CAP_PCTL)
+                pr_err("Power control not implemented!\n");
+}
+/* Set chip watchdog reset timer to fire in 'ticks' backplane cycles */
+void bcma_chipco_watchdog_timer_set(struct bcma_drv_cc *cc, u32 ticks)
+{
+        /* instant NMI */
+        bcma_cc_write32(cc, BCMA_CC_WATCHDOG, ticks);
+}
+void bcma_chipco_irq_mask(struct bcma_drv_cc *cc, u32 mask, u32 value)
+{
+        bcma_cc_write32_masked(cc, BCMA_CC_IRQMASK, mask, value);
+}
+u32 bcma_chipco_irq_status(struct bcma_drv_cc *cc, u32 mask)
+{
+        return bcma_cc_read32(cc, BCMA_CC_IRQSTAT) & mask;
+}
+u32 bcma_chipco_gpio_in(struct bcma_drv_cc *cc, u32 mask)
+{
+        return bcma_cc_read32(cc, BCMA_CC_GPIOIN) & mask;
+}
+u32 bcma_chipco_gpio_out(struct bcma_drv_cc *cc, u32 mask, u32 value)
+{
+        return bcma_cc_write32_masked(cc, BCMA_CC_GPIOOUT, mask, value);
+}
+u32 bcma_chipco_gpio_outen(struct bcma_drv_cc *cc, u32 mask, u32 value)
+{
+        return bcma_cc_write32_masked(cc, BCMA_CC_GPIOOUTEN, mask, value);
+}
+u32 bcma_chipco_gpio_control(struct bcma_drv_cc *cc, u32 mask, u32 value)
+{
+        return bcma_cc_write32_masked(cc, BCMA_CC_GPIOCTL, mask, value);
+}
+EXPORT_SYMBOL_GPL(bcma_chipco_gpio_control);
+u32 bcma_chipco_gpio_intmask(struct bcma_drv_cc *cc, u32 mask, u32 value)
+{
+        return bcma_cc_write32_masked(cc, BCMA_CC_GPIOIRQ, mask, value);
+}
+u32 bcma_chipco_gpio_polarity(struct bcma_drv_cc *cc, u32 mask, u32 value)
+{
+        return bcma_cc_write32_masked(cc, BCMA_CC_GPIOPOL, mask, value);
+}
diff --git a/drivers/bcma/driver_chipcommon_pmu.c b/drivers/bcma/driver_chipcommon_pmu.c
new file mode 100644
index 000000000000..f44177a644c7
--- /dev/null
+++ b/drivers/bcma/driver_chipcommon_pmu.c
@@ -0,0 +1,134 @@
+/*
+ * Broadcom specific AMBA
+ * ChipCommon Power Management Unit driver
+ *
+ * Copyright 2009, Michael Buesch <mb@bu3sch.de>
+ * Copyright 2007, Broadcom Corporation
+ *
+ * Licensed under the GNU/GPL. See COPYING for details.
+ */
+#include "bcma_private.h"
+#include <linux/bcma/bcma.h>
+static void bcma_chipco_chipctl_maskset(struct bcma_drv_cc *cc,
+                                        u32 offset, u32 mask, u32 set)
+{
+        u32 value;
+        bcma_cc_read32(cc, BCMA_CC_CHIPCTL_ADDR);
+        bcma_cc_write32(cc, BCMA_CC_CHIPCTL_ADDR, offset);
+        bcma_cc_read32(cc, BCMA_CC_CHIPCTL_ADDR);
+        value = bcma_cc_read32(cc, BCMA_CC_CHIPCTL_DATA);
+        value &= mask;
+        value |= set;
+        bcma_cc_write32(cc, BCMA_CC_CHIPCTL_DATA, value);
+        bcma_cc_read32(cc, BCMA_CC_CHIPCTL_DATA);
+}
+static void bcma_pmu_pll_init(struct bcma_drv_cc *cc)
+{
+        struct bcma_bus *bus = cc->core->bus;
+        switch (bus->chipinfo.id) {
+        case 0x4313:
+        case 0x4331:
+        case 43224:
+        case 43225:
+                break;
+        default:
+                pr_err("PLL init unknown for device 0x%04X\n",
+                        bus->chipinfo.id);
+        }
+}
+static void bcma_pmu_resources_init(struct bcma_drv_cc *cc)
+{
+        struct bcma_bus *bus = cc->core->bus;
+        u32 min_msk = 0, max_msk = 0;
+        switch (bus->chipinfo.id) {
+        case 0x4313:
+                min_msk = 0x200D;
+                max_msk = 0xFFFF;
+                break;
+        case 43224:
+                break;
+        default:
+                pr_err("PMU resource config unknown for device 0x%04X\n",
+                        bus->chipinfo.id);
+        }
+        /* Set the resource masks. */
+        if (min_msk)
+                bcma_cc_write32(cc, BCMA_CC_PMU_MINRES_MSK, min_msk);
+        if (max_msk)
+                bcma_cc_write32(cc, BCMA_CC_PMU_MAXRES_MSK, max_msk);
+}
+void bcma_pmu_swreg_init(struct bcma_drv_cc *cc)
+{
+        struct bcma_bus *bus = cc->core->bus;
+        switch (bus->chipinfo.id) {
+        case 0x4313:
+        case 0x4331:
+        case 43224:
+                break;
+        default:
+                pr_err("PMU switch/regulators init unknown for device "
+                        "0x%04X\n", bus->chipinfo.id);
+        }
+}
+void bcma_pmu_workarounds(struct bcma_drv_cc *cc)
+{
+        struct bcma_bus *bus = cc->core->bus;
+        switch (bus->chipinfo.id) {
+        case 0x4313:
+                bcma_chipco_chipctl_maskset(cc, 0, ~0, 0x7);
+                break;
+        case 0x4331:
+                pr_err("Enabling Ext PA lines not implemented\n");
+                break;
+        case 43224:
+                if (bus->chipinfo.rev == 0) {
+                        pr_err("Workarounds for 43224 rev 0 not fully "
+                                "implemented\n");
+                        bcma_chipco_chipctl_maskset(cc, 0, ~0, 0xF0);
+                } else {
+                        bcma_chipco_chipctl_maskset(cc, 0, ~0, 0xF0);
+                }
+                break;
+        default:
+                pr_err("Workarounds unknown for device 0x%04X\n",
+                        bus->chipinfo.id);
+        }
+}
+void bcma_pmu_init(struct bcma_drv_cc *cc)
+{
+        u32 pmucap;
+        pmucap = bcma_cc_read32(cc, BCMA_CC_PMU_CAP);
+        cc->pmu.rev = (pmucap & BCMA_CC_PMU_CAP_REVISION);
+        pr_debug("Found rev %u PMU (capabilities 0x%08X)\n", cc->pmu.rev,
+                 pmucap);
+        if (cc->pmu.rev == 1)
+                bcma_cc_mask32(cc, BCMA_CC_PMU_CTL,
+                              ~BCMA_CC_PMU_CTL_NOILPONW);
+        else
+                bcma_cc_set32(cc, BCMA_CC_PMU_CTL,
+                             BCMA_CC_PMU_CTL_NOILPONW);
+        if (cc->core->id.id == 0x4329 && cc->core->id.rev == 2)
+                pr_err("Fix for 4329b0 bad LPOM state not implemented!\n");
+        bcma_pmu_pll_init(cc);
+        bcma_pmu_resources_init(cc);
+        bcma_pmu_swreg_init(cc);
+        bcma_pmu_workarounds(cc);
+}
diff --git a/drivers/bcma/driver_pci.c b/drivers/bcma/driver_pci.c
new file mode 100644
index 000000000000..e757e4e3c7e2
--- /dev/null
+++ b/drivers/bcma/driver_pci.c
@@ -0,0 +1,163 @@
+/*
+ * Broadcom specific AMBA
+ * PCI Core
+ *
+ * Copyright 2005, Broadcom Corporation
+ * Copyright 2006, 2007, Michael Buesch <mb@bu3sch.de>
+ *
+ * Licensed under the GNU/GPL. See COPYING for details.
+ */
+#include "bcma_private.h"
+#include <linux/bcma/bcma.h>
+/**************************************************
+ * R/W ops.
+ **************************************************/
+static u32 bcma_pcie_read(struct bcma_drv_pci *pc, u32 address)
+{
+        pcicore_write32(pc, 0x130, address);
+        pcicore_read32(pc, 0x130);
+        return pcicore_read32(pc, 0x134);
+}
+#if 0
+static void bcma_pcie_write(struct bcma_drv_pci *pc, u32 address, u32 data)
+{
+        pcicore_write32(pc, 0x130, address);
+        pcicore_read32(pc, 0x130);
+        pcicore_write32(pc, 0x134, data);
+}
+#endif
+static void bcma_pcie_mdio_set_phy(struct bcma_drv_pci *pc, u8 phy)
+{
+        const u16 mdio_control = 0x128;
+        const u16 mdio_data = 0x12C;
+        u32 v;
+        int i;
+        v = (1 << 30); /* Start of Transaction */
+        v |= (1 << 28); /* Write Transaction */
+        v |= (1 << 17); /* Turnaround */
+        v |= (0x1F << 18);
+        v |= (phy << 4);
+        pcicore_write32(pc, mdio_data, v);
+        udelay(10);
+        for (i = 0; i < 200; i++) {
+                v = pcicore_read32(pc, mdio_control);
+                if (v & 0x100 /* Trans complete */)
+                        break;
+                msleep(1);
+        }
+}
+static u16 bcma_pcie_mdio_read(struct bcma_drv_pci *pc, u8 device, u8 address)
+{
+        const u16 mdio_control = 0x128;
+        const u16 mdio_data = 0x12C;
+        int max_retries = 10;
+        u16 ret = 0;
+        u32 v;
+        int i;
+        v = 0x80; /* Enable Preamble Sequence */
+        v |= 0x2; /* MDIO Clock Divisor */
+        pcicore_write32(pc, mdio_control, v);
+        if (pc->core->id.rev >= 10) {
+                max_retries = 200;
+                bcma_pcie_mdio_set_phy(pc, device);
+        }
+        v = (1 << 30); /* Start of Transaction */
+        v |= (1 << 29); /* Read Transaction */
+        v |= (1 << 17); /* Turnaround */
+        if (pc->core->id.rev < 10)
+                v |= (u32)device << 22;
+        v |= (u32)address << 18;
+        pcicore_write32(pc, mdio_data, v);
+        /* Wait for the device to complete the transaction */
+        udelay(10);
+        for (i = 0; i < max_retries; i++) {
+                v = pcicore_read32(pc, mdio_control);
+                if (v & 0x100 /* Trans complete */) {
+                        udelay(10);
+                        ret = pcicore_read32(pc, mdio_data);
+                        break;
+                }
+                msleep(1);
+        }
+        pcicore_write32(pc, mdio_control, 0);
+        return ret;
+}
+static void bcma_pcie_mdio_write(struct bcma_drv_pci *pc, u8 device,
+                                u8 address, u16 data)
+{
+        const u16 mdio_control = 0x128;
+        const u16 mdio_data = 0x12C;
+        int max_retries = 10;
+        u32 v;
+        int i;
+        v = 0x80; /* Enable Preamble Sequence */
+        v |= 0x2; /* MDIO Clock Divisor */
+        pcicore_write32(pc, mdio_control, v);
+        if (pc->core->id.rev >= 10) {
+                max_retries = 200;
+                bcma_pcie_mdio_set_phy(pc, device);
+        }
+        v = (1 << 30); /* Start of Transaction */
+        v |= (1 << 28); /* Write Transaction */
+        v |= (1 << 17); /* Turnaround */
+        if (pc->core->id.rev < 10)
+                v |= (u32)device << 22;
+        v |= (u32)address << 18;
+        v |= data;
+        pcicore_write32(pc, mdio_data, v);
+        /* Wait for the device to complete the transaction */
+        udelay(10);
+        for (i = 0; i < max_retries; i++) {
+                v = pcicore_read32(pc, mdio_control);
+                if (v & 0x100 /* Trans complete */)
+                        break;
+                msleep(1);
+        }
+        pcicore_write32(pc, mdio_control, 0);
+}
+/**************************************************
+ * Workarounds.
+ **************************************************/
+static u8 bcma_pcicore_polarity_workaround(struct bcma_drv_pci *pc)
+{
+        return (bcma_pcie_read(pc, 0x204) & 0x10) ? 0xC0 : 0x80;
+}
+static void bcma_pcicore_serdes_workaround(struct bcma_drv_pci *pc)
+{
+        const u8 serdes_pll_device = 0x1D;
+        const u8 serdes_rx_device = 0x1F;
+        u16 tmp;
+        bcma_pcie_mdio_write(pc, serdes_rx_device, 1 /* Control */,
+                              bcma_pcicore_polarity_workaround(pc));
+        tmp = bcma_pcie_mdio_read(pc, serdes_pll_device, 1 /* Control */);
+        if (tmp & 0x4000)
+                bcma_pcie_mdio_write(pc, serdes_pll_device, 1, tmp & ~0x4000);
+}
+/**************************************************
+ * Init.
+ **************************************************/
+void bcma_core_pci_init(struct bcma_drv_pci *pc)
+{
+        bcma_pcicore_serdes_workaround(pc);
+}
diff --git a/drivers/bcma/host_pci.c b/drivers/bcma/host_pci.c
new file mode 100644
index 000000000000..99dd36e8500b
--- /dev/null
+++ b/drivers/bcma/host_pci.c
@@ -0,0 +1,196 @@
+/*
+ * Broadcom specific AMBA
+ * PCI Host
+ *
+ * Licensed under the GNU/GPL. See COPYING for details.
+ */
+#include "bcma_private.h"
+#include <linux/bcma/bcma.h>
+#include <linux/pci.h>
+static void bcma_host_pci_switch_core(struct bcma_device *core)
+{
+        pci_write_config_dword(core->bus->host_pci, BCMA_PCI_BAR0_WIN,
+                               core->addr);
+        pci_write_config_dword(core->bus->host_pci, BCMA_PCI_BAR0_WIN2,
+                               core->wrap);
+        core->bus->mapped_core = core;
+        pr_debug("Switched to core: 0x%X\n", core->id.id);
+}
+static u8 bcma_host_pci_read8(struct bcma_device *core, u16 offset)
+{
+        if (core->bus->mapped_core != core)
+                bcma_host_pci_switch_core(core);
+        return ioread8(core->bus->mmio + offset);
+}
+static u16 bcma_host_pci_read16(struct bcma_device *core, u16 offset)
+{
+        if (core->bus->mapped_core != core)
+                bcma_host_pci_switch_core(core);
+        return ioread16(core->bus->mmio + offset);
+}
+static u32 bcma_host_pci_read32(struct bcma_device *core, u16 offset)
+{
+        if (core->bus->mapped_core != core)
+                bcma_host_pci_switch_core(core);
+        return ioread32(core->bus->mmio + offset);
+}
+static void bcma_host_pci_write8(struct bcma_device *core, u16 offset,
+                                 u8 value)
+{
+        if (core->bus->mapped_core != core)
+                bcma_host_pci_switch_core(core);
+        iowrite8(value, core->bus->mmio + offset);
+}
+static void bcma_host_pci_write16(struct bcma_device *core, u16 offset,
+                                 u16 value)
+{
+        if (core->bus->mapped_core != core)
+                bcma_host_pci_switch_core(core);
+        iowrite16(value, core->bus->mmio + offset);
+}
+static void bcma_host_pci_write32(struct bcma_device *core, u16 offset,
+                                 u32 value)
+{
+        if (core->bus->mapped_core != core)
+                bcma_host_pci_switch_core(core);
+        iowrite32(value, core->bus->mmio + offset);
+}
+static u32 bcma_host_pci_aread32(struct bcma_device *core, u16 offset)
+{
+        if (core->bus->mapped_core != core)
+                bcma_host_pci_switch_core(core);
+        return ioread32(core->bus->mmio + (1 * BCMA_CORE_SIZE) + offset);
+}
+static void bcma_host_pci_awrite32(struct bcma_device *core, u16 offset,
+                                  u32 value)
+{
+        if (core->bus->mapped_core != core)
+                bcma_host_pci_switch_core(core);
+        iowrite32(value, core->bus->mmio + (1 * BCMA_CORE_SIZE) + offset);
+}
+const struct bcma_host_ops bcma_host_pci_ops = {
+        .read8          = bcma_host_pci_read8,
+        .read16         = bcma_host_pci_read16,
+        .read32         = bcma_host_pci_read32,
+        .write8         = bcma_host_pci_write8,
+        .write16        = bcma_host_pci_write16,
+        .write32        = bcma_host_pci_write32,
+        .aread32        = bcma_host_pci_aread32,
+        .awrite32       = bcma_host_pci_awrite32,
+};
+static int bcma_host_pci_probe(struct pci_dev *dev,
+                             const struct pci_device_id *id)
+{
+        struct bcma_bus *bus;
+        int err = -ENOMEM;
+        const char *name;
+        u32 val;
+        /* Alloc */
+        bus = kzalloc(sizeof(*bus), GFP_KERNEL);
+        if (!bus)
+                goto out;
+        /* Basic PCI configuration */
+        err = pci_enable_device(dev);
+        if (err)
+                goto err_kfree_bus;
+        name = dev_name(&dev->dev);
+        if (dev->driver && dev->driver->name)
+                name = dev->driver->name;
+        err = pci_request_regions(dev, name);
+        if (err)
+                goto err_pci_disable;
+        pci_set_master(dev);
+        /* Disable the RETRY_TIMEOUT register (0x41) to keep
+         * PCI Tx retries from interfering with C3 CPU state */
+        pci_read_config_dword(dev, 0x40, &val);
+        if ((val & 0x0000ff00) != 0)
+                pci_write_config_dword(dev, 0x40, val & 0xffff00ff);
+        /* SSB needed additional powering up, do we have any AMBA PCI cards? */
+        if (!pci_is_pcie(dev))
+                pr_err("PCI card detected, report problems.\n");
+        /* Map MMIO */
+        err = -ENOMEM;
+        bus->mmio = pci_iomap(dev, 0, ~0UL);
+        if (!bus->mmio)
+                goto err_pci_release_regions;
+        /* Host specific */
+        bus->host_pci = dev;
+        bus->hosttype = BCMA_HOSTTYPE_PCI;
+        bus->ops = &bcma_host_pci_ops;
+        /* Register */
+        err = bcma_bus_register(bus);
+        if (err)
+                goto err_pci_unmap_mmio;
+        pci_set_drvdata(dev, bus);
+out:
+        return err;
+err_pci_unmap_mmio:
+        pci_iounmap(dev, bus->mmio);
+err_pci_release_regions:
+        pci_release_regions(dev);
+err_pci_disable:
+        pci_disable_device(dev);
+err_kfree_bus:
+        kfree(bus);
+        return err;
+}
+static void bcma_host_pci_remove(struct pci_dev *dev)
+{
+        struct bcma_bus *bus = pci_get_drvdata(dev);
+        bcma_bus_unregister(bus);
+        pci_iounmap(dev, bus->mmio);
+        pci_release_regions(dev);
+        pci_disable_device(dev);
+        kfree(bus);
+        pci_set_drvdata(dev, NULL);
+}
+static DEFINE_PCI_DEVICE_TABLE(bcma_pci_bridge_tbl) = {
+        { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x4331) },
+        { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x4353) },
+        { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, 0x4727) },
+        { 0, },
+};
+MODULE_DEVICE_TABLE(pci, bcma_pci_bridge_tbl);
+static struct pci_driver bcma_pci_bridge_driver = {
+        .name = "bcma-pci-bridge",
+        .id_table = bcma_pci_bridge_tbl,
+        .probe = bcma_host_pci_probe,
+        .remove = bcma_host_pci_remove,
+};
+int __init bcma_host_pci_init(void)
+{
+        return pci_register_driver(&bcma_pci_bridge_driver);
+}
+void __exit bcma_host_pci_exit(void)
+{
+        pci_unregister_driver(&bcma_pci_bridge_driver);
+}
diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
new file mode 100644
index 000000000000..be52344ed19d
--- /dev/null
+++ b/drivers/bcma/main.c
@@ -0,0 +1,247 @@
+/*
+ * Broadcom specific AMBA
+ * Bus subsystem
+ *
+ * Licensed under the GNU/GPL. See COPYING for details.
+ */
+#include "bcma_private.h"
+#include <linux/bcma/bcma.h>
+MODULE_DESCRIPTION("Broadcom's specific AMBA driver");
+MODULE_LICENSE("GPL");
+static int bcma_bus_match(struct device *dev, struct device_driver *drv);
+static int bcma_device_probe(struct device *dev);
+static int bcma_device_remove(struct device *dev);
+static ssize_t manuf_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+        struct bcma_device *core = container_of(dev, struct bcma_device, dev);
+        return sprintf(buf, "0x%03X\n", core->id.manuf);
+}
+static ssize_t id_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+        struct bcma_device *core = container_of(dev, struct bcma_device, dev);
+        return sprintf(buf, "0x%03X\n", core->id.id);
+}
+static ssize_t rev_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+        struct bcma_device *core = container_of(dev, struct bcma_device, dev);
+        return sprintf(buf, "0x%02X\n", core->id.rev);
+}
+static ssize_t class_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+        struct bcma_device *core = container_of(dev, struct bcma_device, dev);
+        return sprintf(buf, "0x%X\n", core->id.class);
+}
+static struct device_attribute bcma_device_attrs[] = {
+        __ATTR_RO(manuf),
+        __ATTR_RO(id),
+        __ATTR_RO(rev),
+        __ATTR_RO(class),
+        __ATTR_NULL,
+};
+static struct bus_type bcma_bus_type = {
+        .name           = "bcma",
+        .match          = bcma_bus_match,
+        .probe          = bcma_device_probe,
+        .remove         = bcma_device_remove,
+        .dev_attrs      = bcma_device_attrs,
+};
+static struct bcma_device *bcma_find_core(struct bcma_bus *bus, u16 coreid)
+{
+        struct bcma_device *core;
+        list_for_each_entry(core, &bus->cores, list) {
+                if (core->id.id == coreid)
+                        return core;
+        }
+        return NULL;
+}
+static void bcma_release_core_dev(struct device *dev)
+{
+        struct bcma_device *core = container_of(dev, struct bcma_device, dev);
+        kfree(core);
+}
+static int bcma_register_cores(struct bcma_bus *bus)
+{
+        struct bcma_device *core;
+        int err, dev_id = 0;
+        list_for_each_entry(core, &bus->cores, list) {
+                /* We support that cores ourself */
+                switch (core->id.id) {
+                case BCMA_CORE_CHIPCOMMON:
+                case BCMA_CORE_PCI:
+                case BCMA_CORE_PCIE:
+                        continue;
+                }
+                core->dev.release = bcma_release_core_dev;
+                core->dev.bus = &bcma_bus_type;
+                dev_set_name(&core->dev, "bcma%d:%d", 0/*bus->num*/, dev_id);
+                switch (bus->hosttype) {
+                case BCMA_HOSTTYPE_PCI:
+                        core->dev.parent = &bus->host_pci->dev;
+                        break;
+                case BCMA_HOSTTYPE_NONE:
+                case BCMA_HOSTTYPE_SDIO:
+                        break;
+                }
+                err = device_register(&core->dev);
+                if (err) {
+                        pr_err("Could not register dev for core 0x%03X\n",
+                               core->id.id);
+                        continue;
+                }
+                core->dev_registered = true;
+                dev_id++;
+        }
+        return 0;
+}
+static void bcma_unregister_cores(struct bcma_bus *bus)
+{
+        struct bcma_device *core;
+        list_for_each_entry(core, &bus->cores, list) {
+                if (core->dev_registered)
+                        device_unregister(&core->dev);
+        }
+}
+int bcma_bus_register(struct bcma_bus *bus)
+{
+        int err;
+        struct bcma_device *core;
+        /* Scan for devices (cores) */
+        err = bcma_bus_scan(bus);
+        if (err) {
+                pr_err("Failed to scan: %d\n", err);
+                return -1;
+        }
+        /* Init CC core */
+        core = bcma_find_core(bus, BCMA_CORE_CHIPCOMMON);
+        if (core) {
+                bus->drv_cc.core = core;
+                bcma_core_chipcommon_init(&bus->drv_cc);
+        }
+        /* Init PCIE core */
+        core = bcma_find_core(bus, BCMA_CORE_PCIE);
+        if (core) {
+                bus->drv_pci.core = core;
+                bcma_core_pci_init(&bus->drv_pci);
+        }
+        /* Register found cores */
+        bcma_register_cores(bus);
+        pr_info("Bus registered\n");
+        return 0;
+}
+EXPORT_SYMBOL_GPL(bcma_bus_register);
+void bcma_bus_unregister(struct bcma_bus *bus)
+{
+        bcma_unregister_cores(bus);
+}
+EXPORT_SYMBOL_GPL(bcma_bus_unregister);
+int __bcma_driver_register(struct bcma_driver *drv, struct module *owner)
+{
+        drv->drv.name = drv->name;
+        drv->drv.bus = &bcma_bus_type;
+        drv->drv.owner = owner;
+        return driver_register(&drv->drv);
+}
+EXPORT_SYMBOL_GPL(__bcma_driver_register);
+void bcma_driver_unregister(struct bcma_driver *drv)
+{
+        driver_unregister(&drv->drv);
+}
+EXPORT_SYMBOL_GPL(bcma_driver_unregister);
+static int bcma_bus_match(struct device *dev, struct device_driver *drv)
+{
+        struct bcma_device *core = container_of(dev, struct bcma_device, dev);
+        struct bcma_driver *adrv = container_of(drv, struct bcma_driver, drv);
+        const struct bcma_device_id *cid = &core->id;
+        const struct bcma_device_id *did;
+        for (did = adrv->id_table; did->manuf || did->id || did->rev; did++) {
+            if ((did->manuf == cid->manuf || did->manuf == BCMA_ANY_MANUF) &&
+                (did->id == cid->id || did->id == BCMA_ANY_ID) &&
+                (did->rev == cid->rev || did->rev == BCMA_ANY_REV) &&
+                (did->class == cid->class || did->class == BCMA_ANY_CLASS))
+                        return 1;
+        }
+        return 0;
+}
+static int bcma_device_probe(struct device *dev)
+{
+        struct bcma_device *core = container_of(dev, struct bcma_device, dev);
+        struct bcma_driver *adrv = container_of(dev->driver, struct bcma_driver,
+                                               drv);
+        int err = 0;
+        if (adrv->probe)
+                err = adrv->probe(core);
+        return err;
+}
+static int bcma_device_remove(struct device *dev)
+{
+        struct bcma_device *core = container_of(dev, struct bcma_device, dev);
+        struct bcma_driver *adrv = container_of(dev->driver, struct bcma_driver,
+                                               drv);
+        if (adrv->remove)
+                adrv->remove(core);
+        return 0;
+}
+static int __init bcma_modinit(void)
+{
+        int err;
+        err = bus_register(&bcma_bus_type);
+        if (err)
+                return err;
+#ifdef CONFIG_BCMA_HOST_PCI
+        err = bcma_host_pci_init();
+        if (err) {
+                pr_err("PCI host initialization failed\n");
+                err = 0;
+        }
+#endif
+        return err;
+}
+fs_initcall(bcma_modinit);
+static void __exit bcma_modexit(void)
+{
+#ifdef CONFIG_BCMA_HOST_PCI
+        bcma_host_pci_exit();
+#endif
+        bus_unregister(&bcma_bus_type);
+}
+module_exit(bcma_modexit)
diff --git a/drivers/bcma/scan.c b/drivers/bcma/scan.c
new file mode 100644
index 000000000000..40d7dcce8933
--- /dev/null
+++ b/drivers/bcma/scan.c
@@ -0,0 +1,360 @@
+/*
+ * Broadcom specific AMBA
+ * Bus scanning
+ *
+ * Licensed under the GNU/GPL. See COPYING for details.
+ */
+#include "scan.h"
+#include "bcma_private.h"
+#include <linux/bcma/bcma.h>
+#include <linux/bcma/bcma_regs.h>
+#include <linux/pci.h>
+#include <linux/io.h>
+#include <linux/dma-mapping.h>
+#include <linux/slab.h>
+struct bcma_device_id_name {
+        u16 id;
+        const char *name;
+};
+struct bcma_device_id_name bcma_device_names[] = {
+        { BCMA_CORE_OOB_ROUTER, "OOB Router" },
+        { BCMA_CORE_INVALID, "Invalid" },
+        { BCMA_CORE_CHIPCOMMON, "ChipCommon" },
+        { BCMA_CORE_ILINE20, "ILine 20" },
+        { BCMA_CORE_SRAM, "SRAM" },
+        { BCMA_CORE_SDRAM, "SDRAM" },
+        { BCMA_CORE_PCI, "PCI" },
+        { BCMA_CORE_MIPS, "MIPS" },
+        { BCMA_CORE_ETHERNET, "Fast Ethernet" },
+        { BCMA_CORE_V90, "V90" },
+        { BCMA_CORE_USB11_HOSTDEV, "USB 1.1 Hostdev" },
+        { BCMA_CORE_ADSL, "ADSL" },
+        { BCMA_CORE_ILINE100, "ILine 100" },
+        { BCMA_CORE_IPSEC, "IPSEC" },
+        { BCMA_CORE_UTOPIA, "UTOPIA" },
+        { BCMA_CORE_PCMCIA, "PCMCIA" },
+        { BCMA_CORE_INTERNAL_MEM, "Internal Memory" },
+        { BCMA_CORE_MEMC_SDRAM, "MEMC SDRAM" },
+        { BCMA_CORE_OFDM, "OFDM" },
+        { BCMA_CORE_EXTIF, "EXTIF" },
+        { BCMA_CORE_80211, "IEEE 802.11" },
+        { BCMA_CORE_PHY_A, "PHY A" },
+        { BCMA_CORE_PHY_B, "PHY B" },
+        { BCMA_CORE_PHY_G, "PHY G" },
+        { BCMA_CORE_MIPS_3302, "MIPS 3302" },
+        { BCMA_CORE_USB11_HOST, "USB 1.1 Host" },
+        { BCMA_CORE_USB11_DEV, "USB 1.1 Device" },
+        { BCMA_CORE_USB20_HOST, "USB 2.0 Host" },
+        { BCMA_CORE_USB20_DEV, "USB 2.0 Device" },
+        { BCMA_CORE_SDIO_HOST, "SDIO Host" },
+        { BCMA_CORE_ROBOSWITCH, "Roboswitch" },
+        { BCMA_CORE_PARA_ATA, "PATA" },
+        { BCMA_CORE_SATA_XORDMA, "SATA XOR-DMA" },
+        { BCMA_CORE_ETHERNET_GBIT, "GBit Ethernet" },
+        { BCMA_CORE_PCIE, "PCIe" },
+        { BCMA_CORE_PHY_N, "PHY N" },
+        { BCMA_CORE_SRAM_CTL, "SRAM Controller" },
+        { BCMA_CORE_MINI_MACPHY, "Mini MACPHY" },
+        { BCMA_CORE_ARM_1176, "ARM 1176" },
+        { BCMA_CORE_ARM_7TDMI, "ARM 7TDMI" },
+        { BCMA_CORE_PHY_LP, "PHY LP" },
+        { BCMA_CORE_PMU, "PMU" },
+        { BCMA_CORE_PHY_SSN, "PHY SSN" },
+        { BCMA_CORE_SDIO_DEV, "SDIO Device" },
+        { BCMA_CORE_ARM_CM3, "ARM CM3" },
+        { BCMA_CORE_PHY_HT, "PHY HT" },
+        { BCMA_CORE_MIPS_74K, "MIPS 74K" },
+        { BCMA_CORE_MAC_GBIT, "GBit MAC" },
+        { BCMA_CORE_DDR12_MEM_CTL, "DDR1/DDR2 Memory Controller" },
+        { BCMA_CORE_PCIE_RC, "PCIe Root Complex" },
+        { BCMA_CORE_OCP_OCP_BRIDGE, "OCP to OCP Bridge" },
+        { BCMA_CORE_SHARED_COMMON, "Common Shared" },
+        { BCMA_CORE_OCP_AHB_BRIDGE, "OCP to AHB Bridge" },
+        { BCMA_CORE_SPI_HOST, "SPI Host" },
+        { BCMA_CORE_I2S, "I2S" },
+        { BCMA_CORE_SDR_DDR1_MEM_CTL, "SDR/DDR1 Memory Controller" },
+        { BCMA_CORE_SHIM, "SHIM" },
+        { BCMA_CORE_DEFAULT, "Default" },
+};
+const char *bcma_device_name(struct bcma_device_id *id)
+{
+        int i;
+        if (id->manuf == BCMA_MANUF_BCM) {
+                for (i = 0; i < ARRAY_SIZE(bcma_device_names); i++) {
+                        if (bcma_device_names[i].id == id->id)
+                                return bcma_device_names[i].name;
+                }
+        }
+        return "UNKNOWN";
+}
+static u32 bcma_scan_read32(struct bcma_bus *bus, u8 current_coreidx,
+                       u16 offset)
+{
+        return readl(bus->mmio + offset);
+}
+static void bcma_scan_switch_core(struct bcma_bus *bus, u32 addr)
+{
+        if (bus->hosttype == BCMA_HOSTTYPE_PCI)
+                pci_write_config_dword(bus->host_pci, BCMA_PCI_BAR0_WIN,
+                                       addr);
+}
+static u32 bcma_erom_get_ent(struct bcma_bus *bus, u32 **eromptr)
+{
+        u32 ent = readl(*eromptr);
+        (*eromptr)++;
+        return ent;
+}
+static void bcma_erom_push_ent(u32 **eromptr)
+{
+        (*eromptr)--;
+}
+static s32 bcma_erom_get_ci(struct bcma_bus *bus, u32 **eromptr)
+{
+        u32 ent = bcma_erom_get_ent(bus, eromptr);
+        if (!(ent & SCAN_ER_VALID))
+                return -ENOENT;
+        if ((ent & SCAN_ER_TAG) != SCAN_ER_TAG_CI)
+                return -ENOENT;
+        return ent;
+}
+static bool bcma_erom_is_end(struct bcma_bus *bus, u32 **eromptr)
+{
+        u32 ent = bcma_erom_get_ent(bus, eromptr);
+        bcma_erom_push_ent(eromptr);
+        return (ent == (SCAN_ER_TAG_END | SCAN_ER_VALID));
+}
+static bool bcma_erom_is_bridge(struct bcma_bus *bus, u32 **eromptr)
+{
+        u32 ent = bcma_erom_get_ent(bus, eromptr);
+        bcma_erom_push_ent(eromptr);
+        return (((ent & SCAN_ER_VALID)) &&
+                ((ent & SCAN_ER_TAGX) == SCAN_ER_TAG_ADDR) &&
+                ((ent & SCAN_ADDR_TYPE) == SCAN_ADDR_TYPE_BRIDGE));
+}
+static void bcma_erom_skip_component(struct bcma_bus *bus, u32 **eromptr)
+{
+        u32 ent;
+        while (1) {
+                ent = bcma_erom_get_ent(bus, eromptr);
+                if ((ent & SCAN_ER_VALID) &&
+                    ((ent & SCAN_ER_TAG) == SCAN_ER_TAG_CI))
+                        break;
+                if (ent == (SCAN_ER_TAG_END | SCAN_ER_VALID))
+                        break;
+        }
+        bcma_erom_push_ent(eromptr);
+}
+static s32 bcma_erom_get_mst_port(struct bcma_bus *bus, u32 **eromptr)
+{
+        u32 ent = bcma_erom_get_ent(bus, eromptr);
+        if (!(ent & SCAN_ER_VALID))
+                return -ENOENT;
+        if ((ent & SCAN_ER_TAG) != SCAN_ER_TAG_MP)
+                return -ENOENT;
+        return ent;
+}
+static s32 bcma_erom_get_addr_desc(struct bcma_bus *bus, u32 **eromptr,
+                                  u32 type, u8 port)
+{
+        u32 addrl, addrh, sizel, sizeh = 0;
+        u32 size;
+        u32 ent = bcma_erom_get_ent(bus, eromptr);
+        if ((!(ent & SCAN_ER_VALID)) ||
+            ((ent & SCAN_ER_TAGX) != SCAN_ER_TAG_ADDR) ||
+            ((ent & SCAN_ADDR_TYPE) != type) ||
+            (((ent & SCAN_ADDR_PORT) >> SCAN_ADDR_PORT_SHIFT) != port)) {
+                bcma_erom_push_ent(eromptr);
+                return -EINVAL;
+        }
+        addrl = ent & SCAN_ADDR_ADDR;
+        if (ent & SCAN_ADDR_AG32)
+                addrh = bcma_erom_get_ent(bus, eromptr);
+        else
+                addrh = 0;
+        if ((ent & SCAN_ADDR_SZ) == SCAN_ADDR_SZ_SZD) {
+                size = bcma_erom_get_ent(bus, eromptr);
+                sizel = size & SCAN_SIZE_SZ;
+                if (size & SCAN_SIZE_SG32)
+                        sizeh = bcma_erom_get_ent(bus, eromptr);
+        } else
+                sizel = SCAN_ADDR_SZ_BASE <<
+                                ((ent & SCAN_ADDR_SZ) >> SCAN_ADDR_SZ_SHIFT);
+        return addrl;
+}
+int bcma_bus_scan(struct bcma_bus *bus)
+{
+        u32 erombase;
+        u32 __iomem *eromptr, *eromend;
+        s32 cia, cib;
+        u8 ports[2], wrappers[2];
+        s32 tmp;
+        u8 i, j;
+        int err;
+        INIT_LIST_HEAD(&bus->cores);
+        bus->nr_cores = 0;
+        bcma_scan_switch_core(bus, BCMA_ADDR_BASE);
+        tmp = bcma_scan_read32(bus, 0, BCMA_CC_ID);
+        bus->chipinfo.id = (tmp & BCMA_CC_ID_ID) >> BCMA_CC_ID_ID_SHIFT;
+        bus->chipinfo.rev = (tmp & BCMA_CC_ID_REV) >> BCMA_CC_ID_REV_SHIFT;
+        bus->chipinfo.pkg = (tmp & BCMA_CC_ID_PKG) >> BCMA_CC_ID_PKG_SHIFT;
+        erombase = bcma_scan_read32(bus, 0, BCMA_CC_EROM);
+        eromptr = bus->mmio;
+        eromend = eromptr + BCMA_CORE_SIZE / sizeof(u32);
+        bcma_scan_switch_core(bus, erombase);
+        while (eromptr < eromend) {
+                struct bcma_device *core = kzalloc(sizeof(*core), GFP_KERNEL);
+                if (!core)
+                        return -ENOMEM;
+                INIT_LIST_HEAD(&core->list);
+                core->bus = bus;
+                /* get CIs */
+                cia = bcma_erom_get_ci(bus, &eromptr);
+                if (cia < 0) {
+                        bcma_erom_push_ent(&eromptr);
+                        if (bcma_erom_is_end(bus, &eromptr))
+                                break;
+                        err= -EILSEQ;
+                        goto out;
+                }
+                cib = bcma_erom_get_ci(bus, &eromptr);
+                if (cib < 0) {
+                        err= -EILSEQ;
+                        goto out;
+                }
+                /* parse CIs */
+                core->id.class = (cia & SCAN_CIA_CLASS) >> SCAN_CIA_CLASS_SHIFT;
+                core->id.id = (cia & SCAN_CIA_ID) >> SCAN_CIA_ID_SHIFT;
+                core->id.manuf = (cia & SCAN_CIA_MANUF) >> SCAN_CIA_MANUF_SHIFT;
+                ports[0] = (cib & SCAN_CIB_NMP) >> SCAN_CIB_NMP_SHIFT;
+                ports[1] = (cib & SCAN_CIB_NSP) >> SCAN_CIB_NSP_SHIFT;
+                wrappers[0] = (cib & SCAN_CIB_NMW) >> SCAN_CIB_NMW_SHIFT;
+                wrappers[1] = (cib & SCAN_CIB_NSW) >> SCAN_CIB_NSW_SHIFT;
+                core->id.rev = (cib & SCAN_CIB_REV) >> SCAN_CIB_REV_SHIFT;
+                if (((core->id.manuf == BCMA_MANUF_ARM) &&
+                     (core->id.id == 0xFFF)) ||
+                    (ports[1] == 0)) {
+                        bcma_erom_skip_component(bus, &eromptr);
+                        continue;
+                }
+                /* check if component is a core at all */
+                if (wrappers[0] + wrappers[1] == 0) {
+                        /* we could save addrl of the router
+                        if (cid == BCMA_CORE_OOB_ROUTER)
+                         */
+                        bcma_erom_skip_component(bus, &eromptr);
+                        continue;
+                }
+                if (bcma_erom_is_bridge(bus, &eromptr)) {
+                        bcma_erom_skip_component(bus, &eromptr);
+                        continue;
+                }
+                /* get & parse master ports */
+                for (i = 0; i < ports[0]; i++) {
+                        u32 mst_port_d = bcma_erom_get_mst_port(bus, &eromptr);
+                        if (mst_port_d < 0) {
+                                err= -EILSEQ;
+                                goto out;
+                        }
+                }
+                /* get & parse slave ports */
+                for (i = 0; i < ports[1]; i++) {
+                        for (j = 0; ; j++) {
+                                tmp = bcma_erom_get_addr_desc(bus, &eromptr,
+                                        SCAN_ADDR_TYPE_SLAVE, i);
+                                if (tmp < 0) {
+                                        /* no more entries for port _i_ */
+                                        /* pr_debug("erom: slave port %d "
+                                         * "has %d descriptors\n", i, j); */
+                                        break;
+                                } else {
+                                        if (i == 0 && j == 0)
+                                                core->addr = tmp;
+                                }
+                        }
+                }
+                /* get & parse master wrappers */
+                for (i = 0; i < wrappers[0]; i++) {
+                        for (j = 0; ; j++) {
+                                tmp = bcma_erom_get_addr_desc(bus, &eromptr,
+                                        SCAN_ADDR_TYPE_MWRAP, i);
+                                if (tmp < 0) {
+                                        /* no more entries for port _i_ */
+                                        /* pr_debug("erom: master wrapper %d "
+                                         * "has %d descriptors\n", i, j); */
+                                        break;
+                                } else {
+                                        if (i == 0 && j == 0)
+                                                core->wrap = tmp;
+                                }
+                        }
+                }
+                /* get & parse slave wrappers */
+                for (i = 0; i < wrappers[1]; i++) {
+                        u8 hack = (ports[1] == 1) ? 0 : 1;
+                        for (j = 0; ; j++) {
+                                tmp = bcma_erom_get_addr_desc(bus, &eromptr,
+                                        SCAN_ADDR_TYPE_SWRAP, i + hack);
+                                if (tmp < 0) {
+                                        /* no more entries for port _i_ */
+                                        /* pr_debug("erom: master wrapper %d "
+                                         * has %d descriptors\n", i, j); */
+                                        break;
+                                } else {
+                                        if (wrappers[0] == 0 && !i && !j)
+                                                core->wrap = tmp;
+                                }
+                        }
+                }
+                pr_info("Core %d found: %s "
+                        "(manuf 0x%03X, id 0x%03X, rev 0x%02X, class 0x%X)\n",
+                        bus->nr_cores, bcma_device_name(&core->id),
+                        core->id.manuf, core->id.id, core->id.rev,
+                        core->id.class);
+                core->core_index = bus->nr_cores++;
+                list_add(&core->list, &bus->cores);
+                continue;
+out:
+                return err;
+        }
+        return 0;
+}
diff --git a/drivers/bcma/scan.h b/drivers/bcma/scan.h
new file mode 100644
index 000000000000..113e6a66884c
--- /dev/null
+++ b/drivers/bcma/scan.h
@@ -0,0 +1,56 @@
+#ifndef BCMA_SCAN_H_
+#define BCMA_SCAN_H_
+#define BCMA_ADDR_BASE          0x18000000
+#define BCMA_WRAP_BASE          0x18100000
+#define SCAN_ER_VALID           0x00000001
+#define SCAN_ER_TAGX            0x00000006 /* we have to ignore 0x8 bit when checking tag for SCAN_ER_TAG_ADDR */
+#define SCAN_ER_TAG             0x0000000E
+#define  SCAN_ER_TAG_CI         0x00000000
+#define  SCAN_ER_TAG_MP         0x00000002
+#define  SCAN_ER_TAG_ADDR       0x00000004
+#define  SCAN_ER_TAG_END        0x0000000E
+#define SCAN_ER_BAD             0xFFFFFFFF
+#define SCAN_CIA_CLASS          0x000000F0
+#define SCAN_CIA_CLASS_SHIFT    4
+#define SCAN_CIA_ID             0x000FFF00
+#define SCAN_CIA_ID_SHIFT       8
+#define SCAN_CIA_MANUF          0xFFF00000
+#define SCAN_CIA_MANUF_SHIFT    20
+#define SCAN_CIB_NMP            0x000001F0
+#define SCAN_CIB_NMP_SHIFT      4
+#define SCAN_CIB_NSP            0x00003E00
+#define SCAN_CIB_NSP_SHIFT      9
+#define SCAN_CIB_NMW            0x0007C000
+#define SCAN_CIB_NMW_SHIFT      14
+#define SCAN_CIB_NSW            0x00F80000
+#define SCAN_CIB_NSW_SHIFT      17
+#define SCAN_CIB_REV            0xFF000000
+#define SCAN_CIB_REV_SHIFT      24
+#define SCAN_ADDR_AG32          0x00000008
+#define SCAN_ADDR_SZ            0x00000030
+#define SCAN_ADDR_SZ_SHIFT      4
+#define  SCAN_ADDR_SZ_4K        0x00000000
+#define  SCAN_ADDR_SZ_8K        0x00000010
+#define  SCAN_ADDR_SZ_16K       0x00000020
+#define  SCAN_ADDR_SZ_SZD       0x00000030
+#define SCAN_ADDR_TYPE          0x000000C0
+#define  SCAN_ADDR_TYPE_SLAVE   0x00000000
+#define  SCAN_ADDR_TYPE_BRIDGE  0x00000040
+#define  SCAN_ADDR_TYPE_SWRAP   0x00000080
+#define  SCAN_ADDR_TYPE_MWRAP   0x000000C0
+#define SCAN_ADDR_PORT          0x00000F00
+#define SCAN_ADDR_PORT_SHIFT    8
+#define SCAN_ADDR_ADDR          0xFFFFF000
+#define SCAN_ADDR_SZ_BASE       0x00001000      /* 4KB */
+#define SCAN_SIZE_SZ_ALIGN      0x00000FFF
+#define SCAN_SIZE_SZ            0xFFFFF000
+#define SCAN_SIZE_SG32          0x00000008
+#endif /* BCMA_SCAN_H_ */
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 8e0de9a05867..11b41fd40c27 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -188,7 +188,7 @@ config BT_MRVL
          The core driver to support Marvell Bluetooth devices.
          This driver is required if you want to support
-          Marvell Bluetooth devices, such as 8688.
+          Marvell Bluetooth devices, such as 8688/8787.
          Say Y here to compile Marvell Bluetooth driver
          into the kernel or say M to compile it as module.
@@ -201,7 +201,7 @@ config BT_MRVL_SDIO
          The driver for Marvell Bluetooth chipsets with SDIO interface.
          This driver is required if you want to use Marvell Bluetooth
-          devices with SDIO interface. Currently only SD8688 chipset is
+          devices with SDIO interface. Currently SD8688/SD8787 chipsets are
          supported.
          Say Y here to compile support for Marvell BT-over-SDIO driver
diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
index 5577ed656e2f..6bacef368fab 100644
--- a/drivers/bluetooth/ath3k.c
+++ b/drivers/bluetooth/ath3k.c
@@ -62,6 +62,7 @@ static struct usb_device_id ath3k_table[] = {
        /* Atheros AR3011 with sflash firmware*/
        { USB_DEVICE(0x0CF3, 0x3002) },
+        { USB_DEVICE(0x13d3, 0x3304) },
        /* Atheros AR9285 Malbec with sflash firmware */
        { USB_DEVICE(0x03F0, 0x311D) },
@@ -138,9 +139,6 @@ static int ath3k_load_firmware(struct usb_device *udev,
                count -= size;
        }
-        kfree(send_buf);
-        return 0;
 error:
        kfree(send_buf);
        return err;
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index dcc2a6ec23f0..7f521d4ac657 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -49,15 +49,59 @@
 static u8 user_rmmod;
 static u8 sdio_ireg;
+static const struct btmrvl_sdio_card_reg btmrvl_reg_8688 = {
+        .cfg = 0x03,
+        .host_int_mask = 0x04,
+        .host_intstatus = 0x05,
+        .card_status = 0x20,
+        .sq_read_base_addr_a0 = 0x10,
+        .sq_read_base_addr_a1 = 0x11,
+        .card_fw_status0 = 0x40,
+        .card_fw_status1 = 0x41,
+        .card_rx_len = 0x42,
+        .card_rx_unit = 0x43,
+        .io_port_0 = 0x00,
+        .io_port_1 = 0x01,
+        .io_port_2 = 0x02,
+};
+static const struct btmrvl_sdio_card_reg btmrvl_reg_8787 = {
+        .cfg = 0x00,
+        .host_int_mask = 0x02,
+        .host_intstatus = 0x03,
+        .card_status = 0x30,
+        .sq_read_base_addr_a0 = 0x40,
+        .sq_read_base_addr_a1 = 0x41,
+        .card_revision = 0x5c,
+        .card_fw_status0 = 0x60,
+        .card_fw_status1 = 0x61,
+        .card_rx_len = 0x62,
+        .card_rx_unit = 0x63,
+        .io_port_0 = 0x78,
+        .io_port_1 = 0x79,
+        .io_port_2 = 0x7a,
+};
 static const struct btmrvl_sdio_device btmrvl_sdio_sd6888 = {
        .helper         = "sd8688_helper.bin",
        .firmware       = "sd8688.bin",
+        .reg            = &btmrvl_reg_8688,
+        .sd_blksz_fw_dl = 64,
+};
+static const struct btmrvl_sdio_device btmrvl_sdio_sd8787 = {
+        .helper         = NULL,
+        .firmware       = "mrvl/sd8787_uapsta.bin",
+        .reg            = &btmrvl_reg_8787,
+        .sd_blksz_fw_dl = 256,
 };
 static const struct sdio_device_id btmrvl_sdio_ids[] = {
        /* Marvell SD8688 Bluetooth device */
        { SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, 0x9105),
                        .driver_data = (unsigned long) &btmrvl_sdio_sd6888 },
+        /* Marvell SD8787 Bluetooth device */
+        { SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, 0x911A),
+                        .driver_data = (unsigned long) &btmrvl_sdio_sd8787 },
        { }     /* Terminating entry */
 };
@@ -69,7 +113,7 @@ static int btmrvl_sdio_get_rx_unit(struct btmrvl_sdio_card *card)
        u8 reg;
        int ret;
-        reg = sdio_readb(card->func, CARD_RX_UNIT_REG, &ret);
+        reg = sdio_readb(card->func, card->reg->card_rx_unit, &ret);
        if (!ret)
                card->rx_unit = reg;
@@ -83,11 +127,11 @@ static int btmrvl_sdio_read_fw_status(struct btmrvl_sdio_card *card, u16 *dat)
        *dat = 0;
-        fws0 = sdio_readb(card->func, CARD_FW_STATUS0_REG, &ret);
+        fws0 = sdio_readb(card->func, card->reg->card_fw_status0, &ret);
        if (ret)
                return -EIO;
-        fws1 = sdio_readb(card->func, CARD_FW_STATUS1_REG, &ret);
+        fws1 = sdio_readb(card->func, card->reg->card_fw_status1, &ret);
        if (ret)
                return -EIO;
@@ -101,7 +145,7 @@ static int btmrvl_sdio_read_rx_len(struct btmrvl_sdio_card *card, u16 *dat)
        u8 reg;
        int ret;
-        reg = sdio_readb(card->func, CARD_RX_LEN_REG, &ret);
+        reg = sdio_readb(card->func, card->reg->card_rx_len, &ret);
        if (!ret)
                *dat = (u16) reg << card->rx_unit;
@@ -113,7 +157,7 @@ static int btmrvl_sdio_enable_host_int_mask(struct btmrvl_sdio_card *card,
 {
        int ret;
-        sdio_writeb(card->func, mask, HOST_INT_MASK_REG, &ret);
+        sdio_writeb(card->func, mask, card->reg->host_int_mask, &ret);
        if (ret) {
                BT_ERR("Unable to enable the host interrupt!");
                ret = -EIO;
@@ -128,13 +172,13 @@ static int btmrvl_sdio_disable_host_int_mask(struct btmrvl_sdio_card *card,
        u8 host_int_mask;
        int ret;
-        host_int_mask = sdio_readb(card->func, HOST_INT_MASK_REG, &ret);
+        host_int_mask = sdio_readb(card->func, card->reg->host_int_mask, &ret);
        if (ret)
                return -EIO;
        host_int_mask &= ~mask;
-        sdio_writeb(card->func, host_int_mask, HOST_INT_MASK_REG, &ret);
+        sdio_writeb(card->func, host_int_mask, card->reg->host_int_mask, &ret);
        if (ret < 0) {
                BT_ERR("Unable to disable the host interrupt!");
                return -EIO;
@@ -150,7 +194,7 @@ static int btmrvl_sdio_poll_card_status(struct btmrvl_sdio_card *card, u8 bits)
        int ret;
        for (tries = 0; tries < MAX_POLL_TRIES * 1000; tries++) {
-                status = sdio_readb(card->func, CARD_STATUS_REG, &ret);
+                status = sdio_readb(card->func, card->reg->card_status, &ret);
                if (ret)
                        goto failed;
                if ((status & bits) == bits)
@@ -299,7 +343,7 @@ static int btmrvl_sdio_download_fw_w_helper(struct btmrvl_sdio_card *card)
        u8 base0, base1;
        void *tmpfwbuf = NULL;
        u8 *fwbuf;
-        u16 len;
+        u16 len, blksz_dl = card->sd_blksz_fw_dl;
        int txlen = 0, tx_blocks = 0, count = 0;
        ret = request_firmware(&fw_firmware, card->firmware,
@@ -345,7 +389,7 @@ static int btmrvl_sdio_download_fw_w_helper(struct btmrvl_sdio_card *card)
                for (tries = 0; tries < MAX_POLL_TRIES; tries++) {
                        base0 = sdio_readb(card->func,
-                                        SQ_READ_BASE_ADDRESS_A0_REG, &ret);
+                                        card->reg->sq_read_base_addr_a0, &ret);
                        if (ret) {
                                BT_ERR("BASE0 register read failed:"
                                        " base0 = 0x%04X(%d)."
@@ -355,7 +399,7 @@ static int btmrvl_sdio_download_fw_w_helper(struct btmrvl_sdio_card *card)
                                goto done;
                        }
                        base1 = sdio_readb(card->func,
-                                        SQ_READ_BASE_ADDRESS_A1_REG, &ret);
+                                        card->reg->sq_read_base_addr_a1, &ret);
                        if (ret) {
                                BT_ERR("BASE1 register read failed:"
                                        " base1 = 0x%04X(%d)."
@@ -403,20 +447,19 @@ static int btmrvl_sdio_download_fw_w_helper(struct btmrvl_sdio_card *card)
                        if (firmwarelen - offset < txlen)
                                txlen = firmwarelen - offset;
-                        tx_blocks =
+                        tx_blocks = (txlen + blksz_dl - 1) / blksz_dl;
-                            (txlen + SDIO_BLOCK_SIZE - 1) / SDIO_BLOCK_SIZE;
                        memcpy(fwbuf, &firmware[offset], txlen);
                }
                ret = sdio_writesb(card->func, card->ioport, fwbuf,
-                                        tx_blocks * SDIO_BLOCK_SIZE);
+                                                tx_blocks * blksz_dl);
                if (ret < 0) {
                        BT_ERR("FW download, writesb(%d) failed @%d",
                                                        count, offset);
-                        sdio_writeb(card->func, HOST_CMD53_FIN, CONFIG_REG,
+                        sdio_writeb(card->func, HOST_CMD53_FIN,
-                                                                        &ret);
+                                                card->reg->cfg, &ret);
                        if (ret)
                                BT_ERR("writeb failed (CFG)");
                }
@@ -597,7 +640,7 @@ static void btmrvl_sdio_interrupt(struct sdio_func *func)
        priv = card->priv;
-        ireg = sdio_readb(card->func, HOST_INTSTATUS_REG, &ret);
+        ireg = sdio_readb(card->func, card->reg->host_intstatus, &ret);
        if (ret) {
                BT_ERR("sdio_readb: read int status register failed");
                return;
@@ -613,7 +656,7 @@ static void btmrvl_sdio_interrupt(struct sdio_func *func)
                sdio_writeb(card->func, ~(ireg) & (DN_LD_HOST_INT_STATUS |
                                        UP_LD_HOST_INT_STATUS),
-                                HOST_INTSTATUS_REG, &ret);
+                                card->reg->host_intstatus, &ret);
                if (ret) {
                        BT_ERR("sdio_writeb: clear int status register failed");
                        return;
@@ -664,7 +707,7 @@ static int btmrvl_sdio_register_dev(struct btmrvl_sdio_card *card)
                goto release_irq;
        }
-        reg = sdio_readb(func, IO_PORT_0_REG, &ret);
+        reg = sdio_readb(func, card->reg->io_port_0, &ret);
        if (ret < 0) {
                ret = -EIO;
                goto release_irq;
@@ -672,7 +715,7 @@ static int btmrvl_sdio_register_dev(struct btmrvl_sdio_card *card)
        card->ioport = reg;
-        reg = sdio_readb(func, IO_PORT_1_REG, &ret);
+        reg = sdio_readb(func, card->reg->io_port_1, &ret);
        if (ret < 0) {
                ret = -EIO;
                goto release_irq;
@@ -680,7 +723,7 @@ static int btmrvl_sdio_register_dev(struct btmrvl_sdio_card *card)
        card->ioport |= (reg << 8);
-        reg = sdio_readb(func, IO_PORT_2_REG, &ret);
+        reg = sdio_readb(func, card->reg->io_port_2, &ret);
        if (ret < 0) {
                ret = -EIO;
                goto release_irq;
@@ -815,6 +858,8 @@ exit:
 static int btmrvl_sdio_download_fw(struct btmrvl_sdio_card *card)
 {
        int ret = 0;
+        u8 fws0;
+        int pollnum = MAX_POLL_TRIES;
        if (!card || !card->func) {
                BT_ERR("card or function is NULL!");
@@ -827,20 +872,36 @@ static int btmrvl_sdio_download_fw(struct btmrvl_sdio_card *card)
                goto done;
        }
-        ret = btmrvl_sdio_download_helper(card);
+        /* Check if other function driver is downloading the firmware */
+        fws0 = sdio_readb(card->func, card->reg->card_fw_status0, &ret);
        if (ret) {
-                BT_ERR("Failed to download helper!");
+                BT_ERR("Failed to read FW downloading status!");
                ret = -EIO;
                goto done;
        }
+        if (fws0) {
+                BT_DBG("BT not the winner (%#x). Skip FW downloading", fws0);
+                /* Give other function more time to download the firmware */
+                pollnum *= 10;
+        } else {
+                if (card->helper) {
+                        ret = btmrvl_sdio_download_helper(card);
+                        if (ret) {
+                                BT_ERR("Failed to download helper!");
+                                ret = -EIO;
+                                goto done;
+                        }
+                }
-        if (btmrvl_sdio_download_fw_w_helper(card)) {
+                if (btmrvl_sdio_download_fw_w_helper(card)) {
-                BT_ERR("Failed to download firmware!");
+                        BT_ERR("Failed to download firmware!");
-                ret = -EIO;
+                        ret = -EIO;
-                goto done;
+                        goto done;
+                }
        }
-        if (btmrvl_sdio_verify_fw_download(card, MAX_POLL_TRIES)) {
+        if (btmrvl_sdio_verify_fw_download(card, pollnum)) {
                BT_ERR("FW failed to be active in time!");
                ret = -ETIMEDOUT;
                goto done;
@@ -864,7 +925,7 @@ static int btmrvl_sdio_wakeup_fw(struct btmrvl_private *priv)
        sdio_claim_host(card->func);
-        sdio_writeb(card->func, HOST_POWER_UP, CONFIG_REG, &ret);
+        sdio_writeb(card->func, HOST_POWER_UP, card->reg->cfg, &ret);
        sdio_release_host(card->func);
@@ -893,8 +954,10 @@ static int btmrvl_sdio_probe(struct sdio_func *func,
        if (id->driver_data) {
                struct btmrvl_sdio_device *data = (void *) id->driver_data;
-                card->helper   = data->helper;
+                card->helper = data->helper;
                card->firmware = data->firmware;
+                card->reg = data->reg;
+                card->sd_blksz_fw_dl = data->sd_blksz_fw_dl;
        }
        if (btmrvl_sdio_register_dev(card) < 0) {
@@ -1011,3 +1074,4 @@ MODULE_VERSION(VERSION);
 MODULE_LICENSE("GPL v2");
 MODULE_FIRMWARE("sd8688_helper.bin");
 MODULE_FIRMWARE("sd8688.bin");
+MODULE_FIRMWARE("mrvl/sd8787_uapsta.bin");
diff --git a/drivers/bluetooth/btmrvl_sdio.h b/drivers/bluetooth/btmrvl_sdio.h
index 27329f107e5a..43d35a609ca9 100644
--- a/drivers/bluetooth/btmrvl_sdio.h
+++ b/drivers/bluetooth/btmrvl_sdio.h
@@ -47,44 +47,46 @@
 /* Max retry number of CMD53 write */
 #define MAX_WRITE_IOMEM_RETRY           2
-/* Host Control Registers */
+/* register bitmasks */
-#define IO_PORT_0_REG                   0x00
+#define HOST_POWER_UP                           BIT(1)
-#define IO_PORT_1_REG                   0x01
+#define HOST_CMD53_FIN                          BIT(2)
-#define IO_PORT_2_REG                   0x02
+#define HIM_DISABLE                             0xff
-#define CONFIG_REG                      0x03
+#define HIM_ENABLE                              (BIT(0) | BIT(1))
-#define HOST_POWER_UP                   BIT(1)
-#define HOST_CMD53_FIN                  BIT(2)
+#define UP_LD_HOST_INT_STATUS                   BIT(0)
+#define DN_LD_HOST_INT_STATUS                   BIT(1)
-#define HOST_INT_MASK_REG               0x04
-#define HIM_DISABLE                     0xff
+#define DN_LD_CARD_RDY                          BIT(0)
-#define HIM_ENABLE                      (BIT(0) | BIT(1))
+#define CARD_IO_READY                           BIT(3)
-#define HOST_INTSTATUS_REG              0x05
+#define FIRMWARE_READY                          0xfedc
-#define UP_LD_HOST_INT_STATUS           BIT(0)
-#define DN_LD_HOST_INT_STATUS           BIT(1)
+struct btmrvl_sdio_card_reg {
-/* Card Control Registers */
+        u8 cfg;
-#define SQ_READ_BASE_ADDRESS_A0_REG     0x10
+        u8 host_int_mask;
-#define SQ_READ_BASE_ADDRESS_A1_REG     0x11
+        u8 host_intstatus;
+        u8 card_status;
-#define CARD_STATUS_REG                 0x20
+        u8 sq_read_base_addr_a0;
-#define DN_LD_CARD_RDY                  BIT(0)
+        u8 sq_read_base_addr_a1;
-#define CARD_IO_READY                   BIT(3)
+        u8 card_revision;
+        u8 card_fw_status0;
-#define CARD_FW_STATUS0_REG             0x40
+        u8 card_fw_status1;
-#define CARD_FW_STATUS1_REG             0x41
+        u8 card_rx_len;
-#define FIRMWARE_READY                  0xfedc
+        u8 card_rx_unit;
+        u8 io_port_0;
-#define CARD_RX_LEN_REG                 0x42
+        u8 io_port_1;
-#define CARD_RX_UNIT_REG                0x43
+        u8 io_port_2;
+};
 struct btmrvl_sdio_card {
        struct sdio_func *func;
        u32 ioport;
        const char *helper;
        const char *firmware;
+        const struct btmrvl_sdio_card_reg *reg;
+        u16 sd_blksz_fw_dl;
        u8 rx_unit;
        struct btmrvl_private *priv;
 };
@@ -92,6 +94,8 @@ struct btmrvl_sdio_card {
 struct btmrvl_sdio_device {
        const char *helper;
        const char *firmware;
+        const struct btmrvl_sdio_card_reg *reg;
+        u16 sd_blksz_fw_dl;
 };
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 762a5109c68a..c2de8951e3fb 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -104,6 +104,7 @@ static struct usb_device_id blacklist_table[] = {
        /* Atheros 3011 with sflash firmware */
        { USB_DEVICE(0x0cf3, 0x3002), .driver_info = BTUSB_IGNORE },
+        { USB_DEVICE(0x13d3, 0x3304), .driver_info = BTUSB_IGNORE },
        /* Atheros AR9285 Malbec with sflash firmware */
        { USB_DEVICE(0x03f0, 0x311d), .driver_info = BTUSB_IGNORE },
diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c
index bd34406faaae..4093935ddf42 100644
--- a/drivers/bluetooth/hci_ath.c
+++ b/drivers/bluetooth/hci_ath.c
@@ -201,8 +201,13 @@ static struct sk_buff *ath_dequeue(struct hci_uart *hu)
 /* Recv data */
 static int ath_recv(struct hci_uart *hu, void *data, int count)
 {
-        if (hci_recv_stream_fragment(hu->hdev, data, count) < 0)
+        int ret;
+        ret = hci_recv_stream_fragment(hu->hdev, data, count);
+        if (ret < 0) {
                BT_ERR("Frame Reassembly Failed");
+                return ret;
+        }
        return count;
 }
diff --git a/drivers/bluetooth/hci_h4.c b/drivers/bluetooth/hci_h4.c
index 7b8ad93e2c36..2fcd8b387d69 100644
--- a/drivers/bluetooth/hci_h4.c
+++ b/drivers/bluetooth/hci_h4.c
@@ -151,8 +151,13 @@ static inline int h4_check_data_len(struct h4_struct *h4, int len)
 /* Recv data */
 static int h4_recv(struct hci_uart *hu, void *data, int count)
 {
-        if (hci_recv_stream_fragment(hu->hdev, data, count) < 0)
+        int ret;
+        ret = hci_recv_stream_fragment(hu->hdev, data, count);
+        if (ret < 0) {
                BT_ERR("Frame Reassembly Failed");
+                return ret;
+        }
        return count;
 }
diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index 48ad2a7ab080..320f71803a2b 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c
@@ -359,6 +359,7 @@ static void hci_uart_tty_wakeup(struct tty_struct *tty)
 */
 static void hci_uart_tty_receive(struct tty_struct *tty, const u8 *data, char *flags, int count)
 {
+        int ret;
        struct hci_uart *hu = (void *)tty->disc_data;
        if (!hu || tty != hu->tty)
@@ -368,8 +369,9 @@ static void hci_uart_tty_receive(struct tty_struct *tty, const u8 *data, char *f
                return;
        spin_lock(&hu->rx_lock);
-        hu->proto->recv(hu, (void *) data, count);
+        ret = hu->proto->recv(hu, (void *) data, count);
-        hu->hdev->stat.byte_rx += count;
+        if (ret > 0)
+                hu->hdev->stat.byte_rx += count;
        spin_unlock(&hu->rx_lock);
        tty_unthrottle(tty);
diff --git a/drivers/ieee802154/fakehard.c b/drivers/ieee802154/fakehard.c
index d9d0e13efe47..a5a49a1baae7 100644
--- a/drivers/ieee802154/fakehard.c
+++ b/drivers/ieee802154/fakehard.c
@@ -393,16 +393,6 @@ static int __devinit ieee802154fake_probe(struct platform_device *pdev)
        priv = netdev_priv(dev);
        priv->phy = phy;
-        /*
-         * If the name is a format string the caller wants us to do a
-         * name allocation.
-         */
-        if (strchr(dev->name, '%')) {
-                err = dev_alloc_name(dev, dev->name);
-                if (err < 0)
-                        goto out;
-        }
        wpan_phy_set_dev(phy, &pdev->dev);
        SET_NETDEV_DEV(dev, &phy->dev);
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index 4ffc224faa7f..8e21d457b899 100644
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -185,15 +185,20 @@ static int addr4_resolve(struct sockaddr_in *src_in,
        __be32 dst_ip = dst_in->sin_addr.s_addr;
        struct rtable *rt;
        struct neighbour *neigh;
+        struct flowi4 fl4;
        int ret;
-        rt = ip_route_output(&init_net, dst_ip, src_ip, 0, addr->bound_dev_if);
+        memset(&fl4, 0, sizeof(fl4));
+        fl4.daddr = dst_ip;
+        fl4.saddr = src_ip;
+        fl4.flowi4_oif = addr->bound_dev_if;
+        rt = ip_route_output_key(&init_net, &fl4);
        if (IS_ERR(rt)) {
                ret = PTR_ERR(rt);
                goto out;
        }
        src_in->sin_family = AF_INET;
-        src_in->sin_addr.s_addr = rt->rt_src;
+        src_in->sin_addr.s_addr = fl4.saddr;
        if (rt->dst.dev->flags & IFF_LOOPBACK) {
                ret = rdma_translate_ip((struct sockaddr *) dst_in, addr);
diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index 3216bcad7e82..239184138994 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -338,8 +338,9 @@ static struct rtable *find_route(struct t3cdev *dev, __be32 local_ip,
                                 __be16 peer_port, u8 tos)
 {
        struct rtable *rt;
+        struct flowi4 fl4;
-        rt = ip_route_output_ports(&init_net, NULL, peer_ip, local_ip,
+        rt = ip_route_output_ports(&init_net, &fl4, NULL, peer_ip, local_ip,
                                   peer_port, local_port, IPPROTO_TCP,
                                   tos, 0);
        if (IS_ERR(rt))
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index d7ee70fc9173..f660cd04ec2f 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -315,8 +315,9 @@ static struct rtable *find_route(struct c4iw_dev *dev, __be32 local_ip,
                                 __be16 peer_port, u8 tos)
 {
        struct rtable *rt;
+        struct flowi4 fl4;
-        rt = ip_route_output_ports(&init_net, NULL, peer_ip, local_ip,
+        rt = ip_route_output_ports(&init_net, &fl4, NULL, peer_ip, local_ip,
                                   peer_port, local_port, IPPROTO_TCP,
                                   tos, 0);
        if (IS_ERR(rt))
diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c
index 10d0a5ec9add..96fa9a4cafdf 100644
--- a/drivers/infiniband/hw/nes/nes_hw.c
+++ b/drivers/infiniband/hw/nes/nes_hw.c
@@ -2885,9 +2885,8 @@ void nes_nic_ce_handler(struct nes_device *nesdev, struct nes_hw_nic_cq *cq)
                                        if ((cqe_errv &
                                                        (NES_NIC_ERRV_BITS_IPV4_CSUM_ERR | NES_NIC_ERRV_BITS_TCPUDP_CSUM_ERR |
                                                        NES_NIC_ERRV_BITS_IPH_ERR | NES_NIC_ERRV_BITS_WQE_OVERRUN)) == 0) {
-                                                if (nesvnic->rx_checksum_disabled == 0) {
+                                                if (nesvnic->netdev->features & NETIF_F_RXCSUM)
                                                        rx_skb->ip_summed = CHECKSUM_UNNECESSARY;
-                                                }
                                        } else
                                                nes_debug(NES_DBG_CQ, "%s: unsuccessfully checksummed TCP or UDP packet."
                                                                " errv = 0x%X, pkt_type = 0x%X.\n",
@@ -2897,7 +2896,7 @@ void nes_nic_ce_handler(struct nes_device *nesdev, struct nes_hw_nic_cq *cq)
                                        if ((cqe_errv &
                                                        (NES_NIC_ERRV_BITS_IPV4_CSUM_ERR | NES_NIC_ERRV_BITS_IPH_ERR |
                                                        NES_NIC_ERRV_BITS_WQE_OVERRUN)) == 0) {
-                                                if (nesvnic->rx_checksum_disabled == 0) {
+                                                if (nesvnic->netdev->features & NETIF_F_RXCSUM) {
                                                        rx_skb->ip_summed = CHECKSUM_UNNECESSARY;
                                                        /* nes_debug(NES_DBG_CQ, "%s: Reporting successfully checksummed IPv4 packet.\n",
                                                                  nesvnic->netdev->name); */
diff --git a/drivers/infiniband/hw/nes/nes_hw.h b/drivers/infiniband/hw/nes/nes_hw.h
index d2abe07133a5..91594116f947 100644
--- a/drivers/infiniband/hw/nes/nes_hw.h
+++ b/drivers/infiniband/hw/nes/nes_hw.h
@@ -1245,7 +1245,6 @@ struct nes_vnic {
        u8  next_qp_nic_index;
        u8  of_device_registered;
        u8  rdma_enabled;
-        u8  rx_checksum_disabled;
        u32 lro_max_aggr;
        struct net_lro_mgr lro_mgr;
        struct net_lro_desc lro_desc[NES_MAX_LRO_DESCRIPTORS];
diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c
index e96b8fb5d44c..d3a1c41cfd27 100644
--- a/drivers/infiniband/hw/nes/nes_nic.c
+++ b/drivers/infiniband/hw/nes/nes_nic.c
@@ -1093,34 +1093,6 @@ static const char nes_ethtool_stringset[][ETH_GSTRING_LEN] = {
 };
 #define NES_ETHTOOL_STAT_COUNT  ARRAY_SIZE(nes_ethtool_stringset)
-/**
- * nes_netdev_get_rx_csum
- */
-static u32 nes_netdev_get_rx_csum (struct net_device *netdev)
-{
-        struct nes_vnic *nesvnic = netdev_priv(netdev);
-        if (nesvnic->rx_checksum_disabled)
-                return 0;
-        else
-                return 1;
-}
-/**
- * nes_netdev_set_rc_csum
- */
-static int nes_netdev_set_rx_csum(struct net_device *netdev, u32 enable)
-{
-        struct nes_vnic *nesvnic = netdev_priv(netdev);
-        if (enable)
-                nesvnic->rx_checksum_disabled = 0;
-        else
-                nesvnic->rx_checksum_disabled = 1;
-        return 0;
-}
 /**
 * nes_netdev_get_sset_count
@@ -1521,7 +1493,7 @@ static int nes_netdev_get_settings(struct net_device *netdev, struct ethtool_cmd
        et_cmd->maxrxpkt = 511;
        if (nesadapter->OneG_Mode) {
-                et_cmd->speed = SPEED_1000;
+                ethtool_cmd_speed_set(et_cmd, SPEED_1000);
                if (phy_type == NES_PHY_TYPE_PUMA_1G) {
                        et_cmd->supported   = SUPPORTED_1000baseT_Full;
                        et_cmd->advertising = ADVERTISED_1000baseT_Full;
@@ -1560,7 +1532,7 @@ static int nes_netdev_get_settings(struct net_device *netdev, struct ethtool_cmd
                et_cmd->advertising = ADVERTISED_10000baseT_Full;
                et_cmd->phy_address = mac_index;
        }
-        et_cmd->speed = SPEED_10000;
+        ethtool_cmd_speed_set(et_cmd, SPEED_10000);
        et_cmd->autoneg = AUTONEG_DISABLE;
        return 0;
 }
@@ -1598,19 +1570,10 @@ static int nes_netdev_set_settings(struct net_device *netdev, struct ethtool_cmd
 }
-static int nes_netdev_set_flags(struct net_device *netdev, u32 flags)
-{
-        return ethtool_op_set_flags(netdev, flags, ETH_FLAG_LRO);
-}
 static const struct ethtool_ops nes_ethtool_ops = {
        .get_link = ethtool_op_get_link,
        .get_settings = nes_netdev_get_settings,
        .set_settings = nes_netdev_set_settings,
-        .get_tx_csum = ethtool_op_get_tx_csum,
-        .get_rx_csum = nes_netdev_get_rx_csum,
-        .get_sg = ethtool_op_get_sg,
        .get_strings = nes_netdev_get_strings,
        .get_sset_count = nes_netdev_get_sset_count,
        .get_ethtool_stats = nes_netdev_get_ethtool_stats,
@@ -1619,13 +1582,6 @@ static const struct ethtool_ops nes_ethtool_ops = {
        .set_coalesce = nes_netdev_set_coalesce,
        .get_pauseparam = nes_netdev_get_pauseparam,
        .set_pauseparam = nes_netdev_set_pauseparam,
-        .set_tx_csum = ethtool_op_set_tx_csum,
-        .set_rx_csum = nes_netdev_set_rx_csum,
-        .set_sg = ethtool_op_set_sg,
-        .get_tso = ethtool_op_get_tso,
-        .set_tso = ethtool_op_set_tso,
-        .get_flags = ethtool_op_get_flags,
-        .set_flags = nes_netdev_set_flags,
 };
@@ -1727,12 +1683,11 @@ struct net_device *nes_netdev_init(struct nes_device *nesdev,
        netdev->dev_addr[5] = (u8)u64temp;
        memcpy(netdev->perm_addr, netdev->dev_addr, 6);
-        if ((nesvnic->logical_port < 2) || (nesdev->nesadapter->hw_rev != NE020_REV)) {
+        netdev->hw_features = NETIF_F_RXCSUM | NETIF_F_SG | NETIF_F_IP_CSUM;
-                netdev->features |= NETIF_F_TSO | NETIF_F_SG | NETIF_F_IP_CSUM;
+        if ((nesvnic->logical_port < 2) || (nesdev->nesadapter->hw_rev != NE020_REV))
-                netdev->features |= NETIF_F_GSO | NETIF_F_TSO | NETIF_F_SG | NETIF_F_IP_CSUM;
+                netdev->hw_features |= NETIF_F_TSO;
-        } else {
+        netdev->features |= netdev->hw_features;
-                netdev->features |= NETIF_F_SG | NETIF_F_IP_CSUM;
+        netdev->hw_features |= NETIF_F_LRO;
-        }
        nes_debug(NES_DBG_INIT, "nesvnic = %p, reported features = 0x%lX, QPid = %d,"
                        " nic_index = %d, logical_port = %d, mac_index = %d.\n",
diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
index ab97f92fc257..7b6985a2e652 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib.h
+++ b/drivers/infiniband/ulp/ipoib/ipoib.h
@@ -91,7 +91,6 @@ enum {
        IPOIB_STOP_REAPER         = 7,
        IPOIB_FLAG_ADMIN_CM       = 9,
        IPOIB_FLAG_UMCAST         = 10,
-        IPOIB_FLAG_CSUM           = 11,
        IPOIB_MAX_BACKOFF_SECONDS = 16,
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
index 93d55806b967..39913a065f99 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
@@ -1463,8 +1463,7 @@ static ssize_t set_mode(struct device *d, struct device_attribute *attr,
                set_bit(IPOIB_FLAG_ADMIN_CM, &priv->flags);
                ipoib_warn(priv, "enabling connected mode "
                           "will cause multicast packet drops\n");
+                netdev_update_features(dev);
-                dev->features &= ~(NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO);
                rtnl_unlock();
                priv->tx_wr.send_flags &= ~IB_SEND_IP_CSUM;
@@ -1474,13 +1473,7 @@ static ssize_t set_mode(struct device *d, struct device_attribute *attr,
        if (!strcmp(buf, "datagram\n")) {
                clear_bit(IPOIB_FLAG_ADMIN_CM, &priv->flags);
+                netdev_update_features(dev);
-                if (test_bit(IPOIB_FLAG_CSUM, &priv->flags)) {
-                        dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
-                        priv->dev->features |= NETIF_F_GRO;
-                        if (priv->hca_caps & IB_DEVICE_UD_TSO)
-                                dev->features |= NETIF_F_TSO;
-                }
                dev_set_mtu(dev, min(priv->mcast_mtu, dev->mtu));
                rtnl_unlock();
                ipoib_flush_paths(dev);
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
index 19f7f5206f78..29bc7b5724ac 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
@@ -42,32 +42,6 @@ static void ipoib_get_drvinfo(struct net_device *netdev,
        strncpy(drvinfo->driver, "ipoib", sizeof(drvinfo->driver) - 1);
 }
-static u32 ipoib_get_rx_csum(struct net_device *dev)
-{
-        struct ipoib_dev_priv *priv = netdev_priv(dev);
-        return test_bit(IPOIB_FLAG_CSUM, &priv->flags) &&
-                !test_bit(IPOIB_FLAG_ADMIN_CM, &priv->flags);
-}
-static int ipoib_set_tso(struct net_device *dev, u32 data)
-{
-        struct ipoib_dev_priv *priv = netdev_priv(dev);
-        if (data) {
-                if (!test_bit(IPOIB_FLAG_ADMIN_CM, &priv->flags) &&
-                    (dev->features & NETIF_F_SG) &&
-                    (priv->hca_caps & IB_DEVICE_UD_TSO)) {
-                        dev->features |= NETIF_F_TSO;
-                } else {
-                        ipoib_warn(priv, "can't set TSO on\n");
-                        return -EOPNOTSUPP;
-                }
-        } else
-                dev->features &= ~NETIF_F_TSO;
-        return 0;
-}
 static int ipoib_get_coalesce(struct net_device *dev,
                              struct ethtool_coalesce *coal)
 {
@@ -108,8 +82,6 @@ static int ipoib_set_coalesce(struct net_device *dev,
 static const struct ethtool_ops ipoib_ethtool_ops = {
        .get_drvinfo            = ipoib_get_drvinfo,
-        .get_rx_csum            = ipoib_get_rx_csum,
-        .set_tso                = ipoib_set_tso,
        .get_coalesce           = ipoib_get_coalesce,
        .set_coalesce           = ipoib_set_coalesce,
 };
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
index 806d0292dc39..81ae61d68a22 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
@@ -292,7 +292,7 @@ static void ipoib_ib_handle_rx_wc(struct net_device *dev, struct ib_wc *wc)
        dev->stats.rx_bytes += skb->len;
        skb->dev = dev;
-        if (test_bit(IPOIB_FLAG_CSUM, &priv->flags) && likely(wc->csum_ok))
+        if ((dev->features & NETIF_F_RXCSUM) && likely(wc->csum_ok))
                skb->ip_summed = CHECKSUM_UNNECESSARY;
        napi_gro_receive(&priv->napi, skb);
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index aca3b44f7aed..86addca9ddf6 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -171,6 +171,16 @@ static int ipoib_stop(struct net_device *dev)
        return 0;
 }
+static u32 ipoib_fix_features(struct net_device *dev, u32 features)
+{
+        struct ipoib_dev_priv *priv = netdev_priv(dev);
+        if (test_bit(IPOIB_FLAG_ADMIN_CM, &priv->flags))
+                features &= ~(NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO);
+        return features;
+}
 static int ipoib_change_mtu(struct net_device *dev, int new_mtu)
 {
        struct ipoib_dev_priv *priv = netdev_priv(dev);
@@ -970,6 +980,7 @@ static const struct net_device_ops ipoib_netdev_ops = {
        .ndo_open                = ipoib_open,
        .ndo_stop                = ipoib_stop,
        .ndo_change_mtu          = ipoib_change_mtu,
+        .ndo_fix_features        = ipoib_fix_features,
        .ndo_start_xmit          = ipoib_start_xmit,
        .ndo_tx_timeout          = ipoib_timeout,
        .ndo_set_multicast_list  = ipoib_set_mcast_list,
@@ -1154,19 +1165,18 @@ int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
        kfree(device_attr);
        if (priv->hca_caps & IB_DEVICE_UD_IP_CSUM) {
-                set_bit(IPOIB_FLAG_CSUM, &priv->flags);
+                priv->dev->hw_features = NETIF_F_SG |
-                priv->dev->features |= NETIF_F_SG | NETIF_F_IP_CSUM;
+                        NETIF_F_IP_CSUM | NETIF_F_RXCSUM;
-        }
-        priv->dev->features |= NETIF_F_GRO;
+                if (priv->hca_caps & IB_DEVICE_UD_TSO)
+                        priv->dev->hw_features |= NETIF_F_TSO;
-        if (priv->dev->features & NETIF_F_SG && priv->hca_caps & IB_DEVICE_UD_TSO)
+                priv->dev->features |= priv->dev->hw_features;
-                priv->dev->features |= NETIF_F_TSO;
+        }
        return 0;
 }
 static struct net_device *ipoib_add_port(const char *format,
                                         struct ib_device *hca, u8 port)
 {
diff --git a/drivers/isdn/capi/Kconfig b/drivers/isdn/capi/Kconfig
index a168e8a891be..15c3ffd9d860 100644
--- a/drivers/isdn/capi/Kconfig
+++ b/drivers/isdn/capi/Kconfig
@@ -33,21 +33,6 @@ config ISDN_CAPI_CAPI20
          standardized libcapi20 to access this functionality.  You should say
          Y/M here.
-config ISDN_CAPI_CAPIFS_BOOL
-        bool "CAPI2.0 filesystem support (DEPRECATED)"
-        depends on ISDN_CAPI_MIDDLEWARE && ISDN_CAPI_CAPI20
-        help
-          This option provides a special file system, similar to /dev/pts with
-          device nodes for the special ttys established by using the
-          middleware extension above.
-          You no longer need this, udev fully replaces it. This feature is
-          scheduled for removal.
-config ISDN_CAPI_CAPIFS
-        tristate
-        depends on ISDN_CAPI_CAPIFS_BOOL
-        default ISDN_CAPI_CAPI20
 config ISDN_CAPI_CAPIDRV
        tristate "CAPI2.0 capidrv interface support"
        depends on ISDN_I4L
diff --git a/drivers/isdn/capi/Makefile b/drivers/isdn/capi/Makefile
index 57123e3e4978..4d5b4b71db1e 100644
--- a/drivers/isdn/capi/Makefile
+++ b/drivers/isdn/capi/Makefile
@@ -7,7 +7,6 @@
 obj-$(CONFIG_ISDN_CAPI)                 += kernelcapi.o
 obj-$(CONFIG_ISDN_CAPI_CAPI20)          += capi.o 
 obj-$(CONFIG_ISDN_CAPI_CAPIDRV)         += capidrv.o
-obj-$(CONFIG_ISDN_CAPI_CAPIFS)          += capifs.o
 # Multipart objects.
diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c
index 0d7088367038..e44933d58790 100644
--- a/drivers/isdn/capi/capi.c
+++ b/drivers/isdn/capi/capi.c
@@ -38,15 +38,10 @@
 #include <linux/isdn/capiutil.h>
 #include <linux/isdn/capicmd.h>
-#include "capifs.h"
 MODULE_DESCRIPTION("CAPI4Linux: Userspace /dev/capi20 interface");
 MODULE_AUTHOR("Carsten Paeth");
 MODULE_LICENSE("GPL");
-#undef _DEBUG_TTYFUNCS          /* call to tty_driver */
-#undef _DEBUG_DATAFLOW          /* data flow */
 /* -------- driver information -------------------------------------- */
 static DEFINE_MUTEX(capi_mutex);
@@ -85,7 +80,6 @@ struct capiminor {
        struct kref kref;
        unsigned int      minor;
-        struct dentry *capifs_dentry;
        struct capi20_appl      *ap;
        u32                     ncci;
@@ -300,17 +294,8 @@ static void capiminor_free(struct capiminor *mp)
 static void capincci_alloc_minor(struct capidev *cdev, struct capincci *np)
 {
-        struct capiminor *mp;
+        if (cdev->userflags & CAPIFLAG_HIGHJACKING)
-        dev_t device;
+                np->minorp = capiminor_alloc(&cdev->ap, np->ncci);
-        if (!(cdev->userflags & CAPIFLAG_HIGHJACKING))
-                return;
-        mp = np->minorp = capiminor_alloc(&cdev->ap, np->ncci);
-        if (mp) {
-                device = MKDEV(capinc_tty_driver->major, mp->minor);
-                mp->capifs_dentry = capifs_new_ncci(mp->minor, device);
-        }
 }
 static void capincci_free_minor(struct capincci *np)
@@ -319,8 +304,6 @@ static void capincci_free_minor(struct capincci *np)
        struct tty_struct *tty;
        if (mp) {
-                capifs_free_ncci(mp->capifs_dentry);
                tty = tty_port_tty_get(&mp->port);
                if (tty) {
                        tty_vhangup(tty);
@@ -432,9 +415,7 @@ static int handle_recv_skb(struct capiminor *mp, struct sk_buff *skb)
        tty = tty_port_tty_get(&mp->port);
        if (!tty) {
-#ifdef _DEBUG_DATAFLOW
+                pr_debug("capi: currently no receiver\n");
-                printk(KERN_DEBUG "capi: currently no receiver\n");
-#endif
                return -1;
        }
        
@@ -447,23 +428,17 @@ static int handle_recv_skb(struct capiminor *mp, struct sk_buff *skb)
        }
        if (ld->ops->receive_buf == NULL) {
-#if defined(_DEBUG_DATAFLOW) || defined(_DEBUG_TTYFUNCS)
+                pr_debug("capi: ldisc has no receive_buf function\n");
-                printk(KERN_DEBUG "capi: ldisc has no receive_buf function\n");
-#endif
                /* fatal error, do not requeue */
                goto free_skb;
        }
        if (mp->ttyinstop) {
-#if defined(_DEBUG_DATAFLOW) || defined(_DEBUG_TTYFUNCS)
+                pr_debug("capi: recv tty throttled\n");
-                printk(KERN_DEBUG "capi: recv tty throttled\n");
-#endif
                goto deref_ldisc;
        }
        if (tty->receive_room < datalen) {
-#if defined(_DEBUG_DATAFLOW) || defined(_DEBUG_TTYFUNCS)
+                pr_debug("capi: no room in tty\n");
-                printk(KERN_DEBUG "capi: no room in tty\n");
-#endif
                goto deref_ldisc;
        }
@@ -479,10 +454,8 @@ static int handle_recv_skb(struct capiminor *mp, struct sk_buff *skb)
        if (errcode == CAPI_NOERROR) {
                skb_pull(skb, CAPIMSG_LEN(skb->data));
-#ifdef _DEBUG_DATAFLOW
+                pr_debug("capi: DATA_B3_RESP %u len=%d => ldisc\n",
-                printk(KERN_DEBUG "capi: DATA_B3_RESP %u len=%d => ldisc\n",
+                         datahandle, skb->len);
-                                        datahandle, skb->len);
-#endif
                ld->ops->receive_buf(tty, skb->data, NULL, skb->len);
        } else {
                printk(KERN_ERR "capi: send DATA_B3_RESP failed=%x\n",
@@ -529,9 +502,7 @@ static void handle_minor_send(struct capiminor *mp)
                return;
        if (mp->ttyoutstop) {
-#if defined(_DEBUG_DATAFLOW) || defined(_DEBUG_TTYFUNCS)
+                pr_debug("capi: send: tty stopped\n");
-                printk(KERN_DEBUG "capi: send: tty stopped\n");
-#endif
                tty_kref_put(tty);
                return;
        }
@@ -573,10 +544,8 @@ static void handle_minor_send(struct capiminor *mp)
                }
                errcode = capi20_put_message(mp->ap, skb);
                if (errcode == CAPI_NOERROR) {
-#ifdef _DEBUG_DATAFLOW
+                        pr_debug("capi: DATA_B3_REQ %u len=%u\n",
-                        printk(KERN_DEBUG "capi: DATA_B3_REQ %u len=%u\n",
+                                 datahandle, len);
-                                                        datahandle, len);
-#endif
                        continue;
                }
                capiminor_del_ack(mp, datahandle);
@@ -650,10 +619,8 @@ static void capi_recv_message(struct capi20_appl *ap, struct sk_buff *skb)
        }
        if (CAPIMSG_SUBCOMMAND(skb->data) == CAPI_IND) {
                datahandle = CAPIMSG_U16(skb->data, CAPIMSG_BASELEN+4+4+2);
-#ifdef _DEBUG_DATAFLOW
+                pr_debug("capi_signal: DATA_B3_IND %u len=%d\n",
-                printk(KERN_DEBUG "capi_signal: DATA_B3_IND %u len=%d\n",
+                         datahandle, skb->len-CAPIMSG_LEN(skb->data));
-                                datahandle, skb->len-CAPIMSG_LEN(skb->data));
-#endif
                skb_queue_tail(&mp->inqueue, skb);
                handle_minor_recv(mp);
@@ -661,11 +628,9 @@ static void capi_recv_message(struct capi20_appl *ap, struct sk_buff *skb)
        } else if (CAPIMSG_SUBCOMMAND(skb->data) == CAPI_CONF) {
                datahandle = CAPIMSG_U16(skb->data, CAPIMSG_BASELEN+4);
-#ifdef _DEBUG_DATAFLOW
+                pr_debug("capi_signal: DATA_B3_CONF %u 0x%x\n",
-                printk(KERN_DEBUG "capi_signal: DATA_B3_CONF %u 0x%x\n",
+                         datahandle,
-                                datahandle,
+                         CAPIMSG_U16(skb->data, CAPIMSG_BASELEN+4+2));
-                                CAPIMSG_U16(skb->data, CAPIMSG_BASELEN+4+2));
-#endif
                kfree_skb(skb);
                capiminor_del_ack(mp, datahandle);
                tty = tty_port_tty_get(&mp->port);
@@ -1095,9 +1060,7 @@ static int capinc_tty_write(struct tty_struct *tty,
        struct capiminor *mp = tty->driver_data;
        struct sk_buff *skb;
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_write(count=%d)\n", count);
-        printk(KERN_DEBUG "capinc_tty_write(count=%d)\n", count);
-#endif
        spin_lock_bh(&mp->outlock);
        skb = mp->outskb;
@@ -1133,9 +1096,7 @@ static int capinc_tty_put_char(struct tty_struct *tty, unsigned char ch)
        struct sk_buff *skb;
        int ret = 1;
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_put_char(%u)\n", ch);
-        printk(KERN_DEBUG "capinc_put_char(%u)\n", ch);
-#endif
        spin_lock_bh(&mp->outlock);
        skb = mp->outskb;
@@ -1174,9 +1135,7 @@ static void capinc_tty_flush_chars(struct tty_struct *tty)
        struct capiminor *mp = tty->driver_data;
        struct sk_buff *skb;
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_flush_chars\n");
-        printk(KERN_DEBUG "capinc_tty_flush_chars\n");
-#endif
        spin_lock_bh(&mp->outlock);
        skb = mp->outskb;
@@ -1200,9 +1159,7 @@ static int capinc_tty_write_room(struct tty_struct *tty)
        room = CAPINC_MAX_SENDQUEUE-skb_queue_len(&mp->outqueue);
        room *= CAPI_MAX_BLKSIZE;
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_write_room = %d\n", room);
-        printk(KERN_DEBUG "capinc_tty_write_room = %d\n", room);
-#endif
        return room;
 }
@@ -1210,12 +1167,10 @@ static int capinc_tty_chars_in_buffer(struct tty_struct *tty)
 {
        struct capiminor *mp = tty->driver_data;
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_chars_in_buffer = %d nack=%d sq=%d rq=%d\n",
-        printk(KERN_DEBUG "capinc_tty_chars_in_buffer = %d nack=%d sq=%d rq=%d\n",
+                 mp->outbytes, mp->nack,
-                        mp->outbytes, mp->nack,
+                 skb_queue_len(&mp->outqueue),
-                        skb_queue_len(&mp->outqueue),
+                 skb_queue_len(&mp->inqueue));
-                        skb_queue_len(&mp->inqueue));
-#endif
        return mp->outbytes;
 }
@@ -1227,17 +1182,13 @@ static int capinc_tty_ioctl(struct tty_struct *tty,
 static void capinc_tty_set_termios(struct tty_struct *tty, struct ktermios * old)
 {
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_set_termios\n");
-        printk(KERN_DEBUG "capinc_tty_set_termios\n");
-#endif
 }
 static void capinc_tty_throttle(struct tty_struct *tty)
 {
        struct capiminor *mp = tty->driver_data;
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_throttle\n");
-        printk(KERN_DEBUG "capinc_tty_throttle\n");
-#endif
        mp->ttyinstop = 1;
 }
@@ -1245,9 +1196,7 @@ static void capinc_tty_unthrottle(struct tty_struct *tty)
 {
        struct capiminor *mp = tty->driver_data;
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_unthrottle\n");
-        printk(KERN_DEBUG "capinc_tty_unthrottle\n");
-#endif
        mp->ttyinstop = 0;
        handle_minor_recv(mp);
 }
@@ -1256,9 +1205,7 @@ static void capinc_tty_stop(struct tty_struct *tty)
 {
        struct capiminor *mp = tty->driver_data;
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_stop\n");
-        printk(KERN_DEBUG "capinc_tty_stop\n");
-#endif
        mp->ttyoutstop = 1;
 }
@@ -1266,9 +1213,7 @@ static void capinc_tty_start(struct tty_struct *tty)
 {
        struct capiminor *mp = tty->driver_data;
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_start\n");
-        printk(KERN_DEBUG "capinc_tty_start\n");
-#endif
        mp->ttyoutstop = 0;
        handle_minor_send(mp);
 }
@@ -1277,39 +1222,29 @@ static void capinc_tty_hangup(struct tty_struct *tty)
 {
        struct capiminor *mp = tty->driver_data;
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_hangup\n");
-        printk(KERN_DEBUG "capinc_tty_hangup\n");
-#endif
        tty_port_hangup(&mp->port);
 }
 static int capinc_tty_break_ctl(struct tty_struct *tty, int state)
 {
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_break_ctl(%d)\n", state);
-        printk(KERN_DEBUG "capinc_tty_break_ctl(%d)\n", state);
-#endif
        return 0;
 }
 static void capinc_tty_flush_buffer(struct tty_struct *tty)
 {
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_flush_buffer\n");
-        printk(KERN_DEBUG "capinc_tty_flush_buffer\n");
-#endif
 }
 static void capinc_tty_set_ldisc(struct tty_struct *tty)
 {
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_set_ldisc\n");
-        printk(KERN_DEBUG "capinc_tty_set_ldisc\n");
-#endif
 }
 static void capinc_tty_send_xchar(struct tty_struct *tty, char ch)
 {
-#ifdef _DEBUG_TTYFUNCS
+        pr_debug("capinc_tty_send_xchar(%d)\n", ch);
-        printk(KERN_DEBUG "capinc_tty_send_xchar(%d)\n", ch);
-#endif
 }
 static const struct tty_operations capinc_ops = {
@@ -1514,10 +1449,8 @@ static int __init capi_init(void)
        proc_init();
-#if defined(CONFIG_ISDN_CAPI_CAPIFS) || defined(CONFIG_ISDN_CAPI_CAPIFS_MODULE)
+#ifdef CONFIG_ISDN_CAPI_MIDDLEWARE
-        compileinfo = " (middleware+capifs)";
+        compileinfo = " (middleware)";
-#elif defined(CONFIG_ISDN_CAPI_MIDDLEWARE)
-        compileinfo = " (no capifs)";
 #else
        compileinfo = " (no middleware)";
 #endif
diff --git a/drivers/isdn/capi/capifs.c b/drivers/isdn/capi/capifs.c
deleted file mode 100644
index b4faed7fe0d3..000000000000
--- a/drivers/isdn/capi/capifs.c
+++ /dev/null
@@ -1,239 +0,0 @@
-/* $Id: capifs.c,v 1.1.2.3 2004/01/16 21:09:26 keil Exp $
- * 
- * Copyright 2000 by Carsten Paeth <calle@calle.de>
- *
- * Heavily based on devpts filesystem from H. Peter Anvin
- * 
- * This software may be used and distributed according to the terms
- * of the GNU General Public License, incorporated herein by reference.
- *
- */
-#include <linux/fs.h>
-#include <linux/mount.h>
-#include <linux/slab.h>
-#include <linux/namei.h>
-#include <linux/module.h>
-#include <linux/init.h>
-#include <linux/ctype.h>
-#include <linux/sched.h>        /* current */
-#include "capifs.h"
-MODULE_DESCRIPTION("CAPI4Linux: /dev/capi/ filesystem");
-MODULE_AUTHOR("Carsten Paeth");
-MODULE_LICENSE("GPL");
-/* ------------------------------------------------------------------ */
-#define CAPIFS_SUPER_MAGIC (('C'<<8)|'N')
-static struct vfsmount *capifs_mnt;
-static int capifs_mnt_count;
-static struct {
-        int setuid;
-        int setgid;
-        uid_t   uid;
-        gid_t   gid;
-        umode_t mode;
-} config = {.mode = 0600};
-/* ------------------------------------------------------------------ */
-static int capifs_remount(struct super_block *s, int *flags, char *data)
-{
-        int setuid = 0;
-        int setgid = 0;
-        uid_t uid = 0;
-        gid_t gid = 0;
-        umode_t mode = 0600;
-        char *this_char;
-        char *new_opt = kstrdup(data, GFP_KERNEL);
-        this_char = NULL;
-        while ((this_char = strsep(&data, ",")) != NULL) {
-                int n;
-                char dummy;
-                if (!*this_char)
-                        continue;
-                if (sscanf(this_char, "uid=%i%c", &n, &dummy) == 1) {
-                        setuid = 1;
-                        uid = n;
-                } else if (sscanf(this_char, "gid=%i%c", &n, &dummy) == 1) {
-                        setgid = 1;
-                        gid = n;
-                } else if (sscanf(this_char, "mode=%o%c", &n, &dummy) == 1)
-                        mode = n & ~S_IFMT;
-                else {
-                        kfree(new_opt);
-                        printk("capifs: called with bogus options\n");
-                        return -EINVAL;
-                }
-        }
-        mutex_lock(&s->s_root->d_inode->i_mutex);
-        replace_mount_options(s, new_opt);
-        config.setuid  = setuid;
-        config.setgid  = setgid;
-        config.uid     = uid;
-        config.gid     = gid;
-        config.mode    = mode;
-        mutex_unlock(&s->s_root->d_inode->i_mutex);
-        return 0;
-}
-static const struct super_operations capifs_sops =
-{
-        .statfs         = simple_statfs,
-        .remount_fs     = capifs_remount,
-        .show_options   = generic_show_options,
-};
-static int
-capifs_fill_super(struct super_block *s, void *data, int silent)
-{
-        struct inode * inode;
-        s->s_blocksize = 1024;
-        s->s_blocksize_bits = 10;
-        s->s_magic = CAPIFS_SUPER_MAGIC;
-        s->s_op = &capifs_sops;
-        s->s_time_gran = 1;
-        inode = new_inode(s);
-        if (!inode)
-                goto fail;
-        inode->i_ino = 1;
-        inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
-        inode->i_mode = S_IFDIR | S_IRUGO | S_IXUGO | S_IWUSR;
-        inode->i_op = &simple_dir_inode_operations;
-        inode->i_fop = &simple_dir_operations;
-        inode->i_nlink = 2;
-        s->s_root = d_alloc_root(inode);
-        if (s->s_root)
-                return 0;
-        
-        printk("capifs: get root dentry failed\n");
-        iput(inode);
-fail:
-        return -ENOMEM;
-}
-static struct dentry *capifs_mount(struct file_system_type *fs_type,
-        int flags, const char *dev_name, void *data)
-{
-        return mount_single(fs_type, flags, data, capifs_fill_super);
-}
-static struct file_system_type capifs_fs_type = {
-        .owner          = THIS_MODULE,
-        .name           = "capifs",
-        .mount          = capifs_mount,
-        .kill_sb        = kill_anon_super,
-};
-static struct dentry *new_ncci(unsigned int number, dev_t device)
-{
-        struct super_block *s = capifs_mnt->mnt_sb;
-        struct dentry *root = s->s_root;
-        struct dentry *dentry;
-        struct inode *inode;
-        char name[10];
-        int namelen;
-        mutex_lock(&root->d_inode->i_mutex);
-        namelen = sprintf(name, "%d", number);
-        dentry = lookup_one_len(name, root, namelen);
-        if (IS_ERR(dentry)) {
-                dentry = NULL;
-                goto unlock_out;
-        }
-        if (dentry->d_inode) {
-                dput(dentry);
-                dentry = NULL;
-                goto unlock_out;
-        }
-        inode = new_inode(s);
-        if (!inode) {
-                dput(dentry);
-                dentry = NULL;
-                goto unlock_out;
-        }
-        /* config contents is protected by root's i_mutex */
-        inode->i_uid = config.setuid ? config.uid : current_fsuid();
-        inode->i_gid = config.setgid ? config.gid : current_fsgid();
-        inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
-        inode->i_ino = number + 2;
-        init_special_inode(inode, S_IFCHR|config.mode, device);
-        d_instantiate(dentry, inode);
-        dget(dentry);
-unlock_out:
-        mutex_unlock(&root->d_inode->i_mutex);
-        return dentry;
-}
-struct dentry *capifs_new_ncci(unsigned int number, dev_t device)
-{
-        struct dentry *dentry;
-        if (simple_pin_fs(&capifs_fs_type, &capifs_mnt, &capifs_mnt_count) < 0)
-                return NULL;
-        dentry = new_ncci(number, device);
-        if (!dentry)
-                simple_release_fs(&capifs_mnt, &capifs_mnt_count);
-        return dentry;
-}
-void capifs_free_ncci(struct dentry *dentry)
-{
-        struct dentry *root = capifs_mnt->mnt_sb->s_root;
-        struct inode *inode;
-        if (!dentry)
-                return;
-        mutex_lock(&root->d_inode->i_mutex);
-        inode = dentry->d_inode;
-        if (inode) {
-                drop_nlink(inode);
-                d_delete(dentry);
-                dput(dentry);
-        }
-        dput(dentry);
-        mutex_unlock(&root->d_inode->i_mutex);
-        simple_release_fs(&capifs_mnt, &capifs_mnt_count);
-}
-static int __init capifs_init(void)
-{
-        return register_filesystem(&capifs_fs_type);
-}
-static void __exit capifs_exit(void)
-{
-        unregister_filesystem(&capifs_fs_type);
-}
-EXPORT_SYMBOL(capifs_new_ncci);
-EXPORT_SYMBOL(capifs_free_ncci);
-module_init(capifs_init);
-module_exit(capifs_exit);
diff --git a/drivers/isdn/capi/capifs.h b/drivers/isdn/capi/capifs.h
deleted file mode 100644
index e193d1189531..000000000000
--- a/drivers/isdn/capi/capifs.h
+++ /dev/null
@@ -1,28 +0,0 @@
-/* $Id: capifs.h,v 1.1.2.2 2004/01/16 21:09:26 keil Exp $
- * 
- * Copyright 2000 by Carsten Paeth <calle@calle.de>
- *
- * This software may be used and distributed according to the terms
- * of the GNU General Public License, incorporated herein by reference.
- *
- */
-#include <linux/dcache.h>
-#if defined(CONFIG_ISDN_CAPI_CAPIFS) || defined(CONFIG_ISDN_CAPI_CAPIFS_MODULE)
-struct dentry *capifs_new_ncci(unsigned int num, dev_t device);
-void capifs_free_ncci(struct dentry *dentry);
-#else
-static inline struct dentry *capifs_new_ncci(unsigned int num, dev_t device)
-{
-        return NULL;
-}
-static inline void capifs_free_ncci(struct dentry *dentry)
-{
-}
-#endif
diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
index 8a3c5cfc4fea..3913f47ef86d 100644
--- a/drivers/isdn/gigaset/bas-gigaset.c
+++ b/drivers/isdn/gigaset/bas-gigaset.c
@@ -1157,7 +1157,6 @@ static void write_iso_tasklet(unsigned long data)
        struct urb *urb;
        int status;
        struct usb_iso_packet_descriptor *ifd;
-        int offset;
        unsigned long flags;
        int i;
        struct sk_buff *skb;
@@ -1225,7 +1224,6 @@ static void write_iso_tasklet(unsigned long data)
                         *   successfully sent
                         * - all following frames are not sent at all
                         */
-                        offset = done->limit;   /* default (no error) */
                        for (i = 0; i < BAS_NUMFRAMES; i++) {
                                ifd = &urb->iso_frame_desc[i];
                                if (ifd->status ||
@@ -1235,9 +1233,6 @@ static void write_iso_tasklet(unsigned long data)
                                                 i, ifd->actual_length,
                                                 ifd->length,
                                                 get_usb_statmsg(ifd->status));
-                                        offset = (ifd->offset +
-                                                  ifd->actual_length)
-                                                 % BAS_OUTBUFSIZE;
                                        break;
                                }
                        }
diff --git a/drivers/isdn/gigaset/ev-layer.c b/drivers/isdn/gigaset/ev-layer.c
index a14187605f5e..ba74646cf0e4 100644
--- a/drivers/isdn/gigaset/ev-layer.c
+++ b/drivers/isdn/gigaset/ev-layer.c
@@ -390,12 +390,12 @@ static const struct zsau_resp_t {
 */
 static int cid_of_response(char *s)
 {
-        unsigned long cid;
+        int cid;
        int rc;
        if (s[-1] != ';')
                return 0;       /* no CID separator */
-        rc = strict_strtoul(s, 10, &cid);
+        rc = kstrtoint(s, 10, &cid);
        if (rc)
                return 0;       /* CID not numeric */
        if (cid < 1 || cid > 65535)
@@ -566,27 +566,19 @@ void gigaset_handle_modem_response(struct cardstate *cs)
                case RT_ZCAU:
                        event->parameter = -1;
                        if (curarg + 1 < params) {
-                                unsigned long type, value;
+                                u8 type, value;
-                                i = strict_strtoul(argv[curarg++], 16, &type);
-                                j = strict_strtoul(argv[curarg++], 16, &value);
-                                if (i == 0 && type < 256 &&
+                                i = kstrtou8(argv[curarg++], 16, &type);
-                                    j == 0 && value < 256)
+                                j = kstrtou8(argv[curarg++], 16, &value);
+                                if (i == 0 && j == 0)
                                        event->parameter = (type << 8) | value;
                        } else
                                curarg = params - 1;
                        break;
                case RT_NUMBER:
-                        event->parameter = -1;
+                        if (curarg >= params ||
-                        if (curarg < params) {
+                            kstrtoint(argv[curarg++], 10, &event->parameter))
-                                unsigned long res;
+                                event->parameter = -1;
-                                int rc;
-                                rc = strict_strtoul(argv[curarg++], 10, &res);
-                                if (rc == 0)
-                                        event->parameter = res;
-                        }
                        gig_dbg(DEBUG_EVENT, "parameter==%d", event->parameter);
                        break;
                }
diff --git a/drivers/isdn/hardware/eicon/debug.c b/drivers/isdn/hardware/eicon/debug.c
index 362640120886..7a9894cb4557 100644
--- a/drivers/isdn/hardware/eicon/debug.c
+++ b/drivers/isdn/hardware/eicon/debug.c
@@ -861,7 +861,7 @@ static int diva_get_idi_adapter_info (IDI_CALL request, dword* serial, dword* lo
 void diva_mnt_add_xdi_adapter (const DESCRIPTOR* d) {
  diva_os_spin_lock_magic_t old_irql, old_irql1;
  dword sec, usec, logical, serial, org_mask;
-  int id, best_id = 0, free_id = -1;
+  int id, free_id = -1;
  char tmp[128];
  diva_dbg_entry_head_t* pmsg = NULL;
  int len;
@@ -906,7 +906,6 @@ void diva_mnt_add_xdi_adapter (const DESCRIPTOR* d) {
        and slot is still free - reuse it
        */
      free_id = id;
-      best_id = 1;
      break;
    }
  }
diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers/isdn/hardware/eicon/message.c
index 8c5c563c4f12..a3395986df3d 100644
--- a/drivers/isdn/hardware/eicon/message.c
+++ b/drivers/isdn/hardware/eicon/message.c
@@ -1198,7 +1198,6 @@ static byte connect_req(dword Id, word Number, DIVA_CAPI_ADAPTER *a,
  word ch;
  word i;
  word Info;
-  word CIP;
  byte LinkLayer;
  API_PARSE * ai;
  API_PARSE * bp;
@@ -1340,7 +1339,6 @@ static byte connect_req(dword Id, word Number, DIVA_CAPI_ADAPTER *a,
        add_s(plci,BC,&parms[6]);
        add_s(plci,LLC,&parms[7]);
        add_s(plci,HLC,&parms[8]);
-        CIP = GET_WORD(parms[0].info);
        if (a->Info_Mask[appl->Id-1] & 0x200)
        {
          /* early B3 connect (CIP mask bit 9) no release after a disc */
@@ -4830,7 +4828,6 @@ static void sig_ind(PLCI *plci)
  dword x_Id;
  dword Id;
  dword rId;
-  word Number = 0;
  word i;
  word cip;
  dword cip_mask;
@@ -5106,7 +5103,7 @@ static void sig_ind(PLCI *plci)
    }
  }
-  if(plci->appl) Number = plci->appl->Number++;
+  if(plci->appl) plci->appl->Number++;
  switch(plci->Sig.Ind) {
  /* Response to Get_Supported_Services request */
@@ -5894,7 +5891,6 @@ static void sig_ind(PLCI *plci)
    break;
  case TEL_CTRL:
-    Number = 0;
    ie = multi_fac_parms[0]; /* inspect the facility hook indications */
    if(plci->State==ADVANCED_VOICE_SIG && ie[0]){
      switch (ie[1]&0x91) {
@@ -10119,14 +10115,12 @@ static byte dtmf_request (dword Id, word Number, DIVA_CAPI_ADAPTER   *a, PLCI
 static void dtmf_confirmation (dword Id, PLCI   *plci)
 {
-  word Info;
  word i;
    byte result[4];
  dbug (1, dprintf ("[%06lx] %s,%d: dtmf_confirmation",
    UnMapId (Id), (char   *)(FILE_), __LINE__));
-  Info = GOOD;
  result[0] = 2;
  PUT_WORD (&result[1], DTMF_SUCCESS);
  if (plci->dtmf_send_requests != 0)
@@ -11520,13 +11514,12 @@ static word mixer_restore_config (dword Id, PLCI   *plci, byte Rc)
 static void mixer_command (dword Id, PLCI   *plci, byte Rc)
 {
  DIVA_CAPI_ADAPTER   *a;
-  word i, internal_command, Info;
+  word i, internal_command;
  dbug (1, dprintf ("[%06lx] %s,%d: mixer_command %02x %04x %04x",
    UnMapId (Id), (char   *)(FILE_), __LINE__, Rc, plci->internal_command,
    plci->li_cmd));
-  Info = GOOD;
  a = plci->adapter;
  internal_command = plci->internal_command;
  plci->internal_command = 0;
@@ -11550,7 +11543,6 @@ static void mixer_command (dword Id, PLCI   *plci, byte Rc)
        {
          dbug (1, dprintf ("[%06lx] %s,%d: Load mixer failed",
            UnMapId (Id), (char   *)(FILE_), __LINE__));
-          Info = _FACILITY_NOT_SUPPORTED;
          break;
        }
        if (plci->internal_command)
@@ -11592,7 +11584,6 @@ static void mixer_command (dword Id, PLCI   *plci, byte Rc)
            } while ((plci->li_plci_b_write_pos != plci->li_plci_b_req_pos)
              && !(plci->li_plci_b_queue[i] & LI_PLCI_B_LAST_FLAG));
          }
-          Info = _FACILITY_NOT_SUPPORTED;
          break;
        }
        if (plci->internal_command)
@@ -11610,7 +11601,6 @@ static void mixer_command (dword Id, PLCI   *plci, byte Rc)
        {
          dbug (1, dprintf ("[%06lx] %s,%d: Unload mixer failed",
            UnMapId (Id), (char   *)(FILE_), __LINE__));
-          Info = _FACILITY_NOT_SUPPORTED;
          break;
        }
        if (plci->internal_command)
@@ -12448,13 +12438,11 @@ static byte mixer_request (dword Id, word Number, DIVA_CAPI_ADAPTER   *a, PLCI
 static void mixer_indication_coefs_set (dword Id, PLCI   *plci)
 {
  dword d;
-  DIVA_CAPI_ADAPTER   *a;
    byte result[12];
  dbug (1, dprintf ("[%06lx] %s,%d: mixer_indication_coefs_set",
    UnMapId (Id), (char   *)(FILE_), __LINE__));
-  a = plci->adapter;
  if (plci->li_plci_b_read_pos != plci->li_plci_b_req_pos)
  {
    do
@@ -14111,13 +14099,11 @@ static void select_b_command (dword Id, PLCI   *plci, byte Rc)
 static void fax_connect_ack_command (dword Id, PLCI   *plci, byte Rc)
 {
-  word Info;
  word internal_command;
  dbug (1, dprintf ("[%06lx] %s,%d: fax_connect_ack_command %02x %04x",
    UnMapId (Id), (char   *)(FILE_), __LINE__, Rc, plci->internal_command));
-  Info = GOOD;
  internal_command = plci->internal_command;
  plci->internal_command = 0;
  switch (internal_command)
@@ -14160,13 +14146,11 @@ static void fax_connect_ack_command (dword Id, PLCI   *plci, byte Rc)
 static void fax_edata_ack_command (dword Id, PLCI   *plci, byte Rc)
 {
-  word Info;
  word internal_command;
  dbug (1, dprintf ("[%06lx] %s,%d: fax_edata_ack_command %02x %04x",
    UnMapId (Id), (char   *)(FILE_), __LINE__, Rc, plci->internal_command));
-  Info = GOOD;
  internal_command = plci->internal_command;
  plci->internal_command = 0;
  switch (internal_command)
@@ -14395,13 +14379,11 @@ static void rtp_connect_b3_req_command (dword Id, PLCI   *plci, byte Rc)
 static void rtp_connect_b3_res_command (dword Id, PLCI   *plci, byte Rc)
 {
-  word Info;
  word internal_command;
  dbug (1, dprintf ("[%06lx] %s,%d: rtp_connect_b3_res_command %02x %04x",
    UnMapId (Id), (char   *)(FILE_), __LINE__, Rc, plci->internal_command));
-  Info = GOOD;
  internal_command = plci->internal_command;
  plci->internal_command = 0;
  switch (internal_command)
@@ -14423,7 +14405,6 @@ static void rtp_connect_b3_res_command (dword Id, PLCI   *plci, byte Rc)
    {
      dbug (1, dprintf ("[%06lx] %s,%d: RTP setting connect resp info failed %02x",
        UnMapId (Id), (char   *)(FILE_), __LINE__, Rc));
-      Info = _WRONG_STATE;
      break;
    }
    if (plci_nl_busy (plci))
diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
index 4343abac0b13..b01a7be1300f 100644
--- a/drivers/isdn/hardware/mISDN/hfcpci.c
+++ b/drivers/isdn/hardware/mISDN/hfcpci.c
@@ -405,7 +405,7 @@ hfcpci_empty_bfifo(struct bchannel *bch, struct bzfifo *bz,
    u_char *bdata, int count)
 {
        u_char          *ptr, *ptr1, new_f2;
-        int             total, maxlen, new_z2;
+        int             maxlen, new_z2;
        struct zt       *zp;
        if ((bch->debug & DEBUG_HW_BCHANNEL) && !(bch->debug & DEBUG_HW_BFIFO))
@@ -431,7 +431,6 @@ hfcpci_empty_bfifo(struct bchannel *bch, struct bzfifo *bz,
                        printk(KERN_WARNING "HFCPCI: receive out of memory\n");
                        return;
                }
-                total = count;
                count -= 3;
                ptr = skb_put(bch->rx_skb, count);
@@ -968,7 +967,6 @@ static void
 ph_state_nt(struct dchannel *dch)
 {
        struct hfc_pci  *hc = dch->hw;
-        u_char  val;
        if (dch->debug)
                printk(KERN_DEBUG "%s: NT newstate %x\n",
@@ -982,7 +980,7 @@ ph_state_nt(struct dchannel *dch)
                        hc->hw.int_m1 &= ~HFCPCI_INTS_TIMER;
                        Write_hfc(hc, HFCPCI_INT_M1, hc->hw.int_m1);
                        /* Clear already pending ints */
-                        val = Read_hfc(hc, HFCPCI_INT_S1);
+                        (void) Read_hfc(hc, HFCPCI_INT_S1);
                        Write_hfc(hc, HFCPCI_STATES, 4 | HFCPCI_LOAD_STATE);
                        udelay(10);
                        Write_hfc(hc, HFCPCI_STATES, 4);
diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
index 8700474747e8..3ccbff13eaf2 100644
--- a/drivers/isdn/hardware/mISDN/hfcsusb.c
+++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
@@ -118,14 +118,12 @@ static void
 ctrl_complete(struct urb *urb)
 {
        struct hfcsusb *hw = (struct hfcsusb *) urb->context;
-        struct ctrl_buf *buf;
        if (debug & DBG_HFC_CALL_TRACE)
                printk(KERN_DEBUG "%s: %s\n", hw->name, __func__);
        urb->dev = hw->dev;
        if (hw->ctrl_cnt) {
-                buf = &hw->ctrl_buff[hw->ctrl_out_idx];
                hw->ctrl_cnt--; /* decrement actual count */
                if (++hw->ctrl_out_idx >= HFC_CTRL_BUFSIZE)
                        hw->ctrl_out_idx = 0;   /* pointer wrap */
@@ -1726,7 +1724,6 @@ hfcsusb_stop_endpoint(struct hfcsusb *hw, int channel)
 static int
 setup_hfcsusb(struct hfcsusb *hw)
 {
-        int err;
        u_char b;
        if (debug & DBG_HFC_CALL_TRACE)
@@ -1745,7 +1742,7 @@ setup_hfcsusb(struct hfcsusb *hw)
        }
        /* first set the needed config, interface and alternate */
-        err = usb_set_interface(hw->dev, hw->if_used, hw->alt_used);
+        (void) usb_set_interface(hw->dev, hw->if_used, hw->alt_used);
        hw->led_state = 0;
diff --git a/drivers/isdn/hisax/arcofi.c b/drivers/isdn/hisax/arcofi.c
index 85a8fd8dd0b7..21cbbe1d5563 100644
--- a/drivers/isdn/hisax/arcofi.c
+++ b/drivers/isdn/hisax/arcofi.c
@@ -30,8 +30,6 @@ add_arcofi_timer(struct IsdnCardState *cs) {
 static void
 send_arcofi(struct IsdnCardState *cs) {
-        u_char val;
-        
        add_arcofi_timer(cs);
        cs->dc.isac.mon_txp = 0;
        cs->dc.isac.mon_txc = cs->dc.isac.arcofi_list->len;
@@ -45,7 +43,7 @@ send_arcofi(struct IsdnCardState *cs) {
        cs->dc.isac.mocr &= 0x0f;
        cs->dc.isac.mocr |= 0xa0;
        cs->writeisac(cs, ISAC_MOCR, cs->dc.isac.mocr);
-        val = cs->readisac(cs, ISAC_MOSR);
+        (void) cs->readisac(cs, ISAC_MOSR);
        cs->writeisac(cs, ISAC_MOX1, cs->dc.isac.mon_tx[cs->dc.isac.mon_txp++]);
        cs->dc.isac.mocr |= 0x10;
        cs->writeisac(cs, ISAC_MOCR, cs->dc.isac.mocr);
diff --git a/drivers/isdn/hisax/elsa_cs.c b/drivers/isdn/hisax/elsa_cs.c
index 496d477af0f8..9e5e87be756b 100644
--- a/drivers/isdn/hisax/elsa_cs.c
+++ b/drivers/isdn/hisax/elsa_cs.c
@@ -129,12 +129,10 @@ static int elsa_cs_configcheck(struct pcmcia_device *p_dev, void *priv_data)
 static int __devinit elsa_cs_config(struct pcmcia_device *link)
 {
-    local_info_t *dev;
    int i;
    IsdnCard_t icard;
    dev_dbg(&link->dev, "elsa_config(0x%p)\n", link);
-    dev = link->priv;
    link->config_flags |= CONF_ENABLE_IRQ | CONF_AUTO_SET_IO;
diff --git a/drivers/isdn/hisax/elsa_ser.c b/drivers/isdn/hisax/elsa_ser.c
index cbda3790a10d..3fa9f6171095 100644
--- a/drivers/isdn/hisax/elsa_ser.c
+++ b/drivers/isdn/hisax/elsa_ser.c
@@ -109,11 +109,10 @@ static void change_speed(struct IsdnCardState *cs, int baud)
 {
        int     quot = 0, baud_base;
        unsigned cval, fcr = 0;
-        int     bits;
        /* byte size and parity */
-        cval = 0x03; bits = 10;
+        cval = 0x03;
        /* Determine divisor based on baud rate */
        baud_base = BASE_BAUD;
        quot = baud_base / baud;
diff --git a/drivers/isdn/hisax/hfc_usb.c b/drivers/isdn/hisax/hfc_usb.c
index ed9527aa5f2c..f407de0e006d 100644
--- a/drivers/isdn/hisax/hfc_usb.c
+++ b/drivers/isdn/hisax/hfc_usb.c
@@ -258,11 +258,9 @@ static void
 ctrl_complete(struct urb *urb)
 {
        hfcusb_data *hfc = (hfcusb_data *) urb->context;
-        ctrl_buft *buf;
        urb->dev = hfc->dev;
        if (hfc->ctrl_cnt) {
-                buf = &hfc->ctrl_buff[hfc->ctrl_out_idx];
                hfc->ctrl_cnt--;        /* decrement actual count */
                if (++hfc->ctrl_out_idx >= HFC_CTRL_BUFSIZE)
                        hfc->ctrl_out_idx = 0;  /* pointer wrap */
@@ -1097,7 +1095,7 @@ static int
 hfc_usb_init(hfcusb_data * hfc)
 {
        usb_fifo *fifo;
-        int i, err;
+        int i;
        u_char b;
        struct hisax_b_if *p_b_if[2];
@@ -1112,7 +1110,7 @@ hfc_usb_init(hfcusb_data * hfc)
        }
        /* first set the needed config, interface and alternate */
-        err = usb_set_interface(hfc->dev, hfc->if_used, hfc->alt_used);
+        usb_set_interface(hfc->dev, hfc->if_used, hfc->alt_used);
        /* do Chip reset */
        write_usb(hfc, HFCUSB_CIRM, 8);
diff --git a/drivers/isdn/hisax/ipacx.c b/drivers/isdn/hisax/ipacx.c
index 332104103e18..690840444184 100644
--- a/drivers/isdn/hisax/ipacx.c
+++ b/drivers/isdn/hisax/ipacx.c
@@ -96,7 +96,7 @@ dch_l2l1(struct PStack *st, int pr, void *arg)
 {
        struct IsdnCardState *cs = (struct IsdnCardState *) st->l1.hardware;
        struct sk_buff *skb = arg;
-  u_char cda1_cr, cda2_cr;
+        u_char cda1_cr;
        switch (pr) {
                case (PH_DATA |REQUEST):
@@ -163,7 +163,7 @@ dch_l2l1(struct PStack *st, int pr, void *arg)
      cs->writeisac(cs, IPACX_CDA_TSDP10, 0x80); // Timeslot 0 is B1
      cs->writeisac(cs, IPACX_CDA_TSDP11, 0x81); // Timeslot 0 is B1
      cda1_cr = cs->readisac(cs, IPACX_CDA1_CR);
-      cda2_cr = cs->readisac(cs, IPACX_CDA2_CR);
+      (void) cs->readisac(cs, IPACX_CDA2_CR);
                        if ((long)arg &1) { // loop B1
        cs->writeisac(cs, IPACX_CDA1_CR, cda1_cr |0x0a); 
      }
diff --git a/drivers/isdn/hisax/jade.c b/drivers/isdn/hisax/jade.c
index ea8f840871d0..a06cea09158b 100644
--- a/drivers/isdn/hisax/jade.c
+++ b/drivers/isdn/hisax/jade.c
@@ -23,10 +23,9 @@
 int
 JadeVersion(struct IsdnCardState *cs, char *s)
 {
-    int ver,i;
+    int ver;
    int to = 50;
    cs->BC_Write_Reg(cs, -1, 0x50, 0x19);
-    i=0;
    while (to) {
        udelay(1);
        ver = cs->BC_Read_Reg(cs, -1, 0x60);
diff --git a/drivers/isdn/hisax/l3dss1.c b/drivers/isdn/hisax/l3dss1.c
index 8e2fd02ecce0..b0d9ab1f21c0 100644
--- a/drivers/isdn/hisax/l3dss1.c
+++ b/drivers/isdn/hisax/l3dss1.c
@@ -2943,7 +2943,7 @@ global_handler(struct PStack *st, int mt, struct sk_buff *skb)
 static void
 dss1up(struct PStack *st, int pr, void *arg)
 {
-        int i, mt, cr, cause, callState;
+        int i, mt, cr, callState;
        char *ptr;
        u_char *p;
        struct sk_buff *skb = arg;
@@ -3034,12 +3034,10 @@ dss1up(struct PStack *st, int pr, void *arg)
                                return;
                        }
                } else if (mt == MT_STATUS) {
-                        cause = 0;
                        if ((ptr = findie(skb->data, skb->len, IE_CAUSE, 0)) != NULL) {
                                ptr++;
                                if (*ptr++ == 2)
                                        ptr++;
-                                cause = *ptr & 0x7f;
                        }
                        callState = 0;
                        if ((ptr = findie(skb->data, skb->len, IE_CALL_STATE, 0)) != NULL) {
diff --git a/drivers/isdn/hisax/l3ni1.c b/drivers/isdn/hisax/l3ni1.c
index 7b229c0ce115..092dcbb39d94 100644
--- a/drivers/isdn/hisax/l3ni1.c
+++ b/drivers/isdn/hisax/l3ni1.c
@@ -2883,7 +2883,7 @@ global_handler(struct PStack *st, int mt, struct sk_buff *skb)
 static void
 ni1up(struct PStack *st, int pr, void *arg)
 {
-        int i, mt, cr, cause, callState;
+        int i, mt, cr, callState;
        char *ptr;
        u_char *p;
        struct sk_buff *skb = arg;
@@ -2986,12 +2986,10 @@ ni1up(struct PStack *st, int pr, void *arg)
                                return;
                        }
                } else if (mt == MT_STATUS) {
-                        cause = 0;
                        if ((ptr = findie(skb->data, skb->len, IE_CAUSE, 0)) != NULL) {
                                ptr++;
                                if (*ptr++ == 2)
                                        ptr++;
-                                cause = *ptr & 0x7f;
                        }
                        callState = 0;
                        if ((ptr = findie(skb->data, skb->len, IE_CALL_STATE, 0)) != NULL) {
diff --git a/drivers/isdn/hisax/st5481.h b/drivers/isdn/hisax/st5481.h
index 64f78a8c28c5..b9054cb7a0da 100644
--- a/drivers/isdn/hisax/st5481.h
+++ b/drivers/isdn/hisax/st5481.h
@@ -377,7 +377,6 @@ struct st5481_bcs {
 };
 struct st5481_adapter {
-        struct list_head list;
        int number_of_leds;
        struct usb_device *usb_dev;
        struct hisax_d_if hisax_d_if;
diff --git a/drivers/isdn/hisax/st5481_init.c b/drivers/isdn/hisax/st5481_init.c
index 13751237bfcd..9f7fd18ff773 100644
--- a/drivers/isdn/hisax/st5481_init.c
+++ b/drivers/isdn/hisax/st5481_init.c
@@ -46,8 +46,6 @@ module_param(debug, int, 0);
 #endif
 int st5481_debug;
-static LIST_HEAD(adapter_list);
 /* ======================================================================
 * registration/deregistration with the USB layer
 */
@@ -86,7 +84,6 @@ static int probe_st5481(struct usb_interface *intf,
                adapter->bcs[i].b_if.ifc.priv = &adapter->bcs[i];
                adapter->bcs[i].b_if.ifc.l2l1 = st5481_b_l2l1;
        }
-        list_add(&adapter->list, &adapter_list);
        retval = st5481_setup_usb(adapter);
        if (retval < 0)
@@ -125,6 +122,7 @@ static int probe_st5481(struct usb_interface *intf,
 err_usb:
        st5481_release_usb(adapter);
 err:
+        kfree(adapter);
        return -EIO;
 }
@@ -142,8 +140,6 @@ static void disconnect_st5481(struct usb_interface *intf)
        if (!adapter)
                return;
        
-        list_del(&adapter->list);
        st5481_stop(adapter);
        st5481_release_b(&adapter->bcs[1]);
        st5481_release_b(&adapter->bcs[0]);
diff --git a/drivers/isdn/hisax/teles_cs.c b/drivers/isdn/hisax/teles_cs.c
index aa25e183bf79..360f9ec7c802 100644
--- a/drivers/isdn/hisax/teles_cs.c
+++ b/drivers/isdn/hisax/teles_cs.c
@@ -111,12 +111,10 @@ static int teles_cs_configcheck(struct pcmcia_device *p_dev, void *priv_data)
 static int __devinit teles_cs_config(struct pcmcia_device *link)
 {
-    local_info_t *dev;
    int i;
    IsdnCard_t icard;
    dev_dbg(&link->dev, "teles_config(0x%p)\n", link);
-    dev = link->priv;
    i = pcmcia_loop_config(link, teles_cs_configcheck, NULL);
    if (i != 0)
diff --git a/drivers/isdn/hysdn/hysdn_proclog.c b/drivers/isdn/hysdn/hysdn_proclog.c
index 2ee93d04b2dd..236cc7dadfd0 100644
--- a/drivers/isdn/hysdn/hysdn_proclog.c
+++ b/drivers/isdn/hysdn/hysdn_proclog.c
@@ -155,7 +155,6 @@ put_log_buffer(hysdn_card * card, char *cp)
 static ssize_t
 hysdn_log_write(struct file *file, const char __user *buf, size_t count, loff_t * off)
 {
-        unsigned long u = 0;
        int rc;
        unsigned char valbuf[128];
        hysdn_card *card = file->private_data;
@@ -167,12 +166,10 @@ hysdn_log_write(struct file *file, const char __user *buf, size_t count, loff_t
        valbuf[count] = 0;      /* terminating 0 */
-        rc = strict_strtoul(valbuf, 0, &u);
+        rc = kstrtoul(valbuf, 0, &card->debug_flags);
+        if (rc < 0)
-        if (rc == 0) {
+                return rc;
-                card->debug_flags = u;  /* remember debug flags */
+        hysdn_addlog(card, "debug set to 0x%lx", card->debug_flags);
-                hysdn_addlog(card, "debug set to 0x%lx", card->debug_flags);
-        }
        return (count);
 }                               /* hysdn_log_write */
diff --git a/drivers/isdn/i4l/isdn_common.c b/drivers/isdn/i4l/isdn_common.c
index 15632bd2f643..6ed82add6ffa 100644
--- a/drivers/isdn/i4l/isdn_common.c
+++ b/drivers/isdn/i4l/isdn_common.c
@@ -399,13 +399,8 @@ isdn_all_eaz(int di, int ch)
 #include <linux/isdn/capicmd.h>
 static int
-isdn_capi_rec_hl_msg(capi_msg *cm) {
+isdn_capi_rec_hl_msg(capi_msg *cm)
-        
+{
-        int di;
-        int ch;
-        
-        di = (cm->adr.Controller & 0x7f) -1;
-        ch = isdn_dc2minor(di, (cm->adr.Controller>>8)& 0x7f);
        switch(cm->Command) {
                case CAPI_FACILITY:
                        /* in the moment only handled in tty */
@@ -1278,7 +1273,6 @@ isdn_ioctl(struct file *file, uint cmd, ulong arg)
        uint minor = iminor(file->f_path.dentry->d_inode);
        isdn_ctrl c;
        int drvidx;
-        int chidx;
        int ret;
        int i;
        char __user *p;
@@ -1340,7 +1334,6 @@ isdn_ioctl(struct file *file, uint cmd, ulong arg)
                drvidx = isdn_minor2drv(minor);
                if (drvidx < 0)
                        return -ENODEV;
-                chidx = isdn_minor2chan(minor);
                if (!(dev->drv[drvidx]->flags & DRV_FLAG_RUNNING))
                        return -ENODEV;
                return 0;
diff --git a/drivers/isdn/i4l/isdn_net.c b/drivers/isdn/i4l/isdn_net.c
index 2a7d17c19489..97988111e45a 100644
--- a/drivers/isdn/i4l/isdn_net.c
+++ b/drivers/isdn/i4l/isdn_net.c
@@ -1678,7 +1678,6 @@ isdn_net_ciscohdlck_slarp_in(isdn_net_local *lp, struct sk_buff *skb)
        u32 your_seq;
        __be32 local;
        __be32 *addr, *mask;
-        u16 unused;
        if (skb->len < 14)
                return;
@@ -1722,7 +1721,6 @@ isdn_net_ciscohdlck_slarp_in(isdn_net_local *lp, struct sk_buff *skb)
                lp->cisco_last_slarp_in = jiffies;
                my_seq = be32_to_cpup((__be32 *)(p + 0));
                your_seq = be32_to_cpup((__be32 *)(p + 4));
-                unused = be16_to_cpup((__be16 *)(p + 8));
                p += 10;
                lp->cisco_yourseq = my_seq;
                lp->cisco_mineseen = your_seq;
diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c
index 607d846ae063..d8504279e502 100644
--- a/drivers/isdn/i4l/isdn_tty.c
+++ b/drivers/isdn/i4l/isdn_tty.c
@@ -998,7 +998,6 @@ isdn_tty_change_speed(modem_info * info)
 {
        uint cflag,
         cval,
-         fcr,
         quot;
        int i;
@@ -1037,7 +1036,6 @@ isdn_tty_change_speed(modem_info * info)
                cval |= UART_LCR_PARITY;
        if (!(cflag & PARODD))
                cval |= UART_LCR_EPAR;
-        fcr = 0;
        /* CTS flow control flag and modem status interrupts */
        if (cflag & CRTSCTS) {
diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
index d0aeb44ee7c0..5bc00156315e 100644
--- a/drivers/isdn/mISDN/layer2.c
+++ b/drivers/isdn/mISDN/layer2.c
@@ -1640,7 +1640,7 @@ l2_tei_remove(struct FsmInst *fi, int event, void *arg)
 }
 static void
-l2_st14_persistant_da(struct FsmInst *fi, int event, void *arg)
+l2_st14_persistent_da(struct FsmInst *fi, int event, void *arg)
 {
        struct layer2 *l2 = fi->userdata;
        struct sk_buff *skb = arg;
@@ -1654,7 +1654,7 @@ l2_st14_persistant_da(struct FsmInst *fi, int event, void *arg)
 }
 static void
-l2_st5_persistant_da(struct FsmInst *fi, int event, void *arg)
+l2_st5_persistent_da(struct FsmInst *fi, int event, void *arg)
 {
        struct layer2 *l2 = fi->userdata;
        struct sk_buff *skb = arg;
@@ -1671,7 +1671,7 @@ l2_st5_persistant_da(struct FsmInst *fi, int event, void *arg)
 }
 static void
-l2_st6_persistant_da(struct FsmInst *fi, int event, void *arg)
+l2_st6_persistent_da(struct FsmInst *fi, int event, void *arg)
 {
        struct layer2 *l2 = fi->userdata;
        struct sk_buff *skb = arg;
@@ -1685,7 +1685,7 @@ l2_st6_persistant_da(struct FsmInst *fi, int event, void *arg)
 }
 static void
-l2_persistant_da(struct FsmInst *fi, int event, void *arg)
+l2_persistent_da(struct FsmInst *fi, int event, void *arg)
 {
        struct layer2 *l2 = fi->userdata;
        struct sk_buff *skb = arg;
@@ -1829,14 +1829,14 @@ static struct FsmNode L2FnList[] =
        {ST_L2_6, EV_L2_FRAME_ERROR, l2_frame_error},
        {ST_L2_7, EV_L2_FRAME_ERROR, l2_frame_error_reest},
        {ST_L2_8, EV_L2_FRAME_ERROR, l2_frame_error_reest},
-        {ST_L2_1, EV_L1_DEACTIVATE, l2_st14_persistant_da},
+        {ST_L2_1, EV_L1_DEACTIVATE, l2_st14_persistent_da},
        {ST_L2_2, EV_L1_DEACTIVATE, l2_st24_tei_remove},
        {ST_L2_3, EV_L1_DEACTIVATE, l2_st3_tei_remove},
-        {ST_L2_4, EV_L1_DEACTIVATE, l2_st14_persistant_da},
+        {ST_L2_4, EV_L1_DEACTIVATE, l2_st14_persistent_da},
-        {ST_L2_5, EV_L1_DEACTIVATE, l2_st5_persistant_da},
+        {ST_L2_5, EV_L1_DEACTIVATE, l2_st5_persistent_da},
-        {ST_L2_6, EV_L1_DEACTIVATE, l2_st6_persistant_da},
+        {ST_L2_6, EV_L1_DEACTIVATE, l2_st6_persistent_da},
-        {ST_L2_7, EV_L1_DEACTIVATE, l2_persistant_da},
+        {ST_L2_7, EV_L1_DEACTIVATE, l2_persistent_da},
-        {ST_L2_8, EV_L1_DEACTIVATE, l2_persistant_da},
+        {ST_L2_8, EV_L1_DEACTIVATE, l2_persistent_da},
 };
 static int
diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c
index 7446d8b4282d..8e325227b4c0 100644
--- a/drivers/isdn/mISDN/socket.c
+++ b/drivers/isdn/mISDN/socket.c
@@ -457,6 +457,9 @@ static int data_sock_getsockopt(struct socket *sock, int level, int optname,
        if (get_user(len, optlen))
                return -EFAULT;
+        if (len != sizeof(char))
+                return -EINVAL;
        switch (optname) {
        case MISDN_TIME_STAMP:
                if (_pms(sk)->cmask & MISDN_TIME_STAMP)
diff --git a/drivers/net/3c509.c b/drivers/net/3c509.c
index 91abb965fb44..5f25889e27ef 100644
--- a/drivers/net/3c509.c
+++ b/drivers/net/3c509.c
@@ -185,7 +185,7 @@ static int max_interrupt_work = 10;
 static int nopnp;
 #endif
-static int __devinit el3_common_init(struct net_device *dev);
+static int el3_common_init(struct net_device *dev);
 static void el3_common_remove(struct net_device *dev);
 static ushort id_read_eeprom(int index);
 static ushort read_eeprom(int ioaddr, int index);
@@ -395,7 +395,7 @@ static struct isa_driver el3_isa_driver = {
 static int isa_registered;
 #ifdef CONFIG_PNP
-static struct pnp_device_id el3_pnp_ids[] = {
+static const struct pnp_device_id el3_pnp_ids[] __devinitconst = {
        { .id = "TCM5090" }, /* 3Com Etherlink III (TP) */
        { .id = "TCM5091" }, /* 3Com Etherlink III */
        { .id = "TCM5094" }, /* 3Com Etherlink III (combo) */
@@ -478,7 +478,7 @@ static int pnp_registered;
 #endif /* CONFIG_PNP */
 #ifdef CONFIG_EISA
-static struct eisa_device_id el3_eisa_ids[] = {
+static const struct eisa_device_id el3_eisa_ids[] __devinitconst = {
                { "TCM5090" },
                { "TCM5091" },
                { "TCM5092" },
@@ -508,7 +508,7 @@ static int eisa_registered;
 #ifdef CONFIG_MCA
 static int el3_mca_probe(struct device *dev);
-static short el3_mca_adapter_ids[] __initdata = {
+static const short el3_mca_adapter_ids[] __devinitconst = {
                0x627c,
                0x627d,
                0x62db,
@@ -517,7 +517,7 @@ static short el3_mca_adapter_ids[] __initdata = {
                0x0000
 };
-static char *el3_mca_adapter_names[] __initdata = {
+static const char *const el3_mca_adapter_names[] __devinitconst = {
                "3Com 3c529 EtherLink III (10base2)",
                "3Com 3c529 EtherLink III (10baseT)",
                "3Com 3c529 EtherLink III (test mode)",
@@ -601,7 +601,7 @@ static void el3_common_remove (struct net_device *dev)
 }
 #ifdef CONFIG_MCA
-static int __init el3_mca_probe(struct device *device)
+static int __devinit el3_mca_probe(struct device *device)
 {
        /* Based on Erik Nygren's (nygren@mit.edu) 3c529 patch,
         * heavily modified by Chris Beauregard
@@ -671,7 +671,7 @@ static int __init el3_mca_probe(struct device *device)
 #endif /* CONFIG_MCA */
 #ifdef CONFIG_EISA
-static int __init el3_eisa_probe (struct device *device)
+static int __devinit el3_eisa_probe (struct device *device)
 {
        short i;
        int ioaddr, irq, if_port;
@@ -1207,7 +1207,7 @@ el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
                        ecmd->duplex = DUPLEX_FULL;
        }
-        ecmd->speed = SPEED_10;
+        ethtool_cmd_speed_set(ecmd, SPEED_10);
        EL3WINDOW(1);
        return 0;
 }
diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
index 8cc22568ebd3..99f43d275442 100644
--- a/drivers/net/3c59x.c
+++ b/drivers/net/3c59x.c
@@ -901,14 +901,14 @@ static const struct dev_pm_ops vortex_pm_ops = {
 #endif /* !CONFIG_PM */
 #ifdef CONFIG_EISA
-static struct eisa_device_id vortex_eisa_ids[] = {
+static const struct eisa_device_id vortex_eisa_ids[] __devinitconst = {
        { "TCM5920", CH_3C592 },
        { "TCM5970", CH_3C597 },
        { "" }
 };
 MODULE_DEVICE_TABLE(eisa, vortex_eisa_ids);
-static int __init vortex_eisa_probe(struct device *device)
+static int __devinit vortex_eisa_probe(struct device *device)
 {
        void __iomem *ioaddr;
        struct eisa_device *edev;
diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c
index dd16e83933a2..10c45051caea 100644
--- a/drivers/net/8139cp.c
+++ b/drivers/net/8139cp.c
@@ -758,8 +758,7 @@ static netdev_tx_t cp_start_xmit (struct sk_buff *skb,
        entry = cp->tx_head;
        eor = (entry == (CP_TX_RING_SIZE - 1)) ? RingEnd : 0;
-        if (dev->features & NETIF_F_TSO)
+        mss = skb_shinfo(skb)->gso_size;
-                mss = skb_shinfo(skb)->gso_size;
        if (skb_shinfo(skb)->nr_frags == 0) {
                struct cp_desc *txd = &cp->tx_ring[entry];
@@ -1416,32 +1415,23 @@ static void cp_set_msglevel(struct net_device *dev, u32 value)
        cp->msg_enable = value;
 }
-static u32 cp_get_rx_csum(struct net_device *dev)
+static int cp_set_features(struct net_device *dev, u32 features)
 {
        struct cp_private *cp = netdev_priv(dev);
-        return (cpr16(CpCmd) & RxChkSum) ? 1 : 0;
+        unsigned long flags;
-}
-static int cp_set_rx_csum(struct net_device *dev, u32 data)
+        if (!((dev->features ^ features) & NETIF_F_RXCSUM))
-{
+                return 0;
-        struct cp_private *cp = netdev_priv(dev);
-        u16 cmd = cp->cpcmd, newcmd;
-        newcmd = cmd;
+        spin_lock_irqsave(&cp->lock, flags);
-        if (data)
+        if (features & NETIF_F_RXCSUM)
-                newcmd |= RxChkSum;
+                cp->cpcmd |= RxChkSum;
        else
-                newcmd &= ~RxChkSum;
+                cp->cpcmd &= ~RxChkSum;
-        if (newcmd != cmd) {
-                unsigned long flags;
-                spin_lock_irqsave(&cp->lock, flags);
+        cpw16_f(CpCmd, cp->cpcmd);
-                cp->cpcmd = newcmd;
+        spin_unlock_irqrestore(&cp->lock, flags);
-                cpw16_f(CpCmd, newcmd);
-                spin_unlock_irqrestore(&cp->lock, flags);
-        }
        return 0;
 }
@@ -1554,11 +1544,6 @@ static const struct ethtool_ops cp_ethtool_ops = {
        .get_link               = ethtool_op_get_link,
        .get_msglevel           = cp_get_msglevel,
        .set_msglevel           = cp_set_msglevel,
-        .get_rx_csum            = cp_get_rx_csum,
-        .set_rx_csum            = cp_set_rx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_csum, /* local! */
-        .set_sg                 = ethtool_op_set_sg,
-        .set_tso                = ethtool_op_set_tso,
        .get_regs               = cp_get_regs,
        .get_wol                = cp_get_wol,
        .set_wol                = cp_set_wol,
@@ -1831,6 +1816,7 @@ static const struct net_device_ops cp_netdev_ops = {
        .ndo_do_ioctl           = cp_ioctl,
        .ndo_start_xmit         = cp_start_xmit,
        .ndo_tx_timeout         = cp_tx_timeout,
+        .ndo_set_features       = cp_set_features,
 #if CP_VLAN_TAG_USED
        .ndo_vlan_rx_register   = cp_vlan_rx_register,
 #endif
@@ -1934,6 +1920,9 @@ static int cp_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
        cp->cpcmd = (pci_using_dac ? PCIDAC : 0) |
                    PCIMulRW | RxChkSum | CpRxOn | CpTxOn;
+        dev->features |= NETIF_F_RXCSUM;
+        dev->hw_features |= NETIF_F_RXCSUM;
        regs = ioremap(pciaddr, CP_REGS_SIZE);
        if (!regs) {
                rc = -EIO;
@@ -1966,9 +1955,8 @@ static int cp_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
        if (pci_using_dac)
                dev->features |= NETIF_F_HIGHDMA;
-#if 0 /* disabled by default until verified */
+        /* disabled by default until verified */
-        dev->features |= NETIF_F_TSO;
+        dev->hw_features |= NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO;
-#endif
        dev->irq = pdev->irq;
diff --git a/drivers/net/acenic.c b/drivers/net/acenic.c
index 01560bb67a7a..d7c1bfe4b6ec 100644
--- a/drivers/net/acenic.c
+++ b/drivers/net/acenic.c
@@ -2659,15 +2659,15 @@ static int ace_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
        link = readl(&regs->GigLnkState);
        if (link & LNK_1000MB)
-                ecmd->speed = SPEED_1000;
+                ethtool_cmd_speed_set(ecmd, SPEED_1000);
        else {
                link = readl(&regs->FastLnkState);
                if (link & LNK_100MB)
-                        ecmd->speed = SPEED_100;
+                        ethtool_cmd_speed_set(ecmd, SPEED_100);
                else if (link & LNK_10MB)
-                        ecmd->speed = SPEED_10;
+                        ethtool_cmd_speed_set(ecmd, SPEED_10);
                else
-                        ecmd->speed = 0;
+                        ethtool_cmd_speed_set(ecmd, 0);
        }
        if (link & LNK_FULL_DUPLEX)
                ecmd->duplex = DUPLEX_FULL;
@@ -2719,9 +2719,9 @@ static int ace_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                link |= LNK_TX_FLOW_CTL_Y;
        if (ecmd->autoneg == AUTONEG_ENABLE)
                link |= LNK_NEGOTIATE;
-        if (ecmd->speed != speed) {
+        if (ethtool_cmd_speed(ecmd) != speed) {
                link &= ~(LNK_1000MB | LNK_100MB | LNK_10MB);
-                switch (speed) {
+                switch (ethtool_cmd_speed(ecmd)) {
                case SPEED_1000:
                        link |= LNK_1000MB;
                        break;
diff --git a/drivers/net/arm/etherh.c b/drivers/net/arm/etherh.c
index fbfb5b47c506..03e217a868d4 100644
--- a/drivers/net/arm/etherh.c
+++ b/drivers/net/arm/etherh.c
@@ -591,10 +591,11 @@ static void etherh_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *i
 static int etherh_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        cmd->supported  = etherh_priv(dev)->supported;
-        cmd->speed      = SPEED_10;
+        ethtool_cmd_speed_set(cmd, SPEED_10);
        cmd->duplex     = DUPLEX_HALF;
        cmd->port       = dev->if_port == IF_PORT_10BASET ? PORT_TP : PORT_BNC;
-        cmd->autoneg    = dev->flags & IFF_AUTOMEDIA ? AUTONEG_ENABLE : AUTONEG_DISABLE;
+        cmd->autoneg    = (dev->flags & IFF_AUTOMEDIA ?
+                           AUTONEG_ENABLE : AUTONEG_DISABLE);
        return 0;
 }
diff --git a/drivers/net/arm/ks8695net.c b/drivers/net/arm/ks8695net.c
index aa07657744c3..a7b0caa18179 100644
--- a/drivers/net/arm/ks8695net.c
+++ b/drivers/net/arm/ks8695net.c
@@ -891,15 +891,16 @@ ks8695_wan_get_settings(struct net_device *ndev, struct ethtool_cmd *cmd)
                        cmd->advertising |= ADVERTISED_Pause;
                cmd->autoneg = AUTONEG_ENABLE;
-                cmd->speed = (ctrl & WMC_WSS) ? SPEED_100 : SPEED_10;
+                ethtool_cmd_speed_set(cmd,
+                                      (ctrl & WMC_WSS) ? SPEED_100 : SPEED_10);
                cmd->duplex = (ctrl & WMC_WDS) ?
                        DUPLEX_FULL : DUPLEX_HALF;
        } else {
                /* auto-negotiation is disabled */
                cmd->autoneg = AUTONEG_DISABLE;
-                cmd->speed = (ctrl & WMC_WANF100) ?
+                ethtool_cmd_speed_set(cmd, ((ctrl & WMC_WANF100) ?
-                        SPEED_100 : SPEED_10;
+                                            SPEED_100 : SPEED_10));
                cmd->duplex = (ctrl & WMC_WANFF) ?
                        DUPLEX_FULL : DUPLEX_HALF;
        }
diff --git a/drivers/net/atl1c/atl1c_ethtool.c b/drivers/net/atl1c/atl1c_ethtool.c
index 7c521508313c..7be884d0aaf6 100644
--- a/drivers/net/atl1c/atl1c_ethtool.c
+++ b/drivers/net/atl1c/atl1c_ethtool.c
@@ -50,13 +50,13 @@ static int atl1c_get_settings(struct net_device *netdev,
        ecmd->transceiver = XCVR_INTERNAL;
        if (adapter->link_speed != SPEED_0) {
-                ecmd->speed = adapter->link_speed;
+                ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                if (adapter->link_duplex == FULL_DUPLEX)
                        ecmd->duplex = DUPLEX_FULL;
                else
                        ecmd->duplex = DUPLEX_HALF;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
@@ -77,7 +77,8 @@ static int atl1c_set_settings(struct net_device *netdev,
        if (ecmd->autoneg == AUTONEG_ENABLE) {
                autoneg_advertised = ADVERTISED_Autoneg;
        } else {
-                if (ecmd->speed == SPEED_1000) {
+                u32 speed = ethtool_cmd_speed(ecmd);
+                if (speed == SPEED_1000) {
                        if (ecmd->duplex != DUPLEX_FULL) {
                                if (netif_msg_link(adapter))
                                        dev_warn(&adapter->pdev->dev,
@@ -86,7 +87,7 @@ static int atl1c_set_settings(struct net_device *netdev,
                                return -EINVAL;
                        }
                        autoneg_advertised = ADVERTISED_1000baseT_Full;
-                } else if (ecmd->speed == SPEED_100) {
+                } else if (speed == SPEED_100) {
                        if (ecmd->duplex == DUPLEX_FULL)
                                autoneg_advertised = ADVERTISED_100baseT_Full;
                        else
@@ -113,11 +114,6 @@ static int atl1c_set_settings(struct net_device *netdev,
        return 0;
 }
-static u32 atl1c_get_tx_csum(struct net_device *netdev)
-{
-        return (netdev->features & NETIF_F_HW_CSUM) != 0;
-}
 static u32 atl1c_get_msglevel(struct net_device *netdev)
 {
        struct atl1c_adapter *adapter = netdev_priv(netdev);
@@ -307,9 +303,6 @@ static const struct ethtool_ops atl1c_ethtool_ops = {
        .get_link               = ethtool_op_get_link,
        .get_eeprom_len         = atl1c_get_eeprom_len,
        .get_eeprom             = atl1c_get_eeprom,
-        .get_tx_csum            = atl1c_get_tx_csum,
-        .get_sg                 = ethtool_op_get_sg,
-        .set_sg                 = ethtool_op_set_sg,
 };
 void atl1c_set_ethtool_ops(struct net_device *netdev)
diff --git a/drivers/net/atl1c/atl1c_main.c b/drivers/net/atl1c/atl1c_main.c
index a6e1c36e48e6..1269ba5d6e56 100644
--- a/drivers/net/atl1c/atl1c_main.c
+++ b/drivers/net/atl1c/atl1c_main.c
@@ -480,6 +480,15 @@ static void atl1c_set_rxbufsize(struct atl1c_adapter *adapter,
        adapter->rx_buffer_len = mtu > AT_RX_BUF_SIZE ?
                roundup(mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN, 8) : AT_RX_BUF_SIZE;
 }
+static u32 atl1c_fix_features(struct net_device *netdev, u32 features)
+{
+        if (netdev->mtu > MAX_TSO_FRAME_SIZE)
+                features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
+        return features;
+}
 /*
 * atl1c_change_mtu - Change the Maximum Transfer Unit
 * @netdev: network interface device structure
@@ -506,14 +515,8 @@ static int atl1c_change_mtu(struct net_device *netdev, int new_mtu)
                netdev->mtu = new_mtu;
                adapter->hw.max_frame_size = new_mtu;
                atl1c_set_rxbufsize(adapter, netdev);
-                if (new_mtu > MAX_TSO_FRAME_SIZE) {
-                        adapter->netdev->features &= ~NETIF_F_TSO;
-                        adapter->netdev->features &= ~NETIF_F_TSO6;
-                } else {
-                        adapter->netdev->features |= NETIF_F_TSO;
-                        adapter->netdev->features |= NETIF_F_TSO6;
-                }
                atl1c_down(adapter);
+                netdev_update_features(netdev);
                atl1c_up(adapter);
                clear_bit(__AT_RESETTING, &adapter->flags);
                if (adapter->hw.ctrl_flags & ATL1C_FPGA_VERSION) {
@@ -1088,10 +1091,8 @@ static void atl1c_configure_tx(struct atl1c_adapter *adapter)
        u32 max_pay_load;
        u16 tx_offload_thresh;
        u32 txq_ctrl_data;
-        u32 extra_size = 0;     /* Jumbo frame threshold in QWORD unit */
        u32 max_pay_load_data;
-        extra_size = ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN;
        tx_offload_thresh = MAX_TX_OFFLOAD_THRESH;
        AT_WRITE_REG(hw, REG_TX_TSO_OFFLOAD_THRESH,
                (tx_offload_thresh >> 3) & TX_TSO_OFFLOAD_THRESH_MASK);
@@ -2536,6 +2537,7 @@ static int atl1c_suspend(struct device *dev)
        return 0;
 }
+#ifdef CONFIG_PM_SLEEP
 static int atl1c_resume(struct device *dev)
 {
        struct pci_dev *pdev = to_pci_dev(dev);
@@ -2562,6 +2564,7 @@ static int atl1c_resume(struct device *dev)
        return 0;
 }
+#endif
 static void atl1c_shutdown(struct pci_dev *pdev)
 {
@@ -2581,6 +2584,7 @@ static const struct net_device_ops atl1c_netdev_ops = {
        .ndo_set_mac_address    = atl1c_set_mac_addr,
        .ndo_set_multicast_list = atl1c_set_multi,
        .ndo_change_mtu         = atl1c_change_mtu,
+        .ndo_fix_features       = atl1c_fix_features,
        .ndo_do_ioctl           = atl1c_ioctl,
        .ndo_tx_timeout         = atl1c_tx_timeout,
        .ndo_get_stats          = atl1c_get_stats,
@@ -2601,12 +2605,13 @@ static int atl1c_init_netdev(struct net_device *netdev, struct pci_dev *pdev)
        atl1c_set_ethtool_ops(netdev);
        /* TODO: add when ready */
-        netdev->features =      NETIF_F_SG         |
+        netdev->hw_features =   NETIF_F_SG         |
                                NETIF_F_HW_CSUM    |
                                NETIF_F_HW_VLAN_TX |
-                                NETIF_F_HW_VLAN_RX |
                                NETIF_F_TSO        |
                                NETIF_F_TSO6;
+        netdev->features =      netdev->hw_features |
+                                NETIF_F_HW_VLAN_RX;
        return 0;
 }
diff --git a/drivers/net/atl1e/atl1e_ethtool.c b/drivers/net/atl1e/atl1e_ethtool.c
index 1209297433b8..6269438d365f 100644
--- a/drivers/net/atl1e/atl1e_ethtool.c
+++ b/drivers/net/atl1e/atl1e_ethtool.c
@@ -51,13 +51,13 @@ static int atl1e_get_settings(struct net_device *netdev,
        ecmd->transceiver = XCVR_INTERNAL;
        if (adapter->link_speed != SPEED_0) {
-                ecmd->speed = adapter->link_speed;
+                ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                if (adapter->link_duplex == FULL_DUPLEX)
                        ecmd->duplex = DUPLEX_FULL;
                else
                        ecmd->duplex = DUPLEX_HALF;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
@@ -382,9 +382,6 @@ static const struct ethtool_ops atl1e_ethtool_ops = {
        .get_eeprom_len         = atl1e_get_eeprom_len,
        .get_eeprom             = atl1e_get_eeprom,
        .set_eeprom             = atl1e_set_eeprom,
-        .set_tx_csum            = ethtool_op_set_tx_hw_csum,
-        .set_sg                 = ethtool_op_set_sg,
-        .set_tso                = ethtool_op_set_tso,
 };
 void atl1e_set_ethtool_ops(struct net_device *netdev)
diff --git a/drivers/net/atl1e/atl1e_main.c b/drivers/net/atl1e/atl1e_main.c
index b0a71e2f28a9..86a912283134 100644
--- a/drivers/net/atl1e/atl1e_main.c
+++ b/drivers/net/atl1e/atl1e_main.c
@@ -691,10 +691,8 @@ static void atl1e_cal_ring_size(struct atl1e_adapter *adapter, u32 *ring_size)
 static void atl1e_init_ring_resources(struct atl1e_adapter *adapter)
 {
-        struct atl1e_tx_ring *tx_ring = NULL;
        struct atl1e_rx_ring *rx_ring = NULL;
-        tx_ring = &adapter->tx_ring;
        rx_ring = &adapter->rx_ring;
        rx_ring->real_page_size = adapter->rx_ring.page_size
@@ -1927,11 +1925,7 @@ void atl1e_down(struct atl1e_adapter *adapter)
         * reschedule our watchdog timer */
        set_bit(__AT_DOWN, &adapter->flags);
-#ifdef NETIF_F_LLTX
        netif_stop_queue(netdev);
-#else
-        netif_tx_disable(netdev);
-#endif
        /* reset MAC to disable all RX/TX */
        atl1e_reset_hw(&adapter->hw);
@@ -2223,10 +2217,10 @@ static int atl1e_init_netdev(struct net_device *netdev, struct pci_dev *pdev)
        netdev->watchdog_timeo = AT_TX_WATCHDOG;
        atl1e_set_ethtool_ops(netdev);
-        netdev->features = NETIF_F_SG | NETIF_F_HW_CSUM |
+        netdev->hw_features = NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_TSO |
-                NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+                NETIF_F_HW_VLAN_TX;
-        netdev->features |= NETIF_F_LLTX;
+        netdev->features = netdev->hw_features |
-        netdev->features |= NETIF_F_TSO;
+                NETIF_F_HW_VLAN_RX | NETIF_F_LLTX;
        return 0;
 }
diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index 67f40b9c16ed..c5298d1ab744 100644
--- a/drivers/net/atlx/atl1.c
+++ b/drivers/net/atlx/atl1.c
@@ -2074,9 +2074,6 @@ static void atl1_intr_tx(struct atl1_adapter *adapter)
        cmb_tpd_next_to_clean = le16_to_cpu(adapter->cmb.cmb->tpd_cons_idx);
        while (cmb_tpd_next_to_clean != sw_tpd_next_to_clean) {
-                struct tx_packet_desc *tpd;
-                tpd = ATL1_TPD_DESC(tpd_ring, sw_tpd_next_to_clean);
                buffer_info = &tpd_ring->buffer_info[sw_tpd_next_to_clean];
                if (buffer_info->dma) {
                        pci_unmap_page(adapter->pdev, buffer_info->dma,
@@ -2572,7 +2569,7 @@ static s32 atl1_up(struct atl1_adapter *adapter)
 {
        struct net_device *netdev = adapter->netdev;
        int err;
-        int irq_flags = IRQF_SAMPLE_RANDOM;
+        int irq_flags = 0;
        /* hardware has been reset, we need to reload some things */
        atlx_set_multi(netdev);
@@ -2986,6 +2983,11 @@ static int __devinit atl1_probe(struct pci_dev *pdev,
        netdev->features |= NETIF_F_SG;
        netdev->features |= (NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX);
+        netdev->hw_features = NETIF_F_HW_CSUM | NETIF_F_SG | NETIF_F_TSO;
+        /* is this valid? see atl1_setup_mac_ctrl() */
+        netdev->features |= NETIF_F_RXCSUM;
        /*
         * patch for some L1 of old version,
         * the final version of L1 may not need these
@@ -3229,13 +3231,13 @@ static int atl1_get_settings(struct net_device *netdev,
        if (netif_carrier_ok(adapter->netdev)) {
                u16 link_speed, link_duplex;
                atl1_get_speed_and_duplex(hw, &link_speed, &link_duplex);
-                ecmd->speed = link_speed;
+                ethtool_cmd_speed_set(ecmd, link_speed);
                if (link_duplex == FULL_DUPLEX)
                        ecmd->duplex = DUPLEX_FULL;
                else
                        ecmd->duplex = DUPLEX_HALF;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
        if (hw->media_type == MEDIA_TYPE_AUTO_SENSOR ||
@@ -3266,7 +3268,8 @@ static int atl1_set_settings(struct net_device *netdev,
        if (ecmd->autoneg == AUTONEG_ENABLE)
                hw->media_type = MEDIA_TYPE_AUTO_SENSOR;
        else {
-                if (ecmd->speed == SPEED_1000) {
+                u32 speed = ethtool_cmd_speed(ecmd);
+                if (speed == SPEED_1000) {
                        if (ecmd->duplex != DUPLEX_FULL) {
                                if (netif_msg_link(adapter))
                                        dev_warn(&adapter->pdev->dev,
@@ -3275,7 +3278,7 @@ static int atl1_set_settings(struct net_device *netdev,
                                goto exit_sset;
                        }
                        hw->media_type = MEDIA_TYPE_1000M_FULL;
-                } else if (ecmd->speed == SPEED_100) {
+                } else if (speed == SPEED_100) {
                        if (ecmd->duplex == DUPLEX_FULL)
                                hw->media_type = MEDIA_TYPE_100M_FULL;
                        else
@@ -3595,12 +3598,6 @@ static int atl1_set_pauseparam(struct net_device *netdev,
        return 0;
 }
-/* FIXME: is this right? -- CHS */
-static u32 atl1_get_rx_csum(struct net_device *netdev)
-{
-        return 1;
-}
 static void atl1_get_strings(struct net_device *netdev, u32 stringset,
        u8 *data)
 {
@@ -3668,13 +3665,9 @@ static const struct ethtool_ops atl1_ethtool_ops = {
        .set_ringparam          = atl1_set_ringparam,
        .get_pauseparam         = atl1_get_pauseparam,
        .set_pauseparam         = atl1_set_pauseparam,
-        .get_rx_csum            = atl1_get_rx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_hw_csum,
        .get_link               = ethtool_op_get_link,
-        .set_sg                 = ethtool_op_set_sg,
        .get_strings            = atl1_get_strings,
        .nway_reset             = atl1_nway_reset,
        .get_ethtool_stats      = atl1_get_ethtool_stats,
        .get_sset_count         = atl1_get_sset_count,
-        .set_tso                = ethtool_op_set_tso,
 };
diff --git a/drivers/net/atlx/atl2.c b/drivers/net/atlx/atl2.c
index e3cbf45dc612..16249e9b6b95 100644
--- a/drivers/net/atlx/atl2.c
+++ b/drivers/net/atlx/atl2.c
@@ -1411,9 +1411,8 @@ static int __devinit atl2_probe(struct pci_dev *pdev,
        err = -EIO;
-#ifdef NETIF_F_HW_VLAN_TX
+        netdev->hw_features = NETIF_F_SG;
        netdev->features |= (NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX);
-#endif
        /* Init PHY as early as possible due to power saving issue  */
        atl2_phy_init(&adapter->hw);
@@ -1770,13 +1769,13 @@ static int atl2_get_settings(struct net_device *netdev,
        ecmd->transceiver = XCVR_INTERNAL;
        if (adapter->link_speed != SPEED_0) {
-                ecmd->speed = adapter->link_speed;
+                ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                if (adapter->link_duplex == FULL_DUPLEX)
                        ecmd->duplex = DUPLEX_FULL;
                else
                        ecmd->duplex = DUPLEX_HALF;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
@@ -1840,11 +1839,6 @@ static int atl2_set_settings(struct net_device *netdev,
        return 0;
 }
-static u32 atl2_get_tx_csum(struct net_device *netdev)
-{
-        return (netdev->features & NETIF_F_HW_CSUM) != 0;
-}
 static u32 atl2_get_msglevel(struct net_device *netdev)
 {
        return 0;
@@ -2112,12 +2106,6 @@ static const struct ethtool_ops atl2_ethtool_ops = {
        .get_eeprom_len         = atl2_get_eeprom_len,
        .get_eeprom             = atl2_get_eeprom,
        .set_eeprom             = atl2_set_eeprom,
-        .get_tx_csum            = atl2_get_tx_csum,
-        .get_sg                 = ethtool_op_get_sg,
-        .set_sg                 = ethtool_op_set_sg,
-#ifdef NETIF_F_TSO
-        .get_tso                = ethtool_op_get_tso,
-#endif
 };
 static void atl2_set_ethtool_ops(struct net_device *netdev)
diff --git a/drivers/net/b44.c b/drivers/net/b44.c
index 2e2b76258ab4..a69331e06b8d 100644
--- a/drivers/net/b44.c
+++ b/drivers/net/b44.c
@@ -1807,8 +1807,8 @@ static int b44_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        if (bp->flags & B44_FLAG_ADV_100FULL)
                cmd->advertising |= ADVERTISED_100baseT_Full;
        cmd->advertising |= ADVERTISED_Pause | ADVERTISED_Asym_Pause;
-        cmd->speed = (bp->flags & B44_FLAG_100_BASE_T) ?
+        ethtool_cmd_speed_set(cmd, ((bp->flags & B44_FLAG_100_BASE_T) ?
-                SPEED_100 : SPEED_10;
+                                    SPEED_100 : SPEED_10));
        cmd->duplex = (bp->flags & B44_FLAG_FULL_DUPLEX) ?
                DUPLEX_FULL : DUPLEX_HALF;
        cmd->port = 0;
@@ -1820,7 +1820,7 @@ static int b44_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        if (cmd->autoneg == AUTONEG_ENABLE)
                cmd->advertising |= ADVERTISED_Autoneg;
        if (!netif_running(dev)){
-                cmd->speed = 0;
+                ethtool_cmd_speed_set(cmd, 0);
                cmd->duplex = 0xff;
        }
        cmd->maxtxpkt = 0;
@@ -1831,6 +1831,7 @@ static int b44_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 static int b44_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        struct b44 *bp = netdev_priv(dev);
+        u32 speed = ethtool_cmd_speed(cmd);
        /* We do not support gigabit. */
        if (cmd->autoneg == AUTONEG_ENABLE) {
@@ -1838,8 +1839,8 @@ static int b44_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                    (ADVERTISED_1000baseT_Half |
                     ADVERTISED_1000baseT_Full))
                        return -EINVAL;
-        } else if ((cmd->speed != SPEED_100 &&
+        } else if ((speed != SPEED_100 &&
-                    cmd->speed != SPEED_10) ||
+                    speed != SPEED_10) ||
                   (cmd->duplex != DUPLEX_HALF &&
                    cmd->duplex != DUPLEX_FULL)) {
                        return -EINVAL;
@@ -1873,7 +1874,7 @@ static int b44_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        } else {
                bp->flags |= B44_FLAG_FORCE_LINK;
                bp->flags &= ~(B44_FLAG_100_BASE_T | B44_FLAG_FULL_DUPLEX);
-                if (cmd->speed == SPEED_100)
+                if (speed == SPEED_100)
                        bp->flags |= B44_FLAG_100_BASE_T;
                if (cmd->duplex == DUPLEX_FULL)
                        bp->flags |= B44_FLAG_FULL_DUPLEX;
diff --git a/drivers/net/bcm63xx_enet.c b/drivers/net/bcm63xx_enet.c
index c48104b08861..f1573d492e90 100644
--- a/drivers/net/bcm63xx_enet.c
+++ b/drivers/net/bcm63xx_enet.c
@@ -839,8 +839,8 @@ static int bcm_enet_open(struct net_device *dev)
        if (ret)
                goto out_phy_disconnect;
-        ret = request_irq(priv->irq_rx, bcm_enet_isr_dma,
+        ret = request_irq(priv->irq_rx, bcm_enet_isr_dma, IRQF_DISABLED,
-                          IRQF_SAMPLE_RANDOM | IRQF_DISABLED, dev->name, dev);
+                          dev->name, dev);
        if (ret)
                goto out_freeirq;
@@ -1346,7 +1346,8 @@ static int bcm_enet_get_settings(struct net_device *dev,
                return phy_ethtool_gset(priv->phydev, cmd);
        } else {
                cmd->autoneg = 0;
-                cmd->speed = (priv->force_speed_100) ? SPEED_100 : SPEED_10;
+                ethtool_cmd_speed_set(cmd, ((priv->force_speed_100)
+                                            ? SPEED_100 : SPEED_10));
                cmd->duplex = (priv->force_duplex_full) ?
                        DUPLEX_FULL : DUPLEX_HALF;
                cmd->supported = ADVERTISED_10baseT_Half  |
diff --git a/drivers/net/benet/be.h b/drivers/net/benet/be.h
index 2353eca32593..a7db870d1641 100644
--- a/drivers/net/benet/be.h
+++ b/drivers/net/benet/be.h
@@ -49,6 +49,7 @@
 #define OC_DEVICE_ID1           0x700   /* Device Id for BE2 cards */
 #define OC_DEVICE_ID2           0x710   /* Device Id for BE3 cards */
 #define OC_DEVICE_ID3           0xe220  /* Device id for Lancer cards */
+#define OC_DEVICE_ID4           0xe228   /* Device id for VF in Lancer */
 static inline char *nic_name(struct pci_dev *pdev)
 {
@@ -58,6 +59,7 @@ static inline char *nic_name(struct pci_dev *pdev)
        case OC_DEVICE_ID2:
                return OC_NAME_BE;
        case OC_DEVICE_ID3:
+        case OC_DEVICE_ID4:
                return OC_NAME_LANCER;
        case BE_DEVICE_ID2:
                return BE3_NAME;
@@ -84,15 +86,14 @@ static inline char *nic_name(struct pci_dev *pdev)
 #define MCC_CQ_LEN              256
 #define MAX_RSS_QS              4       /* BE limit is 4 queues/port */
-#define BE_MAX_MSIX_VECTORS     (MAX_RSS_QS + 1 + 1)/* RSS qs + 1 def Rx + Tx */
+#define MAX_RX_QS               (MAX_RSS_QS + 1) /* RSS qs + 1 def Rx */
+#define BE_MAX_MSIX_VECTORS     (MAX_RX_QS + 1)/* RX + TX */
 #define BE_NAPI_WEIGHT          64
 #define MAX_RX_POST             BE_NAPI_WEIGHT /* Frags posted at a time */
 #define RX_FRAGS_REFILL_WM      (RX_Q_LEN - MAX_RX_POST)
 #define FW_VER_LEN              32
-#define BE_MAX_VF               32
 struct be_dma_mem {
        void *va;
        dma_addr_t dma;
@@ -245,6 +246,43 @@ struct be_rx_obj {
 struct be_drv_stats {
        u8 be_on_die_temperature;
+        u64 be_tx_events;
+        u64 eth_red_drops;
+        u64 rx_drops_no_pbuf;
+        u64 rx_drops_no_txpb;
+        u64 rx_drops_no_erx_descr;
+        u64 rx_drops_no_tpre_descr;
+        u64 rx_drops_too_many_frags;
+        u64 rx_drops_invalid_ring;
+        u64 forwarded_packets;
+        u64 rx_drops_mtu;
+        u64 rx_crc_errors;
+        u64 rx_alignment_symbol_errors;
+        u64 rx_pause_frames;
+        u64 rx_priority_pause_frames;
+        u64 rx_control_frames;
+        u64 rx_in_range_errors;
+        u64 rx_out_range_errors;
+        u64 rx_frame_too_long;
+        u64 rx_address_match_errors;
+        u64 rx_dropped_too_small;
+        u64 rx_dropped_too_short;
+        u64 rx_dropped_header_too_small;
+        u64 rx_dropped_tcp_length;
+        u64 rx_dropped_runt;
+        u64 rx_ip_checksum_errs;
+        u64 rx_tcp_checksum_errs;
+        u64 rx_udp_checksum_errs;
+        u64 rx_switched_unicast_packets;
+        u64 rx_switched_multicast_packets;
+        u64 rx_switched_broadcast_packets;
+        u64 tx_pauseframes;
+        u64 tx_priority_pauseframes;
+        u64 tx_controlframes;
+        u64 rxpp_fifo_overflow_drop;
+        u64 rx_input_fifo_overflow_drop;
+        u64 pmem_fifo_overflow_drop;
+        u64 jabber_events;
 };
 struct be_vf_cfg {
@@ -276,7 +314,7 @@ struct be_adapter {
        spinlock_t mcc_cq_lock;
        struct msix_entry msix_entries[BE_MAX_MSIX_VECTORS];
-        bool msix_enabled;
+        u32 num_msix_vec;
        bool isr_registered;
        /* TX Rings */
@@ -287,7 +325,7 @@ struct be_adapter {
        u32 cache_line_break[8];
        /* Rx rings */
-        struct be_rx_obj rx_obj[MAX_RSS_QS + 1]; /* one default non-rss Q */
+        struct be_rx_obj rx_obj[MAX_RX_QS];
        u32 num_rx_qs;
        u32 big_page_size;      /* Compounded page size shared by rx wrbs */
@@ -308,10 +346,10 @@ struct be_adapter {
        u16 work_counter;
        /* Ethtool knobs and info */
-        bool rx_csum;           /* BE card must perform rx-checksumming */
        char fw_ver[FW_VER_LEN];
        u32 if_handle;          /* Used to configure filtering */
        u32 pmac_id;            /* MAC addr handle used by BE card */
+        u32 beacon_state;       /* for set_phys_id */
        bool eeh_err;
        bool link_up;
@@ -334,7 +372,7 @@ struct be_adapter {
        bool be3_native;
        bool sriov_enabled;
-        struct be_vf_cfg vf_cfg[BE_MAX_VF];
+        struct be_vf_cfg *vf_cfg;
        u8 is_virtfn;
        u32 sli_family;
        u8 hba_port_num;
@@ -347,10 +385,12 @@ struct be_adapter {
 #define BE_GEN2 2
 #define BE_GEN3 3
-#define lancer_chip(adapter)            (adapter->pdev->device == OC_DEVICE_ID3)
+#define lancer_chip(adapter)    ((adapter->pdev->device == OC_DEVICE_ID3) || \
+                                 (adapter->pdev->device == OC_DEVICE_ID4))
 extern const struct ethtool_ops be_ethtool_ops;
+#define msix_enabled(adapter)           (adapter->num_msix_vec > 0)
 #define tx_stats(adapter)               (&adapter->tx_stats)
 #define rx_stats(rxo)                   (&rxo->stats)
@@ -455,18 +495,10 @@ static inline u8 is_udp_pkt(struct sk_buff *skb)
 static inline void be_check_sriov_fn_type(struct be_adapter *adapter)
 {
-        u8 data;
        u32 sli_intf;
-        if (lancer_chip(adapter)) {
+        pci_read_config_dword(adapter->pdev, SLI_INTF_REG_OFFSET, &sli_intf);
-                pci_read_config_dword(adapter->pdev, SLI_INTF_REG_OFFSET,
+        adapter->is_virtfn = (sli_intf & SLI_INTF_FT_MASK) ? 1 : 0;
-                                                                &sli_intf);
-                adapter->is_virtfn = (sli_intf & SLI_INTF_FT_MASK) ? 1 : 0;
-        } else {
-                pci_write_config_byte(adapter->pdev, 0xFE, 0xAA);
-                pci_read_config_byte(adapter->pdev, 0xFE, &data);
-                adapter->is_virtfn = (data != 0xAA);
-        }
 }
 static inline void be_vf_eth_addr_generate(struct be_adapter *adapter, u8 *mac)
@@ -482,9 +514,15 @@ static inline void be_vf_eth_addr_generate(struct be_adapter *adapter, u8 *mac)
        memcpy(mac, adapter->netdev->dev_addr, 3);
 }
+static inline bool be_multi_rxq(const struct be_adapter *adapter)
+{
+        return adapter->num_rx_qs > 1;
+}
 extern void be_cq_notify(struct be_adapter *adapter, u16 qid, bool arm,
                u16 num_popped);
 extern void be_link_status_update(struct be_adapter *adapter, bool link_up);
 extern void netdev_stats_update(struct be_adapter *adapter);
+extern void be_parse_stats(struct be_adapter *adapter);
 extern int be_load_fw(struct be_adapter *adapter, u8 *func);
 #endif                          /* BE_H */
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
index 9dc9394fd4ca..2463b1c97922 100644
--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c
@@ -71,18 +71,38 @@ static int be_mcc_compl_process(struct be_adapter *adapter,
        compl_status = (compl->status >> CQE_STATUS_COMPL_SHIFT) &
                                CQE_STATUS_COMPL_MASK;
-        if ((compl->tag0 == OPCODE_COMMON_WRITE_FLASHROM) &&
+        if (((compl->tag0 == OPCODE_COMMON_WRITE_FLASHROM) ||
+                (compl->tag0 == OPCODE_COMMON_WRITE_OBJECT)) &&
                (compl->tag1 == CMD_SUBSYSTEM_COMMON)) {
                adapter->flash_status = compl_status;
                complete(&adapter->flash_compl);
        }
        if (compl_status == MCC_STATUS_SUCCESS) {
-                if (compl->tag0 == OPCODE_ETH_GET_STATISTICS) {
+                if (((compl->tag0 == OPCODE_ETH_GET_STATISTICS) ||
-                        struct be_cmd_resp_get_stats *resp =
+                         (compl->tag0 == OPCODE_ETH_GET_PPORT_STATS)) &&
-                                                adapter->stats_cmd.va;
+                        (compl->tag1 == CMD_SUBSYSTEM_ETH)) {
-                        be_dws_le_to_cpu(&resp->hw_stats,
+                        if (adapter->generation == BE_GEN3) {
-                                                sizeof(resp->hw_stats));
+                                if (lancer_chip(adapter)) {
+                                        struct lancer_cmd_resp_pport_stats
+                                                *resp = adapter->stats_cmd.va;
+                                        be_dws_le_to_cpu(&resp->pport_stats,
+                                                sizeof(resp->pport_stats));
+                                } else {
+                                        struct be_cmd_resp_get_stats_v1 *resp =
+                                                        adapter->stats_cmd.va;
+                                be_dws_le_to_cpu(&resp->hw_stats,
+                                                        sizeof(resp->hw_stats));
+                                }
+                        } else {
+                                struct be_cmd_resp_get_stats_v0 *resp =
+                                                        adapter->stats_cmd.va;
+                                be_dws_le_to_cpu(&resp->hw_stats,
+                                                        sizeof(resp->hw_stats));
+                        }
+                        be_parse_stats(adapter);
                        netdev_stats_update(adapter);
                        adapter->stats_cmd_sent = false;
                }
@@ -292,12 +312,12 @@ static int be_mbox_db_ready_wait(struct be_adapter *adapter, void __iomem *db)
                if (msecs > 4000) {
                        dev_err(&adapter->pdev->dev, "mbox poll timed out\n");
-                        be_detect_dump_ue(adapter);
+                        if (!lancer_chip(adapter))
+                                be_detect_dump_ue(adapter);
                        return -1;
                }
-                set_current_state(TASK_INTERRUPTIBLE);
+                msleep(1);
-                schedule_timeout(msecs_to_jiffies(1));
                msecs++;
        } while (true);
@@ -374,23 +394,25 @@ int be_cmd_POST(struct be_adapter *adapter)
 {
        u16 stage;
        int status, timeout = 0;
+        struct device *dev = &adapter->pdev->dev;
        do {
                status = be_POST_stage_get(adapter, &stage);
                if (status) {
-                        dev_err(&adapter->pdev->dev, "POST error; stage=0x%x\n",
+                        dev_err(dev, "POST error; stage=0x%x\n", stage);
-                                stage);
                        return -1;
                } else if (stage != POST_STAGE_ARMFW_RDY) {
-                        set_current_state(TASK_INTERRUPTIBLE);
+                        if (msleep_interruptible(2000)) {
-                        schedule_timeout(2 * HZ);
+                                dev_err(dev, "Waiting for POST aborted\n");
+                                return -EINTR;
+                        }
                        timeout += 2;
                } else {
                        return 0;
                }
        } while (timeout < 40);
-        dev_err(&adapter->pdev->dev, "POST timeout; stage=0x%x\n", stage);
+        dev_err(dev, "POST timeout; stage=0x%x\n", stage);
        return -1;
 }
@@ -728,8 +750,6 @@ int be_cmd_cq_create(struct be_adapter *adapter,
        if (lancer_chip(adapter)) {
                req->hdr.version = 2;
                req->page_size = 1; /* 1 for 4K */
-                AMAP_SET_BITS(struct amap_cq_context_lancer, coalescwm, ctxt,
-                                                                coalesce_wm);
                AMAP_SET_BITS(struct amap_cq_context_lancer, nodelay, ctxt,
                                                                no_delay);
                AMAP_SET_BITS(struct amap_cq_context_lancer, count, ctxt,
@@ -1074,7 +1094,7 @@ int be_cmd_if_destroy(struct be_adapter *adapter, u32 interface_id, u32 domain)
 int be_cmd_get_stats(struct be_adapter *adapter, struct be_dma_mem *nonemb_cmd)
 {
        struct be_mcc_wrb *wrb;
-        struct be_cmd_req_get_stats *req;
+        struct be_cmd_req_hdr *hdr;
        struct be_sge *sge;
        int status = 0;
@@ -1088,14 +1108,62 @@ int be_cmd_get_stats(struct be_adapter *adapter, struct be_dma_mem *nonemb_cmd)
                status = -EBUSY;
                goto err;
        }
-        req = nonemb_cmd->va;
+        hdr = nonemb_cmd->va;
        sge = nonembedded_sgl(wrb);
-        be_wrb_hdr_prepare(wrb, sizeof(*req), false, 1,
+        be_wrb_hdr_prepare(wrb, nonemb_cmd->size, false, 1,
                        OPCODE_ETH_GET_STATISTICS);
+        be_cmd_hdr_prepare(hdr, CMD_SUBSYSTEM_ETH,
+                OPCODE_ETH_GET_STATISTICS, nonemb_cmd->size);
+        if (adapter->generation == BE_GEN3)
+                hdr->version = 1;
+        wrb->tag1 = CMD_SUBSYSTEM_ETH;
+        sge->pa_hi = cpu_to_le32(upper_32_bits(nonemb_cmd->dma));
+        sge->pa_lo = cpu_to_le32(nonemb_cmd->dma & 0xFFFFFFFF);
+        sge->len = cpu_to_le32(nonemb_cmd->size);
+        be_mcc_notify(adapter);
+        adapter->stats_cmd_sent = true;
+err:
+        spin_unlock_bh(&adapter->mcc_lock);
+        return status;
+}
+/* Lancer Stats */
+int lancer_cmd_get_pport_stats(struct be_adapter *adapter,
+                                struct be_dma_mem *nonemb_cmd)
+{
+        struct be_mcc_wrb *wrb;
+        struct lancer_cmd_req_pport_stats *req;
+        struct be_sge *sge;
+        int status = 0;
+        spin_lock_bh(&adapter->mcc_lock);
+        wrb = wrb_from_mccq(adapter);
+        if (!wrb) {
+                status = -EBUSY;
+                goto err;
+        }
+        req = nonemb_cmd->va;
+        sge = nonembedded_sgl(wrb);
+        be_wrb_hdr_prepare(wrb, nonemb_cmd->size, false, 1,
+                        OPCODE_ETH_GET_PPORT_STATS);
        be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_ETH,
-                OPCODE_ETH_GET_STATISTICS, sizeof(*req));
+                        OPCODE_ETH_GET_PPORT_STATS, nonemb_cmd->size);
+        req->cmd_params.params.pport_num = cpu_to_le16(adapter->port_num);
+        req->cmd_params.params.reset_stats = 0;
+        wrb->tag1 = CMD_SUBSYSTEM_ETH;
        sge->pa_hi = cpu_to_le32(upper_32_bits(nonemb_cmd->dma));
        sge->pa_lo = cpu_to_le32(nonemb_cmd->dma & 0xFFFFFFFF);
        sge->len = cpu_to_le32(nonemb_cmd->size);
@@ -1110,7 +1178,7 @@ err:
 /* Uses synchronous mcc */
 int be_cmd_link_status_query(struct be_adapter *adapter,
-                        bool *link_up, u8 *mac_speed, u16 *link_speed)
+                        bool *link_up, u8 *mac_speed, u16 *link_speed, u32 dom)
 {
        struct be_mcc_wrb *wrb;
        struct be_cmd_req_link_status *req;
@@ -1186,6 +1254,116 @@ err:
        return status;
 }
+/* Uses synchronous mcc */
+int be_cmd_get_reg_len(struct be_adapter *adapter, u32 *log_size)
+{
+        struct be_mcc_wrb *wrb;
+        struct be_cmd_req_get_fat *req;
+        int status;
+        spin_lock_bh(&adapter->mcc_lock);
+        wrb = wrb_from_mccq(adapter);
+        if (!wrb) {
+                status = -EBUSY;
+                goto err;
+        }
+        req = embedded_payload(wrb);
+        be_wrb_hdr_prepare(wrb, sizeof(*req), true, 0,
+                        OPCODE_COMMON_MANAGE_FAT);
+        be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_COMMON,
+                OPCODE_COMMON_MANAGE_FAT, sizeof(*req));
+        req->fat_operation = cpu_to_le32(QUERY_FAT);
+        status = be_mcc_notify_wait(adapter);
+        if (!status) {
+                struct be_cmd_resp_get_fat *resp = embedded_payload(wrb);
+                if (log_size && resp->log_size)
+                        *log_size = le32_to_cpu(resp->log_size) -
+                                        sizeof(u32);
+        }
+err:
+        spin_unlock_bh(&adapter->mcc_lock);
+        return status;
+}
+void be_cmd_get_regs(struct be_adapter *adapter, u32 buf_len, void *buf)
+{
+        struct be_dma_mem get_fat_cmd;
+        struct be_mcc_wrb *wrb;
+        struct be_cmd_req_get_fat *req;
+        struct be_sge *sge;
+        u32 offset = 0, total_size, buf_size,
+                                log_offset = sizeof(u32), payload_len;
+        int status;
+        if (buf_len == 0)
+                return;
+        total_size = buf_len;
+        get_fat_cmd.size = sizeof(struct be_cmd_req_get_fat) + 60*1024;
+        get_fat_cmd.va = pci_alloc_consistent(adapter->pdev,
+                        get_fat_cmd.size,
+                        &get_fat_cmd.dma);
+        if (!get_fat_cmd.va) {
+                status = -ENOMEM;
+                dev_err(&adapter->pdev->dev,
+                "Memory allocation failure while retrieving FAT data\n");
+                return;
+        }
+        spin_lock_bh(&adapter->mcc_lock);
+        while (total_size) {
+                buf_size = min(total_size, (u32)60*1024);
+                total_size -= buf_size;
+                wrb = wrb_from_mccq(adapter);
+                if (!wrb) {
+                        status = -EBUSY;
+                        goto err;
+                }
+                req = get_fat_cmd.va;
+                sge = nonembedded_sgl(wrb);
+                payload_len = sizeof(struct be_cmd_req_get_fat) + buf_size;
+                be_wrb_hdr_prepare(wrb, payload_len, false, 1,
+                                OPCODE_COMMON_MANAGE_FAT);
+                be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_COMMON,
+                                OPCODE_COMMON_MANAGE_FAT, payload_len);
+                sge->pa_hi = cpu_to_le32(upper_32_bits(get_fat_cmd.dma));
+                sge->pa_lo = cpu_to_le32(get_fat_cmd.dma & 0xFFFFFFFF);
+                sge->len = cpu_to_le32(get_fat_cmd.size);
+                req->fat_operation = cpu_to_le32(RETRIEVE_FAT);
+                req->read_log_offset = cpu_to_le32(log_offset);
+                req->read_log_length = cpu_to_le32(buf_size);
+                req->data_buffer_size = cpu_to_le32(buf_size);
+                status = be_mcc_notify_wait(adapter);
+                if (!status) {
+                        struct be_cmd_resp_get_fat *resp = get_fat_cmd.va;
+                        memcpy(buf + offset,
+                                resp->data_buffer,
+                                resp->read_log_length);
+                } else {
+                        dev_err(&adapter->pdev->dev, "FAT Table Retrieve error\n");
+                        goto err;
+                }
+                offset += buf_size;
+                log_offset += buf_size;
+        }
+err:
+        pci_free_consistent(adapter->pdev, get_fat_cmd.size,
+                        get_fat_cmd.va,
+                        get_fat_cmd.dma);
+        spin_unlock_bh(&adapter->mcc_lock);
+}
 /* Uses Mbox */
 int be_cmd_get_fw_ver(struct be_adapter *adapter, char *fw_ver)
 {
@@ -1293,12 +1471,24 @@ err:
 /* Uses MCC for this command as it may be called in BH context
 * Uses synchronous mcc
 */
-int be_cmd_promiscuous_config(struct be_adapter *adapter, u8 port_num, bool en)
+int be_cmd_promiscuous_config(struct be_adapter *adapter, bool en)
 {
        struct be_mcc_wrb *wrb;
-        struct be_cmd_req_promiscuous_config *req;
+        struct be_cmd_req_rx_filter *req;
+        struct be_dma_mem promiscous_cmd;
+        struct be_sge *sge;
        int status;
+        memset(&promiscous_cmd, 0, sizeof(struct be_dma_mem));
+        promiscous_cmd.size = sizeof(struct be_cmd_req_rx_filter);
+        promiscous_cmd.va = pci_alloc_consistent(adapter->pdev,
+                                promiscous_cmd.size, &promiscous_cmd.dma);
+        if (!promiscous_cmd.va) {
+                dev_err(&adapter->pdev->dev,
+                                "Memory allocation failure\n");
+                return -ENOMEM;
+        }
        spin_lock_bh(&adapter->mcc_lock);
        wrb = wrb_from_mccq(adapter);
@@ -1306,26 +1496,30 @@ int be_cmd_promiscuous_config(struct be_adapter *adapter, u8 port_num, bool en)
                status = -EBUSY;
                goto err;
        }
-        req = embedded_payload(wrb);
-        be_wrb_hdr_prepare(wrb, sizeof(*req), true, 0, OPCODE_ETH_PROMISCUOUS);
+        req = promiscous_cmd.va;
+        sge = nonembedded_sgl(wrb);
-        be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_ETH,
+        be_wrb_hdr_prepare(wrb, sizeof(*req), false, 1,
-                OPCODE_ETH_PROMISCUOUS, sizeof(*req));
+                                        OPCODE_COMMON_NTWK_RX_FILTER);
+        be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_COMMON,
-        /* In FW versions X.102.149/X.101.487 and later,
+                        OPCODE_COMMON_NTWK_RX_FILTER, sizeof(*req));
-         * the port setting associated only with the
-         * issuing pci function will take effect
+        req->if_id = cpu_to_le32(adapter->if_handle);
-         */
+        req->if_flags_mask = cpu_to_le32(BE_IF_FLAGS_PROMISCUOUS);
-        if (port_num)
+        if (en)
-                req->port1_promiscuous = en;
+                req->if_flags = cpu_to_le32(BE_IF_FLAGS_PROMISCUOUS);
-        else
-                req->port0_promiscuous = en;
+        sge->pa_hi = cpu_to_le32(upper_32_bits(promiscous_cmd.dma));
+        sge->pa_lo = cpu_to_le32(promiscous_cmd.dma & 0xFFFFFFFF);
+        sge->len = cpu_to_le32(promiscous_cmd.size);
        status = be_mcc_notify_wait(adapter);
 err:
        spin_unlock_bh(&adapter->mcc_lock);
+        pci_free_consistent(adapter->pdev, promiscous_cmd.size,
+                        promiscous_cmd.va, promiscous_cmd.dma);
        return status;
 }
@@ -1608,6 +1802,81 @@ err:
        return status;
 }
+int lancer_cmd_write_object(struct be_adapter *adapter, struct be_dma_mem *cmd,
+                        u32 data_size, u32 data_offset, const char *obj_name,
+                        u32 *data_written, u8 *addn_status)
+{
+        struct be_mcc_wrb *wrb;
+        struct lancer_cmd_req_write_object *req;
+        struct lancer_cmd_resp_write_object *resp;
+        void *ctxt = NULL;
+        int status;
+        spin_lock_bh(&adapter->mcc_lock);
+        adapter->flash_status = 0;
+        wrb = wrb_from_mccq(adapter);
+        if (!wrb) {
+                status = -EBUSY;
+                goto err_unlock;
+        }
+        req = embedded_payload(wrb);
+        be_wrb_hdr_prepare(wrb, sizeof(struct lancer_cmd_req_write_object),
+                        true, 1, OPCODE_COMMON_WRITE_OBJECT);
+        wrb->tag1 = CMD_SUBSYSTEM_COMMON;
+        be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_COMMON,
+                                OPCODE_COMMON_WRITE_OBJECT,
+                                sizeof(struct lancer_cmd_req_write_object));
+        ctxt = &req->context;
+        AMAP_SET_BITS(struct amap_lancer_write_obj_context,
+                        write_length, ctxt, data_size);
+        if (data_size == 0)
+                AMAP_SET_BITS(struct amap_lancer_write_obj_context,
+                                eof, ctxt, 1);
+        else
+                AMAP_SET_BITS(struct amap_lancer_write_obj_context,
+                                eof, ctxt, 0);
+        be_dws_cpu_to_le(ctxt, sizeof(req->context));
+        req->write_offset = cpu_to_le32(data_offset);
+        strcpy(req->object_name, obj_name);
+        req->descriptor_count = cpu_to_le32(1);
+        req->buf_len = cpu_to_le32(data_size);
+        req->addr_low = cpu_to_le32((cmd->dma +
+                                sizeof(struct lancer_cmd_req_write_object))
+                                & 0xFFFFFFFF);
+        req->addr_high = cpu_to_le32(upper_32_bits(cmd->dma +
+                                sizeof(struct lancer_cmd_req_write_object)));
+        be_mcc_notify(adapter);
+        spin_unlock_bh(&adapter->mcc_lock);
+        if (!wait_for_completion_timeout(&adapter->flash_compl,
+                        msecs_to_jiffies(12000)))
+                status = -1;
+        else
+                status = adapter->flash_status;
+        resp = embedded_payload(wrb);
+        if (!status) {
+                *data_written = le32_to_cpu(resp->actual_write_len);
+        } else {
+                *addn_status = resp->additional_status;
+                status = resp->status;
+        }
+        return status;
+err_unlock:
+        spin_unlock_bh(&adapter->mcc_lock);
+        return status;
+}
 int be_cmd_write_flashrom(struct be_adapter *adapter, struct be_dma_mem *cmd,
                        u32 flash_type, u32 flash_opcode, u32 buf_size)
 {
diff --git a/drivers/net/benet/be_cmds.h b/drivers/net/benet/be_cmds.h
index 4f254cfaabe2..8148cc66cbe9 100644
--- a/drivers/net/benet/be_cmds.h
+++ b/drivers/net/benet/be_cmds.h
@@ -186,12 +186,14 @@ struct be_mcc_mailbox {
 #define OPCODE_COMMON_NTWK_PMAC_ADD                     59
 #define OPCODE_COMMON_NTWK_PMAC_DEL                     60
 #define OPCODE_COMMON_FUNCTION_RESET                    61
+#define OPCODE_COMMON_MANAGE_FAT                        68
 #define OPCODE_COMMON_ENABLE_DISABLE_BEACON             69
 #define OPCODE_COMMON_GET_BEACON_STATE                  70
 #define OPCODE_COMMON_READ_TRANSRECV_DATA               73
 #define OPCODE_COMMON_GET_PHY_DETAILS                   102
 #define OPCODE_COMMON_SET_DRIVER_FUNCTION_CAP           103
 #define OPCODE_COMMON_GET_CNTL_ADDITIONAL_ATTRIBUTES    121
+#define OPCODE_COMMON_WRITE_OBJECT                      172
 #define OPCODE_ETH_RSS_CONFIG                           1
 #define OPCODE_ETH_ACPI_CONFIG                          2
@@ -202,6 +204,7 @@ struct be_mcc_mailbox {
 #define OPCODE_ETH_TX_DESTROY                           9
 #define OPCODE_ETH_RX_DESTROY                           10
 #define OPCODE_ETH_ACPI_WOL_MAGIC_CONFIG                12
+#define OPCODE_ETH_GET_PPORT_STATS                      18
 #define OPCODE_LOWLEVEL_HOST_DDR_DMA                    17
 #define OPCODE_LOWLEVEL_LOOPBACK_TEST                   18
@@ -380,6 +383,24 @@ struct be_cmd_resp_cq_create {
        u16 rsvd0;
 } __packed;
+struct be_cmd_req_get_fat {
+        struct be_cmd_req_hdr hdr;
+        u32 fat_operation;
+        u32 read_log_offset;
+        u32 read_log_length;
+        u32 data_buffer_size;
+        u32 data_buffer[1];
+} __packed;
+struct be_cmd_resp_get_fat {
+        struct be_cmd_resp_hdr hdr;
+        u32 log_size;
+        u32 read_log_length;
+        u32 rsvd[2];
+        u32 data_buffer[1];
+} __packed;
 /******************** Create MCCQ ***************************/
 /* Pseudo amap definition in which each bit of the actual structure is defined
 * as a byte: used to calculate offset/shift/mask of each field */
@@ -549,7 +570,7 @@ struct be_cmd_req_if_destroy {
 };
 /*************** HW Stats Get **********************************/
-struct be_port_rxf_stats {
+struct be_port_rxf_stats_v0 {
        u32 rx_bytes_lsd;       /* dword 0*/
        u32 rx_bytes_msd;       /* dword 1*/
        u32 rx_total_frames;    /* dword 2*/
@@ -618,8 +639,8 @@ struct be_port_rxf_stats {
        u32 rx_input_fifo_overflow;     /* dword 65*/
 };
-struct be_rxf_stats {
+struct be_rxf_stats_v0 {
-        struct be_port_rxf_stats port[2];
+        struct be_port_rxf_stats_v0 port[2];
        u32 rx_drops_no_pbuf;   /* dword 132*/
        u32 rx_drops_no_txpb;   /* dword 133*/
        u32 rx_drops_no_erx_descr;      /* dword 134*/
@@ -642,36 +663,227 @@ struct be_rxf_stats {
        u32 rsvd1[6];
 };
-struct be_erx_stats {
+struct be_erx_stats_v0 {
        u32 rx_drops_no_fragments[44];     /* dwordS 0 to 43*/
-        u32 debug_wdma_sent_hold;          /* dword 44*/
+        u32 rsvd[4];
-        u32 debug_wdma_pbfree_sent_hold;   /* dword 45*/
-        u32 debug_wdma_zerobyte_pbfree_sent_hold; /* dword 46*/
-        u32 debug_pmem_pbuf_dealloc;       /* dword 47*/
 };
 struct be_pmem_stats {
        u32 eth_red_drops;
-        u32 rsvd[4];
+        u32 rsvd[5];
 };
-struct be_hw_stats {
+struct be_hw_stats_v0 {
-        struct be_rxf_stats rxf;
+        struct be_rxf_stats_v0 rxf;
        u32 rsvd[48];
-        struct be_erx_stats erx;
+        struct be_erx_stats_v0 erx;
        struct be_pmem_stats pmem;
 };
-struct be_cmd_req_get_stats {
+struct be_cmd_req_get_stats_v0 {
+        struct be_cmd_req_hdr hdr;
+        u8 rsvd[sizeof(struct be_hw_stats_v0)];
+};
+struct be_cmd_resp_get_stats_v0 {
+        struct be_cmd_resp_hdr hdr;
+        struct be_hw_stats_v0 hw_stats;
+};
+#define make_64bit_val(hi_32, lo_32)    (((u64)hi_32<<32) | lo_32)
+struct lancer_cmd_pport_stats {
+        u32 tx_packets_lo;
+        u32 tx_packets_hi;
+        u32 tx_unicast_packets_lo;
+        u32 tx_unicast_packets_hi;
+        u32 tx_multicast_packets_lo;
+        u32 tx_multicast_packets_hi;
+        u32 tx_broadcast_packets_lo;
+        u32 tx_broadcast_packets_hi;
+        u32 tx_bytes_lo;
+        u32 tx_bytes_hi;
+        u32 tx_unicast_bytes_lo;
+        u32 tx_unicast_bytes_hi;
+        u32 tx_multicast_bytes_lo;
+        u32 tx_multicast_bytes_hi;
+        u32 tx_broadcast_bytes_lo;
+        u32 tx_broadcast_bytes_hi;
+        u32 tx_discards_lo;
+        u32 tx_discards_hi;
+        u32 tx_errors_lo;
+        u32 tx_errors_hi;
+        u32 tx_pause_frames_lo;
+        u32 tx_pause_frames_hi;
+        u32 tx_pause_on_frames_lo;
+        u32 tx_pause_on_frames_hi;
+        u32 tx_pause_off_frames_lo;
+        u32 tx_pause_off_frames_hi;
+        u32 tx_internal_mac_errors_lo;
+        u32 tx_internal_mac_errors_hi;
+        u32 tx_control_frames_lo;
+        u32 tx_control_frames_hi;
+        u32 tx_packets_64_bytes_lo;
+        u32 tx_packets_64_bytes_hi;
+        u32 tx_packets_65_to_127_bytes_lo;
+        u32 tx_packets_65_to_127_bytes_hi;
+        u32 tx_packets_128_to_255_bytes_lo;
+        u32 tx_packets_128_to_255_bytes_hi;
+        u32 tx_packets_256_to_511_bytes_lo;
+        u32 tx_packets_256_to_511_bytes_hi;
+        u32 tx_packets_512_to_1023_bytes_lo;
+        u32 tx_packets_512_to_1023_bytes_hi;
+        u32 tx_packets_1024_to_1518_bytes_lo;
+        u32 tx_packets_1024_to_1518_bytes_hi;
+        u32 tx_packets_1519_to_2047_bytes_lo;
+        u32 tx_packets_1519_to_2047_bytes_hi;
+        u32 tx_packets_2048_to_4095_bytes_lo;
+        u32 tx_packets_2048_to_4095_bytes_hi;
+        u32 tx_packets_4096_to_8191_bytes_lo;
+        u32 tx_packets_4096_to_8191_bytes_hi;
+        u32 tx_packets_8192_to_9216_bytes_lo;
+        u32 tx_packets_8192_to_9216_bytes_hi;
+        u32 tx_lso_packets_lo;
+        u32 tx_lso_packets_hi;
+        u32 rx_packets_lo;
+        u32 rx_packets_hi;
+        u32 rx_unicast_packets_lo;
+        u32 rx_unicast_packets_hi;
+        u32 rx_multicast_packets_lo;
+        u32 rx_multicast_packets_hi;
+        u32 rx_broadcast_packets_lo;
+        u32 rx_broadcast_packets_hi;
+        u32 rx_bytes_lo;
+        u32 rx_bytes_hi;
+        u32 rx_unicast_bytes_lo;
+        u32 rx_unicast_bytes_hi;
+        u32 rx_multicast_bytes_lo;
+        u32 rx_multicast_bytes_hi;
+        u32 rx_broadcast_bytes_lo;
+        u32 rx_broadcast_bytes_hi;
+        u32 rx_unknown_protos;
+        u32 rsvd_69; /* Word 69 is reserved */
+        u32 rx_discards_lo;
+        u32 rx_discards_hi;
+        u32 rx_errors_lo;
+        u32 rx_errors_hi;
+        u32 rx_crc_errors_lo;
+        u32 rx_crc_errors_hi;
+        u32 rx_alignment_errors_lo;
+        u32 rx_alignment_errors_hi;
+        u32 rx_symbol_errors_lo;
+        u32 rx_symbol_errors_hi;
+        u32 rx_pause_frames_lo;
+        u32 rx_pause_frames_hi;
+        u32 rx_pause_on_frames_lo;
+        u32 rx_pause_on_frames_hi;
+        u32 rx_pause_off_frames_lo;
+        u32 rx_pause_off_frames_hi;
+        u32 rx_frames_too_long_lo;
+        u32 rx_frames_too_long_hi;
+        u32 rx_internal_mac_errors_lo;
+        u32 rx_internal_mac_errors_hi;
+        u32 rx_undersize_packets;
+        u32 rx_oversize_packets;
+        u32 rx_fragment_packets;
+        u32 rx_jabbers;
+        u32 rx_control_frames_lo;
+        u32 rx_control_frames_hi;
+        u32 rx_control_frames_unknown_opcode_lo;
+        u32 rx_control_frames_unknown_opcode_hi;
+        u32 rx_in_range_errors;
+        u32 rx_out_of_range_errors;
+        u32 rx_address_match_errors;
+        u32 rx_vlan_mismatch_errors;
+        u32 rx_dropped_too_small;
+        u32 rx_dropped_too_short;
+        u32 rx_dropped_header_too_small;
+        u32 rx_dropped_invalid_tcp_length;
+        u32 rx_dropped_runt;
+        u32 rx_ip_checksum_errors;
+        u32 rx_tcp_checksum_errors;
+        u32 rx_udp_checksum_errors;
+        u32 rx_non_rss_packets;
+        u32 rsvd_111;
+        u32 rx_ipv4_packets_lo;
+        u32 rx_ipv4_packets_hi;
+        u32 rx_ipv6_packets_lo;
+        u32 rx_ipv6_packets_hi;
+        u32 rx_ipv4_bytes_lo;
+        u32 rx_ipv4_bytes_hi;
+        u32 rx_ipv6_bytes_lo;
+        u32 rx_ipv6_bytes_hi;
+        u32 rx_nic_packets_lo;
+        u32 rx_nic_packets_hi;
+        u32 rx_tcp_packets_lo;
+        u32 rx_tcp_packets_hi;
+        u32 rx_iscsi_packets_lo;
+        u32 rx_iscsi_packets_hi;
+        u32 rx_management_packets_lo;
+        u32 rx_management_packets_hi;
+        u32 rx_switched_unicast_packets_lo;
+        u32 rx_switched_unicast_packets_hi;
+        u32 rx_switched_multicast_packets_lo;
+        u32 rx_switched_multicast_packets_hi;
+        u32 rx_switched_broadcast_packets_lo;
+        u32 rx_switched_broadcast_packets_hi;
+        u32 num_forwards_lo;
+        u32 num_forwards_hi;
+        u32 rx_fifo_overflow;
+        u32 rx_input_fifo_overflow;
+        u32 rx_drops_too_many_frags_lo;
+        u32 rx_drops_too_many_frags_hi;
+        u32 rx_drops_invalid_queue;
+        u32 rsvd_141;
+        u32 rx_drops_mtu_lo;
+        u32 rx_drops_mtu_hi;
+        u32 rx_packets_64_bytes_lo;
+        u32 rx_packets_64_bytes_hi;
+        u32 rx_packets_65_to_127_bytes_lo;
+        u32 rx_packets_65_to_127_bytes_hi;
+        u32 rx_packets_128_to_255_bytes_lo;
+        u32 rx_packets_128_to_255_bytes_hi;
+        u32 rx_packets_256_to_511_bytes_lo;
+        u32 rx_packets_256_to_511_bytes_hi;
+        u32 rx_packets_512_to_1023_bytes_lo;
+        u32 rx_packets_512_to_1023_bytes_hi;
+        u32 rx_packets_1024_to_1518_bytes_lo;
+        u32 rx_packets_1024_to_1518_bytes_hi;
+        u32 rx_packets_1519_to_2047_bytes_lo;
+        u32 rx_packets_1519_to_2047_bytes_hi;
+        u32 rx_packets_2048_to_4095_bytes_lo;
+        u32 rx_packets_2048_to_4095_bytes_hi;
+        u32 rx_packets_4096_to_8191_bytes_lo;
+        u32 rx_packets_4096_to_8191_bytes_hi;
+        u32 rx_packets_8192_to_9216_bytes_lo;
+        u32 rx_packets_8192_to_9216_bytes_hi;
+};
+struct pport_stats_params {
+        u16 pport_num;
+        u8 rsvd;
+        u8 reset_stats;
+};
+struct lancer_cmd_req_pport_stats {
        struct be_cmd_req_hdr hdr;
-        u8 rsvd[sizeof(struct be_hw_stats)];
+        union {
+                struct pport_stats_params params;
+                u8 rsvd[sizeof(struct lancer_cmd_pport_stats)];
+        } cmd_params;
 };
-struct be_cmd_resp_get_stats {
+struct lancer_cmd_resp_pport_stats {
        struct be_cmd_resp_hdr hdr;
-        struct be_hw_stats hw_stats;
+        struct lancer_cmd_pport_stats pport_stats;
 };
+static inline  struct lancer_cmd_pport_stats*
+        pport_stats_from_cmd(struct be_adapter *adapter)
+{
+        struct lancer_cmd_resp_pport_stats *cmd = adapter->stats_cmd.va;
+        return &cmd->pport_stats;
+}
 struct be_cmd_req_get_cntl_addnl_attribs {
        struct be_cmd_req_hdr hdr;
        u8 rsvd[8];
@@ -695,13 +907,6 @@ struct be_cmd_req_vlan_config {
        u16 normal_vlan[64];
 } __packed;
-struct be_cmd_req_promiscuous_config {
-        struct be_cmd_req_hdr hdr;
-        u8 port0_promiscuous;
-        u8 port1_promiscuous;
-        u16 rsvd0;
-} __packed;
 /******************** Multicast MAC Config *******************/
 #define BE_MAX_MC               64 /* set mcast promisc if > 64 */
 struct macaddr {
@@ -716,11 +921,18 @@ struct be_cmd_req_mcast_mac_config {
        struct macaddr mac[BE_MAX_MC];
 } __packed;
-static inline struct be_hw_stats *
+/******************* RX FILTER ******************************/
-hw_stats_from_cmd(struct be_cmd_resp_get_stats *cmd)
+struct be_cmd_req_rx_filter {
-{
+        struct be_cmd_req_hdr hdr;
-        return &cmd->hw_stats;
+        u32 global_flags_mask;
-}
+        u32 global_flags;
+        u32 if_flags_mask;
+        u32 if_flags;
+        u32 if_id;
+        u32 multicast_num;
+        struct macaddr mac[BE_MAX_MC];
+};
 /******************** Link Status Query *******************/
 struct be_cmd_req_link_status {
@@ -920,6 +1132,36 @@ struct be_cmd_write_flashrom {
        struct flashrom_params params;
 };
+/**************** Lancer Firmware Flash ************/
+struct amap_lancer_write_obj_context {
+        u8 write_length[24];
+        u8 reserved1[7];
+        u8 eof;
+} __packed;
+struct lancer_cmd_req_write_object {
+        struct be_cmd_req_hdr hdr;
+        u8 context[sizeof(struct amap_lancer_write_obj_context) / 8];
+        u32 write_offset;
+        u8 object_name[104];
+        u32 descriptor_count;
+        u32 buf_len;
+        u32 addr_low;
+        u32 addr_high;
+};
+struct lancer_cmd_resp_write_object {
+        u8 opcode;
+        u8 subsystem;
+        u8 rsvd1[2];
+        u8 status;
+        u8 additional_status;
+        u8 rsvd2[2];
+        u32 resp_len;
+        u32 actual_resp_len;
+        u32 actual_write_len;
+};
 /************************ WOL *******************************/
 struct be_cmd_req_acpi_wol_magic_config{
        struct be_cmd_req_hdr hdr;
@@ -1061,6 +1303,151 @@ struct be_cmd_resp_set_func_cap {
        u8 rsvd[212];
 };
+/*************** HW Stats Get v1 **********************************/
+#define BE_TXP_SW_SZ                    48
+struct be_port_rxf_stats_v1 {
+        u32 rsvd0[12];
+        u32 rx_crc_errors;
+        u32 rx_alignment_symbol_errors;
+        u32 rx_pause_frames;
+        u32 rx_priority_pause_frames;
+        u32 rx_control_frames;
+        u32 rx_in_range_errors;
+        u32 rx_out_range_errors;
+        u32 rx_frame_too_long;
+        u32 rx_address_match_errors;
+        u32 rx_dropped_too_small;
+        u32 rx_dropped_too_short;
+        u32 rx_dropped_header_too_small;
+        u32 rx_dropped_tcp_length;
+        u32 rx_dropped_runt;
+        u32 rsvd1[10];
+        u32 rx_ip_checksum_errs;
+        u32 rx_tcp_checksum_errs;
+        u32 rx_udp_checksum_errs;
+        u32 rsvd2[7];
+        u32 rx_switched_unicast_packets;
+        u32 rx_switched_multicast_packets;
+        u32 rx_switched_broadcast_packets;
+        u32 rsvd3[3];
+        u32 tx_pauseframes;
+        u32 tx_priority_pauseframes;
+        u32 tx_controlframes;
+        u32 rsvd4[10];
+        u32 rxpp_fifo_overflow_drop;
+        u32 rx_input_fifo_overflow_drop;
+        u32 pmem_fifo_overflow_drop;
+        u32 jabber_events;
+        u32 rsvd5[3];
+};
+struct be_rxf_stats_v1 {
+        struct be_port_rxf_stats_v1 port[4];
+        u32 rsvd0[2];
+        u32 rx_drops_no_pbuf;
+        u32 rx_drops_no_txpb;
+        u32 rx_drops_no_erx_descr;
+        u32 rx_drops_no_tpre_descr;
+        u32 rsvd1[6];
+        u32 rx_drops_too_many_frags;
+        u32 rx_drops_invalid_ring;
+        u32 forwarded_packets;
+        u32 rx_drops_mtu;
+        u32 rsvd2[14];
+};
+struct be_erx_stats_v1 {
+        u32 rx_drops_no_fragments[68];     /* dwordS 0 to 67*/
+        u32 rsvd[4];
+};
+struct be_hw_stats_v1 {
+        struct be_rxf_stats_v1 rxf;
+        u32 rsvd0[BE_TXP_SW_SZ];
+        struct be_erx_stats_v1 erx;
+        struct be_pmem_stats pmem;
+        u32 rsvd1[3];
+};
+struct be_cmd_req_get_stats_v1 {
+        struct be_cmd_req_hdr hdr;
+        u8 rsvd[sizeof(struct be_hw_stats_v1)];
+};
+struct be_cmd_resp_get_stats_v1 {
+        struct be_cmd_resp_hdr hdr;
+        struct be_hw_stats_v1 hw_stats;
+};
+static inline void *
+hw_stats_from_cmd(struct be_adapter *adapter)
+{
+        if (adapter->generation == BE_GEN3) {
+                struct be_cmd_resp_get_stats_v1 *cmd = adapter->stats_cmd.va;
+                return &cmd->hw_stats;
+        } else {
+                struct be_cmd_resp_get_stats_v0 *cmd = adapter->stats_cmd.va;
+                return &cmd->hw_stats;
+        }
+}
+static inline void *be_port_rxf_stats_from_cmd(struct be_adapter *adapter)
+{
+        if (adapter->generation == BE_GEN3) {
+                struct be_hw_stats_v1 *hw_stats = hw_stats_from_cmd(adapter);
+                struct be_rxf_stats_v1 *rxf_stats = &hw_stats->rxf;
+                return &rxf_stats->port[adapter->port_num];
+        } else {
+                struct be_hw_stats_v0 *hw_stats = hw_stats_from_cmd(adapter);
+                struct be_rxf_stats_v0 *rxf_stats = &hw_stats->rxf;
+                return &rxf_stats->port[adapter->port_num];
+        }
+}
+static inline void *be_rxf_stats_from_cmd(struct be_adapter *adapter)
+{
+        if (adapter->generation == BE_GEN3) {
+                struct be_hw_stats_v1 *hw_stats = hw_stats_from_cmd(adapter);
+                return &hw_stats->rxf;
+        } else {
+                struct be_hw_stats_v0 *hw_stats = hw_stats_from_cmd(adapter);
+                return &hw_stats->rxf;
+        }
+}
+static inline void *be_erx_stats_from_cmd(struct be_adapter *adapter)
+{
+        if (adapter->generation == BE_GEN3) {
+                struct be_hw_stats_v1 *hw_stats = hw_stats_from_cmd(adapter);
+                return &hw_stats->erx;
+        } else {
+                struct be_hw_stats_v0 *hw_stats = hw_stats_from_cmd(adapter);
+                return &hw_stats->erx;
+        }
+}
+static inline void *be_pmem_stats_from_cmd(struct be_adapter *adapter)
+{
+        if (adapter->generation == BE_GEN3) {
+                struct be_hw_stats_v1 *hw_stats = hw_stats_from_cmd(adapter);
+                return &hw_stats->pmem;
+        } else {
+                struct be_hw_stats_v0 *hw_stats = hw_stats_from_cmd(adapter);
+                return &hw_stats->pmem;
+        }
+}
 extern int be_pci_fnum_get(struct be_adapter *adapter);
 extern int be_cmd_POST(struct be_adapter *adapter);
 extern int be_cmd_mac_addr_query(struct be_adapter *adapter, u8 *mac_addr,
@@ -1093,18 +1480,19 @@ extern int be_cmd_rxq_create(struct be_adapter *adapter,
 extern int be_cmd_q_destroy(struct be_adapter *adapter, struct be_queue_info *q,
                        int type);
 extern int be_cmd_link_status_query(struct be_adapter *adapter,
-                        bool *link_up, u8 *mac_speed, u16 *link_speed);
+                        bool *link_up, u8 *mac_speed, u16 *link_speed, u32 dom);
 extern int be_cmd_reset(struct be_adapter *adapter);
 extern int be_cmd_get_stats(struct be_adapter *adapter,
                        struct be_dma_mem *nonemb_cmd);
+extern int lancer_cmd_get_pport_stats(struct be_adapter *adapter,
+                        struct be_dma_mem *nonemb_cmd);
 extern int be_cmd_get_fw_ver(struct be_adapter *adapter, char *fw_ver);
 extern int be_cmd_modify_eqd(struct be_adapter *adapter, u32 eq_id, u32 eqd);
 extern int be_cmd_vlan_config(struct be_adapter *adapter, u32 if_id,
                        u16 *vtag_array, u32 num, bool untagged,
                        bool promiscuous);
-extern int be_cmd_promiscuous_config(struct be_adapter *adapter,
+extern int be_cmd_promiscuous_config(struct be_adapter *adapter, bool en);
-                        u8 port_num, bool en);
 extern int be_cmd_multicast_set(struct be_adapter *adapter, u32 if_id,
                        struct net_device *netdev, struct be_dma_mem *mem);
 extern int be_cmd_set_flow_control(struct be_adapter *adapter,
@@ -1124,6 +1512,11 @@ extern int be_cmd_get_beacon_state(struct be_adapter *adapter,
 extern int be_cmd_write_flashrom(struct be_adapter *adapter,
                        struct be_dma_mem *cmd, u32 flash_oper,
                        u32 flash_opcode, u32 buf_size);
+extern int lancer_cmd_write_object(struct be_adapter *adapter,
+                                struct be_dma_mem *cmd,
+                                u32 data_size, u32 data_offset,
+                                const char *obj_name,
+                                u32 *data_written, u8 *addn_status);
 int be_cmd_get_flash_crc(struct be_adapter *adapter, u8 *flashed_crc,
                                int offset);
 extern int be_cmd_enable_magic_wol(struct be_adapter *adapter, u8 *mac,
@@ -1148,4 +1541,6 @@ extern void be_detect_dump_ue(struct be_adapter *adapter);
 extern int be_cmd_get_die_temperature(struct be_adapter *adapter);
 extern int be_cmd_get_cntl_attributes(struct be_adapter *adapter);
 extern int be_cmd_check_native_mode(struct be_adapter *adapter);
+extern int be_cmd_get_reg_len(struct be_adapter *adapter, u32 *log_size);
+extern void be_cmd_get_regs(struct be_adapter *adapter, u32 buf_len, void *buf);
diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c
index aac248fbd18b..facfe3ca5c40 100644
--- a/drivers/net/benet/be_ethtool.c
+++ b/drivers/net/benet/be_ethtool.c
@@ -26,8 +26,8 @@ struct be_ethtool_stat {
        int offset;
 };
-enum {NETSTAT, PORTSTAT, MISCSTAT, DRVSTAT_TX, DRVSTAT_RX, ERXSTAT,
+enum {NETSTAT, DRVSTAT_TX, DRVSTAT_RX, ERXSTAT,
-                        PMEMSTAT, DRVSTAT};
+                        DRVSTAT};
 #define FIELDINFO(_struct, field) FIELD_SIZEOF(_struct, field), \
                                        offsetof(_struct, field)
 #define NETSTAT_INFO(field)     #field, NETSTAT,\
@@ -37,15 +37,8 @@ enum {NETSTAT, PORTSTAT, MISCSTAT, DRVSTAT_TX, DRVSTAT_RX, ERXSTAT,
                                        FIELDINFO(struct be_tx_stats, field)
 #define DRVSTAT_RX_INFO(field)  #field, DRVSTAT_RX,\
                                        FIELDINFO(struct be_rx_stats, field)
-#define MISCSTAT_INFO(field)    #field, MISCSTAT,\
+#define ERXSTAT_INFO(field)     #field, ERXSTAT,\
-                                        FIELDINFO(struct be_rxf_stats, field)
+                                        FIELDINFO(struct be_erx_stats_v1, field)
-#define PORTSTAT_INFO(field)    #field, PORTSTAT,\
-                                        FIELDINFO(struct be_port_rxf_stats, \
-                                                field)
-#define ERXSTAT_INFO(field)     #field, ERXSTAT,\
-                                        FIELDINFO(struct be_erx_stats, field)
-#define PMEMSTAT_INFO(field)    #field, PMEMSTAT,\
-                                        FIELDINFO(struct be_pmem_stats, field)
 #define DRVSTAT_INFO(field)     #field, DRVSTAT,\
                                        FIELDINFO(struct be_drv_stats, \
                                                field)
@@ -65,50 +58,41 @@ static const struct be_ethtool_stat et_stats[] = {
        {DRVSTAT_TX_INFO(be_tx_stops)},
        {DRVSTAT_TX_INFO(be_tx_events)},
        {DRVSTAT_TX_INFO(be_tx_compl)},
-        {PORTSTAT_INFO(rx_unicast_frames)},
+        {DRVSTAT_INFO(rx_crc_errors)},
-        {PORTSTAT_INFO(rx_multicast_frames)},
+        {DRVSTAT_INFO(rx_alignment_symbol_errors)},
-        {PORTSTAT_INFO(rx_broadcast_frames)},
+        {DRVSTAT_INFO(rx_pause_frames)},
-        {PORTSTAT_INFO(rx_crc_errors)},
+        {DRVSTAT_INFO(rx_control_frames)},
-        {PORTSTAT_INFO(rx_alignment_symbol_errors)},
+        {DRVSTAT_INFO(rx_in_range_errors)},
-        {PORTSTAT_INFO(rx_pause_frames)},
+        {DRVSTAT_INFO(rx_out_range_errors)},
-        {PORTSTAT_INFO(rx_control_frames)},
+        {DRVSTAT_INFO(rx_frame_too_long)},
-        {PORTSTAT_INFO(rx_in_range_errors)},
+        {DRVSTAT_INFO(rx_address_match_errors)},
-        {PORTSTAT_INFO(rx_out_range_errors)},
+        {DRVSTAT_INFO(rx_dropped_too_small)},
-        {PORTSTAT_INFO(rx_frame_too_long)},
+        {DRVSTAT_INFO(rx_dropped_too_short)},
-        {PORTSTAT_INFO(rx_address_match_errors)},
+        {DRVSTAT_INFO(rx_dropped_header_too_small)},
-        {PORTSTAT_INFO(rx_vlan_mismatch)},
+        {DRVSTAT_INFO(rx_dropped_tcp_length)},
-        {PORTSTAT_INFO(rx_dropped_too_small)},
+        {DRVSTAT_INFO(rx_dropped_runt)},
-        {PORTSTAT_INFO(rx_dropped_too_short)},
+        {DRVSTAT_INFO(rxpp_fifo_overflow_drop)},
-        {PORTSTAT_INFO(rx_dropped_header_too_small)},
+        {DRVSTAT_INFO(rx_input_fifo_overflow_drop)},
-        {PORTSTAT_INFO(rx_dropped_tcp_length)},
+        {DRVSTAT_INFO(rx_ip_checksum_errs)},
-        {PORTSTAT_INFO(rx_dropped_runt)},
+        {DRVSTAT_INFO(rx_tcp_checksum_errs)},
-        {PORTSTAT_INFO(rx_fifo_overflow)},
+        {DRVSTAT_INFO(rx_udp_checksum_errs)},
-        {PORTSTAT_INFO(rx_input_fifo_overflow)},
+        {DRVSTAT_INFO(rx_switched_unicast_packets)},
-        {PORTSTAT_INFO(rx_ip_checksum_errs)},
+        {DRVSTAT_INFO(rx_switched_multicast_packets)},
-        {PORTSTAT_INFO(rx_tcp_checksum_errs)},
+        {DRVSTAT_INFO(rx_switched_broadcast_packets)},
-        {PORTSTAT_INFO(rx_udp_checksum_errs)},
+        {DRVSTAT_INFO(tx_pauseframes)},
-        {PORTSTAT_INFO(rx_non_rss_packets)},
+        {DRVSTAT_INFO(tx_controlframes)},
-        {PORTSTAT_INFO(rx_ipv4_packets)},
+        {DRVSTAT_INFO(rx_priority_pause_frames)},
-        {PORTSTAT_INFO(rx_ipv6_packets)},
+        {DRVSTAT_INFO(pmem_fifo_overflow_drop)},
-        {PORTSTAT_INFO(rx_switched_unicast_packets)},
+        {DRVSTAT_INFO(jabber_events)},
-        {PORTSTAT_INFO(rx_switched_multicast_packets)},
+        {DRVSTAT_INFO(rx_drops_no_pbuf)},
-        {PORTSTAT_INFO(rx_switched_broadcast_packets)},
+        {DRVSTAT_INFO(rx_drops_no_txpb)},
-        {PORTSTAT_INFO(tx_unicastframes)},
+        {DRVSTAT_INFO(rx_drops_no_erx_descr)},
-        {PORTSTAT_INFO(tx_multicastframes)},
+        {DRVSTAT_INFO(rx_drops_no_tpre_descr)},
-        {PORTSTAT_INFO(tx_broadcastframes)},
+        {DRVSTAT_INFO(rx_drops_too_many_frags)},
-        {PORTSTAT_INFO(tx_pauseframes)},
+        {DRVSTAT_INFO(rx_drops_invalid_ring)},
-        {PORTSTAT_INFO(tx_controlframes)},
+        {DRVSTAT_INFO(forwarded_packets)},
-        {MISCSTAT_INFO(rx_drops_no_pbuf)},
+        {DRVSTAT_INFO(rx_drops_mtu)},
-        {MISCSTAT_INFO(rx_drops_no_txpb)},
+        {DRVSTAT_INFO(eth_red_drops)},
-        {MISCSTAT_INFO(rx_drops_no_erx_descr)},
-        {MISCSTAT_INFO(rx_drops_no_tpre_descr)},
-        {MISCSTAT_INFO(rx_drops_too_many_frags)},
-        {MISCSTAT_INFO(rx_drops_invalid_ring)},
-        {MISCSTAT_INFO(forwarded_packets)},
-        {MISCSTAT_INFO(rx_drops_mtu)},
-        {MISCSTAT_INFO(port0_jabber_events)},
-        {MISCSTAT_INFO(port1_jabber_events)},
-        {PMEMSTAT_INFO(eth_red_drops)},
        {DRVSTAT_INFO(be_on_die_temperature)}
 };
 #define ETHTOOL_STATS_NUM ARRAY_SIZE(et_stats)
@@ -156,6 +140,29 @@ be_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo)
 }
 static int
+be_get_reg_len(struct net_device *netdev)
+{
+        struct be_adapter *adapter = netdev_priv(netdev);
+        u32 log_size = 0;
+        if (be_physfn(adapter))
+                be_cmd_get_reg_len(adapter, &log_size);
+        return log_size;
+}
+static void
+be_get_regs(struct net_device *netdev, struct ethtool_regs *regs, void *buf)
+{
+        struct be_adapter *adapter = netdev_priv(netdev);
+        if (be_physfn(adapter)) {
+                memset(buf, 0, regs->len);
+                be_cmd_get_regs(adapter, regs->len, buf);
+        }
+}
+static int
 be_get_coalesce(struct net_device *netdev, struct ethtool_coalesce *coalesce)
 {
        struct be_adapter *adapter = netdev_priv(netdev);
@@ -186,9 +193,9 @@ be_set_coalesce(struct net_device *netdev, struct ethtool_coalesce *coalesce)
        struct be_rx_obj *rxo;
        struct be_eq_obj *rx_eq;
        struct be_eq_obj *tx_eq = &adapter->tx_eq;
-        u32 tx_max, tx_min, tx_cur;
        u32 rx_max, rx_min, rx_cur;
        int status = 0, i;
+        u32 tx_cur;
        if (coalesce->use_adaptive_tx_coalesce == 1)
                return -EINVAL;
@@ -227,8 +234,6 @@ be_set_coalesce(struct net_device *netdev, struct ethtool_coalesce *coalesce)
                }
        }
-        tx_max = coalesce->tx_coalesce_usecs_high;
-        tx_min = coalesce->tx_coalesce_usecs_low;
        tx_cur = coalesce->tx_coalesce_usecs;
        if (tx_cur > BE_MAX_EQD)
@@ -242,32 +247,11 @@ be_set_coalesce(struct net_device *netdev, struct ethtool_coalesce *coalesce)
        return 0;
 }
-static u32 be_get_rx_csum(struct net_device *netdev)
-{
-        struct be_adapter *adapter = netdev_priv(netdev);
-        return adapter->rx_csum;
-}
-static int be_set_rx_csum(struct net_device *netdev, uint32_t data)
-{
-        struct be_adapter *adapter = netdev_priv(netdev);
-        if (data)
-                adapter->rx_csum = true;
-        else
-                adapter->rx_csum = false;
-        return 0;
-}
 static void
 be_get_ethtool_stats(struct net_device *netdev,
                struct ethtool_stats *stats, uint64_t *data)
 {
        struct be_adapter *adapter = netdev_priv(netdev);
-        struct be_hw_stats *hw_stats = hw_stats_from_cmd(adapter->stats_cmd.va);
-        struct be_erx_stats *erx_stats = &hw_stats->erx;
        struct be_rx_obj *rxo;
        void *p = NULL;
        int i, j;
@@ -280,15 +264,6 @@ be_get_ethtool_stats(struct net_device *netdev,
                case DRVSTAT_TX:
                        p = &adapter->tx_stats;
                        break;
-                case PORTSTAT:
-                        p = &hw_stats->rxf.port[adapter->port_num];
-                        break;
-                case MISCSTAT:
-                        p = &hw_stats->rxf;
-                        break;
-                case PMEMSTAT:
-                        p = &hw_stats->pmem;
-                        break;
                case DRVSTAT:
                        p = &adapter->drv_stats;
                        break;
@@ -306,7 +281,8 @@ be_get_ethtool_stats(struct net_device *netdev,
                                p = (u8 *)&rxo->stats + et_rx_stats[i].offset;
                                break;
                        case ERXSTAT:
-                                p = (u32 *)erx_stats + rxo->q.id;
+                                p = (u32 *)be_erx_stats_from_cmd(adapter) +
+                                                                rxo->q.id;
                                break;
                        }
                        data[ETHTOOL_STATS_NUM + j * ETHTOOL_RXSTATS_NUM + i] =
@@ -374,19 +350,28 @@ static int be_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
        if ((adapter->link_speed < 0) || (!(netdev->flags & IFF_UP))) {
                status = be_cmd_link_status_query(adapter, &link_up,
-                                                &mac_speed, &link_speed);
+                                                &mac_speed, &link_speed, 0);
                be_link_status_update(adapter, link_up);
                /* link_speed is in units of 10 Mbps */
                if (link_speed) {
-                        ecmd->speed = link_speed*10;
+                        ethtool_cmd_speed_set(ecmd, link_speed*10);
                } else {
                        switch (mac_speed) {
+                        case PHY_LINK_SPEED_10MBPS:
+                                ethtool_cmd_speed_set(ecmd, SPEED_10);
+                                break;
+                        case PHY_LINK_SPEED_100MBPS:
+                                ethtool_cmd_speed_set(ecmd, SPEED_100);
+                                break;
                        case PHY_LINK_SPEED_1GBPS:
-                                ecmd->speed = SPEED_1000;
+                                ethtool_cmd_speed_set(ecmd, SPEED_1000);
                                break;
                        case PHY_LINK_SPEED_10GBPS:
-                                ecmd->speed = SPEED_10000;
+                                ethtool_cmd_speed_set(ecmd, SPEED_10000);
+                                break;
+                        case PHY_LINK_SPEED_ZERO:
+                                ethtool_cmd_speed_set(ecmd, 0);
                                break;
                        }
                }
@@ -429,14 +414,14 @@ static int be_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
                }
                /* Save for future use */
-                adapter->link_speed = ecmd->speed;
+                adapter->link_speed = ethtool_cmd_speed(ecmd);
                adapter->port_type = ecmd->port;
                adapter->transceiver = ecmd->transceiver;
                adapter->autoneg = ecmd->autoneg;
                dma_free_coherent(&adapter->pdev->dev, phy_cmd.size, phy_cmd.va,
                                  phy_cmd.dma);
        } else {
-                ecmd->speed = adapter->link_speed;
+                ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                ecmd->port = adapter->port_type;
                ecmd->transceiver = adapter->transceiver;
                ecmd->autoneg = adapter->autoneg;
@@ -507,29 +492,33 @@ be_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *ecmd)
 }
 static int
-be_phys_id(struct net_device *netdev, u32 data)
+be_set_phys_id(struct net_device *netdev,
+               enum ethtool_phys_id_state state)
 {
        struct be_adapter *adapter = netdev_priv(netdev);
-        int status;
-        u32 cur;
-        be_cmd_get_beacon_state(adapter, adapter->hba_port_num, &cur);
-        if (cur == BEACON_STATE_ENABLED)
+        switch (state) {
-                return 0;
+        case ETHTOOL_ID_ACTIVE:
+                be_cmd_get_beacon_state(adapter, adapter->hba_port_num,
+                                        &adapter->beacon_state);
+                return 1;       /* cycle on/off once per second */
-        if (data < 2)
+        case ETHTOOL_ID_ON:
-                data = 2;
+                be_cmd_set_beacon_state(adapter, adapter->hba_port_num, 0, 0,
+                                        BEACON_STATE_ENABLED);
+                break;
-        status = be_cmd_set_beacon_state(adapter, adapter->hba_port_num, 0, 0,
+        case ETHTOOL_ID_OFF:
-                        BEACON_STATE_ENABLED);
+                be_cmd_set_beacon_state(adapter, adapter->hba_port_num, 0, 0,
-        set_current_state(TASK_INTERRUPTIBLE);
+                                        BEACON_STATE_DISABLED);
-        schedule_timeout(data*HZ);
+                break;
-        status = be_cmd_set_beacon_state(adapter, adapter->hba_port_num, 0, 0,
+        case ETHTOOL_ID_INACTIVE:
-                        BEACON_STATE_DISABLED);
+                be_cmd_set_beacon_state(adapter, adapter->hba_port_num, 0, 0,
+                                        adapter->beacon_state);
+        }
-        return status;
+        return 0;
 }
 static bool
@@ -646,7 +635,7 @@ be_self_test(struct net_device *netdev, struct ethtool_test *test, u64 *data)
        }
        if (be_cmd_link_status_query(adapter, &link_up, &mac_speed,
-                                &qos_link_speed) != 0) {
+                                &qos_link_speed, 0) != 0) {
                test->flags |= ETH_TEST_FL_FAILED;
                data[4] = -1;
        } else if (!mac_speed) {
@@ -660,11 +649,9 @@ be_do_flash(struct net_device *netdev, struct ethtool_flash *efl)
 {
        struct be_adapter *adapter = netdev_priv(netdev);
        char file_name[ETHTOOL_FLASH_MAX_FILENAME];
-        u32 region;
        file_name[ETHTOOL_FLASH_MAX_FILENAME - 1] = 0;
        strcpy(file_name, efl->data);
-        region = efl->region;
        return be_load_fw(adapter, file_name);
 }
@@ -725,18 +712,12 @@ const struct ethtool_ops be_ethtool_ops = {
        .get_ringparam = be_get_ringparam,
        .get_pauseparam = be_get_pauseparam,
        .set_pauseparam = be_set_pauseparam,
-        .get_rx_csum = be_get_rx_csum,
-        .set_rx_csum = be_set_rx_csum,
-        .get_tx_csum = ethtool_op_get_tx_csum,
-        .set_tx_csum = ethtool_op_set_tx_hw_csum,
-        .get_sg = ethtool_op_get_sg,
-        .set_sg = ethtool_op_set_sg,
-        .get_tso = ethtool_op_get_tso,
-        .set_tso = ethtool_op_set_tso,
        .get_strings = be_get_stat_strings,
-        .phys_id = be_phys_id,
+        .set_phys_id = be_set_phys_id,
        .get_sset_count = be_get_sset_count,
        .get_ethtool_stats = be_get_ethtool_stats,
+        .get_regs_len = be_get_reg_len,
+        .get_regs = be_get_regs,
        .flash_device = be_do_flash,
        .self_test = be_self_test,
 };
diff --git a/drivers/net/benet/be_hw.h b/drivers/net/benet/be_hw.h
index d4344a06090b..53d658afea2a 100644
--- a/drivers/net/benet/be_hw.h
+++ b/drivers/net/benet/be_hw.h
@@ -155,6 +155,10 @@
 /********** SRIOV VF PCICFG OFFSET ********/
 #define SRIOV_VF_PCICFG_OFFSET          (4096)
+/********** FAT TABLE  ********/
+#define RETRIEVE_FAT    0
+#define QUERY_FAT       1
 /* Flashrom related descriptors */
 #define IMAGE_TYPE_FIRMWARE             160
 #define IMAGE_TYPE_BOOTCODE             224
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
index 9187fb4e08f1..4b5e0ed49ed8 100644
--- a/drivers/net/benet/be_main.c
+++ b/drivers/net/benet/be_main.c
@@ -42,6 +42,7 @@ static DEFINE_PCI_DEVICE_TABLE(be_dev_ids) = {
        { PCI_DEVICE(BE_VENDOR_ID, OC_DEVICE_ID1) },
        { PCI_DEVICE(BE_VENDOR_ID, OC_DEVICE_ID2) },
        { PCI_DEVICE(EMULEX_VENDOR_ID, OC_DEVICE_ID3)},
+        { PCI_DEVICE(EMULEX_VENDOR_ID, OC_DEVICE_ID4)},
        { 0 }
 };
 MODULE_DEVICE_TABLE(pci, be_dev_ids);
@@ -116,11 +117,6 @@ static char *ue_status_hi_desc[] = {
        "Unknown"
 };
-static inline bool be_multi_rxq(struct be_adapter *adapter)
-{
-        return (adapter->num_rx_qs > 1);
-}
 static void be_queue_free(struct be_adapter *adapter, struct be_queue_info *q)
 {
        struct be_dma_mem *mem = &q->dma_mem;
@@ -250,14 +246,185 @@ netdev_addr:
        return status;
 }
+static void populate_be2_stats(struct be_adapter *adapter)
+{
+        struct be_drv_stats *drvs = &adapter->drv_stats;
+        struct be_pmem_stats *pmem_sts = be_pmem_stats_from_cmd(adapter);
+        struct be_port_rxf_stats_v0 *port_stats =
+                be_port_rxf_stats_from_cmd(adapter);
+        struct be_rxf_stats_v0 *rxf_stats =
+                be_rxf_stats_from_cmd(adapter);
+        drvs->rx_pause_frames = port_stats->rx_pause_frames;
+        drvs->rx_crc_errors = port_stats->rx_crc_errors;
+        drvs->rx_control_frames = port_stats->rx_control_frames;
+        drvs->rx_in_range_errors = port_stats->rx_in_range_errors;
+        drvs->rx_frame_too_long = port_stats->rx_frame_too_long;
+        drvs->rx_dropped_runt = port_stats->rx_dropped_runt;
+        drvs->rx_ip_checksum_errs = port_stats->rx_ip_checksum_errs;
+        drvs->rx_tcp_checksum_errs = port_stats->rx_tcp_checksum_errs;
+        drvs->rx_udp_checksum_errs = port_stats->rx_udp_checksum_errs;
+        drvs->rxpp_fifo_overflow_drop = port_stats->rx_fifo_overflow;
+        drvs->rx_dropped_tcp_length = port_stats->rx_dropped_tcp_length;
+        drvs->rx_dropped_too_small = port_stats->rx_dropped_too_small;
+        drvs->rx_dropped_too_short = port_stats->rx_dropped_too_short;
+        drvs->rx_out_range_errors = port_stats->rx_out_range_errors;
+        drvs->rx_input_fifo_overflow_drop =
+                port_stats->rx_input_fifo_overflow;
+        drvs->rx_dropped_header_too_small =
+                port_stats->rx_dropped_header_too_small;
+        drvs->rx_address_match_errors =
+                port_stats->rx_address_match_errors;
+        drvs->rx_alignment_symbol_errors =
+                port_stats->rx_alignment_symbol_errors;
+        drvs->tx_pauseframes = port_stats->tx_pauseframes;
+        drvs->tx_controlframes = port_stats->tx_controlframes;
+        if (adapter->port_num)
+                drvs->jabber_events =
+                        rxf_stats->port1_jabber_events;
+        else
+                drvs->jabber_events =
+                        rxf_stats->port0_jabber_events;
+        drvs->rx_drops_no_pbuf = rxf_stats->rx_drops_no_pbuf;
+        drvs->rx_drops_no_txpb = rxf_stats->rx_drops_no_txpb;
+        drvs->rx_drops_no_erx_descr = rxf_stats->rx_drops_no_erx_descr;
+        drvs->rx_drops_invalid_ring = rxf_stats->rx_drops_invalid_ring;
+        drvs->forwarded_packets = rxf_stats->forwarded_packets;
+        drvs->rx_drops_mtu = rxf_stats->rx_drops_mtu;
+        drvs->rx_drops_no_tpre_descr =
+                rxf_stats->rx_drops_no_tpre_descr;
+        drvs->rx_drops_too_many_frags =
+                rxf_stats->rx_drops_too_many_frags;
+        adapter->drv_stats.eth_red_drops = pmem_sts->eth_red_drops;
+}
+static void populate_be3_stats(struct be_adapter *adapter)
+{
+        struct be_drv_stats *drvs = &adapter->drv_stats;
+        struct be_pmem_stats *pmem_sts = be_pmem_stats_from_cmd(adapter);
+        struct be_rxf_stats_v1 *rxf_stats =
+                be_rxf_stats_from_cmd(adapter);
+        struct be_port_rxf_stats_v1 *port_stats =
+                be_port_rxf_stats_from_cmd(adapter);
+        drvs->rx_priority_pause_frames = 0;
+        drvs->pmem_fifo_overflow_drop = 0;
+        drvs->rx_pause_frames = port_stats->rx_pause_frames;
+        drvs->rx_crc_errors = port_stats->rx_crc_errors;
+        drvs->rx_control_frames = port_stats->rx_control_frames;
+        drvs->rx_in_range_errors = port_stats->rx_in_range_errors;
+        drvs->rx_frame_too_long = port_stats->rx_frame_too_long;
+        drvs->rx_dropped_runt = port_stats->rx_dropped_runt;
+        drvs->rx_ip_checksum_errs = port_stats->rx_ip_checksum_errs;
+        drvs->rx_tcp_checksum_errs = port_stats->rx_tcp_checksum_errs;
+        drvs->rx_udp_checksum_errs = port_stats->rx_udp_checksum_errs;
+        drvs->rx_dropped_tcp_length = port_stats->rx_dropped_tcp_length;
+        drvs->rx_dropped_too_small = port_stats->rx_dropped_too_small;
+        drvs->rx_dropped_too_short = port_stats->rx_dropped_too_short;
+        drvs->rx_out_range_errors = port_stats->rx_out_range_errors;
+        drvs->rx_dropped_header_too_small =
+                port_stats->rx_dropped_header_too_small;
+        drvs->rx_input_fifo_overflow_drop =
+                port_stats->rx_input_fifo_overflow_drop;
+        drvs->rx_address_match_errors =
+                port_stats->rx_address_match_errors;
+        drvs->rx_alignment_symbol_errors =
+                port_stats->rx_alignment_symbol_errors;
+        drvs->rxpp_fifo_overflow_drop =
+                port_stats->rxpp_fifo_overflow_drop;
+        drvs->tx_pauseframes = port_stats->tx_pauseframes;
+        drvs->tx_controlframes = port_stats->tx_controlframes;
+        drvs->jabber_events = port_stats->jabber_events;
+        drvs->rx_drops_no_pbuf = rxf_stats->rx_drops_no_pbuf;
+        drvs->rx_drops_no_txpb = rxf_stats->rx_drops_no_txpb;
+        drvs->rx_drops_no_erx_descr = rxf_stats->rx_drops_no_erx_descr;
+        drvs->rx_drops_invalid_ring = rxf_stats->rx_drops_invalid_ring;
+        drvs->forwarded_packets = rxf_stats->forwarded_packets;
+        drvs->rx_drops_mtu = rxf_stats->rx_drops_mtu;
+        drvs->rx_drops_no_tpre_descr =
+                rxf_stats->rx_drops_no_tpre_descr;
+        drvs->rx_drops_too_many_frags =
+                rxf_stats->rx_drops_too_many_frags;
+        adapter->drv_stats.eth_red_drops = pmem_sts->eth_red_drops;
+}
+static void populate_lancer_stats(struct be_adapter *adapter)
+{
+        struct be_drv_stats *drvs = &adapter->drv_stats;
+        struct lancer_cmd_pport_stats *pport_stats = pport_stats_from_cmd
+                                                (adapter);
+        drvs->rx_priority_pause_frames = 0;
+        drvs->pmem_fifo_overflow_drop = 0;
+        drvs->rx_pause_frames =
+                make_64bit_val(pport_stats->rx_pause_frames_lo,
+                                 pport_stats->rx_pause_frames_hi);
+        drvs->rx_crc_errors = make_64bit_val(pport_stats->rx_crc_errors_hi,
+                                                pport_stats->rx_crc_errors_lo);
+        drvs->rx_control_frames =
+                        make_64bit_val(pport_stats->rx_control_frames_hi,
+                        pport_stats->rx_control_frames_lo);
+        drvs->rx_in_range_errors = pport_stats->rx_in_range_errors;
+        drvs->rx_frame_too_long =
+                make_64bit_val(pport_stats->rx_internal_mac_errors_hi,
+                                        pport_stats->rx_frames_too_long_lo);
+        drvs->rx_dropped_runt = pport_stats->rx_dropped_runt;
+        drvs->rx_ip_checksum_errs = pport_stats->rx_ip_checksum_errors;
+        drvs->rx_tcp_checksum_errs = pport_stats->rx_tcp_checksum_errors;
+        drvs->rx_udp_checksum_errs = pport_stats->rx_udp_checksum_errors;
+        drvs->rx_dropped_tcp_length =
+                                pport_stats->rx_dropped_invalid_tcp_length;
+        drvs->rx_dropped_too_small = pport_stats->rx_dropped_too_small;
+        drvs->rx_dropped_too_short = pport_stats->rx_dropped_too_short;
+        drvs->rx_out_range_errors = pport_stats->rx_out_of_range_errors;
+        drvs->rx_dropped_header_too_small =
+                                pport_stats->rx_dropped_header_too_small;
+        drvs->rx_input_fifo_overflow_drop = pport_stats->rx_fifo_overflow;
+        drvs->rx_address_match_errors = pport_stats->rx_address_match_errors;
+        drvs->rx_alignment_symbol_errors =
+                make_64bit_val(pport_stats->rx_symbol_errors_hi,
+                                pport_stats->rx_symbol_errors_lo);
+        drvs->rxpp_fifo_overflow_drop = pport_stats->rx_fifo_overflow;
+        drvs->tx_pauseframes = make_64bit_val(pport_stats->tx_pause_frames_hi,
+                                        pport_stats->tx_pause_frames_lo);
+        drvs->tx_controlframes =
+                make_64bit_val(pport_stats->tx_control_frames_hi,
+                                pport_stats->tx_control_frames_lo);
+        drvs->jabber_events = pport_stats->rx_jabbers;
+        drvs->rx_drops_no_pbuf = 0;
+        drvs->rx_drops_no_txpb = 0;
+        drvs->rx_drops_no_erx_descr = 0;
+        drvs->rx_drops_invalid_ring = pport_stats->rx_drops_invalid_queue;
+        drvs->forwarded_packets = make_64bit_val(pport_stats->num_forwards_hi,
+                                                pport_stats->num_forwards_lo);
+        drvs->rx_drops_mtu = make_64bit_val(pport_stats->rx_drops_mtu_hi,
+                                                pport_stats->rx_drops_mtu_lo);
+        drvs->rx_drops_no_tpre_descr = 0;
+        drvs->rx_drops_too_many_frags =
+                make_64bit_val(pport_stats->rx_drops_too_many_frags_hi,
+                                pport_stats->rx_drops_too_many_frags_lo);
+}
+void be_parse_stats(struct be_adapter *adapter)
+{
+        if (adapter->generation == BE_GEN3) {
+                if (lancer_chip(adapter))
+                        populate_lancer_stats(adapter);
+                 else
+                        populate_be3_stats(adapter);
+        } else {
+                populate_be2_stats(adapter);
+        }
+}
 void netdev_stats_update(struct be_adapter *adapter)
 {
-        struct be_hw_stats *hw_stats = hw_stats_from_cmd(adapter->stats_cmd.va);
+        struct be_drv_stats *drvs = &adapter->drv_stats;
-        struct be_rxf_stats *rxf_stats = &hw_stats->rxf;
-        struct be_port_rxf_stats *port_stats =
-                        &rxf_stats->port[adapter->port_num];
        struct net_device_stats *dev_stats = &adapter->netdev->stats;
-        struct be_erx_stats *erx_stats = &hw_stats->erx;
        struct be_rx_obj *rxo;
        int i;
@@ -267,43 +434,54 @@ void netdev_stats_update(struct be_adapter *adapter)
                dev_stats->rx_bytes += rx_stats(rxo)->rx_bytes;
                dev_stats->multicast += rx_stats(rxo)->rx_mcast_pkts;
                /*  no space in linux buffers: best possible approximation */
-                dev_stats->rx_dropped +=
+                if (adapter->generation == BE_GEN3) {
-                        erx_stats->rx_drops_no_fragments[rxo->q.id];
+                        if (!(lancer_chip(adapter))) {
+                                struct be_erx_stats_v1 *erx_stats =
+                                        be_erx_stats_from_cmd(adapter);
+                                dev_stats->rx_dropped +=
+                                erx_stats->rx_drops_no_fragments[rxo->q.id];
+                        }
+                } else {
+                        struct be_erx_stats_v0 *erx_stats =
+                                        be_erx_stats_from_cmd(adapter);
+                        dev_stats->rx_dropped +=
+                                erx_stats->rx_drops_no_fragments[rxo->q.id];
+                }
        }
        dev_stats->tx_packets = tx_stats(adapter)->be_tx_pkts;
        dev_stats->tx_bytes = tx_stats(adapter)->be_tx_bytes;
        /* bad pkts received */
-        dev_stats->rx_errors = port_stats->rx_crc_errors +
+        dev_stats->rx_errors = drvs->rx_crc_errors +
-                port_stats->rx_alignment_symbol_errors +
+                drvs->rx_alignment_symbol_errors +
-                port_stats->rx_in_range_errors +
+                drvs->rx_in_range_errors +
-                port_stats->rx_out_range_errors +
+                drvs->rx_out_range_errors +
-                port_stats->rx_frame_too_long +
+                drvs->rx_frame_too_long +
-                port_stats->rx_dropped_too_small +
+                drvs->rx_dropped_too_small +
-                port_stats->rx_dropped_too_short +
+                drvs->rx_dropped_too_short +
-                port_stats->rx_dropped_header_too_small +
+                drvs->rx_dropped_header_too_small +
-                port_stats->rx_dropped_tcp_length +
+                drvs->rx_dropped_tcp_length +
-                port_stats->rx_dropped_runt +
+                drvs->rx_dropped_runt +
-                port_stats->rx_tcp_checksum_errs +
+                drvs->rx_tcp_checksum_errs +
-                port_stats->rx_ip_checksum_errs +
+                drvs->rx_ip_checksum_errs +
-                port_stats->rx_udp_checksum_errs;
+                drvs->rx_udp_checksum_errs;
        /* detailed rx errors */
-        dev_stats->rx_length_errors = port_stats->rx_in_range_errors +
+        dev_stats->rx_length_errors = drvs->rx_in_range_errors +
-                port_stats->rx_out_range_errors +
+                drvs->rx_out_range_errors +
-                port_stats->rx_frame_too_long;
+                drvs->rx_frame_too_long;
-        dev_stats->rx_crc_errors = port_stats->rx_crc_errors;
+        dev_stats->rx_crc_errors = drvs->rx_crc_errors;
        /* frame alignment errors */
-        dev_stats->rx_frame_errors = port_stats->rx_alignment_symbol_errors;
+        dev_stats->rx_frame_errors = drvs->rx_alignment_symbol_errors;
        /* receiver fifo overrun */
        /* drops_no_pbuf is no per i/f, it's per BE card */
-        dev_stats->rx_fifo_errors = port_stats->rx_fifo_overflow +
+        dev_stats->rx_fifo_errors = drvs->rxpp_fifo_overflow_drop +
-                                        port_stats->rx_input_fifo_overflow +
+                                drvs->rx_input_fifo_overflow_drop +
-                                        rxf_stats->rx_drops_no_pbuf;
+                                drvs->rx_drops_no_pbuf;
 }
 void be_link_status_update(struct be_adapter *adapter, bool link_up)
@@ -703,7 +881,7 @@ static void be_set_multicast_list(struct net_device *netdev)
        struct be_adapter *adapter = netdev_priv(netdev);
        if (netdev->flags & IFF_PROMISC) {
-                be_cmd_promiscuous_config(adapter, adapter->port_num, 1);
+                be_cmd_promiscuous_config(adapter, true);
                adapter->promiscuous = true;
                goto done;
        }
@@ -711,7 +889,7 @@ static void be_set_multicast_list(struct net_device *netdev)
        /* BE was previously in promiscuous mode; disable it */
        if (adapter->promiscuous) {
                adapter->promiscuous = false;
-                be_cmd_promiscuous_config(adapter, adapter->port_num, 0);
+                be_cmd_promiscuous_config(adapter, false);
        }
        /* Enable multicast promisc if num configured exceeds what we support */
@@ -993,9 +1171,10 @@ static void be_rx_compl_process(struct be_adapter *adapter,
                        struct be_rx_obj *rxo,
                        struct be_rx_compl_info *rxcp)
 {
+        struct net_device *netdev = adapter->netdev;
        struct sk_buff *skb;
-        skb = netdev_alloc_skb_ip_align(adapter->netdev, BE_HDR_LEN);
+        skb = netdev_alloc_skb_ip_align(netdev, BE_HDR_LEN);
        if (unlikely(!skb)) {
                if (net_ratelimit())
                        dev_warn(&adapter->pdev->dev, "skb alloc failed\n");
@@ -1005,13 +1184,16 @@ static void be_rx_compl_process(struct be_adapter *adapter,
        skb_fill_rx_data(adapter, rxo, skb, rxcp);
-        if (likely(adapter->rx_csum && csum_passed(rxcp)))
+        if (likely((netdev->features & NETIF_F_RXCSUM) && csum_passed(rxcp)))
                skb->ip_summed = CHECKSUM_UNNECESSARY;
        else
                skb_checksum_none_assert(skb);
        skb->truesize = skb->len + sizeof(struct sk_buff);
-        skb->protocol = eth_type_trans(skb, adapter->netdev);
+        skb->protocol = eth_type_trans(skb, netdev);
+        if (adapter->netdev->features & NETIF_F_RXHASH)
+                skb->rxhash = rxcp->rss_hash;
        if (unlikely(rxcp->vlanf)) {
                if (!adapter->vlan_grp || adapter->vlans_added == 0) {
@@ -1073,6 +1255,8 @@ static void be_rx_compl_process_gro(struct be_adapter *adapter,
        skb->data_len = rxcp->pkt_size;
        skb->truesize += rxcp->pkt_size;
        skb->ip_summed = CHECKSUM_UNNECESSARY;
+        if (adapter->netdev->features & NETIF_F_RXHASH)
+                skb->rxhash = rxcp->rss_hash;
        if (likely(!rxcp->vlanf))
                napi_gro_frags(&eq_obj->napi);
@@ -1103,9 +1287,14 @@ static void be_parse_rx_compl_v1(struct be_adapter *adapter,
                AMAP_GET_BITS(struct amap_eth_rx_compl_v1, numfrags, compl);
        rxcp->pkt_type =
                AMAP_GET_BITS(struct amap_eth_rx_compl_v1, cast_enc, compl);
-        rxcp->vtm = AMAP_GET_BITS(struct amap_eth_rx_compl_v1, vtm, compl);
+        rxcp->rss_hash =
-        rxcp->vlan_tag = AMAP_GET_BITS(struct amap_eth_rx_compl_v1, vlan_tag,
+                AMAP_GET_BITS(struct amap_eth_rx_compl_v1, rsshash, rxcp);
-                                        compl);
+        if (rxcp->vlanf) {
+                rxcp->vtm = AMAP_GET_BITS(struct amap_eth_rx_compl_v1, vtm,
+                                          compl);
+                rxcp->vlan_tag = AMAP_GET_BITS(struct amap_eth_rx_compl_v1, vlan_tag,
+                                               compl);
+        }
 }
 static void be_parse_rx_compl_v0(struct be_adapter *adapter,
@@ -1130,9 +1319,14 @@ static void be_parse_rx_compl_v0(struct be_adapter *adapter,
                AMAP_GET_BITS(struct amap_eth_rx_compl_v0, numfrags, compl);
        rxcp->pkt_type =
                AMAP_GET_BITS(struct amap_eth_rx_compl_v0, cast_enc, compl);
-        rxcp->vtm = AMAP_GET_BITS(struct amap_eth_rx_compl_v0, vtm, compl);
+        rxcp->rss_hash =
-        rxcp->vlan_tag = AMAP_GET_BITS(struct amap_eth_rx_compl_v0, vlan_tag,
+                AMAP_GET_BITS(struct amap_eth_rx_compl_v0, rsshash, rxcp);
-                                        compl);
+        if (rxcp->vlanf) {
+                rxcp->vtm = AMAP_GET_BITS(struct amap_eth_rx_compl_v0, vtm,
+                                          compl);
+                rxcp->vlan_tag = AMAP_GET_BITS(struct amap_eth_rx_compl_v0, vlan_tag,
+                                               compl);
+        }
 }
 static struct be_rx_compl_info *be_rx_compl_get(struct be_rx_obj *rxo)
@@ -1154,17 +1348,20 @@ static struct be_rx_compl_info *be_rx_compl_get(struct be_rx_obj *rxo)
        else
                be_parse_rx_compl_v0(adapter, compl, rxcp);
-        /* vlanf could be wrongly set in some cards. ignore if vtm is not set */
+        if (rxcp->vlanf) {
-        if ((adapter->function_mode & 0x400) && !rxcp->vtm)
+                /* vlanf could be wrongly set in some cards.
-                rxcp->vlanf = 0;
+                 * ignore if vtm is not set */
+                if ((adapter->function_mode & 0x400) && !rxcp->vtm)
+                        rxcp->vlanf = 0;
-        if (!lancer_chip(adapter))
+                if (!lancer_chip(adapter))
-                rxcp->vlan_tag = swab16(rxcp->vlan_tag);
+                        rxcp->vlan_tag = swab16(rxcp->vlan_tag);
-        if (((adapter->pvid & VLAN_VID_MASK) ==
+                if (((adapter->pvid & VLAN_VID_MASK) ==
-                (rxcp->vlan_tag & VLAN_VID_MASK)) &&
+                     (rxcp->vlan_tag & VLAN_VID_MASK)) &&
-                !adapter->vlan_tag[rxcp->vlan_tag])
+                    !adapter->vlan_tag[rxcp->vlan_tag])
-                rxcp->vlanf = 0;
+                        rxcp->vlanf = 0;
+        }
        /* As the compl has been parsed, reset it; we wont touch it again */
        compl->dw[offsetof(struct amap_eth_rx_compl_v1, valid) / 32] = 0;
@@ -1261,7 +1458,7 @@ static struct be_eth_tx_compl *be_tx_compl_get(struct be_queue_info *tx_cq)
        return txcp;
 }
-static void be_tx_compl_process(struct be_adapter *adapter, u16 last_index)
+static u16 be_tx_compl_process(struct be_adapter *adapter, u16 last_index)
 {
        struct be_queue_info *txq = &adapter->tx_obj.q;
        struct be_eth_wrb *wrb;
@@ -1288,9 +1485,8 @@ static void be_tx_compl_process(struct be_adapter *adapter, u16 last_index)
                queue_tail_inc(txq);
        } while (cur_index != last_index);
-        atomic_sub(num_wrbs, &txq->used);
        kfree_skb(sent_skb);
+        return num_wrbs;
 }
 static inline struct be_eq_entry *event_get(struct be_eq_obj *eq_obj)
@@ -1373,7 +1569,7 @@ static void be_tx_compl_clean(struct be_adapter *adapter)
        struct be_queue_info *tx_cq = &adapter->tx_obj.cq;
        struct be_queue_info *txq = &adapter->tx_obj.q;
        struct be_eth_tx_compl *txcp;
-        u16 end_idx, cmpl = 0, timeo = 0;
+        u16 end_idx, cmpl = 0, timeo = 0, num_wrbs = 0;
        struct sk_buff **sent_skbs = adapter->tx_obj.sent_skb_list;
        struct sk_buff *sent_skb;
        bool dummy_wrb;
@@ -1383,12 +1579,14 @@ static void be_tx_compl_clean(struct be_adapter *adapter)
                while ((txcp = be_tx_compl_get(tx_cq))) {
                        end_idx = AMAP_GET_BITS(struct amap_eth_tx_compl,
                                        wrb_index, txcp);
-                        be_tx_compl_process(adapter, end_idx);
+                        num_wrbs += be_tx_compl_process(adapter, end_idx);
                        cmpl++;
                }
                if (cmpl) {
                        be_cq_notify(adapter, tx_cq->id, false, cmpl);
+                        atomic_sub(num_wrbs, &txq->used);
                        cmpl = 0;
+                        num_wrbs = 0;
                }
                if (atomic_read(&txq->used) == 0 || ++timeo > 200)
@@ -1408,7 +1606,8 @@ static void be_tx_compl_clean(struct be_adapter *adapter)
                index_adv(&end_idx,
                        wrb_cnt_for_skb(adapter, sent_skb, &dummy_wrb) - 1,
                        txq->len);
-                be_tx_compl_process(adapter, end_idx);
+                num_wrbs = be_tx_compl_process(adapter, end_idx);
+                atomic_sub(num_wrbs, &txq->used);
        }
 }
@@ -1573,12 +1772,31 @@ static void be_rx_queues_destroy(struct be_adapter *adapter)
        }
 }
+static u32 be_num_rxqs_want(struct be_adapter *adapter)
+{
+        if (multi_rxq && (adapter->function_caps & BE_FUNCTION_CAPS_RSS) &&
+                !adapter->sriov_enabled && !(adapter->function_mode & 0x400)) {
+                return 1 + MAX_RSS_QS; /* one default non-RSS queue */
+        } else {
+                dev_warn(&adapter->pdev->dev,
+                        "No support for multiple RX queues\n");
+                return 1;
+        }
+}
 static int be_rx_queues_create(struct be_adapter *adapter)
 {
        struct be_queue_info *eq, *q, *cq;
        struct be_rx_obj *rxo;
        int rc, i;
+        adapter->num_rx_qs = min(be_num_rxqs_want(adapter),
+                                msix_enabled(adapter) ?
+                                        adapter->num_msix_vec - 1 : 1);
+        if (adapter->num_rx_qs != MAX_RX_QS)
+                dev_warn(&adapter->pdev->dev,
+                        "Can create only %d RX queues", adapter->num_rx_qs);
        adapter->big_page_size = (1 << get_order(rx_frag_size)) * PAGE_SIZE;
        for_all_rx_queues(adapter, rxo, i) {
                rxo->adapter = adapter;
@@ -1724,12 +1942,15 @@ static int be_poll_rx(struct napi_struct *napi, int budget)
                        break;
                /* Ignore flush completions */
-                if (rxcp->num_rcvd) {
+                if (rxcp->num_rcvd && rxcp->pkt_size) {
                        if (do_gro(rxcp))
                                be_rx_compl_process_gro(adapter, rxo, rxcp);
                        else
                                be_rx_compl_process(adapter, rxo, rxcp);
+                } else if (rxcp->pkt_size == 0) {
+                        be_rx_compl_discard(adapter, rxo, rxcp);
                }
                be_rx_stats_update(rxo, rxcp);
        }
@@ -1760,12 +1981,12 @@ static int be_poll_tx_mcc(struct napi_struct *napi, int budget)
        struct be_queue_info *tx_cq = &adapter->tx_obj.cq;
        struct be_eth_tx_compl *txcp;
        int tx_compl = 0, mcc_compl, status = 0;
-        u16 end_idx;
+        u16 end_idx, num_wrbs = 0;
        while ((txcp = be_tx_compl_get(tx_cq))) {
                end_idx = AMAP_GET_BITS(struct amap_eth_tx_compl,
                                wrb_index, txcp);
-                be_tx_compl_process(adapter, end_idx);
+                num_wrbs += be_tx_compl_process(adapter, end_idx);
                tx_compl++;
        }
@@ -1781,6 +2002,8 @@ static int be_poll_tx_mcc(struct napi_struct *napi, int budget)
        if (tx_compl) {
                be_cq_notify(adapter, adapter->tx_obj.cq.id, true, tx_compl);
+                atomic_sub(num_wrbs, &txq->used);
                /* As Tx wrbs have been freed up, wake up netdev queue if
                 * it was stopped due to lack of tx wrbs.
                 */
@@ -1843,6 +2066,9 @@ static void be_worker(struct work_struct *work)
        struct be_rx_obj *rxo;
        int i;
+        if (!adapter->ue_detected && !lancer_chip(adapter))
+                be_detect_dump_ue(adapter);
        /* when interrupts are not yet enabled, just reap any pending
        * mcc completions */
        if (!netif_running(adapter->netdev)) {
@@ -1855,15 +2081,16 @@ static void be_worker(struct work_struct *work)
                        be_cq_notify(adapter, mcc_obj->cq.id, false, mcc_compl);
                }
-                if (!adapter->ue_detected && !lancer_chip(adapter))
-                        be_detect_dump_ue(adapter);
                goto reschedule;
        }
-        if (!adapter->stats_cmd_sent)
+        if (!adapter->stats_cmd_sent) {
-                be_cmd_get_stats(adapter, &adapter->stats_cmd);
+                if (lancer_chip(adapter))
+                        lancer_cmd_get_pport_stats(adapter,
+                                                &adapter->stats_cmd);
+                else
+                        be_cmd_get_stats(adapter, &adapter->stats_cmd);
+        }
        be_tx_rate_update(adapter);
        for_all_rx_queues(adapter, rxo, i) {
@@ -1875,8 +2102,6 @@ static void be_worker(struct work_struct *work)
                        be_post_rx_frags(rxo, GFP_KERNEL);
                }
        }
-        if (!adapter->ue_detected && !lancer_chip(adapter))
-                be_detect_dump_ue(adapter);
 reschedule:
        adapter->work_counter++;
@@ -1885,51 +2110,35 @@ reschedule:
 static void be_msix_disable(struct be_adapter *adapter)
 {
-        if (adapter->msix_enabled) {
+        if (msix_enabled(adapter)) {
                pci_disable_msix(adapter->pdev);
-                adapter->msix_enabled = false;
+                adapter->num_msix_vec = 0;
-        }
-}
-static int be_num_rxqs_get(struct be_adapter *adapter)
-{
-        if (multi_rxq && (adapter->function_caps & BE_FUNCTION_CAPS_RSS) &&
-                !adapter->sriov_enabled && !(adapter->function_mode & 0x400)) {
-                return 1 + MAX_RSS_QS; /* one default non-RSS queue */
-        } else {
-                dev_warn(&adapter->pdev->dev,
-                        "No support for multiple RX queues\n");
-                return 1;
        }
 }
 static void be_msix_enable(struct be_adapter *adapter)
 {
 #define BE_MIN_MSIX_VECTORS     (1 + 1) /* Rx + Tx */
-        int i, status;
+        int i, status, num_vec;
-        adapter->num_rx_qs = be_num_rxqs_get(adapter);
+        num_vec = be_num_rxqs_want(adapter) + 1;
-        for (i = 0; i < (adapter->num_rx_qs + 1); i++)
+        for (i = 0; i < num_vec; i++)
                adapter->msix_entries[i].entry = i;
-        status = pci_enable_msix(adapter->pdev, adapter->msix_entries,
+        status = pci_enable_msix(adapter->pdev, adapter->msix_entries, num_vec);
-                        adapter->num_rx_qs + 1);
        if (status == 0) {
                goto done;
        } else if (status >= BE_MIN_MSIX_VECTORS) {
+                num_vec = status;
                if (pci_enable_msix(adapter->pdev, adapter->msix_entries,
-                                status) == 0) {
+                                num_vec) == 0)
-                        adapter->num_rx_qs = status - 1;
-                        dev_warn(&adapter->pdev->dev,
-                                "Could alloc only %d MSIx vectors. "
-                                "Using %d RX Qs\n", status, adapter->num_rx_qs);
                        goto done;
-                }
        }
        return;
 done:
-        adapter->msix_enabled = true;
+        adapter->num_msix_vec = num_vec;
+        return;
 }
 static void be_sriov_enable(struct be_adapter *adapter)
@@ -1937,7 +2146,20 @@ static void be_sriov_enable(struct be_adapter *adapter)
        be_check_sriov_fn_type(adapter);
 #ifdef CONFIG_PCI_IOV
        if (be_physfn(adapter) && num_vfs) {
-                int status;
+                int status, pos;
+                u16 nvfs;
+                pos = pci_find_ext_capability(adapter->pdev,
+                                                PCI_EXT_CAP_ID_SRIOV);
+                pci_read_config_word(adapter->pdev,
+                                        pos + PCI_SRIOV_TOTAL_VF, &nvfs);
+                if (num_vfs > nvfs) {
+                        dev_info(&adapter->pdev->dev,
+                                        "Device supports %d VFs and not %d\n",
+                                        nvfs, num_vfs);
+                        num_vfs = nvfs;
+                }
                status = pci_enable_sriov(adapter->pdev, num_vfs);
                adapter->sriov_enabled = status ? false : true;
@@ -2010,8 +2232,7 @@ err_msix:
 err:
        dev_warn(&adapter->pdev->dev,
                "MSIX Request IRQ failed - err %d\n", status);
-        pci_disable_msix(adapter->pdev);
+        be_msix_disable(adapter);
-        adapter->msix_enabled = false;
        return status;
 }
@@ -2020,7 +2241,7 @@ static int be_irq_register(struct be_adapter *adapter)
        struct net_device *netdev = adapter->netdev;
        int status;
-        if (adapter->msix_enabled) {
+        if (msix_enabled(adapter)) {
                status = be_msix_register(adapter);
                if (status == 0)
                        goto done;
@@ -2053,7 +2274,7 @@ static void be_irq_unregister(struct be_adapter *adapter)
                return;
        /* INTx */
-        if (!adapter->msix_enabled) {
+        if (!msix_enabled(adapter)) {
                free_irq(netdev->irq, adapter);
                goto done;
        }
@@ -2095,7 +2316,7 @@ static int be_close(struct net_device *netdev)
                         be_cq_notify(adapter, rxo->cq.id, false, 0);
        }
-        if (adapter->msix_enabled) {
+        if (msix_enabled(adapter)) {
                vec = be_msix_vec_get(adapter, tx_eq);
                synchronize_irq(vec);
@@ -2148,7 +2369,7 @@ static int be_open(struct net_device *netdev)
        be_async_mcc_enable(adapter);
        status = be_cmd_link_status_query(adapter, &link_up, &mac_speed,
-                        &link_speed);
+                        &link_speed, 0);
        if (status)
                goto err;
        be_link_status_update(adapter, link_up);
@@ -2268,7 +2489,7 @@ static int be_setup(struct be_adapter *adapter)
                                BE_IF_FLAGS_PASS_L3L4_ERRORS;
                en_flags |= BE_IF_FLAGS_PASS_L3L4_ERRORS;
-                if (be_multi_rxq(adapter)) {
+                if (adapter->function_caps & BE_FUNCTION_CAPS_RSS) {
                        cap_flags |= BE_IF_FLAGS_RSS;
                        en_flags |= BE_IF_FLAGS_RSS;
                }
@@ -2325,7 +2546,6 @@ static int be_setup(struct be_adapter *adapter)
        return 0;
-        be_mcc_queues_destroy(adapter);
 rx_qs_destroy:
        be_rx_queues_destroy(adapter);
 tx_qs_destroy:
@@ -2493,7 +2713,6 @@ static int be_flash_data(struct be_adapter *adapter,
                                        "cmd to write to flash rom failed.\n");
                                return -1;
                        }
-                        yield();
                }
        }
        return 0;
@@ -2511,32 +2730,96 @@ static int get_ufigen_type(struct flash_file_hdr_g2 *fhdr)
                return 0;
 }
-int be_load_fw(struct be_adapter *adapter, u8 *func)
+static int lancer_fw_download(struct be_adapter *adapter,
+                                const struct firmware *fw)
 {
-        char fw_file[ETHTOOL_FLASH_MAX_FILENAME];
+#define LANCER_FW_DOWNLOAD_CHUNK      (32 * 1024)
-        const struct firmware *fw;
+#define LANCER_FW_DOWNLOAD_LOCATION   "/prg"
-        struct flash_file_hdr_g2 *fhdr;
-        struct flash_file_hdr_g3 *fhdr3;
-        struct image_hdr *img_hdr_ptr = NULL;
        struct be_dma_mem flash_cmd;
-        int status, i = 0, num_imgs = 0;
+        const u8 *data_ptr = NULL;
-        const u8 *p;
+        u8 *dest_image_ptr = NULL;
+        size_t image_size = 0;
+        u32 chunk_size = 0;
+        u32 data_written = 0;
+        u32 offset = 0;
+        int status = 0;
+        u8 add_status = 0;
-        if (!netif_running(adapter->netdev)) {
+        if (!IS_ALIGNED(fw->size, sizeof(u32))) {
                dev_err(&adapter->pdev->dev,
-                        "Firmware load not allowed (interface is down)\n");
+                        "FW Image not properly aligned. "
-                return -EPERM;
+                        "Length must be 4 byte aligned.\n");
+                status = -EINVAL;
+                goto lancer_fw_exit;
+        }
+        flash_cmd.size = sizeof(struct lancer_cmd_req_write_object)
+                                + LANCER_FW_DOWNLOAD_CHUNK;
+        flash_cmd.va = dma_alloc_coherent(&adapter->pdev->dev, flash_cmd.size,
+                                                &flash_cmd.dma, GFP_KERNEL);
+        if (!flash_cmd.va) {
+                status = -ENOMEM;
+                dev_err(&adapter->pdev->dev,
+                        "Memory allocation failure while flashing\n");
+                goto lancer_fw_exit;
        }
-        strcpy(fw_file, func);
+        dest_image_ptr = flash_cmd.va +
+                                sizeof(struct lancer_cmd_req_write_object);
+        image_size = fw->size;
+        data_ptr = fw->data;
-        status = request_firmware(&fw, fw_file, &adapter->pdev->dev);
+        while (image_size) {
-        if (status)
+                chunk_size = min_t(u32, image_size, LANCER_FW_DOWNLOAD_CHUNK);
-                goto fw_exit;
+                /* Copy the image chunk content. */
+                memcpy(dest_image_ptr, data_ptr, chunk_size);
+                status = lancer_cmd_write_object(adapter, &flash_cmd,
+                                chunk_size, offset, LANCER_FW_DOWNLOAD_LOCATION,
+                                &data_written, &add_status);
+                if (status)
+                        break;
+                offset += data_written;
+                data_ptr += data_written;
+                image_size -= data_written;
+        }
+        if (!status) {
+                /* Commit the FW written */
+                status = lancer_cmd_write_object(adapter, &flash_cmd,
+                                        0, offset, LANCER_FW_DOWNLOAD_LOCATION,
+                                        &data_written, &add_status);
+        }
+        dma_free_coherent(&adapter->pdev->dev, flash_cmd.size, flash_cmd.va,
+                                flash_cmd.dma);
+        if (status) {
+                dev_err(&adapter->pdev->dev,
+                        "Firmware load error. "
+                        "Status code: 0x%x Additional Status: 0x%x\n",
+                        status, add_status);
+                goto lancer_fw_exit;
+        }
+        dev_info(&adapter->pdev->dev, "Firmware flashed successfully\n");
+lancer_fw_exit:
+        return status;
+}
+static int be_fw_download(struct be_adapter *adapter, const struct firmware* fw)
+{
+        struct flash_file_hdr_g2 *fhdr;
+        struct flash_file_hdr_g3 *fhdr3;
+        struct image_hdr *img_hdr_ptr = NULL;
+        struct be_dma_mem flash_cmd;
+        const u8 *p;
+        int status = 0, i = 0, num_imgs = 0;
        p = fw->data;
        fhdr = (struct flash_file_hdr_g2 *) p;
-        dev_info(&adapter->pdev->dev, "Flashing firmware file %s\n", fw_file);
        flash_cmd.size = sizeof(struct be_cmd_write_flashrom) + 32*1024;
        flash_cmd.va = dma_alloc_coherent(&adapter->pdev->dev, flash_cmd.size,
@@ -2545,7 +2828,7 @@ int be_load_fw(struct be_adapter *adapter, u8 *func)
                status = -ENOMEM;
                dev_err(&adapter->pdev->dev,
                        "Memory allocation failure while flashing\n");
-                goto fw_exit;
+                goto be_fw_exit;
        }
        if ((adapter->generation == BE_GEN3) &&
@@ -2573,11 +2856,37 @@ int be_load_fw(struct be_adapter *adapter, u8 *func)
                          flash_cmd.dma);
        if (status) {
                dev_err(&adapter->pdev->dev, "Firmware load error\n");
-                goto fw_exit;
+                goto be_fw_exit;
        }
        dev_info(&adapter->pdev->dev, "Firmware flashed successfully\n");
+be_fw_exit:
+        return status;
+}
+int be_load_fw(struct be_adapter *adapter, u8 *fw_file)
+{
+        const struct firmware *fw;
+        int status;
+        if (!netif_running(adapter->netdev)) {
+                dev_err(&adapter->pdev->dev,
+                        "Firmware load not allowed (interface is down)\n");
+                return -1;
+        }
+        status = request_firmware(&fw, fw_file, &adapter->pdev->dev);
+        if (status)
+                goto fw_exit;
+        dev_info(&adapter->pdev->dev, "Flashing firmware file %s\n", fw_file);
+        if (lancer_chip(adapter))
+                status = lancer_fw_download(adapter, fw);
+        else
+                status = be_fw_download(adapter, fw);
 fw_exit:
        release_firmware(fw);
        return status;
@@ -2606,10 +2915,14 @@ static void be_netdev_init(struct net_device *netdev)
        struct be_rx_obj *rxo;
        int i;
-        netdev->features |= NETIF_F_SG | NETIF_F_HW_VLAN_RX | NETIF_F_TSO |
+        netdev->hw_features |= NETIF_F_SG | NETIF_F_TSO | NETIF_F_TSO6 |
-                NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_FILTER |
+                NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM |
-                NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
+                NETIF_F_HW_VLAN_TX;
-                NETIF_F_GRO | NETIF_F_TSO6;
+        if (be_multi_rxq(adapter))
+                netdev->hw_features |= NETIF_F_RXHASH;
+        netdev->features |= netdev->hw_features |
+                NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER;
        netdev->vlan_features |= NETIF_F_SG | NETIF_F_TSO |
                NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
@@ -2619,8 +2932,6 @@ static void be_netdev_init(struct net_device *netdev)
        netdev->flags |= IFF_MULTICAST;
-        adapter->rx_csum = true;
        /* Default settings for Rx and Tx flow control */
        adapter->rx_fc = true;
        adapter->tx_fc = true;
@@ -2788,7 +3099,14 @@ static int be_stats_init(struct be_adapter *adapter)
 {
        struct be_dma_mem *cmd = &adapter->stats_cmd;
-        cmd->size = sizeof(struct be_cmd_req_get_stats);
+        if (adapter->generation == BE_GEN2) {
+                cmd->size = sizeof(struct be_cmd_req_get_stats_v0);
+        } else {
+                if (lancer_chip(adapter))
+                        cmd->size = sizeof(struct lancer_cmd_req_pport_stats);
+                else
+                        cmd->size = sizeof(struct be_cmd_req_get_stats_v1);
+        }
        cmd->va = dma_alloc_coherent(&adapter->pdev->dev, cmd->size, &cmd->dma,
                                     GFP_KERNEL);
        if (cmd->va == NULL)
@@ -2814,6 +3132,7 @@ static void __devexit be_remove(struct pci_dev *pdev)
        be_ctrl_cleanup(adapter);
+        kfree(adapter->vf_cfg);
        be_sriov_disable(adapter);
        be_msix_disable(adapter);
@@ -2841,7 +3160,8 @@ static int be_get_config(struct be_adapter *adapter)
        memset(mac, 0, ETH_ALEN);
-        if (be_physfn(adapter)) {
+        /* A default permanent address is given to each VF for Lancer*/
+        if (be_physfn(adapter) || lancer_chip(adapter)) {
                status = be_cmd_mac_addr_query(adapter, mac,
                        MAC_ADDRESS_TYPE_NETWORK, true /*permanent */, 0);
@@ -2883,6 +3203,7 @@ static int be_dev_family_check(struct be_adapter *adapter)
                adapter->generation = BE_GEN3;
                break;
        case OC_DEVICE_ID3:
+        case OC_DEVICE_ID4:
                pci_read_config_dword(pdev, SLI_INTF_REG_OFFSET, &sli_intf);
                if_type = (sli_intf & SLI_INTF_IF_TYPE_MASK) >>
                                                SLI_INTF_IF_TYPE_SHIFT;
@@ -2892,10 +3213,6 @@ static int be_dev_family_check(struct be_adapter *adapter)
                        dev_err(&pdev->dev, "SLI_INTF reg val is not valid\n");
                        return -EINVAL;
                }
-                if (num_vfs > 0) {
-                        dev_err(&pdev->dev, "VFs not supported\n");
-                        return -EINVAL;
-                }
                adapter->sli_family = ((sli_intf & SLI_INTF_FAMILY_MASK) >>
                                         SLI_INTF_FAMILY_SHIFT);
                adapter->generation = BE_GEN3;
@@ -2998,16 +3315,23 @@ static int __devinit be_probe(struct pci_dev *pdev,
        }
        be_sriov_enable(adapter);
+        if (adapter->sriov_enabled) {
+                adapter->vf_cfg = kcalloc(num_vfs,
+                        sizeof(struct be_vf_cfg), GFP_KERNEL);
+                if (!adapter->vf_cfg)
+                        goto free_netdev;
+        }
        status = be_ctrl_init(adapter);
        if (status)
-                goto free_netdev;
+                goto free_vf_cfg;
        if (lancer_chip(adapter)) {
                status = lancer_test_and_set_rdy_state(adapter);
                if (status) {
                        dev_err(&pdev->dev, "Adapter in non recoverable error\n");
-                        goto free_netdev;
+                        goto ctrl_clean;
                }
        }
@@ -3050,9 +3374,24 @@ static int __devinit be_probe(struct pci_dev *pdev,
        netif_carrier_off(netdev);
        if (be_physfn(adapter) && adapter->sriov_enabled) {
-                status = be_vf_eth_addr_config(adapter);
+                u8 mac_speed;
-                if (status)
+                bool link_up;
-                        goto unreg_netdev;
+                u16 vf, lnk_speed;
+                if (!lancer_chip(adapter)) {
+                        status = be_vf_eth_addr_config(adapter);
+                        if (status)
+                                goto unreg_netdev;
+                }
+                for (vf = 0; vf < num_vfs; vf++) {
+                        status = be_cmd_link_status_query(adapter, &link_up,
+                                        &mac_speed, &lnk_speed, vf + 1);
+                        if (!status)
+                                adapter->vf_cfg[vf].vf_tx_rate = lnk_speed * 10;
+                        else
+                                goto unreg_netdev;
+                }
        }
        dev_info(&pdev->dev, "%s port %d\n", nic_name(pdev), adapter->port_num);
@@ -3069,6 +3408,8 @@ stats_clean:
        be_stats_cleanup(adapter);
 ctrl_clean:
        be_ctrl_cleanup(adapter);
+free_vf_cfg:
+        kfree(adapter->vf_cfg);
 free_netdev:
        be_sriov_disable(adapter);
        free_netdev(netdev);
@@ -3153,16 +3494,15 @@ static void be_shutdown(struct pci_dev *pdev)
        if (!adapter)
                return;
-        if (netif_running(adapter->netdev))
+        cancel_delayed_work_sync(&adapter->work);
-                cancel_delayed_work_sync(&adapter->work);
        netif_device_detach(adapter->netdev);
-        be_cmd_reset_function(adapter);
        if (adapter->wol)
                be_setup_wol(adapter, true);
+        be_cmd_reset_function(adapter);
        pci_disable_device(pdev);
 }
@@ -3274,13 +3614,6 @@ static int __init be_init_module(void)
                rx_frag_size = 2048;
        }
-        if (num_vfs > 32) {
-                printk(KERN_WARNING DRV_NAME
-                        " : Module param num_vfs must not be greater than 32."
-                        "Using 32\n");
-                num_vfs = 32;
-        }
        return pci_register_driver(&be_driver);
 }
 module_init(be_init_module);
diff --git a/drivers/net/bna/bfa_ioc.c b/drivers/net/bna/bfa_ioc.c
index 7581518ecfa2..fcb9bb3169e0 100644
--- a/drivers/net/bna/bfa_ioc.c
+++ b/drivers/net/bna/bfa_ioc.c
@@ -82,7 +82,6 @@ static void bfa_ioc_pf_fwmismatch(struct bfa_ioc *ioc);
 static void bfa_ioc_boot(struct bfa_ioc *ioc, u32 boot_type,
                         u32 boot_param);
 static u32 bfa_ioc_smem_pgnum(struct bfa_ioc *ioc, u32 fmaddr);
-static u32 bfa_ioc_smem_pgoff(struct bfa_ioc *ioc, u32 fmaddr);
 static void bfa_ioc_get_adapter_serial_num(struct bfa_ioc *ioc,
                                                char *serial_num);
 static void bfa_ioc_get_adapter_fw_ver(struct bfa_ioc *ioc,
@@ -1274,13 +1273,12 @@ bfa_ioc_lpu_stop(struct bfa_ioc *ioc)
 void
 bfa_nw_ioc_fwver_get(struct bfa_ioc *ioc, struct bfi_ioc_image_hdr *fwhdr)
 {
-        u32     pgnum, pgoff;
+        u32     pgnum;
        u32     loff = 0;
        int             i;
        u32     *fwsig = (u32 *) fwhdr;
        pgnum = bfa_ioc_smem_pgnum(ioc, loff);
-        pgoff = bfa_ioc_smem_pgoff(ioc, loff);
        writel(pgnum, ioc->ioc_regs.host_page_num_fn);
        for (i = 0; i < (sizeof(struct bfi_ioc_image_hdr) / sizeof(u32));
@@ -1514,7 +1512,7 @@ bfa_ioc_download_fw(struct bfa_ioc *ioc, u32 boot_type,
                    u32 boot_env)
 {
        u32 *fwimg;
-        u32 pgnum, pgoff;
+        u32 pgnum;
        u32 loff = 0;
        u32 chunkno = 0;
        u32 i;
@@ -1527,7 +1525,6 @@ bfa_ioc_download_fw(struct bfa_ioc *ioc, u32 boot_type,
        fwimg = bfa_cb_image_get_chunk(BFA_IOC_FWIMG_TYPE(ioc), chunkno);
        pgnum = bfa_ioc_smem_pgnum(ioc, loff);
-        pgoff = bfa_ioc_smem_pgoff(ioc, loff);
        writel(pgnum, ioc->ioc_regs.host_page_num_fn);
@@ -1925,12 +1922,6 @@ bfa_ioc_smem_pgnum(struct bfa_ioc *ioc, u32 fmaddr)
        return PSS_SMEM_PGNUM(ioc->ioc_regs.smem_pg0, fmaddr);
 }
-static u32
-bfa_ioc_smem_pgoff(struct bfa_ioc *ioc, u32 fmaddr)
-{
-        return PSS_SMEM_PGOFF(fmaddr);
-}
 /**
 * Register mailbox message handler function, to be called by common modules
 */
diff --git a/drivers/net/bna/bna_ctrl.c b/drivers/net/bna/bna_ctrl.c
index e1527472b961..53b14169e363 100644
--- a/drivers/net/bna/bna_ctrl.c
+++ b/drivers/net/bna/bna_ctrl.c
@@ -246,7 +246,6 @@ static void
 bna_mbox_flush_q(struct bna *bna, struct list_head *q)
 {
        struct bna_mbox_qe *mb_qe = NULL;
-        struct bfi_mhdr *cmd_h;
        struct list_head                        *mb_q;
        void                    (*cbfn)(void *arg, int status);
        void                    *cbarg;
@@ -260,7 +259,6 @@ bna_mbox_flush_q(struct bna *bna, struct list_head *q)
                bfa_q_qe_init(mb_qe);
                bna->mbox_mod.msg_pending--;
-                cmd_h = (struct bfi_mhdr *)(&mb_qe->cmd.msg[0]);
                if (cbfn)
                        cbfn(cbarg, BNA_CB_NOT_EXEC);
        }
@@ -2774,23 +2772,6 @@ bna_rit_mod_init(struct bna_rit_mod *rit_mod,
        }
 }
-static void
-bna_rit_mod_uninit(struct bna_rit_mod *rit_mod)
-{
-        struct bna_rit_segment *rit_segment;
-        struct list_head *qe;
-        int i;
-        int j;
-        for (i = 0; i < BFI_RIT_SEG_TOTAL_POOLS; i++) {
-                j = 0;
-                list_for_each(qe, &rit_mod->rit_seg_pool[i]) {
-                        rit_segment = (struct bna_rit_segment *)qe;
-                        j++;
-                }
-        }
-}
 /*
 * Public functions
 */
@@ -2977,8 +2958,6 @@ bna_uninit(struct bna *bna)
        bna_ucam_mod_uninit(&bna->ucam_mod);
-        bna_rit_mod_uninit(&bna->rit_mod);
        bna_ib_mod_uninit(&bna->ib_mod);
        bna_rx_mod_uninit(&bna->rx_mod);
diff --git a/drivers/net/bna/bna_txrx.c b/drivers/net/bna/bna_txrx.c
index 58c7664040dc..380085cc3088 100644
--- a/drivers/net/bna/bna_txrx.c
+++ b/drivers/net/bna/bna_txrx.c
@@ -2229,14 +2229,11 @@ void
 bna_rit_create(struct bna_rx *rx)
 {
        struct list_head        *qe_rxp;
-        struct bna *bna;
        struct bna_rxp *rxp;
        struct bna_rxq *q0 = NULL;
        struct bna_rxq *q1 = NULL;
        int offset;
-        bna = rx->bna;
        offset = 0;
        list_for_each(qe_rxp, &rx->rxp_q) {
                rxp = (struct bna_rxp *)qe_rxp;
@@ -2830,7 +2827,7 @@ bna_rx_create(struct bna *bna, struct bnad *bnad,
        struct bna_mem_descr *dsqpt_mem;        /* s/w qpt for data */
        struct bna_mem_descr *hpage_mem;        /* hdr page mem */
        struct bna_mem_descr *dpage_mem;        /* data page mem */
-        int i, cpage_idx = 0, dpage_idx = 0, hpage_idx = 0, ret;
+        int i, cpage_idx = 0, dpage_idx = 0, hpage_idx = 0;
        int dpage_count, hpage_count, rcb_idx;
        struct bna_ib_config ibcfg;
        /* Fail if we don't have enough RXPs, RXQs */
@@ -2924,7 +2921,7 @@ bna_rx_create(struct bna *bna, struct bnad *bnad,
                ibcfg.interpkt_timeo = BFI_RX_INTERPKT_TIMEO;
                ibcfg.ctrl_flags = BFI_IB_CF_INT_ENABLE;
-                ret = bna_ib_config(rxp->cq.ib, &ibcfg);
+                bna_ib_config(rxp->cq.ib, &ibcfg);
                /* Link rxqs to rxp */
                _rxp_add_rxqs(rxp, q0, q1);
diff --git a/drivers/net/bna/bnad.c b/drivers/net/bna/bnad.c
index 8e6ceab9f4d8..e588511f47fb 100644
--- a/drivers/net/bna/bnad.c
+++ b/drivers/net/bna/bnad.c
@@ -501,7 +501,7 @@ bnad_poll_cq(struct bnad *bnad, struct bna_ccb *ccb, int budget)
                skb_put(skb, ntohs(cmpl->length));
                if (likely
-                    (bnad->rx_csum &&
+                    ((bnad->netdev->features & NETIF_F_RXCSUM) &&
                     (((flags & BNA_CQ_EF_IPV4) &&
                      (flags & BNA_CQ_EF_L3_CKSUM_OK)) ||
                      (flags & BNA_CQ_EF_IPV6)) &&
@@ -2902,23 +2902,20 @@ bnad_netdev_init(struct bnad *bnad, bool using_dac)
 {
        struct net_device *netdev = bnad->netdev;
-        netdev->features |= NETIF_F_IPV6_CSUM;
+        netdev->hw_features = NETIF_F_SG | NETIF_F_RXCSUM |
-        netdev->features |= NETIF_F_TSO;
+                NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
-        netdev->features |= NETIF_F_TSO6;
+                NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_HW_VLAN_TX;
-        netdev->features |= NETIF_F_GRO;
+        netdev->vlan_features = NETIF_F_SG | NETIF_F_HIGHDMA |
-        pr_warn("bna: GRO enabled, using kernel stack GRO\n");
+                NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
+                NETIF_F_TSO | NETIF_F_TSO6;
-        netdev->features |= NETIF_F_SG | NETIF_F_IP_CSUM;
+        netdev->features |= netdev->hw_features |
+                NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER;
        if (using_dac)
                netdev->features |= NETIF_F_HIGHDMA;
-        netdev->features |=
-                NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |
-                NETIF_F_HW_VLAN_FILTER;
-        netdev->vlan_features = netdev->features;
        netdev->mem_start = bnad->mmio_start;
        netdev->mem_end = bnad->mmio_start + bnad->mmio_len - 1;
@@ -2969,7 +2966,6 @@ bnad_init(struct bnad *bnad,
        bnad->txq_depth = BNAD_TXQ_DEPTH;
        bnad->rxq_depth = BNAD_RXQ_DEPTH;
-        bnad->rx_csum = true;
        bnad->tx_coalescing_timeo = BFI_TX_COALESCING_TIMEO;
        bnad->rx_coalescing_timeo = BFI_RX_COALESCING_TIMEO;
diff --git a/drivers/net/bna/bnad.h b/drivers/net/bna/bnad.h
index a89117fa4970..ccdabad0a40c 100644
--- a/drivers/net/bna/bnad.h
+++ b/drivers/net/bna/bnad.h
@@ -237,8 +237,6 @@ struct bnad {
        struct bna_rx_config rx_config[BNAD_MAX_RXS];
        struct bna_tx_config tx_config[BNAD_MAX_TXS];
-        u32             rx_csum;
        void __iomem            *bar0;  /* BAR0 address */
        struct bna bna;
diff --git a/drivers/net/bna/bnad_ethtool.c b/drivers/net/bna/bnad_ethtool.c
index 142d6047da27..3330cd78da2c 100644
--- a/drivers/net/bna/bnad_ethtool.c
+++ b/drivers/net/bna/bnad_ethtool.c
@@ -237,10 +237,10 @@ bnad_get_settings(struct net_device *netdev, struct ethtool_cmd *cmd)
        cmd->phy_address = 0;
        if (netif_carrier_ok(netdev)) {
-                cmd->speed = SPEED_10000;
+                ethtool_cmd_speed_set(cmd, SPEED_10000);
                cmd->duplex = DUPLEX_FULL;
        } else {
-                cmd->speed = -1;
+                ethtool_cmd_speed_set(cmd, -1);
                cmd->duplex = -1;
        }
        cmd->transceiver = XCVR_EXTERNAL;
@@ -256,7 +256,8 @@ bnad_set_settings(struct net_device *netdev, struct ethtool_cmd *cmd)
        /* 10G full duplex setting supported only */
        if (cmd->autoneg == AUTONEG_ENABLE)
                return -EOPNOTSUPP; else {
-                if ((cmd->speed == SPEED_10000) && (cmd->duplex == DUPLEX_FULL))
+                if ((ethtool_cmd_speed(cmd) == SPEED_10000)
+                    && (cmd->duplex == DUPLEX_FULL))
                        return 0;
        }
@@ -806,61 +807,6 @@ bnad_set_pauseparam(struct net_device *netdev,
        return 0;
 }
-static u32
-bnad_get_rx_csum(struct net_device *netdev)
-{
-        u32 rx_csum;
-        struct bnad *bnad = netdev_priv(netdev);
-        rx_csum = bnad->rx_csum;
-        return rx_csum;
-}
-static int
-bnad_set_rx_csum(struct net_device *netdev, u32 rx_csum)
-{
-        struct bnad *bnad = netdev_priv(netdev);
-        mutex_lock(&bnad->conf_mutex);
-        bnad->rx_csum = rx_csum;
-        mutex_unlock(&bnad->conf_mutex);
-        return 0;
-}
-static int
-bnad_set_tx_csum(struct net_device *netdev, u32 tx_csum)
-{
-        struct bnad *bnad = netdev_priv(netdev);
-        mutex_lock(&bnad->conf_mutex);
-        if (tx_csum) {
-                netdev->features |= NETIF_F_IP_CSUM;
-                netdev->features |= NETIF_F_IPV6_CSUM;
-        } else {
-                netdev->features &= ~NETIF_F_IP_CSUM;
-                netdev->features &= ~NETIF_F_IPV6_CSUM;
-        }
-        mutex_unlock(&bnad->conf_mutex);
-        return 0;
-}
-static int
-bnad_set_tso(struct net_device *netdev, u32 tso)
-{
-        struct bnad *bnad = netdev_priv(netdev);
-        mutex_lock(&bnad->conf_mutex);
-        if (tso) {
-                netdev->features |= NETIF_F_TSO;
-                netdev->features |= NETIF_F_TSO6;
-        } else {
-                netdev->features &= ~NETIF_F_TSO;
-                netdev->features &= ~NETIF_F_TSO6;
-        }
-        mutex_unlock(&bnad->conf_mutex);
-        return 0;
-}
 static void
 bnad_get_strings(struct net_device *netdev, u32 stringset, u8 * string)
 {
@@ -1256,14 +1202,6 @@ static struct ethtool_ops bnad_ethtool_ops = {
        .set_ringparam = bnad_set_ringparam,
        .get_pauseparam = bnad_get_pauseparam,
        .set_pauseparam = bnad_set_pauseparam,
-        .get_rx_csum = bnad_get_rx_csum,
-        .set_rx_csum = bnad_set_rx_csum,
-        .get_tx_csum = ethtool_op_get_tx_csum,
-        .set_tx_csum = bnad_set_tx_csum,
-        .get_sg = ethtool_op_get_sg,
-        .set_sg = ethtool_op_set_sg,
-        .get_tso = ethtool_op_get_tso,
-        .set_tso = bnad_set_tso,
        .get_strings = bnad_get_strings,
        .get_ethtool_stats = bnad_get_ethtool_stats,
        .get_sset_count = bnad_get_sset_count
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index d8383a9af9ad..57d3293c65bd 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -3174,7 +3174,7 @@ bnx2_rx_int(struct bnx2 *bp, struct bnx2_napi *bnapi, int budget)
                }
                skb_checksum_none_assert(skb);
-                if (bp->rx_csum &&
+                if ((bp->dev->features & NETIF_F_RXCSUM) &&
                        (status & (L2_FHDR_STATUS_TCP_SEGMENT |
                        L2_FHDR_STATUS_UDP_DATAGRAM))) {
@@ -6696,17 +6696,16 @@ bnx2_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        if (bp->autoneg & AUTONEG_SPEED) {
                cmd->autoneg = AUTONEG_ENABLE;
-        }
+        } else {
-        else {
                cmd->autoneg = AUTONEG_DISABLE;
        }
        if (netif_carrier_ok(dev)) {
-                cmd->speed = bp->line_speed;
+                ethtool_cmd_speed_set(cmd, bp->line_speed);
                cmd->duplex = bp->duplex;
        }
        else {
-                cmd->speed = -1;
+                ethtool_cmd_speed_set(cmd, -1);
                cmd->duplex = -1;
        }
        spin_unlock_bh(&bp->phy_lock);
@@ -6758,21 +6757,21 @@ bnx2_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                advertising |= ADVERTISED_Autoneg;
        }
        else {
+                u32 speed = ethtool_cmd_speed(cmd);
                if (cmd->port == PORT_FIBRE) {
-                        if ((cmd->speed != SPEED_1000 &&
+                        if ((speed != SPEED_1000 &&
-                             cmd->speed != SPEED_2500) ||
+                             speed != SPEED_2500) ||
                            (cmd->duplex != DUPLEX_FULL))
                                goto err_out_unlock;
-                        if (cmd->speed == SPEED_2500 &&
+                        if (speed == SPEED_2500 &&
                            !(bp->phy_flags & BNX2_PHY_FLAG_2_5G_CAPABLE))
                                goto err_out_unlock;
-                }
+                } else if (speed == SPEED_1000 || speed == SPEED_2500)
-                else if (cmd->speed == SPEED_1000 || cmd->speed == SPEED_2500)
                        goto err_out_unlock;
                autoneg &= ~AUTONEG_SPEED;
-                req_line_speed = cmd->speed;
+                req_line_speed = speed;
                req_duplex = cmd->duplex;
                advertising = 0;
        }
@@ -7189,38 +7188,6 @@ bnx2_set_pauseparam(struct net_device *dev, struct ethtool_pauseparam *epause)
        return 0;
 }
-static u32
-bnx2_get_rx_csum(struct net_device *dev)
-{
-        struct bnx2 *bp = netdev_priv(dev);
-        return bp->rx_csum;
-}
-static int
-bnx2_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct bnx2 *bp = netdev_priv(dev);
-        bp->rx_csum = data;
-        return 0;
-}
-static int
-bnx2_set_tso(struct net_device *dev, u32 data)
-{
-        struct bnx2 *bp = netdev_priv(dev);
-        if (data) {
-                dev->features |= NETIF_F_TSO | NETIF_F_TSO_ECN;
-                if (CHIP_NUM(bp) == CHIP_NUM_5709)
-                        dev->features |= NETIF_F_TSO6;
-        } else
-                dev->features &= ~(NETIF_F_TSO | NETIF_F_TSO6 |
-                                   NETIF_F_TSO_ECN);
-        return 0;
-}
 static struct {
        char string[ETH_GSTRING_LEN];
 } bnx2_stats_str_arr[] = {
@@ -7495,82 +7462,74 @@ bnx2_get_ethtool_stats(struct net_device *dev,
 }
 static int
-bnx2_phys_id(struct net_device *dev, u32 data)
+bnx2_set_phys_id(struct net_device *dev, enum ethtool_phys_id_state state)
 {
        struct bnx2 *bp = netdev_priv(dev);
-        int i;
-        u32 save;
-        bnx2_set_power_state(bp, PCI_D0);
+        switch (state) {
+        case ETHTOOL_ID_ACTIVE:
+                bnx2_set_power_state(bp, PCI_D0);
+                bp->leds_save = REG_RD(bp, BNX2_MISC_CFG);
+                REG_WR(bp, BNX2_MISC_CFG, BNX2_MISC_CFG_LEDMODE_MAC);
+                return 1;       /* cycle on/off once per second */
+        case ETHTOOL_ID_ON:
+                REG_WR(bp, BNX2_EMAC_LED, BNX2_EMAC_LED_OVERRIDE |
+                       BNX2_EMAC_LED_1000MB_OVERRIDE |
+                       BNX2_EMAC_LED_100MB_OVERRIDE |
+                       BNX2_EMAC_LED_10MB_OVERRIDE |
+                       BNX2_EMAC_LED_TRAFFIC_OVERRIDE |
+                       BNX2_EMAC_LED_TRAFFIC);
+                break;
-        if (data == 0)
+        case ETHTOOL_ID_OFF:
-                data = 2;
+                REG_WR(bp, BNX2_EMAC_LED, BNX2_EMAC_LED_OVERRIDE);
+                break;
-        save = REG_RD(bp, BNX2_MISC_CFG);
+        case ETHTOOL_ID_INACTIVE:
-        REG_WR(bp, BNX2_MISC_CFG, BNX2_MISC_CFG_LEDMODE_MAC);
+                REG_WR(bp, BNX2_EMAC_LED, 0);
+                REG_WR(bp, BNX2_MISC_CFG, bp->leds_save);
-        for (i = 0; i < (data * 2); i++) {
+                if (!netif_running(dev))
-                if ((i % 2) == 0) {
+                        bnx2_set_power_state(bp, PCI_D3hot);
-                        REG_WR(bp, BNX2_EMAC_LED, BNX2_EMAC_LED_OVERRIDE);
+                break;
-                }
-                else {
-                        REG_WR(bp, BNX2_EMAC_LED, BNX2_EMAC_LED_OVERRIDE |
-                                BNX2_EMAC_LED_1000MB_OVERRIDE |
-                                BNX2_EMAC_LED_100MB_OVERRIDE |
-                                BNX2_EMAC_LED_10MB_OVERRIDE |
-                                BNX2_EMAC_LED_TRAFFIC_OVERRIDE |
-                                BNX2_EMAC_LED_TRAFFIC);
-                }
-                msleep_interruptible(500);
-                if (signal_pending(current))
-                        break;
        }
-        REG_WR(bp, BNX2_EMAC_LED, 0);
-        REG_WR(bp, BNX2_MISC_CFG, save);
-        if (!netif_running(dev))
-                bnx2_set_power_state(bp, PCI_D3hot);
        return 0;
 }
-static int
+static u32
-bnx2_set_tx_csum(struct net_device *dev, u32 data)
+bnx2_fix_features(struct net_device *dev, u32 features)
 {
        struct bnx2 *bp = netdev_priv(dev);
-        if (CHIP_NUM(bp) == CHIP_NUM_5709)
+        if (!(bp->flags & BNX2_FLAG_CAN_KEEP_VLAN))
-                return ethtool_op_set_tx_ipv6_csum(dev, data);
+                features |= NETIF_F_HW_VLAN_RX;
-        else
-                return ethtool_op_set_tx_csum(dev, data);
+        return features;
 }
 static int
-bnx2_set_flags(struct net_device *dev, u32 data)
+bnx2_set_features(struct net_device *dev, u32 features)
 {
        struct bnx2 *bp = netdev_priv(dev);
-        int rc;
-        if (!(bp->flags & BNX2_FLAG_CAN_KEEP_VLAN) &&
-            !(data & ETH_FLAG_RXVLAN))
-                return -EINVAL;
        /* TSO with VLAN tag won't work with current firmware */
-        if (!(data & ETH_FLAG_TXVLAN))
+        if (features & NETIF_F_HW_VLAN_TX)
-                return -EINVAL;
+                dev->vlan_features |= (dev->hw_features & NETIF_F_ALL_TSO);
+        else
-        rc = ethtool_op_set_flags(dev, data, ETH_FLAG_RXHASH | ETH_FLAG_RXVLAN |
+                dev->vlan_features &= ~NETIF_F_ALL_TSO;
-                                  ETH_FLAG_TXVLAN);
-        if (rc)
-                return rc;
-        if ((!!(data & ETH_FLAG_RXVLAN) !=
+        if ((!!(features & NETIF_F_HW_VLAN_RX) !=
            !!(bp->rx_mode & BNX2_EMAC_RX_MODE_KEEP_VLAN_TAG)) &&
            netif_running(dev)) {
                bnx2_netif_stop(bp, false);
+                dev->features = features;
                bnx2_set_rx_mode(dev);
                bnx2_fw_sync(bp, BNX2_DRV_MSG_CODE_KEEP_VLAN_UPDATE, 0, 1);
                bnx2_netif_start(bp, false);
+                return 1;
        }
        return 0;
@@ -7595,18 +7554,11 @@ static const struct ethtool_ops bnx2_ethtool_ops = {
        .set_ringparam          = bnx2_set_ringparam,
        .get_pauseparam         = bnx2_get_pauseparam,
        .set_pauseparam         = bnx2_set_pauseparam,
-        .get_rx_csum            = bnx2_get_rx_csum,
-        .set_rx_csum            = bnx2_set_rx_csum,
-        .set_tx_csum            = bnx2_set_tx_csum,
-        .set_sg                 = ethtool_op_set_sg,
-        .set_tso                = bnx2_set_tso,
        .self_test              = bnx2_self_test,
        .get_strings            = bnx2_get_strings,
-        .phys_id                = bnx2_phys_id,
+        .set_phys_id            = bnx2_set_phys_id,
        .get_ethtool_stats      = bnx2_get_ethtool_stats,
        .get_sset_count         = bnx2_get_sset_count,
-        .set_flags              = bnx2_set_flags,
-        .get_flags              = ethtool_op_get_flags,
 };
 /* Called with rtnl_lock */
@@ -8118,8 +8070,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
        bp->tx_ring_size = MAX_TX_DESC_CNT;
        bnx2_set_rx_ring_size(bp, 255);
-        bp->rx_csum = 1;
        bp->tx_quick_cons_trip_int = 2;
        bp->tx_quick_cons_trip = 20;
        bp->tx_ticks_int = 18;
@@ -8311,17 +8261,14 @@ static const struct net_device_ops bnx2_netdev_ops = {
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_set_mac_address    = bnx2_change_mac_addr,
        .ndo_change_mtu         = bnx2_change_mtu,
+        .ndo_fix_features       = bnx2_fix_features,
+        .ndo_set_features       = bnx2_set_features,
        .ndo_tx_timeout         = bnx2_tx_timeout,
 #ifdef CONFIG_NET_POLL_CONTROLLER
        .ndo_poll_controller    = poll_bnx2,
 #endif
 };
-static inline void vlan_features_add(struct net_device *dev, u32 flags)
-{
-        dev->vlan_features |= flags;
-}
 static int __devinit
 bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
@@ -8361,20 +8308,17 @@ bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        memcpy(dev->dev_addr, bp->mac_addr, 6);
        memcpy(dev->perm_addr, bp->mac_addr, 6);
-        dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_GRO |
+        dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG |
-                         NETIF_F_RXHASH;
+                NETIF_F_TSO | NETIF_F_TSO_ECN |
-        vlan_features_add(dev, NETIF_F_IP_CSUM | NETIF_F_SG);
+                NETIF_F_RXHASH | NETIF_F_RXCSUM;
-        if (CHIP_NUM(bp) == CHIP_NUM_5709) {
-                dev->features |= NETIF_F_IPV6_CSUM;
+        if (CHIP_NUM(bp) == CHIP_NUM_5709)
-                vlan_features_add(dev, NETIF_F_IPV6_CSUM);
+                dev->hw_features |= NETIF_F_IPV6_CSUM | NETIF_F_TSO6;
-        }
-        dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+        dev->vlan_features = dev->hw_features;
-        dev->features |= NETIF_F_TSO | NETIF_F_TSO_ECN;
+        dev->hw_features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
-        vlan_features_add(dev, NETIF_F_TSO | NETIF_F_TSO_ECN);
+        dev->features |= dev->hw_features;
-        if (CHIP_NUM(bp) == CHIP_NUM_5709) {
-                dev->features |= NETIF_F_TSO6;
-                vlan_features_add(dev, NETIF_F_TSO6);
-        }
        if ((rc = register_netdev(dev))) {
                dev_err(&pdev->dev, "Cannot register net device\n");
                goto error;
diff --git a/drivers/net/bnx2.h b/drivers/net/bnx2.h
index 68020451dc4f..bf371f6fe154 100644
--- a/drivers/net/bnx2.h
+++ b/drivers/net/bnx2.h
@@ -6754,8 +6754,6 @@ struct bnx2 {
        u32                     rx_max_ring_idx;
        u32                     rx_max_pg_ring_idx;
-        u32                     rx_csum;
        /* TX constants */
        int             tx_ring_size;
        u32             tx_wake_thresh;
@@ -6922,6 +6920,7 @@ struct bnx2 {
        u8                      num_tx_rings;
        u8                      num_rx_rings;
+        u32                     leds_save;
        u32                     idle_chk_status_idx;
 #ifdef BCM_CNIC
diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h
index e0fca701d2f3..668a578c49e9 100644
--- a/drivers/net/bnx2x/bnx2x.h
+++ b/drivers/net/bnx2x/bnx2x.h
@@ -1,6 +1,6 @@
 /* bnx2x.h: Broadcom Everest network driver.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
@@ -22,8 +22,8 @@
 * (you will need to reboot afterwards) */
 /* #define BNX2X_STOP_ON_ERROR */
-#define DRV_MODULE_VERSION      "1.62.11-0"
+#define DRV_MODULE_VERSION      "1.62.12-0"
-#define DRV_MODULE_RELDATE      "2011/01/31"
+#define DRV_MODULE_RELDATE      "2011/03/20"
 #define BNX2X_BC_VER            0x040200
 #define BNX2X_MULTI_QUEUE
@@ -473,7 +473,8 @@ struct bnx2x_fastpath {
 #define NUM_RX_BD                       (RX_DESC_CNT * NUM_RX_RINGS)
 #define MAX_RX_BD                       (NUM_RX_BD - 1)
 #define MAX_RX_AVAIL                    (MAX_RX_DESC_CNT * NUM_RX_RINGS - 2)
-#define MIN_RX_AVAIL                    128
+#define MIN_RX_SIZE_TPA                 72
+#define MIN_RX_SIZE_NONTPA              10
 #define INIT_JUMBO_RX_RING_SIZE         MAX_RX_AVAIL
 #define INIT_RX_RING_SIZE               MAX_RX_AVAIL
 #define NEXT_RX_IDX(x)          ((((x) & RX_DESC_MASK) == \
@@ -893,6 +894,22 @@ typedef enum {
        (&bp->def_status_blk->sp_sb.\
        index_values[HC_SP_INDEX_EQ_CONS])
+/* This is a data that will be used to create a link report message.
+ * We will keep the data used for the last link report in order
+ * to prevent reporting the same link parameters twice.
+ */
+struct bnx2x_link_report_data {
+        u16 line_speed;                 /* Effective line speed */
+        unsigned long link_report_flags;/* BNX2X_LINK_REPORT_XXX flags */
+};
+enum {
+        BNX2X_LINK_REPORT_FD,           /* Full DUPLEX */
+        BNX2X_LINK_REPORT_LINK_DOWN,
+        BNX2X_LINK_REPORT_RX_FC_ON,
+        BNX2X_LINK_REPORT_TX_FC_ON,
+};
 struct bnx2x {
        /* Fields used in the tx and intr/napi performance paths
         * are grouped together in the beginning of the structure
@@ -918,7 +935,6 @@ struct bnx2x {
        int                     tx_ring_size;
-        u32                     rx_csum;
 /* L2 header size + 2*VLANs (8 bytes) + LLC SNAP (8 bytes) */
 #define ETH_OVREHEAD            (ETH_HLEN + 8 + 8)
 #define ETH_MIN_PACKET_SIZE             60
@@ -1026,6 +1042,9 @@ struct bnx2x {
        struct link_params      link_params;
        struct link_vars        link_vars;
+        u32                     link_cnt;
+        struct bnx2x_link_report_data last_reported_link;
        struct mdio_if_info     mdio;
        struct bnx2x_common     common;
@@ -1223,6 +1242,10 @@ struct bnx2x {
        /* DCBX Negotiation results */
        struct dcbx_features                    dcbx_local_feat;
        u32                                     dcbx_error;
+#ifdef BCM_DCBNL
+        struct dcbx_features                    dcbx_remote_feat;
+        u32                                     dcbx_remote_flags;
+#endif
        u32                                     pending_max;
 };
@@ -1442,6 +1465,8 @@ struct bnx2x_func_init_params {
 #define WAIT_RAMROD_POLL        0x01
 #define WAIT_RAMROD_COMMON      0x02
+void bnx2x_read_mf_cfg(struct bnx2x *bp);
 /* dmae */
 void bnx2x_read_dmae(struct bnx2x *bp, u32 src_addr, u32 len32);
 void bnx2x_write_dmae(struct bnx2x *bp, dma_addr_t dma_addr, u32 dst_addr,
diff --git a/drivers/net/bnx2x/bnx2x_cmn.c b/drivers/net/bnx2x/bnx2x_cmn.c
index 16581df5ee4e..ca2bbc0e5d48 100644
--- a/drivers/net/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/bnx2x/bnx2x_cmn.c
@@ -1,6 +1,6 @@
 /* bnx2x_cmn.c: Broadcom Everest network driver.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
@@ -27,6 +27,49 @@
 static int bnx2x_setup_irqs(struct bnx2x *bp);
+/**
+ * bnx2x_bz_fp - zero content of the fastpath structure.
+ *
+ * @bp:         driver handle
+ * @index:      fastpath index to be zeroed
+ *
+ * Makes sure the contents of the bp->fp[index].napi is kept
+ * intact.
+ */
+static inline void bnx2x_bz_fp(struct bnx2x *bp, int index)
+{
+        struct bnx2x_fastpath *fp = &bp->fp[index];
+        struct napi_struct orig_napi = fp->napi;
+        /* bzero bnx2x_fastpath contents */
+        memset(fp, 0, sizeof(*fp));
+        /* Restore the NAPI object as it has been already initialized */
+        fp->napi = orig_napi;
+}
+/**
+ * bnx2x_move_fp - move content of the fastpath structure.
+ *
+ * @bp:         driver handle
+ * @from:       source FP index
+ * @to:         destination FP index
+ *
+ * Makes sure the contents of the bp->fp[to].napi is kept
+ * intact.
+ */
+static inline void bnx2x_move_fp(struct bnx2x *bp, int from, int to)
+{
+        struct bnx2x_fastpath *from_fp = &bp->fp[from];
+        struct bnx2x_fastpath *to_fp = &bp->fp[to];
+        struct napi_struct orig_napi = to_fp->napi;
+        /* Move bnx2x_fastpath contents */
+        memcpy(to_fp, from_fp, sizeof(*to_fp));
+        to_fp->index = to;
+        /* Restore the NAPI object as it has been already initialized */
+        to_fp->napi = orig_napi;
+}
 /* free skb in the packet ring at pos idx
 * return idx of last bd freed
 */
@@ -265,13 +308,15 @@ static void bnx2x_tpa_start(struct bnx2x_fastpath *fp, u16 queue,
 */
 #define TPA_TSTAMP_OPT_LEN      12
 /**
- * Calculate the approximate value of the MSS for this
+ * bnx2x_set_lro_mss - calculate the approximate value of the MSS
- * aggregation using the first packet of it.
 *
- * @param bp
+ * @bp:                 driver handle
- * @param parsing_flags Parsing flags from the START CQE
+ * @parsing_flags:      parsing flags from the START CQE
- * @param len_on_bd Total length of the first packet for the
+ * @len_on_bd:          total length of the first packet for the
- *                   aggregation.
+ *                      aggregation.
+ *
+ * Approximate value of the MSS for this aggregation calculated using
+ * the first packet of it.
 */
 static inline u16 bnx2x_set_lro_mss(struct bnx2x *bp, u16 parsing_flags,
                                    u16 len_on_bd)
@@ -640,7 +685,7 @@ reuse_rx:
                        skb_checksum_none_assert(skb);
-                        if (bp->rx_csum) {
+                        if (bp->dev->features & NETIF_F_RXCSUM) {
                                if (likely(BNX2X_RX_CSUM_OK(cqe)))
                                        skb->ip_summed = CHECKSUM_UNNECESSARY;
                                else
@@ -758,35 +803,119 @@ u16 bnx2x_get_mf_speed(struct bnx2x *bp)
        return line_speed;
 }
+/**
+ * bnx2x_fill_report_data - fill link report data to report
+ *
+ * @bp:         driver handle
+ * @data:       link state to update
+ *
+ * It uses a none-atomic bit operations because is called under the mutex.
+ */
+static inline void bnx2x_fill_report_data(struct bnx2x *bp,
+                                          struct bnx2x_link_report_data *data)
+{
+        u16 line_speed = bnx2x_get_mf_speed(bp);
+        memset(data, 0, sizeof(*data));
+        /* Fill the report data: efective line speed */
+        data->line_speed = line_speed;
+        /* Link is down */
+        if (!bp->link_vars.link_up || (bp->flags & MF_FUNC_DIS))
+                __set_bit(BNX2X_LINK_REPORT_LINK_DOWN,
+                          &data->link_report_flags);
+        /* Full DUPLEX */
+        if (bp->link_vars.duplex == DUPLEX_FULL)
+                __set_bit(BNX2X_LINK_REPORT_FD, &data->link_report_flags);
+        /* Rx Flow Control is ON */
+        if (bp->link_vars.flow_ctrl & BNX2X_FLOW_CTRL_RX)
+                __set_bit(BNX2X_LINK_REPORT_RX_FC_ON, &data->link_report_flags);
+        /* Tx Flow Control is ON */
+        if (bp->link_vars.flow_ctrl & BNX2X_FLOW_CTRL_TX)
+                __set_bit(BNX2X_LINK_REPORT_TX_FC_ON, &data->link_report_flags);
+}
+/**
+ * bnx2x_link_report - report link status to OS.
+ *
+ * @bp:         driver handle
+ *
+ * Calls the __bnx2x_link_report() under the same locking scheme
+ * as a link/PHY state managing code to ensure a consistent link
+ * reporting.
+ */
 void bnx2x_link_report(struct bnx2x *bp)
 {
-        if (bp->flags & MF_FUNC_DIS) {
+        bnx2x_acquire_phy_lock(bp);
-                netif_carrier_off(bp->dev);
+        __bnx2x_link_report(bp);
-                netdev_err(bp->dev, "NIC Link is Down\n");
+        bnx2x_release_phy_lock(bp);
-                return;
+}
-        }
-        if (bp->link_vars.link_up) {
+/**
-                u16 line_speed;
+ * __bnx2x_link_report - report link status to OS.
+ *
+ * @bp:         driver handle
+ *
+ * None atomic inmlementation.
+ * Should be called under the phy_lock.
+ */
+void __bnx2x_link_report(struct bnx2x *bp)
+{
+        struct bnx2x_link_report_data cur_data;
-                if (bp->state == BNX2X_STATE_OPEN)
+        /* reread mf_cfg */
-                        netif_carrier_on(bp->dev);
+        if (!CHIP_IS_E1(bp))
-                netdev_info(bp->dev, "NIC Link is Up, ");
+                bnx2x_read_mf_cfg(bp);
+        /* Read the current link report info */
+        bnx2x_fill_report_data(bp, &cur_data);
+        /* Don't report link down or exactly the same link status twice */
+        if (!memcmp(&cur_data, &bp->last_reported_link, sizeof(cur_data)) ||
+            (test_bit(BNX2X_LINK_REPORT_LINK_DOWN,
+                      &bp->last_reported_link.link_report_flags) &&
+             test_bit(BNX2X_LINK_REPORT_LINK_DOWN,
+                      &cur_data.link_report_flags)))
+                return;
-                line_speed = bnx2x_get_mf_speed(bp);
+        bp->link_cnt++;
-                pr_cont("%d Mbps ", line_speed);
+        /* We are going to report a new link parameters now -
+         * remember the current data for the next time.
+         */
+        memcpy(&bp->last_reported_link, &cur_data, sizeof(cur_data));
+        if (test_bit(BNX2X_LINK_REPORT_LINK_DOWN,
+                     &cur_data.link_report_flags)) {
+                netif_carrier_off(bp->dev);
+                netdev_err(bp->dev, "NIC Link is Down\n");
+                return;
+        } else {
+                netif_carrier_on(bp->dev);
+                netdev_info(bp->dev, "NIC Link is Up, ");
+                pr_cont("%d Mbps ", cur_data.line_speed);
-                if (bp->link_vars.duplex == DUPLEX_FULL)
+                if (test_and_clear_bit(BNX2X_LINK_REPORT_FD,
+                                       &cur_data.link_report_flags))
                        pr_cont("full duplex");
                else
                        pr_cont("half duplex");
-                if (bp->link_vars.flow_ctrl != BNX2X_FLOW_CTRL_NONE) {
+                /* Handle the FC at the end so that only these flags would be
-                        if (bp->link_vars.flow_ctrl & BNX2X_FLOW_CTRL_RX) {
+                 * possibly set. This way we may easily check if there is no FC
+                 * enabled.
+                 */
+                if (cur_data.link_report_flags) {
+                        if (test_bit(BNX2X_LINK_REPORT_RX_FC_ON,
+                                     &cur_data.link_report_flags)) {
                                pr_cont(", receive ");
-                                if (bp->link_vars.flow_ctrl &
+                                if (test_bit(BNX2X_LINK_REPORT_TX_FC_ON,
-                                    BNX2X_FLOW_CTRL_TX)
+                                     &cur_data.link_report_flags))
                                        pr_cont("& transmit ");
                        } else {
                                pr_cont(", transmit ");
@@ -794,62 +923,9 @@ void bnx2x_link_report(struct bnx2x *bp)
                        pr_cont("flow control ON");
                }
                pr_cont("\n");
-        } else { /* link_down */
-                netif_carrier_off(bp->dev);
-                netdev_err(bp->dev, "NIC Link is Down\n");
        }
 }
-/* Returns the number of actually allocated BDs */
-static inline int bnx2x_alloc_rx_bds(struct bnx2x_fastpath *fp,
-                                      int rx_ring_size)
-{
-        struct bnx2x *bp = fp->bp;
-        u16 ring_prod, cqe_ring_prod;
-        int i;
-        fp->rx_comp_cons = 0;
-        cqe_ring_prod = ring_prod = 0;
-        for (i = 0; i < rx_ring_size; i++) {
-                if (bnx2x_alloc_rx_skb(bp, fp, ring_prod) < 0) {
-                        BNX2X_ERR("was only able to allocate "
-                                  "%d rx skbs on queue[%d]\n", i, fp->index);
-                        fp->eth_q_stats.rx_skb_alloc_failed++;
-                        break;
-                }
-                ring_prod = NEXT_RX_IDX(ring_prod);
-                cqe_ring_prod = NEXT_RCQ_IDX(cqe_ring_prod);
-                WARN_ON(ring_prod <= i);
-        }
-        fp->rx_bd_prod = ring_prod;
-        /* Limit the CQE producer by the CQE ring size */
-        fp->rx_comp_prod = min_t(u16, NUM_RCQ_RINGS*RCQ_DESC_CNT,
-                               cqe_ring_prod);
-        fp->rx_pkt = fp->rx_calls = 0;
-        return i;
-}
-static inline void bnx2x_alloc_rx_bd_ring(struct bnx2x_fastpath *fp)
-{
-        struct bnx2x *bp = fp->bp;
-        int rx_ring_size = bp->rx_ring_size ? bp->rx_ring_size :
-                                              MAX_RX_AVAIL/bp->num_queues;
-        rx_ring_size = max_t(int, MIN_RX_AVAIL, rx_ring_size);
-        bnx2x_alloc_rx_bds(fp, rx_ring_size);
-        /* Warning!
-         * this will generate an interrupt (to the TSTORM)
-         * must only be done after chip is initialized
-         */
-        bnx2x_update_rx_prod(bp, fp, fp->rx_bd_prod, fp->rx_comp_prod,
-                             fp->rx_sge_prod);
-}
 void bnx2x_init_rx_rings(struct bnx2x *bp)
 {
        int func = BP_FUNC(bp);
@@ -858,6 +934,7 @@ void bnx2x_init_rx_rings(struct bnx2x *bp)
        u16 ring_prod;
        int i, j;
+        /* Allocate TPA resources */
        for_each_rx_queue(bp, j) {
                struct bnx2x_fastpath *fp = &bp->fp[j];
@@ -865,6 +942,7 @@ void bnx2x_init_rx_rings(struct bnx2x *bp)
                   "mtu %d  rx_buf_size %d\n", bp->dev->mtu, fp->rx_buf_size);
                if (!fp->disable_tpa) {
+                        /* Fill the per-aggregation pool */
                        for (i = 0; i < max_agg_queues; i++) {
                                fp->tpa_pool[i].skb =
                                   netdev_alloc_skb(bp->dev, fp->rx_buf_size);
@@ -919,13 +997,13 @@ void bnx2x_init_rx_rings(struct bnx2x *bp)
                fp->rx_bd_cons = 0;
-                bnx2x_set_next_page_rx_bd(fp);
+                /* Activate BD ring */
+                /* Warning!
-                /* CQ ring */
+                 * this will generate an interrupt (to the TSTORM)
-                bnx2x_set_next_page_rx_cq(fp);
+                 * must only be done after chip is initialized
+                 */
-                /* Allocate BDs and initialize BD ring */
+                bnx2x_update_rx_prod(bp, fp, fp->rx_bd_prod, fp->rx_comp_prod,
-                bnx2x_alloc_rx_bd_ring(fp);
+                                     fp->rx_sge_prod);
                if (j != 0)
                        continue;
@@ -959,27 +1037,40 @@ static void bnx2x_free_tx_skbs(struct bnx2x *bp)
        }
 }
+static void bnx2x_free_rx_bds(struct bnx2x_fastpath *fp)
+{
+        struct bnx2x *bp = fp->bp;
+        int i;
+        /* ring wasn't allocated */
+        if (fp->rx_buf_ring == NULL)
+                return;
+        for (i = 0; i < NUM_RX_BD; i++) {
+                struct sw_rx_bd *rx_buf = &fp->rx_buf_ring[i];
+                struct sk_buff *skb = rx_buf->skb;
+                if (skb == NULL)
+                        continue;
+                dma_unmap_single(&bp->pdev->dev,
+                                 dma_unmap_addr(rx_buf, mapping),
+                                 fp->rx_buf_size, DMA_FROM_DEVICE);
+                rx_buf->skb = NULL;
+                dev_kfree_skb(skb);
+        }
+}
 static void bnx2x_free_rx_skbs(struct bnx2x *bp)
 {
-        int i, j;
+        int j;
        for_each_rx_queue(bp, j) {
                struct bnx2x_fastpath *fp = &bp->fp[j];
-                for (i = 0; i < NUM_RX_BD; i++) {
+                bnx2x_free_rx_bds(fp);
-                        struct sw_rx_bd *rx_buf = &fp->rx_buf_ring[i];
-                        struct sk_buff *skb = rx_buf->skb;
-                        if (skb == NULL)
-                                continue;
-                        dma_unmap_single(&bp->pdev->dev,
-                                         dma_unmap_addr(rx_buf, mapping),
-                                         fp->rx_buf_size, DMA_FROM_DEVICE);
-                        rx_buf->skb = NULL;
-                        dev_kfree_skb(skb);
-                }
                if (!fp->disable_tpa)
                        bnx2x_free_tpa_pool(bp, fp, CHIP_IS_E1(bp) ?
                                            ETH_MAX_AGGREGATION_QUEUES_E1 :
@@ -1345,29 +1436,47 @@ int bnx2x_nic_load(struct bnx2x *bp, int load_mode)
        bp->state = BNX2X_STATE_OPENING_WAIT4_LOAD;
+        /* Set the initial link reported state to link down */
+        bnx2x_acquire_phy_lock(bp);
+        memset(&bp->last_reported_link, 0, sizeof(bp->last_reported_link));
+        __set_bit(BNX2X_LINK_REPORT_LINK_DOWN,
+                &bp->last_reported_link.link_report_flags);
+        bnx2x_release_phy_lock(bp);
        /* must be called before memory allocation and HW init */
        bnx2x_ilt_set_info(bp);
+        /* zero fastpath structures preserving invariants like napi which are
+         * allocated only once
+         */
+        for_each_queue(bp, i)
+                bnx2x_bz_fp(bp, i);
        /* Set the receive queues buffer size */
        bnx2x_set_rx_buf_size(bp);
+        for_each_queue(bp, i)
+                bnx2x_fp(bp, i, disable_tpa) =
+                                        ((bp->flags & TPA_ENABLE_FLAG) == 0);
+#ifdef BCM_CNIC
+        /* We don't want TPA on FCoE L2 ring */
+        bnx2x_fcoe(bp, disable_tpa) = 1;
+#endif
        if (bnx2x_alloc_mem(bp))
                return -ENOMEM;
+        /* As long as bnx2x_alloc_mem() may possibly update
+         * bp->num_queues, bnx2x_set_real_num_queues() should always
+         * come after it.
+         */
        rc = bnx2x_set_real_num_queues(bp);
        if (rc) {
                BNX2X_ERR("Unable to set real_num_queues\n");
                goto load_error0;
        }
-        for_each_queue(bp, i)
-                bnx2x_fp(bp, i, disable_tpa) =
-                                        ((bp->flags & TPA_ENABLE_FLAG) == 0);
-#ifdef BCM_CNIC
-        /* We don't want TPA on FCoE L2 ring */
-        bnx2x_fcoe(bp, disable_tpa) = 1;
-#endif
        bnx2x_napi_enable(bp);
        /* Send LOAD_REQUEST command to MCP
@@ -1976,12 +2085,11 @@ static inline void bnx2x_set_pbd_gso_e2(struct sk_buff *skb, u32 *parsing_data,
 }
 /**
- * Update PBD in GSO case.
+ * bnx2x_set_pbd_gso - update PBD in GSO case.
 *
- * @param skb
+ * @skb:        packet skb
- * @param tx_start_bd
+ * @pbd:        parse BD
- * @param pbd
+ * @xmit_type:  xmit flags
- * @param xmit_type
 */
 static inline void bnx2x_set_pbd_gso(struct sk_buff *skb,
                                     struct eth_tx_parse_bd_e1x *pbd,
@@ -2008,13 +2116,14 @@ static inline void bnx2x_set_pbd_gso(struct sk_buff *skb,
 }
 /**
+ * bnx2x_set_pbd_csum_e2 - update PBD with checksum and return header length
 *
- * @param skb
+ * @bp:                 driver handle
- * @param tx_start_bd
+ * @skb:                packet skb
- * @param pbd_e2
+ * @parsing_data:       data to be updated
- * @param xmit_type
+ * @xmit_type:          xmit flags
 *
- * @return header len
+ * 57712 related
 */
 static inline  u8 bnx2x_set_pbd_csum_e2(struct bnx2x *bp, struct sk_buff *skb,
        u32 *parsing_data, u32 xmit_type)
@@ -2039,13 +2148,12 @@ static inline  u8 bnx2x_set_pbd_csum_e2(struct bnx2x *bp, struct sk_buff *skb,
 }
 /**
+ * bnx2x_set_pbd_csum - update PBD with checksum and return header length
 *
- * @param skb
+ * @bp:         driver handle
- * @param tx_start_bd
+ * @skb:        packet skb
- * @param pbd
+ * @pbd:        parse BD to be updated
- * @param xmit_type
+ * @xmit_type:  xmit flags
- *
- * @return Header length
 */
 static inline u8 bnx2x_set_pbd_csum(struct bnx2x *bp, struct sk_buff *skb,
        struct eth_tx_parse_bd_e1x *pbd,
@@ -2393,6 +2501,232 @@ int bnx2x_change_mac_addr(struct net_device *dev, void *p)
        return 0;
 }
+static void bnx2x_free_fp_mem_at(struct bnx2x *bp, int fp_index)
+{
+        union host_hc_status_block *sb = &bnx2x_fp(bp, fp_index, status_blk);
+        struct bnx2x_fastpath *fp = &bp->fp[fp_index];
+        /* Common */
+#ifdef BCM_CNIC
+        if (IS_FCOE_IDX(fp_index)) {
+                memset(sb, 0, sizeof(union host_hc_status_block));
+                fp->status_blk_mapping = 0;
+        } else {
+#endif
+                /* status blocks */
+                if (CHIP_IS_E2(bp))
+                        BNX2X_PCI_FREE(sb->e2_sb,
+                                       bnx2x_fp(bp, fp_index,
+                                                status_blk_mapping),
+                                       sizeof(struct host_hc_status_block_e2));
+                else
+                        BNX2X_PCI_FREE(sb->e1x_sb,
+                                       bnx2x_fp(bp, fp_index,
+                                                status_blk_mapping),
+                                       sizeof(struct host_hc_status_block_e1x));
+#ifdef BCM_CNIC
+        }
+#endif
+        /* Rx */
+        if (!skip_rx_queue(bp, fp_index)) {
+                bnx2x_free_rx_bds(fp);
+                /* fastpath rx rings: rx_buf rx_desc rx_comp */
+                BNX2X_FREE(bnx2x_fp(bp, fp_index, rx_buf_ring));
+                BNX2X_PCI_FREE(bnx2x_fp(bp, fp_index, rx_desc_ring),
+                               bnx2x_fp(bp, fp_index, rx_desc_mapping),
+                               sizeof(struct eth_rx_bd) * NUM_RX_BD);
+                BNX2X_PCI_FREE(bnx2x_fp(bp, fp_index, rx_comp_ring),
+                               bnx2x_fp(bp, fp_index, rx_comp_mapping),
+                               sizeof(struct eth_fast_path_rx_cqe) *
+                               NUM_RCQ_BD);
+                /* SGE ring */
+                BNX2X_FREE(bnx2x_fp(bp, fp_index, rx_page_ring));
+                BNX2X_PCI_FREE(bnx2x_fp(bp, fp_index, rx_sge_ring),
+                               bnx2x_fp(bp, fp_index, rx_sge_mapping),
+                               BCM_PAGE_SIZE * NUM_RX_SGE_PAGES);
+        }
+        /* Tx */
+        if (!skip_tx_queue(bp, fp_index)) {
+                /* fastpath tx rings: tx_buf tx_desc */
+                BNX2X_FREE(bnx2x_fp(bp, fp_index, tx_buf_ring));
+                BNX2X_PCI_FREE(bnx2x_fp(bp, fp_index, tx_desc_ring),
+                               bnx2x_fp(bp, fp_index, tx_desc_mapping),
+                               sizeof(union eth_tx_bd_types) * NUM_TX_BD);
+        }
+        /* end of fastpath */
+}
+void bnx2x_free_fp_mem(struct bnx2x *bp)
+{
+        int i;
+        for_each_queue(bp, i)
+                bnx2x_free_fp_mem_at(bp, i);
+}
+static inline void set_sb_shortcuts(struct bnx2x *bp, int index)
+{
+        union host_hc_status_block status_blk = bnx2x_fp(bp, index, status_blk);
+        if (CHIP_IS_E2(bp)) {
+                bnx2x_fp(bp, index, sb_index_values) =
+                        (__le16 *)status_blk.e2_sb->sb.index_values;
+                bnx2x_fp(bp, index, sb_running_index) =
+                        (__le16 *)status_blk.e2_sb->sb.running_index;
+        } else {
+                bnx2x_fp(bp, index, sb_index_values) =
+                        (__le16 *)status_blk.e1x_sb->sb.index_values;
+                bnx2x_fp(bp, index, sb_running_index) =
+                        (__le16 *)status_blk.e1x_sb->sb.running_index;
+        }
+}
+static int bnx2x_alloc_fp_mem_at(struct bnx2x *bp, int index)
+{
+        union host_hc_status_block *sb;
+        struct bnx2x_fastpath *fp = &bp->fp[index];
+        int ring_size = 0;
+        /* if rx_ring_size specified - use it */
+        int rx_ring_size = bp->rx_ring_size ? bp->rx_ring_size :
+                           MAX_RX_AVAIL/bp->num_queues;
+        /* allocate at least number of buffers required by FW */
+        rx_ring_size = max_t(int, fp->disable_tpa ? MIN_RX_SIZE_NONTPA :
+                                                    MIN_RX_SIZE_TPA,
+                                  rx_ring_size);
+        bnx2x_fp(bp, index, bp) = bp;
+        bnx2x_fp(bp, index, index) = index;
+        /* Common */
+        sb = &bnx2x_fp(bp, index, status_blk);
+#ifdef BCM_CNIC
+        if (!IS_FCOE_IDX(index)) {
+#endif
+                /* status blocks */
+                if (CHIP_IS_E2(bp))
+                        BNX2X_PCI_ALLOC(sb->e2_sb,
+                                &bnx2x_fp(bp, index, status_blk_mapping),
+                                sizeof(struct host_hc_status_block_e2));
+                else
+                        BNX2X_PCI_ALLOC(sb->e1x_sb,
+                                &bnx2x_fp(bp, index, status_blk_mapping),
+                            sizeof(struct host_hc_status_block_e1x));
+#ifdef BCM_CNIC
+        }
+#endif
+        set_sb_shortcuts(bp, index);
+        /* Tx */
+        if (!skip_tx_queue(bp, index)) {
+                /* fastpath tx rings: tx_buf tx_desc */
+                BNX2X_ALLOC(bnx2x_fp(bp, index, tx_buf_ring),
+                                sizeof(struct sw_tx_bd) * NUM_TX_BD);
+                BNX2X_PCI_ALLOC(bnx2x_fp(bp, index, tx_desc_ring),
+                                &bnx2x_fp(bp, index, tx_desc_mapping),
+                                sizeof(union eth_tx_bd_types) * NUM_TX_BD);
+        }
+        /* Rx */
+        if (!skip_rx_queue(bp, index)) {
+                /* fastpath rx rings: rx_buf rx_desc rx_comp */
+                BNX2X_ALLOC(bnx2x_fp(bp, index, rx_buf_ring),
+                                sizeof(struct sw_rx_bd) * NUM_RX_BD);
+                BNX2X_PCI_ALLOC(bnx2x_fp(bp, index, rx_desc_ring),
+                                &bnx2x_fp(bp, index, rx_desc_mapping),
+                                sizeof(struct eth_rx_bd) * NUM_RX_BD);
+                BNX2X_PCI_ALLOC(bnx2x_fp(bp, index, rx_comp_ring),
+                                &bnx2x_fp(bp, index, rx_comp_mapping),
+                                sizeof(struct eth_fast_path_rx_cqe) *
+                                NUM_RCQ_BD);
+                /* SGE ring */
+                BNX2X_ALLOC(bnx2x_fp(bp, index, rx_page_ring),
+                                sizeof(struct sw_rx_page) * NUM_RX_SGE);
+                BNX2X_PCI_ALLOC(bnx2x_fp(bp, index, rx_sge_ring),
+                                &bnx2x_fp(bp, index, rx_sge_mapping),
+                                BCM_PAGE_SIZE * NUM_RX_SGE_PAGES);
+                /* RX BD ring */
+                bnx2x_set_next_page_rx_bd(fp);
+                /* CQ ring */
+                bnx2x_set_next_page_rx_cq(fp);
+                /* BDs */
+                ring_size = bnx2x_alloc_rx_bds(fp, rx_ring_size);
+                if (ring_size < rx_ring_size)
+                        goto alloc_mem_err;
+        }
+        return 0;
+/* handles low memory cases */
+alloc_mem_err:
+        BNX2X_ERR("Unable to allocate full memory for queue %d (size %d)\n",
+                                                index, ring_size);
+        /* FW will drop all packets if queue is not big enough,
+         * In these cases we disable the queue
+         * Min size diferent for TPA and non-TPA queues
+         */
+        if (ring_size < (fp->disable_tpa ?
+                                MIN_RX_SIZE_TPA : MIN_RX_SIZE_NONTPA)) {
+                        /* release memory allocated for this queue */
+                        bnx2x_free_fp_mem_at(bp, index);
+                        return -ENOMEM;
+        }
+        return 0;
+}
+int bnx2x_alloc_fp_mem(struct bnx2x *bp)
+{
+        int i;
+        /**
+         * 1. Allocate FP for leading - fatal if error
+         * 2. {CNIC} Allocate FCoE FP - fatal if error
+         * 3. Allocate RSS - fix number of queues if error
+         */
+        /* leading */
+        if (bnx2x_alloc_fp_mem_at(bp, 0))
+                return -ENOMEM;
+#ifdef BCM_CNIC
+        /* FCoE */
+        if (bnx2x_alloc_fp_mem_at(bp, FCOE_IDX))
+                return -ENOMEM;
+#endif
+        /* RSS */
+        for_each_nondefault_eth_queue(bp, i)
+                if (bnx2x_alloc_fp_mem_at(bp, i))
+                        break;
+        /* handle memory failures */
+        if (i != BNX2X_NUM_ETH_QUEUES(bp)) {
+                int delta = BNX2X_NUM_ETH_QUEUES(bp) - i;
+                WARN_ON(delta < 0);
+#ifdef BCM_CNIC
+                /**
+                 * move non eth FPs next to last eth FP
+                 * must be done in that order
+                 * FCOE_IDX < FWD_IDX < OOO_IDX
+                 */
+                /* move FCoE fp */
+                bnx2x_move_fp(bp, FCOE_IDX, FCOE_IDX - delta);
+#endif
+                bp->num_queues -= delta;
+                BNX2X_ERR("Adjusted num of queues from %d to %d\n",
+                          bp->num_queues + delta, bp->num_queues);
+        }
+        return 0;
+}
 static int bnx2x_setup_irqs(struct bnx2x *bp)
 {
@@ -2457,11 +2791,21 @@ alloc_err:
 }
+static int bnx2x_reload_if_running(struct net_device *dev)
+{
+        struct bnx2x *bp = netdev_priv(dev);
+        if (unlikely(!netif_running(dev)))
+                return 0;
+        bnx2x_nic_unload(bp, UNLOAD_NORMAL);
+        return bnx2x_nic_load(bp, LOAD_NORMAL);
+}
 /* called with rtnl_lock */
 int bnx2x_change_mtu(struct net_device *dev, int new_mtu)
 {
        struct bnx2x *bp = netdev_priv(dev);
-        int rc = 0;
        if (bp->recovery_state != BNX2X_RECOVERY_DONE) {
                printk(KERN_ERR "Handling parity error recovery. Try again later\n");
@@ -2478,12 +2822,55 @@ int bnx2x_change_mtu(struct net_device *dev, int new_mtu)
         */
        dev->mtu = new_mtu;
-        if (netif_running(dev)) {
+        return bnx2x_reload_if_running(dev);
-                bnx2x_nic_unload(bp, UNLOAD_NORMAL);
+}
-                rc = bnx2x_nic_load(bp, LOAD_NORMAL);
+u32 bnx2x_fix_features(struct net_device *dev, u32 features)
+{
+        struct bnx2x *bp = netdev_priv(dev);
+        /* TPA requires Rx CSUM offloading */
+        if (!(features & NETIF_F_RXCSUM) || bp->disable_tpa)
+                features &= ~NETIF_F_LRO;
+        return features;
+}
+int bnx2x_set_features(struct net_device *dev, u32 features)
+{
+        struct bnx2x *bp = netdev_priv(dev);
+        u32 flags = bp->flags;
+        bool bnx2x_reload = false;
+        if (features & NETIF_F_LRO)
+                flags |= TPA_ENABLE_FLAG;
+        else
+                flags &= ~TPA_ENABLE_FLAG;
+        if (features & NETIF_F_LOOPBACK) {
+                if (bp->link_params.loopback_mode != LOOPBACK_BMAC) {
+                        bp->link_params.loopback_mode = LOOPBACK_BMAC;
+                        bnx2x_reload = true;
+                }
+        } else {
+                if (bp->link_params.loopback_mode != LOOPBACK_NONE) {
+                        bp->link_params.loopback_mode = LOOPBACK_NONE;
+                        bnx2x_reload = true;
+                }
        }
-        return rc;
+        if (flags ^ bp->flags) {
+                bp->flags = flags;
+                bnx2x_reload = true;
+        }
+        if (bnx2x_reload) {
+                if (bp->recovery_state == BNX2X_RECOVERY_DONE)
+                        return bnx2x_reload_if_running(dev);
+                /* else: bnx2x_nic_load() will be called at end of recovery */
+        }
+        return 0;
 }
 void bnx2x_tx_timeout(struct net_device *dev)
diff --git a/drivers/net/bnx2x/bnx2x_cmn.h b/drivers/net/bnx2x/bnx2x_cmn.h
index ef37b98d6146..fab161e8030d 100644
--- a/drivers/net/bnx2x/bnx2x_cmn.h
+++ b/drivers/net/bnx2x/bnx2x_cmn.h
@@ -1,6 +1,6 @@
 /* bnx2x_cmn.h: Broadcom Everest network driver.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
@@ -25,260 +25,277 @@
 extern int num_queues;
+/************************ Macros ********************************/
+#define BNX2X_PCI_FREE(x, y, size) \
+        do { \
+                if (x) { \
+                        dma_free_coherent(&bp->pdev->dev, size, (void *)x, y); \
+                        x = NULL; \
+                        y = 0; \
+                } \
+        } while (0)
+#define BNX2X_FREE(x) \
+        do { \
+                if (x) { \
+                        kfree((void *)x); \
+                        x = NULL; \
+                } \
+        } while (0)
+#define BNX2X_PCI_ALLOC(x, y, size) \
+        do { \
+                x = dma_alloc_coherent(&bp->pdev->dev, size, y, GFP_KERNEL); \
+                if (x == NULL) \
+                        goto alloc_mem_err; \
+                memset((void *)x, 0, size); \
+        } while (0)
+#define BNX2X_ALLOC(x, size) \
+        do { \
+                x = kzalloc(size, GFP_KERNEL); \
+                if (x == NULL) \
+                        goto alloc_mem_err; \
+        } while (0)
 /*********************** Interfaces ****************************
 *  Functions that need to be implemented by each driver version
 */
 /**
- * Initialize link parameters structure variables.
+ * bnx2x_initial_phy_init - initialize link parameters structure variables.
- *
- * @param bp
- * @param load_mode
 *
- * @return u8
+ * @bp:         driver handle
+ * @load_mode:  current mode
 */
 u8 bnx2x_initial_phy_init(struct bnx2x *bp, int load_mode);
 /**
- * Configure hw according to link parameters structure.
+ * bnx2x_link_set - configure hw according to link parameters structure.
 *
- * @param bp
+ * @bp:         driver handle
 */
 void bnx2x_link_set(struct bnx2x *bp);
 /**
- * Query link status
+ * bnx2x_link_test - query link status.
 *
- * @param bp
+ * @bp:         driver handle
- * @param is_serdes
+ * @is_serdes:  bool
 *
- * @return 0 - link is UP
+ * Returns 0 if link is UP.
 */
 u8 bnx2x_link_test(struct bnx2x *bp, u8 is_serdes);
 /**
- * Handles link status change
+ * bnx2x__link_status_update - handles link status change.
 *
- * @param bp
+ * @bp:         driver handle
 */
 void bnx2x__link_status_update(struct bnx2x *bp);
 /**
- * Report link status to upper layer
+ * bnx2x_link_report - report link status to upper layer.
- *
- * @param bp
 *
- * @return int
+ * @bp:         driver handle
 */
 void bnx2x_link_report(struct bnx2x *bp);
+/* None-atomic version of bnx2x_link_report() */
+void __bnx2x_link_report(struct bnx2x *bp);
 /**
- * calculates MF speed according to current linespeed and MF
+ * bnx2x_get_mf_speed - calculate MF speed.
- * configuration
 *
- * @param bp
+ * @bp:         driver handle
 *
- * @return u16
+ * Takes into account current linespeed and MF configuration.
 */
 u16 bnx2x_get_mf_speed(struct bnx2x *bp);
 /**
- * MSI-X slowpath interrupt handler
+ * bnx2x_msix_sp_int - MSI-X slowpath interrupt handler
- *
- * @param irq
- * @param dev_instance
 *
- * @return irqreturn_t
+ * @irq:                irq number
+ * @dev_instance:       private instance
 */
 irqreturn_t bnx2x_msix_sp_int(int irq, void *dev_instance);
 /**
- * non MSI-X interrupt handler
+ * bnx2x_interrupt - non MSI-X interrupt handler
 *
- * @param irq
+ * @irq:                irq number
- * @param dev_instance
+ * @dev_instance:       private instance
- *
- * @return irqreturn_t
 */
 irqreturn_t bnx2x_interrupt(int irq, void *dev_instance);
 #ifdef BCM_CNIC
 /**
- * Send command to cnic driver
+ * bnx2x_cnic_notify - send command to cnic driver
 *
- * @param bp
+ * @bp:         driver handle
- * @param cmd
+ * @cmd:        command
 */
 int bnx2x_cnic_notify(struct bnx2x *bp, int cmd);
 /**
- * Provides cnic information for proper interrupt handling
+ * bnx2x_setup_cnic_irq_info - provides cnic with IRQ information
 *
- * @param bp
+ * @bp:         driver handle
 */
 void bnx2x_setup_cnic_irq_info(struct bnx2x *bp);
 #endif
 /**
- * Enable HW interrupts.
+ * bnx2x_int_enable - enable HW interrupts.
 *
- * @param bp
+ * @bp:         driver handle
 */
 void bnx2x_int_enable(struct bnx2x *bp);
 /**
- * Disable interrupts. This function ensures that there are no
+ * bnx2x_int_disable_sync - disable interrupts.
- * ISRs or SP DPCs (sp_task) are running after it returns.
 *
- * @param bp
+ * @bp:         driver handle
- * @param disable_hw if true, disable HW interrupts.
+ * @disable_hw: true, disable HW interrupts.
+ *
+ * This function ensures that there are no
+ * ISRs or SP DPCs (sp_task) are running after it returns.
 */
 void bnx2x_int_disable_sync(struct bnx2x *bp, int disable_hw);
 /**
- * Loads device firmware
+ * bnx2x_init_firmware - loads device firmware
 *
- * @param bp
+ * @bp:         driver handle
- *
- * @return int
 */
 int bnx2x_init_firmware(struct bnx2x *bp);
 /**
- * Init HW blocks according to current initialization stage:
+ * bnx2x_init_hw - init HW blocks according to current initialization stage.
- * COMMON, PORT or FUNCTION.
- *
- * @param bp
- * @param load_code: COMMON, PORT or FUNCTION
 *
- * @return int
+ * @bp:         driver handle
+ * @load_code:  COMMON, PORT or FUNCTION
 */
 int bnx2x_init_hw(struct bnx2x *bp, u32 load_code);
 /**
- * Init driver internals:
+ * bnx2x_nic_init - init driver internals.
+ *
+ * @bp:         driver handle
+ * @load_code:  COMMON, PORT or FUNCTION
+ *
+ * Initializes:
 *  - rings
 *  - status blocks
 *  - etc.
- *
- * @param bp
- * @param load_code COMMON, PORT or FUNCTION
 */
 void bnx2x_nic_init(struct bnx2x *bp, u32 load_code);
 /**
- * Allocate driver's memory.
+ * bnx2x_alloc_mem - allocate driver's memory.
- *
- * @param bp
 *
- * @return int
+ * @bp:         driver handle
 */
 int bnx2x_alloc_mem(struct bnx2x *bp);
 /**
- * Release driver's memory.
+ * bnx2x_free_mem - release driver's memory.
 *
- * @param bp
+ * @bp:         driver handle
 */
 void bnx2x_free_mem(struct bnx2x *bp);
 /**
- * Setup eth Client.
+ * bnx2x_setup_client - setup eth client.
 *
- * @param bp
+ * @bp:         driver handle
- * @param fp
+ * @fp:         pointer to fastpath structure
- * @param is_leading
+ * @is_leading: boolean
- *
- * @return int
 */
 int bnx2x_setup_client(struct bnx2x *bp, struct bnx2x_fastpath *fp,
                       int is_leading);
 /**
- * Set number of queues according to mode
+ * bnx2x_set_num_queues - set number of queues according to mode.
- *
- * @param bp
 *
+ * @bp:         driver handle
 */
 void bnx2x_set_num_queues(struct bnx2x *bp);
 /**
- * Cleanup chip internals:
+ * bnx2x_chip_cleanup - cleanup chip internals.
+ *
+ * @bp:                 driver handle
+ * @unload_mode:        COMMON, PORT, FUNCTION
+ *
 * - Cleanup MAC configuration.
- * - Close clients.
+ * - Closes clients.
 * - etc.
- *
- * @param bp
- * @param unload_mode
 */
 void bnx2x_chip_cleanup(struct bnx2x *bp, int unload_mode);
 /**
- * Acquire HW lock.
+ * bnx2x_acquire_hw_lock - acquire HW lock.
 *
- * @param bp
+ * @bp:         driver handle
- * @param resource Resource bit which was locked
+ * @resource:   resource bit which was locked
- *
- * @return int
 */
 int bnx2x_acquire_hw_lock(struct bnx2x *bp, u32 resource);
 /**
- * Release HW lock.
+ * bnx2x_release_hw_lock - release HW lock.
- *
- * @param bp driver handle
- * @param resource Resource bit which was locked
 *
- * @return int
+ * @bp:         driver handle
+ * @resource:   resource bit which was locked
 */
 int bnx2x_release_hw_lock(struct bnx2x *bp, u32 resource);
 /**
- * Configure eth MAC address in the HW according to the value in
+ * bnx2x_set_eth_mac - configure eth MAC address in the HW
- * netdev->dev_addr.
 *
- * @param bp driver handle
+ * @bp:         driver handle
- * @param set
+ * @set:        set or clear
+ *
+ * Configures according to the value in netdev->dev_addr.
 */
 void bnx2x_set_eth_mac(struct bnx2x *bp, int set);
 #ifdef BCM_CNIC
 /**
- * Set/Clear FIP MAC(s) at the next enties in the CAM after the ETH
+ * bnx2x_set_fip_eth_mac_addr - Set/Clear FIP MAC(s)
- * MAC(s). This function will wait until the ramdord completion
- * returns.
 *
- * @param bp driver handle
+ * @bp:         driver handle
- * @param set set or clear the CAM entry
+ * @set:        set or clear the CAM entry
 *
- * @return 0 if cussess, -ENODEV if ramrod doesn't return.
+ * Used next enties in the CAM after the ETH MAC(s).
+ * This function will wait until the ramdord completion returns.
+ * Return 0 if cussess, -ENODEV if ramrod doesn't return.
 */
 int bnx2x_set_fip_eth_mac_addr(struct bnx2x *bp, int set);
 /**
- * Set/Clear ALL_ENODE mcast MAC.
+ * bnx2x_set_all_enode_macs - Set/Clear ALL_ENODE mcast MAC.
- *
- * @param bp
- * @param set
 *
- * @return int
+ * @bp:         driver handle
+ * @set:        set or clear
 */
 int bnx2x_set_all_enode_macs(struct bnx2x *bp, int set);
 #endif
 /**
- * Set MAC filtering configurations.
+ * bnx2x_set_rx_mode - set MAC filtering configurations.
 *
- * @remarks called with netif_tx_lock from dev_mcast.c
+ * @dev:        netdevice
 *
- * @param dev net_device
+ * called with netif_tx_lock from dev_mcast.c
 */
 void bnx2x_set_rx_mode(struct net_device *dev);
 /**
- * Configure MAC filtering rules in a FW.
+ * bnx2x_set_storm_rx_mode - configure MAC filtering rules in a FW.
 *
- * @param bp driver handle
+ * @bp:         driver handle
 */
 void bnx2x_set_storm_rx_mode(struct bnx2x *bp);
@@ -290,63 +307,59 @@ bool bnx2x_reset_is_done(struct bnx2x *bp);
 void bnx2x_disable_close_the_gate(struct bnx2x *bp);
 /**
- * Perform statistics handling according to event
+ * bnx2x_stats_handle - perform statistics handling according to event.
 *
- * @param bp driver handle
+ * @bp:         driver handle
- * @param event bnx2x_stats_event
+ * @event:      bnx2x_stats_event
 */
 void bnx2x_stats_handle(struct bnx2x *bp, enum bnx2x_stats_event event);
 /**
- * Handle ramrods completion
+ * bnx2x_sp_event - handle ramrods completion.
 *
- * @param fp fastpath handle for the event
+ * @fp:         fastpath handle for the event
- * @param rr_cqe eth_rx_cqe
+ * @rr_cqe:     eth_rx_cqe
 */
 void bnx2x_sp_event(struct bnx2x_fastpath *fp, union eth_rx_cqe *rr_cqe);
 /**
- * Init/halt function before/after sending
+ * bnx2x_func_start - init function
- * CLIENT_SETUP/CFC_DEL for the first/last client.
 *
- * @param bp
+ * @bp:         driver handle
 *
- * @return int
+ * Must be called before sending CLIENT_SETUP for the first client.
 */
 int bnx2x_func_start(struct bnx2x *bp);
 /**
- * Prepare ILT configurations according to current driver
+ * bnx2x_ilt_set_info - prepare ILT configurations.
- * parameters.
 *
- * @param bp
+ * @bp:         driver handle
 */
 void bnx2x_ilt_set_info(struct bnx2x *bp);
 /**
- * Inintialize dcbx protocol
+ * bnx2x_dcbx_init - initialize dcbx protocol.
 *
- * @param bp
+ * @bp:         driver handle
 */
 void bnx2x_dcbx_init(struct bnx2x *bp);
 /**
- * Set power state to the requested value. Currently only D0 and
+ * bnx2x_set_power_state - set power state to the requested value.
- * D3hot are supported.
 *
- * @param bp
+ * @bp:         driver handle
- * @param state D0 or D3hot
+ * @state:      required state D0 or D3hot
 *
- * @return int
+ * Currently only D0 and D3hot are supported.
 */
 int bnx2x_set_power_state(struct bnx2x *bp, pci_power_t state);
 /**
- * Updates MAX part of MF configuration in HW
+ * bnx2x_update_max_mf_config - update MAX part of MF configuration in HW.
- * (if required)
 *
- * @param bp
+ * @bp:         driver handle
- * @param value
+ * @value:      new value
 */
 void bnx2x_update_max_mf_config(struct bnx2x *bp, u32 value);
@@ -377,83 +390,72 @@ int bnx2x_resume(struct pci_dev *pdev);
 /* Release IRQ vectors */
 void bnx2x_free_irq(struct bnx2x *bp);
+void bnx2x_free_fp_mem(struct bnx2x *bp);
+int bnx2x_alloc_fp_mem(struct bnx2x *bp);
 void bnx2x_init_rx_rings(struct bnx2x *bp);
 void bnx2x_free_skbs(struct bnx2x *bp);
 void bnx2x_netif_stop(struct bnx2x *bp, int disable_hw);
 void bnx2x_netif_start(struct bnx2x *bp);
 /**
- * Fill msix_table, request vectors, update num_queues according
+ * bnx2x_enable_msix - set msix configuration.
- * to number of available vectors
 *
- * @param bp
+ * @bp:         driver handle
 *
- * @return int
+ * fills msix_table, requests vectors, updates num_queues
+ * according to number of available vectors.
 */
 int bnx2x_enable_msix(struct bnx2x *bp);
 /**
- * Request msi mode from OS, updated internals accordingly
+ * bnx2x_enable_msi - request msi mode from OS, updated internals accordingly
- *
- * @param bp
 *
- * @return int
+ * @bp:         driver handle
 */
 int bnx2x_enable_msi(struct bnx2x *bp);
 /**
- * NAPI callback
+ * bnx2x_poll - NAPI callback
 *
- * @param napi
+ * @napi:       napi structure
- * @param budget
+ * @budget:
 *
- * @return int
 */
 int bnx2x_poll(struct napi_struct *napi, int budget);
 /**
- * Allocate/release memories outsize main driver structure
+ * bnx2x_alloc_mem_bp - allocate memories outsize main driver structure
 *
- * @param bp
+ * @bp:         driver handle
- *
- * @return int
 */
 int __devinit bnx2x_alloc_mem_bp(struct bnx2x *bp);
-void bnx2x_free_mem_bp(struct bnx2x *bp);
 /**
- * Change mtu netdev callback
+ * bnx2x_free_mem_bp - release memories outsize main driver structure
 *
- * @param dev
+ * @bp:         driver handle
- * @param new_mtu
- *
- * @return int
 */
-int bnx2x_change_mtu(struct net_device *dev, int new_mtu);
+void bnx2x_free_mem_bp(struct bnx2x *bp);
 /**
- * tx timeout netdev callback
+ * bnx2x_change_mtu - change mtu netdev callback
 *
- * @param dev
+ * @dev:        net device
- * @param new_mtu
+ * @new_mtu:    requested mtu
 *
- * @return int
 */
-void bnx2x_tx_timeout(struct net_device *dev);
+int bnx2x_change_mtu(struct net_device *dev, int new_mtu);
+u32 bnx2x_fix_features(struct net_device *dev, u32 features);
+int bnx2x_set_features(struct net_device *dev, u32 features);
-#ifdef BCM_VLAN
 /**
- * vlan rx register netdev callback
+ * bnx2x_tx_timeout - tx timeout netdev callback
 *
- * @param dev
+ * @dev:        net device
- * @param new_mtu
- *
- * @return int
 */
-void bnx2x_vlan_rx_register(struct net_device *dev,
+void bnx2x_tx_timeout(struct net_device *dev);
-                                   struct vlan_group *vlgrp);
-#endif
 static inline void bnx2x_update_fpsb_idx(struct bnx2x_fastpath *fp)
 {
@@ -705,7 +707,7 @@ static inline int bnx2x_has_rx_work(struct bnx2x_fastpath *fp)
 /**
 * disables tx from stack point of view
 *
- * @param bp
+ * @bp:         driver handle
 */
 static inline void bnx2x_tx_disable(struct bnx2x *bp)
 {
@@ -880,6 +882,9 @@ static inline void bnx2x_free_rx_sge_range(struct bnx2x *bp,
 {
        int i;
+        if (fp->disable_tpa)
+                return;
        for (i = 0; i < last; i++)
                bnx2x_free_rx_sge(bp, fp, i);
 }
@@ -908,36 +913,39 @@ static inline void bnx2x_free_tpa_pool(struct bnx2x *bp,
        }
 }
+static inline void bnx2x_init_tx_ring_one(struct bnx2x_fastpath *fp)
-static inline void bnx2x_init_tx_rings(struct bnx2x *bp)
 {
-        int i, j;
+        int i;
-        for_each_tx_queue(bp, j) {
+        for (i = 1; i <= NUM_TX_RINGS; i++) {
-                struct bnx2x_fastpath *fp = &bp->fp[j];
+                struct eth_tx_next_bd *tx_next_bd =
+                        &fp->tx_desc_ring[TX_DESC_CNT * i - 1].next_bd;
-                for (i = 1; i <= NUM_TX_RINGS; i++) {
+                tx_next_bd->addr_hi =
-                        struct eth_tx_next_bd *tx_next_bd =
+                        cpu_to_le32(U64_HI(fp->tx_desc_mapping +
-                                &fp->tx_desc_ring[TX_DESC_CNT * i - 1].next_bd;
+                                    BCM_PAGE_SIZE*(i % NUM_TX_RINGS)));
+                tx_next_bd->addr_lo =
+                        cpu_to_le32(U64_LO(fp->tx_desc_mapping +
+                                    BCM_PAGE_SIZE*(i % NUM_TX_RINGS)));
+        }
-                        tx_next_bd->addr_hi =
+        SET_FLAG(fp->tx_db.data.header.header, DOORBELL_HDR_DB_TYPE, 1);
-                                cpu_to_le32(U64_HI(fp->tx_desc_mapping +
+        fp->tx_db.data.zero_fill1 = 0;
-                                            BCM_PAGE_SIZE*(i % NUM_TX_RINGS)));
+        fp->tx_db.data.prod = 0;
-                        tx_next_bd->addr_lo =
-                                cpu_to_le32(U64_LO(fp->tx_desc_mapping +
-                                            BCM_PAGE_SIZE*(i % NUM_TX_RINGS)));
-                }
-                SET_FLAG(fp->tx_db.data.header.header, DOORBELL_HDR_DB_TYPE, 1);
+        fp->tx_pkt_prod = 0;
-                fp->tx_db.data.zero_fill1 = 0;
+        fp->tx_pkt_cons = 0;
-                fp->tx_db.data.prod = 0;
+        fp->tx_bd_prod = 0;
+        fp->tx_bd_cons = 0;
+        fp->tx_pkt = 0;
+}
-                fp->tx_pkt_prod = 0;
+static inline void bnx2x_init_tx_rings(struct bnx2x *bp)
-                fp->tx_pkt_cons = 0;
+{
-                fp->tx_bd_prod = 0;
+        int i;
-                fp->tx_bd_cons = 0;
-                fp->tx_pkt = 0;
+        for_each_tx_queue(bp, i)
-        }
+                bnx2x_init_tx_ring_one(&bp->fp[i]);
 }
 static inline void bnx2x_set_next_page_rx_bd(struct bnx2x_fastpath *fp)
@@ -992,6 +1000,44 @@ static inline void bnx2x_set_next_page_rx_cq(struct bnx2x_fastpath *fp)
        }
 }
+/* Returns the number of actually allocated BDs */
+static inline int bnx2x_alloc_rx_bds(struct bnx2x_fastpath *fp,
+                                      int rx_ring_size)
+{
+        struct bnx2x *bp = fp->bp;
+        u16 ring_prod, cqe_ring_prod;
+        int i;
+        fp->rx_comp_cons = 0;
+        cqe_ring_prod = ring_prod = 0;
+        /* This routine is called only during fo init so
+         * fp->eth_q_stats.rx_skb_alloc_failed = 0
+         */
+        for (i = 0; i < rx_ring_size; i++) {
+                if (bnx2x_alloc_rx_skb(bp, fp, ring_prod) < 0) {
+                        fp->eth_q_stats.rx_skb_alloc_failed++;
+                        continue;
+                }
+                ring_prod = NEXT_RX_IDX(ring_prod);
+                cqe_ring_prod = NEXT_RCQ_IDX(cqe_ring_prod);
+                WARN_ON(ring_prod <= (i - fp->eth_q_stats.rx_skb_alloc_failed));
+        }
+        if (fp->eth_q_stats.rx_skb_alloc_failed)
+                BNX2X_ERR("was only able to allocate "
+                          "%d rx skbs on queue[%d]\n",
+                          (i - fp->eth_q_stats.rx_skb_alloc_failed), fp->index);
+        fp->rx_bd_prod = ring_prod;
+        /* Limit the CQE producer by the CQE ring size */
+        fp->rx_comp_prod = min_t(u16, NUM_RCQ_RINGS*RCQ_DESC_CNT,
+                               cqe_ring_prod);
+        fp->rx_pkt = fp->rx_calls = 0;
+        return i - fp->eth_q_stats.rx_skb_alloc_failed;
+}
 #ifdef BCM_CNIC
 static inline void bnx2x_init_fcoe_fp(struct bnx2x *bp)
 {
@@ -1041,12 +1087,23 @@ static inline void storm_memset_cmng(struct bnx2x *bp,
                                struct cmng_struct_per_port *cmng,
                                u8 port)
 {
-        size_t size = sizeof(struct cmng_struct_per_port);
+        size_t size =
+                sizeof(struct rate_shaping_vars_per_port) +
+                sizeof(struct fairness_vars_per_port) +
+                sizeof(struct safc_struct_per_port) +
+                sizeof(struct pfc_struct_per_port);
        u32 addr = BAR_XSTRORM_INTMEM +
                        XSTORM_CMNG_PER_PORT_VARS_OFFSET(port);
        __storm_memset_struct(bp, addr, size, (u32 *)cmng);
+        addr += size + 4 /* SKIP DCB+LLFC */;
+        size = sizeof(struct cmng_struct_per_port) -
+                size /* written */ - 4 /*skipped*/;
+        __storm_memset_struct(bp, addr, size,
+                              (u32 *)(cmng->traffic_type_to_priority_cos));
 }
 /* HW Lock for shared dual port PHYs */
@@ -1054,12 +1111,11 @@ void bnx2x_acquire_phy_lock(struct bnx2x *bp);
 void bnx2x_release_phy_lock(struct bnx2x *bp);
 /**
- * Extracts MAX BW part from MF configuration.
+ * bnx2x_extract_max_cfg - extract MAX BW part from MF configuration.
 *
- * @param bp
+ * @bp:         driver handle
- * @param mf_cfg
+ * @mf_cfg:     MF configuration
 *
- * @return u16
 */
 static inline u16 bnx2x_extract_max_cfg(struct bnx2x *bp, u32 mf_cfg)
 {
diff --git a/drivers/net/bnx2x/bnx2x_dcb.c b/drivers/net/bnx2x/bnx2x_dcb.c
index 9a24d79c71d9..410a49e571ac 100644
--- a/drivers/net/bnx2x/bnx2x_dcb.c
+++ b/drivers/net/bnx2x/bnx2x_dcb.c
@@ -1,6 +1,6 @@
 /* bnx2x_dcb.c: Broadcom Everest network driver.
 *
- * Copyright 2009-2010 Broadcom Corporation
+ * Copyright 2009-2011 Broadcom Corporation
 *
 * Unless you and Broadcom execute a separate written software license
 * agreement governing use of this software, this software is licensed to you
@@ -485,6 +485,36 @@ static void bnx2x_dcbx_update_ets_params(struct bnx2x *bp)
        }
 }
+#ifdef BCM_DCBNL
+static int bnx2x_dcbx_read_shmem_remote_mib(struct bnx2x *bp)
+{
+        struct lldp_remote_mib remote_mib = {0};
+        u32 dcbx_remote_mib_offset = SHMEM2_RD(bp, dcbx_remote_mib_offset);
+        int rc;
+        DP(NETIF_MSG_LINK, "dcbx_remote_mib_offset 0x%x\n",
+           dcbx_remote_mib_offset);
+        if (SHMEM_DCBX_REMOTE_MIB_NONE == dcbx_remote_mib_offset) {
+                BNX2X_ERR("FW doesn't support dcbx_remote_mib_offset\n");
+                return -EINVAL;
+        }
+        rc = bnx2x_dcbx_read_mib(bp, (u32 *)&remote_mib, dcbx_remote_mib_offset,
+                                 DCBX_READ_REMOTE_MIB);
+        if (rc) {
+                BNX2X_ERR("Faild to read remote mib from FW\n");
+                return rc;
+        }
+        /* save features and flags */
+        bp->dcbx_remote_feat = remote_mib.features;
+        bp->dcbx_remote_flags = remote_mib.flags;
+        return 0;
+}
+#endif
 static int bnx2x_dcbx_read_shmem_neg_results(struct bnx2x *bp)
 {
        struct lldp_local_mib local_mib = {0};
@@ -571,6 +601,28 @@ void bnx2x_dcbx_set_params(struct bnx2x *bp, u32 state)
 {
        switch (state) {
        case BNX2X_DCBX_STATE_NEG_RECEIVED:
+#ifdef BCM_CNIC
+                if (bp->state != BNX2X_STATE_OPENING_WAIT4_LOAD) {
+                        struct cnic_ops *c_ops;
+                        struct cnic_eth_dev *cp = &bp->cnic_eth_dev;
+                        bp->flags |= NO_ISCSI_OOO_FLAG | NO_ISCSI_FLAG;
+                        cp->drv_state |= CNIC_DRV_STATE_NO_ISCSI_OOO;
+                        cp->drv_state |= CNIC_DRV_STATE_NO_ISCSI;
+                        rcu_read_lock();
+                        c_ops = rcu_dereference(bp->cnic_ops);
+                        if (c_ops) {
+                                bnx2x_cnic_notify(bp, CNIC_CTL_STOP_ISCSI_CMD);
+                                rcu_read_unlock();
+                                return;
+                        }
+                        rcu_read_unlock();
+                }
+                /* fall through if no CNIC initialized  */
+        case BNX2X_DCBX_STATE_ISCSI_STOPPED:
+#endif
                {
                        DP(NETIF_MSG_LINK, "BNX2X_DCBX_STATE_NEG_RECEIVED\n");
 #ifdef BCM_DCBNL
@@ -579,6 +631,10 @@ void bnx2x_dcbx_set_params(struct bnx2x *bp, u32 state)
                         * negotiation results
                         */
                        bnx2x_dcbnl_update_applist(bp, true);
+                        /* Read rmeote mib if dcbx is in the FW */
+                        if (bnx2x_dcbx_read_shmem_remote_mib(bp))
+                                return;
 #endif
                        /* Read neg results if dcbx is in the FW */
                        if (bnx2x_dcbx_read_shmem_neg_results(bp))
@@ -1057,12 +1113,6 @@ static void bnx2x_dcbx_get_num_pg_traf_type(struct bnx2x *bp,
        }
 }
-/*******************************************************************************
- * Description: single priority group
- *
- * Return:
- ******************************************************************************/
 static void bnx2x_dcbx_ets_disabled_entry_data(struct bnx2x *bp,
                                               struct cos_help_data *cos_data,
                                               u32 pri_join_mask)
@@ -1075,11 +1125,6 @@ static void bnx2x_dcbx_ets_disabled_entry_data(struct bnx2x *bp,
        cos_data->num_of_cos = 1;
 }
-/*******************************************************************************
- * Description: updating the cos bw
- *
- * Return:
- ******************************************************************************/
 static inline void bnx2x_dcbx_add_to_cos_bw(struct bnx2x *bp,
                                            struct cos_entry_help_data *data,
                                            u8 pg_bw)
@@ -1090,11 +1135,6 @@ static inline void bnx2x_dcbx_add_to_cos_bw(struct bnx2x *bp,
                data->cos_bw += pg_bw;
 }
-/*******************************************************************************
- * Description: single priority group
- *
- * Return:
- ******************************************************************************/
 static void bnx2x_dcbx_separate_pauseable_from_non(struct bnx2x *bp,
                        struct cos_help_data *cos_data,
                        u32 *pg_pri_orginal_spread,
@@ -1347,11 +1387,6 @@ static void bnx2x_dcbx_two_pg_to_cos_params(
        }
 }
-/*******************************************************************************
- * Description: Still
- *
- * Return:
- ******************************************************************************/
 static void bnx2x_dcbx_three_pg_to_cos_params(
                              struct bnx2x              *bp,
                              struct pg_help_data       *pg_help_data,
@@ -1539,11 +1574,6 @@ static void bnx2x_dcbx_get_ets_pri_pg_tbl(struct bnx2x *bp,
        }
 }
-/*******************************************************************************
- * Description: Fill pfc_config struct that will be sent in DCBX start ramrod
- *
- * Return:
- ******************************************************************************/
 static void bnx2x_pfc_fw_struct_e2(struct bnx2x *bp)
 {
        struct flow_control_configuration   *pfc_fw_cfg = NULL;
@@ -2035,7 +2065,6 @@ static u8 bnx2x_dcbnl_set_dcbx(struct net_device *netdev, u8 state)
        return 0;
 }
 static u8 bnx2x_dcbnl_get_featcfg(struct net_device *netdev, int featid,
                                  u8 *flags)
 {
@@ -2115,31 +2144,100 @@ static u8 bnx2x_dcbnl_set_featcfg(struct net_device *netdev, int featid,
        return rval;
 }
+static int bnx2x_peer_appinfo(struct net_device *netdev,
+                              struct dcb_peer_app_info *info, u16* app_count)
+{
+        int i;
+        struct bnx2x *bp = netdev_priv(netdev);
+        DP(NETIF_MSG_LINK, "APP-INFO\n");
+        info->willing = (bp->dcbx_remote_flags & DCBX_APP_REM_WILLING) ?: 0;
+        info->error = (bp->dcbx_remote_flags & DCBX_APP_RX_ERROR) ?: 0;
+        *app_count = 0;
+        for (i = 0; i < DCBX_MAX_APP_PROTOCOL; i++)
+                if (bp->dcbx_remote_feat.app.app_pri_tbl[i].appBitfield &
+                    DCBX_APP_ENTRY_VALID)
+                        (*app_count)++;
+        return 0;
+}
+static int bnx2x_peer_apptable(struct net_device *netdev,
+                               struct dcb_app *table)
+{
+        int i, j;
+        struct bnx2x *bp = netdev_priv(netdev);
+        DP(NETIF_MSG_LINK, "APP-TABLE\n");
+        for (i = 0, j = 0; i < DCBX_MAX_APP_PROTOCOL; i++) {
+                struct dcbx_app_priority_entry *ent =
+                        &bp->dcbx_remote_feat.app.app_pri_tbl[i];
+                if (ent->appBitfield & DCBX_APP_ENTRY_VALID) {
+                        table[j].selector = bnx2x_dcbx_dcbnl_app_idtype(ent);
+                        table[j].priority = bnx2x_dcbx_dcbnl_app_up(ent);
+                        table[j++].protocol = ent->app_id;
+                }
+        }
+        return 0;
+}
+static int bnx2x_cee_peer_getpg(struct net_device *netdev, struct cee_pg *pg)
+{
+        int i;
+        struct bnx2x *bp = netdev_priv(netdev);
+        pg->willing = (bp->dcbx_remote_flags & DCBX_ETS_REM_WILLING) ?: 0;
+        for (i = 0; i < CEE_DCBX_MAX_PGS; i++) {
+                pg->pg_bw[i] =
+                        DCBX_PG_BW_GET(bp->dcbx_remote_feat.ets.pg_bw_tbl, i);
+                pg->prio_pg[i] =
+                        DCBX_PRI_PG_GET(bp->dcbx_remote_feat.ets.pri_pg_tbl, i);
+        }
+        return 0;
+}
+static int bnx2x_cee_peer_getpfc(struct net_device *netdev,
+                                 struct cee_pfc *pfc)
+{
+        struct bnx2x *bp = netdev_priv(netdev);
+        pfc->tcs_supported = bp->dcbx_remote_feat.pfc.pfc_caps;
+        pfc->pfc_en = bp->dcbx_remote_feat.pfc.pri_en_bitmap;
+        return 0;
+}
 const struct dcbnl_rtnl_ops bnx2x_dcbnl_ops = {
-        .getstate       = bnx2x_dcbnl_get_state,
+        .getstate               = bnx2x_dcbnl_get_state,
-        .setstate       = bnx2x_dcbnl_set_state,
+        .setstate               = bnx2x_dcbnl_set_state,
-        .getpermhwaddr  = bnx2x_dcbnl_get_perm_hw_addr,
+        .getpermhwaddr          = bnx2x_dcbnl_get_perm_hw_addr,
-        .setpgtccfgtx   = bnx2x_dcbnl_set_pg_tccfg_tx,
+        .setpgtccfgtx           = bnx2x_dcbnl_set_pg_tccfg_tx,
-        .setpgbwgcfgtx  = bnx2x_dcbnl_set_pg_bwgcfg_tx,
+        .setpgbwgcfgtx          = bnx2x_dcbnl_set_pg_bwgcfg_tx,
-        .setpgtccfgrx   = bnx2x_dcbnl_set_pg_tccfg_rx,
+        .setpgtccfgrx           = bnx2x_dcbnl_set_pg_tccfg_rx,
-        .setpgbwgcfgrx  = bnx2x_dcbnl_set_pg_bwgcfg_rx,
+        .setpgbwgcfgrx          = bnx2x_dcbnl_set_pg_bwgcfg_rx,
-        .getpgtccfgtx   = bnx2x_dcbnl_get_pg_tccfg_tx,
+        .getpgtccfgtx           = bnx2x_dcbnl_get_pg_tccfg_tx,
-        .getpgbwgcfgtx  = bnx2x_dcbnl_get_pg_bwgcfg_tx,
+        .getpgbwgcfgtx          = bnx2x_dcbnl_get_pg_bwgcfg_tx,
-        .getpgtccfgrx   = bnx2x_dcbnl_get_pg_tccfg_rx,
+        .getpgtccfgrx           = bnx2x_dcbnl_get_pg_tccfg_rx,
-        .getpgbwgcfgrx  = bnx2x_dcbnl_get_pg_bwgcfg_rx,
+        .getpgbwgcfgrx          = bnx2x_dcbnl_get_pg_bwgcfg_rx,
-        .setpfccfg      = bnx2x_dcbnl_set_pfc_cfg,
+        .setpfccfg              = bnx2x_dcbnl_set_pfc_cfg,
-        .getpfccfg      = bnx2x_dcbnl_get_pfc_cfg,
+        .getpfccfg              = bnx2x_dcbnl_get_pfc_cfg,
-        .setall         = bnx2x_dcbnl_set_all,
+        .setall                 = bnx2x_dcbnl_set_all,
-        .getcap         = bnx2x_dcbnl_get_cap,
+        .getcap                 = bnx2x_dcbnl_get_cap,
-        .getnumtcs      = bnx2x_dcbnl_get_numtcs,
+        .getnumtcs              = bnx2x_dcbnl_get_numtcs,
-        .setnumtcs      = bnx2x_dcbnl_set_numtcs,
+        .setnumtcs              = bnx2x_dcbnl_set_numtcs,
-        .getpfcstate    = bnx2x_dcbnl_get_pfc_state,
+        .getpfcstate            = bnx2x_dcbnl_get_pfc_state,
-        .setpfcstate    = bnx2x_dcbnl_set_pfc_state,
+        .setpfcstate            = bnx2x_dcbnl_set_pfc_state,
-        .setapp         = bnx2x_dcbnl_set_app_up,
+        .setapp                 = bnx2x_dcbnl_set_app_up,
-        .getdcbx        = bnx2x_dcbnl_get_dcbx,
+        .getdcbx                = bnx2x_dcbnl_get_dcbx,
-        .setdcbx        = bnx2x_dcbnl_set_dcbx,
+        .setdcbx                = bnx2x_dcbnl_set_dcbx,
-        .getfeatcfg     = bnx2x_dcbnl_get_featcfg,
+        .getfeatcfg             = bnx2x_dcbnl_get_featcfg,
-        .setfeatcfg     = bnx2x_dcbnl_set_featcfg,
+        .setfeatcfg             = bnx2x_dcbnl_set_featcfg,
+        .peer_getappinfo        = bnx2x_peer_appinfo,
+        .peer_getapptable       = bnx2x_peer_apptable,
+        .cee_peer_getpg         = bnx2x_cee_peer_getpg,
+        .cee_peer_getpfc        = bnx2x_cee_peer_getpfc,
 };
 #endif /* BCM_DCBNL */
diff --git a/drivers/net/bnx2x/bnx2x_dcb.h b/drivers/net/bnx2x/bnx2x_dcb.h
index 71b8eda43bd0..bed369d67e02 100644
--- a/drivers/net/bnx2x/bnx2x_dcb.h
+++ b/drivers/net/bnx2x/bnx2x_dcb.h
@@ -1,6 +1,6 @@
 /* bnx2x_dcb.h: Broadcom Everest network driver.
 *
- * Copyright 2009-2010 Broadcom Corporation
+ * Copyright 2009-2011 Broadcom Corporation
 *
 * Unless you and Broadcom execute a separate written software license
 * agreement governing use of this software, this software is licensed to you
@@ -61,9 +61,6 @@ struct bnx2x_dcbx_port_params {
 #define BNX2X_DCBX_OVERWRITE_SETTINGS_ENABLE            1
 #define BNX2X_DCBX_OVERWRITE_SETTINGS_INVALID   (BNX2X_DCBX_CONFIG_INV_VALUE)
-/*******************************************************************************
- * LLDP protocol configuration parameters.
- ******************************************************************************/
 struct bnx2x_config_lldp_params {
        u32 overwrite_settings;
        u32 msg_tx_hold;
@@ -83,9 +80,6 @@ struct bnx2x_admin_priority_app_table {
                u32 app_id;
 };
-/*******************************************************************************
- * DCBX protocol configuration parameters.
- ******************************************************************************/
 struct bnx2x_config_dcbx_params {
        u32 overwrite_settings;
        u32 admin_dcbx_version;
@@ -183,9 +177,13 @@ void bnx2x_dcbx_set_state(struct bnx2x *bp, bool dcb_on, u32 dcbx_enabled);
 enum {
        BNX2X_DCBX_STATE_NEG_RECEIVED = 0x1,
-        BNX2X_DCBX_STATE_TX_PAUSED = 0x2,
+#ifdef BCM_CNIC
-        BNX2X_DCBX_STATE_TX_RELEASED = 0x4
+        BNX2X_DCBX_STATE_ISCSI_STOPPED,
+#endif
+        BNX2X_DCBX_STATE_TX_PAUSED,
+        BNX2X_DCBX_STATE_TX_RELEASED
 };
 void bnx2x_dcbx_set_params(struct bnx2x *bp, u32 state);
 /* DCB netlink */
diff --git a/drivers/net/bnx2x/bnx2x_ethtool.c b/drivers/net/bnx2x/bnx2x_ethtool.c
index 89cb977898cb..727fe89ff37f 100644
--- a/drivers/net/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/bnx2x/bnx2x_ethtool.c
@@ -1,6 +1,6 @@
 /* bnx2x_ethtool.c: Broadcom Everest network driver.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
@@ -167,6 +167,7 @@ static int bnx2x_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        struct bnx2x *bp = netdev_priv(dev);
        int cfg_idx = bnx2x_get_link_cfg_idx(bp);
        /* Dual Media boards present all available port types */
        cmd->supported = bp->port.supported[cfg_idx] |
                (bp->port.supported[cfg_idx ^ 1] &
@@ -176,16 +177,16 @@ static int bnx2x_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        if ((bp->state == BNX2X_STATE_OPEN) &&
            !(bp->flags & MF_FUNC_DIS) &&
            (bp->link_vars.link_up)) {
-                cmd->speed = bp->link_vars.line_speed;
+                ethtool_cmd_speed_set(cmd, bp->link_vars.line_speed);
                cmd->duplex = bp->link_vars.duplex;
        } else {
+                ethtool_cmd_speed_set(
-                cmd->speed = bp->link_params.req_line_speed[cfg_idx];
+                        cmd, bp->link_params.req_line_speed[cfg_idx]);
                cmd->duplex = bp->link_params.req_duplex[cfg_idx];
        }
        if (IS_MF(bp))
-                cmd->speed = bnx2x_get_mf_speed(bp);
+                ethtool_cmd_speed_set(cmd, bnx2x_get_mf_speed(bp));
        if (bp->port.supported[cfg_idx] & SUPPORTED_TP)
                cmd->port = PORT_TP;
@@ -206,10 +207,11 @@ static int bnx2x_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        cmd->maxrxpkt = 0;
        DP(NETIF_MSG_LINK, "ethtool_cmd: cmd %d\n"
-           DP_LEVEL "  supported 0x%x  advertising 0x%x  speed %d\n"
+           DP_LEVEL "  supported 0x%x  advertising 0x%x  speed %u\n"
           DP_LEVEL "  duplex %d  port %d  phy_address %d  transceiver %d\n"
           DP_LEVEL "  autoneg %d  maxtxpkt %d  maxrxpkt %d\n",
-           cmd->cmd, cmd->supported, cmd->advertising, cmd->speed,
+           cmd->cmd, cmd->supported, cmd->advertising,
+           ethtool_cmd_speed(cmd),
           cmd->duplex, cmd->port, cmd->phy_address, cmd->transceiver,
           cmd->autoneg, cmd->maxtxpkt, cmd->maxrxpkt);
@@ -226,16 +228,15 @@ static int bnx2x_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                return 0;
        DP(NETIF_MSG_LINK, "ethtool_cmd: cmd %d\n"
-           "  supported 0x%x  advertising 0x%x  speed %d speed_hi %d\n"
+           "  supported 0x%x  advertising 0x%x  speed %u\n"
           "  duplex %d  port %d  phy_address %d  transceiver %d\n"
           "  autoneg %d  maxtxpkt %d  maxrxpkt %d\n",
-           cmd->cmd, cmd->supported, cmd->advertising, cmd->speed,
+           cmd->cmd, cmd->supported, cmd->advertising,
-           cmd->speed_hi,
+           ethtool_cmd_speed(cmd),
           cmd->duplex, cmd->port, cmd->phy_address, cmd->transceiver,
           cmd->autoneg, cmd->maxtxpkt, cmd->maxrxpkt);
-        speed = cmd->speed;
+        speed = ethtool_cmd_speed(cmd);
-        speed |= (cmd->speed_hi << 16);
        if (IS_MF_SI(bp)) {
                u32 part;
@@ -439,7 +440,7 @@ static int bnx2x_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                        break;
                default:
-                        DP(NETIF_MSG_LINK, "Unsupported speed %d\n", speed);
+                        DP(NETIF_MSG_LINK, "Unsupported speed %u\n", speed);
                        return -EINVAL;
                }
@@ -1219,7 +1220,8 @@ static int bnx2x_set_ringparam(struct net_device *dev,
        }
        if ((ering->rx_pending > MAX_RX_AVAIL) ||
-            (ering->rx_pending < MIN_RX_AVAIL) ||
+            (ering->rx_pending < (bp->disable_tpa ? MIN_RX_SIZE_NONTPA :
+                                                    MIN_RX_SIZE_TPA)) ||
            (ering->tx_pending > MAX_TX_AVAIL) ||
            (ering->tx_pending <= MAX_SKB_FRAGS + 4))
                return -EINVAL;
@@ -1299,91 +1301,6 @@ static int bnx2x_set_pauseparam(struct net_device *dev,
        return 0;
 }
-static int bnx2x_set_flags(struct net_device *dev, u32 data)
-{
-        struct bnx2x *bp = netdev_priv(dev);
-        int changed = 0;
-        int rc = 0;
-        if (bp->recovery_state != BNX2X_RECOVERY_DONE) {
-                printk(KERN_ERR "Handling parity error recovery. Try again later\n");
-                return -EAGAIN;
-        }
-        if (!(data & ETH_FLAG_RXVLAN))
-                return -EINVAL;
-        if ((data & ETH_FLAG_LRO) && bp->rx_csum && bp->disable_tpa)
-                return -EINVAL;
-        rc = ethtool_op_set_flags(dev, data, ETH_FLAG_LRO | ETH_FLAG_RXVLAN |
-                                        ETH_FLAG_TXVLAN | ETH_FLAG_RXHASH);
-        if (rc)
-                return rc;
-        /* TPA requires Rx CSUM offloading */
-        if ((data & ETH_FLAG_LRO) && bp->rx_csum) {
-                if (!(bp->flags & TPA_ENABLE_FLAG)) {
-                        bp->flags |= TPA_ENABLE_FLAG;
-                        changed = 1;
-                }
-        } else if (bp->flags & TPA_ENABLE_FLAG) {
-                dev->features &= ~NETIF_F_LRO;
-                bp->flags &= ~TPA_ENABLE_FLAG;
-                changed = 1;
-        }
-        if (changed && netif_running(dev)) {
-                bnx2x_nic_unload(bp, UNLOAD_NORMAL);
-                rc = bnx2x_nic_load(bp, LOAD_NORMAL);
-        }
-        return rc;
-}
-static u32 bnx2x_get_rx_csum(struct net_device *dev)
-{
-        struct bnx2x *bp = netdev_priv(dev);
-        return bp->rx_csum;
-}
-static int bnx2x_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct bnx2x *bp = netdev_priv(dev);
-        int rc = 0;
-        if (bp->recovery_state != BNX2X_RECOVERY_DONE) {
-                printk(KERN_ERR "Handling parity error recovery. Try again later\n");
-                return -EAGAIN;
-        }
-        bp->rx_csum = data;
-        /* Disable TPA, when Rx CSUM is disabled. Otherwise all
-           TPA'ed packets will be discarded due to wrong TCP CSUM */
-        if (!data) {
-                u32 flags = ethtool_op_get_flags(dev);
-                rc = bnx2x_set_flags(dev, (flags & ~ETH_FLAG_LRO));
-        }
-        return rc;
-}
-static int bnx2x_set_tso(struct net_device *dev, u32 data)
-{
-        if (data) {
-                dev->features |= (NETIF_F_TSO | NETIF_F_TSO_ECN);
-                dev->features |= NETIF_F_TSO6;
-        } else {
-                dev->features &= ~(NETIF_F_TSO | NETIF_F_TSO_ECN);
-                dev->features &= ~NETIF_F_TSO6;
-        }
-        return 0;
-}
 static const struct {
        char string[ETH_GSTRING_LEN];
 } bnx2x_tests_str_arr[BNX2X_NUM_TESTS] = {
@@ -2097,35 +2014,37 @@ static void bnx2x_get_ethtool_stats(struct net_device *dev,
        }
 }
-static int bnx2x_phys_id(struct net_device *dev, u32 data)
+static int bnx2x_set_phys_id(struct net_device *dev,
+                             enum ethtool_phys_id_state state)
 {
        struct bnx2x *bp = netdev_priv(dev);
-        int i;
        if (!netif_running(dev))
-                return 0;
+                return -EAGAIN;
        if (!bp->port.pmf)
-                return 0;
+                return -EOPNOTSUPP;
-        if (data == 0)
+        switch (state) {
-                data = 2;
+        case ETHTOOL_ID_ACTIVE:
+                return 1;       /* cycle on/off once per second */
-        for (i = 0; i < (data * 2); i++) {
+        case ETHTOOL_ID_ON:
-                if ((i % 2) == 0)
+                bnx2x_set_led(&bp->link_params, &bp->link_vars,
-                        bnx2x_set_led(&bp->link_params, &bp->link_vars,
+                              LED_MODE_ON, SPEED_1000);
-                                      LED_MODE_ON, SPEED_1000);
+                break;
-                else
-                        bnx2x_set_led(&bp->link_params, &bp->link_vars,
-                                      LED_MODE_FRONT_PANEL_OFF, 0);
-                msleep_interruptible(500);
+        case ETHTOOL_ID_OFF:
-                if (signal_pending(current))
+                bnx2x_set_led(&bp->link_params, &bp->link_vars,
-                        break;
+                              LED_MODE_FRONT_PANEL_OFF, 0);
-        }
+                break;
-        bnx2x_set_led(&bp->link_params, &bp->link_vars,
+        case ETHTOOL_ID_INACTIVE:
-                      LED_MODE_OPER, bp->link_vars.line_speed);
+                bnx2x_set_led(&bp->link_params, &bp->link_vars,
+                              LED_MODE_OPER,
+                              bp->link_vars.line_speed);
+        }
        return 0;
 }
@@ -2204,20 +2123,10 @@ static const struct ethtool_ops bnx2x_ethtool_ops = {
        .set_ringparam          = bnx2x_set_ringparam,
        .get_pauseparam         = bnx2x_get_pauseparam,
        .set_pauseparam         = bnx2x_set_pauseparam,
-        .get_rx_csum            = bnx2x_get_rx_csum,
-        .set_rx_csum            = bnx2x_set_rx_csum,
-        .get_tx_csum            = ethtool_op_get_tx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_hw_csum,
-        .set_flags              = bnx2x_set_flags,
-        .get_flags              = ethtool_op_get_flags,
-        .get_sg                 = ethtool_op_get_sg,
-        .set_sg                 = ethtool_op_set_sg,
-        .get_tso                = ethtool_op_get_tso,
-        .set_tso                = bnx2x_set_tso,
        .self_test              = bnx2x_self_test,
        .get_sset_count         = bnx2x_get_sset_count,
        .get_strings            = bnx2x_get_strings,
-        .phys_id                = bnx2x_phys_id,
+        .set_phys_id            = bnx2x_set_phys_id,
        .get_ethtool_stats      = bnx2x_get_ethtool_stats,
        .get_rxnfc              = bnx2x_get_rxnfc,
        .get_rxfh_indir         = bnx2x_get_rxfh_indir,
diff --git a/drivers/net/bnx2x/bnx2x_fw_defs.h b/drivers/net/bnx2x/bnx2x_fw_defs.h
index f4e5b1ce8149..9fe367836a57 100644
--- a/drivers/net/bnx2x/bnx2x_fw_defs.h
+++ b/drivers/net/bnx2x/bnx2x_fw_defs.h
@@ -1,6 +1,6 @@
 /* bnx2x_fw_defs.h: Broadcom Everest network driver.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
diff --git a/drivers/net/bnx2x/bnx2x_fw_file_hdr.h b/drivers/net/bnx2x/bnx2x_fw_file_hdr.h
index f807262911e5..f4a07fbaed05 100644
--- a/drivers/net/bnx2x/bnx2x_fw_file_hdr.h
+++ b/drivers/net/bnx2x/bnx2x_fw_file_hdr.h
@@ -1,6 +1,6 @@
 /* bnx2x_fw_file_hdr.h: FW binary file header structure.
 *
- * Copyright (c) 2007-2009 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
diff --git a/drivers/net/bnx2x/bnx2x_hsi.h b/drivers/net/bnx2x/bnx2x_hsi.h
index dac1bf9cbbfa..cdf19fe7c7f6 100644
--- a/drivers/net/bnx2x/bnx2x_hsi.h
+++ b/drivers/net/bnx2x/bnx2x_hsi.h
@@ -1,6 +1,6 @@
 /* bnx2x_hsi.h: Broadcom Everest network driver.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
@@ -1929,7 +1929,7 @@ struct host_func_stats {
 #define BCM_5710_FW_MAJOR_VERSION                       6
 #define BCM_5710_FW_MINOR_VERSION                       2
-#define BCM_5710_FW_REVISION_VERSION                    5
+#define BCM_5710_FW_REVISION_VERSION                    9
 #define BCM_5710_FW_ENGINEERING_VERSION                 0
 #define BCM_5710_FW_COMPILE_FLAGS                       1
diff --git a/drivers/net/bnx2x/bnx2x_init.h b/drivers/net/bnx2x/bnx2x_init.h
index fa6dbe3f2058..d5399206f66e 100644
--- a/drivers/net/bnx2x/bnx2x_init.h
+++ b/drivers/net/bnx2x/bnx2x_init.h
@@ -1,7 +1,7 @@
 /* bnx2x_init.h: Broadcom Everest network driver.
 *               Structures and macroes needed during the initialization.
 *
- * Copyright (c) 2007-2009 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
diff --git a/drivers/net/bnx2x/bnx2x_init_ops.h b/drivers/net/bnx2x/bnx2x_init_ops.h
index 66df29fcf751..aafd0232393f 100644
--- a/drivers/net/bnx2x/bnx2x_init_ops.h
+++ b/drivers/net/bnx2x/bnx2x_init_ops.h
@@ -2,7 +2,7 @@
 *               Static functions needed during the initialization.
 *               This file is "included" in bnx2x_main.c.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
diff --git a/drivers/net/bnx2x/bnx2x_link.c b/drivers/net/bnx2x/bnx2x_link.c
index 974ef2be36a5..076e11f5769f 100644
--- a/drivers/net/bnx2x/bnx2x_link.c
+++ b/drivers/net/bnx2x/bnx2x_link.c
@@ -385,7 +385,7 @@ u8 bnx2x_ets_strict(const struct link_params *params, const u8 strict_cos)
        return 0;
 }
 /******************************************************************/
-/*                      ETS section                               */
+/*                      PFC section                               */
 /******************************************************************/
 static void bnx2x_bmac2_get_pfc_stat(struct link_params *params,
@@ -1301,14 +1301,12 @@ static u8 bnx2x_pbf_update(struct link_params *params, u32 flow_ctrl,
        return 0;
 }
-/*
+/**
- * get_emac_base
+ * bnx2x_get_emac_base - retrive emac base address
- *
- * @param cb
- * @param mdc_mdio_access
- * @param port
 *
- * @return u32
+ * @bp:                 driver handle
+ * @mdc_mdio_access:    access type
+ * @port:               port id
 *
 * This function selects the MDC/MDIO access (through emac0 or
 * emac1) depend on the mdc_mdio_access, port, port swapped. Each
diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c
index a97a4a1c344f..f45c0caf3240 100644
--- a/drivers/net/bnx2x/bnx2x_main.c
+++ b/drivers/net/bnx2x/bnx2x_main.c
@@ -1,6 +1,6 @@
 /* bnx2x_main.c: Broadcom Everest network driver.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
@@ -2036,7 +2036,7 @@ static int bnx2x_get_cmng_fns_mode(struct bnx2x *bp)
        return CMNG_FNS_NONE;
 }
-static void bnx2x_read_mf_cfg(struct bnx2x *bp)
+void bnx2x_read_mf_cfg(struct bnx2x *bp)
 {
        int vn, n = (CHIP_MODE_IS_4_PORT(bp) ? 2 : 1);
@@ -2123,7 +2123,6 @@ static inline void bnx2x_link_sync_notify(struct bnx2x *bp)
 /* This function is called upon link interrupt */
 static void bnx2x_link_attn(struct bnx2x *bp)
 {
-        u32 prev_link_status = bp->link_vars.link_status;
        /* Make sure that we are synced with the current statistics */
        bnx2x_stats_handle(bp, STATS_EVENT_STOP);
@@ -2168,17 +2167,15 @@ static void bnx2x_link_attn(struct bnx2x *bp)
                           "single function mode without fairness\n");
        }
+        __bnx2x_link_report(bp);
        if (IS_MF(bp))
                bnx2x_link_sync_notify(bp);
-        /* indicate link status only if link status actually changed */
-        if (prev_link_status != bp->link_vars.link_status)
-                bnx2x_link_report(bp);
 }
 void bnx2x__link_status_update(struct bnx2x *bp)
 {
-        if ((bp->state != BNX2X_STATE_OPEN) || (bp->flags & MF_FUNC_DIS))
+        if (bp->state != BNX2X_STATE_OPEN)
                return;
        bnx2x_link_status_update(&bp->link_params, &bp->link_vars);
@@ -2188,10 +2185,6 @@ void bnx2x__link_status_update(struct bnx2x *bp)
        else
                bnx2x_stats_handle(bp, STATS_EVENT_STOP);
-        /* the link status update could be the result of a DCC event
-           hence re-read the shmem mf configuration */
-        bnx2x_read_mf_cfg(bp);
        /* indicate link status */
        bnx2x_link_report(bp);
 }
@@ -3120,10 +3113,14 @@ static inline void bnx2x_attn_int_deasserted3(struct bnx2x *bp, u32 attn)
                        if (val & DRV_STATUS_SET_MF_BW)
                                bnx2x_set_mf_bw(bp);
-                        bnx2x__link_status_update(bp);
                        if ((bp->port.pmf == 0) && (val & DRV_STATUS_PMF))
                                bnx2x_pmf_update(bp);
+                        /* Always call it here: bnx2x_link_report() will
+                         * prevent the link indication duplication.
+                         */
+                        bnx2x__link_status_update(bp);
                        if (bp->port.pmf &&
                            (val & DRV_STATUS_DCBX_NEGOTIATION_RESULTS) &&
                                bp->dcbx_enabled > 0)
@@ -3904,10 +3901,9 @@ static void bnx2x_timer(unsigned long data)
        if (poll) {
                struct bnx2x_fastpath *fp = &bp->fp[0];
-                int rc;
                bnx2x_tx_int(fp);
-                rc = bnx2x_rx_int(fp, 1000);
+                bnx2x_rx_int(fp, 1000);
        }
        if (!BP_NOMCP(bp)) {
@@ -4062,7 +4058,6 @@ static void bnx2x_init_sb(struct bnx2x *bp, dma_addr_t mapping, int vfid,
        struct hc_status_block_data_e2 sb_data_e2;
        struct hc_status_block_data_e1x sb_data_e1x;
        struct hc_status_block_sm  *hc_sm_p;
-        struct hc_index_data *hc_index_p;
        int data_size;
        u32 *sb_data_p;
@@ -4083,7 +4078,6 @@ static void bnx2x_init_sb(struct bnx2x *bp, dma_addr_t mapping, int vfid,
                sb_data_e2.common.host_sb_addr.hi = U64_HI(mapping);
                sb_data_e2.common.host_sb_addr.lo = U64_LO(mapping);
                hc_sm_p = sb_data_e2.common.state_machine;
-                hc_index_p = sb_data_e2.index_data;
                sb_data_p = (u32 *)&sb_data_e2;
                data_size = sizeof(struct hc_status_block_data_e2)/sizeof(u32);
        } else {
@@ -4097,7 +4091,6 @@ static void bnx2x_init_sb(struct bnx2x *bp, dma_addr_t mapping, int vfid,
                sb_data_e1x.common.host_sb_addr.hi = U64_HI(mapping);
                sb_data_e1x.common.host_sb_addr.lo = U64_LO(mapping);
                hc_sm_p = sb_data_e1x.common.state_machine;
-                hc_index_p = sb_data_e1x.index_data;
                sb_data_p = (u32 *)&sb_data_e1x;
                data_size = sizeof(struct hc_status_block_data_e1x)/sizeof(u32);
        }
@@ -4454,7 +4447,7 @@ static void bnx2x_init_fp_sb(struct bnx2x *bp, int fp_idx)
        fp->state = BNX2X_FP_STATE_CLOSED;
-        fp->index = fp->cid = fp_idx;
+        fp->cid = fp_idx;
        fp->cl_id = BP_L_ID(bp) + fp_idx;
        fp->fw_sb_id = bp->base_fw_ndsb + fp->cl_id + CNIC_CONTEXT_USE;
        fp->igu_sb_id = bp->igu_base_sb + fp_idx + CNIC_CONTEXT_USE;
@@ -4566,9 +4559,11 @@ gunzip_nomem1:
 static void bnx2x_gunzip_end(struct bnx2x *bp)
 {
-        kfree(bp->strm->workspace);
+        if (bp->strm) {
-        kfree(bp->strm);
+                kfree(bp->strm->workspace);
-        bp->strm = NULL;
+                kfree(bp->strm);
+                bp->strm = NULL;
+        }
        if (bp->gunzip_buf) {
                dma_free_coherent(&bp->pdev->dev, FW_BUF_SIZE, bp->gunzip_buf,
@@ -5876,9 +5871,6 @@ int bnx2x_init_hw(struct bnx2x *bp, u32 load_code)
        bp->dmae_ready = 0;
        spin_lock_init(&bp->dmae_lock);
-        rc = bnx2x_gunzip_init(bp);
-        if (rc)
-                return rc;
        switch (load_code) {
        case FW_MSG_CODE_DRV_LOAD_COMMON:
@@ -5922,80 +5914,10 @@ init_hw_err:
 void bnx2x_free_mem(struct bnx2x *bp)
 {
+        bnx2x_gunzip_end(bp);
-#define BNX2X_PCI_FREE(x, y, size) \
-        do { \
-                if (x) { \
-                        dma_free_coherent(&bp->pdev->dev, size, (void *)x, y); \
-                        x = NULL; \
-                        y = 0; \
-                } \
-        } while (0)
-#define BNX2X_FREE(x) \
-        do { \
-                if (x) { \
-                        kfree((void *)x); \
-                        x = NULL; \
-                } \
-        } while (0)
-        int i;
        /* fastpath */
-        /* Common */
+        bnx2x_free_fp_mem(bp);
-        for_each_queue(bp, i) {
-#ifdef BCM_CNIC
-                /* FCoE client uses default status block */
-                if (IS_FCOE_IDX(i)) {
-                        union host_hc_status_block *sb =
-                                &bnx2x_fp(bp, i, status_blk);
-                        memset(sb, 0, sizeof(union host_hc_status_block));
-                        bnx2x_fp(bp, i, status_blk_mapping) = 0;
-                } else {
-#endif
-                /* status blocks */
-                if (CHIP_IS_E2(bp))
-                        BNX2X_PCI_FREE(bnx2x_fp(bp, i, status_blk.e2_sb),
-                                       bnx2x_fp(bp, i, status_blk_mapping),
-                                       sizeof(struct host_hc_status_block_e2));
-                else
-                        BNX2X_PCI_FREE(bnx2x_fp(bp, i, status_blk.e1x_sb),
-                                       bnx2x_fp(bp, i, status_blk_mapping),
-                                       sizeof(struct host_hc_status_block_e1x));
-#ifdef BCM_CNIC
-                }
-#endif
-        }
-        /* Rx */
-        for_each_rx_queue(bp, i) {
-                /* fastpath rx rings: rx_buf rx_desc rx_comp */
-                BNX2X_FREE(bnx2x_fp(bp, i, rx_buf_ring));
-                BNX2X_PCI_FREE(bnx2x_fp(bp, i, rx_desc_ring),
-                               bnx2x_fp(bp, i, rx_desc_mapping),
-                               sizeof(struct eth_rx_bd) * NUM_RX_BD);
-                BNX2X_PCI_FREE(bnx2x_fp(bp, i, rx_comp_ring),
-                               bnx2x_fp(bp, i, rx_comp_mapping),
-                               sizeof(struct eth_fast_path_rx_cqe) *
-                               NUM_RCQ_BD);
-                /* SGE ring */
-                BNX2X_FREE(bnx2x_fp(bp, i, rx_page_ring));
-                BNX2X_PCI_FREE(bnx2x_fp(bp, i, rx_sge_ring),
-                               bnx2x_fp(bp, i, rx_sge_mapping),
-                               BCM_PAGE_SIZE * NUM_RX_SGE_PAGES);
-        }
-        /* Tx */
-        for_each_tx_queue(bp, i) {
-                /* fastpath tx rings: tx_buf tx_desc */
-                BNX2X_FREE(bnx2x_fp(bp, i, tx_buf_ring));
-                BNX2X_PCI_FREE(bnx2x_fp(bp, i, tx_desc_ring),
-                               bnx2x_fp(bp, i, tx_desc_mapping),
-                               sizeof(union eth_tx_bd_types) * NUM_TX_BD);
-        }
        /* end of fastpath */
        BNX2X_PCI_FREE(bp->def_status_blk, bp->def_status_blk_mapping,
@@ -6028,101 +5950,13 @@ void bnx2x_free_mem(struct bnx2x *bp)
                       BCM_PAGE_SIZE * NUM_EQ_PAGES);
        BNX2X_FREE(bp->rx_indir_table);
-#undef BNX2X_PCI_FREE
-#undef BNX2X_KFREE
 }
-static inline void set_sb_shortcuts(struct bnx2x *bp, int index)
-{
-        union host_hc_status_block status_blk = bnx2x_fp(bp, index, status_blk);
-        if (CHIP_IS_E2(bp)) {
-                bnx2x_fp(bp, index, sb_index_values) =
-                        (__le16 *)status_blk.e2_sb->sb.index_values;
-                bnx2x_fp(bp, index, sb_running_index) =
-                        (__le16 *)status_blk.e2_sb->sb.running_index;
-        } else {
-                bnx2x_fp(bp, index, sb_index_values) =
-                        (__le16 *)status_blk.e1x_sb->sb.index_values;
-                bnx2x_fp(bp, index, sb_running_index) =
-                        (__le16 *)status_blk.e1x_sb->sb.running_index;
-        }
-}
 int bnx2x_alloc_mem(struct bnx2x *bp)
 {
-#define BNX2X_PCI_ALLOC(x, y, size) \
+        if (bnx2x_gunzip_init(bp))
-        do { \
+                return -ENOMEM;
-                x = dma_alloc_coherent(&bp->pdev->dev, size, y, GFP_KERNEL); \
-                if (x == NULL) \
-                        goto alloc_mem_err; \
-                memset(x, 0, size); \
-        } while (0)
-#define BNX2X_ALLOC(x, size) \
-        do { \
-                x = kzalloc(size, GFP_KERNEL); \
-                if (x == NULL) \
-                        goto alloc_mem_err; \
-        } while (0)
-        int i;
-        /* fastpath */
-        /* Common */
-        for_each_queue(bp, i) {
-                union host_hc_status_block *sb = &bnx2x_fp(bp, i, status_blk);
-                bnx2x_fp(bp, i, bp) = bp;
-                /* status blocks */
-#ifdef BCM_CNIC
-                if (!IS_FCOE_IDX(i)) {
-#endif
-                        if (CHIP_IS_E2(bp))
-                                BNX2X_PCI_ALLOC(sb->e2_sb,
-                                    &bnx2x_fp(bp, i, status_blk_mapping),
-                                    sizeof(struct host_hc_status_block_e2));
-                        else
-                                BNX2X_PCI_ALLOC(sb->e1x_sb,
-                                    &bnx2x_fp(bp, i, status_blk_mapping),
-                                    sizeof(struct host_hc_status_block_e1x));
-#ifdef BCM_CNIC
-                }
-#endif
-                set_sb_shortcuts(bp, i);
-        }
-        /* Rx */
-        for_each_queue(bp, i) {
-                /* fastpath rx rings: rx_buf rx_desc rx_comp */
-                BNX2X_ALLOC(bnx2x_fp(bp, i, rx_buf_ring),
-                                sizeof(struct sw_rx_bd) * NUM_RX_BD);
-                BNX2X_PCI_ALLOC(bnx2x_fp(bp, i, rx_desc_ring),
-                                &bnx2x_fp(bp, i, rx_desc_mapping),
-                                sizeof(struct eth_rx_bd) * NUM_RX_BD);
-                BNX2X_PCI_ALLOC(bnx2x_fp(bp, i, rx_comp_ring),
-                                &bnx2x_fp(bp, i, rx_comp_mapping),
-                                sizeof(struct eth_fast_path_rx_cqe) *
-                                NUM_RCQ_BD);
-                /* SGE ring */
-                BNX2X_ALLOC(bnx2x_fp(bp, i, rx_page_ring),
-                                sizeof(struct sw_rx_page) * NUM_RX_SGE);
-                BNX2X_PCI_ALLOC(bnx2x_fp(bp, i, rx_sge_ring),
-                                &bnx2x_fp(bp, i, rx_sge_mapping),
-                                BCM_PAGE_SIZE * NUM_RX_SGE_PAGES);
-        }
-        /* Tx */
-        for_each_queue(bp, i) {
-                /* fastpath tx rings: tx_buf tx_desc */
-                BNX2X_ALLOC(bnx2x_fp(bp, i, tx_buf_ring),
-                                sizeof(struct sw_tx_bd) * NUM_TX_BD);
-                BNX2X_PCI_ALLOC(bnx2x_fp(bp, i, tx_desc_ring),
-                                &bnx2x_fp(bp, i, tx_desc_mapping),
-                                sizeof(union eth_tx_bd_types) * NUM_TX_BD);
-        }
-        /* end of fastpath */
 #ifdef BCM_CNIC
        if (CHIP_IS_E2(bp))
@@ -6162,14 +5996,18 @@ int bnx2x_alloc_mem(struct bnx2x *bp)
        BNX2X_ALLOC(bp->rx_indir_table, sizeof(bp->rx_indir_table[0]) *
                    TSTORM_INDIRECTION_TABLE_SIZE);
+        /* fastpath */
+        /* need to be done at the end, since it's self adjusting to amount
+         * of memory available for RSS queues
+         */
+        if (bnx2x_alloc_fp_mem(bp))
+                goto alloc_mem_err;
        return 0;
 alloc_mem_err:
        bnx2x_free_mem(bp);
        return -ENOMEM;
-#undef BNX2X_PCI_ALLOC
-#undef BNX2X_ALLOC
 }
 /*
@@ -6197,14 +6035,14 @@ static int bnx2x_func_stop(struct bnx2x *bp)
 }
 /**
- * Sets a MAC in a CAM for a few L2 Clients for E1x chips
+ * bnx2x_set_mac_addr_gen - set a MAC in a CAM for a few L2 Clients for E1x chips
 *
- * @param bp driver descriptor
+ * @bp:         driver handle
- * @param set set or clear an entry (1 or 0)
+ * @set:        set or clear an entry (1 or 0)
- * @param mac pointer to a buffer containing a MAC
+ * @mac:        pointer to a buffer containing a MAC
- * @param cl_bit_vec bit vector of clients to register a MAC for
+ * @cl_bit_vec: bit vector of clients to register a MAC for
- * @param cam_offset offset in a CAM to use
+ * @cam_offset: offset in a CAM to use
- * @param is_bcast is the set MAC a broadcast address (for E1 only)
+ * @is_bcast:   is the set MAC a broadcast address (for E1 only)
 */
 static void bnx2x_set_mac_addr_gen(struct bnx2x *bp, int set, const u8 *mac,
                                   u32 cl_bit_vec, u8 cam_offset,
@@ -6564,14 +6402,13 @@ void bnx2x_invalidate_e1h_mc_list(struct bnx2x *bp)
 #ifdef BCM_CNIC
 /**
- * Set iSCSI MAC(s) at the next enties in the CAM after the ETH
+ * bnx2x_set_iscsi_eth_mac_addr - set iSCSI MAC(s).
- * MAC(s). This function will wait until the ramdord completion
- * returns.
 *
- * @param bp driver handle
+ * @bp:         driver handle
- * @param set set or clear the CAM entry
+ * @set:        set or clear the CAM entry
 *
- * @return 0 if cussess, -ENODEV if ramrod doesn't return.
+ * This function will wait until the ramdord completion returns.
+ * Return 0 if success, -ENODEV if ramrod doesn't return.
 */
 static int bnx2x_set_iscsi_eth_mac_addr(struct bnx2x *bp, int set)
 {
@@ -6592,14 +6429,13 @@ static int bnx2x_set_iscsi_eth_mac_addr(struct bnx2x *bp, int set)
 }
 /**
- * Set FCoE L2 MAC(s) at the next enties in the CAM after the
+ * bnx2x_set_fip_eth_mac_addr - set FCoE L2 MAC(s)
- * ETH MAC(s). This function will wait until the ramdord
- * completion returns.
 *
- * @param bp driver handle
+ * @bp:         driver handle
- * @param set set or clear the CAM entry
+ * @set:        set or clear the CAM entry
 *
- * @return 0 if cussess, -ENODEV if ramrod doesn't return.
+ * This function will wait until the ramrod completion returns.
+ * Returns 0 if success, -ENODEV if ramrod doesn't return.
 */
 int bnx2x_set_fip_eth_mac_addr(struct bnx2x *bp, int set)
 {
@@ -6803,12 +6639,11 @@ static int bnx2x_setup_fw_client(struct bnx2x *bp,
 }
 /**
- * Configure interrupt mode according to current configuration.
+ * bnx2x_set_int_mode - configure interrupt mode
- * In case of MSI-X it will also try to enable MSI-X.
 *
- * @param bp
+ * @bp:         driver handle
 *
- * @return int
+ * In case of MSI-X it will also try to enable MSI-X.
 */
 static int __devinit bnx2x_set_int_mode(struct bnx2x *bp)
 {
@@ -7392,10 +7227,11 @@ static void bnx2x_clp_reset_prep(struct bnx2x *bp, u32 *magic_val)
        MF_CFG_WR(bp, shared_mf_config.clp_mb, val | SHARED_MF_CLP_MAGIC);
 }
-/* Restore the value of the `magic' bit.
+/**
+ * bnx2x_clp_reset_done - restore the value of the `magic' bit.
 *
- * @param pdev Device handle.
+ * @bp:         driver handle
- * @param magic_val Old value of the `magic' bit.
+ * @magic_val:  old value of the `magic' bit.
 */
 static void bnx2x_clp_reset_done(struct bnx2x *bp, u32 magic_val)
 {
@@ -7406,10 +7242,12 @@ static void bnx2x_clp_reset_done(struct bnx2x *bp, u32 magic_val)
 }
 /**
- * Prepares for MCP reset: takes care of CLP configurations.
+ * bnx2x_reset_mcp_prep - prepare for MCP reset.
 *
- * @param bp
+ * @bp:         driver handle
- * @param magic_val Old value of 'magic' bit.
+ * @magic_val:  old value of 'magic' bit.
+ *
+ * Takes care of CLP configurations.
 */
 static void bnx2x_reset_mcp_prep(struct bnx2x *bp, u32 *magic_val)
 {
@@ -7434,10 +7272,10 @@ static void bnx2x_reset_mcp_prep(struct bnx2x *bp, u32 *magic_val)
 #define MCP_TIMEOUT      5000   /* 5 seconds (in ms) */
 #define MCP_ONE_TIMEOUT  100    /* 100 ms */
-/* Waits for MCP_ONE_TIMEOUT or MCP_ONE_TIMEOUT*10,
+/**
- * depending on the HW type.
+ * bnx2x_mcp_wait_one - wait for MCP_ONE_TIMEOUT
 *
- * @param bp
+ * @bp: driver handle
 */
 static inline void bnx2x_mcp_wait_one(struct bnx2x *bp)
 {
@@ -8059,13 +7897,9 @@ static void __devinit bnx2x_get_common_hwinfo(struct bnx2x *bp)
                (val >= REQ_BC_VER_4_VRFY_SPECIFIC_PHY_OPT_MDL) ?
                FEATURE_CONFIG_BC_SUPPORTS_DUAL_PHY_OPT_MDL_VRFY : 0;
-        if (BP_E1HVN(bp) == 0) {
+        pci_read_config_word(bp->pdev, bp->pm_cap + PCI_PM_PMC, &pmc);
-                pci_read_config_word(bp->pdev, bp->pm_cap + PCI_PM_PMC, &pmc);
+        bp->flags |= (pmc & PCI_PM_CAP_PME_D3cold) ? 0 : NO_WOL_FLAG;
-                bp->flags |= (pmc & PCI_PM_CAP_PME_D3cold) ? 0 : NO_WOL_FLAG;
-        } else {
-                /* no WOL capability for E1HVN != 0 */
-                bp->flags |= NO_WOL_FLAG;
-        }
        BNX2X_DEV_INFO("%sWoL capable\n",
                       (bp->flags & NO_WOL_FLAG) ? "not " : "");
@@ -8571,15 +8405,6 @@ static void __devinit bnx2x_get_mac_hwinfo(struct bnx2x *bp)
                                BNX2X_DEV_INFO("Read iSCSI MAC: "
                                               "0x%x:0x%04x\n", val2, val);
                                bnx2x_set_mac_buf(iscsi_mac, val, val2);
-                                /* Disable iSCSI OOO if MAC configuration is
-                                 * invalid.
-                                 */
-                                if (!is_valid_ether_addr(iscsi_mac)) {
-                                        bp->flags |= NO_ISCSI_OOO_FLAG |
-                                                     NO_ISCSI_FLAG;
-                                        memset(iscsi_mac, 0, ETH_ALEN);
-                                }
                        } else
                                bp->flags |= NO_ISCSI_OOO_FLAG | NO_ISCSI_FLAG;
@@ -8592,13 +8417,6 @@ static void __devinit bnx2x_get_mac_hwinfo(struct bnx2x *bp)
                                               "0x%x:0x%04x\n", val2, val);
                                bnx2x_set_mac_buf(fip_mac, val, val2);
-                                /* Disable FCoE if MAC configuration is
-                                 * invalid.
-                                 */
-                                if (!is_valid_ether_addr(fip_mac)) {
-                                        bp->flags |= NO_FCOE_FLAG;
-                                        memset(bp->fip_mac, 0, ETH_ALEN);
-                                }
                        } else
                                bp->flags |= NO_FCOE_FLAG;
                }
@@ -8629,13 +8447,29 @@ static void __devinit bnx2x_get_mac_hwinfo(struct bnx2x *bp)
                else if (!IS_MF(bp))
                        memcpy(fip_mac, iscsi_mac, ETH_ALEN);
        }
+        /* Disable iSCSI if MAC configuration is
+         * invalid.
+         */
+        if (!is_valid_ether_addr(iscsi_mac)) {
+                bp->flags |= NO_ISCSI_FLAG;
+                memset(iscsi_mac, 0, ETH_ALEN);
+        }
+        /* Disable FCoE if MAC configuration is
+         * invalid.
+         */
+        if (!is_valid_ether_addr(fip_mac)) {
+                bp->flags |= NO_FCOE_FLAG;
+                memset(bp->fip_mac, 0, ETH_ALEN);
+        }
 #endif
 }
 static int __devinit bnx2x_get_hwinfo(struct bnx2x *bp)
 {
        int /*abs*/func = BP_ABS_FUNC(bp);
-        int vn, port;
+        int vn;
        u32 val = 0;
        int rc = 0;
@@ -8670,7 +8504,6 @@ static int __devinit bnx2x_get_hwinfo(struct bnx2x *bp)
        bp->mf_ov = 0;
        bp->mf_mode = 0;
        vn = BP_E1HVN(bp);
-        port = BP_PORT(bp);
        if (!CHIP_IS_E1(bp) && !BP_NOMCP(bp)) {
                DP(NETIF_MSG_PROBE,
@@ -8904,8 +8737,6 @@ static int __devinit bnx2x_init_bp(struct bnx2x *bp)
        bp->multi_mode = multi_mode;
        bp->int_mode = int_mode;
-        bp->dev->features |= NETIF_F_GRO;
        /* Set TPA flags */
        if (disable_tpa) {
                bp->flags &= ~TPA_ENABLE_FLAG;
@@ -8925,8 +8756,6 @@ static int __devinit bnx2x_init_bp(struct bnx2x *bp)
        bp->tx_ring_size = MAX_TX_AVAIL;
-        bp->rx_csum = 1;
        /* make sure that the numbers are in the right granularity */
        bp->tx_ticks = (50 / BNX2X_BTR) * BNX2X_BTR;
        bp->rx_ticks = (25 / BNX2X_BTR) * BNX2X_BTR;
@@ -9304,6 +9133,8 @@ static const struct net_device_ops bnx2x_netdev_ops = {
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_do_ioctl           = bnx2x_ioctl,
        .ndo_change_mtu         = bnx2x_change_mtu,
+        .ndo_fix_features       = bnx2x_fix_features,
+        .ndo_set_features       = bnx2x_set_features,
        .ndo_tx_timeout         = bnx2x_tx_timeout,
 #ifdef CONFIG_NET_POLL_CONTROLLER
        .ndo_poll_controller    = poll_bnx2x,
@@ -9430,20 +9261,20 @@ static int __devinit bnx2x_init_dev(struct pci_dev *pdev,
        dev->netdev_ops = &bnx2x_netdev_ops;
        bnx2x_set_ethtool_ops(dev);
-        dev->features |= NETIF_F_SG;
-        dev->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
+        dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
+                NETIF_F_TSO | NETIF_F_TSO_ECN | NETIF_F_TSO6 |
+                NETIF_F_RXCSUM | NETIF_F_LRO | NETIF_F_HW_VLAN_TX;
+        dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
+                NETIF_F_TSO | NETIF_F_TSO_ECN | NETIF_F_TSO6 | NETIF_F_HIGHDMA;
+        dev->features |= dev->hw_features | NETIF_F_HW_VLAN_RX;
        if (bp->flags & USING_DAC_FLAG)
                dev->features |= NETIF_F_HIGHDMA;
-        dev->features |= (NETIF_F_TSO | NETIF_F_TSO_ECN);
-        dev->features |= NETIF_F_TSO6;
-        dev->features |= (NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX);
-        dev->vlan_features |= NETIF_F_SG;
+        /* Add Loopback capability to the device */
-        dev->vlan_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
+        dev->hw_features |= NETIF_F_LOOPBACK;
-        if (bp->flags & USING_DAC_FLAG)
-                dev->vlan_features |= NETIF_F_HIGHDMA;
-        dev->vlan_features |= (NETIF_F_TSO | NETIF_F_TSO_ECN);
-        dev->vlan_features |= NETIF_F_TSO6;
 #ifdef BCM_DCBNL
        dev->dcbnl_ops = &bnx2x_dcbnl_ops;
@@ -10342,6 +10173,11 @@ static int bnx2x_drv_ctl(struct net_device *dev, struct drv_ctl_info *ctl)
                break;
        }
+        case DRV_CTL_ISCSI_STOPPED_CMD: {
+                bnx2x_dcbx_set_params(bp, BNX2X_DCBX_STATE_ISCSI_STOPPED);
+                break;
+        }
        default:
                BNX2X_ERR("unknown command %x\n", ctl->cmd);
                rc = -EINVAL;
diff --git a/drivers/net/bnx2x/bnx2x_reg.h b/drivers/net/bnx2x/bnx2x_reg.h
index 1509a2318af9..86bba25d2d3f 100644
--- a/drivers/net/bnx2x/bnx2x_reg.h
+++ b/drivers/net/bnx2x/bnx2x_reg.h
@@ -1,6 +1,6 @@
 /* bnx2x_reg.h: Broadcom Everest network driver.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c
index 3445ded6674f..e535bfa08945 100644
--- a/drivers/net/bnx2x/bnx2x_stats.c
+++ b/drivers/net/bnx2x/bnx2x_stats.c
@@ -1,6 +1,6 @@
 /* bnx2x_stats.c: Broadcom Everest network driver.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
diff --git a/drivers/net/bnx2x/bnx2x_stats.h b/drivers/net/bnx2x/bnx2x_stats.h
index 596798c47452..45d14d8bc1aa 100644
--- a/drivers/net/bnx2x/bnx2x_stats.h
+++ b/drivers/net/bnx2x/bnx2x_stats.h
@@ -1,6 +1,6 @@
 /* bnx2x_stats.h: Broadcom Everest network driver.
 *
- * Copyright (c) 2007-2010 Broadcom Corporation
+ * Copyright (c) 2007-2011 Broadcom Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile
index 3c5c014e82b2..4c21bf6b8b2f 100644
--- a/drivers/net/bonding/Makefile
+++ b/drivers/net/bonding/Makefile
@@ -9,6 +9,3 @@ bonding-objs := bond_main.o bond_3ad.o bond_alb.o bond_sysfs.o bond_debugfs.o
 proc-$(CONFIG_PROC_FS) += bond_procfs.o
 bonding-objs += $(proc-y)
-ipv6-$(subst m,y,$(CONFIG_IPV6)) += bond_ipv6.o
-bonding-objs += $(ipv6-y)
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index 31912f17653f..c7537abca4f2 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -716,11 +716,9 @@ static void __set_agg_ports_ready(struct aggregator *aggregator, int val)
 static u32 __get_agg_bandwidth(struct aggregator *aggregator)
 {
        u32 bandwidth = 0;
-        u32 basic_speed;
        if (aggregator->num_of_ports) {
-                basic_speed = __get_link_speed(aggregator->lag_ports);
+                switch (__get_link_speed(aggregator->lag_ports)) {
-                switch (basic_speed) {
                case AD_LINK_SPEED_BITMASK_1MBPS:
                        bandwidth = aggregator->num_of_ports;
                        break;
@@ -2405,14 +2403,6 @@ int bond_3ad_xmit_xor(struct sk_buff *skb, struct net_device *dev)
        struct ad_info ad_info;
        int res = 1;
-        /* make sure that the slaves list will
-         * not change during tx
-         */
-        read_lock(&bond->lock);
-        if (!BOND_IS_OK(bond))
-                goto out;
        if (bond_3ad_get_active_agg_info(bond, &ad_info)) {
                pr_debug("%s: Error: bond_3ad_get_active_agg_info failed\n",
                         dev->name);
@@ -2466,39 +2456,20 @@ out:
                /* no suitable interface, frame not sent */
                dev_kfree_skb(skb);
        }
-        read_unlock(&bond->lock);
        return NETDEV_TX_OK;
 }
-int bond_3ad_lacpdu_recv(struct sk_buff *skb, struct net_device *dev, struct packet_type* ptype, struct net_device *orig_dev)
+void bond_3ad_lacpdu_recv(struct sk_buff *skb, struct bonding *bond,
+                          struct slave *slave)
 {
-        struct bonding *bond = netdev_priv(dev);
+        if (skb->protocol != PKT_TYPE_LACPDU)
-        struct slave *slave = NULL;
+                return;
-        int ret = NET_RX_DROP;
-        if (!(dev->flags & IFF_MASTER))
-                goto out;
-        skb = skb_share_check(skb, GFP_ATOMIC);
-        if (!skb)
-                goto out;
        if (!pskb_may_pull(skb, sizeof(struct lacpdu)))
-                goto out;
+                return;
        read_lock(&bond->lock);
-        slave = bond_get_slave_by_dev(netdev_priv(dev), orig_dev);
-        if (!slave)
-                goto out_unlock;
        bond_3ad_rx_indication((struct lacpdu *) skb->data, slave, skb->len);
-        ret = NET_RX_SUCCESS;
-out_unlock:
        read_unlock(&bond->lock);
-out:
-        dev_kfree_skb(skb);
-        return ret;
 }
diff --git a/drivers/net/bonding/bond_3ad.h b/drivers/net/bonding/bond_3ad.h
index 01b8a6af275b..0ee3f1632c46 100644
--- a/drivers/net/bonding/bond_3ad.h
+++ b/drivers/net/bonding/bond_3ad.h
@@ -258,7 +258,6 @@ struct ad_bond_info {
                                 * requested
                                 */
        struct timer_list ad_timer;
-        struct packet_type ad_pkt_type;
 };
 struct ad_slave_info {
@@ -280,7 +279,8 @@ void bond_3ad_adapter_duplex_changed(struct slave *slave);
 void bond_3ad_handle_link_change(struct slave *slave, char link);
 int  bond_3ad_get_active_agg_info(struct bonding *bond, struct ad_info *ad_info);
 int bond_3ad_xmit_xor(struct sk_buff *skb, struct net_device *dev);
-int bond_3ad_lacpdu_recv(struct sk_buff *skb, struct net_device *dev, struct packet_type* ptype, struct net_device *orig_dev);
+void bond_3ad_lacpdu_recv(struct sk_buff *skb, struct bonding *bond,
+                          struct slave *slave);
 int bond_3ad_set_carrier(struct bonding *bond);
 #endif //__BOND_3AD_H__
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index ba715826e2a8..8f2d2e7c70e5 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -308,49 +308,33 @@ static void rlb_update_entry_from_arp(struct bonding *bond, struct arp_pkt *arp)
        _unlock_rx_hashtbl(bond);
 }
-static int rlb_arp_recv(struct sk_buff *skb, struct net_device *bond_dev, struct packet_type *ptype, struct net_device *orig_dev)
+static void rlb_arp_recv(struct sk_buff *skb, struct bonding *bond,
+                         struct slave *slave)
 {
-        struct bonding *bond;
+        struct arp_pkt *arp;
-        struct arp_pkt *arp = (struct arp_pkt *)skb->data;
-        int res = NET_RX_DROP;
-        while (bond_dev->priv_flags & IFF_802_1Q_VLAN)
+        if (skb->protocol != cpu_to_be16(ETH_P_ARP))
-                bond_dev = vlan_dev_real_dev(bond_dev);
+                return;
-        if (!(bond_dev->priv_flags & IFF_BONDING) ||
-            !(bond_dev->flags & IFF_MASTER))
-                goto out;
+        arp = (struct arp_pkt *) skb->data;
        if (!arp) {
                pr_debug("Packet has no ARP data\n");
-                goto out;
+                return;
        }
-        skb = skb_share_check(skb, GFP_ATOMIC);
+        if (!pskb_may_pull(skb, arp_hdr_len(bond->dev)))
-        if (!skb)
+                return;
-                goto out;
-        if (!pskb_may_pull(skb, arp_hdr_len(bond_dev)))
-                goto out;
        if (skb->len < sizeof(struct arp_pkt)) {
                pr_debug("Packet is too small to be an ARP\n");
-                goto out;
+                return;
        }
        if (arp->op_code == htons(ARPOP_REPLY)) {
                /* update rx hash table for this ARP */
-                bond = netdev_priv(bond_dev);
                rlb_update_entry_from_arp(bond, arp);
                pr_debug("Server received an ARP Reply from client\n");
        }
-        res = NET_RX_SUCCESS;
-out:
-        dev_kfree_skb(skb);
-        return res;
 }
 /* Caller must hold bond lock for read */
@@ -759,7 +743,6 @@ static void rlb_init_table_entry(struct rlb_client_info *entry)
 static int rlb_initialize(struct bonding *bond)
 {
        struct alb_bond_info *bond_info = &(BOND_ALB_INFO(bond));
-        struct packet_type *pk_type = &(BOND_ALB_INFO(bond).rlb_pkt_type);
        struct rlb_client_info  *new_hashtbl;
        int size = RLB_HASH_TABLE_SIZE * sizeof(struct rlb_client_info);
        int i;
@@ -784,13 +767,8 @@ static int rlb_initialize(struct bonding *bond)
        _unlock_rx_hashtbl(bond);
-        /*initialize packet type*/
-        pk_type->type = cpu_to_be16(ETH_P_ARP);
-        pk_type->dev = bond->dev;
-        pk_type->func = rlb_arp_recv;
        /* register to receive ARPs */
-        dev_add_pack(pk_type);
+        bond->recv_probe = rlb_arp_recv;
        return 0;
 }
@@ -799,8 +777,6 @@ static void rlb_deinitialize(struct bonding *bond)
 {
        struct alb_bond_info *bond_info = &(BOND_ALB_INFO(bond));
-        dev_remove_pack(&(bond_info->rlb_pkt_type));
        _lock_rx_hashtbl(bond);
        kfree(bond_info->rx_hashtbl);
@@ -1249,16 +1225,10 @@ int bond_alb_xmit(struct sk_buff *skb, struct net_device *bond_dev)
        skb_reset_mac_header(skb);
        eth_data = eth_hdr(skb);
-        /* make sure that the curr_active_slave and the slaves list do
+        /* make sure that the curr_active_slave do not change during tx
-         * not change during tx
         */
-        read_lock(&bond->lock);
        read_lock(&bond->curr_slave_lock);
-        if (!BOND_IS_OK(bond)) {
-                goto out;
-        }
        switch (ntohs(skb->protocol)) {
        case ETH_P_IP: {
                const struct iphdr *iph = ip_hdr(skb);
@@ -1358,13 +1328,12 @@ int bond_alb_xmit(struct sk_buff *skb, struct net_device *bond_dev)
                }
        }
-out:
        if (res) {
                /* no suitable interface, frame not sent */
                dev_kfree_skb(skb);
        }
        read_unlock(&bond->curr_slave_lock);
-        read_unlock(&bond->lock);
        return NETDEV_TX_OK;
 }
diff --git a/drivers/net/bonding/bond_alb.h b/drivers/net/bonding/bond_alb.h
index 8ca7158b2dda..90f140a2d197 100644
--- a/drivers/net/bonding/bond_alb.h
+++ b/drivers/net/bonding/bond_alb.h
@@ -129,7 +129,6 @@ struct alb_bond_info {
        int                     lp_counter;
        /* -------- rlb parameters -------- */
        int rlb_enabled;
-        struct packet_type      rlb_pkt_type;
        struct rlb_client_info  *rx_hashtbl;    /* Receive hash table */
        spinlock_t              rx_hashtbl_lock;
        u32                     rx_hashtbl_head;
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 16d6fe954695..088fd845ffdf 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -89,8 +89,7 @@
 static int max_bonds    = BOND_DEFAULT_MAX_BONDS;
 static int tx_queues    = BOND_DEFAULT_TX_QUEUES;
-static int num_grat_arp = 1;
+static int num_peer_notif = 1;
-static int num_unsol_na = 1;
 static int miimon       = BOND_LINK_MON_INTERV;
 static int updelay;
 static int downdelay;
@@ -113,10 +112,10 @@ module_param(max_bonds, int, 0);
 MODULE_PARM_DESC(max_bonds, "Max number of bonded devices");
 module_param(tx_queues, int, 0);
 MODULE_PARM_DESC(tx_queues, "Max number of transmit queues (default = 16)");
-module_param(num_grat_arp, int, 0644);
+module_param_named(num_grat_arp, num_peer_notif, int, 0644);
-MODULE_PARM_DESC(num_grat_arp, "Number of gratuitous ARP packets to send on failover event");
+MODULE_PARM_DESC(num_grat_arp, "Number of peer notifications to send on failover event (alias of num_unsol_na)");
-module_param(num_unsol_na, int, 0644);
+module_param_named(num_unsol_na, num_peer_notif, int, 0644);
-MODULE_PARM_DESC(num_unsol_na, "Number of unsolicited IPv6 Neighbor Advertisements packets to send on failover event");
+MODULE_PARM_DESC(num_unsol_na, "Number of peer notifications to send on failover event (alias of num_grat_arp)");
 module_param(miimon, int, 0);
 MODULE_PARM_DESC(miimon, "Link check interval in milliseconds");
 module_param(updelay, int, 0);
@@ -234,7 +233,6 @@ struct bond_parm_tbl ad_select_tbl[] = {
 /*-------------------------- Forward declarations ---------------------------*/
-static void bond_send_gratuitous_arp(struct bonding *bond);
 static int bond_init(struct net_device *bond_dev);
 static void bond_uninit(struct net_device *bond_dev);
@@ -346,32 +344,6 @@ out:
 }
 /**
- * bond_has_challenged_slaves
- * @bond: the bond we're working on
- *
- * Searches the slave list. Returns 1 if a vlan challenged slave
- * was found, 0 otherwise.
- *
- * Assumes bond->lock is held.
- */
-static int bond_has_challenged_slaves(struct bonding *bond)
-{
-        struct slave *slave;
-        int i;
-        bond_for_each_slave(bond, slave, i) {
-                if (slave->dev->features & NETIF_F_VLAN_CHALLENGED) {
-                        pr_debug("found VLAN challenged slave - %s\n",
-                                 slave->dev->name);
-                        return 1;
-                }
-        }
-        pr_debug("no VLAN challenged slaves found\n");
-        return 0;
-}
-/**
 * bond_next_vlan - safely skip to the next item in the vlans list.
 * @bond: the bond we're working on
 * @curr: item we're advancing from
@@ -631,7 +603,8 @@ down:
 static int bond_update_speed_duplex(struct slave *slave)
 {
        struct net_device *slave_dev = slave->dev;
-        struct ethtool_cmd etool;
+        struct ethtool_cmd etool = { .cmd = ETHTOOL_GSET };
+        u32 slave_speed;
        int res;
        /* Fake speed and duplex */
@@ -645,7 +618,8 @@ static int bond_update_speed_duplex(struct slave *slave)
        if (res < 0)
                return -1;
-        switch (etool.speed) {
+        slave_speed = ethtool_cmd_speed(&etool);
+        switch (slave_speed) {
        case SPEED_10:
        case SPEED_100:
        case SPEED_1000:
@@ -663,7 +637,7 @@ static int bond_update_speed_duplex(struct slave *slave)
                return -1;
        }
-        slave->speed = etool.speed;
+        slave->speed = slave_speed;
        slave->duplex = etool.duplex;
        return 0;
@@ -1087,6 +1061,21 @@ static struct slave *bond_find_best_slave(struct bonding *bond)
        return bestslave;
 }
+static bool bond_should_notify_peers(struct bonding *bond)
+{
+        struct slave *slave = bond->curr_active_slave;
+        pr_debug("bond_should_notify_peers: bond %s slave %s\n",
+                 bond->dev->name, slave ? slave->dev->name : "NULL");
+        if (!slave || !bond->send_peer_notif ||
+            test_bit(__LINK_STATE_LINKWATCH_PENDING, &slave->dev->state))
+                return false;
+        bond->send_peer_notif--;
+        return true;
+}
 /**
 * change_active_interface - change the active slave into the specified one
 * @bond: our bonding struct
@@ -1154,6 +1143,8 @@ void bond_change_active_slave(struct bonding *bond, struct slave *new_active)
                        bond_set_slave_inactive_flags(old_active);
                if (new_active) {
+                        bool should_notify_peers = false;
                        bond_set_slave_active_flags(new_active);
                        if (bond->params.fail_over_mac)
@@ -1161,17 +1152,19 @@ void bond_change_active_slave(struct bonding *bond, struct slave *new_active)
                                                      old_active);
                        if (netif_running(bond->dev)) {
-                                bond->send_grat_arp = bond->params.num_grat_arp;
+                                bond->send_peer_notif =
-                                bond_send_gratuitous_arp(bond);
+                                        bond->params.num_peer_notif;
+                                should_notify_peers =
-                                bond->send_unsol_na = bond->params.num_unsol_na;
+                                        bond_should_notify_peers(bond);
-                                bond_send_unsolicited_na(bond);
                        }
                        write_unlock_bh(&bond->curr_slave_lock);
                        read_unlock(&bond->lock);
                        netdev_bonding_change(bond->dev, NETDEV_BONDING_FAILOVER);
+                        if (should_notify_peers)
+                                netdev_bonding_change(bond->dev,
+                                                      NETDEV_NOTIFY_PEERS);
                        read_lock(&bond->lock);
                        write_lock_bh(&bond->curr_slave_lock);
@@ -1387,52 +1380,68 @@ static int bond_sethwaddr(struct net_device *bond_dev,
        return 0;
 }
-#define BOND_VLAN_FEATURES \
+static u32 bond_fix_features(struct net_device *dev, u32 features)
-        (NETIF_F_VLAN_CHALLENGED | NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_TX | \
-         NETIF_F_HW_VLAN_FILTER)
-/*
- * Compute the common dev->feature set available to all slaves.  Some
- * feature bits are managed elsewhere, so preserve those feature bits
- * on the master device.
- */
-static int bond_compute_features(struct bonding *bond)
 {
        struct slave *slave;
-        struct net_device *bond_dev = bond->dev;
+        struct bonding *bond = netdev_priv(dev);
-        u32 features = bond_dev->features;
+        u32 mask;
-        u32 vlan_features = 0;
-        unsigned short max_hard_header_len = max((u16)ETH_HLEN,
-                                                bond_dev->hard_header_len);
        int i;
-        features &= ~(NETIF_F_ALL_CSUM | BOND_VLAN_FEATURES);
+        read_lock(&bond->lock);
-        features |=  NETIF_F_GSO_MASK | NETIF_F_NO_CSUM;
-        if (!bond->first_slave)
+        if (!bond->first_slave) {
-                goto done;
+                /* Disable adding VLANs to empty bond. But why? --mq */
+                features |= NETIF_F_VLAN_CHALLENGED;
+                goto out;
+        }
+        mask = features;
        features &= ~NETIF_F_ONE_FOR_ALL;
+        features |= NETIF_F_ALL_FOR_ALL;
-        vlan_features = bond->first_slave->dev->vlan_features;
        bond_for_each_slave(bond, slave, i) {
                features = netdev_increment_features(features,
                                                     slave->dev->features,
-                                                     NETIF_F_ONE_FOR_ALL);
+                                                     mask);
+        }
+out:
+        read_unlock(&bond->lock);
+        return features;
+}
+#define BOND_VLAN_FEATURES      (NETIF_F_ALL_TX_OFFLOADS | \
+                                 NETIF_F_SOFT_FEATURES | \
+                                 NETIF_F_LRO)
+static void bond_compute_features(struct bonding *bond)
+{
+        struct slave *slave;
+        struct net_device *bond_dev = bond->dev;
+        u32 vlan_features = BOND_VLAN_FEATURES;
+        unsigned short max_hard_header_len = ETH_HLEN;
+        int i;
+        read_lock(&bond->lock);
+        if (!bond->first_slave)
+                goto done;
+        bond_for_each_slave(bond, slave, i) {
                vlan_features = netdev_increment_features(vlan_features,
-                                                        slave->dev->vlan_features,
+                        slave->dev->vlan_features, BOND_VLAN_FEATURES);
-                                                        NETIF_F_ONE_FOR_ALL);
                if (slave->dev->hard_header_len > max_hard_header_len)
                        max_hard_header_len = slave->dev->hard_header_len;
        }
 done:
-        features |= (bond_dev->features & BOND_VLAN_FEATURES);
+        bond_dev->vlan_features = vlan_features;
-        bond_dev->features = netdev_fix_features(bond_dev, features);
-        bond_dev->vlan_features = netdev_fix_features(bond_dev, vlan_features);
        bond_dev->hard_header_len = max_hard_header_len;
-        return 0;
+        read_unlock(&bond->lock);
+        netdev_change_features(bond_dev);
 }
 static void bond_setup_by_slave(struct net_device *bond_dev,
@@ -1452,27 +1461,17 @@ static void bond_setup_by_slave(struct net_device *bond_dev,
 }
 /* On bonding slaves other than the currently active slave, suppress
- * duplicates except for 802.3ad ETH_P_SLOW, alb non-mcast/bcast, and
+ * duplicates except for alb non-mcast/bcast.
- * ARP on active-backup slaves with arp_validate enabled.
 */
 static bool bond_should_deliver_exact_match(struct sk_buff *skb,
                                            struct slave *slave,
                                            struct bonding *bond)
 {
        if (bond_is_slave_inactive(slave)) {
-                if (slave_do_arp_validate(bond, slave) &&
-                    skb->protocol == __cpu_to_be16(ETH_P_ARP))
-                        return false;
                if (bond->params.mode == BOND_MODE_ALB &&
                    skb->pkt_type != PACKET_BROADCAST &&
                    skb->pkt_type != PACKET_MULTICAST)
-                                return false;
-                if (bond->params.mode == BOND_MODE_8023AD &&
-                    skb->protocol == __cpu_to_be16(ETH_P_SLOW))
                        return false;
                return true;
        }
        return false;
@@ -1496,6 +1495,15 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
        if (bond->params.arp_interval)
                slave->dev->last_rx = jiffies;
+        if (bond->recv_probe) {
+                struct sk_buff *nskb = skb_clone(skb, GFP_ATOMIC);
+                if (likely(nskb)) {
+                        bond->recv_probe(nskb, bond, slave);
+                        dev_kfree_skb(nskb);
+                }
+        }
        if (bond_should_deliver_exact_match(skb, slave, bond)) {
                return RX_HANDLER_EXACT;
        }
@@ -1526,7 +1534,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
        struct netdev_hw_addr *ha;
        struct sockaddr addr;
        int link_reporting;
-        int old_features = bond_dev->features;
        int res = 0;
        if (!bond->params.use_carrier && slave_dev->ethtool_ops == NULL &&
@@ -1559,16 +1566,9 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
                        pr_warning("%s: Warning: enslaved VLAN challenged slave %s. Adding VLANs will be blocked as long as %s is part of bond %s\n",
                                   bond_dev->name, slave_dev->name,
                                   slave_dev->name, bond_dev->name);
-                        bond_dev->features |= NETIF_F_VLAN_CHALLENGED;
                }
        } else {
                pr_debug("%s: ! NETIF_F_VLAN_CHALLENGED\n", slave_dev->name);
-                if (bond->slave_cnt == 0) {
-                        /* First slave, and it is not VLAN challenged,
-                         * so remove the block of adding VLANs over the bond.
-                         */
-                        bond_dev->features &= ~NETIF_F_VLAN_CHALLENGED;
-                }
        }
        /*
@@ -1757,10 +1757,10 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
        new_slave->delay = 0;
        new_slave->link_failure_count = 0;
-        bond_compute_features(bond);
        write_unlock_bh(&bond->lock);
+        bond_compute_features(bond);
        read_lock(&bond->lock);
        new_slave->last_arp_rx = jiffies;
@@ -1940,7 +1940,7 @@ err_free:
        kfree(new_slave);
 err_undo_flags:
-        bond_dev->features = old_features;
+        bond_compute_features(bond);
        return res;
 }
@@ -1961,6 +1961,7 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
        struct bonding *bond = netdev_priv(bond_dev);
        struct slave *slave, *oldcurrent;
        struct sockaddr addr;
+        u32 old_features = bond_dev->features;
        /* slave is not a slave or master is not master of this slave */
        if (!(slave_dev->flags & IFF_SLAVE) ||
@@ -2021,8 +2022,6 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
        /* release the slave from its bond */
        bond_detach_slave(bond, slave);
-        bond_compute_features(bond);
        if (bond->primary_slave == slave)
                bond->primary_slave = NULL;
@@ -2066,24 +2065,23 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
                 */
                memset(bond_dev->dev_addr, 0, bond_dev->addr_len);
-                if (!bond->vlgrp) {
+                if (bond->vlgrp) {
-                        bond_dev->features |= NETIF_F_VLAN_CHALLENGED;
-                } else {
                        pr_warning("%s: Warning: clearing HW address of %s while it still has VLANs.\n",
                                   bond_dev->name, bond_dev->name);
                        pr_warning("%s: When re-adding slaves, make sure the bond's HW address matches its VLANs'.\n",
                                   bond_dev->name);
                }
-        } else if ((bond_dev->features & NETIF_F_VLAN_CHALLENGED) &&
-                   !bond_has_challenged_slaves(bond)) {
-                pr_info("%s: last VLAN challenged slave %s left bond %s. VLAN blocking is removed\n",
-                        bond_dev->name, slave_dev->name, bond_dev->name);
-                bond_dev->features &= ~NETIF_F_VLAN_CHALLENGED;
        }
        write_unlock_bh(&bond->lock);
        unblock_netpoll_tx();
+        bond_compute_features(bond);
+        if (!(bond_dev->features & NETIF_F_VLAN_CHALLENGED) &&
+            (old_features & NETIF_F_VLAN_CHALLENGED))
+                pr_info("%s: last VLAN challenged slave %s left bond %s. VLAN blocking is removed\n",
+                        bond_dev->name, slave_dev->name, bond_dev->name);
        /* must do this from outside any spinlocks */
        bond_destroy_slave_symlinks(bond_dev, slave_dev);
@@ -2201,8 +2199,6 @@ static int bond_release_all(struct net_device *bond_dev)
                        bond_alb_deinit_slave(bond, slave);
                }
-                bond_compute_features(bond);
                bond_destroy_slave_symlinks(bond_dev, slave_dev);
                bond_del_vlans_from_slave(bond, slave_dev);
@@ -2251,9 +2247,7 @@ static int bond_release_all(struct net_device *bond_dev)
         */
        memset(bond_dev->dev_addr, 0, bond_dev->addr_len);
-        if (!bond->vlgrp) {
+        if (bond->vlgrp) {
-                bond_dev->features |= NETIF_F_VLAN_CHALLENGED;
-        } else {
                pr_warning("%s: Warning: clearing HW address of %s while it still has VLANs.\n",
                           bond_dev->name, bond_dev->name);
                pr_warning("%s: When re-adding slaves, make sure the bond's HW address matches its VLANs'.\n",
@@ -2264,6 +2258,9 @@ static int bond_release_all(struct net_device *bond_dev)
 out:
        write_unlock_bh(&bond->lock);
+        bond_compute_features(bond);
        return 0;
 }
@@ -2493,7 +2490,7 @@ static void bond_miimon_commit(struct bonding *bond)
                        bond_update_speed_duplex(slave);
-                        pr_info("%s: link status definitely up for interface %s, %d Mbps %s duplex.\n",
+                        pr_info("%s: link status definitely up for interface %s, %u Mbps %s duplex.\n",
                                bond->dev->name, slave->dev->name,
                                slave->speed, slave->duplex ? "full" : "half");
@@ -2570,6 +2567,7 @@ void bond_mii_monitor(struct work_struct *work)
 {
        struct bonding *bond = container_of(work, struct bonding,
                                            mii_work.work);
+        bool should_notify_peers = false;
        read_lock(&bond->lock);
        if (bond->kill_timers)
@@ -2578,17 +2576,7 @@ void bond_mii_monitor(struct work_struct *work)
        if (bond->slave_cnt == 0)
                goto re_arm;
-        if (bond->send_grat_arp) {
+        should_notify_peers = bond_should_notify_peers(bond);
-                read_lock(&bond->curr_slave_lock);
-                bond_send_gratuitous_arp(bond);
-                read_unlock(&bond->curr_slave_lock);
-        }
-        if (bond->send_unsol_na) {
-                read_lock(&bond->curr_slave_lock);
-                bond_send_unsolicited_na(bond);
-                read_unlock(&bond->curr_slave_lock);
-        }
        if (bond_miimon_inspect(bond)) {
                read_unlock(&bond->lock);
@@ -2608,6 +2596,12 @@ re_arm:
                                   msecs_to_jiffies(bond->params.miimon));
 out:
        read_unlock(&bond->lock);
+        if (should_notify_peers) {
+                rtnl_lock();
+                netdev_bonding_change(bond->dev, NETDEV_NOTIFY_PEERS);
+                rtnl_unlock();
+        }
 }
 static __be32 bond_glean_dev_ip(struct net_device *dev)
@@ -2751,44 +2745,6 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
        }
 }
-/*
- * Kick out a gratuitous ARP for an IP on the bonding master plus one
- * for each VLAN above us.
- *
- * Caller must hold curr_slave_lock for read or better
- */
-static void bond_send_gratuitous_arp(struct bonding *bond)
-{
-        struct slave *slave = bond->curr_active_slave;
-        struct vlan_entry *vlan;
-        struct net_device *vlan_dev;
-        pr_debug("bond_send_grat_arp: bond %s slave %s\n",
-                 bond->dev->name, slave ? slave->dev->name : "NULL");
-        if (!slave || !bond->send_grat_arp ||
-            test_bit(__LINK_STATE_LINKWATCH_PENDING, &slave->dev->state))
-                return;
-        bond->send_grat_arp--;
-        if (bond->master_ip) {
-                bond_arp_send(slave->dev, ARPOP_REPLY, bond->master_ip,
-                                bond->master_ip, 0);
-        }
-        if (!bond->vlgrp)
-                return;
-        list_for_each_entry(vlan, &bond->vlan_list, vlan_list) {
-                vlan_dev = vlan_group_get_device(bond->vlgrp, vlan->vlan_id);
-                if (vlan->vlan_ip) {
-                        bond_arp_send(slave->dev, ARPOP_REPLY, vlan->vlan_ip,
-                                      vlan->vlan_ip, vlan->vlan_id);
-                }
-        }
-}
 static void bond_validate_arp(struct bonding *bond, struct slave *slave, __be32 sip, __be32 tip)
 {
        int i;
@@ -2806,48 +2762,26 @@ static void bond_validate_arp(struct bonding *bond, struct slave *slave, __be32
        }
 }
-static int bond_arp_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt, struct net_device *orig_dev)
+static void bond_arp_rcv(struct sk_buff *skb, struct bonding *bond,
+                         struct slave *slave)
 {
        struct arphdr *arp;
-        struct slave *slave;
-        struct bonding *bond;
        unsigned char *arp_ptr;
        __be32 sip, tip;
-        if (dev->priv_flags & IFF_802_1Q_VLAN) {
+        if (skb->protocol != __cpu_to_be16(ETH_P_ARP))
-                /*
+                return;
-                 * When using VLANS and bonding, dev and oriv_dev may be
-                 * incorrect if the physical interface supports VLAN
-                 * acceleration.  With this change ARP validation now
-                 * works for hosts only reachable on the VLAN interface.
-                 */
-                dev = vlan_dev_real_dev(dev);
-                orig_dev = dev_get_by_index_rcu(dev_net(skb->dev),skb->skb_iif);
-        }
-        if (!(dev->priv_flags & IFF_BONDING) || !(dev->flags & IFF_MASTER))
-                goto out;
-        bond = netdev_priv(dev);
        read_lock(&bond->lock);
-        pr_debug("bond_arp_rcv: bond %s skb->dev %s orig_dev %s\n",
+        pr_debug("bond_arp_rcv: bond %s skb->dev %s\n",
-                 bond->dev->name, skb->dev ? skb->dev->name : "NULL",
+                 bond->dev->name, skb->dev->name);
-                 orig_dev ? orig_dev->name : "NULL");
-        slave = bond_get_slave_by_dev(bond, orig_dev);
-        if (!slave || !slave_do_arp_validate(bond, slave))
-                goto out_unlock;
-        skb = skb_share_check(skb, GFP_ATOMIC);
-        if (!skb)
-                goto out_unlock;
-        if (!pskb_may_pull(skb, arp_hdr_len(dev)))
+        if (!pskb_may_pull(skb, arp_hdr_len(bond->dev)))
                goto out_unlock;
        arp = arp_hdr(skb);
-        if (arp->ar_hln != dev->addr_len ||
+        if (arp->ar_hln != bond->dev->addr_len ||
            skb->pkt_type == PACKET_OTHERHOST ||
            skb->pkt_type == PACKET_LOOPBACK ||
            arp->ar_hrd != htons(ARPHRD_ETHER) ||
@@ -2856,9 +2790,9 @@ static int bond_arp_rcv(struct sk_buff *skb, struct net_device *dev, struct pack
                goto out_unlock;
        arp_ptr = (unsigned char *)(arp + 1);
-        arp_ptr += dev->addr_len;
+        arp_ptr += bond->dev->addr_len;
        memcpy(&sip, arp_ptr, 4);
-        arp_ptr += 4 + dev->addr_len;
+        arp_ptr += 4 + bond->dev->addr_len;
        memcpy(&tip, arp_ptr, 4);
        pr_debug("bond_arp_rcv: %s %s/%d av %d sv %d sip %pI4 tip %pI4\n",
@@ -2881,9 +2815,6 @@ static int bond_arp_rcv(struct sk_buff *skb, struct net_device *dev, struct pack
 out_unlock:
        read_unlock(&bond->lock);
-out:
-        dev_kfree_skb(skb);
-        return NET_RX_SUCCESS;
 }
 /*
@@ -3243,6 +3174,7 @@ void bond_activebackup_arp_mon(struct work_struct *work)
 {
        struct bonding *bond = container_of(work, struct bonding,
                                            arp_work.work);
+        bool should_notify_peers = false;
        int delta_in_ticks;
        read_lock(&bond->lock);
@@ -3255,17 +3187,7 @@ void bond_activebackup_arp_mon(struct work_struct *work)
        if (bond->slave_cnt == 0)
                goto re_arm;
-        if (bond->send_grat_arp) {
+        should_notify_peers = bond_should_notify_peers(bond);
-                read_lock(&bond->curr_slave_lock);
-                bond_send_gratuitous_arp(bond);
-                read_unlock(&bond->curr_slave_lock);
-        }
-        if (bond->send_unsol_na) {
-                read_lock(&bond->curr_slave_lock);
-                bond_send_unsolicited_na(bond);
-                read_unlock(&bond->curr_slave_lock);
-        }
        if (bond_ab_arp_inspect(bond, delta_in_ticks)) {
                read_unlock(&bond->lock);
@@ -3286,6 +3208,12 @@ re_arm:
                queue_delayed_work(bond->wq, &bond->arp_work, delta_in_ticks);
 out:
        read_unlock(&bond->lock);
+        if (should_notify_peers) {
+                rtnl_lock();
+                netdev_bonding_change(bond->dev, NETDEV_NOTIFY_PEERS);
+                rtnl_unlock();
+        }
 }
 /*-------------------------- netdev event handling --------------------------*/
@@ -3339,8 +3267,8 @@ static int bond_slave_netdev_event(unsigned long event,
                        slave = bond_get_slave_by_dev(bond, slave_dev);
                        if (slave) {
-                                u16 old_speed = slave->speed;
+                                u32 old_speed = slave->speed;
-                                u16 old_duplex = slave->duplex;
+                                u8  old_duplex = slave->duplex;
                                bond_update_speed_duplex(slave);
@@ -3482,48 +3410,6 @@ static struct notifier_block bond_inetaddr_notifier = {
        .notifier_call = bond_inetaddr_event,
 };
-/*-------------------------- Packet type handling ---------------------------*/
-/* register to receive lacpdus on a bond */
-static void bond_register_lacpdu(struct bonding *bond)
-{
-        struct packet_type *pk_type = &(BOND_AD_INFO(bond).ad_pkt_type);
-        /* initialize packet type */
-        pk_type->type = PKT_TYPE_LACPDU;
-        pk_type->dev = bond->dev;
-        pk_type->func = bond_3ad_lacpdu_recv;
-        dev_add_pack(pk_type);
-}
-/* unregister to receive lacpdus on a bond */
-static void bond_unregister_lacpdu(struct bonding *bond)
-{
-        dev_remove_pack(&(BOND_AD_INFO(bond).ad_pkt_type));
-}
-void bond_register_arp(struct bonding *bond)
-{
-        struct packet_type *pt = &bond->arp_mon_pt;
-        if (pt->type)
-                return;
-        pt->type = htons(ETH_P_ARP);
-        pt->dev = bond->dev;
-        pt->func = bond_arp_rcv;
-        dev_add_pack(pt);
-}
-void bond_unregister_arp(struct bonding *bond)
-{
-        struct packet_type *pt = &bond->arp_mon_pt;
-        dev_remove_pack(pt);
-        pt->type = 0;
-}
 /*---------------------------- Hashing Policies -----------------------------*/
 /*
@@ -3617,14 +3503,14 @@ static int bond_open(struct net_device *bond_dev)
                queue_delayed_work(bond->wq, &bond->arp_work, 0);
                if (bond->params.arp_validate)
-                        bond_register_arp(bond);
+                        bond->recv_probe = bond_arp_rcv;
        }
        if (bond->params.mode == BOND_MODE_8023AD) {
                INIT_DELAYED_WORK(&bond->ad_work, bond_3ad_state_machine_handler);
                queue_delayed_work(bond->wq, &bond->ad_work, 0);
                /* register to receive LACPDUs */
-                bond_register_lacpdu(bond);
+                bond->recv_probe = bond_3ad_lacpdu_recv;
                bond_3ad_initiate_agg_selection(bond, 1);
        }
@@ -3635,18 +3521,9 @@ static int bond_close(struct net_device *bond_dev)
 {
        struct bonding *bond = netdev_priv(bond_dev);
-        if (bond->params.mode == BOND_MODE_8023AD) {
-                /* Unregister the receive of LACPDUs */
-                bond_unregister_lacpdu(bond);
-        }
-        if (bond->params.arp_validate)
-                bond_unregister_arp(bond);
        write_lock_bh(&bond->lock);
-        bond->send_grat_arp = 0;
+        bond->send_peer_notif = 0;
-        bond->send_unsol_na = 0;
        /* signal timers not to re-arm */
        bond->kill_timers = 1;
@@ -3682,6 +3559,7 @@ static int bond_close(struct net_device *bond_dev)
                 */
                bond_alb_deinitialize(bond);
        }
+        bond->recv_probe = NULL;
        return 0;
 }
@@ -4105,10 +3983,6 @@ static int bond_xmit_roundrobin(struct sk_buff *skb, struct net_device *bond_dev
        int i, slave_no, res = 1;
        struct iphdr *iph = ip_hdr(skb);
-        read_lock(&bond->lock);
-        if (!BOND_IS_OK(bond))
-                goto out;
        /*
         * Start with the curr_active_slave that joined the bond as the
         * default for sending IGMP traffic.  For failover purposes one
@@ -4155,7 +4029,7 @@ out:
                /* no suitable interface, frame not sent */
                dev_kfree_skb(skb);
        }
-        read_unlock(&bond->lock);
        return NETDEV_TX_OK;
 }
@@ -4169,24 +4043,18 @@ static int bond_xmit_activebackup(struct sk_buff *skb, struct net_device *bond_d
        struct bonding *bond = netdev_priv(bond_dev);
        int res = 1;
-        read_lock(&bond->lock);
        read_lock(&bond->curr_slave_lock);
-        if (!BOND_IS_OK(bond))
+        if (bond->curr_active_slave)
-                goto out;
+                res = bond_dev_queue_xmit(bond, skb,
+                        bond->curr_active_slave->dev);
-        if (!bond->curr_active_slave)
-                goto out;
-        res = bond_dev_queue_xmit(bond, skb, bond->curr_active_slave->dev);
-out:
        if (res)
                /* no suitable interface, frame not sent */
                dev_kfree_skb(skb);
        read_unlock(&bond->curr_slave_lock);
-        read_unlock(&bond->lock);
        return NETDEV_TX_OK;
 }
@@ -4203,11 +4071,6 @@ static int bond_xmit_xor(struct sk_buff *skb, struct net_device *bond_dev)
        int i;
        int res = 1;
-        read_lock(&bond->lock);
-        if (!BOND_IS_OK(bond))
-                goto out;
        slave_no = bond->xmit_hash_policy(skb, bond->slave_cnt);
        bond_for_each_slave(bond, slave, i) {
@@ -4227,12 +4090,11 @@ static int bond_xmit_xor(struct sk_buff *skb, struct net_device *bond_dev)
                }
        }
-out:
        if (res) {
                /* no suitable interface, frame not sent */
                dev_kfree_skb(skb);
        }
-        read_unlock(&bond->lock);
        return NETDEV_TX_OK;
 }
@@ -4247,11 +4109,6 @@ static int bond_xmit_broadcast(struct sk_buff *skb, struct net_device *bond_dev)
        int i;
        int res = 1;
-        read_lock(&bond->lock);
-        if (!BOND_IS_OK(bond))
-                goto out;
        read_lock(&bond->curr_slave_lock);
        start_at = bond->curr_active_slave;
        read_unlock(&bond->curr_slave_lock);
@@ -4290,7 +4147,6 @@ out:
                dev_kfree_skb(skb);
        /* frame sent to all suitable interfaces */
-        read_unlock(&bond->lock);
        return NETDEV_TX_OK;
 }
@@ -4322,10 +4178,8 @@ static inline int bond_slave_override(struct bonding *bond,
        struct slave *slave = NULL;
        struct slave *check_slave;
-        read_lock(&bond->lock);
+        if (!skb->queue_mapping)
+                return 1;
-        if (!BOND_IS_OK(bond) || !skb->queue_mapping)
-                goto out;
        /* Find out if any slaves have the same mapping as this skb. */
        bond_for_each_slave(bond, check_slave, i) {
@@ -4341,8 +4195,6 @@ static inline int bond_slave_override(struct bonding *bond,
                res = bond_dev_queue_xmit(bond, skb, slave->dev);
        }
-out:
-        read_unlock(&bond->lock);
        return res;
 }
@@ -4357,24 +4209,17 @@ static u16 bond_select_queue(struct net_device *dev, struct sk_buff *skb)
        u16 txq = skb_rx_queue_recorded(skb) ? skb_get_rx_queue(skb) : 0;
        if (unlikely(txq >= dev->real_num_tx_queues)) {
-                do
+                do {
                        txq -= dev->real_num_tx_queues;
-                while (txq >= dev->real_num_tx_queues);
+                } while (txq >= dev->real_num_tx_queues);
        }
        return txq;
 }
-static netdev_tx_t bond_start_xmit(struct sk_buff *skb, struct net_device *dev)
+static netdev_tx_t __bond_start_xmit(struct sk_buff *skb, struct net_device *dev)
 {
        struct bonding *bond = netdev_priv(dev);
-        /*
-         * If we risk deadlock from transmitting this in the
-         * netpoll path, tell netpoll to queue the frame for later tx
-         */
-        if (is_netpoll_tx_blocked(dev))
-                return NETDEV_TX_BUSY;
        if (TX_QUEUE_OVERRIDE(bond->params.mode)) {
                if (!bond_slave_override(bond, skb))
                        return NETDEV_TX_OK;
@@ -4404,6 +4249,29 @@ static netdev_tx_t bond_start_xmit(struct sk_buff *skb, struct net_device *dev)
        }
 }
+static netdev_tx_t bond_start_xmit(struct sk_buff *skb, struct net_device *dev)
+{
+        struct bonding *bond = netdev_priv(dev);
+        netdev_tx_t ret = NETDEV_TX_OK;
+        /*
+         * If we risk deadlock from transmitting this in the
+         * netpoll path, tell netpoll to queue the frame for later tx
+         */
+        if (is_netpoll_tx_blocked(dev))
+                return NETDEV_TX_BUSY;
+        read_lock(&bond->lock);
+        if (bond->slave_cnt)
+                ret = __bond_start_xmit(skb, dev);
+        else
+                dev_kfree_skb(skb);
+        read_unlock(&bond->lock);
+        return ret;
+}
 /*
 * set bond mode specific net device operations
@@ -4448,11 +4316,6 @@ static void bond_ethtool_get_drvinfo(struct net_device *bond_dev,
 static const struct ethtool_ops bond_ethtool_ops = {
        .get_drvinfo            = bond_ethtool_get_drvinfo,
        .get_link               = ethtool_op_get_link,
-        .get_tx_csum            = ethtool_op_get_tx_csum,
-        .get_sg                 = ethtool_op_get_sg,
-        .get_tso                = ethtool_op_get_tso,
-        .get_ufo                = ethtool_op_get_ufo,
-        .get_flags              = ethtool_op_get_flags,
 };
 static const struct net_device_ops bond_netdev_ops = {
@@ -4478,6 +4341,7 @@ static const struct net_device_ops bond_netdev_ops = {
 #endif
        .ndo_add_slave          = bond_enslave,
        .ndo_del_slave          = bond_release,
+        .ndo_fix_features       = bond_fix_features,
 };
 static void bond_destructor(struct net_device *bond_dev)
@@ -4533,14 +4397,14 @@ static void bond_setup(struct net_device *bond_dev)
         * when there are slaves that are not hw accel
         * capable
         */
-        bond_dev->features |= (NETIF_F_HW_VLAN_TX |
-                               NETIF_F_HW_VLAN_RX |
-                               NETIF_F_HW_VLAN_FILTER);
-        /* By default, we enable GRO on bonding devices.
+        bond_dev->hw_features = BOND_VLAN_FEATURES |
-         * Actual support requires lowlevel drivers are GRO ready.
+                                NETIF_F_HW_VLAN_TX |
-         */
+                                NETIF_F_HW_VLAN_RX |
-        bond_dev->features |= NETIF_F_GRO;
+                                NETIF_F_HW_VLAN_FILTER;
+        bond_dev->hw_features &= ~(NETIF_F_ALL_CSUM & ~NETIF_F_NO_CSUM);
+        bond_dev->features |= bond_dev->hw_features;
 }
 static void bond_work_cancel_all(struct bonding *bond)
@@ -4724,16 +4588,10 @@ static int bond_check_params(struct bond_params *params)
                use_carrier = 1;
        }
-        if (num_grat_arp < 0 || num_grat_arp > 255) {
+        if (num_peer_notif < 0 || num_peer_notif > 255) {
-                pr_warning("Warning: num_grat_arp (%d) not in range 0-255 so it was reset to 1\n",
+                pr_warning("Warning: num_grat_arp/num_unsol_na (%d) not in range 0-255 so it was reset to 1\n",
-                           num_grat_arp);
+                           num_peer_notif);
-                num_grat_arp = 1;
+                num_peer_notif = 1;
-        }
-        if (num_unsol_na < 0 || num_unsol_na > 255) {
-                pr_warning("Warning: num_unsol_na (%d) not in range 0-255 so it was reset to 1\n",
-                           num_unsol_na);
-                num_unsol_na = 1;
        }
        /* reset values for 802.3ad */
@@ -4925,8 +4783,7 @@ static int bond_check_params(struct bond_params *params)
        params->mode = bond_mode;
        params->xmit_policy = xmit_hashtype;
        params->miimon = miimon;
-        params->num_grat_arp = num_grat_arp;
+        params->num_peer_notif = num_peer_notif;
-        params->num_unsol_na = num_unsol_na;
        params->arp_interval = arp_interval;
        params->arp_validate = arp_validate_value;
        params->updelay = updelay;
@@ -5025,8 +4882,9 @@ int bond_create(struct net *net, const char *name)
        rtnl_lock();
-        bond_dev = alloc_netdev_mq(sizeof(struct bonding), name ? name : "",
+        bond_dev = alloc_netdev_mq(sizeof(struct bonding),
-                                bond_setup, tx_queues);
+                                   name ? name : "bond%d",
+                                   bond_setup, tx_queues);
        if (!bond_dev) {
                pr_err("%s: eek! can't alloc netdev!\n", name);
                rtnl_unlock();
@@ -5036,26 +4894,10 @@ int bond_create(struct net *net, const char *name)
        dev_net_set(bond_dev, net);
        bond_dev->rtnl_link_ops = &bond_link_ops;
-        if (!name) {
-                res = dev_alloc_name(bond_dev, "bond%d");
-                if (res < 0)
-                        goto out;
-        } else {
-                /*
-                 * If we're given a name to register
-                 * we need to ensure that its not already
-                 * registered
-                 */
-                res = -EEXIST;
-                if (__dev_get_by_name(net, name) != NULL)
-                        goto out;
-        }
        res = register_netdevice(bond_dev);
        netif_carrier_off(bond_dev);
-out:
        rtnl_unlock();
        if (res < 0)
                bond_destructor(bond_dev);
@@ -5121,7 +4963,6 @@ static int __init bonding_init(void)
        register_netdevice_notifier(&bond_netdev_notifier);
        register_inetaddr_notifier(&bond_inetaddr_notifier);
-        bond_register_ipv6_notifier();
 out:
        return res;
 err:
@@ -5136,7 +4977,6 @@ static void __exit bonding_exit(void)
 {
        unregister_netdevice_notifier(&bond_netdev_notifier);
        unregister_inetaddr_notifier(&bond_inetaddr_notifier);
-        bond_unregister_ipv6_notifier();
        bond_destroy_sysfs();
        bond_destroy_debugfs();
diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/bond_procfs.c
index c32ff55a34c1..c97307ddd1c9 100644
--- a/drivers/net/bonding/bond_procfs.c
+++ b/drivers/net/bonding/bond_procfs.c
@@ -4,8 +4,6 @@
 #include "bonding.h"
-extern const char *bond_mode_name(int mode);
 static void *bond_info_seq_start(struct seq_file *seq, loff_t *pos)
        __acquires(RCU)
        __acquires(&bond->lock)
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
index de87aea6d01a..4059bfc73dbf 100644
--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -422,11 +422,6 @@ static ssize_t bonding_store_arp_validate(struct device *d,
                bond->dev->name, arp_validate_tbl[new_value].modename,
                new_value);
-        if (!bond->params.arp_validate && new_value)
-                bond_register_arp(bond);
-        else if (bond->params.arp_validate && !new_value)
-                bond_unregister_arp(bond);
        bond->params.arp_validate = new_value;
        return count;
@@ -874,82 +869,28 @@ static DEVICE_ATTR(ad_select, S_IRUGO | S_IWUSR,
                   bonding_show_ad_select, bonding_store_ad_select);
 /*
- * Show and set the number of grat ARP to send after a failover event.
+ * Show and set the number of peer notifications to send after a failover event.
 */
-static ssize_t bonding_show_n_grat_arp(struct device *d,
+static ssize_t bonding_show_num_peer_notif(struct device *d,
-                                   struct device_attribute *attr,
+                                           struct device_attribute *attr,
-                                   char *buf)
+                                           char *buf)
 {
        struct bonding *bond = to_bond(d);
+        return sprintf(buf, "%d\n", bond->params.num_peer_notif);
-        return sprintf(buf, "%d\n", bond->params.num_grat_arp);
 }
-static ssize_t bonding_store_n_grat_arp(struct device *d,
+static ssize_t bonding_store_num_peer_notif(struct device *d,
-                                    struct device_attribute *attr,
+                                            struct device_attribute *attr,
-                                    const char *buf, size_t count)
+                                            const char *buf, size_t count)
 {
-        int new_value, ret = count;
        struct bonding *bond = to_bond(d);
+        int err = kstrtou8(buf, 10, &bond->params.num_peer_notif);
-        if (sscanf(buf, "%d", &new_value) != 1) {
+        return err ? err : count;
-                pr_err("%s: no num_grat_arp value specified.\n",
-                       bond->dev->name);
-                ret = -EINVAL;
-                goto out;
-        }
-        if (new_value < 0 || new_value > 255) {
-                pr_err("%s: Invalid num_grat_arp value %d not in range 0-255; rejected.\n",
-                       bond->dev->name, new_value);
-                ret = -EINVAL;
-                goto out;
-        } else {
-                bond->params.num_grat_arp = new_value;
-        }
-out:
-        return ret;
 }
 static DEVICE_ATTR(num_grat_arp, S_IRUGO | S_IWUSR,
-                   bonding_show_n_grat_arp, bonding_store_n_grat_arp);
+                   bonding_show_num_peer_notif, bonding_store_num_peer_notif);
-/*
- * Show and set the number of unsolicited NA's to send after a failover event.
- */
-static ssize_t bonding_show_n_unsol_na(struct device *d,
-                                       struct device_attribute *attr,
-                                       char *buf)
-{
-        struct bonding *bond = to_bond(d);
-        return sprintf(buf, "%d\n", bond->params.num_unsol_na);
-}
-static ssize_t bonding_store_n_unsol_na(struct device *d,
-                                        struct device_attribute *attr,
-                                        const char *buf, size_t count)
-{
-        int new_value, ret = count;
-        struct bonding *bond = to_bond(d);
-        if (sscanf(buf, "%d", &new_value) != 1) {
-                pr_err("%s: no num_unsol_na value specified.\n",
-                       bond->dev->name);
-                ret = -EINVAL;
-                goto out;
-        }
-        if (new_value < 0 || new_value > 255) {
-                pr_err("%s: Invalid num_unsol_na value %d not in range 0-255; rejected.\n",
-                       bond->dev->name, new_value);
-                ret = -EINVAL;
-                goto out;
-        } else
-                bond->params.num_unsol_na = new_value;
-out:
-        return ret;
-}
 static DEVICE_ATTR(num_unsol_na, S_IRUGO | S_IWUSR,
-                   bonding_show_n_unsol_na, bonding_store_n_unsol_na);
+                   bonding_show_num_peer_notif, bonding_store_num_peer_notif);
 /*
 * Show and set the MII monitor interval.  There are two tricky bits
@@ -1001,7 +942,6 @@ static ssize_t bonding_store_miimon(struct device *d,
                                bond->dev->name);
                        bond->params.arp_interval = 0;
                        if (bond->params.arp_validate) {
-                                bond_unregister_arp(bond);
                                bond->params.arp_validate =
                                        BOND_ARP_VALIDATE_NONE;
                        }
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index 90736cb4d975..ea1d005be92d 100644
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -24,8 +24,8 @@
 #include "bond_3ad.h"
 #include "bond_alb.h"
-#define DRV_VERSION     "3.7.0"
+#define DRV_VERSION     "3.7.1"
-#define DRV_RELDATE     "June 2, 2010"
+#define DRV_RELDATE     "April 27, 2011"
 #define DRV_NAME        "bonding"
 #define DRV_DESCRIPTION "Ethernet Channel Bonding Driver"
@@ -39,16 +39,6 @@
               netif_carrier_ok(dev))
 /*
- * Checks whether bond is ready for transmit.
- *
- * Caller must hold bond->lock
- */
-#define BOND_IS_OK(bond)                             \
-                   (((bond)->dev->flags & IFF_UP) && \
-                    netif_running((bond)->dev)    && \
-                    ((bond)->slave_cnt > 0))
-/*
 * Checks whether slave is ready for transmit.
 */
 #define SLAVE_IS_OK(slave)                              \
@@ -149,8 +139,7 @@ struct bond_params {
        int mode;
        int xmit_policy;
        int miimon;
-        int num_grat_arp;
+        u8 num_peer_notif;
-        int num_unsol_na;
        int arp_interval;
        int arp_validate;
        int use_carrier;
@@ -178,9 +167,6 @@ struct vlan_entry {
        struct list_head vlan_list;
        __be32 vlan_ip;
        unsigned short vlan_id;
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
-        struct in6_addr vlan_ipv6;
-#endif
 };
 struct slave {
@@ -196,12 +182,12 @@ struct slave {
        u8     backup:1,   /* indicates backup slave. Value corresponds with
                              BOND_STATE_ACTIVE and BOND_STATE_BACKUP */
               inactive:1; /* indicates inactive slave */
+        u8     duplex;
        u32    original_mtu;
        u32    link_failure_count;
-        u8     perm_hwaddr[ETH_ALEN];
+        u32    speed;
-        u16    speed;
-        u8     duplex;
        u16    queue_id;
+        u8     perm_hwaddr[ETH_ALEN];
        struct ad_slave_info ad_info; /* HUGE - better to dynamically alloc */
        struct tlb_slave_info tlb_info;
 #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -231,11 +217,12 @@ struct bonding {
        struct   slave *primary_slave;
        bool     force_primary;
        s32      slave_cnt; /* never change this value outside the attach/detach wrappers */
+        void     (*recv_probe)(struct sk_buff *, struct bonding *,
+                               struct slave *);
        rwlock_t lock;
        rwlock_t curr_slave_lock;
        s8       kill_timers;
-        s8       send_grat_arp;
+        u8       send_peer_notif;
-        s8       send_unsol_na;
        s8       setup_by_slave;
        s8       igmp_retrans;
 #ifdef CONFIG_PROC_FS
@@ -260,9 +247,6 @@ struct bonding {
        struct   delayed_work alb_work;
        struct   delayed_work ad_work;
        struct   delayed_work mcast_work;
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
-        struct   in6_addr master_ipv6;
-#endif
 #ifdef CONFIG_DEBUG_FS
        /* debugging suport via debugfs */
        struct   dentry *debug_dir;
@@ -409,13 +393,12 @@ void bond_set_mode_ops(struct bonding *bond, int mode);
 int bond_parse_parm(const char *mode_arg, const struct bond_parm_tbl *tbl);
 void bond_select_active_slave(struct bonding *bond);
 void bond_change_active_slave(struct bonding *bond, struct slave *new_active);
-void bond_register_arp(struct bonding *);
-void bond_unregister_arp(struct bonding *);
 void bond_create_debugfs(void);
 void bond_destroy_debugfs(void);
 void bond_debug_register(struct bonding *bond);
 void bond_debug_unregister(struct bonding *bond);
 void bond_debug_reregister(struct bonding *bond);
+const char *bond_mode_name(int mode);
 struct bond_net {
        struct net *            net;    /* Associated network namespace */
@@ -459,23 +442,4 @@ extern const struct bond_parm_tbl fail_over_mac_tbl[];
 extern const struct bond_parm_tbl pri_reselect_tbl[];
 extern struct bond_parm_tbl ad_select_tbl[];
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
-void bond_send_unsolicited_na(struct bonding *bond);
-void bond_register_ipv6_notifier(void);
-void bond_unregister_ipv6_notifier(void);
-#else
-static inline void bond_send_unsolicited_na(struct bonding *bond)
-{
-        return;
-}
-static inline void bond_register_ipv6_notifier(void)
-{
-        return;
-}
-static inline void bond_unregister_ipv6_notifier(void)
-{
-        return;
-}
-#endif
 #endif /* _LINUX_BONDING_H */
diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c
index 143a28c666af..22ce03e55b83 100644
--- a/drivers/net/cassini.c
+++ b/drivers/net/cassini.c
@@ -709,10 +709,11 @@ static void cas_begin_auto_negotiation(struct cas *cp, struct ethtool_cmd *ep)
        if (ep->autoneg == AUTONEG_ENABLE)
                cp->link_cntl = BMCR_ANENABLE;
        else {
+                u32 speed = ethtool_cmd_speed(ep);
                cp->link_cntl = 0;
-                if (ep->speed == SPEED_100)
+                if (speed == SPEED_100)
                        cp->link_cntl |= BMCR_SPEED100;
-                else if (ep->speed == SPEED_1000)
+                else if (speed == SPEED_1000)
                        cp->link_cntl |= CAS_BMCR_SPEED1000;
                if (ep->duplex == DUPLEX_FULL)
                        cp->link_cntl |= BMCR_FULLDPLX;
@@ -4605,18 +4606,17 @@ static int cas_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        if (bmcr & BMCR_ANENABLE) {
                cmd->advertising |= ADVERTISED_Autoneg;
                cmd->autoneg = AUTONEG_ENABLE;
-                cmd->speed = ((speed == 10) ?
+                ethtool_cmd_speed_set(cmd, ((speed == 10) ?
-                              SPEED_10 :
+                                            SPEED_10 :
-                              ((speed == 1000) ?
+                                            ((speed == 1000) ?
-                               SPEED_1000 : SPEED_100));
+                                             SPEED_1000 : SPEED_100)));
                cmd->duplex = full_duplex ? DUPLEX_FULL : DUPLEX_HALF;
        } else {
                cmd->autoneg = AUTONEG_DISABLE;
-                cmd->speed =
+                ethtool_cmd_speed_set(cmd, ((bmcr & CAS_BMCR_SPEED1000) ?
-                        (bmcr & CAS_BMCR_SPEED1000) ?
+                                            SPEED_1000 :
-                        SPEED_1000 :
+                                            ((bmcr & BMCR_SPEED100) ?
-                        ((bmcr & BMCR_SPEED100) ? SPEED_100:
+                                             SPEED_100 : SPEED_10)));
-                         SPEED_10);
                cmd->duplex =
                        (bmcr & BMCR_FULLDPLX) ?
                        DUPLEX_FULL : DUPLEX_HALF;
@@ -4633,14 +4633,14 @@ static int cas_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                 * settings that we configured.
                 */
                if (cp->link_cntl & BMCR_ANENABLE) {
-                        cmd->speed = 0;
+                        ethtool_cmd_speed_set(cmd, 0);
                        cmd->duplex = 0xff;
                } else {
-                        cmd->speed = SPEED_10;
+                        ethtool_cmd_speed_set(cmd, SPEED_10);
                        if (cp->link_cntl & BMCR_SPEED100) {
-                                cmd->speed = SPEED_100;
+                                ethtool_cmd_speed_set(cmd, SPEED_100);
                        } else if (cp->link_cntl & CAS_BMCR_SPEED1000) {
-                                cmd->speed = SPEED_1000;
+                                ethtool_cmd_speed_set(cmd, SPEED_1000);
                        }
                        cmd->duplex = (cp->link_cntl & BMCR_FULLDPLX)?
                                DUPLEX_FULL : DUPLEX_HALF;
@@ -4653,6 +4653,7 @@ static int cas_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        struct cas *cp = netdev_priv(dev);
        unsigned long flags;
+        u32 speed = ethtool_cmd_speed(cmd);
        /* Verify the settings we care about. */
        if (cmd->autoneg != AUTONEG_ENABLE &&
@@ -4660,9 +4661,9 @@ static int cas_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                return -EINVAL;
        if (cmd->autoneg == AUTONEG_DISABLE &&
-            ((cmd->speed != SPEED_1000 &&
+            ((speed != SPEED_1000 &&
-              cmd->speed != SPEED_100 &&
+              speed != SPEED_100 &&
-              cmd->speed != SPEED_10) ||
+              speed != SPEED_10) ||
             (cmd->duplex != DUPLEX_HALF &&
              cmd->duplex != DUPLEX_FULL)))
                return -EINVAL;
diff --git a/drivers/net/chelsio/common.h b/drivers/net/chelsio/common.h
index 092f31a126e6..c26d863e1697 100644
--- a/drivers/net/chelsio/common.h
+++ b/drivers/net/chelsio/common.h
@@ -264,11 +264,6 @@ struct adapter {
 enum {                                           /* adapter flags */
        FULL_INIT_DONE        = 1 << 0,
-        TSO_CAPABLE           = 1 << 2,
-        TCP_CSUM_CAPABLE      = 1 << 3,
-        UDP_CSUM_CAPABLE      = 1 << 4,
-        VLAN_ACCEL_CAPABLE    = 1 << 5,
-        RX_CSUM_ENABLED       = 1 << 6,
 };
 struct mdio_ops;
diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c
index 0f71304e0542..b422d83f5343 100644
--- a/drivers/net/chelsio/cxgb2.c
+++ b/drivers/net/chelsio/cxgb2.c
@@ -192,10 +192,8 @@ static void link_start(struct port_info *p)
 static void enable_hw_csum(struct adapter *adapter)
 {
-        if (adapter->flags & TSO_CAPABLE)
+        if (adapter->port[0].dev->hw_features & NETIF_F_TSO)
                t1_tp_set_ip_checksum_offload(adapter->tp, 1);  /* for TSO only */
-        if (adapter->flags & UDP_CSUM_CAPABLE)
-                t1_tp_set_udp_checksum_offload(adapter->tp, 1);
        t1_tp_set_tcp_checksum_offload(adapter->tp, 1);
 }
@@ -579,10 +577,10 @@ static int get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        cmd->advertising = p->link_config.advertising;
        if (netif_carrier_ok(dev)) {
-                cmd->speed = p->link_config.speed;
+                ethtool_cmd_speed_set(cmd, p->link_config.speed);
                cmd->duplex = p->link_config.duplex;
        } else {
-                cmd->speed = -1;
+                ethtool_cmd_speed_set(cmd, -1);
                cmd->duplex = -1;
        }
@@ -640,11 +638,12 @@ static int set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                return -EOPNOTSUPP;             /* can't change speed/duplex */
        if (cmd->autoneg == AUTONEG_DISABLE) {
-                int cap = speed_duplex_to_caps(cmd->speed, cmd->duplex);
+                u32 speed = ethtool_cmd_speed(cmd);
+                int cap = speed_duplex_to_caps(speed, cmd->duplex);
-                if (!(lc->supported & cap) || cmd->speed == SPEED_1000)
+                if (!(lc->supported & cap) || (speed == SPEED_1000))
                        return -EINVAL;
-                lc->requested_speed = cmd->speed;
+                lc->requested_speed = speed;
                lc->requested_duplex = cmd->duplex;
                lc->advertising = 0;
        } else {
@@ -705,33 +704,6 @@ static int set_pauseparam(struct net_device *dev,
        return 0;
 }
-static u32 get_rx_csum(struct net_device *dev)
-{
-        struct adapter *adapter = dev->ml_priv;
-        return (adapter->flags & RX_CSUM_ENABLED) != 0;
-}
-static int set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct adapter *adapter = dev->ml_priv;
-        if (data)
-                adapter->flags |= RX_CSUM_ENABLED;
-        else
-                adapter->flags &= ~RX_CSUM_ENABLED;
-        return 0;
-}
-static int set_tso(struct net_device *dev, u32 value)
-{
-        struct adapter *adapter = dev->ml_priv;
-        if (!(adapter->flags & TSO_CAPABLE))
-                return value ? -EOPNOTSUPP : 0;
-        return ethtool_op_set_tso(dev, value);
-}
 static void get_sge_param(struct net_device *dev, struct ethtool_ringparam *e)
 {
        struct adapter *adapter = dev->ml_priv;
@@ -831,17 +803,12 @@ static const struct ethtool_ops t1_ethtool_ops = {
        .get_eeprom        = get_eeprom,
        .get_pauseparam    = get_pauseparam,
        .set_pauseparam    = set_pauseparam,
-        .get_rx_csum       = get_rx_csum,
-        .set_rx_csum       = set_rx_csum,
-        .set_tx_csum       = ethtool_op_set_tx_csum,
-        .set_sg            = ethtool_op_set_sg,
        .get_link          = ethtool_op_get_link,
        .get_strings       = get_strings,
        .get_sset_count    = get_sset_count,
        .get_ethtool_stats = get_stats,
        .get_regs_len      = get_regs_len,
        .get_regs          = get_regs,
-        .set_tso           = set_tso,
 };
 static int t1_ioctl(struct net_device *dev, struct ifreq *req, int cmd)
@@ -1105,28 +1072,28 @@ static int __devinit init_one(struct pci_dev *pdev,
                netdev->mem_start = mmio_start;
                netdev->mem_end = mmio_start + mmio_len - 1;
                netdev->ml_priv = adapter;
-                netdev->features |= NETIF_F_SG | NETIF_F_IP_CSUM;
+                netdev->hw_features |= NETIF_F_SG | NETIF_F_IP_CSUM |
-                netdev->features |= NETIF_F_LLTX;
+                        NETIF_F_RXCSUM;
+                netdev->features |= NETIF_F_SG | NETIF_F_IP_CSUM |
+                        NETIF_F_RXCSUM | NETIF_F_LLTX;
-                adapter->flags |= RX_CSUM_ENABLED | TCP_CSUM_CAPABLE;
                if (pci_using_dac)
                        netdev->features |= NETIF_F_HIGHDMA;
                if (vlan_tso_capable(adapter)) {
 #if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
-                        adapter->flags |= VLAN_ACCEL_CAPABLE;
                        netdev->features |=
                                NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
 #endif
                        /* T204: disable TSO */
                        if (!(is_T2(adapter)) || bi->port_number != 4) {
-                                adapter->flags |= TSO_CAPABLE;
+                                netdev->hw_features |= NETIF_F_TSO;
                                netdev->features |= NETIF_F_TSO;
                        }
                }
                netdev->netdev_ops = &cxgb_netdev_ops;
-                netdev->hard_header_len += (adapter->flags & TSO_CAPABLE) ?
+                netdev->hard_header_len += (netdev->hw_features & NETIF_F_TSO) ?
                        sizeof(struct cpl_tx_pkt_lso) : sizeof(struct cpl_tx_pkt);
                netif_napi_add(netdev, &adapter->napi, t1_poll, 64);
diff --git a/drivers/net/chelsio/sge.c b/drivers/net/chelsio/sge.c
index 8754d4473042..b948ea737550 100644
--- a/drivers/net/chelsio/sge.c
+++ b/drivers/net/chelsio/sge.c
@@ -929,7 +929,7 @@ void t1_sge_intr_enable(struct sge *sge)
        u32 en = SGE_INT_ENABLE;
        u32 val = readl(sge->adapter->regs + A_PL_ENABLE);
-        if (sge->adapter->flags & TSO_CAPABLE)
+        if (sge->adapter->port[0].dev->hw_features & NETIF_F_TSO)
                en &= ~F_PACKET_TOO_BIG;
        writel(en, sge->adapter->regs + A_SG_INT_ENABLE);
        writel(val | SGE_PL_INTR_MASK, sge->adapter->regs + A_PL_ENABLE);
@@ -952,7 +952,7 @@ int t1_sge_intr_error_handler(struct sge *sge)
        struct adapter *adapter = sge->adapter;
        u32 cause = readl(adapter->regs + A_SG_INT_CAUSE);
-        if (adapter->flags & TSO_CAPABLE)
+        if (adapter->port[0].dev->hw_features & NETIF_F_TSO)
                cause &= ~F_PACKET_TOO_BIG;
        if (cause & F_RESPQ_EXHAUSTED)
                sge->stats.respQ_empty++;
@@ -1369,6 +1369,7 @@ static void sge_rx(struct sge *sge, struct freelQ *fl, unsigned int len)
        const struct cpl_rx_pkt *p;
        struct adapter *adapter = sge->adapter;
        struct sge_port_stats *st;
+        struct net_device *dev;
        skb = get_packet(adapter->pdev, fl, len - sge->rx_pkt_pad);
        if (unlikely(!skb)) {
@@ -1384,9 +1385,10 @@ static void sge_rx(struct sge *sge, struct freelQ *fl, unsigned int len)
        __skb_pull(skb, sizeof(*p));
        st = this_cpu_ptr(sge->port_stats[p->iff]);
+        dev = adapter->port[p->iff].dev;
-        skb->protocol = eth_type_trans(skb, adapter->port[p->iff].dev);
+        skb->protocol = eth_type_trans(skb, dev);
-        if ((adapter->flags & RX_CSUM_ENABLED) && p->csum == 0xffff &&
+        if ((dev->features & NETIF_F_RXCSUM) && p->csum == 0xffff &&
            skb->protocol == htons(ETH_P_IP) &&
            (skb->data[9] == IPPROTO_TCP || skb->data[9] == IPPROTO_UDP)) {
                ++st->rx_cso_good;
@@ -1838,8 +1840,7 @@ netdev_tx_t t1_start_xmit(struct sk_buff *skb, struct net_device *dev)
                        return NETDEV_TX_OK;
                }
-                if (!(adapter->flags & UDP_CSUM_CAPABLE) &&
+                if (skb->ip_summed == CHECKSUM_PARTIAL &&
-                    skb->ip_summed == CHECKSUM_PARTIAL &&
                    ip_hdr(skb)->protocol == IPPROTO_UDP) {
                        if (unlikely(skb_checksum_help(skb))) {
                                pr_debug("%s: unable to do udp checksum\n", dev->name);
diff --git a/drivers/net/chelsio/tp.c b/drivers/net/chelsio/tp.c
index 6222d585e447..8bed4a59e65f 100644
--- a/drivers/net/chelsio/tp.c
+++ b/drivers/net/chelsio/tp.c
@@ -152,11 +152,6 @@ void t1_tp_set_ip_checksum_offload(struct petp *tp, int enable)
        set_csum_offload(tp, F_IP_CSUM, enable);
 }
-void t1_tp_set_udp_checksum_offload(struct petp *tp, int enable)
-{
-        set_csum_offload(tp, F_UDP_CSUM, enable);
-}
 void t1_tp_set_tcp_checksum_offload(struct petp *tp, int enable)
 {
        set_csum_offload(tp, F_TCP_CSUM, enable);
diff --git a/drivers/net/chelsio/tp.h b/drivers/net/chelsio/tp.h
index 32fc71e58913..dfd8ce25106a 100644
--- a/drivers/net/chelsio/tp.h
+++ b/drivers/net/chelsio/tp.h
@@ -65,7 +65,6 @@ void t1_tp_intr_clear(struct petp *tp);
 int t1_tp_intr_handler(struct petp *tp);
 void t1_tp_get_mib_statistics(adapter_t *adap, struct tp_mib_statistics *tps);
-void t1_tp_set_udp_checksum_offload(struct petp *tp, int enable);
 void t1_tp_set_tcp_checksum_offload(struct petp *tp, int enable);
 void t1_tp_set_ip_checksum_offload(struct petp *tp, int enable);
 int t1_tp_set_coalescing_size(struct petp *tp, unsigned int size);
diff --git a/drivers/net/cnic.c b/drivers/net/cnic.c
index 8cca60e43444..cde59b4e5ef8 100644
--- a/drivers/net/cnic.c
+++ b/drivers/net/cnic.c
@@ -2966,31 +2966,36 @@ static int cnic_service_bnx2x(void *data, void *status_blk)
        return 0;
 }
-static void cnic_ulp_stop(struct cnic_dev *dev)
+static void cnic_ulp_stop_one(struct cnic_local *cp, int if_type)
 {
-        struct cnic_local *cp = dev->cnic_priv;
+        struct cnic_ulp_ops *ulp_ops;
-        int if_type;
-        cnic_send_nlmsg(cp, ISCSI_KEVENT_IF_DOWN, NULL);
-        for (if_type = 0; if_type < MAX_CNIC_ULP_TYPE; if_type++) {
+        if (if_type == CNIC_ULP_ISCSI)
-                struct cnic_ulp_ops *ulp_ops;
+                cnic_send_nlmsg(cp, ISCSI_KEVENT_IF_DOWN, NULL);
-                mutex_lock(&cnic_lock);
+        mutex_lock(&cnic_lock);
-                ulp_ops = rcu_dereference_protected(cp->ulp_ops[if_type],
+        ulp_ops = rcu_dereference_protected(cp->ulp_ops[if_type],
-                                                    lockdep_is_held(&cnic_lock));
+                                            lockdep_is_held(&cnic_lock));
-                if (!ulp_ops) {
+        if (!ulp_ops) {
-                        mutex_unlock(&cnic_lock);
-                        continue;
-                }
-                set_bit(ULP_F_CALL_PENDING, &cp->ulp_flags[if_type]);
                mutex_unlock(&cnic_lock);
+                return;
+        }
+        set_bit(ULP_F_CALL_PENDING, &cp->ulp_flags[if_type]);
+        mutex_unlock(&cnic_lock);
-                if (test_and_clear_bit(ULP_F_START, &cp->ulp_flags[if_type]))
+        if (test_and_clear_bit(ULP_F_START, &cp->ulp_flags[if_type]))
-                        ulp_ops->cnic_stop(cp->ulp_handle[if_type]);
+                ulp_ops->cnic_stop(cp->ulp_handle[if_type]);
-                clear_bit(ULP_F_CALL_PENDING, &cp->ulp_flags[if_type]);
+        clear_bit(ULP_F_CALL_PENDING, &cp->ulp_flags[if_type]);
-        }
+}
+static void cnic_ulp_stop(struct cnic_dev *dev)
+{
+        struct cnic_local *cp = dev->cnic_priv;
+        int if_type;
+        for (if_type = 0; if_type < MAX_CNIC_ULP_TYPE; if_type++)
+                cnic_ulp_stop_one(cp, if_type);
 }
 static void cnic_ulp_start(struct cnic_dev *dev)
@@ -3039,6 +3044,12 @@ static int cnic_ctl(void *data, struct cnic_ctl_info *info)
                cnic_put(dev);
                break;
+        case CNIC_CTL_STOP_ISCSI_CMD: {
+                struct cnic_local *cp = dev->cnic_priv;
+                set_bit(CNIC_LCL_FL_STOP_ISCSI, &cp->cnic_local_flags);
+                queue_delayed_work(cnic_wq, &cp->delete_task, 0);
+                break;
+        }
        case CNIC_CTL_COMPLETION_CMD: {
                u32 cid = BNX2X_SW_CID(info->data.comp.cid);
                u32 l5_cid;
@@ -3562,8 +3573,12 @@ static void cnic_init_csk_state(struct cnic_sock *csk)
 static int cnic_cm_connect(struct cnic_sock *csk, struct cnic_sockaddr *saddr)
 {
+        struct cnic_local *cp = csk->dev->cnic_priv;
        int err = 0;
+        if (cp->ethdev->drv_state & CNIC_DRV_STATE_NO_ISCSI)
+                return -EOPNOTSUPP;
        if (!cnic_in_use(csk))
                return -EINVAL;
@@ -3965,6 +3980,15 @@ static void cnic_delete_task(struct work_struct *work)
        cp = container_of(work, struct cnic_local, delete_task.work);
        dev = cp->dev;
+        if (test_and_clear_bit(CNIC_LCL_FL_STOP_ISCSI, &cp->cnic_local_flags)) {
+                struct drv_ctl_info info;
+                cnic_ulp_stop_one(cp, CNIC_ULP_ISCSI);
+                info.cmd = DRV_CTL_ISCSI_STOPPED_CMD;
+                cp->ethdev->drv_ctl(dev->netdev, &info);
+        }
        for (i = 0; i < cp->max_cid_space; i++) {
                struct cnic_context *ctx = &cp->ctx_tbl[i];
diff --git a/drivers/net/cnic.h b/drivers/net/cnic.h
index 4456260c653c..3367a6d3a774 100644
--- a/drivers/net/cnic.h
+++ b/drivers/net/cnic.h
@@ -226,6 +226,7 @@ struct cnic_local {
 #define CNIC_LCL_FL_KWQ_INIT            0x0
 #define CNIC_LCL_FL_L2_WAIT             0x1
 #define CNIC_LCL_FL_RINGS_INITED        0x2
+#define CNIC_LCL_FL_STOP_ISCSI          0x4
        struct cnic_dev *dev;
diff --git a/drivers/net/cnic_if.h b/drivers/net/cnic_if.h
index e01b49ee3591..fdd8e46a9050 100644
--- a/drivers/net/cnic_if.h
+++ b/drivers/net/cnic_if.h
@@ -12,8 +12,8 @@
 #ifndef CNIC_IF_H
 #define CNIC_IF_H
-#define CNIC_MODULE_VERSION     "2.2.13"
+#define CNIC_MODULE_VERSION     "2.2.14"
-#define CNIC_MODULE_RELDATE     "Jan 31, 2011"
+#define CNIC_MODULE_RELDATE     "Mar 30, 2011"
 #define CNIC_ULP_RDMA           0
 #define CNIC_ULP_ISCSI          1
@@ -85,6 +85,7 @@ struct kcqe {
 #define CNIC_CTL_STOP_CMD               1
 #define CNIC_CTL_START_CMD              2
 #define CNIC_CTL_COMPLETION_CMD         3
+#define CNIC_CTL_STOP_ISCSI_CMD         4
 #define DRV_CTL_IO_WR_CMD               0x101
 #define DRV_CTL_IO_RD_CMD               0x102
@@ -94,6 +95,7 @@ struct kcqe {
 #define DRV_CTL_START_L2_CMD            0x106
 #define DRV_CTL_STOP_L2_CMD             0x107
 #define DRV_CTL_RET_L2_SPQ_CREDIT_CMD   0x10c
+#define DRV_CTL_ISCSI_STOPPED_CMD       0x10d
 struct cnic_ctl_completion {
        u32     cid;
diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c
index 9d267d3a6892..e66aceb57cef 100644
--- a/drivers/net/cris/eth_v10.c
+++ b/drivers/net/cris/eth_v10.c
@@ -491,8 +491,8 @@ e100_open(struct net_device *dev)
        /* allocate the irq corresponding to the receiving DMA */
-        if (request_irq(NETWORK_DMA_RX_IRQ_NBR, e100rxtx_interrupt,
+        if (request_irq(NETWORK_DMA_RX_IRQ_NBR, e100rxtx_interrupt, 0, cardname,
-                        IRQF_SAMPLE_RANDOM, cardname, (void *)dev)) {
+                        (void *)dev)) {
                goto grace_exit0;
        }
diff --git a/drivers/net/cxgb3/adapter.h b/drivers/net/cxgb3/adapter.h
index ef67be59680f..7300de5a1426 100644
--- a/drivers/net/cxgb3/adapter.h
+++ b/drivers/net/cxgb3/adapter.h
@@ -50,11 +50,6 @@ struct adapter;
 struct sge_qset;
 struct port_info;
-enum {                  /* rx_offload flags */
-        T3_RX_CSUM      = 1 << 0,
-        T3_LRO          = 1 << 1,
-};
 enum mac_idx_types {
        LAN_MAC_IDX     = 0,
        SAN_MAC_IDX,
@@ -74,7 +69,6 @@ struct port_info {
        struct vlan_group *vlan_grp;
        struct sge_qset *qs;
        u8 port_id;
-        u8 rx_offload;
        u8 nqsets;
        u8 first_qset;
        struct cphy phy;
@@ -212,7 +206,6 @@ struct sge_qset {		/* an SGE queue set */
        struct sge_fl fl[SGE_RXQ_PER_SET];
        struct sge_txq txq[SGE_TXQ_PER_SET];
        int nomem;
-        int lro_enabled;
        void *lro_va;
        struct net_device *netdev;
        struct netdev_queue *tx_q;      /* associated netdev TX queue */
diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h
index 5ccb77d078aa..056ee8c831f1 100644
--- a/drivers/net/cxgb3/common.h
+++ b/drivers/net/cxgb3/common.h
@@ -317,7 +317,6 @@ struct tp_params {
 struct qset_params {            /* SGE queue set parameters */
        unsigned int polling;   /* polling/interrupt service for rspq */
-        unsigned int lro;       /* large receive offload */
        unsigned int coalesce_usecs;    /* irq coalescing timer */
        unsigned int rspq_size; /* # of entries in response queue */
        unsigned int fl_size;   /* # of entries in regular free list */
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index 910893143295..9081ce037149 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -644,26 +644,6 @@ static void enable_all_napi(struct adapter *adap)
 }
 /**
- *      set_qset_lro - Turn a queue set's LRO capability on and off
- *      @dev: the device the qset is attached to
- *      @qset_idx: the queue set index
- *      @val: the LRO switch
- *
- *      Sets LRO on or off for a particular queue set.
- *      the device's features flag is updated to reflect the LRO
- *      capability when all queues belonging to the device are
- *      in the same state.
- */
-static void set_qset_lro(struct net_device *dev, int qset_idx, int val)
-{
-        struct port_info *pi = netdev_priv(dev);
-        struct adapter *adapter = pi->adapter;
-        adapter->params.sge.qset[qset_idx].lro = !!val;
-        adapter->sge.qs[qset_idx].lro_enabled = !!val;
-}
-/**
 *      setup_sge_qsets - configure SGE Tx/Rx/response queues
 *      @adap: the adapter
 *
@@ -685,7 +665,6 @@ static int setup_sge_qsets(struct adapter *adap)
                pi->qs = &adap->sge.qs[pi->first_qset];
                for (j = 0; j < pi->nqsets; ++j, ++qset_idx) {
-                        set_qset_lro(dev, qset_idx, pi->rx_offload & T3_LRO);
                        err = t3_sge_alloc_qset(adap, qset_idx, 1,
                                (adap->flags & USING_MSIX) ? qset_idx + 1 :
                                                             irq_idx,
@@ -1749,23 +1728,26 @@ static int restart_autoneg(struct net_device *dev)
        return 0;
 }
-static int cxgb3_phys_id(struct net_device *dev, u32 data)
+static int set_phys_id(struct net_device *dev,
+                       enum ethtool_phys_id_state state)
 {
        struct port_info *pi = netdev_priv(dev);
        struct adapter *adapter = pi->adapter;
-        int i;
-        if (data == 0)
+        switch (state) {
-                data = 2;
+        case ETHTOOL_ID_ACTIVE:
+                return 1;       /* cycle on/off once per second */
-        for (i = 0; i < data * 2; i++) {
+        case ETHTOOL_ID_OFF:
+                t3_set_reg_field(adapter, A_T3DBG_GPIO_EN, F_GPIO0_OUT_VAL, 0);
+                break;
+        case ETHTOOL_ID_ON:
+        case ETHTOOL_ID_INACTIVE:
                t3_set_reg_field(adapter, A_T3DBG_GPIO_EN, F_GPIO0_OUT_VAL,
-                                 (i & 1) ? F_GPIO0_OUT_VAL : 0);
-                if (msleep_interruptible(500))
-                        break;
-        }
-        t3_set_reg_field(adapter, A_T3DBG_GPIO_EN, F_GPIO0_OUT_VAL,
                         F_GPIO0_OUT_VAL);
+        }
        return 0;
 }
@@ -1777,10 +1759,10 @@ static int get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        cmd->advertising = p->link_config.advertising;
        if (netif_carrier_ok(dev)) {
-                cmd->speed = p->link_config.speed;
+                ethtool_cmd_speed_set(cmd, p->link_config.speed);
                cmd->duplex = p->link_config.duplex;
        } else {
-                cmd->speed = -1;
+                ethtool_cmd_speed_set(cmd, -1);
                cmd->duplex = -1;
        }
@@ -1839,7 +1821,8 @@ static int set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                 * being requested.
                 */
                if (cmd->autoneg == AUTONEG_DISABLE) {
-                        int cap = speed_duplex_to_caps(cmd->speed, cmd->duplex);
+                        u32 speed = ethtool_cmd_speed(cmd);
+                        int cap = speed_duplex_to_caps(speed, cmd->duplex);
                        if (lc->supported & cap)
                                return 0;
                }
@@ -1847,11 +1830,12 @@ static int set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        }
        if (cmd->autoneg == AUTONEG_DISABLE) {
-                int cap = speed_duplex_to_caps(cmd->speed, cmd->duplex);
+                u32 speed = ethtool_cmd_speed(cmd);
+                int cap = speed_duplex_to_caps(speed, cmd->duplex);
-                if (!(lc->supported & cap) || cmd->speed == SPEED_1000)
+                if (!(lc->supported & cap) || (speed == SPEED_1000))
                        return -EINVAL;
-                lc->requested_speed = cmd->speed;
+                lc->requested_speed = speed;
                lc->requested_duplex = cmd->duplex;
                lc->advertising = 0;
        } else {
@@ -1907,29 +1891,6 @@ static int set_pauseparam(struct net_device *dev,
        return 0;
 }
-static u32 get_rx_csum(struct net_device *dev)
-{
-        struct port_info *p = netdev_priv(dev);
-        return p->rx_offload & T3_RX_CSUM;
-}
-static int set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct port_info *p = netdev_priv(dev);
-        if (data) {
-                p->rx_offload |= T3_RX_CSUM;
-        } else {
-                int i;
-                p->rx_offload &= ~(T3_RX_CSUM | T3_LRO);
-                for (i = p->first_qset; i < p->first_qset + p->nqsets; i++)
-                        set_qset_lro(dev, i, 0);
-        }
-        return 0;
-}
 static void get_sge_param(struct net_device *dev, struct ethtool_ringparam *e)
 {
        struct port_info *pi = netdev_priv(dev);
@@ -2101,20 +2062,15 @@ static const struct ethtool_ops cxgb_ethtool_ops = {
        .set_eeprom = set_eeprom,
        .get_pauseparam = get_pauseparam,
        .set_pauseparam = set_pauseparam,
-        .get_rx_csum = get_rx_csum,
-        .set_rx_csum = set_rx_csum,
-        .set_tx_csum = ethtool_op_set_tx_csum,
-        .set_sg = ethtool_op_set_sg,
        .get_link = ethtool_op_get_link,
        .get_strings = get_strings,
-        .phys_id = cxgb3_phys_id,
+        .set_phys_id = set_phys_id,
        .nway_reset = restart_autoneg,
        .get_sset_count = get_sset_count,
        .get_ethtool_stats = get_stats,
        .get_regs_len = get_regs_len,
        .get_regs = get_regs,
        .get_wol = get_wol,
-        .set_tso = ethtool_op_set_tso,
 };
 static int in_range(int val, int lo, int hi)
@@ -2162,15 +2118,6 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
                              MAX_RSPQ_ENTRIES))
                        return -EINVAL;
-                if ((adapter->flags & FULL_INIT_DONE) && t.lro > 0)
-                        for_each_port(adapter, i) {
-                                pi = adap2pinfo(adapter, i);
-                                if (t.qset_idx >= pi->first_qset &&
-                                    t.qset_idx < pi->first_qset + pi->nqsets &&
-                                    !(pi->rx_offload & T3_RX_CSUM))
-                                        return -EINVAL;
-                        }
                if ((adapter->flags & FULL_INIT_DONE) &&
                        (t.rspq_size >= 0 || t.fl_size[0] >= 0 ||
                        t.fl_size[1] >= 0 || t.txq_size[0] >= 0 ||
@@ -2231,8 +2178,14 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
                                }
                        }
                }
-                if (t.lro >= 0)
-                        set_qset_lro(dev, t.qset_idx, t.lro);
+                if (t.lro >= 0) {
+                        if (t.lro)
+                                dev->wanted_features |= NETIF_F_GRO;
+                        else
+                                dev->wanted_features &= ~NETIF_F_GRO;
+                        netdev_update_features(dev);
+                }
                break;
        }
@@ -2266,7 +2219,7 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
                t.fl_size[0] = q->fl_size;
                t.fl_size[1] = q->jumbo_size;
                t.polling = q->polling;
-                t.lro = q->lro;
+                t.lro = !!(dev->features & NETIF_F_GRO);
                t.intr_lat = q->coalesce_usecs;
                t.cong_thres = q->cong_thres;
                t.qnum = q1;
@@ -3304,18 +3257,18 @@ static int __devinit init_one(struct pci_dev *pdev,
                adapter->port[i] = netdev;
                pi = netdev_priv(netdev);
                pi->adapter = adapter;
-                pi->rx_offload = T3_RX_CSUM | T3_LRO;
                pi->port_id = i;
                netif_carrier_off(netdev);
                netdev->irq = pdev->irq;
                netdev->mem_start = mmio_start;
                netdev->mem_end = mmio_start + mmio_len - 1;
-                netdev->features |= NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO;
+                netdev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM |
-                netdev->features |= NETIF_F_GRO;
+                        NETIF_F_TSO | NETIF_F_RXCSUM;
+                netdev->features |= netdev->hw_features |
+                        NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
                if (pci_using_dac)
                        netdev->features |= NETIF_F_HIGHDMA;
-                netdev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
                netdev->netdev_ops = &cxgb_netdev_ops;
                SET_ETHTOOL_OPS(netdev, &cxgb_ethtool_ops);
        }
diff --git a/drivers/net/cxgb3/sge.c b/drivers/net/cxgb3/sge.c
index bfa2d56af1ee..cba1401377ab 100644
--- a/drivers/net/cxgb3/sge.c
+++ b/drivers/net/cxgb3/sge.c
@@ -2019,7 +2019,7 @@ static void rx_eth(struct adapter *adap, struct sge_rspq *rq,
        skb_pull(skb, sizeof(*p) + pad);
        skb->protocol = eth_type_trans(skb, adap->port[p->iff]);
        pi = netdev_priv(skb->dev);
-        if ((pi->rx_offload & T3_RX_CSUM) && p->csum_valid &&
+        if ((skb->dev->features & NETIF_F_RXCSUM) && p->csum_valid &&
            p->csum == htons(0xffff) && !p->fragment) {
                qs->port_stats[SGE_PSTAT_RX_CSUM_GOOD]++;
                skb->ip_summed = CHECKSUM_UNNECESSARY;
@@ -2120,7 +2120,7 @@ static void lro_add_page(struct adapter *adap, struct sge_qset *qs,
                offset = 2 + sizeof(struct cpl_rx_pkt);
                cpl = qs->lro_va = sd->pg_chunk.va + 2;
-                if ((pi->rx_offload & T3_RX_CSUM) &&
+                if ((qs->netdev->features & NETIF_F_RXCSUM) &&
                     cpl->csum_valid && cpl->csum == htons(0xffff)) {
                        skb->ip_summed = CHECKSUM_UNNECESSARY;
                        qs->port_stats[SGE_PSTAT_RX_CSUM_GOOD]++;
@@ -2285,7 +2285,8 @@ static int process_responses(struct adapter *adap, struct sge_qset *qs,
        q->next_holdoff = q->holdoff_tmr;
        while (likely(budget_left && is_new_response(r, q))) {
-                int packet_complete, eth, ethpad = 2, lro = qs->lro_enabled;
+                int packet_complete, eth, ethpad = 2;
+                int lro = !!(qs->netdev->features & NETIF_F_GRO);
                struct sk_buff *skb = NULL;
                u32 len, flags;
                __be32 rss_hi, rss_lo;
diff --git a/drivers/net/cxgb4/cxgb4.h b/drivers/net/cxgb4/cxgb4.h
index 01d49eaa44d2..bc9982a4c1f4 100644
--- a/drivers/net/cxgb4/cxgb4.h
+++ b/drivers/net/cxgb4/cxgb4.h
@@ -290,7 +290,6 @@ struct port_info {
        u8     port_id;
        u8     tx_chan;
        u8     lport;                 /* associated offload logical port */
-        u8     rx_offload;            /* CSO, etc */
        u8     nqsets;                /* # of qsets */
        u8     first_qset;            /* index of first qset */
        u8     rss_mode;
@@ -298,11 +297,6 @@ struct port_info {
        u16   *rss;
 };
-/* port_info.rx_offload flags */
-enum {
-        RX_CSO = 1 << 0,
-};
 struct dentry;
 struct work_struct;
diff --git a/drivers/net/cxgb4/cxgb4_main.c b/drivers/net/cxgb4/cxgb4_main.c
index 5352c8a23f4d..7e3cfbe89e3b 100644
--- a/drivers/net/cxgb4/cxgb4_main.c
+++ b/drivers/net/cxgb4/cxgb4_main.c
@@ -1336,15 +1336,20 @@ static int restart_autoneg(struct net_device *dev)
        return 0;
 }
-static int identify_port(struct net_device *dev, u32 data)
+static int identify_port(struct net_device *dev,
+                         enum ethtool_phys_id_state state)
 {
+        unsigned int val;
        struct adapter *adap = netdev2adap(dev);
-        if (data == 0)
+        if (state == ETHTOOL_ID_ACTIVE)
-                data = 2;     /* default to 2 seconds */
+                val = 0xffff;
+        else if (state == ETHTOOL_ID_INACTIVE)
+                val = 0;
+        else
+                return -EINVAL;
-        return t4_identify_port(adap, adap->fn, netdev2pinfo(dev)->viid,
+        return t4_identify_port(adap, adap->fn, netdev2pinfo(dev)->viid, val);
-                                data * 5);
 }
 static unsigned int from_fw_linkcaps(unsigned int type, unsigned int caps)
@@ -1431,7 +1436,8 @@ static int get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        cmd->supported = from_fw_linkcaps(p->port_type, p->link_cfg.supported);
        cmd->advertising = from_fw_linkcaps(p->port_type,
                                            p->link_cfg.advertising);
-        cmd->speed = netif_carrier_ok(dev) ? p->link_cfg.speed : 0;
+        ethtool_cmd_speed_set(cmd,
+                              netif_carrier_ok(dev) ? p->link_cfg.speed : 0);
        cmd->duplex = DUPLEX_FULL;
        cmd->autoneg = p->link_cfg.autoneg;
        cmd->maxtxpkt = 0;
@@ -1455,6 +1461,7 @@ static int set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        unsigned int cap;
        struct port_info *p = netdev_priv(dev);
        struct link_config *lc = &p->link_cfg;
+        u32 speed = ethtool_cmd_speed(cmd);
        if (cmd->duplex != DUPLEX_FULL)     /* only full-duplex supported */
                return -EINVAL;
@@ -1465,16 +1472,16 @@ static int set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                 * being requested.
                 */
                if (cmd->autoneg == AUTONEG_DISABLE &&
-                    (lc->supported & speed_to_caps(cmd->speed)))
+                    (lc->supported & speed_to_caps(speed)))
-                                return 0;
+                        return 0;
                return -EINVAL;
        }
        if (cmd->autoneg == AUTONEG_DISABLE) {
-                cap = speed_to_caps(cmd->speed);
+                cap = speed_to_caps(speed);
-                if (!(lc->supported & cap) || cmd->speed == SPEED_1000 ||
+                if (!(lc->supported & cap) || (speed == SPEED_1000) ||
-                    cmd->speed == SPEED_10000)
+                    (speed == SPEED_10000))
                        return -EINVAL;
                lc->requested_speed = cap;
                lc->advertising = 0;
@@ -1526,24 +1533,6 @@ static int set_pauseparam(struct net_device *dev,
        return 0;
 }
-static u32 get_rx_csum(struct net_device *dev)
-{
-        struct port_info *p = netdev_priv(dev);
-        return p->rx_offload & RX_CSO;
-}
-static int set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct port_info *p = netdev_priv(dev);
-        if (data)
-                p->rx_offload |= RX_CSO;
-        else
-                p->rx_offload &= ~RX_CSO;
-        return 0;
-}
 static void get_sge_param(struct net_device *dev, struct ethtool_ringparam *e)
 {
        const struct port_info *pi = netdev_priv(dev);
@@ -1865,36 +1854,20 @@ static int set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
        return err;
 }
-#define TSO_FLAGS (NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN)
+static int cxgb_set_features(struct net_device *dev, u32 features)
-static int set_tso(struct net_device *dev, u32 value)
-{
-        if (value)
-                dev->features |= TSO_FLAGS;
-        else
-                dev->features &= ~TSO_FLAGS;
-        return 0;
-}
-static int set_flags(struct net_device *dev, u32 flags)
 {
+        const struct port_info *pi = netdev_priv(dev);
+        u32 changed = dev->features ^ features;
        int err;
-        unsigned long old_feat = dev->features;
-        err = ethtool_op_set_flags(dev, flags, ETH_FLAG_RXHASH |
+        if (!(changed & NETIF_F_HW_VLAN_RX))
-                                   ETH_FLAG_RXVLAN | ETH_FLAG_TXVLAN);
+                return 0;
-        if (err)
-                return err;
-        if ((old_feat ^ dev->features) & NETIF_F_HW_VLAN_RX) {
-                const struct port_info *pi = netdev_priv(dev);
-                err = t4_set_rxmode(pi->adapter, pi->adapter->fn, pi->viid, -1,
+        err = t4_set_rxmode(pi->adapter, pi->adapter->fn, pi->viid, -1,
-                                    -1, -1, -1, !!(flags & ETH_FLAG_RXVLAN),
+                            -1, -1, -1,
-                                    true);
+                            !!(features & NETIF_F_HW_VLAN_RX), true);
-                if (err)
+        if (unlikely(err))
-                        dev->features = old_feat;
+                dev->features = features ^ NETIF_F_HW_VLAN_RX;
-        }
        return err;
 }
@@ -2005,13 +1978,9 @@ static struct ethtool_ops cxgb_ethtool_ops = {
        .set_eeprom        = set_eeprom,
        .get_pauseparam    = get_pauseparam,
        .set_pauseparam    = set_pauseparam,
-        .get_rx_csum       = get_rx_csum,
-        .set_rx_csum       = set_rx_csum,
-        .set_tx_csum       = ethtool_op_set_tx_ipv6_csum,
-        .set_sg            = ethtool_op_set_sg,
        .get_link          = ethtool_op_get_link,
        .get_strings       = get_strings,
-        .phys_id           = identify_port,
+        .set_phys_id       = identify_port,
        .nway_reset        = restart_autoneg,
        .get_sset_count    = get_sset_count,
        .get_ethtool_stats = get_stats,
@@ -2019,8 +1988,6 @@ static struct ethtool_ops cxgb_ethtool_ops = {
        .get_regs          = get_regs,
        .get_wol           = get_wol,
        .set_wol           = set_wol,
-        .set_tso           = set_tso,
-        .set_flags         = set_flags,
        .get_rxnfc         = get_rxnfc,
        .get_rxfh_indir    = get_rss_table,
        .set_rxfh_indir    = set_rss_table,
@@ -2877,6 +2844,7 @@ static const struct net_device_ops cxgb4_netdev_ops = {
        .ndo_get_stats64      = cxgb_get_stats,
        .ndo_set_rx_mode      = cxgb_set_rxmode,
        .ndo_set_mac_address  = cxgb_set_mac_addr,
+        .ndo_set_features     = cxgb_set_features,
        .ndo_validate_addr    = eth_validate_addr,
        .ndo_do_ioctl         = cxgb_ioctl,
        .ndo_change_mtu       = cxgb_change_mtu,
@@ -3559,6 +3527,7 @@ static void free_some_resources(struct adapter *adapter)
                t4_fw_bye(adapter, adapter->fn);
 }
+#define TSO_FLAGS (NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN)
 #define VLAN_FEAT (NETIF_F_SG | NETIF_F_IP_CSUM | TSO_FLAGS | \
                   NETIF_F_IPV6_CSUM | NETIF_F_HIGHDMA)
@@ -3660,14 +3629,14 @@ static int __devinit init_one(struct pci_dev *pdev,
                pi = netdev_priv(netdev);
                pi->adapter = adapter;
                pi->xact_addr_filt = -1;
-                pi->rx_offload = RX_CSO;
                pi->port_id = i;
                netdev->irq = pdev->irq;
-                netdev->features |= NETIF_F_SG | TSO_FLAGS;
+                netdev->hw_features = NETIF_F_SG | TSO_FLAGS |
-                netdev->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
+                        NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
-                netdev->features |= NETIF_F_GRO | NETIF_F_RXHASH | highdma;
+                        NETIF_F_RXCSUM | NETIF_F_RXHASH |
-                netdev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+                        NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+                netdev->features |= netdev->hw_features | highdma;
                netdev->vlan_features = netdev->features & VLAN_FEAT;
                netdev->netdev_ops = &cxgb4_netdev_ops;
diff --git a/drivers/net/cxgb4/sge.c b/drivers/net/cxgb4/sge.c
index 311471b439a8..75a4b0fa19ee 100644
--- a/drivers/net/cxgb4/sge.c
+++ b/drivers/net/cxgb4/sge.c
@@ -1556,7 +1556,6 @@ int t4_ethrx_handler(struct sge_rspq *q, const __be64 *rsp,
 {
        bool csum_ok;
        struct sk_buff *skb;
-        struct port_info *pi;
        const struct cpl_rx_pkt *pkt;
        struct sge_eth_rxq *rxq = container_of(q, struct sge_eth_rxq, rspq);
@@ -1584,10 +1583,9 @@ int t4_ethrx_handler(struct sge_rspq *q, const __be64 *rsp,
        if (skb->dev->features & NETIF_F_RXHASH)
                skb->rxhash = (__force u32)pkt->rsshdr.hash_val;
-        pi = netdev_priv(skb->dev);
        rxq->stats.pkts++;
-        if (csum_ok && (pi->rx_offload & RX_CSO) &&
+        if (csum_ok && (q->netdev->features & NETIF_F_RXCSUM) &&
            (pkt->l2info & htonl(RXF_UDP | RXF_TCP))) {
                if (!pkt->ip_frag) {
                        skb->ip_summed = CHECKSUM_UNNECESSARY;
diff --git a/drivers/net/cxgb4vf/adapter.h b/drivers/net/cxgb4vf/adapter.h
index 4766b4116b41..4fd821aadc8a 100644
--- a/drivers/net/cxgb4vf/adapter.h
+++ b/drivers/net/cxgb4vf/adapter.h
@@ -97,17 +97,11 @@ struct port_info {
        u16 rss_size;                   /* size of VI's RSS table slice */
        u8 pidx;                        /* index into adapter port[] */
        u8 port_id;                     /* physical port ID */
-        u8 rx_offload;                  /* CSO, etc. */
        u8 nqsets;                      /* # of "Queue Sets" */
        u8 first_qset;                  /* index of first "Queue Set" */
        struct link_config link_cfg;    /* physical port configuration */
 };
-/* port_info.rx_offload flags */
-enum {
-        RX_CSO = 1 << 0,
-};
 /*
 * Scatter Gather Engine resources for the "adapter".  Our ingress and egress
 * queues are organized into "Queue Sets" with one ingress and one egress
diff --git a/drivers/net/cxgb4vf/cxgb4vf_main.c b/drivers/net/cxgb4vf/cxgb4vf_main.c
index 4661cbbd9bd9..e71c08e547e4 100644
--- a/drivers/net/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/cxgb4vf/cxgb4vf_main.c
@@ -1167,7 +1167,8 @@ static int cxgb4vf_get_settings(struct net_device *dev,
        cmd->supported = pi->link_cfg.supported;
        cmd->advertising = pi->link_cfg.advertising;
-        cmd->speed = netif_carrier_ok(dev) ? pi->link_cfg.speed : -1;
+        ethtool_cmd_speed_set(cmd,
+                              netif_carrier_ok(dev) ? pi->link_cfg.speed : -1);
        cmd->duplex = DUPLEX_FULL;
        cmd->port = (cmd->supported & SUPPORTED_TP) ? PORT_TP : PORT_FIBRE;
@@ -1326,37 +1327,22 @@ static void cxgb4vf_get_pauseparam(struct net_device *dev,
 }
 /*
- * Return whether RX Checksum Offloading is currently enabled for the device.
+ * Identify the port by blinking the port's LED.
- */
-static u32 cxgb4vf_get_rx_csum(struct net_device *dev)
-{
-        struct port_info *pi = netdev_priv(dev);
-        return (pi->rx_offload & RX_CSO) != 0;
-}
-/*
- * Turn RX Checksum Offloading on or off for the device.
 */
-static int cxgb4vf_set_rx_csum(struct net_device *dev, u32 csum)
+static int cxgb4vf_phys_id(struct net_device *dev,
+                           enum ethtool_phys_id_state state)
 {
+        unsigned int val;
        struct port_info *pi = netdev_priv(dev);
-        if (csum)
+        if (state == ETHTOOL_ID_ACTIVE)
-                pi->rx_offload |= RX_CSO;
+                val = 0xffff;
+        else if (state == ETHTOOL_ID_INACTIVE)
+                val = 0;
        else
-                pi->rx_offload &= ~RX_CSO;
+                return -EINVAL;
-        return 0;
-}
-/*
- * Identify the port by blinking the port's LED.
- */
-static int cxgb4vf_phys_id(struct net_device *dev, u32 id)
-{
-        struct port_info *pi = netdev_priv(dev);
-        return t4vf_identify_port(pi->adapter, pi->viid, 5);
+        return t4vf_identify_port(pi->adapter, pi->viid, val);
 }
 /*
@@ -1560,18 +1546,6 @@ static void cxgb4vf_get_wol(struct net_device *dev,
 */
 #define TSO_FLAGS (NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN)
-/*
- * Set TCP Segmentation Offloading feature capabilities.
- */
-static int cxgb4vf_set_tso(struct net_device *dev, u32 tso)
-{
-        if (tso)
-                dev->features |= TSO_FLAGS;
-        else
-                dev->features &= ~TSO_FLAGS;
-        return 0;
-}
 static struct ethtool_ops cxgb4vf_ethtool_ops = {
        .get_settings           = cxgb4vf_get_settings,
        .get_drvinfo            = cxgb4vf_get_drvinfo,
@@ -1582,19 +1556,14 @@ static struct ethtool_ops cxgb4vf_ethtool_ops = {
        .get_coalesce           = cxgb4vf_get_coalesce,
        .set_coalesce           = cxgb4vf_set_coalesce,
        .get_pauseparam         = cxgb4vf_get_pauseparam,
-        .get_rx_csum            = cxgb4vf_get_rx_csum,
-        .set_rx_csum            = cxgb4vf_set_rx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_ipv6_csum,
-        .set_sg                 = ethtool_op_set_sg,
        .get_link               = ethtool_op_get_link,
        .get_strings            = cxgb4vf_get_strings,
-        .phys_id                = cxgb4vf_phys_id,
+        .set_phys_id            = cxgb4vf_phys_id,
        .get_sset_count         = cxgb4vf_get_sset_count,
        .get_ethtool_stats      = cxgb4vf_get_ethtool_stats,
        .get_regs_len           = cxgb4vf_get_regs_len,
        .get_regs               = cxgb4vf_get_regs,
        .get_wol                = cxgb4vf_get_wol,
-        .set_tso                = cxgb4vf_set_tso,
 };
 /*
@@ -2629,19 +2598,19 @@ static int __devinit cxgb4vf_pci_probe(struct pci_dev *pdev,
                 * it.
                 */
                pi->xact_addr_filt = -1;
-                pi->rx_offload = RX_CSO;
                netif_carrier_off(netdev);
                netdev->irq = pdev->irq;
-                netdev->features = (NETIF_F_SG | TSO_FLAGS |
+                netdev->hw_features = NETIF_F_SG | TSO_FLAGS |
-                                    NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
+                        NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
-                                    NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |
+                        NETIF_F_HW_VLAN_TX | NETIF_F_RXCSUM;
-                                    NETIF_F_GRO);
+                netdev->vlan_features = NETIF_F_SG | TSO_FLAGS |
+                        NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
+                        NETIF_F_HIGHDMA;
+                netdev->features = netdev->hw_features |
+                        NETIF_F_HW_VLAN_RX;
                if (pci_using_dac)
                        netdev->features |= NETIF_F_HIGHDMA;
-                netdev->vlan_features =
-                        (netdev->features &
-                         ~(NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX));
 #ifdef HAVE_NET_DEVICE_OPS
                netdev->netdev_ops = &cxgb4vf_netdev_ops;
diff --git a/drivers/net/cxgb4vf/sge.c b/drivers/net/cxgb4vf/sge.c
index bb65121f581c..5182960e29fd 100644
--- a/drivers/net/cxgb4vf/sge.c
+++ b/drivers/net/cxgb4vf/sge.c
@@ -1555,8 +1555,8 @@ int t4vf_ethrx_handler(struct sge_rspq *rspq, const __be64 *rsp,
        pi = netdev_priv(skb->dev);
        rxq->stats.pkts++;
-        if (csum_ok && (pi->rx_offload & RX_CSO) && !pkt->err_vec &&
+        if (csum_ok && (rspq->netdev->features & NETIF_F_RXCSUM) &&
-            (be32_to_cpu(pkt->l2info) & (RXF_UDP|RXF_TCP))) {
+            !pkt->err_vec && (be32_to_cpu(pkt->l2info) & (RXF_UDP|RXF_TCP))) {
                if (!pkt->ip_frag)
                        skb->ip_summed = CHECKSUM_UNNECESSARY;
                else {
diff --git a/drivers/net/depca.c b/drivers/net/depca.c
index 8b0084d17c8c..17654059922d 100644
--- a/drivers/net/depca.c
+++ b/drivers/net/depca.c
@@ -331,18 +331,18 @@ static struct {
                         "DE422",\
                         ""}
-static char* __initdata depca_signature[] = DEPCA_SIGNATURE;
+static const char* const depca_signature[] __devinitconst = DEPCA_SIGNATURE;
 enum depca_type {
        DEPCA, de100, de101, de200, de201, de202, de210, de212, de422, unknown
 };
-static char depca_string[] = "depca";
+static const char depca_string[] = "depca";
 static int depca_device_remove (struct device *device);
 #ifdef CONFIG_EISA
-static struct eisa_device_id depca_eisa_ids[] = {
+static const struct eisa_device_id depca_eisa_ids[] __devinitconst = {
        { "DEC4220", de422 },
        { "" }
 };
@@ -367,19 +367,19 @@ static struct eisa_driver depca_eisa_driver = {
 #define DE210_ID 0x628d
 #define DE212_ID 0x6def
-static short depca_mca_adapter_ids[] = {
+static const short depca_mca_adapter_ids[] __devinitconst = {
        DE210_ID,
        DE212_ID,
        0x0000
 };
-static char *depca_mca_adapter_name[] = {
+static const char *depca_mca_adapter_name[] = {
        "DEC EtherWORKS MC Adapter (DE210)",
        "DEC EtherWORKS MC Adapter (DE212)",
        NULL
 };
-static enum depca_type depca_mca_adapter_type[] = {
+static const enum depca_type depca_mca_adapter_type[] = {
        de210,
        de212,
        0
@@ -541,10 +541,9 @@ static void SetMulticastFilter(struct net_device *dev);
 static int load_packet(struct net_device *dev, struct sk_buff *skb);
 static void depca_dbg_open(struct net_device *dev);
-static u_char de1xx_irq[] __initdata = { 2, 3, 4, 5, 7, 9, 0 };
+static const u_char de1xx_irq[] __devinitconst = { 2, 3, 4, 5, 7, 9, 0 };
-static u_char de2xx_irq[] __initdata = { 5, 9, 10, 11, 15, 0 };
+static const u_char de2xx_irq[] __devinitconst = { 5, 9, 10, 11, 15, 0 };
-static u_char de422_irq[] __initdata = { 5, 9, 10, 11, 0 };
+static const u_char de422_irq[] __devinitconst = { 5, 9, 10, 11, 0 };
-static u_char *depca_irq;
 static int irq;
 static int io;
@@ -580,7 +579,7 @@ static const struct net_device_ops depca_netdev_ops = {
        .ndo_validate_addr      = eth_validate_addr,
 };
-static int __init depca_hw_init (struct net_device *dev, struct device *device)
+static int __devinit depca_hw_init (struct net_device *dev, struct device *device)
 {
        struct depca_private *lp;
        int i, j, offset, netRAM, mem_len, status = 0;
@@ -748,6 +747,7 @@ static int __init depca_hw_init (struct net_device *dev, struct device *device)
        if (dev->irq < 2) {
                unsigned char irqnum;
                unsigned long irq_mask, delay;
+                const u_char *depca_irq;
                irq_mask = probe_irq_on();
@@ -770,6 +770,7 @@ static int __init depca_hw_init (struct net_device *dev, struct device *device)
                        break;
                default:
+                        depca_irq = NULL;
                        break;  /* Not reached */
                }
@@ -1302,7 +1303,7 @@ static void SetMulticastFilter(struct net_device *dev)
        }
 }
-static int __init depca_common_init (u_long ioaddr, struct net_device **devp)
+static int __devinit depca_common_init (u_long ioaddr, struct net_device **devp)
 {
        int status = 0;
@@ -1333,7 +1334,7 @@ static int __init depca_common_init (u_long ioaddr, struct net_device **devp)
 /*
 ** Microchannel bus I/O device probe
 */
-static int __init depca_mca_probe(struct device *device)
+static int __devinit depca_mca_probe(struct device *device)
 {
        unsigned char pos[2];
        unsigned char where;
@@ -1457,7 +1458,7 @@ static int __init depca_mca_probe(struct device *device)
 ** ISA bus I/O device probe
 */
-static void __init depca_platform_probe (void)
+static void __devinit depca_platform_probe (void)
 {
        int i;
        struct platform_device *pldev;
@@ -1497,7 +1498,7 @@ static void __init depca_platform_probe (void)
        }
 }
-static enum depca_type __init depca_shmem_probe (ulong *mem_start)
+static enum depca_type __devinit depca_shmem_probe (ulong *mem_start)
 {
        u_long mem_base[] = DEPCA_RAM_BASE_ADDRESSES;
        enum depca_type adapter = unknown;
@@ -1558,7 +1559,7 @@ static int __devinit depca_isa_probe (struct platform_device *device)
 */
 #ifdef CONFIG_EISA
-static int __init depca_eisa_probe (struct device *device)
+static int __devinit depca_eisa_probe (struct device *device)
 {
        enum depca_type adapter = unknown;
        struct eisa_device *edev;
@@ -1629,7 +1630,7 @@ static int __devexit depca_device_remove (struct device *device)
 ** and Boot (readb) ROM. This will also give us a clue to the network RAM
 ** base address.
 */
-static int __init DepcaSignature(char *name, u_long base_addr)
+static int __devinit DepcaSignature(char *name, u_long base_addr)
 {
        u_int i, j, k;
        void __iomem *ptr;
diff --git a/drivers/net/dl2k.c b/drivers/net/dl2k.c
index c05db6046050..c445457b66d5 100644
--- a/drivers/net/dl2k.c
+++ b/drivers/net/dl2k.c
@@ -1189,10 +1189,10 @@ static int rio_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                cmd->transceiver = XCVR_INTERNAL;
        }
        if ( np->link_status ) {
-                cmd->speed = np->speed;
+                ethtool_cmd_speed_set(cmd, np->speed);
                cmd->duplex = np->full_duplex ? DUPLEX_FULL : DUPLEX_HALF;
        } else {
-                cmd->speed = -1;
+                ethtool_cmd_speed_set(cmd, -1);
                cmd->duplex = -1;
        }
        if ( np->an_enable)
@@ -1219,31 +1219,20 @@ static int rio_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        } else {
                np->an_enable = 0;
                if (np->speed == 1000) {
-                        cmd->speed = SPEED_100;
+                        ethtool_cmd_speed_set(cmd, SPEED_100);
                        cmd->duplex = DUPLEX_FULL;
                        printk("Warning!! Can't disable Auto negotiation in 1000Mbps, change to Manual 100Mbps, Full duplex.\n");
                }
-                switch(cmd->speed + cmd->duplex) {
+                switch (ethtool_cmd_speed(cmd)) {
+                case SPEED_10:
-                case SPEED_10 + DUPLEX_HALF:
-                        np->speed = 10;
-                        np->full_duplex = 0;
-                        break;
-                case SPEED_10 + DUPLEX_FULL:
                        np->speed = 10;
-                        np->full_duplex = 1;
+                        np->full_duplex = (cmd->duplex == DUPLEX_FULL);
                        break;
-                case SPEED_100 + DUPLEX_HALF:
+                case SPEED_100:
                        np->speed = 100;
-                        np->full_duplex = 0;
+                        np->full_duplex = (cmd->duplex == DUPLEX_FULL);
-                        break;
-                case SPEED_100 + DUPLEX_FULL:
-                        np->speed = 100;
-                        np->full_duplex = 1;
                        break;
-                case SPEED_1000 + DUPLEX_HALF:/* not supported */
+                case SPEED_1000: /* not supported */
-                case SPEED_1000 + DUPLEX_FULL:/* not supported */
                default:
                        return -EINVAL;
                }
diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
index b7af5bab9937..fbaff3584bd4 100644
--- a/drivers/net/dm9000.c
+++ b/drivers/net/dm9000.c
@@ -131,8 +131,6 @@ typedef struct board_info {
        u32             msg_enable;
        u32             wake_state;
-        int             rx_csum;
-        int             can_csum;
        int             ip_summed;
 } board_info_t;
@@ -470,47 +468,20 @@ static int dm9000_nway_reset(struct net_device *dev)
        return mii_nway_restart(&dm->mii);
 }
-static uint32_t dm9000_get_rx_csum(struct net_device *dev)
+static int dm9000_set_features(struct net_device *dev, u32 features)
 {
        board_info_t *dm = to_dm9000_board(dev);
-        return dm->rx_csum;
+        u32 changed = dev->features ^ features;
-}
+        unsigned long flags;
-static int dm9000_set_rx_csum_unlocked(struct net_device *dev, uint32_t data)
-{
-        board_info_t *dm = to_dm9000_board(dev);
-        if (dm->can_csum) {
-                dm->rx_csum = data;
-                iow(dm, DM9000_RCSR, dm->rx_csum ? RCSR_CSUM : 0);
+        if (!(changed & NETIF_F_RXCSUM))
                return 0;
-        }
-        return -EOPNOTSUPP;
-}
-static int dm9000_set_rx_csum(struct net_device *dev, uint32_t data)
-{
-        board_info_t *dm = to_dm9000_board(dev);
-        unsigned long flags;
-        int ret;
        spin_lock_irqsave(&dm->lock, flags);
-        ret = dm9000_set_rx_csum_unlocked(dev, data);
+        iow(dm, DM9000_RCSR, (features & NETIF_F_RXCSUM) ? RCSR_CSUM : 0);
        spin_unlock_irqrestore(&dm->lock, flags);
-        return ret;
+        return 0;
-}
-static int dm9000_set_tx_csum(struct net_device *dev, uint32_t data)
-{
-        board_info_t *dm = to_dm9000_board(dev);
-        int ret = -EOPNOTSUPP;
-        if (dm->can_csum)
-                ret = ethtool_op_set_tx_csum(dev, data);
-        return ret;
 }
 static u32 dm9000_get_link(struct net_device *dev)
@@ -643,10 +614,6 @@ static const struct ethtool_ops dm9000_ethtool_ops = {
        .get_eeprom_len         = dm9000_get_eeprom_len,
        .get_eeprom             = dm9000_get_eeprom,
        .set_eeprom             = dm9000_set_eeprom,
-        .get_rx_csum            = dm9000_get_rx_csum,
-        .set_rx_csum            = dm9000_set_rx_csum,
-        .get_tx_csum            = ethtool_op_get_tx_csum,
-        .set_tx_csum            = dm9000_set_tx_csum,
 };
 static void dm9000_show_carrier(board_info_t *db,
@@ -800,7 +767,9 @@ dm9000_init_dm9000(struct net_device *dev)
        db->io_mode = ior(db, DM9000_ISR) >> 6; /* ISR bit7:6 keeps I/O mode */
        /* Checksum mode */
-        dm9000_set_rx_csum_unlocked(dev, db->rx_csum);
+        if (dev->hw_features & NETIF_F_RXCSUM)
+                iow(db, DM9000_RCSR,
+                        (dev->features & NETIF_F_RXCSUM) ? RCSR_CSUM : 0);
        iow(db, DM9000_GPCR, GPCR_GEP_CNTL);    /* Let GPIO0 output */
@@ -1049,7 +1018,7 @@ dm9000_rx(struct net_device *dev)
                        /* Pass to upper layer */
                        skb->protocol = eth_type_trans(skb, dev);
-                        if (db->rx_csum) {
+                        if (dev->features & NETIF_F_RXCSUM) {
                                if ((((rxbyte & 0x1c) << 3) & rxbyte) == 0)
                                        skb->ip_summed = CHECKSUM_UNNECESSARY;
                                else
@@ -1358,6 +1327,7 @@ static const struct net_device_ops dm9000_netdev_ops = {
        .ndo_set_multicast_list = dm9000_hash_table,
        .ndo_do_ioctl           = dm9000_ioctl,
        .ndo_change_mtu         = eth_change_mtu,
+        .ndo_set_features       = dm9000_set_features,
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_set_mac_address    = eth_mac_addr,
 #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -1551,9 +1521,8 @@ dm9000_probe(struct platform_device *pdev)
        /* dm9000a/b are capable of hardware checksum offload */
        if (db->type == TYPE_DM9000A || db->type == TYPE_DM9000B) {
-                db->can_csum = 1;
+                ndev->hw_features = NETIF_F_RXCSUM | NETIF_F_IP_CSUM;
-                db->rx_csum = 1;
+                ndev->features |= ndev->hw_features;
-                ndev->features |= NETIF_F_IP_CSUM;
        }
        /* from this point we assume that we have found a DM9000 */
diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c
index ff2d29b17858..39cf9b9bd673 100644
--- a/drivers/net/dummy.c
+++ b/drivers/net/dummy.c
@@ -168,10 +168,6 @@ static int __init dummy_init_one(void)
        if (!dev_dummy)
                return -ENOMEM;
-        err = dev_alloc_name(dev_dummy, dev_dummy->name);
-        if (err < 0)
-                goto err;
        dev_dummy->rtnl_link_ops = &dummy_link_ops;
        err = register_netdevice(dev_dummy);
        if (err < 0)
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index b0aa9e68990a..e336c7937f05 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -593,7 +593,6 @@ struct nic {
        enum phy phy;
        struct params params;
        struct timer_list watchdog;
-        struct timer_list blink_timer;
        struct mii_if_info mii;
        struct work_struct tx_timeout_task;
        enum loopback loopback;
@@ -618,7 +617,6 @@ struct nic {
        u32 rx_tco_frames;
        u32 rx_over_length_errors;
-        u16 leds;
        u16 eeprom_wc;
        __le16 eeprom[256];
        spinlock_t mdio_lock;
@@ -1512,7 +1510,7 @@ static int e100_phy_init(struct nic *nic)
 static int e100_hw_init(struct nic *nic)
 {
-        int err;
+        int err = 0;
        e100_hw_reset(nic);
@@ -1668,7 +1666,8 @@ static void e100_adjust_adaptive_ifs(struct nic *nic, int speed, int duplex)
 static void e100_watchdog(unsigned long data)
 {
        struct nic *nic = (struct nic *)data;
-        struct ethtool_cmd cmd;
+        struct ethtool_cmd cmd = { .cmd = ETHTOOL_GSET };
+        u32 speed;
        netif_printk(nic, timer, KERN_DEBUG, nic->netdev,
                     "right now = %ld\n", jiffies);
@@ -1676,10 +1675,11 @@ static void e100_watchdog(unsigned long data)
        /* mii library handles link maintenance tasks */
        mii_ethtool_gset(&nic->mii, &cmd);
+        speed = ethtool_cmd_speed(&cmd);
        if (mii_link_ok(&nic->mii) && !netif_carrier_ok(nic->netdev)) {
                netdev_info(nic->netdev, "NIC Link is Up %u Mbps %s Duplex\n",
-                            cmd.speed == SPEED_100 ? 100 : 10,
+                            speed == SPEED_100 ? 100 : 10,
                            cmd.duplex == DUPLEX_FULL ? "Full" : "Half");
        } else if (!mii_link_ok(&nic->mii) && netif_carrier_ok(nic->netdev)) {
                netdev_info(nic->netdev, "NIC Link is Down\n");
@@ -1698,13 +1698,13 @@ static void e100_watchdog(unsigned long data)
        spin_unlock_irq(&nic->cmd_lock);
        e100_update_stats(nic);
-        e100_adjust_adaptive_ifs(nic, cmd.speed, cmd.duplex);
+        e100_adjust_adaptive_ifs(nic, speed, cmd.duplex);
        if (nic->mac <= mac_82557_D100_C)
                /* Issue a multicast command to workaround a 557 lock up */
                e100_set_multicast_list(nic->netdev);
-        if (nic->flags & ich && cmd.speed==SPEED_10 && cmd.duplex==DUPLEX_HALF)
+        if (nic->flags & ich && speed == SPEED_10 && cmd.duplex == DUPLEX_HALF)
                /* Need SW workaround for ICH[x] 10Mbps/half duplex Tx hang. */
                nic->flags |= ich_10h_workaround;
        else
@@ -2351,30 +2351,6 @@ err_clean_rx:
 #define E100_82552_LED_OVERRIDE 0x19
 #define E100_82552_LED_ON       0x000F /* LEDTX and LED_RX both on */
 #define E100_82552_LED_OFF      0x000A /* LEDTX and LED_RX both off */
-static void e100_blink_led(unsigned long data)
-{
-        struct nic *nic = (struct nic *)data;
-        enum led_state {
-                led_on     = 0x01,
-                led_off    = 0x04,
-                led_on_559 = 0x05,
-                led_on_557 = 0x07,
-        };
-        u16 led_reg = MII_LED_CONTROL;
-        if (nic->phy == phy_82552_v) {
-                led_reg = E100_82552_LED_OVERRIDE;
-                nic->leds = (nic->leds == E100_82552_LED_ON) ?
-                            E100_82552_LED_OFF : E100_82552_LED_ON;
-        } else {
-                nic->leds = (nic->leds & led_on) ? led_off :
-                            (nic->mac < mac_82559_D101M) ? led_on_557 :
-                            led_on_559;
-        }
-        mdio_write(nic->netdev, nic->mii.phy_id, led_reg, nic->leds);
-        mod_timer(&nic->blink_timer, jiffies + HZ / 4);
-}
 static int e100_get_settings(struct net_device *netdev, struct ethtool_cmd *cmd)
 {
@@ -2598,19 +2574,38 @@ static void e100_diag_test(struct net_device *netdev,
        msleep_interruptible(4 * 1000);
 }
-static int e100_phys_id(struct net_device *netdev, u32 data)
+static int e100_set_phys_id(struct net_device *netdev,
+                            enum ethtool_phys_id_state state)
 {
        struct nic *nic = netdev_priv(netdev);
+        enum led_state {
+                led_on     = 0x01,
+                led_off    = 0x04,
+                led_on_559 = 0x05,
+                led_on_557 = 0x07,
+        };
        u16 led_reg = (nic->phy == phy_82552_v) ? E100_82552_LED_OVERRIDE :
-                      MII_LED_CONTROL;
+                MII_LED_CONTROL;
+        u16 leds = 0;
-        if (!data || data > (u32)(MAX_SCHEDULE_TIMEOUT / HZ))
+        switch (state) {
-                data = (u32)(MAX_SCHEDULE_TIMEOUT / HZ);
+        case ETHTOOL_ID_ACTIVE:
-        mod_timer(&nic->blink_timer, jiffies);
+                return 2;
-        msleep_interruptible(data * 1000);
-        del_timer_sync(&nic->blink_timer);
+        case ETHTOOL_ID_ON:
-        mdio_write(netdev, nic->mii.phy_id, led_reg, 0);
+                leds = (nic->phy == phy_82552_v) ? E100_82552_LED_ON :
+                       (nic->mac < mac_82559_D101M) ? led_on_557 : led_on_559;
+                break;
+        case ETHTOOL_ID_OFF:
+                leds = (nic->phy == phy_82552_v) ? E100_82552_LED_OFF : led_off;
+                break;
+        case ETHTOOL_ID_INACTIVE:
+                break;
+        }
+        mdio_write(netdev, nic->mii.phy_id, led_reg, leds);
        return 0;
 }
@@ -2691,7 +2686,7 @@ static const struct ethtool_ops e100_ethtool_ops = {
        .set_ringparam          = e100_set_ringparam,
        .self_test              = e100_diag_test,
        .get_strings            = e100_get_strings,
-        .phys_id                = e100_phys_id,
+        .set_phys_id            = e100_set_phys_id,
        .get_ethtool_stats      = e100_get_ethtool_stats,
        .get_sset_count         = e100_get_sset_count,
 };
@@ -2832,9 +2827,6 @@ static int __devinit e100_probe(struct pci_dev *pdev,
        init_timer(&nic->watchdog);
        nic->watchdog.function = e100_watchdog;
        nic->watchdog.data = (unsigned long)nic;
-        init_timer(&nic->blink_timer);
-        nic->blink_timer.function = e100_blink_led;
-        nic->blink_timer.data = (unsigned long)nic;
        INIT_WORK(&nic->tx_timeout_task, e100_tx_timeout_task);
diff --git a/drivers/net/e1000/e1000.h b/drivers/net/e1000/e1000.h
index a881dd0093bd..8676899120c3 100644
--- a/drivers/net/e1000/e1000.h
+++ b/drivers/net/e1000/e1000.h
@@ -238,9 +238,6 @@ struct e1000_adapter {
        struct work_struct reset_task;
        u8 fc_autoneg;
-        struct timer_list blink_timer;
-        unsigned long led_status;
        /* TX */
        struct e1000_tx_ring *tx_ring;      /* One per active queue */
        unsigned int restart_queue;
@@ -349,7 +346,7 @@ extern int e1000_up(struct e1000_adapter *adapter);
 extern void e1000_down(struct e1000_adapter *adapter);
 extern void e1000_reinit_locked(struct e1000_adapter *adapter);
 extern void e1000_reset(struct e1000_adapter *adapter);
-extern int e1000_set_spd_dplx(struct e1000_adapter *adapter, u16 spddplx);
+extern int e1000_set_spd_dplx(struct e1000_adapter *adapter, u32 spd, u8 dplx);
 extern int e1000_setup_all_rx_resources(struct e1000_adapter *adapter);
 extern int e1000_setup_all_tx_resources(struct e1000_adapter *adapter);
 extern void e1000_free_all_rx_resources(struct e1000_adapter *adapter);
diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c
index dd70738eb2f4..ec0fa426cce2 100644
--- a/drivers/net/e1000/e1000_ethtool.c
+++ b/drivers/net/e1000/e1000_ethtool.c
@@ -158,7 +158,7 @@ static int e1000_get_settings(struct net_device *netdev,
                e1000_get_speed_and_duplex(hw, &adapter->link_speed,
                                                   &adapter->link_duplex);
-                ecmd->speed = adapter->link_speed;
+                ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                /* unfortunately FULL_DUPLEX != DUPLEX_FULL
                 *          and HALF_DUPLEX != DUPLEX_HALF */
@@ -168,7 +168,7 @@ static int e1000_get_settings(struct net_device *netdev,
                else
                        ecmd->duplex = DUPLEX_HALF;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
@@ -197,11 +197,13 @@ static int e1000_set_settings(struct net_device *netdev,
                                                 ADVERTISED_TP |
                                                 ADVERTISED_Autoneg;
                ecmd->advertising = hw->autoneg_advertised;
-        } else
+        } else {
-                if (e1000_set_spd_dplx(adapter, ecmd->speed + ecmd->duplex)) {
+                u32 speed = ethtool_cmd_speed(ecmd);
+                if (e1000_set_spd_dplx(adapter, speed, ecmd->duplex)) {
                        clear_bit(__E1000_RESETTING, &adapter->flags);
                        return -EINVAL;
                }
+        }
        /* reset the link */
@@ -1753,46 +1755,28 @@ static int e1000_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
        return 0;
 }
-/* toggle LED 4 times per second = 2 "blinks" per second */
+static int e1000_set_phys_id(struct net_device *netdev,
-#define E1000_ID_INTERVAL       (HZ/4)
+                             enum ethtool_phys_id_state state)
-/* bit defines for adapter->led_status */
-#define E1000_LED_ON            0
-static void e1000_led_blink_callback(unsigned long data)
 {
-        struct e1000_adapter *adapter = (struct e1000_adapter *) data;
+        struct e1000_adapter *adapter = netdev_priv(netdev);
        struct e1000_hw *hw = &adapter->hw;
-        if (test_and_change_bit(E1000_LED_ON, &adapter->led_status))
+        switch (state) {
-                e1000_led_off(hw);
+        case ETHTOOL_ID_ACTIVE:
-        else
+                e1000_setup_led(hw);
-                e1000_led_on(hw);
+                return 2;
-        mod_timer(&adapter->blink_timer, jiffies + E1000_ID_INTERVAL);
+        case ETHTOOL_ID_ON:
-}
+                e1000_led_on(hw);
+                break;
-static int e1000_phys_id(struct net_device *netdev, u32 data)
-{
-        struct e1000_adapter *adapter = netdev_priv(netdev);
-        struct e1000_hw *hw = &adapter->hw;
-        if (!data)
+        case ETHTOOL_ID_OFF:
-                data = INT_MAX;
+                e1000_led_off(hw);
+                break;
-        if (!adapter->blink_timer.function) {
+        case ETHTOOL_ID_INACTIVE:
-                init_timer(&adapter->blink_timer);
+                e1000_cleanup_led(hw);
-                adapter->blink_timer.function = e1000_led_blink_callback;
-                adapter->blink_timer.data = (unsigned long)adapter;
        }
-        e1000_setup_led(hw);
-        mod_timer(&adapter->blink_timer, jiffies);
-        msleep_interruptible(data * 1000);
-        del_timer_sync(&adapter->blink_timer);
-        e1000_led_off(hw);
-        clear_bit(E1000_LED_ON, &adapter->led_status);
-        e1000_cleanup_led(hw);
        return 0;
 }
@@ -1929,7 +1913,7 @@ static const struct ethtool_ops e1000_ethtool_ops = {
        .set_tso                = e1000_set_tso,
        .self_test              = e1000_diag_test,
        .get_strings            = e1000_get_strings,
-        .phys_id                = e1000_phys_id,
+        .set_phys_id            = e1000_set_phys_id,
        .get_ethtool_stats      = e1000_get_ethtool_stats,
        .get_sset_count         = e1000_get_sset_count,
        .get_coalesce           = e1000_get_coalesce,
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 477e066a1cf0..c18cb8e883dd 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -96,7 +96,6 @@ int e1000_up(struct e1000_adapter *adapter);
 void e1000_down(struct e1000_adapter *adapter);
 void e1000_reinit_locked(struct e1000_adapter *adapter);
 void e1000_reset(struct e1000_adapter *adapter);
-int e1000_set_spd_dplx(struct e1000_adapter *adapter, u16 spddplx);
 int e1000_setup_all_tx_resources(struct e1000_adapter *adapter);
 int e1000_setup_all_rx_resources(struct e1000_adapter *adapter);
 void e1000_free_all_tx_resources(struct e1000_adapter *adapter);
@@ -4385,7 +4384,6 @@ static int e1000_mii_ioctl(struct net_device *netdev, struct ifreq *ifr,
        struct mii_ioctl_data *data = if_mii(ifr);
        int retval;
        u16 mii_reg;
-        u16 spddplx;
        unsigned long flags;
        if (hw->media_type != e1000_media_type_copper)
@@ -4424,17 +4422,18 @@ static int e1000_mii_ioctl(struct net_device *netdev, struct ifreq *ifr,
                                        hw->autoneg = 1;
                                        hw->autoneg_advertised = 0x2F;
                                } else {
+                                        u32 speed;
                                        if (mii_reg & 0x40)
-                                                spddplx = SPEED_1000;
+                                                speed = SPEED_1000;
                                        else if (mii_reg & 0x2000)
-                                                spddplx = SPEED_100;
+                                                speed = SPEED_100;
                                        else
-                                                spddplx = SPEED_10;
+                                                speed = SPEED_10;
-                                        spddplx += (mii_reg & 0x100)
+                                        retval = e1000_set_spd_dplx(
-                                                   ? DUPLEX_FULL :
+                                                adapter, speed,
-                                                   DUPLEX_HALF;
+                                                ((mii_reg & 0x100)
-                                        retval = e1000_set_spd_dplx(adapter,
+                                                 ? DUPLEX_FULL :
-                                                                    spddplx);
+                                                 DUPLEX_HALF));
                                        if (retval)
                                                return retval;
                                }
@@ -4596,20 +4595,24 @@ static void e1000_restore_vlan(struct e1000_adapter *adapter)
        }
 }
-int e1000_set_spd_dplx(struct e1000_adapter *adapter, u16 spddplx)
+int e1000_set_spd_dplx(struct e1000_adapter *adapter, u32 spd, u8 dplx)
 {
        struct e1000_hw *hw = &adapter->hw;
        hw->autoneg = 0;
+        /* Make sure dplx is at most 1 bit and lsb of speed is not set
+         * for the switch() below to work */
+        if ((spd & 1) || (dplx & ~1))
+                goto err_inval;
        /* Fiber NICs only allow 1000 gbps Full duplex */
        if ((hw->media_type == e1000_media_type_fiber) &&
-                spddplx != (SPEED_1000 + DUPLEX_FULL)) {
+            spd != SPEED_1000 &&
-                e_err(probe, "Unsupported Speed/Duplex configuration\n");
+            dplx != DUPLEX_FULL)
-                return -EINVAL;
+                goto err_inval;
-        }
-        switch (spddplx) {
+        switch (spd + dplx) {
        case SPEED_10 + DUPLEX_HALF:
                hw->forced_speed_duplex = e1000_10_half;
                break;
@@ -4628,10 +4631,13 @@ int e1000_set_spd_dplx(struct e1000_adapter *adapter, u16 spddplx)
                break;
        case SPEED_1000 + DUPLEX_HALF: /* not supported */
        default:
-                e_err(probe, "Unsupported Speed/Duplex configuration\n");
+                goto err_inval;
-                return -EINVAL;
        }
        return 0;
+err_inval:
+        e_err(probe, "Unsupported Speed/Duplex configuration\n");
+        return -EINVAL;
 }
 static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake)
diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c
index 89a69035e538..8295f2192439 100644
--- a/drivers/net/e1000e/82571.c
+++ b/drivers/net/e1000e/82571.c
@@ -300,6 +300,7 @@ static s32 e1000_init_mac_params_82571(struct e1000_adapter *adapter)
                func->set_lan_id = e1000_set_lan_id_single_port;
                func->check_mng_mode = e1000e_check_mng_mode_generic;
                func->led_on = e1000e_led_on_generic;
+                func->blink_led = e1000e_blink_led_generic;
                /* FWSM register */
                mac->has_fwsm = true;
@@ -320,6 +321,7 @@ static s32 e1000_init_mac_params_82571(struct e1000_adapter *adapter)
        default:
                func->check_mng_mode = e1000e_check_mng_mode_generic;
                func->led_on = e1000e_led_on_generic;
+                func->blink_led = e1000e_blink_led_generic;
                /* FWSM register */
                mac->has_fwsm = true;
@@ -431,9 +433,6 @@ static s32 e1000_get_variants_82571(struct e1000_adapter *adapter)
        case e1000_82573:
        case e1000_82574:
        case e1000_82583:
-                /* Disable ASPM L0s due to hardware errata */
-                e1000e_disable_aspm(adapter->pdev, PCIE_LINK_STATE_L0S);
                if (pdev->device == E1000_DEV_ID_82573L) {
                        adapter->flags |= FLAG_HAS_JUMBO_FRAMES;
                        adapter->max_hw_frame_size = DEFAULT_JUMBO;
@@ -594,7 +593,7 @@ static s32 e1000_get_hw_semaphore_82573(struct e1000_hw *hw)
                extcnf_ctrl |= E1000_EXTCNF_CTRL_MDIO_SW_OWNERSHIP;
-                msleep(2);
+                usleep_range(2000, 4000);
                i++;
        } while (i < MDIO_OWNERSHIP_TIMEOUT);
@@ -816,7 +815,7 @@ static s32 e1000_update_nvm_checksum_82571(struct e1000_hw *hw)
        /* Check for pending operations. */
        for (i = 0; i < E1000_FLASH_UPDATES; i++) {
-                msleep(1);
+                usleep_range(1000, 2000);
                if ((er32(EECD) & E1000_EECD_FLUPD) == 0)
                        break;
        }
@@ -840,7 +839,7 @@ static s32 e1000_update_nvm_checksum_82571(struct e1000_hw *hw)
        ew32(EECD, eecd);
        for (i = 0; i < E1000_FLASH_UPDATES; i++) {
-                msleep(1);
+                usleep_range(1000, 2000);
                if ((er32(EECD) & E1000_EECD_FLUPD) == 0)
                        break;
        }
@@ -930,7 +929,7 @@ static s32 e1000_get_cfg_done_82571(struct e1000_hw *hw)
                if (er32(EEMNGCTL) &
                    E1000_NVM_CFG_DONE_PORT_0)
                        break;
-                msleep(1);
+                usleep_range(1000, 2000);
                timeout--;
        }
        if (!timeout) {
@@ -1037,7 +1036,7 @@ static s32 e1000_reset_hw_82571(struct e1000_hw *hw)
        ew32(TCTL, E1000_TCTL_PSP);
        e1e_flush();
-        msleep(10);
+        usleep_range(10000, 20000);
        /*
         * Must acquire the MDIO ownership before MAC reset.
@@ -2066,7 +2065,8 @@ struct e1000_info e1000_82573_info = {
                                  | FLAG_HAS_SMART_POWER_DOWN
                                  | FLAG_HAS_AMT
                                  | FLAG_HAS_SWSM_ON_LOAD,
-        .flags2                 = FLAG2_DISABLE_ASPM_L1,
+        .flags2                 = FLAG2_DISABLE_ASPM_L1
+                                  | FLAG2_DISABLE_ASPM_L0S,
        .pba                    = 20,
        .max_hw_frame_size      = ETH_FRAME_LEN + ETH_FCS_LEN,
        .get_variants           = e1000_get_variants_82571,
@@ -2086,7 +2086,8 @@ struct e1000_info e1000_82574_info = {
                                  | FLAG_HAS_SMART_POWER_DOWN
                                  | FLAG_HAS_AMT
                                  | FLAG_HAS_CTRLEXT_ON_LOAD,
-        .flags2                   = FLAG2_CHECK_PHY_HANG,
+        .flags2                   = FLAG2_CHECK_PHY_HANG
+                                  | FLAG2_DISABLE_ASPM_L0S,
        .pba                    = 32,
        .max_hw_frame_size      = DEFAULT_JUMBO,
        .get_variants           = e1000_get_variants_82571,
@@ -2104,6 +2105,7 @@ struct e1000_info e1000_82583_info = {
                                  | FLAG_HAS_SMART_POWER_DOWN
                                  | FLAG_HAS_AMT
                                  | FLAG_HAS_CTRLEXT_ON_LOAD,
+        .flags2                 = FLAG2_DISABLE_ASPM_L0S,
        .pba                    = 32,
        .max_hw_frame_size      = ETH_FRAME_LEN + ETH_FCS_LEN,
        .get_variants           = e1000_get_variants_82571,
diff --git a/drivers/net/e1000e/e1000.h b/drivers/net/e1000e/e1000.h
index 00bf595ebd67..9549879e66a0 100644
--- a/drivers/net/e1000e/e1000.h
+++ b/drivers/net/e1000e/e1000.h
@@ -31,6 +31,7 @@
 #ifndef _E1000_H_
 #define _E1000_H_
+#include <linux/bitops.h>
 #include <linux/types.h>
 #include <linux/timer.h>
 #include <linux/workqueue.h>
@@ -39,6 +40,7 @@
 #include <linux/pci.h>
 #include <linux/pci-aspm.h>
 #include <linux/crc32.h>
+#include <linux/if_vlan.h>
 #include "hw.h"
@@ -280,7 +282,7 @@ struct e1000_adapter {
        const struct e1000_info *ei;
-        struct vlan_group *vlgrp;
+        unsigned long active_vlans[BITS_TO_LONGS(VLAN_N_VID)];
        u32 bd_number;
        u32 rx_buffer_len;
        u16 mng_vlan_id;
@@ -389,13 +391,10 @@ struct e1000_adapter {
        bool fc_autoneg;
-        unsigned long led_status;
        unsigned int flags;
        unsigned int flags2;
        struct work_struct downshift_task;
        struct work_struct update_phy_task;
-        struct work_struct led_blink_task;
        struct work_struct print_hang_task;
        bool idle_check;
@@ -456,6 +455,7 @@ struct e1000_info {
 #define FLAG2_HAS_PHY_STATS               (1 << 4)
 #define FLAG2_HAS_EEE                     (1 << 5)
 #define FLAG2_DMA_BURST                   (1 << 6)
+#define FLAG2_DISABLE_ASPM_L0S            (1 << 7)
 #define FLAG2_DISABLE_AIM                 (1 << 8)
 #define FLAG2_CHECK_PHY_HANG              (1 << 9)
@@ -484,7 +484,6 @@ extern const char e1000e_driver_version[];
 extern void e1000e_check_options(struct e1000_adapter *adapter);
 extern void e1000e_set_ethtool_ops(struct net_device *netdev);
-extern void e1000e_led_blink_task(struct work_struct *work);
 extern int e1000e_up(struct e1000_adapter *adapter);
 extern void e1000e_down(struct e1000_adapter *adapter);
@@ -502,7 +501,6 @@ extern void e1000e_set_interrupt_capability(struct e1000_adapter *adapter);
 extern void e1000e_reset_interrupt_capability(struct e1000_adapter *adapter);
 extern void e1000e_get_hw_control(struct e1000_adapter *adapter);
 extern void e1000e_release_hw_control(struct e1000_adapter *adapter);
-extern void e1000e_disable_aspm(struct pci_dev *pdev, u16 state);
 extern unsigned int copybreak;
@@ -573,7 +571,7 @@ extern s32 e1000e_valid_led_default(struct e1000_hw *hw, u16 *data);
 extern void e1000e_config_collision_dist(struct e1000_hw *hw);
 extern s32 e1000e_config_fc_after_link_up(struct e1000_hw *hw);
 extern s32 e1000e_force_mac_fc(struct e1000_hw *hw);
-extern s32 e1000e_blink_led(struct e1000_hw *hw);
+extern s32 e1000e_blink_led_generic(struct e1000_hw *hw);
 extern void e1000_write_vfta_generic(struct e1000_hw *hw, u32 offset, u32 value);
 extern s32 e1000_check_alt_mac_addr_generic(struct e1000_hw *hw);
 extern void e1000e_reset_adaptive(struct e1000_hw *hw);
diff --git a/drivers/net/e1000e/es2lan.c b/drivers/net/e1000e/es2lan.c
index 2fefa820302b..f4bbeb22f51f 100644
--- a/drivers/net/e1000e/es2lan.c
+++ b/drivers/net/e1000e/es2lan.c
@@ -612,7 +612,7 @@ static s32 e1000_get_cfg_done_80003es2lan(struct e1000_hw *hw)
        while (timeout) {
                if (er32(EEMNGCTL) & mask)
                        break;
-                msleep(1);
+                usleep_range(1000, 2000);
                timeout--;
        }
        if (!timeout) {
@@ -802,7 +802,7 @@ static s32 e1000_reset_hw_80003es2lan(struct e1000_hw *hw)
        ew32(TCTL, E1000_TCTL_PSP);
        e1e_flush();
-        msleep(10);
+        usleep_range(10000, 20000);
        ctrl = er32(CTRL);
@@ -1434,6 +1434,7 @@ static void e1000_clear_hw_cntrs_80003es2lan(struct e1000_hw *hw)
 static struct e1000_mac_operations es2_mac_ops = {
        .read_mac_addr          = e1000_read_mac_addr_80003es2lan,
        .id_led_init            = e1000e_id_led_init,
+        .blink_led              = e1000e_blink_led_generic,
        .check_mng_mode         = e1000e_check_mng_mode_generic,
        /* check_for_link dependent on media type */
        .cleanup_led            = e1000e_cleanup_led_generic,
diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c
index 07f09e96e453..859d0d3af6c9 100644
--- a/drivers/net/e1000e/ethtool.c
+++ b/drivers/net/e1000e/ethtool.c
@@ -122,6 +122,7 @@ static int e1000_get_settings(struct net_device *netdev,
 {
        struct e1000_adapter *adapter = netdev_priv(netdev);
        struct e1000_hw *hw = &adapter->hw;
+        u32 speed;
        if (hw->phy.media_type == e1000_media_type_copper) {
@@ -159,23 +160,23 @@ static int e1000_get_settings(struct net_device *netdev,
                ecmd->transceiver = XCVR_EXTERNAL;
        }
-        ecmd->speed = -1;
+        speed = -1;
        ecmd->duplex = -1;
        if (netif_running(netdev)) {
                if (netif_carrier_ok(netdev)) {
-                        ecmd->speed = adapter->link_speed;
+                        speed = adapter->link_speed;
                        ecmd->duplex = adapter->link_duplex - 1;
                }
        } else {
                u32 status = er32(STATUS);
                if (status & E1000_STATUS_LU) {
                        if (status & E1000_STATUS_SPEED_1000)
-                                ecmd->speed = 1000;
+                                speed = SPEED_1000;
                        else if (status & E1000_STATUS_SPEED_100)
-                                ecmd->speed = 100;
+                                speed = SPEED_100;
                        else
-                                ecmd->speed = 10;
+                                speed = SPEED_10;
                        if (status & E1000_STATUS_FD)
                                ecmd->duplex = DUPLEX_FULL;
@@ -184,6 +185,7 @@ static int e1000_get_settings(struct net_device *netdev,
                }
        }
+        ethtool_cmd_speed_set(ecmd, speed);
        ecmd->autoneg = ((hw->phy.media_type == e1000_media_type_fiber) ||
                         hw->mac.autoneg) ? AUTONEG_ENABLE : AUTONEG_DISABLE;
@@ -198,20 +200,25 @@ static int e1000_get_settings(struct net_device *netdev,
        return 0;
 }
-static int e1000_set_spd_dplx(struct e1000_adapter *adapter, u16 spddplx)
+static int e1000_set_spd_dplx(struct e1000_adapter *adapter, u32 spd, u8 dplx)
 {
        struct e1000_mac_info *mac = &adapter->hw.mac;
        mac->autoneg = 0;
+        /* Make sure dplx is at most 1 bit and lsb of speed is not set
+         * for the switch() below to work */
+        if ((spd & 1) || (dplx & ~1))
+                goto err_inval;
        /* Fiber NICs only allow 1000 gbps Full duplex */
        if ((adapter->hw.phy.media_type == e1000_media_type_fiber) &&
-                spddplx != (SPEED_1000 + DUPLEX_FULL)) {
+            spd != SPEED_1000 &&
-                e_err("Unsupported Speed/Duplex configuration\n");
+            dplx != DUPLEX_FULL) {
-                return -EINVAL;
+                goto err_inval;
        }
-        switch (spddplx) {
+        switch (spd + dplx) {
        case SPEED_10 + DUPLEX_HALF:
                mac->forced_speed_duplex = ADVERTISE_10_HALF;
                break;
@@ -230,10 +237,13 @@ static int e1000_set_spd_dplx(struct e1000_adapter *adapter, u16 spddplx)
                break;
        case SPEED_1000 + DUPLEX_HALF: /* not supported */
        default:
-                e_err("Unsupported Speed/Duplex configuration\n");
+                goto err_inval;
-                return -EINVAL;
        }
        return 0;
+err_inval:
+        e_err("Unsupported Speed/Duplex configuration\n");
+        return -EINVAL;
 }
 static int e1000_set_settings(struct net_device *netdev,
@@ -253,7 +263,7 @@ static int e1000_set_settings(struct net_device *netdev,
        }
        while (test_and_set_bit(__E1000_RESETTING, &adapter->state))
-                msleep(1);
+                usleep_range(1000, 2000);
        if (ecmd->autoneg == AUTONEG_ENABLE) {
                hw->mac.autoneg = 1;
@@ -269,7 +279,8 @@ static int e1000_set_settings(struct net_device *netdev,
                if (adapter->fc_autoneg)
                        hw->fc.requested_mode = e1000_fc_default;
        } else {
-                if (e1000_set_spd_dplx(adapter, ecmd->speed + ecmd->duplex)) {
+                u32 speed = ethtool_cmd_speed(ecmd);
+                if (e1000_set_spd_dplx(adapter, speed, ecmd->duplex)) {
                        clear_bit(__E1000_RESETTING, &adapter->state);
                        return -EINVAL;
                }
@@ -317,7 +328,7 @@ static int e1000_set_pauseparam(struct net_device *netdev,
        adapter->fc_autoneg = pause->autoneg;
        while (test_and_set_bit(__E1000_RESETTING, &adapter->state))
-                msleep(1);
+                usleep_range(1000, 2000);
        if (adapter->fc_autoneg == AUTONEG_ENABLE) {
                hw->fc.requested_mode = e1000_fc_default;
@@ -673,7 +684,7 @@ static int e1000_set_ringparam(struct net_device *netdev,
                return -EINVAL;
        while (test_and_set_bit(__E1000_RESETTING, &adapter->state))
-                msleep(1);
+                usleep_range(1000, 2000);
        if (netif_running(adapter->netdev))
                e1000e_down(adapter);
@@ -952,7 +963,7 @@ static int e1000_intr_test(struct e1000_adapter *adapter, u64 *data)
        /* Disable all the interrupts */
        ew32(IMC, 0xFFFFFFFF);
-        msleep(10);
+        usleep_range(10000, 20000);
        /* Test each interrupt */
        for (i = 0; i < 10; i++) {
@@ -984,7 +995,7 @@ static int e1000_intr_test(struct e1000_adapter *adapter, u64 *data)
                        adapter->test_icr = 0;
                        ew32(IMC, mask);
                        ew32(ICS, mask);
-                        msleep(10);
+                        usleep_range(10000, 20000);
                        if (adapter->test_icr & mask) {
                                *data = 3;
@@ -1002,7 +1013,7 @@ static int e1000_intr_test(struct e1000_adapter *adapter, u64 *data)
                adapter->test_icr = 0;
                ew32(IMS, mask);
                ew32(ICS, mask);
-                msleep(10);
+                usleep_range(10000, 20000);
                if (!(adapter->test_icr & mask)) {
                        *data = 4;
@@ -1020,7 +1031,7 @@ static int e1000_intr_test(struct e1000_adapter *adapter, u64 *data)
                        adapter->test_icr = 0;
                        ew32(IMC, ~mask & 0x00007FFF);
                        ew32(ICS, ~mask & 0x00007FFF);
-                        msleep(10);
+                        usleep_range(10000, 20000);
                        if (adapter->test_icr) {
                                *data = 5;
@@ -1031,7 +1042,7 @@ static int e1000_intr_test(struct e1000_adapter *adapter, u64 *data)
        /* Disable all the interrupts */
        ew32(IMC, 0xFFFFFFFF);
-        msleep(10);
+        usleep_range(10000, 20000);
        /* Unhook test interrupt handler */
        free_irq(irq, netdev);
@@ -1406,7 +1417,7 @@ static int e1000_set_82571_fiber_loopback(struct e1000_adapter *adapter)
         */
 #define E1000_SERDES_LB_ON 0x410
        ew32(SCTL, E1000_SERDES_LB_ON);
-        msleep(10);
+        usleep_range(10000, 20000);
        return 0;
 }
@@ -1501,7 +1512,7 @@ static void e1000_loopback_cleanup(struct e1000_adapter *adapter)
                    hw->phy.media_type == e1000_media_type_internal_serdes) {
 #define E1000_SERDES_LB_OFF 0x400
                        ew32(SCTL, E1000_SERDES_LB_OFF);
-                        msleep(10);
+                        usleep_range(10000, 20000);
                        break;
                }
                /* Fall Through */
@@ -1851,64 +1862,35 @@ static int e1000_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
        return 0;
 }
-/* toggle LED 4 times per second = 2 "blinks" per second */
+static int e1000_set_phys_id(struct net_device *netdev,
-#define E1000_ID_INTERVAL       (HZ/4)
+                             enum ethtool_phys_id_state state)
-/* bit defines for adapter->led_status */
-#define E1000_LED_ON            0
-void e1000e_led_blink_task(struct work_struct *work)
-{
-        struct e1000_adapter *adapter = container_of(work,
-                                        struct e1000_adapter, led_blink_task);
-        if (test_and_change_bit(E1000_LED_ON, &adapter->led_status))
-                adapter->hw.mac.ops.led_off(&adapter->hw);
-        else
-                adapter->hw.mac.ops.led_on(&adapter->hw);
-}
-static void e1000_led_blink_callback(unsigned long data)
-{
-        struct e1000_adapter *adapter = (struct e1000_adapter *) data;
-        schedule_work(&adapter->led_blink_task);
-        mod_timer(&adapter->blink_timer, jiffies + E1000_ID_INTERVAL);
-}
-static int e1000_phys_id(struct net_device *netdev, u32 data)
 {
        struct e1000_adapter *adapter = netdev_priv(netdev);
        struct e1000_hw *hw = &adapter->hw;
-        if (!data)
+        switch (state) {
-                data = INT_MAX;
+        case ETHTOOL_ID_ACTIVE:
+                if (!hw->mac.ops.blink_led)
+                        return 2;       /* cycle on/off twice per second */
-        if ((hw->phy.type == e1000_phy_ife) ||
+                hw->mac.ops.blink_led(hw);
-            (hw->mac.type == e1000_pchlan) ||
+                break;
-            (hw->mac.type == e1000_pch2lan) ||
-            (hw->mac.type == e1000_82583) ||
+        case ETHTOOL_ID_INACTIVE:
-            (hw->mac.type == e1000_82574)) {
-                if (!adapter->blink_timer.function) {
-                        init_timer(&adapter->blink_timer);
-                        adapter->blink_timer.function =
-                                e1000_led_blink_callback;
-                        adapter->blink_timer.data = (unsigned long) adapter;
-                }
-                mod_timer(&adapter->blink_timer, jiffies);
-                msleep_interruptible(data * 1000);
-                del_timer_sync(&adapter->blink_timer);
                if (hw->phy.type == e1000_phy_ife)
                        e1e_wphy(hw, IFE_PHY_SPECIAL_CONTROL_LED, 0);
-        } else {
+                hw->mac.ops.led_off(hw);
-                e1000e_blink_led(hw);
+                hw->mac.ops.cleanup_led(hw);
-                msleep_interruptible(data * 1000);
+                break;
-        }
-        hw->mac.ops.led_off(hw);
+        case ETHTOOL_ID_ON:
-        clear_bit(E1000_LED_ON, &adapter->led_status);
+                adapter->hw.mac.ops.led_on(&adapter->hw);
-        hw->mac.ops.cleanup_led(hw);
+                break;
+        case ETHTOOL_ID_OFF:
+                adapter->hw.mac.ops.led_off(&adapter->hw);
+                break;
+        }
        return 0;
 }
@@ -2020,6 +2002,31 @@ static void e1000_get_strings(struct net_device *netdev, u32 stringset,
        }
 }
+static int e1000e_set_flags(struct net_device *netdev, u32 data)
+{
+        struct e1000_adapter *adapter = netdev_priv(netdev);
+        bool need_reset = false;
+        int rc;
+        need_reset = (data & ETH_FLAG_RXVLAN) !=
+                     (netdev->features & NETIF_F_HW_VLAN_RX);
+        rc = ethtool_op_set_flags(netdev, data, ETH_FLAG_RXVLAN |
+                                  ETH_FLAG_TXVLAN);
+        if (rc)
+                return rc;
+        if (need_reset) {
+                if (netif_running(netdev))
+                        e1000e_reinit_locked(adapter);
+                else
+                        e1000e_reset(adapter);
+        }
+        return 0;
+}
 static const struct ethtool_ops e1000_ethtool_ops = {
        .get_settings           = e1000_get_settings,
        .set_settings           = e1000_set_settings,
@@ -2049,12 +2056,13 @@ static const struct ethtool_ops e1000_ethtool_ops = {
        .set_tso                = e1000_set_tso,
        .self_test              = e1000_diag_test,
        .get_strings            = e1000_get_strings,
-        .phys_id                = e1000_phys_id,
+        .set_phys_id            = e1000_set_phys_id,
        .get_ethtool_stats      = e1000_get_ethtool_stats,
        .get_sset_count         = e1000e_get_sset_count,
        .get_coalesce           = e1000_get_coalesce,
        .set_coalesce           = e1000_set_coalesce,
        .get_flags              = ethtool_op_get_flags,
+        .set_flags              = e1000e_set_flags,
 };
 void e1000e_set_ethtool_ops(struct net_device *netdev)
diff --git a/drivers/net/e1000e/hw.h b/drivers/net/e1000e/hw.h
index 307e1ec22417..6c2fa8327f5c 100644
--- a/drivers/net/e1000e/hw.h
+++ b/drivers/net/e1000e/hw.h
@@ -756,6 +756,7 @@ struct e1000_host_mng_command_info {
 /* Function pointers and static data for the MAC. */
 struct e1000_mac_operations {
        s32  (*id_led_init)(struct e1000_hw *);
+        s32  (*blink_led)(struct e1000_hw *);
        bool (*check_mng_mode)(struct e1000_hw *);
        s32  (*check_for_link)(struct e1000_hw *);
        s32  (*cleanup_led)(struct e1000_hw *);
diff --git a/drivers/net/e1000e/ich8lan.c b/drivers/net/e1000e/ich8lan.c
index ce1dbfdca112..3369d1f6a39c 100644
--- a/drivers/net/e1000e/ich8lan.c
+++ b/drivers/net/e1000e/ich8lan.c
@@ -338,7 +338,7 @@ static s32 e1000_init_phy_params_pchlan(struct e1000_hw *hw)
        /* Ungate automatic PHY configuration on non-managed 82579 */
        if ((hw->mac.type == e1000_pch2lan) &&
            !(fwsm & E1000_ICH_FWSM_FW_VALID)) {
-                msleep(10);
+                usleep_range(10000, 20000);
                e1000_gate_hw_phy_config_ich8lan(hw, false);
        }
@@ -427,7 +427,7 @@ static s32 e1000_init_phy_params_ich8lan(struct e1000_hw *hw)
        phy->id = 0;
        while ((e1000_phy_unknown == e1000e_get_phy_type_from_id(phy->id)) &&
               (i++ < 100)) {
-                msleep(1);
+                usleep_range(1000, 2000);
                ret_val = e1000e_get_phy_id(hw);
                if (ret_val)
                        return ret_val;
@@ -564,6 +564,8 @@ static s32 e1000_init_mac_params_ich8lan(struct e1000_adapter *adapter)
                mac->ops.check_mng_mode = e1000_check_mng_mode_ich8lan;
                /* ID LED init */
                mac->ops.id_led_init = e1000e_id_led_init;
+                /* blink LED */
+                mac->ops.blink_led = e1000e_blink_led_generic;
                /* setup LED */
                mac->ops.setup_led = e1000e_setup_led_generic;
                /* cleanup LED */
@@ -767,6 +769,8 @@ static s32 e1000_get_variants_ich8lan(struct e1000_adapter *adapter)
             (!(er32(CTRL_EXT) & E1000_CTRL_EXT_LSECCK)))) {
                adapter->flags &= ~FLAG_HAS_JUMBO_FRAMES;
                adapter->max_hw_frame_size = ETH_FRAME_LEN + ETH_FCS_LEN;
+                hw->mac.ops.blink_led = NULL;
        }
        if ((adapter->hw.mac.type == e1000_ich8lan) &&
@@ -1704,7 +1708,7 @@ static s32 e1000_post_phy_reset_ich8lan(struct e1000_hw *hw)
                goto out;
        /* Allow time for h/w to get to quiescent state after reset */
-        msleep(10);
+        usleep_range(10000, 20000);
        /* Perform any necessary post-reset workarounds */
        switch (hw->mac.type) {
@@ -1737,7 +1741,7 @@ static s32 e1000_post_phy_reset_ich8lan(struct e1000_hw *hw)
        if (hw->mac.type == e1000_pch2lan) {
                /* Ungate automatic PHY configuration on non-managed 82579 */
                if (!(er32(FWSM) & E1000_ICH_FWSM_FW_VALID)) {
-                        msleep(10);
+                        usleep_range(10000, 20000);
                        e1000_gate_hw_phy_config_ich8lan(hw, false);
                }
@@ -2532,7 +2536,7 @@ release:
         */
        if (!ret_val) {
                e1000e_reload_nvm(hw);
-                msleep(10);
+                usleep_range(10000, 20000);
        }
 out:
@@ -3009,7 +3013,7 @@ static s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw)
        ew32(TCTL, E1000_TCTL_PSP);
        e1e_flush();
-        msleep(10);
+        usleep_range(10000, 20000);
        /* Workaround for ICH8 bit corruption issue in FIFO memory */
        if (hw->mac.type == e1000_ich8lan) {
diff --git a/drivers/net/e1000e/lib.c b/drivers/net/e1000e/lib.c
index 96921de5df2e..dd8ab05b5590 100644
--- a/drivers/net/e1000e/lib.c
+++ b/drivers/net/e1000e/lib.c
@@ -144,7 +144,7 @@ void e1000_write_vfta_generic(struct e1000_hw *hw, u32 offset, u32 value)
 *  @hw: pointer to the HW structure
 *  @rar_count: receive address registers
 *
- *  Setups the receive address registers by setting the base receive address
+ *  Setup the receive address registers by setting the base receive address
 *  register to the devices MAC address and clearing all the other receive
 *  address registers to 0.
 **/
@@ -868,7 +868,7 @@ static s32 e1000_poll_fiber_serdes_link_generic(struct e1000_hw *hw)
         * milliseconds even if the other end is doing it in SW).
         */
        for (i = 0; i < FIBER_LINK_UP_LIMIT; i++) {
-                msleep(10);
+                usleep_range(10000, 20000);
                status = er32(STATUS);
                if (status & E1000_STATUS_LU)
                        break;
@@ -930,7 +930,7 @@ s32 e1000e_setup_fiber_serdes_link(struct e1000_hw *hw)
        ew32(CTRL, ctrl);
        e1e_flush();
-        msleep(1);
+        usleep_range(1000, 2000);
        /*
         * For these adapters, the SW definable pin 1 is set when the optics
@@ -1181,7 +1181,7 @@ s32 e1000e_config_fc_after_link_up(struct e1000_hw *hw)
                         * of pause frames.  In this case, we had to advertise
                         * FULL flow control because we could not advertise Rx
                         * ONLY. Hence, we must now check to see if we need to
-                         * turn OFF  the TRANSMISSION of PAUSE frames.
+                         * turn OFF the TRANSMISSION of PAUSE frames.
                         */
                        if (hw->fc.requested_mode == e1000_fc_full) {
                                hw->fc.current_mode = e1000_fc_full;
@@ -1385,7 +1385,7 @@ s32 e1000e_get_auto_rd_done(struct e1000_hw *hw)
        while (i < AUTO_READ_DONE_TIMEOUT) {
                if (er32(EECD) & E1000_EECD_AUTO_RD)
                        break;
-                msleep(1);
+                usleep_range(1000, 2000);
                i++;
        }
@@ -1530,12 +1530,12 @@ s32 e1000e_cleanup_led_generic(struct e1000_hw *hw)
 }
 /**
- *  e1000e_blink_led - Blink LED
+ *  e1000e_blink_led_generic - Blink LED
 *  @hw: pointer to the HW structure
 *
 *  Blink the LEDs which are set to be on.
 **/
-s32 e1000e_blink_led(struct e1000_hw *hw)
+s32 e1000e_blink_led_generic(struct e1000_hw *hw)
 {
        u32 ledctl_blink = 0;
        u32 i;
@@ -2087,8 +2087,6 @@ s32 e1000e_write_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16 *data)
        if (ret_val)
                return ret_val;
-        msleep(10);
        while (widx < words) {
                u8 write_opcode = NVM_WRITE_OPCODE_SPI;
@@ -2132,7 +2130,7 @@ s32 e1000e_write_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16 *data)
                }
        }
-        msleep(10);
+        usleep_range(10000, 20000);
        nvm->ops.release(hw);
        return 0;
 }
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 506a0a0043b3..0939040305fa 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -58,6 +58,8 @@
 char e1000e_driver_name[] = "e1000e";
 const char e1000e_driver_version[] = DRV_VERSION;
+static void e1000e_disable_aspm(struct pci_dev *pdev, u16 state);
 static const struct e1000_info *e1000_info_tbl[] = {
        [board_82571]           = &e1000_82571_info,
        [board_82572]           = &e1000_82572_info,
@@ -459,13 +461,13 @@ static void e1000_receive_skb(struct e1000_adapter *adapter,
                              struct net_device *netdev, struct sk_buff *skb,
                              u8 status, __le16 vlan)
 {
+        u16 tag = le16_to_cpu(vlan);
        skb->protocol = eth_type_trans(skb, netdev);
-        if (adapter->vlgrp && (status & E1000_RXD_STAT_VP))
+        if (status & E1000_RXD_STAT_VP)
-                vlan_gro_receive(&adapter->napi, adapter->vlgrp,
+                __vlan_hwaccel_put_tag(skb, tag);
-                                 le16_to_cpu(vlan), skb);
-        else
+        napi_gro_receive(&adapter->napi, skb);
-                napi_gro_receive(&adapter->napi, skb);
 }
 /**
@@ -2433,6 +2435,8 @@ static void e1000_vlan_rx_add_vid(struct net_device *netdev, u16 vid)
                vfta |= (1 << (vid & 0x1F));
                hw->mac.ops.write_vfta(hw, index, vfta);
        }
+        set_bit(vid, adapter->active_vlans);
 }
 static void e1000_vlan_rx_kill_vid(struct net_device *netdev, u16 vid)
@@ -2441,13 +2445,6 @@ static void e1000_vlan_rx_kill_vid(struct net_device *netdev, u16 vid)
        struct e1000_hw *hw = &adapter->hw;
        u32 vfta, index;
-        if (!test_bit(__E1000_DOWN, &adapter->state))
-                e1000_irq_disable(adapter);
-        vlan_group_set_device(adapter->vlgrp, vid, NULL);
-        if (!test_bit(__E1000_DOWN, &adapter->state))
-                e1000_irq_enable(adapter);
        if ((adapter->hw.mng_cookie.status &
             E1000_MNG_DHCP_COOKIE_STATUS_VLAN) &&
            (vid == adapter->mng_vlan_id)) {
@@ -2463,93 +2460,105 @@ static void e1000_vlan_rx_kill_vid(struct net_device *netdev, u16 vid)
                vfta &= ~(1 << (vid & 0x1F));
                hw->mac.ops.write_vfta(hw, index, vfta);
        }
+        clear_bit(vid, adapter->active_vlans);
 }
-static void e1000_update_mng_vlan(struct e1000_adapter *adapter)
+/**
+ * e1000e_vlan_filter_disable - helper to disable hw VLAN filtering
+ * @adapter: board private structure to initialize
+ **/
+static void e1000e_vlan_filter_disable(struct e1000_adapter *adapter)
 {
        struct net_device *netdev = adapter->netdev;
-        u16 vid = adapter->hw.mng_cookie.vlan_id;
+        struct e1000_hw *hw = &adapter->hw;
-        u16 old_vid = adapter->mng_vlan_id;
+        u32 rctl;
-        if (!adapter->vlgrp)
-                return;
-        if (!vlan_group_get_device(adapter->vlgrp, vid)) {
+        if (adapter->flags & FLAG_HAS_HW_VLAN_FILTER) {
-                adapter->mng_vlan_id = E1000_MNG_VLAN_NONE;
+                /* disable VLAN receive filtering */
-                if (adapter->hw.mng_cookie.status &
+                rctl = er32(RCTL);
-                        E1000_MNG_DHCP_COOKIE_STATUS_VLAN) {
+                rctl &= ~(E1000_RCTL_VFE | E1000_RCTL_CFIEN);
-                        e1000_vlan_rx_add_vid(netdev, vid);
+                ew32(RCTL, rctl);
-                        adapter->mng_vlan_id = vid;
+                if (adapter->mng_vlan_id != (u16)E1000_MNG_VLAN_NONE) {
+                        e1000_vlan_rx_kill_vid(netdev, adapter->mng_vlan_id);
+                        adapter->mng_vlan_id = E1000_MNG_VLAN_NONE;
                }
-                if ((old_vid != (u16)E1000_MNG_VLAN_NONE) &&
-                                (vid != old_vid) &&
-                    !vlan_group_get_device(adapter->vlgrp, old_vid))
-                        e1000_vlan_rx_kill_vid(netdev, old_vid);
-        } else {
-                adapter->mng_vlan_id = vid;
        }
 }
+/**
+ * e1000e_vlan_filter_enable - helper to enable HW VLAN filtering
+ * @adapter: board private structure to initialize
+ **/
+static void e1000e_vlan_filter_enable(struct e1000_adapter *adapter)
+{
+        struct e1000_hw *hw = &adapter->hw;
+        u32 rctl;
-static void e1000_vlan_rx_register(struct net_device *netdev,
+        if (adapter->flags & FLAG_HAS_HW_VLAN_FILTER) {
-                                   struct vlan_group *grp)
+                /* enable VLAN receive filtering */
+                rctl = er32(RCTL);
+                rctl |= E1000_RCTL_VFE;
+                rctl &= ~E1000_RCTL_CFIEN;
+                ew32(RCTL, rctl);
+        }
+}
+/**
+ * e1000e_vlan_strip_enable - helper to disable HW VLAN stripping
+ * @adapter: board private structure to initialize
+ **/
+static void e1000e_vlan_strip_disable(struct e1000_adapter *adapter)
 {
-        struct e1000_adapter *adapter = netdev_priv(netdev);
        struct e1000_hw *hw = &adapter->hw;
-        u32 ctrl, rctl;
+        u32 ctrl;
-        if (!test_bit(__E1000_DOWN, &adapter->state))
+        /* disable VLAN tag insert/strip */
-                e1000_irq_disable(adapter);
+        ctrl = er32(CTRL);
-        adapter->vlgrp = grp;
+        ctrl &= ~E1000_CTRL_VME;
+        ew32(CTRL, ctrl);
+}
-        if (grp) {
+/**
-                /* enable VLAN tag insert/strip */
+ * e1000e_vlan_strip_enable - helper to enable HW VLAN stripping
-                ctrl = er32(CTRL);
+ * @adapter: board private structure to initialize
-                ctrl |= E1000_CTRL_VME;
+ **/
-                ew32(CTRL, ctrl);
+static void e1000e_vlan_strip_enable(struct e1000_adapter *adapter)
+{
+        struct e1000_hw *hw = &adapter->hw;
+        u32 ctrl;
-                if (adapter->flags & FLAG_HAS_HW_VLAN_FILTER) {
+        /* enable VLAN tag insert/strip */
-                        /* enable VLAN receive filtering */
+        ctrl = er32(CTRL);
-                        rctl = er32(RCTL);
+        ctrl |= E1000_CTRL_VME;
-                        rctl &= ~E1000_RCTL_CFIEN;
+        ew32(CTRL, ctrl);
-                        ew32(RCTL, rctl);
+}
-                        e1000_update_mng_vlan(adapter);
-                }
-        } else {
-                /* disable VLAN tag insert/strip */
-                ctrl = er32(CTRL);
-                ctrl &= ~E1000_CTRL_VME;
-                ew32(CTRL, ctrl);
-                if (adapter->flags & FLAG_HAS_HW_VLAN_FILTER) {
+static void e1000_update_mng_vlan(struct e1000_adapter *adapter)
-                        if (adapter->mng_vlan_id !=
+{
-                            (u16)E1000_MNG_VLAN_NONE) {
+        struct net_device *netdev = adapter->netdev;
-                                e1000_vlan_rx_kill_vid(netdev,
+        u16 vid = adapter->hw.mng_cookie.vlan_id;
-                                                       adapter->mng_vlan_id);
+        u16 old_vid = adapter->mng_vlan_id;
-                                adapter->mng_vlan_id = E1000_MNG_VLAN_NONE;
-                        }
+        if (adapter->hw.mng_cookie.status &
-                }
+            E1000_MNG_DHCP_COOKIE_STATUS_VLAN) {
+                e1000_vlan_rx_add_vid(netdev, vid);
+                adapter->mng_vlan_id = vid;
        }
-        if (!test_bit(__E1000_DOWN, &adapter->state))
+        if ((old_vid != (u16)E1000_MNG_VLAN_NONE) && (vid != old_vid))
-                e1000_irq_enable(adapter);
+                e1000_vlan_rx_kill_vid(netdev, old_vid);
 }
 static void e1000_restore_vlan(struct e1000_adapter *adapter)
 {
        u16 vid;
-        e1000_vlan_rx_register(adapter->netdev, adapter->vlgrp);
+        e1000_vlan_rx_add_vid(adapter->netdev, 0);
-        if (!adapter->vlgrp)
-                return;
-        for (vid = 0; vid < VLAN_N_VID; vid++) {
+        for_each_set_bit(vid, adapter->active_vlans, VLAN_N_VID)
-                if (!vlan_group_get_device(adapter->vlgrp, vid))
-                        continue;
                e1000_vlan_rx_add_vid(adapter->netdev, vid);
-        }
 }
 static void e1000_init_manageability_pt(struct e1000_adapter *adapter)
@@ -2902,7 +2911,7 @@ static void e1000_configure_rx(struct e1000_adapter *adapter)
        rctl = er32(RCTL);
        ew32(RCTL, rctl & ~E1000_RCTL_EN);
        e1e_flush();
-        msleep(10);
+        usleep_range(10000, 20000);
        if (adapter->flags2 & FLAG2_DMA_BURST) {
                /*
@@ -3039,6 +3048,8 @@ static void e1000_set_multi(struct net_device *netdev)
        if (netdev->flags & IFF_PROMISC) {
                rctl |= (E1000_RCTL_UPE | E1000_RCTL_MPE);
                rctl &= ~E1000_RCTL_VFE;
+                /* Do not hardware filter VLANs in promisc mode */
+                e1000e_vlan_filter_disable(adapter);
        } else {
                if (netdev->flags & IFF_ALLMULTI) {
                        rctl |= E1000_RCTL_MPE;
@@ -3046,8 +3057,7 @@ static void e1000_set_multi(struct net_device *netdev)
                } else {
                        rctl &= ~(E1000_RCTL_UPE | E1000_RCTL_MPE);
                }
-                if (adapter->flags & FLAG_HAS_HW_VLAN_FILTER)
+                e1000e_vlan_filter_enable(adapter);
-                        rctl |= E1000_RCTL_VFE;
        }
        ew32(RCTL, rctl);
@@ -3072,6 +3082,11 @@ static void e1000_set_multi(struct net_device *netdev)
                 */
                e1000_update_mc_addr_list(hw, NULL, 0);
        }
+        if (netdev->features & NETIF_F_HW_VLAN_RX)
+                e1000e_vlan_strip_enable(adapter);
+        else
+                e1000e_vlan_strip_disable(adapter);
 }
 /**
@@ -3383,7 +3398,7 @@ void e1000e_down(struct e1000_adapter *adapter)
        ew32(TCTL, tctl);
        /* flush both disables and wait for them to finish */
        e1e_flush();
-        msleep(10);
+        usleep_range(10000, 20000);
        napi_disable(&adapter->napi);
        e1000_irq_disable(adapter);
@@ -3418,7 +3433,7 @@ void e1000e_reinit_locked(struct e1000_adapter *adapter)
 {
        might_sleep();
        while (test_and_set_bit(__E1000_RESETTING, &adapter->state))
-                msleep(1);
+                usleep_range(1000, 2000);
        e1000e_down(adapter);
        e1000e_up(adapter);
        clear_bit(__E1000_RESETTING, &adapter->state);
@@ -3721,10 +3736,8 @@ static int e1000_close(struct net_device *netdev)
         * kill manageability vlan ID if supported, but not if a vlan with
         * the same ID is registered on the host OS (let 8021q kill it)
         */
-        if ((adapter->hw.mng_cookie.status &
+        if (adapter->hw.mng_cookie.status &
-                          E1000_MNG_DHCP_COOKIE_STATUS_VLAN) &&
+            E1000_MNG_DHCP_COOKIE_STATUS_VLAN)
-             !(adapter->vlgrp &&
-               vlan_group_get_device(adapter->vlgrp, adapter->mng_vlan_id)))
                e1000_vlan_rx_kill_vid(netdev, adapter->mng_vlan_id);
        /*
@@ -4328,7 +4341,6 @@ static void e1000_watchdog_task(struct work_struct *work)
 link_up:
        spin_lock(&adapter->stats64_lock);
        e1000e_update_stats(adapter);
-        spin_unlock(&adapter->stats64_lock);
        mac->tx_packet_delta = adapter->stats.tpt - adapter->tpt_old;
        adapter->tpt_old = adapter->stats.tpt;
@@ -4339,6 +4351,7 @@ link_up:
        adapter->gorc_old = adapter->stats.gorc;
        adapter->gotc = adapter->stats.gotc - adapter->gotc_old;
        adapter->gotc_old = adapter->stats.gotc;
+        spin_unlock(&adapter->stats64_lock);
        e1000e_update_adaptive(&adapter->hw);
@@ -5028,7 +5041,7 @@ static int e1000_change_mtu(struct net_device *netdev, int new_mtu)
        }
        while (test_and_set_bit(__E1000_RESETTING, &adapter->state))
-                msleep(1);
+                usleep_range(1000, 2000);
        /* e1000e_down -> e1000e_reset dependent on max_frame_size & mtu */
        adapter->max_frame_size = max_frame;
        e_info("changing MTU from %d to %d\n", netdev->mtu, new_mtu);
@@ -5373,7 +5386,7 @@ static void __e1000e_disable_aspm(struct pci_dev *pdev, u16 state)
        pci_write_config_word(pdev->bus->self, pos + PCI_EXP_LNKCTL, reg16);
 }
 #endif
-void e1000e_disable_aspm(struct pci_dev *pdev, u16 state)
+static void e1000e_disable_aspm(struct pci_dev *pdev, u16 state)
 {
        dev_info(&pdev->dev, "Disabling ASPM %s %s\n",
                 (state & PCIE_LINK_STATE_L0S) ? "L0s" : "",
@@ -5393,13 +5406,19 @@ static int __e1000_resume(struct pci_dev *pdev)
        struct net_device *netdev = pci_get_drvdata(pdev);
        struct e1000_adapter *adapter = netdev_priv(netdev);
        struct e1000_hw *hw = &adapter->hw;
+        u16 aspm_disable_flag = 0;
        u32 err;
+        if (adapter->flags2 & FLAG2_DISABLE_ASPM_L0S)
+                aspm_disable_flag = PCIE_LINK_STATE_L0S;
+        if (adapter->flags2 & FLAG2_DISABLE_ASPM_L1)
+                aspm_disable_flag |= PCIE_LINK_STATE_L1;
+        if (aspm_disable_flag)
+                e1000e_disable_aspm(pdev, aspm_disable_flag);
        pci_set_power_state(pdev, PCI_D0);
        pci_restore_state(pdev);
        pci_save_state(pdev);
-        if (adapter->flags2 & FLAG2_DISABLE_ASPM_L1)
-                e1000e_disable_aspm(pdev, PCIE_LINK_STATE_L1);
        e1000e_set_interrupt_capability(adapter);
        if (netif_running(netdev)) {
@@ -5643,11 +5662,17 @@ static pci_ers_result_t e1000_io_slot_reset(struct pci_dev *pdev)
        struct net_device *netdev = pci_get_drvdata(pdev);
        struct e1000_adapter *adapter = netdev_priv(netdev);
        struct e1000_hw *hw = &adapter->hw;
+        u16 aspm_disable_flag = 0;
        int err;
        pci_ers_result_t result;
+        if (adapter->flags2 & FLAG2_DISABLE_ASPM_L0S)
+                aspm_disable_flag = PCIE_LINK_STATE_L0S;
        if (adapter->flags2 & FLAG2_DISABLE_ASPM_L1)
-                e1000e_disable_aspm(pdev, PCIE_LINK_STATE_L1);
+                aspm_disable_flag |= PCIE_LINK_STATE_L1;
+        if (aspm_disable_flag)
+                e1000e_disable_aspm(pdev, aspm_disable_flag);
        err = pci_enable_device_mem(pdev);
        if (err) {
                dev_err(&pdev->dev,
@@ -5714,7 +5739,7 @@ static void e1000_print_device_info(struct e1000_adapter *adapter)
        u8 pba_str[E1000_PBANUM_LENGTH];
        /* print bus type/speed/width info */
-        e_info("(PCI Express:2.5GB/s:%s) %pM\n",
+        e_info("(PCI Express:2.5GT/s:%s) %pM\n",
               /* bus width */
               ((hw->bus.width == e1000_bus_width_pcie_x4) ? "Width x4" :
                "Width x1"),
@@ -5759,7 +5784,6 @@ static const struct net_device_ops e1000e_netdev_ops = {
        .ndo_tx_timeout         = e1000_tx_timeout,
        .ndo_validate_addr      = eth_validate_addr,
-        .ndo_vlan_rx_register   = e1000_vlan_rx_register,
        .ndo_vlan_rx_add_vid    = e1000_vlan_rx_add_vid,
        .ndo_vlan_rx_kill_vid   = e1000_vlan_rx_kill_vid,
 #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -5789,12 +5813,17 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
        resource_size_t flash_start, flash_len;
        static int cards_found;
+        u16 aspm_disable_flag = 0;
        int i, err, pci_using_dac;
        u16 eeprom_data = 0;
        u16 eeprom_apme_mask = E1000_EEPROM_APME;
+        if (ei->flags2 & FLAG2_DISABLE_ASPM_L0S)
+                aspm_disable_flag = PCIE_LINK_STATE_L0S;
        if (ei->flags2 & FLAG2_DISABLE_ASPM_L1)
-                e1000e_disable_aspm(pdev, PCIE_LINK_STATE_L1);
+                aspm_disable_flag |= PCIE_LINK_STATE_L1;
+        if (aspm_disable_flag)
+                e1000e_disable_aspm(pdev, aspm_disable_flag);
        err = pci_enable_device_mem(pdev);
        if (err)
@@ -5991,7 +6020,6 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
        INIT_WORK(&adapter->downshift_task, e1000e_downshift_workaround);
        INIT_WORK(&adapter->update_phy_task, e1000e_update_phy_task);
        INIT_WORK(&adapter->print_hang_task, e1000_print_hw_hang);
-        INIT_WORK(&adapter->led_blink_task, e1000e_led_blink_task);
        /* Initialize link parameters. User can change them with ethtool */
        adapter->hw.mac.autoneg = 1;
@@ -6124,7 +6152,6 @@ static void __devexit e1000_remove(struct pci_dev *pdev)
        cancel_work_sync(&adapter->watchdog_task);
        cancel_work_sync(&adapter->downshift_task);
        cancel_work_sync(&adapter->update_phy_task);
-        cancel_work_sync(&adapter->led_blink_task);
        cancel_work_sync(&adapter->print_hang_task);
        if (!(netdev->flags & IFF_UP))
diff --git a/drivers/net/e1000e/phy.c b/drivers/net/e1000e/phy.c
index 6ae31fcfb629..484774c13c21 100644
--- a/drivers/net/e1000e/phy.c
+++ b/drivers/net/e1000e/phy.c
@@ -2372,7 +2372,7 @@ s32 e1000e_determine_phy_address(struct e1000_hw *hw)
                                ret_val = 0;
                                goto out;
                        }
-                        msleep(1);
+                        usleep_range(1000, 2000);
                        i++;
                } while (i < 10);
        }
@@ -2740,7 +2740,7 @@ void e1000_power_down_phy_copper(struct e1000_hw *hw)
        e1e_rphy(hw, PHY_CONTROL, &mii_reg);
        mii_reg |= MII_CR_POWER_DOWN;
        e1e_wphy(hw, PHY_CONTROL, mii_reg);
-        msleep(1);
+        usleep_range(1000, 2000);
 }
 /**
diff --git a/drivers/net/eepro.c b/drivers/net/eepro.c
index eb35951a2442..dfeb006035df 100644
--- a/drivers/net/eepro.c
+++ b/drivers/net/eepro.c
@@ -1703,7 +1703,7 @@ static int eepro_ethtool_get_settings(struct net_device *dev,
                cmd->advertising |= ADVERTISED_AUI;
        }
-        cmd->speed = SPEED_10;
+        ethtool_cmd_speed_set(cmd, SPEED_10);
        if (dev->if_port == TPE && lp->word[1] & ee_Duplex) {
                cmd->duplex = DUPLEX_FULL;
diff --git a/drivers/net/ehea/ehea_ethtool.c b/drivers/net/ehea/ehea_ethtool.c
index f3bbdcef338c..7f642aef5e82 100644
--- a/drivers/net/ehea/ehea_ethtool.c
+++ b/drivers/net/ehea/ehea_ethtool.c
@@ -34,6 +34,7 @@
 static int ehea_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        struct ehea_port *port = netdev_priv(dev);
+        u32 speed;
        int ret;
        ret = ehea_sense_port_attr(port);
@@ -43,17 +44,29 @@ static int ehea_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        if (netif_carrier_ok(dev)) {
                switch (port->port_speed) {
-                case EHEA_SPEED_10M: cmd->speed = SPEED_10; break;
+                case EHEA_SPEED_10M:
-                case EHEA_SPEED_100M: cmd->speed = SPEED_100; break;
+                        speed = SPEED_10;
-                case EHEA_SPEED_1G: cmd->speed = SPEED_1000; break;
+                        break;
-                case EHEA_SPEED_10G: cmd->speed = SPEED_10000; break;
+                case EHEA_SPEED_100M:
+                        speed = SPEED_100;
+                        break;
+                case EHEA_SPEED_1G:
+                        speed = SPEED_1000;
+                        break;
+                case EHEA_SPEED_10G:
+                        speed = SPEED_10000;
+                        break;
+                default:
+                        speed = -1;
+                        break; /* BUG */
                }
                cmd->duplex = port->full_duplex == 1 ?
                                                     DUPLEX_FULL : DUPLEX_HALF;
        } else {
-                cmd->speed = -1;
+                speed = ~0;
                cmd->duplex = -1;
        }
+        ethtool_cmd_speed_set(cmd, speed);
        if (cmd->speed == SPEED_10000) {
                cmd->supported = (SUPPORTED_10000baseT_Full | SUPPORTED_FIBRE);
@@ -167,11 +180,6 @@ static void ehea_set_msglevel(struct net_device *dev, u32 value)
        port->msg_enable = value;
 }
-static u32 ehea_get_rx_csum(struct net_device *dev)
-{
-        return 1;
-}
 static char ehea_ethtool_stats_keys[][ETH_GSTRING_LEN] = {
        {"sig_comp_iv"},
        {"swqe_refill_th"},
@@ -268,34 +276,16 @@ static void ehea_get_ethtool_stats(struct net_device *dev,
 }
-static int ehea_set_flags(struct net_device *dev, u32 data)
-{
-        /* Avoid changing the VLAN flags */
-        if ((data & (ETH_FLAG_RXVLAN | ETH_FLAG_TXVLAN)) !=
-            (ethtool_op_get_flags(dev) & (ETH_FLAG_RXVLAN |
-                                          ETH_FLAG_TXVLAN))){
-                return -EINVAL;
-        }
-        return ethtool_op_set_flags(dev, data, ETH_FLAG_LRO
-                                        | ETH_FLAG_TXVLAN
-                                        | ETH_FLAG_RXVLAN);
-}
 const struct ethtool_ops ehea_ethtool_ops = {
        .get_settings = ehea_get_settings,
        .get_drvinfo = ehea_get_drvinfo,
        .get_msglevel = ehea_get_msglevel,
        .set_msglevel = ehea_set_msglevel,
        .get_link = ethtool_op_get_link,
-        .set_tso = ethtool_op_set_tso,
        .get_strings = ehea_get_strings,
        .get_sset_count = ehea_get_sset_count,
        .get_ethtool_stats = ehea_get_ethtool_stats,
-        .get_rx_csum = ehea_get_rx_csum,
        .set_settings = ehea_set_settings,
-        .get_flags = ethtool_op_get_flags,
-        .set_flags = ehea_set_flags,
        .nway_reset = ehea_nway_reset,          /* Restart autonegotiation */
 };
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index 2c60435f2beb..6a0a8fca62bc 100644
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea/ehea_main.c
@@ -3263,10 +3263,12 @@ struct ehea_port *ehea_setup_single_port(struct ehea_adapter *adapter,
        dev->netdev_ops = &ehea_netdev_ops;
        ehea_set_ethtool_ops(dev);
+        dev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO
+                      | NETIF_F_IP_CSUM | NETIF_F_HW_VLAN_TX | NETIF_F_LRO;
        dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO
                      | NETIF_F_HIGHDMA | NETIF_F_IP_CSUM | NETIF_F_HW_VLAN_TX
                      | NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER
-                      | NETIF_F_LLTX;
+                      | NETIF_F_LLTX | NETIF_F_RXCSUM;
        dev->watchdog_timeo = EHEA_WATCH_DOG_TIMEOUT;
        if (use_lro)
diff --git a/drivers/net/enc28j60.c b/drivers/net/enc28j60.c
index 907b05a1c659..2837ce209cd7 100644
--- a/drivers/net/enc28j60.c
+++ b/drivers/net/enc28j60.c
@@ -1488,7 +1488,7 @@ enc28j60_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        cmd->supported  = SUPPORTED_10baseT_Half
                        | SUPPORTED_10baseT_Full
                        | SUPPORTED_TP;
-        cmd->speed      = SPEED_10;
+        ethtool_cmd_speed_set(cmd,  SPEED_10);
        cmd->duplex     = priv->full_duplex ? DUPLEX_FULL : DUPLEX_HALF;
        cmd->port       = PORT_TP;
        cmd->autoneg    = AUTONEG_DISABLE;
@@ -1499,7 +1499,8 @@ enc28j60_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 static int
 enc28j60_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
-        return enc28j60_setlink(dev, cmd->autoneg, cmd->speed, cmd->duplex);
+        return enc28j60_setlink(dev, cmd->autoneg,
+                                ethtool_cmd_speed(cmd), cmd->duplex);
 }
 static u32 enc28j60_get_msglevel(struct net_device *dev)
diff --git a/drivers/net/enic/Makefile b/drivers/net/enic/Makefile
index 2e573be16c13..9d4974bba247 100644
--- a/drivers/net/enic/Makefile
+++ b/drivers/net/enic/Makefile
@@ -1,5 +1,5 @@
 obj-$(CONFIG_ENIC) := enic.o
 enic-y := enic_main.o vnic_cq.o vnic_intr.o vnic_wq.o \
-        enic_res.o enic_dev.o vnic_dev.o vnic_rq.o vnic_vic.o
+        enic_res.o enic_dev.o enic_pp.o vnic_dev.o vnic_rq.o vnic_vic.o
diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index 3a3c3c8a3a9b..38b351c7b979 100644
--- a/drivers/net/enic/enic.h
+++ b/drivers/net/enic/enic.h
@@ -32,7 +32,7 @@
 #define DRV_NAME                "enic"
 #define DRV_DESCRIPTION         "Cisco VIC Ethernet NIC Driver"
-#define DRV_VERSION             "2.1.1.12"
+#define DRV_VERSION             "2.1.1.13"
 #define DRV_COPYRIGHT           "Copyright 2008-2011 Cisco Systems, Inc"
 #define ENIC_BARS_MAX           6
@@ -84,7 +84,6 @@ struct enic {
        unsigned int flags;
        unsigned int mc_count;
        unsigned int uc_count;
-        int csum_rx_enabled;
        u32 port_mtu;
        u32 rx_coalesce_usecs;
        u32 tx_coalesce_usecs;
@@ -120,4 +119,6 @@ static inline struct device *enic_get_dev(struct enic *enic)
        return &(enic->pdev->dev);
 }
+void enic_reset_addr_lists(struct enic *enic);
 #endif /* _ENIC_H_ */
diff --git a/drivers/net/enic/enic_dev.c b/drivers/net/enic/enic_dev.c
index 37ad3a1c82ee..90687b14e60f 100644
--- a/drivers/net/enic/enic_dev.c
+++ b/drivers/net/enic/enic_dev.c
@@ -177,24 +177,24 @@ int enic_vnic_dev_deinit(struct enic *enic)
        return err;
 }
-int enic_dev_init_prov(struct enic *enic, struct vic_provinfo *vp)
+int enic_dev_init_prov2(struct enic *enic, struct vic_provinfo *vp)
 {
        int err;
        spin_lock(&enic->devcmd_lock);
-        err = vnic_dev_init_prov(enic->vdev,
+        err = vnic_dev_init_prov2(enic->vdev,
                (u8 *)vp, vic_provinfo_size(vp));
        spin_unlock(&enic->devcmd_lock);
        return err;
 }
-int enic_dev_init_done(struct enic *enic, int *done, int *error)
+int enic_dev_deinit_done(struct enic *enic, int *status)
 {
        int err;
        spin_lock(&enic->devcmd_lock);
-        err = vnic_dev_init_done(enic->vdev, done, error);
+        err = vnic_dev_deinit_done(enic->vdev, status);
        spin_unlock(&enic->devcmd_lock);
        return err;
@@ -219,3 +219,57 @@ void enic_vlan_rx_kill_vid(struct net_device *netdev, u16 vid)
        enic_del_vlan(enic, vid);
        spin_unlock(&enic->devcmd_lock);
 }
+int enic_dev_enable2(struct enic *enic, int active)
+{
+        int err;
+        spin_lock(&enic->devcmd_lock);
+        err = vnic_dev_enable2(enic->vdev, active);
+        spin_unlock(&enic->devcmd_lock);
+        return err;
+}
+int enic_dev_enable2_done(struct enic *enic, int *status)
+{
+        int err;
+        spin_lock(&enic->devcmd_lock);
+        err = vnic_dev_enable2_done(enic->vdev, status);
+        spin_unlock(&enic->devcmd_lock);
+        return err;
+}
+int enic_dev_status_to_errno(int devcmd_status)
+{
+        switch (devcmd_status) {
+        case ERR_SUCCESS:
+                return 0;
+        case ERR_EINVAL:
+                return -EINVAL;
+        case ERR_EFAULT:
+                return -EFAULT;
+        case ERR_EPERM:
+                return -EPERM;
+        case ERR_EBUSY:
+                return -EBUSY;
+        case ERR_ECMDUNKNOWN:
+        case ERR_ENOTSUPPORTED:
+                return -EOPNOTSUPP;
+        case ERR_EBADSTATE:
+                return -EINVAL;
+        case ERR_ENOMEM:
+                return -ENOMEM;
+        case ERR_ETIMEDOUT:
+                return -ETIMEDOUT;
+        case ERR_ELINKDOWN:
+                return -ENETDOWN;
+        case ERR_EINPROGRESS:
+                return -EINPROGRESS;
+        case ERR_EMAXRES:
+        default:
+                return (devcmd_status < 0) ? devcmd_status : -1;
+        }
+}
diff --git a/drivers/net/enic/enic_dev.h b/drivers/net/enic/enic_dev.h
index 495f57fcb887..d5f681337626 100644
--- a/drivers/net/enic/enic_dev.h
+++ b/drivers/net/enic/enic_dev.h
@@ -35,7 +35,10 @@ int enic_dev_set_ig_vlan_rewrite_mode(struct enic *enic);
 int enic_dev_enable(struct enic *enic);
 int enic_dev_disable(struct enic *enic);
 int enic_vnic_dev_deinit(struct enic *enic);
-int enic_dev_init_prov(struct enic *enic, struct vic_provinfo *vp);
+int enic_dev_init_prov2(struct enic *enic, struct vic_provinfo *vp);
-int enic_dev_init_done(struct enic *enic, int *done, int *error);
+int enic_dev_deinit_done(struct enic *enic, int *status);
+int enic_dev_enable2(struct enic *enic, int arg);
+int enic_dev_enable2_done(struct enic *enic, int *status);
+int enic_dev_status_to_errno(int devcmd_status);
 #endif /* _ENIC_DEV_H_ */
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 8b9cad5e9712..3d99b0f1a236 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -45,6 +45,7 @@
 #include "enic_res.h"
 #include "enic.h"
 #include "enic_dev.h"
+#include "enic_pp.h"
 #define ENIC_NOTIFY_TIMER_PERIOD        (2 * HZ)
 #define WQ_ENET_MAX_DESC_LEN            (1 << WQ_ENET_LEN_BITS)
@@ -179,10 +180,10 @@ static int enic_get_settings(struct net_device *netdev,
        ecmd->transceiver = XCVR_EXTERNAL;
        if (netif_carrier_ok(netdev)) {
-                ecmd->speed = vnic_dev_port_speed(enic->vdev);
+                ethtool_cmd_speed_set(ecmd, vnic_dev_port_speed(enic->vdev));
                ecmd->duplex = DUPLEX_FULL;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
@@ -250,56 +251,6 @@ static void enic_get_ethtool_stats(struct net_device *netdev,
                *(data++) = ((u64 *)&vstats->rx)[enic_rx_stats[i].offset];
 }
-static u32 enic_get_rx_csum(struct net_device *netdev)
-{
-        struct enic *enic = netdev_priv(netdev);
-        return enic->csum_rx_enabled;
-}
-static int enic_set_rx_csum(struct net_device *netdev, u32 data)
-{
-        struct enic *enic = netdev_priv(netdev);
-        if (data && !ENIC_SETTING(enic, RXCSUM))
-                return -EINVAL;
-        enic->csum_rx_enabled = !!data;
-        return 0;
-}
-static int enic_set_tx_csum(struct net_device *netdev, u32 data)
-{
-        struct enic *enic = netdev_priv(netdev);
-        if (data && !ENIC_SETTING(enic, TXCSUM))
-                return -EINVAL;
-        if (data)
-                netdev->features |= NETIF_F_HW_CSUM;
-        else
-                netdev->features &= ~NETIF_F_HW_CSUM;
-        return 0;
-}
-static int enic_set_tso(struct net_device *netdev, u32 data)
-{
-        struct enic *enic = netdev_priv(netdev);
-        if (data && !ENIC_SETTING(enic, TSO))
-                return -EINVAL;
-        if (data)
-                netdev->features |=
-                        NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN;
-        else
-                netdev->features &=
-                        ~(NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN);
-        return 0;
-}
 static u32 enic_get_msglevel(struct net_device *netdev)
 {
        struct enic *enic = netdev_priv(netdev);
@@ -387,17 +338,8 @@ static const struct ethtool_ops enic_ethtool_ops = {
        .get_strings = enic_get_strings,
        .get_sset_count = enic_get_sset_count,
        .get_ethtool_stats = enic_get_ethtool_stats,
-        .get_rx_csum = enic_get_rx_csum,
-        .set_rx_csum = enic_set_rx_csum,
-        .get_tx_csum = ethtool_op_get_tx_csum,
-        .set_tx_csum = enic_set_tx_csum,
-        .get_sg = ethtool_op_get_sg,
-        .set_sg = ethtool_op_set_sg,
-        .get_tso = ethtool_op_get_tso,
-        .set_tso = enic_set_tso,
        .get_coalesce = enic_get_coalesce,
        .set_coalesce = enic_set_coalesce,
-        .get_flags = ethtool_op_get_flags,
 };
 static void enic_free_wq_buf(struct vnic_wq *wq, struct vnic_wq_buf *buf)
@@ -874,7 +816,7 @@ static struct net_device_stats *enic_get_stats(struct net_device *netdev)
        return net_stats;
 }
-static void enic_reset_addr_lists(struct enic *enic)
+void enic_reset_addr_lists(struct enic *enic)
 {
        enic->mc_count = 0;
        enic->uc_count = 0;
@@ -1112,157 +1054,77 @@ static int enic_set_vf_mac(struct net_device *netdev, int vf, u8 *mac)
                return -EINVAL;
 }
-static int enic_set_port_profile(struct enic *enic, u8 *mac)
-{
-        struct vic_provinfo *vp;
-        u8 oui[3] = VIC_PROVINFO_CISCO_OUI;
-        u16 os_type = VIC_GENERIC_PROV_OS_TYPE_LINUX;
-        char uuid_str[38];
-        char client_mac_str[18];
-        u8 *client_mac;
-        int err;
-        err = enic_vnic_dev_deinit(enic);
-        if (err)
-                return err;
-        enic_reset_addr_lists(enic);
-        switch (enic->pp.request) {
-        case PORT_REQUEST_ASSOCIATE:
-                if (!(enic->pp.set & ENIC_SET_NAME) || !strlen(enic->pp.name))
-                        return -EINVAL;
-                if (!is_valid_ether_addr(mac))
-                        return -EADDRNOTAVAIL;
-                vp = vic_provinfo_alloc(GFP_KERNEL, oui,
-                        VIC_PROVINFO_GENERIC_TYPE);
-                if (!vp)
-                        return -ENOMEM;
-                vic_provinfo_add_tlv(vp,
-                        VIC_GENERIC_PROV_TLV_PORT_PROFILE_NAME_STR,
-                        strlen(enic->pp.name) + 1, enic->pp.name);
-                if (!is_zero_ether_addr(enic->pp.mac_addr))
-                        client_mac = enic->pp.mac_addr;
-                else
-                        client_mac = mac;
-                vic_provinfo_add_tlv(vp,
-                        VIC_GENERIC_PROV_TLV_CLIENT_MAC_ADDR,
-                        ETH_ALEN, client_mac);
-                sprintf(client_mac_str, "%pM", client_mac);
-                vic_provinfo_add_tlv(vp,
-                        VIC_GENERIC_PROV_TLV_CLUSTER_PORT_UUID_STR,
-                        sizeof(client_mac_str), client_mac_str);
-                if (enic->pp.set & ENIC_SET_INSTANCE) {
-                        sprintf(uuid_str, "%pUB", enic->pp.instance_uuid);
-                        vic_provinfo_add_tlv(vp,
-                                VIC_GENERIC_PROV_TLV_CLIENT_UUID_STR,
-                                sizeof(uuid_str), uuid_str);
-                }
-                if (enic->pp.set & ENIC_SET_HOST) {
-                        sprintf(uuid_str, "%pUB", enic->pp.host_uuid);
-                        vic_provinfo_add_tlv(vp,
-                                VIC_GENERIC_PROV_TLV_HOST_UUID_STR,
-                                sizeof(uuid_str), uuid_str);
-                }
-                os_type = htons(os_type);
-                vic_provinfo_add_tlv(vp,
-                        VIC_GENERIC_PROV_TLV_OS_TYPE,
-                        sizeof(os_type), &os_type);
-                err = enic_dev_init_prov(enic, vp);
-                vic_provinfo_free(vp);
-                if (err)
-                        return err;
-                break;
-        case PORT_REQUEST_DISASSOCIATE:
-                break;
-        default:
-                return -EINVAL;
-        }
-        /* Set flag to indicate that the port assoc/disassoc
-         * request has been sent out to fw
-         */
-        enic->pp.set |= ENIC_PORT_REQUEST_APPLIED;
-        return 0;
-}
 static int enic_set_vf_port(struct net_device *netdev, int vf,
        struct nlattr *port[])
 {
        struct enic *enic = netdev_priv(netdev);
-        struct enic_port_profile new_pp;
+        struct enic_port_profile prev_pp;
-        int err = 0;
+        int err = 0, restore_pp = 1;
-        memset(&new_pp, 0, sizeof(new_pp));
+        /* don't support VFs, yet */
+        if (vf != PORT_SELF_VF)
+                return -EOPNOTSUPP;
-        if (port[IFLA_PORT_REQUEST]) {
+        if (!port[IFLA_PORT_REQUEST])
-                new_pp.set |= ENIC_SET_REQUEST;
+                return -EOPNOTSUPP;
-                new_pp.request = nla_get_u8(port[IFLA_PORT_REQUEST]);
-        }
+        memcpy(&prev_pp, &enic->pp, sizeof(enic->pp));
+        memset(&enic->pp, 0, sizeof(enic->pp));
+        enic->pp.set |= ENIC_SET_REQUEST;
+        enic->pp.request = nla_get_u8(port[IFLA_PORT_REQUEST]);
        if (port[IFLA_PORT_PROFILE]) {
-                new_pp.set |= ENIC_SET_NAME;
+                enic->pp.set |= ENIC_SET_NAME;
-                memcpy(new_pp.name, nla_data(port[IFLA_PORT_PROFILE]),
+                memcpy(enic->pp.name, nla_data(port[IFLA_PORT_PROFILE]),
                        PORT_PROFILE_MAX);
        }
        if (port[IFLA_PORT_INSTANCE_UUID]) {
-                new_pp.set |= ENIC_SET_INSTANCE;
+                enic->pp.set |= ENIC_SET_INSTANCE;
-                memcpy(new_pp.instance_uuid,
+                memcpy(enic->pp.instance_uuid,
                        nla_data(port[IFLA_PORT_INSTANCE_UUID]), PORT_UUID_MAX);
        }
        if (port[IFLA_PORT_HOST_UUID]) {
-                new_pp.set |= ENIC_SET_HOST;
+                enic->pp.set |= ENIC_SET_HOST;
-                memcpy(new_pp.host_uuid,
+                memcpy(enic->pp.host_uuid,
                        nla_data(port[IFLA_PORT_HOST_UUID]), PORT_UUID_MAX);
        }
-        /* don't support VFs, yet */
+        /* Special case handling: mac came from IFLA_VF_MAC */
-        if (vf != PORT_SELF_VF)
+        if (!is_zero_ether_addr(prev_pp.vf_mac))
-                return -EOPNOTSUPP;
+                memcpy(enic->pp.mac_addr, prev_pp.vf_mac, ETH_ALEN);
-        if (!(new_pp.set & ENIC_SET_REQUEST))
-                return -EOPNOTSUPP;
-        if (new_pp.request == PORT_REQUEST_ASSOCIATE) {
-                /* Special case handling */
-                if (!is_zero_ether_addr(enic->pp.vf_mac))
-                        memcpy(new_pp.mac_addr, enic->pp.vf_mac, ETH_ALEN);
                if (is_zero_ether_addr(netdev->dev_addr))
                        random_ether_addr(netdev->dev_addr);
-        }
-        memcpy(&enic->pp, &new_pp, sizeof(struct enic_port_profile));
+        err = enic_process_set_pp_request(enic, &prev_pp, &restore_pp);
+        if (err) {
+                if (restore_pp) {
+                        /* Things are still the way they were: Implicit
+                         * DISASSOCIATE failed
+                         */
+                        memcpy(&enic->pp, &prev_pp, sizeof(enic->pp));
+                } else {
+                        memset(&enic->pp, 0, sizeof(enic->pp));
+                        memset(netdev->dev_addr, 0, ETH_ALEN);
+                }
+        } else {
+                /* Set flag to indicate that the port assoc/disassoc
+                 * request has been sent out to fw
+                 */
+                enic->pp.set |= ENIC_PORT_REQUEST_APPLIED;
-        err = enic_set_port_profile(enic, netdev->dev_addr);
+                /* If DISASSOCIATE, clean up all assigned/saved macaddresses */
-        if (err)
+                if (enic->pp.request == PORT_REQUEST_DISASSOCIATE) {
-                goto set_port_profile_cleanup;
+                        memset(enic->pp.mac_addr, 0, ETH_ALEN);
+                        memset(netdev->dev_addr, 0, ETH_ALEN);
+                }
+        }
-set_port_profile_cleanup:
        memset(enic->pp.vf_mac, 0, ETH_ALEN);
-        if (err || enic->pp.request == PORT_REQUEST_DISASSOCIATE) {
-                memset(netdev->dev_addr, 0, ETH_ALEN);
-                memset(enic->pp.mac_addr, 0, ETH_ALEN);
-        }
        return err;
 }
@@ -1270,34 +1132,15 @@ static int enic_get_vf_port(struct net_device *netdev, int vf,
        struct sk_buff *skb)
 {
        struct enic *enic = netdev_priv(netdev);
-        int err, error, done;
        u16 response = PORT_PROFILE_RESPONSE_SUCCESS;
+        int err;
        if (!(enic->pp.set & ENIC_PORT_REQUEST_APPLIED))
                return -ENODATA;
-        err = enic_dev_init_done(enic, &done, &error);
+        err = enic_process_get_pp_request(enic, enic->pp.request, &response);
        if (err)
-                error = err;
+                return err;
-        switch (error) {
-        case ERR_SUCCESS:
-                if (!done)
-                        response = PORT_PROFILE_RESPONSE_INPROGRESS;
-                break;
-        case ERR_EINVAL:
-                response = PORT_PROFILE_RESPONSE_INVALID;
-                break;
-        case ERR_EBADSTATE:
-                response = PORT_PROFILE_RESPONSE_BADSTATE;
-                break;
-        case ERR_ENOMEM:
-                response = PORT_PROFILE_RESPONSE_INSUFFICIENT_RESOURCES;
-                break;
-        default:
-                response = PORT_PROFILE_RESPONSE_ERROR;
-                break;
-        }
        NLA_PUT_U16(skb, IFLA_PORT_REQUEST, enic->pp.request);
        NLA_PUT_U16(skb, IFLA_PORT_RESPONSE, response);
@@ -1407,7 +1250,7 @@ static void enic_rq_indicate_buf(struct vnic_rq *rq,
                skb_put(skb, bytes_written);
                skb->protocol = eth_type_trans(skb, netdev);
-                if (enic->csum_rx_enabled && !csum_not_calc) {
+                if ((netdev->features & NETIF_F_RXCSUM) && !csum_not_calc) {
                        skb->csum = htons(checksum);
                        skb->ip_summed = CHECKSUM_COMPLETE;
                }
@@ -2536,17 +2379,18 @@ static int __devinit enic_probe(struct pci_dev *pdev,
                dev_info(dev, "loopback tag=0x%04x\n", enic->loop_tag);
        }
        if (ENIC_SETTING(enic, TXCSUM))
-                netdev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
+                netdev->hw_features |= NETIF_F_SG | NETIF_F_HW_CSUM;
        if (ENIC_SETTING(enic, TSO))
-                netdev->features |= NETIF_F_TSO |
+                netdev->hw_features |= NETIF_F_TSO |
                        NETIF_F_TSO6 | NETIF_F_TSO_ECN;
-        if (ENIC_SETTING(enic, LRO))
+        if (ENIC_SETTING(enic, RXCSUM))
-                netdev->features |= NETIF_F_GRO;
+                netdev->hw_features |= NETIF_F_RXCSUM;
+        netdev->features |= netdev->hw_features;
        if (using_dac)
                netdev->features |= NETIF_F_HIGHDMA;
-        enic->csum_rx_enabled = ENIC_SETTING(enic, RXCSUM);
        err = register_netdev(netdev);
        if (err) {
                dev_err(dev, "Cannot register net device, aborting\n");
diff --git a/drivers/net/enic/enic_pp.c b/drivers/net/enic/enic_pp.c
new file mode 100644
index 000000000000..ffaa75dd1ded
--- /dev/null
+++ b/drivers/net/enic/enic_pp.c
@@ -0,0 +1,264 @@
+/*
+ * Copyright 2011 Cisco Systems, Inc.  All rights reserved.
+ *
+ * This program is free software; you may redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
+ * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
+ * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+ * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ *
+ */
+#include <linux/kernel.h>
+#include <linux/string.h>
+#include <linux/errno.h>
+#include <linux/types.h>
+#include <linux/netdevice.h>
+#include <linux/etherdevice.h>
+#include <linux/rtnetlink.h>
+#include <net/ip.h>
+#include "vnic_vic.h"
+#include "enic_res.h"
+#include "enic.h"
+#include "enic_dev.h"
+static int enic_set_port_profile(struct enic *enic)
+{
+        struct net_device *netdev = enic->netdev;
+        struct vic_provinfo *vp;
+        const u8 oui[3] = VIC_PROVINFO_CISCO_OUI;
+        const u16 os_type = htons(VIC_GENERIC_PROV_OS_TYPE_LINUX);
+        char uuid_str[38];
+        char client_mac_str[18];
+        u8 *client_mac;
+        int err;
+        if (!(enic->pp.set & ENIC_SET_NAME) || !strlen(enic->pp.name))
+                return -EINVAL;
+        vp = vic_provinfo_alloc(GFP_KERNEL, oui,
+                VIC_PROVINFO_GENERIC_TYPE);
+        if (!vp)
+                return -ENOMEM;
+        VIC_PROVINFO_ADD_TLV(vp,
+                VIC_GENERIC_PROV_TLV_PORT_PROFILE_NAME_STR,
+                strlen(enic->pp.name) + 1, enic->pp.name);
+        if (!is_zero_ether_addr(enic->pp.mac_addr))
+                client_mac = enic->pp.mac_addr;
+        else
+                client_mac = netdev->dev_addr;
+        VIC_PROVINFO_ADD_TLV(vp,
+                VIC_GENERIC_PROV_TLV_CLIENT_MAC_ADDR,
+                ETH_ALEN, client_mac);
+        snprintf(client_mac_str, sizeof(client_mac_str), "%pM", client_mac);
+        VIC_PROVINFO_ADD_TLV(vp,
+                VIC_GENERIC_PROV_TLV_CLUSTER_PORT_UUID_STR,
+                sizeof(client_mac_str), client_mac_str);
+        if (enic->pp.set & ENIC_SET_INSTANCE) {
+                sprintf(uuid_str, "%pUB", enic->pp.instance_uuid);
+                VIC_PROVINFO_ADD_TLV(vp,
+                        VIC_GENERIC_PROV_TLV_CLIENT_UUID_STR,
+                        sizeof(uuid_str), uuid_str);
+        }
+        if (enic->pp.set & ENIC_SET_HOST) {
+                sprintf(uuid_str, "%pUB", enic->pp.host_uuid);
+                VIC_PROVINFO_ADD_TLV(vp,
+                        VIC_GENERIC_PROV_TLV_HOST_UUID_STR,
+                        sizeof(uuid_str), uuid_str);
+        }
+        VIC_PROVINFO_ADD_TLV(vp,
+                VIC_GENERIC_PROV_TLV_OS_TYPE,
+                sizeof(os_type), &os_type);
+        err = enic_dev_status_to_errno(enic_dev_init_prov2(enic, vp));
+add_tlv_failure:
+        vic_provinfo_free(vp);
+        return err;
+}
+static int enic_unset_port_profile(struct enic *enic)
+{
+        int err;
+        err = enic_vnic_dev_deinit(enic);
+        if (err)
+                return enic_dev_status_to_errno(err);
+        enic_reset_addr_lists(enic);
+        return 0;
+}
+static int enic_are_pp_different(struct enic_port_profile *pp1,
+                struct enic_port_profile *pp2)
+{
+        return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid,
+                pp2->instance_uuid, PORT_UUID_MAX) |
+                !!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) |
+                !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN);
+}
+static int enic_pp_preassociate(struct enic *enic,
+        struct enic_port_profile *prev_pp, int *restore_pp);
+static int enic_pp_disassociate(struct enic *enic,
+        struct enic_port_profile *prev_pp, int *restore_pp);
+static int enic_pp_preassociate_rr(struct enic *enic,
+        struct enic_port_profile *prev_pp, int *restore_pp);
+static int enic_pp_associate(struct enic *enic,
+        struct enic_port_profile *prev_pp, int *restore_pp);
+static int (*enic_pp_handlers[])(struct enic *enic,
+                struct enic_port_profile *prev_state, int *restore_pp) = {
+        [PORT_REQUEST_PREASSOCIATE]     = enic_pp_preassociate,
+        [PORT_REQUEST_PREASSOCIATE_RR]  = enic_pp_preassociate_rr,
+        [PORT_REQUEST_ASSOCIATE]        = enic_pp_associate,
+        [PORT_REQUEST_DISASSOCIATE]     = enic_pp_disassociate,
+};
+static const int enic_pp_handlers_count =
+                        sizeof(enic_pp_handlers)/sizeof(*enic_pp_handlers);
+static int enic_pp_preassociate(struct enic *enic,
+        struct enic_port_profile *prev_pp, int *restore_pp)
+{
+        return -EOPNOTSUPP;
+}
+static int enic_pp_disassociate(struct enic *enic,
+        struct enic_port_profile *prev_pp, int *restore_pp)
+{
+        return enic_unset_port_profile(enic);
+}
+static int enic_pp_preassociate_rr(struct enic *enic,
+        struct enic_port_profile *prev_pp, int *restore_pp)
+{
+        int err;
+        int active = 0;
+        if (enic->pp.request != PORT_REQUEST_ASSOCIATE) {
+                /* If pre-associate is not part of an associate.
+                We always disassociate first */
+                err = enic_pp_handlers[PORT_REQUEST_DISASSOCIATE](enic,
+                        prev_pp, restore_pp);
+                if (err)
+                        return err;
+                *restore_pp = 0;
+        }
+        *restore_pp = 0;
+        err = enic_set_port_profile(enic);
+        if (err)
+                return err;
+        /* If pre-associate is not part of an associate. */
+        if (enic->pp.request != PORT_REQUEST_ASSOCIATE)
+                err = enic_dev_status_to_errno(enic_dev_enable2(enic, active));
+        return err;
+}
+static int enic_pp_associate(struct enic *enic,
+        struct enic_port_profile *prev_pp, int *restore_pp)
+{
+        int err;
+        int active = 1;
+        /* Check if a pre-associate was called before */
+        if (prev_pp->request != PORT_REQUEST_PREASSOCIATE_RR ||
+                (prev_pp->request == PORT_REQUEST_PREASSOCIATE_RR &&
+                        enic_are_pp_different(prev_pp, &enic->pp))) {
+                err = enic_pp_handlers[PORT_REQUEST_DISASSOCIATE](
+                        enic, prev_pp, restore_pp);
+                if (err)
+                        return err;
+                *restore_pp = 0;
+        }
+        err = enic_pp_handlers[PORT_REQUEST_PREASSOCIATE_RR](
+                        enic, prev_pp, restore_pp);
+        if (err)
+                return err;
+        *restore_pp = 0;
+        return enic_dev_status_to_errno(enic_dev_enable2(enic, active));
+}
+int enic_process_set_pp_request(struct enic *enic,
+        struct enic_port_profile *prev_pp, int *restore_pp)
+{
+        if (enic->pp.request < enic_pp_handlers_count
+                && enic_pp_handlers[enic->pp.request])
+                return enic_pp_handlers[enic->pp.request](enic,
+                        prev_pp, restore_pp);
+        else
+                return -EOPNOTSUPP;
+}
+int enic_process_get_pp_request(struct enic *enic, int request,
+        u16 *response)
+{
+        int err, status = ERR_SUCCESS;
+        switch (request) {
+        case PORT_REQUEST_PREASSOCIATE_RR:
+        case PORT_REQUEST_ASSOCIATE:
+                err = enic_dev_enable2_done(enic, &status);
+                break;
+        case PORT_REQUEST_DISASSOCIATE:
+                err = enic_dev_deinit_done(enic, &status);
+                break;
+        default:
+                return -EINVAL;
+        }
+        if (err)
+                status = err;
+        switch (status) {
+        case ERR_SUCCESS:
+                *response = PORT_PROFILE_RESPONSE_SUCCESS;
+                break;
+        case ERR_EINVAL:
+                *response = PORT_PROFILE_RESPONSE_INVALID;
+                break;
+        case ERR_EBADSTATE:
+                *response = PORT_PROFILE_RESPONSE_BADSTATE;
+                break;
+        case ERR_ENOMEM:
+                *response = PORT_PROFILE_RESPONSE_INSUFFICIENT_RESOURCES;
+                break;
+        case ERR_EINPROGRESS:
+                *response = PORT_PROFILE_RESPONSE_INPROGRESS;
+                break;
+        default:
+                *response = PORT_PROFILE_RESPONSE_ERROR;
+                break;
+        }
+        return 0;
+}
diff --git a/drivers/net/enic/enic_pp.h b/drivers/net/enic/enic_pp.h
new file mode 100644
index 000000000000..699e365a944d
--- /dev/null
+++ b/drivers/net/enic/enic_pp.h
@@ -0,0 +1,27 @@
+/*
+ * Copyright 2011 Cisco Systems, Inc.  All rights reserved.
+ *
+ * This program is free software; you may redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
+ * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
+ * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+ * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ *
+ */
+#ifndef _ENIC_PP_H_
+#define _ENIC_PP_H_
+int enic_process_set_pp_request(struct enic *enic,
+        struct enic_port_profile *prev_pp, int *restore_pp);
+int enic_process_get_pp_request(struct enic *enic, int request,
+        u16 *response);
+#endif /* _ENIC_PP_H_ */
diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c
index f111a37419ce..6e5c6356e7df 100644
--- a/drivers/net/enic/enic_res.c
+++ b/drivers/net/enic/enic_res.c
@@ -98,9 +98,9 @@ int enic_get_vnic_config(struct enic *enic)
                "vNIC MAC addr %pM wq/rq %d/%d mtu %d\n",
                enic->mac_addr, c->wq_desc_count, c->rq_desc_count, c->mtu);
        dev_info(enic_get_dev(enic), "vNIC csum tx/rx %d/%d "
-                "tso/lro %d/%d intr timer %d usec rss %d\n",
+                "tso %d intr timer %d usec rss %d\n",
                ENIC_SETTING(enic, TXCSUM), ENIC_SETTING(enic, RXCSUM),
-                ENIC_SETTING(enic, TSO), ENIC_SETTING(enic, LRO),
+                ENIC_SETTING(enic, TSO),
                c->intr_timer_usec, ENIC_SETTING(enic, RSS));
        return 0;
diff --git a/drivers/net/enic/vnic_dev.c b/drivers/net/enic/vnic_dev.c
index c089b362a36f..68f24ae860ae 100644
--- a/drivers/net/enic/vnic_dev.c
+++ b/drivers/net/enic/vnic_dev.c
@@ -786,48 +786,6 @@ int vnic_dev_init(struct vnic_dev *vdev, int arg)
        return r;
 }
-int vnic_dev_init_done(struct vnic_dev *vdev, int *done, int *err)
-{
-        u64 a0 = 0, a1 = 0;
-        int wait = 1000;
-        int ret;
-        *done = 0;
-        ret = vnic_dev_cmd(vdev, CMD_INIT_STATUS, &a0, &a1, wait);
-        if (ret)
-                return ret;
-        *done = (a0 == 0);
-        *err = (a0 == 0) ? (int)a1:0;
-        return 0;
-}
-int vnic_dev_init_prov(struct vnic_dev *vdev, u8 *buf, u32 len)
-{
-        u64 a0, a1 = len;
-        int wait = 1000;
-        dma_addr_t prov_pa;
-        void *prov_buf;
-        int ret;
-        prov_buf = pci_alloc_consistent(vdev->pdev, len, &prov_pa);
-        if (!prov_buf)
-                return -ENOMEM;
-        memcpy(prov_buf, buf, len);
-        a0 = prov_pa;
-        ret = vnic_dev_cmd(vdev, CMD_INIT_PROV_INFO, &a0, &a1, wait);
-        pci_free_consistent(vdev->pdev, len, prov_buf, prov_pa);
-        return ret;
-}
 int vnic_dev_deinit(struct vnic_dev *vdev)
 {
        u64 a0 = 0, a1 = 0;
@@ -927,4 +885,59 @@ err_out:
        return NULL;
 }
+int vnic_dev_init_prov2(struct vnic_dev *vdev, u8 *buf, u32 len)
+{
+        u64 a0, a1 = len;
+        int wait = 1000;
+        dma_addr_t prov_pa;
+        void *prov_buf;
+        int ret;
+        prov_buf = pci_alloc_consistent(vdev->pdev, len, &prov_pa);
+        if (!prov_buf)
+                return -ENOMEM;
+        memcpy(prov_buf, buf, len);
+        a0 = prov_pa;
+        ret = vnic_dev_cmd(vdev, CMD_INIT_PROV_INFO2, &a0, &a1, wait);
+        pci_free_consistent(vdev->pdev, len, prov_buf, prov_pa);
+        return ret;
+}
+int vnic_dev_enable2(struct vnic_dev *vdev, int active)
+{
+        u64 a0, a1 = 0;
+        int wait = 1000;
+        a0 = (active ? CMD_ENABLE2_ACTIVE : 0);
+        return vnic_dev_cmd(vdev, CMD_ENABLE2, &a0, &a1, wait);
+}
+static int vnic_dev_cmd_status(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd,
+        int *status)
+{
+        u64 a0 = cmd, a1 = 0;
+        int wait = 1000;
+        int ret;
+        ret = vnic_dev_cmd(vdev, CMD_STATUS, &a0, &a1, wait);
+        if (!ret)
+                *status = (int)a0;
+        return ret;
+}
+int vnic_dev_enable2_done(struct vnic_dev *vdev, int *status)
+{
+        return vnic_dev_cmd_status(vdev, CMD_ENABLE2, status);
+}
+int vnic_dev_deinit_done(struct vnic_dev *vdev, int *status)
+{
+        return vnic_dev_cmd_status(vdev, CMD_DEINIT, status);
+}
diff --git a/drivers/net/enic/vnic_dev.h b/drivers/net/enic/vnic_dev.h
index e837546213a8..cf482a2c9dd9 100644
--- a/drivers/net/enic/vnic_dev.h
+++ b/drivers/net/enic/vnic_dev.h
@@ -108,8 +108,6 @@ int vnic_dev_disable(struct vnic_dev *vdev);
 int vnic_dev_open(struct vnic_dev *vdev, int arg);
 int vnic_dev_open_done(struct vnic_dev *vdev, int *done);
 int vnic_dev_init(struct vnic_dev *vdev, int arg);
-int vnic_dev_init_done(struct vnic_dev *vdev, int *done, int *err);
-int vnic_dev_init_prov(struct vnic_dev *vdev, u8 *buf, u32 len);
 int vnic_dev_deinit(struct vnic_dev *vdev);
 int vnic_dev_hang_reset(struct vnic_dev *vdev, int arg);
 int vnic_dev_hang_reset_done(struct vnic_dev *vdev, int *done);
@@ -122,5 +120,9 @@ int vnic_dev_set_ig_vlan_rewrite_mode(struct vnic_dev *vdev,
 struct vnic_dev *vnic_dev_register(struct vnic_dev *vdev,
        void *priv, struct pci_dev *pdev, struct vnic_dev_bar *bar,
        unsigned int num_bars);
+int vnic_dev_init_prov2(struct vnic_dev *vdev, u8 *buf, u32 len);
+int vnic_dev_enable2(struct vnic_dev *vdev, int active);
+int vnic_dev_enable2_done(struct vnic_dev *vdev, int *status);
+int vnic_dev_deinit_done(struct vnic_dev *vdev, int *status);
 #endif /* _VNIC_DEV_H_ */
diff --git a/drivers/net/enic/vnic_devcmd.h b/drivers/net/enic/vnic_devcmd.h
index d833a071bac5..c5569bfb47ac 100644
--- a/drivers/net/enic/vnic_devcmd.h
+++ b/drivers/net/enic/vnic_devcmd.h
@@ -267,17 +267,62 @@ enum vnic_devcmd_cmd {
        /*
         * As for BY_BDF except a0 is index of hvnlink subordinate vnic
-         * or SR-IOV virtual vnic */
+         * or SR-IOV virtual vnic
+         */
        CMD_PROXY_BY_INDEX =    _CMDC(_CMD_DIR_RW, _CMD_VTYPE_ALL, 43),
        /*
-         * in:  (u64)a0=paddr of buffer to put latest VIC VIF-CONFIG-INFO TLV in
+         * For HPP toggle:
-         *      (u32)a1=length of buffer in a0
+         * adapter-info-get
-         * out: (u64)a0=paddr of buffer with latest VIC VIF-CONFIG-INFO TLV
+         * in:  (u64)a0=phsical address of buffer passed in from caller.
-         *      (u32)a1=actual length of latest VIC VIF-CONFIG-INFO TLV */
+         *      (u16)a1=size of buffer specified in a0.
+         * out: (u64)a0=phsical address of buffer passed in from caller.
+         *      (u16)a1=actual bytes from VIF-CONFIG-INFO TLV, or
+         *              0 if no VIF-CONFIG-INFO TLV was ever received. */
        CMD_CONFIG_INFO_GET     = _CMDC(_CMD_DIR_RW, _CMD_VTYPE_ALL, 44),
+        /* init_prov_info2:
+         * Variant of CMD_INIT_PROV_INFO, where it will not try to enable
+         * the vnic until CMD_ENABLE2 is issued.
+         *     (u64)a0=paddr of vnic_devcmd_provinfo
+         *     (u32)a1=sizeof provision info */
+        CMD_INIT_PROV_INFO2  = _CMDC(_CMD_DIR_WRITE, _CMD_VTYPE_ENET, 47),
+        /* enable2:
+         *      (u32)a0=0                  ==> standby
+         *             =CMD_ENABLE2_ACTIVE ==> active
+         */
+        CMD_ENABLE2 = _CMDC(_CMD_DIR_WRITE, _CMD_VTYPE_ENET, 48),
+        /*
+         * cmd_status:
+         *     Returns the status of the specified command
+         * Input:
+         *     a0 = command for which status is being queried.
+         *          Possible values are:
+         *              CMD_SOFT_RESET
+         *              CMD_HANG_RESET
+         *              CMD_OPEN
+         *              CMD_INIT
+         *              CMD_INIT_PROV_INFO
+         *              CMD_DEINIT
+         *              CMD_INIT_PROV_INFO2
+         *              CMD_ENABLE2
+         * Output:
+         *     if status == STAT_ERROR
+         *        a0 = ERR_ENOTSUPPORTED - status for command in a0 is
+         *                                 not supported
+         *     if status == STAT_NONE
+         *        a0 = status of the devcmd specified in a0 as follows.
+         *             ERR_SUCCESS   - command in a0 completed successfully
+         *             ERR_EINPROGRESS - command in a0 is still in progress
+         */
+        CMD_STATUS = _CMDC(_CMD_DIR_RW, _CMD_VTYPE_ALL, 49),
 };
+/* CMD_ENABLE2 flags */
+#define CMD_ENABLE2_ACTIVE  0x1
 /* flags for CMD_OPEN */
 #define CMD_OPENF_OPROM         0x1     /* open coming from option rom */
@@ -315,6 +360,8 @@ enum vnic_devcmd_error {
        ERR_ETIMEDOUT = 8,
        ERR_ELINKDOWN = 9,
        ERR_EMAXRES = 10,
+        ERR_ENOTSUPPORTED = 11,
+        ERR_EINPROGRESS = 12,
 };
 /*
diff --git a/drivers/net/enic/vnic_vic.c b/drivers/net/enic/vnic_vic.c
index 4725b79de0ef..24ef8cd40545 100644
--- a/drivers/net/enic/vnic_vic.c
+++ b/drivers/net/enic/vnic_vic.c
@@ -23,7 +23,8 @@
 #include "vnic_vic.h"
-struct vic_provinfo *vic_provinfo_alloc(gfp_t flags, u8 *oui, u8 type)
+struct vic_provinfo *vic_provinfo_alloc(gfp_t flags, const u8 *oui,
+        const u8 type)
 {
        struct vic_provinfo *vp;
@@ -47,7 +48,7 @@ void vic_provinfo_free(struct vic_provinfo *vp)
 }
 int vic_provinfo_add_tlv(struct vic_provinfo *vp, u16 type, u16 length,
-        void *value)
+        const void *value)
 {
        struct vic_provinfo_tlv *tlv;
diff --git a/drivers/net/enic/vnic_vic.h b/drivers/net/enic/vnic_vic.h
index f700f5d9e81d..9ef81f148351 100644
--- a/drivers/net/enic/vnic_vic.h
+++ b/drivers/net/enic/vnic_vic.h
@@ -47,6 +47,7 @@ enum vic_generic_prov_os_type {
        VIC_GENERIC_PROV_OS_TYPE_ESX = 1,
        VIC_GENERIC_PROV_OS_TYPE_LINUX = 2,
        VIC_GENERIC_PROV_OS_TYPE_WINDOWS = 3,
+        VIC_GENERIC_PROV_OS_TYPE_SOLARIS = 4,
 };
 struct vic_provinfo {
@@ -61,14 +62,22 @@ struct vic_provinfo {
        } tlv[0];
 } __packed;
+#define VIC_PROVINFO_ADD_TLV(vp, tlvtype, tlvlen, data) \
+        do { \
+                err = vic_provinfo_add_tlv(vp, tlvtype, tlvlen, data); \
+                if (err) \
+                        goto add_tlv_failure; \
+        } while (0)
 #define VIC_PROVINFO_MAX_DATA           1385
 #define VIC_PROVINFO_MAX_TLV_DATA (VIC_PROVINFO_MAX_DATA - \
        sizeof(struct vic_provinfo))
-struct vic_provinfo *vic_provinfo_alloc(gfp_t flags, u8 *oui, u8 type);
+struct vic_provinfo *vic_provinfo_alloc(gfp_t flags, const u8 *oui,
+        const u8 type);
 void vic_provinfo_free(struct vic_provinfo *vp);
 int vic_provinfo_add_tlv(struct vic_provinfo *vp, u16 type, u16 length,
-        void *value);
+        const void *value);
 size_t vic_provinfo_size(struct vic_provinfo *vp);
 #endif  /* _VNIC_VIC_H_ */
diff --git a/drivers/net/ewrk3.c b/drivers/net/ewrk3.c
index 380d0614a89a..b5f6173130f4 100644
--- a/drivers/net/ewrk3.c
+++ b/drivers/net/ewrk3.c
@@ -1545,7 +1545,7 @@ static int ewrk3_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
        }
        ecmd->supported |= SUPPORTED_10baseT_Half;
-        ecmd->speed = SPEED_10;
+        ethtool_cmd_speed_set(ecmd, SPEED_10);
        ecmd->duplex = DUPLEX_HALF;
        return 0;
 }
@@ -1604,55 +1604,47 @@ static u32 ewrk3_get_link(struct net_device *dev)
        return !(cmr & CMR_LINK);
 }
-static int ewrk3_phys_id(struct net_device *dev, u32 data)
+static int ewrk3_set_phys_id(struct net_device *dev,
+                             enum ethtool_phys_id_state state)
 {
        struct ewrk3_private *lp = netdev_priv(dev);
        unsigned long iobase = dev->base_addr;
-        unsigned long flags;
        u8 cr;
-        int count;
-        /* Toggle LED 4x per second */
-        count = data << 2;
-        spin_lock_irqsave(&lp->hw_lock, flags);
+        spin_lock_irq(&lp->hw_lock);
-        /* Bail if a PHYS_ID is already in progress */
-        if (lp->led_mask == 0) {
-                spin_unlock_irqrestore(&lp->hw_lock, flags);
-                return -EBUSY;
-        }
-        /* Prevent ISR from twiddling the LED */
+        switch (state) {
-        lp->led_mask = 0;
+        case ETHTOOL_ID_ACTIVE:
+                /* Prevent ISR from twiddling the LED */
+                lp->led_mask = 0;
+                spin_unlock_irq(&lp->hw_lock);
+                return 2;       /* cycle on/off twice per second */
-        while (count--) {
+        case ETHTOOL_ID_ON:
-                /* Toggle the LED */
                cr = inb(EWRK3_CR);
-                outb(cr ^ CR_LED, EWRK3_CR);
+                outb(cr | CR_LED, EWRK3_CR);
+                break;
-                /* Wait a little while */
+        case ETHTOOL_ID_OFF:
-                spin_unlock_irqrestore(&lp->hw_lock, flags);
+                cr = inb(EWRK3_CR);
-                msleep(250);
+                outb(cr & ~CR_LED, EWRK3_CR);
-                spin_lock_irqsave(&lp->hw_lock, flags);
+                break;
-                /* Exit if we got a signal */
+        case ETHTOOL_ID_INACTIVE:
-                if (signal_pending(current))
+                lp->led_mask = CR_LED;
-                        break;
+                cr = inb(EWRK3_CR);
+                outb(cr & ~CR_LED, EWRK3_CR);
        }
+        spin_unlock_irq(&lp->hw_lock);
-        lp->led_mask = CR_LED;
+        return 0;
-        cr = inb(EWRK3_CR);
-        outb(cr & ~CR_LED, EWRK3_CR);
-        spin_unlock_irqrestore(&lp->hw_lock, flags);
-        return signal_pending(current) ? -ERESTARTSYS : 0;
 }
 static const struct ethtool_ops ethtool_ops_203 = {
        .get_drvinfo = ewrk3_get_drvinfo,
        .get_settings = ewrk3_get_settings,
        .set_settings = ewrk3_set_settings,
-        .phys_id = ewrk3_phys_id,
+        .set_phys_id = ewrk3_set_phys_id,
 };
 static const struct ethtool_ops ethtool_ops = {
@@ -1660,7 +1652,7 @@ static const struct ethtool_ops ethtool_ops = {
        .get_settings = ewrk3_get_settings,
        .set_settings = ewrk3_set_settings,
        .get_link = ewrk3_get_link,
-        .phys_id = ewrk3_phys_id,
+        .set_phys_id = ewrk3_set_phys_id,
 };
 /*
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index d5ab4dad5051..d09e8b0add01 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -774,7 +774,6 @@ struct fe_priv {
        u32 driver_data;
        u32 device_id;
        u32 register_size;
-        int rx_csum;
        u32 mac_in_use;
        int mgmt_version;
        int mgmt_sema;
@@ -3956,6 +3955,7 @@ static int nv_set_wol(struct net_device *dev, struct ethtool_wolinfo *wolinfo)
 static int nv_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
 {
        struct fe_priv *np = netdev_priv(dev);
+        u32 speed;
        int adv;
        spin_lock_irq(&np->lock);
@@ -3975,23 +3975,26 @@ static int nv_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
        if (netif_carrier_ok(dev)) {
                switch (np->linkspeed & (NVREG_LINKSPEED_MASK)) {
                case NVREG_LINKSPEED_10:
-                        ecmd->speed = SPEED_10;
+                        speed = SPEED_10;
                        break;
                case NVREG_LINKSPEED_100:
-                        ecmd->speed = SPEED_100;
+                        speed = SPEED_100;
                        break;
                case NVREG_LINKSPEED_1000:
-                        ecmd->speed = SPEED_1000;
+                        speed = SPEED_1000;
+                        break;
+                default:
+                        speed = -1;
                        break;
                }
                ecmd->duplex = DUPLEX_HALF;
                if (np->duplex)
                        ecmd->duplex = DUPLEX_FULL;
        } else {
-                ecmd->speed = -1;
+                speed = -1;
                ecmd->duplex = -1;
        }
+        ethtool_cmd_speed_set(ecmd, speed);
        ecmd->autoneg = np->autoneg;
        ecmd->advertising = ADVERTISED_MII;
@@ -4030,6 +4033,7 @@ static int nv_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
 static int nv_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
 {
        struct fe_priv *np = netdev_priv(dev);
+        u32 speed = ethtool_cmd_speed(ecmd);
        if (ecmd->port != PORT_MII)
                return -EINVAL;
@@ -4055,7 +4059,7 @@ static int nv_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                /* Note: autonegotiation disable, speed 1000 intentionally
                 * forbidden - no one should need that. */
-                if (ecmd->speed != SPEED_10 && ecmd->speed != SPEED_100)
+                if (speed != SPEED_10 && speed != SPEED_100)
                        return -EINVAL;
                if (ecmd->duplex != DUPLEX_HALF && ecmd->duplex != DUPLEX_FULL)
                        return -EINVAL;
@@ -4139,13 +4143,13 @@ static int nv_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                adv = mii_rw(dev, np->phyaddr, MII_ADVERTISE, MII_READ);
                adv &= ~(ADVERTISE_ALL | ADVERTISE_100BASE4 | ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM);
-                if (ecmd->speed == SPEED_10 && ecmd->duplex == DUPLEX_HALF)
+                if (speed == SPEED_10 && ecmd->duplex == DUPLEX_HALF)
                        adv |= ADVERTISE_10HALF;
-                if (ecmd->speed == SPEED_10 && ecmd->duplex == DUPLEX_FULL)
+                if (speed == SPEED_10 && ecmd->duplex == DUPLEX_FULL)
                        adv |= ADVERTISE_10FULL;
-                if (ecmd->speed == SPEED_100 && ecmd->duplex == DUPLEX_HALF)
+                if (speed == SPEED_100 && ecmd->duplex == DUPLEX_HALF)
                        adv |= ADVERTISE_100HALF;
-                if (ecmd->speed == SPEED_100 && ecmd->duplex == DUPLEX_FULL)
+                if (speed == SPEED_100 && ecmd->duplex == DUPLEX_FULL)
                        adv |= ADVERTISE_100FULL;
                np->pause_flags &= ~(NV_PAUSEFRAME_AUTONEG|NV_PAUSEFRAME_RX_ENABLE|NV_PAUSEFRAME_TX_ENABLE);
                if (np->pause_flags & NV_PAUSEFRAME_RX_REQ) {/* for rx we set both advertisements but disable tx pause */
@@ -4264,16 +4268,6 @@ static int nv_nway_reset(struct net_device *dev)
        return ret;
 }
-static int nv_set_tso(struct net_device *dev, u32 value)
-{
-        struct fe_priv *np = netdev_priv(dev);
-        if ((np->driver_data & DEV_HAS_CHECKSUM))
-                return ethtool_op_set_tso(dev, value);
-        else
-                return -EOPNOTSUPP;
-}
 static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* ring)
 {
        struct fe_priv *np = netdev_priv(dev);
@@ -4480,58 +4474,36 @@ static int nv_set_pauseparam(struct net_device *dev, struct ethtool_pauseparam*
        return 0;
 }
-static u32 nv_get_rx_csum(struct net_device *dev)
+static u32 nv_fix_features(struct net_device *dev, u32 features)
 {
-        struct fe_priv *np = netdev_priv(dev);
+        /* vlan is dependent on rx checksum offload */
-        return np->rx_csum != 0;
+        if (features & (NETIF_F_HW_VLAN_TX|NETIF_F_HW_VLAN_RX))
+                features |= NETIF_F_RXCSUM;
+        return features;
 }
-static int nv_set_rx_csum(struct net_device *dev, u32 data)
+static int nv_set_features(struct net_device *dev, u32 features)
 {
        struct fe_priv *np = netdev_priv(dev);
        u8 __iomem *base = get_hwbase(dev);
-        int retcode = 0;
+        u32 changed = dev->features ^ features;
-        if (np->driver_data & DEV_HAS_CHECKSUM) {
-                if (data) {
-                        np->rx_csum = 1;
-                        np->txrxctl_bits |= NVREG_TXRXCTL_RXCHECK;
-                } else {
-                        np->rx_csum = 0;
-                        /* vlan is dependent on rx checksum offload */
-                        if (!(np->vlanctl_bits & NVREG_VLANCONTROL_ENABLE))
-                                np->txrxctl_bits &= ~NVREG_TXRXCTL_RXCHECK;
-                }
-                if (netif_running(dev)) {
-                        spin_lock_irq(&np->lock);
-                        writel(np->txrxctl_bits, base + NvRegTxRxControl);
-                        spin_unlock_irq(&np->lock);
-                }
-        } else {
-                return -EINVAL;
-        }
-        return retcode;
+        if (changed & NETIF_F_RXCSUM) {
-}
+                spin_lock_irq(&np->lock);
-static int nv_set_tx_csum(struct net_device *dev, u32 data)
+                if (features & NETIF_F_RXCSUM)
-{
+                        np->txrxctl_bits |= NVREG_TXRXCTL_RXCHECK;
-        struct fe_priv *np = netdev_priv(dev);
+                else
+                        np->txrxctl_bits &= ~NVREG_TXRXCTL_RXCHECK;
-        if (np->driver_data & DEV_HAS_CHECKSUM)
+                if (netif_running(dev))
-                return ethtool_op_set_tx_csum(dev, data);
+                        writel(np->txrxctl_bits, base + NvRegTxRxControl);
-        else
-                return -EOPNOTSUPP;
-}
-static int nv_set_sg(struct net_device *dev, u32 data)
+                spin_unlock_irq(&np->lock);
-{
+        }
-        struct fe_priv *np = netdev_priv(dev);
-        if (np->driver_data & DEV_HAS_CHECKSUM)
+        return 0;
-                return ethtool_op_set_sg(dev, data);
-        else
-                return -EOPNOTSUPP;
 }
 static int nv_get_sset_count(struct net_device *dev, int sset)
@@ -4896,15 +4868,10 @@ static const struct ethtool_ops ops = {
        .get_regs_len = nv_get_regs_len,
        .get_regs = nv_get_regs,
        .nway_reset = nv_nway_reset,
-        .set_tso = nv_set_tso,
        .get_ringparam = nv_get_ringparam,
        .set_ringparam = nv_set_ringparam,
        .get_pauseparam = nv_get_pauseparam,
        .set_pauseparam = nv_set_pauseparam,
-        .get_rx_csum = nv_get_rx_csum,
-        .set_rx_csum = nv_set_rx_csum,
-        .set_tx_csum = nv_set_tx_csum,
-        .set_sg = nv_set_sg,
        .get_strings = nv_get_strings,
        .get_ethtool_stats = nv_get_ethtool_stats,
        .get_sset_count = nv_get_sset_count,
@@ -5235,6 +5202,8 @@ static const struct net_device_ops nv_netdev_ops = {
        .ndo_start_xmit         = nv_start_xmit,
        .ndo_tx_timeout         = nv_tx_timeout,
        .ndo_change_mtu         = nv_change_mtu,
+        .ndo_fix_features       = nv_fix_features,
+        .ndo_set_features       = nv_set_features,
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_set_mac_address    = nv_set_mac_address,
        .ndo_set_multicast_list = nv_set_multicast,
@@ -5251,6 +5220,8 @@ static const struct net_device_ops nv_netdev_ops_optimized = {
        .ndo_start_xmit         = nv_start_xmit_optimized,
        .ndo_tx_timeout         = nv_tx_timeout,
        .ndo_change_mtu         = nv_change_mtu,
+        .ndo_fix_features       = nv_fix_features,
+        .ndo_set_features       = nv_set_features,
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_set_mac_address    = nv_set_mac_address,
        .ndo_set_multicast_list = nv_set_multicast,
@@ -5364,11 +5335,10 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
                np->pkt_limit = NV_PKTLIMIT_2;
        if (id->driver_data & DEV_HAS_CHECKSUM) {
-                np->rx_csum = 1;
                np->txrxctl_bits |= NVREG_TXRXCTL_RXCHECK;
-                dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
+                dev->hw_features |= NETIF_F_IP_CSUM | NETIF_F_SG |
-                dev->features |= NETIF_F_TSO;
+                        NETIF_F_TSO | NETIF_F_RXCSUM;
-                dev->features |= NETIF_F_GRO;
+                dev->features |= dev->hw_features;
        }
        np->vlanctl_bits = 0;
@@ -5384,7 +5354,6 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
                np->pause_flags |= NV_PAUSEFRAME_TX_CAPABLE | NV_PAUSEFRAME_TX_REQ;
        }
        err = -ENOMEM;
        np->base = ioremap(addr, np->register_size);
        if (!np->base)
diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
index 5131e61c358c..21abb5c01a56 100644
--- a/drivers/net/fs_enet/fs_enet-main.c
+++ b/drivers/net/fs_enet/fs_enet-main.c
@@ -956,8 +956,6 @@ static const struct ethtool_ops fs_ethtool_ops = {
        .get_link = ethtool_op_get_link,
        .get_msglevel = fs_get_msglevel,
        .set_msglevel = fs_set_msglevel,
-        .set_tx_csum = ethtool_op_set_tx_csum,  /* local! */
-        .set_sg = ethtool_op_set_sg,
        .get_regs = fs_get_regs,
 };
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 2a0ad9a501bb..ff60b23a5b74 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -365,7 +365,7 @@ static void gfar_init_mac(struct net_device *ndev)
                gfar_write(&regs->rir0, DEFAULT_RIR0);
        }
-        if (priv->rx_csum_enable)
+        if (ndev->features & NETIF_F_RXCSUM)
                rctrl |= RCTRL_CHECKSUMMING;
        if (priv->extended_hash) {
@@ -463,6 +463,7 @@ static const struct net_device_ops gfar_netdev_ops = {
        .ndo_start_xmit = gfar_start_xmit,
        .ndo_stop = gfar_close,
        .ndo_change_mtu = gfar_change_mtu,
+        .ndo_set_features = gfar_set_features,
        .ndo_set_multicast_list = gfar_set_multi,
        .ndo_tx_timeout = gfar_timeout,
        .ndo_do_ioctl = gfar_ioctl,
@@ -513,7 +514,7 @@ void unlock_tx_qs(struct gfar_private *priv)
 /* Returns 1 if incoming frames use an FCB */
 static inline int gfar_uses_fcb(struct gfar_private *priv)
 {
-        return priv->vlgrp || priv->rx_csum_enable ||
+        return priv->vlgrp || (priv->ndev->features & NETIF_F_RXCSUM) ||
                (priv->device_flags & FSL_GIANFAR_DEV_HAS_TIMER);
 }
@@ -1030,10 +1031,11 @@ static int gfar_probe(struct platform_device *ofdev)
                netif_napi_add(dev, &priv->gfargrp[i].napi, gfar_poll, GFAR_DEV_WEIGHT);
        if (priv->device_flags & FSL_GIANFAR_DEV_HAS_CSUM) {
-                priv->rx_csum_enable = 1;
+                dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG |
-                dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_HIGHDMA;
+                        NETIF_F_RXCSUM;
-        } else
+                dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG |
-                priv->rx_csum_enable = 0;
+                        NETIF_F_RXCSUM | NETIF_F_HIGHDMA;
+        }
        priv->vlgrp = NULL;
@@ -2697,7 +2699,7 @@ static int gfar_process_frame(struct net_device *dev, struct sk_buff *skb,
        if (priv->padding)
                skb_pull(skb, priv->padding);
-        if (priv->rx_csum_enable)
+        if (dev->features & NETIF_F_RXCSUM)
                gfar_rx_checksum(skb, fcb);
        /* Tell the skb what kind of packet this is */
diff --git a/drivers/net/gianfar.h b/drivers/net/gianfar.h
index b2fe7edefad9..fc86f5195445 100644
--- a/drivers/net/gianfar.h
+++ b/drivers/net/gianfar.h
@@ -382,23 +382,6 @@ extern const char gfar_driver_version[];
 #define BD_LFLAG(flags) ((flags) << 16)
 #define BD_LENGTH_MASK          0x0000ffff
-#define CLASS_CODE_UNRECOG              0x00
-#define CLASS_CODE_DUMMY1               0x01
-#define CLASS_CODE_ETHERTYPE1           0x02
-#define CLASS_CODE_ETHERTYPE2           0x03
-#define CLASS_CODE_USER_PROG1           0x04
-#define CLASS_CODE_USER_PROG2           0x05
-#define CLASS_CODE_USER_PROG3           0x06
-#define CLASS_CODE_USER_PROG4           0x07
-#define CLASS_CODE_TCP_IPV4             0x08
-#define CLASS_CODE_UDP_IPV4             0x09
-#define CLASS_CODE_AH_ESP_IPV4          0x0a
-#define CLASS_CODE_SCTP_IPV4            0x0b
-#define CLASS_CODE_TCP_IPV6             0x0c
-#define CLASS_CODE_UDP_IPV6             0x0d
-#define CLASS_CODE_AH_ESP_IPV6          0x0e
-#define CLASS_CODE_SCTP_IPV6            0x0f
 #define FPR_FILER_MASK  0xFFFFFFFF
 #define MAX_FILER_IDX   0xFF
@@ -1100,7 +1083,7 @@ struct gfar_private {
        struct device_node *phy_node;
        struct device_node *tbi_node;
        u32 device_flags;
-        unsigned char rx_csum_enable:1,
+        unsigned char
                extended_hash:1,
                bd_stash_en:1,
                rx_filer_enable:1,
@@ -1170,6 +1153,7 @@ extern void gfar_phy_test(struct mii_bus *bus, struct phy_device *phydev,
 extern void gfar_configure_coalescing(struct gfar_private *priv,
                unsigned long tx_mask, unsigned long rx_mask);
 void gfar_init_sysfs(struct net_device *dev);
+int gfar_set_features(struct net_device *dev, u32 features);
 extern const struct ethtool_ops gfar_ethtool_ops;
diff --git a/drivers/net/gianfar_ethtool.c b/drivers/net/gianfar_ethtool.c
index 3bc8e276ba4d..493d743839d9 100644
--- a/drivers/net/gianfar_ethtool.c
+++ b/drivers/net/gianfar_ethtool.c
@@ -517,15 +517,15 @@ static int gfar_sringparam(struct net_device *dev, struct ethtool_ringparam *rva
        return err;
 }
-static int gfar_set_rx_csum(struct net_device *dev, uint32_t data)
+int gfar_set_features(struct net_device *dev, u32 features)
 {
        struct gfar_private *priv = netdev_priv(dev);
        unsigned long flags;
        int err = 0, i = 0;
+        u32 changed = dev->features ^ features;
-        if (!(priv->device_flags & FSL_GIANFAR_DEV_HAS_CSUM))
+        if (!(changed & NETIF_F_RXCSUM))
-                return -EOPNOTSUPP;
+                return 0;
        if (dev->flags & IFF_UP) {
                /* Halt TX and RX, and process the frames which
@@ -546,58 +546,15 @@ static int gfar_set_rx_csum(struct net_device *dev, uint32_t data)
                /* Now we take down the rings to rebuild them */
                stop_gfar(dev);
-        }
-        spin_lock_irqsave(&priv->bflock, flags);
+                dev->features = features;
-        priv->rx_csum_enable = data;
-        spin_unlock_irqrestore(&priv->bflock, flags);
-        if (dev->flags & IFF_UP) {
                err = startup_gfar(dev);
                netif_tx_wake_all_queues(dev);
        }
        return err;
 }
-static uint32_t gfar_get_rx_csum(struct net_device *dev)
-{
-        struct gfar_private *priv = netdev_priv(dev);
-        if (!(priv->device_flags & FSL_GIANFAR_DEV_HAS_CSUM))
-                return 0;
-        return priv->rx_csum_enable;
-}
-static int gfar_set_tx_csum(struct net_device *dev, uint32_t data)
-{
-        struct gfar_private *priv = netdev_priv(dev);
-        if (!(priv->device_flags & FSL_GIANFAR_DEV_HAS_CSUM))
-                return -EOPNOTSUPP;
-        netif_tx_lock_bh(dev);
-        if (data)
-                dev->features |= NETIF_F_IP_CSUM;
-        else
-                dev->features &= ~NETIF_F_IP_CSUM;
-        netif_tx_unlock_bh(dev);
-        return 0;
-}
-static uint32_t gfar_get_tx_csum(struct net_device *dev)
-{
-        struct gfar_private *priv = netdev_priv(dev);
-        if (!(priv->device_flags & FSL_GIANFAR_DEV_HAS_CSUM))
-                return 0;
-        return (dev->features & NETIF_F_IP_CSUM) != 0;
-}
 static uint32_t gfar_get_msglevel(struct net_device *dev)
 {
        struct gfar_private *priv = netdev_priv(dev);
@@ -645,42 +602,6 @@ static int gfar_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
 }
 #endif
-static int gfar_ethflow_to_class(int flow_type, u64 *class)
-{
-        switch (flow_type) {
-        case TCP_V4_FLOW:
-                *class = CLASS_CODE_TCP_IPV4;
-                break;
-        case UDP_V4_FLOW:
-                *class = CLASS_CODE_UDP_IPV4;
-                break;
-        case AH_V4_FLOW:
-        case ESP_V4_FLOW:
-                *class = CLASS_CODE_AH_ESP_IPV4;
-                break;
-        case SCTP_V4_FLOW:
-                *class = CLASS_CODE_SCTP_IPV4;
-                break;
-        case TCP_V6_FLOW:
-                *class = CLASS_CODE_TCP_IPV6;
-                break;
-        case UDP_V6_FLOW:
-                *class = CLASS_CODE_UDP_IPV6;
-                break;
-        case AH_V6_FLOW:
-        case ESP_V6_FLOW:
-                *class = CLASS_CODE_AH_ESP_IPV6;
-                break;
-        case SCTP_V6_FLOW:
-                *class = CLASS_CODE_SCTP_IPV6;
-                break;
-        default:
-                return 0;
-        }
-        return 1;
-}
 static void ethflow_to_filer_rules (struct gfar_private *priv, u64 ethflow)
 {
        u32 fcr = 0x0, fpr = FPR_FILER_MASK;
@@ -778,11 +699,6 @@ static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow, u
        case UDP_V6_FLOW:
                cmp_rqfpr = RQFPR_IPV6 |RQFPR_UDP;
                break;
-        case IPV4_FLOW:
-                cmp_rqfpr = RQFPR_IPV4;
-        case IPV6_FLOW:
-                cmp_rqfpr = RQFPR_IPV6;
-                break;
        default:
                printk(KERN_ERR "Right now this class is not supported\n");
                return 0;
@@ -848,18 +764,9 @@ static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow, u
 static int gfar_set_hash_opts(struct gfar_private *priv, struct ethtool_rxnfc *cmd)
 {
-        u64 class;
-        if (!gfar_ethflow_to_class(cmd->flow_type, &class))
-                return -EINVAL;
-        if (class < CLASS_CODE_USER_PROG1 ||
-                        class > CLASS_CODE_SCTP_IPV6)
-                return -EINVAL;
        /* write the filer rules here */
        if (!gfar_ethflow_to_filer_table(priv, cmd->data, cmd->flow_type))
-                return -1;
+                return -EINVAL;
        return 0;
 }
@@ -894,11 +801,6 @@ const struct ethtool_ops gfar_ethtool_ops = {
        .get_strings = gfar_gstrings,
        .get_sset_count = gfar_sset_count,
        .get_ethtool_stats = gfar_fill_stats,
-        .get_rx_csum = gfar_get_rx_csum,
-        .get_tx_csum = gfar_get_tx_csum,
-        .set_rx_csum = gfar_set_rx_csum,
-        .set_tx_csum = gfar_set_tx_csum,
-        .set_sg = ethtool_op_set_sg,
        .get_msglevel = gfar_get_msglevel,
        .set_msglevel = gfar_set_msglevel,
 #ifdef CONFIG_PM
diff --git a/drivers/net/greth.c b/drivers/net/greth.c
index 396ff7d785d1..f181304a7ab6 100644
--- a/drivers/net/greth.c
+++ b/drivers/net/greth.c
@@ -901,7 +901,7 @@ static int greth_rx_gbit(struct net_device *dev, int limit)
                                skb_put(skb, pkt_len);
-                                if (greth->flags & GRETH_FLAG_RX_CSUM && hw_checksummed(status))
+                                if (dev->features & NETIF_F_RXCSUM && hw_checksummed(status))
                                        skb->ip_summed = CHECKSUM_UNNECESSARY;
                                else
                                        skb_checksum_none_assert(skb);
@@ -1142,41 +1142,6 @@ static void greth_get_regs(struct net_device *dev, struct ethtool_regs *regs, vo
                buff[i] = greth_read_bd(&greth_regs[i]);
 }
-static u32 greth_get_rx_csum(struct net_device *dev)
-{
-        struct greth_private *greth = netdev_priv(dev);
-        return (greth->flags & GRETH_FLAG_RX_CSUM) != 0;
-}
-static int greth_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct greth_private *greth = netdev_priv(dev);
-        spin_lock_bh(&greth->devlock);
-        if (data)
-                greth->flags |= GRETH_FLAG_RX_CSUM;
-        else
-                greth->flags &= ~GRETH_FLAG_RX_CSUM;
-        spin_unlock_bh(&greth->devlock);
-        return 0;
-}
-static u32 greth_get_tx_csum(struct net_device *dev)
-{
-        return (dev->features & NETIF_F_IP_CSUM) != 0;
-}
-static int greth_set_tx_csum(struct net_device *dev, u32 data)
-{
-        netif_tx_lock_bh(dev);
-        ethtool_op_set_tx_csum(dev, data);
-        netif_tx_unlock_bh(dev);
-        return 0;
-}
 static const struct ethtool_ops greth_ethtool_ops = {
        .get_msglevel           = greth_get_msglevel,
        .set_msglevel           = greth_set_msglevel,
@@ -1185,10 +1150,6 @@ static const struct ethtool_ops greth_ethtool_ops = {
        .get_drvinfo            = greth_get_drvinfo,
        .get_regs_len           = greth_get_regs_len,
        .get_regs               = greth_get_regs,
-        .get_rx_csum            = greth_get_rx_csum,
-        .set_rx_csum            = greth_set_rx_csum,
-        .get_tx_csum            = greth_get_tx_csum,
-        .set_tx_csum            = greth_set_tx_csum,
        .get_link               = ethtool_op_get_link,
 };
@@ -1570,9 +1531,10 @@ static int __devinit greth_of_probe(struct platform_device *ofdev)
        GRETH_REGSAVE(regs->status, 0xFF);
        if (greth->gbit_mac) {
-                dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_HIGHDMA;
+                dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM |
+                        NETIF_F_RXCSUM;
+                dev->features = dev->hw_features | NETIF_F_HIGHDMA;
                greth_netdev_ops.ndo_start_xmit = greth_start_xmit_gbit;
-                greth->flags = GRETH_FLAG_RX_CSUM;
        }
        if (greth->multicast) {
diff --git a/drivers/net/greth.h b/drivers/net/greth.h
index be0f2062bd14..9a0040dee4da 100644
--- a/drivers/net/greth.h
+++ b/drivers/net/greth.h
@@ -77,9 +77,6 @@
 */
 #define MAX_FRAME_SIZE          1520
-/* Flags */
-#define GRETH_FLAG_RX_CSUM 0x1
 /* GRETH APB registers */
 struct greth_regs {
        u32 control;
@@ -133,7 +130,6 @@ struct greth_private {
        unsigned int duplex;
        u32 msg_enable;
-        u32 flags;
        u8 phyaddr;
        u8 multicast;
diff --git a/drivers/net/hamachi.c b/drivers/net/hamachi.c
index 80d25ed53344..a09041aa8509 100644
--- a/drivers/net/hamachi.c
+++ b/drivers/net/hamachi.c
@@ -132,13 +132,8 @@ static int tx_params[MAX_UNITS] = {-1, -1, -1, -1, -1, -1, -1, -1};
 /*
 * RX_CHECKSUM turns on card-generated receive checksum generation for
 *   TCP and UDP packets.  Otherwise the upper layers do the calculation.
- * TX_CHECKSUM won't do anything too useful, even if it works.  There's no
- *   easy mechanism by which to tell the TCP/UDP stack that it need not
- *   generate checksums for this device.  But if somebody can find a way
- *   to get that to work, most of the card work is in here already.
 * 3/10/1999 Pete Wyckoff <wyckoff@ca.sandia.gov>
 */
-#undef  TX_CHECKSUM
 #define RX_CHECKSUM
 /* Operational parameters that usually are not changed. */
@@ -630,11 +625,6 @@ static int __devinit hamachi_init_one (struct pci_dev *pdev,
        SET_NETDEV_DEV(dev, &pdev->dev);
-#ifdef TX_CHECKSUM
-        printk("check that skbcopy in ip_queue_xmit isn't happening\n");
-        dev->hard_header_len += 8;  /* for cksum tag */
-#endif
        for (i = 0; i < 6; i++)
                dev->dev_addr[i] = 1 ? read_eeprom(ioaddr, 4 + i)
                        : readb(ioaddr + StationAddr + i);
@@ -937,11 +927,7 @@ static int hamachi_open(struct net_device *dev)
        /* always 1, takes no more time to do it */
        writew(0x0001, ioaddr + RxChecksum);
-#ifdef TX_CHECKSUM
-        writew(0x0001, ioaddr + TxChecksum);
-#else
        writew(0x0000, ioaddr + TxChecksum);
-#endif
        writew(0x8000, ioaddr + MACCnfg); /* Soft reset the MAC */
        writew(0x215F, ioaddr + MACCnfg);
        writew(0x000C, ioaddr + FrameGap0);
@@ -1226,40 +1212,6 @@ static void hamachi_init_ring(struct net_device *dev)
 }
-#ifdef TX_CHECKSUM
-#define csum_add(it, val) \
-do { \
-    it += (u16) (val); \
-    if (it & 0xffff0000) { \
-        it &= 0xffff; \
-        ++it; \
-    } \
-} while (0)
-    /* printk("add %04x --> %04x\n", val, it); \ */
-/* uh->len already network format, do not swap */
-#define pseudo_csum_udp(sum,ih,uh) do { \
-    sum = 0; \
-    csum_add(sum, (ih)->saddr >> 16); \
-    csum_add(sum, (ih)->saddr & 0xffff); \
-    csum_add(sum, (ih)->daddr >> 16); \
-    csum_add(sum, (ih)->daddr & 0xffff); \
-    csum_add(sum, cpu_to_be16(IPPROTO_UDP)); \
-    csum_add(sum, (uh)->len); \
-} while (0)
-/* swap len */
-#define pseudo_csum_tcp(sum,ih,len) do { \
-    sum = 0; \
-    csum_add(sum, (ih)->saddr >> 16); \
-    csum_add(sum, (ih)->saddr & 0xffff); \
-    csum_add(sum, (ih)->daddr >> 16); \
-    csum_add(sum, (ih)->daddr & 0xffff); \
-    csum_add(sum, cpu_to_be16(IPPROTO_TCP)); \
-    csum_add(sum, htons(len)); \
-} while (0)
-#endif
 static netdev_tx_t hamachi_start_xmit(struct sk_buff *skb,
                                      struct net_device *dev)
 {
@@ -1292,36 +1244,6 @@ static netdev_tx_t hamachi_start_xmit(struct sk_buff *skb,
        hmp->tx_skbuff[entry] = skb;
-#ifdef TX_CHECKSUM
-        {
-            /* tack on checksum tag */
-            u32 tagval = 0;
-            struct ethhdr *eh = (struct ethhdr *)skb->data;
-            if (eh->h_proto == cpu_to_be16(ETH_P_IP)) {
-                struct iphdr *ih = (struct iphdr *)((char *)eh + ETH_HLEN);
-                if (ih->protocol == IPPROTO_UDP) {
-                    struct udphdr *uh
-                      = (struct udphdr *)((char *)ih + ih->ihl*4);
-                    u32 offset = ((unsigned char *)uh + 6) - skb->data;
-                    u32 pseudo;
-                    pseudo_csum_udp(pseudo, ih, uh);
-                    pseudo = htons(pseudo);
-                    printk("udp cksum was %04x, sending pseudo %04x\n",
-                      uh->check, pseudo);
-                    uh->check = 0;  /* zero out uh->check before card calc */
-                    /*
-                     * start at 14 (skip ethhdr), store at offset (uh->check),
-                     * use pseudo value given.
-                     */
-                    tagval = (14 << 24) | (offset << 16) | pseudo;
-                } else if (ih->protocol == IPPROTO_TCP) {
-                    printk("tcp, no auto cksum\n");
-                }
-            }
-            *(u32 *)skb_push(skb, 8) = tagval;
-        }
-#endif
        hmp->tx_ring[entry].addr = cpu_to_leXX(pci_map_single(hmp->pci_dev,
                skb->data, skb->len, PCI_DMA_TODEVICE));
diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
index 8931168d3e74..18d8affecd1b 100644
--- a/drivers/net/hamradio/bpqether.c
+++ b/drivers/net/hamradio/bpqether.c
@@ -516,10 +516,6 @@ static int bpq_new_device(struct net_device *edev)
        memcpy(bpq->dest_addr, bcast_addr, sizeof(bpq_eth_addr));
        memcpy(bpq->acpt_addr, bcast_addr, sizeof(bpq_eth_addr));
-        err = dev_alloc_name(ndev, ndev->name);
-        if (err < 0) 
-                goto error;
        err = register_netdevice(ndev);
        if (err)
                goto error;
diff --git a/drivers/net/hp100.c b/drivers/net/hp100.c
index 8e10d2f6a5ad..c52a1df5d922 100644
--- a/drivers/net/hp100.c
+++ b/drivers/net/hp100.c
@@ -188,14 +188,14 @@ struct hp100_private {
 *  variables
 */
 #ifdef CONFIG_ISA
-static const char *hp100_isa_tbl[] = {
+static const char *const hp100_isa_tbl[] __devinitconst = {
        "HWPF150", /* HP J2573 rev A */
        "HWP1950", /* HP J2573 */
 };
 #endif
 #ifdef CONFIG_EISA
-static struct eisa_device_id hp100_eisa_tbl[] = {
+static const struct eisa_device_id hp100_eisa_tbl[] __devinitconst = {
        { "HWPF180" }, /* HP J2577 rev A */
        { "HWP1920" }, /* HP 27248B */
        { "HWP1940" }, /* HP J2577 */
@@ -336,7 +336,7 @@ static __devinit const char *hp100_read_id(int ioaddr)
 }
 #ifdef CONFIG_ISA
-static __init int hp100_isa_probe1(struct net_device *dev, int ioaddr)
+static __devinit int hp100_isa_probe1(struct net_device *dev, int ioaddr)
 {
        const char *sig;
        int i;
@@ -372,7 +372,7 @@ static __init int hp100_isa_probe1(struct net_device *dev, int ioaddr)
 * EISA and PCI are handled by device infrastructure.
 */
-static int  __init hp100_isa_probe(struct net_device *dev, int addr)
+static int  __devinit hp100_isa_probe(struct net_device *dev, int addr)
 {
        int err = -ENODEV;
@@ -396,7 +396,7 @@ static int  __init hp100_isa_probe(struct net_device *dev, int addr)
 #endif /* CONFIG_ISA */
 #if !defined(MODULE) && defined(CONFIG_ISA)
-struct net_device * __init hp100_probe(int unit)
+struct net_device * __devinit hp100_probe(int unit)
 {
        struct net_device *dev = alloc_etherdev(sizeof(struct hp100_private));
        int err;
@@ -2843,7 +2843,7 @@ static void cleanup_dev(struct net_device *d)
 }
 #ifdef CONFIG_EISA
-static int __init hp100_eisa_probe (struct device *gendev)
+static int __devinit hp100_eisa_probe (struct device *gendev)
 {
        struct net_device *dev = alloc_etherdev(sizeof(struct hp100_private));
        struct eisa_device *edev = to_eisa_device(gendev);
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 3bb990b6651a..079450fe5e96 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -2053,13 +2053,6 @@ static void emac_ethtool_get_pauseparam(struct net_device *ndev,
        mutex_unlock(&dev->link_lock);
 }
-static u32 emac_ethtool_get_rx_csum(struct net_device *ndev)
-{
-        struct emac_instance *dev = netdev_priv(ndev);
-        return dev->tah_dev != NULL;
-}
 static int emac_get_regs_len(struct emac_instance *dev)
 {
        if (emac_has_feature(dev, EMAC_FTR_EMAC4))
@@ -2203,15 +2196,11 @@ static const struct ethtool_ops emac_ethtool_ops = {
        .get_ringparam = emac_ethtool_get_ringparam,
        .get_pauseparam = emac_ethtool_get_pauseparam,
-        .get_rx_csum = emac_ethtool_get_rx_csum,
        .get_strings = emac_ethtool_get_strings,
        .get_sset_count = emac_ethtool_get_sset_count,
        .get_ethtool_stats = emac_ethtool_get_ethtool_stats,
        .get_link = ethtool_op_get_link,
-        .get_tx_csum = ethtool_op_get_tx_csum,
-        .get_sg = ethtool_op_get_sg,
 };
 static int emac_ioctl(struct net_device *ndev, struct ifreq *rq, int cmd)
@@ -2859,8 +2848,10 @@ static int __devinit emac_probe(struct platform_device *ofdev)
        if (err != 0)
                goto err_detach_tah;
-        if (dev->tah_dev)
+        if (dev->tah_dev) {
-                ndev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
+                ndev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG;
+                ndev->features |= ndev->hw_features | NETIF_F_RXCSUM;
+        }
        ndev->watchdog_timeo = 5 * HZ;
        if (emac_phy_supports_gige(dev->phy_mode)) {
                ndev->netdev_ops = &emac_gige_netdev_ops;
diff --git a/drivers/net/ibmlana.c b/drivers/net/ibmlana.c
index 8ff68ae6b520..136d7544cc33 100644
--- a/drivers/net/ibmlana.c
+++ b/drivers/net/ibmlana.c
@@ -782,7 +782,8 @@ static int ibmlana_open(struct net_device *dev)
        /* register resources - only necessary for IRQ */
-        result = request_irq(priv->realirq, irq_handler, IRQF_SHARED | IRQF_SAMPLE_RANDOM, dev->name, dev);
+        result = request_irq(priv->realirq, irq_handler, IRQF_SHARED,
+                             dev->name, dev);
        if (result != 0) {
                printk(KERN_ERR "%s: failed to register irq %d\n", dev->name, dev->irq);
                return result;
@@ -894,12 +895,12 @@ static int ibmlana_irq;
 static int ibmlana_io;
 static int startslot;           /* counts through slots when probing multiple devices */
-static short ibmlana_adapter_ids[] __initdata = {
+static const short ibmlana_adapter_ids[] __devinitconst = {
        IBM_LANA_ID,
        0x0000
 };
-static char *ibmlana_adapter_names[] __devinitdata = {
+static const char *const ibmlana_adapter_names[] __devinitconst = {
        "IBM LAN Adapter/A",
        NULL
 };
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index 5522d459654c..b388d782c7c4 100644
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -710,7 +710,7 @@ static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                                SUPPORTED_FIBRE);
        cmd->advertising = (ADVERTISED_1000baseT_Full | ADVERTISED_Autoneg |
                                ADVERTISED_FIBRE);
-        cmd->speed = SPEED_1000;
+        ethtool_cmd_speed_set(cmd, SPEED_1000);
        cmd->duplex = DUPLEX_FULL;
        cmd->port = PORT_FIBRE;
        cmd->phy_address = 0;
@@ -729,45 +729,24 @@ static void netdev_get_drvinfo(struct net_device *dev,
                sizeof(info->version) - 1);
 }
-static void ibmveth_set_rx_csum_flags(struct net_device *dev, u32 data)
+static u32 ibmveth_fix_features(struct net_device *dev, u32 features)
 {
-        struct ibmveth_adapter *adapter = netdev_priv(dev);
+        /*
+         * Since the ibmveth firmware interface does not have the
-        if (data) {
+         * concept of separate tx/rx checksum offload enable, if rx
-                adapter->rx_csum = 1;
+         * checksum is disabled we also have to disable tx checksum
-        } else {
+         * offload. Once we disable rx checksum offload, we are no
-                /*
+         * longer allowed to send tx buffers that are not properly
-                 * Since the ibmveth firmware interface does not have the
+         * checksummed.
-                 * concept of separate tx/rx checksum offload enable, if rx
+         */
-                 * checksum is disabled we also have to disable tx checksum
-                 * offload. Once we disable rx checksum offload, we are no
-                 * longer allowed to send tx buffers that are not properly
-                 * checksummed.
-                 */
-                adapter->rx_csum = 0;
-                dev->features &= ~NETIF_F_IP_CSUM;
-                dev->features &= ~NETIF_F_IPV6_CSUM;
-        }
-}
-static void ibmveth_set_tx_csum_flags(struct net_device *dev, u32 data)
+        if (!(features & NETIF_F_RXCSUM))
-{
+                features &= ~NETIF_F_ALL_CSUM;
-        struct ibmveth_adapter *adapter = netdev_priv(dev);
-        if (data) {
+        return features;
-                if (adapter->fw_ipv4_csum_support)
-                        dev->features |= NETIF_F_IP_CSUM;
-                if (adapter->fw_ipv6_csum_support)
-                        dev->features |= NETIF_F_IPV6_CSUM;
-                adapter->rx_csum = 1;
-        } else {
-                dev->features &= ~NETIF_F_IP_CSUM;
-                dev->features &= ~NETIF_F_IPV6_CSUM;
-        }
 }
-static int ibmveth_set_csum_offload(struct net_device *dev, u32 data,
+static int ibmveth_set_csum_offload(struct net_device *dev, u32 data)
-                                    void (*done) (struct net_device *, u32))
 {
        struct ibmveth_adapter *adapter = netdev_priv(dev);
        unsigned long set_attr, clr_attr, ret_attr;
@@ -827,8 +806,8 @@ static int ibmveth_set_csum_offload(struct net_device *dev, u32 data,
                } else
                        adapter->fw_ipv6_csum_support = data;
-                if (ret == H_SUCCESS || ret6 == H_SUCCESS)
+                if (ret != H_SUCCESS || ret6 != H_SUCCESS)
-                        done(dev, data);
+                        adapter->rx_csum = data;
                else
                        rc1 = -EIO;
        } else {
@@ -844,41 +823,22 @@ static int ibmveth_set_csum_offload(struct net_device *dev, u32 data,
        return rc1 ? rc1 : rc2;
 }
-static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
+static int ibmveth_set_features(struct net_device *dev, u32 features)
 {
        struct ibmveth_adapter *adapter = netdev_priv(dev);
+        int rx_csum = !!(features & NETIF_F_RXCSUM);
+        int rc;
-        if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum))
+        if (rx_csum == adapter->rx_csum)
-                return 0;
-        return ibmveth_set_csum_offload(dev, data, ibmveth_set_rx_csum_flags);
-}
-static int ibmveth_set_tx_csum(struct net_device *dev, u32 data)
-{
-        struct ibmveth_adapter *adapter = netdev_priv(dev);
-        int rc = 0;
-        if (data && (dev->features & (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM)))
-                return 0;
-        if (!data && !(dev->features & (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM)))
                return 0;
-        if (data && !adapter->rx_csum)
+        rc = ibmveth_set_csum_offload(dev, rx_csum);
-                rc = ibmveth_set_csum_offload(dev, data,
+        if (rc && !adapter->rx_csum)
-                                              ibmveth_set_tx_csum_flags);
+                dev->features = features & ~(NETIF_F_ALL_CSUM | NETIF_F_RXCSUM);
-        else
-                ibmveth_set_tx_csum_flags(dev, data);
        return rc;
 }
-static u32 ibmveth_get_rx_csum(struct net_device *dev)
-{
-        struct ibmveth_adapter *adapter = netdev_priv(dev);
-        return adapter->rx_csum;
-}
 static void ibmveth_get_strings(struct net_device *dev, u32 stringset, u8 *data)
 {
        int i;
@@ -914,13 +874,9 @@ static const struct ethtool_ops netdev_ethtool_ops = {
        .get_drvinfo            = netdev_get_drvinfo,
        .get_settings           = netdev_get_settings,
        .get_link               = ethtool_op_get_link,
-        .set_tx_csum            = ibmveth_set_tx_csum,
-        .get_rx_csum            = ibmveth_get_rx_csum,
-        .set_rx_csum            = ibmveth_set_rx_csum,
        .get_strings            = ibmveth_get_strings,
        .get_sset_count         = ibmveth_get_sset_count,
        .get_ethtool_stats      = ibmveth_get_ethtool_stats,
-        .set_sg                 = ethtool_op_set_sg,
 };
 static int ibmveth_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
@@ -1345,6 +1301,8 @@ static const struct net_device_ops ibmveth_netdev_ops = {
        .ndo_set_multicast_list = ibmveth_set_multicast_list,
        .ndo_do_ioctl           = ibmveth_ioctl,
        .ndo_change_mtu         = ibmveth_change_mtu,
+        .ndo_fix_features       = ibmveth_fix_features,
+        .ndo_set_features       = ibmveth_set_features,
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_set_mac_address    = eth_mac_addr,
 #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -1412,7 +1370,9 @@ static int __devinit ibmveth_probe(struct vio_dev *dev,
        netdev->netdev_ops = &ibmveth_netdev_ops;
        netdev->ethtool_ops = &netdev_ethtool_ops;
        SET_NETDEV_DEV(netdev, &dev->dev);
-        netdev->features |= NETIF_F_SG;
+        netdev->hw_features = NETIF_F_SG | NETIF_F_RXCSUM |
+                NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
+        netdev->features |= netdev->hw_features;
        memcpy(netdev->dev_addr, &adapter->mac_addr, netdev->addr_len);
@@ -1437,7 +1397,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev,
        netdev_dbg(netdev, "registering netdev...\n");
-        ibmveth_set_csum_offload(netdev, 1, ibmveth_set_tx_csum_flags);
+        ibmveth_set_features(netdev, netdev->features);
        rc = register_netdev(netdev);
diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index e07d487f015a..4fecaed67fc4 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -233,10 +233,6 @@ static int __init ifb_init_one(int index)
        if (!dev_ifb)
                return -ENOMEM;
-        err = dev_alloc_name(dev_ifb, dev_ifb->name);
-        if (err < 0)
-                goto err;
        dev_ifb->rtnl_link_ops = &ifb_link_ops;
        err = register_netdevice(dev_ifb);
        if (err < 0)
diff --git a/drivers/net/igb/e1000_82575.c b/drivers/net/igb/e1000_82575.c
index 6b256c275e10..0f563c8c5ffc 100644
--- a/drivers/net/igb/e1000_82575.c
+++ b/drivers/net/igb/e1000_82575.c
@@ -244,6 +244,14 @@ static s32 igb_get_invariants_82575(struct e1000_hw *hw)
         */
        size += NVM_WORD_SIZE_BASE_SHIFT;
+        /*
+         * Check for invalid size
+         */
+        if ((hw->mac.type == e1000_82576) && (size > 15)) {
+                printk("igb: The NVM size is not valid, "
+                        "defaulting to 32K.\n");
+                size = 15;
+        }
        nvm->word_size = 1 << size;
        if (nvm->word_size == (1 << 15))
                nvm->page_size = 128;
@@ -1877,7 +1885,7 @@ static s32 igb_validate_nvm_checksum_82580(struct e1000_hw *hw)
        }
        if (nvm_data & NVM_COMPATIBILITY_BIT_MASK) {
-                /* if chekcsums compatibility bit is set validate checksums
+                /* if checksums compatibility bit is set validate checksums
                 * for all 4 ports. */
                eeprom_regions_count = 4;
        }
@@ -1988,6 +1996,7 @@ static s32 igb_update_nvm_checksum_i350(struct e1000_hw *hw)
 out:
        return ret_val;
 }
 /**
 *  igb_set_eee_i350 - Enable/disable EEE support
 *  @hw: pointer to the HW structure
diff --git a/drivers/net/igb/igb.h b/drivers/net/igb/igb.h
index 1c687e298d5e..f4fa4b1751cf 100644
--- a/drivers/net/igb/igb.h
+++ b/drivers/net/igb/igb.h
@@ -360,7 +360,7 @@ extern int igb_up(struct igb_adapter *);
 extern void igb_down(struct igb_adapter *);
 extern void igb_reinit_locked(struct igb_adapter *);
 extern void igb_reset(struct igb_adapter *);
-extern int igb_set_spd_dplx(struct igb_adapter *, u16);
+extern int igb_set_spd_dplx(struct igb_adapter *, u32, u8);
 extern int igb_setup_tx_resources(struct igb_ring *);
 extern int igb_setup_rx_resources(struct igb_ring *);
 extern void igb_free_tx_resources(struct igb_ring *);
diff --git a/drivers/net/igb/igb_ethtool.c b/drivers/net/igb/igb_ethtool.c
index d976733bbcc2..fdc895e5a3f8 100644
--- a/drivers/net/igb/igb_ethtool.c
+++ b/drivers/net/igb/igb_ethtool.c
@@ -178,11 +178,11 @@ static int igb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
                if ((status & E1000_STATUS_SPEED_1000) ||
                    hw->phy.media_type != e1000_media_type_copper)
-                        ecmd->speed = SPEED_1000;
+                        ethtool_cmd_speed_set(ecmd, SPEED_1000);
                else if (status & E1000_STATUS_SPEED_100)
-                        ecmd->speed = SPEED_100;
+                        ethtool_cmd_speed_set(ecmd, SPEED_100);
                else
-                        ecmd->speed = SPEED_10;
+                        ethtool_cmd_speed_set(ecmd, SPEED_10);
                if ((status & E1000_STATUS_FD) ||
                    hw->phy.media_type != e1000_media_type_copper)
@@ -190,7 +190,7 @@ static int igb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
                else
                        ecmd->duplex = DUPLEX_HALF;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
@@ -223,7 +223,8 @@ static int igb_set_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
                if (adapter->fc_autoneg)
                        hw->fc.requested_mode = e1000_fc_default;
        } else {
-                if (igb_set_spd_dplx(adapter, ecmd->speed + ecmd->duplex)) {
+                u32 speed = ethtool_cmd_speed(ecmd);
+                if (igb_set_spd_dplx(adapter, speed, ecmd->duplex)) {
                        clear_bit(__IGB_RESETTING, &adapter->state);
                        return -EINVAL;
                }
@@ -1963,27 +1964,28 @@ static int igb_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
 /* bit defines for adapter->led_status */
 #define IGB_LED_ON              0
-static int igb_phys_id(struct net_device *netdev, u32 data)
+static int igb_set_phys_id(struct net_device *netdev,
+                           enum ethtool_phys_id_state state)
 {
        struct igb_adapter *adapter = netdev_priv(netdev);
        struct e1000_hw *hw = &adapter->hw;
-        unsigned long timeout;
-        timeout = data * 1000;
+        switch (state) {
+        case ETHTOOL_ID_ACTIVE:
-        /*
+                igb_blink_led(hw);
-         *  msleep_interruptable only accepts unsigned int so we are limited
+                return 2;
-         * in how long a duration we can wait
+        case ETHTOOL_ID_ON:
-         */
+                igb_blink_led(hw);
-        if (!timeout || timeout > UINT_MAX)
+                break;
-                timeout = UINT_MAX;
+        case ETHTOOL_ID_OFF:
+                igb_led_off(hw);
-        igb_blink_led(hw);
+                break;
-        msleep_interruptible(timeout);
+        case ETHTOOL_ID_INACTIVE:
+                igb_led_off(hw);
-        igb_led_off(hw);
+                clear_bit(IGB_LED_ON, &adapter->led_status);
-        clear_bit(IGB_LED_ON, &adapter->led_status);
+                igb_cleanup_led(hw);
-        igb_cleanup_led(hw);
+                break;
+        }
        return 0;
 }
@@ -2215,7 +2217,7 @@ static const struct ethtool_ops igb_ethtool_ops = {
        .set_tso                = igb_set_tso,
        .self_test              = igb_diag_test,
        .get_strings            = igb_get_strings,
-        .phys_id                = igb_phys_id,
+        .set_phys_id            = igb_set_phys_id,
        .get_sset_count         = igb_get_sset_count,
        .get_ethtool_stats      = igb_get_ethtool_stats,
        .get_coalesce           = igb_get_coalesce,
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index 0dfd1b93829e..ce7838e55827 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -3532,6 +3532,25 @@ bool igb_has_link(struct igb_adapter *adapter)
        return link_active;
 }
+static bool igb_thermal_sensor_event(struct e1000_hw *hw, u32 event)
+{
+        bool ret = false;
+        u32 ctrl_ext, thstat;
+        /* check for thermal sensor event on i350, copper only */
+        if (hw->mac.type == e1000_i350) {
+                thstat = rd32(E1000_THSTAT);
+                ctrl_ext = rd32(E1000_CTRL_EXT);
+                if ((hw->phy.media_type == e1000_media_type_copper) &&
+                    !(ctrl_ext & E1000_CTRL_EXT_LINK_MODE_SGMII)) {
+                        ret = !!(thstat & event);
+                }
+        }
+        return ret;
+}
 /**
 * igb_watchdog - Timer Call-back
 * @data: pointer to adapter cast into an unsigned long
@@ -3550,7 +3569,7 @@ static void igb_watchdog_task(struct work_struct *work)
                                                   watchdog_task);
        struct e1000_hw *hw = &adapter->hw;
        struct net_device *netdev = adapter->netdev;
-        u32 link, ctrl_ext, thstat;
+        u32 link;
        int i;
        link = igb_has_link(adapter);
@@ -3574,25 +3593,14 @@ static void igb_watchdog_task(struct work_struct *work)
                               ((ctrl & E1000_CTRL_RFCE) ?  "RX" :
                               ((ctrl & E1000_CTRL_TFCE) ?  "TX" : "None")));
-                        /* check for thermal sensor event on i350,
+                        /* check for thermal sensor event */
-                         * copper only */
+                        if (igb_thermal_sensor_event(hw, E1000_THSTAT_LINK_THROTTLE)) {
-                        if (hw->mac.type == e1000_i350) {
+                                printk(KERN_INFO "igb: %s The network adapter "
-                                thstat = rd32(E1000_THSTAT);
+                                                 "link speed was downshifted "
-                                ctrl_ext = rd32(E1000_CTRL_EXT);
+                                                 "because it overheated.\n",
-                                if ((hw->phy.media_type ==
+                                                 netdev->name);
-                                     e1000_media_type_copper) && !(ctrl_ext &
-                                     E1000_CTRL_EXT_LINK_MODE_SGMII)) {
-                                        if (thstat &
-                                            E1000_THSTAT_LINK_THROTTLE) {
-                                                printk(KERN_INFO "igb: %s The "
-                                                       "network adapter link "
-                                                       "speed was downshifted "
-                                                       "because it "
-                                                       "overheated.\n",
-                                                       netdev->name);
-                                        }
-                                }
                        }
                        /* adjust timeout factor according to speed/duplex */
                        adapter->tx_timeout_factor = 1;
                        switch (adapter->link_speed) {
@@ -3618,22 +3626,15 @@ static void igb_watchdog_task(struct work_struct *work)
                if (netif_carrier_ok(netdev)) {
                        adapter->link_speed = 0;
                        adapter->link_duplex = 0;
-                        /* check for thermal sensor event on i350
-                         * copper only*/
+                        /* check for thermal sensor event */
-                        if (hw->mac.type == e1000_i350) {
+                        if (igb_thermal_sensor_event(hw, E1000_THSTAT_PWR_DOWN)) {
-                                thstat = rd32(E1000_THSTAT);
+                                printk(KERN_ERR "igb: %s The network adapter "
-                                ctrl_ext = rd32(E1000_CTRL_EXT);
+                                                "was stopped because it "
-                                if ((hw->phy.media_type ==
+                                                "overheated.\n",
-                                     e1000_media_type_copper) && !(ctrl_ext &
-                                     E1000_CTRL_EXT_LINK_MODE_SGMII)) {
-                                        if (thstat & E1000_THSTAT_PWR_DOWN) {
-                                                printk(KERN_ERR "igb: %s The "
-                                                "network adapter was stopped "
-                                                "because it overheated.\n",
                                                netdev->name);
-                                        }
-                                }
                        }
                        /* Links status message must follow this format */
                        printk(KERN_INFO "igb: %s NIC Link is Down\n",
                               netdev->name);
@@ -6348,21 +6349,25 @@ static void igb_restore_vlan(struct igb_adapter *adapter)
        }
 }
-int igb_set_spd_dplx(struct igb_adapter *adapter, u16 spddplx)
+int igb_set_spd_dplx(struct igb_adapter *adapter, u32 spd, u8 dplx)
 {
        struct pci_dev *pdev = adapter->pdev;
        struct e1000_mac_info *mac = &adapter->hw.mac;
        mac->autoneg = 0;
+        /* Make sure dplx is at most 1 bit and lsb of speed is not set
+         * for the switch() below to work */
+        if ((spd & 1) || (dplx & ~1))
+                goto err_inval;
        /* Fiber NIC's only allow 1000 Gbps Full duplex */
        if ((adapter->hw.phy.media_type == e1000_media_type_internal_serdes) &&
-                spddplx != (SPEED_1000 + DUPLEX_FULL)) {
+            spd != SPEED_1000 &&
-                dev_err(&pdev->dev, "Unsupported Speed/Duplex configuration\n");
+            dplx != DUPLEX_FULL)
-                return -EINVAL;
+                goto err_inval;
-        }
-        switch (spddplx) {
+        switch (spd + dplx) {
        case SPEED_10 + DUPLEX_HALF:
                mac->forced_speed_duplex = ADVERTISE_10_HALF;
                break;
@@ -6381,10 +6386,13 @@ int igb_set_spd_dplx(struct igb_adapter *adapter, u16 spddplx)
                break;
        case SPEED_1000 + DUPLEX_HALF: /* not supported */
        default:
-                dev_err(&pdev->dev, "Unsupported Speed/Duplex configuration\n");
+                goto err_inval;
-                return -EINVAL;
        }
        return 0;
+err_inval:
+        dev_err(&pdev->dev, "Unsupported Speed/Duplex configuration\n");
+        return -EINVAL;
 }
 static int __igb_shutdown(struct pci_dev *pdev, bool *enable_wake)
diff --git a/drivers/net/igbvf/ethtool.c b/drivers/net/igbvf/ethtool.c
index 1d943aa7c7a6..b0b14d63dfbf 100644
--- a/drivers/net/igbvf/ethtool.c
+++ b/drivers/net/igbvf/ethtool.c
@@ -90,18 +90,18 @@ static int igbvf_get_settings(struct net_device *netdev,
        status = er32(STATUS);
        if (status & E1000_STATUS_LU) {
                if (status & E1000_STATUS_SPEED_1000)
-                        ecmd->speed = 1000;
+                        ethtool_cmd_speed_set(ecmd, SPEED_1000);
                else if (status & E1000_STATUS_SPEED_100)
-                        ecmd->speed = 100;
+                        ethtool_cmd_speed_set(ecmd, SPEED_100);
                else
-                        ecmd->speed = 10;
+                        ethtool_cmd_speed_set(ecmd, SPEED_10);
                if (status & E1000_STATUS_FD)
                        ecmd->duplex = DUPLEX_FULL;
                else
                        ecmd->duplex = DUPLEX_HALF;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
@@ -391,11 +391,6 @@ static int igbvf_set_wol(struct net_device *netdev,
        return -EOPNOTSUPP;
 }
-static int igbvf_phys_id(struct net_device *netdev, u32 data)
-{
-        return 0;
-}
 static int igbvf_get_coalesce(struct net_device *netdev,
                              struct ethtool_coalesce *ec)
 {
@@ -527,7 +522,6 @@ static const struct ethtool_ops igbvf_ethtool_ops = {
        .self_test              = igbvf_diag_test,
        .get_sset_count         = igbvf_get_sset_count,
        .get_strings            = igbvf_get_strings,
-        .phys_id                = igbvf_phys_id,
        .get_ethtool_stats      = igbvf_get_ethtool_stats,
        .get_coalesce           = igbvf_get_coalesce,
        .set_coalesce           = igbvf_set_coalesce,
diff --git a/drivers/net/ioc3-eth.c b/drivers/net/ioc3-eth.c
index c8ee8d28767b..96c95617195f 100644
--- a/drivers/net/ioc3-eth.c
+++ b/drivers/net/ioc3-eth.c
@@ -90,8 +90,6 @@ struct ioc3_private {
        u32 emcr, ehar_h, ehar_l;
        spinlock_t ioc3_lock;
        struct mii_if_info mii;
-        unsigned long flags;
-#define IOC3_FLAG_RX_CHECKSUMS  1
        struct pci_dev *pdev;
@@ -609,7 +607,7 @@ static inline void ioc3_rx(struct net_device *dev)
                                goto next;
                        }
-                        if (likely(ip->flags & IOC3_FLAG_RX_CHECKSUMS))
+                        if (likely(dev->features & NETIF_F_RXCSUM))
                                ioc3_tcpudp_checksum(skb,
                                        w0 & ERXBUF_IPCKSUM_MASK, len);
@@ -1328,6 +1326,7 @@ static int __devinit ioc3_probe(struct pci_dev *pdev,
        dev->watchdog_timeo     = 5 * HZ;
        dev->netdev_ops         = &ioc3_netdev_ops;
        dev->ethtool_ops        = &ioc3_ethtool_ops;
+        dev->hw_features        = NETIF_F_IP_CSUM | NETIF_F_RXCSUM;
        dev->features           = NETIF_F_IP_CSUM;
        sw_physid1 = ioc3_mdio_read(dev, ip->mii.phy_id, MII_PHYSID1);
@@ -1618,37 +1617,12 @@ static u32 ioc3_get_link(struct net_device *dev)
        return rc;
 }
-static u32 ioc3_get_rx_csum(struct net_device *dev)
-{
-        struct ioc3_private *ip = netdev_priv(dev);
-        return ip->flags & IOC3_FLAG_RX_CHECKSUMS;
-}
-static int ioc3_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct ioc3_private *ip = netdev_priv(dev);
-        spin_lock_bh(&ip->ioc3_lock);
-        if (data)
-                ip->flags |= IOC3_FLAG_RX_CHECKSUMS;
-        else
-                ip->flags &= ~IOC3_FLAG_RX_CHECKSUMS;
-        spin_unlock_bh(&ip->ioc3_lock);
-        return 0;
-}
 static const struct ethtool_ops ioc3_ethtool_ops = {
        .get_drvinfo            = ioc3_get_drvinfo,
        .get_settings           = ioc3_get_settings,
        .set_settings           = ioc3_set_settings,
        .nway_reset             = ioc3_nway_reset,
        .get_link               = ioc3_get_link,
-        .get_rx_csum            = ioc3_get_rx_csum,
-        .set_rx_csum            = ioc3_set_rx_csum,
-        .get_tx_csum            = ethtool_op_get_tx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_csum
 };
 static int ioc3_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
diff --git a/drivers/net/irda/smsc-ircc2.c b/drivers/net/irda/smsc-ircc2.c
index 8800e1fe4129..69b5707db369 100644
--- a/drivers/net/irda/smsc-ircc2.c
+++ b/drivers/net/irda/smsc-ircc2.c
@@ -222,19 +222,19 @@ static void smsc_ircc_set_transceiver_for_speed(struct smsc_ircc_cb *self, u32 s
 static void smsc_ircc_sir_wait_hw_transmitter_finish(struct smsc_ircc_cb *self);
 /* Probing */
-static int __init smsc_ircc_look_for_chips(void);
+static int smsc_ircc_look_for_chips(void);
-static const struct smsc_chip * __init smsc_ircc_probe(unsigned short cfg_base, u8 reg, const struct smsc_chip *chip, char *type);
+static const struct smsc_chip * smsc_ircc_probe(unsigned short cfg_base, u8 reg, const struct smsc_chip *chip, char *type);
-static int __init smsc_superio_flat(const struct smsc_chip *chips, unsigned short cfg_base, char *type);
+static int smsc_superio_flat(const struct smsc_chip *chips, unsigned short cfg_base, char *type);
-static int __init smsc_superio_paged(const struct smsc_chip *chips, unsigned short cfg_base, char *type);
+static int smsc_superio_paged(const struct smsc_chip *chips, unsigned short cfg_base, char *type);
-static int __init smsc_superio_fdc(unsigned short cfg_base);
+static int smsc_superio_fdc(unsigned short cfg_base);
-static int __init smsc_superio_lpc(unsigned short cfg_base);
+static int smsc_superio_lpc(unsigned short cfg_base);
 #ifdef CONFIG_PCI
-static int __init preconfigure_smsc_chip(struct smsc_ircc_subsystem_configuration *conf);
+static int preconfigure_smsc_chip(struct smsc_ircc_subsystem_configuration *conf);
-static int __init preconfigure_through_82801(struct pci_dev *dev, struct smsc_ircc_subsystem_configuration *conf);
+static int preconfigure_through_82801(struct pci_dev *dev, struct smsc_ircc_subsystem_configuration *conf);
-static void __init preconfigure_ali_port(struct pci_dev *dev,
+static void preconfigure_ali_port(struct pci_dev *dev,
                                         unsigned short port);
-static int __init preconfigure_through_ali(struct pci_dev *dev, struct smsc_ircc_subsystem_configuration *conf);
+static int preconfigure_through_ali(struct pci_dev *dev, struct smsc_ircc_subsystem_configuration *conf);
-static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg,
+static int smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg,
                                                    unsigned short ircc_fir,
                                                    unsigned short ircc_sir,
                                                    unsigned char ircc_dma,
@@ -366,7 +366,7 @@ static inline void register_bank(int iobase, int bank)
 }
 /* PNP hotplug support */
-static const struct pnp_device_id smsc_ircc_pnp_table[] = {
+static const struct pnp_device_id smsc_ircc_pnp_table[] __devinitconst = {
        { .id = "SMCf010", .driver_data = 0 },
        /* and presumably others */
        { }
@@ -515,7 +515,7 @@ static const struct net_device_ops smsc_ircc_netdev_ops = {
 *    Try to open driver instance
 *
 */
-static int __init smsc_ircc_open(unsigned int fir_base, unsigned int sir_base, u8 dma, u8 irq)
+static int __devinit smsc_ircc_open(unsigned int fir_base, unsigned int sir_base, u8 dma, u8 irq)
 {
        struct smsc_ircc_cb *self;
        struct net_device *dev;
@@ -2273,7 +2273,7 @@ static int __init smsc_superio_paged(const struct smsc_chip *chips, unsigned sho
 }
-static int __init smsc_access(unsigned short cfg_base, unsigned char reg)
+static int __devinit smsc_access(unsigned short cfg_base, unsigned char reg)
 {
        IRDA_DEBUG(1, "%s\n", __func__);
@@ -2281,7 +2281,7 @@ static int __init smsc_access(unsigned short cfg_base, unsigned char reg)
        return inb(cfg_base) != reg ? -1 : 0;
 }
-static const struct smsc_chip * __init smsc_ircc_probe(unsigned short cfg_base, u8 reg, const struct smsc_chip *chip, char *type)
+static const struct smsc_chip * __devinit smsc_ircc_probe(unsigned short cfg_base, u8 reg, const struct smsc_chip *chip, char *type)
 {
        u8 devid, xdevid, rev;
@@ -2406,7 +2406,7 @@ static int __init smsc_superio_lpc(unsigned short cfg_base)
 #ifdef CONFIG_PCI
 #define PCIID_VENDOR_INTEL 0x8086
 #define PCIID_VENDOR_ALI 0x10b9
-static struct smsc_ircc_subsystem_configuration subsystem_configurations[] __initdata = {
+static const struct smsc_ircc_subsystem_configuration subsystem_configurations[] __devinitconst = {
        /*
         * Subsystems needing entries:
         * 0x10b9:0x1533 0x103c:0x0850 HP nx9010 family
@@ -2532,7 +2532,7 @@ static struct smsc_ircc_subsystem_configuration subsystem_configurations[] __ini
 * (FIR port, SIR port, FIR DMA, FIR IRQ)
 * through the chip configuration port.
 */
-static int __init preconfigure_smsc_chip(struct
+static int __devinit preconfigure_smsc_chip(struct
                                         smsc_ircc_subsystem_configuration
                                         *conf)
 {
@@ -2633,7 +2633,7 @@ static int __init preconfigure_smsc_chip(struct
 * or Intel 82801DB/DBL (ICH4/ICH4-L) LPC Interface Bridge.
 * They all work the same way!
 */
-static int __init preconfigure_through_82801(struct pci_dev *dev,
+static int __devinit preconfigure_through_82801(struct pci_dev *dev,
                                             struct
                                             smsc_ircc_subsystem_configuration
                                             *conf)
@@ -2786,7 +2786,7 @@ static int __init preconfigure_through_82801(struct pci_dev *dev,
 * This is based on reverse-engineering since ALi does not
 * provide any data sheet for the 1533 chip.
 */
-static void __init preconfigure_ali_port(struct pci_dev *dev,
+static void __devinit preconfigure_ali_port(struct pci_dev *dev,
                                         unsigned short port)
 {
        unsigned char reg;
@@ -2824,7 +2824,7 @@ static void __init preconfigure_ali_port(struct pci_dev *dev,
        IRDA_MESSAGE("Activated ALi 1533 ISA bridge port 0x%04x.\n", port);
 }
-static int __init preconfigure_through_ali(struct pci_dev *dev,
+static int __devinit preconfigure_through_ali(struct pci_dev *dev,
                                           struct
                                           smsc_ircc_subsystem_configuration
                                           *conf)
@@ -2837,7 +2837,7 @@ static int __init preconfigure_through_ali(struct pci_dev *dev,
        return preconfigure_smsc_chip(conf);
 }
-static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg,
+static int __devinit smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg,
                                                    unsigned short ircc_fir,
                                                    unsigned short ircc_sir,
                                                    unsigned char ircc_dma,
@@ -2849,7 +2849,7 @@ static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg,
        int ret = 0;
        for_each_pci_dev(dev) {
-                struct smsc_ircc_subsystem_configuration *conf;
+                const struct smsc_ircc_subsystem_configuration *conf;
                /*
                 * Cache the subsystem vendor/device:
diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
index 8f3df044e81e..49e8408f05fc 100644
--- a/drivers/net/ixgb/ixgb.h
+++ b/drivers/net/ixgb/ixgb.h
@@ -157,9 +157,6 @@ struct ixgb_adapter {
        u16 link_duplex;
        struct work_struct tx_timeout_task;
-        struct timer_list blink_timer;
-        unsigned long led_status;
        /* TX */
        struct ixgb_desc_ring tx_ring ____cacheline_aligned_in_smp;
        unsigned int restart_queue;
diff --git a/drivers/net/ixgb/ixgb_ethtool.c b/drivers/net/ixgb/ixgb_ethtool.c
index cc53aa1541ba..6da890b9534c 100644
--- a/drivers/net/ixgb/ixgb_ethtool.c
+++ b/drivers/net/ixgb/ixgb_ethtool.c
@@ -104,10 +104,10 @@ ixgb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
        ecmd->transceiver = XCVR_EXTERNAL;
        if (netif_carrier_ok(adapter->netdev)) {
-                ecmd->speed = SPEED_10000;
+                ethtool_cmd_speed_set(ecmd, SPEED_10000);
                ecmd->duplex = DUPLEX_FULL;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
@@ -129,9 +129,10 @@ static int
 ixgb_set_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
 {
        struct ixgb_adapter *adapter = netdev_priv(netdev);
+        u32 speed = ethtool_cmd_speed(ecmd);
        if (ecmd->autoneg == AUTONEG_ENABLE ||
-           ecmd->speed + ecmd->duplex != SPEED_10000 + DUPLEX_FULL)
+            (speed + ecmd->duplex != SPEED_10000 + DUPLEX_FULL))
                return -EINVAL;
        if (netif_running(adapter->netdev)) {
@@ -610,45 +611,23 @@ err_setup_rx:
        return err;
 }
-/* toggle LED 4 times per second = 2 "blinks" per second */
-#define IXGB_ID_INTERVAL        (HZ/4)
-/* bit defines for adapter->led_status */
-#define IXGB_LED_ON             0
-static void
-ixgb_led_blink_callback(unsigned long data)
-{
-        struct ixgb_adapter *adapter = (struct ixgb_adapter *)data;
-        if (test_and_change_bit(IXGB_LED_ON, &adapter->led_status))
-                ixgb_led_off(&adapter->hw);
-        else
-                ixgb_led_on(&adapter->hw);
-        mod_timer(&adapter->blink_timer, jiffies + IXGB_ID_INTERVAL);
-}
 static int
-ixgb_phys_id(struct net_device *netdev, u32 data)
+ixgb_set_phys_id(struct net_device *netdev, enum ethtool_phys_id_state state)
 {
        struct ixgb_adapter *adapter = netdev_priv(netdev);
-        if (!data)
+        switch (state) {
-                data = INT_MAX;
+        case ETHTOOL_ID_ACTIVE:
+                return 2;
-        if (!adapter->blink_timer.function) {
-                init_timer(&adapter->blink_timer);
-                adapter->blink_timer.function = ixgb_led_blink_callback;
-                adapter->blink_timer.data = (unsigned long)adapter;
-        }
-        mod_timer(&adapter->blink_timer, jiffies);
+        case ETHTOOL_ID_ON:
+                ixgb_led_on(&adapter->hw);
+                break;
-        msleep_interruptible(data * 1000);
+        case ETHTOOL_ID_OFF:
-        del_timer_sync(&adapter->blink_timer);
+        case ETHTOOL_ID_INACTIVE:
-        ixgb_led_off(&adapter->hw);
+                ixgb_led_off(&adapter->hw);
-        clear_bit(IXGB_LED_ON, &adapter->led_status);
+        }
        return 0;
 }
@@ -766,7 +745,7 @@ static const struct ethtool_ops ixgb_ethtool_ops = {
        .set_msglevel = ixgb_set_msglevel,
        .set_tso = ixgb_set_tso,
        .get_strings = ixgb_get_strings,
-        .phys_id = ixgb_phys_id,
+        .set_phys_id = ixgb_set_phys_id,
        .get_sset_count = ixgb_get_sset_count,
        .get_ethtool_stats = ixgb_get_ethtool_stats,
        .get_flags = ethtool_op_get_flags,
diff --git a/drivers/net/ixgbe/ixgbe.h b/drivers/net/ixgbe/ixgbe.h
index 8d468028bb55..e467b20ed1f0 100644
--- a/drivers/net/ixgbe/ixgbe.h
+++ b/drivers/net/ixgbe/ixgbe.h
@@ -106,6 +106,7 @@
 #define IXGBE_MAX_VF_FUNCTIONS          64
 #define IXGBE_MAX_VFTA_ENTRIES          128
 #define MAX_EMULATION_MAC_ADDRS         16
+#define IXGBE_MAX_PF_MACVLANS           15
 #define VMDQ_P(p)   ((p) + adapter->num_vfs)
 struct vf_data_storage {
@@ -121,6 +122,15 @@ struct vf_data_storage {
        u16 tx_rate;
 };
+struct vf_macvlans {
+        struct list_head l;
+        int vf;
+        int rar_entry;
+        bool free;
+        bool is_macvlan;
+        u8 vf_macvlan[ETH_ALEN];
+};
 /* wrapper around a pointer to a socket buffer,
 * so a DMA handle can be stored along with the buffer */
 struct ixgbe_tx_buffer {
@@ -331,10 +341,52 @@ struct ixgbe_q_vector {
 /* board specific private data structure */
 struct ixgbe_adapter {
-        struct timer_list watchdog_timer;
+        unsigned long state;
+        /* Some features need tri-state capability,
+         * thus the additional *_CAPABLE flags.
+         */
+        u32 flags;
+#define IXGBE_FLAG_RX_CSUM_ENABLED              (u32)(1)
+#define IXGBE_FLAG_MSI_CAPABLE                  (u32)(1 << 1)
+#define IXGBE_FLAG_MSI_ENABLED                  (u32)(1 << 2)
+#define IXGBE_FLAG_MSIX_CAPABLE                 (u32)(1 << 3)
+#define IXGBE_FLAG_MSIX_ENABLED                 (u32)(1 << 4)
+#define IXGBE_FLAG_RX_1BUF_CAPABLE              (u32)(1 << 6)
+#define IXGBE_FLAG_RX_PS_CAPABLE                (u32)(1 << 7)
+#define IXGBE_FLAG_RX_PS_ENABLED                (u32)(1 << 8)
+#define IXGBE_FLAG_IN_NETPOLL                   (u32)(1 << 9)
+#define IXGBE_FLAG_DCA_ENABLED                  (u32)(1 << 10)
+#define IXGBE_FLAG_DCA_CAPABLE                  (u32)(1 << 11)
+#define IXGBE_FLAG_IMIR_ENABLED                 (u32)(1 << 12)
+#define IXGBE_FLAG_MQ_CAPABLE                   (u32)(1 << 13)
+#define IXGBE_FLAG_DCB_ENABLED                  (u32)(1 << 14)
+#define IXGBE_FLAG_RSS_ENABLED                  (u32)(1 << 16)
+#define IXGBE_FLAG_RSS_CAPABLE                  (u32)(1 << 17)
+#define IXGBE_FLAG_VMDQ_CAPABLE                 (u32)(1 << 18)
+#define IXGBE_FLAG_VMDQ_ENABLED                 (u32)(1 << 19)
+#define IXGBE_FLAG_FAN_FAIL_CAPABLE             (u32)(1 << 20)
+#define IXGBE_FLAG_NEED_LINK_UPDATE             (u32)(1 << 22)
+#define IXGBE_FLAG_NEED_LINK_CONFIG             (u32)(1 << 23)
+#define IXGBE_FLAG_FDIR_HASH_CAPABLE            (u32)(1 << 24)
+#define IXGBE_FLAG_FDIR_PERFECT_CAPABLE         (u32)(1 << 25)
+#define IXGBE_FLAG_FCOE_CAPABLE                 (u32)(1 << 26)
+#define IXGBE_FLAG_FCOE_ENABLED                 (u32)(1 << 27)
+#define IXGBE_FLAG_SRIOV_CAPABLE                (u32)(1 << 28)
+#define IXGBE_FLAG_SRIOV_ENABLED                (u32)(1 << 29)
+        u32 flags2;
+#define IXGBE_FLAG2_RSC_CAPABLE                 (u32)(1)
+#define IXGBE_FLAG2_RSC_ENABLED                 (u32)(1 << 1)
+#define IXGBE_FLAG2_TEMP_SENSOR_CAPABLE         (u32)(1 << 2)
+#define IXGBE_FLAG2_TEMP_SENSOR_EVENT           (u32)(1 << 3)
+#define IXGBE_FLAG2_SEARCH_FOR_SFP              (u32)(1 << 4)
+#define IXGBE_FLAG2_SFP_NEEDS_RESET             (u32)(1 << 5)
+#define IXGBE_FLAG2_RESET_REQUESTED             (u32)(1 << 6)
+#define IXGBE_FLAG2_FDIR_REQUIRES_REINIT        (u32)(1 << 7)
        unsigned long active_vlans[BITS_TO_LONGS(VLAN_N_VID)];
        u16 bd_number;
-        struct work_struct reset_task;
        struct ixgbe_q_vector *q_vector[MAX_MSIX_Q_VECTORS];
        /* DCB parameters */
@@ -377,43 +429,6 @@ struct ixgbe_adapter {
        u32 alloc_rx_page_failed;
        u32 alloc_rx_buff_failed;
-        /* Some features need tri-state capability,
-         * thus the additional *_CAPABLE flags.
-         */
-        u32 flags;
-#define IXGBE_FLAG_RX_CSUM_ENABLED              (u32)(1)
-#define IXGBE_FLAG_MSI_CAPABLE                  (u32)(1 << 1)
-#define IXGBE_FLAG_MSI_ENABLED                  (u32)(1 << 2)
-#define IXGBE_FLAG_MSIX_CAPABLE                 (u32)(1 << 3)
-#define IXGBE_FLAG_MSIX_ENABLED                 (u32)(1 << 4)
-#define IXGBE_FLAG_RX_1BUF_CAPABLE              (u32)(1 << 6)
-#define IXGBE_FLAG_RX_PS_CAPABLE                (u32)(1 << 7)
-#define IXGBE_FLAG_RX_PS_ENABLED                (u32)(1 << 8)
-#define IXGBE_FLAG_IN_NETPOLL                   (u32)(1 << 9)
-#define IXGBE_FLAG_DCA_ENABLED                  (u32)(1 << 10)
-#define IXGBE_FLAG_DCA_CAPABLE                  (u32)(1 << 11)
-#define IXGBE_FLAG_IMIR_ENABLED                 (u32)(1 << 12)
-#define IXGBE_FLAG_MQ_CAPABLE                   (u32)(1 << 13)
-#define IXGBE_FLAG_DCB_ENABLED                  (u32)(1 << 14)
-#define IXGBE_FLAG_RSS_ENABLED                  (u32)(1 << 16)
-#define IXGBE_FLAG_RSS_CAPABLE                  (u32)(1 << 17)
-#define IXGBE_FLAG_VMDQ_CAPABLE                 (u32)(1 << 18)
-#define IXGBE_FLAG_VMDQ_ENABLED                 (u32)(1 << 19)
-#define IXGBE_FLAG_FAN_FAIL_CAPABLE             (u32)(1 << 20)
-#define IXGBE_FLAG_NEED_LINK_UPDATE             (u32)(1 << 22)
-#define IXGBE_FLAG_IN_SFP_LINK_TASK             (u32)(1 << 23)
-#define IXGBE_FLAG_IN_SFP_MOD_TASK              (u32)(1 << 24)
-#define IXGBE_FLAG_FDIR_HASH_CAPABLE            (u32)(1 << 25)
-#define IXGBE_FLAG_FDIR_PERFECT_CAPABLE         (u32)(1 << 26)
-#define IXGBE_FLAG_FCOE_CAPABLE                 (u32)(1 << 27)
-#define IXGBE_FLAG_FCOE_ENABLED                 (u32)(1 << 28)
-#define IXGBE_FLAG_SRIOV_CAPABLE                (u32)(1 << 29)
-#define IXGBE_FLAG_SRIOV_ENABLED                (u32)(1 << 30)
-        u32 flags2;
-#define IXGBE_FLAG2_RSC_CAPABLE                 (u32)(1)
-#define IXGBE_FLAG2_RSC_ENABLED                 (u32)(1 << 1)
-#define IXGBE_FLAG2_TEMP_SENSOR_CAPABLE         (u32)(1 << 2)
 /* default to trying for four seconds */
 #define IXGBE_TRY_LINK_TIMEOUT (4 * HZ)
@@ -434,7 +449,6 @@ struct ixgbe_adapter {
        u32 rx_eitr_param;
        u32 tx_eitr_param;
-        unsigned long state;
        u64 tx_busy;
        unsigned int tx_ring_count;
        unsigned int rx_ring_count;
@@ -443,15 +457,12 @@ struct ixgbe_adapter {
        bool link_up;
        unsigned long link_check_timeout;
-        struct work_struct watchdog_task;
+        struct work_struct service_task;
-        struct work_struct sfp_task;
+        struct timer_list service_timer;
-        struct timer_list sfp_timer;
-        struct work_struct multispeed_fiber_task;
-        struct work_struct sfp_config_module_task;
        u32 fdir_pballoc;
        u32 atr_sample_rate;
+        unsigned long fdir_overflow; /* number of times ATR was backed off */
        spinlock_t fdir_perfect_lock;
-        struct work_struct fdir_reinit_task;
 #ifdef IXGBE_FCOE
        struct ixgbe_fcoe fcoe;
 #endif /* IXGBE_FCOE */
@@ -461,7 +472,7 @@ struct ixgbe_adapter {
        u16 eeprom_version;
        int node;
-        struct work_struct check_overtemp_task;
+        u32 led_reg;
        u32 interrupt_event;
        char lsc_int_name[IFNAMSIZ + 9];
@@ -470,13 +481,17 @@ struct ixgbe_adapter {
        unsigned int num_vfs;
        struct vf_data_storage *vfinfo;
        int vf_rate_link_speed;
+        struct vf_macvlans vf_mvs;
+        struct vf_macvlans *mv_list;
+        bool antispoofing_enabled;
 };
 enum ixbge_state_t {
        __IXGBE_TESTING,
        __IXGBE_RESETTING,
        __IXGBE_DOWN,
-        __IXGBE_SFP_MODULE_NOT_FOUND
+        __IXGBE_SERVICE_SCHED,
+        __IXGBE_IN_SFP_INIT,
 };
 struct ixgbe_rsc_cb {
diff --git a/drivers/net/ixgbe/ixgbe_82598.c b/drivers/net/ixgbe/ixgbe_82598.c
index 845c679c8b87..8179e5060a18 100644
--- a/drivers/net/ixgbe/ixgbe_82598.c
+++ b/drivers/net/ixgbe/ixgbe_82598.c
@@ -37,6 +37,7 @@
 #define IXGBE_82598_RAR_ENTRIES   16
 #define IXGBE_82598_MC_TBL_SIZE  128
 #define IXGBE_82598_VFT_TBL_SIZE 128
+#define IXGBE_82598_RX_PB_SIZE   512
 static s32 ixgbe_setup_copper_link_82598(struct ixgbe_hw *hw,
                                         ixgbe_link_speed speed,
@@ -197,14 +198,35 @@ out:
 *  @hw: pointer to hardware structure
 *
 *  Starts the hardware using the generic start_hw function.
- *  Then set pcie completion timeout
+ *  Disables relaxed ordering Then set pcie completion timeout
+ *
 **/
 static s32 ixgbe_start_hw_82598(struct ixgbe_hw *hw)
 {
+        u32 regval;
+        u32 i;
        s32 ret_val = 0;
        ret_val = ixgbe_start_hw_generic(hw);
+        /* Disable relaxed ordering */
+        for (i = 0; ((i < hw->mac.max_tx_queues) &&
+             (i < IXGBE_DCA_MAX_QUEUES_82598)); i++) {
+                regval = IXGBE_READ_REG(hw, IXGBE_DCA_TXCTRL(i));
+                regval &= ~IXGBE_DCA_TXCTRL_TX_WB_RO_EN;
+                IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL(i), regval);
+        }
+        for (i = 0; ((i < hw->mac.max_rx_queues) &&
+             (i < IXGBE_DCA_MAX_QUEUES_82598)); i++) {
+                regval = IXGBE_READ_REG(hw, IXGBE_DCA_RXCTRL(i));
+                regval &= ~(IXGBE_DCA_RXCTRL_DESC_WRO_EN |
+                            IXGBE_DCA_RXCTRL_DESC_HSRO_EN);
+                IXGBE_WRITE_REG(hw, IXGBE_DCA_RXCTRL(i), regval);
+        }
+        hw->mac.rx_pb_size = IXGBE_82598_RX_PB_SIZE;
        /* set the completion timeout for interface */
        if (ret_val == 0)
                ixgbe_set_pcie_completion_timeout(hw);
@@ -1064,7 +1086,7 @@ static s32 ixgbe_read_i2c_eeprom_82598(struct ixgbe_hw *hw, u8 byte_offset,
                        sfp_stat = sfp_stat & IXGBE_I2C_EEPROM_STATUS_MASK;
                        if (sfp_stat != IXGBE_I2C_EEPROM_STATUS_IN_PROGRESS)
                                break;
-                        msleep(10);
+                        usleep_range(10000, 20000);
                }
                if (sfp_stat != IXGBE_I2C_EEPROM_STATUS_PASS) {
@@ -1188,6 +1210,38 @@ out:
        return physical_layer;
 }
+/**
+ *  ixgbe_set_lan_id_multi_port_pcie_82598 - Set LAN id for PCIe multiple
+ *  port devices.
+ *  @hw: pointer to the HW structure
+ *
+ *  Calls common function and corrects issue with some single port devices
+ *  that enable LAN1 but not LAN0.
+ **/
+static void ixgbe_set_lan_id_multi_port_pcie_82598(struct ixgbe_hw *hw)
+{
+        struct ixgbe_bus_info *bus = &hw->bus;
+        u16 pci_gen = 0;
+        u16 pci_ctrl2 = 0;
+        ixgbe_set_lan_id_multi_port_pcie(hw);
+        /* check if LAN0 is disabled */
+        hw->eeprom.ops.read(hw, IXGBE_PCIE_GENERAL_PTR, &pci_gen);
+        if ((pci_gen != 0) && (pci_gen != 0xFFFF)) {
+                hw->eeprom.ops.read(hw, pci_gen + IXGBE_PCIE_CTRL2, &pci_ctrl2);
+                /* if LAN0 is completely disabled force function to 0 */
+                if ((pci_ctrl2 & IXGBE_PCIE_CTRL2_LAN_DISABLE) &&
+                    !(pci_ctrl2 & IXGBE_PCIE_CTRL2_DISABLE_SELECT) &&
+                    !(pci_ctrl2 & IXGBE_PCIE_CTRL2_DUMMY_ENABLE)) {
+                        bus->func = 0;
+                }
+        }
+}
 static struct ixgbe_mac_operations mac_ops_82598 = {
        .init_hw                = &ixgbe_init_hw_generic,
        .reset_hw               = &ixgbe_reset_hw_82598,
@@ -1199,7 +1253,7 @@ static struct ixgbe_mac_operations mac_ops_82598 = {
        .get_mac_addr           = &ixgbe_get_mac_addr_generic,
        .stop_adapter           = &ixgbe_stop_adapter_generic,
        .get_bus_info           = &ixgbe_get_bus_info_generic,
-        .set_lan_id             = &ixgbe_set_lan_id_multi_port_pcie,
+        .set_lan_id             = &ixgbe_set_lan_id_multi_port_pcie_82598,
        .read_analog_reg8       = &ixgbe_read_analog_reg8_82598,
        .write_analog_reg8      = &ixgbe_write_analog_reg8_82598,
        .setup_link             = &ixgbe_setup_mac_link_82598,
@@ -1227,6 +1281,7 @@ static struct ixgbe_mac_operations mac_ops_82598 = {
 static struct ixgbe_eeprom_operations eeprom_ops_82598 = {
        .init_params            = &ixgbe_init_eeprom_params_generic,
        .read                   = &ixgbe_read_eerd_generic,
+        .read_buffer            = &ixgbe_read_eerd_buffer_generic,
        .calc_checksum          = &ixgbe_calc_eeprom_checksum_generic,
        .validate_checksum      = &ixgbe_validate_eeprom_checksum_generic,
        .update_checksum        = &ixgbe_update_eeprom_checksum_generic,
diff --git a/drivers/net/ixgbe/ixgbe_82599.c b/drivers/net/ixgbe/ixgbe_82599.c
index 00aeba385a2f..8ee661245af3 100644
--- a/drivers/net/ixgbe/ixgbe_82599.c
+++ b/drivers/net/ixgbe/ixgbe_82599.c
@@ -38,6 +38,7 @@
 #define IXGBE_82599_RAR_ENTRIES   128
 #define IXGBE_82599_MC_TBL_SIZE   128
 #define IXGBE_82599_VFT_TBL_SIZE  128
+#define IXGBE_82599_RX_PB_SIZE    512
 static void ixgbe_disable_tx_laser_multispeed_fiber(struct ixgbe_hw *hw);
 static void ixgbe_enable_tx_laser_multispeed_fiber(struct ixgbe_hw *hw);
@@ -61,6 +62,7 @@ static s32 ixgbe_setup_copper_link_82599(struct ixgbe_hw *hw,
                                         bool autoneg,
                                         bool autoneg_wait_to_complete);
 static s32 ixgbe_verify_fw_version_82599(struct ixgbe_hw *hw);
+static bool ixgbe_verify_lesm_fw_enabled_82599(struct ixgbe_hw *hw);
 static void ixgbe_init_mac_link_ops_82599(struct ixgbe_hw *hw)
 {
@@ -86,7 +88,8 @@ static void ixgbe_init_mac_link_ops_82599(struct ixgbe_hw *hw)
                if ((mac->ops.get_media_type(hw) ==
                     ixgbe_media_type_backplane) &&
                    (hw->phy.smart_speed == ixgbe_smart_speed_auto ||
-                     hw->phy.smart_speed == ixgbe_smart_speed_on))
+                     hw->phy.smart_speed == ixgbe_smart_speed_on) &&
+                     !ixgbe_verify_lesm_fw_enabled_82599(hw))
                        mac->ops.setup_link = &ixgbe_setup_mac_link_smartspeed;
                else
                        mac->ops.setup_link = &ixgbe_setup_mac_link_82599;
@@ -107,7 +110,6 @@ static s32 ixgbe_setup_sfp_modules_82599(struct ixgbe_hw *hw)
                ret_val = ixgbe_get_sfp_init_sequence_offsets(hw, &list_offset,
                                                              &data_offset);
                if (ret_val != 0)
                        goto setup_sfp_out;
@@ -127,9 +129,13 @@ static s32 ixgbe_setup_sfp_modules_82599(struct ixgbe_hw *hw)
                }
                /* Release the semaphore */
-                ixgbe_release_swfw_sync(hw, IXGBE_GSSR_MAC_CSR_SM);
+                hw->mac.ops.release_swfw_sync(hw, IXGBE_GSSR_MAC_CSR_SM);
-                /* Delay obtaining semaphore again to allow FW access */
+                /*
-                msleep(hw->eeprom.semaphore_delay);
+                 * Delay obtaining semaphore again to allow FW access,
+                 * semaphore_delay is in ms usleep_range needs us.
+                 */
+                usleep_range(hw->eeprom.semaphore_delay * 1000,
+                             hw->eeprom.semaphore_delay * 2000);
                /* Now restart DSP by setting Restart_AN and clearing LMS */
                IXGBE_WRITE_REG(hw, IXGBE_AUTOC, ((IXGBE_READ_REG(hw,
@@ -138,7 +144,7 @@ static s32 ixgbe_setup_sfp_modules_82599(struct ixgbe_hw *hw)
                /* Wait for AN to leave state 0 */
                for (i = 0; i < 10; i++) {
-                        msleep(4);
+                        usleep_range(4000, 8000);
                        reg_anlp1 = IXGBE_READ_REG(hw, IXGBE_ANLP1);
                        if (reg_anlp1 & IXGBE_ANLP1_AN_STATE_MASK)
                                break;
@@ -353,6 +359,7 @@ static enum ixgbe_media_type ixgbe_get_media_type_82599(struct ixgbe_hw *hw)
        case IXGBE_DEV_ID_82599_SFP:
        case IXGBE_DEV_ID_82599_SFP_FCOE:
        case IXGBE_DEV_ID_82599_SFP_EM:
+        case IXGBE_DEV_ID_82599_SFP_SF2:
                media_type = ixgbe_media_type_fiber;
                break;
        case IXGBE_DEV_ID_82599_CX4:
@@ -361,6 +368,9 @@ static enum ixgbe_media_type ixgbe_get_media_type_82599(struct ixgbe_hw *hw)
        case IXGBE_DEV_ID_82599_T3_LOM:
                media_type = ixgbe_media_type_copper;
                break;
+        case IXGBE_DEV_ID_82599_LS:
+                media_type = ixgbe_media_type_fiber_lco;
+                break;
        default:
                media_type = ixgbe_media_type_unknown;
                break;
@@ -486,7 +496,7 @@ static void ixgbe_flap_tx_laser_multispeed_fiber(struct ixgbe_hw *hw)
 *
 *  Set the link speed in the AUTOC register and restarts link.
 **/
-s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,
+static s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,
                                          ixgbe_link_speed speed,
                                          bool autoneg,
                                          bool autoneg_wait_to_complete)
@@ -1176,7 +1186,7 @@ s32 ixgbe_init_fdir_signature_82599(struct ixgbe_hw *hw, u32 pballoc)
                if (IXGBE_READ_REG(hw, IXGBE_FDIRCTRL) &
                                   IXGBE_FDIRCTRL_INIT_DONE)
                        break;
-                msleep(1);
+                usleep_range(1000, 2000);
        }
        if (i >= IXGBE_FDIR_INIT_DONE_POLL)
                hw_dbg(hw, "Flow Director Signature poll time exceeded!\n");
@@ -1271,7 +1281,7 @@ s32 ixgbe_init_fdir_perfect_82599(struct ixgbe_hw *hw, u32 pballoc)
                if (IXGBE_READ_REG(hw, IXGBE_FDIRCTRL) &
                                   IXGBE_FDIRCTRL_INIT_DONE)
                        break;
-                msleep(1);
+                usleep_range(1000, 2000);
        }
        if (i >= IXGBE_FDIR_INIT_DONE_POLL)
                hw_dbg(hw, "Flow Director Perfect poll time exceeded!\n");
@@ -1740,30 +1750,29 @@ static s32 ixgbe_write_analog_reg8_82599(struct ixgbe_hw *hw, u32 reg, u8 val)
 *  ixgbe_start_hw_82599 - Prepare hardware for Tx/Rx
 *  @hw: pointer to hardware structure
 *
- *  Starts the hardware using the generic start_hw function.
+ *  Starts the hardware using the generic start_hw function
- *  Then performs device-specific:
+ *  and the generation start_hw function.
- *  Clears the rate limiter registers.
+ *  Then performs revision-specific operations, if any.
 **/
 static s32 ixgbe_start_hw_82599(struct ixgbe_hw *hw)
 {
-        u32 q_num;
+        s32 ret_val = 0;
-        s32 ret_val;
        ret_val = ixgbe_start_hw_generic(hw);
+        if (ret_val != 0)
+                goto out;
-        /* Clear the rate limiters */
+        ret_val = ixgbe_start_hw_gen2(hw);
-        for (q_num = 0; q_num < hw->mac.max_tx_queues; q_num++) {
+        if (ret_val != 0)
-                IXGBE_WRITE_REG(hw, IXGBE_RTTDQSEL, q_num);
+                goto out;
-                IXGBE_WRITE_REG(hw, IXGBE_RTTBCNRC, 0);
-        }
-        IXGBE_WRITE_FLUSH(hw);
        /* We need to run link autotry after the driver loads */
        hw->mac.autotry_restart = true;
+        hw->mac.rx_pb_size = IXGBE_82599_RX_PB_SIZE;
        if (ret_val == 0)
                ret_val = ixgbe_verify_fw_version_82599(hw);
+out:
        return ret_val;
 }
@@ -1775,7 +1784,7 @@ static s32 ixgbe_start_hw_82599(struct ixgbe_hw *hw)
 *  If PHY already detected, maintains current PHY type in hw struct,
 *  otherwise executes the PHY detection routine.
 **/
-s32 ixgbe_identify_phy_82599(struct ixgbe_hw *hw)
+static s32 ixgbe_identify_phy_82599(struct ixgbe_hw *hw)
 {
        s32 status = IXGBE_ERR_PHY_ADDR_INVALID;
@@ -1968,21 +1977,6 @@ static s32 ixgbe_enable_rx_dma_82599(struct ixgbe_hw *hw, u32 regval)
 }
 /**
- *  ixgbe_get_device_caps_82599 - Get additional device capabilities
- *  @hw: pointer to hardware structure
- *  @device_caps: the EEPROM word with the extra device capabilities
- *
- *  This function will read the EEPROM location for the device capabilities,
- *  and return the word through device_caps.
- **/
-static s32 ixgbe_get_device_caps_82599(struct ixgbe_hw *hw, u16 *device_caps)
-{
-        hw->eeprom.ops.read(hw, IXGBE_DEVICE_CAPS, device_caps);
-        return 0;
-}
-/**
 *  ixgbe_verify_fw_version_82599 - verify fw version for 82599
 *  @hw: pointer to hardware structure
 *
@@ -2030,6 +2024,110 @@ fw_version_out:
        return status;
 }
+/**
+ *  ixgbe_verify_lesm_fw_enabled_82599 - Checks LESM FW module state.
+ *  @hw: pointer to hardware structure
+ *
+ *  Returns true if the LESM FW module is present and enabled. Otherwise
+ *  returns false. Smart Speed must be disabled if LESM FW module is enabled.
+ **/
+static bool ixgbe_verify_lesm_fw_enabled_82599(struct ixgbe_hw *hw)
+{
+        bool lesm_enabled = false;
+        u16 fw_offset, fw_lesm_param_offset, fw_lesm_state;
+        s32 status;
+        /* get the offset to the Firmware Module block */
+        status = hw->eeprom.ops.read(hw, IXGBE_FW_PTR, &fw_offset);
+        if ((status != 0) ||
+            (fw_offset == 0) || (fw_offset == 0xFFFF))
+                goto out;
+        /* get the offset to the LESM Parameters block */
+        status = hw->eeprom.ops.read(hw, (fw_offset +
+                                     IXGBE_FW_LESM_PARAMETERS_PTR),
+                                     &fw_lesm_param_offset);
+        if ((status != 0) ||
+            (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF))
+                goto out;
+        /* get the lesm state word */
+        status = hw->eeprom.ops.read(hw, (fw_lesm_param_offset +
+                                     IXGBE_FW_LESM_STATE_1),
+                                     &fw_lesm_state);
+        if ((status == 0) &&
+            (fw_lesm_state & IXGBE_FW_LESM_STATE_ENABLED))
+                lesm_enabled = true;
+out:
+        return lesm_enabled;
+}
+/**
+ *  ixgbe_read_eeprom_buffer_82599 - Read EEPROM word(s) using
+ *  fastest available method
+ *
+ *  @hw: pointer to hardware structure
+ *  @offset: offset of  word in EEPROM to read
+ *  @words: number of words
+ *  @data: word(s) read from the EEPROM
+ *
+ *  Retrieves 16 bit word(s) read from EEPROM
+ **/
+static s32 ixgbe_read_eeprom_buffer_82599(struct ixgbe_hw *hw, u16 offset,
+                                          u16 words, u16 *data)
+{
+        struct ixgbe_eeprom_info *eeprom = &hw->eeprom;
+        s32 ret_val = IXGBE_ERR_CONFIG;
+        /*
+         * If EEPROM is detected and can be addressed using 14 bits,
+         * use EERD otherwise use bit bang
+         */
+        if ((eeprom->type == ixgbe_eeprom_spi) &&
+            (offset + (words - 1) <= IXGBE_EERD_MAX_ADDR))
+                ret_val = ixgbe_read_eerd_buffer_generic(hw, offset, words,
+                                                         data);
+        else
+                ret_val = ixgbe_read_eeprom_buffer_bit_bang_generic(hw, offset,
+                                                                    words,
+                                                                    data);
+        return ret_val;
+}
+/**
+ *  ixgbe_read_eeprom_82599 - Read EEPROM word using
+ *  fastest available method
+ *
+ *  @hw: pointer to hardware structure
+ *  @offset: offset of  word in the EEPROM to read
+ *  @data: word read from the EEPROM
+ *
+ *  Reads a 16 bit word from the EEPROM
+ **/
+static s32 ixgbe_read_eeprom_82599(struct ixgbe_hw *hw,
+                                   u16 offset, u16 *data)
+{
+        struct ixgbe_eeprom_info *eeprom = &hw->eeprom;
+        s32 ret_val = IXGBE_ERR_CONFIG;
+        /*
+         * If EEPROM is detected and can be addressed using 14 bits,
+         * use EERD otherwise use bit bang
+         */
+        if ((eeprom->type == ixgbe_eeprom_spi) &&
+            (offset <= IXGBE_EERD_MAX_ADDR))
+                ret_val = ixgbe_read_eerd_generic(hw, offset, data);
+        else
+                ret_val = ixgbe_read_eeprom_bit_bang_generic(hw, offset, data);
+        return ret_val;
+}
 static struct ixgbe_mac_operations mac_ops_82599 = {
        .init_hw                = &ixgbe_init_hw_generic,
        .reset_hw               = &ixgbe_reset_hw_82599,
@@ -2040,7 +2138,7 @@ static struct ixgbe_mac_operations mac_ops_82599 = {
        .enable_rx_dma          = &ixgbe_enable_rx_dma_82599,
        .get_mac_addr           = &ixgbe_get_mac_addr_generic,
        .get_san_mac_addr       = &ixgbe_get_san_mac_addr_generic,
-        .get_device_caps        = &ixgbe_get_device_caps_82599,
+        .get_device_caps        = &ixgbe_get_device_caps_generic,
        .get_wwn_prefix         = &ixgbe_get_wwn_prefix_generic,
        .stop_adapter           = &ixgbe_stop_adapter_generic,
        .get_bus_info           = &ixgbe_get_bus_info_generic,
@@ -2076,8 +2174,10 @@ static struct ixgbe_mac_operations mac_ops_82599 = {
 static struct ixgbe_eeprom_operations eeprom_ops_82599 = {
        .init_params            = &ixgbe_init_eeprom_params_generic,
-        .read                   = &ixgbe_read_eerd_generic,
+        .read                   = &ixgbe_read_eeprom_82599,
+        .read_buffer            = &ixgbe_read_eeprom_buffer_82599,
        .write                  = &ixgbe_write_eeprom_generic,
+        .write_buffer           = &ixgbe_write_eeprom_buffer_bit_bang_generic,
        .calc_checksum          = &ixgbe_calc_eeprom_checksum_generic,
        .validate_checksum      = &ixgbe_validate_eeprom_checksum_generic,
        .update_checksum        = &ixgbe_update_eeprom_checksum_generic,
diff --git a/drivers/net/ixgbe/ixgbe_common.c b/drivers/net/ixgbe/ixgbe_common.c
index bcd952916eb2..b894b42a741c 100644
--- a/drivers/net/ixgbe/ixgbe_common.c
+++ b/drivers/net/ixgbe/ixgbe_common.c
@@ -54,6 +54,13 @@ static s32 ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw);
 static s32 ixgbe_negotiate_fc(struct ixgbe_hw *hw, u32 adv_reg, u32 lp_reg,
                              u32 adv_sym, u32 adv_asm, u32 lp_sym, u32 lp_asm);
 static s32 ixgbe_setup_fc(struct ixgbe_hw *hw, s32 packetbuf_num);
+static s32 ixgbe_poll_eerd_eewr_done(struct ixgbe_hw *hw, u32 ee_reg);
+static s32 ixgbe_read_eeprom_buffer_bit_bang(struct ixgbe_hw *hw, u16 offset,
+                                             u16 words, u16 *data);
+static s32 ixgbe_write_eeprom_buffer_bit_bang(struct ixgbe_hw *hw, u16 offset,
+                                             u16 words, u16 *data);
+static s32 ixgbe_detect_eeprom_page_size_generic(struct ixgbe_hw *hw,
+                                                 u16 offset);
 /**
 *  ixgbe_start_hw_generic - Prepare hardware for Tx/Rx
@@ -96,6 +103,45 @@ s32 ixgbe_start_hw_generic(struct ixgbe_hw *hw)
 }
 /**
+ *  ixgbe_start_hw_gen2 - Init sequence for common device family
+ *  @hw: pointer to hw structure
+ *
+ * Performs the init sequence common to the second generation
+ * of 10 GbE devices.
+ * Devices in the second generation:
+ *     82599
+ *     X540
+ **/
+s32 ixgbe_start_hw_gen2(struct ixgbe_hw *hw)
+{
+        u32 i;
+        u32 regval;
+        /* Clear the rate limiters */
+        for (i = 0; i < hw->mac.max_tx_queues; i++) {
+                IXGBE_WRITE_REG(hw, IXGBE_RTTDQSEL, i);
+                IXGBE_WRITE_REG(hw, IXGBE_RTTBCNRC, 0);
+        }
+        IXGBE_WRITE_FLUSH(hw);
+        /* Disable relaxed ordering */
+        for (i = 0; i < hw->mac.max_tx_queues; i++) {
+                regval = IXGBE_READ_REG(hw, IXGBE_DCA_TXCTRL_82599(i));
+                regval &= ~IXGBE_DCA_TXCTRL_TX_WB_RO_EN;
+                IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL_82599(i), regval);
+        }
+        for (i = 0; i < hw->mac.max_rx_queues; i++) {
+                regval = IXGBE_READ_REG(hw, IXGBE_DCA_RXCTRL(i));
+                regval &= ~(IXGBE_DCA_RXCTRL_DESC_WRO_EN |
+                                        IXGBE_DCA_RXCTRL_DESC_HSRO_EN);
+                IXGBE_WRITE_REG(hw, IXGBE_DCA_RXCTRL(i), regval);
+        }
+        return 0;
+}
+/**
 *  ixgbe_init_hw_generic - Generic hardware initialization
 *  @hw: pointer to hardware structure
 *
@@ -464,7 +510,7 @@ s32 ixgbe_stop_adapter_generic(struct ixgbe_hw *hw)
        reg_val &= ~(IXGBE_RXCTRL_RXEN);
        IXGBE_WRITE_REG(hw, IXGBE_RXCTRL, reg_val);
        IXGBE_WRITE_FLUSH(hw);
-        msleep(2);
+        usleep_range(2000, 4000);
        /* Clear interrupt mask to stop from interrupts being generated */
        IXGBE_WRITE_REG(hw, IXGBE_EIMC, IXGBE_IRQ_CLEAR_MASK);
@@ -545,6 +591,8 @@ s32 ixgbe_init_eeprom_params_generic(struct ixgbe_hw *hw)
                /* Set default semaphore delay to 10ms which is a well
                 * tested value */
                eeprom->semaphore_delay = 10;
+                /* Clear EEPROM page size, it will be initialized as needed */
+                eeprom->word_page_size = 0;
                /*
                 * Check for EEPROM present first.
@@ -577,26 +625,78 @@ s32 ixgbe_init_eeprom_params_generic(struct ixgbe_hw *hw)
 }
 /**
- *  ixgbe_write_eeprom_generic - Writes 16 bit value to EEPROM
+ *  ixgbe_write_eeprom_buffer_bit_bang_generic - Write EEPROM using bit-bang
 *  @hw: pointer to hardware structure
- *  @offset: offset within the EEPROM to be written to
+ *  @offset: offset within the EEPROM to write
- *  @data: 16 bit word to be written to the EEPROM
+ *  @words: number of words
+ *  @data: 16 bit word(s) to write to EEPROM
 *
- *  If ixgbe_eeprom_update_checksum is not called after this function, the
+ *  Reads 16 bit word(s) from EEPROM through bit-bang method
- *  EEPROM will most likely contain an invalid checksum.
 **/
-s32 ixgbe_write_eeprom_generic(struct ixgbe_hw *hw, u16 offset, u16 data)
+s32 ixgbe_write_eeprom_buffer_bit_bang_generic(struct ixgbe_hw *hw, u16 offset,
+                                               u16 words, u16 *data)
 {
-        s32 status;
+        s32 status = 0;
-        u8 write_opcode = IXGBE_EEPROM_WRITE_OPCODE_SPI;
+        u16 i, count;
        hw->eeprom.ops.init_params(hw);
-        if (offset >= hw->eeprom.word_size) {
+        if (words == 0) {
+                status = IXGBE_ERR_INVALID_ARGUMENT;
+                goto out;
+        }
+        if (offset + words > hw->eeprom.word_size) {
                status = IXGBE_ERR_EEPROM;
                goto out;
        }
+        /*
+         * The EEPROM page size cannot be queried from the chip. We do lazy
+         * initialization. It is worth to do that when we write large buffer.
+         */
+        if ((hw->eeprom.word_page_size == 0) &&
+            (words > IXGBE_EEPROM_PAGE_SIZE_MAX))
+                ixgbe_detect_eeprom_page_size_generic(hw, offset);
+        /*
+         * We cannot hold synchronization semaphores for too long
+         * to avoid other entity starvation. However it is more efficient
+         * to read in bursts than synchronizing access for each word.
+         */
+        for (i = 0; i < words; i += IXGBE_EEPROM_RD_BUFFER_MAX_COUNT) {
+                count = (words - i) / IXGBE_EEPROM_RD_BUFFER_MAX_COUNT > 0 ?
+                         IXGBE_EEPROM_RD_BUFFER_MAX_COUNT : (words - i);
+                status = ixgbe_write_eeprom_buffer_bit_bang(hw, offset + i,
+                                                            count, &data[i]);
+                if (status != 0)
+                        break;
+        }
+out:
+        return status;
+}
+/**
+ *  ixgbe_write_eeprom_buffer_bit_bang - Writes 16 bit word(s) to EEPROM
+ *  @hw: pointer to hardware structure
+ *  @offset: offset within the EEPROM to be written to
+ *  @words: number of word(s)
+ *  @data: 16 bit word(s) to be written to the EEPROM
+ *
+ *  If ixgbe_eeprom_update_checksum is not called after this function, the
+ *  EEPROM will most likely contain an invalid checksum.
+ **/
+static s32 ixgbe_write_eeprom_buffer_bit_bang(struct ixgbe_hw *hw, u16 offset,
+                                              u16 words, u16 *data)
+{
+        s32 status;
+        u16 word;
+        u16 page_size;
+        u16 i;
+        u8 write_opcode = IXGBE_EEPROM_WRITE_OPCODE_SPI;
        /* Prepare the EEPROM for writing  */
        status = ixgbe_acquire_eeprom(hw);
@@ -608,62 +708,147 @@ s32 ixgbe_write_eeprom_generic(struct ixgbe_hw *hw, u16 offset, u16 data)
        }
        if (status == 0) {
-                ixgbe_standby_eeprom(hw);
+                for (i = 0; i < words; i++) {
+                        ixgbe_standby_eeprom(hw);
-                /*  Send the WRITE ENABLE command (8 bit opcode )  */
+                        /*  Send the WRITE ENABLE command (8 bit opcode )  */
-                ixgbe_shift_out_eeprom_bits(hw, IXGBE_EEPROM_WREN_OPCODE_SPI,
+                        ixgbe_shift_out_eeprom_bits(hw,
-                                            IXGBE_EEPROM_OPCODE_BITS);
+                                                  IXGBE_EEPROM_WREN_OPCODE_SPI,
+                                                  IXGBE_EEPROM_OPCODE_BITS);
-                ixgbe_standby_eeprom(hw);
+                        ixgbe_standby_eeprom(hw);
-                /*
+                        /*
-                 * Some SPI eeproms use the 8th address bit embedded in the
+                         * Some SPI eeproms use the 8th address bit embedded
-                 * opcode
+                         * in the opcode
-                 */
+                         */
-                if ((hw->eeprom.address_bits == 8) && (offset >= 128))
+                        if ((hw->eeprom.address_bits == 8) &&
-                        write_opcode |= IXGBE_EEPROM_A8_OPCODE_SPI;
+                            ((offset + i) >= 128))
+                                write_opcode |= IXGBE_EEPROM_A8_OPCODE_SPI;
+                        /* Send the Write command (8-bit opcode + addr) */
+                        ixgbe_shift_out_eeprom_bits(hw, write_opcode,
+                                                    IXGBE_EEPROM_OPCODE_BITS);
+                        ixgbe_shift_out_eeprom_bits(hw, (u16)((offset + i) * 2),
+                                                    hw->eeprom.address_bits);
+                        page_size = hw->eeprom.word_page_size;
+                        /* Send the data in burst via SPI*/
+                        do {
+                                word = data[i];
+                                word = (word >> 8) | (word << 8);
+                                ixgbe_shift_out_eeprom_bits(hw, word, 16);
+                                if (page_size == 0)
+                                        break;
+                                /* do not wrap around page */
+                                if (((offset + i) & (page_size - 1)) ==
+                                    (page_size - 1))
+                                        break;
+                        } while (++i < words);
+                        ixgbe_standby_eeprom(hw);
+                        usleep_range(10000, 20000);
+                }
+                /* Done with writing - release the EEPROM */
+                ixgbe_release_eeprom(hw);
+        }
-                /* Send the Write command (8-bit opcode + addr) */
+        return status;
-                ixgbe_shift_out_eeprom_bits(hw, write_opcode,
+}
-                                            IXGBE_EEPROM_OPCODE_BITS);
-                ixgbe_shift_out_eeprom_bits(hw, (u16)(offset*2),
-                                            hw->eeprom.address_bits);
-                /* Send the data */
+/**
-                data = (data >> 8) | (data << 8);
+ *  ixgbe_write_eeprom_generic - Writes 16 bit value to EEPROM
-                ixgbe_shift_out_eeprom_bits(hw, data, 16);
+ *  @hw: pointer to hardware structure
-                ixgbe_standby_eeprom(hw);
+ *  @offset: offset within the EEPROM to be written to
+ *  @data: 16 bit word to be written to the EEPROM
+ *
+ *  If ixgbe_eeprom_update_checksum is not called after this function, the
+ *  EEPROM will most likely contain an invalid checksum.
+ **/
+s32 ixgbe_write_eeprom_generic(struct ixgbe_hw *hw, u16 offset, u16 data)
+{
+        s32 status;
-                /* Done with writing - release the EEPROM */
+        hw->eeprom.ops.init_params(hw);
-                ixgbe_release_eeprom(hw);
+        if (offset >= hw->eeprom.word_size) {
+                status = IXGBE_ERR_EEPROM;
+                goto out;
        }
+        status = ixgbe_write_eeprom_buffer_bit_bang(hw, offset, 1, &data);
 out:
        return status;
 }
 /**
- *  ixgbe_read_eeprom_bit_bang_generic - Read EEPROM word using bit-bang
+ *  ixgbe_read_eeprom_buffer_bit_bang_generic - Read EEPROM using bit-bang
 *  @hw: pointer to hardware structure
 *  @offset: offset within the EEPROM to be read
- *  @data: read 16 bit value from EEPROM
+ *  @words: number of word(s)
+ *  @data: read 16 bit words(s) from EEPROM
 *
- *  Reads 16 bit value from EEPROM through bit-bang method
+ *  Reads 16 bit word(s) from EEPROM through bit-bang method
 **/
-s32 ixgbe_read_eeprom_bit_bang_generic(struct ixgbe_hw *hw, u16 offset,
+s32 ixgbe_read_eeprom_buffer_bit_bang_generic(struct ixgbe_hw *hw, u16 offset,
-                                       u16 *data)
+                                              u16 words, u16 *data)
 {
-        s32 status;
+        s32 status = 0;
-        u16 word_in;
+        u16 i, count;
-        u8 read_opcode = IXGBE_EEPROM_READ_OPCODE_SPI;
        hw->eeprom.ops.init_params(hw);
-        if (offset >= hw->eeprom.word_size) {
+        if (words == 0) {
+                status = IXGBE_ERR_INVALID_ARGUMENT;
+                goto out;
+        }
+        if (offset + words > hw->eeprom.word_size) {
                status = IXGBE_ERR_EEPROM;
                goto out;
        }
+        /*
+         * We cannot hold synchronization semaphores for too long
+         * to avoid other entity starvation. However it is more efficient
+         * to read in bursts than synchronizing access for each word.
+         */
+        for (i = 0; i < words; i += IXGBE_EEPROM_RD_BUFFER_MAX_COUNT) {
+                count = (words - i) / IXGBE_EEPROM_RD_BUFFER_MAX_COUNT > 0 ?
+                         IXGBE_EEPROM_RD_BUFFER_MAX_COUNT : (words - i);
+                status = ixgbe_read_eeprom_buffer_bit_bang(hw, offset + i,
+                                                           count, &data[i]);
+                if (status != 0)
+                        break;
+        }
+out:
+        return status;
+}
+/**
+ *  ixgbe_read_eeprom_buffer_bit_bang - Read EEPROM using bit-bang
+ *  @hw: pointer to hardware structure
+ *  @offset: offset within the EEPROM to be read
+ *  @words: number of word(s)
+ *  @data: read 16 bit word(s) from EEPROM
+ *
+ *  Reads 16 bit word(s) from EEPROM through bit-bang method
+ **/
+static s32 ixgbe_read_eeprom_buffer_bit_bang(struct ixgbe_hw *hw, u16 offset,
+                                             u16 words, u16 *data)
+{
+        s32 status;
+        u16 word_in;
+        u8 read_opcode = IXGBE_EEPROM_READ_OPCODE_SPI;
+        u16 i;
        /* Prepare the EEPROM for reading  */
        status = ixgbe_acquire_eeprom(hw);
@@ -675,29 +860,145 @@ s32 ixgbe_read_eeprom_bit_bang_generic(struct ixgbe_hw *hw, u16 offset,
        }
        if (status == 0) {
-                ixgbe_standby_eeprom(hw);
+                for (i = 0; i < words; i++) {
+                        ixgbe_standby_eeprom(hw);
+                        /*
+                         * Some SPI eeproms use the 8th address bit embedded
+                         * in the opcode
+                         */
+                        if ((hw->eeprom.address_bits == 8) &&
+                            ((offset + i) >= 128))
+                                read_opcode |= IXGBE_EEPROM_A8_OPCODE_SPI;
+                        /* Send the READ command (opcode + addr) */
+                        ixgbe_shift_out_eeprom_bits(hw, read_opcode,
+                                                    IXGBE_EEPROM_OPCODE_BITS);
+                        ixgbe_shift_out_eeprom_bits(hw, (u16)((offset + i) * 2),
+                                                    hw->eeprom.address_bits);
+                        /* Read the data. */
+                        word_in = ixgbe_shift_in_eeprom_bits(hw, 16);
+                        data[i] = (word_in >> 8) | (word_in << 8);
+                }
-                /*
+                /* End this read operation */
-                 * Some SPI eeproms use the 8th address bit embedded in the
+                ixgbe_release_eeprom(hw);
-                 * opcode
+        }
-                 */
-                if ((hw->eeprom.address_bits == 8) && (offset >= 128))
-                        read_opcode |= IXGBE_EEPROM_A8_OPCODE_SPI;
-                /* Send the READ command (opcode + addr) */
+        return status;
-                ixgbe_shift_out_eeprom_bits(hw, read_opcode,
+}
-                                            IXGBE_EEPROM_OPCODE_BITS);
-                ixgbe_shift_out_eeprom_bits(hw, (u16)(offset*2),
+/**
-                                            hw->eeprom.address_bits);
+ *  ixgbe_read_eeprom_bit_bang_generic - Read EEPROM word using bit-bang
+ *  @hw: pointer to hardware structure
+ *  @offset: offset within the EEPROM to be read
+ *  @data: read 16 bit value from EEPROM
+ *
+ *  Reads 16 bit value from EEPROM through bit-bang method
+ **/
+s32 ixgbe_read_eeprom_bit_bang_generic(struct ixgbe_hw *hw, u16 offset,
+                                       u16 *data)
+{
+        s32 status;
-                /* Read the data. */
+        hw->eeprom.ops.init_params(hw);
-                word_in = ixgbe_shift_in_eeprom_bits(hw, 16);
-                *data = (word_in >> 8) | (word_in << 8);
-                /* End this read operation */
+        if (offset >= hw->eeprom.word_size) {
-                ixgbe_release_eeprom(hw);
+                status = IXGBE_ERR_EEPROM;
+                goto out;
+        }
+        status = ixgbe_read_eeprom_buffer_bit_bang(hw, offset, 1, data);
+out:
+        return status;
+}
+/**
+ *  ixgbe_read_eerd_buffer_generic - Read EEPROM word(s) using EERD
+ *  @hw: pointer to hardware structure
+ *  @offset: offset of word in the EEPROM to read
+ *  @words: number of word(s)
+ *  @data: 16 bit word(s) from the EEPROM
+ *
+ *  Reads a 16 bit word(s) from the EEPROM using the EERD register.
+ **/
+s32 ixgbe_read_eerd_buffer_generic(struct ixgbe_hw *hw, u16 offset,
+                                   u16 words, u16 *data)
+{
+        u32 eerd;
+        s32 status = 0;
+        u32 i;
+        hw->eeprom.ops.init_params(hw);
+        if (words == 0) {
+                status = IXGBE_ERR_INVALID_ARGUMENT;
+                goto out;
+        }
+        if (offset >= hw->eeprom.word_size) {
+                status = IXGBE_ERR_EEPROM;
+                goto out;
        }
+        for (i = 0; i < words; i++) {
+                eerd = ((offset + i) << IXGBE_EEPROM_RW_ADDR_SHIFT) +
+                       IXGBE_EEPROM_RW_REG_START;
+                IXGBE_WRITE_REG(hw, IXGBE_EERD, eerd);
+                status = ixgbe_poll_eerd_eewr_done(hw, IXGBE_NVM_POLL_READ);
+                if (status == 0) {
+                        data[i] = (IXGBE_READ_REG(hw, IXGBE_EERD) >>
+                                   IXGBE_EEPROM_RW_REG_DATA);
+                } else {
+                        hw_dbg(hw, "Eeprom read timed out\n");
+                        goto out;
+                }
+        }
+out:
+        return status;
+}
+/**
+ *  ixgbe_detect_eeprom_page_size_generic - Detect EEPROM page size
+ *  @hw: pointer to hardware structure
+ *  @offset: offset within the EEPROM to be used as a scratch pad
+ *
+ *  Discover EEPROM page size by writing marching data at given offset.
+ *  This function is called only when we are writing a new large buffer
+ *  at given offset so the data would be overwritten anyway.
+ **/
+static s32 ixgbe_detect_eeprom_page_size_generic(struct ixgbe_hw *hw,
+                                                 u16 offset)
+{
+        u16 data[IXGBE_EEPROM_PAGE_SIZE_MAX];
+        s32 status = 0;
+        u16 i;
+        for (i = 0; i < IXGBE_EEPROM_PAGE_SIZE_MAX; i++)
+                data[i] = i;
+        hw->eeprom.word_page_size = IXGBE_EEPROM_PAGE_SIZE_MAX;
+        status = ixgbe_write_eeprom_buffer_bit_bang(hw, offset,
+                                             IXGBE_EEPROM_PAGE_SIZE_MAX, data);
+        hw->eeprom.word_page_size = 0;
+        if (status != 0)
+                goto out;
+        status = ixgbe_read_eeprom_buffer_bit_bang(hw, offset, 1, data);
+        if (status != 0)
+                goto out;
+        /*
+         * When writing in burst more than the actual page size
+         * EEPROM address wraps around current page.
+         */
+        hw->eeprom.word_page_size = IXGBE_EEPROM_PAGE_SIZE_MAX - data[0];
+        hw_dbg(hw, "Detected EEPROM page size = %d words.",
+               hw->eeprom.word_page_size);
 out:
        return status;
 }
@@ -712,33 +1013,75 @@ out:
 **/
 s32 ixgbe_read_eerd_generic(struct ixgbe_hw *hw, u16 offset, u16 *data)
 {
-        u32 eerd;
+        return ixgbe_read_eerd_buffer_generic(hw, offset, 1, data);
-        s32 status;
+}
+/**
+ *  ixgbe_write_eewr_buffer_generic - Write EEPROM word(s) using EEWR
+ *  @hw: pointer to hardware structure
+ *  @offset: offset of  word in the EEPROM to write
+ *  @words: number of words
+ *  @data: word(s) write to the EEPROM
+ *
+ *  Write a 16 bit word(s) to the EEPROM using the EEWR register.
+ **/
+s32 ixgbe_write_eewr_buffer_generic(struct ixgbe_hw *hw, u16 offset,
+                                    u16 words, u16 *data)
+{
+        u32 eewr;
+        s32 status = 0;
+        u16 i;
        hw->eeprom.ops.init_params(hw);
+        if (words == 0) {
+                status = IXGBE_ERR_INVALID_ARGUMENT;
+                goto out;
+        }
        if (offset >= hw->eeprom.word_size) {
                status = IXGBE_ERR_EEPROM;
                goto out;
        }
-        eerd = (offset << IXGBE_EEPROM_RW_ADDR_SHIFT) +
+        for (i = 0; i < words; i++) {
-               IXGBE_EEPROM_RW_REG_START;
+                eewr = ((offset + i) << IXGBE_EEPROM_RW_ADDR_SHIFT) |
+                       (data[i] << IXGBE_EEPROM_RW_REG_DATA) |
+                       IXGBE_EEPROM_RW_REG_START;
-        IXGBE_WRITE_REG(hw, IXGBE_EERD, eerd);
+                status = ixgbe_poll_eerd_eewr_done(hw, IXGBE_NVM_POLL_WRITE);
-        status = ixgbe_poll_eerd_eewr_done(hw, IXGBE_NVM_POLL_READ);
+                if (status != 0) {
+                        hw_dbg(hw, "Eeprom write EEWR timed out\n");
+                        goto out;
+                }
-        if (status == 0)
+                IXGBE_WRITE_REG(hw, IXGBE_EEWR, eewr);
-                *data = (IXGBE_READ_REG(hw, IXGBE_EERD) >>
-                         IXGBE_EEPROM_RW_REG_DATA);
+                status = ixgbe_poll_eerd_eewr_done(hw, IXGBE_NVM_POLL_WRITE);
-        else
+                if (status != 0) {
-                hw_dbg(hw, "Eeprom read timed out\n");
+                        hw_dbg(hw, "Eeprom write EEWR timed out\n");
+                        goto out;
+                }
+        }
 out:
        return status;
 }
 /**
+ *  ixgbe_write_eewr_generic - Write EEPROM word using EEWR
+ *  @hw: pointer to hardware structure
+ *  @offset: offset of  word in the EEPROM to write
+ *  @data: word write to the EEPROM
+ *
+ *  Write a 16 bit word to the EEPROM using the EEWR register.
+ **/
+s32 ixgbe_write_eewr_generic(struct ixgbe_hw *hw, u16 offset, u16 data)
+{
+        return ixgbe_write_eewr_buffer_generic(hw, offset, 1, &data);
+}
+/**
 *  ixgbe_poll_eerd_eewr_done - Poll EERD read or EEWR write status
 *  @hw: pointer to hardware structure
 *  @ee_reg: EEPROM flag for polling
@@ -746,7 +1089,7 @@ out:
 *  Polls the status bit (bit 1) of the EERD or EEWR to determine when the
 *  read or write is done respectively.
 **/
-s32 ixgbe_poll_eerd_eewr_done(struct ixgbe_hw *hw, u32 ee_reg)
+static s32 ixgbe_poll_eerd_eewr_done(struct ixgbe_hw *hw, u32 ee_reg)
 {
        u32 i;
        u32 reg;
@@ -846,6 +1189,28 @@ static s32 ixgbe_get_eeprom_semaphore(struct ixgbe_hw *hw)
                udelay(50);
        }
+        if (i == timeout) {
+                hw_dbg(hw, "Driver can't access the Eeprom - SMBI Semaphore "
+                       "not granted.\n");
+                /*
+                 * this release is particularly important because our attempts
+                 * above to get the semaphore may have succeeded, and if there
+                 * was a timeout, we should unconditionally clear the semaphore
+                 * bits to free the driver to make progress
+                 */
+                ixgbe_release_eeprom_semaphore(hw);
+                udelay(50);
+                /*
+                 * one last try
+                 * If the SMBI bit is 0 when we read it, then the bit will be
+                 * set and we have the semaphore
+                 */
+                swsm = IXGBE_READ_REG(hw, IXGBE_SWSM);
+                if (!(swsm & IXGBE_SWSM_SMBI))
+                        status = 0;
+        }
        /* Now get the semaphore between SW/FW through the SWESMBI bit */
        if (status == 0) {
                for (i = 0; i < timeout; i++) {
@@ -1112,8 +1477,12 @@ static void ixgbe_release_eeprom(struct ixgbe_hw *hw)
        hw->mac.ops.release_swfw_sync(hw, IXGBE_GSSR_EEP_SM);
-        /* Delay before attempt to obtain semaphore again to allow FW access */
+        /*
-        msleep(hw->eeprom.semaphore_delay);
+         * Delay before attempt to obtain semaphore again to allow FW
+         * access. semaphore_delay is in ms we need us for usleep_range
+         */
+        usleep_range(hw->eeprom.semaphore_delay * 1000,
+                     hw->eeprom.semaphore_delay * 2000);
 }
 /**
@@ -2189,7 +2558,7 @@ s32 ixgbe_acquire_swfw_sync(struct ixgbe_hw *hw, u16 mask)
                 * thread currently using resource (swmask)
                 */
                ixgbe_release_eeprom_semaphore(hw);
-                msleep(5);
+                usleep_range(5000, 10000);
                timeout--;
        }
@@ -2263,7 +2632,7 @@ s32 ixgbe_blink_led_start_generic(struct ixgbe_hw *hw, u32 index)
                autoc_reg |= IXGBE_AUTOC_AN_RESTART;
                autoc_reg |= IXGBE_AUTOC_FLU;
                IXGBE_WRITE_REG(hw, IXGBE_AUTOC, autoc_reg);
-                msleep(10);
+                usleep_range(10000, 20000);
        }
        led_reg &= ~IXGBE_LED_MODE_MASK(index);
@@ -2883,3 +3252,18 @@ void ixgbe_set_vlan_anti_spoofing(struct ixgbe_hw *hw, bool enable, int vf)
                pfvfspoof &= ~(1 << vf_target_shift);
        IXGBE_WRITE_REG(hw, IXGBE_PFVFSPOOF(vf_target_reg), pfvfspoof);
 }
+/**
+ *  ixgbe_get_device_caps_generic - Get additional device capabilities
+ *  @hw: pointer to hardware structure
+ *  @device_caps: the EEPROM word with the extra device capabilities
+ *
+ *  This function will read the EEPROM location for the device capabilities,
+ *  and return the word through device_caps.
+ **/
+s32 ixgbe_get_device_caps_generic(struct ixgbe_hw *hw, u16 *device_caps)
+{
+        hw->eeprom.ops.read(hw, IXGBE_DEVICE_CAPS, device_caps);
+        return 0;
+}
diff --git a/drivers/net/ixgbe/ixgbe_common.h b/drivers/net/ixgbe/ixgbe_common.h
index 508f635fc2ca..46be83cfb500 100644
--- a/drivers/net/ixgbe/ixgbe_common.h
+++ b/drivers/net/ixgbe/ixgbe_common.h
@@ -35,6 +35,7 @@ u32 ixgbe_get_pcie_msix_count_generic(struct ixgbe_hw *hw);
 s32 ixgbe_init_ops_generic(struct ixgbe_hw *hw);
 s32 ixgbe_init_hw_generic(struct ixgbe_hw *hw);
 s32 ixgbe_start_hw_generic(struct ixgbe_hw *hw);
+s32 ixgbe_start_hw_gen2(struct ixgbe_hw *hw);
 s32 ixgbe_clear_hw_cntrs_generic(struct ixgbe_hw *hw);
 s32 ixgbe_read_pba_string_generic(struct ixgbe_hw *hw, u8 *pba_num,
                                  u32 pba_num_size);
@@ -48,14 +49,22 @@ s32 ixgbe_led_off_generic(struct ixgbe_hw *hw, u32 index);
 s32 ixgbe_init_eeprom_params_generic(struct ixgbe_hw *hw);
 s32 ixgbe_write_eeprom_generic(struct ixgbe_hw *hw, u16 offset, u16 data);
+s32 ixgbe_write_eeprom_buffer_bit_bang_generic(struct ixgbe_hw *hw, u16 offset,
+                                               u16 words, u16 *data);
 s32 ixgbe_read_eerd_generic(struct ixgbe_hw *hw, u16 offset, u16 *data);
+s32 ixgbe_read_eerd_buffer_generic(struct ixgbe_hw *hw, u16 offset,
+                                   u16 words, u16 *data);
+s32 ixgbe_write_eewr_generic(struct ixgbe_hw *hw, u16 offset, u16 data);
+s32 ixgbe_write_eewr_buffer_generic(struct ixgbe_hw *hw, u16 offset,
+                                    u16 words, u16 *data);
 s32 ixgbe_read_eeprom_bit_bang_generic(struct ixgbe_hw *hw, u16 offset,
                                       u16 *data);
+s32 ixgbe_read_eeprom_buffer_bit_bang_generic(struct ixgbe_hw *hw, u16 offset,
+                                              u16 words, u16 *data);
 u16 ixgbe_calc_eeprom_checksum_generic(struct ixgbe_hw *hw);
 s32 ixgbe_validate_eeprom_checksum_generic(struct ixgbe_hw *hw,
                                           u16 *checksum_val);
 s32 ixgbe_update_eeprom_checksum_generic(struct ixgbe_hw *hw);
-s32 ixgbe_poll_eerd_eewr_done(struct ixgbe_hw *hw, u32 ee_reg);
 s32 ixgbe_set_rar_generic(struct ixgbe_hw *hw, u32 index, u8 *addr, u32 vmdq,
                          u32 enable_addr);
@@ -89,6 +98,7 @@ s32 ixgbe_blink_led_start_generic(struct ixgbe_hw *hw, u32 index);
 s32 ixgbe_blink_led_stop_generic(struct ixgbe_hw *hw, u32 index);
 void ixgbe_set_mac_anti_spoofing(struct ixgbe_hw *hw, bool enable, int pf);
 void ixgbe_set_vlan_anti_spoofing(struct ixgbe_hw *hw, bool enable, int vf);
+s32 ixgbe_get_device_caps_generic(struct ixgbe_hw *hw, u16 *device_caps);
 #define IXGBE_WRITE_REG(a, reg, value) writel((value), ((a)->hw_addr + (reg)))
diff --git a/drivers/net/ixgbe/ixgbe_dcb_82598.c b/drivers/net/ixgbe/ixgbe_dcb_82598.c
index 1bc57e52cee3..771d01a60d06 100644
--- a/drivers/net/ixgbe/ixgbe_dcb_82598.c
+++ b/drivers/net/ixgbe/ixgbe_dcb_82598.c
@@ -289,7 +289,7 @@ s32 ixgbe_dcb_config_pfc_82598(struct ixgbe_hw *hw, u8 pfc_en)
 * Configure queue statistics registers, all queues belonging to same traffic
 * class uses a single set of queue statistics counters.
 */
-s32 ixgbe_dcb_config_tc_stats_82598(struct ixgbe_hw *hw)
+static s32 ixgbe_dcb_config_tc_stats_82598(struct ixgbe_hw *hw)
 {
        u32 reg = 0;
        u8  i   = 0;
diff --git a/drivers/net/ixgbe/ixgbe_dcb_82599.c b/drivers/net/ixgbe/ixgbe_dcb_82599.c
index 025af8c53ddb..d50cf78c234d 100644
--- a/drivers/net/ixgbe/ixgbe_dcb_82599.c
+++ b/drivers/net/ixgbe/ixgbe_dcb_82599.c
@@ -39,36 +39,52 @@
 */
 static s32 ixgbe_dcb_config_packet_buffers_82599(struct ixgbe_hw *hw, u8 rx_pba)
 {
-        s32 ret_val = 0;
+        int num_tcs = IXGBE_MAX_PACKET_BUFFERS;
-        u32 value = IXGBE_RXPBSIZE_64KB;
+        u32 rx_pb_size = hw->mac.rx_pb_size << IXGBE_RXPBSIZE_SHIFT;
+        u32 rxpktsize;
+        u32 txpktsize;
+        u32 txpbthresh;
        u8  i = 0;
-        /* Setup Rx packet buffer sizes */
+        /*
-        switch (rx_pba) {
+         * This really means configure the first half of the TCs
-        case pba_80_48:
+         * (Traffic Classes) to use 5/8 of the Rx packet buffer
-                /* Setup the first four at 80KB */
+         * space.  To determine the size of the buffer for each TC,
-                value = IXGBE_RXPBSIZE_80KB;
+         * we are multiplying the average size by 5/4 and applying
-                for (; i < 4; i++)
+         * it to half of the traffic classes.
-                        IXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), value);
+         */
-                /* Setup the last four at 48KB...don't re-init i */
+        if (rx_pba == pba_80_48) {
-                value = IXGBE_RXPBSIZE_48KB;
+                rxpktsize = (rx_pb_size * 5) / (num_tcs * 4);
-                /* Fall Through */
+                rx_pb_size -= rxpktsize * (num_tcs / 2);
-        case pba_equal:
+                for (; i < (num_tcs / 2); i++)
-        default:
+                        IXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), rxpktsize);
-                for (; i < IXGBE_MAX_PACKET_BUFFERS; i++)
+        }
-                        IXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), value);
+        /* Divide the remaining Rx packet buffer evenly among the TCs */
-                /* Setup Tx packet buffer sizes */
+        rxpktsize = rx_pb_size / (num_tcs - i);
-                for (i = 0; i < IXGBE_MAX_PACKET_BUFFERS; i++) {
+        for (; i < num_tcs; i++)
-                        IXGBE_WRITE_REG(hw, IXGBE_TXPBSIZE(i),
+                IXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), rxpktsize);
-                                        IXGBE_TXPBSIZE_20KB);
-                        IXGBE_WRITE_REG(hw, IXGBE_TXPBTHRESH(i),
+        /*
-                                        IXGBE_TXPBTHRESH_DCB);
+         * Setup Tx packet buffer and threshold equally for all TCs
-                }
+         * TXPBTHRESH register is set in K so divide by 1024 and subtract
-                break;
+         * 10 since the largest packet we support is just over 9K.
+         */
+        txpktsize = IXGBE_TXPBSIZE_MAX / num_tcs;
+        txpbthresh = (txpktsize / 1024) - IXGBE_TXPKT_SIZE_MAX;
+        for (i = 0; i < num_tcs; i++) {
+                IXGBE_WRITE_REG(hw, IXGBE_TXPBSIZE(i), txpktsize);
+                IXGBE_WRITE_REG(hw, IXGBE_TXPBTHRESH(i), txpbthresh);
+        }
+        /* Clear unused TCs, if any, to zero buffer size*/
+        for (; i < MAX_TRAFFIC_CLASS; i++) {
+                IXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), 0);
+                IXGBE_WRITE_REG(hw, IXGBE_TXPBSIZE(i), 0);
+                IXGBE_WRITE_REG(hw, IXGBE_TXPBTHRESH(i), 0);
        }
-        return ret_val;
+        return 0;
 }
 /**
@@ -285,12 +301,17 @@ s32 ixgbe_dcb_config_pfc_82599(struct ixgbe_hw *hw, u8 pfc_en)
                IXGBE_WRITE_REG(hw, IXGBE_FCCFG, reg);
                /*
                 * Enable Receive PFC
-                 * We will always honor XOFF frames we receive when
+                 * 82599 will always honor XOFF frames we receive when
-                 * we are in PFC mode.
+                 * we are in PFC mode however X540 only honors enabled
+                 * traffic classes.
                 */
                reg = IXGBE_READ_REG(hw, IXGBE_MFLCN);
                reg &= ~IXGBE_MFLCN_RFCE;
                reg |= IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_DPF;
+                if (hw->mac.type == ixgbe_mac_X540)
+                        reg |= pfc_en << IXGBE_MFLCN_RPFCE_SHIFT;
                IXGBE_WRITE_REG(hw, IXGBE_MFLCN, reg);
        } else {
diff --git a/drivers/net/ixgbe/ixgbe_dcb_82599.h b/drivers/net/ixgbe/ixgbe_dcb_82599.h
index 148fd8b477a9..2de71a503153 100644
--- a/drivers/net/ixgbe/ixgbe_dcb_82599.h
+++ b/drivers/net/ixgbe/ixgbe_dcb_82599.h
@@ -92,8 +92,10 @@
 #define IXGBE_RXPBSIZE_64KB     0x00010000 /* 64KB Packet Buffer */
 #define IXGBE_RXPBSIZE_80KB     0x00014000 /* 80KB Packet Buffer */
 #define IXGBE_RXPBSIZE_128KB    0x00020000 /* 128KB Packet Buffer */
+#define IXGBE_TXPBSIZE_MAX      0x00028000 /* 160KB Packet Buffer*/
 #define IXGBE_TXPBTHRESH_DCB    0xA        /* THRESH value for DCB mode */
+#define IXGBE_TXPKT_SIZE_MAX    0xA        /* Max Tx Packet size  */
 /* SECTXMINIFG DCB */
 #define IXGBE_SECTX_DCB         0x00001F00 /* DCB TX Buffer IFG */
diff --git a/drivers/net/ixgbe/ixgbe_dcb_nl.c b/drivers/net/ixgbe/ixgbe_dcb_nl.c
index 327c8614198c..5e7ed225851a 100644
--- a/drivers/net/ixgbe/ixgbe_dcb_nl.c
+++ b/drivers/net/ixgbe/ixgbe_dcb_nl.c
@@ -347,18 +347,28 @@ static void ixgbe_dcbnl_get_pfc_cfg(struct net_device *netdev, int priority,
 static u8 ixgbe_dcbnl_set_all(struct net_device *netdev)
 {
        struct ixgbe_adapter *adapter = netdev_priv(netdev);
+        struct dcb_app app = {
+                              .selector = DCB_APP_IDTYPE_ETHTYPE,
+                              .protocol = ETH_P_FCOE,
+                             };
+        u8 up = dcb_getapp(netdev, &app);
        int ret;
-        if (!adapter->dcb_set_bitmap ||
-            !(adapter->dcbx_cap & DCB_CAP_DCBX_VER_CEE))
-                return DCB_NO_HW_CHG;
        ret = ixgbe_copy_dcb_cfg(&adapter->temp_dcb_cfg, &adapter->dcb_cfg,
                                 MAX_TRAFFIC_CLASS);
        if (ret)
                return DCB_NO_HW_CHG;
+        /* In IEEE mode app data must be parsed into DCBX format for
+         * hardware routines.
+         */
+        if (adapter->dcbx_cap & DCB_CAP_DCBX_VER_IEEE)
+                up = (1 << up);
+#ifdef IXGBE_FCOE
+        if (up && (up != (1 << adapter->fcoe.up)))
+                adapter->dcb_set_bitmap |= BIT_APP_UPCHG;
        /*
         * Only take down the adapter if an app change occurred. FCoE
         * may shuffle tx rings in this case and this can not be done
@@ -366,12 +376,15 @@ static u8 ixgbe_dcbnl_set_all(struct net_device *netdev)
         */
        if (adapter->dcb_set_bitmap & BIT_APP_UPCHG) {
                while (test_and_set_bit(__IXGBE_RESETTING, &adapter->state))
-                        msleep(1);
+                        usleep_range(1000, 2000);
+                ixgbe_fcoe_setapp(adapter, up);
                if (netif_running(netdev))
                        netdev->netdev_ops->ndo_stop(netdev);
                ixgbe_clear_interrupt_scheme(adapter);
        }
+#endif
        if (adapter->dcb_cfg.pfc_mode_enable) {
                switch (adapter->hw.mac.type) {
@@ -399,12 +412,14 @@ static u8 ixgbe_dcbnl_set_all(struct net_device *netdev)
                }
        }
+#ifdef IXGBE_FCOE
        if (adapter->dcb_set_bitmap & BIT_APP_UPCHG) {
                ixgbe_init_interrupt_scheme(adapter);
                if (netif_running(netdev))
                        netdev->netdev_ops->ndo_open(netdev);
                ret = DCB_HW_CHG_RST;
        }
+#endif
        if (adapter->dcb_set_bitmap & BIT_PFC) {
                u8 pfc_en;
@@ -558,68 +573,6 @@ static u8 ixgbe_dcbnl_getapp(struct net_device *netdev, u8 idtype, u16 id)
        return dcb_getapp(netdev, &app);
 }
-/**
- * ixgbe_dcbnl_setapp - set the DCBX application user priority
- * @netdev : the corresponding netdev
- * @idtype : identifies the id as ether type or TCP/UDP port number
- * @id: id is either ether type or TCP/UDP port number
- * @up: the 802.1p user priority bitmap
- *
- * Returns : 0 on success or 1 on error
- */
-static u8 ixgbe_dcbnl_setapp(struct net_device *netdev,
-                             u8 idtype, u16 id, u8 up)
-{
-        struct ixgbe_adapter *adapter = netdev_priv(netdev);
-        u8 rval = 1;
-        struct dcb_app app = {
-                              .selector = idtype,
-                              .protocol = id,
-                              .priority = up
-                             };
-        if (!(adapter->dcbx_cap & DCB_CAP_DCBX_VER_CEE))
-                return rval;
-        rval = dcb_setapp(netdev, &app);
-        switch (idtype) {
-        case DCB_APP_IDTYPE_ETHTYPE:
-#ifdef IXGBE_FCOE
-                if (id == ETH_P_FCOE) {
-                        u8 old_tc;
-                        /* Get current programmed tc */
-                        old_tc = adapter->fcoe.tc;
-                        rval = ixgbe_fcoe_setapp(adapter, up);
-                        if (rval ||
-                           !(adapter->flags & IXGBE_FLAG_DCB_ENABLED) ||
-                           !(adapter->flags & IXGBE_FLAG_FCOE_ENABLED))
-                                break;
-                        /* The FCoE application priority may be changed multiple
-                         * times in quick succession with switches that build up
-                         * TLVs. To avoid creating uneeded device resets this
-                         * checks the actual HW configuration and clears
-                         * BIT_APP_UPCHG if a HW configuration change is not
-                         * need
-                         */
-                        if (old_tc == adapter->fcoe.tc)
-                                adapter->dcb_set_bitmap &= ~BIT_APP_UPCHG;
-                        else
-                                adapter->dcb_set_bitmap |= BIT_APP_UPCHG;
-                }
-#endif
-                break;
-        case DCB_APP_IDTYPE_PORTNUM:
-                break;
-        default:
-                break;
-        }
-        return rval;
-}
 static int ixgbe_dcbnl_ieee_getets(struct net_device *dev,
                                   struct ieee_ets *ets)
 {
@@ -745,25 +698,14 @@ static int ixgbe_dcbnl_ieee_setapp(struct net_device *dev,
        if (!(adapter->dcbx_cap & DCB_CAP_DCBX_VER_IEEE))
                return -EINVAL;
-#ifdef IXGBE_FCOE
-        if (app->selector == 1 && app->protocol == ETH_P_FCOE) {
-                if (adapter->fcoe.tc == app->priority)
-                        goto setapp;
-                /* In IEEE mode map up to tc 1:1 */
+        dcb_setapp(dev, app);
-                adapter->fcoe.tc = app->priority;
-                adapter->fcoe.up = app->priority;
-                /* Force hardware reset required to push FCoE
+#ifdef IXGBE_FCOE
-                 * setup on {tx|rx}_rings
+        if (app->selector == 1 && app->protocol == ETH_P_FCOE &&
-                 */
+            adapter->fcoe.tc == app->priority)
-                adapter->dcb_set_bitmap |= BIT_APP_UPCHG;
                ixgbe_dcbnl_set_all(dev);
-        }
-setapp:
 #endif
-        dcb_setapp(dev, app);
        return 0;
 }
@@ -838,7 +780,6 @@ const struct dcbnl_rtnl_ops dcbnl_ops = {
        .getpfcstate    = ixgbe_dcbnl_getpfcstate,
        .setpfcstate    = ixgbe_dcbnl_setpfcstate,
        .getapp         = ixgbe_dcbnl_getapp,
-        .setapp         = ixgbe_dcbnl_setapp,
        .getdcbx        = ixgbe_dcbnl_getdcbx,
        .setdcbx        = ixgbe_dcbnl_setdcbx,
 };
diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c
index 76380a2b35aa..cb1555bc8548 100644
--- a/drivers/net/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ixgbe/ixgbe_ethtool.c
@@ -84,6 +84,7 @@ static struct ixgbe_stats ixgbe_gstrings_stats[] = {
        {"hw_rsc_flushed", IXGBE_STAT(rsc_total_flush)},
        {"fdir_match", IXGBE_STAT(stats.fdirmatch)},
        {"fdir_miss", IXGBE_STAT(stats.fdirmiss)},
+        {"fdir_overflow", IXGBE_STAT(fdir_overflow)},
        {"rx_fifo_errors", IXGBE_NETDEV_STAT(rx_fifo_errors)},
        {"rx_missed_errors", IXGBE_NETDEV_STAT(rx_missed_errors)},
        {"tx_aborted_errors", IXGBE_NETDEV_STAT(tx_aborted_errors)},
@@ -102,6 +103,10 @@ static struct ixgbe_stats ixgbe_gstrings_stats[] = {
        {"alloc_rx_page_failed", IXGBE_STAT(alloc_rx_page_failed)},
        {"alloc_rx_buff_failed", IXGBE_STAT(alloc_rx_buff_failed)},
        {"rx_no_dma_resources", IXGBE_STAT(hw_rx_no_dma_resources)},
+        {"os2bmc_rx_by_bmc", IXGBE_STAT(stats.o2bgptc)},
+        {"os2bmc_tx_by_bmc", IXGBE_STAT(stats.b2ospc)},
+        {"os2bmc_tx_by_host", IXGBE_STAT(stats.o2bspc)},
+        {"os2bmc_rx_by_host", IXGBE_STAT(stats.b2ogprc)},
 #ifdef IXGBE_FCOE
        {"fcoe_bad_fccrc", IXGBE_STAT(stats.fccrc)},
        {"rx_fcoe_dropped", IXGBE_STAT(stats.fcoerpdc)},
@@ -288,20 +293,20 @@ static int ixgbe_get_settings(struct net_device *netdev,
        if (link_up) {
                switch (link_speed) {
                case IXGBE_LINK_SPEED_10GB_FULL:
-                        ecmd->speed = SPEED_10000;
+                        ethtool_cmd_speed_set(ecmd, SPEED_10000);
                        break;
                case IXGBE_LINK_SPEED_1GB_FULL:
-                        ecmd->speed = SPEED_1000;
+                        ethtool_cmd_speed_set(ecmd, SPEED_1000);
                        break;
                case IXGBE_LINK_SPEED_100_FULL:
-                        ecmd->speed = SPEED_100;
+                        ethtool_cmd_speed_set(ecmd, SPEED_100);
                        break;
                default:
                        break;
                }
                ecmd->duplex = DUPLEX_FULL;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
@@ -346,9 +351,10 @@ static int ixgbe_set_settings(struct net_device *netdev,
                }
        } else {
                /* in this case we currently only support 10Gb/FULL */
+                u32 speed = ethtool_cmd_speed(ecmd);
                if ((ecmd->autoneg == AUTONEG_ENABLE) ||
                    (ecmd->advertising != ADVERTISED_10000baseT_Full) ||
-                    (ecmd->speed + ecmd->duplex != SPEED_10000 + DUPLEX_FULL))
+                    (speed + ecmd->duplex != SPEED_10000 + DUPLEX_FULL))
                        return -EINVAL;
        }
@@ -846,11 +852,8 @@ static int ixgbe_get_eeprom(struct net_device *netdev,
        if (!eeprom_buff)
                return -ENOMEM;
-        for (i = 0; i < eeprom_len; i++) {
+        ret_val = hw->eeprom.ops.read_buffer(hw, first_word, eeprom_len,
-                if ((ret_val = hw->eeprom.ops.read(hw, first_word + i,
+                                             eeprom_buff);
-                    &eeprom_buff[i])))
-                        break;
-        }
        /* Device's eeprom is always little-endian, word addressable */
        for (i = 0; i < eeprom_len; i++)
@@ -931,7 +934,7 @@ static int ixgbe_set_ringparam(struct net_device *netdev,
        }
        while (test_and_set_bit(__IXGBE_RESETTING, &adapter->state))
-                msleep(1);
+                usleep_range(1000, 2000);
        if (!netif_running(adapter->netdev)) {
                for (i = 0; i < adapter->num_tx_queues; i++)
@@ -1030,9 +1033,6 @@ static int ixgbe_get_sset_count(struct net_device *netdev, int sset)
                return IXGBE_TEST_LEN;
        case ETH_SS_STATS:
                return IXGBE_STATS_LEN;
-        case ETH_SS_NTUPLE_FILTERS:
-                return ETHTOOL_MAX_NTUPLE_LIST_ENTRY *
-                       ETHTOOL_MAX_NTUPLE_STRING_PER_ENTRY;
        default:
                return -EOPNOTSUPP;
        }
@@ -1238,46 +1238,62 @@ static const struct ixgbe_reg_test reg_test_82598[] = {
        { 0, 0, 0, 0 }
 };
-static const u32 register_test_patterns[] = {
+static bool reg_pattern_test(struct ixgbe_adapter *adapter, u64 *data, int reg,
-        0x5A5A5A5A, 0xA5A5A5A5, 0x00000000, 0xFFFFFFFF
+                             u32 mask, u32 write)
-};
+{
+        u32 pat, val, before;
-#define REG_PATTERN_TEST(R, M, W)                                             \
+        static const u32 test_pattern[] = {
-{                                                                             \
+                0x5A5A5A5A, 0xA5A5A5A5, 0x00000000, 0xFFFFFFFF};
-        u32 pat, val, before;                                                 \
-        for (pat = 0; pat < ARRAY_SIZE(register_test_patterns); pat++) {      \
+        for (pat = 0; pat < ARRAY_SIZE(test_pattern); pat++) {
-                before = readl(adapter->hw.hw_addr + R);                      \
+                before = readl(adapter->hw.hw_addr + reg);
-                writel((register_test_patterns[pat] & W),                     \
+                writel((test_pattern[pat] & write),
-                       (adapter->hw.hw_addr + R));                            \
+                       (adapter->hw.hw_addr + reg));
-                val = readl(adapter->hw.hw_addr + R);                         \
+                val = readl(adapter->hw.hw_addr + reg);
-                if (val != (register_test_patterns[pat] & W & M)) {           \
+                if (val != (test_pattern[pat] & write & mask)) {
-                        e_err(drv, "pattern test reg %04X failed: got "       \
+                        e_err(drv, "pattern test reg %04X failed: got "
-                              "0x%08X expected 0x%08X\n",                     \
+                              "0x%08X expected 0x%08X\n",
-                              R, val, (register_test_patterns[pat] & W & M)); \
+                              reg, val, (test_pattern[pat] & write & mask));
-                        *data = R;                                            \
+                        *data = reg;
-                        writel(before, adapter->hw.hw_addr + R);              \
+                        writel(before, adapter->hw.hw_addr + reg);
-                        return 1;                                             \
+                        return 1;
-                }                                                             \
+                }
-                writel(before, adapter->hw.hw_addr + R);                      \
+                writel(before, adapter->hw.hw_addr + reg);
-        }                                                                     \
+        }
+        return 0;
 }
-#define REG_SET_AND_CHECK(R, M, W)                                            \
+static bool reg_set_and_check(struct ixgbe_adapter *adapter, u64 *data, int reg,
-{                                                                             \
+                              u32 mask, u32 write)
-        u32 val, before;                                                      \
+{
-        before = readl(adapter->hw.hw_addr + R);                              \
+        u32 val, before;
-        writel((W & M), (adapter->hw.hw_addr + R));                           \
+        before = readl(adapter->hw.hw_addr + reg);
-        val = readl(adapter->hw.hw_addr + R);                                 \
+        writel((write & mask), (adapter->hw.hw_addr + reg));
-        if ((W & M) != (val & M)) {                                           \
+        val = readl(adapter->hw.hw_addr + reg);
-                e_err(drv, "set/check reg %04X test failed: got 0x%08X "  \
+        if ((write & mask) != (val & mask)) {
-                      "expected 0x%08X\n", R, (val & M), (W & M));        \
+                e_err(drv, "set/check reg %04X test failed: got 0x%08X "
-                *data = R;                                                    \
+                      "expected 0x%08X\n", reg, (val & mask), (write & mask));
-                writel(before, (adapter->hw.hw_addr + R));                    \
+                *data = reg;
-                return 1;                                                     \
+                writel(before, (adapter->hw.hw_addr + reg));
-        }                                                                     \
+                return 1;
-        writel(before, (adapter->hw.hw_addr + R));                            \
+        }
+        writel(before, (adapter->hw.hw_addr + reg));
+        return 0;
 }
+#define REG_PATTERN_TEST(reg, mask, write)                                    \
+        do {                                                                  \
+                if (reg_pattern_test(adapter, data, reg, mask, write))        \
+                        return 1;                                             \
+        } while (0)                                                           \
+#define REG_SET_AND_CHECK(reg, mask, write)                                   \
+        do {                                                                  \
+                if (reg_set_and_check(adapter, data, reg, mask, write))       \
+                        return 1;                                             \
+        } while (0)                                                           \
 static int ixgbe_reg_test(struct ixgbe_adapter *adapter, u64 *data)
 {
        const struct ixgbe_reg_test *test;
@@ -1328,13 +1344,13 @@ static int ixgbe_reg_test(struct ixgbe_adapter *adapter, u64 *data)
                        switch (test->test_type) {
                        case PATTERN_TEST:
                                REG_PATTERN_TEST(test->reg + (i * 0x40),
-                                                test->mask,
+                                                 test->mask,
-                                                test->write);
+                                                 test->write);
                                break;
                        case SET_READ_TEST:
                                REG_SET_AND_CHECK(test->reg + (i * 0x40),
-                                                test->mask,
+                                                  test->mask,
-                                                test->write);
+                                                  test->write);
                                break;
                        case WRITE_NO_TEST:
                                writel(test->write,
@@ -1343,18 +1359,18 @@ static int ixgbe_reg_test(struct ixgbe_adapter *adapter, u64 *data)
                                break;
                        case TABLE32_TEST:
                                REG_PATTERN_TEST(test->reg + (i * 4),
-                                                test->mask,
+                                                 test->mask,
-                                                test->write);
+                                                 test->write);
                                break;
                        case TABLE64_TEST_LO:
                                REG_PATTERN_TEST(test->reg + (i * 8),
-                                                test->mask,
+                                                 test->mask,
-                                                test->write);
+                                                 test->write);
                                break;
                        case TABLE64_TEST_HI:
                                REG_PATTERN_TEST((test->reg + 4) + (i * 8),
-                                                test->mask,
+                                                 test->mask,
-                                                test->write);
+                                                 test->write);
                                break;
                        }
                }
@@ -1417,7 +1433,7 @@ static int ixgbe_intr_test(struct ixgbe_adapter *adapter, u64 *data)
        /* Disable all the interrupts */
        IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, 0xFFFFFFFF);
-        msleep(10);
+        usleep_range(10000, 20000);
        /* Test each interrupt */
        for (; i < 10; i++) {
@@ -1437,7 +1453,7 @@ static int ixgbe_intr_test(struct ixgbe_adapter *adapter, u64 *data)
                                        ~mask & 0x00007FFF);
                        IXGBE_WRITE_REG(&adapter->hw, IXGBE_EICS,
                                        ~mask & 0x00007FFF);
-                        msleep(10);
+                        usleep_range(10000, 20000);
                        if (adapter->test_icr & mask) {
                                *data = 3;
@@ -1454,7 +1470,7 @@ static int ixgbe_intr_test(struct ixgbe_adapter *adapter, u64 *data)
                adapter->test_icr = 0;
                IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMS, mask);
                IXGBE_WRITE_REG(&adapter->hw, IXGBE_EICS, mask);
-                msleep(10);
+                usleep_range(10000, 20000);
                if (!(adapter->test_icr &mask)) {
                        *data = 4;
@@ -1474,7 +1490,7 @@ static int ixgbe_intr_test(struct ixgbe_adapter *adapter, u64 *data)
                                        ~mask & 0x00007FFF);
                        IXGBE_WRITE_REG(&adapter->hw, IXGBE_EICS,
                                        ~mask & 0x00007FFF);
-                        msleep(10);
+                        usleep_range(10000, 20000);
                        if (adapter->test_icr) {
                                *data = 5;
@@ -1485,7 +1501,7 @@ static int ixgbe_intr_test(struct ixgbe_adapter *adapter, u64 *data)
        /* Disable all the interrupts */
        IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, 0xFFFFFFFF);
-        msleep(10);
+        usleep_range(10000, 20000);
        /* Unhook test interrupt handler */
        free_irq(irq, netdev);
@@ -1598,6 +1614,13 @@ static int ixgbe_setup_loopback_test(struct ixgbe_adapter *adapter)
        struct ixgbe_hw *hw = &adapter->hw;
        u32 reg_data;
+        /* X540 needs to set the MACC.FLU bit to force link up */
+        if (adapter->hw.mac.type == ixgbe_mac_X540) {
+                reg_data = IXGBE_READ_REG(&adapter->hw, IXGBE_MACC);
+                reg_data |= IXGBE_MACC_FLU;
+                IXGBE_WRITE_REG(&adapter->hw, IXGBE_MACC, reg_data);
+        }
        /* right now we only support MAC loopback in the driver */
        reg_data = IXGBE_READ_REG(&adapter->hw, IXGBE_HLREG0);
        /* Setup MAC loopback */
@@ -1613,7 +1636,7 @@ static int ixgbe_setup_loopback_test(struct ixgbe_adapter *adapter)
        reg_data |= IXGBE_AUTOC_LMS_10G_LINK_NO_AN | IXGBE_AUTOC_FLU;
        IXGBE_WRITE_REG(&adapter->hw, IXGBE_AUTOC, reg_data);
        IXGBE_WRITE_FLUSH(&adapter->hw);
-        msleep(10);
+        usleep_range(10000, 20000);
        /* Disable Atlas Tx lanes; re-enabled in reset path */
        if (hw->mac.type == ixgbe_mac_82598EB) {
@@ -1999,25 +2022,30 @@ static int ixgbe_nway_reset(struct net_device *netdev)
        return 0;
 }
-static int ixgbe_phys_id(struct net_device *netdev, u32 data)
+static int ixgbe_set_phys_id(struct net_device *netdev,
+                             enum ethtool_phys_id_state state)
 {
        struct ixgbe_adapter *adapter = netdev_priv(netdev);
        struct ixgbe_hw *hw = &adapter->hw;
-        u32 led_reg = IXGBE_READ_REG(hw, IXGBE_LEDCTL);
-        u32 i;
-        if (!data || data > 300)
+        switch (state) {
-                data = 300;
+        case ETHTOOL_ID_ACTIVE:
+                adapter->led_reg = IXGBE_READ_REG(hw, IXGBE_LEDCTL);
+                return 2;
-        for (i = 0; i < (data * 1000); i += 400) {
+        case ETHTOOL_ID_ON:
                hw->mac.ops.led_on(hw, IXGBE_LED_ON);
-                msleep_interruptible(200);
+                break;
+        case ETHTOOL_ID_OFF:
                hw->mac.ops.led_off(hw, IXGBE_LED_ON);
-                msleep_interruptible(200);
+                break;
-        }
-        /* Restore LED settings */
+        case ETHTOOL_ID_INACTIVE:
-        IXGBE_WRITE_REG(&adapter->hw, IXGBE_LEDCTL, led_reg);
+                /* Restore LED settings */
+                IXGBE_WRITE_REG(&adapter->hw, IXGBE_LEDCTL, adapter->led_reg);
+                break;
+        }
        return 0;
 }
@@ -2230,8 +2258,13 @@ static int ixgbe_set_flags(struct net_device *netdev, u32 data)
        need_reset = (data & ETH_FLAG_RXVLAN) !=
                     (netdev->features & NETIF_F_HW_VLAN_RX);
+        if ((data & ETH_FLAG_RXHASH) &&
+            !(adapter->flags & IXGBE_FLAG_RSS_ENABLED))
+                return -EOPNOTSUPP;
        rc = ethtool_op_set_flags(netdev, data, ETH_FLAG_LRO | ETH_FLAG_NTUPLE |
-                                        ETH_FLAG_RXVLAN | ETH_FLAG_TXVLAN);
+                                  ETH_FLAG_RXVLAN | ETH_FLAG_TXVLAN |
+                                  ETH_FLAG_RXHASH);
        if (rc)
                return rc;
@@ -2465,7 +2498,7 @@ static const struct ethtool_ops ixgbe_ethtool_ops = {
        .set_tso                = ixgbe_set_tso,
        .self_test              = ixgbe_diag_test,
        .get_strings            = ixgbe_get_strings,
-        .phys_id                = ixgbe_phys_id,
+        .set_phys_id            = ixgbe_set_phys_id,
        .get_sset_count         = ixgbe_get_sset_count,
        .get_ethtool_stats      = ixgbe_get_ethtool_stats,
        .get_coalesce           = ixgbe_get_coalesce,
diff --git a/drivers/net/ixgbe/ixgbe_fcoe.c b/drivers/net/ixgbe/ixgbe_fcoe.c
index dba7d77588ef..05920726e824 100644
--- a/drivers/net/ixgbe/ixgbe_fcoe.c
+++ b/drivers/net/ixgbe/ixgbe_fcoe.c
@@ -416,8 +416,7 @@ int ixgbe_fcoe_ddp(struct ixgbe_adapter *adapter,
        if (!ddp->udl)
                goto ddp_out;
-        ddp->err = (fcerr | fceofe);
+        if (fcerr | fceofe)
-        if (ddp->err)
                goto ddp_out;
        fcstat = (sterr & IXGBE_RXDADV_STAT_FCSTAT);
@@ -428,6 +427,7 @@ int ixgbe_fcoe_ddp(struct ixgbe_adapter *adapter,
                if (fcstat == IXGBE_RXDADV_STAT_FCSTAT_FCPRSP) {
                        pci_unmap_sg(adapter->pdev, ddp->sgl,
                                     ddp->sgc, DMA_FROM_DEVICE);
+                        ddp->err = (fcerr | fceofe);
                        ddp->sgl = NULL;
                        ddp->sgc = 0;
                }
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index e145f2c455cb..fa01b0b03b77 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -51,8 +51,12 @@
 char ixgbe_driver_name[] = "ixgbe";
 static const char ixgbe_driver_string[] =
                              "Intel(R) 10 Gigabit PCI Express Network Driver";
+#define MAJ 3
-#define DRV_VERSION "3.2.9-k2"
+#define MIN 3
+#define BUILD 8
+#define KFIX 2
+#define DRV_VERSION __stringify(MAJ) "." __stringify(MIN) "." \
+        __stringify(BUILD) "-k" __stringify(KFIX)
 const char ixgbe_driver_version[] = DRV_VERSION;
 static const char ixgbe_copyright[] =
                                "Copyright (c) 1999-2011 Intel Corporation.";
@@ -120,6 +124,10 @@ static DEFINE_PCI_DEVICE_TABLE(ixgbe_pci_tbl) = {
         board_82599 },
        {PCI_VDEVICE(INTEL, IXGBE_DEV_ID_X540T),
         board_X540 },
+        {PCI_VDEVICE(INTEL, IXGBE_DEV_ID_82599_SFP_SF2),
+         board_82599 },
+        {PCI_VDEVICE(INTEL, IXGBE_DEV_ID_82599_LS),
+         board_82599 },
        /* required last entry */
        {0, }
@@ -185,6 +193,22 @@ static inline void ixgbe_disable_sriov(struct ixgbe_adapter *adapter)
        adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED;
 }
+static void ixgbe_service_event_schedule(struct ixgbe_adapter *adapter)
+{
+        if (!test_bit(__IXGBE_DOWN, &adapter->state) &&
+            !test_and_set_bit(__IXGBE_SERVICE_SCHED, &adapter->state))
+                schedule_work(&adapter->service_task);
+}
+static void ixgbe_service_event_complete(struct ixgbe_adapter *adapter)
+{
+        BUG_ON(!test_bit(__IXGBE_SERVICE_SCHED, &adapter->state));
+        /* flush memory to make sure state is correct before next watchog */
+        smp_mb__before_clear_bit();
+        clear_bit(__IXGBE_SERVICE_SCHED, &adapter->state);
+}
 struct ixgbe_reg_info {
        u32 ofs;
        char *name;
@@ -811,7 +835,19 @@ static inline bool ixgbe_check_tx_hang(struct ixgbe_ring *tx_ring)
 #define DESC_NEEDED (TXD_USE_COUNT(IXGBE_MAX_DATA_PER_TXD) /* skb->data */ + \
        MAX_SKB_FRAGS * TXD_USE_COUNT(PAGE_SIZE) + 1) /* for context */
-static void ixgbe_tx_timeout(struct net_device *netdev);
+/**
+ * ixgbe_tx_timeout_reset - initiate reset due to Tx timeout
+ * @adapter: driver private struct
+ **/
+static void ixgbe_tx_timeout_reset(struct ixgbe_adapter *adapter)
+{
+        /* Do the reset outside of interrupt context */
+        if (!test_bit(__IXGBE_DOWN, &adapter->state)) {
+                adapter->flags2 |= IXGBE_FLAG2_RESET_REQUESTED;
+                ixgbe_service_event_schedule(adapter);
+        }
+}
 /**
 * ixgbe_clean_tx_irq - Reclaim resources after transmit completes
@@ -893,7 +929,7 @@ static bool ixgbe_clean_tx_irq(struct ixgbe_q_vector *q_vector,
                        adapter->tx_timeout_count + 1, tx_ring->queue_index);
                /* schedule immediate reset if we believe we hung */
-                ixgbe_tx_timeout(adapter->netdev);
+                ixgbe_tx_timeout_reset(adapter);
                /* the adapter is about to reset, no point in enabling stuff */
                return true;
@@ -943,8 +979,6 @@ static void ixgbe_update_rx_dca(struct ixgbe_adapter *adapter,
        rxctrl |= IXGBE_DCA_RXCTRL_DESC_DCA_EN;
        rxctrl |= IXGBE_DCA_RXCTRL_HEAD_DCA_EN;
        rxctrl &= ~(IXGBE_DCA_RXCTRL_DESC_RRO_EN);
-        rxctrl &= ~(IXGBE_DCA_RXCTRL_DESC_WRO_EN |
-                    IXGBE_DCA_RXCTRL_DESC_HSRO_EN);
        IXGBE_WRITE_REG(hw, IXGBE_DCA_RXCTRL(reg_idx), rxctrl);
 }
@@ -962,7 +996,6 @@ static void ixgbe_update_tx_dca(struct ixgbe_adapter *adapter,
                txctrl &= ~IXGBE_DCA_TXCTRL_CPUID_MASK;
                txctrl |= dca3_get_tag(&adapter->pdev->dev, cpu);
                txctrl |= IXGBE_DCA_TXCTRL_DESC_DCA_EN;
-                txctrl &= ~IXGBE_DCA_TXCTRL_TX_WB_RO_EN;
                IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL(reg_idx), txctrl);
                break;
        case ixgbe_mac_82599EB:
@@ -972,7 +1005,6 @@ static void ixgbe_update_tx_dca(struct ixgbe_adapter *adapter,
                txctrl |= (dca3_get_tag(&adapter->pdev->dev, cpu) <<
                           IXGBE_DCA_TXCTRL_CPUID_SHIFT_82599);
                txctrl |= IXGBE_DCA_TXCTRL_DESC_DCA_EN;
-                txctrl &= ~IXGBE_DCA_TXCTRL_TX_WB_RO_EN;
                IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL_82599(reg_idx), txctrl);
                break;
        default:
@@ -1061,8 +1093,14 @@ static int __ixgbe_notify_dca(struct device *dev, void *data)
        return 0;
 }
 #endif /* CONFIG_IXGBE_DCA */
+static inline void ixgbe_rx_hash(union ixgbe_adv_rx_desc *rx_desc,
+                                 struct sk_buff *skb)
+{
+        skb->rxhash = le32_to_cpu(rx_desc->wb.lower.hi_dword.rss);
+}
 /**
 * ixgbe_receive_skb - Send a completed packet up the stack
 * @adapter: board private structure
@@ -1454,6 +1492,8 @@ static void ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector,
                }
                ixgbe_rx_checksum(adapter, rx_desc, skb);
+                if (adapter->netdev->features & NETIF_F_RXHASH)
+                        ixgbe_rx_hash(rx_desc, skb);
                /* probably a little skewed due to removing CRC */
                total_rx_bytes += skb->len;
@@ -1787,35 +1827,51 @@ static void ixgbe_set_itr_msix(struct ixgbe_q_vector *q_vector)
 }
 /**
- * ixgbe_check_overtemp_task - worker thread to check over tempurature
+ * ixgbe_check_overtemp_subtask - check for over tempurature
- * @work: pointer to work_struct containing our data
+ * @adapter: pointer to adapter
 **/
-static void ixgbe_check_overtemp_task(struct work_struct *work)
+static void ixgbe_check_overtemp_subtask(struct ixgbe_adapter *adapter)
 {
-        struct ixgbe_adapter *adapter = container_of(work,
-                                                     struct ixgbe_adapter,
-                                                     check_overtemp_task);
        struct ixgbe_hw *hw = &adapter->hw;
        u32 eicr = adapter->interrupt_event;
-        if (!(adapter->flags2 & IXGBE_FLAG2_TEMP_SENSOR_CAPABLE))
+        if (test_bit(__IXGBE_DOWN, &adapter->state))
                return;
+        if (!(adapter->flags2 & IXGBE_FLAG2_TEMP_SENSOR_CAPABLE) &&
+            !(adapter->flags2 & IXGBE_FLAG2_TEMP_SENSOR_EVENT))
+                return;
+        adapter->flags2 &= ~IXGBE_FLAG2_TEMP_SENSOR_EVENT;
        switch (hw->device_id) {
-        case IXGBE_DEV_ID_82599_T3_LOM: {
+        case IXGBE_DEV_ID_82599_T3_LOM:
-                u32 autoneg;
+                /*
-                bool link_up = false;
+                 * Since the warning interrupt is for both ports
+                 * we don't have to check if:
+                 *  - This interrupt wasn't for our port.
+                 *  - We may have missed the interrupt so always have to
+                 *    check if we  got a LSC
+                 */
+                if (!(eicr & IXGBE_EICR_GPI_SDP0) &&
+                    !(eicr & IXGBE_EICR_LSC))
+                        return;
+                if (!(eicr & IXGBE_EICR_LSC) && hw->mac.ops.check_link) {
+                        u32 autoneg;
+                        bool link_up = false;
-                if (hw->mac.ops.check_link)
                        hw->mac.ops.check_link(hw, &autoneg, &link_up, false);
-                if (((eicr & IXGBE_EICR_GPI_SDP0) && (!link_up)) ||
+                        if (link_up)
-                    (eicr & IXGBE_EICR_LSC))
+                                return;
-                        /* Check if this is due to overtemp */
+                }
-                        if (hw->phy.ops.check_overtemp(hw) == IXGBE_ERR_OVERTEMP)
-                                break;
+                /* Check if this is not due to overtemp */
-                return;
+                if (hw->phy.ops.check_overtemp(hw) != IXGBE_ERR_OVERTEMP)
-        }
+                        return;
+                break;
        default:
                if (!(eicr & IXGBE_EICR_GPI_SDP0))
                        return;
@@ -1825,8 +1881,8 @@ static void ixgbe_check_overtemp_task(struct work_struct *work)
               "Network adapter has been stopped because it has over heated. "
               "Restart the computer. If the problem persists, "
               "power off the system and replace the adapter\n");
-        /* write to clear the interrupt */
-        IXGBE_WRITE_REG(hw, IXGBE_EICR, IXGBE_EICR_GPI_SDP0);
+        adapter->interrupt_event = 0;
 }
 static void ixgbe_check_fan_failure(struct ixgbe_adapter *adapter, u32 eicr)
@@ -1848,15 +1904,19 @@ static void ixgbe_check_sfp_event(struct ixgbe_adapter *adapter, u32 eicr)
        if (eicr & IXGBE_EICR_GPI_SDP2) {
                /* Clear the interrupt */
                IXGBE_WRITE_REG(hw, IXGBE_EICR, IXGBE_EICR_GPI_SDP2);
-                if (!test_bit(__IXGBE_DOWN, &adapter->state))
+                if (!test_bit(__IXGBE_DOWN, &adapter->state)) {
-                        schedule_work(&adapter->sfp_config_module_task);
+                        adapter->flags2 |= IXGBE_FLAG2_SFP_NEEDS_RESET;
+                        ixgbe_service_event_schedule(adapter);
+                }
        }
        if (eicr & IXGBE_EICR_GPI_SDP1) {
                /* Clear the interrupt */
                IXGBE_WRITE_REG(hw, IXGBE_EICR, IXGBE_EICR_GPI_SDP1);
-                if (!test_bit(__IXGBE_DOWN, &adapter->state))
+                if (!test_bit(__IXGBE_DOWN, &adapter->state)) {
-                        schedule_work(&adapter->multispeed_fiber_task);
+                        adapter->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
+                        ixgbe_service_event_schedule(adapter);
+                }
        }
 }
@@ -1870,7 +1930,7 @@ static void ixgbe_check_lsc(struct ixgbe_adapter *adapter)
        if (!test_bit(__IXGBE_DOWN, &adapter->state)) {
                IXGBE_WRITE_REG(hw, IXGBE_EIMC, IXGBE_EIMC_LSC);
                IXGBE_WRITE_FLUSH(hw);
-                schedule_work(&adapter->watchdog_task);
+                ixgbe_service_event_schedule(adapter);
        }
 }
@@ -1898,26 +1958,32 @@ static irqreturn_t ixgbe_msix_lsc(int irq, void *data)
        switch (hw->mac.type) {
        case ixgbe_mac_82599EB:
-                ixgbe_check_sfp_event(adapter, eicr);
-                if ((adapter->flags2 & IXGBE_FLAG2_TEMP_SENSOR_CAPABLE) &&
-                    ((eicr & IXGBE_EICR_GPI_SDP0) || (eicr & IXGBE_EICR_LSC))) {
-                        adapter->interrupt_event = eicr;
-                        schedule_work(&adapter->check_overtemp_task);
-                }
-                /* now fallthrough to handle Flow Director */
        case ixgbe_mac_X540:
                /* Handle Flow Director Full threshold interrupt */
                if (eicr & IXGBE_EICR_FLOW_DIR) {
+                        int reinit_count = 0;
                        int i;
-                        IXGBE_WRITE_REG(hw, IXGBE_EICR, IXGBE_EICR_FLOW_DIR);
-                        /* Disable transmits before FDIR Re-initialization */
-                        netif_tx_stop_all_queues(netdev);
                        for (i = 0; i < adapter->num_tx_queues; i++) {
-                                struct ixgbe_ring *tx_ring =
+                                struct ixgbe_ring *ring = adapter->tx_ring[i];
-                                                            adapter->tx_ring[i];
                                if (test_and_clear_bit(__IXGBE_TX_FDIR_INIT_DONE,
-                                                       &tx_ring->state))
+                                                       &ring->state))
-                                        schedule_work(&adapter->fdir_reinit_task);
+                                        reinit_count++;
+                        }
+                        if (reinit_count) {
+                                /* no more flow director interrupts until after init */
+                                IXGBE_WRITE_REG(hw, IXGBE_EIMC, IXGBE_EIMC_FLOW_DIR);
+                                eicr &= ~IXGBE_EICR_FLOW_DIR;
+                                adapter->flags2 |= IXGBE_FLAG2_FDIR_REQUIRES_REINIT;
+                                ixgbe_service_event_schedule(adapter);
+                        }
+                }
+                ixgbe_check_sfp_event(adapter, eicr);
+                if ((adapter->flags2 & IXGBE_FLAG2_TEMP_SENSOR_CAPABLE) &&
+                    ((eicr & IXGBE_EICR_GPI_SDP0) || (eicr & IXGBE_EICR_LSC))) {
+                        if (!test_bit(__IXGBE_DOWN, &adapter->state)) {
+                                adapter->interrupt_event = eicr;
+                                adapter->flags2 |= IXGBE_FLAG2_TEMP_SENSOR_EVENT;
+                                ixgbe_service_event_schedule(adapter);
                        }
                }
                break;
@@ -1927,8 +1993,10 @@ static irqreturn_t ixgbe_msix_lsc(int irq, void *data)
        ixgbe_check_fan_failure(adapter, eicr);
+        /* re-enable the original interrupt state, no lsc, no queues */
        if (!test_bit(__IXGBE_DOWN, &adapter->state))
-                IXGBE_WRITE_REG(hw, IXGBE_EIMS, IXGBE_EIMS_OTHER);
+                IXGBE_WRITE_REG(hw, IXGBE_EIMS, eicr &
+                                ~(IXGBE_EIMS_LSC | IXGBE_EIMS_RTX_QUEUE));
        return IRQ_HANDLED;
 }
@@ -2513,8 +2581,11 @@ static irqreturn_t ixgbe_intr(int irq, void *data)
                ixgbe_check_sfp_event(adapter, eicr);
                if ((adapter->flags2 & IXGBE_FLAG2_TEMP_SENSOR_CAPABLE) &&
                    ((eicr & IXGBE_EICR_GPI_SDP0) || (eicr & IXGBE_EICR_LSC))) {
-                        adapter->interrupt_event = eicr;
+                        if (!test_bit(__IXGBE_DOWN, &adapter->state)) {
-                        schedule_work(&adapter->check_overtemp_task);
+                                adapter->interrupt_event = eicr;
+                                adapter->flags2 |= IXGBE_FLAG2_TEMP_SENSOR_EVENT;
+                                ixgbe_service_event_schedule(adapter);
+                        }
                }
                break;
        default:
@@ -2731,7 +2802,7 @@ void ixgbe_configure_tx_ring(struct ixgbe_adapter *adapter,
        /* poll to verify queue is enabled */
        do {
-                msleep(1);
+                usleep_range(1000, 2000);
                txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(reg_idx));
        } while (--wait_loop && !(txdctl & IXGBE_TXDCTL_ENABLE));
        if (!wait_loop)
@@ -3023,7 +3094,7 @@ static void ixgbe_rx_desc_queue_enable(struct ixgbe_adapter *adapter,
                return;
        do {
-                msleep(1);
+                usleep_range(1000, 2000);
                rxdctl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(reg_idx));
        } while (--wait_loop && !(rxdctl & IXGBE_RXDCTL_ENABLE));
@@ -3178,7 +3249,9 @@ static void ixgbe_configure_virtualization(struct ixgbe_adapter *adapter)
        /* enable Tx loopback for VF/PF communication */
        IXGBE_WRITE_REG(hw, IXGBE_PFDTXGSWC, IXGBE_PFDTXGSWC_VT_LBEN);
        /* Enable MAC Anti-Spoofing */
-        hw->mac.ops.set_mac_anti_spoofing(hw, (adapter->num_vfs != 0),
+        hw->mac.ops.set_mac_anti_spoofing(hw,
+                                          (adapter->antispoofing_enabled =
+                                           (adapter->num_vfs != 0)),
                                          adapter->num_vfs);
 }
@@ -3487,7 +3560,7 @@ static int ixgbe_write_uc_addr_list(struct net_device *netdev)
        struct ixgbe_adapter *adapter = netdev_priv(netdev);
        struct ixgbe_hw *hw = &adapter->hw;
        unsigned int vfn = adapter->num_vfs;
-        unsigned int rar_entries = hw->mac.num_rar_entries - (vfn + 1);
+        unsigned int rar_entries = IXGBE_MAX_PF_MACVLANS;
        int count = 0;
        /* return ENOMEM indicating insufficient memory for addresses */
@@ -3760,31 +3833,16 @@ static inline bool ixgbe_is_sfp(struct ixgbe_hw *hw)
 **/
 static void ixgbe_sfp_link_config(struct ixgbe_adapter *adapter)
 {
-        struct ixgbe_hw *hw = &adapter->hw;
+        /*
+         * We are assuming the worst case scenerio here, and that
+         * is that an SFP was inserted/removed after the reset
+         * but before SFP detection was enabled.  As such the best
+         * solution is to just start searching as soon as we start
+         */
+        if (adapter->hw.mac.type == ixgbe_mac_82598EB)
+                adapter->flags2 |= IXGBE_FLAG2_SEARCH_FOR_SFP;
-                if (hw->phy.multispeed_fiber) {
+        adapter->flags2 |= IXGBE_FLAG2_SFP_NEEDS_RESET;
-                        /*
-                         * In multispeed fiber setups, the device may not have
-                         * had a physical connection when the driver loaded.
-                         * If that's the case, the initial link configuration
-                         * couldn't get the MAC into 10G or 1G mode, so we'll
-                         * never have a link status change interrupt fire.
-                         * We need to try and force an autonegotiation
-                         * session, then bring up link.
-                         */
-                        if (hw->mac.ops.setup_sfp)
-                                hw->mac.ops.setup_sfp(hw);
-                        if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
-                                schedule_work(&adapter->multispeed_fiber_task);
-                } else {
-                        /*
-                         * Direct Attach Cu and non-multispeed fiber modules
-                         * still need to be configured properly prior to
-                         * attempting link.
-                         */
-                        if (!(adapter->flags & IXGBE_FLAG_IN_SFP_MOD_TASK))
-                                schedule_work(&adapter->sfp_config_module_task);
-                }
 }
 /**
@@ -3860,9 +3918,10 @@ static void ixgbe_setup_gpie(struct ixgbe_adapter *adapter)
        if (adapter->flags & IXGBE_FLAG_FAN_FAIL_CAPABLE)
                gpie |= IXGBE_SDP1_GPIEN;
-        if (hw->mac.type == ixgbe_mac_82599EB)
+        if (hw->mac.type == ixgbe_mac_82599EB) {
                gpie |= IXGBE_SDP1_GPIEN;
                gpie |= IXGBE_SDP2_GPIEN;
+        }
        IXGBE_WRITE_REG(hw, IXGBE_GPIE, gpie);
 }
@@ -3913,17 +3972,6 @@ static int ixgbe_up_complete(struct ixgbe_adapter *adapter)
                        e_crit(drv, "Fan has stopped, replace the adapter\n");
        }
-        /*
-         * For hot-pluggable SFP+ devices, a new SFP+ module may have
-         * arrived before interrupts were enabled but after probe.  Such
-         * devices wouldn't have their type identified yet. We need to
-         * kick off the SFP+ module setup first, then try to bring up link.
-         * If we're not hot-pluggable SFP+, we just need to configure link
-         * and bring it up.
-         */
-        if (hw->phy.type == ixgbe_phy_none)
-                schedule_work(&adapter->sfp_config_module_task);
        /* enable transmits */
        netif_tx_start_all_queues(adapter->netdev);
@@ -3931,7 +3979,7 @@ static int ixgbe_up_complete(struct ixgbe_adapter *adapter)
         * link up interrupt but shouldn't be a problem */
        adapter->flags |= IXGBE_FLAG_NEED_LINK_UPDATE;
        adapter->link_check_timeout = jiffies;
-        mod_timer(&adapter->watchdog_timer, jiffies);
+        mod_timer(&adapter->service_timer, jiffies);
        /* Set PF Reset Done bit so PF/VF Mail Ops can work */
        ctrl_ext = IXGBE_READ_REG(hw, IXGBE_CTRL_EXT);
@@ -3944,8 +3992,11 @@ static int ixgbe_up_complete(struct ixgbe_adapter *adapter)
 void ixgbe_reinit_locked(struct ixgbe_adapter *adapter)
 {
        WARN_ON(in_interrupt());
+        /* put off any impending NetWatchDogTimeout */
+        adapter->netdev->trans_start = jiffies;
        while (test_and_set_bit(__IXGBE_RESETTING, &adapter->state))
-                msleep(1);
+                usleep_range(1000, 2000);
        ixgbe_down(adapter);
        /*
         * If SR-IOV enabled then wait a bit before bringing the adapter
@@ -3972,10 +4023,20 @@ void ixgbe_reset(struct ixgbe_adapter *adapter)
        struct ixgbe_hw *hw = &adapter->hw;
        int err;
+        /* lock SFP init bit to prevent race conditions with the watchdog */
+        while (test_and_set_bit(__IXGBE_IN_SFP_INIT, &adapter->state))
+                usleep_range(1000, 2000);
+        /* clear all SFP and link config related flags while holding SFP_INIT */
+        adapter->flags2 &= ~(IXGBE_FLAG2_SEARCH_FOR_SFP |
+                             IXGBE_FLAG2_SFP_NEEDS_RESET);
+        adapter->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;
        err = hw->mac.ops.init_hw(hw);
        switch (err) {
        case 0:
        case IXGBE_ERR_SFP_NOT_PRESENT:
+        case IXGBE_ERR_SFP_NOT_SUPPORTED:
                break;
        case IXGBE_ERR_MASTER_REQUESTS_PENDING:
                e_dev_err("master disable timed out\n");
@@ -3993,6 +4054,8 @@ void ixgbe_reset(struct ixgbe_adapter *adapter)
                e_dev_err("Hardware Error: %d\n", err);
        }
+        clear_bit(__IXGBE_IN_SFP_INIT, &adapter->state);
        /* reprogram the RAR[0] in case user changed it. */
        hw->mac.ops.set_rar(hw, 0, hw->mac.addr, adapter->num_vfs,
                            IXGBE_RAH_AV);
@@ -4121,26 +4184,12 @@ void ixgbe_down(struct ixgbe_adapter *adapter)
        struct net_device *netdev = adapter->netdev;
        struct ixgbe_hw *hw = &adapter->hw;
        u32 rxctrl;
-        u32 txdctl;
        int i;
        int num_q_vectors = adapter->num_msix_vectors - NON_Q_VECTORS;
        /* signal that we are down to the interrupt handler */
        set_bit(__IXGBE_DOWN, &adapter->state);
-        /* disable receive for all VFs and wait one second */
-        if (adapter->num_vfs) {
-                /* ping all the active vfs to let them know we are going down */
-                ixgbe_ping_all_vfs(adapter);
-                /* Disable all VFTE/VFRE TX/RX */
-                ixgbe_disable_tx_rx(adapter);
-                /* Mark all the VFs as inactive */
-                for (i = 0 ; i < adapter->num_vfs; i++)
-                        adapter->vfinfo[i].clear_to_send = 0;
-        }
        /* disable receives */
        rxctrl = IXGBE_READ_REG(hw, IXGBE_RXCTRL);
        IXGBE_WRITE_REG(hw, IXGBE_RXCTRL, rxctrl & ~IXGBE_RXCTRL_RXEN);
@@ -4150,15 +4199,11 @@ void ixgbe_down(struct ixgbe_adapter *adapter)
                /* this call also flushes the previous write */
                ixgbe_disable_rx_queue(adapter, adapter->rx_ring[i]);
-        msleep(10);
+        usleep_range(10000, 20000);
        netif_tx_stop_all_queues(netdev);
-        clear_bit(__IXGBE_SFP_MODULE_NOT_FOUND, &adapter->state);
+        /* call carrier off first to avoid false dev_watchdog timeouts */
-        del_timer_sync(&adapter->sfp_timer);
-        del_timer_sync(&adapter->watchdog_timer);
-        cancel_work_sync(&adapter->watchdog_task);
        netif_carrier_off(netdev);
        netif_tx_disable(netdev);
@@ -4166,6 +4211,25 @@ void ixgbe_down(struct ixgbe_adapter *adapter)
        ixgbe_napi_disable_all(adapter);
+        adapter->flags2 &= ~(IXGBE_FLAG2_FDIR_REQUIRES_REINIT |
+                             IXGBE_FLAG2_RESET_REQUESTED);
+        adapter->flags &= ~IXGBE_FLAG_NEED_LINK_UPDATE;
+        del_timer_sync(&adapter->service_timer);
+        /* disable receive for all VFs and wait one second */
+        if (adapter->num_vfs) {
+                /* ping all the active vfs to let them know we are going down */
+                ixgbe_ping_all_vfs(adapter);
+                /* Disable all VFTE/VFRE TX/RX */
+                ixgbe_disable_tx_rx(adapter);
+                /* Mark all the VFs as inactive */
+                for (i = 0 ; i < adapter->num_vfs; i++)
+                        adapter->vfinfo[i].clear_to_send = 0;
+        }
        /* Cleanup the affinity_hint CPU mask memory and callback */
        for (i = 0; i < num_q_vectors; i++) {
                struct ixgbe_q_vector *q_vector = adapter->q_vector[i];
@@ -4175,21 +4239,13 @@ void ixgbe_down(struct ixgbe_adapter *adapter)
                free_cpumask_var(q_vector->affinity_mask);
        }
-        if (adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE ||
-            adapter->flags & IXGBE_FLAG_FDIR_PERFECT_CAPABLE)
-                cancel_work_sync(&adapter->fdir_reinit_task);
-        if (adapter->flags2 & IXGBE_FLAG2_TEMP_SENSOR_CAPABLE)
-                cancel_work_sync(&adapter->check_overtemp_task);
        /* disable transmits in the hardware now that interrupts are off */
        for (i = 0; i < adapter->num_tx_queues; i++) {
                u8 reg_idx = adapter->tx_ring[i]->reg_idx;
-                txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(reg_idx));
+                IXGBE_WRITE_REG(hw, IXGBE_TXDCTL(reg_idx), IXGBE_TXDCTL_SWFLSH);
-                IXGBE_WRITE_REG(hw, IXGBE_TXDCTL(reg_idx),
-                                (txdctl & ~IXGBE_TXDCTL_ENABLE));
        }
-        /* Disable the Tx DMA engine on 82599 */
+        /* Disable the Tx DMA engine on 82599 and X540 */
        switch (hw->mac.type) {
        case ixgbe_mac_82599EB:
        case ixgbe_mac_X540:
@@ -4201,9 +4257,6 @@ void ixgbe_down(struct ixgbe_adapter *adapter)
                break;
        }
-        /* clear n-tuple filters that are cached */
-        ethtool_ntuple_flush(netdev);
        if (!pci_channel_offline(adapter->pdev))
                ixgbe_reset(adapter);
@@ -4267,25 +4320,8 @@ static void ixgbe_tx_timeout(struct net_device *netdev)
 {
        struct ixgbe_adapter *adapter = netdev_priv(netdev);
-        adapter->tx_timeout_count++;
        /* Do the reset outside of interrupt context */
-        schedule_work(&adapter->reset_task);
+        ixgbe_tx_timeout_reset(adapter);
-}
-static void ixgbe_reset_task(struct work_struct *work)
-{
-        struct ixgbe_adapter *adapter;
-        adapter = container_of(work, struct ixgbe_adapter, reset_task);
-        /* If we're already down or resetting, just bail */
-        if (test_bit(__IXGBE_DOWN, &adapter->state) ||
-            test_bit(__IXGBE_RESETTING, &adapter->state))
-                return;
-        ixgbe_dump(adapter);
-        netdev_err(adapter->netdev, "Reset adapter\n");
-        ixgbe_reinit_locked(adapter);
 }
 /**
@@ -4567,8 +4603,8 @@ static inline bool ixgbe_cache_ring_rss(struct ixgbe_adapter *adapter)
 #ifdef CONFIG_IXGBE_DCB
 /* ixgbe_get_first_reg_idx - Return first register index associated with ring */
-void ixgbe_get_first_reg_idx(struct ixgbe_adapter *adapter, u8 tc,
+static void ixgbe_get_first_reg_idx(struct ixgbe_adapter *adapter, u8 tc,
-                             unsigned int *tx, unsigned int *rx)
+                                    unsigned int *tx, unsigned int *rx)
 {
        struct net_device *dev = adapter->netdev;
        struct ixgbe_hw *hw = &adapter->hw;
@@ -5133,57 +5169,6 @@ void ixgbe_clear_interrupt_scheme(struct ixgbe_adapter *adapter)
 }
 /**
- * ixgbe_sfp_timer - worker thread to find a missing module
- * @data: pointer to our adapter struct
- **/
-static void ixgbe_sfp_timer(unsigned long data)
-{
-        struct ixgbe_adapter *adapter = (struct ixgbe_adapter *)data;
-        /*
-         * Do the sfp_timer outside of interrupt context due to the
-         * delays that sfp+ detection requires
-         */
-        schedule_work(&adapter->sfp_task);
-}
-/**
- * ixgbe_sfp_task - worker thread to find a missing module
- * @work: pointer to work_struct containing our data
- **/
-static void ixgbe_sfp_task(struct work_struct *work)
-{
-        struct ixgbe_adapter *adapter = container_of(work,
-                                                     struct ixgbe_adapter,
-                                                     sfp_task);
-        struct ixgbe_hw *hw = &adapter->hw;
-        if ((hw->phy.type == ixgbe_phy_nl) &&
-            (hw->phy.sfp_type == ixgbe_sfp_type_not_present)) {
-                s32 ret = hw->phy.ops.identify_sfp(hw);
-                if (ret == IXGBE_ERR_SFP_NOT_PRESENT)
-                        goto reschedule;
-                ret = hw->phy.ops.reset(hw);
-                if (ret == IXGBE_ERR_SFP_NOT_SUPPORTED) {
-                        e_dev_err("failed to initialize because an unsupported "
-                                  "SFP+ module type was detected.\n");
-                        e_dev_err("Reload the driver after installing a "
-                                  "supported module.\n");
-                        unregister_netdev(adapter->netdev);
-                } else {
-                        e_info(probe, "detected SFP+: %d\n", hw->phy.sfp_type);
-                }
-                /* don't need this routine any more */
-                clear_bit(__IXGBE_SFP_MODULE_NOT_FOUND, &adapter->state);
-        }
-        return;
-reschedule:
-        if (test_bit(__IXGBE_SFP_MODULE_NOT_FOUND, &adapter->state))
-                mod_timer(&adapter->sfp_timer,
-                          round_jiffies(jiffies + (2 * HZ)));
-}
-/**
 * ixgbe_sw_init - Initialize general software structures (struct ixgbe_adapter)
 * @adapter: board private structure to initialize
 *
@@ -5899,8 +5884,13 @@ void ixgbe_update_stats(struct ixgbe_adapter *adapter)
                hwstats->gotc += IXGBE_READ_REG(hw, IXGBE_GOTCH);
                hwstats->tor += IXGBE_READ_REG(hw, IXGBE_TORH);
                break;
-        case ixgbe_mac_82599EB:
        case ixgbe_mac_X540:
+                /* OS2BMC stats are X540 only*/
+                hwstats->o2bgptc += IXGBE_READ_REG(hw, IXGBE_O2BGPTC);
+                hwstats->o2bspc += IXGBE_READ_REG(hw, IXGBE_O2BSPC);
+                hwstats->b2ospc += IXGBE_READ_REG(hw, IXGBE_B2OSPC);
+                hwstats->b2ogprc += IXGBE_READ_REG(hw, IXGBE_B2OGPRC);
+        case ixgbe_mac_82599EB:
                hwstats->gorc += IXGBE_READ_REG(hw, IXGBE_GORCL);
                IXGBE_READ_REG(hw, IXGBE_GORCH); /* to clear */
                hwstats->gotc += IXGBE_READ_REG(hw, IXGBE_GOTCL);
@@ -5974,23 +5964,66 @@ void ixgbe_update_stats(struct ixgbe_adapter *adapter)
 }
 /**
- * ixgbe_watchdog - Timer Call-back
+ * ixgbe_fdir_reinit_subtask - worker thread to reinit FDIR filter table
- * @data: pointer to adapter cast into an unsigned long
+ * @adapter - pointer to the device adapter structure
 **/
-static void ixgbe_watchdog(unsigned long data)
+static void ixgbe_fdir_reinit_subtask(struct ixgbe_adapter *adapter)
 {
-        struct ixgbe_adapter *adapter = (struct ixgbe_adapter *)data;
        struct ixgbe_hw *hw = &adapter->hw;
-        u64 eics = 0;
        int i;
-        /*
+        if (!(adapter->flags2 & IXGBE_FLAG2_FDIR_REQUIRES_REINIT))
-         *  Do the watchdog outside of interrupt context due to the lovely
+                return;
-         * delays that some of the newer hardware requires
-         */
+        adapter->flags2 &= ~IXGBE_FLAG2_FDIR_REQUIRES_REINIT;
+        /* if interface is down do nothing */
        if (test_bit(__IXGBE_DOWN, &adapter->state))
-                goto watchdog_short_circuit;
+                return;
+        /* do nothing if we are not using signature filters */
+        if (!(adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE))
+                return;
+        adapter->fdir_overflow++;
+        if (ixgbe_reinit_fdir_tables_82599(hw) == 0) {
+                for (i = 0; i < adapter->num_tx_queues; i++)
+                        set_bit(__IXGBE_TX_FDIR_INIT_DONE,
+                                &(adapter->tx_ring[i]->state));
+                /* re-enable flow director interrupts */
+                IXGBE_WRITE_REG(hw, IXGBE_EIMS, IXGBE_EIMS_FLOW_DIR);
+        } else {
+                e_err(probe, "failed to finish FDIR re-initialization, "
+                      "ignored adding FDIR ATR filters\n");
+        }
+}
+/**
+ * ixgbe_check_hang_subtask - check for hung queues and dropped interrupts
+ * @adapter - pointer to the device adapter structure
+ *
+ * This function serves two purposes.  First it strobes the interrupt lines
+ * in order to make certain interrupts are occuring.  Secondly it sets the
+ * bits needed to check for TX hangs.  As a result we should immediately
+ * determine if a hang has occured.
+ */
+static void ixgbe_check_hang_subtask(struct ixgbe_adapter *adapter)
+{
+        struct ixgbe_hw *hw = &adapter->hw;
+        u64 eics = 0;
+        int i;
+        /* If we're down or resetting, just bail */
+        if (test_bit(__IXGBE_DOWN, &adapter->state) ||
+            test_bit(__IXGBE_RESETTING, &adapter->state))
+                return;
+        /* Force detection of hung controller */
+        if (netif_carrier_ok(adapter->netdev)) {
+                for (i = 0; i < adapter->num_tx_queues; i++)
+                        set_check_for_tx_hang(adapter->tx_ring[i]);
+        }
        if (!(adapter->flags & IXGBE_FLAG_MSIX_ENABLED)) {
                /*
@@ -6000,108 +6033,172 @@ static void ixgbe_watchdog(unsigned long data)
                 */
                IXGBE_WRITE_REG(hw, IXGBE_EICS,
                        (IXGBE_EICS_TCP_TIMER | IXGBE_EICS_OTHER));
-                goto watchdog_reschedule;
+        } else {
-        }
+                /* get one bit for every active tx/rx interrupt vector */
+                for (i = 0; i < adapter->num_msix_vectors - NON_Q_VECTORS; i++) {
-        /* get one bit for every active tx/rx interrupt vector */
+                        struct ixgbe_q_vector *qv = adapter->q_vector[i];
-        for (i = 0; i < adapter->num_msix_vectors - NON_Q_VECTORS; i++) {
+                        if (qv->rxr_count || qv->txr_count)
-                struct ixgbe_q_vector *qv = adapter->q_vector[i];
+                                eics |= ((u64)1 << i);
-                if (qv->rxr_count || qv->txr_count)
+                }
-                        eics |= ((u64)1 << i);
        }
-        /* Cause software interrupt to ensure rx rings are cleaned */
+        /* Cause software interrupt to ensure rings are cleaned */
        ixgbe_irq_rearm_queues(adapter, eics);
-watchdog_reschedule:
-        /* Reset the timer */
-        mod_timer(&adapter->watchdog_timer, round_jiffies(jiffies + 2 * HZ));
-watchdog_short_circuit:
-        schedule_work(&adapter->watchdog_task);
 }
 /**
- * ixgbe_multispeed_fiber_task - worker thread to configure multispeed fiber
+ * ixgbe_watchdog_update_link - update the link status
- * @work: pointer to work_struct containing our data
+ * @adapter - pointer to the device adapter structure
+ * @link_speed - pointer to a u32 to store the link_speed
 **/
-static void ixgbe_multispeed_fiber_task(struct work_struct *work)
+static void ixgbe_watchdog_update_link(struct ixgbe_adapter *adapter)
 {
-        struct ixgbe_adapter *adapter = container_of(work,
-                                                     struct ixgbe_adapter,
-                                                     multispeed_fiber_task);
        struct ixgbe_hw *hw = &adapter->hw;
-        u32 autoneg;
+        u32 link_speed = adapter->link_speed;
-        bool negotiation;
+        bool link_up = adapter->link_up;
+        int i;
-        adapter->flags |= IXGBE_FLAG_IN_SFP_LINK_TASK;
+        if (!(adapter->flags & IXGBE_FLAG_NEED_LINK_UPDATE))
-        autoneg = hw->phy.autoneg_advertised;
+                return;
-        if ((!autoneg) && (hw->mac.ops.get_link_capabilities))
-                hw->mac.ops.get_link_capabilities(hw, &autoneg, &negotiation);
+        if (hw->mac.ops.check_link) {
-        hw->mac.autotry_restart = false;
+                hw->mac.ops.check_link(hw, &link_speed, &link_up, false);
-        if (hw->mac.ops.setup_link)
+        } else {
-                hw->mac.ops.setup_link(hw, autoneg, negotiation, true);
+                /* always assume link is up, if no check link function */
-        adapter->flags |= IXGBE_FLAG_NEED_LINK_UPDATE;
+                link_speed = IXGBE_LINK_SPEED_10GB_FULL;
-        adapter->flags &= ~IXGBE_FLAG_IN_SFP_LINK_TASK;
+                link_up = true;
+        }
+        if (link_up) {
+                if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) {
+                        for (i = 0; i < MAX_TRAFFIC_CLASS; i++)
+                                hw->mac.ops.fc_enable(hw, i);
+                } else {
+                        hw->mac.ops.fc_enable(hw, 0);
+                }
+        }
+        if (link_up ||
+            time_after(jiffies, (adapter->link_check_timeout +
+                                 IXGBE_TRY_LINK_TIMEOUT))) {
+                adapter->flags &= ~IXGBE_FLAG_NEED_LINK_UPDATE;
+                IXGBE_WRITE_REG(hw, IXGBE_EIMS, IXGBE_EIMC_LSC);
+                IXGBE_WRITE_FLUSH(hw);
+        }
+        adapter->link_up = link_up;
+        adapter->link_speed = link_speed;
 }
 /**
- * ixgbe_sfp_config_module_task - worker thread to configure a new SFP+ module
+ * ixgbe_watchdog_link_is_up - update netif_carrier status and
- * @work: pointer to work_struct containing our data
+ *                             print link up message
+ * @adapter - pointer to the device adapter structure
 **/
-static void ixgbe_sfp_config_module_task(struct work_struct *work)
+static void ixgbe_watchdog_link_is_up(struct ixgbe_adapter *adapter)
 {
-        struct ixgbe_adapter *adapter = container_of(work,
+        struct net_device *netdev = adapter->netdev;
-                                                     struct ixgbe_adapter,
-                                                     sfp_config_module_task);
        struct ixgbe_hw *hw = &adapter->hw;
-        u32 err;
+        u32 link_speed = adapter->link_speed;
+        bool flow_rx, flow_tx;
-        adapter->flags |= IXGBE_FLAG_IN_SFP_MOD_TASK;
+        /* only continue if link was previously down */
+        if (netif_carrier_ok(netdev))
+                return;
-        /* Time for electrical oscillations to settle down */
+        adapter->flags2 &= ~IXGBE_FLAG2_SEARCH_FOR_SFP;
-        msleep(100);
-        err = hw->phy.ops.identify_sfp(hw);
-        if (err == IXGBE_ERR_SFP_NOT_SUPPORTED) {
+        switch (hw->mac.type) {
-                e_dev_err("failed to initialize because an unsupported SFP+ "
+        case ixgbe_mac_82598EB: {
-                          "module type was detected.\n");
+                u32 frctl = IXGBE_READ_REG(hw, IXGBE_FCTRL);
-                e_dev_err("Reload the driver after installing a supported "
+                u32 rmcs = IXGBE_READ_REG(hw, IXGBE_RMCS);
-                          "module.\n");
+                flow_rx = !!(frctl & IXGBE_FCTRL_RFCE);
-                unregister_netdev(adapter->netdev);
+                flow_tx = !!(rmcs & IXGBE_RMCS_TFCE_802_3X);
-                return;
+        }
+                break;
+        case ixgbe_mac_X540:
+        case ixgbe_mac_82599EB: {
+                u32 mflcn = IXGBE_READ_REG(hw, IXGBE_MFLCN);
+                u32 fccfg = IXGBE_READ_REG(hw, IXGBE_FCCFG);
+                flow_rx = !!(mflcn & IXGBE_MFLCN_RFCE);
+                flow_tx = !!(fccfg & IXGBE_FCCFG_TFCE_802_3X);
+        }
+                break;
+        default:
+                flow_tx = false;
+                flow_rx = false;
+                break;
        }
-        if (hw->mac.ops.setup_sfp)
+        e_info(drv, "NIC Link is Up %s, Flow Control: %s\n",
-                hw->mac.ops.setup_sfp(hw);
+               (link_speed == IXGBE_LINK_SPEED_10GB_FULL ?
+               "10 Gbps" :
+               (link_speed == IXGBE_LINK_SPEED_1GB_FULL ?
+               "1 Gbps" :
+               (link_speed == IXGBE_LINK_SPEED_100_FULL ?
+               "100 Mbps" :
+               "unknown speed"))),
+               ((flow_rx && flow_tx) ? "RX/TX" :
+               (flow_rx ? "RX" :
+               (flow_tx ? "TX" : "None"))));
-        if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
+        netif_carrier_on(netdev);
-                /* This will also work for DA Twinax connections */
+#ifdef HAVE_IPLINK_VF_CONFIG
-                schedule_work(&adapter->multispeed_fiber_task);
+        ixgbe_check_vf_rate_limit(adapter);
-        adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
+#endif /* HAVE_IPLINK_VF_CONFIG */
 }
 /**
- * ixgbe_fdir_reinit_task - worker thread to reinit FDIR filter table
+ * ixgbe_watchdog_link_is_down - update netif_carrier status and
- * @work: pointer to work_struct containing our data
+ *                               print link down message
+ * @adapter - pointer to the adapter structure
 **/
-static void ixgbe_fdir_reinit_task(struct work_struct *work)
+static void ixgbe_watchdog_link_is_down(struct ixgbe_adapter* adapter)
 {
-        struct ixgbe_adapter *adapter = container_of(work,
+        struct net_device *netdev = adapter->netdev;
-                                                     struct ixgbe_adapter,
-                                                     fdir_reinit_task);
        struct ixgbe_hw *hw = &adapter->hw;
+        adapter->link_up = false;
+        adapter->link_speed = 0;
+        /* only continue if link was up previously */
+        if (!netif_carrier_ok(netdev))
+                return;
+        /* poll for SFP+ cable when link is down */
+        if (ixgbe_is_sfp(hw) && hw->mac.type == ixgbe_mac_82598EB)
+                adapter->flags2 |= IXGBE_FLAG2_SEARCH_FOR_SFP;
+        e_info(drv, "NIC Link is Down\n");
+        netif_carrier_off(netdev);
+}
+/**
+ * ixgbe_watchdog_flush_tx - flush queues on link down
+ * @adapter - pointer to the device adapter structure
+ **/
+static void ixgbe_watchdog_flush_tx(struct ixgbe_adapter *adapter)
+{
        int i;
+        int some_tx_pending = 0;
-        if (ixgbe_reinit_fdir_tables_82599(hw) == 0) {
+        if (!netif_carrier_ok(adapter->netdev)) {
-                for (i = 0; i < adapter->num_tx_queues; i++)
+                for (i = 0; i < adapter->num_tx_queues; i++) {
-                        set_bit(__IXGBE_TX_FDIR_INIT_DONE,
+                        struct ixgbe_ring *tx_ring = adapter->tx_ring[i];
-                                &(adapter->tx_ring[i]->state));
+                        if (tx_ring->next_to_use != tx_ring->next_to_clean) {
-        } else {
+                                some_tx_pending = 1;
-                e_err(probe, "failed to finish FDIR re-initialization, "
+                                break;
-                      "ignored adding FDIR ATR filters\n");
+                        }
+                }
+                if (some_tx_pending) {
+                        /* We've lost link, so the controller stops DMA,
+                         * but we've got queued Tx work that's never going
+                         * to get done, so reset controller to flush Tx.
+                         * (Do the reset outside of interrupt context).
+                         */
+                        adapter->flags2 |= IXGBE_FLAG2_RESET_REQUESTED;
+                }
        }
-        /* Done FDIR Re-initialization, enable transmits */
-        netif_tx_start_all_queues(adapter->netdev);
 }
 static void ixgbe_spoof_check(struct ixgbe_adapter *adapter)
@@ -6124,133 +6221,186 @@ static void ixgbe_spoof_check(struct ixgbe_adapter *adapter)
        e_warn(drv, "%d Spoofed packets detected\n", ssvpc);
 }
-static DEFINE_MUTEX(ixgbe_watchdog_lock);
+/**
+ * ixgbe_watchdog_subtask - check and bring link up
+ * @adapter - pointer to the device adapter structure
+ **/
+static void ixgbe_watchdog_subtask(struct ixgbe_adapter *adapter)
+{
+        /* if interface is down do nothing */
+        if (test_bit(__IXGBE_DOWN, &adapter->state))
+                return;
+        ixgbe_watchdog_update_link(adapter);
+        if (adapter->link_up)
+                ixgbe_watchdog_link_is_up(adapter);
+        else
+                ixgbe_watchdog_link_is_down(adapter);
+        ixgbe_spoof_check(adapter);
+        ixgbe_update_stats(adapter);
+        ixgbe_watchdog_flush_tx(adapter);
+}
 /**
- * ixgbe_watchdog_task - worker thread to bring link up
+ * ixgbe_sfp_detection_subtask - poll for SFP+ cable
- * @work: pointer to work_struct containing our data
+ * @adapter - the ixgbe adapter structure
 **/
-static void ixgbe_watchdog_task(struct work_struct *work)
+static void ixgbe_sfp_detection_subtask(struct ixgbe_adapter *adapter)
 {
-        struct ixgbe_adapter *adapter = container_of(work,
-                                                     struct ixgbe_adapter,
-                                                     watchdog_task);
-        struct net_device *netdev = adapter->netdev;
        struct ixgbe_hw *hw = &adapter->hw;
-        u32 link_speed;
+        s32 err;
-        bool link_up;
-        int i;
-        struct ixgbe_ring *tx_ring;
-        int some_tx_pending = 0;
-        mutex_lock(&ixgbe_watchdog_lock);
+        /* not searching for SFP so there is nothing to do here */
+        if (!(adapter->flags2 & IXGBE_FLAG2_SEARCH_FOR_SFP) &&
+            !(adapter->flags2 & IXGBE_FLAG2_SFP_NEEDS_RESET))
+                return;
-        link_up = adapter->link_up;
+        /* someone else is in init, wait until next service event */
-        link_speed = adapter->link_speed;
+        if (test_and_set_bit(__IXGBE_IN_SFP_INIT, &adapter->state))
+                return;
-        if (adapter->flags & IXGBE_FLAG_NEED_LINK_UPDATE) {
+        err = hw->phy.ops.identify_sfp(hw);
-                hw->mac.ops.check_link(hw, &link_speed, &link_up, false);
+        if (err == IXGBE_ERR_SFP_NOT_SUPPORTED)
-                if (link_up) {
+                goto sfp_out;
-#ifdef CONFIG_DCB
-                        if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) {
-                                for (i = 0; i < MAX_TRAFFIC_CLASS; i++)
-                                        hw->mac.ops.fc_enable(hw, i);
-                        } else {
-                                hw->mac.ops.fc_enable(hw, 0);
-                        }
-#else
-                        hw->mac.ops.fc_enable(hw, 0);
-#endif
-                }
-                if (link_up ||
+        if (err == IXGBE_ERR_SFP_NOT_PRESENT) {
-                    time_after(jiffies, (adapter->link_check_timeout +
+                /* If no cable is present, then we need to reset
-                                         IXGBE_TRY_LINK_TIMEOUT))) {
+                 * the next time we find a good cable. */
-                        adapter->flags &= ~IXGBE_FLAG_NEED_LINK_UPDATE;
+                adapter->flags2 |= IXGBE_FLAG2_SFP_NEEDS_RESET;
-                        IXGBE_WRITE_REG(hw, IXGBE_EIMS, IXGBE_EIMC_LSC);
-                }
-                adapter->link_up = link_up;
-                adapter->link_speed = link_speed;
        }
-        if (link_up) {
+        /* exit on error */
-                if (!netif_carrier_ok(netdev)) {
+        if (err)
-                        bool flow_rx, flow_tx;
+                goto sfp_out;
-                        switch (hw->mac.type) {
-                        case ixgbe_mac_82598EB: {
-                                u32 frctl = IXGBE_READ_REG(hw, IXGBE_FCTRL);
-                                u32 rmcs = IXGBE_READ_REG(hw, IXGBE_RMCS);
-                                flow_rx = !!(frctl & IXGBE_FCTRL_RFCE);
-                                flow_tx = !!(rmcs & IXGBE_RMCS_TFCE_802_3X);
-                        }
-                                break;
-                        case ixgbe_mac_82599EB:
-                        case ixgbe_mac_X540: {
-                                u32 mflcn = IXGBE_READ_REG(hw, IXGBE_MFLCN);
-                                u32 fccfg = IXGBE_READ_REG(hw, IXGBE_FCCFG);
-                                flow_rx = !!(mflcn & IXGBE_MFLCN_RFCE);
-                                flow_tx = !!(fccfg & IXGBE_FCCFG_TFCE_802_3X);
-                        }
-                                break;
-                        default:
-                                flow_tx = false;
-                                flow_rx = false;
-                                break;
-                        }
-                        e_info(drv, "NIC Link is Up %s, Flow Control: %s\n",
+        /* exit if reset not needed */
-                               (link_speed == IXGBE_LINK_SPEED_10GB_FULL ?
+        if (!(adapter->flags2 & IXGBE_FLAG2_SFP_NEEDS_RESET))
-                               "10 Gbps" :
+                goto sfp_out;
-                               (link_speed == IXGBE_LINK_SPEED_1GB_FULL ?
-                               "1 Gbps" :
-                               (link_speed == IXGBE_LINK_SPEED_100_FULL ?
-                               "100 Mbps" :
-                               "unknown speed"))),
-                               ((flow_rx && flow_tx) ? "RX/TX" :
-                               (flow_rx ? "RX" :
-                               (flow_tx ? "TX" : "None"))));
-                        netif_carrier_on(netdev);
-                        ixgbe_check_vf_rate_limit(adapter);
-                } else {
-                        /* Force detection of hung controller */
-                        for (i = 0; i < adapter->num_tx_queues; i++) {
-                                tx_ring = adapter->tx_ring[i];
-                                set_check_for_tx_hang(tx_ring);
-                        }
-                }
-        } else {
-                adapter->link_up = false;
-                adapter->link_speed = 0;
-                if (netif_carrier_ok(netdev)) {
-                        e_info(drv, "NIC Link is Down\n");
-                        netif_carrier_off(netdev);
-                }
-        }
-        if (!netif_carrier_ok(netdev)) {
+        adapter->flags2 &= ~IXGBE_FLAG2_SFP_NEEDS_RESET;
-                for (i = 0; i < adapter->num_tx_queues; i++) {
-                        tx_ring = adapter->tx_ring[i];
-                        if (tx_ring->next_to_use != tx_ring->next_to_clean) {
-                                some_tx_pending = 1;
-                                break;
-                        }
-                }
-                if (some_tx_pending) {
+        /*
-                        /* We've lost link, so the controller stops DMA,
+         * A module may be identified correctly, but the EEPROM may not have
-                         * but we've got queued Tx work that's never going
+         * support for that module.  setup_sfp() will fail in that case, so
-                         * to get done, so reset controller to flush Tx.
+         * we should not allow that module to load.
-                         * (Do the reset outside of interrupt context).
+         */
-                         */
+        if (hw->mac.type == ixgbe_mac_82598EB)
-                         schedule_work(&adapter->reset_task);
+                err = hw->phy.ops.reset(hw);
-                }
+        else
+                err = hw->mac.ops.setup_sfp(hw);
+        if (err == IXGBE_ERR_SFP_NOT_SUPPORTED)
+                goto sfp_out;
+        adapter->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
+        e_info(probe, "detected SFP+: %d\n", hw->phy.sfp_type);
+sfp_out:
+        clear_bit(__IXGBE_IN_SFP_INIT, &adapter->state);
+        if ((err == IXGBE_ERR_SFP_NOT_SUPPORTED) &&
+            (adapter->netdev->reg_state == NETREG_REGISTERED)) {
+                e_dev_err("failed to initialize because an unsupported "
+                          "SFP+ module type was detected.\n");
+                e_dev_err("Reload the driver after installing a "
+                          "supported module.\n");
+                unregister_netdev(adapter->netdev);
        }
+}
-        ixgbe_spoof_check(adapter);
+/**
-        ixgbe_update_stats(adapter);
+ * ixgbe_sfp_link_config_subtask - set up link SFP after module install
-        mutex_unlock(&ixgbe_watchdog_lock);
+ * @adapter - the ixgbe adapter structure
+ **/
+static void ixgbe_sfp_link_config_subtask(struct ixgbe_adapter *adapter)
+{
+        struct ixgbe_hw *hw = &adapter->hw;
+        u32 autoneg;
+        bool negotiation;
+        if (!(adapter->flags & IXGBE_FLAG_NEED_LINK_CONFIG))
+                return;
+        /* someone else is in init, wait until next service event */
+        if (test_and_set_bit(__IXGBE_IN_SFP_INIT, &adapter->state))
+                return;
+        adapter->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;
+        autoneg = hw->phy.autoneg_advertised;
+        if ((!autoneg) && (hw->mac.ops.get_link_capabilities))
+                hw->mac.ops.get_link_capabilities(hw, &autoneg, &negotiation);
+        hw->mac.autotry_restart = false;
+        if (hw->mac.ops.setup_link)
+                hw->mac.ops.setup_link(hw, autoneg, negotiation, true);
+        adapter->flags |= IXGBE_FLAG_NEED_LINK_UPDATE;
+        adapter->link_check_timeout = jiffies;
+        clear_bit(__IXGBE_IN_SFP_INIT, &adapter->state);
+}
+/**
+ * ixgbe_service_timer - Timer Call-back
+ * @data: pointer to adapter cast into an unsigned long
+ **/
+static void ixgbe_service_timer(unsigned long data)
+{
+        struct ixgbe_adapter *adapter = (struct ixgbe_adapter *)data;
+        unsigned long next_event_offset;
+        /* poll faster when waiting for link */
+        if (adapter->flags & IXGBE_FLAG_NEED_LINK_UPDATE)
+                next_event_offset = HZ / 10;
+        else
+                next_event_offset = HZ * 2;
+        /* Reset the timer */
+        mod_timer(&adapter->service_timer, next_event_offset + jiffies);
+        ixgbe_service_event_schedule(adapter);
+}
+static void ixgbe_reset_subtask(struct ixgbe_adapter *adapter)
+{
+        if (!(adapter->flags2 & IXGBE_FLAG2_RESET_REQUESTED))
+                return;
+        adapter->flags2 &= ~IXGBE_FLAG2_RESET_REQUESTED;
+        /* If we're already down or resetting, just bail */
+        if (test_bit(__IXGBE_DOWN, &adapter->state) ||
+            test_bit(__IXGBE_RESETTING, &adapter->state))
+                return;
+        ixgbe_dump(adapter);
+        netdev_err(adapter->netdev, "Reset adapter\n");
+        adapter->tx_timeout_count++;
+        ixgbe_reinit_locked(adapter);
+}
+/**
+ * ixgbe_service_task - manages and runs subtasks
+ * @work: pointer to work_struct containing our data
+ **/
+static void ixgbe_service_task(struct work_struct *work)
+{
+        struct ixgbe_adapter *adapter = container_of(work,
+                                                     struct ixgbe_adapter,
+                                                     service_task);
+        ixgbe_reset_subtask(adapter);
+        ixgbe_sfp_detection_subtask(adapter);
+        ixgbe_sfp_link_config_subtask(adapter);
+        ixgbe_check_overtemp_subtask(adapter);
+        ixgbe_watchdog_subtask(adapter);
+        ixgbe_fdir_reinit_subtask(adapter);
+        ixgbe_check_hang_subtask(adapter);
+        ixgbe_service_event_complete(adapter);
 }
 static int ixgbe_tso(struct ixgbe_adapter *adapter,
@@ -7089,6 +7239,8 @@ static void __devinit ixgbe_probe_vf(struct ixgbe_adapter *adapter,
 #ifdef CONFIG_PCI_IOV
        struct ixgbe_hw *hw = &adapter->hw;
        int err;
+        int num_vf_macvlans, i;
+        struct vf_macvlans *mv_list;
        if (hw->mac.type == ixgbe_mac_82598EB || !max_vfs)
                return;
@@ -7105,6 +7257,26 @@ static void __devinit ixgbe_probe_vf(struct ixgbe_adapter *adapter,
                e_err(probe, "Failed to enable PCI sriov: %d\n", err);
                goto err_novfs;
        }
+        num_vf_macvlans = hw->mac.num_rar_entries -
+                (IXGBE_MAX_PF_MACVLANS + 1 + adapter->num_vfs);
+        adapter->mv_list = mv_list = kcalloc(num_vf_macvlans,
+                                             sizeof(struct vf_macvlans),
+                                             GFP_KERNEL);
+        if (mv_list) {
+                /* Initialize list of VF macvlans */
+                INIT_LIST_HEAD(&adapter->vf_mvs.l);
+                for (i = 0; i < num_vf_macvlans; i++) {
+                        mv_list->vf = -1;
+                        mv_list->free = true;
+                        mv_list->rar_entry = hw->mac.num_rar_entries -
+                                (i + adapter->num_vfs + 1);
+                        list_add(&mv_list->l, &adapter->vf_mvs.l);
+                        mv_list++;
+                }
+        }
        /* If call to enable VFs succeeded then allocate memory
         * for per VF control structures.
         */
@@ -7275,22 +7447,6 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
        hw->phy.mdio.mdio_read = ixgbe_mdio_read;
        hw->phy.mdio.mdio_write = ixgbe_mdio_write;
-        /* set up this timer and work struct before calling get_invariants
-         * which might start the timer
-         */
-        init_timer(&adapter->sfp_timer);
-        adapter->sfp_timer.function = ixgbe_sfp_timer;
-        adapter->sfp_timer.data = (unsigned long) adapter;
-        INIT_WORK(&adapter->sfp_task, ixgbe_sfp_task);
-        /* multispeed fiber has its own tasklet, called from GPI SDP1 context */
-        INIT_WORK(&adapter->multispeed_fiber_task, ixgbe_multispeed_fiber_task);
-        /* a new SFP+ module arrival, called from GPI SDP2 context */
-        INIT_WORK(&adapter->sfp_config_module_task,
-                  ixgbe_sfp_config_module_task);
        ii->get_invariants(hw);
        /* setup the private structure */
@@ -7324,17 +7480,9 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
        hw->phy.reset_if_overtemp = false;
        if (err == IXGBE_ERR_SFP_NOT_PRESENT &&
            hw->mac.type == ixgbe_mac_82598EB) {
-                /*
-                 * Start a kernel thread to watch for a module to arrive.
-                 * Only do this for 82598, since 82599 will generate
-                 * interrupts on module arrival.
-                 */
-                set_bit(__IXGBE_SFP_MODULE_NOT_FOUND, &adapter->state);
-                mod_timer(&adapter->sfp_timer,
-                          round_jiffies(jiffies + (2 * HZ)));
                err = 0;
        } else if (err == IXGBE_ERR_SFP_NOT_SUPPORTED) {
-                e_dev_err("failed to initialize because an unsupported SFP+ "
+                e_dev_err("failed to load because an unsupported SFP+ "
                          "module type was detected.\n");
                e_dev_err("Reload the driver after installing a supported "
                          "module.\n");
@@ -7356,9 +7504,16 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
        netdev->features |= NETIF_F_TSO;
        netdev->features |= NETIF_F_TSO6;
        netdev->features |= NETIF_F_GRO;
+        netdev->features |= NETIF_F_RXHASH;
-        if (adapter->hw.mac.type == ixgbe_mac_82599EB)
+        switch (adapter->hw.mac.type) {
+        case ixgbe_mac_82599EB:
+        case ixgbe_mac_X540:
                netdev->features |= NETIF_F_SCTP_CSUM;
+                break;
+        default:
+                break;
+        }
        netdev->vlan_features |= NETIF_F_TSO;
        netdev->vlan_features |= NETIF_F_TSO6;
@@ -7419,17 +7574,19 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
              (hw->mac.type == ixgbe_mac_82599EB))))
                hw->mac.ops.disable_tx_laser(hw);
-        init_timer(&adapter->watchdog_timer);
+        setup_timer(&adapter->service_timer, &ixgbe_service_timer,
-        adapter->watchdog_timer.function = ixgbe_watchdog;
+                    (unsigned long) adapter);
-        adapter->watchdog_timer.data = (unsigned long)adapter;
-        INIT_WORK(&adapter->reset_task, ixgbe_reset_task);
+        INIT_WORK(&adapter->service_task, ixgbe_service_task);
-        INIT_WORK(&adapter->watchdog_task, ixgbe_watchdog_task);
+        clear_bit(__IXGBE_SERVICE_SCHED, &adapter->state);
        err = ixgbe_init_interrupt_scheme(adapter);
        if (err)
                goto err_sw_init;
+        if (!(adapter->flags & IXGBE_FLAG_RSS_ENABLED))
+                netdev->features &= ~NETIF_F_RXHASH;
        switch (pdev->device) {
        case IXGBE_DEV_ID_82599_SFP:
                /* Only this subdevice supports WOL */
@@ -7458,8 +7615,8 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
        /* print bus type/speed/width info */
        e_dev_info("(PCI Express:%s:%s) %pM\n",
-                   (hw->bus.speed == ixgbe_bus_speed_5000 ? "5.0Gb/s" :
+                   (hw->bus.speed == ixgbe_bus_speed_5000 ? "5.0GT/s" :
-                    hw->bus.speed == ixgbe_bus_speed_2500 ? "2.5Gb/s" :
+                    hw->bus.speed == ixgbe_bus_speed_2500 ? "2.5GT/s" :
                    "Unknown"),
                   (hw->bus.width == ixgbe_bus_width_pcie_x8 ? "Width x8" :
                    hw->bus.width == ixgbe_bus_width_pcie_x4 ? "Width x4" :
@@ -7508,13 +7665,6 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
        /* carrier off reporting is important to ethtool even BEFORE open */
        netif_carrier_off(netdev);
-        if (adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE ||
-            adapter->flags & IXGBE_FLAG_FDIR_PERFECT_CAPABLE)
-                INIT_WORK(&adapter->fdir_reinit_task, ixgbe_fdir_reinit_task);
-        if (adapter->flags2 & IXGBE_FLAG2_TEMP_SENSOR_CAPABLE)
-                INIT_WORK(&adapter->check_overtemp_task,
-                          ixgbe_check_overtemp_task);
 #ifdef CONFIG_IXGBE_DCA
        if (dca_add_requester(&pdev->dev) == 0) {
                adapter->flags |= IXGBE_FLAG_DCA_ENABLED;
@@ -7541,11 +7691,7 @@ err_sw_init:
 err_eeprom:
        if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)
                ixgbe_disable_sriov(adapter);
-        clear_bit(__IXGBE_SFP_MODULE_NOT_FOUND, &adapter->state);
+        adapter->flags2 &= ~IXGBE_FLAG2_SEARCH_FOR_SFP;
-        del_timer_sync(&adapter->sfp_timer);
-        cancel_work_sync(&adapter->sfp_task);
-        cancel_work_sync(&adapter->multispeed_fiber_task);
-        cancel_work_sync(&adapter->sfp_config_module_task);
        iounmap(hw->hw_addr);
 err_ioremap:
        free_netdev(netdev);
@@ -7573,24 +7719,7 @@ static void __devexit ixgbe_remove(struct pci_dev *pdev)
        struct net_device *netdev = adapter->netdev;
        set_bit(__IXGBE_DOWN, &adapter->state);
+        cancel_work_sync(&adapter->service_task);
-        /*
-         * The timers may be rescheduled, so explicitly disable them
-         * from being rescheduled.
-         */
-        clear_bit(__IXGBE_SFP_MODULE_NOT_FOUND, &adapter->state);
-        del_timer_sync(&adapter->watchdog_timer);
-        del_timer_sync(&adapter->sfp_timer);
-        cancel_work_sync(&adapter->watchdog_task);
-        cancel_work_sync(&adapter->sfp_task);
-        cancel_work_sync(&adapter->multispeed_fiber_task);
-        cancel_work_sync(&adapter->sfp_config_module_task);
-        if (adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE ||
-            adapter->flags & IXGBE_FLAG_FDIR_PERFECT_CAPABLE)
-                cancel_work_sync(&adapter->fdir_reinit_task);
-        if (adapter->flags2 & IXGBE_FLAG2_TEMP_SENSOR_CAPABLE)
-                cancel_work_sync(&adapter->check_overtemp_task);
 #ifdef CONFIG_IXGBE_DCA
        if (adapter->flags & IXGBE_FLAG_DCA_ENABLED) {
diff --git a/drivers/net/ixgbe/ixgbe_mbx.h b/drivers/net/ixgbe/ixgbe_mbx.h
index fe6ea81dc7f8..b239bdac38da 100644
--- a/drivers/net/ixgbe/ixgbe_mbx.h
+++ b/drivers/net/ixgbe/ixgbe_mbx.h
@@ -36,9 +36,6 @@
 #define IXGBE_VFMAILBOX             0x002FC
 #define IXGBE_VFMBMEM               0x00200
-#define IXGBE_PFMAILBOX(x)          (0x04B00 + (4 * x))
-#define IXGBE_PFMBMEM(vfn)          (0x13000 + (64 * vfn))
 #define IXGBE_PFMAILBOX_STS   0x00000001 /* Initiate message send to VF */
 #define IXGBE_PFMAILBOX_ACK   0x00000002 /* Ack message recv'd from VF */
 #define IXGBE_PFMAILBOX_VFU   0x00000004 /* VF owns the mailbox buffer */
@@ -70,6 +67,7 @@
 #define IXGBE_VF_SET_MULTICAST    0x03 /* VF requests PF to set MC addr */
 #define IXGBE_VF_SET_VLAN         0x04 /* VF requests PF to set VLAN */
 #define IXGBE_VF_SET_LPE          0x05 /* VF requests PF to set VMOLR.LPE */
+#define IXGBE_VF_SET_MACVLAN      0x06 /* VF requests PF for unicast filter */
 /* length of permanent address message returned from PF */
 #define IXGBE_VF_PERMADDR_MSG_LEN 4
diff --git a/drivers/net/ixgbe/ixgbe_phy.c b/drivers/net/ixgbe/ixgbe_phy.c
index df5b8aa4795d..735f686c3b36 100644
--- a/drivers/net/ixgbe/ixgbe_phy.c
+++ b/drivers/net/ixgbe/ixgbe_phy.c
@@ -449,7 +449,8 @@ s32 ixgbe_setup_phy_link_generic(struct ixgbe_hw *hw)
                                     MDIO_MMD_AN,
                                     &autoneg_reg);
-                autoneg_reg &= ~ADVERTISE_100FULL;
+                autoneg_reg &= ~(ADVERTISE_100FULL |
+                                 ADVERTISE_100HALF);
                if (hw->phy.autoneg_advertised & IXGBE_LINK_SPEED_100_FULL)
                        autoneg_reg |= ADVERTISE_100FULL;
@@ -656,7 +657,8 @@ s32 ixgbe_setup_phy_link_tnx(struct ixgbe_hw *hw)
                                     MDIO_MMD_AN,
                                     &autoneg_reg);
-                autoneg_reg &= ~ADVERTISE_100FULL;
+                autoneg_reg &= ~(ADVERTISE_100FULL |
+                                 ADVERTISE_100HALF);
                if (hw->phy.autoneg_advertised & IXGBE_LINK_SPEED_100_FULL)
                        autoneg_reg |= ADVERTISE_100FULL;
@@ -753,7 +755,7 @@ s32 ixgbe_reset_phy_nl(struct ixgbe_hw *hw)
                                     &phy_data);
                if ((phy_data & MDIO_CTRL1_RESET) == 0)
                        break;
-                msleep(10);
+                usleep_range(10000, 20000);
        }
        if ((phy_data & MDIO_CTRL1_RESET) != 0) {
@@ -782,7 +784,7 @@ s32 ixgbe_reset_phy_nl(struct ixgbe_hw *hw)
                case IXGBE_DELAY_NL:
                        data_offset++;
                        hw_dbg(hw, "DELAY: %d MS\n", edata);
-                        msleep(edata);
+                        usleep_range(edata * 1000, edata * 2000);
                        break;
                case IXGBE_DATA_NL:
                        hw_dbg(hw, "DATA:\n");
@@ -1220,7 +1222,7 @@ s32 ixgbe_read_i2c_byte_generic(struct ixgbe_hw *hw, u8 byte_offset,
                swfw_mask = IXGBE_GSSR_PHY0_SM;
        do {
-                if (ixgbe_acquire_swfw_sync(hw, swfw_mask) != 0) {
+                if (hw->mac.ops.acquire_swfw_sync(hw, swfw_mask) != 0) {
                        status = IXGBE_ERR_SWFW_SYNC;
                        goto read_byte_out;
                }
@@ -1267,7 +1269,7 @@ s32 ixgbe_read_i2c_byte_generic(struct ixgbe_hw *hw, u8 byte_offset,
                break;
 fail:
-                ixgbe_release_swfw_sync(hw, swfw_mask);
+                hw->mac.ops.release_swfw_sync(hw, swfw_mask);
                msleep(100);
                ixgbe_i2c_bus_clear(hw);
                retry++;
@@ -1278,7 +1280,7 @@ fail:
        } while (retry < max_retry);
-        ixgbe_release_swfw_sync(hw, swfw_mask);
+        hw->mac.ops.release_swfw_sync(hw, swfw_mask);
 read_byte_out:
        return status;
@@ -1306,7 +1308,7 @@ s32 ixgbe_write_i2c_byte_generic(struct ixgbe_hw *hw, u8 byte_offset,
        else
                swfw_mask = IXGBE_GSSR_PHY0_SM;
-        if (ixgbe_acquire_swfw_sync(hw, swfw_mask) != 0) {
+        if (hw->mac.ops.acquire_swfw_sync(hw, swfw_mask) != 0) {
                status = IXGBE_ERR_SWFW_SYNC;
                goto write_byte_out;
        }
@@ -1350,7 +1352,7 @@ fail:
                        hw_dbg(hw, "I2C byte write error.\n");
        } while (retry < max_retry);
-        ixgbe_release_swfw_sync(hw, swfw_mask);
+        hw->mac.ops.release_swfw_sync(hw, swfw_mask);
 write_byte_out:
        return status;
diff --git a/drivers/net/ixgbe/ixgbe_sriov.c b/drivers/net/ixgbe/ixgbe_sriov.c
index 6e50d8328942..ac99b0458fe2 100644
--- a/drivers/net/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ixgbe/ixgbe_sriov.c
@@ -82,6 +82,21 @@ static int ixgbe_set_vf_multicasts(struct ixgbe_adapter *adapter,
        return 0;
 }
+static void ixgbe_restore_vf_macvlans(struct ixgbe_adapter *adapter)
+{
+        struct ixgbe_hw *hw = &adapter->hw;
+        struct list_head *pos;
+        struct vf_macvlans *entry;
+        list_for_each(pos, &adapter->vf_mvs.l) {
+                entry = list_entry(pos, struct vf_macvlans, l);
+                if (entry->free == false)
+                        hw->mac.ops.set_rar(hw, entry->rar_entry,
+                                            entry->vf_macvlan,
+                                            entry->vf, IXGBE_RAH_AV);
+        }
+}
 void ixgbe_restore_vf_multicasts(struct ixgbe_adapter *adapter)
 {
        struct ixgbe_hw *hw = &adapter->hw;
@@ -102,6 +117,9 @@ void ixgbe_restore_vf_multicasts(struct ixgbe_adapter *adapter)
                        IXGBE_WRITE_REG(hw, IXGBE_MTA(vector_reg), mta_reg);
                }
        }
+        /* Restore any VF macvlans */
+        ixgbe_restore_vf_macvlans(adapter);
 }
 static int ixgbe_set_vf_vlan(struct ixgbe_adapter *adapter, int add, int vid,
@@ -110,7 +128,7 @@ static int ixgbe_set_vf_vlan(struct ixgbe_adapter *adapter, int add, int vid,
        return adapter->hw.mac.ops.set_vfta(&adapter->hw, vid, vf, (bool)add);
 }
-void ixgbe_set_vf_lpe(struct ixgbe_adapter *adapter, u32 *msgbuf)
+static void ixgbe_set_vf_lpe(struct ixgbe_adapter *adapter, u32 *msgbuf)
 {
        struct ixgbe_hw *hw = &adapter->hw;
        int new_mtu = msgbuf[1];
@@ -200,6 +218,61 @@ static int ixgbe_set_vf_mac(struct ixgbe_adapter *adapter,
        return 0;
 }
+static int ixgbe_set_vf_macvlan(struct ixgbe_adapter *adapter,
+                                int vf, int index, unsigned char *mac_addr)
+{
+        struct ixgbe_hw *hw = &adapter->hw;
+        struct list_head *pos;
+        struct vf_macvlans *entry;
+        if (index <= 1) {
+                list_for_each(pos, &adapter->vf_mvs.l) {
+                        entry = list_entry(pos, struct vf_macvlans, l);
+                        if (entry->vf == vf) {
+                                entry->vf = -1;
+                                entry->free = true;
+                                entry->is_macvlan = false;
+                                hw->mac.ops.clear_rar(hw, entry->rar_entry);
+                        }
+                }
+        }
+        /*
+         * If index was zero then we were asked to clear the uc list
+         * for the VF.  We're done.
+         */
+        if (!index)
+                return 0;
+        entry = NULL;
+        list_for_each(pos, &adapter->vf_mvs.l) {
+                entry = list_entry(pos, struct vf_macvlans, l);
+                if (entry->free)
+                        break;
+        }
+        /*
+         * If we traversed the entire list and didn't find a free entry
+         * then we're out of space on the RAR table.  Also entry may
+         * be NULL because the original memory allocation for the list
+         * failed, which is not fatal but does mean we can't support
+         * VF requests for MACVLAN because we couldn't allocate
+         * memory for the list management required.
+         */
+        if (!entry || !entry->free)
+                return -ENOSPC;
+        entry->free = false;
+        entry->is_macvlan = true;
+        entry->vf = vf;
+        memcpy(entry->vf_macvlan, mac_addr, ETH_ALEN);
+        hw->mac.ops.set_rar(hw, entry->rar_entry, mac_addr, vf, IXGBE_RAH_AV);
+        return 0;
+}
 int ixgbe_vf_configuration(struct pci_dev *pdev, unsigned int event_mask)
 {
        unsigned char vf_mac_addr[6];
@@ -251,12 +324,12 @@ static inline void ixgbe_vf_reset_msg(struct ixgbe_adapter *adapter, u32 vf)
 static int ixgbe_rcv_msg_from_vf(struct ixgbe_adapter *adapter, u32 vf)
 {
        u32 mbx_size = IXGBE_VFMAILBOX_SIZE;
-        u32 msgbuf[mbx_size];
+        u32 msgbuf[IXGBE_VFMAILBOX_SIZE];
        struct ixgbe_hw *hw = &adapter->hw;
        s32 retval;
        int entries;
        u16 *hash_list;
-        int add, vid;
+        int add, vid, index;
        u8 *new_mac;
        retval = ixgbe_read_mbx(hw, msgbuf, mbx_size, vf);
@@ -345,6 +418,24 @@ static int ixgbe_rcv_msg_from_vf(struct ixgbe_adapter *adapter, u32 vf)
                        retval = ixgbe_set_vf_vlan(adapter, add, vid, vf);
                }
                break;
+        case IXGBE_VF_SET_MACVLAN:
+                index = (msgbuf[0] & IXGBE_VT_MSGINFO_MASK) >>
+                        IXGBE_VT_MSGINFO_SHIFT;
+                /*
+                 * If the VF is allowed to set MAC filters then turn off
+                 * anti-spoofing to avoid false positives.  An index
+                 * greater than 0 will indicate the VF is setting a
+                 * macvlan MAC filter.
+                 */
+                if (index > 0 && adapter->antispoofing_enabled) {
+                        hw->mac.ops.set_mac_anti_spoofing(hw, false,
+                                                          adapter->num_vfs);
+                        hw->mac.ops.set_vlan_anti_spoofing(hw, false, vf);
+                        adapter->antispoofing_enabled = false;
+                }
+                retval = ixgbe_set_vf_macvlan(adapter, vf, index,
+                                              (unsigned char *)(&msgbuf[1]));
+                break;
        default:
                e_err(drv, "Unhandled Msg %8.8x\n", msgbuf[0]);
                retval = IXGBE_ERR_MBX;
@@ -452,7 +543,8 @@ int ixgbe_ndo_set_vf_vlan(struct net_device *netdev, int vf, u16 vlan, u8 qos)
                        goto out;
                ixgbe_set_vmvir(adapter, vlan | (qos << VLAN_PRIO_SHIFT), vf);
                ixgbe_set_vmolr(hw, vf, false);
-                hw->mac.ops.set_vlan_anti_spoofing(hw, true, vf);
+                if (adapter->antispoofing_enabled)
+                        hw->mac.ops.set_vlan_anti_spoofing(hw, true, vf);
                adapter->vfinfo[vf].pf_vlan = vlan;
                adapter->vfinfo[vf].pf_qos = qos;
                dev_info(&adapter->pdev->dev,
diff --git a/drivers/net/ixgbe/ixgbe_type.h b/drivers/net/ixgbe/ixgbe_type.h
index 25c1fb7eda06..fa43f2507f43 100644
--- a/drivers/net/ixgbe/ixgbe_type.h
+++ b/drivers/net/ixgbe/ixgbe_type.h
@@ -58,9 +58,11 @@
 #define IXGBE_DEV_ID_82599_SFP_FCOE      0x1529
 #define IXGBE_SUBDEV_ID_82599_SFP        0x11A9
 #define IXGBE_DEV_ID_82599_SFP_EM        0x1507
+#define IXGBE_DEV_ID_82599_SFP_SF2       0x154D
 #define IXGBE_DEV_ID_82599_XAUI_LOM      0x10FC
 #define IXGBE_DEV_ID_82599_COMBO_BACKPLANE 0x10F8
 #define IXGBE_SUBDEV_ID_82599_KX4_KR_MEZZ  0x000C
+#define IXGBE_DEV_ID_82599_LS            0x154F
 #define IXGBE_DEV_ID_X540T               0x1528
 /* General Registers */
@@ -163,6 +165,9 @@
                         (0x0D018 + ((_i - 64) * 0x40)))
 #define IXGBE_RXDCTL(_i) (((_i) < 64) ? (0x01028 + ((_i) * 0x40)) : \
                          (0x0D028 + ((_i - 64) * 0x40)))
+#define IXGBE_RSCCTL(_i) (((_i) < 64) ? (0x0102C + ((_i) * 0x40)) : \
+                          (0x0D02C + ((_i - 64) * 0x40)))
+#define IXGBE_RSCDBU     0x03028
 #define IXGBE_RDDCC      0x02F20
 #define IXGBE_RXMEMWRAP  0x03190
 #define IXGBE_STARCTRL   0x03024
@@ -227,17 +232,23 @@
 #define IXGBE_VLVF(_i)  (0x0F100 + ((_i) * 4))  /* 64 of these (0-63) */
 #define IXGBE_VLVFB(_i) (0x0F200 + ((_i) * 4))  /* 128 of these (0-127) */
 #define IXGBE_VMVIR(_i) (0x08000 + ((_i) * 4))  /* 64 of these (0-63) */
-#define IXGBE_VT_CTL    0x051B0
+#define IXGBE_VT_CTL         0x051B0
-#define IXGBE_VFRE(_i)  (0x051E0 + ((_i) * 4))
+#define IXGBE_PFMAILBOX(_i)  (0x04B00 + (4 * (_i))) /* 64 total */
-#define IXGBE_VFTE(_i)  (0x08110 + ((_i) * 4))
+#define IXGBE_PFMBMEM(_i)    (0x13000 + (64 * (_i))) /* 64 Mailboxes, 16 DW each */
-#define IXGBE_VMECM(_i) (0x08790 + ((_i) * 4))
+#define IXGBE_PFMBICR(_i)    (0x00710 + (4 * (_i))) /* 4 total */
-#define IXGBE_QDE       0x2F04
+#define IXGBE_PFMBIMR(_i)    (0x00720 + (4 * (_i))) /* 4 total */
-#define IXGBE_VMOLR(_i) (0x0F000 + ((_i) * 4)) /* 64 total */
+#define IXGBE_VFRE(_i)       (0x051E0 + ((_i) * 4))
-#define IXGBE_UTA(_i)   (0x0F400 + ((_i) * 4))
+#define IXGBE_VFTE(_i)       (0x08110 + ((_i) * 4))
-#define IXGBE_VMRCTL(_i)        (0x0F600 + ((_i) * 4))
+#define IXGBE_VMECM(_i)      (0x08790 + ((_i) * 4))
-#define IXGBE_VMRVLAN(_i)       (0x0F610 + ((_i) * 4))
+#define IXGBE_QDE            0x2F04
-#define IXGBE_VMRVM(_i)         (0x0F630 + ((_i) * 4))
+#define IXGBE_VMTXSW(_i)     (0x05180 + ((_i) * 4)) /* 2 total */
-#define IXGBE_L34T_IMIR(_i)      (0x0E800 + ((_i) * 4)) /*128 of these (0-127)*/
+#define IXGBE_VMOLR(_i)      (0x0F000 + ((_i) * 4)) /* 64 total */
+#define IXGBE_UTA(_i)        (0x0F400 + ((_i) * 4))
+#define IXGBE_MRCTL(_i)      (0x0F600 + ((_i) * 4))
+#define IXGBE_VMRVLAN(_i)    (0x0F610 + ((_i) * 4))
+#define IXGBE_VMRVM(_i)      (0x0F630 + ((_i) * 4))
+#define IXGBE_L34T_IMIR(_i)  (0x0E800 + ((_i) * 4)) /*128 of these (0-127)*/
+#define IXGBE_RXFECCERR0         0x051B8
 #define IXGBE_LLITHRESH 0x0EC90
 #define IXGBE_IMIR(_i)  (0x05A80 + ((_i) * 4))  /* 8 of these (0-7) */
 #define IXGBE_IMIREXT(_i)       (0x05AA0 + ((_i) * 4))  /* 8 of these (0-7) */
@@ -364,7 +375,7 @@
 #define IXGBE_WUFC_FLX5 0x00200000 /* Flexible Filter 5 Enable */
 #define IXGBE_WUFC_FLX_FILTERS     0x000F0000 /* Mask for 4 flex filters */
 #define IXGBE_WUFC_EXT_FLX_FILTERS 0x00300000 /* Mask for Ext. flex filters */
-#define IXGBE_WUFC_ALL_FILTERS     0x003F00FF /* Mask for all 6 wakeup filters*/
+#define IXGBE_WUFC_ALL_FILTERS     0x003F00FF /* Mask for all wakeup filters */
 #define IXGBE_WUFC_FLX_OFFSET      16 /* Offset to the Flexible Filters bits */
 /* Wake Up Status */
@@ -406,7 +417,6 @@
 #define IXGBE_SECTXSTAT         0x08804
 #define IXGBE_SECTXBUFFAF       0x08808
 #define IXGBE_SECTXMINIFG       0x08810
-#define IXGBE_SECTXSTAT         0x08804
 #define IXGBE_SECRXCTRL         0x08D00
 #define IXGBE_SECRXSTAT         0x08D04
@@ -499,21 +509,6 @@
 #define IXGBE_SECTXCTRL_STORE_FORWARD_ENABLE    0x4
-/* HW RSC registers */
-#define IXGBE_RSCCTL(_i) (((_i) < 64) ? (0x0102C + ((_i) * 0x40)) : \
-                          (0x0D02C + ((_i - 64) * 0x40)))
-#define IXGBE_RSCDBU      0x03028
-#define IXGBE_RSCCTL_RSCEN          0x01
-#define IXGBE_RSCCTL_MAXDESC_1      0x00
-#define IXGBE_RSCCTL_MAXDESC_4      0x04
-#define IXGBE_RSCCTL_MAXDESC_8      0x08
-#define IXGBE_RSCCTL_MAXDESC_16     0x0C
-#define IXGBE_RXDADV_RSCCNT_SHIFT     17
-#define IXGBE_GPIE_RSC_DELAY_SHIFT    11
-#define IXGBE_RXDADV_RSCCNT_MASK    0x001E0000
-#define IXGBE_RSCDBU_RSCACKDIS      0x00000080
-#define IXGBE_RDRXCTL_RSCFRSTSIZE   0x003E0000
 /* DCB registers */
 #define IXGBE_RTRPCS      0x02430
 #define IXGBE_RTTDCS      0x04900
@@ -522,6 +517,7 @@
 #define IXGBE_RTRUP2TC    0x03020
 #define IXGBE_RTTUP2TC    0x0C800
 #define IXGBE_RTRPT4C(_i) (0x02140 + ((_i) * 4)) /* 8 of these (0-7) */
+#define IXGBE_TXLLQ(_i)   (0x082E0 + ((_i) * 4)) /* 4 of these (0-3) */
 #define IXGBE_RTRPT4S(_i) (0x02160 + ((_i) * 4)) /* 8 of these (0-7) */
 #define IXGBE_RTTDT2C(_i) (0x04910 + ((_i) * 4)) /* 8 of these (0-7) */
 #define IXGBE_RTTDT2S(_i) (0x04930 + ((_i) * 4)) /* 8 of these (0-7) */
@@ -540,7 +536,7 @@
        (IXGBE_RTTBCNRC_RF_DEC_MASK << IXGBE_RTTBCNRC_RF_INT_SHIFT)
-/* FCoE registers */
+/* FCoE DMA Context Registers */
 #define IXGBE_FCPTRL    0x02410 /* FC User Desc. PTR Low */
 #define IXGBE_FCPTRH    0x02414 /* FC USer Desc. PTR High */
 #define IXGBE_FCBUFF    0x02418 /* FC Buffer Control */
@@ -677,6 +673,10 @@
 #define IXGBE_FCOEDWRC  0x0242C /* Number of FCoE DWords Received */
 #define IXGBE_FCOEPTC   0x08784 /* Number of FCoE Packets Transmitted */
 #define IXGBE_FCOEDWTC  0x08788 /* Number of FCoE DWords Transmitted */
+#define IXGBE_O2BGPTC   0x041C4
+#define IXGBE_O2BSPC    0x087B0
+#define IXGBE_B2OSPC    0x041C0
+#define IXGBE_B2OGPRC   0x02F90
 #define IXGBE_PCRC8ECL  0x0E810
 #define IXGBE_PCRC8ECH  0x0E811
 #define IXGBE_PCRC8ECH_MASK     0x1F
@@ -742,17 +742,10 @@
 #define IXGBE_PBACLR_82599      0x11068
 #define IXGBE_CIAA_82599        0x11088
 #define IXGBE_CIAD_82599        0x1108C
-#define IXGBE_PCIE_DIAG_0_82599 0x11090
+#define IXGBE_PICAUSE           0x110B0
-#define IXGBE_PCIE_DIAG_1_82599 0x11094
+#define IXGBE_PIENA             0x110B8
-#define IXGBE_PCIE_DIAG_2_82599 0x11098
-#define IXGBE_PCIE_DIAG_3_82599 0x1109C
-#define IXGBE_PCIE_DIAG_4_82599 0x110A0
-#define IXGBE_PCIE_DIAG_5_82599 0x110A4
-#define IXGBE_PCIE_DIAG_6_82599 0x110A8
-#define IXGBE_PCIE_DIAG_7_82599 0x110C0
-#define IXGBE_INTRPT_CSR_82599  0x110B0
-#define IXGBE_INTRPT_MASK_82599 0x110B8
 #define IXGBE_CDQ_MBR_82599     0x110B4
+#define IXGBE_PCIESPARE         0x110BC
 #define IXGBE_MISC_REG_82599    0x110F0
 #define IXGBE_ECC_CTRL_0_82599  0x11100
 #define IXGBE_ECC_CTRL_1_82599  0x11104
@@ -785,7 +778,19 @@
 #define IXGBE_SYSTIML    0x08C0C /* System time register Low - RO */
 #define IXGBE_SYSTIMH    0x08C10 /* System time register High - RO */
 #define IXGBE_TIMINCA    0x08C14 /* Increment attributes register - RW */
-#define IXGBE_RXUDP      0x08C1C /* Time Sync Rx UDP Port - RW */
+#define IXGBE_TIMADJL    0x08C18 /* Time Adjustment Offset register Low - RW */
+#define IXGBE_TIMADJH    0x08C1C /* Time Adjustment Offset register High - RW */
+#define IXGBE_TSAUXC     0x08C20 /* TimeSync Auxiliary Control register - RW */
+#define IXGBE_TRGTTIML0  0x08C24 /* Target Time Register 0 Low - RW */
+#define IXGBE_TRGTTIMH0  0x08C28 /* Target Time Register 0 High - RW */
+#define IXGBE_TRGTTIML1  0x08C2C /* Target Time Register 1 Low - RW */
+#define IXGBE_TRGTTIMH1  0x08C30 /* Target Time Register 1 High - RW */
+#define IXGBE_FREQOUT0   0x08C34 /* Frequency Out 0 Control register - RW */
+#define IXGBE_FREQOUT1   0x08C38 /* Frequency Out 1 Control register - RW */
+#define IXGBE_AUXSTMPL0  0x08C3C /* Auxiliary Time Stamp 0 register Low - RO */
+#define IXGBE_AUXSTMPH0  0x08C40 /* Auxiliary Time Stamp 0 register High - RO */
+#define IXGBE_AUXSTMPL1  0x08C44 /* Auxiliary Time Stamp 1 register Low - RO */
+#define IXGBE_AUXSTMPH1  0x08C48 /* Auxiliary Time Stamp 1 register High - RO */
 /* Diagnostic Registers */
 #define IXGBE_RDSTATCTL   0x02C20
@@ -829,8 +834,20 @@
 #define IXGBE_TXDATARDPTR(_i)   (0x0C720 + ((_i) * 4)) /* 8 of these C720-C72C*/
 #define IXGBE_TXDESCRDPTR(_i)   (0x0C730 + ((_i) * 4)) /* 8 of these C730-C73C*/
 #define IXGBE_PCIEECCCTL 0x1106C
+#define IXGBE_RXWRPTR(_i)       (0x03100 + ((_i) * 4)) /* 8 of these 3100-310C*/
+#define IXGBE_RXUSED(_i)        (0x03120 + ((_i) * 4)) /* 8 of these 3120-312C*/
+#define IXGBE_RXRDPTR(_i)       (0x03140 + ((_i) * 4)) /* 8 of these 3140-314C*/
+#define IXGBE_RXRDWRPTR(_i)     (0x03160 + ((_i) * 4)) /* 8 of these 3160-310C*/
+#define IXGBE_TXWRPTR(_i)       (0x0C100 + ((_i) * 4)) /* 8 of these C100-C10C*/
+#define IXGBE_TXUSED(_i)        (0x0C120 + ((_i) * 4)) /* 8 of these C120-C12C*/
+#define IXGBE_TXRDPTR(_i)       (0x0C140 + ((_i) * 4)) /* 8 of these C140-C14C*/
+#define IXGBE_TXRDWRPTR(_i)     (0x0C160 + ((_i) * 4)) /* 8 of these C160-C10C*/
 #define IXGBE_PCIEECCCTL0 0x11100
 #define IXGBE_PCIEECCCTL1 0x11104
+#define IXGBE_RXDBUECC  0x03F70
+#define IXGBE_TXDBUECC  0x0CF70
+#define IXGBE_RXDBUEST 0x03F74
+#define IXGBE_TXDBUEST 0x0CF74
 #define IXGBE_PBTXECC   0x0C300
 #define IXGBE_PBRXECC   0x03300
 #define IXGBE_GHECCR    0x110B0
@@ -871,6 +888,7 @@
 #define IXGBE_AUTOC3    0x042AC
 #define IXGBE_ANLP1     0x042B0
 #define IXGBE_ANLP2     0x042B4
+#define IXGBE_MACC      0x04330
 #define IXGBE_ATLASCTL  0x04800
 #define IXGBE_MMNGC     0x042D0
 #define IXGBE_ANLPNP1   0x042D4
@@ -883,14 +901,49 @@
 #define IXGBE_MPVC      0x04318
 #define IXGBE_SGMIIC    0x04314
+/* Statistics Registers */
+#define IXGBE_RXNFGPC      0x041B0
+#define IXGBE_RXNFGBCL     0x041B4
+#define IXGBE_RXNFGBCH     0x041B8
+#define IXGBE_RXDGPC       0x02F50
+#define IXGBE_RXDGBCL      0x02F54
+#define IXGBE_RXDGBCH      0x02F58
+#define IXGBE_RXDDGPC      0x02F5C
+#define IXGBE_RXDDGBCL     0x02F60
+#define IXGBE_RXDDGBCH     0x02F64
+#define IXGBE_RXLPBKGPC    0x02F68
+#define IXGBE_RXLPBKGBCL   0x02F6C
+#define IXGBE_RXLPBKGBCH   0x02F70
+#define IXGBE_RXDLPBKGPC   0x02F74
+#define IXGBE_RXDLPBKGBCL  0x02F78
+#define IXGBE_RXDLPBKGBCH  0x02F7C
+#define IXGBE_TXDGPC       0x087A0
+#define IXGBE_TXDGBCL      0x087A4
+#define IXGBE_TXDGBCH      0x087A8
+#define IXGBE_RXDSTATCTRL 0x02F40
+/* Copper Pond 2 link timeout */
 #define IXGBE_VALIDATE_LINK_READY_TIMEOUT 50
 /* Omer CORECTL */
 #define IXGBE_CORECTL           0x014F00
 /* BARCTRL */
-#define IXGBE_BARCTRL           0x110F4
+#define IXGBE_BARCTRL               0x110F4
-#define IXGBE_BARCTRL_FLSIZE    0x0700
+#define IXGBE_BARCTRL_FLSIZE        0x0700
-#define IXGBE_BARCTRL_CSRSIZE   0x2000
+#define IXGBE_BARCTRL_FLSIZE_SHIFT  8
+#define IXGBE_BARCTRL_CSRSIZE       0x2000
+/* RSCCTL Bit Masks */
+#define IXGBE_RSCCTL_RSCEN          0x01
+#define IXGBE_RSCCTL_MAXDESC_1      0x00
+#define IXGBE_RSCCTL_MAXDESC_4      0x04
+#define IXGBE_RSCCTL_MAXDESC_8      0x08
+#define IXGBE_RSCCTL_MAXDESC_16     0x0C
+/* RSCDBU Bit Masks */
+#define IXGBE_RSCDBU_RSCSMALDIS_MASK    0x0000007F
+#define IXGBE_RSCDBU_RSCACKDIS          0x00000080
 /* RDRXCTL Bit Masks */
 #define IXGBE_RDRXCTL_RDMTS_1_2     0x00000000 /* Rx Desc Min Threshold Size */
@@ -898,6 +951,8 @@
 #define IXGBE_RDRXCTL_MVMEN         0x00000020
 #define IXGBE_RDRXCTL_DMAIDONE      0x00000008 /* DMA init cycle done */
 #define IXGBE_RDRXCTL_AGGDIS        0x00010000 /* Aggregation disable */
+#define IXGBE_RDRXCTL_RSCFRSTSIZE   0x003E0000 /* RSC First packet size */
+#define IXGBE_RDRXCTL_RSCLLIDIS     0x00800000 /* Disable RSC compl on LLI */
 #define IXGBE_RDRXCTL_RSCACKC       0x02000000 /* must set 1 when RSC enabled */
 #define IXGBE_RDRXCTL_FCOE_WRFIX    0x04000000 /* must set 1 when RSC enabled */
@@ -969,8 +1024,8 @@
 #define IXGBE_MSCA_OP_CODE_SHIFT     26 /* OP CODE shift */
 #define IXGBE_MSCA_ADDR_CYCLE        0x00000000 /* OP CODE 00 (addr cycle) */
 #define IXGBE_MSCA_WRITE             0x04000000 /* OP CODE 01 (write) */
-#define IXGBE_MSCA_READ              0x08000000 /* OP CODE 10 (read) */
+#define IXGBE_MSCA_READ              0x0C000000 /* OP CODE 11 (read) */
-#define IXGBE_MSCA_READ_AUTOINC      0x0C000000 /* OP CODE 11 (read, auto inc)*/
+#define IXGBE_MSCA_READ_AUTOINC      0x08000000 /* OP CODE 10 (read, auto inc)*/
 #define IXGBE_MSCA_ST_CODE_MASK      0x30000000 /* ST Code mask */
 #define IXGBE_MSCA_ST_CODE_SHIFT     28 /* ST Code shift */
 #define IXGBE_MSCA_NEW_PROTOCOL      0x00000000 /* ST CODE 00 (new protocol) */
@@ -1057,6 +1112,7 @@
 #define IXGBE_GPIE_EIMEN         0x00000040 /* Immediate Interrupt Enable */
 #define IXGBE_GPIE_EIAME         0x40000000
 #define IXGBE_GPIE_PBA_SUPPORT   0x80000000
+#define IXGBE_GPIE_RSC_DELAY_SHIFT 11
 #define IXGBE_GPIE_VTMODE_MASK   0x0000C000 /* VT Mode Mask */
 #define IXGBE_GPIE_VTMODE_16     0x00004000 /* 16 VFs 8 queues per VF */
 #define IXGBE_GPIE_VTMODE_32     0x00008000 /* 32 VFs 4 queues per VF */
@@ -1291,6 +1347,11 @@
 #define IXGBE_FTQF_POOL_SHIFT           8
 #define IXGBE_FTQF_5TUPLE_MASK_MASK     0x0000001F
 #define IXGBE_FTQF_5TUPLE_MASK_SHIFT    25
+#define IXGBE_FTQF_SOURCE_ADDR_MASK     0x1E
+#define IXGBE_FTQF_DEST_ADDR_MASK       0x1D
+#define IXGBE_FTQF_SOURCE_PORT_MASK     0x1B
+#define IXGBE_FTQF_DEST_PORT_MASK       0x17
+#define IXGBE_FTQF_PROTOCOL_COMP_MASK   0x0F
 #define IXGBE_FTQF_POOL_MASK_EN         0x40000000
 #define IXGBE_FTQF_QUEUE_ENABLE         0x80000000
@@ -1333,11 +1394,11 @@
 *
 * Current filters:
 *    EAPOL 802.1x (0x888e): Filter 0
- *    BCN (0x8904):          Filter 1
+ *    FCoE (0x8906):         Filter 2
 *    1588 (0x88f7):         Filter 3
+ *    FIP  (0x8914):         Filter 4
 */
 #define IXGBE_ETQF_FILTER_EAPOL          0
-#define IXGBE_ETQF_FILTER_BCN            1
 #define IXGBE_ETQF_FILTER_FCOE           2
 #define IXGBE_ETQF_FILTER_1588           3
 #define IXGBE_ETQF_FILTER_FIP            4
@@ -1448,6 +1509,11 @@
 #define IXGBE_AUTOC2_10G_XFI (0x1 << IXGBE_AUTOC2_10G_SERIAL_PMA_PMD_SHIFT)
 #define IXGBE_AUTOC2_10G_SFI (0x2 << IXGBE_AUTOC2_10G_SERIAL_PMA_PMD_SHIFT)
+#define IXGBE_MACC_FLU       0x00000001
+#define IXGBE_MACC_FSV_10G   0x00030000
+#define IXGBE_MACC_FS        0x00040000
+#define IXGBE_MAC_RX2TX_LPBK 0x00000002
 /* LINKS Bit Masks */
 #define IXGBE_LINKS_KX_AN_COMP  0x80000000
 #define IXGBE_LINKS_UP          0x40000000
@@ -1501,7 +1567,6 @@
 #define IXGBE_ANLP1_ASM_PAUSE           0x0800
 #define IXGBE_ANLP1_AN_STATE_MASK       0x000f0000
 /* SW Semaphore Register bitmasks */
 #define IXGBE_SWSM_SMBI 0x00000001 /* Driver Semaphore bit */
 #define IXGBE_SWSM_SWESMBI 0x00000002 /* FW Semaphore bit */
@@ -1514,6 +1579,10 @@
 #define IXGBE_GSSR_PHY1_SM    0x0004
 #define IXGBE_GSSR_MAC_CSR_SM 0x0008
 #define IXGBE_GSSR_FLASH_SM   0x0010
+#define IXGBE_GSSR_SW_MNG_SM  0x0400
+/* FW Status register bitmask */
+#define IXGBE_FWSTS_FWRI    0x00000200 /* Firmware Reset Indication */
 /* EEC Register */
 #define IXGBE_EEC_SK        0x00000001 /* EEPROM Clock */
@@ -1534,6 +1603,7 @@
 /* EEPROM Addressing bits based on type (0-small, 1-large) */
 #define IXGBE_EEC_ADDR_SIZE 0x00000400
 #define IXGBE_EEC_SIZE      0x00007800 /* EEPROM Size */
+#define IXGBE_EERD_MAX_ADDR 0x00003FFF /* EERD alows 14 bits for addr. */
 #define IXGBE_EEC_SIZE_SHIFT          11
 #define IXGBE_EEPROM_WORD_SIZE_SHIFT  6
@@ -1563,8 +1633,10 @@
 #define IXGBE_FW_PTR            0x0F
 #define IXGBE_PBANUM0_PTR       0x15
 #define IXGBE_PBANUM1_PTR       0x16
-#define IXGBE_DEVICE_CAPS       0x2C
+#define IXGBE_FREE_SPACE_PTR    0X3E
 #define IXGBE_SAN_MAC_ADDR_PTR  0x28
+#define IXGBE_DEVICE_CAPS       0x2C
+#define IXGBE_SERIAL_NUMBER_MAC_ADDR 0x11
 #define IXGBE_PCIE_MSIX_82599_CAPS  0x72
 #define IXGBE_PCIE_MSIX_82598_CAPS  0x62
@@ -1601,6 +1673,10 @@
 #define IXGBE_ETH_LENGTH_OF_ADDRESS   6
+#define IXGBE_EEPROM_PAGE_SIZE_MAX       128
+#define IXGBE_EEPROM_RD_BUFFER_MAX_COUNT 512 /* EEPROM words # read in burst */
+#define IXGBE_EEPROM_WR_BUFFER_MAX_COUNT 256 /* EEPROM words # wr in burst */
 #ifndef IXGBE_EEPROM_GRANT_ATTEMPTS
 #define IXGBE_EEPROM_GRANT_ATTEMPTS 1000 /* EEPROM # attempts to gain grant */
 #endif
@@ -1616,14 +1692,25 @@
 #define IXGBE_FLUDONE_ATTEMPTS 20000
 #endif
+#define IXGBE_PCIE_CTRL2                 0x5   /* PCIe Control 2 Offset */
+#define IXGBE_PCIE_CTRL2_DUMMY_ENABLE    0x8   /* Dummy Function Enable */
+#define IXGBE_PCIE_CTRL2_LAN_DISABLE     0x2   /* LAN PCI Disable */
+#define IXGBE_PCIE_CTRL2_DISABLE_SELECT  0x1   /* LAN Disable Select */
 #define IXGBE_SAN_MAC_ADDR_PORT0_OFFSET  0x0
 #define IXGBE_SAN_MAC_ADDR_PORT1_OFFSET  0x3
 #define IXGBE_DEVICE_CAPS_ALLOW_ANY_SFP  0x1
 #define IXGBE_DEVICE_CAPS_FCOE_OFFLOADS  0x2
+#define IXGBE_FW_LESM_PARAMETERS_PTR     0x2
+#define IXGBE_FW_LESM_STATE_1            0x1
+#define IXGBE_FW_LESM_STATE_ENABLED      0x8000 /* LESM Enable bit */
 #define IXGBE_FW_PASSTHROUGH_PATCH_CONFIG_PTR   0x4
-#define IXGBE_FW_PATCH_VERSION_4   0x7
+#define IXGBE_FW_PATCH_VERSION_4         0x7
+#define IXGBE_FCOE_IBA_CAPS_BLK_PTR         0x33 /* iSCSI/FCOE block */
-/* Alternative SAN MAC Address Block */
+#define IXGBE_FCOE_IBA_CAPS_FCOE            0x20 /* FCOE flags */
+#define IXGBE_ISCSI_FCOE_BLK_PTR            0x17 /* iSCSI/FCOE block */
+#define IXGBE_ISCSI_FCOE_FLAGS_OFFSET       0x0  /* FCOE flags */
+#define IXGBE_ISCSI_FCOE_FLAGS_ENABLE       0x1  /* FCOE flags enable bit */
 #define IXGBE_ALT_SAN_MAC_ADDR_BLK_PTR      0x27 /* Alt. SAN MAC block */
 #define IXGBE_ALT_SAN_MAC_ADDR_CAPS_OFFSET  0x0 /* Alt. SAN MAC capability */
 #define IXGBE_ALT_SAN_MAC_ADDR_PORT0_OFFSET 0x1 /* Alt. SAN MAC 0 offset */
@@ -1688,6 +1775,7 @@
 /* Transmit Config masks */
 #define IXGBE_TXDCTL_ENABLE     0x02000000 /* Enable specific Tx Queue */
 #define IXGBE_TXDCTL_SWFLSH     0x04000000 /* Tx Desc. write-back flushing */
+#define IXGBE_TXDCTL_WTHRESH_SHIFT      16 /* shift to WTHRESH bits */
 /* Enable short packet padding to 64 bytes */
 #define IXGBE_TX_PAD_ENABLE     0x00000400
 #define IXGBE_JUMBO_FRAME_ENABLE 0x00000004  /* Allow jumbo frames */
@@ -1701,9 +1789,9 @@
 #define IXGBE_RXCTRL_RXEN       0x00000001  /* Enable Receiver */
 #define IXGBE_RXCTRL_DMBYPS     0x00000002  /* Descriptor Monitor Bypass */
 #define IXGBE_RXDCTL_ENABLE     0x02000000  /* Enable specific Rx Queue */
-#define IXGBE_RXDCTL_VME        0x40000000  /* VLAN mode enable */
 #define IXGBE_RXDCTL_RLPMLMASK  0x00003FFF  /* Only supported on the X540 */
 #define IXGBE_RXDCTL_RLPML_EN   0x00008000
+#define IXGBE_RXDCTL_VME        0x40000000  /* VLAN mode enable */
 #define IXGBE_FCTRL_SBP 0x00000002 /* Store Bad Packet */
 #define IXGBE_FCTRL_MPE 0x00000100 /* Multicast Promiscuous Ena*/
@@ -1719,6 +1807,8 @@
 #define IXGBE_MFLCN_RPFCE       0x00000004 /* Receive Priority FC Enable */
 #define IXGBE_MFLCN_RFCE        0x00000008 /* Receive FC Enable */
+#define IXGBE_MFLCN_RPFCE_SHIFT          4
 /* Multiple Receive Queue Control */
 #define IXGBE_MRQC_RSSEN                 0x00000001  /* RSS Enable */
 #define IXGBE_MRQC_MRQE_MASK                    0xF /* Bits 3:0 */
@@ -1859,6 +1949,8 @@
 #define IXGBE_RXDADV_PKTTYPE_MASK       0x0000FFF0
 #define IXGBE_RXDADV_PKTTYPE_MASK_EX    0x0001FFF0
 #define IXGBE_RXDADV_HDRBUFLEN_MASK     0x00007FE0
+#define IXGBE_RXDADV_RSCCNT_MASK        0x001E0000
+#define IXGBE_RXDADV_RSCCNT_SHIFT       17
 #define IXGBE_RXDADV_HDRBUFLEN_SHIFT    5
 #define IXGBE_RXDADV_SPLITHEADER_EN     0x00001000
 #define IXGBE_RXDADV_SPH                0x8000
@@ -1934,15 +2026,6 @@
 #define IXGBE_VFLRE(_i)                  (((_i & 1) ? 0x001C0 : 0x00600))
 #define IXGBE_VFLREC(_i)                 (0x00700 + (_i * 4))
-/* Little Endian defines */
-#ifndef __le32
-#define __le32  u32
-#endif
-#ifndef __le64
-#define __le64  u64
-#endif
 enum ixgbe_fdir_pballoc_type {
        IXGBE_FDIR_PBALLOC_64K = 0,
        IXGBE_FDIR_PBALLOC_128K,
@@ -2141,8 +2224,6 @@ typedef u32 ixgbe_link_speed;
                                        IXGBE_LINK_SPEED_1GB_FULL | \
                                        IXGBE_LINK_SPEED_10GB_FULL)
-#define IXGBE_PCIE_DEV_CTRL_2 0xC8
-#define PCIE_COMPL_TO_VALUE 0x05
 /* Physical layer type */
 typedef u32 ixgbe_physical_layer;
@@ -2315,6 +2396,7 @@ enum ixgbe_sfp_type {
 enum ixgbe_media_type {
        ixgbe_media_type_unknown = 0,
        ixgbe_media_type_fiber,
+        ixgbe_media_type_fiber_lco,
        ixgbe_media_type_copper,
        ixgbe_media_type_backplane,
        ixgbe_media_type_cx4,
@@ -2478,6 +2560,10 @@ struct ixgbe_hw_stats {
        u64 fcoeptc;
        u64 fcoedwrc;
        u64 fcoedwtc;
+        u64 b2ospc;
+        u64 b2ogprc;
+        u64 o2bgptc;
+        u64 o2bspc;
 };
 /* forward declaration */
@@ -2491,7 +2577,9 @@ typedef u8* (*ixgbe_mc_addr_itr) (struct ixgbe_hw *hw, u8 **mc_addr_ptr,
 struct ixgbe_eeprom_operations {
        s32 (*init_params)(struct ixgbe_hw *);
        s32 (*read)(struct ixgbe_hw *, u16, u16 *);
+        s32 (*read_buffer)(struct ixgbe_hw *, u16, u16, u16 *);
        s32 (*write)(struct ixgbe_hw *, u16, u16);
+        s32 (*write_buffer)(struct ixgbe_hw *, u16, u16, u16 *);
        s32 (*validate_checksum)(struct ixgbe_hw *, u16 *);
        s32 (*update_checksum)(struct ixgbe_hw *);
        u16 (*calc_checksum)(struct ixgbe_hw *);
@@ -2577,6 +2665,7 @@ struct ixgbe_eeprom_info {
        u32                             semaphore_delay;
        u16                             word_size;
        u16                             address_bits;
+        u16                             word_page_size;
 };
 #define IXGBE_FLAGS_DOUBLE_RESET_REQUIRED       0x01
@@ -2597,6 +2686,7 @@ struct ixgbe_mac_info {
        u32                             vft_size;
        u32                             num_rar_entries;
        u32                             rar_highwater;
+        u32                             rx_pb_size;
        u32                             max_tx_queues;
        u32                             max_rx_queues;
        u32                             max_msix_vectors;
diff --git a/drivers/net/ixgbe/ixgbe_x540.c b/drivers/net/ixgbe/ixgbe_x540.c
index d9323c08f5c7..4ed687be2fe3 100644
--- a/drivers/net/ixgbe/ixgbe_x540.c
+++ b/drivers/net/ixgbe/ixgbe_x540.c
@@ -37,6 +37,7 @@
 #define IXGBE_X540_RAR_ENTRIES   128
 #define IXGBE_X540_MC_TBL_SIZE   128
 #define IXGBE_X540_VFT_TBL_SIZE  128
+#define IXGBE_X540_RX_PB_SIZE    384
 static s32 ixgbe_update_flash_X540(struct ixgbe_hw *hw);
 static s32 ixgbe_poll_flash_update_done_X540(struct ixgbe_hw *hw);
@@ -226,6 +227,28 @@ mac_reset_top:
 }
 /**
+ *  ixgbe_start_hw_X540 - Prepare hardware for Tx/Rx
+ *  @hw: pointer to hardware structure
+ *
+ *  Starts the hardware using the generic start_hw function
+ *  and the generation start_hw function.
+ *  Then performs revision-specific operations, if any.
+ **/
+static s32 ixgbe_start_hw_X540(struct ixgbe_hw *hw)
+{
+        s32 ret_val = 0;
+        ret_val = ixgbe_start_hw_generic(hw);
+        if (ret_val != 0)
+                goto out;
+        ret_val = ixgbe_start_hw_gen2(hw);
+        hw->mac.rx_pb_size = IXGBE_X540_RX_PB_SIZE;
+out:
+        return ret_val;
+}
+/**
 *  ixgbe_get_supported_physical_layer_X540 - Returns physical layer type
 *  @hw: pointer to hardware structure
 *
@@ -281,74 +304,105 @@ static s32 ixgbe_init_eeprom_params_X540(struct ixgbe_hw *hw)
 }
 /**
- * ixgbe_read_eerd_X540 - Read EEPROM word using EERD
+ *  ixgbe_read_eerd_X540- Read EEPROM word using EERD
- * @hw: pointer to hardware structure
+ *  @hw: pointer to hardware structure
- * @offset: offset of word in the EEPROM to read
+ *  @offset: offset of  word in the EEPROM to read
- * @data: word read from the EERPOM
+ *  @data: word read from the EEPROM
+ *
+ *  Reads a 16 bit word from the EEPROM using the EERD register.
 **/
 static s32 ixgbe_read_eerd_X540(struct ixgbe_hw *hw, u16 offset, u16 *data)
 {
-        s32 status;
+        s32 status = 0;
-        if (hw->mac.ops.acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) == 0)
+        if (hw->mac.ops.acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) ==
+            0)
                status = ixgbe_read_eerd_generic(hw, offset, data);
        else
                status = IXGBE_ERR_SWFW_SYNC;
-        ixgbe_release_swfw_sync_X540(hw, IXGBE_GSSR_EEP_SM);
+        hw->mac.ops.release_swfw_sync(hw, IXGBE_GSSR_EEP_SM);
        return status;
 }
 /**
- * ixgbe_write_eewr_X540 - Write EEPROM word using EEWR
+ *  ixgbe_read_eerd_buffer_X540 - Read EEPROM word(s) using EERD
- * @hw: pointer to hardware structure
+ *  @hw: pointer to hardware structure
- * @offset: offset of  word in the EEPROM to write
+ *  @offset: offset of  word in the EEPROM to read
- * @data: word write to the EEPROM
+ *  @words: number of words
+ *  @data: word(s) read from the EEPROM
 *
- * Write a 16 bit word to the EEPROM using the EEWR register.
+ *  Reads a 16 bit word(s) from the EEPROM using the EERD register.
 **/
-static s32 ixgbe_write_eewr_X540(struct ixgbe_hw *hw, u16 offset, u16 data)
+static s32 ixgbe_read_eerd_buffer_X540(struct ixgbe_hw *hw,
+                                       u16 offset, u16 words, u16 *data)
 {
-        u32 eewr;
+        s32 status = 0;
-        s32 status;
-        hw->eeprom.ops.init_params(hw);
+        if (hw->mac.ops.acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) ==
+            0)
+                status = ixgbe_read_eerd_buffer_generic(hw, offset,
+                                                        words, data);
+        else
+                status = IXGBE_ERR_SWFW_SYNC;
-        if (offset >= hw->eeprom.word_size) {
+        hw->mac.ops.release_swfw_sync(hw, IXGBE_GSSR_EEP_SM);
-                status = IXGBE_ERR_EEPROM;
+        return status;
-                goto out;
+}
-        }
-        eewr = (offset << IXGBE_EEPROM_RW_ADDR_SHIFT) |
+/**
-               (data << IXGBE_EEPROM_RW_REG_DATA) |
+ *  ixgbe_write_eewr_X540 - Write EEPROM word using EEWR
-               IXGBE_EEPROM_RW_REG_START;
+ *  @hw: pointer to hardware structure
+ *  @offset: offset of  word in the EEPROM to write
+ *  @data: word write to the EEPROM
+ *
+ *  Write a 16 bit word to the EEPROM using the EEWR register.
+ **/
+static s32 ixgbe_write_eewr_X540(struct ixgbe_hw *hw, u16 offset, u16 data)
+{
+        s32 status = 0;
-        if (hw->mac.ops.acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) == 0) {
+        if (hw->mac.ops.acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) == 0)
-                status = ixgbe_poll_eerd_eewr_done(hw, IXGBE_NVM_POLL_WRITE);
+                status = ixgbe_write_eewr_generic(hw, offset, data);
-                if (status != 0) {
+        else
-                        hw_dbg(hw, "Eeprom write EEWR timed out\n");
+                status = IXGBE_ERR_SWFW_SYNC;
-                        goto out;
-                }
-                IXGBE_WRITE_REG(hw, IXGBE_EEWR, eewr);
+        hw->mac.ops.release_swfw_sync(hw, IXGBE_GSSR_EEP_SM);
+        return status;
+}
-                status = ixgbe_poll_eerd_eewr_done(hw, IXGBE_NVM_POLL_WRITE);
+/**
-                if (status != 0) {
+ *  ixgbe_write_eewr_buffer_X540 - Write EEPROM word(s) using EEWR
-                        hw_dbg(hw, "Eeprom write EEWR timed out\n");
+ *  @hw: pointer to hardware structure
-                        goto out;
+ *  @offset: offset of  word in the EEPROM to write
-                }
+ *  @words: number of words
-        } else {
+ *  @data: word(s) write to the EEPROM
+ *
+ *  Write a 16 bit word(s) to the EEPROM using the EEWR register.
+ **/
+static s32 ixgbe_write_eewr_buffer_X540(struct ixgbe_hw *hw,
+                                        u16 offset, u16 words, u16 *data)
+{
+        s32 status = 0;
+        if (hw->mac.ops.acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) ==
+            0)
+                status = ixgbe_write_eewr_buffer_generic(hw, offset,
+                                                         words, data);
+        else
                status = IXGBE_ERR_SWFW_SYNC;
-        }
-out:
+        hw->mac.ops.release_swfw_sync(hw, IXGBE_GSSR_EEP_SM);
-        ixgbe_release_swfw_sync_X540(hw, IXGBE_GSSR_EEP_SM);
        return status;
 }
 /**
- * ixgbe_calc_eeprom_checksum_X540 - Calculates and returns the checksum
+ *  ixgbe_calc_eeprom_checksum_X540 - Calculates and returns the checksum
- * @hw: pointer to hardware structure
+ *
+ *  This function does not use synchronization for EERD and EEWR. It can
+ *  be used internally by function which utilize ixgbe_acquire_swfw_sync_X540.
+ *
+ *  @hw: pointer to hardware structure
 **/
 static u16 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)
 {
@@ -359,9 +413,15 @@ static u16 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)
        u16 pointer = 0;
        u16 word = 0;
+        /*
+         * Do not use hw->eeprom.ops.read because we do not want to take
+         * the synchronization semaphores here. Instead use
+         * ixgbe_read_eerd_generic
+         */
        /* Include 0x0-0x3F in the checksum */
        for (i = 0; i < IXGBE_EEPROM_CHECKSUM; i++) {
-                if (hw->eeprom.ops.read(hw, i, &word) != 0) {
+                if (ixgbe_read_eerd_generic(hw, i, &word) != 0) {
                        hw_dbg(hw, "EEPROM read failed\n");
                        break;
                }
@@ -376,7 +436,7 @@ static u16 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)
                if (i == IXGBE_PHY_PTR || i == IXGBE_OPTION_ROM_PTR)
                        continue;
-                if (hw->eeprom.ops.read(hw, i, &pointer) != 0) {
+                if (ixgbe_read_eerd_generic(hw, i, &pointer) != 0) {
                        hw_dbg(hw, "EEPROM read failed\n");
                        break;
                }
@@ -386,7 +446,7 @@ static u16 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)
                    pointer >= hw->eeprom.word_size)
                        continue;
-                if (hw->eeprom.ops.read(hw, pointer, &length) != 0) {
+                if (ixgbe_read_eerd_generic(hw, pointer, &length) != 0) {
                        hw_dbg(hw, "EEPROM read failed\n");
                        break;
                }
@@ -397,7 +457,7 @@ static u16 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)
                        continue;
                for (j = pointer+1; j <= pointer+length; j++) {
-                        if (hw->eeprom.ops.read(hw, j, &word) != 0) {
+                        if (ixgbe_read_eerd_generic(hw, j, &word) != 0) {
                                hw_dbg(hw, "EEPROM read failed\n");
                                break;
                        }
@@ -411,6 +471,62 @@ static u16 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)
 }
 /**
+ *  ixgbe_validate_eeprom_checksum_X540 - Validate EEPROM checksum
+ *  @hw: pointer to hardware structure
+ *  @checksum_val: calculated checksum
+ *
+ *  Performs checksum calculation and validates the EEPROM checksum.  If the
+ *  caller does not need checksum_val, the value can be NULL.
+ **/
+static s32 ixgbe_validate_eeprom_checksum_X540(struct ixgbe_hw *hw,
+                                               u16 *checksum_val)
+{
+        s32 status;
+        u16 checksum;
+        u16 read_checksum = 0;
+        /*
+         * Read the first word from the EEPROM. If this times out or fails, do
+         * not continue or we could be in for a very long wait while every
+         * EEPROM read fails
+         */
+        status = hw->eeprom.ops.read(hw, 0, &checksum);
+        if (status != 0) {
+                hw_dbg(hw, "EEPROM read failed\n");
+                goto out;
+        }
+        if (hw->mac.ops.acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) == 0) {
+                checksum = hw->eeprom.ops.calc_checksum(hw);
+                /*
+                 * Do not use hw->eeprom.ops.read because we do not want to take
+                 * the synchronization semaphores twice here.
+                 */
+                ixgbe_read_eerd_generic(hw, IXGBE_EEPROM_CHECKSUM,
+                                        &read_checksum);
+                /*
+                 * Verify read checksum from EEPROM is the same as
+                 * calculated checksum
+                 */
+                if (read_checksum != checksum)
+                        status = IXGBE_ERR_EEPROM_CHECKSUM;
+                /* If the user cares, return the calculated checksum */
+                if (checksum_val)
+                        *checksum_val = checksum;
+        } else {
+                status = IXGBE_ERR_SWFW_SYNC;
+        }
+        hw->mac.ops.release_swfw_sync(hw, IXGBE_GSSR_EEP_SM);
+out:
+        return status;
+}
+/**
 * ixgbe_update_eeprom_checksum_X540 - Updates the EEPROM checksum and flash
 * @hw: pointer to hardware structure
 *
@@ -421,11 +537,35 @@ static u16 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)
 static s32 ixgbe_update_eeprom_checksum_X540(struct ixgbe_hw *hw)
 {
        s32 status;
+        u16 checksum;
+        /*
+         * Read the first word from the EEPROM. If this times out or fails, do
+         * not continue or we could be in for a very long wait while every
+         * EEPROM read fails
+         */
+        status = hw->eeprom.ops.read(hw, 0, &checksum);
+        if (status != 0)
+                hw_dbg(hw, "EEPROM read failed\n");
-        status = ixgbe_update_eeprom_checksum_generic(hw);
+        if (hw->mac.ops.acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) == 0) {
+                checksum = hw->eeprom.ops.calc_checksum(hw);
+                /*
+                 * Do not use hw->eeprom.ops.write because we do not want to
+                 * take the synchronization semaphores twice here.
+                 */
+                status = ixgbe_write_eewr_generic(hw, IXGBE_EEPROM_CHECKSUM,
+                                                  checksum);
-        if (status)
+        if (status == 0)
                status = ixgbe_update_flash_X540(hw);
+        else
+                status = IXGBE_ERR_SWFW_SYNC;
+        }
+        hw->mac.ops.release_swfw_sync(hw, IXGBE_GSSR_EEP_SM);
        return status;
 }
@@ -452,7 +592,7 @@ static s32 ixgbe_update_flash_X540(struct ixgbe_hw *hw)
        IXGBE_WRITE_REG(hw, IXGBE_EEC, flup);
        status = ixgbe_poll_flash_update_done_X540(hw);
-        if (status)
+        if (status == 0)
                hw_dbg(hw, "Flash update complete\n");
        else
                hw_dbg(hw, "Flash update time out\n");
@@ -466,11 +606,10 @@ static s32 ixgbe_update_flash_X540(struct ixgbe_hw *hw)
                }
                status = ixgbe_poll_flash_update_done_X540(hw);
-                if (status)
+                if (status == 0)
                        hw_dbg(hw, "Flash update complete\n");
                else
                        hw_dbg(hw, "Flash update time out\n");
        }
 out:
        return status;
@@ -542,7 +681,7 @@ static s32 ixgbe_acquire_swfw_sync_X540(struct ixgbe_hw *hw, u16 mask)
                         * resource (swmask)
                         */
                        ixgbe_release_swfw_sync_semaphore(hw);
-                        msleep(5);
+                        usleep_range(5000, 10000);
                }
        }
@@ -564,7 +703,7 @@ static s32 ixgbe_acquire_swfw_sync_X540(struct ixgbe_hw *hw, u16 mask)
                }
        }
-        msleep(5);
+        usleep_range(5000, 10000);
        return 0;
 }
@@ -588,7 +727,7 @@ static void ixgbe_release_swfw_sync_X540(struct ixgbe_hw *hw, u16 mask)
        IXGBE_WRITE_REG(hw, IXGBE_SWFW_SYNC, swfw_sync);
        ixgbe_release_swfw_sync_semaphore(hw);
-        msleep(5);
+        usleep_range(5000, 10000);
 }
 /**
@@ -658,10 +797,70 @@ static void ixgbe_release_swfw_sync_semaphore(struct ixgbe_hw *hw)
        IXGBE_WRITE_FLUSH(hw);
 }
+/**
+ * ixgbe_blink_led_start_X540 - Blink LED based on index.
+ * @hw: pointer to hardware structure
+ * @index: led number to blink
+ *
+ * Devices that implement the version 2 interface:
+ *   X540
+ **/
+static s32 ixgbe_blink_led_start_X540(struct ixgbe_hw *hw, u32 index)
+{
+        u32 macc_reg;
+        u32 ledctl_reg;
+        /*
+         * In order for the blink bit in the LED control register
+         * to work, link and speed must be forced in the MAC. We
+         * will reverse this when we stop the blinking.
+         */
+        macc_reg = IXGBE_READ_REG(hw, IXGBE_MACC);
+        macc_reg |= IXGBE_MACC_FLU | IXGBE_MACC_FSV_10G | IXGBE_MACC_FS;
+        IXGBE_WRITE_REG(hw, IXGBE_MACC, macc_reg);
+        /* Set the LED to LINK_UP + BLINK. */
+        ledctl_reg = IXGBE_READ_REG(hw, IXGBE_LEDCTL);
+        ledctl_reg &= ~IXGBE_LED_MODE_MASK(index);
+        ledctl_reg |= IXGBE_LED_BLINK(index);
+        IXGBE_WRITE_REG(hw, IXGBE_LEDCTL, ledctl_reg);
+        IXGBE_WRITE_FLUSH(hw);
+        return 0;
+}
+/**
+ * ixgbe_blink_led_stop_X540 - Stop blinking LED based on index.
+ * @hw: pointer to hardware structure
+ * @index: led number to stop blinking
+ *
+ * Devices that implement the version 2 interface:
+ *   X540
+ **/
+static s32 ixgbe_blink_led_stop_X540(struct ixgbe_hw *hw, u32 index)
+{
+        u32 macc_reg;
+        u32 ledctl_reg;
+        /* Restore the LED to its default value. */
+        ledctl_reg = IXGBE_READ_REG(hw, IXGBE_LEDCTL);
+        ledctl_reg &= ~IXGBE_LED_MODE_MASK(index);
+        ledctl_reg |= IXGBE_LED_LINK_ACTIVE << IXGBE_LED_MODE_SHIFT(index);
+        ledctl_reg &= ~IXGBE_LED_BLINK(index);
+        IXGBE_WRITE_REG(hw, IXGBE_LEDCTL, ledctl_reg);
+        /* Unforce link and speed in the MAC. */
+        macc_reg = IXGBE_READ_REG(hw, IXGBE_MACC);
+        macc_reg &= ~(IXGBE_MACC_FLU | IXGBE_MACC_FSV_10G | IXGBE_MACC_FS);
+        IXGBE_WRITE_REG(hw, IXGBE_MACC, macc_reg);
+        IXGBE_WRITE_FLUSH(hw);
+        return 0;
+}
 static struct ixgbe_mac_operations mac_ops_X540 = {
        .init_hw                = &ixgbe_init_hw_generic,
        .reset_hw               = &ixgbe_reset_hw_X540,
-        .start_hw               = &ixgbe_start_hw_generic,
+        .start_hw               = &ixgbe_start_hw_X540,
        .clear_hw_cntrs         = &ixgbe_clear_hw_cntrs_generic,
        .get_media_type         = &ixgbe_get_media_type_X540,
        .get_supported_physical_layer =
@@ -669,7 +868,7 @@ static struct ixgbe_mac_operations mac_ops_X540 = {
        .enable_rx_dma          = &ixgbe_enable_rx_dma_generic,
        .get_mac_addr           = &ixgbe_get_mac_addr_generic,
        .get_san_mac_addr       = &ixgbe_get_san_mac_addr_generic,
-        .get_device_caps        = NULL,
+        .get_device_caps        = &ixgbe_get_device_caps_generic,
        .get_wwn_prefix         = &ixgbe_get_wwn_prefix_generic,
        .stop_adapter           = &ixgbe_stop_adapter_generic,
        .get_bus_info           = &ixgbe_get_bus_info_generic,
@@ -681,8 +880,8 @@ static struct ixgbe_mac_operations mac_ops_X540 = {
        .get_link_capabilities  = &ixgbe_get_copper_link_capabilities_generic,
        .led_on                 = &ixgbe_led_on_generic,
        .led_off                = &ixgbe_led_off_generic,
-        .blink_led_start        = &ixgbe_blink_led_start_generic,
+        .blink_led_start        = &ixgbe_blink_led_start_X540,
-        .blink_led_stop         = &ixgbe_blink_led_stop_generic,
+        .blink_led_stop         = &ixgbe_blink_led_stop_X540,
        .set_rar                = &ixgbe_set_rar_generic,
        .clear_rar              = &ixgbe_clear_rar_generic,
        .set_vmdq               = &ixgbe_set_vmdq_generic,
@@ -705,9 +904,11 @@ static struct ixgbe_mac_operations mac_ops_X540 = {
 static struct ixgbe_eeprom_operations eeprom_ops_X540 = {
        .init_params            = &ixgbe_init_eeprom_params_X540,
        .read                   = &ixgbe_read_eerd_X540,
+        .read_buffer            = &ixgbe_read_eerd_buffer_X540,
        .write                  = &ixgbe_write_eewr_X540,
+        .write_buffer           = &ixgbe_write_eewr_buffer_X540,
        .calc_checksum          = &ixgbe_calc_eeprom_checksum_X540,
-        .validate_checksum      = &ixgbe_validate_eeprom_checksum_generic,
+        .validate_checksum      = &ixgbe_validate_eeprom_checksum_X540,
        .update_checksum        = &ixgbe_update_eeprom_checksum_X540,
 };
diff --git a/drivers/net/ixgbevf/ethtool.c b/drivers/net/ixgbevf/ethtool.c
index 0563ab29264e..deee3754b1f7 100644
--- a/drivers/net/ixgbevf/ethtool.c
+++ b/drivers/net/ixgbevf/ethtool.c
@@ -104,11 +104,13 @@ static int ixgbevf_get_settings(struct net_device *netdev,
        hw->mac.ops.check_link(hw, &link_speed, &link_up, false);
        if (link_up) {
-                ecmd->speed = (link_speed == IXGBE_LINK_SPEED_10GB_FULL) ?
+                ethtool_cmd_speed_set(
-                               SPEED_10000 : SPEED_1000;
+                        ecmd,
+                        (link_speed == IXGBE_LINK_SPEED_10GB_FULL) ?
+                        SPEED_10000 : SPEED_1000);
                ecmd->duplex = DUPLEX_FULL;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
diff --git a/drivers/net/ixgbevf/ixgbevf_main.c b/drivers/net/ixgbevf/ixgbevf_main.c
index 05fa7c85deed..d7ab202fb95c 100644
--- a/drivers/net/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ixgbevf/ixgbevf_main.c
@@ -1460,6 +1460,34 @@ static void ixgbevf_restore_vlan(struct ixgbevf_adapter *adapter)
        }
 }
+static int ixgbevf_write_uc_addr_list(struct net_device *netdev)
+{
+        struct ixgbevf_adapter *adapter = netdev_priv(netdev);
+        struct ixgbe_hw *hw = &adapter->hw;
+        int count = 0;
+        if ((netdev_uc_count(netdev)) > 10) {
+                printk(KERN_ERR "Too many unicast filters - No Space\n");
+                return -ENOSPC;
+        }
+        if (!netdev_uc_empty(netdev)) {
+                struct netdev_hw_addr *ha;
+                netdev_for_each_uc_addr(ha, netdev) {
+                        hw->mac.ops.set_uc_addr(hw, ++count, ha->addr);
+                        udelay(200);
+                }
+        } else {
+                /*
+                 * If the list is empty then send message to PF driver to
+                 * clear all macvlans on this VF.
+                 */
+                hw->mac.ops.set_uc_addr(hw, 0, NULL);
+        }
+        return count;
+}
 /**
 * ixgbevf_set_rx_mode - Multicast set
 * @netdev: network interface device structure
@@ -1476,6 +1504,8 @@ static void ixgbevf_set_rx_mode(struct net_device *netdev)
        /* reprogram multicast list */
        if (hw->mac.ops.update_mc_addr_list)
                hw->mac.ops.update_mc_addr_list(hw, netdev);
+        ixgbevf_write_uc_addr_list(netdev);
 }
 static void ixgbevf_napi_enable_all(struct ixgbevf_adapter *adapter)
diff --git a/drivers/net/ixgbevf/mbx.h b/drivers/net/ixgbevf/mbx.h
index b2b5bf5daa3d..ea393eb03f3a 100644
--- a/drivers/net/ixgbevf/mbx.h
+++ b/drivers/net/ixgbevf/mbx.h
@@ -81,6 +81,7 @@
 #define IXGBE_VF_SET_MULTICAST    0x03 /* VF requests PF to set MC addr */
 #define IXGBE_VF_SET_VLAN         0x04 /* VF requests PF to set VLAN */
 #define IXGBE_VF_SET_LPE          0x05 /* VF requests PF to set VMOLR.LPE */
+#define IXGBE_VF_SET_MACVLAN      0x06 /* VF requests PF for unicast filter */
 /* length of permanent address message returned from PF */
 #define IXGBE_VF_PERMADDR_MSG_LEN 4
diff --git a/drivers/net/ixgbevf/vf.c b/drivers/net/ixgbevf/vf.c
index eecd3bf6833f..aa3682e8c473 100644
--- a/drivers/net/ixgbevf/vf.c
+++ b/drivers/net/ixgbevf/vf.c
@@ -216,6 +216,39 @@ static s32 ixgbevf_get_mac_addr_vf(struct ixgbe_hw *hw, u8 *mac_addr)
        return 0;
 }
+static s32 ixgbevf_set_uc_addr_vf(struct ixgbe_hw *hw, u32 index, u8 *addr)
+{
+        struct ixgbe_mbx_info *mbx = &hw->mbx;
+        u32 msgbuf[3];
+        u8 *msg_addr = (u8 *)(&msgbuf[1]);
+        s32 ret_val;
+        memset(msgbuf, 0, sizeof(msgbuf));
+        /*
+         * If index is one then this is the start of a new list and needs
+         * indication to the PF so it can do it's own list management.
+         * If it is zero then that tells the PF to just clear all of
+         * this VF's macvlans and there is no new list.
+         */
+        msgbuf[0] |= index << IXGBE_VT_MSGINFO_SHIFT;
+        msgbuf[0] |= IXGBE_VF_SET_MACVLAN;
+        if (addr)
+                memcpy(msg_addr, addr, 6);
+        ret_val = mbx->ops.write_posted(hw, msgbuf, 3);
+        if (!ret_val)
+                ret_val = mbx->ops.read_posted(hw, msgbuf, 3);
+        msgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;
+        if (!ret_val)
+                if (msgbuf[0] ==
+                    (IXGBE_VF_SET_MACVLAN | IXGBE_VT_MSGTYPE_NACK))
+                        ret_val = -ENOMEM;
+        return ret_val;
+}
 /**
 *  ixgbevf_set_rar_vf - set device MAC address
 *  @hw: pointer to hardware structure
@@ -378,6 +411,7 @@ static struct ixgbe_mac_operations ixgbevf_mac_ops = {
        .check_link          = ixgbevf_check_mac_link_vf,
        .set_rar             = ixgbevf_set_rar_vf,
        .update_mc_addr_list = ixgbevf_update_mc_addr_list_vf,
+        .set_uc_addr         = ixgbevf_set_uc_addr_vf,
        .set_vfta            = ixgbevf_set_vfta_vf,
 };
diff --git a/drivers/net/ixgbevf/vf.h b/drivers/net/ixgbevf/vf.h
index 23eb114c149f..10306b492ee6 100644
--- a/drivers/net/ixgbevf/vf.h
+++ b/drivers/net/ixgbevf/vf.h
@@ -62,6 +62,7 @@ struct ixgbe_mac_operations {
        /* RAR, Multicast, VLAN */
        s32 (*set_rar)(struct ixgbe_hw *, u32, u8 *, u32);
+        s32 (*set_uc_addr)(struct ixgbe_hw *, u32, u8 *);
        s32 (*init_rx_addrs)(struct ixgbe_hw *);
        s32 (*update_mc_addr_list)(struct ixgbe_hw *, struct net_device *);
        s32 (*enable_mc)(struct ixgbe_hw *);
diff --git a/drivers/net/jme.c b/drivers/net/jme.c
index 994c80939c7a..b5b174a8c149 100644
--- a/drivers/net/jme.c
+++ b/drivers/net/jme.c
@@ -2230,17 +2230,9 @@ jme_change_mtu(struct net_device *netdev, int new_mtu)
                jme_restart_rx_engine(jme);
        }
-        if (new_mtu > 1900) {
-                netdev->features &= ~(NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
-                                NETIF_F_TSO | NETIF_F_TSO6);
-        } else {
-                if (test_bit(JME_FLAG_TXCSUM, &jme->flags))
-                        netdev->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
-                if (test_bit(JME_FLAG_TSO, &jme->flags))
-                        netdev->features |= NETIF_F_TSO | NETIF_F_TSO6;
-        }
        netdev->mtu = new_mtu;
+        netdev_update_features(netdev);
        jme_reset_link(jme);
        return 0;
@@ -2563,7 +2555,8 @@ jme_set_settings(struct net_device *netdev,
        struct jme_adapter *jme = netdev_priv(netdev);
        int rc, fdc = 0;
-        if (ecmd->speed == SPEED_1000 && ecmd->autoneg != AUTONEG_ENABLE)
+        if (ethtool_cmd_speed(ecmd) == SPEED_1000
+            && ecmd->autoneg != AUTONEG_ENABLE)
                return -EINVAL;
        /*
@@ -2640,19 +2633,20 @@ jme_set_msglevel(struct net_device *netdev, u32 value)
 }
 static u32
-jme_get_rx_csum(struct net_device *netdev)
+jme_fix_features(struct net_device *netdev, u32 features)
 {
-        struct jme_adapter *jme = netdev_priv(netdev);
+        if (netdev->mtu > 1900)
-        return jme->reg_rxmcs & RXMCS_CHECKSUM;
+                features &= ~(NETIF_F_ALL_TSO | NETIF_F_ALL_CSUM);
+        return features;
 }
 static int
-jme_set_rx_csum(struct net_device *netdev, u32 on)
+jme_set_features(struct net_device *netdev, u32 features)
 {
        struct jme_adapter *jme = netdev_priv(netdev);
        spin_lock_bh(&jme->rxmcs_lock);
-        if (on)
+        if (features & NETIF_F_RXCSUM)
                jme->reg_rxmcs |= RXMCS_CHECKSUM;
        else
                jme->reg_rxmcs &= ~RXMCS_CHECKSUM;
@@ -2663,42 +2657,6 @@ jme_set_rx_csum(struct net_device *netdev, u32 on)
 }
 static int
-jme_set_tx_csum(struct net_device *netdev, u32 on)
-{
-        struct jme_adapter *jme = netdev_priv(netdev);
-        if (on) {
-                set_bit(JME_FLAG_TXCSUM, &jme->flags);
-                if (netdev->mtu <= 1900)
-                        netdev->features |=
-                                NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
-        } else {
-                clear_bit(JME_FLAG_TXCSUM, &jme->flags);
-                netdev->features &=
-                                ~(NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM);
-        }
-        return 0;
-}
-static int
-jme_set_tso(struct net_device *netdev, u32 on)
-{
-        struct jme_adapter *jme = netdev_priv(netdev);
-        if (on) {
-                set_bit(JME_FLAG_TSO, &jme->flags);
-                if (netdev->mtu <= 1900)
-                        netdev->features |= NETIF_F_TSO | NETIF_F_TSO6;
-        } else {
-                clear_bit(JME_FLAG_TSO, &jme->flags);
-                netdev->features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
-        }
-        return 0;
-}
-static int
 jme_nway_reset(struct net_device *netdev)
 {
        struct jme_adapter *jme = netdev_priv(netdev);
@@ -2839,11 +2797,6 @@ static const struct ethtool_ops jme_ethtool_ops = {
        .get_link               = jme_get_link,
        .get_msglevel           = jme_get_msglevel,
        .set_msglevel           = jme_set_msglevel,
-        .get_rx_csum            = jme_get_rx_csum,
-        .set_rx_csum            = jme_set_rx_csum,
-        .set_tx_csum            = jme_set_tx_csum,
-        .set_tso                = jme_set_tso,
-        .set_sg                 = ethtool_op_set_sg,
        .nway_reset             = jme_nway_reset,
        .get_eeprom_len         = jme_get_eeprom_len,
        .get_eeprom             = jme_get_eeprom,
@@ -2903,6 +2856,8 @@ static const struct net_device_ops jme_netdev_ops = {
        .ndo_change_mtu         = jme_change_mtu,
        .ndo_tx_timeout         = jme_tx_timeout,
        .ndo_vlan_rx_register   = jme_vlan_rx_register,
+        .ndo_fix_features       = jme_fix_features,
+        .ndo_set_features       = jme_set_features,
 };
 static int __devinit
@@ -2957,6 +2912,12 @@ jme_init_one(struct pci_dev *pdev,
        netdev->netdev_ops = &jme_netdev_ops;
        netdev->ethtool_ops             = &jme_ethtool_ops;
        netdev->watchdog_timeo          = TX_TIMEOUT;
+        netdev->hw_features             =       NETIF_F_IP_CSUM |
+                                                NETIF_F_IPV6_CSUM |
+                                                NETIF_F_SG |
+                                                NETIF_F_TSO |
+                                                NETIF_F_TSO6 |
+                                                NETIF_F_RXCSUM;
        netdev->features                =       NETIF_F_IP_CSUM |
                                                NETIF_F_IPV6_CSUM |
                                                NETIF_F_SG |
@@ -3040,8 +3001,9 @@ jme_init_one(struct pci_dev *pdev,
        jme->reg_txpfc = 0;
        jme->reg_pmcs = PMCS_MFEN;
        jme->reg_gpreg1 = GPREG1_DEFAULT;
-        set_bit(JME_FLAG_TXCSUM, &jme->flags);
-        set_bit(JME_FLAG_TSO, &jme->flags);
+        if (jme->reg_rxmcs & RXMCS_CHECKSUM)
+                netdev->features |= NETIF_F_RXCSUM;
        /*
         * Get Max Read Req Size from PCI Config Space
diff --git a/drivers/net/jme.h b/drivers/net/jme.h
index 8bf30451e821..e9aaeca96abc 100644
--- a/drivers/net/jme.h
+++ b/drivers/net/jme.h
@@ -468,8 +468,6 @@ struct jme_adapter {
 enum jme_flags_bits {
        JME_FLAG_MSI            = 1,
        JME_FLAG_SSET           = 2,
-        JME_FLAG_TXCSUM         = 3,
-        JME_FLAG_TSO            = 4,
        JME_FLAG_POLL           = 5,
        JME_FLAG_SHUTDOWN       = 6,
 };
diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c
index 7f7d5708a658..41ea5920c158 100644
--- a/drivers/net/ksz884x.c
+++ b/drivers/net/ksz884x.c
@@ -1221,7 +1221,6 @@ struct ksz_port_info {
 #define LINK_INT_WORKING                (1 << 0)
 #define SMALL_PACKET_TX_BUG             (1 << 1)
 #define HALF_DUPLEX_SIGNAL_BUG          (1 << 2)
-#define IPV6_CSUM_GEN_HACK              (1 << 3)
 #define RX_HUGE_FRAME                   (1 << 4)
 #define STP_SUPPORT                     (1 << 8)
@@ -3748,7 +3747,6 @@ static int hw_init(struct ksz_hw *hw)
                if (1 == rc)
                        hw->features |= HALF_DUPLEX_SIGNAL_BUG;
        }
-        hw->features |= IPV6_CSUM_GEN_HACK;
        return rc;
 }
@@ -4887,8 +4885,7 @@ static netdev_tx_t netdev_tx(struct sk_buff *skb, struct net_device *dev)
        left = hw_alloc_pkt(hw, skb->len, num);
        if (left) {
                if (left < num ||
-                                ((hw->features & IPV6_CSUM_GEN_HACK) &&
+                                ((CHECKSUM_PARTIAL == skb->ip_summed) &&
-                                (CHECKSUM_PARTIAL == skb->ip_summed) &&
                                (ETH_P_IPV6 == htons(skb->protocol)))) {
                        struct sk_buff *org_skb = skb;
@@ -6001,6 +5998,7 @@ static int netdev_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        struct dev_priv *priv = netdev_priv(dev);
        struct dev_info *hw_priv = priv->adapter;
        struct ksz_port *port = &priv->port;
+        u32 speed = ethtool_cmd_speed(cmd);
        int rc;
        /*
@@ -6009,11 +6007,11 @@ static int netdev_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
         */
        if (cmd->autoneg && priv->advertising == cmd->advertising) {
                cmd->advertising |= ADVERTISED_ALL;
-                if (10 == cmd->speed)
+                if (10 == speed)
                        cmd->advertising &=
                                ~(ADVERTISED_100baseT_Full |
                                ADVERTISED_100baseT_Half);
-                else if (100 == cmd->speed)
+                else if (100 == speed)
                        cmd->advertising &=
                                ~(ADVERTISED_10baseT_Full |
                                ADVERTISED_10baseT_Half);
@@ -6035,8 +6033,8 @@ static int netdev_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                port->force_link = 0;
        } else {
                port->duplex = cmd->duplex + 1;
-                if (cmd->speed != 1000)
+                if (1000 != speed)
-                        port->speed = cmd->speed;
+                        port->speed = speed;
                if (cmd->autoneg)
                        port->force_link = 0;
                else
@@ -6583,57 +6581,33 @@ static void netdev_get_ethtool_stats(struct net_device *dev,
 }
 /**
- * netdev_get_rx_csum - get receive checksum support
+ * netdev_set_features - set receive checksum support
 * @dev:        Network device.
- *
+ * @features:   New device features (offloads).
- * This function gets receive checksum support setting.
- *
- * Return true if receive checksum is enabled; false otherwise.
- */
-static u32 netdev_get_rx_csum(struct net_device *dev)
-{
-        struct dev_priv *priv = netdev_priv(dev);
-        struct dev_info *hw_priv = priv->adapter;
-        struct ksz_hw *hw = &hw_priv->hw;
-        return hw->rx_cfg &
-                (DMA_RX_CSUM_UDP |
-                DMA_RX_CSUM_TCP |
-                DMA_RX_CSUM_IP);
-}
-/**
- * netdev_set_rx_csum - set receive checksum support
- * @dev:        Network device.
- * @data:       Zero to disable receive checksum support.
 *
 * This function sets receive checksum support setting.
 *
 * Return 0 if successful; otherwise an error code.
 */
-static int netdev_set_rx_csum(struct net_device *dev, u32 data)
+static int netdev_set_features(struct net_device *dev, u32 features)
 {
        struct dev_priv *priv = netdev_priv(dev);
        struct dev_info *hw_priv = priv->adapter;
        struct ksz_hw *hw = &hw_priv->hw;
-        u32 new_setting = hw->rx_cfg;
-        if (data)
-                new_setting |=
-                        (DMA_RX_CSUM_UDP | DMA_RX_CSUM_TCP |
-                        DMA_RX_CSUM_IP);
-        else
-                new_setting &=
-                        ~(DMA_RX_CSUM_UDP | DMA_RX_CSUM_TCP |
-                        DMA_RX_CSUM_IP);
-        new_setting &= ~DMA_RX_CSUM_UDP;
        mutex_lock(&hw_priv->lock);
-        if (new_setting != hw->rx_cfg) {
-                hw->rx_cfg = new_setting;
+        /* see note in hw_setup() */
-                if (hw->enabled)
+        if (features & NETIF_F_RXCSUM)
-                        writel(hw->rx_cfg, hw->io + KS_DMA_RX_CTRL);
+                hw->rx_cfg |= DMA_RX_CSUM_TCP | DMA_RX_CSUM_IP;
-        }
+        else
+                hw->rx_cfg &= ~(DMA_RX_CSUM_TCP | DMA_RX_CSUM_IP);
+        if (hw->enabled)
+                writel(hw->rx_cfg, hw->io + KS_DMA_RX_CTRL);
        mutex_unlock(&hw_priv->lock);
        return 0;
 }
@@ -6658,12 +6632,6 @@ static struct ethtool_ops netdev_ethtool_ops = {
        .get_strings            = netdev_get_strings,
        .get_sset_count         = netdev_get_sset_count,
        .get_ethtool_stats      = netdev_get_ethtool_stats,
-        .get_rx_csum            = netdev_get_rx_csum,
-        .set_rx_csum            = netdev_set_rx_csum,
-        .get_tx_csum            = ethtool_op_get_tx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_csum,
-        .get_sg                 = ethtool_op_get_sg,
-        .set_sg                 = ethtool_op_set_sg,
 };
 /*
@@ -6828,14 +6796,15 @@ static int __init netdev_init(struct net_device *dev)
        /* 500 ms timeout */
        dev->watchdog_timeo = HZ / 2;
-        dev->features |= NETIF_F_IP_CSUM;
+        dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_RXCSUM;
        /*
         * Hardware does not really support IPv6 checksum generation, but
-         * driver actually runs faster with this on.  Refer IPV6_CSUM_GEN_HACK.
+         * driver actually runs faster with this on.
         */
-        dev->features |= NETIF_F_IPV6_CSUM;
+        dev->hw_features |= NETIF_F_IPV6_CSUM;
-        dev->features |= NETIF_F_SG;
+        dev->features |= dev->hw_features;
        sema_init(&priv->proc_sem, 1);
@@ -6860,6 +6829,7 @@ static const struct net_device_ops netdev_ops = {
        .ndo_start_xmit         = netdev_tx,
        .ndo_tx_timeout         = netdev_tx_timeout,
        .ndo_change_mtu         = netdev_change_mtu,
+        .ndo_set_features       = netdev_set_features,
        .ndo_set_mac_address    = netdev_set_mac_address,
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_do_ioctl           = netdev_ioctl,
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index d70fb76edb77..4ce9e5f2c069 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -174,7 +174,8 @@ static void loopback_setup(struct net_device *dev)
                | NETIF_F_HIGHDMA
                | NETIF_F_LLTX
                | NETIF_F_NETNS_LOCAL
-                | NETIF_F_VLAN_CHALLENGED;
+                | NETIF_F_VLAN_CHALLENGED
+                | NETIF_F_LOOPBACK;
        dev->ethtool_ops        = &loopback_ethtool_ops;
        dev->header_ops         = &eth_header_ops;
        dev->netdev_ops         = &loopback_ops;
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 79ccb54ab00c..629bd2649c0c 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -576,6 +576,11 @@ static irqreturn_t macb_interrupt(int irq, void *dev_id)
                 * add that if/when we get our hands on a full-blown MII PHY.
                 */
+                if (status & MACB_BIT(ISR_ROVR)) {
+                        /* We missed at least one packet */
+                        bp->hw_stats.rx_overruns++;
+                }
                if (status & MACB_BIT(HRESP)) {
                        /*
                         * TODO: Reset the hardware, and maybe move the printk
@@ -1024,7 +1029,8 @@ static struct net_device_stats *macb_get_stats(struct net_device *dev)
                                   hwstat->rx_jabbers +
                                   hwstat->rx_undersize_pkts +
                                   hwstat->rx_length_mismatch);
-        nstat->rx_over_errors = hwstat->rx_resource_errors;
+        nstat->rx_over_errors = hwstat->rx_resource_errors +
+                                   hwstat->rx_overruns;
        nstat->rx_crc_errors = hwstat->rx_fcs_errors;
        nstat->rx_frame_errors = hwstat->rx_align_errors;
        nstat->rx_fifo_errors = hwstat->rx_overruns;
@@ -1171,8 +1177,7 @@ static int __init macb_probe(struct platform_device *pdev)
        }
        dev->irq = platform_get_irq(pdev, 0);
-        err = request_irq(dev->irq, macb_interrupt, IRQF_SAMPLE_RANDOM,
+        err = request_irq(dev->irq, macb_interrupt, 0, dev->name, dev);
-                          dev->name, dev);
        if (err) {
                printk(KERN_ERR
                       "%s: Unable to request IRQ %d (error %d)\n",
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index d8e4e69ad0b9..d72a70615c0f 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -70,16 +70,17 @@ static void macvlan_hash_add(struct macvlan_dev *vlan)
        hlist_add_head_rcu(&vlan->hlist, &port->vlan_hash[addr[5]]);
 }
-static void macvlan_hash_del(struct macvlan_dev *vlan)
+static void macvlan_hash_del(struct macvlan_dev *vlan, bool sync)
 {
        hlist_del_rcu(&vlan->hlist);
-        synchronize_rcu();
+        if (sync)
+                synchronize_rcu();
 }
 static void macvlan_hash_change_addr(struct macvlan_dev *vlan,
                                        const unsigned char *addr)
 {
-        macvlan_hash_del(vlan);
+        macvlan_hash_del(vlan, true);
        /* Now that we are unhashed it is safe to change the device
         * address without confusing packet delivery.
         */
@@ -345,7 +346,7 @@ static int macvlan_stop(struct net_device *dev)
        dev_uc_del(lowerdev, dev->dev_addr);
 hash_del:
-        macvlan_hash_del(vlan);
+        macvlan_hash_del(vlan, !dev->dismantle);
        return 0;
 }
@@ -415,7 +416,7 @@ static struct lock_class_key macvlan_netdev_addr_lock_key;
 #define MACVLAN_FEATURES \
        (NETIF_F_SG | NETIF_F_ALL_CSUM | NETIF_F_HIGHDMA | NETIF_F_FRAGLIST | \
         NETIF_F_GSO | NETIF_F_TSO | NETIF_F_UFO | NETIF_F_GSO_ROBUST | \
-         NETIF_F_TSO_ECN | NETIF_F_TSO6 | NETIF_F_GRO)
+         NETIF_F_TSO_ECN | NETIF_F_TSO6 | NETIF_F_GRO | NETIF_F_RXCSUM)
 #define MACVLAN_STATE_MASK \
        ((1<<__LINK_STATE_NOCARRIER) | (1<<__LINK_STATE_DORMANT))
@@ -517,12 +518,6 @@ static void macvlan_ethtool_get_drvinfo(struct net_device *dev,
        snprintf(drvinfo->version, 32, "0.1");
 }
-static u32 macvlan_ethtool_get_rx_csum(struct net_device *dev)
-{
-        const struct macvlan_dev *vlan = netdev_priv(dev);
-        return dev_ethtool_get_rx_csum(vlan->lowerdev);
-}
 static int macvlan_ethtool_get_settings(struct net_device *dev,
                                        struct ethtool_cmd *cmd)
 {
@@ -530,18 +525,10 @@ static int macvlan_ethtool_get_settings(struct net_device *dev,
        return dev_ethtool_get_settings(vlan->lowerdev, cmd);
 }
-static u32 macvlan_ethtool_get_flags(struct net_device *dev)
-{
-        const struct macvlan_dev *vlan = netdev_priv(dev);
-        return dev_ethtool_get_flags(vlan->lowerdev);
-}
 static const struct ethtool_ops macvlan_ethtool_ops = {
        .get_link               = ethtool_op_get_link,
        .get_settings           = macvlan_ethtool_get_settings,
-        .get_rx_csum            = macvlan_ethtool_get_rx_csum,
        .get_drvinfo            = macvlan_ethtool_get_drvinfo,
-        .get_flags              = macvlan_ethtool_get_flags,
 };
 static const struct net_device_ops macvlan_netdev_ops = {
@@ -598,8 +585,8 @@ static int macvlan_port_create(struct net_device *dev)
        err = netdev_rx_handler_register(dev, macvlan_handle_frame, port);
        if (err)
                kfree(port);
+        else
-        dev->priv_flags |= IFF_MACVLAN_PORT;
+                dev->priv_flags |= IFF_MACVLAN_PORT;
        return err;
 }
@@ -791,6 +778,7 @@ static int macvlan_device_event(struct notifier_block *unused,
        struct net_device *dev = ptr;
        struct macvlan_dev *vlan, *next;
        struct macvlan_port *port;
+        LIST_HEAD(list_kill);
        if (!macvlan_port_exists(dev))
                return NOTIFY_DONE;
@@ -816,7 +804,9 @@ static int macvlan_device_event(struct notifier_block *unused,
                        break;
                list_for_each_entry_safe(vlan, next, &port->vlans, list)
-                        vlan->dev->rtnl_link_ops->dellink(vlan->dev, NULL);
+                        vlan->dev->rtnl_link_ops->dellink(vlan->dev, &list_kill);
+                unregister_netdevice_many(&list_kill);
+                list_del(&list_kill);
                break;
        case NETDEV_PRE_TYPE_CHANGE:
                /* Forbid underlaying device to change its type. */
diff --git a/drivers/net/mdio.c b/drivers/net/mdio.c
index e85bf04cf813..16fbb11d92ac 100644
--- a/drivers/net/mdio.c
+++ b/drivers/net/mdio.c
@@ -176,6 +176,9 @@ static u32 mdio45_get_an(const struct mdio_if_info *mdio, u16 addr)
 * @npage_adv: Modes currently advertised on next pages
 * @npage_lpa: Modes advertised by link partner on next pages
 *
+ * The @ecmd parameter is expected to have been cleared before calling
+ * mdio45_ethtool_gset_npage().
+ *
 * Since the CSRs for auto-negotiation using next pages are not fully
 * standardised, this function does not attempt to decode them.  The
 * caller must pass them in.
@@ -185,6 +188,7 @@ void mdio45_ethtool_gset_npage(const struct mdio_if_info *mdio,
                               u32 npage_adv, u32 npage_lpa)
 {
        int reg;
+        u32 speed;
        ecmd->transceiver = XCVR_INTERNAL;
        ecmd->phy_address = mdio->prtad;
@@ -287,33 +291,36 @@ void mdio45_ethtool_gset_npage(const struct mdio_if_info *mdio,
                if (modes & (ADVERTISED_10000baseT_Full |
                             ADVERTISED_10000baseKX4_Full |
                             ADVERTISED_10000baseKR_Full)) {
-                        ecmd->speed = SPEED_10000;
+                        speed = SPEED_10000;
                        ecmd->duplex = DUPLEX_FULL;
                } else if (modes & (ADVERTISED_1000baseT_Full |
                                    ADVERTISED_1000baseT_Half |
                                    ADVERTISED_1000baseKX_Full)) {
-                        ecmd->speed = SPEED_1000;
+                        speed = SPEED_1000;
                        ecmd->duplex = !(modes & ADVERTISED_1000baseT_Half);
                } else if (modes & (ADVERTISED_100baseT_Full |
                                    ADVERTISED_100baseT_Half)) {
-                        ecmd->speed = SPEED_100;
+                        speed = SPEED_100;
                        ecmd->duplex = !!(modes & ADVERTISED_100baseT_Full);
                } else {
-                        ecmd->speed = SPEED_10;
+                        speed = SPEED_10;
                        ecmd->duplex = !!(modes & ADVERTISED_10baseT_Full);
                }
        } else {
                /* Report forced settings */
                reg = mdio->mdio_read(mdio->dev, mdio->prtad, MDIO_MMD_PMAPMD,
                                      MDIO_CTRL1);
-                ecmd->speed = (((reg & MDIO_PMA_CTRL1_SPEED1000) ? 100 : 1) *
+                speed = (((reg & MDIO_PMA_CTRL1_SPEED1000) ? 100 : 1)
-                               ((reg & MDIO_PMA_CTRL1_SPEED100) ? 100 : 10));
+                         * ((reg & MDIO_PMA_CTRL1_SPEED100) ? 100 : 10));
                ecmd->duplex = (reg & MDIO_CTRL1_FULLDPLX ||
-                                ecmd->speed == SPEED_10000);
+                                speed == SPEED_10000);
        }
+        ethtool_cmd_speed_set(ecmd, speed);
        /* 10GBASE-T MDI/MDI-X */
-        if (ecmd->port == PORT_TP && ecmd->speed == SPEED_10000) {
+        if (ecmd->port == PORT_TP
+            && (ethtool_cmd_speed(ecmd) == SPEED_10000)) {
                switch (mdio->mdio_read(mdio->dev, mdio->prtad, MDIO_MMD_PMAPMD,
                                        MDIO_PMA_10GBT_SWAPPOL)) {
                case MDIO_PMA_10GBT_SWAPPOL_ABNX | MDIO_PMA_10GBT_SWAPPOL_CDNX:
diff --git a/drivers/net/mii.c b/drivers/net/mii.c
index d4fc00b1ff93..c62e7816d548 100644
--- a/drivers/net/mii.c
+++ b/drivers/net/mii.c
@@ -62,6 +62,9 @@ static u32 mii_get_an(struct mii_if_info *mii, u16 addr)
 * @mii: MII interface
 * @ecmd: requested ethtool_cmd
 *
+ * The @ecmd parameter is expected to have been cleared before calling
+ * mii_ethtool_gset().
+ *
 * Returns 0 for success, negative on error.
 */
 int mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)
@@ -122,22 +125,25 @@ int mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)
                if (nego & (ADVERTISED_1000baseT_Full |
                            ADVERTISED_1000baseT_Half)) {
-                        ecmd->speed = SPEED_1000;
+                        ethtool_cmd_speed_set(ecmd, SPEED_1000);
                        ecmd->duplex = !!(nego & ADVERTISED_1000baseT_Full);
                } else if (nego & (ADVERTISED_100baseT_Full |
                                   ADVERTISED_100baseT_Half)) {
-                        ecmd->speed = SPEED_100;
+                        ethtool_cmd_speed_set(ecmd, SPEED_100);
                        ecmd->duplex = !!(nego & ADVERTISED_100baseT_Full);
                } else {
-                        ecmd->speed = SPEED_10;
+                        ethtool_cmd_speed_set(ecmd, SPEED_10);
                        ecmd->duplex = !!(nego & ADVERTISED_10baseT_Full);
                }
        } else {
                ecmd->autoneg = AUTONEG_DISABLE;
-                ecmd->speed = ((bmcr & BMCR_SPEED1000 &&
+                ethtool_cmd_speed_set(ecmd,
-                                (bmcr & BMCR_SPEED100) == 0) ? SPEED_1000 :
+                                      ((bmcr & BMCR_SPEED1000 &&
-                               (bmcr & BMCR_SPEED100) ? SPEED_100 : SPEED_10);
+                                        (bmcr & BMCR_SPEED100) == 0) ?
+                                       SPEED_1000 :
+                                       ((bmcr & BMCR_SPEED100) ?
+                                        SPEED_100 : SPEED_10)));
                ecmd->duplex = (bmcr & BMCR_FULLDPLX) ? DUPLEX_FULL : DUPLEX_HALF;
        }
@@ -158,10 +164,11 @@ int mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)
 int mii_ethtool_sset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)
 {
        struct net_device *dev = mii->dev;
+        u32 speed = ethtool_cmd_speed(ecmd);
-        if (ecmd->speed != SPEED_10 &&
+        if (speed != SPEED_10 &&
-            ecmd->speed != SPEED_100 &&
+            speed != SPEED_100 &&
-            ecmd->speed != SPEED_1000)
+            speed != SPEED_1000)
                return -EINVAL;
        if (ecmd->duplex != DUPLEX_HALF && ecmd->duplex != DUPLEX_FULL)
                return -EINVAL;
@@ -173,7 +180,7 @@ int mii_ethtool_sset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)
                return -EINVAL;
        if (ecmd->autoneg != AUTONEG_DISABLE && ecmd->autoneg != AUTONEG_ENABLE)
                return -EINVAL;
-        if ((ecmd->speed == SPEED_1000) && (!mii->supports_gmii))
+        if ((speed == SPEED_1000) && (!mii->supports_gmii))
                return -EINVAL;
        /* ignore supported, maxtxpkt, maxrxpkt */
@@ -231,9 +238,9 @@ int mii_ethtool_sset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)
                bmcr = mii->mdio_read(dev, mii->phy_id, MII_BMCR);
                tmp = bmcr & ~(BMCR_ANENABLE | BMCR_SPEED100 |
                               BMCR_SPEED1000 | BMCR_FULLDPLX);
-                if (ecmd->speed == SPEED_1000)
+                if (speed == SPEED_1000)
                        tmp |= BMCR_SPEED1000;
-                else if (ecmd->speed == SPEED_100)
+                else if (speed == SPEED_100)
                        tmp |= BMCR_SPEED100;
                if (ecmd->duplex == DUPLEX_FULL) {
                        tmp |= BMCR_FULLDPLX;
diff --git a/drivers/net/mlx4/en_ethtool.c b/drivers/net/mlx4/en_ethtool.c
index d54b7abf0225..2e858e4dcf4d 100644
--- a/drivers/net/mlx4/en_ethtool.c
+++ b/drivers/net/mlx4/en_ethtool.c
@@ -57,37 +57,6 @@ mlx4_en_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo)
        drvinfo->eedump_len = 0;
 }
-static u32 mlx4_en_get_tso(struct net_device *dev)
-{
-        return (dev->features & NETIF_F_TSO) != 0;
-}
-static int mlx4_en_set_tso(struct net_device *dev, u32 data)
-{
-        struct mlx4_en_priv *priv = netdev_priv(dev);
-        if (data) {
-                if (!priv->mdev->LSO_support)
-                        return -EPERM;
-                dev->features |= (NETIF_F_TSO | NETIF_F_TSO6);
-        } else
-                dev->features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
-        return 0;
-}
-static u32 mlx4_en_get_rx_csum(struct net_device *dev)
-{
-        struct mlx4_en_priv *priv = netdev_priv(dev);
-        return priv->rx_csum;
-}
-static int mlx4_en_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct mlx4_en_priv *priv = netdev_priv(dev);
-        priv->rx_csum = (data != 0);
-        return 0;
-}
 static const char main_strings[][ETH_GSTRING_LEN] = {
        "rx_packets", "tx_packets", "rx_bytes", "tx_bytes", "rx_errors",
        "tx_errors", "rx_dropped", "tx_dropped", "multicast", "collisions",
@@ -296,10 +265,10 @@ static int mlx4_en_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        trans_type = priv->port_state.transciver;
        if (netif_carrier_ok(dev)) {
-                cmd->speed = priv->port_state.link_speed;
+                ethtool_cmd_speed_set(cmd, priv->port_state.link_speed);
                cmd->duplex = DUPLEX_FULL;
        } else {
-                cmd->speed = -1;
+                ethtool_cmd_speed_set(cmd, -1);
                cmd->duplex = -1;
        }
@@ -323,7 +292,8 @@ static int mlx4_en_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 static int mlx4_en_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        if ((cmd->autoneg == AUTONEG_ENABLE) ||
-            (cmd->speed != SPEED_10000) || (cmd->duplex != DUPLEX_FULL))
+            (ethtool_cmd_speed(cmd) != SPEED_10000) ||
+            (cmd->duplex != DUPLEX_FULL))
                return -EINVAL;
        /* Nothing to change */
@@ -483,17 +453,7 @@ const struct ethtool_ops mlx4_en_ethtool_ops = {
        .get_drvinfo = mlx4_en_get_drvinfo,
        .get_settings = mlx4_en_get_settings,
        .set_settings = mlx4_en_set_settings,
-#ifdef NETIF_F_TSO
-        .get_tso = mlx4_en_get_tso,
-        .set_tso = mlx4_en_set_tso,
-#endif
-        .get_sg = ethtool_op_get_sg,
-        .set_sg = ethtool_op_set_sg,
        .get_link = ethtool_op_get_link,
-        .get_rx_csum = mlx4_en_get_rx_csum,
-        .set_rx_csum = mlx4_en_set_rx_csum,
-        .get_tx_csum = ethtool_op_get_tx_csum,
-        .set_tx_csum = ethtool_op_set_tx_ipv6_csum,
        .get_strings = mlx4_en_get_strings,
        .get_sset_count = mlx4_en_get_sset_count,
        .get_ethtool_stats = mlx4_en_get_ethtool_stats,
@@ -508,7 +468,6 @@ const struct ethtool_ops mlx4_en_ethtool_ops = {
        .set_pauseparam = mlx4_en_set_pauseparam,
        .get_ringparam = mlx4_en_get_ringparam,
        .set_ringparam = mlx4_en_set_ringparam,
-        .get_flags = ethtool_op_get_flags,
 };
diff --git a/drivers/net/mlx4/en_netdev.c b/drivers/net/mlx4/en_netdev.c
index 77063f91c564..61850adae6f7 100644
--- a/drivers/net/mlx4/en_netdev.c
+++ b/drivers/net/mlx4/en_netdev.c
@@ -1083,7 +1083,6 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
        priv->prof = prof;
        priv->port = port;
        priv->port_up = false;
-        priv->rx_csum = 1;
        priv->flags = prof->flags;
        priv->tx_ring_num = prof->tx_ring_num;
        priv->rx_ring_num = prof->rx_ring_num;
@@ -1141,21 +1140,16 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
        /*
         * Set driver features
         */
-        dev->features |= NETIF_F_SG;
+        dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
-        dev->vlan_features |= NETIF_F_SG;
+        if (mdev->LSO_support)
-        dev->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
+                dev->hw_features |= NETIF_F_TSO | NETIF_F_TSO6;
-        dev->vlan_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
-        dev->features |= NETIF_F_HIGHDMA;
+        dev->vlan_features = dev->hw_features;
-        dev->features |= NETIF_F_HW_VLAN_TX |
-                         NETIF_F_HW_VLAN_RX |
+        dev->hw_features |= NETIF_F_RXCSUM;
-                         NETIF_F_HW_VLAN_FILTER;
+        dev->features = dev->hw_features | NETIF_F_HIGHDMA |
-        dev->features |= NETIF_F_GRO;
+                        NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |
-        if (mdev->LSO_support) {
+                        NETIF_F_HW_VLAN_FILTER;
-                dev->features |= NETIF_F_TSO;
-                dev->features |= NETIF_F_TSO6;
-                dev->vlan_features |= NETIF_F_TSO;
-                dev->vlan_features |= NETIF_F_TSO6;
-        }
        mdev->pndev[port] = dev;
diff --git a/drivers/net/mlx4/en_rx.c b/drivers/net/mlx4/en_rx.c
index 62dd21b06df4..277215fb9d72 100644
--- a/drivers/net/mlx4/en_rx.c
+++ b/drivers/net/mlx4/en_rx.c
@@ -584,7 +584,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
                ring->bytes += length;
                ring->packets++;
-                if (likely(priv->rx_csum)) {
+                if (likely(dev->features & NETIF_F_RXCSUM)) {
                        if ((cqe->status & cpu_to_be16(MLX4_CQE_STATUS_IPOK)) &&
                            (cqe->checksum == cpu_to_be16(0xffff))) {
                                priv->port_stats.rx_chksum_good++;
diff --git a/drivers/net/mlx4/mlx4_en.h b/drivers/net/mlx4/mlx4_en.h
index e30f6099c0de..0b5150df0585 100644
--- a/drivers/net/mlx4/mlx4_en.h
+++ b/drivers/net/mlx4/mlx4_en.h
@@ -451,7 +451,6 @@ struct mlx4_en_priv {
        int registered;
        int allocated;
        int stride;
-        int rx_csum;
        u64 mac;
        int mac_index;
        unsigned max_mtu;
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 34425b94452f..a5d9b1c310b3 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -1444,13 +1444,13 @@ mv643xx_eth_get_settings_phyless(struct mv643xx_eth_private *mp,
        cmd->advertising = ADVERTISED_MII;
        switch (port_status & PORT_SPEED_MASK) {
        case PORT_SPEED_10:
-                cmd->speed = SPEED_10;
+                ethtool_cmd_speed_set(cmd, SPEED_10);
                break;
        case PORT_SPEED_100:
-                cmd->speed = SPEED_100;
+                ethtool_cmd_speed_set(cmd, SPEED_100);
                break;
        case PORT_SPEED_1000:
-                cmd->speed = SPEED_1000;
+                ethtool_cmd_speed_set(cmd, SPEED_1000);
                break;
        default:
                cmd->speed = -1;
@@ -1575,18 +1575,12 @@ mv643xx_eth_set_ringparam(struct net_device *dev, struct ethtool_ringparam *er)
        return 0;
 }
-static u32
-mv643xx_eth_get_rx_csum(struct net_device *dev)
-{
-        struct mv643xx_eth_private *mp = netdev_priv(dev);
-        return !!(rdlp(mp, PORT_CONFIG) & 0x02000000);
-}
 static int
-mv643xx_eth_set_rx_csum(struct net_device *dev, u32 rx_csum)
+mv643xx_eth_set_features(struct net_device *dev, u32 features)
 {
        struct mv643xx_eth_private *mp = netdev_priv(dev);
+        u32 rx_csum = features & NETIF_F_RXCSUM;
        wrlp(mp, PORT_CONFIG, rx_csum ? 0x02000000 : 0x00000000);
@@ -1634,11 +1628,6 @@ static void mv643xx_eth_get_ethtool_stats(struct net_device *dev,
        }
 }
-static int mv643xx_eth_set_flags(struct net_device *dev, u32 data)
-{
-        return ethtool_op_set_flags(dev, data, ETH_FLAG_LRO);
-}
 static int mv643xx_eth_get_sset_count(struct net_device *dev, int sset)
 {
        if (sset == ETH_SS_STATS)
@@ -1657,14 +1646,8 @@ static const struct ethtool_ops mv643xx_eth_ethtool_ops = {
        .set_coalesce           = mv643xx_eth_set_coalesce,
        .get_ringparam          = mv643xx_eth_get_ringparam,
        .set_ringparam          = mv643xx_eth_set_ringparam,
-        .get_rx_csum            = mv643xx_eth_get_rx_csum,
-        .set_rx_csum            = mv643xx_eth_set_rx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_csum,
-        .set_sg                 = ethtool_op_set_sg,
        .get_strings            = mv643xx_eth_get_strings,
        .get_ethtool_stats      = mv643xx_eth_get_ethtool_stats,
-        .get_flags              = ethtool_op_get_flags,
-        .set_flags              = mv643xx_eth_set_flags,
        .get_sset_count         = mv643xx_eth_get_sset_count,
 };
@@ -2264,7 +2247,7 @@ static void port_start(struct mv643xx_eth_private *mp)
         * frames to RX queue #0, and include the pseudo-header when
         * calculating receive checksums.
         */
-        wrlp(mp, PORT_CONFIG, 0x02000000);
+        mv643xx_eth_set_features(mp->dev, mp->dev->features);
        /*
         * Treat BPDUs as normal multicasts, and disable partition mode.
@@ -2848,6 +2831,7 @@ static const struct net_device_ops mv643xx_eth_netdev_ops = {
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_do_ioctl           = mv643xx_eth_ioctl,
        .ndo_change_mtu         = mv643xx_eth_change_mtu,
+        .ndo_set_features       = mv643xx_eth_set_features,
        .ndo_tx_timeout         = mv643xx_eth_tx_timeout,
        .ndo_get_stats          = mv643xx_eth_get_stats,
 #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -2930,7 +2914,9 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
        dev->watchdog_timeo = 2 * HZ;
        dev->base_addr = 0;
-        dev->features = NETIF_F_SG | NETIF_F_IP_CSUM;
+        dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM |
+                NETIF_F_RXCSUM | NETIF_F_LRO;
+        dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_RXCSUM;
        dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM;
        SET_NETDEV_DEV(dev, &pdev->dev);
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index 1446de59ae53..b1358f79ba0a 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -205,7 +205,6 @@ struct myri10ge_priv {
        int tx_boundary;        /* boundary transmits cannot cross */
        int num_slices;
        int running;            /* running?             */
-        int csum_flag;          /* rx_csums?            */
        int small_bytes;
        int big_bytes;
        int max_intr_slots;
@@ -1386,7 +1385,7 @@ myri10ge_rx_done(struct myri10ge_slice_state *ss, int len, __wsum csum,
        skb->protocol = eth_type_trans(skb, dev);
        skb_record_rx_queue(skb, ss - &mgp->ss[0]);
-        if (mgp->csum_flag) {
+        if (dev->features & NETIF_F_RXCSUM) {
                if ((skb->protocol == htons(ETH_P_IP)) ||
                    (skb->protocol == htons(ETH_P_IPV6))) {
                        skb->csum = csum;
@@ -1645,7 +1644,7 @@ myri10ge_get_settings(struct net_device *netdev, struct ethtool_cmd *cmd)
        int i;
        cmd->autoneg = AUTONEG_DISABLE;
-        cmd->speed = SPEED_10000;
+        ethtool_cmd_speed_set(cmd, SPEED_10000);
        cmd->duplex = DUPLEX_FULL;
        /*
@@ -1757,43 +1756,6 @@ myri10ge_get_ringparam(struct net_device *netdev,
        ring->tx_pending = ring->tx_max_pending;
 }
-static u32 myri10ge_get_rx_csum(struct net_device *netdev)
-{
-        struct myri10ge_priv *mgp = netdev_priv(netdev);
-        if (mgp->csum_flag)
-                return 1;
-        else
-                return 0;
-}
-static int myri10ge_set_rx_csum(struct net_device *netdev, u32 csum_enabled)
-{
-        struct myri10ge_priv *mgp = netdev_priv(netdev);
-        int err = 0;
-        if (csum_enabled)
-                mgp->csum_flag = MXGEFW_FLAGS_CKSUM;
-        else {
-                netdev->features &= ~NETIF_F_LRO;
-                mgp->csum_flag = 0;
-        }
-        return err;
-}
-static int myri10ge_set_tso(struct net_device *netdev, u32 tso_enabled)
-{
-        struct myri10ge_priv *mgp = netdev_priv(netdev);
-        u32 flags = mgp->features & (NETIF_F_TSO6 | NETIF_F_TSO);
-        if (tso_enabled)
-                netdev->features |= flags;
-        else
-                netdev->features &= ~flags;
-        return 0;
-}
 static const char myri10ge_gstrings_main_stats[][ETH_GSTRING_LEN] = {
        "rx_packets", "tx_packets", "rx_bytes", "tx_bytes", "rx_errors",
        "tx_errors", "rx_dropped", "tx_dropped", "multicast", "collisions",
@@ -1944,11 +1906,6 @@ static u32 myri10ge_get_msglevel(struct net_device *netdev)
        return mgp->msg_enable;
 }
-static int myri10ge_set_flags(struct net_device *netdev, u32 value)
-{
-        return ethtool_op_set_flags(netdev, value, ETH_FLAG_LRO);
-}
 static const struct ethtool_ops myri10ge_ethtool_ops = {
        .get_settings = myri10ge_get_settings,
        .get_drvinfo = myri10ge_get_drvinfo,
@@ -1957,19 +1914,12 @@ static const struct ethtool_ops myri10ge_ethtool_ops = {
        .get_pauseparam = myri10ge_get_pauseparam,
        .set_pauseparam = myri10ge_set_pauseparam,
        .get_ringparam = myri10ge_get_ringparam,
-        .get_rx_csum = myri10ge_get_rx_csum,
-        .set_rx_csum = myri10ge_set_rx_csum,
-        .set_tx_csum = ethtool_op_set_tx_hw_csum,
-        .set_sg = ethtool_op_set_sg,
-        .set_tso = myri10ge_set_tso,
        .get_link = ethtool_op_get_link,
        .get_strings = myri10ge_get_strings,
        .get_sset_count = myri10ge_get_sset_count,
        .get_ethtool_stats = myri10ge_get_ethtool_stats,
        .set_msglevel = myri10ge_set_msglevel,
        .get_msglevel = myri10ge_get_msglevel,
-        .get_flags = ethtool_op_get_flags,
-        .set_flags = myri10ge_set_flags
 };
 static int myri10ge_allocate_rings(struct myri10ge_slice_state *ss)
@@ -3136,6 +3086,14 @@ static int myri10ge_set_mac_address(struct net_device *dev, void *addr)
        return 0;
 }
+static u32 myri10ge_fix_features(struct net_device *dev, u32 features)
+{
+        if (!(features & NETIF_F_RXCSUM))
+                features &= ~NETIF_F_LRO;
+        return features;
+}
 static int myri10ge_change_mtu(struct net_device *dev, int new_mtu)
 {
        struct myri10ge_priv *mgp = netdev_priv(dev);
@@ -3834,6 +3792,7 @@ static const struct net_device_ops myri10ge_netdev_ops = {
        .ndo_get_stats          = myri10ge_get_stats,
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_change_mtu         = myri10ge_change_mtu,
+        .ndo_fix_features       = myri10ge_fix_features,
        .ndo_set_multicast_list = myri10ge_set_multicast_list,
        .ndo_set_mac_address    = myri10ge_set_mac_address,
 };
@@ -3860,7 +3819,6 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        mgp = netdev_priv(netdev);
        mgp->dev = netdev;
        mgp->pdev = pdev;
-        mgp->csum_flag = MXGEFW_FLAGS_CKSUM;
        mgp->pause = myri10ge_flow_control;
        mgp->intr_coal_delay = myri10ge_intr_coal_delay;
        mgp->msg_enable = netif_msg_init(myri10ge_debug, MYRI10GE_MSG_DEFAULT);
@@ -3976,11 +3934,11 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        netdev->netdev_ops = &myri10ge_netdev_ops;
        netdev->mtu = myri10ge_initial_mtu;
        netdev->base_addr = mgp->iomem_base;
-        netdev->features = mgp->features;
+        netdev->hw_features = mgp->features | NETIF_F_LRO | NETIF_F_RXCSUM;
+        netdev->features = netdev->hw_features;
        if (dac_enabled)
                netdev->features |= NETIF_F_HIGHDMA;
-        netdev->features |= NETIF_F_LRO;
        netdev->vlan_features |= mgp->features;
        if (mgp->fw_ver_tiny < 37)
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index 1074231f0a0d..b78be088c4ad 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -2820,7 +2820,7 @@ static int netdev_get_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
        u32 tmp;
        ecmd->port        = dev->if_port;
-        ecmd->speed       = np->speed;
+        ethtool_cmd_speed_set(ecmd, np->speed);
        ecmd->duplex      = np->duplex;
        ecmd->autoneg     = np->autoneg;
        ecmd->advertising = 0;
@@ -2878,9 +2878,9 @@ static int netdev_get_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
                tmp = mii_nway_result(
                        np->advertising & mdio_read(dev, MII_LPA));
                if (tmp == LPA_100FULL || tmp == LPA_100HALF)
-                        ecmd->speed  = SPEED_100;
+                        ethtool_cmd_speed_set(ecmd, SPEED_100);
                else
-                        ecmd->speed  = SPEED_10;
+                        ethtool_cmd_speed_set(ecmd, SPEED_10);
                if (tmp == LPA_100FULL || tmp == LPA_10FULL)
                        ecmd->duplex = DUPLEX_FULL;
                else
@@ -2908,7 +2908,8 @@ static int netdev_set_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
                        return -EINVAL;
                }
        } else if (ecmd->autoneg == AUTONEG_DISABLE) {
-                if (ecmd->speed != SPEED_10 && ecmd->speed != SPEED_100)
+                u32 speed = ethtool_cmd_speed(ecmd);
+                if (speed != SPEED_10 && speed != SPEED_100)
                        return -EINVAL;
                if (ecmd->duplex != DUPLEX_HALF && ecmd->duplex != DUPLEX_FULL)
                        return -EINVAL;
@@ -2956,7 +2957,7 @@ static int netdev_set_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
                if (ecmd->advertising & ADVERTISED_100baseT_Full)
                        np->advertising |= ADVERTISE_100FULL;
        } else {
-                np->speed  = ecmd->speed;
+                np->speed  = ethtool_cmd_speed(ecmd);
                np->duplex = ecmd->duplex;
                /* user overriding the initial full duplex parm? */
                if (np->duplex == DUPLEX_HALF)
diff --git a/drivers/net/ne3210.c b/drivers/net/ne3210.c
index 243ed2aee88e..e8984b0ca521 100644
--- a/drivers/net/ne3210.c
+++ b/drivers/net/ne3210.c
@@ -80,17 +80,20 @@ static void ne3210_block_output(struct net_device *dev, int count, const unsigne
 #define NE3210_DEBUG    0x0
-static unsigned char irq_map[] __initdata = {15, 12, 11, 10, 9, 7, 5, 3};
+static const unsigned char irq_map[] __devinitconst =
-static unsigned int shmem_map[] __initdata = {0xff0, 0xfe0, 0xfff0, 0xd8, 0xffe0, 0xffc0, 0xd0, 0x0};
+        { 15, 12, 11, 10, 9, 7, 5, 3 };
-static const char *ifmap[] __initdata = {"UTP", "?", "BNC", "AUI"};
+static const unsigned int shmem_map[] __devinitconst =
-static int ifmap_val[] __initdata = {
+        { 0xff0, 0xfe0, 0xfff0, 0xd8, 0xffe0, 0xffc0, 0xd0, 0x0 };
+static const char *const ifmap[] __devinitconst =
+        { "UTP", "?", "BNC", "AUI" };
+static const int ifmap_val[] __devinitconst = {
                IF_PORT_10BASET,
                IF_PORT_UNKNOWN,
                IF_PORT_10BASE2,
                IF_PORT_AUI,
 };
-static int __init ne3210_eisa_probe (struct device *device)
+static int __devinit ne3210_eisa_probe (struct device *device)
 {
        unsigned long ioaddr, phys_mem;
        int i, retval, port_index;
@@ -313,7 +316,7 @@ static void ne3210_block_output(struct net_device *dev, int count,
        memcpy_toio(shmem, buf, count);
 }
-static struct eisa_device_id ne3210_ids[] = {
+static const struct eisa_device_id ne3210_ids[] __devinitconst = {
        { "EGL0101" },
        { "NVL1801" },
        { "" },
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index eb41e44921e6..a83e101440fd 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -242,34 +242,6 @@ static struct netconsole_target *to_target(struct config_item *item)
 }
 /*
- * Wrapper over simple_strtol (base 10) with sanity and range checking.
- * We return (signed) long only because we may want to return errors.
- * Do not use this to convert numbers that are allowed to be negative.
- */
-static long strtol10_check_range(const char *cp, long min, long max)
-{
-        long ret;
-        char *p = (char *) cp;
-        WARN_ON(min < 0);
-        WARN_ON(max < min);
-        ret = simple_strtol(p, &p, 10);
-        if (*p && (*p != '\n')) {
-                printk(KERN_ERR "netconsole: invalid input\n");
-                return -EINVAL;
-        }
-        if ((ret < min) || (ret > max)) {
-                printk(KERN_ERR "netconsole: input %ld must be between "
-                                "%ld and %ld\n", ret, min, max);
-                return -EINVAL;
-        }
-        return ret;
-}
-/*
 * Attribute operations for netconsole_target.
 */
@@ -327,12 +299,14 @@ static ssize_t store_enabled(struct netconsole_target *nt,
                             const char *buf,
                             size_t count)
 {
+        int enabled;
        int err;
-        long enabled;
-        enabled = strtol10_check_range(buf, 0, 1);
+        err = kstrtoint(buf, 10, &enabled);
-        if (enabled < 0)
+        if (err < 0)
-                return enabled;
+                return err;
+        if (enabled < 0 || enabled > 1)
+                return -EINVAL;
        if (enabled) {  /* 1 */
@@ -384,8 +358,7 @@ static ssize_t store_local_port(struct netconsole_target *nt,
                                const char *buf,
                                size_t count)
 {
-        long local_port;
+        int rv;
-#define __U16_MAX       ((__u16) ~0U)
        if (nt->enabled) {
                printk(KERN_ERR "netconsole: target (%s) is enabled, "
@@ -394,12 +367,9 @@ static ssize_t store_local_port(struct netconsole_target *nt,
                return -EINVAL;
        }
-        local_port = strtol10_check_range(buf, 0, __U16_MAX);
+        rv = kstrtou16(buf, 10, &nt->np.local_port);
-        if (local_port < 0)
+        if (rv < 0)
-                return local_port;
+                return rv;
-        nt->np.local_port = local_port;
        return strnlen(buf, count);
 }
@@ -407,8 +377,7 @@ static ssize_t store_remote_port(struct netconsole_target *nt,
                                 const char *buf,
                                 size_t count)
 {
-        long remote_port;
+        int rv;
-#define __U16_MAX       ((__u16) ~0U)
        if (nt->enabled) {
                printk(KERN_ERR "netconsole: target (%s) is enabled, "
@@ -417,12 +386,9 @@ static ssize_t store_remote_port(struct netconsole_target *nt,
                return -EINVAL;
        }
-        remote_port = strtol10_check_range(buf, 0, __U16_MAX);
+        rv = kstrtou16(buf, 10, &nt->np.remote_port);
-        if (remote_port < 0)
+        if (rv < 0)
-                return remote_port;
+                return rv;
-        nt->np.remote_port = remote_port;
        return strnlen(buf, count);
 }
@@ -463,8 +429,6 @@ static ssize_t store_remote_mac(struct netconsole_target *nt,
                                size_t count)
 {
        u8 remote_mac[ETH_ALEN];
-        char *p = (char *) buf;
-        int i;
        if (nt->enabled) {
                printk(KERN_ERR "netconsole: target (%s) is enabled, "
@@ -473,23 +437,13 @@ static ssize_t store_remote_mac(struct netconsole_target *nt,
                return -EINVAL;
        }
-        for (i = 0; i < ETH_ALEN - 1; i++) {
+        if (!mac_pton(buf, remote_mac))
-                remote_mac[i] = simple_strtoul(p, &p, 16);
+                return -EINVAL;
-                if (*p != ':')
+        if (buf[3 * ETH_ALEN - 1] && buf[3 * ETH_ALEN - 1] != '\n')
-                        goto invalid;
+                return -EINVAL;
-                p++;
-        }
-        remote_mac[ETH_ALEN - 1] = simple_strtoul(p, &p, 16);
-        if (*p && (*p != '\n'))
-                goto invalid;
        memcpy(nt->np.remote_mac, remote_mac, ETH_ALEN);
        return strnlen(buf, count);
-invalid:
-        printk(KERN_ERR "netconsole: invalid input\n");
-        return -EINVAL;
 }
 /*
diff --git a/drivers/net/netxen/netxen_nic.h b/drivers/net/netxen/netxen_nic.h
index 679dc8519c5b..77220687b92a 100644
--- a/drivers/net/netxen/netxen_nic.h
+++ b/drivers/net/netxen/netxen_nic.h
@@ -1177,7 +1177,7 @@ struct netxen_adapter {
        u8 max_sds_rings;
        u8 driver_mismatch;
        u8 msix_supported;
-        u8 rx_csum;
+        u8 __pad;
        u8 pci_using_dac;
        u8 portnum;
        u8 physical_port;
diff --git a/drivers/net/netxen/netxen_nic_ethtool.c b/drivers/net/netxen/netxen_nic_ethtool.c
index 3bdcc803ec68..b34fb74d07e3 100644
--- a/drivers/net/netxen/netxen_nic_ethtool.c
+++ b/drivers/net/netxen/netxen_nic_ethtool.c
@@ -117,7 +117,7 @@ netxen_nic_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                ecmd->port = PORT_TP;
-                ecmd->speed = adapter->link_speed;
+                ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                ecmd->duplex = adapter->link_duplex;
                ecmd->autoneg = adapter->link_autoneg;
@@ -134,7 +134,7 @@ netxen_nic_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                }
                if (netif_running(dev) && adapter->has_link_events) {
-                        ecmd->speed = adapter->link_speed;
+                        ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                        ecmd->autoneg = adapter->link_autoneg;
                        ecmd->duplex = adapter->link_duplex;
                        goto skip;
@@ -146,10 +146,10 @@ netxen_nic_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                        u16 pcifn = adapter->ahw.pci_func;
                        val = NXRD32(adapter, P3_LINK_SPEED_REG(pcifn));
-                        ecmd->speed = P3_LINK_SPEED_MHZ *
+                        ethtool_cmd_speed_set(ecmd, P3_LINK_SPEED_MHZ *
-                                        P3_LINK_SPEED_VAL(pcifn, val);
+                                              P3_LINK_SPEED_VAL(pcifn, val));
                } else
-                        ecmd->speed = SPEED_10000;
+                        ethtool_cmd_speed_set(ecmd, SPEED_10000);
                ecmd->duplex = DUPLEX_FULL;
                ecmd->autoneg = AUTONEG_DISABLE;
@@ -251,6 +251,7 @@ static int
 netxen_nic_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
 {
        struct netxen_adapter *adapter = netdev_priv(dev);
+        u32 speed = ethtool_cmd_speed(ecmd);
        int ret;
        if (adapter->ahw.port_type != NETXEN_NIC_GBE)
@@ -259,14 +260,14 @@ netxen_nic_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
        if (!(adapter->capabilities & NX_FW_CAPABILITY_GBE_LINK_CFG))
                return -EOPNOTSUPP;
-        ret = nx_fw_cmd_set_gbe_port(adapter, ecmd->speed, ecmd->duplex,
+        ret = nx_fw_cmd_set_gbe_port(adapter, speed, ecmd->duplex,
                                     ecmd->autoneg);
        if (ret == NX_RCODE_NOT_SUPPORTED)
                return -EOPNOTSUPP;
        else if (ret)
                return -EIO;
-        adapter->link_speed = ecmd->speed;
+        adapter->link_speed = speed;
        adapter->link_duplex = ecmd->duplex;
        adapter->link_autoneg = ecmd->autoneg;
@@ -676,62 +677,6 @@ netxen_nic_get_ethtool_stats(struct net_device *dev,
        }
 }
-static u32 netxen_nic_get_tx_csum(struct net_device *dev)
-{
-        return dev->features & NETIF_F_IP_CSUM;
-}
-static u32 netxen_nic_get_rx_csum(struct net_device *dev)
-{
-        struct netxen_adapter *adapter = netdev_priv(dev);
-        return adapter->rx_csum;
-}
-static int netxen_nic_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct netxen_adapter *adapter = netdev_priv(dev);
-        if (data) {
-                adapter->rx_csum = data;
-                return 0;
-        }
-        if (dev->features & NETIF_F_LRO) {
-                if (netxen_config_hw_lro(adapter, NETXEN_NIC_LRO_DISABLED))
-                        return -EIO;
-                dev->features &= ~NETIF_F_LRO;
-                netxen_send_lro_cleanup(adapter);
-                netdev_info(dev, "disabling LRO as rx_csum is off\n");
-        }
-        adapter->rx_csum = data;
-        return 0;
-}
-static u32 netxen_nic_get_tso(struct net_device *dev)
-{
-        struct netxen_adapter *adapter = netdev_priv(dev);
-        if (NX_IS_REVISION_P3(adapter->ahw.revision_id))
-                return (dev->features & (NETIF_F_TSO | NETIF_F_TSO6)) != 0;
-        return (dev->features & NETIF_F_TSO) != 0;
-}
-static int netxen_nic_set_tso(struct net_device *dev, u32 data)
-{
-        if (data) {
-                struct netxen_adapter *adapter = netdev_priv(dev);
-                dev->features |= NETIF_F_TSO;
-                if (NX_IS_REVISION_P3(adapter->ahw.revision_id))
-                        dev->features |= NETIF_F_TSO6;
-        } else
-                dev->features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
-        return 0;
-}
 static void
 netxen_nic_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
 {
@@ -866,43 +811,6 @@ static int netxen_get_intr_coalesce(struct net_device *netdev,
        return 0;
 }
-static int netxen_nic_set_flags(struct net_device *netdev, u32 data)
-{
-        struct netxen_adapter *adapter = netdev_priv(netdev);
-        int hw_lro;
-        if (ethtool_invalid_flags(netdev, data, ETH_FLAG_LRO))
-                return -EINVAL;
-        if (!(adapter->capabilities & NX_FW_CAPABILITY_HW_LRO))
-                return -EINVAL;
-        if (!adapter->rx_csum) {
-                netdev_info(netdev, "rx csum is off, cannot toggle LRO\n");
-                return -EINVAL;
-        }
-        if (!!(data & ETH_FLAG_LRO) == !!(netdev->features & NETIF_F_LRO))
-                return 0;
-        if (data & ETH_FLAG_LRO) {
-                hw_lro = NETXEN_NIC_LRO_ENABLED;
-                netdev->features |= NETIF_F_LRO;
-        } else {
-                hw_lro = NETXEN_NIC_LRO_DISABLED;
-                netdev->features &= ~NETIF_F_LRO;
-        }
-        if (netxen_config_hw_lro(adapter, hw_lro))
-                return -EIO;
-        if ((hw_lro == 0) && netxen_send_lro_cleanup(adapter))
-                return -EIO;
-        return 0;
-}
 const struct ethtool_ops netxen_nic_ethtool_ops = {
        .get_settings = netxen_nic_get_settings,
        .set_settings = netxen_nic_set_settings,
@@ -916,21 +824,12 @@ const struct ethtool_ops netxen_nic_ethtool_ops = {
        .set_ringparam = netxen_nic_set_ringparam,
        .get_pauseparam = netxen_nic_get_pauseparam,
        .set_pauseparam = netxen_nic_set_pauseparam,
-        .get_tx_csum = netxen_nic_get_tx_csum,
-        .set_tx_csum = ethtool_op_set_tx_csum,
-        .set_sg = ethtool_op_set_sg,
-        .get_tso = netxen_nic_get_tso,
-        .set_tso = netxen_nic_set_tso,
        .get_wol = netxen_nic_get_wol,
        .set_wol = netxen_nic_set_wol,
        .self_test = netxen_nic_diag_test,
        .get_strings = netxen_nic_get_strings,
        .get_ethtool_stats = netxen_nic_get_ethtool_stats,
        .get_sset_count = netxen_get_sset_count,
-        .get_rx_csum = netxen_nic_get_rx_csum,
-        .set_rx_csum = netxen_nic_set_rx_csum,
        .get_coalesce = netxen_get_intr_coalesce,
        .set_coalesce = netxen_set_intr_coalesce,
-        .get_flags = ethtool_op_get_flags,
-        .set_flags = netxen_nic_set_flags,
 };
diff --git a/drivers/net/netxen/netxen_nic_init.c b/drivers/net/netxen/netxen_nic_init.c
index 731077d8d962..7f999671c7b2 100644
--- a/drivers/net/netxen/netxen_nic_init.c
+++ b/drivers/net/netxen/netxen_nic_init.c
@@ -1483,7 +1483,8 @@ static struct sk_buff *netxen_process_rxbuf(struct netxen_adapter *adapter,
        if (!skb)
                goto no_skb;
-        if (likely(adapter->rx_csum && cksum == STATUS_CKSUM_OK)) {
+        if (likely((adapter->netdev->features & NETIF_F_RXCSUM)
+            && cksum == STATUS_CKSUM_OK)) {
                adapter->stats.csummed++;
                skb->ip_summed = CHECKSUM_UNNECESSARY;
        } else
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index e8a4b6655999..b644383017f9 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -485,6 +485,37 @@ static void netxen_set_multicast_list(struct net_device *dev)
        adapter->set_multi(dev);
 }
+static u32 netxen_fix_features(struct net_device *dev, u32 features)
+{
+        if (!(features & NETIF_F_RXCSUM)) {
+                netdev_info(dev, "disabling LRO as RXCSUM is off\n");
+                features &= ~NETIF_F_LRO;
+        }
+        return features;
+}
+static int netxen_set_features(struct net_device *dev, u32 features)
+{
+        struct netxen_adapter *adapter = netdev_priv(dev);
+        int hw_lro;
+        if (!((dev->features ^ features) & NETIF_F_LRO))
+                return 0;
+        hw_lro = (features & NETIF_F_LRO) ? NETXEN_NIC_LRO_ENABLED
+                 : NETXEN_NIC_LRO_DISABLED;
+        if (netxen_config_hw_lro(adapter, hw_lro))
+                return -EIO;
+        if (!(features & NETIF_F_LRO) && netxen_send_lro_cleanup(adapter))
+                return -EIO;
+        return 0;
+}
 static const struct net_device_ops netxen_netdev_ops = {
        .ndo_open          = netxen_nic_open,
        .ndo_stop          = netxen_nic_close,
@@ -495,6 +526,8 @@ static const struct net_device_ops netxen_netdev_ops = {
        .ndo_set_mac_address    = netxen_nic_set_mac,
        .ndo_change_mtu    = netxen_nic_change_mtu,
        .ndo_tx_timeout    = netxen_tx_timeout,
+        .ndo_fix_features = netxen_fix_features,
+        .ndo_set_features = netxen_set_features,
 #ifdef CONFIG_NET_POLL_CONTROLLER
        .ndo_poll_controller = netxen_nic_poll_controller,
 #endif
@@ -905,7 +938,7 @@ netxen_nic_request_irq(struct netxen_adapter *adapter)
        struct nx_host_sds_ring *sds_ring;
        int err, ring;
-        unsigned long flags = IRQF_SAMPLE_RANDOM;
+        unsigned long flags = 0;
        struct net_device *netdev = adapter->netdev;
        struct netxen_recv_context *recv_ctx = &adapter->recv_ctx;
@@ -1196,7 +1229,6 @@ netxen_setup_netdev(struct netxen_adapter *adapter,
        int err = 0;
        struct pci_dev *pdev = adapter->pdev;
-        adapter->rx_csum = 1;
        adapter->mc_enabled = 0;
        if (NX_IS_REVISION_P3(adapter->ahw.revision_id))
                adapter->max_mc_count = 38;
@@ -1210,14 +1242,13 @@ netxen_setup_netdev(struct netxen_adapter *adapter,
        SET_ETHTOOL_OPS(netdev, &netxen_nic_ethtool_ops);
-        netdev->features |= (NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO);
+        netdev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO |
-        netdev->features |= (NETIF_F_GRO);
+                              NETIF_F_RXCSUM;
-        netdev->vlan_features |= (NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO);
-        if (NX_IS_REVISION_P3(adapter->ahw.revision_id)) {
+        if (NX_IS_REVISION_P3(adapter->ahw.revision_id))
-                netdev->features |= (NETIF_F_IPV6_CSUM | NETIF_F_TSO6);
+                netdev->hw_features |= NETIF_F_IPV6_CSUM | NETIF_F_TSO6;
-                netdev->vlan_features |= (NETIF_F_IPV6_CSUM | NETIF_F_TSO6);
-        }
+        netdev->vlan_features |= netdev->hw_features;
        if (adapter->pci_using_dac) {
                netdev->features |= NETIF_F_HIGHDMA;
@@ -1225,10 +1256,12 @@ netxen_setup_netdev(struct netxen_adapter *adapter,
        }
        if (adapter->capabilities & NX_FW_CAPABILITY_FVLANTX)
-                netdev->features |= (NETIF_F_HW_VLAN_TX);
+                netdev->hw_features |= NETIF_F_HW_VLAN_TX;
        if (adapter->capabilities & NX_FW_CAPABILITY_HW_LRO)
-                netdev->features |= NETIF_F_LRO;
+                netdev->hw_features |= NETIF_F_LRO;
+        netdev->features |= netdev->hw_features;
        netdev->irq = adapter->msix_entries[0].vector;
diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index 32678b6c6b39..cc25bff0bd3b 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -1233,7 +1233,7 @@ static int link_status_1g_rgmii(struct niu *np, int *link_up_p)
        bmsr = err;
        if (bmsr & BMSR_LSTATUS) {
-                u16 adv, lpa, common, estat;
+                u16 adv, lpa;
                err = mii_read(np, np->phy_addr, MII_ADVERTISE);
                if (err < 0)
@@ -1245,12 +1245,9 @@ static int link_status_1g_rgmii(struct niu *np, int *link_up_p)
                        goto out;
                lpa = err;
-                common = adv & lpa;
                err = mii_read(np, np->phy_addr, MII_ESTATUS);
                if (err < 0)
                        goto out;
-                estat = err;
                link_up = 1;
                current_speed = SPEED_1000;
                current_duplex = DUPLEX_FULL;
@@ -1650,7 +1647,7 @@ static int xcvr_init_10g(struct niu *np)
                break;
        }
-        return 0;
+        return err;
 }
 static int mii_reset(struct niu *np)
@@ -2381,17 +2378,14 @@ static int serdes_init_10g_serdes(struct niu *np)
        struct niu_link_config *lp = &np->link_config;
        unsigned long ctrl_reg, test_cfg_reg, pll_cfg, i;
        u64 ctrl_val, test_cfg_val, sig, mask, val;
-        u64 reset_val;
        switch (np->port) {
        case 0:
-                reset_val =  ENET_SERDES_RESET_0;
                ctrl_reg = ENET_SERDES_0_CTRL_CFG;
                test_cfg_reg = ENET_SERDES_0_TEST_CFG;
                pll_cfg = ENET_SERDES_0_PLL_CFG;
                break;
        case 1:
-                reset_val =  ENET_SERDES_RESET_1;
                ctrl_reg = ENET_SERDES_1_CTRL_CFG;
                test_cfg_reg = ENET_SERDES_1_TEST_CFG;
                pll_cfg = ENET_SERDES_1_PLL_CFG;
@@ -6071,8 +6065,7 @@ static int niu_request_irq(struct niu *np)
        for (i = 0; i < np->num_ldg; i++) {
                struct niu_ldg *lp = &np->ldg[i];
-                err = request_irq(lp->irq, niu_interrupt,
+                err = request_irq(lp->irq, niu_interrupt, IRQF_SHARED,
-                                  IRQF_SHARED | IRQF_SAMPLE_RANDOM,
                                  np->irq_name[i], lp);
                if (err)
                        goto out_free_irqs;
@@ -6851,7 +6844,7 @@ static int niu_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        cmd->supported = lp->supported;
        cmd->advertising = lp->active_advertising;
        cmd->autoneg = lp->active_autoneg;
-        cmd->speed = lp->active_speed;
+        ethtool_cmd_speed_set(cmd, lp->active_speed);
        cmd->duplex = lp->active_duplex;
        cmd->port = (np->flags & NIU_FLAGS_FIBER) ? PORT_FIBRE : PORT_TP;
        cmd->transceiver = (np->flags & NIU_FLAGS_XCVR_SERDES) ?
@@ -6866,7 +6859,7 @@ static int niu_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        struct niu_link_config *lp = &np->link_config;
        lp->advertising = cmd->advertising;
-        lp->speed = cmd->speed;
+        lp->speed = ethtool_cmd_speed(cmd);
        lp->duplex = cmd->duplex;
        lp->autoneg = cmd->autoneg;
        return niu_init_link(np);
@@ -7023,6 +7016,7 @@ static int niu_ethflow_to_class(int flow_type, u64 *class)
        case UDP_V4_FLOW:
                *class = CLASS_CODE_UDP_IPV4;
                break;
+        case AH_ESP_V4_FLOW:
        case AH_V4_FLOW:
        case ESP_V4_FLOW:
                *class = CLASS_CODE_AH_ESP_IPV4;
@@ -7036,6 +7030,7 @@ static int niu_ethflow_to_class(int flow_type, u64 *class)
        case UDP_V6_FLOW:
                *class = CLASS_CODE_UDP_IPV6;
                break;
+        case AH_ESP_V6_FLOW:
        case AH_V6_FLOW:
        case ESP_V6_FLOW:
                *class = CLASS_CODE_AH_ESP_IPV6;
@@ -7889,37 +7884,35 @@ static void niu_force_led(struct niu *np, int on)
        nw64_mac(reg, val);
 }
-static int niu_phys_id(struct net_device *dev, u32 data)
+static int niu_set_phys_id(struct net_device *dev,
+                           enum ethtool_phys_id_state state)
 {
        struct niu *np = netdev_priv(dev);
-        u64 orig_led_state;
-        int i;
        if (!netif_running(dev))
                return -EAGAIN;
-        if (data == 0)
+        switch (state) {
-                data = 2;
+        case ETHTOOL_ID_ACTIVE:
+                np->orig_led_state = niu_led_state_save(np);
+                return 1;       /* cycle on/off once per second */
-        orig_led_state = niu_led_state_save(np);
+        case ETHTOOL_ID_ON:
-        for (i = 0; i < (data * 2); i++) {
+                niu_force_led(np, 1);
-                int on = ((i % 2) == 0);
+                break;
-                niu_force_led(np, on);
+        case ETHTOOL_ID_OFF:
+                niu_force_led(np, 0);
+                break;
-                if (msleep_interruptible(500))
+        case ETHTOOL_ID_INACTIVE:
-                        break;
+                niu_led_state_restore(np, np->orig_led_state);
        }
-        niu_led_state_restore(np, orig_led_state);
        return 0;
 }
-static int niu_set_flags(struct net_device *dev, u32 data)
-{
-        return ethtool_op_set_flags(dev, data, ETH_FLAG_RXHASH);
-}
 static const struct ethtool_ops niu_ethtool_ops = {
        .get_drvinfo            = niu_get_drvinfo,
        .get_link               = ethtool_op_get_link,
@@ -7933,11 +7926,9 @@ static const struct ethtool_ops niu_ethtool_ops = {
        .get_strings            = niu_get_strings,
        .get_sset_count         = niu_get_sset_count,
        .get_ethtool_stats      = niu_get_ethtool_stats,
-        .phys_id                = niu_phys_id,
+        .set_phys_id            = niu_set_phys_id,
        .get_rxnfc              = niu_get_nfc,
        .set_rxnfc              = niu_set_nfc,
-        .set_flags              = niu_set_flags,
-        .get_flags              = ethtool_op_get_flags,
 };
 static int niu_ldg_assign_ldn(struct niu *np, struct niu_parent *parent,
@@ -8131,7 +8122,7 @@ static int __devinit niu_pci_vpd_scan_props(struct niu *np,
        netif_printk(np, probe, KERN_DEBUG, np->dev,
                     "VPD_SCAN: start[%x] end[%x]\n", start, end);
        while (start < end) {
-                int len, err, instance, type, prop_len;
+                int len, err, prop_len;
                char namebuf[64];
                u8 *prop_buf;
                int max_len;
@@ -8147,8 +8138,6 @@ static int __devinit niu_pci_vpd_scan_props(struct niu *np,
                len = err;
                start += 3;
-                instance = niu_pci_eeprom_read(np, start);
-                type = niu_pci_eeprom_read(np, start + 3);
                prop_len = niu_pci_eeprom_read(np, start + 4);
                err = niu_pci_vpd_get_propname(np, start + 5, namebuf, 64);
                if (err < 0)
@@ -9768,8 +9757,8 @@ static void __devinit niu_device_announce(struct niu *np)
 static void __devinit niu_set_basic_features(struct net_device *dev)
 {
-        dev->features |= (NETIF_F_SG | NETIF_F_HW_CSUM |
+        dev->hw_features = NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_RXHASH;
-                          NETIF_F_GRO | NETIF_F_RXHASH);
+        dev->features |= dev->hw_features | NETIF_F_RXCSUM;
 }
 static int __devinit niu_pci_init_one(struct pci_dev *pdev,
diff --git a/drivers/net/niu.h b/drivers/net/niu.h
index a41fa8ebe05f..51e177e1860d 100644
--- a/drivers/net/niu.h
+++ b/drivers/net/niu.h
@@ -3279,6 +3279,7 @@ struct niu {
        unsigned long                   xpcs_off;
        struct timer_list               timer;
+        u64                             orig_led_state;
        const struct niu_phy_ops        *phy_ops;
        int                             phy_addr;
diff --git a/drivers/net/ns83820.c b/drivers/net/ns83820.c
index 6667e0667a88..3e4040f2f3cb 100644
--- a/drivers/net/ns83820.c
+++ b/drivers/net/ns83820.c
@@ -1251,7 +1251,7 @@ static int ns83820_get_settings(struct net_device *ndev,
        /*
         * Here's the list of available ethtool commands from other drivers:
         *      cmd->advertising =
-         *      cmd->speed =
+         *      ethtool_cmd_speed_set(cmd, ...)
         *      cmd->duplex =
         *      cmd->port = 0;
         *      cmd->phy_address =
@@ -1289,13 +1289,13 @@ static int ns83820_get_settings(struct net_device *ndev,
        cmd->duplex = fullduplex ? DUPLEX_FULL : DUPLEX_HALF;
        switch (cfg / CFG_SPDSTS0 & 3) {
        case 2:
-                cmd->speed = SPEED_1000;
+                ethtool_cmd_speed_set(cmd, SPEED_1000);
                break;
        case 1:
-                cmd->speed = SPEED_100;
+                ethtool_cmd_speed_set(cmd, SPEED_100);
                break;
        default:
-                cmd->speed = SPEED_10;
+                ethtool_cmd_speed_set(cmd, SPEED_10);
                break;
        }
        cmd->autoneg = (tbicr & TBICR_MR_AN_ENABLE)
diff --git a/drivers/net/pch_gbe/pch_gbe.h b/drivers/net/pch_gbe/pch_gbe.h
index bf126e76fabf..59fac77d0dbb 100644
--- a/drivers/net/pch_gbe/pch_gbe.h
+++ b/drivers/net/pch_gbe/pch_gbe.h
@@ -597,8 +597,6 @@ struct pch_gbe_hw_stats {
 * @rx_ring:            Pointer of Rx descriptor ring structure
 * @rx_buffer_len:      Receive buffer length
 * @tx_queue_len:       Transmit queue length
- * @rx_csum:            Receive TCP/IP checksum enable/disable
- * @tx_csum:            Transmit TCP/IP checksum enable/disable
 * @have_msi:           PCI MSI mode flag
 */
@@ -623,8 +621,6 @@ struct pch_gbe_adapter {
        struct pch_gbe_rx_ring *rx_ring;
        unsigned long rx_buffer_len;
        unsigned long tx_queue_len;
-        bool rx_csum;
-        bool tx_csum;
        bool have_msi;
 };
diff --git a/drivers/net/pch_gbe/pch_gbe_ethtool.c b/drivers/net/pch_gbe/pch_gbe_ethtool.c
index d2174a40d708..ea2d8e41887a 100644
--- a/drivers/net/pch_gbe/pch_gbe_ethtool.c
+++ b/drivers/net/pch_gbe/pch_gbe_ethtool.c
@@ -92,7 +92,7 @@ static int pch_gbe_get_settings(struct net_device *netdev,
        ecmd->advertising &= ~(ADVERTISED_TP | ADVERTISED_1000baseT_Half);
        if (!netif_carrier_ok(adapter->netdev))
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
        return ret;
 }
@@ -109,12 +109,15 @@ static int pch_gbe_set_settings(struct net_device *netdev,
 {
        struct pch_gbe_adapter *adapter = netdev_priv(netdev);
        struct pch_gbe_hw *hw = &adapter->hw;
+        u32 speed = ethtool_cmd_speed(ecmd);
        int ret;
        pch_gbe_hal_write_phy_reg(hw, MII_BMCR, BMCR_RESET);
-        if (ecmd->speed == USHRT_MAX) {
+        /* when set_settings() is called with a ethtool_cmd previously
-                ecmd->speed = SPEED_1000;
+         * filled by get_settings() on a down link, speed is -1: */
+        if (speed == UINT_MAX) {
+                speed = SPEED_1000;
                ecmd->duplex = DUPLEX_FULL;
        }
        ret = mii_ethtool_sset(&adapter->mii, ecmd);
@@ -122,7 +125,7 @@ static int pch_gbe_set_settings(struct net_device *netdev,
                pr_err("Error: mii_ethtool_sset\n");
                return ret;
        }
-        hw->mac.link_speed = ecmd->speed;
+        hw->mac.link_speed = speed;
        hw->mac.link_duplex = ecmd->duplex;
        hw->phy.autoneg_advertised = ecmd->advertising;
        hw->mac.autoneg = ecmd->autoneg;
@@ -434,57 +437,6 @@ static int pch_gbe_set_pauseparam(struct net_device *netdev,
 }
 /**
- * pch_gbe_get_rx_csum - Report whether receive checksums are turned on or off
- * @netdev:  Network interface device structure
- * Returns
- *      true(1):  Checksum On
- *      false(0): Checksum Off
- */
-static u32 pch_gbe_get_rx_csum(struct net_device *netdev)
-{
-        struct pch_gbe_adapter *adapter = netdev_priv(netdev);
-        return adapter->rx_csum;
-}
-/**
- * pch_gbe_set_rx_csum - Turn receive checksum on or off
- * @netdev:  Network interface device structure
- * @data:    Checksum On[true] or Off[false]
- * Returns
- *      0:                      Successful.
- *      Negative value:         Failed.
- */
-static int pch_gbe_set_rx_csum(struct net_device *netdev, u32 data)
-{
-        struct pch_gbe_adapter *adapter = netdev_priv(netdev);
-        adapter->rx_csum = data;
-        if ((netif_running(netdev)))
-                pch_gbe_reinit_locked(adapter);
-        else
-                pch_gbe_reset(adapter);
-        return 0;
-}
-/**
- * pch_gbe_set_tx_csum - Turn transmit checksums on or off
- * @netdev: Network interface device structure
- * @data:   Checksum on[true] or off[false]
- * Returns
- *      0:                      Successful.
- *      Negative value:         Failed.
- */
-static int pch_gbe_set_tx_csum(struct net_device *netdev, u32 data)
-{
-        struct pch_gbe_adapter *adapter = netdev_priv(netdev);
-        adapter->tx_csum = data;
-        return ethtool_op_set_tx_ipv6_csum(netdev, data);
-}
-/**
 * pch_gbe_get_strings - Return a set of strings that describe the requested
 *                       objects
 * @netdev:    Network interface device structure
@@ -554,9 +506,6 @@ static const struct ethtool_ops pch_gbe_ethtool_ops = {
        .set_ringparam = pch_gbe_set_ringparam,
        .get_pauseparam = pch_gbe_get_pauseparam,
        .set_pauseparam = pch_gbe_set_pauseparam,
-        .get_rx_csum = pch_gbe_get_rx_csum,
-        .set_rx_csum = pch_gbe_set_rx_csum,
-        .set_tx_csum = pch_gbe_set_tx_csum,
        .get_strings = pch_gbe_get_strings,
        .get_ethtool_stats = pch_gbe_get_ethtool_stats,
        .get_sset_count = pch_gbe_get_sset_count,
diff --git a/drivers/net/pch_gbe/pch_gbe_main.c b/drivers/net/pch_gbe/pch_gbe_main.c
index 56d049a472da..c2476fd96573 100644
--- a/drivers/net/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/pch_gbe/pch_gbe_main.c
@@ -659,6 +659,7 @@ static void pch_gbe_configure_tx(struct pch_gbe_adapter *adapter)
 */
 static void pch_gbe_setup_rctl(struct pch_gbe_adapter *adapter)
 {
+        struct net_device *netdev = adapter->netdev;
        struct pch_gbe_hw *hw = &adapter->hw;
        u32 rx_mode, tcpip;
@@ -669,7 +670,7 @@ static void pch_gbe_setup_rctl(struct pch_gbe_adapter *adapter)
        tcpip = ioread32(&hw->reg->TCPIP_ACC);
-        if (adapter->rx_csum) {
+        if (netdev->features & NETIF_F_RXCSUM) {
                tcpip &= ~PCH_GBE_RX_TCPIPACC_OFF;
                tcpip |= PCH_GBE_RX_TCPIPACC_EN;
        } else {
@@ -890,12 +891,12 @@ static void pch_gbe_watchdog(unsigned long data)
        struct pch_gbe_adapter *adapter = (struct pch_gbe_adapter *)data;
        struct net_device *netdev = adapter->netdev;
        struct pch_gbe_hw *hw = &adapter->hw;
-        struct ethtool_cmd cmd;
        pr_debug("right now = %ld\n", jiffies);
        pch_gbe_update_stats(adapter);
        if ((mii_link_ok(&adapter->mii)) && (!netif_carrier_ok(netdev))) {
+                struct ethtool_cmd cmd = { .cmd = ETHTOOL_GSET };
                netdev->tx_queue_len = adapter->tx_queue_len;
                /* mii library handles link maintenance tasks */
                if (mii_ethtool_gset(&adapter->mii, &cmd)) {
@@ -905,7 +906,7 @@ static void pch_gbe_watchdog(unsigned long data)
                                                PCH_GBE_WATCHDOG_PERIOD));
                        return;
                }
-                hw->mac.link_speed = cmd.speed;
+                hw->mac.link_speed = ethtool_cmd_speed(&cmd);
                hw->mac.link_duplex = cmd.duplex;
                /* Set the RGMII control. */
                pch_gbe_set_rgmii_ctrl(adapter, hw->mac.link_speed,
@@ -915,7 +916,7 @@ static void pch_gbe_watchdog(unsigned long data)
                                 hw->mac.link_duplex);
                netdev_dbg(netdev,
                           "Link is Up %d Mbps %s-Duplex\n",
-                           cmd.speed,
+                           hw->mac.link_speed,
                           cmd.duplex == DUPLEX_FULL ? "Full" : "Half");
                netif_carrier_on(netdev);
                netif_wake_queue(netdev);
@@ -953,7 +954,7 @@ static void pch_gbe_tx_queue(struct pch_gbe_adapter *adapter,
        frame_ctrl = 0;
        if (unlikely(skb->len < PCH_GBE_SHORT_PKT))
                frame_ctrl |= PCH_GBE_TXD_CTRL_APAD;
-        if (unlikely(!adapter->tx_csum))
+        if (skb->ip_summed == CHECKSUM_NONE)
                frame_ctrl |= PCH_GBE_TXD_CTRL_TCPIP_ACC_OFF;
        /* Performs checksum processing */
@@ -961,7 +962,7 @@ static void pch_gbe_tx_queue(struct pch_gbe_adapter *adapter,
         * It is because the hardware accelerator does not support a checksum,
         * when the received data size is less than 64 bytes.
         */
-        if ((skb->len < PCH_GBE_SHORT_PKT) && (adapter->tx_csum)) {
+        if (skb->len < PCH_GBE_SHORT_PKT && skb->ip_summed != CHECKSUM_NONE) {
                frame_ctrl |= PCH_GBE_TXD_CTRL_APAD |
                              PCH_GBE_TXD_CTRL_TCPIP_ACC_OFF;
                if (skb->protocol == htons(ETH_P_IP)) {
@@ -1429,7 +1430,7 @@ pch_gbe_clean_rx(struct pch_gbe_adapter *adapter,
                        length = (rx_desc->rx_words_eob) - 3;
                        /* Decide the data conversion method */
-                        if (!adapter->rx_csum) {
+                        if (!(netdev->features & NETIF_F_RXCSUM)) {
                                /* [Header:14][payload] */
                                if (NET_IP_ALIGN) {
                                        /* Because alignment differs,
@@ -2032,6 +2033,29 @@ static int pch_gbe_change_mtu(struct net_device *netdev, int new_mtu)
 }
 /**
+ * pch_gbe_set_features - Reset device after features changed
+ * @netdev:   Network interface device structure
+ * @features:  New features
+ * Returns
+ *      0:              HW state updated successfully
+ */
+static int pch_gbe_set_features(struct net_device *netdev, u32 features)
+{
+        struct pch_gbe_adapter *adapter = netdev_priv(netdev);
+        u32 changed = features ^ netdev->features;
+        if (!(changed & NETIF_F_RXCSUM))
+                return 0;
+        if (netif_running(netdev))
+                pch_gbe_reinit_locked(adapter);
+        else
+                pch_gbe_reset(adapter);
+        return 0;
+}
+/**
 * pch_gbe_ioctl - Controls register through a MII interface
 * @netdev:   Network interface device structure
 * @ifr:      Pointer to ifr structure
@@ -2131,6 +2155,7 @@ static const struct net_device_ops pch_gbe_netdev_ops = {
        .ndo_set_mac_address = pch_gbe_set_mac,
        .ndo_tx_timeout = pch_gbe_tx_timeout,
        .ndo_change_mtu = pch_gbe_change_mtu,
+        .ndo_set_features = pch_gbe_set_features,
        .ndo_do_ioctl = pch_gbe_ioctl,
        .ndo_set_multicast_list = &pch_gbe_set_multi,
 #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -2336,7 +2361,9 @@ static int pch_gbe_probe(struct pci_dev *pdev,
        netdev->watchdog_timeo = PCH_GBE_WATCHDOG_PERIOD;
        netif_napi_add(netdev, &adapter->napi,
                       pch_gbe_napi_poll, PCH_GBE_RX_WEIGHT);
-        netdev->features = NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_GRO;
+        netdev->hw_features = NETIF_F_RXCSUM |
+                NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
+        netdev->features = netdev->hw_features;
        pch_gbe_set_ethtool_ops(netdev);
        pch_gbe_mac_load_mac_addr(&adapter->hw);
@@ -2375,11 +2402,6 @@ static int pch_gbe_probe(struct pci_dev *pdev,
        pch_gbe_check_options(adapter);
-        if (adapter->tx_csum)
-                netdev->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
-        else
-                netdev->features &= ~(NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM);
        /* initialize the wol settings based on the eeprom settings */
        adapter->wake_up_evt = PCH_GBE_WL_INIT_SETTING;
        dev_info(&pdev->dev, "MAC address : %pM\n", netdev->dev_addr);
diff --git a/drivers/net/pch_gbe/pch_gbe_param.c b/drivers/net/pch_gbe/pch_gbe_param.c
index ef0996a0eaaa..5b5d90a47e29 100644
--- a/drivers/net/pch_gbe/pch_gbe_param.c
+++ b/drivers/net/pch_gbe/pch_gbe_param.c
@@ -426,6 +426,8 @@ full_duplex_only:
 void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
 {
        struct pch_gbe_hw *hw = &adapter->hw;
+        struct net_device *dev = adapter->netdev;
+        int val;
        { /* Transmit Descriptor Count */
                static const struct pch_gbe_option opt = {
@@ -466,9 +468,10 @@ void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
                        .err  = "defaulting to Enabled",
                        .def  = PCH_GBE_DEFAULT_RX_CSUM
                };
-                adapter->rx_csum = XsumRX;
+                val = XsumRX;
-                pch_gbe_validate_option((int *)(&adapter->rx_csum),
+                pch_gbe_validate_option(&val, &opt, adapter);
-                                        &opt, adapter);
+                if (!val)
+                        dev->features &= ~NETIF_F_RXCSUM;
        }
        { /* Checksum Offload Enable/Disable */
                static const struct pch_gbe_option opt = {
@@ -477,9 +480,10 @@ void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
                        .err  = "defaulting to Enabled",
                        .def  = PCH_GBE_DEFAULT_TX_CSUM
                };
-                adapter->tx_csum = XsumTX;
+                val = XsumTX;
-                pch_gbe_validate_option((int *)(&adapter->tx_csum),
+                pch_gbe_validate_option(&val, &opt, adapter);
-                                                &opt, adapter);
+                if (!val)
+                        dev->features &= ~NETIF_F_ALL_CSUM;
        }
        { /* Flow Control */
                static const struct pch_gbe_option opt = {
diff --git a/drivers/net/pch_gbe/pch_gbe_phy.c b/drivers/net/pch_gbe/pch_gbe_phy.c
index 923a687acd30..28bb9603d736 100644
--- a/drivers/net/pch_gbe/pch_gbe_phy.c
+++ b/drivers/net/pch_gbe/pch_gbe_phy.c
@@ -247,7 +247,7 @@ inline void pch_gbe_phy_set_rgmii(struct pch_gbe_hw *hw)
 void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw)
 {
        struct pch_gbe_adapter *adapter;
-        struct ethtool_cmd     cmd;
+        struct ethtool_cmd     cmd = { .cmd = ETHTOOL_GSET };
        int ret;
        u16 mii_reg;
@@ -256,7 +256,7 @@ void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw)
        if (ret)
                pr_err("Error: mii_ethtool_gset\n");
-        cmd.speed = hw->mac.link_speed;
+        ethtool_cmd_speed_set(&cmd, hw->mac.link_speed);
        cmd.duplex = hw->mac.link_duplex;
        cmd.advertising = hw->phy.autoneg_advertised;
        cmd.autoneg = hw->mac.autoneg;
diff --git a/drivers/net/pcmcia/smc91c92_cs.c b/drivers/net/pcmcia/smc91c92_cs.c
index 108591756440..288e4f1317ee 100644
--- a/drivers/net/pcmcia/smc91c92_cs.c
+++ b/drivers/net/pcmcia/smc91c92_cs.c
@@ -1860,7 +1860,7 @@ static int smc_netdev_get_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
    tmp = inw(ioaddr + CONFIG);
    ecmd->port = (tmp & CFG_AUI_SELECT) ? PORT_AUI : PORT_TP;
    ecmd->transceiver = XCVR_INTERNAL;
-    ecmd->speed = SPEED_10;
+    ethtool_cmd_speed_set(ecmd, SPEED_10);
    ecmd->phy_address = ioaddr + MGMT;
    SMC_SELECT_BANK(0);
@@ -1875,8 +1875,8 @@ static int smc_netdev_set_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
    u16 tmp;
    unsigned int ioaddr = dev->base_addr;
-    if (ecmd->speed != SPEED_10)
+    if (ethtool_cmd_speed(ecmd) != SPEED_10)
-        return -EINVAL;
+        return -EINVAL;
    if (ecmd->duplex != DUPLEX_HALF && ecmd->duplex != DUPLEX_FULL)
        return -EINVAL;
    if (ecmd->port != PORT_TP && ecmd->port != PORT_AUI)
diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c
index 768037602dff..b48aba9e4227 100644
--- a/drivers/net/pcnet32.c
+++ b/drivers/net/pcnet32.c
@@ -295,12 +295,14 @@ struct pcnet32_private {
        struct net_device       *next;
        struct mii_if_info      mii_if;
        struct timer_list       watchdog_timer;
-        struct timer_list       blink_timer;
        u32                     msg_enable;     /* debug message level */
        /* each bit indicates an available PHY */
        u32                     phymask;
        unsigned short          chip_version;   /* which variant this is */
+        /* saved registers during ethtool blink */
+        u16                     save_regs[4];
 };
 static int pcnet32_probe_pci(struct pci_dev *, const struct pci_device_id *);
@@ -324,8 +326,6 @@ static void pcnet32_restart(struct net_device *dev, unsigned int csr0_bits);
 static void pcnet32_ethtool_test(struct net_device *dev,
                                 struct ethtool_test *eth_test, u64 * data);
 static int pcnet32_loopback_test(struct net_device *dev, uint64_t * data1);
-static int pcnet32_phys_id(struct net_device *dev, u32 data);
-static void pcnet32_led_blink_callback(struct net_device *dev);
 static int pcnet32_get_regs_len(struct net_device *dev);
 static void pcnet32_get_regs(struct net_device *dev, struct ethtool_regs *regs,
                             void *ptr);
@@ -1022,7 +1022,8 @@ clean_up:
        return rc;
 }                               /* end pcnet32_loopback_test  */
-static void pcnet32_led_blink_callback(struct net_device *dev)
+static int pcnet32_set_phys_id(struct net_device *dev,
+                               enum ethtool_phys_id_state state)
 {
        struct pcnet32_private *lp = netdev_priv(dev);
        struct pcnet32_access *a = &lp->a;
@@ -1030,50 +1031,31 @@ static void pcnet32_led_blink_callback(struct net_device *dev)
        unsigned long flags;
        int i;
-        spin_lock_irqsave(&lp->lock, flags);
+        switch (state) {
-        for (i = 4; i < 8; i++)
+        case ETHTOOL_ID_ACTIVE:
-                a->write_bcr(ioaddr, i, a->read_bcr(ioaddr, i) ^ 0x4000);
+                /* Save the current value of the bcrs */
-        spin_unlock_irqrestore(&lp->lock, flags);
+                spin_lock_irqsave(&lp->lock, flags);
+                for (i = 4; i < 8; i++)
-        mod_timer(&lp->blink_timer, PCNET32_BLINK_TIMEOUT);
+                        lp->save_regs[i - 4] = a->read_bcr(ioaddr, i);
-}
+                spin_unlock_irqrestore(&lp->lock, flags);
+                return 2;       /* cycle on/off twice per second */
-static int pcnet32_phys_id(struct net_device *dev, u32 data)
+        case ETHTOOL_ID_ON:
-{
+        case ETHTOOL_ID_OFF:
-        struct pcnet32_private *lp = netdev_priv(dev);
+                /* Blink the led */
-        struct pcnet32_access *a = &lp->a;
+                spin_lock_irqsave(&lp->lock, flags);
-        ulong ioaddr = dev->base_addr;
+                for (i = 4; i < 8; i++)
-        unsigned long flags;
+                        a->write_bcr(ioaddr, i, a->read_bcr(ioaddr, i) ^ 0x4000);
-        int i, regs[4];
+                spin_unlock_irqrestore(&lp->lock, flags);
+                break;
-        if (!lp->blink_timer.function) {
+        case ETHTOOL_ID_INACTIVE:
-                init_timer(&lp->blink_timer);
+                /* Restore the original value of the bcrs */
-                lp->blink_timer.function = (void *)pcnet32_led_blink_callback;
+                spin_lock_irqsave(&lp->lock, flags);
-                lp->blink_timer.data = (unsigned long)dev;
+                for (i = 4; i < 8; i++)
+                        a->write_bcr(ioaddr, i, lp->save_regs[i - 4]);
+                spin_unlock_irqrestore(&lp->lock, flags);
        }
-        /* Save the current value of the bcrs */
-        spin_lock_irqsave(&lp->lock, flags);
-        for (i = 4; i < 8; i++)
-                regs[i - 4] = a->read_bcr(ioaddr, i);
-        spin_unlock_irqrestore(&lp->lock, flags);
-        mod_timer(&lp->blink_timer, jiffies);
-        set_current_state(TASK_INTERRUPTIBLE);
-        /* AV: the limit here makes no sense whatsoever */
-        if ((!data) || (data > (u32) (MAX_SCHEDULE_TIMEOUT / HZ)))
-                data = (u32) (MAX_SCHEDULE_TIMEOUT / HZ);
-        msleep_interruptible(data * 1000);
-        del_timer_sync(&lp->blink_timer);
-        /* Restore the original value of the bcrs */
-        spin_lock_irqsave(&lp->lock, flags);
-        for (i = 4; i < 8; i++)
-                a->write_bcr(ioaddr, i, regs[i - 4]);
-        spin_unlock_irqrestore(&lp->lock, flags);
        return 0;
 }
@@ -1450,7 +1432,7 @@ static const struct ethtool_ops pcnet32_ethtool_ops = {
        .set_ringparam          = pcnet32_set_ringparam,
        .get_strings            = pcnet32_get_strings,
        .self_test              = pcnet32_ethtool_test,
-        .phys_id                = pcnet32_phys_id,
+        .set_phys_id            = pcnet32_set_phys_id,
        .get_regs_len           = pcnet32_get_regs_len,
        .get_regs               = pcnet32_get_regs,
        .get_sset_count         = pcnet32_get_sset_count,
@@ -2117,7 +2099,7 @@ static int pcnet32_open(struct net_device *dev)
                int first_phy = -1;
                u16 bmcr;
                u32 bcr9;
-                struct ethtool_cmd ecmd;
+                struct ethtool_cmd ecmd = { .cmd = ETHTOOL_GSET };
                /*
                 * There is really no good other way to handle multiple PHYs
@@ -2133,9 +2115,9 @@ static int pcnet32_open(struct net_device *dev)
                        ecmd.port = PORT_MII;
                        ecmd.transceiver = XCVR_INTERNAL;
                        ecmd.autoneg = AUTONEG_DISABLE;
-                        ecmd.speed =
+                        ethtool_cmd_speed_set(&ecmd,
-                            lp->
+                                              (lp->options & PCNET32_PORT_100) ?
-                            options & PCNET32_PORT_100 ? SPEED_100 : SPEED_10;
+                                              SPEED_100 : SPEED_10);
                        bcr9 = lp->a.read_bcr(ioaddr, 9);
                        if (lp->options & PCNET32_PORT_FD) {
@@ -2781,11 +2763,11 @@ static void pcnet32_check_media(struct net_device *dev, int verbose)
                netif_carrier_on(dev);
                if (lp->mii) {
                        if (netif_msg_link(lp)) {
-                                struct ethtool_cmd ecmd;
+                                struct ethtool_cmd ecmd = {
+                                        .cmd = ETHTOOL_GSET };
                                mii_ethtool_gset(&lp->mii_if, &ecmd);
-                                netdev_info(dev, "link up, %sMbps, %s-duplex\n",
+                                netdev_info(dev, "link up, %uMbps, %s-duplex\n",
-                                            (ecmd.speed == SPEED_100)
+                                            ethtool_cmd_speed(&ecmd),
-                                            ? "100" : "10",
                                            (ecmd.duplex == DUPLEX_FULL)
                                            ? "full" : "half");
                        }
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index f7670330f988..a47595760751 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -238,6 +238,8 @@ static void phy_sanitize_settings(struct phy_device *phydev)
 */
 int phy_ethtool_sset(struct phy_device *phydev, struct ethtool_cmd *cmd)
 {
+        u32 speed = ethtool_cmd_speed(cmd);
        if (cmd->phy_address != phydev->addr)
                return -EINVAL;
@@ -253,16 +255,16 @@ int phy_ethtool_sset(struct phy_device *phydev, struct ethtool_cmd *cmd)
                return -EINVAL;
        if (cmd->autoneg == AUTONEG_DISABLE &&
-            ((cmd->speed != SPEED_1000 &&
+            ((speed != SPEED_1000 &&
-              cmd->speed != SPEED_100 &&
+              speed != SPEED_100 &&
-              cmd->speed != SPEED_10) ||
+              speed != SPEED_10) ||
             (cmd->duplex != DUPLEX_HALF &&
              cmd->duplex != DUPLEX_FULL)))
                return -EINVAL;
        phydev->autoneg = cmd->autoneg;
-        phydev->speed = cmd->speed;
+        phydev->speed = speed;
        phydev->advertising = cmd->advertising;
@@ -286,7 +288,7 @@ int phy_ethtool_gset(struct phy_device *phydev, struct ethtool_cmd *cmd)
        cmd->advertising = phydev->advertising;
-        cmd->speed = phydev->speed;
+        ethtool_cmd_speed_set(cmd, phydev->speed);
        cmd->duplex = phydev->duplex;
        cmd->port = PORT_MII;
        cmd->phy_address = phydev->addr;
diff --git a/drivers/net/pptp.c b/drivers/net/pptp.c
index 51dfcf8023c7..1286fe212dc4 100644
--- a/drivers/net/pptp.c
+++ b/drivers/net/pptp.c
@@ -175,6 +175,7 @@ static int pptp_xmit(struct ppp_channel *chan, struct sk_buff *skb)
        struct pptp_opt *opt = &po->proto.pptp;
        struct pptp_gre_header *hdr;
        unsigned int header_len = sizeof(*hdr);
+        struct flowi4 fl4;
        int islcp;
        int len;
        unsigned char *data;
@@ -189,7 +190,7 @@ static int pptp_xmit(struct ppp_channel *chan, struct sk_buff *skb)
        if (sk_pppox(po)->sk_state & PPPOX_DEAD)
                goto tx_error;
-        rt = ip_route_output_ports(&init_net, NULL,
+        rt = ip_route_output_ports(&init_net, &fl4, NULL,
                                   opt->dst_addr.sin_addr.s_addr,
                                   opt->src_addr.sin_addr.s_addr,
                                   0, 0, IPPROTO_GRE,
@@ -270,8 +271,8 @@ static int pptp_xmit(struct ppp_channel *chan, struct sk_buff *skb)
                iph->frag_off   =       0;
        iph->protocol = IPPROTO_GRE;
        iph->tos      = 0;
-        iph->daddr    = rt->rt_dst;
+        iph->daddr    = fl4.daddr;
-        iph->saddr    = rt->rt_src;
+        iph->saddr    = fl4.saddr;
        iph->ttl      = ip4_dst_hoplimit(&rt->dst);
        iph->tot_len  = htons(skb->len);
@@ -434,6 +435,7 @@ static int pptp_connect(struct socket *sock, struct sockaddr *uservaddr,
        struct pppox_sock *po = pppox_sk(sk);
        struct pptp_opt *opt = &po->proto.pptp;
        struct rtable *rt;
+        struct flowi4 fl4;
        int error = 0;
        if (sp->sa_protocol != PX_PROTO_PPTP)
@@ -463,7 +465,7 @@ static int pptp_connect(struct socket *sock, struct sockaddr *uservaddr,
        po->chan.private = sk;
        po->chan.ops = &pptp_chan_ops;
-        rt = ip_route_output_ports(&init_net, sk,
+        rt = ip_route_output_ports(&init_net, &fl4, sk,
                                   opt->dst_addr.sin_addr.s_addr,
                                   opt->src_addr.sin_addr.s_addr,
                                   0, 0,
diff --git a/drivers/net/ps3_gelic_net.c b/drivers/net/ps3_gelic_net.c
index ffdf7349ef7a..b1f251da1535 100644
--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -951,7 +951,7 @@ static void gelic_net_pass_skb_up(struct gelic_descr *descr,
        skb->protocol = eth_type_trans(skb, netdev);
        /* checksum offload */
-        if (card->rx_csum) {
+        if (netdev->features & NETIF_F_RXCSUM) {
                if ((data_status & GELIC_DESCR_DATA_STATUS_CHK_MASK) &&
                    (!(data_error & GELIC_DESCR_DATA_ERROR_CHK_MASK)))
                        skb->ip_summed = CHECKSUM_UNNECESSARY;
@@ -1243,17 +1243,17 @@ static int gelic_ether_get_settings(struct net_device *netdev,
        switch (card->ether_port_status & GELIC_LV1_ETHER_SPEED_MASK) {
        case GELIC_LV1_ETHER_SPEED_10:
-                cmd->speed = SPEED_10;
+                ethtool_cmd_speed_set(cmd, SPEED_10);
                break;
        case GELIC_LV1_ETHER_SPEED_100:
-                cmd->speed = SPEED_100;
+                ethtool_cmd_speed_set(cmd, SPEED_100);
                break;
        case GELIC_LV1_ETHER_SPEED_1000:
-                cmd->speed = SPEED_1000;
+                ethtool_cmd_speed_set(cmd, SPEED_1000);
                break;
        default:
                pr_info("%s: speed unknown\n", __func__);
-                cmd->speed = SPEED_10;
+                ethtool_cmd_speed_set(cmd, SPEED_10);
                break;
        }
@@ -1312,21 +1312,6 @@ static int gelic_ether_set_settings(struct net_device *netdev,
        return 0;
 }
-u32 gelic_net_get_rx_csum(struct net_device *netdev)
-{
-        struct gelic_card *card = netdev_card(netdev);
-        return card->rx_csum;
-}
-int gelic_net_set_rx_csum(struct net_device *netdev, u32 data)
-{
-        struct gelic_card *card = netdev_card(netdev);
-        card->rx_csum = data;
-        return 0;
-}
 static void gelic_net_get_wol(struct net_device *netdev,
                              struct ethtool_wolinfo *wol)
 {
@@ -1411,10 +1396,6 @@ static const struct ethtool_ops gelic_ether_ethtool_ops = {
        .get_settings   = gelic_ether_get_settings,
        .set_settings   = gelic_ether_set_settings,
        .get_link       = ethtool_op_get_link,
-        .get_tx_csum    = ethtool_op_get_tx_csum,
-        .set_tx_csum    = ethtool_op_set_tx_csum,
-        .get_rx_csum    = gelic_net_get_rx_csum,
-        .set_rx_csum    = gelic_net_set_rx_csum,
        .get_wol        = gelic_net_get_wol,
        .set_wol        = gelic_net_set_wol,
 };
@@ -1512,7 +1493,11 @@ int __devinit gelic_net_setup_netdev(struct net_device *netdev,
        int status;
        u64 v1, v2;
+        netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_RXCSUM;
        netdev->features = NETIF_F_IP_CSUM;
+        if (GELIC_CARD_RX_CSUM_DEFAULT)
+                netdev->features |= NETIF_F_RXCSUM;
        status = lv1_net_control(bus_id(card), dev_id(card),
                                 GELIC_LV1_GET_MAC_ADDRESS,
@@ -1756,7 +1741,6 @@ static int __devinit ps3_gelic_driver_probe(struct ps3_system_bus_device *dev)
        /* setup card structure */
        card->irq_mask = GELIC_CARD_RXINT | GELIC_CARD_TXINT |
                GELIC_CARD_PORT_STATUS_CHANGED;
-        card->rx_csum = GELIC_CARD_RX_CSUM_DEFAULT;
        if (gelic_card_init_chain(card, &card->tx_chain,
diff --git a/drivers/net/ps3_gelic_net.h b/drivers/net/ps3_gelic_net.h
index fadadf9097a3..d9a55b93898b 100644
--- a/drivers/net/ps3_gelic_net.h
+++ b/drivers/net/ps3_gelic_net.h
@@ -290,7 +290,6 @@ struct gelic_card {
        struct gelic_descr_chain tx_chain;
        struct gelic_descr_chain rx_chain;
        int rx_dma_restart_required;
-        int rx_csum;
        /*
         * tx_lock guards tx descriptor list and
         * tx_dma_progress.
@@ -377,8 +376,6 @@ extern int gelic_net_setup_netdev(struct net_device *netdev,
 /* shared ethtool ops */
 extern void gelic_net_get_drvinfo(struct net_device *netdev,
                                  struct ethtool_drvinfo *info);
-extern u32 gelic_net_get_rx_csum(struct net_device *netdev);
-extern int gelic_net_set_rx_csum(struct net_device *netdev, u32 data);
 extern void gelic_net_poll_controller(struct net_device *netdev);
 #endif /* _GELIC_NET_H */
diff --git a/drivers/net/ps3_gelic_wireless.c b/drivers/net/ps3_gelic_wireless.c
index b5ae29d20f2e..2e62938c0f82 100644
--- a/drivers/net/ps3_gelic_wireless.c
+++ b/drivers/net/ps3_gelic_wireless.c
@@ -2581,10 +2581,6 @@ static const struct net_device_ops gelic_wl_netdevice_ops = {
 static const struct ethtool_ops gelic_wl_ethtool_ops = {
        .get_drvinfo    = gelic_net_get_drvinfo,
        .get_link       = gelic_wl_get_link,
-        .get_tx_csum    = ethtool_op_get_tx_csum,
-        .set_tx_csum    = ethtool_op_set_tx_csum,
-        .get_rx_csum    = gelic_net_get_rx_csum,
-        .set_rx_csum    = gelic_net_set_rx_csum,
 };
 static void __devinit gelic_wl_setup_netdev_ops(struct net_device *netdev)
diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index 348b4f1367c9..d495a6859fd9 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -1725,7 +1725,7 @@ static int ql_get_settings(struct net_device *ndev, struct ethtool_cmd *ecmd)
        }
        ecmd->advertising = ql_supported_modes(qdev);
        ecmd->autoneg = ql_get_auto_cfg_status(qdev);
-        ecmd->speed = ql_get_speed(qdev);
+        ethtool_cmd_speed_set(ecmd, ql_get_speed(qdev));
        ecmd->duplex = ql_get_full_dup(qdev);
        return 0;
 }
@@ -3468,7 +3468,7 @@ static int ql_adapter_up(struct ql3_adapter *qdev)
 {
        struct net_device *ndev = qdev->ndev;
        int err;
-        unsigned long irq_flags = IRQF_SAMPLE_RANDOM | IRQF_SHARED;
+        unsigned long irq_flags = IRQF_SHARED;
        unsigned long hw_flags;
        if (ql_alloc_mem_resources(qdev)) {
diff --git a/drivers/net/qlcnic/qlcnic.h b/drivers/net/qlcnic/qlcnic.h
index b0dead00b2d1..480ef5cb6ef9 100644
--- a/drivers/net/qlcnic/qlcnic.h
+++ b/drivers/net/qlcnic/qlcnic.h
@@ -29,13 +29,15 @@
 #include <linux/io.h>
 #include <asm/byteorder.h>
+#include <linux/bitops.h>
+#include <linux/if_vlan.h>
 #include "qlcnic_hdr.h"
 #define _QLCNIC_LINUX_MAJOR 5
 #define _QLCNIC_LINUX_MINOR 0
-#define _QLCNIC_LINUX_SUBVERSION 15
+#define _QLCNIC_LINUX_SUBVERSION 18
-#define QLCNIC_LINUX_VERSIONID  "5.0.15"
+#define QLCNIC_LINUX_VERSIONID  "5.0.18"
 #define QLCNIC_DRV_IDC_VER  0x01
 #define QLCNIC_DRIVER_VERSION  ((_QLCNIC_LINUX_MAJOR << 16) |\
                 (_QLCNIC_LINUX_MINOR << 8) | (_QLCNIC_LINUX_SUBVERSION))
@@ -93,8 +95,6 @@
 #define TX_IP_PKT       0x04
 #define TX_TCP_LSO      0x05
 #define TX_TCP_LSO6     0x06
-#define TX_IPSEC        0x07
-#define TX_IPSEC_CMD    0x0a
 #define TX_TCPV6_PKT    0x0b
 #define TX_UDPV6_PKT    0x0c
@@ -118,7 +118,6 @@
 #define PHAN_PEG_RCV_INITIALIZED        0xff01
 #define NUM_RCV_DESC_RINGS      3
-#define NUM_STS_DESC_RINGS      4
 #define RCV_RING_NORMAL 0
 #define RCV_RING_JUMBO  1
@@ -201,7 +200,7 @@ struct rcv_desc {
        __le16 reserved;
        __le32 buffer_length;   /* allocated buffer length (usually 2K) */
        __le64 addr_buffer;
-};
+} __packed;
 /* opcode field in status_desc */
 #define QLCNIC_SYN_OFFLOAD      0x03
@@ -293,6 +292,7 @@ struct uni_data_desc{
 /* Flash Defines and Structures */
 #define QLCNIC_FLT_LOCATION     0x3F1000
 #define QLCNIC_FW_IMAGE_REGION  0x74
+#define QLCNIC_BOOTLD_REGION    0X72
 struct qlcnic_flt_header {
        u16 version;
        u16 len;
@@ -307,7 +307,7 @@ struct qlcnic_flt_entry {
        u8 reserved1;
        u32 size;
        u32 start_addr;
-        u32 end_add;
+        u32 end_addr;
 };
 /* Magic number to let user know flash is programmed */
@@ -366,12 +366,6 @@ struct qlcnic_skb_frag {
        u64 length;
 };
-struct qlcnic_recv_crb {
-        u32 crb_rcv_producer[NUM_RCV_DESC_RINGS];
-        u32 crb_sts_consumer[NUM_STS_DESC_RINGS];
-        u32 sw_int_mask[NUM_STS_DESC_RINGS];
-};
 /*    Following defines are for the state of the buffers    */
 #define QLCNIC_BUFFER_FREE      0
 #define QLCNIC_BUFFER_BUSY      1
@@ -388,10 +382,10 @@ struct qlcnic_cmd_buffer {
 /* In rx_buffer, we do not need multiple fragments as is a single buffer */
 struct qlcnic_rx_buffer {
-        struct list_head list;
+        u16 ref_handle;
        struct sk_buff *skb;
+        struct list_head list;
        u64 dma;
-        u16 ref_handle;
 };
 /* Board types */
@@ -399,6 +393,48 @@ struct qlcnic_rx_buffer {
 #define QLCNIC_XGBE     0x02
 /*
+ * Interrupt coalescing defaults. The defaults are for 1500 MTU. It is
+ * adjusted based on configured MTU.
+ */
+#define QLCNIC_DEFAULT_INTR_COALESCE_RX_TIME_US 3
+#define QLCNIC_DEFAULT_INTR_COALESCE_RX_PACKETS 256
+#define QLCNIC_INTR_DEFAULT                     0x04
+#define QLCNIC_CONFIG_INTR_COALESCE             3
+struct qlcnic_nic_intr_coalesce {
+        u8      type;
+        u8      sts_ring_mask;
+        u16     rx_packets;
+        u16     rx_time_us;
+        u16     flag;
+        u32     timer_out;
+};
+struct qlcnic_dump_template_hdr {
+        __le32  type;
+        __le32  offset;
+        __le32  size;
+        __le32  cap_mask;
+        __le32  num_entries;
+        __le32  version;
+        __le32  timestamp;
+        __le32  checksum;
+        __le32  drv_cap_mask;
+        __le32  sys_info[3];
+        __le32  saved_state[16];
+        __le32  cap_sizes[8];
+        __le32  rsvd[0];
+};
+struct qlcnic_fw_dump {
+        u8      clr;    /* flag to indicate if dump is cleared */
+        u32     size;   /* total size of the dump */
+        void    *data;  /* dump data area */
+        struct  qlcnic_dump_template_hdr *tmpl_hdr;
+};
+/*
 * One hardware_context{} per adapter
 * contains interrupt info as well shared hardware info.
 */
@@ -416,6 +452,9 @@ struct qlcnic_hardware_context {
        u8 linkup;
        u16 port_type;
        u16 board_type;
+        struct qlcnic_nic_intr_coalesce coal;
+        struct qlcnic_fw_dump fw_dump;
 };
 struct qlcnic_adapter_stats {
@@ -443,50 +482,49 @@ struct qlcnic_adapter_stats {
 * be one Rcv Descriptor for normal packets, one for jumbo and may be others.
 */
 struct qlcnic_host_rds_ring {
-        u32 producer;
+        void __iomem *crb_rcv_producer;
+        struct rcv_desc *desc_head;
+        struct qlcnic_rx_buffer *rx_buf_arr;
        u32 num_desc;
+        u32 producer;
        u32 dma_size;
        u32 skb_size;
        u32 flags;
-        void __iomem *crb_rcv_producer;
-        struct rcv_desc *desc_head;
-        struct qlcnic_rx_buffer *rx_buf_arr;
        struct list_head free_list;
        spinlock_t lock;
        dma_addr_t phys_addr;
-};
+} ____cacheline_internodealigned_in_smp;
 struct qlcnic_host_sds_ring {
        u32 consumer;
        u32 num_desc;
        void __iomem *crb_sts_consumer;
-        void __iomem *crb_intr_mask;
        struct status_desc *desc_head;
        struct qlcnic_adapter *adapter;
        struct napi_struct napi;
        struct list_head free_list[NUM_RCV_DESC_RINGS];
+        void __iomem *crb_intr_mask;
        int irq;
        dma_addr_t phys_addr;
        char name[IFNAMSIZ+4];
-};
+} ____cacheline_internodealigned_in_smp;
 struct qlcnic_host_tx_ring {
        u32 producer;
-        __le32 *hw_consumer;
        u32 sw_consumer;
-        void __iomem *crb_cmd_producer;
        u32 num_desc;
+        void __iomem *crb_cmd_producer;
-        struct netdev_queue *txq;
-        struct qlcnic_cmd_buffer *cmd_buf_arr;
        struct cmd_desc_type0 *desc_head;
+        struct qlcnic_cmd_buffer *cmd_buf_arr;
+        __le32 *hw_consumer;
        dma_addr_t phys_addr;
        dma_addr_t hw_cons_phys_addr;
-};
+        struct netdev_queue *txq;
+} ____cacheline_internodealigned_in_smp;
 /*
 * Receive context. There is one such structure per instance of the
@@ -495,12 +533,12 @@ struct qlcnic_host_tx_ring {
 * present elsewhere.
 */
 struct qlcnic_recv_context {
+        struct qlcnic_host_rds_ring *rds_rings;
+        struct qlcnic_host_sds_ring *sds_rings;
        u32 state;
        u16 context_id;
        u16 virt_port;
-        struct qlcnic_host_rds_ring *rds_rings;
-        struct qlcnic_host_sds_ring *sds_rings;
 };
 /* HW context creation */
@@ -539,9 +577,6 @@ struct qlcnic_recv_context {
 #define QLCNIC_CDRP_CMD_DESTROY_RX_CTX          0x00000008
 #define QLCNIC_CDRP_CMD_CREATE_TX_CTX           0x00000009
 #define QLCNIC_CDRP_CMD_DESTROY_TX_CTX          0x0000000a
-#define QLCNIC_CDRP_CMD_SETUP_STATISTICS        0x0000000e
-#define QLCNIC_CDRP_CMD_GET_STATISTICS          0x0000000f
-#define QLCNIC_CDRP_CMD_DELETE_STATISTICS       0x00000010
 #define QLCNIC_CDRP_CMD_SET_MTU                 0x00000012
 #define QLCNIC_CDRP_CMD_READ_PHY                0x00000013
 #define QLCNIC_CDRP_CMD_WRITE_PHY               0x00000014
@@ -550,17 +585,11 @@ struct qlcnic_recv_context {
 #define QLCNIC_CDRP_CMD_SET_FLOW_CTL            0x00000017
 #define QLCNIC_CDRP_CMD_READ_MAX_MTU            0x00000018
 #define QLCNIC_CDRP_CMD_READ_MAX_LRO            0x00000019
-#define QLCNIC_CDRP_CMD_CONFIGURE_TOE           0x0000001a
-#define QLCNIC_CDRP_CMD_FUNC_ATTRIB             0x0000001b
-#define QLCNIC_CDRP_CMD_READ_PEXQ_PARAMETERS    0x0000001c
-#define QLCNIC_CDRP_CMD_GET_LIC_CAPABILITIES    0x0000001d
-#define QLCNIC_CDRP_CMD_READ_MAX_LRO_PER_BOARD  0x0000001e
 #define QLCNIC_CDRP_CMD_MAC_ADDRESS             0x0000001f
 #define QLCNIC_CDRP_CMD_GET_PCI_INFO            0x00000020
 #define QLCNIC_CDRP_CMD_GET_NIC_INFO            0x00000021
 #define QLCNIC_CDRP_CMD_SET_NIC_INFO            0x00000022
-#define QLCNIC_CDRP_CMD_RESET_NPAR              0x00000023
 #define QLCNIC_CDRP_CMD_GET_ESWITCH_CAPABILITY  0x00000024
 #define QLCNIC_CDRP_CMD_TOGGLE_ESWITCH          0x00000025
 #define QLCNIC_CDRP_CMD_GET_ESWITCH_STATUS      0x00000026
@@ -568,8 +597,12 @@ struct qlcnic_recv_context {
 #define QLCNIC_CDRP_CMD_CONFIGURE_ESWITCH       0x00000028
 #define QLCNIC_CDRP_CMD_GET_ESWITCH_PORT_CONFIG 0x00000029
 #define QLCNIC_CDRP_CMD_GET_ESWITCH_STATS       0x0000002a
+#define QLCNIC_CDRP_CMD_CONFIG_PORT             0x0000002E
+#define QLCNIC_CDRP_CMD_TEMP_SIZE               0x0000002f
+#define QLCNIC_CDRP_CMD_GET_TEMP_HDR            0x00000030
 #define QLCNIC_RCODE_SUCCESS            0
+#define QLCNIC_RCODE_NOT_SUPPORTED      9
 #define QLCNIC_RCODE_TIMEOUT            17
 #define QLCNIC_DESTROY_CTX_RESET        0
@@ -598,14 +631,14 @@ struct qlcnic_hostrq_sds_ring {
        __le32 ring_size;               /* Ring entries */
        __le16 msi_index;
        __le16 rsvd;            /* Padding */
-};
+} __packed;
 struct qlcnic_hostrq_rds_ring {
        __le64 host_phys_addr;  /* Ring base addr */
        __le64 buff_size;               /* Packet buffer size */
        __le32 ring_size;               /* Ring entries */
        __le32 ring_kind;               /* Class of ring */
-};
+} __packed;
 struct qlcnic_hostrq_rx_ctx {
        __le64 host_rsp_dma_addr;       /* Response dma'd here */
@@ -626,17 +659,17 @@ struct qlcnic_hostrq_rx_ctx {
           - N hostrq_rds_rings
           - N hostrq_sds_rings */
        char data[0];
-};
+} __packed;
 struct qlcnic_cardrsp_rds_ring{
        __le32 host_producer_crb;       /* Crb to use */
        __le32 rsvd1;           /* Padding */
-};
+} __packed;
 struct qlcnic_cardrsp_sds_ring {
        __le32 host_consumer_crb;       /* Crb to use */
        __le32 interrupt_crb;   /* Crb to use */
-};
+} __packed;
 struct qlcnic_cardrsp_rx_ctx {
        /* These ring offsets are relative to data[0] below */
@@ -655,7 +688,7 @@ struct qlcnic_cardrsp_rx_ctx {
           - N cardrsp_rds_rings
           - N cardrs_sds_rings */
        char data[0];
-};
+} __packed;
 #define SIZEOF_HOSTRQ_RX(HOSTRQ_RX, rds_rings, sds_rings)       \
        (sizeof(HOSTRQ_RX) +                                    \
@@ -675,7 +708,7 @@ struct qlcnic_hostrq_cds_ring {
        __le64 host_phys_addr;  /* Ring base addr */
        __le32 ring_size;               /* Ring entries */
        __le32 rsvd;            /* Padding */
-};
+} __packed;
 struct qlcnic_hostrq_tx_ctx {
        __le64 host_rsp_dma_addr;       /* Response dma'd here */
@@ -690,12 +723,12 @@ struct qlcnic_hostrq_tx_ctx {
        __le16 rsvd3;           /* Padding */
        struct qlcnic_hostrq_cds_ring cds_ring; /* Desc of cds ring */
        u8  reserved[128];      /* future expansion */
-};
+} __packed;
 struct qlcnic_cardrsp_cds_ring {
        __le32 host_producer_crb;       /* Crb to use */
        __le32 interrupt_crb;   /* Crb to use */
-};
+} __packed;
 struct qlcnic_cardrsp_tx_ctx {
        __le32 host_ctx_state;  /* Starting state */
@@ -704,7 +737,7 @@ struct qlcnic_cardrsp_tx_ctx {
        u8  virt_port;          /* Virtual/Logical id of port */
        struct qlcnic_cardrsp_cds_ring cds_ring;        /* Card cds settings */
        u8  reserved[128];      /* future expansion */
-};
+} __packed;
 #define SIZEOF_HOSTRQ_TX(HOSTRQ_TX)     (sizeof(HOSTRQ_TX))
 #define SIZEOF_CARDRSP_TX(CARDRSP_TX)   (sizeof(CARDRSP_TX))
@@ -738,40 +771,6 @@ struct qlcnic_mac_list_s {
        uint8_t mac_addr[ETH_ALEN+2];
 };
-/*
- * Interrupt coalescing defaults. The defaults are for 1500 MTU. It is
- * adjusted based on configured MTU.
- */
-#define QLCNIC_DEFAULT_INTR_COALESCE_RX_TIME_US 3
-#define QLCNIC_DEFAULT_INTR_COALESCE_RX_PACKETS 256
-#define QLCNIC_DEFAULT_INTR_COALESCE_TX_PACKETS 64
-#define QLCNIC_DEFAULT_INTR_COALESCE_TX_TIME_US 4
-#define QLCNIC_INTR_DEFAULT                     0x04
-union qlcnic_nic_intr_coalesce_data {
-        struct {
-                u16     rx_packets;
-                u16     rx_time_us;
-                u16     tx_packets;
-                u16     tx_time_us;
-        } data;
-        u64             word;
-};
-struct qlcnic_nic_intr_coalesce {
-        u16             stats_time_us;
-        u16             rate_sample_time;
-        u16             flags;
-        u16             rsvd_1;
-        u32             low_threshold;
-        u32             high_threshold;
-        union qlcnic_nic_intr_coalesce_data     normal;
-        union qlcnic_nic_intr_coalesce_data     low;
-        union qlcnic_nic_intr_coalesce_data     high;
-        union qlcnic_nic_intr_coalesce_data     irq;
-};
 #define QLCNIC_HOST_REQUEST     0x13
 #define QLCNIC_REQUEST          0x14
@@ -783,50 +782,20 @@ struct qlcnic_nic_intr_coalesce {
 /*
 * Driver --> Firmware
 */
-#define QLCNIC_H2C_OPCODE_START                         0
+#define QLCNIC_H2C_OPCODE_CONFIG_RSS                    0x1
-#define QLCNIC_H2C_OPCODE_CONFIG_RSS                    1
+#define QLCNIC_H2C_OPCODE_CONFIG_INTR_COALESCE          0x3
-#define QLCNIC_H2C_OPCODE_CONFIG_RSS_TBL                2
+#define QLCNIC_H2C_OPCODE_CONFIG_LED                    0x4
-#define QLCNIC_H2C_OPCODE_CONFIG_INTR_COALESCE          3
+#define QLCNIC_H2C_OPCODE_LRO_REQUEST                   0x7
-#define QLCNIC_H2C_OPCODE_CONFIG_LED                    4
+#define QLCNIC_H2C_OPCODE_SET_MAC_RECEIVE_MODE          0xc
-#define QLCNIC_H2C_OPCODE_CONFIG_PROMISCUOUS            5
+#define QLCNIC_H2C_OPCODE_CONFIG_IPADDR         0x12
-#define QLCNIC_H2C_OPCODE_CONFIG_L2_MAC                 6
+#define QLCNIC_H2C_OPCODE_GET_LINKEVENT         0x15
-#define QLCNIC_H2C_OPCODE_LRO_REQUEST                   7
+#define QLCNIC_H2C_OPCODE_CONFIG_BRIDGING               0x17
-#define QLCNIC_H2C_OPCODE_GET_SNMP_STATS                8
+#define QLCNIC_H2C_OPCODE_CONFIG_HW_LRO         0x18
-#define QLCNIC_H2C_OPCODE_PROXY_START_REQUEST           9
-#define QLCNIC_H2C_OPCODE_PROXY_STOP_REQUEST            10
-#define QLCNIC_H2C_OPCODE_PROXY_SET_MTU                 11
-#define QLCNIC_H2C_OPCODE_PROXY_SET_VPORT_MISS_MODE     12
-#define QLCNIC_H2C_OPCODE_GET_FINGER_PRINT_REQUEST      13
-#define QLCNIC_H2C_OPCODE_INSTALL_LICENSE_REQUEST       14
-#define QLCNIC_H2C_OPCODE_GET_LICENSE_CAPABILITY_REQUEST        15
-#define QLCNIC_H2C_OPCODE_GET_NET_STATS                 16
-#define QLCNIC_H2C_OPCODE_PROXY_UPDATE_P2V              17
-#define QLCNIC_H2C_OPCODE_CONFIG_IPADDR                 18
-#define QLCNIC_H2C_OPCODE_PROXY_STOP_DONE               20
-#define QLCNIC_H2C_OPCODE_GET_LINKEVENT                 21
-#define QLCNIC_C2C_OPCODE                               22
-#define QLCNIC_H2C_OPCODE_CONFIG_BRIDGING               23
-#define QLCNIC_H2C_OPCODE_CONFIG_HW_LRO                 24
-#define QLCNIC_H2C_OPCODE_LAST                          25
 /*
 * Firmware --> Driver
 */
-#define QLCNIC_C2H_OPCODE_START                         128
-#define QLCNIC_C2H_OPCODE_CONFIG_RSS_RESPONSE           129
-#define QLCNIC_C2H_OPCODE_CONFIG_RSS_TBL_RESPONSE       130
-#define QLCNIC_C2H_OPCODE_CONFIG_MAC_RESPONSE           131
-#define QLCNIC_C2H_OPCODE_CONFIG_PROMISCUOUS_RESPONSE   132
-#define QLCNIC_C2H_OPCODE_CONFIG_L2_MAC_RESPONSE        133
-#define QLCNIC_C2H_OPCODE_LRO_DELETE_RESPONSE           134
-#define QLCNIC_C2H_OPCODE_LRO_ADD_FAILURE_RESPONSE      135
-#define QLCNIC_C2H_OPCODE_GET_SNMP_STATS                136
-#define QLCNIC_C2H_OPCODE_GET_FINGER_PRINT_REPLY        137
-#define QLCNIC_C2H_OPCODE_INSTALL_LICENSE_REPLY         138
-#define QLCNIC_C2H_OPCODE_GET_LICENSE_CAPABILITIES_REPLY 139
-#define QLCNIC_C2H_OPCODE_GET_NET_STATS_RESPONSE        140
 #define QLCNIC_C2H_OPCODE_GET_LINKEVENT_RESPONSE        141
-#define QLCNIC_C2H_OPCODE_LAST                          142
 #define VPORT_MISS_MODE_DROP            0 /* drop all unmatched */
 #define VPORT_MISS_MODE_ACCEPT_ALL      1 /* accept all packets */
@@ -895,7 +864,7 @@ struct qlcnic_nic_req {
        __le64 qhdr;
        __le64 req_hdr;
        __le64 words[6];
-};
+} __packed;
 struct qlcnic_mac_req {
        u8 op;
@@ -906,7 +875,7 @@ struct qlcnic_mac_req {
 struct qlcnic_vlan_req {
        __le16 vlan_id;
        __le16 rsvd[3];
-};
+} __packed;
 struct qlcnic_ipaddr {
        __be32 ipv4;
@@ -929,7 +898,8 @@ struct qlcnic_ipaddr {
 #define QLCNIC_IS_MSI_FAMILY(adapter) \
        ((adapter)->flags & (QLCNIC_MSI_ENABLED | QLCNIC_MSIX_ENABLED))
-#define MSIX_ENTRIES_PER_ADAPTER        NUM_STS_DESC_RINGS
+#define QLCNIC_DEF_NUM_STS_DESC_RINGS   4
+#define QLCNIC_MIN_NUM_RSS_RINGS        2
 #define QLCNIC_MSIX_TBL_SPACE           8192
 #define QLCNIC_PCI_REG_MSIX_TBL         0x44
 #define QLCNIC_MSIX_TBL_PGSIZE          4096
@@ -942,6 +912,7 @@ struct qlcnic_ipaddr {
 #define __QLCNIC_RESETTING              2
 #define __QLCNIC_START_FW               4
 #define __QLCNIC_AER                    5
+#define __QLCNIC_DIAG_RES_ALLOC         6
 #define QLCNIC_INTERRUPT_TEST           1
 #define QLCNIC_LOOPBACK_TEST            2
@@ -965,14 +936,14 @@ struct qlcnic_filter_hash {
 };
 struct qlcnic_adapter {
-        struct qlcnic_hardware_context ahw;
+        struct qlcnic_hardware_context *ahw;
+        struct qlcnic_recv_context *recv_ctx;
+        struct qlcnic_host_tx_ring *tx_ring;
        struct net_device *netdev;
        struct pci_dev *pdev;
-        struct list_head mac_list;
-        spinlock_t tx_clean_lock;
+        unsigned long state;
-        spinlock_t mac_learn_lock;
+        u32 flags;
        u16 num_txd;
        u16 num_rxd;
@@ -983,14 +954,12 @@ struct qlcnic_adapter {
        u8 max_rds_rings;
        u8 max_sds_rings;
        u8 msix_supported;
-        u8 rx_csum;
        u8 portnum;
        u8 physical_port;
        u8 reset_context;
        u8 mc_enabled;
        u8 max_mc_count;
-        u8 rss_supported;
        u8 fw_wait_cnt;
        u8 fw_fail_cnt;
        u8 tx_timeo_cnt;
@@ -1015,7 +984,6 @@ struct qlcnic_adapter {
        u32 fw_hal_version;
        u32 capabilities;
-        u32 flags;
        u32 irq;
        u32 temp;
@@ -1033,31 +1001,29 @@ struct qlcnic_adapter {
        u8 mac_addr[ETH_ALEN];
        u64 dev_rst_time;
+        unsigned long vlans[BITS_TO_LONGS(VLAN_N_VID)];
-        struct vlan_group *vlgrp;
        struct qlcnic_npar_info *npars;
        struct qlcnic_eswitch *eswitch;
        struct qlcnic_nic_template *nic_ops;
        struct qlcnic_adapter_stats stats;
+        struct list_head mac_list;
-        struct qlcnic_recv_context recv_ctx;
-        struct qlcnic_host_tx_ring *tx_ring;
        void __iomem    *tgt_mask_reg;
        void __iomem    *tgt_status_reg;
        void __iomem    *crb_int_state_reg;
        void __iomem    *isr_int_vec;
-        struct msix_entry msix_entries[MSIX_ENTRIES_PER_ADAPTER];
+        struct msix_entry *msix_entries;
        struct delayed_work fw_work;
-        struct qlcnic_nic_intr_coalesce coal;
        struct qlcnic_filter_hash fhash;
-        unsigned long state;
+        spinlock_t tx_clean_lock;
+        spinlock_t mac_learn_lock;
        __le32 file_prd_off;    /*File fw product offset*/
        u32 fw_version;
        const struct firmware *fw;
@@ -1079,7 +1045,7 @@ struct qlcnic_info {
        __le16  min_tx_bw;
        __le16  max_tx_bw;
        u8      reserved2[104];
-};
+} __packed;
 struct qlcnic_pci_info {
        __le16  id; /* pci function id */
@@ -1093,7 +1059,7 @@ struct qlcnic_pci_info {
        u8      mac[ETH_ALEN];
        u8      reserved2[106];
-};
+} __packed;
 struct qlcnic_npar_info {
        u16     pvid;
@@ -1210,15 +1176,160 @@ struct __qlcnic_esw_statistics {
        __le64 local_frames;
        __le64 numbytes;
        __le64 rsvd[3];
-};
+} __packed;
 struct qlcnic_esw_statistics {
        struct __qlcnic_esw_statistics rx;
        struct __qlcnic_esw_statistics tx;
 };
-int qlcnic_fw_cmd_query_phy(struct qlcnic_adapter *adapter, u32 reg, u32 *val);
+struct qlcnic_common_entry_hdr {
-int qlcnic_fw_cmd_set_phy(struct qlcnic_adapter *adapter, u32 reg, u32 val);
+        __le32  type;
+        __le32  offset;
+        __le32  cap_size;
+        u8      mask;
+        u8      rsvd[2];
+        u8      flags;
+} __packed;
+struct __crb {
+        __le32  addr;
+        u8      stride;
+        u8      rsvd1[3];
+        __le32  data_size;
+        __le32  no_ops;
+        __le32  rsvd2[4];
+} __packed;
+struct __ctrl {
+        __le32  addr;
+        u8      stride;
+        u8      index_a;
+        __le16  timeout;
+        __le32  data_size;
+        __le32  no_ops;
+        u8      opcode;
+        u8      index_v;
+        u8      shl_val;
+        u8      shr_val;
+        __le32  val1;
+        __le32  val2;
+        __le32  val3;
+} __packed;
+struct __cache {
+        __le32  addr;
+        u8      stride;
+        u8      rsvd;
+        __le16  init_tag_val;
+        __le32  size;
+        __le32  no_ops;
+        __le32  ctrl_addr;
+        __le32  ctrl_val;
+        __le32  read_addr;
+        u8      read_addr_stride;
+        u8      read_addr_num;
+        u8      rsvd1[2];
+} __packed;
+struct __ocm {
+        u8      rsvd[8];
+        __le32  size;
+        __le32  no_ops;
+        u8      rsvd1[8];
+        __le32  read_addr;
+        __le32  read_addr_stride;
+} __packed;
+struct __mem {
+        u8      rsvd[24];
+        __le32  addr;
+        __le32  size;
+} __packed;
+struct __mux {
+        __le32  addr;
+        u8      rsvd[4];
+        __le32  size;
+        __le32  no_ops;
+        __le32  val;
+        __le32  val_stride;
+        __le32  read_addr;
+        u8      rsvd2[4];
+} __packed;
+struct __queue {
+        __le32  sel_addr;
+        __le16  stride;
+        u8      rsvd[2];
+        __le32  size;
+        __le32  no_ops;
+        u8      rsvd2[8];
+        __le32  read_addr;
+        u8      read_addr_stride;
+        u8      read_addr_cnt;
+        u8      rsvd3[2];
+} __packed;
+struct qlcnic_dump_entry {
+        struct qlcnic_common_entry_hdr hdr;
+        union {
+                struct __crb    crb;
+                struct __cache  cache;
+                struct __ocm    ocm;
+                struct __mem    mem;
+                struct __mux    mux;
+                struct __queue  que;
+                struct __ctrl   ctrl;
+        } region;
+} __packed;
+enum op_codes {
+        QLCNIC_DUMP_NOP         = 0,
+        QLCNIC_DUMP_READ_CRB    = 1,
+        QLCNIC_DUMP_READ_MUX    = 2,
+        QLCNIC_DUMP_QUEUE       = 3,
+        QLCNIC_DUMP_BRD_CONFIG  = 4,
+        QLCNIC_DUMP_READ_OCM    = 6,
+        QLCNIC_DUMP_PEG_REG     = 7,
+        QLCNIC_DUMP_L1_DTAG     = 8,
+        QLCNIC_DUMP_L1_ITAG     = 9,
+        QLCNIC_DUMP_L1_DATA     = 11,
+        QLCNIC_DUMP_L1_INST     = 12,
+        QLCNIC_DUMP_L2_DTAG     = 21,
+        QLCNIC_DUMP_L2_ITAG     = 22,
+        QLCNIC_DUMP_L2_DATA     = 23,
+        QLCNIC_DUMP_L2_INST     = 24,
+        QLCNIC_DUMP_READ_ROM    = 71,
+        QLCNIC_DUMP_READ_MEM    = 72,
+        QLCNIC_DUMP_READ_CTRL   = 98,
+        QLCNIC_DUMP_TLHDR       = 99,
+        QLCNIC_DUMP_RDEND       = 255
+};
+#define QLCNIC_DUMP_WCRB        BIT_0
+#define QLCNIC_DUMP_RWCRB       BIT_1
+#define QLCNIC_DUMP_ANDCRB      BIT_2
+#define QLCNIC_DUMP_ORCRB       BIT_3
+#define QLCNIC_DUMP_POLLCRB     BIT_4
+#define QLCNIC_DUMP_RD_SAVE     BIT_5
+#define QLCNIC_DUMP_WRT_SAVED   BIT_6
+#define QLCNIC_DUMP_MOD_SAVE_ST BIT_7
+#define QLCNIC_DUMP_SKIP        BIT_7
+#define QLCNIC_DUMP_MASK_MIN            3
+#define QLCNIC_DUMP_MASK_DEF            0x0f
+#define QLCNIC_DUMP_MASK_MAX            0xff
+#define QLCNIC_FORCE_FW_DUMP_KEY        0xdeadfeed
+struct qlcnic_dump_operations {
+        enum op_codes opcode;
+        u32 (*handler)(struct qlcnic_adapter *,
+                        struct qlcnic_dump_entry *, u32 *);
+};
+int qlcnic_fw_cmd_get_minidump_temp(struct qlcnic_adapter *adapter);
+int qlcnic_fw_cmd_set_port(struct qlcnic_adapter *adapter, u32 config);
 u32 qlcnic_hw_read_wx_2M(struct qlcnic_adapter *adapter, ulong off);
 int qlcnic_hw_write_wx_2M(struct qlcnic_adapter *, ulong off, u32 data);
@@ -1264,6 +1375,7 @@ int qlcnic_wol_supported(struct qlcnic_adapter *adapter);
 int qlcnic_config_led(struct qlcnic_adapter *adapter, u32 state, u32 rate);
 void qlcnic_prune_lb_filters(struct qlcnic_adapter *adapter);
 void qlcnic_delete_lb_filters(struct qlcnic_adapter *adapter);
+int qlcnic_dump_fw(struct qlcnic_adapter *);
 /* Functions from qlcnic_init.c */
 int qlcnic_load_firmware(struct qlcnic_adapter *adapter);
@@ -1274,7 +1386,7 @@ int qlcnic_pinit_from_rom(struct qlcnic_adapter *adapter);
 int qlcnic_setup_idc_param(struct qlcnic_adapter *adapter);
 int qlcnic_check_flash_fw_ver(struct qlcnic_adapter *adapter);
-int qlcnic_rom_fast_read(struct qlcnic_adapter *adapter, int addr, int *valp);
+int qlcnic_rom_fast_read(struct qlcnic_adapter *adapter, u32 addr, u32 *valp);
 int qlcnic_rom_fast_read_words(struct qlcnic_adapter *adapter, int addr,
                                u8 *bytes, size_t size);
 int qlcnic_alloc_sw_resources(struct qlcnic_adapter *adapter);
@@ -1294,7 +1406,7 @@ void qlcnic_release_tx_buffers(struct qlcnic_adapter *adapter);
 int qlcnic_check_fw_status(struct qlcnic_adapter *adapter);
 void qlcnic_watchdog_task(struct work_struct *work);
-void qlcnic_post_rx_buffers(struct qlcnic_adapter *adapter, u32 ringid,
+void qlcnic_post_rx_buffers(struct qlcnic_adapter *adapter,
                struct qlcnic_host_rds_ring *rds_ring);
 int qlcnic_process_rcv_ring(struct qlcnic_host_sds_ring *sds_ring, int max);
 void qlcnic_set_multi(struct net_device *netdev);
@@ -1308,6 +1420,8 @@ void qlcnic_advert_link_change(struct qlcnic_adapter *adapter, int linkup);
 int qlcnic_fw_cmd_set_mtu(struct qlcnic_adapter *adapter, int mtu);
 int qlcnic_change_mtu(struct net_device *netdev, int new_mtu);
+u32 qlcnic_fix_features(struct net_device *netdev, u32 features);
+int qlcnic_set_features(struct net_device *netdev, u32 features);
 int qlcnic_config_hw_lro(struct qlcnic_adapter *adapter, int enable);
 int qlcnic_config_bridged_mode(struct qlcnic_adapter *adapter, u32 enable);
 int qlcnic_send_lro_cleanup(struct qlcnic_adapter *adapter);
@@ -1322,6 +1436,9 @@ u32 qlcnic_issue_cmd(struct qlcnic_adapter *adapter,
 void qlcnic_diag_free_res(struct net_device *netdev, int max_sds_rings);
 int qlcnic_diag_alloc_res(struct net_device *netdev, int test);
 netdev_tx_t qlcnic_xmit_frame(struct sk_buff *skb, struct net_device *netdev);
+int qlcnic_validate_max_rss(struct net_device *netdev, u8 max_hw, u8 val);
+int qlcnic_set_max_rss(struct qlcnic_adapter *adapter, u8 data);
+void qlcnic_dev_request_reset(struct qlcnic_adapter *);
 /* Management functions */
 int qlcnic_get_mac_address(struct qlcnic_adapter *, u8*);
@@ -1379,8 +1496,7 @@ static const struct qlcnic_brdinfo qlcnic_boards[] = {
 static inline u32 qlcnic_tx_avail(struct qlcnic_host_tx_ring *tx_ring)
 {
-        smp_mb();
+        if (likely(tx_ring->producer < tx_ring->sw_consumer))
-        if (tx_ring->producer < tx_ring->sw_consumer)
                return tx_ring->sw_consumer - tx_ring->producer;
        else
                return tx_ring->sw_consumer + tx_ring->num_desc -
diff --git a/drivers/net/qlcnic/qlcnic_ctx.c b/drivers/net/qlcnic/qlcnic_ctx.c
index 27631f23b3fd..bab041a5c758 100644
--- a/drivers/net/qlcnic/qlcnic_ctx.c
+++ b/drivers/net/qlcnic/qlcnic_ctx.c
@@ -64,14 +64,105 @@ qlcnic_issue_cmd(struct qlcnic_adapter *adapter,
        return rcode;
 }
+static uint32_t qlcnic_temp_checksum(uint32_t *temp_buffer, u16 temp_size)
+{
+        uint64_t sum = 0;
+        int count = temp_size / sizeof(uint32_t);
+        while (count-- > 0)
+                sum += *temp_buffer++;
+        while (sum >> 32)
+                sum = (sum & 0xFFFFFFFF) + (sum >> 32);
+        return ~sum;
+}
+int qlcnic_fw_cmd_get_minidump_temp(struct qlcnic_adapter *adapter)
+{
+        int err, i;
+        u16 temp_size;
+        void *tmp_addr;
+        u32 version, csum, *template, *tmp_buf;
+        struct qlcnic_hardware_context *ahw;
+        struct qlcnic_dump_template_hdr *tmpl_hdr, *tmp_tmpl;
+        dma_addr_t tmp_addr_t = 0;
+        ahw = adapter->ahw;
+        err = qlcnic_issue_cmd(adapter,
+                        adapter->ahw->pci_func,
+                        adapter->fw_hal_version,
+                        0,
+                        0,
+                        0,
+                        QLCNIC_CDRP_CMD_TEMP_SIZE);
+        if (err != QLCNIC_RCODE_SUCCESS) {
+                err = QLCRD32(adapter, QLCNIC_ARG1_CRB_OFFSET);
+                dev_err(&adapter->pdev->dev,
+                        "Failed to get template size %d\n", err);
+                err = -EIO;
+                return err;
+        }
+        version = QLCRD32(adapter, QLCNIC_ARG3_CRB_OFFSET);
+        temp_size = QLCRD32(adapter, QLCNIC_ARG2_CRB_OFFSET);
+        if (!temp_size)
+                return -EIO;
+        tmp_addr = dma_alloc_coherent(&adapter->pdev->dev, temp_size,
+                        &tmp_addr_t, GFP_KERNEL);
+        if (!tmp_addr) {
+                dev_err(&adapter->pdev->dev,
+                        "Can't get memory for FW dump template\n");
+                return -ENOMEM;
+        }
+        err = qlcnic_issue_cmd(adapter,
+                adapter->ahw->pci_func,
+                adapter->fw_hal_version,
+                LSD(tmp_addr_t),
+                MSD(tmp_addr_t),
+                temp_size,
+                QLCNIC_CDRP_CMD_GET_TEMP_HDR);
+        if (err != QLCNIC_RCODE_SUCCESS) {
+                dev_err(&adapter->pdev->dev,
+                        "Failed to get mini dump template header %d\n", err);
+                err = -EIO;
+                goto error;
+        }
+        tmp_tmpl = (struct qlcnic_dump_template_hdr *) tmp_addr;
+        csum = qlcnic_temp_checksum((uint32_t *) tmp_addr, temp_size);
+        if (csum) {
+                dev_err(&adapter->pdev->dev,
+                        "Template header checksum validation failed\n");
+                err = -EIO;
+                goto error;
+        }
+        ahw->fw_dump.tmpl_hdr = vzalloc(temp_size);
+        if (!ahw->fw_dump.tmpl_hdr) {
+                err = -EIO;
+                goto error;
+        }
+        tmp_buf = (u32 *) tmp_addr;
+        template = (u32 *) ahw->fw_dump.tmpl_hdr;
+        for (i = 0; i < temp_size/sizeof(u32); i++)
+                *template++ = __le32_to_cpu(*tmp_buf++);
+        tmpl_hdr = ahw->fw_dump.tmpl_hdr;
+        if (tmpl_hdr->cap_mask > QLCNIC_DUMP_MASK_DEF &&
+                tmpl_hdr->cap_mask <= QLCNIC_DUMP_MASK_MAX)
+                tmpl_hdr->drv_cap_mask = tmpl_hdr->cap_mask;
+        else
+                tmpl_hdr->drv_cap_mask = QLCNIC_DUMP_MASK_DEF;
+error:
+        dma_free_coherent(&adapter->pdev->dev, temp_size, tmp_addr, tmp_addr_t);
+        return err;
+}
 int
 qlcnic_fw_cmd_set_mtu(struct qlcnic_adapter *adapter, int mtu)
 {
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        if (recv_ctx->state == QLCNIC_HOST_CTX_STATE_ACTIVE) {
                if (qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        recv_ctx->context_id,
                        mtu,
@@ -102,12 +193,12 @@ qlcnic_fw_cmd_create_rx_ctx(struct qlcnic_adapter *adapter)
        dma_addr_t hostrq_phys_addr, cardrsp_phys_addr;
        u64 phys_addr;
-        int i, nrds_rings, nsds_rings;
+        u8 i, nrds_rings, nsds_rings;
        size_t rq_size, rsp_size;
        u32 cap, reg, val, reg2;
        int err;
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        nrds_rings = adapter->max_rds_rings;
        nsds_rings = adapter->max_sds_rings;
@@ -119,14 +210,14 @@ qlcnic_fw_cmd_create_rx_ctx(struct qlcnic_adapter *adapter)
                SIZEOF_CARDRSP_RX(struct qlcnic_cardrsp_rx_ctx, nrds_rings,
                                                nsds_rings);
-        addr = pci_alloc_consistent(adapter->pdev,
+        addr = dma_alloc_coherent(&adapter->pdev->dev, rq_size,
-                                rq_size, &hostrq_phys_addr);
+                        &hostrq_phys_addr, GFP_KERNEL);
        if (addr == NULL)
                return -ENOMEM;
        prq = (struct qlcnic_hostrq_rx_ctx *)addr;
-        addr = pci_alloc_consistent(adapter->pdev,
+        addr = dma_alloc_coherent(&adapter->pdev->dev, rsp_size,
-                        rsp_size, &cardrsp_phys_addr);
+                        &cardrsp_phys_addr, GFP_KERNEL);
        if (addr == NULL) {
                err = -ENOMEM;
                goto out_free_rq;
@@ -151,7 +242,7 @@ qlcnic_fw_cmd_create_rx_ctx(struct qlcnic_adapter *adapter)
        prq->num_rds_rings = cpu_to_le16(nrds_rings);
        prq->num_sds_rings = cpu_to_le16(nsds_rings);
-        prq->rds_ring_offset = cpu_to_le32(0);
+        prq->rds_ring_offset = 0;
        val = le32_to_cpu(prq->rds_ring_offset) +
                (sizeof(struct qlcnic_hostrq_rds_ring) * nrds_rings);
@@ -187,7 +278,7 @@ qlcnic_fw_cmd_create_rx_ctx(struct qlcnic_adapter *adapter)
        phys_addr = hostrq_phys_addr;
        err = qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        (u32)(phys_addr >> 32),
                        (u32)(phys_addr & 0xffffffff),
@@ -207,7 +298,7 @@ qlcnic_fw_cmd_create_rx_ctx(struct qlcnic_adapter *adapter)
                rds_ring = &recv_ctx->rds_rings[i];
                reg = le32_to_cpu(prsp_rds[i].host_producer_crb);
-                rds_ring->crb_rcv_producer = adapter->ahw.pci_base0 + reg;
+                rds_ring->crb_rcv_producer = adapter->ahw->pci_base0 + reg;
        }
        prsp_sds = ((struct qlcnic_cardrsp_sds_ring *)
@@ -219,8 +310,8 @@ qlcnic_fw_cmd_create_rx_ctx(struct qlcnic_adapter *adapter)
                reg = le32_to_cpu(prsp_sds[i].host_consumer_crb);
                reg2 = le32_to_cpu(prsp_sds[i].interrupt_crb);
-                sds_ring->crb_sts_consumer = adapter->ahw.pci_base0 + reg;
+                sds_ring->crb_sts_consumer = adapter->ahw->pci_base0 + reg;
-                sds_ring->crb_intr_mask = adapter->ahw.pci_base0 + reg2;
+                sds_ring->crb_intr_mask = adapter->ahw->pci_base0 + reg2;
        }
        recv_ctx->state = le32_to_cpu(prsp->host_ctx_state);
@@ -228,19 +319,20 @@ qlcnic_fw_cmd_create_rx_ctx(struct qlcnic_adapter *adapter)
        recv_ctx->virt_port = prsp->virt_port;
 out_free_rsp:
-        pci_free_consistent(adapter->pdev, rsp_size, prsp, cardrsp_phys_addr);
+        dma_free_coherent(&adapter->pdev->dev, rsp_size, prsp,
+                cardrsp_phys_addr);
 out_free_rq:
-        pci_free_consistent(adapter->pdev, rq_size, prq, hostrq_phys_addr);
+        dma_free_coherent(&adapter->pdev->dev, rq_size, prq, hostrq_phys_addr);
        return err;
 }
 static void
 qlcnic_fw_cmd_destroy_rx_ctx(struct qlcnic_adapter *adapter)
 {
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        if (qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        recv_ctx->context_id,
                        QLCNIC_DESTROY_CTX_RESET,
@@ -274,14 +366,14 @@ qlcnic_fw_cmd_create_tx_ctx(struct qlcnic_adapter *adapter)
        *(tx_ring->hw_consumer) = 0;
        rq_size = SIZEOF_HOSTRQ_TX(struct qlcnic_hostrq_tx_ctx);
-        rq_addr = pci_alloc_consistent(adapter->pdev,
+        rq_addr = dma_alloc_coherent(&adapter->pdev->dev, rq_size,
-                rq_size, &rq_phys_addr);
+                        &rq_phys_addr, GFP_KERNEL);
        if (!rq_addr)
                return -ENOMEM;
        rsp_size = SIZEOF_CARDRSP_TX(struct qlcnic_cardrsp_tx_ctx);
-        rsp_addr = pci_alloc_consistent(adapter->pdev,
+        rsp_addr = dma_alloc_coherent(&adapter->pdev->dev, rsp_size,
-                rsp_size, &rsp_phys_addr);
+                        &rsp_phys_addr, GFP_KERNEL);
        if (!rsp_addr) {
                err = -ENOMEM;
                goto out_free_rq;
@@ -313,7 +405,7 @@ qlcnic_fw_cmd_create_tx_ctx(struct qlcnic_adapter *adapter)
        phys_addr = rq_phys_addr;
        err = qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        (u32)(phys_addr >> 32),
                        ((u32)phys_addr & 0xffffffff),
@@ -322,7 +414,7 @@ qlcnic_fw_cmd_create_tx_ctx(struct qlcnic_adapter *adapter)
        if (err == QLCNIC_RCODE_SUCCESS) {
                temp = le32_to_cpu(prsp->cds_ring.host_producer_crb);
-                tx_ring->crb_cmd_producer = adapter->ahw.pci_base0 + temp;
+                tx_ring->crb_cmd_producer = adapter->ahw->pci_base0 + temp;
                adapter->tx_context_id =
                        le16_to_cpu(prsp->context_id);
@@ -332,10 +424,11 @@ qlcnic_fw_cmd_create_tx_ctx(struct qlcnic_adapter *adapter)
                err = -EIO;
        }
-        pci_free_consistent(adapter->pdev, rsp_size, rsp_addr, rsp_phys_addr);
+        dma_free_coherent(&adapter->pdev->dev, rsp_size, rsp_addr,
+                rsp_phys_addr);
 out_free_rq:
-        pci_free_consistent(adapter->pdev, rq_size, rq_addr, rq_phys_addr);
+        dma_free_coherent(&adapter->pdev->dev, rq_size, rq_addr, rq_phys_addr);
        return err;
 }
@@ -344,7 +437,7 @@ static void
 qlcnic_fw_cmd_destroy_tx_ctx(struct qlcnic_adapter *adapter)
 {
        if (qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        adapter->tx_context_id,
                        QLCNIC_DESTROY_CTX_RESET,
@@ -357,33 +450,15 @@ qlcnic_fw_cmd_destroy_tx_ctx(struct qlcnic_adapter *adapter)
 }
 int
-qlcnic_fw_cmd_query_phy(struct qlcnic_adapter *adapter, u32 reg, u32 *val)
+qlcnic_fw_cmd_set_port(struct qlcnic_adapter *adapter, u32 config)
-{
-        if (qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
-                        adapter->fw_hal_version,
-                        reg,
-                        0,
-                        0,
-                        QLCNIC_CDRP_CMD_READ_PHY)) {
-                return -EIO;
-        }
-        return QLCRD32(adapter, QLCNIC_ARG1_CRB_OFFSET);
-}
-int
-qlcnic_fw_cmd_set_phy(struct qlcnic_adapter *adapter, u32 reg, u32 val)
 {
        return qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
-                        reg,
+                        config,
-                        val,
+                        0,
                        0,
-                        QLCNIC_CDRP_CMD_WRITE_PHY);
+                        QLCNIC_CDRP_CMD_CONFIG_PORT);
 }
 int qlcnic_alloc_hw_resources(struct qlcnic_adapter *adapter)
@@ -398,20 +473,19 @@ int qlcnic_alloc_hw_resources(struct qlcnic_adapter *adapter)
        struct pci_dev *pdev = adapter->pdev;
-        recv_ctx = &adapter->recv_ctx;
+        recv_ctx = adapter->recv_ctx;
        tx_ring = adapter->tx_ring;
-        tx_ring->hw_consumer = (__le32 *)pci_alloc_consistent(pdev, sizeof(u32),
+        tx_ring->hw_consumer = (__le32 *) dma_alloc_coherent(&pdev->dev,
-                                                &tx_ring->hw_cons_phys_addr);
+                sizeof(u32), &tx_ring->hw_cons_phys_addr, GFP_KERNEL);
        if (tx_ring->hw_consumer == NULL) {
                dev_err(&pdev->dev, "failed to allocate tx consumer\n");
                return -ENOMEM;
        }
-        *(tx_ring->hw_consumer) = 0;
        /* cmd desc ring */
-        addr = pci_alloc_consistent(pdev, TX_DESC_RINGSIZE(tx_ring),
+        addr = dma_alloc_coherent(&pdev->dev, TX_DESC_RINGSIZE(tx_ring),
-                        &tx_ring->phys_addr);
+                        &tx_ring->phys_addr, GFP_KERNEL);
        if (addr == NULL) {
                dev_err(&pdev->dev, "failed to allocate tx desc ring\n");
@@ -423,9 +497,9 @@ int qlcnic_alloc_hw_resources(struct qlcnic_adapter *adapter)
        for (ring = 0; ring < adapter->max_rds_rings; ring++) {
                rds_ring = &recv_ctx->rds_rings[ring];
-                addr = pci_alloc_consistent(adapter->pdev,
+                addr = dma_alloc_coherent(&adapter->pdev->dev,
                                RCV_DESC_RINGSIZE(rds_ring),
-                                &rds_ring->phys_addr);
+                                &rds_ring->phys_addr, GFP_KERNEL);
                if (addr == NULL) {
                        dev_err(&pdev->dev,
                                "failed to allocate rds ring [%d]\n", ring);
@@ -439,9 +513,9 @@ int qlcnic_alloc_hw_resources(struct qlcnic_adapter *adapter)
        for (ring = 0; ring < adapter->max_sds_rings; ring++) {
                sds_ring = &recv_ctx->sds_rings[ring];
-                addr = pci_alloc_consistent(adapter->pdev,
+                addr = dma_alloc_coherent(&adapter->pdev->dev,
                                STATUS_DESC_RINGSIZE(sds_ring),
-                                &sds_ring->phys_addr);
+                                &sds_ring->phys_addr, GFP_KERNEL);
                if (addr == NULL) {
                        dev_err(&pdev->dev,
                                "failed to allocate sds ring [%d]\n", ring);
@@ -501,11 +575,11 @@ void qlcnic_free_hw_resources(struct qlcnic_adapter *adapter)
        struct qlcnic_host_tx_ring *tx_ring;
        int ring;
-        recv_ctx = &adapter->recv_ctx;
+        recv_ctx = adapter->recv_ctx;
        tx_ring = adapter->tx_ring;
        if (tx_ring->hw_consumer != NULL) {
-                pci_free_consistent(adapter->pdev,
+                dma_free_coherent(&adapter->pdev->dev,
                                sizeof(u32),
                                tx_ring->hw_consumer,
                                tx_ring->hw_cons_phys_addr);
@@ -513,7 +587,7 @@ void qlcnic_free_hw_resources(struct qlcnic_adapter *adapter)
        }
        if (tx_ring->desc_head != NULL) {
-                pci_free_consistent(adapter->pdev,
+                dma_free_coherent(&adapter->pdev->dev,
                                TX_DESC_RINGSIZE(tx_ring),
                                tx_ring->desc_head, tx_ring->phys_addr);
                tx_ring->desc_head = NULL;
@@ -523,7 +597,7 @@ void qlcnic_free_hw_resources(struct qlcnic_adapter *adapter)
                rds_ring = &recv_ctx->rds_rings[ring];
                if (rds_ring->desc_head != NULL) {
-                        pci_free_consistent(adapter->pdev,
+                        dma_free_coherent(&adapter->pdev->dev,
                                        RCV_DESC_RINGSIZE(rds_ring),
                                        rds_ring->desc_head,
                                        rds_ring->phys_addr);
@@ -535,7 +609,7 @@ void qlcnic_free_hw_resources(struct qlcnic_adapter *adapter)
                sds_ring = &recv_ctx->sds_rings[ring];
                if (sds_ring->desc_head != NULL) {
-                        pci_free_consistent(adapter->pdev,
+                        dma_free_coherent(&adapter->pdev->dev,
                                STATUS_DESC_RINGSIZE(sds_ring),
                                sds_ring->desc_head,
                                sds_ring->phys_addr);
@@ -551,9 +625,9 @@ int qlcnic_get_mac_address(struct qlcnic_adapter *adapter, u8 *mac)
        int err;
        u32 arg1;
-        arg1 = adapter->ahw.pci_func | BIT_8;
+        arg1 = adapter->ahw->pci_func | BIT_8;
        err = qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        arg1,
                        0,
@@ -582,15 +656,15 @@ int qlcnic_get_nic_info(struct qlcnic_adapter *adapter,
        void *nic_info_addr;
        size_t  nic_size = sizeof(struct qlcnic_info);
-        nic_info_addr = pci_alloc_consistent(adapter->pdev,
+        nic_info_addr = dma_alloc_coherent(&adapter->pdev->dev, nic_size,
-                nic_size, &nic_dma_t);
+                                &nic_dma_t, GFP_KERNEL);
        if (!nic_info_addr)
                return -ENOMEM;
        memset(nic_info_addr, 0, nic_size);
        nic_info = (struct qlcnic_info *) nic_info_addr;
        err = qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        MSD(nic_dma_t),
                        LSD(nic_dma_t),
@@ -623,7 +697,8 @@ int qlcnic_get_nic_info(struct qlcnic_adapter *adapter,
                err = -EIO;
        }
-        pci_free_consistent(adapter->pdev, nic_size, nic_info_addr, nic_dma_t);
+        dma_free_coherent(&adapter->pdev->dev, nic_size, nic_info_addr,
+                nic_dma_t);
        return err;
 }
@@ -639,8 +714,8 @@ int qlcnic_set_nic_info(struct qlcnic_adapter *adapter, struct qlcnic_info *nic)
        if (adapter->op_mode != QLCNIC_MGMT_FUNC)
                return err;
-        nic_info_addr = pci_alloc_consistent(adapter->pdev, nic_size,
+        nic_info_addr = dma_alloc_coherent(&adapter->pdev->dev, nic_size,
-                        &nic_dma_t);
+                        &nic_dma_t, GFP_KERNEL);
        if (!nic_info_addr)
                return -ENOMEM;
@@ -659,7 +734,7 @@ int qlcnic_set_nic_info(struct qlcnic_adapter *adapter, struct qlcnic_info *nic)
        nic_info->max_tx_bw = cpu_to_le16(nic->max_tx_bw);
        err = qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        MSD(nic_dma_t),
                        LSD(nic_dma_t),
@@ -672,7 +747,8 @@ int qlcnic_set_nic_info(struct qlcnic_adapter *adapter, struct qlcnic_info *nic)
                err = -EIO;
        }
-        pci_free_consistent(adapter->pdev, nic_size, nic_info_addr, nic_dma_t);
+        dma_free_coherent(&adapter->pdev->dev, nic_size, nic_info_addr,
+                nic_dma_t);
        return err;
 }
@@ -687,15 +763,15 @@ int qlcnic_get_pci_info(struct qlcnic_adapter *adapter,
        size_t npar_size = sizeof(struct qlcnic_pci_info);
        size_t pci_size = npar_size * QLCNIC_MAX_PCI_FUNC;
-        pci_info_addr = pci_alloc_consistent(adapter->pdev, pci_size,
+        pci_info_addr = dma_alloc_coherent(&adapter->pdev->dev, pci_size,
-                        &pci_info_dma_t);
+                        &pci_info_dma_t, GFP_KERNEL);
        if (!pci_info_addr)
                return -ENOMEM;
        memset(pci_info_addr, 0, pci_size);
        npar = (struct qlcnic_pci_info *) pci_info_addr;
        err = qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        MSD(pci_info_dma_t),
                        LSD(pci_info_dma_t),
@@ -721,7 +797,7 @@ int qlcnic_get_pci_info(struct qlcnic_adapter *adapter,
                err = -EIO;
        }
-        pci_free_consistent(adapter->pdev, pci_size, pci_info_addr,
+        dma_free_coherent(&adapter->pdev->dev, pci_size, pci_info_addr,
                pci_info_dma_t);
        return err;
 }
@@ -741,7 +817,7 @@ int qlcnic_config_port_mirroring(struct qlcnic_adapter *adapter, u8 id,
        arg1 |= pci_func << 8;
        err = qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        arg1,
                        0,
@@ -775,14 +851,14 @@ int qlcnic_get_port_stats(struct qlcnic_adapter *adapter, const u8 func,
                return -ENOMEM;
        if (adapter->op_mode != QLCNIC_MGMT_FUNC &&
-            func != adapter->ahw.pci_func) {
+            func != adapter->ahw->pci_func) {
                dev_err(&adapter->pdev->dev,
                        "Not privilege to query stats for func=%d", func);
                return -EIO;
        }
-        stats_addr = pci_alloc_consistent(adapter->pdev, stats_size,
+        stats_addr = dma_alloc_coherent(&adapter->pdev->dev, stats_size,
-                        &stats_dma_t);
+                        &stats_dma_t, GFP_KERNEL);
        if (!stats_addr) {
                dev_err(&adapter->pdev->dev, "Unable to allocate memory\n");
                return -ENOMEM;
@@ -793,7 +869,7 @@ int qlcnic_get_port_stats(struct qlcnic_adapter *adapter, const u8 func,
        arg1 |= rx_tx << 15 | stats_size << 16;
        err = qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        arg1,
                        MSD(stats_dma_t),
@@ -816,7 +892,7 @@ int qlcnic_get_port_stats(struct qlcnic_adapter *adapter, const u8 func,
                esw_stats->numbytes = le64_to_cpu(stats->numbytes);
        }
-        pci_free_consistent(adapter->pdev, stats_size, stats_addr,
+        dma_free_coherent(&adapter->pdev->dev, stats_size, stats_addr,
                stats_dma_t);
        return err;
 }
@@ -900,7 +976,7 @@ int qlcnic_clear_esw_stats(struct qlcnic_adapter *adapter, const u8 func_esw,
        arg1 |= BIT_14 | rx_tx << 15;
        return qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        arg1,
                        0,
@@ -921,7 +997,7 @@ __qlcnic_get_eswitch_port_config(struct qlcnic_adapter *adapter,
        u8 pci_func;
        pci_func = (*arg1 >> 8);
        err = qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        *arg1,
                        0,
@@ -999,7 +1075,7 @@ int qlcnic_config_switch_port(struct qlcnic_adapter *adapter,
        }
        err = qlcnic_issue_cmd(adapter,
-                        adapter->ahw.pci_func,
+                        adapter->ahw->pci_func,
                        adapter->fw_hal_version,
                        arg1,
                        arg2,
diff --git a/drivers/net/qlcnic/qlcnic_ethtool.c b/drivers/net/qlcnic/qlcnic_ethtool.c
index 45b2755d6cba..9efc690a289f 100644
--- a/drivers/net/qlcnic/qlcnic_ethtool.c
+++ b/drivers/net/qlcnic/qlcnic_ethtool.c
@@ -150,10 +150,10 @@ qlcnic_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
 {
        struct qlcnic_adapter *adapter = netdev_priv(dev);
        int check_sfp_module = 0;
-        u16 pcifn = adapter->ahw.pci_func;
+        u16 pcifn = adapter->ahw->pci_func;
        /* read which mode */
-        if (adapter->ahw.port_type == QLCNIC_GBE) {
+        if (adapter->ahw->port_type == QLCNIC_GBE) {
                ecmd->supported = (SUPPORTED_10baseT_Half |
                                   SUPPORTED_10baseT_Full |
                                   SUPPORTED_100baseT_Half |
@@ -166,11 +166,11 @@ qlcnic_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                                     ADVERTISED_1000baseT_Half |
                                     ADVERTISED_1000baseT_Full);
-                ecmd->speed = adapter->link_speed;
+                ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                ecmd->duplex = adapter->link_duplex;
                ecmd->autoneg = adapter->link_autoneg;
-        } else if (adapter->ahw.port_type == QLCNIC_XGBE) {
+        } else if (adapter->ahw->port_type == QLCNIC_XGBE) {
                u32 val;
                val = QLCRD32(adapter, QLCNIC_PORT_MODE_ADDR);
@@ -183,15 +183,15 @@ qlcnic_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                }
                if (netif_running(dev) && adapter->has_link_events) {
-                        ecmd->speed = adapter->link_speed;
+                        ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                        ecmd->autoneg = adapter->link_autoneg;
                        ecmd->duplex = adapter->link_duplex;
                        goto skip;
                }
                val = QLCRD32(adapter, P3P_LINK_SPEED_REG(pcifn));
-                ecmd->speed = P3P_LINK_SPEED_MHZ *
+                ethtool_cmd_speed_set(ecmd, P3P_LINK_SPEED_MHZ *
-                        P3P_LINK_SPEED_VAL(pcifn, val);
+                                      P3P_LINK_SPEED_VAL(pcifn, val));
                ecmd->duplex = DUPLEX_FULL;
                ecmd->autoneg = AUTONEG_DISABLE;
        } else
@@ -201,7 +201,7 @@ skip:
        ecmd->phy_address = adapter->physical_port;
        ecmd->transceiver = XCVR_EXTERNAL;
-        switch (adapter->ahw.board_type) {
+        switch (adapter->ahw->board_type) {
        case QLCNIC_BRDTYPE_P3P_REF_QG:
        case QLCNIC_BRDTYPE_P3P_4_GB:
        case QLCNIC_BRDTYPE_P3P_4_GB_MM:
@@ -238,7 +238,7 @@ skip:
                ecmd->autoneg = AUTONEG_DISABLE;
                break;
        case QLCNIC_BRDTYPE_P3P_10G_TP:
-                if (adapter->ahw.port_type == QLCNIC_XGBE) {
+                if (adapter->ahw->port_type == QLCNIC_XGBE) {
                        ecmd->autoneg = AUTONEG_DISABLE;
                        ecmd->supported |= (SUPPORTED_FIBRE | SUPPORTED_TP);
                        ecmd->advertising |=
@@ -256,7 +256,7 @@ skip:
                break;
        default:
                dev_err(&adapter->pdev->dev, "Unsupported board model %d\n",
-                        adapter->ahw.board_type);
+                        adapter->ahw->board_type);
                return -EIO;
        }
@@ -284,50 +284,44 @@ skip:
 static int
 qlcnic_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
 {
+        u32 config = 0;
+        u32 ret = 0;
        struct qlcnic_adapter *adapter = netdev_priv(dev);
-        __u32 status;
+        if (adapter->ahw->port_type != QLCNIC_GBE)
+                return -EOPNOTSUPP;
        /* read which mode */
-        if (adapter->ahw.port_type == QLCNIC_GBE) {
+        if (ecmd->duplex)
-                /* autonegotiation */
+                config |= 0x1;
-                if (qlcnic_fw_cmd_set_phy(adapter,
-                               QLCNIC_NIU_GB_MII_MGMT_ADDR_AUTONEG,
-                               ecmd->autoneg) != 0)
-                        return -EIO;
-                else
-                        adapter->link_autoneg = ecmd->autoneg;
-                if (qlcnic_fw_cmd_query_phy(adapter,
+        if (ecmd->autoneg)
-                              QLCNIC_NIU_GB_MII_MGMT_ADDR_PHY_STATUS,
+                config |= 0x2;
-                              &status) != 0)
-                        return -EIO;
-                switch (ecmd->speed) {
+        switch (ethtool_cmd_speed(ecmd)) {
-                case SPEED_10:
+        case SPEED_10:
-                        qlcnic_set_phy_speed(status, 0);
+                config |= (0 << 8);
-                        break;
+                break;
-                case SPEED_100:
+        case SPEED_100:
-                        qlcnic_set_phy_speed(status, 1);
+                config |= (1 << 8);
-                        break;
+                break;
-                case SPEED_1000:
+        case SPEED_1000:
-                        qlcnic_set_phy_speed(status, 2);
+                config |= (10 << 8);
-                        break;
+                break;
-                }
+        default:
+                return -EIO;
+        }
-                if (ecmd->duplex == DUPLEX_HALF)
+        ret = qlcnic_fw_cmd_set_port(adapter, config);
-                        qlcnic_clear_phy_duplex(status);
-                if (ecmd->duplex == DUPLEX_FULL)
+        if (ret == QLCNIC_RCODE_NOT_SUPPORTED)
-                        qlcnic_set_phy_duplex(status);
-                if (qlcnic_fw_cmd_set_phy(adapter,
-                               QLCNIC_NIU_GB_MII_MGMT_ADDR_PHY_STATUS,
-                               *((int *)&status)) != 0)
-                        return -EIO;
-                else {
-                        adapter->link_speed = ecmd->speed;
-                        adapter->link_duplex = ecmd->duplex;
-                }
-        } else
                return -EOPNOTSUPP;
+        else if (ret)
+                return -EIO;
+        adapter->link_speed = ethtool_cmd_speed(ecmd);
+        adapter->link_duplex = ecmd->duplex;
+        adapter->link_autoneg = ecmd->autoneg;
        if (!netif_running(dev))
                return 0;
@@ -340,14 +334,14 @@ static void
 qlcnic_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *p)
 {
        struct qlcnic_adapter *adapter = netdev_priv(dev);
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        struct qlcnic_host_sds_ring *sds_ring;
        u32 *regs_buff = p;
        int ring, i = 0, j = 0;
        memset(p, 0, qlcnic_get_regs_len(dev));
        regs->version = (QLCNIC_ETHTOOL_REGS_VER << 24) |
-                (adapter->ahw.revision_id << 16) | (adapter->pdev)->device;
+                (adapter->ahw->revision_id << 16) | (adapter->pdev)->device;
        regs_buff[0] = (0xcafe0000 | (QLCNIC_DEV_INFO_SIZE & 0xffff));
        regs_buff[1] = QLCNIC_MGMT_API_VERSION;
@@ -382,7 +376,7 @@ static u32 qlcnic_test_link(struct net_device *dev)
        u32 val;
        val = QLCRD32(adapter, CRB_XG_STATE_P3P);
-        val = XG_LINK_STATE_P3P(adapter->ahw.pci_func, val);
+        val = XG_LINK_STATE_P3P(adapter->ahw->pci_func, val);
        return (val == XG_LINK_UP_P3P) ? 0 : 1;
 }
@@ -474,6 +468,39 @@ qlcnic_set_ringparam(struct net_device *dev,
        return qlcnic_reset_context(adapter);
 }
+static void qlcnic_get_channels(struct net_device *dev,
+                struct ethtool_channels *channel)
+{
+        struct qlcnic_adapter *adapter = netdev_priv(dev);
+        channel->max_rx = rounddown_pow_of_two(min_t(int,
+                        adapter->max_rx_ques, num_online_cpus()));
+        channel->max_tx = adapter->max_tx_ques;
+        channel->rx_count = adapter->max_sds_rings;
+        channel->tx_count = adapter->max_tx_ques;
+}
+static int qlcnic_set_channels(struct net_device *dev,
+                struct ethtool_channels *channel)
+{
+        struct qlcnic_adapter *adapter = netdev_priv(dev);
+        int err;
+        if (channel->other_count || channel->combined_count ||
+            channel->tx_count != channel->max_tx)
+                return -EINVAL;
+        err = qlcnic_validate_max_rss(dev, channel->max_rx, channel->rx_count);
+        if (err)
+                return err;
+        err = qlcnic_set_max_rss(adapter, channel->rx_count);
+        netdev_info(dev, "allocated 0x%x sds rings\n",
+                                 adapter->max_sds_rings);
+        return err;
+}
 static void
 qlcnic_get_pauseparam(struct net_device *netdev,
                          struct ethtool_pauseparam *pause)
@@ -482,7 +509,7 @@ qlcnic_get_pauseparam(struct net_device *netdev,
        int port = adapter->physical_port;
        __u32 val;
-        if (adapter->ahw.port_type == QLCNIC_GBE) {
+        if (adapter->ahw->port_type == QLCNIC_GBE) {
                if ((port < 0) || (port > QLCNIC_NIU_MAX_GBE_PORTS))
                        return;
                /* get flow control settings */
@@ -504,7 +531,7 @@ qlcnic_get_pauseparam(struct net_device *netdev,
                        pause->tx_pause = !(qlcnic_gb_get_gb3_mask(val));
                        break;
                }
-        } else if (adapter->ahw.port_type == QLCNIC_XGBE) {
+        } else if (adapter->ahw->port_type == QLCNIC_XGBE) {
                if ((port < 0) || (port > QLCNIC_NIU_MAX_XG_PORTS))
                        return;
                pause->rx_pause = 1;
@@ -515,7 +542,7 @@ qlcnic_get_pauseparam(struct net_device *netdev,
                        pause->tx_pause = !(qlcnic_xg_get_xg1_mask(val));
        } else {
                dev_err(&netdev->dev, "Unknown board type: %x\n",
-                                        adapter->ahw.port_type);
+                                        adapter->ahw->port_type);
        }
 }
@@ -528,7 +555,7 @@ qlcnic_set_pauseparam(struct net_device *netdev,
        __u32 val;
        /* read mode */
-        if (adapter->ahw.port_type == QLCNIC_GBE) {
+        if (adapter->ahw->port_type == QLCNIC_GBE) {
                if ((port < 0) || (port > QLCNIC_NIU_MAX_GBE_PORTS))
                        return -EIO;
                /* set flow control */
@@ -571,7 +598,7 @@ qlcnic_set_pauseparam(struct net_device *netdev,
                        break;
                }
                QLCWR32(adapter, QLCNIC_NIU_GB_PAUSE_CTL, val);
-        } else if (adapter->ahw.port_type == QLCNIC_XGBE) {
+        } else if (adapter->ahw->port_type == QLCNIC_XGBE) {
                if (!pause->rx_pause || pause->autoneg)
                        return -EOPNOTSUPP;
@@ -593,7 +620,7 @@ qlcnic_set_pauseparam(struct net_device *netdev,
                QLCWR32(adapter, QLCNIC_NIU_XG_PAUSE_CTL, val);
        } else {
                dev_err(&netdev->dev, "Unknown board type: %x\n",
-                                adapter->ahw.port_type);
+                                adapter->ahw->port_type);
        }
        return 0;
 }
@@ -639,8 +666,8 @@ static int qlcnic_irq_test(struct net_device *netdev)
                goto clear_it;
        adapter->diag_cnt = 0;
-        ret = qlcnic_issue_cmd(adapter, adapter->ahw.pci_func,
+        ret = qlcnic_issue_cmd(adapter, adapter->ahw->pci_func,
-                        adapter->fw_hal_version, adapter->portnum,
+                        adapter->fw_hal_version, adapter->ahw->pci_func,
                        0, 0, 0x00000011);
        if (ret)
                goto done;
@@ -749,14 +776,14 @@ qlcnic_get_ethtool_stats(struct net_device *dev,
                return;
        memset(&port_stats, 0, sizeof(struct qlcnic_esw_statistics));
-        ret = qlcnic_get_port_stats(adapter, adapter->ahw.pci_func,
+        ret = qlcnic_get_port_stats(adapter, adapter->ahw->pci_func,
                        QLCNIC_QUERY_RX_COUNTER, &port_stats.rx);
        if (ret)
                return;
        qlcnic_fill_device_stats(&index, data, &port_stats.rx);
-        ret = qlcnic_get_port_stats(adapter, adapter->ahw.pci_func,
+        ret = qlcnic_get_port_stats(adapter, adapter->ahw->pci_func,
                        QLCNIC_QUERY_TX_COUNTER, &port_stats.tx);
        if (ret)
                return;
@@ -764,115 +791,49 @@ qlcnic_get_ethtool_stats(struct net_device *dev,
        qlcnic_fill_device_stats(&index, data, &port_stats.tx);
 }
-static int qlcnic_set_tx_csum(struct net_device *dev, u32 data)
+static int qlcnic_set_led(struct net_device *dev,
-{
+                          enum ethtool_phys_id_state state)
-        struct qlcnic_adapter *adapter = netdev_priv(dev);
-        if ((adapter->flags & QLCNIC_ESWITCH_ENABLED))
-                return -EOPNOTSUPP;
-        if (data)
-                dev->features |= (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM);
-        else
-                dev->features &= ~(NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM);
-        return 0;
-}
-static u32 qlcnic_get_tx_csum(struct net_device *dev)
-{
-        return dev->features & NETIF_F_IP_CSUM;
-}
-static u32 qlcnic_get_rx_csum(struct net_device *dev)
-{
-        struct qlcnic_adapter *adapter = netdev_priv(dev);
-        return adapter->rx_csum;
-}
-static int qlcnic_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct qlcnic_adapter *adapter = netdev_priv(dev);
-        if ((adapter->flags & QLCNIC_ESWITCH_ENABLED))
-                return -EOPNOTSUPP;
-        if (!!data) {
-                adapter->rx_csum = !!data;
-                return 0;
-        }
-        if (dev->features & NETIF_F_LRO) {
-                if (qlcnic_config_hw_lro(adapter, QLCNIC_LRO_DISABLED))
-                        return -EIO;
-                dev->features &= ~NETIF_F_LRO;
-                qlcnic_send_lro_cleanup(adapter);
-                dev_info(&adapter->pdev->dev,
-                                        "disabling LRO as rx_csum is off\n");
-        }
-        adapter->rx_csum = !!data;
-        return 0;
-}
-static u32 qlcnic_get_tso(struct net_device *dev)
-{
-        return (dev->features & (NETIF_F_TSO | NETIF_F_TSO6)) != 0;
-}
-static int qlcnic_set_tso(struct net_device *dev, u32 data)
-{
-        struct qlcnic_adapter *adapter = netdev_priv(dev);
-        if (!(adapter->capabilities & QLCNIC_FW_CAPABILITY_TSO))
-                return -EOPNOTSUPP;
-        if (data)
-                dev->features |= (NETIF_F_TSO | NETIF_F_TSO6);
-        else
-                dev->features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
-        return 0;
-}
-static int qlcnic_blink_led(struct net_device *dev, u32 val)
 {
        struct qlcnic_adapter *adapter = netdev_priv(dev);
        int max_sds_rings = adapter->max_sds_rings;
-        int dev_down = 0;
-        int ret;
-        if (!test_bit(__QLCNIC_DEV_UP, &adapter->state)) {
-                dev_down = 1;
-                if (test_and_set_bit(__QLCNIC_RESETTING, &adapter->state))
-                        return -EIO;
-                ret = qlcnic_diag_alloc_res(dev, QLCNIC_LED_TEST);
+        switch (state) {
-                if (ret) {
+        case ETHTOOL_ID_ACTIVE:
-                        clear_bit(__QLCNIC_RESETTING, &adapter->state);
+                if (!test_bit(__QLCNIC_DEV_UP, &adapter->state)) {
-                        return ret;
+                        if (test_and_set_bit(__QLCNIC_RESETTING, &adapter->state))
+                                return -EIO;
+                        if (qlcnic_diag_alloc_res(dev, QLCNIC_LED_TEST)) {
+                                clear_bit(__QLCNIC_RESETTING, &adapter->state);
+                                return -EIO;
+                        }
+                        set_bit(__QLCNIC_DIAG_RES_ALLOC, &adapter->state);
                }
-        }
-        ret = adapter->nic_ops->config_led(adapter, 1, 0xf);
+                if (adapter->nic_ops->config_led(adapter, 1, 0xf) == 0)
-        if (ret) {
+                        return 0;
                dev_err(&adapter->pdev->dev,
                        "Failed to set LED blink state.\n");
-                goto done;
+                break;
-        }
-        msleep_interruptible(val * 1000);
+        case ETHTOOL_ID_INACTIVE:
+                if (adapter->nic_ops->config_led(adapter, 0, 0xf))
+                        dev_err(&adapter->pdev->dev,
+                                "Failed to reset LED blink state.\n");
-        ret = adapter->nic_ops->config_led(adapter, 0, 0xf);
+                break;
-        if (ret) {
-                dev_err(&adapter->pdev->dev,
+        default:
-                        "Failed to reset LED blink state.\n");
+                return -EINVAL;
-                goto done;
        }
-done:
+        if (test_and_clear_bit(__QLCNIC_DIAG_RES_ALLOC, &adapter->state)) {
-        if (dev_down) {
                qlcnic_diag_free_res(dev, max_sds_rings);
                clear_bit(__QLCNIC_RESETTING, &adapter->state);
        }
-        return ret;
+        return -EIO;
 }
 static void
@@ -936,8 +897,8 @@ static int qlcnic_set_intr_coalesce(struct net_device *netdev,
        */
        if (ethcoal->rx_coalesce_usecs > 0xffff ||
                ethcoal->rx_max_coalesced_frames > 0xffff ||
-                ethcoal->tx_coalesce_usecs > 0xffff ||
+                ethcoal->tx_coalesce_usecs ||
-                ethcoal->tx_max_coalesced_frames > 0xffff ||
+                ethcoal->tx_max_coalesced_frames ||
                ethcoal->rx_coalesce_usecs_irq ||
                ethcoal->rx_max_coalesced_frames_irq ||
                ethcoal->tx_coalesce_usecs_irq ||
@@ -959,21 +920,17 @@ static int qlcnic_set_intr_coalesce(struct net_device *netdev,
        if (!ethcoal->rx_coalesce_usecs ||
                !ethcoal->rx_max_coalesced_frames) {
-                adapter->coal.flags = QLCNIC_INTR_DEFAULT;
+                adapter->ahw->coal.flag = QLCNIC_INTR_DEFAULT;
-                adapter->coal.normal.data.rx_time_us =
+                adapter->ahw->coal.rx_time_us =
                        QLCNIC_DEFAULT_INTR_COALESCE_RX_TIME_US;
-                adapter->coal.normal.data.rx_packets =
+                adapter->ahw->coal.rx_packets =
                        QLCNIC_DEFAULT_INTR_COALESCE_RX_PACKETS;
        } else {
-                adapter->coal.flags = 0;
+                adapter->ahw->coal.flag = 0;
-                adapter->coal.normal.data.rx_time_us =
+                adapter->ahw->coal.rx_time_us = ethcoal->rx_coalesce_usecs;
-                ethcoal->rx_coalesce_usecs;
+                adapter->ahw->coal.rx_packets =
-                adapter->coal.normal.data.rx_packets =
+                        ethcoal->rx_max_coalesced_frames;
-                ethcoal->rx_max_coalesced_frames;
        }
-        adapter->coal.normal.data.tx_time_us = ethcoal->tx_coalesce_usecs;
-        adapter->coal.normal.data.tx_packets =
-        ethcoal->tx_max_coalesced_frames;
        qlcnic_config_intr_coalesce(adapter);
@@ -988,66 +945,102 @@ static int qlcnic_get_intr_coalesce(struct net_device *netdev,
        if (adapter->is_up != QLCNIC_ADAPTER_UP_MAGIC)
                return -EINVAL;
-        ethcoal->rx_coalesce_usecs = adapter->coal.normal.data.rx_time_us;
+        ethcoal->rx_coalesce_usecs = adapter->ahw->coal.rx_time_us;
-        ethcoal->tx_coalesce_usecs = adapter->coal.normal.data.tx_time_us;
+        ethcoal->rx_max_coalesced_frames = adapter->ahw->coal.rx_packets;
-        ethcoal->rx_max_coalesced_frames =
-                adapter->coal.normal.data.rx_packets;
-        ethcoal->tx_max_coalesced_frames =
-                adapter->coal.normal.data.tx_packets;
        return 0;
 }
-static int qlcnic_set_flags(struct net_device *netdev, u32 data)
+static u32 qlcnic_get_msglevel(struct net_device *netdev)
 {
        struct qlcnic_adapter *adapter = netdev_priv(netdev);
-        int hw_lro;
-        if (ethtool_invalid_flags(netdev, data, ETH_FLAG_LRO))
-                return -EINVAL;
-        if (!(adapter->capabilities & QLCNIC_FW_CAPABILITY_HW_LRO))
-                return -EINVAL;
-        if (!adapter->rx_csum) {
-                dev_info(&adapter->pdev->dev, "rx csum is off, "
-                        "cannot toggle lro\n");
-                return -EINVAL;
-        }
-        if ((data & ETH_FLAG_LRO) && (netdev->features & NETIF_F_LRO))
+        return adapter->msg_enable;
-                return 0;
+}
-        if (data & ETH_FLAG_LRO) {
-                hw_lro = QLCNIC_LRO_ENABLED;
-                netdev->features |= NETIF_F_LRO;
-        } else {
-                hw_lro = 0;
-                netdev->features &= ~NETIF_F_LRO;
-        }
-        if (qlcnic_config_hw_lro(adapter, hw_lro))
+static void qlcnic_set_msglevel(struct net_device *netdev, u32 msglvl)
-                return -EIO;
+{
+        struct qlcnic_adapter *adapter = netdev_priv(netdev);
-        if ((hw_lro == 0) && qlcnic_send_lro_cleanup(adapter))
+        adapter->msg_enable = msglvl;
-                return -EIO;
+}
+static int
+qlcnic_get_dump_flag(struct net_device *netdev, struct ethtool_dump *dump)
+{
+        struct qlcnic_adapter *adapter = netdev_priv(netdev);
+        struct qlcnic_fw_dump *fw_dump = &adapter->ahw->fw_dump;
+        dump->len = fw_dump->tmpl_hdr->size + fw_dump->size;
+        dump->flag = fw_dump->tmpl_hdr->drv_cap_mask;
+        dump->version = adapter->fw_version;
        return 0;
 }
-static u32 qlcnic_get_msglevel(struct net_device *netdev)
+static int
+qlcnic_get_dump_data(struct net_device *netdev, struct ethtool_dump *dump,
+                        void *buffer)
 {
+        int i, copy_sz;
+        u32 *hdr_ptr, *data;
        struct qlcnic_adapter *adapter = netdev_priv(netdev);
+        struct qlcnic_fw_dump *fw_dump = &adapter->ahw->fw_dump;
-        return adapter->msg_enable;
+        if (qlcnic_api_lock(adapter))
+                return -EIO;
+        if (!fw_dump->clr) {
+                netdev_info(netdev, "Dump not available\n");
+                qlcnic_api_unlock(adapter);
+                return -EINVAL;
+        }
+        /* Copy template header first */
+        copy_sz = fw_dump->tmpl_hdr->size;
+        hdr_ptr = (u32 *) fw_dump->tmpl_hdr;
+        data = (u32 *) buffer;
+        for (i = 0; i < copy_sz/sizeof(u32); i++)
+                *data++ = cpu_to_le32(*hdr_ptr++);
+        /* Copy captured dump data */
+        memcpy(buffer + copy_sz, fw_dump->data, fw_dump->size);
+        dump->len = copy_sz + fw_dump->size;
+        dump->flag = fw_dump->tmpl_hdr->drv_cap_mask;
+        /* Free dump area once data has been captured */
+        vfree(fw_dump->data);
+        fw_dump->data = NULL;
+        fw_dump->clr = 0;
+        qlcnic_api_unlock(adapter);
+        return 0;
 }
-static void qlcnic_set_msglevel(struct net_device *netdev, u32 msglvl)
+static int
+qlcnic_set_dump(struct net_device *netdev, struct ethtool_dump *val)
 {
+        int ret = 0;
        struct qlcnic_adapter *adapter = netdev_priv(netdev);
+        struct qlcnic_fw_dump *fw_dump = &adapter->ahw->fw_dump;
-        adapter->msg_enable = msglvl;
+        if (val->flag == QLCNIC_FORCE_FW_DUMP_KEY) {
+                netdev_info(netdev, "Forcing a FW dump\n");
+                qlcnic_dev_request_reset(adapter);
+        } else {
+                if (val->flag > QLCNIC_DUMP_MASK_MAX ||
+                        val->flag < QLCNIC_DUMP_MASK_MIN) {
+                                netdev_info(netdev,
+                                "Invalid dump level: 0x%x\n", val->flag);
+                                ret = -EINVAL;
+                                goto out;
+                }
+                if (qlcnic_api_lock(adapter))
+                        return -EIO;
+                fw_dump->tmpl_hdr->drv_cap_mask = val->flag & 0xff;
+                qlcnic_api_unlock(adapter);
+                netdev_info(netdev, "Driver mask changed to: 0x%x\n",
+                        fw_dump->tmpl_hdr->drv_cap_mask);
+        }
+out:
+        return ret;
 }
 const struct ethtool_ops qlcnic_ethtool_ops = {
@@ -1061,26 +1054,22 @@ const struct ethtool_ops qlcnic_ethtool_ops = {
        .get_eeprom = qlcnic_get_eeprom,
        .get_ringparam = qlcnic_get_ringparam,
        .set_ringparam = qlcnic_set_ringparam,
+        .get_channels = qlcnic_get_channels,
+        .set_channels = qlcnic_set_channels,
        .get_pauseparam = qlcnic_get_pauseparam,
        .set_pauseparam = qlcnic_set_pauseparam,
-        .get_tx_csum = qlcnic_get_tx_csum,
-        .set_tx_csum = qlcnic_set_tx_csum,
-        .set_sg = ethtool_op_set_sg,
-        .get_tso = qlcnic_get_tso,
-        .set_tso = qlcnic_set_tso,
        .get_wol = qlcnic_get_wol,
        .set_wol = qlcnic_set_wol,
        .self_test = qlcnic_diag_test,
        .get_strings = qlcnic_get_strings,
        .get_ethtool_stats = qlcnic_get_ethtool_stats,
        .get_sset_count = qlcnic_get_sset_count,
-        .get_rx_csum = qlcnic_get_rx_csum,
-        .set_rx_csum = qlcnic_set_rx_csum,
        .get_coalesce = qlcnic_get_intr_coalesce,
        .set_coalesce = qlcnic_set_intr_coalesce,
-        .get_flags = ethtool_op_get_flags,
+        .set_phys_id = qlcnic_set_led,
-        .set_flags = qlcnic_set_flags,
-        .phys_id = qlcnic_blink_led,
        .set_msglevel = qlcnic_set_msglevel,
        .get_msglevel = qlcnic_get_msglevel,
+        .get_dump_flag = qlcnic_get_dump_flag,
+        .get_dump_data = qlcnic_get_dump_data,
+        .set_dump = qlcnic_set_dump,
 };
diff --git a/drivers/net/qlcnic/qlcnic_hdr.h b/drivers/net/qlcnic/qlcnic_hdr.h
index 726ef555b6bc..d14506f764e0 100644
--- a/drivers/net/qlcnic/qlcnic_hdr.h
+++ b/drivers/net/qlcnic/qlcnic_hdr.h
@@ -492,10 +492,10 @@ enum {
 #define TEST_AGT_CTRL   (0x00)
-#define TA_CTL_START    1
+#define TA_CTL_START    BIT_0
-#define TA_CTL_ENABLE   2
+#define TA_CTL_ENABLE   BIT_1
-#define TA_CTL_WRITE    4
+#define TA_CTL_WRITE    BIT_2
-#define TA_CTL_BUSY     8
+#define TA_CTL_BUSY     BIT_3
 /*
 *   Register offsets for MN
@@ -765,6 +765,38 @@ struct qlcnic_legacy_intr_set {
 #define QLCNIC_MAX_PCI_FUNC     8
 #define QLCNIC_MAX_VLAN_FILTERS 64
+/* FW dump defines */
+#define MIU_TEST_CTR            0x41000090
+#define MIU_TEST_ADDR_LO        0x41000094
+#define MIU_TEST_ADDR_HI        0x41000098
+#define FLASH_ROM_WINDOW        0x42110030
+#define FLASH_ROM_DATA          0x42150000
+static const u32 MIU_TEST_READ_DATA[] = {
+        0x410000A8, 0x410000AC, 0x410000B8, 0x410000BC, };
+#define QLCNIC_FW_DUMP_REG1     0x00130060
+#define QLCNIC_FW_DUMP_REG2     0x001e0000
+#define QLCNIC_FLASH_SEM2_LK    0x0013C010
+#define QLCNIC_FLASH_SEM2_ULK   0x0013C014
+#define QLCNIC_FLASH_LOCK_ID    0x001B2100
+#define QLCNIC_RD_DUMP_REG(addr, bar0, data) do {                       \
+        writel((addr & 0xFFFF0000), (void *) (bar0 +                    \
+                QLCNIC_FW_DUMP_REG1));                                  \
+        readl((void *) (bar0 + QLCNIC_FW_DUMP_REG1));                   \
+        *data = readl((void *) (bar0 + QLCNIC_FW_DUMP_REG2 +            \
+                LSW(addr)));                                            \
+} while (0)
+#define QLCNIC_WR_DUMP_REG(addr, bar0, data) do {                       \
+        writel((addr & 0xFFFF0000), (void *) (bar0 +                    \
+                QLCNIC_FW_DUMP_REG1));                                  \
+        readl((void *) (bar0 + QLCNIC_FW_DUMP_REG1));                   \
+        writel(data, (void *) (bar0 + QLCNIC_FW_DUMP_REG2 + LSW(addr)));\
+        readl((void *) (bar0 + QLCNIC_FW_DUMP_REG2 + LSW(addr)));       \
+} while (0)
 /* PCI function operational mode */
 enum {
        QLCNIC_MGMT_FUNC        = 0,
diff --git a/drivers/net/qlcnic/qlcnic_hw.c b/drivers/net/qlcnic/qlcnic_hw.c
index 616940f0a8d0..e9656616f2a2 100644
--- a/drivers/net/qlcnic/qlcnic_hw.c
+++ b/drivers/net/qlcnic/qlcnic_hw.c
@@ -9,6 +9,7 @@
 #include <linux/slab.h>
 #include <net/ip.h>
+#include <linux/bitops.h>
 #define MASK(n) ((1ULL<<(n))-1)
 #define OCM_WIN_P3P(addr) (addr & 0xffc0000)
@@ -457,7 +458,7 @@ int qlcnic_nic_set_promisc(struct qlcnic_adapter *adapter, u32 mode)
        req.qhdr = cpu_to_le64(QLCNIC_HOST_REQUEST << 23);
-        word = QLCNIC_H2C_OPCODE_PROXY_SET_VPORT_MISS_MODE |
+        word = QLCNIC_H2C_OPCODE_SET_MAC_RECEIVE_MODE |
                        ((u64)adapter->portnum << 16);
        req.req_hdr = cpu_to_le64(word);
@@ -532,33 +533,31 @@ void qlcnic_delete_lb_filters(struct qlcnic_adapter *adapter)
        }
 }
-#define QLCNIC_CONFIG_INTR_COALESCE     3
 /*
 * Send the interrupt coalescing parameter set by ethtool to the card.
 */
 int qlcnic_config_intr_coalesce(struct qlcnic_adapter *adapter)
 {
        struct qlcnic_nic_req req;
-        u64 word[6];
+        int rv;
-        int rv, i;
        memset(&req, 0, sizeof(struct qlcnic_nic_req));
        req.qhdr = cpu_to_le64(QLCNIC_HOST_REQUEST << 23);
-        word[0] = QLCNIC_CONFIG_INTR_COALESCE | ((u64)adapter->portnum << 16);
+        req.req_hdr = cpu_to_le64(QLCNIC_CONFIG_INTR_COALESCE |
-        req.req_hdr = cpu_to_le64(word[0]);
+                ((u64) adapter->portnum << 16));
-        memcpy(&word[0], &adapter->coal, sizeof(adapter->coal));
-        for (i = 0; i < 6; i++)
-                req.words[i] = cpu_to_le64(word[i]);
+        req.words[0] = cpu_to_le64(((u64) adapter->ahw->coal.flag) << 32);
+        req.words[2] = cpu_to_le64(adapter->ahw->coal.rx_packets |
+                        ((u64) adapter->ahw->coal.rx_time_us) << 16);
+        req.words[5] = cpu_to_le64(adapter->ahw->coal.timer_out |
+                        ((u64) adapter->ahw->coal.type) << 32 |
+                        ((u64) adapter->ahw->coal.sts_ring_mask) << 40);
        rv = qlcnic_send_cmd_descs(adapter, (struct cmd_desc_type0 *)&req, 1);
        if (rv != 0)
                dev_err(&adapter->netdev->dev,
                        "Could not send interrupt coalescing parameters\n");
        return rv;
 }
@@ -568,6 +567,9 @@ int qlcnic_config_hw_lro(struct qlcnic_adapter *adapter, int enable)
        u64 word;
        int rv;
+        if (!test_bit(__QLCNIC_FW_ATTACHED, &adapter->state))
+                return 0;
        memset(&req, 0, sizeof(struct qlcnic_nic_req));
        req.qhdr = cpu_to_le64(QLCNIC_HOST_REQUEST << 23);
@@ -713,6 +715,9 @@ int qlcnic_send_lro_cleanup(struct qlcnic_adapter *adapter)
        u64 word;
        int rv;
+        if (!test_bit(__QLCNIC_FW_ATTACHED, &adapter->state))
+                return 0;
        memset(&req, 0, sizeof(struct qlcnic_nic_req));
        req.qhdr = cpu_to_le64(QLCNIC_HOST_REQUEST << 23);
@@ -754,6 +759,43 @@ int qlcnic_change_mtu(struct net_device *netdev, int mtu)
        return rc;
 }
+u32 qlcnic_fix_features(struct net_device *netdev, u32 features)
+{
+        struct qlcnic_adapter *adapter = netdev_priv(netdev);
+        if ((adapter->flags & QLCNIC_ESWITCH_ENABLED)) {
+                u32 changed = features ^ netdev->features;
+                features ^= changed & (NETIF_F_ALL_CSUM | NETIF_F_RXCSUM);
+        }
+        if (!(features & NETIF_F_RXCSUM))
+                features &= ~NETIF_F_LRO;
+        return features;
+}
+int qlcnic_set_features(struct net_device *netdev, u32 features)
+{
+        struct qlcnic_adapter *adapter = netdev_priv(netdev);
+        u32 changed = netdev->features ^ features;
+        int hw_lro = (features & NETIF_F_LRO) ? QLCNIC_LRO_ENABLED : 0;
+        if (!(changed & NETIF_F_LRO))
+                return 0;
+        netdev->features = features ^ NETIF_F_LRO;
+        if (qlcnic_config_hw_lro(adapter, hw_lro))
+                return -EIO;
+        if ((hw_lro == 0) && qlcnic_send_lro_cleanup(adapter))
+                return -EIO;
+        return 0;
+}
 /*
 * Changes the CRB window to the specified window.
 */
@@ -780,7 +822,7 @@ qlcnic_pci_get_crb_addr_2M(struct qlcnic_adapter *adapter,
        m = &crb_128M_2M_map[CRB_BLK(off)].sub_block[CRB_SUBBLK(off)];
        if (m->valid && (m->start_128M <= off) && (m->end_128M > off)) {
-                *addr = adapter->ahw.pci_base0 + m->start_2M +
+                *addr = adapter->ahw->pci_base0 + m->start_2M +
                        (off - m->start_128M);
                return 0;
        }
@@ -788,7 +830,7 @@ qlcnic_pci_get_crb_addr_2M(struct qlcnic_adapter *adapter,
        /*
         * Not in direct map, use crb window
         */
-        *addr = adapter->ahw.pci_base0 + CRB_INDIRECT_2M + (off & MASK(16));
+        *addr = adapter->ahw->pci_base0 + CRB_INDIRECT_2M + (off & MASK(16));
        return 1;
 }
@@ -801,7 +843,7 @@ static int
 qlcnic_pci_set_crbwindow_2M(struct qlcnic_adapter *adapter, ulong off)
 {
        u32 window;
-        void __iomem *addr = adapter->ahw.pci_base0 + CRB_WINDOW_2M;
+        void __iomem *addr = adapter->ahw->pci_base0 + CRB_WINDOW_2M;
        off -= QLCNIC_PCI_CRBSPACE;
@@ -838,13 +880,13 @@ qlcnic_hw_write_wx_2M(struct qlcnic_adapter *adapter, ulong off, u32 data)
        if (rv > 0) {
                /* indirect access */
-                write_lock_irqsave(&adapter->ahw.crb_lock, flags);
+                write_lock_irqsave(&adapter->ahw->crb_lock, flags);
                crb_win_lock(adapter);
                rv = qlcnic_pci_set_crbwindow_2M(adapter, off);
                if (!rv)
                        writel(data, addr);
                crb_win_unlock(adapter);
-                write_unlock_irqrestore(&adapter->ahw.crb_lock, flags);
+                write_unlock_irqrestore(&adapter->ahw->crb_lock, flags);
                return rv;
        }
@@ -869,12 +911,12 @@ qlcnic_hw_read_wx_2M(struct qlcnic_adapter *adapter, ulong off)
        if (rv > 0) {
                /* indirect access */
-                write_lock_irqsave(&adapter->ahw.crb_lock, flags);
+                write_lock_irqsave(&adapter->ahw->crb_lock, flags);
                crb_win_lock(adapter);
                if (!qlcnic_pci_set_crbwindow_2M(adapter, off))
                        data = readl(addr);
                crb_win_unlock(adapter);
-                write_unlock_irqrestore(&adapter->ahw.crb_lock, flags);
+                write_unlock_irqrestore(&adapter->ahw->crb_lock, flags);
                return data;
        }
@@ -904,9 +946,9 @@ qlcnic_pci_set_window_2M(struct qlcnic_adapter *adapter,
        window = OCM_WIN_P3P(addr);
-        writel(window, adapter->ahw.ocm_win_crb);
+        writel(window, adapter->ahw->ocm_win_crb);
        /* read back to flush */
-        readl(adapter->ahw.ocm_win_crb);
+        readl(adapter->ahw->ocm_win_crb);
        *start = QLCNIC_PCI_OCM0_2M + GET_MEM_OFFS_2M(addr);
        return 0;
@@ -920,13 +962,13 @@ qlcnic_pci_mem_access_direct(struct qlcnic_adapter *adapter, u64 off,
        int ret;
        u32 start;
-        mutex_lock(&adapter->ahw.mem_lock);
+        mutex_lock(&adapter->ahw->mem_lock);
        ret = qlcnic_pci_set_window_2M(adapter, off, &start);
        if (ret != 0)
                goto unlock;
-        addr = adapter->ahw.pci_base0 + start;
+        addr = adapter->ahw->pci_base0 + start;
        if (op == 0)    /* read */
                *data = readq(addr);
@@ -934,7 +976,7 @@ qlcnic_pci_mem_access_direct(struct qlcnic_adapter *adapter, u64 off,
                writeq(*data, addr);
 unlock:
-        mutex_unlock(&adapter->ahw.mem_lock);
+        mutex_unlock(&adapter->ahw->mem_lock);
        return ret;
 }
@@ -942,23 +984,23 @@ unlock:
 void
 qlcnic_pci_camqm_read_2M(struct qlcnic_adapter *adapter, u64 off, u64 *data)
 {
-        void __iomem *addr = adapter->ahw.pci_base0 +
+        void __iomem *addr = adapter->ahw->pci_base0 +
                QLCNIC_PCI_CAMQM_2M_BASE + (off - QLCNIC_PCI_CAMQM);
-        mutex_lock(&adapter->ahw.mem_lock);
+        mutex_lock(&adapter->ahw->mem_lock);
        *data = readq(addr);
-        mutex_unlock(&adapter->ahw.mem_lock);
+        mutex_unlock(&adapter->ahw->mem_lock);
 }
 void
 qlcnic_pci_camqm_write_2M(struct qlcnic_adapter *adapter, u64 off, u64 data)
 {
-        void __iomem *addr = adapter->ahw.pci_base0 +
+        void __iomem *addr = adapter->ahw->pci_base0 +
                QLCNIC_PCI_CAMQM_2M_BASE + (off - QLCNIC_PCI_CAMQM);
-        mutex_lock(&adapter->ahw.mem_lock);
+        mutex_lock(&adapter->ahw->mem_lock);
        writeq(data, addr);
-        mutex_unlock(&adapter->ahw.mem_lock);
+        mutex_unlock(&adapter->ahw->mem_lock);
 }
 #define MAX_CTL_CHECK   1000
@@ -997,7 +1039,7 @@ qlcnic_pci_mem_write_2M(struct qlcnic_adapter *adapter,
 correct:
        off8 = off & ~0xf;
-        mutex_lock(&adapter->ahw.mem_lock);
+        mutex_lock(&adapter->ahw->mem_lock);
        writel(off8, (mem_crb + MIU_TEST_AGT_ADDR_LO));
        writel(0, (mem_crb + MIU_TEST_AGT_ADDR_HI));
@@ -1049,7 +1091,7 @@ correct:
                ret = 0;
 done:
-        mutex_unlock(&adapter->ahw.mem_lock);
+        mutex_unlock(&adapter->ahw->mem_lock);
        return ret;
 }
@@ -1091,7 +1133,7 @@ qlcnic_pci_mem_read_2M(struct qlcnic_adapter *adapter,
 correct:
        off8 = off & ~0xf;
-        mutex_lock(&adapter->ahw.mem_lock);
+        mutex_lock(&adapter->ahw->mem_lock);
        writel(off8, (mem_crb + MIU_TEST_AGT_ADDR_LO));
        writel(0, (mem_crb + MIU_TEST_AGT_ADDR_HI));
@@ -1121,7 +1163,7 @@ correct:
                ret = 0;
        }
-        mutex_unlock(&adapter->ahw.mem_lock);
+        mutex_unlock(&adapter->ahw->mem_lock);
        return ret;
 }
@@ -1145,7 +1187,7 @@ int qlcnic_get_board_info(struct qlcnic_adapter *adapter)
        if (qlcnic_rom_fast_read(adapter, offset, &board_type))
                return -EIO;
-        adapter->ahw.board_type = board_type;
+        adapter->ahw->board_type = board_type;
        if (board_type == QLCNIC_BRDTYPE_P3P_4_GB_MM) {
                u32 gpio = QLCRD32(adapter, QLCNIC_ROMUSB_GLB_PAD_GPIO_I);
@@ -1164,20 +1206,20 @@ int qlcnic_get_board_info(struct qlcnic_adapter *adapter)
        case QLCNIC_BRDTYPE_P3P_10G_SFP_QT:
        case QLCNIC_BRDTYPE_P3P_10G_XFP:
        case QLCNIC_BRDTYPE_P3P_10000_BASE_T:
-                adapter->ahw.port_type = QLCNIC_XGBE;
+                adapter->ahw->port_type = QLCNIC_XGBE;
                break;
        case QLCNIC_BRDTYPE_P3P_REF_QG:
        case QLCNIC_BRDTYPE_P3P_4_GB:
        case QLCNIC_BRDTYPE_P3P_4_GB_MM:
-                adapter->ahw.port_type = QLCNIC_GBE;
+                adapter->ahw->port_type = QLCNIC_GBE;
                break;
        case QLCNIC_BRDTYPE_P3P_10G_TP:
-                adapter->ahw.port_type = (adapter->portnum < 2) ?
+                adapter->ahw->port_type = (adapter->portnum < 2) ?
                        QLCNIC_XGBE : QLCNIC_GBE;
                break;
        default:
                dev_err(&pdev->dev, "unknown board type %x\n", board_type);
-                adapter->ahw.port_type = QLCNIC_XGBE;
+                adapter->ahw->port_type = QLCNIC_XGBE;
                break;
        }
@@ -1220,3 +1262,461 @@ int qlcnic_config_led(struct qlcnic_adapter *adapter, u32 state, u32 rate)
        return rv;
 }
+/* FW dump related functions */
+static u32
+qlcnic_dump_crb(struct qlcnic_adapter *adapter, struct qlcnic_dump_entry *entry,
+                u32 *buffer)
+{
+        int i;
+        u32 addr, data;
+        struct __crb *crb = &entry->region.crb;
+        void __iomem *base = adapter->ahw->pci_base0;
+        addr = crb->addr;
+        for (i = 0; i < crb->no_ops; i++) {
+                QLCNIC_RD_DUMP_REG(addr, base, &data);
+                *buffer++ = cpu_to_le32(addr);
+                *buffer++ = cpu_to_le32(data);
+                addr += crb->stride;
+        }
+        return crb->no_ops * 2 * sizeof(u32);
+}
+static u32
+qlcnic_dump_ctrl(struct qlcnic_adapter *adapter,
+        struct qlcnic_dump_entry *entry, u32 *buffer)
+{
+        int i, k, timeout = 0;
+        void __iomem *base = adapter->ahw->pci_base0;
+        u32 addr, data;
+        u8 opcode, no_ops;
+        struct __ctrl *ctr = &entry->region.ctrl;
+        struct qlcnic_dump_template_hdr *t_hdr = adapter->ahw->fw_dump.tmpl_hdr;
+        addr = ctr->addr;
+        no_ops = ctr->no_ops;
+        for (i = 0; i < no_ops; i++) {
+                k = 0;
+                opcode = 0;
+                for (k = 0; k < 8; k++) {
+                        if (!(ctr->opcode & (1 << k)))
+                                continue;
+                        switch (1 << k) {
+                        case QLCNIC_DUMP_WCRB:
+                                QLCNIC_WR_DUMP_REG(addr, base, ctr->val1);
+                                break;
+                        case QLCNIC_DUMP_RWCRB:
+                                QLCNIC_RD_DUMP_REG(addr, base, &data);
+                                QLCNIC_WR_DUMP_REG(addr, base, data);
+                                break;
+                        case QLCNIC_DUMP_ANDCRB:
+                                QLCNIC_RD_DUMP_REG(addr, base, &data);
+                                QLCNIC_WR_DUMP_REG(addr, base,
+                                        (data & ctr->val2));
+                                break;
+                        case QLCNIC_DUMP_ORCRB:
+                                QLCNIC_RD_DUMP_REG(addr, base, &data);
+                                QLCNIC_WR_DUMP_REG(addr, base,
+                                        (data | ctr->val3));
+                                break;
+                        case QLCNIC_DUMP_POLLCRB:
+                                while (timeout <= ctr->timeout) {
+                                        QLCNIC_RD_DUMP_REG(addr, base, &data);
+                                        if ((data & ctr->val2) == ctr->val1)
+                                                break;
+                                        msleep(1);
+                                        timeout++;
+                                }
+                                if (timeout > ctr->timeout) {
+                                        dev_info(&adapter->pdev->dev,
+                                        "Timed out, aborting poll CRB\n");
+                                        return -EINVAL;
+                                }
+                                break;
+                        case QLCNIC_DUMP_RD_SAVE:
+                                if (ctr->index_a)
+                                        addr = t_hdr->saved_state[ctr->index_a];
+                                QLCNIC_RD_DUMP_REG(addr, base, &data);
+                                t_hdr->saved_state[ctr->index_v] = data;
+                                break;
+                        case QLCNIC_DUMP_WRT_SAVED:
+                                if (ctr->index_v)
+                                        data = t_hdr->saved_state[ctr->index_v];
+                                else
+                                        data = ctr->val1;
+                                if (ctr->index_a)
+                                        addr = t_hdr->saved_state[ctr->index_a];
+                                QLCNIC_WR_DUMP_REG(addr, base, data);
+                                break;
+                        case QLCNIC_DUMP_MOD_SAVE_ST:
+                                data = t_hdr->saved_state[ctr->index_v];
+                                data <<= ctr->shl_val;
+                                data >>= ctr->shr_val;
+                                if (ctr->val2)
+                                        data &= ctr->val2;
+                                data |= ctr->val3;
+                                data += ctr->val1;
+                                t_hdr->saved_state[ctr->index_v] = data;
+                                break;
+                        default:
+                                dev_info(&adapter->pdev->dev,
+                                        "Unknown opcode\n");
+                                break;
+                        }
+                }
+                addr += ctr->stride;
+        }
+        return 0;
+}
+static u32
+qlcnic_dump_mux(struct qlcnic_adapter *adapter, struct qlcnic_dump_entry *entry,
+        u32 *buffer)
+{
+        int loop;
+        u32 val, data = 0;
+        struct __mux *mux = &entry->region.mux;
+        void __iomem *base = adapter->ahw->pci_base0;
+        val = mux->val;
+        for (loop = 0; loop < mux->no_ops; loop++) {
+                QLCNIC_WR_DUMP_REG(mux->addr, base, val);
+                QLCNIC_RD_DUMP_REG(mux->read_addr, base, &data);
+                *buffer++ = cpu_to_le32(val);
+                *buffer++ = cpu_to_le32(data);
+                val += mux->val_stride;
+        }
+        return 2 * mux->no_ops * sizeof(u32);
+}
+static u32
+qlcnic_dump_que(struct qlcnic_adapter *adapter, struct qlcnic_dump_entry *entry,
+        u32 *buffer)
+{
+        int i, loop;
+        u32 cnt, addr, data, que_id = 0;
+        void __iomem *base = adapter->ahw->pci_base0;
+        struct __queue *que = &entry->region.que;
+        addr = que->read_addr;
+        cnt = que->read_addr_cnt;
+        for (loop = 0; loop < que->no_ops; loop++) {
+                QLCNIC_WR_DUMP_REG(que->sel_addr, base, que_id);
+                for (i = 0; i < cnt; i++) {
+                        QLCNIC_RD_DUMP_REG(addr, base, &data);
+                        *buffer++ = cpu_to_le32(data);
+                        addr += que->read_addr_stride;
+                }
+                que_id += que->stride;
+        }
+        return que->no_ops * cnt * sizeof(u32);
+}
+static u32
+qlcnic_dump_ocm(struct qlcnic_adapter *adapter, struct qlcnic_dump_entry *entry,
+        u32 *buffer)
+{
+        int i;
+        u32 data;
+        void __iomem *addr;
+        struct __ocm *ocm = &entry->region.ocm;
+        addr = adapter->ahw->pci_base0 + ocm->read_addr;
+        for (i = 0; i < ocm->no_ops; i++) {
+                data = readl(addr);
+                *buffer++ = cpu_to_le32(data);
+                addr += ocm->read_addr_stride;
+        }
+        return ocm->no_ops * sizeof(u32);
+}
+static u32
+qlcnic_read_rom(struct qlcnic_adapter *adapter, struct qlcnic_dump_entry *entry,
+        u32 *buffer)
+{
+        int i, count = 0;
+        u32 fl_addr, size, val, lck_val, addr;
+        struct __mem *rom = &entry->region.mem;
+        void __iomem *base = adapter->ahw->pci_base0;
+        fl_addr = rom->addr;
+        size = rom->size/4;
+lock_try:
+        lck_val = readl(base + QLCNIC_FLASH_SEM2_LK);
+        if (!lck_val && count < MAX_CTL_CHECK) {
+                msleep(10);
+                count++;
+                goto lock_try;
+        }
+        writel(adapter->ahw->pci_func, (base + QLCNIC_FLASH_LOCK_ID));
+        for (i = 0; i < size; i++) {
+                addr = fl_addr & 0xFFFF0000;
+                QLCNIC_WR_DUMP_REG(FLASH_ROM_WINDOW, base, addr);
+                addr = LSW(fl_addr) + FLASH_ROM_DATA;
+                QLCNIC_RD_DUMP_REG(addr, base, &val);
+                fl_addr += 4;
+                *buffer++ = cpu_to_le32(val);
+        }
+        readl(base + QLCNIC_FLASH_SEM2_ULK);
+        return rom->size;
+}
+static u32
+qlcnic_dump_l1_cache(struct qlcnic_adapter *adapter,
+        struct qlcnic_dump_entry *entry, u32 *buffer)
+{
+        int i;
+        u32 cnt, val, data, addr;
+        void __iomem *base = adapter->ahw->pci_base0;
+        struct __cache *l1 = &entry->region.cache;
+        val = l1->init_tag_val;
+        for (i = 0; i < l1->no_ops; i++) {
+                QLCNIC_WR_DUMP_REG(l1->addr, base, val);
+                QLCNIC_WR_DUMP_REG(l1->ctrl_addr, base, LSW(l1->ctrl_val));
+                addr = l1->read_addr;
+                cnt = l1->read_addr_num;
+                while (cnt) {
+                        QLCNIC_RD_DUMP_REG(addr, base, &data);
+                        *buffer++ = cpu_to_le32(data);
+                        addr += l1->read_addr_stride;
+                        cnt--;
+                }
+                val += l1->stride;
+        }
+        return l1->no_ops * l1->read_addr_num * sizeof(u32);
+}
+static u32
+qlcnic_dump_l2_cache(struct qlcnic_adapter *adapter,
+        struct qlcnic_dump_entry *entry, u32 *buffer)
+{
+        int i;
+        u32 cnt, val, data, addr;
+        u8 poll_mask, poll_to, time_out = 0;
+        void __iomem *base = adapter->ahw->pci_base0;
+        struct __cache *l2 = &entry->region.cache;
+        val = l2->init_tag_val;
+        poll_mask = LSB(MSW(l2->ctrl_val));
+        poll_to = MSB(MSW(l2->ctrl_val));
+        for (i = 0; i < l2->no_ops; i++) {
+                QLCNIC_WR_DUMP_REG(l2->addr, base, val);
+                do {
+                        QLCNIC_WR_DUMP_REG(l2->ctrl_addr, base,
+                                LSW(l2->ctrl_val));
+                        QLCNIC_RD_DUMP_REG(l2->ctrl_addr, base, &data);
+                        if (!(data & poll_mask))
+                                break;
+                        msleep(1);
+                        time_out++;
+                } while (time_out <= poll_to);
+                if (time_out > poll_to)
+                        return -EINVAL;
+                addr = l2->read_addr;
+                cnt = l2->read_addr_num;
+                while (cnt) {
+                        QLCNIC_RD_DUMP_REG(addr, base, &data);
+                        *buffer++ = cpu_to_le32(data);
+                        addr += l2->read_addr_stride;
+                        cnt--;
+                }
+                val += l2->stride;
+        }
+        return l2->no_ops * l2->read_addr_num * sizeof(u32);
+}
+static u32
+qlcnic_read_memory(struct qlcnic_adapter *adapter,
+        struct qlcnic_dump_entry *entry, u32 *buffer)
+{
+        u32 addr, data, test, ret = 0;
+        int i, reg_read;
+        struct __mem *mem = &entry->region.mem;
+        void __iomem *base = adapter->ahw->pci_base0;
+        reg_read = mem->size;
+        addr = mem->addr;
+        /* check for data size of multiple of 16 and 16 byte alignment */
+        if ((addr & 0xf) || (reg_read%16)) {
+                dev_info(&adapter->pdev->dev,
+                        "Unaligned memory addr:0x%x size:0x%x\n",
+                        addr, reg_read);
+                return -EINVAL;
+        }
+        mutex_lock(&adapter->ahw->mem_lock);
+        while (reg_read != 0) {
+                QLCNIC_WR_DUMP_REG(MIU_TEST_ADDR_LO, base, addr);
+                QLCNIC_WR_DUMP_REG(MIU_TEST_ADDR_HI, base, 0);
+                QLCNIC_WR_DUMP_REG(MIU_TEST_CTR, base,
+                        TA_CTL_ENABLE | TA_CTL_START);
+                for (i = 0; i < MAX_CTL_CHECK; i++) {
+                        QLCNIC_RD_DUMP_REG(MIU_TEST_CTR, base, &test);
+                        if (!(test & TA_CTL_BUSY))
+                                break;
+                }
+                if (i == MAX_CTL_CHECK) {
+                        if (printk_ratelimit()) {
+                                dev_err(&adapter->pdev->dev,
+                                        "failed to read through agent\n");
+                                ret = -EINVAL;
+                                goto out;
+                        }
+                }
+                for (i = 0; i < 4; i++) {
+                        QLCNIC_RD_DUMP_REG(MIU_TEST_READ_DATA[i], base, &data);
+                        *buffer++ = cpu_to_le32(data);
+                }
+                addr += 16;
+                reg_read -= 16;
+                ret += 16;
+        }
+out:
+        mutex_unlock(&adapter->ahw->mem_lock);
+        return mem->size;
+}
+static u32
+qlcnic_dump_nop(struct qlcnic_adapter *adapter,
+        struct qlcnic_dump_entry *entry, u32 *buffer)
+{
+        entry->hdr.flags |= QLCNIC_DUMP_SKIP;
+        return 0;
+}
+struct qlcnic_dump_operations fw_dump_ops[] = {
+        { QLCNIC_DUMP_NOP, qlcnic_dump_nop },
+        { QLCNIC_DUMP_READ_CRB, qlcnic_dump_crb },
+        { QLCNIC_DUMP_READ_MUX, qlcnic_dump_mux },
+        { QLCNIC_DUMP_QUEUE, qlcnic_dump_que },
+        { QLCNIC_DUMP_BRD_CONFIG, qlcnic_read_rom },
+        { QLCNIC_DUMP_READ_OCM, qlcnic_dump_ocm },
+        { QLCNIC_DUMP_PEG_REG, qlcnic_dump_ctrl },
+        { QLCNIC_DUMP_L1_DTAG, qlcnic_dump_l1_cache },
+        { QLCNIC_DUMP_L1_ITAG, qlcnic_dump_l1_cache },
+        { QLCNIC_DUMP_L1_DATA, qlcnic_dump_l1_cache },
+        { QLCNIC_DUMP_L1_INST, qlcnic_dump_l1_cache },
+        { QLCNIC_DUMP_L2_DTAG, qlcnic_dump_l2_cache },
+        { QLCNIC_DUMP_L2_ITAG, qlcnic_dump_l2_cache },
+        { QLCNIC_DUMP_L2_DATA, qlcnic_dump_l2_cache },
+        { QLCNIC_DUMP_L2_INST, qlcnic_dump_l2_cache },
+        { QLCNIC_DUMP_READ_ROM, qlcnic_read_rom },
+        { QLCNIC_DUMP_READ_MEM, qlcnic_read_memory },
+        { QLCNIC_DUMP_READ_CTRL, qlcnic_dump_ctrl },
+        { QLCNIC_DUMP_TLHDR, qlcnic_dump_nop },
+        { QLCNIC_DUMP_RDEND, qlcnic_dump_nop },
+};
+/* Walk the template and collect dump for each entry in the dump template */
+static int
+qlcnic_valid_dump_entry(struct device *dev, struct qlcnic_dump_entry *entry,
+        u32 size)
+{
+        int ret = 1;
+        if (size != entry->hdr.cap_size) {
+                dev_info(dev,
+                "Invalidate dump, Type:%d\tMask:%d\tSize:%dCap_size:%d\n",
+                entry->hdr.type, entry->hdr.mask, size, entry->hdr.cap_size);
+                dev_info(dev, "Aborting further dump capture\n");
+                ret = 0;
+        }
+        return ret;
+}
+int qlcnic_dump_fw(struct qlcnic_adapter *adapter)
+{
+        u32 *buffer;
+        char mesg[64];
+        char *msg[] = {mesg, NULL};
+        int i, k, ops_cnt, ops_index, dump_size = 0;
+        u32 entry_offset, dump, no_entries, buf_offset = 0;
+        struct qlcnic_dump_entry *entry;
+        struct qlcnic_fw_dump *fw_dump = &adapter->ahw->fw_dump;
+        struct qlcnic_dump_template_hdr *tmpl_hdr = fw_dump->tmpl_hdr;
+        if (fw_dump->clr) {
+                dev_info(&adapter->pdev->dev,
+                        "Previous dump not cleared, not capturing dump\n");
+                return -EIO;
+        }
+        /* Calculate the size for dump data area only */
+        for (i = 2, k = 1; (i & QLCNIC_DUMP_MASK_MAX); i <<= 1, k++)
+                if (i & tmpl_hdr->drv_cap_mask)
+                        dump_size += tmpl_hdr->cap_sizes[k];
+        if (!dump_size)
+                return -EIO;
+        fw_dump->data = vzalloc(dump_size);
+        if (!fw_dump->data) {
+                dev_info(&adapter->pdev->dev,
+                        "Unable to allocate (%d KB) for fw dump\n",
+                        dump_size/1024);
+                return -ENOMEM;
+        }
+        buffer = fw_dump->data;
+        fw_dump->size = dump_size;
+        no_entries = tmpl_hdr->num_entries;
+        ops_cnt = ARRAY_SIZE(fw_dump_ops);
+        entry_offset = tmpl_hdr->offset;
+        tmpl_hdr->sys_info[0] = QLCNIC_DRIVER_VERSION;
+        tmpl_hdr->sys_info[1] = adapter->fw_version;
+        for (i = 0; i < no_entries; i++) {
+                entry = (struct qlcnic_dump_entry *) ((void *) tmpl_hdr +
+                        entry_offset);
+                if (!(entry->hdr.mask & tmpl_hdr->drv_cap_mask)) {
+                        entry->hdr.flags |= QLCNIC_DUMP_SKIP;
+                        entry_offset += entry->hdr.offset;
+                        continue;
+                }
+                /* Find the handler for this entry */
+                ops_index = 0;
+                while (ops_index < ops_cnt) {
+                        if (entry->hdr.type == fw_dump_ops[ops_index].opcode)
+                                break;
+                        ops_index++;
+                }
+                if (ops_index == ops_cnt) {
+                        dev_info(&adapter->pdev->dev,
+                                "Invalid entry type %d, exiting dump\n",
+                                entry->hdr.type);
+                        goto error;
+                }
+                /* Collect dump for this entry */
+                dump = fw_dump_ops[ops_index].handler(adapter, entry, buffer);
+                if (dump && !qlcnic_valid_dump_entry(&adapter->pdev->dev, entry,
+                        dump))
+                        entry->hdr.flags |= QLCNIC_DUMP_SKIP;
+                buf_offset += entry->hdr.cap_size;
+                entry_offset += entry->hdr.offset;
+                buffer = fw_dump->data + buf_offset;
+        }
+        if (dump_size != buf_offset) {
+                dev_info(&adapter->pdev->dev,
+                        "Captured(%d) and expected size(%d) do not match\n",
+                        buf_offset, dump_size);
+                goto error;
+        } else {
+                fw_dump->clr = 1;
+                snprintf(mesg, sizeof(mesg), "FW dump for device: %d\n",
+                        adapter->pdev->devfn);
+                dev_info(&adapter->pdev->dev, "Dump data, %d bytes captured\n",
+                        fw_dump->size);
+                /* Send a udev event to notify availability of FW dump */
+                kobject_uevent_env(&adapter->pdev->dev.kobj, KOBJ_CHANGE, msg);
+                return 0;
+        }
+error:
+        vfree(fw_dump->data);
+        return -EINVAL;
+}
diff --git a/drivers/net/qlcnic/qlcnic_init.c b/drivers/net/qlcnic/qlcnic_init.c
index a7f1d5b7e811..5b8bbcf904d5 100644
--- a/drivers/net/qlcnic/qlcnic_init.c
+++ b/drivers/net/qlcnic/qlcnic_init.c
@@ -94,7 +94,7 @@ void qlcnic_release_rx_buffers(struct qlcnic_adapter *adapter)
        struct qlcnic_rx_buffer *rx_buf;
        int i, ring;
-        recv_ctx = &adapter->recv_ctx;
+        recv_ctx = adapter->recv_ctx;
        for (ring = 0; ring < adapter->max_rds_rings; ring++) {
                rds_ring = &recv_ctx->rds_rings[ring];
                for (i = 0; i < rds_ring->num_desc; ++i) {
@@ -119,7 +119,7 @@ void qlcnic_reset_rx_buffers_list(struct qlcnic_adapter *adapter)
        struct qlcnic_rx_buffer *rx_buf;
        int i, ring;
-        recv_ctx = &adapter->recv_ctx;
+        recv_ctx = adapter->recv_ctx;
        for (ring = 0; ring < adapter->max_rds_rings; ring++) {
                rds_ring = &recv_ctx->rds_rings[ring];
@@ -173,7 +173,7 @@ void qlcnic_free_sw_resources(struct qlcnic_adapter *adapter)
        struct qlcnic_host_tx_ring *tx_ring;
        int ring;
-        recv_ctx = &adapter->recv_ctx;
+        recv_ctx = adapter->recv_ctx;
        if (recv_ctx->rds_rings == NULL)
                goto skip_rds;
@@ -226,7 +226,7 @@ int qlcnic_alloc_sw_resources(struct qlcnic_adapter *adapter)
        }
        tx_ring->cmd_buf_arr = cmd_buf_arr;
-        recv_ctx = &adapter->recv_ctx;
+        recv_ctx = adapter->recv_ctx;
        size = adapter->max_rds_rings * sizeof(struct qlcnic_host_rds_ring);
        rds_ring = kzalloc(size, GFP_KERNEL);
@@ -345,7 +345,7 @@ static int qlcnic_wait_rom_done(struct qlcnic_adapter *adapter)
 }
 static int do_rom_fast_read(struct qlcnic_adapter *adapter,
-                            int addr, int *valp)
+                            u32 addr, u32 *valp)
 {
        QLCWR32(adapter, QLCNIC_ROMUSB_ROM_ADDRESS, addr);
        QLCWR32(adapter, QLCNIC_ROMUSB_ROM_DUMMY_BYTE_CNT, 0);
@@ -398,7 +398,7 @@ qlcnic_rom_fast_read_words(struct qlcnic_adapter *adapter, int addr,
        return ret;
 }
-int qlcnic_rom_fast_read(struct qlcnic_adapter *adapter, int addr, int *valp)
+int qlcnic_rom_fast_read(struct qlcnic_adapter *adapter, u32 addr, u32 *valp)
 {
        int ret;
@@ -864,7 +864,7 @@ nomn:
        for (i = 0; i < entries; i++) {
                __le32 flags, file_chiprev, offs;
-                u8 chiprev = adapter->ahw.revision_id;
+                u8 chiprev = adapter->ahw->revision_id;
                u32 flagbit;
                offs = cpu_to_le32(ptab_descr->findex) +
@@ -1130,9 +1130,20 @@ qlcnic_load_firmware(struct qlcnic_adapter *adapter)
        } else {
                u64 data;
                u32 hi, lo;
+                int ret;
-                size = (QLCNIC_IMAGE_START - QLCNIC_BOOTLD_START) / 8;
+                struct qlcnic_flt_entry bootld_entry;
-                flashaddr = QLCNIC_BOOTLD_START;
+                ret = qlcnic_get_flt_entry(adapter, QLCNIC_BOOTLD_REGION,
+                                        &bootld_entry);
+                if (!ret) {
+                        size = bootld_entry.size / 8;
+                        flashaddr = bootld_entry.start_addr;
+                } else {
+                        size = (QLCNIC_IMAGE_START - QLCNIC_BOOTLD_START) / 8;
+                        flashaddr = QLCNIC_BOOTLD_START;
+                        dev_info(&pdev->dev,
+                                "using legacy method to get flash fw region");
+                }
                for (i = 0; i < size; i++) {
                        if (qlcnic_rom_fast_read(adapter,
@@ -1379,8 +1390,8 @@ static struct sk_buff *qlcnic_process_rxbuf(struct qlcnic_adapter *adapter,
        skb = buffer->skb;
-        if (likely(adapter->rx_csum && (cksum == STATUS_CKSUM_OK ||
+        if (likely((adapter->netdev->features & NETIF_F_RXCSUM) &&
-                                                cksum == STATUS_CKSUM_LOOP))) {
+            (cksum == STATUS_CKSUM_OK || cksum == STATUS_CKSUM_LOOP))) {
                adapter->stats.csummed++;
                skb->ip_summed = CHECKSUM_UNNECESSARY;
        } else {
@@ -1394,7 +1405,7 @@ static struct sk_buff *qlcnic_process_rxbuf(struct qlcnic_adapter *adapter,
        return skb;
 }
-static int
+static inline int
 qlcnic_check_rx_tagging(struct qlcnic_adapter *adapter, struct sk_buff *skb,
                        u16 *vlan_tag)
 {
@@ -1425,7 +1436,7 @@ qlcnic_process_rcv(struct qlcnic_adapter *adapter,
                int ring, u64 sts_data0)
 {
        struct net_device *netdev = adapter->netdev;
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        struct qlcnic_rx_buffer *buffer;
        struct sk_buff *skb;
        struct qlcnic_host_rds_ring *rds_ring;
@@ -1467,10 +1478,10 @@ qlcnic_process_rcv(struct qlcnic_adapter *adapter,
        skb->protocol = eth_type_trans(skb, netdev);
-        if ((vid != 0xffff) && adapter->vlgrp)
+        if (vid != 0xffff)
-                vlan_gro_receive(&sds_ring->napi, adapter->vlgrp, vid, skb);
+                __vlan_hwaccel_put_tag(skb, vid);
-        else
-                napi_gro_receive(&sds_ring->napi, skb);
+        napi_gro_receive(&sds_ring->napi, skb);
        adapter->stats.rx_pkts++;
        adapter->stats.rxbytes += length;
@@ -1488,7 +1499,7 @@ qlcnic_process_lro(struct qlcnic_adapter *adapter,
                int ring, u64 sts_data0, u64 sts_data1)
 {
        struct net_device *netdev = adapter->netdev;
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        struct qlcnic_rx_buffer *buffer;
        struct sk_buff *skb;
        struct qlcnic_host_rds_ring *rds_ring;
@@ -1552,10 +1563,9 @@ qlcnic_process_lro(struct qlcnic_adapter *adapter,
        length = skb->len;
-        if ((vid != 0xffff) && adapter->vlgrp)
+        if (vid != 0xffff)
-                vlan_hwaccel_receive_skb(skb, adapter->vlgrp, vid);
+                __vlan_hwaccel_put_tag(skb, vid);
-        else
+        netif_receive_skb(skb);
-                netif_receive_skb(skb);
        adapter->stats.lro_pkts++;
        adapter->stats.lrobytes += length;
@@ -1625,7 +1635,7 @@ skip:
        for (ring = 0; ring < adapter->max_rds_rings; ring++) {
                struct qlcnic_host_rds_ring *rds_ring =
-                        &adapter->recv_ctx.rds_rings[ring];
+                        &adapter->recv_ctx->rds_rings[ring];
                if (!list_empty(&sds_ring->free_list[ring])) {
                        list_for_each(cur, &sds_ring->free_list[ring]) {
@@ -1651,12 +1661,13 @@ skip:
 }
 void
-qlcnic_post_rx_buffers(struct qlcnic_adapter *adapter, u32 ringid,
+qlcnic_post_rx_buffers(struct qlcnic_adapter *adapter,
        struct qlcnic_host_rds_ring *rds_ring)
 {
        struct rcv_desc *pdesc;
        struct qlcnic_rx_buffer *buffer;
-        int producer, count = 0;
+        int count = 0;
+        u32 producer;
        struct list_head *head;
        producer = rds_ring->producer;
@@ -1696,7 +1707,8 @@ qlcnic_post_rx_buffers_nodb(struct qlcnic_adapter *adapter,
 {
        struct rcv_desc *pdesc;
        struct qlcnic_rx_buffer *buffer;
-        int producer, count = 0;
+        int  count = 0;
+        uint32_t producer;
        struct list_head *head;
        if (!spin_trylock(&rds_ring->lock))
diff --git a/drivers/net/qlcnic/qlcnic_main.c b/drivers/net/qlcnic/qlcnic_main.c
index cb1a1ef36c0a..3ab7d2c7baf2 100644
--- a/drivers/net/qlcnic/qlcnic_main.c
+++ b/drivers/net/qlcnic/qlcnic_main.c
@@ -13,12 +13,12 @@
 #include <linux/swab.h>
 #include <linux/dma-mapping.h>
-#include <linux/if_vlan.h>
 #include <net/ip.h>
 #include <linux/ipv6.h>
 #include <linux/inetdevice.h>
 #include <linux/sysfs.h>
 #include <linux/aer.h>
+#include <linux/log2.h>
 MODULE_DESCRIPTION("QLogic 1/10 GbE Converged/Intelligent Ethernet Driver");
 MODULE_LICENSE("GPL");
@@ -98,6 +98,9 @@ static int qlcnicvf_config_bridged_mode(struct qlcnic_adapter *, u32);
 static int qlcnicvf_start_firmware(struct qlcnic_adapter *);
 static void qlcnic_set_netdev_features(struct qlcnic_adapter *,
                                struct qlcnic_esw_func_cfg *);
+static void qlcnic_vlan_rx_add(struct net_device *, u16);
+static void qlcnic_vlan_rx_del(struct net_device *, u16);
 /*  PCI Device ID Table  */
 #define ENTRY(device) \
        {PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, (device)), \
@@ -113,7 +116,7 @@ static DEFINE_PCI_DEVICE_TABLE(qlcnic_pci_tbl) = {
 MODULE_DEVICE_TABLE(pci, qlcnic_pci_tbl);
-void
+inline void
 qlcnic_update_cmd_producer(struct qlcnic_adapter *adapter,
                struct qlcnic_host_tx_ring *tx_ring)
 {
@@ -169,7 +172,7 @@ qlcnic_napi_add(struct qlcnic_adapter *adapter, struct net_device *netdev)
 {
        int ring;
        struct qlcnic_host_sds_ring *sds_ring;
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        if (qlcnic_alloc_sds_rings(recv_ctx, adapter->max_sds_rings))
                return -ENOMEM;
@@ -193,14 +196,14 @@ qlcnic_napi_del(struct qlcnic_adapter *adapter)
 {
        int ring;
        struct qlcnic_host_sds_ring *sds_ring;
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        for (ring = 0; ring < adapter->max_sds_rings; ring++) {
                sds_ring = &recv_ctx->sds_rings[ring];
                netif_napi_del(&sds_ring->napi);
        }
-        qlcnic_free_sds_rings(&adapter->recv_ctx);
+        qlcnic_free_sds_rings(adapter->recv_ctx);
 }
 static void
@@ -208,7 +211,7 @@ qlcnic_napi_enable(struct qlcnic_adapter *adapter)
 {
        int ring;
        struct qlcnic_host_sds_ring *sds_ring;
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        if (adapter->is_up != QLCNIC_ADAPTER_UP_MAGIC)
                return;
@@ -225,7 +228,7 @@ qlcnic_napi_disable(struct qlcnic_adapter *adapter)
 {
        int ring;
        struct qlcnic_host_sds_ring *sds_ring;
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        if (adapter->is_up != QLCNIC_ADAPTER_UP_MAGIC)
                return;
@@ -317,13 +320,6 @@ static int qlcnic_set_mac(struct net_device *netdev, void *p)
        return 0;
 }
-static void qlcnic_vlan_rx_register(struct net_device *netdev,
-                struct vlan_group *grp)
-{
-        struct qlcnic_adapter *adapter = netdev_priv(netdev);
-        adapter->vlgrp = grp;
-}
 static const struct net_device_ops qlcnic_netdev_ops = {
        .ndo_open          = qlcnic_open,
        .ndo_stop          = qlcnic_close,
@@ -333,8 +329,11 @@ static const struct net_device_ops qlcnic_netdev_ops = {
        .ndo_set_multicast_list = qlcnic_set_multi,
        .ndo_set_mac_address    = qlcnic_set_mac,
        .ndo_change_mtu    = qlcnic_change_mtu,
+        .ndo_fix_features  = qlcnic_fix_features,
+        .ndo_set_features  = qlcnic_set_features,
        .ndo_tx_timeout    = qlcnic_tx_timeout,
-        .ndo_vlan_rx_register = qlcnic_vlan_rx_register,
+        .ndo_vlan_rx_add_vid    = qlcnic_vlan_rx_add,
+        .ndo_vlan_rx_kill_vid   = qlcnic_vlan_rx_del,
 #ifdef CONFIG_NET_POLL_CONTROLLER
        .ndo_poll_controller = qlcnic_poll_controller,
 #endif
@@ -352,72 +351,87 @@ static struct qlcnic_nic_template qlcnic_vf_ops = {
        .start_firmware = qlcnicvf_start_firmware
 };
-static void
+static int qlcnic_enable_msix(struct qlcnic_adapter *adapter, u32 num_msix)
-qlcnic_setup_intr(struct qlcnic_adapter *adapter)
 {
-        const struct qlcnic_legacy_intr_set *legacy_intrp;
        struct pci_dev *pdev = adapter->pdev;
-        int err, num_msix;
+        int err = -1;
-        if (adapter->rss_supported) {
-                num_msix = (num_online_cpus() >= MSIX_ENTRIES_PER_ADAPTER) ?
-                        MSIX_ENTRIES_PER_ADAPTER : 2;
-        } else
-                num_msix = 1;
        adapter->max_sds_rings = 1;
        adapter->flags &= ~(QLCNIC_MSI_ENABLED | QLCNIC_MSIX_ENABLED);
-        legacy_intrp = &legacy_intr[adapter->ahw.pci_func];
-        adapter->int_vec_bit = legacy_intrp->int_vec_bit;
-        adapter->tgt_status_reg = qlcnic_get_ioaddr(adapter,
-                        legacy_intrp->tgt_status_reg);
-        adapter->tgt_mask_reg = qlcnic_get_ioaddr(adapter,
-                        legacy_intrp->tgt_mask_reg);
-        adapter->isr_int_vec = qlcnic_get_ioaddr(adapter, ISR_INT_VECTOR);
-        adapter->crb_int_state_reg = qlcnic_get_ioaddr(adapter,
-                        ISR_INT_STATE_REG);
        qlcnic_set_msix_bit(pdev, 0);
        if (adapter->msix_supported) {
+ enable_msix:
                qlcnic_init_msix_entries(adapter, num_msix);
                err = pci_enable_msix(pdev, adapter->msix_entries, num_msix);
                if (err == 0) {
                        adapter->flags |= QLCNIC_MSIX_ENABLED;
                        qlcnic_set_msix_bit(pdev, 1);
-                        if (adapter->rss_supported)
+                        adapter->max_sds_rings = num_msix;
-                                adapter->max_sds_rings = num_msix;
                        dev_info(&pdev->dev, "using msi-x interrupts\n");
-                        return;
+                        return err;
                }
+                if (err > 0) {
+                        num_msix = rounddown_pow_of_two(err);
+                        if (num_msix)
+                                goto enable_msix;
+                }
+        }
+        return err;
+}
-                if (err > 0)
-                        pci_disable_msix(pdev);
-                /* fall through for msi */
+static void qlcnic_enable_msi_legacy(struct qlcnic_adapter *adapter)
-        }
+{
+        const struct qlcnic_legacy_intr_set *legacy_intrp;
+        struct pci_dev *pdev = adapter->pdev;
        if (use_msi && !pci_enable_msi(pdev)) {
                adapter->flags |= QLCNIC_MSI_ENABLED;
                adapter->tgt_status_reg = qlcnic_get_ioaddr(adapter,
-                                msi_tgt_status[adapter->ahw.pci_func]);
+                                msi_tgt_status[adapter->ahw->pci_func]);
                dev_info(&pdev->dev, "using msi interrupts\n");
                adapter->msix_entries[0].vector = pdev->irq;
                return;
        }
+        legacy_intrp = &legacy_intr[adapter->ahw->pci_func];
+        adapter->int_vec_bit = legacy_intrp->int_vec_bit;
+        adapter->tgt_status_reg = qlcnic_get_ioaddr(adapter,
+                        legacy_intrp->tgt_status_reg);
+        adapter->tgt_mask_reg = qlcnic_get_ioaddr(adapter,
+                        legacy_intrp->tgt_mask_reg);
+        adapter->isr_int_vec = qlcnic_get_ioaddr(adapter, ISR_INT_VECTOR);
+        adapter->crb_int_state_reg = qlcnic_get_ioaddr(adapter,
+                        ISR_INT_STATE_REG);
        dev_info(&pdev->dev, "using legacy interrupts\n");
        adapter->msix_entries[0].vector = pdev->irq;
 }
 static void
+qlcnic_setup_intr(struct qlcnic_adapter *adapter)
+{
+        int num_msix;
+        if (adapter->msix_supported) {
+                num_msix = (num_online_cpus() >=
+                        QLCNIC_DEF_NUM_STS_DESC_RINGS) ?
+                        QLCNIC_DEF_NUM_STS_DESC_RINGS :
+                        QLCNIC_MIN_NUM_RSS_RINGS;
+        } else
+                num_msix = 1;
+        if (!qlcnic_enable_msix(adapter, num_msix))
+                return;
+        qlcnic_enable_msi_legacy(adapter);
+}
+static void
 qlcnic_teardown_intr(struct qlcnic_adapter *adapter)
 {
        if (adapter->flags & QLCNIC_MSIX_ENABLED)
@@ -429,8 +443,8 @@ qlcnic_teardown_intr(struct qlcnic_adapter *adapter)
 static void
 qlcnic_cleanup_pci_map(struct qlcnic_adapter *adapter)
 {
-        if (adapter->ahw.pci_base0 != NULL)
+        if (adapter->ahw->pci_base0 != NULL)
-                iounmap(adapter->ahw.pci_base0);
+                iounmap(adapter->ahw->pci_base0);
 }
 static int
@@ -464,8 +478,10 @@ qlcnic_init_pci_info(struct qlcnic_adapter *adapter)
        for (i = 0; i < QLCNIC_MAX_PCI_FUNC; i++) {
                pfn = pci_info[i].id;
-                if (pfn > QLCNIC_MAX_PCI_FUNC)
+                if (pfn > QLCNIC_MAX_PCI_FUNC) {
-                        return QL_STATUS_INVALID_PARAM;
+                        ret = QL_STATUS_INVALID_PARAM;
+                        goto err_eswitch;
+                }
                adapter->npars[pfn].active = (u8)pci_info[i].active;
                adapter->npars[pfn].type = (u8)pci_info[i].type;
                adapter->npars[pfn].phy_port = (u8)pci_info[i].default_port;
@@ -498,7 +514,7 @@ qlcnic_set_function_modes(struct qlcnic_adapter *adapter)
        u32 ref_count;
        int i, ret = 1;
        u32 data = QLCNIC_MGMT_FUNC;
-        void __iomem *priv_op = adapter->ahw.pci_base0 + QLCNIC_DRV_OP_MODE;
+        void __iomem *priv_op = adapter->ahw->pci_base0 + QLCNIC_DRV_OP_MODE;
        /* If other drivers are not in use set their privilege level */
        ref_count = QLCRD32(adapter, QLCNIC_CRB_DRV_ACTIVE);
@@ -510,16 +526,16 @@ qlcnic_set_function_modes(struct qlcnic_adapter *adapter)
                for (i = 0; i < QLCNIC_MAX_PCI_FUNC; i++) {
                        id = i;
                        if (adapter->npars[i].type != QLCNIC_TYPE_NIC ||
-                                id == adapter->ahw.pci_func)
+                                id == adapter->ahw->pci_func)
                                continue;
                        data |= (qlcnic_config_npars &
                                        QLC_DEV_SET_DRV(0xf, id));
                }
        } else {
                data = readl(priv_op);
-                data = (data & ~QLC_DEV_SET_DRV(0xf, adapter->ahw.pci_func)) |
+                data = (data & ~QLC_DEV_SET_DRV(0xf, adapter->ahw->pci_func)) |
                        (QLC_DEV_SET_DRV(QLCNIC_MGMT_FUNC,
-                        adapter->ahw.pci_func));
+                        adapter->ahw->pci_func));
        }
        writel(data, priv_op);
        qlcnic_api_unlock(adapter);
@@ -537,22 +553,23 @@ qlcnic_check_vf(struct qlcnic_adapter *adapter)
        u32 op_mode, priv_level;
        /* Determine FW API version */
-        adapter->fw_hal_version = readl(adapter->ahw.pci_base0 + QLCNIC_FW_API);
+        adapter->fw_hal_version = readl(adapter->ahw->pci_base0 +
+                                        QLCNIC_FW_API);
        /* Find PCI function number */
        pci_read_config_dword(adapter->pdev, QLCNIC_MSIX_TABLE_OFFSET, &func);
-        msix_base_addr = adapter->ahw.pci_base0 + QLCNIC_MSIX_BASE;
+        msix_base_addr = adapter->ahw->pci_base0 + QLCNIC_MSIX_BASE;
        msix_base = readl(msix_base_addr);
        func = (func - msix_base)/QLCNIC_MSIX_TBL_PGSIZE;
-        adapter->ahw.pci_func = func;
+        adapter->ahw->pci_func = func;
        /* Determine function privilege level */
-        priv_op = adapter->ahw.pci_base0 + QLCNIC_DRV_OP_MODE;
+        priv_op = adapter->ahw->pci_base0 + QLCNIC_DRV_OP_MODE;
        op_mode = readl(priv_op);
        if (op_mode == QLC_DEV_DRV_DEFAULT)
                priv_level = QLCNIC_MGMT_FUNC;
        else
-                priv_level = QLC_DEV_GET_DRV(op_mode, adapter->ahw.pci_func);
+                priv_level = QLC_DEV_GET_DRV(op_mode, adapter->ahw->pci_func);
        if (priv_level == QLCNIC_NON_PRIV_FUNC) {
                adapter->op_mode = QLCNIC_NON_PRIV_FUNC;
@@ -591,13 +608,14 @@ qlcnic_setup_pci_map(struct qlcnic_adapter *adapter)
        dev_info(&pdev->dev, "%dMB memory map\n", (int)(mem_len>>20));
-        adapter->ahw.pci_base0 = mem_ptr0;
+        adapter->ahw->pci_base0 = mem_ptr0;
-        adapter->ahw.pci_len0 = pci_len0;
+        adapter->ahw->pci_len0 = pci_len0;
        qlcnic_check_vf(adapter);
-        adapter->ahw.ocm_win_crb = qlcnic_get_ioaddr(adapter,
+        adapter->ahw->ocm_win_crb = qlcnic_get_ioaddr(adapter,
-                QLCNIC_PCIX_PS_REG(PCIX_OCM_WINDOW_REG(adapter->ahw.pci_func)));
+                QLCNIC_PCIX_PS_REG(PCIX_OCM_WINDOW_REG(
+                        adapter->ahw->pci_func)));
        return 0;
 }
@@ -639,7 +657,7 @@ qlcnic_check_options(struct qlcnic_adapter *adapter)
        dev_info(&pdev->dev, "firmware v%d.%d.%d\n",
                        fw_major, fw_minor, fw_build);
-        if (adapter->ahw.port_type == QLCNIC_XGBE) {
+        if (adapter->ahw->port_type == QLCNIC_XGBE) {
                if (adapter->flags & QLCNIC_ESWITCH_ENABLED) {
                        adapter->num_rxd = DEFAULT_RCV_DESCRIPTORS_VF;
                        adapter->max_rxd = MAX_RCV_DESCRIPTORS_VF;
@@ -651,7 +669,7 @@ qlcnic_check_options(struct qlcnic_adapter *adapter)
                adapter->num_jumbo_rxd = MAX_JUMBO_RCV_DESCRIPTORS_10G;
                adapter->max_jumbo_rxd = MAX_JUMBO_RCV_DESCRIPTORS_10G;
-        } else if (adapter->ahw.port_type == QLCNIC_GBE) {
+        } else if (adapter->ahw->port_type == QLCNIC_GBE) {
                adapter->num_rxd = DEFAULT_RCV_DESCRIPTORS_1G;
                adapter->num_jumbo_rxd = MAX_JUMBO_RCV_DESCRIPTORS_1G;
                adapter->max_jumbo_rxd = MAX_JUMBO_RCV_DESCRIPTORS_1G;
@@ -659,7 +677,6 @@ qlcnic_check_options(struct qlcnic_adapter *adapter)
        }
        adapter->msix_supported = !!use_msi_x;
-        adapter->rss_supported = !!use_msi_x;
        adapter->num_txd = MAX_CMD_DESCRIPTORS;
@@ -672,7 +689,7 @@ qlcnic_initialize_nic(struct qlcnic_adapter *adapter)
        int err;
        struct qlcnic_info nic_info;
-        err = qlcnic_get_nic_info(adapter, &nic_info, adapter->ahw.pci_func);
+        err = qlcnic_get_nic_info(adapter, &nic_info, adapter->ahw->pci_func);
        if (err)
                return err;
@@ -708,6 +725,22 @@ qlcnic_set_vlan_config(struct qlcnic_adapter *adapter,
 }
 static void
+qlcnic_vlan_rx_add(struct net_device *netdev, u16 vid)
+{
+        struct qlcnic_adapter *adapter = netdev_priv(netdev);
+        set_bit(vid, adapter->vlans);
+}
+static void
+qlcnic_vlan_rx_del(struct net_device *netdev, u16 vid)
+{
+        struct qlcnic_adapter *adapter = netdev_priv(netdev);
+        qlcnic_restore_indev_addr(netdev, NETDEV_DOWN);
+        clear_bit(vid, adapter->vlans);
+}
+static void
 qlcnic_set_eswitch_port_features(struct qlcnic_adapter *adapter,
                struct qlcnic_esw_func_cfg *esw_cfg)
 {
@@ -734,7 +767,7 @@ qlcnic_set_eswitch_port_config(struct qlcnic_adapter *adapter)
        if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
                return 0;
-        esw_cfg.pci_func = adapter->ahw.pci_func;
+        esw_cfg.pci_func = adapter->ahw->pci_func;
        if (qlcnic_get_eswitch_port_config(adapter, &esw_cfg))
                        return -EIO;
        qlcnic_set_vlan_config(adapter, &esw_cfg);
@@ -750,28 +783,27 @@ qlcnic_set_netdev_features(struct qlcnic_adapter *adapter,
        struct net_device *netdev = adapter->netdev;
        unsigned long features, vlan_features;
-        features = (NETIF_F_SG | NETIF_F_IP_CSUM |
+        features = (NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_RXCSUM |
                        NETIF_F_IPV6_CSUM | NETIF_F_GRO);
        vlan_features = (NETIF_F_SG | NETIF_F_IP_CSUM |
-                        NETIF_F_IPV6_CSUM);
+                        NETIF_F_IPV6_CSUM | NETIF_F_HW_VLAN_FILTER);
        if (adapter->capabilities & QLCNIC_FW_CAPABILITY_TSO) {
                features |= (NETIF_F_TSO | NETIF_F_TSO6);
                vlan_features |= (NETIF_F_TSO | NETIF_F_TSO6);
        }
-        if (adapter->capabilities & QLCNIC_FW_CAPABILITY_HW_LRO)
+        if (netdev->features & NETIF_F_LRO)
                features |= NETIF_F_LRO;
        if (esw_cfg->offload_flags & BIT_0) {
                netdev->features |= features;
-                adapter->rx_csum = 1;
                if (!(esw_cfg->offload_flags & BIT_1))
                        netdev->features &= ~NETIF_F_TSO;
                if (!(esw_cfg->offload_flags & BIT_2))
                        netdev->features &= ~NETIF_F_TSO6;
        } else {
                netdev->features &= ~features;
-                adapter->rx_csum = 0;
        }
        netdev->vlan_features = (features & vlan_features);
@@ -791,14 +823,14 @@ qlcnic_check_eswitch_mode(struct qlcnic_adapter *adapter)
        if (adapter->flags & QLCNIC_ADAPTER_INITIALIZED)
                return 0;
-        priv_op = adapter->ahw.pci_base0 + QLCNIC_DRV_OP_MODE;
+        priv_op = adapter->ahw->pci_base0 + QLCNIC_DRV_OP_MODE;
        op_mode = readl(priv_op);
-        priv_level = QLC_DEV_GET_DRV(op_mode, adapter->ahw.pci_func);
+        priv_level = QLC_DEV_GET_DRV(op_mode, adapter->ahw->pci_func);
        if (op_mode == QLC_DEV_DRV_DEFAULT)
                priv_level = QLCNIC_MGMT_FUNC;
        else
-                priv_level = QLC_DEV_GET_DRV(op_mode, adapter->ahw.pci_func);
+                priv_level = QLC_DEV_GET_DRV(op_mode, adapter->ahw->pci_func);
        if (adapter->flags & QLCNIC_ESWITCH_ENABLED) {
                if (priv_level == QLCNIC_MGMT_FUNC) {
@@ -1038,7 +1070,7 @@ qlcnic_request_irq(struct qlcnic_adapter *adapter)
        unsigned long flags = 0;
        struct net_device *netdev = adapter->netdev;
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        if (adapter->diag_test == QLCNIC_INTERRUPT_TEST) {
                handler = qlcnic_tmp_intr;
@@ -1075,7 +1107,7 @@ qlcnic_free_irq(struct qlcnic_adapter *adapter)
        int ring;
        struct qlcnic_host_sds_ring *sds_ring;
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        for (ring = 0; ring < adapter->max_sds_rings; ring++) {
                sds_ring = &recv_ctx->sds_rings[ring];
@@ -1083,20 +1115,6 @@ qlcnic_free_irq(struct qlcnic_adapter *adapter)
        }
 }
-static void
-qlcnic_init_coalesce_defaults(struct qlcnic_adapter *adapter)
-{
-        adapter->coal.flags = QLCNIC_INTR_DEFAULT;
-        adapter->coal.normal.data.rx_time_us =
-                QLCNIC_DEFAULT_INTR_COALESCE_RX_TIME_US;
-        adapter->coal.normal.data.rx_packets =
-                QLCNIC_DEFAULT_INTR_COALESCE_RX_PACKETS;
-        adapter->coal.normal.data.tx_time_us =
-                QLCNIC_DEFAULT_INTR_COALESCE_TX_TIME_US;
-        adapter->coal.normal.data.tx_packets =
-                QLCNIC_DEFAULT_INTR_COALESCE_TX_PACKETS;
-}
 static int
 __qlcnic_up(struct qlcnic_adapter *adapter, struct net_device *netdev)
 {
@@ -1115,14 +1133,14 @@ __qlcnic_up(struct qlcnic_adapter *adapter, struct net_device *netdev)
                return -EIO;
        for (ring = 0; ring < adapter->max_rds_rings; ring++) {
-                rds_ring = &adapter->recv_ctx.rds_rings[ring];
+                rds_ring = &adapter->recv_ctx->rds_rings[ring];
-                qlcnic_post_rx_buffers(adapter, ring, rds_ring);
+                qlcnic_post_rx_buffers(adapter, rds_ring);
        }
        qlcnic_set_multi(netdev);
        qlcnic_fw_cmd_set_mtu(adapter, netdev->mtu);
-        adapter->ahw.linkup = 0;
+        adapter->ahw->linkup = 0;
        if (adapter->max_sds_rings > 1)
                qlcnic_config_rss(adapter, 1);
@@ -1230,8 +1248,6 @@ qlcnic_attach(struct qlcnic_adapter *adapter)
                goto err_out_free_hw;
        }
-        qlcnic_init_coalesce_defaults(adapter);
        qlcnic_create_sysfs_entries(adapter);
        adapter->is_up = QLCNIC_ADAPTER_UP_MAGIC;
@@ -1272,7 +1288,7 @@ void qlcnic_diag_free_res(struct net_device *netdev, int max_sds_rings)
        clear_bit(__QLCNIC_DEV_UP, &adapter->state);
        if (adapter->diag_test == QLCNIC_INTERRUPT_TEST) {
                for (ring = 0; ring < adapter->max_sds_rings; ring++) {
-                        sds_ring = &adapter->recv_ctx.sds_rings[ring];
+                        sds_ring = &adapter->recv_ctx->sds_rings[ring];
                        qlcnic_disable_int(sds_ring);
                }
        }
@@ -1293,6 +1309,48 @@ out:
        netif_device_attach(netdev);
 }
+static int qlcnic_alloc_adapter_resources(struct qlcnic_adapter *adapter)
+{
+        int err = 0;
+        adapter->ahw = kzalloc(sizeof(struct qlcnic_hardware_context),
+                                GFP_KERNEL);
+        if (!adapter->ahw) {
+                dev_err(&adapter->pdev->dev,
+                        "Failed to allocate recv ctx resources for adapter\n");
+                err = -ENOMEM;
+                goto err_out;
+        }
+        adapter->recv_ctx = kzalloc(sizeof(struct qlcnic_recv_context),
+                                GFP_KERNEL);
+        if (!adapter->recv_ctx) {
+                dev_err(&adapter->pdev->dev,
+                        "Failed to allocate recv ctx resources for adapter\n");
+                kfree(adapter->ahw);
+                adapter->ahw = NULL;
+                err = -ENOMEM;
+                goto err_out;
+        }
+        /* Initialize interrupt coalesce parameters */
+        adapter->ahw->coal.flag = QLCNIC_INTR_DEFAULT;
+        adapter->ahw->coal.rx_time_us = QLCNIC_DEFAULT_INTR_COALESCE_RX_TIME_US;
+        adapter->ahw->coal.rx_packets = QLCNIC_DEFAULT_INTR_COALESCE_RX_PACKETS;
+err_out:
+        return err;
+}
+static void qlcnic_free_adapter_resources(struct qlcnic_adapter *adapter)
+{
+        kfree(adapter->recv_ctx);
+        adapter->recv_ctx = NULL;
+        if (adapter->ahw->fw_dump.tmpl_hdr) {
+                vfree(adapter->ahw->fw_dump.tmpl_hdr);
+                adapter->ahw->fw_dump.tmpl_hdr = NULL;
+        }
+        kfree(adapter->ahw);
+        adapter->ahw = NULL;
+}
 int qlcnic_diag_alloc_res(struct net_device *netdev, int test)
 {
        struct qlcnic_adapter *adapter = netdev_priv(netdev);
@@ -1325,13 +1383,13 @@ int qlcnic_diag_alloc_res(struct net_device *netdev, int test)
        }
        for (ring = 0; ring < adapter->max_rds_rings; ring++) {
-                rds_ring = &adapter->recv_ctx.rds_rings[ring];
+                rds_ring = &adapter->recv_ctx->rds_rings[ring];
-                qlcnic_post_rx_buffers(adapter, ring, rds_ring);
+                qlcnic_post_rx_buffers(adapter, rds_ring);
        }
        if (adapter->diag_test == QLCNIC_INTERRUPT_TEST) {
                for (ring = 0; ring < adapter->max_sds_rings; ring++) {
-                        sds_ring = &adapter->recv_ctx.sds_rings[ring];
+                        sds_ring = &adapter->recv_ctx->sds_rings[ring];
                        qlcnic_enable_int(sds_ring);
                }
        }
@@ -1399,7 +1457,6 @@ qlcnic_setup_netdev(struct qlcnic_adapter *adapter,
        int err;
        struct pci_dev *pdev = adapter->pdev;
-        adapter->rx_csum = 1;
        adapter->mc_enabled = 0;
        adapter->max_mc_count = 38;
@@ -1410,26 +1467,24 @@ qlcnic_setup_netdev(struct qlcnic_adapter *adapter,
        SET_ETHTOOL_OPS(netdev, &qlcnic_ethtool_ops);
-        netdev->features |= (NETIF_F_SG | NETIF_F_IP_CSUM |
+        netdev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM |
-                NETIF_F_IPV6_CSUM | NETIF_F_GRO | NETIF_F_HW_VLAN_RX);
+                NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM;
-        netdev->vlan_features |= (NETIF_F_SG | NETIF_F_IP_CSUM |
-                NETIF_F_IPV6_CSUM);
-        if (adapter->capabilities & QLCNIC_FW_CAPABILITY_TSO) {
+        if (adapter->capabilities & QLCNIC_FW_CAPABILITY_TSO)
-                netdev->features |= (NETIF_F_TSO | NETIF_F_TSO6);
+                netdev->hw_features |= NETIF_F_TSO | NETIF_F_TSO6;
-                netdev->vlan_features |= (NETIF_F_TSO | NETIF_F_TSO6);
+        if (pci_using_dac)
-        }
+                netdev->hw_features |= NETIF_F_HIGHDMA;
-        if (pci_using_dac) {
+        netdev->vlan_features = netdev->hw_features;
-                netdev->features |= NETIF_F_HIGHDMA;
-                netdev->vlan_features |= NETIF_F_HIGHDMA;
-        }
        if (adapter->capabilities & QLCNIC_FW_CAPABILITY_FVLANTX)
-                netdev->features |= (NETIF_F_HW_VLAN_TX);
+                netdev->hw_features |= NETIF_F_HW_VLAN_TX;
        if (adapter->capabilities & QLCNIC_FW_CAPABILITY_HW_LRO)
-                netdev->features |= NETIF_F_LRO;
+                netdev->hw_features |= NETIF_F_LRO;
+        netdev->features |= netdev->hw_features |
+                NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER;
        netdev->irq = adapter->msix_entries[0].vector;
        netif_carrier_off(netdev);
@@ -1459,6 +1514,19 @@ static int qlcnic_set_dma_mask(struct pci_dev *pdev, u8 *pci_using_dac)
        return 0;
 }
+static int
+qlcnic_alloc_msix_entries(struct qlcnic_adapter *adapter, u16 count)
+{
+        adapter->msix_entries = kcalloc(count, sizeof(struct msix_entry),
+                                        GFP_KERNEL);
+        if (adapter->msix_entries)
+                return 0;
+        dev_err(&adapter->pdev->dev, "failed allocating msix_entries\n");
+        return -ENOMEM;
+}
 static int __devinit
 qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
@@ -1501,23 +1569,30 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        adapter = netdev_priv(netdev);
        adapter->netdev  = netdev;
        adapter->pdev    = pdev;
-        adapter->dev_rst_time = jiffies;
+        if (qlcnic_alloc_adapter_resources(adapter))
+                goto err_out_free_netdev;
+        adapter->dev_rst_time = jiffies;
        revision_id = pdev->revision;
-        adapter->ahw.revision_id = revision_id;
+        adapter->ahw->revision_id = revision_id;
-        rwlock_init(&adapter->ahw.crb_lock);
+        rwlock_init(&adapter->ahw->crb_lock);
-        mutex_init(&adapter->ahw.mem_lock);
+        mutex_init(&adapter->ahw->mem_lock);
        spin_lock_init(&adapter->tx_clean_lock);
        INIT_LIST_HEAD(&adapter->mac_list);
        err = qlcnic_setup_pci_map(adapter);
        if (err)
-                goto err_out_free_netdev;
+                goto err_out_free_hw;
        /* This will be reset for mezz cards  */
-        adapter->portnum = adapter->ahw.pci_func;
+        adapter->portnum = adapter->ahw->pci_func;
+        /* Get FW dump template and store it */
+        if (adapter->op_mode != QLCNIC_NON_PRIV_FUNC)
+                qlcnic_fw_cmd_get_minidump_temp(adapter);
        err = qlcnic_get_board_info(adapter);
        if (err) {
@@ -1545,11 +1620,15 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                pr_info("%s: %s Board Chip rev 0x%x\n",
                                module_name(THIS_MODULE),
-                                brd_name, adapter->ahw.revision_id);
+                                brd_name, adapter->ahw->revision_id);
        }
        qlcnic_clear_stats(adapter);
+        err = qlcnic_alloc_msix_entries(adapter, adapter->max_rx_ques);
+        if (err)
+                goto err_out_decr_ref;
        qlcnic_setup_intr(adapter);
        err = qlcnic_setup_netdev(adapter, netdev, pci_using_dac);
@@ -1560,7 +1639,7 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        qlcnic_schedule_work(adapter, qlcnic_fw_poll_work, FW_POLL_DELAY);
-        switch (adapter->ahw.port_type) {
+        switch (adapter->ahw->port_type) {
        case QLCNIC_GBE:
                dev_info(&adapter->pdev->dev, "%s: GbE port initialized\n",
                                adapter->netdev->name);
@@ -1578,6 +1657,7 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 err_out_disable_msi:
        qlcnic_teardown_intr(adapter);
+        kfree(adapter->msix_entries);
 err_out_decr_ref:
        qlcnic_clr_all_drv_state(adapter, 0);
@@ -1585,6 +1665,9 @@ err_out_decr_ref:
 err_out_iounmap:
        qlcnic_cleanup_pci_map(adapter);
+err_out_free_hw:
+        qlcnic_free_adapter_resources(adapter);
 err_out_free_netdev:
        free_netdev(netdev);
@@ -1626,6 +1709,7 @@ static void __devexit qlcnic_remove(struct pci_dev *pdev)
        qlcnic_free_lb_filters_mem(adapter);
        qlcnic_teardown_intr(adapter);
+        kfree(adapter->msix_entries);
        qlcnic_remove_diag_entries(adapter);
@@ -1638,6 +1722,7 @@ static void __devexit qlcnic_remove(struct pci_dev *pdev)
        pci_disable_device(pdev);
        pci_set_drvdata(pdev, NULL);
+        qlcnic_free_adapter_resources(adapter);
        free_netdev(netdev);
 }
 static int __qlcnic_shutdown(struct pci_dev *pdev)
@@ -1819,6 +1904,7 @@ static void qlcnic_change_filter(struct qlcnic_adapter *adapter,
        vlan_req->vlan_id = vlan_id;
        tx_ring->producer = get_next_index(producer, tx_ring->num_desc);
+        smp_mb();
 }
 #define QLCNIC_MAC_HASH(MAC)\
@@ -1879,58 +1965,122 @@ qlcnic_send_filter(struct qlcnic_adapter *adapter,
        spin_unlock(&adapter->mac_learn_lock);
 }
-static void
+static int
-qlcnic_tso_check(struct net_device *netdev,
+qlcnic_tx_pkt(struct qlcnic_adapter *adapter,
-                struct qlcnic_host_tx_ring *tx_ring,
                struct cmd_desc_type0 *first_desc,
                struct sk_buff *skb)
 {
-        u8 opcode = TX_ETHER_PKT;
+        u8 opcode = 0, hdr_len = 0;
-        __be16 protocol = skb->protocol;
+        u16 flags = 0, vlan_tci = 0;
-        u16 flags = 0;
+        int copied, offset, copy_len;
-        int copied, offset, copy_len, hdr_len = 0, tso = 0;
        struct cmd_desc_type0 *hwdesc;
        struct vlan_ethhdr *vh;
-        struct qlcnic_adapter *adapter = netdev_priv(netdev);
+        struct qlcnic_host_tx_ring *tx_ring = adapter->tx_ring;
+        u16 protocol = ntohs(skb->protocol);
        u32 producer = tx_ring->producer;
-        __le16 vlan_oob = first_desc->flags_opcode &
-                                cpu_to_le16(FLAGS_VLAN_OOB);
+        if (protocol == ETH_P_8021Q) {
+                vh = (struct vlan_ethhdr *)skb->data;
+                flags = FLAGS_VLAN_TAGGED;
+                vlan_tci = vh->h_vlan_TCI;
+        } else if (vlan_tx_tag_present(skb)) {
+                flags = FLAGS_VLAN_OOB;
+                vlan_tci = vlan_tx_tag_get(skb);
+        }
+        if (unlikely(adapter->pvid)) {
+                if (vlan_tci && !(adapter->flags & QLCNIC_TAGGING_ENABLED))
+                        return -EIO;
+                if (vlan_tci && (adapter->flags & QLCNIC_TAGGING_ENABLED))
+                        goto set_flags;
+                flags = FLAGS_VLAN_OOB;
+                vlan_tci = adapter->pvid;
+        }
+set_flags:
+        qlcnic_set_tx_vlan_tci(first_desc, vlan_tci);
+        qlcnic_set_tx_flags_opcode(first_desc, flags, opcode);
        if (*(skb->data) & BIT_0) {
                flags |= BIT_0;
                memcpy(&first_desc->eth_addr, skb->data, ETH_ALEN);
        }
+        opcode = TX_ETHER_PKT;
-        if ((netdev->features & (NETIF_F_TSO | NETIF_F_TSO6)) &&
+        if ((adapter->netdev->features & (NETIF_F_TSO | NETIF_F_TSO6)) &&
                        skb_shinfo(skb)->gso_size > 0) {
                hdr_len = skb_transport_offset(skb) + tcp_hdrlen(skb);
                first_desc->mss = cpu_to_le16(skb_shinfo(skb)->gso_size);
                first_desc->total_hdr_length = hdr_len;
-                if (vlan_oob) {
+                opcode = (protocol == ETH_P_IPV6) ? TX_TCP_LSO6 : TX_TCP_LSO;
+                /* For LSO, we need to copy the MAC/IP/TCP headers into
+                * the descriptor ring */
+                copied = 0;
+                offset = 2;
+                if (flags & FLAGS_VLAN_OOB) {
                        first_desc->total_hdr_length += VLAN_HLEN;
                        first_desc->tcp_hdr_offset = VLAN_HLEN;
                        first_desc->ip_hdr_offset = VLAN_HLEN;
                        /* Only in case of TSO on vlan device */
                        flags |= FLAGS_VLAN_TAGGED;
+                        /* Create a TSO vlan header template for firmware */
+                        hwdesc = &tx_ring->desc_head[producer];
+                        tx_ring->cmd_buf_arr[producer].skb = NULL;
+                        copy_len = min((int)sizeof(struct cmd_desc_type0) -
+                                offset, hdr_len + VLAN_HLEN);
+                        vh = (struct vlan_ethhdr *)((char *) hwdesc + 2);
+                        skb_copy_from_linear_data(skb, vh, 12);
+                        vh->h_vlan_proto = htons(ETH_P_8021Q);
+                        vh->h_vlan_TCI = htons(vlan_tci);
+                        skb_copy_from_linear_data_offset(skb, 12,
+                                (char *)vh + 16, copy_len - 16);
+                        copied = copy_len - VLAN_HLEN;
+                        offset = 0;
+                        producer = get_next_index(producer, tx_ring->num_desc);
                }
-                opcode = (protocol == cpu_to_be16(ETH_P_IPV6)) ?
+                while (copied < hdr_len) {
-                                TX_TCP_LSO6 : TX_TCP_LSO;
-                tso = 1;
+                        copy_len = min((int)sizeof(struct cmd_desc_type0) -
+                                offset, (hdr_len - copied));
+                        hwdesc = &tx_ring->desc_head[producer];
+                        tx_ring->cmd_buf_arr[producer].skb = NULL;
+                        skb_copy_from_linear_data_offset(skb, copied,
+                                 (char *) hwdesc + offset, copy_len);
+                        copied += copy_len;
+                        offset = 0;
+                        producer = get_next_index(producer, tx_ring->num_desc);
+                }
+                tx_ring->producer = producer;
+                smp_mb();
+                adapter->stats.lso_frames++;
        } else if (skb->ip_summed == CHECKSUM_PARTIAL) {
                u8 l4proto;
-                if (protocol == cpu_to_be16(ETH_P_IP)) {
+                if (protocol == ETH_P_IP) {
                        l4proto = ip_hdr(skb)->protocol;
                        if (l4proto == IPPROTO_TCP)
                                opcode = TX_TCP_PKT;
                        else if (l4proto == IPPROTO_UDP)
                                opcode = TX_UDP_PKT;
-                } else if (protocol == cpu_to_be16(ETH_P_IPV6)) {
+                } else if (protocol == ETH_P_IPV6) {
                        l4proto = ipv6_hdr(skb)->nexthdr;
                        if (l4proto == IPPROTO_TCP)
@@ -1939,63 +2089,11 @@ qlcnic_tso_check(struct net_device *netdev,
                                opcode = TX_UDPV6_PKT;
                }
        }
        first_desc->tcp_hdr_offset += skb_transport_offset(skb);
        first_desc->ip_hdr_offset += skb_network_offset(skb);
        qlcnic_set_tx_flags_opcode(first_desc, flags, opcode);
-        if (!tso)
+        return 0;
-                return;
-        /* For LSO, we need to copy the MAC/IP/TCP headers into
-         * the descriptor ring
-         */
-        copied = 0;
-        offset = 2;
-        if (vlan_oob) {
-                /* Create a TSO vlan header template for firmware */
-                hwdesc = &tx_ring->desc_head[producer];
-                tx_ring->cmd_buf_arr[producer].skb = NULL;
-                copy_len = min((int)sizeof(struct cmd_desc_type0) - offset,
-                                hdr_len + VLAN_HLEN);
-                vh = (struct vlan_ethhdr *)((char *)hwdesc + 2);
-                skb_copy_from_linear_data(skb, vh, 12);
-                vh->h_vlan_proto = htons(ETH_P_8021Q);
-                vh->h_vlan_TCI = (__be16)swab16((u16)first_desc->vlan_TCI);
-                skb_copy_from_linear_data_offset(skb, 12,
-                                (char *)vh + 16, copy_len - 16);
-                copied = copy_len - VLAN_HLEN;
-                offset = 0;
-                producer = get_next_index(producer, tx_ring->num_desc);
-        }
-        while (copied < hdr_len) {
-                copy_len = min((int)sizeof(struct cmd_desc_type0) - offset,
-                                (hdr_len - copied));
-                hwdesc = &tx_ring->desc_head[producer];
-                tx_ring->cmd_buf_arr[producer].skb = NULL;
-                skb_copy_from_linear_data_offset(skb, copied,
-                                 (char *)hwdesc + offset, copy_len);
-                copied += copy_len;
-                offset = 0;
-                producer = get_next_index(producer, tx_ring->num_desc);
-        }
-        tx_ring->producer = producer;
-        barrier();
-        adapter->stats.lso_frames++;
 }
 static int
@@ -2046,39 +2144,21 @@ out_err:
        return -ENOMEM;
 }
-static int
+static void
-qlcnic_check_tx_tagging(struct qlcnic_adapter *adapter,
+qlcnic_unmap_buffers(struct pci_dev *pdev, struct sk_buff *skb,
-                        struct sk_buff *skb,
+                        struct qlcnic_cmd_buffer *pbuf)
-                        struct cmd_desc_type0 *first_desc)
 {
-        u8 opcode = 0;
+        struct qlcnic_skb_frag *nf = &pbuf->frag_array[0];
-        u16 flags = 0;
+        int nr_frags = skb_shinfo(skb)->nr_frags;
-        __be16 protocol = skb->protocol;
+        int i;
-        struct vlan_ethhdr *vh;
-        if (protocol == cpu_to_be16(ETH_P_8021Q)) {
+        for (i = 0; i < nr_frags; i++) {
-                vh = (struct vlan_ethhdr *)skb->data;
+                nf = &pbuf->frag_array[i+1];
-                protocol = vh->h_vlan_encapsulated_proto;
+                pci_unmap_page(pdev, nf->dma, nf->length, PCI_DMA_TODEVICE);
-                flags = FLAGS_VLAN_TAGGED;
-                qlcnic_set_tx_vlan_tci(first_desc, ntohs(vh->h_vlan_TCI));
-        } else if (vlan_tx_tag_present(skb)) {
-                flags = FLAGS_VLAN_OOB;
-                qlcnic_set_tx_vlan_tci(first_desc, vlan_tx_tag_get(skb));
        }
-        if (unlikely(adapter->pvid)) {
-                if (first_desc->vlan_TCI &&
-                                !(adapter->flags & QLCNIC_TAGGING_ENABLED))
-                        return -EIO;
-                if (first_desc->vlan_TCI &&
-                                (adapter->flags & QLCNIC_TAGGING_ENABLED))
-                        goto set_flags;
-                flags = FLAGS_VLAN_OOB;
+        nf = &pbuf->frag_array[0];
-                qlcnic_set_tx_vlan_tci(first_desc, adapter->pvid);
+        pci_unmap_single(pdev, nf->dma, skb_headlen(skb), PCI_DMA_TODEVICE);
-        }
-set_flags:
-        qlcnic_set_tx_flags_opcode(first_desc, flags, opcode);
-        return 0;
 }
 static inline void
@@ -2103,7 +2183,7 @@ qlcnic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
        int i, k;
        u32 producer;
-        int frag_count, no_of_desc;
+        int frag_count;
        u32 num_txd = tx_ring->num_desc;
        if (!test_bit(__QLCNIC_DEV_UP, &adapter->state)) {
@@ -2133,12 +2213,8 @@ qlcnic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
                frag_count = 1 + skb_shinfo(skb)->nr_frags;
        }
-        /* 4 fragments per cmd des */
-        no_of_desc = (frag_count + 3) >> 2;
        if (unlikely(qlcnic_tx_avail(tx_ring) <= TX_STOP_THRESH)) {
                netif_stop_queue(netdev);
-                smp_mb();
                if (qlcnic_tx_avail(tx_ring) > TX_STOP_THRESH)
                        netif_start_queue(netdev);
                else {
@@ -2155,9 +2231,6 @@ qlcnic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
        first_desc = hwdesc = &tx_ring->desc_head[producer];
        qlcnic_clear_cmddesc((u64 *)hwdesc);
-        if (qlcnic_check_tx_tagging(adapter, skb, first_desc))
-                goto drop_packet;
        if (qlcnic_map_tx_skb(pdev, skb, pbuf)) {
                adapter->stats.tx_dma_map_error++;
                goto drop_packet;
@@ -2201,8 +2274,10 @@ qlcnic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
        }
        tx_ring->producer = get_next_index(producer, num_txd);
+        smp_mb();
-        qlcnic_tso_check(netdev, tx_ring, first_desc, skb);
+        if (unlikely(qlcnic_tx_pkt(adapter, first_desc, skb)))
+                goto unwind_buff;
        if (qlcnic_mac_learn)
                qlcnic_send_filter(adapter, tx_ring, first_desc, skb);
@@ -2214,6 +2289,8 @@ qlcnic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
        return NETDEV_TX_OK;
+unwind_buff:
+        qlcnic_unmap_buffers(pdev, skb, pbuf);
 drop_packet:
        adapter->stats.txdropped++;
        dev_kfree_skb_any(skb);
@@ -2260,16 +2337,16 @@ void qlcnic_advert_link_change(struct qlcnic_adapter *adapter, int linkup)
 {
        struct net_device *netdev = adapter->netdev;
-        if (adapter->ahw.linkup && !linkup) {
+        if (adapter->ahw->linkup && !linkup) {
                netdev_info(netdev, "NIC Link is down\n");
-                adapter->ahw.linkup = 0;
+                adapter->ahw->linkup = 0;
                if (netif_running(netdev)) {
                        netif_carrier_off(netdev);
                        netif_stop_queue(netdev);
                }
-        } else if (!adapter->ahw.linkup && linkup) {
+        } else if (!adapter->ahw->linkup && linkup) {
                netdev_info(netdev, "NIC Link is up\n");
-                adapter->ahw.linkup = 1;
+                adapter->ahw->linkup = 1;
                if (netif_running(netdev)) {
                        netif_carrier_on(netdev);
                        netif_wake_queue(netdev);
@@ -2505,7 +2582,7 @@ static void qlcnic_poll_controller(struct net_device *netdev)
        int ring;
        struct qlcnic_host_sds_ring *sds_ring;
        struct qlcnic_adapter *adapter = netdev_priv(netdev);
-        struct qlcnic_recv_context *recv_ctx = &adapter->recv_ctx;
+        struct qlcnic_recv_context *recv_ctx = adapter->recv_ctx;
        disable_irq(adapter->irq);
        for (ring = 0; ring < adapter->max_sds_rings; ring++) {
@@ -2756,6 +2833,8 @@ skip_ack_check:
                        set_bit(__QLCNIC_START_FW, &adapter->state);
                        QLCDB(adapter, DRV, "Restarting fw\n");
                        qlcnic_idc_debug_info(adapter, 0);
+                        QLCDB(adapter, DRV, "Take FW dump\n");
+                        qlcnic_dump_fw(adapter);
                }
                qlcnic_api_unlock(adapter);
@@ -2854,7 +2933,7 @@ qlcnic_set_npar_non_operational(struct qlcnic_adapter *adapter)
 }
 /*Transit to RESET state from READY state only */
-static void
+void
 qlcnic_dev_request_reset(struct qlcnic_adapter *adapter)
 {
        u32 state;
@@ -3266,6 +3345,56 @@ static struct device_attribute dev_attr_diag_mode = {
        .store = qlcnic_store_diag_mode,
 };
+int qlcnic_validate_max_rss(struct net_device *netdev, u8 max_hw, u8 val)
+{
+        if (!use_msi_x && !use_msi) {
+                netdev_info(netdev, "no msix or msi support, hence no rss\n");
+                return -EINVAL;
+        }
+        if ((val > max_hw) || (val <  2) || !is_power_of_2(val)) {
+                netdev_info(netdev, "rss_ring valid range [2 - %x] in "
+                        " powers of 2\n", max_hw);
+                return -EINVAL;
+        }
+        return 0;
+}
+int qlcnic_set_max_rss(struct qlcnic_adapter *adapter, u8 data)
+{
+        struct net_device *netdev = adapter->netdev;
+        int err = 0;
+        if (test_and_set_bit(__QLCNIC_RESETTING, &adapter->state))
+                return -EBUSY;
+        netif_device_detach(netdev);
+        if (netif_running(netdev))
+                __qlcnic_down(adapter, netdev);
+        qlcnic_detach(adapter);
+        qlcnic_teardown_intr(adapter);
+        if (qlcnic_enable_msix(adapter, data)) {
+                netdev_info(netdev, "failed setting max_rss; rss disabled\n");
+                qlcnic_enable_msi_legacy(adapter);
+        }
+        if (netif_running(netdev)) {
+                err = qlcnic_attach(adapter);
+                if (err)
+                        goto done;
+                err = __qlcnic_up(adapter, netdev);
+                if (err)
+                        goto done;
+                qlcnic_restore_indev_addr(netdev, NETDEV_UP);
+        }
+ done:
+        netif_device_attach(netdev);
+        clear_bit(__QLCNIC_RESETTING, &adapter->state);
+        return err;
+}
 static int
 qlcnic_sysfs_validate_crb(struct qlcnic_adapter *adapter,
                loff_t offset, size_t size)
@@ -3396,7 +3525,6 @@ qlcnic_sysfs_write_mem(struct file *filp, struct kobject *kobj,
        return size;
 }
 static struct bin_attribute bin_attr_crb = {
        .attr = {.name = "crb", .mode = (S_IRUGO | S_IWUSR)},
        .size = 0,
@@ -3515,7 +3643,7 @@ validate_esw_config(struct qlcnic_adapter *adapter,
        u8 pci_func;
        int i;
-        op_mode = readl(adapter->ahw.pci_base0 + QLCNIC_DRV_OP_MODE);
+        op_mode = readl(adapter->ahw->pci_base0 + QLCNIC_DRV_OP_MODE);
        for (i = 0; i < count; i++) {
                pci_func = esw_cfg[i].pci_func;
@@ -3581,13 +3709,13 @@ qlcnic_sysfs_write_esw_config(struct file *file, struct kobject *kobj,
                        if (qlcnic_config_switch_port(adapter, &esw_cfg[i]))
                                return QL_STATUS_INVALID_PARAM;
-                if (adapter->ahw.pci_func != esw_cfg[i].pci_func)
+                if (adapter->ahw->pci_func != esw_cfg[i].pci_func)
                        continue;
                op_mode = esw_cfg[i].op_mode;
                qlcnic_get_eswitch_port_config(adapter, &esw_cfg[i]);
                esw_cfg[i].op_mode = op_mode;
-                esw_cfg[i].pci_func = adapter->ahw.pci_func;
+                esw_cfg[i].pci_func = adapter->ahw->pci_func;
                switch (esw_cfg[i].op_mode) {
                case QLCNIC_PORT_DEFAULTS:
@@ -3968,14 +4096,14 @@ qlcnic_create_diag_entries(struct qlcnic_adapter *adapter)
                dev_info(dev, "failed to create crb sysfs entry\n");
        if (device_create_bin_file(dev, &bin_attr_mem))
                dev_info(dev, "failed to create mem sysfs entry\n");
+        if (device_create_bin_file(dev, &bin_attr_pci_config))
+                dev_info(dev, "failed to create pci config sysfs entry");
        if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
                return;
        if (device_create_bin_file(dev, &bin_attr_esw_config))
                dev_info(dev, "failed to create esw config sysfs entry");
        if (adapter->op_mode != QLCNIC_MGMT_FUNC)
                return;
-        if (device_create_bin_file(dev, &bin_attr_pci_config))
-                dev_info(dev, "failed to create pci config sysfs entry");
        if (device_create_bin_file(dev, &bin_attr_npar_config))
                dev_info(dev, "failed to create npar config sysfs entry");
        if (device_create_bin_file(dev, &bin_attr_pm_config))
@@ -3996,12 +4124,12 @@ qlcnic_remove_diag_entries(struct qlcnic_adapter *adapter)
        device_remove_file(dev, &dev_attr_diag_mode);
        device_remove_bin_file(dev, &bin_attr_crb);
        device_remove_bin_file(dev, &bin_attr_mem);
+        device_remove_bin_file(dev, &bin_attr_pci_config);
        if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
                return;
        device_remove_bin_file(dev, &bin_attr_esw_config);
        if (adapter->op_mode != QLCNIC_MGMT_FUNC)
                return;
-        device_remove_bin_file(dev, &bin_attr_pci_config);
        device_remove_bin_file(dev, &bin_attr_npar_config);
        device_remove_bin_file(dev, &bin_attr_pm_config);
        device_remove_bin_file(dev, &bin_attr_esw_stats);
@@ -4048,14 +4176,10 @@ qlcnic_restore_indev_addr(struct net_device *netdev, unsigned long event)
        qlcnic_config_indev_addr(adapter, netdev, event);
-        if (!adapter->vlgrp)
+        for_each_set_bit(vid, adapter->vlans, VLAN_N_VID) {
-                return;
+                dev = vlan_find_dev(netdev, vid);
-        for (vid = 0; vid < VLAN_N_VID; vid++) {
-                dev = vlan_group_get_device(adapter->vlgrp, vid);
                if (!dev)
                        continue;
                qlcnic_config_indev_addr(adapter, dev, event);
        }
 }
diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h
index 4757c59a07a2..d32850715f5c 100644
--- a/drivers/net/qlge/qlge.h
+++ b/drivers/net/qlge/qlge.h
@@ -2134,7 +2134,7 @@ struct ql_adapter {
        struct delayed_work mpi_idc_work;
        struct delayed_work mpi_core_to_log;
        struct completion ide_completion;
-        struct nic_operations *nic_ops;
+        const struct nic_operations *nic_ops;
        u16 device_id;
        struct timer_list timer;
        atomic_t lb_count;
diff --git a/drivers/net/qlge/qlge_ethtool.c b/drivers/net/qlge/qlge_ethtool.c
index 8149cc9de4ca..19b00fa0eaf0 100644
--- a/drivers/net/qlge/qlge_ethtool.c
+++ b/drivers/net/qlge/qlge_ethtool.c
@@ -356,7 +356,7 @@ static int ql_get_settings(struct net_device *ndev,
                ecmd->port = PORT_FIBRE;
        }
-        ecmd->speed = SPEED_10000;
+        ethtool_cmd_speed_set(ecmd, SPEED_10000);
        ecmd->duplex = DUPLEX_FULL;
        return 0;
@@ -412,31 +412,31 @@ static int ql_set_wol(struct net_device *ndev, struct ethtool_wolinfo *wol)
        return 0;
 }
-static int ql_phys_id(struct net_device *ndev, u32 data)
+static int ql_set_phys_id(struct net_device *ndev,
+                          enum ethtool_phys_id_state state)
 {
        struct ql_adapter *qdev = netdev_priv(ndev);
-        u32 led_reg, i;
-        int status;
-        /* Save the current LED settings */
-        status = ql_mb_get_led_cfg(qdev);
-        if (status)
-                return status;
-        led_reg = qdev->led_config;
-        /* Start blinking the led */
+        switch (state) {
-        if (!data || data > 300)
+        case ETHTOOL_ID_ACTIVE:
-                data = 300;
+                /* Save the current LED settings */
+                if (ql_mb_get_led_cfg(qdev))
+                        return -EIO;
-        for (i = 0; i < (data * 10); i++)
+                /* Start blinking */
                ql_mb_set_led_cfg(qdev, QL_LED_BLINK);
+                return 0;
-        /* Restore LED settings */
+        case ETHTOOL_ID_INACTIVE:
-        status = ql_mb_set_led_cfg(qdev, led_reg);
+                /* Restore LED settings */
-        if (status)
+                if (ql_mb_set_led_cfg(qdev, qdev->led_config))
-                return status;
+                        return -EIO;
+                return 0;
-        return 0;
+        default:
+                return -EINVAL;
+        }
 }
 static int ql_start_loopback(struct ql_adapter *qdev)
@@ -655,32 +655,6 @@ static int ql_set_pauseparam(struct net_device *netdev,
        return status;
 }
-static u32 ql_get_rx_csum(struct net_device *netdev)
-{
-        struct ql_adapter *qdev = netdev_priv(netdev);
-        return qdev->rx_csum;
-}
-static int ql_set_rx_csum(struct net_device *netdev, uint32_t data)
-{
-        struct ql_adapter *qdev = netdev_priv(netdev);
-        qdev->rx_csum = data;
-        return 0;
-}
-static int ql_set_tso(struct net_device *ndev, uint32_t data)
-{
-        if (data) {
-                ndev->features |= NETIF_F_TSO;
-                ndev->features |= NETIF_F_TSO6;
-        } else {
-                ndev->features &= ~NETIF_F_TSO;
-                ndev->features &= ~NETIF_F_TSO6;
-        }
-        return 0;
-}
 static u32 ql_get_msglevel(struct net_device *ndev)
 {
        struct ql_adapter *qdev = netdev_priv(ndev);
@@ -703,18 +677,10 @@ const struct ethtool_ops qlge_ethtool_ops = {
        .get_msglevel = ql_get_msglevel,
        .set_msglevel = ql_set_msglevel,
        .get_link = ethtool_op_get_link,
-        .phys_id                 = ql_phys_id,
+        .set_phys_id             = ql_set_phys_id,
        .self_test               = ql_self_test,
        .get_pauseparam          = ql_get_pauseparam,
        .set_pauseparam          = ql_set_pauseparam,
-        .get_rx_csum = ql_get_rx_csum,
-        .set_rx_csum = ql_set_rx_csum,
-        .get_tx_csum = ethtool_op_get_tx_csum,
-        .set_tx_csum = ethtool_op_set_tx_csum,
-        .get_sg = ethtool_op_get_sg,
-        .set_sg = ethtool_op_set_sg,
-        .get_tso = ethtool_op_get_tso,
-        .set_tso = ql_set_tso,
        .get_coalesce = ql_get_coalesce,
        .set_coalesce = ql_set_coalesce,
        .get_sset_count = ql_get_sset_count,
diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
index 5bb311945436..6c9d124cfc76 100644
--- a/drivers/net/qlge/qlge_main.c
+++ b/drivers/net/qlge/qlge_main.c
@@ -1571,7 +1571,7 @@ static void ql_process_mac_rx_page(struct ql_adapter *qdev,
        skb->protocol = eth_type_trans(skb, ndev);
        skb_checksum_none_assert(skb);
-        if (qdev->rx_csum &&
+        if ((ndev->features & NETIF_F_RXCSUM) &&
                !(ib_mac_rsp->flags1 & IB_MAC_CSUM_ERR_MASK)) {
                /* TCP frame. */
                if (ib_mac_rsp->flags2 & IB_MAC_IOCB_RSP_T) {
@@ -1684,7 +1684,7 @@ static void ql_process_mac_rx_skb(struct ql_adapter *qdev,
        /* If rx checksum is on, and there are no
         * csum or frame errors.
         */
-        if (qdev->rx_csum &&
+        if ((ndev->features & NETIF_F_RXCSUM) &&
                !(ib_mac_rsp->flags1 & IB_MAC_CSUM_ERR_MASK)) {
                /* TCP frame. */
                if (ib_mac_rsp->flags2 & IB_MAC_IOCB_RSP_T) {
@@ -2004,7 +2004,7 @@ static void ql_process_mac_split_rx_intr(struct ql_adapter *qdev,
        /* If rx checksum is on, and there are no
         * csum or frame errors.
         */
-        if (qdev->rx_csum &&
+        if ((ndev->features & NETIF_F_RXCSUM) &&
                !(ib_mac_rsp->flags1 & IB_MAC_CSUM_ERR_MASK)) {
                /* TCP frame. */
                if (ib_mac_rsp->flags2 & IB_MAC_IOCB_RSP_T) {
@@ -4412,12 +4412,12 @@ error:
        rtnl_unlock();
 }
-static struct nic_operations qla8012_nic_ops = {
+static const struct nic_operations qla8012_nic_ops = {
        .get_flash              = ql_get_8012_flash_params,
        .port_initialize        = ql_8012_port_initialize,
 };
-static struct nic_operations qla8000_nic_ops = {
+static const struct nic_operations qla8000_nic_ops = {
        .get_flash              = ql_get_8000_flash_params,
        .port_initialize        = ql_8000_port_initialize,
 };
@@ -4621,7 +4621,6 @@ static int __devinit ql_init_device(struct pci_dev *pdev,
        /*
         * Set up the operating parameters.
         */
-        qdev->rx_csum = 1;
        qdev->workqueue = create_singlethread_workqueue(ndev->name);
        INIT_DELAYED_WORK(&qdev->asic_reset_work, ql_asic_reset_work);
        INIT_DELAYED_WORK(&qdev->mpi_reset_work, ql_mpi_reset_work);
@@ -4695,15 +4694,11 @@ static int __devinit qlge_probe(struct pci_dev *pdev,
        qdev = netdev_priv(ndev);
        SET_NETDEV_DEV(ndev, &pdev->dev);
-        ndev->features = (0
+        ndev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM |
-                          | NETIF_F_IP_CSUM
+                NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN |
-                          | NETIF_F_SG
+                NETIF_F_HW_VLAN_TX | NETIF_F_RXCSUM;
-                          | NETIF_F_TSO
+        ndev->features = ndev->hw_features |
-                          | NETIF_F_TSO6
+                NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER;
-                          | NETIF_F_TSO_ECN
-                          | NETIF_F_HW_VLAN_TX
-                          | NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER);
-        ndev->features |= NETIF_F_GRO;
        if (test_bit(QL_DMA64, &qdev->flags))
                ndev->features |= NETIF_F_HIGHDMA;
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 397c36810a15..04f4e6086cd0 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -37,6 +37,8 @@
 #define FIRMWARE_8168D_1        "rtl_nic/rtl8168d-1.fw"
 #define FIRMWARE_8168D_2        "rtl_nic/rtl8168d-2.fw"
+#define FIRMWARE_8168E_1        "rtl_nic/rtl8168e-1.fw"
+#define FIRMWARE_8168E_2        "rtl_nic/rtl8168e-2.fw"
 #define FIRMWARE_8105E_1        "rtl_nic/rtl8105e-1.fw"
 #ifdef RTL8169_DEBUG
@@ -96,89 +98,125 @@ static const int multicast_filter_limit = 32;
 #define RTL_R32(reg)            readl (ioaddr + (reg))
 enum mac_version {
-        RTL_GIGA_MAC_NONE   = 0x00,
+        RTL_GIGA_MAC_VER_01 = 0,
-        RTL_GIGA_MAC_VER_01 = 0x01, // 8169
+        RTL_GIGA_MAC_VER_02,
-        RTL_GIGA_MAC_VER_02 = 0x02, // 8169S
+        RTL_GIGA_MAC_VER_03,
-        RTL_GIGA_MAC_VER_03 = 0x03, // 8110S
+        RTL_GIGA_MAC_VER_04,
-        RTL_GIGA_MAC_VER_04 = 0x04, // 8169SB
+        RTL_GIGA_MAC_VER_05,
-        RTL_GIGA_MAC_VER_05 = 0x05, // 8110SCd
+        RTL_GIGA_MAC_VER_06,
-        RTL_GIGA_MAC_VER_06 = 0x06, // 8110SCe
+        RTL_GIGA_MAC_VER_07,
-        RTL_GIGA_MAC_VER_07 = 0x07, // 8102e
+        RTL_GIGA_MAC_VER_08,
-        RTL_GIGA_MAC_VER_08 = 0x08, // 8102e
+        RTL_GIGA_MAC_VER_09,
-        RTL_GIGA_MAC_VER_09 = 0x09, // 8102e
+        RTL_GIGA_MAC_VER_10,
-        RTL_GIGA_MAC_VER_10 = 0x0a, // 8101e
+        RTL_GIGA_MAC_VER_11,
-        RTL_GIGA_MAC_VER_11 = 0x0b, // 8168Bb
+        RTL_GIGA_MAC_VER_12,
-        RTL_GIGA_MAC_VER_12 = 0x0c, // 8168Be
+        RTL_GIGA_MAC_VER_13,
-        RTL_GIGA_MAC_VER_13 = 0x0d, // 8101Eb
+        RTL_GIGA_MAC_VER_14,
-        RTL_GIGA_MAC_VER_14 = 0x0e, // 8101 ?
+        RTL_GIGA_MAC_VER_15,
-        RTL_GIGA_MAC_VER_15 = 0x0f, // 8101 ?
+        RTL_GIGA_MAC_VER_16,
-        RTL_GIGA_MAC_VER_16 = 0x11, // 8101Ec
+        RTL_GIGA_MAC_VER_17,
-        RTL_GIGA_MAC_VER_17 = 0x10, // 8168Bf
+        RTL_GIGA_MAC_VER_18,
-        RTL_GIGA_MAC_VER_18 = 0x12, // 8168CP
+        RTL_GIGA_MAC_VER_19,
-        RTL_GIGA_MAC_VER_19 = 0x13, // 8168C
+        RTL_GIGA_MAC_VER_20,
-        RTL_GIGA_MAC_VER_20 = 0x14, // 8168C
+        RTL_GIGA_MAC_VER_21,
-        RTL_GIGA_MAC_VER_21 = 0x15, // 8168C
+        RTL_GIGA_MAC_VER_22,
-        RTL_GIGA_MAC_VER_22 = 0x16, // 8168C
+        RTL_GIGA_MAC_VER_23,
-        RTL_GIGA_MAC_VER_23 = 0x17, // 8168CP
+        RTL_GIGA_MAC_VER_24,
-        RTL_GIGA_MAC_VER_24 = 0x18, // 8168CP
+        RTL_GIGA_MAC_VER_25,
-        RTL_GIGA_MAC_VER_25 = 0x19, // 8168D
+        RTL_GIGA_MAC_VER_26,
-        RTL_GIGA_MAC_VER_26 = 0x1a, // 8168D
+        RTL_GIGA_MAC_VER_27,
-        RTL_GIGA_MAC_VER_27 = 0x1b, // 8168DP
+        RTL_GIGA_MAC_VER_28,
-        RTL_GIGA_MAC_VER_28 = 0x1c, // 8168DP
+        RTL_GIGA_MAC_VER_29,
-        RTL_GIGA_MAC_VER_29 = 0x1d, // 8105E
+        RTL_GIGA_MAC_VER_30,
-        RTL_GIGA_MAC_VER_30 = 0x1e, // 8105E
+        RTL_GIGA_MAC_VER_31,
+        RTL_GIGA_MAC_VER_32,
+        RTL_GIGA_MAC_VER_33,
+        RTL_GIGA_MAC_NONE   = 0xff,
 };
-#define _R(NAME,MAC,MASK) \
+enum rtl_tx_desc_version {
-        { .name = NAME, .mac_version = MAC, .RxConfigMask = MASK }
+        RTL_TD_0        = 0,
+        RTL_TD_1        = 1,
+};
+#define _R(NAME,TD,FW) \
+        { .name = NAME, .txd_version = TD, .fw_name = FW }
 static const struct {
        const char *name;
-        u8 mac_version;
+        enum rtl_tx_desc_version txd_version;
-        u32 RxConfigMask;       /* Clears the bits supported by this chip */
-} rtl_chip_info[] = {
-        _R("RTL8169",           RTL_GIGA_MAC_VER_01, 0xff7e1880), // 8169
-        _R("RTL8169s",          RTL_GIGA_MAC_VER_02, 0xff7e1880), // 8169S
-        _R("RTL8110s",          RTL_GIGA_MAC_VER_03, 0xff7e1880), // 8110S
-        _R("RTL8169sb/8110sb",  RTL_GIGA_MAC_VER_04, 0xff7e1880), // 8169SB
-        _R("RTL8169sc/8110sc",  RTL_GIGA_MAC_VER_05, 0xff7e1880), // 8110SCd
-        _R("RTL8169sc/8110sc",  RTL_GIGA_MAC_VER_06, 0xff7e1880), // 8110SCe
-        _R("RTL8102e",          RTL_GIGA_MAC_VER_07, 0xff7e1880), // PCI-E
-        _R("RTL8102e",          RTL_GIGA_MAC_VER_08, 0xff7e1880), // PCI-E
-        _R("RTL8102e",          RTL_GIGA_MAC_VER_09, 0xff7e1880), // PCI-E
-        _R("RTL8101e",          RTL_GIGA_MAC_VER_10, 0xff7e1880), // PCI-E
-        _R("RTL8168b/8111b",    RTL_GIGA_MAC_VER_11, 0xff7e1880), // PCI-E
-        _R("RTL8168b/8111b",    RTL_GIGA_MAC_VER_12, 0xff7e1880), // PCI-E
-        _R("RTL8101e",          RTL_GIGA_MAC_VER_13, 0xff7e1880), // PCI-E 8139
-        _R("RTL8100e",          RTL_GIGA_MAC_VER_14, 0xff7e1880), // PCI-E 8139
-        _R("RTL8100e",          RTL_GIGA_MAC_VER_15, 0xff7e1880), // PCI-E 8139
-        _R("RTL8168b/8111b",    RTL_GIGA_MAC_VER_17, 0xff7e1880), // PCI-E
-        _R("RTL8101e",          RTL_GIGA_MAC_VER_16, 0xff7e1880), // PCI-E
-        _R("RTL8168cp/8111cp",  RTL_GIGA_MAC_VER_18, 0xff7e1880), // PCI-E
-        _R("RTL8168c/8111c",    RTL_GIGA_MAC_VER_19, 0xff7e1880), // PCI-E
-        _R("RTL8168c/8111c",    RTL_GIGA_MAC_VER_20, 0xff7e1880), // PCI-E
-        _R("RTL8168c/8111c",    RTL_GIGA_MAC_VER_21, 0xff7e1880), // PCI-E
-        _R("RTL8168c/8111c",    RTL_GIGA_MAC_VER_22, 0xff7e1880), // PCI-E
-        _R("RTL8168cp/8111cp",  RTL_GIGA_MAC_VER_23, 0xff7e1880), // PCI-E
-        _R("RTL8168cp/8111cp",  RTL_GIGA_MAC_VER_24, 0xff7e1880), // PCI-E
-        _R("RTL8168d/8111d",    RTL_GIGA_MAC_VER_25, 0xff7e1880), // PCI-E
-        _R("RTL8168d/8111d",    RTL_GIGA_MAC_VER_26, 0xff7e1880), // PCI-E
-        _R("RTL8168dp/8111dp",  RTL_GIGA_MAC_VER_27, 0xff7e1880), // PCI-E
-        _R("RTL8168dp/8111dp",  RTL_GIGA_MAC_VER_28, 0xff7e1880), // PCI-E
-        _R("RTL8105e",          RTL_GIGA_MAC_VER_29, 0xff7e1880), // PCI-E
-        _R("RTL8105e",          RTL_GIGA_MAC_VER_30, 0xff7e1880)  // PCI-E
-};
-#undef _R
-static const struct rtl_firmware_info {
-        int mac_version;
        const char *fw_name;
-} rtl_firmware_infos[] = {
+} rtl_chip_infos[] = {
-        { .mac_version = RTL_GIGA_MAC_VER_25, .fw_name = FIRMWARE_8168D_1 },
+        /* PCI devices. */
-        { .mac_version = RTL_GIGA_MAC_VER_26, .fw_name = FIRMWARE_8168D_2 },
+        [RTL_GIGA_MAC_VER_01] =
-        { .mac_version = RTL_GIGA_MAC_VER_29, .fw_name = FIRMWARE_8105E_1 },
+                _R("RTL8169",           RTL_TD_0, NULL),
-        { .mac_version = RTL_GIGA_MAC_VER_30, .fw_name = FIRMWARE_8105E_1 }
+        [RTL_GIGA_MAC_VER_02] =
+                _R("RTL8169s",          RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_03] =
+                _R("RTL8110s",          RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_04] =
+                _R("RTL8169sb/8110sb",  RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_05] =
+                _R("RTL8169sc/8110sc",  RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_06] =
+                _R("RTL8169sc/8110sc",  RTL_TD_0, NULL),
+        /* PCI-E devices. */
+        [RTL_GIGA_MAC_VER_07] =
+                _R("RTL8102e",          RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_08] =
+                _R("RTL8102e",          RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_09] =
+                _R("RTL8102e",          RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_10] =
+                _R("RTL8101e",          RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_11] =
+                _R("RTL8168b/8111b",    RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_12] =
+                _R("RTL8168b/8111b",    RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_13] =
+                _R("RTL8101e",          RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_14] =
+                _R("RTL8100e",          RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_15] =
+                _R("RTL8100e",          RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_16] =
+                _R("RTL8101e",          RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_17] =
+                _R("RTL8168b/8111b",    RTL_TD_0, NULL),
+        [RTL_GIGA_MAC_VER_18] =
+                _R("RTL8168cp/8111cp",  RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_19] =
+                _R("RTL8168c/8111c",    RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_20] =
+                _R("RTL8168c/8111c",    RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_21] =
+                _R("RTL8168c/8111c",    RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_22] =
+                _R("RTL8168c/8111c",    RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_23] =
+                _R("RTL8168cp/8111cp",  RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_24] =
+                _R("RTL8168cp/8111cp",  RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_25] =
+                _R("RTL8168d/8111d",    RTL_TD_1, FIRMWARE_8168D_1),
+        [RTL_GIGA_MAC_VER_26] =
+                _R("RTL8168d/8111d",    RTL_TD_1, FIRMWARE_8168D_2),
+        [RTL_GIGA_MAC_VER_27] =
+                _R("RTL8168dp/8111dp",  RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_28] =
+                _R("RTL8168dp/8111dp",  RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_29] =
+                _R("RTL8105e",          RTL_TD_1, FIRMWARE_8105E_1),
+        [RTL_GIGA_MAC_VER_30] =
+                _R("RTL8105e",          RTL_TD_1, FIRMWARE_8105E_1),
+        [RTL_GIGA_MAC_VER_31] =
+                _R("RTL8168dp/8111dp",  RTL_TD_1, NULL),
+        [RTL_GIGA_MAC_VER_32] =
+                _R("RTL8168e/8111e",    RTL_TD_1, FIRMWARE_8168E_1),
+        [RTL_GIGA_MAC_VER_33] =
+                _R("RTL8168e/8111e",    RTL_TD_1, FIRMWARE_8168E_2)
 };
+#undef _R
 enum cfg_version {
        RTL_CFG_0 = 0x00,
@@ -232,6 +270,9 @@ enum rtl_registers {
        IntrStatus      = 0x3e,
        TxConfig        = 0x40,
        RxConfig        = 0x44,
+#define RTL_RX_CONFIG_MASK              0xff7e1880u
        RxMissed        = 0x4c,
        Cfg9346         = 0x50,
        Config0         = 0x51,
@@ -325,7 +366,9 @@ enum rtl8168_registers {
 #define OCPAR_FLAG                      0x80000000
 #define OCPAR_GPHY_WRITE_CMD            0x8000f060
 #define OCPAR_GPHY_READ_CMD             0x0000f060
-        RDSAR1                  = 0xd0  /* 8168c only. Undocumented on 8168dp */
+        RDSAR1                  = 0xd0, /* 8168c only. Undocumented on 8168dp */
+        MISC                    = 0xf0, /* 8168e only. */
+#define TXPLA_RST                       (1 << 29)
 };
 enum rtl_register_content {
@@ -403,6 +446,7 @@ enum rtl_register_content {
        BWF             = (1 << 6),     /* Accept Broadcast wakeup frame */
        MWF             = (1 << 5),     /* Accept Multicast wakeup frame */
        UWF             = (1 << 4),     /* Accept Unicast wakeup frame */
+        Spi_en          = (1 << 3),
        LanWake         = (1 << 1),     /* LanWake enable/disable */
        PMEStatus       = (1 << 0),     /* PME status can be reset by PCI RST# */
@@ -451,21 +495,69 @@ enum rtl_register_content {
        CounterDump     = 0x8,
 };
-enum desc_status_bit {
+enum rtl_desc_bit {
+        /* First doubleword. */
        DescOwn         = (1 << 31), /* Descriptor is owned by NIC */
        RingEnd         = (1 << 30), /* End of descriptor ring */
        FirstFrag       = (1 << 29), /* First segment of a packet */
        LastFrag        = (1 << 28), /* Final segment of a packet */
+};
+/* Generic case. */
+enum rtl_tx_desc_bit {
+        /* First doubleword. */
+        TD_LSO          = (1 << 27),            /* Large Send Offload */
+#define TD_MSS_MAX                      0x07ffu /* MSS value */
-        /* Tx private */
+        /* Second doubleword. */
-        LargeSend       = (1 << 27), /* TCP Large Send Offload (TSO) */
+        TxVlanTag       = (1 << 17),            /* Add VLAN tag */
-        MSSShift        = 16,        /* MSS value position */
+};
-        MSSMask         = 0xfff,     /* MSS value + LargeSend bit: 12 bits */
-        IPCS            = (1 << 18), /* Calculate IP checksum */
+/* 8169, 8168b and 810x except 8102e. */
-        UDPCS           = (1 << 17), /* Calculate UDP/IP checksum */
+enum rtl_tx_desc_bit_0 {
-        TCPCS           = (1 << 16), /* Calculate TCP/IP checksum */
+        /* First doubleword. */
-        TxVlanTag       = (1 << 17), /* Add VLAN tag */
+#define TD0_MSS_SHIFT                   16      /* MSS position (11 bits) */
+        TD0_TCP_CS      = (1 << 16),            /* Calculate TCP/IP checksum */
+        TD0_UDP_CS      = (1 << 17),            /* Calculate UDP/IP checksum */
+        TD0_IP_CS       = (1 << 18),            /* Calculate IP checksum */
+};
+/* 8102e, 8168c and beyond. */
+enum rtl_tx_desc_bit_1 {
+        /* Second doubleword. */
+#define TD1_MSS_SHIFT                   18      /* MSS position (11 bits) */
+        TD1_IP_CS       = (1 << 29),            /* Calculate IP checksum */
+        TD1_TCP_CS      = (1 << 30),            /* Calculate TCP/IP checksum */
+        TD1_UDP_CS      = (1 << 31),            /* Calculate UDP/IP checksum */
+};
+static const struct rtl_tx_desc_info {
+        struct {
+                u32 udp;
+                u32 tcp;
+        } checksum;
+        u16 mss_shift;
+        u16 opts_offset;
+} tx_desc_info [] = {
+        [RTL_TD_0] = {
+                .checksum = {
+                        .udp    = TD0_IP_CS | TD0_UDP_CS,
+                        .tcp    = TD0_IP_CS | TD0_TCP_CS
+                },
+                .mss_shift      = TD0_MSS_SHIFT,
+                .opts_offset    = 0
+        },
+        [RTL_TD_1] = {
+                .checksum = {
+                        .udp    = TD1_IP_CS | TD1_UDP_CS,
+                        .tcp    = TD1_IP_CS | TD1_TCP_CS
+                },
+                .mss_shift      = TD1_MSS_SHIFT,
+                .opts_offset    = 1
+        }
+};
+enum rtl_rx_desc_bit {
        /* Rx private */
        PID1            = (1 << 18), /* Protocol ID bit 1/2 */
        PID0            = (1 << 17), /* Protocol ID bit 2/2 */
@@ -525,13 +617,13 @@ struct rtl8169_counters {
 struct rtl8169_private {
        void __iomem *mmio_addr;        /* memory map physical address */
-        struct pci_dev *pci_dev;        /* Index of PCI device */
+        struct pci_dev *pci_dev;
        struct net_device *dev;
        struct napi_struct napi;
-        spinlock_t lock;                /* spin lock flag */
+        spinlock_t lock;
        u32 msg_enable;
-        int chipset;
+        u16 txd_version;
-        int mac_version;
+        u16 mac_version;
        u32 cur_rx; /* Index into the Rx descriptor buffer of next Rx pkt. */
        u32 cur_tx; /* Index into the Tx descriptor buffer of next Rx pkt. */
        u32 dirty_rx;
@@ -547,7 +639,6 @@ struct rtl8169_private {
        u16 intr_event;
        u16 napi_event;
        u16 intr_mask;
-        int phy_1000_ctrl_reg;
        struct mdio_ops {
                void (*write)(void __iomem *, int, int);
@@ -588,6 +679,8 @@ MODULE_LICENSE("GPL");
 MODULE_VERSION(RTL8169_VERSION);
 MODULE_FIRMWARE(FIRMWARE_8168D_1);
 MODULE_FIRMWARE(FIRMWARE_8168D_2);
+MODULE_FIRMWARE(FIRMWARE_8168E_1);
+MODULE_FIRMWARE(FIRMWARE_8168E_2);
 MODULE_FIRMWARE(FIRMWARE_8105E_1);
 static int rtl8169_open(struct net_device *dev);
@@ -659,32 +752,49 @@ static void rtl8168_oob_notify(struct rtl8169_private *tp, u8 cmd)
 #define OOB_CMD_DRIVER_START    0x05
 #define OOB_CMD_DRIVER_STOP     0x06
+static u16 rtl8168_get_ocp_reg(struct rtl8169_private *tp)
+{
+        return (tp->mac_version == RTL_GIGA_MAC_VER_31) ? 0xb8 : 0x10;
+}
 static void rtl8168_driver_start(struct rtl8169_private *tp)
 {
+        u16 reg;
        int i;
        rtl8168_oob_notify(tp, OOB_CMD_DRIVER_START);
+        reg = rtl8168_get_ocp_reg(tp);
        for (i = 0; i < 10; i++) {
                msleep(10);
-                if (ocp_read(tp, 0x0f, 0x0010) & 0x00000800)
+                if (ocp_read(tp, 0x0f, reg) & 0x00000800)
                        break;
        }
 }
 static void rtl8168_driver_stop(struct rtl8169_private *tp)
 {
+        u16 reg;
        int i;
        rtl8168_oob_notify(tp, OOB_CMD_DRIVER_STOP);
+        reg = rtl8168_get_ocp_reg(tp);
        for (i = 0; i < 10; i++) {
                msleep(10);
-                if ((ocp_read(tp, 0x0f, 0x0010) & 0x00000800) == 0)
+                if ((ocp_read(tp, 0x0f, reg) & 0x00000800) == 0)
                        break;
        }
 }
+static int r8168dp_check_dash(struct rtl8169_private *tp)
+{
+        u16 reg = rtl8168_get_ocp_reg(tp);
+        return (ocp_read(tp, 0x0f, reg) & 0x00008000) ? 1 : 0;
+}
 static void r8169_mdio_write(void __iomem *ioaddr, int reg_addr, int value)
 {
@@ -983,9 +1093,8 @@ static void rtl8169_xmii_reset_enable(struct rtl8169_private *tp)
 }
 static void __rtl8169_check_link_status(struct net_device *dev,
-                                      struct rtl8169_private *tp,
+                                        struct rtl8169_private *tp,
-                                      void __iomem *ioaddr,
+                                        void __iomem *ioaddr, bool pm)
-                                      bool pm)
 {
        unsigned long flags;
@@ -1102,6 +1211,11 @@ static int rtl8169_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
        return 0;
 }
+static const char *rtl_lookup_firmware_name(struct rtl8169_private *tp)
+{
+        return rtl_chip_infos[tp->mac_version].fw_name;
+}
 static void rtl8169_get_drvinfo(struct net_device *dev,
                                struct ethtool_drvinfo *info)
 {
@@ -1110,6 +1224,8 @@ static void rtl8169_get_drvinfo(struct net_device *dev,
        strcpy(info->driver, MODULENAME);
        strcpy(info->version, RTL8169_VERSION);
        strcpy(info->bus_info, pci_name(tp->pci_dev));
+        strncpy(info->fw_version, IS_ERR_OR_NULL(tp->fw) ? "N/A" :
+                rtl_lookup_firmware_name(tp), sizeof(info->fw_version) - 1);
 }
 static int rtl8169_get_regs_len(struct net_device *dev)
@@ -1171,16 +1287,7 @@ static int rtl8169_set_speed_xmii(struct net_device *dev,
                giga_ctrl &= ~(ADVERTISE_1000FULL | ADVERTISE_1000HALF);
                /* The 8100e/8101e/8102e do Fast Ethernet only. */
-                if ((tp->mac_version != RTL_GIGA_MAC_VER_07) &&
+                if (tp->mii.supports_gmii) {
-                    (tp->mac_version != RTL_GIGA_MAC_VER_08) &&
-                    (tp->mac_version != RTL_GIGA_MAC_VER_09) &&
-                    (tp->mac_version != RTL_GIGA_MAC_VER_10) &&
-                    (tp->mac_version != RTL_GIGA_MAC_VER_13) &&
-                    (tp->mac_version != RTL_GIGA_MAC_VER_14) &&
-                    (tp->mac_version != RTL_GIGA_MAC_VER_15) &&
-                    (tp->mac_version != RTL_GIGA_MAC_VER_16) &&
-                    (tp->mac_version != RTL_GIGA_MAC_VER_29) &&
-                    (tp->mac_version != RTL_GIGA_MAC_VER_30)) {
                        if (adv & ADVERTISED_1000baseT_Half)
                                giga_ctrl |= ADVERTISE_1000HALF;
                        if (adv & ADVERTISED_1000baseT_Full)
@@ -1210,12 +1317,10 @@ static int rtl8169_set_speed_xmii(struct net_device *dev,
                        bmcr |= BMCR_FULLDPLX;
        }
-        tp->phy_1000_ctrl_reg = giga_ctrl;
        rtl_writephy(tp, MII_BMCR, bmcr);
-        if ((tp->mac_version == RTL_GIGA_MAC_VER_02) ||
+        if (tp->mac_version == RTL_GIGA_MAC_VER_02 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_03)) {
+            tp->mac_version == RTL_GIGA_MAC_VER_03) {
                if ((speed == SPEED_100) && (autoneg != AUTONEG_ENABLE)) {
                        rtl_writephy(tp, 0x17, 0x2138);
                        rtl_writephy(tp, 0x0e, 0x0260);
@@ -1237,10 +1342,14 @@ static int rtl8169_set_speed(struct net_device *dev,
        int ret;
        ret = tp->set_speed(dev, autoneg, speed, duplex, advertising);
+        if (ret < 0)
+                goto out;
-        if (netif_running(dev) && (tp->phy_1000_ctrl_reg & ADVERTISE_1000FULL))
+        if (netif_running(dev) && (autoneg == AUTONEG_ENABLE) &&
+            (advertising & ADVERTISED_1000baseT_Full)) {
                mod_timer(&tp->timer, jiffies + RTL8169_PHY_TIMEOUT);
+        }
+out:
        return ret;
 }
@@ -1250,22 +1359,25 @@ static int rtl8169_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        unsigned long flags;
        int ret;
+        del_timer_sync(&tp->timer);
        spin_lock_irqsave(&tp->lock, flags);
-        ret = rtl8169_set_speed(dev,
+        ret = rtl8169_set_speed(dev, cmd->autoneg, ethtool_cmd_speed(cmd),
-                cmd->autoneg, cmd->speed, cmd->duplex, cmd->advertising);
+                                cmd->duplex, cmd->advertising);
        spin_unlock_irqrestore(&tp->lock, flags);
        return ret;
 }
-static u32 rtl8169_get_rx_csum(struct net_device *dev)
+static u32 rtl8169_fix_features(struct net_device *dev, u32 features)
 {
-        struct rtl8169_private *tp = netdev_priv(dev);
+        if (dev->mtu > TD_MSS_MAX)
+                features &= ~NETIF_F_ALL_TSO;
-        return tp->cp_cmd & RxChkSum;
+        return features;
 }
-static int rtl8169_set_rx_csum(struct net_device *dev, u32 data)
+static int rtl8169_set_features(struct net_device *dev, u32 features)
 {
        struct rtl8169_private *tp = netdev_priv(dev);
        void __iomem *ioaddr = tp->mmio_addr;
@@ -1273,11 +1385,16 @@ static int rtl8169_set_rx_csum(struct net_device *dev, u32 data)
        spin_lock_irqsave(&tp->lock, flags);
-        if (data)
+        if (features & NETIF_F_RXCSUM)
                tp->cp_cmd |= RxChkSum;
        else
                tp->cp_cmd &= ~RxChkSum;
+        if (dev->features & NETIF_F_HW_VLAN_RX)
+                tp->cp_cmd |= RxVlan;
+        else
+                tp->cp_cmd &= ~RxVlan;
        RTL_W16(CPlusCmd, tp->cp_cmd);
        RTL_R16(CPlusCmd);
@@ -1293,27 +1410,6 @@ static inline u32 rtl8169_tx_vlan_tag(struct rtl8169_private *tp,
                TxVlanTag | swab16(vlan_tx_tag_get(skb)) : 0x00;
 }
-#define NETIF_F_HW_VLAN_TX_RX   (NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX)
-static void rtl8169_vlan_mode(struct net_device *dev)
-{
-        struct rtl8169_private *tp = netdev_priv(dev);
-        void __iomem *ioaddr = tp->mmio_addr;
-        unsigned long flags;
-        spin_lock_irqsave(&tp->lock, flags);
-        if (dev->features & NETIF_F_HW_VLAN_RX)
-                tp->cp_cmd |= RxVlan;
-        else
-                tp->cp_cmd &= ~RxVlan;
-        RTL_W16(CPlusCmd, tp->cp_cmd);
-        /* PCI commit */
-        RTL_R16(CPlusCmd);
-        spin_unlock_irqrestore(&tp->lock, flags);
-        dev->vlan_features = dev->features &~ NETIF_F_HW_VLAN_TX_RX;
-}
 static void rtl8169_rx_vlan_tag(struct RxDesc *desc, struct sk_buff *skb)
 {
        u32 opts2 = le32_to_cpu(desc->opts2);
@@ -1339,7 +1435,7 @@ static int rtl8169_gset_tbi(struct net_device *dev, struct ethtool_cmd *cmd)
        cmd->advertising = (status & TBINwEnable) ?  ADVERTISED_Autoneg : 0;
        cmd->autoneg = !!(status & TBINwEnable);
-        cmd->speed = SPEED_1000;
+        ethtool_cmd_speed_set(cmd, SPEED_1000);
        cmd->duplex = DUPLEX_FULL; /* Always set */
        return 0;
@@ -1424,11 +1520,11 @@ static void rtl8169_update_counters(struct net_device *dev)
 {
        struct rtl8169_private *tp = netdev_priv(dev);
        void __iomem *ioaddr = tp->mmio_addr;
+        struct device *d = &tp->pci_dev->dev;
        struct rtl8169_counters *counters;
        dma_addr_t paddr;
        u32 cmd;
        int wait = 1000;
-        struct device *d = &tp->pci_dev->dev;
        /*
         * Some chips are unable to dump tally counters when the receiver
@@ -1448,7 +1544,6 @@ static void rtl8169_update_counters(struct net_device *dev)
        while (wait--) {
                if ((RTL_R32(CounterAddrLow) & CounterDump) == 0) {
-                        /* copy updated counters */
                        memcpy(&tp->counters, counters, sizeof(*counters));
                        break;
                }
@@ -1494,28 +1589,6 @@ static void rtl8169_get_strings(struct net_device *dev, u32 stringset, u8 *data)
        }
 }
-static int rtl8169_set_flags(struct net_device *dev, u32 data)
-{
-        struct rtl8169_private *tp = netdev_priv(dev);
-        unsigned long old_feat = dev->features;
-        int rc;
-        if ((tp->mac_version == RTL_GIGA_MAC_VER_05) &&
-            !(data & ETH_FLAG_RXVLAN)) {
-                netif_info(tp, drv, dev, "8110SCd requires hardware Rx VLAN\n");
-                return -EINVAL;
-        }
-        rc = ethtool_op_set_flags(dev, data, ETH_FLAG_TXVLAN | ETH_FLAG_RXVLAN);
-        if (rc)
-                return rc;
-        if ((old_feat ^ dev->features) & NETIF_F_HW_VLAN_RX)
-                rtl8169_vlan_mode(dev);
-        return 0;
-}
 static const struct ethtool_ops rtl8169_ethtool_ops = {
        .get_drvinfo            = rtl8169_get_drvinfo,
        .get_regs_len           = rtl8169_get_regs_len,
@@ -1524,24 +1597,18 @@ static const struct ethtool_ops rtl8169_ethtool_ops = {
        .set_settings           = rtl8169_set_settings,
        .get_msglevel           = rtl8169_get_msglevel,
        .set_msglevel           = rtl8169_set_msglevel,
-        .get_rx_csum            = rtl8169_get_rx_csum,
-        .set_rx_csum            = rtl8169_set_rx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_csum,
-        .set_sg                 = ethtool_op_set_sg,
-        .set_tso                = ethtool_op_set_tso,
        .get_regs               = rtl8169_get_regs,
        .get_wol                = rtl8169_get_wol,
        .set_wol                = rtl8169_set_wol,
        .get_strings            = rtl8169_get_strings,
        .get_sset_count         = rtl8169_get_sset_count,
        .get_ethtool_stats      = rtl8169_get_ethtool_stats,
-        .set_flags              = rtl8169_set_flags,
-        .get_flags              = ethtool_op_get_flags,
 };
 static void rtl8169_get_mac_version(struct rtl8169_private *tp,
-                                    void __iomem *ioaddr)
+                                    struct net_device *dev, u8 default_version)
 {
+        void __iomem *ioaddr = tp->mmio_addr;
        /*
         * The driver currently handles the 8168Bf and the 8168Be identically
         * but they can be identified more specifically through the test below
@@ -1558,6 +1625,11 @@ static void rtl8169_get_mac_version(struct rtl8169_private *tp,
                u32 val;
                int mac_version;
        } mac_info[] = {
+                /* 8168E family. */
+                { 0x7cf00000, 0x2c200000,       RTL_GIGA_MAC_VER_33 },
+                { 0x7cf00000, 0x2c100000,       RTL_GIGA_MAC_VER_32 },
+                { 0x7c800000, 0x2c000000,       RTL_GIGA_MAC_VER_33 },
                /* 8168D family. */
                { 0x7cf00000, 0x28300000,       RTL_GIGA_MAC_VER_26 },
                { 0x7cf00000, 0x28100000,       RTL_GIGA_MAC_VER_25 },
@@ -1566,6 +1638,7 @@ static void rtl8169_get_mac_version(struct rtl8169_private *tp,
                /* 8168DP family. */
                { 0x7cf00000, 0x28800000,       RTL_GIGA_MAC_VER_27 },
                { 0x7cf00000, 0x28a00000,       RTL_GIGA_MAC_VER_28 },
+                { 0x7cf00000, 0x28b00000,       RTL_GIGA_MAC_VER_31 },
                /* 8168C family. */
                { 0x7cf00000, 0x3cb00000,       RTL_GIGA_MAC_VER_24 },
@@ -1585,6 +1658,7 @@ static void rtl8169_get_mac_version(struct rtl8169_private *tp,
                { 0x7c800000, 0x30000000,       RTL_GIGA_MAC_VER_11 },
                /* 8101 family. */
+                { 0x7cf00000, 0x40b00000,       RTL_GIGA_MAC_VER_30 },
                { 0x7cf00000, 0x40a00000,       RTL_GIGA_MAC_VER_30 },
                { 0x7cf00000, 0x40900000,       RTL_GIGA_MAC_VER_29 },
                { 0x7c800000, 0x40800000,       RTL_GIGA_MAC_VER_30 },
@@ -1621,6 +1695,12 @@ static void rtl8169_get_mac_version(struct rtl8169_private *tp,
        while ((reg & p->mask) != p->val)
                p++;
        tp->mac_version = p->mac_version;
+        if (tp->mac_version == RTL_GIGA_MAC_NONE) {
+                netif_notice(tp, probe, dev,
+                             "unknown MAC, using family default\n");
+                tp->mac_version = default_version;
+        }
 }
 static void rtl8169_print_mac_version(struct rtl8169_private *tp)
@@ -1690,14 +1770,14 @@ rtl_phy_write_fw(struct rtl8169_private *tp, const struct firmware *fw)
                case PHY_BJMPN:
                        if (regno > index) {
                                netif_err(tp, probe, tp->dev,
-                                        "Out of range of firmware\n");
+                                          "Out of range of firmware\n");
                                return;
                        }
                        break;
                case PHY_READCOUNT_EQ_SKIP:
                        if (index + 2 >= fw_size) {
                                netif_err(tp, probe, tp->dev,
-                                        "Out of range of firmware\n");
+                                          "Out of range of firmware\n");
                                return;
                        }
                        break;
@@ -1706,7 +1786,7 @@ rtl_phy_write_fw(struct rtl8169_private *tp, const struct firmware *fw)
                case PHY_SKIPN:
                        if (index + 1 + regno >= fw_size) {
                                netif_err(tp, probe, tp->dev,
-                                        "Out of range of firmware\n");
+                                          "Out of range of firmware\n");
                                return;
                        }
                        break;
@@ -1762,10 +1842,7 @@ rtl_phy_write_fw(struct rtl8169_private *tp, const struct firmware *fw)
                        index++;
                        break;
                case PHY_READCOUNT_EQ_SKIP:
-                        if (count == data)
+                        index += (count == data) ? 2 : 1;
-                                index += 2;
-                        else
-                                index += 1;
                        break;
                case PHY_COMP_EQ_SKIPN:
                        if (predata == data)
@@ -2176,7 +2253,7 @@ static void rtl8168d_1_hw_phy_config(struct rtl8169_private *tp)
                /*
                 * Tx Error Issue
-                 * enhance line driver power
+                 * Enhance line driver power
                 */
                { 0x1f, 0x0002 },
                { 0x06, 0x5561 },
@@ -2288,7 +2365,7 @@ static void rtl8168d_2_hw_phy_config(struct rtl8169_private *tp)
                /*
                 * Tx Error Issue
-                 * enhance line driver power
+                 * Enhance line driver power
                 */
                { 0x1f, 0x0002 },
                { 0x06, 0x5561 },
@@ -2444,6 +2521,79 @@ static void rtl8168d_4_hw_phy_config(struct rtl8169_private *tp)
        rtl_patchphy(tp, 0x0d, 1 << 5);
 }
+static void rtl8168e_hw_phy_config(struct rtl8169_private *tp)
+{
+        static const struct phy_reg phy_reg_init[] = {
+                /* Enable Delay cap */
+                { 0x1f, 0x0005 },
+                { 0x05, 0x8b80 },
+                { 0x06, 0xc896 },
+                { 0x1f, 0x0000 },
+                /* Channel estimation fine tune */
+                { 0x1f, 0x0001 },
+                { 0x0b, 0x6c20 },
+                { 0x07, 0x2872 },
+                { 0x1c, 0xefff },
+                { 0x1f, 0x0003 },
+                { 0x14, 0x6420 },
+                { 0x1f, 0x0000 },
+                /* Update PFM & 10M TX idle timer */
+                { 0x1f, 0x0007 },
+                { 0x1e, 0x002f },
+                { 0x15, 0x1919 },
+                { 0x1f, 0x0000 },
+                { 0x1f, 0x0007 },
+                { 0x1e, 0x00ac },
+                { 0x18, 0x0006 },
+                { 0x1f, 0x0000 }
+        };
+        rtl_apply_firmware(tp);
+        rtl_writephy_batch(tp, phy_reg_init, ARRAY_SIZE(phy_reg_init));
+        /* DCO enable for 10M IDLE Power */
+        rtl_writephy(tp, 0x1f, 0x0007);
+        rtl_writephy(tp, 0x1e, 0x0023);
+        rtl_w1w0_phy(tp, 0x17, 0x0006, 0x0000);
+        rtl_writephy(tp, 0x1f, 0x0000);
+        /* For impedance matching */
+        rtl_writephy(tp, 0x1f, 0x0002);
+        rtl_w1w0_phy(tp, 0x08, 0x8000, 0x7f00);
+        rtl_writephy(tp, 0x1f, 0x0000);
+        /* PHY auto speed down */
+        rtl_writephy(tp, 0x1f, 0x0007);
+        rtl_writephy(tp, 0x1e, 0x002d);
+        rtl_w1w0_phy(tp, 0x18, 0x0050, 0x0000);
+        rtl_writephy(tp, 0x1f, 0x0000);
+        rtl_w1w0_phy(tp, 0x14, 0x8000, 0x0000);
+        rtl_writephy(tp, 0x1f, 0x0005);
+        rtl_writephy(tp, 0x05, 0x8b86);
+        rtl_w1w0_phy(tp, 0x06, 0x0001, 0x0000);
+        rtl_writephy(tp, 0x1f, 0x0000);
+        rtl_writephy(tp, 0x1f, 0x0005);
+        rtl_writephy(tp, 0x05, 0x8b85);
+        rtl_w1w0_phy(tp, 0x06, 0x0000, 0x2000);
+        rtl_writephy(tp, 0x1f, 0x0007);
+        rtl_writephy(tp, 0x1e, 0x0020);
+        rtl_w1w0_phy(tp, 0x15, 0x0000, 0x1100);
+        rtl_writephy(tp, 0x1f, 0x0006);
+        rtl_writephy(tp, 0x00, 0x5a00);
+        rtl_writephy(tp, 0x1f, 0x0000);
+        rtl_writephy(tp, 0x0d, 0x0007);
+        rtl_writephy(tp, 0x0e, 0x003c);
+        rtl_writephy(tp, 0x0d, 0x4007);
+        rtl_writephy(tp, 0x0e, 0x0000);
+        rtl_writephy(tp, 0x0d, 0x0000);
+}
 static void rtl8102e_hw_phy_config(struct rtl8169_private *tp)
 {
        static const struct phy_reg phy_reg_init[] = {
@@ -2558,6 +2708,13 @@ static void rtl_hw_phy_config(struct net_device *dev)
        case RTL_GIGA_MAC_VER_30:
                rtl8105e_hw_phy_config(tp);
                break;
+        case RTL_GIGA_MAC_VER_31:
+                /* None. */
+                break;
+        case RTL_GIGA_MAC_VER_32:
+        case RTL_GIGA_MAC_VER_33:
+                rtl8168e_hw_phy_config(tp);
+                break;
        default:
                break;
@@ -2574,9 +2731,6 @@ static void rtl8169_phy_timer(unsigned long __opaque)
        assert(tp->mac_version > RTL_GIGA_MAC_VER_01);
-        if (!(tp->phy_1000_ctrl_reg & ADVERTISE_1000FULL))
-                return;
        spin_lock_irq(&tp->lock);
        if (tp->phy_reset_pending(tp)) {
@@ -2601,28 +2755,6 @@ out_unlock:
        spin_unlock_irq(&tp->lock);
 }
-static inline void rtl8169_delete_timer(struct net_device *dev)
-{
-        struct rtl8169_private *tp = netdev_priv(dev);
-        struct timer_list *timer = &tp->timer;
-        if (tp->mac_version <= RTL_GIGA_MAC_VER_01)
-                return;
-        del_timer_sync(timer);
-}
-static inline void rtl8169_request_timer(struct net_device *dev)
-{
-        struct rtl8169_private *tp = netdev_priv(dev);
-        struct timer_list *timer = &tp->timer;
-        if (tp->mac_version <= RTL_GIGA_MAC_VER_01)
-                return;
-        mod_timer(timer, jiffies + RTL8169_PHY_TIMEOUT);
-}
 #ifdef CONFIG_NET_POLL_CONTROLLER
 /*
 * Polling 'interrupt' - used by things like netconsole to send skbs
@@ -2690,11 +2822,11 @@ static void rtl8169_init_phy(struct net_device *dev, struct rtl8169_private *tp)
        rtl8169_phy_reset(dev, tp);
        rtl8169_set_speed(dev, AUTONEG_ENABLE, SPEED_1000, DUPLEX_FULL,
-                ADVERTISED_10baseT_Half | ADVERTISED_10baseT_Full |
+                          ADVERTISED_10baseT_Half | ADVERTISED_10baseT_Full |
-                ADVERTISED_100baseT_Half | ADVERTISED_100baseT_Full |
+                          ADVERTISED_100baseT_Half | ADVERTISED_100baseT_Full |
-                (tp->mii.supports_gmii ?
+                          (tp->mii.supports_gmii ?
-                        ADVERTISED_1000baseT_Half |
+                           ADVERTISED_1000baseT_Half |
-                        ADVERTISED_1000baseT_Full : 0));
+                           ADVERTISED_1000baseT_Full : 0));
        if (RTL_R8(PHYstatus) & TBI_Enable)
                netif_info(tp, link, dev, "TBI auto-negotiating\n");
@@ -2747,7 +2879,8 @@ static int rtl8169_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
        return netif_running(dev) ? tp->do_ioctl(tp, data, cmd) : -ENODEV;
 }
-static int rtl_xmii_ioctl(struct rtl8169_private *tp, struct mii_ioctl_data *data, int cmd)
+static int rtl_xmii_ioctl(struct rtl8169_private *tp,
+                          struct mii_ioctl_data *data, int cmd)
 {
        switch (cmd) {
        case SIOCGMIIPHY:
@@ -2847,6 +2980,8 @@ static const struct net_device_ops rtl8169_netdev_ops = {
        .ndo_tx_timeout         = rtl8169_tx_timeout,
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_change_mtu         = rtl8169_change_mtu,
+        .ndo_fix_features       = rtl8169_fix_features,
+        .ndo_set_features       = rtl8169_set_features,
        .ndo_set_mac_address    = rtl_set_mac_address,
        .ndo_do_ioctl           = rtl8169_ioctl,
        .ndo_set_multicast_list = rtl_set_rx_mode,
@@ -2866,6 +3001,7 @@ static void __devinit rtl_init_mdio_ops(struct rtl8169_private *tp)
                ops->read       = r8168dp_1_mdio_read;
                break;
        case RTL_GIGA_MAC_VER_28:
+        case RTL_GIGA_MAC_VER_31:
                ops->write      = r8168dp_2_mdio_write;
                ops->read       = r8168dp_2_mdio_read;
                break;
@@ -2907,33 +3043,82 @@ static void r810x_pll_power_up(struct rtl8169_private *tp)
 static void r8168_phy_power_up(struct rtl8169_private *tp)
 {
        rtl_writephy(tp, 0x1f, 0x0000);
-        rtl_writephy(tp, 0x0e, 0x0000);
+        switch (tp->mac_version) {
+        case RTL_GIGA_MAC_VER_11:
+        case RTL_GIGA_MAC_VER_12:
+        case RTL_GIGA_MAC_VER_17:
+        case RTL_GIGA_MAC_VER_18:
+        case RTL_GIGA_MAC_VER_19:
+        case RTL_GIGA_MAC_VER_20:
+        case RTL_GIGA_MAC_VER_21:
+        case RTL_GIGA_MAC_VER_22:
+        case RTL_GIGA_MAC_VER_23:
+        case RTL_GIGA_MAC_VER_24:
+        case RTL_GIGA_MAC_VER_25:
+        case RTL_GIGA_MAC_VER_26:
+        case RTL_GIGA_MAC_VER_27:
+        case RTL_GIGA_MAC_VER_28:
+        case RTL_GIGA_MAC_VER_31:
+                rtl_writephy(tp, 0x0e, 0x0000);
+                break;
+        default:
+                break;
+        }
        rtl_writephy(tp, MII_BMCR, BMCR_ANENABLE);
 }
 static void r8168_phy_power_down(struct rtl8169_private *tp)
 {
        rtl_writephy(tp, 0x1f, 0x0000);
-        rtl_writephy(tp, 0x0e, 0x0200);
+        switch (tp->mac_version) {
-        rtl_writephy(tp, MII_BMCR, BMCR_PDOWN);
+        case RTL_GIGA_MAC_VER_32:
+        case RTL_GIGA_MAC_VER_33:
+                rtl_writephy(tp, MII_BMCR, BMCR_ANENABLE | BMCR_PDOWN);
+                break;
+        case RTL_GIGA_MAC_VER_11:
+        case RTL_GIGA_MAC_VER_12:
+        case RTL_GIGA_MAC_VER_17:
+        case RTL_GIGA_MAC_VER_18:
+        case RTL_GIGA_MAC_VER_19:
+        case RTL_GIGA_MAC_VER_20:
+        case RTL_GIGA_MAC_VER_21:
+        case RTL_GIGA_MAC_VER_22:
+        case RTL_GIGA_MAC_VER_23:
+        case RTL_GIGA_MAC_VER_24:
+        case RTL_GIGA_MAC_VER_25:
+        case RTL_GIGA_MAC_VER_26:
+        case RTL_GIGA_MAC_VER_27:
+        case RTL_GIGA_MAC_VER_28:
+        case RTL_GIGA_MAC_VER_31:
+                rtl_writephy(tp, 0x0e, 0x0200);
+        default:
+                rtl_writephy(tp, MII_BMCR, BMCR_PDOWN);
+                break;
+        }
 }
 static void r8168_pll_power_down(struct rtl8169_private *tp)
 {
        void __iomem *ioaddr = tp->mmio_addr;
-        if (((tp->mac_version == RTL_GIGA_MAC_VER_27) ||
+        if ((tp->mac_version == RTL_GIGA_MAC_VER_27 ||
-             (tp->mac_version == RTL_GIGA_MAC_VER_28)) &&
+             tp->mac_version == RTL_GIGA_MAC_VER_28 ||
-            (ocp_read(tp, 0x0f, 0x0010) & 0x00008000)) {
+             tp->mac_version == RTL_GIGA_MAC_VER_31) &&
+            r8168dp_check_dash(tp)) {
                return;
        }
-        if (((tp->mac_version == RTL_GIGA_MAC_VER_23) ||
+        if ((tp->mac_version == RTL_GIGA_MAC_VER_23 ||
-             (tp->mac_version == RTL_GIGA_MAC_VER_24)) &&
+             tp->mac_version == RTL_GIGA_MAC_VER_24) &&
            (RTL_R16(CPlusCmd) & ASF)) {
                return;
        }
+        if (tp->mac_version == RTL_GIGA_MAC_VER_32 ||
+            tp->mac_version == RTL_GIGA_MAC_VER_33)
+                rtl_ephy_write(ioaddr, 0x19, 0xff64);
        if (__rtl8169_get_wol(tp) & WAKE_ANY) {
                rtl_writephy(tp, 0x1f, 0x0000);
                rtl_writephy(tp, MII_BMCR, 0x0000);
@@ -2950,6 +3135,9 @@ static void r8168_pll_power_down(struct rtl8169_private *tp)
        case RTL_GIGA_MAC_VER_26:
        case RTL_GIGA_MAC_VER_27:
        case RTL_GIGA_MAC_VER_28:
+        case RTL_GIGA_MAC_VER_31:
+        case RTL_GIGA_MAC_VER_32:
+        case RTL_GIGA_MAC_VER_33:
                RTL_W8(PMCH, RTL_R8(PMCH) & ~0x80);
                break;
        }
@@ -2959,9 +3147,10 @@ static void r8168_pll_power_up(struct rtl8169_private *tp)
 {
        void __iomem *ioaddr = tp->mmio_addr;
-        if (((tp->mac_version == RTL_GIGA_MAC_VER_27) ||
+        if ((tp->mac_version == RTL_GIGA_MAC_VER_27 ||
-             (tp->mac_version == RTL_GIGA_MAC_VER_28)) &&
+             tp->mac_version == RTL_GIGA_MAC_VER_28 ||
-            (ocp_read(tp, 0x0f, 0x0010) & 0x00008000)) {
+             tp->mac_version == RTL_GIGA_MAC_VER_31) &&
+            r8168dp_check_dash(tp)) {
                return;
        }
@@ -2970,6 +3159,9 @@ static void r8168_pll_power_up(struct rtl8169_private *tp)
        case RTL_GIGA_MAC_VER_26:
        case RTL_GIGA_MAC_VER_27:
        case RTL_GIGA_MAC_VER_28:
+        case RTL_GIGA_MAC_VER_31:
+        case RTL_GIGA_MAC_VER_32:
+        case RTL_GIGA_MAC_VER_33:
                RTL_W8(PMCH, RTL_R8(PMCH) | 0x80);
                break;
        }
@@ -3024,6 +3216,9 @@ static void __devinit rtl_init_pll_power_ops(struct rtl8169_private *tp)
        case RTL_GIGA_MAC_VER_26:
        case RTL_GIGA_MAC_VER_27:
        case RTL_GIGA_MAC_VER_28:
+        case RTL_GIGA_MAC_VER_31:
+        case RTL_GIGA_MAC_VER_32:
+        case RTL_GIGA_MAC_VER_33:
                ops->down       = r8168_pll_power_down;
                ops->up         = r8168_pll_power_up;
                break;
@@ -3035,6 +3230,22 @@ static void __devinit rtl_init_pll_power_ops(struct rtl8169_private *tp)
        }
 }
+static void rtl_hw_reset(struct rtl8169_private *tp)
+{
+        void __iomem *ioaddr = tp->mmio_addr;
+        int i;
+        /* Soft reset the chip. */
+        RTL_W8(ChipCmd, CmdReset);
+        /* Check that the chip has finished the reset. */
+        for (i = 0; i < 100; i++) {
+                if ((RTL_R8(ChipCmd) & CmdReset) == 0)
+                        break;
+                msleep_interruptible(1);
+        }
+}
 static int __devinit
 rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
@@ -3044,7 +3255,7 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        struct mii_if_info *mii;
        struct net_device *dev;
        void __iomem *ioaddr;
-        unsigned int i;
+        int chipset, i;
        int rc;
        if (netif_msg_drv(&debug)) {
@@ -3134,6 +3345,7 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
                rc = -EIO;
                goto err_out_free_res_3;
        }
+        tp->mmio_addr = ioaddr;
        tp->pcie_cap = pci_find_capability(pdev, PCI_CAP_ID_EXP);
        if (!tp->pcie_cap)
@@ -3141,22 +3353,14 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        RTL_W16(IntrMask, 0x0000);
-        /* Soft reset the chip. */
+        rtl_hw_reset(tp);
-        RTL_W8(ChipCmd, CmdReset);
-        /* Check that the chip has finished the reset. */
-        for (i = 0; i < 100; i++) {
-                if ((RTL_R8(ChipCmd) & CmdReset) == 0)
-                        break;
-                msleep_interruptible(1);
-        }
        RTL_W16(IntrStatus, 0xffff);
        pci_set_master(pdev);
        /* Identify chip attached to board */
-        rtl8169_get_mac_version(tp, ioaddr);
+        rtl8169_get_mac_version(tp, dev, cfg->default_ver);
        /*
         * Pretend we are using VLANs; This bypasses a nasty bug where
@@ -3168,25 +3372,10 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        rtl_init_mdio_ops(tp);
        rtl_init_pll_power_ops(tp);
-        /* Use appropriate default if unknown */
-        if (tp->mac_version == RTL_GIGA_MAC_NONE) {
-                netif_notice(tp, probe, dev,
-                             "unknown MAC, using family default\n");
-                tp->mac_version = cfg->default_ver;
-        }
        rtl8169_print_mac_version(tp);
-        for (i = 0; i < ARRAY_SIZE(rtl_chip_info); i++) {
+        chipset = tp->mac_version;
-                if (tp->mac_version == rtl_chip_info[i].mac_version)
+        tp->txd_version = rtl_chip_infos[chipset].txd_version;
-                        break;
-        }
-        if (i == ARRAY_SIZE(rtl_chip_info)) {
-                dev_err(&pdev->dev,
-                        "driver bug, MAC version not found in rtl_chip_info\n");
-                goto err_out_msi_4;
-        }
-        tp->chipset = i;
        RTL_W8(Cfg9346, Cfg9346_Unlock);
        RTL_W8(Config1, RTL_R8(Config1) | PMEnable);
@@ -3206,8 +3395,6 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
                tp->phy_reset_pending = rtl8169_tbi_reset_pending;
                tp->link_ok = rtl8169_tbi_link_ok;
                tp->do_ioctl = rtl_tbi_ioctl;
-                tp->phy_1000_ctrl_reg = ADVERTISE_1000FULL; /* Implied by TBI */
        } else {
                tp->set_speed = rtl8169_set_speed_xmii;
                tp->get_settings = rtl8169_gset_xmii;
@@ -3219,8 +3406,6 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        spin_lock_init(&tp->lock);
-        tp->mmio_addr = ioaddr;
        /* Get MAC address */
        for (i = 0; i < MAC_ADDR_LEN; i++)
                dev->dev_addr[i] = RTL_R8(MAC0 + i);
@@ -3233,7 +3418,19 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        netif_napi_add(dev, &tp->napi, rtl8169_poll, R8169_NAPI_WEIGHT);
-        dev->features |= NETIF_F_HW_VLAN_TX_RX | NETIF_F_GRO;
+        /* don't enable SG, IP_CSUM and TSO by default - it might not work
+         * properly for all devices */
+        dev->features |= NETIF_F_RXCSUM |
+                NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+        dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO |
+                NETIF_F_RXCSUM | NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+        dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO |
+                NETIF_F_HIGHDMA;
+        if (tp->mac_version == RTL_GIGA_MAC_VER_05)
+                /* 8110SCd requires hardware Rx VLAN - disallow toggling */
+                dev->hw_features &= ~NETIF_F_HW_VLAN_RX;
        tp->intr_mask = 0xffff;
        tp->hw_start = cfg->hw_start;
@@ -3253,12 +3450,12 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        pci_set_drvdata(pdev, dev);
        netif_info(tp, probe, dev, "%s at 0x%lx, %pM, XID %08x IRQ %d\n",
-                   rtl_chip_info[tp->chipset].name,
+                   rtl_chip_infos[chipset].name, dev->base_addr, dev->dev_addr,
-                   dev->base_addr, dev->dev_addr,
                   (u32)(RTL_R32(TxConfig) & 0x9cf0f8ff), dev->irq);
-        if ((tp->mac_version == RTL_GIGA_MAC_VER_27) ||
+        if (tp->mac_version == RTL_GIGA_MAC_VER_27 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_28)) {
+            tp->mac_version == RTL_GIGA_MAC_VER_28 ||
+            tp->mac_version == RTL_GIGA_MAC_VER_31) {
                rtl8168_driver_start(tp);
        }
@@ -3290,8 +3487,9 @@ static void __devexit rtl8169_remove_one(struct pci_dev *pdev)
        struct net_device *dev = pci_get_drvdata(pdev);
        struct rtl8169_private *tp = netdev_priv(dev);
-        if ((tp->mac_version == RTL_GIGA_MAC_VER_27) ||
+        if (tp->mac_version == RTL_GIGA_MAC_VER_27 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_28)) {
+            tp->mac_version == RTL_GIGA_MAC_VER_28 ||
+            tp->mac_version == RTL_GIGA_MAC_VER_31) {
                rtl8168_driver_stop(tp);
        }
@@ -3314,33 +3512,23 @@ static void __devexit rtl8169_remove_one(struct pci_dev *pdev)
 static void rtl_request_firmware(struct rtl8169_private *tp)
 {
-        int i;
        /* Return early if the firmware is already loaded / cached. */
-        if (!IS_ERR(tp->fw))
+        if (IS_ERR(tp->fw)) {
-                goto out;
+                const char *name;
-        for (i = 0; i < ARRAY_SIZE(rtl_firmware_infos); i++) {
-                const struct rtl_firmware_info *info = rtl_firmware_infos + i;
-                if (info->mac_version == tp->mac_version) {
+                name = rtl_lookup_firmware_name(tp);
-                        const char *name = info->fw_name;
+                if (name) {
                        int rc;
                        rc = request_firmware(&tp->fw, name, &tp->pci_dev->dev);
-                        if (rc < 0) {
+                        if (rc >= 0)
-                                netif_warn(tp, ifup, tp->dev, "unable to load "
+                                return;
-                                        "firmware patch %s (%d)\n", name, rc);
-                                goto out_disable_request_firmware;
+                        netif_warn(tp, ifup, tp->dev, "unable to load "
-                        }
+                                "firmware patch %s (%d)\n", name, rc);
-                        goto out;
                }
+                tp->fw = NULL;
        }
-out_disable_request_firmware:
-        tp->fw = NULL;
-out:
-        return;
 }
 static int rtl8169_open(struct net_device *dev)
@@ -3386,14 +3574,12 @@ static int rtl8169_open(struct net_device *dev)
        rtl8169_init_phy(dev, tp);
-        rtl8169_vlan_mode(dev);
+        rtl8169_set_features(dev, dev->features);
        rtl_pll_power_up(tp);
        rtl_hw_start(dev);
-        rtl8169_request_timer(dev);
        tp->saved_wolopts = 0;
        pm_runtime_put_noidle(&pdev->dev);
@@ -3425,7 +3611,8 @@ static void rtl8169_hw_reset(struct rtl8169_private *tp)
        rtl8169_irq_mask_and_ack(ioaddr);
        if (tp->mac_version == RTL_GIGA_MAC_VER_27 ||
-            tp->mac_version == RTL_GIGA_MAC_VER_28) {
+            tp->mac_version == RTL_GIGA_MAC_VER_28 ||
+            tp->mac_version == RTL_GIGA_MAC_VER_31) {
                while (RTL_R8(TxPoll) & NPQ)
                        udelay(20);
@@ -3443,7 +3630,7 @@ static void rtl_set_rx_tx_config_registers(struct rtl8169_private *tp)
        void __iomem *ioaddr = tp->mmio_addr;
        u32 cfg = rtl8169_rx_config;
-        cfg |= (RTL_R32(RxConfig) & rtl_chip_info[tp->chipset].RxConfigMask);
+        cfg |= (RTL_R32(RxConfig) & RTL_RX_CONFIG_MASK);
        RTL_W32(RxConfig, cfg);
        /* Set DMA burst size and Interframe Gap Time */
@@ -3454,25 +3641,14 @@ static void rtl_set_rx_tx_config_registers(struct rtl8169_private *tp)
 static void rtl_hw_start(struct net_device *dev)
 {
        struct rtl8169_private *tp = netdev_priv(dev);
-        void __iomem *ioaddr = tp->mmio_addr;
-        unsigned int i;
-        /* Soft reset the chip. */
+        rtl_hw_reset(tp);
-        RTL_W8(ChipCmd, CmdReset);
-        /* Check that the chip has finished the reset. */
-        for (i = 0; i < 100; i++) {
-                if ((RTL_R8(ChipCmd) & CmdReset) == 0)
-                        break;
-                msleep_interruptible(1);
-        }
        tp->hw_start(dev);
        netif_start_queue(dev);
 }
 static void rtl_set_rx_tx_desc_registers(struct rtl8169_private *tp,
                                         void __iomem *ioaddr)
 {
@@ -3538,26 +3714,26 @@ static void rtl_hw_start_8169(struct net_device *dev)
        }
        RTL_W8(Cfg9346, Cfg9346_Unlock);
-        if ((tp->mac_version == RTL_GIGA_MAC_VER_01) ||
+        if (tp->mac_version == RTL_GIGA_MAC_VER_01 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_02) ||
+            tp->mac_version == RTL_GIGA_MAC_VER_02 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_03) ||
+            tp->mac_version == RTL_GIGA_MAC_VER_03 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_04))
+            tp->mac_version == RTL_GIGA_MAC_VER_04)
                RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb);
        RTL_W8(EarlyTxThres, NoEarlyTx);
        rtl_set_rx_max_size(ioaddr, rx_buf_sz);
-        if ((tp->mac_version == RTL_GIGA_MAC_VER_01) ||
+        if (tp->mac_version == RTL_GIGA_MAC_VER_01 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_02) ||
+            tp->mac_version == RTL_GIGA_MAC_VER_02 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_03) ||
+            tp->mac_version == RTL_GIGA_MAC_VER_03 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_04))
+            tp->mac_version == RTL_GIGA_MAC_VER_04)
                rtl_set_rx_tx_config_registers(tp);
        tp->cp_cmd |= rtl_rw_cpluscmd(ioaddr) | PCIMulRW;
-        if ((tp->mac_version == RTL_GIGA_MAC_VER_02) ||
+        if (tp->mac_version == RTL_GIGA_MAC_VER_02 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_03)) {
+            tp->mac_version == RTL_GIGA_MAC_VER_03) {
                dprintk("Set MAC Reg C+CR Offset 0xE0. "
                        "Bit-3 and bit-14 MUST be 1\n");
                tp->cp_cmd |= (1 << 14);
@@ -3575,10 +3751,10 @@ static void rtl_hw_start_8169(struct net_device *dev)
        rtl_set_rx_tx_desc_registers(tp, ioaddr);
-        if ((tp->mac_version != RTL_GIGA_MAC_VER_01) &&
+        if (tp->mac_version != RTL_GIGA_MAC_VER_01 &&
-            (tp->mac_version != RTL_GIGA_MAC_VER_02) &&
+            tp->mac_version != RTL_GIGA_MAC_VER_02 &&
-            (tp->mac_version != RTL_GIGA_MAC_VER_03) &&
+            tp->mac_version != RTL_GIGA_MAC_VER_03 &&
-            (tp->mac_version != RTL_GIGA_MAC_VER_04)) {
+            tp->mac_version != RTL_GIGA_MAC_VER_04) {
                RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb);
                rtl_set_rx_tx_config_registers(tp);
        }
@@ -3822,6 +3998,17 @@ static void rtl_hw_start_8168d(void __iomem *ioaddr, struct pci_dev *pdev)
        RTL_W16(CPlusCmd, RTL_R16(CPlusCmd) & ~R8168_CPCMD_QUIRK_MASK);
 }
+static void rtl_hw_start_8168dp(void __iomem *ioaddr, struct pci_dev *pdev)
+{
+        rtl_csi_access_enable_1(ioaddr);
+        rtl_tx_performance_tweak(pdev, 0x5 << MAX_READ_REQUEST_SHIFT);
+        RTL_W8(MaxTxPacketSize, TxPacketMax);
+        rtl_disable_clock_request(pdev);
+}
 static void rtl_hw_start_8168d_4(void __iomem *ioaddr, struct pci_dev *pdev)
 {
        static const struct ephy_info e_info_8168d_4[] = {
@@ -3848,6 +4035,41 @@ static void rtl_hw_start_8168d_4(void __iomem *ioaddr, struct pci_dev *pdev)
        rtl_enable_clock_request(pdev);
 }
+static void rtl_hw_start_8168e(void __iomem *ioaddr, struct pci_dev *pdev)
+{
+        static const struct ephy_info e_info_8168e[] = {
+                { 0x00, 0x0200, 0x0100 },
+                { 0x00, 0x0000, 0x0004 },
+                { 0x06, 0x0002, 0x0001 },
+                { 0x06, 0x0000, 0x0030 },
+                { 0x07, 0x0000, 0x2000 },
+                { 0x00, 0x0000, 0x0020 },
+                { 0x03, 0x5800, 0x2000 },
+                { 0x03, 0x0000, 0x0001 },
+                { 0x01, 0x0800, 0x1000 },
+                { 0x07, 0x0000, 0x4000 },
+                { 0x1e, 0x0000, 0x2000 },
+                { 0x19, 0xffff, 0xfe6c },
+                { 0x0a, 0x0000, 0x0040 }
+        };
+        rtl_csi_access_enable_2(ioaddr);
+        rtl_ephy_init(ioaddr, e_info_8168e, ARRAY_SIZE(e_info_8168e));
+        rtl_tx_performance_tweak(pdev, 0x5 << MAX_READ_REQUEST_SHIFT);
+        RTL_W8(MaxTxPacketSize, TxPacketMax);
+        rtl_disable_clock_request(pdev);
+        /* Reset tx FIFO pointer */
+        RTL_W32(MISC, RTL_R32(MISC) | TXPLA_RST);
+        RTL_W32(MISC, RTL_R32(MISC) & ~TXPLA_RST);
+        RTL_W8(Config5, RTL_R8(Config5) & ~Spi_en);
+}
 static void rtl_hw_start_8168(struct net_device *dev)
 {
        struct rtl8169_private *tp = netdev_priv(dev);
@@ -3885,55 +4107,64 @@ static void rtl_hw_start_8168(struct net_device *dev)
        switch (tp->mac_version) {
        case RTL_GIGA_MAC_VER_11:
                rtl_hw_start_8168bb(ioaddr, pdev);
-        break;
+                break;
        case RTL_GIGA_MAC_VER_12:
        case RTL_GIGA_MAC_VER_17:
                rtl_hw_start_8168bef(ioaddr, pdev);
-        break;
+                break;
        case RTL_GIGA_MAC_VER_18:
                rtl_hw_start_8168cp_1(ioaddr, pdev);
-        break;
+                break;
        case RTL_GIGA_MAC_VER_19:
                rtl_hw_start_8168c_1(ioaddr, pdev);
-        break;
+                break;
        case RTL_GIGA_MAC_VER_20:
                rtl_hw_start_8168c_2(ioaddr, pdev);
-        break;
+                break;
        case RTL_GIGA_MAC_VER_21:
                rtl_hw_start_8168c_3(ioaddr, pdev);
-        break;
+                break;
        case RTL_GIGA_MAC_VER_22:
                rtl_hw_start_8168c_4(ioaddr, pdev);
-        break;
+                break;
        case RTL_GIGA_MAC_VER_23:
                rtl_hw_start_8168cp_2(ioaddr, pdev);
-        break;
+                break;
        case RTL_GIGA_MAC_VER_24:
                rtl_hw_start_8168cp_3(ioaddr, pdev);
-        break;
+                break;
        case RTL_GIGA_MAC_VER_25:
        case RTL_GIGA_MAC_VER_26:
        case RTL_GIGA_MAC_VER_27:
                rtl_hw_start_8168d(ioaddr, pdev);
-        break;
+                break;
        case RTL_GIGA_MAC_VER_28:
                rtl_hw_start_8168d_4(ioaddr, pdev);
-        break;
+                break;
+        case RTL_GIGA_MAC_VER_31:
+                rtl_hw_start_8168dp(ioaddr, pdev);
+                break;
+        case RTL_GIGA_MAC_VER_32:
+        case RTL_GIGA_MAC_VER_33:
+                rtl_hw_start_8168e(ioaddr, pdev);
+                break;
        default:
                printk(KERN_ERR PFX "%s: unknown chipset (mac_version = %d).\n",
                        dev->name, tp->mac_version);
-        break;
+                break;
        }
        RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb);
@@ -4017,10 +4248,10 @@ static void rtl_hw_start_8105e_1(void __iomem *ioaddr, struct pci_dev *pdev)
                { 0x0a, 0, 0x0020 }
        };
-        /* Force LAN exit from ASPM if Rx/Tx are not idel */
+        /* Force LAN exit from ASPM if Rx/Tx are not idle */
        RTL_W32(FuncEvent, RTL_R32(FuncEvent) | 0x002800);
-        /* disable Early Tally Counter */
+        /* Disable Early Tally Counter */
        RTL_W32(FuncEvent, RTL_R32(FuncEvent) & ~0x010000);
        RTL_W8(MCU, RTL_R8(MCU) | EN_NDP | EN_OOB_RESET);
@@ -4041,8 +4272,8 @@ static void rtl_hw_start_8101(struct net_device *dev)
        void __iomem *ioaddr = tp->mmio_addr;
        struct pci_dev *pdev = tp->pci_dev;
-        if ((tp->mac_version == RTL_GIGA_MAC_VER_13) ||
+        if (tp->mac_version == RTL_GIGA_MAC_VER_13 ||
-            (tp->mac_version == RTL_GIGA_MAC_VER_16)) {
+            tp->mac_version == RTL_GIGA_MAC_VER_16) {
                int cap = tp->pcie_cap;
                if (cap) {
@@ -4105,6 +4336,8 @@ static int rtl8169_change_mtu(struct net_device *dev, int new_mtu)
                return -EINVAL;
        dev->mtu = new_mtu;
+        netdev_update_features(dev);
        return 0;
 }
@@ -4342,6 +4575,7 @@ static void rtl8169_reset_task(struct work_struct *work)
        struct rtl8169_private *tp =
                container_of(work, struct rtl8169_private, task.work);
        struct net_device *dev = tp->dev;
+        int i;
        rtnl_lock();
@@ -4350,19 +4584,15 @@ static void rtl8169_reset_task(struct work_struct *work)
        rtl8169_wait_for_quiescence(dev);
-        rtl8169_rx_interrupt(dev, tp, tp->mmio_addr, ~(u32)0);
+        for (i = 0; i < NUM_RX_DESC; i++)
+                rtl8169_mark_to_asic(tp->RxDescArray + i, rx_buf_sz);
        rtl8169_tx_clear(tp);
-        if (tp->dirty_rx == tp->cur_rx) {
+        rtl8169_init_ring_indexes(tp);
-                rtl8169_init_ring_indexes(tp);
+        rtl_hw_start(dev);
-                rtl_hw_start(dev);
+        netif_wake_queue(dev);
-                netif_wake_queue(dev);
+        rtl8169_check_link_status(dev, tp, tp->mmio_addr);
-                rtl8169_check_link_status(dev, tp, tp->mmio_addr);
-        } else {
-                if (net_ratelimit())
-                        netif_emerg(tp, intr, dev, "Rx buffers shortage\n");
-                rtl8169_schedule_work(dev, rtl8169_reset_task);
-        }
 out_unlock:
        rtnl_unlock();
@@ -4379,7 +4609,7 @@ static void rtl8169_tx_timeout(struct net_device *dev)
 }
 static int rtl8169_xmit_frags(struct rtl8169_private *tp, struct sk_buff *skb,
-                              u32 opts1)
+                              u32 *opts)
 {
        struct skb_shared_info *info = skb_shinfo(skb);
        unsigned int cur_frag, entry;
@@ -4406,10 +4636,12 @@ static int rtl8169_xmit_frags(struct rtl8169_private *tp, struct sk_buff *skb,
                        goto err_out;
                }
-                /* anti gcc 2.95.3 bugware (sic) */
+                /* Anti gcc 2.95.3 bugware (sic) */
-                status = opts1 | len | (RingEnd * !((entry + 1) % NUM_TX_DESC));
+                status = opts[0] | len |
+                        (RingEnd * !((entry + 1) % NUM_TX_DESC));
                txd->opts1 = cpu_to_le32(status);
+                txd->opts2 = cpu_to_le32(opts[1]);
                txd->addr = cpu_to_le64(mapping);
                tp->tx_skb[entry].len = len;
@@ -4427,24 +4659,26 @@ err_out:
        return -EIO;
 }
-static inline u32 rtl8169_tso_csum(struct sk_buff *skb, struct net_device *dev)
+static inline void rtl8169_tso_csum(struct rtl8169_private *tp,
+                                    struct sk_buff *skb, u32 *opts)
 {
-        if (dev->features & NETIF_F_TSO) {
+        const struct rtl_tx_desc_info *info = tx_desc_info + tp->txd_version;
-                u32 mss = skb_shinfo(skb)->gso_size;
+        u32 mss = skb_shinfo(skb)->gso_size;
+        int offset = info->opts_offset;
-                if (mss)
+        if (mss) {
-                        return LargeSend | ((mss & MSSMask) << MSSShift);
+                opts[0] |= TD_LSO;
-        }
+                opts[offset] |= min(mss, TD_MSS_MAX) << info->mss_shift;
-        if (skb->ip_summed == CHECKSUM_PARTIAL) {
+        } else if (skb->ip_summed == CHECKSUM_PARTIAL) {
                const struct iphdr *ip = ip_hdr(skb);
                if (ip->protocol == IPPROTO_TCP)
-                        return IPCS | TCPCS;
+                        opts[offset] |= info->checksum.tcp;
                else if (ip->protocol == IPPROTO_UDP)
-                        return IPCS | UDPCS;
+                        opts[offset] |= info->checksum.udp;
-                WARN_ON(1);     /* we need a WARN() */
+                else
+                        WARN_ON_ONCE(1);
        }
-        return 0;
 }
 static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
@@ -4457,7 +4691,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
        struct device *d = &tp->pci_dev->dev;
        dma_addr_t mapping;
        u32 status, len;
-        u32 opts1;
+        u32 opts[2];
        int frags;
        if (unlikely(TX_BUFFS_AVAIL(tp) < skb_shinfo(skb)->nr_frags)) {
@@ -4478,31 +4712,35 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
        tp->tx_skb[entry].len = len;
        txd->addr = cpu_to_le64(mapping);
-        txd->opts2 = cpu_to_le32(rtl8169_tx_vlan_tag(tp, skb));
-        opts1 = DescOwn | rtl8169_tso_csum(skb, dev);
+        opts[1] = cpu_to_le32(rtl8169_tx_vlan_tag(tp, skb));
+        opts[0] = DescOwn;
-        frags = rtl8169_xmit_frags(tp, skb, opts1);
+        rtl8169_tso_csum(tp, skb, opts);
+        frags = rtl8169_xmit_frags(tp, skb, opts);
        if (frags < 0)
                goto err_dma_1;
        else if (frags)
-                opts1 |= FirstFrag;
+                opts[0] |= FirstFrag;
        else {
-                opts1 |= FirstFrag | LastFrag;
+                opts[0] |= FirstFrag | LastFrag;
                tp->tx_skb[entry].skb = skb;
        }
+        txd->opts2 = cpu_to_le32(opts[1]);
        wmb();
-        /* anti gcc 2.95.3 bugware (sic) */
+        /* Anti gcc 2.95.3 bugware (sic) */
-        status = opts1 | len | (RingEnd * !((entry + 1) % NUM_TX_DESC));
+        status = opts[0] | len | (RingEnd * !((entry + 1) % NUM_TX_DESC));
        txd->opts1 = cpu_to_le32(status);
        tp->cur_tx += frags + 1;
        wmb();
-        RTL_W8(TxPoll, NPQ);    /* set polling bit */
+        RTL_W8(TxPoll, NPQ);
        if (TX_BUFFS_AVAIL(tp) < MAX_SKB_FRAGS) {
                netif_stop_queue(dev);
@@ -4659,20 +4897,12 @@ static struct sk_buff *rtl8169_try_rx_copy(void *data,
        return skb;
 }
-/*
- * Warning : rtl8169_rx_interrupt() might be called :
- * 1) from NAPI (softirq) context
- *      (polling = 1 : we should call netif_receive_skb())
- * 2) from process context (rtl8169_reset_task())
- *      (polling = 0 : we must call netif_rx() instead)
- */
 static int rtl8169_rx_interrupt(struct net_device *dev,
                                struct rtl8169_private *tp,
                                void __iomem *ioaddr, u32 budget)
 {
        unsigned int cur_rx, rx_left;
        unsigned int count;
-        int polling = (budget != ~(u32)0) ? 1 : 0;
        cur_rx = tp->cur_rx;
        rx_left = NUM_RX_DESC + tp->dirty_rx - cur_rx;
@@ -4732,10 +4962,7 @@ static int rtl8169_rx_interrupt(struct net_device *dev,
                        rtl8169_rx_vlan_tag(desc, skb);
-                        if (likely(polling))
+                        napi_gro_receive(&tp->napi, skb);
-                                napi_gro_receive(&tp->napi, skb);
-                        else
-                                netif_rx(skb);
                        dev->stats.rx_bytes += pkt_size;
                        dev->stats.rx_packets++;
@@ -4798,6 +5025,7 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance)
                        case RTL_GIGA_MAC_VER_24:
                        case RTL_GIGA_MAC_VER_27:
                        case RTL_GIGA_MAC_VER_28:
+                        case RTL_GIGA_MAC_VER_31:
                        /* Experimental science. Pktgen proof. */
                        case RTL_GIGA_MAC_VER_12:
                        case RTL_GIGA_MAC_VER_25:
@@ -4890,7 +5118,7 @@ static void rtl8169_down(struct net_device *dev)
        struct rtl8169_private *tp = netdev_priv(dev);
        void __iomem *ioaddr = tp->mmio_addr;
-        rtl8169_delete_timer(dev);
+        del_timer_sync(&tp->timer);
        netif_stop_queue(dev);
@@ -4927,7 +5155,7 @@ static int rtl8169_close(struct net_device *dev)
        pm_runtime_get_sync(&pdev->dev);
-        /* update counters before going down */
+        /* Update counters before going down */
        rtl8169_update_counters(dev);
        rtl8169_down(dev);
@@ -4982,7 +5210,7 @@ static void rtl_set_rx_mode(struct net_device *dev)
        spin_lock_irqsave(&tp->lock, flags);
        tmp = rtl8169_rx_config | rx_mode |
-              (RTL_R32(RxConfig) & rtl_chip_info[tp->chipset].RxConfigMask);
+              (RTL_R32(RxConfig) & RTL_RX_CONFIG_MASK);
        if (tp->mac_version > RTL_GIGA_MAC_VER_06) {
                u32 data = mc_filter[0];
@@ -5120,15 +5348,15 @@ static int rtl8169_runtime_idle(struct device *device)
 }
 static const struct dev_pm_ops rtl8169_pm_ops = {
-        .suspend = rtl8169_suspend,
+        .suspend                = rtl8169_suspend,
-        .resume = rtl8169_resume,
+        .resume                 = rtl8169_resume,
-        .freeze = rtl8169_suspend,
+        .freeze                 = rtl8169_suspend,
-        .thaw = rtl8169_resume,
+        .thaw                   = rtl8169_resume,
-        .poweroff = rtl8169_suspend,
+        .poweroff               = rtl8169_suspend,
-        .restore = rtl8169_resume,
+        .restore                = rtl8169_resume,
-        .runtime_suspend = rtl8169_runtime_suspend,
+        .runtime_suspend        = rtl8169_runtime_suspend,
-        .runtime_resume = rtl8169_runtime_resume,
+        .runtime_resume         = rtl8169_runtime_resume,
-        .runtime_idle = rtl8169_runtime_idle,
+        .runtime_idle           = rtl8169_runtime_idle,
 };
 #define RTL8169_PM_OPS  (&rtl8169_pm_ops)
@@ -5147,7 +5375,7 @@ static void rtl_shutdown(struct pci_dev *pdev)
        rtl8169_net_suspend(dev);
-        /* restore original MAC address */
+        /* Restore original MAC address */
        rtl_rar_set(tp, dev->perm_addr);
        spin_lock_irq(&tp->lock);
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index 337bdcd5abc9..89cfee7e8643 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -2244,13 +2244,12 @@ static int verify_xena_quiescence(struct s2io_nic *sp)
 static void fix_mac_address(struct s2io_nic *sp)
 {
        struct XENA_dev_config __iomem *bar0 = sp->bar0;
-        u64 val64;
        int i = 0;
        while (fix_mac[i] != END_SIGN) {
                writeq(fix_mac[i++], &bar0->gpio_control);
                udelay(10);
-                val64 = readq(&bar0->gpio_control);
+                (void) readq(&bar0->gpio_control);
        }
 }
@@ -2727,7 +2726,6 @@ static void free_rxd_blk(struct s2io_nic *sp, int ring_no, int blk)
        int j;
        struct sk_buff *skb;
        struct RxD_t *rxdp;
-        struct buffAdd *ba;
        struct RxD1 *rxdp1;
        struct RxD3 *rxdp3;
        struct mac_info *mac_control = &sp->mac_control;
@@ -2751,7 +2749,6 @@ static void free_rxd_blk(struct s2io_nic *sp, int ring_no, int blk)
                        memset(rxdp, 0, sizeof(struct RxD1));
                } else if (sp->rxd_mode == RXD_MODE_3B) {
                        rxdp3 = (struct RxD3 *)rxdp;
-                        ba = &mac_control->rings[ring_no].ba[blk][j];
                        pci_unmap_single(sp->pdev,
                                         (dma_addr_t)rxdp3->Buffer0_ptr,
                                         BUF0_LEN,
@@ -5383,7 +5380,7 @@ static int s2io_ethtool_sset(struct net_device *dev,
 {
        struct s2io_nic *sp = netdev_priv(dev);
        if ((info->autoneg == AUTONEG_ENABLE) ||
-            (info->speed != SPEED_10000) ||
+            (ethtool_cmd_speed(info) != SPEED_10000) ||
            (info->duplex != DUPLEX_FULL))
                return -EINVAL;
        else {
@@ -5417,10 +5414,10 @@ static int s2io_ethtool_gset(struct net_device *dev, struct ethtool_cmd *info)
        info->transceiver = XCVR_EXTERNAL;
        if (netif_carrier_ok(sp->dev)) {
-                info->speed = 10000;
+                ethtool_cmd_speed_set(info, SPEED_10000);
                info->duplex = DUPLEX_FULL;
        } else {
-                info->speed = -1;
+                ethtool_cmd_speed_set(info, -1);
                info->duplex = -1;
        }
@@ -5484,83 +5481,79 @@ static void s2io_ethtool_gregs(struct net_device *dev,
        }
 }
-/**
+/*
- *  s2io_phy_id  - timer function that alternates adapter LED.
+ *  s2io_set_led - control NIC led
- *  @data : address of the private member of the device structure, which
- *  is a pointer to the s2io_nic structure, provided as an u32.
- * Description: This is actually the timer function that alternates the
- * adapter LED bit of the adapter control bit to set/reset every time on
- * invocation. The timer is set for 1/2 a second, hence tha NIC blinks
- *  once every second.
 */
-static void s2io_phy_id(unsigned long data)
+static void s2io_set_led(struct s2io_nic *sp, bool on)
 {
-        struct s2io_nic *sp = (struct s2io_nic *)data;
        struct XENA_dev_config __iomem *bar0 = sp->bar0;
-        u64 val64 = 0;
+        u16 subid = sp->pdev->subsystem_device;
-        u16 subid;
+        u64 val64;
-        subid = sp->pdev->subsystem_device;
        if ((sp->device_type == XFRAME_II_DEVICE) ||
            ((subid & 0xFF) >= 0x07)) {
                val64 = readq(&bar0->gpio_control);
-                val64 ^= GPIO_CTRL_GPIO_0;
+                if (on)
+                        val64 |= GPIO_CTRL_GPIO_0;
+                else
+                        val64 &= ~GPIO_CTRL_GPIO_0;
                writeq(val64, &bar0->gpio_control);
        } else {
                val64 = readq(&bar0->adapter_control);
-                val64 ^= ADAPTER_LED_ON;
+                if (on)
+                        val64 |= ADAPTER_LED_ON;
+                else
+                        val64 &= ~ADAPTER_LED_ON;
                writeq(val64, &bar0->adapter_control);
        }
-        mod_timer(&sp->id_timer, jiffies + HZ / 2);
 }
 /**
- * s2io_ethtool_idnic - To physically identify the nic on the system.
+ * s2io_ethtool_set_led - To physically identify the nic on the system.
- * @sp : private member of the device structure, which is a pointer to the
+ * @dev : network device
- * s2io_nic structure.
+ * @state: led setting
- * @id : pointer to the structure with identification parameters given by
+ *
- * ethtool.
 * Description: Used to physically identify the NIC on the system.
 * The Link LED will blink for a time specified by the user for
 * identification.
 * NOTE: The Link has to be Up to be able to blink the LED. Hence
 * identification is possible only if it's link is up.
- * Return value:
- * int , returns 0 on success
 */
-static int s2io_ethtool_idnic(struct net_device *dev, u32 data)
+static int s2io_ethtool_set_led(struct net_device *dev,
+                                enum ethtool_phys_id_state state)
 {
-        u64 val64 = 0, last_gpio_ctrl_val;
        struct s2io_nic *sp = netdev_priv(dev);
        struct XENA_dev_config __iomem *bar0 = sp->bar0;
-        u16 subid;
+        u16 subid = sp->pdev->subsystem_device;
-        subid = sp->pdev->subsystem_device;
-        last_gpio_ctrl_val = readq(&bar0->gpio_control);
        if ((sp->device_type == XFRAME_I_DEVICE) && ((subid & 0xFF) < 0x07)) {
-                val64 = readq(&bar0->adapter_control);
+                u64 val64 = readq(&bar0->adapter_control);
                if (!(val64 & ADAPTER_CNTL_EN)) {
                        pr_err("Adapter Link down, cannot blink LED\n");
-                        return -EFAULT;
+                        return -EAGAIN;
                }
        }
-        if (sp->id_timer.function == NULL) {
-                init_timer(&sp->id_timer);
-                sp->id_timer.function = s2io_phy_id;
-                sp->id_timer.data = (unsigned long)sp;
-        }
-        mod_timer(&sp->id_timer, jiffies);
-        if (data)
-                msleep_interruptible(data * HZ);
-        else
-                msleep_interruptible(MAX_FLICKER_TIME);
-        del_timer_sync(&sp->id_timer);
-        if (CARDS_WITH_FAULTY_LINK_INDICATORS(sp->device_type, subid)) {
+        switch (state) {
-                writeq(last_gpio_ctrl_val, &bar0->gpio_control);
+        case ETHTOOL_ID_ACTIVE:
-                last_gpio_ctrl_val = readq(&bar0->gpio_control);
+                sp->adapt_ctrl_org = readq(&bar0->gpio_control);
+                return 1;       /* cycle on/off once per second */
+        case ETHTOOL_ID_ON:
+                s2io_set_led(sp, true);
+                break;
+        case ETHTOOL_ID_OFF:
+                s2io_set_led(sp, false);
+                break;
+        case ETHTOOL_ID_INACTIVE:
+                if (CARDS_WITH_FAULTY_LINK_INDICATORS(sp->device_type, subid))
+                        writeq(sp->adapt_ctrl_org, &bar0->gpio_control);
        }
        return 0;
@@ -6625,25 +6618,6 @@ static int s2io_ethtool_get_regs_len(struct net_device *dev)
 }
-static u32 s2io_ethtool_get_rx_csum(struct net_device *dev)
-{
-        struct s2io_nic *sp = netdev_priv(dev);
-        return sp->rx_csum;
-}
-static int s2io_ethtool_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct s2io_nic *sp = netdev_priv(dev);
-        if (data)
-                sp->rx_csum = 1;
-        else
-                sp->rx_csum = 0;
-        return 0;
-}
 static int s2io_get_eeprom_len(struct net_device *dev)
 {
        return XENA_EEPROM_SPACE;
@@ -6695,61 +6669,27 @@ static void s2io_ethtool_get_strings(struct net_device *dev,
        }
 }
-static int s2io_ethtool_op_set_tx_csum(struct net_device *dev, u32 data)
+static int s2io_set_features(struct net_device *dev, u32 features)
-{
-        if (data)
-                dev->features |= NETIF_F_IP_CSUM;
-        else
-                dev->features &= ~NETIF_F_IP_CSUM;
-        return 0;
-}
-static u32 s2io_ethtool_op_get_tso(struct net_device *dev)
-{
-        return (dev->features & NETIF_F_TSO) != 0;
-}
-static int s2io_ethtool_op_set_tso(struct net_device *dev, u32 data)
-{
-        if (data)
-                dev->features |= (NETIF_F_TSO | NETIF_F_TSO6);
-        else
-                dev->features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
-        return 0;
-}
-static int s2io_ethtool_set_flags(struct net_device *dev, u32 data)
 {
        struct s2io_nic *sp = netdev_priv(dev);
-        int rc = 0;
+        u32 changed = (features ^ dev->features) & NETIF_F_LRO;
-        int changed = 0;
-        if (ethtool_invalid_flags(dev, data, ETH_FLAG_LRO))
-                return -EINVAL;
-        if (data & ETH_FLAG_LRO) {
-                if (!(dev->features & NETIF_F_LRO)) {
-                        dev->features |= NETIF_F_LRO;
-                        changed = 1;
-                }
-        } else if (dev->features & NETIF_F_LRO) {
-                dev->features &= ~NETIF_F_LRO;
-                changed = 1;
-        }
        if (changed && netif_running(dev)) {
+                int rc;
                s2io_stop_all_tx_queue(sp);
                s2io_card_down(sp);
+                dev->features = features;
                rc = s2io_card_up(sp);
                if (rc)
                        s2io_reset(sp);
                else
                        s2io_start_all_tx_queue(sp);
+                return rc ? rc : 1;
        }
-        return rc;
+        return 0;
 }
 static const struct ethtool_ops netdev_ethtool_ops = {
@@ -6765,18 +6705,9 @@ static const struct ethtool_ops netdev_ethtool_ops = {
        .get_ringparam = s2io_ethtool_gringparam,
        .get_pauseparam = s2io_ethtool_getpause_data,
        .set_pauseparam = s2io_ethtool_setpause_data,
-        .get_rx_csum = s2io_ethtool_get_rx_csum,
-        .set_rx_csum = s2io_ethtool_set_rx_csum,
-        .set_tx_csum = s2io_ethtool_op_set_tx_csum,
-        .set_flags = s2io_ethtool_set_flags,
-        .get_flags = ethtool_op_get_flags,
-        .set_sg = ethtool_op_set_sg,
-        .get_tso = s2io_ethtool_op_get_tso,
-        .set_tso = s2io_ethtool_op_set_tso,
-        .set_ufo = ethtool_op_set_ufo,
        .self_test = s2io_ethtool_test,
        .get_strings = s2io_ethtool_get_strings,
-        .phys_id = s2io_ethtool_idnic,
+        .set_phys_id = s2io_ethtool_set_led,
        .get_ethtool_stats = s2io_get_ethtool_stats,
        .get_sset_count = s2io_get_sset_count,
 };
@@ -7545,7 +7476,7 @@ static int rx_osm_handler(struct ring_info *ring_data, struct RxD_t * rxdp)
        if ((rxdp->Control_1 & TCP_OR_UDP_FRAME) &&
            ((!ring_data->lro) ||
             (ring_data->lro && (!(rxdp->Control_1 & RXD_FRAME_IP_FRAG)))) &&
-            (sp->rx_csum)) {
+            (dev->features & NETIF_F_RXCSUM)) {
                l3_csum = RXD_GET_L3_CKSUM(rxdp->Control_1);
                l4_csum = RXD_GET_L4_CKSUM(rxdp->Control_1);
                if ((l3_csum == L3_CKSUM_OK) && (l4_csum == L4_CKSUM_OK)) {
@@ -7806,6 +7737,7 @@ static const struct net_device_ops s2io_netdev_ops = {
        .ndo_do_ioctl           = s2io_ioctl,
        .ndo_set_mac_address    = s2io_set_mac_addr,
        .ndo_change_mtu         = s2io_change_mtu,
+        .ndo_set_features       = s2io_set_features,
        .ndo_vlan_rx_register   = s2io_vlan_rx_register,
        .ndo_vlan_rx_kill_vid   = s2io_vlan_rx_kill_vid,
        .ndo_tx_timeout         = s2io_tx_watchdog,
@@ -8047,17 +7979,18 @@ s2io_init_nic(struct pci_dev *pdev, const struct pci_device_id *pre)
        /*  Driver entry points */
        dev->netdev_ops = &s2io_netdev_ops;
        SET_ETHTOOL_OPS(dev, &netdev_ethtool_ops);
-        dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+        dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM |
-        dev->features |= NETIF_F_LRO;
+                NETIF_F_TSO | NETIF_F_TSO6 |
-        dev->features |= NETIF_F_SG | NETIF_F_IP_CSUM;
+                NETIF_F_RXCSUM | NETIF_F_LRO;
+        dev->features |= dev->hw_features |
+                NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+        if (sp->device_type & XFRAME_II_DEVICE) {
+                dev->hw_features |= NETIF_F_UFO;
+                if (ufo)
+                        dev->features |= NETIF_F_UFO;
+        }
        if (sp->high_dma_flag == true)
                dev->features |= NETIF_F_HIGHDMA;
-        dev->features |= NETIF_F_TSO;
-        dev->features |= NETIF_F_TSO6;
-        if ((sp->device_type & XFRAME_II_DEVICE) && (ufo))  {
-                dev->features |= NETIF_F_UFO;
-                dev->features |= NETIF_F_HW_CSUM;
-        }
        dev->watchdog_timeo = WATCH_DOG_TIMEOUT;
        INIT_WORK(&sp->rst_timer_task, s2io_restart_nic);
        INIT_WORK(&sp->set_link_task, s2io_set_link);
diff --git a/drivers/net/s2io.h b/drivers/net/s2io.h
index 2d144979f6f8..800b3a44e653 100644
--- a/drivers/net/s2io.h
+++ b/drivers/net/s2io.h
@@ -893,9 +893,6 @@ struct s2io_nic {
        u16 all_multi_pos;
        u16 promisc_flg;
-        /*  Id timer, used to blink NIC to physically identify NIC. */
-        struct timer_list id_timer;
        /*  Restart timer, used to restart NIC if the device is stuck and
         *  a schedule task that will set the correct Link state once the
         *  NIC's PHY has stabilized after a state change.
@@ -1005,18 +1002,16 @@ static inline void writeq(u64 val, void __iomem *addr)
 #define LF      2
 static inline void SPECIAL_REG_WRITE(u64 val, void __iomem *addr, int order)
 {
-        u32 ret;
        if (order == LF) {
                writel((u32) (val), addr);
-                ret = readl(addr);
+                (void) readl(addr);
                writel((u32) (val >> 32), (addr + 4));
-                ret = readl(addr + 4);
+                (void) readl(addr + 4);
        } else {
                writel((u32) (val >> 32), (addr + 4));
-                ret = readl(addr + 4);
+                (void) readl(addr + 4);
                writel((u32) (val), addr);
-                ret = readl(addr);
+                (void) readl(addr);
        }
 }
diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c
index 76290a8c3c14..fa74314ef789 100644
--- a/drivers/net/sc92031.c
+++ b/drivers/net/sc92031.c
@@ -1173,7 +1173,8 @@ static int sc92031_ethtool_get_settings(struct net_device *dev,
        if (phy_ctrl & PhyCtrlAne)
                cmd->advertising |= ADVERTISED_Autoneg;
-        cmd->speed = (output_status & 0x2) ? SPEED_100 : SPEED_10;
+        ethtool_cmd_speed_set(cmd,
+                              (output_status & 0x2) ? SPEED_100 : SPEED_10);
        cmd->duplex = (output_status & 0x4) ? DUPLEX_FULL : DUPLEX_HALF;
        cmd->port = PORT_MII;
        cmd->phy_address = phy_address;
@@ -1188,10 +1189,11 @@ static int sc92031_ethtool_set_settings(struct net_device *dev,
 {
        struct sc92031_priv *priv = netdev_priv(dev);
        void __iomem *port_base = priv->port_base;
+        u32 speed = ethtool_cmd_speed(cmd);
        u32 phy_ctrl;
        u32 old_phy_ctrl;
-        if (!(cmd->speed == SPEED_10 || cmd->speed == SPEED_100))
+        if (!(speed == SPEED_10 || speed == SPEED_100))
                return -EINVAL;
        if (!(cmd->duplex == DUPLEX_HALF || cmd->duplex == DUPLEX_FULL))
                return -EINVAL;
@@ -1229,7 +1231,7 @@ static int sc92031_ethtool_set_settings(struct net_device *dev,
                // FIXME: Whole branch guessed
                phy_ctrl = 0;
-                if (cmd->speed == SPEED_10)
+                if (speed == SPEED_10)
                        phy_ctrl |= PhyCtrlSpd10;
                else /* cmd->speed == SPEED_100 */
                        phy_ctrl |= PhyCtrlSpd100;
diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c
index a3c2aab53de8..c914729f9554 100644
--- a/drivers/net/sfc/efx.c
+++ b/drivers/net/sfc/efx.c
@@ -798,11 +798,6 @@ void efx_link_status_changed(struct efx_nic *efx)
        if (!netif_running(efx->net_dev))
                return;
-        if (efx->port_inhibited) {
-                netif_carrier_off(efx->net_dev);
-                return;
-        }
        if (link_state->up != netif_carrier_ok(efx->net_dev)) {
                efx->n_link_state_changes++;
@@ -838,7 +833,7 @@ void efx_link_set_advertising(struct efx_nic *efx, u32 advertising)
        }
 }
-void efx_link_set_wanted_fc(struct efx_nic *efx, enum efx_fc_type wanted_fc)
+void efx_link_set_wanted_fc(struct efx_nic *efx, u8 wanted_fc)
 {
        efx->wanted_fc = wanted_fc;
        if (efx->link_advertising) {
@@ -1319,8 +1314,20 @@ static void efx_remove_interrupts(struct efx_nic *efx)
 static void efx_set_channels(struct efx_nic *efx)
 {
+        struct efx_channel *channel;
+        struct efx_tx_queue *tx_queue;
        efx->tx_channel_offset =
                separate_tx_channels ? efx->n_channels - efx->n_tx_channels : 0;
+        /* We need to adjust the TX queue numbers if we have separate
+         * RX-only and TX-only channels.
+         */
+        efx_for_each_channel(channel, efx) {
+                efx_for_each_channel_tx_queue(tx_queue, channel)
+                        tx_queue->queue -= (efx->tx_channel_offset *
+                                            EFX_TXQ_TYPES);
+        }
 }
 static int efx_probe_nic(struct efx_nic *efx)
@@ -1438,7 +1445,7 @@ static void efx_start_all(struct efx_nic *efx)
         * restart the transmit interface early so the watchdog timer stops */
        efx_start_port(efx);
-        if (efx_dev_registered(efx) && !efx->port_inhibited)
+        if (efx_dev_registered(efx) && netif_device_present(efx->net_dev))
                netif_tx_wake_all_queues(efx->net_dev);
        efx_for_each_channel(channel, efx)
@@ -1876,6 +1883,17 @@ static void efx_set_multicast_list(struct net_device *net_dev)
        /* Otherwise efx_start_port() will do this */
 }
+static int efx_set_features(struct net_device *net_dev, u32 data)
+{
+        struct efx_nic *efx = netdev_priv(net_dev);
+        /* If disabling RX n-tuple filtering, clear existing filters */
+        if (net_dev->features & ~data & NETIF_F_NTUPLE)
+                efx_filter_clear_rx(efx, EFX_FILTER_PRI_MANUAL);
+        return 0;
+}
 static const struct net_device_ops efx_netdev_ops = {
        .ndo_open               = efx_net_open,
        .ndo_stop               = efx_net_stop,
@@ -1887,6 +1905,7 @@ static const struct net_device_ops efx_netdev_ops = {
        .ndo_change_mtu         = efx_change_mtu,
        .ndo_set_mac_address    = efx_set_mac_address,
        .ndo_set_multicast_list = efx_set_multicast_list,
+        .ndo_set_features       = efx_set_features,
 #ifdef CONFIG_NET_POLL_CONTROLLER
        .ndo_poll_controller = efx_netpoll,
 #endif
@@ -2090,6 +2109,7 @@ int efx_reset(struct efx_nic *efx, enum reset_type method)
        netif_info(efx, drv, efx->net_dev, "resetting (%s)\n",
                   RESET_TYPE(method));
+        netif_device_detach(efx->net_dev);
        efx_reset_down(efx, method);
        rc = efx->type->reset(efx, method);
@@ -2123,6 +2143,7 @@ out:
                efx->state = STATE_DISABLED;
        } else {
                netif_dbg(efx, drv, efx->net_dev, "reset complete\n");
+                netif_device_attach(efx->net_dev);
        }
        return rc;
 }
@@ -2235,7 +2256,7 @@ static bool efx_port_dummy_op_poll(struct efx_nic *efx)
        return false;
 }
-static struct efx_phy_operations efx_dummy_phy_operations = {
+static const struct efx_phy_operations efx_dummy_phy_operations = {
        .init            = efx_port_dummy_op_int,
        .reconfigure     = efx_port_dummy_op_int,
        .poll            = efx_port_dummy_op_poll,
@@ -2251,7 +2272,7 @@ static struct efx_phy_operations efx_dummy_phy_operations = {
 /* This zeroes out and then fills in the invariants in a struct
 * efx_nic (including all sub-structures).
 */
-static int efx_init_struct(struct efx_nic *efx, struct efx_nic_type *type,
+static int efx_init_struct(struct efx_nic *efx, const struct efx_nic_type *type,
                           struct pci_dev *pci_dev, struct net_device *net_dev)
 {
        int i;
@@ -2271,7 +2292,6 @@ static int efx_init_struct(struct efx_nic *efx, struct efx_nic_type *type,
        strlcpy(efx->name, pci_name(pci_dev), sizeof(efx->name));
        efx->net_dev = net_dev;
-        efx->rx_checksum_enabled = true;
        spin_lock_init(&efx->stats_lock);
        mutex_init(&efx->mac_lock);
        efx->mac_op = type->default_mac_ops;
@@ -2442,7 +2462,7 @@ static int efx_pci_probe_main(struct efx_nic *efx)
 static int __devinit efx_pci_probe(struct pci_dev *pci_dev,
                                   const struct pci_device_id *entry)
 {
-        struct efx_nic_type *type = (struct efx_nic_type *) entry->driver_data;
+        const struct efx_nic_type *type = (const struct efx_nic_type *) entry->driver_data;
        struct net_device *net_dev;
        struct efx_nic *efx;
        int i, rc;
@@ -2454,12 +2474,15 @@ static int __devinit efx_pci_probe(struct pci_dev *pci_dev,
                return -ENOMEM;
        net_dev->features |= (type->offload_features | NETIF_F_SG |
                              NETIF_F_HIGHDMA | NETIF_F_TSO |
-                              NETIF_F_GRO);
+                              NETIF_F_RXCSUM);
        if (type->offload_features & NETIF_F_V6_CSUM)
                net_dev->features |= NETIF_F_TSO6;
        /* Mask for features that also apply to VLAN devices */
        net_dev->vlan_features |= (NETIF_F_ALL_CSUM | NETIF_F_SG |
-                                   NETIF_F_HIGHDMA | NETIF_F_TSO);
+                                   NETIF_F_HIGHDMA | NETIF_F_ALL_TSO |
+                                   NETIF_F_RXCSUM);
+        /* All offloads can be toggled */
+        net_dev->hw_features = net_dev->features & ~NETIF_F_HIGHDMA;
        efx = netdev_priv(net_dev);
        pci_set_drvdata(pci_dev, efx);
        SET_NETDEV_DEV(net_dev, &pci_dev->dev);
diff --git a/drivers/net/sfc/efx.h b/drivers/net/sfc/efx.h
index 3d83a1f74fef..b0d1209ea18d 100644
--- a/drivers/net/sfc/efx.h
+++ b/drivers/net/sfc/efx.h
@@ -142,6 +142,6 @@ static inline void efx_schedule_channel(struct efx_channel *channel)
 extern void efx_link_status_changed(struct efx_nic *efx);
 extern void efx_link_set_advertising(struct efx_nic *efx, u32);
-extern void efx_link_set_wanted_fc(struct efx_nic *efx, enum efx_fc_type);
+extern void efx_link_set_wanted_fc(struct efx_nic *efx, u8);
 #endif /* EFX_EFX_H */
diff --git a/drivers/net/sfc/ethtool.c b/drivers/net/sfc/ethtool.c
index 807178ef65ad..d229027dc363 100644
--- a/drivers/net/sfc/ethtool.c
+++ b/drivers/net/sfc/ethtool.c
@@ -178,19 +178,27 @@ static struct efx_ethtool_stat efx_ethtool_stats[] = {
 */
 /* Identify device by flashing LEDs */
-static int efx_ethtool_phys_id(struct net_device *net_dev, u32 count)
+static int efx_ethtool_phys_id(struct net_device *net_dev,
+                               enum ethtool_phys_id_state state)
 {
        struct efx_nic *efx = netdev_priv(net_dev);
+        enum efx_led_mode mode = EFX_LED_DEFAULT;
-        do {
+        switch (state) {
-                efx->type->set_id_led(efx, EFX_LED_ON);
+        case ETHTOOL_ID_ON:
-                schedule_timeout_interruptible(HZ / 2);
+                mode = EFX_LED_ON;
+                break;
-                efx->type->set_id_led(efx, EFX_LED_OFF);
+        case ETHTOOL_ID_OFF:
-                schedule_timeout_interruptible(HZ / 2);
+                mode = EFX_LED_OFF;
-        } while (!signal_pending(current) && --count != 0);
+                break;
+        case ETHTOOL_ID_INACTIVE:
+                mode = EFX_LED_DEFAULT;
+                break;
+        case ETHTOOL_ID_ACTIVE:
+                return 1;       /* cycle on/off once per second */
+        }
-        efx->type->set_id_led(efx, EFX_LED_DEFAULT);
+        efx->type->set_id_led(efx, mode);
        return 0;
 }
@@ -211,7 +219,7 @@ static int efx_ethtool_get_settings(struct net_device *net_dev,
        ecmd->supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;
        if (LOOPBACK_INTERNAL(efx)) {
-                ecmd->speed = link_state->speed;
+                ethtool_cmd_speed_set(ecmd, link_state->speed);
                ecmd->duplex = link_state->fd ? DUPLEX_FULL : DUPLEX_HALF;
        }
@@ -226,7 +234,8 @@ static int efx_ethtool_set_settings(struct net_device *net_dev,
        int rc;
        /* GMAC does not support 1000Mbps HD */
-        if (ecmd->speed == SPEED_1000 && ecmd->duplex != DUPLEX_FULL) {
+        if ((ethtool_cmd_speed(ecmd) == SPEED_1000) &&
+            (ecmd->duplex != DUPLEX_FULL)) {
                netif_dbg(efx, drv, efx->net_dev,
                          "rejecting unsupported 1000Mbps HD setting\n");
                return -EINVAL;
@@ -518,72 +527,6 @@ static void efx_ethtool_get_stats(struct net_device *net_dev,
        }
 }
-static int efx_ethtool_set_tso(struct net_device *net_dev, u32 enable)
-{
-        struct efx_nic *efx __attribute__ ((unused)) = netdev_priv(net_dev);
-        u32 features;
-        features = NETIF_F_TSO;
-        if (efx->type->offload_features & NETIF_F_V6_CSUM)
-                features |= NETIF_F_TSO6;
-        if (enable)
-                net_dev->features |= features;
-        else
-                net_dev->features &= ~features;
-        return 0;
-}
-static int efx_ethtool_set_tx_csum(struct net_device *net_dev, u32 enable)
-{
-        struct efx_nic *efx = netdev_priv(net_dev);
-        u32 features = efx->type->offload_features & NETIF_F_ALL_CSUM;
-        if (enable)
-                net_dev->features |= features;
-        else
-                net_dev->features &= ~features;
-        return 0;
-}
-static int efx_ethtool_set_rx_csum(struct net_device *net_dev, u32 enable)
-{
-        struct efx_nic *efx = netdev_priv(net_dev);
-        /* No way to stop the hardware doing the checks; we just
-         * ignore the result.
-         */
-        efx->rx_checksum_enabled = !!enable;
-        return 0;
-}
-static u32 efx_ethtool_get_rx_csum(struct net_device *net_dev)
-{
-        struct efx_nic *efx = netdev_priv(net_dev);
-        return efx->rx_checksum_enabled;
-}
-static int efx_ethtool_set_flags(struct net_device *net_dev, u32 data)
-{
-        struct efx_nic *efx = netdev_priv(net_dev);
-        u32 supported = (efx->type->offload_features &
-                         (ETH_FLAG_RXHASH | ETH_FLAG_NTUPLE));
-        int rc;
-        rc = ethtool_op_set_flags(net_dev, data, supported);
-        if (rc)
-                return rc;
-        if (!(data & ETH_FLAG_NTUPLE))
-                efx_filter_clear_rx(efx, EFX_FILTER_PRI_MANUAL);
-        return 0;
-}
 static void efx_ethtool_self_test(struct net_device *net_dev,
                                  struct ethtool_test *test, u64 *data)
 {
@@ -755,7 +698,7 @@ static int efx_ethtool_set_pauseparam(struct net_device *net_dev,
                                      struct ethtool_pauseparam *pause)
 {
        struct efx_nic *efx = netdev_priv(net_dev);
-        enum efx_fc_type wanted_fc, old_fc;
+        u8 wanted_fc, old_fc;
        u32 old_adv;
        bool reset;
        int rc = 0;
@@ -1012,8 +955,9 @@ static int efx_ethtool_set_rx_ntuple(struct net_device *net_dev,
        if (ntuple->fs.action == ETHTOOL_RXNTUPLE_ACTION_CLEAR)
                return efx_filter_remove_filter(efx, &filter);
-        else
-                return efx_filter_insert_filter(efx, &filter, true);
+        rc = efx_filter_insert_filter(efx, &filter, true);
+        return rc < 0 ? rc : 0;
 }
 static int efx_ethtool_get_rxfh_indir(struct net_device *net_dev,
@@ -1070,22 +1014,10 @@ const struct ethtool_ops efx_ethtool_ops = {
        .set_ringparam          = efx_ethtool_set_ringparam,
        .get_pauseparam         = efx_ethtool_get_pauseparam,
        .set_pauseparam         = efx_ethtool_set_pauseparam,
-        .get_rx_csum            = efx_ethtool_get_rx_csum,
-        .set_rx_csum            = efx_ethtool_set_rx_csum,
-        .get_tx_csum            = ethtool_op_get_tx_csum,
-        /* Need to enable/disable IPv6 too */
-        .set_tx_csum            = efx_ethtool_set_tx_csum,
-        .get_sg                 = ethtool_op_get_sg,
-        .set_sg                 = ethtool_op_set_sg,
-        .get_tso                = ethtool_op_get_tso,
-        /* Need to enable/disable TSO-IPv6 too */
-        .set_tso                = efx_ethtool_set_tso,
-        .get_flags              = ethtool_op_get_flags,
-        .set_flags              = efx_ethtool_set_flags,
        .get_sset_count         = efx_ethtool_get_sset_count,
        .self_test              = efx_ethtool_self_test,
        .get_strings            = efx_ethtool_get_strings,
-        .phys_id                = efx_ethtool_phys_id,
+        .set_phys_id            = efx_ethtool_phys_id,
        .get_ethtool_stats      = efx_ethtool_get_stats,
        .get_wol                = efx_ethtool_get_wol,
        .set_wol                = efx_ethtool_set_wol,
diff --git a/drivers/net/sfc/falcon.c b/drivers/net/sfc/falcon.c
index d96b23769bd1..60176e873d62 100644
--- a/drivers/net/sfc/falcon.c
+++ b/drivers/net/sfc/falcon.c
@@ -1703,7 +1703,7 @@ static int falcon_set_wol(struct efx_nic *efx, u32 type)
 **************************************************************************
 */
-struct efx_nic_type falcon_a1_nic_type = {
+const struct efx_nic_type falcon_a1_nic_type = {
        .probe = falcon_probe_nic,
        .remove = falcon_remove_nic,
        .init = falcon_init_nic,
@@ -1744,7 +1744,7 @@ struct efx_nic_type falcon_a1_nic_type = {
        .reset_world_flags = ETH_RESET_IRQ,
 };
-struct efx_nic_type falcon_b0_nic_type = {
+const struct efx_nic_type falcon_b0_nic_type = {
        .probe = falcon_probe_nic,
        .remove = falcon_remove_nic,
        .init = falcon_init_nic,
diff --git a/drivers/net/sfc/falcon_xmac.c b/drivers/net/sfc/falcon_xmac.c
index 2c9ee5db3bf7..9516452c079c 100644
--- a/drivers/net/sfc/falcon_xmac.c
+++ b/drivers/net/sfc/falcon_xmac.c
@@ -362,7 +362,7 @@ void falcon_poll_xmac(struct efx_nic *efx)
        falcon_ack_status_intr(efx);
 }
-struct efx_mac_operations falcon_xmac_operations = {
+const struct efx_mac_operations falcon_xmac_operations = {
        .reconfigure    = falcon_reconfigure_xmac,
        .update_stats   = falcon_update_stats_xmac,
        .check_fault    = falcon_xmac_check_fault,
diff --git a/drivers/net/sfc/mac.h b/drivers/net/sfc/mac.h
index 6886cdf87c12..d6a255d0856b 100644
--- a/drivers/net/sfc/mac.h
+++ b/drivers/net/sfc/mac.h
@@ -13,8 +13,8 @@
 #include "net_driver.h"
-extern struct efx_mac_operations falcon_xmac_operations;
+extern const struct efx_mac_operations falcon_xmac_operations;
-extern struct efx_mac_operations efx_mcdi_mac_operations;
+extern const struct efx_mac_operations efx_mcdi_mac_operations;
 extern int efx_mcdi_mac_stats(struct efx_nic *efx, dma_addr_t dma_addr,
                              u32 dma_len, int enable, int clear);
diff --git a/drivers/net/sfc/mcdi_mac.c b/drivers/net/sfc/mcdi_mac.c
index 33f7294edb47..50c20777a564 100644
--- a/drivers/net/sfc/mcdi_mac.c
+++ b/drivers/net/sfc/mcdi_mac.c
@@ -138,7 +138,7 @@ static bool efx_mcdi_mac_check_fault(struct efx_nic *efx)
 }
-struct efx_mac_operations efx_mcdi_mac_operations = {
+const struct efx_mac_operations efx_mcdi_mac_operations = {
        .reconfigure    = efx_mcdi_mac_reconfigure,
        .update_stats   = efx_port_dummy_op_void,
        .check_fault    = efx_mcdi_mac_check_fault,
diff --git a/drivers/net/sfc/mcdi_phy.c b/drivers/net/sfc/mcdi_phy.c
index 7e3c65b0c99f..6c63ab0710af 100644
--- a/drivers/net/sfc/mcdi_phy.c
+++ b/drivers/net/sfc/mcdi_phy.c
@@ -513,7 +513,7 @@ static void efx_mcdi_phy_get_settings(struct efx_nic *efx, struct ethtool_cmd *e
        ecmd->supported =
                mcdi_to_ethtool_cap(phy_cfg->media, phy_cfg->supported_cap);
        ecmd->advertising = efx->link_advertising;
-        ecmd->speed = efx->link_state.speed;
+        ethtool_cmd_speed_set(ecmd, efx->link_state.speed);
        ecmd->duplex = efx->link_state.fd;
        ecmd->port = mcdi_to_ethtool_media(phy_cfg->media);
        ecmd->phy_address = phy_cfg->port;
@@ -545,7 +545,7 @@ static int efx_mcdi_phy_set_settings(struct efx_nic *efx, struct ethtool_cmd *ec
                caps = (ethtool_to_mcdi_cap(ecmd->advertising) |
                         1 << MC_CMD_PHY_CAP_AN_LBN);
        } else if (ecmd->duplex) {
-                switch (ecmd->speed) {
+                switch (ethtool_cmd_speed(ecmd)) {
                case 10:    caps = 1 << MC_CMD_PHY_CAP_10FDX_LBN;    break;
                case 100:   caps = 1 << MC_CMD_PHY_CAP_100FDX_LBN;   break;
                case 1000:  caps = 1 << MC_CMD_PHY_CAP_1000FDX_LBN;  break;
@@ -553,7 +553,7 @@ static int efx_mcdi_phy_set_settings(struct efx_nic *efx, struct ethtool_cmd *ec
                default:    return -EINVAL;
                }
        } else {
-                switch (ecmd->speed) {
+                switch (ethtool_cmd_speed(ecmd)) {
                case 10:    caps = 1 << MC_CMD_PHY_CAP_10HDX_LBN;    break;
                case 100:   caps = 1 << MC_CMD_PHY_CAP_100HDX_LBN;   break;
                case 1000:  caps = 1 << MC_CMD_PHY_CAP_1000HDX_LBN;  break;
@@ -739,7 +739,7 @@ static const char *efx_mcdi_phy_test_name(struct efx_nic *efx,
        return NULL;
 }
-struct efx_phy_operations efx_mcdi_phy_ops = {
+const struct efx_phy_operations efx_mcdi_phy_ops = {
        .probe          = efx_mcdi_phy_probe,
        .init           = efx_port_dummy_op_int,
        .reconfigure    = efx_mcdi_phy_reconfigure,
diff --git a/drivers/net/sfc/mdio_10g.c b/drivers/net/sfc/mdio_10g.c
index 19e68c26d103..7ab385c8136d 100644
--- a/drivers/net/sfc/mdio_10g.c
+++ b/drivers/net/sfc/mdio_10g.c
@@ -232,12 +232,12 @@ void efx_mdio_set_mmds_lpower(struct efx_nic *efx,
 */
 int efx_mdio_set_settings(struct efx_nic *efx, struct ethtool_cmd *ecmd)
 {
-        struct ethtool_cmd prev;
+        struct ethtool_cmd prev = { .cmd = ETHTOOL_GSET };
        efx->phy_op->get_settings(efx, &prev);
        if (ecmd->advertising == prev.advertising &&
-            ecmd->speed == prev.speed &&
+            ethtool_cmd_speed(ecmd) == ethtool_cmd_speed(&prev) &&
            ecmd->duplex == prev.duplex &&
            ecmd->port == prev.port &&
            ecmd->autoneg == prev.autoneg)
@@ -284,7 +284,7 @@ void efx_mdio_an_reconfigure(struct efx_nic *efx)
        efx_mdio_write(efx, MDIO_MMD_AN, MDIO_CTRL1, reg);
 }
-enum efx_fc_type efx_mdio_get_pause(struct efx_nic *efx)
+u8 efx_mdio_get_pause(struct efx_nic *efx)
 {
        BUILD_BUG_ON(EFX_FC_AUTO & (EFX_FC_RX | EFX_FC_TX));
diff --git a/drivers/net/sfc/mdio_10g.h b/drivers/net/sfc/mdio_10g.h
index df0703940c83..a97dbbd2de99 100644
--- a/drivers/net/sfc/mdio_10g.h
+++ b/drivers/net/sfc/mdio_10g.h
@@ -92,7 +92,7 @@ extern void efx_mdio_an_reconfigure(struct efx_nic *efx);
 /* Get pause parameters from AN if available (otherwise return
 * requested pause parameters)
 */
-enum efx_fc_type efx_mdio_get_pause(struct efx_nic *efx);
+u8 efx_mdio_get_pause(struct efx_nic *efx);
 /* Wait for specified MMDs to exit reset within a timeout */
 extern int efx_mdio_wait_reset_mmds(struct efx_nic *efx,
diff --git a/drivers/net/sfc/net_driver.h b/drivers/net/sfc/net_driver.h
index 191a311da2dc..e8d5f03a89fe 100644
--- a/drivers/net/sfc/net_driver.h
+++ b/drivers/net/sfc/net_driver.h
@@ -449,11 +449,9 @@ enum nic_state {
 struct efx_nic;
 /* Pseudo bit-mask flow control field */
-enum efx_fc_type {
+#define EFX_FC_RX       FLOW_CTRL_RX
-        EFX_FC_RX = FLOW_CTRL_RX,
+#define EFX_FC_TX       FLOW_CTRL_TX
-        EFX_FC_TX = FLOW_CTRL_TX,
+#define EFX_FC_AUTO     4
-        EFX_FC_AUTO = 4,
-};
 /**
 * struct efx_link_state - Current state of the link
@@ -465,7 +463,7 @@ enum efx_fc_type {
 struct efx_link_state {
        bool up;
        bool fd;
-        enum efx_fc_type fc;
+        u8 fc;
        unsigned int speed;
 };
@@ -670,16 +668,14 @@ struct efx_filter_state;
 * @mtd_list: List of MTDs attached to the NIC
 * @nic_data: Hardware dependent state
 * @mac_lock: MAC access lock. Protects @port_enabled, @phy_mode,
- *      @port_inhibited, efx_monitor() and efx_reconfigure_port()
+ *      efx_monitor() and efx_reconfigure_port()
 * @port_enabled: Port enabled indicator.
 *      Serialises efx_stop_all(), efx_start_all(), efx_monitor() and
 *      efx_mac_work() with kernel interfaces. Safe to read under any
 *      one of the rtnl_lock, mac_lock, or netif_tx_lock, but all three must
 *      be held to modify it.
- * @port_inhibited: If set, the netif_carrier is always off. Hold the mac_lock
 * @port_initialized: Port initialized?
 * @net_dev: Operating system network device. Consider holding the rtnl lock
- * @rx_checksum_enabled: RX checksumming enabled
 * @stats_buffer: DMA buffer for statistics
 * @mac_op: MAC interface
 * @phy_type: PHY type
@@ -765,18 +761,16 @@ struct efx_nic {
        struct mutex mac_lock;
        struct work_struct mac_work;
        bool port_enabled;
-        bool port_inhibited;
        bool port_initialized;
        struct net_device *net_dev;
-        bool rx_checksum_enabled;
        struct efx_buffer stats_buffer;
-        struct efx_mac_operations *mac_op;
+        const struct efx_mac_operations *mac_op;
        unsigned int phy_type;
-        struct efx_phy_operations *phy_op;
+        const struct efx_phy_operations *phy_op;
        void *phy_data;
        struct mdio_if_info mdio;
        unsigned int mdio_bus;
@@ -788,7 +782,7 @@ struct efx_nic {
        bool promiscuous;
        union efx_multicast_hash multicast_hash;
-        enum efx_fc_type wanted_fc;
+        u8 wanted_fc;
        atomic_t rx_reset;
        enum efx_loopback_mode loopback_mode;
@@ -897,7 +891,7 @@ struct efx_nic_type {
        void (*resume_wol)(struct efx_nic *efx);
        int (*test_registers)(struct efx_nic *efx);
        int (*test_nvram)(struct efx_nic *efx);
-        struct efx_mac_operations *default_mac_ops;
+        const struct efx_mac_operations *default_mac_ops;
        int revision;
        unsigned int mem_map_size;
diff --git a/drivers/net/sfc/nic.c b/drivers/net/sfc/nic.c
index 9b29a8d7c449..f2a2b947f860 100644
--- a/drivers/net/sfc/nic.c
+++ b/drivers/net/sfc/nic.c
@@ -852,7 +852,6 @@ efx_handle_rx_event(struct efx_channel *channel, const efx_qword_t *event)
        unsigned expected_ptr;
        bool rx_ev_pkt_ok, discard = false, checksummed;
        struct efx_rx_queue *rx_queue;
-        struct efx_nic *efx = channel->efx;
        /* Basic packet information */
        rx_ev_byte_cnt = EFX_QWORD_FIELD(*event, FSF_AZ_RX_EV_BYTE_CNT);
@@ -875,9 +874,8 @@ efx_handle_rx_event(struct efx_channel *channel, const efx_qword_t *event)
                 * UDP/IP, then we can rely on the hardware checksum.
                 */
                checksummed =
-                        likely(efx->rx_checksum_enabled) &&
+                        rx_ev_hdr_type == FSE_CZ_RX_EV_HDR_TYPE_IPV4V6_TCP ||
-                        (rx_ev_hdr_type == FSE_CZ_RX_EV_HDR_TYPE_IPV4V6_TCP ||
+                        rx_ev_hdr_type == FSE_CZ_RX_EV_HDR_TYPE_IPV4V6_UDP;
-                         rx_ev_hdr_type == FSE_CZ_RX_EV_HDR_TYPE_IPV4V6_UDP);
        } else {
                efx_handle_rx_not_ok(rx_queue, event, &rx_ev_pkt_ok, &discard);
                checksummed = false;
diff --git a/drivers/net/sfc/nic.h b/drivers/net/sfc/nic.h
index d91701abd331..4bd1f2839dfe 100644
--- a/drivers/net/sfc/nic.h
+++ b/drivers/net/sfc/nic.h
@@ -152,9 +152,9 @@ struct siena_nic_data {
        int wol_filter_id;
 };
-extern struct efx_nic_type falcon_a1_nic_type;
+extern const struct efx_nic_type falcon_a1_nic_type;
-extern struct efx_nic_type falcon_b0_nic_type;
+extern const struct efx_nic_type falcon_b0_nic_type;
-extern struct efx_nic_type siena_a0_nic_type;
+extern const struct efx_nic_type siena_a0_nic_type;
 /**************************************************************************
 *
diff --git a/drivers/net/sfc/phy.h b/drivers/net/sfc/phy.h
index b3b79472421e..11d148cd8441 100644
--- a/drivers/net/sfc/phy.h
+++ b/drivers/net/sfc/phy.h
@@ -13,14 +13,14 @@
 /****************************************************************************
 * 10Xpress (SFX7101) PHY
 */
-extern struct efx_phy_operations falcon_sfx7101_phy_ops;
+extern const struct efx_phy_operations falcon_sfx7101_phy_ops;
 extern void tenxpress_set_id_led(struct efx_nic *efx, enum efx_led_mode mode);
 /****************************************************************************
 * AMCC/Quake QT202x PHYs
 */
-extern struct efx_phy_operations falcon_qt202x_phy_ops;
+extern const struct efx_phy_operations falcon_qt202x_phy_ops;
 /* These PHYs provide various H/W control states for LEDs */
 #define QUAKE_LED_LINK_INVAL    (0)
@@ -39,7 +39,7 @@ extern void falcon_qt202x_set_led(struct efx_nic *p, int led, int state);
 /****************************************************************************
 * Transwitch CX4 retimer
 */
-extern struct efx_phy_operations falcon_txc_phy_ops;
+extern const struct efx_phy_operations falcon_txc_phy_ops;
 #define TXC_GPIO_DIR_INPUT      0
 #define TXC_GPIO_DIR_OUTPUT     1
@@ -50,7 +50,7 @@ extern void falcon_txc_set_gpio_val(struct efx_nic *efx, int pin, int val);
 /****************************************************************************
 * Siena managed PHYs
 */
-extern struct efx_phy_operations efx_mcdi_phy_ops;
+extern const struct efx_phy_operations efx_mcdi_phy_ops;
 extern int efx_mcdi_mdio_read(struct efx_nic *efx, unsigned int bus,
                              unsigned int prtad, unsigned int devad,
diff --git a/drivers/net/sfc/qt202x_phy.c b/drivers/net/sfc/qt202x_phy.c
index 55f90924247e..7ad97e397406 100644
--- a/drivers/net/sfc/qt202x_phy.c
+++ b/drivers/net/sfc/qt202x_phy.c
@@ -449,7 +449,7 @@ static void qt202x_phy_remove(struct efx_nic *efx)
        efx->phy_data = NULL;
 }
-struct efx_phy_operations falcon_qt202x_phy_ops = {
+const struct efx_phy_operations falcon_qt202x_phy_ops = {
        .probe           = qt202x_phy_probe,
        .init            = qt202x_phy_init,
        .reconfigure     = qt202x_phy_reconfigure,
diff --git a/drivers/net/sfc/rx.c b/drivers/net/sfc/rx.c
index c0fdb59030fb..b7dc891b4461 100644
--- a/drivers/net/sfc/rx.c
+++ b/drivers/net/sfc/rx.c
@@ -605,6 +605,9 @@ void __efx_rx_packet(struct efx_channel *channel,
                skb_record_rx_queue(skb, channel->channel);
        }
+        if (unlikely(!(efx->net_dev->features & NETIF_F_RXCSUM)))
+                checksummed = false;
        if (likely(checksummed || rx_buf->is_page)) {
                efx_rx_packet_gro(channel, rx_buf, eh, checksummed);
                return;
diff --git a/drivers/net/sfc/selftest.c b/drivers/net/sfc/selftest.c
index 50ad3bcaf68a..822f6c2a6a7c 100644
--- a/drivers/net/sfc/selftest.c
+++ b/drivers/net/sfc/selftest.c
@@ -695,12 +695,12 @@ int efx_selftest(struct efx_nic *efx, struct efx_self_tests *tests,
        /* Offline (i.e. disruptive) testing
         * This checks MAC and PHY loopback on the specified port. */
-        /* force the carrier state off so the kernel doesn't transmit during
+        /* Detach the device so the kernel doesn't transmit during the
-         * the loopback test, and the watchdog timeout doesn't fire. Also put
+         * loopback test and the watchdog timeout doesn't fire.
-         * falcon into loopback for the register test.
         */
+        netif_device_detach(efx->net_dev);
        mutex_lock(&efx->mac_lock);
-        efx->port_inhibited = true;
        if (efx->loopback_modes) {
                /* We need the 312 clock from the PHY to test the XMAC
                 * registers, so move into XGMII loopback if available */
@@ -750,12 +750,11 @@ int efx_selftest(struct efx_nic *efx, struct efx_self_tests *tests,
        /* restore the PHY to the previous state */
        mutex_lock(&efx->mac_lock);
        efx->phy_mode = phy_mode;
-        efx->port_inhibited = false;
        efx->loopback_mode = loopback_mode;
        __efx_reconfigure_port(efx);
        mutex_unlock(&efx->mac_lock);
-        netif_tx_wake_all_queues(efx->net_dev);
+        netif_device_attach(efx->net_dev);
        return rc_test;
 }
diff --git a/drivers/net/sfc/siena.c b/drivers/net/sfc/siena.c
index 837869b71db9..fb4721f780ff 100644
--- a/drivers/net/sfc/siena.c
+++ b/drivers/net/sfc/siena.c
@@ -599,7 +599,7 @@ static void siena_init_wol(struct efx_nic *efx)
 **************************************************************************
 */
-struct efx_nic_type siena_a0_nic_type = {
+const struct efx_nic_type siena_a0_nic_type = {
        .probe = siena_probe_nic,
        .remove = siena_remove_nic,
        .init = siena_init_nic,
diff --git a/drivers/net/sfc/tenxpress.c b/drivers/net/sfc/tenxpress.c
index efdceb35aaae..7b0fd89e7b85 100644
--- a/drivers/net/sfc/tenxpress.c
+++ b/drivers/net/sfc/tenxpress.c
@@ -460,7 +460,7 @@ tenxpress_get_settings(struct efx_nic *efx, struct ethtool_cmd *ecmd)
        /* In loopback, the PHY automatically brings up the correct interface,
         * but doesn't advertise the correct speed. So override it */
        if (LOOPBACK_EXTERNAL(efx))
-                ecmd->speed = SPEED_10000;
+                ethtool_cmd_speed_set(ecmd, SPEED_10000);
 }
 static int tenxpress_set_settings(struct efx_nic *efx, struct ethtool_cmd *ecmd)
@@ -478,7 +478,7 @@ static void sfx7101_set_npage_adv(struct efx_nic *efx, u32 advertising)
                          advertising & ADVERTISED_10000baseT_Full);
 }
-struct efx_phy_operations falcon_sfx7101_phy_ops = {
+const struct efx_phy_operations falcon_sfx7101_phy_ops = {
        .probe            = tenxpress_phy_probe,
        .init             = tenxpress_phy_init,
        .reconfigure      = tenxpress_phy_reconfigure,
diff --git a/drivers/net/sfc/tx.c b/drivers/net/sfc/tx.c
index d2c85dfdf3bf..84eb99e0f8d2 100644
--- a/drivers/net/sfc/tx.c
+++ b/drivers/net/sfc/tx.c
@@ -205,7 +205,9 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb)
                                        goto unwind;
                                }
                                smp_mb();
-                                netif_tx_start_queue(tx_queue->core_txq);
+                                if (likely(!efx->loopback_selftest))
+                                        netif_tx_start_queue(
+                                                tx_queue->core_txq);
                        }
                        insert_ptr = tx_queue->insert_count & tx_queue->ptr_mask;
@@ -338,8 +340,7 @@ netdev_tx_t efx_hard_start_xmit(struct sk_buff *skb,
        struct efx_tx_queue *tx_queue;
        unsigned index, type;
-        if (unlikely(efx->port_inhibited))
+        EFX_WARN_ON_PARANOID(!netif_device_present(net_dev));
-                return NETDEV_TX_BUSY;
        index = skb_get_queue_mapping(skb);
        type = skb->ip_summed == CHECKSUM_PARTIAL ? EFX_TXQ_TYPE_OFFLOAD : 0;
@@ -436,7 +437,7 @@ void efx_xmit_done(struct efx_tx_queue *tx_queue, unsigned int index)
        smp_mb();
        if (unlikely(netif_tx_queue_stopped(tx_queue->core_txq)) &&
            likely(efx->port_enabled) &&
-            likely(!efx->port_inhibited)) {
+            likely(netif_device_present(efx->net_dev))) {
                fill_level = tx_queue->insert_count - tx_queue->read_count;
                if (fill_level < EFX_TXQ_THRESHOLD(efx)) {
                        EFX_BUG_ON_PARANOID(!efx_dev_registered(efx));
diff --git a/drivers/net/sfc/txc43128_phy.c b/drivers/net/sfc/txc43128_phy.c
index d9886addcc99..7c21b334a75b 100644
--- a/drivers/net/sfc/txc43128_phy.c
+++ b/drivers/net/sfc/txc43128_phy.c
@@ -545,7 +545,7 @@ static void txc43128_get_settings(struct efx_nic *efx, struct ethtool_cmd *ecmd)
        mdio45_ethtool_gset(&efx->mdio, ecmd);
 }
-struct efx_phy_operations falcon_txc_phy_ops = {
+const struct efx_phy_operations falcon_txc_phy_ops = {
        .probe          = txc43128_phy_probe,
        .init           = txc43128_phy_init,
        .reconfigure    = txc43128_phy_reconfigure,
diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index 35b28f42d208..52a48cb75440 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -303,7 +303,7 @@ static int skge_get_settings(struct net_device *dev,
        ecmd->advertising = skge->advertising;
        ecmd->autoneg = skge->autoneg;
-        ecmd->speed = skge->speed;
+        ethtool_cmd_speed_set(ecmd, skge->speed);
        ecmd->duplex = skge->duplex;
        return 0;
 }
@@ -321,8 +321,9 @@ static int skge_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                skge->speed = -1;
        } else {
                u32 setting;
+                u32 speed = ethtool_cmd_speed(ecmd);
-                switch (ecmd->speed) {
+                switch (speed) {
                case SPEED_1000:
                        if (ecmd->duplex == DUPLEX_FULL)
                                setting = SUPPORTED_1000baseT_Full;
@@ -355,7 +356,7 @@ static int skge_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                if ((setting & supported) == 0)
                        return -EINVAL;
-                skge->speed = ecmd->speed;
+                skge->speed = speed;
                skge->duplex = ecmd->duplex;
        }
@@ -537,46 +538,6 @@ static int skge_nway_reset(struct net_device *dev)
        return 0;
 }
-static int skge_set_sg(struct net_device *dev, u32 data)
-{
-        struct skge_port *skge = netdev_priv(dev);
-        struct skge_hw *hw = skge->hw;
-        if (hw->chip_id == CHIP_ID_GENESIS && data)
-                return -EOPNOTSUPP;
-        return ethtool_op_set_sg(dev, data);
-}
-static int skge_set_tx_csum(struct net_device *dev, u32 data)
-{
-        struct skge_port *skge = netdev_priv(dev);
-        struct skge_hw *hw = skge->hw;
-        if (hw->chip_id == CHIP_ID_GENESIS && data)
-                return -EOPNOTSUPP;
-        return ethtool_op_set_tx_csum(dev, data);
-}
-static u32 skge_get_rx_csum(struct net_device *dev)
-{
-        struct skge_port *skge = netdev_priv(dev);
-        return skge->rx_csum;
-}
-/* Only Yukon supports checksum offload. */
-static int skge_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct skge_port *skge = netdev_priv(dev);
-        if (skge->hw->chip_id == CHIP_ID_GENESIS && data)
-                return -EOPNOTSUPP;
-        skge->rx_csum = data;
-        return 0;
-}
 static void skge_get_pauseparam(struct net_device *dev,
                                struct ethtool_pauseparam *ecmd)
 {
@@ -786,28 +747,27 @@ static void skge_led(struct skge_port *skge, enum led_mode mode)
 }
 /* blink LED's for finding board */
-static int skge_phys_id(struct net_device *dev, u32 data)
+static int skge_set_phys_id(struct net_device *dev,
+                            enum ethtool_phys_id_state state)
 {
        struct skge_port *skge = netdev_priv(dev);
-        unsigned long ms;
-        enum led_mode mode = LED_MODE_TST;
-        if (!data || data > (u32)(MAX_SCHEDULE_TIMEOUT / HZ))
+        switch (state) {
-                ms = jiffies_to_msecs(MAX_SCHEDULE_TIMEOUT / HZ) * 1000;
+        case ETHTOOL_ID_ACTIVE:
-        else
+                return 2;       /* cycle on/off twice per second */
-                ms = data * 1000;
-        while (ms > 0) {
+        case ETHTOOL_ID_ON:
-                skge_led(skge, mode);
+                skge_led(skge, LED_MODE_TST);
-                mode ^= LED_MODE_TST;
+                break;
-                if (msleep_interruptible(BLINK_MS))
+        case ETHTOOL_ID_OFF:
-                        break;
+                skge_led(skge, LED_MODE_OFF);
-                ms -= BLINK_MS;
+                break;
-        }
-        /* back to regular LED state */
+        case ETHTOOL_ID_INACTIVE:
-        skge_led(skge, netif_running(dev) ? LED_MODE_ON : LED_MODE_OFF);
+                /* back to regular LED state */
+                skge_led(skge, netif_running(dev) ? LED_MODE_ON : LED_MODE_OFF);
+        }
        return 0;
 }
@@ -925,12 +885,8 @@ static const struct ethtool_ops skge_ethtool_ops = {
        .set_pauseparam = skge_set_pauseparam,
        .get_coalesce   = skge_get_coalesce,
        .set_coalesce   = skge_set_coalesce,
-        .set_sg         = skge_set_sg,
-        .set_tx_csum    = skge_set_tx_csum,
-        .get_rx_csum    = skge_get_rx_csum,
-        .set_rx_csum    = skge_set_rx_csum,
        .get_strings    = skge_get_strings,
-        .phys_id        = skge_phys_id,
+        .set_phys_id    = skge_set_phys_id,
        .get_sset_count = skge_get_sset_count,
        .get_ethtool_stats = skge_get_ethtool_stats,
 };
@@ -3085,7 +3041,8 @@ static struct sk_buff *skge_rx_get(struct net_device *dev,
        }
        skb_put(skb, len);
-        if (skge->rx_csum) {
+        if (dev->features & NETIF_F_RXCSUM) {
                skb->csum = csum;
                skb->ip_summed = CHECKSUM_COMPLETE;
        }
@@ -3847,10 +3804,10 @@ static struct net_device *skge_devinit(struct skge_hw *hw, int port,
        setup_timer(&skge->link_timer, xm_link_timer, (unsigned long) skge);
        if (hw->chip_id != CHIP_ID_GENESIS) {
-                dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
+                dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG |
-                skge->rx_csum = 1;
+                                   NETIF_F_RXCSUM;
+                dev->features |= dev->hw_features;
        }
-        dev->features |= NETIF_F_GRO;
        /* read the mac address */
        memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port*8, ETH_ALEN);
diff --git a/drivers/net/skge.h b/drivers/net/skge.h
index 51c0214ac25c..598bf7a1a55e 100644
--- a/drivers/net/skge.h
+++ b/drivers/net/skge.h
@@ -2460,7 +2460,6 @@ struct skge_port {
        struct timer_list    link_timer;
        enum pause_control   flow_control;
        enum pause_status    flow_status;
-        u8                   rx_csum;
        u8                   blink_on;
        u8                   wol;
        u8                   autoneg;   /* AUTONEG_ENABLE, AUTONEG_DISABLE */
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index ff8d262dc276..3ee41da130c2 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -1198,12 +1198,12 @@ static void rx_set_checksum(struct sky2_port *sky2)
        sky2_write32(sky2->hw,
                     Q_ADDR(rxqaddr[sky2->port], Q_CSR),
-                     (sky2->flags & SKY2_FLAG_RX_CHECKSUM)
+                     (sky2->netdev->features & NETIF_F_RXCSUM)
                     ? BMU_ENA_RX_CHKSUM : BMU_DIS_RX_CHKSUM);
 }
 /* Enable/disable receive hash calculation (RSS) */
-static void rx_set_rss(struct net_device *dev)
+static void rx_set_rss(struct net_device *dev, u32 features)
 {
        struct sky2_port *sky2 = netdev_priv(dev);
        struct sky2_hw *hw = sky2->hw;
@@ -1216,7 +1216,7 @@ static void rx_set_rss(struct net_device *dev)
        }
        /* Program RSS initial values */
-        if (dev->features & NETIF_F_RXHASH) {
+        if (features & NETIF_F_RXHASH) {
                u32 key[nkeys];
                get_random_bytes(key, nkeys * sizeof(u32));
@@ -1322,32 +1322,32 @@ static int sky2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
        return err;
 }
-#define NETIF_F_ALL_VLAN (NETIF_F_HW_VLAN_TX|NETIF_F_HW_VLAN_RX)
+#define SKY2_VLAN_OFFLOADS (NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO)
-static void sky2_vlan_mode(struct net_device *dev)
+static void sky2_vlan_mode(struct net_device *dev, u32 features)
 {
        struct sky2_port *sky2 = netdev_priv(dev);
        struct sky2_hw *hw = sky2->hw;
        u16 port = sky2->port;
-        if (dev->features & NETIF_F_HW_VLAN_RX)
+        if (features & NETIF_F_HW_VLAN_RX)
                sky2_write32(hw, SK_REG(port, RX_GMF_CTRL_T),
                             RX_VLAN_STRIP_ON);
        else
                sky2_write32(hw, SK_REG(port, RX_GMF_CTRL_T),
                             RX_VLAN_STRIP_OFF);
-        dev->vlan_features = dev->features &~ NETIF_F_ALL_VLAN;
+        if (features & NETIF_F_HW_VLAN_TX) {
-        if (dev->features & NETIF_F_HW_VLAN_TX)
                sky2_write32(hw, SK_REG(port, TX_GMF_CTRL_T),
                             TX_VLAN_TAG_ON);
-        else {
+                dev->vlan_features |= SKY2_VLAN_OFFLOADS;
+        } else {
                sky2_write32(hw, SK_REG(port, TX_GMF_CTRL_T),
                             TX_VLAN_TAG_OFF);
                /* Can't do transmit offload of vlan without hw vlan */
-                dev->vlan_features &= ~(NETIF_F_TSO | NETIF_F_SG
+                dev->vlan_features &= ~SKY2_VLAN_OFFLOADS;
-                                        | NETIF_F_ALL_CSUM);
        }
 }
@@ -1463,7 +1463,7 @@ static void sky2_rx_start(struct sky2_port *sky2)
                rx_set_checksum(sky2);
        if (!(hw->flags & SKY2_HW_RSS_BROKEN))
-                rx_set_rss(sky2->netdev);
+                rx_set_rss(sky2->netdev, sky2->netdev->features);
        /* submit Rx ring */
        for (i = 0; i < sky2->rx_pending; i++) {
@@ -1626,7 +1626,8 @@ static void sky2_hw_up(struct sky2_port *sky2)
        sky2_prefetch_init(hw, txqaddr[port], sky2->tx_le_map,
                           sky2->tx_ring_size - 1);
-        sky2_vlan_mode(sky2->netdev);
+        sky2_vlan_mode(sky2->netdev, sky2->netdev->features);
+        netdev_update_features(sky2->netdev);
        sky2_rx_start(sky2);
 }
@@ -2261,12 +2262,9 @@ static int sky2_change_mtu(struct net_device *dev, int new_mtu)
             hw->chip_id == CHIP_ID_YUKON_FE_P))
                return -EINVAL;
-        /* TSO, etc on Yukon Ultra and MTU > 1500 not supported */
-        if (new_mtu > ETH_DATA_LEN && hw->chip_id == CHIP_ID_YUKON_EC_U)
-                dev->features &= ~(NETIF_F_TSO|NETIF_F_SG|NETIF_F_ALL_CSUM);
        if (!netif_running(dev)) {
                dev->mtu = new_mtu;
+                netdev_update_features(dev);
                return 0;
        }
@@ -2288,6 +2286,7 @@ static int sky2_change_mtu(struct net_device *dev, int new_mtu)
        sky2_rx_clean(sky2);
        dev->mtu = new_mtu;
+        netdev_update_features(dev);
        mode = DATA_BLIND_VAL(DATA_BLIND_DEF) |
                GM_SMOD_VLAN_ENA | IPG_DATA_VAL(IPG_DATA_DEF);
@@ -2535,8 +2534,11 @@ static void sky2_rx_checksum(struct sky2_port *sky2, u32 status)
                           "%s: receive checksum problem (status = %#x)\n",
                           sky2->netdev->name, status);
-                /* Disable checksum offload */
+                /* Disable checksum offload
-                sky2->flags &= ~SKY2_FLAG_RX_CHECKSUM;
+                 * It will be reenabled on next ndo_set_features, but if it's
+                 * really broken, will get disabled again
+                 */
+                sky2->netdev->features &= ~NETIF_F_RXCSUM;
                sky2_write32(sky2->hw, Q_ADDR(rxqaddr[sky2->port], Q_CSR),
                             BMU_DIS_RX_CHKSUM);
        }
@@ -2591,7 +2593,7 @@ static int sky2_status_intr(struct sky2_hw *hw, int to_do, u16 idx)
                        /* This chip reports checksum status differently */
                        if (hw->flags & SKY2_HW_NEW_LE) {
-                                if ((sky2->flags & SKY2_FLAG_RX_CHECKSUM) &&
+                                if ((dev->features & NETIF_F_RXCSUM) &&
                                    (le->css & (CSS_ISIPV4 | CSS_ISIPV6)) &&
                                    (le->css & CSS_TCPUDPCSOK))
                                        skb->ip_summed = CHECKSUM_UNNECESSARY;
@@ -2616,7 +2618,7 @@ static int sky2_status_intr(struct sky2_hw *hw, int to_do, u16 idx)
                        sky2->rx_tag = length;
                        /* fall through */
                case OP_RXCHKS:
-                        if (likely(sky2->flags & SKY2_FLAG_RX_CHECKSUM))
+                        if (likely(dev->features & NETIF_F_RXCSUM))
                                sky2_rx_checksum(sky2, status);
                        break;
@@ -3411,10 +3413,10 @@ static int sky2_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
        ecmd->phy_address = PHY_ADDR_MARV;
        if (sky2_is_copper(hw)) {
                ecmd->port = PORT_TP;
-                ecmd->speed = sky2->speed;
+                ethtool_cmd_speed_set(ecmd, sky2->speed);
                ecmd->supported |=  SUPPORTED_Autoneg | SUPPORTED_TP;
        } else {
-                ecmd->speed = SPEED_1000;
+                ethtool_cmd_speed_set(ecmd, SPEED_1000);
                ecmd->port = PORT_FIBRE;
                ecmd->supported |=  SUPPORTED_Autoneg | SUPPORTED_FIBRE;
        }
@@ -3450,8 +3452,9 @@ static int sky2_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                sky2->speed = -1;
        } else {
                u32 setting;
+                u32 speed = ethtool_cmd_speed(ecmd);
-                switch (ecmd->speed) {
+                switch (speed) {
                case SPEED_1000:
                        if (ecmd->duplex == DUPLEX_FULL)
                                setting = SUPPORTED_1000baseT_Full;
@@ -3484,7 +3487,7 @@ static int sky2_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
                if ((setting & supported) == 0)
                        return -EINVAL;
-                sky2->speed = ecmd->speed;
+                sky2->speed = speed;
                sky2->duplex = ecmd->duplex;
                sky2->flags &= ~SKY2_FLAG_AUTO_SPEED;
        }
@@ -3552,28 +3555,6 @@ static const struct sky2_stat {
        { "tx_fifo_underrun", GM_TXE_FIFO_UR },
 };
-static u32 sky2_get_rx_csum(struct net_device *dev)
-{
-        struct sky2_port *sky2 = netdev_priv(dev);
-        return !!(sky2->flags & SKY2_FLAG_RX_CHECKSUM);
-}
-static int sky2_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct sky2_port *sky2 = netdev_priv(dev);
-        if (data)
-                sky2->flags |= SKY2_FLAG_RX_CHECKSUM;
-        else
-                sky2->flags &= ~SKY2_FLAG_RX_CHECKSUM;
-        sky2_write32(sky2->hw, Q_ADDR(rxqaddr[sky2->port], Q_CSR),
-                     data ? BMU_ENA_RX_CHKSUM : BMU_DIS_RX_CHKSUM);
-        return 0;
-}
 static u32 sky2_get_msglevel(struct net_device *netdev)
 {
        struct sky2_port *sky2 = netdev_priv(netdev);
@@ -3826,23 +3807,24 @@ static void sky2_led(struct sky2_port *sky2, enum led_mode mode)
 }
 /* blink LED's for finding board */
-static int sky2_phys_id(struct net_device *dev, u32 data)
+static int sky2_set_phys_id(struct net_device *dev,
+                            enum ethtool_phys_id_state state)
 {
        struct sky2_port *sky2 = netdev_priv(dev);
-        unsigned int i;
-        if (data == 0)
-                data = UINT_MAX;
-        for (i = 0; i < data; i++) {
+        switch (state) {
+        case ETHTOOL_ID_ACTIVE:
+                return 1;       /* cycle on/off once per second */
+        case ETHTOOL_ID_INACTIVE:
+                sky2_led(sky2, MO_LED_NORM);
+                break;
+        case ETHTOOL_ID_ON:
                sky2_led(sky2, MO_LED_ON);
-                if (msleep_interruptible(500))
+                break;
-                        break;
+        case ETHTOOL_ID_OFF:
                sky2_led(sky2, MO_LED_OFF);
-                if (msleep_interruptible(500))
+                break;
-                        break;
        }
-        sky2_led(sky2, MO_LED_NORM);
        return 0;
 }
@@ -4083,34 +4065,6 @@ static void sky2_get_regs(struct net_device *dev, struct ethtool_regs *regs,
        }
 }
-/* In order to do Jumbo packets on these chips, need to turn off the
- * transmit store/forward. Therefore checksum offload won't work.
- */
-static int no_tx_offload(struct net_device *dev)
-{
-        const struct sky2_port *sky2 = netdev_priv(dev);
-        const struct sky2_hw *hw = sky2->hw;
-        return dev->mtu > ETH_DATA_LEN && hw->chip_id == CHIP_ID_YUKON_EC_U;
-}
-static int sky2_set_tx_csum(struct net_device *dev, u32 data)
-{
-        if (data && no_tx_offload(dev))
-                return -EINVAL;
-        return ethtool_op_set_tx_csum(dev, data);
-}
-static int sky2_set_tso(struct net_device *dev, u32 data)
-{
-        if (data && no_tx_offload(dev))
-                return -EINVAL;
-        return ethtool_op_set_tso(dev, data);
-}
 static int sky2_get_eeprom_len(struct net_device *dev)
 {
        struct sky2_port *sky2 = netdev_priv(dev);
@@ -4213,31 +4167,36 @@ static int sky2_set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom
        return sky2_vpd_write(sky2->hw, cap, data, eeprom->offset, eeprom->len);
 }
-static int sky2_set_flags(struct net_device *dev, u32 data)
+static u32 sky2_fix_features(struct net_device *dev, u32 features)
 {
-        struct sky2_port *sky2 = netdev_priv(dev);
+        const struct sky2_port *sky2 = netdev_priv(dev);
-        unsigned long old_feat = dev->features;
+        const struct sky2_hw *hw = sky2->hw;
-        u32 supported = 0;
-        int rc;
-        if (!(sky2->hw->flags & SKY2_HW_RSS_BROKEN))
+        /* In order to do Jumbo packets on these chips, need to turn off the
-                supported |= ETH_FLAG_RXHASH;
+         * transmit store/forward. Therefore checksum offload won't work.
+         */
+        if (dev->mtu > ETH_DATA_LEN && hw->chip_id == CHIP_ID_YUKON_EC_U)
+                features &= ~(NETIF_F_TSO|NETIF_F_SG|NETIF_F_ALL_CSUM);
-        if (!(sky2->hw->flags & SKY2_HW_VLAN_BROKEN))
+        return features;
-                supported |= ETH_FLAG_RXVLAN | ETH_FLAG_TXVLAN;
+}
-        printk(KERN_DEBUG "sky2 set_flags: supported %x data %x\n",
+static int sky2_set_features(struct net_device *dev, u32 features)
-               supported, data);
+{
+        struct sky2_port *sky2 = netdev_priv(dev);
+        u32 changed = dev->features ^ features;
-        rc = ethtool_op_set_flags(dev, data, supported);
+        if (changed & NETIF_F_RXCSUM) {
-        if (rc)
+                u32 on = features & NETIF_F_RXCSUM;
-                return rc;
+                sky2_write32(sky2->hw, Q_ADDR(rxqaddr[sky2->port], Q_CSR),
+                             on ? BMU_ENA_RX_CHKSUM : BMU_DIS_RX_CHKSUM);
+        }
-        if ((old_feat ^ dev->features) & NETIF_F_RXHASH)
+        if (changed & NETIF_F_RXHASH)
-                rx_set_rss(dev);
+                rx_set_rss(dev, features);
-        if ((old_feat ^ dev->features) & NETIF_F_ALL_VLAN)
+        if (changed & (NETIF_F_HW_VLAN_TX|NETIF_F_HW_VLAN_RX))
-                sky2_vlan_mode(dev);
+                sky2_vlan_mode(dev, features);
        return 0;
 }
@@ -4257,11 +4216,6 @@ static const struct ethtool_ops sky2_ethtool_ops = {
        .get_eeprom_len = sky2_get_eeprom_len,
        .get_eeprom     = sky2_get_eeprom,
        .set_eeprom     = sky2_set_eeprom,
-        .set_sg         = ethtool_op_set_sg,
-        .set_tx_csum    = sky2_set_tx_csum,
-        .set_tso        = sky2_set_tso,
-        .get_rx_csum    = sky2_get_rx_csum,
-        .set_rx_csum    = sky2_set_rx_csum,
        .get_strings    = sky2_get_strings,
        .get_coalesce   = sky2_get_coalesce,
        .set_coalesce   = sky2_set_coalesce,
@@ -4269,11 +4223,9 @@ static const struct ethtool_ops sky2_ethtool_ops = {
        .set_ringparam  = sky2_set_ringparam,
        .get_pauseparam = sky2_get_pauseparam,
        .set_pauseparam = sky2_set_pauseparam,
-        .phys_id        = sky2_phys_id,
+        .set_phys_id    = sky2_set_phys_id,
        .get_sset_count = sky2_get_sset_count,
        .get_ethtool_stats = sky2_get_ethtool_stats,
-        .set_flags      = sky2_set_flags,
-        .get_flags      = ethtool_op_get_flags,
 };
 #ifdef CONFIG_SKY2_DEBUG
@@ -4553,6 +4505,8 @@ static const struct net_device_ops sky2_netdev_ops[2] = {
        .ndo_set_mac_address    = sky2_set_mac_address,
        .ndo_set_multicast_list = sky2_set_multicast,
        .ndo_change_mtu         = sky2_change_mtu,
+        .ndo_fix_features       = sky2_fix_features,
+        .ndo_set_features       = sky2_set_features,
        .ndo_tx_timeout         = sky2_tx_timeout,
        .ndo_get_stats64        = sky2_get_stats,
 #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -4568,6 +4522,8 @@ static const struct net_device_ops sky2_netdev_ops[2] = {
        .ndo_set_mac_address    = sky2_set_mac_address,
        .ndo_set_multicast_list = sky2_set_multicast,
        .ndo_change_mtu         = sky2_change_mtu,
+        .ndo_fix_features       = sky2_fix_features,
+        .ndo_set_features       = sky2_set_features,
        .ndo_tx_timeout         = sky2_tx_timeout,
        .ndo_get_stats64        = sky2_get_stats,
  },
@@ -4600,7 +4556,7 @@ static __devinit struct net_device *sky2_init_netdev(struct sky2_hw *hw,
        /* Auto speed and flow control */
        sky2->flags = SKY2_FLAG_AUTO_SPEED | SKY2_FLAG_AUTO_PAUSE;
        if (hw->chip_id != CHIP_ID_YUKON_XL)
-                sky2->flags |= SKY2_FLAG_RX_CHECKSUM;
+                dev->hw_features |= NETIF_F_RXCSUM;
        sky2->flow_mode = FC_BOTH;
@@ -4619,18 +4575,21 @@ static __devinit struct net_device *sky2_init_netdev(struct sky2_hw *hw,
        sky2->port = port;
-        dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG
+        dev->hw_features |= NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO;
-                | NETIF_F_TSO | NETIF_F_GRO;
        if (highmem)
                dev->features |= NETIF_F_HIGHDMA;
        /* Enable receive hashing unless hardware is known broken */
        if (!(hw->flags & SKY2_HW_RSS_BROKEN))
-                dev->features |= NETIF_F_RXHASH;
+                dev->hw_features |= NETIF_F_RXHASH;
+        if (!(hw->flags & SKY2_HW_VLAN_BROKEN)) {
+                dev->hw_features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+                dev->vlan_features |= SKY2_VLAN_OFFLOADS;
+        }
-        if (!(hw->flags & SKY2_HW_VLAN_BROKEN))
+        dev->features |= dev->hw_features;
-                dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
        /* read the mac address */
        memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port * 8, ETH_ALEN);
diff --git a/drivers/net/sky2.h b/drivers/net/sky2.h
index 0c6d10c5f053..318c9ae7bf91 100644
--- a/drivers/net/sky2.h
+++ b/drivers/net/sky2.h
@@ -2254,7 +2254,6 @@ struct sky2_port {
        u8                   wol;               /* WAKE_ bits */
        u8                   duplex;            /* DUPLEX_HALF, DUPLEX_FULL */
        u16                  flags;
-#define SKY2_FLAG_RX_CHECKSUM           0x0001
 #define SKY2_FLAG_AUTO_SPEED            0x0002
 #define SKY2_FLAG_AUTO_PAUSE            0x0004
diff --git a/drivers/net/smc-mca.c b/drivers/net/smc-mca.c
index d07c39cb4daf..0f29f261fcfe 100644
--- a/drivers/net/smc-mca.c
+++ b/drivers/net/smc-mca.c
@@ -156,7 +156,7 @@ static const struct {
   { 14, 15 }
 };
-static short smc_mca_adapter_ids[] __initdata = {
+static const short smc_mca_adapter_ids[] __devinitconst = {
        0x61c8,
        0x61c9,
        0x6fc0,
@@ -168,7 +168,7 @@ static short smc_mca_adapter_ids[] __initdata = {
        0x0000
 };
-static char *smc_mca_adapter_names[] __initdata = {
+static const char *const smc_mca_adapter_names[] __devinitconst = {
        "SMC Ethercard PLUS Elite/A BNC/AUI (WD8013EP/A)",
        "SMC Ethercard PLUS Elite/A UTP/AUI (WD8013WP/A)",
        "WD Ethercard PLUS/A (WD8003E/A or WD8003ET/A)",
@@ -199,7 +199,7 @@ static const struct net_device_ops ultramca_netdev_ops = {
 #endif
 };
-static int __init ultramca_probe(struct device *gen_dev)
+static int __devinit ultramca_probe(struct device *gen_dev)
 {
        unsigned short ioaddr;
        struct net_device *dev;
diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index 66831f378396..053863aefb12 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -1488,9 +1488,9 @@ smc911x_ethtool_getsettings(struct net_device *dev, struct ethtool_cmd *cmd)
                                SUPPORTED_TP | SUPPORTED_AUI;
                if (lp->ctl_rspeed == 10)
-                        cmd->speed = SPEED_10;
+                        ethtool_cmd_speed_set(cmd, SPEED_10);
                else if (lp->ctl_rspeed == 100)
-                        cmd->speed = SPEED_100;
+                        ethtool_cmd_speed_set(cmd, SPEED_100);
                cmd->autoneg = AUTONEG_DISABLE;
                if (lp->mii.phy_id==1)
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index 43654a3bb0ec..dc4805f473e3 100644
--- a/drivers/net/smc91x.c
+++ b/drivers/net/smc91x.c
@@ -1565,9 +1565,9 @@ smc_ethtool_getsettings(struct net_device *dev, struct ethtool_cmd *cmd)
                                 SUPPORTED_TP | SUPPORTED_AUI;
                if (lp->ctl_rspeed == 10)
-                        cmd->speed = SPEED_10;
+                        ethtool_cmd_speed_set(cmd, SPEED_10);
                else if (lp->ctl_rspeed == 100)
-                        cmd->speed = SPEED_100;
+                        ethtool_cmd_speed_set(cmd, SPEED_100);
                cmd->autoneg = AUTONEG_DISABLE;
                cmd->transceiver = XCVR_INTERNAL;
diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
index 4b42ecc63dcf..c6d47d10590c 100644
--- a/drivers/net/smsc911x.c
+++ b/drivers/net/smsc911x.c
@@ -29,6 +29,8 @@
 *
 */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #include <linux/crc32.h>
 #include <linux/delay.h>
 #include <linux/errno.h>
@@ -69,6 +71,17 @@ static int debug = 3;
 module_param(debug, int, 0);
 MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
+struct smsc911x_data;
+struct smsc911x_ops {
+        u32 (*reg_read)(struct smsc911x_data *pdata, u32 reg);
+        void (*reg_write)(struct smsc911x_data *pdata, u32 reg, u32 val);
+        void (*rx_readfifo)(struct smsc911x_data *pdata,
+                                unsigned int *buf, unsigned int wordcount);
+        void (*tx_writefifo)(struct smsc911x_data *pdata,
+                                unsigned int *buf, unsigned int wordcount);
+};
 struct smsc911x_data {
        void __iomem *ioaddr;
@@ -116,8 +129,14 @@ struct smsc911x_data {
        unsigned int clear_bits_mask;
        unsigned int hashhi;
        unsigned int hashlo;
+        /* register access functions */
+        const struct smsc911x_ops *ops;
 };
+/* Easy access to information */
+#define __smsc_shift(pdata, reg) ((reg) << ((pdata)->config.shift))
 static inline u32 __smsc911x_reg_read(struct smsc911x_data *pdata, u32 reg)
 {
        if (pdata->config.flags & SMSC911X_USE_32BIT)
@@ -131,13 +150,29 @@ static inline u32 __smsc911x_reg_read(struct smsc911x_data *pdata, u32 reg)
        return 0;
 }
+static inline u32
+__smsc911x_reg_read_shift(struct smsc911x_data *pdata, u32 reg)
+{
+        if (pdata->config.flags & SMSC911X_USE_32BIT)
+                return readl(pdata->ioaddr + __smsc_shift(pdata, reg));
+        if (pdata->config.flags & SMSC911X_USE_16BIT)
+                return (readw(pdata->ioaddr +
+                                __smsc_shift(pdata, reg)) & 0xFFFF) |
+                        ((readw(pdata->ioaddr +
+                        __smsc_shift(pdata, reg + 2)) & 0xFFFF) << 16);
+        BUG();
+        return 0;
+}
 static inline u32 smsc911x_reg_read(struct smsc911x_data *pdata, u32 reg)
 {
        u32 data;
        unsigned long flags;
        spin_lock_irqsave(&pdata->dev_lock, flags);
-        data = __smsc911x_reg_read(pdata, reg);
+        data = pdata->ops->reg_read(pdata, reg);
        spin_unlock_irqrestore(&pdata->dev_lock, flags);
        return data;
@@ -160,13 +195,32 @@ static inline void __smsc911x_reg_write(struct smsc911x_data *pdata, u32 reg,
        BUG();
 }
+static inline void
+__smsc911x_reg_write_shift(struct smsc911x_data *pdata, u32 reg, u32 val)
+{
+        if (pdata->config.flags & SMSC911X_USE_32BIT) {
+                writel(val, pdata->ioaddr + __smsc_shift(pdata, reg));
+                return;
+        }
+        if (pdata->config.flags & SMSC911X_USE_16BIT) {
+                writew(val & 0xFFFF,
+                        pdata->ioaddr + __smsc_shift(pdata, reg));
+                writew((val >> 16) & 0xFFFF,
+                        pdata->ioaddr + __smsc_shift(pdata, reg + 2));
+                return;
+        }
+        BUG();
+}
 static inline void smsc911x_reg_write(struct smsc911x_data *pdata, u32 reg,
                                      u32 val)
 {
        unsigned long flags;
        spin_lock_irqsave(&pdata->dev_lock, flags);
-        __smsc911x_reg_write(pdata, reg, val);
+        pdata->ops->reg_write(pdata, reg, val);
        spin_unlock_irqrestore(&pdata->dev_lock, flags);
 }
@@ -202,6 +256,40 @@ out:
        spin_unlock_irqrestore(&pdata->dev_lock, flags);
 }
+/* Writes a packet to the TX_DATA_FIFO - shifted version */
+static inline void
+smsc911x_tx_writefifo_shift(struct smsc911x_data *pdata, unsigned int *buf,
+                      unsigned int wordcount)
+{
+        unsigned long flags;
+        spin_lock_irqsave(&pdata->dev_lock, flags);
+        if (pdata->config.flags & SMSC911X_SWAP_FIFO) {
+                while (wordcount--)
+                        __smsc911x_reg_write_shift(pdata, TX_DATA_FIFO,
+                                             swab32(*buf++));
+                goto out;
+        }
+        if (pdata->config.flags & SMSC911X_USE_32BIT) {
+                writesl(pdata->ioaddr + __smsc_shift(pdata,
+                                                TX_DATA_FIFO), buf, wordcount);
+                goto out;
+        }
+        if (pdata->config.flags & SMSC911X_USE_16BIT) {
+                while (wordcount--)
+                        __smsc911x_reg_write_shift(pdata,
+                                                 TX_DATA_FIFO, *buf++);
+                goto out;
+        }
+        BUG();
+out:
+        spin_unlock_irqrestore(&pdata->dev_lock, flags);
+}
 /* Reads a packet out of the RX_DATA_FIFO */
 static inline void
 smsc911x_rx_readfifo(struct smsc911x_data *pdata, unsigned int *buf,
@@ -234,6 +322,40 @@ out:
        spin_unlock_irqrestore(&pdata->dev_lock, flags);
 }
+/* Reads a packet out of the RX_DATA_FIFO - shifted version */
+static inline void
+smsc911x_rx_readfifo_shift(struct smsc911x_data *pdata, unsigned int *buf,
+                     unsigned int wordcount)
+{
+        unsigned long flags;
+        spin_lock_irqsave(&pdata->dev_lock, flags);
+        if (pdata->config.flags & SMSC911X_SWAP_FIFO) {
+                while (wordcount--)
+                        *buf++ = swab32(__smsc911x_reg_read_shift(pdata,
+                                                            RX_DATA_FIFO));
+                goto out;
+        }
+        if (pdata->config.flags & SMSC911X_USE_32BIT) {
+                readsl(pdata->ioaddr + __smsc_shift(pdata,
+                                                RX_DATA_FIFO), buf, wordcount);
+                goto out;
+        }
+        if (pdata->config.flags & SMSC911X_USE_16BIT) {
+                while (wordcount--)
+                        *buf++ = __smsc911x_reg_read_shift(pdata,
+                                                                RX_DATA_FIFO);
+                goto out;
+        }
+        BUG();
+out:
+        spin_unlock_irqrestore(&pdata->dev_lock, flags);
+}
 /* waits for MAC not busy, with timeout.  Only called by smsc911x_mac_read
 * and smsc911x_mac_write, so assumes mac_lock is held */
 static int smsc911x_mac_complete(struct smsc911x_data *pdata)
@@ -248,8 +370,8 @@ static int smsc911x_mac_complete(struct smsc911x_data *pdata)
                if (!(val & MAC_CSR_CMD_CSR_BUSY_))
                        return 0;
        }
-        SMSC_WARNING(HW, "Timed out waiting for MAC not BUSY. "
+        SMSC_WARN(pdata, hw, "Timed out waiting for MAC not BUSY. "
-                "MAC_CSR_CMD: 0x%08X", val);
+                  "MAC_CSR_CMD: 0x%08X", val);
        return -EIO;
 }
@@ -262,7 +384,7 @@ static u32 smsc911x_mac_read(struct smsc911x_data *pdata, unsigned int offset)
        temp = smsc911x_reg_read(pdata, MAC_CSR_CMD);
        if (unlikely(temp & MAC_CSR_CMD_CSR_BUSY_)) {
-                SMSC_WARNING(HW, "MAC busy at entry");
+                SMSC_WARN(pdata, hw, "MAC busy at entry");
                return 0xFFFFFFFF;
        }
@@ -277,7 +399,7 @@ static u32 smsc911x_mac_read(struct smsc911x_data *pdata, unsigned int offset)
        if (likely(smsc911x_mac_complete(pdata) == 0))
                return smsc911x_reg_read(pdata, MAC_CSR_DATA);
-        SMSC_WARNING(HW, "MAC busy after read");
+        SMSC_WARN(pdata, hw, "MAC busy after read");
        return 0xFFFFFFFF;
 }
@@ -291,8 +413,8 @@ static void smsc911x_mac_write(struct smsc911x_data *pdata,
        temp = smsc911x_reg_read(pdata, MAC_CSR_CMD);
        if (unlikely(temp & MAC_CSR_CMD_CSR_BUSY_)) {
-                SMSC_WARNING(HW,
+                SMSC_WARN(pdata, hw,
-                        "smsc911x_mac_write failed, MAC busy at entry");
+                          "smsc911x_mac_write failed, MAC busy at entry");
                return;
        }
@@ -310,8 +432,7 @@ static void smsc911x_mac_write(struct smsc911x_data *pdata,
        if (likely(smsc911x_mac_complete(pdata) == 0))
                return;
-        SMSC_WARNING(HW,
+        SMSC_WARN(pdata, hw, "smsc911x_mac_write failed, MAC busy after write");
-                "smsc911x_mac_write failed, MAC busy after write");
 }
 /* Get a phy register */
@@ -326,8 +447,7 @@ static int smsc911x_mii_read(struct mii_bus *bus, int phyaddr, int regidx)
        /* Confirm MII not busy */
        if (unlikely(smsc911x_mac_read(pdata, MII_ACC) & MII_ACC_MII_BUSY_)) {
-                SMSC_WARNING(HW,
+                SMSC_WARN(pdata, hw, "MII is busy in smsc911x_mii_read???");
-                        "MII is busy in smsc911x_mii_read???");
                reg = -EIO;
                goto out;
        }
@@ -343,7 +463,7 @@ static int smsc911x_mii_read(struct mii_bus *bus, int phyaddr, int regidx)
                        goto out;
                }
-        SMSC_WARNING(HW, "Timed out waiting for MII read to finish");
+        SMSC_WARN(pdata, hw, "Timed out waiting for MII read to finish");
        reg = -EIO;
 out:
@@ -364,8 +484,7 @@ static int smsc911x_mii_write(struct mii_bus *bus, int phyaddr, int regidx,
        /* Confirm MII not busy */
        if (unlikely(smsc911x_mac_read(pdata, MII_ACC) & MII_ACC_MII_BUSY_)) {
-                SMSC_WARNING(HW,
+                SMSC_WARN(pdata, hw, "MII is busy in smsc911x_mii_write???");
-                        "MII is busy in smsc911x_mii_write???");
                reg = -EIO;
                goto out;
        }
@@ -385,7 +504,7 @@ static int smsc911x_mii_write(struct mii_bus *bus, int phyaddr, int regidx,
                        goto out;
                }
-        SMSC_WARNING(HW, "Timed out waiting for MII write to finish");
+        SMSC_WARN(pdata, hw, "Timed out waiting for MII write to finish");
        reg = -EIO;
 out:
@@ -426,18 +545,20 @@ static void smsc911x_phy_initialise_external(struct smsc911x_data *pdata)
        unsigned int hwcfg = smsc911x_reg_read(pdata, HW_CFG);
        if (pdata->config.flags & SMSC911X_FORCE_INTERNAL_PHY) {
-                SMSC_TRACE(HW, "Forcing internal PHY");
+                SMSC_TRACE(pdata, hw, "Forcing internal PHY");
                pdata->using_extphy = 0;
        } else if (pdata->config.flags & SMSC911X_FORCE_EXTERNAL_PHY) {
-                SMSC_TRACE(HW, "Forcing external PHY");
+                SMSC_TRACE(pdata, hw, "Forcing external PHY");
                smsc911x_phy_enable_external(pdata);
                pdata->using_extphy = 1;
        } else if (hwcfg & HW_CFG_EXT_PHY_DET_) {
-                SMSC_TRACE(HW, "HW_CFG EXT_PHY_DET set, using external PHY");
+                SMSC_TRACE(pdata, hw,
+                           "HW_CFG EXT_PHY_DET set, using external PHY");
                smsc911x_phy_enable_external(pdata);
                pdata->using_extphy = 1;
        } else {
-                SMSC_TRACE(HW, "HW_CFG EXT_PHY_DET clear, using internal PHY");
+                SMSC_TRACE(pdata, hw,
+                           "HW_CFG EXT_PHY_DET clear, using internal PHY");
                pdata->using_extphy = 0;
        }
 }
@@ -499,7 +620,7 @@ static int smsc911x_phy_check_loopbackpkt(struct smsc911x_data *pdata)
                wrsz += (u32)((ulong)pdata->loopback_tx_pkt & 0x3);
                wrsz >>= 2;
-                smsc911x_tx_writefifo(pdata, (unsigned int *)bufp, wrsz);
+                pdata->ops->tx_writefifo(pdata, (unsigned int *)bufp, wrsz);
                /* Wait till transmit is done */
                i = 60;
@@ -509,13 +630,13 @@ static int smsc911x_phy_check_loopbackpkt(struct smsc911x_data *pdata)
                } while ((i--) && (!status));
                if (!status) {
-                        SMSC_WARNING(HW, "Failed to transmit "
+                        SMSC_WARN(pdata, hw,
-                                "during loopback test");
+                                  "Failed to transmit during loopback test");
                        continue;
                }
                if (status & TX_STS_ES_) {
-                        SMSC_WARNING(HW, "Transmit encountered "
+                        SMSC_WARN(pdata, hw,
-                                "errors during loopback test");
+                                  "Transmit encountered errors during loopback test");
                        continue;
                }
@@ -527,13 +648,13 @@ static int smsc911x_phy_check_loopbackpkt(struct smsc911x_data *pdata)
                } while ((i--) && (!status));
                if (!status) {
-                        SMSC_WARNING(HW,
+                        SMSC_WARN(pdata, hw,
-                                "Failed to receive during loopback test");
+                                  "Failed to receive during loopback test");
                        continue;
                }
                if (status & RX_STS_ES_) {
-                        SMSC_WARNING(HW, "Receive encountered "
+                        SMSC_WARN(pdata, hw,
-                                "errors during loopback test");
+                                  "Receive encountered errors during loopback test");
                        continue;
                }
@@ -543,12 +664,12 @@ static int smsc911x_phy_check_loopbackpkt(struct smsc911x_data *pdata)
                rdsz += (u32)((ulong)pdata->loopback_rx_pkt & 0x3);
                rdsz >>= 2;
-                smsc911x_rx_readfifo(pdata, (unsigned int *)bufp, rdsz);
+                pdata->ops->rx_readfifo(pdata, (unsigned int *)bufp, rdsz);
                if (pktlength != (MIN_PACKET_SIZE + 4)) {
-                        SMSC_WARNING(HW, "Unexpected packet size "
+                        SMSC_WARN(pdata, hw, "Unexpected packet size "
-                                "during loop back test, size=%d, will retry",
+                                  "during loop back test, size=%d, will retry",
-                                pktlength);
+                                  pktlength);
                } else {
                        unsigned int j;
                        int mismatch = 0;
@@ -560,12 +681,12 @@ static int smsc911x_phy_check_loopbackpkt(struct smsc911x_data *pdata)
                                }
                        }
                        if (!mismatch) {
-                                SMSC_TRACE(HW, "Successfully verified "
+                                SMSC_TRACE(pdata, hw, "Successfully verified "
                                           "loopback packet");
                                return 0;
                        } else {
-                                SMSC_WARNING(HW, "Data mismatch "
+                                SMSC_WARN(pdata, hw, "Data mismatch "
-                                        "during loop back test, will retry");
+                                          "during loop back test, will retry");
                        }
                }
        }
@@ -582,7 +703,7 @@ static int smsc911x_phy_reset(struct smsc911x_data *pdata)
        BUG_ON(!phy_dev);
        BUG_ON(!phy_dev->bus);
-        SMSC_TRACE(HW, "Performing PHY BCR Reset");
+        SMSC_TRACE(pdata, hw, "Performing PHY BCR Reset");
        smsc911x_mii_write(phy_dev->bus, phy_dev->addr, MII_BMCR, BMCR_RESET);
        do {
                msleep(1);
@@ -591,7 +712,7 @@ static int smsc911x_phy_reset(struct smsc911x_data *pdata)
        } while ((i--) && (temp & BMCR_RESET));
        if (temp & BMCR_RESET) {
-                SMSC_WARNING(HW, "PHY reset failed to complete.");
+                SMSC_WARN(pdata, hw, "PHY reset failed to complete");
                return -EIO;
        }
        /* Extra delay required because the phy may not be completed with
@@ -695,11 +816,11 @@ static void smsc911x_phy_update_flowcontrol(struct smsc911x_data *pdata)
                else
                        afc &= ~0xF;
-                SMSC_TRACE(HW, "rx pause %s, tx pause %s",
+                SMSC_TRACE(pdata, hw, "rx pause %s, tx pause %s",
-                        (cap & FLOW_CTRL_RX ? "enabled" : "disabled"),
+                           (cap & FLOW_CTRL_RX ? "enabled" : "disabled"),
-                        (cap & FLOW_CTRL_TX ? "enabled" : "disabled"));
+                           (cap & FLOW_CTRL_TX ? "enabled" : "disabled"));
        } else {
-                SMSC_TRACE(HW, "half duplex");
+                SMSC_TRACE(pdata, hw, "half duplex");
                flow = 0;
                afc |= 0xF;
        }
@@ -722,17 +843,17 @@ static void smsc911x_phy_adjust_link(struct net_device *dev)
        if (phy_dev->duplex != pdata->last_duplex) {
                unsigned int mac_cr;
-                SMSC_TRACE(HW, "duplex state has changed");
+                SMSC_TRACE(pdata, hw, "duplex state has changed");
                spin_lock_irqsave(&pdata->mac_lock, flags);
                mac_cr = smsc911x_mac_read(pdata, MAC_CR);
                if (phy_dev->duplex) {
-                        SMSC_TRACE(HW,
+                        SMSC_TRACE(pdata, hw,
-                                "configuring for full duplex mode");
+                                   "configuring for full duplex mode");
                        mac_cr |= MAC_CR_FDPX_;
                } else {
-                        SMSC_TRACE(HW,
+                        SMSC_TRACE(pdata, hw,
-                                "configuring for half duplex mode");
+                                   "configuring for half duplex mode");
                        mac_cr &= ~MAC_CR_FDPX_;
                }
                smsc911x_mac_write(pdata, MAC_CR, mac_cr);
@@ -744,9 +865,9 @@ static void smsc911x_phy_adjust_link(struct net_device *dev)
        carrier = netif_carrier_ok(dev);
        if (carrier != pdata->last_carrier) {
-                SMSC_TRACE(HW, "carrier state has changed");
+                SMSC_TRACE(pdata, hw, "carrier state has changed");
                if (carrier) {
-                        SMSC_TRACE(HW, "configuring for carrier OK");
+                        SMSC_TRACE(pdata, hw, "configuring for carrier OK");
                        if ((pdata->gpio_orig_setting & GPIO_CFG_LED1_EN_) &&
                            (!pdata->using_extphy)) {
                                /* Restore original GPIO configuration */
@@ -755,7 +876,7 @@ static void smsc911x_phy_adjust_link(struct net_device *dev)
                                        pdata->gpio_setting);
                        }
                } else {
-                        SMSC_TRACE(HW, "configuring for no carrier");
+                        SMSC_TRACE(pdata, hw, "configuring for no carrier");
                        /* Check global setting that LED1
                         * usage is 10/100 indicator */
                        pdata->gpio_setting = smsc911x_reg_read(pdata,
@@ -787,25 +908,25 @@ static int smsc911x_mii_probe(struct net_device *dev)
        /* find the first phy */
        phydev = phy_find_first(pdata->mii_bus);
        if (!phydev) {
-                pr_err("%s: no PHY found\n", dev->name);
+                netdev_err(dev, "no PHY found\n");
                return -ENODEV;
        }
-        SMSC_TRACE(PROBE, "PHY: addr %d, phy_id 0x%08X",
+        SMSC_TRACE(pdata, probe, "PHY: addr %d, phy_id 0x%08X",
-                        phydev->addr, phydev->phy_id);
+                   phydev->addr, phydev->phy_id);
        ret = phy_connect_direct(dev, phydev,
                        &smsc911x_phy_adjust_link, 0,
                        pdata->config.phy_interface);
        if (ret) {
-                pr_err("%s: Could not attach to PHY\n", dev->name);
+                netdev_err(dev, "Could not attach to PHY\n");
                return ret;
        }
-        pr_info("%s: attached PHY driver [%s] (mii_bus:phy_addr=%s, irq=%d)\n",
+        netdev_info(dev,
-                dev->name, phydev->drv->name,
+                    "attached PHY driver [%s] (mii_bus:phy_addr=%s, irq=%d)\n",
-                dev_name(&phydev->dev), phydev->irq);
+                    phydev->drv->name, dev_name(&phydev->dev), phydev->irq);
        /* mask with MAC supported features */
        phydev->supported &= (PHY_BASIC_FEATURES | SUPPORTED_Pause |
@@ -818,13 +939,13 @@ static int smsc911x_mii_probe(struct net_device *dev)
 #ifdef USE_PHY_WORK_AROUND
        if (smsc911x_phy_loopbacktest(dev) < 0) {
-                SMSC_WARNING(HW, "Failed Loop Back Test");
+                SMSC_WARN(pdata, hw, "Failed Loop Back Test");
                return -ENODEV;
        }
-        SMSC_TRACE(HW, "Passed Loop Back Test");
+        SMSC_TRACE(pdata, hw, "Passed Loop Back Test");
 #endif                          /* USE_PHY_WORK_AROUND */
-        SMSC_TRACE(HW, "phy initialised successfully");
+        SMSC_TRACE(pdata, hw, "phy initialised successfully");
        return 0;
 }
@@ -860,8 +981,8 @@ static int __devinit smsc911x_mii_init(struct platform_device *pdev,
                smsc911x_phy_initialise_external(pdata);
                break;
        default:
-                SMSC_TRACE(HW, "External PHY is not supported, "
+                SMSC_TRACE(pdata, hw, "External PHY is not supported, "
-                        "using internal PHY");
+                           "using internal PHY");
                pdata->using_extphy = 0;
                break;
        }
@@ -872,12 +993,12 @@ static int __devinit smsc911x_mii_init(struct platform_device *pdev,
        }
        if (mdiobus_register(pdata->mii_bus)) {
-                SMSC_WARNING(PROBE, "Error registering mii bus");
+                SMSC_WARN(pdata, probe, "Error registering mii bus");
                goto err_out_free_bus_2;
        }
        if (smsc911x_mii_probe(dev) < 0) {
-                SMSC_WARNING(PROBE, "Error registering mii bus");
+                SMSC_WARN(pdata, probe, "Error registering mii bus");
                goto err_out_unregister_bus_3;
        }
@@ -913,8 +1034,7 @@ static void smsc911x_tx_update_txcounters(struct net_device *dev)
                         * does not reference a hardware defined reserved bit
                         * but rather a driver defined one.
                         */
-                        SMSC_WARNING(HW,
+                        SMSC_WARN(pdata, hw, "Packet tag reserved bit is high");
-                                "Packet tag reserved bit is high");
                } else {
                        if (unlikely(tx_stat & TX_STS_ES_)) {
                                dev->stats.tx_errors++;
@@ -977,8 +1097,8 @@ smsc911x_rx_fastforward(struct smsc911x_data *pdata, unsigned int pktbytes)
                } while ((val & RX_DP_CTRL_RX_FFWD_) && --timeout);
                if (unlikely(timeout == 0))
-                        SMSC_WARNING(HW, "Timed out waiting for "
+                        SMSC_WARN(pdata, hw, "Timed out waiting for "
-                                "RX FFWD to finish, RX_DP_CTRL: 0x%08X", val);
+                                  "RX FFWD to finish, RX_DP_CTRL: 0x%08X", val);
        } else {
                unsigned int temp;
                while (pktwords--)
@@ -1021,8 +1141,8 @@ static int smsc911x_poll(struct napi_struct *napi, int budget)
                smsc911x_rx_counterrors(dev, rxstat);
                if (unlikely(rxstat & RX_STS_ES_)) {
-                        SMSC_WARNING(RX_ERR,
+                        SMSC_WARN(pdata, rx_err,
-                                "Discarding packet with error bit set");
+                                  "Discarding packet with error bit set");
                        /* Packet has an error, discard it and continue with
                         * the next */
                        smsc911x_rx_fastforward(pdata, pktwords);
@@ -1032,8 +1152,8 @@ static int smsc911x_poll(struct napi_struct *napi, int budget)
                skb = netdev_alloc_skb(dev, pktlength + NET_IP_ALIGN);
                if (unlikely(!skb)) {
-                        SMSC_WARNING(RX_ERR,
+                        SMSC_WARN(pdata, rx_err,
-                                "Unable to allocate skb for rx packet");
+                                  "Unable to allocate skb for rx packet");
                        /* Drop the packet and stop this polling iteration */
                        smsc911x_rx_fastforward(pdata, pktwords);
                        dev->stats.rx_dropped++;
@@ -1046,8 +1166,8 @@ static int smsc911x_poll(struct napi_struct *napi, int budget)
                /* Align IP on 16B boundary */
                skb_reserve(skb, NET_IP_ALIGN);
                skb_put(skb, pktlength - 4);
-                smsc911x_rx_readfifo(pdata, (unsigned int *)skb->head,
+                pdata->ops->rx_readfifo(pdata,
-                                     pktwords);
+                                 (unsigned int *)skb->head, pktwords);
                skb->protocol = eth_type_trans(skb, dev);
                skb_checksum_none_assert(skb);
                netif_receive_skb(skb);
@@ -1083,8 +1203,8 @@ static void smsc911x_rx_multicast_update(struct smsc911x_data *pdata)
        smsc911x_mac_write(pdata, MAC_CR, mac_cr);
        smsc911x_mac_write(pdata, HASHH, pdata->hashhi);
        smsc911x_mac_write(pdata, HASHL, pdata->hashlo);
-        SMSC_TRACE(HW, "maccr 0x%08X, HASHH 0x%08X, HASHL 0x%08X",
+        SMSC_TRACE(pdata, hw, "maccr 0x%08X, HASHH 0x%08X, HASHL 0x%08X",
-                mac_cr, pdata->hashhi, pdata->hashlo);
+                   mac_cr, pdata->hashhi, pdata->hashlo);
 }
 static void smsc911x_rx_multicast_update_workaround(struct smsc911x_data *pdata)
@@ -1102,7 +1222,7 @@ static void smsc911x_rx_multicast_update_workaround(struct smsc911x_data *pdata)
        /* Check Rx has stopped */
        if (smsc911x_mac_read(pdata, MAC_CR) & MAC_CR_RXEN_)
-                SMSC_WARNING(DRV, "Rx not stopped");
+                SMSC_WARN(pdata, drv, "Rx not stopped");
        /* Perform the update - safe to do now Rx has stopped */
        smsc911x_rx_multicast_update(pdata);
@@ -1131,7 +1251,7 @@ static int smsc911x_soft_reset(struct smsc911x_data *pdata)
        } while ((--timeout) && (temp & HW_CFG_SRST_));
        if (unlikely(temp & HW_CFG_SRST_)) {
-                SMSC_WARNING(DRV, "Failed to complete reset");
+                SMSC_WARN(pdata, drv, "Failed to complete reset");
                return -EIO;
        }
        return 0;
@@ -1160,18 +1280,18 @@ static int smsc911x_open(struct net_device *dev)
        /* if the phy is not yet registered, retry later*/
        if (!pdata->phy_dev) {
-                SMSC_WARNING(HW, "phy_dev is NULL");
+                SMSC_WARN(pdata, hw, "phy_dev is NULL");
                return -EAGAIN;
        }
        if (!is_valid_ether_addr(dev->dev_addr)) {
-                SMSC_WARNING(HW, "dev_addr is not a valid MAC address");
+                SMSC_WARN(pdata, hw, "dev_addr is not a valid MAC address");
                return -EADDRNOTAVAIL;
        }
        /* Reset the LAN911x */
        if (smsc911x_soft_reset(pdata)) {
-                SMSC_WARNING(HW, "soft reset failed");
+                SMSC_WARN(pdata, hw, "soft reset failed");
                return -EIO;
        }
@@ -1191,8 +1311,8 @@ static int smsc911x_open(struct net_device *dev)
        }
        if (unlikely(timeout == 0))
-                SMSC_WARNING(IFUP,
+                SMSC_WARN(pdata, ifup,
-                        "Timed out waiting for EEPROM busy bit to clear");
+                          "Timed out waiting for EEPROM busy bit to clear");
        smsc911x_reg_write(pdata, GPIO_CFG, 0x70070000);
@@ -1210,22 +1330,22 @@ static int smsc911x_open(struct net_device *dev)
        intcfg = ((10 << 24) | INT_CFG_IRQ_EN_);
        if (pdata->config.irq_polarity) {
-                SMSC_TRACE(IFUP, "irq polarity: active high");
+                SMSC_TRACE(pdata, ifup, "irq polarity: active high");
                intcfg |= INT_CFG_IRQ_POL_;
        } else {
-                SMSC_TRACE(IFUP, "irq polarity: active low");
+                SMSC_TRACE(pdata, ifup, "irq polarity: active low");
        }
        if (pdata->config.irq_type) {
-                SMSC_TRACE(IFUP, "irq type: push-pull");
+                SMSC_TRACE(pdata, ifup, "irq type: push-pull");
                intcfg |= INT_CFG_IRQ_TYPE_;
        } else {
-                SMSC_TRACE(IFUP, "irq type: open drain");
+                SMSC_TRACE(pdata, ifup, "irq type: open drain");
        }
        smsc911x_reg_write(pdata, INT_CFG, intcfg);
-        SMSC_TRACE(IFUP, "Testing irq handler using IRQ %d", dev->irq);
+        SMSC_TRACE(pdata, ifup, "Testing irq handler using IRQ %d", dev->irq);
        pdata->software_irq_signal = 0;
        smp_wmb();
@@ -1241,14 +1361,15 @@ static int smsc911x_open(struct net_device *dev)
        }
        if (!pdata->software_irq_signal) {
-                dev_warn(&dev->dev, "ISR failed signaling test (IRQ %d)\n",
+                netdev_warn(dev, "ISR failed signaling test (IRQ %d)\n",
-                         dev->irq);
+                            dev->irq);
                return -ENODEV;
        }
-        SMSC_TRACE(IFUP, "IRQ handler passed test using IRQ %d", dev->irq);
+        SMSC_TRACE(pdata, ifup, "IRQ handler passed test using IRQ %d",
+                   dev->irq);
-        dev_info(&dev->dev, "SMSC911x/921x identified at %#08lx, IRQ: %d\n",
+        netdev_info(dev, "SMSC911x/921x identified at %#08lx, IRQ: %d\n",
-                 (unsigned long)pdata->ioaddr, dev->irq);
+                    (unsigned long)pdata->ioaddr, dev->irq);
        /* Reset the last known duplex and carrier */
        pdata->last_duplex = -1;
@@ -1313,7 +1434,7 @@ static int smsc911x_stop(struct net_device *dev)
        if (pdata->phy_dev)
                phy_stop(pdata->phy_dev);
-        SMSC_TRACE(IFDOWN, "Interface stopped");
+        SMSC_TRACE(pdata, ifdown, "Interface stopped");
        return 0;
 }
@@ -1331,8 +1452,8 @@ static int smsc911x_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
        freespace = smsc911x_reg_read(pdata, TX_FIFO_INF) & TX_FIFO_INF_TDFREE_;
        if (unlikely(freespace < TX_FIFO_LOW_THRESHOLD))
-                SMSC_WARNING(TX_ERR,
+                SMSC_WARN(pdata, tx_err,
-                        "Tx data fifo low, space available: %d", freespace);
+                          "Tx data fifo low, space available: %d", freespace);
        /* Word alignment adjustment */
        tx_cmd_a = (u32)((ulong)skb->data & 0x03) << 16;
@@ -1350,7 +1471,7 @@ static int smsc911x_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
        wrsz += (u32)((ulong)skb->data & 0x3);
        wrsz >>= 2;
-        smsc911x_tx_writefifo(pdata, (unsigned int *)bufp, wrsz);
+        pdata->ops->tx_writefifo(pdata, (unsigned int *)bufp, wrsz);
        freespace -= (skb->len + 32);
        dev_kfree_skb(skb);
@@ -1432,7 +1553,7 @@ static void smsc911x_set_multicast_list(struct net_device *dev)
                 * receiving data */
                if (!pdata->multicast_update_pending) {
                        unsigned int temp;
-                        SMSC_TRACE(HW, "scheduling mcast update");
+                        SMSC_TRACE(pdata, hw, "scheduling mcast update");
                        pdata->multicast_update_pending = 1;
                        /* Request the hardware to stop, then perform the
@@ -1474,7 +1595,7 @@ static irqreturn_t smsc911x_irqhandler(int irq, void *dev_id)
        if (unlikely(intsts & inten & INT_STS_RXSTOP_INT_)) {
                /* Called when there is a multicast update scheduled and
                 * it is now safe to complete the update */
-                SMSC_TRACE(INTR, "RX Stop interrupt");
+                SMSC_TRACE(pdata, intr, "RX Stop interrupt");
                smsc911x_reg_write(pdata, INT_STS, INT_STS_RXSTOP_INT_);
                if (pdata->multicast_update_pending)
                        smsc911x_rx_multicast_update_workaround(pdata);
@@ -1491,7 +1612,7 @@ static irqreturn_t smsc911x_irqhandler(int irq, void *dev_id)
        }
        if (unlikely(intsts & inten & INT_STS_RXE_)) {
-                SMSC_TRACE(INTR, "RX Error interrupt");
+                SMSC_TRACE(pdata, intr, "RX Error interrupt");
                smsc911x_reg_write(pdata, INT_STS, INT_STS_RXE_);
                serviced = IRQ_HANDLED;
        }
@@ -1505,8 +1626,7 @@ static irqreturn_t smsc911x_irqhandler(int irq, void *dev_id)
                        /* Schedule a NAPI poll */
                        __napi_schedule(&pdata->napi);
                } else {
-                        SMSC_WARNING(RX_ERR,
+                        SMSC_WARN(pdata, rx_err, "napi_schedule_prep failed");
-                                "napi_schedule_prep failed");
                }
                serviced = IRQ_HANDLED;
        }
@@ -1543,7 +1663,7 @@ static int smsc911x_set_mac_address(struct net_device *dev, void *p)
        smsc911x_set_hw_mac_address(pdata, dev->dev_addr);
        spin_unlock_irq(&pdata->mac_lock);
-        dev_info(&dev->dev, "MAC Address: %pM\n", dev->dev_addr);
+        netdev_info(dev, "MAC Address: %pM\n", dev->dev_addr);
        return 0;
 }
@@ -1649,9 +1769,9 @@ static int smsc911x_eeprom_send_cmd(struct smsc911x_data *pdata, u32 op)
        int timeout = 100;
        u32 e2cmd;
-        SMSC_TRACE(DRV, "op 0x%08x", op);
+        SMSC_TRACE(pdata, drv, "op 0x%08x", op);
        if (smsc911x_reg_read(pdata, E2P_CMD) & E2P_CMD_EPC_BUSY_) {
-                SMSC_WARNING(DRV, "Busy at start");
+                SMSC_WARN(pdata, drv, "Busy at start");
                return -EBUSY;
        }
@@ -1664,12 +1784,12 @@ static int smsc911x_eeprom_send_cmd(struct smsc911x_data *pdata, u32 op)
        } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (--timeout));
        if (!timeout) {
-                SMSC_TRACE(DRV, "TIMED OUT");
+                SMSC_TRACE(pdata, drv, "TIMED OUT");
                return -EAGAIN;
        }
        if (e2cmd & E2P_CMD_EPC_TIMEOUT_) {
-                SMSC_TRACE(DRV, "Error occurred during eeprom operation");
+                SMSC_TRACE(pdata, drv, "Error occurred during eeprom operation");
                return -EINVAL;
        }
@@ -1682,7 +1802,7 @@ static int smsc911x_eeprom_read_location(struct smsc911x_data *pdata,
        u32 op = E2P_CMD_EPC_CMD_READ_ | address;
        int ret;
-        SMSC_TRACE(DRV, "address 0x%x", address);
+        SMSC_TRACE(pdata, drv, "address 0x%x", address);
        ret = smsc911x_eeprom_send_cmd(pdata, op);
        if (!ret)
@@ -1698,7 +1818,7 @@ static int smsc911x_eeprom_write_location(struct smsc911x_data *pdata,
        u32 temp;
        int ret;
-        SMSC_TRACE(DRV, "address 0x%x, data 0x%x", address, data);
+        SMSC_TRACE(pdata, drv, "address 0x%x, data 0x%x", address, data);
        ret = smsc911x_eeprom_send_cmd(pdata, op);
        if (!ret) {
@@ -1811,26 +1931,26 @@ static int __devinit smsc911x_init(struct net_device *dev)
        struct smsc911x_data *pdata = netdev_priv(dev);
        unsigned int byte_test;
-        SMSC_TRACE(PROBE, "Driver Parameters:");
+        SMSC_TRACE(pdata, probe, "Driver Parameters:");
-        SMSC_TRACE(PROBE, "LAN base: 0x%08lX",
+        SMSC_TRACE(pdata, probe, "LAN base: 0x%08lX",
-                (unsigned long)pdata->ioaddr);
+                   (unsigned long)pdata->ioaddr);
-        SMSC_TRACE(PROBE, "IRQ: %d", dev->irq);
+        SMSC_TRACE(pdata, probe, "IRQ: %d", dev->irq);
-        SMSC_TRACE(PROBE, "PHY will be autodetected.");
+        SMSC_TRACE(pdata, probe, "PHY will be autodetected.");
        spin_lock_init(&pdata->dev_lock);
        spin_lock_init(&pdata->mac_lock);
        if (pdata->ioaddr == 0) {
-                SMSC_WARNING(PROBE, "pdata->ioaddr: 0x00000000");
+                SMSC_WARN(pdata, probe, "pdata->ioaddr: 0x00000000");
                return -ENODEV;
        }
        /* Check byte ordering */
        byte_test = smsc911x_reg_read(pdata, BYTE_TEST);
-        SMSC_TRACE(PROBE, "BYTE_TEST: 0x%08X", byte_test);
+        SMSC_TRACE(pdata, probe, "BYTE_TEST: 0x%08X", byte_test);
        if (byte_test == 0x43218765) {
-                SMSC_TRACE(PROBE, "BYTE_TEST looks swapped, "
+                SMSC_TRACE(pdata, probe, "BYTE_TEST looks swapped, "
-                        "applying WORD_SWAP");
+                           "applying WORD_SWAP");
                smsc911x_reg_write(pdata, WORD_SWAP, 0xffffffff);
                /* 1 dummy read of BYTE_TEST is needed after a write to
@@ -1841,12 +1961,13 @@ static int __devinit smsc911x_init(struct net_device *dev)
        }
        if (byte_test != 0x87654321) {
-                SMSC_WARNING(DRV, "BYTE_TEST: 0x%08X", byte_test);
+                SMSC_WARN(pdata, drv, "BYTE_TEST: 0x%08X", byte_test);
                if (((byte_test >> 16) & 0xFFFF) == (byte_test & 0xFFFF)) {
-                        SMSC_WARNING(PROBE,
+                        SMSC_WARN(pdata, probe,
-                                "top 16 bits equal to bottom 16 bits");
+                                  "top 16 bits equal to bottom 16 bits");
-                        SMSC_TRACE(PROBE, "This may mean the chip is set "
+                        SMSC_TRACE(pdata, probe,
-                                "for 32 bit while the bus is reading 16 bit");
+                                   "This may mean the chip is set "
+                                   "for 32 bit while the bus is reading 16 bit");
                }
                return -ENODEV;
        }
@@ -1881,17 +2002,18 @@ static int __devinit smsc911x_init(struct net_device *dev)
                break;
        default:
-                SMSC_WARNING(PROBE, "LAN911x not identified, idrev: 0x%08X",
+                SMSC_WARN(pdata, probe, "LAN911x not identified, idrev: 0x%08X",
-                        pdata->idrev);
+                          pdata->idrev);
                return -ENODEV;
        }
-        SMSC_TRACE(PROBE, "LAN911x identified, idrev: 0x%08X, generation: %d",
+        SMSC_TRACE(pdata, probe,
-                pdata->idrev, pdata->generation);
+                   "LAN911x identified, idrev: 0x%08X, generation: %d",
+                   pdata->idrev, pdata->generation);
        if (pdata->generation == 0)
-                SMSC_WARNING(PROBE,
+                SMSC_WARN(pdata, probe,
-                        "This driver is not intended for this chip revision");
+                          "This driver is not intended for this chip revision");
        /* workaround for platforms without an eeprom, where the mac address
         * is stored elsewhere and set by the bootloader.  This saves the
@@ -1931,7 +2053,7 @@ static int __devexit smsc911x_drv_remove(struct platform_device *pdev)
        BUG_ON(!pdata->ioaddr);
        BUG_ON(!pdata->phy_dev);
-        SMSC_TRACE(IFDOWN, "Stopping driver.");
+        SMSC_TRACE(pdata, ifdown, "Stopping driver");
        phy_disconnect(pdata->phy_dev);
        pdata->phy_dev = NULL;
@@ -1955,6 +2077,22 @@ static int __devexit smsc911x_drv_remove(struct platform_device *pdev)
        return 0;
 }
+/* standard register acces */
+static const struct smsc911x_ops standard_smsc911x_ops = {
+        .reg_read = __smsc911x_reg_read,
+        .reg_write = __smsc911x_reg_write,
+        .rx_readfifo = smsc911x_rx_readfifo,
+        .tx_writefifo = smsc911x_tx_writefifo,
+};
+/* shifted register access */
+static const struct smsc911x_ops shifted_smsc911x_ops = {
+        .reg_read = __smsc911x_reg_read_shift,
+        .reg_write = __smsc911x_reg_write_shift,
+        .rx_readfifo = smsc911x_rx_readfifo_shift,
+        .tx_writefifo = smsc911x_tx_writefifo_shift,
+};
 static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
 {
        struct net_device *dev;
@@ -1965,11 +2103,11 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
        int res_size, irq_flags;
        int retval;
-        pr_info("%s: Driver version %s.\n", SMSC_CHIPNAME, SMSC_DRV_VERSION);
+        pr_info("Driver version %s\n", SMSC_DRV_VERSION);
        /* platform data specifies irq & dynamic bus configuration */
        if (!pdev->dev.platform_data) {
-                pr_warning("%s: platform_data not provided\n", SMSC_CHIPNAME);
+                pr_warn("platform_data not provided\n");
                retval = -ENODEV;
                goto out_0;
        }
@@ -1979,8 +2117,7 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
        if (!res)
                res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (!res) {
-                pr_warning("%s: Could not allocate resource.\n",
+                pr_warn("Could not allocate resource\n");
-                        SMSC_CHIPNAME);
                retval = -ENODEV;
                goto out_0;
        }
@@ -1988,8 +2125,7 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
        irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
        if (!irq_res) {
-                pr_warning("%s: Could not allocate irq resource.\n",
+                pr_warn("Could not allocate irq resource\n");
-                        SMSC_CHIPNAME);
                retval = -ENODEV;
                goto out_0;
        }
@@ -2001,7 +2137,7 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
        dev = alloc_etherdev(sizeof(struct smsc911x_data));
        if (!dev) {
-                pr_warning("%s: Could not allocate device.\n", SMSC_CHIPNAME);
+                pr_warn("Could not allocate device\n");
                retval = -ENOMEM;
                goto out_release_io_1;
        }
@@ -2021,12 +2157,17 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
        pdata->msg_enable = ((1 << debug) - 1);
        if (pdata->ioaddr == NULL) {
-                SMSC_WARNING(PROBE,
+                SMSC_WARN(pdata, probe, "Error smsc911x base address invalid");
-                        "Error smsc911x base address invalid");
                retval = -ENOMEM;
                goto out_free_netdev_2;
        }
+        /* assume standard, non-shifted, access to HW registers */
+        pdata->ops = &standard_smsc911x_ops;
+        /* apply the right access if shifting is needed */
+        if (config->shift)
+                pdata->ops = &shifted_smsc911x_ops;
        retval = smsc911x_init(dev);
        if (retval < 0)
                goto out_unmap_io_3;
@@ -2047,8 +2188,8 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
        retval = request_irq(dev->irq, smsc911x_irqhandler,
                             irq_flags | IRQF_SHARED, dev->name, dev);
        if (retval) {
-                SMSC_WARNING(PROBE,
+                SMSC_WARN(pdata, probe,
-                        "Unable to claim requested irq: %d", dev->irq);
+                          "Unable to claim requested irq: %d", dev->irq);
                goto out_unmap_io_3;
        }
@@ -2056,17 +2197,16 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
        retval = register_netdev(dev);
        if (retval) {
-                SMSC_WARNING(PROBE,
+                SMSC_WARN(pdata, probe, "Error %i registering device", retval);
-                        "Error %i registering device", retval);
                goto out_unset_drvdata_4;
        } else {
-                SMSC_TRACE(PROBE, "Network interface: \"%s\"", dev->name);
+                SMSC_TRACE(pdata, probe,
+                           "Network interface: \"%s\"", dev->name);
        }
        retval = smsc911x_mii_init(pdev, dev);
        if (retval) {
-                SMSC_WARNING(PROBE,
+                SMSC_WARN(pdata, probe, "Error %i initialising mii", retval);
-                        "Error %i initialising mii", retval);
                goto out_unregister_netdev_5;
        }
@@ -2075,10 +2215,12 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
        /* Check if mac address has been specified when bringing interface up */
        if (is_valid_ether_addr(dev->dev_addr)) {
                smsc911x_set_hw_mac_address(pdata, dev->dev_addr);
-                SMSC_TRACE(PROBE, "MAC Address is specified by configuration");
+                SMSC_TRACE(pdata, probe,
+                           "MAC Address is specified by configuration");
        } else if (is_valid_ether_addr(pdata->config.mac)) {
                memcpy(dev->dev_addr, pdata->config.mac, 6);
-                SMSC_TRACE(PROBE, "MAC Address specified by platform data");
+                SMSC_TRACE(pdata, probe,
+                           "MAC Address specified by platform data");
        } else {
                /* Try reading mac address from device. if EEPROM is present
                 * it will already have been set */
@@ -2086,20 +2228,20 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
                if (is_valid_ether_addr(dev->dev_addr)) {
                        /* eeprom values are valid  so use them */
-                        SMSC_TRACE(PROBE,
+                        SMSC_TRACE(pdata, probe,
-                                "Mac Address is read from LAN911x EEPROM");
+                                   "Mac Address is read from LAN911x EEPROM");
                } else {
                        /* eeprom values are invalid, generate random MAC */
                        random_ether_addr(dev->dev_addr);
                        smsc911x_set_hw_mac_address(pdata, dev->dev_addr);
-                        SMSC_TRACE(PROBE,
+                        SMSC_TRACE(pdata, probe,
-                                "MAC Address is set to random_ether_addr");
+                                   "MAC Address is set to random_ether_addr");
                }
        }
        spin_unlock_irq(&pdata->mac_lock);
-        dev_info(&dev->dev, "MAC Address: %pM\n", dev->dev_addr);
+        netdev_info(dev, "MAC Address: %pM\n", dev->dev_addr);
        return 0;
diff --git a/drivers/net/smsc911x.h b/drivers/net/smsc911x.h
index 50f712e99e96..8d67aacf8867 100644
--- a/drivers/net/smsc911x.h
+++ b/drivers/net/smsc911x.h
@@ -33,25 +33,21 @@
 * can be successfully looped back */
 #define USE_PHY_WORK_AROUND
-#define DPRINTK(nlevel, klevel, fmt, args...) \
-        ((void)((NETIF_MSG_##nlevel & pdata->msg_enable) && \
-        printk(KERN_##klevel "%s: %s: " fmt "\n", \
-        pdata->dev->name, __func__, ## args)))
 #if USE_DEBUG >= 1
-#define SMSC_WARNING(nlevel, fmt, args...) \
+#define SMSC_WARN(pdata, nlevel, fmt, args...)                  \
-        DPRINTK(nlevel, WARNING, fmt, ## args)
+        netif_warn(pdata, nlevel, (pdata)->dev,                 \
+                   "%s: " fmt "\n", __func__, ##args)
 #else
-#define SMSC_WARNING(nlevel, fmt, args...) \
+#define SMSC_WARN(pdata, nlevel, fmt, args...)                  \
-        ({ do {} while (0); 0; })
+        no_printk(fmt "\n", ##args)
 #endif
 #if USE_DEBUG >= 2
-#define SMSC_TRACE(nlevel, fmt, args...) \
+#define SMSC_TRACE(pdata, nlevel, fmt, args...)                 \
-        DPRINTK(nlevel, INFO, fmt, ## args)
+        netif_info(pdata, nlevel, pdata->dev, fmt "\n", ##args)
 #else
-#define SMSC_TRACE(nlevel, fmt, args...) \
+#define SMSC_TRACE(pdata, nlevel, fmt, args...)                 \
-        ({ do {} while (0); 0; })
+        no_printk(fmt "\n", ##args)
 #endif
 #ifdef CONFIG_DEBUG_SPINLOCK
diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c
index cb6bcca9d541..949f124e1278 100644
--- a/drivers/net/spider_net.c
+++ b/drivers/net/spider_net.c
@@ -994,15 +994,13 @@ spider_net_pass_skb_up(struct spider_net_descr *descr,
        skb->protocol = eth_type_trans(skb, netdev);
        /* checksum offload */
-        if (card->options.rx_csum) {
+        skb_checksum_none_assert(skb);
+        if (netdev->features & NETIF_F_RXCSUM) {
                if ( ( (data_status & SPIDER_NET_DATA_STATUS_CKSUM_MASK) ==
                       SPIDER_NET_DATA_STATUS_CKSUM_MASK) &&
                     !(data_error & SPIDER_NET_DATA_ERR_CKSUM_MASK))
                        skb->ip_summed = CHECKSUM_UNNECESSARY;
-                else
+        }
-                        skb_checksum_none_assert(skb);
-        } else
-                skb_checksum_none_assert(skb);
        if (data_status & SPIDER_NET_VLAN_PACKET) {
                /* further enhancements: HW-accel VLAN
@@ -2322,14 +2320,15 @@ spider_net_setup_netdev(struct spider_net_card *card)
        card->aneg_timer.function = spider_net_link_phy;
        card->aneg_timer.data = (unsigned long) card;
-        card->options.rx_csum = SPIDER_NET_RX_CSUM_DEFAULT;
        netif_napi_add(netdev, &card->napi,
                       spider_net_poll, SPIDER_NET_NAPI_WEIGHT);
        spider_net_setup_netdev_ops(netdev);
-        netdev->features = NETIF_F_IP_CSUM | NETIF_F_LLTX;
+        netdev->hw_features = NETIF_F_RXCSUM | NETIF_F_IP_CSUM;
+        if (SPIDER_NET_RX_CSUM_DEFAULT)
+                netdev->features |= NETIF_F_RXCSUM;
+        netdev->features |= NETIF_F_IP_CSUM | NETIF_F_LLTX;
        /* some time: NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |
         *              NETIF_F_HW_VLAN_FILTER */
diff --git a/drivers/net/spider_net.h b/drivers/net/spider_net.h
index 05f74cbdd617..020f64a8fcf7 100644
--- a/drivers/net/spider_net.h
+++ b/drivers/net/spider_net.h
@@ -429,12 +429,6 @@ struct spider_net_descr_chain {
 * 701b8000 would be correct, but every packets gets that flag */
 #define SPIDER_NET_DESTROY_RX_FLAGS     0x700b8000
-/* this will be bigger some time */
-struct spider_net_options {
-        int rx_csum; /* for rx: if 0 ip_summed=NONE,
-                        if 1 and hw has verified, ip_summed=UNNECESSARY */
-};
 #define SPIDER_NET_DEFAULT_MSG          ( NETIF_MSG_DRV | \
                                          NETIF_MSG_PROBE | \
                                          NETIF_MSG_LINK | \
@@ -487,7 +481,6 @@ struct spider_net_card {
        /* for ethtool */
        int msg_enable;
        struct spider_net_extra_stats spider_stats;
-        struct spider_net_options options;
        /* Must be last item in struct */
        struct spider_net_descr darray[0];
diff --git a/drivers/net/spider_net_ethtool.c b/drivers/net/spider_net_ethtool.c
index 5bae728c3820..9c288cd7d171 100644
--- a/drivers/net/spider_net_ethtool.c
+++ b/drivers/net/spider_net_ethtool.c
@@ -58,7 +58,7 @@ spider_net_ethtool_get_settings(struct net_device *netdev,
        cmd->advertising = (ADVERTISED_1000baseT_Full |
                             ADVERTISED_FIBRE);
        cmd->port = PORT_FIBRE;
-        cmd->speed = card->phy.speed;
+        ethtool_cmd_speed_set(cmd, card->phy.speed);
        cmd->duplex = DUPLEX_FULL;
        return 0;
@@ -115,24 +115,6 @@ spider_net_ethtool_nway_reset(struct net_device *netdev)
        return 0;
 }
-static u32
-spider_net_ethtool_get_rx_csum(struct net_device *netdev)
-{
-        struct spider_net_card *card = netdev_priv(netdev);
-        return card->options.rx_csum;
-}
-static int
-spider_net_ethtool_set_rx_csum(struct net_device *netdev, u32 n)
-{
-        struct spider_net_card *card = netdev_priv(netdev);
-        card->options.rx_csum = n;
-        return 0;
-}
 static void
 spider_net_ethtool_get_ringparam(struct net_device *netdev,
                                 struct ethtool_ringparam *ering)
@@ -189,9 +171,6 @@ const struct ethtool_ops spider_net_ethtool_ops = {
        .set_msglevel           = spider_net_ethtool_set_msglevel,
        .get_link               = ethtool_op_get_link,
        .nway_reset             = spider_net_ethtool_nway_reset,
-        .get_rx_csum            = spider_net_ethtool_get_rx_csum,
-        .set_rx_csum            = spider_net_ethtool_set_rx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_csum,
        .get_ringparam          = spider_net_ethtool_get_ringparam,
        .get_strings            = spider_net_get_strings,
        .get_sset_count         = spider_net_get_sset_count,
diff --git a/drivers/net/stmmac/dwmac1000_core.c b/drivers/net/stmmac/dwmac1000_core.c
index 6ae4c3f4c63c..f20455cbfbbc 100644
--- a/drivers/net/stmmac/dwmac1000_core.c
+++ b/drivers/net/stmmac/dwmac1000_core.c
@@ -178,10 +178,11 @@ static void dwmac1000_pmt(void __iomem *ioaddr, unsigned long mode)
 {
        unsigned int pmt = 0;
-        if (mode == WAKE_MAGIC) {
+        if (mode & WAKE_MAGIC) {
                CHIP_DBG(KERN_DEBUG "GMAC: WOL Magic frame\n");
                pmt |= power_down | magic_pkt_en;
-        } else if (mode == WAKE_UCAST) {
+        }
+        if (mode & WAKE_UCAST) {
                CHIP_DBG(KERN_DEBUG "GMAC: WOL on global unicast\n");
                pmt |= global_unicast;
        }
diff --git a/drivers/net/stmmac/stmmac.h b/drivers/net/stmmac/stmmac.h
index 5f06c4706abe..2b076b313622 100644
--- a/drivers/net/stmmac/stmmac.h
+++ b/drivers/net/stmmac/stmmac.h
@@ -21,7 +21,6 @@
 *******************************************************************************/
 #define DRV_MODULE_VERSION      "Nov_2010"
-#include <linux/platform_device.h>
 #include <linux/stmmac.h>
 #include "common.h"
diff --git a/drivers/net/stmmac/stmmac_ethtool.c b/drivers/net/stmmac/stmmac_ethtool.c
index fd719edc7f7c..ae5213a8c4cd 100644
--- a/drivers/net/stmmac/stmmac_ethtool.c
+++ b/drivers/net/stmmac/stmmac_ethtool.c
@@ -197,13 +197,6 @@ static void stmmac_ethtool_gregs(struct net_device *dev,
        }
 }
-static u32 stmmac_ethtool_get_rx_csum(struct net_device *dev)
-{
-        struct stmmac_priv *priv = netdev_priv(dev);
-        return priv->rx_coe;
-}
 static void
 stmmac_get_pauseparam(struct net_device *netdev,
                      struct ethtool_pauseparam *pause)
@@ -241,20 +234,11 @@ stmmac_set_pauseparam(struct net_device *netdev,
                new_pause |= FLOW_TX;
        priv->flow_ctrl = new_pause;
+        phy->autoneg = pause->autoneg;
        if (phy->autoneg) {
-                if (netif_running(netdev)) {
+                if (netif_running(netdev))
-                        struct ethtool_cmd cmd;
+                        ret = phy_start_aneg(phy);
-                        /* auto-negotiation automatically restarted */
-                        cmd.cmd = ETHTOOL_NWAY_RST;
-                        cmd.supported = phy->supported;
-                        cmd.advertising = phy->advertising;
-                        cmd.autoneg = phy->autoneg;
-                        cmd.speed = phy->speed;
-                        cmd.duplex = phy->duplex;
-                        cmd.phy_address = phy->addr;
-                        ret = phy_ethtool_sset(phy, &cmd);
-                }
        } else
                priv->hw->mac->flow_ctrl(priv->ioaddr, phy->duplex,
                                         priv->flow_ctrl, priv->pause);
@@ -315,7 +299,7 @@ static void stmmac_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
        spin_lock_irq(&priv->lock);
        if (device_can_wakeup(priv->device)) {
-                wol->supported = WAKE_MAGIC;
+                wol->supported = WAKE_MAGIC | WAKE_UCAST;
                wol->wolopts = priv->wolopts;
        }
        spin_unlock_irq(&priv->lock);
@@ -324,7 +308,7 @@ static void stmmac_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
 static int stmmac_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
 {
        struct stmmac_priv *priv = netdev_priv(dev);
-        u32 support = WAKE_MAGIC;
+        u32 support = WAKE_MAGIC | WAKE_UCAST;
        if (!device_can_wakeup(priv->device))
                return -EINVAL;
@@ -358,11 +342,6 @@ static struct ethtool_ops stmmac_ethtool_ops = {
        .get_regs = stmmac_ethtool_gregs,
        .get_regs_len = stmmac_ethtool_get_regs_len,
        .get_link = ethtool_op_get_link,
-        .get_rx_csum = stmmac_ethtool_get_rx_csum,
-        .get_tx_csum = ethtool_op_get_tx_csum,
-        .set_tx_csum = ethtool_op_set_tx_ipv6_csum,
-        .get_sg = ethtool_op_get_sg,
-        .set_sg = ethtool_op_set_sg,
        .get_pauseparam = stmmac_get_pauseparam,
        .set_pauseparam = stmmac_set_pauseparam,
        .get_ethtool_stats = stmmac_get_ethtool_stats,
@@ -370,8 +349,6 @@ static struct ethtool_ops stmmac_ethtool_ops = {
        .get_wol = stmmac_get_wol,
        .set_wol = stmmac_set_wol,
        .get_sset_count = stmmac_get_sset_count,
-        .get_tso = ethtool_op_get_tso,
-        .set_tso = ethtool_op_set_tso,
 };
 void stmmac_set_ethtool_ops(struct net_device *netdev)
diff --git a/drivers/net/stmmac/stmmac_main.c b/drivers/net/stmmac/stmmac_main.c
index cc973fc38405..e15c4a0bb96d 100644
--- a/drivers/net/stmmac/stmmac_main.c
+++ b/drivers/net/stmmac/stmmac_main.c
@@ -116,9 +116,6 @@ static int tc = TC_DEFAULT;
 module_param(tc, int, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(tc, "DMA threshold control value");
-#define RX_NO_COALESCE  1       /* Always interrupt on completion */
-#define TX_NO_COALESCE  -1      /* No moderation by default */
 /* Pay attention to tune this parameter; take care of both
 * hardware capability and network stabitily/performance impact.
 * Many tests showed that ~4ms latency seems to be good enough. */
@@ -139,7 +136,6 @@ static const u32 default_msg_level = (NETIF_MSG_DRV | NETIF_MSG_PROBE |
                                      NETIF_MSG_IFDOWN | NETIF_MSG_TIMER);
 static irqreturn_t stmmac_interrupt(int irq, void *dev_id);
-static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev);
 /**
 * stmmac_verify_args - verify the driver parameters.
@@ -831,6 +827,7 @@ static int stmmac_open(struct net_device *dev)
                pr_info("stmmac: Rx Checksum Offload Engine supported\n");
        if (priv->plat->tx_coe)
                pr_info("\tTX Checksum insertion supported\n");
+        netdev_update_features(dev);
        /* Initialise the MMC (if present) to disable all interrupts. */
        writel(0xffffffff, priv->ioaddr + MMC_HIGH_INTR_MASK);
@@ -934,46 +931,6 @@ static int stmmac_release(struct net_device *dev)
        return 0;
 }
-/*
- * To perform emulated hardware segmentation on skb.
- */
-static int stmmac_sw_tso(struct stmmac_priv *priv, struct sk_buff *skb)
-{
-        struct sk_buff *segs, *curr_skb;
-        int gso_segs = skb_shinfo(skb)->gso_segs;
-        /* Estimate the number of fragments in the worst case */
-        if (unlikely(stmmac_tx_avail(priv) < gso_segs)) {
-                netif_stop_queue(priv->dev);
-                TX_DBG(KERN_ERR "%s: TSO BUG! Tx Ring full when queue awake\n",
-                       __func__);
-                if (stmmac_tx_avail(priv) < gso_segs)
-                        return NETDEV_TX_BUSY;
-                netif_wake_queue(priv->dev);
-        }
-        TX_DBG("\tstmmac_sw_tso: segmenting: skb %p (len %d)\n",
-               skb, skb->len);
-        segs = skb_gso_segment(skb, priv->dev->features & ~NETIF_F_TSO);
-        if (IS_ERR(segs))
-                goto sw_tso_end;
-        do {
-                curr_skb = segs;
-                segs = segs->next;
-                TX_DBG("\t\tcurrent skb->len: %d, *curr %p,"
-                       "*next %p\n", curr_skb->len, curr_skb, segs);
-                curr_skb->next = NULL;
-                stmmac_xmit(curr_skb, priv->dev);
-        } while (segs);
-sw_tso_end:
-        dev_kfree_skb(skb);
-        return NETDEV_TX_OK;
-}
 static unsigned int stmmac_handle_jumbo_frames(struct sk_buff *skb,
                                               struct net_device *dev,
                                               int csum_insertion)
@@ -1051,16 +1008,7 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
                       !skb_is_gso(skb) ? "isn't" : "is");
 #endif
-        if (unlikely(skb_is_gso(skb)))
+        csum_insertion = (skb->ip_summed == CHECKSUM_PARTIAL);
-                return stmmac_sw_tso(priv, skb);
-        if (likely((skb->ip_summed == CHECKSUM_PARTIAL))) {
-                if (unlikely((!priv->plat->tx_coe) ||
-                             (priv->no_csum_insertion)))
-                        skb_checksum_help(skb);
-                else
-                        csum_insertion = 1;
-        }
        desc = priv->dma_tx + entry;
        first = desc;
@@ -1380,18 +1328,29 @@ static int stmmac_change_mtu(struct net_device *dev, int new_mtu)
                return -EINVAL;
        }
+        dev->mtu = new_mtu;
+        netdev_update_features(dev);
+        return 0;
+}
+static u32 stmmac_fix_features(struct net_device *dev, u32 features)
+{
+        struct stmmac_priv *priv = netdev_priv(dev);
+        if (!priv->rx_coe)
+                features &= ~NETIF_F_RXCSUM;
+        if (!priv->plat->tx_coe)
+                features &= ~NETIF_F_ALL_CSUM;
        /* Some GMAC devices have a bugged Jumbo frame support that
         * needs to have the Tx COE disabled for oversized frames
         * (due to limited buffer sizes). In this case we disable
         * the TX csum insertionin the TDES and not use SF. */
-        if ((priv->plat->bugged_jumbo) && (priv->dev->mtu > ETH_DATA_LEN))
+        if (priv->plat->bugged_jumbo && (dev->mtu > ETH_DATA_LEN))
-                priv->no_csum_insertion = 1;
+                features &= ~NETIF_F_ALL_CSUM;
-        else
-                priv->no_csum_insertion = 0;
-        dev->mtu = new_mtu;
+        return features;
-        return 0;
 }
 static irqreturn_t stmmac_interrupt(int irq, void *dev_id)
@@ -1471,6 +1430,7 @@ static const struct net_device_ops stmmac_netdev_ops = {
        .ndo_start_xmit = stmmac_xmit,
        .ndo_stop = stmmac_release,
        .ndo_change_mtu = stmmac_change_mtu,
+        .ndo_fix_features = stmmac_fix_features,
        .ndo_set_multicast_list = stmmac_multicast_list,
        .ndo_tx_timeout = stmmac_tx_timeout,
        .ndo_do_ioctl = stmmac_ioctl,
@@ -1501,8 +1461,8 @@ static int stmmac_probe(struct net_device *dev)
        dev->netdev_ops = &stmmac_netdev_ops;
        stmmac_set_ethtool_ops(dev);
-        dev->features |= NETIF_F_SG | NETIF_F_HIGHDMA |
+        dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
-                NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
+        dev->features |= dev->hw_features | NETIF_F_HIGHDMA;
        dev->watchdog_timeo = msecs_to_jiffies(watchdog);
 #ifdef STMMAC_VLAN_TAG_USED
        /* Both mac100 and gmac support receive VLAN tag detection */
diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index d3be735c4719..ab5930099267 100644
--- a/drivers/net/sungem.c
+++ b/drivers/net/sungem.c
@@ -1294,7 +1294,7 @@ static void gem_begin_auto_negotiation(struct gem *gp, struct ethtool_cmd *ep)
                autoneg = 1;
        } else {
                autoneg = 0;
-                speed = ep->speed;
+                speed = ethtool_cmd_speed(ep);
                duplex = ep->duplex;
        }
@@ -2642,7 +2642,7 @@ static int gem_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                /* Return current PHY settings */
                spin_lock_irq(&gp->lock);
                cmd->autoneg = gp->want_autoneg;
-                cmd->speed = gp->phy_mii.speed;
+                ethtool_cmd_speed_set(cmd, gp->phy_mii.speed);
                cmd->duplex = gp->phy_mii.duplex;
                cmd->advertising = gp->phy_mii.advertising;
@@ -2659,7 +2659,7 @@ static int gem_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                         SUPPORTED_100baseT_Half | SUPPORTED_100baseT_Full |
                         SUPPORTED_Autoneg);
                cmd->advertising = cmd->supported;
-                cmd->speed = 0;
+                ethtool_cmd_speed_set(cmd, 0);
                cmd->duplex = cmd->port = cmd->phy_address =
                        cmd->transceiver = cmd->autoneg = 0;
@@ -2673,7 +2673,7 @@ static int gem_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                        cmd->advertising = cmd->supported;
                        cmd->transceiver = XCVR_INTERNAL;
                        if (gp->lstate == link_up)
-                                cmd->speed = SPEED_1000;
+                                ethtool_cmd_speed_set(cmd, SPEED_1000);
                        cmd->duplex = DUPLEX_FULL;
                        cmd->autoneg = 1;
                }
@@ -2686,6 +2686,7 @@ static int gem_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 static int gem_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        struct gem *gp = netdev_priv(dev);
+        u32 speed = ethtool_cmd_speed(cmd);
        /* Verify the settings we care about. */
        if (cmd->autoneg != AUTONEG_ENABLE &&
@@ -2697,9 +2698,9 @@ static int gem_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                return -EINVAL;
        if (cmd->autoneg == AUTONEG_DISABLE &&
-            ((cmd->speed != SPEED_1000 &&
+            ((speed != SPEED_1000 &&
-              cmd->speed != SPEED_100 &&
+              speed != SPEED_100 &&
-              cmd->speed != SPEED_10) ||
+              speed != SPEED_10) ||
             (cmd->duplex != DUPLEX_HALF &&
              cmd->duplex != DUPLEX_FULL)))
                return -EINVAL;
@@ -3146,7 +3147,8 @@ static int __devinit gem_init_one(struct pci_dev *pdev,
                            gp->phy_mii.def ? gp->phy_mii.def->name : "no");
        /* GEM can do it all... */
-        dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_LLTX;
+        dev->hw_features = NETIF_F_SG | NETIF_F_HW_CSUM;
+        dev->features |= dev->hw_features | NETIF_F_RXCSUM | NETIF_F_LLTX;
        if (pci_using_dac)
                dev->features |= NETIF_F_HIGHDMA;
diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c
index bff2f7999ff0..30aad54b1b3a 100644
--- a/drivers/net/sunhme.c
+++ b/drivers/net/sunhme.c
@@ -1383,7 +1383,7 @@ force_link:
                if (ep == NULL || ep->autoneg == AUTONEG_ENABLE) {
                        hp->sw_bmcr = BMCR_SPEED100;
                } else {
-                        if (ep->speed == SPEED_100)
+                        if (ethtool_cmd_speed(ep) == SPEED_100)
                                hp->sw_bmcr = BMCR_SPEED100;
                        else
                                hp->sw_bmcr = 0;
@@ -2401,6 +2401,7 @@ static void happy_meal_set_multicast(struct net_device *dev)
 static int hme_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        struct happy_meal *hp = netdev_priv(dev);
+        u32 speed;
        cmd->supported =
                (SUPPORTED_10baseT_Half | SUPPORTED_10baseT_Full |
@@ -2420,10 +2421,9 @@ static int hme_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        if (hp->sw_bmcr & BMCR_ANENABLE) {
                cmd->autoneg = AUTONEG_ENABLE;
-                cmd->speed =
+                speed = ((hp->sw_lpa & (LPA_100HALF | LPA_100FULL)) ?
-                        (hp->sw_lpa & (LPA_100HALF | LPA_100FULL)) ?
+                         SPEED_100 : SPEED_10);
-                        SPEED_100 : SPEED_10;
+                if (speed == SPEED_100)
-                if (cmd->speed == SPEED_100)
                        cmd->duplex =
                                (hp->sw_lpa & (LPA_100FULL)) ?
                                DUPLEX_FULL : DUPLEX_HALF;
@@ -2433,13 +2433,12 @@ static int hme_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                                DUPLEX_FULL : DUPLEX_HALF;
        } else {
                cmd->autoneg = AUTONEG_DISABLE;
-                cmd->speed =
+                speed = (hp->sw_bmcr & BMCR_SPEED100) ? SPEED_100 : SPEED_10;
-                        (hp->sw_bmcr & BMCR_SPEED100) ?
-                        SPEED_100 : SPEED_10;
                cmd->duplex =
                        (hp->sw_bmcr & BMCR_FULLDPLX) ?
                        DUPLEX_FULL : DUPLEX_HALF;
        }
+        ethtool_cmd_speed_set(cmd, speed);
        return 0;
 }
@@ -2452,8 +2451,8 @@ static int hme_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
            cmd->autoneg != AUTONEG_DISABLE)
                return -EINVAL;
        if (cmd->autoneg == AUTONEG_DISABLE &&
-            ((cmd->speed != SPEED_100 &&
+            ((ethtool_cmd_speed(cmd) != SPEED_100 &&
-              cmd->speed != SPEED_10) ||
+              ethtool_cmd_speed(cmd) != SPEED_10) ||
             (cmd->duplex != DUPLEX_HALF &&
              cmd->duplex != DUPLEX_FULL)))
                return -EINVAL;
@@ -2788,7 +2787,8 @@ static int __devinit happy_meal_sbus_probe_one(struct platform_device *op, int i
        dev->ethtool_ops = &hme_ethtool_ops;
        /* Happy Meal can do it all... */
-        dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
+        dev->hw_features = NETIF_F_SG | NETIF_F_HW_CSUM;
+        dev->features |= dev->hw_features | NETIF_F_RXCSUM;
        dev->irq = op->archdata.irqs[0];
@@ -3113,7 +3113,8 @@ static int __devinit happy_meal_pci_probe(struct pci_dev *pdev,
        dev->dma = 0;
        /* Happy Meal can do it all... */
-        dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
+        dev->hw_features = NETIF_F_SG | NETIF_F_HW_CSUM;
+        dev->features |= dev->hw_features | NETIF_F_RXCSUM;
 #if defined(CONFIG_SBUS) && defined(CONFIG_PCI)
        /* Hook up PCI register/descriptor accessors. */
diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c
index 8564ec5cfb7f..80fbee0d40af 100644
--- a/drivers/net/tehuti.c
+++ b/drivers/net/tehuti.c
@@ -2017,9 +2017,11 @@ bdx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                ndev->irq = pdev->irq;
                ndev->features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO
                    | NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |
-                    NETIF_F_HW_VLAN_FILTER
+                    NETIF_F_HW_VLAN_FILTER | NETIF_F_RXCSUM
                    /*| NETIF_F_FRAGLIST */
                    ;
+                ndev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG |
+                        NETIF_F_TSO | NETIF_F_HW_VLAN_TX;
                if (pci_using_dac)
                        ndev->features |= NETIF_F_HIGHDMA;
@@ -2149,7 +2151,7 @@ static int bdx_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
        ecmd->supported = (SUPPORTED_10000baseT_Full | SUPPORTED_FIBRE);
        ecmd->advertising = (ADVERTISED_10000baseT_Full | ADVERTISED_FIBRE);
-        ecmd->speed = SPEED_10000;
+        ethtool_cmd_speed_set(ecmd, SPEED_10000);
        ecmd->duplex = DUPLEX_FULL;
        ecmd->port = PORT_FIBRE;
        ecmd->transceiver = XCVR_EXTERNAL;      /* what does it mean? */
@@ -2188,24 +2190,6 @@ bdx_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo)
 }
 /*
- * bdx_get_rx_csum - report whether receive checksums are turned on or off
- * @netdev
- */
-static u32 bdx_get_rx_csum(struct net_device *netdev)
-{
-        return 1;               /* always on */
-}
-/*
- * bdx_get_tx_csum - report whether transmit checksums are turned on or off
- * @netdev
- */
-static u32 bdx_get_tx_csum(struct net_device *netdev)
-{
-        return (netdev->features & NETIF_F_IP_CSUM) != 0;
-}
-/*
 * bdx_get_coalesce - get interrupt coalescing parameters
 * @netdev
 * @ecoal
@@ -2424,10 +2408,6 @@ static void bdx_set_ethtool_ops(struct net_device *netdev)
                .set_coalesce = bdx_set_coalesce,
                .get_ringparam = bdx_get_ringparam,
                .set_ringparam = bdx_set_ringparam,
-                .get_rx_csum = bdx_get_rx_csum,
-                .get_tx_csum = bdx_get_tx_csum,
-                .get_sg = ethtool_op_get_sg,
-                .get_tso = ethtool_op_get_tso,
                .get_strings = bdx_get_strings,
                .get_sset_count = bdx_get_sset_count,
                .get_ethtool_stats = bdx_get_ethtool_stats,
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 7a5daefb6f33..db19332a7d87 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -62,12 +62,36 @@
 #include "tg3.h"
+/* Functions & macros to verify TG3_FLAGS types */
+static inline int _tg3_flag(enum TG3_FLAGS flag, unsigned long *bits)
+{
+        return test_bit(flag, bits);
+}
+static inline void _tg3_flag_set(enum TG3_FLAGS flag, unsigned long *bits)
+{
+        set_bit(flag, bits);
+}
+static inline void _tg3_flag_clear(enum TG3_FLAGS flag, unsigned long *bits)
+{
+        clear_bit(flag, bits);
+}
+#define tg3_flag(tp, flag)                              \
+        _tg3_flag(TG3_FLAG_##flag, (tp)->tg3_flags)
+#define tg3_flag_set(tp, flag)                          \
+        _tg3_flag_set(TG3_FLAG_##flag, (tp)->tg3_flags)
+#define tg3_flag_clear(tp, flag)                        \
+        _tg3_flag_clear(TG3_FLAG_##flag, (tp)->tg3_flags)
 #define DRV_MODULE_NAME         "tg3"
 #define TG3_MAJ_NUM                     3
-#define TG3_MIN_NUM                     117
+#define TG3_MIN_NUM                     119
 #define DRV_MODULE_VERSION      \
        __stringify(TG3_MAJ_NUM) "." __stringify(TG3_MIN_NUM)
-#define DRV_MODULE_RELDATE      "January 25, 2011"
+#define DRV_MODULE_RELDATE      "May 18, 2011"
 #define TG3_DEF_MAC_MODE        0
 #define TG3_DEF_RX_MODE         0
@@ -85,26 +109,25 @@
 /* length of time before we decide the hardware is borked,
 * and dev->tx_timeout() should be called to fix the problem
 */
 #define TG3_TX_TIMEOUT                  (5 * HZ)
 /* hardware minimum and maximum for a single frame's data payload */
 #define TG3_MIN_MTU                     60
 #define TG3_MAX_MTU(tp) \
-        ((tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) ? 9000 : 1500)
+        (tg3_flag(tp, JUMBO_CAPABLE) ? 9000 : 1500)
 /* These numbers seem to be hard coded in the NIC firmware somehow.
 * You can't change the ring sizes, but you can change where you place
 * them in the NIC onboard memory.
 */
 #define TG3_RX_STD_RING_SIZE(tp) \
-        ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 || \
+        (tg3_flag(tp, LRG_PROD_RING_CAP) ? \
-          GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) ? \
+         TG3_RX_STD_MAX_SIZE_5717 : TG3_RX_STD_MAX_SIZE_5700)
-         RX_STD_MAX_SIZE_5717 : 512)
 #define TG3_DEF_RX_RING_PENDING         200
 #define TG3_RX_JMB_RING_SIZE(tp) \
-        ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 || \
+        (tg3_flag(tp, LRG_PROD_RING_CAP) ? \
-          GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) ? \
+         TG3_RX_JMB_MAX_SIZE_5717 : TG3_RX_JMB_MAX_SIZE_5700)
-         1024 : 256)
 #define TG3_DEF_RX_JUMBO_RING_PENDING   100
 #define TG3_RSS_INDIR_TBL_SIZE          128
@@ -167,11 +190,6 @@
 #define TG3_RAW_IP_ALIGN 2
-/* number of ETHTOOL_GSTATS u64's */
-#define TG3_NUM_STATS           (sizeof(struct tg3_ethtool_stats)/sizeof(u64))
-#define TG3_NUM_TEST            6
 #define TG3_FW_UPDATE_TIMEOUT_SEC       5
 #define FIRMWARE_TG3            "tigon/tg3.bin"
@@ -266,6 +284,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
        {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57791)},
        {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
        {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
+        {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
        {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
        {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
        {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
@@ -280,7 +299,7 @@ MODULE_DEVICE_TABLE(pci, tg3_pci_tbl);
 static const struct {
        const char string[ETH_GSTRING_LEN];
-} ethtool_stats_keys[TG3_NUM_STATS] = {
+} ethtool_stats_keys[] = {
        { "rx_octets" },
        { "rx_fragments" },
        { "rx_ucast_packets" },
@@ -356,12 +375,17 @@ static const struct {
        { "ring_status_update" },
        { "nic_irqs" },
        { "nic_avoided_irqs" },
-        { "nic_tx_threshold_hit" }
+        { "nic_tx_threshold_hit" },
+        { "mbuf_lwm_thresh_hit" },
 };
+#define TG3_NUM_STATS   ARRAY_SIZE(ethtool_stats_keys)
 static const struct {
        const char string[ETH_GSTRING_LEN];
-} ethtool_test_keys[TG3_NUM_TEST] = {
+} ethtool_test_keys[] = {
        { "nvram test     (online) " },
        { "link test      (online) " },
        { "register test  (offline)" },
@@ -370,6 +394,9 @@ static const struct {
        { "interrupt test (offline)" },
 };
+#define TG3_NUM_TEST    ARRAY_SIZE(ethtool_test_keys)
 static void tg3_write32(struct tg3 *tp, u32 off, u32 val)
 {
        writel(val, tp->regs + off);
@@ -467,8 +494,7 @@ static u32 tg3_read_indirect_mbox(struct tg3 *tp, u32 off)
 */
 static void _tw32_flush(struct tg3 *tp, u32 off, u32 val, u32 usec_wait)
 {
-        if ((tp->tg3_flags & TG3_FLAG_PCIX_TARGET_HWBUG) ||
+        if (tg3_flag(tp, PCIX_TARGET_HWBUG) || tg3_flag(tp, ICH_WORKAROUND))
-            (tp->tg3_flags2 & TG3_FLG2_ICH_WORKAROUND))
                /* Non-posted methods */
                tp->write32(tp, off, val);
        else {
@@ -488,8 +514,7 @@ static void _tw32_flush(struct tg3 *tp, u32 off, u32 val, u32 usec_wait)
 static inline void tw32_mailbox_flush(struct tg3 *tp, u32 off, u32 val)
 {
        tp->write32_mbox(tp, off, val);
-        if (!(tp->tg3_flags & TG3_FLAG_MBOX_WRITE_REORDER) &&
+        if (!tg3_flag(tp, MBOX_WRITE_REORDER) && !tg3_flag(tp, ICH_WORKAROUND))
-            !(tp->tg3_flags2 & TG3_FLG2_ICH_WORKAROUND))
                tp->read32_mbox(tp, off);
 }
@@ -497,9 +522,9 @@ static void tg3_write32_tx_mbox(struct tg3 *tp, u32 off, u32 val)
 {
        void __iomem *mbox = tp->regs + off;
        writel(val, mbox);
-        if (tp->tg3_flags & TG3_FLAG_TXD_MBOX_HWBUG)
+        if (tg3_flag(tp, TXD_MBOX_HWBUG))
                writel(val, mbox);
-        if (tp->tg3_flags & TG3_FLAG_MBOX_WRITE_REORDER)
+        if (tg3_flag(tp, MBOX_WRITE_REORDER))
                readl(mbox);
 }
@@ -528,12 +553,12 @@ static void tg3_write_mem(struct tg3 *tp, u32 off, u32 val)
 {
        unsigned long flags;
-        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906) &&
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906 &&
            (off >= NIC_SRAM_STATS_BLK) && (off < NIC_SRAM_TX_BUFFER_DESC))
                return;
        spin_lock_irqsave(&tp->indirect_lock, flags);
-        if (tp->tg3_flags & TG3_FLAG_SRAM_USE_CONFIG) {
+        if (tg3_flag(tp, SRAM_USE_CONFIG)) {
                pci_write_config_dword(tp->pdev, TG3PCI_MEM_WIN_BASE_ADDR, off);
                pci_write_config_dword(tp->pdev, TG3PCI_MEM_WIN_DATA, val);
@@ -553,14 +578,14 @@ static void tg3_read_mem(struct tg3 *tp, u32 off, u32 *val)
 {
        unsigned long flags;
-        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906) &&
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906 &&
            (off >= NIC_SRAM_STATS_BLK) && (off < NIC_SRAM_TX_BUFFER_DESC)) {
                *val = 0;
                return;
        }
        spin_lock_irqsave(&tp->indirect_lock, flags);
-        if (tp->tg3_flags & TG3_FLAG_SRAM_USE_CONFIG) {
+        if (tg3_flag(tp, SRAM_USE_CONFIG)) {
                pci_write_config_dword(tp->pdev, TG3PCI_MEM_WIN_BASE_ADDR, off);
                pci_read_config_dword(tp->pdev, TG3PCI_MEM_WIN_DATA, val);
@@ -597,7 +622,7 @@ static int tg3_ape_lock(struct tg3 *tp, int locknum)
        int ret = 0;
        u32 status, req, gnt;
-        if (!(tp->tg3_flags3 & TG3_FLG3_ENABLE_APE))
+        if (!tg3_flag(tp, ENABLE_APE))
                return 0;
        switch (locknum) {
@@ -643,7 +668,7 @@ static void tg3_ape_unlock(struct tg3 *tp, int locknum)
 {
        u32 gnt;
-        if (!(tp->tg3_flags3 & TG3_FLG3_ENABLE_APE))
+        if (!tg3_flag(tp, ENABLE_APE))
                return;
        switch (locknum) {
@@ -687,14 +712,14 @@ static void tg3_enable_ints(struct tg3 *tp)
                struct tg3_napi *tnapi = &tp->napi[i];
                tw32_mailbox_f(tnapi->int_mbox, tnapi->last_tag << 24);
-                if (tp->tg3_flags2 & TG3_FLG2_1SHOT_MSI)
+                if (tg3_flag(tp, 1SHOT_MSI))
                        tw32_mailbox_f(tnapi->int_mbox, tnapi->last_tag << 24);
                tp->coal_now |= tnapi->coal_now;
        }
        /* Force an initial interrupt */
-        if (!(tp->tg3_flags & TG3_FLAG_TAGGED_STATUS) &&
+        if (!tg3_flag(tp, TAGGED_STATUS) &&
            (tp->napi[0].hw_status->status & SD_STATUS_UPDATED))
                tw32(GRC_LOCAL_CTRL, tp->grc_local_ctrl | GRC_LCLCTRL_SETINT);
        else
@@ -710,9 +735,7 @@ static inline unsigned int tg3_has_work(struct tg3_napi *tnapi)
        unsigned int work_exists = 0;
        /* check for phy events */
-        if (!(tp->tg3_flags &
+        if (!(tg3_flag(tp, USE_LINKCHG_REG) || tg3_flag(tp, POLL_SERDES))) {
-              (TG3_FLAG_USE_LINKCHG_REG |
-               TG3_FLAG_POLL_SERDES))) {
                if (sblk->status & SD_STATUS_LINK_CHG)
                        work_exists = 1;
        }
@@ -740,8 +763,7 @@ static void tg3_int_reenable(struct tg3_napi *tnapi)
         * The last_tag we write above tells the chip which piece of
         * work we've completed.
         */
-        if (!(tp->tg3_flags & TG3_FLAG_TAGGED_STATUS) &&
+        if (!tg3_flag(tp, TAGGED_STATUS) && tg3_has_work(tnapi))
-            tg3_has_work(tnapi))
                tw32(HOSTCC_MODE, tp->coalesce_mode |
                     HOSTCC_MODE_ENABLE | tnapi->coal_now);
 }
@@ -751,8 +773,7 @@ static void tg3_switch_clocks(struct tg3 *tp)
        u32 clock_ctrl;
        u32 orig_clock_ctrl;
-        if ((tp->tg3_flags & TG3_FLAG_CPMU_PRESENT) ||
+        if (tg3_flag(tp, CPMU_PRESENT) || tg3_flag(tp, 5780_CLASS))
-            (tp->tg3_flags2 & TG3_FLG2_5780_CLASS))
                return;
        clock_ctrl = tr32(TG3PCI_CLOCK_CTRL);
@@ -763,7 +784,7 @@ static void tg3_switch_clocks(struct tg3 *tp)
                       0x1f);
        tp->pci_clock_ctrl = clock_ctrl;
-        if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS) {
+        if (tg3_flag(tp, 5705_PLUS)) {
                if (orig_clock_ctrl & CLOCK_CTRL_625_CORE) {
                        tw32_wait_f(TG3PCI_CLOCK_CTRL,
                                    clock_ctrl | CLOCK_CTRL_625_CORE, 40);
@@ -880,6 +901,104 @@ static int tg3_writephy(struct tg3 *tp, int reg, u32 val)
        return ret;
 }
+static int tg3_phy_cl45_write(struct tg3 *tp, u32 devad, u32 addr, u32 val)
+{
+        int err;
+        err = tg3_writephy(tp, MII_TG3_MMD_CTRL, devad);
+        if (err)
+                goto done;
+        err = tg3_writephy(tp, MII_TG3_MMD_ADDRESS, addr);
+        if (err)
+                goto done;
+        err = tg3_writephy(tp, MII_TG3_MMD_CTRL,
+                           MII_TG3_MMD_CTRL_DATA_NOINC | devad);
+        if (err)
+                goto done;
+        err = tg3_writephy(tp, MII_TG3_MMD_ADDRESS, val);
+done:
+        return err;
+}
+static int tg3_phy_cl45_read(struct tg3 *tp, u32 devad, u32 addr, u32 *val)
+{
+        int err;
+        err = tg3_writephy(tp, MII_TG3_MMD_CTRL, devad);
+        if (err)
+                goto done;
+        err = tg3_writephy(tp, MII_TG3_MMD_ADDRESS, addr);
+        if (err)
+                goto done;
+        err = tg3_writephy(tp, MII_TG3_MMD_CTRL,
+                           MII_TG3_MMD_CTRL_DATA_NOINC | devad);
+        if (err)
+                goto done;
+        err = tg3_readphy(tp, MII_TG3_MMD_ADDRESS, val);
+done:
+        return err;
+}
+static int tg3_phydsp_read(struct tg3 *tp, u32 reg, u32 *val)
+{
+        int err;
+        err = tg3_writephy(tp, MII_TG3_DSP_ADDRESS, reg);
+        if (!err)
+                err = tg3_readphy(tp, MII_TG3_DSP_RW_PORT, val);
+        return err;
+}
+static int tg3_phydsp_write(struct tg3 *tp, u32 reg, u32 val)
+{
+        int err;
+        err = tg3_writephy(tp, MII_TG3_DSP_ADDRESS, reg);
+        if (!err)
+                err = tg3_writephy(tp, MII_TG3_DSP_RW_PORT, val);
+        return err;
+}
+static int tg3_phy_auxctl_read(struct tg3 *tp, int reg, u32 *val)
+{
+        int err;
+        err = tg3_writephy(tp, MII_TG3_AUX_CTRL,
+                           (reg << MII_TG3_AUXCTL_MISC_RDSEL_SHIFT) |
+                           MII_TG3_AUXCTL_SHDWSEL_MISC);
+        if (!err)
+                err = tg3_readphy(tp, MII_TG3_AUX_CTRL, val);
+        return err;
+}
+static int tg3_phy_auxctl_write(struct tg3 *tp, int reg, u32 set)
+{
+        if (reg == MII_TG3_AUXCTL_SHDWSEL_MISC)
+                set |= MII_TG3_AUXCTL_MISC_WREN;
+        return tg3_writephy(tp, MII_TG3_AUX_CTRL, set | reg);
+}
+#define TG3_PHY_AUXCTL_SMDSP_ENABLE(tp) \
+        tg3_phy_auxctl_write((tp), MII_TG3_AUXCTL_SHDWSEL_AUXCTL, \
+                             MII_TG3_AUXCTL_ACTL_SMDSP_ENA | \
+                             MII_TG3_AUXCTL_ACTL_TX_6DB)
+#define TG3_PHY_AUXCTL_SMDSP_DISABLE(tp) \
+        tg3_phy_auxctl_write((tp), MII_TG3_AUXCTL_SHDWSEL_AUXCTL, \
+                             MII_TG3_AUXCTL_ACTL_TX_6DB);
 static int tg3_bmcr_reset(struct tg3 *tp)
 {
        u32 phy_control;
@@ -982,7 +1101,7 @@ static void tg3_mdio_config_5785(struct tg3 *tp)
                return;
        }
-        if (!(tp->tg3_flags3 & TG3_FLG3_RGMII_INBAND_DISABLE))
+        if (!tg3_flag(tp, RGMII_INBAND_DISABLE))
                val |= MAC_PHYCFG2_EMODE_MASK_MASK |
                       MAC_PHYCFG2_FMODE_MASK_MASK |
                       MAC_PHYCFG2_GMODE_MASK_MASK |
@@ -995,10 +1114,10 @@ static void tg3_mdio_config_5785(struct tg3 *tp)
        val = tr32(MAC_PHYCFG1);
        val &= ~(MAC_PHYCFG1_RXCLK_TO_MASK | MAC_PHYCFG1_TXCLK_TO_MASK |
                 MAC_PHYCFG1_RGMII_EXT_RX_DEC | MAC_PHYCFG1_RGMII_SND_STAT_EN);
-        if (!(tp->tg3_flags3 & TG3_FLG3_RGMII_INBAND_DISABLE)) {
+        if (!tg3_flag(tp, RGMII_INBAND_DISABLE)) {
-                if (tp->tg3_flags3 & TG3_FLG3_RGMII_EXT_IBND_RX_EN)
+                if (tg3_flag(tp, RGMII_EXT_IBND_RX_EN))
                        val |= MAC_PHYCFG1_RGMII_EXT_RX_DEC;
-                if (tp->tg3_flags3 & TG3_FLG3_RGMII_EXT_IBND_TX_EN)
+                if (tg3_flag(tp, RGMII_EXT_IBND_TX_EN))
                        val |= MAC_PHYCFG1_RGMII_SND_STAT_EN;
        }
        val |= MAC_PHYCFG1_RXCLK_TIMEOUT | MAC_PHYCFG1_TXCLK_TIMEOUT |
@@ -1013,13 +1132,13 @@ static void tg3_mdio_config_5785(struct tg3 *tp)
                 MAC_RGMII_MODE_TX_ENABLE |
                 MAC_RGMII_MODE_TX_LOWPWR |
                 MAC_RGMII_MODE_TX_RESET);
-        if (!(tp->tg3_flags3 & TG3_FLG3_RGMII_INBAND_DISABLE)) {
+        if (!tg3_flag(tp, RGMII_INBAND_DISABLE)) {
-                if (tp->tg3_flags3 & TG3_FLG3_RGMII_EXT_IBND_RX_EN)
+                if (tg3_flag(tp, RGMII_EXT_IBND_RX_EN))
                        val |= MAC_RGMII_MODE_RX_INT_B |
                               MAC_RGMII_MODE_RX_QUALITY |
                               MAC_RGMII_MODE_RX_ACTIVITY |
                               MAC_RGMII_MODE_RX_ENG_DET;
-                if (tp->tg3_flags3 & TG3_FLG3_RGMII_EXT_IBND_TX_EN)
+                if (tg3_flag(tp, RGMII_EXT_IBND_TX_EN))
                        val |= MAC_RGMII_MODE_TX_ENABLE |
                               MAC_RGMII_MODE_TX_LOWPWR |
                               MAC_RGMII_MODE_TX_RESET;
@@ -1033,7 +1152,7 @@ static void tg3_mdio_start(struct tg3 *tp)
        tw32_f(MAC_MI_MODE, tp->mi_mode);
        udelay(80);
-        if ((tp->tg3_flags3 & TG3_FLG3_MDIOBUS_INITED) &&
+        if (tg3_flag(tp, MDIOBUS_INITED) &&
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785)
                tg3_mdio_config_5785(tp);
 }
@@ -1044,8 +1163,7 @@ static int tg3_mdio_init(struct tg3 *tp)
        u32 reg;
        struct phy_device *phydev;
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+        if (tg3_flag(tp, 5717_PLUS)) {
-            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) {
                u32 is_serdes;
                tp->phy_addr = PCI_FUNC(tp->pdev->devfn) + 1;
@@ -1062,8 +1180,7 @@ static int tg3_mdio_init(struct tg3 *tp)
        tg3_mdio_start(tp);
-        if (!(tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB) ||
+        if (!tg3_flag(tp, USE_PHYLIB) || tg3_flag(tp, MDIOBUS_INITED))
-            (tp->tg3_flags3 & TG3_FLG3_MDIOBUS_INITED))
                return 0;
        tp->mdio_bus = mdiobus_alloc();
@@ -1119,11 +1236,11 @@ static int tg3_mdio_init(struct tg3 *tp)
                                     PHY_BRCM_RX_REFCLK_UNUSED |
                                     PHY_BRCM_DIS_TXCRXC_NOENRGY |
                                     PHY_BRCM_AUTO_PWRDWN_ENABLE;
-                if (tp->tg3_flags3 & TG3_FLG3_RGMII_INBAND_DISABLE)
+                if (tg3_flag(tp, RGMII_INBAND_DISABLE))
                        phydev->dev_flags |= PHY_BRCM_STD_IBND_DISABLE;
-                if (tp->tg3_flags3 & TG3_FLG3_RGMII_EXT_IBND_RX_EN)
+                if (tg3_flag(tp, RGMII_EXT_IBND_RX_EN))
                        phydev->dev_flags |= PHY_BRCM_EXT_IBND_RX_ENABLE;
-                if (tp->tg3_flags3 & TG3_FLG3_RGMII_EXT_IBND_TX_EN)
+                if (tg3_flag(tp, RGMII_EXT_IBND_TX_EN))
                        phydev->dev_flags |= PHY_BRCM_EXT_IBND_TX_ENABLE;
                /* fallthru */
        case PHY_ID_RTL8211C:
@@ -1137,7 +1254,7 @@ static int tg3_mdio_init(struct tg3 *tp)
                break;
        }
-        tp->tg3_flags3 |= TG3_FLG3_MDIOBUS_INITED;
+        tg3_flag_set(tp, MDIOBUS_INITED);
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785)
                tg3_mdio_config_5785(tp);
@@ -1147,59 +1264,13 @@ static int tg3_mdio_init(struct tg3 *tp)
 static void tg3_mdio_fini(struct tg3 *tp)
 {
-        if (tp->tg3_flags3 & TG3_FLG3_MDIOBUS_INITED) {
+        if (tg3_flag(tp, MDIOBUS_INITED)) {
-                tp->tg3_flags3 &= ~TG3_FLG3_MDIOBUS_INITED;
+                tg3_flag_clear(tp, MDIOBUS_INITED);
                mdiobus_unregister(tp->mdio_bus);
                mdiobus_free(tp->mdio_bus);
        }
 }
-static int tg3_phy_cl45_write(struct tg3 *tp, u32 devad, u32 addr, u32 val)
-{
-        int err;
-        err = tg3_writephy(tp, MII_TG3_MMD_CTRL, devad);
-        if (err)
-                goto done;
-        err = tg3_writephy(tp, MII_TG3_MMD_ADDRESS, addr);
-        if (err)
-                goto done;
-        err = tg3_writephy(tp, MII_TG3_MMD_CTRL,
-                           MII_TG3_MMD_CTRL_DATA_NOINC | devad);
-        if (err)
-                goto done;
-        err = tg3_writephy(tp, MII_TG3_MMD_ADDRESS, val);
-done:
-        return err;
-}
-static int tg3_phy_cl45_read(struct tg3 *tp, u32 devad, u32 addr, u32 *val)
-{
-        int err;
-        err = tg3_writephy(tp, MII_TG3_MMD_CTRL, devad);
-        if (err)
-                goto done;
-        err = tg3_writephy(tp, MII_TG3_MMD_ADDRESS, addr);
-        if (err)
-                goto done;
-        err = tg3_writephy(tp, MII_TG3_MMD_CTRL,
-                           MII_TG3_MMD_CTRL_DATA_NOINC | devad);
-        if (err)
-                goto done;
-        err = tg3_readphy(tp, MII_TG3_MMD_ADDRESS, val);
-done:
-        return err;
-}
 /* tp->lock is held. */
 static inline void tg3_generate_fw_event(struct tg3 *tp)
 {
@@ -1247,8 +1318,7 @@ static void tg3_ump_link_report(struct tg3 *tp)
        u32 reg;
        u32 val;
-        if (!(tp->tg3_flags2 & TG3_FLG2_5780_CLASS) ||
+        if (!tg3_flag(tp, 5780_CLASS) || !tg3_flag(tp, ENABLE_ASF))
-            !(tp->tg3_flags  & TG3_FLAG_ENABLE_ASF))
                return;
        tg3_wait_for_event_ack(tp);
@@ -1308,6 +1378,11 @@ static void tg3_link_report(struct tg3 *tp)
                            "on" : "off",
                            (tp->link_config.active_flowctrl & FLOW_CTRL_RX) ?
                            "on" : "off");
+                if (tp->phy_flags & TG3_PHYFLG_EEE_CAP)
+                        netdev_info(tp->dev, "EEE is %s\n",
+                                    tp->setlpicnt ? "enabled" : "disabled");
                tg3_ump_link_report(tp);
        }
 }
@@ -1373,13 +1448,12 @@ static void tg3_setup_flow_control(struct tg3 *tp, u32 lcladv, u32 rmtadv)
        u32 old_rx_mode = tp->rx_mode;
        u32 old_tx_mode = tp->tx_mode;
-        if (tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB)
+        if (tg3_flag(tp, USE_PHYLIB))
                autoneg = tp->mdio_bus->phy_map[TG3_PHY_MII_ADDR]->autoneg;
        else
                autoneg = tp->link_config.autoneg;
-        if (autoneg == AUTONEG_ENABLE &&
+        if (autoneg == AUTONEG_ENABLE && tg3_flag(tp, PAUSE_AUTONEG)) {
-            (tp->tg3_flags & TG3_FLAG_PAUSE_AUTONEG)) {
                if (tp->phy_flags & TG3_PHYFLG_ANY_SERDES)
                        flowctrl = tg3_resolve_flowctrl_1000X(lcladv, rmtadv);
                else
@@ -1576,28 +1650,6 @@ static void tg3_phy_fini(struct tg3 *tp)
        }
 }
-static int tg3_phydsp_read(struct tg3 *tp, u32 reg, u32 *val)
-{
-        int err;
-        err = tg3_writephy(tp, MII_TG3_DSP_ADDRESS, reg);
-        if (!err)
-                err = tg3_readphy(tp, MII_TG3_DSP_RW_PORT, val);
-        return err;
-}
-static int tg3_phydsp_write(struct tg3 *tp, u32 reg, u32 val)
-{
-        int err;
-        err = tg3_writephy(tp, MII_TG3_DSP_ADDRESS, reg);
-        if (!err)
-                err = tg3_writephy(tp, MII_TG3_DSP_RW_PORT, val);
-        return err;
-}
 static void tg3_phy_fet_toggle_apd(struct tg3 *tp, bool enable)
 {
        u32 phytest;
@@ -1622,9 +1674,8 @@ static void tg3_phy_toggle_apd(struct tg3 *tp, bool enable)
 {
        u32 reg;
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS) ||
+        if (!tg3_flag(tp, 5705_PLUS) ||
-            ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+            (tg3_flag(tp, 5717_PLUS) &&
-              GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) &&
             (tp->phy_flags & TG3_PHYFLG_MII_SERDES)))
                return;
@@ -1658,7 +1709,7 @@ static void tg3_phy_toggle_automdix(struct tg3 *tp, int enable)
 {
        u32 phy;
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS) ||
+        if (!tg3_flag(tp, 5705_PLUS) ||
            (tp->phy_flags & TG3_PHYFLG_ANY_SERDES))
                return;
@@ -1680,31 +1731,33 @@ static void tg3_phy_toggle_automdix(struct tg3 *tp, int enable)
                        tg3_writephy(tp, MII_TG3_FET_TEST, ephy);
                }
        } else {
-                phy = MII_TG3_AUXCTL_MISC_RDSEL_MISC |
+                int ret;
-                      MII_TG3_AUXCTL_SHDWSEL_MISC;
-                if (!tg3_writephy(tp, MII_TG3_AUX_CTRL, phy) &&
+                ret = tg3_phy_auxctl_read(tp,
-                    !tg3_readphy(tp, MII_TG3_AUX_CTRL, &phy)) {
+                                          MII_TG3_AUXCTL_SHDWSEL_MISC, &phy);
+                if (!ret) {
                        if (enable)
                                phy |= MII_TG3_AUXCTL_MISC_FORCE_AMDIX;
                        else
                                phy &= ~MII_TG3_AUXCTL_MISC_FORCE_AMDIX;
-                        phy |= MII_TG3_AUXCTL_MISC_WREN;
+                        tg3_phy_auxctl_write(tp,
-                        tg3_writephy(tp, MII_TG3_AUX_CTRL, phy);
+                                             MII_TG3_AUXCTL_SHDWSEL_MISC, phy);
                }
        }
 }
 static void tg3_phy_set_wirespeed(struct tg3 *tp)
 {
+        int ret;
        u32 val;
        if (tp->phy_flags & TG3_PHYFLG_NO_ETH_WIRE_SPEED)
                return;
-        if (!tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x7007) &&
+        ret = tg3_phy_auxctl_read(tp, MII_TG3_AUXCTL_SHDWSEL_MISC, &val);
-            !tg3_readphy(tp, MII_TG3_AUX_CTRL, &val))
+        if (!ret)
-                tg3_writephy(tp, MII_TG3_AUX_CTRL,
+                tg3_phy_auxctl_write(tp, MII_TG3_AUXCTL_SHDWSEL_MISC,
-                             (val | (1 << 15) | (1 << 4)));
+                                     val | MII_TG3_AUXCTL_MISC_WIRESPD_EN);
 }
 static void tg3_phy_apply_otp(struct tg3 *tp)
@@ -1716,11 +1769,8 @@ static void tg3_phy_apply_otp(struct tg3 *tp)
        otp = tp->phy_otp;
-        /* Enable SM_DSP clock and tx 6dB coding. */
+        if (TG3_PHY_AUXCTL_SMDSP_ENABLE(tp))
-        phy = MII_TG3_AUXCTL_SHDWSEL_AUXCTL |
+                return;
-              MII_TG3_AUXCTL_ACTL_SMDSP_ENA |
-              MII_TG3_AUXCTL_ACTL_TX_6DB;
-        tg3_writephy(tp, MII_TG3_AUX_CTRL, phy);
        phy = ((otp & TG3_OTP_AGCTGT_MASK) >> TG3_OTP_AGCTGT_SHIFT);
        phy |= MII_TG3_DSP_TAP1_AGCTGT_DFLT;
@@ -1744,10 +1794,7 @@ static void tg3_phy_apply_otp(struct tg3 *tp)
              ((otp & TG3_OTP_RCOFF_MASK) >> TG3_OTP_RCOFF_SHIFT);
        tg3_phydsp_write(tp, MII_TG3_DSP_EXP97, phy);
-        /* Turn off SM_DSP clock. */
+        TG3_PHY_AUXCTL_SMDSP_DISABLE(tp);
-        phy = MII_TG3_AUXCTL_SHDWSEL_AUXCTL |
-              MII_TG3_AUXCTL_ACTL_TX_6DB;
-        tg3_writephy(tp, MII_TG3_AUX_CTRL, phy);
 }
 static void tg3_phy_eee_adjust(struct tg3 *tp, u32 current_link_up)
@@ -1776,29 +1823,9 @@ static void tg3_phy_eee_adjust(struct tg3 *tp, u32 current_link_up)
                tg3_phy_cl45_read(tp, MDIO_MMD_AN,
                                  TG3_CL45_D7_EEERES_STAT, &val);
-                switch (val) {
+                if (val == TG3_CL45_D7_EEERES_STAT_LP_1000T ||
-                case TG3_CL45_D7_EEERES_STAT_LP_1000T:
+                    val == TG3_CL45_D7_EEERES_STAT_LP_100TX)
-                        switch (GET_ASIC_REV(tp->pci_chip_rev_id)) {
-                        case ASIC_REV_5717:
-                        case ASIC_REV_5719:
-                        case ASIC_REV_57765:
-                                /* Enable SM_DSP clock and tx 6dB coding. */
-                                val = MII_TG3_AUXCTL_SHDWSEL_AUXCTL |
-                                      MII_TG3_AUXCTL_ACTL_SMDSP_ENA |
-                                      MII_TG3_AUXCTL_ACTL_TX_6DB;
-                                tg3_writephy(tp, MII_TG3_AUX_CTRL, val);
-                                tg3_phydsp_write(tp, MII_TG3_DSP_TAP26, 0x0000);
-                                /* Turn off SM_DSP clock. */
-                                val = MII_TG3_AUXCTL_SHDWSEL_AUXCTL |
-                                      MII_TG3_AUXCTL_ACTL_TX_6DB;
-                                tg3_writephy(tp, MII_TG3_AUX_CTRL, val);
-                        }
-                        /* Fallthrough */
-                case TG3_CL45_D7_EEERES_STAT_LP_100TX:
                        tp->setlpicnt = 2;
-                }
        }
        if (!tp->setlpicnt) {
@@ -1807,6 +1834,23 @@ static void tg3_phy_eee_adjust(struct tg3 *tp, u32 current_link_up)
        }
 }
+static void tg3_phy_eee_enable(struct tg3 *tp)
+{
+        u32 val;
+        if (tp->link_config.active_speed == SPEED_1000 &&
+            (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719 ||
+             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57765) &&
+            !TG3_PHY_AUXCTL_SMDSP_ENABLE(tp)) {
+                tg3_phydsp_write(tp, MII_TG3_DSP_TAP26, 0x0003);
+                TG3_PHY_AUXCTL_SMDSP_DISABLE(tp);
+        }
+        val = tr32(TG3_CPMU_EEE_MODE);
+        tw32(TG3_CPMU_EEE_MODE, val | TG3_CPMU_EEEMD_LPI_ENABLE);
+}
 static int tg3_wait_macro_done(struct tg3 *tp)
 {
        int limit = 100;
@@ -1945,8 +1989,9 @@ static int tg3_phy_reset_5703_4_5(struct tg3 *tp)
                             (MII_TG3_CTRL_AS_MASTER |
                              MII_TG3_CTRL_ENABLE_AS_MASTER));
-                /* Enable SM_DSP_CLOCK and 6dB.  */
+                err = TG3_PHY_AUXCTL_SMDSP_ENABLE(tp);
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0c00);
+                if (err)
+                        return err;
                /* Block the PHY control access.  */
                tg3_phydsp_write(tp, 0x8005, 0x0800);
@@ -1965,13 +2010,7 @@ static int tg3_phy_reset_5703_4_5(struct tg3 *tp)
        tg3_writephy(tp, MII_TG3_DSP_ADDRESS, 0x8200);
        tg3_writephy(tp, MII_TG3_DSP_CONTROL, 0x0000);
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5703 ||
+        TG3_PHY_AUXCTL_SMDSP_DISABLE(tp);
-            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704) {
-                /* Set Extended packet length bit for jumbo frames */
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x4400);
-        } else {
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0400);
-        }
        tg3_writephy(tp, MII_TG3_CTRL, phy9_orig);
@@ -2047,8 +2086,7 @@ static int tg3_phy_reset(struct tg3 *tp)
                }
        }
-        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+        if (tg3_flag(tp, 5717_PLUS) &&
-             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) &&
            (tp->phy_flags & TG3_PHYFLG_MII_SERDES))
                return 0;
@@ -2060,49 +2098,57 @@ static int tg3_phy_reset(struct tg3 *tp)
                tg3_phy_toggle_apd(tp, false);
 out:
-        if (tp->phy_flags & TG3_PHYFLG_ADC_BUG) {
+        if ((tp->phy_flags & TG3_PHYFLG_ADC_BUG) &&
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0c00);
+            !TG3_PHY_AUXCTL_SMDSP_ENABLE(tp)) {
                tg3_phydsp_write(tp, 0x201f, 0x2aaa);
                tg3_phydsp_write(tp, 0x000a, 0x0323);
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0400);
+                TG3_PHY_AUXCTL_SMDSP_DISABLE(tp);
        }
        if (tp->phy_flags & TG3_PHYFLG_5704_A0_BUG) {
                tg3_writephy(tp, MII_TG3_MISC_SHDW, 0x8d68);
                tg3_writephy(tp, MII_TG3_MISC_SHDW, 0x8d68);
        }
        if (tp->phy_flags & TG3_PHYFLG_BER_BUG) {
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0c00);
+                if (!TG3_PHY_AUXCTL_SMDSP_ENABLE(tp)) {
-                tg3_phydsp_write(tp, 0x000a, 0x310b);
+                        tg3_phydsp_write(tp, 0x000a, 0x310b);
-                tg3_phydsp_write(tp, 0x201f, 0x9506);
+                        tg3_phydsp_write(tp, 0x201f, 0x9506);
-                tg3_phydsp_write(tp, 0x401f, 0x14e2);
+                        tg3_phydsp_write(tp, 0x401f, 0x14e2);
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0400);
+                        TG3_PHY_AUXCTL_SMDSP_DISABLE(tp);
+                }
        } else if (tp->phy_flags & TG3_PHYFLG_JITTER_BUG) {
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0c00);
+                if (!TG3_PHY_AUXCTL_SMDSP_ENABLE(tp)) {
-                tg3_writephy(tp, MII_TG3_DSP_ADDRESS, 0x000a);
+                        tg3_writephy(tp, MII_TG3_DSP_ADDRESS, 0x000a);
-                if (tp->phy_flags & TG3_PHYFLG_ADJUST_TRIM) {
+                        if (tp->phy_flags & TG3_PHYFLG_ADJUST_TRIM) {
-                        tg3_writephy(tp, MII_TG3_DSP_RW_PORT, 0x110b);
+                                tg3_writephy(tp, MII_TG3_DSP_RW_PORT, 0x110b);
-                        tg3_writephy(tp, MII_TG3_TEST1,
+                                tg3_writephy(tp, MII_TG3_TEST1,
-                                     MII_TG3_TEST1_TRIM_EN | 0x4);
+                                             MII_TG3_TEST1_TRIM_EN | 0x4);
-                } else
+                        } else
-                        tg3_writephy(tp, MII_TG3_DSP_RW_PORT, 0x010b);
+                                tg3_writephy(tp, MII_TG3_DSP_RW_PORT, 0x010b);
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0400);
+                        TG3_PHY_AUXCTL_SMDSP_DISABLE(tp);
+                }
        }
        /* Set Extended packet length bit (bit 14) on all chips that */
        /* support jumbo frames */
        if ((tp->phy_id & TG3_PHY_ID_MASK) == TG3_PHY_ID_BCM5401) {
                /* Cannot do read-modify-write on 5401 */
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x4c20);
+                tg3_phy_auxctl_write(tp, MII_TG3_AUXCTL_SHDWSEL_AUXCTL, 0x4c20);
-        } else if (tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) {
+        } else if (tg3_flag(tp, JUMBO_CAPABLE)) {
                /* Set bit 14 with read-modify-write to preserve other bits */
-                if (!tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0007) &&
+                err = tg3_phy_auxctl_read(tp,
-                    !tg3_readphy(tp, MII_TG3_AUX_CTRL, &val))
+                                          MII_TG3_AUXCTL_SHDWSEL_AUXCTL, &val);
-                        tg3_writephy(tp, MII_TG3_AUX_CTRL, val | 0x4000);
+                if (!err)
+                        tg3_phy_auxctl_write(tp, MII_TG3_AUXCTL_SHDWSEL_AUXCTL,
+                                           val | MII_TG3_AUXCTL_ACTL_EXTPKTLEN);
        }
        /* Set phy register 0x10 bit 0 to high fifo elasticity to support
         * jumbo frames transmission.
         */
-        if (tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) {
+        if (tg3_flag(tp, JUMBO_CAPABLE)) {
                if (!tg3_readphy(tp, MII_TG3_EXT_CTRL, &val))
                        tg3_writephy(tp, MII_TG3_EXT_CTRL,
                                     val | MII_TG3_EXT_CTRL_FIFO_ELASTIC);
@@ -2123,14 +2169,15 @@ static void tg3_frob_aux_power(struct tg3 *tp)
        bool need_vaux = false;
        /* The GPIOs do something completely different on 57765. */
-        if ((tp->tg3_flags2 & TG3_FLG2_IS_NIC) == 0 ||
+        if (!tg3_flag(tp, IS_NIC) ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57765)
                return;
        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704 ||
             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5714 ||
-             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717) &&
+             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720) &&
            tp->pdev_peer != tp->pdev) {
                struct net_device *dev_peer;
@@ -2140,17 +2187,16 @@ static void tg3_frob_aux_power(struct tg3 *tp)
                if (dev_peer) {
                        struct tg3 *tp_peer = netdev_priv(dev_peer);
-                        if (tp_peer->tg3_flags & TG3_FLAG_INIT_COMPLETE)
+                        if (tg3_flag(tp_peer, INIT_COMPLETE))
                                return;
-                        if ((tp_peer->tg3_flags & TG3_FLAG_WOL_ENABLE) ||
+                        if (tg3_flag(tp_peer, WOL_ENABLE) ||
-                            (tp_peer->tg3_flags & TG3_FLAG_ENABLE_ASF))
+                            tg3_flag(tp_peer, ENABLE_ASF))
                                need_vaux = true;
                }
        }
-        if ((tp->tg3_flags & TG3_FLAG_WOL_ENABLE) ||
+        if (tg3_flag(tp, WOL_ENABLE) || tg3_flag(tp, ENABLE_ASF))
-            (tp->tg3_flags & TG3_FLAG_ENABLE_ASF))
                need_vaux = true;
        if (need_vaux) {
@@ -2304,11 +2350,10 @@ static void tg3_power_down_phy(struct tg3 *tp, bool do_low_power)
                tg3_writephy(tp, MII_TG3_EXT_CTRL,
                             MII_TG3_EXT_CTRL_FORCE_LED_OFF);
-                tg3_writephy(tp, MII_TG3_AUX_CTRL,
+                val = MII_TG3_AUXCTL_PCTL_100TX_LPWR |
-                             MII_TG3_AUXCTL_SHDWSEL_PWRCTL |
+                      MII_TG3_AUXCTL_PCTL_SPR_ISOLATE |
-                             MII_TG3_AUXCTL_PCTL_100TX_LPWR |
+                      MII_TG3_AUXCTL_PCTL_VREG_11V;
-                             MII_TG3_AUXCTL_PCTL_SPR_ISOLATE |
+                tg3_phy_auxctl_write(tp, MII_TG3_AUXCTL_SHDWSEL_PWRCTL, val);
-                             MII_TG3_AUXCTL_PCTL_VREG_11V);
        }
        /* The PHY should not be powered down on some chips because
@@ -2334,7 +2379,7 @@ static void tg3_power_down_phy(struct tg3 *tp, bool do_low_power)
 /* tp->lock is held. */
 static int tg3_nvram_lock(struct tg3 *tp)
 {
-        if (tp->tg3_flags & TG3_FLAG_NVRAM) {
+        if (tg3_flag(tp, NVRAM)) {
                int i;
                if (tp->nvram_lock_cnt == 0) {
@@ -2357,7 +2402,7 @@ static int tg3_nvram_lock(struct tg3 *tp)
 /* tp->lock is held. */
 static void tg3_nvram_unlock(struct tg3 *tp)
 {
-        if (tp->tg3_flags & TG3_FLAG_NVRAM) {
+        if (tg3_flag(tp, NVRAM)) {
                if (tp->nvram_lock_cnt > 0)
                        tp->nvram_lock_cnt--;
                if (tp->nvram_lock_cnt == 0)
@@ -2368,8 +2413,7 @@ static void tg3_nvram_unlock(struct tg3 *tp)
 /* tp->lock is held. */
 static void tg3_enable_nvram_access(struct tg3 *tp)
 {
-        if ((tp->tg3_flags2 & TG3_FLG2_5750_PLUS) &&
+        if (tg3_flag(tp, 5750_PLUS) && !tg3_flag(tp, PROTECTED_NVRAM)) {
-            !(tp->tg3_flags3 & TG3_FLG3_PROTECTED_NVRAM)) {
                u32 nvaccess = tr32(NVRAM_ACCESS);
                tw32(NVRAM_ACCESS, nvaccess | ACCESS_ENABLE);
@@ -2379,8 +2423,7 @@ static void tg3_enable_nvram_access(struct tg3 *tp)
 /* tp->lock is held. */
 static void tg3_disable_nvram_access(struct tg3 *tp)
 {
-        if ((tp->tg3_flags2 & TG3_FLG2_5750_PLUS) &&
+        if (tg3_flag(tp, 5750_PLUS) && !tg3_flag(tp, PROTECTED_NVRAM)) {
-            !(tp->tg3_flags3 & TG3_FLG3_PROTECTED_NVRAM)) {
                u32 nvaccess = tr32(NVRAM_ACCESS);
                tw32(NVRAM_ACCESS, nvaccess & ~ACCESS_ENABLE);
@@ -2450,10 +2493,10 @@ static int tg3_nvram_exec_cmd(struct tg3 *tp, u32 nvram_cmd)
 static u32 tg3_nvram_phys_addr(struct tg3 *tp, u32 addr)
 {
-        if ((tp->tg3_flags & TG3_FLAG_NVRAM) &&
+        if (tg3_flag(tp, NVRAM) &&
-            (tp->tg3_flags & TG3_FLAG_NVRAM_BUFFERED) &&
+            tg3_flag(tp, NVRAM_BUFFERED) &&
-            (tp->tg3_flags2 & TG3_FLG2_FLASH) &&
+            tg3_flag(tp, FLASH) &&
-           !(tp->tg3_flags3 & TG3_FLG3_NO_NVRAM_ADDR_TRANS) &&
+            !tg3_flag(tp, NO_NVRAM_ADDR_TRANS) &&
            (tp->nvram_jedecnum == JEDEC_ATMEL))
                addr = ((addr / tp->nvram_pagesize) <<
@@ -2465,10 +2508,10 @@ static u32 tg3_nvram_phys_addr(struct tg3 *tp, u32 addr)
 static u32 tg3_nvram_logical_addr(struct tg3 *tp, u32 addr)
 {
-        if ((tp->tg3_flags & TG3_FLAG_NVRAM) &&
+        if (tg3_flag(tp, NVRAM) &&
-            (tp->tg3_flags & TG3_FLAG_NVRAM_BUFFERED) &&
+            tg3_flag(tp, NVRAM_BUFFERED) &&
-            (tp->tg3_flags2 & TG3_FLG2_FLASH) &&
+            tg3_flag(tp, FLASH) &&
-           !(tp->tg3_flags3 & TG3_FLG3_NO_NVRAM_ADDR_TRANS) &&
+            !tg3_flag(tp, NO_NVRAM_ADDR_TRANS) &&
            (tp->nvram_jedecnum == JEDEC_ATMEL))
                addr = ((addr >> ATMEL_AT45DB0X1B_PAGE_POS) *
@@ -2488,7 +2531,7 @@ static int tg3_nvram_read(struct tg3 *tp, u32 offset, u32 *val)
 {
        int ret;
-        if (!(tp->tg3_flags & TG3_FLAG_NVRAM))
+        if (!tg3_flag(tp, NVRAM))
                return tg3_nvram_read_using_eeprom(tp, offset, val);
        offset = tg3_nvram_phys_addr(tp, offset);
@@ -2580,7 +2623,7 @@ static int tg3_power_up(struct tg3 *tp)
        pci_set_power_state(tp->pdev, PCI_D0);
        /* Switch out of Vaux if it is a NIC */
-        if (tp->tg3_flags2 & TG3_FLG2_IS_NIC)
+        if (tg3_flag(tp, IS_NIC))
                tw32_wait_f(GRC_LOCAL_CTRL, tp->grc_local_ctrl, 100);
        return 0;
@@ -2594,7 +2637,7 @@ static int tg3_power_down_prepare(struct tg3 *tp)
        tg3_enable_register_access(tp);
        /* Restore the CLKREQ setting. */
-        if (tp->tg3_flags3 & TG3_FLG3_CLKREQ_BUG) {
+        if (tg3_flag(tp, CLKREQ_BUG)) {
                u16 lnkctl;
                pci_read_config_word(tp->pdev,
@@ -2611,9 +2654,9 @@ static int tg3_power_down_prepare(struct tg3 *tp)
             misc_host_ctrl | MISC_HOST_CTRL_MASK_PCI_INT);
        device_should_wake = device_may_wakeup(&tp->pdev->dev) &&
-                             (tp->tg3_flags & TG3_FLAG_WOL_ENABLE);
+                             tg3_flag(tp, WOL_ENABLE);
-        if (tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB) {
+        if (tg3_flag(tp, USE_PHYLIB)) {
                do_low_power = false;
                if ((tp->phy_flags & TG3_PHYFLG_IS_CONNECTED) &&
                    !(tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER)) {
@@ -2634,9 +2677,8 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                                      ADVERTISED_Autoneg |
                                      ADVERTISED_10baseT_Half;
-                        if ((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) ||
+                        if (tg3_flag(tp, ENABLE_ASF) || device_should_wake) {
-                            device_should_wake) {
+                                if (tg3_flag(tp, WOL_SPEED_100MB))
-                                if (tp->tg3_flags & TG3_FLAG_WOL_SPEED_100MB)
                                        advertising |=
                                                ADVERTISED_100baseT_Half |
                                                ADVERTISED_100baseT_Full |
@@ -2681,7 +2723,7 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                val = tr32(GRC_VCPU_EXT_CTRL);
                tw32(GRC_VCPU_EXT_CTRL, val | GRC_VCPU_EXT_CTRL_DISABLE_WOL);
-        } else if (!(tp->tg3_flags & TG3_FLAG_ENABLE_ASF)) {
+        } else if (!tg3_flag(tp, ENABLE_ASF)) {
                int i;
                u32 val;
@@ -2692,7 +2734,7 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                        msleep(1);
                }
        }
-        if (tp->tg3_flags & TG3_FLAG_WOL_CAP)
+        if (tg3_flag(tp, WOL_CAP))
                tg3_write_mem(tp, NIC_SRAM_WOL_MBOX, WOL_SIGNATURE |
                                                     WOL_DRV_STATE_SHUTDOWN |
                                                     WOL_DRV_WOL |
@@ -2702,8 +2744,13 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                u32 mac_mode;
                if (!(tp->phy_flags & TG3_PHYFLG_PHY_SERDES)) {
-                        if (do_low_power) {
+                        if (do_low_power &&
-                                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x5a);
+                            !(tp->phy_flags & TG3_PHYFLG_IS_FET)) {
+                                tg3_phy_auxctl_write(tp,
+                                               MII_TG3_AUXCTL_SHDWSEL_PWRCTL,
+                                               MII_TG3_AUXCTL_PCTL_WOL_EN |
+                                               MII_TG3_AUXCTL_PCTL_100TX_LPWR |
+                                               MII_TG3_AUXCTL_PCTL_CL_AB_TXDAC);
                                udelay(40);
                        }
@@ -2715,8 +2762,7 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                        mac_mode |= tp->mac_mode & MAC_MODE_LINK_POLARITY;
                        if (GET_ASIC_REV(tp->pci_chip_rev_id) ==
                            ASIC_REV_5700) {
-                                u32 speed = (tp->tg3_flags &
+                                u32 speed = tg3_flag(tp, WOL_SPEED_100MB) ?
-                                             TG3_FLAG_WOL_SPEED_100MB) ?
                                             SPEED_100 : SPEED_10;
                                if (tg3_5700_link_polarity(tp, speed))
                                        mac_mode |= MAC_MODE_LINK_POLARITY;
@@ -2727,17 +2773,15 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                        mac_mode = MAC_MODE_PORT_MODE_TBI;
                }
-                if (!(tp->tg3_flags2 & TG3_FLG2_5750_PLUS))
+                if (!tg3_flag(tp, 5750_PLUS))
                        tw32(MAC_LED_CTRL, tp->led_ctrl);
                mac_mode |= MAC_MODE_MAGIC_PKT_ENABLE;
-                if (((tp->tg3_flags2 & TG3_FLG2_5705_PLUS) &&
+                if ((tg3_flag(tp, 5705_PLUS) && !tg3_flag(tp, 5780_CLASS)) &&
-                    !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) &&
+                    (tg3_flag(tp, ENABLE_ASF) || tg3_flag(tp, ENABLE_APE)))
-                    ((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) ||
-                     (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)))
                        mac_mode |= MAC_MODE_KEEP_FRAME_IN_WOL;
-                if (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)
+                if (tg3_flag(tp, ENABLE_APE))
                        mac_mode |= MAC_MODE_APE_TX_EN |
                                    MAC_MODE_APE_RX_EN |
                                    MAC_MODE_TDE_ENABLE;
@@ -2749,7 +2793,7 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                udelay(10);
        }
-        if (!(tp->tg3_flags & TG3_FLAG_WOL_SPEED_100MB) &&
+        if (!tg3_flag(tp, WOL_SPEED_100MB) &&
            (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700 ||
             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5701)) {
                u32 base_val;
@@ -2760,12 +2804,11 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                tw32_wait_f(TG3PCI_CLOCK_CTRL, base_val | CLOCK_CTRL_ALTCLK |
                            CLOCK_CTRL_PWRDOWN_PLL133, 40);
-        } else if ((tp->tg3_flags2 & TG3_FLG2_5780_CLASS) ||
+        } else if (tg3_flag(tp, 5780_CLASS) ||
-                   (tp->tg3_flags & TG3_FLAG_CPMU_PRESENT) ||
+                   tg3_flag(tp, CPMU_PRESENT) ||
-                   (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906)) {
+                   GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906) {
                /* do nothing */
-        } else if (!((tp->tg3_flags2 & TG3_FLG2_5750_PLUS) &&
+        } else if (!(tg3_flag(tp, 5750_PLUS) && tg3_flag(tp, ENABLE_ASF))) {
-                     (tp->tg3_flags & TG3_FLAG_ENABLE_ASF))) {
                u32 newbits1, newbits2;
                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700 ||
@@ -2774,7 +2817,7 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                                    CLOCK_CTRL_TXCLK_DISABLE |
                                    CLOCK_CTRL_ALTCLK);
                        newbits2 = newbits1 | CLOCK_CTRL_44MHZ_CORE;
-                } else if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS) {
+                } else if (tg3_flag(tp, 5705_PLUS)) {
                        newbits1 = CLOCK_CTRL_625_CORE;
                        newbits2 = newbits1 | CLOCK_CTRL_ALTCLK;
                } else {
@@ -2788,7 +2831,7 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                tw32_wait_f(TG3PCI_CLOCK_CTRL, tp->pci_clock_ctrl | newbits2,
                            40);
-                if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) {
+                if (!tg3_flag(tp, 5705_PLUS)) {
                        u32 newbits3;
                        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700 ||
@@ -2805,8 +2848,7 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                }
        }
-        if (!(device_should_wake) &&
+        if (!(device_should_wake) && !tg3_flag(tp, ENABLE_ASF))
-            !(tp->tg3_flags & TG3_FLAG_ENABLE_ASF))
                tg3_power_down_phy(tp, do_low_power);
        tg3_frob_aux_power(tp);
@@ -2818,7 +2860,7 @@ static int tg3_power_down_prepare(struct tg3 *tp)
                val &= ~((1 << 16) | (1 << 4) | (1 << 2) | (1 << 1) | 1);
                tw32(0x7d00, val);
-                if (!(tp->tg3_flags & TG3_FLAG_ENABLE_ASF)) {
+                if (!tg3_flag(tp, ENABLE_ASF)) {
                        int err;
                        err = tg3_nvram_lock(tp);
@@ -2837,7 +2879,7 @@ static void tg3_power_down(struct tg3 *tp)
 {
        tg3_power_down_prepare(tp);
-        pci_wake_from_d3(tp->pdev, tp->tg3_flags & TG3_FLAG_WOL_ENABLE);
+        pci_wake_from_d3(tp->pdev, tg3_flag(tp, WOL_ENABLE));
        pci_set_power_state(tp->pdev, PCI_D3hot);
 }
@@ -2888,106 +2930,54 @@ static void tg3_aux_stat_to_speed_duplex(struct tg3 *tp, u32 val, u16 *speed, u8
        }
 }
-static void tg3_phy_copper_begin(struct tg3 *tp)
+static int tg3_phy_autoneg_cfg(struct tg3 *tp, u32 advertise, u32 flowctrl)
 {
-        u32 new_adv;
+        int err = 0;
-        int i;
+        u32 val, new_adv;
-        if (tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER) {
+        new_adv = ADVERTISE_CSMA;
-                /* Entering low power mode.  Disable gigabit and
+        if (advertise & ADVERTISED_10baseT_Half)
-                 * 100baseT advertisements.
+                new_adv |= ADVERTISE_10HALF;
-                 */
+        if (advertise & ADVERTISED_10baseT_Full)
-                tg3_writephy(tp, MII_TG3_CTRL, 0);
+                new_adv |= ADVERTISE_10FULL;
+        if (advertise & ADVERTISED_100baseT_Half)
+                new_adv |= ADVERTISE_100HALF;
+        if (advertise & ADVERTISED_100baseT_Full)
+                new_adv |= ADVERTISE_100FULL;
-                new_adv = (ADVERTISE_10HALF | ADVERTISE_10FULL |
+        new_adv |= tg3_advert_flowctrl_1000T(flowctrl);
-                           ADVERTISE_CSMA | ADVERTISE_PAUSE_CAP);
-                if (tp->tg3_flags & TG3_FLAG_WOL_SPEED_100MB)
-                        new_adv |= (ADVERTISE_100HALF | ADVERTISE_100FULL);
-                tg3_writephy(tp, MII_ADVERTISE, new_adv);
+        err = tg3_writephy(tp, MII_ADVERTISE, new_adv);
-        } else if (tp->link_config.speed == SPEED_INVALID) {
+        if (err)
-                if (tp->phy_flags & TG3_PHYFLG_10_100_ONLY)
+                goto done;
-                        tp->link_config.advertising &=
-                                ~(ADVERTISED_1000baseT_Half |
-                                  ADVERTISED_1000baseT_Full);
-                new_adv = ADVERTISE_CSMA;
+        if (tp->phy_flags & TG3_PHYFLG_10_100_ONLY)
-                if (tp->link_config.advertising & ADVERTISED_10baseT_Half)
+                goto done;
-                        new_adv |= ADVERTISE_10HALF;
-                if (tp->link_config.advertising & ADVERTISED_10baseT_Full)
-                        new_adv |= ADVERTISE_10FULL;
-                if (tp->link_config.advertising & ADVERTISED_100baseT_Half)
-                        new_adv |= ADVERTISE_100HALF;
-                if (tp->link_config.advertising & ADVERTISED_100baseT_Full)
-                        new_adv |= ADVERTISE_100FULL;
-                new_adv |= tg3_advert_flowctrl_1000T(tp->link_config.flowctrl);
-                tg3_writephy(tp, MII_ADVERTISE, new_adv);
-                if (tp->link_config.advertising &
-                    (ADVERTISED_1000baseT_Half | ADVERTISED_1000baseT_Full)) {
-                        new_adv = 0;
-                        if (tp->link_config.advertising & ADVERTISED_1000baseT_Half)
-                                new_adv |= MII_TG3_CTRL_ADV_1000_HALF;
-                        if (tp->link_config.advertising & ADVERTISED_1000baseT_Full)
-                                new_adv |= MII_TG3_CTRL_ADV_1000_FULL;
-                        if (!(tp->phy_flags & TG3_PHYFLG_10_100_ONLY) &&
-                            (tp->pci_chip_rev_id == CHIPREV_ID_5701_A0 ||
-                             tp->pci_chip_rev_id == CHIPREV_ID_5701_B0))
-                                new_adv |= (MII_TG3_CTRL_AS_MASTER |
-                                            MII_TG3_CTRL_ENABLE_AS_MASTER);
-                        tg3_writephy(tp, MII_TG3_CTRL, new_adv);
-                } else {
-                        tg3_writephy(tp, MII_TG3_CTRL, 0);
-                }
-        } else {
-                new_adv = tg3_advert_flowctrl_1000T(tp->link_config.flowctrl);
-                new_adv |= ADVERTISE_CSMA;
-                /* Asking for a specific link mode. */
+        new_adv = 0;
-                if (tp->link_config.speed == SPEED_1000) {
+        if (advertise & ADVERTISED_1000baseT_Half)
-                        tg3_writephy(tp, MII_ADVERTISE, new_adv);
+                new_adv |= MII_TG3_CTRL_ADV_1000_HALF;
+        if (advertise & ADVERTISED_1000baseT_Full)
+                new_adv |= MII_TG3_CTRL_ADV_1000_FULL;
-                        if (tp->link_config.duplex == DUPLEX_FULL)
+        if (tp->pci_chip_rev_id == CHIPREV_ID_5701_A0 ||
-                                new_adv = MII_TG3_CTRL_ADV_1000_FULL;
+            tp->pci_chip_rev_id == CHIPREV_ID_5701_B0)
-                        else
+                new_adv |= (MII_TG3_CTRL_AS_MASTER |
-                                new_adv = MII_TG3_CTRL_ADV_1000_HALF;
+                            MII_TG3_CTRL_ENABLE_AS_MASTER);
-                        if (tp->pci_chip_rev_id == CHIPREV_ID_5701_A0 ||
-                            tp->pci_chip_rev_id == CHIPREV_ID_5701_B0)
-                                new_adv |= (MII_TG3_CTRL_AS_MASTER |
-                                            MII_TG3_CTRL_ENABLE_AS_MASTER);
-                } else {
-                        if (tp->link_config.speed == SPEED_100) {
-                                if (tp->link_config.duplex == DUPLEX_FULL)
-                                        new_adv |= ADVERTISE_100FULL;
-                                else
-                                        new_adv |= ADVERTISE_100HALF;
-                        } else {
-                                if (tp->link_config.duplex == DUPLEX_FULL)
-                                        new_adv |= ADVERTISE_10FULL;
-                                else
-                                        new_adv |= ADVERTISE_10HALF;
-                        }
-                        tg3_writephy(tp, MII_ADVERTISE, new_adv);
-                        new_adv = 0;
-                }
-                tg3_writephy(tp, MII_TG3_CTRL, new_adv);
+        err = tg3_writephy(tp, MII_TG3_CTRL, new_adv);
-        }
+        if (err)
+                goto done;
-        if (tp->phy_flags & TG3_PHYFLG_EEE_CAP) {
+        if (!(tp->phy_flags & TG3_PHYFLG_EEE_CAP))
-                u32 val;
+                goto done;
-                tw32(TG3_CPMU_EEE_MODE,
+        tw32(TG3_CPMU_EEE_MODE,
-                     tr32(TG3_CPMU_EEE_MODE) & ~TG3_CPMU_EEEMD_LPI_ENABLE);
+             tr32(TG3_CPMU_EEE_MODE) & ~TG3_CPMU_EEEMD_LPI_ENABLE);
-                /* Enable SM_DSP clock and tx 6dB coding. */
+        err = TG3_PHY_AUXCTL_SMDSP_ENABLE(tp);
-                val = MII_TG3_AUXCTL_SHDWSEL_AUXCTL |
+        if (!err) {
-                      MII_TG3_AUXCTL_ACTL_SMDSP_ENA |
+                u32 err2;
-                      MII_TG3_AUXCTL_ACTL_TX_6DB;
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, val);
                switch (GET_ASIC_REV(tp->pci_chip_rev_id)) {
                case ASIC_REV_5717:
@@ -3004,22 +2994,66 @@ static void tg3_phy_copper_begin(struct tg3 *tp)
                }
                val = 0;
-                if (tp->link_config.autoneg == AUTONEG_ENABLE) {
+                /* Advertise 100-BaseTX EEE ability */
-                        /* Advertise 100-BaseTX EEE ability */
+                if (advertise & ADVERTISED_100baseT_Full)
-                        if (tp->link_config.advertising &
+                        val |= MDIO_AN_EEE_ADV_100TX;
-                            ADVERTISED_100baseT_Full)
+                /* Advertise 1000-BaseT EEE ability */
-                                val |= MDIO_AN_EEE_ADV_100TX;
+                if (advertise & ADVERTISED_1000baseT_Full)
-                        /* Advertise 1000-BaseT EEE ability */
+                        val |= MDIO_AN_EEE_ADV_1000T;
-                        if (tp->link_config.advertising &
+                err = tg3_phy_cl45_write(tp, MDIO_MMD_AN, MDIO_AN_EEE_ADV, val);
-                            ADVERTISED_1000baseT_Full)
-                                val |= MDIO_AN_EEE_ADV_1000T;
+                err2 = TG3_PHY_AUXCTL_SMDSP_DISABLE(tp);
+                if (!err)
+                        err = err2;
+        }
+done:
+        return err;
+}
+static void tg3_phy_copper_begin(struct tg3 *tp)
+{
+        u32 new_adv;
+        int i;
+        if (tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER) {
+                new_adv = ADVERTISED_10baseT_Half |
+                          ADVERTISED_10baseT_Full;
+                if (tg3_flag(tp, WOL_SPEED_100MB))
+                        new_adv |= ADVERTISED_100baseT_Half |
+                                   ADVERTISED_100baseT_Full;
+                tg3_phy_autoneg_cfg(tp, new_adv,
+                                    FLOW_CTRL_TX | FLOW_CTRL_RX);
+        } else if (tp->link_config.speed == SPEED_INVALID) {
+                if (tp->phy_flags & TG3_PHYFLG_10_100_ONLY)
+                        tp->link_config.advertising &=
+                                ~(ADVERTISED_1000baseT_Half |
+                                  ADVERTISED_1000baseT_Full);
+                tg3_phy_autoneg_cfg(tp, tp->link_config.advertising,
+                                    tp->link_config.flowctrl);
+        } else {
+                /* Asking for a specific link mode. */
+                if (tp->link_config.speed == SPEED_1000) {
+                        if (tp->link_config.duplex == DUPLEX_FULL)
+                                new_adv = ADVERTISED_1000baseT_Full;
+                        else
+                                new_adv = ADVERTISED_1000baseT_Half;
+                } else if (tp->link_config.speed == SPEED_100) {
+                        if (tp->link_config.duplex == DUPLEX_FULL)
+                                new_adv = ADVERTISED_100baseT_Full;
+                        else
+                                new_adv = ADVERTISED_100baseT_Half;
+                } else {
+                        if (tp->link_config.duplex == DUPLEX_FULL)
+                                new_adv = ADVERTISED_10baseT_Full;
+                        else
+                                new_adv = ADVERTISED_10baseT_Half;
                }
-                tg3_phy_cl45_write(tp, MDIO_MMD_AN, MDIO_AN_EEE_ADV, val);
-                /* Turn off SM_DSP clock. */
+                tg3_phy_autoneg_cfg(tp, new_adv,
-                val = MII_TG3_AUXCTL_SHDWSEL_AUXCTL |
+                                    tp->link_config.flowctrl);
-                      MII_TG3_AUXCTL_ACTL_TX_6DB;
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, val);
        }
        if (tp->link_config.autoneg == AUTONEG_DISABLE &&
@@ -3077,7 +3111,7 @@ static int tg3_init_5401phy_dsp(struct tg3 *tp)
        /* Turn off tap power management. */
        /* Set Extended packet length bit */
-        err  = tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x4c20);
+        err = tg3_phy_auxctl_write(tp, MII_TG3_AUXCTL_SHDWSEL_AUXCTL, 0x4c20);
        err |= tg3_phydsp_write(tp, 0x0012, 0x1804);
        err |= tg3_phydsp_write(tp, 0x0013, 0x1204);
@@ -3140,7 +3174,7 @@ static int tg3_adv_1000T_flowctrl_ok(struct tg3 *tp, u32 *lcladv, u32 *rmtadv)
                if (curadv != reqadv)
                        return 0;
-                if (tp->tg3_flags & TG3_FLAG_PAUSE_AUTONEG)
+                if (tg3_flag(tp, PAUSE_AUTONEG))
                        tg3_readphy(tp, MII_LPA, rmtadv);
        } else {
                /* Reprogram the advertisement register, even if it
@@ -3183,7 +3217,7 @@ static int tg3_setup_copper_phy(struct tg3 *tp, int force_reset)
                udelay(80);
        }
-        tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x02);
+        tg3_phy_auxctl_write(tp, MII_TG3_AUXCTL_SHDWSEL_PWRCTL, 0);
        /* Some third-party PHYs need to be reset on link going
         * down.
@@ -3203,7 +3237,7 @@ static int tg3_setup_copper_phy(struct tg3 *tp, int force_reset)
        if ((tp->phy_id & TG3_PHY_ID_MASK) == TG3_PHY_ID_BCM5401) {
                tg3_readphy(tp, MII_BMSR, &bmsr);
                if (tg3_readphy(tp, MII_BMSR, &bmsr) ||
-                    !(tp->tg3_flags & TG3_FLAG_INIT_COMPLETE))
+                    !tg3_flag(tp, INIT_COMPLETE))
                        bmsr = 0;
                if (!(bmsr & BMSR_LSTATUS)) {
@@ -3264,11 +3298,13 @@ static int tg3_setup_copper_phy(struct tg3 *tp, int force_reset)
        current_duplex = DUPLEX_INVALID;
        if (tp->phy_flags & TG3_PHYFLG_CAPACITIVE_COUPLING) {
-                tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x4007);
+                err = tg3_phy_auxctl_read(tp,
-                tg3_readphy(tp, MII_TG3_AUX_CTRL, &val);
+                                          MII_TG3_AUXCTL_SHDWSEL_MISCTEST,
-                if (!(val & (1 << 10))) {
+                                          &val);
-                        val |= (1 << 10);
+                if (!err && !(val & (1 << 10))) {
-                        tg3_writephy(tp, MII_TG3_AUX_CTRL, val);
+                        tg3_phy_auxctl_write(tp,
+                                             MII_TG3_AUXCTL_SHDWSEL_MISCTEST,
+                                             val | (1 << 10));
                        goto relink;
                }
        }
@@ -3341,8 +3377,8 @@ relink:
                tg3_phy_copper_begin(tp);
                tg3_readphy(tp, MII_BMSR, &bmsr);
-                if (!tg3_readphy(tp, MII_BMSR, &bmsr) &&
+                if ((!tg3_readphy(tp, MII_BMSR, &bmsr) && (bmsr & BMSR_LSTATUS)) ||
-                    (bmsr & BMSR_LSTATUS))
+                    (tp->mac_mode & MAC_MODE_PORT_INT_LPBACK))
                        current_link_up = 1;
        }
@@ -3385,7 +3421,7 @@ relink:
        tg3_phy_eee_adjust(tp, current_link_up);
-        if (tp->tg3_flags & TG3_FLAG_USE_LINKCHG_REG) {
+        if (tg3_flag(tp, USE_LINKCHG_REG)) {
                /* Polled via timer. */
                tw32_f(MAC_EVENT, 0);
        } else {
@@ -3396,8 +3432,7 @@ relink:
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700 &&
            current_link_up == 1 &&
            tp->link_config.active_speed == SPEED_1000 &&
-            ((tp->tg3_flags & TG3_FLAG_PCIX_MODE) ||
+            (tg3_flag(tp, PCIX_MODE) || tg3_flag(tp, PCI_HIGH_SPEED))) {
-             (tp->tg3_flags & TG3_FLAG_PCI_HIGH_SPEED))) {
                udelay(120);
                tw32_f(MAC_STATUS,
                     (MAC_STATUS_SYNC_CHANGED |
@@ -3409,7 +3444,7 @@ relink:
        }
        /* Prevent send BD corruption. */
-        if (tp->tg3_flags3 & TG3_FLG3_CLKREQ_BUG) {
+        if (tg3_flag(tp, CLKREQ_BUG)) {
                u16 oldlnkctl, newlnkctl;
                pci_read_config_word(tp->pdev,
@@ -3804,7 +3839,7 @@ static void tg3_init_bcm8002(struct tg3 *tp)
        int i;
        /* Reset when initting first time or we have a link. */
-        if ((tp->tg3_flags & TG3_FLAG_INIT_COMPLETE) &&
+        if (tg3_flag(tp, INIT_COMPLETE) &&
            !(mac_status & MAC_STATUS_PCS_SYNCED))
                return;
@@ -4065,9 +4100,9 @@ static int tg3_setup_fiber_phy(struct tg3 *tp, int force_reset)
        orig_active_speed = tp->link_config.active_speed;
        orig_active_duplex = tp->link_config.active_duplex;
-        if (!(tp->tg3_flags2 & TG3_FLG2_HW_AUTONEG) &&
+        if (!tg3_flag(tp, HW_AUTONEG) &&
            netif_carrier_ok(tp->dev) &&
-            (tp->tg3_flags & TG3_FLAG_INIT_COMPLETE)) {
+            tg3_flag(tp, INIT_COMPLETE)) {
                mac_status = tr32(MAC_STATUS);
                mac_status &= (MAC_STATUS_PCS_SYNCED |
                               MAC_STATUS_SIGNAL_DET |
@@ -4098,7 +4133,7 @@ static int tg3_setup_fiber_phy(struct tg3 *tp, int force_reset)
        current_link_up = 0;
        mac_status = tr32(MAC_STATUS);
-        if (tp->tg3_flags2 & TG3_FLG2_HW_AUTONEG)
+        if (tg3_flag(tp, HW_AUTONEG))
                current_link_up = tg3_setup_fiber_hw_autoneg(tp, mac_status);
        else
                current_link_up = tg3_setup_fiber_by_hand(tp, mac_status);
@@ -4297,7 +4332,7 @@ static int tg3_setup_fiber_mii_phy(struct tg3 *tp, int force_reset)
                                        current_duplex = DUPLEX_FULL;
                                else
                                        current_duplex = DUPLEX_HALF;
-                        } else if (!(tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) {
+                        } else if (!tg3_flag(tp, 5780_CLASS)) {
                                /* Link is up via parallel detect */
                        } else {
                                current_link_up = 0;
@@ -4394,6 +4429,7 @@ static void tg3_serdes_parallel_detect(struct tg3 *tp)
 static int tg3_setup_phy(struct tg3 *tp, int force_reset)
 {
+        u32 val;
        int err;
        if (tp->phy_flags & TG3_PHYFLG_PHY_SERDES)
@@ -4404,7 +4440,7 @@ static int tg3_setup_phy(struct tg3 *tp, int force_reset)
                err = tg3_setup_copper_phy(tp, force_reset);
        if (GET_CHIP_REV(tp->pci_chip_rev_id) == CHIPREV_5784_AX) {
-                u32 val, scale;
+                u32 scale;
                val = tr32(TG3_CPMU_CLCK_STAT) & CPMU_CLCK_STAT_MAC_CLCK_MASK;
                if (val == CPMU_CLCK_STAT_MAC_CLCK_62_5)
@@ -4419,19 +4455,22 @@ static int tg3_setup_phy(struct tg3 *tp, int force_reset)
                tw32(GRC_MISC_CFG, val);
        }
+        val = (2 << TX_LENGTHS_IPG_CRS_SHIFT) |
+              (6 << TX_LENGTHS_IPG_SHIFT);
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720)
+                val |= tr32(MAC_TX_LENGTHS) &
+                       (TX_LENGTHS_JMB_FRM_LEN_MSK |
+                        TX_LENGTHS_CNT_DWN_VAL_MSK);
        if (tp->link_config.active_speed == SPEED_1000 &&
            tp->link_config.active_duplex == DUPLEX_HALF)
-                tw32(MAC_TX_LENGTHS,
+                tw32(MAC_TX_LENGTHS, val |
-                     ((2 << TX_LENGTHS_IPG_CRS_SHIFT) |
+                     (0xff << TX_LENGTHS_SLOT_TIME_SHIFT));
-                      (6 << TX_LENGTHS_IPG_SHIFT) |
-                      (0xff << TX_LENGTHS_SLOT_TIME_SHIFT)));
        else
-                tw32(MAC_TX_LENGTHS,
+                tw32(MAC_TX_LENGTHS, val |
-                     ((2 << TX_LENGTHS_IPG_CRS_SHIFT) |
+                     (32 << TX_LENGTHS_SLOT_TIME_SHIFT));
-                      (6 << TX_LENGTHS_IPG_SHIFT) |
-                      (32 << TX_LENGTHS_SLOT_TIME_SHIFT)));
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) {
+        if (!tg3_flag(tp, 5705_PLUS)) {
                if (netif_carrier_ok(tp->dev)) {
                        tw32(HOSTCC_STAT_COAL_TICKS,
                             tp->coal.stats_block_coalesce_usecs);
@@ -4440,8 +4479,8 @@ static int tg3_setup_phy(struct tg3 *tp, int force_reset)
                }
        }
-        if (tp->tg3_flags & TG3_FLAG_ASPM_WORKAROUND) {
+        if (tg3_flag(tp, ASPM_WORKAROUND)) {
-                u32 val = tr32(PCIE_PWR_MGMT_THRESH);
+                val = tr32(PCIE_PWR_MGMT_THRESH);
                if (!netif_carrier_ok(tp->dev))
                        val = (val & ~PCIE_PWR_MGMT_L1_THRESH_MSK) |
                              tp->pwrmgmt_thresh;
@@ -4458,6 +4497,123 @@ static inline int tg3_irq_sync(struct tg3 *tp)
        return tp->irq_sync;
 }
+static inline void tg3_rd32_loop(struct tg3 *tp, u32 *dst, u32 off, u32 len)
+{
+        int i;
+        dst = (u32 *)((u8 *)dst + off);
+        for (i = 0; i < len; i += sizeof(u32))
+                *dst++ = tr32(off + i);
+}
+static void tg3_dump_legacy_regs(struct tg3 *tp, u32 *regs)
+{
+        tg3_rd32_loop(tp, regs, TG3PCI_VENDOR, 0xb0);
+        tg3_rd32_loop(tp, regs, MAILBOX_INTERRUPT_0, 0x200);
+        tg3_rd32_loop(tp, regs, MAC_MODE, 0x4f0);
+        tg3_rd32_loop(tp, regs, SNDDATAI_MODE, 0xe0);
+        tg3_rd32_loop(tp, regs, SNDDATAC_MODE, 0x04);
+        tg3_rd32_loop(tp, regs, SNDBDS_MODE, 0x80);
+        tg3_rd32_loop(tp, regs, SNDBDI_MODE, 0x48);
+        tg3_rd32_loop(tp, regs, SNDBDC_MODE, 0x04);
+        tg3_rd32_loop(tp, regs, RCVLPC_MODE, 0x20);
+        tg3_rd32_loop(tp, regs, RCVLPC_SELLST_BASE, 0x15c);
+        tg3_rd32_loop(tp, regs, RCVDBDI_MODE, 0x0c);
+        tg3_rd32_loop(tp, regs, RCVDBDI_JUMBO_BD, 0x3c);
+        tg3_rd32_loop(tp, regs, RCVDBDI_BD_PROD_IDX_0, 0x44);
+        tg3_rd32_loop(tp, regs, RCVDCC_MODE, 0x04);
+        tg3_rd32_loop(tp, regs, RCVBDI_MODE, 0x20);
+        tg3_rd32_loop(tp, regs, RCVCC_MODE, 0x14);
+        tg3_rd32_loop(tp, regs, RCVLSC_MODE, 0x08);
+        tg3_rd32_loop(tp, regs, MBFREE_MODE, 0x08);
+        tg3_rd32_loop(tp, regs, HOSTCC_MODE, 0x100);
+        if (tg3_flag(tp, SUPPORT_MSIX))
+                tg3_rd32_loop(tp, regs, HOSTCC_RXCOL_TICKS_VEC1, 0x180);
+        tg3_rd32_loop(tp, regs, MEMARB_MODE, 0x10);
+        tg3_rd32_loop(tp, regs, BUFMGR_MODE, 0x58);
+        tg3_rd32_loop(tp, regs, RDMAC_MODE, 0x08);
+        tg3_rd32_loop(tp, regs, WDMAC_MODE, 0x08);
+        tg3_rd32_loop(tp, regs, RX_CPU_MODE, 0x04);
+        tg3_rd32_loop(tp, regs, RX_CPU_STATE, 0x04);
+        tg3_rd32_loop(tp, regs, RX_CPU_PGMCTR, 0x04);
+        tg3_rd32_loop(tp, regs, RX_CPU_HWBKPT, 0x04);
+        if (!tg3_flag(tp, 5705_PLUS)) {
+                tg3_rd32_loop(tp, regs, TX_CPU_MODE, 0x04);
+                tg3_rd32_loop(tp, regs, TX_CPU_STATE, 0x04);
+                tg3_rd32_loop(tp, regs, TX_CPU_PGMCTR, 0x04);
+        }
+        tg3_rd32_loop(tp, regs, GRCMBOX_INTERRUPT_0, 0x110);
+        tg3_rd32_loop(tp, regs, FTQ_RESET, 0x120);
+        tg3_rd32_loop(tp, regs, MSGINT_MODE, 0x0c);
+        tg3_rd32_loop(tp, regs, DMAC_MODE, 0x04);
+        tg3_rd32_loop(tp, regs, GRC_MODE, 0x4c);
+        if (tg3_flag(tp, NVRAM))
+                tg3_rd32_loop(tp, regs, NVRAM_CMD, 0x24);
+}
+static void tg3_dump_state(struct tg3 *tp)
+{
+        int i;
+        u32 *regs;
+        regs = kzalloc(TG3_REG_BLK_SIZE, GFP_ATOMIC);
+        if (!regs) {
+                netdev_err(tp->dev, "Failed allocating register dump buffer\n");
+                return;
+        }
+        if (tg3_flag(tp, PCI_EXPRESS)) {
+                /* Read up to but not including private PCI registers */
+                for (i = 0; i < TG3_PCIE_TLDLPL_PORT; i += sizeof(u32))
+                        regs[i / sizeof(u32)] = tr32(i);
+        } else
+                tg3_dump_legacy_regs(tp, regs);
+        for (i = 0; i < TG3_REG_BLK_SIZE / sizeof(u32); i += 4) {
+                if (!regs[i + 0] && !regs[i + 1] &&
+                    !regs[i + 2] && !regs[i + 3])
+                        continue;
+                netdev_err(tp->dev, "0x%08x: 0x%08x, 0x%08x, 0x%08x, 0x%08x\n",
+                           i * 4,
+                           regs[i + 0], regs[i + 1], regs[i + 2], regs[i + 3]);
+        }
+        kfree(regs);
+        for (i = 0; i < tp->irq_cnt; i++) {
+                struct tg3_napi *tnapi = &tp->napi[i];
+                /* SW status block */
+                netdev_err(tp->dev,
+                         "%d: Host status block [%08x:%08x:(%04x:%04x:%04x):(%04x:%04x)]\n",
+                           i,
+                           tnapi->hw_status->status,
+                           tnapi->hw_status->status_tag,
+                           tnapi->hw_status->rx_jumbo_consumer,
+                           tnapi->hw_status->rx_consumer,
+                           tnapi->hw_status->rx_mini_consumer,
+                           tnapi->hw_status->idx[0].rx_producer,
+                           tnapi->hw_status->idx[0].tx_consumer);
+                netdev_err(tp->dev,
+                "%d: NAPI info [%08x:%08x:(%04x:%04x:%04x):%04x:(%04x:%04x:%04x:%04x)]\n",
+                           i,
+                           tnapi->last_tag, tnapi->last_irq_tag,
+                           tnapi->tx_prod, tnapi->tx_cons, tnapi->tx_pending,
+                           tnapi->rx_rcb_ptr,
+                           tnapi->prodring.rx_std_prod_idx,
+                           tnapi->prodring.rx_std_cons_idx,
+                           tnapi->prodring.rx_jmb_prod_idx,
+                           tnapi->prodring.rx_jmb_cons_idx);
+        }
+}
 /* This is called whenever we suspect that the system chipset is re-
 * ordering the sequence of MMIO to the tx send mailbox. The symptom
 * is bogus tx completions. We try to recover by setting the
@@ -4466,7 +4622,7 @@ static inline int tg3_irq_sync(struct tg3 *tp)
 */
 static void tg3_tx_recover(struct tg3 *tp)
 {
-        BUG_ON((tp->tg3_flags & TG3_FLAG_MBOX_WRITE_REORDER) ||
+        BUG_ON(tg3_flag(tp, MBOX_WRITE_REORDER) ||
               tp->write32_tx_mbox == tg3_write_indirect_mbox);
        netdev_warn(tp->dev,
@@ -4476,7 +4632,7 @@ static void tg3_tx_recover(struct tg3 *tp)
                    "and include system chipset information.\n");
        spin_lock(&tp->lock);
-        tp->tg3_flags |= TG3_FLAG_TX_RECOVERY_PENDING;
+        tg3_flag_set(tp, TX_RECOVERY_PENDING);
        spin_unlock(&tp->lock);
 }
@@ -4500,7 +4656,7 @@ static void tg3_tx(struct tg3_napi *tnapi)
        struct netdev_queue *txq;
        int index = tnapi - tp->napi;
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS)
+        if (tg3_flag(tp, ENABLE_TSS))
                index--;
        txq = netdev_get_tx_queue(tp->dev, index);
@@ -4815,7 +4971,7 @@ static int tg3_rx(struct tg3_napi *tnapi, int budget)
                        skb = copy_skb;
                }
-                if ((tp->tg3_flags & TG3_FLAG_RX_CHECKSUMS) &&
+                if ((tp->dev->features & NETIF_F_RXCSUM) &&
                    (desc->type_flags & RXD_FLAG_TCPUDP_CSUM) &&
                    (((desc->ip_tcp_csum & RXD_TCPCSUM_MASK)
                      >> RXD_TCPCSUM_SHIFT) == 0xffff))
@@ -4868,7 +5024,7 @@ next_pkt_nopost:
        tw32_rx_mbox(tnapi->consmbox, sw_idx);
        /* Refill RX ring(s). */
-        if (!(tp->tg3_flags3 & TG3_FLG3_ENABLE_RSS)) {
+        if (!tg3_flag(tp, ENABLE_RSS)) {
                if (work_mask & RXD_OPAQUE_RING_STD) {
                        tpr->rx_std_prod_idx = std_prod_idx &
                                               tp->rx_std_ring_mask;
@@ -4901,16 +5057,14 @@ next_pkt_nopost:
 static void tg3_poll_link(struct tg3 *tp)
 {
        /* handle link change and other phy events */
-        if (!(tp->tg3_flags &
+        if (!(tg3_flag(tp, USE_LINKCHG_REG) || tg3_flag(tp, POLL_SERDES))) {
-              (TG3_FLAG_USE_LINKCHG_REG |
-               TG3_FLAG_POLL_SERDES))) {
                struct tg3_hw_status *sblk = tp->napi[0].hw_status;
                if (sblk->status & SD_STATUS_LINK_CHG) {
                        sblk->status = SD_STATUS_UPDATED |
                                       (sblk->status & ~SD_STATUS_LINK_CHG);
                        spin_lock(&tp->lock);
-                        if (tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB) {
+                        if (tg3_flag(tp, USE_PHYLIB)) {
                                tw32_f(MAC_STATUS,
                                     (MAC_STATUS_SYNC_CHANGED |
                                      MAC_STATUS_CFG_CHANGED |
@@ -5057,7 +5211,7 @@ static int tg3_poll_work(struct tg3_napi *tnapi, int work_done, int budget)
        /* run TX completion thread */
        if (tnapi->hw_status->idx[0].tx_consumer != tnapi->tx_cons) {
                tg3_tx(tnapi);
-                if (unlikely(tp->tg3_flags & TG3_FLAG_TX_RECOVERY_PENDING))
+                if (unlikely(tg3_flag(tp, TX_RECOVERY_PENDING)))
                        return work_done;
        }
@@ -5068,7 +5222,7 @@ static int tg3_poll_work(struct tg3_napi *tnapi, int work_done, int budget)
        if (*(tnapi->rx_rcb_prod_idx) != tnapi->rx_rcb_ptr)
                work_done += tg3_rx(tnapi, budget - work_done);
-        if ((tp->tg3_flags3 & TG3_FLG3_ENABLE_RSS) && tnapi == &tp->napi[1]) {
+        if (tg3_flag(tp, ENABLE_RSS) && tnapi == &tp->napi[1]) {
                struct tg3_rx_prodring_set *dpr = &tp->napi[0].prodring;
                int i, err = 0;
                u32 std_prod_idx = dpr->rx_std_prod_idx;
@@ -5107,7 +5261,7 @@ static int tg3_poll_msix(struct napi_struct *napi, int budget)
        while (1) {
                work_done = tg3_poll_work(tnapi, work_done, budget);
-                if (unlikely(tp->tg3_flags & TG3_FLAG_TX_RECOVERY_PENDING))
+                if (unlikely(tg3_flag(tp, TX_RECOVERY_PENDING)))
                        goto tx_recovery;
                if (unlikely(work_done >= budget))
@@ -5141,6 +5295,40 @@ tx_recovery:
        return work_done;
 }
+static void tg3_process_error(struct tg3 *tp)
+{
+        u32 val;
+        bool real_error = false;
+        if (tg3_flag(tp, ERROR_PROCESSED))
+                return;
+        /* Check Flow Attention register */
+        val = tr32(HOSTCC_FLOW_ATTN);
+        if (val & ~HOSTCC_FLOW_ATTN_MBUF_LWM) {
+                netdev_err(tp->dev, "FLOW Attention error.  Resetting chip.\n");
+                real_error = true;
+        }
+        if (tr32(MSGINT_STATUS) & ~MSGINT_STATUS_MSI_REQ) {
+                netdev_err(tp->dev, "MSI Status error.  Resetting chip.\n");
+                real_error = true;
+        }
+        if (tr32(RDMAC_STATUS) || tr32(WDMAC_STATUS)) {
+                netdev_err(tp->dev, "DMA Status error.  Resetting chip.\n");
+                real_error = true;
+        }
+        if (!real_error)
+                return;
+        tg3_dump_state(tp);
+        tg3_flag_set(tp, ERROR_PROCESSED);
+        schedule_work(&tp->reset_task);
+}
 static int tg3_poll(struct napi_struct *napi, int budget)
 {
        struct tg3_napi *tnapi = container_of(napi, struct tg3_napi, napi);
@@ -5149,17 +5337,20 @@ static int tg3_poll(struct napi_struct *napi, int budget)
        struct tg3_hw_status *sblk = tnapi->hw_status;
        while (1) {
+                if (sblk->status & SD_STATUS_ERROR)
+                        tg3_process_error(tp);
                tg3_poll_link(tp);
                work_done = tg3_poll_work(tnapi, work_done, budget);
-                if (unlikely(tp->tg3_flags & TG3_FLAG_TX_RECOVERY_PENDING))
+                if (unlikely(tg3_flag(tp, TX_RECOVERY_PENDING)))
                        goto tx_recovery;
                if (unlikely(work_done >= budget))
                        break;
-                if (tp->tg3_flags & TG3_FLAG_TAGGED_STATUS) {
+                if (tg3_flag(tp, TAGGED_STATUS)) {
                        /* tp->last_tag is used in tg3_int_reenable() below
                         * to tell the hw how much work has been processed,
                         * so we must read it before checking for more work.
@@ -5326,7 +5517,7 @@ static irqreturn_t tg3_interrupt(int irq, void *dev_id)
         * interrupt is ours and will flush the status block.
         */
        if (unlikely(!(sblk->status & SD_STATUS_UPDATED))) {
-                if ((tp->tg3_flags & TG3_FLAG_CHIP_RESETTING) ||
+                if (tg3_flag(tp, CHIP_RESETTING) ||
                    (tr32(TG3PCI_PCISTATE) & PCISTATE_INT_NOT_ACTIVE)) {
                        handled = 0;
                        goto out;
@@ -5375,7 +5566,7 @@ static irqreturn_t tg3_interrupt_tagged(int irq, void *dev_id)
         * interrupt is ours and will flush the status block.
         */
        if (unlikely(sblk->status_tag == tnapi->last_irq_tag)) {
-                if ((tp->tg3_flags & TG3_FLAG_CHIP_RESETTING) ||
+                if (tg3_flag(tp, CHIP_RESETTING) ||
                    (tr32(TG3PCI_PCISTATE) & PCISTATE_INT_NOT_ACTIVE)) {
                        handled = 0;
                        goto out;
@@ -5488,14 +5679,14 @@ static void tg3_reset_task(struct work_struct *work)
        tg3_full_lock(tp, 1);
-        restart_timer = tp->tg3_flags2 & TG3_FLG2_RESTART_TIMER;
+        restart_timer = tg3_flag(tp, RESTART_TIMER);
-        tp->tg3_flags2 &= ~TG3_FLG2_RESTART_TIMER;
+        tg3_flag_clear(tp, RESTART_TIMER);
-        if (tp->tg3_flags & TG3_FLAG_TX_RECOVERY_PENDING) {
+        if (tg3_flag(tp, TX_RECOVERY_PENDING)) {
                tp->write32_tx_mbox = tg3_write32_tx_mbox;
                tp->write32_rx_mbox = tg3_write_flush_reg32;
-                tp->tg3_flags |= TG3_FLAG_MBOX_WRITE_REORDER;
+                tg3_flag_set(tp, MBOX_WRITE_REORDER);
-                tp->tg3_flags &= ~TG3_FLAG_TX_RECOVERY_PENDING;
+                tg3_flag_clear(tp, TX_RECOVERY_PENDING);
        }
        tg3_halt(tp, RESET_KIND_SHUTDOWN, 0);
@@ -5515,21 +5706,13 @@ out:
                tg3_phy_start(tp);
 }
-static void tg3_dump_short_state(struct tg3 *tp)
-{
-        netdev_err(tp->dev, "DEBUG: MAC_TX_STATUS[%08x] MAC_RX_STATUS[%08x]\n",
-                   tr32(MAC_TX_STATUS), tr32(MAC_RX_STATUS));
-        netdev_err(tp->dev, "DEBUG: RDMAC_STATUS[%08x] WDMAC_STATUS[%08x]\n",
-                   tr32(RDMAC_STATUS), tr32(WDMAC_STATUS));
-}
 static void tg3_tx_timeout(struct net_device *dev)
 {
        struct tg3 *tp = netdev_priv(dev);
        if (netif_msg_tx_err(tp)) {
                netdev_err(dev, "transmit timed out, resetting\n");
-                tg3_dump_short_state(tp);
+                tg3_dump_state(tp);
        }
        schedule_work(&tp->reset_task);
@@ -5548,7 +5731,7 @@ static inline int tg3_40bit_overflow_test(struct tg3 *tp, dma_addr_t mapping,
                                          int len)
 {
 #if defined(CONFIG_HIGHMEM) && (BITS_PER_LONG == 64)
-        if (tp->tg3_flags & TG3_FLAG_40BIT_DMA_BUG)
+        if (tg3_flag(tp, 40BIT_DMA_BUG))
                return ((u64) mapping + len) > DMA_BIT_MASK(40);
        return 0;
 #else
@@ -5556,18 +5739,62 @@ static inline int tg3_40bit_overflow_test(struct tg3 *tp, dma_addr_t mapping,
 #endif
 }
-static void tg3_set_txd(struct tg3_napi *, int, dma_addr_t, int, u32, u32);
+static void tg3_set_txd(struct tg3_napi *tnapi, int entry,
+                        dma_addr_t mapping, int len, u32 flags,
+                        u32 mss_and_is_end)
+{
+        struct tg3_tx_buffer_desc *txd = &tnapi->tx_ring[entry];
+        int is_end = (mss_and_is_end & 0x1);
+        u32 mss = (mss_and_is_end >> 1);
+        u32 vlan_tag = 0;
+        if (is_end)
+                flags |= TXD_FLAG_END;
+        if (flags & TXD_FLAG_VLAN) {
+                vlan_tag = flags >> 16;
+                flags &= 0xffff;
+        }
+        vlan_tag |= (mss << TXD_MSS_SHIFT);
+        txd->addr_hi = ((u64) mapping >> 32);
+        txd->addr_lo = ((u64) mapping & 0xffffffff);
+        txd->len_flags = (len << TXD_LEN_SHIFT) | flags;
+        txd->vlan_tag = vlan_tag << TXD_VLAN_TAG_SHIFT;
+}
+static void tg3_skb_error_unmap(struct tg3_napi *tnapi,
+                                struct sk_buff *skb, int last)
+{
+        int i;
+        u32 entry = tnapi->tx_prod;
+        struct ring_info *txb = &tnapi->tx_buffers[entry];
+        pci_unmap_single(tnapi->tp->pdev,
+                         dma_unmap_addr(txb, mapping),
+                         skb_headlen(skb),
+                         PCI_DMA_TODEVICE);
+        for (i = 0; i <= last; i++) {
+                skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
+                entry = NEXT_TX(entry);
+                txb = &tnapi->tx_buffers[entry];
+                pci_unmap_page(tnapi->tp->pdev,
+                               dma_unmap_addr(txb, mapping),
+                               frag->size, PCI_DMA_TODEVICE);
+        }
+}
 /* Workaround 4GB and 40-bit hardware DMA bugs. */
 static int tigon3_dma_hwbug_workaround(struct tg3_napi *tnapi,
-                                       struct sk_buff *skb, u32 last_plus_one,
+                                       struct sk_buff *skb,
-                                       u32 *start, u32 base_flags, u32 mss)
+                                       u32 base_flags, u32 mss)
 {
        struct tg3 *tp = tnapi->tp;
        struct sk_buff *new_skb;
        dma_addr_t new_addr = 0;
-        u32 entry = *start;
+        u32 entry = tnapi->tx_prod;
-        int i, ret = 0;
+        int ret = 0;
        if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701)
                new_skb = skb_copy(skb, GFP_ATOMIC);
@@ -5583,55 +5810,30 @@ static int tigon3_dma_hwbug_workaround(struct tg3_napi *tnapi,
                ret = -1;
        } else {
                /* New SKB is guaranteed to be linear. */
-                entry = *start;
                new_addr = pci_map_single(tp->pdev, new_skb->data, new_skb->len,
                                          PCI_DMA_TODEVICE);
                /* Make sure the mapping succeeded */
                if (pci_dma_mapping_error(tp->pdev, new_addr)) {
                        ret = -1;
                        dev_kfree_skb(new_skb);
-                        new_skb = NULL;
                /* Make sure new skb does not cross any 4G boundaries.
                 * Drop the packet if it does.
                 */
-                } else if ((tp->tg3_flags3 & TG3_FLG3_4G_DMA_BNDRY_BUG) &&
+                } else if (tg3_flag(tp, 4G_DMA_BNDRY_BUG) &&
-                            tg3_4g_overflow_test(new_addr, new_skb->len)) {
+                           tg3_4g_overflow_test(new_addr, new_skb->len)) {
                        pci_unmap_single(tp->pdev, new_addr, new_skb->len,
                                         PCI_DMA_TODEVICE);
                        ret = -1;
                        dev_kfree_skb(new_skb);
-                        new_skb = NULL;
                } else {
+                        tnapi->tx_buffers[entry].skb = new_skb;
+                        dma_unmap_addr_set(&tnapi->tx_buffers[entry],
+                                           mapping, new_addr);
                        tg3_set_txd(tnapi, entry, new_addr, new_skb->len,
                                    base_flags, 1 | (mss << 1));
-                        *start = NEXT_TX(entry);
-                }
-        }
-        /* Now clean up the sw ring entries. */
-        i = 0;
-        while (entry != last_plus_one) {
-                int len;
-                if (i == 0)
-                        len = skb_headlen(skb);
-                else
-                        len = skb_shinfo(skb)->frags[i-1].size;
-                pci_unmap_single(tp->pdev,
-                                 dma_unmap_addr(&tnapi->tx_buffers[entry],
-                                                mapping),
-                                 len, PCI_DMA_TODEVICE);
-                if (i == 0) {
-                        tnapi->tx_buffers[entry].skb = new_skb;
-                        dma_unmap_addr_set(&tnapi->tx_buffers[entry], mapping,
-                                           new_addr);
-                } else {
-                        tnapi->tx_buffers[entry].skb = NULL;
                }
-                entry = NEXT_TX(entry);
-                i++;
        }
        dev_kfree_skb(skb);
@@ -5639,202 +5841,7 @@ static int tigon3_dma_hwbug_workaround(struct tg3_napi *tnapi,
        return ret;
 }
-static void tg3_set_txd(struct tg3_napi *tnapi, int entry,
+static netdev_tx_t tg3_start_xmit(struct sk_buff *, struct net_device *);
-                        dma_addr_t mapping, int len, u32 flags,
-                        u32 mss_and_is_end)
-{
-        struct tg3_tx_buffer_desc *txd = &tnapi->tx_ring[entry];
-        int is_end = (mss_and_is_end & 0x1);
-        u32 mss = (mss_and_is_end >> 1);
-        u32 vlan_tag = 0;
-        if (is_end)
-                flags |= TXD_FLAG_END;
-        if (flags & TXD_FLAG_VLAN) {
-                vlan_tag = flags >> 16;
-                flags &= 0xffff;
-        }
-        vlan_tag |= (mss << TXD_MSS_SHIFT);
-        txd->addr_hi = ((u64) mapping >> 32);
-        txd->addr_lo = ((u64) mapping & 0xffffffff);
-        txd->len_flags = (len << TXD_LEN_SHIFT) | flags;
-        txd->vlan_tag = vlan_tag << TXD_VLAN_TAG_SHIFT;
-}
-/* hard_start_xmit for devices that don't have any bugs and
- * support TG3_FLG2_HW_TSO_2 and TG3_FLG2_HW_TSO_3 only.
- */
-static netdev_tx_t tg3_start_xmit(struct sk_buff *skb,
-                                  struct net_device *dev)
-{
-        struct tg3 *tp = netdev_priv(dev);
-        u32 len, entry, base_flags, mss;
-        dma_addr_t mapping;
-        struct tg3_napi *tnapi;
-        struct netdev_queue *txq;
-        unsigned int i, last;
-        txq = netdev_get_tx_queue(dev, skb_get_queue_mapping(skb));
-        tnapi = &tp->napi[skb_get_queue_mapping(skb)];
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS)
-                tnapi++;
-        /* We are running in BH disabled context with netif_tx_lock
-         * and TX reclaim runs via tp->napi.poll inside of a software
-         * interrupt.  Furthermore, IRQ processing runs lockless so we have
-         * no IRQ context deadlocks to worry about either.  Rejoice!
-         */
-        if (unlikely(tg3_tx_avail(tnapi) <= (skb_shinfo(skb)->nr_frags + 1))) {
-                if (!netif_tx_queue_stopped(txq)) {
-                        netif_tx_stop_queue(txq);
-                        /* This is a hard error, log it. */
-                        netdev_err(dev,
-                                   "BUG! Tx Ring full when queue awake!\n");
-                }
-                return NETDEV_TX_BUSY;
-        }
-        entry = tnapi->tx_prod;
-        base_flags = 0;
-        mss = skb_shinfo(skb)->gso_size;
-        if (mss) {
-                int tcp_opt_len, ip_tcp_len;
-                u32 hdrlen;
-                if (skb_header_cloned(skb) &&
-                    pskb_expand_head(skb, 0, 0, GFP_ATOMIC)) {
-                        dev_kfree_skb(skb);
-                        goto out_unlock;
-                }
-                if (skb_is_gso_v6(skb)) {
-                        hdrlen = skb_headlen(skb) - ETH_HLEN;
-                } else {
-                        struct iphdr *iph = ip_hdr(skb);
-                        tcp_opt_len = tcp_optlen(skb);
-                        ip_tcp_len = ip_hdrlen(skb) + sizeof(struct tcphdr);
-                        iph->check = 0;
-                        iph->tot_len = htons(mss + ip_tcp_len + tcp_opt_len);
-                        hdrlen = ip_tcp_len + tcp_opt_len;
-                }
-                if (tp->tg3_flags2 & TG3_FLG2_HW_TSO_3) {
-                        mss |= (hdrlen & 0xc) << 12;
-                        if (hdrlen & 0x10)
-                                base_flags |= 0x00000010;
-                        base_flags |= (hdrlen & 0x3e0) << 5;
-                } else
-                        mss |= hdrlen << 9;
-                base_flags |= (TXD_FLAG_CPU_PRE_DMA |
-                               TXD_FLAG_CPU_POST_DMA);
-                tcp_hdr(skb)->check = 0;
-        } else if (skb->ip_summed == CHECKSUM_PARTIAL) {
-                base_flags |= TXD_FLAG_TCPUDP_CSUM;
-        }
-        if (vlan_tx_tag_present(skb))
-                base_flags |= (TXD_FLAG_VLAN |
-                               (vlan_tx_tag_get(skb) << 16));
-        len = skb_headlen(skb);
-        /* Queue skb data, a.k.a. the main skb fragment. */
-        mapping = pci_map_single(tp->pdev, skb->data, len, PCI_DMA_TODEVICE);
-        if (pci_dma_mapping_error(tp->pdev, mapping)) {
-                dev_kfree_skb(skb);
-                goto out_unlock;
-        }
-        tnapi->tx_buffers[entry].skb = skb;
-        dma_unmap_addr_set(&tnapi->tx_buffers[entry], mapping, mapping);
-        if ((tp->tg3_flags3 & TG3_FLG3_USE_JUMBO_BDFLAG) &&
-            !mss && skb->len > VLAN_ETH_FRAME_LEN)
-                base_flags |= TXD_FLAG_JMB_PKT;
-        tg3_set_txd(tnapi, entry, mapping, len, base_flags,
-                    (skb_shinfo(skb)->nr_frags == 0) | (mss << 1));
-        entry = NEXT_TX(entry);
-        /* Now loop through additional data fragments, and queue them. */
-        if (skb_shinfo(skb)->nr_frags > 0) {
-                last = skb_shinfo(skb)->nr_frags - 1;
-                for (i = 0; i <= last; i++) {
-                        skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
-                        len = frag->size;
-                        mapping = pci_map_page(tp->pdev,
-                                               frag->page,
-                                               frag->page_offset,
-                                               len, PCI_DMA_TODEVICE);
-                        if (pci_dma_mapping_error(tp->pdev, mapping))
-                                goto dma_error;
-                        tnapi->tx_buffers[entry].skb = NULL;
-                        dma_unmap_addr_set(&tnapi->tx_buffers[entry], mapping,
-                                           mapping);
-                        tg3_set_txd(tnapi, entry, mapping, len,
-                                    base_flags, (i == last) | (mss << 1));
-                        entry = NEXT_TX(entry);
-                }
-        }
-        /* Packets are ready, update Tx producer idx local and on card. */
-        tw32_tx_mbox(tnapi->prodmbox, entry);
-        tnapi->tx_prod = entry;
-        if (unlikely(tg3_tx_avail(tnapi) <= (MAX_SKB_FRAGS + 1))) {
-                netif_tx_stop_queue(txq);
-                /* netif_tx_stop_queue() must be done before checking
-                 * checking tx index in tg3_tx_avail() below, because in
-                 * tg3_tx(), we update tx index before checking for
-                 * netif_tx_queue_stopped().
-                 */
-                smp_mb();
-                if (tg3_tx_avail(tnapi) > TG3_TX_WAKEUP_THRESH(tnapi))
-                        netif_tx_wake_queue(txq);
-        }
-out_unlock:
-        mmiowb();
-        return NETDEV_TX_OK;
-dma_error:
-        last = i;
-        entry = tnapi->tx_prod;
-        tnapi->tx_buffers[entry].skb = NULL;
-        pci_unmap_single(tp->pdev,
-                         dma_unmap_addr(&tnapi->tx_buffers[entry], mapping),
-                         skb_headlen(skb),
-                         PCI_DMA_TODEVICE);
-        for (i = 0; i <= last; i++) {
-                skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
-                entry = NEXT_TX(entry);
-                pci_unmap_page(tp->pdev,
-                               dma_unmap_addr(&tnapi->tx_buffers[entry],
-                                              mapping),
-                               frag->size, PCI_DMA_TODEVICE);
-        }
-        dev_kfree_skb(skb);
-        return NETDEV_TX_OK;
-}
-static netdev_tx_t tg3_start_xmit_dma_bug(struct sk_buff *,
-                                          struct net_device *);
 /* Use GSO to workaround a rare TSO bug that may be triggered when the
 * TSO header is greater than 80 bytes.
@@ -5868,7 +5875,7 @@ static int tg3_tso_bug(struct tg3 *tp, struct sk_buff *skb)
                nskb = segs;
                segs = segs->next;
                nskb->next = NULL;
-                tg3_start_xmit_dma_bug(nskb, tp->dev);
+                tg3_start_xmit(nskb, tp->dev);
        } while (segs);
 tg3_tso_bug_end:
@@ -5878,22 +5885,21 @@ tg3_tso_bug_end:
 }
 /* hard_start_xmit for devices that have the 4G bug and/or 40-bit bug and
- * support TG3_FLG2_HW_TSO_1 or firmware TSO only.
+ * support TG3_FLAG_HW_TSO_1 or firmware TSO only.
 */
-static netdev_tx_t tg3_start_xmit_dma_bug(struct sk_buff *skb,
+static netdev_tx_t tg3_start_xmit(struct sk_buff *skb, struct net_device *dev)
-                                          struct net_device *dev)
 {
        struct tg3 *tp = netdev_priv(dev);
        u32 len, entry, base_flags, mss;
-        int would_hit_hwbug;
+        int i = -1, would_hit_hwbug;
        dma_addr_t mapping;
        struct tg3_napi *tnapi;
        struct netdev_queue *txq;
-        unsigned int i, last;
+        unsigned int last;
        txq = netdev_get_tx_queue(dev, skb_get_queue_mapping(skb));
        tnapi = &tp->napi[skb_get_queue_mapping(skb)];
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS)
+        if (tg3_flag(tp, ENABLE_TSS))
                tnapi++;
        /* We are running in BH disabled context with netif_tx_lock
@@ -5944,13 +5950,15 @@ static netdev_tx_t tg3_start_xmit_dma_bug(struct sk_buff *skb,
                }
                if (unlikely((ETH_HLEN + hdr_len) > 80) &&
-                             (tp->tg3_flags2 & TG3_FLG2_TSO_BUG))
+                    tg3_flag(tp, TSO_BUG))
                        return tg3_tso_bug(tp, skb);
                base_flags |= (TXD_FLAG_CPU_PRE_DMA |
                               TXD_FLAG_CPU_POST_DMA);
-                if (tp->tg3_flags2 & TG3_FLG2_HW_TSO) {
+                if (tg3_flag(tp, HW_TSO_1) ||
+                    tg3_flag(tp, HW_TSO_2) ||
+                    tg3_flag(tp, HW_TSO_3)) {
                        tcp_hdr(skb)->check = 0;
                        base_flags &= ~TXD_FLAG_TCPUDP_CSUM;
                } else
@@ -5959,14 +5967,14 @@ static netdev_tx_t tg3_start_xmit_dma_bug(struct sk_buff *skb,
                                                                 IPPROTO_TCP,
                                                                 0);
-                if (tp->tg3_flags2 & TG3_FLG2_HW_TSO_3) {
+                if (tg3_flag(tp, HW_TSO_3)) {
                        mss |= (hdr_len & 0xc) << 12;
                        if (hdr_len & 0x10)
                                base_flags |= 0x00000010;
                        base_flags |= (hdr_len & 0x3e0) << 5;
-                } else if (tp->tg3_flags2 & TG3_FLG2_HW_TSO_2)
+                } else if (tg3_flag(tp, HW_TSO_2))
                        mss |= hdr_len << 9;
-                else if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO_1) ||
+                else if (tg3_flag(tp, HW_TSO_1) ||
                         GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705) {
                        if (tcp_opt_len || iph->ihl > 5) {
                                int tsflags;
@@ -5988,7 +5996,7 @@ static netdev_tx_t tg3_start_xmit_dma_bug(struct sk_buff *skb,
                base_flags |= (TXD_FLAG_VLAN |
                               (vlan_tx_tag_get(skb) << 16));
-        if ((tp->tg3_flags3 & TG3_FLG3_USE_JUMBO_BDFLAG) &&
+        if (tg3_flag(tp, USE_JUMBO_BDFLAG) &&
            !mss && skb->len > VLAN_ETH_FRAME_LEN)
                base_flags |= TXD_FLAG_JMB_PKT;
@@ -6005,18 +6013,18 @@ static netdev_tx_t tg3_start_xmit_dma_bug(struct sk_buff *skb,
        would_hit_hwbug = 0;
-        if ((tp->tg3_flags3 & TG3_FLG3_SHORT_DMA_BUG) && len <= 8)
+        if (tg3_flag(tp, SHORT_DMA_BUG) && len <= 8)
                would_hit_hwbug = 1;
-        if ((tp->tg3_flags3 & TG3_FLG3_4G_DMA_BNDRY_BUG) &&
+        if (tg3_flag(tp, 4G_DMA_BNDRY_BUG) &&
            tg3_4g_overflow_test(mapping, len))
                would_hit_hwbug = 1;
-        if ((tp->tg3_flags3 & TG3_FLG3_40BIT_DMA_LIMIT_BUG) &&
+        if (tg3_flag(tp, 40BIT_DMA_LIMIT_BUG) &&
            tg3_40bit_overflow_test(tp, mapping, len))
                would_hit_hwbug = 1;
-        if (tp->tg3_flags3 & TG3_FLG3_5701_DMA_BUG)
+        if (tg3_flag(tp, 5701_DMA_BUG))
                would_hit_hwbug = 1;
        tg3_set_txd(tnapi, entry, mapping, len, base_flags,
@@ -6042,19 +6050,21 @@ static netdev_tx_t tg3_start_xmit_dma_bug(struct sk_buff *skb,
                        if (pci_dma_mapping_error(tp->pdev, mapping))
                                goto dma_error;
-                        if ((tp->tg3_flags3 & TG3_FLG3_SHORT_DMA_BUG) &&
+                        if (tg3_flag(tp, SHORT_DMA_BUG) &&
                            len <= 8)
                                would_hit_hwbug = 1;
-                        if ((tp->tg3_flags3 & TG3_FLG3_4G_DMA_BNDRY_BUG) &&
+                        if (tg3_flag(tp, 4G_DMA_BNDRY_BUG) &&
                            tg3_4g_overflow_test(mapping, len))
                                would_hit_hwbug = 1;
-                        if ((tp->tg3_flags3 & TG3_FLG3_40BIT_DMA_LIMIT_BUG) &&
+                        if (tg3_flag(tp, 40BIT_DMA_LIMIT_BUG) &&
                            tg3_40bit_overflow_test(tp, mapping, len))
                                would_hit_hwbug = 1;
-                        if (tp->tg3_flags2 & TG3_FLG2_HW_TSO)
+                        if (tg3_flag(tp, HW_TSO_1) ||
+                            tg3_flag(tp, HW_TSO_2) ||
+                            tg3_flag(tp, HW_TSO_3))
                                tg3_set_txd(tnapi, entry, mapping, len,
                                            base_flags, (i == last)|(mss << 1));
                        else
@@ -6066,20 +6076,15 @@ static netdev_tx_t tg3_start_xmit_dma_bug(struct sk_buff *skb,
        }
        if (would_hit_hwbug) {
-                u32 last_plus_one = entry;
+                tg3_skb_error_unmap(tnapi, skb, i);
-                u32 start;
-                start = entry - 1 - skb_shinfo(skb)->nr_frags;
-                start &= (TG3_TX_RING_SIZE - 1);
                /* If the workaround fails due to memory/mapping
                 * failure, silently drop this packet.
                 */
-                if (tigon3_dma_hwbug_workaround(tnapi, skb, last_plus_one,
+                if (tigon3_dma_hwbug_workaround(tnapi, skb, base_flags, mss))
-                                                &start, base_flags, mss))
                        goto out_unlock;
-                entry = start;
+                entry = NEXT_TX(tnapi->tx_prod);
        }
        /* Packets are ready, update Tx producer idx local and on card. */
@@ -6105,25 +6110,66 @@ out_unlock:
        return NETDEV_TX_OK;
 dma_error:
-        last = i;
+        tg3_skb_error_unmap(tnapi, skb, i);
-        entry = tnapi->tx_prod;
+        dev_kfree_skb(skb);
-        tnapi->tx_buffers[entry].skb = NULL;
+        tnapi->tx_buffers[tnapi->tx_prod].skb = NULL;
-        pci_unmap_single(tp->pdev,
+        return NETDEV_TX_OK;
-                         dma_unmap_addr(&tnapi->tx_buffers[entry], mapping),
+}
-                         skb_headlen(skb),
-                         PCI_DMA_TODEVICE);
-        for (i = 0; i <= last; i++) {
-                skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
-                entry = NEXT_TX(entry);
-                pci_unmap_page(tp->pdev,
+static void tg3_set_loopback(struct net_device *dev, u32 features)
-                               dma_unmap_addr(&tnapi->tx_buffers[entry],
+{
-                                              mapping),
+        struct tg3 *tp = netdev_priv(dev);
-                               frag->size, PCI_DMA_TODEVICE);
+        if (features & NETIF_F_LOOPBACK) {
+                if (tp->mac_mode & MAC_MODE_PORT_INT_LPBACK)
+                        return;
+                /*
+                 * Clear MAC_MODE_HALF_DUPLEX or you won't get packets back in
+                 * loopback mode if Half-Duplex mode was negotiated earlier.
+                 */
+                tp->mac_mode &= ~MAC_MODE_HALF_DUPLEX;
+                /* Enable internal MAC loopback mode */
+                tp->mac_mode |= MAC_MODE_PORT_INT_LPBACK;
+                spin_lock_bh(&tp->lock);
+                tw32(MAC_MODE, tp->mac_mode);
+                netif_carrier_on(tp->dev);
+                spin_unlock_bh(&tp->lock);
+                netdev_info(dev, "Internal MAC loopback mode enabled.\n");
+        } else {
+                if (!(tp->mac_mode & MAC_MODE_PORT_INT_LPBACK))
+                        return;
+                /* Disable internal MAC loopback mode */
+                tp->mac_mode &= ~MAC_MODE_PORT_INT_LPBACK;
+                spin_lock_bh(&tp->lock);
+                tw32(MAC_MODE, tp->mac_mode);
+                /* Force link status check */
+                tg3_setup_phy(tp, 1);
+                spin_unlock_bh(&tp->lock);
+                netdev_info(dev, "Internal MAC loopback mode disabled.\n");
        }
+}
-        dev_kfree_skb(skb);
+static u32 tg3_fix_features(struct net_device *dev, u32 features)
-        return NETDEV_TX_OK;
+{
+        struct tg3 *tp = netdev_priv(dev);
+        if (dev->mtu > ETH_DATA_LEN && tg3_flag(tp, 5780_CLASS))
+                features &= ~NETIF_F_ALL_TSO;
+        return features;
+}
+static int tg3_set_features(struct net_device *dev, u32 features)
+{
+        u32 changed = dev->features ^ features;
+        if ((changed & NETIF_F_LOOPBACK) && netif_running(dev))
+                tg3_set_loopback(dev, features);
+        return 0;
 }
 static inline void tg3_set_mtu(struct net_device *dev, struct tg3 *tp,
@@ -6132,16 +6178,18 @@ static inline void tg3_set_mtu(struct net_device *dev, struct tg3 *tp,
        dev->mtu = new_mtu;
        if (new_mtu > ETH_DATA_LEN) {
-                if (tp->tg3_flags2 & TG3_FLG2_5780_CLASS) {
+                if (tg3_flag(tp, 5780_CLASS)) {
-                        tp->tg3_flags2 &= ~TG3_FLG2_TSO_CAPABLE;
+                        netdev_update_features(dev);
-                        ethtool_op_set_tso(dev, 0);
+                        tg3_flag_clear(tp, TSO_CAPABLE);
                } else {
-                        tp->tg3_flags |= TG3_FLAG_JUMBO_RING_ENABLE;
+                        tg3_flag_set(tp, JUMBO_RING_ENABLE);
                }
        } else {
-                if (tp->tg3_flags2 & TG3_FLG2_5780_CLASS)
+                if (tg3_flag(tp, 5780_CLASS)) {
-                        tp->tg3_flags2 |= TG3_FLG2_TSO_CAPABLE;
+                        tg3_flag_set(tp, TSO_CAPABLE);
-                tp->tg3_flags &= ~TG3_FLAG_JUMBO_RING_ENABLE;
+                        netdev_update_features(dev);
+                }
+                tg3_flag_clear(tp, JUMBO_RING_ENABLE);
        }
 }
@@ -6195,7 +6243,7 @@ static void tg3_rx_prodring_free(struct tg3 *tp,
                        tg3_rx_skb_free(tp, &tpr->rx_std_buffers[i],
                                        tp->rx_pkt_map_sz);
-                if (tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) {
+                if (tg3_flag(tp, JUMBO_CAPABLE)) {
                        for (i = tpr->rx_jmb_cons_idx;
                             i != tpr->rx_jmb_prod_idx;
                             i = (i + 1) & tp->rx_jmb_ring_mask) {
@@ -6211,8 +6259,7 @@ static void tg3_rx_prodring_free(struct tg3 *tp,
                tg3_rx_skb_free(tp, &tpr->rx_std_buffers[i],
                                tp->rx_pkt_map_sz);
-        if ((tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) &&
+        if (tg3_flag(tp, JUMBO_CAPABLE) && !tg3_flag(tp, 5780_CLASS)) {
-            !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) {
                for (i = 0; i <= tp->rx_jmb_ring_mask; i++)
                        tg3_rx_skb_free(tp, &tpr->rx_jmb_buffers[i],
                                        TG3_RX_JMB_MAP_SZ);
@@ -6249,7 +6296,7 @@ static int tg3_rx_prodring_alloc(struct tg3 *tp,
        memset(tpr->rx_std, 0, TG3_RX_STD_RING_BYTES(tp));
        rx_pkt_dma_sz = TG3_RX_STD_DMA_SZ;
-        if ((tp->tg3_flags2 & TG3_FLG2_5780_CLASS) &&
+        if (tg3_flag(tp, 5780_CLASS) &&
            tp->dev->mtu > ETH_DATA_LEN)
                rx_pkt_dma_sz = TG3_RX_JMB_DMA_SZ;
        tp->rx_pkt_map_sz = TG3_RX_DMA_TO_MAP_SZ(rx_pkt_dma_sz);
@@ -6282,13 +6329,12 @@ static int tg3_rx_prodring_alloc(struct tg3 *tp,
                }
        }
-        if (!(tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) ||
+        if (!tg3_flag(tp, JUMBO_CAPABLE) || tg3_flag(tp, 5780_CLASS))
-            (tp->tg3_flags2 & TG3_FLG2_5780_CLASS))
                goto done;
        memset(tpr->rx_jmb, 0, TG3_RX_JMB_RING_BYTES(tp));
-        if (!(tp->tg3_flags & TG3_FLAG_JUMBO_RING_ENABLE))
+        if (!tg3_flag(tp, JUMBO_RING_ENABLE))
                goto done;
        for (i = 0; i <= tp->rx_jmb_ring_mask; i++) {
@@ -6357,8 +6403,7 @@ static int tg3_rx_prodring_init(struct tg3 *tp,
        if (!tpr->rx_std)
                goto err_out;
-        if ((tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) &&
+        if (tg3_flag(tp, JUMBO_CAPABLE) && !tg3_flag(tp, 5780_CLASS)) {
-            !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) {
                tpr->rx_jmb_buffers = kzalloc(TG3_RX_JMB_BUFF_RING_SIZE(tp),
                                              GFP_KERNEL);
                if (!tpr->rx_jmb_buffers)
@@ -6556,8 +6601,8 @@ static int tg3_alloc_consistent(struct tg3 *tp)
                /* If multivector TSS is enabled, vector 0 does not handle
                 * tx interrupts.  Don't allocate any resources for it.
                 */
-                if ((!i && !(tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS)) ||
+                if ((!i && !tg3_flag(tp, ENABLE_TSS)) ||
-                    (i && (tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS))) {
+                    (i && tg3_flag(tp, ENABLE_TSS))) {
                        tnapi->tx_buffers = kzalloc(sizeof(struct ring_info) *
                                                    TG3_TX_RING_SIZE,
                                                    GFP_KERNEL);
@@ -6597,7 +6642,7 @@ static int tg3_alloc_consistent(struct tg3 *tp)
                 * If multivector RSS is enabled, vector 0 does not handle
                 * rx or tx interrupts.  Don't allocate any resources for it.
                 */
-                if (!i && (tp->tg3_flags3 & TG3_FLG3_ENABLE_RSS))
+                if (!i && tg3_flag(tp, ENABLE_RSS))
                        continue;
                tnapi->rx_rcb = dma_alloc_coherent(&tp->pdev->dev,
@@ -6627,7 +6672,7 @@ static int tg3_stop_block(struct tg3 *tp, unsigned long ofs, u32 enable_bit, int
        unsigned int i;
        u32 val;
-        if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS) {
+        if (tg3_flag(tp, 5705_PLUS)) {
                switch (ofs) {
                case RCVLSC_MODE:
                case DMAC_MODE:
@@ -6737,7 +6782,7 @@ static void tg3_ape_send_event(struct tg3 *tp, u32 event)
        u32 apedata;
        /* NCSI does not support APE events */
-        if (tp->tg3_flags3 & TG3_FLG3_APE_HAS_NCSI)
+        if (tg3_flag(tp, APE_HAS_NCSI))
                return;
        apedata = tg3_ape_read32(tp, TG3_APE_SEG_SIG);
@@ -6776,7 +6821,7 @@ static void tg3_ape_driver_state_change(struct tg3 *tp, int kind)
        u32 event;
        u32 apedata;
-        if (!(tp->tg3_flags3 & TG3_FLG3_ENABLE_APE))
+        if (!tg3_flag(tp, ENABLE_APE))
                return;
        switch (kind) {
@@ -6805,7 +6850,7 @@ static void tg3_ape_driver_state_change(struct tg3 *tp, int kind)
                tg3_ape_write32(tp, TG3_APE_HOST_SEG_SIG, 0x0);
                if (device_may_wakeup(&tp->pdev->dev) &&
-                    (tp->tg3_flags & TG3_FLAG_WOL_ENABLE)) {
+                    tg3_flag(tp, WOL_ENABLE)) {
                        tg3_ape_write32(tp, TG3_APE_HOST_WOL_SPEED,
                                            TG3_APE_HOST_WOL_SPEED_AUTO);
                        apedata = TG3_APE_HOST_DRVR_STATE_WOL;
@@ -6834,7 +6879,7 @@ static void tg3_write_sig_pre_reset(struct tg3 *tp, int kind)
        tg3_write_mem(tp, NIC_SRAM_FIRMWARE_MBOX,
                      NIC_SRAM_FIRMWARE_MBOX_MAGIC1);
-        if (tp->tg3_flags2 & TG3_FLG2_ASF_NEW_HANDSHAKE) {
+        if (tg3_flag(tp, ASF_NEW_HANDSHAKE)) {
                switch (kind) {
                case RESET_KIND_INIT:
                        tg3_write_mem(tp, NIC_SRAM_FW_DRV_STATE_MBOX,
@@ -6864,7 +6909,7 @@ static void tg3_write_sig_pre_reset(struct tg3 *tp, int kind)
 /* tp->lock is held. */
 static void tg3_write_sig_post_reset(struct tg3 *tp, int kind)
 {
-        if (tp->tg3_flags2 & TG3_FLG2_ASF_NEW_HANDSHAKE) {
+        if (tg3_flag(tp, ASF_NEW_HANDSHAKE)) {
                switch (kind) {
                case RESET_KIND_INIT:
                        tg3_write_mem(tp, NIC_SRAM_FW_DRV_STATE_MBOX,
@@ -6888,7 +6933,7 @@ static void tg3_write_sig_post_reset(struct tg3 *tp, int kind)
 /* tp->lock is held. */
 static void tg3_write_sig_legacy(struct tg3 *tp, int kind)
 {
-        if (tp->tg3_flags & TG3_FLAG_ENABLE_ASF) {
+        if (tg3_flag(tp, ENABLE_ASF)) {
                switch (kind) {
                case RESET_KIND_INIT:
                        tg3_write_mem(tp, NIC_SRAM_FW_DRV_STATE_MBOX,
@@ -6939,9 +6984,8 @@ static int tg3_poll_fw(struct tg3 *tp)
         * of the above loop as an error, but do report the lack of
         * running firmware once.
         */
-        if (i >= 100000 &&
+        if (i >= 100000 && !tg3_flag(tp, NO_FWARE_REPORTED)) {
-            !(tp->tg3_flags2 & TG3_FLG2_NO_FWARE_REPORTED)) {
+                tg3_flag_set(tp, NO_FWARE_REPORTED);
-                tp->tg3_flags2 |= TG3_FLG2_NO_FWARE_REPORTED;
                netdev_info(tp->dev, "No firmware running\n");
        }
@@ -6974,10 +7018,10 @@ static void tg3_restore_pci_state(struct tg3 *tp)
        /* Set MAX PCI retry to zero. */
        val = (PCISTATE_ROM_ENABLE | PCISTATE_ROM_RETRY_ENABLE);
        if (tp->pci_chip_rev_id == CHIPREV_ID_5704_A0 &&
-            (tp->tg3_flags & TG3_FLAG_PCIX_MODE))
+            tg3_flag(tp, PCIX_MODE))
                val |= PCISTATE_RETRY_SAME_DMA;
        /* Allow reads and writes to the APE register and memory space. */
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)
+        if (tg3_flag(tp, ENABLE_APE))
                val |= PCISTATE_ALLOW_APE_CTLSPC_WR |
                       PCISTATE_ALLOW_APE_SHMEM_WR |
                       PCISTATE_ALLOW_APE_PSPACE_WR;
@@ -6986,7 +7030,7 @@ static void tg3_restore_pci_state(struct tg3 *tp)
        pci_write_config_word(tp->pdev, PCI_COMMAND, tp->pci_cmd);
        if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5785) {
-                if (tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS)
+                if (tg3_flag(tp, PCI_EXPRESS))
                        pcie_set_readrq(tp->pdev, tp->pcie_readrq);
                else {
                        pci_write_config_byte(tp->pdev, PCI_CACHE_LINE_SIZE,
@@ -6997,7 +7041,7 @@ static void tg3_restore_pci_state(struct tg3 *tp)
        }
        /* Make sure PCI-X relaxed ordering bit is clear. */
-        if (tp->tg3_flags & TG3_FLAG_PCIX_MODE) {
+        if (tg3_flag(tp, PCIX_MODE)) {
                u16 pcix_cmd;
                pci_read_config_word(tp->pdev, tp->pcix_cap + PCI_X_CMD,
@@ -7007,12 +7051,12 @@ static void tg3_restore_pci_state(struct tg3 *tp)
                                      pcix_cmd);
        }
-        if (tp->tg3_flags2 & TG3_FLG2_5780_CLASS) {
+        if (tg3_flag(tp, 5780_CLASS)) {
                /* Chip reset on 5780 will reset MSI enable bit,
                 * so need to restore it.
                 */
-                if (tp->tg3_flags2 & TG3_FLG2_USING_MSI) {
+                if (tg3_flag(tp, USING_MSI)) {
                        u16 ctrl;
                        pci_read_config_word(tp->pdev,
@@ -7052,7 +7096,7 @@ static int tg3_chip_reset(struct tg3 *tp)
        tg3_save_pci_state(tp);
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5752 ||
-            (tp->tg3_flags3 & TG3_FLG3_5755_PLUS))
+            tg3_flag(tp, 5755_PLUS))
                tw32(GRC_FASTBOOT_PC, 0);
        /*
@@ -7071,7 +7115,7 @@ static int tg3_chip_reset(struct tg3 *tp)
         * at this time, but the irq handler may still be called due to irq
         * sharing or irqpoll.
         */
-        tp->tg3_flags |= TG3_FLAG_CHIP_RESETTING;
+        tg3_flag_set(tp, CHIP_RESETTING);
        for (i = 0; i < tp->irq_cnt; i++) {
                struct tg3_napi *tnapi = &tp->napi[i];
                if (tnapi->hw_status) {
@@ -7094,10 +7138,10 @@ static int tg3_chip_reset(struct tg3 *tp)
        /* do the reset */
        val = GRC_MISC_CFG_CORECLK_RESET;
-        if (tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS) {
+        if (tg3_flag(tp, PCI_EXPRESS)) {
                /* Force PCIe 1.0a mode */
                if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5785 &&
-                    !(tp->tg3_flags3 & TG3_FLG3_5717_PLUS) &&
+                    !tg3_flag(tp, 57765_PLUS) &&
                    tr32(TG3_PCIE_PHY_TSTCTL) ==
                    (TG3_PCIE_PHY_TSTCTL_PCIE10 | TG3_PCIE_PHY_TSTCTL_PSCRAM))
                        tw32(TG3_PCIE_PHY_TSTCTL, TG3_PCIE_PHY_TSTCTL_PSCRAM);
@@ -7115,8 +7159,7 @@ static int tg3_chip_reset(struct tg3 *tp)
        }
        /* Manage gphy power for all CPMU absent PCIe devices. */
-        if ((tp->tg3_flags2 & TG3_FLG2_5705_PLUS) &&
+        if (tg3_flag(tp, 5705_PLUS) && !tg3_flag(tp, CPMU_PRESENT))
-            !(tp->tg3_flags & TG3_FLAG_CPMU_PRESENT))
                val |= GRC_MISC_CFG_KEEP_GPHY_POWER;
        tw32(GRC_MISC_CFG, val);
@@ -7149,7 +7192,7 @@ static int tg3_chip_reset(struct tg3 *tp)
        udelay(120);
-        if ((tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS) && tp->pcie_cap) {
+        if (tg3_flag(tp, PCI_EXPRESS) && tp->pcie_cap) {
                u16 val16;
                if (tp->pci_chip_rev_id == CHIPREV_ID_5750_A0) {
@@ -7175,7 +7218,7 @@ static int tg3_chip_reset(struct tg3 *tp)
                 * Older PCIe devices only support the 128 byte
                 * MPS setting.  Enforce the restriction.
                 */
-                if (!(tp->tg3_flags & TG3_FLAG_CPMU_PRESENT))
+                if (!tg3_flag(tp, CPMU_PRESENT))
                        val16 &= ~PCI_EXP_DEVCTL_PAYLOAD;
                pci_write_config_word(tp->pdev,
                                      tp->pcie_cap + PCI_EXP_DEVCTL,
@@ -7194,10 +7237,11 @@ static int tg3_chip_reset(struct tg3 *tp)
        tg3_restore_pci_state(tp);
-        tp->tg3_flags &= ~TG3_FLAG_CHIP_RESETTING;
+        tg3_flag_clear(tp, CHIP_RESETTING);
+        tg3_flag_clear(tp, ERROR_PROCESSED);
        val = 0;
-        if (tp->tg3_flags2 & TG3_FLG2_5780_CLASS)
+        if (tg3_flag(tp, 5780_CLASS))
                val = tr32(MEMARB_MODE);
        tw32(MEMARB_MODE, val | MEMARB_MODE_ENABLE);
@@ -7222,7 +7266,7 @@ static int tg3_chip_reset(struct tg3 *tp)
                tw32(TG3PCI_CLOCK_CTRL, tp->pci_clock_ctrl);
        }
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)
+        if (tg3_flag(tp, ENABLE_APE))
                tp->mac_mode = MAC_MODE_APE_TX_EN |
                               MAC_MODE_APE_RX_EN |
                               MAC_MODE_TDE_ENABLE;
@@ -7247,28 +7291,33 @@ static int tg3_chip_reset(struct tg3 *tp)
        tg3_mdio_start(tp);
-        if ((tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS) &&
+        if (tg3_flag(tp, PCI_EXPRESS) &&
            tp->pci_chip_rev_id != CHIPREV_ID_5750_A0 &&
            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5785 &&
-            !(tp->tg3_flags3 & TG3_FLG3_5717_PLUS)) {
+            !tg3_flag(tp, 57765_PLUS)) {
                val = tr32(0x7c00);
                tw32(0x7c00, val | (1 << 25));
        }
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720) {
+                val = tr32(TG3_CPMU_CLCK_ORIDE);
+                tw32(TG3_CPMU_CLCK_ORIDE, val & ~CPMU_CLCK_ORIDE_MAC_ORIDE_EN);
+        }
        /* Reprobe ASF enable state.  */
-        tp->tg3_flags &= ~TG3_FLAG_ENABLE_ASF;
+        tg3_flag_clear(tp, ENABLE_ASF);
-        tp->tg3_flags2 &= ~TG3_FLG2_ASF_NEW_HANDSHAKE;
+        tg3_flag_clear(tp, ASF_NEW_HANDSHAKE);
        tg3_read_mem(tp, NIC_SRAM_DATA_SIG, &val);
        if (val == NIC_SRAM_DATA_SIG_MAGIC) {
                u32 nic_cfg;
                tg3_read_mem(tp, NIC_SRAM_DATA_CFG, &nic_cfg);
                if (nic_cfg & NIC_SRAM_DATA_CFG_ASF_ENABLE) {
-                        tp->tg3_flags |= TG3_FLAG_ENABLE_ASF;
+                        tg3_flag_set(tp, ENABLE_ASF);
                        tp->last_event_jiffies = jiffies;
-                        if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS)
+                        if (tg3_flag(tp, 5750_PLUS))
-                                tp->tg3_flags2 |= TG3_FLG2_ASF_NEW_HANDSHAKE;
+                                tg3_flag_set(tp, ASF_NEW_HANDSHAKE);
                }
        }
@@ -7278,8 +7327,7 @@ static int tg3_chip_reset(struct tg3 *tp)
 /* tp->lock is held. */
 static void tg3_stop_fw(struct tg3 *tp)
 {
-        if ((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) &&
+        if (tg3_flag(tp, ENABLE_ASF) && !tg3_flag(tp, ENABLE_APE)) {
-           !(tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)) {
                /* Wait for RX cpu to ACK the previous event. */
                tg3_wait_for_event_ack(tp);
@@ -7325,8 +7373,7 @@ static int tg3_halt_cpu(struct tg3 *tp, u32 offset)
 {
        int i;
-        BUG_ON(offset == TX_CPU_BASE &&
+        BUG_ON(offset == TX_CPU_BASE && tg3_flag(tp, 5705_PLUS));
-            (tp->tg3_flags2 & TG3_FLG2_5705_PLUS));
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906) {
                u32 val = tr32(GRC_VCPU_EXT_CTRL);
@@ -7361,7 +7408,7 @@ static int tg3_halt_cpu(struct tg3 *tp, u32 offset)
        }
        /* Clear firmware's nvram arbitration. */
-        if (tp->tg3_flags & TG3_FLAG_NVRAM)
+        if (tg3_flag(tp, NVRAM))
                tw32(NVRAM_SWARB, SWARB_REQ_CLR0);
        return 0;
 }
@@ -7379,15 +7426,14 @@ static int tg3_load_firmware_cpu(struct tg3 *tp, u32 cpu_base, u32 cpu_scratch_b
        int err, lock_err, i;
        void (*write_op)(struct tg3 *, u32, u32);
-        if (cpu_base == TX_CPU_BASE &&
+        if (cpu_base == TX_CPU_BASE && tg3_flag(tp, 5705_PLUS)) {
-            (tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) {
                netdev_err(tp->dev,
                           "%s: Trying to load TX cpu firmware which is 5705\n",
                           __func__);
                return -EINVAL;
        }
-        if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS)
+        if (tg3_flag(tp, 5705_PLUS))
                write_op = tg3_write_mem;
        else
                write_op = tg3_write_indirect_reg32;
@@ -7473,8 +7519,6 @@ static int tg3_load_5701_a0_firmware_fix(struct tg3 *tp)
        return 0;
 }
-/* 5705 needs a special version of the TSO firmware.  */
 /* tp->lock is held. */
 static int tg3_load_tso_firmware(struct tg3 *tp)
 {
@@ -7483,7 +7527,9 @@ static int tg3_load_tso_firmware(struct tg3 *tp)
        unsigned long cpu_base, cpu_scratch_base, cpu_scratch_size;
        int err, i;
-        if (tp->tg3_flags2 & TG3_FLG2_HW_TSO)
+        if (tg3_flag(tp, HW_TSO_1) ||
+            tg3_flag(tp, HW_TSO_2) ||
+            tg3_flag(tp, HW_TSO_3))
                return 0;
        fw_data = (void *)tp->fw->data;
@@ -7552,7 +7598,7 @@ static int tg3_set_mac_addr(struct net_device *dev, void *p)
        if (!netif_running(dev))
                return 0;
-        if (tp->tg3_flags & TG3_FLAG_ENABLE_ASF) {
+        if (tg3_flag(tp, ENABLE_ASF)) {
                u32 addr0_high, addr0_low, addr1_high, addr1_low;
                addr0_high = tr32(MAC_ADDR_0_HIGH);
@@ -7587,7 +7633,7 @@ static void tg3_set_bdinfo(struct tg3 *tp, u32 bdinfo_addr,
                      (bdinfo_addr + TG3_BDINFO_MAXLEN_FLAGS),
                       maxlen_flags);
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+        if (!tg3_flag(tp, 5705_PLUS))
                tg3_write_mem(tp,
                              (bdinfo_addr + TG3_BDINFO_NIC_ADDR),
                              nic_addr);
@@ -7598,7 +7644,7 @@ static void __tg3_set_coalesce(struct tg3 *tp, struct ethtool_coalesce *ec)
 {
        int i;
-        if (!(tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS)) {
+        if (!tg3_flag(tp, ENABLE_TSS)) {
                tw32(HOSTCC_TXCOL_TICKS, ec->tx_coalesce_usecs);
                tw32(HOSTCC_TXMAX_FRAMES, ec->tx_max_coalesced_frames);
                tw32(HOSTCC_TXCOAL_MAXF_INT, ec->tx_max_coalesced_frames_irq);
@@ -7608,7 +7654,7 @@ static void __tg3_set_coalesce(struct tg3 *tp, struct ethtool_coalesce *ec)
                tw32(HOSTCC_TXCOAL_MAXF_INT, 0);
        }
-        if (!(tp->tg3_flags3 & TG3_FLG3_ENABLE_RSS)) {
+        if (!tg3_flag(tp, ENABLE_RSS)) {
                tw32(HOSTCC_RXCOL_TICKS, ec->rx_coalesce_usecs);
                tw32(HOSTCC_RXMAX_FRAMES, ec->rx_max_coalesced_frames);
                tw32(HOSTCC_RXCOAL_MAXF_INT, ec->rx_max_coalesced_frames_irq);
@@ -7618,7 +7664,7 @@ static void __tg3_set_coalesce(struct tg3 *tp, struct ethtool_coalesce *ec)
                tw32(HOSTCC_RXCOAL_MAXF_INT, 0);
        }
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) {
+        if (!tg3_flag(tp, 5705_PLUS)) {
                u32 val = ec->stats_block_coalesce_usecs;
                tw32(HOSTCC_RXCOAL_TICK_INT, ec->rx_coalesce_usecs_irq);
@@ -7640,7 +7686,7 @@ static void __tg3_set_coalesce(struct tg3 *tp, struct ethtool_coalesce *ec)
                reg = HOSTCC_RXCOAL_MAXF_INT_VEC1 + i * 0x18;
                tw32(reg, ec->rx_max_coalesced_frames_irq);
-                if (tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS) {
+                if (tg3_flag(tp, ENABLE_TSS)) {
                        reg = HOSTCC_TXCOL_TICKS_VEC1 + i * 0x18;
                        tw32(reg, ec->tx_coalesce_usecs);
                        reg = HOSTCC_TXMAX_FRAMES_VEC1 + i * 0x18;
@@ -7655,7 +7701,7 @@ static void __tg3_set_coalesce(struct tg3 *tp, struct ethtool_coalesce *ec)
                tw32(HOSTCC_RXMAX_FRAMES_VEC1 + i * 0x18, 0);
                tw32(HOSTCC_RXCOAL_MAXF_INT_VEC1 + i * 0x18, 0);
-                if (tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS) {
+                if (tg3_flag(tp, ENABLE_TSS)) {
                        tw32(HOSTCC_TXCOL_TICKS_VEC1 + i * 0x18, 0);
                        tw32(HOSTCC_TXMAX_FRAMES_VEC1 + i * 0x18, 0);
                        tw32(HOSTCC_TXCOAL_MAXF_INT_VEC1 + i * 0x18, 0);
@@ -7671,10 +7717,9 @@ static void tg3_rings_reset(struct tg3 *tp)
        struct tg3_napi *tnapi = &tp->napi[0];
        /* Disable all transmit rings but the first. */
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+        if (!tg3_flag(tp, 5705_PLUS))
                limit = NIC_SRAM_SEND_RCB + TG3_BDINFO_SIZE * 16;
-        else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+        else if (tg3_flag(tp, 5717_PLUS))
-                 GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)
                limit = NIC_SRAM_SEND_RCB + TG3_BDINFO_SIZE * 4;
        else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57765)
                limit = NIC_SRAM_SEND_RCB + TG3_BDINFO_SIZE * 2;
@@ -7688,10 +7733,9 @@ static void tg3_rings_reset(struct tg3 *tp)
        /* Disable all receive return rings but the first. */
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+        if (tg3_flag(tp, 5717_PLUS))
-            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)
                limit = NIC_SRAM_RCV_RET_RCB + TG3_BDINFO_SIZE * 17;
-        else if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+        else if (!tg3_flag(tp, 5705_PLUS))
                limit = NIC_SRAM_RCV_RET_RCB + TG3_BDINFO_SIZE * 16;
        else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
                 GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57765)
@@ -7708,16 +7752,16 @@ static void tg3_rings_reset(struct tg3 *tp)
        tw32_mailbox_f(tp->napi[0].int_mbox, 1);
        /* Zero mailbox registers. */
-        if (tp->tg3_flags & TG3_FLAG_SUPPORT_MSIX) {
+        if (tg3_flag(tp, SUPPORT_MSIX)) {
                for (i = 1; i < tp->irq_max; i++) {
                        tp->napi[i].tx_prod = 0;
                        tp->napi[i].tx_cons = 0;
-                        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS)
+                        if (tg3_flag(tp, ENABLE_TSS))
                                tw32_mailbox(tp->napi[i].prodmbox, 0);
                        tw32_rx_mbox(tp->napi[i].consmbox, 0);
                        tw32_mailbox_f(tp->napi[i].int_mbox, 1);
                }
-                if (!(tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS))
+                if (!tg3_flag(tp, ENABLE_TSS))
                        tw32_mailbox(tp->napi[0].prodmbox, 0);
        } else {
                tp->napi[0].tx_prod = 0;
@@ -7727,7 +7771,7 @@ static void tg3_rings_reset(struct tg3 *tp)
        }
        /* Make sure the NIC-based send BD rings are disabled. */
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) {
+        if (!tg3_flag(tp, 5705_PLUS)) {
                u32 mbox = MAILBOX_SNDNIC_PROD_IDX_0 + TG3_64BIT_REG_LOW;
                for (i = 0; i < 16; i++)
                        tw32_tx_mbox(mbox + i * 8, 0);
@@ -7787,6 +7831,47 @@ static void tg3_rings_reset(struct tg3 *tp)
        }
 }
+static void tg3_setup_rxbd_thresholds(struct tg3 *tp)
+{
+        u32 val, bdcache_maxcnt, host_rep_thresh, nic_rep_thresh;
+        if (!tg3_flag(tp, 5750_PLUS) ||
+            tg3_flag(tp, 5780_CLASS) ||
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750 ||
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5752)
+                bdcache_maxcnt = TG3_SRAM_RX_STD_BDCACHE_SIZE_5700;
+        else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
+                 GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787)
+                bdcache_maxcnt = TG3_SRAM_RX_STD_BDCACHE_SIZE_5755;
+        else
+                bdcache_maxcnt = TG3_SRAM_RX_STD_BDCACHE_SIZE_5906;
+        nic_rep_thresh = min(bdcache_maxcnt / 2, tp->rx_std_max_post);
+        host_rep_thresh = max_t(u32, tp->rx_pending / 8, 1);
+        val = min(nic_rep_thresh, host_rep_thresh);
+        tw32(RCVBDI_STD_THRESH, val);
+        if (tg3_flag(tp, 57765_PLUS))
+                tw32(STD_REPLENISH_LWM, bdcache_maxcnt);
+        if (!tg3_flag(tp, JUMBO_CAPABLE) || tg3_flag(tp, 5780_CLASS))
+                return;
+        if (!tg3_flag(tp, 5705_PLUS))
+                bdcache_maxcnt = TG3_SRAM_RX_JMB_BDCACHE_SIZE_5700;
+        else
+                bdcache_maxcnt = TG3_SRAM_RX_JMB_BDCACHE_SIZE_5717;
+        host_rep_thresh = max_t(u32, tp->rx_jumbo_pending / 8, 1);
+        val = min(bdcache_maxcnt / 2, host_rep_thresh);
+        tw32(RCVBDI_JUMBO_THRESH, val);
+        if (tg3_flag(tp, 57765_PLUS))
+                tw32(JMB_REPLENISH_LWM, bdcache_maxcnt);
+}
 /* tp->lock is held. */
 static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
 {
@@ -7800,7 +7885,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        tg3_write_sig_pre_reset(tp, RESET_KIND_INIT);
-        if (tp->tg3_flags & TG3_FLAG_INIT_COMPLETE)
+        if (tg3_flag(tp, INIT_COMPLETE))
                tg3_abort_hw(tp, 1);
        /* Enable MAC control of LPI */
@@ -7820,7 +7905,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5717)
                        val |= TG3_CPMU_EEEMD_SND_IDX_DET_EN;
-                if (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)
+                if (tg3_flag(tp, ENABLE_APE))
                        val |= TG3_CPMU_EEEMD_APE_TX_DET_EN;
                tw32_f(TG3_CPMU_EEE_MODE, val);
@@ -7879,7 +7964,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                tw32(TG3_PCIE_LNKCTL, val | TG3_PCIE_LNKCTL_L1_PLL_PD_DIS);
        }
-        if (tp->tg3_flags3 & TG3_FLG3_L1PLLPD_EN) {
+        if (tg3_flag(tp, L1PLLPD_EN)) {
                u32 grc_mode = tr32(GRC_MODE);
                /* Access the lower 1K of PL PCIE block registers. */
@@ -7909,6 +7994,22 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                        tw32(GRC_MODE, grc_mode);
                }
+                if (GET_CHIP_REV(tp->pci_chip_rev_id) != CHIPREV_57765_AX) {
+                        u32 grc_mode = tr32(GRC_MODE);
+                        /* Access the lower 1K of DL PCIE block registers. */
+                        val = grc_mode & ~GRC_MODE_PCIE_PORT_MASK;
+                        tw32(GRC_MODE, val | GRC_MODE_PCIE_DL_SEL);
+                        val = tr32(TG3_PCIE_TLDLPL_PORT +
+                                   TG3_PCIE_DL_LO_FTSMAX);
+                        val &= ~TG3_PCIE_DL_LO_FTSMAX_MSK;
+                        tw32(TG3_PCIE_TLDLPL_PORT + TG3_PCIE_DL_LO_FTSMAX,
+                             val | TG3_PCIE_DL_LO_FTSMAX_VAL);
+                        tw32(GRC_MODE, grc_mode);
+                }
                val = tr32(TG3_CPMU_LSPD_10MB_CLK);
                val &= ~CPMU_LSPD_10MB_MACCLK_MASK;
                val |= CPMU_LSPD_10MB_MACCLK_6_25;
@@ -7920,20 +8021,20 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
         * other revision.  But do not set this on PCI Express
         * chips and don't even touch the clocks if the CPMU is present.
         */
-        if (!(tp->tg3_flags & TG3_FLAG_CPMU_PRESENT)) {
+        if (!tg3_flag(tp, CPMU_PRESENT)) {
-                if (!(tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS))
+                if (!tg3_flag(tp, PCI_EXPRESS))
                        tp->pci_clock_ctrl |= CLOCK_CTRL_DELAY_PCI_GRANT;
                tw32_f(TG3PCI_CLOCK_CTRL, tp->pci_clock_ctrl);
        }
        if (tp->pci_chip_rev_id == CHIPREV_ID_5704_A0 &&
-            (tp->tg3_flags & TG3_FLAG_PCIX_MODE)) {
+            tg3_flag(tp, PCIX_MODE)) {
                val = tr32(TG3PCI_PCISTATE);
                val |= PCISTATE_RETRY_SAME_DMA;
                tw32(TG3PCI_PCISTATE, val);
        }
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE) {
+        if (tg3_flag(tp, ENABLE_APE)) {
                /* Allow reads and writes to the
                 * APE register and memory space.
                 */
@@ -7960,11 +8061,14 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        if (err)
                return err;
-        if (tp->tg3_flags3 & TG3_FLG3_5717_PLUS) {
+        if (tg3_flag(tp, 57765_PLUS)) {
                val = tr32(TG3PCI_DMA_RW_CTRL) &
                      ~DMA_RWCTRL_DIS_CACHE_ALIGNMENT;
                if (tp->pci_chip_rev_id == CHIPREV_ID_57765_A0)
                        val &= ~DMA_RWCTRL_CRDRDR_RDMA_MRRS_MSK;
+                if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_57765 &&
+                    GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5717)
+                        val |= DMA_RWCTRL_TAGGED_STAT_WA;
                tw32(TG3PCI_DMA_RW_CTRL, val | tp->dma_rwctrl);
        } else if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5784 &&
                   GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5761) {
@@ -7999,7 +8103,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        tw32(GRC_MISC_CFG, val);
        /* Initialize MBUF/DESC pool. */
-        if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS) {
+        if (tg3_flag(tp, 5750_PLUS)) {
                /* Do nothing.  */
        } else if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5705) {
                tw32(BUFMGR_MB_POOL_ADDR, NIC_SRAM_MBUF_POOL_BASE);
@@ -8009,7 +8113,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                        tw32(BUFMGR_MB_POOL_SIZE, NIC_SRAM_MBUF_POOL_SIZE96);
                tw32(BUFMGR_DMA_DESC_POOL_ADDR, NIC_SRAM_DMA_DESC_POOL_BASE);
                tw32(BUFMGR_DMA_DESC_POOL_SIZE, NIC_SRAM_DMA_DESC_POOL_SIZE);
-        } else if (tp->tg3_flags2 & TG3_FLG2_TSO_CAPABLE) {
+        } else if (tg3_flag(tp, TSO_CAPABLE)) {
                int fw_len;
                fw_len = tp->fw_len;
@@ -8043,6 +8147,10 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        val = BUFMGR_MODE_ENABLE | BUFMGR_MODE_ATTN_ENABLE;
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)
                val |= BUFMGR_MODE_NO_TX_UNDERRUN;
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+            tp->pci_chip_rev_id == CHIPREV_ID_5719_A0 ||
+            tp->pci_chip_rev_id == CHIPREV_ID_5720_A0)
+                val |= BUFMGR_MODE_MBLOW_ATTN_ENAB;
        tw32(BUFMGR_MODE, val);
        for (i = 0; i < 2000; i++) {
                if (tr32(BUFMGR_MODE) & BUFMGR_MODE_ENABLE)
@@ -8054,21 +8162,10 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                return -ENODEV;
        }
-        /* Setup replenish threshold. */
+        if (tp->pci_chip_rev_id == CHIPREV_ID_5906_A1)
-        val = tp->rx_pending / 8;
+                tw32(ISO_PKT_TX, (tr32(ISO_PKT_TX) & ~0x3) | 0x2);
-        if (val == 0)
-                val = 1;
-        else if (val > tp->rx_std_max_post)
-                val = tp->rx_std_max_post;
-        else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906) {
-                if (tp->pci_chip_rev_id == CHIPREV_ID_5906_A1)
-                        tw32(ISO_PKT_TX, (tr32(ISO_PKT_TX) & ~0x3) | 0x2);
-                if (val > (TG3_RX_INTERNAL_RING_SZ_5906 / 2))
-                        val = TG3_RX_INTERNAL_RING_SZ_5906 / 2;
-        }
-        tw32(RCVBDI_STD_THRESH, val);
+        tg3_setup_rxbd_thresholds(tp);
        /* Initialize TG3_BDINFO's at:
         *  RCVDBDI_STD_BD:     standard eth size rx ring
@@ -8091,13 +8188,12 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
             ((u64) tpr->rx_std_mapping >> 32));
        tw32(RCVDBDI_STD_BD + TG3_BDINFO_HOST_ADDR + TG3_64BIT_REG_LOW,
             ((u64) tpr->rx_std_mapping & 0xffffffff));
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5717 &&
+        if (!tg3_flag(tp, 5717_PLUS))
-            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5719)
                tw32(RCVDBDI_STD_BD + TG3_BDINFO_NIC_ADDR,
                     NIC_SRAM_RX_BUFFER_DESC);
        /* Disable the mini ring */
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+        if (!tg3_flag(tp, 5705_PLUS))
                tw32(RCVDBDI_MINI_BD + TG3_BDINFO_MAXLEN_FLAGS,
                     BDINFO_FLAGS_DISABLED);
@@ -8105,20 +8201,18 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
         * blocks on those devices that have them.
         */
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719 ||
-            ((tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) &&
+            (tg3_flag(tp, JUMBO_CAPABLE) && !tg3_flag(tp, 5780_CLASS))) {
-            !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS))) {
-                /* Setup replenish threshold. */
-                tw32(RCVBDI_JUMBO_THRESH, tp->rx_jumbo_pending / 8);
-                if (tp->tg3_flags & TG3_FLAG_JUMBO_RING_ENABLE) {
+                if (tg3_flag(tp, JUMBO_RING_ENABLE)) {
                        tw32(RCVDBDI_JUMBO_BD + TG3_BDINFO_HOST_ADDR + TG3_64BIT_REG_HIGH,
                             ((u64) tpr->rx_jmb_mapping >> 32));
                        tw32(RCVDBDI_JUMBO_BD + TG3_BDINFO_HOST_ADDR + TG3_64BIT_REG_LOW,
                             ((u64) tpr->rx_jmb_mapping & 0xffffffff));
+                        val = TG3_RX_JMB_RING_SIZE(tp) <<
+                              BDINFO_FLAGS_MAXLEN_SHIFT;
                        tw32(RCVDBDI_JUMBO_BD + TG3_BDINFO_MAXLEN_FLAGS,
-                             (RX_JUMBO_MAX_SIZE << BDINFO_FLAGS_MAXLEN_SHIFT) |
+                             val | BDINFO_FLAGS_USE_EXT_RECV);
-                             BDINFO_FLAGS_USE_EXT_RECV);
+                        if (!tg3_flag(tp, USE_JUMBO_BDFLAG) ||
-                        if (!(tp->tg3_flags3 & TG3_FLG3_USE_JUMBO_BDFLAG) ||
                            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57765)
                                tw32(RCVDBDI_JUMBO_BD + TG3_BDINFO_NIC_ADDR,
                                     NIC_SRAM_RX_JUMBO_BUFFER_DESC);
@@ -8127,32 +8221,27 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                             BDINFO_FLAGS_DISABLED);
                }
-                if (tp->tg3_flags3 & TG3_FLG3_5717_PLUS) {
+                if (tg3_flag(tp, 57765_PLUS)) {
                        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57765)
-                                val = RX_STD_MAX_SIZE_5705;
+                                val = TG3_RX_STD_MAX_SIZE_5700;
                        else
-                                val = RX_STD_MAX_SIZE_5717;
+                                val = TG3_RX_STD_MAX_SIZE_5717;
                        val <<= BDINFO_FLAGS_MAXLEN_SHIFT;
                        val |= (TG3_RX_STD_DMA_SZ << 2);
                } else
                        val = TG3_RX_STD_DMA_SZ << BDINFO_FLAGS_MAXLEN_SHIFT;
        } else
-                val = RX_STD_MAX_SIZE_5705 << BDINFO_FLAGS_MAXLEN_SHIFT;
+                val = TG3_RX_STD_MAX_SIZE_5700 << BDINFO_FLAGS_MAXLEN_SHIFT;
        tw32(RCVDBDI_STD_BD + TG3_BDINFO_MAXLEN_FLAGS, val);
        tpr->rx_std_prod_idx = tp->rx_pending;
        tw32_rx_mbox(TG3_RX_STD_PROD_IDX_REG, tpr->rx_std_prod_idx);
-        tpr->rx_jmb_prod_idx = (tp->tg3_flags & TG3_FLAG_JUMBO_RING_ENABLE) ?
+        tpr->rx_jmb_prod_idx =
-                          tp->rx_jumbo_pending : 0;
+                tg3_flag(tp, JUMBO_RING_ENABLE) ? tp->rx_jumbo_pending : 0;
        tw32_rx_mbox(TG3_RX_JMB_PROD_IDX_REG, tpr->rx_jmb_prod_idx);
-        if (tp->tg3_flags3 & TG3_FLG3_5717_PLUS) {
-                tw32(STD_REPLENISH_LWM, 32);
-                tw32(JMB_REPLENISH_LWM, 16);
-        }
        tg3_rings_reset(tp);
        /* Initialize MAC address and backoff seed. */
@@ -8165,10 +8254,16 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        /* The slot time is changed by tg3_setup_phy if we
         * run at gigabit with half duplex.
         */
-        tw32(MAC_TX_LENGTHS,
+        val = (2 << TX_LENGTHS_IPG_CRS_SHIFT) |
-             (2 << TX_LENGTHS_IPG_CRS_SHIFT) |
+              (6 << TX_LENGTHS_IPG_SHIFT) |
-             (6 << TX_LENGTHS_IPG_SHIFT) |
+              (32 << TX_LENGTHS_SLOT_TIME_SHIFT);
-             (32 << TX_LENGTHS_SLOT_TIME_SHIFT));
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720)
+                val |= tr32(MAC_TX_LENGTHS) &
+                       (TX_LENGTHS_JMB_FRM_LEN_MSK |
+                        TX_LENGTHS_CNT_DWN_VAL_MSK);
+        tw32(MAC_TX_LENGTHS, val);
        /* Receive rules. */
        tw32(MAC_RCV_RULE_CFG, RCV_RULE_CFG_DEFAULT_CLASS);
@@ -8195,33 +8290,39 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705 &&
            tp->pci_chip_rev_id != CHIPREV_ID_5705_A0) {
-                if (tp->tg3_flags2 & TG3_FLG2_TSO_CAPABLE &&
+                if (tg3_flag(tp, TSO_CAPABLE) &&
                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705) {
                        rdmac_mode |= RDMAC_MODE_FIFO_SIZE_128;
                } else if (!(tr32(TG3PCI_PCISTATE) & PCISTATE_BUS_SPEED_HIGH) &&
-                           !(tp->tg3_flags2 & TG3_FLG2_IS_5788)) {
+                           !tg3_flag(tp, IS_5788)) {
                        rdmac_mode |= RDMAC_MODE_FIFO_LONG_BURST;
                }
        }
-        if (tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS)
+        if (tg3_flag(tp, PCI_EXPRESS))
                rdmac_mode |= RDMAC_MODE_FIFO_LONG_BURST;
-        if (tp->tg3_flags2 & TG3_FLG2_HW_TSO)
+        if (tg3_flag(tp, HW_TSO_1) ||
+            tg3_flag(tp, HW_TSO_2) ||
+            tg3_flag(tp, HW_TSO_3))
                rdmac_mode |= RDMAC_MODE_IPV4_LSO_EN;
-        if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO_3) ||
+        if (tg3_flag(tp, 57765_PLUS) ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780)
                rdmac_mode |= RDMAC_MODE_IPV6_LSO_EN;
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720)
+                rdmac_mode |= tr32(RDMAC_MODE) & RDMAC_MODE_H2BNC_VLAN_DET;
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5761 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5784 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780 ||
-            (tp->tg3_flags3 & TG3_FLG3_5717_PLUS)) {
+            tg3_flag(tp, 57765_PLUS)) {
                val = tr32(TG3_RDMA_RSRVCTRL_REG);
-                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) {
+                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719 ||
+                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720) {
                        val &= ~(TG3_RDMA_RSRVCTRL_TXMRGN_MASK |
                                 TG3_RDMA_RSRVCTRL_FIFO_LWM_MASK |
                                 TG3_RDMA_RSRVCTRL_FIFO_HWM_MASK);
@@ -8233,7 +8334,8 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                     val | TG3_RDMA_RSRVCTRL_FIFO_OFLW_FIX);
        }
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) {
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719 ||
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720) {
                val = tr32(TG3_LSO_RD_DMA_CRPTEN_CTRL);
                tw32(TG3_LSO_RD_DMA_CRPTEN_CTRL, val |
                     TG3_LSO_RD_DMA_CRPTEN_CTRL_BLEN_BD_4K |
@@ -8241,12 +8343,12 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        }
        /* Receive/send statistics. */
-        if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS) {
+        if (tg3_flag(tp, 5750_PLUS)) {
                val = tr32(RCVLPC_STATS_ENABLE);
                val &= ~RCVLPC_STATSENAB_DACK_FIX;
                tw32(RCVLPC_STATS_ENABLE, val);
        } else if ((rdmac_mode & RDMAC_MODE_FIFO_SIZE_128) &&
-                   (tp->tg3_flags2 & TG3_FLG2_TSO_CAPABLE)) {
+                   tg3_flag(tp, TSO_CAPABLE)) {
                val = tr32(RCVLPC_STATS_ENABLE);
                val &= ~RCVLPC_STATSENAB_LNGBRST_RFIX;
                tw32(RCVLPC_STATS_ENABLE, val);
@@ -8269,7 +8371,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        __tg3_set_coalesce(tp, &tp->coal);
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) {
+        if (!tg3_flag(tp, 5705_PLUS)) {
                /* Status/statistics block address.  See tg3_timer,
                 * the tg3_periodic_fetch_stats call there, and
                 * tg3_get_stats to see how this works for 5705/5750 chips.
@@ -8295,7 +8397,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        tw32(RCVCC_MODE, RCVCC_MODE_ENABLE | RCVCC_MODE_ATTN_ENABLE);
        tw32(RCVLPC_MODE, RCVLPC_MODE_ENABLE);
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+        if (!tg3_flag(tp, 5705_PLUS))
                tw32(RCVLSC_MODE, RCVLSC_MODE_ENABLE | RCVLSC_MODE_ATTN_ENABLE);
        if (tp->phy_flags & TG3_PHYFLG_MII_SERDES) {
@@ -8305,13 +8407,13 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                udelay(10);
        }
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)
+        if (tg3_flag(tp, ENABLE_APE))
                tp->mac_mode = MAC_MODE_APE_TX_EN | MAC_MODE_APE_RX_EN;
        else
                tp->mac_mode = 0;
        tp->mac_mode |= MAC_MODE_TXSTAT_ENABLE | MAC_MODE_RXSTAT_ENABLE |
                MAC_MODE_TDE_ENABLE | MAC_MODE_RDE_ENABLE | MAC_MODE_FHDE_ENABLE;
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS) &&
+        if (!tg3_flag(tp, 5705_PLUS) &&
            !(tp->phy_flags & TG3_PHYFLG_PHY_SERDES) &&
            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700)
                tp->mac_mode |= MAC_MODE_LINK_POLARITY;
@@ -8319,12 +8421,12 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        udelay(40);
        /* tp->grc_local_ctrl is partially set up during tg3_get_invariants().
-         * If TG3_FLG2_IS_NIC is zero, we should read the
+         * If TG3_FLAG_IS_NIC is zero, we should read the
         * register to preserve the GPIO settings for LOMs. The GPIOs,
         * whether used as inputs or outputs, are set by boot code after
         * reset.
         */
-        if (!(tp->tg3_flags2 & TG3_FLG2_IS_NIC)) {
+        if (!tg3_flag(tp, IS_NIC)) {
                u32 gpio_mask;
                gpio_mask = GRC_LCLCTRL_GPIO_OE0 | GRC_LCLCTRL_GPIO_OE1 |
@@ -8342,21 +8444,20 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                tp->grc_local_ctrl |= tr32(GRC_LOCAL_CTRL) & gpio_mask;
                /* GPIO1 must be driven high for eeprom write protect */
-                if (tp->tg3_flags & TG3_FLAG_EEPROM_WRITE_PROT)
+                if (tg3_flag(tp, EEPROM_WRITE_PROT))
                        tp->grc_local_ctrl |= (GRC_LCLCTRL_GPIO_OE1 |
                                               GRC_LCLCTRL_GPIO_OUTPUT1);
        }
        tw32_f(GRC_LOCAL_CTRL, tp->grc_local_ctrl);
        udelay(100);
-        if ((tp->tg3_flags2 & TG3_FLG2_USING_MSIX) &&
+        if (tg3_flag(tp, USING_MSIX) && tp->irq_cnt > 1) {
-                tp->irq_cnt > 1) {
                val = tr32(MSGINT_MODE);
                val |= MSGINT_MODE_MULTIVEC_EN | MSGINT_MODE_ENABLE;
                tw32(MSGINT_MODE, val);
        }
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) {
+        if (!tg3_flag(tp, 5705_PLUS)) {
                tw32_f(DMAC_MODE, DMAC_MODE_ENABLE);
                udelay(40);
        }
@@ -8369,18 +8470,18 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705 &&
            tp->pci_chip_rev_id != CHIPREV_ID_5705_A0) {
-                if ((tp->tg3_flags2 & TG3_FLG2_TSO_CAPABLE) &&
+                if (tg3_flag(tp, TSO_CAPABLE) &&
                    (tp->pci_chip_rev_id == CHIPREV_ID_5705_A1 ||
                     tp->pci_chip_rev_id == CHIPREV_ID_5705_A2)) {
                        /* nothing */
                } else if (!(tr32(TG3PCI_PCISTATE) & PCISTATE_BUS_SPEED_HIGH) &&
-                           !(tp->tg3_flags2 & TG3_FLG2_IS_5788)) {
+                           !tg3_flag(tp, IS_5788)) {
                        val |= WDMAC_MODE_RX_ACCEL;
                }
        }
        /* Enable host coalescing bug fix */
-        if (tp->tg3_flags3 & TG3_FLG3_5755_PLUS)
+        if (tg3_flag(tp, 5755_PLUS))
                val |= WDMAC_MODE_STATUS_TAG_FIX;
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785)
@@ -8389,7 +8490,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        tw32_f(WDMAC_MODE, val);
        udelay(40);
-        if (tp->tg3_flags & TG3_FLAG_PCIX_MODE) {
+        if (tg3_flag(tp, PCIX_MODE)) {
                u16 pcix_cmd;
                pci_read_config_word(tp->pdev, tp->pcix_cap + PCI_X_CMD,
@@ -8409,7 +8510,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        udelay(40);
        tw32(RCVDCC_MODE, RCVDCC_MODE_ENABLE | RCVDCC_MODE_ATTN_ENABLE);
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+        if (!tg3_flag(tp, 5705_PLUS))
                tw32(MBFREE_MODE, MBFREE_MODE_ENABLE);
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5761)
@@ -8421,15 +8522,16 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        tw32(SNDBDC_MODE, SNDBDC_MODE_ENABLE | SNDBDC_MODE_ATTN_ENABLE);
        tw32(RCVBDI_MODE, RCVBDI_MODE_ENABLE | RCVBDI_MODE_RCB_ATTN_ENAB);
        val = RCVDBDI_MODE_ENABLE | RCVDBDI_MODE_INV_RING_SZ;
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+        if (tg3_flag(tp, LRG_PROD_RING_CAP))
-            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)
                val |= RCVDBDI_MODE_LRG_RING_SZ;
        tw32(RCVDBDI_MODE, val);
        tw32(SNDDATAI_MODE, SNDDATAI_MODE_ENABLE);
-        if (tp->tg3_flags2 & TG3_FLG2_HW_TSO)
+        if (tg3_flag(tp, HW_TSO_1) ||
+            tg3_flag(tp, HW_TSO_2) ||
+            tg3_flag(tp, HW_TSO_3))
                tw32(SNDDATAI_MODE, SNDDATAI_MODE_ENABLE | 0x8);
        val = SNDBDI_MODE_ENABLE | SNDBDI_MODE_ATTN_ENABLE;
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS)
+        if (tg3_flag(tp, ENABLE_TSS))
                val |= SNDBDI_MODE_MULTI_TXQ_EN;
        tw32(SNDBDI_MODE, val);
        tw32(SNDBDS_MODE, SNDBDS_MODE_ENABLE | SNDBDS_MODE_ATTN_ENABLE);
@@ -8440,20 +8542,28 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                        return err;
        }
-        if (tp->tg3_flags2 & TG3_FLG2_TSO_CAPABLE) {
+        if (tg3_flag(tp, TSO_CAPABLE)) {
                err = tg3_load_tso_firmware(tp);
                if (err)
                        return err;
        }
        tp->tx_mode = TX_MODE_ENABLE;
-        if ((tp->tg3_flags3 & TG3_FLG3_5755_PLUS) ||
+        if (tg3_flag(tp, 5755_PLUS) ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906)
                tp->tx_mode |= TX_MODE_MBUF_LOCKUP_FIX;
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720) {
+                val = TX_MODE_JMB_FRM_LEN | TX_MODE_CNT_DN_MODE;
+                tp->tx_mode &= ~val;
+                tp->tx_mode |= tr32(MAC_TX_MODE) & val;
+        }
        tw32_f(MAC_TX_MODE, tp->tx_mode);
        udelay(100);
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_RSS) {
+        if (tg3_flag(tp, ENABLE_RSS)) {
                u32 reg = MAC_RSS_INDIR_TBL_0;
                u8 *ent = (u8 *)&val;
@@ -8482,10 +8592,10 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        }
        tp->rx_mode = RX_MODE_ENABLE;
-        if (tp->tg3_flags3 & TG3_FLG3_5755_PLUS)
+        if (tg3_flag(tp, 5755_PLUS))
                tp->rx_mode |= RX_MODE_IPV6_CSUM_ENABLE;
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_RSS)
+        if (tg3_flag(tp, ENABLE_RSS))
                tp->rx_mode |= RX_MODE_RSS_ENABLE |
                               RX_MODE_RSS_ITBL_HASH_BITS_7 |
                               RX_MODE_RSS_IPV6_HASH_EN |
@@ -8532,11 +8642,11 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704 &&
            (tp->phy_flags & TG3_PHYFLG_PHY_SERDES)) {
                /* Use hardware link auto-negotiation */
-                tp->tg3_flags2 |= TG3_FLG2_HW_AUTONEG;
+                tg3_flag_set(tp, HW_AUTONEG);
        }
        if ((tp->phy_flags & TG3_PHYFLG_MII_SERDES) &&
-            (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5714)) {
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5714) {
                u32 tmp;
                tmp = tr32(SERDES_RX_CTRL);
@@ -8546,7 +8656,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                tw32(GRC_LOCAL_CTRL, tp->grc_local_ctrl);
        }
-        if (!(tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB)) {
+        if (!tg3_flag(tp, USE_PHYLIB)) {
                if (tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER) {
                        tp->phy_flags &= ~TG3_PHYFLG_IS_LOW_POWER;
                        tp->link_config.speed = tp->link_config.orig_speed;
@@ -8579,12 +8689,11 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
        tw32(MAC_RCV_RULE_1,  0x86000004 & RCV_RULE_DISABLE_MASK);
        tw32(MAC_RCV_VALUE_1, 0xffffffff & RCV_RULE_DISABLE_MASK);
-        if ((tp->tg3_flags2 & TG3_FLG2_5705_PLUS) &&
+        if (tg3_flag(tp, 5705_PLUS) && !tg3_flag(tp, 5780_CLASS))
-            !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS))
                limit = 8;
        else
                limit = 16;
-        if (tp->tg3_flags & TG3_FLAG_ENABLE_ASF)
+        if (tg3_flag(tp, ENABLE_ASF))
                limit -= 4;
        switch (limit) {
        case 16:
@@ -8622,7 +8731,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
                break;
        }
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)
+        if (tg3_flag(tp, ENABLE_APE))
                /* Write our heartbeat update interval to APE. */
                tg3_ape_write32(tp, TG3_APE_HOST_HEARTBEAT_INT_MS,
                                APE_HOST_HEARTBEAT_INT_DISABLE);
@@ -8688,7 +8797,21 @@ static void tg3_periodic_fetch_stats(struct tg3 *tp)
        TG3_STAT_ADD32(&sp->rx_undersize_packets, MAC_RX_STATS_UNDERSIZE);
        TG3_STAT_ADD32(&sp->rxbds_empty, RCVLPC_NO_RCV_BD_CNT);
-        TG3_STAT_ADD32(&sp->rx_discards, RCVLPC_IN_DISCARDS_CNT);
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5717 &&
+            tp->pci_chip_rev_id != CHIPREV_ID_5719_A0 &&
+            tp->pci_chip_rev_id != CHIPREV_ID_5720_A0) {
+                TG3_STAT_ADD32(&sp->rx_discards, RCVLPC_IN_DISCARDS_CNT);
+        } else {
+                u32 val = tr32(HOSTCC_FLOW_ATTN);
+                val = (val & HOSTCC_FLOW_ATTN_MBUF_LWM) ? 1 : 0;
+                if (val) {
+                        tw32(HOSTCC_FLOW_ATTN, HOSTCC_FLOW_ATTN_MBUF_LWM);
+                        sp->rx_discards.low += val;
+                        if (sp->rx_discards.low < val)
+                                sp->rx_discards.high += 1;
+                }
+                sp->mbuf_lwm_thresh_hit = sp->rx_discards;
+        }
        TG3_STAT_ADD32(&sp->rx_errors, RCVLPC_IN_ERRORS_CNT);
 }
@@ -8701,7 +8824,7 @@ static void tg3_timer(unsigned long __opaque)
        spin_lock(&tp->lock);
-        if (!(tp->tg3_flags & TG3_FLAG_TAGGED_STATUS)) {
+        if (!tg3_flag(tp, TAGGED_STATUS)) {
                /* All of this garbage is because when using non-tagged
                 * IRQ status the mailbox/status_block protocol the chip
                 * uses with the cpu is race prone.
@@ -8715,7 +8838,7 @@ static void tg3_timer(unsigned long __opaque)
                }
                if (!(tr32(WDMAC_MODE) & WDMAC_MODE_ENABLE)) {
-                        tp->tg3_flags2 |= TG3_FLG2_RESTART_TIMER;
+                        tg3_flag_set(tp, RESTART_TIMER);
                        spin_unlock(&tp->lock);
                        schedule_work(&tp->reset_task);
                        return;
@@ -8724,16 +8847,13 @@ static void tg3_timer(unsigned long __opaque)
        /* This part only runs once per second. */
        if (!--tp->timer_counter) {
-                if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS)
+                if (tg3_flag(tp, 5705_PLUS))
                        tg3_periodic_fetch_stats(tp);
-                if (tp->setlpicnt && !--tp->setlpicnt) {
+                if (tp->setlpicnt && !--tp->setlpicnt)
-                        u32 val = tr32(TG3_CPMU_EEE_MODE);
+                        tg3_phy_eee_enable(tp);
-                        tw32(TG3_CPMU_EEE_MODE,
-                             val | TG3_CPMU_EEEMD_LPI_ENABLE);
-                }
-                if (tp->tg3_flags & TG3_FLAG_USE_LINKCHG_REG) {
+                if (tg3_flag(tp, USE_LINKCHG_REG)) {
                        u32 mac_stat;
                        int phy_event;
@@ -8748,7 +8868,7 @@ static void tg3_timer(unsigned long __opaque)
                        if (phy_event)
                                tg3_setup_phy(tp, 0);
-                } else if (tp->tg3_flags & TG3_FLAG_POLL_SERDES) {
+                } else if (tg3_flag(tp, POLL_SERDES)) {
                        u32 mac_stat = tr32(MAC_STATUS);
                        int need_setup = 0;
@@ -8773,7 +8893,7 @@ static void tg3_timer(unsigned long __opaque)
                                tg3_setup_phy(tp, 0);
                        }
                } else if ((tp->phy_flags & TG3_PHYFLG_MII_SERDES) &&
-                           (tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) {
+                           tg3_flag(tp, 5780_CLASS)) {
                        tg3_serdes_parallel_detect(tp);
                }
@@ -8798,8 +8918,7 @@ static void tg3_timer(unsigned long __opaque)
         * resets.
         */
        if (!--tp->asf_counter) {
-                if ((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) &&
+                if (tg3_flag(tp, ENABLE_ASF) && !tg3_flag(tp, ENABLE_APE)) {
-                    !(tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)) {
                        tg3_wait_for_event_ack(tp);
                        tg3_write_mem(tp, NIC_SRAM_FW_CMD_MBOX,
@@ -8835,16 +8954,16 @@ static int tg3_request_irq(struct tg3 *tp, int irq_num)
                name[IFNAMSIZ-1] = 0;
        }
-        if (tp->tg3_flags2 & TG3_FLG2_USING_MSI_OR_MSIX) {
+        if (tg3_flag(tp, USING_MSI) || tg3_flag(tp, USING_MSIX)) {
                fn = tg3_msi;
-                if (tp->tg3_flags2 & TG3_FLG2_1SHOT_MSI)
+                if (tg3_flag(tp, 1SHOT_MSI))
                        fn = tg3_msi_1shot;
-                flags = IRQF_SAMPLE_RANDOM;
+                flags = 0;
        } else {
                fn = tg3_interrupt;
-                if (tp->tg3_flags & TG3_FLAG_TAGGED_STATUS)
+                if (tg3_flag(tp, TAGGED_STATUS))
                        fn = tg3_interrupt_tagged;
-                flags = IRQF_SHARED | IRQF_SAMPLE_RANDOM;
+                flags = IRQF_SHARED;
        }
        return request_irq(tnapi->irq_vec, fn, flags, name, tnapi);
@@ -8868,8 +8987,7 @@ static int tg3_test_interrupt(struct tg3 *tp)
         * Turn off MSI one shot mode.  Otherwise this test has no
         * observable way to know whether the interrupt was delivered.
         */
-        if ((tp->tg3_flags3 & TG3_FLG3_5717_PLUS) &&
+        if (tg3_flag(tp, 57765_PLUS) && tg3_flag(tp, USING_MSI)) {
-            (tp->tg3_flags2 & TG3_FLG2_USING_MSI)) {
                val = tr32(MSGINT_MODE) | MSGINT_MODE_ONE_SHOT_DISABLE;
                tw32(MSGINT_MODE, val);
        }
@@ -8911,8 +9029,7 @@ static int tg3_test_interrupt(struct tg3 *tp)
        if (intr_ok) {
                /* Reenable MSI one shot mode. */
-                if ((tp->tg3_flags3 & TG3_FLG3_5717_PLUS) &&
+                if (tg3_flag(tp, 57765_PLUS) && tg3_flag(tp, USING_MSI)) {
-                    (tp->tg3_flags2 & TG3_FLG2_USING_MSI)) {
                        val = tr32(MSGINT_MODE) & ~MSGINT_MODE_ONE_SHOT_DISABLE;
                        tw32(MSGINT_MODE, val);
                }
@@ -8930,7 +9047,7 @@ static int tg3_test_msi(struct tg3 *tp)
        int err;
        u16 pci_cmd;
-        if (!(tp->tg3_flags2 & TG3_FLG2_USING_MSI))
+        if (!tg3_flag(tp, USING_MSI))
                return 0;
        /* Turn off SERR reporting in case MSI terminates with Master
@@ -8960,7 +9077,7 @@ static int tg3_test_msi(struct tg3 *tp)
        pci_disable_msi(tp->pdev);
-        tp->tg3_flags2 &= ~TG3_FLG2_USING_MSI;
+        tg3_flag_clear(tp, USING_MSI);
        tp->napi[0].irq_vec = tp->pdev->irq;
        err = tg3_request_irq(tp, 0);
@@ -9057,9 +9174,11 @@ static bool tg3_enable_msix(struct tg3 *tp)
        }
        if (tp->irq_cnt > 1) {
-                tp->tg3_flags3 |= TG3_FLG3_ENABLE_RSS;
+                tg3_flag_set(tp, ENABLE_RSS);
-                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) {
-                        tp->tg3_flags3 |= TG3_FLG3_ENABLE_TSS;
+                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719 ||
+                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720) {
+                        tg3_flag_set(tp, ENABLE_TSS);
                        netif_set_real_num_tx_queues(tp->dev, tp->irq_cnt - 1);
                }
        }
@@ -9069,8 +9188,8 @@ static bool tg3_enable_msix(struct tg3 *tp)
 static void tg3_ints_init(struct tg3 *tp)
 {
-        if ((tp->tg3_flags & TG3_FLAG_SUPPORT_MSI_OR_MSIX) &&
+        if ((tg3_flag(tp, SUPPORT_MSI) || tg3_flag(tp, SUPPORT_MSIX)) &&
-            !(tp->tg3_flags & TG3_FLAG_TAGGED_STATUS)) {
+            !tg3_flag(tp, TAGGED_STATUS)) {
                /* All MSI supporting chips should support tagged
                 * status.  Assert that this is the case.
                 */
@@ -9079,21 +9198,19 @@ static void tg3_ints_init(struct tg3 *tp)
                goto defcfg;
        }
-        if ((tp->tg3_flags & TG3_FLAG_SUPPORT_MSIX) && tg3_enable_msix(tp))
+        if (tg3_flag(tp, SUPPORT_MSIX) && tg3_enable_msix(tp))
-                tp->tg3_flags2 |= TG3_FLG2_USING_MSIX;
+                tg3_flag_set(tp, USING_MSIX);
-        else if ((tp->tg3_flags & TG3_FLAG_SUPPORT_MSI) &&
+        else if (tg3_flag(tp, SUPPORT_MSI) && pci_enable_msi(tp->pdev) == 0)
-                 pci_enable_msi(tp->pdev) == 0)
+                tg3_flag_set(tp, USING_MSI);
-                tp->tg3_flags2 |= TG3_FLG2_USING_MSI;
-        if (tp->tg3_flags2 & TG3_FLG2_USING_MSI_OR_MSIX) {
+        if (tg3_flag(tp, USING_MSI) || tg3_flag(tp, USING_MSIX)) {
                u32 msi_mode = tr32(MSGINT_MODE);
-                if ((tp->tg3_flags2 & TG3_FLG2_USING_MSIX) &&
+                if (tg3_flag(tp, USING_MSIX) && tp->irq_cnt > 1)
-                    tp->irq_cnt > 1)
                        msi_mode |= MSGINT_MODE_MULTIVEC_EN;
                tw32(MSGINT_MODE, msi_mode | MSGINT_MODE_ENABLE);
        }
 defcfg:
-        if (!(tp->tg3_flags2 & TG3_FLG2_USING_MSIX)) {
+        if (!tg3_flag(tp, USING_MSIX)) {
                tp->irq_cnt = 1;
                tp->napi[0].irq_vec = tp->pdev->irq;
                netif_set_real_num_tx_queues(tp->dev, 1);
@@ -9103,12 +9220,14 @@ defcfg:
 static void tg3_ints_fini(struct tg3 *tp)
 {
-        if (tp->tg3_flags2 & TG3_FLG2_USING_MSIX)
+        if (tg3_flag(tp, USING_MSIX))
                pci_disable_msix(tp->pdev);
-        else if (tp->tg3_flags2 & TG3_FLG2_USING_MSI)
+        else if (tg3_flag(tp, USING_MSI))
                pci_disable_msi(tp->pdev);
-        tp->tg3_flags2 &= ~TG3_FLG2_USING_MSI_OR_MSIX;
+        tg3_flag_clear(tp, USING_MSI);
-        tp->tg3_flags3 &= ~(TG3_FLG3_ENABLE_RSS | TG3_FLG3_ENABLE_TSS);
+        tg3_flag_clear(tp, USING_MSIX);
+        tg3_flag_clear(tp, ENABLE_RSS);
+        tg3_flag_clear(tp, ENABLE_TSS);
 }
 static int tg3_open(struct net_device *dev)
@@ -9123,10 +9242,10 @@ static int tg3_open(struct net_device *dev)
                                return err;
                } else if (err) {
                        netdev_warn(tp->dev, "TSO capability disabled\n");
-                        tp->tg3_flags2 &= ~TG3_FLG2_TSO_CAPABLE;
+                        tg3_flag_clear(tp, TSO_CAPABLE);
-                } else if (!(tp->tg3_flags2 & TG3_FLG2_TSO_CAPABLE)) {
+                } else if (!tg3_flag(tp, TSO_CAPABLE)) {
                        netdev_notice(tp->dev, "TSO capability restored\n");
-                        tp->tg3_flags2 |= TG3_FLG2_TSO_CAPABLE;
+                        tg3_flag_set(tp, TSO_CAPABLE);
                }
        }
@@ -9139,7 +9258,7 @@ static int tg3_open(struct net_device *dev)
        tg3_full_lock(tp, 0);
        tg3_disable_ints(tp);
-        tp->tg3_flags &= ~TG3_FLAG_INIT_COMPLETE;
+        tg3_flag_clear(tp, INIT_COMPLETE);
        tg3_full_unlock(tp);
@@ -9180,7 +9299,7 @@ static int tg3_open(struct net_device *dev)
                tg3_halt(tp, RESET_KIND_SHUTDOWN, 1);
                tg3_free_rings(tp);
        } else {
-                if (tp->tg3_flags & TG3_FLAG_TAGGED_STATUS)
+                if (tg3_flag(tp, TAGGED_STATUS))
                        tp->timer_offset = HZ;
                else
                        tp->timer_offset = HZ / 10;
@@ -9202,7 +9321,7 @@ static int tg3_open(struct net_device *dev)
        if (err)
                goto err_out3;
-        if (tp->tg3_flags2 & TG3_FLG2_USING_MSI) {
+        if (tg3_flag(tp, USING_MSI)) {
                err = tg3_test_msi(tp);
                if (err) {
@@ -9214,8 +9333,7 @@ static int tg3_open(struct net_device *dev)
                        goto err_out2;
                }
-                if (!(tp->tg3_flags3 & TG3_FLG3_5717_PLUS) &&
+                if (!tg3_flag(tp, 57765_PLUS) && tg3_flag(tp, USING_MSI)) {
-                    (tp->tg3_flags2 & TG3_FLG2_USING_MSI)) {
                        u32 val = tr32(PCIE_TRANSACTION_CFG);
                        tw32(PCIE_TRANSACTION_CFG,
@@ -9228,13 +9346,20 @@ static int tg3_open(struct net_device *dev)
        tg3_full_lock(tp, 0);
        add_timer(&tp->timer);
-        tp->tg3_flags |= TG3_FLAG_INIT_COMPLETE;
+        tg3_flag_set(tp, INIT_COMPLETE);
        tg3_enable_ints(tp);
        tg3_full_unlock(tp);
        netif_tx_start_all_queues(dev);
+        /*
+         * Reset loopback feature if it was turned on while the device was down
+         * make sure that it's installed properly now.
+         */
+        if (dev->features & NETIF_F_LOOPBACK)
+                tg3_set_loopback(dev, dev->features);
        return 0;
 err_out3:
@@ -9277,7 +9402,7 @@ static int tg3_close(struct net_device *dev)
        tg3_halt(tp, RESET_KIND_SHUTDOWN, 1);
        tg3_free_rings(tp);
-        tp->tg3_flags &= ~TG3_FLAG_INIT_COMPLETE;
+        tg3_flag_clear(tp, INIT_COMPLETE);
        tg3_full_unlock(tp);
@@ -9424,6 +9549,8 @@ static struct tg3_ethtool_stats *tg3_get_estats(struct tg3 *tp)
        ESTAT_ADD(nic_avoided_irqs);
        ESTAT_ADD(nic_tx_threshold_hit);
+        ESTAT_ADD(mbuf_lwm_thresh_hit);
        return estats;
 }
@@ -9534,7 +9661,7 @@ static void __tg3_set_rx_mode(struct net_device *dev)
        /* When ASF is in use, we always keep the RX_MODE_KEEP_VLAN_TAG
         * flag clear.
         */
-        if (!(tp->tg3_flags & TG3_FLAG_ENABLE_ASF))
+        if (!tg3_flag(tp, ENABLE_ASF))
                rx_mode |= RX_MODE_KEEP_VLAN_TAG;
 #endif
@@ -9588,82 +9715,26 @@ static void tg3_set_rx_mode(struct net_device *dev)
        tg3_full_unlock(tp);
 }
-#define TG3_REGDUMP_LEN         (32 * 1024)
 static int tg3_get_regs_len(struct net_device *dev)
 {
-        return TG3_REGDUMP_LEN;
+        return TG3_REG_BLK_SIZE;
 }
 static void tg3_get_regs(struct net_device *dev,
                struct ethtool_regs *regs, void *_p)
 {
-        u32 *p = _p;
        struct tg3 *tp = netdev_priv(dev);
-        u8 *orig_p = _p;
-        int i;
        regs->version = 0;
-        memset(p, 0, TG3_REGDUMP_LEN);
+        memset(_p, 0, TG3_REG_BLK_SIZE);
        if (tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER)
                return;
        tg3_full_lock(tp, 0);
-#define __GET_REG32(reg)        (*(p)++ = tr32(reg))
+        tg3_dump_legacy_regs(tp, (u32 *)_p);
-#define GET_REG32_LOOP(base, len)               \
-do {    p = (u32 *)(orig_p + (base));           \
-        for (i = 0; i < len; i += 4)            \
-                __GET_REG32((base) + i);        \
-} while (0)
-#define GET_REG32_1(reg)                        \
-do {    p = (u32 *)(orig_p + (reg));            \
-        __GET_REG32((reg));                     \
-} while (0)
-        GET_REG32_LOOP(TG3PCI_VENDOR, 0xb0);
-        GET_REG32_LOOP(MAILBOX_INTERRUPT_0, 0x200);
-        GET_REG32_LOOP(MAC_MODE, 0x4f0);
-        GET_REG32_LOOP(SNDDATAI_MODE, 0xe0);
-        GET_REG32_1(SNDDATAC_MODE);
-        GET_REG32_LOOP(SNDBDS_MODE, 0x80);
-        GET_REG32_LOOP(SNDBDI_MODE, 0x48);
-        GET_REG32_1(SNDBDC_MODE);
-        GET_REG32_LOOP(RCVLPC_MODE, 0x20);
-        GET_REG32_LOOP(RCVLPC_SELLST_BASE, 0x15c);
-        GET_REG32_LOOP(RCVDBDI_MODE, 0x0c);
-        GET_REG32_LOOP(RCVDBDI_JUMBO_BD, 0x3c);
-        GET_REG32_LOOP(RCVDBDI_BD_PROD_IDX_0, 0x44);
-        GET_REG32_1(RCVDCC_MODE);
-        GET_REG32_LOOP(RCVBDI_MODE, 0x20);
-        GET_REG32_LOOP(RCVCC_MODE, 0x14);
-        GET_REG32_LOOP(RCVLSC_MODE, 0x08);
-        GET_REG32_1(MBFREE_MODE);
-        GET_REG32_LOOP(HOSTCC_MODE, 0x100);
-        GET_REG32_LOOP(MEMARB_MODE, 0x10);
-        GET_REG32_LOOP(BUFMGR_MODE, 0x58);
-        GET_REG32_LOOP(RDMAC_MODE, 0x08);
-        GET_REG32_LOOP(WDMAC_MODE, 0x08);
-        GET_REG32_1(RX_CPU_MODE);
-        GET_REG32_1(RX_CPU_STATE);
-        GET_REG32_1(RX_CPU_PGMCTR);
-        GET_REG32_1(RX_CPU_HWBKPT);
-        GET_REG32_1(TX_CPU_MODE);
-        GET_REG32_1(TX_CPU_STATE);
-        GET_REG32_1(TX_CPU_PGMCTR);
-        GET_REG32_LOOP(GRCMBOX_INTERRUPT_0, 0x110);
-        GET_REG32_LOOP(FTQ_RESET, 0x120);
-        GET_REG32_LOOP(MSGINT_MODE, 0x0c);
-        GET_REG32_1(DMAC_MODE);
-        GET_REG32_LOOP(GRC_MODE, 0x4c);
-        if (tp->tg3_flags & TG3_FLAG_NVRAM)
-                GET_REG32_LOOP(NVRAM_CMD, 0x24);
-#undef __GET_REG32
-#undef GET_REG32_LOOP
-#undef GET_REG32_1
        tg3_full_unlock(tp);
 }
@@ -9683,7 +9754,7 @@ static int tg3_get_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom,
        u32 i, offset, len, b_offset, b_count;
        __be32 val;
-        if (tp->tg3_flags3 & TG3_FLG3_NO_NVRAM)
+        if (tg3_flag(tp, NO_NVRAM))
                return -EINVAL;
        if (tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER)
@@ -9751,7 +9822,7 @@ static int tg3_set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom,
        if (tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER)
                return -EAGAIN;
-        if ((tp->tg3_flags3 & TG3_FLG3_NO_NVRAM) ||
+        if (tg3_flag(tp, NO_NVRAM) ||
            eeprom->magic != TG3_EEPROM_MAGIC)
                return -EINVAL;
@@ -9803,7 +9874,7 @@ static int tg3_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        struct tg3 *tp = netdev_priv(dev);
-        if (tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB) {
+        if (tg3_flag(tp, USE_PHYLIB)) {
                struct phy_device *phydev;
                if (!(tp->phy_flags & TG3_PHYFLG_IS_CONNECTED))
                        return -EAGAIN;
@@ -9831,10 +9902,10 @@ static int tg3_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        cmd->advertising = tp->link_config.advertising;
        if (netif_running(dev)) {
-                cmd->speed = tp->link_config.active_speed;
+                ethtool_cmd_speed_set(cmd, tp->link_config.active_speed);
                cmd->duplex = tp->link_config.active_duplex;
        } else {
-                cmd->speed = SPEED_INVALID;
+                ethtool_cmd_speed_set(cmd, SPEED_INVALID);
                cmd->duplex = DUPLEX_INVALID;
        }
        cmd->phy_address = tp->phy_addr;
@@ -9848,8 +9919,9 @@ static int tg3_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 static int tg3_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        struct tg3 *tp = netdev_priv(dev);
+        u32 speed = ethtool_cmd_speed(cmd);
-        if (tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB) {
+        if (tg3_flag(tp, USE_PHYLIB)) {
                struct phy_device *phydev;
                if (!(tp->phy_flags & TG3_PHYFLG_IS_CONNECTED))
                        return -EAGAIN;
@@ -9897,14 +9969,14 @@ static int tg3_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                cmd->advertising &= mask;
        } else {
                if (tp->phy_flags & TG3_PHYFLG_ANY_SERDES) {
-                        if (cmd->speed != SPEED_1000)
+                        if (speed != SPEED_1000)
                                return -EINVAL;
                        if (cmd->duplex != DUPLEX_FULL)
                                return -EINVAL;
                } else {
-                        if (cmd->speed != SPEED_100 &&
+                        if (speed != SPEED_100 &&
-                            cmd->speed != SPEED_10)
+                            speed != SPEED_10)
                                return -EINVAL;
                }
        }
@@ -9919,7 +9991,7 @@ static int tg3_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                tp->link_config.duplex = DUPLEX_INVALID;
        } else {
                tp->link_config.advertising = 0;
-                tp->link_config.speed = cmd->speed;
+                tp->link_config.speed = speed;
                tp->link_config.duplex = cmd->duplex;
        }
@@ -9949,14 +10021,12 @@ static void tg3_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
 {
        struct tg3 *tp = netdev_priv(dev);
-        if ((tp->tg3_flags & TG3_FLAG_WOL_CAP) &&
+        if (tg3_flag(tp, WOL_CAP) && device_can_wakeup(&tp->pdev->dev))
-            device_can_wakeup(&tp->pdev->dev))
                wol->supported = WAKE_MAGIC;
        else
                wol->supported = 0;
        wol->wolopts = 0;
-        if ((tp->tg3_flags & TG3_FLAG_WOL_ENABLE) &&
+        if (tg3_flag(tp, WOL_ENABLE) && device_can_wakeup(&tp->pdev->dev))
-            device_can_wakeup(&tp->pdev->dev))
                wol->wolopts = WAKE_MAGIC;
        memset(&wol->sopass, 0, sizeof(wol->sopass));
 }
@@ -9969,19 +10039,18 @@ static int tg3_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
        if (wol->wolopts & ~WAKE_MAGIC)
                return -EINVAL;
        if ((wol->wolopts & WAKE_MAGIC) &&
-            !((tp->tg3_flags & TG3_FLAG_WOL_CAP) && device_can_wakeup(dp)))
+            !(tg3_flag(tp, WOL_CAP) && device_can_wakeup(dp)))
                return -EINVAL;
        device_set_wakeup_enable(dp, wol->wolopts & WAKE_MAGIC);
        spin_lock_bh(&tp->lock);
        if (device_may_wakeup(dp))
-                tp->tg3_flags |= TG3_FLAG_WOL_ENABLE;
+                tg3_flag_set(tp, WOL_ENABLE);
        else
-                tp->tg3_flags &= ~TG3_FLAG_WOL_ENABLE;
+                tg3_flag_clear(tp, WOL_ENABLE);
        spin_unlock_bh(&tp->lock);
        return 0;
 }
@@ -9997,33 +10066,6 @@ static void tg3_set_msglevel(struct net_device *dev, u32 value)
        tp->msg_enable = value;
 }
-static int tg3_set_tso(struct net_device *dev, u32 value)
-{
-        struct tg3 *tp = netdev_priv(dev);
-        if (!(tp->tg3_flags2 & TG3_FLG2_TSO_CAPABLE)) {
-                if (value)
-                        return -EINVAL;
-                return 0;
-        }
-        if ((dev->features & NETIF_F_IPV6_CSUM) &&
-            ((tp->tg3_flags2 & TG3_FLG2_HW_TSO_2) ||
-             (tp->tg3_flags2 & TG3_FLG2_HW_TSO_3))) {
-                if (value) {
-                        dev->features |= NETIF_F_TSO6;
-                        if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO_3) ||
-                            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5761 ||
-                            (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5784 &&
-                             GET_CHIP_REV(tp->pci_chip_rev_id) != CHIPREV_5784_AX) ||
-                            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785 ||
-                            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780)
-                                dev->features |= NETIF_F_TSO_ECN;
-                } else
-                        dev->features &= ~(NETIF_F_TSO6 | NETIF_F_TSO_ECN);
-        }
-        return ethtool_op_set_tso(dev, value);
-}
 static int tg3_nway_reset(struct net_device *dev)
 {
        struct tg3 *tp = netdev_priv(dev);
@@ -10035,7 +10077,7 @@ static int tg3_nway_reset(struct net_device *dev)
        if (tp->phy_flags & TG3_PHYFLG_PHY_SERDES)
                return -EINVAL;
-        if (tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB) {
+        if (tg3_flag(tp, USE_PHYLIB)) {
                if (!(tp->phy_flags & TG3_PHYFLG_IS_CONNECTED))
                        return -EAGAIN;
                r = phy_start_aneg(tp->mdio_bus->phy_map[TG3_PHY_MII_ADDR]);
@@ -10064,7 +10106,7 @@ static void tg3_get_ringparam(struct net_device *dev, struct ethtool_ringparam *
        ering->rx_max_pending = tp->rx_std_ring_mask;
        ering->rx_mini_max_pending = 0;
-        if (tp->tg3_flags & TG3_FLAG_JUMBO_RING_ENABLE)
+        if (tg3_flag(tp, JUMBO_RING_ENABLE))
                ering->rx_jumbo_max_pending = tp->rx_jmb_ring_mask;
        else
                ering->rx_jumbo_max_pending = 0;
@@ -10073,7 +10115,7 @@ static void tg3_get_ringparam(struct net_device *dev, struct ethtool_ringparam *
        ering->rx_pending = tp->rx_pending;
        ering->rx_mini_pending = 0;
-        if (tp->tg3_flags & TG3_FLAG_JUMBO_RING_ENABLE)
+        if (tg3_flag(tp, JUMBO_RING_ENABLE))
                ering->rx_jumbo_pending = tp->rx_jumbo_pending;
        else
                ering->rx_jumbo_pending = 0;
@@ -10090,7 +10132,7 @@ static int tg3_set_ringparam(struct net_device *dev, struct ethtool_ringparam *e
            (ering->rx_jumbo_pending > tp->rx_jmb_ring_mask) ||
            (ering->tx_pending > TG3_TX_RING_SIZE - 1) ||
            (ering->tx_pending <= MAX_SKB_FRAGS) ||
-            ((tp->tg3_flags2 & TG3_FLG2_TSO_BUG) &&
+            (tg3_flag(tp, TSO_BUG) &&
             (ering->tx_pending <= (MAX_SKB_FRAGS * 3))))
                return -EINVAL;
@@ -10104,7 +10146,7 @@ static int tg3_set_ringparam(struct net_device *dev, struct ethtool_ringparam *e
        tp->rx_pending = ering->rx_pending;
-        if ((tp->tg3_flags2 & TG3_FLG2_MAX_RXPEND_64) &&
+        if (tg3_flag(tp, MAX_RXPEND_64) &&
            tp->rx_pending > 63)
                tp->rx_pending = 63;
        tp->rx_jumbo_pending = ering->rx_jumbo_pending;
@@ -10131,7 +10173,7 @@ static void tg3_get_pauseparam(struct net_device *dev, struct ethtool_pauseparam
 {
        struct tg3 *tp = netdev_priv(dev);
-        epause->autoneg = (tp->tg3_flags & TG3_FLAG_PAUSE_AUTONEG) != 0;
+        epause->autoneg = !!tg3_flag(tp, PAUSE_AUTONEG);
        if (tp->link_config.active_flowctrl & FLOW_CTRL_RX)
                epause->rx_pause = 1;
@@ -10149,7 +10191,7 @@ static int tg3_set_pauseparam(struct net_device *dev, struct ethtool_pauseparam
        struct tg3 *tp = netdev_priv(dev);
        int err = 0;
-        if (tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB) {
+        if (tg3_flag(tp, USE_PHYLIB)) {
                u32 newadv;
                struct phy_device *phydev;
@@ -10177,9 +10219,9 @@ static int tg3_set_pauseparam(struct net_device *dev, struct ethtool_pauseparam
                        newadv = 0;
                if (epause->autoneg)
-                        tp->tg3_flags |= TG3_FLAG_PAUSE_AUTONEG;
+                        tg3_flag_set(tp, PAUSE_AUTONEG);
                else
-                        tp->tg3_flags &= ~TG3_FLAG_PAUSE_AUTONEG;
+                        tg3_flag_clear(tp, PAUSE_AUTONEG);
                if (tp->phy_flags & TG3_PHYFLG_IS_CONNECTED) {
                        u32 oldadv = phydev->advertising &
@@ -10221,9 +10263,9 @@ static int tg3_set_pauseparam(struct net_device *dev, struct ethtool_pauseparam
                tg3_full_lock(tp, irq_sync);
                if (epause->autoneg)
-                        tp->tg3_flags |= TG3_FLAG_PAUSE_AUTONEG;
+                        tg3_flag_set(tp, PAUSE_AUTONEG);
                else
-                        tp->tg3_flags &= ~TG3_FLAG_PAUSE_AUTONEG;
+                        tg3_flag_clear(tp, PAUSE_AUTONEG);
                if (epause->rx_pause)
                        tp->link_config.flowctrl |= FLOW_CTRL_RX;
                else
@@ -10246,50 +10288,6 @@ static int tg3_set_pauseparam(struct net_device *dev, struct ethtool_pauseparam
        return err;
 }
-static u32 tg3_get_rx_csum(struct net_device *dev)
-{
-        struct tg3 *tp = netdev_priv(dev);
-        return (tp->tg3_flags & TG3_FLAG_RX_CHECKSUMS) != 0;
-}
-static int tg3_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct tg3 *tp = netdev_priv(dev);
-        if (tp->tg3_flags & TG3_FLAG_BROKEN_CHECKSUMS) {
-                if (data != 0)
-                        return -EINVAL;
-                return 0;
-        }
-        spin_lock_bh(&tp->lock);
-        if (data)
-                tp->tg3_flags |= TG3_FLAG_RX_CHECKSUMS;
-        else
-                tp->tg3_flags &= ~TG3_FLAG_RX_CHECKSUMS;
-        spin_unlock_bh(&tp->lock);
-        return 0;
-}
-static int tg3_set_tx_csum(struct net_device *dev, u32 data)
-{
-        struct tg3 *tp = netdev_priv(dev);
-        if (tp->tg3_flags & TG3_FLAG_BROKEN_CHECKSUMS) {
-                if (data != 0)
-                        return -EINVAL;
-                return 0;
-        }
-        if (tp->tg3_flags3 & TG3_FLG3_5755_PLUS)
-                ethtool_op_set_tx_ipv6_csum(dev, data);
-        else
-                ethtool_op_set_tx_csum(dev, data);
-        return 0;
-}
 static int tg3_get_sset_count(struct net_device *dev, int sset)
 {
        switch (sset) {
@@ -10317,35 +10315,38 @@ static void tg3_get_strings(struct net_device *dev, u32 stringset, u8 *buf)
        }
 }
-static int tg3_phys_id(struct net_device *dev, u32 data)
+static int tg3_set_phys_id(struct net_device *dev,
+                            enum ethtool_phys_id_state state)
 {
        struct tg3 *tp = netdev_priv(dev);
-        int i;
        if (!netif_running(tp->dev))
                return -EAGAIN;
-        if (data == 0)
+        switch (state) {
-                data = UINT_MAX / 2;
+        case ETHTOOL_ID_ACTIVE:
+                return 1;       /* cycle on/off once per second */
-        for (i = 0; i < (data * 2); i++) {
-                if ((i % 2) == 0)
+        case ETHTOOL_ID_ON:
-                        tw32(MAC_LED_CTRL, LED_CTRL_LNKLED_OVERRIDE |
+                tw32(MAC_LED_CTRL, LED_CTRL_LNKLED_OVERRIDE |
-                                           LED_CTRL_1000MBPS_ON |
+                     LED_CTRL_1000MBPS_ON |
-                                           LED_CTRL_100MBPS_ON |
+                     LED_CTRL_100MBPS_ON |
-                                           LED_CTRL_10MBPS_ON |
+                     LED_CTRL_10MBPS_ON |
-                                           LED_CTRL_TRAFFIC_OVERRIDE |
+                     LED_CTRL_TRAFFIC_OVERRIDE |
-                                           LED_CTRL_TRAFFIC_BLINK |
+                     LED_CTRL_TRAFFIC_BLINK |
-                                           LED_CTRL_TRAFFIC_LED);
+                     LED_CTRL_TRAFFIC_LED);
+                break;
-                else
+        case ETHTOOL_ID_OFF:
-                        tw32(MAC_LED_CTRL, LED_CTRL_LNKLED_OVERRIDE |
+                tw32(MAC_LED_CTRL, LED_CTRL_LNKLED_OVERRIDE |
-                                           LED_CTRL_TRAFFIC_OVERRIDE);
+                     LED_CTRL_TRAFFIC_OVERRIDE);
+                break;
-                if (msleep_interruptible(500))
+        case ETHTOOL_ID_INACTIVE:
-                        break;
+                tw32(MAC_LED_CTRL, tp->led_ctrl);
+                break;
        }
-        tw32(MAC_LED_CTRL, tp->led_ctrl);
        return 0;
 }
@@ -10356,6 +10357,80 @@ static void tg3_get_ethtool_stats(struct net_device *dev,
        memcpy(tmp_stats, tg3_get_estats(tp), sizeof(tp->estats));
 }
+static __be32 * tg3_vpd_readblock(struct tg3 *tp)
+{
+        int i;
+        __be32 *buf;
+        u32 offset = 0, len = 0;
+        u32 magic, val;
+        if (tg3_flag(tp, NO_NVRAM) || tg3_nvram_read(tp, 0, &magic))
+                return NULL;
+        if (magic == TG3_EEPROM_MAGIC) {
+                for (offset = TG3_NVM_DIR_START;
+                     offset < TG3_NVM_DIR_END;
+                     offset += TG3_NVM_DIRENT_SIZE) {
+                        if (tg3_nvram_read(tp, offset, &val))
+                                return NULL;
+                        if ((val >> TG3_NVM_DIRTYPE_SHIFT) ==
+                            TG3_NVM_DIRTYPE_EXTVPD)
+                                break;
+                }
+                if (offset != TG3_NVM_DIR_END) {
+                        len = (val & TG3_NVM_DIRTYPE_LENMSK) * 4;
+                        if (tg3_nvram_read(tp, offset + 4, &offset))
+                                return NULL;
+                        offset = tg3_nvram_logical_addr(tp, offset);
+                }
+        }
+        if (!offset || !len) {
+                offset = TG3_NVM_VPD_OFF;
+                len = TG3_NVM_VPD_LEN;
+        }
+        buf = kmalloc(len, GFP_KERNEL);
+        if (buf == NULL)
+                return NULL;
+        if (magic == TG3_EEPROM_MAGIC) {
+                for (i = 0; i < len; i += 4) {
+                        /* The data is in little-endian format in NVRAM.
+                         * Use the big-endian read routines to preserve
+                         * the byte order as it exists in NVRAM.
+                         */
+                        if (tg3_nvram_read_be32(tp, offset + i, &buf[i/4]))
+                                goto error;
+                }
+        } else {
+                u8 *ptr;
+                ssize_t cnt;
+                unsigned int pos = 0;
+                ptr = (u8 *)&buf[0];
+                for (i = 0; pos < len && i < 3; i++, pos += cnt, ptr += cnt) {
+                        cnt = pci_read_vpd(tp->pdev, pos,
+                                           len - pos, ptr);
+                        if (cnt == -ETIMEDOUT || cnt == -EINTR)
+                                cnt = 0;
+                        else if (cnt < 0)
+                                goto error;
+                }
+                if (pos != len)
+                        goto error;
+        }
+        return buf;
+error:
+        kfree(buf);
+        return NULL;
+}
 #define NVRAM_TEST_SIZE 0x100
 #define NVRAM_SELFBOOT_FORMAT1_0_SIZE   0x14
 #define NVRAM_SELFBOOT_FORMAT1_2_SIZE   0x18
@@ -10369,7 +10444,7 @@ static int tg3_test_nvram(struct tg3 *tp)
        __be32 *buf;
        int i, j, k, err = 0, size;
-        if (tp->tg3_flags3 & TG3_FLG3_NO_NVRAM)
+        if (tg3_flag(tp, NO_NVRAM))
                return 0;
        if (tg3_nvram_read(tp, 0, &magic) != 0)
@@ -10495,14 +10570,11 @@ static int tg3_test_nvram(struct tg3 *tp)
        if (csum != le32_to_cpu(buf[0xfc/4]))
                goto out;
-        for (i = 0; i < TG3_NVM_VPD_LEN; i += 4) {
+        kfree(buf);
-                /* The data is in little-endian format in NVRAM.
-                 * Use the big-endian read routines to preserve
+        buf = tg3_vpd_readblock(tp);
-                 * the byte order as it exists in NVRAM.
+        if (!buf)
-                 */
+                return -ENOMEM;
-                if (tg3_nvram_read_be32(tp, TG3_NVM_VPD_OFF + i, &buf[i/4]))
-                        goto out;
-        }
        i = pci_vpd_find_tag((u8 *)buf, 0, TG3_NVM_VPD_LEN,
                             PCI_VPD_LRDT_RO_DATA);
@@ -10714,9 +10786,9 @@ static int tg3_test_registers(struct tg3 *tp)
        };
        is_5705 = is_5750 = 0;
-        if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS) {
+        if (tg3_flag(tp, 5705_PLUS)) {
                is_5705 = 1;
-                if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS)
+                if (tg3_flag(tp, 5750_PLUS))
                        is_5750 = 1;
        }
@@ -10727,7 +10799,7 @@ static int tg3_test_registers(struct tg3 *tp)
                if (!is_5705 && (reg_tbl[i].flags & TG3_FL_5705))
                        continue;
-                if ((tp->tg3_flags2 & TG3_FLG2_IS_5788) &&
+                if (tg3_flag(tp, IS_5788) &&
                    (reg_tbl[i].flags & TG3_FL_NOT_5788))
                        continue;
@@ -10850,16 +10922,15 @@ static int tg3_test_memory(struct tg3 *tp)
        int err = 0;
        int i;
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+        if (tg3_flag(tp, 5717_PLUS))
-            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)
                mem_tbl = mem_tbl_5717;
        else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57765)
                mem_tbl = mem_tbl_57765;
-        else if (tp->tg3_flags3 & TG3_FLG3_5755_PLUS)
+        else if (tg3_flag(tp, 5755_PLUS))
                mem_tbl = mem_tbl_5755;
        else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906)
                mem_tbl = mem_tbl_5906;
-        else if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS)
+        else if (tg3_flag(tp, 5705_PLUS))
                mem_tbl = mem_tbl_5705;
        else
                mem_tbl = mem_tbl_570x;
@@ -10875,11 +10946,35 @@ static int tg3_test_memory(struct tg3 *tp)
 #define TG3_MAC_LOOPBACK        0
 #define TG3_PHY_LOOPBACK        1
+#define TG3_TSO_LOOPBACK        2
+#define TG3_TSO_MSS             500
+#define TG3_TSO_IP_HDR_LEN      20
+#define TG3_TSO_TCP_HDR_LEN     20
+#define TG3_TSO_TCP_OPT_LEN     12
+static const u8 tg3_tso_header[] = {
+0x08, 0x00,
+0x45, 0x00, 0x00, 0x00,
+0x00, 0x00, 0x40, 0x00,
+0x40, 0x06, 0x00, 0x00,
+0x0a, 0x00, 0x00, 0x01,
+0x0a, 0x00, 0x00, 0x02,
+0x0d, 0x00, 0xe0, 0x00,
+0x00, 0x00, 0x01, 0x00,
+0x00, 0x00, 0x02, 0x00,
+0x80, 0x10, 0x10, 0x00,
+0x14, 0x09, 0x00, 0x00,
+0x01, 0x01, 0x08, 0x0a,
+0x11, 0x11, 0x11, 0x11,
+0x11, 0x11, 0x11, 0x11,
+};
-static int tg3_run_loopback(struct tg3 *tp, int loopback_mode)
+static int tg3_run_loopback(struct tg3 *tp, u32 pktsz, int loopback_mode)
 {
        u32 mac_mode, rx_start_idx, rx_idx, tx_idx, opaque_key;
-        u32 desc_idx, coal_now;
+        u32 base_flags = 0, mss = 0, desc_idx, coal_now, data_off, val;
        struct sk_buff *skb, *rx_skb;
        u8 *tx_data;
        dma_addr_t map;
@@ -10891,9 +10986,9 @@ static int tg3_run_loopback(struct tg3 *tp, int loopback_mode)
        tnapi = &tp->napi[0];
        rnapi = &tp->napi[0];
        if (tp->irq_cnt > 1) {
-                if (tp->tg3_flags3 & TG3_FLG3_ENABLE_RSS)
+                if (tg3_flag(tp, ENABLE_RSS))
                        rnapi = &tp->napi[1];
-                if (tp->tg3_flags3 & TG3_FLG3_ENABLE_TSS)
+                if (tg3_flag(tp, ENABLE_TSS))
                        tnapi = &tp->napi[1];
        }
        coal_now = tnapi->coal_now | rnapi->coal_now;
@@ -10905,22 +11000,20 @@ static int tg3_run_loopback(struct tg3 *tp, int loopback_mode)
                 * all newer ASIC revisions.
                 */
                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5780 ||
-                    (tp->tg3_flags & TG3_FLAG_CPMU_PRESENT))
+                    tg3_flag(tp, CPMU_PRESENT))
                        return 0;
                mac_mode = tp->mac_mode &
                           ~(MAC_MODE_PORT_MODE_MASK | MAC_MODE_HALF_DUPLEX);
                mac_mode |= MAC_MODE_PORT_INT_LPBACK;
-                if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+                if (!tg3_flag(tp, 5705_PLUS))
                        mac_mode |= MAC_MODE_LINK_POLARITY;
                if (tp->phy_flags & TG3_PHYFLG_10_100_ONLY)
                        mac_mode |= MAC_MODE_PORT_MODE_MII;
                else
                        mac_mode |= MAC_MODE_PORT_MODE_GMII;
                tw32(MAC_MODE, mac_mode);
-        } else if (loopback_mode == TG3_PHY_LOOPBACK) {
+        } else {
-                u32 val;
                if (tp->phy_flags & TG3_PHYFLG_IS_FET) {
                        tg3_phy_fet_toggle_apd(tp, false);
                        val = BMCR_LOOPBACK | BMCR_FULLDPLX | BMCR_SPEED100;
@@ -10968,13 +11061,11 @@ static int tg3_run_loopback(struct tg3 *tp, int loopback_mode)
                                break;
                        mdelay(1);
                }
-        } else {
-                return -EINVAL;
        }
        err = -EIO;
-        tx_len = 1514;
+        tx_len = pktsz;
        skb = netdev_alloc_skb(tp->dev, tx_len);
        if (!skb)
                return -ENOMEM;
@@ -10983,9 +11074,58 @@ static int tg3_run_loopback(struct tg3 *tp, int loopback_mode)
        memcpy(tx_data, tp->dev->dev_addr, 6);
        memset(tx_data + 6, 0x0, 8);
-        tw32(MAC_RX_MTU_SIZE, tx_len + 4);
+        tw32(MAC_RX_MTU_SIZE, tx_len + ETH_FCS_LEN);
+        if (loopback_mode == TG3_TSO_LOOPBACK) {
+                struct iphdr *iph = (struct iphdr *)&tx_data[ETH_HLEN];
+                u32 hdr_len = TG3_TSO_IP_HDR_LEN + TG3_TSO_TCP_HDR_LEN +
+                              TG3_TSO_TCP_OPT_LEN;
+                memcpy(tx_data + ETH_ALEN * 2, tg3_tso_header,
+                       sizeof(tg3_tso_header));
+                mss = TG3_TSO_MSS;
+                val = tx_len - ETH_ALEN * 2 - sizeof(tg3_tso_header);
+                num_pkts = DIV_ROUND_UP(val, TG3_TSO_MSS);
+                /* Set the total length field in the IP header */
+                iph->tot_len = htons((u16)(mss + hdr_len));
+                base_flags = (TXD_FLAG_CPU_PRE_DMA |
+                              TXD_FLAG_CPU_POST_DMA);
+                if (tg3_flag(tp, HW_TSO_1) ||
+                    tg3_flag(tp, HW_TSO_2) ||
+                    tg3_flag(tp, HW_TSO_3)) {
+                        struct tcphdr *th;
+                        val = ETH_HLEN + TG3_TSO_IP_HDR_LEN;
+                        th = (struct tcphdr *)&tx_data[val];
+                        th->check = 0;
+                } else
+                        base_flags |= TXD_FLAG_TCPUDP_CSUM;
+                if (tg3_flag(tp, HW_TSO_3)) {
+                        mss |= (hdr_len & 0xc) << 12;
+                        if (hdr_len & 0x10)
+                                base_flags |= 0x00000010;
+                        base_flags |= (hdr_len & 0x3e0) << 5;
+                } else if (tg3_flag(tp, HW_TSO_2))
+                        mss |= hdr_len << 9;
+                else if (tg3_flag(tp, HW_TSO_1) ||
+                         GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705) {
+                        mss |= (TG3_TSO_TCP_OPT_LEN << 9);
+                } else {
+                        base_flags |= (TG3_TSO_TCP_OPT_LEN << 10);
+                }
+                data_off = ETH_ALEN * 2 + sizeof(tg3_tso_header);
+        } else {
+                num_pkts = 1;
+                data_off = ETH_HLEN;
+        }
-        for (i = 14; i < tx_len; i++)
+        for (i = data_off; i < tx_len; i++)
                tx_data[i] = (u8) (i & 0xff);
        map = pci_map_single(tp->pdev, skb->data, tx_len, PCI_DMA_TODEVICE);
@@ -11001,12 +11141,10 @@ static int tg3_run_loopback(struct tg3 *tp, int loopback_mode)
        rx_start_idx = rnapi->hw_status->idx[0].rx_producer;
-        num_pkts = 0;
+        tg3_set_txd(tnapi, tnapi->tx_prod, map, tx_len,
+                    base_flags, (mss << 1) | 1);
-        tg3_set_txd(tnapi, tnapi->tx_prod, map, tx_len, 0, 1);
        tnapi->tx_prod++;
-        num_pkts++;
        tw32_tx_mbox(tnapi->prodmbox, tnapi->tx_prod);
        tr32_mailbox(tnapi->prodmbox);
@@ -11036,29 +11174,56 @@ static int tg3_run_loopback(struct tg3 *tp, int loopback_mode)
        if (rx_idx != rx_start_idx + num_pkts)
                goto out;
-        desc = &rnapi->rx_rcb[rx_start_idx];
+        val = data_off;
-        desc_idx = desc->opaque & RXD_OPAQUE_INDEX_MASK;
+        while (rx_idx != rx_start_idx) {
-        opaque_key = desc->opaque & RXD_OPAQUE_RING_MASK;
+                desc = &rnapi->rx_rcb[rx_start_idx++];
-        if (opaque_key != RXD_OPAQUE_RING_STD)
+                desc_idx = desc->opaque & RXD_OPAQUE_INDEX_MASK;
-                goto out;
+                opaque_key = desc->opaque & RXD_OPAQUE_RING_MASK;
-        if ((desc->err_vlan & RXD_ERR_MASK) != 0 &&
+                if ((desc->err_vlan & RXD_ERR_MASK) != 0 &&
-            (desc->err_vlan != RXD_ERR_ODD_NIBBLE_RCVD_MII))
+                    (desc->err_vlan != RXD_ERR_ODD_NIBBLE_RCVD_MII))
-                goto out;
+                        goto out;
-        rx_len = ((desc->idx_len & RXD_LEN_MASK) >> RXD_LEN_SHIFT) - 4;
+                rx_len = ((desc->idx_len & RXD_LEN_MASK) >> RXD_LEN_SHIFT)
-        if (rx_len != tx_len)
+                         - ETH_FCS_LEN;
-                goto out;
-        rx_skb = tpr->rx_std_buffers[desc_idx].skb;
+                if (loopback_mode != TG3_TSO_LOOPBACK) {
+                        if (rx_len != tx_len)
+                                goto out;
-        map = dma_unmap_addr(&tpr->rx_std_buffers[desc_idx], mapping);
+                        if (pktsz <= TG3_RX_STD_DMA_SZ - ETH_FCS_LEN) {
-        pci_dma_sync_single_for_cpu(tp->pdev, map, rx_len, PCI_DMA_FROMDEVICE);
+                                if (opaque_key != RXD_OPAQUE_RING_STD)
+                                        goto out;
+                        } else {
+                                if (opaque_key != RXD_OPAQUE_RING_JUMBO)
+                                        goto out;
+                        }
+                } else if ((desc->type_flags & RXD_FLAG_TCPUDP_CSUM) &&
+                           (desc->ip_tcp_csum & RXD_TCPCSUM_MASK)
+                            >> RXD_TCPCSUM_SHIFT != 0xffff) {
+                        goto out;
+                }
-        for (i = 14; i < tx_len; i++) {
+                if (opaque_key == RXD_OPAQUE_RING_STD) {
-                if (*(rx_skb->data + i) != (u8) (i & 0xff))
+                        rx_skb = tpr->rx_std_buffers[desc_idx].skb;
+                        map = dma_unmap_addr(&tpr->rx_std_buffers[desc_idx],
+                                             mapping);
+                } else if (opaque_key == RXD_OPAQUE_RING_JUMBO) {
+                        rx_skb = tpr->rx_jmb_buffers[desc_idx].skb;
+                        map = dma_unmap_addr(&tpr->rx_jmb_buffers[desc_idx],
+                                             mapping);
+                } else
                        goto out;
+                pci_dma_sync_single_for_cpu(tp->pdev, map, rx_len,
+                                            PCI_DMA_FROMDEVICE);
+                for (i = data_off; i < rx_len; i++, val++) {
+                        if (*(rx_skb->data + i) != (u8) (val & 0xff))
+                                goto out;
+                }
        }
        err = 0;
        /* tg3_free_rings will unmap and free the rx_skb */
@@ -11066,10 +11231,13 @@ out:
        return err;
 }
-#define TG3_MAC_LOOPBACK_FAILED         1
+#define TG3_STD_LOOPBACK_FAILED         1
-#define TG3_PHY_LOOPBACK_FAILED         2
+#define TG3_JMB_LOOPBACK_FAILED         2
-#define TG3_LOOPBACK_FAILED             (TG3_MAC_LOOPBACK_FAILED |      \
+#define TG3_TSO_LOOPBACK_FAILED         4
-                                         TG3_PHY_LOOPBACK_FAILED)
+#define TG3_MAC_LOOPBACK_SHIFT          0
+#define TG3_PHY_LOOPBACK_SHIFT          4
+#define TG3_LOOPBACK_FAILED             0x00000077
 static int tg3_test_loopback(struct tg3 *tp)
 {
@@ -11088,11 +11256,20 @@ static int tg3_test_loopback(struct tg3 *tp)
                goto done;
        }
+        if (tg3_flag(tp, ENABLE_RSS)) {
+                int i;
+                /* Reroute all rx packets to the 1st queue */
+                for (i = MAC_RSS_INDIR_TBL_0;
+                     i < MAC_RSS_INDIR_TBL_0 + TG3_RSS_INDIR_TBL_SIZE; i += 4)
+                        tw32(i, 0x0);
+        }
        /* Turn off gphy autopowerdown. */
        if (tp->phy_flags & TG3_PHYFLG_ENABLE_APD)
                tg3_phy_toggle_apd(tp, false);
-        if (tp->tg3_flags & TG3_FLAG_CPMU_PRESENT) {
+        if (tg3_flag(tp, CPMU_PRESENT)) {
                int i;
                u32 status;
@@ -11118,10 +11295,14 @@ static int tg3_test_loopback(struct tg3 *tp)
                                  CPMU_CTRL_LINK_AWARE_MODE));
        }
-        if (tg3_run_loopback(tp, TG3_MAC_LOOPBACK))
+        if (tg3_run_loopback(tp, ETH_FRAME_LEN, TG3_MAC_LOOPBACK))
-                err |= TG3_MAC_LOOPBACK_FAILED;
+                err |= TG3_STD_LOOPBACK_FAILED << TG3_MAC_LOOPBACK_SHIFT;
-        if (tp->tg3_flags & TG3_FLAG_CPMU_PRESENT) {
+        if (tg3_flag(tp, JUMBO_RING_ENABLE) &&
+            tg3_run_loopback(tp, 9000 + ETH_HLEN, TG3_MAC_LOOPBACK))
+                err |= TG3_JMB_LOOPBACK_FAILED << TG3_MAC_LOOPBACK_SHIFT;
+        if (tg3_flag(tp, CPMU_PRESENT)) {
                tw32(TG3_CPMU_CTRL, cpmuctrl);
                /* Release the mutex */
@@ -11129,9 +11310,18 @@ static int tg3_test_loopback(struct tg3 *tp)
        }
        if (!(tp->phy_flags & TG3_PHYFLG_PHY_SERDES) &&
-            !(tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB)) {
+            !tg3_flag(tp, USE_PHYLIB)) {
-                if (tg3_run_loopback(tp, TG3_PHY_LOOPBACK))
+                if (tg3_run_loopback(tp, ETH_FRAME_LEN, TG3_PHY_LOOPBACK))
-                        err |= TG3_PHY_LOOPBACK_FAILED;
+                        err |= TG3_STD_LOOPBACK_FAILED <<
+                               TG3_PHY_LOOPBACK_SHIFT;
+                if (tg3_flag(tp, TSO_CAPABLE) &&
+                    tg3_run_loopback(tp, ETH_FRAME_LEN, TG3_TSO_LOOPBACK))
+                        err |= TG3_TSO_LOOPBACK_FAILED <<
+                               TG3_PHY_LOOPBACK_SHIFT;
+                if (tg3_flag(tp, JUMBO_RING_ENABLE) &&
+                    tg3_run_loopback(tp, 9000 + ETH_HLEN, TG3_PHY_LOOPBACK))
+                        err |= TG3_JMB_LOOPBACK_FAILED <<
+                               TG3_PHY_LOOPBACK_SHIFT;
        }
        /* Re-enable gphy autopowerdown. */
@@ -11176,7 +11366,7 @@ static void tg3_self_test(struct net_device *dev, struct ethtool_test *etest,
                tg3_halt(tp, RESET_KIND_SUSPEND, 1);
                err = tg3_nvram_lock(tp);
                tg3_halt_cpu(tp, RX_CPU_BASE);
-                if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+                if (!tg3_flag(tp, 5705_PLUS))
                        tg3_halt_cpu(tp, TX_CPU_BASE);
                if (!err)
                        tg3_nvram_unlock(tp);
@@ -11206,7 +11396,7 @@ static void tg3_self_test(struct net_device *dev, struct ethtool_test *etest,
                tg3_halt(tp, RESET_KIND_SHUTDOWN, 1);
                if (netif_running(dev)) {
-                        tp->tg3_flags |= TG3_FLAG_INIT_COMPLETE;
+                        tg3_flag_set(tp, INIT_COMPLETE);
                        err2 = tg3_restart_hw(tp, 1);
                        if (!err2)
                                tg3_netif_start(tp);
@@ -11228,7 +11418,7 @@ static int tg3_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
        struct tg3 *tp = netdev_priv(dev);
        int err;
-        if (tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB) {
+        if (tg3_flag(tp, USE_PHYLIB)) {
                struct phy_device *phydev;
                if (!(tp->phy_flags & TG3_PHYFLG_IS_CONNECTED))
                        return -EAGAIN;
@@ -11247,9 +11437,7 @@ static int tg3_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
                if (tp->phy_flags & TG3_PHYFLG_PHY_SERDES)
                        break;                  /* We have no PHY */
-                if ((tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER) ||
+                if (!netif_running(dev))
-                    ((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) &&
-                     !netif_running(dev)))
                        return -EAGAIN;
                spin_lock_bh(&tp->lock);
@@ -11265,9 +11453,7 @@ static int tg3_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
                if (tp->phy_flags & TG3_PHYFLG_PHY_SERDES)
                        break;                  /* We have no PHY */
-                if ((tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER) ||
+                if (!netif_running(dev))
-                    ((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) &&
-                     !netif_running(dev)))
                        return -EAGAIN;
                spin_lock_bh(&tp->lock);
@@ -11297,7 +11483,7 @@ static int tg3_set_coalesce(struct net_device *dev, struct ethtool_coalesce *ec)
        u32 max_rxcoal_tick_int = 0, max_txcoal_tick_int = 0;
        u32 max_stat_coal_ticks = 0, min_stat_coal_ticks = 0;
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) {
+        if (!tg3_flag(tp, 5705_PLUS)) {
                max_rxcoal_tick_int = MAX_RXCOAL_TICK_INT;
                max_txcoal_tick_int = MAX_TXCOAL_TICK_INT;
                max_stat_coal_ticks = MAX_STAT_COAL_TICKS;
@@ -11364,14 +11550,9 @@ static const struct ethtool_ops tg3_ethtool_ops = {
        .set_ringparam          = tg3_set_ringparam,
        .get_pauseparam         = tg3_get_pauseparam,
        .set_pauseparam         = tg3_set_pauseparam,
-        .get_rx_csum            = tg3_get_rx_csum,
-        .set_rx_csum            = tg3_set_rx_csum,
-        .set_tx_csum            = tg3_set_tx_csum,
-        .set_sg                 = ethtool_op_set_sg,
-        .set_tso                = tg3_set_tso,
        .self_test              = tg3_self_test,
        .get_strings            = tg3_get_strings,
-        .phys_id                = tg3_phys_id,
+        .set_phys_id            = tg3_set_phys_id,
        .get_ethtool_stats      = tg3_get_ethtool_stats,
        .get_coalesce           = tg3_get_coalesce,
        .set_coalesce           = tg3_set_coalesce,
@@ -11416,8 +11597,7 @@ static void __devinit tg3_get_nvram_size(struct tg3 *tp)
 {
        u32 val;
-        if ((tp->tg3_flags3 & TG3_FLG3_NO_NVRAM) ||
+        if (tg3_flag(tp, NO_NVRAM) || tg3_nvram_read(tp, 0, &val) != 0)
-            tg3_nvram_read(tp, 0, &val) != 0)
                return;
        /* Selfboot format */
@@ -11452,19 +11632,19 @@ static void __devinit tg3_get_nvram_info(struct tg3 *tp)
        nvcfg1 = tr32(NVRAM_CFG1);
        if (nvcfg1 & NVRAM_CFG1_FLASHIF_ENAB) {
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
        } else {
                nvcfg1 &= ~NVRAM_CFG1_COMPAT_BYPASS;
                tw32(NVRAM_CFG1, nvcfg1);
        }
-        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) ||
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750 ||
-            (tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) {
+            tg3_flag(tp, 5780_CLASS)) {
                switch (nvcfg1 & NVRAM_CFG1_VENDOR_MASK) {
                case FLASH_VENDOR_ATMEL_FLASH_BUFFERED:
                        tp->nvram_jedecnum = JEDEC_ATMEL;
                        tp->nvram_pagesize = ATMEL_AT45DB0X1B_PAGE_SIZE;
-                        tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                        tg3_flag_set(tp, NVRAM_BUFFERED);
                        break;
                case FLASH_VENDOR_ATMEL_FLASH_UNBUFFERED:
                        tp->nvram_jedecnum = JEDEC_ATMEL;
@@ -11473,12 +11653,12 @@ static void __devinit tg3_get_nvram_info(struct tg3 *tp)
                case FLASH_VENDOR_ATMEL_EEPROM:
                        tp->nvram_jedecnum = JEDEC_ATMEL;
                        tp->nvram_pagesize = ATMEL_AT24C512_CHIP_SIZE;
-                        tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                        tg3_flag_set(tp, NVRAM_BUFFERED);
                        break;
                case FLASH_VENDOR_ST:
                        tp->nvram_jedecnum = JEDEC_ST;
                        tp->nvram_pagesize = ST_M45PEX0_PAGE_SIZE;
-                        tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                        tg3_flag_set(tp, NVRAM_BUFFERED);
                        break;
                case FLASH_VENDOR_SAIFUN:
                        tp->nvram_jedecnum = JEDEC_SAIFUN;
@@ -11493,7 +11673,7 @@ static void __devinit tg3_get_nvram_info(struct tg3 *tp)
        } else {
                tp->nvram_jedecnum = JEDEC_ATMEL;
                tp->nvram_pagesize = ATMEL_AT45DB0X1B_PAGE_SIZE;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
        }
 }
@@ -11532,29 +11712,29 @@ static void __devinit tg3_get_5752_nvram_info(struct tg3 *tp)
        /* NVRAM protection for TPM */
        if (nvcfg1 & (1 << 27))
-                tp->tg3_flags3 |= TG3_FLG3_PROTECTED_NVRAM;
+                tg3_flag_set(tp, PROTECTED_NVRAM);
        switch (nvcfg1 & NVRAM_CFG1_5752VENDOR_MASK) {
        case FLASH_5752VENDOR_ATMEL_EEPROM_64KHZ:
        case FLASH_5752VENDOR_ATMEL_EEPROM_376KHZ:
                tp->nvram_jedecnum = JEDEC_ATMEL;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
                break;
        case FLASH_5752VENDOR_ATMEL_FLASH_BUFFERED:
                tp->nvram_jedecnum = JEDEC_ATMEL;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                break;
        case FLASH_5752VENDOR_ST_M45PE10:
        case FLASH_5752VENDOR_ST_M45PE20:
        case FLASH_5752VENDOR_ST_M45PE40:
                tp->nvram_jedecnum = JEDEC_ST;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                break;
        }
-        if (tp->tg3_flags2 & TG3_FLG2_FLASH) {
+        if (tg3_flag(tp, FLASH)) {
                tg3_nvram_get_pagesize(tp, nvcfg1);
        } else {
                /* For eeprom, set pagesize to maximum eeprom size */
@@ -11573,7 +11753,7 @@ static void __devinit tg3_get_5755_nvram_info(struct tg3 *tp)
        /* NVRAM protection for TPM */
        if (nvcfg1 & (1 << 27)) {
-                tp->tg3_flags3 |= TG3_FLG3_PROTECTED_NVRAM;
+                tg3_flag_set(tp, PROTECTED_NVRAM);
                protect = 1;
        }
@@ -11584,8 +11764,8 @@ static void __devinit tg3_get_5755_nvram_info(struct tg3 *tp)
        case FLASH_5755VENDOR_ATMEL_FLASH_3:
        case FLASH_5755VENDOR_ATMEL_FLASH_5:
                tp->nvram_jedecnum = JEDEC_ATMEL;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                tp->nvram_pagesize = 264;
                if (nvcfg1 == FLASH_5755VENDOR_ATMEL_FLASH_1 ||
                    nvcfg1 == FLASH_5755VENDOR_ATMEL_FLASH_5)
@@ -11602,8 +11782,8 @@ static void __devinit tg3_get_5755_nvram_info(struct tg3 *tp)
        case FLASH_5752VENDOR_ST_M45PE20:
        case FLASH_5752VENDOR_ST_M45PE40:
                tp->nvram_jedecnum = JEDEC_ST;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                tp->nvram_pagesize = 256;
                if (nvcfg1 == FLASH_5752VENDOR_ST_M45PE10)
                        tp->nvram_size = (protect ?
@@ -11633,7 +11813,7 @@ static void __devinit tg3_get_5787_nvram_info(struct tg3 *tp)
        case FLASH_5787VENDOR_MICRO_EEPROM_64KHZ:
        case FLASH_5787VENDOR_MICRO_EEPROM_376KHZ:
                tp->nvram_jedecnum = JEDEC_ATMEL;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
                tp->nvram_pagesize = ATMEL_AT24C512_CHIP_SIZE;
                nvcfg1 &= ~NVRAM_CFG1_COMPAT_BYPASS;
@@ -11644,16 +11824,16 @@ static void __devinit tg3_get_5787_nvram_info(struct tg3 *tp)
        case FLASH_5755VENDOR_ATMEL_FLASH_2:
        case FLASH_5755VENDOR_ATMEL_FLASH_3:
                tp->nvram_jedecnum = JEDEC_ATMEL;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                tp->nvram_pagesize = 264;
                break;
        case FLASH_5752VENDOR_ST_M45PE10:
        case FLASH_5752VENDOR_ST_M45PE20:
        case FLASH_5752VENDOR_ST_M45PE40:
                tp->nvram_jedecnum = JEDEC_ST;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                tp->nvram_pagesize = 256;
                break;
        }
@@ -11667,7 +11847,7 @@ static void __devinit tg3_get_5761_nvram_info(struct tg3 *tp)
        /* NVRAM protection for TPM */
        if (nvcfg1 & (1 << 27)) {
-                tp->tg3_flags3 |= TG3_FLG3_PROTECTED_NVRAM;
+                tg3_flag_set(tp, PROTECTED_NVRAM);
                protect = 1;
        }
@@ -11682,9 +11862,9 @@ static void __devinit tg3_get_5761_nvram_info(struct tg3 *tp)
        case FLASH_5761VENDOR_ATMEL_MDB081D:
        case FLASH_5761VENDOR_ATMEL_MDB161D:
                tp->nvram_jedecnum = JEDEC_ATMEL;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
-                tp->tg3_flags3 |= TG3_FLG3_NO_NVRAM_ADDR_TRANS;
+                tg3_flag_set(tp, NO_NVRAM_ADDR_TRANS);
                tp->nvram_pagesize = 256;
                break;
        case FLASH_5761VENDOR_ST_A_M45PE20:
@@ -11696,8 +11876,8 @@ static void __devinit tg3_get_5761_nvram_info(struct tg3 *tp)
        case FLASH_5761VENDOR_ST_M_M45PE80:
        case FLASH_5761VENDOR_ST_M_M45PE16:
                tp->nvram_jedecnum = JEDEC_ST;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                tp->nvram_pagesize = 256;
                break;
        }
@@ -11737,7 +11917,7 @@ static void __devinit tg3_get_5761_nvram_info(struct tg3 *tp)
 static void __devinit tg3_get_5906_nvram_info(struct tg3 *tp)
 {
        tp->nvram_jedecnum = JEDEC_ATMEL;
-        tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+        tg3_flag_set(tp, NVRAM_BUFFERED);
        tp->nvram_pagesize = ATMEL_AT24C512_CHIP_SIZE;
 }
@@ -11751,7 +11931,7 @@ static void __devinit tg3_get_57780_nvram_info(struct tg3 *tp)
        case FLASH_5787VENDOR_ATMEL_EEPROM_376KHZ:
        case FLASH_5787VENDOR_MICRO_EEPROM_376KHZ:
                tp->nvram_jedecnum = JEDEC_ATMEL;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
                tp->nvram_pagesize = ATMEL_AT24C512_CHIP_SIZE;
                nvcfg1 &= ~NVRAM_CFG1_COMPAT_BYPASS;
@@ -11765,8 +11945,8 @@ static void __devinit tg3_get_57780_nvram_info(struct tg3 *tp)
        case FLASH_57780VENDOR_ATMEL_AT45DB041D:
        case FLASH_57780VENDOR_ATMEL_AT45DB041B:
                tp->nvram_jedecnum = JEDEC_ATMEL;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                switch (nvcfg1 & NVRAM_CFG1_5752VENDOR_MASK) {
                case FLASH_5752VENDOR_ATMEL_FLASH_BUFFERED:
@@ -11788,8 +11968,8 @@ static void __devinit tg3_get_57780_nvram_info(struct tg3 *tp)
        case FLASH_5752VENDOR_ST_M45PE20:
        case FLASH_5752VENDOR_ST_M45PE40:
                tp->nvram_jedecnum = JEDEC_ST;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                switch (nvcfg1 & NVRAM_CFG1_5752VENDOR_MASK) {
                case FLASH_5752VENDOR_ST_M45PE10:
@@ -11804,13 +11984,13 @@ static void __devinit tg3_get_57780_nvram_info(struct tg3 *tp)
                }
                break;
        default:
-                tp->tg3_flags3 |= TG3_FLG3_NO_NVRAM;
+                tg3_flag_set(tp, NO_NVRAM);
                return;
        }
        tg3_nvram_get_pagesize(tp, nvcfg1);
        if (tp->nvram_pagesize != 264 && tp->nvram_pagesize != 528)
-                tp->tg3_flags3 |= TG3_FLG3_NO_NVRAM_ADDR_TRANS;
+                tg3_flag_set(tp, NO_NVRAM_ADDR_TRANS);
 }
@@ -11824,7 +12004,7 @@ static void __devinit tg3_get_5717_nvram_info(struct tg3 *tp)
        case FLASH_5717VENDOR_ATMEL_EEPROM:
        case FLASH_5717VENDOR_MICRO_EEPROM:
                tp->nvram_jedecnum = JEDEC_ATMEL;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
                tp->nvram_pagesize = ATMEL_AT24C512_CHIP_SIZE;
                nvcfg1 &= ~NVRAM_CFG1_COMPAT_BYPASS;
@@ -11838,11 +12018,13 @@ static void __devinit tg3_get_5717_nvram_info(struct tg3 *tp)
        case FLASH_5717VENDOR_ATMEL_ADB021D:
        case FLASH_5717VENDOR_ATMEL_45USPT:
                tp->nvram_jedecnum = JEDEC_ATMEL;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                switch (nvcfg1 & NVRAM_CFG1_5752VENDOR_MASK) {
                case FLASH_5717VENDOR_ATMEL_MDB021D:
+                        /* Detect size with tg3_nvram_get_size() */
+                        break;
                case FLASH_5717VENDOR_ATMEL_ADB021B:
                case FLASH_5717VENDOR_ATMEL_ADB021D:
                        tp->nvram_size = TG3_NVRAM_SIZE_256KB;
@@ -11863,13 +12045,15 @@ static void __devinit tg3_get_5717_nvram_info(struct tg3 *tp)
        case FLASH_5717VENDOR_ST_25USPT:
        case FLASH_5717VENDOR_ST_45USPT:
                tp->nvram_jedecnum = JEDEC_ST;
-                tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
-                tp->tg3_flags2 |= TG3_FLG2_FLASH;
+                tg3_flag_set(tp, FLASH);
                switch (nvcfg1 & NVRAM_CFG1_5752VENDOR_MASK) {
                case FLASH_5717VENDOR_ST_M_M25PE20:
-                case FLASH_5717VENDOR_ST_A_M25PE20:
                case FLASH_5717VENDOR_ST_M_M45PE20:
+                        /* Detect size with tg3_nvram_get_size() */
+                        break;
+                case FLASH_5717VENDOR_ST_A_M25PE20:
                case FLASH_5717VENDOR_ST_A_M45PE20:
                        tp->nvram_size = TG3_NVRAM_SIZE_256KB;
                        break;
@@ -11879,13 +12063,125 @@ static void __devinit tg3_get_5717_nvram_info(struct tg3 *tp)
                }
                break;
        default:
-                tp->tg3_flags3 |= TG3_FLG3_NO_NVRAM;
+                tg3_flag_set(tp, NO_NVRAM);
+                return;
+        }
+        tg3_nvram_get_pagesize(tp, nvcfg1);
+        if (tp->nvram_pagesize != 264 && tp->nvram_pagesize != 528)
+                tg3_flag_set(tp, NO_NVRAM_ADDR_TRANS);
+}
+static void __devinit tg3_get_5720_nvram_info(struct tg3 *tp)
+{
+        u32 nvcfg1, nvmpinstrp;
+        nvcfg1 = tr32(NVRAM_CFG1);
+        nvmpinstrp = nvcfg1 & NVRAM_CFG1_5752VENDOR_MASK;
+        switch (nvmpinstrp) {
+        case FLASH_5720_EEPROM_HD:
+        case FLASH_5720_EEPROM_LD:
+                tp->nvram_jedecnum = JEDEC_ATMEL;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
+                nvcfg1 &= ~NVRAM_CFG1_COMPAT_BYPASS;
+                tw32(NVRAM_CFG1, nvcfg1);
+                if (nvmpinstrp == FLASH_5720_EEPROM_HD)
+                        tp->nvram_pagesize = ATMEL_AT24C512_CHIP_SIZE;
+                else
+                        tp->nvram_pagesize = ATMEL_AT24C02_CHIP_SIZE;
+                return;
+        case FLASH_5720VENDOR_M_ATMEL_DB011D:
+        case FLASH_5720VENDOR_A_ATMEL_DB011B:
+        case FLASH_5720VENDOR_A_ATMEL_DB011D:
+        case FLASH_5720VENDOR_M_ATMEL_DB021D:
+        case FLASH_5720VENDOR_A_ATMEL_DB021B:
+        case FLASH_5720VENDOR_A_ATMEL_DB021D:
+        case FLASH_5720VENDOR_M_ATMEL_DB041D:
+        case FLASH_5720VENDOR_A_ATMEL_DB041B:
+        case FLASH_5720VENDOR_A_ATMEL_DB041D:
+        case FLASH_5720VENDOR_M_ATMEL_DB081D:
+        case FLASH_5720VENDOR_A_ATMEL_DB081D:
+        case FLASH_5720VENDOR_ATMEL_45USPT:
+                tp->nvram_jedecnum = JEDEC_ATMEL;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
+                tg3_flag_set(tp, FLASH);
+                switch (nvmpinstrp) {
+                case FLASH_5720VENDOR_M_ATMEL_DB021D:
+                case FLASH_5720VENDOR_A_ATMEL_DB021B:
+                case FLASH_5720VENDOR_A_ATMEL_DB021D:
+                        tp->nvram_size = TG3_NVRAM_SIZE_256KB;
+                        break;
+                case FLASH_5720VENDOR_M_ATMEL_DB041D:
+                case FLASH_5720VENDOR_A_ATMEL_DB041B:
+                case FLASH_5720VENDOR_A_ATMEL_DB041D:
+                        tp->nvram_size = TG3_NVRAM_SIZE_512KB;
+                        break;
+                case FLASH_5720VENDOR_M_ATMEL_DB081D:
+                case FLASH_5720VENDOR_A_ATMEL_DB081D:
+                        tp->nvram_size = TG3_NVRAM_SIZE_1MB;
+                        break;
+                default:
+                        tp->nvram_size = TG3_NVRAM_SIZE_128KB;
+                        break;
+                }
+                break;
+        case FLASH_5720VENDOR_M_ST_M25PE10:
+        case FLASH_5720VENDOR_M_ST_M45PE10:
+        case FLASH_5720VENDOR_A_ST_M25PE10:
+        case FLASH_5720VENDOR_A_ST_M45PE10:
+        case FLASH_5720VENDOR_M_ST_M25PE20:
+        case FLASH_5720VENDOR_M_ST_M45PE20:
+        case FLASH_5720VENDOR_A_ST_M25PE20:
+        case FLASH_5720VENDOR_A_ST_M45PE20:
+        case FLASH_5720VENDOR_M_ST_M25PE40:
+        case FLASH_5720VENDOR_M_ST_M45PE40:
+        case FLASH_5720VENDOR_A_ST_M25PE40:
+        case FLASH_5720VENDOR_A_ST_M45PE40:
+        case FLASH_5720VENDOR_M_ST_M25PE80:
+        case FLASH_5720VENDOR_M_ST_M45PE80:
+        case FLASH_5720VENDOR_A_ST_M25PE80:
+        case FLASH_5720VENDOR_A_ST_M45PE80:
+        case FLASH_5720VENDOR_ST_25USPT:
+        case FLASH_5720VENDOR_ST_45USPT:
+                tp->nvram_jedecnum = JEDEC_ST;
+                tg3_flag_set(tp, NVRAM_BUFFERED);
+                tg3_flag_set(tp, FLASH);
+                switch (nvmpinstrp) {
+                case FLASH_5720VENDOR_M_ST_M25PE20:
+                case FLASH_5720VENDOR_M_ST_M45PE20:
+                case FLASH_5720VENDOR_A_ST_M25PE20:
+                case FLASH_5720VENDOR_A_ST_M45PE20:
+                        tp->nvram_size = TG3_NVRAM_SIZE_256KB;
+                        break;
+                case FLASH_5720VENDOR_M_ST_M25PE40:
+                case FLASH_5720VENDOR_M_ST_M45PE40:
+                case FLASH_5720VENDOR_A_ST_M25PE40:
+                case FLASH_5720VENDOR_A_ST_M45PE40:
+                        tp->nvram_size = TG3_NVRAM_SIZE_512KB;
+                        break;
+                case FLASH_5720VENDOR_M_ST_M25PE80:
+                case FLASH_5720VENDOR_M_ST_M45PE80:
+                case FLASH_5720VENDOR_A_ST_M25PE80:
+                case FLASH_5720VENDOR_A_ST_M45PE80:
+                        tp->nvram_size = TG3_NVRAM_SIZE_1MB;
+                        break;
+                default:
+                        tp->nvram_size = TG3_NVRAM_SIZE_128KB;
+                        break;
+                }
+                break;
+        default:
+                tg3_flag_set(tp, NO_NVRAM);
                return;
        }
        tg3_nvram_get_pagesize(tp, nvcfg1);
        if (tp->nvram_pagesize != 264 && tp->nvram_pagesize != 528)
-                tp->tg3_flags3 |= TG3_FLG3_NO_NVRAM_ADDR_TRANS;
+                tg3_flag_set(tp, NO_NVRAM_ADDR_TRANS);
 }
 /* Chips other than 5700/5701 use the NVRAM for fetching info. */
@@ -11905,7 +12201,7 @@ static void __devinit tg3_nvram_init(struct tg3 *tp)
        if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700 &&
            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701) {
-                tp->tg3_flags |= TG3_FLAG_NVRAM;
+                tg3_flag_set(tp, NVRAM);
                if (tg3_nvram_lock(tp)) {
                        netdev_warn(tp->dev,
@@ -11935,6 +12231,8 @@ static void __devinit tg3_nvram_init(struct tg3 *tp)
                else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
                         GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)
                        tg3_get_5717_nvram_info(tp);
+                else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720)
+                        tg3_get_5720_nvram_info(tp);
                else
                        tg3_get_nvram_info(tp);
@@ -11945,7 +12243,8 @@ static void __devinit tg3_nvram_init(struct tg3 *tp)
                tg3_nvram_unlock(tp);
        } else {
-                tp->tg3_flags &= ~(TG3_FLAG_NVRAM | TG3_FLAG_NVRAM_BUFFERED);
+                tg3_flag_clear(tp, NVRAM);
+                tg3_flag_clear(tp, NVRAM_BUFFERED);
                tg3_get_eeprom_size(tp);
        }
@@ -12128,7 +12427,7 @@ static int tg3_nvram_write_block_buffered(struct tg3 *tp, u32 offset, u32 len,
                        nvram_cmd |= NVRAM_CMD_LAST;
                if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5752 &&
-                    !(tp->tg3_flags3 & TG3_FLG3_5755_PLUS) &&
+                    !tg3_flag(tp, 5755_PLUS) &&
                    (tp->nvram_jedecnum == JEDEC_ST) &&
                    (nvram_cmd & NVRAM_CMD_FIRST)) {
@@ -12138,7 +12437,7 @@ static int tg3_nvram_write_block_buffered(struct tg3 *tp, u32 offset, u32 len,
                                break;
                }
-                if (!(tp->tg3_flags2 & TG3_FLG2_FLASH)) {
+                if (!tg3_flag(tp, FLASH)) {
                        /* We always do complete word writes to eeprom. */
                        nvram_cmd |= (NVRAM_CMD_FIRST | NVRAM_CMD_LAST);
                }
@@ -12154,13 +12453,13 @@ static int tg3_nvram_write_block(struct tg3 *tp, u32 offset, u32 len, u8 *buf)
 {
        int ret;
-        if (tp->tg3_flags & TG3_FLAG_EEPROM_WRITE_PROT) {
+        if (tg3_flag(tp, EEPROM_WRITE_PROT)) {
                tw32_f(GRC_LOCAL_CTRL, tp->grc_local_ctrl &
                       ~GRC_LCLCTRL_GPIO_OUTPUT1);
                udelay(40);
        }
-        if (!(tp->tg3_flags & TG3_FLAG_NVRAM)) {
+        if (!tg3_flag(tp, NVRAM)) {
                ret = tg3_nvram_write_block_using_eeprom(tp, offset, len, buf);
        } else {
                u32 grc_mode;
@@ -12170,16 +12469,13 @@ static int tg3_nvram_write_block(struct tg3 *tp, u32 offset, u32 len, u8 *buf)
                        return ret;
                tg3_enable_nvram_access(tp);
-                if ((tp->tg3_flags2 & TG3_FLG2_5750_PLUS) &&
+                if (tg3_flag(tp, 5750_PLUS) && !tg3_flag(tp, PROTECTED_NVRAM))
-                    !(tp->tg3_flags3 & TG3_FLG3_PROTECTED_NVRAM))
                        tw32(NVRAM_WRITE1, 0x406);
                grc_mode = tr32(GRC_MODE);
                tw32(GRC_MODE, grc_mode | GRC_MODE_NVRAM_WR_ENABLE);
-                if ((tp->tg3_flags & TG3_FLAG_NVRAM_BUFFERED) ||
+                if (tg3_flag(tp, NVRAM_BUFFERED) || !tg3_flag(tp, FLASH)) {
-                        !(tp->tg3_flags2 & TG3_FLG2_FLASH)) {
                        ret = tg3_nvram_write_block_buffered(tp, offset, len,
                                buf);
                } else {
@@ -12194,7 +12490,7 @@ static int tg3_nvram_write_block(struct tg3 *tp, u32 offset, u32 len, u8 *buf)
                tg3_nvram_unlock(tp);
        }
-        if (tp->tg3_flags & TG3_FLAG_EEPROM_WRITE_PROT) {
+        if (tg3_flag(tp, EEPROM_WRITE_PROT)) {
                tw32_f(GRC_LOCAL_CTRL, tp->grc_local_ctrl);
                udelay(40);
        }
@@ -12316,19 +12612,20 @@ static void __devinit tg3_get_eeprom_hw_cfg(struct tg3 *tp)
        tp->led_ctrl = LED_CTRL_MODE_PHY_1;
        /* Assume an onboard device and WOL capable by default.  */
-        tp->tg3_flags |= TG3_FLAG_EEPROM_WRITE_PROT | TG3_FLAG_WOL_CAP;
+        tg3_flag_set(tp, EEPROM_WRITE_PROT);
+        tg3_flag_set(tp, WOL_CAP);
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906) {
                if (!(tr32(PCIE_TRANSACTION_CFG) & PCIE_TRANS_CFG_LOM)) {
-                        tp->tg3_flags &= ~TG3_FLAG_EEPROM_WRITE_PROT;
+                        tg3_flag_clear(tp, EEPROM_WRITE_PROT);
-                        tp->tg3_flags2 |= TG3_FLG2_IS_NIC;
+                        tg3_flag_set(tp, IS_NIC);
                }
                val = tr32(VCPU_CFGSHDW);
                if (val & VCPU_CFGSHDW_ASPM_DBNC)
-                        tp->tg3_flags |= TG3_FLAG_ASPM_WORKAROUND;
+                        tg3_flag_set(tp, ASPM_WORKAROUND);
                if ((val & VCPU_CFGSHDW_WOL_ENABLE) &&
                    (val & VCPU_CFGSHDW_WOL_MAGPKT)) {
-                        tp->tg3_flags |= TG3_FLAG_WOL_ENABLE;
+                        tg3_flag_set(tp, WOL_ENABLE);
                        device_set_wakeup_enable(&tp->pdev->dev, true);
                }
                goto done;
@@ -12345,9 +12642,9 @@ static void __devinit tg3_get_eeprom_hw_cfg(struct tg3 *tp)
                tg3_read_mem(tp, NIC_SRAM_DATA_VER, &ver);
                ver >>= NIC_SRAM_DATA_VER_SHIFT;
-                if ((GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700) &&
+                if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700 &&
-                    (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701) &&
+                    GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701 &&
-                    (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5703) &&
+                    GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5703 &&
                    (ver > 0) && (ver < 0x100))
                        tg3_read_mem(tp, NIC_SRAM_DATA_CFG_2, &cfg2);
@@ -12371,13 +12668,13 @@ static void __devinit tg3_get_eeprom_hw_cfg(struct tg3 *tp)
                tp->phy_id = eeprom_phy_id;
                if (eeprom_phy_serdes) {
-                        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+                        if (!tg3_flag(tp, 5705_PLUS))
                                tp->phy_flags |= TG3_PHYFLG_PHY_SERDES;
                        else
                                tp->phy_flags |= TG3_PHYFLG_MII_SERDES;
                }
-                if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS)
+                if (tg3_flag(tp, 5750_PLUS))
                        led_cfg = cfg2 & (NIC_SRAM_DATA_CFG_LED_MODE_MASK |
                                    SHASTA_EXT_LED_MODE_MASK);
                else
@@ -12437,34 +12734,34 @@ static void __devinit tg3_get_eeprom_hw_cfg(struct tg3 *tp)
                        tp->led_ctrl = LED_CTRL_MODE_PHY_1;
                if (nic_cfg & NIC_SRAM_DATA_CFG_EEPROM_WP) {
-                        tp->tg3_flags |= TG3_FLAG_EEPROM_WRITE_PROT;
+                        tg3_flag_set(tp, EEPROM_WRITE_PROT);
                        if ((tp->pdev->subsystem_vendor ==
                             PCI_VENDOR_ID_ARIMA) &&
                            (tp->pdev->subsystem_device == 0x205a ||
                             tp->pdev->subsystem_device == 0x2063))
-                                tp->tg3_flags &= ~TG3_FLAG_EEPROM_WRITE_PROT;
+                                tg3_flag_clear(tp, EEPROM_WRITE_PROT);
                } else {
-                        tp->tg3_flags &= ~TG3_FLAG_EEPROM_WRITE_PROT;
+                        tg3_flag_clear(tp, EEPROM_WRITE_PROT);
-                        tp->tg3_flags2 |= TG3_FLG2_IS_NIC;
+                        tg3_flag_set(tp, IS_NIC);
                }
                if (nic_cfg & NIC_SRAM_DATA_CFG_ASF_ENABLE) {
-                        tp->tg3_flags |= TG3_FLAG_ENABLE_ASF;
+                        tg3_flag_set(tp, ENABLE_ASF);
-                        if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS)
+                        if (tg3_flag(tp, 5750_PLUS))
-                                tp->tg3_flags2 |= TG3_FLG2_ASF_NEW_HANDSHAKE;
+                                tg3_flag_set(tp, ASF_NEW_HANDSHAKE);
                }
                if ((nic_cfg & NIC_SRAM_DATA_CFG_APE_ENABLE) &&
-                        (tp->tg3_flags2 & TG3_FLG2_5750_PLUS))
+                    tg3_flag(tp, 5750_PLUS))
-                        tp->tg3_flags3 |= TG3_FLG3_ENABLE_APE;
+                        tg3_flag_set(tp, ENABLE_APE);
                if (tp->phy_flags & TG3_PHYFLG_ANY_SERDES &&
                    !(nic_cfg & NIC_SRAM_DATA_CFG_FIBER_WOL))
-                        tp->tg3_flags &= ~TG3_FLAG_WOL_CAP;
+                        tg3_flag_clear(tp, WOL_CAP);
-                if ((tp->tg3_flags & TG3_FLAG_WOL_CAP) &&
+                if (tg3_flag(tp, WOL_CAP) &&
                    (nic_cfg & NIC_SRAM_DATA_CFG_WOL_ENABLE)) {
-                        tp->tg3_flags |= TG3_FLAG_WOL_ENABLE;
+                        tg3_flag_set(tp, WOL_ENABLE);
                        device_set_wakeup_enable(&tp->pdev->dev, true);
                }
@@ -12476,33 +12773,33 @@ static void __devinit tg3_get_eeprom_hw_cfg(struct tg3 *tp)
                if (cfg2 & (1 << 18))
                        tp->phy_flags |= TG3_PHYFLG_SERDES_PREEMPHASIS;
-                if (((tp->tg3_flags3 & TG3_FLG3_5717_PLUS) ||
+                if ((tg3_flag(tp, 57765_PLUS) ||
-                    ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5784 &&
+                     (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5784 &&
-                      GET_CHIP_REV(tp->pci_chip_rev_id) != CHIPREV_5784_AX))) &&
+                      GET_CHIP_REV(tp->pci_chip_rev_id) != CHIPREV_5784_AX)) &&
                    (cfg2 & NIC_SRAM_DATA_CFG_2_APD_EN))
                        tp->phy_flags |= TG3_PHYFLG_ENABLE_APD;
-                if ((tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS) &&
+                if (tg3_flag(tp, PCI_EXPRESS) &&
                    GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5785 &&
-                    !(tp->tg3_flags3 & TG3_FLG3_5717_PLUS)) {
+                    !tg3_flag(tp, 57765_PLUS)) {
                        u32 cfg3;
                        tg3_read_mem(tp, NIC_SRAM_DATA_CFG_3, &cfg3);
                        if (cfg3 & NIC_SRAM_ASPM_DEBOUNCE)
-                                tp->tg3_flags |= TG3_FLAG_ASPM_WORKAROUND;
+                                tg3_flag_set(tp, ASPM_WORKAROUND);
                }
                if (cfg4 & NIC_SRAM_RGMII_INBAND_DISABLE)
-                        tp->tg3_flags3 |= TG3_FLG3_RGMII_INBAND_DISABLE;
+                        tg3_flag_set(tp, RGMII_INBAND_DISABLE);
                if (cfg4 & NIC_SRAM_RGMII_EXT_IBND_RX_EN)
-                        tp->tg3_flags3 |= TG3_FLG3_RGMII_EXT_IBND_RX_EN;
+                        tg3_flag_set(tp, RGMII_EXT_IBND_RX_EN);
                if (cfg4 & NIC_SRAM_RGMII_EXT_IBND_TX_EN)
-                        tp->tg3_flags3 |= TG3_FLG3_RGMII_EXT_IBND_TX_EN;
+                        tg3_flag_set(tp, RGMII_EXT_IBND_TX_EN);
        }
 done:
-        if (tp->tg3_flags & TG3_FLAG_WOL_CAP)
+        if (tg3_flag(tp, WOL_CAP))
                device_set_wakeup_enable(&tp->pdev->dev,
-                                 tp->tg3_flags & TG3_FLAG_WOL_ENABLE);
+                                         tg3_flag(tp, WOL_ENABLE));
        else
                device_set_wakeup_capable(&tp->pdev->dev, false);
 }
@@ -12592,18 +12889,17 @@ static int __devinit tg3_phy_probe(struct tg3 *tp)
        int err;
        /* flow control autonegotiation is default behavior */
-        tp->tg3_flags |= TG3_FLAG_PAUSE_AUTONEG;
+        tg3_flag_set(tp, PAUSE_AUTONEG);
        tp->link_config.flowctrl = FLOW_CTRL_TX | FLOW_CTRL_RX;
-        if (tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB)
+        if (tg3_flag(tp, USE_PHYLIB))
                return tg3_phy_init(tp);
        /* Reading the PHY ID register can conflict with ASF
         * firmware access to the PHY hardware.
         */
        err = 0;
-        if ((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) ||
+        if (tg3_flag(tp, ENABLE_ASF) || tg3_flag(tp, ENABLE_APE)) {
-            (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)) {
                hw_phy_id = hw_phy_id_masked = TG3_PHY_ID_INVALID;
        } else {
                /* Now read the physical PHY_ID from the chip and verify
@@ -12659,9 +12955,9 @@ static int __devinit tg3_phy_probe(struct tg3 *tp)
        tg3_phy_init_link_config(tp);
        if (!(tp->phy_flags & TG3_PHYFLG_ANY_SERDES) &&
-            !(tp->tg3_flags3 & TG3_FLG3_ENABLE_APE) &&
+            !tg3_flag(tp, ENABLE_APE) &&
-            !(tp->tg3_flags & TG3_FLAG_ENABLE_ASF)) {
+            !tg3_flag(tp, ENABLE_ASF)) {
-                u32 bmsr, adv_reg, tg3_ctrl, mask;
+                u32 bmsr, mask;
                tg3_readphy(tp, MII_BMSR, &bmsr);
                if (!tg3_readphy(tp, MII_BMSR, &bmsr) &&
@@ -12672,36 +12968,18 @@ static int __devinit tg3_phy_probe(struct tg3 *tp)
                if (err)
                        return err;
-                adv_reg = (ADVERTISE_10HALF | ADVERTISE_10FULL |
+                tg3_phy_set_wirespeed(tp);
-                           ADVERTISE_100HALF | ADVERTISE_100FULL |
-                           ADVERTISE_CSMA | ADVERTISE_PAUSE_CAP);
-                tg3_ctrl = 0;
-                if (!(tp->phy_flags & TG3_PHYFLG_10_100_ONLY)) {
-                        tg3_ctrl = (MII_TG3_CTRL_ADV_1000_HALF |
-                                    MII_TG3_CTRL_ADV_1000_FULL);
-                        if (tp->pci_chip_rev_id == CHIPREV_ID_5701_A0 ||
-                            tp->pci_chip_rev_id == CHIPREV_ID_5701_B0)
-                                tg3_ctrl |= (MII_TG3_CTRL_AS_MASTER |
-                                             MII_TG3_CTRL_ENABLE_AS_MASTER);
-                }
                mask = (ADVERTISED_10baseT_Half | ADVERTISED_10baseT_Full |
                        ADVERTISED_100baseT_Half | ADVERTISED_100baseT_Full |
                        ADVERTISED_1000baseT_Half | ADVERTISED_1000baseT_Full);
                if (!tg3_copper_is_advertising_all(tp, mask)) {
-                        tg3_writephy(tp, MII_ADVERTISE, adv_reg);
+                        tg3_phy_autoneg_cfg(tp, tp->link_config.advertising,
+                                            tp->link_config.flowctrl);
-                        if (!(tp->phy_flags & TG3_PHYFLG_10_100_ONLY))
-                                tg3_writephy(tp, MII_TG3_CTRL, tg3_ctrl);
                        tg3_writephy(tp, MII_BMCR,
                                     BMCR_ANENABLE | BMCR_ANRESTART);
                }
-                tg3_phy_set_wirespeed(tp);
-                tg3_writephy(tp, MII_ADVERTISE, adv_reg);
-                if (!(tp->phy_flags & TG3_PHYFLG_10_100_ONLY))
-                        tg3_writephy(tp, MII_TG3_CTRL, tg3_ctrl);
        }
 skip_phy_reset:
@@ -12721,46 +12999,11 @@ static void __devinit tg3_read_vpd(struct tg3 *tp)
        u8 *vpd_data;
        unsigned int block_end, rosize, len;
        int j, i = 0;
-        u32 magic;
-        if ((tp->tg3_flags3 & TG3_FLG3_NO_NVRAM) ||
+        vpd_data = (u8 *)tg3_vpd_readblock(tp);
-            tg3_nvram_read(tp, 0x0, &magic))
-                goto out_no_vpd;
-        vpd_data = kmalloc(TG3_NVM_VPD_LEN, GFP_KERNEL);
        if (!vpd_data)
                goto out_no_vpd;
-        if (magic == TG3_EEPROM_MAGIC) {
-                for (i = 0; i < TG3_NVM_VPD_LEN; i += 4) {
-                        u32 tmp;
-                        /* The data is in little-endian format in NVRAM.
-                         * Use the big-endian read routines to preserve
-                         * the byte order as it exists in NVRAM.
-                         */
-                        if (tg3_nvram_read_be32(tp, TG3_NVM_VPD_OFF + i, &tmp))
-                                goto out_not_found;
-                        memcpy(&vpd_data[i], &tmp, sizeof(tmp));
-                }
-        } else {
-                ssize_t cnt;
-                unsigned int pos = 0;
-                for (; pos < TG3_NVM_VPD_LEN && i < 3; i++, pos += cnt) {
-                        cnt = pci_read_vpd(tp->pdev, pos,
-                                           TG3_NVM_VPD_LEN - pos,
-                                           &vpd_data[pos]);
-                        if (cnt == -ETIMEDOUT || cnt == -EINTR)
-                                cnt = 0;
-                        else if (cnt < 0)
-                                goto out_not_found;
-                }
-                if (pos != TG3_NVM_VPD_LEN)
-                        goto out_not_found;
-        }
        i = pci_vpd_find_tag(vpd_data, 0, TG3_NVM_VPD_LEN,
                             PCI_VPD_LRDT_RO_DATA);
        if (i < 0)
@@ -13014,7 +13257,7 @@ static void __devinit tg3_read_mgmtfw_ver(struct tg3 *tp)
        if (offset == TG3_NVM_DIR_END)
                return;
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+        if (!tg3_flag(tp, 5705_PLUS))
                start = 0x08000000;
        else if (tg3_nvram_read(tp, offset - 4, &start))
                return;
@@ -13054,8 +13297,7 @@ static void __devinit tg3_read_dash_ver(struct tg3 *tp)
        u32 apedata;
        char *fwtype;
-        if (!(tp->tg3_flags3 & TG3_FLG3_ENABLE_APE) ||
+        if (!tg3_flag(tp, ENABLE_APE) || !tg3_flag(tp, ENABLE_ASF))
-            !(tp->tg3_flags  & TG3_FLAG_ENABLE_ASF))
                return;
        apedata = tg3_ape_read32(tp, TG3_APE_SEG_SIG);
@@ -13069,7 +13311,7 @@ static void __devinit tg3_read_dash_ver(struct tg3 *tp)
        apedata = tg3_ape_read32(tp, TG3_APE_FW_VERSION);
        if (tg3_ape_read32(tp, TG3_APE_FW_FEATURES) & TG3_APE_FW_FEATURE_NCSI) {
-                tp->tg3_flags3 |= TG3_FLG3_APE_HAS_NCSI;
+                tg3_flag_set(tp, APE_HAS_NCSI);
                fwtype = "NCSI";
        } else {
                fwtype = "DASH";
@@ -13093,7 +13335,7 @@ static void __devinit tg3_read_fw_ver(struct tg3 *tp)
        if (tp->fw_ver[0] != 0)
                vpd_vers = true;
-        if (tp->tg3_flags3 & TG3_FLG3_NO_NVRAM) {
+        if (tg3_flag(tp, NO_NVRAM)) {
                strcat(tp->fw_ver, "sb");
                return;
        }
@@ -13110,8 +13352,7 @@ static void __devinit tg3_read_fw_ver(struct tg3 *tp)
        else
                return;
-        if (!(tp->tg3_flags & TG3_FLAG_ENABLE_ASF) ||
+        if (!tg3_flag(tp, ENABLE_ASF) || tg3_flag(tp, ENABLE_APE) || vpd_vers)
-             (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE) || vpd_vers)
                goto done;
        tg3_read_mgmtfw_ver(tp);
@@ -13122,21 +13363,14 @@ done:
 static struct pci_dev * __devinit tg3_find_peer(struct tg3 *);
-static inline void vlan_features_add(struct net_device *dev, unsigned long flags)
-{
-        dev->vlan_features |= flags;
-}
 static inline u32 tg3_rx_ret_ring_size(struct tg3 *tp)
 {
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+        if (tg3_flag(tp, LRG_PROD_RING_CAP))
-            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)
+                return TG3_RX_RET_MAX_SIZE_5717;
-                return 4096;
+        else if (tg3_flag(tp, JUMBO_CAPABLE) && !tg3_flag(tp, 5780_CLASS))
-        else if ((tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) &&
+                return TG3_RX_RET_MAX_SIZE_5700;
-                 !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS))
-                return 1024;
        else
-                return 512;
+                return TG3_RX_RET_MAX_SIZE_5705;
 }
 static DEFINE_PCI_DEVICE_TABLE(tg3_write_reorder_chipsets) = {
@@ -13181,7 +13415,8 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                if (tp->pdev->device == TG3PCI_DEVICE_TIGON3_5717 ||
                    tp->pdev->device == TG3PCI_DEVICE_TIGON3_5718 ||
-                    tp->pdev->device == TG3PCI_DEVICE_TIGON3_5719)
+                    tp->pdev->device == TG3PCI_DEVICE_TIGON3_5719 ||
+                    tp->pdev->device == TG3PCI_DEVICE_TIGON3_5720)
                        pci_read_config_dword(tp->pdev,
                                              TG3PCI_GEN2_PRODID_ASICREV,
                                              &prod_id_asic_rev);
@@ -13258,15 +13493,14 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                        if (bridge->subordinate &&
                            (bridge->subordinate->number ==
                             tp->pdev->bus->number)) {
+                                tg3_flag_set(tp, ICH_WORKAROUND);
-                                tp->tg3_flags2 |= TG3_FLG2_ICH_WORKAROUND;
                                pci_dev_put(bridge);
                                break;
                        }
                }
        }
-        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5701)) {
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5701) {
                static struct tg3_dev_id {
                        u32     vendor;
                        u32     device;
@@ -13291,7 +13525,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                             tp->pdev->bus->number) &&
                            (bridge->subordinate->subordinate >=
                             tp->pdev->bus->number)) {
-                                tp->tg3_flags3 |= TG3_FLG3_5701_DMA_BUG;
+                                tg3_flag_set(tp, 5701_DMA_BUG);
                                pci_dev_put(bridge);
                                break;
                        }
@@ -13306,8 +13540,8 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
         */
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5780 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5714) {
-                tp->tg3_flags2 |= TG3_FLG2_5780_CLASS;
+                tg3_flag_set(tp, 5780_CLASS);
-                tp->tg3_flags |= TG3_FLAG_40BIT_DMA_BUG;
+                tg3_flag_set(tp, 40BIT_DMA_BUG);
                tp->msi_cap = pci_find_capability(tp->pdev, PCI_CAP_ID_MSI);
        } else {
                struct pci_dev *bridge = NULL;
@@ -13321,7 +13555,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                             tp->pdev->bus->number) &&
                            (bridge->subordinate->subordinate >=
                             tp->pdev->bus->number)) {
-                                tp->tg3_flags |= TG3_FLAG_40BIT_DMA_BUG;
+                                tg3_flag_set(tp, 40BIT_DMA_BUG);
                                pci_dev_put(bridge);
                                break;
                        }
@@ -13336,13 +13570,18 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5714 ||
-            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717)
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720)
                tp->pdev_peer = tg3_find_peer(tp);
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719 ||
-            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57765)
+            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720)
-                tp->tg3_flags3 |= TG3_FLG3_5717_PLUS;
+                tg3_flag_set(tp, 5717_PLUS);
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57765 ||
+            tg3_flag(tp, 5717_PLUS))
+                tg3_flag_set(tp, 57765_PLUS);
        /* Intentionally exclude ASIC_REV_5906 */
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
@@ -13351,97 +13590,102 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5761 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780 ||
-            (tp->tg3_flags3 & TG3_FLG3_5717_PLUS))
+            tg3_flag(tp, 57765_PLUS))
-                tp->tg3_flags3 |= TG3_FLG3_5755_PLUS;
+                tg3_flag_set(tp, 5755_PLUS);
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5752 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906 ||
-            (tp->tg3_flags3 & TG3_FLG3_5755_PLUS) ||
+            tg3_flag(tp, 5755_PLUS) ||
-            (tp->tg3_flags2 & TG3_FLG2_5780_CLASS))
+            tg3_flag(tp, 5780_CLASS))
-                tp->tg3_flags2 |= TG3_FLG2_5750_PLUS;
+                tg3_flag_set(tp, 5750_PLUS);
-        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705) ||
-            (tp->tg3_flags2 & TG3_FLG2_5750_PLUS))
-                tp->tg3_flags2 |= TG3_FLG2_5705_PLUS;
-        /* 5700 B0 chips do not support checksumming correctly due
-         * to hardware bugs.
-         */
-        if (tp->pci_chip_rev_id == CHIPREV_ID_5700_B0)
-                tp->tg3_flags |= TG3_FLAG_BROKEN_CHECKSUMS;
-        else {
-                unsigned long features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_GRO;
-                tp->tg3_flags |= TG3_FLAG_RX_CHECKSUMS;
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705 ||
-                if (tp->tg3_flags3 & TG3_FLG3_5755_PLUS)
+            tg3_flag(tp, 5750_PLUS))
-                        features |= NETIF_F_IPV6_CSUM;
+                tg3_flag_set(tp, 5705_PLUS);
-                tp->dev->features |= features;
-                vlan_features_add(tp->dev, features);
-        }
        /* Determine TSO capabilities */
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)
                ; /* Do nothing. HW bug. */
-        else if (tp->tg3_flags3 & TG3_FLG3_5717_PLUS)
+        else if (tg3_flag(tp, 57765_PLUS))
-                tp->tg3_flags2 |= TG3_FLG2_HW_TSO_3;
+                tg3_flag_set(tp, HW_TSO_3);
-        else if ((tp->tg3_flags3 & TG3_FLG3_5755_PLUS) ||
+        else if (tg3_flag(tp, 5755_PLUS) ||
                 GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906)
-                tp->tg3_flags2 |= TG3_FLG2_HW_TSO_2;
+                tg3_flag_set(tp, HW_TSO_2);
-        else if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS) {
+        else if (tg3_flag(tp, 5750_PLUS)) {
-                tp->tg3_flags2 |= TG3_FLG2_HW_TSO_1 | TG3_FLG2_TSO_BUG;
+                tg3_flag_set(tp, HW_TSO_1);
+                tg3_flag_set(tp, TSO_BUG);
                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750 &&
                    tp->pci_chip_rev_id >= CHIPREV_ID_5750_C2)
-                        tp->tg3_flags2 &= ~TG3_FLG2_TSO_BUG;
+                        tg3_flag_clear(tp, TSO_BUG);
        } else if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700 &&
                   GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701 &&
                   tp->pci_chip_rev_id != CHIPREV_ID_5705_A0) {
-                tp->tg3_flags2 |= TG3_FLG2_TSO_BUG;
+                        tg3_flag_set(tp, TSO_BUG);
                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705)
                        tp->fw_needed = FIRMWARE_TG3TSO5;
                else
                        tp->fw_needed = FIRMWARE_TG3TSO;
        }
+        /* Selectively allow TSO based on operating conditions */
+        if (tg3_flag(tp, HW_TSO_1) ||
+            tg3_flag(tp, HW_TSO_2) ||
+            tg3_flag(tp, HW_TSO_3) ||
+            (tp->fw_needed && !tg3_flag(tp, ENABLE_ASF)))
+                tg3_flag_set(tp, TSO_CAPABLE);
+        else {
+                tg3_flag_clear(tp, TSO_CAPABLE);
+                tg3_flag_clear(tp, TSO_BUG);
+                tp->fw_needed = NULL;
+        }
+        if (tp->pci_chip_rev_id == CHIPREV_ID_5701_A0)
+                tp->fw_needed = FIRMWARE_TG3;
        tp->irq_max = 1;
-        if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS) {
+        if (tg3_flag(tp, 5750_PLUS)) {
-                tp->tg3_flags |= TG3_FLAG_SUPPORT_MSI;
+                tg3_flag_set(tp, SUPPORT_MSI);
                if (GET_CHIP_REV(tp->pci_chip_rev_id) == CHIPREV_5750_AX ||
                    GET_CHIP_REV(tp->pci_chip_rev_id) == CHIPREV_5750_BX ||
                    (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5714 &&
                     tp->pci_chip_rev_id <= CHIPREV_ID_5714_A2 &&
                     tp->pdev_peer == tp->pdev))
-                        tp->tg3_flags &= ~TG3_FLAG_SUPPORT_MSI;
+                        tg3_flag_clear(tp, SUPPORT_MSI);
-                if ((tp->tg3_flags3 & TG3_FLG3_5755_PLUS) ||
+                if (tg3_flag(tp, 5755_PLUS) ||
                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906) {
-                        tp->tg3_flags2 |= TG3_FLG2_1SHOT_MSI;
+                        tg3_flag_set(tp, 1SHOT_MSI);
                }
-                if (tp->tg3_flags3 & TG3_FLG3_5717_PLUS) {
+                if (tg3_flag(tp, 57765_PLUS)) {
-                        tp->tg3_flags |= TG3_FLAG_SUPPORT_MSIX;
+                        tg3_flag_set(tp, SUPPORT_MSIX);
                        tp->irq_max = TG3_IRQ_MAX_VECS;
                }
        }
-        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+        /* All chips can get confused if TX buffers
-            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719 ||
+         * straddle the 4GB address boundary.
-            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906)
+         */
-                tp->tg3_flags3 |= TG3_FLG3_SHORT_DMA_BUG;
+        tg3_flag_set(tp, 4G_DMA_BNDRY_BUG);
-        else if (!(tp->tg3_flags3 & TG3_FLG3_5755_PLUS)) {
-                tp->tg3_flags3 |= TG3_FLG3_4G_DMA_BNDRY_BUG;
+        if (tg3_flag(tp, 5755_PLUS))
-                tp->tg3_flags3 |= TG3_FLG3_40BIT_DMA_LIMIT_BUG;
+                tg3_flag_set(tp, SHORT_DMA_BUG);
-        }
+        else
+                tg3_flag_set(tp, 40BIT_DMA_LIMIT_BUG);
-        if ((tp->tg3_flags3 & TG3_FLG3_5717_PLUS) &&
+        if (tg3_flag(tp, 5717_PLUS))
+                tg3_flag_set(tp, LRG_PROD_RING_CAP);
+        if (tg3_flag(tp, 57765_PLUS) &&
            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5719)
-                tp->tg3_flags3 |= TG3_FLG3_USE_JUMBO_BDFLAG;
+                tg3_flag_set(tp, USE_JUMBO_BDFLAG);
-        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS) ||
+        if (!tg3_flag(tp, 5705_PLUS) ||
-            (tp->tg3_flags2 & TG3_FLG2_5780_CLASS) ||
+            tg3_flag(tp, 5780_CLASS) ||
-            (tp->tg3_flags3 & TG3_FLG3_USE_JUMBO_BDFLAG))
+            tg3_flag(tp, USE_JUMBO_BDFLAG))
-                tp->tg3_flags |= TG3_FLAG_JUMBO_CAPABLE;
+                tg3_flag_set(tp, JUMBO_CAPABLE);
        pci_read_config_dword(tp->pdev, TG3PCI_PCISTATE,
                              &pci_state_reg);
@@ -13450,10 +13694,11 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        if (tp->pcie_cap != 0) {
                u16 lnkctl;
-                tp->tg3_flags2 |= TG3_FLG2_PCI_EXPRESS;
+                tg3_flag_set(tp, PCI_EXPRESS);
                tp->pcie_readrq = 4096;
-                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719)
+                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719 ||
+                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720)
                        tp->pcie_readrq = 2048;
                pcie_set_readrq(tp->pdev, tp->pcie_readrq);
@@ -13462,20 +13707,23 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                                     tp->pcie_cap + PCI_EXP_LNKCTL,
                                     &lnkctl);
                if (lnkctl & PCI_EXP_LNKCTL_CLKREQ_EN) {
-                        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906)
+                        if (GET_ASIC_REV(tp->pci_chip_rev_id) ==
-                                tp->tg3_flags2 &= ~TG3_FLG2_HW_TSO_2;
+                            ASIC_REV_5906) {
+                                tg3_flag_clear(tp, HW_TSO_2);
+                                tg3_flag_clear(tp, TSO_CAPABLE);
+                        }
                        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5784 ||
                            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5761 ||
                            tp->pci_chip_rev_id == CHIPREV_ID_57780_A0 ||
                            tp->pci_chip_rev_id == CHIPREV_ID_57780_A1)
-                                tp->tg3_flags3 |= TG3_FLG3_CLKREQ_BUG;
+                                tg3_flag_set(tp, CLKREQ_BUG);
                } else if (tp->pci_chip_rev_id == CHIPREV_ID_5717_A0) {
-                        tp->tg3_flags3 |= TG3_FLG3_L1PLLPD_EN;
+                        tg3_flag_set(tp, L1PLLPD_EN);
                }
        } else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785) {
-                tp->tg3_flags2 |= TG3_FLG2_PCI_EXPRESS;
+                tg3_flag_set(tp, PCI_EXPRESS);
-        } else if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS) ||
+        } else if (!tg3_flag(tp, 5705_PLUS) ||
-                   (tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) {
+                   tg3_flag(tp, 5780_CLASS)) {
                tp->pcix_cap = pci_find_capability(tp->pdev, PCI_CAP_ID_PCIX);
                if (!tp->pcix_cap) {
                        dev_err(&tp->pdev->dev,
@@ -13484,7 +13732,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                }
                if (!(pci_state_reg & PCISTATE_CONV_PCI_MODE))
-                        tp->tg3_flags |= TG3_FLAG_PCIX_MODE;
+                        tg3_flag_set(tp, PCIX_MODE);
        }
        /* If we have an AMD 762 or VIA K8T800 chipset, write
@@ -13494,8 +13742,8 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
         * posted to the chip in order.
         */
        if (pci_dev_present(tg3_write_reorder_chipsets) &&
-            !(tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS))
+            !tg3_flag(tp, PCI_EXPRESS))
-                tp->tg3_flags |= TG3_FLAG_MBOX_WRITE_REORDER;
+                tg3_flag_set(tp, MBOX_WRITE_REORDER);
        pci_read_config_byte(tp->pdev, PCI_CACHE_LINE_SIZE,
                             &tp->pci_cacheline_sz);
@@ -13512,17 +13760,17 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                /* 5700 BX chips need to have their TX producer index
                 * mailboxes written twice to workaround a bug.
                 */
-                tp->tg3_flags |= TG3_FLAG_TXD_MBOX_HWBUG;
+                tg3_flag_set(tp, TXD_MBOX_HWBUG);
                /* If we are in PCI-X mode, enable register write workaround.
                 *
                 * The workaround is to use indirect register accesses
                 * for all chip writes not to mailbox registers.
                 */
-                if (tp->tg3_flags & TG3_FLAG_PCIX_MODE) {
+                if (tg3_flag(tp, PCIX_MODE)) {
                        u32 pm_reg;
-                        tp->tg3_flags |= TG3_FLAG_PCIX_TARGET_HWBUG;
+                        tg3_flag_set(tp, PCIX_TARGET_HWBUG);
                        /* The chip can have it's power management PCI config
                         * space registers clobbered due to this bug.
@@ -13545,9 +13793,9 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        }
        if ((pci_state_reg & PCISTATE_BUS_SPEED_HIGH) != 0)
-                tp->tg3_flags |= TG3_FLAG_PCI_HIGH_SPEED;
+                tg3_flag_set(tp, PCI_HIGH_SPEED);
        if ((pci_state_reg & PCISTATE_BUS_32BIT) != 0)
-                tp->tg3_flags |= TG3_FLAG_PCI_32BIT;
+                tg3_flag_set(tp, PCI_32BIT);
        /* Chip-specific fixup from Broadcom driver */
        if ((tp->pci_chip_rev_id == CHIPREV_ID_5704_A0) &&
@@ -13565,10 +13813,10 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        tp->write32_rx_mbox = tg3_write32;
        /* Various workaround register access methods */
-        if (tp->tg3_flags & TG3_FLAG_PCIX_TARGET_HWBUG)
+        if (tg3_flag(tp, PCIX_TARGET_HWBUG))
                tp->write32 = tg3_write_indirect_reg32;
        else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5701 ||
-                 ((tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS) &&
+                 (tg3_flag(tp, PCI_EXPRESS) &&
                  tp->pci_chip_rev_id == CHIPREV_ID_5750_A0)) {
                /*
                 * Back to back register writes can cause problems on these
@@ -13580,14 +13828,13 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                tp->write32 = tg3_write_flush_reg32;
        }
-        if ((tp->tg3_flags & TG3_FLAG_TXD_MBOX_HWBUG) ||
+        if (tg3_flag(tp, TXD_MBOX_HWBUG) || tg3_flag(tp, MBOX_WRITE_REORDER)) {
-            (tp->tg3_flags & TG3_FLAG_MBOX_WRITE_REORDER)) {
                tp->write32_tx_mbox = tg3_write32_tx_mbox;
-                if (tp->tg3_flags & TG3_FLAG_MBOX_WRITE_REORDER)
+                if (tg3_flag(tp, MBOX_WRITE_REORDER))
                        tp->write32_rx_mbox = tg3_write_flush_reg32;
        }
-        if (tp->tg3_flags2 & TG3_FLG2_ICH_WORKAROUND) {
+        if (tg3_flag(tp, ICH_WORKAROUND)) {
                tp->read32 = tg3_read_indirect_reg32;
                tp->write32 = tg3_write_indirect_reg32;
                tp->read32_mbox = tg3_read_indirect_mbox;
@@ -13610,13 +13857,13 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        }
        if (tp->write32 == tg3_write_indirect_reg32 ||
-            ((tp->tg3_flags & TG3_FLAG_PCIX_MODE) &&
+            (tg3_flag(tp, PCIX_MODE) &&
             (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700 ||
              GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5701)))
-                tp->tg3_flags |= TG3_FLAG_SRAM_USE_CONFIG;
+                tg3_flag_set(tp, SRAM_USE_CONFIG);
        /* Get eeprom hw config before calling tg3_set_power_state().
-         * In particular, the TG3_FLG2_IS_NIC flag must be
+         * In particular, the TG3_FLAG_IS_NIC flag must be
         * determined before calling tg3_set_power_state() so that
         * we know whether or not to switch out of Vaux power.
         * When the flag is set, it means that GPIO1 is used for eeprom
@@ -13625,7 +13872,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
         */
        tg3_get_eeprom_hw_cfg(tp);
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE) {
+        if (tg3_flag(tp, ENABLE_APE)) {
                /* Allow reads and writes to the
                 * APE register and memory space.
                 */
@@ -13640,16 +13887,16 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5761 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780 ||
-            (tp->tg3_flags3 & TG3_FLG3_5717_PLUS))
+            tg3_flag(tp, 57765_PLUS))
-                tp->tg3_flags |= TG3_FLAG_CPMU_PRESENT;
+                tg3_flag_set(tp, CPMU_PRESENT);
-        /* Set up tp->grc_local_ctrl before calling tg_power_up().
+        /* Set up tp->grc_local_ctrl before calling tg3_power_up().
         * GPIO1 driven high will bring 5700's external PHY out of reset.
         * It is also used as eeprom write protect on LOMs.
         */
        tp->grc_local_ctrl = GRC_LCLCTRL_INT_ON_ATTN | GRC_LCLCTRL_AUTO_SEEPROM;
-        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700) ||
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700 ||
-            (tp->tg3_flags & TG3_FLAG_EEPROM_WRITE_PROT))
+            tg3_flag(tp, EEPROM_WRITE_PROT))
                tp->grc_local_ctrl |= (GRC_LCLCTRL_GPIO_OE1 |
                                       GRC_LCLCTRL_GPIO_OUTPUT1);
        /* Unused GPIO3 must be driven as output on 5752 because there
@@ -13667,7 +13914,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
            tp->pdev->device == TG3PCI_DEVICE_TIGON3_5761S) {
                /* Turn off the debug UART. */
                tp->grc_local_ctrl |= GRC_LCLCTRL_GPIO_UART_SEL;
-                if (tp->tg3_flags2 & TG3_FLG2_IS_NIC)
+                if (tg3_flag(tp, IS_NIC))
                        /* Keep VMain power. */
                        tp->grc_local_ctrl |= GRC_LCLCTRL_GPIO_OE0 |
                                              GRC_LCLCTRL_GPIO_OUTPUT0;
@@ -13683,26 +13930,25 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        /* Derive initial jumbo mode from MTU assigned in
         * ether_setup() via the alloc_etherdev() call
         */
-        if (tp->dev->mtu > ETH_DATA_LEN &&
+        if (tp->dev->mtu > ETH_DATA_LEN && !tg3_flag(tp, 5780_CLASS))
-            !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS))
+                tg3_flag_set(tp, JUMBO_RING_ENABLE);
-                tp->tg3_flags |= TG3_FLAG_JUMBO_RING_ENABLE;
        /* Determine WakeOnLan speed to use. */
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700 ||
            tp->pci_chip_rev_id == CHIPREV_ID_5701_A0 ||
            tp->pci_chip_rev_id == CHIPREV_ID_5701_B0 ||
            tp->pci_chip_rev_id == CHIPREV_ID_5701_B2) {
-                tp->tg3_flags &= ~(TG3_FLAG_WOL_SPEED_100MB);
+                tg3_flag_clear(tp, WOL_SPEED_100MB);
        } else {
-                tp->tg3_flags |= TG3_FLAG_WOL_SPEED_100MB;
+                tg3_flag_set(tp, WOL_SPEED_100MB);
        }
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906)
                tp->phy_flags |= TG3_PHYFLG_IS_FET;
        /* A few boards don't want Ethernet@WireSpeed phy feature */
-        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700) ||
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700 ||
-            ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705) &&
+            (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705 &&
             (tp->pci_chip_rev_id != CHIPREV_ID_5705_A0) &&
             (tp->pci_chip_rev_id != CHIPREV_ID_5705_A1)) ||
            (tp->phy_flags & TG3_PHYFLG_IS_FET) ||
@@ -13715,11 +13961,11 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        if (tp->pci_chip_rev_id == CHIPREV_ID_5704_A0)
                tp->phy_flags |= TG3_PHYFLG_5704_A0_BUG;
-        if ((tp->tg3_flags2 & TG3_FLG2_5705_PLUS) &&
+        if (tg3_flag(tp, 5705_PLUS) &&
            !(tp->phy_flags & TG3_PHYFLG_IS_FET) &&
            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5785 &&
            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_57780 &&
-            !(tp->tg3_flags3 & TG3_FLG3_5717_PLUS)) {
+            !tg3_flag(tp, 57765_PLUS)) {
                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755 ||
                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5787 ||
                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5784 ||
@@ -13740,7 +13986,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                        tp->phy_otp = TG3_OTP_DEFAULT;
        }
-        if (tp->tg3_flags & TG3_FLAG_CPMU_PRESENT)
+        if (tg3_flag(tp, CPMU_PRESENT))
                tp->mi_mode = MAC_MI_MODE_500KHZ_CONST;
        else
                tp->mi_mode = MAC_MI_MODE_BASE;
@@ -13750,9 +13996,17 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
            GET_CHIP_REV(tp->pci_chip_rev_id) != CHIPREV_5700_BX)
                tp->coalesce_mode |= HOSTCC_MODE_32BYTE;
+        /* Set these bits to enable statistics workaround. */
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+            tp->pci_chip_rev_id == CHIPREV_ID_5719_A0 ||
+            tp->pci_chip_rev_id == CHIPREV_ID_5720_A0) {
+                tp->coalesce_mode |= HOSTCC_MODE_ATTN;
+                tp->grc_mode |= GRC_MODE_IRQ_ON_FLOW_ATTN;
+        }
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780)
-                tp->tg3_flags3 |= TG3_FLG3_USE_PHYLIB;
+                tg3_flag_set(tp, USE_PHYLIB);
        err = tg3_mdio_init(tp);
        if (err)
@@ -13760,7 +14014,15 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        /* Initialize data/descriptor byte/word swapping. */
        val = tr32(GRC_MODE);
-        val &= GRC_MODE_HOST_STACKUP;
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5720)
+                val &= (GRC_MODE_BYTE_SWAP_B2HRX_DATA |
+                        GRC_MODE_WORD_SWAP_B2HRX_DATA |
+                        GRC_MODE_B2HRX_ENABLE |
+                        GRC_MODE_HTX2B_ENABLE |
+                        GRC_MODE_HOST_STACKUP);
+        else
+                val &= GRC_MODE_HOST_STACKUP;
        tw32(GRC_MODE, val | tp->grc_mode);
        tg3_switch_clocks(tp);
@@ -13771,7 +14033,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        pci_read_config_dword(tp->pdev, TG3PCI_PCISTATE,
                              &pci_state_reg);
        if ((pci_state_reg & PCISTATE_CONV_PCI_MODE) == 0 &&
-            (tp->tg3_flags & TG3_FLAG_PCIX_TARGET_HWBUG) == 0) {
+            !tg3_flag(tp, PCIX_TARGET_HWBUG)) {
                u32 chiprevid = GET_CHIP_REV_ID(tp->misc_host_ctrl);
                if (chiprevid == CHIPREV_ID_5701_A0 ||
@@ -13790,7 +14052,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
                        writel(0x00000000, sram_base + 4);
                        writel(0xffffffff, sram_base + 4);
                        if (readl(sram_base) != 0x00000000)
-                                tp->tg3_flags |= TG3_FLAG_PCIX_TARGET_HWBUG;
+                                tg3_flag_set(tp, PCIX_TARGET_HWBUG);
                }
        }
@@ -13803,12 +14065,12 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705 &&
            (grc_misc_cfg == GRC_MISC_CFG_BOARD_ID_5788 ||
             grc_misc_cfg == GRC_MISC_CFG_BOARD_ID_5788M))
-                tp->tg3_flags2 |= TG3_FLG2_IS_5788;
+                tg3_flag_set(tp, IS_5788);
-        if (!(tp->tg3_flags2 & TG3_FLG2_IS_5788) &&
+        if (!tg3_flag(tp, IS_5788) &&
-            (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700))
+            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700)
-                tp->tg3_flags |= TG3_FLAG_TAGGED_STATUS;
+                tg3_flag_set(tp, TAGGED_STATUS);
-        if (tp->tg3_flags & TG3_FLAG_TAGGED_STATUS) {
+        if (tg3_flag(tp, TAGGED_STATUS)) {
                tp->coalesce_mode |= (HOSTCC_MODE_CLRTICK_RXBD |
                                      HOSTCC_MODE_CLRTICK_TXBD);
@@ -13818,7 +14080,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
        }
        /* Preserve the APE MAC_MODE bits */
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)
+        if (tg3_flag(tp, ENABLE_APE))
                tp->mac_mode = MAC_MODE_APE_TX_EN | MAC_MODE_APE_RX_EN;
        else
                tp->mac_mode = TG3_DEF_MAC_MODE;
@@ -13865,9 +14127,9 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
         * status register in those cases.
         */
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700)
-                tp->tg3_flags |= TG3_FLAG_USE_LINKCHG_REG;
+                tg3_flag_set(tp, USE_LINKCHG_REG);
        else
-                tp->tg3_flags &= ~TG3_FLAG_USE_LINKCHG_REG;
+                tg3_flag_clear(tp, USE_LINKCHG_REG);
        /* The led_ctrl is set during tg3_phy_probe, here we might
         * have to force the link status polling mechanism based
@@ -13877,19 +14139,19 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5701 &&
            !(tp->phy_flags & TG3_PHYFLG_PHY_SERDES)) {
                tp->phy_flags |= TG3_PHYFLG_USE_MI_INTERRUPT;
-                tp->tg3_flags |= TG3_FLAG_USE_LINKCHG_REG;
+                tg3_flag_set(tp, USE_LINKCHG_REG);
        }
        /* For all SERDES we poll the MAC status register. */
        if (tp->phy_flags & TG3_PHYFLG_PHY_SERDES)
-                tp->tg3_flags |= TG3_FLAG_POLL_SERDES;
+                tg3_flag_set(tp, POLL_SERDES);
        else
-                tp->tg3_flags &= ~TG3_FLAG_POLL_SERDES;
+                tg3_flag_clear(tp, POLL_SERDES);
        tp->rx_offset = NET_IP_ALIGN;
        tp->rx_copy_thresh = TG3_RX_COPY_THRESHOLD;
        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5701 &&
-            (tp->tg3_flags & TG3_FLAG_PCIX_MODE) != 0) {
+            tg3_flag(tp, PCIX_MODE)) {
                tp->rx_offset = 0;
 #ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
                tp->rx_copy_thresh = ~(u16)0;
@@ -13910,7 +14172,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755)
                tp->rx_std_max_post = 8;
-        if (tp->tg3_flags & TG3_FLAG_ASPM_WORKAROUND)
+        if (tg3_flag(tp, ASPM_WORKAROUND))
                tp->pwrmgmt_thresh = tr32(PCIE_PWR_MGMT_THRESH) &
                                     PCIE_PWR_MGMT_L1_THRESH_MSK;
@@ -13957,16 +14219,15 @@ static int __devinit tg3_get_device_address(struct tg3 *tp)
 #endif
        mac_offset = 0x7c;
-        if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704) ||
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704 ||
-            (tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) {
+            tg3_flag(tp, 5780_CLASS)) {
                if (tr32(TG3PCI_DUAL_MAC_CTRL) & DUAL_MAC_CTRL_ID)
                        mac_offset = 0xcc;
                if (tg3_nvram_lock(tp))
                        tw32_f(NVRAM_CMD, NVRAM_CMD_RESET);
                else
                        tg3_nvram_unlock(tp);
-        } else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 ||
+        } else if (tg3_flag(tp, 5717_PLUS)) {
-                   GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) {
                if (PCI_FUNC(tp->pdev->devfn) & 1)
                        mac_offset = 0xcc;
                if (PCI_FUNC(tp->pdev->devfn) > 1)
@@ -13991,7 +14252,7 @@ static int __devinit tg3_get_device_address(struct tg3 *tp)
        }
        if (!addr_ok) {
                /* Next, try NVRAM. */
-                if (!(tp->tg3_flags3 & TG3_FLG3_NO_NVRAM) &&
+                if (!tg3_flag(tp, NO_NVRAM) &&
                    !tg3_nvram_read_be32(tp, mac_offset + 0, &hi) &&
                    !tg3_nvram_read_be32(tp, mac_offset + 4, &lo)) {
                        memcpy(&dev->dev_addr[0], ((char *)&hi) + 2, 2);
@@ -14042,7 +14303,7 @@ static u32 __devinit tg3_calc_dma_bndry(struct tg3 *tp, u32 val)
         */
        if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700 &&
            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701 &&
-            !(tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS))
+            !tg3_flag(tp, PCI_EXPRESS))
                goto out;
 #if defined(CONFIG_PPC64) || defined(CONFIG_IA64) || defined(CONFIG_PARISC)
@@ -14055,7 +14316,7 @@ static u32 __devinit tg3_calc_dma_bndry(struct tg3 *tp, u32 val)
 #endif
 #endif
-        if (tp->tg3_flags3 & TG3_FLG3_5717_PLUS) {
+        if (tg3_flag(tp, 57765_PLUS)) {
                val = goal ? 0 : DMA_RWCTRL_DIS_CACHE_ALIGNMENT;
                goto out;
        }
@@ -14074,8 +14335,7 @@ static u32 __devinit tg3_calc_dma_bndry(struct tg3 *tp, u32 val)
         * other than 5700 and 5701 which do not implement the
         * boundary bits.
         */
-        if ((tp->tg3_flags & TG3_FLAG_PCIX_MODE) &&
+        if (tg3_flag(tp, PCIX_MODE) && !tg3_flag(tp, PCI_EXPRESS)) {
-            !(tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS)) {
                switch (cacheline_size) {
                case 16:
                case 32:
@@ -14100,7 +14360,7 @@ static u32 __devinit tg3_calc_dma_bndry(struct tg3 *tp, u32 val)
                                DMA_RWCTRL_WRITE_BNDRY_384_PCIX);
                        break;
                }
-        } else if (tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS) {
+        } else if (tg3_flag(tp, PCI_EXPRESS)) {
                switch (cacheline_size) {
                case 16:
                case 32:
@@ -14272,13 +14532,13 @@ static int __devinit tg3_test_dma(struct tg3 *tp)
        tp->dma_rwctrl = tg3_calc_dma_bndry(tp, tp->dma_rwctrl);
-        if (tp->tg3_flags3 & TG3_FLG3_5717_PLUS)
+        if (tg3_flag(tp, 57765_PLUS))
                goto out;
-        if (tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS) {
+        if (tg3_flag(tp, PCI_EXPRESS)) {
                /* DMA read watermark not used on PCIE */
                tp->dma_rwctrl |= 0x00180000;
-        } else if (!(tp->tg3_flags & TG3_FLAG_PCIX_MODE)) {
+        } else if (!tg3_flag(tp, PCIX_MODE)) {
                if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705 ||
                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750)
                        tp->dma_rwctrl |= 0x003f0000;
@@ -14294,7 +14554,7 @@ static int __devinit tg3_test_dma(struct tg3 *tp)
                         * do the less restrictive ONE_DMA workaround for
                         * better performance.
                         */
-                        if ((tp->tg3_flags & TG3_FLAG_40BIT_DMA_BUG) &&
+                        if (tg3_flag(tp, 40BIT_DMA_BUG) &&
                            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704)
                                tp->dma_rwctrl |= 0x8000;
                        else if (ccval == 0x6 || ccval == 0x7)
@@ -14423,7 +14683,6 @@ static int __devinit tg3_test_dma(struct tg3 *tp)
        }
        if ((tp->dma_rwctrl & DMA_RWCTRL_WRITE_BNDRY_MASK) !=
            DMA_RWCTRL_WRITE_BNDRY_16) {
                /* DMA test passed without adjusting DMA boundary,
                 * now look for chipsets that are known to expose the
                 * DMA bug without failing the test.
@@ -14447,7 +14706,7 @@ out_nofree:
 static void __devinit tg3_init_bufmgr_config(struct tg3 *tp)
 {
-        if (tp->tg3_flags3 & TG3_FLG3_5717_PLUS) {
+        if (tg3_flag(tp, 57765_PLUS)) {
                tp->bufmgr_config.mbuf_read_dma_low_water =
                        DEFAULT_MB_RDMA_LOW_WATER_5705;
                tp->bufmgr_config.mbuf_mac_rx_low_water =
@@ -14461,7 +14720,7 @@ static void __devinit tg3_init_bufmgr_config(struct tg3 *tp)
                        DEFAULT_MB_MACRX_LOW_WATER_JUMBO_57765;
                tp->bufmgr_config.mbuf_high_water_jumbo =
                        DEFAULT_MB_HIGH_WATER_JUMBO_57765;
-        } else if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS) {
+        } else if (tg3_flag(tp, 5705_PLUS)) {
                tp->bufmgr_config.mbuf_read_dma_low_water =
                        DEFAULT_MB_RDMA_LOW_WATER_5705;
                tp->bufmgr_config.mbuf_mac_rx_low_water =
@@ -14525,6 +14784,7 @@ static char * __devinit tg3_phy_string(struct tg3 *tp)
        case TG3_PHY_ID_BCM5718S:       return "5718S";
        case TG3_PHY_ID_BCM57765:       return "57765";
        case TG3_PHY_ID_BCM5719C:       return "5719C";
+        case TG3_PHY_ID_BCM5720C:       return "5720C";
        case TG3_PHY_ID_BCM8002:        return "8002/serdes";
        case 0:                 return "serdes";
        default:                return "unknown";
@@ -14533,10 +14793,10 @@ static char * __devinit tg3_phy_string(struct tg3 *tp)
 static char * __devinit tg3_bus_string(struct tg3 *tp, char *str)
 {
-        if (tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS) {
+        if (tg3_flag(tp, PCI_EXPRESS)) {
                strcpy(str, "PCI Express");
                return str;
-        } else if (tp->tg3_flags & TG3_FLAG_PCIX_MODE) {
+        } else if (tg3_flag(tp, PCIX_MODE)) {
                u32 clock_ctrl = tr32(TG3PCI_CLOCK_CTRL) & 0x1f;
                strcpy(str, "PCIX:");
@@ -14555,12 +14815,12 @@ static char * __devinit tg3_bus_string(struct tg3 *tp, char *str)
                        strcat(str, "100MHz");
        } else {
                strcpy(str, "PCI:");
-                if (tp->tg3_flags & TG3_FLAG_PCI_HIGH_SPEED)
+                if (tg3_flag(tp, PCI_HIGH_SPEED))
                        strcat(str, "66MHz");
                else
                        strcat(str, "33MHz");
        }
-        if (tp->tg3_flags & TG3_FLAG_PCI_32BIT)
+        if (tg3_flag(tp, PCI_32BIT))
                strcat(str, ":32-bit");
        else
                strcat(str, ":64-bit");
@@ -14619,7 +14879,7 @@ static void __devinit tg3_init_coal(struct tg3 *tp)
                ec->tx_coalesce_usecs_irq = DEFAULT_TXCOAL_TICK_INT_CLRTCKS;
        }
-        if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS) {
+        if (tg3_flag(tp, 5705_PLUS)) {
                ec->rx_coalesce_usecs_irq = 0;
                ec->tx_coalesce_usecs_irq = 0;
                ec->stats_block_coalesce_usecs = 0;
@@ -14637,22 +14897,8 @@ static const struct net_device_ops tg3_netdev_ops = {
        .ndo_do_ioctl           = tg3_ioctl,
        .ndo_tx_timeout         = tg3_tx_timeout,
        .ndo_change_mtu         = tg3_change_mtu,
-#ifdef CONFIG_NET_POLL_CONTROLLER
+        .ndo_fix_features       = tg3_fix_features,
-        .ndo_poll_controller    = tg3_poll_controller,
+        .ndo_set_features       = tg3_set_features,
-#endif
-};
-static const struct net_device_ops tg3_netdev_ops_dma_bug = {
-        .ndo_open               = tg3_open,
-        .ndo_stop               = tg3_close,
-        .ndo_start_xmit         = tg3_start_xmit_dma_bug,
-        .ndo_get_stats64        = tg3_get_stats64,
-        .ndo_validate_addr      = eth_validate_addr,
-        .ndo_set_multicast_list = tg3_set_rx_mode,
-        .ndo_set_mac_address    = tg3_set_mac_addr,
-        .ndo_do_ioctl           = tg3_ioctl,
-        .ndo_tx_timeout         = tg3_tx_timeout,
-        .ndo_change_mtu         = tg3_change_mtu,
 #ifdef CONFIG_NET_POLL_CONTROLLER
        .ndo_poll_controller    = tg3_poll_controller,
 #endif
@@ -14667,6 +14913,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
        u32 sndmbx, rcvmbx, intmbx;
        char str[40];
        u64 dma_mask, persist_dma_mask;
+        u32 features = 0;
        printk_once(KERN_INFO "%s\n", version);
@@ -14702,8 +14949,6 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
        SET_NETDEV_DEV(dev, &pdev->dev);
-        dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
        tp = netdev_priv(dev);
        tp->pdev = pdev;
        tp->dev = dev;
@@ -14753,6 +14998,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
        dev->ethtool_ops = &tg3_ethtool_ops;
        dev->watchdog_timeo = TG3_TX_TIMEOUT;
+        dev->netdev_ops = &tg3_netdev_ops;
        dev->irq = pdev->irq;
        err = tg3_get_invariants(tp);
@@ -14762,23 +15008,15 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
                goto err_out_iounmap;
        }
-        if ((tp->tg3_flags3 & TG3_FLG3_5755_PLUS) &&
-            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5717 &&
-            GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5719)
-                dev->netdev_ops = &tg3_netdev_ops;
-        else
-                dev->netdev_ops = &tg3_netdev_ops_dma_bug;
        /* The EPB bridge inside 5714, 5715, and 5780 and any
         * device behind the EPB cannot support DMA addresses > 40-bit.
         * On 64-bit systems with IOMMU, use 40-bit dma_mask.
         * On 64-bit systems without IOMMU, use 64-bit dma_mask and
         * do DMA address check in tg3_start_xmit().
         */
-        if (tp->tg3_flags2 & TG3_FLG2_IS_5788)
+        if (tg3_flag(tp, IS_5788))
                persist_dma_mask = dma_mask = DMA_BIT_MASK(32);
-        else if (tp->tg3_flags & TG3_FLAG_40BIT_DMA_BUG) {
+        else if (tg3_flag(tp, 40BIT_DMA_BUG)) {
                persist_dma_mask = dma_mask = DMA_BIT_MASK(40);
 #ifdef CONFIG_HIGHMEM
                dma_mask = DMA_BIT_MASK(64);
@@ -14790,7 +15028,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
        if (dma_mask > DMA_BIT_MASK(32)) {
                err = pci_set_dma_mask(pdev, dma_mask);
                if (!err) {
-                        dev->features |= NETIF_F_HIGHDMA;
+                        features |= NETIF_F_HIGHDMA;
                        err = pci_set_consistent_dma_mask(pdev,
                                                          persist_dma_mask);
                        if (err < 0) {
@@ -14811,48 +15049,58 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
        tg3_init_bufmgr_config(tp);
-        /* Selectively allow TSO based on operating conditions */
+        features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
-        if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO) ||
-            (tp->fw_needed && !(tp->tg3_flags & TG3_FLAG_ENABLE_ASF)))
-                tp->tg3_flags2 |= TG3_FLG2_TSO_CAPABLE;
-        else {
-                tp->tg3_flags2 &= ~(TG3_FLG2_TSO_CAPABLE | TG3_FLG2_TSO_BUG);
-                tp->fw_needed = NULL;
-        }
-        if (tp->pci_chip_rev_id == CHIPREV_ID_5701_A0)
+        /* 5700 B0 chips do not support checksumming correctly due
-                tp->fw_needed = FIRMWARE_TG3;
+         * to hardware bugs.
+         */
+        if (tp->pci_chip_rev_id != CHIPREV_ID_5700_B0) {
+                features |= NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_RXCSUM;
+                if (tg3_flag(tp, 5755_PLUS))
+                        features |= NETIF_F_IPV6_CSUM;
+        }
        /* TSO is on by default on chips that support hardware TSO.
         * Firmware TSO on older chips gives lower performance, so it
         * is off by default, but can be enabled using ethtool.
         */
-        if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO) &&
+        if ((tg3_flag(tp, HW_TSO_1) ||
-            (dev->features & NETIF_F_IP_CSUM)) {
+             tg3_flag(tp, HW_TSO_2) ||
-                dev->features |= NETIF_F_TSO;
+             tg3_flag(tp, HW_TSO_3)) &&
-                vlan_features_add(dev, NETIF_F_TSO);
+            (features & NETIF_F_IP_CSUM))
-        }
+                features |= NETIF_F_TSO;
-        if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO_2) ||
+        if (tg3_flag(tp, HW_TSO_2) || tg3_flag(tp, HW_TSO_3)) {
-            (tp->tg3_flags2 & TG3_FLG2_HW_TSO_3)) {
+                if (features & NETIF_F_IPV6_CSUM)
-                if (dev->features & NETIF_F_IPV6_CSUM) {
+                        features |= NETIF_F_TSO6;
-                        dev->features |= NETIF_F_TSO6;
+                if (tg3_flag(tp, HW_TSO_3) ||
-                        vlan_features_add(dev, NETIF_F_TSO6);
-                }
-                if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO_3) ||
                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5761 ||
                    (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5784 &&
                     GET_CHIP_REV(tp->pci_chip_rev_id) != CHIPREV_5784_AX) ||
-                        GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785 ||
+                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785 ||
-                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780) {
+                    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780)
-                        dev->features |= NETIF_F_TSO_ECN;
+                        features |= NETIF_F_TSO_ECN;
-                        vlan_features_add(dev, NETIF_F_TSO_ECN);
-                }
        }
+        dev->features |= features;
+        dev->vlan_features |= features;
+        /*
+         * Add loopback capability only for a subset of devices that support
+         * MAC-LOOPBACK. Eventually this need to be enhanced to allow INT-PHY
+         * loopback for the remaining devices.
+         */
+        if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5780 &&
+            !tg3_flag(tp, CPMU_PRESENT))
+                /* Add the loopback capability */
+                features |= NETIF_F_LOOPBACK;
+        dev->hw_features |= features;
        if (tp->pci_chip_rev_id == CHIPREV_ID_5705_A1 &&
-            !(tp->tg3_flags2 & TG3_FLG2_TSO_CAPABLE) &&
+            !tg3_flag(tp, TSO_CAPABLE) &&
            !(tr32(TG3PCI_PCISTATE) & PCISTATE_BUS_SPEED_HIGH)) {
-                tp->tg3_flags2 |= TG3_FLG2_MAX_RXPEND_64;
+                tg3_flag_set(tp, MAX_RXPEND_64);
                tp->rx_pending = 63;
        }
@@ -14863,7 +15111,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
                goto err_out_iounmap;
        }
-        if (tp->tg3_flags3 & TG3_FLG3_ENABLE_APE) {
+        if (tg3_flag(tp, ENABLE_APE)) {
                tp->aperegs = pci_ioremap_bar(pdev, BAR_2);
                if (!tp->aperegs) {
                        dev_err(&pdev->dev,
@@ -14874,7 +15122,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
                tg3_ape_lock_init(tp);
-                if (tp->tg3_flags & TG3_FLAG_ENABLE_ASF)
+                if (tg3_flag(tp, ENABLE_ASF))
                        tg3_read_dash_ver(tp);
        }
@@ -14918,7 +15166,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
                else
                        tnapi->coal_now = HOSTCC_MODE_NOW;
-                if (!(tp->tg3_flags & TG3_FLAG_SUPPORT_MSIX))
+                if (!tg3_flag(tp, SUPPORT_MSIX))
                        break;
                /*
@@ -14972,21 +15220,25 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
                        ethtype = "10/100/1000Base-T";
                netdev_info(dev, "attached PHY is %s (%s Ethernet) "
-                            "(WireSpeed[%d])\n", tg3_phy_string(tp), ethtype,
+                            "(WireSpeed[%d], EEE[%d])\n",
-                          (tp->phy_flags & TG3_PHYFLG_NO_ETH_WIRE_SPEED) == 0);
+                            tg3_phy_string(tp), ethtype,
+                            (tp->phy_flags & TG3_PHYFLG_NO_ETH_WIRE_SPEED) == 0,
+                            (tp->phy_flags & TG3_PHYFLG_EEE_CAP) != 0);
        }
        netdev_info(dev, "RXcsums[%d] LinkChgREG[%d] MIirq[%d] ASF[%d] TSOcap[%d]\n",
-                    (tp->tg3_flags & TG3_FLAG_RX_CHECKSUMS) != 0,
+                    (dev->features & NETIF_F_RXCSUM) != 0,
-                    (tp->tg3_flags & TG3_FLAG_USE_LINKCHG_REG) != 0,
+                    tg3_flag(tp, USE_LINKCHG_REG) != 0,
                    (tp->phy_flags & TG3_PHYFLG_USE_MI_INTERRUPT) != 0,
-                    (tp->tg3_flags & TG3_FLAG_ENABLE_ASF) != 0,
+                    tg3_flag(tp, ENABLE_ASF) != 0,
-                    (tp->tg3_flags2 & TG3_FLG2_TSO_CAPABLE) != 0);
+                    tg3_flag(tp, TSO_CAPABLE) != 0);
        netdev_info(dev, "dma_rwctrl[%08x] dma_mask[%d-bit]\n",
                    tp->dma_rwctrl,
                    pdev->dma_mask == DMA_BIT_MASK(32) ? 32 :
                    ((u64)pdev->dma_mask) == DMA_BIT_MASK(40) ? 40 : 64);
+        pci_save_state(pdev);
        return 0;
 err_out_apeunmap:
@@ -15025,7 +15277,7 @@ static void __devexit tg3_remove_one(struct pci_dev *pdev)
                cancel_work_sync(&tp->reset_task);
-                if (tp->tg3_flags3 & TG3_FLG3_USE_PHYLIB) {
+                if (!tg3_flag(tp, USE_PHYLIB)) {
                        tg3_phy_fini(tp);
                        tg3_mdio_fini(tp);
                }
@@ -15071,7 +15323,7 @@ static int tg3_suspend(struct device *device)
        tg3_full_lock(tp, 0);
        tg3_halt(tp, RESET_KIND_SHUTDOWN, 1);
-        tp->tg3_flags &= ~TG3_FLAG_INIT_COMPLETE;
+        tg3_flag_clear(tp, INIT_COMPLETE);
        tg3_full_unlock(tp);
        err = tg3_power_down_prepare(tp);
@@ -15080,7 +15332,7 @@ static int tg3_suspend(struct device *device)
                tg3_full_lock(tp, 0);
-                tp->tg3_flags |= TG3_FLAG_INIT_COMPLETE;
+                tg3_flag_set(tp, INIT_COMPLETE);
                err2 = tg3_restart_hw(tp, 1);
                if (err2)
                        goto out;
@@ -15115,7 +15367,7 @@ static int tg3_resume(struct device *device)
        tg3_full_lock(tp, 0);
-        tp->tg3_flags |= TG3_FLAG_INIT_COMPLETE;
+        tg3_flag_set(tp, INIT_COMPLETE);
        err = tg3_restart_hw(tp, 1);
        if (err)
                goto out;
@@ -15143,11 +15395,156 @@ static SIMPLE_DEV_PM_OPS(tg3_pm_ops, tg3_suspend, tg3_resume);
 #endif /* CONFIG_PM_SLEEP */
+/**
+ * tg3_io_error_detected - called when PCI error is detected
+ * @pdev: Pointer to PCI device
+ * @state: The current pci connection state
+ *
+ * This function is called after a PCI bus error affecting
+ * this device has been detected.
+ */
+static pci_ers_result_t tg3_io_error_detected(struct pci_dev *pdev,
+                                              pci_channel_state_t state)
+{
+        struct net_device *netdev = pci_get_drvdata(pdev);
+        struct tg3 *tp = netdev_priv(netdev);
+        pci_ers_result_t err = PCI_ERS_RESULT_NEED_RESET;
+        netdev_info(netdev, "PCI I/O error detected\n");
+        rtnl_lock();
+        if (!netif_running(netdev))
+                goto done;
+        tg3_phy_stop(tp);
+        tg3_netif_stop(tp);
+        del_timer_sync(&tp->timer);
+        tg3_flag_clear(tp, RESTART_TIMER);
+        /* Want to make sure that the reset task doesn't run */
+        cancel_work_sync(&tp->reset_task);
+        tg3_flag_clear(tp, TX_RECOVERY_PENDING);
+        tg3_flag_clear(tp, RESTART_TIMER);
+        netif_device_detach(netdev);
+        /* Clean up software state, even if MMIO is blocked */
+        tg3_full_lock(tp, 0);
+        tg3_halt(tp, RESET_KIND_SHUTDOWN, 0);
+        tg3_full_unlock(tp);
+done:
+        if (state == pci_channel_io_perm_failure)
+                err = PCI_ERS_RESULT_DISCONNECT;
+        else
+                pci_disable_device(pdev);
+        rtnl_unlock();
+        return err;
+}
+/**
+ * tg3_io_slot_reset - called after the pci bus has been reset.
+ * @pdev: Pointer to PCI device
+ *
+ * Restart the card from scratch, as if from a cold-boot.
+ * At this point, the card has exprienced a hard reset,
+ * followed by fixups by BIOS, and has its config space
+ * set up identically to what it was at cold boot.
+ */
+static pci_ers_result_t tg3_io_slot_reset(struct pci_dev *pdev)
+{
+        struct net_device *netdev = pci_get_drvdata(pdev);
+        struct tg3 *tp = netdev_priv(netdev);
+        pci_ers_result_t rc = PCI_ERS_RESULT_DISCONNECT;
+        int err;
+        rtnl_lock();
+        if (pci_enable_device(pdev)) {
+                netdev_err(netdev, "Cannot re-enable PCI device after reset.\n");
+                goto done;
+        }
+        pci_set_master(pdev);
+        pci_restore_state(pdev);
+        pci_save_state(pdev);
+        if (!netif_running(netdev)) {
+                rc = PCI_ERS_RESULT_RECOVERED;
+                goto done;
+        }
+        err = tg3_power_up(tp);
+        if (err) {
+                netdev_err(netdev, "Failed to restore register access.\n");
+                goto done;
+        }
+        rc = PCI_ERS_RESULT_RECOVERED;
+done:
+        rtnl_unlock();
+        return rc;
+}
+/**
+ * tg3_io_resume - called when traffic can start flowing again.
+ * @pdev: Pointer to PCI device
+ *
+ * This callback is called when the error recovery driver tells
+ * us that its OK to resume normal operation.
+ */
+static void tg3_io_resume(struct pci_dev *pdev)
+{
+        struct net_device *netdev = pci_get_drvdata(pdev);
+        struct tg3 *tp = netdev_priv(netdev);
+        int err;
+        rtnl_lock();
+        if (!netif_running(netdev))
+                goto done;
+        tg3_full_lock(tp, 0);
+        tg3_flag_set(tp, INIT_COMPLETE);
+        err = tg3_restart_hw(tp, 1);
+        tg3_full_unlock(tp);
+        if (err) {
+                netdev_err(netdev, "Cannot restart hardware after reset.\n");
+                goto done;
+        }
+        netif_device_attach(netdev);
+        tp->timer.expires = jiffies + tp->timer_offset;
+        add_timer(&tp->timer);
+        tg3_netif_start(tp);
+        tg3_phy_start(tp);
+done:
+        rtnl_unlock();
+}
+static struct pci_error_handlers tg3_err_handler = {
+        .error_detected = tg3_io_error_detected,
+        .slot_reset     = tg3_io_slot_reset,
+        .resume         = tg3_io_resume
+};
 static struct pci_driver tg3_driver = {
        .name           = DRV_MODULE_NAME,
        .id_table       = tg3_pci_tbl,
        .probe          = tg3_init_one,
        .remove         = __devexit_p(tg3_remove_one),
+        .err_handler    = &tg3_err_handler,
        .driver.pm      = TG3_PM_OPS,
 };
diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h
index 5e96706ad108..5b3d2f34da7a 100644
--- a/drivers/net/tg3.h
+++ b/drivers/net/tg3.h
@@ -23,11 +23,13 @@
 #define TG3_BDINFO_NIC_ADDR             0xcUL /* 32-bit */
 #define TG3_BDINFO_SIZE                 0x10UL
-#define TG3_RX_INTERNAL_RING_SZ_5906    32
+#define TG3_RX_STD_MAX_SIZE_5700        512
+#define TG3_RX_STD_MAX_SIZE_5717        2048
-#define RX_STD_MAX_SIZE_5705            512
+#define TG3_RX_JMB_MAX_SIZE_5700        256
-#define RX_STD_MAX_SIZE_5717            2048
+#define TG3_RX_JMB_MAX_SIZE_5717        1024
-#define RX_JUMBO_MAX_SIZE               0xdeadbeef /* XXX */
+#define TG3_RX_RET_MAX_SIZE_5700        1024
+#define TG3_RX_RET_MAX_SIZE_5705        512
+#define TG3_RX_RET_MAX_SIZE_5717        4096
 /* First 256 bytes are a mirror of PCI config space. */
 #define TG3PCI_VENDOR                   0x00000000
@@ -54,6 +56,7 @@
 #define  TG3PCI_DEVICE_TIGON3_57791      0x16b2
 #define  TG3PCI_DEVICE_TIGON3_57795      0x16b6
 #define  TG3PCI_DEVICE_TIGON3_5719       0x1657
+#define  TG3PCI_DEVICE_TIGON3_5720       0x165f
 /* 0x04 --> 0x2c unused */
 #define TG3PCI_SUBVENDOR_ID_BROADCOM            PCI_VENDOR_ID_BROADCOM
 #define TG3PCI_SUBDEVICE_ID_BROADCOM_95700A6    0x1644
@@ -142,6 +145,7 @@
 #define  CHIPREV_ID_5717_A0              0x05717000
 #define  CHIPREV_ID_57765_A0             0x57785000
 #define  CHIPREV_ID_5719_A0              0x05719000
+#define  CHIPREV_ID_5720_A0              0x05720000
 #define  GET_ASIC_REV(CHIP_REV_ID)      ((CHIP_REV_ID) >> 12)
 #define   ASIC_REV_5700                  0x07
 #define   ASIC_REV_5701                  0x00
@@ -163,6 +167,7 @@
 #define   ASIC_REV_5717                  0x5717
 #define   ASIC_REV_57765                 0x57785
 #define   ASIC_REV_5719                  0x5719
+#define   ASIC_REV_5720                  0x5720
 #define  GET_CHIP_REV(CHIP_REV_ID)      ((CHIP_REV_ID) >> 8)
 #define   CHIPREV_5700_AX                0x70
 #define   CHIPREV_5700_BX                0x71
@@ -175,6 +180,7 @@
 #define   CHIPREV_5750_BX                0x41
 #define   CHIPREV_5784_AX                0x57840
 #define   CHIPREV_5761_AX                0x57610
+#define   CHIPREV_57765_AX               0x577650
 #define  GET_METAL_REV(CHIP_REV_ID)     ((CHIP_REV_ID) & 0xff)
 #define   METAL_REV_A0                   0x00
 #define   METAL_REV_A1                   0x01
@@ -183,6 +189,7 @@
 #define   METAL_REV_B2                   0x02
 #define TG3PCI_DMA_RW_CTRL              0x0000006c
 #define  DMA_RWCTRL_DIS_CACHE_ALIGNMENT  0x00000001
+#define  DMA_RWCTRL_TAGGED_STAT_WA       0x00000080
 #define  DMA_RWCTRL_CRDRDR_RDMA_MRRS_MSK 0x00000380
 #define  DMA_RWCTRL_READ_BNDRY_MASK      0x00000700
 #define  DMA_RWCTRL_READ_BNDRY_DISAB     0x00000000
@@ -473,6 +480,8 @@
 #define  TX_MODE_BIG_BCKOFF_ENABLE       0x00000020
 #define  TX_MODE_LONG_PAUSE_ENABLE       0x00000040
 #define  TX_MODE_MBUF_LOCKUP_FIX         0x00000100
+#define  TX_MODE_JMB_FRM_LEN             0x00400000
+#define  TX_MODE_CNT_DN_MODE             0x00800000
 #define MAC_TX_STATUS                   0x00000460
 #define  TX_STATUS_XOFFED                0x00000001
 #define  TX_STATUS_SENT_XOFF             0x00000002
@@ -487,6 +496,8 @@
 #define  TX_LENGTHS_IPG_SHIFT            8
 #define  TX_LENGTHS_IPG_CRS_MASK         0x00003000
 #define  TX_LENGTHS_IPG_CRS_SHIFT        12
+#define  TX_LENGTHS_JMB_FRM_LEN_MSK      0x00ff0000
+#define  TX_LENGTHS_CNT_DWN_VAL_MSK      0xff000000
 #define MAC_RX_MODE                     0x00000468
 #define  RX_MODE_RESET                   0x00000001
 #define  RX_MODE_ENABLE                  0x00000002
@@ -1079,6 +1090,9 @@
 #define  CPMU_HST_ACC_MACCLK_6_25        0x00130000
 /* 0x3620 --> 0x3630 unused */
+#define TG3_CPMU_CLCK_ORIDE             0x00003624
+#define  CPMU_CLCK_ORIDE_MAC_ORIDE_EN    0x80000000
 #define TG3_CPMU_CLCK_STAT              0x00003630
 #define  CPMU_CLCK_STAT_MAC_CLCK_MASK    0x001f0000
 #define  CPMU_CLCK_STAT_MAC_CLCK_62_5    0x00000000
@@ -1188,6 +1202,7 @@
 #define HOSTCC_STATS_BLK_NIC_ADDR       0x00003c40
 #define HOSTCC_STATUS_BLK_NIC_ADDR      0x00003c44
 #define HOSTCC_FLOW_ATTN                0x00003c48
+#define HOSTCC_FLOW_ATTN_MBUF_LWM        0x00000040
 /* 0x3c4c --> 0x3c50 unused */
 #define HOSTCC_JUMBO_CON_IDX            0x00003c50
 #define HOSTCC_STD_CON_IDX              0x00003c54
@@ -1321,6 +1336,7 @@
 #define  RDMAC_MODE_MULT_DMA_RD_DIS      0x01000000
 #define  RDMAC_MODE_IPV4_LSO_EN          0x08000000
 #define  RDMAC_MODE_IPV6_LSO_EN          0x10000000
+#define  RDMAC_MODE_H2BNC_VLAN_DET       0x20000000
 #define RDMAC_STATUS                    0x00004804
 #define  RDMAC_STATUS_TGTABORT           0x00000004
 #define  RDMAC_STATUS_MSTABORT           0x00000008
@@ -1597,6 +1613,7 @@
 #define  MSGINT_MODE_ONE_SHOT_DISABLE    0x00000020
 #define  MSGINT_MODE_MULTIVEC_EN         0x00000080
 #define MSGINT_STATUS                   0x00006004
+#define  MSGINT_STATUS_MSI_REQ           0x00000001
 #define MSGINT_FIFO                     0x00006008
 /* 0x600c --> 0x6400 unused */
@@ -1613,6 +1630,8 @@
 #define  GRC_MODE_WSWAP_NONFRM_DATA     0x00000004
 #define  GRC_MODE_BSWAP_DATA            0x00000010
 #define  GRC_MODE_WSWAP_DATA            0x00000020
+#define  GRC_MODE_BYTE_SWAP_B2HRX_DATA  0x00000040
+#define  GRC_MODE_WORD_SWAP_B2HRX_DATA  0x00000080
 #define  GRC_MODE_SPLITHDR              0x00000100
 #define  GRC_MODE_NOFRM_CRACKING        0x00000200
 #define  GRC_MODE_INCL_CRC              0x00000400
@@ -1620,8 +1639,10 @@
 #define  GRC_MODE_NOIRQ_ON_SENDS        0x00002000
 #define  GRC_MODE_NOIRQ_ON_RCV          0x00004000
 #define  GRC_MODE_FORCE_PCI32BIT        0x00008000
+#define  GRC_MODE_B2HRX_ENABLE          0x00008000
 #define  GRC_MODE_HOST_STACKUP          0x00010000
 #define  GRC_MODE_HOST_SENDBDS          0x00020000
+#define  GRC_MODE_HTX2B_ENABLE          0x00040000
 #define  GRC_MODE_NO_TX_PHDR_CSUM       0x00100000
 #define  GRC_MODE_NVRAM_WR_ENABLE       0x00200000
 #define  GRC_MODE_PCIE_TL_SEL           0x00000000
@@ -1818,6 +1839,38 @@
 #define  FLASH_5717VENDOR_ATMEL_45USPT   0x03400000
 #define  FLASH_5717VENDOR_ST_25USPT      0x03400002
 #define  FLASH_5717VENDOR_ST_45USPT      0x03400001
+#define  FLASH_5720_EEPROM_HD            0x00000001
+#define  FLASH_5720_EEPROM_LD            0x00000003
+#define  FLASH_5720VENDOR_M_ATMEL_DB011D 0x01000000
+#define  FLASH_5720VENDOR_M_ATMEL_DB021D 0x01000002
+#define  FLASH_5720VENDOR_M_ATMEL_DB041D 0x01000001
+#define  FLASH_5720VENDOR_M_ATMEL_DB081D 0x01000003
+#define  FLASH_5720VENDOR_M_ST_M25PE10   0x02000000
+#define  FLASH_5720VENDOR_M_ST_M25PE20   0x02000002
+#define  FLASH_5720VENDOR_M_ST_M25PE40   0x02000001
+#define  FLASH_5720VENDOR_M_ST_M25PE80   0x02000003
+#define  FLASH_5720VENDOR_M_ST_M45PE10   0x03000000
+#define  FLASH_5720VENDOR_M_ST_M45PE20   0x03000002
+#define  FLASH_5720VENDOR_M_ST_M45PE40   0x03000001
+#define  FLASH_5720VENDOR_M_ST_M45PE80   0x03000003
+#define  FLASH_5720VENDOR_A_ATMEL_DB011B 0x01800000
+#define  FLASH_5720VENDOR_A_ATMEL_DB021B 0x01800002
+#define  FLASH_5720VENDOR_A_ATMEL_DB041B 0x01800001
+#define  FLASH_5720VENDOR_A_ATMEL_DB011D 0x01c00000
+#define  FLASH_5720VENDOR_A_ATMEL_DB021D 0x01c00002
+#define  FLASH_5720VENDOR_A_ATMEL_DB041D 0x01c00001
+#define  FLASH_5720VENDOR_A_ATMEL_DB081D 0x01c00003
+#define  FLASH_5720VENDOR_A_ST_M25PE10   0x02800000
+#define  FLASH_5720VENDOR_A_ST_M25PE20   0x02800002
+#define  FLASH_5720VENDOR_A_ST_M25PE40   0x02800001
+#define  FLASH_5720VENDOR_A_ST_M25PE80   0x02800003
+#define  FLASH_5720VENDOR_A_ST_M45PE10   0x02c00000
+#define  FLASH_5720VENDOR_A_ST_M45PE20   0x02c00002
+#define  FLASH_5720VENDOR_A_ST_M45PE40   0x02c00001
+#define  FLASH_5720VENDOR_A_ST_M45PE80   0x02c00003
+#define  FLASH_5720VENDOR_ATMEL_45USPT   0x03c00000
+#define  FLASH_5720VENDOR_ST_25USPT      0x03c00002
+#define  FLASH_5720VENDOR_ST_45USPT      0x03c00001
 #define  NVRAM_CFG1_5752PAGE_SIZE_MASK   0x70000000
 #define  FLASH_5752PAGE_SIZE_256         0x00000000
 #define  FLASH_5752PAGE_SIZE_512         0x10000000
@@ -1899,11 +1952,16 @@
 /* Alternate PCIE definitions */
 #define TG3_PCIE_TLDLPL_PORT            0x00007c00
+#define TG3_PCIE_DL_LO_FTSMAX           0x0000000c
+#define TG3_PCIE_DL_LO_FTSMAX_MSK       0x000000ff
+#define TG3_PCIE_DL_LO_FTSMAX_VAL       0x0000002c
 #define TG3_PCIE_PL_LO_PHYCTL1           0x00000004
 #define TG3_PCIE_PL_LO_PHYCTL1_L1PLLPD_EN         0x00001000
 #define TG3_PCIE_PL_LO_PHYCTL5           0x00000014
 #define TG3_PCIE_PL_LO_PHYCTL5_DIS_L2CLKREQ       0x80000000
+#define TG3_REG_BLK_SIZE                0x00008000
 /* OTP bit definitions */
 #define TG3_OTP_AGCTGT_MASK             0x000000e0
 #define TG3_OTP_AGCTGT_SHIFT            1
@@ -1955,7 +2013,9 @@
 #define TG3_NVM_DIR_END                 0x78
 #define TG3_NVM_DIRENT_SIZE             0xc
 #define TG3_NVM_DIRTYPE_SHIFT           24
+#define TG3_NVM_DIRTYPE_LENMSK          0x003fffff
 #define TG3_NVM_DIRTYPE_ASFINI          1
+#define TG3_NVM_DIRTYPE_EXTVPD          20
 #define TG3_NVM_PTREV_BCVER             0x94
 #define TG3_NVM_BCVER_MAJMSK            0x0000ff00
 #define TG3_NVM_BCVER_MAJSFT            8
@@ -2079,6 +2139,13 @@
 #define  NIC_SRAM_MBUF_POOL_BASE5705    0x00010000
 #define  NIC_SRAM_MBUF_POOL_SIZE5705    0x0000e000
+#define TG3_SRAM_RX_STD_BDCACHE_SIZE_5700       128
+#define TG3_SRAM_RX_STD_BDCACHE_SIZE_5755       64
+#define TG3_SRAM_RX_STD_BDCACHE_SIZE_5906       32
+#define TG3_SRAM_RX_JMB_BDCACHE_SIZE_5700       64
+#define TG3_SRAM_RX_JMB_BDCACHE_SIZE_5717       16
 /* Currently this is fixed. */
 #define TG3_PHY_MII_ADDR                0x01
@@ -2119,7 +2186,7 @@
 #define  MII_TG3_DSP_TAP26_OPCSINPT     0x0004
 #define MII_TG3_DSP_AADJ1CH0            0x001f
 #define MII_TG3_DSP_CH34TP2             0x4022
-#define MII_TG3_DSP_CH34TP2_HIBW01      0x0010
+#define MII_TG3_DSP_CH34TP2_HIBW01      0x017b
 #define MII_TG3_DSP_AADJ1CH3            0x601f
 #define  MII_TG3_DSP_AADJ1CH3_ADCCKADJ  0x0002
 #define MII_TG3_DSP_EXP1_INT_STAT       0x0f01
@@ -2132,19 +2199,26 @@
 #define MII_TG3_AUX_CTRL                0x18 /* auxiliary control register */
+#define MII_TG3_AUXCTL_SHDWSEL_AUXCTL   0x0000
+#define MII_TG3_AUXCTL_ACTL_TX_6DB      0x0400
+#define MII_TG3_AUXCTL_ACTL_SMDSP_ENA   0x0800
+#define MII_TG3_AUXCTL_ACTL_EXTPKTLEN   0x4000
+#define MII_TG3_AUXCTL_SHDWSEL_PWRCTL   0x0002
+#define MII_TG3_AUXCTL_PCTL_WOL_EN      0x0008
 #define MII_TG3_AUXCTL_PCTL_100TX_LPWR  0x0010
 #define MII_TG3_AUXCTL_PCTL_SPR_ISOLATE 0x0020
+#define MII_TG3_AUXCTL_PCTL_CL_AB_TXDAC 0x0040
 #define MII_TG3_AUXCTL_PCTL_VREG_11V    0x0180
-#define MII_TG3_AUXCTL_SHDWSEL_PWRCTL   0x0002
-#define MII_TG3_AUXCTL_MISC_WREN        0x8000
+#define MII_TG3_AUXCTL_SHDWSEL_MISCTEST 0x0004
-#define MII_TG3_AUXCTL_MISC_FORCE_AMDIX 0x0200
-#define MII_TG3_AUXCTL_MISC_RDSEL_MISC  0x7000
 #define MII_TG3_AUXCTL_SHDWSEL_MISC     0x0007
+#define MII_TG3_AUXCTL_MISC_WIRESPD_EN  0x0010
+#define MII_TG3_AUXCTL_MISC_FORCE_AMDIX 0x0200
+#define MII_TG3_AUXCTL_MISC_RDSEL_SHIFT 12
+#define MII_TG3_AUXCTL_MISC_WREN        0x8000
-#define MII_TG3_AUXCTL_ACTL_SMDSP_ENA   0x0800
-#define MII_TG3_AUXCTL_ACTL_TX_6DB      0x0400
-#define MII_TG3_AUXCTL_SHDWSEL_AUXCTL   0x0000
 #define MII_TG3_AUX_STAT                0x19 /* auxiliary status register */
 #define MII_TG3_AUX_STAT_LPASS          0x0004
@@ -2564,7 +2638,12 @@ struct tg3_hw_stats {
        tg3_stat64_t                    nic_avoided_irqs;
        tg3_stat64_t                    nic_tx_threshold_hit;
-        u8                              __reserved4[0xb00-0x9c0];
+        /* NOT a part of the hardware statistics block format.
+         * These stats are here as storage for tg3_periodic_fetch_stats().
+         */
+        tg3_stat64_t                    mbuf_lwm_thresh_hit;
+        u8                              __reserved4[0xb00-0x9c8];
 };
 /* 'mapping' is superfluous as the chip does not write into
@@ -2696,6 +2775,8 @@ struct tg3_ethtool_stats {
        u64             nic_irqs;
        u64             nic_avoided_irqs;
        u64             nic_tx_threshold_hit;
+        u64             mbuf_lwm_thresh_hit;
 };
 struct tg3_rx_prodring_set {
@@ -2745,6 +2826,86 @@ struct tg3_napi {
        unsigned int                    irq_vec;
 };
+enum TG3_FLAGS {
+        TG3_FLAG_TAGGED_STATUS = 0,
+        TG3_FLAG_TXD_MBOX_HWBUG,
+        TG3_FLAG_USE_LINKCHG_REG,
+        TG3_FLAG_ERROR_PROCESSED,
+        TG3_FLAG_ENABLE_ASF,
+        TG3_FLAG_ASPM_WORKAROUND,
+        TG3_FLAG_POLL_SERDES,
+        TG3_FLAG_MBOX_WRITE_REORDER,
+        TG3_FLAG_PCIX_TARGET_HWBUG,
+        TG3_FLAG_WOL_SPEED_100MB,
+        TG3_FLAG_WOL_ENABLE,
+        TG3_FLAG_EEPROM_WRITE_PROT,
+        TG3_FLAG_NVRAM,
+        TG3_FLAG_NVRAM_BUFFERED,
+        TG3_FLAG_SUPPORT_MSI,
+        TG3_FLAG_SUPPORT_MSIX,
+        TG3_FLAG_PCIX_MODE,
+        TG3_FLAG_PCI_HIGH_SPEED,
+        TG3_FLAG_PCI_32BIT,
+        TG3_FLAG_SRAM_USE_CONFIG,
+        TG3_FLAG_TX_RECOVERY_PENDING,
+        TG3_FLAG_WOL_CAP,
+        TG3_FLAG_JUMBO_RING_ENABLE,
+        TG3_FLAG_PAUSE_AUTONEG,
+        TG3_FLAG_CPMU_PRESENT,
+        TG3_FLAG_40BIT_DMA_BUG,
+        TG3_FLAG_BROKEN_CHECKSUMS,
+        TG3_FLAG_JUMBO_CAPABLE,
+        TG3_FLAG_CHIP_RESETTING,
+        TG3_FLAG_INIT_COMPLETE,
+        TG3_FLAG_RESTART_TIMER,
+        TG3_FLAG_TSO_BUG,
+        TG3_FLAG_IS_5788,
+        TG3_FLAG_MAX_RXPEND_64,
+        TG3_FLAG_TSO_CAPABLE,
+        TG3_FLAG_PCI_EXPRESS,
+        TG3_FLAG_ASF_NEW_HANDSHAKE,
+        TG3_FLAG_HW_AUTONEG,
+        TG3_FLAG_IS_NIC,
+        TG3_FLAG_FLASH,
+        TG3_FLAG_HW_TSO_1,
+        TG3_FLAG_5705_PLUS,
+        TG3_FLAG_5750_PLUS,
+        TG3_FLAG_HW_TSO_3,
+        TG3_FLAG_USING_MSI,
+        TG3_FLAG_USING_MSIX,
+        TG3_FLAG_ICH_WORKAROUND,
+        TG3_FLAG_5780_CLASS,
+        TG3_FLAG_HW_TSO_2,
+        TG3_FLAG_1SHOT_MSI,
+        TG3_FLAG_NO_FWARE_REPORTED,
+        TG3_FLAG_NO_NVRAM_ADDR_TRANS,
+        TG3_FLAG_ENABLE_APE,
+        TG3_FLAG_PROTECTED_NVRAM,
+        TG3_FLAG_5701_DMA_BUG,
+        TG3_FLAG_USE_PHYLIB,
+        TG3_FLAG_MDIOBUS_INITED,
+        TG3_FLAG_LRG_PROD_RING_CAP,
+        TG3_FLAG_RGMII_INBAND_DISABLE,
+        TG3_FLAG_RGMII_EXT_IBND_RX_EN,
+        TG3_FLAG_RGMII_EXT_IBND_TX_EN,
+        TG3_FLAG_CLKREQ_BUG,
+        TG3_FLAG_5755_PLUS,
+        TG3_FLAG_NO_NVRAM,
+        TG3_FLAG_ENABLE_RSS,
+        TG3_FLAG_ENABLE_TSS,
+        TG3_FLAG_4G_DMA_BNDRY_BUG,
+        TG3_FLAG_40BIT_DMA_LIMIT_BUG,
+        TG3_FLAG_SHORT_DMA_BUG,
+        TG3_FLAG_USE_JUMBO_BDFLAG,
+        TG3_FLAG_L1PLLPD_EN,
+        TG3_FLAG_57765_PLUS,
+        TG3_FLAG_APE_HAS_NCSI,
+        TG3_FLAG_5717_PLUS,
+        /* Add new flags before this comment and TG3_FLAG_NUMBER_OF_FLAGS */
+        TG3_FLAG_NUMBER_OF_FLAGS,       /* Last entry in enum TG3_FLAGS */
+};
 struct tg3 {
        /* begin "general, frequently-used members" cacheline section */
@@ -2768,7 +2929,7 @@ struct tg3 {
        /* SMP locking strategy:
         *
         * lock: Held during reset, PHY access, timer, and when
-         *       updating tg3_flags and tg3_flags2.
+         *       updating tg3_flags.
         *
         * netif_tx_lock: Held during tg3_start_xmit. tg3_tx holds
         *                netif_tx_lock when it needs to call
@@ -2825,94 +2986,13 @@ struct tg3 {
        struct tg3_ethtool_stats        estats;
        struct tg3_ethtool_stats        estats_prev;
+        DECLARE_BITMAP(tg3_flags, TG3_FLAG_NUMBER_OF_FLAGS);
        union {
        unsigned long                   phy_crc_errors;
        unsigned long                   last_event_jiffies;
        };
-        u32                             tg3_flags;
-#define TG3_FLAG_TAGGED_STATUS          0x00000001
-#define TG3_FLAG_TXD_MBOX_HWBUG         0x00000002
-#define TG3_FLAG_RX_CHECKSUMS           0x00000004
-#define TG3_FLAG_USE_LINKCHG_REG        0x00000008
-#define TG3_FLAG_ENABLE_ASF             0x00000020
-#define TG3_FLAG_ASPM_WORKAROUND        0x00000040
-#define TG3_FLAG_POLL_SERDES            0x00000080
-#define TG3_FLAG_MBOX_WRITE_REORDER     0x00000100
-#define TG3_FLAG_PCIX_TARGET_HWBUG      0x00000200
-#define TG3_FLAG_WOL_SPEED_100MB        0x00000400
-#define TG3_FLAG_WOL_ENABLE             0x00000800
-#define TG3_FLAG_EEPROM_WRITE_PROT      0x00001000
-#define TG3_FLAG_NVRAM                  0x00002000
-#define TG3_FLAG_NVRAM_BUFFERED         0x00004000
-#define TG3_FLAG_SUPPORT_MSI            0x00008000
-#define TG3_FLAG_SUPPORT_MSIX           0x00010000
-#define TG3_FLAG_SUPPORT_MSI_OR_MSIX    (TG3_FLAG_SUPPORT_MSI | \
-                                         TG3_FLAG_SUPPORT_MSIX)
-#define TG3_FLAG_PCIX_MODE              0x00020000
-#define TG3_FLAG_PCI_HIGH_SPEED         0x00040000
-#define TG3_FLAG_PCI_32BIT              0x00080000
-#define TG3_FLAG_SRAM_USE_CONFIG        0x00100000
-#define TG3_FLAG_TX_RECOVERY_PENDING    0x00200000
-#define TG3_FLAG_WOL_CAP                0x00400000
-#define TG3_FLAG_JUMBO_RING_ENABLE      0x00800000
-#define TG3_FLAG_PAUSE_AUTONEG          0x02000000
-#define TG3_FLAG_CPMU_PRESENT           0x04000000
-#define TG3_FLAG_40BIT_DMA_BUG          0x08000000
-#define TG3_FLAG_BROKEN_CHECKSUMS       0x10000000
-#define TG3_FLAG_JUMBO_CAPABLE          0x20000000
-#define TG3_FLAG_CHIP_RESETTING         0x40000000
-#define TG3_FLAG_INIT_COMPLETE          0x80000000
-        u32                             tg3_flags2;
-#define TG3_FLG2_RESTART_TIMER          0x00000001
-#define TG3_FLG2_TSO_BUG                0x00000002
-#define TG3_FLG2_IS_5788                0x00000008
-#define TG3_FLG2_MAX_RXPEND_64          0x00000010
-#define TG3_FLG2_TSO_CAPABLE            0x00000020
-#define TG3_FLG2_PCI_EXPRESS            0x00000200
-#define TG3_FLG2_ASF_NEW_HANDSHAKE      0x00000400
-#define TG3_FLG2_HW_AUTONEG             0x00000800
-#define TG3_FLG2_IS_NIC                 0x00001000
-#define TG3_FLG2_FLASH                  0x00008000
-#define TG3_FLG2_HW_TSO_1               0x00010000
-#define TG3_FLG2_5705_PLUS              0x00040000
-#define TG3_FLG2_5750_PLUS              0x00080000
-#define TG3_FLG2_HW_TSO_3               0x00100000
-#define TG3_FLG2_USING_MSI              0x00200000
-#define TG3_FLG2_USING_MSIX             0x00400000
-#define TG3_FLG2_USING_MSI_OR_MSIX      (TG3_FLG2_USING_MSI | \
-                                        TG3_FLG2_USING_MSIX)
-#define TG3_FLG2_ICH_WORKAROUND         0x02000000
-#define TG3_FLG2_5780_CLASS             0x04000000
-#define TG3_FLG2_HW_TSO_2               0x08000000
-#define TG3_FLG2_HW_TSO                 (TG3_FLG2_HW_TSO_1 | \
-                                         TG3_FLG2_HW_TSO_2 | \
-                                         TG3_FLG2_HW_TSO_3)
-#define TG3_FLG2_1SHOT_MSI              0x10000000
-#define TG3_FLG2_NO_FWARE_REPORTED      0x40000000
-        u32                             tg3_flags3;
-#define TG3_FLG3_NO_NVRAM_ADDR_TRANS    0x00000001
-#define TG3_FLG3_ENABLE_APE             0x00000002
-#define TG3_FLG3_PROTECTED_NVRAM        0x00000004
-#define TG3_FLG3_5701_DMA_BUG           0x00000008
-#define TG3_FLG3_USE_PHYLIB             0x00000010
-#define TG3_FLG3_MDIOBUS_INITED         0x00000020
-#define TG3_FLG3_RGMII_INBAND_DISABLE   0x00000100
-#define TG3_FLG3_RGMII_EXT_IBND_RX_EN   0x00000200
-#define TG3_FLG3_RGMII_EXT_IBND_TX_EN   0x00000400
-#define TG3_FLG3_CLKREQ_BUG             0x00000800
-#define TG3_FLG3_5755_PLUS              0x00002000
-#define TG3_FLG3_NO_NVRAM               0x00004000
-#define TG3_FLG3_ENABLE_RSS             0x00020000
-#define TG3_FLG3_ENABLE_TSS             0x00040000
-#define TG3_FLG3_4G_DMA_BNDRY_BUG       0x00080000
-#define TG3_FLG3_40BIT_DMA_LIMIT_BUG    0x00100000
-#define TG3_FLG3_SHORT_DMA_BUG          0x00200000
-#define TG3_FLG3_USE_JUMBO_BDFLAG       0x00400000
-#define TG3_FLG3_L1PLLPD_EN             0x00800000
-#define TG3_FLG3_5717_PLUS              0x01000000
-#define TG3_FLG3_APE_HAS_NCSI           0x02000000
        struct timer_list               timer;
        u16                             timer_counter;
        u16                             timer_multiplier;
@@ -2983,6 +3063,7 @@ struct tg3 {
 #define TG3_PHY_ID_BCM5718S             0xbc050ff0
 #define TG3_PHY_ID_BCM57765             0x5c0d8a40
 #define TG3_PHY_ID_BCM5719C             0x5c0d8a20
+#define TG3_PHY_ID_BCM5720C             0x5c0d8b60
 #define TG3_PHY_ID_BCM5906              0xdc00ac40
 #define TG3_PHY_ID_BCM8002              0x60010140
 #define TG3_PHY_ID_INVALID              0xffffffff
@@ -3049,6 +3130,7 @@ struct tg3 {
        int                             nvram_lock_cnt;
        u32                             nvram_size;
+#define TG3_NVRAM_SIZE_2KB              0x00000800
 #define TG3_NVRAM_SIZE_64KB             0x00010000
 #define TG3_NVRAM_SIZE_128KB            0x00020000
 #define TG3_NVRAM_SIZE_256KB            0x00040000
@@ -3064,6 +3146,9 @@ struct tg3 {
 #define JEDEC_SAIFUN                    0x4f
 #define JEDEC_SST                       0xbf
+#define ATMEL_AT24C02_CHIP_SIZE         TG3_NVRAM_SIZE_2KB
+#define ATMEL_AT24C02_PAGE_SIZE         (8)
 #define ATMEL_AT24C64_CHIP_SIZE         TG3_NVRAM_SIZE_64KB
 #define ATMEL_AT24C64_PAGE_SIZE         (32)
diff --git a/drivers/net/tile/tilepro.c b/drivers/net/tile/tilepro.c
index 0825db6d883f..1e980fdd9d77 100644
--- a/drivers/net/tile/tilepro.c
+++ b/drivers/net/tile/tilepro.c
@@ -1930,7 +1930,7 @@ static int tile_net_tx(struct sk_buff *skb, struct net_device *dev)
        unsigned int len = skb->len;
        unsigned char *data = skb->data;
-        unsigned int csum_start = skb->csum_start - skb_headroom(skb);
+        unsigned int csum_start = skb_checksum_start_offset(skb);
        lepp_frag_t frags[LEPP_MAX_FRAGS];
diff --git a/drivers/net/tokenring/madgemc.c b/drivers/net/tokenring/madgemc.c
index 2bedc0ace812..1313aa1315f0 100644
--- a/drivers/net/tokenring/madgemc.c
+++ b/drivers/net/tokenring/madgemc.c
@@ -727,7 +727,7 @@ static int __devexit madgemc_remove(struct device *device)
        return 0;
 }
-static short madgemc_adapter_ids[] __initdata = {
+static const short madgemc_adapter_ids[] __devinitconst = {
        0x002d,
        0x0000
 };
diff --git a/drivers/net/tokenring/olympic.c b/drivers/net/tokenring/olympic.c
index 2684003b8ab6..e3855aeb13d4 100644
--- a/drivers/net/tokenring/olympic.c
+++ b/drivers/net/tokenring/olympic.c
@@ -86,6 +86,7 @@
 #include <linux/timer.h>
 #include <linux/in.h>
 #include <linux/ioport.h>
+#include <linux/seq_file.h>
 #include <linux/string.h>
 #include <linux/proc_fs.h>
 #include <linux/ptrace.h>
@@ -193,7 +194,7 @@ static void olympic_arb_cmd(struct net_device *dev);
 static int olympic_change_mtu(struct net_device *dev, int mtu);
 static void olympic_srb_bh(struct net_device *dev) ; 
 static void olympic_asb_bh(struct net_device *dev) ; 
-static int olympic_proc_info(char *buffer, char **start, off_t offset, int length, int *eof, void *data) ; 
+static const struct file_operations olympic_proc_ops;
 static const struct net_device_ops olympic_netdev_ops = {
        .ndo_open               = olympic_open,
@@ -272,7 +273,7 @@ static int __devinit olympic_probe(struct pci_dev *pdev, const struct pci_device
                char proc_name[20] ; 
                strcpy(proc_name,"olympic_") ;
                strcat(proc_name,dev->name) ; 
-                create_proc_read_entry(proc_name,0,init_net.proc_net,olympic_proc_info,(void *)dev) ;
+                proc_create_data(proc_name, 0, init_net.proc_net, &olympic_proc_ops, dev);
                printk("Olympic: Network Monitor information: /proc/%s\n",proc_name); 
        }
        return  0 ;
@@ -1615,29 +1616,25 @@ static int olympic_change_mtu(struct net_device *dev, int mtu)
        return 0 ; 
 }
-static int olympic_proc_info(char *buffer, char **start, off_t offset, int length, int *eof, void *data)
+static int olympic_proc_show(struct seq_file *m, void *v)
 {
-        struct net_device *dev = (struct net_device *)data ; 
+        struct net_device *dev = m->private;
        struct olympic_private *olympic_priv=netdev_priv(dev);
        u8 __iomem *oat = (olympic_priv->olympic_lap + olympic_priv->olympic_addr_table_addr) ; 
        u8 __iomem *opt = (olympic_priv->olympic_lap + olympic_priv->olympic_parms_addr) ; 
-        int size = 0 ; 
-        int len=0;
-        off_t begin=0;
-        off_t pos=0;
        u8 addr[6];
        u8 addr2[6];
        int i;
-        size = sprintf(buffer, 
+        seq_printf(m,
                "IBM Pit/Pit-Phy/Olympic Chipset Token Ring Adapter %s\n",dev->name);
-        size += sprintf(buffer+size, "\n%6s: Adapter Address   : Node Address      : Functional Addr\n",
+        seq_printf(m, "\n%6s: Adapter Address   : Node Address      : Functional Addr\n",
           dev->name); 
        for (i = 0 ; i < 6 ; i++)
                addr[i] = readb(oat+offsetof(struct olympic_adapter_addr_table,node_addr) + i);
-        size += sprintf(buffer+size, "%6s: %pM : %pM : %02x:%02x:%02x:%02x\n",
+        seq_printf(m, "%6s: %pM : %pM : %02x:%02x:%02x:%02x\n",
           dev->name,
           dev->dev_addr, addr,
           readb(oat+offsetof(struct olympic_adapter_addr_table,func_addr)), 
@@ -1645,9 +1642,9 @@ static int olympic_proc_info(char *buffer, char **start, off_t offset, int lengt
           readb(oat+offsetof(struct olympic_adapter_addr_table,func_addr)+2),
           readb(oat+offsetof(struct olympic_adapter_addr_table,func_addr)+3));
         
-        size += sprintf(buffer+size, "\n%6s: Token Ring Parameters Table:\n", dev->name);
+        seq_printf(m, "\n%6s: Token Ring Parameters Table:\n", dev->name);
-        size += sprintf(buffer+size, "%6s: Physical Addr : Up Node Address   : Poll Address      : AccPri : Auth Src : Att Code :\n",
+        seq_printf(m, "%6s: Physical Addr : Up Node Address   : Poll Address      : AccPri : Auth Src : Att Code :\n",
          dev->name) ; 
        for (i = 0 ; i < 6 ; i++)
@@ -1655,7 +1652,7 @@ static int olympic_proc_info(char *buffer, char **start, off_t offset, int lengt
        for (i = 0 ; i < 6 ; i++)
                addr2[i] =  readb(opt+offsetof(struct olympic_parameters_table, poll_addr) + i);
-        size += sprintf(buffer+size, "%6s: %02x:%02x:%02x:%02x   : %pM : %pM : %04x   : %04x     :  %04x    :\n",
+        seq_printf(m, "%6s: %02x:%02x:%02x:%02x   : %pM : %pM : %04x   : %04x     :  %04x    :\n",
          dev->name,
          readb(opt+offsetof(struct olympic_parameters_table, phys_addr)),
          readb(opt+offsetof(struct olympic_parameters_table, phys_addr)+1),
@@ -1666,12 +1663,12 @@ static int olympic_proc_info(char *buffer, char **start, off_t offset, int lengt
          swab16(readw(opt+offsetof(struct olympic_parameters_table, auth_source_class))),
          swab16(readw(opt+offsetof(struct olympic_parameters_table, att_code))));
-        size += sprintf(buffer+size, "%6s: Source Address    : Bcn T : Maj. V : Lan St : Lcl Rg : Mon Err : Frame Correl : \n",
+        seq_printf(m, "%6s: Source Address    : Bcn T : Maj. V : Lan St : Lcl Rg : Mon Err : Frame Correl : \n",
          dev->name) ; 
        
        for (i = 0 ; i < 6 ; i++)
                addr[i] = readb(opt+offsetof(struct olympic_parameters_table, source_addr) + i);
-        size += sprintf(buffer+size, "%6s: %pM : %04x  : %04x   : %04x   : %04x   : %04x    :     %04x     : \n",
+        seq_printf(m, "%6s: %pM : %04x  : %04x   : %04x   : %04x   : %04x    :     %04x     : \n",
          dev->name, addr,
          swab16(readw(opt+offsetof(struct olympic_parameters_table, beacon_type))),
          swab16(readw(opt+offsetof(struct olympic_parameters_table, major_vector))),
@@ -1680,12 +1677,12 @@ static int olympic_proc_info(char *buffer, char **start, off_t offset, int lengt
          swab16(readw(opt+offsetof(struct olympic_parameters_table, mon_error))),
          swab16(readw(opt+offsetof(struct olympic_parameters_table, frame_correl))));
-        size += sprintf(buffer+size, "%6s: Beacon Details :  Tx  :  Rx  : NAUN Node Address : NAUN Node Phys : \n",
+        seq_printf(m, "%6s: Beacon Details :  Tx  :  Rx  : NAUN Node Address : NAUN Node Phys : \n",
          dev->name) ; 
        for (i = 0 ; i < 6 ; i++)
                addr[i] = readb(opt+offsetof(struct olympic_parameters_table, beacon_naun) + i);
-        size += sprintf(buffer+size, "%6s:                :  %02x  :  %02x  : %pM : %02x:%02x:%02x:%02x    : \n",
+        seq_printf(m, "%6s:                :  %02x  :  %02x  : %pM : %02x:%02x:%02x:%02x    : \n",
          dev->name,
          swab16(readw(opt+offsetof(struct olympic_parameters_table, beacon_transmit))),
          swab16(readw(opt+offsetof(struct olympic_parameters_table, beacon_receive))),
@@ -1695,19 +1692,21 @@ static int olympic_proc_info(char *buffer, char **start, off_t offset, int lengt
          readb(opt+offsetof(struct olympic_parameters_table, beacon_phys)+2),
          readb(opt+offsetof(struct olympic_parameters_table, beacon_phys)+3));
-        len=size;
+        return 0;
-        pos=begin+size;
-        if (pos<offset) {
-                len=0;
-                begin=pos;
-        }
-        *start=buffer+(offset-begin);   /* Start of wanted data */
-        len-=(offset-begin);            /* Start slop */
-        if(len>length)
-                len=length;             /* Ending slop */
-        return len;
 }
+static int olympic_proc_open(struct inode *inode, struct file *file)
+{
+        return single_open(file, olympic_proc_show, PDE(inode)->data);
+}
+static const struct file_operations olympic_proc_ops = {
+        .open           = olympic_proc_open,
+        .read           = seq_read,
+        .llseek         = seq_lseek,
+        .release        = single_release,
+};
 static void __devexit olympic_remove_one(struct pci_dev *pdev) 
 {
        struct net_device *dev = pci_get_drvdata(pdev) ; 
diff --git a/drivers/net/tulip/21142.c b/drivers/net/tulip/21142.c
index 007d8e75666d..092c3faa882a 100644
--- a/drivers/net/tulip/21142.c
+++ b/drivers/net/tulip/21142.c
@@ -122,8 +122,8 @@ void t21142_start_nway(struct net_device *dev)
        tp->nway = tp->mediasense = 1;
        tp->nwayset = tp->lpar = 0;
        if (tulip_debug > 1)
-                printk(KERN_DEBUG "%s: Restarting 21143 autonegotiation, csr14=%08x\n",
+                netdev_dbg(dev, "Restarting 21143 autonegotiation, csr14=%08x\n",
-                       dev->name, csr14);
+                           csr14);
        iowrite32(0x0001, ioaddr + CSR13);
        udelay(100);
        iowrite32(csr14, ioaddr + CSR14);
@@ -206,14 +206,14 @@ void t21142_lnk_change(struct net_device *dev, int csr5)
 #if 0                                                   /* Restart shouldn't be needed. */
                iowrite32(tp->csr6 | RxOn, ioaddr + CSR6);
                if (tulip_debug > 2)
-                        printk(KERN_DEBUG "%s:  Restarting Tx and Rx, CSR5 is %08x\n",
+                        netdev_dbg(dev, " Restarting Tx and Rx, CSR5 is %08x\n",
-                               dev->name, ioread32(ioaddr + CSR5));
+                                   ioread32(ioaddr + CSR5));
 #endif
                tulip_start_rxtx(tp);
                if (tulip_debug > 2)
-                        printk(KERN_DEBUG "%s:  Setting CSR6 %08x/%x CSR12 %08x\n",
+                        netdev_dbg(dev, " Setting CSR6 %08x/%x CSR12 %08x\n",
-                               dev->name, tp->csr6, ioread32(ioaddr + CSR6),
+                                   tp->csr6, ioread32(ioaddr + CSR6),
-                               ioread32(ioaddr + CSR12));
+                                   ioread32(ioaddr + CSR12));
        } else if ((tp->nwayset  &&  (csr5 & 0x08000000) &&
                    (dev->if_port == 3  ||  dev->if_port == 5) &&
                    (csr12 & 2) == 2) ||
diff --git a/drivers/net/tulip/Makefile b/drivers/net/tulip/Makefile
index 200cbf7c815c..5e8be38b45bb 100644
--- a/drivers/net/tulip/Makefile
+++ b/drivers/net/tulip/Makefile
@@ -2,6 +2,8 @@
 # Makefile for the Linux "Tulip" family network device drivers.
 #
+ccflags-$(CONFIG_NET_TULIP)     := -DDEBUG
 obj-$(CONFIG_PCMCIA_XIRCOM)     += xircom_cb.o
 obj-$(CONFIG_DM9102)            += dmfe.o
 obj-$(CONFIG_WINBOND_840)       += winbond-840.o
diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
index b13c6b040be3..e2f692351180 100644
--- a/drivers/net/tulip/de2104x.c
+++ b/drivers/net/tulip/de2104x.c
@@ -27,6 +27,8 @@
 */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #define DRV_NAME                "de2104x"
 #define DRV_VERSION             "0.7"
 #define DRV_RELDATE             "Mar 17, 2004"
@@ -51,7 +53,7 @@
 /* These identify the driver base version and may not be removed. */
 static char version[] =
-KERN_INFO DRV_NAME " PCI Ethernet driver v" DRV_VERSION " (" DRV_RELDATE ")\n";
+"PCI Ethernet driver v" DRV_VERSION " (" DRV_RELDATE ")";
 MODULE_AUTHOR("Jeff Garzik <jgarzik@pobox.com>");
 MODULE_DESCRIPTION("Intel/Digital 21040/1 series PCI Ethernet driver");
@@ -73,8 +75,6 @@ static int rx_copybreak = 100;
 module_param (rx_copybreak, int, 0);
 MODULE_PARM_DESC (rx_copybreak, "de2104x Breakpoint at which Rx packets are copied");
-#define PFX                     DRV_NAME ": "
 #define DE_DEF_MSG_ENABLE       (NETIF_MSG_DRV          | \
                                 NETIF_MSG_PROBE        | \
                                 NETIF_MSG_LINK         | \
@@ -377,18 +377,16 @@ static u16 t21041_csr15[] = { 0x0008, 0x0006, 0x000E, 0x0008, 0x0008, };
 static void de_rx_err_acct (struct de_private *de, unsigned rx_tail,
                            u32 status, u32 len)
 {
-        if (netif_msg_rx_err (de))
+        netif_dbg(de, rx_err, de->dev,
-                printk (KERN_DEBUG
+                  "rx err, slot %d status 0x%x len %d\n",
-                        "%s: rx err, slot %d status 0x%x len %d\n",
+                  rx_tail, status, len);
-                        de->dev->name, rx_tail, status, len);
        if ((status & 0x38000300) != 0x0300) {
                /* Ingore earlier buffers. */
                if ((status & 0xffff) != 0x7fff) {
-                        if (netif_msg_rx_err(de))
+                        netif_warn(de, rx_err, de->dev,
-                                dev_warn(&de->dev->dev,
+                                   "Oversized Ethernet frame spanned multiple buffers, status %08x!\n",
-                                         "Oversized Ethernet frame spanned multiple buffers, status %08x!\n",
+                                   status);
-                                         status);
                        de->net_stats.rx_length_errors++;
                }
        } else if (status & RxError) {
@@ -435,10 +433,9 @@ static void de_rx (struct de_private *de)
                copying_skb = (len <= rx_copybreak);
-                if (unlikely(netif_msg_rx_status(de)))
+                netif_dbg(de, rx_status, de->dev,
-                        printk(KERN_DEBUG "%s: rx slot %d status 0x%x len %d copying? %d\n",
+                          "rx slot %d status 0x%x len %d copying? %d\n",
-                               de->dev->name, rx_tail, status, len,
+                          rx_tail, status, len, copying_skb);
-                               copying_skb);
                buflen = copying_skb ? (len + RX_OFFSET) : de->rx_buf_sz;
                copy_skb = dev_alloc_skb (buflen);
@@ -491,7 +488,7 @@ rx_next:
        }
        if (!rx_work)
-                dev_warn(&de->dev->dev, "rx work limit reached\n");
+                netdev_warn(de->dev, "rx work limit reached\n");
        de->rx_tail = rx_tail;
 }
@@ -506,10 +503,9 @@ static irqreturn_t de_interrupt (int irq, void *dev_instance)
        if ((!(status & (IntrOK|IntrErr))) || (status == 0xFFFF))
                return IRQ_NONE;
-        if (netif_msg_intr(de))
+        netif_dbg(de, intr, dev, "intr, status %08x mode %08x desc %u/%u/%u\n",
-                printk(KERN_DEBUG "%s: intr, status %08x mode %08x desc %u/%u/%u\n",
+                  status, dr32(MacMode),
-                       dev->name, status, dr32(MacMode),
+                  de->rx_tail, de->tx_head, de->tx_tail);
-                       de->rx_tail, de->tx_head, de->tx_tail);
        dw32(MacStatus, status);
@@ -534,9 +530,9 @@ static irqreturn_t de_interrupt (int irq, void *dev_instance)
                pci_read_config_word(de->pdev, PCI_STATUS, &pci_status);
                pci_write_config_word(de->pdev, PCI_STATUS, pci_status);
-                dev_err(&de->dev->dev,
+                netdev_err(de->dev,
-                        "PCI bus error, status=%08x, PCI status=%04x\n",
+                           "PCI bus error, status=%08x, PCI status=%04x\n",
-                        status, pci_status);
+                           status, pci_status);
        }
        return IRQ_HANDLED;
@@ -572,9 +568,9 @@ static void de_tx (struct de_private *de)
                if (status & LastFrag) {
                        if (status & TxError) {
-                                if (netif_msg_tx_err(de))
+                                netif_dbg(de, tx_err, de->dev,
-                                        printk(KERN_DEBUG "%s: tx err, status 0x%x\n",
+                                          "tx err, status 0x%x\n",
-                                               de->dev->name, status);
+                                          status);
                                de->net_stats.tx_errors++;
                                if (status & TxOWC)
                                        de->net_stats.tx_window_errors++;
@@ -587,9 +583,8 @@ static void de_tx (struct de_private *de)
                        } else {
                                de->net_stats.tx_packets++;
                                de->net_stats.tx_bytes += skb->len;
-                                if (netif_msg_tx_done(de))
+                                netif_dbg(de, tx_done, de->dev,
-                                        printk(KERN_DEBUG "%s: tx done, slot %d\n",
+                                          "tx done, slot %d\n", tx_tail);
-                                               de->dev->name, tx_tail);
                        }
                        dev_kfree_skb_irq(skb);
                }
@@ -646,9 +641,8 @@ static netdev_tx_t de_start_xmit (struct sk_buff *skb,
        wmb();
        de->tx_head = NEXT_TX(entry);
-        if (netif_msg_tx_queued(de))
+        netif_dbg(de, tx_queued, dev, "tx queued, slot %d, skblen %d\n",
-                printk(KERN_DEBUG "%s: tx queued, slot %d, skblen %d\n",
+                  entry, skb->len);
-                       dev->name, entry, skb->len);
        if (tx_free == 0)
                netif_stop_queue(dev);
@@ -873,7 +867,7 @@ static void de_stop_rxtx (struct de_private *de)
                udelay(100);
        }
-        dev_warn(&de->dev->dev, "timeout expired stopping DMA\n");
+        netdev_warn(de->dev, "timeout expired, stopping DMA\n");
 }
 static inline void de_start_rxtx (struct de_private *de)
@@ -907,9 +901,8 @@ static void de_link_up(struct de_private *de)
 {
        if (!netif_carrier_ok(de->dev)) {
                netif_carrier_on(de->dev);
-                if (netif_msg_link(de))
+                netif_info(de, link, de->dev, "link up, media %s\n",
-                        dev_info(&de->dev->dev, "link up, media %s\n",
+                           media_name[de->media_type]);
-                                 media_name[de->media_type]);
        }
 }
@@ -917,8 +910,7 @@ static void de_link_down(struct de_private *de)
 {
        if (netif_carrier_ok(de->dev)) {
                netif_carrier_off(de->dev);
-                if (netif_msg_link(de))
+                netif_info(de, link, de->dev, "link down\n");
-                        dev_info(&de->dev->dev, "link down\n");
        }
 }
@@ -928,8 +920,7 @@ static void de_set_media (struct de_private *de)
        u32 macmode = dr32(MacMode);
        if (de_is_running(de))
-                dev_warn(&de->dev->dev,
+                netdev_warn(de->dev, "chip is running while changing media!\n");
-                         "chip is running while changing media!\n");
        if (de->de21040)
                dw32(CSR11, FULL_DUPLEX_MAGIC);
@@ -948,18 +939,13 @@ static void de_set_media (struct de_private *de)
        else
                macmode &= ~FullDuplex;
-        if (netif_msg_link(de))
+        netif_info(de, link, de->dev, "set link %s\n", media_name[media]);
-                dev_info(&de->dev->dev, "set link %s\n", media_name[media]);
+        netif_info(de, hw, de->dev, "mode 0x%x, sia 0x%x,0x%x,0x%x,0x%x\n",
-        if (netif_msg_hw(de)) {
+                   dr32(MacMode), dr32(SIAStatus),
-                dev_info(&de->dev->dev, "mode 0x%x, sia 0x%x,0x%x,0x%x,0x%x\n",
+                   dr32(CSR13), dr32(CSR14), dr32(CSR15));
-                         dr32(MacMode), dr32(SIAStatus),
+        netif_info(de, hw, de->dev, "set mode 0x%x, set sia 0x%x,0x%x,0x%x\n",
-                         dr32(CSR13), dr32(CSR14), dr32(CSR15));
+                   macmode, de->media[media].csr13,
+                   de->media[media].csr14, de->media[media].csr15);
-                dev_info(&de->dev->dev,
-                         "set mode 0x%x, set sia 0x%x,0x%x,0x%x\n",
-                         macmode, de->media[media].csr13,
-                         de->media[media].csr14, de->media[media].csr15);
-        }
        if (macmode != dr32(MacMode))
                dw32(MacMode, macmode);
 }
@@ -996,9 +982,8 @@ static void de21040_media_timer (unsigned long data)
                if (!netif_carrier_ok(dev))
                        de_link_up(de);
                else
-                        if (netif_msg_timer(de))
+                        netif_info(de, timer, dev, "%s link ok, status %x\n",
-                                dev_info(&dev->dev, "%s link ok, status %x\n",
+                                   media_name[de->media_type], status);
-                                         media_name[de->media_type], status);
                return;
        }
@@ -1025,9 +1010,8 @@ no_link_yet:
        de->media_timer.expires = jiffies + DE_TIMER_NO_LINK;
        add_timer(&de->media_timer);
-        if (netif_msg_timer(de))
+        netif_info(de, timer, dev, "no link, trying media %s, status %x\n",
-                dev_info(&dev->dev, "no link, trying media %s, status %x\n",
+                   media_name[de->media_type], status);
-                         media_name[de->media_type], status);
 }
 static unsigned int de_ok_to_advertise (struct de_private *de, u32 new_media)
@@ -1085,11 +1069,10 @@ static void de21041_media_timer (unsigned long data)
                if (!netif_carrier_ok(dev))
                        de_link_up(de);
                else
-                        if (netif_msg_timer(de))
+                        netif_info(de, timer, dev,
-                                dev_info(&dev->dev,
+                                   "%s link ok, mode %x status %x\n",
-                                         "%s link ok, mode %x status %x\n",
+                                   media_name[de->media_type],
-                                         media_name[de->media_type],
+                                   dr32(MacMode), status);
-                                         dr32(MacMode), status);
                return;
        }
@@ -1163,9 +1146,8 @@ no_link_yet:
        de->media_timer.expires = jiffies + DE_TIMER_NO_LINK;
        add_timer(&de->media_timer);
-        if (netif_msg_timer(de))
+        netif_info(de, timer, dev, "no link, trying media %s, status %x\n",
-                dev_info(&dev->dev, "no link, trying media %s, status %x\n",
+                   media_name[de->media_type], status);
-                         media_name[de->media_type], status);
 }
 static void de_media_interrupt (struct de_private *de, u32 status)
@@ -1401,14 +1383,13 @@ static int de_open (struct net_device *dev)
        struct de_private *de = netdev_priv(dev);
        int rc;
-        if (netif_msg_ifup(de))
+        netif_dbg(de, ifup, dev, "enabling interface\n");
-                printk(KERN_DEBUG "%s: enabling interface\n", dev->name);
        de->rx_buf_sz = (dev->mtu <= 1500 ? PKT_BUF_SZ : dev->mtu + 32);
        rc = de_alloc_rings(de);
        if (rc) {
-                dev_err(&dev->dev, "ring allocation failure, err=%d\n", rc);
+                netdev_err(dev, "ring allocation failure, err=%d\n", rc);
                return rc;
        }
@@ -1416,14 +1397,14 @@ static int de_open (struct net_device *dev)
        rc = request_irq(dev->irq, de_interrupt, IRQF_SHARED, dev->name, dev);
        if (rc) {
-                dev_err(&dev->dev, "IRQ %d request failure, err=%d\n",
+                netdev_err(dev, "IRQ %d request failure, err=%d\n",
-                        dev->irq, rc);
+                           dev->irq, rc);
                goto err_out_free;
        }
        rc = de_init_hw(de);
        if (rc) {
-                dev_err(&dev->dev, "h/w init failure, err=%d\n", rc);
+                netdev_err(dev, "h/w init failure, err=%d\n", rc);
                goto err_out_free_irq;
        }
@@ -1444,8 +1425,7 @@ static int de_close (struct net_device *dev)
        struct de_private *de = netdev_priv(dev);
        unsigned long flags;
-        if (netif_msg_ifdown(de))
+        netif_dbg(de, ifdown, dev, "disabling interface\n");
-                printk(KERN_DEBUG "%s: disabling interface\n", dev->name);
        del_timer_sync(&de->media_timer);
@@ -1466,9 +1446,9 @@ static void de_tx_timeout (struct net_device *dev)
 {
        struct de_private *de = netdev_priv(dev);
-        printk(KERN_DEBUG "%s: NIC status %08x mode %08x sia %08x desc %u/%u/%u\n",
+        netdev_dbg(dev, "NIC status %08x mode %08x sia %08x desc %u/%u/%u\n",
-               dev->name, dr32(MacStatus), dr32(MacMode), dr32(SIAStatus),
+                   dr32(MacStatus), dr32(MacMode), dr32(SIAStatus),
-               de->rx_tail, de->tx_head, de->tx_tail);
+                   de->rx_tail, de->tx_head, de->tx_tail);
        del_timer_sync(&de->media_timer);
@@ -1518,18 +1498,17 @@ static int __de_get_settings(struct de_private *de, struct ethtool_cmd *ecmd)
        switch (de->media_type) {
        case DE_MEDIA_AUI:
                ecmd->port = PORT_AUI;
-                ecmd->speed = 5;
                break;
        case DE_MEDIA_BNC:
                ecmd->port = PORT_BNC;
-                ecmd->speed = 2;
                break;
        default:
                ecmd->port = PORT_TP;
-                ecmd->speed = SPEED_10;
                break;
        }
+        ethtool_cmd_speed_set(ecmd, 10);
        if (dr32(MacMode) & FullDuplex)
                ecmd->duplex = DUPLEX_FULL;
        else
@@ -1550,9 +1529,7 @@ static int __de_set_settings(struct de_private *de, struct ethtool_cmd *ecmd)
        u32 new_media;
        unsigned int media_lock;
-        if (ecmd->speed != SPEED_10 && ecmd->speed != 5 && ecmd->speed != 2)
+        if (ethtool_cmd_speed(ecmd) != 10)
-                return -EINVAL;
-        if (de->de21040 && ecmd->speed == 2)
                return -EINVAL;
        if (ecmd->duplex != DUPLEX_HALF && ecmd->duplex != DUPLEX_FULL)
                return -EINVAL;
@@ -1696,9 +1673,8 @@ static int de_nway_reset(struct net_device *dev)
        status = dr32(SIAStatus);
        dw32(SIAStatus, (status & ~NWayState) | NWayRestart);
-        if (netif_msg_link(de))
+        netif_info(de, link, dev, "link nway restart, status %x,%x\n",
-                dev_info(&de->dev->dev, "link nway restart, status %x,%x\n",
+                   status, dr32(SIAStatus));
-                         status, dr32(SIAStatus));
        return 0;
 }
@@ -1743,7 +1719,8 @@ static void __devinit de21040_get_mac_address (struct de_private *de)
                de->dev->dev_addr[i] = value;
                udelay(1);
                if (boguscnt <= 0)
-                        pr_warning(PFX "timeout reading 21040 MAC address byte %u\n", i);
+                        pr_warn("timeout reading 21040 MAC address byte %u\n",
+                                i);
        }
 }
@@ -1929,8 +1906,10 @@ static void __devinit de21041_get_srom_info (struct de_private *de)
                                        de->media[idx].csr14,
                                        de->media[idx].csr15);
-                } else if (netif_msg_probe(de))
+                } else {
-                        pr_cont("\n");
+                        if (netif_msg_probe(de))
+                                pr_cont("\n");
+                }
                if (bufp > ((void *)&ee_data[DE_EEPROM_SIZE - 3]))
                        break;
@@ -1999,7 +1978,7 @@ static int __devinit de_init_one (struct pci_dev *pdev,
 #ifndef MODULE
        if (board_idx == 0)
-                printk("%s", version);
+                pr_info("%s\n", version);
 #endif
        /* allocate a new ethernet device structure, and fill in defaults */
@@ -2041,7 +2020,7 @@ static int __devinit de_init_one (struct pci_dev *pdev,
        /* check for invalid IRQ value */
        if (pdev->irq < 2) {
                rc = -EIO;
-                pr_err(PFX "invalid irq (%d) for pci dev %s\n",
+                pr_err("invalid irq (%d) for pci dev %s\n",
                       pdev->irq, pci_name(pdev));
                goto err_out_res;
        }
@@ -2052,12 +2031,12 @@ static int __devinit de_init_one (struct pci_dev *pdev,
        pciaddr = pci_resource_start(pdev, 1);
        if (!pciaddr) {
                rc = -EIO;
-                pr_err(PFX "no MMIO resource for pci dev %s\n", pci_name(pdev));
+                pr_err("no MMIO resource for pci dev %s\n", pci_name(pdev));
                goto err_out_res;
        }
        if (pci_resource_len(pdev, 1) < DE_REGS_SIZE) {
                rc = -EIO;
-                pr_err(PFX "MMIO resource (%llx) too small on pci dev %s\n",
+                pr_err("MMIO resource (%llx) too small on pci dev %s\n",
                       (unsigned long long)pci_resource_len(pdev, 1),
                       pci_name(pdev));
                goto err_out_res;
@@ -2067,7 +2046,7 @@ static int __devinit de_init_one (struct pci_dev *pdev,
        regs = ioremap_nocache(pciaddr, DE_REGS_SIZE);
        if (!regs) {
                rc = -EIO;
-                pr_err(PFX "Cannot map PCI MMIO (%llx@%lx) on pci dev %s\n",
+                pr_err("Cannot map PCI MMIO (%llx@%lx) on pci dev %s\n",
                       (unsigned long long)pci_resource_len(pdev, 1),
                       pciaddr, pci_name(pdev));
                goto err_out_res;
@@ -2080,7 +2059,7 @@ static int __devinit de_init_one (struct pci_dev *pdev,
        /* make sure hardware is not running */
        rc = de_reset_mac(de);
        if (rc) {
-                pr_err(PFX "Cannot reset MAC, pci dev %s\n", pci_name(pdev));
+                pr_err("Cannot reset MAC, pci dev %s\n", pci_name(pdev));
                goto err_out_iomap;
        }
@@ -2100,11 +2079,11 @@ static int __devinit de_init_one (struct pci_dev *pdev,
                goto err_out_iomap;
        /* print info about board and interface just registered */
-        dev_info(&dev->dev, "%s at 0x%lx, %pM, IRQ %d\n",
+        netdev_info(dev, "%s at 0x%lx, %pM, IRQ %d\n",
-                 de->de21040 ? "21040" : "21041",
+                    de->de21040 ? "21040" : "21041",
-                 dev->base_addr,
+                    dev->base_addr,
-                 dev->dev_addr,
+                    dev->dev_addr,
-                 dev->irq);
+                    dev->irq);
        pci_set_drvdata(pdev, dev);
@@ -2192,7 +2171,7 @@ static int de_resume (struct pci_dev *pdev)
        if (!netif_running(dev))
                goto out_attach;
        if ((retval = pci_enable_device(pdev))) {
-                dev_err(&dev->dev, "pci_enable_device failed in resume\n");
+                netdev_err(dev, "pci_enable_device failed in resume\n");
                goto out;
        }
        pci_set_master(pdev);
@@ -2221,7 +2200,7 @@ static struct pci_driver de_driver = {
 static int __init de_init (void)
 {
 #ifdef MODULE
-        printk("%s", version);
+        pr_info("%s\n", version);
 #endif
        return pci_register_driver(&de_driver);
 }
diff --git a/drivers/net/tulip/de4x5.c b/drivers/net/tulip/de4x5.c
index efaa1d69b720..45144d5bd11b 100644
--- a/drivers/net/tulip/de4x5.c
+++ b/drivers/net/tulip/de4x5.c
@@ -1995,7 +1995,7 @@ SetMulticastFilter(struct net_device *dev)
 static u_char de4x5_irq[] = EISA_ALLOWED_IRQ_LIST;
-static int __init de4x5_eisa_probe (struct device *gendev)
+static int __devinit de4x5_eisa_probe (struct device *gendev)
 {
        struct eisa_device *edev;
        u_long iobase;
@@ -2097,7 +2097,7 @@ static int __devexit de4x5_eisa_remove (struct device *device)
        return 0;
 }
-static struct eisa_device_id de4x5_eisa_ids[] = {
+static const struct eisa_device_id de4x5_eisa_ids[] __devinitconst = {
        { "DEC4250", 0 },       /* 0 is the board name index... */
        { "" }
 };
diff --git a/drivers/net/tulip/dmfe.c b/drivers/net/tulip/dmfe.c
index fb07f48910ae..468512731966 100644
--- a/drivers/net/tulip/dmfe.c
+++ b/drivers/net/tulip/dmfe.c
@@ -295,8 +295,7 @@ enum dmfe_CR6_bits {
 /* Global variable declaration ----------------------------- */
 static int __devinitdata printed_version;
 static const char version[] __devinitconst =
-        KERN_INFO DRV_NAME ": Davicom DM9xxx net driver, version "
+        "Davicom DM9xxx net driver, version " DRV_VERSION " (" DRV_RELDATE ")";
-        DRV_VERSION " (" DRV_RELDATE ")\n";
 static int dmfe_debug;
 static unsigned char dmfe_media_mode = DMFE_AUTO;
@@ -381,7 +380,7 @@ static int __devinit dmfe_init_one (struct pci_dev *pdev,
        DMFE_DBUG(0, "dmfe_init_one()", 0);
        if (!printed_version++)
-                printk(version);
+                pr_info("%s\n", version);
        /*
         *      SPARC on-board DM910x chips should be handled by the main
@@ -406,7 +405,7 @@ static int __devinit dmfe_init_one (struct pci_dev *pdev,
        SET_NETDEV_DEV(dev, &pdev->dev);
        if (pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) {
-                pr_warning("32-bit PCI DMA not available\n");
+                pr_warn("32-bit PCI DMA not available\n");
                err = -ENODEV;
                goto err_out_free;
        }
@@ -2203,7 +2202,7 @@ static int __init dmfe_init_module(void)
 {
        int rc;
-        printk(version);
+        pr_info("%s\n", version);
        printed_version = 1;
        DMFE_DBUG(0, "init_module() ", debug);
diff --git a/drivers/net/tulip/eeprom.c b/drivers/net/tulip/eeprom.c
index 296486bf0956..fa5eee925f25 100644
--- a/drivers/net/tulip/eeprom.c
+++ b/drivers/net/tulip/eeprom.c
@@ -222,8 +222,8 @@ subsequent_board:
                /* there is no phy information, don't even try to build mtable */
                if (count == 0) {
                        if (tulip_debug > 0)
-                                pr_warning("%s: no phy info, aborting mtable build\n",
+                                pr_warn("%s: no phy info, aborting mtable build\n",
-                                           dev->name);
+                                        dev->name);
                        return;
                }
diff --git a/drivers/net/tulip/interrupt.c b/drivers/net/tulip/interrupt.c
index 0013642903ee..5350d753e0ff 100644
--- a/drivers/net/tulip/interrupt.c
+++ b/drivers/net/tulip/interrupt.c
@@ -125,12 +125,12 @@ int tulip_poll(struct napi_struct *napi, int budget)
 #endif
        if (tulip_debug > 4)
-                printk(KERN_DEBUG " In tulip_rx(), entry %d %08x\n",
+                netdev_dbg(dev, " In tulip_rx(), entry %d %08x\n",
-                       entry, tp->rx_ring[entry].status);
+                           entry, tp->rx_ring[entry].status);
       do {
                if (ioread32(tp->base_addr + CSR5) == 0xffffffff) {
-                        printk(KERN_DEBUG " In tulip_poll(), hardware disappeared\n");
+                        netdev_dbg(dev, " In tulip_poll(), hardware disappeared\n");
                        break;
                }
               /* Acknowledge current RX interrupt sources. */
@@ -145,9 +145,9 @@ int tulip_poll(struct napi_struct *napi, int budget)
                       if (tp->dirty_rx + RX_RING_SIZE == tp->cur_rx)
                               break;
-                       if (tulip_debug > 5)
+                       if (tulip_debug > 5)
-                               printk(KERN_DEBUG "%s: In tulip_rx(), entry %d %08x\n",
+                                netdev_dbg(dev, "In tulip_rx(), entry %d %08x\n",
-                                      dev->name, entry, status);
+                                           entry, status);
                       if (++work_done >= budget)
                               goto not_done;
@@ -184,9 +184,9 @@ int tulip_poll(struct napi_struct *napi, int budget)
                                        }
                               } else {
                                /* There was a fatal error. */
-                                       if (tulip_debug > 2)
+                                       if (tulip_debug > 2)
-                                               printk(KERN_DEBUG "%s: Receive error, Rx status %08x\n",
+                                                netdev_dbg(dev, "Receive error, Rx status %08x\n",
-                                                      dev->name, status);
+                                                           status);
                                        dev->stats.rx_errors++; /* end of a packet.*/
                                        if (pkt_len > 1518 ||
                                            (status & RxDescRunt))
@@ -367,16 +367,16 @@ static int tulip_rx(struct net_device *dev)
        int received = 0;
        if (tulip_debug > 4)
-                printk(KERN_DEBUG " In tulip_rx(), entry %d %08x\n",
+                netdev_dbg(dev, "In tulip_rx(), entry %d %08x\n",
-                       entry, tp->rx_ring[entry].status);
+                           entry, tp->rx_ring[entry].status);
        /* If we own the next entry, it is a new packet. Send it up. */
        while ( ! (tp->rx_ring[entry].status & cpu_to_le32(DescOwned))) {
                s32 status = le32_to_cpu(tp->rx_ring[entry].status);
                short pkt_len;
                if (tulip_debug > 5)
-                        printk(KERN_DEBUG "%s: In tulip_rx(), entry %d %08x\n",
+                        netdev_dbg(dev, "In tulip_rx(), entry %d %08x\n",
-                               dev->name, entry, status);
+                                   entry, status);
                if (--rx_work_limit < 0)
                        break;
@@ -404,16 +404,16 @@ static int tulip_rx(struct net_device *dev)
                                /* Ingore earlier buffers. */
                                if ((status & 0xffff) != 0x7fff) {
                                        if (tulip_debug > 1)
-                                                dev_warn(&dev->dev,
+                                                netdev_warn(dev,
-                                                         "Oversized Ethernet frame spanned multiple buffers, status %08x!\n",
+                                                            "Oversized Ethernet frame spanned multiple buffers, status %08x!\n",
-                                                         status);
+                                                            status);
                                        dev->stats.rx_length_errors++;
                                }
                        } else {
                                /* There was a fatal error. */
                                if (tulip_debug > 2)
-                                        printk(KERN_DEBUG "%s: Receive error, Rx status %08x\n",
+                                        netdev_dbg(dev, "Receive error, Rx status %08x\n",
-                                               dev->name, status);
+                                                   status);
                                dev->stats.rx_errors++; /* end of a packet.*/
                                if (pkt_len > 1518 ||
                                    (status & RxDescRunt))
@@ -573,8 +573,8 @@ irqreturn_t tulip_interrupt(int irq, void *dev_instance)
 #endif /*  CONFIG_TULIP_NAPI */
                if (tulip_debug > 4)
-                        printk(KERN_DEBUG "%s: interrupt  csr5=%#8.8x new csr5=%#8.8x\n",
+                        netdev_dbg(dev, "interrupt  csr5=%#8.8x new csr5=%#8.8x\n",
-                               dev->name, csr5, ioread32(ioaddr + CSR5));
+                                   csr5, ioread32(ioaddr + CSR5));
                if (csr5 & (TxNoBuf | TxDied | TxIntr | TimerInt)) {
@@ -605,8 +605,8 @@ irqreturn_t tulip_interrupt(int irq, void *dev_instance)
                                        /* There was an major error, log it. */
 #ifndef final_version
                                        if (tulip_debug > 1)
-                                                printk(KERN_DEBUG "%s: Transmit error, Tx status %08x\n",
+                                                netdev_dbg(dev, "Transmit error, Tx status %08x\n",
-                                                       dev->name, status);
+                                                           status);
 #endif
                                        dev->stats.tx_errors++;
                                        if (status & 0x4104)
@@ -804,8 +804,8 @@ irqreturn_t tulip_interrupt(int irq, void *dev_instance)
        }
        if (tulip_debug > 4)
-                printk(KERN_DEBUG "%s: exiting interrupt, csr5=%#04x\n",
+                netdev_dbg(dev, "exiting interrupt, csr5=%#04x\n",
-                       dev->name, ioread32(ioaddr + CSR5));
+                           ioread32(ioaddr + CSR5));
        return IRQ_HANDLED;
 }
diff --git a/drivers/net/tulip/media.c b/drivers/net/tulip/media.c
index a0c770ee4b64..4bd13922875d 100644
--- a/drivers/net/tulip/media.c
+++ b/drivers/net/tulip/media.c
@@ -182,8 +182,8 @@ void tulip_select_media(struct net_device *dev, int startup)
                switch (mleaf->type) {
                case 0:                                 /* 21140 non-MII xcvr. */
                        if (tulip_debug > 1)
-                                printk(KERN_DEBUG "%s: Using a 21140 non-MII transceiver with control setting %02x\n",
+                                netdev_dbg(dev, "Using a 21140 non-MII transceiver with control setting %02x\n",
-                                       dev->name, p[1]);
+                                           p[1]);
                        dev->if_port = p[0];
                        if (startup)
                                iowrite32(mtable->csr12dir | 0x100, ioaddr + CSR12);
@@ -204,15 +204,14 @@ void tulip_select_media(struct net_device *dev, int startup)
                                struct medialeaf *rleaf = &mtable->mleaf[mtable->has_reset];
                                unsigned char *rst = rleaf->leafdata;
                                if (tulip_debug > 1)
-                                        printk(KERN_DEBUG "%s: Resetting the transceiver\n",
+                                        netdev_dbg(dev, "Resetting the transceiver\n");
-                                               dev->name);
                                for (i = 0; i < rst[0]; i++)
                                        iowrite32(get_u16(rst + 1 + (i<<1)) << 16, ioaddr + CSR15);
                        }
                        if (tulip_debug > 1)
-                                printk(KERN_DEBUG "%s: 21143 non-MII %s transceiver control %04x/%04x\n",
+                                netdev_dbg(dev, "21143 non-MII %s transceiver control %04x/%04x\n",
-                                       dev->name, medianame[dev->if_port],
+                                           medianame[dev->if_port],
-                                       setup[0], setup[1]);
+                                           setup[0], setup[1]);
                        if (p[0] & 0x40) {      /* SIA (CSR13-15) setup values are provided. */
                                csr13val = setup[0];
                                csr14val = setup[1];
@@ -239,8 +238,8 @@ void tulip_select_media(struct net_device *dev, int startup)
                                if (startup) iowrite32(csr13val, ioaddr + CSR13);
                        }
                        if (tulip_debug > 1)
-                                printk(KERN_DEBUG "%s:  Setting CSR15 to %08x/%08x\n",
+                                netdev_dbg(dev, "Setting CSR15 to %08x/%08x\n",
-                                       dev->name, csr15dir, csr15val);
+                                           csr15dir, csr15val);
                        if (mleaf->type == 4)
                                new_csr6 = 0x82020000 | ((setup[2] & 0x71) << 18);
                        else
@@ -316,9 +315,9 @@ void tulip_select_media(struct net_device *dev, int startup)
                                if (tp->mii_advertise == 0)
                                        tp->mii_advertise = tp->advertising[phy_num];
                                if (tulip_debug > 1)
-                                        printk(KERN_DEBUG "%s:  Advertising %04x on MII %d\n",
+                                        netdev_dbg(dev, " Advertising %04x on MII %d\n",
-                                               dev->name, tp->mii_advertise,
+                                                   tp->mii_advertise,
-                                               tp->phys[phy_num]);
+                                                   tp->phys[phy_num]);
                                tulip_mdio_write(dev, tp->phys[phy_num], 4, tp->mii_advertise);
                        }
                        break;
@@ -335,8 +334,7 @@ void tulip_select_media(struct net_device *dev, int startup)
                                struct medialeaf *rleaf = &mtable->mleaf[mtable->has_reset];
                                unsigned char *rst = rleaf->leafdata;
                                if (tulip_debug > 1)
-                                        printk(KERN_DEBUG "%s: Resetting the transceiver\n",
+                                        netdev_dbg(dev, "Resetting the transceiver\n");
-                                               dev->name);
                                for (i = 0; i < rst[0]; i++)
                                        iowrite32(get_u16(rst + 1 + (i<<1)) << 16, ioaddr + CSR15);
                        }
@@ -344,20 +342,21 @@ void tulip_select_media(struct net_device *dev, int startup)
                        break;
                }
                default:
-                        printk(KERN_DEBUG "%s:  Invalid media table selection %d\n",
+                        netdev_dbg(dev, " Invalid media table selection %d\n",
-                               dev->name, mleaf->type);
+                                   mleaf->type);
                        new_csr6 = 0x020E0000;
                }
                if (tulip_debug > 1)
-                        printk(KERN_DEBUG "%s: Using media type %s, CSR12 is %02x\n",
+                        netdev_dbg(dev, "Using media type %s, CSR12 is %02x\n",
-                               dev->name, medianame[dev->if_port],
+                                   medianame[dev->if_port],
                                   ioread32(ioaddr + CSR12) & 0xff);
        } else if (tp->chip_id == LC82C168) {
                if (startup && ! tp->medialock)
                        dev->if_port = tp->mii_cnt ? 11 : 0;
                if (tulip_debug > 1)
-                        printk(KERN_DEBUG "%s: PNIC PHY status is %3.3x, media %s\n",
+                        netdev_dbg(dev, "PNIC PHY status is %3.3x, media %s\n",
-                               dev->name, ioread32(ioaddr + 0xB8), medianame[dev->if_port]);
+                                   ioread32(ioaddr + 0xB8),
+                                   medianame[dev->if_port]);
                if (tp->mii_cnt) {
                        new_csr6 = 0x810C0000;
                        iowrite32(0x0001, ioaddr + CSR15);
@@ -388,9 +387,9 @@ void tulip_select_media(struct net_device *dev, int startup)
                } else
                        new_csr6 = 0x03860000;
                if (tulip_debug > 1)
-                        printk(KERN_DEBUG "%s: No media description table, assuming %s transceiver, CSR12 %02x\n",
+                        netdev_dbg(dev, "No media description table, assuming %s transceiver, CSR12 %02x\n",
-                               dev->name, medianame[dev->if_port],
+                                   medianame[dev->if_port],
-                               ioread32(ioaddr + CSR12));
+                                   ioread32(ioaddr + CSR12));
        }
        tp->csr6 = new_csr6 | (tp->csr6 & 0xfdff) | (tp->full_duplex ? 0x0200 : 0);
@@ -504,8 +503,8 @@ void __devinit tulip_find_mii (struct net_device *dev, int board_idx)
                /* Fixup for DLink with miswired PHY. */
                if (mii_advert != to_advert) {
-                        printk(KERN_DEBUG "tulip%d:  Advertising %04x on PHY %d, previously advertising %04x\n",
+                        pr_debug("tulip%d:  Advertising %04x on PHY %d, previously advertising %04x\n",
-                               board_idx, to_advert, phy, mii_advert);
+                                 board_idx, to_advert, phy, mii_advert);
                        tulip_mdio_write (dev, phy, 4, to_advert);
                }
diff --git a/drivers/net/tulip/pnic.c b/drivers/net/tulip/pnic.c
index a63e64b6863d..aa4d9dad0395 100644
--- a/drivers/net/tulip/pnic.c
+++ b/drivers/net/tulip/pnic.c
@@ -40,8 +40,8 @@ void pnic_do_nway(struct net_device *dev)
                        new_csr6 |= 0x00000200;
                }
                if (tulip_debug > 1)
-                        printk(KERN_DEBUG "%s: PNIC autonegotiated status %08x, %s\n",
+                        netdev_dbg(dev, "PNIC autonegotiated status %08x, %s\n",
-                               dev->name, phy_reg, medianame[dev->if_port]);
+                                   phy_reg, medianame[dev->if_port]);
                if (tp->csr6 != new_csr6) {
                        tp->csr6 = new_csr6;
                        /* Restart Tx */
@@ -58,8 +58,8 @@ void pnic_lnk_change(struct net_device *dev, int csr5)
        int phy_reg = ioread32(ioaddr + 0xB8);
        if (tulip_debug > 1)
-                printk(KERN_DEBUG "%s: PNIC link changed state %08x, CSR5 %08x\n",
+                netdev_dbg(dev, "PNIC link changed state %08x, CSR5 %08x\n",
-                       dev->name, phy_reg, csr5);
+                           phy_reg, csr5);
        if (ioread32(ioaddr + CSR5) & TPLnkFail) {
                iowrite32((ioread32(ioaddr + CSR7) & ~TPLnkFail) | TPLnkPass, ioaddr + CSR7);
                /* If we use an external MII, then we mustn't use the
@@ -114,8 +114,8 @@ void pnic_timer(unsigned long data)
                int csr5 = ioread32(ioaddr + CSR5);
                if (tulip_debug > 1)
-                        printk(KERN_DEBUG "%s: PNIC timer PHY status %08x, %s CSR5 %08x\n",
+                        netdev_dbg(dev, "PNIC timer PHY status %08x, %s CSR5 %08x\n",
-                               dev->name, phy_reg, medianame[dev->if_port], csr5);
+                                   phy_reg, medianame[dev->if_port], csr5);
                if (phy_reg & 0x04000000) {     /* Remote link fault */
                        iowrite32(0x0201F078, ioaddr + 0xB8);
                        next_tick = 1*HZ;
@@ -125,11 +125,11 @@ void pnic_timer(unsigned long data)
                        next_tick = 60*HZ;
                } else if (csr5 & TPLnkFail) { /* 100baseTx link beat */
                        if (tulip_debug > 1)
-                                printk(KERN_DEBUG "%s: %s link beat failed, CSR12 %04x, CSR5 %08x, PHY %03x\n",
+                                netdev_dbg(dev, "%s link beat failed, CSR12 %04x, CSR5 %08x, PHY %03x\n",
-                                       dev->name, medianame[dev->if_port],
+                                           medianame[dev->if_port],
-                                       csr12,
+                                           csr12,
-                                       ioread32(ioaddr + CSR5),
+                                           ioread32(ioaddr + CSR5),
-                                       ioread32(ioaddr + 0xB8));
+                                           ioread32(ioaddr + 0xB8));
                        next_tick = 3*HZ;
                        if (tp->medialock) {
                        } else if (tp->nwayset  &&  (dev->if_port & 1)) {
diff --git a/drivers/net/tulip/pnic2.c b/drivers/net/tulip/pnic2.c
index 4690c8e69207..93358ee4d830 100644
--- a/drivers/net/tulip/pnic2.c
+++ b/drivers/net/tulip/pnic2.c
@@ -125,8 +125,8 @@ void pnic2_start_nway(struct net_device *dev)
        csr14 |= 0x00001184;
        if (tulip_debug > 1)
-                printk(KERN_DEBUG "%s: Restarting PNIC2 autonegotiation, csr14=%08x\n",
+                netdev_dbg(dev, "Restarting PNIC2 autonegotiation, csr14=%08x\n",
-                       dev->name, csr14);
+                           csr14);
        /* tell pnic2_lnk_change we are doing an nway negotiation */
        dev->if_port = 0;
@@ -137,8 +137,7 @@ void pnic2_start_nway(struct net_device *dev)
        tp->csr6 = ioread32(ioaddr + CSR6);
        if (tulip_debug > 1)
-                printk(KERN_DEBUG "%s: On Entry to Nway, csr6=%08x\n",
+                netdev_dbg(dev, "On Entry to Nway, csr6=%08x\n", tp->csr6);
-                       dev->name, tp->csr6);
        /* mask off any bits not to touch
         * comment at top of file explains mask value
@@ -271,9 +270,10 @@ void pnic2_lnk_change(struct net_device *dev, int csr5)
                        iowrite32(1, ioaddr + CSR13);
                        if (tulip_debug > 2)
-                                printk(KERN_DEBUG "%s: Setting CSR6 %08x/%x CSR12 %08x\n",
+                                netdev_dbg(dev, "Setting CSR6 %08x/%x CSR12 %08x\n",
-                                       dev->name, tp->csr6,
+                                           tp->csr6,
-                                       ioread32(ioaddr + CSR6), ioread32(ioaddr + CSR12));
+                                           ioread32(ioaddr + CSR6),
+                                           ioread32(ioaddr + CSR12));
                        /* now the following actually writes out the
                         * new csr6 values
@@ -324,7 +324,7 @@ void pnic2_lnk_change(struct net_device *dev, int csr5)
                /* Link blew? Maybe restart NWay. */
                if (tulip_debug > 2)
-                        printk(KERN_DEBUG "%s: Ugh! Link blew?\n", dev->name);
+                        netdev_dbg(dev, "Ugh! Link blew?\n");
                del_timer_sync(&tp->timer);
                pnic2_start_nway(dev);
diff --git a/drivers/net/tulip/timer.c b/drivers/net/tulip/timer.c
index 36c2725ec886..2017faf2d0e6 100644
--- a/drivers/net/tulip/timer.c
+++ b/drivers/net/tulip/timer.c
@@ -28,11 +28,11 @@ void tulip_media_task(struct work_struct *work)
        unsigned long flags;
        if (tulip_debug > 2) {
-                printk(KERN_DEBUG "%s: Media selection tick, %s, status %08x mode %08x SIA %08x %08x %08x %08x\n",
+                netdev_dbg(dev, "Media selection tick, %s, status %08x mode %08x SIA %08x %08x %08x %08x\n",
-                       dev->name, medianame[dev->if_port],
+                           medianame[dev->if_port],
-                       ioread32(ioaddr + CSR5), ioread32(ioaddr + CSR6),
+                           ioread32(ioaddr + CSR5), ioread32(ioaddr + CSR6),
-                       csr12, ioread32(ioaddr + CSR13),
+                           csr12, ioread32(ioaddr + CSR13),
-                       ioread32(ioaddr + CSR14), ioread32(ioaddr + CSR15));
+                           ioread32(ioaddr + CSR14), ioread32(ioaddr + CSR15));
        }
        switch (tp->chip_id) {
        case DC21140:
@@ -48,9 +48,9 @@ void tulip_media_task(struct work_struct *work)
                           Assume this a generic MII or SYM transceiver. */
                        next_tick = 60*HZ;
                        if (tulip_debug > 2)
-                                printk(KERN_DEBUG "%s: network media monitor CSR6 %08x CSR12 0x%02x\n",
+                                netdev_dbg(dev, "network media monitor CSR6 %08x CSR12 0x%02x\n",
-                                       dev->name,
+                                           ioread32(ioaddr + CSR6),
-                                       ioread32(ioaddr + CSR6), csr12 & 0xff);
+                                           csr12 & 0xff);
                        break;
                }
                mleaf = &tp->mtable->mleaf[tp->cur_index];
@@ -62,8 +62,8 @@ void tulip_media_task(struct work_struct *work)
                        s8 bitnum = p[offset];
                        if (p[offset+1] & 0x80) {
                                if (tulip_debug > 1)
-                                        printk(KERN_DEBUG "%s: Transceiver monitor tick CSR12=%#02x, no media sense\n",
+                                        netdev_dbg(dev, "Transceiver monitor tick CSR12=%#02x, no media sense\n",
-                                               dev->name, csr12);
+                                                   csr12);
                                if (mleaf->type == 4) {
                                        if (mleaf->media == 3 && (csr12 & 0x02))
                                                goto select_next_media;
@@ -71,17 +71,16 @@ void tulip_media_task(struct work_struct *work)
                                break;
                        }
                        if (tulip_debug > 2)
-                                printk(KERN_DEBUG "%s: Transceiver monitor tick: CSR12=%#02x bit %d is %d, expecting %d\n",
+                                netdev_dbg(dev, "Transceiver monitor tick: CSR12=%#02x bit %d is %d, expecting %d\n",
-                                       dev->name, csr12, (bitnum >> 1) & 7,
+                                           csr12, (bitnum >> 1) & 7,
-                                       (csr12 & (1 << ((bitnum >> 1) & 7))) != 0,
+                                           (csr12 & (1 << ((bitnum >> 1) & 7))) != 0,
-                                       (bitnum >= 0));
+                                           (bitnum >= 0));
                        /* Check that the specified bit has the proper value. */
                        if ((bitnum < 0) !=
                                ((csr12 & (1 << ((bitnum >> 1) & 7))) != 0)) {
                                if (tulip_debug > 2)
-                                        printk(KERN_DEBUG "%s: Link beat detected for %s\n",
+                                        netdev_dbg(dev, "Link beat detected for %s\n",
-                                               dev->name,
+                                                   medianame[mleaf->media & MEDIA_MASK]);
-                                               medianame[mleaf->media & MEDIA_MASK]);
                                if ((p[2] & 0x61) == 0x01)      /* Bogus Znyx board. */
                                        goto actually_mii;
                                netif_carrier_on(dev);
@@ -99,10 +98,9 @@ void tulip_media_task(struct work_struct *work)
                        if (tulip_media_cap[dev->if_port] & MediaIsFD)
                                goto select_next_media; /* Skip FD entries. */
                        if (tulip_debug > 1)
-                                printk(KERN_DEBUG "%s: No link beat on media %s, trying transceiver type %s\n",
+                                netdev_dbg(dev, "No link beat on media %s, trying transceiver type %s\n",
-                                       dev->name,
+                                           medianame[mleaf->media & MEDIA_MASK],
-                                       medianame[mleaf->media & MEDIA_MASK],
+                                           medianame[tp->mtable->mleaf[tp->cur_index].media]);
-                                       medianame[tp->mtable->mleaf[tp->cur_index].media]);
                        tulip_select_media(dev, 0);
                        /* Restart the transmit process. */
                        tulip_restart_rxtx(tp);
@@ -166,10 +164,9 @@ void comet_timer(unsigned long data)
        int next_tick = 60*HZ;
        if (tulip_debug > 1)
-                printk(KERN_DEBUG "%s: Comet link status %04x partner capability %04x\n",
+                netdev_dbg(dev, "Comet link status %04x partner capability %04x\n",
-                       dev->name,
+                           tulip_mdio_read(dev, tp->phys[0], 1),
-                       tulip_mdio_read(dev, tp->phys[0], 1),
+                           tulip_mdio_read(dev, tp->phys[0], 5));
-                       tulip_mdio_read(dev, tp->phys[0], 5));
        /* mod_timer synchronizes us with potential add_timer calls
         * from interrupts.
         */
diff --git a/drivers/net/tulip/tulip.h b/drivers/net/tulip/tulip.h
index ed66a16711dc..9db528967da9 100644
--- a/drivers/net/tulip/tulip.h
+++ b/drivers/net/tulip/tulip.h
@@ -547,11 +547,9 @@ static inline void tulip_stop_rxtx(struct tulip_private *tp)
                        udelay(10);
                if (!i)
-                        printk(KERN_DEBUG "%s: tulip_stop_rxtx() failed"
+                        netdev_dbg(tp->dev, "tulip_stop_rxtx() failed (CSR5 0x%x CSR6 0x%x)\n",
-                                        " (CSR5 0x%x CSR6 0x%x)\n",
+                                   ioread32(ioaddr + CSR5),
-                                        pci_name(tp->pdev),
+                                   ioread32(ioaddr + CSR6));
-                                        ioread32(ioaddr + CSR5),
-                                        ioread32(ioaddr + CSR6));
        }
 }
diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 5c01e260f1ba..82f87647207e 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -12,6 +12,7 @@
        Please submit bugs to http://bugzilla.kernel.org/ .
 */
+#define pr_fmt(fmt) "tulip: " fmt
 #define DRV_NAME        "tulip"
 #ifdef CONFIG_TULIP_NAPI
@@ -119,8 +120,6 @@ module_param(csr0, int, 0);
 module_param_array(options, int, NULL, 0);
 module_param_array(full_duplex, int, NULL, 0);
-#define PFX DRV_NAME ": "
 #ifdef TULIP_DEBUG
 int tulip_debug = TULIP_DEBUG;
 #else
@@ -331,8 +330,7 @@ static void tulip_up(struct net_device *dev)
        udelay(100);
        if (tulip_debug > 1)
-                printk(KERN_DEBUG "%s: tulip_up(), irq==%d\n",
+                netdev_dbg(dev, "tulip_up(), irq==%d\n", dev->irq);
-                       dev->name, dev->irq);
        iowrite32(tp->rx_ring_dma, ioaddr + CSR3);
        iowrite32(tp->tx_ring_dma, ioaddr + CSR4);
@@ -499,10 +497,10 @@ media_picked:
        iowrite32(0, ioaddr + CSR2);            /* Rx poll demand */
        if (tulip_debug > 2) {
-                printk(KERN_DEBUG "%s: Done tulip_up(), CSR0 %08x, CSR5 %08x CSR6 %08x\n",
+                netdev_dbg(dev, "Done tulip_up(), CSR0 %08x, CSR5 %08x CSR6 %08x\n",
-                       dev->name, ioread32(ioaddr + CSR0),
+                           ioread32(ioaddr + CSR0),
-                       ioread32(ioaddr + CSR5),
+                           ioread32(ioaddr + CSR5),
-                       ioread32(ioaddr + CSR6));
+                           ioread32(ioaddr + CSR6));
        }
        /* Set the timer to switch to check for link beat and perhaps switch
@@ -843,8 +841,7 @@ static int tulip_close (struct net_device *dev)
        tulip_down (dev);
        if (tulip_debug > 1)
-                dev_printk(KERN_DEBUG, &dev->dev,
+                netdev_dbg(dev, "Shutting down ethercard, status was %02x\n",
-                           "Shutting down ethercard, status was %02x\n",
                           ioread32 (ioaddr + CSR5));
        free_irq (dev->irq, dev);
@@ -1207,7 +1204,7 @@ static void __devinit tulip_mwi_config (struct pci_dev *pdev,
        u32 csr0;
        if (tulip_debug > 3)
-                printk(KERN_DEBUG "%s: tulip_mwi_config()\n", pci_name(pdev));
+                netdev_dbg(dev, "tulip_mwi_config()\n");
        tp->csr0 = csr0 = 0;
@@ -1269,8 +1266,8 @@ static void __devinit tulip_mwi_config (struct pci_dev *pdev,
 out:
        tp->csr0 = csr0;
        if (tulip_debug > 2)
-                printk(KERN_DEBUG "%s: MWI config cacheline=%d, csr0=%08x\n",
+                netdev_dbg(dev, "MWI config cacheline=%d, csr0=%08x\n",
-                       pci_name(pdev), cache, csr0);
+                           cache, csr0);
 }
 #endif
@@ -1340,13 +1337,13 @@ static int __devinit tulip_init_one (struct pci_dev *pdev,
         */
        if (pdev->subsystem_vendor == PCI_VENDOR_ID_LMC) {
-                pr_err(PFX "skipping LMC card\n");
+                pr_err("skipping LMC card\n");
                return -ENODEV;
        } else if (pdev->subsystem_vendor == PCI_VENDOR_ID_SBE &&
                   (pdev->subsystem_device == PCI_SUBDEVICE_ID_SBE_T3E3 ||
                    pdev->subsystem_device == PCI_SUBDEVICE_ID_SBE_2T3E3_P0 ||
                    pdev->subsystem_device == PCI_SUBDEVICE_ID_SBE_2T3E3_P1)) {
-                pr_err(PFX "skipping SBE T3E3 port\n");
+                pr_err("skipping SBE T3E3 port\n");
                return -ENODEV;
        }
@@ -1362,13 +1359,13 @@ static int __devinit tulip_init_one (struct pci_dev *pdev,
                if (pdev->vendor == 0x1282 && pdev->device == 0x9100 &&
                    pdev->revision < 0x30) {
-                        pr_info(PFX "skipping early DM9100 with Crc bug (use dmfe)\n");
+                        pr_info("skipping early DM9100 with Crc bug (use dmfe)\n");
                        return -ENODEV;
                }
                dp = pci_device_to_OF_node(pdev);
                if (!(dp && of_get_property(dp, "local-mac-address", NULL))) {
-                        pr_info(PFX "skipping DM910x expansion card (use dmfe)\n");
+                        pr_info("skipping DM910x expansion card (use dmfe)\n");
                        return -ENODEV;
                }
        }
@@ -1415,16 +1412,14 @@ static int __devinit tulip_init_one (struct pci_dev *pdev,
        i = pci_enable_device(pdev);
        if (i) {
-                pr_err(PFX "Cannot enable tulip board #%d, aborting\n",
+                pr_err("Cannot enable tulip board #%d, aborting\n", board_idx);
-                       board_idx);
                return i;
        }
        /* The chip will fail to enter a low-power state later unless
         * first explicitly commanded into D0 */
        if (pci_set_power_state(pdev, PCI_D0)) {
-                printk (KERN_NOTICE PFX
+                pr_notice("Failed to set power state to D0\n");
-                        "Failed to set power state to D0\n");
        }
        irq = pdev->irq;
@@ -1432,13 +1427,13 @@ static int __devinit tulip_init_one (struct pci_dev *pdev,
        /* alloc_etherdev ensures aligned and zeroed private structures */
        dev = alloc_etherdev (sizeof (*tp));
        if (!dev) {
-                pr_err(PFX "ether device alloc failed, aborting\n");
+                pr_err("ether device alloc failed, aborting\n");
                return -ENOMEM;
        }
        SET_NETDEV_DEV(dev, &pdev->dev);
        if (pci_resource_len (pdev, 0) < tulip_tbl[chip_idx].io_size) {
-                pr_err(PFX "%s: I/O region (0x%llx@0x%llx) too small, aborting\n",
+                pr_err("%s: I/O region (0x%llx@0x%llx) too small, aborting\n",
                       pci_name(pdev),
                       (unsigned long long)pci_resource_len (pdev, 0),
                       (unsigned long long)pci_resource_start (pdev, 0));
@@ -1483,7 +1478,8 @@ static int __devinit tulip_init_one (struct pci_dev *pdev,
                if (sig == 0x09811317) {
                        tp->flags |= COMET_PM;
                        tp->wolinfo.supported = WAKE_PHY | WAKE_MAGIC;
-                        printk(KERN_INFO "tulip_init_one: Enabled WOL support for AN983B\n");
+                        pr_info("%s: Enabled WOL support for AN983B\n",
+                                __func__);
                }
        }
        tp->pdev = pdev;
@@ -1879,7 +1875,7 @@ save_state:
                tulip_set_wolopts(pdev, tp->wolinfo.wolopts);
                rc = pci_enable_wake(pdev, pstate, tp->wolinfo.wolopts);
                if (rc)
-                        printk("tulip: pci_enable_wake failed (%d)\n", rc);
+                        pr_err("pci_enable_wake failed (%d)\n", rc);
        }
        pci_set_power_state(pdev, pstate);
@@ -1905,12 +1901,12 @@ static int tulip_resume(struct pci_dev *pdev)
                return 0;
        if ((retval = pci_enable_device(pdev))) {
-                pr_err(PFX "pci_enable_device failed in resume\n");
+                pr_err("pci_enable_device failed in resume\n");
                return retval;
        }
        if ((retval = request_irq(dev->irq, tulip_interrupt, IRQF_SHARED, dev->name, dev))) {
-                pr_err(PFX "request_irq failed in resume\n");
+                pr_err("request_irq failed in resume\n");
                return retval;
        }
diff --git a/drivers/net/tulip/uli526x.c b/drivers/net/tulip/uli526x.c
index 74217dbf0143..9e63f406f72d 100644
--- a/drivers/net/tulip/uli526x.c
+++ b/drivers/net/tulip/uli526x.c
@@ -209,8 +209,7 @@ enum uli526x_CR6_bits {
 /* Global variable declaration ----------------------------- */
 static int __devinitdata printed_version;
 static const char version[] __devinitconst =
-        KERN_INFO DRV_NAME ": ULi M5261/M5263 net driver, version "
+        "ULi M5261/M5263 net driver, version " DRV_VERSION " (" DRV_RELDATE ")";
-        DRV_VERSION " (" DRV_RELDATE ")\n";
 static int uli526x_debug;
 static unsigned char uli526x_media_mode = ULI526X_AUTO;
@@ -283,7 +282,7 @@ static int __devinit uli526x_init_one (struct pci_dev *pdev,
        ULI526X_DBUG(0, "uli526x_init_one()", 0);
        if (!printed_version++)
-                printk(version);
+                pr_info("%s\n", version);
        /* Init network device */
        dev = alloc_etherdev(sizeof(*db));
@@ -292,7 +291,7 @@ static int __devinit uli526x_init_one (struct pci_dev *pdev,
        SET_NETDEV_DEV(dev, &pdev->dev);
        if (pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) {
-                pr_warning("32-bit PCI DMA not available\n");
+                pr_warn("32-bit PCI DMA not available\n");
                err = -ENODEV;
                goto err_out_free;
        }
@@ -390,9 +389,9 @@ static int __devinit uli526x_init_one (struct pci_dev *pdev,
        if (err)
                goto err_out_res;
-        dev_info(&dev->dev, "ULi M%04lx at pci%s, %pM, irq %d\n",
+        netdev_info(dev, "ULi M%04lx at pci%s, %pM, irq %d\n",
-                 ent->driver_data >> 16, pci_name(pdev),
+                    ent->driver_data >> 16, pci_name(pdev),
-                 dev->dev_addr, dev->irq);
+                    dev->dev_addr, dev->irq);
        pci_set_master(pdev);
@@ -524,7 +523,7 @@ static void uli526x_init(struct net_device *dev)
                }
        }
        if(phy_tmp == 32)
-                pr_warning("Can not find the phy address!!!");
+                pr_warn("Can not find the phy address!!!\n");
        /* Parser SROM and media mode */
        db->media_mode = uli526x_media_mode;
@@ -590,7 +589,7 @@ static netdev_tx_t uli526x_start_xmit(struct sk_buff *skb,
        /* Too large packet check */
        if (skb->len > MAX_PACKET_SIZE) {
-                pr_err("big packet = %d\n", (u16)skb->len);
+                netdev_err(dev, "big packet = %d\n", (u16)skb->len);
                dev_kfree_skb(skb);
                return NETDEV_TX_OK;
        }
@@ -600,7 +599,7 @@ static netdev_tx_t uli526x_start_xmit(struct sk_buff *skb,
        /* No Tx resource check, it never happen nromally */
        if (db->tx_packet_cnt >= TX_FREE_DESC_CNT) {
                spin_unlock_irqrestore(&db->lock, flags);
-                pr_err("No Tx resource %ld\n", db->tx_packet_cnt);
+                netdev_err(dev, "No Tx resource %ld\n", db->tx_packet_cnt);
                return NETDEV_TX_BUSY;
        }
@@ -667,15 +666,6 @@ static int uli526x_stop(struct net_device *dev)
        /* free allocated rx buffer */
        uli526x_free_rxbuffer(db);
-#if 0
-        /* show statistic counter */
-        printk(DRV_NAME ": FU:%lx EC:%lx LC:%lx NC:%lx LOC:%lx TXJT:%lx RESET:%lx RCR8:%lx FAL:%lx TT:%lx\n",
-                db->tx_fifo_underrun, db->tx_excessive_collision,
-                db->tx_late_collision, db->tx_no_carrier, db->tx_loss_carrier,
-                db->tx_jabber_timeout, db->reset_count, db->reset_cr8,
-                db->reset_fatal, db->reset_TXtimeout);
-#endif
        return 0;
 }
@@ -755,7 +745,6 @@ static void uli526x_free_tx_pkt(struct net_device *dev,
        txptr = db->tx_remove_ptr;
        while(db->tx_packet_cnt) {
                tdes0 = le32_to_cpu(txptr->tdes0);
-                /* printk(DRV_NAME ": tdes0=%x\n", tdes0); */
                if (tdes0 & 0x80000000)
                        break;
@@ -765,7 +754,6 @@ static void uli526x_free_tx_pkt(struct net_device *dev,
                /* Transmit statistic counter */
                if ( tdes0 != 0x7fffffff ) {
-                        /* printk(DRV_NAME ": tdes0=%x\n", tdes0); */
                        dev->stats.collisions += (tdes0 >> 3) & 0xf;
                        dev->stats.tx_bytes += le32_to_cpu(txptr->tdes1) & 0x7ff;
                        if (tdes0 & TDES0_ERR_MASK) {
@@ -838,7 +826,6 @@ static void uli526x_rx_packet(struct net_device *dev, struct uli526x_board_info
                        /* error summary bit check */
                        if (rdes0 & 0x8000) {
                                /* This is a error packet */
-                                //printk(DRV_NAME ": rdes0: %lx\n", rdes0);
                                dev->stats.rx_errors++;
                                if (rdes0 & 1)
                                        dev->stats.rx_fifo_errors++;
@@ -945,12 +932,12 @@ ULi_ethtool_gset(struct uli526x_board_info *db, struct ethtool_cmd *ecmd)
        ecmd->transceiver = XCVR_EXTERNAL;
-        ecmd->speed = 10;
+        ethtool_cmd_speed_set(ecmd, SPEED_10);
        ecmd->duplex = DUPLEX_HALF;
        if(db->op_mode==ULI526X_100MHF || db->op_mode==ULI526X_100MFD)
        {
-                ecmd->speed = 100;
+                ethtool_cmd_speed_set(ecmd, SPEED_100);
        }
        if(db->op_mode==ULI526X_10MFD || db->op_mode==ULI526X_100MFD)
        {
@@ -958,7 +945,7 @@ ULi_ethtool_gset(struct uli526x_board_info *db, struct ethtool_cmd *ecmd)
        }
        if(db->link_failed)
        {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
@@ -1024,7 +1011,6 @@ static void uli526x_timer(unsigned long data)
        struct net_device *dev = (struct net_device *) data;
        struct uli526x_board_info *db = netdev_priv(dev);
        unsigned long flags;
-        u8 TmpSpeed=10;
        //ULI526X_DBUG(0, "uli526x_timer()", 0);
        spin_lock_irqsave(&db->lock, flags);
@@ -1047,8 +1033,7 @@ static void uli526x_timer(unsigned long data)
                if ( time_after(jiffies, dev_trans_start(dev) + ULI526X_TX_TIMEOUT) ) {
                        db->reset_TXtimeout++;
                        db->wait_reset = 1;
-                        printk( "%s: Tx timeout - resetting\n",
+                        netdev_err(dev, " Tx timeout - resetting\n");
-                               dev->name);
                }
        }
@@ -1070,7 +1055,7 @@ static void uli526x_timer(unsigned long data)
                /* Link Failed */
                ULI526X_DBUG(0, "Link Failed", tmp_cr12);
                netif_carrier_off(dev);
-                pr_info("%s NIC Link is Down\n",dev->name);
+                netdev_info(dev, "NIC Link is Down\n");
                db->link_failed = 1;
                /* For Force 10/100M Half/Full mode: Enable Auto-Nego mode */
@@ -1096,18 +1081,13 @@ static void uli526x_timer(unsigned long data)
                        if(db->link_failed==0)
                        {
-                                if(db->op_mode==ULI526X_100MHF || db->op_mode==ULI526X_100MFD)
+                                netdev_info(dev, "NIC Link is Up %d Mbps %s duplex\n",
-                                {
+                                            (db->op_mode == ULI526X_100MHF ||
-                                        TmpSpeed = 100;
+                                             db->op_mode == ULI526X_100MFD)
-                                }
+                                            ? 100 : 10,
-                                if(db->op_mode==ULI526X_10MFD || db->op_mode==ULI526X_100MFD)
+                                            (db->op_mode == ULI526X_10MFD ||
-                                {
+                                             db->op_mode == ULI526X_100MFD)
-                                        pr_info("%s NIC Link is Up %d Mbps Full duplex\n",dev->name,TmpSpeed);
+                                            ? "Full" : "Half");
-                                }
-                                else
-                                {
-                                        pr_info("%s NIC Link is Up %d Mbps Half duplex\n",dev->name,TmpSpeed);
-                                }
                                netif_carrier_on(dev);
                        }
                        /* SHOW_MEDIA_TYPE(db->op_mode); */
@@ -1116,7 +1096,7 @@ static void uli526x_timer(unsigned long data)
                {
                        if(db->init==1)
                        {
-                                pr_info("%s NIC Link is Down\n",dev->name);
+                                netdev_info(dev, "NIC Link is Down\n");
                                netif_carrier_off(dev);
                        }
                }
@@ -1242,7 +1222,7 @@ static int uli526x_resume(struct pci_dev *pdev)
        err = pci_set_power_state(pdev, PCI_D0);
        if (err) {
-                dev_warn(&dev->dev, "Could not put device into D0\n");
+                netdev_warn(dev, "Could not put device into D0\n");
                return err;
        }
@@ -1443,7 +1423,7 @@ static void send_filter_frame(struct net_device *dev, int mc_cnt)
                update_cr6(db->cr6_data, dev->base_addr);
                dev->trans_start = jiffies;
        } else
-                pr_err("No Tx resource - Send_filter_frame!\n");
+                netdev_err(dev, "No Tx resource - Send_filter_frame!\n");
 }
@@ -1540,7 +1520,6 @@ static u8 uli526x_sense_speed(struct uli526x_board_info * db)
                else
                        phy_mode = 0x1000;
-                /* printk(DRV_NAME ": Phy_mode %x ",phy_mode); */
                switch (phy_mode) {
                case 0x1000: db->op_mode = ULI526X_10MHF; break;
                case 0x2000: db->op_mode = ULI526X_10MFD; break;
@@ -1829,7 +1808,7 @@ MODULE_PARM_DESC(mode, "ULi M5261/M5263: Bit 0: 10/100Mbps, bit 2: duplex, bit 8
 static int __init uli526x_init_module(void)
 {
-        printk(version);
+        pr_info("%s\n", version);
        printed_version = 1;
        ULI526X_DBUG(0, "init_module() ", debug);
diff --git a/drivers/net/tulip/winbond-840.c b/drivers/net/tulip/winbond-840.c
index f0b231035dee..862eadf07191 100644
--- a/drivers/net/tulip/winbond-840.c
+++ b/drivers/net/tulip/winbond-840.c
@@ -44,6 +44,8 @@
        * Wake-On-LAN
 */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #define DRV_NAME        "winbond-840"
 #define DRV_VERSION     "1.01-e"
 #define DRV_RELDATE     "Sep-11-2006"
@@ -139,7 +141,7 @@ static int full_duplex[MAX_UNITS] = {-1, -1, -1, -1, -1, -1, -1, -1};
 /* These identify the driver base version and may not be removed. */
 static const char version[] __initconst =
-        KERN_INFO DRV_NAME ".c:v" DRV_VERSION " (2.4 port) "
+        "v" DRV_VERSION " (2.4 port) "
        DRV_RELDATE "  Donald Becker <becker@scyld.com>\n"
        "  http://www.scyld.com/network/drivers.html\n";
@@ -375,8 +377,8 @@ static int __devinit w840_probe1 (struct pci_dev *pdev,
        irq = pdev->irq;
        if (pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) {
-                pr_warning("Winbond-840: Device %s disabled due to DMA limitations\n",
+                pr_warn("Device %s disabled due to DMA limitations\n",
-                           pci_name(pdev));
+                        pci_name(pdev));
                return -EIO;
        }
        dev = alloc_etherdev(sizeof(*np));
@@ -643,8 +645,7 @@ static int netdev_open(struct net_device *dev)
                goto out_err;
        if (debug > 1)
-                printk(KERN_DEBUG "%s: w89c840_open() irq %d\n",
+                netdev_dbg(dev, "w89c840_open() irq %d\n", dev->irq);
-                       dev->name, dev->irq);
        if((i=alloc_ringdesc(dev)))
                goto out_err;
@@ -656,7 +657,7 @@ static int netdev_open(struct net_device *dev)
        netif_start_queue(dev);
        if (debug > 2)
-                printk(KERN_DEBUG "%s: Done netdev_open()\n", dev->name);
+                netdev_dbg(dev, "Done netdev_open()\n");
        /* Set the timer to check for link beat. */
        init_timer(&np->timer);
@@ -785,9 +786,9 @@ static void netdev_timer(unsigned long data)
        void __iomem *ioaddr = np->base_addr;
        if (debug > 2)
-                printk(KERN_DEBUG "%s: Media selection timer tick, status %08x config %08x\n",
+                netdev_dbg(dev, "Media selection timer tick, status %08x config %08x\n",
-                       dev->name, ioread32(ioaddr + IntrStatus),
+                           ioread32(ioaddr + IntrStatus),
-                       ioread32(ioaddr + NetworkConfig));
+                           ioread32(ioaddr + NetworkConfig));
        spin_lock_irq(&np->lock);
        update_csr6(dev, update_link(dev));
        spin_unlock_irq(&np->lock);
@@ -1054,8 +1055,8 @@ static netdev_tx_t start_tx(struct sk_buff *skb, struct net_device *dev)
        spin_unlock_irq(&np->lock);
        if (debug > 4) {
-                printk(KERN_DEBUG "%s: Transmit frame #%d queued in slot %d\n",
+                netdev_dbg(dev, "Transmit frame #%d queued in slot %d\n",
-                       dev->name, np->cur_tx, entry);
+                           np->cur_tx, entry);
        }
        return NETDEV_TX_OK;
 }
@@ -1072,8 +1073,8 @@ static void netdev_tx_done(struct net_device *dev)
                if (tx_status & 0x8000) {       /* There was an error, log it. */
 #ifndef final_version
                        if (debug > 1)
-                                printk(KERN_DEBUG "%s: Transmit error, Tx status %08x\n",
+                                netdev_dbg(dev, "Transmit error, Tx status %08x\n",
-                                       dev->name, tx_status);
+                                           tx_status);
 #endif
                        np->stats.tx_errors++;
                        if (tx_status & 0x0104) np->stats.tx_aborted_errors++;
@@ -1085,8 +1086,8 @@ static void netdev_tx_done(struct net_device *dev)
                } else {
 #ifndef final_version
                        if (debug > 3)
-                                printk(KERN_DEBUG "%s: Transmit slot %d ok, Tx status %08x\n",
+                                netdev_dbg(dev, "Transmit slot %d ok, Tx status %08x\n",
-                                       dev->name, entry, tx_status);
+                                           entry, tx_status);
 #endif
                        np->stats.tx_bytes += np->tx_skbuff[entry]->len;
                        np->stats.collisions += (tx_status >> 3) & 15;
@@ -1129,8 +1130,7 @@ static irqreturn_t intr_handler(int irq, void *dev_instance)
                iowrite32(intr_status & 0x001ffff, ioaddr + IntrStatus);
                if (debug > 4)
-                        printk(KERN_DEBUG "%s: Interrupt, status %04x\n",
+                        netdev_dbg(dev, "Interrupt, status %04x\n", intr_status);
-                               dev->name, intr_status);
                if ((intr_status & (NormalIntr|AbnormalIntr)) == 0)
                        break;
@@ -1171,8 +1171,8 @@ static irqreturn_t intr_handler(int irq, void *dev_instance)
        } while (1);
        if (debug > 3)
-                printk(KERN_DEBUG "%s: exiting interrupt, status=%#4.4x\n",
+                netdev_dbg(dev, "exiting interrupt, status=%#4.4x\n",
-                       dev->name, ioread32(ioaddr + IntrStatus));
+                           ioread32(ioaddr + IntrStatus));
        return IRQ_RETVAL(handled);
 }
@@ -1185,8 +1185,8 @@ static int netdev_rx(struct net_device *dev)
        int work_limit = np->dirty_rx + RX_RING_SIZE - np->cur_rx;
        if (debug > 4) {
-                printk(KERN_DEBUG " In netdev_rx(), entry %d status %04x\n",
+                netdev_dbg(dev, " In netdev_rx(), entry %d status %04x\n",
-                       entry, np->rx_ring[entry].status);
+                           entry, np->rx_ring[entry].status);
        }
        /* If EOP is set on the next entry, it's a new packet. Send it up. */
@@ -1195,8 +1195,8 @@ static int netdev_rx(struct net_device *dev)
                s32 status = desc->status;
                if (debug > 4)
-                        printk(KERN_DEBUG "  netdev_rx() status was %08x\n",
+                        netdev_dbg(dev, "  netdev_rx() status was %08x\n",
-                               status);
+                                   status);
                if (status < 0)
                        break;
                if ((status & 0x38008300) != 0x0300) {
@@ -1211,8 +1211,8 @@ static int netdev_rx(struct net_device *dev)
                        } else if (status & 0x8000) {
                                /* There was a fatal error. */
                                if (debug > 2)
-                                        printk(KERN_DEBUG "%s: Receive error, Rx status %08x\n",
+                                        netdev_dbg(dev, "Receive error, Rx status %08x\n",
-                                               dev->name, status);
+                                                   status);
                                np->stats.rx_errors++; /* end of a packet.*/
                                if (status & 0x0890) np->stats.rx_length_errors++;
                                if (status & 0x004C) np->stats.rx_frame_errors++;
@@ -1225,8 +1225,8 @@ static int netdev_rx(struct net_device *dev)
 #ifndef final_version
                        if (debug > 4)
-                                printk(KERN_DEBUG "  netdev_rx() normal Rx pkt length %d status %x\n",
+                                netdev_dbg(dev, "  netdev_rx() normal Rx pkt length %d status %x\n",
-                                       pkt_len, status);
+                                           pkt_len, status);
 #endif
                        /* Check if the packet is long enough to accept without copying
                           to a minimally-sized skbuff. */
@@ -1251,10 +1251,10 @@ static int netdev_rx(struct net_device *dev)
 #ifndef final_version                           /* Remove after testing. */
                        /* You will want this info for the initial debug. */
                        if (debug > 5)
-                                printk(KERN_DEBUG "  Rx data %pM %pM %02x%02x %pI4\n",
+                                netdev_dbg(dev, "  Rx data %pM %pM %02x%02x %pI4\n",
-                                       &skb->data[0], &skb->data[6],
+                                           &skb->data[0], &skb->data[6],
-                                       skb->data[12], skb->data[13],
+                                           skb->data[12], skb->data[13],
-                                       &skb->data[14]);
+                                           &skb->data[14]);
 #endif
                        skb->protocol = eth_type_trans(skb, dev);
                        netif_rx(skb);
@@ -1292,8 +1292,7 @@ static void netdev_error(struct net_device *dev, int intr_status)
        void __iomem *ioaddr = np->base_addr;
        if (debug > 2)
-                printk(KERN_DEBUG "%s: Abnormal event, %08x\n",
+                netdev_dbg(dev, "Abnormal event, %08x\n", intr_status);
-                       dev->name, intr_status);
        if (intr_status == 0xffffffff)
                return;
        spin_lock(&np->lock);
@@ -1313,8 +1312,7 @@ static void netdev_error(struct net_device *dev, int intr_status)
                        new = 127; /* load full packet before starting */
                new = (np->csr6 & ~(0x7F << 14)) | (new<<14);
 #endif
-                printk(KERN_DEBUG "%s: Tx underflow, new csr6 %08x\n",
+                netdev_dbg(dev, "Tx underflow, new csr6 %08x\n", new);
-                       dev->name, new);
                update_csr6(dev, new);
        }
        if (intr_status & RxDied) {             /* Missed a Rx frame. */
@@ -1487,13 +1485,12 @@ static int netdev_close(struct net_device *dev)
        netif_stop_queue(dev);
        if (debug > 1) {
-                printk(KERN_DEBUG "%s: Shutting down ethercard, status was %08x Config %08x\n",
+                netdev_dbg(dev, "Shutting down ethercard, status was %08x Config %08x\n",
-                       dev->name, ioread32(ioaddr + IntrStatus),
+                           ioread32(ioaddr + IntrStatus),
-                       ioread32(ioaddr + NetworkConfig));
+                           ioread32(ioaddr + NetworkConfig));
-                printk(KERN_DEBUG "%s: Queue pointers were Tx %d / %d,  Rx %d / %d\n",
+                netdev_dbg(dev, "Queue pointers were Tx %d / %d,  Rx %d / %d\n",
-                       dev->name,
+                           np->cur_tx, np->dirty_tx,
-                       np->cur_tx, np->dirty_tx,
+                           np->cur_rx, np->dirty_rx);
-                       np->cur_rx, np->dirty_rx);
        }
        /* Stop the chip's Tx and Rx processes. */
diff --git a/drivers/net/tulip/xircom_cb.c b/drivers/net/tulip/xircom_cb.c
index 5a73752be2ca..988b8eb24d37 100644
--- a/drivers/net/tulip/xircom_cb.c
+++ b/drivers/net/tulip/xircom_cb.c
@@ -37,15 +37,6 @@
 #include <asm/irq.h>
 #endif
-#ifdef DEBUG
-#define enter(x)   printk("Enter: %s, %s line %i\n",x,__FILE__,__LINE__)
-#define leave(x)   printk("Leave: %s, %s line %i\n",x,__FILE__,__LINE__)
-#else
-#define enter(x)   do {} while (0)
-#define leave(x)   do {} while (0)
-#endif
 MODULE_DESCRIPTION("Xircom Cardbus ethernet driver");
 MODULE_AUTHOR("Arjan van de Ven <arjanv@redhat.com>");
 MODULE_LICENSE("GPL");
@@ -161,7 +152,7 @@ static struct pci_driver xircom_ops = {
 };
-#ifdef DEBUG
+#if defined DEBUG && DEBUG > 1
 static void print_binary(unsigned int number)
 {
        int i,i2;
@@ -176,7 +167,7 @@ static void print_binary(unsigned int number)
                if ((i&3)==0)
                        buffer[i2++]=' ';
        }
-        printk("%s\n",buffer);
+        pr_debug("%s\n",buffer);
 }
 #endif
@@ -205,7 +196,6 @@ static int __devinit xircom_probe(struct pci_dev *pdev, const struct pci_device_
        struct xircom_private *private;
        unsigned long flags;
        unsigned short tmp16;
-        enter("xircom_probe");
        /* First do the PCI initialisation */
@@ -272,8 +262,8 @@ static int __devinit xircom_probe(struct pci_dev *pdev, const struct pci_device_
                goto reg_fail;
        }
-        dev_info(&dev->dev, "Xircom cardbus revision %i at irq %i\n",
+        netdev_info(dev, "Xircom cardbus revision %i at irq %i\n",
-                 pdev->revision, pdev->irq);
+                    pdev->revision, pdev->irq);
        /* start the transmitter to get a heartbeat */
        /* TODO: send 2 dummy packets here */
        transceiver_voodoo(private);
@@ -285,7 +275,6 @@ static int __devinit xircom_probe(struct pci_dev *pdev, const struct pci_device_
        trigger_receive(private);
-        leave("xircom_probe");
        return 0;
 reg_fail:
@@ -310,7 +299,6 @@ static void __devexit xircom_remove(struct pci_dev *pdev)
        struct net_device *dev = pci_get_drvdata(pdev);
        struct xircom_private *card = netdev_priv(dev);
-        enter("xircom_remove");
        pci_free_consistent(pdev,8192,card->rx_buffer,card->rx_dma_handle);
        pci_free_consistent(pdev,8192,card->tx_buffer,card->tx_dma_handle);
@@ -318,7 +306,6 @@ static void __devexit xircom_remove(struct pci_dev *pdev)
        unregister_netdev(dev);
        free_netdev(dev);
        pci_set_drvdata(pdev, NULL);
-        leave("xircom_remove");
 }
 static irqreturn_t xircom_interrupt(int irq, void *dev_instance)
@@ -328,17 +315,15 @@ static irqreturn_t xircom_interrupt(int irq, void *dev_instance)
        unsigned int status;
        int i;
-        enter("xircom_interrupt\n");
        spin_lock(&card->lock);
        status = inl(card->io_port+CSR5);
-#ifdef DEBUG
+#if defined DEBUG && DEBUG > 1
        print_binary(status);
-        printk("tx status 0x%08x 0x%08x\n",
+        pr_debug("tx status 0x%08x 0x%08x\n",
-               card->tx_buffer[0], card->tx_buffer[4]);
+                 card->tx_buffer[0], card->tx_buffer[4]);
-        printk("rx status 0x%08x 0x%08x\n",
+        pr_debug("rx status 0x%08x 0x%08x\n",
-               card->rx_buffer[0], card->rx_buffer[4]);
+                 card->rx_buffer[0], card->rx_buffer[4]);
 #endif
        /* Handle shared irq and hotplug */
        if (status == 0 || status == 0xffffffff) {
@@ -348,9 +333,9 @@ static irqreturn_t xircom_interrupt(int irq, void *dev_instance)
        if (link_status_changed(card)) {
                int newlink;
-                printk(KERN_DEBUG "xircom_cb: Link status has changed\n");
+                netdev_dbg(dev, "Link status has changed\n");
                newlink = link_status(card);
-                dev_info(&dev->dev, "Link is %i mbit\n", newlink);
+                netdev_info(dev, "Link is %d mbit\n", newlink);
                if (newlink)
                        netif_carrier_on(dev);
                else
@@ -369,9 +354,7 @@ static irqreturn_t xircom_interrupt(int irq, void *dev_instance)
        for (i=0;i<NUMDESCRIPTORS;i++)
                investigate_read_descriptor(dev,card,i,bufferoffsets[i]);
        spin_unlock(&card->lock);
-        leave("xircom_interrupt");
        return IRQ_HANDLED;
 }
@@ -382,7 +365,6 @@ static netdev_tx_t xircom_start_xmit(struct sk_buff *skb,
        unsigned long flags;
        int nextdescriptor;
        int desc;
-        enter("xircom_start_xmit");
        card = netdev_priv(dev);
        spin_lock_irqsave(&card->lock,flags);
@@ -424,13 +406,10 @@ static netdev_tx_t xircom_start_xmit(struct sk_buff *skb,
                                netif_stop_queue(dev);
                        }
                        card->transmit_used = nextdescriptor;
-                        leave("xircom-start_xmit - sent");
                        spin_unlock_irqrestore(&card->lock,flags);
                        return NETDEV_TX_OK;
        }
        /* Uh oh... no free descriptor... drop the packet */
        netif_stop_queue(dev);
        spin_unlock_irqrestore(&card->lock,flags);
@@ -446,18 +425,16 @@ static int xircom_open(struct net_device *dev)
 {
        struct xircom_private *xp = netdev_priv(dev);
        int retval;
-        enter("xircom_open");
-        pr_info("xircom cardbus adaptor found, registering as %s, using irq %i\n",
+        netdev_info(dev, "xircom cardbus adaptor found, using irq %i\n",
-                dev->name, dev->irq);
+                    dev->irq);
        retval = request_irq(dev->irq, xircom_interrupt, IRQF_SHARED, dev->name, dev);
-        if (retval) {
+        if (retval)
-                leave("xircom_open - No IRQ");
                return retval;
-        }
        xircom_up(xp);
        xp->open = 1;
-        leave("xircom_open");
        return 0;
 }
@@ -466,7 +443,6 @@ static int xircom_close(struct net_device *dev)
        struct xircom_private *card;
        unsigned long flags;
-        enter("xircom_close");
        card = netdev_priv(dev);
        netif_stop_queue(dev); /* we don't want new packets */
@@ -486,8 +462,6 @@ static int xircom_close(struct net_device *dev)
        card->open = 0;
        free_irq(dev->irq,dev);
-        leave("xircom_close");
        return 0;
 }
@@ -507,8 +481,6 @@ static void initialize_card(struct xircom_private *card)
 {
        unsigned int val;
        unsigned long flags;
-        enter("initialize_card");
        spin_lock_irqsave(&card->lock, flags);
@@ -534,8 +506,6 @@ static void initialize_card(struct xircom_private *card)
        deactivate_transmitter(card);
        spin_unlock_irqrestore(&card->lock, flags);
-        leave("initialize_card");
 }
 /*
@@ -547,12 +517,9 @@ ignored; I chose zero.
 static void trigger_transmit(struct xircom_private *card)
 {
        unsigned int val;
-        enter("trigger_transmit");
        val = 0;
        outl(val, card->io_port + CSR1);
-        leave("trigger_transmit");
 }
 /*
@@ -565,12 +532,9 @@ ignored; I chose zero.
 static void trigger_receive(struct xircom_private *card)
 {
        unsigned int val;
-        enter("trigger_receive");
        val = 0;
        outl(val, card->io_port + CSR2);
-        leave("trigger_receive");
 }
 /*
@@ -581,8 +545,6 @@ static void setup_descriptors(struct xircom_private *card)
 {
        u32 address;
        int i;
-        enter("setup_descriptors");
        BUG_ON(card->rx_buffer == NULL);
        BUG_ON(card->tx_buffer == NULL);
@@ -636,8 +598,6 @@ static void setup_descriptors(struct xircom_private *card)
        /* wite the transmit descriptor ring to the card */
        address = card->tx_dma_handle;
        outl(address, card->io_port + CSR4);    /* xmit descr list address */
-        leave("setup_descriptors");
 }
 /*
@@ -647,13 +607,10 @@ valid by setting the address in the card to 0x00.
 static void remove_descriptors(struct xircom_private *card)
 {
        unsigned int val;
-        enter("remove_descriptors");
        val = 0;
        outl(val, card->io_port + CSR3);        /* Receive descriptor address */
        outl(val, card->io_port + CSR4);        /* Send descriptor address */
-        leave("remove_descriptors");
 }
 /*
@@ -665,21 +622,17 @@ This function also clears the status-bit.
 static int link_status_changed(struct xircom_private *card)
 {
        unsigned int val;
-        enter("link_status_changed");
        val = inl(card->io_port + CSR5);        /* Status register */
-        if ((val & (1 << 27)) == 0) {   /* no change */
+        if ((val & (1 << 27)) == 0)             /* no change */
-                leave("link_status_changed - nochange");
                return 0;
-        }
        /* clear the event by writing a 1 to the bit in the
           status register. */
        val = (1 << 27);
        outl(val, card->io_port + CSR5);
-        leave("link_status_changed - changed");
        return 1;
 }
@@ -691,16 +644,12 @@ in a non-stopped state.
 static int transmit_active(struct xircom_private *card)
 {
        unsigned int val;
-        enter("transmit_active");
        val = inl(card->io_port + CSR5);        /* Status register */
-        if ((val & (7 << 20)) == 0) {   /* transmitter disabled */
+        if ((val & (7 << 20)) == 0)             /* transmitter disabled */
-                leave("transmit_active - inactive");
                return 0;
-        }
-        leave("transmit_active - active");
        return 1;
 }
@@ -711,17 +660,12 @@ in a non-stopped state.
 static int receive_active(struct xircom_private *card)
 {
        unsigned int val;
-        enter("receive_active");
        val = inl(card->io_port + CSR5);        /* Status register */
-        if ((val & (7 << 17)) == 0) {   /* receiver disabled */
+        if ((val & (7 << 17)) == 0)             /* receiver disabled */
-                leave("receive_active - inactive");
                return 0;
-        }
-        leave("receive_active - active");
        return 1;
 }
@@ -739,8 +683,6 @@ static void activate_receiver(struct xircom_private *card)
 {
        unsigned int val;
        int counter;
-        enter("activate_receiver");
        val = inl(card->io_port + CSR6);        /* Operation mode */
@@ -761,7 +703,7 @@ static void activate_receiver(struct xircom_private *card)
                udelay(50);
                counter--;
                if (counter <= 0)
-                        pr_err("Receiver failed to deactivate\n");
+                        netdev_err(card->dev, "Receiver failed to deactivate\n");
        }
        /* enable the receiver */
@@ -778,10 +720,9 @@ static void activate_receiver(struct xircom_private *card)
                udelay(50);
                counter--;
                if (counter <= 0)
-                        pr_err("Receiver failed to re-activate\n");
+                        netdev_err(card->dev,
+                                   "Receiver failed to re-activate\n");
        }
-        leave("activate_receiver");
 }
 /*
@@ -795,7 +736,6 @@ static void deactivate_receiver(struct xircom_private *card)
 {
        unsigned int val;
        int counter;
-        enter("deactivate_receiver");
        val = inl(card->io_port + CSR6);        /* Operation mode */
        val = val & ~2;                         /* disable the receiver */
@@ -809,11 +749,8 @@ static void deactivate_receiver(struct xircom_private *card)
                udelay(50);
                counter--;
                if (counter <= 0)
-                        pr_err("Receiver failed to deactivate\n");
+                        netdev_err(card->dev, "Receiver failed to deactivate\n");
        }
-        leave("deactivate_receiver");
 }
@@ -831,8 +768,6 @@ static void activate_transmitter(struct xircom_private *card)
 {
        unsigned int val;
        int counter;
-        enter("activate_transmitter");
        val = inl(card->io_port + CSR6);        /* Operation mode */
@@ -852,7 +787,8 @@ static void activate_transmitter(struct xircom_private *card)
                udelay(50);
                counter--;
                if (counter <= 0)
-                        pr_err("Transmitter failed to deactivate\n");
+                        netdev_err(card->dev,
+                                   "Transmitter failed to deactivate\n");
        }
        /* enable the transmitter */
@@ -869,10 +805,9 @@ static void activate_transmitter(struct xircom_private *card)
                udelay(50);
                counter--;
                if (counter <= 0)
-                        pr_err("Transmitter failed to re-activate\n");
+                        netdev_err(card->dev,
+                                   "Transmitter failed to re-activate\n");
        }
-        leave("activate_transmitter");
 }
 /*
@@ -886,7 +821,6 @@ static void deactivate_transmitter(struct xircom_private *card)
 {
        unsigned int val;
        int counter;
-        enter("deactivate_transmitter");
        val = inl(card->io_port + CSR6);        /* Operation mode */
        val = val & ~2;         /* disable the transmitter */
@@ -900,11 +834,9 @@ static void deactivate_transmitter(struct xircom_private *card)
                udelay(50);
                counter--;
                if (counter <= 0)
-                        pr_err("Transmitter failed to deactivate\n");
+                        netdev_err(card->dev,
+                                   "Transmitter failed to deactivate\n");
        }
-        leave("deactivate_transmitter");
 }
@@ -916,13 +848,10 @@ must be called with the lock held and interrupts disabled.
 static void enable_transmit_interrupt(struct xircom_private *card)
 {
        unsigned int val;
-        enter("enable_transmit_interrupt");
        val = inl(card->io_port + CSR7);        /* Interrupt enable register */
        val |= 1;                               /* enable the transmit interrupt */
        outl(val, card->io_port + CSR7);
-        leave("enable_transmit_interrupt");
 }
@@ -934,13 +863,10 @@ must be called with the lock held and interrupts disabled.
 static void enable_receive_interrupt(struct xircom_private *card)
 {
        unsigned int val;
-        enter("enable_receive_interrupt");
        val = inl(card->io_port + CSR7);        /* Interrupt enable register */
        val = val | (1 << 6);                   /* enable the receive interrupt */
        outl(val, card->io_port + CSR7);
-        leave("enable_receive_interrupt");
 }
 /*
@@ -951,13 +877,10 @@ must be called with the lock held and interrupts disabled.
 static void enable_link_interrupt(struct xircom_private *card)
 {
        unsigned int val;
-        enter("enable_link_interrupt");
        val = inl(card->io_port + CSR7);        /* Interrupt enable register */
        val = val | (1 << 27);                  /* enable the link status chage interrupt */
        outl(val, card->io_port + CSR7);
-        leave("enable_link_interrupt");
 }
@@ -970,12 +893,9 @@ must be called with the lock held and interrupts disabled.
 static void disable_all_interrupts(struct xircom_private *card)
 {
        unsigned int val;
-        enter("enable_all_interrupts");
        val = 0;                                /* disable all interrupts */
        outl(val, card->io_port + CSR7);
-        leave("disable_all_interrupts");
 }
 /*
@@ -986,7 +906,6 @@ must be called with the lock held and interrupts disabled.
 static void enable_common_interrupts(struct xircom_private *card)
 {
        unsigned int val;
-        enter("enable_link_interrupt");
        val = inl(card->io_port + CSR7);        /* Interrupt enable register */
        val |= (1<<16); /* Normal Interrupt Summary */
@@ -998,8 +917,6 @@ static void enable_common_interrupts(struct xircom_private *card)
        val |= (1<<2);  /* Transmit Buffer Unavailable */
        val |= (1<<1);  /* Transmit Process Stopped */
        outl(val, card->io_port + CSR7);
-        leave("enable_link_interrupt");
 }
 /*
@@ -1010,13 +927,11 @@ must be called with the lock held and interrupts disabled.
 static int enable_promisc(struct xircom_private *card)
 {
        unsigned int val;
-        enter("enable_promisc");
        val = inl(card->io_port + CSR6);
        val = val | (1 << 6);
        outl(val, card->io_port + CSR6);
-        leave("enable_promisc");
        return 1;
 }
@@ -1031,7 +946,6 @@ Must be called in locked state with interrupts disabled
 static int link_status(struct xircom_private *card)
 {
        unsigned int val;
-        enter("link_status");
        val = inb(card->io_port + CSR12);
@@ -1042,7 +956,6 @@ static int link_status(struct xircom_private *card)
        /* If we get here -> no link at all */
-        leave("link_status");
        return 0;
 }
@@ -1061,8 +974,6 @@ static void read_mac_address(struct xircom_private *card)
        unsigned long flags;
        int i;
-        enter("read_mac_address");
        spin_lock_irqsave(&card->lock, flags);
        outl(1 << 12, card->io_port + CSR9);    /* enable boot rom access */
@@ -1090,7 +1001,6 @@ static void read_mac_address(struct xircom_private *card)
        }
        spin_unlock_irqrestore(&card->lock, flags);
        pr_debug(" %pM\n", card->dev->dev_addr);
-        leave("read_mac_address");
 }
@@ -1103,8 +1013,6 @@ static void transceiver_voodoo(struct xircom_private *card)
 {
        unsigned long flags;
-        enter("transceiver_voodoo");
        /* disable all powermanagement */
        pci_write_config_dword(card->pdev, PCI_POWERMGMT, 0x0000);
@@ -1122,7 +1030,6 @@ static void transceiver_voodoo(struct xircom_private *card)
        spin_unlock_irqrestore(&card->lock, flags);
        netif_start_queue(card->dev);
-        leave("transceiver_voodoo");
 }
@@ -1131,8 +1038,6 @@ static void xircom_up(struct xircom_private *card)
        unsigned long flags;
        int i;
-        enter("xircom_up");
        /* disable all powermanagement */
        pci_write_config_dword(card->pdev, PCI_POWERMGMT, 0x0000);
@@ -1156,87 +1061,84 @@ static void xircom_up(struct xircom_private *card)
        trigger_receive(card);
        trigger_transmit(card);
        netif_start_queue(card->dev);
-        leave("xircom_up");
 }
 /* Bufferoffset is in BYTES */
-static void investigate_read_descriptor(struct net_device *dev,struct xircom_private *card, int descnr, unsigned int bufferoffset)
+static void
+investigate_read_descriptor(struct net_device *dev, struct xircom_private *card,
+                            int descnr, unsigned int bufferoffset)
 {
-                int status;
+        int status;
-                enter("investigate_read_descriptor");
-                status = le32_to_cpu(card->rx_buffer[4*descnr]);
-                if ((status > 0)) {     /* packet received */
+        status = le32_to_cpu(card->rx_buffer[4*descnr]);
-                        /* TODO: discard error packets */
+        if (status > 0) {               /* packet received */
-                        short pkt_len = ((status >> 16) & 0x7ff) - 4;   /* minus 4, we don't want the CRC */
+                /* TODO: discard error packets */
-                        struct sk_buff *skb;
-                        if (pkt_len > 1518) {
+                short pkt_len = ((status >> 16) & 0x7ff) - 4;
-                                pr_err("Packet length %i is bogus\n", pkt_len);
+                                        /* minus 4, we don't want the CRC */
-                                pkt_len = 1518;
+                struct sk_buff *skb;
-                        }
-                        skb = dev_alloc_skb(pkt_len + 2);
+                if (pkt_len > 1518) {
-                        if (skb == NULL) {
+                        netdev_err(dev, "Packet length %i is bogus\n", pkt_len);
-                                dev->stats.rx_dropped++;
+                        pkt_len = 1518;
-                                goto out;
-                        }
-                        skb_reserve(skb, 2);
-                        skb_copy_to_linear_data(skb, (unsigned char*)&card->rx_buffer[bufferoffset / 4], pkt_len);
-                        skb_put(skb, pkt_len);
-                        skb->protocol = eth_type_trans(skb, dev);
-                        netif_rx(skb);
-                        dev->stats.rx_packets++;
-                        dev->stats.rx_bytes += pkt_len;
-                      out:
-                        /* give the buffer back to the card */
-                        card->rx_buffer[4*descnr] =  cpu_to_le32(0x80000000);
-                        trigger_receive(card);
                }
-                leave("investigate_read_descriptor");
+                skb = dev_alloc_skb(pkt_len + 2);
+                if (skb == NULL) {
+                        dev->stats.rx_dropped++;
+                        goto out;
+                }
+                skb_reserve(skb, 2);
+                skb_copy_to_linear_data(skb,
+                                        &card->rx_buffer[bufferoffset / 4],
+                                        pkt_len);
+                skb_put(skb, pkt_len);
+                skb->protocol = eth_type_trans(skb, dev);
+                netif_rx(skb);
+                dev->stats.rx_packets++;
+                dev->stats.rx_bytes += pkt_len;
+out:
+                /* give the buffer back to the card */
+                card->rx_buffer[4*descnr] = cpu_to_le32(0x80000000);
+                trigger_receive(card);
+        }
 }
 /* Bufferoffset is in BYTES */
-static void investigate_write_descriptor(struct net_device *dev, struct xircom_private *card, int descnr, unsigned int bufferoffset)
+static void
+investigate_write_descriptor(struct net_device *dev,
+                             struct xircom_private *card,
+                             int descnr, unsigned int bufferoffset)
 {
-                int status;
+        int status;
-                enter("investigate_write_descriptor");
-                status = le32_to_cpu(card->tx_buffer[4*descnr]);
+        status = le32_to_cpu(card->tx_buffer[4*descnr]);
 #if 0
-                if (status & 0x8000) {  /* Major error */
+        if (status & 0x8000) {  /* Major error */
-                        pr_err("Major transmit error status %x\n", status);
+                pr_err("Major transmit error status %x\n", status);
-                        card->tx_buffer[4*descnr] = 0;
+                card->tx_buffer[4*descnr] = 0;
-                        netif_wake_queue (dev);
+                netif_wake_queue (dev);
-                }
+        }
 #endif
-                if (status > 0) {       /* bit 31 is 0 when done */
+        if (status > 0) {       /* bit 31 is 0 when done */
-                        if (card->tx_skb[descnr]!=NULL) {
+                if (card->tx_skb[descnr]!=NULL) {
-                                dev->stats.tx_bytes += card->tx_skb[descnr]->len;
+                        dev->stats.tx_bytes += card->tx_skb[descnr]->len;
-                                dev_kfree_skb_irq(card->tx_skb[descnr]);
+                        dev_kfree_skb_irq(card->tx_skb[descnr]);
-                        }
-                        card->tx_skb[descnr] = NULL;
-                        /* Bit 8 in the status field is 1 if there was a collision */
-                        if (status&(1<<8))
-                                dev->stats.collisions++;
-                        card->tx_buffer[4*descnr] = 0; /* descriptor is free again */
-                        netif_wake_queue (dev);
-                        dev->stats.tx_packets++;
                }
+                card->tx_skb[descnr] = NULL;
-                leave("investigate_write_descriptor");
+                /* Bit 8 in the status field is 1 if there was a collision */
+                if (status & (1 << 8))
+                        dev->stats.collisions++;
+                card->tx_buffer[4*descnr] = 0; /* descriptor is free again */
+                netif_wake_queue (dev);
+                dev->stats.tx_packets++;
+        }
 }
 static int __init xircom_init(void)
 {
        return pci_register_driver(&xircom_ops);
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index f5e9ac00a07b..74e94054ab1a 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -123,6 +123,9 @@ struct tun_struct {
        gid_t                   group;
        struct net_device       *dev;
+        u32                     set_features;
+#define TUN_USER_FEATURES (NETIF_F_HW_CSUM|NETIF_F_TSO_ECN|NETIF_F_TSO| \
+                          NETIF_F_TSO6|NETIF_F_UFO)
        struct fasync_struct    *fasync;
        struct tap_filter       txflt;
@@ -451,12 +454,20 @@ tun_net_change_mtu(struct net_device *dev, int new_mtu)
        return 0;
 }
+static u32 tun_net_fix_features(struct net_device *dev, u32 features)
+{
+        struct tun_struct *tun = netdev_priv(dev);
+        return (features & tun->set_features) | (features & ~TUN_USER_FEATURES);
+}
 static const struct net_device_ops tun_netdev_ops = {
        .ndo_uninit             = tun_net_uninit,
        .ndo_open               = tun_net_open,
        .ndo_stop               = tun_net_close,
        .ndo_start_xmit         = tun_net_xmit,
        .ndo_change_mtu         = tun_net_change_mtu,
+        .ndo_fix_features       = tun_net_fix_features,
 };
 static const struct net_device_ops tap_netdev_ops = {
@@ -465,6 +476,7 @@ static const struct net_device_ops tap_netdev_ops = {
        .ndo_stop               = tun_net_close,
        .ndo_start_xmit         = tun_net_xmit,
        .ndo_change_mtu         = tun_net_change_mtu,
+        .ndo_fix_features       = tun_net_fix_features,
        .ndo_set_multicast_list = tun_net_mclist,
        .ndo_set_mac_address    = eth_mac_addr,
        .ndo_validate_addr      = eth_validate_addr,
@@ -628,8 +640,7 @@ static __inline__ ssize_t tun_get_user(struct tun_struct *tun,
                        kfree_skb(skb);
                        return -EINVAL;
                }
-        } else if (tun->flags & TUN_NOCHECKSUM)
+        }
-                skb->ip_summed = CHECKSUM_UNNECESSARY;
        switch (tun->flags & TUN_TYPE_MASK) {
        case TUN_TUN_DEV:
@@ -1088,11 +1099,9 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
                tun_net_init(dev);
-                if (strchr(dev->name, '%')) {
+                dev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST |
-                        err = dev_alloc_name(dev, dev->name);
+                        TUN_USER_FEATURES;
-                        if (err < 0)
+                dev->features = dev->hw_features;
-                                goto err_free_sk;
-                }
                err = register_netdevice(tun->dev);
                if (err < 0)
@@ -1158,18 +1167,12 @@ static int tun_get_iff(struct net *net, struct tun_struct *tun,
 /* This is like a cut-down ethtool ops, except done via tun fd so no
 * privs required. */
-static int set_offload(struct net_device *dev, unsigned long arg)
+static int set_offload(struct tun_struct *tun, unsigned long arg)
 {
-        u32 old_features, features;
+        u32 features = 0;
-        old_features = dev->features;
-        /* Unset features, set them as we chew on the arg. */
-        features = (old_features & ~(NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST
-                                    |NETIF_F_TSO_ECN|NETIF_F_TSO|NETIF_F_TSO6
-                                    |NETIF_F_UFO));
        if (arg & TUN_F_CSUM) {
-                features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;
+                features |= NETIF_F_HW_CSUM;
                arg &= ~TUN_F_CSUM;
                if (arg & (TUN_F_TSO4|TUN_F_TSO6)) {
@@ -1195,9 +1198,8 @@ static int set_offload(struct net_device *dev, unsigned long arg)
        if (arg)
                return -EINVAL;
-        dev->features = features;
+        tun->set_features = features;
-        if (old_features != dev->features)
+        netdev_update_features(tun->dev);
-                netdev_features_change(dev);
        return 0;
 }
@@ -1262,12 +1264,9 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
        case TUNSETNOCSUM:
                /* Disable/Enable checksum */
-                if (arg)
-                        tun->flags |= TUN_NOCHECKSUM;
-                else
-                        tun->flags &= ~TUN_NOCHECKSUM;
-                tun_debug(KERN_INFO, tun, "checksum %s\n",
+                /* [unimplemented] */
+                tun_debug(KERN_INFO, tun, "ignored: set checksum %s\n",
                          arg ? "disabled" : "enabled");
                break;
@@ -1316,7 +1315,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
                break;
 #endif
        case TUNSETOFFLOAD:
-                ret = set_offload(tun->dev, arg);
+                ret = set_offload(tun, arg);
                break;
        case TUNSETTXFILTER:
@@ -1548,7 +1547,7 @@ static int tun_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        cmd->supported          = 0;
        cmd->advertising        = 0;
-        cmd->speed              = SPEED_10;
+        ethtool_cmd_speed_set(cmd, SPEED_10);
        cmd->duplex             = DUPLEX_FULL;
        cmd->port               = PORT_TP;
        cmd->phy_address        = 0;
@@ -1595,30 +1594,12 @@ static void tun_set_msglevel(struct net_device *dev, u32 value)
 #endif
 }
-static u32 tun_get_rx_csum(struct net_device *dev)
-{
-        struct tun_struct *tun = netdev_priv(dev);
-        return (tun->flags & TUN_NOCHECKSUM) == 0;
-}
-static int tun_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct tun_struct *tun = netdev_priv(dev);
-        if (data)
-                tun->flags &= ~TUN_NOCHECKSUM;
-        else
-                tun->flags |= TUN_NOCHECKSUM;
-        return 0;
-}
 static const struct ethtool_ops tun_ethtool_ops = {
        .get_settings   = tun_get_settings,
        .get_drvinfo    = tun_get_drvinfo,
        .get_msglevel   = tun_get_msglevel,
        .set_msglevel   = tun_set_msglevel,
        .get_link       = ethtool_op_get_link,
-        .get_rx_csum    = tun_get_rx_csum,
-        .set_rx_csum    = tun_set_rx_csum
 };
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
index 82653cb07857..3de4283344e9 100644
--- a/drivers/net/typhoon.c
+++ b/drivers/net/typhoon.c
@@ -1050,7 +1050,7 @@ typhoon_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        /* need to get stats to make these link speed/duplex valid */
        typhoon_do_get_stats(tp);
-        cmd->speed = tp->speed;
+        ethtool_cmd_speed_set(cmd, tp->speed);
        cmd->duplex = tp->duplex;
        cmd->phy_address = 0;
        cmd->transceiver = XCVR_INTERNAL;
@@ -1068,25 +1068,26 @@ static int
 typhoon_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        struct typhoon *tp = netdev_priv(dev);
+        u32 speed = ethtool_cmd_speed(cmd);
        struct cmd_desc xp_cmd;
        __le16 xcvr;
        int err;
        err = -EINVAL;
-        if(cmd->autoneg == AUTONEG_ENABLE) {
+        if (cmd->autoneg == AUTONEG_ENABLE) {
                xcvr = TYPHOON_XCVR_AUTONEG;
        } else {
-                if(cmd->duplex == DUPLEX_HALF) {
+                if (cmd->duplex == DUPLEX_HALF) {
-                        if(cmd->speed == SPEED_10)
+                        if (speed == SPEED_10)
                                xcvr = TYPHOON_XCVR_10HALF;
-                        else if(cmd->speed == SPEED_100)
+                        else if (speed == SPEED_100)
                                xcvr = TYPHOON_XCVR_100HALF;
                        else
                                goto out;
-                } else if(cmd->duplex == DUPLEX_FULL) {
+                } else if (cmd->duplex == DUPLEX_FULL) {
-                        if(cmd->speed == SPEED_10)
+                        if (speed == SPEED_10)
                                xcvr = TYPHOON_XCVR_10FULL;
-                        else if(cmd->speed == SPEED_100)
+                        else if (speed == SPEED_100)
                                xcvr = TYPHOON_XCVR_100FULL;
                        else
                                goto out;
@@ -1105,7 +1106,7 @@ typhoon_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                tp->speed = 0xff;       /* invalid */
                tp->duplex = 0xff;      /* invalid */
        } else {
-                tp->speed = cmd->speed;
+                tp->speed = speed;
                tp->duplex = cmd->duplex;
        }
@@ -1144,28 +1145,6 @@ typhoon_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
        return 0;
 }
-static u32
-typhoon_get_rx_csum(struct net_device *dev)
-{
-        /* For now, we don't allow turning off RX checksums.
-         */
-        return 1;
-}
-static int
-typhoon_set_flags(struct net_device *dev, u32 data)
-{
-        /* There's no way to turn off the RX VLAN offloading and stripping
-         * on the current 3XP firmware -- it does not respect the offload
-         * settings -- so we only allow the user to toggle the TX processing.
-         */
-        if (!(data & ETH_FLAG_RXVLAN))
-                return -EINVAL;
-        return ethtool_op_set_flags(dev, data,
-                                    ETH_FLAG_RXVLAN | ETH_FLAG_TXVLAN);
-}
 static void
 typhoon_get_ringparam(struct net_device *dev, struct ethtool_ringparam *ering)
 {
@@ -1187,13 +1166,7 @@ static const struct ethtool_ops typhoon_ethtool_ops = {
        .get_wol                = typhoon_get_wol,
        .set_wol                = typhoon_set_wol,
        .get_link               = ethtool_op_get_link,
-        .get_rx_csum            = typhoon_get_rx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_csum,
-        .set_sg                 = ethtool_op_set_sg,
-        .set_tso                = ethtool_op_set_tso,
        .get_ringparam          = typhoon_get_ringparam,
-        .set_flags              = typhoon_set_flags,
-        .get_flags              = ethtool_op_get_flags,
 };
 static int
@@ -2482,10 +2455,15 @@ typhoon_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        /* We can handle scatter gather, up to 16 entries, and
         * we can do IP checksumming (only version 4, doh...)
+         *
+         * There's no way to turn off the RX VLAN offloading and stripping
+         * on the current 3XP firmware -- it does not respect the offload
+         * settings -- so we only allow the user to toggle the TX processing.
         */
-        dev->features |= NETIF_F_SG | NETIF_F_IP_CSUM;
+        dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO |
-        dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+                NETIF_F_HW_VLAN_TX;
-        dev->features |= NETIF_F_TSO;
+        dev->features = dev->hw_features |
+                NETIF_F_HW_VLAN_RX | NETIF_F_RXCSUM;
        if(register_netdev(dev) < 0) {
                err_msg = "unable to register netdev";
diff --git a/drivers/net/ucc_geth_ethtool.c b/drivers/net/ucc_geth_ethtool.c
index 6f92e48f02d3..537fbc0a4401 100644
--- a/drivers/net/ucc_geth_ethtool.c
+++ b/drivers/net/ucc_geth_ethtool.c
@@ -410,7 +410,6 @@ static const struct ethtool_ops uec_ethtool_ops = {
        .set_ringparam          = uec_set_ringparam,
        .get_pauseparam         = uec_get_pauseparam,
        .set_pauseparam         = uec_set_pauseparam,
-        .set_sg                 = ethtool_op_set_sg,
        .get_sset_count         = uec_get_sset_count,
        .get_strings            = uec_get_strings,
        .get_ethtool_stats      = uec_get_ethtool_stats,
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 3ec22c307797..9d4f9117260f 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -258,7 +258,7 @@ config USB_NET_NET1080
          optionally with LEDs that indicate traffic
 config USB_NET_PLUSB
-        tristate "Prolific PL-2301/2302 based cables"
+        tristate "Prolific PL-2301/2302/25A1 based cables"
        # if the handshake/init/reset problems, from original 'plusb',
        # are ever resolved ... then remove "experimental"
        depends on USB_USBNET && EXPERIMENTAL
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
index 6140b56cce53..6998aa6b7bb7 100644
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -847,7 +847,7 @@ static void ax88172_set_multicast(struct net_device *net)
 static int ax88172_link_reset(struct usbnet *dev)
 {
        u8 mode;
-        struct ethtool_cmd ecmd;
+        struct ethtool_cmd ecmd = { .cmd = ETHTOOL_GSET };
        mii_check_media(&dev->mii, 1, 1);
        mii_ethtool_gset(&dev->mii, &ecmd);
@@ -856,8 +856,8 @@ static int ax88172_link_reset(struct usbnet *dev)
        if (ecmd.duplex != DUPLEX_FULL)
                mode |= ~AX88172_MEDIUM_FD;
-        netdev_dbg(dev->net, "ax88172_link_reset() speed: %d duplex: %d setting mode to 0x%04x\n",
+        netdev_dbg(dev->net, "ax88172_link_reset() speed: %u duplex: %d setting mode to 0x%04x\n",
-                   ecmd.speed, ecmd.duplex, mode);
+                   ethtool_cmd_speed(&ecmd), ecmd.duplex, mode);
        asix_write_medium_mode(dev, mode);
@@ -947,20 +947,20 @@ static const struct ethtool_ops ax88772_ethtool_ops = {
 static int ax88772_link_reset(struct usbnet *dev)
 {
        u16 mode;
-        struct ethtool_cmd ecmd;
+        struct ethtool_cmd ecmd = { .cmd = ETHTOOL_GSET };
        mii_check_media(&dev->mii, 1, 1);
        mii_ethtool_gset(&dev->mii, &ecmd);
        mode = AX88772_MEDIUM_DEFAULT;
-        if (ecmd.speed != SPEED_100)
+        if (ethtool_cmd_speed(&ecmd) != SPEED_100)
                mode &= ~AX_MEDIUM_PS;
        if (ecmd.duplex != DUPLEX_FULL)
                mode &= ~AX_MEDIUM_FD;
-        netdev_dbg(dev->net, "ax88772_link_reset() speed: %d duplex: %d setting mode to 0x%04x\n",
+        netdev_dbg(dev->net, "ax88772_link_reset() speed: %u duplex: %d setting mode to 0x%04x\n",
-                   ecmd.speed, ecmd.duplex, mode);
+                   ethtool_cmd_speed(&ecmd), ecmd.duplex, mode);
        asix_write_medium_mode(dev, mode);
@@ -1173,18 +1173,20 @@ static int marvell_led_status(struct usbnet *dev, u16 speed)
 static int ax88178_link_reset(struct usbnet *dev)
 {
        u16 mode;
-        struct ethtool_cmd ecmd;
+        struct ethtool_cmd ecmd = { .cmd = ETHTOOL_GSET };
        struct asix_data *data = (struct asix_data *)&dev->data;
+        u32 speed;
        netdev_dbg(dev->net, "ax88178_link_reset()\n");
        mii_check_media(&dev->mii, 1, 1);
        mii_ethtool_gset(&dev->mii, &ecmd);
        mode = AX88178_MEDIUM_DEFAULT;
+        speed = ethtool_cmd_speed(&ecmd);
-        if (ecmd.speed == SPEED_1000)
+        if (speed == SPEED_1000)
                mode |= AX_MEDIUM_GM;
-        else if (ecmd.speed == SPEED_100)
+        else if (speed == SPEED_100)
                mode |= AX_MEDIUM_PS;
        else
                mode &= ~(AX_MEDIUM_PS | AX_MEDIUM_GM);
@@ -1196,13 +1198,13 @@ static int ax88178_link_reset(struct usbnet *dev)
        else
                mode &= ~AX_MEDIUM_FD;
-        netdev_dbg(dev->net, "ax88178_link_reset() speed: %d duplex: %d setting mode to 0x%04x\n",
+        netdev_dbg(dev->net, "ax88178_link_reset() speed: %u duplex: %d setting mode to 0x%04x\n",
-                   ecmd.speed, ecmd.duplex, mode);
+                   speed, ecmd.duplex, mode);
        asix_write_medium_mode(dev, mode);
        if (data->phymode == PHY_MODE_MARVELL && data->ledmode)
-                marvell_led_status(dev, ecmd.speed);
+                marvell_led_status(dev, speed);
        return 0;
 }
diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c
index 97687d335903..d7221c4a5dcf 100644
--- a/drivers/net/usb/catc.c
+++ b/drivers/net/usb/catc.c
@@ -686,7 +686,7 @@ static int catc_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
        cmd->supported = SUPPORTED_10baseT_Half | SUPPORTED_TP;
        cmd->advertising = ADVERTISED_10baseT_Half | ADVERTISED_TP;
-        cmd->speed = SPEED_10;
+        ethtool_cmd_speed_set(cmd, SPEED_10);
        cmd->duplex = DUPLEX_HALF;
        cmd->port = PORT_TP; 
        cmd->phy_address = 0;
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 1033ef6476a4..4ab557d0287d 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -54,13 +54,13 @@
 #include <linux/usb/usbnet.h>
 #include <linux/usb/cdc.h>
-#define DRIVER_VERSION                          "23-Apr-2011"
+#define DRIVER_VERSION                          "06-May-2011"
 /* CDC NCM subclass 3.2.1 */
 #define USB_CDC_NCM_NDP16_LENGTH_MIN            0x10
 /* Maximum NTB length */
-#define CDC_NCM_NTB_MAX_SIZE_TX                 (16384 + 4) /* bytes, must be short terminated */
+#define CDC_NCM_NTB_MAX_SIZE_TX                 16384   /* bytes */
 #define CDC_NCM_NTB_MAX_SIZE_RX                 16384   /* bytes */
 /* Minimum value for MaxDatagramSize, ch. 6.2.9 */
@@ -722,7 +722,7 @@ cdc_ncm_fill_tx_frame(struct cdc_ncm_ctx *ctx, struct sk_buff *skb)
        } else {
                /* reset variables */
-                skb_out = alloc_skb(ctx->tx_max, GFP_ATOMIC);
+                skb_out = alloc_skb((ctx->tx_max + 1), GFP_ATOMIC);
                if (skb_out == NULL) {
                        if (skb != NULL) {
                                dev_kfree_skb_any(skb);
@@ -861,8 +861,11 @@ cdc_ncm_fill_tx_frame(struct cdc_ncm_ctx *ctx, struct sk_buff *skb)
        /* store last offset */
        last_offset = offset;
-        if ((last_offset < ctx->tx_max) && ((last_offset %
+        if (((last_offset < ctx->tx_max) && ((last_offset %
-                        le16_to_cpu(ctx->out_ep->desc.wMaxPacketSize)) == 0)) {
+                        le16_to_cpu(ctx->out_ep->desc.wMaxPacketSize)) == 0)) ||
+            (((last_offset == ctx->tx_max) && ((ctx->tx_max %
+                le16_to_cpu(ctx->out_ep->desc.wMaxPacketSize)) == 0)) &&
+                (ctx->tx_max < le32_to_cpu(ctx->ncm_parm.dwNtbOutMaxSize)))) {
                /* force short packet */
                *(((u8 *)skb_out->data) + last_offset) = 0;
                last_offset++;
diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c
index 5002f5be47be..1d93133e9b74 100644
--- a/drivers/net/usb/dm9601.c
+++ b/drivers/net/usb/dm9601.c
@@ -599,13 +599,13 @@ static void dm9601_status(struct usbnet *dev, struct urb *urb)
 static int dm9601_link_reset(struct usbnet *dev)
 {
-        struct ethtool_cmd ecmd;
+        struct ethtool_cmd ecmd = { .cmd = ETHTOOL_GSET };
        mii_check_media(&dev->mii, 1, 1);
        mii_ethtool_gset(&dev->mii, &ecmd);
-        netdev_dbg(dev->net, "link_reset() speed: %d duplex: %d\n",
+        netdev_dbg(dev->net, "link_reset() speed: %u duplex: %d\n",
-                   ecmd.speed, ecmd.duplex);
+                   ethtool_cmd_speed(&ecmd), ecmd.duplex);
        return 0;
 }
diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c
index 823c53751307..217aec8a768f 100644
--- a/drivers/net/usb/plusb.c
+++ b/drivers/net/usb/plusb.c
@@ -45,6 +45,14 @@
 * seems to get wedged under load.  Prolific docs are weak, and
 * don't identify differences between PL2301 and PL2302, much less
 * anything to explain the different PL2302 versions observed.
+ *
+ * NOTE:  pl2501 has several modes, including pl2301 and pl2302
+ * compatibility.   Some docs suggest the difference between 2301
+ * and 2302 is only to make MS-Windows use a different driver...
+ *
+ * pl25a1 glue based on patch from Tony Gibbs.  Prolific "docs" on
+ * this chip are as usual incomplete about what control messages
+ * are supported.
 */
 /*
@@ -86,16 +94,20 @@ pl_set_QuickLink_features(struct usbnet *dev, int val)
 static int pl_reset(struct usbnet *dev)
 {
+        int status;
        /* some units seem to need this reset, others reject it utterly.
         * FIXME be more like "naplink" or windows drivers.
         */
-        (void) pl_set_QuickLink_features(dev,
+        status = pl_set_QuickLink_features(dev,
                PL_S_EN|PL_RESET_OUT|PL_RESET_IN|PL_PEER_E);
+        if (status != 0 && netif_msg_probe(dev))
+                netif_dbg(dev, link, dev->net, "pl_reset --> %d\n", status);
        return 0;
 }
 static const struct driver_info prolific_info = {
-        .description =  "Prolific PL-2301/PL-2302",
+        .description =  "Prolific PL-2301/PL-2302/PL-25A1",
        .flags =        FLAG_POINTTOPOINT | FLAG_NO_SETINT,
                /* some PL-2302 versions seem to fail usb_set_interface() */
        .reset =        pl_reset,
@@ -111,6 +123,7 @@ static const struct driver_info	prolific_info = {
 static const struct usb_device_id       products [] = {
+/* full speed cables */
 {
        USB_DEVICE(0x067b, 0x0000),     // PL-2301
        .driver_info =  (unsigned long) &prolific_info,
@@ -119,6 +132,15 @@ static const struct usb_device_id	products [] = {
        .driver_info =  (unsigned long) &prolific_info,
 },
+/* high speed cables */
+{
+        USB_DEVICE(0x067b, 0x25a1),     /* PL-25A1, no eeprom */
+        .driver_info =  (unsigned long) &prolific_info,
+}, {
+        USB_DEVICE(0x050d, 0x258a),     /* Belkin F5U258/F5U279 (PL-25A1) */
+        .driver_info =  (unsigned long) &prolific_info,
+},
        { },            // END
 };
 MODULE_DEVICE_TABLE(usb, products);
@@ -134,16 +156,16 @@ static struct usb_driver plusb_driver = {
 static int __init plusb_init(void)
 {
-        return usb_register(&plusb_driver);
+        return usb_register(&plusb_driver);
 }
 module_init(plusb_init);
 static void __exit plusb_exit(void)
 {
-        usb_deregister(&plusb_driver);
+        usb_deregister(&plusb_driver);
 }
 module_exit(plusb_exit);
 MODULE_AUTHOR("David Brownell");
-MODULE_DESCRIPTION("Prolific PL-2301/2302 USB Host to Host Link Driver");
+MODULE_DESCRIPTION("Prolific PL-2301/2302/25A1 USB Host to Host Link Driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c
index 5994a25c56ac..255d6a424a6b 100644
--- a/drivers/net/usb/rndis_host.c
+++ b/drivers/net/usb/rndis_host.c
@@ -104,8 +104,10 @@ static void rndis_msg_indicate(struct usbnet *dev, struct rndis_indicate *msg,
 int rndis_command(struct usbnet *dev, struct rndis_msg_hdr *buf, int buflen)
 {
        struct cdc_state        *info = (void *) &dev->data;
+        struct usb_cdc_notification notification;
        int                     master_ifnum;
        int                     retval;
+        int                     partial;
        unsigned                count;
        __le32                  rsp;
        u32                     xid = 0, msg_len, request_id;
@@ -133,13 +135,20 @@ int rndis_command(struct usbnet *dev, struct rndis_msg_hdr *buf, int buflen)
        if (unlikely(retval < 0 || xid == 0))
                return retval;
-        // FIXME Seems like some devices discard responses when
+        /* Some devices don't respond on the control channel until
-        // we time out and cancel our "get response" requests...
+         * polled on the status channel, so do that first. */
-        // so, this is fragile.  Probably need to poll for status.
+        if (dev->driver_info->data & RNDIS_DRIVER_DATA_POLL_STATUS) {
+                retval = usb_interrupt_msg(
+                        dev->udev,
+                        usb_rcvintpipe(dev->udev,
+                                       dev->status->desc.bEndpointAddress),
+                        &notification, sizeof(notification), &partial,
+                        RNDIS_CONTROL_TIMEOUT_MS);
+                if (unlikely(retval < 0))
+                        return retval;
+        }
-        /* ignore status endpoint, just poll the control channel;
+        /* Poll the control channel; the request probably completed immediately */
-         * the request probably completed immediately
-         */
        rsp = buf->msg_type | RNDIS_MSG_COMPLETION;
        for (count = 0; count < 10; count++) {
                memset(buf, 0, CONTROL_BUFFER_SIZE);
@@ -581,17 +590,33 @@ static const struct driver_info	rndis_info = {
        .tx_fixup =     rndis_tx_fixup,
 };
+static const struct driver_info rndis_poll_status_info = {
+        .description =  "RNDIS device (poll status before control)",
+        .flags =        FLAG_ETHER | FLAG_POINTTOPOINT | FLAG_FRAMING_RN | FLAG_NO_SETINT,
+        .data =         RNDIS_DRIVER_DATA_POLL_STATUS,
+        .bind =         rndis_bind,
+        .unbind =       rndis_unbind,
+        .status =       rndis_status,
+        .rx_fixup =     rndis_rx_fixup,
+        .tx_fixup =     rndis_tx_fixup,
+};
 /*-------------------------------------------------------------------------*/
 static const struct usb_device_id       products [] = {
 {
+        /* 2Wire HomePortal 1000SW */
+        USB_DEVICE_AND_INTERFACE_INFO(0x1630, 0x0042,
+                                      USB_CLASS_COMM, 2 /* ACM */, 0x0ff),
+        .driver_info = (unsigned long) &rndis_poll_status_info,
+}, {
        /* RNDIS is MSFT's un-official variant of CDC ACM */
        USB_INTERFACE_INFO(USB_CLASS_COMM, 2 /* ACM */, 0x0ff),
        .driver_info = (unsigned long) &rndis_info,
 }, {
        /* "ActiveSync" is an undocumented variant of RNDIS, used in WM5 */
        USB_INTERFACE_INFO(USB_CLASS_MISC, 1, 1),
-        .driver_info = (unsigned long) &rndis_info,
+        .driver_info = (unsigned long) &rndis_poll_status_info,
 }, {
        /* RNDIS for tethering */
        USB_INTERFACE_INFO(USB_CLASS_WIRELESS_CONTROLLER, 1, 3),
diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index e85c89c6706d..041fb7d43c4f 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -843,10 +843,11 @@ static int rtl8150_get_settings(struct net_device *netdev, struct ethtool_cmd *e
        get_registers(dev, BMCR, 2, &bmcr);
        get_registers(dev, ANLP, 2, &lpa);
        if (bmcr & BMCR_ANENABLE) {
+                u32 speed = ((lpa & (LPA_100HALF | LPA_100FULL)) ?
+                             SPEED_100 : SPEED_10);
+                ethtool_cmd_speed_set(ecmd, speed);
                ecmd->autoneg = AUTONEG_ENABLE;
-                ecmd->speed = (lpa & (LPA_100HALF | LPA_100FULL)) ?
+                if (speed == SPEED_100)
-                             SPEED_100 : SPEED_10;
-                if (ecmd->speed == SPEED_100)
                        ecmd->duplex = (lpa & LPA_100FULL) ?
                            DUPLEX_FULL : DUPLEX_HALF;
                else
@@ -854,8 +855,8 @@ static int rtl8150_get_settings(struct net_device *netdev, struct ethtool_cmd *e
                            DUPLEX_FULL : DUPLEX_HALF;
        } else {
                ecmd->autoneg = AUTONEG_DISABLE;
-                ecmd->speed = (bmcr & BMCR_SPEED100) ?
+                ethtool_cmd_speed_set(ecmd, ((bmcr & BMCR_SPEED100) ?
-                    SPEED_100 : SPEED_10;
+                                             SPEED_100 : SPEED_10));
                ecmd->duplex = (bmcr & BMCR_FULLDPLX) ?
                    DUPLEX_FULL : DUPLEX_HALF;
        }
diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c
index 753ee6eb7edd..15b3d6888ae9 100644
--- a/drivers/net/usb/smsc75xx.c
+++ b/drivers/net/usb/smsc75xx.c
@@ -65,7 +65,6 @@ struct smsc75xx_priv {
        struct usbnet *dev;
        u32 rfe_ctl;
        u32 multicast_hash_table[DP_SEL_VHF_HASH_LEN];
-        bool use_rx_csum;
        struct mutex dataport_mutex;
        spinlock_t rfe_ctl_lock;
        struct work_struct set_multicast;
@@ -504,7 +503,7 @@ static int smsc75xx_update_flowcontrol(struct usbnet *dev, u8 duplex,
 static int smsc75xx_link_reset(struct usbnet *dev)
 {
        struct mii_if_info *mii = &dev->mii;
-        struct ethtool_cmd ecmd;
+        struct ethtool_cmd ecmd = { .cmd = ETHTOOL_GSET };
        u16 lcladv, rmtadv;
        int ret;
@@ -520,8 +519,9 @@ static int smsc75xx_link_reset(struct usbnet *dev)
        lcladv = smsc75xx_mdio_read(dev->net, mii->phy_id, MII_ADVERTISE);
        rmtadv = smsc75xx_mdio_read(dev->net, mii->phy_id, MII_LPA);
-        netif_dbg(dev, link, dev->net, "speed: %d duplex: %d lcladv: %04x"
+        netif_dbg(dev, link, dev->net, "speed: %u duplex: %d lcladv: %04x"
-                " rmtadv: %04x", ecmd.speed, ecmd.duplex, lcladv, rmtadv);
+                  " rmtadv: %04x", ethtool_cmd_speed(&ecmd),
+                  ecmd.duplex, lcladv, rmtadv);
        return smsc75xx_update_flowcontrol(dev, ecmd.duplex, lcladv, rmtadv);
 }
@@ -548,28 +548,6 @@ static void smsc75xx_status(struct usbnet *dev, struct urb *urb)
                        "unexpected interrupt, intdata=0x%08X", intdata);
 }
-/* Enable or disable Rx checksum offload engine */
-static int smsc75xx_set_rx_csum_offload(struct usbnet *dev)
-{
-        struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);
-        unsigned long flags;
-        int ret;
-        spin_lock_irqsave(&pdata->rfe_ctl_lock, flags);
-        if (pdata->use_rx_csum)
-                pdata->rfe_ctl |= RFE_CTL_TCPUDP_CKM | RFE_CTL_IP_CKM;
-        else
-                pdata->rfe_ctl &= ~(RFE_CTL_TCPUDP_CKM | RFE_CTL_IP_CKM);
-        spin_unlock_irqrestore(&pdata->rfe_ctl_lock, flags);
-        ret = smsc75xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
-        check_warn_return(ret, "Error writing RFE_CTL");
-        return 0;
-}
 static int smsc75xx_ethtool_get_eeprom_len(struct net_device *net)
 {
        return MAX_EEPROM_SIZE;
@@ -599,34 +577,6 @@ static int smsc75xx_ethtool_set_eeprom(struct net_device *netdev,
        return smsc75xx_write_eeprom(dev, ee->offset, ee->len, data);
 }
-static u32 smsc75xx_ethtool_get_rx_csum(struct net_device *netdev)
-{
-        struct usbnet *dev = netdev_priv(netdev);
-        struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);
-        return pdata->use_rx_csum;
-}
-static int smsc75xx_ethtool_set_rx_csum(struct net_device *netdev, u32 val)
-{
-        struct usbnet *dev = netdev_priv(netdev);
-        struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);
-        pdata->use_rx_csum = !!val;
-        return smsc75xx_set_rx_csum_offload(dev);
-}
-static int smsc75xx_ethtool_set_tso(struct net_device *netdev, u32 data)
-{
-        if (data)
-                netdev->features |= NETIF_F_TSO | NETIF_F_TSO6;
-        else
-                netdev->features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
-        return 0;
-}
 static const struct ethtool_ops smsc75xx_ethtool_ops = {
        .get_link       = usbnet_get_link,
        .nway_reset     = usbnet_nway_reset,
@@ -638,12 +588,6 @@ static const struct ethtool_ops smsc75xx_ethtool_ops = {
        .get_eeprom_len = smsc75xx_ethtool_get_eeprom_len,
        .get_eeprom     = smsc75xx_ethtool_get_eeprom,
        .set_eeprom     = smsc75xx_ethtool_set_eeprom,
-        .get_tx_csum    = ethtool_op_get_tx_csum,
-        .set_tx_csum    = ethtool_op_set_tx_hw_csum,
-        .get_rx_csum    = smsc75xx_ethtool_get_rx_csum,
-        .set_rx_csum    = smsc75xx_ethtool_set_rx_csum,
-        .get_tso        = ethtool_op_get_tso,
-        .set_tso        = smsc75xx_ethtool_set_tso,
 };
 static int smsc75xx_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
@@ -782,6 +726,30 @@ static int smsc75xx_change_mtu(struct net_device *netdev, int new_mtu)
        return usbnet_change_mtu(netdev, new_mtu);
 }
+/* Enable or disable Rx checksum offload engine */
+static int smsc75xx_set_features(struct net_device *netdev, u32 features)
+{
+        struct usbnet *dev = netdev_priv(netdev);
+        struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);
+        unsigned long flags;
+        int ret;
+        spin_lock_irqsave(&pdata->rfe_ctl_lock, flags);
+        if (features & NETIF_F_RXCSUM)
+                pdata->rfe_ctl |= RFE_CTL_TCPUDP_CKM | RFE_CTL_IP_CKM;
+        else
+                pdata->rfe_ctl &= ~(RFE_CTL_TCPUDP_CKM | RFE_CTL_IP_CKM);
+        spin_unlock_irqrestore(&pdata->rfe_ctl_lock, flags);
+        /* it's racing here! */
+        ret = smsc75xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
+        check_warn_return(ret, "Error writing RFE_CTL");
+        return 0;
+}
 static int smsc75xx_reset(struct usbnet *dev)
 {
        struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);
@@ -960,11 +928,7 @@ static int smsc75xx_reset(struct usbnet *dev)
        netif_dbg(dev, ifup, dev->net, "RFE_CTL set to 0x%08x", pdata->rfe_ctl);
        /* Enable or disable checksum offload engines */
-        ethtool_op_set_tx_hw_csum(dev->net, DEFAULT_TX_CSUM_ENABLE);
+        smsc75xx_set_features(dev->net, dev->net->features);
-        ret = smsc75xx_set_rx_csum_offload(dev);
-        check_warn_return(ret, "Failed to set rx csum offload: %d", ret);
-        smsc75xx_ethtool_set_tso(dev->net, DEFAULT_TSO_ENABLE);
        smsc75xx_set_multicast(dev->net);
@@ -1037,6 +1001,7 @@ static const struct net_device_ops smsc75xx_netdev_ops = {
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_do_ioctl           = smsc75xx_ioctl,
        .ndo_set_multicast_list = smsc75xx_set_multicast,
+        .ndo_set_features       = smsc75xx_set_features,
 };
 static int smsc75xx_bind(struct usbnet *dev, struct usb_interface *intf)
@@ -1065,10 +1030,17 @@ static int smsc75xx_bind(struct usbnet *dev, struct usb_interface *intf)
        INIT_WORK(&pdata->set_multicast, smsc75xx_deferred_multicast_write);
-        pdata->use_rx_csum = DEFAULT_RX_CSUM_ENABLE;
+        if (DEFAULT_TX_CSUM_ENABLE) {
+                dev->net->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
+                if (DEFAULT_TSO_ENABLE)
+                        dev->net->features |= NETIF_F_SG |
+                                NETIF_F_TSO | NETIF_F_TSO6;
+        }
+        if (DEFAULT_RX_CSUM_ENABLE)
+                dev->net->features |= NETIF_F_RXCSUM;
-        /* We have to advertise SG otherwise TSO cannot be enabled */
+        dev->net->hw_features = NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
-        dev->net->features |= NETIF_F_SG;
+                NETIF_F_SG | NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_RXCSUM;
        /* Init all registers */
        ret = smsc75xx_reset(dev);
@@ -1091,10 +1063,11 @@ static void smsc75xx_unbind(struct usbnet *dev, struct usb_interface *intf)
        }
 }
-static void smsc75xx_rx_csum_offload(struct sk_buff *skb, u32 rx_cmd_a,
+static void smsc75xx_rx_csum_offload(struct usbnet *dev, struct sk_buff *skb,
-                                     u32 rx_cmd_b)
+                                     u32 rx_cmd_a, u32 rx_cmd_b)
 {
-        if (unlikely(rx_cmd_a & RX_CMD_A_LCSM)) {
+        if (!(dev->net->features & NETIF_F_RXCSUM) ||
+            unlikely(rx_cmd_a & RX_CMD_A_LCSM)) {
                skb->ip_summed = CHECKSUM_NONE;
        } else {
                skb->csum = ntohs((u16)(rx_cmd_b >> RX_CMD_B_CSUM_SHIFT));
@@ -1104,8 +1077,6 @@ static void smsc75xx_rx_csum_offload(struct sk_buff *skb, u32 rx_cmd_a,
 static int smsc75xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
 {
-        struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);
        while (skb->len > 0) {
                u32 rx_cmd_a, rx_cmd_b, align_count, size;
                struct sk_buff *ax_skb;
@@ -1145,11 +1116,8 @@ static int smsc75xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
                        /* last frame in this batch */
                        if (skb->len == size) {
-                                if (pdata->use_rx_csum)
+                                smsc75xx_rx_csum_offload(dev, skb, rx_cmd_a,
-                                        smsc75xx_rx_csum_offload(skb, rx_cmd_a,
+                                        rx_cmd_b);
-                                                rx_cmd_b);
-                                else
-                                        skb->ip_summed = CHECKSUM_NONE;
                                skb_trim(skb, skb->len - 4); /* remove fcs */
                                skb->truesize = size + sizeof(struct sk_buff);
@@ -1167,11 +1135,8 @@ static int smsc75xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
                        ax_skb->data = packet;
                        skb_set_tail_pointer(ax_skb, size);
-                        if (pdata->use_rx_csum)
+                        smsc75xx_rx_csum_offload(dev, ax_skb, rx_cmd_a,
-                                smsc75xx_rx_csum_offload(ax_skb, rx_cmd_a,
+                                rx_cmd_b);
-                                        rx_cmd_b);
-                        else
-                                ax_skb->ip_summed = CHECKSUM_NONE;
                        skb_trim(ax_skb, ax_skb->len - 4); /* remove fcs */
                        ax_skb->truesize = size + sizeof(struct sk_buff);
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 48d4efdb4959..f74f3ce71526 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -52,8 +52,6 @@ struct smsc95xx_priv {
        u32 hash_hi;
        u32 hash_lo;
        spinlock_t mac_cr_lock;
-        bool use_tx_csum;
-        bool use_rx_csum;
 };
 struct usb_context {
@@ -459,7 +457,7 @@ static int smsc95xx_link_reset(struct usbnet *dev)
 {
        struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
        struct mii_if_info *mii = &dev->mii;
-        struct ethtool_cmd ecmd;
+        struct ethtool_cmd ecmd = { .cmd = ETHTOOL_GSET };
        unsigned long flags;
        u16 lcladv, rmtadv;
        u32 intdata;
@@ -474,8 +472,9 @@ static int smsc95xx_link_reset(struct usbnet *dev)
        lcladv = smsc95xx_mdio_read(dev->net, mii->phy_id, MII_ADVERTISE);
        rmtadv = smsc95xx_mdio_read(dev->net, mii->phy_id, MII_LPA);
-        netif_dbg(dev, link, dev->net, "speed: %d duplex: %d lcladv: %04x rmtadv: %04x\n",
+        netif_dbg(dev, link, dev->net,
-                  ecmd.speed, ecmd.duplex, lcladv, rmtadv);
+                  "speed: %u duplex: %d lcladv: %04x rmtadv: %04x\n",
+                  ethtool_cmd_speed(&ecmd), ecmd.duplex, lcladv, rmtadv);
        spin_lock_irqsave(&pdata->mac_cr_lock, flags);
        if (ecmd.duplex != DUPLEX_FULL) {
@@ -517,22 +516,24 @@ static void smsc95xx_status(struct usbnet *dev, struct urb *urb)
 }
 /* Enable or disable Tx & Rx checksum offload engines */
-static int smsc95xx_set_csums(struct usbnet *dev)
+static int smsc95xx_set_features(struct net_device *netdev, u32 features)
 {
-        struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
+        struct usbnet *dev = netdev_priv(netdev);
        u32 read_buf;
-        int ret = smsc95xx_read_reg(dev, COE_CR, &read_buf);
+        int ret;
+        ret = smsc95xx_read_reg(dev, COE_CR, &read_buf);
        if (ret < 0) {
                netdev_warn(dev->net, "Failed to read COE_CR: %d\n", ret);
                return ret;
        }
-        if (pdata->use_tx_csum)
+        if (features & NETIF_F_HW_CSUM)
                read_buf |= Tx_COE_EN_;
        else
                read_buf &= ~Tx_COE_EN_;
-        if (pdata->use_rx_csum)
+        if (features & NETIF_F_RXCSUM)
                read_buf |= Rx_COE_EN_;
        else
                read_buf &= ~Rx_COE_EN_;
@@ -576,43 +577,6 @@ static int smsc95xx_ethtool_set_eeprom(struct net_device *netdev,
        return smsc95xx_write_eeprom(dev, ee->offset, ee->len, data);
 }
-static u32 smsc95xx_ethtool_get_rx_csum(struct net_device *netdev)
-{
-        struct usbnet *dev = netdev_priv(netdev);
-        struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
-        return pdata->use_rx_csum;
-}
-static int smsc95xx_ethtool_set_rx_csum(struct net_device *netdev, u32 val)
-{
-        struct usbnet *dev = netdev_priv(netdev);
-        struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
-        pdata->use_rx_csum = !!val;
-        return smsc95xx_set_csums(dev);
-}
-static u32 smsc95xx_ethtool_get_tx_csum(struct net_device *netdev)
-{
-        struct usbnet *dev = netdev_priv(netdev);
-        struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
-        return pdata->use_tx_csum;
-}
-static int smsc95xx_ethtool_set_tx_csum(struct net_device *netdev, u32 val)
-{
-        struct usbnet *dev = netdev_priv(netdev);
-        struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
-        pdata->use_tx_csum = !!val;
-        ethtool_op_set_tx_hw_csum(netdev, pdata->use_tx_csum);
-        return smsc95xx_set_csums(dev);
-}
 static const struct ethtool_ops smsc95xx_ethtool_ops = {
        .get_link       = usbnet_get_link,
        .nway_reset     = usbnet_nway_reset,
@@ -624,10 +588,6 @@ static const struct ethtool_ops smsc95xx_ethtool_ops = {
        .get_eeprom_len = smsc95xx_ethtool_get_eeprom_len,
        .get_eeprom     = smsc95xx_ethtool_get_eeprom,
        .set_eeprom     = smsc95xx_ethtool_set_eeprom,
-        .get_tx_csum    = smsc95xx_ethtool_get_tx_csum,
-        .set_tx_csum    = smsc95xx_ethtool_set_tx_csum,
-        .get_rx_csum    = smsc95xx_ethtool_get_rx_csum,
-        .set_rx_csum    = smsc95xx_ethtool_set_rx_csum,
 };
 static int smsc95xx_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
@@ -755,7 +715,6 @@ static int smsc95xx_phy_initialize(struct usbnet *dev)
 static int smsc95xx_reset(struct usbnet *dev)
 {
        struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
-        struct net_device *netdev = dev->net;
        u32 read_buf, write_buf, burst_cap;
        int ret = 0, timeout;
@@ -975,12 +934,7 @@ static int smsc95xx_reset(struct usbnet *dev)
        }
        /* Enable or disable checksum offload engines */
-        ethtool_op_set_tx_hw_csum(netdev, pdata->use_tx_csum);
+        smsc95xx_set_features(dev->net, dev->net->features);
-        ret = smsc95xx_set_csums(dev);
-        if (ret < 0) {
-                netdev_warn(dev->net, "Failed to set csum offload: %d\n", ret);
-                return ret;
-        }
        smsc95xx_set_multicast(dev->net);
@@ -1019,6 +973,7 @@ static const struct net_device_ops smsc95xx_netdev_ops = {
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_do_ioctl           = smsc95xx_ioctl,
        .ndo_set_multicast_list = smsc95xx_set_multicast,
+        .ndo_set_features       = smsc95xx_set_features,
 };
 static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf)
@@ -1045,8 +1000,12 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf)
        spin_lock_init(&pdata->mac_cr_lock);
-        pdata->use_tx_csum = DEFAULT_TX_CSUM_ENABLE;
+        if (DEFAULT_TX_CSUM_ENABLE)
-        pdata->use_rx_csum = DEFAULT_RX_CSUM_ENABLE;
+                dev->net->features |= NETIF_F_HW_CSUM;
+        if (DEFAULT_RX_CSUM_ENABLE)
+                dev->net->features |= NETIF_F_RXCSUM;
+        dev->net->hw_features = NETIF_F_HW_CSUM | NETIF_F_RXCSUM;
        smsc95xx_init_mac_address(dev);
@@ -1056,7 +1015,7 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf)
        dev->net->netdev_ops = &smsc95xx_netdev_ops;
        dev->net->ethtool_ops = &smsc95xx_ethtool_ops;
        dev->net->flags |= IFF_MULTICAST;
-        dev->net->hard_header_len += SMSC95XX_TX_OVERHEAD;
+        dev->net->hard_header_len += SMSC95XX_TX_OVERHEAD_CSUM;
        return 0;
 }
@@ -1080,8 +1039,6 @@ static void smsc95xx_rx_csum_offload(struct sk_buff *skb)
 static int smsc95xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
 {
-        struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
        while (skb->len > 0) {
                u32 header, align_count;
                struct sk_buff *ax_skb;
@@ -1123,7 +1080,7 @@ static int smsc95xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
                        /* last frame in this batch */
                        if (skb->len == size) {
-                                if (pdata->use_rx_csum)
+                                if (dev->net->features & NETIF_F_RXCSUM)
                                        smsc95xx_rx_csum_offload(skb);
                                skb_trim(skb, skb->len - 4); /* remove fcs */
                                skb->truesize = size + sizeof(struct sk_buff);
@@ -1141,7 +1098,7 @@ static int smsc95xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
                        ax_skb->data = packet;
                        skb_set_tail_pointer(ax_skb, size);
-                        if (pdata->use_rx_csum)
+                        if (dev->net->features & NETIF_F_RXCSUM)
                                smsc95xx_rx_csum_offload(ax_skb);
                        skb_trim(ax_skb, ax_skb->len - 4); /* remove fcs */
                        ax_skb->truesize = size + sizeof(struct sk_buff);
@@ -1174,8 +1131,7 @@ static u32 smsc95xx_calc_csum_preamble(struct sk_buff *skb)
 static struct sk_buff *smsc95xx_tx_fixup(struct usbnet *dev,
                                         struct sk_buff *skb, gfp_t flags)
 {
-        struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
+        bool csum = skb->ip_summed == CHECKSUM_PARTIAL;
-        bool csum = pdata->use_tx_csum && (skb->ip_summed == CHECKSUM_PARTIAL);
        int overhead = csum ? SMSC95XX_TX_OVERHEAD_CSUM : SMSC95XX_TX_OVERHEAD;
        u32 tx_cmd_a, tx_cmd_b;
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 9ab439d144ed..e6dd24466965 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1541,9 +1541,9 @@ EXPORT_SYMBOL_GPL(usbnet_resume);
 static int __init usbnet_init(void)
 {
-        /* compiler should optimize this out */
+        /* Compiler should optimize this out. */
-        BUILD_BUG_ON (sizeof (((struct sk_buff *)0)->cb)
+        BUILD_BUG_ON(
-                        < sizeof (struct skb_data));
+                FIELD_SIZEOF(struct sk_buff, cb) < sizeof(struct skb_data));
        random_ether_addr(node_id);
        return 0;
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 3b99f64104fd..8461576fa015 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -22,7 +22,6 @@
 #define MIN_MTU 68              /* Min L3 MTU */
 #define MAX_MTU 65535           /* Max L3 MTU (arbitrary) */
-#define MTU_PAD (ETH_HLEN + 4)  /* Max difference between L2 and L3 size MTU */
 struct veth_net_stats {
        unsigned long   rx_packets;
@@ -36,7 +35,6 @@ struct veth_net_stats {
 struct veth_priv {
        struct net_device *peer;
        struct veth_net_stats __percpu *stats;
-        unsigned ip_summed;
 };
 /*
@@ -53,7 +51,7 @@ static int veth_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        cmd->supported          = 0;
        cmd->advertising        = 0;
-        cmd->speed              = SPEED_10000;
+        ethtool_cmd_speed_set(cmd, SPEED_10000);
        cmd->duplex             = DUPLEX_FULL;
        cmd->port               = PORT_TP;
        cmd->phy_address        = 0;
@@ -99,47 +97,10 @@ static void veth_get_ethtool_stats(struct net_device *dev,
        data[0] = priv->peer->ifindex;
 }
-static u32 veth_get_rx_csum(struct net_device *dev)
-{
-        struct veth_priv *priv;
-        priv = netdev_priv(dev);
-        return priv->ip_summed == CHECKSUM_UNNECESSARY;
-}
-static int veth_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct veth_priv *priv;
-        priv = netdev_priv(dev);
-        priv->ip_summed = data ? CHECKSUM_UNNECESSARY : CHECKSUM_NONE;
-        return 0;
-}
-static u32 veth_get_tx_csum(struct net_device *dev)
-{
-        return (dev->features & NETIF_F_NO_CSUM) != 0;
-}
-static int veth_set_tx_csum(struct net_device *dev, u32 data)
-{
-        if (data)
-                dev->features |= NETIF_F_NO_CSUM;
-        else
-                dev->features &= ~NETIF_F_NO_CSUM;
-        return 0;
-}
 static const struct ethtool_ops veth_ethtool_ops = {
        .get_settings           = veth_get_settings,
        .get_drvinfo            = veth_get_drvinfo,
        .get_link               = ethtool_op_get_link,
-        .get_rx_csum            = veth_get_rx_csum,
-        .set_rx_csum            = veth_set_rx_csum,
-        .get_tx_csum            = veth_get_tx_csum,
-        .set_tx_csum            = veth_set_tx_csum,
-        .get_sg                 = ethtool_op_get_sg,
-        .set_sg                 = ethtool_op_set_sg,
        .get_strings            = veth_get_strings,
        .get_sset_count         = veth_get_sset_count,
        .get_ethtool_stats      = veth_get_ethtool_stats,
@@ -168,8 +129,9 @@ static netdev_tx_t veth_xmit(struct sk_buff *skb, struct net_device *dev)
        /* don't change ip_summed == CHECKSUM_PARTIAL, as that
           will cause bad checksum on forwarded packets */
-        if (skb->ip_summed == CHECKSUM_NONE)
+        if (skb->ip_summed == CHECKSUM_NONE &&
-                skb->ip_summed = rcv_priv->ip_summed;
+            rcv->features & NETIF_F_RXCSUM)
+                skb->ip_summed = CHECKSUM_UNNECESSARY;
        length = skb->len;
        if (dev_forward_skb(rcv, skb) != NET_RX_SUCCESS)
@@ -304,6 +266,8 @@ static void veth_setup(struct net_device *dev)
        dev->ethtool_ops = &veth_ethtool_ops;
        dev->features |= NETIF_F_LLTX;
        dev->destructor = veth_dev_free;
+        dev->hw_features = NETIF_F_NO_CSUM | NETIF_F_SG | NETIF_F_RXCSUM;
 }
 /*
diff --git a/drivers/net/via-rhine.c b/drivers/net/via-rhine.c
index eb5d75df5d5d..7f23ab913fd9 100644
--- a/drivers/net/via-rhine.c
+++ b/drivers/net/via-rhine.c
@@ -29,6 +29,8 @@
 */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #define DRV_NAME        "via-rhine"
 #define DRV_VERSION     "1.5.0"
 #define DRV_RELDATE     "2010-10-09"
@@ -37,6 +39,7 @@
 /* A few user-configurable values.
   These may be modified when a driver module is loaded. */
+#define DEBUG
 static int debug = 1;   /* 1 normal messages, 0 quiet .. 7 verbose. */
 static int max_interrupt_work = 20;
@@ -111,8 +114,7 @@ static const int multicast_filter_limit = 32;
 /* These identify the driver base version and may not be removed. */
 static const char version[] __devinitconst =
-        KERN_INFO DRV_NAME ".c:v1.10-LK" DRV_VERSION " " DRV_RELDATE
+        "v1.10-LK" DRV_VERSION " " DRV_RELDATE " Written by Donald Becker";
-        " Written by Donald Becker\n";
 /* This driver was written to use PCI memory space. Some early versions
   of the Rhine may only work correctly with I/O space accesses. */
@@ -495,14 +497,15 @@ static void rhine_set_vlan_cam_mask(void __iomem *ioaddr, u32 mask);
 static void rhine_init_cam_filter(struct net_device *dev);
 static void rhine_update_vcam(struct net_device *dev);
-#define RHINE_WAIT_FOR(condition) do {                                  \
+#define RHINE_WAIT_FOR(condition)                               \
-        int i=1024;                                                     \
+do {                                                            \
-        while (!(condition) && --i)                                     \
+        int i = 1024;                                           \
-                ;                                                       \
+        while (!(condition) && --i)                             \
-        if (debug > 1 && i < 512)                                       \
+                ;                                               \
-                printk(KERN_INFO "%s: %4d cycles used @ %s:%d\n",       \
+        if (debug > 1 && i < 512)                               \
-                                DRV_NAME, 1024-i, __func__, __LINE__);  \
+                pr_info("%4d cycles used @ %s:%d\n",            \
-} while(0)
+                        1024 - i, __func__, __LINE__);          \
+} while (0)
 static inline u32 get_intr_status(struct net_device *dev)
 {
@@ -571,8 +574,8 @@ static void rhine_power_init(struct net_device *dev)
                        default:
                                reason = "Unknown";
                        }
-                        printk(KERN_INFO "%s: Woke system up. Reason: %s.\n",
+                        netdev_info(dev, "Woke system up. Reason: %s\n",
-                               DRV_NAME, reason);
+                                    reason);
                }
        }
 }
@@ -586,8 +589,7 @@ static void rhine_chip_reset(struct net_device *dev)
        IOSYNC;
        if (ioread8(ioaddr + ChipCmd1) & Cmd1Reset) {
-                printk(KERN_INFO "%s: Reset not complete yet. "
+                netdev_info(dev, "Reset not complete yet. Trying harder.\n");
-                        "Trying harder.\n", DRV_NAME);
                /* Force reset */
                if (rp->quirks & rqForceReset)
@@ -598,9 +600,9 @@ static void rhine_chip_reset(struct net_device *dev)
        }
        if (debug > 1)
-                printk(KERN_INFO "%s: Reset %s.\n", dev->name,
+                netdev_info(dev, "Reset %s\n",
-                        (ioread8(ioaddr + ChipCmd1) & Cmd1Reset) ?
+                            (ioread8(ioaddr + ChipCmd1) & Cmd1Reset) ?
-                        "failed" : "succeeded");
+                            "failed" : "succeeded");
 }
 #ifdef USE_MMIO
@@ -728,9 +730,7 @@ static int __devinit rhine_init_one(struct pci_dev *pdev,
 /* when built into the kernel, we only print version if device is found */
 #ifndef MODULE
-        static int printed_version;
+        pr_info_once("%s\n", version);
-        if (!printed_version++)
-                printk(version);
 #endif
        io_size = 256;
@@ -765,8 +765,8 @@ static int __devinit rhine_init_one(struct pci_dev *pdev,
        /* this should always be supported */
        rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
        if (rc) {
-                printk(KERN_ERR "32-bit PCI DMA addresses not supported by "
+                dev_err(&pdev->dev,
-                       "the card!?\n");
+                        "32-bit PCI DMA addresses not supported by the card!?\n");
                goto err_out;
        }
@@ -774,7 +774,7 @@ static int __devinit rhine_init_one(struct pci_dev *pdev,
        if ((pci_resource_len(pdev, 0) < io_size) ||
            (pci_resource_len(pdev, 1) < io_size)) {
                rc = -EIO;
-                printk(KERN_ERR "Insufficient PCI resources, aborting\n");
+                dev_err(&pdev->dev, "Insufficient PCI resources, aborting\n");
                goto err_out;
        }
@@ -786,7 +786,7 @@ static int __devinit rhine_init_one(struct pci_dev *pdev,
        dev = alloc_etherdev(sizeof(struct rhine_private));
        if (!dev) {
                rc = -ENOMEM;
-                printk(KERN_ERR "alloc_etherdev failed\n");
+                dev_err(&pdev->dev, "alloc_etherdev failed\n");
                goto err_out;
        }
        SET_NETDEV_DEV(dev, &pdev->dev);
@@ -804,8 +804,9 @@ static int __devinit rhine_init_one(struct pci_dev *pdev,
        ioaddr = pci_iomap(pdev, bar, io_size);
        if (!ioaddr) {
                rc = -EIO;
-                printk(KERN_ERR "ioremap failed for device %s, region 0x%X "
+                dev_err(&pdev->dev,
-                       "@ 0x%lX\n", pci_name(pdev), io_size, memaddr);
+                        "ioremap failed for device %s, region 0x%X @ 0x%lX\n",
+                        pci_name(pdev), io_size, memaddr);
                goto err_out_free_res;
        }
@@ -820,8 +821,9 @@ static int __devinit rhine_init_one(struct pci_dev *pdev,
                unsigned char b = readb(ioaddr+reg);
                if (a != b) {
                        rc = -EIO;
-                        printk(KERN_ERR "MMIO do not match PIO [%02x] "
+                        dev_err(&pdev->dev,
-                               "(%02x != %02x)\n", reg, a, b);
+                                "MMIO do not match PIO [%02x] (%02x != %02x)\n",
+                                reg, a, b);
                        goto err_out_unmap;
                }
        }
@@ -836,13 +838,15 @@ static int __devinit rhine_init_one(struct pci_dev *pdev,
        for (i = 0; i < 6; i++)
                dev->dev_addr[i] = ioread8(ioaddr + StationAddr + i);
-        memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
-        if (!is_valid_ether_addr(dev->perm_addr)) {
+        if (!is_valid_ether_addr(dev->dev_addr)) {
-                rc = -EIO;
+                /* Report it and use a random ethernet address instead */
-                printk(KERN_ERR "Invalid MAC address\n");
+                netdev_err(dev, "Invalid MAC address: %pM\n", dev->dev_addr);
-                goto err_out_unmap;
+                random_ether_addr(dev->dev_addr);
+                netdev_info(dev, "Using random MAC address: %pM\n",
+                            dev->dev_addr);
        }
+        memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
        /* For Rhine-I/II, phy_id is loaded from EEPROM */
        if (!phy_id)
@@ -878,14 +882,14 @@ static int __devinit rhine_init_one(struct pci_dev *pdev,
        if (rc)
                goto err_out_unmap;
-        printk(KERN_INFO "%s: VIA %s at 0x%lx, %pM, IRQ %d.\n",
+        netdev_info(dev, "VIA %s at 0x%lx, %pM, IRQ %d\n",
-               dev->name, name,
+                    name,
 #ifdef USE_MMIO
-               memaddr,
+                    memaddr,
 #else
-               (long)ioaddr,
+                    (long)ioaddr,
 #endif
-               dev->dev_addr, pdev->irq);
+                    dev->dev_addr, pdev->irq);
        pci_set_drvdata(pdev, dev);
@@ -896,11 +900,11 @@ static int __devinit rhine_init_one(struct pci_dev *pdev,
                mdio_write(dev, phy_id, MII_BMCR, mii_cmd);
                if (mii_status != 0xffff && mii_status != 0x0000) {
                        rp->mii_if.advertising = mdio_read(dev, phy_id, 4);
-                        printk(KERN_INFO "%s: MII PHY found at address "
+                        netdev_info(dev,
-                               "%d, status 0x%4.4x advertising %4.4x "
+                                    "MII PHY found at address %d, status 0x%04x advertising %04x Link %04x\n",
-                               "Link %4.4x.\n", dev->name, phy_id,
+                                    phy_id,
-                               mii_status, rp->mii_if.advertising,
+                                    mii_status, rp->mii_if.advertising,
-                               mdio_read(dev, phy_id, 5));
+                                    mdio_read(dev, phy_id, 5));
                        /* set IFF_RUNNING */
                        if (mii_status & BMSR_LSTATUS)
@@ -912,8 +916,7 @@ static int __devinit rhine_init_one(struct pci_dev *pdev,
        }
        rp->mii_if.phy_id = phy_id;
        if (debug > 1 && avoid_D3)
-                printk(KERN_INFO "%s: No D3 power state at shutdown.\n",
+                netdev_info(dev, "No D3 power state at shutdown\n");
-                       dev->name);
        return 0;
@@ -938,7 +941,7 @@ static int alloc_ring(struct net_device* dev)
                                    TX_RING_SIZE * sizeof(struct tx_desc),
                                    &ring_dma);
        if (!ring) {
-                printk(KERN_ERR "Could not allocate DMA memory.\n");
+                netdev_err(dev, "Could not allocate DMA memory\n");
                return -ENOMEM;
        }
        if (rp->quirks & rqRhineI) {
@@ -1098,8 +1101,8 @@ static void rhine_check_media(struct net_device *dev, unsigned int init_media)
            iowrite8(ioread8(ioaddr + ChipCmd1) & ~Cmd1FDuplex,
                   ioaddr + ChipCmd1);
        if (debug > 1)
-                printk(KERN_INFO "%s: force_media %d, carrier %d\n", dev->name,
+                netdev_info(dev, "force_media %d, carrier %d\n",
-                        rp->mii_if.force_media, netif_carrier_ok(dev));
+                            rp->mii_if.force_media, netif_carrier_ok(dev));
 }
 /* Called after status of force_media possibly changed */
@@ -1113,9 +1116,8 @@ static void rhine_set_carrier(struct mii_if_info *mii)
        else    /* Let MMI library update carrier status */
                rhine_check_media(mii->dev, 0);
        if (debug > 1)
-                printk(KERN_INFO "%s: force_media %d, carrier %d\n",
+                netdev_info(mii->dev, "force_media %d, carrier %d\n",
-                       mii->dev->name, mii->force_media,
+                            mii->force_media, netif_carrier_ok(mii->dev));
-                       netif_carrier_ok(mii->dev));
 }
 /**
@@ -1402,8 +1404,7 @@ static int rhine_open(struct net_device *dev)
                return rc;
        if (debug > 1)
-                printk(KERN_DEBUG "%s: rhine_open() irq %d.\n",
+                netdev_dbg(dev, "%s() irq %d\n", __func__, rp->pdev->irq);
-                       dev->name, rp->pdev->irq);
        rc = alloc_ring(dev);
        if (rc) {
@@ -1415,10 +1416,9 @@ static int rhine_open(struct net_device *dev)
        rhine_chip_reset(dev);
        init_registers(dev);
        if (debug > 2)
-                printk(KERN_DEBUG "%s: Done rhine_open(), status %4.4x "
+                netdev_dbg(dev, "%s() Done - status %04x MII status: %04x\n",
-                       "MII status: %4.4x.\n",
+                           __func__, ioread16(ioaddr + ChipCmd),
-                       dev->name, ioread16(ioaddr + ChipCmd),
+                           mdio_read(dev, rp->mii_if.phy_id, MII_BMSR));
-                       mdio_read(dev, rp->mii_if.phy_id, MII_BMSR));
        netif_start_queue(dev);
@@ -1461,10 +1461,9 @@ static void rhine_tx_timeout(struct net_device *dev)
        struct rhine_private *rp = netdev_priv(dev);
        void __iomem *ioaddr = rp->base;
-        printk(KERN_WARNING "%s: Transmit timed out, status %4.4x, PHY status "
+        netdev_warn(dev, "Transmit timed out, status %04x, PHY status %04x, resetting...\n",
-               "%4.4x, resetting...\n",
+                    ioread16(ioaddr + IntrStatus),
-               dev->name, ioread16(ioaddr + IntrStatus),
+                    mdio_read(dev, rp->mii_if.phy_id, MII_BMSR));
-               mdio_read(dev, rp->mii_if.phy_id, MII_BMSR));
        schedule_work(&rp->reset_task);
 }
@@ -1551,8 +1550,8 @@ static netdev_tx_t rhine_start_tx(struct sk_buff *skb,
        spin_unlock_irqrestore(&rp->lock, flags);
        if (debug > 4) {
-                printk(KERN_DEBUG "%s: Transmit frame #%d queued in slot %d.\n",
+                netdev_dbg(dev, "Transmit frame #%d queued in slot %d\n",
-                       dev->name, rp->cur_tx-1, entry);
+                           rp->cur_tx-1, entry);
        }
        return NETDEV_TX_OK;
 }
@@ -1578,8 +1577,8 @@ static irqreturn_t rhine_interrupt(int irq, void *dev_instance)
                IOSYNC;
                if (debug > 4)
-                        printk(KERN_DEBUG "%s: Interrupt, status %8.8x.\n",
+                        netdev_dbg(dev, "Interrupt, status %08x\n",
-                               dev->name, intr_status);
+                                   intr_status);
                if (intr_status & (IntrRxDone | IntrRxErr | IntrRxDropped |
                                   IntrRxWakeUp | IntrRxEmpty | IntrRxNoBuf)) {
@@ -1597,9 +1596,9 @@ static irqreturn_t rhine_interrupt(int irq, void *dev_instance)
                                RHINE_WAIT_FOR(!(ioread8(ioaddr+ChipCmd) & CmdTxOn));
                                if (debug > 2 &&
                                    ioread8(ioaddr+ChipCmd) & CmdTxOn)
-                                        printk(KERN_WARNING "%s: "
+                                        netdev_warn(dev,
-                                               "rhine_interrupt() Tx engine "
+                                                    "%s: Tx engine still on\n",
-                                               "still on.\n", dev->name);
+                                                    __func__);
                        }
                        rhine_tx(dev);
                }
@@ -1611,16 +1610,15 @@ static irqreturn_t rhine_interrupt(int irq, void *dev_instance)
                        rhine_error(dev, intr_status);
                if (--boguscnt < 0) {
-                        printk(KERN_WARNING "%s: Too much work at interrupt, "
+                        netdev_warn(dev, "Too much work at interrupt, status=%#08x\n",
-                               "status=%#8.8x.\n",
+                                    intr_status);
-                               dev->name, intr_status);
                        break;
                }
        }
        if (debug > 3)
-                printk(KERN_DEBUG "%s: exiting interrupt, status=%8.8x.\n",
+                netdev_dbg(dev, "exiting interrupt, status=%08x\n",
-                       dev->name, ioread16(ioaddr + IntrStatus));
+                           ioread16(ioaddr + IntrStatus));
        return IRQ_RETVAL(handled);
 }
@@ -1637,15 +1635,14 @@ static void rhine_tx(struct net_device *dev)
        while (rp->dirty_tx != rp->cur_tx) {
                txstatus = le32_to_cpu(rp->tx_ring[entry].tx_status);
                if (debug > 6)
-                        printk(KERN_DEBUG "Tx scavenge %d status %8.8x.\n",
+                        netdev_dbg(dev, "Tx scavenge %d status %08x\n",
-                               entry, txstatus);
+                                   entry, txstatus);
                if (txstatus & DescOwn)
                        break;
                if (txstatus & 0x8000) {
                        if (debug > 1)
-                                printk(KERN_DEBUG "%s: Transmit error, "
+                                netdev_dbg(dev, "Transmit error, Tx status %08x\n",
-                                       "Tx status %8.8x.\n",
+                                           txstatus);
-                                       dev->name, txstatus);
                        dev->stats.tx_errors++;
                        if (txstatus & 0x0400)
                                dev->stats.tx_carrier_errors++;
@@ -1668,9 +1665,9 @@ static void rhine_tx(struct net_device *dev)
                        else
                                dev->stats.collisions += txstatus & 0x0F;
                        if (debug > 6)
-                                printk(KERN_DEBUG "collisions: %1.1x:%1.1x\n",
+                                netdev_dbg(dev, "collisions: %1.1x:%1.1x\n",
-                                       (txstatus >> 3) & 0xF,
+                                           (txstatus >> 3) & 0xF,
-                                       txstatus & 0xF);
+                                           txstatus & 0xF);
                        dev->stats.tx_bytes += rp->tx_skbuff[entry]->len;
                        dev->stats.tx_packets++;
                }
@@ -1703,7 +1700,7 @@ static void rhine_tx(struct net_device *dev)
 static inline u16 rhine_get_vlan_tci(struct sk_buff *skb, int data_size)
 {
        u8 *trailer = (u8 *)skb->data + ((data_size + 3) & ~3) + 2;
-        return ntohs(*(u16 *)trailer);
+        return be16_to_cpup((__be16 *)trailer);
 }
 /* Process up to limit frames from receive ring */
@@ -1714,9 +1711,9 @@ static int rhine_rx(struct net_device *dev, int limit)
        int entry = rp->cur_rx % RX_RING_SIZE;
        if (debug > 4) {
-                printk(KERN_DEBUG "%s: rhine_rx(), entry %d status %8.8x.\n",
+                netdev_dbg(dev, "%s(), entry %d status %08x\n",
-                       dev->name, entry,
+                           __func__, entry,
-                       le32_to_cpu(rp->rx_head_desc->rx_status));
+                           le32_to_cpu(rp->rx_head_desc->rx_status));
        }
        /* If EOP is set on the next entry, it's a new packet. Send it up. */
@@ -1730,26 +1727,26 @@ static int rhine_rx(struct net_device *dev, int limit)
                        break;
                if (debug > 4)
-                        printk(KERN_DEBUG "rhine_rx() status is %8.8x.\n",
+                        netdev_dbg(dev, "%s() status is %08x\n",
-                               desc_status);
+                                   __func__, desc_status);
                if ((desc_status & (RxWholePkt | RxErr)) != RxWholePkt) {
                        if ((desc_status & RxWholePkt) != RxWholePkt) {
-                                printk(KERN_WARNING "%s: Oversized Ethernet "
+                                netdev_warn(dev,
-                                       "frame spanned multiple buffers, entry "
+        "Oversized Ethernet frame spanned multiple buffers, "
-                                       "%#x length %d status %8.8x!\n",
+        "entry %#x length %d status %08x!\n",
-                                       dev->name, entry, data_size,
+                                            entry, data_size,
-                                       desc_status);
+                                            desc_status);
-                                printk(KERN_WARNING "%s: Oversized Ethernet "
+                                netdev_warn(dev,
-                                       "frame %p vs %p.\n", dev->name,
+                                            "Oversized Ethernet frame %p vs %p\n",
-                                       rp->rx_head_desc, &rp->rx_ring[entry]);
+                                            rp->rx_head_desc,
+                                            &rp->rx_ring[entry]);
                                dev->stats.rx_length_errors++;
                        } else if (desc_status & RxErr) {
                                /* There was a error. */
                                if (debug > 2)
-                                        printk(KERN_DEBUG "rhine_rx() Rx "
+                                        netdev_dbg(dev, "%s() Rx error was %08x\n",
-                                               "error was %8.8x.\n",
+                                                   __func__, desc_status);
-                                               desc_status);
                                dev->stats.rx_errors++;
                                if (desc_status & 0x0030)
                                        dev->stats.rx_length_errors++;
@@ -1791,9 +1788,7 @@ static int rhine_rx(struct net_device *dev, int limit)
                        } else {
                                skb = rp->rx_skbuff[entry];
                                if (skb == NULL) {
-                                        printk(KERN_ERR "%s: Inconsistent Rx "
+                                        netdev_err(dev, "Inconsistent Rx descriptor chain\n");
-                                               "descriptor chain.\n",
-                                               dev->name);
                                        break;
                                }
                                rp->rx_skbuff[entry] = NULL;
@@ -1886,9 +1881,8 @@ static void rhine_restart_tx(struct net_device *dev) {
        else {
                /* This should never happen */
                if (debug > 1)
-                        printk(KERN_WARNING "%s: rhine_restart_tx() "
+                        netdev_warn(dev, "%s() Another error occurred %08x\n",
-                               "Another error occurred %8.8x.\n",
+                                   __func__, intr_status);
-                               dev->name, intr_status);
        }
 }
@@ -1909,21 +1903,19 @@ static void rhine_error(struct net_device *dev, int intr_status)
        }
        if (intr_status & IntrTxAborted) {
                if (debug > 1)
-                        printk(KERN_INFO "%s: Abort %8.8x, frame dropped.\n",
+                        netdev_info(dev, "Abort %08x, frame dropped\n",
-                               dev->name, intr_status);
+                                    intr_status);
        }
        if (intr_status & IntrTxUnderrun) {
                if (rp->tx_thresh < 0xE0)
                        BYTE_REG_BITS_SET((rp->tx_thresh += 0x20), 0x80, ioaddr + TxConfig);
                if (debug > 1)
-                        printk(KERN_INFO "%s: Transmitter underrun, Tx "
+                        netdev_info(dev, "Transmitter underrun, Tx threshold now %02x\n",
-                               "threshold now %2.2x.\n",
+                                    rp->tx_thresh);
-                               dev->name, rp->tx_thresh);
        }
        if (intr_status & IntrTxDescRace) {
                if (debug > 2)
-                        printk(KERN_INFO "%s: Tx descriptor write-back race.\n",
+                        netdev_info(dev, "Tx descriptor write-back race\n");
-                               dev->name);
        }
        if ((intr_status & IntrTxError) &&
            (intr_status & (IntrTxAborted |
@@ -1932,9 +1924,8 @@ static void rhine_error(struct net_device *dev, int intr_status)
                        BYTE_REG_BITS_SET((rp->tx_thresh += 0x20), 0x80, ioaddr + TxConfig);
                }
                if (debug > 1)
-                        printk(KERN_INFO "%s: Unspecified error. Tx "
+                        netdev_info(dev, "Unspecified error. Tx threshold now %02x\n",
-                               "threshold now %2.2x.\n",
+                                    rp->tx_thresh);
-                               dev->name, rp->tx_thresh);
        }
        if (intr_status & (IntrTxAborted | IntrTxUnderrun | IntrTxDescRace |
                           IntrTxError))
@@ -1944,8 +1935,8 @@ static void rhine_error(struct net_device *dev, int intr_status)
                            IntrTxError | IntrTxAborted | IntrNormalSummary |
                            IntrTxDescRace)) {
                if (debug > 1)
-                        printk(KERN_ERR "%s: Something Wicked happened! "
+                        netdev_err(dev, "Something Wicked happened! %08x\n",
-                               "%8.8x.\n", dev->name, intr_status);
+                                   intr_status);
        }
        spin_unlock(&rp->lock);
@@ -2145,9 +2136,8 @@ static int rhine_close(struct net_device *dev)
        spin_lock_irq(&rp->lock);
        if (debug > 1)
-                printk(KERN_DEBUG "%s: Shutting down ethercard, "
+                netdev_dbg(dev, "Shutting down ethercard, status was %04x\n",
-                       "status was %4.4x.\n",
+                           ioread16(ioaddr + ChipCmd));
-                       dev->name, ioread16(ioaddr + ChipCmd));
        /* Switch to loopback mode to avoid hardware races. */
        iowrite8(rp->tx_thresh | 0x02, ioaddr + TxConfig);
@@ -2265,12 +2255,12 @@ static int rhine_resume(struct pci_dev *pdev)
                return 0;
        if (request_irq(dev->irq, rhine_interrupt, IRQF_SHARED, dev->name, dev))
-                printk(KERN_ERR "via-rhine %s: request_irq failed\n", dev->name);
+                netdev_err(dev, "request_irq failed\n");
        ret = pci_set_power_state(pdev, PCI_D0);
        if (debug > 1)
-                printk(KERN_INFO "%s: Entering power state D0 %s (%d).\n",
+                netdev_info(dev, "Entering power state D0 %s (%d)\n",
-                        dev->name, ret ? "failed" : "succeeded", ret);
+                            ret ? "failed" : "succeeded", ret);
        pci_restore_state(pdev);
@@ -2326,17 +2316,15 @@ static int __init rhine_init(void)
 {
 /* when a module, this is printed whether or not devices are found in probe */
 #ifdef MODULE
-        printk(version);
+        pr_info("%s\n", version);
 #endif
        if (dmi_check_system(rhine_dmi_table)) {
                /* these BIOSes fail at PXE boot if chip is in D3 */
                avoid_D3 = 1;
-                printk(KERN_WARNING "%s: Broken BIOS detected, avoid_D3 "
+                pr_warn("Broken BIOS detected, avoid_D3 enabled\n");
-                                    "enabled.\n",
-                       DRV_NAME);
        }
        else if (avoid_D3)
-                printk(KERN_INFO "%s: avoid_D3 set.\n", DRV_NAME);
+                pr_info("avoid_D3 set\n");
        return pci_register_driver(&rhine_driver);
 }
diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index 4fe051753842..06daa9d6fee8 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -2600,8 +2600,7 @@ static netdev_tx_t velocity_xmit(struct sk_buff *skb,
        /*
         *      Handle hardware checksum
         */
-        if ((dev->features & NETIF_F_IP_CSUM) &&
+        if (skb->ip_summed == CHECKSUM_PARTIAL) {
-            (skb->ip_summed == CHECKSUM_PARTIAL)) {
                const struct iphdr *ip = ip_hdr(skb);
                if (ip->protocol == IPPROTO_TCP)
                        td_ptr->tdesc1.TCR |= TCR0_TCPCK;
@@ -2841,6 +2840,7 @@ static int __devinit velocity_found1(struct pci_dev *pdev, const struct pci_devi
        dev->ethtool_ops = &velocity_ethtool_ops;
        netif_napi_add(dev, &vptr->napi, velocity_poll, VELOCITY_NAPI_WEIGHT);
+        dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_HW_VLAN_TX;
        dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_FILTER |
                NETIF_F_HW_VLAN_RX | NETIF_F_IP_CSUM;
@@ -3182,7 +3182,8 @@ static void velocity_ethtool_down(struct net_device *dev)
                pci_set_power_state(vptr->pdev, PCI_D3hot);
 }
-static int velocity_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
+static int velocity_get_settings(struct net_device *dev,
+                                 struct ethtool_cmd *cmd)
 {
        struct velocity_info *vptr = netdev_priv(dev);
        struct mac_regs __iomem *regs = vptr->mac_regs;
@@ -3228,12 +3229,14 @@ static int velocity_get_settings(struct net_device *dev, struct ethtool_cmd *cmd
                        break;
                }
        }
        if (status & VELOCITY_SPEED_1000)
-                cmd->speed = SPEED_1000;
+                ethtool_cmd_speed_set(cmd, SPEED_1000);
        else if (status & VELOCITY_SPEED_100)
-                cmd->speed = SPEED_100;
+                ethtool_cmd_speed_set(cmd, SPEED_100);
        else
-                cmd->speed = SPEED_10;
+                ethtool_cmd_speed_set(cmd, SPEED_10);
        cmd->autoneg = (status & VELOCITY_AUTONEG_ENABLE) ? AUTONEG_ENABLE : AUTONEG_DISABLE;
        cmd->port = PORT_TP;
        cmd->transceiver = XCVR_INTERNAL;
@@ -3247,9 +3250,11 @@ static int velocity_get_settings(struct net_device *dev, struct ethtool_cmd *cmd
        return 0;
 }
-static int velocity_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
+static int velocity_set_settings(struct net_device *dev,
+                                 struct ethtool_cmd *cmd)
 {
        struct velocity_info *vptr = netdev_priv(dev);
+        u32 speed = ethtool_cmd_speed(cmd);
        u32 curr_status;
        u32 new_status = 0;
        int ret = 0;
@@ -3258,9 +3263,9 @@ static int velocity_set_settings(struct net_device *dev, struct ethtool_cmd *cmd
        curr_status &= (~VELOCITY_LINK_FAIL);
        new_status |= ((cmd->autoneg) ? VELOCITY_AUTONEG_ENABLE : 0);
-        new_status |= ((cmd->speed == SPEED_1000) ? VELOCITY_SPEED_1000 : 0);
+        new_status |= ((speed == SPEED_1000) ? VELOCITY_SPEED_1000 : 0);
-        new_status |= ((cmd->speed == SPEED_100) ? VELOCITY_SPEED_100 : 0);
+        new_status |= ((speed == SPEED_100) ? VELOCITY_SPEED_100 : 0);
-        new_status |= ((cmd->speed == SPEED_10) ? VELOCITY_SPEED_10 : 0);
+        new_status |= ((speed == SPEED_10) ? VELOCITY_SPEED_10 : 0);
        new_status |= ((cmd->duplex == DUPLEX_FULL) ? VELOCITY_DUPLEX_FULL : 0);
        if ((new_status & VELOCITY_AUTONEG_ENABLE) &&
@@ -3457,13 +3462,10 @@ static const struct ethtool_ops velocity_ethtool_ops = {
        .get_settings   =       velocity_get_settings,
        .set_settings   =       velocity_set_settings,
        .get_drvinfo    =       velocity_get_drvinfo,
-        .set_tx_csum    =       ethtool_op_set_tx_csum,
-        .get_tx_csum    =       ethtool_op_get_tx_csum,
        .get_wol        =       velocity_ethtool_get_wol,
        .set_wol        =       velocity_ethtool_set_wol,
        .get_msglevel   =       velocity_get_msglevel,
        .set_msglevel   =       velocity_set_msglevel,
-        .set_sg         =       ethtool_op_set_sg,
        .get_link       =       velocity_get_link,
        .get_coalesce   =       velocity_get_coalesce,
        .set_coalesce   =       velocity_set_coalesce,
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 82dba5aaf423..0cb0b0632672 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -710,17 +710,6 @@ static int virtnet_close(struct net_device *dev)
        return 0;
 }
-static int virtnet_set_tx_csum(struct net_device *dev, u32 data)
-{
-        struct virtnet_info *vi = netdev_priv(dev);
-        struct virtio_device *vdev = vi->vdev;
-        if (data && !virtio_has_feature(vdev, VIRTIO_NET_F_CSUM))
-                return -ENOSYS;
-        return ethtool_op_set_tx_hw_csum(dev, data);
-}
 static void virtnet_set_rx_mode(struct net_device *dev)
 {
        struct virtnet_info *vi = netdev_priv(dev);
@@ -822,10 +811,6 @@ static void virtnet_vlan_rx_kill_vid(struct net_device *dev, u16 vid)
 }
 static const struct ethtool_ops virtnet_ethtool_ops = {
-        .set_tx_csum = virtnet_set_tx_csum,
-        .set_sg = ethtool_op_set_sg,
-        .set_tso = ethtool_op_set_tso,
-        .set_ufo = ethtool_op_set_ufo,
        .get_link = ethtool_op_get_link,
 };
@@ -912,22 +897,29 @@ static int virtnet_probe(struct virtio_device *vdev)
        SET_NETDEV_DEV(dev, &vdev->dev);
        /* Do we support "hardware" checksums? */
-        if (csum && virtio_has_feature(vdev, VIRTIO_NET_F_CSUM)) {
+        if (virtio_has_feature(vdev, VIRTIO_NET_F_CSUM)) {
                /* This opens up the world of extra features. */
-                dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;
+                dev->hw_features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;
-                if (gso && virtio_has_feature(vdev, VIRTIO_NET_F_GSO)) {
+                if (csum)
-                        dev->features |= NETIF_F_TSO | NETIF_F_UFO
+                        dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;
+                if (virtio_has_feature(vdev, VIRTIO_NET_F_GSO)) {
+                        dev->hw_features |= NETIF_F_TSO | NETIF_F_UFO
                                | NETIF_F_TSO_ECN | NETIF_F_TSO6;
                }
                /* Individual feature bits: what can host handle? */
-                if (gso && virtio_has_feature(vdev, VIRTIO_NET_F_HOST_TSO4))
+                if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_TSO4))
-                        dev->features |= NETIF_F_TSO;
+                        dev->hw_features |= NETIF_F_TSO;
-                if (gso && virtio_has_feature(vdev, VIRTIO_NET_F_HOST_TSO6))
+                if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_TSO6))
-                        dev->features |= NETIF_F_TSO6;
+                        dev->hw_features |= NETIF_F_TSO6;
-                if (gso && virtio_has_feature(vdev, VIRTIO_NET_F_HOST_ECN))
+                if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_ECN))
-                        dev->features |= NETIF_F_TSO_ECN;
+                        dev->hw_features |= NETIF_F_TSO_ECN;
-                if (gso && virtio_has_feature(vdev, VIRTIO_NET_F_HOST_UFO))
+                if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_UFO))
-                        dev->features |= NETIF_F_UFO;
+                        dev->hw_features |= NETIF_F_UFO;
+                if (gso)
+                        dev->features |= dev->hw_features & (NETIF_F_ALL_TSO|NETIF_F_UFO);
+                /* (!csum && gso) case will be fixed by register_netdev() */
        }
        /* Configuration may specify what MAC to use.  Otherwise random. */
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index c16ed961153a..fa6e2ac7475a 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1083,7 +1083,7 @@ vmxnet3_rx_csum(struct vmxnet3_adapter *adapter,
                struct sk_buff *skb,
                union Vmxnet3_GenericDesc *gdesc)
 {
-        if (!gdesc->rcd.cnc && adapter->rxcsum) {
+        if (!gdesc->rcd.cnc && adapter->netdev->features & NETIF_F_RXCSUM) {
                /* typical case: TCP/UDP over IP and both csums are correct */
                if ((le32_to_cpu(gdesc->dword[3]) & VMXNET3_RCD_CSUM_OK) ==
                                                        VMXNET3_RCD_CSUM_OK) {
@@ -2082,10 +2082,10 @@ vmxnet3_setup_driver_shared(struct vmxnet3_adapter *adapter)
        devRead->misc.ddLen = cpu_to_le32(sizeof(struct vmxnet3_adapter));
        /* set up feature flags */
-        if (adapter->rxcsum)
+        if (adapter->netdev->features & NETIF_F_RXCSUM)
                devRead->misc.uptFeatures |= UPT1_F_RXCSUM;
-        if (adapter->lro) {
+        if (adapter->netdev->features & NETIF_F_LRO) {
                devRead->misc.uptFeatures |= UPT1_F_LRO;
                devRead->misc.maxNumRxSG = cpu_to_le16(1 + MAX_SKB_FRAGS);
        }
@@ -2594,9 +2594,6 @@ vmxnet3_change_mtu(struct net_device *netdev, int new_mtu)
        if (new_mtu < VMXNET3_MIN_MTU || new_mtu > VMXNET3_MAX_MTU)
                return -EINVAL;
-        if (new_mtu > 1500 && !adapter->jumbo_frame)
-                return -EINVAL;
        netdev->mtu = new_mtu;
        /*
@@ -2642,28 +2639,18 @@ vmxnet3_declare_features(struct vmxnet3_adapter *adapter, bool dma64)
 {
        struct net_device *netdev = adapter->netdev;
-        netdev->features = NETIF_F_SG |
+        netdev->hw_features = NETIF_F_SG | NETIF_F_RXCSUM |
-                NETIF_F_HW_CSUM |
+                NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_TX |
-                NETIF_F_HW_VLAN_TX |
+                NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_LRO;
-                NETIF_F_HW_VLAN_RX |
+        if (dma64)
-                NETIF_F_HW_VLAN_FILTER |
-                NETIF_F_TSO |
-                NETIF_F_TSO6 |
-                NETIF_F_LRO;
-        printk(KERN_INFO "features: sg csum vlan jf tso tsoIPv6 lro");
-        adapter->rxcsum = true;
-        adapter->jumbo_frame = true;
-        adapter->lro = true;
-        if (dma64) {
                netdev->features |= NETIF_F_HIGHDMA;
-                printk(" highDMA");
+        netdev->vlan_features = netdev->hw_features & ~NETIF_F_HW_VLAN_TX;
-        }
+        netdev->features = netdev->hw_features |
+                NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER;
-        netdev->vlan_features = netdev->features;
+        netdev_info(adapter->netdev,
-        printk("\n");
+                "features: sg csum vlan jf tso tsoIPv6 lro%s\n",
+                dma64 ? " highDMA" : "");
 }
@@ -2876,6 +2863,7 @@ vmxnet3_probe_device(struct pci_dev *pdev,
                .ndo_start_xmit = vmxnet3_xmit_frame,
                .ndo_set_mac_address = vmxnet3_set_mac_addr,
                .ndo_change_mtu = vmxnet3_change_mtu,
+                .ndo_set_features = vmxnet3_set_features,
                .ndo_get_stats = vmxnet3_get_stats,
                .ndo_tx_timeout = vmxnet3_tx_timeout,
                .ndo_set_multicast_list = vmxnet3_set_mc,
@@ -2896,6 +2884,9 @@ vmxnet3_probe_device(struct pci_dev *pdev,
        int num_tx_queues;
        int num_rx_queues;
+        if (!pci_msi_enabled())
+                enable_mq = 0;
 #ifdef VMXNET3_RSS
        if (enable_mq)
                num_rx_queues = min(VMXNET3_DEVICE_MAX_RX_QUEUES,
diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c
index 976467253d20..dc959fe27aa5 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
@@ -33,40 +33,6 @@ struct vmxnet3_stat_desc {
 };
-static u32
-vmxnet3_get_rx_csum(struct net_device *netdev)
-{
-        struct vmxnet3_adapter *adapter = netdev_priv(netdev);
-        return adapter->rxcsum;
-}
-static int
-vmxnet3_set_rx_csum(struct net_device *netdev, u32 val)
-{
-        struct vmxnet3_adapter *adapter = netdev_priv(netdev);
-        unsigned long flags;
-        if (adapter->rxcsum != val) {
-                adapter->rxcsum = val;
-                if (netif_running(netdev)) {
-                        if (val)
-                                adapter->shared->devRead.misc.uptFeatures |=
-                                UPT1_F_RXCSUM;
-                        else
-                                adapter->shared->devRead.misc.uptFeatures &=
-                                ~UPT1_F_RXCSUM;
-                        spin_lock_irqsave(&adapter->cmd_lock, flags);
-                        VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD,
-                                               VMXNET3_CMD_UPDATE_FEATURE);
-                        spin_unlock_irqrestore(&adapter->cmd_lock, flags);
-                }
-        }
-        return 0;
-}
 /* per tq stats maintained by the device */
 static const struct vmxnet3_stat_desc
 vmxnet3_tq_dev_stats[] = {
@@ -296,31 +262,28 @@ vmxnet3_get_strings(struct net_device *netdev, u32 stringset, u8 *buf)
        }
 }
-static int
+int vmxnet3_set_features(struct net_device *netdev, u32 features)
-vmxnet3_set_flags(struct net_device *netdev, u32 data)
 {
        struct vmxnet3_adapter *adapter = netdev_priv(netdev);
-        u8 lro_requested = (data & ETH_FLAG_LRO) == 0 ? 0 : 1;
-        u8 lro_present = (netdev->features & NETIF_F_LRO) == 0 ? 0 : 1;
        unsigned long flags;
+        u32 changed = features ^ netdev->features;
-        if (ethtool_invalid_flags(netdev, data, ETH_FLAG_LRO))
+        if (changed & (NETIF_F_RXCSUM|NETIF_F_LRO)) {
-                return -EINVAL;
+                if (features & NETIF_F_RXCSUM)
+                        adapter->shared->devRead.misc.uptFeatures |=
-        if (lro_requested ^ lro_present) {
+                        UPT1_F_RXCSUM;
-                /* toggle the LRO feature*/
+                else
-                netdev->features ^= NETIF_F_LRO;
+                        adapter->shared->devRead.misc.uptFeatures &=
+                        ~UPT1_F_RXCSUM;
-                /* Update private LRO flag */
-                adapter->lro = lro_requested;
                /* update harware LRO capability accordingly */
-                if (lro_requested)
+                if (features & NETIF_F_LRO)
                        adapter->shared->devRead.misc.uptFeatures |=
                                                        UPT1_F_LRO;
                else
                        adapter->shared->devRead.misc.uptFeatures &=
                                                        ~UPT1_F_LRO;
                spin_lock_irqsave(&adapter->cmd_lock, flags);
                VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD,
                                       VMXNET3_CMD_UPDATE_FEATURE);
@@ -462,10 +425,10 @@ vmxnet3_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
        ecmd->transceiver = XCVR_INTERNAL;
        if (adapter->link_speed) {
-                ecmd->speed = adapter->link_speed;
+                ethtool_cmd_speed_set(ecmd, adapter->link_speed);
                ecmd->duplex = DUPLEX_FULL;
        } else {
-                ecmd->speed = -1;
+                ethtool_cmd_speed_set(ecmd, -1);
                ecmd->duplex = -1;
        }
        return 0;
@@ -657,17 +620,7 @@ static struct ethtool_ops vmxnet3_ethtool_ops = {
        .get_wol           = vmxnet3_get_wol,
        .set_wol           = vmxnet3_set_wol,
        .get_link          = ethtool_op_get_link,
-        .get_rx_csum       = vmxnet3_get_rx_csum,
-        .set_rx_csum       = vmxnet3_set_rx_csum,
-        .get_tx_csum       = ethtool_op_get_tx_csum,
-        .set_tx_csum       = ethtool_op_set_tx_hw_csum,
-        .get_sg            = ethtool_op_get_sg,
-        .set_sg            = ethtool_op_set_sg,
-        .get_tso           = ethtool_op_get_tso,
-        .set_tso           = ethtool_op_set_tso,
        .get_strings       = vmxnet3_get_strings,
-        .get_flags         = ethtool_op_get_flags,
-        .set_flags         = vmxnet3_set_flags,
        .get_sset_count    = vmxnet3_get_sset_count,
        .get_ethtool_stats = vmxnet3_get_ethtool_stats,
        .get_ringparam     = vmxnet3_get_ringparam,
diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
index fb5d245ac878..f50d36fdf405 100644
--- a/drivers/net/vmxnet3/vmxnet3_int.h
+++ b/drivers/net/vmxnet3/vmxnet3_int.h
@@ -68,10 +68,10 @@
 /*
 * Version numbers
 */
-#define VMXNET3_DRIVER_VERSION_STRING   "1.0.25.0-k"
+#define VMXNET3_DRIVER_VERSION_STRING   "1.1.9.0-k"
 /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */
-#define VMXNET3_DRIVER_VERSION_NUM      0x01001900
+#define VMXNET3_DRIVER_VERSION_NUM      0x01010900
 #if defined(CONFIG_PCI_MSI)
        /* RSS only makes sense if MSI-X is supported. */
@@ -329,10 +329,6 @@ struct vmxnet3_adapter {
        u8                      __iomem *hw_addr0; /* for BAR 0 */
        u8                      __iomem *hw_addr1; /* for BAR 1 */
-        /* feature control */
-        bool                            rxcsum;
-        bool                            lro;
-        bool                            jumbo_frame;
 #ifdef VMXNET3_RSS
        struct UPT1_RSSConf             *rss_conf;
        bool                            rss;
@@ -404,6 +400,9 @@ void
 vmxnet3_rq_destroy_all(struct vmxnet3_adapter *adapter);
 int
+vmxnet3_set_features(struct net_device *netdev, u32 features);
+int
 vmxnet3_create_queues(struct vmxnet3_adapter *adapter,
                      u32 tx_ring_size, u32 rx_ring_size, u32 rx_ring2_size);
diff --git a/drivers/net/vxge/vxge-config.c b/drivers/net/vxge/vxge-config.c
index 401bebf59502..32763b2dd73f 100644
--- a/drivers/net/vxge/vxge-config.c
+++ b/drivers/net/vxge/vxge-config.c
@@ -159,16 +159,15 @@ vxge_hw_vpath_fw_api(struct __vxge_hw_virtualpath *vpath, u32 action,
                     u32 fw_memo, u32 offset, u64 *data0, u64 *data1,
                     u64 *steer_ctrl)
 {
-        struct vxge_hw_vpath_reg __iomem *vp_reg;
+        struct vxge_hw_vpath_reg __iomem *vp_reg = vpath->vp_reg;
        enum vxge_hw_status status;
        u64 val64;
-        u32 retry = 0, max_retry = 100;
+        u32 retry = 0, max_retry = 3;
-        vp_reg = vpath->vp_reg;
-        if (vpath->vp_open) {
+        spin_lock(&vpath->lock);
-                max_retry = 3;
+        if (!vpath->vp_open) {
-                spin_lock(&vpath->lock);
+                spin_unlock(&vpath->lock);
+                max_retry = 100;
        }
        writeq(*data0, &vp_reg->rts_access_steer_data0);
@@ -1000,7 +999,7 @@ exit:
 /**
 * vxge_hw_device_hw_info_get - Get the hw information
 * Returns the vpath mask that has the bits set for each vpath allocated
- * for the driver, FW version information and the first mac addresse for
+ * for the driver, FW version information, and the first mac address for
 * each vpath
 */
 enum vxge_hw_status __devinit
@@ -1064,9 +1063,10 @@ vxge_hw_device_hw_info_get(void __iomem *bar0,
                val64 = readq(&toc->toc_vpath_pointer[i]);
+                spin_lock_init(&vpath.lock);
                vpath.vp_reg = (struct vxge_hw_vpath_reg __iomem *)
                               (bar0 + val64);
-                vpath.vp_open = 0;
+                vpath.vp_open = VXGE_HW_VP_NOT_OPEN;
                status = __vxge_hw_vpath_pci_func_mode_get(&vpath, hw_info);
                if (status != VXGE_HW_OK)
@@ -1090,7 +1090,7 @@ vxge_hw_device_hw_info_get(void __iomem *bar0,
                val64 = readq(&toc->toc_vpath_pointer[i]);
                vpath.vp_reg = (struct vxge_hw_vpath_reg __iomem *)
                               (bar0 + val64);
-                vpath.vp_open = 0;
+                vpath.vp_open = VXGE_HW_VP_NOT_OPEN;
                status =  __vxge_hw_vpath_addr_get(&vpath,
                                hw_info->mac_addrs[i],
@@ -4646,7 +4646,27 @@ static void __vxge_hw_vp_terminate(struct __vxge_hw_device *hldev, u32 vp_id)
                vpath->hldev->tim_int_mask1, vpath->vp_id);
        hldev->stats.hw_dev_info_stats.vpath_info[vpath->vp_id] = NULL;
-        memset(vpath, 0, sizeof(struct __vxge_hw_virtualpath));
+        /* If the whole struct __vxge_hw_virtualpath is zeroed, nothing will
+         * work after the interface is brought down.
+         */
+        spin_lock(&vpath->lock);
+        vpath->vp_open = VXGE_HW_VP_NOT_OPEN;
+        spin_unlock(&vpath->lock);
+        vpath->vpmgmt_reg = NULL;
+        vpath->nofl_db = NULL;
+        vpath->max_mtu = 0;
+        vpath->vsport_number = 0;
+        vpath->max_kdfc_db = 0;
+        vpath->max_nofl_db = 0;
+        vpath->ringh = NULL;
+        vpath->fifoh = NULL;
+        memset(&vpath->vpath_handles, 0, sizeof(struct list_head));
+        vpath->stats_block = 0;
+        vpath->hw_stats = NULL;
+        vpath->hw_stats_sav = NULL;
+        vpath->sw_stats = NULL;
 exit:
        return;
 }
@@ -4670,7 +4690,7 @@ __vxge_hw_vp_initialize(struct __vxge_hw_device *hldev, u32 vp_id,
        vpath = &hldev->virtual_paths[vp_id];
-        spin_lock_init(&hldev->virtual_paths[vp_id].lock);
+        spin_lock_init(&vpath->lock);
        vpath->vp_id = vp_id;
        vpath->vp_open = VXGE_HW_VP_OPEN;
        vpath->hldev = hldev;
@@ -5019,10 +5039,6 @@ enum vxge_hw_status vxge_hw_vpath_close(struct __vxge_hw_vpath_handle *vp)
        __vxge_hw_vp_terminate(devh, vp_id);
-        spin_lock(&vpath->lock);
-        vpath->vp_open = VXGE_HW_VP_NOT_OPEN;
-        spin_unlock(&vpath->lock);
 vpath_close_exit:
        return status;
 }
diff --git a/drivers/net/vxge/vxge-config.h b/drivers/net/vxge/vxge-config.h
index 3c53aa732c9d..359b9b9f8041 100644
--- a/drivers/net/vxge/vxge-config.h
+++ b/drivers/net/vxge/vxge-config.h
@@ -412,44 +412,48 @@ struct vxge_hw_vp_config {
 * See also: struct vxge_hw_tim_intr_config{}.
 */
 struct vxge_hw_device_config {
-        u32                             dma_blockpool_initial;
+        u32                                     device_poll_millis;
-        u32                             dma_blockpool_max;
+#define VXGE_HW_MIN_DEVICE_POLL_MILLIS          1
-#define VXGE_HW_MIN_DMA_BLOCK_POOL_SIZE                 0
+#define VXGE_HW_MAX_DEVICE_POLL_MILLIS          100000
-#define VXGE_HW_INITIAL_DMA_BLOCK_POOL_SIZE             0
+#define VXGE_HW_DEF_DEVICE_POLL_MILLIS          1000
-#define VXGE_HW_INCR_DMA_BLOCK_POOL_SIZE                4
-#define VXGE_HW_MAX_DMA_BLOCK_POOL_SIZE                 4096
+        u32                                     dma_blockpool_initial;
+        u32                                     dma_blockpool_max;
-#define        VXGE_HW_MAX_PAYLOAD_SIZE_512             2
+#define VXGE_HW_MIN_DMA_BLOCK_POOL_SIZE         0
+#define VXGE_HW_INITIAL_DMA_BLOCK_POOL_SIZE     0
-        u32                             intr_mode;
+#define VXGE_HW_INCR_DMA_BLOCK_POOL_SIZE        4
-#define VXGE_HW_INTR_MODE_IRQLINE                       0
+#define VXGE_HW_MAX_DMA_BLOCK_POOL_SIZE         4096
-#define VXGE_HW_INTR_MODE_MSIX                          1
-#define VXGE_HW_INTR_MODE_MSIX_ONE_SHOT                 2
+#define VXGE_HW_MAX_PAYLOAD_SIZE_512            2
-#define VXGE_HW_INTR_MODE_DEF                           0
+        u32                                     intr_mode:2,
+#define VXGE_HW_INTR_MODE_IRQLINE               0
-        u32                             rth_en;
+#define VXGE_HW_INTR_MODE_MSIX                  1
-#define VXGE_HW_RTH_DISABLE                             0
+#define VXGE_HW_INTR_MODE_MSIX_ONE_SHOT         2
-#define VXGE_HW_RTH_ENABLE                              1
-#define VXGE_HW_RTH_DEFAULT                             0
+#define VXGE_HW_INTR_MODE_DEF                   0
-        u32                             rth_it_type;
+                                                rth_en:1,
-#define VXGE_HW_RTH_IT_TYPE_SOLO_IT                     0
+#define VXGE_HW_RTH_DISABLE                     0
-#define VXGE_HW_RTH_IT_TYPE_MULTI_IT                    1
+#define VXGE_HW_RTH_ENABLE                      1
-#define VXGE_HW_RTH_IT_TYPE_DEFAULT                     0
+#define VXGE_HW_RTH_DEFAULT                     0
-        u32                             rts_mac_en;
+                                                rth_it_type:1,
+#define VXGE_HW_RTH_IT_TYPE_SOLO_IT             0
+#define VXGE_HW_RTH_IT_TYPE_MULTI_IT            1
+#define VXGE_HW_RTH_IT_TYPE_DEFAULT             0
+                                                rts_mac_en:1,
 #define VXGE_HW_RTS_MAC_DISABLE                 0
 #define VXGE_HW_RTS_MAC_ENABLE                  1
 #define VXGE_HW_RTS_MAC_DEFAULT                 0
-        struct vxge_hw_vp_config        vp_config[VXGE_HW_MAX_VIRTUAL_PATHS];
+                                                hwts_en:1;
+#define VXGE_HW_HWTS_DISABLE                    0
-        u32                             device_poll_millis;
+#define VXGE_HW_HWTS_ENABLE                     1
-#define VXGE_HW_MIN_DEVICE_POLL_MILLIS                  1
+#define VXGE_HW_HWTS_DEFAULT                    1
-#define VXGE_HW_MAX_DEVICE_POLL_MILLIS                  100000
-#define VXGE_HW_DEF_DEVICE_POLL_MILLIS                  1000
+        struct vxge_hw_vp_config vp_config[VXGE_HW_MAX_VIRTUAL_PATHS];
 };
 /**
diff --git a/drivers/net/vxge/vxge-ethtool.c b/drivers/net/vxge/vxge-ethtool.c
index c5eb034107fd..92dd72d3f9de 100644
--- a/drivers/net/vxge/vxge-ethtool.c
+++ b/drivers/net/vxge/vxge-ethtool.c
@@ -33,7 +33,8 @@ static int vxge_ethtool_sset(struct net_device *dev, struct ethtool_cmd *info)
 {
        /* We currently only support 10Gb/FULL */
        if ((info->autoneg == AUTONEG_ENABLE) ||
-            (info->speed != SPEED_10000) || (info->duplex != DUPLEX_FULL))
+            (ethtool_cmd_speed(info) != SPEED_10000) ||
+            (info->duplex != DUPLEX_FULL))
                return -EINVAL;
        return 0;
@@ -58,10 +59,10 @@ static int vxge_ethtool_gset(struct net_device *dev, struct ethtool_cmd *info)
        info->transceiver = XCVR_EXTERNAL;
        if (netif_carrier_ok(dev)) {
-                info->speed = SPEED_10000;
+                ethtool_cmd_speed_set(info, SPEED_10000);
                info->duplex = DUPLEX_FULL;
        } else {
-                info->speed = -1;
+                ethtool_cmd_speed_set(info, -1);
                info->duplex = -1;
        }
@@ -134,22 +135,29 @@ static void vxge_ethtool_gregs(struct net_device *dev,
 /**
 * vxge_ethtool_idnic - To physically identify the nic on the system.
 * @dev : device pointer.
- * @id : pointer to the structure with identification parameters given by
+ * @state : requested LED state
- * ethtool.
 *
 * Used to physically identify the NIC on the system.
- * The Link LED will blink for a time specified by the user.
- * Return value:
 * 0 on success
 */
-static int vxge_ethtool_idnic(struct net_device *dev, u32 data)
+static int vxge_ethtool_idnic(struct net_device *dev,
+                              enum ethtool_phys_id_state state)
 {
        struct vxgedev *vdev = netdev_priv(dev);
        struct __vxge_hw_device *hldev = vdev->devh;
-        vxge_hw_device_flick_link_led(hldev, VXGE_FLICKER_ON);
+        switch (state) {
-        msleep_interruptible(data ? (data * HZ) : VXGE_MAX_FLICKER_TIME);
+        case ETHTOOL_ID_ACTIVE:
-        vxge_hw_device_flick_link_led(hldev, VXGE_FLICKER_OFF);
+                vxge_hw_device_flick_link_led(hldev, VXGE_FLICKER_ON);
+                break;
+        case ETHTOOL_ID_INACTIVE:
+                vxge_hw_device_flick_link_led(hldev, VXGE_FLICKER_OFF);
+                break;
+        default:
+                return -EINVAL;
+        }
        return 0;
 }
@@ -1064,35 +1072,6 @@ static int vxge_ethtool_get_regs_len(struct net_device *dev)
        return sizeof(struct vxge_hw_vpath_reg) * vdev->no_of_vpath;
 }
-static u32 vxge_get_rx_csum(struct net_device *dev)
-{
-        struct vxgedev *vdev = netdev_priv(dev);
-        return vdev->rx_csum;
-}
-static int vxge_set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct vxgedev *vdev = netdev_priv(dev);
-        if (data)
-                vdev->rx_csum = 1;
-        else
-                vdev->rx_csum = 0;
-        return 0;
-}
-static int vxge_ethtool_op_set_tso(struct net_device *dev, u32 data)
-{
-        if (data)
-                dev->features |= (NETIF_F_TSO | NETIF_F_TSO6);
-        else
-                dev->features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
-        return 0;
-}
 static int vxge_ethtool_get_sset_count(struct net_device *dev, int sset)
 {
        struct vxgedev *vdev = netdev_priv(dev);
@@ -1112,40 +1091,6 @@ static int vxge_ethtool_get_sset_count(struct net_device *dev, int sset)
        }
 }
-static int vxge_set_flags(struct net_device *dev, u32 data)
-{
-        struct vxgedev *vdev = netdev_priv(dev);
-        enum vxge_hw_status status;
-        if (ethtool_invalid_flags(dev, data, ETH_FLAG_RXHASH))
-                return -EINVAL;
-        if (!!(data & ETH_FLAG_RXHASH) == vdev->devh->config.rth_en)
-                return 0;
-        if (netif_running(dev) || (vdev->config.rth_steering == NO_STEERING))
-                return -EINVAL;
-        vdev->devh->config.rth_en = !!(data & ETH_FLAG_RXHASH);
-        /* Enabling RTH requires some of the logic in vxge_device_register and a
-         * vpath reset.  Due to these restrictions, only allow modification
-         * while the interface is down.
-         */
-        status = vxge_reset_all_vpaths(vdev);
-        if (status != VXGE_HW_OK) {
-                vdev->devh->config.rth_en = !vdev->devh->config.rth_en;
-                return -EFAULT;
-        }
-        if (vdev->devh->config.rth_en)
-                dev->features |= NETIF_F_RXHASH;
-        else
-                dev->features &= ~NETIF_F_RXHASH;
-        return 0;
-}
 static int vxge_fw_flash(struct net_device *dev, struct ethtool_flash *parms)
 {
        struct vxgedev *vdev = netdev_priv(dev);
@@ -1174,19 +1119,10 @@ static const struct ethtool_ops vxge_ethtool_ops = {
        .get_link               = ethtool_op_get_link,
        .get_pauseparam         = vxge_ethtool_getpause_data,
        .set_pauseparam         = vxge_ethtool_setpause_data,
-        .get_rx_csum            = vxge_get_rx_csum,
-        .set_rx_csum            = vxge_set_rx_csum,
-        .get_tx_csum            = ethtool_op_get_tx_csum,
-        .set_tx_csum            = ethtool_op_set_tx_ipv6_csum,
-        .get_sg                 = ethtool_op_get_sg,
-        .set_sg                 = ethtool_op_set_sg,
-        .get_tso                = ethtool_op_get_tso,
-        .set_tso                = vxge_ethtool_op_set_tso,
        .get_strings            = vxge_ethtool_get_strings,
-        .phys_id                = vxge_ethtool_idnic,
+        .set_phys_id            = vxge_ethtool_idnic,
        .get_sset_count         = vxge_ethtool_get_sset_count,
        .get_ethtool_stats      = vxge_get_ethtool_stats,
-        .set_flags              = vxge_set_flags,
        .flash_device           = vxge_fw_flash,
 };
diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
index aff68c1118d4..fc837cf6bd4d 100644
--- a/drivers/net/vxge/vxge-main.c
+++ b/drivers/net/vxge/vxge-main.c
@@ -304,22 +304,14 @@ vxge_rx_complete(struct vxge_ring *ring, struct sk_buff *skb, u16 vlan,
                "%s: %s:%d  skb protocol = %d",
                ring->ndev->name, __func__, __LINE__, skb->protocol);
-        if (ring->gro_enable) {
+        if (ring->vlgrp && ext_info->vlan &&
-                if (ring->vlgrp && ext_info->vlan &&
+                (ring->vlan_tag_strip ==
-                        (ring->vlan_tag_strip ==
+                        VXGE_HW_VPATH_RPA_STRIP_VLAN_TAG_ENABLE))
-                                VXGE_HW_VPATH_RPA_STRIP_VLAN_TAG_ENABLE))
+                vlan_gro_receive(ring->napi_p, ring->vlgrp,
-                        vlan_gro_receive(ring->napi_p, ring->vlgrp,
+                                ext_info->vlan, skb);
-                                        ext_info->vlan, skb);
+        else
-                else
+                napi_gro_receive(ring->napi_p, skb);
-                        napi_gro_receive(ring->napi_p, skb);
-        } else {
-                if (ring->vlgrp && vlan &&
-                        (ring->vlan_tag_strip ==
-                                VXGE_HW_VPATH_RPA_STRIP_VLAN_TAG_ENABLE))
-                        vlan_hwaccel_receive_skb(skb, ring->vlgrp, vlan);
-                else
-                        netif_receive_skb(skb);
-        }
        vxge_debug_entryexit(VXGE_TRACE,
                "%s: %s:%d Exiting...", ring->ndev->name, __func__, __LINE__);
 }
@@ -490,7 +482,7 @@ vxge_rx_1b_compl(struct __vxge_hw_ring *ringh, void *dtr,
                if ((ext_info.proto & VXGE_HW_FRAME_PROTO_TCP_OR_UDP) &&
                    !(ext_info.proto & VXGE_HW_FRAME_PROTO_IP_FRAG) &&
-                    ring->rx_csum && /* Offload Rx side CSUM */
+                    (dev->features & NETIF_F_RXCSUM) && /* Offload Rx side CSUM */
                    ext_info.l3_cksum == VXGE_HW_L3_CKSUM_OK &&
                    ext_info.l4_cksum == VXGE_HW_L4_CKSUM_OK)
                        skb->ip_summed = CHECKSUM_UNNECESSARY;
@@ -2094,11 +2086,9 @@ static int vxge_open_vpaths(struct vxgedev *vdev)
                                vdev->config.fifo_indicate_max_pkts;
                        vpath->fifo.tx_vector_no = 0;
                        vpath->ring.rx_vector_no = 0;
-                        vpath->ring.rx_csum = vdev->rx_csum;
                        vpath->ring.rx_hwts = vdev->rx_hwts;
                        vpath->is_open = 1;
                        vdev->vp_handles[i] = vpath->handle;
-                        vpath->ring.gro_enable = vdev->config.gro_enable;
                        vpath->ring.vlan_tag_strip = vdev->vlan_tag_strip;
                        vdev->stats.vpaths_open++;
                } else {
@@ -2670,6 +2660,40 @@ static void vxge_poll_vp_lockup(unsigned long data)
        mod_timer(&vdev->vp_lockup_timer, jiffies + HZ / 1000);
 }
+static u32 vxge_fix_features(struct net_device *dev, u32 features)
+{
+        u32 changed = dev->features ^ features;
+        /* Enabling RTH requires some of the logic in vxge_device_register and a
+         * vpath reset.  Due to these restrictions, only allow modification
+         * while the interface is down.
+         */
+        if ((changed & NETIF_F_RXHASH) && netif_running(dev))
+                features ^= NETIF_F_RXHASH;
+        return features;
+}
+static int vxge_set_features(struct net_device *dev, u32 features)
+{
+        struct vxgedev *vdev = netdev_priv(dev);
+        u32 changed = dev->features ^ features;
+        if (!(changed & NETIF_F_RXHASH))
+                return 0;
+        /* !netif_running() ensured by vxge_fix_features() */
+        vdev->devh->config.rth_en = !!(features & NETIF_F_RXHASH);
+        if (vxge_reset_all_vpaths(vdev) != VXGE_HW_OK) {
+                dev->features = features ^ NETIF_F_RXHASH;
+                vdev->devh->config.rth_en = !!(dev->features & NETIF_F_RXHASH);
+                return -EIO;
+        }
+        return 0;
+}
 /**
 * vxge_open
 * @dev: pointer to the device structure.
@@ -3112,8 +3136,7 @@ vxge_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *net_stats)
        return net_stats;
 }
-static enum vxge_hw_status vxge_timestamp_config(struct vxgedev *vdev,
+static enum vxge_hw_status vxge_timestamp_config(struct __vxge_hw_device *devh)
-                                                 int enable)
 {
        enum vxge_hw_status status;
        u64 val64;
@@ -3123,27 +3146,24 @@ static enum vxge_hw_status vxge_timestamp_config(struct vxgedev *vdev,
         * required for the driver to load (due to a hardware bug),
         * there is no need to do anything special here.
         */
-        if (enable)
+        val64 = VXGE_HW_XMAC_TIMESTAMP_EN |
-                val64 = VXGE_HW_XMAC_TIMESTAMP_EN |
+                VXGE_HW_XMAC_TIMESTAMP_USE_LINK_ID(0) |
-                        VXGE_HW_XMAC_TIMESTAMP_USE_LINK_ID(0) |
+                VXGE_HW_XMAC_TIMESTAMP_INTERVAL(0);
-                        VXGE_HW_XMAC_TIMESTAMP_INTERVAL(0);
-        else
-                val64 = 0;
-        status = vxge_hw_mgmt_reg_write(vdev->devh,
+        status = vxge_hw_mgmt_reg_write(devh,
                                        vxge_hw_mgmt_reg_type_mrpcim,
                                        0,
                                        offsetof(struct vxge_hw_mrpcim_reg,
                                                 xmac_timestamp),
                                        val64);
-        vxge_hw_device_flush_io(vdev->devh);
+        vxge_hw_device_flush_io(devh);
+        devh->config.hwts_en = VXGE_HW_HWTS_ENABLE;
        return status;
 }
 static int vxge_hwtstamp_ioctl(struct vxgedev *vdev, void __user *data)
 {
        struct hwtstamp_config config;
-        enum vxge_hw_status status;
        int i;
        if (copy_from_user(&config, data, sizeof(config)))
@@ -3164,10 +3184,6 @@ static int vxge_hwtstamp_ioctl(struct vxgedev *vdev, void __user *data)
        switch (config.rx_filter) {
        case HWTSTAMP_FILTER_NONE:
-                status = vxge_timestamp_config(vdev, 0);
-                if (status != VXGE_HW_OK)
-                        return -EFAULT;
                vdev->rx_hwts = 0;
                config.rx_filter = HWTSTAMP_FILTER_NONE;
                break;
@@ -3186,8 +3202,7 @@ static int vxge_hwtstamp_ioctl(struct vxgedev *vdev, void __user *data)
        case HWTSTAMP_FILTER_PTP_V2_EVENT:
        case HWTSTAMP_FILTER_PTP_V2_SYNC:
        case HWTSTAMP_FILTER_PTP_V2_DELAY_REQ:
-                status = vxge_timestamp_config(vdev, 1);
+                if (vdev->devh->config.hwts_en != VXGE_HW_HWTS_ENABLE)
-                if (status != VXGE_HW_OK)
                        return -EFAULT;
                vdev->rx_hwts = 1;
@@ -3378,6 +3393,8 @@ static const struct net_device_ops vxge_netdev_ops = {
        .ndo_do_ioctl           = vxge_ioctl,
        .ndo_set_mac_address    = vxge_set_mac_addr,
        .ndo_change_mtu         = vxge_change_mtu,
+        .ndo_fix_features       = vxge_fix_features,
+        .ndo_set_features       = vxge_set_features,
        .ndo_vlan_rx_register   = vxge_vlan_rx_register,
        .ndo_vlan_rx_kill_vid   = vxge_vlan_rx_kill_vid,
        .ndo_vlan_rx_add_vid    = vxge_vlan_rx_add_vid,
@@ -3424,14 +3441,21 @@ static int __devinit vxge_device_register(struct __vxge_hw_device *hldev,
        vdev->devh = hldev;
        vdev->pdev = hldev->pdev;
        memcpy(&vdev->config, config, sizeof(struct vxge_config));
-        vdev->rx_csum = 1;      /* Enable Rx CSUM by default. */
        vdev->rx_hwts = 0;
        vdev->titan1 = (vdev->pdev->revision == VXGE_HW_TITAN1_PCI_REVISION);
        SET_NETDEV_DEV(ndev, &vdev->pdev->dev);
-        ndev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |
+        ndev->hw_features = NETIF_F_RXCSUM | NETIF_F_SG |
-                                NETIF_F_HW_VLAN_FILTER;
+                NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
+                NETIF_F_TSO | NETIF_F_TSO6 |
+                NETIF_F_HW_VLAN_TX;
+        if (vdev->config.rth_steering != NO_STEERING)
+                ndev->hw_features |= NETIF_F_RXHASH;
+        ndev->features |= ndev->hw_features |
+                NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER;
        /*  Driver entry points */
        ndev->irq = vdev->pdev->irq;
        ndev->base_addr = (unsigned long) hldev->bar0;
@@ -3443,11 +3467,6 @@ static int __devinit vxge_device_register(struct __vxge_hw_device *hldev,
        vxge_initialize_ethtool_ops(ndev);
-        if (vdev->config.rth_steering != NO_STEERING) {
-                ndev->features |= NETIF_F_RXHASH;
-                hldev->config.rth_en = VXGE_HW_RTH_ENABLE;
-        }
        /* Allocate memory for vpath */
        vdev->vpaths = kzalloc((sizeof(struct vxge_vpath)) *
                                no_of_vpath, GFP_KERNEL);
@@ -3459,9 +3478,6 @@ static int __devinit vxge_device_register(struct __vxge_hw_device *hldev,
                goto _out1;
        }
-        ndev->features |= NETIF_F_SG;
-        ndev->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
        vxge_debug_init(vxge_hw_device_trace_level_get(hldev),
                "%s : checksuming enabled", __func__);
@@ -3471,11 +3487,6 @@ static int __devinit vxge_device_register(struct __vxge_hw_device *hldev,
                        "%s : using High DMA", __func__);
        }
-        ndev->features |= NETIF_F_TSO | NETIF_F_TSO6;
-        if (vdev->config.gro_enable)
-                ndev->features |= NETIF_F_GRO;
        ret = register_netdev(ndev);
        if (ret) {
                vxge_debug_init(vxge_hw_device_trace_level_get(hldev),
@@ -4005,15 +4016,6 @@ static void __devinit vxge_print_parm(struct vxgedev *vdev, u64 vpath_mask)
                vdev->config.tx_steering_type = 0;
        }
-        if (vdev->config.gro_enable) {
-                vxge_debug_init(VXGE_ERR,
-                        "%s: Generic receive offload enabled",
-                        vdev->ndev->name);
-        } else
-                vxge_debug_init(VXGE_TRACE,
-                        "%s: Generic receive offload disabled",
-                        vdev->ndev->name);
        if (vdev->config.addr_learn_en)
                vxge_debug_init(VXGE_TRACE,
                        "%s: MAC Address learning enabled", vdev->ndev->name);
@@ -4575,12 +4577,29 @@ vxge_probe(struct pci_dev *pdev, const struct pci_device_id *pre)
                goto _exit4;
        }
+        /* Always enable HWTS.  This will always cause the FCS to be invalid,
+         * due to the fact that HWTS is using the FCS as the location of the
+         * timestamp.  The HW FCS checking will still correctly determine if
+         * there is a valid checksum, and the FCS is being removed by the driver
+         * anyway.  So no fucntionality is being lost.  Since it is always
+         * enabled, we now simply use the ioctl call to set whether or not the
+         * driver should be paying attention to the HWTS.
+         */
+        if (is_privileged == VXGE_HW_OK) {
+                status = vxge_timestamp_config(hldev);
+                if (status != VXGE_HW_OK) {
+                        vxge_debug_init(VXGE_ERR, "%s: HWTS enable failed",
+                                        VXGE_DRIVER_NAME);
+                        ret = -EFAULT;
+                        goto _exit4;
+                }
+        }
        vxge_hw_device_debug_set(hldev, VXGE_ERR, VXGE_COMPONENT_LL);
        /* set private device info */
        pci_set_drvdata(pdev, hldev);
-        ll_config->gro_enable = VXGE_GRO_ALWAYS_AGGREGATE;
        ll_config->fifo_indicate_max_pkts = VXGE_FIFO_INDICATE_MAX_PKTS;
        ll_config->addr_learn_en = addr_learn_en;
        ll_config->rth_algorithm = RTH_ALG_JENKINS;
diff --git a/drivers/net/vxge/vxge-main.h b/drivers/net/vxge/vxge-main.h
index 40474f0da576..ed120aba443d 100644
--- a/drivers/net/vxge/vxge-main.h
+++ b/drivers/net/vxge/vxge-main.h
@@ -168,9 +168,6 @@ struct vxge_config {
 #define NEW_NAPI_WEIGHT 64
        int             napi_weight;
-#define VXGE_GRO_DONOT_AGGREGATE                0
-#define VXGE_GRO_ALWAYS_AGGREGATE               1
-        int             gro_enable;
        int             intr_type;
 #define INTA    0
 #define MSI     1
@@ -290,13 +287,11 @@ struct vxge_ring {
        unsigned long interrupt_count;
        unsigned long jiffies;
-        /* copy of the flag indicating whether rx_csum is to be used */
+        /* copy of the flag indicating whether rx_hwts is to be used */
-        u32 rx_csum:1,
+        u32 rx_hwts:1;
-            rx_hwts:1;
        int pkts_processed;
        int budget;
-        int gro_enable;
        struct napi_struct napi;
        struct napi_struct *napi_p;
@@ -369,9 +364,8 @@ struct vxgedev {
         */
        u16             all_multi_flg;
-         /* A flag indicating whether rx_csum is to be used or not. */
+        /* A flag indicating whether rx_hwts is to be used or not. */
-        u32     rx_csum:1,
+        u32     rx_hwts:1,
-                rx_hwts:1,
                titan1:1;
        struct vxge_msix_entry *vxge_entries;
diff --git a/drivers/net/vxge/vxge-traffic.h b/drivers/net/vxge/vxge-traffic.h
index 6c2fc0b72af5..4a518a3b131c 100644
--- a/drivers/net/vxge/vxge-traffic.h
+++ b/drivers/net/vxge/vxge-traffic.h
@@ -240,7 +240,7 @@ struct vxge_hw_tim_intr_config {
        u32                             btimer_val;
 #define VXGE_HW_MIN_TIM_BTIMER_VAL                              0
 #define VXGE_HW_MAX_TIM_BTIMER_VAL                              67108864
-#define VXGE_HW_USE_FLASH_DEFAULT                               0xffffffff
+#define VXGE_HW_USE_FLASH_DEFAULT                               (~0)
        u32                             timer_ac_en;
 #define VXGE_HW_TIM_TIMER_AC_ENABLE                             1
diff --git a/drivers/net/vxge/vxge-version.h b/drivers/net/vxge/vxge-version.h
index 581e21525e85..b9efa28bab3e 100644
--- a/drivers/net/vxge/vxge-version.h
+++ b/drivers/net/vxge/vxge-version.h
@@ -16,8 +16,8 @@
 #define VXGE_VERSION_MAJOR      "2"
 #define VXGE_VERSION_MINOR      "5"
-#define VXGE_VERSION_FIX        "2"
+#define VXGE_VERSION_FIX        "3"
-#define VXGE_VERSION_BUILD      "22259"
+#define VXGE_VERSION_BUILD      "22640"
 #define VXGE_VERSION_FOR        "k"
 #define VXGE_FW_VER(maj, min, bld) (((maj) << 16) + ((min) << 8) + (bld))
diff --git a/drivers/net/wan/dlci.c b/drivers/net/wan/dlci.c
index 1481a446fefb..21b104db5a90 100644
--- a/drivers/net/wan/dlci.c
+++ b/drivers/net/wan/dlci.c
@@ -341,10 +341,6 @@ static int dlci_add(struct dlci_add *dlci)
                }
        }
-        err = dev_alloc_name(master, master->name);
-        if (err < 0)
-                goto err2;
        *(short *)(master->dev_addr) = dlci->dlci;
        dlp = netdev_priv(master);
diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
index 0edb535bb2b5..fc433f28c047 100644
--- a/drivers/net/wan/hdlc_fr.c
+++ b/drivers/net/wan/hdlc_fr.c
@@ -1070,7 +1070,7 @@ static int fr_add_pvc(struct net_device *frad, unsigned int dlci, int type)
        hdlc_device *hdlc = dev_to_hdlc(frad);
        pvc_device *pvc;
        struct net_device *dev;
-        int result, used;
+        int used;
        if ((pvc = add_pvc(frad, dlci)) == NULL) {
                printk(KERN_WARNING "%s: Memory squeeze on fr_add_pvc()\n",
@@ -1106,13 +1106,6 @@ static int fr_add_pvc(struct net_device *frad, unsigned int dlci, int type)
        dev->tx_queue_len = 0;
        dev->ml_priv = pvc;
-        result = dev_alloc_name(dev, dev->name);
-        if (result < 0) {
-                free_netdev(dev);
-                delete_unused_pvcs(hdlc);
-                return result;
-        }
        if (register_netdevice(dev) != 0) {
                free_netdev(dev);
                delete_unused_pvcs(hdlc);
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 7f5bb913c8b9..eec463f99c09 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -338,10 +338,6 @@ static int lapbeth_new_device(struct net_device *dev)
        dev_hold(dev);
        lapbeth->ethdev = dev;
-        rc = dev_alloc_name(ndev, ndev->name);
-        if (rc < 0) 
-                goto fail;
        rc = -EIO;
        if (register_netdevice(ndev))
                goto fail;
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index 7aeb113cbb90..f354bd4e121e 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -284,5 +284,6 @@ source "drivers/net/wireless/rtlwifi/Kconfig"
 source "drivers/net/wireless/wl1251/Kconfig"
 source "drivers/net/wireless/wl12xx/Kconfig"
 source "drivers/net/wireless/zd1211rw/Kconfig"
+source "drivers/net/wireless/mwifiex/Kconfig"
 endif # WLAN
diff --git a/drivers/net/wireless/Makefile b/drivers/net/wireless/Makefile
index ddd3fb6ba1d3..7bba6a82b875 100644
--- a/drivers/net/wireless/Makefile
+++ b/drivers/net/wireless/Makefile
@@ -56,3 +56,5 @@ obj-$(CONFIG_WL12XX)	+= wl12xx/
 obj-$(CONFIG_WL12XX_PLATFORM_DATA)      += wl12xx/
 obj-$(CONFIG_IWM)       += iwmc3200wifi/
+obj-$(CONFIG_MWIFIEX)   += mwifiex/
diff --git a/drivers/net/wireless/ath/Kconfig b/drivers/net/wireless/ath/Kconfig
index 92c216263ee9..d1b23067619f 100644
--- a/drivers/net/wireless/ath/Kconfig
+++ b/drivers/net/wireless/ath/Kconfig
@@ -24,7 +24,6 @@ config ATH_DEBUG
 source "drivers/net/wireless/ath/ath5k/Kconfig"
 source "drivers/net/wireless/ath/ath9k/Kconfig"
-source "drivers/net/wireless/ath/ar9170/Kconfig"
 source "drivers/net/wireless/ath/carl9170/Kconfig"
 endif
diff --git a/drivers/net/wireless/ath/Makefile b/drivers/net/wireless/ath/Makefile
index 6d711ec97ec2..0e8f528c81c0 100644
--- a/drivers/net/wireless/ath/Makefile
+++ b/drivers/net/wireless/ath/Makefile
@@ -1,6 +1,5 @@
 obj-$(CONFIG_ATH5K)             += ath5k/
 obj-$(CONFIG_ATH9K_HW)          += ath9k/
-obj-$(CONFIG_AR9170_USB)        += ar9170/
 obj-$(CONFIG_CARL9170)          += carl9170/
 obj-$(CONFIG_ATH_COMMON)        += ath.o
diff --git a/drivers/net/wireless/ath/ar9170/Kconfig b/drivers/net/wireless/ath/ar9170/Kconfig
deleted file mode 100644
index 7b9672b0d090..000000000000
--- a/drivers/net/wireless/ath/ar9170/Kconfig
+++ /dev/null
@@ -1,20 +0,0 @@
-config AR9170_USB
-        tristate "Atheros AR9170 802.11n USB support (OBSOLETE)"
-        depends on USB && MAC80211
-        select FW_LOADER
-        help
-          This driver is going to get replaced by carl9170.
-          This is a driver for the Atheros "otus" 802.11n USB devices.
-          These devices require additional firmware (2 files).
-          For now, these files can be downloaded from here:
-          http://wireless.kernel.org/en/users/Drivers/ar9170
-          If you choose to build a module, it'll be called ar9170usb.
-config AR9170_LEDS
-        bool
-        depends on AR9170_USB && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = AR9170_USB)
-        default y
diff --git a/drivers/net/wireless/ath/ar9170/Makefile b/drivers/net/wireless/ath/ar9170/Makefile
deleted file mode 100644
index 8d91c7ee3215..000000000000
--- a/drivers/net/wireless/ath/ar9170/Makefile
+++ /dev/null
@@ -1,3 +0,0 @@
-ar9170usb-objs := usb.o main.o cmd.o mac.o phy.o led.o
-obj-$(CONFIG_AR9170_USB) += ar9170usb.o
diff --git a/drivers/net/wireless/ath/ar9170/ar9170.h b/drivers/net/wireless/ath/ar9170/ar9170.h
deleted file mode 100644
index 371e4ce49528..000000000000
--- a/drivers/net/wireless/ath/ar9170/ar9170.h
+++ /dev/null
@@ -1,258 +0,0 @@
-/*
- * Atheros AR9170 driver
- *
- * Driver specific definitions
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#ifndef __AR9170_H
-#define __AR9170_H
-#include <linux/completion.h>
-#include <linux/spinlock.h>
-#include <net/cfg80211.h>
-#include <net/mac80211.h>
-#ifdef CONFIG_AR9170_LEDS
-#include <linux/leds.h>
-#endif /* CONFIG_AR9170_LEDS */
-#include "eeprom.h"
-#include "hw.h"
-#include "../regd.h"
-#define PAYLOAD_MAX     (AR9170_MAX_CMD_LEN/4 - 1)
-enum ar9170_bw {
-        AR9170_BW_20,
-        AR9170_BW_40_BELOW,
-        AR9170_BW_40_ABOVE,
-        __AR9170_NUM_BW,
-};
-static inline enum ar9170_bw nl80211_to_ar9170(enum nl80211_channel_type type)
-{
-        switch (type) {
-        case NL80211_CHAN_NO_HT:
-        case NL80211_CHAN_HT20:
-                return AR9170_BW_20;
-        case NL80211_CHAN_HT40MINUS:
-                return AR9170_BW_40_BELOW;
-        case NL80211_CHAN_HT40PLUS:
-                return AR9170_BW_40_ABOVE;
-        default:
-                BUG();
-        }
-}
-enum ar9170_rf_init_mode {
-        AR9170_RFI_NONE,
-        AR9170_RFI_WARM,
-        AR9170_RFI_COLD,
-};
-#define AR9170_MAX_RX_BUFFER_SIZE               8192
-#ifdef CONFIG_AR9170_LEDS
-struct ar9170;
-struct ar9170_led {
-        struct ar9170 *ar;
-        struct led_classdev l;
-        char name[32];
-        unsigned int toggled;
-        bool last_state;
-        bool registered;
-};
-#endif /* CONFIG_AR9170_LEDS */
-enum ar9170_device_state {
-        AR9170_UNKNOWN_STATE,
-        AR9170_STOPPED,
-        AR9170_IDLE,
-        AR9170_STARTED,
-};
-struct ar9170_rxstream_mpdu_merge {
-        struct ar9170_rx_head plcp;
-        bool has_plcp;
-};
-struct ar9170_tx_queue_stats {
-        unsigned int len;
-        unsigned int limit;
-        unsigned int count;
-};
-#define AR9170_QUEUE_TIMEOUT            64
-#define AR9170_TX_TIMEOUT               8
-#define AR9170_JANITOR_DELAY            128
-#define AR9170_TX_INVALID_RATE          0xffffffff
-#define AR9170_NUM_TX_LIMIT_HARD        AR9170_TXQ_DEPTH
-#define AR9170_NUM_TX_LIMIT_SOFT        (AR9170_TXQ_DEPTH - 10)
-struct ar9170 {
-        struct ieee80211_hw *hw;
-        struct ath_common common;
-        struct mutex mutex;
-        enum ar9170_device_state state;
-        bool registered;
-        unsigned long bad_hw_nagger;
-        int (*open)(struct ar9170 *);
-        void (*stop)(struct ar9170 *);
-        int (*tx)(struct ar9170 *, struct sk_buff *);
-        int (*exec_cmd)(struct ar9170 *, enum ar9170_cmd, u32 ,
-                        void *, u32 , void *);
-        void (*callback_cmd)(struct ar9170 *, u32 , void *);
-        int (*flush)(struct ar9170 *);
-        /* interface mode settings */
-        struct ieee80211_vif *vif;
-        /* beaconing */
-        struct sk_buff *beacon;
-        struct work_struct beacon_work;
-        bool enable_beacon;
-        /* cryptographic engine */
-        u64 usedkeys;
-        bool rx_software_decryption;
-        bool disable_offload;
-        /* filter settings */
-        u64 cur_mc_hash;
-        u32 cur_filter;
-        unsigned int filter_state;
-        bool sniffer_enabled;
-        /* PHY */
-        struct ieee80211_channel *channel;
-        int noise[4];
-        /* power calibration data */
-        u8 power_5G_leg[4];
-        u8 power_2G_cck[4];
-        u8 power_2G_ofdm[4];
-        u8 power_5G_ht20[8];
-        u8 power_5G_ht40[8];
-        u8 power_2G_ht20[8];
-        u8 power_2G_ht40[8];
-        u8 phy_heavy_clip;
-#ifdef CONFIG_AR9170_LEDS
-        struct delayed_work led_work;
-        struct ar9170_led leds[AR9170_NUM_LEDS];
-#endif /* CONFIG_AR9170_LEDS */
-        /* qos queue settings */
-        spinlock_t tx_stats_lock;
-        struct ar9170_tx_queue_stats tx_stats[5];
-        struct ieee80211_tx_queue_params edcf[5];
-        spinlock_t cmdlock;
-        __le32 cmdbuf[PAYLOAD_MAX + 1];
-        /* MAC statistics */
-        struct ieee80211_low_level_stats stats;
-        /* EEPROM */
-        struct ar9170_eeprom eeprom;
-        /* tx queues - as seen by hw - */
-        struct sk_buff_head tx_pending[__AR9170_NUM_TXQ];
-        struct sk_buff_head tx_status[__AR9170_NUM_TXQ];
-        struct delayed_work tx_janitor;
-        /* rxstream mpdu merge */
-        struct ar9170_rxstream_mpdu_merge rx_mpdu;
-        struct sk_buff *rx_failover;
-        int rx_failover_missing;
-        /* (cached) HW A-MPDU settings */
-        u8 global_ampdu_density;
-        u8 global_ampdu_factor;
-};
-struct ar9170_tx_info {
-        unsigned long timeout;
-};
-#define IS_STARTED(a)           (((struct ar9170 *)a)->state >= AR9170_STARTED)
-#define IS_ACCEPTING_CMD(a)     (((struct ar9170 *)a)->state >= AR9170_IDLE)
-/* exported interface */
-void *ar9170_alloc(size_t priv_size);
-int ar9170_register(struct ar9170 *ar, struct device *pdev);
-void ar9170_rx(struct ar9170 *ar, struct sk_buff *skb);
-void ar9170_unregister(struct ar9170 *ar);
-void ar9170_tx_callback(struct ar9170 *ar, struct sk_buff *skb);
-void ar9170_handle_command_response(struct ar9170 *ar, void *buf, u32 len);
-int ar9170_nag_limiter(struct ar9170 *ar);
-/* MAC */
-void ar9170_op_tx(struct ieee80211_hw *hw, struct sk_buff *skb);
-int ar9170_init_mac(struct ar9170 *ar);
-int ar9170_set_qos(struct ar9170 *ar);
-int ar9170_update_multicast(struct ar9170 *ar, const u64 mc_hast);
-int ar9170_update_frame_filter(struct ar9170 *ar, const u32 filter);
-int ar9170_set_operating_mode(struct ar9170 *ar);
-int ar9170_set_beacon_timers(struct ar9170 *ar);
-int ar9170_set_dyn_sifs_ack(struct ar9170 *ar);
-int ar9170_set_slot_time(struct ar9170 *ar);
-int ar9170_set_basic_rates(struct ar9170 *ar);
-int ar9170_set_hwretry_limit(struct ar9170 *ar, u32 max_retry);
-int ar9170_update_beacon(struct ar9170 *ar);
-void ar9170_new_beacon(struct work_struct *work);
-int ar9170_upload_key(struct ar9170 *ar, u8 id, const u8 *mac, u8 ktype,
-                      u8 keyidx, u8 *keydata, int keylen);
-int ar9170_disable_key(struct ar9170 *ar, u8 id);
-/* LEDs */
-#ifdef CONFIG_AR9170_LEDS
-int ar9170_register_leds(struct ar9170 *ar);
-void ar9170_unregister_leds(struct ar9170 *ar);
-#endif /* CONFIG_AR9170_LEDS */
-int ar9170_init_leds(struct ar9170 *ar);
-int ar9170_set_leds_state(struct ar9170 *ar, u32 led_state);
-/* PHY / RF */
-int ar9170_init_phy(struct ar9170 *ar, enum ieee80211_band band);
-int ar9170_init_rf(struct ar9170 *ar);
-int ar9170_set_channel(struct ar9170 *ar, struct ieee80211_channel *channel,
-                       enum ar9170_rf_init_mode rfi, enum ar9170_bw bw);
-#endif /* __AR9170_H */
diff --git a/drivers/net/wireless/ath/ar9170/cmd.c b/drivers/net/wireless/ath/ar9170/cmd.c
deleted file mode 100644
index 6452c5055a63..000000000000
--- a/drivers/net/wireless/ath/ar9170/cmd.c
+++ /dev/null
@@ -1,127 +0,0 @@
-/*
- * Atheros AR9170 driver
- *
- * Basic HW register/memory/command access functions
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#include "ar9170.h"
-#include "cmd.h"
-int ar9170_write_mem(struct ar9170 *ar, const __le32 *data, size_t len)
-{
-        int err;
-        if (unlikely(!IS_ACCEPTING_CMD(ar)))
-                return 0;
-        err = ar->exec_cmd(ar, AR9170_CMD_WMEM, len, (u8 *) data, 0, NULL);
-        if (err)
-                wiphy_debug(ar->hw->wiphy, "writing memory failed\n");
-        return err;
-}
-int ar9170_write_reg(struct ar9170 *ar, const u32 reg, const u32 val)
-{
-        const __le32 buf[2] = {
-                cpu_to_le32(reg),
-                cpu_to_le32(val),
-        };
-        int err;
-        if (unlikely(!IS_ACCEPTING_CMD(ar)))
-                return 0;
-        err = ar->exec_cmd(ar, AR9170_CMD_WREG, sizeof(buf),
-                           (u8 *) buf, 0, NULL);
-        if (err)
-                wiphy_debug(ar->hw->wiphy, "writing reg %#x (val %#x) failed\n",
-                            reg, val);
-        return err;
-}
-int ar9170_read_mreg(struct ar9170 *ar, int nregs, const u32 *regs, u32 *out)
-{
-        int i, err;
-        __le32 *offs, *res;
-        if (unlikely(!IS_ACCEPTING_CMD(ar)))
-                return 0;
-        /* abuse "out" for the register offsets, must be same length */
-        offs = (__le32 *)out;
-        for (i = 0; i < nregs; i++)
-                offs[i] = cpu_to_le32(regs[i]);
-        /* also use the same buffer for the input */
-        res = (__le32 *)out;
-        err = ar->exec_cmd(ar, AR9170_CMD_RREG,
-                           4 * nregs, (u8 *)offs,
-                           4 * nregs, (u8 *)res);
-        if (err)
-                return err;
-        /* convert result to cpu endian */
-        for (i = 0; i < nregs; i++)
-                out[i] = le32_to_cpu(res[i]);
-        return 0;
-}
-int ar9170_read_reg(struct ar9170 *ar, u32 reg, u32 *val)
-{
-        return ar9170_read_mreg(ar, 1, &reg, val);
-}
-int ar9170_echo_test(struct ar9170 *ar, u32 v)
-{
-        __le32 echobuf = cpu_to_le32(v);
-        __le32 echores;
-        int err;
-        if (unlikely(!IS_ACCEPTING_CMD(ar)))
-                return -ENODEV;
-        err = ar->exec_cmd(ar, AR9170_CMD_ECHO,
-                           4, (u8 *)&echobuf,
-                           4, (u8 *)&echores);
-        if (err)
-                return err;
-        if (echobuf != echores)
-                return -EINVAL;
-        return 0;
-}
diff --git a/drivers/net/wireless/ath/ar9170/cmd.h b/drivers/net/wireless/ath/ar9170/cmd.h
deleted file mode 100644
index ec8134b4b949..000000000000
--- a/drivers/net/wireless/ath/ar9170/cmd.h
+++ /dev/null
@@ -1,92 +0,0 @@
-/*
- * Atheros AR9170 driver
- *
- * Basic HW register/memory/command access functions
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#ifndef __CMD_H
-#define __CMD_H
-#include "ar9170.h"
-/* basic HW access */
-int ar9170_write_mem(struct ar9170 *ar, const __le32 *data, size_t len);
-int ar9170_write_reg(struct ar9170 *ar, const u32 reg, const u32 val);
-int ar9170_read_reg(struct ar9170 *ar, u32 reg, u32 *val);
-int ar9170_read_mreg(struct ar9170 *ar, int nregs, const u32 *regs, u32 *out);
-int ar9170_echo_test(struct ar9170 *ar, u32 v);
-/*
- * Macros to facilitate writing multiple registers in a single
- * write-combining USB command. Note that when the first group
- * fails the whole thing will fail without any others attempted,
- * but you won't know which write in the group failed.
- */
-#define ar9170_regwrite_begin(ar)                                       \
-do {                                                                    \
-        int __nreg = 0, __err = 0;                                      \
-        struct ar9170 *__ar = ar;
-#define ar9170_regwrite(r, v) do {                                      \
-        __ar->cmdbuf[2 * __nreg + 1] = cpu_to_le32(r);                  \
-        __ar->cmdbuf[2 * __nreg + 2] = cpu_to_le32(v);                  \
-        __nreg++;                                                       \
-        if ((__nreg >= PAYLOAD_MAX/2)) {                                \
-                if (IS_ACCEPTING_CMD(__ar))                             \
-                        __err = ar->exec_cmd(__ar, AR9170_CMD_WREG,     \
-                                             8 * __nreg,                \
-                                             (u8 *) &__ar->cmdbuf[1],   \
-                                             0, NULL);                  \
-                __nreg = 0;                                             \
-                if (__err)                                              \
-                        goto __regwrite_out;                            \
-        }                                                               \
-} while (0)
-#define ar9170_regwrite_finish()                                        \
-__regwrite_out :                                                        \
-        if (__nreg) {                                                   \
-                if (IS_ACCEPTING_CMD(__ar))                             \
-                        __err = ar->exec_cmd(__ar, AR9170_CMD_WREG,     \
-                                             8 * __nreg,                \
-                                             (u8 *) &__ar->cmdbuf[1],   \
-                                             0, NULL);                  \
-                __nreg = 0;                                             \
-        }
-#define ar9170_regwrite_result()                                        \
-        __err;                                                          \
-} while (0);
-#endif /* __CMD_H */
diff --git a/drivers/net/wireless/ath/ar9170/eeprom.h b/drivers/net/wireless/ath/ar9170/eeprom.h
deleted file mode 100644
index 6c4663883423..000000000000
--- a/drivers/net/wireless/ath/ar9170/eeprom.h
+++ /dev/null
@@ -1,179 +0,0 @@
-/*
- * Atheros AR9170 driver
- *
- * EEPROM layout
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#ifndef __AR9170_EEPROM_H
-#define __AR9170_EEPROM_H
-#define AR5416_MAX_CHAINS               2
-#define AR5416_MODAL_SPURS              5
-struct ar9170_eeprom_modal {
-        __le32  antCtrlChain[AR5416_MAX_CHAINS];
-        __le32  antCtrlCommon;
-        s8      antennaGainCh[AR5416_MAX_CHAINS];
-        u8      switchSettling;
-        u8      txRxAttenCh[AR5416_MAX_CHAINS];
-        u8      rxTxMarginCh[AR5416_MAX_CHAINS];
-        s8      adcDesiredSize;
-        s8      pgaDesiredSize;
-        u8      xlnaGainCh[AR5416_MAX_CHAINS];
-        u8      txEndToXpaOff;
-        u8      txEndToRxOn;
-        u8      txFrameToXpaOn;
-        u8      thresh62;
-        s8      noiseFloorThreshCh[AR5416_MAX_CHAINS];
-        u8      xpdGain;
-        u8      xpd;
-        s8      iqCalICh[AR5416_MAX_CHAINS];
-        s8      iqCalQCh[AR5416_MAX_CHAINS];
-        u8      pdGainOverlap;
-        u8      ob;
-        u8      db;
-        u8      xpaBiasLvl;
-        u8      pwrDecreaseFor2Chain;
-        u8      pwrDecreaseFor3Chain;
-        u8      txFrameToDataStart;
-        u8      txFrameToPaOn;
-        u8      ht40PowerIncForPdadc;
-        u8      bswAtten[AR5416_MAX_CHAINS];
-        u8      bswMargin[AR5416_MAX_CHAINS];
-        u8      swSettleHt40;
-        u8      reserved[22];
-        struct spur_channel {
-                __le16 spurChan;
-                u8      spurRangeLow;
-                u8      spurRangeHigh;
-        } __packed spur_channels[AR5416_MODAL_SPURS];
-} __packed;
-#define AR5416_NUM_PD_GAINS             4
-#define AR5416_PD_GAIN_ICEPTS           5
-struct ar9170_calibration_data_per_freq {
-        u8      pwr_pdg[AR5416_NUM_PD_GAINS][AR5416_PD_GAIN_ICEPTS];
-        u8      vpd_pdg[AR5416_NUM_PD_GAINS][AR5416_PD_GAIN_ICEPTS];
-} __packed;
-#define AR5416_NUM_5G_CAL_PIERS         8
-#define AR5416_NUM_2G_CAL_PIERS         4
-#define AR5416_NUM_5G_TARGET_PWRS       8
-#define AR5416_NUM_2G_CCK_TARGET_PWRS   3
-#define AR5416_NUM_2G_OFDM_TARGET_PWRS  4
-#define AR5416_MAX_NUM_TGT_PWRS         8
-struct ar9170_calibration_target_power_legacy {
-        u8      freq;
-        u8      power[4];
-} __packed;
-struct ar9170_calibration_target_power_ht {
-        u8      freq;
-        u8      power[8];
-} __packed;
-#define AR5416_NUM_CTLS                 24
-struct ar9170_calctl_edges {
-        u8      channel;
-#define AR9170_CALCTL_EDGE_FLAGS        0xC0
-        u8      power_flags;
-} __packed;
-#define AR5416_NUM_BAND_EDGES           8
-struct ar9170_calctl_data {
-        struct ar9170_calctl_edges
-                control_edges[AR5416_MAX_CHAINS][AR5416_NUM_BAND_EDGES];
-} __packed;
-struct ar9170_eeprom {
-        __le16  length;
-        __le16  checksum;
-        __le16  version;
-        u8      operating_flags;
-#define AR9170_OPFLAG_5GHZ              1
-#define AR9170_OPFLAG_2GHZ              2
-        u8      misc;
-        __le16  reg_domain[2];
-        u8      mac_address[6];
-        u8      rx_mask;
-        u8      tx_mask;
-        __le16  rf_silent;
-        __le16  bluetooth_options;
-        __le16  device_capabilities;
-        __le32  build_number;
-        u8      deviceType;
-        u8      reserved[33];
-        u8      customer_data[64];
-        struct ar9170_eeprom_modal
-                modal_header[2];
-        u8      cal_freq_pier_5G[AR5416_NUM_5G_CAL_PIERS];
-        u8      cal_freq_pier_2G[AR5416_NUM_2G_CAL_PIERS];
-        struct ar9170_calibration_data_per_freq
-                cal_pier_data_5G[AR5416_MAX_CHAINS][AR5416_NUM_5G_CAL_PIERS],
-                cal_pier_data_2G[AR5416_MAX_CHAINS][AR5416_NUM_2G_CAL_PIERS];
-        /* power calibration data */
-        struct ar9170_calibration_target_power_legacy
-                cal_tgt_pwr_5G[AR5416_NUM_5G_TARGET_PWRS];
-        struct ar9170_calibration_target_power_ht
-                cal_tgt_pwr_5G_ht20[AR5416_NUM_5G_TARGET_PWRS],
-                cal_tgt_pwr_5G_ht40[AR5416_NUM_5G_TARGET_PWRS];
-        struct ar9170_calibration_target_power_legacy
-                cal_tgt_pwr_2G_cck[AR5416_NUM_2G_CCK_TARGET_PWRS],
-                cal_tgt_pwr_2G_ofdm[AR5416_NUM_2G_OFDM_TARGET_PWRS];
-        struct ar9170_calibration_target_power_ht
-                cal_tgt_pwr_2G_ht20[AR5416_NUM_2G_OFDM_TARGET_PWRS],
-                cal_tgt_pwr_2G_ht40[AR5416_NUM_2G_OFDM_TARGET_PWRS];
-        /* conformance testing limits */
-        u8      ctl_index[AR5416_NUM_CTLS];
-        struct ar9170_calctl_data
-                ctl_data[AR5416_NUM_CTLS];
-        u8      pad;
-        __le16  subsystem_id;
-} __packed;
-#endif /* __AR9170_EEPROM_H */
diff --git a/drivers/net/wireless/ath/ar9170/hw.h b/drivers/net/wireless/ath/ar9170/hw.h
deleted file mode 100644
index 06f1f3c951a4..000000000000
--- a/drivers/net/wireless/ath/ar9170/hw.h
+++ /dev/null
@@ -1,430 +0,0 @@
-/*
- * Atheros AR9170 driver
- *
- * Hardware-specific definitions
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#ifndef __AR9170_HW_H
-#define __AR9170_HW_H
-#define AR9170_MAX_CMD_LEN      64
-enum ar9170_cmd {
-        AR9170_CMD_RREG         = 0x00,
-        AR9170_CMD_WREG         = 0x01,
-        AR9170_CMD_RMEM         = 0x02,
-        AR9170_CMD_WMEM         = 0x03,
-        AR9170_CMD_BITAND       = 0x04,
-        AR9170_CMD_BITOR        = 0x05,
-        AR9170_CMD_EKEY         = 0x28,
-        AR9170_CMD_DKEY         = 0x29,
-        AR9170_CMD_FREQUENCY    = 0x30,
-        AR9170_CMD_RF_INIT      = 0x31,
-        AR9170_CMD_SYNTH        = 0x32,
-        AR9170_CMD_FREQ_START   = 0x33,
-        AR9170_CMD_ECHO         = 0x80,
-        AR9170_CMD_TALLY        = 0x81,
-        AR9170_CMD_TALLY_APD    = 0x82,
-        AR9170_CMD_CONFIG       = 0x83,
-        AR9170_CMD_RESET        = 0x90,
-        AR9170_CMD_DKRESET      = 0x91,
-        AR9170_CMD_DKTX_STATUS  = 0x92,
-        AR9170_CMD_FDC          = 0xA0,
-        AR9170_CMD_WREEPROM     = 0xB0,
-        AR9170_CMD_WFLASH       = 0xB0,
-        AR9170_CMD_FLASH_ERASE  = 0xB1,
-        AR9170_CMD_FLASH_PROG   = 0xB2,
-        AR9170_CMD_FLASH_CHKSUM = 0xB3,
-        AR9170_CMD_FLASH_READ   = 0xB4,
-        AR9170_CMD_FW_DL_INIT   = 0xB5,
-        AR9170_CMD_MEM_WREEPROM = 0xBB,
-};
-/* endpoints */
-#define AR9170_EP_TX                            1
-#define AR9170_EP_RX                            2
-#define AR9170_EP_IRQ                           3
-#define AR9170_EP_CMD                           4
-#define AR9170_EEPROM_START                     0x1600
-#define AR9170_GPIO_REG_BASE                    0x1d0100
-#define AR9170_GPIO_REG_PORT_TYPE               AR9170_GPIO_REG_BASE
-#define AR9170_GPIO_REG_DATA                    (AR9170_GPIO_REG_BASE + 4)
-#define AR9170_NUM_LEDS                         2
-#define AR9170_USB_REG_BASE                     0x1e1000
-#define AR9170_USB_REG_DMA_CTL                  (AR9170_USB_REG_BASE + 0x108)
-#define         AR9170_DMA_CTL_ENABLE_TO_DEVICE         0x1
-#define         AR9170_DMA_CTL_ENABLE_FROM_DEVICE       0x2
-#define         AR9170_DMA_CTL_HIGH_SPEED               0x4
-#define         AR9170_DMA_CTL_PACKET_MODE              0x8
-#define AR9170_USB_REG_MAX_AGG_UPLOAD           (AR9170_USB_REG_BASE + 0x110)
-#define AR9170_USB_REG_UPLOAD_TIME_CTL          (AR9170_USB_REG_BASE + 0x114)
-#define AR9170_MAC_REG_BASE                     0x1c3000
-#define AR9170_MAC_REG_TSF_L                    (AR9170_MAC_REG_BASE + 0x514)
-#define AR9170_MAC_REG_TSF_H                    (AR9170_MAC_REG_BASE + 0x518)
-#define AR9170_MAC_REG_ATIM_WINDOW              (AR9170_MAC_REG_BASE + 0x51C)
-#define AR9170_MAC_REG_BCN_PERIOD               (AR9170_MAC_REG_BASE + 0x520)
-#define AR9170_MAC_REG_PRETBTT                  (AR9170_MAC_REG_BASE + 0x524)
-#define AR9170_MAC_REG_MAC_ADDR_L               (AR9170_MAC_REG_BASE + 0x610)
-#define AR9170_MAC_REG_MAC_ADDR_H               (AR9170_MAC_REG_BASE + 0x614)
-#define AR9170_MAC_REG_BSSID_L                  (AR9170_MAC_REG_BASE + 0x618)
-#define AR9170_MAC_REG_BSSID_H                  (AR9170_MAC_REG_BASE + 0x61c)
-#define AR9170_MAC_REG_GROUP_HASH_TBL_L         (AR9170_MAC_REG_BASE + 0x624)
-#define AR9170_MAC_REG_GROUP_HASH_TBL_H         (AR9170_MAC_REG_BASE + 0x628)
-#define AR9170_MAC_REG_RX_TIMEOUT               (AR9170_MAC_REG_BASE + 0x62C)
-#define AR9170_MAC_REG_BASIC_RATE               (AR9170_MAC_REG_BASE + 0x630)
-#define AR9170_MAC_REG_MANDATORY_RATE           (AR9170_MAC_REG_BASE + 0x634)
-#define AR9170_MAC_REG_RTS_CTS_RATE             (AR9170_MAC_REG_BASE + 0x638)
-#define AR9170_MAC_REG_BACKOFF_PROTECT          (AR9170_MAC_REG_BASE + 0x63c)
-#define AR9170_MAC_REG_RX_THRESHOLD             (AR9170_MAC_REG_BASE + 0x640)
-#define AR9170_MAC_REG_RX_PE_DELAY              (AR9170_MAC_REG_BASE + 0x64C)
-#define AR9170_MAC_REG_DYNAMIC_SIFS_ACK         (AR9170_MAC_REG_BASE + 0x658)
-#define AR9170_MAC_REG_SNIFFER                  (AR9170_MAC_REG_BASE + 0x674)
-#define         AR9170_MAC_REG_SNIFFER_ENABLE_PROMISC   BIT(0)
-#define         AR9170_MAC_REG_SNIFFER_DEFAULTS         0x02000000
-#define AR9170_MAC_REG_ENCRYPTION               (AR9170_MAC_REG_BASE + 0x678)
-#define         AR9170_MAC_REG_ENCRYPTION_RX_SOFTWARE   BIT(3)
-#define         AR9170_MAC_REG_ENCRYPTION_DEFAULTS      0x70
-#define AR9170_MAC_REG_MISC_680                 (AR9170_MAC_REG_BASE + 0x680)
-#define AR9170_MAC_REG_TX_UNDERRUN              (AR9170_MAC_REG_BASE + 0x688)
-#define AR9170_MAC_REG_FRAMETYPE_FILTER         (AR9170_MAC_REG_BASE + 0x68c)
-#define         AR9170_MAC_REG_FTF_ASSOC_REQ            BIT(0)
-#define         AR9170_MAC_REG_FTF_ASSOC_RESP           BIT(1)
-#define         AR9170_MAC_REG_FTF_REASSOC_REQ          BIT(2)
-#define         AR9170_MAC_REG_FTF_REASSOC_RESP         BIT(3)
-#define         AR9170_MAC_REG_FTF_PRB_REQ              BIT(4)
-#define         AR9170_MAC_REG_FTF_PRB_RESP             BIT(5)
-#define         AR9170_MAC_REG_FTF_BIT6                 BIT(6)
-#define         AR9170_MAC_REG_FTF_BIT7                 BIT(7)
-#define         AR9170_MAC_REG_FTF_BEACON               BIT(8)
-#define         AR9170_MAC_REG_FTF_ATIM                 BIT(9)
-#define         AR9170_MAC_REG_FTF_DEASSOC              BIT(10)
-#define         AR9170_MAC_REG_FTF_AUTH                 BIT(11)
-#define         AR9170_MAC_REG_FTF_DEAUTH               BIT(12)
-#define         AR9170_MAC_REG_FTF_BIT13                BIT(13)
-#define         AR9170_MAC_REG_FTF_BIT14                BIT(14)
-#define         AR9170_MAC_REG_FTF_BIT15                BIT(15)
-#define         AR9170_MAC_REG_FTF_BAR                  BIT(24)
-#define         AR9170_MAC_REG_FTF_BA                   BIT(25)
-#define         AR9170_MAC_REG_FTF_PSPOLL               BIT(26)
-#define         AR9170_MAC_REG_FTF_RTS                  BIT(27)
-#define         AR9170_MAC_REG_FTF_CTS                  BIT(28)
-#define         AR9170_MAC_REG_FTF_ACK                  BIT(29)
-#define         AR9170_MAC_REG_FTF_CFE                  BIT(30)
-#define         AR9170_MAC_REG_FTF_CFE_ACK              BIT(31)
-#define         AR9170_MAC_REG_FTF_DEFAULTS             0x0700ffff
-#define         AR9170_MAC_REG_FTF_MONITOR              0xfd00ffff
-#define AR9170_MAC_REG_RX_TOTAL                 (AR9170_MAC_REG_BASE + 0x6A0)
-#define AR9170_MAC_REG_RX_CRC32                 (AR9170_MAC_REG_BASE + 0x6A4)
-#define AR9170_MAC_REG_RX_CRC16                 (AR9170_MAC_REG_BASE + 0x6A8)
-#define AR9170_MAC_REG_RX_ERR_DECRYPTION_UNI    (AR9170_MAC_REG_BASE + 0x6AC)
-#define AR9170_MAC_REG_RX_OVERRUN               (AR9170_MAC_REG_BASE + 0x6B0)
-#define AR9170_MAC_REG_RX_ERR_DECRYPTION_MUL    (AR9170_MAC_REG_BASE + 0x6BC)
-#define AR9170_MAC_REG_TX_RETRY                 (AR9170_MAC_REG_BASE + 0x6CC)
-#define AR9170_MAC_REG_TX_TOTAL                 (AR9170_MAC_REG_BASE + 0x6F4)
-#define AR9170_MAC_REG_ACK_EXTENSION            (AR9170_MAC_REG_BASE + 0x690)
-#define AR9170_MAC_REG_EIFS_AND_SIFS            (AR9170_MAC_REG_BASE + 0x698)
-#define AR9170_MAC_REG_SLOT_TIME                (AR9170_MAC_REG_BASE + 0x6F0)
-#define AR9170_MAC_REG_POWERMANAGEMENT          (AR9170_MAC_REG_BASE + 0x700)
-#define         AR9170_MAC_REG_POWERMGT_IBSS            0xe0
-#define         AR9170_MAC_REG_POWERMGT_AP              0xa1
-#define         AR9170_MAC_REG_POWERMGT_STA             0x2
-#define         AR9170_MAC_REG_POWERMGT_AP_WDS          0x3
-#define         AR9170_MAC_REG_POWERMGT_DEFAULTS        (0xf << 24)
-#define AR9170_MAC_REG_ROLL_CALL_TBL_L          (AR9170_MAC_REG_BASE + 0x704)
-#define AR9170_MAC_REG_ROLL_CALL_TBL_H          (AR9170_MAC_REG_BASE + 0x708)
-#define AR9170_MAC_REG_AC0_CW                   (AR9170_MAC_REG_BASE + 0xB00)
-#define AR9170_MAC_REG_AC1_CW                   (AR9170_MAC_REG_BASE + 0xB04)
-#define AR9170_MAC_REG_AC2_CW                   (AR9170_MAC_REG_BASE + 0xB08)
-#define AR9170_MAC_REG_AC3_CW                   (AR9170_MAC_REG_BASE + 0xB0C)
-#define AR9170_MAC_REG_AC4_CW                   (AR9170_MAC_REG_BASE + 0xB10)
-#define AR9170_MAC_REG_AC1_AC0_AIFS             (AR9170_MAC_REG_BASE + 0xB14)
-#define AR9170_MAC_REG_AC3_AC2_AIFS             (AR9170_MAC_REG_BASE + 0xB18)
-#define AR9170_MAC_REG_RETRY_MAX                (AR9170_MAC_REG_BASE + 0xB28)
-#define AR9170_MAC_REG_FCS_SELECT               (AR9170_MAC_REG_BASE + 0xBB0)
-#define         AR9170_MAC_FCS_SWFCS            0x1
-#define         AR9170_MAC_FCS_FIFO_PROT        0x4
-#define AR9170_MAC_REG_TXOP_NOT_ENOUGH_IND      (AR9170_MAC_REG_BASE + 0xB30)
-#define AR9170_MAC_REG_AC1_AC0_TXOP             (AR9170_MAC_REG_BASE + 0xB44)
-#define AR9170_MAC_REG_AC3_AC2_TXOP             (AR9170_MAC_REG_BASE + 0xB48)
-#define AR9170_MAC_REG_AMPDU_FACTOR             (AR9170_MAC_REG_BASE + 0xB9C)
-#define AR9170_MAC_REG_AMPDU_DENSITY            (AR9170_MAC_REG_BASE + 0xBA0)
-#define AR9170_MAC_REG_ACK_TABLE                (AR9170_MAC_REG_BASE + 0xC00)
-#define AR9170_MAC_REG_AMPDU_RX_THRESH          (AR9170_MAC_REG_BASE + 0xC50)
-#define AR9170_MAC_REG_TXRX_MPI                 (AR9170_MAC_REG_BASE + 0xD7C)
-#define         AR9170_MAC_TXRX_MPI_TX_MPI_MASK 0x0000000f
-#define         AR9170_MAC_TXRX_MPI_TX_TO_MASK  0x0000fff0
-#define         AR9170_MAC_TXRX_MPI_RX_MPI_MASK 0x000f0000
-#define         AR9170_MAC_TXRX_MPI_RX_TO_MASK  0xfff00000
-#define AR9170_MAC_REG_BCN_ADDR                 (AR9170_MAC_REG_BASE + 0xD84)
-#define AR9170_MAC_REG_BCN_LENGTH               (AR9170_MAC_REG_BASE + 0xD88)
-#define AR9170_MAC_REG_BCN_PLCP                 (AR9170_MAC_REG_BASE + 0xD90)
-#define AR9170_MAC_REG_BCN_CTRL                 (AR9170_MAC_REG_BASE + 0xD94)
-#define AR9170_MAC_REG_BCN_HT1                  (AR9170_MAC_REG_BASE + 0xDA0)
-#define AR9170_MAC_REG_BCN_HT2                  (AR9170_MAC_REG_BASE + 0xDA4)
-#define AR9170_PWR_REG_BASE                     0x1D4000
-#define AR9170_PWR_REG_CLOCK_SEL                (AR9170_PWR_REG_BASE + 0x008)
-#define         AR9170_PWR_CLK_AHB_40MHZ        0
-#define         AR9170_PWR_CLK_AHB_20_22MHZ     1
-#define         AR9170_PWR_CLK_AHB_40_44MHZ     2
-#define         AR9170_PWR_CLK_AHB_80_88MHZ     3
-#define         AR9170_PWR_CLK_DAC_160_INV_DLY  0x70
-/* put beacon here in memory */
-#define AR9170_BEACON_BUFFER_ADDRESS            0x117900
-struct ar9170_tx_control {
-        __le16 length;
-        __le16 mac_control;
-        __le32 phy_control;
-        u8 frame_data[0];
-} __packed;
-/* these are either-or */
-#define AR9170_TX_MAC_PROT_RTS                  0x0001
-#define AR9170_TX_MAC_PROT_CTS                  0x0002
-#define AR9170_TX_MAC_NO_ACK                    0x0004
-/* if unset, MAC will only do SIFS space before frame */
-#define AR9170_TX_MAC_BACKOFF                   0x0008
-#define AR9170_TX_MAC_BURST                     0x0010
-#define AR9170_TX_MAC_AGGR                      0x0020
-/* encryption is a two-bit field */
-#define AR9170_TX_MAC_ENCR_NONE                 0x0000
-#define AR9170_TX_MAC_ENCR_RC4                  0x0040
-#define AR9170_TX_MAC_ENCR_CENC                 0x0080
-#define AR9170_TX_MAC_ENCR_AES                  0x00c0
-#define AR9170_TX_MAC_MMIC                      0x0100
-#define AR9170_TX_MAC_HW_DURATION               0x0200
-#define AR9170_TX_MAC_QOS_SHIFT                 10
-#define AR9170_TX_MAC_QOS_MASK                  (3 << AR9170_TX_MAC_QOS_SHIFT)
-#define AR9170_TX_MAC_AGGR_QOS_BIT1             0x0400
-#define AR9170_TX_MAC_AGGR_QOS_BIT2             0x0800
-#define AR9170_TX_MAC_DISABLE_TXOP              0x1000
-#define AR9170_TX_MAC_TXOP_RIFS                 0x2000
-#define AR9170_TX_MAC_IMM_AMPDU                 0x4000
-#define AR9170_TX_MAC_RATE_PROBE                0x8000
-/* either-or */
-#define AR9170_TX_PHY_MOD_MASK                  0x00000003
-#define AR9170_TX_PHY_MOD_CCK                   0x00000000
-#define AR9170_TX_PHY_MOD_OFDM                  0x00000001
-#define AR9170_TX_PHY_MOD_HT                    0x00000002
-/* depends on modulation */
-#define AR9170_TX_PHY_SHORT_PREAMBLE            0x00000004
-#define AR9170_TX_PHY_GREENFIELD                0x00000004
-#define AR9170_TX_PHY_BW_SHIFT                  3
-#define AR9170_TX_PHY_BW_MASK                   (3 << AR9170_TX_PHY_BW_SHIFT)
-#define AR9170_TX_PHY_BW_20MHZ                  0
-#define AR9170_TX_PHY_BW_40MHZ                  2
-#define AR9170_TX_PHY_BW_40MHZ_DUP              3
-#define AR9170_TX_PHY_TX_HEAVY_CLIP_SHIFT       6
-#define AR9170_TX_PHY_TX_HEAVY_CLIP_MASK        (7 << AR9170_TX_PHY_TX_HEAVY_CLIP_SHIFT)
-#define AR9170_TX_PHY_TX_PWR_SHIFT              9
-#define AR9170_TX_PHY_TX_PWR_MASK               (0x3f << AR9170_TX_PHY_TX_PWR_SHIFT)
-/* not part of the hw-spec */
-#define AR9170_TX_PHY_QOS_SHIFT                 25
-#define AR9170_TX_PHY_QOS_MASK                  (3 << AR9170_TX_PHY_QOS_SHIFT)
-#define AR9170_TX_PHY_TXCHAIN_SHIFT             15
-#define AR9170_TX_PHY_TXCHAIN_MASK              (7 << AR9170_TX_PHY_TXCHAIN_SHIFT)
-#define AR9170_TX_PHY_TXCHAIN_1                 1
-/* use for cck, ofdm 6/9/12/18/24 and HT if capable */
-#define AR9170_TX_PHY_TXCHAIN_2                 5
-#define AR9170_TX_PHY_MCS_SHIFT                 18
-#define AR9170_TX_PHY_MCS_MASK                  (0x7f << AR9170_TX_PHY_MCS_SHIFT)
-#define AR9170_TX_PHY_SHORT_GI                  0x80000000
-#define AR5416_MAX_RATE_POWER                   63
-struct ar9170_rx_head {
-        u8 plcp[12];
-} __packed;
-struct ar9170_rx_phystatus {
-        union {
-                struct {
-                        u8 rssi_ant0, rssi_ant1, rssi_ant2,
-                           rssi_ant0x, rssi_ant1x, rssi_ant2x,
-                           rssi_combined;
-                } __packed;
-                u8 rssi[7];
-        } __packed;
-        u8 evm_stream0[6], evm_stream1[6];
-        u8 phy_err;
-} __packed;
-struct ar9170_rx_macstatus {
-        u8 SAidx, DAidx;
-        u8 error;
-        u8 status;
-} __packed;
-#define AR9170_ENC_ALG_NONE                     0x0
-#define AR9170_ENC_ALG_WEP64                    0x1
-#define AR9170_ENC_ALG_TKIP                     0x2
-#define AR9170_ENC_ALG_AESCCMP                  0x4
-#define AR9170_ENC_ALG_WEP128                   0x5
-#define AR9170_ENC_ALG_WEP256                   0x6
-#define AR9170_ENC_ALG_CENC                     0x7
-#define AR9170_RX_ENC_SOFTWARE                  0x8
-static inline u8 ar9170_get_decrypt_type(struct ar9170_rx_macstatus *t)
-{
-        return (t->SAidx & 0xc0) >> 4 |
-               (t->DAidx & 0xc0) >> 6;
-}
-#define AR9170_RX_STATUS_MODULATION_MASK        0x03
-#define AR9170_RX_STATUS_MODULATION_CCK         0x00
-#define AR9170_RX_STATUS_MODULATION_OFDM        0x01
-#define AR9170_RX_STATUS_MODULATION_HT          0x02
-#define AR9170_RX_STATUS_MODULATION_DUPOFDM     0x03
-/* depends on modulation */
-#define AR9170_RX_STATUS_SHORT_PREAMBLE         0x08
-#define AR9170_RX_STATUS_GREENFIELD             0x08
-#define AR9170_RX_STATUS_MPDU_MASK              0x30
-#define AR9170_RX_STATUS_MPDU_SINGLE            0x00
-#define AR9170_RX_STATUS_MPDU_FIRST             0x20
-#define AR9170_RX_STATUS_MPDU_MIDDLE            0x30
-#define AR9170_RX_STATUS_MPDU_LAST              0x10
-#define AR9170_RX_ERROR_RXTO                    0x01
-#define AR9170_RX_ERROR_OVERRUN                 0x02
-#define AR9170_RX_ERROR_DECRYPT                 0x04
-#define AR9170_RX_ERROR_FCS                     0x08
-#define AR9170_RX_ERROR_WRONG_RA                0x10
-#define AR9170_RX_ERROR_PLCP                    0x20
-#define AR9170_RX_ERROR_MMIC                    0x40
-#define AR9170_RX_ERROR_FATAL                   0x80
-struct ar9170_cmd_tx_status {
-        u8 dst[ETH_ALEN];
-        __le32 rate;
-        __le16 status;
-} __packed;
-#define AR9170_TX_STATUS_COMPLETE               0x00
-#define AR9170_TX_STATUS_RETRY                  0x01
-#define AR9170_TX_STATUS_FAILED                 0x02
-struct ar9170_cmd_ba_failed_count {
-        __le16 failed;
-        __le16 rate;
-} __packed;
-struct ar9170_cmd_response {
-        u8 flag;
-        u8 type;
-        __le16 padding;
-        union {
-                struct ar9170_cmd_tx_status             tx_status;
-                struct ar9170_cmd_ba_failed_count       ba_fail_cnt;
-                u8 data[0];
-        };
-} __packed;
-/* QoS */
-/* mac80211 queue to HW/FW map */
-static const u8 ar9170_qos_hwmap[4] = { 3, 2, 0, 1 };
-/* HW/FW queue to mac80211 map */
-static const u8 ar9170_qos_mac80211map[4] = { 2, 3, 1, 0 };
-enum ar9170_txq {
-        AR9170_TXQ_BE,
-        AR9170_TXQ_BK,
-        AR9170_TXQ_VI,
-        AR9170_TXQ_VO,
-        __AR9170_NUM_TXQ,
-};
-#define AR9170_TXQ_DEPTH        32
-#define AR9170_TX_MAX_PENDING   128
-#define AR9170_RX_STREAM_MAX_SIZE 65535
-#endif /* __AR9170_HW_H */
diff --git a/drivers/net/wireless/ath/ar9170/led.c b/drivers/net/wireless/ath/ar9170/led.c
deleted file mode 100644
index 832d90087f8a..000000000000
--- a/drivers/net/wireless/ath/ar9170/led.c
+++ /dev/null
@@ -1,181 +0,0 @@
-/*
- * Atheros AR9170 driver
- *
- * LED handling
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#include "ar9170.h"
-#include "cmd.h"
-int ar9170_set_leds_state(struct ar9170 *ar, u32 led_state)
-{
-        return ar9170_write_reg(ar, AR9170_GPIO_REG_DATA, led_state);
-}
-int ar9170_init_leds(struct ar9170 *ar)
-{
-        int err;
-        /* disable LEDs */
-        /* GPIO [0/1 mode: output, 2/3: input] */
-        err = ar9170_write_reg(ar, AR9170_GPIO_REG_PORT_TYPE, 3);
-        if (err)
-                goto out;
-        /* GPIO 0/1 value: off */
-        err = ar9170_set_leds_state(ar, 0);
-out:
-        return err;
-}
-#ifdef CONFIG_AR9170_LEDS
-static void ar9170_update_leds(struct work_struct *work)
-{
-        struct ar9170 *ar = container_of(work, struct ar9170, led_work.work);
-        int i, tmp, blink_delay = 1000;
-        u32 led_val = 0;
-        bool rerun = false;
-        if (unlikely(!IS_ACCEPTING_CMD(ar)))
-                return ;
-        mutex_lock(&ar->mutex);
-        for (i = 0; i < AR9170_NUM_LEDS; i++)
-                if (ar->leds[i].registered && ar->leds[i].toggled) {
-                        led_val |= 1 << i;
-                        tmp = 70 + 200 / (ar->leds[i].toggled);
-                        if (tmp < blink_delay)
-                                blink_delay = tmp;
-                        if (ar->leds[i].toggled > 1)
-                                ar->leds[i].toggled = 0;
-                        rerun = true;
-                }
-        ar9170_set_leds_state(ar, led_val);
-        mutex_unlock(&ar->mutex);
-        if (!rerun)
-                return;
-        ieee80211_queue_delayed_work(ar->hw,
-                                     &ar->led_work,
-                                     msecs_to_jiffies(blink_delay));
-}
-static void ar9170_led_brightness_set(struct led_classdev *led,
-                                      enum led_brightness brightness)
-{
-        struct ar9170_led *arl = container_of(led, struct ar9170_led, l);
-        struct ar9170 *ar = arl->ar;
-        if (unlikely(!arl->registered))
-                return ;
-        if (arl->last_state != !!brightness) {
-                arl->toggled++;
-                arl->last_state = !!brightness;
-        }
-        if (likely(IS_ACCEPTING_CMD(ar) && arl->toggled))
-                ieee80211_queue_delayed_work(ar->hw, &ar->led_work, HZ/10);
-}
-static int ar9170_register_led(struct ar9170 *ar, int i, char *name,
-                               char *trigger)
-{
-        int err;
-        snprintf(ar->leds[i].name, sizeof(ar->leds[i].name),
-                 "ar9170-%s::%s", wiphy_name(ar->hw->wiphy), name);
-        ar->leds[i].ar = ar;
-        ar->leds[i].l.name = ar->leds[i].name;
-        ar->leds[i].l.brightness_set = ar9170_led_brightness_set;
-        ar->leds[i].l.brightness = 0;
-        ar->leds[i].l.default_trigger = trigger;
-        err = led_classdev_register(wiphy_dev(ar->hw->wiphy),
-                                    &ar->leds[i].l);
-        if (err)
-                wiphy_err(ar->hw->wiphy, "failed to register %s LED (%d).\n",
-                          ar->leds[i].name, err);
-        else
-                ar->leds[i].registered = true;
-        return err;
-}
-void ar9170_unregister_leds(struct ar9170 *ar)
-{
-        int i;
-        for (i = 0; i < AR9170_NUM_LEDS; i++)
-                if (ar->leds[i].registered) {
-                        led_classdev_unregister(&ar->leds[i].l);
-                        ar->leds[i].registered = false;
-                        ar->leds[i].toggled = 0;
-                }
-        cancel_delayed_work_sync(&ar->led_work);
-}
-int ar9170_register_leds(struct ar9170 *ar)
-{
-        int err;
-        INIT_DELAYED_WORK(&ar->led_work, ar9170_update_leds);
-        err = ar9170_register_led(ar, 0, "tx",
-                                  ieee80211_get_tx_led_name(ar->hw));
-        if (err)
-                goto fail;
-        err = ar9170_register_led(ar, 1, "assoc",
-                                 ieee80211_get_assoc_led_name(ar->hw));
-        if (err)
-                goto fail;
-        return 0;
-fail:
-        ar9170_unregister_leds(ar);
-        return err;
-}
-#endif /* CONFIG_AR9170_LEDS */
diff --git a/drivers/net/wireless/ath/ar9170/mac.c b/drivers/net/wireless/ath/ar9170/mac.c
deleted file mode 100644
index 857e86104295..000000000000
--- a/drivers/net/wireless/ath/ar9170/mac.c
+++ /dev/null
@@ -1,519 +0,0 @@
-/*
- * Atheros AR9170 driver
- *
- * MAC programming
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#include <asm/unaligned.h>
-#include "ar9170.h"
-#include "cmd.h"
-int ar9170_set_dyn_sifs_ack(struct ar9170 *ar)
-{
-        u32 val;
-        if (conf_is_ht40(&ar->hw->conf))
-                val = 0x010a;
-        else {
-                if (ar->hw->conf.channel->band == IEEE80211_BAND_2GHZ)
-                        val = 0x105;
-                else
-                        val = 0x104;
-        }
-        return ar9170_write_reg(ar, AR9170_MAC_REG_DYNAMIC_SIFS_ACK, val);
-}
-int ar9170_set_slot_time(struct ar9170 *ar)
-{
-        u32 slottime = 20;
-        if (!ar->vif)
-                return 0;
-        if ((ar->hw->conf.channel->band == IEEE80211_BAND_5GHZ) ||
-            ar->vif->bss_conf.use_short_slot)
-                slottime = 9;
-        return ar9170_write_reg(ar, AR9170_MAC_REG_SLOT_TIME, slottime << 10);
-}
-int ar9170_set_basic_rates(struct ar9170 *ar)
-{
-        u8 cck, ofdm;
-        if (!ar->vif)
-                return 0;
-        ofdm = ar->vif->bss_conf.basic_rates >> 4;
-        /* FIXME: is still necessary? */
-        if (ar->hw->conf.channel->band == IEEE80211_BAND_5GHZ)
-                cck = 0;
-        else
-                cck = ar->vif->bss_conf.basic_rates & 0xf;
-        return ar9170_write_reg(ar, AR9170_MAC_REG_BASIC_RATE,
-                                ofdm << 8 | cck);
-}
-int ar9170_set_qos(struct ar9170 *ar)
-{
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(AR9170_MAC_REG_AC0_CW, ar->edcf[0].cw_min |
-                        (ar->edcf[0].cw_max << 16));
-        ar9170_regwrite(AR9170_MAC_REG_AC1_CW, ar->edcf[1].cw_min |
-                        (ar->edcf[1].cw_max << 16));
-        ar9170_regwrite(AR9170_MAC_REG_AC2_CW, ar->edcf[2].cw_min |
-                        (ar->edcf[2].cw_max << 16));
-        ar9170_regwrite(AR9170_MAC_REG_AC3_CW, ar->edcf[3].cw_min |
-                        (ar->edcf[3].cw_max << 16));
-        ar9170_regwrite(AR9170_MAC_REG_AC4_CW, ar->edcf[4].cw_min |
-                        (ar->edcf[4].cw_max << 16));
-        ar9170_regwrite(AR9170_MAC_REG_AC1_AC0_AIFS,
-                        ((ar->edcf[0].aifs * 9 + 10)) |
-                        ((ar->edcf[1].aifs * 9 + 10) << 12) |
-                        ((ar->edcf[2].aifs * 9 + 10) << 24));
-        ar9170_regwrite(AR9170_MAC_REG_AC3_AC2_AIFS,
-                        ((ar->edcf[2].aifs * 9 + 10) >> 8) |
-                        ((ar->edcf[3].aifs * 9 + 10) << 4) |
-                        ((ar->edcf[4].aifs * 9 + 10) << 16));
-        ar9170_regwrite(AR9170_MAC_REG_AC1_AC0_TXOP,
-                        ar->edcf[0].txop | ar->edcf[1].txop << 16);
-        ar9170_regwrite(AR9170_MAC_REG_AC3_AC2_TXOP,
-                        ar->edcf[2].txop | ar->edcf[3].txop << 16);
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-static int ar9170_set_ampdu_density(struct ar9170 *ar, u8 mpdudensity)
-{
-        u32 val;
-        /* don't allow AMPDU density > 8us */
-        if (mpdudensity > 6)
-                return -EINVAL;
-        /* Watch out! Otus uses slightly different density values. */
-        val = 0x140a00 | (mpdudensity ? (mpdudensity + 1) : 0);
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(AR9170_MAC_REG_AMPDU_DENSITY, val);
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-int ar9170_init_mac(struct ar9170 *ar)
-{
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(AR9170_MAC_REG_ACK_EXTENSION, 0x40);
-        ar9170_regwrite(AR9170_MAC_REG_RETRY_MAX, 0);
-        /* enable MMIC */
-        ar9170_regwrite(AR9170_MAC_REG_SNIFFER,
-                        AR9170_MAC_REG_SNIFFER_DEFAULTS);
-        ar9170_regwrite(AR9170_MAC_REG_RX_THRESHOLD, 0xc1f80);
-        ar9170_regwrite(AR9170_MAC_REG_RX_PE_DELAY, 0x70);
-        ar9170_regwrite(AR9170_MAC_REG_EIFS_AND_SIFS, 0xa144000);
-        ar9170_regwrite(AR9170_MAC_REG_SLOT_TIME, 9 << 10);
-        /* CF-END mode */
-        ar9170_regwrite(0x1c3b2c, 0x19000000);
-        /* NAV protects ACK only (in TXOP) */
-        ar9170_regwrite(0x1c3b38, 0x201);
-        /* Set Beacon PHY CTRL's TPC to 0x7, TA1=1 */
-        /* OTUS set AM to 0x1 */
-        ar9170_regwrite(AR9170_MAC_REG_BCN_HT1, 0x8000170);
-        ar9170_regwrite(AR9170_MAC_REG_BACKOFF_PROTECT, 0x105);
-        /* AGG test code*/
-        /* Aggregation MAX number and timeout */
-        ar9170_regwrite(0x1c3b9c, 0x10000a);
-        ar9170_regwrite(AR9170_MAC_REG_FRAMETYPE_FILTER,
-                        AR9170_MAC_REG_FTF_DEFAULTS);
-        /* Enable deaggregator, response in sniffer mode */
-        ar9170_regwrite(0x1c3c40, 0x1 | 1<<30);
-        /* rate sets */
-        ar9170_regwrite(AR9170_MAC_REG_BASIC_RATE, 0x150f);
-        ar9170_regwrite(AR9170_MAC_REG_MANDATORY_RATE, 0x150f);
-        ar9170_regwrite(AR9170_MAC_REG_RTS_CTS_RATE, 0x10b01bb);
-        /* MIMO response control */
-        ar9170_regwrite(0x1c3694, 0x4003C1E);/* bit 26~28  otus-AM */
-        /* switch MAC to OTUS interface */
-        ar9170_regwrite(0x1c3600, 0x3);
-        ar9170_regwrite(AR9170_MAC_REG_AMPDU_RX_THRESH, 0xffff);
-        /* set PHY register read timeout (??) */
-        ar9170_regwrite(AR9170_MAC_REG_MISC_680, 0xf00008);
-        /* Disable Rx TimeOut, workaround for BB. */
-        ar9170_regwrite(AR9170_MAC_REG_RX_TIMEOUT, 0x0);
-        /* Set CPU clock frequency to 88/80MHz */
-        ar9170_regwrite(AR9170_PWR_REG_CLOCK_SEL,
-                        AR9170_PWR_CLK_AHB_80_88MHZ |
-                        AR9170_PWR_CLK_DAC_160_INV_DLY);
-        /* Set WLAN DMA interrupt mode: generate int per packet */
-        ar9170_regwrite(AR9170_MAC_REG_TXRX_MPI, 0x110011);
-        ar9170_regwrite(AR9170_MAC_REG_FCS_SELECT,
-                        AR9170_MAC_FCS_FIFO_PROT);
-        /* Disables the CF_END frame, undocumented register */
-        ar9170_regwrite(AR9170_MAC_REG_TXOP_NOT_ENOUGH_IND,
-                        0x141E0F48);
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-static int ar9170_set_mac_reg(struct ar9170 *ar, const u32 reg, const u8 *mac)
-{
-        static const u8 zero[ETH_ALEN] = { 0 };
-        if (!mac)
-                mac = zero;
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(reg, get_unaligned_le32(mac));
-        ar9170_regwrite(reg + 4, get_unaligned_le16(mac + 4));
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-int ar9170_update_multicast(struct ar9170 *ar, const u64 mc_hash)
-{
-        int err;
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(AR9170_MAC_REG_GROUP_HASH_TBL_H, mc_hash >> 32);
-        ar9170_regwrite(AR9170_MAC_REG_GROUP_HASH_TBL_L, mc_hash);
-        ar9170_regwrite_finish();
-        err = ar9170_regwrite_result();
-        if (err)
-                return err;
-        ar->cur_mc_hash = mc_hash;
-        return 0;
-}
-int ar9170_update_frame_filter(struct ar9170 *ar, const u32 filter)
-{
-        int err;
-        err = ar9170_write_reg(ar, AR9170_MAC_REG_FRAMETYPE_FILTER, filter);
-        if (err)
-                return err;
-        ar->cur_filter = filter;
-        return 0;
-}
-static int ar9170_set_promiscouous(struct ar9170 *ar)
-{
-        u32 encr_mode, sniffer;
-        int err;
-        err = ar9170_read_reg(ar, AR9170_MAC_REG_SNIFFER, &sniffer);
-        if (err)
-                return err;
-        err = ar9170_read_reg(ar, AR9170_MAC_REG_ENCRYPTION, &encr_mode);
-        if (err)
-                return err;
-        if (ar->sniffer_enabled) {
-                sniffer |= AR9170_MAC_REG_SNIFFER_ENABLE_PROMISC;
-                /*
-                 * Rx decryption works in place.
-                 *
-                 * If we don't disable it, the hardware will render all
-                 * encrypted frames which are encrypted with an unknown
-                 * key useless.
-                 */
-                encr_mode |= AR9170_MAC_REG_ENCRYPTION_RX_SOFTWARE;
-                ar->sniffer_enabled = true;
-        } else {
-                sniffer &= ~AR9170_MAC_REG_SNIFFER_ENABLE_PROMISC;
-                if (ar->rx_software_decryption)
-                        encr_mode |= AR9170_MAC_REG_ENCRYPTION_RX_SOFTWARE;
-                else
-                        encr_mode &= ~AR9170_MAC_REG_ENCRYPTION_RX_SOFTWARE;
-        }
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(AR9170_MAC_REG_ENCRYPTION, encr_mode);
-        ar9170_regwrite(AR9170_MAC_REG_SNIFFER, sniffer);
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-int ar9170_set_operating_mode(struct ar9170 *ar)
-{
-        struct ath_common *common = &ar->common;
-        u32 pm_mode = AR9170_MAC_REG_POWERMGT_DEFAULTS;
-        u8 *mac_addr, *bssid;
-        int err;
-        if (ar->vif) {
-                mac_addr = common->macaddr;
-                bssid = common->curbssid;
-                switch (ar->vif->type) {
-                case NL80211_IFTYPE_MESH_POINT:
-                case NL80211_IFTYPE_ADHOC:
-                        pm_mode |= AR9170_MAC_REG_POWERMGT_IBSS;
-                        break;
-                case NL80211_IFTYPE_AP:
-                        pm_mode |= AR9170_MAC_REG_POWERMGT_AP;
-                        break;
-                case NL80211_IFTYPE_WDS:
-                        pm_mode |= AR9170_MAC_REG_POWERMGT_AP_WDS;
-                        break;
-                case NL80211_IFTYPE_MONITOR:
-                        ar->sniffer_enabled = true;
-                        ar->rx_software_decryption = true;
-                        break;
-                default:
-                        pm_mode |= AR9170_MAC_REG_POWERMGT_STA;
-                        break;
-                }
-        } else {
-                mac_addr = NULL;
-                bssid = NULL;
-        }
-        err = ar9170_set_mac_reg(ar, AR9170_MAC_REG_MAC_ADDR_L, mac_addr);
-        if (err)
-                return err;
-        err = ar9170_set_mac_reg(ar, AR9170_MAC_REG_BSSID_L, bssid);
-        if (err)
-                return err;
-        err = ar9170_set_promiscouous(ar);
-        if (err)
-                return err;
-        /* set AMPDU density to 8us. */
-        err = ar9170_set_ampdu_density(ar, 6);
-        if (err)
-                return err;
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(AR9170_MAC_REG_POWERMANAGEMENT, pm_mode);
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-int ar9170_set_hwretry_limit(struct ar9170 *ar, unsigned int max_retry)
-{
-        u32 tmp = min_t(u32, 0x33333, max_retry * 0x11111);
-        return ar9170_write_reg(ar, AR9170_MAC_REG_RETRY_MAX, tmp);
-}
-int ar9170_set_beacon_timers(struct ar9170 *ar)
-{
-        u32 v = 0;
-        u32 pretbtt = 0;
-        if (ar->vif) {
-                v |= ar->vif->bss_conf.beacon_int;
-                if (ar->enable_beacon) {
-                        switch (ar->vif->type) {
-                        case NL80211_IFTYPE_MESH_POINT:
-                        case NL80211_IFTYPE_ADHOC:
-                                v |= BIT(25);
-                                break;
-                        case NL80211_IFTYPE_AP:
-                                v |= BIT(24);
-                                pretbtt = (ar->vif->bss_conf.beacon_int - 6) <<
-                                          16;
-                                break;
-                        default:
-                        break;
-                        }
-                }
-                v |= ar->vif->bss_conf.dtim_period << 16;
-        }
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(AR9170_MAC_REG_PRETBTT, pretbtt);
-        ar9170_regwrite(AR9170_MAC_REG_BCN_PERIOD, v);
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-int ar9170_update_beacon(struct ar9170 *ar)
-{
-        struct sk_buff *skb;
-        __le32 *data, *old = NULL;
-        u32 word;
-        int i;
-        skb = ieee80211_beacon_get(ar->hw, ar->vif);
-        if (!skb)
-                return -ENOMEM;
-        data = (__le32 *)skb->data;
-        if (ar->beacon)
-                old = (__le32 *)ar->beacon->data;
-        ar9170_regwrite_begin(ar);
-        for (i = 0; i < DIV_ROUND_UP(skb->len, 4); i++) {
-                /*
-                 * XXX: This accesses beyond skb data for up
-                 *      to the last 3 bytes!!
-                 */
-                if (old && (data[i] == old[i]))
-                        continue;
-                word = le32_to_cpu(data[i]);
-                ar9170_regwrite(AR9170_BEACON_BUFFER_ADDRESS + 4 * i, word);
-        }
-        /* XXX: use skb->cb info */
-        if (ar->hw->conf.channel->band == IEEE80211_BAND_2GHZ)
-                ar9170_regwrite(AR9170_MAC_REG_BCN_PLCP,
-                                ((skb->len + 4) << (3 + 16)) + 0x0400);
-        else
-                ar9170_regwrite(AR9170_MAC_REG_BCN_PLCP,
-                                ((skb->len + 4) << 16) + 0x001b);
-        ar9170_regwrite(AR9170_MAC_REG_BCN_LENGTH, skb->len + 4);
-        ar9170_regwrite(AR9170_MAC_REG_BCN_ADDR, AR9170_BEACON_BUFFER_ADDRESS);
-        ar9170_regwrite(AR9170_MAC_REG_BCN_CTRL, 1);
-        ar9170_regwrite_finish();
-        dev_kfree_skb(ar->beacon);
-        ar->beacon = skb;
-        return ar9170_regwrite_result();
-}
-void ar9170_new_beacon(struct work_struct *work)
-{
-        struct ar9170 *ar = container_of(work, struct ar9170,
-                                         beacon_work);
-        struct sk_buff *skb;
-        if (unlikely(!IS_STARTED(ar)))
-                return ;
-        mutex_lock(&ar->mutex);
-        if (!ar->vif)
-                goto out;
-        ar9170_update_beacon(ar);
-        rcu_read_lock();
-        while ((skb = ieee80211_get_buffered_bc(ar->hw, ar->vif)))
-                ar9170_op_tx(ar->hw, skb);
-        rcu_read_unlock();
- out:
-        mutex_unlock(&ar->mutex);
-}
-int ar9170_upload_key(struct ar9170 *ar, u8 id, const u8 *mac, u8 ktype,
-                      u8 keyidx, u8 *keydata, int keylen)
-{
-        __le32 vals[7];
-        static const u8 bcast[ETH_ALEN] =
-                { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
-        u8 dummy;
-        mac = mac ? : bcast;
-        vals[0] = cpu_to_le32((keyidx << 16) + id);
-        vals[1] = cpu_to_le32(mac[1] << 24 | mac[0] << 16 | ktype);
-        vals[2] = cpu_to_le32(mac[5] << 24 | mac[4] << 16 |
-                              mac[3] << 8 | mac[2]);
-        memset(&vals[3], 0, 16);
-        if (keydata)
-                memcpy(&vals[3], keydata, keylen);
-        return ar->exec_cmd(ar, AR9170_CMD_EKEY,
-                            sizeof(vals), (u8 *)vals,
-                            1, &dummy);
-}
-int ar9170_disable_key(struct ar9170 *ar, u8 id)
-{
-        __le32 val = cpu_to_le32(id);
-        u8 dummy;
-        return ar->exec_cmd(ar, AR9170_CMD_EKEY,
-                            sizeof(val), (u8 *)&val,
-                            1, &dummy);
-}
diff --git a/drivers/net/wireless/ath/ar9170/main.c b/drivers/net/wireless/ath/ar9170/main.c
deleted file mode 100644
index ccc2edaaeda0..000000000000
--- a/drivers/net/wireless/ath/ar9170/main.c
+++ /dev/null
@@ -1,2190 +0,0 @@
-/*
- * Atheros AR9170 driver
- *
- * mac80211 interaction code
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- * Copyright 2009, Christian Lamparter <chunkeey@web.de>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#include <linux/init.h>
-#include <linux/slab.h>
-#include <linux/module.h>
-#include <linux/etherdevice.h>
-#include <net/mac80211.h>
-#include "ar9170.h"
-#include "hw.h"
-#include "cmd.h"
-static int modparam_nohwcrypt;
-module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
-MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
-#define RATE(_bitrate, _hw_rate, _txpidx, _flags) {     \
-        .bitrate        = (_bitrate),                   \
-        .flags          = (_flags),                     \
-        .hw_value       = (_hw_rate) | (_txpidx) << 4,  \
-}
-static struct ieee80211_rate __ar9170_ratetable[] = {
-        RATE(10, 0, 0, 0),
-        RATE(20, 1, 1, IEEE80211_RATE_SHORT_PREAMBLE),
-        RATE(55, 2, 2, IEEE80211_RATE_SHORT_PREAMBLE),
-        RATE(110, 3, 3, IEEE80211_RATE_SHORT_PREAMBLE),
-        RATE(60, 0xb, 0, 0),
-        RATE(90, 0xf, 0, 0),
-        RATE(120, 0xa, 0, 0),
-        RATE(180, 0xe, 0, 0),
-        RATE(240, 0x9, 0, 0),
-        RATE(360, 0xd, 1, 0),
-        RATE(480, 0x8, 2, 0),
-        RATE(540, 0xc, 3, 0),
-};
-#undef RATE
-#define ar9170_g_ratetable      (__ar9170_ratetable + 0)
-#define ar9170_g_ratetable_size 12
-#define ar9170_a_ratetable      (__ar9170_ratetable + 4)
-#define ar9170_a_ratetable_size 8
-/*
- * NB: The hw_value is used as an index into the ar9170_phy_freq_params
- *     array in phy.c so that we don't have to do frequency lookups!
- */
-#define CHAN(_freq, _idx) {             \
-        .center_freq    = (_freq),      \
-        .hw_value       = (_idx),       \
-        .max_power      = 18, /* XXX */ \
-}
-static struct ieee80211_channel ar9170_2ghz_chantable[] = {
-        CHAN(2412,  0),
-        CHAN(2417,  1),
-        CHAN(2422,  2),
-        CHAN(2427,  3),
-        CHAN(2432,  4),
-        CHAN(2437,  5),
-        CHAN(2442,  6),
-        CHAN(2447,  7),
-        CHAN(2452,  8),
-        CHAN(2457,  9),
-        CHAN(2462, 10),
-        CHAN(2467, 11),
-        CHAN(2472, 12),
-        CHAN(2484, 13),
-};
-static struct ieee80211_channel ar9170_5ghz_chantable[] = {
-        CHAN(4920, 14),
-        CHAN(4940, 15),
-        CHAN(4960, 16),
-        CHAN(4980, 17),
-        CHAN(5040, 18),
-        CHAN(5060, 19),
-        CHAN(5080, 20),
-        CHAN(5180, 21),
-        CHAN(5200, 22),
-        CHAN(5220, 23),
-        CHAN(5240, 24),
-        CHAN(5260, 25),
-        CHAN(5280, 26),
-        CHAN(5300, 27),
-        CHAN(5320, 28),
-        CHAN(5500, 29),
-        CHAN(5520, 30),
-        CHAN(5540, 31),
-        CHAN(5560, 32),
-        CHAN(5580, 33),
-        CHAN(5600, 34),
-        CHAN(5620, 35),
-        CHAN(5640, 36),
-        CHAN(5660, 37),
-        CHAN(5680, 38),
-        CHAN(5700, 39),
-        CHAN(5745, 40),
-        CHAN(5765, 41),
-        CHAN(5785, 42),
-        CHAN(5805, 43),
-        CHAN(5825, 44),
-        CHAN(5170, 45),
-        CHAN(5190, 46),
-        CHAN(5210, 47),
-        CHAN(5230, 48),
-};
-#undef CHAN
-#define AR9170_HT_CAP                                                   \
-{                                                                       \
-        .ht_supported   = true,                                         \
-        .cap            = IEEE80211_HT_CAP_MAX_AMSDU |                  \
-                          IEEE80211_HT_CAP_SUP_WIDTH_20_40 |            \
-                          IEEE80211_HT_CAP_SGI_40 |                     \
-                          IEEE80211_HT_CAP_GRN_FLD |                    \
-                          IEEE80211_HT_CAP_DSSSCCK40 |                  \
-                          IEEE80211_HT_CAP_SM_PS,                       \
-        .ampdu_factor   = 3,                                            \
-        .ampdu_density  = 6,                                            \
-        .mcs            = {                                             \
-                .rx_mask = { 0xff, 0xff, 0, 0, 0x1, 0, 0, 0, 0, 0, },   \
-                .rx_highest = cpu_to_le16(300),                         \
-                .tx_params = IEEE80211_HT_MCS_TX_DEFINED,               \
-        },                                                              \
-}
-static struct ieee80211_supported_band ar9170_band_2GHz = {
-        .channels       = ar9170_2ghz_chantable,
-        .n_channels     = ARRAY_SIZE(ar9170_2ghz_chantable),
-        .bitrates       = ar9170_g_ratetable,
-        .n_bitrates     = ar9170_g_ratetable_size,
-        .ht_cap         = AR9170_HT_CAP,
-};
-static struct ieee80211_supported_band ar9170_band_5GHz = {
-        .channels       = ar9170_5ghz_chantable,
-        .n_channels     = ARRAY_SIZE(ar9170_5ghz_chantable),
-        .bitrates       = ar9170_a_ratetable,
-        .n_bitrates     = ar9170_a_ratetable_size,
-        .ht_cap         = AR9170_HT_CAP,
-};
-static void ar9170_tx(struct ar9170 *ar);
-static inline u16 ar9170_get_seq_h(struct ieee80211_hdr *hdr)
-{
-        return le16_to_cpu(hdr->seq_ctrl) >> 4;
-}
-static inline u16 ar9170_get_seq(struct sk_buff *skb)
-{
-        struct ar9170_tx_control *txc = (void *) skb->data;
-        return ar9170_get_seq_h((void *) txc->frame_data);
-}
-#ifdef AR9170_QUEUE_DEBUG
-static void ar9170_print_txheader(struct ar9170 *ar, struct sk_buff *skb)
-{
-        struct ar9170_tx_control *txc = (void *) skb->data;
-        struct ieee80211_tx_info *txinfo = IEEE80211_SKB_CB(skb);
-        struct ar9170_tx_info *arinfo = (void *) txinfo->rate_driver_data;
-        struct ieee80211_hdr *hdr = (void *) txc->frame_data;
-        wiphy_debug(ar->hw->wiphy,
-                    "=> FRAME [skb:%p, q:%d, DA:[%pM] s:%d "
-                    "mac_ctrl:%04x, phy_ctrl:%08x, timeout:[%d ms]]\n",
-                    skb, skb_get_queue_mapping(skb),
-                    ieee80211_get_DA(hdr), ar9170_get_seq_h(hdr),
-                    le16_to_cpu(txc->mac_control), le32_to_cpu(txc->phy_control),
-                    jiffies_to_msecs(arinfo->timeout - jiffies));
-}
-static void __ar9170_dump_txqueue(struct ar9170 *ar,
-                                struct sk_buff_head *queue)
-{
-        struct sk_buff *skb;
-        int i = 0;
-        printk(KERN_DEBUG "---[ cut here ]---\n");
-        wiphy_debug(ar->hw->wiphy, "%d entries in queue.\n",
-                    skb_queue_len(queue));
-        skb_queue_walk(queue, skb) {
-                printk(KERN_DEBUG "index:%d =>\n", i++);
-                ar9170_print_txheader(ar, skb);
-        }
-        if (i != skb_queue_len(queue))
-                printk(KERN_DEBUG "WARNING: queue frame counter "
-                       "mismatch %d != %d\n", skb_queue_len(queue), i);
-        printk(KERN_DEBUG "---[ end ]---\n");
-}
-#endif /* AR9170_QUEUE_DEBUG */
-#ifdef AR9170_QUEUE_DEBUG
-static void ar9170_dump_txqueue(struct ar9170 *ar,
-                                struct sk_buff_head *queue)
-{
-        unsigned long flags;
-        spin_lock_irqsave(&queue->lock, flags);
-        __ar9170_dump_txqueue(ar, queue);
-        spin_unlock_irqrestore(&queue->lock, flags);
-}
-#endif /* AR9170_QUEUE_DEBUG */
-#ifdef AR9170_QUEUE_STOP_DEBUG
-static void __ar9170_dump_txstats(struct ar9170 *ar)
-{
-        int i;
-        wiphy_debug(ar->hw->wiphy, "QoS queue stats\n");
-        for (i = 0; i < __AR9170_NUM_TXQ; i++)
-                wiphy_debug(ar->hw->wiphy,
-                            "queue:%d limit:%d len:%d waitack:%d stopped:%d\n",
-                            i, ar->tx_stats[i].limit, ar->tx_stats[i].len,
-                            skb_queue_len(&ar->tx_status[i]),
-                            ieee80211_queue_stopped(ar->hw, i));
-}
-#endif /* AR9170_QUEUE_STOP_DEBUG */
-/* caller must guarantee exclusive access for _bin_ queue. */
-static void ar9170_recycle_expired(struct ar9170 *ar,
-                                   struct sk_buff_head *queue,
-                                   struct sk_buff_head *bin)
-{
-        struct sk_buff *skb, *old = NULL;
-        unsigned long flags;
-        spin_lock_irqsave(&queue->lock, flags);
-        while ((skb = skb_peek(queue))) {
-                struct ieee80211_tx_info *txinfo;
-                struct ar9170_tx_info *arinfo;
-                txinfo = IEEE80211_SKB_CB(skb);
-                arinfo = (void *) txinfo->rate_driver_data;
-                if (time_is_before_jiffies(arinfo->timeout)) {
-#ifdef AR9170_QUEUE_DEBUG
-                        wiphy_debug(ar->hw->wiphy,
-                                    "[%ld > %ld] frame expired => recycle\n",
-                                    jiffies, arinfo->timeout);
-                        ar9170_print_txheader(ar, skb);
-#endif /* AR9170_QUEUE_DEBUG */
-                        __skb_unlink(skb, queue);
-                        __skb_queue_tail(bin, skb);
-                } else {
-                        break;
-                }
-                if (unlikely(old == skb)) {
-                        /* bail out - queue is shot. */
-                        WARN_ON(1);
-                        break;
-                }
-                old = skb;
-        }
-        spin_unlock_irqrestore(&queue->lock, flags);
-}
-static void ar9170_tx_status(struct ar9170 *ar, struct sk_buff *skb,
-                                    u16 tx_status)
-{
-        struct ieee80211_tx_info *txinfo;
-        unsigned int retries = 0;
-        txinfo = IEEE80211_SKB_CB(skb);
-        ieee80211_tx_info_clear_status(txinfo);
-        switch (tx_status) {
-        case AR9170_TX_STATUS_RETRY:
-                retries = 2;
-        case AR9170_TX_STATUS_COMPLETE:
-                txinfo->flags |= IEEE80211_TX_STAT_ACK;
-                break;
-        case AR9170_TX_STATUS_FAILED:
-                retries = ar->hw->conf.long_frame_max_tx_count;
-                break;
-        default:
-                wiphy_err(ar->hw->wiphy,
-                          "invalid tx_status response (%x)\n", tx_status);
-                break;
-        }
-        txinfo->status.rates[0].count = retries + 1;
-        skb_pull(skb, sizeof(struct ar9170_tx_control));
-        ieee80211_tx_status_irqsafe(ar->hw, skb);
-}
-void ar9170_tx_callback(struct ar9170 *ar, struct sk_buff *skb)
-{
-        struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
-        struct ar9170_tx_info *arinfo = (void *) info->rate_driver_data;
-        unsigned int queue = skb_get_queue_mapping(skb);
-        unsigned long flags;
-        spin_lock_irqsave(&ar->tx_stats_lock, flags);
-        ar->tx_stats[queue].len--;
-        if (ar->tx_stats[queue].len < AR9170_NUM_TX_LIMIT_SOFT) {
-#ifdef AR9170_QUEUE_STOP_DEBUG
-                wiphy_debug(ar->hw->wiphy, "wake queue %d\n", queue);
-                __ar9170_dump_txstats(ar);
-#endif /* AR9170_QUEUE_STOP_DEBUG */
-                ieee80211_wake_queue(ar->hw, queue);
-        }
-        spin_unlock_irqrestore(&ar->tx_stats_lock, flags);
-        if (info->flags & IEEE80211_TX_CTL_NO_ACK) {
-                ar9170_tx_status(ar, skb, AR9170_TX_STATUS_FAILED);
-        } else {
-                arinfo->timeout = jiffies +
-                          msecs_to_jiffies(AR9170_TX_TIMEOUT);
-                skb_queue_tail(&ar->tx_status[queue], skb);
-        }
-        if (!ar->tx_stats[queue].len &&
-            !skb_queue_empty(&ar->tx_pending[queue])) {
-                ar9170_tx(ar);
-        }
-}
-static struct sk_buff *ar9170_get_queued_skb(struct ar9170 *ar,
-                                             const u8 *mac,
-                                             struct sk_buff_head *queue,
-                                             const u32 rate)
-{
-        unsigned long flags;
-        struct sk_buff *skb;
-        /*
-         * Unfortunately, the firmware does not tell to which (queued) frame
-         * this transmission status report belongs to.
-         *
-         * So we have to make risky guesses - with the scarce information
-         * the firmware provided (-> destination MAC, and phy_control) -
-         * and hope that we picked the right one...
-         */
-        spin_lock_irqsave(&queue->lock, flags);
-        skb_queue_walk(queue, skb) {
-                struct ar9170_tx_control *txc = (void *) skb->data;
-                struct ieee80211_hdr *hdr = (void *) txc->frame_data;
-                u32 r;
-                if (mac && compare_ether_addr(ieee80211_get_DA(hdr), mac)) {
-#ifdef AR9170_QUEUE_DEBUG
-                        wiphy_debug(ar->hw->wiphy,
-                                    "skip frame => DA %pM != %pM\n",
-                                    mac, ieee80211_get_DA(hdr));
-                        ar9170_print_txheader(ar, skb);
-#endif /* AR9170_QUEUE_DEBUG */
-                        continue;
-                }
-                r = (le32_to_cpu(txc->phy_control) & AR9170_TX_PHY_MCS_MASK) >>
-                    AR9170_TX_PHY_MCS_SHIFT;
-                if ((rate != AR9170_TX_INVALID_RATE) && (r != rate)) {
-#ifdef AR9170_QUEUE_DEBUG
-                        wiphy_debug(ar->hw->wiphy,
-                                    "skip frame => rate %d != %d\n", rate, r);
-                        ar9170_print_txheader(ar, skb);
-#endif /* AR9170_QUEUE_DEBUG */
-                        continue;
-                }
-                __skb_unlink(skb, queue);
-                spin_unlock_irqrestore(&queue->lock, flags);
-                return skb;
-        }
-#ifdef AR9170_QUEUE_DEBUG
-        wiphy_err(ar->hw->wiphy,
-                  "ESS:[%pM] does not have any outstanding frames in queue.\n",
-                  mac);
-        __ar9170_dump_txqueue(ar, queue);
-#endif /* AR9170_QUEUE_DEBUG */
-        spin_unlock_irqrestore(&queue->lock, flags);
-        return NULL;
-}
-/*
- * This worker tries to keeps an maintain tx_status queues.
- * So we can guarantee that incoming tx_status reports are
- * actually for a pending frame.
- */
-static void ar9170_tx_janitor(struct work_struct *work)
-{
-        struct ar9170 *ar = container_of(work, struct ar9170,
-                                         tx_janitor.work);
-        struct sk_buff_head waste;
-        unsigned int i;
-        bool resched = false;
-        if (unlikely(!IS_STARTED(ar)))
-                return ;
-        skb_queue_head_init(&waste);
-        for (i = 0; i < __AR9170_NUM_TXQ; i++) {
-#ifdef AR9170_QUEUE_DEBUG
-                wiphy_debug(ar->hw->wiphy, "garbage collector scans queue:%d\n",
-                            i);
-                ar9170_dump_txqueue(ar, &ar->tx_pending[i]);
-                ar9170_dump_txqueue(ar, &ar->tx_status[i]);
-#endif /* AR9170_QUEUE_DEBUG */
-                ar9170_recycle_expired(ar, &ar->tx_status[i], &waste);
-                ar9170_recycle_expired(ar, &ar->tx_pending[i], &waste);
-                skb_queue_purge(&waste);
-                if (!skb_queue_empty(&ar->tx_status[i]) ||
-                    !skb_queue_empty(&ar->tx_pending[i]))
-                        resched = true;
-        }
-        if (!resched)
-                return;
-        ieee80211_queue_delayed_work(ar->hw,
-                                     &ar->tx_janitor,
-                                     msecs_to_jiffies(AR9170_JANITOR_DELAY));
-}
-void ar9170_handle_command_response(struct ar9170 *ar, void *buf, u32 len)
-{
-        struct ar9170_cmd_response *cmd = (void *) buf;
-        if ((cmd->type & 0xc0) != 0xc0) {
-                ar->callback_cmd(ar, len, buf);
-                return;
-        }
-        /* hardware event handlers */
-        switch (cmd->type) {
-        case 0xc1: {
-                /*
-                 * TX status notification:
-                 * bytes: 0c c1 XX YY M1 M2 M3 M4 M5 M6 R4 R3 R2 R1 S2 S1
-                 *
-                 * XX always 81
-                 * YY always 00
-                 * M1-M6 is the MAC address
-                 * R1-R4 is the transmit rate
-                 * S1-S2 is the transmit status
-                 */
-                struct sk_buff *skb;
-                u32 phy = le32_to_cpu(cmd->tx_status.rate);
-                u32 q = (phy & AR9170_TX_PHY_QOS_MASK) >>
-                        AR9170_TX_PHY_QOS_SHIFT;
-#ifdef AR9170_QUEUE_DEBUG
-                wiphy_debug(ar->hw->wiphy,
-                            "recv tx_status for %pm, p:%08x, q:%d\n",
-                            cmd->tx_status.dst, phy, q);
-#endif /* AR9170_QUEUE_DEBUG */
-                skb = ar9170_get_queued_skb(ar, cmd->tx_status.dst,
-                                            &ar->tx_status[q],
-                                            AR9170_TX_INVALID_RATE);
-                if (unlikely(!skb))
-                        return ;
-                ar9170_tx_status(ar, skb, le16_to_cpu(cmd->tx_status.status));
-                break;
-                }
-        case 0xc0:
-                /*
-                 * pre-TBTT event
-                 */
-                if (ar->vif && ar->vif->type == NL80211_IFTYPE_AP)
-                        ieee80211_queue_work(ar->hw, &ar->beacon_work);
-                break;
-        case 0xc2:
-                /*
-                 * (IBSS) beacon send notification
-                 * bytes: 04 c2 XX YY B4 B3 B2 B1
-                 *
-                 * XX always 80
-                 * YY always 00
-                 * B1-B4 "should" be the number of send out beacons.
-                 */
-                break;
-        case 0xc3:
-                /* End of Atim Window */
-                break;
-        case 0xc4:
-                /* BlockACK bitmap */
-                break;
-        case 0xc5:
-                /* BlockACK events */
-                break;
-        case 0xc6:
-                /* Watchdog Interrupt */
-                break;
-        case 0xc9:
-                /* retransmission issue / SIFS/EIFS collision ?! */
-                break;
-        /* firmware debug */
-        case 0xca:
-                printk(KERN_DEBUG "ar9170 FW: %.*s\n", len - 4,
-                                (char *)buf + 4);
-                break;
-        case 0xcb:
-                len -= 4;
-                switch (len) {
-                case 1:
-                        printk(KERN_DEBUG "ar9170 FW: u8: %#.2x\n",
-                                *((char *)buf + 4));
-                        break;
-                case 2:
-                        printk(KERN_DEBUG "ar9170 FW: u8: %#.4x\n",
-                                le16_to_cpup((__le16 *)((char *)buf + 4)));
-                        break;
-                case 4:
-                        printk(KERN_DEBUG "ar9170 FW: u8: %#.8x\n",
-                                le32_to_cpup((__le32 *)((char *)buf + 4)));
-                        break;
-                case 8:
-                        printk(KERN_DEBUG "ar9170 FW: u8: %#.16lx\n",
-                                (unsigned long)le64_to_cpup(
-                                                (__le64 *)((char *)buf + 4)));
-                        break;
-                }
-                break;
-        case 0xcc:
-                print_hex_dump_bytes("ar9170 FW:", DUMP_PREFIX_NONE,
-                                     (char *)buf + 4, len - 4);
-                break;
-        default:
-                pr_info("received unhandled event %x\n", cmd->type);
-                print_hex_dump_bytes("dump:", DUMP_PREFIX_NONE, buf, len);
-                break;
-        }
-}
-static void ar9170_rx_reset_rx_mpdu(struct ar9170 *ar)
-{
-        memset(&ar->rx_mpdu.plcp, 0, sizeof(struct ar9170_rx_head));
-        ar->rx_mpdu.has_plcp = false;
-}
-int ar9170_nag_limiter(struct ar9170 *ar)
-{
-        bool print_message;
-        /*
-         * we expect all sorts of errors in promiscuous mode.
-         * don't bother with it, it's OK!
-         */
-        if (ar->sniffer_enabled)
-                return false;
-        /*
-         * only go for frequent errors! The hardware tends to
-         * do some stupid thing once in a while under load, in
-         * noisy environments or just for fun!
-         */
-        if (time_before(jiffies, ar->bad_hw_nagger) && net_ratelimit())
-                print_message = true;
-        else
-                print_message = false;
-        /* reset threshold for "once in a while" */
-        ar->bad_hw_nagger = jiffies + HZ / 4;
-        return print_message;
-}
-static int ar9170_rx_mac_status(struct ar9170 *ar,
-                                struct ar9170_rx_head *head,
-                                struct ar9170_rx_macstatus *mac,
-                                struct ieee80211_rx_status *status)
-{
-        u8 error, decrypt;
-        BUILD_BUG_ON(sizeof(struct ar9170_rx_head) != 12);
-        BUILD_BUG_ON(sizeof(struct ar9170_rx_macstatus) != 4);
-        error = mac->error;
-        if (error & AR9170_RX_ERROR_MMIC) {
-                status->flag |= RX_FLAG_MMIC_ERROR;
-                error &= ~AR9170_RX_ERROR_MMIC;
-        }
-        if (error & AR9170_RX_ERROR_PLCP) {
-                status->flag |= RX_FLAG_FAILED_PLCP_CRC;
-                error &= ~AR9170_RX_ERROR_PLCP;
-                if (!(ar->filter_state & FIF_PLCPFAIL))
-                        return -EINVAL;
-        }
-        if (error & AR9170_RX_ERROR_FCS) {
-                status->flag |= RX_FLAG_FAILED_FCS_CRC;
-                error &= ~AR9170_RX_ERROR_FCS;
-                if (!(ar->filter_state & FIF_FCSFAIL))
-                        return -EINVAL;
-        }
-        decrypt = ar9170_get_decrypt_type(mac);
-        if (!(decrypt & AR9170_RX_ENC_SOFTWARE) &&
-            decrypt != AR9170_ENC_ALG_NONE)
-                status->flag |= RX_FLAG_DECRYPTED;
-        /* ignore wrong RA errors */
-        error &= ~AR9170_RX_ERROR_WRONG_RA;
-        if (error & AR9170_RX_ERROR_DECRYPT) {
-                error &= ~AR9170_RX_ERROR_DECRYPT;
-                /*
-                 * Rx decryption is done in place,
-                 * the original data is lost anyway.
-                 */
-                return -EINVAL;
-        }
-        /* drop any other error frames */
-        if (unlikely(error)) {
-                /* TODO: update netdevice's RX dropped/errors statistics */
-                if (ar9170_nag_limiter(ar))
-                        wiphy_debug(ar->hw->wiphy,
-                                    "received frame with suspicious error code (%#x).\n",
-                                    error);
-                return -EINVAL;
-        }
-        status->band = ar->channel->band;
-        status->freq = ar->channel->center_freq;
-        switch (mac->status & AR9170_RX_STATUS_MODULATION_MASK) {
-        case AR9170_RX_STATUS_MODULATION_CCK:
-                if (mac->status & AR9170_RX_STATUS_SHORT_PREAMBLE)
-                        status->flag |= RX_FLAG_SHORTPRE;
-                switch (head->plcp[0]) {
-                case 0x0a:
-                        status->rate_idx = 0;
-                        break;
-                case 0x14:
-                        status->rate_idx = 1;
-                        break;
-                case 0x37:
-                        status->rate_idx = 2;
-                        break;
-                case 0x6e:
-                        status->rate_idx = 3;
-                        break;
-                default:
-                        if (ar9170_nag_limiter(ar))
-                                wiphy_err(ar->hw->wiphy,
-                                          "invalid plcp cck rate (%x).\n",
-                                          head->plcp[0]);
-                        return -EINVAL;
-                }
-                break;
-        case AR9170_RX_STATUS_MODULATION_DUPOFDM:
-        case AR9170_RX_STATUS_MODULATION_OFDM:
-                switch (head->plcp[0] & 0xf) {
-                case 0xb:
-                        status->rate_idx = 0;
-                        break;
-                case 0xf:
-                        status->rate_idx = 1;
-                        break;
-                case 0xa:
-                        status->rate_idx = 2;
-                        break;
-                case 0xe:
-                        status->rate_idx = 3;
-                        break;
-                case 0x9:
-                        status->rate_idx = 4;
-                        break;
-                case 0xd:
-                        status->rate_idx = 5;
-                        break;
-                case 0x8:
-                        status->rate_idx = 6;
-                        break;
-                case 0xc:
-                        status->rate_idx = 7;
-                        break;
-                default:
-                        if (ar9170_nag_limiter(ar))
-                                wiphy_err(ar->hw->wiphy,
-                                          "invalid plcp ofdm rate (%x).\n",
-                                          head->plcp[0]);
-                        return -EINVAL;
-                }
-                if (status->band == IEEE80211_BAND_2GHZ)
-                        status->rate_idx += 4;
-                break;
-        case AR9170_RX_STATUS_MODULATION_HT:
-                if (head->plcp[3] & 0x80)
-                        status->flag |= RX_FLAG_40MHZ;
-                if (head->plcp[6] & 0x80)
-                        status->flag |= RX_FLAG_SHORT_GI;
-                status->rate_idx = clamp(0, 75, head->plcp[6] & 0x7f);
-                status->flag |= RX_FLAG_HT;
-                break;
-        default:
-                if (ar9170_nag_limiter(ar))
-                        wiphy_err(ar->hw->wiphy, "invalid modulation\n");
-                return -EINVAL;
-        }
-        return 0;
-}
-static void ar9170_rx_phy_status(struct ar9170 *ar,
-                                 struct ar9170_rx_phystatus *phy,
-                                 struct ieee80211_rx_status *status)
-{
-        int i;
-        BUILD_BUG_ON(sizeof(struct ar9170_rx_phystatus) != 20);
-        for (i = 0; i < 3; i++)
-                if (phy->rssi[i] != 0x80)
-                        status->antenna |= BIT(i);
-        /* post-process RSSI */
-        for (i = 0; i < 7; i++)
-                if (phy->rssi[i] & 0x80)
-                        phy->rssi[i] = ((phy->rssi[i] & 0x7f) + 1) & 0x7f;
-        /* TODO: we could do something with phy_errors */
-        status->signal = ar->noise[0] + phy->rssi_combined;
-}
-static struct sk_buff *ar9170_rx_copy_data(u8 *buf, int len)
-{
-        struct sk_buff *skb;
-        int reserved = 0;
-        struct ieee80211_hdr *hdr = (void *) buf;
-        if (ieee80211_is_data_qos(hdr->frame_control)) {
-                u8 *qc = ieee80211_get_qos_ctl(hdr);
-                reserved += NET_IP_ALIGN;
-                if (*qc & IEEE80211_QOS_CONTROL_A_MSDU_PRESENT)
-                        reserved += NET_IP_ALIGN;
-        }
-        if (ieee80211_has_a4(hdr->frame_control))
-                reserved += NET_IP_ALIGN;
-        reserved = 32 + (reserved & NET_IP_ALIGN);
-        skb = dev_alloc_skb(len + reserved);
-        if (likely(skb)) {
-                skb_reserve(skb, reserved);
-                memcpy(skb_put(skb, len), buf, len);
-        }
-        return skb;
-}
-/*
- * If the frame alignment is right (or the kernel has
- * CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS), and there
- * is only a single MPDU in the USB frame, then we could
- * submit to mac80211 the SKB directly. However, since
- * there may be multiple packets in one SKB in stream
- * mode, and we need to observe the proper ordering,
- * this is non-trivial.
- */
-static void ar9170_handle_mpdu(struct ar9170 *ar, u8 *buf, int len)
-{
-        struct ar9170_rx_head *head;
-        struct ar9170_rx_macstatus *mac;
-        struct ar9170_rx_phystatus *phy = NULL;
-        struct ieee80211_rx_status status;
-        struct sk_buff *skb;
-        int mpdu_len;
-        if (unlikely(!IS_STARTED(ar) || len < (sizeof(*mac))))
-                return ;
-        /* Received MPDU */
-        mpdu_len = len - sizeof(*mac);
-        mac = (void *)(buf + mpdu_len);
-        if (unlikely(mac->error & AR9170_RX_ERROR_FATAL)) {
-                /* this frame is too damaged and can't be used - drop it */
-                return ;
-        }
-        switch (mac->status & AR9170_RX_STATUS_MPDU_MASK) {
-        case AR9170_RX_STATUS_MPDU_FIRST:
-                /* first mpdu packet has the plcp header */
-                if (likely(mpdu_len >= sizeof(struct ar9170_rx_head))) {
-                        head = (void *) buf;
-                        memcpy(&ar->rx_mpdu.plcp, (void *) buf,
-                               sizeof(struct ar9170_rx_head));
-                        mpdu_len -= sizeof(struct ar9170_rx_head);
-                        buf += sizeof(struct ar9170_rx_head);
-                        ar->rx_mpdu.has_plcp = true;
-                } else {
-                        if (ar9170_nag_limiter(ar))
-                                wiphy_err(ar->hw->wiphy,
-                                          "plcp info is clipped.\n");
-                        return ;
-                }
-                break;
-        case AR9170_RX_STATUS_MPDU_LAST:
-                /* last mpdu has a extra tail with phy status information */
-                if (likely(mpdu_len >= sizeof(struct ar9170_rx_phystatus))) {
-                        mpdu_len -= sizeof(struct ar9170_rx_phystatus);
-                        phy = (void *)(buf + mpdu_len);
-                } else {
-                        if (ar9170_nag_limiter(ar))
-                                wiphy_err(ar->hw->wiphy,
-                                          "frame tail is clipped.\n");
-                        return ;
-                }
-        case AR9170_RX_STATUS_MPDU_MIDDLE:
-                /* middle mpdus are just data */
-                if (unlikely(!ar->rx_mpdu.has_plcp)) {
-                        if (!ar9170_nag_limiter(ar))
-                                return ;
-                        wiphy_err(ar->hw->wiphy,
-                                  "rx stream did not start with a first_mpdu frame tag.\n");
-                        return ;
-                }
-                head = &ar->rx_mpdu.plcp;
-                break;
-        case AR9170_RX_STATUS_MPDU_SINGLE:
-                /* single mpdu - has plcp (head) and phy status (tail) */
-                head = (void *) buf;
-                mpdu_len -= sizeof(struct ar9170_rx_head);
-                mpdu_len -= sizeof(struct ar9170_rx_phystatus);
-                buf += sizeof(struct ar9170_rx_head);
-                phy = (void *)(buf + mpdu_len);
-                break;
-        default:
-                BUG_ON(1);
-                break;
-        }
-        if (unlikely(mpdu_len < FCS_LEN))
-                return ;
-        memset(&status, 0, sizeof(status));
-        if (unlikely(ar9170_rx_mac_status(ar, head, mac, &status)))
-                return ;
-        if (phy)
-                ar9170_rx_phy_status(ar, phy, &status);
-        skb = ar9170_rx_copy_data(buf, mpdu_len);
-        if (likely(skb)) {
-                memcpy(IEEE80211_SKB_RXCB(skb), &status, sizeof(status));
-                ieee80211_rx_irqsafe(ar->hw, skb);
-        }
-}
-void ar9170_rx(struct ar9170 *ar, struct sk_buff *skb)
-{
-        unsigned int i, tlen, resplen, wlen = 0, clen = 0;
-        u8 *tbuf, *respbuf;
-        tbuf = skb->data;
-        tlen = skb->len;
-        while (tlen >= 4) {
-                clen = tbuf[1] << 8 | tbuf[0];
-                wlen = ALIGN(clen, 4);
-                /* check if this is stream has a valid tag.*/
-                if (tbuf[2] != 0 || tbuf[3] != 0x4e) {
-                        /*
-                         * TODO: handle the highly unlikely event that the
-                         * corrupted stream has the TAG at the right position.
-                         */
-                        /* check if the frame can be repaired. */
-                        if (!ar->rx_failover_missing) {
-                                /* this is no "short read". */
-                                if (ar9170_nag_limiter(ar)) {
-                                        wiphy_err(ar->hw->wiphy,
-                                                  "missing tag!\n");
-                                        goto err_telluser;
-                                } else
-                                        goto err_silent;
-                        }
-                        if (ar->rx_failover_missing > tlen) {
-                                if (ar9170_nag_limiter(ar)) {
-                                        wiphy_err(ar->hw->wiphy,
-                                                  "possible multi stream corruption!\n");
-                                        goto err_telluser;
-                                } else
-                                        goto err_silent;
-                        }
-                        memcpy(skb_put(ar->rx_failover, tlen), tbuf, tlen);
-                        ar->rx_failover_missing -= tlen;
-                        if (ar->rx_failover_missing <= 0) {
-                                /*
-                                 * nested ar9170_rx call!
-                                 * termination is guaranteed, even when the
-                                 * combined frame also have a element with
-                                 * a bad tag.
-                                 */
-                                ar->rx_failover_missing = 0;
-                                ar9170_rx(ar, ar->rx_failover);
-                                skb_reset_tail_pointer(ar->rx_failover);
-                                skb_trim(ar->rx_failover, 0);
-                        }
-                        return ;
-                }
-                /* check if stream is clipped */
-                if (wlen > tlen - 4) {
-                        if (ar->rx_failover_missing) {
-                                /* TODO: handle double stream corruption. */
-                                if (ar9170_nag_limiter(ar)) {
-                                        wiphy_err(ar->hw->wiphy,
-                                                  "double rx stream corruption!\n");
-                                        goto err_telluser;
-                                } else
-                                        goto err_silent;
-                        }
-                        /*
-                         * save incomplete data set.
-                         * the firmware will resend the missing bits when
-                         * the rx - descriptor comes round again.
-                         */
-                        memcpy(skb_put(ar->rx_failover, tlen), tbuf, tlen);
-                        ar->rx_failover_missing = clen - tlen;
-                        return ;
-                }
-                resplen = clen;
-                respbuf = tbuf + 4;
-                tbuf += wlen + 4;
-                tlen -= wlen + 4;
-                i = 0;
-                /* weird thing, but this is the same in the original driver */
-                while (resplen > 2 && i < 12 &&
-                       respbuf[0] == 0xff && respbuf[1] == 0xff) {
-                        i += 2;
-                        resplen -= 2;
-                        respbuf += 2;
-                }
-                if (resplen < 4)
-                        continue;
-                /* found the 6 * 0xffff marker? */
-                if (i == 12)
-                        ar9170_handle_command_response(ar, respbuf, resplen);
-                else
-                        ar9170_handle_mpdu(ar, respbuf, clen);
-        }
-        if (tlen) {
-                if (net_ratelimit())
-                        wiphy_err(ar->hw->wiphy,
-                                  "%d bytes of unprocessed data left in rx stream!\n",
-                                  tlen);
-                goto err_telluser;
-        }
-        return ;
-err_telluser:
-        wiphy_err(ar->hw->wiphy,
-                  "damaged RX stream data [want:%d, data:%d, rx:%d, pending:%d ]\n",
-                  clen, wlen, tlen, ar->rx_failover_missing);
-        if (ar->rx_failover_missing)
-                print_hex_dump_bytes("rxbuf:", DUMP_PREFIX_OFFSET,
-                                     ar->rx_failover->data,
-                                     ar->rx_failover->len);
-        print_hex_dump_bytes("stream:", DUMP_PREFIX_OFFSET,
-                             skb->data, skb->len);
-        wiphy_err(ar->hw->wiphy,
-                  "If you see this message frequently, please check your hardware and cables.\n");
-err_silent:
-        if (ar->rx_failover_missing) {
-                skb_reset_tail_pointer(ar->rx_failover);
-                skb_trim(ar->rx_failover, 0);
-                ar->rx_failover_missing = 0;
-        }
-}
-#define AR9170_FILL_QUEUE(queue, ai_fs, cwmin, cwmax, _txop)            \
-do {                                                                    \
-        queue.aifs = ai_fs;                                             \
-        queue.cw_min = cwmin;                                           \
-        queue.cw_max = cwmax;                                           \
-        queue.txop = _txop;                                             \
-} while (0)
-static int ar9170_op_start(struct ieee80211_hw *hw)
-{
-        struct ar9170 *ar = hw->priv;
-        int err, i;
-        mutex_lock(&ar->mutex);
-        /* reinitialize queues statistics */
-        memset(&ar->tx_stats, 0, sizeof(ar->tx_stats));
-        for (i = 0; i < __AR9170_NUM_TXQ; i++)
-                ar->tx_stats[i].limit = AR9170_TXQ_DEPTH;
-        /* reset QoS defaults */
-        AR9170_FILL_QUEUE(ar->edcf[0], 3, 15, 1023,  0); /* BEST EFFORT*/
-        AR9170_FILL_QUEUE(ar->edcf[1], 7, 15, 1023,  0); /* BACKGROUND */
-        AR9170_FILL_QUEUE(ar->edcf[2], 2, 7,    15, 94); /* VIDEO */
-        AR9170_FILL_QUEUE(ar->edcf[3], 2, 3,     7, 47); /* VOICE */
-        AR9170_FILL_QUEUE(ar->edcf[4], 2, 3,     7,  0); /* SPECIAL */
-        /* set sane AMPDU defaults */
-        ar->global_ampdu_density = 6;
-        ar->global_ampdu_factor = 3;
-        ar->bad_hw_nagger = jiffies;
-        err = ar->open(ar);
-        if (err)
-                goto out;
-        err = ar9170_init_mac(ar);
-        if (err)
-                goto out;
-        err = ar9170_set_qos(ar);
-        if (err)
-                goto out;
-        err = ar9170_init_phy(ar, IEEE80211_BAND_2GHZ);
-        if (err)
-                goto out;
-        err = ar9170_init_rf(ar);
-        if (err)
-                goto out;
-        /* start DMA */
-        err = ar9170_write_reg(ar, 0x1c3d30, 0x100);
-        if (err)
-                goto out;
-        ar->state = AR9170_STARTED;
-out:
-        mutex_unlock(&ar->mutex);
-        return err;
-}
-static void ar9170_op_stop(struct ieee80211_hw *hw)
-{
-        struct ar9170 *ar = hw->priv;
-        unsigned int i;
-        if (IS_STARTED(ar))
-                ar->state = AR9170_IDLE;
-        cancel_delayed_work_sync(&ar->tx_janitor);
-#ifdef CONFIG_AR9170_LEDS
-        cancel_delayed_work_sync(&ar->led_work);
-#endif
-        cancel_work_sync(&ar->beacon_work);
-        mutex_lock(&ar->mutex);
-        if (IS_ACCEPTING_CMD(ar)) {
-                ar9170_set_leds_state(ar, 0);
-                /* stop DMA */
-                ar9170_write_reg(ar, 0x1c3d30, 0);
-                ar->stop(ar);
-        }
-        for (i = 0; i < __AR9170_NUM_TXQ; i++) {
-                skb_queue_purge(&ar->tx_pending[i]);
-                skb_queue_purge(&ar->tx_status[i]);
-        }
-        mutex_unlock(&ar->mutex);
-}
-static int ar9170_tx_prepare(struct ar9170 *ar, struct sk_buff *skb)
-{
-        struct ieee80211_hdr *hdr;
-        struct ar9170_tx_control *txc;
-        struct ieee80211_tx_info *info;
-        struct ieee80211_tx_rate *txrate;
-        struct ar9170_tx_info *arinfo;
-        unsigned int queue = skb_get_queue_mapping(skb);
-        u16 keytype = 0;
-        u16 len, icv = 0;
-        BUILD_BUG_ON(sizeof(*arinfo) > sizeof(info->rate_driver_data));
-        hdr = (void *)skb->data;
-        info = IEEE80211_SKB_CB(skb);
-        len = skb->len;
-        txc = (void *)skb_push(skb, sizeof(*txc));
-        if (info->control.hw_key) {
-                icv = info->control.hw_key->icv_len;
-                switch (info->control.hw_key->cipher) {
-                case WLAN_CIPHER_SUITE_WEP40:
-                case WLAN_CIPHER_SUITE_WEP104:
-                case WLAN_CIPHER_SUITE_TKIP:
-                        keytype = AR9170_TX_MAC_ENCR_RC4;
-                        break;
-                case WLAN_CIPHER_SUITE_CCMP:
-                        keytype = AR9170_TX_MAC_ENCR_AES;
-                        break;
-                default:
-                        WARN_ON(1);
-                        goto err_out;
-                }
-        }
-        /* Length */
-        txc->length = cpu_to_le16(len + icv + 4);
-        txc->mac_control = cpu_to_le16(AR9170_TX_MAC_HW_DURATION |
-                                       AR9170_TX_MAC_BACKOFF);
-        txc->mac_control |= cpu_to_le16(ar9170_qos_hwmap[queue] <<
-                                        AR9170_TX_MAC_QOS_SHIFT);
-        txc->mac_control |= cpu_to_le16(keytype);
-        txc->phy_control = cpu_to_le32(0);
-        if (info->flags & IEEE80211_TX_CTL_NO_ACK)
-                txc->mac_control |= cpu_to_le16(AR9170_TX_MAC_NO_ACK);
-        txrate = &info->control.rates[0];
-        if (txrate->flags & IEEE80211_TX_RC_USE_CTS_PROTECT)
-                txc->mac_control |= cpu_to_le16(AR9170_TX_MAC_PROT_CTS);
-        else if (txrate->flags & IEEE80211_TX_RC_USE_RTS_CTS)
-                txc->mac_control |= cpu_to_le16(AR9170_TX_MAC_PROT_RTS);
-        arinfo = (void *)info->rate_driver_data;
-        arinfo->timeout = jiffies + msecs_to_jiffies(AR9170_QUEUE_TIMEOUT);
-        if (!(info->flags & IEEE80211_TX_CTL_NO_ACK) &&
-             (is_valid_ether_addr(ieee80211_get_DA(hdr)))) {
-                /*
-                 * WARNING:
-                 * Putting the QoS queue bits into an unexplored territory is
-                 * certainly not elegant.
-                 *
-                 * In my defense: This idea provides a reasonable way to
-                 * smuggle valuable information to the tx_status callback.
-                 * Also, the idea behind this bit-abuse came straight from
-                 * the original driver code.
-                 */
-                txc->phy_control |=
-                        cpu_to_le32(queue << AR9170_TX_PHY_QOS_SHIFT);
-                txc->mac_control |= cpu_to_le16(AR9170_TX_MAC_RATE_PROBE);
-        }
-        return 0;
-err_out:
-        skb_pull(skb, sizeof(*txc));
-        return -EINVAL;
-}
-static void ar9170_tx_prepare_phy(struct ar9170 *ar, struct sk_buff *skb)
-{
-        struct ar9170_tx_control *txc;
-        struct ieee80211_tx_info *info;
-        struct ieee80211_rate *rate = NULL;
-        struct ieee80211_tx_rate *txrate;
-        u32 power, chains;
-        txc = (void *) skb->data;
-        info = IEEE80211_SKB_CB(skb);
-        txrate = &info->control.rates[0];
-        if (txrate->flags & IEEE80211_TX_RC_GREEN_FIELD)
-                txc->phy_control |= cpu_to_le32(AR9170_TX_PHY_GREENFIELD);
-        if (txrate->flags & IEEE80211_TX_RC_USE_SHORT_PREAMBLE)
-                txc->phy_control |= cpu_to_le32(AR9170_TX_PHY_SHORT_PREAMBLE);
-        if (txrate->flags & IEEE80211_TX_RC_40_MHZ_WIDTH)
-                txc->phy_control |= cpu_to_le32(AR9170_TX_PHY_BW_40MHZ);
-        /* this works because 40 MHz is 2 and dup is 3 */
-        if (txrate->flags & IEEE80211_TX_RC_DUP_DATA)
-                txc->phy_control |= cpu_to_le32(AR9170_TX_PHY_BW_40MHZ_DUP);
-        if (txrate->flags & IEEE80211_TX_RC_SHORT_GI)
-                txc->phy_control |= cpu_to_le32(AR9170_TX_PHY_SHORT_GI);
-        if (txrate->flags & IEEE80211_TX_RC_MCS) {
-                u32 r = txrate->idx;
-                u8 *txpower;
-                /* heavy clip control */
-                txc->phy_control |= cpu_to_le32((r & 0x7) << 7);
-                r <<= AR9170_TX_PHY_MCS_SHIFT;
-                BUG_ON(r & ~AR9170_TX_PHY_MCS_MASK);
-                txc->phy_control |= cpu_to_le32(r & AR9170_TX_PHY_MCS_MASK);
-                txc->phy_control |= cpu_to_le32(AR9170_TX_PHY_MOD_HT);
-                if (txrate->flags & IEEE80211_TX_RC_40_MHZ_WIDTH) {
-                        if (info->band == IEEE80211_BAND_5GHZ)
-                                txpower = ar->power_5G_ht40;
-                        else
-                                txpower = ar->power_2G_ht40;
-                } else {
-                        if (info->band == IEEE80211_BAND_5GHZ)
-                                txpower = ar->power_5G_ht20;
-                        else
-                                txpower = ar->power_2G_ht20;
-                }
-                power = txpower[(txrate->idx) & 7];
-        } else {
-                u8 *txpower;
-                u32 mod;
-                u32 phyrate;
-                u8 idx = txrate->idx;
-                if (info->band != IEEE80211_BAND_2GHZ) {
-                        idx += 4;
-                        txpower = ar->power_5G_leg;
-                        mod = AR9170_TX_PHY_MOD_OFDM;
-                } else {
-                        if (idx < 4) {
-                                txpower = ar->power_2G_cck;
-                                mod = AR9170_TX_PHY_MOD_CCK;
-                        } else {
-                                mod = AR9170_TX_PHY_MOD_OFDM;
-                                txpower = ar->power_2G_ofdm;
-                        }
-                }
-                rate = &__ar9170_ratetable[idx];
-                phyrate = rate->hw_value & 0xF;
-                power = txpower[(rate->hw_value & 0x30) >> 4];
-                phyrate <<= AR9170_TX_PHY_MCS_SHIFT;
-                txc->phy_control |= cpu_to_le32(mod);
-                txc->phy_control |= cpu_to_le32(phyrate);
-        }
-        power <<= AR9170_TX_PHY_TX_PWR_SHIFT;
-        power &= AR9170_TX_PHY_TX_PWR_MASK;
-        txc->phy_control |= cpu_to_le32(power);
-        /* set TX chains */
-        if (ar->eeprom.tx_mask == 1) {
-                chains = AR9170_TX_PHY_TXCHAIN_1;
-        } else {
-                chains = AR9170_TX_PHY_TXCHAIN_2;
-                /* >= 36M legacy OFDM - use only one chain */
-                if (rate && rate->bitrate >= 360)
-                        chains = AR9170_TX_PHY_TXCHAIN_1;
-        }
-        txc->phy_control |= cpu_to_le32(chains << AR9170_TX_PHY_TXCHAIN_SHIFT);
-}
-static void ar9170_tx(struct ar9170 *ar)
-{
-        struct sk_buff *skb;
-        unsigned long flags;
-        struct ieee80211_tx_info *info;
-        struct ar9170_tx_info *arinfo;
-        unsigned int i, frames, frames_failed, remaining_space;
-        int err;
-        bool schedule_garbagecollector = false;
-        BUILD_BUG_ON(sizeof(*arinfo) > sizeof(info->rate_driver_data));
-        if (unlikely(!IS_STARTED(ar)))
-                return ;
-        remaining_space = AR9170_TX_MAX_PENDING;
-        for (i = 0; i < __AR9170_NUM_TXQ; i++) {
-                spin_lock_irqsave(&ar->tx_stats_lock, flags);
-                frames = min(ar->tx_stats[i].limit - ar->tx_stats[i].len,
-                             skb_queue_len(&ar->tx_pending[i]));
-                if (remaining_space < frames) {
-#ifdef AR9170_QUEUE_DEBUG
-                        wiphy_debug(ar->hw->wiphy,
-                                    "tx quota reached queue:%d, "
-                                    "remaining slots:%d, needed:%d\n",
-                                    i, remaining_space, frames);
-#endif /* AR9170_QUEUE_DEBUG */
-                        frames = remaining_space;
-                }
-                ar->tx_stats[i].len += frames;
-                ar->tx_stats[i].count += frames;
-                if (ar->tx_stats[i].len >= ar->tx_stats[i].limit) {
-#ifdef AR9170_QUEUE_DEBUG
-                        wiphy_debug(ar->hw->wiphy, "queue %d full\n", i);
-                        wiphy_debug(ar->hw->wiphy, "stuck frames: ===>\n");
-                        ar9170_dump_txqueue(ar, &ar->tx_pending[i]);
-                        ar9170_dump_txqueue(ar, &ar->tx_status[i]);
-#endif /* AR9170_QUEUE_DEBUG */
-#ifdef AR9170_QUEUE_STOP_DEBUG
-                        wiphy_debug(ar->hw->wiphy, "stop queue %d\n", i);
-                        __ar9170_dump_txstats(ar);
-#endif /* AR9170_QUEUE_STOP_DEBUG */
-                        ieee80211_stop_queue(ar->hw, i);
-                }
-                spin_unlock_irqrestore(&ar->tx_stats_lock, flags);
-                if (!frames)
-                        continue;
-                frames_failed = 0;
-                while (frames) {
-                        skb = skb_dequeue(&ar->tx_pending[i]);
-                        if (unlikely(!skb)) {
-                                frames_failed += frames;
-                                frames = 0;
-                                break;
-                        }
-                        info = IEEE80211_SKB_CB(skb);
-                        arinfo = (void *) info->rate_driver_data;
-                        /* TODO: cancel stuck frames */
-                        arinfo->timeout = jiffies +
-                                          msecs_to_jiffies(AR9170_TX_TIMEOUT);
-#ifdef AR9170_QUEUE_DEBUG
-                        wiphy_debug(ar->hw->wiphy, "send frame q:%d =>\n", i);
-                        ar9170_print_txheader(ar, skb);
-#endif /* AR9170_QUEUE_DEBUG */
-                        err = ar->tx(ar, skb);
-                        if (unlikely(err)) {
-                                frames_failed++;
-                                dev_kfree_skb_any(skb);
-                        } else {
-                                remaining_space--;
-                                schedule_garbagecollector = true;
-                        }
-                        frames--;
-                }
-#ifdef AR9170_QUEUE_DEBUG
-                wiphy_debug(ar->hw->wiphy,
-                            "ar9170_tx report for queue %d\n", i);
-                wiphy_debug(ar->hw->wiphy,
-                            "unprocessed pending frames left:\n");
-                ar9170_dump_txqueue(ar, &ar->tx_pending[i]);
-#endif /* AR9170_QUEUE_DEBUG */
-                if (unlikely(frames_failed)) {
-#ifdef AR9170_QUEUE_DEBUG
-                        wiphy_debug(ar->hw->wiphy,
-                                    "frames failed %d =>\n", frames_failed);
-#endif /* AR9170_QUEUE_DEBUG */
-                        spin_lock_irqsave(&ar->tx_stats_lock, flags);
-                        ar->tx_stats[i].len -= frames_failed;
-                        ar->tx_stats[i].count -= frames_failed;
-#ifdef AR9170_QUEUE_STOP_DEBUG
-                        wiphy_debug(ar->hw->wiphy, "wake queue %d\n", i);
-                        __ar9170_dump_txstats(ar);
-#endif /* AR9170_QUEUE_STOP_DEBUG */
-                        ieee80211_wake_queue(ar->hw, i);
-                        spin_unlock_irqrestore(&ar->tx_stats_lock, flags);
-                }
-        }
-        if (!schedule_garbagecollector)
-                return;
-        ieee80211_queue_delayed_work(ar->hw,
-                                     &ar->tx_janitor,
-                                     msecs_to_jiffies(AR9170_JANITOR_DELAY));
-}
-void ar9170_op_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
-{
-        struct ar9170 *ar = hw->priv;
-        struct ieee80211_tx_info *info;
-        unsigned int queue;
-        if (unlikely(!IS_STARTED(ar)))
-                goto err_free;
-        if (unlikely(ar9170_tx_prepare(ar, skb)))
-                goto err_free;
-        queue = skb_get_queue_mapping(skb);
-        info = IEEE80211_SKB_CB(skb);
-        ar9170_tx_prepare_phy(ar, skb);
-        skb_queue_tail(&ar->tx_pending[queue], skb);
-        ar9170_tx(ar);
-        return;
-err_free:
-        dev_kfree_skb_any(skb);
-}
-static int ar9170_op_add_interface(struct ieee80211_hw *hw,
-                                   struct ieee80211_vif *vif)
-{
-        struct ar9170 *ar = hw->priv;
-        struct ath_common *common = &ar->common;
-        int err = 0;
-        mutex_lock(&ar->mutex);
-        if (ar->vif) {
-                err = -EBUSY;
-                goto unlock;
-        }
-        ar->vif = vif;
-        memcpy(common->macaddr, vif->addr, ETH_ALEN);
-        if (modparam_nohwcrypt || (ar->vif->type != NL80211_IFTYPE_STATION)) {
-                ar->rx_software_decryption = true;
-                ar->disable_offload = true;
-        }
-        ar->cur_filter = 0;
-        err = ar9170_update_frame_filter(ar, AR9170_MAC_REG_FTF_DEFAULTS);
-        if (err)
-                goto unlock;
-        err = ar9170_set_operating_mode(ar);
-unlock:
-        mutex_unlock(&ar->mutex);
-        return err;
-}
-static void ar9170_op_remove_interface(struct ieee80211_hw *hw,
-                                       struct ieee80211_vif *vif)
-{
-        struct ar9170 *ar = hw->priv;
-        mutex_lock(&ar->mutex);
-        ar->vif = NULL;
-        ar9170_update_frame_filter(ar, 0);
-        ar9170_set_beacon_timers(ar);
-        dev_kfree_skb(ar->beacon);
-        ar->beacon = NULL;
-        ar->sniffer_enabled = false;
-        ar->rx_software_decryption = false;
-        ar9170_set_operating_mode(ar);
-        mutex_unlock(&ar->mutex);
-}
-static int ar9170_op_config(struct ieee80211_hw *hw, u32 changed)
-{
-        struct ar9170 *ar = hw->priv;
-        int err = 0;
-        mutex_lock(&ar->mutex);
-        if (changed & IEEE80211_CONF_CHANGE_LISTEN_INTERVAL) {
-                /* TODO */
-                err = 0;
-        }
-        if (changed & IEEE80211_CONF_CHANGE_PS) {
-                /* TODO */
-                err = 0;
-        }
-        if (changed & IEEE80211_CONF_CHANGE_POWER) {
-                /* TODO */
-                err = 0;
-        }
-        if (changed & IEEE80211_CONF_CHANGE_RETRY_LIMITS) {
-                /*
-                 * is it long_frame_max_tx_count or short_frame_max_tx_count?
-                 */
-                err = ar9170_set_hwretry_limit(ar,
-                        ar->hw->conf.long_frame_max_tx_count);
-                if (err)
-                        goto out;
-        }
-        if (changed & IEEE80211_CONF_CHANGE_CHANNEL) {
-                /* adjust slot time for 5 GHz */
-                err = ar9170_set_slot_time(ar);
-                if (err)
-                        goto out;
-                err = ar9170_set_dyn_sifs_ack(ar);
-                if (err)
-                        goto out;
-                err = ar9170_set_channel(ar, hw->conf.channel,
-                                AR9170_RFI_NONE,
-                                nl80211_to_ar9170(hw->conf.channel_type));
-                if (err)
-                        goto out;
-        }
-out:
-        mutex_unlock(&ar->mutex);
-        return err;
-}
-static u64 ar9170_op_prepare_multicast(struct ieee80211_hw *hw,
-                                       struct netdev_hw_addr_list *mc_list)
-{
-        u64 mchash;
-        struct netdev_hw_addr *ha;
-        /* always get broadcast frames */
-        mchash = 1ULL << (0xff >> 2);
-        netdev_hw_addr_list_for_each(ha, mc_list)
-                mchash |= 1ULL << (ha->addr[5] >> 2);
-        return mchash;
-}
-static void ar9170_op_configure_filter(struct ieee80211_hw *hw,
-                                       unsigned int changed_flags,
-                                       unsigned int *new_flags,
-                                       u64 multicast)
-{
-        struct ar9170 *ar = hw->priv;
-        if (unlikely(!IS_ACCEPTING_CMD(ar)))
-                return ;
-        mutex_lock(&ar->mutex);
-        /* mask supported flags */
-        *new_flags &= FIF_ALLMULTI | FIF_CONTROL | FIF_BCN_PRBRESP_PROMISC |
-                      FIF_PROMISC_IN_BSS | FIF_FCSFAIL | FIF_PLCPFAIL;
-        ar->filter_state = *new_flags;
-        /*
-         * We can support more by setting the sniffer bit and
-         * then checking the error flags, later.
-         */
-        if (changed_flags & FIF_ALLMULTI && *new_flags & FIF_ALLMULTI)
-                multicast = ~0ULL;
-        if (multicast != ar->cur_mc_hash)
-                ar9170_update_multicast(ar, multicast);
-        if (changed_flags & FIF_CONTROL) {
-                u32 filter = AR9170_MAC_REG_FTF_PSPOLL |
-                             AR9170_MAC_REG_FTF_RTS |
-                             AR9170_MAC_REG_FTF_CTS |
-                             AR9170_MAC_REG_FTF_ACK |
-                             AR9170_MAC_REG_FTF_CFE |
-                             AR9170_MAC_REG_FTF_CFE_ACK;
-                if (*new_flags & FIF_CONTROL)
-                        filter |= ar->cur_filter;
-                else
-                        filter &= (~ar->cur_filter);
-                ar9170_update_frame_filter(ar, filter);
-        }
-        if (changed_flags & FIF_PROMISC_IN_BSS) {
-                ar->sniffer_enabled = ((*new_flags) & FIF_PROMISC_IN_BSS) != 0;
-                ar9170_set_operating_mode(ar);
-        }
-        mutex_unlock(&ar->mutex);
-}
-static void ar9170_op_bss_info_changed(struct ieee80211_hw *hw,
-                                       struct ieee80211_vif *vif,
-                                       struct ieee80211_bss_conf *bss_conf,
-                                       u32 changed)
-{
-        struct ar9170 *ar = hw->priv;
-        struct ath_common *common = &ar->common;
-        int err = 0;
-        mutex_lock(&ar->mutex);
-        if (changed & BSS_CHANGED_BSSID) {
-                memcpy(common->curbssid, bss_conf->bssid, ETH_ALEN);
-                err = ar9170_set_operating_mode(ar);
-                if (err)
-                        goto out;
-        }
-        if (changed & BSS_CHANGED_BEACON_ENABLED)
-                ar->enable_beacon = bss_conf->enable_beacon;
-        if (changed & BSS_CHANGED_BEACON) {
-                err = ar9170_update_beacon(ar);
-                if (err)
-                        goto out;
-        }
-        if (changed & (BSS_CHANGED_BEACON_ENABLED | BSS_CHANGED_BEACON |
-                       BSS_CHANGED_BEACON_INT)) {
-                err = ar9170_set_beacon_timers(ar);
-                if (err)
-                        goto out;
-        }
-        if (changed & BSS_CHANGED_ASSOC) {
-#ifndef CONFIG_AR9170_LEDS
-                /* enable assoc LED. */
-                err = ar9170_set_leds_state(ar, bss_conf->assoc ? 2 : 0);
-#endif /* CONFIG_AR9170_LEDS */
-        }
-        if (changed & BSS_CHANGED_HT) {
-                /* TODO */
-                err = 0;
-        }
-        if (changed & BSS_CHANGED_ERP_SLOT) {
-                err = ar9170_set_slot_time(ar);
-                if (err)
-                        goto out;
-        }
-        if (changed & BSS_CHANGED_BASIC_RATES) {
-                err = ar9170_set_basic_rates(ar);
-                if (err)
-                        goto out;
-        }
-out:
-        mutex_unlock(&ar->mutex);
-}
-static u64 ar9170_op_get_tsf(struct ieee80211_hw *hw)
-{
-        struct ar9170 *ar = hw->priv;
-        int err;
-        u64 tsf;
-#define NR 3
-        static const u32 addr[NR] = { AR9170_MAC_REG_TSF_H,
-                                    AR9170_MAC_REG_TSF_L,
-                                    AR9170_MAC_REG_TSF_H };
-        u32 val[NR];
-        int loops = 0;
-        mutex_lock(&ar->mutex);
-        while (loops++ < 10) {
-                err = ar9170_read_mreg(ar, NR, addr, val);
-                if (err || val[0] == val[2])
-                        break;
-        }
-        mutex_unlock(&ar->mutex);
-        if (WARN_ON(err))
-                return 0;
-        tsf = val[0];
-        tsf = (tsf << 32) | val[1];
-        return tsf;
-#undef NR
-}
-static int ar9170_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
-                          struct ieee80211_vif *vif, struct ieee80211_sta *sta,
-                          struct ieee80211_key_conf *key)
-{
-        struct ar9170 *ar = hw->priv;
-        int err = 0, i;
-        u8 ktype;
-        if ((!ar->vif) || (ar->disable_offload))
-                return -EOPNOTSUPP;
-        switch (key->cipher) {
-        case WLAN_CIPHER_SUITE_WEP40:
-                ktype = AR9170_ENC_ALG_WEP64;
-                break;
-        case WLAN_CIPHER_SUITE_WEP104:
-                ktype = AR9170_ENC_ALG_WEP128;
-                break;
-        case WLAN_CIPHER_SUITE_TKIP:
-                ktype = AR9170_ENC_ALG_TKIP;
-                break;
-        case WLAN_CIPHER_SUITE_CCMP:
-                ktype = AR9170_ENC_ALG_AESCCMP;
-                break;
-        default:
-                return -EOPNOTSUPP;
-        }
-        mutex_lock(&ar->mutex);
-        if (cmd == SET_KEY) {
-                if (unlikely(!IS_STARTED(ar))) {
-                        err = -EOPNOTSUPP;
-                        goto out;
-                }
-                /* group keys need all-zeroes address */
-                if (!(key->flags & IEEE80211_KEY_FLAG_PAIRWISE))
-                        sta = NULL;
-                if (key->flags & IEEE80211_KEY_FLAG_PAIRWISE) {
-                        for (i = 0; i < 64; i++)
-                                if (!(ar->usedkeys & BIT(i)))
-                                        break;
-                        if (i == 64) {
-                                ar->rx_software_decryption = true;
-                                ar9170_set_operating_mode(ar);
-                                err = -ENOSPC;
-                                goto out;
-                        }
-                } else {
-                        i = 64 + key->keyidx;
-                }
-                key->hw_key_idx = i;
-                err = ar9170_upload_key(ar, i, sta ? sta->addr : NULL, ktype, 0,
-                                        key->key, min_t(u8, 16, key->keylen));
-                if (err)
-                        goto out;
-                if (key->cipher == WLAN_CIPHER_SUITE_TKIP) {
-                        err = ar9170_upload_key(ar, i, sta ? sta->addr : NULL,
-                                                ktype, 1, key->key + 16, 16);
-                        if (err)
-                                goto out;
-                        /*
-                         * hardware is not capable generating the MMIC
-                         * for fragmented frames!
-                         */
-                        key->flags |= IEEE80211_KEY_FLAG_GENERATE_MMIC;
-                }
-                if (i < 64)
-                        ar->usedkeys |= BIT(i);
-                key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
-        } else {
-                if (unlikely(!IS_STARTED(ar))) {
-                        /* The device is gone... together with the key ;-) */
-                        err = 0;
-                        goto out;
-                }
-                err = ar9170_disable_key(ar, key->hw_key_idx);
-                if (err)
-                        goto out;
-                if (key->hw_key_idx < 64) {
-                        ar->usedkeys &= ~BIT(key->hw_key_idx);
-                } else {
-                        err = ar9170_upload_key(ar, key->hw_key_idx, NULL,
-                                                AR9170_ENC_ALG_NONE, 0,
-                                                NULL, 0);
-                        if (err)
-                                goto out;
-                        if (key->cipher == WLAN_CIPHER_SUITE_TKIP) {
-                                err = ar9170_upload_key(ar, key->hw_key_idx,
-                                                        NULL,
-                                                        AR9170_ENC_ALG_NONE, 1,
-                                                        NULL, 0);
-                                if (err)
-                                        goto out;
-                        }
-                }
-        }
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(AR9170_MAC_REG_ROLL_CALL_TBL_L, ar->usedkeys);
-        ar9170_regwrite(AR9170_MAC_REG_ROLL_CALL_TBL_H, ar->usedkeys >> 32);
-        ar9170_regwrite_finish();
-        err = ar9170_regwrite_result();
-out:
-        mutex_unlock(&ar->mutex);
-        return err;
-}
-static int ar9170_get_stats(struct ieee80211_hw *hw,
-                            struct ieee80211_low_level_stats *stats)
-{
-        struct ar9170 *ar = hw->priv;
-        u32 val;
-        int err;
-        mutex_lock(&ar->mutex);
-        err = ar9170_read_reg(ar, AR9170_MAC_REG_TX_RETRY, &val);
-        ar->stats.dot11ACKFailureCount += val;
-        memcpy(stats, &ar->stats, sizeof(*stats));
-        mutex_unlock(&ar->mutex);
-        return 0;
-}
-static int ar9170_get_survey(struct ieee80211_hw *hw, int idx,
-                                struct survey_info *survey)
-{
-        struct ar9170 *ar = hw->priv;
-        struct ieee80211_conf *conf = &hw->conf;
-        if (idx != 0)
-                return -ENOENT;
-        /* TODO: update noise value, e.g. call ar9170_set_channel */
-        survey->channel = conf->channel;
-        survey->filled = SURVEY_INFO_NOISE_DBM;
-        survey->noise = ar->noise[0];
-        return 0;
-}
-static int ar9170_conf_tx(struct ieee80211_hw *hw, u16 queue,
-                          const struct ieee80211_tx_queue_params *param)
-{
-        struct ar9170 *ar = hw->priv;
-        int ret;
-        mutex_lock(&ar->mutex);
-        if (queue < __AR9170_NUM_TXQ) {
-                memcpy(&ar->edcf[ar9170_qos_hwmap[queue]],
-                       param, sizeof(*param));
-                ret = ar9170_set_qos(ar);
-        } else {
-                ret = -EINVAL;
-        }
-        mutex_unlock(&ar->mutex);
-        return ret;
-}
-static int ar9170_ampdu_action(struct ieee80211_hw *hw,
-                               struct ieee80211_vif *vif,
-                               enum ieee80211_ampdu_mlme_action action,
-                               struct ieee80211_sta *sta, u16 tid, u16 *ssn,
-                               u8 buf_size)
-{
-        switch (action) {
-        case IEEE80211_AMPDU_RX_START:
-        case IEEE80211_AMPDU_RX_STOP:
-                /* Handled by firmware */
-                break;
-        default:
-                return -EOPNOTSUPP;
-        }
-        return 0;
-}
-static const struct ieee80211_ops ar9170_ops = {
-        .start                  = ar9170_op_start,
-        .stop                   = ar9170_op_stop,
-        .tx                     = ar9170_op_tx,
-        .add_interface          = ar9170_op_add_interface,
-        .remove_interface       = ar9170_op_remove_interface,
-        .config                 = ar9170_op_config,
-        .prepare_multicast      = ar9170_op_prepare_multicast,
-        .configure_filter       = ar9170_op_configure_filter,
-        .conf_tx                = ar9170_conf_tx,
-        .bss_info_changed       = ar9170_op_bss_info_changed,
-        .get_tsf                = ar9170_op_get_tsf,
-        .set_key                = ar9170_set_key,
-        .get_stats              = ar9170_get_stats,
-        .get_survey             = ar9170_get_survey,
-        .ampdu_action           = ar9170_ampdu_action,
-};
-void *ar9170_alloc(size_t priv_size)
-{
-        struct ieee80211_hw *hw;
-        struct ar9170 *ar;
-        struct sk_buff *skb;
-        int i;
-        /*
-         * this buffer is used for rx stream reconstruction.
-         * Under heavy load this device (or the transport layer?)
-         * tends to split the streams into separate rx descriptors.
-         */
-        skb = __dev_alloc_skb(AR9170_RX_STREAM_MAX_SIZE, GFP_KERNEL);
-        if (!skb)
-                goto err_nomem;
-        hw = ieee80211_alloc_hw(priv_size, &ar9170_ops);
-        if (!hw)
-                goto err_nomem;
-        ar = hw->priv;
-        ar->hw = hw;
-        ar->rx_failover = skb;
-        mutex_init(&ar->mutex);
-        spin_lock_init(&ar->cmdlock);
-        spin_lock_init(&ar->tx_stats_lock);
-        for (i = 0; i < __AR9170_NUM_TXQ; i++) {
-                skb_queue_head_init(&ar->tx_status[i]);
-                skb_queue_head_init(&ar->tx_pending[i]);
-        }
-        ar9170_rx_reset_rx_mpdu(ar);
-        INIT_WORK(&ar->beacon_work, ar9170_new_beacon);
-        INIT_DELAYED_WORK(&ar->tx_janitor, ar9170_tx_janitor);
-        /* all hw supports 2.4 GHz, so set channel to 1 by default */
-        ar->channel = &ar9170_2ghz_chantable[0];
-        /* first part of wiphy init */
-        ar->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
-                                         BIT(NL80211_IFTYPE_WDS) |
-                                         BIT(NL80211_IFTYPE_ADHOC);
-        ar->hw->flags |= IEEE80211_HW_RX_INCLUDES_FCS |
-                         IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
-                         IEEE80211_HW_SIGNAL_DBM;
-        ar->hw->queues = __AR9170_NUM_TXQ;
-        ar->hw->extra_tx_headroom = 8;
-        ar->hw->max_rates = 1;
-        ar->hw->max_rate_tries = 3;
-        for (i = 0; i < ARRAY_SIZE(ar->noise); i++)
-                ar->noise[i] = -95; /* ATH_DEFAULT_NOISE_FLOOR */
-        return ar;
-err_nomem:
-        kfree_skb(skb);
-        return ERR_PTR(-ENOMEM);
-}
-static int ar9170_read_eeprom(struct ar9170 *ar)
-{
-#define RW      8       /* number of words to read at once */
-#define RB      (sizeof(u32) * RW)
-        struct ath_regulatory *regulatory = &ar->common.regulatory;
-        u8 *eeprom = (void *)&ar->eeprom;
-        u8 *addr = ar->eeprom.mac_address;
-        __le32 offsets[RW];
-        unsigned int rx_streams, tx_streams, tx_params = 0;
-        int i, j, err, bands = 0;
-        BUILD_BUG_ON(sizeof(ar->eeprom) & 3);
-        BUILD_BUG_ON(RB > AR9170_MAX_CMD_LEN - 4);
-#ifndef __CHECKER__
-        /* don't want to handle trailing remains */
-        BUILD_BUG_ON(sizeof(ar->eeprom) % RB);
-#endif
-        for (i = 0; i < sizeof(ar->eeprom)/RB; i++) {
-                for (j = 0; j < RW; j++)
-                        offsets[j] = cpu_to_le32(AR9170_EEPROM_START +
-                                                 RB * i + 4 * j);
-                err = ar->exec_cmd(ar, AR9170_CMD_RREG,
-                                   RB, (u8 *) &offsets,
-                                   RB, eeprom + RB * i);
-                if (err)
-                        return err;
-        }
-#undef RW
-#undef RB
-        if (ar->eeprom.length == cpu_to_le16(0xFFFF))
-                return -ENODATA;
-        if (ar->eeprom.operating_flags & AR9170_OPFLAG_2GHZ) {
-                ar->hw->wiphy->bands[IEEE80211_BAND_2GHZ] = &ar9170_band_2GHz;
-                bands++;
-        }
-        if (ar->eeprom.operating_flags & AR9170_OPFLAG_5GHZ) {
-                ar->hw->wiphy->bands[IEEE80211_BAND_5GHZ] = &ar9170_band_5GHz;
-                bands++;
-        }
-        rx_streams = hweight8(ar->eeprom.rx_mask);
-        tx_streams = hweight8(ar->eeprom.tx_mask);
-        if (rx_streams != tx_streams)
-                tx_params = IEEE80211_HT_MCS_TX_RX_DIFF;
-        if (tx_streams >= 1 && tx_streams <= IEEE80211_HT_MCS_TX_MAX_STREAMS)
-                tx_params = (tx_streams - 1) <<
-                            IEEE80211_HT_MCS_TX_MAX_STREAMS_SHIFT;
-        ar9170_band_2GHz.ht_cap.mcs.tx_params |= tx_params;
-        ar9170_band_5GHz.ht_cap.mcs.tx_params |= tx_params;
-        /*
-         * I measured this, a bandswitch takes roughly
-         * 135 ms and a frequency switch about 80.
-         *
-         * FIXME: measure these values again once EEPROM settings
-         *        are used, that will influence them!
-         */
-        if (bands == 2)
-                ar->hw->channel_change_time = 135 * 1000;
-        else
-                ar->hw->channel_change_time = 80 * 1000;
-        regulatory->current_rd = le16_to_cpu(ar->eeprom.reg_domain[0]);
-        regulatory->current_rd_ext = le16_to_cpu(ar->eeprom.reg_domain[1]);
-        /* second part of wiphy init */
-        SET_IEEE80211_PERM_ADDR(ar->hw, addr);
-        return bands ? 0 : -EINVAL;
-}
-static int ar9170_reg_notifier(struct wiphy *wiphy,
-                        struct regulatory_request *request)
-{
-        struct ieee80211_hw *hw = wiphy_to_ieee80211_hw(wiphy);
-        struct ar9170 *ar = hw->priv;
-        return ath_reg_notifier_apply(wiphy, request, &ar->common.regulatory);
-}
-int ar9170_register(struct ar9170 *ar, struct device *pdev)
-{
-        struct ath_regulatory *regulatory = &ar->common.regulatory;
-        int err;
-        /* try to read EEPROM, init MAC addr */
-        err = ar9170_read_eeprom(ar);
-        if (err)
-                goto err_out;
-        err = ath_regd_init(regulatory, ar->hw->wiphy,
-                            ar9170_reg_notifier);
-        if (err)
-                goto err_out;
-        err = ieee80211_register_hw(ar->hw);
-        if (err)
-                goto err_out;
-        if (!ath_is_world_regd(regulatory))
-                regulatory_hint(ar->hw->wiphy, regulatory->alpha2);
-        err = ar9170_init_leds(ar);
-        if (err)
-                goto err_unreg;
-#ifdef CONFIG_AR9170_LEDS
-        err = ar9170_register_leds(ar);
-        if (err)
-                goto err_unreg;
-#endif /* CONFIG_AR9170_LEDS */
-        dev_info(pdev, "Atheros AR9170 is registered as '%s'\n",
-                 wiphy_name(ar->hw->wiphy));
-        ar->registered = true;
-        return 0;
-err_unreg:
-        ieee80211_unregister_hw(ar->hw);
-err_out:
-        return err;
-}
-void ar9170_unregister(struct ar9170 *ar)
-{
-        if (ar->registered) {
-#ifdef CONFIG_AR9170_LEDS
-                ar9170_unregister_leds(ar);
-#endif /* CONFIG_AR9170_LEDS */
-        ieee80211_unregister_hw(ar->hw);
-        }
-        kfree_skb(ar->rx_failover);
-        mutex_destroy(&ar->mutex);
-}
diff --git a/drivers/net/wireless/ath/ar9170/phy.c b/drivers/net/wireless/ath/ar9170/phy.c
deleted file mode 100644
index aa8d06ba1ee4..000000000000
--- a/drivers/net/wireless/ath/ar9170/phy.c
+++ /dev/null
@@ -1,1719 +0,0 @@
-/*
- * Atheros AR9170 driver
- *
- * PHY and RF code
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#include <linux/bitrev.h>
-#include "ar9170.h"
-#include "cmd.h"
-static int ar9170_init_power_cal(struct ar9170 *ar)
-{
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(0x1bc000 + 0x993c, 0x7f);
-        ar9170_regwrite(0x1bc000 + 0x9934, 0x3f3f3f3f);
-        ar9170_regwrite(0x1bc000 + 0x9938, 0x3f3f3f3f);
-        ar9170_regwrite(0x1bc000 + 0xa234, 0x3f3f3f3f);
-        ar9170_regwrite(0x1bc000 + 0xa238, 0x3f3f3f3f);
-        ar9170_regwrite(0x1bc000 + 0xa38c, 0x3f3f3f3f);
-        ar9170_regwrite(0x1bc000 + 0xa390, 0x3f3f3f3f);
-        ar9170_regwrite(0x1bc000 + 0xa3cc, 0x3f3f3f3f);
-        ar9170_regwrite(0x1bc000 + 0xa3d0, 0x3f3f3f3f);
-        ar9170_regwrite(0x1bc000 + 0xa3d4, 0x3f3f3f3f);
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-struct ar9170_phy_init {
-        u32 reg, _5ghz_20, _5ghz_40, _2ghz_40, _2ghz_20;
-};
-static struct ar9170_phy_init ar5416_phy_init[] = {
-        { 0x1c5800, 0x00000007, 0x00000007, 0x00000007, 0x00000007, },
-        { 0x1c5804, 0x00000300, 0x000003c4, 0x000003c4, 0x00000300, },
-        { 0x1c5808, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c580c, 0xad848e19, 0xad848e19, 0xad848e19, 0xad848e19, },
-        { 0x1c5810, 0x7d14e000, 0x7d14e000, 0x7d14e000, 0x7d14e000, },
-        { 0x1c5814, 0x9c0a9f6b, 0x9c0a9f6b, 0x9c0a9f6b, 0x9c0a9f6b, },
-        { 0x1c5818, 0x00000090, 0x00000090, 0x00000090, 0x00000090, },
-        { 0x1c581c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5820, 0x02020200, 0x02020200, 0x02020200, 0x02020200, },
-        { 0x1c5824, 0x00000e0e, 0x00000e0e, 0x00000e0e, 0x00000e0e, },
-        { 0x1c5828, 0x0a020001, 0x0a020001, 0x0a020001, 0x0a020001, },
-        { 0x1c582c, 0x0000a000, 0x0000a000, 0x0000a000, 0x0000a000, },
-        { 0x1c5830, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5834, 0x00000e0e, 0x00000e0e, 0x00000e0e, 0x00000e0e, },
-        { 0x1c5838, 0x00000007, 0x00000007, 0x00000007, 0x00000007, },
-        { 0x1c583c, 0x00200400, 0x00200400, 0x00200400, 0x00200400, },
-        { 0x1c5840, 0x206a002e, 0x206a002e, 0x206a002e, 0x206a002e, },
-        { 0x1c5844, 0x1372161e, 0x13721c1e, 0x13721c24, 0x137216a4, },
-        { 0x1c5848, 0x001a6a65, 0x001a6a65, 0x00197a68, 0x00197a68, },
-        { 0x1c584c, 0x1284233c, 0x1284233c, 0x1284233c, 0x1284233c, },
-        { 0x1c5850, 0x6c48b4e4, 0x6c48b4e4, 0x6c48b0e4, 0x6c48b0e4, },
-        { 0x1c5854, 0x00000859, 0x00000859, 0x00000859, 0x00000859, },
-        { 0x1c5858, 0x7ec80d2e, 0x7ec80d2e, 0x7ec80d2e, 0x7ec80d2e, },
-        { 0x1c585c, 0x31395c5e, 0x31395c5e, 0x31395c5e, 0x31395c5e, },
-        { 0x1c5860, 0x0004dd10, 0x0004dd10, 0x0004dd20, 0x0004dd20, },
-        { 0x1c5868, 0x409a4190, 0x409a4190, 0x409a4190, 0x409a4190, },
-        { 0x1c586c, 0x050cb081, 0x050cb081, 0x050cb081, 0x050cb081, },
-        { 0x1c5900, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5904, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5908, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c590c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5914, 0x000007d0, 0x000007d0, 0x00000898, 0x00000898, },
-        { 0x1c5918, 0x00000118, 0x00000230, 0x00000268, 0x00000134, },
-        { 0x1c591c, 0x10000fff, 0x10000fff, 0x10000fff, 0x10000fff, },
-        { 0x1c5920, 0x0510081c, 0x0510081c, 0x0510001c, 0x0510001c, },
-        { 0x1c5924, 0xd0058a15, 0xd0058a15, 0xd0058a15, 0xd0058a15, },
-        { 0x1c5928, 0x00000001, 0x00000001, 0x00000001, 0x00000001, },
-        { 0x1c592c, 0x00000004, 0x00000004, 0x00000004, 0x00000004, },
-        { 0x1c5934, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, },
-        { 0x1c5938, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, },
-        { 0x1c593c, 0x0000007f, 0x0000007f, 0x0000007f, 0x0000007f, },
-        { 0x1c5944, 0xdfb81020, 0xdfb81020, 0xdfb81020, 0xdfb81020, },
-        { 0x1c5948, 0x9280b212, 0x9280b212, 0x9280b212, 0x9280b212, },
-        { 0x1c594c, 0x00020028, 0x00020028, 0x00020028, 0x00020028, },
-        { 0x1c5954, 0x5d50e188, 0x5d50e188, 0x5d50e188, 0x5d50e188, },
-        { 0x1c5958, 0x00081fff, 0x00081fff, 0x00081fff, 0x00081fff, },
-        { 0x1c5960, 0x00009b40, 0x00009b40, 0x00009b40, 0x00009b40, },
-        { 0x1c5964, 0x00001120, 0x00001120, 0x00001120, 0x00001120, },
-        { 0x1c5970, 0x190fb515, 0x190fb515, 0x190fb515, 0x190fb515, },
-        { 0x1c5974, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5978, 0x00000001, 0x00000001, 0x00000001, 0x00000001, },
-        { 0x1c597c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5980, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5984, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5988, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c598c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5990, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5994, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5998, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c599c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c59a0, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c59a4, 0x00000007, 0x00000007, 0x00000007, 0x00000007, },
-        { 0x1c59a8, 0x001fff00, 0x001fff00, 0x001fff00, 0x001fff00, },
-        { 0x1c59ac, 0x006f00c4, 0x006f00c4, 0x006f00c4, 0x006f00c4, },
-        { 0x1c59b0, 0x03051000, 0x03051000, 0x03051000, 0x03051000, },
-        { 0x1c59b4, 0x00000820, 0x00000820, 0x00000820, 0x00000820, },
-        { 0x1c59c0, 0x038919be, 0x038919be, 0x038919be, 0x038919be, },
-        { 0x1c59c4, 0x06336f77, 0x06336f77, 0x06336f77, 0x06336f77, },
-        { 0x1c59c8, 0x60f6532c, 0x60f6532c, 0x60f6532c, 0x60f6532c, },
-        { 0x1c59cc, 0x08f186c8, 0x08f186c8, 0x08f186c8, 0x08f186c8, },
-        { 0x1c59d0, 0x00046384, 0x00046384, 0x00046384, 0x00046384, },
-        { 0x1c59d4, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c59d8, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c59dc, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c59e0, 0x00000200, 0x00000200, 0x00000200, 0x00000200, },
-        { 0x1c59e4, 0x64646464, 0x64646464, 0x64646464, 0x64646464, },
-        { 0x1c59e8, 0x3c787878, 0x3c787878, 0x3c787878, 0x3c787878, },
-        { 0x1c59ec, 0x000000aa, 0x000000aa, 0x000000aa, 0x000000aa, },
-        { 0x1c59f0, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c59fc, 0x00001042, 0x00001042, 0x00001042, 0x00001042, },
-        { 0x1c5a00, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5a04, 0x00000040, 0x00000040, 0x00000040, 0x00000040, },
-        { 0x1c5a08, 0x00000080, 0x00000080, 0x00000080, 0x00000080, },
-        { 0x1c5a0c, 0x000001a1, 0x000001a1, 0x00000141, 0x00000141, },
-        { 0x1c5a10, 0x000001e1, 0x000001e1, 0x00000181, 0x00000181, },
-        { 0x1c5a14, 0x00000021, 0x00000021, 0x000001c1, 0x000001c1, },
-        { 0x1c5a18, 0x00000061, 0x00000061, 0x00000001, 0x00000001, },
-        { 0x1c5a1c, 0x00000168, 0x00000168, 0x00000041, 0x00000041, },
-        { 0x1c5a20, 0x000001a8, 0x000001a8, 0x000001a8, 0x000001a8, },
-        { 0x1c5a24, 0x000001e8, 0x000001e8, 0x000001e8, 0x000001e8, },
-        { 0x1c5a28, 0x00000028, 0x00000028, 0x00000028, 0x00000028, },
-        { 0x1c5a2c, 0x00000068, 0x00000068, 0x00000068, 0x00000068, },
-        { 0x1c5a30, 0x00000189, 0x00000189, 0x000000a8, 0x000000a8, },
-        { 0x1c5a34, 0x000001c9, 0x000001c9, 0x00000169, 0x00000169, },
-        { 0x1c5a38, 0x00000009, 0x00000009, 0x000001a9, 0x000001a9, },
-        { 0x1c5a3c, 0x00000049, 0x00000049, 0x000001e9, 0x000001e9, },
-        { 0x1c5a40, 0x00000089, 0x00000089, 0x00000029, 0x00000029, },
-        { 0x1c5a44, 0x00000170, 0x00000170, 0x00000069, 0x00000069, },
-        { 0x1c5a48, 0x000001b0, 0x000001b0, 0x00000190, 0x00000190, },
-        { 0x1c5a4c, 0x000001f0, 0x000001f0, 0x000001d0, 0x000001d0, },
-        { 0x1c5a50, 0x00000030, 0x00000030, 0x00000010, 0x00000010, },
-        { 0x1c5a54, 0x00000070, 0x00000070, 0x00000050, 0x00000050, },
-        { 0x1c5a58, 0x00000191, 0x00000191, 0x00000090, 0x00000090, },
-        { 0x1c5a5c, 0x000001d1, 0x000001d1, 0x00000151, 0x00000151, },
-        { 0x1c5a60, 0x00000011, 0x00000011, 0x00000191, 0x00000191, },
-        { 0x1c5a64, 0x00000051, 0x00000051, 0x000001d1, 0x000001d1, },
-        { 0x1c5a68, 0x00000091, 0x00000091, 0x00000011, 0x00000011, },
-        { 0x1c5a6c, 0x000001b8, 0x000001b8, 0x00000051, 0x00000051, },
-        { 0x1c5a70, 0x000001f8, 0x000001f8, 0x00000198, 0x00000198, },
-        { 0x1c5a74, 0x00000038, 0x00000038, 0x000001d8, 0x000001d8, },
-        { 0x1c5a78, 0x00000078, 0x00000078, 0x00000018, 0x00000018, },
-        { 0x1c5a7c, 0x00000199, 0x00000199, 0x00000058, 0x00000058, },
-        { 0x1c5a80, 0x000001d9, 0x000001d9, 0x00000098, 0x00000098, },
-        { 0x1c5a84, 0x00000019, 0x00000019, 0x00000159, 0x00000159, },
-        { 0x1c5a88, 0x00000059, 0x00000059, 0x00000199, 0x00000199, },
-        { 0x1c5a8c, 0x00000099, 0x00000099, 0x000001d9, 0x000001d9, },
-        { 0x1c5a90, 0x000000d9, 0x000000d9, 0x00000019, 0x00000019, },
-        { 0x1c5a94, 0x000000f9, 0x000000f9, 0x00000059, 0x00000059, },
-        { 0x1c5a98, 0x000000f9, 0x000000f9, 0x00000099, 0x00000099, },
-        { 0x1c5a9c, 0x000000f9, 0x000000f9, 0x000000d9, 0x000000d9, },
-        { 0x1c5aa0, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5aa4, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5aa8, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5aac, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ab0, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ab4, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ab8, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5abc, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ac0, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ac4, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ac8, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5acc, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ad0, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ad4, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ad8, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5adc, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ae0, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ae4, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5ae8, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5aec, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5af0, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5af4, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5af8, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5afc, 0x000000f9, 0x000000f9, 0x000000f9, 0x000000f9, },
-        { 0x1c5b00, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5b04, 0x00000001, 0x00000001, 0x00000001, 0x00000001, },
-        { 0x1c5b08, 0x00000002, 0x00000002, 0x00000002, 0x00000002, },
-        { 0x1c5b0c, 0x00000003, 0x00000003, 0x00000003, 0x00000003, },
-        { 0x1c5b10, 0x00000004, 0x00000004, 0x00000004, 0x00000004, },
-        { 0x1c5b14, 0x00000005, 0x00000005, 0x00000005, 0x00000005, },
-        { 0x1c5b18, 0x00000008, 0x00000008, 0x00000008, 0x00000008, },
-        { 0x1c5b1c, 0x00000009, 0x00000009, 0x00000009, 0x00000009, },
-        { 0x1c5b20, 0x0000000a, 0x0000000a, 0x0000000a, 0x0000000a, },
-        { 0x1c5b24, 0x0000000b, 0x0000000b, 0x0000000b, 0x0000000b, },
-        { 0x1c5b28, 0x0000000c, 0x0000000c, 0x0000000c, 0x0000000c, },
-        { 0x1c5b2c, 0x0000000d, 0x0000000d, 0x0000000d, 0x0000000d, },
-        { 0x1c5b30, 0x00000010, 0x00000010, 0x00000010, 0x00000010, },
-        { 0x1c5b34, 0x00000011, 0x00000011, 0x00000011, 0x00000011, },
-        { 0x1c5b38, 0x00000012, 0x00000012, 0x00000012, 0x00000012, },
-        { 0x1c5b3c, 0x00000013, 0x00000013, 0x00000013, 0x00000013, },
-        { 0x1c5b40, 0x00000014, 0x00000014, 0x00000014, 0x00000014, },
-        { 0x1c5b44, 0x00000015, 0x00000015, 0x00000015, 0x00000015, },
-        { 0x1c5b48, 0x00000018, 0x00000018, 0x00000018, 0x00000018, },
-        { 0x1c5b4c, 0x00000019, 0x00000019, 0x00000019, 0x00000019, },
-        { 0x1c5b50, 0x0000001a, 0x0000001a, 0x0000001a, 0x0000001a, },
-        { 0x1c5b54, 0x0000001b, 0x0000001b, 0x0000001b, 0x0000001b, },
-        { 0x1c5b58, 0x0000001c, 0x0000001c, 0x0000001c, 0x0000001c, },
-        { 0x1c5b5c, 0x0000001d, 0x0000001d, 0x0000001d, 0x0000001d, },
-        { 0x1c5b60, 0x00000020, 0x00000020, 0x00000020, 0x00000020, },
-        { 0x1c5b64, 0x00000021, 0x00000021, 0x00000021, 0x00000021, },
-        { 0x1c5b68, 0x00000022, 0x00000022, 0x00000022, 0x00000022, },
-        { 0x1c5b6c, 0x00000023, 0x00000023, 0x00000023, 0x00000023, },
-        { 0x1c5b70, 0x00000024, 0x00000024, 0x00000024, 0x00000024, },
-        { 0x1c5b74, 0x00000025, 0x00000025, 0x00000025, 0x00000025, },
-        { 0x1c5b78, 0x00000028, 0x00000028, 0x00000028, 0x00000028, },
-        { 0x1c5b7c, 0x00000029, 0x00000029, 0x00000029, 0x00000029, },
-        { 0x1c5b80, 0x0000002a, 0x0000002a, 0x0000002a, 0x0000002a, },
-        { 0x1c5b84, 0x0000002b, 0x0000002b, 0x0000002b, 0x0000002b, },
-        { 0x1c5b88, 0x0000002c, 0x0000002c, 0x0000002c, 0x0000002c, },
-        { 0x1c5b8c, 0x0000002d, 0x0000002d, 0x0000002d, 0x0000002d, },
-        { 0x1c5b90, 0x00000030, 0x00000030, 0x00000030, 0x00000030, },
-        { 0x1c5b94, 0x00000031, 0x00000031, 0x00000031, 0x00000031, },
-        { 0x1c5b98, 0x00000032, 0x00000032, 0x00000032, 0x00000032, },
-        { 0x1c5b9c, 0x00000033, 0x00000033, 0x00000033, 0x00000033, },
-        { 0x1c5ba0, 0x00000034, 0x00000034, 0x00000034, 0x00000034, },
-        { 0x1c5ba4, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5ba8, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bac, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bb0, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bb4, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bb8, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bbc, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bc0, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bc4, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bc8, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bcc, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bd0, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bd4, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bd8, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bdc, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5be0, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5be4, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5be8, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bec, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bf0, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bf4, 0x00000035, 0x00000035, 0x00000035, 0x00000035, },
-        { 0x1c5bf8, 0x00000010, 0x00000010, 0x00000010, 0x00000010, },
-        { 0x1c5bfc, 0x0000001a, 0x0000001a, 0x0000001a, 0x0000001a, },
-        { 0x1c5c00, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c0c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c10, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c14, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c18, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c1c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c20, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c24, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c28, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c2c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c30, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c34, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c38, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5c3c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5cf0, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5cf4, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5cf8, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c5cfc, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c6200, 0x00000008, 0x00000008, 0x0000000e, 0x0000000e, },
-        { 0x1c6204, 0x00000440, 0x00000440, 0x00000440, 0x00000440, },
-        { 0x1c6208, 0xd6be4788, 0xd6be4788, 0xd03e4788, 0xd03e4788, },
-        { 0x1c620c, 0x012e8160, 0x012e8160, 0x012a8160, 0x012a8160, },
-        { 0x1c6210, 0x40806333, 0x40806333, 0x40806333, 0x40806333, },
-        { 0x1c6214, 0x00106c10, 0x00106c10, 0x00106c10, 0x00106c10, },
-        { 0x1c6218, 0x009c4060, 0x009c4060, 0x009c4060, 0x009c4060, },
-        { 0x1c621c, 0x1883800a, 0x1883800a, 0x1883800a, 0x1883800a, },
-        { 0x1c6220, 0x018830c6, 0x018830c6, 0x018830c6, 0x018830c6, },
-        { 0x1c6224, 0x00000400, 0x00000400, 0x00000400, 0x00000400, },
-        { 0x1c6228, 0x000009b5, 0x000009b5, 0x000009b5, 0x000009b5, },
-        { 0x1c622c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c6230, 0x00000108, 0x00000210, 0x00000210, 0x00000108, },
-        { 0x1c6234, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, },
-        { 0x1c6238, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, },
-        { 0x1c623c, 0x13c889af, 0x13c889af, 0x13c889af, 0x13c889af, },
-        { 0x1c6240, 0x38490a20, 0x38490a20, 0x38490a20, 0x38490a20, },
-        { 0x1c6244, 0x00007bb6, 0x00007bb6, 0x00007bb6, 0x00007bb6, },
-        { 0x1c6248, 0x0fff3ffc, 0x0fff3ffc, 0x0fff3ffc, 0x0fff3ffc, },
-        { 0x1c624c, 0x00000001, 0x00000001, 0x00000001, 0x00000001, },
-        { 0x1c6250, 0x0000a000, 0x0000a000, 0x0000a000, 0x0000a000, },
-        { 0x1c6254, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c6258, 0x0cc75380, 0x0cc75380, 0x0cc75380, 0x0cc75380, },
-        { 0x1c625c, 0x0f0f0f01, 0x0f0f0f01, 0x0f0f0f01, 0x0f0f0f01, },
-        { 0x1c6260, 0xdfa91f01, 0xdfa91f01, 0xdfa91f01, 0xdfa91f01, },
-        { 0x1c6264, 0x00418a11, 0x00418a11, 0x00418a11, 0x00418a11, },
-        { 0x1c6268, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c626c, 0x09249126, 0x09249126, 0x09249126, 0x09249126, },
-        { 0x1c6274, 0x0a1a9caa, 0x0a1a9caa, 0x0a1a7caa, 0x0a1a7caa, },
-        { 0x1c6278, 0x1ce739ce, 0x1ce739ce, 0x1ce739ce, 0x1ce739ce, },
-        { 0x1c627c, 0x051701ce, 0x051701ce, 0x051701ce, 0x051701ce, },
-        { 0x1c6300, 0x18010000, 0x18010000, 0x18010000, 0x18010000, },
-        { 0x1c6304, 0x30032602, 0x30032602, 0x2e032402, 0x2e032402, },
-        { 0x1c6308, 0x48073e06, 0x48073e06, 0x4a0a3c06, 0x4a0a3c06, },
-        { 0x1c630c, 0x560b4c0a, 0x560b4c0a, 0x621a540b, 0x621a540b, },
-        { 0x1c6310, 0x641a600f, 0x641a600f, 0x764f6c1b, 0x764f6c1b, },
-        { 0x1c6314, 0x7a4f6e1b, 0x7a4f6e1b, 0x845b7a5a, 0x845b7a5a, },
-        { 0x1c6318, 0x8c5b7e5a, 0x8c5b7e5a, 0x950f8ccf, 0x950f8ccf, },
-        { 0x1c631c, 0x9d0f96cf, 0x9d0f96cf, 0xa5cf9b4f, 0xa5cf9b4f, },
-        { 0x1c6320, 0xb51fa69f, 0xb51fa69f, 0xbddfaf1f, 0xbddfaf1f, },
-        { 0x1c6324, 0xcb3fbd07, 0xcb3fbcbf, 0xd1ffc93f, 0xd1ffc93f, },
-        { 0x1c6328, 0x0000d7bf, 0x0000d7bf, 0x00000000, 0x00000000, },
-        { 0x1c632c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c6330, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c6334, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c6338, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c633c, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c6340, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c6344, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c6348, 0x3fffffff, 0x3fffffff, 0x3fffffff, 0x3fffffff, },
-        { 0x1c634c, 0x3fffffff, 0x3fffffff, 0x3fffffff, 0x3fffffff, },
-        { 0x1c6350, 0x3fffffff, 0x3fffffff, 0x3fffffff, 0x3fffffff, },
-        { 0x1c6354, 0x0003ffff, 0x0003ffff, 0x0003ffff, 0x0003ffff, },
-        { 0x1c6358, 0x79a8aa1f, 0x79a8aa1f, 0x79a8aa1f, 0x79a8aa1f, },
-        { 0x1c6388, 0x08000000, 0x08000000, 0x08000000, 0x08000000, },
-        { 0x1c638c, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, },
-        { 0x1c6390, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, },
-        { 0x1c6394, 0x1ce739ce, 0x1ce739ce, 0x1ce739ce, 0x1ce739ce, },
-        { 0x1c6398, 0x000001ce, 0x000001ce, 0x000001ce, 0x000001ce, },
-        { 0x1c639c, 0x00000007, 0x00000007, 0x00000007, 0x00000007, },
-        { 0x1c63a0, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63a4, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63a8, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63ac, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63b0, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63b4, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63b8, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63bc, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63c0, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63c4, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63c8, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63cc, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, },
-        { 0x1c63d0, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, },
-        { 0x1c63d4, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, 0x3f3f3f3f, },
-        { 0x1c63d8, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
-        { 0x1c63dc, 0x1ce739ce, 0x1ce739ce, 0x1ce739ce, 0x1ce739ce, },
-        { 0x1c63e0, 0x000000c0, 0x000000c0, 0x000000c0, 0x000000c0, },
-        { 0x1c6848, 0x00180a65, 0x00180a65, 0x00180a68, 0x00180a68, },
-        { 0x1c6920, 0x0510001c, 0x0510001c, 0x0510001c, 0x0510001c, },
-        { 0x1c6960, 0x00009b40, 0x00009b40, 0x00009b40, 0x00009b40, },
-        { 0x1c720c, 0x012e8160, 0x012e8160, 0x012a8160, 0x012a8160, },
-        { 0x1c726c, 0x09249126, 0x09249126, 0x09249126, 0x09249126, },
-        { 0x1c7848, 0x00180a65, 0x00180a65, 0x00180a68, 0x00180a68, },
-        { 0x1c7920, 0x0510001c, 0x0510001c, 0x0510001c, 0x0510001c, },
-        { 0x1c7960, 0x00009b40, 0x00009b40, 0x00009b40, 0x00009b40, },
-        { 0x1c820c, 0x012e8160, 0x012e8160, 0x012a8160, 0x012a8160, },
-        { 0x1c826c, 0x09249126, 0x09249126, 0x09249126, 0x09249126, },
-/*      { 0x1c8864, 0x0001ce00, 0x0001ce00, 0x0001ce00, 0x0001ce00, }, */
-        { 0x1c8864, 0x0001c600, 0x0001c600, 0x0001c600, 0x0001c600, },
-        { 0x1c895c, 0x004b6a8e, 0x004b6a8e, 0x004b6a8e, 0x004b6a8e, },
-        { 0x1c8968, 0x000003ce, 0x000003ce, 0x000003ce, 0x000003ce, },
-        { 0x1c89bc, 0x00181400, 0x00181400, 0x00181400, 0x00181400, },
-        { 0x1c9270, 0x00820820, 0x00820820, 0x00820820, 0x00820820, },
-        { 0x1c935c, 0x066c420f, 0x066c420f, 0x066c420f, 0x066c420f, },
-        { 0x1c9360, 0x0f282207, 0x0f282207, 0x0f282207, 0x0f282207, },
-        { 0x1c9364, 0x17601685, 0x17601685, 0x17601685, 0x17601685, },
-        { 0x1c9368, 0x1f801104, 0x1f801104, 0x1f801104, 0x1f801104, },
-        { 0x1c936c, 0x37a00c03, 0x37a00c03, 0x37a00c03, 0x37a00c03, },
-        { 0x1c9370, 0x3fc40883, 0x3fc40883, 0x3fc40883, 0x3fc40883, },
-        { 0x1c9374, 0x57c00803, 0x57c00803, 0x57c00803, 0x57c00803, },
-        { 0x1c9378, 0x5fd80682, 0x5fd80682, 0x5fd80682, 0x5fd80682, },
-        { 0x1c937c, 0x7fe00482, 0x7fe00482, 0x7fe00482, 0x7fe00482, },
-        { 0x1c9380, 0x7f3c7bba, 0x7f3c7bba, 0x7f3c7bba, 0x7f3c7bba, },
-        { 0x1c9384, 0xf3307ff0, 0xf3307ff0, 0xf3307ff0, 0xf3307ff0, }
-};
-/*
- * look up a certain register in ar5416_phy_init[] and return the init. value
- * for the band and bandwidth given. Return 0 if register address not found.
- */
-static u32 ar9170_get_default_phy_reg_val(u32 reg, bool is_2ghz, bool is_40mhz)
-{
-        unsigned int i;
-        for (i = 0; i < ARRAY_SIZE(ar5416_phy_init); i++) {
-                if (ar5416_phy_init[i].reg != reg)
-                        continue;
-                if (is_2ghz) {
-                        if (is_40mhz)
-                                return ar5416_phy_init[i]._2ghz_40;
-                        else
-                                return ar5416_phy_init[i]._2ghz_20;
-                } else {
-                        if (is_40mhz)
-                                return ar5416_phy_init[i]._5ghz_40;
-                        else
-                                return ar5416_phy_init[i]._5ghz_20;
-                }
-        }
-        return 0;
-}
-/*
- * initialize some phy regs from eeprom values in modal_header[]
- * acc. to band and bandwidth
- */
-static int ar9170_init_phy_from_eeprom(struct ar9170 *ar,
-                                bool is_2ghz, bool is_40mhz)
-{
-        static const u8 xpd2pd[16] = {
-                0x2, 0x2, 0x2, 0x1, 0x2, 0x2, 0x6, 0x2,
-                0x2, 0x3, 0x7, 0x2, 0xB, 0x2, 0x2, 0x2
-        };
-        u32 defval, newval;
-        /* pointer to the modal_header acc. to band */
-        struct ar9170_eeprom_modal *m = &ar->eeprom.modal_header[is_2ghz];
-        ar9170_regwrite_begin(ar);
-        /* ant common control (index 0) */
-        newval = le32_to_cpu(m->antCtrlCommon);
-        ar9170_regwrite(0x1c5964, newval);
-        /* ant control chain 0 (index 1) */
-        newval = le32_to_cpu(m->antCtrlChain[0]);
-        ar9170_regwrite(0x1c5960, newval);
-        /* ant control chain 2 (index 2) */
-        newval = le32_to_cpu(m->antCtrlChain[1]);
-        ar9170_regwrite(0x1c7960, newval);
-        /* SwSettle (index 3) */
-        if (!is_40mhz) {
-                defval = ar9170_get_default_phy_reg_val(0x1c5844,
-                                                        is_2ghz, is_40mhz);
-                newval = (defval & ~0x3f80) |
-                        ((m->switchSettling & 0x7f) << 7);
-                ar9170_regwrite(0x1c5844, newval);
-        }
-        /* adcDesired, pdaDesired (index 4) */
-        defval = ar9170_get_default_phy_reg_val(0x1c5850, is_2ghz, is_40mhz);
-        newval = (defval & ~0xffff) | ((u8)m->pgaDesiredSize << 8) |
-                ((u8)m->adcDesiredSize);
-        ar9170_regwrite(0x1c5850, newval);
-        /* TxEndToXpaOff, TxFrameToXpaOn (index 5) */
-        defval = ar9170_get_default_phy_reg_val(0x1c5834, is_2ghz, is_40mhz);
-        newval = (m->txEndToXpaOff << 24) | (m->txEndToXpaOff << 16) |
-                (m->txFrameToXpaOn << 8) | m->txFrameToXpaOn;
-        ar9170_regwrite(0x1c5834, newval);
-        /* TxEndToRxOn (index 6) */
-        defval = ar9170_get_default_phy_reg_val(0x1c5828, is_2ghz, is_40mhz);
-        newval = (defval & ~0xff0000) | (m->txEndToRxOn << 16);
-        ar9170_regwrite(0x1c5828, newval);
-        /* thresh62 (index 7) */
-        defval = ar9170_get_default_phy_reg_val(0x1c8864, is_2ghz, is_40mhz);
-        newval = (defval & ~0x7f000) | (m->thresh62 << 12);
-        ar9170_regwrite(0x1c8864, newval);
-        /* tx/rx attenuation chain 0 (index 8) */
-        defval = ar9170_get_default_phy_reg_val(0x1c5848, is_2ghz, is_40mhz);
-        newval = (defval & ~0x3f000) | ((m->txRxAttenCh[0] & 0x3f) << 12);
-        ar9170_regwrite(0x1c5848, newval);
-        /* tx/rx attenuation chain 2 (index 9) */
-        defval = ar9170_get_default_phy_reg_val(0x1c7848, is_2ghz, is_40mhz);
-        newval = (defval & ~0x3f000) | ((m->txRxAttenCh[1] & 0x3f) << 12);
-        ar9170_regwrite(0x1c7848, newval);
-        /* tx/rx margin chain 0 (index 10) */
-        defval = ar9170_get_default_phy_reg_val(0x1c620c, is_2ghz, is_40mhz);
-        newval = (defval & ~0xfc0000) | ((m->rxTxMarginCh[0] & 0x3f) << 18);
-        /* bsw margin chain 0 for 5GHz only */
-        if (!is_2ghz)
-                newval = (newval & ~0x3c00) | ((m->bswMargin[0] & 0xf) << 10);
-        ar9170_regwrite(0x1c620c, newval);
-        /* tx/rx margin chain 2 (index 11) */
-        defval = ar9170_get_default_phy_reg_val(0x1c820c, is_2ghz, is_40mhz);
-        newval = (defval & ~0xfc0000) | ((m->rxTxMarginCh[1] & 0x3f) << 18);
-        ar9170_regwrite(0x1c820c, newval);
-        /* iqCall, iqCallq chain 0 (index 12) */
-        defval = ar9170_get_default_phy_reg_val(0x1c5920, is_2ghz, is_40mhz);
-        newval = (defval & ~0x7ff) | (((u8)m->iqCalICh[0] & 0x3f) << 5) |
-                ((u8)m->iqCalQCh[0] & 0x1f);
-        ar9170_regwrite(0x1c5920, newval);
-        /* iqCall, iqCallq chain 2 (index 13) */
-        defval = ar9170_get_default_phy_reg_val(0x1c7920, is_2ghz, is_40mhz);
-        newval = (defval & ~0x7ff) | (((u8)m->iqCalICh[1] & 0x3f) << 5) |
-                ((u8)m->iqCalQCh[1] & 0x1f);
-        ar9170_regwrite(0x1c7920, newval);
-        /* xpd gain mask (index 14) */
-        defval = ar9170_get_default_phy_reg_val(0x1c6258, is_2ghz, is_40mhz);
-        newval = (defval & ~0xf0000) | (xpd2pd[m->xpdGain & 0xf] << 16);
-        ar9170_regwrite(0x1c6258, newval);
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-int ar9170_init_phy(struct ar9170 *ar, enum ieee80211_band band)
-{
-        int i, err;
-        u32 val;
-        bool is_2ghz = band == IEEE80211_BAND_2GHZ;
-        bool is_40mhz = conf_is_ht40(&ar->hw->conf);
-        ar9170_regwrite_begin(ar);
-        for (i = 0; i < ARRAY_SIZE(ar5416_phy_init); i++) {
-                if (is_40mhz) {
-                        if (is_2ghz)
-                                val = ar5416_phy_init[i]._2ghz_40;
-                        else
-                                val = ar5416_phy_init[i]._5ghz_40;
-                } else {
-                        if (is_2ghz)
-                                val = ar5416_phy_init[i]._2ghz_20;
-                        else
-                                val = ar5416_phy_init[i]._5ghz_20;
-                }
-                ar9170_regwrite(ar5416_phy_init[i].reg, val);
-        }
-        ar9170_regwrite_finish();
-        err = ar9170_regwrite_result();
-        if (err)
-                return err;
-        err = ar9170_init_phy_from_eeprom(ar, is_2ghz, is_40mhz);
-        if (err)
-                return err;
-        err = ar9170_init_power_cal(ar);
-        if (err)
-                return err;
-        /* XXX: remove magic! */
-        if (is_2ghz)
-                err = ar9170_write_reg(ar, 0x1d4014, 0x5163);
-        else
-                err = ar9170_write_reg(ar, 0x1d4014, 0x5143);
-        return err;
-}
-struct ar9170_rf_init {
-        u32 reg, _5ghz, _2ghz;
-};
-static struct ar9170_rf_init ar9170_rf_init[] = {
-     /* bank 0 */
-     { 0x1c58b0,  0x1e5795e5,  0x1e5795e5},
-     { 0x1c58e0,  0x02008020,  0x02008020},
-     /* bank 1 */
-     { 0x1c58b0,  0x02108421,  0x02108421},
-     { 0x1c58ec,  0x00000008,  0x00000008},
-     /* bank 2 */
-     { 0x1c58b0,  0x0e73ff17,  0x0e73ff17},
-     { 0x1c58e0,  0x00000420,  0x00000420},
-     /* bank 3 */
-     { 0x1c58f0,  0x01400018,  0x01c00018},
-     /* bank 4 */
-     { 0x1c58b0,  0x000001a1,  0x000001a1},
-     { 0x1c58e8,  0x00000001,  0x00000001},
-     /* bank 5 */
-     { 0x1c58b0,  0x00000013,  0x00000013},
-     { 0x1c58e4,  0x00000002,  0x00000002},
-     /* bank 6 */
-     { 0x1c58b0,  0x00000000,  0x00000000},
-     { 0x1c58b0,  0x00000000,  0x00000000},
-     { 0x1c58b0,  0x00000000,  0x00000000},
-     { 0x1c58b0,  0x00000000,  0x00000000},
-     { 0x1c58b0,  0x00000000,  0x00000000},
-     { 0x1c58b0,  0x00004000,  0x00004000},
-     { 0x1c58b0,  0x00006c00,  0x00006c00},
-     { 0x1c58b0,  0x00002c00,  0x00002c00},
-     { 0x1c58b0,  0x00004800,  0x00004800},
-     { 0x1c58b0,  0x00004000,  0x00004000},
-     { 0x1c58b0,  0x00006000,  0x00006000},
-     { 0x1c58b0,  0x00001000,  0x00001000},
-     { 0x1c58b0,  0x00004000,  0x00004000},
-     { 0x1c58b0,  0x00007c00,  0x00007c00},
-     { 0x1c58b0,  0x00007c00,  0x00007c00},
-     { 0x1c58b0,  0x00007c00,  0x00007c00},
-     { 0x1c58b0,  0x00007c00,  0x00007c00},
-     { 0x1c58b0,  0x00007c00,  0x00007c00},
-     { 0x1c58b0,  0x00087c00,  0x00087c00},
-     { 0x1c58b0,  0x00007c00,  0x00007c00},
-     { 0x1c58b0,  0x00005400,  0x00005400},
-     { 0x1c58b0,  0x00000c00,  0x00000c00},
-     { 0x1c58b0,  0x00001800,  0x00001800},
-     { 0x1c58b0,  0x00007c00,  0x00007c00},
-     { 0x1c58b0,  0x00006c00,  0x00006c00},
-     { 0x1c58b0,  0x00006c00,  0x00006c00},
-     { 0x1c58b0,  0x00007c00,  0x00007c00},
-     { 0x1c58b0,  0x00002c00,  0x00002c00},
-     { 0x1c58b0,  0x00003c00,  0x00003c00},
-     { 0x1c58b0,  0x00003800,  0x00003800},
-     { 0x1c58b0,  0x00001c00,  0x00001c00},
-     { 0x1c58b0,  0x00000800,  0x00000800},
-     { 0x1c58b0,  0x00000408,  0x00000408},
-     { 0x1c58b0,  0x00004c15,  0x00004c15},
-     { 0x1c58b0,  0x00004188,  0x00004188},
-     { 0x1c58b0,  0x0000201e,  0x0000201e},
-     { 0x1c58b0,  0x00010408,  0x00010408},
-     { 0x1c58b0,  0x00000801,  0x00000801},
-     { 0x1c58b0,  0x00000c08,  0x00000c08},
-     { 0x1c58b0,  0x0000181e,  0x0000181e},
-     { 0x1c58b0,  0x00001016,  0x00001016},
-     { 0x1c58b0,  0x00002800,  0x00002800},
-     { 0x1c58b0,  0x00004010,  0x00004010},
-     { 0x1c58b0,  0x0000081c,  0x0000081c},
-     { 0x1c58b0,  0x00000115,  0x00000115},
-     { 0x1c58b0,  0x00000015,  0x00000015},
-     { 0x1c58b0,  0x00000066,  0x00000066},
-     { 0x1c58b0,  0x0000001c,  0x0000001c},
-     { 0x1c58b0,  0x00000000,  0x00000000},
-     { 0x1c58b0,  0x00000004,  0x00000004},
-     { 0x1c58b0,  0x00000015,  0x00000015},
-     { 0x1c58b0,  0x0000001f,  0x0000001f},
-     { 0x1c58e0,  0x00000000,  0x00000400},
-     /* bank 7 */
-     { 0x1c58b0,  0x000000a0,  0x000000a0},
-     { 0x1c58b0,  0x00000000,  0x00000000},
-     { 0x1c58b0,  0x00000040,  0x00000040},
-     { 0x1c58f0,  0x0000001c,  0x0000001c},
-};
-static int ar9170_init_rf_banks_0_7(struct ar9170 *ar, bool band5ghz)
-{
-        int err, i;
-        ar9170_regwrite_begin(ar);
-        for (i = 0; i < ARRAY_SIZE(ar9170_rf_init); i++)
-                ar9170_regwrite(ar9170_rf_init[i].reg,
-                                band5ghz ? ar9170_rf_init[i]._5ghz
-                                         : ar9170_rf_init[i]._2ghz);
-        ar9170_regwrite_finish();
-        err = ar9170_regwrite_result();
-        if (err)
-                wiphy_err(ar->hw->wiphy, "rf init failed\n");
-        return err;
-}
-static int ar9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz,
-                                    u32 freq, enum ar9170_bw bw)
-{
-        int err;
-        u32 d0, d1, td0, td1, fd0, fd1;
-        u8 chansel;
-        u8 refsel0 = 1, refsel1 = 0;
-        u8 lf_synth = 0;
-        switch (bw) {
-        case AR9170_BW_40_ABOVE:
-                freq += 10;
-                break;
-        case AR9170_BW_40_BELOW:
-                freq -= 10;
-                break;
-        case AR9170_BW_20:
-                break;
-        case __AR9170_NUM_BW:
-                BUG();
-        }
-        if (band5ghz) {
-                if (freq % 10) {
-                        chansel = (freq - 4800) / 5;
-                } else {
-                        chansel = ((freq - 4800) / 10) * 2;
-                        refsel0 = 0;
-                        refsel1 = 1;
-                }
-                chansel = byte_rev_table[chansel];
-        } else {
-                if (freq == 2484) {
-                        chansel = 10 + (freq - 2274) / 5;
-                        lf_synth = 1;
-                } else
-                        chansel = 16 + (freq - 2272) / 5;
-                chansel *= 4;
-                chansel = byte_rev_table[chansel];
-        }
-        d1 =    chansel;
-        d0 =    0x21 |
-                refsel0 << 3 |
-                refsel1 << 2 |
-                lf_synth << 1;
-        td0 =   d0 & 0x1f;
-        td1 =   d1 & 0x1f;
-        fd0 =   td1 << 5 | td0;
-        td0 =   (d0 >> 5) & 0x7;
-        td1 =   (d1 >> 5) & 0x7;
-        fd1 =   td1 << 5 | td0;
-        ar9170_regwrite_begin(ar);
-        ar9170_regwrite(0x1c58b0, fd0);
-        ar9170_regwrite(0x1c58e8, fd1);
-        ar9170_regwrite_finish();
-        err = ar9170_regwrite_result();
-        if (err)
-                return err;
-        msleep(10);
-        return 0;
-}
-struct ar9170_phy_freq_params {
-        u8 coeff_exp;
-        u16 coeff_man;
-        u8 coeff_exp_shgi;
-        u16 coeff_man_shgi;
-};
-struct ar9170_phy_freq_entry {
-        u16 freq;
-        struct ar9170_phy_freq_params params[__AR9170_NUM_BW];
-};
-/* NB: must be in sync with channel tables in main! */
-static const struct ar9170_phy_freq_entry ar9170_phy_freq_params[] = {
-/*
- *      freq,
- *              20MHz,
- *              40MHz (below),
- *              40Mhz (above),
- */
-        { 2412, {
-                { 3, 21737, 3, 19563, },
-                { 3, 21827, 3, 19644, },
-                { 3, 21647, 3, 19482, },
-        } },
-        { 2417, {
-                { 3, 21692, 3, 19523, },
-                { 3, 21782, 3, 19604, },
-                { 3, 21602, 3, 19442, },
-        } },
-        { 2422, {
-                { 3, 21647, 3, 19482, },
-                { 3, 21737, 3, 19563, },
-                { 3, 21558, 3, 19402, },
-        } },
-        { 2427, {
-                { 3, 21602, 3, 19442, },
-                { 3, 21692, 3, 19523, },
-                { 3, 21514, 3, 19362, },
-        } },
-        { 2432, {
-                { 3, 21558, 3, 19402, },
-                { 3, 21647, 3, 19482, },
-                { 3, 21470, 3, 19323, },
-        } },
-        { 2437, {
-                { 3, 21514, 3, 19362, },
-                { 3, 21602, 3, 19442, },
-                { 3, 21426, 3, 19283, },
-        } },
-        { 2442, {
-                { 3, 21470, 3, 19323, },
-                { 3, 21558, 3, 19402, },
-                { 3, 21382, 3, 19244, },
-        } },
-        { 2447, {
-                { 3, 21426, 3, 19283, },
-                { 3, 21514, 3, 19362, },
-                { 3, 21339, 3, 19205, },
-        } },
-        { 2452, {
-                { 3, 21382, 3, 19244, },
-                { 3, 21470, 3, 19323, },
-                { 3, 21295, 3, 19166, },
-        } },
-        { 2457, {
-                { 3, 21339, 3, 19205, },
-                { 3, 21426, 3, 19283, },
-                { 3, 21252, 3, 19127, },
-        } },
-        { 2462, {
-                { 3, 21295, 3, 19166, },
-                { 3, 21382, 3, 19244, },
-                { 3, 21209, 3, 19088, },
-        } },
-        { 2467, {
-                { 3, 21252, 3, 19127, },
-                { 3, 21339, 3, 19205, },
-                { 3, 21166, 3, 19050, },
-        } },
-        { 2472, {
-                { 3, 21209, 3, 19088, },
-                { 3, 21295, 3, 19166, },
-                { 3, 21124, 3, 19011, },
-        } },
-        { 2484, {
-                { 3, 21107, 3, 18996, },
-                { 3, 21192, 3, 19073, },
-                { 3, 21022, 3, 18920, },
-        } },
-        { 4920, {
-                { 4, 21313, 4, 19181, },
-                { 4, 21356, 4, 19220, },
-                { 4, 21269, 4, 19142, },
-        } },
-        { 4940, {
-                { 4, 21226, 4, 19104, },
-                { 4, 21269, 4, 19142, },
-                { 4, 21183, 4, 19065, },
-        } },
-        { 4960, {
-                { 4, 21141, 4, 19027, },
-                { 4, 21183, 4, 19065, },
-                { 4, 21098, 4, 18988, },
-        } },
-        { 4980, {
-                { 4, 21056, 4, 18950, },
-                { 4, 21098, 4, 18988, },
-                { 4, 21014, 4, 18912, },
-        } },
-        { 5040, {
-                { 4, 20805, 4, 18725, },
-                { 4, 20846, 4, 18762, },
-                { 4, 20764, 4, 18687, },
-        } },
-        { 5060, {
-                { 4, 20723, 4, 18651, },
-                { 4, 20764, 4, 18687, },
-                { 4, 20682, 4, 18614, },
-        } },
-        { 5080, {
-                { 4, 20641, 4, 18577, },
-                { 4, 20682, 4, 18614, },
-                { 4, 20601, 4, 18541, },
-        } },
-        { 5180, {
-                { 4, 20243, 4, 18219, },
-                { 4, 20282, 4, 18254, },
-                { 4, 20204, 4, 18183, },
-        } },
-        { 5200, {
-                { 4, 20165, 4, 18148, },
-                { 4, 20204, 4, 18183, },
-                { 4, 20126, 4, 18114, },
-        } },
-        { 5220, {
-                { 4, 20088, 4, 18079, },
-                { 4, 20126, 4, 18114, },
-                { 4, 20049, 4, 18044, },
-        } },
-        { 5240, {
-                { 4, 20011, 4, 18010, },
-                { 4, 20049, 4, 18044, },
-                { 4, 19973, 4, 17976, },
-        } },
-        { 5260, {
-                { 4, 19935, 4, 17941, },
-                { 4, 19973, 4, 17976, },
-                { 4, 19897, 4, 17907, },
-        } },
-        { 5280, {
-                { 4, 19859, 4, 17873, },
-                { 4, 19897, 4, 17907, },
-                { 4, 19822, 4, 17840, },
-        } },
-        { 5300, {
-                { 4, 19784, 4, 17806, },
-                { 4, 19822, 4, 17840, },
-                { 4, 19747, 4, 17772, },
-        } },
-        { 5320, {
-                { 4, 19710, 4, 17739, },
-                { 4, 19747, 4, 17772, },
-                { 4, 19673, 4, 17706, },
-        } },
-        { 5500, {
-                { 4, 19065, 4, 17159, },
-                { 4, 19100, 4, 17190, },
-                { 4, 19030, 4, 17127, },
-        } },
-        { 5520, {
-                { 4, 18996, 4, 17096, },
-                { 4, 19030, 4, 17127, },
-                { 4, 18962, 4, 17065, },
-        } },
-        { 5540, {
-                { 4, 18927, 4, 17035, },
-                { 4, 18962, 4, 17065, },
-                { 4, 18893, 4, 17004, },
-        } },
-        { 5560, {
-                { 4, 18859, 4, 16973, },
-                { 4, 18893, 4, 17004, },
-                { 4, 18825, 4, 16943, },
-        } },
-        { 5580, {
-                { 4, 18792, 4, 16913, },
-                { 4, 18825, 4, 16943, },
-                { 4, 18758, 4, 16882, },
-        } },
-        { 5600, {
-                { 4, 18725, 4, 16852, },
-                { 4, 18758, 4, 16882, },
-                { 4, 18691, 4, 16822, },
-        } },
-        { 5620, {
-                { 4, 18658, 4, 16792, },
-                { 4, 18691, 4, 16822, },
-                { 4, 18625, 4, 16762, },
-        } },
-        { 5640, {
-                { 4, 18592, 4, 16733, },
-                { 4, 18625, 4, 16762, },
-                { 4, 18559, 4, 16703, },
-        } },
-        { 5660, {
-                { 4, 18526, 4, 16673, },
-                { 4, 18559, 4, 16703, },
-                { 4, 18493, 4, 16644, },
-        } },
-        { 5680, {
-                { 4, 18461, 4, 16615, },
-                { 4, 18493, 4, 16644, },
-                { 4, 18428, 4, 16586, },
-        } },
-        { 5700, {
-                { 4, 18396, 4, 16556, },
-                { 4, 18428, 4, 16586, },
-                { 4, 18364, 4, 16527, },
-        } },
-        { 5745, {
-                { 4, 18252, 4, 16427, },
-                { 4, 18284, 4, 16455, },
-                { 4, 18220, 4, 16398, },
-        } },
-        { 5765, {
-                { 4, 18189, 5, 32740, },
-                { 4, 18220, 4, 16398, },
-                { 4, 18157, 5, 32683, },
-        } },
-        { 5785, {
-                { 4, 18126, 5, 32626, },
-                { 4, 18157, 5, 32683, },
-                { 4, 18094, 5, 32570, },
-        } },
-        { 5805, {
-                { 4, 18063, 5, 32514, },
-                { 4, 18094, 5, 32570, },
-                { 4, 18032, 5, 32458, },
-        } },
-        { 5825, {
-                { 4, 18001, 5, 32402, },
-                { 4, 18032, 5, 32458, },
-                { 4, 17970, 5, 32347, },
-        } },
-        { 5170, {
-                { 4, 20282, 4, 18254, },
-                { 4, 20321, 4, 18289, },
-                { 4, 20243, 4, 18219, },
-        } },
-        { 5190, {
-                { 4, 20204, 4, 18183, },
-                { 4, 20243, 4, 18219, },
-                { 4, 20165, 4, 18148, },
-        } },
-        { 5210, {
-                { 4, 20126, 4, 18114, },
-                { 4, 20165, 4, 18148, },
-                { 4, 20088, 4, 18079, },
-        } },
-        { 5230, {
-                { 4, 20049, 4, 18044, },
-                { 4, 20088, 4, 18079, },
-                { 4, 20011, 4, 18010, },
-        } },
-};
-static const struct ar9170_phy_freq_params *
-ar9170_get_hw_dyn_params(struct ieee80211_channel *channel,
-                         enum ar9170_bw bw)
-{
-        unsigned int chanidx = 0;
-        u16 freq = 2412;
-        if (channel) {
-                chanidx = channel->hw_value;
-                freq = channel->center_freq;
-        }
-        BUG_ON(chanidx >= ARRAY_SIZE(ar9170_phy_freq_params));
-        BUILD_BUG_ON(__AR9170_NUM_BW != 3);
-        WARN_ON(ar9170_phy_freq_params[chanidx].freq != freq);
-        return &ar9170_phy_freq_params[chanidx].params[bw];
-}
-int ar9170_init_rf(struct ar9170 *ar)
-{
-        const struct ar9170_phy_freq_params *freqpar;
-        __le32 cmd[7];
-        int err;
-        err = ar9170_init_rf_banks_0_7(ar, false);
-        if (err)
-                return err;
-        err = ar9170_init_rf_bank4_pwr(ar, false, 2412, AR9170_BW_20);
-        if (err)
-                return err;
-        freqpar = ar9170_get_hw_dyn_params(NULL, AR9170_BW_20);
-        cmd[0] = cpu_to_le32(2412 * 1000);
-        cmd[1] = cpu_to_le32(0);
-        cmd[2] = cpu_to_le32(1);
-        cmd[3] = cpu_to_le32(freqpar->coeff_exp);
-        cmd[4] = cpu_to_le32(freqpar->coeff_man);
-        cmd[5] = cpu_to_le32(freqpar->coeff_exp_shgi);
-        cmd[6] = cpu_to_le32(freqpar->coeff_man_shgi);
-        /* RF_INIT echoes the command back to us */
-        err = ar->exec_cmd(ar, AR9170_CMD_RF_INIT,
-                           sizeof(cmd), (u8 *)cmd,
-                           sizeof(cmd), (u8 *)cmd);
-        if (err)
-                return err;
-        msleep(1000);
-        return ar9170_echo_test(ar, 0xaabbccdd);
-}
-static int ar9170_find_freq_idx(int nfreqs, u8 *freqs, u8 f)
-{
-        int idx = nfreqs - 2;
-        while (idx >= 0) {
-                if (f >= freqs[idx])
-                        return idx;
-                idx--;
-        }
-        return 0;
-}
-static s32 ar9170_interpolate_s32(s32 x, s32 x1, s32 y1, s32 x2, s32 y2)
-{
-        /* nothing to interpolate, it's horizontal */
-        if (y2 == y1)
-                return y1;
-        /* check if we hit one of the edges */
-        if (x == x1)
-                return y1;
-        if (x == x2)
-                return y2;
-        /* x1 == x2 is bad, hopefully == x */
-        if (x2 == x1)
-                return y1;
-        return y1 + (((y2 - y1) * (x - x1)) / (x2 - x1));
-}
-static u8 ar9170_interpolate_u8(u8 x, u8 x1, u8 y1, u8 x2, u8 y2)
-{
-#define SHIFT           8
-        s32 y;
-        y = ar9170_interpolate_s32(x << SHIFT,
-                                   x1 << SHIFT, y1 << SHIFT,
-                                   x2 << SHIFT, y2 << SHIFT);
-        /*
-         * XXX: unwrap this expression
-         *      Isn't it just DIV_ROUND_UP(y, 1<<SHIFT)?
-         *      Can we rely on the compiler to optimise away the div?
-         */
-        return (y >> SHIFT) + ((y & (1<<(SHIFT-1))) >> (SHIFT - 1));
-#undef SHIFT
-}
-static u8 ar9170_interpolate_val(u8 x, u8 *x_array, u8 *y_array)
-{
-        int i;
-        for (i = 0; i < 3; i++)
-                if (x <= x_array[i + 1])
-                        break;
-        return ar9170_interpolate_u8(x,
-                                     x_array[i],
-                                     y_array[i],
-                                     x_array[i + 1],
-                                     y_array[i + 1]);
-}
-static int ar9170_set_freq_cal_data(struct ar9170 *ar,
-                                    struct ieee80211_channel *channel)
-{
-        u8 *cal_freq_pier;
-        u8 vpds[2][AR5416_PD_GAIN_ICEPTS];
-        u8 pwrs[2][AR5416_PD_GAIN_ICEPTS];
-        int chain, idx, i;
-        u32 phy_data = 0;
-        u8 f, tmp;
-        switch (channel->band) {
-        case IEEE80211_BAND_2GHZ:
-                f = channel->center_freq - 2300;
-                cal_freq_pier = ar->eeprom.cal_freq_pier_2G;
-                i = AR5416_NUM_2G_CAL_PIERS - 1;
-                break;
-        case IEEE80211_BAND_5GHZ:
-                f = (channel->center_freq - 4800) / 5;
-                cal_freq_pier = ar->eeprom.cal_freq_pier_5G;
-                i = AR5416_NUM_5G_CAL_PIERS - 1;
-                break;
-        default:
-                return -EINVAL;
-                break;
-        }
-        for (; i >= 0; i--) {
-                if (cal_freq_pier[i] != 0xff)
-                        break;
-        }
-        if (i < 0)
-                return -EINVAL;
-        idx = ar9170_find_freq_idx(i, cal_freq_pier, f);
-        ar9170_regwrite_begin(ar);
-        for (chain = 0; chain < AR5416_MAX_CHAINS; chain++) {
-                for (i = 0; i < AR5416_PD_GAIN_ICEPTS; i++) {
-                        struct ar9170_calibration_data_per_freq *cal_pier_data;
-                        int j;
-                        switch (channel->band) {
-                        case IEEE80211_BAND_2GHZ:
-                                cal_pier_data = &ar->eeprom.
-                                        cal_pier_data_2G[chain][idx];
-                                break;
-                        case IEEE80211_BAND_5GHZ:
-                                cal_pier_data = &ar->eeprom.
-                                        cal_pier_data_5G[chain][idx];
-                                break;
-                        default:
-                                return -EINVAL;
-                        }
-                        for (j = 0; j < 2; j++) {
-                                vpds[j][i] = ar9170_interpolate_u8(f,
-                                        cal_freq_pier[idx],
-                                        cal_pier_data->vpd_pdg[j][i],
-                                        cal_freq_pier[idx + 1],
-                                        cal_pier_data[1].vpd_pdg[j][i]);
-                                pwrs[j][i] = ar9170_interpolate_u8(f,
-                                        cal_freq_pier[idx],
-                                        cal_pier_data->pwr_pdg[j][i],
-                                        cal_freq_pier[idx + 1],
-                                        cal_pier_data[1].pwr_pdg[j][i]) / 2;
-                        }
-                }
-                for (i = 0; i < 76; i++) {
-                        if (i < 25) {
-                                tmp = ar9170_interpolate_val(i, &pwrs[0][0],
-                                                             &vpds[0][0]);
-                        } else {
-                                tmp = ar9170_interpolate_val(i - 12,
-                                                             &pwrs[1][0],
-                                                             &vpds[1][0]);
-                        }
-                        phy_data |= tmp << ((i & 3) << 3);
-                        if ((i & 3) == 3) {
-                                ar9170_regwrite(0x1c6280 + chain * 0x1000 +
-                                                (i & ~3), phy_data);
-                                phy_data = 0;
-                        }
-                }
-                for (i = 19; i < 32; i++)
-                        ar9170_regwrite(0x1c6280 + chain * 0x1000 + (i << 2),
-                                        0x0);
-        }
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-static u8 ar9170_get_max_edge_power(struct ar9170 *ar,
-                                    struct ar9170_calctl_edges edges[],
-                                    u32 freq)
-{
-        int i;
-        u8 rc = AR5416_MAX_RATE_POWER;
-        u8 f;
-        if (freq < 3000)
-                f = freq - 2300;
-        else
-                f = (freq - 4800) / 5;
-        for (i = 0; i < AR5416_NUM_BAND_EDGES; i++) {
-                if (edges[i].channel == 0xff)
-                        break;
-                if (f == edges[i].channel) {
-                        /* exact freq match */
-                        rc = edges[i].power_flags & ~AR9170_CALCTL_EDGE_FLAGS;
-                        break;
-                }
-                if (i > 0 && f < edges[i].channel) {
-                        if (f > edges[i - 1].channel &&
-                            edges[i - 1].power_flags &
-                            AR9170_CALCTL_EDGE_FLAGS) {
-                                /* lower channel has the inband flag set */
-                                rc = edges[i - 1].power_flags &
-                                        ~AR9170_CALCTL_EDGE_FLAGS;
-                        }
-                        break;
-                }
-        }
-        if (i == AR5416_NUM_BAND_EDGES) {
-                if (f > edges[i - 1].channel &&
-                    edges[i - 1].power_flags & AR9170_CALCTL_EDGE_FLAGS) {
-                        /* lower channel has the inband flag set */
-                        rc = edges[i - 1].power_flags &
-                                ~AR9170_CALCTL_EDGE_FLAGS;
-                }
-        }
-        return rc;
-}
-static u8 ar9170_get_heavy_clip(struct ar9170 *ar,
-                                struct ar9170_calctl_edges edges[],
-                                u32 freq, enum ar9170_bw bw)
-{
-        u8 f;
-        int i;
-        u8 rc = 0;
-        if (freq < 3000)
-                f = freq - 2300;
-        else
-                f = (freq - 4800) / 5;
-        if (bw == AR9170_BW_40_BELOW || bw == AR9170_BW_40_ABOVE)
-                rc |= 0xf0;
-        for (i = 0; i < AR5416_NUM_BAND_EDGES; i++) {
-                if (edges[i].channel == 0xff)
-                        break;
-                if (f == edges[i].channel) {
-                        if (!(edges[i].power_flags & AR9170_CALCTL_EDGE_FLAGS))
-                                rc |= 0x0f;
-                        break;
-                }
-        }
-        return rc;
-}
-/*
- * calculate the conformance test limits and the heavy clip parameter
- * and apply them to ar->power* (derived from otus hal/hpmain.c, line 3706)
- */
-static void ar9170_calc_ctl(struct ar9170 *ar, u32 freq, enum ar9170_bw bw)
-{
-        u8 ctl_grp; /* CTL group */
-        u8 ctl_idx; /* CTL index */
-        int i, j;
-        struct ctl_modes {
-                u8 ctl_mode;
-                u8 max_power;
-                u8 *pwr_cal_data;
-                int pwr_cal_len;
-        } *modes;
-        /*
-         * order is relevant in the mode_list_*: we fall back to the
-         * lower indices if any mode is missed in the EEPROM.
-         */
-        struct ctl_modes mode_list_2ghz[] = {
-                { CTL_11B, 0, ar->power_2G_cck, 4 },
-                { CTL_11G, 0, ar->power_2G_ofdm, 4 },
-                { CTL_2GHT20, 0, ar->power_2G_ht20, 8 },
-                { CTL_2GHT40, 0, ar->power_2G_ht40, 8 },
-        };
-        struct ctl_modes mode_list_5ghz[] = {
-                { CTL_11A, 0, ar->power_5G_leg, 4 },
-                { CTL_5GHT20, 0, ar->power_5G_ht20, 8 },
-                { CTL_5GHT40, 0, ar->power_5G_ht40, 8 },
-        };
-        int nr_modes;
-#define EDGES(c, n) (ar->eeprom.ctl_data[c].control_edges[n])
-        ar->phy_heavy_clip = 0;
-        /*
-         * TODO: investigate the differences between OTUS'
-         * hpreg.c::zfHpGetRegulatoryDomain() and
-         * ath/regd.c::ath_regd_get_band_ctl() -
-         * e.g. for FCC3_WORLD the OTUS procedure
-         * always returns CTL_FCC, while the one in ath/ delivers
-         * CTL_ETSI for 2GHz and CTL_FCC for 5GHz.
-         */
-        ctl_grp = ath_regd_get_band_ctl(&ar->common.regulatory,
-                                        ar->hw->conf.channel->band);
-        /* ctl group not found - either invalid band (NO_CTL) or ww roaming */
-        if (ctl_grp == NO_CTL || ctl_grp == SD_NO_CTL)
-                ctl_grp = CTL_FCC;
-        if (ctl_grp != CTL_FCC)
-                /* skip CTL and heavy clip for CTL_MKK and CTL_ETSI */
-                return;
-        if (ar->hw->conf.channel->band == IEEE80211_BAND_2GHZ) {
-                modes = mode_list_2ghz;
-                nr_modes = ARRAY_SIZE(mode_list_2ghz);
-        } else {
-                modes = mode_list_5ghz;
-                nr_modes = ARRAY_SIZE(mode_list_5ghz);
-        }
-        for (i = 0; i < nr_modes; i++) {
-                u8 c = ctl_grp | modes[i].ctl_mode;
-                for (ctl_idx = 0; ctl_idx < AR5416_NUM_CTLS; ctl_idx++)
-                        if (c == ar->eeprom.ctl_index[ctl_idx])
-                                break;
-                if (ctl_idx < AR5416_NUM_CTLS) {
-                        int f_off = 0;
-                        /* determine heav clip parameter from
-                           the 11G edges array */
-                        if (modes[i].ctl_mode == CTL_11G) {
-                                ar->phy_heavy_clip =
-                                        ar9170_get_heavy_clip(ar,
-                                                              EDGES(ctl_idx, 1),
-                                                              freq, bw);
-                        }
-                        /* adjust freq for 40MHz */
-                        if (modes[i].ctl_mode == CTL_2GHT40 ||
-                            modes[i].ctl_mode == CTL_5GHT40) {
-                                if (bw == AR9170_BW_40_BELOW)
-                                        f_off = -10;
-                                else
-                                        f_off = 10;
-                        }
-                        modes[i].max_power =
-                                ar9170_get_max_edge_power(ar, EDGES(ctl_idx, 1),
-                                                          freq+f_off);
-                        /*
-                         * TODO: check if the regulatory max. power is
-                         *  controlled by cfg80211 for DFS
-                         * (hpmain applies it to max_power itself for DFS freq)
-                         */
-                } else {
-                        /*
-                         * Workaround in otus driver, hpmain.c, line 3906:
-                         * if no data for 5GHT20 are found, take the
-                         * legacy 5G value.
-                         * We extend this here to fallback from any other *HT or
-                         * 11G, too.
-                         */
-                        int k = i;
-                        modes[i].max_power = AR5416_MAX_RATE_POWER;
-                        while (k-- > 0) {
-                                if (modes[k].max_power !=
-                                    AR5416_MAX_RATE_POWER) {
-                                        modes[i].max_power = modes[k].max_power;
-                                        break;
-                                }
-                        }
-                }
-                /* apply max power to pwr_cal_data (ar->power_*) */
-                for (j = 0; j < modes[i].pwr_cal_len; j++) {
-                        modes[i].pwr_cal_data[j] = min(modes[i].pwr_cal_data[j],
-                                                       modes[i].max_power);
-                }
-        }
-        if (ar->phy_heavy_clip & 0xf0) {
-                ar->power_2G_ht40[0]--;
-                ar->power_2G_ht40[1]--;
-                ar->power_2G_ht40[2]--;
-        }
-        if (ar->phy_heavy_clip & 0xf) {
-                ar->power_2G_ht20[0]++;
-                ar->power_2G_ht20[1]++;
-                ar->power_2G_ht20[2]++;
-        }
-#undef EDGES
-}
-static int ar9170_set_power_cal(struct ar9170 *ar, u32 freq, enum ar9170_bw bw)
-{
-        struct ar9170_calibration_target_power_legacy *ctpl;
-        struct ar9170_calibration_target_power_ht *ctph;
-        u8 *ctpres;
-        int ntargets;
-        int idx, i, n;
-        u8 ackpower, ackchains, f;
-        u8 pwr_freqs[AR5416_MAX_NUM_TGT_PWRS];
-        if (freq < 3000)
-                f = freq - 2300;
-        else
-                f = (freq - 4800)/5;
-        /*
-         * cycle through the various modes
-         *
-         * legacy modes first: 5G, 2G CCK, 2G OFDM
-         */
-        for (i = 0; i < 3; i++) {
-                switch (i) {
-                case 0: /* 5 GHz legacy */
-                        ctpl = &ar->eeprom.cal_tgt_pwr_5G[0];
-                        ntargets = AR5416_NUM_5G_TARGET_PWRS;
-                        ctpres = ar->power_5G_leg;
-                        break;
-                case 1: /* 2.4 GHz CCK */
-                        ctpl = &ar->eeprom.cal_tgt_pwr_2G_cck[0];
-                        ntargets = AR5416_NUM_2G_CCK_TARGET_PWRS;
-                        ctpres = ar->power_2G_cck;
-                        break;
-                case 2: /* 2.4 GHz OFDM */
-                        ctpl = &ar->eeprom.cal_tgt_pwr_2G_ofdm[0];
-                        ntargets = AR5416_NUM_2G_OFDM_TARGET_PWRS;
-                        ctpres = ar->power_2G_ofdm;
-                        break;
-                default:
-                        BUG();
-                }
-                for (n = 0; n < ntargets; n++) {
-                        if (ctpl[n].freq == 0xff)
-                                break;
-                        pwr_freqs[n] = ctpl[n].freq;
-                }
-                ntargets = n;
-                idx = ar9170_find_freq_idx(ntargets, pwr_freqs, f);
-                for (n = 0; n < 4; n++)
-                        ctpres[n] = ar9170_interpolate_u8(
-                                        f,
-                                        ctpl[idx + 0].freq,
-                                        ctpl[idx + 0].power[n],
-                                        ctpl[idx + 1].freq,
-                                        ctpl[idx + 1].power[n]);
-        }
-        /*
-         * HT modes now: 5G HT20, 5G HT40, 2G CCK, 2G OFDM, 2G HT20, 2G HT40
-         */
-        for (i = 0; i < 4; i++) {
-                switch (i) {
-                case 0: /* 5 GHz HT 20 */
-                        ctph = &ar->eeprom.cal_tgt_pwr_5G_ht20[0];
-                        ntargets = AR5416_NUM_5G_TARGET_PWRS;
-                        ctpres = ar->power_5G_ht20;
-                        break;
-                case 1: /* 5 GHz HT 40 */
-                        ctph = &ar->eeprom.cal_tgt_pwr_5G_ht40[0];
-                        ntargets = AR5416_NUM_5G_TARGET_PWRS;
-                        ctpres = ar->power_5G_ht40;
-                        break;
-                case 2: /* 2.4 GHz HT 20 */
-                        ctph = &ar->eeprom.cal_tgt_pwr_2G_ht20[0];
-                        ntargets = AR5416_NUM_2G_OFDM_TARGET_PWRS;
-                        ctpres = ar->power_2G_ht20;
-                        break;
-                case 3: /* 2.4 GHz HT 40 */
-                        ctph = &ar->eeprom.cal_tgt_pwr_2G_ht40[0];
-                        ntargets = AR5416_NUM_2G_OFDM_TARGET_PWRS;
-                        ctpres = ar->power_2G_ht40;
-                        break;
-                default:
-                        BUG();
-                }
-                for (n = 0; n < ntargets; n++) {
-                        if (ctph[n].freq == 0xff)
-                                break;
-                        pwr_freqs[n] = ctph[n].freq;
-                }
-                ntargets = n;
-                idx = ar9170_find_freq_idx(ntargets, pwr_freqs, f);
-                for (n = 0; n < 8; n++)
-                        ctpres[n] = ar9170_interpolate_u8(
-                                        f,
-                                        ctph[idx + 0].freq,
-                                        ctph[idx + 0].power[n],
-                                        ctph[idx + 1].freq,
-                                        ctph[idx + 1].power[n]);
-        }
-        /* calc. conformance test limits and apply to ar->power*[] */
-        ar9170_calc_ctl(ar, freq, bw);
-        /* set ACK/CTS TX power */
-        ar9170_regwrite_begin(ar);
-        if (ar->eeprom.tx_mask != 1)
-                ackchains = AR9170_TX_PHY_TXCHAIN_2;
-        else
-                ackchains = AR9170_TX_PHY_TXCHAIN_1;
-        if (freq < 3000)
-                ackpower = ar->power_2G_ofdm[0] & 0x3f;
-        else
-                ackpower = ar->power_5G_leg[0] & 0x3f;
-        ar9170_regwrite(0x1c3694, ackpower << 20 | ackchains << 26);
-        ar9170_regwrite(0x1c3bb4, ackpower << 5 | ackchains << 11 |
-                                  ackpower << 21 | ackchains << 27);
-        ar9170_regwrite_finish();
-        return ar9170_regwrite_result();
-}
-static int ar9170_calc_noise_dbm(u32 raw_noise)
-{
-        if (raw_noise & 0x100)
-                return ~((raw_noise & 0x0ff) >> 1);
-        else
-                return (raw_noise & 0xff) >> 1;
-}
-int ar9170_set_channel(struct ar9170 *ar, struct ieee80211_channel *channel,
-                       enum ar9170_rf_init_mode rfi, enum ar9170_bw bw)
-{
-        const struct ar9170_phy_freq_params *freqpar;
-        u32 cmd, tmp, offs;
-        __le32 vals[8];
-        int i, err;
-        bool bandswitch;
-        /* clear BB heavy clip enable */
-        err = ar9170_write_reg(ar, 0x1c59e0, 0x200);
-        if (err)
-                return err;
-        /* may be NULL at first setup */
-        if (ar->channel)
-                bandswitch = ar->channel->band != channel->band;
-        else
-                bandswitch = true;
-        /* HW workaround */
-        if (!ar->hw->wiphy->bands[IEEE80211_BAND_5GHZ] &&
-            channel->center_freq <= 2417)
-                bandswitch = true;
-        err = ar->exec_cmd(ar, AR9170_CMD_FREQ_START, 0, NULL, 0, NULL);
-        if (err)
-                return err;
-        if (rfi != AR9170_RFI_NONE || bandswitch) {
-                u32 val = 0x400;
-                if (rfi == AR9170_RFI_COLD)
-                        val = 0x800;
-                /* warm/cold reset BB/ADDA */
-                err = ar9170_write_reg(ar, 0x1d4004, val);
-                if (err)
-                        return err;
-                err = ar9170_write_reg(ar, 0x1d4004, 0x0);
-                if (err)
-                        return err;
-                err = ar9170_init_phy(ar, channel->band);
-                if (err)
-                        return err;
-                err = ar9170_init_rf_banks_0_7(ar,
-                        channel->band == IEEE80211_BAND_5GHZ);
-                if (err)
-                        return err;
-                cmd = AR9170_CMD_RF_INIT;
-        } else {
-                cmd = AR9170_CMD_FREQUENCY;
-        }
-        err = ar9170_init_rf_bank4_pwr(ar,
-                channel->band == IEEE80211_BAND_5GHZ,
-                channel->center_freq, bw);
-        if (err)
-                return err;
-        switch (bw) {
-        case AR9170_BW_20:
-                tmp = 0x240;
-                offs = 0;
-                break;
-        case AR9170_BW_40_BELOW:
-                tmp = 0x2c4;
-                offs = 3;
-                break;
-        case AR9170_BW_40_ABOVE:
-                tmp = 0x2d4;
-                offs = 1;
-                break;
-        default:
-                BUG();
-                return -ENOSYS;
-        }
-        if (ar->eeprom.tx_mask != 1)
-                tmp |= 0x100;
-        err = ar9170_write_reg(ar, 0x1c5804, tmp);
-        if (err)
-                return err;
-        err = ar9170_set_freq_cal_data(ar, channel);
-        if (err)
-                return err;
-        err = ar9170_set_power_cal(ar, channel->center_freq, bw);
-        if (err)
-                return err;
-        freqpar = ar9170_get_hw_dyn_params(channel, bw);
-        vals[0] = cpu_to_le32(channel->center_freq * 1000);
-        vals[1] = cpu_to_le32(conf_is_ht40(&ar->hw->conf));
-        vals[2] = cpu_to_le32(offs << 2 | 1);
-        vals[3] = cpu_to_le32(freqpar->coeff_exp);
-        vals[4] = cpu_to_le32(freqpar->coeff_man);
-        vals[5] = cpu_to_le32(freqpar->coeff_exp_shgi);
-        vals[6] = cpu_to_le32(freqpar->coeff_man_shgi);
-        vals[7] = cpu_to_le32(1000);
-        err = ar->exec_cmd(ar, cmd, sizeof(vals), (u8 *)vals,
-                           sizeof(vals), (u8 *)vals);
-        if (err)
-                return err;
-        if (ar->phy_heavy_clip) {
-                err = ar9170_write_reg(ar, 0x1c59e0,
-                                       0x200 | ar->phy_heavy_clip);
-                if (err) {
-                        if (ar9170_nag_limiter(ar))
-                                wiphy_err(ar->hw->wiphy,
-                                          "failed to set heavy clip\n");
-                }
-        }
-        for (i = 0; i < 2; i++) {
-                ar->noise[i] = ar9170_calc_noise_dbm(
-                                (le32_to_cpu(vals[2 + i]) >> 19) & 0x1ff);
-                ar->noise[i + 2] = ar9170_calc_noise_dbm(
-                                    (le32_to_cpu(vals[5 + i]) >> 23) & 0x1ff);
-        }
-        ar->channel = channel;
-        return 0;
-}
diff --git a/drivers/net/wireless/ath/ar9170/usb.c b/drivers/net/wireless/ath/ar9170/usb.c
deleted file mode 100644
index d3be6f9816b5..000000000000
--- a/drivers/net/wireless/ath/ar9170/usb.c
+++ /dev/null
@@ -1,1008 +0,0 @@
-/*
- * Atheros AR9170 driver
- *
- * USB - frontend
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- * Copyright 2009, Christian Lamparter <chunkeey@web.de>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#include <linux/module.h>
-#include <linux/slab.h>
-#include <linux/usb.h>
-#include <linux/firmware.h>
-#include <linux/etherdevice.h>
-#include <linux/device.h>
-#include <net/mac80211.h>
-#include "ar9170.h"
-#include "cmd.h"
-#include "hw.h"
-#include "usb.h"
-MODULE_AUTHOR("Johannes Berg <johannes@sipsolutions.net>");
-MODULE_AUTHOR("Christian Lamparter <chunkeey@web.de>");
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("Atheros AR9170 802.11n USB wireless");
-MODULE_FIRMWARE("ar9170.fw");
-enum ar9170_requirements {
-        AR9170_REQ_FW1_ONLY = 1,
-};
-static struct usb_device_id ar9170_usb_ids[] = {
-        /* Atheros 9170 */
-        { USB_DEVICE(0x0cf3, 0x9170) },
-        /* Atheros TG121N */
-        { USB_DEVICE(0x0cf3, 0x1001) },
-        /* TP-Link TL-WN821N v2 */
-        { USB_DEVICE(0x0cf3, 0x1002) },
-        /* 3Com Dual Band 802.11n USB Adapter */
-        { USB_DEVICE(0x0cf3, 0x1010) },
-        /* H3C Dual Band 802.11n USB Adapter */
-        { USB_DEVICE(0x0cf3, 0x1011) },
-        /* Cace Airpcap NX */
-        { USB_DEVICE(0xcace, 0x0300) },
-        /* D-Link DWA 160 A1 */
-        { USB_DEVICE(0x07d1, 0x3c10) },
-        /* D-Link DWA 160 A2 */
-        { USB_DEVICE(0x07d1, 0x3a09) },
-        /* Netgear WNA1000 */
-        { USB_DEVICE(0x0846, 0x9040) },
-        /* Netgear WNDA3100 */
-        { USB_DEVICE(0x0846, 0x9010) },
-        /* Netgear WN111 v2 */
-        { USB_DEVICE(0x0846, 0x9001) },
-        /* Zydas ZD1221 */
-        { USB_DEVICE(0x0ace, 0x1221) },
-        /* Proxim ORiNOCO 802.11n USB */
-        { USB_DEVICE(0x1435, 0x0804) },
-        /* WNC Generic 11n USB Dongle */
-        { USB_DEVICE(0x1435, 0x0326) },
-        /* ZyXEL NWD271N */
-        { USB_DEVICE(0x0586, 0x3417) },
-        /* Z-Com UB81 BG */
-        { USB_DEVICE(0x0cde, 0x0023) },
-        /* Z-Com UB82 ABG */
-        { USB_DEVICE(0x0cde, 0x0026) },
-        /* Sphairon Homelink 1202 */
-        { USB_DEVICE(0x0cde, 0x0027) },
-        /* Arcadyan WN7512 */
-        { USB_DEVICE(0x083a, 0xf522) },
-        /* Planex GWUS300 */
-        { USB_DEVICE(0x2019, 0x5304) },
-        /* IO-Data WNGDNUS2 */
-        { USB_DEVICE(0x04bb, 0x093f) },
-        /* AVM FRITZ!WLAN USB Stick N */
-        { USB_DEVICE(0x057C, 0x8401) },
-        /* NEC WL300NU-G */
-        { USB_DEVICE(0x0409, 0x0249) },
-        /* AVM FRITZ!WLAN USB Stick N 2.4 */
-        { USB_DEVICE(0x057C, 0x8402), .driver_info = AR9170_REQ_FW1_ONLY },
-        /* Qwest/Actiontec 802AIN Wireless N USB Network Adapter */
-        { USB_DEVICE(0x1668, 0x1200) },
-        /* terminate */
-        {}
-};
-MODULE_DEVICE_TABLE(usb, ar9170_usb_ids);
-static void ar9170_usb_submit_urb(struct ar9170_usb *aru)
-{
-        struct urb *urb;
-        unsigned long flags;
-        int err;
-        if (unlikely(!IS_STARTED(&aru->common)))
-                return ;
-        spin_lock_irqsave(&aru->tx_urb_lock, flags);
-        if (atomic_read(&aru->tx_submitted_urbs) >= AR9170_NUM_TX_URBS) {
-                spin_unlock_irqrestore(&aru->tx_urb_lock, flags);
-                return ;
-        }
-        atomic_inc(&aru->tx_submitted_urbs);
-        urb = usb_get_from_anchor(&aru->tx_pending);
-        if (!urb) {
-                atomic_dec(&aru->tx_submitted_urbs);
-                spin_unlock_irqrestore(&aru->tx_urb_lock, flags);
-                return ;
-        }
-        spin_unlock_irqrestore(&aru->tx_urb_lock, flags);
-        aru->tx_pending_urbs--;
-        usb_anchor_urb(urb, &aru->tx_submitted);
-        err = usb_submit_urb(urb, GFP_ATOMIC);
-        if (unlikely(err)) {
-                if (ar9170_nag_limiter(&aru->common))
-                        dev_err(&aru->udev->dev, "submit_urb failed (%d).\n",
-                                err);
-                usb_unanchor_urb(urb);
-                atomic_dec(&aru->tx_submitted_urbs);
-                ar9170_tx_callback(&aru->common, urb->context);
-        }
-        usb_free_urb(urb);
-}
-static void ar9170_usb_tx_urb_complete_frame(struct urb *urb)
-{
-        struct sk_buff *skb = urb->context;
-        struct ar9170_usb *aru = usb_get_intfdata(usb_ifnum_to_if(urb->dev, 0));
-        if (unlikely(!aru)) {
-                dev_kfree_skb_irq(skb);
-                return ;
-        }
-        atomic_dec(&aru->tx_submitted_urbs);
-        ar9170_tx_callback(&aru->common, skb);
-        ar9170_usb_submit_urb(aru);
-}
-static void ar9170_usb_tx_urb_complete(struct urb *urb)
-{
-}
-static void ar9170_usb_irq_completed(struct urb *urb)
-{
-        struct ar9170_usb *aru = urb->context;
-        switch (urb->status) {
-        /* everything is fine */
-        case 0:
-                break;
-        /* disconnect */
-        case -ENOENT:
-        case -ECONNRESET:
-        case -ENODEV:
-        case -ESHUTDOWN:
-                goto free;
-        default:
-                goto resubmit;
-        }
-        ar9170_handle_command_response(&aru->common, urb->transfer_buffer,
-                                       urb->actual_length);
-resubmit:
-        usb_anchor_urb(urb, &aru->rx_submitted);
-        if (usb_submit_urb(urb, GFP_ATOMIC)) {
-                usb_unanchor_urb(urb);
-                goto free;
-        }
-        return;
-free:
-        usb_free_coherent(aru->udev, 64, urb->transfer_buffer, urb->transfer_dma);
-}
-static void ar9170_usb_rx_completed(struct urb *urb)
-{
-        struct sk_buff *skb = urb->context;
-        struct ar9170_usb *aru = usb_get_intfdata(usb_ifnum_to_if(urb->dev, 0));
-        int err;
-        if (!aru)
-                goto free;
-        switch (urb->status) {
-        /* everything is fine */
-        case 0:
-                break;
-        /* disconnect */
-        case -ENOENT:
-        case -ECONNRESET:
-        case -ENODEV:
-        case -ESHUTDOWN:
-                goto free;
-        default:
-                goto resubmit;
-        }
-        skb_put(skb, urb->actual_length);
-        ar9170_rx(&aru->common, skb);
-resubmit:
-        skb_reset_tail_pointer(skb);
-        skb_trim(skb, 0);
-        usb_anchor_urb(urb, &aru->rx_submitted);
-        err = usb_submit_urb(urb, GFP_ATOMIC);
-        if (unlikely(err)) {
-                usb_unanchor_urb(urb);
-                goto free;
-        }
-        return ;
-free:
-        dev_kfree_skb_irq(skb);
-}
-static int ar9170_usb_prep_rx_urb(struct ar9170_usb *aru,
-                                  struct urb *urb, gfp_t gfp)
-{
-        struct sk_buff *skb;
-        skb = __dev_alloc_skb(AR9170_MAX_RX_BUFFER_SIZE + 32, gfp);
-        if (!skb)
-                return -ENOMEM;
-        /* reserve some space for mac80211's radiotap */
-        skb_reserve(skb, 32);
-        usb_fill_bulk_urb(urb, aru->udev,
-                          usb_rcvbulkpipe(aru->udev, AR9170_EP_RX),
-                          skb->data, min(skb_tailroom(skb),
-                          AR9170_MAX_RX_BUFFER_SIZE),
-                          ar9170_usb_rx_completed, skb);
-        return 0;
-}
-static int ar9170_usb_alloc_rx_irq_urb(struct ar9170_usb *aru)
-{
-        struct urb *urb = NULL;
-        void *ibuf;
-        int err = -ENOMEM;
-        /* initialize interrupt endpoint */
-        urb = usb_alloc_urb(0, GFP_KERNEL);
-        if (!urb)
-                goto out;
-        ibuf = usb_alloc_coherent(aru->udev, 64, GFP_KERNEL, &urb->transfer_dma);
-        if (!ibuf)
-                goto out;
-        usb_fill_int_urb(urb, aru->udev,
-                         usb_rcvintpipe(aru->udev, AR9170_EP_IRQ), ibuf,
-                         64, ar9170_usb_irq_completed, aru, 1);
-        urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
-        usb_anchor_urb(urb, &aru->rx_submitted);
-        err = usb_submit_urb(urb, GFP_KERNEL);
-        if (err) {
-                usb_unanchor_urb(urb);
-                usb_free_coherent(aru->udev, 64, urb->transfer_buffer,
-                                  urb->transfer_dma);
-        }
-out:
-        usb_free_urb(urb);
-        return err;
-}
-static int ar9170_usb_alloc_rx_bulk_urbs(struct ar9170_usb *aru)
-{
-        struct urb *urb;
-        int i;
-        int err = -EINVAL;
-        for (i = 0; i < AR9170_NUM_RX_URBS; i++) {
-                err = -ENOMEM;
-                urb = usb_alloc_urb(0, GFP_KERNEL);
-                if (!urb)
-                        goto err_out;
-                err = ar9170_usb_prep_rx_urb(aru, urb, GFP_KERNEL);
-                if (err) {
-                        usb_free_urb(urb);
-                        goto err_out;
-                }
-                usb_anchor_urb(urb, &aru->rx_submitted);
-                err = usb_submit_urb(urb, GFP_KERNEL);
-                if (err) {
-                        usb_unanchor_urb(urb);
-                        dev_kfree_skb_any((void *) urb->transfer_buffer);
-                        usb_free_urb(urb);
-                        goto err_out;
-                }
-                usb_free_urb(urb);
-        }
-        /* the device now waiting for a firmware. */
-        aru->common.state = AR9170_IDLE;
-        return 0;
-err_out:
-        usb_kill_anchored_urbs(&aru->rx_submitted);
-        return err;
-}
-static int ar9170_usb_flush(struct ar9170 *ar)
-{
-        struct ar9170_usb *aru = (void *) ar;
-        struct urb *urb;
-        int ret, err = 0;
-        if (IS_STARTED(ar))
-                aru->common.state = AR9170_IDLE;
-        usb_wait_anchor_empty_timeout(&aru->tx_pending,
-                                            msecs_to_jiffies(800));
-        while ((urb = usb_get_from_anchor(&aru->tx_pending))) {
-                ar9170_tx_callback(&aru->common, (void *) urb->context);
-                usb_free_urb(urb);
-        }
-        /* lets wait a while until the tx - queues are dried out */
-        ret = usb_wait_anchor_empty_timeout(&aru->tx_submitted,
-                                            msecs_to_jiffies(100));
-        if (ret == 0)
-                err = -ETIMEDOUT;
-        usb_kill_anchored_urbs(&aru->tx_submitted);
-        if (IS_ACCEPTING_CMD(ar))
-                aru->common.state = AR9170_STARTED;
-        return err;
-}
-static void ar9170_usb_cancel_urbs(struct ar9170_usb *aru)
-{
-        int err;
-        aru->common.state = AR9170_UNKNOWN_STATE;
-        err = ar9170_usb_flush(&aru->common);
-        if (err)
-                dev_err(&aru->udev->dev, "stuck tx urbs!\n");
-        usb_poison_anchored_urbs(&aru->tx_submitted);
-        usb_poison_anchored_urbs(&aru->rx_submitted);
-}
-static int ar9170_usb_exec_cmd(struct ar9170 *ar, enum ar9170_cmd cmd,
-                               unsigned int plen, void *payload,
-                               unsigned int outlen, void *out)
-{
-        struct ar9170_usb *aru = (void *) ar;
-        struct urb *urb = NULL;
-        unsigned long flags;
-        int err = -ENOMEM;
-        if (unlikely(!IS_ACCEPTING_CMD(ar)))
-                return -EPERM;
-        if (WARN_ON(plen > AR9170_MAX_CMD_LEN - 4))
-                return -EINVAL;
-        urb = usb_alloc_urb(0, GFP_ATOMIC);
-        if (unlikely(!urb))
-                goto err_free;
-        ar->cmdbuf[0] = cpu_to_le32(plen);
-        ar->cmdbuf[0] |= cpu_to_le32(cmd << 8);
-        /* writing multiple regs fills this buffer already */
-        if (plen && payload != (u8 *)(&ar->cmdbuf[1]))
-                memcpy(&ar->cmdbuf[1], payload, plen);
-        spin_lock_irqsave(&aru->common.cmdlock, flags);
-        aru->readbuf = (u8 *)out;
-        aru->readlen = outlen;
-        spin_unlock_irqrestore(&aru->common.cmdlock, flags);
-        usb_fill_int_urb(urb, aru->udev,
-                         usb_sndintpipe(aru->udev, AR9170_EP_CMD),
-                         aru->common.cmdbuf, plen + 4,
-                         ar9170_usb_tx_urb_complete, NULL, 1);
-        usb_anchor_urb(urb, &aru->tx_submitted);
-        err = usb_submit_urb(urb, GFP_ATOMIC);
-        if (unlikely(err)) {
-                usb_unanchor_urb(urb);
-                usb_free_urb(urb);
-                goto err_unbuf;
-        }
-        usb_free_urb(urb);
-        err = wait_for_completion_timeout(&aru->cmd_wait, HZ);
-        if (err == 0) {
-                err = -ETIMEDOUT;
-                goto err_unbuf;
-        }
-        if (aru->readlen != outlen) {
-                err = -EMSGSIZE;
-                goto err_unbuf;
-        }
-        return 0;
-err_unbuf:
-        /* Maybe the device was removed in the second we were waiting? */
-        if (IS_STARTED(ar)) {
-                dev_err(&aru->udev->dev, "no command feedback "
-                                         "received (%d).\n", err);
-                /* provide some maybe useful debug information */
-                print_hex_dump_bytes("ar9170 cmd: ", DUMP_PREFIX_NONE,
-                                     aru->common.cmdbuf, plen + 4);
-                dump_stack();
-        }
-        /* invalidate to avoid completing the next prematurely */
-        spin_lock_irqsave(&aru->common.cmdlock, flags);
-        aru->readbuf = NULL;
-        aru->readlen = 0;
-        spin_unlock_irqrestore(&aru->common.cmdlock, flags);
-err_free:
-        return err;
-}
-static int ar9170_usb_tx(struct ar9170 *ar, struct sk_buff *skb)
-{
-        struct ar9170_usb *aru = (struct ar9170_usb *) ar;
-        struct urb *urb;
-        if (unlikely(!IS_STARTED(ar))) {
-                /* Seriously, what were you drink... err... thinking!? */
-                return -EPERM;
-        }
-        urb = usb_alloc_urb(0, GFP_ATOMIC);
-        if (unlikely(!urb))
-                return -ENOMEM;
-        usb_fill_bulk_urb(urb, aru->udev,
-                          usb_sndbulkpipe(aru->udev, AR9170_EP_TX),
-                          skb->data, skb->len,
-                          ar9170_usb_tx_urb_complete_frame, skb);
-        urb->transfer_flags |= URB_ZERO_PACKET;
-        usb_anchor_urb(urb, &aru->tx_pending);
-        aru->tx_pending_urbs++;
-        usb_free_urb(urb);
-        ar9170_usb_submit_urb(aru);
-        return 0;
-}
-static void ar9170_usb_callback_cmd(struct ar9170 *ar, u32 len , void *buffer)
-{
-        struct ar9170_usb *aru = (void *) ar;
-        unsigned long flags;
-        u32 in, out;
-        if (unlikely(!buffer))
-                return ;
-        in = le32_to_cpup((__le32 *)buffer);
-        out = le32_to_cpu(ar->cmdbuf[0]);
-        /* mask off length byte */
-        out &= ~0xFF;
-        if (aru->readlen >= 0) {
-                /* add expected length */
-                out |= aru->readlen;
-        } else {
-                /* add obtained length */
-                out |= in & 0xFF;
-        }
-        /*
-         * Some commands (e.g: AR9170_CMD_FREQUENCY) have a variable response
-         * length and we cannot predict the correct length in advance.
-         * So we only check if we provided enough space for the data.
-         */
-        if (unlikely(out < in)) {
-                dev_warn(&aru->udev->dev, "received invalid command response "
-                                          "got %d bytes, instead of %d bytes "
-                                          "and the resp length is %d bytes\n",
-                         in, out, len);
-                print_hex_dump_bytes("ar9170 invalid resp: ",
-                                     DUMP_PREFIX_OFFSET, buffer, len);
-                /*
-                 * Do not complete, then the command times out,
-                 * and we get a stack trace from there.
-                 */
-                return ;
-        }
-        spin_lock_irqsave(&aru->common.cmdlock, flags);
-        if (aru->readbuf && len > 0) {
-                memcpy(aru->readbuf, buffer + 4, len - 4);
-                aru->readbuf = NULL;
-        }
-        complete(&aru->cmd_wait);
-        spin_unlock_irqrestore(&aru->common.cmdlock, flags);
-}
-static int ar9170_usb_upload(struct ar9170_usb *aru, const void *data,
-                             size_t len, u32 addr, bool complete)
-{
-        int transfer, err;
-        u8 *buf = kmalloc(4096, GFP_KERNEL);
-        if (!buf)
-                return -ENOMEM;
-        while (len) {
-                transfer = min_t(int, len, 4096);
-                memcpy(buf, data, transfer);
-                err = usb_control_msg(aru->udev, usb_sndctrlpipe(aru->udev, 0),
-                                      0x30 /* FW DL */, 0x40 | USB_DIR_OUT,
-                                      addr >> 8, 0, buf, transfer, 1000);
-                if (err < 0) {
-                        kfree(buf);
-                        return err;
-                }
-                len -= transfer;
-                data += transfer;
-                addr += transfer;
-        }
-        kfree(buf);
-        if (complete) {
-                err = usb_control_msg(aru->udev, usb_sndctrlpipe(aru->udev, 0),
-                                      0x31 /* FW DL COMPLETE */,
-                                      0x40 | USB_DIR_OUT, 0, 0, NULL, 0, 5000);
-        }
-        return 0;
-}
-static int ar9170_usb_reset(struct ar9170_usb *aru)
-{
-        int ret, lock = (aru->intf->condition != USB_INTERFACE_BINDING);
-        if (lock) {
-                ret = usb_lock_device_for_reset(aru->udev, aru->intf);
-                if (ret < 0) {
-                        dev_err(&aru->udev->dev, "unable to lock device "
-                                "for reset (%d).\n", ret);
-                        return ret;
-                }
-        }
-        ret = usb_reset_device(aru->udev);
-        if (lock)
-                usb_unlock_device(aru->udev);
-        /* let it rest - for a second - */
-        msleep(1000);
-        return ret;
-}
-static int ar9170_usb_upload_firmware(struct ar9170_usb *aru)
-{
-        int err;
-        if (!aru->init_values)
-                goto upload_fw_start;
-        /* First, upload initial values to device RAM */
-        err = ar9170_usb_upload(aru, aru->init_values->data,
-                                aru->init_values->size, 0x102800, false);
-        if (err) {
-                dev_err(&aru->udev->dev, "firmware part 1 "
-                        "upload failed (%d).\n", err);
-                return err;
-        }
-upload_fw_start:
-        /* Then, upload the firmware itself and start it */
-        return ar9170_usb_upload(aru, aru->firmware->data, aru->firmware->size,
-                                0x200000, true);
-}
-static int ar9170_usb_init_transport(struct ar9170_usb *aru)
-{
-        struct ar9170 *ar = (void *) &aru->common;
-        int err;
-        ar9170_regwrite_begin(ar);
-        /* Set USB Rx stream mode MAX packet number to 2 */
-        ar9170_regwrite(AR9170_USB_REG_MAX_AGG_UPLOAD, 0x4);
-        /* Set USB Rx stream mode timeout to 10us */
-        ar9170_regwrite(AR9170_USB_REG_UPLOAD_TIME_CTL, 0x80);
-        ar9170_regwrite_finish();
-        err = ar9170_regwrite_result();
-        if (err)
-                dev_err(&aru->udev->dev, "USB setup failed (%d).\n", err);
-        return err;
-}
-static void ar9170_usb_stop(struct ar9170 *ar)
-{
-        struct ar9170_usb *aru = (void *) ar;
-        int ret;
-        if (IS_ACCEPTING_CMD(ar))
-                aru->common.state = AR9170_STOPPED;
-        ret = ar9170_usb_flush(ar);
-        if (ret)
-                dev_err(&aru->udev->dev, "kill pending tx urbs.\n");
-        usb_poison_anchored_urbs(&aru->tx_submitted);
-        /*
-         * Note:
-         * So far we freed all tx urbs, but we won't dare to touch any rx urbs.
-         * Else we would end up with a unresponsive device...
-         */
-}
-static int ar9170_usb_open(struct ar9170 *ar)
-{
-        struct ar9170_usb *aru = (void *) ar;
-        int err;
-        usb_unpoison_anchored_urbs(&aru->tx_submitted);
-        err = ar9170_usb_init_transport(aru);
-        if (err) {
-                usb_poison_anchored_urbs(&aru->tx_submitted);
-                return err;
-        }
-        aru->common.state = AR9170_IDLE;
-        return 0;
-}
-static int ar9170_usb_init_device(struct ar9170_usb *aru)
-{
-        int err;
-        err = ar9170_usb_alloc_rx_irq_urb(aru);
-        if (err)
-                goto err_out;
-        err = ar9170_usb_alloc_rx_bulk_urbs(aru);
-        if (err)
-                goto err_unrx;
-        err = ar9170_usb_upload_firmware(aru);
-        if (err) {
-                err = ar9170_echo_test(&aru->common, 0x60d43110);
-                if (err) {
-                        /* force user invention, by disabling the device */
-                        err = usb_driver_set_configuration(aru->udev, -1);
-                        dev_err(&aru->udev->dev, "device is in a bad state. "
-                                                 "please reconnect it!\n");
-                        goto err_unrx;
-                }
-        }
-        return 0;
-err_unrx:
-        ar9170_usb_cancel_urbs(aru);
-err_out:
-        return err;
-}
-static void ar9170_usb_firmware_failed(struct ar9170_usb *aru)
-{
-        struct device *parent = aru->udev->dev.parent;
-        struct usb_device *udev;
-        /*
-         * Store a copy of the usb_device pointer locally.
-         * This is because device_release_driver initiates
-         * ar9170_usb_disconnect, which in turn frees our
-         * driver context (aru).
-         */
-        udev = aru->udev;
-        complete(&aru->firmware_loading_complete);
-        /* unbind anything failed */
-        if (parent)
-                device_lock(parent);
-        device_release_driver(&udev->dev);
-        if (parent)
-                device_unlock(parent);
-        usb_put_dev(udev);
-}
-static void ar9170_usb_firmware_finish(const struct firmware *fw, void *context)
-{
-        struct ar9170_usb *aru = context;
-        int err;
-        aru->firmware = fw;
-        if (!fw) {
-                dev_err(&aru->udev->dev, "firmware file not found.\n");
-                goto err_freefw;
-        }
-        err = ar9170_usb_init_device(aru);
-        if (err)
-                goto err_freefw;
-        err = ar9170_usb_open(&aru->common);
-        if (err)
-                goto err_unrx;
-        err = ar9170_register(&aru->common, &aru->udev->dev);
-        ar9170_usb_stop(&aru->common);
-        if (err)
-                goto err_unrx;
-        complete(&aru->firmware_loading_complete);
-        usb_put_dev(aru->udev);
-        return;
- err_unrx:
-        ar9170_usb_cancel_urbs(aru);
- err_freefw:
-        ar9170_usb_firmware_failed(aru);
-}
-static void ar9170_usb_firmware_inits(const struct firmware *fw,
-                                      void *context)
-{
-        struct ar9170_usb *aru = context;
-        int err;
-        if (!fw) {
-                dev_err(&aru->udev->dev, "file with init values not found.\n");
-                ar9170_usb_firmware_failed(aru);
-                return;
-        }
-        aru->init_values = fw;
-        /* ok so we have the init values -- get code for two-stage */
-        err = request_firmware_nowait(THIS_MODULE, 1, "ar9170-2.fw",
-                                      &aru->udev->dev, GFP_KERNEL, aru,
-                                      ar9170_usb_firmware_finish);
-        if (err)
-                ar9170_usb_firmware_failed(aru);
-}
-static void ar9170_usb_firmware_step2(const struct firmware *fw, void *context)
-{
-        struct ar9170_usb *aru = context;
-        int err;
-        if (fw) {
-                ar9170_usb_firmware_finish(fw, context);
-                return;
-        }
-        if (aru->req_one_stage_fw) {
-                dev_err(&aru->udev->dev, "ar9170.fw firmware file "
-                        "not found and is required for this device\n");
-                ar9170_usb_firmware_failed(aru);
-                return;
-        }
-        dev_err(&aru->udev->dev, "ar9170.fw firmware file "
-                "not found, trying old firmware...\n");
-        err = request_firmware_nowait(THIS_MODULE, 1, "ar9170-1.fw",
-                                      &aru->udev->dev, GFP_KERNEL, aru,
-                                      ar9170_usb_firmware_inits);
-        if (err)
-                ar9170_usb_firmware_failed(aru);
-}
-static bool ar9170_requires_one_stage(const struct usb_device_id *id)
-{
-        if (!id->driver_info)
-                return false;
-        if (id->driver_info == AR9170_REQ_FW1_ONLY)
-                return true;
-        return false;
-}
-static int ar9170_usb_probe(struct usb_interface *intf,
-                        const struct usb_device_id *id)
-{
-        struct ar9170_usb *aru;
-        struct ar9170 *ar;
-        struct usb_device *udev;
-        int err;
-        aru = ar9170_alloc(sizeof(*aru));
-        if (IS_ERR(aru)) {
-                err = PTR_ERR(aru);
-                goto out;
-        }
-        udev = interface_to_usbdev(intf);
-        usb_get_dev(udev);
-        aru->udev = udev;
-        aru->intf = intf;
-        ar = &aru->common;
-        aru->req_one_stage_fw = ar9170_requires_one_stage(id);
-        usb_set_intfdata(intf, aru);
-        SET_IEEE80211_DEV(ar->hw, &intf->dev);
-        init_usb_anchor(&aru->rx_submitted);
-        init_usb_anchor(&aru->tx_pending);
-        init_usb_anchor(&aru->tx_submitted);
-        init_completion(&aru->cmd_wait);
-        init_completion(&aru->firmware_loading_complete);
-        spin_lock_init(&aru->tx_urb_lock);
-        aru->tx_pending_urbs = 0;
-        atomic_set(&aru->tx_submitted_urbs, 0);
-        aru->common.stop = ar9170_usb_stop;
-        aru->common.flush = ar9170_usb_flush;
-        aru->common.open = ar9170_usb_open;
-        aru->common.tx = ar9170_usb_tx;
-        aru->common.exec_cmd = ar9170_usb_exec_cmd;
-        aru->common.callback_cmd = ar9170_usb_callback_cmd;
-#ifdef CONFIG_PM
-        udev->reset_resume = 1;
-#endif /* CONFIG_PM */
-        err = ar9170_usb_reset(aru);
-        if (err)
-                goto err_freehw;
-        usb_get_dev(aru->udev);
-        return request_firmware_nowait(THIS_MODULE, 1, "ar9170.fw",
-                                       &aru->udev->dev, GFP_KERNEL, aru,
-                                       ar9170_usb_firmware_step2);
-err_freehw:
-        usb_set_intfdata(intf, NULL);
-        usb_put_dev(udev);
-        ieee80211_free_hw(ar->hw);
-out:
-        return err;
-}
-static void ar9170_usb_disconnect(struct usb_interface *intf)
-{
-        struct ar9170_usb *aru = usb_get_intfdata(intf);
-        if (!aru)
-                return;
-        aru->common.state = AR9170_IDLE;
-        wait_for_completion(&aru->firmware_loading_complete);
-        ar9170_unregister(&aru->common);
-        ar9170_usb_cancel_urbs(aru);
-        usb_put_dev(aru->udev);
-        usb_set_intfdata(intf, NULL);
-        ieee80211_free_hw(aru->common.hw);
-        release_firmware(aru->init_values);
-        release_firmware(aru->firmware);
-}
-#ifdef CONFIG_PM
-static int ar9170_suspend(struct usb_interface *intf,
-                          pm_message_t  message)
-{
-        struct ar9170_usb *aru = usb_get_intfdata(intf);
-        if (!aru)
-                return -ENODEV;
-        aru->common.state = AR9170_IDLE;
-        ar9170_usb_cancel_urbs(aru);
-        return 0;
-}
-static int ar9170_resume(struct usb_interface *intf)
-{
-        struct ar9170_usb *aru = usb_get_intfdata(intf);
-        int err;
-        if (!aru)
-                return -ENODEV;
-        usb_unpoison_anchored_urbs(&aru->rx_submitted);
-        usb_unpoison_anchored_urbs(&aru->tx_submitted);
-        err = ar9170_usb_init_device(aru);
-        if (err)
-                goto err_unrx;
-        err = ar9170_usb_open(&aru->common);
-        if (err)
-                goto err_unrx;
-        return 0;
-err_unrx:
-        aru->common.state = AR9170_IDLE;
-        ar9170_usb_cancel_urbs(aru);
-        return err;
-}
-#endif /* CONFIG_PM */
-static struct usb_driver ar9170_driver = {
-        .name = "ar9170usb",
-        .probe = ar9170_usb_probe,
-        .disconnect = ar9170_usb_disconnect,
-        .id_table = ar9170_usb_ids,
-        .soft_unbind = 1,
-#ifdef CONFIG_PM
-        .suspend = ar9170_suspend,
-        .resume = ar9170_resume,
-        .reset_resume = ar9170_resume,
-#endif /* CONFIG_PM */
-};
-static int __init ar9170_init(void)
-{
-        return usb_register(&ar9170_driver);
-}
-static void __exit ar9170_exit(void)
-{
-        usb_deregister(&ar9170_driver);
-}
-module_init(ar9170_init);
-module_exit(ar9170_exit);
diff --git a/drivers/net/wireless/ath/ar9170/usb.h b/drivers/net/wireless/ath/ar9170/usb.h
deleted file mode 100644
index 919b06046eb3..000000000000
--- a/drivers/net/wireless/ath/ar9170/usb.h
+++ /dev/null
@@ -1,82 +0,0 @@
-/*
- * Atheros AR9170 USB driver
- *
- * Driver specific definitions
- *
- * Copyright 2008, Johannes Berg <johannes@sipsolutions.net>
- * Copyright 2009, Christian Lamparter <chunkeey@web.de>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, see
- * http://www.gnu.org/licenses/.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *    Copyright (c) 2007-2008 Atheros Communications, Inc.
- *
- *    Permission to use, copy, modify, and/or distribute this software for any
- *    purpose with or without fee is hereby granted, provided that the above
- *    copyright notice and this permission notice appear in all copies.
- *
- *    THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- *    WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- *    MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- *    ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- *    WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- *    ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- *    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-#ifndef __USB_H
-#define __USB_H
-#include <linux/usb.h>
-#include <linux/completion.h>
-#include <linux/spinlock.h>
-#include <linux/leds.h>
-#include <net/cfg80211.h>
-#include <net/mac80211.h>
-#include <linux/firmware.h>
-#include "eeprom.h"
-#include "hw.h"
-#include "ar9170.h"
-#define AR9170_NUM_RX_URBS                      16
-#define AR9170_NUM_TX_URBS                      8
-struct firmware;
-struct ar9170_usb {
-        struct ar9170 common;
-        struct usb_device *udev;
-        struct usb_interface *intf;
-        struct usb_anchor rx_submitted;
-        struct usb_anchor tx_pending;
-        struct usb_anchor tx_submitted;
-        bool req_one_stage_fw;
-        spinlock_t tx_urb_lock;
-        atomic_t tx_submitted_urbs;
-        unsigned int tx_pending_urbs;
-        struct completion cmd_wait;
-        struct completion firmware_loading_complete;
-        int readlen;
-        u8 *readbuf;
-        const struct firmware *init_values;
-        const struct firmware *firmware;
-};
-#endif /* __USB_H */
diff --git a/drivers/net/wireless/ath/ath.h b/drivers/net/wireless/ath/ath.h
index a6c6a466000f..7cf4317a2a84 100644
--- a/drivers/net/wireless/ath/ath.h
+++ b/drivers/net/wireless/ath/ath.h
@@ -119,17 +119,11 @@ struct ath_ops {
        void (*write)(void *, u32 val, u32 reg_offset);
        void (*enable_write_buffer)(void *);
        void (*write_flush) (void *);
+        u32 (*rmw)(void *, u32 reg_offset, u32 set, u32 clr);
 };
 struct ath_common;
+struct ath_bus_ops;
-struct ath_bus_ops {
-        enum ath_bus_type ath_bus_type;
-        void (*read_cachesize)(struct ath_common *common, int *csz);
-        bool (*eeprom_read)(struct ath_common *common, u32 off, u16 *data);
-        void (*bt_coex_prep)(struct ath_common *common);
-        void (*extn_synch_en)(struct ath_common *common);
-};
 struct ath_common {
        void *ah;
diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
index 82324e98efef..ea9982781559 100644
--- a/drivers/net/wireless/ath/ath5k/ahb.c
+++ b/drivers/net/wireless/ath/ath5k/ahb.c
@@ -18,6 +18,7 @@
 #include <linux/nl80211.h>
 #include <linux/platform_device.h>
+#include <linux/etherdevice.h>
 #include <ar231x_platform.h>
 #include "ath5k.h"
 #include "debug.h"
@@ -62,10 +63,27 @@ int ath5k_hw_read_srev(struct ath5k_hw *ah)
        return 0;
 }
+static int ath5k_ahb_eeprom_read_mac(struct ath5k_hw *ah, u8 *mac)
+{
+        struct ath5k_softc *sc = ah->ah_sc;
+        struct platform_device *pdev = to_platform_device(sc->dev);
+        struct ar231x_board_config *bcfg = pdev->dev.platform_data;
+        u8 *cfg_mac;
+        if (to_platform_device(sc->dev)->id == 0)
+                cfg_mac = bcfg->config->wlan0_mac;
+        else
+                cfg_mac = bcfg->config->wlan1_mac;
+        memcpy(mac, cfg_mac, ETH_ALEN);
+        return 0;
+}
 static const struct ath_bus_ops ath_ahb_bus_ops = {
        .ath_bus_type = ATH_AHB,
        .read_cachesize = ath5k_ahb_read_cachesize,
        .eeprom_read = ath5k_ahb_eeprom_read,
+        .eeprom_read_mac = ath5k_ahb_eeprom_read_mac,
 };
 /*Initialization*/
@@ -142,6 +160,16 @@ static int ath_ahb_probe(struct platform_device *pdev)
                else
                        reg |= AR5K_AR5312_ENABLE_WLAN1;
                __raw_writel(reg, (void __iomem *) AR5K_AR5312_ENABLE);
+                /*
+                 * On a dual-band AR5312, the multiband radio is only
+                 * used as pass-through. Disable 2 GHz support in the
+                 * driver for it
+                 */
+                if (to_platform_device(sc->dev)->id == 0 &&
+                    (bcfg->config->flags & (BD_WLAN0|BD_WLAN1)) ==
+                     (BD_WLAN1|BD_WLAN0))
+                        __set_bit(ATH_STAT_2G_DISABLED, sc->status);
        }
        ret = ath5k_init_softc(sc, &ath_ahb_bus_ops);
diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k/ath5k.h
index 8a06dbd39629..bb50700436fe 100644
--- a/drivers/net/wireless/ath/ath5k/ath5k.h
+++ b/drivers/net/wireless/ath/ath5k/ath5k.h
@@ -224,8 +224,7 @@
 /* SIFS */
 #define AR5K_INIT_SIFS_TURBO                    6
-/* XXX: 8 from initvals 10 from standard */
+#define AR5K_INIT_SIFS_DEFAULT_BG               10
-#define AR5K_INIT_SIFS_DEFAULT_BG               8
 #define AR5K_INIT_SIFS_DEFAULT_A                16
 #define AR5K_INIT_SIFS_HALF_RATE                32
 #define AR5K_INIT_SIFS_QUARTER_RATE             64
@@ -453,12 +452,10 @@ struct ath5k_tx_status {
        u16     ts_seqnum;
        u16     ts_tstamp;
        u8      ts_status;
-        u8      ts_rate[4];
-        u8      ts_retry[4];
        u8      ts_final_idx;
+        u8      ts_final_retry;
        s8      ts_rssi;
        u8      ts_shortretry;
-        u8      ts_longretry;
        u8      ts_virtcol;
        u8      ts_antenna;
 };
@@ -875,6 +872,19 @@ enum ath5k_int {
        AR5K_INT_QTRIG  =       0x40000000, /* Non common */
        AR5K_INT_GLOBAL =       0x80000000,
+        AR5K_INT_TX_ALL = AR5K_INT_TXOK
+                | AR5K_INT_TXDESC
+                | AR5K_INT_TXERR
+                | AR5K_INT_TXEOL
+                | AR5K_INT_TXURN,
+        AR5K_INT_RX_ALL = AR5K_INT_RXOK
+                | AR5K_INT_RXDESC
+                | AR5K_INT_RXERR
+                | AR5K_INT_RXNOFRM
+                | AR5K_INT_RXEOL
+                | AR5K_INT_RXORN,
        AR5K_INT_COMMON  = AR5K_INT_RXOK
                | AR5K_INT_RXDESC
                | AR5K_INT_RXERR
@@ -1058,6 +1068,7 @@ struct ath5k_hw {
        u8                      ah_coverage_class;
        bool                    ah_ack_bitrate_high;
        u8                      ah_bwmode;
+        bool                    ah_short_slot;
        /* Antenna Control */
        u32                     ah_ant_ctl[AR5K_EEPROM_N_MODES][AR5K_ANT_MAX];
@@ -1144,6 +1155,13 @@ struct ath5k_hw {
                struct ath5k_rx_status *);
 };
+struct ath_bus_ops {
+        enum ath_bus_type ath_bus_type;
+        void (*read_cachesize)(struct ath_common *common, int *csz);
+        bool (*eeprom_read)(struct ath_common *common, u32 off, u16 *data);
+        int (*eeprom_read_mac)(struct ath5k_hw *ah, u8 *mac);
+};
 /*
 * Prototypes
 */
@@ -1227,13 +1245,12 @@ int ath5k_hw_dma_stop(struct ath5k_hw *ah);
 /* EEPROM access functions */
 int ath5k_eeprom_init(struct ath5k_hw *ah);
 void ath5k_eeprom_detach(struct ath5k_hw *ah);
-int ath5k_eeprom_read_mac(struct ath5k_hw *ah, u8 *mac);
 /* Protocol Control Unit Functions */
 /* Helpers */
 int ath5k_hw_get_frame_duration(struct ath5k_hw *ah,
-                int len, struct ieee80211_rate *rate);
+                int len, struct ieee80211_rate *rate, bool shortpre);
 unsigned int ath5k_hw_get_default_slottime(struct ath5k_hw *ah);
 unsigned int ath5k_hw_get_default_sifs(struct ath5k_hw *ah);
 extern int ath5k_hw_set_opmode(struct ath5k_hw *ah, enum nl80211_iftype opmode);
diff --git a/drivers/net/wireless/ath/ath5k/attach.c b/drivers/net/wireless/ath/ath5k/attach.c
index bc8240560488..1588401de3c4 100644
--- a/drivers/net/wireless/ath/ath5k/attach.c
+++ b/drivers/net/wireless/ath/ath5k/attach.c
@@ -313,12 +313,17 @@ int ath5k_hw_init(struct ath5k_softc *sc)
                goto err;
        }
+        if (test_bit(ATH_STAT_2G_DISABLED, sc->status)) {
+                __clear_bit(AR5K_MODE_11B, ah->ah_capabilities.cap_mode);
+                __clear_bit(AR5K_MODE_11G, ah->ah_capabilities.cap_mode);
+        }
        /* Crypto settings */
        common->keymax = (sc->ah->ah_version == AR5K_AR5210 ?
                          AR5K_KEYTABLE_SIZE_5210 : AR5K_KEYTABLE_SIZE_5211);
        if (srev >= AR5K_SREV_AR5212_V4 &&
-            (ee->ee_version >= AR5K_EEPROM_VERSION_5_0 &&
+            (ee->ee_version < AR5K_EEPROM_VERSION_5_0 ||
            !AR5K_EEPROM_AES_DIS(ee->ee_misc5)))
                common->crypt_caps |= ATH_CRYPT_CAP_CIPHER_AESCCM;
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 349a5963931b..22047628ccfa 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -1444,6 +1444,21 @@ ath5k_receive_frame_ok(struct ath5k_softc *sc, struct ath5k_rx_status *rs)
 }
 static void
+ath5k_set_current_imask(struct ath5k_softc *sc)
+{
+        enum ath5k_int imask = sc->imask;
+        unsigned long flags;
+        spin_lock_irqsave(&sc->irqlock, flags);
+        if (sc->rx_pending)
+                imask &= ~AR5K_INT_RX_ALL;
+        if (sc->tx_pending)
+                imask &= ~AR5K_INT_TX_ALL;
+        ath5k_hw_set_imr(sc->ah, imask);
+        spin_unlock_irqrestore(&sc->irqlock, flags);
+}
+static void
 ath5k_tasklet_rx(unsigned long data)
 {
        struct ath5k_rx_status rs = {};
@@ -1506,6 +1521,8 @@ next:
        } while (ath5k_rxbuf_setup(sc, bf) == 0);
 unlock:
        spin_unlock(&sc->rxbuflock);
+        sc->rx_pending = false;
+        ath5k_set_current_imask(sc);
 }
@@ -1573,28 +1590,28 @@ ath5k_tx_frame_completed(struct ath5k_softc *sc, struct sk_buff *skb,
                         struct ath5k_txq *txq, struct ath5k_tx_status *ts)
 {
        struct ieee80211_tx_info *info;
+        u8 tries[3];
        int i;
        sc->stats.tx_all_count++;
        sc->stats.tx_bytes_count += skb->len;
        info = IEEE80211_SKB_CB(skb);
+        tries[0] = info->status.rates[0].count;
+        tries[1] = info->status.rates[1].count;
+        tries[2] = info->status.rates[2].count;
        ieee80211_tx_info_clear_status(info);
-        for (i = 0; i < 4; i++) {
+        for (i = 0; i < ts->ts_final_idx; i++) {
                struct ieee80211_tx_rate *r =
                        &info->status.rates[i];
-                if (ts->ts_rate[i]) {
+                r->count = tries[i];
-                        r->idx = ath5k_hw_to_driver_rix(sc, ts->ts_rate[i]);
-                        r->count = ts->ts_retry[i];
-                } else {
-                        r->idx = -1;
-                        r->count = 0;
-                }
        }
-        /* count the successful attempt as well */
+        info->status.rates[ts->ts_final_idx].count = ts->ts_final_retry;
-        info->status.rates[ts->ts_final_idx].count++;
+        info->status.rates[ts->ts_final_idx + 1].idx = -1;
        if (unlikely(ts->ts_status)) {
                sc->stats.ack_fail++;
@@ -1609,6 +1626,9 @@ ath5k_tx_frame_completed(struct ath5k_softc *sc, struct sk_buff *skb,
        } else {
                info->flags |= IEEE80211_TX_STAT_ACK;
                info->status.ack_signal = ts->ts_rssi;
+                /* count the successful attempt as well */
+                info->status.rates[ts->ts_final_idx].count++;
        }
        /*
@@ -1690,6 +1710,9 @@ ath5k_tasklet_tx(unsigned long data)
        for (i=0; i < AR5K_NUM_TX_QUEUES; i++)
                if (sc->txqs[i].setup && (sc->ah->ah_txq_isr & BIT(i)))
                        ath5k_tx_processq(sc, &sc->txqs[i]);
+        sc->tx_pending = false;
+        ath5k_set_current_imask(sc);
 }
@@ -2119,6 +2142,20 @@ ath5k_intr_calibration_poll(struct ath5k_hw *ah)
         * AR5K_REG_ENABLE_BITS(ah, AR5K_CR, AR5K_CR_SWI); */
 }
+static void
+ath5k_schedule_rx(struct ath5k_softc *sc)
+{
+        sc->rx_pending = true;
+        tasklet_schedule(&sc->rxtq);
+}
+static void
+ath5k_schedule_tx(struct ath5k_softc *sc)
+{
+        sc->tx_pending = true;
+        tasklet_schedule(&sc->txtq);
+}
 irqreturn_t
 ath5k_intr(int irq, void *dev_id)
 {
@@ -2161,7 +2198,7 @@ ath5k_intr(int irq, void *dev_id)
                                ieee80211_queue_work(sc->hw, &sc->reset_work);
                        }
                        else
-                                tasklet_schedule(&sc->rxtq);
+                                ath5k_schedule_rx(sc);
                } else {
                        if (status & AR5K_INT_SWBA) {
                                tasklet_hi_schedule(&sc->beacontq);
@@ -2179,10 +2216,10 @@ ath5k_intr(int irq, void *dev_id)
                                ath5k_hw_update_tx_triglevel(ah, true);
                        }
                        if (status & (AR5K_INT_RXOK | AR5K_INT_RXERR))
-                                tasklet_schedule(&sc->rxtq);
+                                ath5k_schedule_rx(sc);
                        if (status & (AR5K_INT_TXOK | AR5K_INT_TXDESC
                                        | AR5K_INT_TXERR | AR5K_INT_TXEOL))
-                                tasklet_schedule(&sc->txtq);
+                                ath5k_schedule_tx(sc);
                        if (status & AR5K_INT_BMISS) {
                                /* TODO */
                        }
@@ -2201,6 +2238,9 @@ ath5k_intr(int irq, void *dev_id)
        } while (ath5k_hw_is_intr_pending(ah) && --counter > 0);
+        if (sc->rx_pending || sc->tx_pending)
+                ath5k_set_current_imask(sc);
        if (unlikely(!counter))
                ATH5K_WARN(sc, "too many interrupts, giving up for now\n");
@@ -2354,7 +2394,7 @@ ath5k_init_softc(struct ath5k_softc *sc, const struct ath_bus_ops *bus_ops)
        spin_lock_init(&sc->rxbuflock);
        spin_lock_init(&sc->txbuflock);
        spin_lock_init(&sc->block);
+        spin_lock_init(&sc->irqlock);
        /* Setup interrupt handler */
        ret = request_irq(sc->irq, ath5k_intr, IRQF_SHARED, "ath", sc);
@@ -2572,6 +2612,8 @@ done:
 static void stop_tasklets(struct ath5k_softc *sc)
 {
+        sc->rx_pending = false;
+        sc->tx_pending = false;
        tasklet_kill(&sc->rxtq);
        tasklet_kill(&sc->txtq);
        tasklet_kill(&sc->calib);
@@ -2838,7 +2880,7 @@ ath5k_init(struct ieee80211_hw *hw)
        INIT_WORK(&sc->reset_work, ath5k_reset_work);
        INIT_DELAYED_WORK(&sc->tx_complete_work, ath5k_tx_complete_poll_work);
-        ret = ath5k_eeprom_read_mac(ah, mac);
+        ret = ath5k_hw_common(ah)->bus_ops->eeprom_read_mac(ah, mac);
        if (ret) {
                ATH5K_ERR(sc, "unable to read address from EEPROM\n");
                goto err_queues;
@@ -2898,7 +2940,6 @@ ath5k_deinit_softc(struct ath5k_softc *sc)
         * XXX: ??? detach ath5k_hw ???
         * Other than that, it's straightforward...
         */
-        ath5k_debug_finish_device(sc);
        ieee80211_unregister_hw(hw);
        ath5k_desc_free(sc);
        ath5k_txq_release(sc);
diff --git a/drivers/net/wireless/ath/ath5k/base.h b/drivers/net/wireless/ath/ath5k/base.h
index 978f1f4ac2f3..b294f3305011 100644
--- a/drivers/net/wireless/ath/ath5k/base.h
+++ b/drivers/net/wireless/ath/ath5k/base.h
@@ -193,12 +193,13 @@ struct ath5k_softc {
        dma_addr_t              desc_daddr;     /* DMA (physical) address */
        size_t                  desc_len;       /* size of TX/RX descriptors */
-        DECLARE_BITMAP(status, 5);
+        DECLARE_BITMAP(status, 6);
 #define ATH_STAT_INVALID        0               /* disable hardware accesses */
 #define ATH_STAT_MRRETRY        1               /* multi-rate retry support */
 #define ATH_STAT_PROMISC        2
 #define ATH_STAT_LEDSOFT        3               /* enable LED gpio status */
 #define ATH_STAT_STARTED        4               /* opened & irqs enabled */
+#define ATH_STAT_2G_DISABLED    5               /* multiband radio without 2G */
        unsigned int            filter_flags;   /* HW flags, AR5K_RX_FILTER_* */
        struct ieee80211_channel *curchan;      /* current h/w channel */
@@ -207,6 +208,10 @@ struct ath5k_softc {
        enum ath5k_int          imask;          /* interrupt mask copy */
+        spinlock_t              irqlock;
+        bool                    rx_pending;     /* rx tasklet pending */
+        bool                    tx_pending;     /* tx tasklet pending */
        u8                      lladdr[ETH_ALEN];
        u8                      bssidmask[ETH_ALEN];
diff --git a/drivers/net/wireless/ath/ath5k/caps.c b/drivers/net/wireless/ath/ath5k/caps.c
index f77e8a703c5c..7dd88e1c3ff8 100644
--- a/drivers/net/wireless/ath/ath5k/caps.c
+++ b/drivers/net/wireless/ath/ath5k/caps.c
@@ -94,6 +94,9 @@ int ath5k_hw_set_capabilities(struct ath5k_hw *ah)
                }
        }
+        if ((ah->ah_radio_5ghz_revision & 0xf0) == AR5K_SREV_RAD_2112)
+                __clear_bit(AR5K_MODE_11A, caps->cap_mode);
        /* Set number of supported TX queues */
        if (ah->ah_version == AR5K_AR5210)
                caps->cap_queues.q_tx_num = AR5K_NUM_TX_QUEUES_NOQCU;
diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
index 0230f30e9e9a..0bf7313b8a17 100644
--- a/drivers/net/wireless/ath/ath5k/debug.c
+++ b/drivers/net/wireless/ath/ath5k/debug.c
@@ -888,65 +888,38 @@ static const struct file_operations fops_queue = {
 void
 ath5k_debug_init_device(struct ath5k_softc *sc)
 {
-        sc->debug.level = ath5k_debug;
+        struct dentry *phydir;
-        sc->debug.debugfs_phydir = debugfs_create_dir("ath5k",
+        sc->debug.level = ath5k_debug;
-                                sc->hw->wiphy->debugfsdir);
-        sc->debug.debugfs_debug = debugfs_create_file("debug",
+        phydir = debugfs_create_dir("ath5k", sc->hw->wiphy->debugfsdir);
-                                S_IWUSR | S_IRUSR,
+        if (!phydir)
-                                sc->debug.debugfs_phydir, sc, &fops_debug);
+            return;
-        sc->debug.debugfs_registers = debugfs_create_file("registers", S_IRUSR,
+        debugfs_create_file("debug", S_IWUSR | S_IRUSR, phydir, sc,
-                                sc->debug.debugfs_phydir, sc, &fops_registers);
+                            &fops_debug);
-        sc->debug.debugfs_beacon = debugfs_create_file("beacon",
+        debugfs_create_file("registers", S_IRUSR, phydir, sc, &fops_registers);
-                                S_IWUSR | S_IRUSR,
-                                sc->debug.debugfs_phydir, sc, &fops_beacon);
-        sc->debug.debugfs_reset = debugfs_create_file("reset", S_IWUSR,
+        debugfs_create_file("beacon", S_IWUSR | S_IRUSR, phydir, sc,
-                                sc->debug.debugfs_phydir, sc, &fops_reset);
+                            &fops_beacon);
-        sc->debug.debugfs_antenna = debugfs_create_file("antenna",
+        debugfs_create_file("reset", S_IWUSR, phydir, sc, &fops_reset);
-                                S_IWUSR | S_IRUSR,
-                                sc->debug.debugfs_phydir, sc, &fops_antenna);
-        sc->debug.debugfs_misc = debugfs_create_file("misc",
+        debugfs_create_file("antenna", S_IWUSR | S_IRUSR, phydir, sc,
-                                S_IRUSR,
+                            &fops_antenna);
-                                sc->debug.debugfs_phydir, sc, &fops_misc);
-        sc->debug.debugfs_frameerrors = debugfs_create_file("frameerrors",
+        debugfs_create_file("misc", S_IRUSR, phydir, sc, &fops_misc);
-                                S_IWUSR | S_IRUSR,
-                                sc->debug.debugfs_phydir, sc,
-                                &fops_frameerrors);
-        sc->debug.debugfs_ani = debugfs_create_file("ani",
+        debugfs_create_file("frameerrors", S_IWUSR | S_IRUSR, phydir, sc,
-                                S_IWUSR | S_IRUSR,
+                            &fops_frameerrors);
-                                sc->debug.debugfs_phydir, sc,
-                                &fops_ani);
-        sc->debug.debugfs_queue = debugfs_create_file("queue",
+        debugfs_create_file("ani", S_IWUSR | S_IRUSR, phydir, sc, &fops_ani);
-                                S_IWUSR | S_IRUSR,
-                                sc->debug.debugfs_phydir, sc,
-                                &fops_queue);
-}
-void
+        debugfs_create_file("queue", S_IWUSR | S_IRUSR, phydir, sc,
-ath5k_debug_finish_device(struct ath5k_softc *sc)
+                            &fops_queue);
-{
-        debugfs_remove(sc->debug.debugfs_debug);
-        debugfs_remove(sc->debug.debugfs_registers);
-        debugfs_remove(sc->debug.debugfs_beacon);
-        debugfs_remove(sc->debug.debugfs_reset);
-        debugfs_remove(sc->debug.debugfs_antenna);
-        debugfs_remove(sc->debug.debugfs_misc);
-        debugfs_remove(sc->debug.debugfs_frameerrors);
-        debugfs_remove(sc->debug.debugfs_ani);
-        debugfs_remove(sc->debug.debugfs_queue);
-        debugfs_remove(sc->debug.debugfs_phydir);
 }
 /* functions used in other places */
 void
diff --git a/drivers/net/wireless/ath/ath5k/debug.h b/drivers/net/wireless/ath/ath5k/debug.h
index b0355aef68d3..193dd2d4ea3c 100644
--- a/drivers/net/wireless/ath/ath5k/debug.h
+++ b/drivers/net/wireless/ath/ath5k/debug.h
@@ -68,17 +68,6 @@ struct ath5k_buf;
 struct ath5k_dbg_info {
        unsigned int            level;          /* debug level */
-        /* debugfs entries */
-        struct dentry           *debugfs_phydir;
-        struct dentry           *debugfs_debug;
-        struct dentry           *debugfs_registers;
-        struct dentry           *debugfs_beacon;
-        struct dentry           *debugfs_reset;
-        struct dentry           *debugfs_antenna;
-        struct dentry           *debugfs_misc;
-        struct dentry           *debugfs_frameerrors;
-        struct dentry           *debugfs_ani;
-        struct dentry           *debugfs_queue;
 };
 /**
@@ -141,9 +130,6 @@ void
 ath5k_debug_init_device(struct ath5k_softc *sc);
 void
-ath5k_debug_finish_device(struct ath5k_softc *sc);
-void
 ath5k_debug_printrxbuffs(struct ath5k_softc *sc, struct ath5k_hw *ah);
 void
@@ -167,9 +153,6 @@ static inline void
 ath5k_debug_init_device(struct ath5k_softc *sc) {}
 static inline void
-ath5k_debug_finish_device(struct ath5k_softc *sc) {}
-static inline void
 ath5k_debug_printrxbuffs(struct ath5k_softc *sc, struct ath5k_hw *ah) {}
 static inline void
diff --git a/drivers/net/wireless/ath/ath5k/desc.c b/drivers/net/wireless/ath/ath5k/desc.c
index a8fcc94269f7..62172d585723 100644
--- a/drivers/net/wireless/ath/ath5k/desc.c
+++ b/drivers/net/wireless/ath/ath5k/desc.c
@@ -185,6 +185,12 @@ static int ath5k_hw_setup_4word_tx_desc(struct ath5k_hw *ah,
        struct ath5k_hw_4w_tx_ctl *tx_ctl;
        unsigned int frame_len;
+        /*
+         * Use local variables for these to reduce load/store access on
+         * uncached memory
+         */
+        u32 txctl0 = 0, txctl1 = 0, txctl2 = 0, txctl3 = 0;
        tx_ctl = &desc->ud.ds_tx5212.tx_ctl;
        /*
@@ -208,8 +214,9 @@ static int ath5k_hw_setup_4word_tx_desc(struct ath5k_hw *ah,
        if (tx_power > AR5K_TUNE_MAX_TXPOWER)
                tx_power = AR5K_TUNE_MAX_TXPOWER;
-        /* Clear descriptor */
+        /* Clear descriptor status area */
-        memset(&desc->ud.ds_tx5212, 0, sizeof(struct ath5k_hw_5212_tx_desc));
+        memset(&desc->ud.ds_tx5212.tx_stat, 0,
+               sizeof(desc->ud.ds_tx5212.tx_stat));
        /* Setup control descriptor */
@@ -221,7 +228,7 @@ static int ath5k_hw_setup_4word_tx_desc(struct ath5k_hw *ah,
        if (frame_len & ~AR5K_4W_TX_DESC_CTL0_FRAME_LEN)
                return -EINVAL;
-        tx_ctl->tx_control_0 = frame_len & AR5K_4W_TX_DESC_CTL0_FRAME_LEN;
+        txctl0 = frame_len & AR5K_4W_TX_DESC_CTL0_FRAME_LEN;
        /* Verify and set buffer length */
@@ -232,21 +239,17 @@ static int ath5k_hw_setup_4word_tx_desc(struct ath5k_hw *ah,
        if (pkt_len & ~AR5K_4W_TX_DESC_CTL1_BUF_LEN)
                return -EINVAL;
-        tx_ctl->tx_control_1 = pkt_len & AR5K_4W_TX_DESC_CTL1_BUF_LEN;
+        txctl1 = pkt_len & AR5K_4W_TX_DESC_CTL1_BUF_LEN;
-        tx_ctl->tx_control_0 |=
+        txctl0 |= AR5K_REG_SM(tx_power, AR5K_4W_TX_DESC_CTL0_XMIT_POWER) |
-                AR5K_REG_SM(tx_power, AR5K_4W_TX_DESC_CTL0_XMIT_POWER) |
+                  AR5K_REG_SM(antenna_mode, AR5K_4W_TX_DESC_CTL0_ANT_MODE_XMIT);
-                AR5K_REG_SM(antenna_mode, AR5K_4W_TX_DESC_CTL0_ANT_MODE_XMIT);
+        txctl1 |= AR5K_REG_SM(type, AR5K_4W_TX_DESC_CTL1_FRAME_TYPE);
-        tx_ctl->tx_control_1 |= AR5K_REG_SM(type,
+        txctl2 = AR5K_REG_SM(tx_tries0, AR5K_4W_TX_DESC_CTL2_XMIT_TRIES0);
-                                        AR5K_4W_TX_DESC_CTL1_FRAME_TYPE);
+        txctl3 = tx_rate0 & AR5K_4W_TX_DESC_CTL3_XMIT_RATE0;
-        tx_ctl->tx_control_2 = AR5K_REG_SM(tx_tries0,
-                                        AR5K_4W_TX_DESC_CTL2_XMIT_TRIES0);
-        tx_ctl->tx_control_3 = tx_rate0 & AR5K_4W_TX_DESC_CTL3_XMIT_RATE0;
 #define _TX_FLAGS(_c, _flag)                                    \
        if (flags & AR5K_TXDESC_##_flag) {                      \
-                tx_ctl->tx_control_##_c |=                      \
+                txctl##_c |= AR5K_4W_TX_DESC_CTL##_c##_##_flag; \
-                        AR5K_4W_TX_DESC_CTL##_c##_##_flag;      \
        }
        _TX_FLAGS(0, CLRDMASK);
@@ -262,8 +265,8 @@ static int ath5k_hw_setup_4word_tx_desc(struct ath5k_hw *ah,
         * WEP crap
         */
        if (key_index != AR5K_TXKEYIX_INVALID) {
-                tx_ctl->tx_control_0 |= AR5K_4W_TX_DESC_CTL0_ENCRYPT_KEY_VALID;
+                txctl0 |= AR5K_4W_TX_DESC_CTL0_ENCRYPT_KEY_VALID;
-                tx_ctl->tx_control_1 |= AR5K_REG_SM(key_index,
+                txctl1 |= AR5K_REG_SM(key_index,
                                AR5K_4W_TX_DESC_CTL1_ENCRYPT_KEY_IDX);
        }
@@ -274,12 +277,16 @@ static int ath5k_hw_setup_4word_tx_desc(struct ath5k_hw *ah,
                if ((flags & AR5K_TXDESC_RTSENA) &&
                                (flags & AR5K_TXDESC_CTSENA))
                        return -EINVAL;
-                tx_ctl->tx_control_2 |= rtscts_duration &
+                txctl2 |= rtscts_duration & AR5K_4W_TX_DESC_CTL2_RTS_DURATION;
-                                AR5K_4W_TX_DESC_CTL2_RTS_DURATION;
+                txctl3 |= AR5K_REG_SM(rtscts_rate,
-                tx_ctl->tx_control_3 |= AR5K_REG_SM(rtscts_rate,
                                AR5K_4W_TX_DESC_CTL3_RTS_CTS_RATE);
        }
+        tx_ctl->tx_control_0 = txctl0;
+        tx_ctl->tx_control_1 = txctl1;
+        tx_ctl->tx_control_2 = txctl2;
+        tx_ctl->tx_control_3 = txctl3;
        return 0;
 }
@@ -364,7 +371,7 @@ static int ath5k_hw_proc_2word_tx_status(struct ath5k_hw *ah,
                AR5K_DESC_TX_STATUS0_SEND_TIMESTAMP);
        ts->ts_shortretry = AR5K_REG_MS(tx_status->tx_status_0,
                AR5K_DESC_TX_STATUS0_SHORT_RETRY_COUNT);
-        ts->ts_longretry = AR5K_REG_MS(tx_status->tx_status_0,
+        ts->ts_final_retry = AR5K_REG_MS(tx_status->tx_status_0,
                AR5K_DESC_TX_STATUS0_LONG_RETRY_COUNT);
        /*TODO: ts->ts_virtcol + test*/
        ts->ts_seqnum = AR5K_REG_MS(tx_status->tx_status_1,
@@ -373,9 +380,6 @@ static int ath5k_hw_proc_2word_tx_status(struct ath5k_hw *ah,
                AR5K_DESC_TX_STATUS1_ACK_SIG_STRENGTH);
        ts->ts_antenna = 1;
        ts->ts_status = 0;
-        ts->ts_rate[0] = AR5K_REG_MS(tx_ctl->tx_control_0,
-                AR5K_2W_TX_DESC_CTL0_XMIT_RATE);
-        ts->ts_retry[0] = ts->ts_longretry;
        ts->ts_final_idx = 0;
        if (!(tx_status->tx_status_0 & AR5K_DESC_TX_STATUS0_FRAME_XMIT_OK)) {
@@ -401,81 +405,48 @@ static int ath5k_hw_proc_4word_tx_status(struct ath5k_hw *ah,
 {
        struct ath5k_hw_4w_tx_ctl *tx_ctl;
        struct ath5k_hw_tx_status *tx_status;
+        u32 txstat0, txstat1;
        tx_ctl = &desc->ud.ds_tx5212.tx_ctl;
        tx_status = &desc->ud.ds_tx5212.tx_stat;
+        txstat1 = ACCESS_ONCE(tx_status->tx_status_1);
        /* No frame has been send or error */
-        if (unlikely(!(tx_status->tx_status_1 & AR5K_DESC_TX_STATUS1_DONE)))
+        if (unlikely(!(txstat1 & AR5K_DESC_TX_STATUS1_DONE)))
                return -EINPROGRESS;
+        txstat0 = ACCESS_ONCE(tx_status->tx_status_0);
        /*
         * Get descriptor status
         */
-        ts->ts_tstamp = AR5K_REG_MS(tx_status->tx_status_0,
+        ts->ts_tstamp = AR5K_REG_MS(txstat0,
                AR5K_DESC_TX_STATUS0_SEND_TIMESTAMP);
-        ts->ts_shortretry = AR5K_REG_MS(tx_status->tx_status_0,
+        ts->ts_shortretry = AR5K_REG_MS(txstat0,
                AR5K_DESC_TX_STATUS0_SHORT_RETRY_COUNT);
-        ts->ts_longretry = AR5K_REG_MS(tx_status->tx_status_0,
+        ts->ts_final_retry = AR5K_REG_MS(txstat0,
                AR5K_DESC_TX_STATUS0_LONG_RETRY_COUNT);
-        ts->ts_seqnum = AR5K_REG_MS(tx_status->tx_status_1,
+        ts->ts_seqnum = AR5K_REG_MS(txstat1,
                AR5K_DESC_TX_STATUS1_SEQ_NUM);
-        ts->ts_rssi = AR5K_REG_MS(tx_status->tx_status_1,
+        ts->ts_rssi = AR5K_REG_MS(txstat1,
                AR5K_DESC_TX_STATUS1_ACK_SIG_STRENGTH);
-        ts->ts_antenna = (tx_status->tx_status_1 &
+        ts->ts_antenna = (txstat1 &
                AR5K_DESC_TX_STATUS1_XMIT_ANTENNA_5212) ? 2 : 1;
        ts->ts_status = 0;
-        ts->ts_final_idx = AR5K_REG_MS(tx_status->tx_status_1,
+        ts->ts_final_idx = AR5K_REG_MS(txstat1,
                        AR5K_DESC_TX_STATUS1_FINAL_TS_IX_5212);
-        /* The longretry counter has the number of un-acked retries
-         * for the final rate. To get the total number of retries
-         * we have to add the retry counters for the other rates
-         * as well
-         */
-        ts->ts_retry[ts->ts_final_idx] = ts->ts_longretry;
-        switch (ts->ts_final_idx) {
-        case 3:
-                ts->ts_rate[3] = AR5K_REG_MS(tx_ctl->tx_control_3,
-                        AR5K_4W_TX_DESC_CTL3_XMIT_RATE3);
-                ts->ts_retry[2] = AR5K_REG_MS(tx_ctl->tx_control_2,
-                        AR5K_4W_TX_DESC_CTL2_XMIT_TRIES2);
-                ts->ts_longretry += ts->ts_retry[2];
-                /* fall through */
-        case 2:
-                ts->ts_rate[2] = AR5K_REG_MS(tx_ctl->tx_control_3,
-                        AR5K_4W_TX_DESC_CTL3_XMIT_RATE2);
-                ts->ts_retry[1] = AR5K_REG_MS(tx_ctl->tx_control_2,
-                        AR5K_4W_TX_DESC_CTL2_XMIT_TRIES1);
-                ts->ts_longretry += ts->ts_retry[1];
-                /* fall through */
-        case 1:
-                ts->ts_rate[1] = AR5K_REG_MS(tx_ctl->tx_control_3,
-                        AR5K_4W_TX_DESC_CTL3_XMIT_RATE1);
-                ts->ts_retry[0] = AR5K_REG_MS(tx_ctl->tx_control_2,
-                        AR5K_4W_TX_DESC_CTL2_XMIT_TRIES1);
-                ts->ts_longretry += ts->ts_retry[0];
-                /* fall through */
-        case 0:
-                ts->ts_rate[0] = tx_ctl->tx_control_3 &
-                        AR5K_4W_TX_DESC_CTL3_XMIT_RATE0;
-                break;
-        }
        /* TX error */
-        if (!(tx_status->tx_status_0 & AR5K_DESC_TX_STATUS0_FRAME_XMIT_OK)) {
+        if (!(txstat0 & AR5K_DESC_TX_STATUS0_FRAME_XMIT_OK)) {
-                if (tx_status->tx_status_0 &
+                if (txstat0 & AR5K_DESC_TX_STATUS0_EXCESSIVE_RETRIES)
-                                AR5K_DESC_TX_STATUS0_EXCESSIVE_RETRIES)
                        ts->ts_status |= AR5K_TXERR_XRETRY;
-                if (tx_status->tx_status_0 & AR5K_DESC_TX_STATUS0_FIFO_UNDERRUN)
+                if (txstat0 & AR5K_DESC_TX_STATUS0_FIFO_UNDERRUN)
                        ts->ts_status |= AR5K_TXERR_FIFO;
-                if (tx_status->tx_status_0 & AR5K_DESC_TX_STATUS0_FILTERED)
+                if (txstat0 & AR5K_DESC_TX_STATUS0_FILTERED)
                        ts->ts_status |= AR5K_TXERR_FILT;
        }
@@ -609,37 +580,37 @@ static int ath5k_hw_proc_5212_rx_status(struct ath5k_hw *ah,
                                        struct ath5k_rx_status *rs)
 {
        struct ath5k_hw_rx_status *rx_status;
+        u32 rxstat0, rxstat1;
        rx_status = &desc->ud.ds_rx.rx_stat;
+        rxstat1 = ACCESS_ONCE(rx_status->rx_status_1);
        /* No frame received / not ready */
-        if (unlikely(!(rx_status->rx_status_1 &
+        if (unlikely(!(rxstat1 & AR5K_5212_RX_DESC_STATUS1_DONE)))
-                                AR5K_5212_RX_DESC_STATUS1_DONE)))
                return -EINPROGRESS;
        memset(rs, 0, sizeof(struct ath5k_rx_status));
+        rxstat0 = ACCESS_ONCE(rx_status->rx_status_0);
        /*
         * Frame receive status
         */
-        rs->rs_datalen = rx_status->rx_status_0 &
+        rs->rs_datalen = rxstat0 & AR5K_5212_RX_DESC_STATUS0_DATA_LEN;
-                AR5K_5212_RX_DESC_STATUS0_DATA_LEN;
+        rs->rs_rssi = AR5K_REG_MS(rxstat0,
-        rs->rs_rssi = AR5K_REG_MS(rx_status->rx_status_0,
                AR5K_5212_RX_DESC_STATUS0_RECEIVE_SIGNAL);
-        rs->rs_rate = AR5K_REG_MS(rx_status->rx_status_0,
+        rs->rs_rate = AR5K_REG_MS(rxstat0,
                AR5K_5212_RX_DESC_STATUS0_RECEIVE_RATE);
-        rs->rs_antenna = AR5K_REG_MS(rx_status->rx_status_0,
+        rs->rs_antenna = AR5K_REG_MS(rxstat0,
                AR5K_5212_RX_DESC_STATUS0_RECEIVE_ANTENNA);
-        rs->rs_more = !!(rx_status->rx_status_0 &
+        rs->rs_more = !!(rxstat0 & AR5K_5212_RX_DESC_STATUS0_MORE);
-                AR5K_5212_RX_DESC_STATUS0_MORE);
+        rs->rs_tstamp = AR5K_REG_MS(rxstat1,
-        rs->rs_tstamp = AR5K_REG_MS(rx_status->rx_status_1,
                AR5K_5212_RX_DESC_STATUS1_RECEIVE_TIMESTAMP);
        /*
         * Key table status
         */
-        if (rx_status->rx_status_1 & AR5K_5212_RX_DESC_STATUS1_KEY_INDEX_VALID)
+        if (rxstat1 & AR5K_5212_RX_DESC_STATUS1_KEY_INDEX_VALID)
-                rs->rs_keyix = AR5K_REG_MS(rx_status->rx_status_1,
+                rs->rs_keyix = AR5K_REG_MS(rxstat1,
                                           AR5K_5212_RX_DESC_STATUS1_KEY_INDEX);
        else
                rs->rs_keyix = AR5K_RXKEYIX_INVALID;
@@ -647,27 +618,22 @@ static int ath5k_hw_proc_5212_rx_status(struct ath5k_hw *ah,
        /*
         * Receive/descriptor errors
         */
-        if (!(rx_status->rx_status_1 &
+        if (!(rxstat1 & AR5K_5212_RX_DESC_STATUS1_FRAME_RECEIVE_OK)) {
-            AR5K_5212_RX_DESC_STATUS1_FRAME_RECEIVE_OK)) {
+                if (rxstat1 & AR5K_5212_RX_DESC_STATUS1_CRC_ERROR)
-                if (rx_status->rx_status_1 &
-                                AR5K_5212_RX_DESC_STATUS1_CRC_ERROR)
                        rs->rs_status |= AR5K_RXERR_CRC;
-                if (rx_status->rx_status_1 &
+                if (rxstat1 & AR5K_5212_RX_DESC_STATUS1_PHY_ERROR) {
-                                AR5K_5212_RX_DESC_STATUS1_PHY_ERROR) {
                        rs->rs_status |= AR5K_RXERR_PHY;
-                        rs->rs_phyerr = AR5K_REG_MS(rx_status->rx_status_1,
+                        rs->rs_phyerr = AR5K_REG_MS(rxstat1,
                                AR5K_5212_RX_DESC_STATUS1_PHY_ERROR_CODE);
                        if (!ah->ah_capabilities.cap_has_phyerr_counters)
                                ath5k_ani_phy_error_report(ah, rs->rs_phyerr);
                }
-                if (rx_status->rx_status_1 &
+                if (rxstat1 & AR5K_5212_RX_DESC_STATUS1_DECRYPT_CRC_ERROR)
-                                AR5K_5212_RX_DESC_STATUS1_DECRYPT_CRC_ERROR)
                        rs->rs_status |= AR5K_RXERR_DECRYPT;
-                if (rx_status->rx_status_1 &
+                if (rxstat1 & AR5K_5212_RX_DESC_STATUS1_MIC_ERROR)
-                                AR5K_5212_RX_DESC_STATUS1_MIC_ERROR)
                        rs->rs_status |= AR5K_RXERR_MIC;
        }
        return 0;
diff --git a/drivers/net/wireless/ath/ath5k/eeprom.c b/drivers/net/wireless/ath/ath5k/eeprom.c
index efb672cb31e4..1fef84f87c78 100644
--- a/drivers/net/wireless/ath/ath5k/eeprom.c
+++ b/drivers/net/wireless/ath/ath5k/eeprom.c
@@ -660,6 +660,53 @@ ath5k_get_pcdac_intercepts(struct ath5k_hw *ah, u8 min, u8 max, u8 *vp)
                vp[i] = (ip[i] * max + (100 - ip[i]) * min) / 100;
 }
+static int
+ath5k_eeprom_free_pcal_info(struct ath5k_hw *ah, int mode)
+{
+        struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
+        struct ath5k_chan_pcal_info *chinfo;
+        u8 pier, pdg;
+        switch (mode) {
+        case AR5K_EEPROM_MODE_11A:
+                if (!AR5K_EEPROM_HDR_11A(ee->ee_header))
+                        return 0;
+                chinfo = ee->ee_pwr_cal_a;
+                break;
+        case AR5K_EEPROM_MODE_11B:
+                if (!AR5K_EEPROM_HDR_11B(ee->ee_header))
+                        return 0;
+                chinfo = ee->ee_pwr_cal_b;
+                break;
+        case AR5K_EEPROM_MODE_11G:
+                if (!AR5K_EEPROM_HDR_11G(ee->ee_header))
+                        return 0;
+                chinfo = ee->ee_pwr_cal_g;
+                break;
+        default:
+                return -EINVAL;
+        }
+        for (pier = 0; pier < ee->ee_n_piers[mode]; pier++) {
+                if (!chinfo[pier].pd_curves)
+                        continue;
+                for (pdg = 0; pdg < ee->ee_pd_gains[mode]; pdg++) {
+                        struct ath5k_pdgain_info *pd =
+                                        &chinfo[pier].pd_curves[pdg];
+                        if (pd != NULL) {
+                                kfree(pd->pd_step);
+                                kfree(pd->pd_pwr);
+                        }
+                }
+                kfree(chinfo[pier].pd_curves);
+        }
+        return 0;
+}
 /* Convert RF5111 specific data to generic raw data
 * used by interpolation code */
 static int
@@ -684,7 +731,7 @@ ath5k_eeprom_convert_pcal_info_5111(struct ath5k_hw *ah, int mode,
                                GFP_KERNEL);
                if (!chinfo[pier].pd_curves)
-                        return -ENOMEM;
+                        goto err_out;
                /* Only one curve for RF5111
                 * find out which one and place
@@ -708,12 +755,12 @@ ath5k_eeprom_convert_pcal_info_5111(struct ath5k_hw *ah, int mode,
                pd->pd_step = kcalloc(AR5K_EEPROM_N_PWR_POINTS_5111,
                                        sizeof(u8), GFP_KERNEL);
                if (!pd->pd_step)
-                        return -ENOMEM;
+                        goto err_out;
                pd->pd_pwr = kcalloc(AR5K_EEPROM_N_PWR_POINTS_5111,
                                        sizeof(s16), GFP_KERNEL);
                if (!pd->pd_pwr)
-                        return -ENOMEM;
+                        goto err_out;
                /* Fill raw dataset
                 * (convert power to 0.25dB units
@@ -734,6 +781,10 @@ ath5k_eeprom_convert_pcal_info_5111(struct ath5k_hw *ah, int mode,
        }
        return 0;
+err_out:
+        ath5k_eeprom_free_pcal_info(ah, mode);
+        return -ENOMEM;
 }
 /* Parse EEPROM data */
@@ -867,7 +918,7 @@ ath5k_eeprom_convert_pcal_info_5112(struct ath5k_hw *ah, int mode,
                                        GFP_KERNEL);
                if (!chinfo[pier].pd_curves)
-                        return -ENOMEM;
+                        goto err_out;
                /* Fill pd_curves */
                for (pdg = 0; pdg < ee->ee_pd_gains[mode]; pdg++) {
@@ -886,14 +937,13 @@ ath5k_eeprom_convert_pcal_info_5112(struct ath5k_hw *ah, int mode,
                                                sizeof(u8), GFP_KERNEL);
                                if (!pd->pd_step)
-                                        return -ENOMEM;
+                                        goto err_out;
                                pd->pd_pwr = kcalloc(pd->pd_points,
                                                sizeof(s16), GFP_KERNEL);
                                if (!pd->pd_pwr)
-                                        return -ENOMEM;
+                                        goto err_out;
                                /* Fill raw dataset
                                 * (all power levels are in 0.25dB units) */
@@ -925,13 +975,13 @@ ath5k_eeprom_convert_pcal_info_5112(struct ath5k_hw *ah, int mode,
                                                sizeof(u8), GFP_KERNEL);
                                if (!pd->pd_step)
-                                        return -ENOMEM;
+                                        goto err_out;
                                pd->pd_pwr = kcalloc(pd->pd_points,
                                                sizeof(s16), GFP_KERNEL);
                                if (!pd->pd_pwr)
-                                        return -ENOMEM;
+                                        goto err_out;
                                /* Fill raw dataset
                                 * (all power levels are in 0.25dB units) */
@@ -954,6 +1004,10 @@ ath5k_eeprom_convert_pcal_info_5112(struct ath5k_hw *ah, int mode,
        }
        return 0;
+err_out:
+        ath5k_eeprom_free_pcal_info(ah, mode);
+        return -ENOMEM;
 }
 /* Parse EEPROM data */
@@ -1156,7 +1210,7 @@ ath5k_eeprom_convert_pcal_info_2413(struct ath5k_hw *ah, int mode,
                                        GFP_KERNEL);
                if (!chinfo[pier].pd_curves)
-                        return -ENOMEM;
+                        goto err_out;
                /* Fill pd_curves */
                for (pdg = 0; pdg < ee->ee_pd_gains[mode]; pdg++) {
@@ -1177,13 +1231,13 @@ ath5k_eeprom_convert_pcal_info_2413(struct ath5k_hw *ah, int mode,
                                        sizeof(u8), GFP_KERNEL);
                        if (!pd->pd_step)
-                                return -ENOMEM;
+                                goto err_out;
                        pd->pd_pwr = kcalloc(pd->pd_points,
                                        sizeof(s16), GFP_KERNEL);
                        if (!pd->pd_pwr)
-                                return -ENOMEM;
+                                goto err_out;
                        /* Fill raw dataset
                         * convert all pwr levels to
@@ -1213,6 +1267,10 @@ ath5k_eeprom_convert_pcal_info_2413(struct ath5k_hw *ah, int mode,
        }
        return 0;
+err_out:
+        ath5k_eeprom_free_pcal_info(ah, mode);
+        return -ENOMEM;
 }
 /* Parse EEPROM data */
@@ -1534,53 +1592,6 @@ ath5k_eeprom_read_pcal_info(struct ath5k_hw *ah)
        return 0;
 }
-static int
-ath5k_eeprom_free_pcal_info(struct ath5k_hw *ah, int mode)
-{
-        struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
-        struct ath5k_chan_pcal_info *chinfo;
-        u8 pier, pdg;
-        switch (mode) {
-        case AR5K_EEPROM_MODE_11A:
-                if (!AR5K_EEPROM_HDR_11A(ee->ee_header))
-                        return 0;
-                chinfo = ee->ee_pwr_cal_a;
-                break;
-        case AR5K_EEPROM_MODE_11B:
-                if (!AR5K_EEPROM_HDR_11B(ee->ee_header))
-                        return 0;
-                chinfo = ee->ee_pwr_cal_b;
-                break;
-        case AR5K_EEPROM_MODE_11G:
-                if (!AR5K_EEPROM_HDR_11G(ee->ee_header))
-                        return 0;
-                chinfo = ee->ee_pwr_cal_g;
-                break;
-        default:
-                return -EINVAL;
-        }
-        for (pier = 0; pier < ee->ee_n_piers[mode]; pier++) {
-                if (!chinfo[pier].pd_curves)
-                        continue;
-                for (pdg = 0; pdg < ee->ee_pd_gains[mode]; pdg++) {
-                        struct ath5k_pdgain_info *pd =
-                                        &chinfo[pier].pd_curves[pdg];
-                        if (pd != NULL) {
-                                kfree(pd->pd_step);
-                                kfree(pd->pd_pwr);
-                        }
-                }
-                kfree(chinfo[pier].pd_curves);
-        }
-        return 0;
-}
 /* Read conformance test limits used for regulatory control */
 static int
 ath5k_eeprom_read_ctl_info(struct ath5k_hw *ah)
@@ -1721,35 +1732,6 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah)
        return ret;
 }
-/*
- * Read the MAC address from eeprom
- */
-int ath5k_eeprom_read_mac(struct ath5k_hw *ah, u8 *mac)
-{
-        u8 mac_d[ETH_ALEN] = {};
-        u32 total, offset;
-        u16 data;
-        int octet;
-        AR5K_EEPROM_READ(0x20, data);
-        for (offset = 0x1f, octet = 0, total = 0; offset >= 0x1d; offset--) {
-                AR5K_EEPROM_READ(offset, data);
-                total += data;
-                mac_d[octet + 1] = data & 0xff;
-                mac_d[octet] = data >> 8;
-                octet += 2;
-        }
-        if (!total || total == 3 * 0xffff)
-                return -EINVAL;
-        memcpy(mac, mac_d, ETH_ALEN);
-        return 0;
-}
 /***********************\
 * Init/Detach functions *
diff --git a/drivers/net/wireless/ath/ath5k/mac80211-ops.c b/drivers/net/wireless/ath/ath5k/mac80211-ops.c
index 9be29b728b1c..807bd6440169 100644
--- a/drivers/net/wireless/ath/ath5k/mac80211-ops.c
+++ b/drivers/net/wireless/ath/ath5k/mac80211-ops.c
@@ -282,6 +282,15 @@ ath5k_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
        if (changes & BSS_CHANGED_BEACON_INT)
                sc->bintval = bss_conf->beacon_int;
+        if (changes & BSS_CHANGED_ERP_SLOT) {
+                int slot_time;
+                ah->ah_short_slot = bss_conf->use_short_slot;
+                slot_time = ath5k_hw_get_default_slottime(ah) +
+                            3 * ah->ah_coverage_class;
+                ath5k_hw_set_ifs_intervals(ah, slot_time);
+        }
        if (changes & BSS_CHANGED_ASSOC) {
                avf->assoc = bss_conf->assoc;
                if (bss_conf->assoc)
diff --git a/drivers/net/wireless/ath/ath5k/pci.c b/drivers/net/wireless/ath/ath5k/pci.c
index 3c44689a700b..296c316a8341 100644
--- a/drivers/net/wireless/ath/ath5k/pci.c
+++ b/drivers/net/wireless/ath/ath5k/pci.c
@@ -17,6 +17,7 @@
 #include <linux/nl80211.h>
 #include <linux/pci.h>
 #include <linux/pci-aspm.h>
+#include <linux/etherdevice.h>
 #include "../ath.h"
 #include "ath5k.h"
 #include "debug.h"
@@ -108,11 +109,42 @@ int ath5k_hw_read_srev(struct ath5k_hw *ah)
        return 0;
 }
+/*
+ * Read the MAC address from eeprom or platform_data
+ */
+static int ath5k_pci_eeprom_read_mac(struct ath5k_hw *ah, u8 *mac)
+{
+        u8 mac_d[ETH_ALEN] = {};
+        u32 total, offset;
+        u16 data;
+        int octet;
+        AR5K_EEPROM_READ(0x20, data);
+        for (offset = 0x1f, octet = 0, total = 0; offset >= 0x1d; offset--) {
+                AR5K_EEPROM_READ(offset, data);
+                total += data;
+                mac_d[octet + 1] = data & 0xff;
+                mac_d[octet] = data >> 8;
+                octet += 2;
+        }
+        if (!total || total == 3 * 0xffff)
+                return -EINVAL;
+        memcpy(mac, mac_d, ETH_ALEN);
+        return 0;
+}
 /* Common ath_bus_opts structure */
 static const struct ath_bus_ops ath_pci_bus_ops = {
        .ath_bus_type = ATH_PCI,
        .read_cachesize = ath5k_pci_read_cachesize,
        .eeprom_read = ath5k_pci_eeprom_read,
+        .eeprom_read_mac = ath5k_pci_eeprom_read_mac,
 };
 /********************\
diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c
index d9b3f828455a..712a9ac4000e 100644
--- a/drivers/net/wireless/ath/ath5k/pcu.c
+++ b/drivers/net/wireless/ath/ath5k/pcu.c
@@ -75,7 +75,7 @@ static const unsigned int ack_rates_high[] =
 * bwmodes.
 */
 int ath5k_hw_get_frame_duration(struct ath5k_hw *ah,
-                int len, struct ieee80211_rate *rate)
+                int len, struct ieee80211_rate *rate, bool shortpre)
 {
        struct ath5k_softc *sc = ah->ah_sc;
        int sifs, preamble, plcp_bits, sym_time;
@@ -84,9 +84,15 @@ int ath5k_hw_get_frame_duration(struct ath5k_hw *ah,
        /* Fallback */
        if (!ah->ah_bwmode) {
-                dur = ieee80211_generic_frame_duration(sc->hw,
+                __le16 raw_dur = ieee80211_generic_frame_duration(sc->hw,
-                                                NULL, len, rate);
+                                        NULL, len, rate);
-                return le16_to_cpu(dur);
+                /* subtract difference between long and short preamble */
+                dur = le16_to_cpu(raw_dur);
+                if (shortpre)
+                        dur -= 96;
+                return dur;
        }
        bitrate = rate->bitrate;
@@ -145,9 +151,9 @@ unsigned int ath5k_hw_get_default_slottime(struct ath5k_hw *ah)
                slot_time = AR5K_INIT_SLOT_TIME_QUARTER_RATE;
                break;
        case AR5K_BWMODE_DEFAULT:
-                slot_time = AR5K_INIT_SLOT_TIME_DEFAULT;
        default:
-                if (channel->hw_value & CHANNEL_CCK)
+                slot_time = AR5K_INIT_SLOT_TIME_DEFAULT;
+                if ((channel->hw_value & CHANNEL_CCK) && !ah->ah_short_slot)
                        slot_time = AR5K_INIT_SLOT_TIME_B;
                break;
        }
@@ -263,27 +269,14 @@ static inline void ath5k_hw_write_rate_duration(struct ath5k_hw *ah)
                 * actual rate for this rate. See mac80211 tx.c
                 * ieee80211_duration() for a brief description of
                 * what rate we should choose to TX ACKs. */
-                tx_time = ath5k_hw_get_frame_duration(ah, 10, rate);
+                tx_time = ath5k_hw_get_frame_duration(ah, 10, rate, false);
                ath5k_hw_reg_write(ah, tx_time, reg);
                if (!(rate->flags & IEEE80211_RATE_SHORT_PREAMBLE))
                        continue;
-                /*
+                tx_time = ath5k_hw_get_frame_duration(ah, 10, rate, true);
-                 * We're not distinguishing short preamble here,
-                 * This is true, all we'll get is a longer value here
-                 * which is not necessarilly bad. We could use
-                 * export ieee80211_frame_duration() but that needs to be
-                 * fixed first to be properly used by mac802111 drivers:
-                 *
-                 *  - remove erp stuff and let the routine figure ofdm
-                 *    erp rates
-                 *  - remove passing argument ieee80211_local as
-                 *    drivers don't have access to it
-                 *  - move drivers using ieee80211_generic_frame_duration()
-                 *    to this
-                 */
                ath5k_hw_reg_write(ah, tx_time,
                        reg + (AR5K_SET_SHORT_PREAMBLE << 2));
        }
diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c
index 3343fb9e4940..b18c5021aac3 100644
--- a/drivers/net/wireless/ath/ath5k/qcu.c
+++ b/drivers/net/wireless/ath/ath5k/qcu.c
@@ -519,7 +519,7 @@ int ath5k_hw_set_ifs_intervals(struct ath5k_hw *ah, unsigned int slot_time)
                return -EINVAL;
        sifs = ath5k_hw_get_default_sifs(ah);
-        sifs_clock = ath5k_hw_htoclock(ah, sifs);
+        sifs_clock = ath5k_hw_htoclock(ah, sifs - 2);
        /* EIFS
         * Txtime of ack at lowest rate + SIFS + DIFS
@@ -550,7 +550,7 @@ int ath5k_hw_set_ifs_intervals(struct ath5k_hw *ah, unsigned int slot_time)
        else
                rate = &sc->sbands[IEEE80211_BAND_2GHZ].bitrates[0];
-        ack_tx_time = ath5k_hw_get_frame_duration(ah, 10, rate);
+        ack_tx_time = ath5k_hw_get_frame_duration(ah, 10, rate, false);
        /* ack_tx_time includes an SIFS already */
        eifs = ack_tx_time + sifs + 2 * slot_time;
diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c
index 84206898f77d..3510de2cf622 100644
--- a/drivers/net/wireless/ath/ath5k/reset.c
+++ b/drivers/net/wireless/ath/ath5k/reset.c
@@ -159,6 +159,11 @@ static void ath5k_hw_init_core_clock(struct ath5k_hw *ah)
        rxlat = AR5K_REG_MS(usec_reg, AR5K_USEC_RX_LATENCY_5211);
        /*
+         * Set default Tx frame to Tx data start delay
+         */
+        txf2txs = AR5K_INIT_TXF2TXD_START_DEFAULT;
+        /*
         * 5210 initvals don't include usec settings
         * so we need to use magic values here for
         * tx/rx latencies
diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig
index ad57a6d23110..d9ff8413ab9a 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -5,7 +5,7 @@ config ATH9K_COMMON
 config ATH9K
        tristate "Atheros 802.11n wireless cards support"
-        depends on PCI && MAC80211
+        depends on MAC80211
        select ATH9K_HW
        select MAC80211_LEDS
        select LEDS_CLASS
@@ -23,6 +23,25 @@ config ATH9K
          If you choose to build a module, it'll be called ath9k.
+config ATH9K_PCI
+        bool "Atheros ath9k PCI/PCIe bus support"
+        depends on ATH9K && PCI
+        default PCI
+        ---help---
+          This option enables the PCI bus support in ath9k.
+          Say Y, if you have a compatible PCI/PCIe wireless card.
+config ATH9K_AHB
+        bool "Atheros ath9k AHB bus support"
+        depends on ATH9K
+        default n
+        ---help---
+          This option enables the AHB bus support in ath9k.
+          Say Y, if you have a SoC with a compatible built-in
+          wireless MAC. Say N if unsure.
 config ATH9K_DEBUGFS
        bool "Atheros ath9k debugging"
        depends on ATH9K && DEBUG_FS
diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wireless/ath/ath9k/Makefile
index 4d66ca8042eb..05a6fade7b1c 100644
--- a/drivers/net/wireless/ath/ath9k/Makefile
+++ b/drivers/net/wireless/ath/ath9k/Makefile
@@ -6,8 +6,8 @@ ath9k-y +=	beacon.o \
                xmit.o \
 ath9k-$(CONFIG_ATH9K_RATE_CONTROL) += rc.o
-ath9k-$(CONFIG_PCI) += pci.o
+ath9k-$(CONFIG_ATH9K_PCI) += pci.o
-ath9k-$(CONFIG_ATHEROS_AR71XX) += ahb.o
+ath9k-$(CONFIG_ATH9K_AHB) += ahb.o
 ath9k-$(CONFIG_ATH9K_DEBUGFS) += debug.o
 obj-$(CONFIG_ATH9K) += ath9k.o
@@ -48,4 +48,6 @@ ath9k_htc-y +=	htc_hst.o \
                htc_drv_init.o \
                htc_drv_gpio.o
+ath9k_htc-$(CONFIG_ATH9K_HTC_DEBUGFS) += htc_drv_debug.o
 obj-$(CONFIG_ATH9K_HTC) += ath9k_htc.o
diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c
index 9cb0efa9b4c0..61956392f2da 100644
--- a/drivers/net/wireless/ath/ath9k/ahb.c
+++ b/drivers/net/wireless/ath/ath9k/ahb.c
@@ -21,6 +21,18 @@
 #include <linux/ath9k_platform.h>
 #include "ath9k.h"
+static const struct platform_device_id ath9k_platform_id_table[] = {
+        {
+                .name = "ath9k",
+                .driver_data = AR5416_AR9100_DEVID,
+        },
+        {
+                .name = "ar934x_wmac",
+                .driver_data = AR9300_DEVID_AR9340,
+        },
+        {},
+};
 /* return bus cachesize in 4B word units */
 static void ath_ahb_read_cachesize(struct ath_common *common, int *csz)
 {
@@ -57,6 +69,7 @@ static int ath_ahb_probe(struct platform_device *pdev)
        struct ath_softc *sc;
        struct ieee80211_hw *hw;
        struct resource *res;
+        const struct platform_device_id *id = platform_get_device_id(pdev);
        int irq;
        int ret = 0;
        struct ath_hw *ah;
@@ -116,7 +129,7 @@ static int ath_ahb_probe(struct platform_device *pdev)
                goto err_free_hw;
        }
-        ret = ath9k_init_device(AR5416_AR9100_DEVID, sc, 0x0, &ath_ahb_bus_ops);
+        ret = ath9k_init_device(id->driver_data, sc, 0x0, &ath_ahb_bus_ops);
        if (ret) {
                dev_err(&pdev->dev, "failed to initialize device\n");
                goto err_irq;
@@ -165,8 +178,11 @@ static struct platform_driver ath_ahb_driver = {
                .name   = "ath9k",
                .owner  = THIS_MODULE,
        },
+        .id_table    = ath9k_platform_id_table,
 };
+MODULE_DEVICE_TABLE(platform, ath9k_platform_id_table);
 int ath_ahb_init(void)
 {
        return platform_driver_register(&ath_ahb_driver);
diff --git a/drivers/net/wireless/ath/ath9k/ani.c b/drivers/net/wireless/ath/ath9k/ani.c
index 2e31c775351f..5a1f4f511bc1 100644
--- a/drivers/net/wireless/ath/ath9k/ani.c
+++ b/drivers/net/wireless/ath/ath9k/ani.c
@@ -899,12 +899,6 @@ void ath9k_hw_ani_init(struct ath_hw *ah)
         * check here default level should not modify INI setting.
         */
        if (use_new_ani(ah)) {
-                const struct ani_ofdm_level_entry *entry_ofdm;
-                const struct ani_cck_level_entry *entry_cck;
-                entry_ofdm = &ofdm_level_table[ATH9K_ANI_OFDM_DEF_LEVEL];
-                entry_cck = &cck_level_table[ATH9K_ANI_CCK_DEF_LEVEL];
                ah->aniperiod = ATH9K_ANI_PERIOD_NEW;
                ah->config.ani_poll_interval = ATH9K_ANI_POLLINTERVAL_NEW;
        } else {
diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c
index 106c0b06cf55..4bf9dab4f2b3 100644
--- a/drivers/net/wireless/ath/ath9k/ar5008_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar5008_phy.c
@@ -44,6 +44,34 @@ static const int m1ThreshExt_off = 127;
 static const int m2ThreshExt_off = 127;
+static void ar5008_rf_bank_setup(u32 *bank, struct ar5416IniArray *array,
+                                 int col)
+{
+        int i;
+        for (i = 0; i < array->ia_rows; i++)
+                bank[i] = INI_RA(array, i, col);
+}
+#define REG_WRITE_RF_ARRAY(iniarray, regData, regWr) \
+        ar5008_write_rf_array(ah, iniarray, regData, &(regWr))
+static void ar5008_write_rf_array(struct ath_hw *ah, struct ar5416IniArray *array,
+                                  u32 *data, unsigned int *writecnt)
+{
+        int r;
+        ENABLE_REGWRITE_BUFFER(ah);
+        for (r = 0; r < array->ia_rows; r++) {
+                REG_WRITE(ah, INI_RA(array, r, 0), data[r]);
+                DO_DELAY(*writecnt);
+        }
+        REGWRITE_BUFFER_FLUSH(ah);
+}
 /**
 * ar5008_hw_phy_modify_rx_buffer() - perform analog swizzling of parameters
 * @rfbuf:
@@ -530,16 +558,16 @@ static bool ar5008_hw_set_rf_regs(struct ath_hw *ah,
        eepMinorRev = ah->eep_ops->get_eeprom(ah, EEP_MINOR_REV);
        /* Setup Bank 0 Write */
-        RF_BANK_SETUP(ah->analogBank0Data, &ah->iniBank0, 1);
+        ar5008_rf_bank_setup(ah->analogBank0Data, &ah->iniBank0, 1);
        /* Setup Bank 1 Write */
-        RF_BANK_SETUP(ah->analogBank1Data, &ah->iniBank1, 1);
+        ar5008_rf_bank_setup(ah->analogBank1Data, &ah->iniBank1, 1);
        /* Setup Bank 2 Write */
-        RF_BANK_SETUP(ah->analogBank2Data, &ah->iniBank2, 1);
+        ar5008_rf_bank_setup(ah->analogBank2Data, &ah->iniBank2, 1);
        /* Setup Bank 6 Write */
-        RF_BANK_SETUP(ah->analogBank3Data, &ah->iniBank3,
+        ar5008_rf_bank_setup(ah->analogBank3Data, &ah->iniBank3,
                      modesIndex);
        {
                int i;
@@ -569,7 +597,7 @@ static bool ar5008_hw_set_rf_regs(struct ath_hw *ah,
        }
        /* Setup Bank 7 Setup */
-        RF_BANK_SETUP(ah->analogBank7Data, &ah->iniBank7, 1);
+        ar5008_rf_bank_setup(ah->analogBank7Data, &ah->iniBank7, 1);
        /* Write Analog registers */
        REG_WRITE_RF_ARRAY(&ah->iniBank0, ah->analogBank0Data,
@@ -729,6 +757,7 @@ static int ar5008_hw_process_ini(struct ath_hw *ah,
                                 struct ath9k_channel *chan)
 {
        struct ath_regulatory *regulatory = ath9k_hw_regulatory(ah);
+        struct ath_common *common = ath9k_hw_common(ah);
        int i, regWrites = 0;
        struct ieee80211_channel *channel = chan->chan;
        u32 modesIndex, freqIndex;
@@ -805,7 +834,8 @@ static int ar5008_hw_process_ini(struct ath_hw *ah,
                REG_WRITE(ah, reg, val);
                if (reg >= 0x7800 && reg < 0x78a0
-                    && ah->config.analog_shiftreg) {
+                    && ah->config.analog_shiftreg
+                    && (common->bus_ops->ath_bus_type != ATH_USB)) {
                        udelay(100);
                }
@@ -835,7 +865,8 @@ static int ar5008_hw_process_ini(struct ath_hw *ah,
                REG_WRITE(ah, reg, val);
                if (reg >= 0x7800 && reg < 0x78a0
-                    && ah->config.analog_shiftreg) {
+                    && ah->config.analog_shiftreg
+                    && (common->bus_ops->ath_bus_type != ATH_USB)) {
                        udelay(100);
                }
diff --git a/drivers/net/wireless/ath/ath9k/ar9002_calib.c b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
index 76388c6d6692..cb611b287b35 100644
--- a/drivers/net/wireless/ath/ath9k/ar9002_calib.c
+++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
@@ -26,6 +26,27 @@ enum ar9002_cal_types {
        IQ_MISMATCH_CAL = BIT(2),
 };
+static bool ar9002_hw_is_cal_supported(struct ath_hw *ah,
+                                struct ath9k_channel *chan,
+                                enum ar9002_cal_types cal_type)
+{
+        bool supported = false;
+        switch (ah->supp_cals & cal_type) {
+        case IQ_MISMATCH_CAL:
+                /* Run IQ Mismatch for non-CCK only */
+                if (!IS_CHAN_B(chan))
+                        supported = true;
+                break;
+        case ADC_GAIN_CAL:
+        case ADC_DC_CAL:
+                /* Run ADC Gain Cal for non-CCK & non 2GHz-HT20 only */
+                if (!IS_CHAN_B(chan) &&
+                    !(IS_CHAN_2GHZ(chan) && IS_CHAN_HT20(chan)))
+                        supported = true;
+                break;
+        }
+        return supported;
+}
 static void ar9002_hw_setup_calibration(struct ath_hw *ah,
                                        struct ath9k_cal_list *currCal)
@@ -858,26 +879,32 @@ static bool ar9002_hw_init_cal(struct ath_hw *ah, struct ath9k_channel *chan)
        if (AR_SREV_9100(ah) || AR_SREV_9160_10_OR_LATER(ah)) {
                ah->supp_cals = IQ_MISMATCH_CAL;
-                if (AR_SREV_9160_10_OR_LATER(ah) &&
+                if (AR_SREV_9160_10_OR_LATER(ah))
-                    !(IS_CHAN_2GHZ(chan) && IS_CHAN_HT20(chan))) {
                        ah->supp_cals |= ADC_GAIN_CAL | ADC_DC_CAL;
+                if (AR_SREV_9287(ah))
+                        ah->supp_cals &= ~ADC_GAIN_CAL;
+                if (ar9002_hw_is_cal_supported(ah, chan, ADC_GAIN_CAL)) {
                        INIT_CAL(&ah->adcgain_caldata);
                        INSERT_CAL(ah, &ah->adcgain_caldata);
                        ath_dbg(common, ATH_DBG_CALIBRATE,
-                                "enabling ADC Gain Calibration.\n");
+                                        "enabling ADC Gain Calibration.\n");
+                }
+                if (ar9002_hw_is_cal_supported(ah, chan, ADC_DC_CAL)) {
                        INIT_CAL(&ah->adcdc_caldata);
                        INSERT_CAL(ah, &ah->adcdc_caldata);
                        ath_dbg(common, ATH_DBG_CALIBRATE,
-                                "enabling ADC DC Calibration.\n");
+                                        "enabling ADC DC Calibration.\n");
                }
-                INIT_CAL(&ah->iq_caldata);
+                if (ar9002_hw_is_cal_supported(ah, chan, IQ_MISMATCH_CAL)) {
-                INSERT_CAL(ah, &ah->iq_caldata);
+                        INIT_CAL(&ah->iq_caldata);
-                ath_dbg(common, ATH_DBG_CALIBRATE,
+                        INSERT_CAL(ah, &ah->iq_caldata);
-                        "enabling IQ Calibration.\n");
+                        ath_dbg(common, ATH_DBG_CALIBRATE,
+                                        "enabling IQ Calibration.\n");
+                }
                ah->cal_list_curr = ah->cal_list;
diff --git a/drivers/net/wireless/ath/ath9k/ar9002_mac.c b/drivers/net/wireless/ath/ath9k/ar9002_mac.c
index 399ab3bb299b..7a332f16b79a 100644
--- a/drivers/net/wireless/ath/ath9k/ar9002_mac.c
+++ b/drivers/net/wireless/ath/ath9k/ar9002_mac.c
@@ -290,7 +290,6 @@ static void ar9002_hw_set11n_txdesc(struct ath_hw *ah, void *ds,
                | (flags & ATH9K_TXDESC_VMF ? AR_VirtMoreFrag : 0)
                | SM(txPower, AR_XmitPower)
                | (flags & ATH9K_TXDESC_VEOL ? AR_VEOL : 0)
-                | (flags & ATH9K_TXDESC_CLRDMASK ? AR_ClrDestMask : 0)
                | (flags & ATH9K_TXDESC_INTREQ ? AR_TxIntrReq : 0)
                | (keyIx != ATH9K_TXKEYIX_INVALID ? AR_DestIdxValid : 0);
@@ -311,6 +310,16 @@ static void ar9002_hw_set11n_txdesc(struct ath_hw *ah, void *ds,
        }
 }
+static void ar9002_hw_set_clrdmask(struct ath_hw *ah, void *ds, bool val)
+{
+        struct ar5416_desc *ads = AR5416DESC(ds);
+        if (val)
+                ads->ds_ctl0 |= AR_ClrDestMask;
+        else
+                ads->ds_ctl0 &= ~AR_ClrDestMask;
+}
 static void ar9002_hw_set11n_ratescenario(struct ath_hw *ah, void *ds,
                                          void *lastds,
                                          u32 durUpdateEn, u32 rtsctsRate,
@@ -406,26 +415,6 @@ static void ar9002_hw_clr11n_aggr(struct ath_hw *ah, void *ds)
        ads->ds_ctl1 &= (~AR_IsAggr & ~AR_MoreAggr);
 }
-static void ar9002_hw_set11n_burstduration(struct ath_hw *ah, void *ds,
-                                           u32 burstDuration)
-{
-        struct ar5416_desc *ads = AR5416DESC(ds);
-        ads->ds_ctl2 &= ~AR_BurstDur;
-        ads->ds_ctl2 |= SM(burstDuration, AR_BurstDur);
-}
-static void ar9002_hw_set11n_virtualmorefrag(struct ath_hw *ah, void *ds,
-                                            u32 vmf)
-{
-        struct ar5416_desc *ads = AR5416DESC(ds);
-        if (vmf)
-                ads->ds_ctl0 |= AR_VirtMoreFrag;
-        else
-                ads->ds_ctl0 &= ~AR_VirtMoreFrag;
-}
 void ath9k_hw_setuprxdesc(struct ath_hw *ah, struct ath_desc *ds,
                          u32 size, u32 flags)
 {
@@ -458,6 +447,5 @@ void ar9002_hw_attach_mac_ops(struct ath_hw *ah)
        ops->set11n_aggr_middle = ar9002_hw_set11n_aggr_middle;
        ops->set11n_aggr_last = ar9002_hw_set11n_aggr_last;
        ops->clr11n_aggr = ar9002_hw_clr11n_aggr;
-        ops->set11n_burstduration = ar9002_hw_set11n_burstduration;
+        ops->set_clrdmask = ar9002_hw_set_clrdmask;
-        ops->set11n_virtualmorefrag = ar9002_hw_set11n_virtualmorefrag;
 }
diff --git a/drivers/net/wireless/ath/ath9k/ar9002_phy.c b/drivers/net/wireless/ath/ath9k/ar9002_phy.c
index 7d68d61e406b..a57e963cf0dc 100644
--- a/drivers/net/wireless/ath/ath9k/ar9002_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar9002_phy.c
@@ -517,23 +517,7 @@ static void ar9002_hw_set_nf_limits(struct ath_hw *ah)
        }
 }
-void ar9002_hw_attach_phy_ops(struct ath_hw *ah)
+static void ar9002_hw_antdiv_comb_conf_get(struct ath_hw *ah,
-{
-        struct ath_hw_private_ops *priv_ops = ath9k_hw_private_ops(ah);
-        priv_ops->set_rf_regs = NULL;
-        priv_ops->rf_alloc_ext_banks = NULL;
-        priv_ops->rf_free_ext_banks = NULL;
-        priv_ops->rf_set_freq = ar9002_hw_set_channel;
-        priv_ops->spur_mitigate_freq = ar9002_hw_spur_mitigate;
-        priv_ops->olc_init = ar9002_olc_init;
-        priv_ops->compute_pll_control = ar9002_hw_compute_pll_control;
-        priv_ops->do_getnf = ar9002_hw_do_getnf;
-        ar9002_hw_set_nf_limits(ah);
-}
-void ath9k_hw_antdiv_comb_conf_get(struct ath_hw *ah,
                                   struct ath_hw_antcomb_conf *antconf)
 {
        u32 regval;
@@ -545,10 +529,11 @@ void ath9k_hw_antdiv_comb_conf_get(struct ath_hw *ah,
                                 AR_PHY_9285_ANT_DIV_ALT_LNACONF_S;
        antconf->fast_div_bias = (regval & AR_PHY_9285_FAST_DIV_BIAS) >>
                                  AR_PHY_9285_FAST_DIV_BIAS_S;
+        antconf->lna1_lna2_delta = -3;
+        antconf->div_group = 0;
 }
-EXPORT_SYMBOL(ath9k_hw_antdiv_comb_conf_get);
-void ath9k_hw_antdiv_comb_conf_set(struct ath_hw *ah,
+static void ar9002_hw_antdiv_comb_conf_set(struct ath_hw *ah,
                                   struct ath_hw_antcomb_conf *antconf)
 {
        u32 regval;
@@ -566,4 +551,23 @@ void ath9k_hw_antdiv_comb_conf_set(struct ath_hw *ah,
        REG_WRITE(ah, AR_PHY_MULTICHAIN_GAIN_CTL, regval);
 }
-EXPORT_SYMBOL(ath9k_hw_antdiv_comb_conf_set);
+void ar9002_hw_attach_phy_ops(struct ath_hw *ah)
+{
+        struct ath_hw_private_ops *priv_ops = ath9k_hw_private_ops(ah);
+        struct ath_hw_ops *ops = ath9k_hw_ops(ah);
+        priv_ops->set_rf_regs = NULL;
+        priv_ops->rf_alloc_ext_banks = NULL;
+        priv_ops->rf_free_ext_banks = NULL;
+        priv_ops->rf_set_freq = ar9002_hw_set_channel;
+        priv_ops->spur_mitigate_freq = ar9002_hw_spur_mitigate;
+        priv_ops->olc_init = ar9002_olc_init;
+        priv_ops->compute_pll_control = ar9002_hw_compute_pll_control;
+        priv_ops->do_getnf = ar9002_hw_do_getnf;
+        ops->antdiv_comb_conf_get = ar9002_hw_antdiv_comb_conf_get;
+        ops->antdiv_comb_conf_set = ar9002_hw_antdiv_comb_conf_set;
+        ar9002_hw_set_nf_limits(ah);
+}
diff --git a/drivers/net/wireless/ath/ath9k/ar9002_phy.h b/drivers/net/wireless/ath/ath9k/ar9002_phy.h
index 37663dbbcf57..47780ef1c892 100644
--- a/drivers/net/wireless/ath/ath9k/ar9002_phy.h
+++ b/drivers/net/wireless/ath/ath9k/ar9002_phy.h
@@ -483,7 +483,11 @@
 #define AR_PHY_TX_PWRCTRL_INIT_TX_GAIN     0x01F80000
 #define AR_PHY_TX_PWRCTRL_INIT_TX_GAIN_S   19
+#define AR_PHY_TX_PWRCTRL8       0xa278
 #define AR_PHY_TX_PWRCTRL9       0xa27C
+#define AR_PHY_TX_PWRCTRL10       0xa394
 #define AR_PHY_TX_DESIRED_SCALE_CCK        0x00007C00
 #define AR_PHY_TX_DESIRED_SCALE_CCK_S      10
 #define AR_PHY_TX_PWRCTRL9_RES_DC_REMOVAL  0x80000000
@@ -495,6 +499,8 @@
 #define AR_PHY_CH0_TX_PWRCTRL11  0xa398
 #define AR_PHY_CH1_TX_PWRCTRL11  0xb398
+#define AR_PHY_CH0_TX_PWRCTRL12  0xa3dc
+#define AR_PHY_CH0_TX_PWRCTRL13  0xa3e0
 #define AR_PHY_TX_PWRCTRL_OLPC_TEMP_COMP   0x0000FC00
 #define AR_PHY_TX_PWRCTRL_OLPC_TEMP_COMP_S 10
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h b/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h
index 9ecca93392e8..f915a3dbfcad 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h
+++ b/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h
@@ -34,10 +34,10 @@ static const u32 ar9300_2p2_radio_postamble[][5] = {
 static const u32 ar9300Modes_lowest_ob_db_tx_gain_table_2p2[][5] = {
        /* Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20   */
-        {0x0000a2dc, 0x00033800, 0x00033800, 0x00637800, 0x00637800},
+        {0x0000a2dc, 0x00033800, 0x00033800, 0x03aaa352, 0x03aaa352},
-        {0x0000a2e0, 0x0003c000, 0x0003c000, 0x03838000, 0x03838000},
+        {0x0000a2e0, 0x0003c000, 0x0003c000, 0x03ccc584, 0x03ccc584},
-        {0x0000a2e4, 0x03fc0000, 0x03fc0000, 0x03fc0000, 0x03fc0000},
+        {0x0000a2e4, 0x03fc0000, 0x03fc0000, 0x03f0f800, 0x03f0f800},
-        {0x0000a2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000a2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
        {0x0000a410, 0x000050d9, 0x000050d9, 0x000050d9, 0x000050d9},
        {0x0000a500, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
        {0x0000a504, 0x06000003, 0x06000003, 0x04000002, 0x04000002},
@@ -119,14 +119,14 @@ static const u32 ar9300Modes_lowest_ob_db_tx_gain_table_2p2[][5] = {
        {0x0000a634, 0x04411104, 0x04411104, 0x04015005, 0x04015005},
        {0x0000a638, 0x04411104, 0x04411104, 0x04015005, 0x04015005},
        {0x0000a63c, 0x04411104, 0x04411104, 0x04015005, 0x04015005},
-        {0x0000b2dc, 0x00033800, 0x00033800, 0x00637800, 0x00637800},
+        {0x0000b2dc, 0x00033800, 0x00033800, 0x03aaa352, 0x03aaa352},
-        {0x0000b2e0, 0x0003c000, 0x0003c000, 0x03838000, 0x03838000},
+        {0x0000b2e0, 0x0003c000, 0x0003c000, 0x03ccc584, 0x03ccc584},
-        {0x0000b2e4, 0x03fc0000, 0x03fc0000, 0x03fc0000, 0x03fc0000},
+        {0x0000b2e4, 0x03fc0000, 0x03fc0000, 0x03f0f800, 0x03f0f800},
-        {0x0000b2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000b2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
-        {0x0000c2dc, 0x00033800, 0x00033800, 0x00637800, 0x00637800},
+        {0x0000c2dc, 0x00033800, 0x00033800, 0x03aaa352, 0x03aaa352},
-        {0x0000c2e0, 0x0003c000, 0x0003c000, 0x03838000, 0x03838000},
+        {0x0000c2e0, 0x0003c000, 0x0003c000, 0x03ccc584, 0x03ccc584},
-        {0x0000c2e4, 0x03fc0000, 0x03fc0000, 0x03fc0000, 0x03fc0000},
+        {0x0000c2e4, 0x03fc0000, 0x03fc0000, 0x03f0f800, 0x03f0f800},
-        {0x0000c2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000c2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
        {0x00016044, 0x012492d4, 0x012492d4, 0x012492d4, 0x012492d4},
        {0x00016048, 0x62480001, 0x62480001, 0x62480001, 0x62480001},
        {0x00016068, 0x6db6db6c, 0x6db6db6c, 0x6db6db6c, 0x6db6db6c},
@@ -835,10 +835,10 @@ static const u32 ar9300_2p2_baseband_core[][2] = {
 static const u32 ar9300Modes_high_power_tx_gain_table_2p2[][5] = {
        /* Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20   */
-        {0x0000a2dc, 0x0380c7fc, 0x0380c7fc, 0x00637800, 0x00637800},
+        {0x0000a2dc, 0x0380c7fc, 0x0380c7fc, 0x03aaa352, 0x03aaa352},
-        {0x0000a2e0, 0x0000f800, 0x0000f800, 0x03838000, 0x03838000},
+        {0x0000a2e0, 0x0000f800, 0x0000f800, 0x03ccc584, 0x03ccc584},
-        {0x0000a2e4, 0x03ff0000, 0x03ff0000, 0x03fc0000, 0x03fc0000},
+        {0x0000a2e4, 0x03ff0000, 0x03ff0000, 0x03f0f800, 0x03f0f800},
-        {0x0000a2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000a2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
        {0x0000a410, 0x000050d8, 0x000050d8, 0x000050d9, 0x000050d9},
        {0x0000a500, 0x00002220, 0x00002220, 0x00000000, 0x00000000},
        {0x0000a504, 0x04002222, 0x04002222, 0x04000002, 0x04000002},
@@ -920,14 +920,14 @@ static const u32 ar9300Modes_high_power_tx_gain_table_2p2[][5] = {
        {0x0000a634, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
        {0x0000a638, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
        {0x0000a63c, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
-        {0x0000b2dc, 0x0380c7fc, 0x0380c7fc, 0x00637800, 0x00637800},
+        {0x0000b2dc, 0x0380c7fc, 0x0380c7fc, 0x03aaa352, 0x03aaa352},
-        {0x0000b2e0, 0x0000f800, 0x0000f800, 0x03838000, 0x03838000},
+        {0x0000b2e0, 0x0000f800, 0x0000f800, 0x03ccc584, 0x03ccc584},
-        {0x0000b2e4, 0x03ff0000, 0x03ff0000, 0x03fc0000, 0x03fc0000},
+        {0x0000b2e4, 0x03ff0000, 0x03ff0000, 0x03f0f800, 0x03f0f800},
-        {0x0000b2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000b2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
-        {0x0000c2dc, 0x0380c7fc, 0x0380c7fc, 0x00637800, 0x00637800},
+        {0x0000c2dc, 0x0380c7fc, 0x0380c7fc, 0x03aaa352, 0x03aaa352},
-        {0x0000c2e0, 0x0000f800, 0x0000f800, 0x03838000, 0x03838000},
+        {0x0000c2e0, 0x0000f800, 0x0000f800, 0x03ccc584, 0x03ccc584},
-        {0x0000c2e4, 0x03ff0000, 0x03ff0000, 0x03fc0000, 0x03fc0000},
+        {0x0000c2e4, 0x03ff0000, 0x03ff0000, 0x03f0f800, 0x03f0f800},
-        {0x0000c2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000c2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
        {0x00016044, 0x056db2e6, 0x056db2e6, 0x056db2e6, 0x056db2e6},
        {0x00016048, 0xae480001, 0xae480001, 0xae480001, 0xae480001},
        {0x00016068, 0x6eb6db6c, 0x6eb6db6c, 0x6eb6db6c, 0x6eb6db6c},
@@ -941,10 +941,10 @@ static const u32 ar9300Modes_high_power_tx_gain_table_2p2[][5] = {
 static const u32 ar9300Modes_high_ob_db_tx_gain_table_2p2[][5] = {
        /* Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20   */
-        {0x0000a2dc, 0x01feee00, 0x01feee00, 0x00637800, 0x00637800},
+        {0x0000a2dc, 0x01feee00, 0x01feee00, 0x03aaa352, 0x03aaa352},
-        {0x0000a2e0, 0x0000f000, 0x0000f000, 0x03838000, 0x03838000},
+        {0x0000a2e0, 0x0000f000, 0x0000f000, 0x03ccc584, 0x03ccc584},
-        {0x0000a2e4, 0x01ff0000, 0x01ff0000, 0x03fc0000, 0x03fc0000},
+        {0x0000a2e4, 0x01ff0000, 0x01ff0000, 0x03f0f800, 0x03f0f800},
-        {0x0000a2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000a2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
        {0x0000a410, 0x000050d8, 0x000050d8, 0x000050d9, 0x000050d9},
        {0x0000a500, 0x00002220, 0x00002220, 0x00000000, 0x00000000},
        {0x0000a504, 0x04002222, 0x04002222, 0x04000002, 0x04000002},
@@ -1026,14 +1026,14 @@ static const u32 ar9300Modes_high_ob_db_tx_gain_table_2p2[][5] = {
        {0x0000a634, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
        {0x0000a638, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
        {0x0000a63c, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
-        {0x0000b2dc, 0x01feee00, 0x01feee00, 0x00637800, 0x00637800},
+        {0x0000b2dc, 0x01feee00, 0x01feee00, 0x03aaa352, 0x03aaa352},
-        {0x0000b2e0, 0x0000f000, 0x0000f000, 0x03838000, 0x03838000},
+        {0x0000b2e0, 0x0000f000, 0x0000f000, 0x03ccc584, 0x03ccc584},
-        {0x0000b2e4, 0x01ff0000, 0x01ff0000, 0x03fc0000, 0x03fc0000},
+        {0x0000b2e4, 0x01ff0000, 0x01ff0000, 0x03f0f800, 0x03f0f800},
-        {0x0000b2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000b2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
-        {0x0000c2dc, 0x01feee00, 0x01feee00, 0x00637800, 0x00637800},
+        {0x0000c2dc, 0x01feee00, 0x01feee00, 0x03aaa352, 0x03aaa352},
-        {0x0000c2e0, 0x0000f000, 0x0000f000, 0x03838000, 0x03838000},
+        {0x0000c2e0, 0x0000f000, 0x0000f000, 0x03ccc584, 0x03ccc584},
-        {0x0000c2e4, 0x01ff0000, 0x01ff0000, 0x03fc0000, 0x03fc0000},
+        {0x0000c2e4, 0x01ff0000, 0x01ff0000, 0x03f0f800, 0x03f0f800},
-        {0x0000c2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000c2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
        {0x00016044, 0x056db2e4, 0x056db2e4, 0x056db2e4, 0x056db2e4},
        {0x00016048, 0x8e480001, 0x8e480001, 0x8e480001, 0x8e480001},
        {0x00016068, 0x6db6db6c, 0x6db6db6c, 0x6db6db6c, 0x6db6db6c},
@@ -1307,10 +1307,10 @@ static const u32 ar9300Common_rx_gain_table_2p2[][2] = {
 static const u32 ar9300Modes_low_ob_db_tx_gain_table_2p2[][5] = {
        /* Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20   */
-        {0x0000a2dc, 0x0380c7fc, 0x0380c7fc, 0x00637800, 0x00637800},
+        {0x0000a2dc, 0x00033800, 0x00033800, 0x03aaa352, 0x03aaa352},
-        {0x0000a2e0, 0x0000f800, 0x0000f800, 0x03838000, 0x03838000},
+        {0x0000a2e0, 0x0003c000, 0x0003c000, 0x03ccc584, 0x03ccc584},
-        {0x0000a2e4, 0x03ff0000, 0x03ff0000, 0x03fc0000, 0x03fc0000},
+        {0x0000a2e4, 0x03fc0000, 0x03fc0000, 0x03f0f800, 0x03f0f800},
-        {0x0000a2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000a2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
        {0x0000a410, 0x000050d9, 0x000050d9, 0x000050d9, 0x000050d9},
        {0x0000a500, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
        {0x0000a504, 0x06000003, 0x06000003, 0x04000002, 0x04000002},
@@ -1329,21 +1329,21 @@ static const u32 ar9300Modes_low_ob_db_tx_gain_table_2p2[][5] = {
        {0x0000a538, 0x4702244a, 0x4702244a, 0x34000e24, 0x34000e24},
        {0x0000a53c, 0x4b02244c, 0x4b02244c, 0x38001640, 0x38001640},
        {0x0000a540, 0x4e02246c, 0x4e02246c, 0x3c001660, 0x3c001660},
-        {0x0000a544, 0x5302266c, 0x5302266c, 0x3f001861, 0x3f001861},
+        {0x0000a544, 0x52022470, 0x52022470, 0x3f001861, 0x3f001861},
-        {0x0000a548, 0x5702286c, 0x5702286c, 0x43001a81, 0x43001a81},
+        {0x0000a548, 0x55022490, 0x55022490, 0x43001a81, 0x43001a81},
-        {0x0000a54c, 0x5c02486b, 0x5c02486b, 0x47001a83, 0x47001a83},
+        {0x0000a54c, 0x59022492, 0x59022492, 0x47001a83, 0x47001a83},
-        {0x0000a550, 0x61024a6c, 0x61024a6c, 0x4a001c84, 0x4a001c84},
+        {0x0000a550, 0x5d022692, 0x5d022692, 0x4a001c84, 0x4a001c84},
-        {0x0000a554, 0x66026a6c, 0x66026a6c, 0x4e001ce3, 0x4e001ce3},
+        {0x0000a554, 0x61022892, 0x61022892, 0x4e001ce3, 0x4e001ce3},
-        {0x0000a558, 0x6b026e6c, 0x6b026e6c, 0x52001ce5, 0x52001ce5},
+        {0x0000a558, 0x65024890, 0x65024890, 0x52001ce5, 0x52001ce5},
-        {0x0000a55c, 0x7002708c, 0x7002708c, 0x56001ce9, 0x56001ce9},
+        {0x0000a55c, 0x69024892, 0x69024892, 0x56001ce9, 0x56001ce9},
-        {0x0000a560, 0x7302b08a, 0x7302b08a, 0x5a001ceb, 0x5a001ceb},
+        {0x0000a560, 0x6e024c92, 0x6e024c92, 0x5a001ceb, 0x5a001ceb},
-        {0x0000a564, 0x7702b08c, 0x7702b08c, 0x5d001eec, 0x5d001eec},
+        {0x0000a564, 0x74026e92, 0x74026e92, 0x5d001eec, 0x5d001eec},
-        {0x0000a568, 0x7702b08c, 0x7702b08c, 0x5d001eec, 0x5d001eec},
+        {0x0000a568, 0x74026e92, 0x74026e92, 0x5d001eec, 0x5d001eec},
-        {0x0000a56c, 0x7702b08c, 0x7702b08c, 0x5d001eec, 0x5d001eec},
+        {0x0000a56c, 0x74026e92, 0x74026e92, 0x5d001eec, 0x5d001eec},
-        {0x0000a570, 0x7702b08c, 0x7702b08c, 0x5d001eec, 0x5d001eec},
+        {0x0000a570, 0x74026e92, 0x74026e92, 0x5d001eec, 0x5d001eec},
-        {0x0000a574, 0x7702b08c, 0x7702b08c, 0x5d001eec, 0x5d001eec},
+        {0x0000a574, 0x74026e92, 0x74026e92, 0x5d001eec, 0x5d001eec},
-        {0x0000a578, 0x7702b08c, 0x7702b08c, 0x5d001eec, 0x5d001eec},
+        {0x0000a578, 0x74026e92, 0x74026e92, 0x5d001eec, 0x5d001eec},
-        {0x0000a57c, 0x7702b08c, 0x7702b08c, 0x5d001eec, 0x5d001eec},
+        {0x0000a57c, 0x74026e92, 0x74026e92, 0x5d001eec, 0x5d001eec},
        {0x0000a580, 0x00800000, 0x00800000, 0x00800000, 0x00800000},
        {0x0000a584, 0x06800003, 0x06800003, 0x04800002, 0x04800002},
        {0x0000a588, 0x0a800020, 0x0a800020, 0x08800004, 0x08800004},
@@ -1361,45 +1361,45 @@ static const u32 ar9300Modes_low_ob_db_tx_gain_table_2p2[][5] = {
        {0x0000a5b8, 0x4782244a, 0x4782244a, 0x34800e24, 0x34800e24},
        {0x0000a5bc, 0x4b82244c, 0x4b82244c, 0x38801640, 0x38801640},
        {0x0000a5c0, 0x4e82246c, 0x4e82246c, 0x3c801660, 0x3c801660},
-        {0x0000a5c4, 0x5382266c, 0x5382266c, 0x3f801861, 0x3f801861},
+        {0x0000a5c4, 0x52822470, 0x52822470, 0x3f801861, 0x3f801861},
-        {0x0000a5c8, 0x5782286c, 0x5782286c, 0x43801a81, 0x43801a81},
+        {0x0000a5c8, 0x55822490, 0x55822490, 0x43801a81, 0x43801a81},
-        {0x0000a5cc, 0x5c82486b, 0x5c82486b, 0x47801a83, 0x47801a83},
+        {0x0000a5cc, 0x59822492, 0x59822492, 0x47801a83, 0x47801a83},
-        {0x0000a5d0, 0x61824a6c, 0x61824a6c, 0x4a801c84, 0x4a801c84},
+        {0x0000a5d0, 0x5d822692, 0x5d822692, 0x4a801c84, 0x4a801c84},
-        {0x0000a5d4, 0x66826a6c, 0x66826a6c, 0x4e801ce3, 0x4e801ce3},
+        {0x0000a5d4, 0x61822892, 0x61822892, 0x4e801ce3, 0x4e801ce3},
-        {0x0000a5d8, 0x6b826e6c, 0x6b826e6c, 0x52801ce5, 0x52801ce5},
+        {0x0000a5d8, 0x65824890, 0x65824890, 0x52801ce5, 0x52801ce5},
-        {0x0000a5dc, 0x7082708c, 0x7082708c, 0x56801ce9, 0x56801ce9},
+        {0x0000a5dc, 0x69824892, 0x69824892, 0x56801ce9, 0x56801ce9},
-        {0x0000a5e0, 0x7382b08a, 0x7382b08a, 0x5a801ceb, 0x5a801ceb},
+        {0x0000a5e0, 0x6e824c92, 0x6e824c92, 0x5a801ceb, 0x5a801ceb},
-        {0x0000a5e4, 0x7782b08c, 0x7782b08c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5e4, 0x74826e92, 0x74826e92, 0x5d801eec, 0x5d801eec},
-        {0x0000a5e8, 0x7782b08c, 0x7782b08c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5e8, 0x74826e92, 0x74826e92, 0x5d801eec, 0x5d801eec},
-        {0x0000a5ec, 0x7782b08c, 0x7782b08c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5ec, 0x74826e92, 0x74826e92, 0x5d801eec, 0x5d801eec},
-        {0x0000a5f0, 0x7782b08c, 0x7782b08c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5f0, 0x74826e92, 0x74826e92, 0x5d801eec, 0x5d801eec},
-        {0x0000a5f4, 0x7782b08c, 0x7782b08c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5f4, 0x74826e92, 0x74826e92, 0x5d801eec, 0x5d801eec},
-        {0x0000a5f8, 0x7782b08c, 0x7782b08c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5f8, 0x74826e92, 0x74826e92, 0x5d801eec, 0x5d801eec},
-        {0x0000a5fc, 0x7782b08c, 0x7782b08c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5fc, 0x74826e92, 0x74826e92, 0x5d801eec, 0x5d801eec},
        {0x0000a600, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
        {0x0000a604, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
        {0x0000a608, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
        {0x0000a60c, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
        {0x0000a610, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
-        {0x0000a614, 0x01404000, 0x01404000, 0x01404000, 0x01404000},
+        {0x0000a614, 0x02004000, 0x02004000, 0x01404000, 0x01404000},
-        {0x0000a618, 0x01404501, 0x01404501, 0x01404501, 0x01404501},
+        {0x0000a618, 0x02004801, 0x02004801, 0x01404501, 0x01404501},
-        {0x0000a61c, 0x02008802, 0x02008802, 0x02008501, 0x02008501},
+        {0x0000a61c, 0x02808a02, 0x02808a02, 0x02008501, 0x02008501},
-        {0x0000a620, 0x0300cc03, 0x0300cc03, 0x0280ca03, 0x0280ca03},
+        {0x0000a620, 0x0380ce03, 0x0380ce03, 0x0280ca03, 0x0280ca03},
-        {0x0000a624, 0x0300cc03, 0x0300cc03, 0x03010c04, 0x03010c04},
+        {0x0000a624, 0x04411104, 0x04411104, 0x03010c04, 0x03010c04},
-        {0x0000a628, 0x0300cc03, 0x0300cc03, 0x04014c04, 0x04014c04},
+        {0x0000a628, 0x04411104, 0x04411104, 0x04014c04, 0x04014c04},
-        {0x0000a62c, 0x03810c03, 0x03810c03, 0x04015005, 0x04015005},
+        {0x0000a62c, 0x04411104, 0x04411104, 0x04015005, 0x04015005},
-        {0x0000a630, 0x03810e04, 0x03810e04, 0x04015005, 0x04015005},
+        {0x0000a630, 0x04411104, 0x04411104, 0x04015005, 0x04015005},
-        {0x0000a634, 0x03810e04, 0x03810e04, 0x04015005, 0x04015005},
+        {0x0000a634, 0x04411104, 0x04411104, 0x04015005, 0x04015005},
-        {0x0000a638, 0x03810e04, 0x03810e04, 0x04015005, 0x04015005},
+        {0x0000a638, 0x04411104, 0x04411104, 0x04015005, 0x04015005},
-        {0x0000a63c, 0x03810e04, 0x03810e04, 0x04015005, 0x04015005},
+        {0x0000a63c, 0x04411104, 0x04411104, 0x04015005, 0x04015005},
-        {0x0000b2dc, 0x0380c7fc, 0x0380c7fc, 0x00637800, 0x00637800},
+        {0x0000b2dc, 0x00033800, 0x00033800, 0x03aaa352, 0x03aaa352},
-        {0x0000b2e0, 0x0000f800, 0x0000f800, 0x03838000, 0x03838000},
+        {0x0000b2e0, 0x0003c000, 0x0003c000, 0x03ccc584, 0x03ccc584},
-        {0x0000b2e4, 0x03ff0000, 0x03ff0000, 0x03fc0000, 0x03fc0000},
+        {0x0000b2e4, 0x03fc0000, 0x03fc0000, 0x03f0f800, 0x03f0f800},
-        {0x0000b2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000b2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
-        {0x0000c2dc, 0x0380c7fc, 0x0380c7fc, 0x00637800, 0x00637800},
+        {0x0000c2dc, 0x00033800, 0x00033800, 0x03aaa352, 0x03aaa352},
-        {0x0000c2e0, 0x0000f800, 0x0000f800, 0x03838000, 0x03838000},
+        {0x0000c2e0, 0x0003c000, 0x0003c000, 0x03ccc584, 0x03ccc584},
-        {0x0000c2e4, 0x03ff0000, 0x03ff0000, 0x03fc0000, 0x03fc0000},
+        {0x0000c2e4, 0x03fc0000, 0x03fc0000, 0x03f0f800, 0x03f0f800},
-        {0x0000c2e8, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000c2e8, 0x00000000, 0x00000000, 0x03ff0000, 0x03ff0000},
        {0x00016044, 0x012492d4, 0x012492d4, 0x012492d4, 0x012492d4},
        {0x00016048, 0x66480001, 0x66480001, 0x66480001, 0x66480001},
        {0x00016068, 0x6db6db6c, 0x6db6db6c, 0x6db6db6c, 0x6db6db6c},
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_calib.c b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
index 4a4cd88429c0..f276cb922b4d 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_calib.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
@@ -18,13 +18,13 @@
 #include "hw-ops.h"
 #include "ar9003_phy.h"
-#define MPASS   3
 #define MAX_MEASUREMENT 8
-#define MAX_DIFFERENCE  10
+#define MAX_MAG_DELTA   11
+#define MAX_PHS_DELTA   10
 struct coeff {
-        int mag_coeff[AR9300_MAX_CHAINS][MAX_MEASUREMENT][MPASS];
+        int mag_coeff[AR9300_MAX_CHAINS][MAX_MEASUREMENT];
-        int phs_coeff[AR9300_MAX_CHAINS][MAX_MEASUREMENT][MPASS];
+        int phs_coeff[AR9300_MAX_CHAINS][MAX_MEASUREMENT];
        int iqc_coeff[2];
 };
@@ -185,17 +185,19 @@ static void ar9003_hw_iqcal_collect(struct ath_hw *ah)
        /* Accumulate IQ cal measures for active chains */
        for (i = 0; i < AR5416_MAX_CHAINS; i++) {
-                ah->totalPowerMeasI[i] +=
+                if (ah->txchainmask & BIT(i)) {
-                        REG_READ(ah, AR_PHY_CAL_MEAS_0(i));
+                        ah->totalPowerMeasI[i] +=
-                ah->totalPowerMeasQ[i] +=
+                                REG_READ(ah, AR_PHY_CAL_MEAS_0(i));
-                        REG_READ(ah, AR_PHY_CAL_MEAS_1(i));
+                        ah->totalPowerMeasQ[i] +=
-                ah->totalIqCorrMeas[i] +=
+                                REG_READ(ah, AR_PHY_CAL_MEAS_1(i));
-                        (int32_t) REG_READ(ah, AR_PHY_CAL_MEAS_2(i));
+                        ah->totalIqCorrMeas[i] +=
-                ath_dbg(ath9k_hw_common(ah), ATH_DBG_CALIBRATE,
+                                (int32_t) REG_READ(ah, AR_PHY_CAL_MEAS_2(i));
-                        "%d: Chn %d pmi=0x%08x;pmq=0x%08x;iqcm=0x%08x;\n",
+                        ath_dbg(ath9k_hw_common(ah), ATH_DBG_CALIBRATE,
-                        ah->cal_samples, i, ah->totalPowerMeasI[i],
+                                "%d: Chn %d pmi=0x%08x;pmq=0x%08x;iqcm=0x%08x;\n",
-                        ah->totalPowerMeasQ[i],
+                                ah->cal_samples, i, ah->totalPowerMeasI[i],
-                        ah->totalIqCorrMeas[i]);
+                                ah->totalPowerMeasQ[i],
+                                ah->totalIqCorrMeas[i]);
+                }
        }
 }
@@ -608,36 +610,48 @@ static bool ar9003_hw_calc_iq_corr(struct ath_hw *ah,
        return true;
 }
-static bool ar9003_hw_compute_closest_pass_and_avg(int *mp_coeff, int *mp_avg)
+static void ar9003_hw_detect_outlier(int *mp_coeff, int nmeasurement,
+                                     int max_delta)
 {
-        int diff[MPASS];
+        int mp_max = -64, max_idx = 0;
+        int mp_min = 63, min_idx = 0;
-        diff[0] = abs(mp_coeff[0] - mp_coeff[1]);
+        int mp_avg = 0, i, outlier_idx = 0;
-        diff[1] = abs(mp_coeff[1] - mp_coeff[2]);
-        diff[2] = abs(mp_coeff[2] - mp_coeff[0]);
+        /* find min/max mismatch across all calibrated gains */
+        for (i = 0; i < nmeasurement; i++) {
-        if (diff[0] > MAX_DIFFERENCE &&
+                mp_avg += mp_coeff[i];
-            diff[1] > MAX_DIFFERENCE &&
+                if (mp_coeff[i] > mp_max) {
-            diff[2] > MAX_DIFFERENCE)
+                        mp_max = mp_coeff[i];
-                return false;
+                        max_idx = i;
+                } else if (mp_coeff[i] < mp_min) {
+                        mp_min = mp_coeff[i];
+                        min_idx = i;
+                }
+        }
-        if (diff[0] <= diff[1] && diff[0] <= diff[2])
+        /* find average (exclude max abs value) */
-                *mp_avg = (mp_coeff[0] + mp_coeff[1]) / 2;
+        for (i = 0; i < nmeasurement; i++) {
-        else if (diff[1] <= diff[2])
+                if ((abs(mp_coeff[i]) < abs(mp_max)) ||
-                *mp_avg = (mp_coeff[1] + mp_coeff[2]) / 2;
+                    (abs(mp_coeff[i]) < abs(mp_min)))
-        else
+                        mp_avg += mp_coeff[i];
-                *mp_avg = (mp_coeff[2] + mp_coeff[0]) / 2;
+        }
+        mp_avg /= (nmeasurement - 1);
-        return true;
+        /* detect outlier */
+        if (abs(mp_max - mp_min) > max_delta) {
+                if (abs(mp_max - mp_avg) > abs(mp_min - mp_avg))
+                        outlier_idx = max_idx;
+                else
+                        outlier_idx = min_idx;
+        }
+        mp_coeff[outlier_idx] = mp_avg;
 }
 static void ar9003_hw_tx_iqcal_load_avg_2_passes(struct ath_hw *ah,
                                                 u8 num_chains,
                                                 struct coeff *coeff)
 {
-        struct ath_common *common = ath9k_hw_common(ah);
        int i, im, nmeasurement;
-        int magnitude, phase;
        u32 tx_corr_coeff[MAX_MEASUREMENT][AR9300_MAX_CHAINS];
        memset(tx_corr_coeff, 0, sizeof(tx_corr_coeff));
@@ -657,37 +671,28 @@ static void ar9003_hw_tx_iqcal_load_avg_2_passes(struct ath_hw *ah,
        /* Load the average of 2 passes */
        for (i = 0; i < num_chains; i++) {
-                if (AR_SREV_9485(ah))
+                nmeasurement = REG_READ_FIELD(ah,
-                        nmeasurement = REG_READ_FIELD(ah,
+                                AR_PHY_TX_IQCAL_STATUS_B0,
-                                        AR_PHY_TX_IQCAL_STATUS_B0_9485,
+                                AR_PHY_CALIBRATED_GAINS_0);
-                                        AR_PHY_CALIBRATED_GAINS_0);
-                else
-                        nmeasurement = REG_READ_FIELD(ah,
-                                        AR_PHY_TX_IQCAL_STATUS_B0,
-                                        AR_PHY_CALIBRATED_GAINS_0);
                if (nmeasurement > MAX_MEASUREMENT)
                        nmeasurement = MAX_MEASUREMENT;
-                for (im = 0; im < nmeasurement; im++) {
+                /* detect outlier only if nmeasurement > 1 */
-                        /*
+                if (nmeasurement > 1) {
-                         * Determine which 2 passes are closest and compute avg
+                        /* Detect magnitude outlier */
-                         * magnitude
+                        ar9003_hw_detect_outlier(coeff->mag_coeff[i],
-                         */
+                                        nmeasurement, MAX_MAG_DELTA);
-                        if (!ar9003_hw_compute_closest_pass_and_avg(coeff->mag_coeff[i][im],
-                                                                    &magnitude))
-                                goto disable_txiqcal;
-                        /*
+                        /* Detect phase outlier */
-                         * Determine which 2 passes are closest and compute avg
+                        ar9003_hw_detect_outlier(coeff->phs_coeff[i],
-                         * phase
+                                        nmeasurement, MAX_PHS_DELTA);
-                         */
+                }
-                        if (!ar9003_hw_compute_closest_pass_and_avg(coeff->phs_coeff[i][im],
-                                                                    &phase))
+                for (im = 0; im < nmeasurement; im++) {
-                                goto disable_txiqcal;
-                        coeff->iqc_coeff[0] = (magnitude & 0x7f) |
+                        coeff->iqc_coeff[0] = (coeff->mag_coeff[i][im] & 0x7f) |
-                                              ((phase & 0x7f) << 7);
+                                ((coeff->phs_coeff[i][im] & 0x7f) << 7);
                        if ((im % 2) == 0)
                                REG_RMW_FIELD(ah, tx_corr_coeff[im][i],
@@ -707,141 +712,37 @@ static void ar9003_hw_tx_iqcal_load_avg_2_passes(struct ath_hw *ah,
        return;
-disable_txiqcal:
-        REG_RMW_FIELD(ah, AR_PHY_TX_IQCAL_CONTROL_3,
-                      AR_PHY_TX_IQCAL_CONTROL_3_IQCORR_EN, 0x0);
-        REG_RMW_FIELD(ah, AR_PHY_RX_IQCAL_CORR_B0,
-                      AR_PHY_RX_IQCAL_CORR_B0_LOOPBACK_IQCORR_EN, 0x0);
-        ath_dbg(common, ATH_DBG_CALIBRATE, "TX IQ Cal disabled\n");
 }
-static void ar9003_hw_tx_iq_cal(struct ath_hw *ah)
+static bool ar9003_hw_tx_iq_cal_run(struct ath_hw *ah)
 {
        struct ath_common *common = ath9k_hw_common(ah);
-        static const u32 txiqcal_status[AR9300_MAX_CHAINS] = {
-                AR_PHY_TX_IQCAL_STATUS_B0,
-                AR_PHY_TX_IQCAL_STATUS_B1,
-                AR_PHY_TX_IQCAL_STATUS_B2,
-        };
-        static const u32 chan_info_tab[] = {
-                AR_PHY_CHAN_INFO_TAB_0,
-                AR_PHY_CHAN_INFO_TAB_1,
-                AR_PHY_CHAN_INFO_TAB_2,
-        };
-        struct coeff coeff;
-        s32 iq_res[6];
-        s32 i, j, ip, im, nmeasurement;
-        u8 nchains = get_streams(common->tx_chainmask);
-        for (ip = 0; ip < MPASS; ip++) {
-                REG_RMW_FIELD(ah, AR_PHY_TX_IQCAL_CONTROL_1,
-                              AR_PHY_TX_IQCAQL_CONTROL_1_IQCORR_I_Q_COFF_DELPT,
-                              DELPT);
-                REG_RMW_FIELD(ah, AR_PHY_TX_IQCAL_START,
-                              AR_PHY_TX_IQCAL_START_DO_CAL,
-                              AR_PHY_TX_IQCAL_START_DO_CAL);
-                if (!ath9k_hw_wait(ah, AR_PHY_TX_IQCAL_START,
-                                   AR_PHY_TX_IQCAL_START_DO_CAL,
-                                   0, AH_WAIT_TIMEOUT)) {
-                        ath_dbg(common, ATH_DBG_CALIBRATE,
-                                "Tx IQ Cal not complete.\n");
-                        goto TX_IQ_CAL_FAILED;
-                }
-                nmeasurement = REG_READ_FIELD(ah, AR_PHY_TX_IQCAL_STATUS_B0,
-                                              AR_PHY_CALIBRATED_GAINS_0);
-                        if (nmeasurement > MAX_MEASUREMENT)
-                                nmeasurement = MAX_MEASUREMENT;
-                for (i = 0; i < nchains; i++) {
-                        ath_dbg(common, ATH_DBG_CALIBRATE,
-                                "Doing Tx IQ Cal for chain %d.\n", i);
-                        for (im = 0; im < nmeasurement; im++) {
-                                if (REG_READ(ah, txiqcal_status[i]) &
-                                             AR_PHY_TX_IQCAL_STATUS_FAILED) {
-                                        ath_dbg(common, ATH_DBG_CALIBRATE,
-                                                "Tx IQ Cal failed for chain %d.\n", i);
-                                        goto TX_IQ_CAL_FAILED;
-                                }
-                                for (j = 0; j < 3; j++) {
-                                        u8 idx = 2 * j,
-                                           offset = 4 * (3 * im + j);
-                                        REG_RMW_FIELD(ah, AR_PHY_CHAN_INFO_MEMORY,
-                                                      AR_PHY_CHAN_INFO_TAB_S2_READ,
-                                                      0);
-                                        /* 32 bits */
-                                        iq_res[idx] = REG_READ(ah,
-                                                        chan_info_tab[i] +
-                                                        offset);
-                                        REG_RMW_FIELD(ah, AR_PHY_CHAN_INFO_MEMORY,
-                                                      AR_PHY_CHAN_INFO_TAB_S2_READ,
-                                                      1);
-                                        /* 16 bits */
-                                        iq_res[idx+1] = 0xffff & REG_READ(ah,
-                                                                chan_info_tab[i] +
-                                                                offset);
-                                        ath_dbg(common, ATH_DBG_CALIBRATE,
-                                                "IQ RES[%d]=0x%x IQ_RES[%d]=0x%x\n",
-                                                idx, iq_res[idx], idx+1, iq_res[idx+1]);
-                                }
-                                if (!ar9003_hw_calc_iq_corr(ah, i, iq_res,
-                                                            coeff.iqc_coeff)) {
-                                        ath_dbg(common, ATH_DBG_CALIBRATE,
-                                                "Failed in calculation of IQ correction.\n");
-                                        goto TX_IQ_CAL_FAILED;
-                                }
-                                coeff.mag_coeff[i][im][ip] =
-                                                coeff.iqc_coeff[0] & 0x7f;
-                                coeff.phs_coeff[i][im][ip] =
-                                                (coeff.iqc_coeff[0] >> 7) & 0x7f;
-                                if (coeff.mag_coeff[i][im][ip] > 63)
-                                        coeff.mag_coeff[i][im][ip] -= 128;
-                                if (coeff.phs_coeff[i][im][ip] > 63)
-                                        coeff.phs_coeff[i][im][ip] -= 128;
-                        }
-                }
-        }
-        ar9003_hw_tx_iqcal_load_avg_2_passes(ah, nchains, &coeff);
-        return;
-TX_IQ_CAL_FAILED:
-        ath_dbg(common, ATH_DBG_CALIBRATE, "Tx IQ Cal failed\n");
-}
-static void ar9003_hw_tx_iq_cal_run(struct ath_hw *ah)
-{
        u8 tx_gain_forced;
-        REG_RMW_FIELD(ah, AR_PHY_TX_IQCAL_CONTROL_1_9485,
-                      AR_PHY_TX_IQCAQL_CONTROL_1_IQCORR_I_Q_COFF_DELPT, DELPT);
        tx_gain_forced = REG_READ_FIELD(ah, AR_PHY_TX_FORCED_GAIN,
                                        AR_PHY_TXGAIN_FORCE);
        if (tx_gain_forced)
                REG_RMW_FIELD(ah, AR_PHY_TX_FORCED_GAIN,
                              AR_PHY_TXGAIN_FORCE, 0);
-        REG_RMW_FIELD(ah, AR_PHY_TX_IQCAL_START_9485,
+        REG_RMW_FIELD(ah, AR_PHY_TX_IQCAL_START,
-                      AR_PHY_TX_IQCAL_START_DO_CAL_9485, 1);
+                      AR_PHY_TX_IQCAL_START_DO_CAL, 1);
+        if (!ath9k_hw_wait(ah, AR_PHY_TX_IQCAL_START,
+                        AR_PHY_TX_IQCAL_START_DO_CAL, 0,
+                        AH_WAIT_TIMEOUT)) {
+                ath_dbg(common, ATH_DBG_CALIBRATE,
+                        "Tx IQ Cal is not completed.\n");
+                return false;
+        }
+        return true;
 }
 static void ar9003_hw_tx_iq_cal_post_proc(struct ath_hw *ah)
 {
        struct ath_common *common = ath9k_hw_common(ah);
        const u32 txiqcal_status[AR9300_MAX_CHAINS] = {
-                AR_PHY_TX_IQCAL_STATUS_B0_9485,
+                AR_PHY_TX_IQCAL_STATUS_B0,
                AR_PHY_TX_IQCAL_STATUS_B1,
                AR_PHY_TX_IQCAL_STATUS_B2,
        };
@@ -853,7 +754,7 @@ static void ar9003_hw_tx_iq_cal_post_proc(struct ath_hw *ah)
        struct coeff coeff;
        s32 iq_res[6];
        u8 num_chains = 0;
-        int i, ip, im, j;
+        int i, im, j;
        int nmeasurement;
        for (i = 0; i < AR9300_MAX_CHAINS; i++) {
@@ -861,71 +762,69 @@ static void ar9003_hw_tx_iq_cal_post_proc(struct ath_hw *ah)
                        num_chains++;
        }
-        for (ip = 0; ip < MPASS; ip++) {
+        for (i = 0; i < num_chains; i++) {
-                for (i = 0; i < num_chains; i++) {
+                nmeasurement = REG_READ_FIELD(ah,
-                        nmeasurement = REG_READ_FIELD(ah,
+                                AR_PHY_TX_IQCAL_STATUS_B0,
-                                        AR_PHY_TX_IQCAL_STATUS_B0_9485,
+                                AR_PHY_CALIBRATED_GAINS_0);
-                                        AR_PHY_CALIBRATED_GAINS_0);
+                if (nmeasurement > MAX_MEASUREMENT)
-                        if (nmeasurement > MAX_MEASUREMENT)
+                        nmeasurement = MAX_MEASUREMENT;
-                                nmeasurement = MAX_MEASUREMENT;
-                        for (im = 0; im < nmeasurement; im++) {
+                for (im = 0; im < nmeasurement; im++) {
-                                ath_dbg(common, ATH_DBG_CALIBRATE,
+                        ath_dbg(common, ATH_DBG_CALIBRATE,
-                                        "Doing Tx IQ Cal for chain %d.\n", i);
+                                "Doing Tx IQ Cal for chain %d.\n", i);
-                                if (REG_READ(ah, txiqcal_status[i]) &
+                        if (REG_READ(ah, txiqcal_status[i]) &
-                                    AR_PHY_TX_IQCAL_STATUS_FAILED) {
+                                        AR_PHY_TX_IQCAL_STATUS_FAILED) {
-                                        ath_dbg(common, ATH_DBG_CALIBRATE,
+                                ath_dbg(common, ATH_DBG_CALIBRATE,
                                        "Tx IQ Cal failed for chain %d.\n", i);
-                                        goto tx_iqcal_fail;
+                                goto tx_iqcal_fail;
-                                }
+                        }
-                                for (j = 0; j < 3; j++) {
+                        for (j = 0; j < 3; j++) {
-                                        u32 idx = 2 * j, offset = 4 * (3 * im + j);
+                                u32 idx = 2 * j, offset = 4 * (3 * im + j);
-                                        REG_RMW_FIELD(ah,
+                                REG_RMW_FIELD(ah,
                                                AR_PHY_CHAN_INFO_MEMORY,
                                                AR_PHY_CHAN_INFO_TAB_S2_READ,
                                                0);
-                                        /* 32 bits */
+                                /* 32 bits */
-                                        iq_res[idx] = REG_READ(ah,
+                                iq_res[idx] = REG_READ(ah,
-                                                        chan_info_tab[i] +
+                                                chan_info_tab[i] +
-                                                        offset);
+                                                offset);
-                                        REG_RMW_FIELD(ah,
+                                REG_RMW_FIELD(ah,
                                                AR_PHY_CHAN_INFO_MEMORY,
                                                AR_PHY_CHAN_INFO_TAB_S2_READ,
                                                1);
-                                        /* 16 bits */
+                                /* 16 bits */
-                                        iq_res[idx + 1] = 0xffff & REG_READ(ah,
+                                iq_res[idx + 1] = 0xffff & REG_READ(ah,
-                                                          chan_info_tab[i] + offset);
+                                                chan_info_tab[i] + offset);
-                                        ath_dbg(common, ATH_DBG_CALIBRATE,
+                                ath_dbg(common, ATH_DBG_CALIBRATE,
-                                                "IQ RES[%d]=0x%x"
+                                        "IQ RES[%d]=0x%x"
-                                                "IQ_RES[%d]=0x%x\n",
+                                        "IQ_RES[%d]=0x%x\n",
-                                                idx, iq_res[idx], idx + 1,
+                                        idx, iq_res[idx], idx + 1,
-                                                iq_res[idx + 1]);
+                                        iq_res[idx + 1]);
-                                }
+                        }
-                                if (!ar9003_hw_calc_iq_corr(ah, i, iq_res,
+                        if (!ar9003_hw_calc_iq_corr(ah, i, iq_res,
-                                                            coeff.iqc_coeff)) {
+                                                coeff.iqc_coeff)) {
-                                        ath_dbg(common, ATH_DBG_CALIBRATE,
+                                ath_dbg(common, ATH_DBG_CALIBRATE,
-                                         "Failed in calculation of IQ correction.\n");
+                                        "Failed in calculation of \
-                                        goto tx_iqcal_fail;
+                                        IQ correction.\n");
-                                }
+                                goto tx_iqcal_fail;
+                        }
-                                coeff.mag_coeff[i][im][ip] =
+                        coeff.mag_coeff[i][im] = coeff.iqc_coeff[0] & 0x7f;
-                                                coeff.iqc_coeff[0] & 0x7f;
+                        coeff.phs_coeff[i][im] =
-                                coeff.phs_coeff[i][im][ip] =
+                                (coeff.iqc_coeff[0] >> 7) & 0x7f;
-                                                (coeff.iqc_coeff[0] >> 7) & 0x7f;
-                                if (coeff.mag_coeff[i][im][ip] > 63)
+                        if (coeff.mag_coeff[i][im] > 63)
-                                        coeff.mag_coeff[i][im][ip] -= 128;
+                                coeff.mag_coeff[i][im] -= 128;
-                                if (coeff.phs_coeff[i][im][ip] > 63)
+                        if (coeff.phs_coeff[i][im] > 63)
-                                        coeff.phs_coeff[i][im][ip] -= 128;
+                                coeff.phs_coeff[i][im] -= 128;
-                        }
                }
        }
        ar9003_hw_tx_iqcal_load_avg_2_passes(ah, num_chains, &coeff);
@@ -940,31 +839,37 @@ static bool ar9003_hw_init_cal(struct ath_hw *ah,
                               struct ath9k_channel *chan)
 {
        struct ath_common *common = ath9k_hw_common(ah);
+        struct ath9k_hw_capabilities *pCap = &ah->caps;
        int val;
+        bool txiqcal_done = false;
        val = REG_READ(ah, AR_ENT_OTP);
        ath_dbg(common, ATH_DBG_CALIBRATE, "ath9k: AR_ENT_OTP 0x%x\n", val);
-        if (AR_SREV_9485(ah))
+        /* Configure rx/tx chains before running AGC/TxiQ cals */
-                ar9003_hw_set_chain_masks(ah, 0x1, 0x1);
+        if (val & AR_ENT_OTP_CHAIN2_DISABLE)
-        else if (val & AR_ENT_OTP_CHAIN2_DISABLE)
                ar9003_hw_set_chain_masks(ah, 0x3, 0x3);
        else
-                /*
+                ar9003_hw_set_chain_masks(ah, pCap->rx_chainmask,
-                 * 0x7 = 0b111 , AR9003 needs to be configured for 3-chain
+                                          pCap->tx_chainmask);
-                 * mode before running AGC/TxIQ cals
-                 */
-                ar9003_hw_set_chain_masks(ah, 0x7, 0x7);
        /* Do Tx IQ Calibration */
-        if (AR_SREV_9485(ah))
+        REG_RMW_FIELD(ah, AR_PHY_TX_IQCAL_CONTROL_1,
-                ar9003_hw_tx_iq_cal_run(ah);
+                      AR_PHY_TX_IQCAL_CONTROL_1_IQCORR_I_Q_COFF_DELPT,
-        else
+                      DELPT);
-                ar9003_hw_tx_iq_cal(ah);
-        REG_WRITE(ah, AR_PHY_ACTIVE, AR_PHY_ACTIVE_DIS);
+        /*
-        udelay(5);
+         * For AR9485 or later chips, TxIQ cal runs as part of
-        REG_WRITE(ah, AR_PHY_ACTIVE, AR_PHY_ACTIVE_EN);
+         * AGC calibration
+         */
+        if (AR_SREV_9485_OR_LATER(ah))
+                txiqcal_done = true;
+        else {
+                txiqcal_done = ar9003_hw_tx_iq_cal_run(ah);
+                REG_WRITE(ah, AR_PHY_ACTIVE, AR_PHY_ACTIVE_DIS);
+                udelay(5);
+                REG_WRITE(ah, AR_PHY_ACTIVE, AR_PHY_ACTIVE_EN);
+        }
        /* Calibrate the AGC */
        REG_WRITE(ah, AR_PHY_AGC_CONTROL,
@@ -979,7 +884,7 @@ static bool ar9003_hw_init_cal(struct ath_hw *ah,
                return false;
        }
-        if (AR_SREV_9485(ah))
+        if (txiqcal_done)
                ar9003_hw_tx_iq_cal_post_proc(ah);
        /* Revert chainmasks to their original values before NF cal */
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
index 6eadf975ae48..1e220354e4be 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
@@ -652,7 +652,7 @@ static const struct ar9300_eeprom ar9300_x113 = {
                .regDmn = { LE16(0), LE16(0x1f) },
                .txrxMask =  0x77, /* 4 bits tx and 4 bits rx */
                .opCapFlags = {
-                        .opFlags = AR5416_OPFLAGS_11G | AR5416_OPFLAGS_11A,
+                        .opFlags = AR5416_OPFLAGS_11A,
                        .eepMisc = 0,
                },
                .rfSilent = 0,
@@ -922,7 +922,7 @@ static const struct ar9300_eeprom ar9300_x113 = {
                .db_stage2 = {3, 3, 3}, /* 3 chain */
                .db_stage3 = {3, 3, 3}, /* doesn't exist for 2G */
                .db_stage4 = {3, 3, 3},  /* don't exist for 2G */
-                .xpaBiasLvl = 0,
+                .xpaBiasLvl = 0xf,
                .txFrameToDataStart = 0x0e,
                .txFrameToPaOn = 0x0e,
                .txClip = 3, /* 4 bits tx_clip, 4 bits dac_scale_cck */
@@ -3217,7 +3217,6 @@ static int ar9300_compress_decision(struct ath_hw *ah,
                                    u8 *word, int length, int mdata_size)
 {
        struct ath_common *common = ath9k_hw_common(ah);
-        u8 *dptr;
        const struct ar9300_eeprom *eep = NULL;
        switch (code) {
@@ -3235,7 +3234,6 @@ static int ar9300_compress_decision(struct ath_hw *ah,
                break;
        case _CompressBlock:
                if (reference == 0) {
-                        dptr = mptr;
                } else {
                        eep = ar9003_eeprom_struct_find_by_id(reference);
                        if (eep == NULL) {
@@ -3444,13 +3442,15 @@ static void ar9003_hw_xpa_bias_level_apply(struct ath_hw *ah, bool is2ghz)
 {
        int bias = ar9003_hw_xpa_bias_level_get(ah, is2ghz);
-        if (AR_SREV_9485(ah))
+        if (AR_SREV_9485(ah) || AR_SREV_9340(ah))
                REG_RMW_FIELD(ah, AR_CH0_TOP2, AR_CH0_TOP2_XPABIASLVL, bias);
        else {
                REG_RMW_FIELD(ah, AR_CH0_TOP, AR_CH0_TOP_XPABIASLVL, bias);
-                REG_RMW_FIELD(ah, AR_CH0_THERM, AR_CH0_THERM_XPABIASLVL_MSB,
+                REG_RMW_FIELD(ah, AR_CH0_THERM,
-                              bias >> 2);
+                                AR_CH0_THERM_XPABIASLVL_MSB,
-                REG_RMW_FIELD(ah, AR_CH0_THERM, AR_CH0_THERM_XPASHORT2GND, 1);
+                                bias >> 2);
+                REG_RMW_FIELD(ah, AR_CH0_THERM,
+                                AR_CH0_THERM_XPASHORT2GND, 1);
        }
 }
@@ -3497,34 +3497,77 @@ static u16 ar9003_hw_ant_ctrl_chain_get(struct ath_hw *ah,
 static void ar9003_hw_ant_ctrl_apply(struct ath_hw *ah, bool is2ghz)
 {
+        int chain;
+        u32 regval;
+        u32 ant_div_ctl1;
+        static const u32 switch_chain_reg[AR9300_MAX_CHAINS] = {
+                        AR_PHY_SWITCH_CHAIN_0,
+                        AR_PHY_SWITCH_CHAIN_1,
+                        AR_PHY_SWITCH_CHAIN_2,
+        };
        u32 value = ar9003_hw_ant_ctrl_common_get(ah, is2ghz);
        REG_RMW_FIELD(ah, AR_PHY_SWITCH_COM, AR_SWITCH_TABLE_COM_ALL, value);
        value = ar9003_hw_ant_ctrl_common_2_get(ah, is2ghz);
        REG_RMW_FIELD(ah, AR_PHY_SWITCH_COM_2, AR_SWITCH_TABLE_COM2_ALL, value);
-        value = ar9003_hw_ant_ctrl_chain_get(ah, 0, is2ghz);
+        for (chain = 0; chain < AR9300_MAX_CHAINS; chain++) {
-        REG_RMW_FIELD(ah, AR_PHY_SWITCH_CHAIN_0, AR_SWITCH_TABLE_ALL, value);
+                if ((ah->rxchainmask & BIT(chain)) ||
+                    (ah->txchainmask & BIT(chain))) {
-        if (!AR_SREV_9485(ah)) {
+                        value = ar9003_hw_ant_ctrl_chain_get(ah, chain,
-                value = ar9003_hw_ant_ctrl_chain_get(ah, 1, is2ghz);
+                                                             is2ghz);
-                REG_RMW_FIELD(ah, AR_PHY_SWITCH_CHAIN_1, AR_SWITCH_TABLE_ALL,
+                        REG_RMW_FIELD(ah, switch_chain_reg[chain],
-                              value);
+                                      AR_SWITCH_TABLE_ALL, value);
+                }
-                value = ar9003_hw_ant_ctrl_chain_get(ah, 2, is2ghz);
-                REG_RMW_FIELD(ah, AR_PHY_SWITCH_CHAIN_2, AR_SWITCH_TABLE_ALL,
-                              value);
        }
        if (AR_SREV_9485(ah)) {
                value = ath9k_hw_ar9300_get_eeprom(ah, EEP_ANT_DIV_CTL1);
-                REG_RMW_FIELD(ah, AR_PHY_MC_GAIN_CTRL, AR_ANT_DIV_CTRL_ALL,
+                /*
-                              value);
+                 * main_lnaconf, alt_lnaconf, main_tb, alt_tb
-                REG_RMW_FIELD(ah, AR_PHY_MC_GAIN_CTRL, AR_ANT_DIV_ENABLE,
+                 * are the fields present
-                              value >> 6);
+                 */
-                REG_RMW_FIELD(ah, AR_PHY_CCK_DETECT, AR_FAST_DIV_ENABLE,
+                regval = REG_READ(ah, AR_PHY_MC_GAIN_CTRL);
-                              value >> 7);
+                regval &= (~AR_ANT_DIV_CTRL_ALL);
+                regval |= (value & 0x3f) << AR_ANT_DIV_CTRL_ALL_S;
+                /* enable_lnadiv */
+                regval &= (~AR_PHY_9485_ANT_DIV_LNADIV);
+                regval |= ((value >> 6) & 0x1) <<
+                                AR_PHY_9485_ANT_DIV_LNADIV_S;
+                REG_WRITE(ah, AR_PHY_MC_GAIN_CTRL, regval);
+                /*enable fast_div */
+                regval = REG_READ(ah, AR_PHY_CCK_DETECT);
+                regval &= (~AR_FAST_DIV_ENABLE);
+                regval |= ((value >> 7) & 0x1) <<
+                                AR_FAST_DIV_ENABLE_S;
+                REG_WRITE(ah, AR_PHY_CCK_DETECT, regval);
+                ant_div_ctl1 =
+                        ah->eep_ops->get_eeprom(ah, EEP_ANT_DIV_CTL1);
+                /* check whether antenna diversity is enabled */
+                if ((ant_div_ctl1 >> 0x6) == 0x3) {
+                        regval = REG_READ(ah, AR_PHY_MC_GAIN_CTRL);
+                        /*
+                         * clear bits 25-30 main_lnaconf, alt_lnaconf,
+                         * main_tb, alt_tb
+                         */
+                        regval &= (~(AR_PHY_9485_ANT_DIV_MAIN_LNACONF |
+                                        AR_PHY_9485_ANT_DIV_ALT_LNACONF |
+                                        AR_PHY_9485_ANT_DIV_ALT_GAINTB |
+                                        AR_PHY_9485_ANT_DIV_MAIN_GAINTB));
+                        /* by default use LNA1 for the main antenna */
+                        regval |= (AR_PHY_9485_ANT_DIV_LNA1 <<
+                                        AR_PHY_9485_ANT_DIV_MAIN_LNACONF_S);
+                        regval |= (AR_PHY_9485_ANT_DIV_LNA2 <<
+                                        AR_PHY_9485_ANT_DIV_ALT_LNACONF_S);
+                        REG_WRITE(ah, AR_PHY_MC_GAIN_CTRL, regval);
+                }
        }
 }
 static void ar9003_hw_drive_strength_apply(struct ath_hw *ah)
@@ -3634,13 +3677,16 @@ static void ar9003_hw_atten_apply(struct ath_hw *ah, struct ath9k_channel *chan)
        /* Test value. if 0 then attenuation is unused. Don't load anything. */
        for (i = 0; i < 3; i++) {
-                value = ar9003_hw_atten_chain_get(ah, i, chan);
+                if (ah->txchainmask & BIT(i)) {
-                REG_RMW_FIELD(ah, ext_atten_reg[i],
+                        value = ar9003_hw_atten_chain_get(ah, i, chan);
-                              AR_PHY_EXT_ATTEN_CTL_XATTEN1_DB, value);
+                        REG_RMW_FIELD(ah, ext_atten_reg[i],
+                                      AR_PHY_EXT_ATTEN_CTL_XATTEN1_DB, value);
-                value = ar9003_hw_atten_chain_get_margin(ah, i, chan);
-                REG_RMW_FIELD(ah, ext_atten_reg[i],
+                        value = ar9003_hw_atten_chain_get_margin(ah, i, chan);
-                              AR_PHY_EXT_ATTEN_CTL_XATTEN1_MARGIN, value);
+                        REG_RMW_FIELD(ah, ext_atten_reg[i],
+                                      AR_PHY_EXT_ATTEN_CTL_XATTEN1_MARGIN,
+                                      value);
+                }
        }
 }
@@ -3749,8 +3795,9 @@ static void ath9k_hw_ar9300_set_board_values(struct ath_hw *ah,
        ar9003_hw_ant_ctrl_apply(ah, IS_CHAN_2GHZ(chan));
        ar9003_hw_drive_strength_apply(ah);
        ar9003_hw_atten_apply(ah, chan);
-        ar9003_hw_internal_regulator_apply(ah);
+        if (!AR_SREV_9340(ah))
-        if (AR_SREV_9485(ah))
+                ar9003_hw_internal_regulator_apply(ah);
+        if (AR_SREV_9485(ah) || AR_SREV_9340(ah))
                ar9003_hw_apply_tuning_caps(ah);
 }
@@ -3994,6 +4041,16 @@ static int ar9003_hw_tx_power_regwrite(struct ath_hw *ah, u8 * pPwrArray)
                  POW_SM(pPwrArray[ALL_TARGET_LEGACY_1L_5L], 0)
            );
+        /* Write the power for duplicated frames - HT40 */
+        /* dup40_cck (LSB), dup40_ofdm, ext20_cck, ext20_ofdm (MSB) */
+        REG_WRITE(ah, 0xa3e0,
+                  POW_SM(pPwrArray[ALL_TARGET_LEGACY_6_24], 24) |
+                  POW_SM(pPwrArray[ALL_TARGET_LEGACY_1L_5L], 16) |
+                  POW_SM(pPwrArray[ALL_TARGET_LEGACY_6_24],  8) |
+                  POW_SM(pPwrArray[ALL_TARGET_LEGACY_1L_5L],  0)
+            );
        /* Write the HT20 power per rate set */
        /* 0/8/16 (LSB), 1-3/9-11/17-19, 4, 5 (MSB) */
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_hw.c b/drivers/net/wireless/ath/ath9k/ar9003_hw.c
index 7f5de6e4448b..a55eddbb2589 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_hw.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_hw.c
@@ -18,6 +18,7 @@
 #include "ar9003_mac.h"
 #include "ar9003_2p2_initvals.h"
 #include "ar9485_initvals.h"
+#include "ar9340_initvals.h"
 /* General hardware code for the AR9003 hadware family */
@@ -28,109 +29,105 @@
 */
 static void ar9003_hw_init_mode_regs(struct ath_hw *ah)
 {
-        if (AR_SREV_9485_11(ah)) {
+        if (AR_SREV_9340(ah)) {
                /* mac */
                INIT_INI_ARRAY(&ah->iniMac[ATH_INI_PRE], NULL, 0, 0);
                INIT_INI_ARRAY(&ah->iniMac[ATH_INI_CORE],
-                                ar9485_1_1_mac_core,
+                                ar9340_1p0_mac_core,
-                                ARRAY_SIZE(ar9485_1_1_mac_core), 2);
+                                ARRAY_SIZE(ar9340_1p0_mac_core), 2);
                INIT_INI_ARRAY(&ah->iniMac[ATH_INI_POST],
-                                ar9485_1_1_mac_postamble,
+                                ar9340_1p0_mac_postamble,
-                                ARRAY_SIZE(ar9485_1_1_mac_postamble), 5);
+                                ARRAY_SIZE(ar9340_1p0_mac_postamble), 5);
                /* bb */
-                INIT_INI_ARRAY(&ah->iniBB[ATH_INI_PRE], ar9485_1_1,
+                INIT_INI_ARRAY(&ah->iniBB[ATH_INI_PRE], NULL, 0, 0);
-                                ARRAY_SIZE(ar9485_1_1), 2);
                INIT_INI_ARRAY(&ah->iniBB[ATH_INI_CORE],
-                                ar9485_1_1_baseband_core,
+                                ar9340_1p0_baseband_core,
-                                ARRAY_SIZE(ar9485_1_1_baseband_core), 2);
+                                ARRAY_SIZE(ar9340_1p0_baseband_core), 2);
                INIT_INI_ARRAY(&ah->iniBB[ATH_INI_POST],
-                                ar9485_1_1_baseband_postamble,
+                                ar9340_1p0_baseband_postamble,
-                                ARRAY_SIZE(ar9485_1_1_baseband_postamble), 5);
+                                ARRAY_SIZE(ar9340_1p0_baseband_postamble), 5);
                /* radio */
                INIT_INI_ARRAY(&ah->iniRadio[ATH_INI_PRE], NULL, 0, 0);
                INIT_INI_ARRAY(&ah->iniRadio[ATH_INI_CORE],
-                                ar9485_1_1_radio_core,
+                                ar9340_1p0_radio_core,
-                                ARRAY_SIZE(ar9485_1_1_radio_core), 2);
+                                ARRAY_SIZE(ar9340_1p0_radio_core), 2);
                INIT_INI_ARRAY(&ah->iniRadio[ATH_INI_POST],
-                                ar9485_1_1_radio_postamble,
+                                ar9340_1p0_radio_postamble,
-                                ARRAY_SIZE(ar9485_1_1_radio_postamble), 2);
+                                ARRAY_SIZE(ar9340_1p0_radio_postamble), 5);
                /* soc */
                INIT_INI_ARRAY(&ah->iniSOC[ATH_INI_PRE],
-                                ar9485_1_1_soc_preamble,
+                                ar9340_1p0_soc_preamble,
-                                ARRAY_SIZE(ar9485_1_1_soc_preamble), 2);
+                                ARRAY_SIZE(ar9340_1p0_soc_preamble), 2);
                INIT_INI_ARRAY(&ah->iniSOC[ATH_INI_CORE], NULL, 0, 0);
-                INIT_INI_ARRAY(&ah->iniSOC[ATH_INI_POST], NULL, 0, 0);
+                INIT_INI_ARRAY(&ah->iniSOC[ATH_INI_POST],
+                                ar9340_1p0_soc_postamble,
+                                ARRAY_SIZE(ar9340_1p0_soc_postamble), 5);
                /* rx/tx gain */
                INIT_INI_ARRAY(&ah->iniModesRxGain,
-                                ar9485_common_rx_gain_1_1,
+                                ar9340Common_wo_xlna_rx_gain_table_1p0,
-                                ARRAY_SIZE(ar9485_common_rx_gain_1_1), 2);
+                                ARRAY_SIZE(ar9340Common_wo_xlna_rx_gain_table_1p0),
+                                5);
                INIT_INI_ARRAY(&ah->iniModesTxGain,
-                                ar9485_modes_lowest_ob_db_tx_gain_1_1,
+                                ar9340Modes_high_ob_db_tx_gain_table_1p0,
-                                ARRAY_SIZE(ar9485_modes_lowest_ob_db_tx_gain_1_1),
+                                ARRAY_SIZE(ar9340Modes_high_ob_db_tx_gain_table_1p0),
                                5);
-                /* Load PCIE SERDES settings from INI */
+                INIT_INI_ARRAY(&ah->iniModesAdditional,
+                                ar9340Modes_fast_clock_1p0,
-                /* Awake Setting */
+                                ARRAY_SIZE(ar9340Modes_fast_clock_1p0),
+                                3);
-                INIT_INI_ARRAY(&ah->iniPcieSerdes,
-                                ar9485_1_1_pcie_phy_clkreq_disable_L1,
-                                ARRAY_SIZE(ar9485_1_1_pcie_phy_clkreq_disable_L1),
-                                2);
-                /* Sleep Setting */
-                INIT_INI_ARRAY(&ah->iniPcieSerdesLowPower,
+                INIT_INI_ARRAY(&ah->iniModesAdditional_40M,
-                                ar9485_1_1_pcie_phy_clkreq_disable_L1,
+                                ar9340_1p0_radio_core_40M,
-                                ARRAY_SIZE(ar9485_1_1_pcie_phy_clkreq_disable_L1),
+                                ARRAY_SIZE(ar9340_1p0_radio_core_40M),
                                2);
-        } else if (AR_SREV_9485(ah)) {
+        } else if (AR_SREV_9485_11(ah)) {
                /* mac */
                INIT_INI_ARRAY(&ah->iniMac[ATH_INI_PRE], NULL, 0, 0);
                INIT_INI_ARRAY(&ah->iniMac[ATH_INI_CORE],
-                                ar9485_1_0_mac_core,
+                                ar9485_1_1_mac_core,
-                                ARRAY_SIZE(ar9485_1_0_mac_core), 2);
+                                ARRAY_SIZE(ar9485_1_1_mac_core), 2);
                INIT_INI_ARRAY(&ah->iniMac[ATH_INI_POST],
-                                ar9485_1_0_mac_postamble,
+                                ar9485_1_1_mac_postamble,
-                                ARRAY_SIZE(ar9485_1_0_mac_postamble), 5);
+                                ARRAY_SIZE(ar9485_1_1_mac_postamble), 5);
                /* bb */
-                INIT_INI_ARRAY(&ah->iniBB[ATH_INI_PRE], ar9485_1_0,
+                INIT_INI_ARRAY(&ah->iniBB[ATH_INI_PRE], ar9485_1_1,
-                                ARRAY_SIZE(ar9485_1_0), 2);
+                                ARRAY_SIZE(ar9485_1_1), 2);
                INIT_INI_ARRAY(&ah->iniBB[ATH_INI_CORE],
-                                ar9485_1_0_baseband_core,
+                                ar9485_1_1_baseband_core,
-                                ARRAY_SIZE(ar9485_1_0_baseband_core), 2);
+                                ARRAY_SIZE(ar9485_1_1_baseband_core), 2);
                INIT_INI_ARRAY(&ah->iniBB[ATH_INI_POST],
-                                ar9485_1_0_baseband_postamble,
+                                ar9485_1_1_baseband_postamble,
-                                ARRAY_SIZE(ar9485_1_0_baseband_postamble), 5);
+                                ARRAY_SIZE(ar9485_1_1_baseband_postamble), 5);
                /* radio */
                INIT_INI_ARRAY(&ah->iniRadio[ATH_INI_PRE], NULL, 0, 0);
                INIT_INI_ARRAY(&ah->iniRadio[ATH_INI_CORE],
-                                ar9485_1_0_radio_core,
+                                ar9485_1_1_radio_core,
-                                ARRAY_SIZE(ar9485_1_0_radio_core), 2);
+                                ARRAY_SIZE(ar9485_1_1_radio_core), 2);
                INIT_INI_ARRAY(&ah->iniRadio[ATH_INI_POST],
-                                ar9485_1_0_radio_postamble,
+                                ar9485_1_1_radio_postamble,
-                                ARRAY_SIZE(ar9485_1_0_radio_postamble), 2);
+                                ARRAY_SIZE(ar9485_1_1_radio_postamble), 2);
                /* soc */
                INIT_INI_ARRAY(&ah->iniSOC[ATH_INI_PRE],
-                                ar9485_1_0_soc_preamble,
+                                ar9485_1_1_soc_preamble,
-                                ARRAY_SIZE(ar9485_1_0_soc_preamble), 2);
+                                ARRAY_SIZE(ar9485_1_1_soc_preamble), 2);
                INIT_INI_ARRAY(&ah->iniSOC[ATH_INI_CORE], NULL, 0, 0);
                INIT_INI_ARRAY(&ah->iniSOC[ATH_INI_POST], NULL, 0, 0);
                /* rx/tx gain */
                INIT_INI_ARRAY(&ah->iniModesRxGain,
-                                ar9485Common_rx_gain_1_0,
+                                ar9485Common_wo_xlna_rx_gain_1_1,
-                                ARRAY_SIZE(ar9485Common_rx_gain_1_0), 2);
+                                ARRAY_SIZE(ar9485Common_wo_xlna_rx_gain_1_1), 2);
                INIT_INI_ARRAY(&ah->iniModesTxGain,
-                                ar9485Modes_lowest_ob_db_tx_gain_1_0,
+                                ar9485_modes_lowest_ob_db_tx_gain_1_1,
-                                ARRAY_SIZE(ar9485Modes_lowest_ob_db_tx_gain_1_0),
+                                ARRAY_SIZE(ar9485_modes_lowest_ob_db_tx_gain_1_1),
                                5);
                /* Load PCIE SERDES settings from INI */
@@ -138,15 +135,15 @@ static void ar9003_hw_init_mode_regs(struct ath_hw *ah)
                /* Awake Setting */
                INIT_INI_ARRAY(&ah->iniPcieSerdes,
-                                ar9485_1_0_pcie_phy_pll_on_clkreq_disable_L1,
+                                ar9485_1_1_pcie_phy_clkreq_disable_L1,
-                                ARRAY_SIZE(ar9485_1_0_pcie_phy_pll_on_clkreq_disable_L1),
+                                ARRAY_SIZE(ar9485_1_1_pcie_phy_clkreq_disable_L1),
                                2);
                /* Sleep Setting */
                INIT_INI_ARRAY(&ah->iniPcieSerdesLowPower,
-                                ar9485_1_0_pcie_phy_pll_on_clkreq_disable_L1,
+                                ar9485_1_1_pcie_phy_clkreq_disable_L1,
-                                ARRAY_SIZE(ar9485_1_0_pcie_phy_pll_on_clkreq_disable_L1),
+                                ARRAY_SIZE(ar9485_1_1_pcie_phy_clkreq_disable_L1),
                                2);
        } else {
                /* mac */
@@ -223,15 +220,15 @@ static void ar9003_tx_gain_table_apply(struct ath_hw *ah)
        switch (ar9003_hw_get_tx_gain_idx(ah)) {
        case 0:
        default:
-                if (AR_SREV_9485_11(ah))
+                if (AR_SREV_9340(ah))
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
-                                       ar9485_modes_lowest_ob_db_tx_gain_1_1,
+                                        ar9340Modes_lowest_ob_db_tx_gain_table_1p0,
-                                       ARRAY_SIZE(ar9485_modes_lowest_ob_db_tx_gain_1_1),
+                                       ARRAY_SIZE(ar9340Modes_lowest_ob_db_tx_gain_table_1p0),
                                       5);
-                else if (AR_SREV_9485(ah))
+                else if (AR_SREV_9485_11(ah))
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
-                                       ar9485Modes_lowest_ob_db_tx_gain_1_0,
+                                       ar9485_modes_lowest_ob_db_tx_gain_1_1,
-                                       ARRAY_SIZE(ar9485Modes_lowest_ob_db_tx_gain_1_0),
+                                       ARRAY_SIZE(ar9485_modes_lowest_ob_db_tx_gain_1_1),
                                       5);
                else
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
@@ -240,15 +237,15 @@ static void ar9003_tx_gain_table_apply(struct ath_hw *ah)
                                       5);
                break;
        case 1:
-                if (AR_SREV_9485_11(ah))
+                if (AR_SREV_9340(ah))
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
-                                       ar9485Modes_high_ob_db_tx_gain_1_1,
+                                        ar9340Modes_lowest_ob_db_tx_gain_table_1p0,
-                                       ARRAY_SIZE(ar9485Modes_high_ob_db_tx_gain_1_1),
+                                       ARRAY_SIZE(ar9340Modes_lowest_ob_db_tx_gain_table_1p0),
                                       5);
-                else if (AR_SREV_9485(ah))
+                else if (AR_SREV_9485_11(ah))
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
-                                       ar9485Modes_high_ob_db_tx_gain_1_0,
+                                       ar9485Modes_high_ob_db_tx_gain_1_1,
-                                       ARRAY_SIZE(ar9485Modes_high_ob_db_tx_gain_1_0),
+                                       ARRAY_SIZE(ar9485Modes_high_ob_db_tx_gain_1_1),
                                       5);
                else
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
@@ -257,15 +254,15 @@ static void ar9003_tx_gain_table_apply(struct ath_hw *ah)
                                       5);
                break;
        case 2:
-                if (AR_SREV_9485_11(ah))
+                if (AR_SREV_9340(ah))
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
-                                       ar9485Modes_low_ob_db_tx_gain_1_1,
+                                        ar9340Modes_lowest_ob_db_tx_gain_table_1p0,
-                                       ARRAY_SIZE(ar9485Modes_low_ob_db_tx_gain_1_1),
+                                       ARRAY_SIZE(ar9340Modes_lowest_ob_db_tx_gain_table_1p0),
                                       5);
-                else if (AR_SREV_9485(ah))
+                else if (AR_SREV_9485_11(ah))
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
-                                       ar9485Modes_low_ob_db_tx_gain_1_0,
+                                       ar9485Modes_low_ob_db_tx_gain_1_1,
-                                       ARRAY_SIZE(ar9485Modes_low_ob_db_tx_gain_1_0),
+                                       ARRAY_SIZE(ar9485Modes_low_ob_db_tx_gain_1_1),
                                       5);
                else
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
@@ -274,15 +271,15 @@ static void ar9003_tx_gain_table_apply(struct ath_hw *ah)
                                       5);
                break;
        case 3:
-                if (AR_SREV_9485_11(ah))
+                if (AR_SREV_9340(ah))
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
-                                       ar9485Modes_high_power_tx_gain_1_1,
+                                        ar9340Modes_lowest_ob_db_tx_gain_table_1p0,
-                                       ARRAY_SIZE(ar9485Modes_high_power_tx_gain_1_1),
+                                       ARRAY_SIZE(ar9340Modes_lowest_ob_db_tx_gain_table_1p0),
                                       5);
-                else if (AR_SREV_9485(ah))
+                else if (AR_SREV_9485_11(ah))
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
-                                       ar9485Modes_high_power_tx_gain_1_0,
+                                       ar9485Modes_high_power_tx_gain_1_1,
-                                       ARRAY_SIZE(ar9485Modes_high_power_tx_gain_1_0),
+                                       ARRAY_SIZE(ar9485Modes_high_power_tx_gain_1_1),
                                       5);
                else
                        INIT_INI_ARRAY(&ah->iniModesTxGain,
@@ -298,15 +295,15 @@ static void ar9003_rx_gain_table_apply(struct ath_hw *ah)
        switch (ar9003_hw_get_rx_gain_idx(ah)) {
        case 0:
        default:
-                if (AR_SREV_9485_11(ah))
+                if (AR_SREV_9340(ah))
                        INIT_INI_ARRAY(&ah->iniModesRxGain,
-                                       ar9485_common_rx_gain_1_1,
+                                       ar9340Common_rx_gain_table_1p0,
-                                       ARRAY_SIZE(ar9485_common_rx_gain_1_1),
+                                       ARRAY_SIZE(ar9340Common_rx_gain_table_1p0),
                                       2);
-                else if (AR_SREV_9485(ah))
+                else if (AR_SREV_9485_11(ah))
                        INIT_INI_ARRAY(&ah->iniModesRxGain,
-                                       ar9485Common_rx_gain_1_0,
+                                       ar9485Common_wo_xlna_rx_gain_1_1,
-                                       ARRAY_SIZE(ar9485Common_rx_gain_1_0),
+                                       ARRAY_SIZE(ar9485Common_wo_xlna_rx_gain_1_1),
                                       2);
                else
                        INIT_INI_ARRAY(&ah->iniModesRxGain,
@@ -315,15 +312,15 @@ static void ar9003_rx_gain_table_apply(struct ath_hw *ah)
                                       2);
                break;
        case 1:
-                if (AR_SREV_9485_11(ah))
+                if (AR_SREV_9340(ah))
                        INIT_INI_ARRAY(&ah->iniModesRxGain,
-                                       ar9485Common_wo_xlna_rx_gain_1_1,
+                                       ar9340Common_wo_xlna_rx_gain_table_1p0,
-                                       ARRAY_SIZE(ar9485Common_wo_xlna_rx_gain_1_1),
+                                       ARRAY_SIZE(ar9340Common_wo_xlna_rx_gain_table_1p0),
                                       2);
-                else if (AR_SREV_9485(ah))
+                else if (AR_SREV_9485_11(ah))
                        INIT_INI_ARRAY(&ah->iniModesRxGain,
-                                       ar9485Common_wo_xlna_rx_gain_1_0,
+                                       ar9485Common_wo_xlna_rx_gain_1_1,
-                                       ARRAY_SIZE(ar9485Common_wo_xlna_rx_gain_1_0),
+                                       ARRAY_SIZE(ar9485Common_wo_xlna_rx_gain_1_1),
                                       2);
                else
                        INIT_INI_ARRAY(&ah->iniModesRxGain,
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mac.c b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
index 038a0cbfc6e7..be6adec33ddb 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_mac.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
@@ -329,7 +329,6 @@ static void ar9003_hw_set11n_txdesc(struct ath_hw *ah, void *ds,
                | (flags & ATH9K_TXDESC_VMF ? AR_VirtMoreFrag : 0)
                | SM(txpower, AR_XmitPower)
                | (flags & ATH9K_TXDESC_VEOL ? AR_VEOL : 0)
-                | (flags & ATH9K_TXDESC_CLRDMASK ? AR_ClrDestMask : 0)
                | (keyIx != ATH9K_TXKEYIX_INVALID ? AR_DestIdxValid : 0)
                | (flags & ATH9K_TXDESC_LOWRXCHAIN ? AR_LowRxChain : 0);
@@ -350,6 +349,16 @@ static void ar9003_hw_set11n_txdesc(struct ath_hw *ah, void *ds,
        ads->ctl22 = 0;
 }
+static void ar9003_hw_set_clrdmask(struct ath_hw *ah, void *ds, bool val)
+{
+        struct ar9003_txc *ads = (struct ar9003_txc *) ds;
+        if (val)
+                ads->ctl11 |= AR_ClrDestMask;
+        else
+                ads->ctl11 &= ~AR_ClrDestMask;
+}
 static void ar9003_hw_set11n_ratescenario(struct ath_hw *ah, void *ds,
                                          void *lastds,
                                          u32 durUpdateEn, u32 rtsctsRate,
@@ -475,27 +484,6 @@ static void ar9003_hw_clr11n_aggr(struct ath_hw *ah, void *ds)
        ads->ctl12 &= (~AR_IsAggr & ~AR_MoreAggr);
 }
-static void ar9003_hw_set11n_burstduration(struct ath_hw *ah, void *ds,
-                                           u32 burstDuration)
-{
-        struct ar9003_txc *ads = (struct ar9003_txc *) ds;
-        ads->ctl13 &= ~AR_BurstDur;
-        ads->ctl13 |= SM(burstDuration, AR_BurstDur);
-}
-static void ar9003_hw_set11n_virtualmorefrag(struct ath_hw *ah, void *ds,
-                                             u32 vmf)
-{
-        struct ar9003_txc *ads = (struct ar9003_txc *) ds;
-        if (vmf)
-                ads->ctl11 |=  AR_VirtMoreFrag;
-        else
-                ads->ctl11 &= ~AR_VirtMoreFrag;
-}
 void ar9003_hw_set_paprd_txdesc(struct ath_hw *ah, void *ds, u8 chains)
 {
        struct ar9003_txc *ads = ds;
@@ -520,8 +508,7 @@ void ar9003_hw_attach_mac_ops(struct ath_hw *hw)
        ops->set11n_aggr_middle = ar9003_hw_set11n_aggr_middle;
        ops->set11n_aggr_last = ar9003_hw_set11n_aggr_last;
        ops->clr11n_aggr = ar9003_hw_clr11n_aggr;
-        ops->set11n_burstduration = ar9003_hw_set11n_burstduration;
+        ops->set_clrdmask = ar9003_hw_set_clrdmask;
-        ops->set11n_virtualmorefrag = ar9003_hw_set11n_virtualmorefrag;
 }
 void ath9k_hw_set_rx_bufsize(struct ath_hw *ah, u16 buf_size)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
index eb250d6b8038..25f3c2fdf2bc 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
@@ -75,16 +75,42 @@ static int ar9003_hw_set_channel(struct ath_hw *ah, struct ath9k_channel *chan)
        freq = centers.synth_center;
        if (freq < 4800) {     /* 2 GHz, fractional mode */
-                if (AR_SREV_9485(ah))
+                if (AR_SREV_9485(ah)) {
-                        channelSel = CHANSEL_2G_9485(freq);
+                        u32 chan_frac;
-                else
+                        /*
+                         * freq_ref = 40 / (refdiva >> amoderefsel); where refdiva=1 and amoderefsel=0
+                         * ndiv = ((chan_mhz * 4) / 3) / freq_ref;
+                         * chansel = int(ndiv), chanfrac = (ndiv - chansel) * 0x20000
+                         */
+                        channelSel = (freq * 4) / 120;
+                        chan_frac = (((freq * 4) % 120) * 0x20000) / 120;
+                        channelSel = (channelSel << 17) | chan_frac;
+                } else if (AR_SREV_9340(ah)) {
+                        if (ah->is_clk_25mhz) {
+                                u32 chan_frac;
+                                channelSel = (freq * 2) / 75;
+                                chan_frac = (((freq * 2) % 75) * 0x20000) / 75;
+                                channelSel = (channelSel << 17) | chan_frac;
+                        } else
+                                channelSel = CHANSEL_2G(freq) >> 1;
+                } else
                        channelSel = CHANSEL_2G(freq);
                /* Set to 2G mode */
                bMode = 1;
        } else {
-                channelSel = CHANSEL_5G(freq);
+                if (AR_SREV_9340(ah) && ah->is_clk_25mhz) {
-                /* Doubler is ON, so, divide channelSel by 2. */
+                        u32 chan_frac;
-                channelSel >>= 1;
+                        channelSel = (freq * 2) / 75;
+                        chan_frac = ((freq % 75) * 0x20000) / 75;
+                        channelSel = (channelSel << 17) | chan_frac;
+                } else {
+                        channelSel = CHANSEL_5G(freq);
+                        /* Doubler is ON, so, divide channelSel by 2. */
+                        channelSel >>= 1;
+                }
                /* Set to 5G mode */
                bMode = 0;
        }
@@ -142,7 +168,7 @@ static void ar9003_hw_spur_mitigate_mrc_cck(struct ath_hw *ah,
         * is out-of-band and can be ignored.
         */
-        if (AR_SREV_9485(ah)) {
+        if (AR_SREV_9485(ah) || AR_SREV_9340(ah)) {
                spur_fbin_ptr = ar9003_get_spur_chan_ptr(ah,
                                                         IS_CHAN_2GHZ(chan));
                if (spur_fbin_ptr[0] == 0) /* No spur */
@@ -167,7 +193,7 @@ static void ar9003_hw_spur_mitigate_mrc_cck(struct ath_hw *ah,
        for (i = 0; i < max_spur_cnts; i++) {
                negative = 0;
-                if (AR_SREV_9485(ah))
+                if (AR_SREV_9485(ah) || AR_SREV_9340(ah))
                        cur_bb_spur = FBIN2FREQ(spur_fbin_ptr[i],
                                        IS_CHAN_2GHZ(chan)) - synth_freq;
                else
@@ -401,7 +427,7 @@ static void ar9003_hw_spur_mitigate_ofdm(struct ath_hw *ah,
        ar9003_hw_spur_ofdm_clear(ah);
-        for (i = 0; spurChansPtr[i] && i < 5; i++) {
+        for (i = 0; i < AR_EEPROM_MODAL_SPURS && spurChansPtr[i]; i++) {
                freq_offset = FBIN2FREQ(spurChansPtr[i], mode) - synth_freq;
                if (abs(freq_offset) < range) {
                        ar9003_hw_spur_ofdm_work(ah, chan, freq_offset);
@@ -590,29 +616,25 @@ static int ar9003_hw_process_ini(struct ath_hw *ah,
        struct ath_regulatory *regulatory = ath9k_hw_regulatory(ah);
        unsigned int regWrites = 0, i;
        struct ieee80211_channel *channel = chan->chan;
-        u32 modesIndex, freqIndex;
+        u32 modesIndex;
        switch (chan->chanmode) {
        case CHANNEL_A:
        case CHANNEL_A_HT20:
                modesIndex = 1;
-                freqIndex = 1;
                break;
        case CHANNEL_A_HT40PLUS:
        case CHANNEL_A_HT40MINUS:
                modesIndex = 2;
-                freqIndex = 1;
                break;
        case CHANNEL_G:
        case CHANNEL_G_HT20:
        case CHANNEL_B:
                modesIndex = 4;
-                freqIndex = 2;
                break;
        case CHANNEL_G_HT40PLUS:
        case CHANNEL_G_HT40MINUS:
                modesIndex = 3;
-                freqIndex = 2;
                break;
        default:
@@ -637,6 +659,9 @@ static int ar9003_hw_process_ini(struct ath_hw *ah,
                REG_WRITE_ARRAY(&ah->iniModesAdditional,
                                modesIndex, regWrites);
+        if (AR_SREV_9340(ah) && !ah->is_clk_25mhz)
+                REG_WRITE_ARRAY(&ah->iniModesAdditional_40M, 1, regWrites);
        ar9003_hw_override_ini(ah);
        ar9003_hw_set_channel_regs(ah, chan);
        ar9003_hw_set_chain_masks(ah, ah->rxchainmask, ah->txchainmask);
@@ -1159,9 +1184,52 @@ static void ar9003_hw_set_radar_conf(struct ath_hw *ah)
        conf->radar_inband = 8;
 }
+static void ar9003_hw_antdiv_comb_conf_get(struct ath_hw *ah,
+                                   struct ath_hw_antcomb_conf *antconf)
+{
+        u32 regval;
+        regval = REG_READ(ah, AR_PHY_MC_GAIN_CTRL);
+        antconf->main_lna_conf = (regval & AR_PHY_9485_ANT_DIV_MAIN_LNACONF) >>
+                                  AR_PHY_9485_ANT_DIV_MAIN_LNACONF_S;
+        antconf->alt_lna_conf = (regval & AR_PHY_9485_ANT_DIV_ALT_LNACONF) >>
+                                 AR_PHY_9485_ANT_DIV_ALT_LNACONF_S;
+        antconf->fast_div_bias = (regval & AR_PHY_9485_ANT_FAST_DIV_BIAS) >>
+                                  AR_PHY_9485_ANT_FAST_DIV_BIAS_S;
+        antconf->lna1_lna2_delta = -9;
+        antconf->div_group = 2;
+}
+static void ar9003_hw_antdiv_comb_conf_set(struct ath_hw *ah,
+                                   struct ath_hw_antcomb_conf *antconf)
+{
+        u32 regval;
+        regval = REG_READ(ah, AR_PHY_MC_GAIN_CTRL);
+        regval &= ~(AR_PHY_9485_ANT_DIV_MAIN_LNACONF |
+                    AR_PHY_9485_ANT_DIV_ALT_LNACONF |
+                    AR_PHY_9485_ANT_FAST_DIV_BIAS |
+                    AR_PHY_9485_ANT_DIV_MAIN_GAINTB |
+                    AR_PHY_9485_ANT_DIV_ALT_GAINTB);
+        regval |= ((antconf->main_lna_conf <<
+                                        AR_PHY_9485_ANT_DIV_MAIN_LNACONF_S)
+                   & AR_PHY_9485_ANT_DIV_MAIN_LNACONF);
+        regval |= ((antconf->alt_lna_conf << AR_PHY_9485_ANT_DIV_ALT_LNACONF_S)
+                   & AR_PHY_9485_ANT_DIV_ALT_LNACONF);
+        regval |= ((antconf->fast_div_bias << AR_PHY_9485_ANT_FAST_DIV_BIAS_S)
+                   & AR_PHY_9485_ANT_FAST_DIV_BIAS);
+        regval |= ((antconf->main_gaintb << AR_PHY_9485_ANT_DIV_MAIN_GAINTB_S)
+                   & AR_PHY_9485_ANT_DIV_MAIN_GAINTB);
+        regval |= ((antconf->alt_gaintb << AR_PHY_9485_ANT_DIV_ALT_GAINTB_S)
+                   & AR_PHY_9485_ANT_DIV_ALT_GAINTB);
+        REG_WRITE(ah, AR_PHY_MC_GAIN_CTRL, regval);
+}
 void ar9003_hw_attach_phy_ops(struct ath_hw *ah)
 {
        struct ath_hw_private_ops *priv_ops = ath9k_hw_private_ops(ah);
+        struct ath_hw_ops *ops = ath9k_hw_ops(ah);
        static const u32 ar9300_cca_regs[6] = {
                AR_PHY_CCA_0,
                AR_PHY_CCA_1,
@@ -1188,6 +1256,9 @@ void ar9003_hw_attach_phy_ops(struct ath_hw *ah)
        priv_ops->ani_cache_ini_regs = ar9003_hw_ani_cache_ini_regs;
        priv_ops->set_radar_params = ar9003_hw_set_radar_params;
+        ops->antdiv_comb_conf_get = ar9003_hw_antdiv_comb_conf_get;
+        ops->antdiv_comb_conf_set = ar9003_hw_antdiv_comb_conf_set;
        ar9003_hw_set_nf_limits(ah);
        ar9003_hw_set_radar_conf(ah);
        memcpy(ah->nf_regs, ar9300_cca_regs, sizeof(ah->nf_regs));
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.h b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
index 8bdda2cf9dd7..c7505b48e5c0 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_phy.h
+++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
@@ -261,12 +261,34 @@
 #define AR_PHY_EXT_CCA0         (AR_AGC_BASE + 0x20)
 #define AR_PHY_RESTART          (AR_AGC_BASE + 0x24)
+/*
+ * Antenna Diversity  settings
+ */
 #define AR_PHY_MC_GAIN_CTRL     (AR_AGC_BASE + 0x28)
 #define AR_ANT_DIV_CTRL_ALL     0x7e000000
 #define AR_ANT_DIV_CTRL_ALL_S   25
 #define AR_ANT_DIV_ENABLE       0x1000000
 #define AR_ANT_DIV_ENABLE_S     24
+#define AR_PHY_9485_ANT_FAST_DIV_BIAS                   0x00007e00
+#define AR_PHY_9485_ANT_FAST_DIV_BIAS_S                  9
+#define AR_PHY_9485_ANT_DIV_LNADIV                      0x01000000
+#define AR_PHY_9485_ANT_DIV_LNADIV_S                    24
+#define AR_PHY_9485_ANT_DIV_ALT_LNACONF                 0x06000000
+#define AR_PHY_9485_ANT_DIV_ALT_LNACONF_S               25
+#define AR_PHY_9485_ANT_DIV_MAIN_LNACONF                0x18000000
+#define AR_PHY_9485_ANT_DIV_MAIN_LNACONF_S              27
+#define AR_PHY_9485_ANT_DIV_ALT_GAINTB                  0x20000000
+#define AR_PHY_9485_ANT_DIV_ALT_GAINTB_S                29
+#define AR_PHY_9485_ANT_DIV_MAIN_GAINTB                 0x40000000
+#define AR_PHY_9485_ANT_DIV_MAIN_GAINTB_S               30
+#define AR_PHY_9485_ANT_DIV_LNA1_MINUS_LNA2             0x0
+#define AR_PHY_9485_ANT_DIV_LNA2                        0x1
+#define AR_PHY_9485_ANT_DIV_LNA1                        0x2
+#define AR_PHY_9485_ANT_DIV_LNA1_PLUS_LNA2              0x3
 #define AR_PHY_EXTCHN_PWRTHR1   (AR_AGC_BASE + 0x2c)
 #define AR_PHY_EXT_CHN_WIN      (AR_AGC_BASE + 0x30)
 #define AR_PHY_20_40_DET_THR    (AR_AGC_BASE + 0x34)
@@ -548,15 +570,12 @@
 #define AR_PHY_TXGAIN_TABLE      (AR_SM_BASE + 0x300)
-#define AR_PHY_TX_IQCAL_START_9485              (AR_SM_BASE + 0x3c4)
+#define AR_PHY_TX_IQCAL_CONTROL_1   (AR_SM_BASE + AR_SREV_9485(ah) ? \
-#define AR_PHY_TX_IQCAL_START_DO_CAL_9485       0x80000000
+                                                 0x3c8 : 0x448)
-#define AR_PHY_TX_IQCAL_START_DO_CAL_9485_S     31
+#define AR_PHY_TX_IQCAL_START       (AR_SM_BASE + AR_SREV_9485(ah) ? \
-#define AR_PHY_TX_IQCAL_CONTROL_1_9485          (AR_SM_BASE + 0x3c8)
+                                                 0x3c4 : 0x440)
-#define AR_PHY_TX_IQCAL_STATUS_B0_9485          (AR_SM_BASE + 0x3f0)
+#define AR_PHY_TX_IQCAL_STATUS_B0   (AR_SM_BASE + AR_SREV_9485(ah) ? \
+                                                 0x3f0 : 0x48c)
-#define AR_PHY_TX_IQCAL_CONTROL_1   (AR_SM_BASE + 0x448)
-#define AR_PHY_TX_IQCAL_START       (AR_SM_BASE + 0x440)
-#define AR_PHY_TX_IQCAL_STATUS_B0   (AR_SM_BASE + 0x48c)
 #define AR_PHY_TX_IQCAL_CORR_COEFF_B0(_i)    (AR_SM_BASE + \
                                             (AR_SREV_9485(ah) ? \
                                              0x3d0 : 0x450) + ((_i) << 2))
@@ -588,7 +607,7 @@
 #define AR_PHY_65NM_CH0_BIAS2       0x160c4
 #define AR_PHY_65NM_CH0_BIAS4       0x160cc
 #define AR_PHY_65NM_CH0_RXTX4       0x1610c
-#define AR_PHY_65NM_CH0_THERM       (AR_SREV_9485(ah) ? 0x1628c : 0x16290)
+#define AR_PHY_65NM_CH0_THERM       (AR_SREV_9300(ah) ? 0x16290 : 0x1628c)
 #define AR_PHY_65NM_CH0_THERM_LOCAL   0x80000000
 #define AR_PHY_65NM_CH0_THERM_LOCAL_S 31
@@ -758,10 +777,10 @@
 #define AR_PHY_SPECTRAL_SCAN_SHORT_REPEAT   0x01000000
 #define AR_PHY_SPECTRAL_SCAN_SHORT_REPEAT_S 24
 #define AR_PHY_CHANNEL_STATUS_RX_CLEAR      0x00000004
-#define AR_PHY_TX_IQCAQL_CONTROL_1_IQCORR_I_Q_COFF_DELPT             0x01fc0000
+#define AR_PHY_TX_IQCAL_CONTROL_1_IQCORR_I_Q_COFF_DELPT             0x01fc0000
-#define AR_PHY_TX_IQCAQL_CONTROL_1_IQCORR_I_Q_COFF_DELPT_S                   18
+#define AR_PHY_TX_IQCAL_CONTROL_1_IQCORR_I_Q_COFF_DELPT_S                   18
-#define AR_PHY_TX_IQCAL_START_DO_CAL        0x00000001
+#define AR_PHY_TX_IQCAL_START_DO_CAL        0x00000001
-#define AR_PHY_TX_IQCAL_START_DO_CAL_S      0
+#define AR_PHY_TX_IQCAL_START_DO_CAL_S      0
 #define AR_PHY_TX_IQCAL_STATUS_FAILED    0x00000001
 #define AR_PHY_CALIBRATED_GAINS_0        0x3e
diff --git a/drivers/net/wireless/ath/ath9k/ar9340_initvals.h b/drivers/net/wireless/ath/ath9k/ar9340_initvals.h
new file mode 100644
index 000000000000..815a8af1beef
--- /dev/null
+++ b/drivers/net/wireless/ath/ath9k/ar9340_initvals.h
@@ -0,0 +1,1525 @@
+/*
+ * Copyright (c) 2011 Atheros Communications Inc.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+#ifndef INITVALS_9340_H
+#define INITVALS_9340_H
+static const u32 ar9340_1p0_radio_postamble[][5] = {
+        /*  Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20  */
+        {0x000160ac, 0xa4646800, 0xa4646800, 0xa4646800, 0xa4646800},
+        {0x0001610c, 0x08000000, 0x08000000, 0x00000000, 0x00000000},
+        {0x00016140, 0x10804000, 0x10804000, 0x50804000, 0x50804000},
+        {0x0001650c, 0x08000000, 0x08000000, 0x00000000, 0x00000000},
+        {0x00016540, 0x10804000, 0x10804000, 0x50804000, 0x50804000},
+};
+static const u32 ar9340Modes_lowest_ob_db_tx_gain_table_1p0[][5] = {
+        /*   Addr     5G_HT20     5G_HT40     2G_HT40     2G_HT20  */
+        {0x0000a410, 0x000050d9, 0x000050d9, 0x000050d9, 0x000050d9},
+        {0x0000a500, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000a504, 0x06000003, 0x06000003, 0x04000002, 0x04000002},
+        {0x0000a508, 0x0a000020, 0x0a000020, 0x08000004, 0x08000004},
+        {0x0000a50c, 0x10000023, 0x10000023, 0x0b000200, 0x0b000200},
+        {0x0000a510, 0x16000220, 0x16000220, 0x0f000202, 0x0f000202},
+        {0x0000a514, 0x1c000223, 0x1c000223, 0x12000400, 0x12000400},
+        {0x0000a518, 0x21020220, 0x21020220, 0x16000402, 0x16000402},
+        {0x0000a51c, 0x27020223, 0x27020223, 0x19000404, 0x19000404},
+        {0x0000a520, 0x2b022220, 0x2b022220, 0x1c000603, 0x1c000603},
+        {0x0000a524, 0x2f022222, 0x2f022222, 0x21000a02, 0x21000a02},
+        {0x0000a528, 0x34022225, 0x34022225, 0x25000a04, 0x25000a04},
+        {0x0000a52c, 0x3a02222a, 0x3a02222a, 0x28000a20, 0x28000a20},
+        {0x0000a530, 0x3e02222c, 0x3e02222c, 0x2c000e20, 0x2c000e20},
+        {0x0000a534, 0x4202242a, 0x4202242a, 0x30000e22, 0x30000e22},
+        {0x0000a538, 0x4702244a, 0x4702244a, 0x34000e24, 0x34000e24},
+        {0x0000a53c, 0x4b02244c, 0x4b02244c, 0x38001640, 0x38001640},
+        {0x0000a540, 0x4e02246c, 0x4e02246c, 0x3c001660, 0x3c001660},
+        {0x0000a544, 0x5302266c, 0x5302266c, 0x3f001861, 0x3f001861},
+        {0x0000a548, 0x5702286c, 0x5702286c, 0x43001a81, 0x43001a81},
+        {0x0000a54c, 0x5c04286b, 0x5c04286b, 0x47001a83, 0x47001a83},
+        {0x0000a550, 0x61042a6c, 0x61042a6c, 0x4a001c84, 0x4a001c84},
+        {0x0000a554, 0x66062a6c, 0x66062a6c, 0x4e001ce3, 0x4e001ce3},
+        {0x0000a558, 0x6b062e6c, 0x6b062e6c, 0x52001ce5, 0x52001ce5},
+        {0x0000a55c, 0x7006308c, 0x7006308c, 0x56001ce9, 0x56001ce9},
+        {0x0000a560, 0x730a308a, 0x730a308a, 0x5a001ceb, 0x5a001ceb},
+        {0x0000a564, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a568, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a56c, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a570, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a574, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a578, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a57c, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a580, 0x00800000, 0x00800000, 0x00800000, 0x00800000},
+        {0x0000a584, 0x06800003, 0x06800003, 0x04800002, 0x04800002},
+        {0x0000a588, 0x0a800020, 0x0a800020, 0x08800004, 0x08800004},
+        {0x0000a58c, 0x10800023, 0x10800023, 0x0b800200, 0x0b800200},
+        {0x0000a590, 0x16800220, 0x16800220, 0x0f800202, 0x0f800202},
+        {0x0000a594, 0x1c800223, 0x1c800223, 0x12800400, 0x12800400},
+        {0x0000a598, 0x21820220, 0x21820220, 0x16800402, 0x16800402},
+        {0x0000a59c, 0x27820223, 0x27820223, 0x19800404, 0x19800404},
+        {0x0000a5a0, 0x2b822220, 0x2b822220, 0x1c800603, 0x1c800603},
+        {0x0000a5a4, 0x2f822222, 0x2f822222, 0x21800a02, 0x21800a02},
+        {0x0000a5a8, 0x34822225, 0x34822225, 0x25800a04, 0x25800a04},
+        {0x0000a5ac, 0x3a82222a, 0x3a82222a, 0x28800a20, 0x28800a20},
+        {0x0000a5b0, 0x3e82222c, 0x3e82222c, 0x2c800e20, 0x2c800e20},
+        {0x0000a5b4, 0x4282242a, 0x4282242a, 0x30800e22, 0x30800e22},
+        {0x0000a5b8, 0x4782244a, 0x4782244a, 0x34800e24, 0x34800e24},
+        {0x0000a5bc, 0x4b82244c, 0x4b82244c, 0x38801640, 0x38801640},
+        {0x0000a5c0, 0x4e82246c, 0x4e82246c, 0x3c801660, 0x3c801660},
+        {0x0000a5c4, 0x5382266c, 0x5382266c, 0x3f801861, 0x3f801861},
+        {0x0000a5c8, 0x5782286c, 0x5782286c, 0x43801a81, 0x43801a81},
+        {0x0000a5cc, 0x5c84286b, 0x5c84286b, 0x47801a83, 0x47801a83},
+        {0x0000a5d0, 0x61842a6c, 0x61842a6c, 0x4a801c84, 0x4a801c84},
+        {0x0000a5d4, 0x66862a6c, 0x66862a6c, 0x4e801ce3, 0x4e801ce3},
+        {0x0000a5d8, 0x6b862e6c, 0x6b862e6c, 0x52801ce5, 0x52801ce5},
+        {0x0000a5dc, 0x7086308c, 0x7086308c, 0x56801ce9, 0x56801ce9},
+        {0x0000a5e0, 0x738a308a, 0x738a308a, 0x5a801ceb, 0x5a801ceb},
+        {0x0000a5e4, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5e8, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5ec, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5f0, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5f4, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5f8, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5fc, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x00016044, 0x056db2db, 0x056db2db, 0x056db2db, 0x056db2db},
+        {0x00016048, 0x24925266, 0x24925266, 0x24925266, 0x24925266},
+        {0x00016444, 0x056db2db, 0x056db2db, 0x056db2db, 0x056db2db},
+        {0x00016448, 0x24925266, 0x24925266, 0x24925266, 0x24925266},
+};
+static const u32 ar9340Modes_fast_clock_1p0[][3] = {
+        /*  Addr      5G_HT20     5G_HT40  */
+        {0x00001030, 0x00000268, 0x000004d0},
+        {0x00001070, 0x0000018c, 0x00000318},
+        {0x000010b0, 0x00000fd0, 0x00001fa0},
+        {0x00008014, 0x044c044c, 0x08980898},
+        {0x0000801c, 0x148ec02b, 0x148ec057},
+        {0x00008318, 0x000044c0, 0x00008980},
+        {0x00009e00, 0x03721821, 0x03721821},
+        {0x0000a230, 0x0000000b, 0x00000016},
+        {0x0000a254, 0x00000898, 0x00001130},
+};
+static const u32 ar9340_1p0_radio_core[][2] = {
+        /*  Addr     allmodes  */
+        {0x00016000, 0x36db6db6},
+        {0x00016004, 0x6db6db40},
+        {0x00016008, 0x73f00000},
+        {0x0001600c, 0x00000000},
+        {0x00016040, 0x7f80fff8},
+        {0x00016044, 0x03b6d2db},
+        {0x00016048, 0x24925266},
+        {0x0001604c, 0x000f0278},
+        {0x00016050, 0x6db6db6c},
+        {0x00016054, 0x6db60000},
+        {0x00016080, 0x00080000},
+        {0x00016084, 0x0e48048c},
+        {0x00016088, 0x14214514},
+        {0x0001608c, 0x119f081c},
+        {0x00016090, 0x24926490},
+        {0x00016094, 0x00000000},
+        {0x00016098, 0xd411eb84},
+        {0x0001609c, 0x03e47f32},
+        {0x000160a0, 0xc2108ffe},
+        {0x000160a4, 0x812fc370},
+        {0x000160a8, 0x423c8000},
+        {0x000160ac, 0xa4646800},
+        {0x000160b0, 0x00fe7f46},
+        {0x000160b4, 0x92480000},
+        {0x000160c0, 0x006db6db},
+        {0x000160c4, 0x6db6db60},
+        {0x000160c8, 0x6db6db6c},
+        {0x000160cc, 0x6de6db6c},
+        {0x000160d0, 0xb6da4924},
+        {0x00016100, 0x04cb0001},
+        {0x00016104, 0xfff80000},
+        {0x00016108, 0x00080010},
+        {0x0001610c, 0x00000000},
+        {0x00016140, 0x50804008},
+        {0x00016144, 0x01884080},
+        {0x00016148, 0x000080c0},
+        {0x00016280, 0x01000015},
+        {0x00016284, 0x05530000},
+        {0x00016288, 0x00318000},
+        {0x0001628c, 0x50000000},
+        {0x00016290, 0x4080294f},
+        {0x00016380, 0x00000000},
+        {0x00016384, 0x00000000},
+        {0x00016388, 0x00800700},
+        {0x0001638c, 0x00800700},
+        {0x00016390, 0x00800700},
+        {0x00016394, 0x00000000},
+        {0x00016398, 0x00000000},
+        {0x0001639c, 0x00000000},
+        {0x000163a0, 0x00000001},
+        {0x000163a4, 0x00000001},
+        {0x000163a8, 0x00000000},
+        {0x000163ac, 0x00000000},
+        {0x000163b0, 0x00000000},
+        {0x000163b4, 0x00000000},
+        {0x000163b8, 0x00000000},
+        {0x000163bc, 0x00000000},
+        {0x000163c0, 0x000000a0},
+        {0x000163c4, 0x000c0000},
+        {0x000163c8, 0x14021402},
+        {0x000163cc, 0x00001402},
+        {0x000163d0, 0x00000000},
+        {0x000163d4, 0x00000000},
+        {0x00016400, 0x36db6db6},
+        {0x00016404, 0x6db6db40},
+        {0x00016408, 0x73f00000},
+        {0x0001640c, 0x00000000},
+        {0x00016440, 0x7f80fff8},
+        {0x00016444, 0x03b6d2db},
+        {0x00016448, 0x24927266},
+        {0x0001644c, 0x000f0278},
+        {0x00016450, 0x6db6db6c},
+        {0x00016454, 0x6db60000},
+        {0x00016500, 0x04cb0001},
+        {0x00016504, 0xfff80000},
+        {0x00016508, 0x00080010},
+        {0x0001650c, 0x00000000},
+        {0x00016540, 0x50804008},
+        {0x00016544, 0x01884080},
+        {0x00016548, 0x000080c0},
+        {0x00016780, 0x00000000},
+        {0x00016784, 0x00000000},
+        {0x00016788, 0x00800700},
+        {0x0001678c, 0x00800700},
+        {0x00016790, 0x00800700},
+        {0x00016794, 0x00000000},
+        {0x00016798, 0x00000000},
+        {0x0001679c, 0x00000000},
+        {0x000167a0, 0x00000001},
+        {0x000167a4, 0x00000001},
+        {0x000167a8, 0x00000000},
+        {0x000167ac, 0x00000000},
+        {0x000167b0, 0x00000000},
+        {0x000167b4, 0x00000000},
+        {0x000167b8, 0x00000000},
+        {0x000167bc, 0x00000000},
+        {0x000167c0, 0x000000a0},
+        {0x000167c4, 0x000c0000},
+        {0x000167c8, 0x14021402},
+        {0x000167cc, 0x00001402},
+        {0x000167d0, 0x00000000},
+        {0x000167d4, 0x00000000},
+};
+static const u32 ar9340_1p0_radio_core_40M[][2] = {
+        {0x0001609c, 0x02566f3a},
+        {0x000160ac, 0xa4647c00},
+        {0x000160b0, 0x01885f5a},
+};
+static const u32 ar9340_1p0_mac_postamble[][5] = {
+        /* Addr       5G_HT20     5G_HT40     2G_HT40    2G_HT20  */
+        {0x00001030, 0x00000230, 0x00000460, 0x000002c0, 0x00000160},
+        {0x00001070, 0x00000168, 0x000002d0, 0x00000318, 0x0000018c},
+        {0x000010b0, 0x00000e60, 0x00001cc0, 0x00007c70, 0x00003e38},
+        {0x00008014, 0x03e803e8, 0x07d007d0, 0x10801600, 0x08400b00},
+        {0x0000801c, 0x128d8027, 0x128d804f, 0x12e00057, 0x12e0002b},
+        {0x00008120, 0x08f04800, 0x08f04800, 0x08f04810, 0x08f04810},
+        {0x000081d0, 0x00003210, 0x00003210, 0x0000320a, 0x0000320a},
+        {0x00008318, 0x00003e80, 0x00007d00, 0x00006880, 0x00003440},
+};
+static const u32 ar9340_1p0_soc_postamble[][5] = {
+        /*   Addr     5G_HT20     5G_HT40     2G_HT40     2G_HT20  */
+        {0x00007010, 0x00000023, 0x00000023, 0x00000023, 0x00000023},
+};
+static const u32 ar9340_1p0_baseband_postamble[][5] = {
+        /*  Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20  */
+        {0x00009810, 0xd00a8005, 0xd00a8005, 0xd00a8011, 0xd00a8011},
+        {0x00009820, 0x206a022e, 0x206a022e, 0x206a022e, 0x206a022e},
+        {0x00009824, 0x5ac640d0, 0x5ac640d0, 0x5ac640d0, 0x5ac640d0},
+        {0x00009828, 0x06903081, 0x06903081, 0x06903881, 0x06903881},
+        {0x0000982c, 0x05eea6d4, 0x05eea6d4, 0x05eea6d4, 0x05eea6d4},
+        {0x00009830, 0x0000059c, 0x0000059c, 0x0000119c, 0x0000119c},
+        {0x00009c00, 0x00000044, 0x000000c4, 0x000000c4, 0x00000044},
+        {0x00009e00, 0x0372161e, 0x0372161e, 0x037216a0, 0x037216a0},
+        {0x00009e04, 0x00182020, 0x00182020, 0x00182020, 0x00182020},
+        {0x00009e0c, 0x6c4000e2, 0x6d4000e2, 0x6d4000e2, 0x6c4000e2},
+        {0x00009e10, 0x7ec88d2e, 0x7ec88d2e, 0x7ec88d2e, 0x7ec88d2e},
+        {0x00009e14, 0x31395d5e, 0x3139605e, 0x3139605e, 0x31395d5e},
+        {0x00009e18, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x00009e1c, 0x0001cf9c, 0x0001cf9c, 0x00021f9c, 0x00021f9c},
+        {0x00009e20, 0x000003b5, 0x000003b5, 0x000003ce, 0x000003ce},
+        {0x00009e2c, 0x0000001c, 0x0000001c, 0x00000021, 0x00000021},
+        {0x00009e44, 0x02321e27, 0x02321e27, 0x02291e27, 0x02291e27},
+        {0x00009e48, 0x5030201a, 0x5030201a, 0x50302012, 0x50302012},
+        {0x00009fc8, 0x0003f000, 0x0003f000, 0x0001a000, 0x0001a000},
+        {0x0000a204, 0x00003fc0, 0x00003fc4, 0x00003fc4, 0x00003fc0},
+        {0x0000a208, 0x00000104, 0x00000104, 0x00000004, 0x00000004},
+        {0x0000a230, 0x0000000a, 0x00000014, 0x00000016, 0x0000000b},
+        {0x0000a238, 0xffb81018, 0xffb81018, 0xffb81018, 0xffb81018},
+        {0x0000a250, 0x00000000, 0x00000000, 0x00000210, 0x00000108},
+        {0x0000a254, 0x000007d0, 0x00000fa0, 0x00001130, 0x00000898},
+        {0x0000a258, 0x02020002, 0x02020002, 0x02020002, 0x02020002},
+        {0x0000a25c, 0x01000e0e, 0x01000e0e, 0x01000e0e, 0x01000e0e},
+        {0x0000a260, 0x0a021501, 0x0a021501, 0x3a021501, 0x3a021501},
+        {0x0000a264, 0x00000e0e, 0x00000e0e, 0x00000e0e, 0x00000e0e},
+        {0x0000a280, 0x00000007, 0x00000007, 0x0000000b, 0x0000000b},
+        {0x0000a284, 0x00000000, 0x00000000, 0x00000150, 0x00000150},
+        {0x0000a288, 0x00000220, 0x00000220, 0x00000110, 0x00000110},
+        {0x0000a28c, 0x00011111, 0x00011111, 0x00022222, 0x00022222},
+        {0x0000a2c4, 0x00158d18, 0x00158d18, 0x00158d18, 0x00158d18},
+        {0x0000a2d0, 0x00071981, 0x00071981, 0x00071981, 0x00071982},
+        {0x0000a2d8, 0xf999a83a, 0xf999a83a, 0xf999a83a, 0xf999a83a},
+        {0x0000a358, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000a830, 0x0000019c, 0x0000019c, 0x0000019c, 0x0000019c},
+        {0x0000ae04, 0x00180000, 0x00180000, 0x00180000, 0x00180000},
+        {0x0000ae18, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000ae1c, 0x0000019c, 0x0000019c, 0x0000019c, 0x0000019c},
+        {0x0000ae20, 0x000001b5, 0x000001b5, 0x000001ce, 0x000001ce},
+        {0x0000b284, 0x00000000, 0x00000000, 0x00000150, 0x00000150},
+};
+static const u32 ar9340_1p0_baseband_core[][2] = {
+        /*  Addr     allmodes  */
+        {0x00009800, 0xafe68e30},
+        {0x00009804, 0xfd14e000},
+        {0x00009808, 0x9c0a9f6b},
+        {0x0000980c, 0x04900000},
+        {0x00009814, 0xb280c00a},
+        {0x00009818, 0x00000000},
+        {0x0000981c, 0x00020028},
+        {0x00009834, 0x5f3ca3de},
+        {0x00009838, 0x0108ecff},
+        {0x0000983c, 0x14750600},
+        {0x00009880, 0x201fff00},
+        {0x00009884, 0x00001042},
+        {0x000098a4, 0x00200400},
+        {0x000098b0, 0x52440bbe},
+        {0x000098d0, 0x004b6a8e},
+        {0x000098d4, 0x00000820},
+        {0x000098dc, 0x00000000},
+        {0x000098f0, 0x00000000},
+        {0x000098f4, 0x00000000},
+        {0x00009c04, 0xff55ff55},
+        {0x00009c08, 0x0320ff55},
+        {0x00009c0c, 0x00000000},
+        {0x00009c10, 0x00000000},
+        {0x00009c14, 0x00046384},
+        {0x00009c18, 0x05b6b440},
+        {0x00009c1c, 0x00b6b440},
+        {0x00009d00, 0xc080a333},
+        {0x00009d04, 0x40206c10},
+        {0x00009d08, 0x009c4060},
+        {0x00009d0c, 0x9883800a},
+        {0x00009d10, 0x01834061},
+        {0x00009d14, 0x00c0040b},
+        {0x00009d18, 0x00000000},
+        {0x00009e08, 0x0038230c},
+        {0x00009e24, 0x990bb515},
+        {0x00009e28, 0x0c6f0000},
+        {0x00009e30, 0x06336f77},
+        {0x00009e34, 0x6af6532f},
+        {0x00009e38, 0x0cc80c00},
+        {0x00009e3c, 0xcf946222},
+        {0x00009e40, 0x0d261820},
+        {0x00009e4c, 0x00001004},
+        {0x00009e50, 0x00ff03f1},
+        {0x00009e54, 0x00000000},
+        {0x00009fc0, 0x803e4788},
+        {0x00009fc4, 0x0001efb5},
+        {0x00009fcc, 0x40000014},
+        {0x00009fd0, 0x01193b93},
+        {0x0000a20c, 0x00000000},
+        {0x0000a220, 0x00000000},
+        {0x0000a224, 0x00000000},
+        {0x0000a228, 0x10002310},
+        {0x0000a22c, 0x01036a1e},
+        {0x0000a234, 0x10000fff},
+        {0x0000a23c, 0x00000000},
+        {0x0000a244, 0x0c000000},
+        {0x0000a2a0, 0x00000001},
+        {0x0000a2c0, 0x00000001},
+        {0x0000a2c8, 0x00000000},
+        {0x0000a2cc, 0x18c43433},
+        {0x0000a2d4, 0x00000000},
+        {0x0000a2dc, 0x00000000},
+        {0x0000a2e0, 0x00000000},
+        {0x0000a2e4, 0x00000000},
+        {0x0000a2e8, 0x00000000},
+        {0x0000a2ec, 0x00000000},
+        {0x0000a2f0, 0x00000000},
+        {0x0000a2f4, 0x00000000},
+        {0x0000a2f8, 0x00000000},
+        {0x0000a344, 0x00000000},
+        {0x0000a34c, 0x00000000},
+        {0x0000a350, 0x0000a000},
+        {0x0000a364, 0x00000000},
+        {0x0000a370, 0x00000000},
+        {0x0000a390, 0x00000001},
+        {0x0000a394, 0x00000444},
+        {0x0000a398, 0x001f0e0f},
+        {0x0000a39c, 0x0075393f},
+        {0x0000a3a0, 0xb79f6427},
+        {0x0000a3a4, 0x00000000},
+        {0x0000a3a8, 0xaaaaaaaa},
+        {0x0000a3ac, 0x3c466478},
+        {0x0000a3c0, 0x20202020},
+        {0x0000a3c4, 0x22222220},
+        {0x0000a3c8, 0x20200020},
+        {0x0000a3cc, 0x20202020},
+        {0x0000a3d0, 0x20202020},
+        {0x0000a3d4, 0x20202020},
+        {0x0000a3d8, 0x20202020},
+        {0x0000a3dc, 0x20202020},
+        {0x0000a3e0, 0x20202020},
+        {0x0000a3e4, 0x20202020},
+        {0x0000a3e8, 0x20202020},
+        {0x0000a3ec, 0x20202020},
+        {0x0000a3f0, 0x00000000},
+        {0x0000a3f4, 0x00000246},
+        {0x0000a3f8, 0x0cdbd380},
+        {0x0000a3fc, 0x000f0f01},
+        {0x0000a400, 0x8fa91f01},
+        {0x0000a404, 0x00000000},
+        {0x0000a408, 0x0e79e5c6},
+        {0x0000a40c, 0x00820820},
+        {0x0000a414, 0x1ce739ce},
+        {0x0000a418, 0x2d001dce},
+        {0x0000a41c, 0x1ce739ce},
+        {0x0000a420, 0x000001ce},
+        {0x0000a424, 0x1ce739ce},
+        {0x0000a428, 0x000001ce},
+        {0x0000a42c, 0x1ce739ce},
+        {0x0000a430, 0x1ce739ce},
+        {0x0000a434, 0x00000000},
+        {0x0000a438, 0x00001801},
+        {0x0000a43c, 0x00000000},
+        {0x0000a440, 0x00000000},
+        {0x0000a444, 0x00000000},
+        {0x0000a448, 0x04000080},
+        {0x0000a44c, 0x00000001},
+        {0x0000a450, 0x00010000},
+        {0x0000a458, 0x00000000},
+        {0x0000a600, 0x00000000},
+        {0x0000a604, 0x00000000},
+        {0x0000a608, 0x00000000},
+        {0x0000a60c, 0x00000000},
+        {0x0000a610, 0x00000000},
+        {0x0000a614, 0x00000000},
+        {0x0000a618, 0x00000000},
+        {0x0000a61c, 0x00000000},
+        {0x0000a620, 0x00000000},
+        {0x0000a624, 0x00000000},
+        {0x0000a628, 0x00000000},
+        {0x0000a62c, 0x00000000},
+        {0x0000a630, 0x00000000},
+        {0x0000a634, 0x00000000},
+        {0x0000a638, 0x00000000},
+        {0x0000a63c, 0x00000000},
+        {0x0000a640, 0x00000000},
+        {0x0000a644, 0x3fad9d74},
+        {0x0000a648, 0x0048060a},
+        {0x0000a64c, 0x00000637},
+        {0x0000a670, 0x03020100},
+        {0x0000a674, 0x09080504},
+        {0x0000a678, 0x0d0c0b0a},
+        {0x0000a67c, 0x13121110},
+        {0x0000a680, 0x31301514},
+        {0x0000a684, 0x35343332},
+        {0x0000a688, 0x00000036},
+        {0x0000a690, 0x00000838},
+        {0x0000a7c0, 0x00000000},
+        {0x0000a7c4, 0xfffffffc},
+        {0x0000a7c8, 0x00000000},
+        {0x0000a7cc, 0x00000000},
+        {0x0000a7d0, 0x00000000},
+        {0x0000a7d4, 0x00000004},
+        {0x0000a7dc, 0x00000000},
+        {0x0000a8d0, 0x004b6a8e},
+        {0x0000a8d4, 0x00000820},
+        {0x0000a8dc, 0x00000000},
+        {0x0000a8f0, 0x00000000},
+        {0x0000a8f4, 0x00000000},
+        {0x0000b2d0, 0x00000080},
+        {0x0000b2d4, 0x00000000},
+        {0x0000b2dc, 0x00000000},
+        {0x0000b2e0, 0x00000000},
+        {0x0000b2e4, 0x00000000},
+        {0x0000b2e8, 0x00000000},
+        {0x0000b2ec, 0x00000000},
+        {0x0000b2f0, 0x00000000},
+        {0x0000b2f4, 0x00000000},
+        {0x0000b2f8, 0x00000000},
+        {0x0000b408, 0x0e79e5c0},
+        {0x0000b40c, 0x00820820},
+        {0x0000b420, 0x00000000},
+};
+static const u32 ar9340Modes_high_power_tx_gain_table_1p0[][5] = {
+        /*  Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20  */
+        {0x0000a410, 0x000050d8, 0x000050d8, 0x000050d9, 0x000050d9},
+        {0x0000a500, 0x00002220, 0x00002220, 0x00000000, 0x00000000},
+        {0x0000a504, 0x04002222, 0x04002222, 0x04000002, 0x04000002},
+        {0x0000a508, 0x09002421, 0x09002421, 0x08000004, 0x08000004},
+        {0x0000a50c, 0x0d002621, 0x0d002621, 0x0b000200, 0x0b000200},
+        {0x0000a510, 0x13004620, 0x13004620, 0x0f000202, 0x0f000202},
+        {0x0000a514, 0x19004a20, 0x19004a20, 0x11000400, 0x11000400},
+        {0x0000a518, 0x1d004e20, 0x1d004e20, 0x15000402, 0x15000402},
+        {0x0000a51c, 0x21005420, 0x21005420, 0x19000404, 0x19000404},
+        {0x0000a520, 0x26005e20, 0x26005e20, 0x1b000603, 0x1b000603},
+        {0x0000a524, 0x2b005e40, 0x2b005e40, 0x1f000a02, 0x1f000a02},
+        {0x0000a528, 0x2f005e42, 0x2f005e42, 0x23000a04, 0x23000a04},
+        {0x0000a52c, 0x33005e44, 0x33005e44, 0x26000a20, 0x26000a20},
+        {0x0000a530, 0x38005e65, 0x38005e65, 0x2a000e20, 0x2a000e20},
+        {0x0000a534, 0x3c005e69, 0x3c005e69, 0x2e000e22, 0x2e000e22},
+        {0x0000a538, 0x40005e6b, 0x40005e6b, 0x31000e24, 0x31000e24},
+        {0x0000a53c, 0x44005e6d, 0x44005e6d, 0x34001640, 0x34001640},
+        {0x0000a540, 0x49005e72, 0x49005e72, 0x38001660, 0x38001660},
+        {0x0000a544, 0x4e005eb2, 0x4e005eb2, 0x3b001861, 0x3b001861},
+        {0x0000a548, 0x53005f12, 0x53005f12, 0x3e001a81, 0x3e001a81},
+        {0x0000a54c, 0x59025eb5, 0x59025eb5, 0x42001a83, 0x42001a83},
+        {0x0000a550, 0x5e025f12, 0x5e025f12, 0x44001c84, 0x44001c84},
+        {0x0000a554, 0x61027f12, 0x61027f12, 0x48001ce3, 0x48001ce3},
+        {0x0000a558, 0x6702bf12, 0x6702bf12, 0x4c001ce5, 0x4c001ce5},
+        {0x0000a55c, 0x6b02bf14, 0x6b02bf14, 0x50001ce9, 0x50001ce9},
+        {0x0000a560, 0x6f02bf16, 0x6f02bf16, 0x54001ceb, 0x54001ceb},
+        {0x0000a564, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a568, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a56c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a570, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a574, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a578, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a57c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a580, 0x00802220, 0x00802220, 0x00800000, 0x00800000},
+        {0x0000a584, 0x04802222, 0x04802222, 0x04800002, 0x04800002},
+        {0x0000a588, 0x09802421, 0x09802421, 0x08800004, 0x08800004},
+        {0x0000a58c, 0x0d802621, 0x0d802621, 0x0b800200, 0x0b800200},
+        {0x0000a590, 0x13804620, 0x13804620, 0x0f800202, 0x0f800202},
+        {0x0000a594, 0x19804a20, 0x19804a20, 0x11800400, 0x11800400},
+        {0x0000a598, 0x1d804e20, 0x1d804e20, 0x15800402, 0x15800402},
+        {0x0000a59c, 0x21805420, 0x21805420, 0x19800404, 0x19800404},
+        {0x0000a5a0, 0x26805e20, 0x26805e20, 0x1b800603, 0x1b800603},
+        {0x0000a5a4, 0x2b805e40, 0x2b805e40, 0x1f800a02, 0x1f800a02},
+        {0x0000a5a8, 0x2f805e42, 0x2f805e42, 0x23800a04, 0x23800a04},
+        {0x0000a5ac, 0x33805e44, 0x33805e44, 0x26800a20, 0x26800a20},
+        {0x0000a5b0, 0x38805e65, 0x38805e65, 0x2a800e20, 0x2a800e20},
+        {0x0000a5b4, 0x3c805e69, 0x3c805e69, 0x2e800e22, 0x2e800e22},
+        {0x0000a5b8, 0x40805e6b, 0x40805e6b, 0x31800e24, 0x31800e24},
+        {0x0000a5bc, 0x44805e6d, 0x44805e6d, 0x34801640, 0x34801640},
+        {0x0000a5c0, 0x49805e72, 0x49805e72, 0x38801660, 0x38801660},
+        {0x0000a5c4, 0x4e805eb2, 0x4e805eb2, 0x3b801861, 0x3b801861},
+        {0x0000a5c8, 0x53805f12, 0x53805f12, 0x3e801a81, 0x3e801a81},
+        {0x0000a5cc, 0x59825eb2, 0x59825eb2, 0x42801a83, 0x42801a83},
+        {0x0000a5d0, 0x5e825f12, 0x5e825f12, 0x44801c84, 0x44801c84},
+        {0x0000a5d4, 0x61827f12, 0x61827f12, 0x48801ce3, 0x48801ce3},
+        {0x0000a5d8, 0x6782bf12, 0x6782bf12, 0x4c801ce5, 0x4c801ce5},
+        {0x0000a5dc, 0x6b82bf14, 0x6b82bf14, 0x50801ce9, 0x50801ce9},
+        {0x0000a5e0, 0x6f82bf16, 0x6f82bf16, 0x54801ceb, 0x54801ceb},
+        {0x0000a5e4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5e8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5ec, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5f0, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5f4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5f8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5fc, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x00016044, 0x056db2db, 0x056db2db, 0x056db2db, 0x056db2db},
+        {0x00016048, 0x24925266, 0x24925266, 0x24925266, 0x24925266},
+        {0x00016444, 0x056db2db, 0x056db2db, 0x056db2db, 0x056db2db},
+        {0x00016448, 0x24925266, 0x24925266, 0x24925266, 0x24925266},
+};
+static const u32 ar9340Modes_high_ob_db_tx_gain_table_1p0[][5] = {
+        /*  Addr       5G_HT20    5G_HT40     2G_HT40     2G_HT20  */
+        {0x0000a410, 0x000050d8, 0x000050d8, 0x000050d9, 0x000050d9},
+        {0x0000a500, 0x00002220, 0x00002220, 0x00000000, 0x00000000},
+        {0x0000a504, 0x04002222, 0x04002222, 0x04000002, 0x04000002},
+        {0x0000a508, 0x09002421, 0x09002421, 0x08000004, 0x08000004},
+        {0x0000a50c, 0x0d002621, 0x0d002621, 0x0b000200, 0x0b000200},
+        {0x0000a510, 0x13004620, 0x13004620, 0x0f000202, 0x0f000202},
+        {0x0000a514, 0x19004a20, 0x19004a20, 0x11000400, 0x11000400},
+        {0x0000a518, 0x1d004e20, 0x1d004e20, 0x15000402, 0x15000402},
+        {0x0000a51c, 0x21005420, 0x21005420, 0x19000404, 0x19000404},
+        {0x0000a520, 0x26005e20, 0x26005e20, 0x1b000603, 0x1b000603},
+        {0x0000a524, 0x2b005e40, 0x2b005e40, 0x1f000a02, 0x1f000a02},
+        {0x0000a528, 0x2f005e42, 0x2f005e42, 0x23000a04, 0x23000a04},
+        {0x0000a52c, 0x33005e44, 0x33005e44, 0x26000a20, 0x26000a20},
+        {0x0000a530, 0x38005e65, 0x38005e65, 0x2a000e20, 0x2a000e20},
+        {0x0000a534, 0x3c005e69, 0x3c005e69, 0x2e000e22, 0x2e000e22},
+        {0x0000a538, 0x40005e6b, 0x40005e6b, 0x31000e24, 0x31000e24},
+        {0x0000a53c, 0x44005e6d, 0x44005e6d, 0x34001640, 0x34001640},
+        {0x0000a540, 0x49005e72, 0x49005e72, 0x38001660, 0x38001660},
+        {0x0000a544, 0x4e005eb2, 0x4e005eb2, 0x3b001861, 0x3b001861},
+        {0x0000a548, 0x53005f12, 0x53005f12, 0x3e001a81, 0x3e001a81},
+        {0x0000a54c, 0x59025eb5, 0x59025eb5, 0x42001a83, 0x42001a83},
+        {0x0000a550, 0x5e025f12, 0x5e025f12, 0x44001c84, 0x44001c84},
+        {0x0000a554, 0x61027f12, 0x61027f12, 0x48001ce3, 0x48001ce3},
+        {0x0000a558, 0x6702bf12, 0x6702bf12, 0x4c001ce5, 0x4c001ce5},
+        {0x0000a55c, 0x6b02bf14, 0x6b02bf14, 0x50001ce9, 0x50001ce9},
+        {0x0000a560, 0x6f02bf16, 0x6f02bf16, 0x54001ceb, 0x54001ceb},
+        {0x0000a564, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a568, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a56c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a570, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a574, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a578, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a57c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a580, 0x00802220, 0x00802220, 0x00800000, 0x00800000},
+        {0x0000a584, 0x04802222, 0x04802222, 0x04800002, 0x04800002},
+        {0x0000a588, 0x09802421, 0x09802421, 0x08800004, 0x08800004},
+        {0x0000a58c, 0x0d802621, 0x0d802621, 0x0b800200, 0x0b800200},
+        {0x0000a590, 0x13804620, 0x13804620, 0x0f800202, 0x0f800202},
+        {0x0000a594, 0x19804a20, 0x19804a20, 0x11800400, 0x11800400},
+        {0x0000a598, 0x1d804e20, 0x1d804e20, 0x15800402, 0x15800402},
+        {0x0000a59c, 0x21805420, 0x21805420, 0x19800404, 0x19800404},
+        {0x0000a5a0, 0x26805e20, 0x26805e20, 0x1b800603, 0x1b800603},
+        {0x0000a5a4, 0x2b805e40, 0x2b805e40, 0x1f800a02, 0x1f800a02},
+        {0x0000a5a8, 0x2f805e42, 0x2f805e42, 0x23800a04, 0x23800a04},
+        {0x0000a5ac, 0x33805e44, 0x33805e44, 0x26800a20, 0x26800a20},
+        {0x0000a5b0, 0x38805e65, 0x38805e65, 0x2a800e20, 0x2a800e20},
+        {0x0000a5b4, 0x3c805e69, 0x3c805e69, 0x2e800e22, 0x2e800e22},
+        {0x0000a5b8, 0x40805e6b, 0x40805e6b, 0x31800e24, 0x31800e24},
+        {0x0000a5bc, 0x44805e6d, 0x44805e6d, 0x34801640, 0x34801640},
+        {0x0000a5c0, 0x49805e72, 0x49805e72, 0x38801660, 0x38801660},
+        {0x0000a5c4, 0x4e805eb2, 0x4e805eb2, 0x3b801861, 0x3b801861},
+        {0x0000a5c8, 0x53805f12, 0x53805f12, 0x3e801a81, 0x3e801a81},
+        {0x0000a5cc, 0x59825eb2, 0x59825eb2, 0x42801a83, 0x42801a83},
+        {0x0000a5d0, 0x5e825f12, 0x5e825f12, 0x44801c84, 0x44801c84},
+        {0x0000a5d4, 0x61827f12, 0x61827f12, 0x48801ce3, 0x48801ce3},
+        {0x0000a5d8, 0x6782bf12, 0x6782bf12, 0x4c801ce5, 0x4c801ce5},
+        {0x0000a5dc, 0x6b82bf14, 0x6b82bf14, 0x50801ce9, 0x50801ce9},
+        {0x0000a5e0, 0x6f82bf16, 0x6f82bf16, 0x54801ceb, 0x54801ceb},
+        {0x0000a5e4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5e8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5ec, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5f0, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5f4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5f8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5fc, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x00016044, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4},
+        {0x00016048, 0x8e481266, 0x8e481266, 0x8e481266, 0x8e481266},
+        {0x00016444, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4},
+        {0x00016448, 0x8e481266, 0x8e481266, 0x8e481266, 0x8e481266},
+};
+static const u32 ar9340Modes_ub124_tx_gain_table_1p0[][5] = {
+        /*  Addr      5G_HT20      5G_HT40     2G_HT40    2G_HT20  */
+        {0x0000a410, 0x000050d8, 0x000050d8, 0x000050d9, 0x000050d9},
+        {0x0000a500, 0x00002220, 0x00002220, 0x00000000, 0x00000000},
+        {0x0000a504, 0x04002222, 0x04002222, 0x04000002, 0x04000002},
+        {0x0000a508, 0x09002421, 0x09002421, 0x08000004, 0x08000004},
+        {0x0000a50c, 0x0d002621, 0x0d002621, 0x0b000200, 0x0b000200},
+        {0x0000a510, 0x13004620, 0x13004620, 0x0f000202, 0x0f000202},
+        {0x0000a514, 0x19004a20, 0x19004a20, 0x11000400, 0x11000400},
+        {0x0000a518, 0x1d004e20, 0x1d004e20, 0x15000402, 0x15000402},
+        {0x0000a51c, 0x21005420, 0x21005420, 0x19000404, 0x19000404},
+        {0x0000a520, 0x26005e20, 0x26005e20, 0x1b000603, 0x1b000603},
+        {0x0000a524, 0x2b005e40, 0x2b005e40, 0x1f000a02, 0x1f000a02},
+        {0x0000a528, 0x2f005e42, 0x2f005e42, 0x23000a04, 0x23000a04},
+        {0x0000a52c, 0x33005e44, 0x33005e44, 0x26000a20, 0x26000a20},
+        {0x0000a530, 0x38005e65, 0x38005e65, 0x2a000e20, 0x2a000e20},
+        {0x0000a534, 0x3c005e69, 0x3c005e69, 0x2e000e22, 0x2e000e22},
+        {0x0000a538, 0x40005e6b, 0x40005e6b, 0x31000e24, 0x31000e24},
+        {0x0000a53c, 0x44005e6d, 0x44005e6d, 0x34001640, 0x34001640},
+        {0x0000a540, 0x49005e72, 0x49005e72, 0x38001660, 0x38001660},
+        {0x0000a544, 0x4e005eb2, 0x4e005eb2, 0x3b001861, 0x3b001861},
+        {0x0000a548, 0x53005f12, 0x53005f12, 0x3e001a81, 0x3e001a81},
+        {0x0000a54c, 0x59025eb5, 0x59025eb5, 0x42001a83, 0x42001a83},
+        {0x0000a550, 0x5e025f12, 0x5e025f12, 0x44001c84, 0x44001c84},
+        {0x0000a554, 0x61027f12, 0x61027f12, 0x48001ce3, 0x48001ce3},
+        {0x0000a558, 0x6702bf12, 0x6702bf12, 0x4c001ce5, 0x4c001ce5},
+        {0x0000a55c, 0x6b02bf14, 0x6b02bf14, 0x50001ce9, 0x50001ce9},
+        {0x0000a560, 0x6f02bf16, 0x6f02bf16, 0x54001ceb, 0x54001ceb},
+        {0x0000a564, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a568, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a56c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a570, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a574, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a578, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a57c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
+        {0x0000a580, 0x00802220, 0x00802220, 0x00800000, 0x00800000},
+        {0x0000a584, 0x04802222, 0x04802222, 0x04800002, 0x04800002},
+        {0x0000a588, 0x09802421, 0x09802421, 0x08800004, 0x08800004},
+        {0x0000a58c, 0x0d802621, 0x0d802621, 0x0b800200, 0x0b800200},
+        {0x0000a590, 0x13804620, 0x13804620, 0x0f800202, 0x0f800202},
+        {0x0000a594, 0x19804a20, 0x19804a20, 0x11800400, 0x11800400},
+        {0x0000a598, 0x1d804e20, 0x1d804e20, 0x15800402, 0x15800402},
+        {0x0000a59c, 0x21805420, 0x21805420, 0x19800404, 0x19800404},
+        {0x0000a5a0, 0x26805e20, 0x26805e20, 0x1b800603, 0x1b800603},
+        {0x0000a5a4, 0x2b805e40, 0x2b805e40, 0x1f800a02, 0x1f800a02},
+        {0x0000a5a8, 0x2f805e42, 0x2f805e42, 0x23800a04, 0x23800a04},
+        {0x0000a5ac, 0x33805e44, 0x33805e44, 0x26800a20, 0x26800a20},
+        {0x0000a5b0, 0x38805e65, 0x38805e65, 0x2a800e20, 0x2a800e20},
+        {0x0000a5b4, 0x3c805e69, 0x3c805e69, 0x2e800e22, 0x2e800e22},
+        {0x0000a5b8, 0x40805e6b, 0x40805e6b, 0x31800e24, 0x31800e24},
+        {0x0000a5bc, 0x44805e6d, 0x44805e6d, 0x34801640, 0x34801640},
+        {0x0000a5c0, 0x49805e72, 0x49805e72, 0x38801660, 0x38801660},
+        {0x0000a5c4, 0x4e805eb2, 0x4e805eb2, 0x3b801861, 0x3b801861},
+        {0x0000a5c8, 0x53805f12, 0x53805f12, 0x3e801a81, 0x3e801a81},
+        {0x0000a5cc, 0x59825eb2, 0x59825eb2, 0x42801a83, 0x42801a83},
+        {0x0000a5d0, 0x5e825f12, 0x5e825f12, 0x44801c84, 0x44801c84},
+        {0x0000a5d4, 0x61827f12, 0x61827f12, 0x48801ce3, 0x48801ce3},
+        {0x0000a5d8, 0x6782bf12, 0x6782bf12, 0x4c801ce5, 0x4c801ce5},
+        {0x0000a5dc, 0x6b82bf14, 0x6b82bf14, 0x50801ce9, 0x50801ce9},
+        {0x0000a5e0, 0x6f82bf16, 0x6f82bf16, 0x54801ceb, 0x54801ceb},
+        {0x0000a5e4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5e8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5ec, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5f0, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5f4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5f8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x0000a5fc, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
+        {0x00016044, 0x036db2db, 0x036db2db, 0x036db2db, 0x036db2db},
+        {0x00016048, 0x69b65266, 0x69b65266, 0x69b65266, 0x69b65266},
+        {0x00016444, 0x036db2db, 0x036db2db, 0x036db2db, 0x036db2db},
+        {0x00016448, 0x69b65266, 0x69b65266, 0x69b65266, 0x69b65266},
+};
+static const u32 ar9340Common_rx_gain_table_1p0[][2] = {
+        /*   Addr     allmodes */
+        {0x0000a000, 0x00010000},
+        {0x0000a004, 0x00030002},
+        {0x0000a008, 0x00050004},
+        {0x0000a00c, 0x00810080},
+        {0x0000a010, 0x00830082},
+        {0x0000a014, 0x01810180},
+        {0x0000a018, 0x01830182},
+        {0x0000a01c, 0x01850184},
+        {0x0000a020, 0x01890188},
+        {0x0000a024, 0x018b018a},
+        {0x0000a028, 0x018d018c},
+        {0x0000a02c, 0x01910190},
+        {0x0000a030, 0x01930192},
+        {0x0000a034, 0x01950194},
+        {0x0000a038, 0x038a0196},
+        {0x0000a03c, 0x038c038b},
+        {0x0000a040, 0x0390038d},
+        {0x0000a044, 0x03920391},
+        {0x0000a048, 0x03940393},
+        {0x0000a04c, 0x03960395},
+        {0x0000a050, 0x00000000},
+        {0x0000a054, 0x00000000},
+        {0x0000a058, 0x00000000},
+        {0x0000a05c, 0x00000000},
+        {0x0000a060, 0x00000000},
+        {0x0000a064, 0x00000000},
+        {0x0000a068, 0x00000000},
+        {0x0000a06c, 0x00000000},
+        {0x0000a070, 0x00000000},
+        {0x0000a074, 0x00000000},
+        {0x0000a078, 0x00000000},
+        {0x0000a07c, 0x00000000},
+        {0x0000a080, 0x22222229},
+        {0x0000a084, 0x1d1d1d1d},
+        {0x0000a088, 0x1d1d1d1d},
+        {0x0000a08c, 0x1d1d1d1d},
+        {0x0000a090, 0x171d1d1d},
+        {0x0000a094, 0x11111717},
+        {0x0000a098, 0x00030311},
+        {0x0000a09c, 0x00000000},
+        {0x0000a0a0, 0x00000000},
+        {0x0000a0a4, 0x00000000},
+        {0x0000a0a8, 0x00000000},
+        {0x0000a0ac, 0x00000000},
+        {0x0000a0b0, 0x00000000},
+        {0x0000a0b4, 0x00000000},
+        {0x0000a0b8, 0x00000000},
+        {0x0000a0bc, 0x00000000},
+        {0x0000a0c0, 0x001f0000},
+        {0x0000a0c4, 0x01000101},
+        {0x0000a0c8, 0x011e011f},
+        {0x0000a0cc, 0x011c011d},
+        {0x0000a0d0, 0x02030204},
+        {0x0000a0d4, 0x02010202},
+        {0x0000a0d8, 0x021f0200},
+        {0x0000a0dc, 0x0302021e},
+        {0x0000a0e0, 0x03000301},
+        {0x0000a0e4, 0x031e031f},
+        {0x0000a0e8, 0x0402031d},
+        {0x0000a0ec, 0x04000401},
+        {0x0000a0f0, 0x041e041f},
+        {0x0000a0f4, 0x0502041d},
+        {0x0000a0f8, 0x05000501},
+        {0x0000a0fc, 0x051e051f},
+        {0x0000a100, 0x06010602},
+        {0x0000a104, 0x061f0600},
+        {0x0000a108, 0x061d061e},
+        {0x0000a10c, 0x07020703},
+        {0x0000a110, 0x07000701},
+        {0x0000a114, 0x00000000},
+        {0x0000a118, 0x00000000},
+        {0x0000a11c, 0x00000000},
+        {0x0000a120, 0x00000000},
+        {0x0000a124, 0x00000000},
+        {0x0000a128, 0x00000000},
+        {0x0000a12c, 0x00000000},
+        {0x0000a130, 0x00000000},
+        {0x0000a134, 0x00000000},
+        {0x0000a138, 0x00000000},
+        {0x0000a13c, 0x00000000},
+        {0x0000a140, 0x001f0000},
+        {0x0000a144, 0x01000101},
+        {0x0000a148, 0x011e011f},
+        {0x0000a14c, 0x011c011d},
+        {0x0000a150, 0x02030204},
+        {0x0000a154, 0x02010202},
+        {0x0000a158, 0x021f0200},
+        {0x0000a15c, 0x0302021e},
+        {0x0000a160, 0x03000301},
+        {0x0000a164, 0x031e031f},
+        {0x0000a168, 0x0402031d},
+        {0x0000a16c, 0x04000401},
+        {0x0000a170, 0x041e041f},
+        {0x0000a174, 0x0502041d},
+        {0x0000a178, 0x05000501},
+        {0x0000a17c, 0x051e051f},
+        {0x0000a180, 0x06010602},
+        {0x0000a184, 0x061f0600},
+        {0x0000a188, 0x061d061e},
+        {0x0000a18c, 0x07020703},
+        {0x0000a190, 0x07000701},
+        {0x0000a194, 0x00000000},
+        {0x0000a198, 0x00000000},
+        {0x0000a19c, 0x00000000},
+        {0x0000a1a0, 0x00000000},
+        {0x0000a1a4, 0x00000000},
+        {0x0000a1a8, 0x00000000},
+        {0x0000a1ac, 0x00000000},
+        {0x0000a1b0, 0x00000000},
+        {0x0000a1b4, 0x00000000},
+        {0x0000a1b8, 0x00000000},
+        {0x0000a1bc, 0x00000000},
+        {0x0000a1c0, 0x00000000},
+        {0x0000a1c4, 0x00000000},
+        {0x0000a1c8, 0x00000000},
+        {0x0000a1cc, 0x00000000},
+        {0x0000a1d0, 0x00000000},
+        {0x0000a1d4, 0x00000000},
+        {0x0000a1d8, 0x00000000},
+        {0x0000a1dc, 0x00000000},
+        {0x0000a1e0, 0x00000000},
+        {0x0000a1e4, 0x00000000},
+        {0x0000a1e8, 0x00000000},
+        {0x0000a1ec, 0x00000000},
+        {0x0000a1f0, 0x00000396},
+        {0x0000a1f4, 0x00000396},
+        {0x0000a1f8, 0x00000396},
+        {0x0000a1fc, 0x00000196},
+        {0x0000b000, 0x00010000},
+        {0x0000b004, 0x00030002},
+        {0x0000b008, 0x00050004},
+        {0x0000b00c, 0x00810080},
+        {0x0000b010, 0x00830082},
+        {0x0000b014, 0x01810180},
+        {0x0000b018, 0x01830182},
+        {0x0000b01c, 0x01850184},
+        {0x0000b020, 0x02810280},
+        {0x0000b024, 0x02830282},
+        {0x0000b028, 0x02850284},
+        {0x0000b02c, 0x02890288},
+        {0x0000b030, 0x028b028a},
+        {0x0000b034, 0x0388028c},
+        {0x0000b038, 0x038a0389},
+        {0x0000b03c, 0x038c038b},
+        {0x0000b040, 0x0390038d},
+        {0x0000b044, 0x03920391},
+        {0x0000b048, 0x03940393},
+        {0x0000b04c, 0x03960395},
+        {0x0000b050, 0x00000000},
+        {0x0000b054, 0x00000000},
+        {0x0000b058, 0x00000000},
+        {0x0000b05c, 0x00000000},
+        {0x0000b060, 0x00000000},
+        {0x0000b064, 0x00000000},
+        {0x0000b068, 0x00000000},
+        {0x0000b06c, 0x00000000},
+        {0x0000b070, 0x00000000},
+        {0x0000b074, 0x00000000},
+        {0x0000b078, 0x00000000},
+        {0x0000b07c, 0x00000000},
+        {0x0000b080, 0x32323232},
+        {0x0000b084, 0x2f2f3232},
+        {0x0000b088, 0x23282a2d},
+        {0x0000b08c, 0x1c1e2123},
+        {0x0000b090, 0x14171919},
+        {0x0000b094, 0x0e0e1214},
+        {0x0000b098, 0x03050707},
+        {0x0000b09c, 0x00030303},
+        {0x0000b0a0, 0x00000000},
+        {0x0000b0a4, 0x00000000},
+        {0x0000b0a8, 0x00000000},
+        {0x0000b0ac, 0x00000000},
+        {0x0000b0b0, 0x00000000},
+        {0x0000b0b4, 0x00000000},
+        {0x0000b0b8, 0x00000000},
+        {0x0000b0bc, 0x00000000},
+        {0x0000b0c0, 0x003f0020},
+        {0x0000b0c4, 0x00400041},
+        {0x0000b0c8, 0x0140005f},
+        {0x0000b0cc, 0x0160015f},
+        {0x0000b0d0, 0x017e017f},
+        {0x0000b0d4, 0x02410242},
+        {0x0000b0d8, 0x025f0240},
+        {0x0000b0dc, 0x027f0260},
+        {0x0000b0e0, 0x0341027e},
+        {0x0000b0e4, 0x035f0340},
+        {0x0000b0e8, 0x037f0360},
+        {0x0000b0ec, 0x04400441},
+        {0x0000b0f0, 0x0460045f},
+        {0x0000b0f4, 0x0541047f},
+        {0x0000b0f8, 0x055f0540},
+        {0x0000b0fc, 0x057f0560},
+        {0x0000b100, 0x06400641},
+        {0x0000b104, 0x0660065f},
+        {0x0000b108, 0x067e067f},
+        {0x0000b10c, 0x07410742},
+        {0x0000b110, 0x075f0740},
+        {0x0000b114, 0x077f0760},
+        {0x0000b118, 0x07800781},
+        {0x0000b11c, 0x07a0079f},
+        {0x0000b120, 0x07c107bf},
+        {0x0000b124, 0x000007c0},
+        {0x0000b128, 0x00000000},
+        {0x0000b12c, 0x00000000},
+        {0x0000b130, 0x00000000},
+        {0x0000b134, 0x00000000},
+        {0x0000b138, 0x00000000},
+        {0x0000b13c, 0x00000000},
+        {0x0000b140, 0x003f0020},
+        {0x0000b144, 0x00400041},
+        {0x0000b148, 0x0140005f},
+        {0x0000b14c, 0x0160015f},
+        {0x0000b150, 0x017e017f},
+        {0x0000b154, 0x02410242},
+        {0x0000b158, 0x025f0240},
+        {0x0000b15c, 0x027f0260},
+        {0x0000b160, 0x0341027e},
+        {0x0000b164, 0x035f0340},
+        {0x0000b168, 0x037f0360},
+        {0x0000b16c, 0x04400441},
+        {0x0000b170, 0x0460045f},
+        {0x0000b174, 0x0541047f},
+        {0x0000b178, 0x055f0540},
+        {0x0000b17c, 0x057f0560},
+        {0x0000b180, 0x06400641},
+        {0x0000b184, 0x0660065f},
+        {0x0000b188, 0x067e067f},
+        {0x0000b18c, 0x07410742},
+        {0x0000b190, 0x075f0740},
+        {0x0000b194, 0x077f0760},
+        {0x0000b198, 0x07800781},
+        {0x0000b19c, 0x07a0079f},
+        {0x0000b1a0, 0x07c107bf},
+        {0x0000b1a4, 0x000007c0},
+        {0x0000b1a8, 0x00000000},
+        {0x0000b1ac, 0x00000000},
+        {0x0000b1b0, 0x00000000},
+        {0x0000b1b4, 0x00000000},
+        {0x0000b1b8, 0x00000000},
+        {0x0000b1bc, 0x00000000},
+        {0x0000b1c0, 0x00000000},
+        {0x0000b1c4, 0x00000000},
+        {0x0000b1c8, 0x00000000},
+        {0x0000b1cc, 0x00000000},
+        {0x0000b1d0, 0x00000000},
+        {0x0000b1d4, 0x00000000},
+        {0x0000b1d8, 0x00000000},
+        {0x0000b1dc, 0x00000000},
+        {0x0000b1e0, 0x00000000},
+        {0x0000b1e4, 0x00000000},
+        {0x0000b1e8, 0x00000000},
+        {0x0000b1ec, 0x00000000},
+        {0x0000b1f0, 0x00000396},
+        {0x0000b1f4, 0x00000396},
+        {0x0000b1f8, 0x00000396},
+        {0x0000b1fc, 0x00000196},
+};
+static const u32 ar9340Modes_low_ob_db_tx_gain_table_1p0[][5] = {
+        /*  Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20  */
+        {0x0000a410, 0x000050d9, 0x000050d9, 0x000050d9, 0x000050d9},
+        {0x0000a500, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000a504, 0x06000003, 0x06000003, 0x04000002, 0x04000002},
+        {0x0000a508, 0x0a000020, 0x0a000020, 0x08000004, 0x08000004},
+        {0x0000a50c, 0x10000023, 0x10000023, 0x0b000200, 0x0b000200},
+        {0x0000a510, 0x16000220, 0x16000220, 0x0f000202, 0x0f000202},
+        {0x0000a514, 0x1c000223, 0x1c000223, 0x12000400, 0x12000400},
+        {0x0000a518, 0x21020220, 0x21020220, 0x16000402, 0x16000402},
+        {0x0000a51c, 0x27020223, 0x27020223, 0x19000404, 0x19000404},
+        {0x0000a520, 0x2b022220, 0x2b022220, 0x1c000603, 0x1c000603},
+        {0x0000a524, 0x2f022222, 0x2f022222, 0x21000a02, 0x21000a02},
+        {0x0000a528, 0x34022225, 0x34022225, 0x25000a04, 0x25000a04},
+        {0x0000a52c, 0x3a02222a, 0x3a02222a, 0x28000a20, 0x28000a20},
+        {0x0000a530, 0x3e02222c, 0x3e02222c, 0x2c000e20, 0x2c000e20},
+        {0x0000a534, 0x4202242a, 0x4202242a, 0x30000e22, 0x30000e22},
+        {0x0000a538, 0x4702244a, 0x4702244a, 0x34000e24, 0x34000e24},
+        {0x0000a53c, 0x4b02244c, 0x4b02244c, 0x38001640, 0x38001640},
+        {0x0000a540, 0x4e02246c, 0x4e02246c, 0x3c001660, 0x3c001660},
+        {0x0000a544, 0x5302266c, 0x5302266c, 0x3f001861, 0x3f001861},
+        {0x0000a548, 0x5702286c, 0x5702286c, 0x43001a81, 0x43001a81},
+        {0x0000a54c, 0x5c04286b, 0x5c04286b, 0x47001a83, 0x47001a83},
+        {0x0000a550, 0x61042a6c, 0x61042a6c, 0x4a001c84, 0x4a001c84},
+        {0x0000a554, 0x66062a6c, 0x66062a6c, 0x4e001ce3, 0x4e001ce3},
+        {0x0000a558, 0x6b062e6c, 0x6b062e6c, 0x52001ce5, 0x52001ce5},
+        {0x0000a55c, 0x7006308c, 0x7006308c, 0x56001ce9, 0x56001ce9},
+        {0x0000a560, 0x730a308a, 0x730a308a, 0x5a001ceb, 0x5a001ceb},
+        {0x0000a564, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a568, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a56c, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a570, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a574, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a578, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a57c, 0x770a308c, 0x770a308c, 0x5d001eec, 0x5d001eec},
+        {0x0000a580, 0x00800000, 0x00800000, 0x00800000, 0x00800000},
+        {0x0000a584, 0x06800003, 0x06800003, 0x04800002, 0x04800002},
+        {0x0000a588, 0x0a800020, 0x0a800020, 0x08800004, 0x08800004},
+        {0x0000a58c, 0x10800023, 0x10800023, 0x0b800200, 0x0b800200},
+        {0x0000a590, 0x16800220, 0x16800220, 0x0f800202, 0x0f800202},
+        {0x0000a594, 0x1c800223, 0x1c800223, 0x12800400, 0x12800400},
+        {0x0000a598, 0x21820220, 0x21820220, 0x16800402, 0x16800402},
+        {0x0000a59c, 0x27820223, 0x27820223, 0x19800404, 0x19800404},
+        {0x0000a5a0, 0x2b822220, 0x2b822220, 0x1c800603, 0x1c800603},
+        {0x0000a5a4, 0x2f822222, 0x2f822222, 0x21800a02, 0x21800a02},
+        {0x0000a5a8, 0x34822225, 0x34822225, 0x25800a04, 0x25800a04},
+        {0x0000a5ac, 0x3a82222a, 0x3a82222a, 0x28800a20, 0x28800a20},
+        {0x0000a5b0, 0x3e82222c, 0x3e82222c, 0x2c800e20, 0x2c800e20},
+        {0x0000a5b4, 0x4282242a, 0x4282242a, 0x30800e22, 0x30800e22},
+        {0x0000a5b8, 0x4782244a, 0x4782244a, 0x34800e24, 0x34800e24},
+        {0x0000a5bc, 0x4b82244c, 0x4b82244c, 0x38801640, 0x38801640},
+        {0x0000a5c0, 0x4e82246c, 0x4e82246c, 0x3c801660, 0x3c801660},
+        {0x0000a5c4, 0x5382266c, 0x5382266c, 0x3f801861, 0x3f801861},
+        {0x0000a5c8, 0x5782286c, 0x5782286c, 0x43801a81, 0x43801a81},
+        {0x0000a5cc, 0x5c84286b, 0x5c84286b, 0x47801a83, 0x47801a83},
+        {0x0000a5d0, 0x61842a6c, 0x61842a6c, 0x4a801c84, 0x4a801c84},
+        {0x0000a5d4, 0x66862a6c, 0x66862a6c, 0x4e801ce3, 0x4e801ce3},
+        {0x0000a5d8, 0x6b862e6c, 0x6b862e6c, 0x52801ce5, 0x52801ce5},
+        {0x0000a5dc, 0x7086308c, 0x7086308c, 0x56801ce9, 0x56801ce9},
+        {0x0000a5e0, 0x738a308a, 0x738a308a, 0x5a801ceb, 0x5a801ceb},
+        {0x0000a5e4, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5e8, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5ec, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5f0, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5f4, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5f8, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x0000a5fc, 0x778a308c, 0x778a308c, 0x5d801eec, 0x5d801eec},
+        {0x00016044, 0x056db2db, 0x056db2db, 0x056db2db, 0x056db2db},
+        {0x00016048, 0x24925266, 0x24925266, 0x24925266, 0x24925266},
+        {0x00016444, 0x056db2db, 0x056db2db, 0x056db2db, 0x056db2db},
+        {0x00016448, 0x24925266, 0x24925266, 0x24925266, 0x24925266},
+};
+static const u32 ar9340Modes_mixed_ob_db_tx_gain_table_1p0[][5] = {
+        /*  Addr       5G_HT20     5G_HT40     2G_HT40    2G_HT20  */
+        {0x0000a410, 0x000050d9, 0x000050d9, 0x000050d9, 0x000050d9},
+        {0x0000a500, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
+        {0x0000a504, 0x06000003, 0x06000003, 0x04000002, 0x04000002},
+        {0x0000a508, 0x0a000020, 0x0a000020, 0x08000004, 0x08000004},
+        {0x0000a50c, 0x10000023, 0x10000023, 0x0b000200, 0x0b000200},
+        {0x0000a510, 0x16000220, 0x16000220, 0x0f000202, 0x0f000202},
+        {0x0000a514, 0x1c000223, 0x1c000223, 0x11000400, 0x11000400},
+        {0x0000a518, 0x21020220, 0x21020220, 0x15000402, 0x15000402},
+        {0x0000a51c, 0x27020223, 0x27020223, 0x19000404, 0x19000404},
+        {0x0000a520, 0x2b022220, 0x2b022220, 0x1b000603, 0x1b000603},
+        {0x0000a524, 0x2f022222, 0x2f022222, 0x1f000a02, 0x1f000a02},
+        {0x0000a528, 0x34022225, 0x34022225, 0x23000a04, 0x23000a04},
+        {0x0000a52c, 0x3a02222a, 0x3a02222a, 0x26000a20, 0x26000a20},
+        {0x0000a530, 0x3e02222c, 0x3e02222c, 0x2a000e20, 0x2a000e20},
+        {0x0000a534, 0x4202242a, 0x4202242a, 0x2e000e22, 0x2e000e22},
+        {0x0000a538, 0x4702244a, 0x4702244a, 0x31000e24, 0x31000e24},
+        {0x0000a53c, 0x4b02244c, 0x4b02244c, 0x34001640, 0x34001640},
+        {0x0000a540, 0x4e02246c, 0x4e02246c, 0x38001660, 0x38001660},
+        {0x0000a544, 0x5302266c, 0x5302266c, 0x3b001861, 0x3b001861},
+        {0x0000a548, 0x5702286c, 0x5702286c, 0x3e001a81, 0x3e001a81},
+        {0x0000a54c, 0x5c04286b, 0x5c04286b, 0x42001a83, 0x42001a83},
+        {0x0000a550, 0x61042a6c, 0x61042a6c, 0x44001c84, 0x44001c84},
+        {0x0000a554, 0x66062a6c, 0x66062a6c, 0x48001ce3, 0x48001ce3},
+        {0x0000a558, 0x6b062e6c, 0x6b062e6c, 0x4c001ce5, 0x4c001ce5},
+        {0x0000a55c, 0x7006308c, 0x7006308c, 0x50001ce9, 0x50001ce9},
+        {0x0000a560, 0x730a308a, 0x730a308a, 0x54001ceb, 0x54001ceb},
+        {0x0000a564, 0x770a308c, 0x770a308c, 0x56001eec, 0x56001eec},
+        {0x0000a568, 0x770a308c, 0x770a308c, 0x56001eec, 0x56001eec},
+        {0x0000a56c, 0x770a308c, 0x770a308c, 0x56001eec, 0x56001eec},
+        {0x0000a570, 0x770a308c, 0x770a308c, 0x56001eec, 0x56001eec},
+        {0x0000a574, 0x770a308c, 0x770a308c, 0x56001eec, 0x56001eec},
+        {0x0000a578, 0x770a308c, 0x770a308c, 0x56001eec, 0x56001eec},
+        {0x0000a57c, 0x770a308c, 0x770a308c, 0x56001eec, 0x56001eec},
+        {0x0000a580, 0x00800000, 0x00800000, 0x00800000, 0x00800000},
+        {0x0000a584, 0x06800003, 0x06800003, 0x04800002, 0x04800002},
+        {0x0000a588, 0x0a800020, 0x0a800020, 0x08800004, 0x08800004},
+        {0x0000a58c, 0x10800023, 0x10800023, 0x0b800200, 0x0b800200},
+        {0x0000a590, 0x16800220, 0x16800220, 0x0f800202, 0x0f800202},
+        {0x0000a594, 0x1c800223, 0x1c800223, 0x11800400, 0x11800400},
+        {0x0000a598, 0x21820220, 0x21820220, 0x15800402, 0x15800402},
+        {0x0000a59c, 0x27820223, 0x27820223, 0x19800404, 0x19800404},
+        {0x0000a5a0, 0x2b822220, 0x2b822220, 0x1b800603, 0x1b800603},
+        {0x0000a5a4, 0x2f822222, 0x2f822222, 0x1f800a02, 0x1f800a02},
+        {0x0000a5a8, 0x34822225, 0x34822225, 0x23800a04, 0x23800a04},
+        {0x0000a5ac, 0x3a82222a, 0x3a82222a, 0x26800a20, 0x26800a20},
+        {0x0000a5b0, 0x3e82222c, 0x3e82222c, 0x2a800e20, 0x2a800e20},
+        {0x0000a5b4, 0x4282242a, 0x4282242a, 0x2e800e22, 0x2e800e22},
+        {0x0000a5b8, 0x4782244a, 0x4782244a, 0x31800e24, 0x31800e24},
+        {0x0000a5bc, 0x4b82244c, 0x4b82244c, 0x34801640, 0x34801640},
+        {0x0000a5c0, 0x4e82246c, 0x4e82246c, 0x38801660, 0x38801660},
+        {0x0000a5c4, 0x5382266c, 0x5382266c, 0x3b801861, 0x3b801861},
+        {0x0000a5c8, 0x5782286c, 0x5782286c, 0x3e801a81, 0x3e801a81},
+        {0x0000a5cc, 0x5c84286b, 0x5c84286b, 0x42801a83, 0x42801a83},
+        {0x0000a5d0, 0x61842a6c, 0x61842a6c, 0x44801c84, 0x44801c84},
+        {0x0000a5d4, 0x66862a6c, 0x66862a6c, 0x48801ce3, 0x48801ce3},
+        {0x0000a5d8, 0x6b862e6c, 0x6b862e6c, 0x4c801ce5, 0x4c801ce5},
+        {0x0000a5dc, 0x7086308c, 0x7086308c, 0x50801ce9, 0x50801ce9},
+        {0x0000a5e0, 0x738a308a, 0x738a308a, 0x54801ceb, 0x54801ceb},
+        {0x0000a5e4, 0x778a308c, 0x778a308c, 0x56801eec, 0x56801eec},
+        {0x0000a5e8, 0x778a308c, 0x778a308c, 0x56801eec, 0x56801eec},
+        {0x0000a5ec, 0x778a308c, 0x778a308c, 0x56801eec, 0x56801eec},
+        {0x0000a5f0, 0x778a308c, 0x778a308c, 0x56801eec, 0x56801eec},
+        {0x0000a5f4, 0x778a308c, 0x778a308c, 0x56801eec, 0x56801eec},
+        {0x0000a5f8, 0x778a308c, 0x778a308c, 0x56801eec, 0x56801eec},
+        {0x0000a5fc, 0x778a308c, 0x778a308c, 0x56801eec, 0x56801eec},
+        {0x00016044, 0x056db2db, 0x056db2db, 0x03b6d2e4, 0x03b6d2e4},
+        {0x00016048, 0x24927266, 0x24927266, 0x8e483266, 0x8e483266},
+        {0x00016444, 0x056db2db, 0x056db2db, 0x03b6d2e4, 0x03b6d2e4},
+        {0x00016448, 0x24927266, 0x24927266, 0x8e482266, 0x8e482266},
+};
+static const u32 ar9340_1p0_mac_core[][2] = {
+        /*    Addr        allmodes        */
+        {0x00000008, 0x00000000},
+        {0x00000030, 0x00020085},
+        {0x00000034, 0x00000005},
+        {0x00000040, 0x00000000},
+        {0x00000044, 0x00000000},
+        {0x00000048, 0x00000008},
+        {0x0000004c, 0x00000010},
+        {0x00000050, 0x00000000},
+        {0x00001040, 0x002ffc0f},
+        {0x00001044, 0x002ffc0f},
+        {0x00001048, 0x002ffc0f},
+        {0x0000104c, 0x002ffc0f},
+        {0x00001050, 0x002ffc0f},
+        {0x00001054, 0x002ffc0f},
+        {0x00001058, 0x002ffc0f},
+        {0x0000105c, 0x002ffc0f},
+        {0x00001060, 0x002ffc0f},
+        {0x00001064, 0x002ffc0f},
+        {0x000010f0, 0x00000100},
+        {0x00001270, 0x00000000},
+        {0x000012b0, 0x00000000},
+        {0x000012f0, 0x00000000},
+        {0x0000143c, 0x00000000},
+        {0x0000147c, 0x00000000},
+        {0x00008000, 0x00000000},
+        {0x00008004, 0x00000000},
+        {0x00008008, 0x00000000},
+        {0x0000800c, 0x00000000},
+        {0x00008018, 0x00000000},
+        {0x00008020, 0x00000000},
+        {0x00008038, 0x00000000},
+        {0x0000803c, 0x00000000},
+        {0x00008040, 0x00000000},
+        {0x00008044, 0x00000000},
+        {0x00008048, 0x00000000},
+        {0x0000804c, 0xffffffff},
+        {0x00008054, 0x00000000},
+        {0x00008058, 0x00000000},
+        {0x0000805c, 0x000fc78f},
+        {0x00008060, 0x0000000f},
+        {0x00008064, 0x00000000},
+        {0x00008070, 0x00000310},
+        {0x00008074, 0x00000020},
+        {0x00008078, 0x00000000},
+        {0x0000809c, 0x0000000f},
+        {0x000080a0, 0x00000000},
+        {0x000080a4, 0x02ff0000},
+        {0x000080a8, 0x0e070605},
+        {0x000080ac, 0x0000000d},
+        {0x000080b0, 0x00000000},
+        {0x000080b4, 0x00000000},
+        {0x000080b8, 0x00000000},
+        {0x000080bc, 0x00000000},
+        {0x000080c0, 0x2a800000},
+        {0x000080c4, 0x06900168},
+        {0x000080c8, 0x13881c20},
+        {0x000080cc, 0x01f40000},
+        {0x000080d0, 0x00252500},
+        {0x000080d4, 0x00a00000},
+        {0x000080d8, 0x00400000},
+        {0x000080dc, 0x00000000},
+        {0x000080e0, 0xffffffff},
+        {0x000080e4, 0x0000ffff},
+        {0x000080e8, 0x3f3f3f3f},
+        {0x000080ec, 0x00000000},
+        {0x000080f0, 0x00000000},
+        {0x000080f4, 0x00000000},
+        {0x000080fc, 0x00020000},
+        {0x00008100, 0x00000000},
+        {0x00008108, 0x00000052},
+        {0x0000810c, 0x00000000},
+        {0x00008110, 0x00000000},
+        {0x00008114, 0x000007ff},
+        {0x00008118, 0x000000aa},
+        {0x0000811c, 0x00003210},
+        {0x00008124, 0x00000000},
+        {0x00008128, 0x00000000},
+        {0x0000812c, 0x00000000},
+        {0x00008130, 0x00000000},
+        {0x00008134, 0x00000000},
+        {0x00008138, 0x00000000},
+        {0x0000813c, 0x0000ffff},
+        {0x00008144, 0xffffffff},
+        {0x00008168, 0x00000000},
+        {0x0000816c, 0x00000000},
+        {0x00008170, 0x18486200},
+        {0x00008174, 0x33332210},
+        {0x00008178, 0x00000000},
+        {0x0000817c, 0x00020000},
+        {0x000081c0, 0x00000000},
+        {0x000081c4, 0x33332210},
+        {0x000081c8, 0x00000000},
+        {0x000081cc, 0x00000000},
+        {0x000081d4, 0x00000000},
+        {0x000081ec, 0x00000000},
+        {0x000081f0, 0x00000000},
+        {0x000081f4, 0x00000000},
+        {0x000081f8, 0x00000000},
+        {0x000081fc, 0x00000000},
+        {0x00008240, 0x00100000},
+        {0x00008244, 0x0010f424},
+        {0x00008248, 0x00000800},
+        {0x0000824c, 0x0001e848},
+        {0x00008250, 0x00000000},
+        {0x00008254, 0x00000000},
+        {0x00008258, 0x00000000},
+        {0x0000825c, 0x40000000},
+        {0x00008260, 0x00080922},
+        {0x00008264, 0x9d400010},
+        {0x00008268, 0xffffffff},
+        {0x0000826c, 0x0000ffff},
+        {0x00008270, 0x00000000},
+        {0x00008274, 0x40000000},
+        {0x00008278, 0x003e4180},
+        {0x0000827c, 0x00000004},
+        {0x00008284, 0x0000002c},
+        {0x00008288, 0x0000002c},
+        {0x0000828c, 0x000000ff},
+        {0x00008294, 0x00000000},
+        {0x00008298, 0x00000000},
+        {0x0000829c, 0x00000000},
+        {0x00008300, 0x00000140},
+        {0x00008314, 0x00000000},
+        {0x0000831c, 0x0000010d},
+        {0x00008328, 0x00000000},
+        {0x0000832c, 0x00000007},
+        {0x00008330, 0x00000302},
+        {0x00008334, 0x00000700},
+        {0x00008338, 0x00ff0000},
+        {0x0000833c, 0x02400000},
+        {0x00008340, 0x000107ff},
+        {0x00008344, 0xaa48105b},
+        {0x00008348, 0x008f0000},
+        {0x0000835c, 0x00000000},
+        {0x00008360, 0xffffffff},
+        {0x00008364, 0xffffffff},
+        {0x00008368, 0x00000000},
+        {0x00008370, 0x00000000},
+        {0x00008374, 0x000000ff},
+        {0x00008378, 0x00000000},
+        {0x0000837c, 0x00000000},
+        {0x00008380, 0xffffffff},
+        {0x00008384, 0xffffffff},
+        {0x00008390, 0xffffffff},
+        {0x00008394, 0xffffffff},
+        {0x00008398, 0x00000000},
+        {0x0000839c, 0x00000000},
+        {0x000083a0, 0x00000000},
+        {0x000083a4, 0x0000fa14},
+        {0x000083a8, 0x000f0c00},
+        {0x000083ac, 0x33332210},
+        {0x000083b0, 0x33332210},
+        {0x000083b4, 0x33332210},
+        {0x000083b8, 0x33332210},
+        {0x000083bc, 0x00000000},
+        {0x000083c0, 0x00000000},
+        {0x000083c4, 0x00000000},
+        {0x000083c8, 0x00000000},
+        {0x000083cc, 0x00000200},
+        {0x000083d0, 0x000301ff},
+};
+static const u32 ar9340Common_wo_xlna_rx_gain_table_1p0[][2] = {
+        /*    Addr        allmodes        */
+        {0x0000a000, 0x00010000},
+        {0x0000a004, 0x00030002},
+        {0x0000a008, 0x00050004},
+        {0x0000a00c, 0x00810080},
+        {0x0000a010, 0x00830082},
+        {0x0000a014, 0x01810180},
+        {0x0000a018, 0x01830182},
+        {0x0000a01c, 0x01850184},
+        {0x0000a020, 0x01890188},
+        {0x0000a024, 0x018b018a},
+        {0x0000a028, 0x018d018c},
+        {0x0000a02c, 0x03820190},
+        {0x0000a030, 0x03840383},
+        {0x0000a034, 0x03880385},
+        {0x0000a038, 0x038a0389},
+        {0x0000a03c, 0x038c038b},
+        {0x0000a040, 0x0390038d},
+        {0x0000a044, 0x03920391},
+        {0x0000a048, 0x03940393},
+        {0x0000a04c, 0x03960395},
+        {0x0000a050, 0x00000000},
+        {0x0000a054, 0x00000000},
+        {0x0000a058, 0x00000000},
+        {0x0000a05c, 0x00000000},
+        {0x0000a060, 0x00000000},
+        {0x0000a064, 0x00000000},
+        {0x0000a068, 0x00000000},
+        {0x0000a06c, 0x00000000},
+        {0x0000a070, 0x00000000},
+        {0x0000a074, 0x00000000},
+        {0x0000a078, 0x00000000},
+        {0x0000a07c, 0x00000000},
+        {0x0000a080, 0x29292929},
+        {0x0000a084, 0x29292929},
+        {0x0000a088, 0x29292929},
+        {0x0000a08c, 0x29292929},
+        {0x0000a090, 0x22292929},
+        {0x0000a094, 0x1d1d2222},
+        {0x0000a098, 0x0c111117},
+        {0x0000a09c, 0x00030303},
+        {0x0000a0a0, 0x00000000},
+        {0x0000a0a4, 0x00000000},
+        {0x0000a0a8, 0x00000000},
+        {0x0000a0ac, 0x00000000},
+        {0x0000a0b0, 0x00000000},
+        {0x0000a0b4, 0x00000000},
+        {0x0000a0b8, 0x00000000},
+        {0x0000a0bc, 0x00000000},
+        {0x0000a0c0, 0x001f0000},
+        {0x0000a0c4, 0x01000101},
+        {0x0000a0c8, 0x011e011f},
+        {0x0000a0cc, 0x011c011d},
+        {0x0000a0d0, 0x02030204},
+        {0x0000a0d4, 0x02010202},
+        {0x0000a0d8, 0x021f0200},
+        {0x0000a0dc, 0x0302021e},
+        {0x0000a0e0, 0x03000301},
+        {0x0000a0e4, 0x031e031f},
+        {0x0000a0e8, 0x0402031d},
+        {0x0000a0ec, 0x04000401},
+        {0x0000a0f0, 0x041e041f},
+        {0x0000a0f4, 0x0502041d},
+        {0x0000a0f8, 0x05000501},
+        {0x0000a0fc, 0x051e051f},
+        {0x0000a100, 0x06010602},
+        {0x0000a104, 0x061f0600},
+        {0x0000a108, 0x061d061e},
+        {0x0000a10c, 0x07020703},
+        {0x0000a110, 0x07000701},
+        {0x0000a114, 0x00000000},
+        {0x0000a118, 0x00000000},
+        {0x0000a11c, 0x00000000},
+        {0x0000a120, 0x00000000},
+        {0x0000a124, 0x00000000},
+        {0x0000a128, 0x00000000},
+        {0x0000a12c, 0x00000000},
+        {0x0000a130, 0x00000000},
+        {0x0000a134, 0x00000000},
+        {0x0000a138, 0x00000000},
+        {0x0000a13c, 0x00000000},
+        {0x0000a140, 0x001f0000},
+        {0x0000a144, 0x01000101},
+        {0x0000a148, 0x011e011f},
+        {0x0000a14c, 0x011c011d},
+        {0x0000a150, 0x02030204},
+        {0x0000a154, 0x02010202},
+        {0x0000a158, 0x021f0200},
+        {0x0000a15c, 0x0302021e},
+        {0x0000a160, 0x03000301},
+        {0x0000a164, 0x031e031f},
+        {0x0000a168, 0x0402031d},
+        {0x0000a16c, 0x04000401},
+        {0x0000a170, 0x041e041f},
+        {0x0000a174, 0x0502041d},
+        {0x0000a178, 0x05000501},
+        {0x0000a17c, 0x051e051f},
+        {0x0000a180, 0x06010602},
+        {0x0000a184, 0x061f0600},
+        {0x0000a188, 0x061d061e},
+        {0x0000a18c, 0x07020703},
+        {0x0000a190, 0x07000701},
+        {0x0000a194, 0x00000000},
+        {0x0000a198, 0x00000000},
+        {0x0000a19c, 0x00000000},
+        {0x0000a1a0, 0x00000000},
+        {0x0000a1a4, 0x00000000},
+        {0x0000a1a8, 0x00000000},
+        {0x0000a1ac, 0x00000000},
+        {0x0000a1b0, 0x00000000},
+        {0x0000a1b4, 0x00000000},
+        {0x0000a1b8, 0x00000000},
+        {0x0000a1bc, 0x00000000},
+        {0x0000a1c0, 0x00000000},
+        {0x0000a1c4, 0x00000000},
+        {0x0000a1c8, 0x00000000},
+        {0x0000a1cc, 0x00000000},
+        {0x0000a1d0, 0x00000000},
+        {0x0000a1d4, 0x00000000},
+        {0x0000a1d8, 0x00000000},
+        {0x0000a1dc, 0x00000000},
+        {0x0000a1e0, 0x00000000},
+        {0x0000a1e4, 0x00000000},
+        {0x0000a1e8, 0x00000000},
+        {0x0000a1ec, 0x00000000},
+        {0x0000a1f0, 0x00000396},
+        {0x0000a1f4, 0x00000396},
+        {0x0000a1f8, 0x00000396},
+        {0x0000a1fc, 0x00000196},
+        {0x0000b000, 0x00010000},
+        {0x0000b004, 0x00030002},
+        {0x0000b008, 0x00050004},
+        {0x0000b00c, 0x00810080},
+        {0x0000b010, 0x00830082},
+        {0x0000b014, 0x01810180},
+        {0x0000b018, 0x01830182},
+        {0x0000b01c, 0x01850184},
+        {0x0000b020, 0x02810280},
+        {0x0000b024, 0x02830282},
+        {0x0000b028, 0x02850284},
+        {0x0000b02c, 0x02890288},
+        {0x0000b030, 0x028b028a},
+        {0x0000b034, 0x0388028c},
+        {0x0000b038, 0x038a0389},
+        {0x0000b03c, 0x038c038b},
+        {0x0000b040, 0x0390038d},
+        {0x0000b044, 0x03920391},
+        {0x0000b048, 0x03940393},
+        {0x0000b04c, 0x03960395},
+        {0x0000b050, 0x00000000},
+        {0x0000b054, 0x00000000},
+        {0x0000b058, 0x00000000},
+        {0x0000b05c, 0x00000000},
+        {0x0000b060, 0x00000000},
+        {0x0000b064, 0x00000000},
+        {0x0000b068, 0x00000000},
+        {0x0000b06c, 0x00000000},
+        {0x0000b070, 0x00000000},
+        {0x0000b074, 0x00000000},
+        {0x0000b078, 0x00000000},
+        {0x0000b07c, 0x00000000},
+        {0x0000b080, 0x32323232},
+        {0x0000b084, 0x2f2f3232},
+        {0x0000b088, 0x23282a2d},
+        {0x0000b08c, 0x1c1e2123},
+        {0x0000b090, 0x14171919},
+        {0x0000b094, 0x0e0e1214},
+        {0x0000b098, 0x03050707},
+        {0x0000b09c, 0x00030303},
+        {0x0000b0a0, 0x00000000},
+        {0x0000b0a4, 0x00000000},
+        {0x0000b0a8, 0x00000000},
+        {0x0000b0ac, 0x00000000},
+        {0x0000b0b0, 0x00000000},
+        {0x0000b0b4, 0x00000000},
+        {0x0000b0b8, 0x00000000},
+        {0x0000b0bc, 0x00000000},
+        {0x0000b0c0, 0x003f0020},
+        {0x0000b0c4, 0x00400041},
+        {0x0000b0c8, 0x0140005f},
+        {0x0000b0cc, 0x0160015f},
+        {0x0000b0d0, 0x017e017f},
+        {0x0000b0d4, 0x02410242},
+        {0x0000b0d8, 0x025f0240},
+        {0x0000b0dc, 0x027f0260},
+        {0x0000b0e0, 0x0341027e},
+        {0x0000b0e4, 0x035f0340},
+        {0x0000b0e8, 0x037f0360},
+        {0x0000b0ec, 0x04400441},
+        {0x0000b0f0, 0x0460045f},
+        {0x0000b0f4, 0x0541047f},
+        {0x0000b0f8, 0x055f0540},
+        {0x0000b0fc, 0x057f0560},
+        {0x0000b100, 0x06400641},
+        {0x0000b104, 0x0660065f},
+        {0x0000b108, 0x067e067f},
+        {0x0000b10c, 0x07410742},
+        {0x0000b110, 0x075f0740},
+        {0x0000b114, 0x077f0760},
+        {0x0000b118, 0x07800781},
+        {0x0000b11c, 0x07a0079f},
+        {0x0000b120, 0x07c107bf},
+        {0x0000b124, 0x000007c0},
+        {0x0000b128, 0x00000000},
+        {0x0000b12c, 0x00000000},
+        {0x0000b130, 0x00000000},
+        {0x0000b134, 0x00000000},
+        {0x0000b138, 0x00000000},
+        {0x0000b13c, 0x00000000},
+        {0x0000b140, 0x003f0020},
+        {0x0000b144, 0x00400041},
+        {0x0000b148, 0x0140005f},
+        {0x0000b14c, 0x0160015f},
+        {0x0000b150, 0x017e017f},
+        {0x0000b154, 0x02410242},
+        {0x0000b158, 0x025f0240},
+        {0x0000b15c, 0x027f0260},
+        {0x0000b160, 0x0341027e},
+        {0x0000b164, 0x035f0340},
+        {0x0000b168, 0x037f0360},
+        {0x0000b16c, 0x04400441},
+        {0x0000b170, 0x0460045f},
+        {0x0000b174, 0x0541047f},
+        {0x0000b178, 0x055f0540},
+        {0x0000b17c, 0x057f0560},
+        {0x0000b180, 0x06400641},
+        {0x0000b184, 0x0660065f},
+        {0x0000b188, 0x067e067f},
+        {0x0000b18c, 0x07410742},
+        {0x0000b190, 0x075f0740},
+        {0x0000b194, 0x077f0760},
+        {0x0000b198, 0x07800781},
+        {0x0000b19c, 0x07a0079f},
+        {0x0000b1a0, 0x07c107bf},
+        {0x0000b1a4, 0x000007c0},
+        {0x0000b1a8, 0x00000000},
+        {0x0000b1ac, 0x00000000},
+        {0x0000b1b0, 0x00000000},
+        {0x0000b1b4, 0x00000000},
+        {0x0000b1b8, 0x00000000},
+        {0x0000b1bc, 0x00000000},
+        {0x0000b1c0, 0x00000000},
+        {0x0000b1c4, 0x00000000},
+        {0x0000b1c8, 0x00000000},
+        {0x0000b1cc, 0x00000000},
+        {0x0000b1d0, 0x00000000},
+        {0x0000b1d4, 0x00000000},
+        {0x0000b1d8, 0x00000000},
+        {0x0000b1dc, 0x00000000},
+        {0x0000b1e0, 0x00000000},
+        {0x0000b1e4, 0x00000000},
+        {0x0000b1e8, 0x00000000},
+        {0x0000b1ec, 0x00000000},
+        {0x0000b1f0, 0x00000396},
+        {0x0000b1f4, 0x00000396},
+        {0x0000b1f8, 0x00000396},
+        {0x0000b1fc, 0x00000196},
+};
+static const u32 ar9340_1p0_soc_preamble[][2] = {
+        /*    Addr        allmodes        */
+        {0x000040a4, 0x00a0c1c9},
+        {0x00007008, 0x00000000},
+        {0x00007020, 0x00000000},
+        {0x00007034, 0x00000002},
+        {0x00007038, 0x000004c2},
+};
+#endif
diff --git a/drivers/net/wireless/ath/ath9k/ar9485_initvals.h b/drivers/net/wireless/ath/ath9k/ar9485_initvals.h
index 71cc0a3a29fb..fbdde29f0ab8 100644
--- a/drivers/net/wireless/ath/ath9k/ar9485_initvals.h
+++ b/drivers/net/wireless/ath/ath9k/ar9485_initvals.h
@@ -17,931 +17,6 @@
 #ifndef INITVALS_9485_H
 #define INITVALS_9485_H
-static const u32 ar9485Common_1_0[][2] = {
-        /*   Addr     allmodes */
-        {0x00007010, 0x00000022},
-        {0x00007020, 0x00000000},
-        {0x00007034, 0x00000002},
-        {0x00007038, 0x000004c2},
-};
-static const u32 ar9485_1_0_mac_postamble[][5] = {
-        /* Addr     5G_HT20     5G_HT40     2G_HT40     2G_HT20    */
-        {0x00001030, 0x00000230, 0x00000460, 0x000002c0, 0x00000160},
-        {0x00001070, 0x00000168, 0x000002d0, 0x00000318, 0x0000018c},
-        {0x000010b0, 0x00000e60, 0x00001cc0, 0x00007c70, 0x00003e38},
-        {0x00008014, 0x03e803e8, 0x07d007d0, 0x10801600, 0x08400b00},
-        {0x0000801c, 0x128d8027, 0x128d804f, 0x12e00057, 0x12e0002b},
-        {0x00008120, 0x08f04800, 0x08f04800, 0x08f04810, 0x08f04810},
-        {0x000081d0, 0x00003210, 0x00003210, 0x0000320a, 0x0000320a},
-        {0x00008318, 0x00003e80, 0x00007d00, 0x00006880, 0x00003440},
-};
-static const u32 ar9485_1_0_pcie_phy_pll_on_clkreq_disable_L1[][2] = {
-        /*   Addr     allmodes */
-        {0x00018c00, 0x10212e5e},
-        {0x00018c04, 0x000801d8},
-        {0x00018c08, 0x0000580c},
-};
-static const u32 ar9485Common_wo_xlna_rx_gain_1_0[][2] = {
-        /*   Addr     allmodes */
-        {0x0000a000, 0x00010000},
-        {0x0000a004, 0x00030002},
-        {0x0000a008, 0x00050004},
-        {0x0000a00c, 0x00810080},
-        {0x0000a010, 0x01800082},
-        {0x0000a014, 0x01820181},
-        {0x0000a018, 0x01840183},
-        {0x0000a01c, 0x01880185},
-        {0x0000a020, 0x018a0189},
-        {0x0000a024, 0x02850284},
-        {0x0000a028, 0x02890288},
-        {0x0000a02c, 0x03850384},
-        {0x0000a030, 0x03890388},
-        {0x0000a034, 0x038b038a},
-        {0x0000a038, 0x038d038c},
-        {0x0000a03c, 0x03910390},
-        {0x0000a040, 0x03930392},
-        {0x0000a044, 0x03950394},
-        {0x0000a048, 0x00000396},
-        {0x0000a04c, 0x00000000},
-        {0x0000a050, 0x00000000},
-        {0x0000a054, 0x00000000},
-        {0x0000a058, 0x00000000},
-        {0x0000a05c, 0x00000000},
-        {0x0000a060, 0x00000000},
-        {0x0000a064, 0x00000000},
-        {0x0000a068, 0x00000000},
-        {0x0000a06c, 0x00000000},
-        {0x0000a070, 0x00000000},
-        {0x0000a074, 0x00000000},
-        {0x0000a078, 0x00000000},
-        {0x0000a07c, 0x00000000},
-        {0x0000a080, 0x28282828},
-        {0x0000a084, 0x28282828},
-        {0x0000a088, 0x28282828},
-        {0x0000a08c, 0x28282828},
-        {0x0000a090, 0x28282828},
-        {0x0000a094, 0x21212128},
-        {0x0000a098, 0x171c1c1c},
-        {0x0000a09c, 0x02020212},
-        {0x0000a0a0, 0x00000202},
-        {0x0000a0a4, 0x00000000},
-        {0x0000a0a8, 0x00000000},
-        {0x0000a0ac, 0x00000000},
-        {0x0000a0b0, 0x00000000},
-        {0x0000a0b4, 0x00000000},
-        {0x0000a0b8, 0x00000000},
-        {0x0000a0bc, 0x00000000},
-        {0x0000a0c0, 0x001f0000},
-        {0x0000a0c4, 0x111f1100},
-        {0x0000a0c8, 0x111d111e},
-        {0x0000a0cc, 0x111b111c},
-        {0x0000a0d0, 0x22032204},
-        {0x0000a0d4, 0x22012202},
-        {0x0000a0d8, 0x221f2200},
-        {0x0000a0dc, 0x221d221e},
-        {0x0000a0e0, 0x33013302},
-        {0x0000a0e4, 0x331f3300},
-        {0x0000a0e8, 0x4402331e},
-        {0x0000a0ec, 0x44004401},
-        {0x0000a0f0, 0x441e441f},
-        {0x0000a0f4, 0x55015502},
-        {0x0000a0f8, 0x551f5500},
-        {0x0000a0fc, 0x6602551e},
-        {0x0000a100, 0x66006601},
-        {0x0000a104, 0x661e661f},
-        {0x0000a108, 0x7703661d},
-        {0x0000a10c, 0x77017702},
-        {0x0000a110, 0x00007700},
-        {0x0000a114, 0x00000000},
-        {0x0000a118, 0x00000000},
-        {0x0000a11c, 0x00000000},
-        {0x0000a120, 0x00000000},
-        {0x0000a124, 0x00000000},
-        {0x0000a128, 0x00000000},
-        {0x0000a12c, 0x00000000},
-        {0x0000a130, 0x00000000},
-        {0x0000a134, 0x00000000},
-        {0x0000a138, 0x00000000},
-        {0x0000a13c, 0x00000000},
-        {0x0000a140, 0x001f0000},
-        {0x0000a144, 0x111f1100},
-        {0x0000a148, 0x111d111e},
-        {0x0000a14c, 0x111b111c},
-        {0x0000a150, 0x22032204},
-        {0x0000a154, 0x22012202},
-        {0x0000a158, 0x221f2200},
-        {0x0000a15c, 0x221d221e},
-        {0x0000a160, 0x33013302},
-        {0x0000a164, 0x331f3300},
-        {0x0000a168, 0x4402331e},
-        {0x0000a16c, 0x44004401},
-        {0x0000a170, 0x441e441f},
-        {0x0000a174, 0x55015502},
-        {0x0000a178, 0x551f5500},
-        {0x0000a17c, 0x6602551e},
-        {0x0000a180, 0x66006601},
-        {0x0000a184, 0x661e661f},
-        {0x0000a188, 0x7703661d},
-        {0x0000a18c, 0x77017702},
-        {0x0000a190, 0x00007700},
-        {0x0000a194, 0x00000000},
-        {0x0000a198, 0x00000000},
-        {0x0000a19c, 0x00000000},
-        {0x0000a1a0, 0x00000000},
-        {0x0000a1a4, 0x00000000},
-        {0x0000a1a8, 0x00000000},
-        {0x0000a1ac, 0x00000000},
-        {0x0000a1b0, 0x00000000},
-        {0x0000a1b4, 0x00000000},
-        {0x0000a1b8, 0x00000000},
-        {0x0000a1bc, 0x00000000},
-        {0x0000a1c0, 0x00000000},
-        {0x0000a1c4, 0x00000000},
-        {0x0000a1c8, 0x00000000},
-        {0x0000a1cc, 0x00000000},
-        {0x0000a1d0, 0x00000000},
-        {0x0000a1d4, 0x00000000},
-        {0x0000a1d8, 0x00000000},
-        {0x0000a1dc, 0x00000000},
-        {0x0000a1e0, 0x00000000},
-        {0x0000a1e4, 0x00000000},
-        {0x0000a1e8, 0x00000000},
-        {0x0000a1ec, 0x00000000},
-        {0x0000a1f0, 0x00000396},
-        {0x0000a1f4, 0x00000396},
-        {0x0000a1f8, 0x00000396},
-        {0x0000a1fc, 0x00000296},
-};
-static const u32 ar9485Modes_high_power_tx_gain_1_0[][5] = {
-        /*   Addr      5G_HT20     5G_HT40     2G_HT40     2G_HT20 */
-        {0x0000a410, 0x000050d9, 0x000050d9, 0x000050d8, 0x000050d8},
-        {0x0000a500, 0x00022200, 0x00022200, 0x00000000, 0x00000000},
-        {0x0000a504, 0x05062002, 0x05062002, 0x04000002, 0x04000002},
-        {0x0000a508, 0x0c002e00, 0x0c002e00, 0x08000004, 0x08000004},
-        {0x0000a50c, 0x11062202, 0x11062202, 0x0d000200, 0x0d000200},
-        {0x0000a510, 0x17022e00, 0x17022e00, 0x11000202, 0x11000202},
-        {0x0000a514, 0x1d000ec2, 0x1d000ec2, 0x15000400, 0x15000400},
-        {0x0000a518, 0x25020ec0, 0x25020ec0, 0x19000402, 0x19000402},
-        {0x0000a51c, 0x2b020ec3, 0x2b020ec3, 0x1d000404, 0x1d000404},
-        {0x0000a520, 0x2f001f04, 0x2f001f04, 0x21000603, 0x21000603},
-        {0x0000a524, 0x35001fc4, 0x35001fc4, 0x25000605, 0x25000605},
-        {0x0000a528, 0x3c022f04, 0x3c022f04, 0x2a000a03, 0x2a000a03},
-        {0x0000a52c, 0x41023e85, 0x41023e85, 0x2c000a04, 0x2c000a04},
-        {0x0000a530, 0x48023ec6, 0x48023ec6, 0x2e000a20, 0x2e000a20},
-        {0x0000a534, 0x4d023f01, 0x4d023f01, 0x34000e20, 0x34000e20},
-        {0x0000a538, 0x53023f4b, 0x53023f4b, 0x38000e22, 0x38000e22},
-        {0x0000a53c, 0x5a027f09, 0x5a027f09, 0x3c000e24, 0x3c000e24},
-        {0x0000a540, 0x5f027fc9, 0x5f027fc9, 0x40000e26, 0x40000e26},
-        {0x0000a544, 0x6502feca, 0x6502feca, 0x43001640, 0x43001640},
-        {0x0000a548, 0x6b02ff4a, 0x6b02ff4a, 0x46001660, 0x46001660},
-        {0x0000a54c, 0x7203feca, 0x7203feca, 0x49001861, 0x49001861},
-        {0x0000a550, 0x7703ff0b, 0x7703ff0b, 0x4c001a81, 0x4c001a81},
-        {0x0000a554, 0x7d06ffcb, 0x7d06ffcb, 0x4f001a83, 0x4f001a83},
-        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x54001c85, 0x54001c85},
-        {0x0000a55c, 0x8907ffcb, 0x8907ffcb, 0x58001ce5, 0x58001ce5},
-        {0x0000a560, 0x900fff0b, 0x900fff0b, 0x5b001ce9, 0x5b001ce9},
-        {0x0000a564, 0x960fffcb, 0x960fffcb, 0x60001eeb, 0x60001eeb},
-        {0x0000a568, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a56c, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a570, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a574, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a578, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a57c, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x00016044, 0x05b6b2db, 0x05b6b2db, 0x05b6b2db, 0x05b6b2db},
-};
-static const u32 ar9485_1_0[][2] = {
-        /*  Addr      allmodes */
-        {0x0000a580, 0x00000000},
-        {0x0000a584, 0x00000000},
-        {0x0000a588, 0x00000000},
-        {0x0000a58c, 0x00000000},
-        {0x0000a590, 0x00000000},
-        {0x0000a594, 0x00000000},
-        {0x0000a598, 0x00000000},
-        {0x0000a59c, 0x00000000},
-        {0x0000a5a0, 0x00000000},
-        {0x0000a5a4, 0x00000000},
-        {0x0000a5a8, 0x00000000},
-        {0x0000a5ac, 0x00000000},
-        {0x0000a5b0, 0x00000000},
-        {0x0000a5b4, 0x00000000},
-        {0x0000a5b8, 0x00000000},
-        {0x0000a5bc, 0x00000000},
-};
-static const u32 ar9485_1_0_radio_core[][2] = {
-        /*   Addr     allmodes */
-        {0x00016000, 0x36db6db6},
-        {0x00016004, 0x6db6db40},
-        {0x00016008, 0x73800000},
-        {0x0001600c, 0x00000000},
-        {0x00016040, 0x7f80fff8},
-        {0x00016048, 0x6c92426e},
-        {0x0001604c, 0x000f0278},
-        {0x00016050, 0x6db6db6c},
-        {0x00016054, 0x6db60000},
-        {0x00016080, 0x00080000},
-        {0x00016084, 0x0e48048c},
-        {0x00016088, 0x14214514},
-        {0x0001608c, 0x119f081e},
-        {0x00016090, 0x24926490},
-        {0x00016098, 0xd28b3330},
-        {0x000160a0, 0xc2108ffe},
-        {0x000160a4, 0x812fc370},
-        {0x000160a8, 0x423c8000},
-        {0x000160b4, 0x92480040},
-        {0x000160c0, 0x006db6db},
-        {0x000160c4, 0x0186db60},
-        {0x000160c8, 0x6db6db6c},
-        {0x000160cc, 0x6de6fbe0},
-        {0x000160d0, 0xf7dfcf3c},
-        {0x00016100, 0x04cb0001},
-        {0x00016104, 0xfff80015},
-        {0x00016108, 0x00080010},
-        {0x00016144, 0x01884080},
-        {0x00016148, 0x00008040},
-        {0x00016180, 0x08453333},
-        {0x00016184, 0x18e82f01},
-        {0x00016188, 0x00000000},
-        {0x0001618c, 0x00000000},
-        {0x00016240, 0x08400000},
-        {0x00016244, 0x1bf90f00},
-        {0x00016248, 0x00000000},
-        {0x0001624c, 0x00000000},
-        {0x00016280, 0x01000015},
-        {0x00016284, 0x00d30000},
-        {0x00016288, 0x00318000},
-        {0x0001628c, 0x50000000},
-        {0x00016290, 0x4b96210f},
-        {0x00016380, 0x00000000},
-        {0x00016384, 0x00000000},
-        {0x00016388, 0x00800700},
-        {0x0001638c, 0x00800700},
-        {0x00016390, 0x00800700},
-        {0x00016394, 0x00000000},
-        {0x00016398, 0x00000000},
-        {0x0001639c, 0x00000000},
-        {0x000163a0, 0x00000001},
-        {0x000163a4, 0x00000001},
-        {0x000163a8, 0x00000000},
-        {0x000163ac, 0x00000000},
-        {0x000163b0, 0x00000000},
-        {0x000163b4, 0x00000000},
-        {0x000163b8, 0x00000000},
-        {0x000163bc, 0x00000000},
-        {0x000163c0, 0x000000a0},
-        {0x000163c4, 0x000c0000},
-        {0x000163c8, 0x14021402},
-        {0x000163cc, 0x00001402},
-        {0x000163d0, 0x00000000},
-        {0x000163d4, 0x00000000},
-        {0x00016c40, 0x1319c178},
-        {0x00016c44, 0x10000000},
-};
-static const u32 ar9485Modes_lowest_ob_db_tx_gain_1_0[][5] = {
-        /*  Addr       5G_HT20     5G_HT40     2G_HT40     2G_HT20 */
-        {0x0000a410, 0x000050d9, 0x000050d9, 0x000050d8, 0x000050d8},
-        {0x0000a500, 0x00022200, 0x00022200, 0x00000000, 0x00000000},
-        {0x0000a504, 0x05062002, 0x05062002, 0x04000002, 0x04000002},
-        {0x0000a508, 0x0c002e00, 0x0c002e00, 0x08000004, 0x08000004},
-        {0x0000a50c, 0x11062202, 0x11062202, 0x0d000200, 0x0d000200},
-        {0x0000a510, 0x17022e00, 0x17022e00, 0x11000202, 0x11000202},
-        {0x0000a514, 0x1d000ec2, 0x1d000ec2, 0x15000400, 0x15000400},
-        {0x0000a518, 0x25020ec0, 0x25020ec0, 0x19000402, 0x19000402},
-        {0x0000a51c, 0x2b020ec3, 0x2b020ec3, 0x1d000404, 0x1d000404},
-        {0x0000a520, 0x2f001f04, 0x2f001f04, 0x21000603, 0x21000603},
-        {0x0000a524, 0x35001fc4, 0x35001fc4, 0x25000605, 0x25000605},
-        {0x0000a528, 0x3c022f04, 0x3c022f04, 0x2a000a03, 0x2a000a03},
-        {0x0000a52c, 0x41023e85, 0x41023e85, 0x2c000a04, 0x2c000a04},
-        {0x0000a530, 0x48023ec6, 0x48023ec6, 0x2e000a20, 0x2e000a20},
-        {0x0000a534, 0x4d023f01, 0x4d023f01, 0x34000e20, 0x34000e20},
-        {0x0000a538, 0x53023f4b, 0x53023f4b, 0x38000e22, 0x38000e22},
-        {0x0000a53c, 0x5a027f09, 0x5a027f09, 0x3c000e24, 0x3c000e24},
-        {0x0000a540, 0x5f027fc9, 0x5f027fc9, 0x40000e26, 0x40000e26},
-        {0x0000a544, 0x6502feca, 0x6502feca, 0x43001640, 0x43001640},
-        {0x0000a548, 0x6b02ff4a, 0x6b02ff4a, 0x46001660, 0x46001660},
-        {0x0000a54c, 0x7203feca, 0x7203feca, 0x49001861, 0x49001861},
-        {0x0000a550, 0x7703ff0b, 0x7703ff0b, 0x4c001a81, 0x4c001a81},
-        {0x0000a554, 0x7d06ffcb, 0x7d06ffcb, 0x4f001a83, 0x4f001a83},
-        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x54001c85, 0x54001c85},
-        {0x0000a55c, 0x8907ffcb, 0x8907ffcb, 0x58001ce5, 0x58001ce5},
-        {0x0000a560, 0x900fff0b, 0x900fff0b, 0x5b001ce9, 0x5b001ce9},
-        {0x0000a564, 0x960fffcb, 0x960fffcb, 0x60001eeb, 0x60001eeb},
-        {0x0000a568, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a56c, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a570, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a574, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a578, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a57c, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x00016044, 0x05b6b2db, 0x05b6b2db, 0x05b6b2db, 0x05b6b2db},
-};
-static const u32 ar9485_1_0_baseband_core[][2] = {
-        /* Addr      allmodes  */
-        {0x00009800, 0xafe68e30},
-        {0x00009804, 0xfd14e000},
-        {0x00009808, 0x9c0a8f6b},
-        {0x0000980c, 0x04800000},
-        {0x00009814, 0x9280c00a},
-        {0x00009818, 0x00000000},
-        {0x0000981c, 0x00020028},
-        {0x00009834, 0x5f3ca3de},
-        {0x00009838, 0x0108ecff},
-        {0x0000983c, 0x14750600},
-        {0x00009880, 0x201fff00},
-        {0x00009884, 0x00001042},
-        {0x000098a4, 0x00200400},
-        {0x000098b0, 0x52440bbe},
-        {0x000098bc, 0x00000002},
-        {0x000098d0, 0x004b6a8e},
-        {0x000098d4, 0x00000820},
-        {0x000098dc, 0x00000000},
-        {0x000098f0, 0x00000000},
-        {0x000098f4, 0x00000000},
-        {0x00009c04, 0x00000000},
-        {0x00009c08, 0x03200000},
-        {0x00009c0c, 0x00000000},
-        {0x00009c10, 0x00000000},
-        {0x00009c14, 0x00046384},
-        {0x00009c18, 0x05b6b440},
-        {0x00009c1c, 0x00b6b440},
-        {0x00009d00, 0xc080a333},
-        {0x00009d04, 0x40206c10},
-        {0x00009d08, 0x009c4060},
-        {0x00009d0c, 0x1883800a},
-        {0x00009d10, 0x01834061},
-        {0x00009d14, 0x00c00400},
-        {0x00009d18, 0x00000000},
-        {0x00009d1c, 0x00000000},
-        {0x00009e08, 0x0038233c},
-        {0x00009e24, 0x990bb515},
-        {0x00009e28, 0x0a6f0000},
-        {0x00009e30, 0x06336f77},
-        {0x00009e34, 0x6af6532f},
-        {0x00009e38, 0x0cc80c00},
-        {0x00009e40, 0x0d261820},
-        {0x00009e4c, 0x00001004},
-        {0x00009e50, 0x00ff03f1},
-        {0x00009fc0, 0x80be4788},
-        {0x00009fc4, 0x0001efb5},
-        {0x00009fcc, 0x40000014},
-        {0x0000a20c, 0x00000000},
-        {0x0000a210, 0x00000000},
-        {0x0000a220, 0x00000000},
-        {0x0000a224, 0x00000000},
-        {0x0000a228, 0x10002310},
-        {0x0000a23c, 0x00000000},
-        {0x0000a244, 0x0c000000},
-        {0x0000a2a0, 0x00000001},
-        {0x0000a2c0, 0x00000001},
-        {0x0000a2c8, 0x00000000},
-        {0x0000a2cc, 0x18c43433},
-        {0x0000a2d4, 0x00000000},
-        {0x0000a2dc, 0x00000000},
-        {0x0000a2e0, 0x00000000},
-        {0x0000a2e4, 0x00000000},
-        {0x0000a2e8, 0x00000000},
-        {0x0000a2ec, 0x00000000},
-        {0x0000a2f0, 0x00000000},
-        {0x0000a2f4, 0x00000000},
-        {0x0000a2f8, 0x00000000},
-        {0x0000a344, 0x00000000},
-        {0x0000a34c, 0x00000000},
-        {0x0000a350, 0x0000a000},
-        {0x0000a364, 0x00000000},
-        {0x0000a370, 0x00000000},
-        {0x0000a390, 0x00000001},
-        {0x0000a394, 0x00000444},
-        {0x0000a398, 0x001f0e0f},
-        {0x0000a39c, 0x0075393f},
-        {0x0000a3a0, 0xb79f6427},
-        {0x0000a3a4, 0x00000000},
-        {0x0000a3a8, 0xaaaaaaaa},
-        {0x0000a3ac, 0x3c466478},
-        {0x0000a3c0, 0x20202020},
-        {0x0000a3c4, 0x22222220},
-        {0x0000a3c8, 0x20200020},
-        {0x0000a3cc, 0x20202020},
-        {0x0000a3d0, 0x20202020},
-        {0x0000a3d4, 0x20202020},
-        {0x0000a3d8, 0x20202020},
-        {0x0000a3dc, 0x20202020},
-        {0x0000a3e0, 0x20202020},
-        {0x0000a3e4, 0x20202020},
-        {0x0000a3e8, 0x20202020},
-        {0x0000a3ec, 0x20202020},
-        {0x0000a3f0, 0x00000000},
-        {0x0000a3f4, 0x00000006},
-        {0x0000a3f8, 0x0cdbd380},
-        {0x0000a3fc, 0x000f0f01},
-        {0x0000a400, 0x8fa91f01},
-        {0x0000a404, 0x00000000},
-        {0x0000a408, 0x0e79e5c6},
-        {0x0000a40c, 0x00820820},
-        {0x0000a414, 0x1ce739ce},
-        {0x0000a418, 0x2d0011ce},
-        {0x0000a41c, 0x1ce739ce},
-        {0x0000a420, 0x000001ce},
-        {0x0000a424, 0x1ce739ce},
-        {0x0000a428, 0x000001ce},
-        {0x0000a42c, 0x1ce739ce},
-        {0x0000a430, 0x1ce739ce},
-        {0x0000a434, 0x00000000},
-        {0x0000a438, 0x00001801},
-        {0x0000a43c, 0x00000000},
-        {0x0000a440, 0x00000000},
-        {0x0000a444, 0x00000000},
-        {0x0000a448, 0x04000000},
-        {0x0000a44c, 0x00000001},
-        {0x0000a450, 0x00010000},
-        {0x0000a458, 0x00000000},
-        {0x0000a5c4, 0x3fad9d74},
-        {0x0000a5c8, 0x0048060a},
-        {0x0000a5cc, 0x00000637},
-        {0x0000a760, 0x03020100},
-        {0x0000a764, 0x09080504},
-        {0x0000a768, 0x0d0c0b0a},
-        {0x0000a76c, 0x13121110},
-        {0x0000a770, 0x31301514},
-        {0x0000a774, 0x35343332},
-        {0x0000a778, 0x00000036},
-        {0x0000a780, 0x00000838},
-        {0x0000a7c0, 0x00000000},
-        {0x0000a7c4, 0xfffffffc},
-        {0x0000a7c8, 0x00000000},
-        {0x0000a7cc, 0x00000000},
-        {0x0000a7d0, 0x00000000},
-        {0x0000a7d4, 0x00000004},
-        {0x0000a7dc, 0x00000001},
-};
-static const u32 ar9485Modes_high_ob_db_tx_gain_1_0[][5] = {
-        /* Addr        5G_HT20     5G_HT40     2G_HT40    2G_HT20  */
-        {0x0000a410, 0x000050d9, 0x000050d9, 0x000050d8, 0x000050d8},
-        {0x0000a500, 0x00022200, 0x00022200, 0x00000000, 0x00000000},
-        {0x0000a504, 0x05062002, 0x05062002, 0x04000002, 0x04000002},
-        {0x0000a508, 0x0c002e00, 0x0c002e00, 0x08000004, 0x08000004},
-        {0x0000a50c, 0x11062202, 0x11062202, 0x0d000200, 0x0d000200},
-        {0x0000a510, 0x17022e00, 0x17022e00, 0x11000202, 0x11000202},
-        {0x0000a514, 0x1d000ec2, 0x1d000ec2, 0x15000400, 0x15000400},
-        {0x0000a518, 0x25020ec0, 0x25020ec0, 0x19000402, 0x19000402},
-        {0x0000a51c, 0x2b020ec3, 0x2b020ec3, 0x1d000404, 0x1d000404},
-        {0x0000a520, 0x2f001f04, 0x2f001f04, 0x21000603, 0x21000603},
-        {0x0000a524, 0x35001fc4, 0x35001fc4, 0x25000605, 0x25000605},
-        {0x0000a528, 0x3c022f04, 0x3c022f04, 0x2a000a03, 0x2a000a03},
-        {0x0000a52c, 0x41023e85, 0x41023e85, 0x2c000a04, 0x2c000a04},
-        {0x0000a530, 0x48023ec6, 0x48023ec6, 0x2e000a20, 0x2e000a20},
-        {0x0000a534, 0x4d023f01, 0x4d023f01, 0x34000e20, 0x34000e20},
-        {0x0000a538, 0x53023f4b, 0x53023f4b, 0x38000e22, 0x38000e22},
-        {0x0000a53c, 0x5a027f09, 0x5a027f09, 0x3c000e24, 0x3c000e24},
-        {0x0000a540, 0x5f027fc9, 0x5f027fc9, 0x40000e26, 0x40000e26},
-        {0x0000a544, 0x6502feca, 0x6502feca, 0x43001640, 0x43001640},
-        {0x0000a548, 0x6b02ff4a, 0x6b02ff4a, 0x46001660, 0x46001660},
-        {0x0000a54c, 0x7203feca, 0x7203feca, 0x49001861, 0x49001861},
-        {0x0000a550, 0x7703ff0b, 0x7703ff0b, 0x4c001a81, 0x4c001a81},
-        {0x0000a554, 0x7d06ffcb, 0x7d06ffcb, 0x4f001a83, 0x4f001a83},
-        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x54001c85, 0x54001c85},
-        {0x0000a55c, 0x8907ffcb, 0x8907ffcb, 0x58001ce5, 0x58001ce5},
-        {0x0000a560, 0x900fff0b, 0x900fff0b, 0x5b001ce9, 0x5b001ce9},
-        {0x0000a564, 0x960fffcb, 0x960fffcb, 0x60001eeb, 0x60001eeb},
-        {0x0000a568, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a56c, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a570, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a574, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a578, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a57c, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x00016044, 0x05b6b2db, 0x05b6b2db, 0x05b6b2db, 0x05b6b2db},
-};
-static const u32 ar9485Common_rx_gain_1_0[][2] = {
-        /* Addr      allmodes  */
-        {0x0000a000, 0x00010000},
-        {0x0000a004, 0x00030002},
-        {0x0000a008, 0x00050004},
-        {0x0000a00c, 0x00810080},
-        {0x0000a010, 0x01800082},
-        {0x0000a014, 0x01820181},
-        {0x0000a018, 0x01840183},
-        {0x0000a01c, 0x01880185},
-        {0x0000a020, 0x018a0189},
-        {0x0000a024, 0x02850284},
-        {0x0000a028, 0x02890288},
-        {0x0000a02c, 0x03850384},
-        {0x0000a030, 0x03890388},
-        {0x0000a034, 0x038b038a},
-        {0x0000a038, 0x038d038c},
-        {0x0000a03c, 0x03910390},
-        {0x0000a040, 0x03930392},
-        {0x0000a044, 0x03950394},
-        {0x0000a048, 0x00000396},
-        {0x0000a04c, 0x00000000},
-        {0x0000a050, 0x00000000},
-        {0x0000a054, 0x00000000},
-        {0x0000a058, 0x00000000},
-        {0x0000a05c, 0x00000000},
-        {0x0000a060, 0x00000000},
-        {0x0000a064, 0x00000000},
-        {0x0000a068, 0x00000000},
-        {0x0000a06c, 0x00000000},
-        {0x0000a070, 0x00000000},
-        {0x0000a074, 0x00000000},
-        {0x0000a078, 0x00000000},
-        {0x0000a07c, 0x00000000},
-        {0x0000a080, 0x28282828},
-        {0x0000a084, 0x28282828},
-        {0x0000a088, 0x28282828},
-        {0x0000a08c, 0x28282828},
-        {0x0000a090, 0x28282828},
-        {0x0000a094, 0x21212128},
-        {0x0000a098, 0x171c1c1c},
-        {0x0000a09c, 0x02020212},
-        {0x0000a0a0, 0x00000202},
-        {0x0000a0a4, 0x00000000},
-        {0x0000a0a8, 0x00000000},
-        {0x0000a0ac, 0x00000000},
-        {0x0000a0b0, 0x00000000},
-        {0x0000a0b4, 0x00000000},
-        {0x0000a0b8, 0x00000000},
-        {0x0000a0bc, 0x00000000},
-        {0x0000a0c0, 0x001f0000},
-        {0x0000a0c4, 0x111f1100},
-        {0x0000a0c8, 0x111d111e},
-        {0x0000a0cc, 0x111b111c},
-        {0x0000a0d0, 0x22032204},
-        {0x0000a0d4, 0x22012202},
-        {0x0000a0d8, 0x221f2200},
-        {0x0000a0dc, 0x221d221e},
-        {0x0000a0e0, 0x33013302},
-        {0x0000a0e4, 0x331f3300},
-        {0x0000a0e8, 0x4402331e},
-        {0x0000a0ec, 0x44004401},
-        {0x0000a0f0, 0x441e441f},
-        {0x0000a0f4, 0x55015502},
-        {0x0000a0f8, 0x551f5500},
-        {0x0000a0fc, 0x6602551e},
-        {0x0000a100, 0x66006601},
-        {0x0000a104, 0x661e661f},
-        {0x0000a108, 0x7703661d},
-        {0x0000a10c, 0x77017702},
-        {0x0000a110, 0x00007700},
-        {0x0000a114, 0x00000000},
-        {0x0000a118, 0x00000000},
-        {0x0000a11c, 0x00000000},
-        {0x0000a120, 0x00000000},
-        {0x0000a124, 0x00000000},
-        {0x0000a128, 0x00000000},
-        {0x0000a12c, 0x00000000},
-        {0x0000a130, 0x00000000},
-        {0x0000a134, 0x00000000},
-        {0x0000a138, 0x00000000},
-        {0x0000a13c, 0x00000000},
-        {0x0000a140, 0x001f0000},
-        {0x0000a144, 0x111f1100},
-        {0x0000a148, 0x111d111e},
-        {0x0000a14c, 0x111b111c},
-        {0x0000a150, 0x22032204},
-        {0x0000a154, 0x22012202},
-        {0x0000a158, 0x221f2200},
-        {0x0000a15c, 0x221d221e},
-        {0x0000a160, 0x33013302},
-        {0x0000a164, 0x331f3300},
-        {0x0000a168, 0x4402331e},
-        {0x0000a16c, 0x44004401},
-        {0x0000a170, 0x441e441f},
-        {0x0000a174, 0x55015502},
-        {0x0000a178, 0x551f5500},
-        {0x0000a17c, 0x6602551e},
-        {0x0000a180, 0x66006601},
-        {0x0000a184, 0x661e661f},
-        {0x0000a188, 0x7703661d},
-        {0x0000a18c, 0x77017702},
-        {0x0000a190, 0x00007700},
-        {0x0000a194, 0x00000000},
-        {0x0000a198, 0x00000000},
-        {0x0000a19c, 0x00000000},
-        {0x0000a1a0, 0x00000000},
-        {0x0000a1a4, 0x00000000},
-        {0x0000a1a8, 0x00000000},
-        {0x0000a1ac, 0x00000000},
-        {0x0000a1b0, 0x00000000},
-        {0x0000a1b4, 0x00000000},
-        {0x0000a1b8, 0x00000000},
-        {0x0000a1bc, 0x00000000},
-        {0x0000a1c0, 0x00000000},
-        {0x0000a1c4, 0x00000000},
-        {0x0000a1c8, 0x00000000},
-        {0x0000a1cc, 0x00000000},
-        {0x0000a1d0, 0x00000000},
-        {0x0000a1d4, 0x00000000},
-        {0x0000a1d8, 0x00000000},
-        {0x0000a1dc, 0x00000000},
-        {0x0000a1e0, 0x00000000},
-        {0x0000a1e4, 0x00000000},
-        {0x0000a1e8, 0x00000000},
-        {0x0000a1ec, 0x00000000},
-        {0x0000a1f0, 0x00000396},
-        {0x0000a1f4, 0x00000396},
-        {0x0000a1f8, 0x00000396},
-        {0x0000a1fc, 0x00000296},
-};
-static const u32 ar9485_1_0_pcie_phy_pll_on_clkreq_enable_L1[][2] = {
-        /*   Addr    allmodes  */
-        {0x00018c00, 0x10252e5e},
-        {0x00018c04, 0x000801d8},
-        {0x00018c08, 0x0000580c},
-};
-static const u32 ar9485_1_0_pcie_phy_clkreq_enable_L1[][2] = {
-        /*  Addr    allmodes   */
-        {0x00018c00, 0x10253e5e},
-        {0x00018c04, 0x000801d8},
-        {0x00018c08, 0x0000580c},
-};
-static const u32 ar9485_1_0_soc_preamble[][2] = {
-        /*   Addr     allmodes */
-        {0x00004090, 0x00aa10aa},
-        {0x000040a4, 0x00a0c9c9},
-        {0x00007048, 0x00000004},
-};
-static const u32 ar9485_fast_clock_1_0_baseband_postamble[][3] = {
-        /*   Addr      5G_HT20     5G_HT40 */
-        {0x00009e00, 0x03721821, 0x03721821},
-        {0x0000a230, 0x0000400b, 0x00004016},
-        {0x0000a254, 0x00000898, 0x00001130},
-};
-static const u32 ar9485_1_0_baseband_postamble[][5] = {
-        /* Addr        5G_HT20     5G_HT40     2G_HT40     2G_HT20 */
-        {0x00009810, 0xd00a8005, 0xd00a8005, 0xd00a8005, 0xd00a8005},
-        {0x00009820, 0x206a002e, 0x206a002e, 0x206a002e, 0x206a002e},
-        {0x00009824, 0x5ac640d0, 0x5ac640d0, 0x5ac640d0, 0x5ac640d0},
-        {0x00009828, 0x06903081, 0x06903081, 0x06903881, 0x06903881},
-        {0x0000982c, 0x05eea6d4, 0x05eea6d4, 0x05eea6d4, 0x05eea6d4},
-        {0x00009830, 0x0000059c, 0x0000059c, 0x0000059c, 0x0000059c},
-        {0x00009c00, 0x00000044, 0x00000044, 0x00000044, 0x00000044},
-        {0x00009e00, 0x0372161e, 0x0372161e, 0x037216a0, 0x037216a0},
-        {0x00009e04, 0x00182020, 0x00182020, 0x00182020, 0x00182020},
-        {0x00009e0c, 0x6c4000e2, 0x6d4000e2, 0x6d4000e2, 0x6c4000e2},
-        {0x00009e10, 0x7ec88d2e, 0x7ec88d2e, 0x7ec80d2e, 0x7ec80d2e},
-        {0x00009e14, 0x31395d5e, 0x3139605e, 0x3139605e, 0x31395d5e},
-        {0x00009e18, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
-        {0x00009e1c, 0x0001cf9c, 0x0001cf9c, 0x00021f9c, 0x00021f9c},
-        {0x00009e20, 0x000003b5, 0x000003b5, 0x000003ce, 0x000003ce},
-        {0x00009e2c, 0x0000001c, 0x0000001c, 0x00000021, 0x00000021},
-        {0x00009e3c, 0xcf946220, 0xcf946220, 0xcf946222, 0xcf946222},
-        {0x00009e44, 0x02321e27, 0x02321e27, 0x02282324, 0x02282324},
-        {0x00009e48, 0x5030201a, 0x5030201a, 0x50302010, 0x50302010},
-        {0x00009fc8, 0x0003f000, 0x0003f000, 0x0001a000, 0x0001a000},
-        {0x0000a204, 0x01303fc0, 0x01303fc4, 0x01303fc4, 0x01303fc0},
-        {0x0000a208, 0x00000104, 0x00000104, 0x00000004, 0x00000004},
-        {0x0000a230, 0x0000400a, 0x00004014, 0x00004016, 0x0000400b},
-        {0x0000a234, 0x10000fff, 0x10000fff, 0x10000fff, 0x10000fff},
-        {0x0000a238, 0xffb81018, 0xffb81018, 0xffb81018, 0xffb81018},
-        {0x0000a250, 0x00000000, 0x00000000, 0x00000210, 0x00000108},
-        {0x0000a254, 0x000007d0, 0x00000fa0, 0x00001130, 0x00000898},
-        {0x0000a258, 0x02020002, 0x02020002, 0x02020002, 0x02020002},
-        {0x0000a25c, 0x01000e0e, 0x01000e0e, 0x01000e0e, 0x01000e0e},
-        {0x0000a260, 0x3a021501, 0x3a021501, 0x3a021501, 0x3a021501},
-        {0x0000a264, 0x00000e0e, 0x00000e0e, 0x00000e0e, 0x00000e0e},
-        {0x0000a280, 0x00000007, 0x00000007, 0x0000000b, 0x0000000b},
-        {0x0000a284, 0x00000000, 0x00000000, 0x000002a0, 0x000002a0},
-        {0x0000a288, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
-        {0x0000a28c, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
-        {0x0000a2c4, 0x00158d18, 0x00158d18, 0x00158d18, 0x00158d18},
-        {0x0000a2d0, 0x00071981, 0x00071981, 0x00071981, 0x00071982},
-        {0x0000a2d8, 0xf999a83a, 0xf999a83a, 0xf999a83a, 0xf999a83a},
-        {0x0000a358, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
-        {0x0000be04, 0x00802020, 0x00802020, 0x00802020, 0x00802020},
-        {0x0000be18, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
-};
-static const u32 ar9485Modes_low_ob_db_tx_gain_1_0[][5] = {
-        /*  Addr      5G_HT20    5G_HT40     2G_HT40     2G_HT20   */
-        {0x0000a410, 0x000050d9, 0x000050d9, 0x000050d8, 0x000050d8},
-        {0x0000a500, 0x00022200, 0x00022200, 0x00000000, 0x00000000},
-        {0x0000a504, 0x05062002, 0x05062002, 0x04000002, 0x04000002},
-        {0x0000a508, 0x0c002e00, 0x0c002e00, 0x08000004, 0x08000004},
-        {0x0000a50c, 0x11062202, 0x11062202, 0x0d000200, 0x0d000200},
-        {0x0000a510, 0x17022e00, 0x17022e00, 0x11000202, 0x11000202},
-        {0x0000a514, 0x1d000ec2, 0x1d000ec2, 0x15000400, 0x15000400},
-        {0x0000a518, 0x25020ec0, 0x25020ec0, 0x19000402, 0x19000402},
-        {0x0000a51c, 0x2b020ec3, 0x2b020ec3, 0x1d000404, 0x1d000404},
-        {0x0000a520, 0x2f001f04, 0x2f001f04, 0x21000603, 0x21000603},
-        {0x0000a524, 0x35001fc4, 0x35001fc4, 0x25000605, 0x25000605},
-        {0x0000a528, 0x3c022f04, 0x3c022f04, 0x2a000a03, 0x2a000a03},
-        {0x0000a52c, 0x41023e85, 0x41023e85, 0x2c000a04, 0x2c000a04},
-        {0x0000a530, 0x48023ec6, 0x48023ec6, 0x2e000a20, 0x2e000a20},
-        {0x0000a534, 0x4d023f01, 0x4d023f01, 0x34000e20, 0x34000e20},
-        {0x0000a538, 0x53023f4b, 0x53023f4b, 0x38000e22, 0x38000e22},
-        {0x0000a53c, 0x5a027f09, 0x5a027f09, 0x3c000e24, 0x3c000e24},
-        {0x0000a540, 0x5f027fc9, 0x5f027fc9, 0x40000e26, 0x40000e26},
-        {0x0000a544, 0x6502feca, 0x6502feca, 0x43001640, 0x43001640},
-        {0x0000a548, 0x6b02ff4a, 0x6b02ff4a, 0x46001660, 0x46001660},
-        {0x0000a54c, 0x7203feca, 0x7203feca, 0x49001861, 0x49001861},
-        {0x0000a550, 0x7703ff0b, 0x7703ff0b, 0x4c001a81, 0x4c001a81},
-        {0x0000a554, 0x7d06ffcb, 0x7d06ffcb, 0x4f001a83, 0x4f001a83},
-        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x54001c85, 0x54001c85},
-        {0x0000a55c, 0x8907ffcb, 0x8907ffcb, 0x58001ce5, 0x58001ce5},
-        {0x0000a560, 0x900fff0b, 0x900fff0b, 0x5b001ce9, 0x5b001ce9},
-        {0x0000a564, 0x960fffcb, 0x960fffcb, 0x60001eeb, 0x60001eeb},
-        {0x0000a568, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a56c, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a570, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a574, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a578, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x0000a57c, 0x9c1fff0b, 0x9c1fff0b, 0x60001eeb, 0x60001eeb},
-        {0x00016044, 0x05b6b2db, 0x05b6b2db, 0x05b6b2db, 0x05b6b2db},
-};
-static const u32 ar9485_1_0_pcie_phy_clkreq_disable_L1[][2] = {
-        /*   Addr     allmodes */
-        {0x00018c00, 0x10213e5e},
-        {0x00018c04, 0x000801d8},
-        {0x00018c08, 0x0000580c},
-};
-static const u32 ar9485_1_0_radio_postamble[][2] = {
-        /*   Addr     allmodes */
-        {0x0001609c, 0x0b283f31},
-        {0x000160ac, 0x24611800},
-        {0x000160b0, 0x03284f3e},
-        {0x0001610c, 0x00170000},
-        {0x00016140, 0x10804008},
-};
-static const u32 ar9485_1_0_mac_core[][2] = {
-        /*  Addr      allmodes */
-        {0x00000008, 0x00000000},
-        {0x00000030, 0x00020085},
-        {0x00000034, 0x00000005},
-        {0x00000040, 0x00000000},
-        {0x00000044, 0x00000000},
-        {0x00000048, 0x00000008},
-        {0x0000004c, 0x00000010},
-        {0x00000050, 0x00000000},
-        {0x00001040, 0x002ffc0f},
-        {0x00001044, 0x002ffc0f},
-        {0x00001048, 0x002ffc0f},
-        {0x0000104c, 0x002ffc0f},
-        {0x00001050, 0x002ffc0f},
-        {0x00001054, 0x002ffc0f},
-        {0x00001058, 0x002ffc0f},
-        {0x0000105c, 0x002ffc0f},
-        {0x00001060, 0x002ffc0f},
-        {0x00001064, 0x002ffc0f},
-        {0x000010f0, 0x00000100},
-        {0x00001270, 0x00000000},
-        {0x000012b0, 0x00000000},
-        {0x000012f0, 0x00000000},
-        {0x0000143c, 0x00000000},
-        {0x0000147c, 0x00000000},
-        {0x00008000, 0x00000000},
-        {0x00008004, 0x00000000},
-        {0x00008008, 0x00000000},
-        {0x0000800c, 0x00000000},
-        {0x00008018, 0x00000000},
-        {0x00008020, 0x00000000},
-        {0x00008038, 0x00000000},
-        {0x0000803c, 0x00000000},
-        {0x00008040, 0x00000000},
-        {0x00008044, 0x00000000},
-        {0x00008048, 0x00000000},
-        {0x0000804c, 0xffffffff},
-        {0x00008054, 0x00000000},
-        {0x00008058, 0x00000000},
-        {0x0000805c, 0x000fc78f},
-        {0x00008060, 0x0000000f},
-        {0x00008064, 0x00000000},
-        {0x00008070, 0x00000310},
-        {0x00008074, 0x00000020},
-        {0x00008078, 0x00000000},
-        {0x0000809c, 0x0000000f},
-        {0x000080a0, 0x00000000},
-        {0x000080a4, 0x02ff0000},
-        {0x000080a8, 0x0e070605},
-        {0x000080ac, 0x0000000d},
-        {0x000080b0, 0x00000000},
-        {0x000080b4, 0x00000000},
-        {0x000080b8, 0x00000000},
-        {0x000080bc, 0x00000000},
-        {0x000080c0, 0x2a800000},
-        {0x000080c4, 0x06900168},
-        {0x000080c8, 0x13881c20},
-        {0x000080cc, 0x01f40000},
-        {0x000080d0, 0x00252500},
-        {0x000080d4, 0x00a00000},
-        {0x000080d8, 0x00400000},
-        {0x000080dc, 0x00000000},
-        {0x000080e0, 0xffffffff},
-        {0x000080e4, 0x0000ffff},
-        {0x000080e8, 0x3f3f3f3f},
-        {0x000080ec, 0x00000000},
-        {0x000080f0, 0x00000000},
-        {0x000080f4, 0x00000000},
-        {0x000080fc, 0x00020000},
-        {0x00008100, 0x00000000},
-        {0x00008108, 0x00000052},
-        {0x0000810c, 0x00000000},
-        {0x00008110, 0x00000000},
-        {0x00008114, 0x000007ff},
-        {0x00008118, 0x000000aa},
-        {0x0000811c, 0x00003210},
-        {0x00008124, 0x00000000},
-        {0x00008128, 0x00000000},
-        {0x0000812c, 0x00000000},
-        {0x00008130, 0x00000000},
-        {0x00008134, 0x00000000},
-        {0x00008138, 0x00000000},
-        {0x0000813c, 0x0000ffff},
-        {0x00008144, 0xffffffff},
-        {0x00008168, 0x00000000},
-        {0x0000816c, 0x00000000},
-        {0x00008170, 0x18486200},
-        {0x00008174, 0x33332210},
-        {0x00008178, 0x00000000},
-        {0x0000817c, 0x00020000},
-        {0x000081c0, 0x00000000},
-        {0x000081c4, 0x33332210},
-        {0x000081c8, 0x00000000},
-        {0x000081cc, 0x00000000},
-        {0x000081d4, 0x00000000},
-        {0x000081ec, 0x00000000},
-        {0x000081f0, 0x00000000},
-        {0x000081f4, 0x00000000},
-        {0x000081f8, 0x00000000},
-        {0x000081fc, 0x00000000},
-        {0x00008240, 0x00100000},
-        {0x00008244, 0x0010f400},
-        {0x00008248, 0x00000800},
-        {0x0000824c, 0x0001e800},
-        {0x00008250, 0x00000000},
-        {0x00008254, 0x00000000},
-        {0x00008258, 0x00000000},
-        {0x0000825c, 0x40000000},
-        {0x00008260, 0x00080922},
-        {0x00008264, 0x9ca00010},
-        {0x00008268, 0xffffffff},
-        {0x0000826c, 0x0000ffff},
-        {0x00008270, 0x00000000},
-        {0x00008274, 0x40000000},
-        {0x00008278, 0x003e4180},
-        {0x0000827c, 0x00000004},
-        {0x00008284, 0x0000002c},
-        {0x00008288, 0x0000002c},
-        {0x0000828c, 0x000000ff},
-        {0x00008294, 0x00000000},
-        {0x00008298, 0x00000000},
-        {0x0000829c, 0x00000000},
-        {0x00008300, 0x00000140},
-        {0x00008314, 0x00000000},
-        {0x0000831c, 0x0000010d},
-        {0x00008328, 0x00000000},
-        {0x0000832c, 0x00000007},
-        {0x00008330, 0x00000302},
-        {0x00008334, 0x00000700},
-        {0x00008338, 0x00ff0000},
-        {0x0000833c, 0x02400000},
-        {0x00008340, 0x000107ff},
-        {0x00008344, 0xa248105b},
-        {0x00008348, 0x008f0000},
-        {0x0000835c, 0x00000000},
-        {0x00008360, 0xffffffff},
-        {0x00008364, 0xffffffff},
-        {0x00008368, 0x00000000},
-        {0x00008370, 0x00000000},
-        {0x00008374, 0x000000ff},
-        {0x00008378, 0x00000000},
-        {0x0000837c, 0x00000000},
-        {0x00008380, 0xffffffff},
-        {0x00008384, 0xffffffff},
-        {0x00008390, 0xffffffff},
-        {0x00008394, 0xffffffff},
-        {0x00008398, 0x00000000},
-        {0x0000839c, 0x00000000},
-        {0x000083a0, 0x00000000},
-        {0x000083a4, 0x0000fa14},
-        {0x000083a8, 0x000f0c00},
-        {0x000083ac, 0x33332210},
-        {0x000083b0, 0x33332210},
-        {0x000083b4, 0x33332210},
-        {0x000083b8, 0x33332210},
-        {0x000083bc, 0x00000000},
-        {0x000083c0, 0x00000000},
-        {0x000083c4, 0x00000000},
-        {0x000083c8, 0x00000000},
-        {0x000083cc, 0x00000200},
-        {0x000083d0, 0x000301ff},
-};
 static const u32 ar9485_1_1_mac_core[][2] = {
        /*  Addr       allmodes */
        {0x00000008, 0x00000000},
@@ -1321,7 +396,7 @@ static const u32 ar9485Modes_high_ob_db_tx_gain_1_1[][5] = {
        {0x0000a54c, 0x7203feca, 0x7203feca, 0x51001865, 0x51001865},
        {0x0000a550, 0x7703ff0b, 0x7703ff0b, 0x55001a86, 0x55001a86},
        {0x0000a554, 0x7d06ffcb, 0x7d06ffcb, 0x57001ce9, 0x57001ce9},
-        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x5a001eeb, 0x5a001eeb},
+        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x5a001ceb, 0x5a001ceb},
        {0x0000a55c, 0x8907ffcb, 0x8907ffcb, 0x5e001eeb, 0x5e001eeb},
        {0x0000a560, 0x900fff0b, 0x900fff0b, 0x5e001eeb, 0x5e001eeb},
        {0x0000a564, 0x960fffcb, 0x960fffcb, 0x5e001eeb, 0x5e001eeb},
@@ -1394,7 +469,7 @@ static const u32 ar9485_modes_lowest_ob_db_tx_gain_1_1[][5] = {
        {0x0000a54c, 0x7203feca, 0x7203feca, 0x51001865, 0x51001865},
        {0x0000a550, 0x7703ff0b, 0x7703ff0b, 0x55001a86, 0x55001a86},
        {0x0000a554, 0x7d06ffcb, 0x7d06ffcb, 0x57001ce9, 0x57001ce9},
-        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x5a001eeb, 0x5a001eeb},
+        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x5a001ceb, 0x5a001ceb},
        {0x0000a55c, 0x8907ffcb, 0x8907ffcb, 0x5e001eeb, 0x5e001eeb},
        {0x0000a560, 0x900fff0b, 0x900fff0b, 0x5e001eeb, 0x5e001eeb},
        {0x0000a564, 0x960fffcb, 0x960fffcb, 0x5e001eeb, 0x5e001eeb},
@@ -1560,7 +635,7 @@ static const u32 ar9485Modes_high_power_tx_gain_1_1[][5] = {
        {0x0000a54c, 0x7203feca, 0x7203feca, 0x51001865, 0x51001865},
        {0x0000a550, 0x7703ff0b, 0x7703ff0b, 0x55001a86, 0x55001a86},
        {0x0000a554, 0x7d06ffcb, 0x7d06ffcb, 0x57001ce9, 0x57001ce9},
-        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x5a001eeb, 0x5a001eeb},
+        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x5a001ceb, 0x5a001ceb},
        {0x0000a55c, 0x8907ffcb, 0x8907ffcb, 0x5e001eeb, 0x5e001eeb},
        {0x0000a560, 0x900fff0b, 0x900fff0b, 0x5e001eeb, 0x5e001eeb},
        {0x0000a564, 0x960fffcb, 0x960fffcb, 0x5e001eeb, 0x5e001eeb},
@@ -1653,7 +728,7 @@ static const u32 ar9485_modes_green_ob_db_tx_gain_1_1[][5] = {
        {0x0000a54c, 0x7203feca, 0x7203feca, 0x51001865, 0x51001865},
        {0x0000a550, 0x7703ff0b, 0x7703ff0b, 0x55001a86, 0x55001a86},
        {0x0000a554, 0x7d06ffcb, 0x7d06ffcb, 0x57001ce9, 0x57001ce9},
-        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x5a001eeb, 0x5a001eeb},
+        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x5a001ceb, 0x5a001ceb},
        {0x0000a55c, 0x8907ffcb, 0x8907ffcb, 0x5e001eeb, 0x5e001eeb},
        {0x0000a560, 0x900fff0b, 0x900fff0b, 0x5e001eeb, 0x5e001eeb},
        {0x0000a564, 0x960fffcb, 0x960fffcb, 0x5e001eeb, 0x5e001eeb},
@@ -1752,7 +827,7 @@ static const u32 ar9485Modes_low_ob_db_tx_gain_1_1[][5] = {
        {0x0000a54c, 0x7203feca, 0x7203feca, 0x51001865, 0x51001865},
        {0x0000a550, 0x7703ff0b, 0x7703ff0b, 0x55001a86, 0x55001a86},
        {0x0000a554, 0x7d06ffcb, 0x7d06ffcb, 0x57001ce9, 0x57001ce9},
-        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x5a001eeb, 0x5a001eeb},
+        {0x0000a558, 0x8407ff0b, 0x8407ff0b, 0x5a001ceb, 0x5a001ceb},
        {0x0000a55c, 0x8907ffcb, 0x8907ffcb, 0x5e001eeb, 0x5e001eeb},
        {0x0000a560, 0x900fff0b, 0x900fff0b, 0x5e001eeb, 0x5e001eeb},
        {0x0000a564, 0x960fffcb, 0x960fffcb, 0x5e001eeb, 0x5e001eeb},
diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
index 099bd4183ad0..03b37d7be1c3 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/ath/ath9k/ath9k.h
@@ -62,7 +62,6 @@ struct ath_node;
 #define ATH_TXQ_SETUP(sc, i)        ((sc)->tx.txqsetup & (1<<i))
 struct ath_config {
-        u32 ath_aggr_prot;
        u16 txpowlimit;
        u8 cabqReadytime;
 };
@@ -120,13 +119,11 @@ void ath_descdma_cleanup(struct ath_softc *sc, struct ath_descdma *dd,
 /* RX / TX */
 /***********/
-#define ATH_MAX_ANTENNA         3
 #define ATH_RXBUF               512
 #define ATH_TXBUF               512
 #define ATH_TXBUF_RESERVE       5
 #define ATH_MAX_QDEPTH          (ATH_TXBUF / 4 - ATH_TXBUF_RESERVE)
 #define ATH_TXMAXTRY            13
-#define ATH_MGT_TXMAXTRY        4
 #define TID_TO_WME_AC(_tid)                             \
        ((((_tid) == 0) || ((_tid) == 3)) ? WME_AC_BE : \
@@ -202,6 +199,7 @@ struct ath_atx_ac {
        int sched;
        struct list_head list;
        struct list_head tid_q;
+        bool clear_ps_filter;
 };
 struct ath_frame_info {
@@ -257,8 +255,12 @@ struct ath_node {
 #endif
        struct ath_atx_tid tid[WME_NUM_TID];
        struct ath_atx_ac ac[WME_NUM_AC];
+        int ps_key;
        u16 maxampdu;
        u8 mpdudensity;
+        bool sleeping;
 };
 #define AGGR_CLEANUP         BIT(1)
@@ -340,17 +342,18 @@ int ath_tx_aggr_start(struct ath_softc *sc, struct ieee80211_sta *sta,
 void ath_tx_aggr_stop(struct ath_softc *sc, struct ieee80211_sta *sta, u16 tid);
 void ath_tx_aggr_resume(struct ath_softc *sc, struct ieee80211_sta *sta, u16 tid);
+void ath_tx_aggr_wakeup(struct ath_softc *sc, struct ath_node *an);
+bool ath_tx_aggr_sleep(struct ath_softc *sc, struct ath_node *an);
 /********/
 /* VIFs */
 /********/
 struct ath_vif {
        int av_bslot;
-        bool is_bslot_active;
+        bool is_bslot_active, primary_sta_vif;
        __le64 tsf_adjust; /* TSF adjustment for staggered beacons */
-        enum nl80211_iftype av_opmode;
        struct ath_buf *av_bcbuf;
-        u8 bssid[ETH_ALEN]; /* current BSSID from config_interface */
 };
 /*******************/
@@ -362,7 +365,7 @@ struct ath_vif {
 * number of BSSIDs) if a given beacon does not go out even after waiting this
 * number of beacon intervals, the game's up.
 */
-#define BSTUCK_THRESH                   (9 * ATH_BCBUF)
+#define BSTUCK_THRESH                   9
 #define ATH_BCBUF                       4
 #define ATH_DEFAULT_BINTVAL             100 /* TU */
 #define ATH_DEFAULT_BMISS_LIMIT         10
@@ -386,7 +389,7 @@ struct ath_beacon {
        u32 beaconq;
        u32 bmisscnt;
        u32 ast_be_xmit;
-        u64 bc_tstamp;
+        u32 bc_tstamp;
        struct ieee80211_vif *bslot[ATH_BCBUF];
        int slottime;
        int slotupdate;
@@ -401,6 +404,7 @@ void ath_beacon_config(struct ath_softc *sc, struct ieee80211_vif *vif);
 int ath_beacon_alloc(struct ath_softc *sc, struct ieee80211_vif *vif);
 void ath_beacon_return(struct ath_softc *sc, struct ath_vif *avp);
 int ath_beaconq_config(struct ath_softc *sc);
+void ath_set_beacon(struct ath_softc *sc);
 void ath9k_set_beaconing_status(struct ath_softc *sc, bool status);
 /*******/
@@ -418,6 +422,7 @@ void ath9k_set_beaconing_status(struct ath_softc *sc, bool status);
 #define ATH_PAPRD_TIMEOUT       100 /* msecs */
 void ath_hw_check(struct work_struct *work);
+void ath_hw_pll_work(struct work_struct *work);
 void ath_paprd_calibrate(struct work_struct *work);
 void ath_ani_calibrate(unsigned long data);
@@ -448,6 +453,7 @@ void ath9k_btcoex_timer_pause(struct ath_softc *sc);
 #define ATH_LED_PIN_DEF                 1
 #define ATH_LED_PIN_9287                8
+#define ATH_LED_PIN_9300                10
 #define ATH_LED_PIN_9485                6
 #ifdef CONFIG_MAC80211_LEDS
@@ -477,7 +483,6 @@ static inline void ath_deinit_leds(struct ath_softc *sc)
 #define ATH_ANT_DIV_COMB_ALT_ANT_RATIO 30
 #define ATH_ANT_DIV_COMB_ALT_ANT_RATIO2 20
-#define ATH_ANT_DIV_COMB_LNA1_LNA2_DELTA -3
 #define ATH_ANT_DIV_COMB_LNA1_LNA2_SWITCH_DELTA -1
 #define ATH_ANT_DIV_COMB_LNA1_DELTA_HI -4
 #define ATH_ANT_DIV_COMB_LNA1_DELTA_MID -2
@@ -550,6 +555,7 @@ struct ath_ant_comb {
 #define SC_OP_BT_SCAN                BIT(13)
 #define SC_OP_ANI_RUN                BIT(14)
 #define SC_OP_ENABLE_APM             BIT(15)
+#define SC_OP_PRIM_STA_VIF           BIT(16)
 /* Powersave flags */
 #define PS_WAIT_FOR_BEACON        BIT(0)
@@ -557,6 +563,7 @@ struct ath_ant_comb {
 #define PS_WAIT_FOR_PSPOLL_DATA   BIT(2)
 #define PS_WAIT_FOR_TX_ACK        BIT(3)
 #define PS_BEACON_SYNC            BIT(4)
+#define PS_TSFOOR_SYNC            BIT(5)
 struct ath_rate_table;
@@ -667,7 +674,7 @@ void ath_radio_disable(struct ath_softc *sc, struct ieee80211_hw *hw);
 bool ath9k_setpower(struct ath_softc *sc, enum ath9k_power_mode mode);
 bool ath9k_uses_beacons(int type);
-#ifdef CONFIG_PCI
+#ifdef CONFIG_ATH9K_PCI
 int ath_pci_init(void);
 void ath_pci_exit(void);
 #else
@@ -675,7 +682,7 @@ static inline int ath_pci_init(void) { return 0; };
 static inline void ath_pci_exit(void) {};
 #endif
-#ifdef CONFIG_ATHEROS_AR71XX
+#ifdef CONFIG_ATH9K_AHB
 int ath_ahb_init(void);
 void ath_ahb_exit(void);
 #else
@@ -688,8 +695,6 @@ void ath9k_ps_restore(struct ath_softc *sc);
 u8 ath_txchainmask_reduction(struct ath_softc *sc, u8 chainmask, u32 rate);
-void ath9k_set_bssid_mask(struct ieee80211_hw *hw, struct ieee80211_vif *vif);
 void ath_start_rfkill_poll(struct ath_softc *sc);
 extern void ath9k_rfkill_poll_state(struct ieee80211_hw *hw);
 void ath9k_calculate_iter_data(struct ieee80211_hw *hw,
diff --git a/drivers/net/wireless/ath/ath9k/beacon.c b/drivers/net/wireless/ath/ath9k/beacon.c
index 6d2a545fc35e..637dbc5f7b67 100644
--- a/drivers/net/wireless/ath/ath9k/beacon.c
+++ b/drivers/net/wireless/ath/ath9k/beacon.c
@@ -57,8 +57,8 @@ int ath_beaconq_config(struct ath_softc *sc)
 /*
 *  Associates the beacon frame buffer with a transmit descriptor.  Will set
- *  up all required antenna switch parameters, rate codes, and channel flags.
+ *  up rate codes, and channel flags. Beacons are always sent out at the
- *  Beacons are always sent out at the lowest rate, and are not retried.
+ *  lowest rate, and are not retried.
 */
 static void ath_beacon_setup(struct ath_softc *sc, struct ath_vif *avp,
                             struct ath_buf *bf, int rateidx)
@@ -68,7 +68,7 @@ static void ath_beacon_setup(struct ath_softc *sc, struct ath_vif *avp,
        struct ath_common *common = ath9k_hw_common(ah);
        struct ath_desc *ds;
        struct ath9k_11n_rate_series series[4];
-        int flags, antenna, ctsrate = 0, ctsduration = 0;
+        int flags, ctsrate = 0, ctsduration = 0;
        struct ieee80211_supported_band *sband;
        u8 rate = 0;
@@ -76,12 +76,6 @@ static void ath_beacon_setup(struct ath_softc *sc, struct ath_vif *avp,
        flags = ATH9K_TXDESC_NOACK;
        ds->ds_link = 0;
-        /*
-         * Switch antenna every beacon.
-         * Should only switch every beacon period, not for every SWBA
-         * XXX assumes two antennae
-         */
-        antenna = ((sc->beacon.ast_be_xmit / sc->nbcnvifs) & 1 ? 2 : 1);
        sband = &sc->sbands[common->hw->conf.channel->band];
        rate = sband->bitrates[rateidx].hw_value;
@@ -278,7 +272,7 @@ int ath_beacon_alloc(struct ath_softc *sc, struct ieee80211_vif *vif)
                return -ENOMEM;
        tstamp = ((struct ieee80211_mgmt *)skb->data)->u.beacon.timestamp;
-        sc->beacon.bc_tstamp = le64_to_cpu(tstamp);
+        sc->beacon.bc_tstamp = (u32) le64_to_cpu(tstamp);
        /* Calculate a TSF adjustment factor required for staggered beacons. */
        if (avp->av_bslot > 0) {
                u64 tsfadjust;
@@ -294,8 +288,8 @@ int ath_beacon_alloc(struct ath_softc *sc, struct ieee80211_vif *vif)
                 * adjustment. Other slots are adjusted to get the timestamp
                 * close to the TBTT for the BSS.
                 */
-                tsfadjust = intval * avp->av_bslot / ATH_BCBUF;
+                tsfadjust = TU_TO_USEC(intval * avp->av_bslot) / ATH_BCBUF;
-                avp->tsf_adjust = cpu_to_le64(TU_TO_USEC(tsfadjust));
+                avp->tsf_adjust = cpu_to_le64(tsfadjust);
                ath_dbg(common, ATH_DBG_BEACON,
                        "stagger beacons, bslot %d intval %u tsfadjust %llu\n",
@@ -326,9 +320,11 @@ void ath_beacon_return(struct ath_softc *sc, struct ath_vif *avp)
        if (avp->av_bcbuf != NULL) {
                struct ath_buf *bf;
+                avp->is_bslot_active = false;
                if (avp->av_bslot != -1) {
                        sc->beacon.bslot[avp->av_bslot] = NULL;
                        sc->nbcnvifs--;
+                        avp->av_bslot = -1;
                }
                bf = avp->av_bcbuf;
@@ -369,12 +365,13 @@ void ath_beacon_tasklet(unsigned long data)
        if (ath9k_hw_numtxpending(ah, sc->beacon.beaconq) != 0) {
                sc->beacon.bmisscnt++;
-                if (sc->beacon.bmisscnt < BSTUCK_THRESH) {
+                if (sc->beacon.bmisscnt < BSTUCK_THRESH * sc->nbcnvifs) {
                        ath_dbg(common, ATH_DBG_BSTUCK,
                                "missed %u consecutive beacons\n",
                                sc->beacon.bmisscnt);
                        ath9k_hw_stop_dma_queue(ah, sc->beacon.beaconq);
-                        ath9k_hw_bstuck_nfcal(ah);
+                        if (sc->beacon.bmisscnt > 3)
+                                ath9k_hw_bstuck_nfcal(ah);
                } else if (sc->beacon.bmisscnt >= BSTUCK_THRESH) {
                        ath_dbg(common, ATH_DBG_BSTUCK,
                                "beacon is officially stuck\n");
@@ -385,13 +382,6 @@ void ath_beacon_tasklet(unsigned long data)
                return;
        }
-        if (sc->beacon.bmisscnt != 0) {
-                ath_dbg(common, ATH_DBG_BSTUCK,
-                        "resume beacon xmit after %u misses\n",
-                        sc->beacon.bmisscnt);
-                sc->beacon.bmisscnt = 0;
-        }
        /*
         * Generate beacon frames. we are sending frames
         * staggered so calculate the slot for this frame based
@@ -401,21 +391,14 @@ void ath_beacon_tasklet(unsigned long data)
        intval = cur_conf->beacon_interval ? : ATH_DEFAULT_BINTVAL;
        tsf = ath9k_hw_gettsf64(ah);
-        tsftu = TSF_TO_TU(tsf>>32, tsf);
+        tsf += TU_TO_USEC(ah->config.sw_beacon_response_time);
-        slot = ((tsftu % intval) * ATH_BCBUF) / intval;
+        tsftu = TSF_TO_TU((tsf * ATH_BCBUF) >>32, tsf * ATH_BCBUF);
-        /*
+        slot = (tsftu % (intval * ATH_BCBUF)) / intval;
-         * Reverse the slot order to get slot 0 on the TBTT offset that does
-         * not require TSF adjustment and other slots adding
-         * slot/ATH_BCBUF * beacon_int to timestamp. For example, with
-         * ATH_BCBUF = 4, we process beacon slots as follows: 3 2 1 0 3 2 1 ..
-         * and slot 0 is at correct offset to TBTT.
-         */
-        slot = ATH_BCBUF - slot - 1;
        vif = sc->beacon.bslot[slot];
        ath_dbg(common, ATH_DBG_BEACON,
                "slot %d [tsf %llu tsftu %u intval %u] vif %p\n",
-                slot, tsf, tsftu, intval, vif);
+                slot, tsf, tsftu / ATH_BCBUF, intval, vif);
        bfaddr = 0;
        if (vif) {
@@ -424,6 +407,13 @@ void ath_beacon_tasklet(unsigned long data)
                        bfaddr = bf->bf_daddr;
                        bc = 1;
                }
+                if (sc->beacon.bmisscnt != 0) {
+                        ath_dbg(common, ATH_DBG_BSTUCK,
+                                "resume beacon xmit after %u misses\n",
+                                sc->beacon.bmisscnt);
+                        sc->beacon.bmisscnt = 0;
+                }
        }
        /*
@@ -463,13 +453,17 @@ static void ath9k_beacon_init(struct ath_softc *sc,
                              u32 next_beacon,
                              u32 beacon_period)
 {
-        if (beacon_period & ATH9K_BEACON_RESET_TSF)
+        if (sc->sc_flags & SC_OP_TSF_RESET) {
                ath9k_ps_wakeup(sc);
+                ath9k_hw_reset_tsf(sc->sc_ah);
+        }
        ath9k_hw_beaconinit(sc->sc_ah, next_beacon, beacon_period);
-        if (beacon_period & ATH9K_BEACON_RESET_TSF)
+        if (sc->sc_flags & SC_OP_TSF_RESET) {
                ath9k_ps_restore(sc);
+                sc->sc_flags &= ~SC_OP_TSF_RESET;
+        }
 }
 /*
@@ -484,18 +478,14 @@ static void ath_beacon_config_ap(struct ath_softc *sc,
        u32 nexttbtt, intval;
        /* NB: the beacon interval is kept internally in TU's */
-        intval = conf->beacon_interval & ATH9K_BEACON_PERIOD;
+        intval = TU_TO_USEC(conf->beacon_interval & ATH9K_BEACON_PERIOD);
        intval /= ATH_BCBUF;    /* for staggered beacons */
        nexttbtt = intval;
-        if (sc->sc_flags & SC_OP_TSF_RESET)
-                intval |= ATH9K_BEACON_RESET_TSF;
        /*
         * In AP mode we enable the beacon timers and SWBA interrupts to
         * prepare beacon frames.
         */
-        intval |= ATH9K_BEACON_ENA;
        ah->imask |= ATH9K_INT_SWBA;
        ath_beaconq_config(sc);
@@ -505,11 +495,6 @@ static void ath_beacon_config_ap(struct ath_softc *sc,
        ath9k_beacon_init(sc, nexttbtt, intval);
        sc->beacon.bmisscnt = 0;
        ath9k_hw_set_interrupts(ah, ah->imask);
-        /* Clear the reset TSF flag, so that subsequent beacon updation
-           will not reset the HW TSF. */
-        sc->sc_flags &= ~SC_OP_TSF_RESET;
 }
 /*
@@ -635,7 +620,13 @@ static void ath_beacon_config_sta(struct ath_softc *sc,
        ath9k_hw_disable_interrupts(ah);
        ath9k_hw_set_sta_beacon_timers(ah, &bs);
        ah->imask |= ATH9K_INT_BMISS;
-        ath9k_hw_set_interrupts(ah, ah->imask);
+        /*
+         * If the beacon config is called beacause of TSFOOR,
+         * Interrupts will be enabled back at the end of ath9k_tasklet
+         */
+        if (!(sc->ps_flags & PS_TSFOOR_SYNC))
+                ath9k_hw_set_interrupts(ah, ah->imask);
 }
 static void ath_beacon_config_adhoc(struct ath_softc *sc,
@@ -643,25 +634,20 @@ static void ath_beacon_config_adhoc(struct ath_softc *sc,
 {
        struct ath_hw *ah = sc->sc_ah;
        struct ath_common *common = ath9k_hw_common(ah);
-        u64 tsf;
+        u32 tsf, delta, intval, nexttbtt;
-        u32 tsftu, intval, nexttbtt;
+        tsf = ath9k_hw_gettsf32(ah) + TU_TO_USEC(FUDGE);
-        intval = conf->beacon_interval & ATH9K_BEACON_PERIOD;
+        intval = TU_TO_USEC(conf->beacon_interval & ATH9K_BEACON_PERIOD);
+        if (!sc->beacon.bc_tstamp)
-        /* Pull nexttbtt forward to reflect the current TSF */
+                nexttbtt = tsf + intval;
+        else {
-        nexttbtt = TSF_TO_TU(sc->beacon.bc_tstamp >> 32, sc->beacon.bc_tstamp);
+                if (tsf > sc->beacon.bc_tstamp)
-        if (nexttbtt == 0)
+                        delta = (tsf - sc->beacon.bc_tstamp);
-                nexttbtt = intval;
+                else
-        else if (intval)
+                        delta = (tsf + 1 + (~0U - sc->beacon.bc_tstamp));
-                nexttbtt = roundup(nexttbtt, intval);
+                nexttbtt = tsf + roundup(delta, intval);
+        }
-        tsf = ath9k_hw_gettsf64(ah);
-        tsftu = TSF_TO_TU((u32)(tsf>>32), (u32)tsf) + FUDGE;
-        do {
-                nexttbtt += intval;
-        } while (nexttbtt < tsftu);
        ath_dbg(common, ATH_DBG_BEACON,
                "IBSS nexttbtt %u intval %u (%u)\n",
@@ -672,7 +658,6 @@ static void ath_beacon_config_adhoc(struct ath_softc *sc,
         * if we need to manually prepare beacon frames.  Otherwise we use a
         * self-linked tx descriptor and let the hardware deal with things.
         */
-        intval |= ATH9K_BEACON_ENA;
        ah->imask |= ATH9K_INT_SWBA;
        ath_beaconq_config(sc);
@@ -682,25 +667,71 @@ static void ath_beacon_config_adhoc(struct ath_softc *sc,
        ath9k_hw_disable_interrupts(ah);
        ath9k_beacon_init(sc, nexttbtt, intval);
        sc->beacon.bmisscnt = 0;
-        ath9k_hw_set_interrupts(ah, ah->imask);
+        /*
+         * If the beacon config is called beacause of TSFOOR,
+         * Interrupts will be enabled back at the end of ath9k_tasklet
+         */
+        if (!(sc->ps_flags & PS_TSFOOR_SYNC))
+                ath9k_hw_set_interrupts(ah, ah->imask);
 }
-void ath_beacon_config(struct ath_softc *sc, struct ieee80211_vif *vif)
+static bool ath9k_allow_beacon_config(struct ath_softc *sc,
+                                      struct ieee80211_vif *vif)
 {
        struct ath_beacon_config *cur_conf = &sc->cur_beacon_conf;
        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
-        enum nl80211_iftype iftype;
+        struct ieee80211_bss_conf *bss_conf = &vif->bss_conf;
+        struct ath_vif *avp = (void *)vif->drv_priv;
-        /* Setup the beacon configuration parameters */
+        /*
-        if (vif) {
+         * Can not have different beacon interval on multiple
-                struct ieee80211_bss_conf *bss_conf = &vif->bss_conf;
+         * AP interface case
-                iftype = vif->type;
+         */
-                cur_conf->beacon_interval = bss_conf->beacon_int;
+        if ((sc->sc_ah->opmode == NL80211_IFTYPE_AP) &&
-                cur_conf->dtim_period = bss_conf->dtim_period;
+            (sc->nbcnvifs > 1) &&
-        } else {
+            (vif->type == NL80211_IFTYPE_AP) &&
-                iftype = sc->sc_ah->opmode;
+            (cur_conf->beacon_interval != bss_conf->beacon_int)) {
+                ath_dbg(common, ATH_DBG_CONFIG,
+                        "Changing beacon interval of multiple \
+                        AP interfaces !\n");
+                return false;
        }
+        /*
+         * Can not configure station vif's beacon config
+         * while on AP opmode
+         */
+        if ((sc->sc_ah->opmode == NL80211_IFTYPE_AP) &&
+            (vif->type != NL80211_IFTYPE_AP)) {
+                ath_dbg(common, ATH_DBG_CONFIG,
+                        "STA vif's beacon not allowed on AP mode\n");
+                return false;
+        }
+        /*
+         * Do not allow beacon config if HW was already configured
+         * with another STA vif
+         */
+        if ((sc->sc_ah->opmode == NL80211_IFTYPE_STATION) &&
+            (vif->type == NL80211_IFTYPE_STATION) &&
+            (sc->sc_flags & SC_OP_BEACONS) &&
+            !avp->primary_sta_vif) {
+                ath_dbg(common, ATH_DBG_CONFIG,
+                        "Beacon already configured for a station interface\n");
+                return false;
+        }
+        return true;
+}
+void ath_beacon_config(struct ath_softc *sc, struct ieee80211_vif *vif)
+{
+        struct ath_beacon_config *cur_conf = &sc->cur_beacon_conf;
+        struct ieee80211_bss_conf *bss_conf = &vif->bss_conf;
+        if (!ath9k_allow_beacon_config(sc, vif))
+                return;
+        /* Setup the beacon configuration parameters */
+        cur_conf->beacon_interval = bss_conf->beacon_int;
+        cur_conf->dtim_period = bss_conf->dtim_period;
        cur_conf->listen_interval = 1;
        cur_conf->dtim_count = 1;
        cur_conf->bmiss_timeout =
@@ -723,9 +754,37 @@ void ath_beacon_config(struct ath_softc *sc, struct ieee80211_vif *vif)
        if (cur_conf->dtim_period == 0)
                cur_conf->dtim_period = 1;
-        switch (iftype) {
+        ath_set_beacon(sc);
+}
+static bool ath_has_valid_bslot(struct ath_softc *sc)
+{
+        struct ath_vif *avp;
+        int slot;
+        bool found = false;
+        for (slot = 0; slot < ATH_BCBUF; slot++) {
+                if (sc->beacon.bslot[slot]) {
+                        avp = (void *)sc->beacon.bslot[slot]->drv_priv;
+                        if (avp->is_bslot_active) {
+                                found = true;
+                                break;
+                        }
+                }
+        }
+        return found;
+}
+void ath_set_beacon(struct ath_softc *sc)
+{
+        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+        struct ath_beacon_config *cur_conf = &sc->cur_beacon_conf;
+        switch (sc->sc_ah->opmode) {
        case NL80211_IFTYPE_AP:
-                ath_beacon_config_ap(sc, cur_conf);
+                if (ath_has_valid_bslot(sc))
+                        ath_beacon_config_ap(sc, cur_conf);
                break;
        case NL80211_IFTYPE_ADHOC:
        case NL80211_IFTYPE_MESH_POINT:
@@ -746,26 +805,15 @@ void ath_beacon_config(struct ath_softc *sc, struct ieee80211_vif *vif)
 void ath9k_set_beaconing_status(struct ath_softc *sc, bool status)
 {
        struct ath_hw *ah = sc->sc_ah;
-        struct ath_vif *avp;
-        int slot;
+        if (!ath_has_valid_bslot(sc))
-        bool found = false;
+                return;
        ath9k_ps_wakeup(sc);
        if (status) {
-                for (slot = 0; slot < ATH_BCBUF; slot++) {
+                /* Re-enable beaconing */
-                        if (sc->beacon.bslot[slot]) {
+                ah->imask |= ATH9K_INT_SWBA;
-                                avp = (void *)sc->beacon.bslot[slot]->drv_priv;
+                ath9k_hw_set_interrupts(ah, ah->imask);
-                                if (avp->is_bslot_active) {
-                                        found = true;
-                                        break;
-                                }
-                        }
-                }
-                if (found) {
-                        /* Re-enable beaconing */
-                        ah->imask |= ATH9K_INT_SWBA;
-                        ath9k_hw_set_interrupts(ah, ah->imask);
-                }
        } else {
                /* Disable SWBA interrupt */
                ah->imask &= ~ATH9K_INT_SWBA;
diff --git a/drivers/net/wireless/ath/ath9k/btcoex.c b/drivers/net/wireless/ath/ath9k/btcoex.c
index d33bf204c995..23f15a7ca7f1 100644
--- a/drivers/net/wireless/ath/ath9k/btcoex.c
+++ b/drivers/net/wireless/ath/ath9k/btcoex.c
@@ -51,6 +51,10 @@ void ath9k_hw_init_btcoex_hw(struct ath_hw *ah, int qnum)
                .bt_hold_rx_clear = true,
        };
        u32 i;
+        bool rxclear_polarity = ath_bt_config.bt_rxclear_polarity;
+        if (AR_SREV_9300_20_OR_LATER(ah))
+                rxclear_polarity = !ath_bt_config.bt_rxclear_polarity;
        btcoex_hw->bt_coex_mode =
                (btcoex_hw->bt_coex_mode & AR_BT_QCU_THRESH) |
@@ -59,7 +63,7 @@ void ath9k_hw_init_btcoex_hw(struct ath_hw *ah, int qnum)
                SM(ath_bt_config.bt_txframe_extend, AR_BT_TX_FRAME_EXTEND) |
                SM(ath_bt_config.bt_mode, AR_BT_MODE) |
                SM(ath_bt_config.bt_quiet_collision, AR_BT_QUIET) |
-                SM(ath_bt_config.bt_rxclear_polarity, AR_BT_RX_CLEAR_POLARITY) |
+                SM(rxclear_polarity, AR_BT_RX_CLEAR_POLARITY) |
                SM(ath_bt_config.bt_priority_time, AR_BT_PRIORITY_TIME) |
                SM(ath_bt_config.bt_first_slot_time, AR_BT_FIRST_SLOT_TIME) |
                SM(qnum, AR_BT_QCU_THRESH);
@@ -142,6 +146,7 @@ void ath9k_hw_btcoex_set_weight(struct ath_hw *ah,
 }
 EXPORT_SYMBOL(ath9k_hw_btcoex_set_weight);
 static void ath9k_hw_btcoex_enable_3wire(struct ath_hw *ah)
 {
        struct ath_btcoex_hw *btcoex_hw = &ah->btcoex_hw;
@@ -152,9 +157,22 @@ static void ath9k_hw_btcoex_enable_3wire(struct ath_hw *ah)
         * enable coex 3-wire
         */
        REG_WRITE(ah, AR_BT_COEX_MODE, btcoex_hw->bt_coex_mode);
-        REG_WRITE(ah, AR_BT_COEX_WEIGHT, btcoex_hw->bt_coex_weights);
        REG_WRITE(ah, AR_BT_COEX_MODE2, btcoex_hw->bt_coex_mode2);
+        if (AR_SREV_9300_20_OR_LATER(ah)) {
+                REG_WRITE(ah, AR_BT_COEX_WL_WEIGHTS0, ah->bt_coex_wlan_weight[0]);
+                REG_WRITE(ah, AR_BT_COEX_WL_WEIGHTS1, ah->bt_coex_wlan_weight[1]);
+                REG_WRITE(ah, AR_BT_COEX_BT_WEIGHTS0, ah->bt_coex_bt_weight[0]);
+                REG_WRITE(ah, AR_BT_COEX_BT_WEIGHTS1, ah->bt_coex_bt_weight[1]);
+                REG_WRITE(ah, AR_BT_COEX_BT_WEIGHTS2, ah->bt_coex_bt_weight[2]);
+                REG_WRITE(ah, AR_BT_COEX_BT_WEIGHTS3, ah->bt_coex_bt_weight[3]);
+        } else
+                REG_WRITE(ah, AR_BT_COEX_WEIGHT, btcoex_hw->bt_coex_weights);
        if (AR_SREV_9271(ah)) {
                val = REG_READ(ah, 0x50040);
                val &= 0xFFFFFEFF;
@@ -202,10 +220,86 @@ void ath9k_hw_btcoex_disable(struct ath_hw *ah)
        if (btcoex_hw->scheme == ATH_BTCOEX_CFG_3WIRE) {
                REG_WRITE(ah, AR_BT_COEX_MODE, AR_BT_QUIET | AR_BT_MODE);
-                REG_WRITE(ah, AR_BT_COEX_WEIGHT, 0);
                REG_WRITE(ah, AR_BT_COEX_MODE2, 0);
+                if (AR_SREV_9300_20_OR_LATER(ah)) {
+                        REG_WRITE(ah, AR_BT_COEX_WL_WEIGHTS0, 0);
+                        REG_WRITE(ah, AR_BT_COEX_WL_WEIGHTS1, 0);
+                        REG_WRITE(ah, AR_BT_COEX_BT_WEIGHTS0, 0);
+                        REG_WRITE(ah, AR_BT_COEX_BT_WEIGHTS1, 0);
+                        REG_WRITE(ah, AR_BT_COEX_BT_WEIGHTS2, 0);
+                        REG_WRITE(ah, AR_BT_COEX_BT_WEIGHTS3, 0);
+                } else
+                        REG_WRITE(ah, AR_BT_COEX_WEIGHT, 0);
        }
        ah->btcoex_hw.enabled = false;
 }
 EXPORT_SYMBOL(ath9k_hw_btcoex_disable);
+static void ar9003_btcoex_bt_stomp(struct ath_hw *ah,
+                         enum ath_stomp_type stomp_type)
+{
+        ah->bt_coex_bt_weight[0] = AR9300_BT_WGHT;
+        ah->bt_coex_bt_weight[1] = AR9300_BT_WGHT;
+        ah->bt_coex_bt_weight[2] = AR9300_BT_WGHT;
+        ah->bt_coex_bt_weight[3] = AR9300_BT_WGHT;
+        switch (stomp_type) {
+        case ATH_BTCOEX_STOMP_ALL:
+                ah->bt_coex_wlan_weight[0] = AR9300_STOMP_ALL_WLAN_WGHT0;
+                ah->bt_coex_wlan_weight[1] = AR9300_STOMP_ALL_WLAN_WGHT1;
+                break;
+        case ATH_BTCOEX_STOMP_LOW:
+                ah->bt_coex_wlan_weight[0] = AR9300_STOMP_LOW_WLAN_WGHT0;
+                ah->bt_coex_wlan_weight[1] = AR9300_STOMP_LOW_WLAN_WGHT1;
+                break;
+        case ATH_BTCOEX_STOMP_NONE:
+                ah->bt_coex_wlan_weight[0] = AR9300_STOMP_NONE_WLAN_WGHT0;
+                ah->bt_coex_wlan_weight[1] = AR9300_STOMP_NONE_WLAN_WGHT1;
+                break;
+        default:
+                ath_dbg(ath9k_hw_common(ah), ATH_DBG_BTCOEX,
+                                "Invalid Stomptype\n");
+                break;
+        }
+        ath9k_hw_btcoex_enable(ah);
+}
+/*
+ * Configures appropriate weight based on stomp type.
+ */
+void ath9k_hw_btcoex_bt_stomp(struct ath_hw *ah,
+                              enum ath_stomp_type stomp_type)
+{
+        if (AR_SREV_9300_20_OR_LATER(ah)) {
+                ar9003_btcoex_bt_stomp(ah, stomp_type);
+                return;
+        }
+        switch (stomp_type) {
+        case ATH_BTCOEX_STOMP_ALL:
+                ath9k_hw_btcoex_set_weight(ah, AR_BT_COEX_WGHT,
+                                AR_STOMP_ALL_WLAN_WGHT);
+                break;
+        case ATH_BTCOEX_STOMP_LOW:
+                ath9k_hw_btcoex_set_weight(ah, AR_BT_COEX_WGHT,
+                                AR_STOMP_LOW_WLAN_WGHT);
+                break;
+        case ATH_BTCOEX_STOMP_NONE:
+                ath9k_hw_btcoex_set_weight(ah, AR_BT_COEX_WGHT,
+                                AR_STOMP_NONE_WLAN_WGHT);
+                break;
+        default:
+                ath_dbg(ath9k_hw_common(ah), ATH_DBG_BTCOEX,
+                                "Invalid Stomptype\n");
+                break;
+        }
+        ath9k_hw_btcoex_enable(ah);
+}
+EXPORT_SYMBOL(ath9k_hw_btcoex_bt_stomp);
diff --git a/drivers/net/wireless/ath/ath9k/btcoex.h b/drivers/net/wireless/ath/ath9k/btcoex.h
index 588dfd464dd1..a9efca83d676 100644
--- a/drivers/net/wireless/ath/ath9k/btcoex.h
+++ b/drivers/net/wireless/ath/ath9k/btcoex.h
@@ -19,9 +19,13 @@
 #include "hw.h"
-#define ATH_WLANACTIVE_GPIO     5
+#define ATH_WLANACTIVE_GPIO_9280     5
-#define ATH_BTACTIVE_GPIO       6
+#define ATH_BTACTIVE_GPIO_9280       6
-#define ATH_BTPRIORITY_GPIO     7
+#define ATH_BTPRIORITY_GPIO_9285     7
+#define ATH_WLANACTIVE_GPIO_9300     5
+#define ATH_BTACTIVE_GPIO_9300       4
+#define ATH_BTPRIORITY_GPIO_9300     8
 #define ATH_BTCOEX_DEF_BT_PERIOD  45
 #define ATH_BTCOEX_DEF_DUTY_CYCLE 55
@@ -32,6 +36,14 @@
 #define ATH_BT_CNT_THRESHOLD           3
 #define ATH_BT_CNT_SCAN_THRESHOLD      15
+/* Defines the BT AR_BT_COEX_WGHT used */
+enum ath_stomp_type {
+        ATH_BTCOEX_NO_STOMP,
+        ATH_BTCOEX_STOMP_ALL,
+        ATH_BTCOEX_STOMP_LOW,
+        ATH_BTCOEX_STOMP_NONE
+};
 enum ath_btcoex_scheme {
        ATH_BTCOEX_CFG_NONE,
        ATH_BTCOEX_CFG_2WIRE,
@@ -57,5 +69,7 @@ void ath9k_hw_btcoex_set_weight(struct ath_hw *ah,
                                u32 wlan_weight);
 void ath9k_hw_btcoex_enable(struct ath_hw *ah);
 void ath9k_hw_btcoex_disable(struct ath_hw *ah);
+void ath9k_hw_btcoex_bt_stomp(struct ath_hw *ah,
+                              enum ath_stomp_type stomp_type);
 #endif
diff --git a/drivers/net/wireless/ath/ath9k/calib.c b/drivers/net/wireless/ath/ath9k/calib.c
index 8649581fa4dd..558b228a717f 100644
--- a/drivers/net/wireless/ath/ath9k/calib.c
+++ b/drivers/net/wireless/ath/ath9k/calib.c
@@ -69,15 +69,21 @@ static void ath9k_hw_update_nfcal_hist_buffer(struct ath_hw *ah,
                                              int16_t *nfarray)
 {
        struct ath_common *common = ath9k_hw_common(ah);
+        struct ieee80211_conf *conf = &common->hw->conf;
        struct ath_nf_limits *limit;
        struct ath9k_nfcal_hist *h;
        bool high_nf_mid = false;
+        u8 chainmask = (ah->rxchainmask << 3) | ah->rxchainmask;
        int i;
        h = cal->nfCalHist;
        limit = ath9k_hw_get_nf_limits(ah, ah->curchan);
        for (i = 0; i < NUM_NF_READINGS; i++) {
+                if (!(chainmask & (1 << i)) ||
+                    ((i >= AR5416_MAX_CHAINS) && !conf_is_ht40(conf)))
+                        continue;
                h[i].nfCalBuffer[h[i].currIndex] = nfarray[i];
                if (++h[i].currIndex >= ATH9K_NF_CAL_HIST_MAX)
@@ -225,6 +231,7 @@ void ath9k_hw_loadnf(struct ath_hw *ah, struct ath9k_channel *chan)
        int32_t val;
        u8 chainmask = (ah->rxchainmask << 3) | ah->rxchainmask;
        struct ath_common *common = ath9k_hw_common(ah);
+        struct ieee80211_conf *conf = &common->hw->conf;
        s16 default_nf = ath9k_hw_get_default_nf(ah, chan);
        if (ah->caldata)
@@ -234,6 +241,9 @@ void ath9k_hw_loadnf(struct ath_hw *ah, struct ath9k_channel *chan)
                if (chainmask & (1 << i)) {
                        s16 nfval;
+                        if ((i >= AR5416_MAX_CHAINS) && !conf_is_ht40(conf))
+                                continue;
                        if (h)
                                nfval = h[i].privNF;
                        else
@@ -293,6 +303,9 @@ void ath9k_hw_loadnf(struct ath_hw *ah, struct ath9k_channel *chan)
        ENABLE_REGWRITE_BUFFER(ah);
        for (i = 0; i < NUM_NF_READINGS; i++) {
                if (chainmask & (1 << i)) {
+                        if ((i >= AR5416_MAX_CHAINS) && !conf_is_ht40(conf))
+                                continue;
                        val = REG_READ(ah, ah->nf_regs[i]);
                        val &= 0xFFFFFE00;
                        val |= (((u32) (-50) << 1) & 0x1ff);
@@ -396,14 +409,6 @@ void ath9k_init_nfcal_hist_buffer(struct ath_hw *ah,
        }
 }
-s16 ath9k_hw_getchan_noise(struct ath_hw *ah, struct ath9k_channel *chan)
-{
-        if (!ah->curchan || !ah->curchan->noisefloor)
-                return ath9k_hw_get_default_nf(ah, chan);
-        return ah->curchan->noisefloor;
-}
-EXPORT_SYMBOL(ath9k_hw_getchan_noise);
 void ath9k_hw_bstuck_nfcal(struct ath_hw *ah)
 {
diff --git a/drivers/net/wireless/ath/ath9k/calib.h b/drivers/net/wireless/ath/ath9k/calib.h
index b8973eb8d858..4420780fa3b8 100644
--- a/drivers/net/wireless/ath/ath9k/calib.h
+++ b/drivers/net/wireless/ath/ath9k/calib.h
@@ -106,7 +106,6 @@ bool ath9k_hw_getnf(struct ath_hw *ah, struct ath9k_channel *chan);
 void ath9k_init_nfcal_hist_buffer(struct ath_hw *ah,
                                  struct ath9k_channel *chan);
 void ath9k_hw_bstuck_nfcal(struct ath_hw *ah);
-s16 ath9k_hw_getchan_noise(struct ath_hw *ah, struct ath9k_channel *chan);
 void ath9k_hw_reset_calibration(struct ath_hw *ah,
                                struct ath9k_cal_list *currCal);
diff --git a/drivers/net/wireless/ath/ath9k/common.c b/drivers/net/wireless/ath/ath9k/common.c
index 615e68276e72..74535e6dfb82 100644
--- a/drivers/net/wireless/ath/ath9k/common.c
+++ b/drivers/net/wireless/ath/ath9k/common.c
@@ -116,7 +116,7 @@ void ath9k_cmn_update_ichannel(struct ath9k_channel *ichan,
        if (chan->band == IEEE80211_BAND_2GHZ) {
                ichan->chanmode = CHANNEL_G;
-                ichan->channelFlags = CHANNEL_2GHZ | CHANNEL_OFDM | CHANNEL_G;
+                ichan->channelFlags = CHANNEL_2GHZ | CHANNEL_OFDM;
        } else {
                ichan->chanmode = CHANNEL_A;
                ichan->channelFlags = CHANNEL_5GHZ | CHANNEL_OFDM;
@@ -158,37 +158,6 @@ int ath9k_cmn_count_streams(unsigned int chainmask, int max)
 }
 EXPORT_SYMBOL(ath9k_cmn_count_streams);
-/*
- * Configures appropriate weight based on stomp type.
- */
-void ath9k_cmn_btcoex_bt_stomp(struct ath_common *common,
-                                  enum ath_stomp_type stomp_type)
-{
-        struct ath_hw *ah = common->ah;
-        switch (stomp_type) {
-        case ATH_BTCOEX_STOMP_ALL:
-                ath9k_hw_btcoex_set_weight(ah, AR_BT_COEX_WGHT,
-                                           AR_STOMP_ALL_WLAN_WGHT);
-                break;
-        case ATH_BTCOEX_STOMP_LOW:
-                ath9k_hw_btcoex_set_weight(ah, AR_BT_COEX_WGHT,
-                                           AR_STOMP_LOW_WLAN_WGHT);
-                break;
-        case ATH_BTCOEX_STOMP_NONE:
-                ath9k_hw_btcoex_set_weight(ah, AR_BT_COEX_WGHT,
-                                           AR_STOMP_NONE_WLAN_WGHT);
-                break;
-        default:
-                ath_dbg(common, ATH_DBG_BTCOEX,
-                        "Invalid Stomptype\n");
-                break;
-        }
-        ath9k_hw_btcoex_enable(ah);
-}
-EXPORT_SYMBOL(ath9k_cmn_btcoex_bt_stomp);
 void ath9k_cmn_update_txpow(struct ath_hw *ah, u16 cur_txpow,
                            u16 new_txpow, u16 *txpower)
 {
diff --git a/drivers/net/wireless/ath/ath9k/common.h b/drivers/net/wireless/ath/ath9k/common.h
index b2f7b5f89097..5124f1420b3a 100644
--- a/drivers/net/wireless/ath/ath9k/common.h
+++ b/drivers/net/wireless/ath/ath9k/common.h
@@ -50,14 +50,6 @@
 #define ATH_EP_RND(x, mul)                                              \
        ((((x)%(mul)) >= ((mul)/2)) ? ((x) + ((mul) - 1)) / (mul) : (x)/(mul))
-/* Defines the BT AR_BT_COEX_WGHT used */
-enum ath_stomp_type {
-        ATH_BTCOEX_NO_STOMP,
-        ATH_BTCOEX_STOMP_ALL,
-        ATH_BTCOEX_STOMP_LOW,
-        ATH_BTCOEX_STOMP_NONE
-};
 int ath9k_cmn_padpos(__le16 frame_control);
 int ath9k_cmn_get_hw_crypto_keytype(struct sk_buff *skb);
 void ath9k_cmn_update_ichannel(struct ath9k_channel *ichan,
diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c
index 8df5a92a20f1..bad1a87249b6 100644
--- a/drivers/net/wireless/ath/ath9k/debug.c
+++ b/drivers/net/wireless/ath/ath9k/debug.c
@@ -326,6 +326,8 @@ void ath_debug_stat_interrupt(struct ath_softc *sc, enum ath9k_int status)
                sc->debug.stats.istats.dtimsync++;
        if (status & ATH9K_INT_DTIM)
                sc->debug.stats.istats.dtim++;
+        if (status & ATH9K_INT_TSFOOR)
+                sc->debug.stats.istats.tsfoor++;
 }
 static ssize_t read_file_interrupt(struct file *file, char __user *user_buf,
@@ -380,8 +382,11 @@ static ssize_t read_file_interrupt(struct file *file, char __user *user_buf,
        len += snprintf(buf + len, sizeof(buf) - len,
                "%8s: %10u\n", "DTIM", sc->debug.stats.istats.dtim);
        len += snprintf(buf + len, sizeof(buf) - len,
+                "%8s: %10u\n", "TSFOOR", sc->debug.stats.istats.tsfoor);
+        len += snprintf(buf + len, sizeof(buf) - len,
                "%8s: %10u\n", "TOTAL", sc->debug.stats.istats.total);
        if (len > sizeof(buf))
                len = sizeof(buf);
@@ -845,7 +850,7 @@ static ssize_t read_file_recv(struct file *file, char __user *user_buf,
        struct ath_softc *sc = file->private_data;
        char *buf;
-        unsigned int len = 0, size = 1152;
+        unsigned int len = 0, size = 1400;
        ssize_t retval = 0;
        buf = kzalloc(size, GFP_KERNEL);
@@ -874,6 +879,34 @@ static ssize_t read_file_recv(struct file *file, char __user *user_buf,
                        "%18s : %10u\n", "DECRYPT BUSY ERR",
                        sc->debug.stats.rxstats.decrypt_busy_err);
+        len += snprintf(buf + len, size - len,
+                        "%18s : %10d\n", "RSSI-CTL0",
+                        sc->debug.stats.rxstats.rs_rssi_ctl0);
+        len += snprintf(buf + len, size - len,
+                        "%18s : %10d\n", "RSSI-CTL1",
+                        sc->debug.stats.rxstats.rs_rssi_ctl1);
+        len += snprintf(buf + len, size - len,
+                        "%18s : %10d\n", "RSSI-CTL2",
+                        sc->debug.stats.rxstats.rs_rssi_ctl2);
+        len += snprintf(buf + len, size - len,
+                        "%18s : %10d\n", "RSSI-EXT0",
+                        sc->debug.stats.rxstats.rs_rssi_ext0);
+        len += snprintf(buf + len, size - len,
+                        "%18s : %10d\n", "RSSI-EXT1",
+                        sc->debug.stats.rxstats.rs_rssi_ext1);
+        len += snprintf(buf + len, size - len,
+                        "%18s : %10d\n", "RSSI-EXT2",
+                        sc->debug.stats.rxstats.rs_rssi_ext2);
+        len += snprintf(buf + len, size - len,
+                        "%18s : %10d\n", "Rx Antenna",
+                        sc->debug.stats.rxstats.rs_antenna);
        PHY_ERR("UNDERRUN", ATH9K_PHYERR_UNDERRUN);
        PHY_ERR("TIMING", ATH9K_PHYERR_TIMING);
        PHY_ERR("PARITY", ATH9K_PHYERR_PARITY);
@@ -948,6 +981,16 @@ void ath_debug_stat_rx(struct ath_softc *sc, struct ath_rx_status *rs)
                RX_PHY_ERR_INC(phyerr);
        }
+        sc->debug.stats.rxstats.rs_rssi_ctl0 = rs->rs_rssi_ctl0;
+        sc->debug.stats.rxstats.rs_rssi_ctl1 = rs->rs_rssi_ctl1;
+        sc->debug.stats.rxstats.rs_rssi_ctl2 = rs->rs_rssi_ctl2;
+        sc->debug.stats.rxstats.rs_rssi_ext0 = rs->rs_rssi_ext0;
+        sc->debug.stats.rxstats.rs_rssi_ext1 = rs->rs_rssi_ext1;
+        sc->debug.stats.rxstats.rs_rssi_ext2 = rs->rs_rssi_ext2;
+        sc->debug.stats.rxstats.rs_antenna = rs->rs_antenna;
 #undef RX_STAT_INC
 #undef RX_PHY_ERR_INC
 }
@@ -1088,67 +1131,43 @@ int ath9k_init_debug(struct ath_hw *ah)
                return -ENOMEM;
 #ifdef CONFIG_ATH_DEBUG
-        if (!debugfs_create_file("debug", S_IRUSR | S_IWUSR,
+        debugfs_create_file("debug", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
-                        sc->debug.debugfs_phy, sc, &fops_debug))
+                            sc, &fops_debug);
-                goto err;
 #endif
+        debugfs_create_file("dma", S_IRUSR, sc->debug.debugfs_phy, sc,
-        if (!debugfs_create_file("dma", S_IRUSR, sc->debug.debugfs_phy,
+                            &fops_dma);
-                        sc, &fops_dma))
+        debugfs_create_file("interrupt", S_IRUSR, sc->debug.debugfs_phy, sc,
-                goto err;
+                            &fops_interrupt);
+        debugfs_create_file("wiphy", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
-        if (!debugfs_create_file("interrupt", S_IRUSR, sc->debug.debugfs_phy,
+                            sc, &fops_wiphy);
-                        sc, &fops_interrupt))
+        debugfs_create_file("xmit", S_IRUSR, sc->debug.debugfs_phy, sc,
-                goto err;
+                            &fops_xmit);
+        debugfs_create_file("stations", S_IRUSR, sc->debug.debugfs_phy, sc,
-        if (!debugfs_create_file("wiphy", S_IRUSR | S_IWUSR,
+                            &fops_stations);
-                        sc->debug.debugfs_phy, sc, &fops_wiphy))
+        debugfs_create_file("misc", S_IRUSR, sc->debug.debugfs_phy, sc,
-                goto err;
+                            &fops_misc);
+        debugfs_create_file("recv", S_IRUSR, sc->debug.debugfs_phy, sc,
-        if (!debugfs_create_file("xmit", S_IRUSR, sc->debug.debugfs_phy,
+                            &fops_recv);
-                        sc, &fops_xmit))
+        debugfs_create_file("rx_chainmask", S_IRUSR | S_IWUSR,
-                goto err;
+                            sc->debug.debugfs_phy, sc, &fops_rx_chainmask);
+        debugfs_create_file("tx_chainmask", S_IRUSR | S_IWUSR,
-        if (!debugfs_create_file("stations", S_IRUSR, sc->debug.debugfs_phy,
+                            sc->debug.debugfs_phy, sc, &fops_tx_chainmask);
-                        sc, &fops_stations))
+        debugfs_create_file("regidx", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
-                goto err;
+                            sc, &fops_regidx);
+        debugfs_create_file("regval", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
-        if (!debugfs_create_file("misc", S_IRUSR, sc->debug.debugfs_phy,
+                            sc, &fops_regval);
-                        sc, &fops_misc))
+        debugfs_create_bool("ignore_extcca", S_IRUSR | S_IWUSR,
-                goto err;
+                            sc->debug.debugfs_phy,
+                            &ah->config.cwm_ignore_extcca);
-        if (!debugfs_create_file("recv", S_IRUSR, sc->debug.debugfs_phy,
+        debugfs_create_file("regdump", S_IRUSR, sc->debug.debugfs_phy, sc,
-                        sc, &fops_recv))
+                            &fops_regdump);
-                goto err;
+        debugfs_create_u32("gpio_mask", S_IRUSR | S_IWUSR,
-        if (!debugfs_create_file("rx_chainmask", S_IRUSR | S_IWUSR,
+                           sc->debug.debugfs_phy, &sc->sc_ah->gpio_mask);
-                        sc->debug.debugfs_phy, sc, &fops_rx_chainmask))
-                goto err;
+        debugfs_create_u32("gpio_val", S_IRUSR | S_IWUSR,
+                           sc->debug.debugfs_phy, &sc->sc_ah->gpio_val);
-        if (!debugfs_create_file("tx_chainmask", S_IRUSR | S_IWUSR,
-                        sc->debug.debugfs_phy, sc, &fops_tx_chainmask))
-                goto err;
-        if (!debugfs_create_file("regidx", S_IRUSR | S_IWUSR,
-                        sc->debug.debugfs_phy, sc, &fops_regidx))
-                goto err;
-        if (!debugfs_create_file("regval", S_IRUSR | S_IWUSR,
-                        sc->debug.debugfs_phy, sc, &fops_regval))
-                goto err;
-        if (!debugfs_create_bool("ignore_extcca", S_IRUSR | S_IWUSR,
-                        sc->debug.debugfs_phy, &ah->config.cwm_ignore_extcca))
-                goto err;
-        if (!debugfs_create_file("regdump", S_IRUSR, sc->debug.debugfs_phy,
-                        sc, &fops_regdump))
-                goto err;
        sc->debug.regidx = 0;
        return 0;
-err:
-        debugfs_remove_recursive(sc->debug.debugfs_phy);
-        sc->debug.debugfs_phy = NULL;
-        return -ENOMEM;
 }
diff --git a/drivers/net/wireless/ath/ath9k/debug.h b/drivers/net/wireless/ath/ath9k/debug.h
index 59338de0ce19..5488a324cc10 100644
--- a/drivers/net/wireless/ath/ath9k/debug.h
+++ b/drivers/net/wireless/ath/ath9k/debug.h
@@ -54,6 +54,9 @@ struct ath_buf;
 * @dtimsync: DTIM sync lossage
 * @dtim: RX Beacon with DTIM
 * @bb_watchdog: Baseband watchdog
+ * @tsfoor: TSF out of range, indicates that the corrected TSF received
+ * from a beacon differs from the PCU's internal TSF by more than a
+ * (programmable) threshold
 */
 struct ath_interrupt_stats {
        u32 total;
@@ -78,6 +81,7 @@ struct ath_interrupt_stats {
        u32 dtimsync;
        u32 dtim;
        u32 bb_watchdog;
+        u32 tsfoor;
 };
 /**
@@ -157,6 +161,13 @@ struct ath_rx_stats {
        u32 post_delim_crc_err;
        u32 decrypt_busy_err;
        u32 phy_err_stats[ATH9K_PHYERR_MAX];
+        int8_t rs_rssi_ctl0;
+        int8_t rs_rssi_ctl1;
+        int8_t rs_rssi_ctl2;
+        int8_t rs_rssi_ext0;
+        int8_t rs_rssi_ext1;
+        int8_t rs_rssi_ext2;
+        u8 rs_antenna;
 };
 struct ath_stats {
diff --git a/drivers/net/wireless/ath/ath9k/eeprom.h b/drivers/net/wireless/ath/ath9k/eeprom.h
index bd82447f5b78..3e316133f114 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom.h
+++ b/drivers/net/wireless/ath/ath9k/eeprom.h
@@ -436,7 +436,11 @@ struct modal_eep_4k_header {
        u8 db2_2:4, db2_3:4;
        u8 db2_4:4, reserved:4;
 #endif
-        u8 futureModal[4];
+        u8 tx_diversity;
+        u8 flc_pwr_thresh;
+        u8 bb_scale_smrt_antenna;
+#define EEP_4K_BB_DESIRED_SCALE_MASK    0x1f
+        u8 futureModal[1];
        struct spur_chan spurChans[AR_EEPROM_MODAL_SPURS];
 } __packed;
diff --git a/drivers/net/wireless/ath/ath9k/eeprom_4k.c b/drivers/net/wireless/ath/ath9k/eeprom_4k.c
index bc77a308c901..6f714dd72365 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom_4k.c
+++ b/drivers/net/wireless/ath/ath9k/eeprom_4k.c
@@ -781,6 +781,7 @@ static void ath9k_hw_4k_set_board_values(struct ath_hw *ah,
 {
        struct modal_eep_4k_header *pModal;
        struct ar5416_eeprom_4k *eep = &ah->eeprom.map4k;
+        struct base_eep_header_4k *pBase = &eep->baseEepHeader;
        u8 txRxAttenLocal;
        u8 ob[5], db1[5], db2[5];
        u8 ant_div_control1, ant_div_control2;
@@ -1003,6 +1004,31 @@ static void ath9k_hw_4k_set_board_values(struct ath_hw *ah,
                                      AR_PHY_SETTLING_SWITCH,
                                      pModal->swSettleHt40);
        }
+        if (AR_SREV_9271(ah) || AR_SREV_9285(ah)) {
+                u8 bb_desired_scale = (pModal->bb_scale_smrt_antenna &
+                                EEP_4K_BB_DESIRED_SCALE_MASK);
+                if ((pBase->txGainType == 0) && (bb_desired_scale != 0)) {
+                        u32 pwrctrl, mask, clr;
+                        mask = BIT(0)|BIT(5)|BIT(10)|BIT(15)|BIT(20)|BIT(25);
+                        pwrctrl = mask * bb_desired_scale;
+                        clr = mask * 0x1f;
+                        REG_RMW(ah, AR_PHY_TX_PWRCTRL8, pwrctrl, clr);
+                        REG_RMW(ah, AR_PHY_TX_PWRCTRL10, pwrctrl, clr);
+                        REG_RMW(ah, AR_PHY_CH0_TX_PWRCTRL12, pwrctrl, clr);
+                        mask = BIT(0)|BIT(5)|BIT(15);
+                        pwrctrl = mask * bb_desired_scale;
+                        clr = mask * 0x1f;
+                        REG_RMW(ah, AR_PHY_TX_PWRCTRL9, pwrctrl, clr);
+                        mask = BIT(0)|BIT(5);
+                        pwrctrl = mask * bb_desired_scale;
+                        clr = mask * 0x1f;
+                        REG_RMW(ah, AR_PHY_CH0_TX_PWRCTRL11, pwrctrl, clr);
+                        REG_RMW(ah, AR_PHY_CH0_TX_PWRCTRL13, pwrctrl, clr);
+                }
+        }
 }
 static u16 ath9k_hw_4k_get_spur_channel(struct ath_hw *ah, u16 i, bool is2GHz)
diff --git a/drivers/net/wireless/ath/ath9k/eeprom_9287.c b/drivers/net/wireless/ath/ath9k/eeprom_9287.c
index 8cd8333cc086..b87db4763098 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom_9287.c
+++ b/drivers/net/wireless/ath/ath9k/eeprom_9287.c
@@ -319,10 +319,9 @@ static void ath9k_hw_set_ar9287_power_cal_table(struct ath_hw *ah,
        u16 numXpdGain, xpdMask;
        u16 xpdGainValues[AR5416_NUM_PD_GAINS] = {0, 0, 0, 0};
        u32 reg32, regOffset, regChainOffset, regval;
-        int16_t modalIdx, diff = 0;
+        int16_t diff = 0;
        struct ar9287_eeprom *pEepData = &ah->eeprom.map9287;
-        modalIdx = IS_CHAN_2GHZ(chan) ? 1 : 0;
        xpdMask = pEepData->modalHeader.xpdGain;
        if ((pEepData->baseEepHeader.version & AR9287_EEP_VER_MINOR_MASK) >=
@@ -392,6 +391,8 @@ static void ath9k_hw_set_ar9287_power_cal_table(struct ath_hw *ah,
                                                           numXpdGain);
                        }
+                        ENABLE_REGWRITE_BUFFER(ah);
                        if (i == 0) {
                                if (!ath9k_hw_ar9287_get_eeprom(ah,
                                                        EEP_OL_PWRCTRL)) {
@@ -442,6 +443,7 @@ static void ath9k_hw_set_ar9287_power_cal_table(struct ath_hw *ah,
                                        regOffset += 4;
                                }
                        }
+                        REGWRITE_BUFFER_FLUSH(ah);
                }
        }
@@ -757,6 +759,8 @@ static void ath9k_hw_ar9287_set_txpower(struct ath_hw *ah,
                        ratesArray[i] -= AR9287_PWR_TABLE_OFFSET_DB * 2;
        }
+        ENABLE_REGWRITE_BUFFER(ah);
        /* OFDM power per rate */
        REG_WRITE(ah, AR_PHY_POWER_TX_RATE1,
                  ATH9K_POW_SM(ratesArray[rate18mb], 24)
@@ -840,6 +844,7 @@ static void ath9k_hw_ar9287_set_txpower(struct ath_hw *ah,
                          | ATH9K_POW_SM(ratesArray[rateDupOfdm], 8)
                          | ATH9K_POW_SM(ratesArray[rateDupCck], 0));
        }
+        REGWRITE_BUFFER_FLUSH(ah);
 }
 static void ath9k_hw_ar9287_set_addac(struct ath_hw *ah,
@@ -852,35 +857,12 @@ static void ath9k_hw_ar9287_set_board_values(struct ath_hw *ah,
 {
        struct ar9287_eeprom *eep = &ah->eeprom.map9287;
        struct modal_eep_ar9287_header *pModal = &eep->modalHeader;
-        u16 antWrites[AR9287_ANT_16S];
        u32 regChainOffset, regval;
        u8 txRxAttenLocal;
-        int i, j, offset_num;
+        int i;
        pModal = &eep->modalHeader;
-        antWrites[0] = (u16)((pModal->antCtrlCommon >> 28) & 0xF);
-        antWrites[1] = (u16)((pModal->antCtrlCommon >> 24) & 0xF);
-        antWrites[2] = (u16)((pModal->antCtrlCommon >> 20) & 0xF);
-        antWrites[3] = (u16)((pModal->antCtrlCommon >> 16) & 0xF);
-        antWrites[4] = (u16)((pModal->antCtrlCommon >> 12) & 0xF);
-        antWrites[5] = (u16)((pModal->antCtrlCommon >> 8) & 0xF);
-        antWrites[6] = (u16)((pModal->antCtrlCommon >> 4)  & 0xF);
-        antWrites[7] = (u16)(pModal->antCtrlCommon & 0xF);
-        offset_num = 8;
-        for (i = 0, j = offset_num; i < AR9287_MAX_CHAINS; i++) {
-                antWrites[j++] = (u16)((pModal->antCtrlChain[i] >> 28) & 0xf);
-                antWrites[j++] = (u16)((pModal->antCtrlChain[i] >> 10) & 0x3);
-                antWrites[j++] = (u16)((pModal->antCtrlChain[i] >> 8) & 0x3);
-                antWrites[j++] = 0;
-                antWrites[j++] = (u16)((pModal->antCtrlChain[i] >> 6) & 0x3);
-                antWrites[j++] = (u16)((pModal->antCtrlChain[i] >> 4) & 0x3);
-                antWrites[j++] = (u16)((pModal->antCtrlChain[i] >> 2) & 0x3);
-                antWrites[j++] = (u16)(pModal->antCtrlChain[i] & 0x3);
-        }
        REG_WRITE(ah, AR_PHY_SWITCH_COM, pModal->antCtrlCommon);
        for (i = 0; i < AR9287_MAX_CHAINS; i++) {
diff --git a/drivers/net/wireless/ath/ath9k/eeprom_def.c b/drivers/net/wireless/ath/ath9k/eeprom_def.c
index fccd87df7300..c031854b569f 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom_def.c
+++ b/drivers/net/wireless/ath/ath9k/eeprom_def.c
@@ -231,6 +231,10 @@ static int ath9k_hw_def_check_eeprom(struct ath_hw *ah)
                                integer = swab32(pModal->antCtrlChain[i]);
                                pModal->antCtrlChain[i] = integer;
                        }
+                        for (i = 0; i < 3; i++) {
+                                word = swab16(pModal->xpaBiasLvlFreq[i]);
+                                pModal->xpaBiasLvlFreq[i] = word;
+                        }
                        for (i = 0; i < AR_EEPROM_MODAL_SPURS; i++) {
                                word = swab16(pModal->spurChans[i].spurChan);
@@ -799,6 +803,8 @@ static void ath9k_hw_set_def_power_cal_table(struct ath_hw *ah,
                                                           pwr_table_offset,
                                                           &diff);
+                        ENABLE_REGWRITE_BUFFER(ah);
                        if ((i == 0) || AR_SREV_5416_20_OR_LATER(ah)) {
                                if (OLC_FOR_AR9280_20_LATER) {
                                        REG_WRITE(ah,
@@ -847,6 +853,7 @@ static void ath9k_hw_set_def_power_cal_table(struct ath_hw *ah,
                                regOffset += 4;
                        }
+                        REGWRITE_BUFFER_FLUSH(ah);
                }
        }
@@ -1205,6 +1212,8 @@ static void ath9k_hw_def_set_txpower(struct ath_hw *ah,
                }
        }
+        ENABLE_REGWRITE_BUFFER(ah);
        REG_WRITE(ah, AR_PHY_POWER_TX_RATE1,
                  ATH9K_POW_SM(ratesArray[rate18mb], 24)
                  | ATH9K_POW_SM(ratesArray[rate12mb], 16)
@@ -1291,6 +1300,8 @@ static void ath9k_hw_def_set_txpower(struct ath_hw *ah,
        REG_WRITE(ah, AR_PHY_POWER_TX_SUB,
                  ATH9K_POW_SM(pModal->pwrDecreaseFor3Chain, 6)
                  | ATH9K_POW_SM(pModal->pwrDecreaseFor2Chain, 0));
+        REGWRITE_BUFFER_FLUSH(ah);
 }
 static u16 ath9k_hw_def_get_spur_channel(struct ath_hw *ah, u16 i, bool is2GHz)
diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/ath/ath9k/gpio.c
index 0fb8f8ac275a..0349b3a1cc58 100644
--- a/drivers/net/wireless/ath/ath9k/gpio.c
+++ b/drivers/net/wireless/ath/ath9k/gpio.c
@@ -41,12 +41,16 @@ void ath_init_leds(struct ath_softc *sc)
 {
        int ret;
-        if (AR_SREV_9287(sc->sc_ah))
+        if (sc->sc_ah->led_pin < 0) {
-                sc->sc_ah->led_pin = ATH_LED_PIN_9287;
+                if (AR_SREV_9287(sc->sc_ah))
-        else if (AR_SREV_9485(sc->sc_ah))
+                        sc->sc_ah->led_pin = ATH_LED_PIN_9287;
-                sc->sc_ah->led_pin = ATH_LED_PIN_9485;
+                else if (AR_SREV_9485(sc->sc_ah))
-        else
+                        sc->sc_ah->led_pin = ATH_LED_PIN_9485;
-                sc->sc_ah->led_pin = ATH_LED_PIN_DEF;
+                else if (AR_SREV_9300(sc->sc_ah))
+                        sc->sc_ah->led_pin = ATH_LED_PIN_9300;
+                else
+                        sc->sc_ah->led_pin = ATH_LED_PIN_DEF;
+        }
        /* Configure gpio 1 for output */
        ath9k_hw_cfg_output(sc->sc_ah, sc->sc_ah->led_pin,
@@ -136,10 +140,10 @@ static void ath_detect_bt_priority(struct ath_softc *sc)
 static void ath9k_gen_timer_start(struct ath_hw *ah,
                                  struct ath_gen_timer *timer,
-                                  u32 timer_next,
+                                  u32 trig_timeout,
                                  u32 timer_period)
 {
-        ath9k_hw_gen_timer_start(ah, timer, timer_next, timer_period);
+        ath9k_hw_gen_timer_start(ah, timer, trig_timeout, timer_period);
        if ((ah->imask & ATH9K_INT_GENTIMER) == 0) {
                ath9k_hw_disable_interrupts(ah);
@@ -172,17 +176,17 @@ static void ath_btcoex_period_timer(unsigned long data)
        struct ath_softc *sc = (struct ath_softc *) data;
        struct ath_hw *ah = sc->sc_ah;
        struct ath_btcoex *btcoex = &sc->btcoex;
-        struct ath_common *common = ath9k_hw_common(ah);
        u32 timer_period;
        bool is_btscan;
+        ath9k_ps_wakeup(sc);
        ath_detect_bt_priority(sc);
        is_btscan = sc->sc_flags & SC_OP_BT_SCAN;
        spin_lock_bh(&btcoex->btcoex_lock);
-        ath9k_cmn_btcoex_bt_stomp(common, is_btscan ? ATH_BTCOEX_STOMP_ALL :
+        ath9k_hw_btcoex_bt_stomp(ah, is_btscan ? ATH_BTCOEX_STOMP_ALL :
                              btcoex->bt_stomp_type);
        spin_unlock_bh(&btcoex->btcoex_lock);
@@ -193,11 +197,12 @@ static void ath_btcoex_period_timer(unsigned long data)
                timer_period = is_btscan ? btcoex->btscan_no_stomp :
                                           btcoex->btcoex_no_stomp;
-                ath9k_gen_timer_start(ah, btcoex->no_stomp_timer, 0,
+                ath9k_gen_timer_start(ah, btcoex->no_stomp_timer, timer_period,
                                      timer_period * 10);
                btcoex->hw_timer_enabled = true;
        }
+        ath9k_ps_restore(sc);
        mod_timer(&btcoex->period_timer, jiffies +
                                  msecs_to_jiffies(ATH_BTCOEX_DEF_BT_PERIOD));
 }
@@ -217,14 +222,16 @@ static void ath_btcoex_no_stomp_timer(void *arg)
        ath_dbg(common, ATH_DBG_BTCOEX,
                "no stomp timer running\n");
+        ath9k_ps_wakeup(sc);
        spin_lock_bh(&btcoex->btcoex_lock);
        if (btcoex->bt_stomp_type == ATH_BTCOEX_STOMP_LOW || is_btscan)
-                ath9k_cmn_btcoex_bt_stomp(common, ATH_BTCOEX_STOMP_NONE);
+                ath9k_hw_btcoex_bt_stomp(ah, ATH_BTCOEX_STOMP_NONE);
         else if (btcoex->bt_stomp_type == ATH_BTCOEX_STOMP_ALL)
-                ath9k_cmn_btcoex_bt_stomp(common, ATH_BTCOEX_STOMP_LOW);
+                ath9k_hw_btcoex_bt_stomp(ah, ATH_BTCOEX_STOMP_LOW);
        spin_unlock_bh(&btcoex->btcoex_lock);
+        ath9k_ps_restore(sc);
 }
 int ath_init_btcoex_timer(struct ath_softc *sc)
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
index 2d10239ce829..2e3a33a53406 100644
--- a/drivers/net/wireless/ath/ath9k/hif_usb.c
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
@@ -17,11 +17,9 @@
 #include "htc.h"
 /* identify firmware images */
-#define FIRMWARE_AR7010         "ar7010.fw"
+#define FIRMWARE_AR7010_1_1     "htc_7010.fw"
-#define FIRMWARE_AR7010_1_1     "ar7010_1_1.fw"
+#define FIRMWARE_AR9271         "htc_9271.fw"
-#define FIRMWARE_AR9271         "ar9271.fw"
-MODULE_FIRMWARE(FIRMWARE_AR7010);
 MODULE_FIRMWARE(FIRMWARE_AR7010_1_1);
 MODULE_FIRMWARE(FIRMWARE_AR9271);
@@ -80,7 +78,7 @@ static void hif_usb_regout_cb(struct urb *urb)
        if (cmd) {
                ath9k_htc_txcompletion_cb(cmd->hif_dev->htc_handle,
-                                          cmd->skb, 1);
+                                          cmd->skb, true);
                kfree(cmd);
        }
@@ -126,6 +124,90 @@ static int hif_usb_send_regout(struct hif_device_usb *hif_dev,
        return ret;
 }
+static void hif_usb_mgmt_cb(struct urb *urb)
+{
+        struct cmd_buf *cmd = (struct cmd_buf *)urb->context;
+        struct hif_device_usb *hif_dev = cmd->hif_dev;
+        bool txok = true;
+        if (!cmd || !cmd->skb || !cmd->hif_dev)
+                return;
+        switch (urb->status) {
+        case 0:
+                break;
+        case -ENOENT:
+        case -ECONNRESET:
+        case -ENODEV:
+        case -ESHUTDOWN:
+                txok = false;
+                /*
+                 * If the URBs are being flushed, no need to complete
+                 * this packet.
+                 */
+                spin_lock(&hif_dev->tx.tx_lock);
+                if (hif_dev->tx.flags & HIF_USB_TX_FLUSH) {
+                        spin_unlock(&hif_dev->tx.tx_lock);
+                        dev_kfree_skb_any(cmd->skb);
+                        kfree(cmd);
+                        return;
+                }
+                spin_unlock(&hif_dev->tx.tx_lock);
+                break;
+        default:
+                txok = false;
+                break;
+        }
+        skb_pull(cmd->skb, 4);
+        ath9k_htc_txcompletion_cb(cmd->hif_dev->htc_handle,
+                                  cmd->skb, txok);
+        kfree(cmd);
+}
+static int hif_usb_send_mgmt(struct hif_device_usb *hif_dev,
+                             struct sk_buff *skb)
+{
+        struct urb *urb;
+        struct cmd_buf *cmd;
+        int ret = 0;
+        __le16 *hdr;
+        urb = usb_alloc_urb(0, GFP_ATOMIC);
+        if (urb == NULL)
+                return -ENOMEM;
+        cmd = kzalloc(sizeof(*cmd), GFP_ATOMIC);
+        if (cmd == NULL) {
+                usb_free_urb(urb);
+                return -ENOMEM;
+        }
+        cmd->skb = skb;
+        cmd->hif_dev = hif_dev;
+        hdr = (__le16 *) skb_push(skb, 4);
+        *hdr++ = cpu_to_le16(skb->len - 4);
+        *hdr++ = cpu_to_le16(ATH_USB_TX_STREAM_MODE_TAG);
+        usb_fill_bulk_urb(urb, hif_dev->udev,
+                         usb_sndbulkpipe(hif_dev->udev, USB_WLAN_TX_PIPE),
+                         skb->data, skb->len,
+                         hif_usb_mgmt_cb, cmd);
+        usb_anchor_urb(urb, &hif_dev->mgmt_submitted);
+        ret = usb_submit_urb(urb, GFP_ATOMIC);
+        if (ret) {
+                usb_unanchor_urb(urb);
+                kfree(cmd);
+        }
+        usb_free_urb(urb);
+        return ret;
+}
 static inline void ath9k_skb_queue_purge(struct hif_device_usb *hif_dev,
                                         struct sk_buff_head *list)
 {
@@ -133,7 +215,22 @@ static inline void ath9k_skb_queue_purge(struct hif_device_usb *hif_dev,
        while ((skb = __skb_dequeue(list)) != NULL) {
                dev_kfree_skb_any(skb);
-                TX_STAT_INC(skb_dropped);
+        }
+}
+static inline void ath9k_skb_queue_complete(struct hif_device_usb *hif_dev,
+                                            struct sk_buff_head *queue,
+                                            bool txok)
+{
+        struct sk_buff *skb;
+        while ((skb = __skb_dequeue(queue)) != NULL) {
+                ath9k_htc_txcompletion_cb(hif_dev->htc_handle,
+                                          skb, txok);
+                if (txok)
+                        TX_STAT_INC(skb_success);
+                else
+                        TX_STAT_INC(skb_failed);
        }
 }
@@ -141,7 +238,7 @@ static void hif_usb_tx_cb(struct urb *urb)
 {
        struct tx_buf *tx_buf = (struct tx_buf *) urb->context;
        struct hif_device_usb *hif_dev;
-        struct sk_buff *skb;
+        bool txok = true;
        if (!tx_buf || !tx_buf->hif_dev)
                return;
@@ -155,10 +252,7 @@ static void hif_usb_tx_cb(struct urb *urb)
        case -ECONNRESET:
        case -ENODEV:
        case -ESHUTDOWN:
-                /*
+                txok = false;
-                 * The URB has been killed, free the SKBs.
-                 */
-                ath9k_skb_queue_purge(hif_dev, &tx_buf->skb_queue);
                /*
                 * If the URBs are being flushed, no need to add this
@@ -167,41 +261,19 @@ static void hif_usb_tx_cb(struct urb *urb)
                spin_lock(&hif_dev->tx.tx_lock);
                if (hif_dev->tx.flags & HIF_USB_TX_FLUSH) {
                        spin_unlock(&hif_dev->tx.tx_lock);
+                        ath9k_skb_queue_purge(hif_dev, &tx_buf->skb_queue);
                        return;
                }
                spin_unlock(&hif_dev->tx.tx_lock);
-                /*
+                break;
-                 * In the stop() case, this URB has to be added to
-                 * the free list.
-                 */
-                goto add_free;
        default:
+                txok = false;
                break;
        }
-        /*
+        ath9k_skb_queue_complete(hif_dev, &tx_buf->skb_queue, txok);
-         * Check if TX has been stopped, this is needed because
-         * this CB could have been invoked just after the TX lock
-         * was released in hif_stop() and kill_urb() hasn't been
-         * called yet.
-         */
-        spin_lock(&hif_dev->tx.tx_lock);
-        if (hif_dev->tx.flags & HIF_USB_TX_STOP) {
-                spin_unlock(&hif_dev->tx.tx_lock);
-                ath9k_skb_queue_purge(hif_dev, &tx_buf->skb_queue);
-                goto add_free;
-        }
-        spin_unlock(&hif_dev->tx.tx_lock);
-        /* Complete the queued SKBs. */
-        while ((skb = __skb_dequeue(&tx_buf->skb_queue)) != NULL) {
-                ath9k_htc_txcompletion_cb(hif_dev->htc_handle,
-                                          skb, 1);
-                TX_STAT_INC(skb_completed);
-        }
-add_free:
        /* Re-initialize the SKB queue */
        tx_buf->len = tx_buf->offset = 0;
        __skb_queue_head_init(&tx_buf->skb_queue);
@@ -274,7 +346,7 @@ static int __hif_usb_tx(struct hif_device_usb *hif_dev)
        ret = usb_submit_urb(tx_buf->urb, GFP_ATOMIC);
        if (ret) {
                tx_buf->len = tx_buf->offset = 0;
-                ath9k_skb_queue_purge(hif_dev, &tx_buf->skb_queue);
+                ath9k_skb_queue_complete(hif_dev, &tx_buf->skb_queue, false);
                __skb_queue_head_init(&tx_buf->skb_queue);
                list_move_tail(&tx_buf->list, &hif_dev->tx.tx_buf);
                hif_dev->tx.tx_buf_cnt++;
@@ -286,10 +358,11 @@ static int __hif_usb_tx(struct hif_device_usb *hif_dev)
        return ret;
 }
-static int hif_usb_send_tx(struct hif_device_usb *hif_dev, struct sk_buff *skb,
+static int hif_usb_send_tx(struct hif_device_usb *hif_dev, struct sk_buff *skb)
-                           struct ath9k_htc_tx_ctl *tx_ctl)
 {
+        struct ath9k_htc_tx_ctl *tx_ctl;
        unsigned long flags;
+        int ret = 0;
        spin_lock_irqsave(&hif_dev->tx.tx_lock, flags);
@@ -304,26 +377,36 @@ static int hif_usb_send_tx(struct hif_device_usb *hif_dev, struct sk_buff *skb,
                return -ENOMEM;
        }
-        __skb_queue_tail(&hif_dev->tx.tx_skb_queue, skb);
+        spin_unlock_irqrestore(&hif_dev->tx.tx_lock, flags);
-        hif_dev->tx.tx_skb_cnt++;
-        /* Send normal frames immediately */
+        tx_ctl = HTC_SKB_CB(skb);
-        if (!tx_ctl || (tx_ctl && (tx_ctl->type == ATH9K_HTC_NORMAL)))
-                __hif_usb_tx(hif_dev);
+        /* Mgmt/Beacon frames don't use the TX buffer pool */
+        if ((tx_ctl->type == ATH9K_HTC_MGMT) ||
+            (tx_ctl->type == ATH9K_HTC_BEACON)) {
+                ret = hif_usb_send_mgmt(hif_dev, skb);
+        }
+        spin_lock_irqsave(&hif_dev->tx.tx_lock, flags);
+        if ((tx_ctl->type == ATH9K_HTC_NORMAL) ||
+            (tx_ctl->type == ATH9K_HTC_AMPDU)) {
+                __skb_queue_tail(&hif_dev->tx.tx_skb_queue, skb);
+                hif_dev->tx.tx_skb_cnt++;
+        }
        /* Check if AMPDUs have to be sent immediately */
-        if (tx_ctl && (tx_ctl->type == ATH9K_HTC_AMPDU) &&
+        if ((hif_dev->tx.tx_buf_cnt == MAX_TX_URB_NUM) &&
-            (hif_dev->tx.tx_buf_cnt == MAX_TX_URB_NUM) &&
            (hif_dev->tx.tx_skb_cnt < 2)) {
                __hif_usb_tx(hif_dev);
        }
        spin_unlock_irqrestore(&hif_dev->tx.tx_lock, flags);
-        return 0;
+        return ret;
 }
-static void hif_usb_start(void *hif_handle, u8 pipe_id)
+static void hif_usb_start(void *hif_handle)
 {
        struct hif_device_usb *hif_dev = (struct hif_device_usb *)hif_handle;
        unsigned long flags;
@@ -335,14 +418,14 @@ static void hif_usb_start(void *hif_handle, u8 pipe_id)
        spin_unlock_irqrestore(&hif_dev->tx.tx_lock, flags);
 }
-static void hif_usb_stop(void *hif_handle, u8 pipe_id)
+static void hif_usb_stop(void *hif_handle)
 {
        struct hif_device_usb *hif_dev = (struct hif_device_usb *)hif_handle;
        struct tx_buf *tx_buf = NULL, *tx_buf_tmp = NULL;
        unsigned long flags;
        spin_lock_irqsave(&hif_dev->tx.tx_lock, flags);
-        ath9k_skb_queue_purge(hif_dev, &hif_dev->tx.tx_skb_queue);
+        ath9k_skb_queue_complete(hif_dev, &hif_dev->tx.tx_skb_queue, false);
        hif_dev->tx.tx_skb_cnt = 0;
        hif_dev->tx.flags |= HIF_USB_TX_STOP;
        spin_unlock_irqrestore(&hif_dev->tx.tx_lock, flags);
@@ -352,17 +435,18 @@ static void hif_usb_stop(void *hif_handle, u8 pipe_id)
                                 &hif_dev->tx.tx_pending, list) {
                usb_kill_urb(tx_buf->urb);
        }
+        usb_kill_anchored_urbs(&hif_dev->mgmt_submitted);
 }
-static int hif_usb_send(void *hif_handle, u8 pipe_id, struct sk_buff *skb,
+static int hif_usb_send(void *hif_handle, u8 pipe_id, struct sk_buff *skb)
-                        struct ath9k_htc_tx_ctl *tx_ctl)
 {
        struct hif_device_usb *hif_dev = (struct hif_device_usb *)hif_handle;
        int ret = 0;
        switch (pipe_id) {
        case USB_WLAN_TX_PIPE:
-                ret = hif_usb_send_tx(hif_dev, skb, tx_ctl);
+                ret = hif_usb_send_tx(hif_dev, skb);
                break;
        case USB_REG_OUT_PIPE:
                ret = hif_usb_send_regout(hif_dev, skb);
@@ -377,6 +461,40 @@ static int hif_usb_send(void *hif_handle, u8 pipe_id, struct sk_buff *skb,
        return ret;
 }
+static inline bool check_index(struct sk_buff *skb, u8 idx)
+{
+        struct ath9k_htc_tx_ctl *tx_ctl;
+        tx_ctl = HTC_SKB_CB(skb);
+        if ((tx_ctl->type == ATH9K_HTC_AMPDU) &&
+            (tx_ctl->sta_idx == idx))
+                return true;
+        return false;
+}
+static void hif_usb_sta_drain(void *hif_handle, u8 idx)
+{
+        struct hif_device_usb *hif_dev = (struct hif_device_usb *)hif_handle;
+        struct sk_buff *skb, *tmp;
+        unsigned long flags;
+        spin_lock_irqsave(&hif_dev->tx.tx_lock, flags);
+        skb_queue_walk_safe(&hif_dev->tx.tx_skb_queue, skb, tmp) {
+                if (check_index(skb, idx)) {
+                        __skb_unlink(skb, &hif_dev->tx.tx_skb_queue);
+                        ath9k_htc_txcompletion_cb(hif_dev->htc_handle,
+                                                  skb, false);
+                        hif_dev->tx.tx_skb_cnt--;
+                        TX_STAT_INC(skb_failed);
+                }
+        }
+        spin_unlock_irqrestore(&hif_dev->tx.tx_lock, flags);
+}
 static struct ath9k_htc_hif hif_usb = {
        .transport = ATH9K_HIF_USB,
        .name = "ath9k_hif_usb",
@@ -386,6 +504,7 @@ static struct ath9k_htc_hif hif_usb = {
        .start = hif_usb_start,
        .stop = hif_usb_stop,
+        .sta_drain = hif_usb_sta_drain,
        .send = hif_usb_send,
 };
@@ -567,6 +686,9 @@ static void ath9k_hif_usb_reg_in_cb(struct urb *urb)
        case -ESHUTDOWN:
                goto free;
        default:
+                skb_reset_tail_pointer(skb);
+                skb_trim(skb, 0);
                goto resubmit;
        }
@@ -591,23 +713,15 @@ static void ath9k_hif_usb_reg_in_cb(struct urb *urb)
                                                 USB_REG_IN_PIPE),
                                 nskb->data, MAX_REG_IN_BUF_SIZE,
                                 ath9k_hif_usb_reg_in_cb, nskb);
-                ret = usb_submit_urb(urb, GFP_ATOMIC);
-                if (ret) {
-                        kfree_skb(nskb);
-                        urb->context = NULL;
-                }
-                return;
        }
 resubmit:
-        skb_reset_tail_pointer(skb);
+        usb_anchor_urb(urb, &hif_dev->reg_in_submitted);
-        skb_trim(skb, 0);
        ret = usb_submit_urb(urb, GFP_ATOMIC);
-        if (ret)
+        if (ret) {
+                usb_unanchor_urb(urb);
                goto free;
+        }
        return;
 free:
@@ -641,6 +755,8 @@ static void ath9k_hif_usb_dealloc_tx_urbs(struct hif_device_usb *hif_dev)
                kfree(tx_buf->buf);
                kfree(tx_buf);
        }
+        usb_kill_anchored_urbs(&hif_dev->mgmt_submitted);
 }
 static int ath9k_hif_usb_alloc_tx_urbs(struct hif_device_usb *hif_dev)
@@ -652,6 +768,7 @@ static int ath9k_hif_usb_alloc_tx_urbs(struct hif_device_usb *hif_dev)
        INIT_LIST_HEAD(&hif_dev->tx.tx_pending);
        spin_lock_init(&hif_dev->tx.tx_lock);
        __skb_queue_head_init(&hif_dev->tx.tx_skb_queue);
+        init_usb_anchor(&hif_dev->mgmt_submitted);
        for (i = 0; i < MAX_TX_URB_NUM; i++) {
                tx_buf = kzalloc(sizeof(struct tx_buf), GFP_KERNEL);
@@ -748,43 +865,67 @@ err_urb:
        return ret;
 }
-static void ath9k_hif_usb_dealloc_reg_in_urb(struct hif_device_usb *hif_dev)
+static void ath9k_hif_usb_dealloc_reg_in_urbs(struct hif_device_usb *hif_dev)
 {
-        if (hif_dev->reg_in_urb) {
+        usb_kill_anchored_urbs(&hif_dev->reg_in_submitted);
-                usb_kill_urb(hif_dev->reg_in_urb);
-                if (hif_dev->reg_in_urb->context)
-                        kfree_skb((void *)hif_dev->reg_in_urb->context);
-                usb_free_urb(hif_dev->reg_in_urb);
-                hif_dev->reg_in_urb = NULL;
-        }
 }
-static int ath9k_hif_usb_alloc_reg_in_urb(struct hif_device_usb *hif_dev)
+static int ath9k_hif_usb_alloc_reg_in_urbs(struct hif_device_usb *hif_dev)
 {
-        struct sk_buff *skb;
+        struct urb *urb = NULL;
+        struct sk_buff *skb = NULL;
+        int i, ret;
-        hif_dev->reg_in_urb = usb_alloc_urb(0, GFP_KERNEL);
+        init_usb_anchor(&hif_dev->reg_in_submitted);
-        if (hif_dev->reg_in_urb == NULL)
-                return -ENOMEM;
-        skb = alloc_skb(MAX_REG_IN_BUF_SIZE, GFP_KERNEL);
+        for (i = 0; i < MAX_REG_IN_URB_NUM; i++) {
-        if (!skb)
-                goto err;
-        usb_fill_bulk_urb(hif_dev->reg_in_urb, hif_dev->udev,
+                /* Allocate URB */
-                         usb_rcvbulkpipe(hif_dev->udev,
+                urb = usb_alloc_urb(0, GFP_KERNEL);
-                                         USB_REG_IN_PIPE),
+                if (urb == NULL) {
-                         skb->data, MAX_REG_IN_BUF_SIZE,
+                        ret = -ENOMEM;
-                         ath9k_hif_usb_reg_in_cb, skb);
+                        goto err_urb;
+                }
-        if (usb_submit_urb(hif_dev->reg_in_urb, GFP_KERNEL) != 0)
+                /* Allocate buffer */
-                goto err;
+                skb = alloc_skb(MAX_REG_IN_BUF_SIZE, GFP_KERNEL);
+                if (!skb) {
+                        ret = -ENOMEM;
+                        goto err_skb;
+                }
+                usb_fill_bulk_urb(urb, hif_dev->udev,
+                                  usb_rcvbulkpipe(hif_dev->udev,
+                                                  USB_REG_IN_PIPE),
+                                  skb->data, MAX_REG_IN_BUF_SIZE,
+                                  ath9k_hif_usb_reg_in_cb, skb);
+                /* Anchor URB */
+                usb_anchor_urb(urb, &hif_dev->reg_in_submitted);
+                /* Submit URB */
+                ret = usb_submit_urb(urb, GFP_KERNEL);
+                if (ret) {
+                        usb_unanchor_urb(urb);
+                        goto err_submit;
+                }
+                /*
+                 * Drop reference count.
+                 * This ensures that the URB is freed when killing them.
+                 */
+                usb_free_urb(urb);
+        }
        return 0;
-err:
+err_submit:
-        ath9k_hif_usb_dealloc_reg_in_urb(hif_dev);
+        kfree_skb(skb);
-        return -ENOMEM;
+err_skb:
+        usb_free_urb(urb);
+err_urb:
+        ath9k_hif_usb_dealloc_reg_in_urbs(hif_dev);
+        return ret;
 }
 static int ath9k_hif_usb_alloc_urbs(struct hif_device_usb *hif_dev)
@@ -801,7 +942,7 @@ static int ath9k_hif_usb_alloc_urbs(struct hif_device_usb *hif_dev)
                goto err_rx;
        /* Register Read */
-        if (ath9k_hif_usb_alloc_reg_in_urb(hif_dev) < 0)
+        if (ath9k_hif_usb_alloc_reg_in_urbs(hif_dev) < 0)
                goto err_reg;
        return 0;
@@ -816,7 +957,7 @@ err:
 static void ath9k_hif_usb_dealloc_urbs(struct hif_device_usb *hif_dev)
 {
        usb_kill_anchored_urbs(&hif_dev->regout_submitted);
-        ath9k_hif_usb_dealloc_reg_in_urb(hif_dev);
+        ath9k_hif_usb_dealloc_reg_in_urbs(hif_dev);
        ath9k_hif_usb_dealloc_tx_urbs(hif_dev);
        ath9k_hif_usb_dealloc_rx_urbs(hif_dev);
 }
@@ -1026,10 +1167,7 @@ static int ath9k_hif_usb_probe(struct usb_interface *interface,
        /* Find out which firmware to load */
        if (IS_AR7010_DEVICE(id->driver_info))
-                if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x0202)
+                hif_dev->fw_name = FIRMWARE_AR7010_1_1;
-                        hif_dev->fw_name = FIRMWARE_AR7010_1_1;
-                else
-                        hif_dev->fw_name = FIRMWARE_AR7010;
        else
                hif_dev->fw_name = FIRMWARE_AR9271;
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.h b/drivers/net/wireless/ath/ath9k/hif_usb.h
index 7b9d863d4035..2bdcdbc14b1e 100644
--- a/drivers/net/wireless/ath/ath9k/hif_usb.h
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.h
@@ -17,6 +17,9 @@
 #ifndef HTC_USB_H
 #define HTC_USB_H
+#define MAJOR_VERSION_REQ 1
+#define MINOR_VERSION_REQ 2
 #define IS_AR7010_DEVICE(_v) (((_v) == AR9280_USB) || ((_v) == AR9287_USB))
 #define AR9271_FIRMWARE       0x501000
@@ -31,7 +34,7 @@
 /* FIXME: Verify these numbers (with Windows) */
 #define MAX_TX_URB_NUM  8
-#define MAX_TX_BUF_NUM  1024
+#define MAX_TX_BUF_NUM  256
 #define MAX_TX_BUF_SIZE 32768
 #define MAX_TX_AGGR_NUM 20
@@ -40,7 +43,7 @@
 #define MAX_PKT_NUM_IN_TRANSFER 10
 #define MAX_REG_OUT_URB_NUM  1
-#define MAX_REG_OUT_BUF_NUM  8
+#define MAX_REG_IN_URB_NUM   64
 #define MAX_REG_IN_BUF_SIZE 64
@@ -90,9 +93,10 @@ struct hif_device_usb {
        const struct firmware *firmware;
        struct htc_target *htc_handle;
        struct hif_usb_tx tx;
-        struct urb *reg_in_urb;
        struct usb_anchor regout_submitted;
        struct usb_anchor rx_submitted;
+        struct usb_anchor reg_in_submitted;
+        struct usb_anchor mgmt_submitted;
        struct sk_buff *remain_skb;
        const char *fw_name;
        int rx_remain_len;
diff --git a/drivers/net/wireless/ath/ath9k/htc.h b/drivers/net/wireless/ath/ath9k/htc.h
index 753a245c5ad1..dfc7a982fc7e 100644
--- a/drivers/net/wireless/ath/ath9k/htc.h
+++ b/drivers/net/wireless/ath/ath9k/htc.h
@@ -66,13 +66,13 @@ enum htc_opmode {
        HTC_M_WDS       = 2
 };
-#define ATH9K_HTC_HDRSPACE sizeof(struct htc_frame_hdr)
+#define ATH9K_HTC_AMPDU  1
-#define ATH9K_HTC_AMPDU 1
 #define ATH9K_HTC_NORMAL 2
+#define ATH9K_HTC_BEACON 3
+#define ATH9K_HTC_MGMT   4
 #define ATH9K_HTC_TX_CTSONLY      0x1
 #define ATH9K_HTC_TX_RTSCTS       0x2
-#define ATH9K_HTC_TX_USE_MIN_RATE 0x100
 struct tx_frame_hdr {
        u8 data_type;
@@ -82,7 +82,8 @@ struct tx_frame_hdr {
        __be32 flags; /* ATH9K_HTC_TX_* */
        u8 key_type;
        u8 keyix;
-        u8 reserved[26];
+        u8 cookie;
+        u8 pad;
 } __packed;
 struct tx_mgmt_hdr {
@@ -92,50 +93,34 @@ struct tx_mgmt_hdr {
        u8 flags;
        u8 key_type;
        u8 keyix;
-        u16 reserved;
+        u8 cookie;
+        u8 pad;
 } __packed;
 struct tx_beacon_header {
-        u8 len_changed;
        u8 vif_index;
+        u8 len_changed;
        u16 rev;
 } __packed;
-struct ath9k_htc_target_hw {
+#define MAX_TX_AMPDU_SUBFRAMES_9271 17
-        u32 flags;
+#define MAX_TX_AMPDU_SUBFRAMES_7010 22
-        u32 flags_ext;
-        u32 ampdu_limit;
-        u8 ampdu_subframes;
-        u8 tx_chainmask;
-        u8 tx_chainmask_legacy;
-        u8 rtscts_ratecode;
-        u8 protmode;
-} __packed;
 struct ath9k_htc_cap_target {
-        u32 flags;
+        __be32 ampdu_limit;
-        u32 flags_ext;
-        u32 ampdu_limit;
        u8 ampdu_subframes;
+        u8 enable_coex;
        u8 tx_chainmask;
-        u8 tx_chainmask_legacy;
+        u8 pad;
-        u8 rtscts_ratecode;
-        u8 protmode;
 } __packed;
 struct ath9k_htc_target_vif {
        u8 index;
-        u8 des_bssid[ETH_ALEN];
+        u8 opmode;
-        __be32 opmode;
        u8 myaddr[ETH_ALEN];
-        u8 bssid[ETH_ALEN];
-        u32 flags;
-        u32 flags_ext;
-        u16 ps_sta;
-        __be16 rtsthreshold;
        u8 ath_cap;
-        u8 node;
+        __be16 rtsthreshold;
-        s8 mcast_rate;
+        u8 pad;
 } __packed;
 #define ATH_HTC_STA_AUTH  0x0001
@@ -143,27 +128,16 @@ struct ath9k_htc_target_vif {
 #define ATH_HTC_STA_ERP   0x0004
 #define ATH_HTC_STA_HT    0x0008
-/* FIXME: UAPSD variables */
 struct ath9k_htc_target_sta {
-        u16 associd;
-        u16 txpower;
-        u32 ucastkey;
        u8 macaddr[ETH_ALEN];
        u8 bssid[ETH_ALEN];
        u8 sta_index;
        u8 vif_index;
-        u8 vif_sta;
-        __be16 flags; /* ATH_HTC_STA_* */
-        u16 htcap;
-        u8 valid;
-        u16 capinfo;
-        struct ath9k_htc_target_hw *hw;
-        struct ath9k_htc_target_vif *vif;
-        u16 txseqmgmt;
        u8 is_vif_sta;
-        u16 maxampdu;
+        __be16 flags; /* ATH_HTC_STA_* */
-        u16 iv16;
+        __be16 htcap;
-        u32 iv32;
+        __be16 maxampdu;
+        u8 pad;
 } __packed;
 struct ath9k_htc_target_aggr {
@@ -197,12 +171,38 @@ struct ath9k_htc_target_rate {
        struct ath9k_htc_rate rates;
 };
-struct ath9k_htc_target_stats {
+struct ath9k_htc_target_rate_mask {
-        __be32 tx_shortretry;
+        u8 vif_index;
-        __be32 tx_longretry;
+        u8 band;
-        __be32 tx_xretries;
+        __be32 mask;
-        __be32 ht_txunaggr_xretry;
+        u16 pad;
-        __be32 ht_tx_xretries;
+} __packed;
+struct ath9k_htc_target_int_stats {
+        __be32 rx;
+        __be32 rxorn;
+        __be32 rxeol;
+        __be32 txurn;
+        __be32 txto;
+        __be32 cst;
+} __packed;
+struct ath9k_htc_target_tx_stats {
+        __be32 xretries;
+        __be32 fifoerr;
+        __be32 filtered;
+        __be32 timer_exp;
+        __be32 shortretries;
+        __be32 longretries;
+        __be32 qnull;
+        __be32 encap_fail;
+        __be32 nobuf;
+} __packed;
+struct ath9k_htc_target_rx_stats {
+        __be32 nobuf;
+        __be32 host_send;
+        __be32 host_done;
 } __packed;
 #define ATH9K_HTC_MAX_VIF 2
@@ -244,6 +244,8 @@ struct ath9k_htc_vif {
        u8 index;
        u16 seq_no;
        bool beacon_configured;
+        int bslot;
+        __le64 tsfadjust;
 };
 struct ath9k_vif_iter_data {
@@ -282,23 +284,65 @@ struct ath9k_htc_rx {
        spinlock_t rxbuflock;
 };
+#define ATH9K_HTC_TX_CLEANUP_INTERVAL 50 /* ms */
+#define ATH9K_HTC_TX_TIMEOUT_INTERVAL 2500 /* ms */
+#define ATH9K_HTC_TX_RESERVE 10
+#define ATH9K_HTC_TX_TIMEOUT_COUNT 20
+#define ATH9K_HTC_TX_THRESHOLD (MAX_TX_BUF_NUM - ATH9K_HTC_TX_RESERVE)
+#define ATH9K_HTC_OP_TX_QUEUES_STOP BIT(0)
+#define ATH9K_HTC_OP_TX_DRAIN       BIT(1)
+struct ath9k_htc_tx {
+        u8 flags;
+        int queued_cnt;
+        struct sk_buff_head mgmt_ep_queue;
+        struct sk_buff_head cab_ep_queue;
+        struct sk_buff_head data_be_queue;
+        struct sk_buff_head data_bk_queue;
+        struct sk_buff_head data_vi_queue;
+        struct sk_buff_head data_vo_queue;
+        struct sk_buff_head tx_failed;
+        DECLARE_BITMAP(tx_slot, MAX_TX_BUF_NUM);
+        struct timer_list cleanup_timer;
+        spinlock_t tx_lock;
+};
 struct ath9k_htc_tx_ctl {
        u8 type; /* ATH9K_HTC_* */
+        u8 epid;
+        u8 txok;
+        u8 sta_idx;
+        unsigned long timestamp;
 };
+static inline struct ath9k_htc_tx_ctl *HTC_SKB_CB(struct sk_buff *skb)
+{
+        struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
+        BUILD_BUG_ON(sizeof(struct ath9k_htc_tx_ctl) >
+                     IEEE80211_TX_INFO_DRIVER_DATA_SIZE);
+        return (struct ath9k_htc_tx_ctl *) &tx_info->driver_data;
+}
 #ifdef CONFIG_ATH9K_HTC_DEBUGFS
 #define TX_STAT_INC(c) (hif_dev->htc_handle->drv_priv->debug.tx_stats.c++)
 #define RX_STAT_INC(c) (hif_dev->htc_handle->drv_priv->debug.rx_stats.c++)
+#define CAB_STAT_INC   priv->debug.tx_stats.cab_queued++
 #define TX_QSTAT_INC(q) (priv->debug.tx_stats.queue_stats[q]++)
+void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv,
+                           struct ath_htc_rx_status *rxs);
 struct ath_tx_stats {
        u32 buf_queued;
        u32 buf_completed;
        u32 skb_queued;
-        u32 skb_completed;
+        u32 skb_success;
-        u32 skb_dropped;
+        u32 skb_failed;
+        u32 cab_queued;
        u32 queue_stats[WME_NUM_AC];
 };
@@ -306,55 +350,57 @@ struct ath_rx_stats {
        u32 skb_allocated;
        u32 skb_completed;
        u32 skb_dropped;
+        u32 err_crc;
+        u32 err_decrypt_crc;
+        u32 err_mic;
+        u32 err_pre_delim;
+        u32 err_post_delim;
+        u32 err_decrypt_busy;
+        u32 err_phy;
+        u32 err_phy_stats[ATH9K_PHYERR_MAX];
 };
 struct ath9k_debug {
        struct dentry *debugfs_phy;
-        struct dentry *debugfs_tgt_stats;
-        struct dentry *debugfs_xmit;
-        struct dentry *debugfs_recv;
        struct ath_tx_stats tx_stats;
        struct ath_rx_stats rx_stats;
-        u32 txrate;
 };
 #else
 #define TX_STAT_INC(c) do { } while (0)
 #define RX_STAT_INC(c) do { } while (0)
+#define CAB_STAT_INC   do { } while (0)
 #define TX_QSTAT_INC(c) do { } while (0)
+static inline void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv,
+                                         struct ath_htc_rx_status *rxs)
+{
+}
 #endif /* CONFIG_ATH9K_HTC_DEBUGFS */
 #define ATH_LED_PIN_DEF             1
-#define ATH_LED_PIN_9287            8
+#define ATH_LED_PIN_9287            10
 #define ATH_LED_PIN_9271            15
 #define ATH_LED_PIN_7010            12
-#define ATH_LED_ON_DURATION_IDLE    350 /* in msecs */
-#define ATH_LED_OFF_DURATION_IDLE   250 /* in msecs */
-enum ath_led_type {
-        ATH_LED_RADIO,
-        ATH_LED_ASSOC,
-        ATH_LED_TX,
-        ATH_LED_RX
-};
-struct ath_led {
+#define BSTUCK_THRESHOLD 10
-        struct ath9k_htc_priv *priv;
-        struct led_classdev led_cdev;
+/*
-        enum ath_led_type led_type;
+ * Adjust these when the max. no of beaconing interfaces is
-        struct delayed_work brightness_work;
+ * increased.
-        char name[32];
+ */
-        bool registered;
+#define DEFAULT_SWBA_RESPONSE 40 /* in TUs */
-        int brightness;
+#define MIN_SWBA_RESPONSE     10 /* in TUs */
-};
 struct htc_beacon_config {
+        struct ieee80211_vif *bslot[ATH9K_HTC_MAX_BCN_VIF];
        u16 beacon_interval;
        u16 dtim_period;
        u16 bmiss_timeout;
+        u32 bmiss_cnt;
 };
 struct ath_btcoex {
@@ -372,14 +418,11 @@ void ath_htc_cancel_btcoex_work(struct ath9k_htc_priv *priv);
 #define OP_INVALID                 BIT(0)
 #define OP_SCANNING                BIT(1)
-#define OP_LED_ASSOCIATED          BIT(2)
+#define OP_ENABLE_BEACON           BIT(2)
-#define OP_LED_ON                  BIT(3)
+#define OP_BT_PRIORITY_DETECTED    BIT(3)
-#define OP_ENABLE_BEACON           BIT(4)
+#define OP_BT_SCAN                 BIT(4)
-#define OP_LED_DEINIT              BIT(5)
+#define OP_ANI_RUNNING             BIT(5)
-#define OP_BT_PRIORITY_DETECTED    BIT(6)
+#define OP_TSF_RESET               BIT(6)
-#define OP_BT_SCAN                 BIT(7)
-#define OP_ANI_RUNNING             BIT(8)
-#define OP_TSF_RESET               BIT(9)
 struct ath9k_htc_priv {
        struct device *dev;
@@ -388,6 +431,9 @@ struct ath9k_htc_priv {
        struct htc_target *htc;
        struct wmi *wmi;
+        u16 fw_version_major;
+        u16 fw_version_minor;
        enum htc_endpoint_id wmi_cmd_ep;
        enum htc_endpoint_id beacon_ep;
        enum htc_endpoint_id cab_ep;
@@ -411,27 +457,23 @@ struct ath9k_htc_priv {
        u16 txpowlimit;
        u16 nvifs;
        u16 nstations;
-        u32 bmiss_cnt;
        bool rearm_ani;
        bool reconfig_beacon;
+        unsigned int rxfilter;
        struct ath9k_hw_cal_data caldata;
+        struct ieee80211_supported_band sbands[IEEE80211_NUM_BANDS];
        spinlock_t beacon_lock;
+        struct htc_beacon_config cur_beacon_conf;
-        bool tx_queues_stop;
+        struct ath9k_htc_rx rx;
-        spinlock_t tx_lock;
+        struct ath9k_htc_tx tx;
-        struct ieee80211_vif *vif;
-        struct htc_beacon_config cur_beacon_conf;
-        unsigned int rxfilter;
        struct tasklet_struct swba_tasklet;
        struct tasklet_struct rx_tasklet;
-        struct ieee80211_supported_band sbands[IEEE80211_NUM_BANDS];
-        struct ath9k_htc_rx rx;
-        struct tasklet_struct tx_tasklet;
-        struct sk_buff_head tx_queue;
        struct delayed_work ani_work;
+        struct tasklet_struct tx_failed_tasklet;
        struct work_struct ps_work;
        struct work_struct fatal_work;
@@ -440,15 +482,13 @@ struct ath9k_htc_priv {
        bool ps_enabled;
        bool ps_idle;
-        struct ath_led radio_led;
+#ifdef CONFIG_MAC80211_LEDS
-        struct ath_led assoc_led;
+        enum led_brightness brightness;
-        struct ath_led tx_led;
+        bool led_registered;
-        struct ath_led rx_led;
+        char led_name[32];
-        struct delayed_work ath9k_led_blink_work;
+        struct led_classdev led_cdev;
-        int led_on_duration;
+        struct work_struct led_work;
-        int led_off_duration;
+#endif
-        int led_on_cnt;
-        int led_off_cnt;
        int beaconq;
        int cabq;
@@ -470,11 +510,18 @@ static inline void ath_read_cachesize(struct ath_common *common, int *csz)
 void ath9k_htc_reset(struct ath9k_htc_priv *priv);
+void ath9k_htc_assign_bslot(struct ath9k_htc_priv *priv,
+                            struct ieee80211_vif *vif);
+void ath9k_htc_remove_bslot(struct ath9k_htc_priv *priv,
+                            struct ieee80211_vif *vif);
+void ath9k_htc_set_tsfadjust(struct ath9k_htc_priv *priv,
+                             struct ieee80211_vif *vif);
 void ath9k_htc_beaconq_config(struct ath9k_htc_priv *priv);
 void ath9k_htc_beacon_config(struct ath9k_htc_priv *priv,
                             struct ieee80211_vif *vif);
 void ath9k_htc_beacon_reconfig(struct ath9k_htc_priv *priv);
-void ath9k_htc_swba(struct ath9k_htc_priv *priv, u8 beacon_pending);
+void ath9k_htc_swba(struct ath9k_htc_priv *priv,
+                    struct wmi_event_swba *swba);
 void ath9k_htc_rxep(void *priv, struct sk_buff *skb,
                    enum htc_endpoint_id ep_id);
@@ -483,7 +530,8 @@ void ath9k_htc_txep(void *priv, struct sk_buff *skb, enum htc_endpoint_id ep_id,
 void ath9k_htc_beaconep(void *drv_priv, struct sk_buff *skb,
                        enum htc_endpoint_id ep_id, bool txok);
-int ath9k_htc_update_cap_target(struct ath9k_htc_priv *priv);
+int ath9k_htc_update_cap_target(struct ath9k_htc_priv *priv,
+                                u8 enable_coex);
 void ath9k_htc_station_work(struct work_struct *work);
 void ath9k_htc_aggr_work(struct work_struct *work);
 void ath9k_htc_ani_work(struct work_struct *work);
@@ -491,14 +539,23 @@ void ath9k_htc_start_ani(struct ath9k_htc_priv *priv);
 void ath9k_htc_stop_ani(struct ath9k_htc_priv *priv);
 int ath9k_tx_init(struct ath9k_htc_priv *priv);
-void ath9k_tx_tasklet(unsigned long data);
+int ath9k_htc_tx_start(struct ath9k_htc_priv *priv,
-int ath9k_htc_tx_start(struct ath9k_htc_priv *priv, struct sk_buff *skb);
+                       struct sk_buff *skb, u8 slot, bool is_cab);
 void ath9k_tx_cleanup(struct ath9k_htc_priv *priv);
 bool ath9k_htc_txq_setup(struct ath9k_htc_priv *priv, int subtype);
 int ath9k_htc_cabq_setup(struct ath9k_htc_priv *priv);
 int get_hw_qnum(u16 queue, int *hwq_map);
 int ath_htc_txq_update(struct ath9k_htc_priv *priv, int qnum,
                       struct ath9k_tx_queue_info *qinfo);
+void ath9k_htc_check_stop_queues(struct ath9k_htc_priv *priv);
+void ath9k_htc_check_wake_queues(struct ath9k_htc_priv *priv);
+int ath9k_htc_tx_get_slot(struct ath9k_htc_priv *priv);
+void ath9k_htc_tx_clear_slot(struct ath9k_htc_priv *priv, int slot);
+void ath9k_htc_tx_drain(struct ath9k_htc_priv *priv);
+void ath9k_htc_txstatus(struct ath9k_htc_priv *priv, void *wmi_event);
+void ath9k_htc_tx_failed(struct ath9k_htc_priv *priv);
+void ath9k_tx_failed_tasklet(unsigned long data);
+void ath9k_htc_tx_cleanup_timer(unsigned long data);
 int ath9k_rx_init(struct ath9k_htc_priv *priv);
 void ath9k_rx_cleanup(struct ath9k_htc_priv *priv);
@@ -516,9 +573,24 @@ void ath9k_start_rfkill_poll(struct ath9k_htc_priv *priv);
 void ath9k_htc_rfkill_poll_state(struct ieee80211_hw *hw);
 void ath9k_htc_radio_enable(struct ieee80211_hw *hw);
 void ath9k_htc_radio_disable(struct ieee80211_hw *hw);
-void ath9k_led_stop_brightness(struct ath9k_htc_priv *priv);
+#ifdef CONFIG_MAC80211_LEDS
 void ath9k_init_leds(struct ath9k_htc_priv *priv);
 void ath9k_deinit_leds(struct ath9k_htc_priv *priv);
+void ath9k_led_work(struct work_struct *work);
+#else
+static inline void ath9k_init_leds(struct ath9k_htc_priv *priv)
+{
+}
+static inline void ath9k_deinit_leds(struct ath9k_htc_priv *priv)
+{
+}
+static inline void ath9k_led_work(struct work_struct *work)
+{
+}
+#endif
 int ath9k_htc_probe_device(struct htc_target *htc_handle, struct device *dev,
                           u16 devid, char *product, u32 drv_info);
@@ -528,15 +600,9 @@ void ath9k_htc_suspend(struct htc_target *htc_handle);
 int ath9k_htc_resume(struct htc_target *htc_handle);
 #endif
 #ifdef CONFIG_ATH9K_HTC_DEBUGFS
-int ath9k_htc_debug_create_root(void);
-void ath9k_htc_debug_remove_root(void);
 int ath9k_htc_init_debug(struct ath_hw *ah);
-void ath9k_htc_exit_debug(struct ath_hw *ah);
 #else
-static inline int ath9k_htc_debug_create_root(void) { return 0; };
-static inline void ath9k_htc_debug_remove_root(void) {};
 static inline int ath9k_htc_init_debug(struct ath_hw *ah) { return 0; };
-static inline void ath9k_htc_exit_debug(struct ath_hw *ah) {};
 #endif /* CONFIG_ATH9K_HTC_DEBUGFS */
 #endif /* HTC_H */
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c b/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
index 8d1d8792436d..0ded2c66d5ff 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
@@ -18,6 +18,50 @@
 #define FUDGE 2
+void ath9k_htc_beaconq_config(struct ath9k_htc_priv *priv)
+{
+        struct ath_hw *ah = priv->ah;
+        struct ath9k_tx_queue_info qi, qi_be;
+        memset(&qi, 0, sizeof(struct ath9k_tx_queue_info));
+        memset(&qi_be, 0, sizeof(struct ath9k_tx_queue_info));
+        ath9k_hw_get_txq_props(ah, priv->beaconq, &qi);
+        if (priv->ah->opmode == NL80211_IFTYPE_AP) {
+                qi.tqi_aifs = 1;
+                qi.tqi_cwmin = 0;
+                qi.tqi_cwmax = 0;
+        } else if (priv->ah->opmode == NL80211_IFTYPE_ADHOC) {
+                int qnum = priv->hwq_map[WME_AC_BE];
+                ath9k_hw_get_txq_props(ah, qnum, &qi_be);
+                qi.tqi_aifs = qi_be.tqi_aifs;
+                /*
+                 * For WIFI Beacon Distribution
+                 * Long slot time  : 2x cwmin
+                 * Short slot time : 4x cwmin
+                 */
+                if (ah->slottime == ATH9K_SLOT_TIME_20)
+                        qi.tqi_cwmin = 2*qi_be.tqi_cwmin;
+                else
+                        qi.tqi_cwmin = 4*qi_be.tqi_cwmin;
+                qi.tqi_cwmax = qi_be.tqi_cwmax;
+        }
+        if (!ath9k_hw_set_txq_props(ah, priv->beaconq, &qi)) {
+                ath_err(ath9k_hw_common(ah),
+                        "Unable to update beacon queue %u!\n", priv->beaconq);
+        } else {
+                ath9k_hw_resettxqueue(ah, priv->beaconq);
+        }
+}
 static void ath9k_htc_beacon_config_sta(struct ath9k_htc_priv *priv,
                                        struct htc_beacon_config *bss_conf)
 {
@@ -30,7 +74,7 @@ static void ath9k_htc_beacon_config_sta(struct ath9k_htc_priv *priv,
        __be32 htc_imask = 0;
        u64 tsf;
        int num_beacons, offset, dtim_dec_count, cfp_dec_count;
-        int ret;
+        int ret __attribute__ ((unused));
        u8 cmd_rsp;
        memset(&bs, 0, sizeof(bs));
@@ -146,7 +190,7 @@ static void ath9k_htc_beacon_config_ap(struct ath9k_htc_priv *priv,
        enum ath9k_int imask = 0;
        u32 nexttbtt, intval, tsftu;
        __be32 htc_imask = 0;
-        int ret;
+        int ret __attribute__ ((unused));
        u8 cmd_rsp;
        u64 tsf;
@@ -154,8 +198,17 @@ static void ath9k_htc_beacon_config_ap(struct ath9k_htc_priv *priv,
        intval /= ATH9K_HTC_MAX_BCN_VIF;
        nexttbtt = intval;
+        /*
+         * To reduce beacon misses under heavy TX load,
+         * set the beacon response time to a larger value.
+         */
+        if (intval > DEFAULT_SWBA_RESPONSE)
+                priv->ah->config.sw_beacon_response_time = DEFAULT_SWBA_RESPONSE;
+        else
+                priv->ah->config.sw_beacon_response_time = MIN_SWBA_RESPONSE;
        if (priv->op_flags & OP_TSF_RESET) {
-                intval |= ATH9K_BEACON_RESET_TSF;
+                ath9k_hw_reset_tsf(priv->ah);
                priv->op_flags &= ~OP_TSF_RESET;
        } else {
                /*
@@ -168,18 +221,20 @@ static void ath9k_htc_beacon_config_ap(struct ath9k_htc_priv *priv,
                } while (nexttbtt < tsftu);
        }
-        intval |= ATH9K_BEACON_ENA;
        if (priv->op_flags & OP_ENABLE_BEACON)
                imask |= ATH9K_INT_SWBA;
        ath_dbg(common, ATH_DBG_CONFIG,
-                "AP Beacon config, intval: %d, nexttbtt: %u imask: 0x%x\n",
+                "AP Beacon config, intval: %d, nexttbtt: %u, resp_time: %d "
-                bss_conf->beacon_interval, nexttbtt, imask);
+                "imask: 0x%x\n",
+                bss_conf->beacon_interval, nexttbtt,
+                priv->ah->config.sw_beacon_response_time, imask);
+        ath9k_htc_beaconq_config(priv);
        WMI_CMD(WMI_DISABLE_INTR_CMDID);
-        ath9k_hw_beaconinit(priv->ah, nexttbtt, intval);
+        ath9k_hw_beaconinit(priv->ah, TU_TO_USEC(nexttbtt), TU_TO_USEC(intval));
-        priv->bmiss_cnt = 0;
+        priv->cur_beacon_conf.bmiss_cnt = 0;
        htc_imask = cpu_to_be32(imask);
        WMI_CMD_BUF(WMI_ENABLE_INTR_CMDID, &htc_imask);
 }
@@ -191,7 +246,7 @@ static void ath9k_htc_beacon_config_adhoc(struct ath9k_htc_priv *priv,
        enum ath9k_int imask = 0;
        u32 nexttbtt, intval, tsftu;
        __be32 htc_imask = 0;
-        int ret;
+        int ret __attribute__ ((unused));
        u8 cmd_rsp;
        u64 tsf;
@@ -207,17 +262,26 @@ static void ath9k_htc_beacon_config_adhoc(struct ath9k_htc_priv *priv,
                nexttbtt += intval;
        } while (nexttbtt < tsftu);
-        intval |= ATH9K_BEACON_ENA;
+        /*
+         * Only one IBSS interfce is allowed.
+         */
+        if (intval > DEFAULT_SWBA_RESPONSE)
+                priv->ah->config.sw_beacon_response_time = DEFAULT_SWBA_RESPONSE;
+        else
+                priv->ah->config.sw_beacon_response_time = MIN_SWBA_RESPONSE;
        if (priv->op_flags & OP_ENABLE_BEACON)
                imask |= ATH9K_INT_SWBA;
        ath_dbg(common, ATH_DBG_CONFIG,
-                "IBSS Beacon config, intval: %d, nexttbtt: %u, imask: 0x%x\n",
+                "IBSS Beacon config, intval: %d, nexttbtt: %u, "
-                bss_conf->beacon_interval, nexttbtt, imask);
+                "resp_time: %d, imask: 0x%x\n",
+                bss_conf->beacon_interval, nexttbtt,
+                priv->ah->config.sw_beacon_response_time, imask);
        WMI_CMD(WMI_DISABLE_INTR_CMDID);
-        ath9k_hw_beaconinit(priv->ah, nexttbtt, intval);
+        ath9k_hw_beaconinit(priv->ah, TU_TO_USEC(nexttbtt), TU_TO_USEC(intval));
-        priv->bmiss_cnt = 0;
+        priv->cur_beacon_conf.bmiss_cnt = 0;
        htc_imask = cpu_to_be32(imask);
        WMI_CMD_BUF(WMI_ENABLE_INTR_CMDID, &htc_imask);
 }
@@ -228,38 +292,101 @@ void ath9k_htc_beaconep(void *drv_priv, struct sk_buff *skb,
        dev_kfree_skb_any(skb);
 }
-void ath9k_htc_swba(struct ath9k_htc_priv *priv, u8 beacon_pending)
+static void ath9k_htc_send_buffered(struct ath9k_htc_priv *priv,
+                                    int slot)
 {
-        struct ath9k_htc_vif *avp = (void *)priv->vif->drv_priv;
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct ieee80211_vif *vif;
+        struct sk_buff *skb;
+        struct ieee80211_hdr *hdr;
+        int padpos, padsize, ret, tx_slot;
+        spin_lock_bh(&priv->beacon_lock);
+        vif = priv->cur_beacon_conf.bslot[slot];
+        skb = ieee80211_get_buffered_bc(priv->hw, vif);
+        while(skb) {
+                hdr = (struct ieee80211_hdr *) skb->data;
+                padpos = ath9k_cmn_padpos(hdr->frame_control);
+                padsize = padpos & 3;
+                if (padsize && skb->len > padpos) {
+                        if (skb_headroom(skb) < padsize) {
+                                dev_kfree_skb_any(skb);
+                                goto next;
+                        }
+                        skb_push(skb, padsize);
+                        memmove(skb->data, skb->data + padsize, padpos);
+                }
+                tx_slot = ath9k_htc_tx_get_slot(priv);
+                if (tx_slot < 0) {
+                        ath_dbg(common, ATH_DBG_XMIT, "No free CAB slot\n");
+                        dev_kfree_skb_any(skb);
+                        goto next;
+                }
+                ret = ath9k_htc_tx_start(priv, skb, tx_slot, true);
+                if (ret != 0) {
+                        ath9k_htc_tx_clear_slot(priv, tx_slot);
+                        dev_kfree_skb_any(skb);
+                        ath_dbg(common, ATH_DBG_XMIT,
+                                "Failed to send CAB frame\n");
+                } else {
+                        spin_lock_bh(&priv->tx.tx_lock);
+                        priv->tx.queued_cnt++;
+                        spin_unlock_bh(&priv->tx.tx_lock);
+                }
+        next:
+                skb = ieee80211_get_buffered_bc(priv->hw, vif);
+        }
+        spin_unlock_bh(&priv->beacon_lock);
+}
+static void ath9k_htc_send_beacon(struct ath9k_htc_priv *priv,
+                                  int slot)
+{
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct ieee80211_vif *vif;
+        struct ath9k_htc_vif *avp;
        struct tx_beacon_header beacon_hdr;
-        struct ath9k_htc_tx_ctl tx_ctl;
+        struct ath9k_htc_tx_ctl *tx_ctl;
        struct ieee80211_tx_info *info;
+        struct ieee80211_mgmt *mgmt;
        struct sk_buff *beacon;
        u8 *tx_fhdr;
+        int ret;
        memset(&beacon_hdr, 0, sizeof(struct tx_beacon_header));
-        memset(&tx_ctl, 0, sizeof(struct ath9k_htc_tx_ctl));
-        /* FIXME: Handle BMISS */
-        if (beacon_pending != 0) {
-                priv->bmiss_cnt++;
-                return;
-        }
        spin_lock_bh(&priv->beacon_lock);
+        vif = priv->cur_beacon_conf.bslot[slot];
+        avp = (struct ath9k_htc_vif *)vif->drv_priv;
        if (unlikely(priv->op_flags & OP_SCANNING)) {
                spin_unlock_bh(&priv->beacon_lock);
                return;
        }
        /* Get a new beacon */
-        beacon = ieee80211_beacon_get(priv->hw, priv->vif);
+        beacon = ieee80211_beacon_get(priv->hw, vif);
        if (!beacon) {
                spin_unlock_bh(&priv->beacon_lock);
                return;
        }
+        /*
+         * Update the TSF adjust value here, the HW will
+         * add this value for every beacon.
+         */
+        mgmt = (struct ieee80211_mgmt *)beacon->data;
+        mgmt->u.beacon.timestamp = avp->tsfadjust;
        info = IEEE80211_SKB_CB(beacon);
        if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ) {
                struct ieee80211_hdr *hdr =
@@ -269,45 +396,149 @@ void ath9k_htc_swba(struct ath9k_htc_priv *priv, u8 beacon_pending)
                hdr->seq_ctrl |= cpu_to_le16(avp->seq_no);
        }
-        tx_ctl.type = ATH9K_HTC_NORMAL;
+        tx_ctl = HTC_SKB_CB(beacon);
+        memset(tx_ctl, 0, sizeof(*tx_ctl));
+        tx_ctl->type = ATH9K_HTC_BEACON;
+        tx_ctl->epid = priv->beacon_ep;
        beacon_hdr.vif_index = avp->index;
        tx_fhdr = skb_push(beacon, sizeof(beacon_hdr));
        memcpy(tx_fhdr, (u8 *) &beacon_hdr, sizeof(beacon_hdr));
-        htc_send(priv->htc, beacon, priv->beacon_ep, &tx_ctl);
+        ret = htc_send(priv->htc, beacon);
+        if (ret != 0) {
+                if (ret == -ENOMEM) {
+                        ath_dbg(common, ATH_DBG_BSTUCK,
+                                "Failed to send beacon, no free TX buffer\n");
+                }
+                dev_kfree_skb_any(beacon);
+        }
        spin_unlock_bh(&priv->beacon_lock);
 }
-/* Currently, only for IBSS */
+static int ath9k_htc_choose_bslot(struct ath9k_htc_priv *priv,
-void ath9k_htc_beaconq_config(struct ath9k_htc_priv *priv)
+                                  struct wmi_event_swba *swba)
 {
-        struct ath_hw *ah = priv->ah;
+        struct ath_common *common = ath9k_hw_common(priv->ah);
-        struct ath9k_tx_queue_info qi, qi_be;
+        u64 tsf;
-        int qnum = priv->hwq_map[WME_AC_BE];
+        u32 tsftu;
+        u16 intval;
+        int slot;
-        memset(&qi, 0, sizeof(struct ath9k_tx_queue_info));
+        intval = priv->cur_beacon_conf.beacon_interval & ATH9K_BEACON_PERIOD;
-        memset(&qi_be, 0, sizeof(struct ath9k_tx_queue_info));
-        ath9k_hw_get_txq_props(ah, qnum, &qi_be);
+        tsf = be64_to_cpu(swba->tsf);
+        tsftu = TSF_TO_TU(tsf >> 32, tsf);
+        slot = ((tsftu % intval) * ATH9K_HTC_MAX_BCN_VIF) / intval;
+        slot = ATH9K_HTC_MAX_BCN_VIF - slot - 1;
-        qi.tqi_aifs = qi_be.tqi_aifs;
+        ath_dbg(common, ATH_DBG_BEACON,
-        /* For WIFI Beacon Distribution
+                "Choose slot: %d, tsf: %llu, tsftu: %u, intval: %u\n",
-         * Long slot time  : 2x cwmin
+                slot, tsf, tsftu, intval);
-         * Short slot time : 4x cwmin
-         */
-        if (ah->slottime == ATH9K_SLOT_TIME_20)
-                qi.tqi_cwmin = 2*qi_be.tqi_cwmin;
-        else
-                qi.tqi_cwmin = 4*qi_be.tqi_cwmin;
-        qi.tqi_cwmax = qi_be.tqi_cwmax;
-        if (!ath9k_hw_set_txq_props(ah, priv->beaconq, &qi)) {
+        return slot;
-                ath_err(ath9k_hw_common(ah),
+}
-                        "Unable to update beacon queue %u!\n", qnum);
-        } else {
+void ath9k_htc_swba(struct ath9k_htc_priv *priv,
-                ath9k_hw_resettxqueue(ah, priv->beaconq);
+                    struct wmi_event_swba *swba)
+{
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        int slot;
+        if (swba->beacon_pending != 0) {
+                priv->cur_beacon_conf.bmiss_cnt++;
+                if (priv->cur_beacon_conf.bmiss_cnt > BSTUCK_THRESHOLD) {
+                        ath_dbg(common, ATH_DBG_BSTUCK,
+                                "Beacon stuck, HW reset\n");
+                        ieee80211_queue_work(priv->hw,
+                                             &priv->fatal_work);
+                }
+                return;
        }
+        if (priv->cur_beacon_conf.bmiss_cnt) {
+                ath_dbg(common, ATH_DBG_BSTUCK,
+                        "Resuming beacon xmit after %u misses\n",
+                        priv->cur_beacon_conf.bmiss_cnt);
+                priv->cur_beacon_conf.bmiss_cnt = 0;
+        }
+        slot = ath9k_htc_choose_bslot(priv, swba);
+        spin_lock_bh(&priv->beacon_lock);
+        if (priv->cur_beacon_conf.bslot[slot] == NULL) {
+                spin_unlock_bh(&priv->beacon_lock);
+                return;
+        }
+        spin_unlock_bh(&priv->beacon_lock);
+        ath9k_htc_send_buffered(priv, slot);
+        ath9k_htc_send_beacon(priv, slot);
+}
+void ath9k_htc_assign_bslot(struct ath9k_htc_priv *priv,
+                            struct ieee80211_vif *vif)
+{
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct ath9k_htc_vif *avp = (struct ath9k_htc_vif *)vif->drv_priv;
+        int i = 0;
+        spin_lock_bh(&priv->beacon_lock);
+        for (i = 0; i < ATH9K_HTC_MAX_BCN_VIF; i++) {
+                if (priv->cur_beacon_conf.bslot[i] == NULL) {
+                        avp->bslot = i;
+                        break;
+                }
+        }
+        priv->cur_beacon_conf.bslot[avp->bslot] = vif;
+        spin_unlock_bh(&priv->beacon_lock);
+        ath_dbg(common, ATH_DBG_CONFIG,
+                "Added interface at beacon slot: %d\n", avp->bslot);
+}
+void ath9k_htc_remove_bslot(struct ath9k_htc_priv *priv,
+                            struct ieee80211_vif *vif)
+{
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct ath9k_htc_vif *avp = (struct ath9k_htc_vif *)vif->drv_priv;
+        spin_lock_bh(&priv->beacon_lock);
+        priv->cur_beacon_conf.bslot[avp->bslot] = NULL;
+        spin_unlock_bh(&priv->beacon_lock);
+        ath_dbg(common, ATH_DBG_CONFIG,
+                "Removed interface at beacon slot: %d\n", avp->bslot);
+}
+/*
+ * Calculate the TSF adjustment value for all slots
+ * other than zero.
+ */
+void ath9k_htc_set_tsfadjust(struct ath9k_htc_priv *priv,
+                             struct ieee80211_vif *vif)
+{
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct ath9k_htc_vif *avp = (struct ath9k_htc_vif *)vif->drv_priv;
+        struct htc_beacon_config *cur_conf = &priv->cur_beacon_conf;
+        u64 tsfadjust;
+        if (avp->bslot == 0)
+                return;
+        /*
+         * The beacon interval cannot be different for multi-AP mode,
+         * and we reach here only for VIF slots greater than zero,
+         * so beacon_interval is guaranteed to be set in cur_conf.
+         */
+        tsfadjust = cur_conf->beacon_interval * avp->bslot / ATH9K_HTC_MAX_BCN_VIF;
+        avp->tsfadjust = cpu_to_le64(TU_TO_USEC(tsfadjust));
+        ath_dbg(common, ATH_DBG_CONFIG,
+                "tsfadjust is: %llu for bslot: %d\n",
+                (unsigned long long)tsfadjust, avp->bslot);
 }
 static void ath9k_htc_beacon_iter(void *data, u8 *mac, struct ieee80211_vif *vif)
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_debug.c b/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
new file mode 100644
index 000000000000..aa48b3abbc48
--- /dev/null
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
@@ -0,0 +1,960 @@
+/*
+ * Copyright (c) 2010-2011 Atheros Communications Inc.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+#include "htc.h"
+static int ath9k_debugfs_open(struct inode *inode, struct file *file)
+{
+        file->private_data = inode->i_private;
+        return 0;
+}
+static ssize_t read_file_tgt_int_stats(struct file *file, char __user *user_buf,
+                                       size_t count, loff_t *ppos)
+{
+        struct ath9k_htc_priv *priv = file->private_data;
+        struct ath9k_htc_target_int_stats cmd_rsp;
+        char buf[512];
+        unsigned int len = 0;
+        int ret = 0;
+        memset(&cmd_rsp, 0, sizeof(cmd_rsp));
+        ath9k_htc_ps_wakeup(priv);
+        WMI_CMD(WMI_INT_STATS_CMDID);
+        if (ret) {
+                ath9k_htc_ps_restore(priv);
+                return -EINVAL;
+        }
+        ath9k_htc_ps_restore(priv);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "RX",
+                        be32_to_cpu(cmd_rsp.rx));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "RXORN",
+                        be32_to_cpu(cmd_rsp.rxorn));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "RXEOL",
+                        be32_to_cpu(cmd_rsp.rxeol));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "TXURN",
+                        be32_to_cpu(cmd_rsp.txurn));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "TXTO",
+                        be32_to_cpu(cmd_rsp.txto));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "CST",
+                        be32_to_cpu(cmd_rsp.cst));
+        if (len > sizeof(buf))
+                len = sizeof(buf);
+        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
+}
+static const struct file_operations fops_tgt_int_stats = {
+        .read = read_file_tgt_int_stats,
+        .open = ath9k_debugfs_open,
+        .owner = THIS_MODULE,
+        .llseek = default_llseek,
+};
+static ssize_t read_file_tgt_tx_stats(struct file *file, char __user *user_buf,
+                                      size_t count, loff_t *ppos)
+{
+        struct ath9k_htc_priv *priv = file->private_data;
+        struct ath9k_htc_target_tx_stats cmd_rsp;
+        char buf[512];
+        unsigned int len = 0;
+        int ret = 0;
+        memset(&cmd_rsp, 0, sizeof(cmd_rsp));
+        ath9k_htc_ps_wakeup(priv);
+        WMI_CMD(WMI_TX_STATS_CMDID);
+        if (ret) {
+                ath9k_htc_ps_restore(priv);
+                return -EINVAL;
+        }
+        ath9k_htc_ps_restore(priv);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "Xretries",
+                        be32_to_cpu(cmd_rsp.xretries));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "FifoErr",
+                        be32_to_cpu(cmd_rsp.fifoerr));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "Filtered",
+                        be32_to_cpu(cmd_rsp.filtered));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "TimerExp",
+                        be32_to_cpu(cmd_rsp.timer_exp));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "ShortRetries",
+                        be32_to_cpu(cmd_rsp.shortretries));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "LongRetries",
+                        be32_to_cpu(cmd_rsp.longretries));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "QueueNull",
+                        be32_to_cpu(cmd_rsp.qnull));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "EncapFail",
+                        be32_to_cpu(cmd_rsp.encap_fail));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "NoBuf",
+                        be32_to_cpu(cmd_rsp.nobuf));
+        if (len > sizeof(buf))
+                len = sizeof(buf);
+        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
+}
+static const struct file_operations fops_tgt_tx_stats = {
+        .read = read_file_tgt_tx_stats,
+        .open = ath9k_debugfs_open,
+        .owner = THIS_MODULE,
+        .llseek = default_llseek,
+};
+static ssize_t read_file_tgt_rx_stats(struct file *file, char __user *user_buf,
+                                      size_t count, loff_t *ppos)
+{
+        struct ath9k_htc_priv *priv = file->private_data;
+        struct ath9k_htc_target_rx_stats cmd_rsp;
+        char buf[512];
+        unsigned int len = 0;
+        int ret = 0;
+        memset(&cmd_rsp, 0, sizeof(cmd_rsp));
+        ath9k_htc_ps_wakeup(priv);
+        WMI_CMD(WMI_RX_STATS_CMDID);
+        if (ret) {
+                ath9k_htc_ps_restore(priv);
+                return -EINVAL;
+        }
+        ath9k_htc_ps_restore(priv);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "NoBuf",
+                        be32_to_cpu(cmd_rsp.nobuf));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "HostSend",
+                        be32_to_cpu(cmd_rsp.host_send));
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "HostDone",
+                        be32_to_cpu(cmd_rsp.host_done));
+        if (len > sizeof(buf))
+                len = sizeof(buf);
+        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
+}
+static const struct file_operations fops_tgt_rx_stats = {
+        .read = read_file_tgt_rx_stats,
+        .open = ath9k_debugfs_open,
+        .owner = THIS_MODULE,
+        .llseek = default_llseek,
+};
+static ssize_t read_file_xmit(struct file *file, char __user *user_buf,
+                              size_t count, loff_t *ppos)
+{
+        struct ath9k_htc_priv *priv = file->private_data;
+        char buf[512];
+        unsigned int len = 0;
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "Buffers queued",
+                        priv->debug.tx_stats.buf_queued);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "Buffers completed",
+                        priv->debug.tx_stats.buf_completed);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "SKBs queued",
+                        priv->debug.tx_stats.skb_queued);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "SKBs success",
+                        priv->debug.tx_stats.skb_success);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "SKBs failed",
+                        priv->debug.tx_stats.skb_failed);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "CAB queued",
+                        priv->debug.tx_stats.cab_queued);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "BE queued",
+                        priv->debug.tx_stats.queue_stats[WME_AC_BE]);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "BK queued",
+                        priv->debug.tx_stats.queue_stats[WME_AC_BK]);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "VI queued",
+                        priv->debug.tx_stats.queue_stats[WME_AC_VI]);
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "%20s : %10u\n", "VO queued",
+                        priv->debug.tx_stats.queue_stats[WME_AC_VO]);
+        if (len > sizeof(buf))
+                len = sizeof(buf);
+        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
+}
+static const struct file_operations fops_xmit = {
+        .read = read_file_xmit,
+        .open = ath9k_debugfs_open,
+        .owner = THIS_MODULE,
+        .llseek = default_llseek,
+};
+void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv,
+                           struct ath_htc_rx_status *rxs)
+{
+#define RX_PHY_ERR_INC(c) priv->debug.rx_stats.err_phy_stats[c]++
+        if (rxs->rs_status & ATH9K_RXERR_CRC)
+                priv->debug.rx_stats.err_crc++;
+        if (rxs->rs_status & ATH9K_RXERR_DECRYPT)
+                priv->debug.rx_stats.err_decrypt_crc++;
+        if (rxs->rs_status & ATH9K_RXERR_MIC)
+                priv->debug.rx_stats.err_mic++;
+        if (rxs->rs_status & ATH9K_RX_DELIM_CRC_PRE)
+                priv->debug.rx_stats.err_pre_delim++;
+        if (rxs->rs_status & ATH9K_RX_DELIM_CRC_POST)
+                priv->debug.rx_stats.err_post_delim++;
+        if (rxs->rs_status & ATH9K_RX_DECRYPT_BUSY)
+                priv->debug.rx_stats.err_decrypt_busy++;
+        if (rxs->rs_status & ATH9K_RXERR_PHY) {
+                priv->debug.rx_stats.err_phy++;
+                if (rxs->rs_phyerr < ATH9K_PHYERR_MAX)
+                        RX_PHY_ERR_INC(rxs->rs_phyerr);
+        }
+#undef RX_PHY_ERR_INC
+}
+static ssize_t read_file_recv(struct file *file, char __user *user_buf,
+                              size_t count, loff_t *ppos)
+{
+#define PHY_ERR(s, p)                                                   \
+        len += snprintf(buf + len, size - len, "%20s : %10u\n", s,      \
+                        priv->debug.rx_stats.err_phy_stats[p]);
+        struct ath9k_htc_priv *priv = file->private_data;
+        char *buf;
+        unsigned int len = 0, size = 1500;
+        ssize_t retval = 0;
+        buf = kzalloc(size, GFP_KERNEL);
+        if (buf == NULL)
+                return -ENOMEM;
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10u\n", "SKBs allocated",
+                        priv->debug.rx_stats.skb_allocated);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10u\n", "SKBs completed",
+                        priv->debug.rx_stats.skb_completed);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10u\n", "SKBs Dropped",
+                        priv->debug.rx_stats.skb_dropped);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10u\n", "CRC ERR",
+                        priv->debug.rx_stats.err_crc);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10u\n", "DECRYPT CRC ERR",
+                        priv->debug.rx_stats.err_decrypt_crc);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10u\n", "MIC ERR",
+                        priv->debug.rx_stats.err_mic);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10u\n", "PRE-DELIM CRC ERR",
+                        priv->debug.rx_stats.err_pre_delim);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10u\n", "POST-DELIM CRC ERR",
+                        priv->debug.rx_stats.err_post_delim);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10u\n", "DECRYPT BUSY ERR",
+                        priv->debug.rx_stats.err_decrypt_busy);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10u\n", "TOTAL PHY ERR",
+                        priv->debug.rx_stats.err_phy);
+        PHY_ERR("UNDERRUN", ATH9K_PHYERR_UNDERRUN);
+        PHY_ERR("TIMING", ATH9K_PHYERR_TIMING);
+        PHY_ERR("PARITY", ATH9K_PHYERR_PARITY);
+        PHY_ERR("RATE", ATH9K_PHYERR_RATE);
+        PHY_ERR("LENGTH", ATH9K_PHYERR_LENGTH);
+        PHY_ERR("RADAR", ATH9K_PHYERR_RADAR);
+        PHY_ERR("SERVICE", ATH9K_PHYERR_SERVICE);
+        PHY_ERR("TOR", ATH9K_PHYERR_TOR);
+        PHY_ERR("OFDM-TIMING", ATH9K_PHYERR_OFDM_TIMING);
+        PHY_ERR("OFDM-SIGNAL-PARITY", ATH9K_PHYERR_OFDM_SIGNAL_PARITY);
+        PHY_ERR("OFDM-RATE", ATH9K_PHYERR_OFDM_RATE_ILLEGAL);
+        PHY_ERR("OFDM-LENGTH", ATH9K_PHYERR_OFDM_LENGTH_ILLEGAL);
+        PHY_ERR("OFDM-POWER-DROP", ATH9K_PHYERR_OFDM_POWER_DROP);
+        PHY_ERR("OFDM-SERVICE", ATH9K_PHYERR_OFDM_SERVICE);
+        PHY_ERR("OFDM-RESTART", ATH9K_PHYERR_OFDM_RESTART);
+        PHY_ERR("FALSE-RADAR-EXT", ATH9K_PHYERR_FALSE_RADAR_EXT);
+        PHY_ERR("CCK-TIMING", ATH9K_PHYERR_CCK_TIMING);
+        PHY_ERR("CCK-HEADER-CRC", ATH9K_PHYERR_CCK_HEADER_CRC);
+        PHY_ERR("CCK-RATE", ATH9K_PHYERR_CCK_RATE_ILLEGAL);
+        PHY_ERR("CCK-SERVICE", ATH9K_PHYERR_CCK_SERVICE);
+        PHY_ERR("CCK-RESTART", ATH9K_PHYERR_CCK_RESTART);
+        PHY_ERR("CCK-LENGTH", ATH9K_PHYERR_CCK_LENGTH_ILLEGAL);
+        PHY_ERR("CCK-POWER-DROP", ATH9K_PHYERR_CCK_POWER_DROP);
+        PHY_ERR("HT-CRC", ATH9K_PHYERR_HT_CRC_ERROR);
+        PHY_ERR("HT-LENGTH", ATH9K_PHYERR_HT_LENGTH_ILLEGAL);
+        PHY_ERR("HT-RATE", ATH9K_PHYERR_HT_RATE_ILLEGAL);
+        if (len > size)
+                len = size;
+        retval = simple_read_from_buffer(user_buf, count, ppos, buf, len);
+        kfree(buf);
+        return retval;
+#undef PHY_ERR
+}
+static const struct file_operations fops_recv = {
+        .read = read_file_recv,
+        .open = ath9k_debugfs_open,
+        .owner = THIS_MODULE,
+        .llseek = default_llseek,
+};
+static ssize_t read_file_slot(struct file *file, char __user *user_buf,
+                              size_t count, loff_t *ppos)
+{
+        struct ath9k_htc_priv *priv = file->private_data;
+        char buf[512];
+        unsigned int len = 0;
+        spin_lock_bh(&priv->tx.tx_lock);
+        len += snprintf(buf + len, sizeof(buf) - len, "TX slot bitmap : ");
+        len += bitmap_scnprintf(buf + len, sizeof(buf) - len,
+                               priv->tx.tx_slot, MAX_TX_BUF_NUM);
+        len += snprintf(buf + len, sizeof(buf) - len, "\n");
+        len += snprintf(buf + len, sizeof(buf) - len,
+                        "Used slots     : %d\n",
+                        bitmap_weight(priv->tx.tx_slot, MAX_TX_BUF_NUM));
+        spin_unlock_bh(&priv->tx.tx_lock);
+        if (len > sizeof(buf))
+                len = sizeof(buf);
+        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
+}
+static const struct file_operations fops_slot = {
+        .read = read_file_slot,
+        .open = ath9k_debugfs_open,
+        .owner = THIS_MODULE,
+        .llseek = default_llseek,
+};
+static ssize_t read_file_queue(struct file *file, char __user *user_buf,
+                               size_t count, loff_t *ppos)
+{
+        struct ath9k_htc_priv *priv = file->private_data;
+        char buf[512];
+        unsigned int len = 0;
+        len += snprintf(buf + len, sizeof(buf) - len, "%20s : %10u\n",
+                        "Mgmt endpoint", skb_queue_len(&priv->tx.mgmt_ep_queue));
+        len += snprintf(buf + len, sizeof(buf) - len, "%20s : %10u\n",
+                        "Cab endpoint", skb_queue_len(&priv->tx.cab_ep_queue));
+        len += snprintf(buf + len, sizeof(buf) - len, "%20s : %10u\n",
+                        "Data BE endpoint", skb_queue_len(&priv->tx.data_be_queue));
+        len += snprintf(buf + len, sizeof(buf) - len, "%20s : %10u\n",
+                        "Data BK endpoint", skb_queue_len(&priv->tx.data_bk_queue));
+        len += snprintf(buf + len, sizeof(buf) - len, "%20s : %10u\n",
+                        "Data VI endpoint", skb_queue_len(&priv->tx.data_vi_queue));
+        len += snprintf(buf + len, sizeof(buf) - len, "%20s : %10u\n",
+                        "Data VO endpoint", skb_queue_len(&priv->tx.data_vo_queue));
+        len += snprintf(buf + len, sizeof(buf) - len, "%20s : %10u\n",
+                        "Failed queue", skb_queue_len(&priv->tx.tx_failed));
+        spin_lock_bh(&priv->tx.tx_lock);
+        len += snprintf(buf + len, sizeof(buf) - len, "%20s : %10u\n",
+                        "Queued count", priv->tx.queued_cnt);
+        spin_unlock_bh(&priv->tx.tx_lock);
+        if (len > sizeof(buf))
+                len = sizeof(buf);
+        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
+}
+static const struct file_operations fops_queue = {
+        .read = read_file_queue,
+        .open = ath9k_debugfs_open,
+        .owner = THIS_MODULE,
+        .llseek = default_llseek,
+};
+static ssize_t read_file_debug(struct file *file, char __user *user_buf,
+                               size_t count, loff_t *ppos)
+{
+        struct ath9k_htc_priv *priv = file->private_data;
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        char buf[32];
+        unsigned int len;
+        len = sprintf(buf, "0x%08x\n", common->debug_mask);
+        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
+}
+static ssize_t write_file_debug(struct file *file, const char __user *user_buf,
+                                size_t count, loff_t *ppos)
+{
+        struct ath9k_htc_priv *priv = file->private_data;
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        unsigned long mask;
+        char buf[32];
+        ssize_t len;
+        len = min(count, sizeof(buf) - 1);
+        if (copy_from_user(buf, user_buf, len))
+                return -EFAULT;
+        buf[len] = '\0';
+        if (strict_strtoul(buf, 0, &mask))
+                return -EINVAL;
+        common->debug_mask = mask;
+        return count;
+}
+static const struct file_operations fops_debug = {
+        .read = read_file_debug,
+        .write = write_file_debug,
+        .open = ath9k_debugfs_open,
+        .owner = THIS_MODULE,
+        .llseek = default_llseek,
+};
+static ssize_t read_file_base_eeprom(struct file *file, char __user *user_buf,
+                                     size_t count, loff_t *ppos)
+{
+        struct ath9k_htc_priv *priv = file->private_data;
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct base_eep_header *pBase = NULL;
+        unsigned int len = 0, size = 1500;
+        ssize_t retval = 0;
+        char *buf;
+        /*
+         * This can be done since all the 3 EEPROM families have the
+         * same base header upto a certain point, and we are interested in
+         * the data only upto that point.
+         */
+        if (AR_SREV_9271(priv->ah))
+                pBase = (struct base_eep_header *)
+                        &priv->ah->eeprom.map4k.baseEepHeader;
+        else if (priv->ah->hw_version.usbdev == AR9280_USB)
+                pBase = (struct base_eep_header *)
+                        &priv->ah->eeprom.def.baseEepHeader;
+        else if (priv->ah->hw_version.usbdev == AR9287_USB)
+                pBase = (struct base_eep_header *)
+                        &priv->ah->eeprom.map9287.baseEepHeader;
+        if (pBase == NULL) {
+                ath_err(common, "Unknown EEPROM type\n");
+                return 0;
+        }
+        buf = kzalloc(size, GFP_KERNEL);
+        if (buf == NULL)
+                return -ENOMEM;
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n", "Major Version",
+                        pBase->version >> 12);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n", "Minor Version",
+                        pBase->version & 0xFFF);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n", "Checksum",
+                        pBase->checksum);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n", "Length",
+                        pBase->length);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n", "RegDomain1",
+                        pBase->regDmn[0]);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n", "RegDomain2",
+                        pBase->regDmn[1]);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "TX Mask", pBase->txMask);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "RX Mask", pBase->rxMask);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "Allow 5GHz",
+                        !!(pBase->opCapFlags & AR5416_OPFLAGS_11A));
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "Allow 2GHz",
+                        !!(pBase->opCapFlags & AR5416_OPFLAGS_11G));
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "Disable 2GHz HT20",
+                        !!(pBase->opCapFlags & AR5416_OPFLAGS_N_2G_HT20));
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "Disable 2GHz HT40",
+                        !!(pBase->opCapFlags & AR5416_OPFLAGS_N_2G_HT40));
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "Disable 5Ghz HT20",
+                        !!(pBase->opCapFlags & AR5416_OPFLAGS_N_5G_HT20));
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "Disable 5Ghz HT40",
+                        !!(pBase->opCapFlags & AR5416_OPFLAGS_N_5G_HT40));
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "Big Endian",
+                        !!(pBase->eepMisc & 0x01));
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "Cal Bin Major Ver",
+                        (pBase->binBuildNumber >> 24) & 0xFF);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "Cal Bin Minor Ver",
+                        (pBase->binBuildNumber >> 16) & 0xFF);
+        len += snprintf(buf + len, size - len,
+                        "%20s : %10d\n",
+                        "Cal Bin Build",
+                        (pBase->binBuildNumber >> 8) & 0xFF);
+        /*
+         * UB91 specific data.
+         */
+        if (AR_SREV_9271(priv->ah)) {
+                struct base_eep_header_4k *pBase4k =
+                        &priv->ah->eeprom.map4k.baseEepHeader;
+                len += snprintf(buf + len, size - len,
+                                "%20s : %10d\n",
+                                "TX Gain type",
+                                pBase4k->txGainType);
+        }
+        /*
+         * UB95 specific data.
+         */
+        if (priv->ah->hw_version.usbdev == AR9287_USB) {
+                struct base_eep_ar9287_header *pBase9287 =
+                        &priv->ah->eeprom.map9287.baseEepHeader;
+                len += snprintf(buf + len, size - len,
+                                "%20s : %10ddB\n",
+                                "Power Table Offset",
+                                pBase9287->pwrTableOffset);
+                len += snprintf(buf + len, size - len,
+                                "%20s : %10d\n",
+                                "OpenLoop Power Ctrl",
+                                pBase9287->openLoopPwrCntl);
+        }
+        len += snprintf(buf + len, size - len,
+                        "%20s : %02X:%02X:%02X:%02X:%02X:%02X\n",
+                        "MacAddress",
+                        pBase->macAddr[0], pBase->macAddr[1], pBase->macAddr[2],
+                        pBase->macAddr[3], pBase->macAddr[4], pBase->macAddr[5]);
+        if (len > size)
+                len = size;
+        retval = simple_read_from_buffer(user_buf, count, ppos, buf, len);
+        kfree(buf);
+        return retval;
+}
+static const struct file_operations fops_base_eeprom = {
+        .read = read_file_base_eeprom,
+        .open = ath9k_debugfs_open,
+        .owner = THIS_MODULE,
+        .llseek = default_llseek,
+};
+static ssize_t read_4k_modal_eeprom(struct file *file,
+                                    char __user *user_buf,
+                                    size_t count, loff_t *ppos)
+{
+#define PR_EEP(_s, _val)                                                \
+        do {                                                            \
+                len += snprintf(buf + len, size - len, "%20s : %10d\n", \
+                                _s, (_val));                            \
+        } while (0)
+        struct ath9k_htc_priv *priv = file->private_data;
+        struct modal_eep_4k_header *pModal = &priv->ah->eeprom.map4k.modalHeader;
+        unsigned int len = 0, size = 2048;
+        ssize_t retval = 0;
+        char *buf;
+        buf = kzalloc(size, GFP_KERNEL);
+        if (buf == NULL)
+                return -ENOMEM;
+        PR_EEP("Chain0 Ant. Control", pModal->antCtrlChain[0]);
+        PR_EEP("Ant. Common Control", pModal->antCtrlCommon);
+        PR_EEP("Chain0 Ant. Gain", pModal->antennaGainCh[0]);
+        PR_EEP("Switch Settle", pModal->switchSettling);
+        PR_EEP("Chain0 TxRxAtten", pModal->txRxAttenCh[0]);
+        PR_EEP("Chain0 RxTxMargin", pModal->rxTxMarginCh[0]);
+        PR_EEP("ADC Desired size", pModal->adcDesiredSize);
+        PR_EEP("PGA Desired size", pModal->pgaDesiredSize);
+        PR_EEP("Chain0 xlna Gain", pModal->xlnaGainCh[0]);
+        PR_EEP("txEndToXpaOff", pModal->txEndToXpaOff);
+        PR_EEP("txEndToRxOn", pModal->txEndToRxOn);
+        PR_EEP("txFrameToXpaOn", pModal->txFrameToXpaOn);
+        PR_EEP("CCA Threshold)", pModal->thresh62);
+        PR_EEP("Chain0 NF Threshold", pModal->noiseFloorThreshCh[0]);
+        PR_EEP("xpdGain", pModal->xpdGain);
+        PR_EEP("External PD", pModal->xpd);
+        PR_EEP("Chain0 I Coefficient", pModal->iqCalICh[0]);
+        PR_EEP("Chain0 Q Coefficient", pModal->iqCalQCh[0]);
+        PR_EEP("pdGainOverlap", pModal->pdGainOverlap);
+        PR_EEP("O/D Bias Version", pModal->version);
+        PR_EEP("CCK OutputBias", pModal->ob_0);
+        PR_EEP("BPSK OutputBias", pModal->ob_1);
+        PR_EEP("QPSK OutputBias", pModal->ob_2);
+        PR_EEP("16QAM OutputBias", pModal->ob_3);
+        PR_EEP("64QAM OutputBias", pModal->ob_4);
+        PR_EEP("CCK Driver1_Bias", pModal->db1_0);
+        PR_EEP("BPSK Driver1_Bias", pModal->db1_1);
+        PR_EEP("QPSK Driver1_Bias", pModal->db1_2);
+        PR_EEP("16QAM Driver1_Bias", pModal->db1_3);
+        PR_EEP("64QAM Driver1_Bias", pModal->db1_4);
+        PR_EEP("CCK Driver2_Bias", pModal->db2_0);
+        PR_EEP("BPSK Driver2_Bias", pModal->db2_1);
+        PR_EEP("QPSK Driver2_Bias", pModal->db2_2);
+        PR_EEP("16QAM Driver2_Bias", pModal->db2_3);
+        PR_EEP("64QAM Driver2_Bias", pModal->db2_4);
+        PR_EEP("xPA Bias Level", pModal->xpaBiasLvl);
+        PR_EEP("txFrameToDataStart", pModal->txFrameToDataStart);
+        PR_EEP("txFrameToPaOn", pModal->txFrameToPaOn);
+        PR_EEP("HT40 Power Inc.", pModal->ht40PowerIncForPdadc);
+        PR_EEP("Chain0 bswAtten", pModal->bswAtten[0]);
+        PR_EEP("Chain0 bswMargin", pModal->bswMargin[0]);
+        PR_EEP("HT40 Switch Settle", pModal->swSettleHt40);
+        PR_EEP("Chain0 xatten2Db", pModal->xatten2Db[0]);
+        PR_EEP("Chain0 xatten2Margin", pModal->xatten2Margin[0]);
+        PR_EEP("Ant. Diversity ctl1", pModal->antdiv_ctl1);
+        PR_EEP("Ant. Diversity ctl2", pModal->antdiv_ctl2);
+        PR_EEP("TX Diversity", pModal->tx_diversity);
+        if (len > size)
+                len = size;
+        retval = simple_read_from_buffer(user_buf, count, ppos, buf, len);
+        kfree(buf);
+        return retval;
+#undef PR_EEP
+}
+static ssize_t read_def_modal_eeprom(struct file *file,
+                                     char __user *user_buf,
+                                     size_t count, loff_t *ppos)
+{
+#define PR_EEP(_s, _val)                                                \
+        do {                                                            \
+                if (pBase->opCapFlags & AR5416_OPFLAGS_11G) {           \
+                        pModal = &priv->ah->eeprom.def.modalHeader[1];  \
+                        len += snprintf(buf + len, size - len, "%20s : %8d%7s", \
+                                        _s, (_val), "|");               \
+                }                                                       \
+                if (pBase->opCapFlags & AR5416_OPFLAGS_11A) {           \
+                        pModal = &priv->ah->eeprom.def.modalHeader[0];  \
+                        len += snprintf(buf + len, size - len, "%9d\n", \
+                                        (_val));                        \
+                }                                                       \
+        } while (0)
+        struct ath9k_htc_priv *priv = file->private_data;
+        struct base_eep_header *pBase = &priv->ah->eeprom.def.baseEepHeader;
+        struct modal_eep_header *pModal = NULL;
+        unsigned int len = 0, size = 3500;
+        ssize_t retval = 0;
+        char *buf;
+        buf = kzalloc(size, GFP_KERNEL);
+        if (buf == NULL)
+                return -ENOMEM;
+        len += snprintf(buf + len, size - len,
+                        "%31s %15s\n", "2G", "5G");
+        len += snprintf(buf + len, size - len,
+                        "%32s %16s\n", "====", "====\n");
+        PR_EEP("Chain0 Ant. Control", pModal->antCtrlChain[0]);
+        PR_EEP("Chain1 Ant. Control", pModal->antCtrlChain[1]);
+        PR_EEP("Chain2 Ant. Control", pModal->antCtrlChain[2]);
+        PR_EEP("Ant. Common Control", pModal->antCtrlCommon);
+        PR_EEP("Chain0 Ant. Gain", pModal->antennaGainCh[0]);
+        PR_EEP("Chain1 Ant. Gain", pModal->antennaGainCh[1]);
+        PR_EEP("Chain2 Ant. Gain", pModal->antennaGainCh[2]);
+        PR_EEP("Switch Settle", pModal->switchSettling);
+        PR_EEP("Chain0 TxRxAtten", pModal->txRxAttenCh[0]);
+        PR_EEP("Chain1 TxRxAtten", pModal->txRxAttenCh[1]);
+        PR_EEP("Chain2 TxRxAtten", pModal->txRxAttenCh[2]);
+        PR_EEP("Chain0 RxTxMargin", pModal->rxTxMarginCh[0]);
+        PR_EEP("Chain1 RxTxMargin", pModal->rxTxMarginCh[1]);
+        PR_EEP("Chain2 RxTxMargin", pModal->rxTxMarginCh[2]);
+        PR_EEP("ADC Desired size", pModal->adcDesiredSize);
+        PR_EEP("PGA Desired size", pModal->pgaDesiredSize);
+        PR_EEP("Chain0 xlna Gain", pModal->xlnaGainCh[0]);
+        PR_EEP("Chain1 xlna Gain", pModal->xlnaGainCh[1]);
+        PR_EEP("Chain2 xlna Gain", pModal->xlnaGainCh[2]);
+        PR_EEP("txEndToXpaOff", pModal->txEndToXpaOff);
+        PR_EEP("txEndToRxOn", pModal->txEndToRxOn);
+        PR_EEP("txFrameToXpaOn", pModal->txFrameToXpaOn);
+        PR_EEP("CCA Threshold)", pModal->thresh62);
+        PR_EEP("Chain0 NF Threshold", pModal->noiseFloorThreshCh[0]);
+        PR_EEP("Chain1 NF Threshold", pModal->noiseFloorThreshCh[1]);
+        PR_EEP("Chain2 NF Threshold", pModal->noiseFloorThreshCh[2]);
+        PR_EEP("xpdGain", pModal->xpdGain);
+        PR_EEP("External PD", pModal->xpd);
+        PR_EEP("Chain0 I Coefficient", pModal->iqCalICh[0]);
+        PR_EEP("Chain1 I Coefficient", pModal->iqCalICh[1]);
+        PR_EEP("Chain2 I Coefficient", pModal->iqCalICh[2]);
+        PR_EEP("Chain0 Q Coefficient", pModal->iqCalQCh[0]);
+        PR_EEP("Chain1 Q Coefficient", pModal->iqCalQCh[1]);
+        PR_EEP("Chain2 Q Coefficient", pModal->iqCalQCh[2]);
+        PR_EEP("pdGainOverlap", pModal->pdGainOverlap);
+        PR_EEP("Chain0 OutputBias", pModal->ob);
+        PR_EEP("Chain0 DriverBias", pModal->db);
+        PR_EEP("xPA Bias Level", pModal->xpaBiasLvl);
+        PR_EEP("2chain pwr decrease", pModal->pwrDecreaseFor2Chain);
+        PR_EEP("3chain pwr decrease", pModal->pwrDecreaseFor3Chain);
+        PR_EEP("txFrameToDataStart", pModal->txFrameToDataStart);
+        PR_EEP("txFrameToPaOn", pModal->txFrameToPaOn);
+        PR_EEP("HT40 Power Inc.", pModal->ht40PowerIncForPdadc);
+        PR_EEP("Chain0 bswAtten", pModal->bswAtten[0]);
+        PR_EEP("Chain1 bswAtten", pModal->bswAtten[1]);
+        PR_EEP("Chain2 bswAtten", pModal->bswAtten[2]);
+        PR_EEP("Chain0 bswMargin", pModal->bswMargin[0]);
+        PR_EEP("Chain1 bswMargin", pModal->bswMargin[1]);
+        PR_EEP("Chain2 bswMargin", pModal->bswMargin[2]);
+        PR_EEP("HT40 Switch Settle", pModal->swSettleHt40);
+        PR_EEP("Chain0 xatten2Db", pModal->xatten2Db[0]);
+        PR_EEP("Chain1 xatten2Db", pModal->xatten2Db[1]);
+        PR_EEP("Chain2 xatten2Db", pModal->xatten2Db[2]);
+        PR_EEP("Chain0 xatten2Margin", pModal->xatten2Margin[0]);
+        PR_EEP("Chain1 xatten2Margin", pModal->xatten2Margin[1]);
+        PR_EEP("Chain2 xatten2Margin", pModal->xatten2Margin[2]);
+        PR_EEP("Chain1 OutputBias", pModal->ob_ch1);
+        PR_EEP("Chain1 DriverBias", pModal->db_ch1);
+        PR_EEP("LNA Control", pModal->lna_ctl);
+        PR_EEP("XPA Bias Freq0", pModal->xpaBiasLvlFreq[0]);
+        PR_EEP("XPA Bias Freq1", pModal->xpaBiasLvlFreq[1]);
+        PR_EEP("XPA Bias Freq2", pModal->xpaBiasLvlFreq[2]);
+        if (len > size)
+                len = size;
+        retval = simple_read_from_buffer(user_buf, count, ppos, buf, len);
+        kfree(buf);
+        return retval;
+#undef PR_EEP
+}
+static ssize_t read_9287_modal_eeprom(struct file *file,
+                                      char __user *user_buf,
+                                      size_t count, loff_t *ppos)
+{
+#define PR_EEP(_s, _val)                                                \
+        do {                                                            \
+                len += snprintf(buf + len, size - len, "%20s : %10d\n", \
+                                _s, (_val));                            \
+        } while (0)
+        struct ath9k_htc_priv *priv = file->private_data;
+        struct modal_eep_ar9287_header *pModal = &priv->ah->eeprom.map9287.modalHeader;
+        unsigned int len = 0, size = 3000;
+        ssize_t retval = 0;
+        char *buf;
+        buf = kzalloc(size, GFP_KERNEL);
+        if (buf == NULL)
+                return -ENOMEM;
+        PR_EEP("Chain0 Ant. Control", pModal->antCtrlChain[0]);
+        PR_EEP("Chain1 Ant. Control", pModal->antCtrlChain[1]);
+        PR_EEP("Ant. Common Control", pModal->antCtrlCommon);
+        PR_EEP("Chain0 Ant. Gain", pModal->antennaGainCh[0]);
+        PR_EEP("Chain1 Ant. Gain", pModal->antennaGainCh[1]);
+        PR_EEP("Switch Settle", pModal->switchSettling);
+        PR_EEP("Chain0 TxRxAtten", pModal->txRxAttenCh[0]);
+        PR_EEP("Chain1 TxRxAtten", pModal->txRxAttenCh[1]);
+        PR_EEP("Chain0 RxTxMargin", pModal->rxTxMarginCh[0]);
+        PR_EEP("Chain1 RxTxMargin", pModal->rxTxMarginCh[1]);
+        PR_EEP("ADC Desired size", pModal->adcDesiredSize);
+        PR_EEP("txEndToXpaOff", pModal->txEndToXpaOff);
+        PR_EEP("txEndToRxOn", pModal->txEndToRxOn);
+        PR_EEP("txFrameToXpaOn", pModal->txFrameToXpaOn);
+        PR_EEP("CCA Threshold)", pModal->thresh62);
+        PR_EEP("Chain0 NF Threshold", pModal->noiseFloorThreshCh[0]);
+        PR_EEP("Chain1 NF Threshold", pModal->noiseFloorThreshCh[1]);
+        PR_EEP("xpdGain", pModal->xpdGain);
+        PR_EEP("External PD", pModal->xpd);
+        PR_EEP("Chain0 I Coefficient", pModal->iqCalICh[0]);
+        PR_EEP("Chain1 I Coefficient", pModal->iqCalICh[1]);
+        PR_EEP("Chain0 Q Coefficient", pModal->iqCalQCh[0]);
+        PR_EEP("Chain1 Q Coefficient", pModal->iqCalQCh[1]);
+        PR_EEP("pdGainOverlap", pModal->pdGainOverlap);
+        PR_EEP("xPA Bias Level", pModal->xpaBiasLvl);
+        PR_EEP("txFrameToDataStart", pModal->txFrameToDataStart);
+        PR_EEP("txFrameToPaOn", pModal->txFrameToPaOn);
+        PR_EEP("HT40 Power Inc.", pModal->ht40PowerIncForPdadc);
+        PR_EEP("Chain0 bswAtten", pModal->bswAtten[0]);
+        PR_EEP("Chain1 bswAtten", pModal->bswAtten[1]);
+        PR_EEP("Chain0 bswMargin", pModal->bswMargin[0]);
+        PR_EEP("Chain1 bswMargin", pModal->bswMargin[1]);
+        PR_EEP("HT40 Switch Settle", pModal->swSettleHt40);
+        PR_EEP("AR92x7 Version", pModal->version);
+        PR_EEP("DriverBias1", pModal->db1);
+        PR_EEP("DriverBias2", pModal->db1);
+        PR_EEP("CCK OutputBias", pModal->ob_cck);
+        PR_EEP("PSK OutputBias", pModal->ob_psk);
+        PR_EEP("QAM OutputBias", pModal->ob_qam);
+        PR_EEP("PAL_OFF OutputBias", pModal->ob_pal_off);
+        if (len > size)
+                len = size;
+        retval = simple_read_from_buffer(user_buf, count, ppos, buf, len);
+        kfree(buf);
+        return retval;
+#undef PR_EEP
+}
+static ssize_t read_file_modal_eeprom(struct file *file, char __user *user_buf,
+                                      size_t count, loff_t *ppos)
+{
+        struct ath9k_htc_priv *priv = file->private_data;
+        if (AR_SREV_9271(priv->ah))
+                return read_4k_modal_eeprom(file, user_buf, count, ppos);
+        else if (priv->ah->hw_version.usbdev == AR9280_USB)
+                return read_def_modal_eeprom(file, user_buf, count, ppos);
+        else if (priv->ah->hw_version.usbdev == AR9287_USB)
+                return read_9287_modal_eeprom(file, user_buf, count, ppos);
+        return 0;
+}
+static const struct file_operations fops_modal_eeprom = {
+        .read = read_file_modal_eeprom,
+        .open = ath9k_debugfs_open,
+        .owner = THIS_MODULE,
+        .llseek = default_llseek,
+};
+int ath9k_htc_init_debug(struct ath_hw *ah)
+{
+        struct ath_common *common = ath9k_hw_common(ah);
+        struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *) common->priv;
+        priv->debug.debugfs_phy = debugfs_create_dir(KBUILD_MODNAME,
+                                             priv->hw->wiphy->debugfsdir);
+        if (!priv->debug.debugfs_phy)
+                return -ENOMEM;
+        debugfs_create_file("tgt_int_stats", S_IRUSR, priv->debug.debugfs_phy,
+                            priv, &fops_tgt_int_stats);
+        debugfs_create_file("tgt_tx_stats", S_IRUSR, priv->debug.debugfs_phy,
+                            priv, &fops_tgt_tx_stats);
+        debugfs_create_file("tgt_rx_stats", S_IRUSR, priv->debug.debugfs_phy,
+                            priv, &fops_tgt_rx_stats);
+        debugfs_create_file("xmit", S_IRUSR, priv->debug.debugfs_phy,
+                            priv, &fops_xmit);
+        debugfs_create_file("recv", S_IRUSR, priv->debug.debugfs_phy,
+                            priv, &fops_recv);
+        debugfs_create_file("slot", S_IRUSR, priv->debug.debugfs_phy,
+                            priv, &fops_slot);
+        debugfs_create_file("queue", S_IRUSR, priv->debug.debugfs_phy,
+                            priv, &fops_queue);
+        debugfs_create_file("debug", S_IRUSR | S_IWUSR, priv->debug.debugfs_phy,
+                            priv, &fops_debug);
+        debugfs_create_file("base_eeprom", S_IRUSR, priv->debug.debugfs_phy,
+                            priv, &fops_base_eeprom);
+        debugfs_create_file("modal_eeprom", S_IRUSR, priv->debug.debugfs_phy,
+                            priv, &fops_modal_eeprom);
+        return 0;
+}
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
index 7e630a81b453..af57fe5aab98 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
@@ -65,17 +65,19 @@ static void ath_btcoex_period_work(struct work_struct *work)
        u32 timer_period;
        bool is_btscan;
        int ret;
-        u8 cmd_rsp, aggr;
        ath_detect_bt_priority(priv);
        is_btscan = !!(priv->op_flags & OP_BT_SCAN);
-        aggr = priv->op_flags & OP_BT_PRIORITY_DETECTED;
+        ret = ath9k_htc_update_cap_target(priv,
+                                  !!(priv->op_flags & OP_BT_PRIORITY_DETECTED));
-        WMI_CMD_BUF(WMI_AGGR_LIMIT_CMD, &aggr);
+        if (ret) {
+                ath_err(common, "Unable to set BTCOEX parameters\n");
+                return;
+        }
-        ath9k_cmn_btcoex_bt_stomp(common, is_btscan ? ATH_BTCOEX_STOMP_ALL :
+        ath9k_hw_btcoex_bt_stomp(priv->ah, is_btscan ? ATH_BTCOEX_STOMP_ALL :
                        btcoex->bt_stomp_type);
        timer_period = is_btscan ? btcoex->btscan_no_stomp :
@@ -103,9 +105,9 @@ static void ath_btcoex_duty_cycle_work(struct work_struct *work)
                "time slice work for bt and wlan\n");
        if (btcoex->bt_stomp_type == ATH_BTCOEX_STOMP_LOW || is_btscan)
-                ath9k_cmn_btcoex_bt_stomp(common, ATH_BTCOEX_STOMP_NONE);
+                ath9k_hw_btcoex_bt_stomp(ah, ATH_BTCOEX_STOMP_NONE);
        else if (btcoex->bt_stomp_type == ATH_BTCOEX_STOMP_ALL)
-                ath9k_cmn_btcoex_bt_stomp(common, ATH_BTCOEX_STOMP_LOW);
+                ath9k_hw_btcoex_bt_stomp(ah, ATH_BTCOEX_STOMP_LOW);
 }
 void ath_htc_init_btcoex_work(struct ath9k_htc_priv *priv)
@@ -152,140 +154,41 @@ void ath_htc_cancel_btcoex_work(struct ath9k_htc_priv *priv)
 /* LED */
 /*******/
-static void ath9k_led_blink_work(struct work_struct *work)
+#ifdef CONFIG_MAC80211_LEDS
+void ath9k_led_work(struct work_struct *work)
 {
-        struct ath9k_htc_priv *priv = container_of(work, struct ath9k_htc_priv,
+        struct ath9k_htc_priv *priv = container_of(work,
-                                                   ath9k_led_blink_work.work);
+                                                   struct ath9k_htc_priv,
+                                                   led_work);
-        if (!(priv->op_flags & OP_LED_ASSOCIATED))
+        ath9k_hw_set_gpio(priv->ah, priv->ah->led_pin,
-                return;
+                          (priv->brightness == LED_OFF));
-        if ((priv->led_on_duration == ATH_LED_ON_DURATION_IDLE) ||
-            (priv->led_off_duration == ATH_LED_OFF_DURATION_IDLE))
-                ath9k_hw_set_gpio(priv->ah, priv->ah->led_pin, 0);
-        else
-                ath9k_hw_set_gpio(priv->ah, priv->ah->led_pin,
-                                  (priv->op_flags & OP_LED_ON) ? 1 : 0);
-        ieee80211_queue_delayed_work(priv->hw,
-                                     &priv->ath9k_led_blink_work,
-                                     (priv->op_flags & OP_LED_ON) ?
-                                     msecs_to_jiffies(priv->led_off_duration) :
-                                     msecs_to_jiffies(priv->led_on_duration));
-        priv->led_on_duration = priv->led_on_cnt ?
-                max((ATH_LED_ON_DURATION_IDLE - priv->led_on_cnt), 25) :
-                ATH_LED_ON_DURATION_IDLE;
-        priv->led_off_duration = priv->led_off_cnt ?
-                max((ATH_LED_OFF_DURATION_IDLE - priv->led_off_cnt), 10) :
-                ATH_LED_OFF_DURATION_IDLE;
-        priv->led_on_cnt = priv->led_off_cnt = 0;
-        if (priv->op_flags & OP_LED_ON)
-                priv->op_flags &= ~OP_LED_ON;
-        else
-                priv->op_flags |= OP_LED_ON;
-}
-static void ath9k_led_brightness_work(struct work_struct *work)
-{
-        struct ath_led *led = container_of(work, struct ath_led,
-                                           brightness_work.work);
-        struct ath9k_htc_priv *priv = led->priv;
-        switch (led->brightness) {
-        case LED_OFF:
-                if (led->led_type == ATH_LED_ASSOC ||
-                    led->led_type == ATH_LED_RADIO) {
-                        ath9k_hw_set_gpio(priv->ah, priv->ah->led_pin,
-                                          (led->led_type == ATH_LED_RADIO));
-                        priv->op_flags &= ~OP_LED_ASSOCIATED;
-                        if (led->led_type == ATH_LED_RADIO)
-                                priv->op_flags &= ~OP_LED_ON;
-                } else {
-                        priv->led_off_cnt++;
-                }
-                break;
-        case LED_FULL:
-                if (led->led_type == ATH_LED_ASSOC) {
-                        priv->op_flags |= OP_LED_ASSOCIATED;
-                        ieee80211_queue_delayed_work(priv->hw,
-                                             &priv->ath9k_led_blink_work, 0);
-                } else if (led->led_type == ATH_LED_RADIO) {
-                        ath9k_hw_set_gpio(priv->ah, priv->ah->led_pin, 0);
-                        priv->op_flags |= OP_LED_ON;
-                } else {
-                        priv->led_on_cnt++;
-                }
-                break;
-        default:
-                break;
-        }
 }
 static void ath9k_led_brightness(struct led_classdev *led_cdev,
                                 enum led_brightness brightness)
 {
-        struct ath_led *led = container_of(led_cdev, struct ath_led, led_cdev);
+        struct ath9k_htc_priv *priv = container_of(led_cdev,
-        struct ath9k_htc_priv *priv = led->priv;
+                                                   struct ath9k_htc_priv,
+                                                   led_cdev);
-        led->brightness = brightness;
-        if (!(priv->op_flags & OP_LED_DEINIT))
-                ieee80211_queue_delayed_work(priv->hw,
-                                             &led->brightness_work, 0);
-}
-void ath9k_led_stop_brightness(struct ath9k_htc_priv *priv)
-{
-        cancel_delayed_work_sync(&priv->radio_led.brightness_work);
-        cancel_delayed_work_sync(&priv->assoc_led.brightness_work);
-        cancel_delayed_work_sync(&priv->tx_led.brightness_work);
-        cancel_delayed_work_sync(&priv->rx_led.brightness_work);
-}
-static int ath9k_register_led(struct ath9k_htc_priv *priv, struct ath_led *led,
-                              char *trigger)
-{
-        int ret;
-        led->priv = priv;
-        led->led_cdev.name = led->name;
-        led->led_cdev.default_trigger = trigger;
-        led->led_cdev.brightness_set = ath9k_led_brightness;
-        ret = led_classdev_register(wiphy_dev(priv->hw->wiphy), &led->led_cdev);
+        /* Not locked, but it's just a tiny green light..*/
-        if (ret)
+        priv->brightness = brightness;
-                ath_err(ath9k_hw_common(priv->ah),
+        ieee80211_queue_work(priv->hw, &priv->led_work);
-                        "Failed to register led:%s", led->name);
-        else
-                led->registered = 1;
-        INIT_DELAYED_WORK(&led->brightness_work, ath9k_led_brightness_work);
-        return ret;
-}
-static void ath9k_unregister_led(struct ath_led *led)
-{
-        if (led->registered) {
-                led_classdev_unregister(&led->led_cdev);
-                led->registered = 0;
-        }
 }
 void ath9k_deinit_leds(struct ath9k_htc_priv *priv)
 {
-        priv->op_flags |= OP_LED_DEINIT;
+        if (!priv->led_registered)
-        ath9k_unregister_led(&priv->assoc_led);
+                return;
-        priv->op_flags &= ~OP_LED_ASSOCIATED;
-        ath9k_unregister_led(&priv->tx_led);
+        ath9k_led_brightness(&priv->led_cdev, LED_OFF);
-        ath9k_unregister_led(&priv->rx_led);
+        led_classdev_unregister(&priv->led_cdev);
-        ath9k_unregister_led(&priv->radio_led);
+        cancel_work_sync(&priv->led_work);
 }
 void ath9k_init_leds(struct ath9k_htc_priv *priv)
 {
-        char *trigger;
        int ret;
        if (AR_SREV_9287(priv->ah))
@@ -303,48 +206,21 @@ void ath9k_init_leds(struct ath9k_htc_priv *priv)
        /* LED off, active low */
        ath9k_hw_set_gpio(priv->ah, priv->ah->led_pin, 1);
-        INIT_DELAYED_WORK(&priv->ath9k_led_blink_work, ath9k_led_blink_work);
+        snprintf(priv->led_name, sizeof(priv->led_name),
+                "ath9k_htc-%s", wiphy_name(priv->hw->wiphy));
-        trigger = ieee80211_get_radio_led_name(priv->hw);
+        priv->led_cdev.name = priv->led_name;
-        snprintf(priv->radio_led.name, sizeof(priv->radio_led.name),
+        priv->led_cdev.brightness_set = ath9k_led_brightness;
-                "ath9k-%s::radio", wiphy_name(priv->hw->wiphy));
-        ret = ath9k_register_led(priv, &priv->radio_led, trigger);
-        priv->radio_led.led_type = ATH_LED_RADIO;
-        if (ret)
-                goto fail;
-        trigger = ieee80211_get_assoc_led_name(priv->hw);
-        snprintf(priv->assoc_led.name, sizeof(priv->assoc_led.name),
-                "ath9k-%s::assoc", wiphy_name(priv->hw->wiphy));
-        ret = ath9k_register_led(priv, &priv->assoc_led, trigger);
-        priv->assoc_led.led_type = ATH_LED_ASSOC;
-        if (ret)
-                goto fail;
-        trigger = ieee80211_get_tx_led_name(priv->hw);
-        snprintf(priv->tx_led.name, sizeof(priv->tx_led.name),
-                "ath9k-%s::tx", wiphy_name(priv->hw->wiphy));
-        ret = ath9k_register_led(priv, &priv->tx_led, trigger);
-        priv->tx_led.led_type = ATH_LED_TX;
-        if (ret)
-                goto fail;
-        trigger = ieee80211_get_rx_led_name(priv->hw);
-        snprintf(priv->rx_led.name, sizeof(priv->rx_led.name),
-                "ath9k-%s::rx", wiphy_name(priv->hw->wiphy));
-        ret = ath9k_register_led(priv, &priv->rx_led, trigger);
-        priv->rx_led.led_type = ATH_LED_RX;
-        if (ret)
-                goto fail;
-        priv->op_flags &= ~OP_LED_DEINIT;
-        return;
+        ret = led_classdev_register(wiphy_dev(priv->hw->wiphy), &priv->led_cdev);
+        if (ret < 0)
+                return;
+        INIT_WORK(&priv->led_work, ath9k_led_work);
+        priv->led_registered = true;
-fail:
+        return;
-        cancel_delayed_work_sync(&priv->ath9k_led_blink_work);
-        ath9k_deinit_leds(priv);
 }
+#endif
 /*******************/
 /*      Rfkill     */
@@ -398,9 +274,9 @@ void ath9k_htc_radio_enable(struct ieee80211_hw *hw)
        /* Start TX */
        htc_start(priv->htc);
-        spin_lock_bh(&priv->tx_lock);
+        spin_lock_bh(&priv->tx.tx_lock);
-        priv->tx_queues_stop = false;
+        priv->tx.flags &= ~ATH9K_HTC_OP_TX_QUEUES_STOP;
-        spin_unlock_bh(&priv->tx_lock);
+        spin_unlock_bh(&priv->tx.tx_lock);
        ieee80211_wake_queues(hw);
        WMI_CMD(WMI_ENABLE_INTR_CMDID);
@@ -429,13 +305,15 @@ void ath9k_htc_radio_disable(struct ieee80211_hw *hw)
        /* Stop TX */
        ieee80211_stop_queues(hw);
-        htc_stop(priv->htc);
+        ath9k_htc_tx_drain(priv);
        WMI_CMD(WMI_DRAIN_TXQ_ALL_CMDID);
-        skb_queue_purge(&priv->tx_queue);
        /* Stop RX */
        WMI_CMD(WMI_STOP_RECV_CMDID);
+        /* Clear the WMI event queue */
+        ath9k_wmi_event_drain(priv);
        /*
         * The MIB counters have to be disabled here,
         * since the target doesn't do it.
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
index fc67c937e172..bfdc8a887183 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
@@ -117,6 +117,21 @@ static struct ieee80211_rate ath9k_legacy_rates[] = {
        RATE(540, 0x0c, 0),
 };
+#ifdef CONFIG_MAC80211_LEDS
+static const struct ieee80211_tpt_blink ath9k_htc_tpt_blink[] = {
+        { .throughput = 0 * 1024, .blink_time = 334 },
+        { .throughput = 1 * 1024, .blink_time = 260 },
+        { .throughput = 5 * 1024, .blink_time = 220 },
+        { .throughput = 10 * 1024, .blink_time = 190 },
+        { .throughput = 20 * 1024, .blink_time = 170 },
+        { .throughput = 50 * 1024, .blink_time = 150 },
+        { .throughput = 70 * 1024, .blink_time = 130 },
+        { .throughput = 100 * 1024, .blink_time = 110 },
+        { .throughput = 200 * 1024, .blink_time = 80 },
+        { .throughput = 300 * 1024, .blink_time = 50 },
+};
+#endif
 static int ath9k_htc_wait_for_target(struct ath9k_htc_priv *priv)
 {
        int time_left;
@@ -140,7 +155,6 @@ static int ath9k_htc_wait_for_target(struct ath9k_htc_priv *priv)
 static void ath9k_deinit_priv(struct ath9k_htc_priv *priv)
 {
-        ath9k_htc_exit_debug(priv->ah);
        ath9k_hw_deinit(priv->ah);
        kfree(priv->ah);
        priv->ah = NULL;
@@ -244,7 +258,7 @@ static int ath9k_init_htc_services(struct ath9k_htc_priv *priv, u16 devid,
         */
        if (IS_AR7010_DEVICE(drv_info))
-                priv->htc->credits = 45;
+                priv->htc->credits = 48;
        else
                priv->htc->credits = 33;
@@ -430,13 +444,16 @@ static void ath9k_regwrite_flush(void *hw_priv)
        mutex_unlock(&priv->wmi->multi_write_mutex);
 }
-static const struct ath_ops ath9k_common_ops = {
+static u32 ath9k_reg_rmw(void *hw_priv, u32 reg_offset, u32 set, u32 clr)
-        .read = ath9k_regread,
+{
-        .multi_read = ath9k_multi_regread,
+        u32 val;
-        .write = ath9k_regwrite,
-        .enable_write_buffer = ath9k_enable_regwrite_buffer,
+        val = ath9k_regread(hw_priv, reg_offset);
-        .write_flush = ath9k_regwrite_flush,
+        val &= ~clr;
-};
+        val |= set;
+        ath9k_regwrite(hw_priv, val, reg_offset);
+        return val;
+}
 static void ath_usb_read_cachesize(struct ath_common *common, int *csz)
 {
@@ -561,13 +578,7 @@ static void ath9k_init_crypto(struct ath9k_htc_priv *priv)
        int i = 0;
        /* Get the hardware key cache size. */
-        common->keymax = priv->ah->caps.keycache_size;
+        common->keymax = AR_KEYTABLE_SIZE;
-        if (common->keymax > ATH_KEYMAX) {
-                ath_dbg(common, ATH_DBG_ANY,
-                        "Warning, using only %u entries in %u key cache\n",
-                        ATH_KEYMAX, common->keymax);
-                common->keymax = ATH_KEYMAX;
-        }
        if (priv->ah->misc_mode & AR_PCU_MIC_NEW_LOC_ENA)
                common->crypt_caps |= ATH_CRYPT_CAP_MIC_COMBINED;
@@ -646,7 +657,7 @@ static int ath9k_init_priv(struct ath9k_htc_priv *priv,
 {
        struct ath_hw *ah = NULL;
        struct ath_common *common;
-        int ret = 0, csz = 0;
+        int i, ret = 0, csz = 0;
        priv->op_flags |= OP_INVALID;
@@ -658,30 +669,35 @@ static int ath9k_init_priv(struct ath9k_htc_priv *priv,
        ah->hw_version.subsysid = 0; /* FIXME */
        ah->hw_version.usbdev = drv_info;
        ah->ah_flags |= AH_USE_EEPROM;
+        ah->reg_ops.read = ath9k_regread;
+        ah->reg_ops.multi_read = ath9k_multi_regread;
+        ah->reg_ops.write = ath9k_regwrite;
+        ah->reg_ops.enable_write_buffer = ath9k_enable_regwrite_buffer;
+        ah->reg_ops.write_flush = ath9k_regwrite_flush;
+        ah->reg_ops.rmw = ath9k_reg_rmw;
        priv->ah = ah;
        common = ath9k_hw_common(ah);
-        common->ops = &ath9k_common_ops;
+        common->ops = &ah->reg_ops;
        common->bus_ops = &ath9k_usb_bus_ops;
        common->ah = ah;
        common->hw = priv->hw;
        common->priv = priv;
        common->debug_mask = ath9k_debug;
-        spin_lock_init(&priv->wmi->wmi_lock);
        spin_lock_init(&priv->beacon_lock);
-        spin_lock_init(&priv->tx_lock);
+        spin_lock_init(&priv->tx.tx_lock);
        mutex_init(&priv->mutex);
        mutex_init(&priv->htc_pm_lock);
-        tasklet_init(&priv->swba_tasklet, ath9k_swba_tasklet,
-                     (unsigned long)priv);
        tasklet_init(&priv->rx_tasklet, ath9k_rx_tasklet,
                     (unsigned long)priv);
-        tasklet_init(&priv->tx_tasklet, ath9k_tx_tasklet,
+        tasklet_init(&priv->tx_failed_tasklet, ath9k_tx_failed_tasklet,
                     (unsigned long)priv);
        INIT_DELAYED_WORK(&priv->ani_work, ath9k_htc_ani_work);
        INIT_WORK(&priv->ps_work, ath9k_ps_work);
        INIT_WORK(&priv->fatal_work, ath9k_fatal_work);
+        setup_timer(&priv->tx.cleanup_timer, ath9k_htc_tx_cleanup_timer,
+                    (unsigned long)priv);
        /*
         * Cache line size is used to size and align various
@@ -698,16 +714,13 @@ static int ath9k_init_priv(struct ath9k_htc_priv *priv,
                goto err_hw;
        }
-        ret = ath9k_htc_init_debug(ah);
-        if (ret) {
-                ath_err(common, "Unable to create debugfs files\n");
-                goto err_debug;
-        }
        ret = ath9k_init_queues(priv);
        if (ret)
                goto err_queues;
+        for (i = 0; i < ATH9K_HTC_MAX_BCN_VIF; i++)
+                priv->cur_beacon_conf.bslot[i] = NULL;
        ath9k_init_crypto(priv);
        ath9k_init_channels_rates(priv);
        ath9k_init_misc(priv);
@@ -720,8 +733,6 @@ static int ath9k_init_priv(struct ath9k_htc_priv *priv,
        return 0;
 err_queues:
-        ath9k_htc_exit_debug(ah);
-err_debug:
        ath9k_hw_deinit(ah);
 err_hw:
@@ -742,17 +753,27 @@ static void ath9k_set_hw_capab(struct ath9k_htc_priv *priv,
                IEEE80211_HW_HAS_RATE_CONTROL |
                IEEE80211_HW_RX_INCLUDES_FCS |
                IEEE80211_HW_SUPPORTS_PS |
-                IEEE80211_HW_PS_NULLFUNC_STACK;
+                IEEE80211_HW_PS_NULLFUNC_STACK |
+                IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING;
        hw->wiphy->interface_modes =
                BIT(NL80211_IFTYPE_STATION) |
-                BIT(NL80211_IFTYPE_ADHOC);
+                BIT(NL80211_IFTYPE_ADHOC) |
+                BIT(NL80211_IFTYPE_AP) |
+                BIT(NL80211_IFTYPE_P2P_GO) |
+                BIT(NL80211_IFTYPE_P2P_CLIENT);
        hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
        hw->queues = 4;
        hw->channel_change_time = 5000;
        hw->max_listen_interval = 10;
+        if (AR_SREV_9271(priv->ah))
+                hw->max_tx_aggregation_subframes = MAX_TX_AMPDU_SUBFRAMES_9271;
+        else
+                hw->max_tx_aggregation_subframes = MAX_TX_AMPDU_SUBFRAMES_7010;
        hw->vif_data_size = sizeof(struct ath9k_htc_vif);
        hw->sta_data_size = sizeof(struct ath9k_htc_sta);
@@ -779,6 +800,43 @@ static void ath9k_set_hw_capab(struct ath9k_htc_priv *priv,
        SET_IEEE80211_PERM_ADDR(hw, common->macaddr);
 }
+static int ath9k_init_firmware_version(struct ath9k_htc_priv *priv)
+{
+        struct ieee80211_hw *hw = priv->hw;
+        struct wmi_fw_version cmd_rsp;
+        int ret;
+        memset(&cmd_rsp, 0, sizeof(cmd_rsp));
+        WMI_CMD(WMI_GET_FW_VERSION);
+        if (ret)
+                return -EINVAL;
+        priv->fw_version_major = be16_to_cpu(cmd_rsp.major);
+        priv->fw_version_minor = be16_to_cpu(cmd_rsp.minor);
+        snprintf(hw->wiphy->fw_version, ETHTOOL_BUSINFO_LEN, "%d.%d",
+                 priv->fw_version_major,
+                 priv->fw_version_minor);
+        dev_info(priv->dev, "ath9k_htc: FW Version: %d.%d\n",
+                 priv->fw_version_major,
+                 priv->fw_version_minor);
+        /*
+         * Check if the available FW matches the driver's
+         * required version.
+         */
+        if (priv->fw_version_major != MAJOR_VERSION_REQ ||
+            priv->fw_version_minor != MINOR_VERSION_REQ) {
+                dev_err(priv->dev, "ath9k_htc: Please upgrade to FW version %d.%d\n",
+                        MAJOR_VERSION_REQ, MINOR_VERSION_REQ);
+                return -EINVAL;
+        }
+        return 0;
+}
 static int ath9k_init_device(struct ath9k_htc_priv *priv,
                             u16 devid, char *product, u32 drv_info)
 {
@@ -798,6 +856,10 @@ static int ath9k_init_device(struct ath9k_htc_priv *priv,
        common = ath9k_hw_common(ah);
        ath9k_set_hw_capab(priv, hw);
+        error = ath9k_init_firmware_version(priv);
+        if (error != 0)
+                goto err_fw;
        /* Initialize regulatory */
        error = ath_regd_init(&common->regulatory, priv->hw->wiphy,
                              ath9k_reg_notifier);
@@ -816,6 +878,13 @@ static int ath9k_init_device(struct ath9k_htc_priv *priv,
        if (error != 0)
                goto err_rx;
+#ifdef CONFIG_MAC80211_LEDS
+        /* must be initialized before ieee80211_register_hw */
+        priv->led_cdev.default_trigger = ieee80211_create_tpt_led_trigger(priv->hw,
+                IEEE80211_TPT_LEDTRIG_FL_RADIO, ath9k_htc_tpt_blink,
+                ARRAY_SIZE(ath9k_htc_tpt_blink));
+#endif
        /* Register with mac80211 */
        error = ieee80211_register_hw(hw);
        if (error)
@@ -828,6 +897,12 @@ static int ath9k_init_device(struct ath9k_htc_priv *priv,
                        goto err_world;
        }
+        error = ath9k_htc_init_debug(priv->ah);
+        if (error) {
+                ath_err(common, "Unable to create debugfs files\n");
+                goto err_world;
+        }
        ath_dbg(common, ATH_DBG_CONFIG,
                "WMI:%d, BCN:%d, CAB:%d, UAPSD:%d, MGMT:%d, "
                "BE:%d, BK:%d, VI:%d, VO:%d\n",
@@ -858,6 +933,8 @@ err_rx:
 err_tx:
        /* Nothing */
 err_regd:
+        /* Nothing */
+err_fw:
        ath9k_deinit_priv(priv);
 err_init:
        return error;
@@ -946,38 +1023,20 @@ int ath9k_htc_resume(struct htc_target *htc_handle)
 static int __init ath9k_htc_init(void)
 {
-        int error;
+        if (ath9k_hif_usb_init() < 0) {
-        error = ath9k_htc_debug_create_root();
-        if (error < 0) {
-                printk(KERN_ERR
-                        "ath9k_htc: Unable to create debugfs root: %d\n",
-                        error);
-                goto err_dbg;
-        }
-        error = ath9k_hif_usb_init();
-        if (error < 0) {
                printk(KERN_ERR
                        "ath9k_htc: No USB devices found,"
                        " driver not installed.\n");
-                error = -ENODEV;
+                return -ENODEV;
-                goto err_usb;
        }
        return 0;
-err_usb:
-        ath9k_htc_debug_remove_root();
-err_dbg:
-        return error;
 }
 module_init(ath9k_htc_init);
 static void __exit ath9k_htc_exit(void)
 {
        ath9k_hif_usb_exit();
-        ath9k_htc_debug_remove_root();
        printk(KERN_INFO "ath9k_htc: Driver unloaded\n");
 }
 module_exit(ath9k_htc_exit);
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
index db8c0c044e9e..5aa104fe7eeb 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
@@ -16,10 +16,6 @@
 #include "htc.h"
-#ifdef CONFIG_ATH9K_HTC_DEBUGFS
-static struct dentry *ath9k_debugfs_root;
-#endif
 /*************/
 /* Utilities */
 /*************/
@@ -197,11 +193,16 @@ void ath9k_htc_reset(struct ath9k_htc_priv *priv)
        ath9k_htc_stop_ani(priv);
        ieee80211_stop_queues(priv->hw);
-        htc_stop(priv->htc);
+        del_timer_sync(&priv->tx.cleanup_timer);
+        ath9k_htc_tx_drain(priv);
        WMI_CMD(WMI_DISABLE_INTR_CMDID);
        WMI_CMD(WMI_DRAIN_TXQ_ALL_CMDID);
        WMI_CMD(WMI_STOP_RECV_CMDID);
+        ath9k_wmi_event_drain(priv);
        caldata = &priv->caldata;
        ret = ath9k_hw_reset(ah, ah->curchan, caldata, false);
        if (ret) {
@@ -225,6 +226,9 @@ void ath9k_htc_reset(struct ath9k_htc_priv *priv)
        ath9k_htc_vif_reconfig(priv);
        ieee80211_wake_queues(priv->hw);
+        mod_timer(&priv->tx.cleanup_timer,
+                  jiffies + msecs_to_jiffies(ATH9K_HTC_TX_CLEANUP_INTERVAL));
        ath9k_htc_ps_restore(priv);
        mutex_unlock(&priv->mutex);
 }
@@ -250,11 +254,16 @@ static int ath9k_htc_set_channel(struct ath9k_htc_priv *priv,
        fastcc = !!(hw->conf.flags & IEEE80211_CONF_OFFCHANNEL);
        ath9k_htc_ps_wakeup(priv);
-        htc_stop(priv->htc);
+        del_timer_sync(&priv->tx.cleanup_timer);
+        ath9k_htc_tx_drain(priv);
        WMI_CMD(WMI_DISABLE_INTR_CMDID);
        WMI_CMD(WMI_DRAIN_TXQ_ALL_CMDID);
        WMI_CMD(WMI_STOP_RECV_CMDID);
+        ath9k_wmi_event_drain(priv);
        ath_dbg(common, ATH_DBG_CONFIG,
                "(%u MHz) -> (%u MHz), HT: %d, HT40: %d fastcc: %d\n",
                priv->ah->curchan->channel,
@@ -263,6 +272,7 @@ static int ath9k_htc_set_channel(struct ath9k_htc_priv *priv,
        if (!fastcc)
                caldata = &priv->caldata;
        ret = ath9k_hw_reset(ah, hchan, caldata, fastcc);
        if (ret) {
                ath_err(common,
@@ -296,6 +306,9 @@ static int ath9k_htc_set_channel(struct ath9k_htc_priv *priv,
            !(hw->conf.flags & IEEE80211_CONF_OFFCHANNEL))
                ath9k_htc_vif_reconfig(priv);
+        mod_timer(&priv->tx.cleanup_timer,
+                  jiffies + msecs_to_jiffies(ATH9K_HTC_TX_CLEANUP_INTERVAL));
 err:
        ath9k_htc_ps_restore(priv);
        return ret;
@@ -319,6 +332,11 @@ static void __ath9k_htc_remove_monitor_interface(struct ath9k_htc_priv *priv)
        memcpy(&hvif.myaddr, common->macaddr, ETH_ALEN);
        hvif.index = priv->mon_vif_idx;
        WMI_CMD_BUF(WMI_VAP_REMOVE_CMDID, &hvif);
+        if (ret) {
+                ath_err(common, "Unable to remove monitor interface at idx: %d\n",
+                        priv->mon_vif_idx);
+        }
        priv->nvifs--;
        priv->vif_slot &= ~(1 << priv->mon_vif_idx);
 }
@@ -349,7 +367,7 @@ static int ath9k_htc_add_monitor_interface(struct ath9k_htc_priv *priv)
        memset(&hvif, 0, sizeof(struct ath9k_htc_target_vif));
        memcpy(&hvif.myaddr, common->macaddr, ETH_ALEN);
-        hvif.opmode = cpu_to_be32(HTC_M_MONITOR);
+        hvif.opmode = HTC_M_MONITOR;
        hvif.index = ffz(priv->vif_slot);
        WMI_CMD_BUF(WMI_VAP_CREATE_CMDID, &hvif);
@@ -382,7 +400,7 @@ static int ath9k_htc_add_monitor_interface(struct ath9k_htc_priv *priv)
        tsta.is_vif_sta = 1;
        tsta.sta_index = sta_idx;
        tsta.vif_index = hvif.index;
-        tsta.maxampdu = 0xffff;
+        tsta.maxampdu = cpu_to_be16(0xffff);
        WMI_CMD_BUF(WMI_NODE_CREATE_CMDID, &tsta);
        if (ret) {
@@ -449,6 +467,7 @@ static int ath9k_htc_add_station(struct ath9k_htc_priv *priv,
        struct ath9k_htc_sta *ista;
        int ret, sta_idx;
        u8 cmd_rsp;
+        u16 maxampdu;
        if (priv->nstations >= ATH9K_HTC_MAX_STA)
                return -ENOBUFS;
@@ -463,9 +482,7 @@ static int ath9k_htc_add_station(struct ath9k_htc_priv *priv,
                ista = (struct ath9k_htc_sta *) sta->drv_priv;
                memcpy(&tsta.macaddr, sta->addr, ETH_ALEN);
                memcpy(&tsta.bssid, common->curbssid, ETH_ALEN);
-                tsta.associd = common->curaid;
                tsta.is_vif_sta = 0;
-                tsta.valid = true;
                ista->index = sta_idx;
        } else {
                memcpy(&tsta.macaddr, vif->addr, ETH_ALEN);
@@ -474,7 +491,15 @@ static int ath9k_htc_add_station(struct ath9k_htc_priv *priv,
        tsta.sta_index = sta_idx;
        tsta.vif_index = avp->index;
-        tsta.maxampdu = 0xffff;
+        if (!sta) {
+                tsta.maxampdu = cpu_to_be16(0xffff);
+        } else {
+                maxampdu = 1 << (IEEE80211_HT_MAX_AMPDU_FACTOR +
+                                 sta->ht_cap.ampdu_factor);
+                tsta.maxampdu = cpu_to_be16(maxampdu);
+        }
        if (sta && sta->ht_cap.ht_supported)
                tsta.flags = cpu_to_be16(ATH_HTC_STA_HT);
@@ -547,7 +572,8 @@ static int ath9k_htc_remove_station(struct ath9k_htc_priv *priv,
        return 0;
 }
-int ath9k_htc_update_cap_target(struct ath9k_htc_priv *priv)
+int ath9k_htc_update_cap_target(struct ath9k_htc_priv *priv,
+                                u8 enable_coex)
 {
        struct ath9k_htc_cap_target tcap;
        int ret;
@@ -555,13 +581,9 @@ int ath9k_htc_update_cap_target(struct ath9k_htc_priv *priv)
        memset(&tcap, 0, sizeof(struct ath9k_htc_cap_target));
-        /* FIXME: Values are hardcoded */
+        tcap.ampdu_limit = cpu_to_be32(0xffff);
-        tcap.flags = 0x240c40;
+        tcap.ampdu_subframes = priv->hw->max_tx_aggregation_subframes;
-        tcap.flags_ext = 0x80601000;
+        tcap.enable_coex = enable_coex;
-        tcap.ampdu_limit = 0xffff0000;
-        tcap.ampdu_subframes = 20;
-        tcap.tx_chainmask_legacy = priv->ah->caps.tx_chainmask;
-        tcap.protmode = 1;
        tcap.tx_chainmask = priv->ah->caps.tx_chainmask;
        WMI_CMD_BUF(WMI_TARGET_IC_UPDATE_CMDID, &tcap);
@@ -709,218 +731,13 @@ static int ath9k_htc_tx_aggr_oper(struct ath9k_htc_priv *priv,
                        (aggr.aggr_enable) ? "Starting" : "Stopping",
                        sta->addr, tid);
-        spin_lock_bh(&priv->tx_lock);
+        spin_lock_bh(&priv->tx.tx_lock);
        ista->tid_state[tid] = (aggr.aggr_enable && !ret) ? AGGR_START : AGGR_STOP;
-        spin_unlock_bh(&priv->tx_lock);
+        spin_unlock_bh(&priv->tx.tx_lock);
        return ret;
 }
-/*********/
-/* DEBUG */
-/*********/
-#ifdef CONFIG_ATH9K_HTC_DEBUGFS
-static int ath9k_debugfs_open(struct inode *inode, struct file *file)
-{
-        file->private_data = inode->i_private;
-        return 0;
-}
-static ssize_t read_file_tgt_stats(struct file *file, char __user *user_buf,
-                                   size_t count, loff_t *ppos)
-{
-        struct ath9k_htc_priv *priv = file->private_data;
-        struct ath9k_htc_target_stats cmd_rsp;
-        char buf[512];
-        unsigned int len = 0;
-        int ret = 0;
-        memset(&cmd_rsp, 0, sizeof(cmd_rsp));
-        WMI_CMD(WMI_TGT_STATS_CMDID);
-        if (ret)
-                return -EINVAL;
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%19s : %10u\n", "TX Short Retries",
-                        be32_to_cpu(cmd_rsp.tx_shortretry));
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%19s : %10u\n", "TX Long Retries",
-                        be32_to_cpu(cmd_rsp.tx_longretry));
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%19s : %10u\n", "TX Xretries",
-                        be32_to_cpu(cmd_rsp.tx_xretries));
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%19s : %10u\n", "TX Unaggr. Xretries",
-                        be32_to_cpu(cmd_rsp.ht_txunaggr_xretry));
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%19s : %10u\n", "TX Xretries (HT)",
-                        be32_to_cpu(cmd_rsp.ht_tx_xretries));
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%19s : %10u\n", "TX Rate", priv->debug.txrate);
-        if (len > sizeof(buf))
-                len = sizeof(buf);
-        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
-}
-static const struct file_operations fops_tgt_stats = {
-        .read = read_file_tgt_stats,
-        .open = ath9k_debugfs_open,
-        .owner = THIS_MODULE,
-        .llseek = default_llseek,
-};
-static ssize_t read_file_xmit(struct file *file, char __user *user_buf,
-                              size_t count, loff_t *ppos)
-{
-        struct ath9k_htc_priv *priv = file->private_data;
-        char buf[512];
-        unsigned int len = 0;
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "Buffers queued",
-                        priv->debug.tx_stats.buf_queued);
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "Buffers completed",
-                        priv->debug.tx_stats.buf_completed);
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "SKBs queued",
-                        priv->debug.tx_stats.skb_queued);
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "SKBs completed",
-                        priv->debug.tx_stats.skb_completed);
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "SKBs dropped",
-                        priv->debug.tx_stats.skb_dropped);
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "BE queued",
-                        priv->debug.tx_stats.queue_stats[WME_AC_BE]);
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "BK queued",
-                        priv->debug.tx_stats.queue_stats[WME_AC_BK]);
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "VI queued",
-                        priv->debug.tx_stats.queue_stats[WME_AC_VI]);
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "VO queued",
-                        priv->debug.tx_stats.queue_stats[WME_AC_VO]);
-        if (len > sizeof(buf))
-                len = sizeof(buf);
-        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
-}
-static const struct file_operations fops_xmit = {
-        .read = read_file_xmit,
-        .open = ath9k_debugfs_open,
-        .owner = THIS_MODULE,
-        .llseek = default_llseek,
-};
-static ssize_t read_file_recv(struct file *file, char __user *user_buf,
-                              size_t count, loff_t *ppos)
-{
-        struct ath9k_htc_priv *priv = file->private_data;
-        char buf[512];
-        unsigned int len = 0;
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "SKBs allocated",
-                        priv->debug.rx_stats.skb_allocated);
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "SKBs completed",
-                        priv->debug.rx_stats.skb_completed);
-        len += snprintf(buf + len, sizeof(buf) - len,
-                        "%20s : %10u\n", "SKBs Dropped",
-                        priv->debug.rx_stats.skb_dropped);
-        if (len > sizeof(buf))
-                len = sizeof(buf);
-        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
-}
-static const struct file_operations fops_recv = {
-        .read = read_file_recv,
-        .open = ath9k_debugfs_open,
-        .owner = THIS_MODULE,
-        .llseek = default_llseek,
-};
-int ath9k_htc_init_debug(struct ath_hw *ah)
-{
-        struct ath_common *common = ath9k_hw_common(ah);
-        struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *) common->priv;
-        if (!ath9k_debugfs_root)
-                return -ENOENT;
-        priv->debug.debugfs_phy = debugfs_create_dir(wiphy_name(priv->hw->wiphy),
-                                                     ath9k_debugfs_root);
-        if (!priv->debug.debugfs_phy)
-                goto err;
-        priv->debug.debugfs_tgt_stats = debugfs_create_file("tgt_stats", S_IRUSR,
-                                                    priv->debug.debugfs_phy,
-                                                    priv, &fops_tgt_stats);
-        if (!priv->debug.debugfs_tgt_stats)
-                goto err;
-        priv->debug.debugfs_xmit = debugfs_create_file("xmit", S_IRUSR,
-                                                       priv->debug.debugfs_phy,
-                                                       priv, &fops_xmit);
-        if (!priv->debug.debugfs_xmit)
-                goto err;
-        priv->debug.debugfs_recv = debugfs_create_file("recv", S_IRUSR,
-                                                       priv->debug.debugfs_phy,
-                                                       priv, &fops_recv);
-        if (!priv->debug.debugfs_recv)
-                goto err;
-        return 0;
-err:
-        ath9k_htc_exit_debug(ah);
-        return -ENOMEM;
-}
-void ath9k_htc_exit_debug(struct ath_hw *ah)
-{
-        struct ath_common *common = ath9k_hw_common(ah);
-        struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *) common->priv;
-        debugfs_remove(priv->debug.debugfs_recv);
-        debugfs_remove(priv->debug.debugfs_xmit);
-        debugfs_remove(priv->debug.debugfs_tgt_stats);
-        debugfs_remove(priv->debug.debugfs_phy);
-}
-int ath9k_htc_debug_create_root(void)
-{
-        ath9k_debugfs_root = debugfs_create_dir(KBUILD_MODNAME, NULL);
-        if (!ath9k_debugfs_root)
-                return -ENOENT;
-        return 0;
-}
-void ath9k_htc_debug_remove_root(void)
-{
-        debugfs_remove(ath9k_debugfs_root);
-        ath9k_debugfs_root = NULL;
-}
-#endif /* CONFIG_ATH9K_HTC_DEBUGFS */
 /*******/
 /* ANI */
 /*******/
@@ -1040,7 +857,8 @@ static void ath9k_htc_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
 {
        struct ieee80211_hdr *hdr;
        struct ath9k_htc_priv *priv = hw->priv;
-        int padpos, padsize, ret;
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        int padpos, padsize, ret, slot;
        hdr = (struct ieee80211_hdr *) skb->data;
@@ -1048,30 +866,32 @@ static void ath9k_htc_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
        padpos = ath9k_cmn_padpos(hdr->frame_control);
        padsize = padpos & 3;
        if (padsize && skb->len > padpos) {
-                if (skb_headroom(skb) < padsize)
+                if (skb_headroom(skb) < padsize) {
+                        ath_dbg(common, ATH_DBG_XMIT, "No room for padding\n");
                        goto fail_tx;
+                }
                skb_push(skb, padsize);
                memmove(skb->data, skb->data + padsize, padpos);
        }
-        ret = ath9k_htc_tx_start(priv, skb);
+        slot = ath9k_htc_tx_get_slot(priv);
-        if (ret != 0) {
+        if (slot < 0) {
-                if (ret == -ENOMEM) {
+                ath_dbg(common, ATH_DBG_XMIT, "No free TX slot\n");
-                        ath_dbg(ath9k_hw_common(priv->ah), ATH_DBG_XMIT,
-                                "Stopping TX queues\n");
-                        ieee80211_stop_queues(hw);
-                        spin_lock_bh(&priv->tx_lock);
-                        priv->tx_queues_stop = true;
-                        spin_unlock_bh(&priv->tx_lock);
-                } else {
-                        ath_dbg(ath9k_hw_common(priv->ah), ATH_DBG_XMIT,
-                                "Tx failed\n");
-                }
                goto fail_tx;
        }
+        ret = ath9k_htc_tx_start(priv, skb, slot, false);
+        if (ret != 0) {
+                ath_dbg(common, ATH_DBG_XMIT, "Tx failed\n");
+                goto clear_slot;
+        }
+        ath9k_htc_check_stop_queues(priv);
        return;
+clear_slot:
+        ath9k_htc_tx_clear_slot(priv, slot);
 fail_tx:
        dev_kfree_skb_any(skb);
 }
@@ -1122,7 +942,7 @@ static int ath9k_htc_start(struct ieee80211_hw *hw)
        ath9k_host_rx_init(priv);
-        ret = ath9k_htc_update_cap_target(priv);
+        ret = ath9k_htc_update_cap_target(priv, 0);
        if (ret)
                ath_dbg(common, ATH_DBG_CONFIG,
                        "Failed to update capability in target\n");
@@ -1130,12 +950,15 @@ static int ath9k_htc_start(struct ieee80211_hw *hw)
        priv->op_flags &= ~OP_INVALID;
        htc_start(priv->htc);
-        spin_lock_bh(&priv->tx_lock);
+        spin_lock_bh(&priv->tx.tx_lock);
-        priv->tx_queues_stop = false;
+        priv->tx.flags &= ~ATH9K_HTC_OP_TX_QUEUES_STOP;
-        spin_unlock_bh(&priv->tx_lock);
+        spin_unlock_bh(&priv->tx.tx_lock);
        ieee80211_wake_queues(hw);
+        mod_timer(&priv->tx.cleanup_timer,
+                  jiffies + msecs_to_jiffies(ATH9K_HTC_TX_CLEANUP_INTERVAL));
        if (ah->btcoex_hw.scheme == ATH_BTCOEX_CFG_3WIRE) {
                ath9k_hw_btcoex_set_weight(ah, AR_BT_COEX_WGHT,
                                           AR_STOMP_LOW_WLAN_WGHT);
@@ -1152,7 +975,7 @@ static void ath9k_htc_stop(struct ieee80211_hw *hw)
        struct ath9k_htc_priv *priv = hw->priv;
        struct ath_hw *ah = priv->ah;
        struct ath_common *common = ath9k_hw_common(ah);
-        int ret = 0;
+        int ret __attribute__ ((unused));
        u8 cmd_rsp;
        mutex_lock(&priv->mutex);
@@ -1164,25 +987,27 @@ static void ath9k_htc_stop(struct ieee80211_hw *hw)
        }
        ath9k_htc_ps_wakeup(priv);
-        htc_stop(priv->htc);
        WMI_CMD(WMI_DISABLE_INTR_CMDID);
        WMI_CMD(WMI_DRAIN_TXQ_ALL_CMDID);
        WMI_CMD(WMI_STOP_RECV_CMDID);
-        tasklet_kill(&priv->swba_tasklet);
        tasklet_kill(&priv->rx_tasklet);
-        tasklet_kill(&priv->tx_tasklet);
-        skb_queue_purge(&priv->tx_queue);
+        del_timer_sync(&priv->tx.cleanup_timer);
+        ath9k_htc_tx_drain(priv);
+        ath9k_wmi_event_drain(priv);
        mutex_unlock(&priv->mutex);
        /* Cancel all the running timers/work .. */
        cancel_work_sync(&priv->fatal_work);
        cancel_work_sync(&priv->ps_work);
-        cancel_delayed_work_sync(&priv->ath9k_led_blink_work);
+#ifdef CONFIG_MAC80211_LEDS
+        cancel_work_sync(&priv->led_work);
+#endif
        ath9k_htc_stop_ani(priv);
-        ath9k_led_stop_brightness(priv);
        mutex_lock(&priv->mutex);
@@ -1245,13 +1070,13 @@ static int ath9k_htc_add_interface(struct ieee80211_hw *hw,
        switch (vif->type) {
        case NL80211_IFTYPE_STATION:
-                hvif.opmode = cpu_to_be32(HTC_M_STA);
+                hvif.opmode = HTC_M_STA;
                break;
        case NL80211_IFTYPE_ADHOC:
-                hvif.opmode = cpu_to_be32(HTC_M_IBSS);
+                hvif.opmode = HTC_M_IBSS;
                break;
        case NL80211_IFTYPE_AP:
-                hvif.opmode = cpu_to_be32(HTC_M_HOSTAP);
+                hvif.opmode = HTC_M_HOSTAP;
                break;
        default:
                ath_err(common,
@@ -1281,14 +1106,20 @@ static int ath9k_htc_add_interface(struct ieee80211_hw *hw,
        priv->vif_slot |= (1 << avp->index);
        priv->nvifs++;
-        priv->vif = vif;
        INC_VIF(priv, vif->type);
+        if ((vif->type == NL80211_IFTYPE_AP) ||
+            (vif->type == NL80211_IFTYPE_ADHOC))
+                ath9k_htc_assign_bslot(priv, vif);
        ath9k_htc_set_opmode(priv);
        if ((priv->ah->opmode == NL80211_IFTYPE_AP) &&
-            !(priv->op_flags & OP_ANI_RUNNING))
+            !(priv->op_flags & OP_ANI_RUNNING)) {
+                ath9k_hw_set_tsfadjust(priv->ah, 1);
                ath9k_htc_start_ani(priv);
+        }
        ath_dbg(common, ATH_DBG_CONFIG,
                "Attach a VIF of type: %d at idx: %d\n", vif->type, avp->index);
@@ -1317,13 +1148,21 @@ static void ath9k_htc_remove_interface(struct ieee80211_hw *hw,
        memcpy(&hvif.myaddr, vif->addr, ETH_ALEN);
        hvif.index = avp->index;
        WMI_CMD_BUF(WMI_VAP_REMOVE_CMDID, &hvif);
+        if (ret) {
+                ath_err(common, "Unable to remove interface at idx: %d\n",
+                        avp->index);
+        }
        priv->nvifs--;
        priv->vif_slot &= ~(1 << avp->index);
        ath9k_htc_remove_station(priv, vif, NULL);
-        priv->vif = NULL;
        DEC_VIF(priv, vif->type);
+        if ((vif->type == NL80211_IFTYPE_AP) ||
+            (vif->type == NL80211_IFTYPE_ADHOC))
+                ath9k_htc_remove_bslot(priv, vif);
        ath9k_htc_set_opmode(priv);
        /*
@@ -1493,10 +1332,13 @@ static int ath9k_htc_sta_remove(struct ieee80211_hw *hw,
                                struct ieee80211_sta *sta)
 {
        struct ath9k_htc_priv *priv = hw->priv;
+        struct ath9k_htc_sta *ista;
        int ret;
        mutex_lock(&priv->mutex);
        ath9k_htc_ps_wakeup(priv);
+        ista = (struct ath9k_htc_sta *) sta->drv_priv;
+        htc_sta_drain(priv->htc, ista->index);
        ret = ath9k_htc_remove_station(priv, vif, sta);
        ath9k_htc_ps_restore(priv);
        mutex_unlock(&priv->mutex);
@@ -1644,6 +1486,7 @@ static void ath9k_htc_bss_info_changed(struct ieee80211_hw *hw,
        if ((changed & BSS_CHANGED_BEACON_ENABLED) && bss_conf->enable_beacon) {
                ath_dbg(common, ATH_DBG_CONFIG,
                        "Beacon enabled for BSS: %pM\n", bss_conf->bssid);
+                ath9k_htc_set_tsfadjust(priv, vif);
                priv->op_flags |= OP_ENABLE_BEACON;
                ath9k_htc_beacon_config(priv, vif);
        }
@@ -1741,6 +1584,7 @@ static int ath9k_htc_ampdu_action(struct ieee80211_hw *hw,
        int ret = 0;
        mutex_lock(&priv->mutex);
+        ath9k_htc_ps_wakeup(priv);
        switch (action) {
        case IEEE80211_AMPDU_RX_START:
@@ -1758,14 +1602,15 @@ static int ath9k_htc_ampdu_action(struct ieee80211_hw *hw,
                break;
        case IEEE80211_AMPDU_TX_OPERATIONAL:
                ista = (struct ath9k_htc_sta *) sta->drv_priv;
-                spin_lock_bh(&priv->tx_lock);
+                spin_lock_bh(&priv->tx.tx_lock);
                ista->tid_state[tid] = AGGR_OPERATIONAL;
-                spin_unlock_bh(&priv->tx_lock);
+                spin_unlock_bh(&priv->tx.tx_lock);
                break;
        default:
                ath_err(ath9k_hw_common(priv->ah), "Unknown AMPDU action\n");
        }
+        ath9k_htc_ps_restore(priv);
        mutex_unlock(&priv->mutex);
        return ret;
@@ -1816,6 +1661,55 @@ static void ath9k_htc_set_coverage_class(struct ieee80211_hw *hw,
        mutex_unlock(&priv->mutex);
 }
+/*
+ * Currently, this is used only for selecting the minimum rate
+ * for management frames, rate selection for data frames remain
+ * unaffected.
+ */
+static int ath9k_htc_set_bitrate_mask(struct ieee80211_hw *hw,
+                                      struct ieee80211_vif *vif,
+                                      const struct cfg80211_bitrate_mask *mask)
+{
+        struct ath9k_htc_priv *priv = hw->priv;
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct ath9k_htc_target_rate_mask tmask;
+        struct ath9k_htc_vif *avp = (void *)vif->drv_priv;
+        int ret = 0;
+        u8 cmd_rsp;
+        memset(&tmask, 0, sizeof(struct ath9k_htc_target_rate_mask));
+        tmask.vif_index = avp->index;
+        tmask.band = IEEE80211_BAND_2GHZ;
+        tmask.mask = cpu_to_be32(mask->control[IEEE80211_BAND_2GHZ].legacy);
+        WMI_CMD_BUF(WMI_BITRATE_MASK_CMDID, &tmask);
+        if (ret) {
+                ath_err(common,
+                        "Unable to set 2G rate mask for "
+                        "interface at idx: %d\n", avp->index);
+                goto out;
+        }
+        tmask.band = IEEE80211_BAND_5GHZ;
+        tmask.mask = cpu_to_be32(mask->control[IEEE80211_BAND_5GHZ].legacy);
+        WMI_CMD_BUF(WMI_BITRATE_MASK_CMDID, &tmask);
+        if (ret) {
+                ath_err(common,
+                        "Unable to set 5G rate mask for "
+                        "interface at idx: %d\n", avp->index);
+                goto out;
+        }
+        ath_dbg(common, ATH_DBG_CONFIG,
+                "Set bitrate masks: 0x%x, 0x%x\n",
+                mask->control[IEEE80211_BAND_2GHZ].legacy,
+                mask->control[IEEE80211_BAND_5GHZ].legacy);
+out:
+        return ret;
+}
 struct ieee80211_ops ath9k_htc_ops = {
        .tx                 = ath9k_htc_tx,
        .start              = ath9k_htc_start,
@@ -1838,4 +1732,5 @@ struct ieee80211_ops ath9k_htc_ops = {
        .set_rts_threshold  = ath9k_htc_set_rts_threshold,
        .rfkill_poll        = ath9k_htc_rfkill_poll_state,
        .set_coverage_class = ath9k_htc_set_coverage_class,
+        .set_bitrate_mask   = ath9k_htc_set_bitrate_mask,
 };
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
index 4a4f27ba96af..a898dac22337 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
@@ -53,6 +53,138 @@ int get_hw_qnum(u16 queue, int *hwq_map)
        }
 }
+void ath9k_htc_check_stop_queues(struct ath9k_htc_priv *priv)
+{
+        spin_lock_bh(&priv->tx.tx_lock);
+        priv->tx.queued_cnt++;
+        if ((priv->tx.queued_cnt >= ATH9K_HTC_TX_THRESHOLD) &&
+            !(priv->tx.flags & ATH9K_HTC_OP_TX_QUEUES_STOP)) {
+                priv->tx.flags |= ATH9K_HTC_OP_TX_QUEUES_STOP;
+                ieee80211_stop_queues(priv->hw);
+        }
+        spin_unlock_bh(&priv->tx.tx_lock);
+}
+void ath9k_htc_check_wake_queues(struct ath9k_htc_priv *priv)
+{
+        spin_lock_bh(&priv->tx.tx_lock);
+        if ((priv->tx.queued_cnt < ATH9K_HTC_TX_THRESHOLD) &&
+            (priv->tx.flags & ATH9K_HTC_OP_TX_QUEUES_STOP)) {
+                priv->tx.flags &= ~ATH9K_HTC_OP_TX_QUEUES_STOP;
+                ieee80211_wake_queues(priv->hw);
+        }
+        spin_unlock_bh(&priv->tx.tx_lock);
+}
+int ath9k_htc_tx_get_slot(struct ath9k_htc_priv *priv)
+{
+        int slot;
+        spin_lock_bh(&priv->tx.tx_lock);
+        slot = find_first_zero_bit(priv->tx.tx_slot, MAX_TX_BUF_NUM);
+        if (slot >= MAX_TX_BUF_NUM) {
+                spin_unlock_bh(&priv->tx.tx_lock);
+                return -ENOBUFS;
+        }
+        __set_bit(slot, priv->tx.tx_slot);
+        spin_unlock_bh(&priv->tx.tx_lock);
+        return slot;
+}
+void ath9k_htc_tx_clear_slot(struct ath9k_htc_priv *priv, int slot)
+{
+        spin_lock_bh(&priv->tx.tx_lock);
+        __clear_bit(slot, priv->tx.tx_slot);
+        spin_unlock_bh(&priv->tx.tx_lock);
+}
+static inline enum htc_endpoint_id get_htc_epid(struct ath9k_htc_priv *priv,
+                                                u16 qnum)
+{
+        enum htc_endpoint_id epid;
+        switch (qnum) {
+        case 0:
+                TX_QSTAT_INC(WME_AC_VO);
+                epid = priv->data_vo_ep;
+                break;
+        case 1:
+                TX_QSTAT_INC(WME_AC_VI);
+                epid = priv->data_vi_ep;
+                break;
+        case 2:
+                TX_QSTAT_INC(WME_AC_BE);
+                epid = priv->data_be_ep;
+                break;
+        case 3:
+        default:
+                TX_QSTAT_INC(WME_AC_BK);
+                epid = priv->data_bk_ep;
+                break;
+        }
+        return epid;
+}
+static inline struct sk_buff_head*
+get_htc_epid_queue(struct ath9k_htc_priv *priv, u8 epid)
+{
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct sk_buff_head *epid_queue = NULL;
+        if (epid == priv->mgmt_ep)
+                epid_queue = &priv->tx.mgmt_ep_queue;
+        else if (epid == priv->cab_ep)
+                epid_queue = &priv->tx.cab_ep_queue;
+        else if (epid == priv->data_be_ep)
+                epid_queue = &priv->tx.data_be_queue;
+        else if (epid == priv->data_bk_ep)
+                epid_queue = &priv->tx.data_bk_queue;
+        else if (epid == priv->data_vi_ep)
+                epid_queue = &priv->tx.data_vi_queue;
+        else if (epid == priv->data_vo_ep)
+                epid_queue = &priv->tx.data_vo_queue;
+        else
+                ath_err(common, "Invalid EPID: %d\n", epid);
+        return epid_queue;
+}
+/*
+ * Removes the driver header and returns the TX slot number
+ */
+static inline int strip_drv_header(struct ath9k_htc_priv *priv,
+                                   struct sk_buff *skb)
+{
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct ath9k_htc_tx_ctl *tx_ctl;
+        int slot;
+        tx_ctl = HTC_SKB_CB(skb);
+        if (tx_ctl->epid == priv->mgmt_ep) {
+                struct tx_mgmt_hdr *tx_mhdr =
+                        (struct tx_mgmt_hdr *)skb->data;
+                slot = tx_mhdr->cookie;
+                skb_pull(skb, sizeof(struct tx_mgmt_hdr));
+        } else if ((tx_ctl->epid == priv->data_bk_ep) ||
+                   (tx_ctl->epid == priv->data_be_ep) ||
+                   (tx_ctl->epid == priv->data_vi_ep) ||
+                   (tx_ctl->epid == priv->data_vo_ep) ||
+                   (tx_ctl->epid == priv->cab_ep)) {
+                struct tx_frame_hdr *tx_fhdr =
+                        (struct tx_frame_hdr *)skb->data;
+                slot = tx_fhdr->cookie;
+                skb_pull(skb, sizeof(struct tx_frame_hdr));
+        } else {
+                ath_err(common, "Unsupported EPID: %d\n", tx_ctl->epid);
+                slot = -EINVAL;
+        }
+        return slot;
+}
 int ath_htc_txq_update(struct ath9k_htc_priv *priv, int qnum,
                       struct ath9k_tx_queue_info *qinfo)
 {
@@ -79,23 +211,140 @@ int ath_htc_txq_update(struct ath9k_htc_priv *priv, int qnum,
        return error;
 }
-int ath9k_htc_tx_start(struct ath9k_htc_priv *priv, struct sk_buff *skb)
+static void ath9k_htc_tx_mgmt(struct ath9k_htc_priv *priv,
+                              struct ath9k_htc_vif *avp,
+                              struct sk_buff *skb,
+                              u8 sta_idx, u8 vif_idx, u8 slot)
+{
+        struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
+        struct ieee80211_mgmt *mgmt;
+        struct ieee80211_hdr *hdr;
+        struct tx_mgmt_hdr mgmt_hdr;
+        struct ath9k_htc_tx_ctl *tx_ctl;
+        u8 *tx_fhdr;
+        tx_ctl = HTC_SKB_CB(skb);
+        hdr = (struct ieee80211_hdr *) skb->data;
+        memset(tx_ctl, 0, sizeof(*tx_ctl));
+        memset(&mgmt_hdr, 0, sizeof(struct tx_mgmt_hdr));
+        /*
+         * Set the TSF adjust value for probe response
+         * frame also.
+         */
+        if (avp && unlikely(ieee80211_is_probe_resp(hdr->frame_control))) {
+                mgmt = (struct ieee80211_mgmt *)skb->data;
+                mgmt->u.probe_resp.timestamp = avp->tsfadjust;
+        }
+        tx_ctl->type = ATH9K_HTC_MGMT;
+        mgmt_hdr.node_idx = sta_idx;
+        mgmt_hdr.vif_idx = vif_idx;
+        mgmt_hdr.tidno = 0;
+        mgmt_hdr.flags = 0;
+        mgmt_hdr.cookie = slot;
+        mgmt_hdr.key_type = ath9k_cmn_get_hw_crypto_keytype(skb);
+        if (mgmt_hdr.key_type == ATH9K_KEY_TYPE_CLEAR)
+                mgmt_hdr.keyix = (u8) ATH9K_TXKEYIX_INVALID;
+        else
+                mgmt_hdr.keyix = tx_info->control.hw_key->hw_key_idx;
+        tx_fhdr = skb_push(skb, sizeof(mgmt_hdr));
+        memcpy(tx_fhdr, (u8 *) &mgmt_hdr, sizeof(mgmt_hdr));
+        tx_ctl->epid = priv->mgmt_ep;
+}
+static void ath9k_htc_tx_data(struct ath9k_htc_priv *priv,
+                              struct ieee80211_vif *vif,
+                              struct sk_buff *skb,
+                              u8 sta_idx, u8 vif_idx, u8 slot,
+                              bool is_cab)
+{
+        struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
+        struct ieee80211_hdr *hdr;
+        struct ath9k_htc_tx_ctl *tx_ctl;
+        struct tx_frame_hdr tx_hdr;
+        u32 flags = 0;
+        u8 *qc, *tx_fhdr;
+        u16 qnum;
+        tx_ctl = HTC_SKB_CB(skb);
+        hdr = (struct ieee80211_hdr *) skb->data;
+        memset(tx_ctl, 0, sizeof(*tx_ctl));
+        memset(&tx_hdr, 0, sizeof(struct tx_frame_hdr));
+        tx_hdr.node_idx = sta_idx;
+        tx_hdr.vif_idx = vif_idx;
+        tx_hdr.cookie = slot;
+        /*
+         * This is a bit redundant but it helps to get
+         * the per-packet index quickly when draining the
+         * TX queue in the HIF layer. Otherwise we would
+         * have to parse the packet contents ...
+         */
+        tx_ctl->sta_idx = sta_idx;
+        if (tx_info->flags & IEEE80211_TX_CTL_AMPDU) {
+                tx_ctl->type = ATH9K_HTC_AMPDU;
+                tx_hdr.data_type = ATH9K_HTC_AMPDU;
+        } else {
+                tx_ctl->type = ATH9K_HTC_NORMAL;
+                tx_hdr.data_type = ATH9K_HTC_NORMAL;
+        }
+        if (ieee80211_is_data_qos(hdr->frame_control)) {
+                qc = ieee80211_get_qos_ctl(hdr);
+                tx_hdr.tidno = qc[0] & IEEE80211_QOS_CTL_TID_MASK;
+        }
+        /* Check for RTS protection */
+        if (priv->hw->wiphy->rts_threshold != (u32) -1)
+                if (skb->len > priv->hw->wiphy->rts_threshold)
+                        flags |= ATH9K_HTC_TX_RTSCTS;
+        /* CTS-to-self */
+        if (!(flags & ATH9K_HTC_TX_RTSCTS) &&
+            (vif && vif->bss_conf.use_cts_prot))
+                flags |= ATH9K_HTC_TX_CTSONLY;
+        tx_hdr.flags = cpu_to_be32(flags);
+        tx_hdr.key_type = ath9k_cmn_get_hw_crypto_keytype(skb);
+        if (tx_hdr.key_type == ATH9K_KEY_TYPE_CLEAR)
+                tx_hdr.keyix = (u8) ATH9K_TXKEYIX_INVALID;
+        else
+                tx_hdr.keyix = tx_info->control.hw_key->hw_key_idx;
+        tx_fhdr = skb_push(skb, sizeof(tx_hdr));
+        memcpy(tx_fhdr, (u8 *) &tx_hdr, sizeof(tx_hdr));
+        if (is_cab) {
+                CAB_STAT_INC;
+                tx_ctl->epid = priv->cab_ep;
+                return;
+        }
+        qnum = skb_get_queue_mapping(skb);
+        tx_ctl->epid = get_htc_epid(priv, qnum);
+}
+int ath9k_htc_tx_start(struct ath9k_htc_priv *priv,
+                       struct sk_buff *skb,
+                       u8 slot, bool is_cab)
 {
        struct ieee80211_hdr *hdr;
        struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
        struct ieee80211_sta *sta = tx_info->control.sta;
        struct ieee80211_vif *vif = tx_info->control.vif;
        struct ath9k_htc_sta *ista;
-        struct ath9k_htc_vif *avp;
+        struct ath9k_htc_vif *avp = NULL;
-        struct ath9k_htc_tx_ctl tx_ctl;
-        enum htc_endpoint_id epid;
-        u16 qnum;
-        __le16 fc;
-        u8 *tx_fhdr;
        u8 sta_idx, vif_idx;
        hdr = (struct ieee80211_hdr *) skb->data;
-        fc = hdr->frame_control;
        /*
         * Find out on which interface this packet has to be
@@ -124,218 +373,430 @@ int ath9k_htc_tx_start(struct ath9k_htc_priv *priv, struct sk_buff *skb)
                sta_idx = priv->vif_sta_pos[vif_idx];
        }
-        memset(&tx_ctl, 0, sizeof(struct ath9k_htc_tx_ctl));
+        if (ieee80211_is_data(hdr->frame_control))
+                ath9k_htc_tx_data(priv, vif, skb,
+                                  sta_idx, vif_idx, slot, is_cab);
+        else
+                ath9k_htc_tx_mgmt(priv, avp, skb,
+                                  sta_idx, vif_idx, slot);
-        if (ieee80211_is_data(fc)) {
-                struct tx_frame_hdr tx_hdr;
-                u32 flags = 0;
-                u8 *qc;
-                memset(&tx_hdr, 0, sizeof(struct tx_frame_hdr));
+        return htc_send(priv->htc, skb);
+}
-                tx_hdr.node_idx = sta_idx;
+static inline bool __ath9k_htc_check_tx_aggr(struct ath9k_htc_priv *priv,
-                tx_hdr.vif_idx = vif_idx;
+                                             struct ath9k_htc_sta *ista, u8 tid)
+{
+        bool ret = false;
-                if (tx_info->flags & IEEE80211_TX_CTL_AMPDU) {
+        spin_lock_bh(&priv->tx.tx_lock);
-                        tx_ctl.type = ATH9K_HTC_AMPDU;
+        if ((tid < ATH9K_HTC_MAX_TID) && (ista->tid_state[tid] == AGGR_STOP))
-                        tx_hdr.data_type = ATH9K_HTC_AMPDU;
+                ret = true;
-                } else {
+        spin_unlock_bh(&priv->tx.tx_lock);
-                        tx_ctl.type = ATH9K_HTC_NORMAL;
-                        tx_hdr.data_type = ATH9K_HTC_NORMAL;
+        return ret;
-                }
+}
+static void ath9k_htc_check_tx_aggr(struct ath9k_htc_priv *priv,
+                                    struct ieee80211_vif *vif,
+                                    struct sk_buff *skb)
+{
+        struct ieee80211_sta *sta;
+        struct ieee80211_hdr *hdr;
+        __le16 fc;
+        hdr = (struct ieee80211_hdr *) skb->data;
+        fc = hdr->frame_control;
+        rcu_read_lock();
+        sta = ieee80211_find_sta(vif, hdr->addr1);
+        if (!sta) {
+                rcu_read_unlock();
+                return;
+        }
+        if (sta && conf_is_ht(&priv->hw->conf) &&
+            !(skb->protocol == cpu_to_be16(ETH_P_PAE))) {
                if (ieee80211_is_data_qos(fc)) {
+                        u8 *qc, tid;
+                        struct ath9k_htc_sta *ista;
                        qc = ieee80211_get_qos_ctl(hdr);
-                        tx_hdr.tidno = qc[0] & IEEE80211_QOS_CTL_TID_MASK;
+                        tid = qc[0] & 0xf;
+                        ista = (struct ath9k_htc_sta *)sta->drv_priv;
+                        if (__ath9k_htc_check_tx_aggr(priv, ista, tid)) {
+                                ieee80211_start_tx_ba_session(sta, tid, 0);
+                                spin_lock_bh(&priv->tx.tx_lock);
+                                ista->tid_state[tid] = AGGR_PROGRESS;
+                                spin_unlock_bh(&priv->tx.tx_lock);
+                        }
                }
+        }
-                /* Check for RTS protection */
+        rcu_read_unlock();
-                if (priv->hw->wiphy->rts_threshold != (u32) -1)
+}
-                        if (skb->len > priv->hw->wiphy->rts_threshold)
-                                flags |= ATH9K_HTC_TX_RTSCTS;
-                /* CTS-to-self */
+static void ath9k_htc_tx_process(struct ath9k_htc_priv *priv,
-                if (!(flags & ATH9K_HTC_TX_RTSCTS) &&
+                                 struct sk_buff *skb,
-                    (vif && vif->bss_conf.use_cts_prot))
+                                 struct __wmi_event_txstatus *txs)
-                        flags |= ATH9K_HTC_TX_CTSONLY;
+{
+        struct ieee80211_vif *vif;
+        struct ath9k_htc_tx_ctl *tx_ctl;
+        struct ieee80211_tx_info *tx_info;
+        struct ieee80211_tx_rate *rate;
+        struct ieee80211_conf *cur_conf = &priv->hw->conf;
+        bool txok;
+        int slot;
-                tx_hdr.flags = cpu_to_be32(flags);
+        slot = strip_drv_header(priv, skb);
-                tx_hdr.key_type = ath9k_cmn_get_hw_crypto_keytype(skb);
+        if (slot < 0) {
-                if (tx_hdr.key_type == ATH9K_KEY_TYPE_CLEAR)
+                dev_kfree_skb_any(skb);
-                        tx_hdr.keyix = (u8) ATH9K_TXKEYIX_INVALID;
+                return;
-                else
+        }
-                        tx_hdr.keyix = tx_info->control.hw_key->hw_key_idx;
-                tx_fhdr = skb_push(skb, sizeof(tx_hdr));
+        tx_ctl = HTC_SKB_CB(skb);
-                memcpy(tx_fhdr, (u8 *) &tx_hdr, sizeof(tx_hdr));
+        txok = tx_ctl->txok;
+        tx_info = IEEE80211_SKB_CB(skb);
+        vif = tx_info->control.vif;
+        rate = &tx_info->status.rates[0];
-                qnum = skb_get_queue_mapping(skb);
+        memset(&tx_info->status, 0, sizeof(tx_info->status));
-                switch (qnum) {
+        /*
-                case 0:
+         * URB submission failed for this frame, it never reached
-                        TX_QSTAT_INC(WME_AC_VO);
+         * the target.
-                        epid = priv->data_vo_ep;
+         */
-                        break;
+        if (!txok || !vif || !txs)
-                case 1:
+                goto send_mac80211;
-                        TX_QSTAT_INC(WME_AC_VI);
-                        epid = priv->data_vi_ep;
+        if (txs->ts_flags & ATH9K_HTC_TXSTAT_ACK)
-                        break;
+                tx_info->flags |= IEEE80211_TX_STAT_ACK;
-                case 2:
-                        TX_QSTAT_INC(WME_AC_BE);
-                        epid = priv->data_be_ep;
-                        break;
-                case 3:
-                default:
-                        TX_QSTAT_INC(WME_AC_BK);
-                        epid = priv->data_bk_ep;
-                        break;
-                }
-        } else {
-                struct tx_mgmt_hdr mgmt_hdr;
-                memset(&mgmt_hdr, 0, sizeof(struct tx_mgmt_hdr));
+        if (txs->ts_flags & ATH9K_HTC_TXSTAT_FILT)
+                tx_info->flags |= IEEE80211_TX_STAT_TX_FILTERED;
-                tx_ctl.type = ATH9K_HTC_NORMAL;
+        if (txs->ts_flags & ATH9K_HTC_TXSTAT_RTC_CTS)
+                rate->flags |= IEEE80211_TX_RC_USE_RTS_CTS;
-                mgmt_hdr.node_idx = sta_idx;
+        rate->count = 1;
-                mgmt_hdr.vif_idx = vif_idx;
+        rate->idx = MS(txs->ts_rate, ATH9K_HTC_TXSTAT_RATE);
-                mgmt_hdr.tidno = 0;
-                mgmt_hdr.flags = 0;
-                mgmt_hdr.key_type = ath9k_cmn_get_hw_crypto_keytype(skb);
+        if (txs->ts_flags & ATH9K_HTC_TXSTAT_MCS) {
-                if (mgmt_hdr.key_type == ATH9K_KEY_TYPE_CLEAR)
+                rate->flags |= IEEE80211_TX_RC_MCS;
-                        mgmt_hdr.keyix = (u8) ATH9K_TXKEYIX_INVALID;
-                else
-                        mgmt_hdr.keyix = tx_info->control.hw_key->hw_key_idx;
-                tx_fhdr = skb_push(skb, sizeof(mgmt_hdr));
+                if (txs->ts_flags & ATH9K_HTC_TXSTAT_CW40)
-                memcpy(tx_fhdr, (u8 *) &mgmt_hdr, sizeof(mgmt_hdr));
+                        rate->flags |= IEEE80211_TX_RC_40_MHZ_WIDTH;
-                epid = priv->mgmt_ep;
+                if (txs->ts_flags & ATH9K_HTC_TXSTAT_SGI)
+                        rate->flags |= IEEE80211_TX_RC_SHORT_GI;
+        } else {
+                if (cur_conf->channel->band == IEEE80211_BAND_5GHZ)
+                        rate->idx += 4; /* No CCK rates */
        }
-        return htc_send(priv->htc, skb, epid, &tx_ctl);
+        ath9k_htc_check_tx_aggr(priv, vif, skb);
+send_mac80211:
+        spin_lock_bh(&priv->tx.tx_lock);
+        if (WARN_ON(--priv->tx.queued_cnt < 0))
+                priv->tx.queued_cnt = 0;
+        spin_unlock_bh(&priv->tx.tx_lock);
+        ath9k_htc_tx_clear_slot(priv, slot);
+        /* Send status to mac80211 */
+        ieee80211_tx_status(priv->hw, skb);
 }
-static bool ath9k_htc_check_tx_aggr(struct ath9k_htc_priv *priv,
+static inline void ath9k_htc_tx_drainq(struct ath9k_htc_priv *priv,
-                                    struct ath9k_htc_sta *ista, u8 tid)
+                                       struct sk_buff_head *queue)
 {
-        bool ret = false;
+        struct sk_buff *skb;
-        spin_lock_bh(&priv->tx_lock);
+        while ((skb = skb_dequeue(queue)) != NULL) {
-        if ((tid < ATH9K_HTC_MAX_TID) && (ista->tid_state[tid] == AGGR_STOP))
+                ath9k_htc_tx_process(priv, skb, NULL);
-                ret = true;
+        }
-        spin_unlock_bh(&priv->tx_lock);
+}
-        return ret;
+void ath9k_htc_tx_drain(struct ath9k_htc_priv *priv)
+{
+        struct ath9k_htc_tx_event *event, *tmp;
+        spin_lock_bh(&priv->tx.tx_lock);
+        priv->tx.flags |= ATH9K_HTC_OP_TX_DRAIN;
+        spin_unlock_bh(&priv->tx.tx_lock);
+        /*
+         * Ensure that all pending TX frames are flushed,
+         * and that the TX completion/failed tasklets is killed.
+         */
+        htc_stop(priv->htc);
+        tasklet_kill(&priv->wmi->wmi_event_tasklet);
+        tasklet_kill(&priv->tx_failed_tasklet);
+        ath9k_htc_tx_drainq(priv, &priv->tx.mgmt_ep_queue);
+        ath9k_htc_tx_drainq(priv, &priv->tx.cab_ep_queue);
+        ath9k_htc_tx_drainq(priv, &priv->tx.data_be_queue);
+        ath9k_htc_tx_drainq(priv, &priv->tx.data_bk_queue);
+        ath9k_htc_tx_drainq(priv, &priv->tx.data_vi_queue);
+        ath9k_htc_tx_drainq(priv, &priv->tx.data_vo_queue);
+        ath9k_htc_tx_drainq(priv, &priv->tx.tx_failed);
+        /*
+         * The TX cleanup timer has already been killed.
+         */
+        spin_lock_bh(&priv->wmi->event_lock);
+        list_for_each_entry_safe(event, tmp, &priv->wmi->pending_tx_events, list) {
+                list_del(&event->list);
+                kfree(event);
+        }
+        spin_unlock_bh(&priv->wmi->event_lock);
+        spin_lock_bh(&priv->tx.tx_lock);
+        priv->tx.flags &= ~ATH9K_HTC_OP_TX_DRAIN;
+        spin_unlock_bh(&priv->tx.tx_lock);
 }
-void ath9k_tx_tasklet(unsigned long data)
+void ath9k_tx_failed_tasklet(unsigned long data)
 {
        struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *)data;
-        struct ieee80211_vif *vif;
-        struct ieee80211_sta *sta;
-        struct ieee80211_hdr *hdr;
-        struct ieee80211_tx_info *tx_info;
-        struct sk_buff *skb = NULL;
-        __le16 fc;
-        while ((skb = skb_dequeue(&priv->tx_queue)) != NULL) {
+        spin_lock_bh(&priv->tx.tx_lock);
+        if (priv->tx.flags & ATH9K_HTC_OP_TX_DRAIN) {
+                spin_unlock_bh(&priv->tx.tx_lock);
+                return;
+        }
+        spin_unlock_bh(&priv->tx.tx_lock);
-                hdr = (struct ieee80211_hdr *) skb->data;
+        ath9k_htc_tx_drainq(priv, &priv->tx.tx_failed);
-                fc = hdr->frame_control;
+}
-                tx_info = IEEE80211_SKB_CB(skb);
-                vif = tx_info->control.vif;
-                memset(&tx_info->status, 0, sizeof(tx_info->status));
+static inline bool check_cookie(struct ath9k_htc_priv *priv,
+                                struct sk_buff *skb,
+                                u8 cookie, u8 epid)
+{
+        u8 fcookie = 0;
+        if (epid == priv->mgmt_ep) {
+                struct tx_mgmt_hdr *hdr;
+                hdr = (struct tx_mgmt_hdr *) skb->data;
+                fcookie = hdr->cookie;
+        } else if ((epid == priv->data_bk_ep) ||
+                   (epid == priv->data_be_ep) ||
+                   (epid == priv->data_vi_ep) ||
+                   (epid == priv->data_vo_ep) ||
+                   (epid == priv->cab_ep)) {
+                struct tx_frame_hdr *hdr;
+                hdr = (struct tx_frame_hdr *) skb->data;
+                fcookie = hdr->cookie;
+        }
-                if (!vif)
+        if (fcookie == cookie)
-                        goto send_mac80211;
+                return true;
-                rcu_read_lock();
+        return false;
+}
-                sta = ieee80211_find_sta(vif, hdr->addr1);
+static struct sk_buff* ath9k_htc_tx_get_packet(struct ath9k_htc_priv *priv,
-                if (!sta) {
+                                               struct __wmi_event_txstatus *txs)
-                        rcu_read_unlock();
+{
-                        ieee80211_tx_status(priv->hw, skb);
+        struct ath_common *common = ath9k_hw_common(priv->ah);
-                        continue;
+        struct sk_buff_head *epid_queue;
+        struct sk_buff *skb, *tmp;
+        unsigned long flags;
+        u8 epid = MS(txs->ts_rate, ATH9K_HTC_TXSTAT_EPID);
+        epid_queue = get_htc_epid_queue(priv, epid);
+        if (!epid_queue)
+                return NULL;
+        spin_lock_irqsave(&epid_queue->lock, flags);
+        skb_queue_walk_safe(epid_queue, skb, tmp) {
+                if (check_cookie(priv, skb, txs->cookie, epid)) {
+                        __skb_unlink(skb, epid_queue);
+                        spin_unlock_irqrestore(&epid_queue->lock, flags);
+                        return skb;
                }
+        }
+        spin_unlock_irqrestore(&epid_queue->lock, flags);
+        ath_dbg(common, ATH_DBG_XMIT,
+                "No matching packet for cookie: %d, epid: %d\n",
+                txs->cookie, epid);
-                /* Check if we need to start aggregation */
+        return NULL;
+}
-                if (sta && conf_is_ht(&priv->hw->conf) &&
+void ath9k_htc_txstatus(struct ath9k_htc_priv *priv, void *wmi_event)
-                    !(skb->protocol == cpu_to_be16(ETH_P_PAE))) {
+{
-                        if (ieee80211_is_data_qos(fc)) {
+        struct wmi_event_txstatus *txs = (struct wmi_event_txstatus *)wmi_event;
-                                u8 *qc, tid;
+        struct __wmi_event_txstatus *__txs;
-                                struct ath9k_htc_sta *ista;
+        struct sk_buff *skb;
+        struct ath9k_htc_tx_event *tx_pend;
+        int i;
-                                qc = ieee80211_get_qos_ctl(hdr);
+        for (i = 0; i < txs->cnt; i++) {
-                                tid = qc[0] & 0xf;
+                WARN_ON(txs->cnt > HTC_MAX_TX_STATUS);
-                                ista = (struct ath9k_htc_sta *)sta->drv_priv;
-                                if (ath9k_htc_check_tx_aggr(priv, ista, tid)) {
+                __txs = &txs->txstatus[i];
-                                        ieee80211_start_tx_ba_session(sta, tid, 0);
-                                        spin_lock_bh(&priv->tx_lock);
-                                        ista->tid_state[tid] = AGGR_PROGRESS;
-                                        spin_unlock_bh(&priv->tx_lock);
-                                }
-                        }
-                }
-                rcu_read_unlock();
+                skb = ath9k_htc_tx_get_packet(priv, __txs);
+                if (!skb) {
+                        /*
+                         * Store this event, so that the TX cleanup
+                         * routine can check later for the needed packet.
+                         */
+                        tx_pend = kzalloc(sizeof(struct ath9k_htc_tx_event),
+                                          GFP_ATOMIC);
+                        if (!tx_pend)
+                                continue;
+                        memcpy(&tx_pend->txs, __txs,
+                               sizeof(struct __wmi_event_txstatus));
+                        spin_lock(&priv->wmi->event_lock);
+                        list_add_tail(&tx_pend->list,
+                                      &priv->wmi->pending_tx_events);
+                        spin_unlock(&priv->wmi->event_lock);
-        send_mac80211:
+                        continue;
-                /* Send status to mac80211 */
+                }
-                ieee80211_tx_status(priv->hw, skb);
+                ath9k_htc_tx_process(priv, skb, __txs);
        }
        /* Wake TX queues if needed */
-        spin_lock_bh(&priv->tx_lock);
+        ath9k_htc_check_wake_queues(priv);
-        if (priv->tx_queues_stop) {
-                priv->tx_queues_stop = false;
-                spin_unlock_bh(&priv->tx_lock);
-                ath_dbg(ath9k_hw_common(priv->ah), ATH_DBG_XMIT,
-                        "Waking up TX queues\n");
-                ieee80211_wake_queues(priv->hw);
-                return;
-        }
-        spin_unlock_bh(&priv->tx_lock);
 }
 void ath9k_htc_txep(void *drv_priv, struct sk_buff *skb,
                    enum htc_endpoint_id ep_id, bool txok)
 {
        struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *) drv_priv;
-        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct ath9k_htc_tx_ctl *tx_ctl;
-        struct ieee80211_tx_info *tx_info;
+        struct sk_buff_head *epid_queue;
-        if (!skb)
+        tx_ctl = HTC_SKB_CB(skb);
+        tx_ctl->txok = txok;
+        tx_ctl->timestamp = jiffies;
+        if (!txok) {
+                skb_queue_tail(&priv->tx.tx_failed, skb);
+                tasklet_schedule(&priv->tx_failed_tasklet);
                return;
+        }
-        if (ep_id == priv->mgmt_ep) {
+        epid_queue = get_htc_epid_queue(priv, ep_id);
-                skb_pull(skb, sizeof(struct tx_mgmt_hdr));
+        if (!epid_queue) {
-        } else if ((ep_id == priv->data_bk_ep) ||
-                   (ep_id == priv->data_be_ep) ||
-                   (ep_id == priv->data_vi_ep) ||
-                   (ep_id == priv->data_vo_ep)) {
-                skb_pull(skb, sizeof(struct tx_frame_hdr));
-        } else {
-                ath_err(common, "Unsupported TX EPID: %d\n", ep_id);
                dev_kfree_skb_any(skb);
                return;
        }
-        tx_info = IEEE80211_SKB_CB(skb);
+        skb_queue_tail(epid_queue, skb);
+}
-        if (txok)
+static inline bool check_packet(struct ath9k_htc_priv *priv, struct sk_buff *skb)
-                tx_info->flags |= IEEE80211_TX_STAT_ACK;
+{
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct ath9k_htc_tx_ctl *tx_ctl;
-        skb_queue_tail(&priv->tx_queue, skb);
+        tx_ctl = HTC_SKB_CB(skb);
-        tasklet_schedule(&priv->tx_tasklet);
+        if (time_after(jiffies,
+                       tx_ctl->timestamp +
+                       msecs_to_jiffies(ATH9K_HTC_TX_TIMEOUT_INTERVAL))) {
+                ath_dbg(common, ATH_DBG_XMIT,
+                        "Dropping a packet due to TX timeout\n");
+                return true;
+        }
+        return false;
+}
+static void ath9k_htc_tx_cleanup_queue(struct ath9k_htc_priv *priv,
+                                       struct sk_buff_head *epid_queue)
+{
+        bool process = false;
+        unsigned long flags;
+        struct sk_buff *skb, *tmp;
+        struct sk_buff_head queue;
+        skb_queue_head_init(&queue);
+        spin_lock_irqsave(&epid_queue->lock, flags);
+        skb_queue_walk_safe(epid_queue, skb, tmp) {
+                if (check_packet(priv, skb)) {
+                        __skb_unlink(skb, epid_queue);
+                        __skb_queue_tail(&queue, skb);
+                        process = true;
+                }
+        }
+        spin_unlock_irqrestore(&epid_queue->lock, flags);
+        if (process) {
+                skb_queue_walk_safe(&queue, skb, tmp) {
+                        __skb_unlink(skb, &queue);
+                        ath9k_htc_tx_process(priv, skb, NULL);
+                }
+        }
+}
+void ath9k_htc_tx_cleanup_timer(unsigned long data)
+{
+        struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *) data;
+        struct ath_common *common = ath9k_hw_common(priv->ah);
+        struct ath9k_htc_tx_event *event, *tmp;
+        struct sk_buff *skb;
+        spin_lock(&priv->wmi->event_lock);
+        list_for_each_entry_safe(event, tmp, &priv->wmi->pending_tx_events, list) {
+                skb = ath9k_htc_tx_get_packet(priv, &event->txs);
+                if (skb) {
+                        ath_dbg(common, ATH_DBG_XMIT,
+                                "Found packet for cookie: %d, epid: %d\n",
+                                event->txs.cookie,
+                                MS(event->txs.ts_rate, ATH9K_HTC_TXSTAT_EPID));
+                        ath9k_htc_tx_process(priv, skb, &event->txs);
+                        list_del(&event->list);
+                        kfree(event);
+                        continue;
+                }
+                if (++event->count >= ATH9K_HTC_TX_TIMEOUT_COUNT) {
+                        list_del(&event->list);
+                        kfree(event);
+                }
+        }
+        spin_unlock(&priv->wmi->event_lock);
+        /*
+         * Check if status-pending packets have to be cleaned up.
+         */
+        ath9k_htc_tx_cleanup_queue(priv, &priv->tx.mgmt_ep_queue);
+        ath9k_htc_tx_cleanup_queue(priv, &priv->tx.cab_ep_queue);
+        ath9k_htc_tx_cleanup_queue(priv, &priv->tx.data_be_queue);
+        ath9k_htc_tx_cleanup_queue(priv, &priv->tx.data_bk_queue);
+        ath9k_htc_tx_cleanup_queue(priv, &priv->tx.data_vi_queue);
+        ath9k_htc_tx_cleanup_queue(priv, &priv->tx.data_vo_queue);
+        /* Wake TX queues if needed */
+        ath9k_htc_check_wake_queues(priv);
+        mod_timer(&priv->tx.cleanup_timer,
+                  jiffies + msecs_to_jiffies(ATH9K_HTC_TX_CLEANUP_INTERVAL));
 }
 int ath9k_tx_init(struct ath9k_htc_priv *priv)
 {
-        skb_queue_head_init(&priv->tx_queue);
+        skb_queue_head_init(&priv->tx.mgmt_ep_queue);
+        skb_queue_head_init(&priv->tx.cab_ep_queue);
+        skb_queue_head_init(&priv->tx.data_be_queue);
+        skb_queue_head_init(&priv->tx.data_bk_queue);
+        skb_queue_head_init(&priv->tx.data_vi_queue);
+        skb_queue_head_init(&priv->tx.data_vo_queue);
+        skb_queue_head_init(&priv->tx.tx_failed);
        return 0;
 }
@@ -507,8 +968,9 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
        int last_rssi = ATH_RSSI_DUMMY_MARKER;
        __le16 fc;
-        if (skb->len <= HTC_RX_FRAME_HEADER_SIZE) {
+        if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {
-                ath_err(common, "Corrupted RX frame, dropping\n");
+                ath_err(common, "Corrupted RX frame, dropping (len: %d)\n",
+                        skb->len);
                goto rx_next;
        }
@@ -522,6 +984,8 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
                goto rx_next;
        }
+        ath9k_htc_err_stat_rx(priv, rxstatus);
        /* Get the RX status information */
        memcpy(&rxbuf->rxstatus, rxstatus, HTC_RX_FRAME_HEADER_SIZE);
        skb_pull(skb, HTC_RX_FRAME_HEADER_SIZE);
diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c
index 62e139a30a74..cee970fdf652 100644
--- a/drivers/net/wireless/ath/ath9k/htc_hst.c
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.c
@@ -17,8 +17,8 @@
 #include "htc.h"
 static int htc_issue_send(struct htc_target *target, struct sk_buff* skb,
-                          u16 len, u8 flags, u8 epid,
+                          u16 len, u8 flags, u8 epid)
-                          struct ath9k_htc_tx_ctl *tx_ctl)
 {
        struct htc_frame_hdr *hdr;
        struct htc_endpoint *endpoint = &target->endpoint[epid];
@@ -30,8 +30,8 @@ static int htc_issue_send(struct htc_target *target, struct sk_buff* skb,
        hdr->flags = flags;
        hdr->payload_len = cpu_to_be16(len);
-        status = target->hif->send(target->hif_dev, endpoint->ul_pipeid, skb,
+        status = target->hif->send(target->hif_dev, endpoint->ul_pipeid, skb);
-                                   tx_ctl);
        return status;
 }
@@ -162,7 +162,7 @@ static int htc_config_pipe_credits(struct htc_target *target)
        target->htc_flags |= HTC_OP_CONFIG_PIPE_CREDITS;
-        ret = htc_issue_send(target, skb, skb->len, 0, ENDPOINT0, NULL);
+        ret = htc_issue_send(target, skb, skb->len, 0, ENDPOINT0);
        if (ret)
                goto err;
@@ -197,7 +197,7 @@ static int htc_setup_complete(struct htc_target *target)
        target->htc_flags |= HTC_OP_START_WAIT;
-        ret = htc_issue_send(target, skb, skb->len, 0, ENDPOINT0, NULL);
+        ret = htc_issue_send(target, skb, skb->len, 0, ENDPOINT0);
        if (ret)
                goto err;
@@ -268,7 +268,7 @@ int htc_connect_service(struct htc_target *target,
        conn_msg->dl_pipeid = endpoint->dl_pipeid;
        conn_msg->ul_pipeid = endpoint->ul_pipeid;
-        ret = htc_issue_send(target, skb, skb->len, 0, ENDPOINT0, NULL);
+        ret = htc_issue_send(target, skb, skb->len, 0, ENDPOINT0);
        if (ret)
                goto err;
@@ -286,35 +286,33 @@ err:
        return ret;
 }
-int htc_send(struct htc_target *target, struct sk_buff *skb,
+int htc_send(struct htc_target *target, struct sk_buff *skb)
-             enum htc_endpoint_id epid, struct ath9k_htc_tx_ctl *tx_ctl)
 {
-        return htc_issue_send(target, skb, skb->len, 0, epid, tx_ctl);
+        struct ath9k_htc_tx_ctl *tx_ctl;
+        tx_ctl = HTC_SKB_CB(skb);
+        return htc_issue_send(target, skb, skb->len, 0, tx_ctl->epid);
 }
-void htc_stop(struct htc_target *target)
+int htc_send_epid(struct htc_target *target, struct sk_buff *skb,
+                  enum htc_endpoint_id epid)
 {
-        enum htc_endpoint_id epid;
+        return htc_issue_send(target, skb, skb->len, 0, epid);
-        struct htc_endpoint *endpoint;
+}
-        for (epid = ENDPOINT0; epid < ENDPOINT_MAX; epid++) {
+void htc_stop(struct htc_target *target)
-                endpoint = &target->endpoint[epid];
+{
-                if (endpoint->service_id != 0)
+        target->hif->stop(target->hif_dev);
-                        target->hif->stop(target->hif_dev, endpoint->ul_pipeid);
-        }
 }
 void htc_start(struct htc_target *target)
 {
-        enum htc_endpoint_id epid;
+        target->hif->start(target->hif_dev);
-        struct htc_endpoint *endpoint;
+}
-        for (epid = ENDPOINT0; epid < ENDPOINT_MAX; epid++) {
+void htc_sta_drain(struct htc_target *target, u8 idx)
-                endpoint = &target->endpoint[epid];
+{
-                if (endpoint->service_id != 0)
+        target->hif->sta_drain(target->hif_dev, idx);
-                        target->hif->start(target->hif_dev,
-                                           endpoint->ul_pipeid);
-        }
 }
 void ath9k_htc_txcompletion_cb(struct htc_target *htc_handle,
diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.h b/drivers/net/wireless/ath/ath9k/htc_hst.h
index ecd018798c47..91a5305db95a 100644
--- a/drivers/net/wireless/ath/ath9k/htc_hst.h
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.h
@@ -33,10 +33,10 @@ struct ath9k_htc_hif {
        u8 control_dl_pipe;
        u8 control_ul_pipe;
-        void (*start) (void *hif_handle, u8 pipe);
+        void (*start) (void *hif_handle);
-        void (*stop) (void *hif_handle, u8 pipe);
+        void (*stop) (void *hif_handle);
-        int (*send) (void *hif_handle, u8 pipe, struct sk_buff *buf,
+        void (*sta_drain) (void *hif_handle, u8 idx);
-                     struct ath9k_htc_tx_ctl *tx_ctl);
+        int (*send) (void *hif_handle, u8 pipe, struct sk_buff *buf);
 };
 enum htc_endpoint_id {
@@ -83,21 +83,10 @@ struct htc_ep_callbacks {
        void (*rx) (void *, struct sk_buff *, enum htc_endpoint_id);
 };
-#define HTC_TX_QUEUE_SIZE 256
-struct htc_txq {
-        struct sk_buff *buf[HTC_TX_QUEUE_SIZE];
-        u32 txqdepth;
-        u16 txbuf_cnt;
-        u16 txq_head;
-        u16 txq_tail;
-};
 struct htc_endpoint {
        u16 service_id;
        struct htc_ep_callbacks ep_callbacks;
-        struct htc_txq htc_txq;
        u32 max_txqdepth;
        int max_msglen;
@@ -205,10 +194,12 @@ int htc_init(struct htc_target *target);
 int htc_connect_service(struct htc_target *target,
                          struct htc_service_connreq *service_connreq,
                          enum htc_endpoint_id *conn_rsp_eid);
-int htc_send(struct htc_target *target, struct sk_buff *skb,
+int htc_send(struct htc_target *target, struct sk_buff *skb);
-             enum htc_endpoint_id eid, struct ath9k_htc_tx_ctl *tx_ctl);
+int htc_send_epid(struct htc_target *target, struct sk_buff *skb,
+                  enum htc_endpoint_id epid);
 void htc_stop(struct htc_target *target);
 void htc_start(struct htc_target *target);
+void htc_sta_drain(struct htc_target *target, u8 idx);
 void ath9k_htc_rx_msg(struct htc_target *htc_handle,
                      struct sk_buff *skb, u32 len, u8 pipe_id);
diff --git a/drivers/net/wireless/ath/ath9k/hw-ops.h b/drivers/net/wireless/ath/ath9k/hw-ops.h
index c8f254fe0f0b..8b8f0445aef8 100644
--- a/drivers/net/wireless/ath/ath9k/hw-ops.h
+++ b/drivers/net/wireless/ath/ath9k/hw-ops.h
@@ -116,16 +116,21 @@ static inline void ath9k_hw_clr11n_aggr(struct ath_hw *ah, void *ds)
        ath9k_hw_ops(ah)->clr11n_aggr(ah, ds);
 }
-static inline void ath9k_hw_set11n_burstduration(struct ath_hw *ah, void *ds,
+static inline void ath9k_hw_set_clrdmask(struct ath_hw *ah, void *ds, bool val)
-                                                 u32 burstDuration)
 {
-        ath9k_hw_ops(ah)->set11n_burstduration(ah, ds, burstDuration);
+        ath9k_hw_ops(ah)->set_clrdmask(ah, ds, val);
 }
-static inline void ath9k_hw_set11n_virtualmorefrag(struct ath_hw *ah, void *ds,
+static inline void ath9k_hw_antdiv_comb_conf_get(struct ath_hw *ah,
-                                                   u32 vmf)
+                struct ath_hw_antcomb_conf *antconf)
 {
-        ath9k_hw_ops(ah)->set11n_virtualmorefrag(ah, ds, vmf);
+        ath9k_hw_ops(ah)->antdiv_comb_conf_get(ah, antconf);
+}
+static inline void ath9k_hw_antdiv_comb_conf_set(struct ath_hw *ah,
+                struct ath_hw_antcomb_conf *antconf)
+{
+        ath9k_hw_ops(ah)->antdiv_comb_conf_set(ah, antconf);
 }
 /* Private hardware call ops */
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index c95bc5cc1a1f..b75b5dca4e29 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -130,6 +130,20 @@ bool ath9k_hw_wait(struct ath_hw *ah, u32 reg, u32 mask, u32 val, u32 timeout)
 }
 EXPORT_SYMBOL(ath9k_hw_wait);
+void ath9k_hw_write_array(struct ath_hw *ah, struct ar5416IniArray *array,
+                          int column, unsigned int *writecnt)
+{
+        int r;
+        ENABLE_REGWRITE_BUFFER(ah);
+        for (r = 0; r < array->ia_rows; r++) {
+                REG_WRITE(ah, INI_RA(array, r, 0),
+                          INI_RA(array, r, column));
+                DO_DELAY(*writecnt);
+        }
+        REGWRITE_BUFFER_FLUSH(ah);
+}
 u32 ath9k_hw_reverse_bits(u32 val, u32 n)
 {
        u32 retval;
@@ -142,25 +156,6 @@ u32 ath9k_hw_reverse_bits(u32 val, u32 n)
        return retval;
 }
-bool ath9k_get_channel_edges(struct ath_hw *ah,
-                             u16 flags, u16 *low,
-                             u16 *high)
-{
-        struct ath9k_hw_capabilities *pCap = &ah->caps;
-        if (flags & CHANNEL_5GHZ) {
-                *low = pCap->low_5ghz_chan;
-                *high = pCap->high_5ghz_chan;
-                return true;
-        }
-        if ((flags & CHANNEL_2GHZ)) {
-                *low = pCap->low_2ghz_chan;
-                *high = pCap->high_2ghz_chan;
-                return true;
-        }
-        return false;
-}
 u16 ath9k_hw_computetxtime(struct ath_hw *ah,
                           u8 phy, int kbps,
                           u32 frameLen, u16 rateix,
@@ -252,6 +247,17 @@ static void ath9k_hw_read_revisions(struct ath_hw *ah)
 {
        u32 val;
+        switch (ah->hw_version.devid) {
+        case AR5416_AR9100_DEVID:
+                ah->hw_version.macVersion = AR_SREV_VERSION_9100;
+                break;
+        case AR9300_DEVID_AR9340:
+                ah->hw_version.macVersion = AR_SREV_VERSION_9340;
+                val = REG_READ(ah, AR_SREV);
+                ah->hw_version.macRev = MS(val, AR_SREV_REVISION2);
+                return;
+        }
        val = REG_READ(ah, AR_SREV) & AR_SREV_ID;
        if (val == 0xFF) {
@@ -364,11 +370,6 @@ static void ath9k_hw_init_config(struct ath_hw *ah)
                ah->config.spurchans[i][1] = AR_NO_SPUR;
        }
-        if (ah->hw_version.devid != AR2427_DEVID_PCIE)
-                ah->config.ht_enable = 1;
-        else
-                ah->config.ht_enable = 0;
        /* PAPRD needs some more work to be enabled */
        ah->config.paprd_disable = 1;
@@ -410,6 +411,8 @@ static void ath9k_hw_init_defaults(struct ath_hw *ah)
        ah->sta_id1_defaults =
                AR_STA_ID1_CRPT_MIC_ENABLE |
                AR_STA_ID1_MCAST_KSRCH;
+        if (AR_SREV_9100(ah))
+                ah->sta_id1_defaults |= AR_STA_ID1_AR9100_BA_FIX;
        ah->enable_32kHz_clock = DONT_USE_32KHZ;
        ah->slottime = 20;
        ah->globaltxtimeout = (u32) -1;
@@ -470,7 +473,7 @@ static int ath9k_hw_post_init(struct ath_hw *ah)
                return ecode;
        }
-        if (!AR_SREV_9100(ah)) {
+        if (!AR_SREV_9100(ah) && !AR_SREV_9340(ah)) {
                ath9k_hw_ani_setup(ah);
                ath9k_hw_ani_init(ah);
        }
@@ -492,9 +495,6 @@ static int __ath9k_hw_init(struct ath_hw *ah)
        struct ath_common *common = ath9k_hw_common(ah);
        int r = 0;
-        if (ah->hw_version.devid == AR5416_AR9100_DEVID)
-                ah->hw_version.macVersion = AR_SREV_VERSION_9100;
        ath9k_hw_read_revisions(ah);
        /*
@@ -552,6 +552,7 @@ static int __ath9k_hw_init(struct ath_hw *ah)
        case AR_SREV_VERSION_9271:
        case AR_SREV_VERSION_9300:
        case AR_SREV_VERSION_9485:
+        case AR_SREV_VERSION_9340:
                break;
        default:
                ath_err(common,
@@ -560,7 +561,7 @@ static int __ath9k_hw_init(struct ath_hw *ah)
                return -EOPNOTSUPP;
        }
-        if (AR_SREV_9271(ah) || AR_SREV_9100(ah))
+        if (AR_SREV_9271(ah) || AR_SREV_9100(ah) || AR_SREV_9340(ah))
                ah->is_pciexpress = false;
        ah->hw_version.phyRev = REG_READ(ah, AR_PHY_CHIP_ID);
@@ -629,6 +630,7 @@ int ath9k_hw_init(struct ath_hw *ah)
        case AR2427_DEVID_PCIE:
        case AR9300_DEVID_PCIE:
        case AR9300_DEVID_AR9485_PCIE:
+        case AR9300_DEVID_AR9340:
                break;
        default:
                if (common->bus_ops->ath_bus_type == ATH_USB)
@@ -671,48 +673,89 @@ static void ath9k_hw_init_qos(struct ath_hw *ah)
        REGWRITE_BUFFER_FLUSH(ah);
 }
-unsigned long ar9003_get_pll_sqsum_dvc(struct ath_hw *ah)
+u32 ar9003_get_pll_sqsum_dvc(struct ath_hw *ah)
 {
-                REG_WRITE(ah, PLL3, (REG_READ(ah, PLL3) & ~(PLL3_DO_MEAS_MASK)));
+        REG_CLR_BIT(ah, PLL3, PLL3_DO_MEAS_MASK);
-                udelay(100);
+        udelay(100);
-                REG_WRITE(ah, PLL3, (REG_READ(ah, PLL3) | PLL3_DO_MEAS_MASK));
+        REG_SET_BIT(ah, PLL3, PLL3_DO_MEAS_MASK);
-                while ((REG_READ(ah, PLL4) & PLL4_MEAS_DONE) == 0)
+        while ((REG_READ(ah, PLL4) & PLL4_MEAS_DONE) == 0)
-                        udelay(100);
+                udelay(100);
-                return (REG_READ(ah, PLL3) & SQSUM_DVC_MASK) >> 3;
+        return (REG_READ(ah, PLL3) & SQSUM_DVC_MASK) >> 3;
 }
 EXPORT_SYMBOL(ar9003_get_pll_sqsum_dvc);
-#define DPLL2_KD_VAL            0x3D
-#define DPLL2_KI_VAL            0x06
-#define DPLL3_PHASE_SHIFT_VAL   0x1
 static void ath9k_hw_init_pll(struct ath_hw *ah,
                              struct ath9k_channel *chan)
 {
        u32 pll;
        if (AR_SREV_9485(ah)) {
-                REG_WRITE(ah, AR_RTC_PLL_CONTROL2, 0x886666);
-                REG_WRITE(ah, AR_CH0_DDR_DPLL2, 0x19e82f01);
-                REG_RMW_FIELD(ah, AR_CH0_DDR_DPLL3,
+                /* program BB PLL ki and kd value, ki=0x4, kd=0x40 */
-                              AR_CH0_DPLL3_PHASE_SHIFT, DPLL3_PHASE_SHIFT_VAL);
+                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL2,
+                              AR_CH0_BB_DPLL2_PLL_PWD, 0x1);
-                REG_WRITE(ah, AR_RTC_PLL_CONTROL, 0x1142c);
+                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL2,
-                udelay(1000);
+                              AR_CH0_DPLL2_KD, 0x40);
+                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL2,
+                              AR_CH0_DPLL2_KI, 0x4);
-                REG_WRITE(ah, AR_RTC_PLL_CONTROL2, 0x886666);
+                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL1,
+                              AR_CH0_BB_DPLL1_REFDIV, 0x5);
+                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL1,
+                              AR_CH0_BB_DPLL1_NINI, 0x58);
+                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL1,
+                              AR_CH0_BB_DPLL1_NFRAC, 0x0);
                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL2,
-                              AR_CH0_DPLL2_KD, DPLL2_KD_VAL);
+                              AR_CH0_BB_DPLL2_OUTDIV, 0x1);
+                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL2,
+                              AR_CH0_BB_DPLL2_LOCAL_PLL, 0x1);
                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL2,
-                              AR_CH0_DPLL2_KI, DPLL2_KI_VAL);
+                              AR_CH0_BB_DPLL2_EN_NEGTRIG, 0x1);
+                /* program BB PLL phase_shift to 0x6 */
                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL3,
-                              AR_CH0_DPLL3_PHASE_SHIFT, DPLL3_PHASE_SHIFT_VAL);
+                              AR_CH0_BB_DPLL3_PHASE_SHIFT, 0x6);
-                REG_WRITE(ah, AR_RTC_PLL_CONTROL, 0x142c);
+                REG_RMW_FIELD(ah, AR_CH0_BB_DPLL2,
+                              AR_CH0_BB_DPLL2_PLL_PWD, 0x0);
+                udelay(1000);
+        } else if (AR_SREV_9340(ah)) {
+                u32 regval, pll2_divint, pll2_divfrac, refdiv;
+                REG_WRITE(ah, AR_RTC_PLL_CONTROL, 0x1142c);
+                udelay(1000);
+                REG_SET_BIT(ah, AR_PHY_PLL_MODE, 0x1 << 16);
+                udelay(100);
+                if (ah->is_clk_25mhz) {
+                        pll2_divint = 0x54;
+                        pll2_divfrac = 0x1eb85;
+                        refdiv = 3;
+                } else {
+                        pll2_divint = 88;
+                        pll2_divfrac = 0;
+                        refdiv = 5;
+                }
+                regval = REG_READ(ah, AR_PHY_PLL_MODE);
+                regval |= (0x1 << 16);
+                REG_WRITE(ah, AR_PHY_PLL_MODE, regval);
+                udelay(100);
+                REG_WRITE(ah, AR_PHY_PLL_CONTROL, (refdiv << 27) |
+                          (pll2_divint << 18) | pll2_divfrac);
+                udelay(100);
+                regval = REG_READ(ah, AR_PHY_PLL_MODE);
+                regval = (regval & 0x80071fff) | (0x1 << 30) | (0x1 << 13) |
+                         (0x4 << 26) | (0x18 << 19);
+                REG_WRITE(ah, AR_PHY_PLL_MODE, regval);
+                REG_WRITE(ah, AR_PHY_PLL_MODE,
+                          REG_READ(ah, AR_PHY_PLL_MODE) & 0xfffeffff);
                udelay(1000);
        }
@@ -720,6 +763,9 @@ static void ath9k_hw_init_pll(struct ath_hw *ah,
        REG_WRITE(ah, AR_RTC_PLL_CONTROL, pll);
+        if (AR_SREV_9485(ah) || AR_SREV_9340(ah))
+                udelay(1000);
        /* Switch the core clock for ar9271 to 117Mhz */
        if (AR_SREV_9271(ah)) {
                udelay(500);
@@ -729,17 +775,34 @@ static void ath9k_hw_init_pll(struct ath_hw *ah,
        udelay(RTC_PLL_SETTLE_DELAY);
        REG_WRITE(ah, AR_RTC_SLEEP_CLK, AR_RTC_FORCE_DERIVED_CLK);
+        if (AR_SREV_9340(ah)) {
+                if (ah->is_clk_25mhz) {
+                        REG_WRITE(ah, AR_RTC_DERIVED_CLK, 0x17c << 1);
+                        REG_WRITE(ah, AR_SLP32_MODE, 0x0010f3d7);
+                        REG_WRITE(ah,  AR_SLP32_INC, 0x0001e7ae);
+                } else {
+                        REG_WRITE(ah, AR_RTC_DERIVED_CLK, 0x261 << 1);
+                        REG_WRITE(ah, AR_SLP32_MODE, 0x0010f400);
+                        REG_WRITE(ah,  AR_SLP32_INC, 0x0001e800);
+                }
+                udelay(100);
+        }
 }
 static void ath9k_hw_init_interrupt_masks(struct ath_hw *ah,
                                          enum nl80211_iftype opmode)
 {
+        u32 sync_default = AR_INTR_SYNC_DEFAULT;
        u32 imr_reg = AR_IMR_TXERR |
                AR_IMR_TXURN |
                AR_IMR_RXERR |
                AR_IMR_RXORN |
                AR_IMR_BCNMISC;
+        if (AR_SREV_9340(ah))
+                sync_default &= ~AR_INTR_SYNC_HOST1_FATAL;
        if (AR_SREV_9300_20_OR_LATER(ah)) {
                imr_reg |= AR_IMR_RXOK_HP;
                if (ah->config.rx_intr_mitigation)
@@ -770,7 +833,7 @@ static void ath9k_hw_init_interrupt_masks(struct ath_hw *ah,
        if (!AR_SREV_9100(ah)) {
                REG_WRITE(ah, AR_INTR_SYNC_CAUSE, 0xFFFFFFFF);
-                REG_WRITE(ah, AR_INTR_SYNC_ENABLE, AR_INTR_SYNC_DEFAULT);
+                REG_WRITE(ah, AR_INTR_SYNC_ENABLE, sync_default);
                REG_WRITE(ah, AR_INTR_SYNC_MASK, 0);
        }
@@ -830,8 +893,7 @@ void ath9k_hw_init_global_settings(struct ath_hw *ah)
                ah->misc_mode);
        if (ah->misc_mode != 0)
-                REG_WRITE(ah, AR_PCU_MISC,
+                REG_SET_BIT(ah, AR_PCU_MISC, ah->misc_mode);
-                          REG_READ(ah, AR_PCU_MISC) | ah->misc_mode);
        if (conf->channel && conf->channel->band == IEEE80211_BAND_5GHZ)
                sifstime = 16;
@@ -899,23 +961,19 @@ u32 ath9k_regd_get_ctl(struct ath_regulatory *reg, struct ath9k_channel *chan)
 static inline void ath9k_hw_set_dma(struct ath_hw *ah)
 {
        struct ath_common *common = ath9k_hw_common(ah);
-        u32 regval;
        ENABLE_REGWRITE_BUFFER(ah);
        /*
         * set AHB_MODE not to do cacheline prefetches
        */
-        if (!AR_SREV_9300_20_OR_LATER(ah)) {
+        if (!AR_SREV_9300_20_OR_LATER(ah))
-                regval = REG_READ(ah, AR_AHB_MODE);
+                REG_SET_BIT(ah, AR_AHB_MODE, AR_AHB_PREFETCH_RD_EN);
-                REG_WRITE(ah, AR_AHB_MODE, regval | AR_AHB_PREFETCH_RD_EN);
-        }
        /*
         * let mac dma reads be in 128 byte chunks
         */
-        regval = REG_READ(ah, AR_TXCFG) & ~AR_TXCFG_DMASZ_MASK;
+        REG_RMW(ah, AR_TXCFG, AR_TXCFG_DMASZ_128B, AR_TXCFG_DMASZ_MASK);
-        REG_WRITE(ah, AR_TXCFG, regval | AR_TXCFG_DMASZ_128B);
        REGWRITE_BUFFER_FLUSH(ah);
@@ -932,8 +990,7 @@ static inline void ath9k_hw_set_dma(struct ath_hw *ah)
        /*
         * let mac dma writes be in 128 byte chunks
         */
-        regval = REG_READ(ah, AR_RXCFG) & ~AR_RXCFG_DMASZ_MASK;
+        REG_RMW(ah, AR_RXCFG, AR_RXCFG_DMASZ_128B, AR_RXCFG_DMASZ_MASK);
-        REG_WRITE(ah, AR_RXCFG, regval | AR_RXCFG_DMASZ_128B);
        /*
         * Setup receive FIFO threshold to hold off TX activities
@@ -972,30 +1029,27 @@ static inline void ath9k_hw_set_dma(struct ath_hw *ah)
 static void ath9k_hw_set_operating_mode(struct ath_hw *ah, int opmode)
 {
-        u32 val;
+        u32 mask = AR_STA_ID1_STA_AP | AR_STA_ID1_ADHOC;
+        u32 set = AR_STA_ID1_KSRCH_MODE;
-        val = REG_READ(ah, AR_STA_ID1);
-        val &= ~(AR_STA_ID1_STA_AP | AR_STA_ID1_ADHOC);
        switch (opmode) {
-        case NL80211_IFTYPE_AP:
-                REG_WRITE(ah, AR_STA_ID1, val | AR_STA_ID1_STA_AP
-                          | AR_STA_ID1_KSRCH_MODE);
-                REG_CLR_BIT(ah, AR_CFG, AR_CFG_AP_ADHOC_INDICATION);
-                break;
        case NL80211_IFTYPE_ADHOC:
        case NL80211_IFTYPE_MESH_POINT:
-                REG_WRITE(ah, AR_STA_ID1, val | AR_STA_ID1_ADHOC
+                set |= AR_STA_ID1_ADHOC;
-                          | AR_STA_ID1_KSRCH_MODE);
                REG_SET_BIT(ah, AR_CFG, AR_CFG_AP_ADHOC_INDICATION);
                break;
+        case NL80211_IFTYPE_AP:
+                set |= AR_STA_ID1_STA_AP;
+                /* fall through */
        case NL80211_IFTYPE_STATION:
-                REG_WRITE(ah, AR_STA_ID1, val | AR_STA_ID1_KSRCH_MODE);
+                REG_CLR_BIT(ah, AR_CFG, AR_CFG_AP_ADHOC_INDICATION);
                break;
        default:
-                if (ah->is_monitoring)
+                if (!ah->is_monitoring)
-                        REG_WRITE(ah, AR_STA_ID1, val | AR_STA_ID1_KSRCH_MODE);
+                        set = 0;
                break;
        }
+        REG_RMW(ah, AR_STA_ID1, set, mask);
 }
 void ath9k_hw_get_delta_slope_vals(struct ath_hw *ah, u32 coef_scaled,
@@ -1021,10 +1075,8 @@ static bool ath9k_hw_set_reset(struct ath_hw *ah, int type)
        u32 tmpReg;
        if (AR_SREV_9100(ah)) {
-                u32 val = REG_READ(ah, AR_RTC_DERIVED_CLK);
+                REG_RMW_FIELD(ah, AR_RTC_DERIVED_CLK,
-                val &= ~AR_RTC_DERIVED_CLK_PERIOD;
+                              AR_RTC_DERIVED_CLK_PERIOD, 1);
-                val |= SM(1, AR_RTC_DERIVED_CLK_PERIOD);
-                REG_WRITE(ah, AR_RTC_DERIVED_CLK, val);
                (void)REG_READ(ah, AR_RTC_DERIVED_CLK);
        }
@@ -1212,6 +1264,20 @@ static bool ath9k_hw_channel_change(struct ath_hw *ah,
        return true;
 }
+static void ath9k_hw_apply_gpio_override(struct ath_hw *ah)
+{
+        u32 gpio_mask = ah->gpio_mask;
+        int i;
+        for (i = 0; gpio_mask; i++, gpio_mask >>= 1) {
+                if (!(gpio_mask & 1))
+                        continue;
+                ath9k_hw_cfg_output(ah, i, AR_GPIO_OUTPUT_MUX_AS_OUTPUT);
+                ath9k_hw_set_gpio(ah, i, !!(ah->gpio_val & BIT(i)));
+        }
+}
 bool ath9k_hw_check_alive(struct ath_hw *ah)
 {
        int count = 50;
@@ -1409,7 +1475,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan,
        REGWRITE_BUFFER_FLUSH(ah);
        ah->intr_txqs = 0;
-        for (i = 0; i < ah->caps.total_queues; i++)
+        for (i = 0; i < ATH9K_NUM_TX_QUEUES; i++)
                ath9k_hw_resettxqueue(ah, i);
        ath9k_hw_init_interrupt_masks(ah, ah->opmode);
@@ -1426,8 +1492,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan,
                ar9002_hw_enable_wep_aggregation(ah);
        }
-        REG_WRITE(ah, AR_STA_ID1,
+        REG_SET_BIT(ah, AR_STA_ID1, AR_STA_ID1_PRESERVE_SEQNUM);
-                  REG_READ(ah, AR_STA_ID1) | AR_STA_ID1_PRESERVE_SEQNUM);
        ath9k_hw_set_dma(ah);
@@ -1480,7 +1545,9 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan,
                                REG_WRITE(ah, AR_CFG, AR_CFG_SWTD | AR_CFG_SWRD);
                }
 #ifdef __BIG_ENDIAN
-                else
+                else if (AR_SREV_9340(ah))
+                        REG_RMW(ah, AR_CFG, AR_CFG_SWRB | AR_CFG_SWTB, 0);
+                else
                        REG_WRITE(ah, AR_CFG, AR_CFG_SWTD | AR_CFG_SWRD);
 #endif
        }
@@ -1491,6 +1558,8 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan,
        if (AR_SREV_9300_20_OR_LATER(ah))
                ar9003_hw_bb_watchdog_config(ah);
+        ath9k_hw_apply_gpio_override(ah);
        return 0;
 }
 EXPORT_SYMBOL(ath9k_hw_reset);
@@ -1670,21 +1739,15 @@ void ath9k_hw_beaconinit(struct ath_hw *ah, u32 next_beacon, u32 beacon_period)
        case NL80211_IFTYPE_MESH_POINT:
                REG_SET_BIT(ah, AR_TXCFG,
                            AR_TXCFG_ADHOC_BEACON_ATIM_TX_POLICY);
-                REG_WRITE(ah, AR_NEXT_NDP_TIMER,
+                REG_WRITE(ah, AR_NEXT_NDP_TIMER, next_beacon +
-                          TU_TO_USEC(next_beacon +
+                          TU_TO_USEC(ah->atim_window ? ah->atim_window : 1));
-                                     (ah->atim_window ? ah->
-                                      atim_window : 1)));
                flags |= AR_NDP_TIMER_EN;
        case NL80211_IFTYPE_AP:
-                REG_WRITE(ah, AR_NEXT_TBTT_TIMER, TU_TO_USEC(next_beacon));
+                REG_WRITE(ah, AR_NEXT_TBTT_TIMER, next_beacon);
-                REG_WRITE(ah, AR_NEXT_DMA_BEACON_ALERT,
+                REG_WRITE(ah, AR_NEXT_DMA_BEACON_ALERT, next_beacon -
-                          TU_TO_USEC(next_beacon -
+                          TU_TO_USEC(ah->config.dma_beacon_response_time));
-                                     ah->config.
+                REG_WRITE(ah, AR_NEXT_SWBA, next_beacon -
-                                     dma_beacon_response_time));
+                          TU_TO_USEC(ah->config.sw_beacon_response_time));
-                REG_WRITE(ah, AR_NEXT_SWBA,
-                          TU_TO_USEC(next_beacon -
-                                     ah->config.
-                                     sw_beacon_response_time));
                flags |=
                        AR_TBTT_TIMER_EN | AR_DBA_TIMER_EN | AR_SWBA_TIMER_EN;
                break;
@@ -1696,18 +1759,13 @@ void ath9k_hw_beaconinit(struct ath_hw *ah, u32 next_beacon, u32 beacon_period)
                break;
        }
-        REG_WRITE(ah, AR_BEACON_PERIOD, TU_TO_USEC(beacon_period));
+        REG_WRITE(ah, AR_BEACON_PERIOD, beacon_period);
-        REG_WRITE(ah, AR_DMA_BEACON_PERIOD, TU_TO_USEC(beacon_period));
+        REG_WRITE(ah, AR_DMA_BEACON_PERIOD, beacon_period);
-        REG_WRITE(ah, AR_SWBA_PERIOD, TU_TO_USEC(beacon_period));
+        REG_WRITE(ah, AR_SWBA_PERIOD, beacon_period);
-        REG_WRITE(ah, AR_NDP_PERIOD, TU_TO_USEC(beacon_period));
+        REG_WRITE(ah, AR_NDP_PERIOD, beacon_period);
        REGWRITE_BUFFER_FLUSH(ah);
-        beacon_period &= ~ATH9K_BEACON_ENA;
-        if (beacon_period & ATH9K_BEACON_RESET_TSF) {
-                ath9k_hw_reset_tsf(ah);
-        }
        REG_SET_BIT(ah, AR_TIMER_MODE, flags);
 }
 EXPORT_SYMBOL(ath9k_hw_beaconinit);
@@ -1795,7 +1853,7 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
        struct ath_common *common = ath9k_hw_common(ah);
        struct ath_btcoex_hw *btcoex_hw = &ah->btcoex_hw;
-        u16 capField = 0, eeval;
+        u16 eeval;
        u8 ant_div_ctl1, tx_chainmask, rx_chainmask;
        eeval = ah->eep_ops->get_eeprom(ah, EEP_REG_0);
@@ -1806,8 +1864,6 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
                eeval |= AR9285_RDEXT_DEFAULT;
        regulatory->current_rd_ext = eeval;
-        capField = ah->eep_ops->get_eeprom(ah, EEP_OP_CAP);
        if (ah->opmode != NL80211_IFTYPE_AP &&
            ah->hw_version.subvendorid == AR_SUBVENDOR_ID_NEW_A) {
                if (regulatory->current_rd == 0x64 ||
@@ -1842,6 +1898,8 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
            !(AR_SREV_9271(ah)))
                /* CB71: GPIO 0 is pulled down to indicate 3 rx chains */
                pCap->rx_chainmask = ath9k_hw_gpio_get(ah, 0) ? 0x5 : 0x7;
+        else if (AR_SREV_9100(ah))
+                pCap->rx_chainmask = 0x7;
        else
                /* Use rx_chainmask from EEPROM. */
                pCap->rx_chainmask = ah->eep_ops->get_eeprom(ah, EEP_RX_MASK);
@@ -1852,36 +1910,13 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
        if (AR_SREV_9300_20_OR_LATER(ah))
                ah->misc_mode |= AR_PCU_ALWAYS_PERFORM_KEYSEARCH;
-        pCap->low_2ghz_chan = 2312;
-        pCap->high_2ghz_chan = 2732;
-        pCap->low_5ghz_chan = 4920;
-        pCap->high_5ghz_chan = 6100;
        common->crypt_caps |= ATH_CRYPT_CAP_CIPHER_AESCCM;
-        if (ah->config.ht_enable)
+        if (ah->hw_version.devid != AR2427_DEVID_PCIE)
                pCap->hw_caps |= ATH9K_HW_CAP_HT;
        else
                pCap->hw_caps &= ~ATH9K_HW_CAP_HT;
-        if (capField & AR_EEPROM_EEPCAP_MAXQCU)
-                pCap->total_queues =
-                        MS(capField, AR_EEPROM_EEPCAP_MAXQCU);
-        else
-                pCap->total_queues = ATH9K_NUM_TX_QUEUES;
-        if (capField & AR_EEPROM_EEPCAP_KC_ENTRIES)
-                pCap->keycache_size =
-                        1 << MS(capField, AR_EEPROM_EEPCAP_KC_ENTRIES);
-        else
-                pCap->keycache_size = AR_KEYTABLE_SIZE;
-        if (AR_SREV_9285(ah) || AR_SREV_9271(ah))
-                pCap->tx_triglevel_max = MAX_TX_FIFO_THRESHOLD >> 1;
-        else
-                pCap->tx_triglevel_max = MAX_TX_FIFO_THRESHOLD;
        if (AR_SREV_9271(ah))
                pCap->num_gpio_pins = AR9271_NUM_GPIO;
        else if (AR_DEVID_7010(ah))
@@ -1900,8 +1935,6 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
                pCap->rts_aggr_limit = (8 * 1024);
        }
-        pCap->hw_caps |= ATH9K_HW_CAP_ENHANCEDPM;
 #if defined(CONFIG_RFKILL) || defined(CONFIG_RFKILL_MODULE)
        ah->rfsilent = ah->eep_ops->get_eeprom(ah, EEP_RF_SILENT);
        if (ah->rfsilent & EEP_RFSILENT_ENABLED) {
@@ -1923,32 +1956,23 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
        else
                pCap->hw_caps |= ATH9K_HW_CAP_4KB_SPLITTRANS;
-        if (regulatory->current_rd_ext & (1 << REG_EXT_JAPAN_MIDBAND)) {
+        if (common->btcoex_enabled) {
-                pCap->reg_cap =
+                if (AR_SREV_9300_20_OR_LATER(ah)) {
-                        AR_EEPROM_EEREGCAP_EN_KK_NEW_11A |
-                        AR_EEPROM_EEREGCAP_EN_KK_U1_EVEN |
-                        AR_EEPROM_EEREGCAP_EN_KK_U2 |
-                        AR_EEPROM_EEREGCAP_EN_KK_MIDBAND;
-        } else {
-                pCap->reg_cap =
-                        AR_EEPROM_EEREGCAP_EN_KK_NEW_11A |
-                        AR_EEPROM_EEREGCAP_EN_KK_U1_EVEN;
-        }
-        /* Advertise midband for AR5416 with FCC midband set in eeprom */
-        if (regulatory->current_rd_ext & (1 << REG_EXT_FCC_MIDBAND) &&
-            AR_SREV_5416(ah))
-                pCap->reg_cap |= AR_EEPROM_EEREGCAP_EN_FCC_MIDBAND;
-        if (AR_SREV_9280_20_OR_LATER(ah) && common->btcoex_enabled) {
-                btcoex_hw->btactive_gpio = ATH_BTACTIVE_GPIO;
-                btcoex_hw->wlanactive_gpio = ATH_WLANACTIVE_GPIO;
-                if (AR_SREV_9285(ah)) {
                        btcoex_hw->scheme = ATH_BTCOEX_CFG_3WIRE;
-                        btcoex_hw->btpriority_gpio = ATH_BTPRIORITY_GPIO;
+                        btcoex_hw->btactive_gpio = ATH_BTACTIVE_GPIO_9300;
-                } else {
+                        btcoex_hw->wlanactive_gpio = ATH_WLANACTIVE_GPIO_9300;
-                        btcoex_hw->scheme = ATH_BTCOEX_CFG_2WIRE;
+                        btcoex_hw->btpriority_gpio = ATH_BTPRIORITY_GPIO_9300;
+                } else if (AR_SREV_9280_20_OR_LATER(ah)) {
+                        btcoex_hw->btactive_gpio = ATH_BTACTIVE_GPIO_9280;
+                        btcoex_hw->wlanactive_gpio = ATH_WLANACTIVE_GPIO_9280;
+                        if (AR_SREV_9285(ah)) {
+                                btcoex_hw->scheme = ATH_BTCOEX_CFG_3WIRE;
+                                btcoex_hw->btpriority_gpio =
+                                                ATH_BTPRIORITY_GPIO_9285;
+                        } else {
+                                btcoex_hw->scheme = ATH_BTCOEX_CFG_2WIRE;
+                        }
                }
        } else {
                btcoex_hw->scheme = ATH_BTCOEX_CFG_NONE;
@@ -1998,6 +2022,22 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
        }
+        if (AR_SREV_9485(ah)) {
+                ant_div_ctl1 = ah->eep_ops->get_eeprom(ah, EEP_ANT_DIV_CTL1);
+                /*
+                 * enable the diversity-combining algorithm only when
+                 * both enable_lna_div and enable_fast_div are set
+                 *              Table for Diversity
+                 * ant_div_alt_lnaconf          bit 0-1
+                 * ant_div_main_lnaconf         bit 2-3
+                 * ant_div_alt_gaintb           bit 4
+                 * ant_div_main_gaintb          bit 5
+                 * enable_ant_div_lnadiv        bit 6
+                 * enable_ant_fast_div          bit 7
+                 */
+                if ((ant_div_ctl1 >> 0x6) == 0x3)
+                        pCap->hw_caps |= ATH9K_HW_CAP_ANT_DIV_COMB;
+        }
        if (AR_SREV_9485_10(ah)) {
                pCap->pcie_lcr_extsync_en = true;
@@ -2186,11 +2226,9 @@ void ath9k_hw_setrxfilter(struct ath_hw *ah, u32 bits)
        REG_WRITE(ah, AR_PHY_ERR, phybits);
        if (phybits)
-                REG_WRITE(ah, AR_RXCFG,
+                REG_SET_BIT(ah, AR_RXCFG, AR_RXCFG_ZLFDMA);
-                          REG_READ(ah, AR_RXCFG) | AR_RXCFG_ZLFDMA);
        else
-                REG_WRITE(ah, AR_RXCFG,
+                REG_CLR_BIT(ah, AR_RXCFG, AR_RXCFG_ZLFDMA);
-                          REG_READ(ah, AR_RXCFG) & ~AR_RXCFG_ZLFDMA);
        REGWRITE_BUFFER_FLUSH(ah);
 }
@@ -2366,10 +2404,11 @@ static u32 rightmost_index(struct ath_gen_timer_table *timer_table, u32 *mask)
        return timer_table->gen_timer_index[b];
 }
-static u32 ath9k_hw_gettsf32(struct ath_hw *ah)
+u32 ath9k_hw_gettsf32(struct ath_hw *ah)
 {
        return REG_READ(ah, AR_TSF_L32);
 }
+EXPORT_SYMBOL(ath9k_hw_gettsf32);
 struct ath_gen_timer *ath_gen_timer_alloc(struct ath_hw *ah,
                                          void (*trigger)(void *),
@@ -2402,11 +2441,11 @@ EXPORT_SYMBOL(ath_gen_timer_alloc);
 void ath9k_hw_gen_timer_start(struct ath_hw *ah,
                              struct ath_gen_timer *timer,
-                              u32 timer_next,
+                              u32 trig_timeout,
                              u32 timer_period)
 {
        struct ath_gen_timer_table *timer_table = &ah->hw_gen_timers;
-        u32 tsf;
+        u32 tsf, timer_next;
        BUG_ON(!timer_period);
@@ -2414,18 +2453,13 @@ void ath9k_hw_gen_timer_start(struct ath_hw *ah,
        tsf = ath9k_hw_gettsf32(ah);
+        timer_next = tsf + trig_timeout;
        ath_dbg(ath9k_hw_common(ah), ATH_DBG_HWTIMER,
                "current tsf %x period %x timer_next %x\n",
                tsf, timer_period, timer_next);
        /*
-         * Pull timer_next forward if the current TSF already passed it
-         * because of software latency
-         */
-        if (timer_next < tsf)
-                timer_next = tsf + timer_period;
-        /*
         * Program generic timer registers
         */
        REG_WRITE(ah, gen_tmr_configuration[timer->index].next_addr,
diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h
index 6650fd48415c..7af2773d2bfc 100644
--- a/drivers/net/wireless/ath/ath9k/hw.h
+++ b/drivers/net/wireless/ath/ath9k/hw.h
@@ -43,6 +43,7 @@
 #define AR9287_DEVID_PCI        0x002d
 #define AR9287_DEVID_PCIE       0x002e
 #define AR9300_DEVID_PCIE       0x0030
+#define AR9300_DEVID_AR9340     0x0031
 #define AR9300_DEVID_AR9485_PCIE 0x0032
 #define AR5416_AR9100_DEVID     0x000b
@@ -55,6 +56,9 @@
 #define AT9285_COEX3WIRE_SA_SUBSYSID    0x30aa
 #define AT9285_COEX3WIRE_DA_SUBSYSID    0x30ab
+#define AR9300_NUM_BT_WEIGHTS   4
+#define AR9300_NUM_WLAN_WEIGHTS 4
 #define ATH_AMPDU_LIMIT_MAX        (64 * 1024 - 1)
 #define ATH_DEFAULT_NOISE_FLOOR -95
@@ -65,53 +69,49 @@
 /* Register read/write primitives */
 #define REG_WRITE(_ah, _reg, _val) \
-        ath9k_hw_common(_ah)->ops->write((_ah), (_val), (_reg))
+        (_ah)->reg_ops.write((_ah), (_val), (_reg))
 #define REG_READ(_ah, _reg) \
-        ath9k_hw_common(_ah)->ops->read((_ah), (_reg))
+        (_ah)->reg_ops.read((_ah), (_reg))
 #define REG_READ_MULTI(_ah, _addr, _val, _cnt)          \
-        ath9k_hw_common(_ah)->ops->multi_read((_ah), (_addr), (_val), (_cnt))
+        (_ah)->reg_ops.multi_read((_ah), (_addr), (_val), (_cnt))
+#define REG_RMW(_ah, _reg, _set, _clr) \
+        (_ah)->reg_ops.rmw((_ah), (_reg), (_set), (_clr))
 #define ENABLE_REGWRITE_BUFFER(_ah)                                     \
        do {                                                            \
-                if (ath9k_hw_common(_ah)->ops->enable_write_buffer)     \
+                if ((_ah)->reg_ops.enable_write_buffer) \
-                        ath9k_hw_common(_ah)->ops->enable_write_buffer((_ah)); \
+                        (_ah)->reg_ops.enable_write_buffer((_ah)); \
        } while (0)
 #define REGWRITE_BUFFER_FLUSH(_ah)                                      \
        do {                                                            \
-                if (ath9k_hw_common(_ah)->ops->write_flush)             \
+                if ((_ah)->reg_ops.write_flush)         \
-                        ath9k_hw_common(_ah)->ops->write_flush((_ah));  \
+                        (_ah)->reg_ops.write_flush((_ah));      \
        } while (0)
 #define SM(_v, _f)  (((_v) << _f##_S) & _f)
 #define MS(_v, _f)  (((_v) & _f) >> _f##_S)
-#define REG_RMW(_a, _r, _set, _clr)    \
-        REG_WRITE(_a, _r, (REG_READ(_a, _r) & ~(_clr)) | (_set))
 #define REG_RMW_FIELD(_a, _r, _f, _v) \
-        REG_WRITE(_a, _r, \
+        REG_RMW(_a, _r, (((_v) << _f##_S) & _f), (_f))
-        (REG_READ(_a, _r) & ~_f) | (((_v) << _f##_S) & _f))
 #define REG_READ_FIELD(_a, _r, _f) \
        (((REG_READ(_a, _r) & _f) >> _f##_S))
 #define REG_SET_BIT(_a, _r, _f) \
-        REG_WRITE(_a, _r, REG_READ(_a, _r) | (_f))
+        REG_RMW(_a, _r, (_f), 0)
 #define REG_CLR_BIT(_a, _r, _f) \
-        REG_WRITE(_a, _r, REG_READ(_a, _r) & ~(_f))
+        REG_RMW(_a, _r, 0, (_f))
-#define DO_DELAY(x) do {                        \
+#define DO_DELAY(x) do {                                        \
-                if ((++(x) % 64) == 0)          \
+                if (((++(x) % 64) == 0) &&                      \
-                        udelay(1);              \
+                    (ath9k_hw_common(ah)->bus_ops->ath_bus_type \
+                        != ATH_USB))                            \
+                        udelay(1);                              \
        } while (0)
-#define REG_WRITE_ARRAY(iniarray, column, regWr) do {                   \
+#define REG_WRITE_ARRAY(iniarray, column, regWr) \
-                int r;                                                  \
+        ath9k_hw_write_array(ah, iniarray, column, &(regWr))
-                for (r = 0; r < ((iniarray)->ia_rows); r++) {           \
-                        REG_WRITE(ah, INI_RA((iniarray), (r), 0),       \
-                                  INI_RA((iniarray), r, (column)));     \
-                        DO_DELAY(regWr);                                \
-                }                                                       \
-        } while (0)
 #define AR_GPIO_OUTPUT_MUX_AS_OUTPUT             0
 #define AR_GPIO_OUTPUT_MUX_AS_PCIE_ATTENTION_LED 1
@@ -125,7 +125,7 @@
 #define AR_GPIO_BIT(_gpio)          (1 << (_gpio))
 #define BASE_ACTIVATE_DELAY         100
-#define RTC_PLL_SETTLE_DELAY        100
+#define RTC_PLL_SETTLE_DELAY        (AR_SREV_9340(ah) ? 1000 : 100)
 #define COEF_SCALE_S                24
 #define HT40_CHANNEL_CENTER_SHIFT   10
@@ -178,7 +178,6 @@ enum ath9k_hw_caps {
        ATH9K_HW_CAP_HT                         = BIT(0),
        ATH9K_HW_CAP_RFSILENT                   = BIT(1),
        ATH9K_HW_CAP_CST                        = BIT(2),
-        ATH9K_HW_CAP_ENHANCEDPM                 = BIT(3),
        ATH9K_HW_CAP_AUTOSLEEP                  = BIT(4),
        ATH9K_HW_CAP_4KB_SPLITTRANS             = BIT(5),
        ATH9K_HW_CAP_EDMA                       = BIT(6),
@@ -195,17 +194,11 @@ enum ath9k_hw_caps {
 struct ath9k_hw_capabilities {
        u32 hw_caps; /* ATH9K_HW_CAP_* from ath9k_hw_caps */
-        u16 total_queues;
-        u16 keycache_size;
-        u16 low_5ghz_chan, high_5ghz_chan;
-        u16 low_2ghz_chan, high_2ghz_chan;
        u16 rts_aggr_limit;
        u8 tx_chainmask;
        u8 rx_chainmask;
        u8 max_txchains;
        u8 max_rxchains;
-        u16 tx_triglevel_max;
-        u16 reg_cap;
        u8 num_gpio_pins;
        u8 rx_hp_qdepth;
        u8 rx_lp_qdepth;
@@ -227,7 +220,6 @@ struct ath9k_ops_config {
        u8 pcie_clock_req;
        u32 pcie_waen;
        u8 analog_shiftreg;
-        u8 ht_enable;
        u8 paprd_disable;
        u32 ofdm_trig_low;
        u32 ofdm_trig_high;
@@ -412,8 +404,6 @@ struct ath9k_beacon_state {
        u32 bs_nextdtim;
        u32 bs_intval;
 #define ATH9K_BEACON_PERIOD       0x0000ffff
-#define ATH9K_BEACON_ENA          0x00800000
-#define ATH9K_BEACON_RESET_TSF    0x01000000
 #define ATH9K_TSFOOR_THRESHOLD    0x00004240 /* 16k us */
        u32 bs_dtimperiod;
        u16 bs_cfpperiod;
@@ -489,6 +479,10 @@ struct ath_hw_antcomb_conf {
        u8 main_lna_conf;
        u8 alt_lna_conf;
        u8 fast_div_bias;
+        u8 main_gaintb;
+        u8 alt_gaintb;
+        int lna1_lna2_delta;
+        u8 div_group;
 };
 /**
@@ -638,10 +632,12 @@ struct ath_hw_ops {
                                   u32 numDelims);
        void (*set11n_aggr_last)(struct ath_hw *ah, void *ds);
        void (*clr11n_aggr)(struct ath_hw *ah, void *ds);
-        void (*set11n_burstduration)(struct ath_hw *ah, void *ds,
+        void (*set_clrdmask)(struct ath_hw *ah, void *ds, bool val);
-                                     u32 burstDuration);
+        void (*antdiv_comb_conf_get)(struct ath_hw *ah,
-        void (*set11n_virtualmorefrag)(struct ath_hw *ah, void *ds,
+                        struct ath_hw_antcomb_conf *antconf);
-                                       u32 vmf);
+        void (*antdiv_comb_conf_set)(struct ath_hw *ah,
+                        struct ath_hw_antcomb_conf *antconf);
 };
 struct ath_nf_limits {
@@ -655,6 +651,8 @@ struct ath_nf_limits {
 #define AH_UNPLUGGED    0x2 /* The card has been physically removed. */
 struct ath_hw {
+        struct ath_ops reg_ops;
        struct ieee80211_hw *hw;
        struct ath_common common;
        struct ath9k_hw_version hw_version;
@@ -784,6 +782,8 @@ struct ath_hw {
        /* Bluetooth coexistance */
        struct ath_btcoex_hw btcoex_hw;
+        u32 bt_coex_bt_weight[AR9300_NUM_BT_WEIGHTS];
+        u32 bt_coex_wlan_weight[AR9300_NUM_WLAN_WEIGHTS];
        u32 intr_txqs;
        u8 txchainmask;
@@ -794,7 +794,9 @@ struct ath_hw {
        u32 originalGain[22];
        int initPDADC;
        int PDADCdelta;
-        u8 led_pin;
+        int led_pin;
+        u32 gpio_mask;
+        u32 gpio_val;
        struct ar5416IniArray iniModes;
        struct ar5416IniArray iniCommon;
@@ -810,6 +812,7 @@ struct ath_hw {
        struct ar5416IniArray iniPcieSerdes;
        struct ar5416IniArray iniPcieSerdesLowPower;
        struct ar5416IniArray iniModesAdditional;
+        struct ar5416IniArray iniModesAdditional_40M;
        struct ar5416IniArray iniModesRxGain;
        struct ar5416IniArray iniModesTxGain;
        struct ar5416IniArray iniModes_9271_1_0_only;
@@ -856,6 +859,16 @@ struct ath_hw {
        /* Enterprise mode cap */
        u32 ent_mode;
+        bool is_clk_25mhz;
+};
+struct ath_bus_ops {
+        enum ath_bus_type ath_bus_type;
+        void (*read_cachesize)(struct ath_common *common, int *csz);
+        bool (*eeprom_read)(struct ath_common *common, u32 off, u16 *data);
+        void (*bt_coex_prep)(struct ath_common *common);
+        void (*extn_synch_en)(struct ath_common *common);
 };
 static inline struct ath_common *ath9k_hw_common(struct ath_hw *ah)
@@ -900,15 +913,12 @@ void ath9k_hw_cfg_output(struct ath_hw *ah, u32 gpio,
 void ath9k_hw_set_gpio(struct ath_hw *ah, u32 gpio, u32 val);
 u32 ath9k_hw_getdefantenna(struct ath_hw *ah);
 void ath9k_hw_setantenna(struct ath_hw *ah, u32 antenna);
-void ath9k_hw_antdiv_comb_conf_get(struct ath_hw *ah,
-                                   struct ath_hw_antcomb_conf *antconf);
-void ath9k_hw_antdiv_comb_conf_set(struct ath_hw *ah,
-                                   struct ath_hw_antcomb_conf *antconf);
 /* General Operation */
 bool ath9k_hw_wait(struct ath_hw *ah, u32 reg, u32 mask, u32 val, u32 timeout);
+void ath9k_hw_write_array(struct ath_hw *ah, struct ar5416IniArray *array,
+                          int column, unsigned int *writecnt);
 u32 ath9k_hw_reverse_bits(u32 val, u32 n);
-bool ath9k_get_channel_edges(struct ath_hw *ah, u16 flags, u16 *low, u16 *high);
 u16 ath9k_hw_computetxtime(struct ath_hw *ah,
                           u8 phy, int kbps,
                           u32 frameLen, u16 rateix, bool shortPreamble);
@@ -924,12 +934,13 @@ void ath9k_hw_setopmode(struct ath_hw *ah);
 void ath9k_hw_setmcastfilter(struct ath_hw *ah, u32 filter0, u32 filter1);
 void ath9k_hw_setbssidmask(struct ath_hw *ah);
 void ath9k_hw_write_associd(struct ath_hw *ah);
+u32 ath9k_hw_gettsf32(struct ath_hw *ah);
 u64 ath9k_hw_gettsf64(struct ath_hw *ah);
 void ath9k_hw_settsf64(struct ath_hw *ah, u64 tsf64);
 void ath9k_hw_reset_tsf(struct ath_hw *ah);
 void ath9k_hw_set_tsfadjust(struct ath_hw *ah, u32 setting);
 void ath9k_hw_init_global_settings(struct ath_hw *ah);
-unsigned long ar9003_get_pll_sqsum_dvc(struct ath_hw *ah);
+u32 ar9003_get_pll_sqsum_dvc(struct ath_hw *ah);
 void ath9k_hw_set11nmac2040(struct ath_hw *ah);
 void ath9k_hw_beaconinit(struct ath_hw *ah, u32 next_beacon, u32 beacon_period);
 void ath9k_hw_set_sta_beacon_timers(struct ath_hw *ah,
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 79aec983279f..b172d1509515 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -15,6 +15,7 @@
 */
 #include <linux/slab.h>
+#include <linux/ath9k_platform.h>
 #include "ath9k.h"
@@ -195,10 +196,27 @@ static unsigned int ath9k_ioread32(void *hw_priv, u32 reg_offset)
        return val;
 }
-static const struct ath_ops ath9k_common_ops = {
+static unsigned int ath9k_reg_rmw(void *hw_priv, u32 reg_offset, u32 set, u32 clr)
-        .read = ath9k_ioread32,
+{
-        .write = ath9k_iowrite32,
+        struct ath_hw *ah = (struct ath_hw *) hw_priv;
-};
+        struct ath_common *common = ath9k_hw_common(ah);
+        struct ath_softc *sc = (struct ath_softc *) common->priv;
+        unsigned long uninitialized_var(flags);
+        u32 val;
+        if (ah->config.serialize_regmode == SER_REG_MODE_ON)
+                spin_lock_irqsave(&sc->sc_serial_rw, flags);
+        val = ioread32(sc->mem + reg_offset);
+        val &= ~clr;
+        val |= set;
+        iowrite32(val, sc->mem + reg_offset);
+        if (ah->config.serialize_regmode == SER_REG_MODE_ON)
+                spin_unlock_irqrestore(&sc->sc_serial_rw, flags);
+        return val;
+}
 /**************************/
 /*     Initialization     */
@@ -389,13 +407,7 @@ void ath9k_init_crypto(struct ath_softc *sc)
        int i = 0;
        /* Get the hardware key cache size. */
-        common->keymax = sc->sc_ah->caps.keycache_size;
+        common->keymax = AR_KEYTABLE_SIZE;
-        if (common->keymax > ATH_KEYMAX) {
-                ath_dbg(common, ATH_DBG_ANY,
-                        "Warning, using only %u entries in %u key cache\n",
-                        ATH_KEYMAX, common->keymax);
-                common->keymax = ATH_KEYMAX;
-        }
        /*
         * Reset the key cache since some parts do not
@@ -537,6 +549,7 @@ static void ath9k_init_misc(struct ath_softc *sc)
 static int ath9k_init_softc(u16 devid, struct ath_softc *sc, u16 subsysid,
                            const struct ath_bus_ops *bus_ops)
 {
+        struct ath9k_platform_data *pdata = sc->dev->platform_data;
        struct ath_hw *ah = NULL;
        struct ath_common *common;
        int ret = 0, i;
@@ -549,13 +562,23 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc, u16 subsysid,
        ah->hw = sc->hw;
        ah->hw_version.devid = devid;
        ah->hw_version.subsysid = subsysid;
+        ah->reg_ops.read = ath9k_ioread32;
+        ah->reg_ops.write = ath9k_iowrite32;
+        ah->reg_ops.rmw = ath9k_reg_rmw;
        sc->sc_ah = ah;
-        if (!sc->dev->platform_data)
+        if (!pdata) {
                ah->ah_flags |= AH_USE_EEPROM;
+                sc->sc_ah->led_pin = -1;
+        } else {
+                sc->sc_ah->gpio_mask = pdata->gpio_mask;
+                sc->sc_ah->gpio_val = pdata->gpio_val;
+                sc->sc_ah->led_pin = pdata->led_pin;
+                ah->is_clk_25mhz = pdata->is_clk_25mhz;
+        }
        common = ath9k_hw_common(ah);
-        common->ops = &ath9k_common_ops;
+        common->ops = &ah->reg_ops;
        common->bus_ops = bus_ops;
        common->ah = ah;
        common->hw = sc->hw;
@@ -587,6 +610,9 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc, u16 subsysid,
        if (ret)
                goto err_hw;
+        if (pdata && pdata->macaddr)
+                memcpy(common->macaddr, pdata->macaddr, ETH_ALEN);
        ret = ath9k_init_queues(sc);
        if (ret)
                goto err_queues;
@@ -679,6 +705,8 @@ void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
        if (AR_SREV_5416(sc->sc_ah))
                hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
+        hw->wiphy->flags |= WIPHY_FLAG_IBSS_RSN;
        hw->queues = 4;
        hw->max_rates = 4;
        hw->channel_change_time = 5000;
@@ -773,6 +801,7 @@ int ath9k_init_device(u16 devid, struct ath_softc *sc, u16 subsysid,
        INIT_WORK(&sc->hw_check_work, ath_hw_check);
        INIT_WORK(&sc->paprd_work, ath_paprd_calibrate);
+        INIT_DELAYED_WORK(&sc->hw_pll_work, ath_hw_pll_work);
        sc->last_rssi = ATH_RSSI_DUMMY_MARKER;
        ath_init_leds(sc);
diff --git a/drivers/net/wireless/ath/ath9k/mac.c b/drivers/net/wireless/ath/ath9k/mac.c
index edc1cbbfecaf..bd6d2b9d736f 100644
--- a/drivers/net/wireless/ath/ath9k/mac.c
+++ b/drivers/net/wireless/ath/ath9k/mac.c
@@ -209,15 +209,8 @@ bool ath9k_hw_set_txq_props(struct ath_hw *ah, int q,
 {
        u32 cw;
        struct ath_common *common = ath9k_hw_common(ah);
-        struct ath9k_hw_capabilities *pCap = &ah->caps;
        struct ath9k_tx_queue_info *qi;
-        if (q >= pCap->total_queues) {
-                ath_dbg(common, ATH_DBG_QUEUE,
-                        "Set TXQ properties, invalid queue: %u\n", q);
-                return false;
-        }
        qi = &ah->txq[q];
        if (qi->tqi_type == ATH9K_TX_QUEUE_INACTIVE) {
                ath_dbg(common, ATH_DBG_QUEUE,
@@ -280,15 +273,8 @@ bool ath9k_hw_get_txq_props(struct ath_hw *ah, int q,
                            struct ath9k_tx_queue_info *qinfo)
 {
        struct ath_common *common = ath9k_hw_common(ah);
-        struct ath9k_hw_capabilities *pCap = &ah->caps;
        struct ath9k_tx_queue_info *qi;
-        if (q >= pCap->total_queues) {
-                ath_dbg(common, ATH_DBG_QUEUE,
-                        "Get TXQ properties, invalid queue: %u\n", q);
-                return false;
-        }
        qi = &ah->txq[q];
        if (qi->tqi_type == ATH9K_TX_QUEUE_INACTIVE) {
                ath_dbg(common, ATH_DBG_QUEUE,
@@ -320,28 +306,27 @@ int ath9k_hw_setuptxqueue(struct ath_hw *ah, enum ath9k_tx_queue type,
 {
        struct ath_common *common = ath9k_hw_common(ah);
        struct ath9k_tx_queue_info *qi;
-        struct ath9k_hw_capabilities *pCap = &ah->caps;
        int q;
        switch (type) {
        case ATH9K_TX_QUEUE_BEACON:
-                q = pCap->total_queues - 1;
+                q = ATH9K_NUM_TX_QUEUES - 1;
                break;
        case ATH9K_TX_QUEUE_CAB:
-                q = pCap->total_queues - 2;
+                q = ATH9K_NUM_TX_QUEUES - 2;
                break;
        case ATH9K_TX_QUEUE_PSPOLL:
                q = 1;
                break;
        case ATH9K_TX_QUEUE_UAPSD:
-                q = pCap->total_queues - 3;
+                q = ATH9K_NUM_TX_QUEUES - 3;
                break;
        case ATH9K_TX_QUEUE_DATA:
-                for (q = 0; q < pCap->total_queues; q++)
+                for (q = 0; q < ATH9K_NUM_TX_QUEUES; q++)
                        if (ah->txq[q].tqi_type ==
                            ATH9K_TX_QUEUE_INACTIVE)
                                break;
-                if (q == pCap->total_queues) {
+                if (q == ATH9K_NUM_TX_QUEUES) {
                        ath_err(common, "No available TX queue\n");
                        return -1;
                }
@@ -382,15 +367,9 @@ EXPORT_SYMBOL(ath9k_hw_setuptxqueue);
 bool ath9k_hw_releasetxqueue(struct ath_hw *ah, u32 q)
 {
-        struct ath9k_hw_capabilities *pCap = &ah->caps;
        struct ath_common *common = ath9k_hw_common(ah);
        struct ath9k_tx_queue_info *qi;
-        if (q >= pCap->total_queues) {
-                ath_dbg(common, ATH_DBG_QUEUE,
-                        "Release TXQ, invalid queue: %u\n", q);
-                return false;
-        }
        qi = &ah->txq[q];
        if (qi->tqi_type == ATH9K_TX_QUEUE_INACTIVE) {
                ath_dbg(common, ATH_DBG_QUEUE,
@@ -414,18 +393,11 @@ EXPORT_SYMBOL(ath9k_hw_releasetxqueue);
 bool ath9k_hw_resettxqueue(struct ath_hw *ah, u32 q)
 {
-        struct ath9k_hw_capabilities *pCap = &ah->caps;
        struct ath_common *common = ath9k_hw_common(ah);
        struct ath9k_channel *chan = ah->curchan;
        struct ath9k_tx_queue_info *qi;
        u32 cwMin, chanCwMin, value;
-        if (q >= pCap->total_queues) {
-                ath_dbg(common, ATH_DBG_QUEUE,
-                        "Reset TXQ, invalid queue: %u\n", q);
-                return false;
-        }
        qi = &ah->txq[q];
        if (qi->tqi_type == ATH9K_TX_QUEUE_INACTIVE) {
                ath_dbg(common, ATH_DBG_QUEUE,
@@ -458,17 +430,21 @@ bool ath9k_hw_resettxqueue(struct ath_hw *ah, u32 q)
                  SM(qi->tqi_shretry, AR_D_RETRY_LIMIT_FR_SH));
        REG_WRITE(ah, AR_QMISC(q), AR_Q_MISC_DCU_EARLY_TERM_REQ);
-        REG_WRITE(ah, AR_DMISC(q),
-                  AR_D_MISC_CW_BKOFF_EN | AR_D_MISC_FRAG_WAIT_EN | 0x2);
+        if (AR_SREV_9340(ah))
+                REG_WRITE(ah, AR_DMISC(q),
+                          AR_D_MISC_CW_BKOFF_EN | AR_D_MISC_FRAG_WAIT_EN | 0x1);
+        else
+                REG_WRITE(ah, AR_DMISC(q),
+                          AR_D_MISC_CW_BKOFF_EN | AR_D_MISC_FRAG_WAIT_EN | 0x2);
        if (qi->tqi_cbrPeriod) {
                REG_WRITE(ah, AR_QCBRCFG(q),
                          SM(qi->tqi_cbrPeriod, AR_Q_CBRCFG_INTERVAL) |
                          SM(qi->tqi_cbrOverflowLimit, AR_Q_CBRCFG_OVF_THRESH));
-                REG_WRITE(ah, AR_QMISC(q),
+                REG_SET_BIT(ah, AR_QMISC(q), AR_Q_MISC_FSP_CBR |
-                          REG_READ(ah, AR_QMISC(q)) | AR_Q_MISC_FSP_CBR |
+                            (qi->tqi_cbrOverflowLimit ?
-                          (qi->tqi_cbrOverflowLimit ?
+                             AR_Q_MISC_CBR_EXP_CNTR_LIMIT_EN : 0));
-                           AR_Q_MISC_CBR_EXP_CNTR_LIMIT_EN : 0));
        }
        if (qi->tqi_readyTime && (qi->tqi_type != ATH9K_TX_QUEUE_CAB)) {
                REG_WRITE(ah, AR_QRDYTIMECFG(q),
@@ -481,40 +457,31 @@ bool ath9k_hw_resettxqueue(struct ath_hw *ah, u32 q)
                  (qi->tqi_burstTime ? AR_D_CHNTIME_EN : 0));
        if (qi->tqi_burstTime
-            && (qi->tqi_qflags & TXQ_FLAG_RDYTIME_EXP_POLICY_ENABLE)) {
+            && (qi->tqi_qflags & TXQ_FLAG_RDYTIME_EXP_POLICY_ENABLE))
-                REG_WRITE(ah, AR_QMISC(q),
+                REG_SET_BIT(ah, AR_QMISC(q), AR_Q_MISC_RDYTIME_EXP_POLICY);
-                          REG_READ(ah, AR_QMISC(q)) |
-                          AR_Q_MISC_RDYTIME_EXP_POLICY);
-        }
+        if (qi->tqi_qflags & TXQ_FLAG_BACKOFF_DISABLE)
+                REG_SET_BIT(ah, AR_DMISC(q), AR_D_MISC_POST_FR_BKOFF_DIS);
-        if (qi->tqi_qflags & TXQ_FLAG_BACKOFF_DISABLE) {
-                REG_WRITE(ah, AR_DMISC(q),
-                          REG_READ(ah, AR_DMISC(q)) |
-                          AR_D_MISC_POST_FR_BKOFF_DIS);
-        }
        REGWRITE_BUFFER_FLUSH(ah);
-        if (qi->tqi_qflags & TXQ_FLAG_FRAG_BURST_BACKOFF_ENABLE) {
+        if (qi->tqi_qflags & TXQ_FLAG_FRAG_BURST_BACKOFF_ENABLE)
-                REG_WRITE(ah, AR_DMISC(q),
+                REG_SET_BIT(ah, AR_DMISC(q), AR_D_MISC_FRAG_BKOFF_EN);
-                          REG_READ(ah, AR_DMISC(q)) |
-                          AR_D_MISC_FRAG_BKOFF_EN);
-        }
        switch (qi->tqi_type) {
        case ATH9K_TX_QUEUE_BEACON:
                ENABLE_REGWRITE_BUFFER(ah);
-                REG_WRITE(ah, AR_QMISC(q), REG_READ(ah, AR_QMISC(q))
+                REG_SET_BIT(ah, AR_QMISC(q),
-                          | AR_Q_MISC_FSP_DBA_GATED
+                            AR_Q_MISC_FSP_DBA_GATED
-                          | AR_Q_MISC_BEACON_USE
+                            | AR_Q_MISC_BEACON_USE
-                          | AR_Q_MISC_CBR_INCR_DIS1);
+                            | AR_Q_MISC_CBR_INCR_DIS1);
-                REG_WRITE(ah, AR_DMISC(q), REG_READ(ah, AR_DMISC(q))
+                REG_SET_BIT(ah, AR_DMISC(q),
-                          | (AR_D_MISC_ARB_LOCKOUT_CNTRL_GLOBAL <<
+                            (AR_D_MISC_ARB_LOCKOUT_CNTRL_GLOBAL <<
                             AR_D_MISC_ARB_LOCKOUT_CNTRL_S)
-                          | AR_D_MISC_BEACON_USE
+                            | AR_D_MISC_BEACON_USE
-                          | AR_D_MISC_POST_FR_BKOFF_DIS);
+                            | AR_D_MISC_POST_FR_BKOFF_DIS);
                REGWRITE_BUFFER_FLUSH(ah);
@@ -533,41 +500,38 @@ bool ath9k_hw_resettxqueue(struct ath_hw *ah, u32 q)
        case ATH9K_TX_QUEUE_CAB:
                ENABLE_REGWRITE_BUFFER(ah);
-                REG_WRITE(ah, AR_QMISC(q), REG_READ(ah, AR_QMISC(q))
+                REG_SET_BIT(ah, AR_QMISC(q),
-                          | AR_Q_MISC_FSP_DBA_GATED
+                            AR_Q_MISC_FSP_DBA_GATED
-                          | AR_Q_MISC_CBR_INCR_DIS1
+                            | AR_Q_MISC_CBR_INCR_DIS1
-                          | AR_Q_MISC_CBR_INCR_DIS0);
+                            | AR_Q_MISC_CBR_INCR_DIS0);
                value = (qi->tqi_readyTime -
                         (ah->config.sw_beacon_response_time -
                          ah->config.dma_beacon_response_time) -
                         ah->config.additional_swba_backoff) * 1024;
                REG_WRITE(ah, AR_QRDYTIMECFG(q),
                          value | AR_Q_RDYTIMECFG_EN);
-                REG_WRITE(ah, AR_DMISC(q), REG_READ(ah, AR_DMISC(q))
+                REG_SET_BIT(ah, AR_DMISC(q),
-                          | (AR_D_MISC_ARB_LOCKOUT_CNTRL_GLOBAL <<
+                            (AR_D_MISC_ARB_LOCKOUT_CNTRL_GLOBAL <<
                             AR_D_MISC_ARB_LOCKOUT_CNTRL_S));
                REGWRITE_BUFFER_FLUSH(ah);
                break;
        case ATH9K_TX_QUEUE_PSPOLL:
-                REG_WRITE(ah, AR_QMISC(q),
+                REG_SET_BIT(ah, AR_QMISC(q), AR_Q_MISC_CBR_INCR_DIS1);
-                          REG_READ(ah, AR_QMISC(q)) | AR_Q_MISC_CBR_INCR_DIS1);
                break;
        case ATH9K_TX_QUEUE_UAPSD:
-                REG_WRITE(ah, AR_DMISC(q), REG_READ(ah, AR_DMISC(q)) |
+                REG_SET_BIT(ah, AR_DMISC(q), AR_D_MISC_POST_FR_BKOFF_DIS);
-                          AR_D_MISC_POST_FR_BKOFF_DIS);
                break;
        default:
                break;
        }
        if (qi->tqi_intFlags & ATH9K_TXQ_USE_LOCKOUT_BKOFF_DIS) {
-                REG_WRITE(ah, AR_DMISC(q),
+                REG_SET_BIT(ah, AR_DMISC(q),
-                          REG_READ(ah, AR_DMISC(q)) |
+                            SM(AR_D_MISC_ARB_LOCKOUT_CNTRL_GLOBAL,
-                          SM(AR_D_MISC_ARB_LOCKOUT_CNTRL_GLOBAL,
+                               AR_D_MISC_ARB_LOCKOUT_CNTRL) |
-                             AR_D_MISC_ARB_LOCKOUT_CNTRL) |
+                            AR_D_MISC_POST_FR_BKOFF_DIS);
-                          AR_D_MISC_POST_FR_BKOFF_DIS);
        }
        if (AR_SREV_9300_20_OR_LATER(ah))
@@ -754,7 +718,6 @@ EXPORT_SYMBOL(ath9k_hw_abortpcurecv);
 bool ath9k_hw_stopdmarecv(struct ath_hw *ah, bool *reset)
 {
 #define AH_RX_STOP_DMA_TIMEOUT 10000   /* usec */
-#define AH_RX_TIME_QUANTUM     100     /* usec */
        struct ath_common *common = ath9k_hw_common(ah);
        u32 mac_status, last_mac_status = 0;
        int i;
@@ -797,7 +760,6 @@ bool ath9k_hw_stopdmarecv(struct ath_hw *ah, bool *reset)
                return true;
        }
-#undef AH_RX_TIME_QUANTUM
 #undef AH_RX_STOP_DMA_TIMEOUT
 }
 EXPORT_SYMBOL(ath9k_hw_stopdmarecv);
@@ -855,10 +817,14 @@ EXPORT_SYMBOL(ath9k_hw_disable_interrupts);
 void ath9k_hw_enable_interrupts(struct ath_hw *ah)
 {
        struct ath_common *common = ath9k_hw_common(ah);
+        u32 sync_default = AR_INTR_SYNC_DEFAULT;
        if (!(ah->imask & ATH9K_INT_GLOBAL))
                return;
+        if (AR_SREV_9340(ah))
+                sync_default &= ~AR_INTR_SYNC_HOST1_FATAL;
        ath_dbg(common, ATH_DBG_INTERRUPT, "enable IER\n");
        REG_WRITE(ah, AR_IER, AR_IER_ENABLE);
        if (!AR_SREV_9100(ah)) {
@@ -867,10 +833,8 @@ void ath9k_hw_enable_interrupts(struct ath_hw *ah)
                REG_WRITE(ah, AR_INTR_ASYNC_MASK, AR_INTR_MAC_IRQ);
-                REG_WRITE(ah, AR_INTR_SYNC_ENABLE,
+                REG_WRITE(ah, AR_INTR_SYNC_ENABLE, sync_default);
-                          AR_INTR_SYNC_DEFAULT);
+                REG_WRITE(ah, AR_INTR_SYNC_MASK, sync_default);
-                REG_WRITE(ah, AR_INTR_SYNC_MASK,
-                          AR_INTR_SYNC_DEFAULT);
        }
        ath_dbg(common, ATH_DBG_INTERRUPT, "AR_IMR 0x%x IER 0x%x\n",
                REG_READ(ah, AR_IMR), REG_READ(ah, AR_IER));
@@ -926,6 +890,9 @@ void ath9k_hw_set_interrupts(struct ath_hw *ah, enum ath9k_int ints)
                        mask |= AR_IMR_GENTMR;
        }
+        if (ints & ATH9K_INT_GENTIMER)
+                mask |= AR_IMR_GENTMR;
        if (ints & (ATH9K_INT_BMISC)) {
                mask |= AR_IMR_BCNMISC;
                if (ints & ATH9K_INT_TIM)
diff --git a/drivers/net/wireless/ath/ath9k/mac.h b/drivers/net/wireless/ath/ath9k/mac.h
index c2a59386fb9c..b60c130917f7 100644
--- a/drivers/net/wireless/ath/ath9k/mac.h
+++ b/drivers/net/wireless/ath/ath9k/mac.h
@@ -239,7 +239,6 @@ struct ath_desc {
        void *ds_vdata;
 } __packed __aligned(4);
-#define ATH9K_TXDESC_CLRDMASK           0x0001
 #define ATH9K_TXDESC_NOACK              0x0002
 #define ATH9K_TXDESC_RTSENA             0x0004
 #define ATH9K_TXDESC_CTSENA             0x0008
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 1482fa650833..17ebdf1e8b7b 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -299,7 +299,7 @@ int ath_set_channel(struct ath_softc *sc, struct ieee80211_hw *hw,
        if (!(sc->sc_flags & (SC_OP_OFFCHANNEL))) {
                if (sc->sc_flags & SC_OP_BEACONS)
-                        ath_beacon_config(sc, NULL);
+                        ath_set_beacon(sc);
                ieee80211_queue_delayed_work(sc->hw, &sc->tx_complete_work, 0);
                ieee80211_queue_delayed_work(sc->hw, &sc->hw_pll_work, HZ/2);
                ath_start_ani(common);
@@ -624,6 +624,43 @@ out:
        ath9k_ps_restore(sc);
 }
+static void ath_hw_pll_rx_hang_check(struct ath_softc *sc, u32 pll_sqsum)
+{
+        static int count;
+        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+        if (pll_sqsum >= 0x40000) {
+                count++;
+                if (count == 3) {
+                        /* Rx is hung for more than 500ms. Reset it */
+                        ath_dbg(common, ATH_DBG_RESET,
+                                "Possible RX hang, resetting");
+                        ath_reset(sc, true);
+                        count = 0;
+                }
+        } else
+                count = 0;
+}
+void ath_hw_pll_work(struct work_struct *work)
+{
+        struct ath_softc *sc = container_of(work, struct ath_softc,
+                                            hw_pll_work.work);
+        u32 pll_sqsum;
+        if (AR_SREV_9485(sc->sc_ah)) {
+                ath9k_ps_wakeup(sc);
+                pll_sqsum = ar9003_get_pll_sqsum_dvc(sc->sc_ah);
+                ath9k_ps_restore(sc);
+                ath_hw_pll_rx_hang_check(sc, pll_sqsum);
+                ieee80211_queue_delayed_work(sc->hw, &sc->hw_pll_work, HZ/5);
+        }
+}
 void ath9k_tasklet(unsigned long data)
 {
        struct ath_softc *sc = (struct ath_softc *)data;
@@ -652,6 +689,17 @@ void ath9k_tasklet(unsigned long data)
            !ath9k_hw_check_alive(ah))
                ieee80211_queue_work(sc->hw, &sc->hw_check_work);
+        if ((status & ATH9K_INT_TSFOOR) && sc->ps_enabled) {
+                /*
+                 * TSF sync does not look correct; remain awake to sync with
+                 * the next Beacon.
+                 */
+                ath_dbg(common, ATH_DBG_PS,
+                        "TSFOOR - Sync with next Beacon\n");
+                sc->ps_flags |= PS_WAIT_FOR_BEACON | PS_BEACON_SYNC |
+                                PS_TSFOOR_SYNC;
+        }
        if (ah->caps.hw_caps & ATH9K_HW_CAP_EDMA)
                rxmask = (ATH9K_INT_RXHP | ATH9K_INT_RXLP | ATH9K_INT_RXEOL |
                          ATH9K_INT_RXORN);
@@ -674,16 +722,6 @@ void ath9k_tasklet(unsigned long data)
                        ath_tx_tasklet(sc);
        }
-        if ((status & ATH9K_INT_TSFOOR) && sc->ps_enabled) {
-                /*
-                 * TSF sync does not look correct; remain awake to sync with
-                 * the next Beacon.
-                 */
-                ath_dbg(common, ATH_DBG_PS,
-                        "TSFOOR - Sync with next Beacon\n");
-                sc->ps_flags |= PS_WAIT_FOR_BEACON | PS_BEACON_SYNC;
-        }
        if (ah->btcoex_hw.scheme == ATH_BTCOEX_CFG_3WIRE)
                if (status & ATH9K_INT_GENTIMER)
                        ath_gen_timer_isr(sc->sc_ah);
@@ -828,48 +866,6 @@ chip_reset:
 #undef SCHED_INTR
 }
-static void ath9k_bss_assoc_info(struct ath_softc *sc,
-                                 struct ieee80211_hw *hw,
-                                 struct ieee80211_vif *vif,
-                                 struct ieee80211_bss_conf *bss_conf)
-{
-        struct ath_hw *ah = sc->sc_ah;
-        struct ath_common *common = ath9k_hw_common(ah);
-        if (bss_conf->assoc) {
-                ath_dbg(common, ATH_DBG_CONFIG,
-                        "Bss Info ASSOC %d, bssid: %pM\n",
-                        bss_conf->aid, common->curbssid);
-                /* New association, store aid */
-                common->curaid = bss_conf->aid;
-                ath9k_hw_write_associd(ah);
-                /*
-                 * Request a re-configuration of Beacon related timers
-                 * on the receipt of the first Beacon frame (i.e.,
-                 * after time sync with the AP).
-                 */
-                sc->ps_flags |= PS_BEACON_SYNC;
-                /* Configure the beacon */
-                ath_beacon_config(sc, vif);
-                /* Reset rssi stats */
-                sc->last_rssi = ATH_RSSI_DUMMY_MARKER;
-                sc->sc_ah->stats.avgbrssi = ATH_RSSI_DUMMY_MARKER;
-                sc->sc_flags |= SC_OP_ANI_RUN;
-                ath_start_ani(common);
-        } else {
-                ath_dbg(common, ATH_DBG_CONFIG, "Bss Info DISASSOC\n");
-                common->curaid = 0;
-                /* Stop ANI */
-                sc->sc_flags &= ~SC_OP_ANI_RUN;
-                del_timer_sync(&common->ani.timer);
-        }
-}
 void ath_radio_enable(struct ath_softc *sc, struct ieee80211_hw *hw)
 {
        struct ath_hw *ah = sc->sc_ah;
@@ -899,7 +895,7 @@ void ath_radio_enable(struct ath_softc *sc, struct ieee80211_hw *hw)
                goto out;
        }
        if (sc->sc_flags & SC_OP_BEACONS)
-                ath_beacon_config(sc, NULL);    /* restart beacons */
+                ath_set_beacon(sc);     /* restart beacons */
        /* Re-Enable  interrupts */
        ath9k_hw_set_interrupts(ah, ah->imask);
@@ -1006,7 +1002,7 @@ int ath_reset(struct ath_softc *sc, bool retry_tx)
                               sc->config.txpowlimit, &sc->curtxpow);
        if ((sc->sc_flags & SC_OP_BEACONS) || !(sc->sc_flags & (SC_OP_OFFCHANNEL)))
-                ath_beacon_config(sc, NULL);    /* restart beacons */
+                ath_set_beacon(sc);     /* restart beacons */
        ath9k_hw_set_interrupts(ah, ah->imask);
@@ -1389,7 +1385,9 @@ static void ath9k_calculate_summary_state(struct ieee80211_hw *hw,
                ath9k_hw_set_tsfadjust(ah, 0);
                sc->sc_flags &= ~SC_OP_TSF_RESET;
-                if (iter_data.nwds + iter_data.nmeshes)
+                if (iter_data.nmeshes)
+                        ah->opmode = NL80211_IFTYPE_MESH_POINT;
+                else if (iter_data.nwds)
                        ah->opmode = NL80211_IFTYPE_AP;
                else if (iter_data.nadhocs)
                        ah->opmode = NL80211_IFTYPE_ADHOC;
@@ -1413,6 +1411,7 @@ static void ath9k_calculate_summary_state(struct ieee80211_hw *hw,
        /* Set up ANI */
        if ((iter_data.naps + iter_data.nadhocs) > 0) {
+                sc->sc_ah->stats.avgbrssi = ATH_RSSI_DUMMY_MARKER;
                sc->sc_flags |= SC_OP_ANI_RUN;
                ath_start_ani(common);
        } else {
@@ -1452,7 +1451,6 @@ static int ath9k_add_interface(struct ieee80211_hw *hw,
        struct ath_softc *sc = hw->priv;
        struct ath_hw *ah = sc->sc_ah;
        struct ath_common *common = ath9k_hw_common(ah);
-        struct ath_vif *avp = (void *)vif->drv_priv;
        int ret = 0;
        ath9k_ps_wakeup(sc);
@@ -1482,8 +1480,9 @@ static int ath9k_add_interface(struct ieee80211_hw *hw,
                }
        }
-        if ((vif->type == NL80211_IFTYPE_ADHOC) &&
+        if ((ah->opmode == NL80211_IFTYPE_ADHOC) ||
-            sc->nvifs > 0) {
+            ((vif->type == NL80211_IFTYPE_ADHOC) &&
+             sc->nvifs > 0)) {
                ath_err(common, "Cannot create ADHOC interface when other"
                        " interfaces already exist.\n");
                ret = -EINVAL;
@@ -1493,10 +1492,6 @@ static int ath9k_add_interface(struct ieee80211_hw *hw,
        ath_dbg(common, ATH_DBG_CONFIG,
                "Attach a VIF of type: %d\n", vif->type);
-        /* Set the VIF opmode */
-        avp->av_opmode = vif->type;
-        avp->av_bslot = -1;
        sc->nvifs++;
        ath9k_do_vif_add_setup(hw, vif);
@@ -1782,23 +1777,68 @@ static int ath9k_sta_add(struct ieee80211_hw *hw,
                         struct ieee80211_sta *sta)
 {
        struct ath_softc *sc = hw->priv;
+        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+        struct ath_node *an = (struct ath_node *) sta->drv_priv;
+        struct ieee80211_key_conf ps_key = { };
        ath_node_attach(sc, sta);
+        if (vif->type != NL80211_IFTYPE_AP &&
+            vif->type != NL80211_IFTYPE_AP_VLAN)
+                return 0;
+        an->ps_key = ath_key_config(common, vif, sta, &ps_key);
        return 0;
 }
+static void ath9k_del_ps_key(struct ath_softc *sc,
+                             struct ieee80211_vif *vif,
+                             struct ieee80211_sta *sta)
+{
+        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+        struct ath_node *an = (struct ath_node *) sta->drv_priv;
+        struct ieee80211_key_conf ps_key = { .hw_key_idx = an->ps_key };
+        if (!an->ps_key)
+            return;
+        ath_key_delete(common, &ps_key);
+}
 static int ath9k_sta_remove(struct ieee80211_hw *hw,
                            struct ieee80211_vif *vif,
                            struct ieee80211_sta *sta)
 {
        struct ath_softc *sc = hw->priv;
+        ath9k_del_ps_key(sc, vif, sta);
        ath_node_detach(sc, sta);
        return 0;
 }
+static void ath9k_sta_notify(struct ieee80211_hw *hw,
+                         struct ieee80211_vif *vif,
+                         enum sta_notify_cmd cmd,
+                         struct ieee80211_sta *sta)
+{
+        struct ath_softc *sc = hw->priv;
+        struct ath_node *an = (struct ath_node *) sta->drv_priv;
+        switch (cmd) {
+        case STA_NOTIFY_SLEEP:
+                an->sleeping = true;
+                if (ath_tx_aggr_sleep(sc, an))
+                        ieee80211_sta_set_tim(sta);
+                break;
+        case STA_NOTIFY_AWAKE:
+                an->sleeping = false;
+                ath_tx_aggr_wakeup(sc, an);
+                break;
+        }
+}
 static int ath9k_conf_tx(struct ieee80211_hw *hw, u16 queue,
                         const struct ieee80211_tx_queue_params *params)
 {
@@ -1855,12 +1895,29 @@ static int ath9k_set_key(struct ieee80211_hw *hw,
        if (ath9k_modparam_nohwcrypt)
                return -ENOSPC;
+        if (vif->type == NL80211_IFTYPE_ADHOC &&
+            (key->cipher == WLAN_CIPHER_SUITE_TKIP ||
+             key->cipher == WLAN_CIPHER_SUITE_CCMP) &&
+            !(key->flags & IEEE80211_KEY_FLAG_PAIRWISE)) {
+                /*
+                 * For now, disable hw crypto for the RSN IBSS group keys. This
+                 * could be optimized in the future to use a modified key cache
+                 * design to support per-STA RX GTK, but until that gets
+                 * implemented, use of software crypto for group addressed
+                 * frames is a acceptable to allow RSN IBSS to be used.
+                 */
+                return -EOPNOTSUPP;
+        }
        mutex_lock(&sc->mutex);
        ath9k_ps_wakeup(sc);
        ath_dbg(common, ATH_DBG_CONFIG, "Set HW Key\n");
        switch (cmd) {
        case SET_KEY:
+                if (sta)
+                        ath9k_del_ps_key(sc, vif, sta);
                ret = ath_key_config(common, vif, sta, key);
                if (ret >= 0) {
                        key->hw_key_idx = ret;
@@ -1886,6 +1943,92 @@ static int ath9k_set_key(struct ieee80211_hw *hw,
        return ret;
 }
+static void ath9k_bss_iter(void *data, u8 *mac, struct ieee80211_vif *vif)
+{
+        struct ath_softc *sc = data;
+        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+        struct ieee80211_bss_conf *bss_conf = &vif->bss_conf;
+        struct ath_vif *avp = (void *)vif->drv_priv;
+        switch (sc->sc_ah->opmode) {
+        case NL80211_IFTYPE_ADHOC:
+                /* There can be only one vif available */
+                memcpy(common->curbssid, bss_conf->bssid, ETH_ALEN);
+                common->curaid = bss_conf->aid;
+                ath9k_hw_write_associd(sc->sc_ah);
+                /* configure beacon */
+                if (bss_conf->enable_beacon)
+                        ath_beacon_config(sc, vif);
+                break;
+        case NL80211_IFTYPE_STATION:
+                /*
+                 * Skip iteration if primary station vif's bss info
+                 * was not changed
+                 */
+                if (sc->sc_flags & SC_OP_PRIM_STA_VIF)
+                        break;
+                if (bss_conf->assoc) {
+                        sc->sc_flags |= SC_OP_PRIM_STA_VIF;
+                        avp->primary_sta_vif = true;
+                        memcpy(common->curbssid, bss_conf->bssid, ETH_ALEN);
+                        common->curaid = bss_conf->aid;
+                        ath9k_hw_write_associd(sc->sc_ah);
+                        ath_dbg(common, ATH_DBG_CONFIG,
+                                "Bss Info ASSOC %d, bssid: %pM\n",
+                                bss_conf->aid, common->curbssid);
+                        ath_beacon_config(sc, vif);
+                        /*
+                         * Request a re-configuration of Beacon related timers
+                         * on the receipt of the first Beacon frame (i.e.,
+                         * after time sync with the AP).
+                         */
+                        sc->ps_flags |= PS_BEACON_SYNC | PS_WAIT_FOR_BEACON;
+                        /* Reset rssi stats */
+                        sc->last_rssi = ATH_RSSI_DUMMY_MARKER;
+                        sc->sc_ah->stats.avgbrssi = ATH_RSSI_DUMMY_MARKER;
+                        sc->sc_flags |= SC_OP_ANI_RUN;
+                        ath_start_ani(common);
+                }
+                break;
+        default:
+                break;
+        }
+}
+static void ath9k_config_bss(struct ath_softc *sc, struct ieee80211_vif *vif)
+{
+        struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+        struct ieee80211_bss_conf *bss_conf = &vif->bss_conf;
+        struct ath_vif *avp = (void *)vif->drv_priv;
+        /* Reconfigure bss info */
+        if (avp->primary_sta_vif && !bss_conf->assoc) {
+                ath_dbg(common, ATH_DBG_CONFIG,
+                        "Bss Info DISASSOC %d, bssid %pM\n",
+                        common->curaid, common->curbssid);
+                sc->sc_flags &= ~(SC_OP_PRIM_STA_VIF | SC_OP_BEACONS);
+                avp->primary_sta_vif = false;
+                memset(common->curbssid, 0, ETH_ALEN);
+                common->curaid = 0;
+        }
+        ieee80211_iterate_active_interfaces_atomic(
+                        sc->hw, ath9k_bss_iter, sc);
+        /*
+         * None of station vifs are associated.
+         * Clear bssid & aid
+         */
+        if ((sc->sc_ah->opmode == NL80211_IFTYPE_STATION) &&
+            !(sc->sc_flags & SC_OP_PRIM_STA_VIF)) {
+                ath9k_hw_write_associd(sc->sc_ah);
+                /* Stop ANI */
+                sc->sc_flags &= ~SC_OP_ANI_RUN;
+                del_timer_sync(&common->ani.timer);
+        }
+}
 static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
                                   struct ieee80211_vif *vif,
@@ -1893,7 +2036,6 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
                                   u32 changed)
 {
        struct ath_softc *sc = hw->priv;
-        struct ath_beacon_config *cur_conf = &sc->cur_beacon_conf;
        struct ath_hw *ah = sc->sc_ah;
        struct ath_common *common = ath9k_hw_common(ah);
        struct ath_vif *avp = (void *)vif->drv_priv;
@@ -1904,20 +2046,10 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
        mutex_lock(&sc->mutex);
        if (changed & BSS_CHANGED_BSSID) {
-                /* Set BSSID */
+                ath9k_config_bss(sc, vif);
-                memcpy(common->curbssid, bss_conf->bssid, ETH_ALEN);
-                memcpy(avp->bssid, bss_conf->bssid, ETH_ALEN);
-                common->curaid = 0;
-                ath9k_hw_write_associd(ah);
-                /* Set aggregation protection mode parameters */
-                sc->config.ath_aggr_prot = 0;
                ath_dbg(common, ATH_DBG_CONFIG, "BSSID: %pM aid: 0x%x\n",
                        common->curbssid, common->curaid);
-                /* need to reconfigure the beacon */
-                sc->sc_flags &= ~SC_OP_BEACONS ;
        }
        /* Enable transmission of beacons (AP, IBSS, MESH) */
@@ -1958,7 +2090,6 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
        }
        if (changed & BSS_CHANGED_BEACON_INT) {
-                cur_conf->beacon_interval = bss_conf->beacon_int;
                /*
                 * In case of AP mode, the HW TSF has to be reset
                 * when the beacon interval changes.
@@ -1970,9 +2101,8 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
                        if (!error)
                                ath_beacon_config(sc, vif);
                        ath9k_set_beaconing_status(sc, true);
-                } else {
+                } else
                        ath_beacon_config(sc, vif);
-                }
        }
        if (changed & BSS_CHANGED_ERP_PREAMBLE) {
@@ -1994,12 +2124,6 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
                        sc->sc_flags &= ~SC_OP_PROTECT_ENABLE;
        }
-        if (changed & BSS_CHANGED_ASSOC) {
-                ath_dbg(common, ATH_DBG_CONFIG, "BSS Changed ASSOC %d\n",
-                        bss_conf->assoc);
-                ath9k_bss_assoc_info(sc, hw, vif, bss_conf);
-        }
        mutex_unlock(&sc->mutex);
        ath9k_ps_restore(sc);
 }
@@ -2145,10 +2269,9 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop)
        struct ath_common *common = ath9k_hw_common(ah);
        int timeout = 200; /* ms */
        int i, j;
+        bool drain_txq;
-        ath9k_ps_wakeup(sc);
        mutex_lock(&sc->mutex);
        cancel_delayed_work_sync(&sc->tx_complete_work);
        if (sc->sc_flags & SC_OP_INVALID) {
@@ -2161,7 +2284,7 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop)
                timeout = 1;
        for (j = 0; j < timeout; j++) {
-                int npend = 0;
+                bool npend = false;
                if (j)
                        usleep_range(1000, 2000);
@@ -2170,22 +2293,43 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop)
                        if (!ATH_TXQ_SETUP(sc, i))
                                continue;
-                        npend += ath9k_has_pending_frames(sc, &sc->tx.txq[i]);
+                        npend = ath9k_has_pending_frames(sc, &sc->tx.txq[i]);
+                        if (npend)
+                                break;
                }
                if (!npend)
                    goto out;
        }
-        if (!ath_drain_all_txq(sc, false))
+        ath9k_ps_wakeup(sc);
+        spin_lock_bh(&sc->sc_pcu_lock);
+        drain_txq = ath_drain_all_txq(sc, false);
+        spin_unlock_bh(&sc->sc_pcu_lock);
+        if (!drain_txq)
                ath_reset(sc, false);
+        ath9k_ps_restore(sc);
        ieee80211_wake_queues(hw);
 out:
        ieee80211_queue_delayed_work(hw, &sc->tx_complete_work, 0);
        mutex_unlock(&sc->mutex);
-        ath9k_ps_restore(sc);
+}
+static bool ath9k_tx_frames_pending(struct ieee80211_hw *hw)
+{
+        struct ath_softc *sc = hw->priv;
+        int i;
+        for (i = 0; i < ATH9K_NUM_TX_QUEUES; i++) {
+                if (!ATH_TXQ_SETUP(sc, i))
+                        continue;
+                if (ath9k_has_pending_frames(sc, &sc->tx.txq[i]))
+                        return true;
+        }
+        return false;
 }
 struct ieee80211_ops ath9k_ops = {
@@ -2199,6 +2343,7 @@ struct ieee80211_ops ath9k_ops = {
        .configure_filter   = ath9k_configure_filter,
        .sta_add            = ath9k_sta_add,
        .sta_remove         = ath9k_sta_remove,
+        .sta_notify         = ath9k_sta_notify,
        .conf_tx            = ath9k_conf_tx,
        .bss_info_changed   = ath9k_bss_info_changed,
        .set_key            = ath9k_set_key,
@@ -2210,4 +2355,5 @@ struct ieee80211_ops ath9k_ops = {
        .rfkill_poll        = ath9k_rfkill_poll_state,
        .set_coverage_class = ath9k_set_coverage_class,
        .flush              = ath9k_flush,
+        .tx_frames_pending  = ath9k_tx_frames_pending,
 };
diff --git a/drivers/net/wireless/ath/ath9k/phy.h b/drivers/net/wireless/ath/ath9k/phy.h
index 5e3d7496986e..9441bf8ca2fd 100644
--- a/drivers/net/wireless/ath/ath9k/phy.h
+++ b/drivers/net/wireless/ath/ath9k/phy.h
@@ -19,7 +19,6 @@
 #define CHANSEL_DIV             15
 #define CHANSEL_2G(_freq)       (((_freq) * 0x10000) / CHANSEL_DIV)
-#define CHANSEL_2G_9485(_freq)  ((((_freq) * 0x10000) - 215) / CHANSEL_DIV)
 #define CHANSEL_5G(_freq)       (((_freq) * 0x8000) / CHANSEL_DIV)
 #define AR_PHY_BASE     0x9800
@@ -38,26 +37,15 @@
 #define AR_PHY_CLC_Q0        0x0000ffd0
 #define AR_PHY_CLC_Q0_S      5
-#define REG_WRITE_RF_ARRAY(iniarray, regData, regWr) do {               \
-                int r;                                                  \
-                for (r = 0; r < ((iniarray)->ia_rows); r++) {           \
-                        REG_WRITE(ah, INI_RA((iniarray), r, 0), (regData)[r]); \
-                        DO_DELAY(regWr);                                \
-                }                                                       \
-        } while (0)
 #define ANTSWAP_AB 0x0001
 #define REDUCE_CHAIN_0 0x00000050
 #define REDUCE_CHAIN_1 0x00000051
 #define AR_PHY_CHIP_ID 0x9818
-#define RF_BANK_SETUP(_bank, _iniarray, _col) do {                      \
-                int i;                                                  \
-                for (i = 0; i < (_iniarray)->ia_rows; i++)              \
-                        (_bank)[i] = INI_RA((_iniarray), i, _col);;     \
-        } while (0)
 #define AR_PHY_TIMING11_SPUR_FREQ_SD            0x3FF00000
 #define AR_PHY_TIMING11_SPUR_FREQ_SD_S          20
+#define AR_PHY_PLL_CONTROL 0x16180
+#define AR_PHY_PLL_MODE 0x16184
 #endif
diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
index 4c0d36a6980f..4ccbf2ddb553 100644
--- a/drivers/net/wireless/ath/ath9k/rc.c
+++ b/drivers/net/wireless/ath/ath9k/rc.c
@@ -854,14 +854,13 @@ static void ath_get_rate(void *priv, struct ieee80211_sta *sta, void *priv_sta,
        ath_rc_rate_set_rtscts(sc, rate_table, tx_info);
 }
-static bool ath_rc_update_per(struct ath_softc *sc,
+static void ath_rc_update_per(struct ath_softc *sc,
                              const struct ath_rate_table *rate_table,
                              struct ath_rate_priv *ath_rc_priv,
                                  struct ieee80211_tx_info *tx_info,
                              int tx_rate, int xretries, int retries,
                              u32 now_msec)
 {
-        bool state_change = false;
        int count, n_bad_frames;
        u8 last_per;
        static const u32 nretry_to_per_lookup[10] = {
@@ -992,8 +991,6 @@ static bool ath_rc_update_per(struct ath_softc *sc,
                }
        }
-        return state_change;
 }
 static void ath_debug_stat_retries(struct ath_rate_priv *rc, int rix,
@@ -1017,7 +1014,6 @@ static void ath_rc_update_ht(struct ath_softc *sc,
        u32 now_msec = jiffies_to_msecs(jiffies);
        int rate;
        u8 last_per;
-        bool state_change = false;
        const struct ath_rate_table *rate_table = ath_rc_priv->rate_table;
        int size = ath_rc_priv->rate_table_size;
@@ -1027,9 +1023,9 @@ static void ath_rc_update_ht(struct ath_softc *sc,
        last_per = ath_rc_priv->per[tx_rate];
        /* Update PER first */
-        state_change = ath_rc_update_per(sc, rate_table, ath_rc_priv,
+        ath_rc_update_per(sc, rate_table, ath_rc_priv,
-                                         tx_info, tx_rate, xretries,
+                          tx_info, tx_rate, xretries,
-                                         retries, now_msec);
+                          retries, now_msec);
        /*
         * If this rate looks bad (high PER) then stop using it for
@@ -1092,8 +1088,7 @@ static int ath_rc_get_rateindex(const struct ath_rate_table *rate_table,
        if (!(rate->flags & IEEE80211_TX_RC_MCS))
                return rate->idx;
-        while (rate->idx > mcs_rix_off[i] &&
+        while (i < ARRAY_SIZE(mcs_rix_off) && rate->idx > mcs_rix_off[i]) {
-               i < ARRAY_SIZE(mcs_rix_off)) {
                rix++; i++;
        }
diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
index b29c80def35e..4f52e0429f99 100644
--- a/drivers/net/wireless/ath/ath9k/recv.c
+++ b/drivers/net/wireless/ath/ath9k/recv.c
@@ -28,6 +28,33 @@ static inline bool ath_is_alt_ant_ratio_better(int alt_ratio, int maxdelta,
                (alt_rssi_avg > main_rssi_avg + mindelta)) && (pkt_count > 50);
 }
+static inline bool ath_ant_div_comb_alt_check(u8 div_group, int alt_ratio,
+                                        int curr_main_set, int curr_alt_set,
+                                        int alt_rssi_avg, int main_rssi_avg)
+{
+        bool result = false;
+        switch (div_group) {
+        case 0:
+                if (alt_ratio > ATH_ANT_DIV_COMB_ALT_ANT_RATIO)
+                        result = true;
+                break;
+        case 1:
+                if ((((curr_main_set == ATH_ANT_DIV_COMB_LNA2) &&
+                        (curr_alt_set == ATH_ANT_DIV_COMB_LNA1) &&
+                                (alt_rssi_avg >= (main_rssi_avg - 5))) ||
+                        ((curr_main_set == ATH_ANT_DIV_COMB_LNA1) &&
+                        (curr_alt_set == ATH_ANT_DIV_COMB_LNA2) &&
+                                (alt_rssi_avg >= (main_rssi_avg - 2)))) &&
+                                                        (alt_rssi_avg >= 4))
+                        result = true;
+                else
+                        result = false;
+                break;
+        }
+        return result;
+}
 static inline bool ath9k_check_auto_sleep(struct ath_softc *sc)
 {
        return sc->ps_enabled &&
@@ -75,7 +102,6 @@ static void ath_rx_buf_link(struct ath_softc *sc, struct ath_buf *bf)
                *sc->rx.rxlink = bf->bf_daddr;
        sc->rx.rxlink = &ds->ds_link;
-        ath9k_hw_rxena(ah);
 }
 static void ath_setdefantenna(struct ath_softc *sc, u32 antenna)
@@ -426,9 +452,7 @@ u32 ath_calcrxfilter(struct ath_softc *sc)
        else
                rfilt |= ATH9K_RX_FILTER_BEACON;
-        if ((AR_SREV_9280_20_OR_LATER(sc->sc_ah) ||
+        if ((sc->sc_ah->opmode == NL80211_IFTYPE_AP) ||
-            AR_SREV_9285_12_OR_LATER(sc->sc_ah)) &&
-            (sc->sc_ah->opmode == NL80211_IFTYPE_AP) &&
            (sc->rx.rxfilter & FIF_PSPOLL))
                rfilt |= ATH9K_RX_FILTER_PSPOLL;
@@ -574,7 +598,8 @@ static void ath_rx_ps_beacon(struct ath_softc *sc, struct sk_buff *skb)
                sc->ps_flags &= ~PS_BEACON_SYNC;
                ath_dbg(common, ATH_DBG_PS,
                        "Reconfigure Beacon timers based on timestamp from the AP\n");
-                ath_beacon_config(sc, NULL);
+                ath_set_beacon(sc);
+                sc->ps_flags &= ~PS_TSFOOR_SYNC;
        }
        if (ath_beacon_dtim_pending_cab(skb)) {
@@ -919,7 +944,8 @@ static void ath9k_process_rssi(struct ath_common *common,
        int last_rssi;
        __le16 fc;
-        if (ah->opmode != NL80211_IFTYPE_STATION)
+        if ((ah->opmode != NL80211_IFTYPE_STATION) &&
+            (ah->opmode != NL80211_IFTYPE_ADHOC))
                return;
        fc = hdr->frame_control;
@@ -1291,49 +1317,138 @@ static void ath_select_ant_div_from_quick_scan(struct ath_ant_comb *antcomb,
        }
 }
-static void ath_ant_div_conf_fast_divbias(struct ath_hw_antcomb_conf *ant_conf)
+static void ath_ant_div_conf_fast_divbias(struct ath_hw_antcomb_conf *ant_conf,
+                struct ath_ant_comb *antcomb, int alt_ratio)
 {
-        /* Adjust the fast_div_bias based on main and alt lna conf */
+        if (ant_conf->div_group == 0) {
-        switch ((ant_conf->main_lna_conf << 4) | ant_conf->alt_lna_conf) {
+                /* Adjust the fast_div_bias based on main and alt lna conf */
-        case (0x01): /* A-B LNA2 */
+                switch ((ant_conf->main_lna_conf << 4) |
-                ant_conf->fast_div_bias = 0x3b;
+                                ant_conf->alt_lna_conf) {
-                break;
+                case (0x01): /* A-B LNA2 */
-        case (0x02): /* A-B LNA1 */
+                        ant_conf->fast_div_bias = 0x3b;
-                ant_conf->fast_div_bias = 0x3d;
+                        break;
-                break;
+                case (0x02): /* A-B LNA1 */
-        case (0x03): /* A-B A+B */
+                        ant_conf->fast_div_bias = 0x3d;
-                ant_conf->fast_div_bias = 0x1;
+                        break;
-                break;
+                case (0x03): /* A-B A+B */
-        case (0x10): /* LNA2 A-B */
+                        ant_conf->fast_div_bias = 0x1;
-                ant_conf->fast_div_bias = 0x7;
+                        break;
-                break;
+                case (0x10): /* LNA2 A-B */
-        case (0x12): /* LNA2 LNA1 */
+                        ant_conf->fast_div_bias = 0x7;
-                ant_conf->fast_div_bias = 0x2;
+                        break;
-                break;
+                case (0x12): /* LNA2 LNA1 */
-        case (0x13): /* LNA2 A+B */
+                        ant_conf->fast_div_bias = 0x2;
-                ant_conf->fast_div_bias = 0x7;
+                        break;
-                break;
+                case (0x13): /* LNA2 A+B */
-        case (0x20): /* LNA1 A-B */
+                        ant_conf->fast_div_bias = 0x7;
-                ant_conf->fast_div_bias = 0x6;
+                        break;
-                break;
+                case (0x20): /* LNA1 A-B */
-        case (0x21): /* LNA1 LNA2 */
+                        ant_conf->fast_div_bias = 0x6;
-                ant_conf->fast_div_bias = 0x0;
+                        break;
-                break;
+                case (0x21): /* LNA1 LNA2 */
-        case (0x23): /* LNA1 A+B */
+                        ant_conf->fast_div_bias = 0x0;
-                ant_conf->fast_div_bias = 0x6;
+                        break;
-                break;
+                case (0x23): /* LNA1 A+B */
-        case (0x30): /* A+B A-B */
+                        ant_conf->fast_div_bias = 0x6;
-                ant_conf->fast_div_bias = 0x1;
+                        break;
-                break;
+                case (0x30): /* A+B A-B */
-        case (0x31): /* A+B LNA2 */
+                        ant_conf->fast_div_bias = 0x1;
-                ant_conf->fast_div_bias = 0x3b;
+                        break;
-                break;
+                case (0x31): /* A+B LNA2 */
-        case (0x32): /* A+B LNA1 */
+                        ant_conf->fast_div_bias = 0x3b;
-                ant_conf->fast_div_bias = 0x3d;
+                        break;
-                break;
+                case (0x32): /* A+B LNA1 */
-        default:
+                        ant_conf->fast_div_bias = 0x3d;
-                break;
+                        break;
+                default:
+                        break;
+                }
+        } else if (ant_conf->div_group == 2) {
+                /* Adjust the fast_div_bias based on main and alt_lna_conf */
+                switch ((ant_conf->main_lna_conf << 4) |
+                                ant_conf->alt_lna_conf) {
+                case (0x01): /* A-B LNA2 */
+                        ant_conf->fast_div_bias = 0x1;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x02): /* A-B LNA1 */
+                        ant_conf->fast_div_bias = 0x1;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x03): /* A-B A+B */
+                        ant_conf->fast_div_bias = 0x1;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x10): /* LNA2 A-B */
+                        if (!(antcomb->scan) &&
+                                (alt_ratio > ATH_ANT_DIV_COMB_ALT_ANT_RATIO))
+                                ant_conf->fast_div_bias = 0x1;
+                        else
+                                ant_conf->fast_div_bias = 0x2;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x12): /* LNA2 LNA1 */
+                        ant_conf->fast_div_bias = 0x1;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x13): /* LNA2 A+B */
+                        if (!(antcomb->scan) &&
+                                (alt_ratio > ATH_ANT_DIV_COMB_ALT_ANT_RATIO))
+                                ant_conf->fast_div_bias = 0x1;
+                        else
+                                ant_conf->fast_div_bias = 0x2;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x20): /* LNA1 A-B */
+                        if (!(antcomb->scan) &&
+                                (alt_ratio > ATH_ANT_DIV_COMB_ALT_ANT_RATIO))
+                                ant_conf->fast_div_bias = 0x1;
+                        else
+                                ant_conf->fast_div_bias = 0x2;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x21): /* LNA1 LNA2 */
+                        ant_conf->fast_div_bias = 0x1;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x23): /* LNA1 A+B */
+                        if (!(antcomb->scan) &&
+                                (alt_ratio > ATH_ANT_DIV_COMB_ALT_ANT_RATIO))
+                                ant_conf->fast_div_bias = 0x1;
+                        else
+                                ant_conf->fast_div_bias = 0x2;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x30): /* A+B A-B */
+                        ant_conf->fast_div_bias = 0x1;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x31): /* A+B LNA2 */
+                        ant_conf->fast_div_bias = 0x1;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                case (0x32): /* A+B LNA1 */
+                        ant_conf->fast_div_bias = 0x1;
+                        ant_conf->main_gaintb = 0;
+                        ant_conf->alt_gaintb = 0;
+                        break;
+                default:
+                        break;
+                }
        }
 }
 /* Antenna diversity and combining */
@@ -1342,7 +1457,7 @@ static void ath_ant_comb_scan(struct ath_softc *sc, struct ath_rx_status *rs)
        struct ath_hw_antcomb_conf div_ant_conf;
        struct ath_ant_comb *antcomb = &sc->ant_comb;
        int alt_ratio = 0, alt_rssi_avg = 0, main_rssi_avg = 0, curr_alt_set;
-        int curr_main_set, curr_bias;
+        int curr_main_set;
        int main_rssi = rs->rs_rssi_ctl0;
        int alt_rssi = rs->rs_rssi_ctl1;
        int rx_ant_conf,  main_ant_conf;
@@ -1353,8 +1468,8 @@ static void ath_ant_comb_scan(struct ath_softc *sc, struct ath_rx_status *rs)
        main_ant_conf = (rs->rs_rssi_ctl2 >> ATH_ANT_RX_MAIN_SHIFT) &
                         ATH_ANT_RX_MASK;
-        /* Record packet only when alt_rssi is positive */
+        /* Record packet only when both main_rssi and  alt_rssi is positive */
-        if (alt_rssi > 0) {
+        if (main_rssi > 0 && alt_rssi > 0) {
                antcomb->total_pkt_count++;
                antcomb->main_total_rssi += main_rssi;
                antcomb->alt_total_rssi  += alt_rssi;
@@ -1396,7 +1511,6 @@ static void ath_ant_comb_scan(struct ath_softc *sc, struct ath_rx_status *rs)
        ath9k_hw_antdiv_comb_conf_get(sc->sc_ah, &div_ant_conf);
        curr_alt_set = div_ant_conf.alt_lna_conf;
        curr_main_set = div_ant_conf.main_lna_conf;
-        curr_bias = div_ant_conf.fast_div_bias;
        antcomb->count++;
@@ -1415,7 +1529,9 @@ static void ath_ant_comb_scan(struct ath_softc *sc, struct ath_rx_status *rs)
        }
        if (!antcomb->scan) {
-                if (alt_ratio > ATH_ANT_DIV_COMB_ALT_ANT_RATIO) {
+                if (ath_ant_div_comb_alt_check(div_ant_conf.div_group,
+                                        alt_ratio, curr_main_set, curr_alt_set,
+                                        alt_rssi_avg, main_rssi_avg)) {
                        if (curr_alt_set == ATH_ANT_DIV_COMB_LNA2) {
                                /* Switch main and alt LNA */
                                div_ant_conf.main_lna_conf =
@@ -1444,7 +1560,7 @@ static void ath_ant_comb_scan(struct ath_softc *sc, struct ath_rx_status *rs)
                }
                if ((alt_rssi_avg < (main_rssi_avg +
-                    ATH_ANT_DIV_COMB_LNA1_LNA2_DELTA)))
+                                                div_ant_conf.lna1_lna2_delta)))
                        goto div_comb_done;
        }
@@ -1558,8 +1674,7 @@ static void ath_ant_comb_scan(struct ath_softc *sc, struct ath_rx_status *rs)
        antcomb->quick_scan_cnt++;
 div_comb_done:
-        ath_ant_div_conf_fast_divbias(&div_ant_conf);
+        ath_ant_div_conf_fast_divbias(&div_ant_conf, antcomb, alt_ratio);
        ath9k_hw_antdiv_comb_conf_set(sc->sc_ah, &div_ant_conf);
        antcomb->scan_start_time = jiffies;
@@ -1746,7 +1861,7 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush, bool hp)
                if ((sc->ps_flags & (PS_WAIT_FOR_BEACON |
                                              PS_WAIT_FOR_CAB |
                                              PS_WAIT_FOR_PSPOLL_DATA)) ||
-                                        unlikely(ath9k_check_auto_sleep(sc)))
+                                                ath9k_check_auto_sleep(sc))
                        ath_rx_ps(sc, skb);
                spin_unlock_irqrestore(&sc->sc_pm_lock, flags);
@@ -1767,6 +1882,7 @@ requeue:
                } else {
                        list_move_tail(&bf->list, &sc->rx.rxbuf);
                        ath_rx_buf_link(sc, bf);
+                        ath9k_hw_rxena(ah);
                }
        } while (1);
diff --git a/drivers/net/wireless/ath/ath9k/reg.h b/drivers/net/wireless/ath/ath9k/reg.h
index 8fa8acfde62e..456f3ec20fef 100644
--- a/drivers/net/wireless/ath/ath9k/reg.h
+++ b/drivers/net/wireless/ath/ath9k/reg.h
@@ -693,7 +693,7 @@
 #define AR_RC_APB            0x00000002
 #define AR_RC_HOSTIF         0x00000100
-#define AR_WA                           0x4004
+#define AR_WA                   (AR_SREV_9340(ah) ? 0x40c4 : 0x4004)
 #define AR_WA_BIT6                      (1 << 6)
 #define AR_WA_BIT7                      (1 << 7)
 #define AR_WA_BIT23                     (1 << 23)
@@ -712,7 +712,7 @@
 #define AR_PM_STATE                 0x4008
 #define AR_PM_STATE_PME_D3COLD_VAUX 0x00100000
-#define AR_HOST_TIMEOUT             0x4018
+#define AR_HOST_TIMEOUT             (AR_SREV_9340(ah) ? 0x4008 : 0x4018)
 #define AR_HOST_TIMEOUT_APB_CNTR    0x0000FFFF
 #define AR_HOST_TIMEOUT_APB_CNTR_S  0
 #define AR_HOST_TIMEOUT_LCL_CNTR    0xFFFF0000
@@ -742,7 +742,8 @@
 #define EEPROM_PROTECT_WP_1024_2047   0x8000
 #define AR_SREV \
-        ((AR_SREV_9100(ah)) ? 0x0600 : 0x4020)
+        ((AR_SREV_9100(ah)) ? 0x0600 : (AR_SREV_9340(ah) \
+                                        ? 0x400c : 0x4020))
 #define AR_SREV_ID \
        ((AR_SREV_9100(ah)) ? 0x00000FFF : 0x000000FF)
@@ -790,6 +791,7 @@
 #define AR_SREV_VERSION_9485            0x240
 #define AR_SREV_REVISION_9485_10        0
 #define AR_SREV_REVISION_9485_11        1
+#define AR_SREV_VERSION_9340            0x300
 #define AR_SREV_5416(_ah) \
        (((_ah)->hw_version.macVersion == AR_SREV_VERSION_5416_PCI) || \
@@ -858,9 +860,7 @@
 #define AR_SREV_9300(_ah) \
        (((_ah)->hw_version.macVersion == AR_SREV_VERSION_9300))
 #define AR_SREV_9300_20_OR_LATER(_ah) \
-        (((_ah)->hw_version.macVersion > AR_SREV_VERSION_9300) || \
+        ((_ah)->hw_version.macVersion >= AR_SREV_VERSION_9300)
-         (((_ah)->hw_version.macVersion == AR_SREV_VERSION_9300) && \
-          ((_ah)->hw_version.macRev >= AR_SREV_REVISION_9300_20)))
 #define AR_SREV_9485(_ah) \
        (((_ah)->hw_version.macVersion == AR_SREV_VERSION_9485))
@@ -870,6 +870,11 @@
 #define AR_SREV_9485_11(_ah) \
        (AR_SREV_9485(_ah) && \
         ((_ah)->hw_version.macRev == AR_SREV_REVISION_9485_11))
+#define AR_SREV_9485_OR_LATER(_ah) \
+        (((_ah)->hw_version.macVersion >= AR_SREV_VERSION_9485))
+#define AR_SREV_9340(_ah) \
+        (((_ah)->hw_version.macVersion == AR_SREV_VERSION_9340))
 #define AR_SREV_9285E_20(_ah) \
    (AR_SREV_9285_12_OR_LATER(_ah) && \
@@ -912,11 +917,11 @@ enum ath_usb_dev {
 #define AR_INTR_SPURIOUS                      0xFFFFFFFF
-#define AR_INTR_SYNC_CAUSE_CLR                0x4028
+#define AR_INTR_SYNC_CAUSE                    (AR_SREV_9340(ah) ? 0x4010 : 0x4028)
+#define AR_INTR_SYNC_CAUSE_CLR                (AR_SREV_9340(ah) ? 0x4010 : 0x4028)
-#define AR_INTR_SYNC_CAUSE                    0x4028
-#define AR_INTR_SYNC_ENABLE                   0x402c
+#define AR_INTR_SYNC_ENABLE                   (AR_SREV_9340(ah) ? 0x4014 : 0x402c)
 #define AR_INTR_SYNC_ENABLE_GPIO              0xFFFC0000
 #define AR_INTR_SYNC_ENABLE_GPIO_S            18
@@ -956,24 +961,24 @@ enum {
 };
-#define AR_INTR_ASYNC_MASK                       0x4030
+#define AR_INTR_ASYNC_MASK                       (AR_SREV_9340(ah) ? 0x4018 : 0x4030)
 #define AR_INTR_ASYNC_MASK_GPIO                  0xFFFC0000
 #define AR_INTR_ASYNC_MASK_GPIO_S                18
-#define AR_INTR_SYNC_MASK                        0x4034
+#define AR_INTR_SYNC_MASK                        (AR_SREV_9340(ah) ? 0x401c : 0x4034)
 #define AR_INTR_SYNC_MASK_GPIO                   0xFFFC0000
 #define AR_INTR_SYNC_MASK_GPIO_S                 18
-#define AR_INTR_ASYNC_CAUSE_CLR                  0x4038
+#define AR_INTR_ASYNC_CAUSE_CLR                  (AR_SREV_9340(ah) ? 0x4020 : 0x4038)
-#define AR_INTR_ASYNC_CAUSE                      0x4038
+#define AR_INTR_ASYNC_CAUSE                      (AR_SREV_9340(ah) ? 0x4020 : 0x4038)
-#define AR_INTR_ASYNC_ENABLE                     0x403c
+#define AR_INTR_ASYNC_ENABLE                     (AR_SREV_9340(ah) ? 0x4024 : 0x403c)
 #define AR_INTR_ASYNC_ENABLE_GPIO                0xFFFC0000
 #define AR_INTR_ASYNC_ENABLE_GPIO_S              18
 #define AR_PCIE_SERDES                           0x4040
 #define AR_PCIE_SERDES2                          0x4044
-#define AR_PCIE_PM_CTRL                          0x4014
+#define AR_PCIE_PM_CTRL                          (AR_SREV_9340(ah) ? 0x4004 : 0x4014)
 #define AR_PCIE_PM_CTRL_ENA                      0x00080000
 #define AR_NUM_GPIO                              14
@@ -984,7 +989,7 @@ enum {
 #define AR9300_NUM_GPIO                          17
 #define AR7010_NUM_GPIO                          16
-#define AR_GPIO_IN_OUT                           0x4048
+#define AR_GPIO_IN_OUT                           (AR_SREV_9340(ah) ? 0x4028 : 0x4048)
 #define AR_GPIO_IN_VAL                           0x0FFFC000
 #define AR_GPIO_IN_VAL_S                         14
 #define AR928X_GPIO_IN_VAL                       0x000FFC00
@@ -998,11 +1003,12 @@ enum {
 #define AR7010_GPIO_IN_VAL                       0x0000FFFF
 #define AR7010_GPIO_IN_VAL_S                     0
-#define AR_GPIO_IN                               0x404c
+#define AR_GPIO_IN                               (AR_SREV_9340(ah) ? 0x402c : 0x404c)
 #define AR9300_GPIO_IN_VAL                       0x0001FFFF
 #define AR9300_GPIO_IN_VAL_S                     0
-#define AR_GPIO_OE_OUT                           (AR_SREV_9300_20_OR_LATER(ah) ? 0x4050 : 0x404c)
+#define AR_GPIO_OE_OUT                           (AR_SREV_9340(ah) ? 0x4030 : \
+                                                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x4050 : 0x404c))
 #define AR_GPIO_OE_OUT_DRV                       0x3
 #define AR_GPIO_OE_OUT_DRV_NO                    0x0
 #define AR_GPIO_OE_OUT_DRV_LOW                   0x1
@@ -1024,11 +1030,13 @@ enum {
 #define AR7010_GPIO_INT_MASK                     0x52024
 #define AR7010_GPIO_FUNCTION                     0x52028
-#define AR_GPIO_INTR_POL                         (AR_SREV_9300_20_OR_LATER(ah) ? 0x4058 : 0x4050)
+#define AR_GPIO_INTR_POL                         (AR_SREV_9340(ah) ? 0x4038 : \
+                                                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x4058 : 0x4050))
 #define AR_GPIO_INTR_POL_VAL                     0x0001FFFF
 #define AR_GPIO_INTR_POL_VAL_S                   0
-#define AR_GPIO_INPUT_EN_VAL                     (AR_SREV_9300_20_OR_LATER(ah) ? 0x405c : 0x4054)
+#define AR_GPIO_INPUT_EN_VAL                     (AR_SREV_9340(ah) ? 0x403c : \
+                                                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x405c : 0x4054))
 #define AR_GPIO_INPUT_EN_VAL_BT_PRIORITY_DEF     0x00000004
 #define AR_GPIO_INPUT_EN_VAL_BT_PRIORITY_S       2
 #define AR_GPIO_INPUT_EN_VAL_BT_FREQUENCY_DEF    0x00000008
@@ -1046,13 +1054,15 @@ enum {
 #define AR_GPIO_RTC_RESET_OVERRIDE_ENABLE        0x00010000
 #define AR_GPIO_JTAG_DISABLE                     0x00020000
-#define AR_GPIO_INPUT_MUX1                       (AR_SREV_9300_20_OR_LATER(ah) ? 0x4060 : 0x4058)
+#define AR_GPIO_INPUT_MUX1                       (AR_SREV_9340(ah) ? 0x4040 : \
+                                                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x4060 : 0x4058))
 #define AR_GPIO_INPUT_MUX1_BT_ACTIVE             0x000f0000
 #define AR_GPIO_INPUT_MUX1_BT_ACTIVE_S           16
 #define AR_GPIO_INPUT_MUX1_BT_PRIORITY           0x00000f00
 #define AR_GPIO_INPUT_MUX1_BT_PRIORITY_S         8
-#define AR_GPIO_INPUT_MUX2                       (AR_SREV_9300_20_OR_LATER(ah) ? 0x4064 : 0x405c)
+#define AR_GPIO_INPUT_MUX2                       (AR_SREV_9340(ah) ? 0x4044 : \
+                                                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x4064 : 0x405c))
 #define AR_GPIO_INPUT_MUX2_CLK25                 0x0000000f
 #define AR_GPIO_INPUT_MUX2_CLK25_S               0
 #define AR_GPIO_INPUT_MUX2_RFSILENT              0x000000f0
@@ -1060,13 +1070,18 @@ enum {
 #define AR_GPIO_INPUT_MUX2_RTC_RESET             0x00000f00
 #define AR_GPIO_INPUT_MUX2_RTC_RESET_S           8
-#define AR_GPIO_OUTPUT_MUX1                      (AR_SREV_9300_20_OR_LATER(ah) ? 0x4068 : 0x4060)
+#define AR_GPIO_OUTPUT_MUX1                      (AR_SREV_9340(ah) ? 0x4048 : \
-#define AR_GPIO_OUTPUT_MUX2                      (AR_SREV_9300_20_OR_LATER(ah) ? 0x406c : 0x4064)
+                                                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x4068 : 0x4060))
-#define AR_GPIO_OUTPUT_MUX3                      (AR_SREV_9300_20_OR_LATER(ah) ? 0x4070 : 0x4068)
+#define AR_GPIO_OUTPUT_MUX2                      (AR_SREV_9340(ah) ? 0x404c : \
+                                                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x406c : 0x4064))
+#define AR_GPIO_OUTPUT_MUX3                      (AR_SREV_9340(ah) ? 0x4050 : \
+                                                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x4070 : 0x4068))
-#define AR_INPUT_STATE                           (AR_SREV_9300_20_OR_LATER(ah) ? 0x4074 : 0x406c)
+#define AR_INPUT_STATE                           (AR_SREV_9340(ah) ? 0x4054 : \
+                                                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x4074 : 0x406c))
-#define AR_EEPROM_STATUS_DATA                    (AR_SREV_9300_20_OR_LATER(ah) ? 0x4084 : 0x407c)
+#define AR_EEPROM_STATUS_DATA                    (AR_SREV_9340(ah) ? 0x40c8 : \
+                                                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x4084 : 0x407c))
 #define AR_EEPROM_STATUS_DATA_VAL                0x0000ffff
 #define AR_EEPROM_STATUS_DATA_VAL_S              0
 #define AR_EEPROM_STATUS_DATA_BUSY               0x00010000
@@ -1074,28 +1089,51 @@ enum {
 #define AR_EEPROM_STATUS_DATA_PROT_ACCESS        0x00040000
 #define AR_EEPROM_STATUS_DATA_ABSENT_ACCESS      0x00080000
-#define AR_OBS                  (AR_SREV_9300_20_OR_LATER(ah) ? 0x4088 : 0x4080)
+#define AR_OBS                  (AR_SREV_9340(ah) ? 0x405c : \
+                                 (AR_SREV_9300_20_OR_LATER(ah) ? 0x4088 : 0x4080))
 #define AR_GPIO_PDPU                             (AR_SREV_9300_20_OR_LATER(ah) ? 0x4090 : 0x4088)
-#define AR_PCIE_MSI                              (AR_SREV_9300_20_OR_LATER(ah) ? 0x40a4 : 0x4094)
+#define AR_PCIE_MSI                             (AR_SREV_9340(ah) ? 0x40d8 : \
+                                                 (AR_SREV_9300_20_OR_LATER(ah) ? 0x40a4 : 0x4094))
 #define AR_PCIE_MSI_ENABLE                       0x00000001
-#define AR_INTR_PRIO_SYNC_ENABLE  0x40c4
+#define AR_INTR_PRIO_SYNC_ENABLE  (AR_SREV_9340(ah) ? 0x4088 : 0x40c4)
-#define AR_INTR_PRIO_ASYNC_MASK   0x40c8
+#define AR_INTR_PRIO_ASYNC_MASK   (AR_SREV_9340(ah) ? 0x408c : 0x40c8)
-#define AR_INTR_PRIO_SYNC_MASK    0x40cc
+#define AR_INTR_PRIO_SYNC_MASK    (AR_SREV_9340(ah) ? 0x4090 : 0x40cc)
-#define AR_INTR_PRIO_ASYNC_ENABLE 0x40d4
+#define AR_INTR_PRIO_ASYNC_ENABLE (AR_SREV_9340(ah) ? 0x4094 : 0x40d4)
 #define AR_ENT_OTP                0x40d8
 #define AR_ENT_OTP_CHAIN2_DISABLE               0x00020000
 #define AR_ENT_OTP_MPSD         0x00800000
-#define AR_CH0_BB_DPLL2          0x16184
+#define AR_CH0_BB_DPLL1          0x16180
+#define AR_CH0_BB_DPLL1_REFDIV   0xF8000000
+#define AR_CH0_BB_DPLL1_REFDIV_S 27
+#define AR_CH0_BB_DPLL1_NINI     0x07FC0000
+#define AR_CH0_BB_DPLL1_NINI_S   18
+#define AR_CH0_BB_DPLL1_NFRAC    0x0003FFFF
+#define AR_CH0_BB_DPLL1_NFRAC_S  0
+#define AR_CH0_BB_DPLL2              0x16184
+#define AR_CH0_BB_DPLL2_LOCAL_PLL       0x40000000
+#define AR_CH0_BB_DPLL2_LOCAL_PLL_S     30
+#define AR_CH0_DPLL2_KI              0x3C000000
+#define AR_CH0_DPLL2_KI_S            26
+#define AR_CH0_DPLL2_KD              0x03F80000
+#define AR_CH0_DPLL2_KD_S            19
+#define AR_CH0_BB_DPLL2_EN_NEGTRIG   0x00040000
+#define AR_CH0_BB_DPLL2_EN_NEGTRIG_S 18
+#define AR_CH0_BB_DPLL2_PLL_PWD      0x00010000
+#define AR_CH0_BB_DPLL2_PLL_PWD_S    16
+#define AR_CH0_BB_DPLL2_OUTDIV       0x0000E000
+#define AR_CH0_BB_DPLL2_OUTDIV_S     13
 #define AR_CH0_BB_DPLL3          0x16188
+#define AR_CH0_BB_DPLL3_PHASE_SHIFT     0x3F800000
+#define AR_CH0_BB_DPLL3_PHASE_SHIFT_S   23
 #define AR_CH0_DDR_DPLL2         0x16244
 #define AR_CH0_DDR_DPLL3         0x16248
-#define AR_CH0_DPLL2_KD              0x03F80000
-#define AR_CH0_DPLL2_KD_S            19
-#define AR_CH0_DPLL2_KI              0x3C000000
-#define AR_CH0_DPLL2_KI_S            26
 #define AR_CH0_DPLL3_PHASE_SHIFT     0x3F800000
 #define AR_CH0_DPLL3_PHASE_SHIFT_S   23
 #define AR_PHY_CCA_NOM_VAL_2GHZ      -118
@@ -1144,6 +1182,7 @@ enum {
 #define AR_RTC_PLL_REFDIV_5     0x000000c0
 #define AR_RTC_PLL_CLKSEL       0x00000300
 #define AR_RTC_PLL_CLKSEL_S     8
+#define AR_RTC_PLL_BYPASS       0x00010000
 #define PLL3 0x16188
 #define PLL3_DO_MEAS_MASK 0x40000000
@@ -1190,7 +1229,8 @@ enum {
 /* RTC_DERIVED_* - only for AR9100 */
-#define AR_RTC_DERIVED_CLK           (AR_RTC_BASE + 0x0038)
+#define AR_RTC_DERIVED_CLK \
+        (AR_SREV_9100(ah) ? (AR_RTC_BASE + 0x0038) : 0x7038)
 #define AR_RTC_DERIVED_CLK_PERIOD    0x0000fffe
 #define AR_RTC_DERIVED_CLK_PERIOD_S  1
@@ -1396,6 +1436,7 @@ enum {
 #define AR_STA_ID1_PCF             0x00100000
 #define AR_STA_ID1_USE_DEFANT      0x00200000
 #define AR_STA_ID1_DEFANT_UPDATE   0x00400000
+#define AR_STA_ID1_AR9100_BA_FIX   0x00400000
 #define AR_STA_ID1_RTS_USE_DEF     0x00800000
 #define AR_STA_ID1_ACKCTS_6MB      0x01000000
 #define AR_STA_ID1_BASE_RATE_11B   0x02000000
@@ -1668,6 +1709,22 @@ enum {
 #define AR_BTCOEX_WL_WGHT          0xffff0000
 #define AR_BTCOEX_WL_WGHT_S        16
+#define AR_BT_COEX_WL_WEIGHTS0     0x8174
+#define AR_BT_COEX_WL_WEIGHTS1     0x81c4
+#define AR_BT_COEX_BT_WEIGHTS0     0x83ac
+#define AR_BT_COEX_BT_WEIGHTS1     0x83b0
+#define AR_BT_COEX_BT_WEIGHTS2     0x83b4
+#define AR_BT_COEX_BT_WEIGHTS3     0x83b8
+#define AR9300_BT_WGHT                     0xcccc4444
+#define AR9300_STOMP_ALL_WLAN_WGHT0        0xfffffff0
+#define AR9300_STOMP_ALL_WLAN_WGHT1        0xfffffff0
+#define AR9300_STOMP_LOW_WLAN_WGHT0        0x88888880
+#define AR9300_STOMP_LOW_WLAN_WGHT1        0x88888880
+#define AR9300_STOMP_NONE_WLAN_WGHT0       0x00000000
+#define AR9300_STOMP_NONE_WLAN_WGHT1       0x00000000
 #define AR_BT_COEX_MODE2           0x817c
 #define AR_BT_BCN_MISS_THRESH      0x000000ff
 #define AR_BT_BCN_MISS_THRESH_S    0
diff --git a/drivers/net/wireless/ath/ath9k/wmi.c b/drivers/net/wireless/ath/ath9k/wmi.c
index d3d24904f62f..f9b1eb4853c4 100644
--- a/drivers/net/wireless/ath/ath9k/wmi.c
+++ b/drivers/net/wireless/ath/ath9k/wmi.c
@@ -23,20 +23,18 @@ static const char *wmi_cmd_to_name(enum wmi_cmd_id wmi_cmd)
                return "WMI_ECHO_CMDID";
        case WMI_ACCESS_MEMORY_CMDID:
                return "WMI_ACCESS_MEMORY_CMDID";
+        case WMI_GET_FW_VERSION:
+                return "WMI_GET_FW_VERSION";
        case WMI_DISABLE_INTR_CMDID:
                return "WMI_DISABLE_INTR_CMDID";
        case WMI_ENABLE_INTR_CMDID:
                return "WMI_ENABLE_INTR_CMDID";
-        case WMI_RX_LINK_CMDID:
-                return "WMI_RX_LINK_CMDID";
        case WMI_ATH_INIT_CMDID:
                return "WMI_ATH_INIT_CMDID";
        case WMI_ABORT_TXQ_CMDID:
                return "WMI_ABORT_TXQ_CMDID";
        case WMI_STOP_TX_DMA_CMDID:
                return "WMI_STOP_TX_DMA_CMDID";
-        case WMI_STOP_DMA_RECV_CMDID:
-                return "WMI_STOP_DMA_RECV_CMDID";
        case WMI_ABORT_TX_DMA_CMDID:
                return "WMI_ABORT_TX_DMA_CMDID";
        case WMI_DRAIN_TXQ_CMDID:
@@ -51,8 +49,6 @@ static const char *wmi_cmd_to_name(enum wmi_cmd_id wmi_cmd)
                return "WMI_FLUSH_RECV_CMDID";
        case WMI_SET_MODE_CMDID:
                return "WMI_SET_MODE_CMDID";
-        case WMI_RESET_CMDID:
-                return "WMI_RESET_CMDID";
        case WMI_NODE_CREATE_CMDID:
                return "WMI_NODE_CREATE_CMDID";
        case WMI_NODE_REMOVE_CMDID:
@@ -61,8 +57,6 @@ static const char *wmi_cmd_to_name(enum wmi_cmd_id wmi_cmd)
                return "WMI_VAP_REMOVE_CMDID";
        case WMI_VAP_CREATE_CMDID:
                return "WMI_VAP_CREATE_CMDID";
-        case WMI_BEACON_UPDATE_CMDID:
-                return "WMI_BEACON_UPDATE_CMDID";
        case WMI_REG_READ_CMDID:
                return "WMI_REG_READ_CMDID";
        case WMI_REG_WRITE_CMDID:
@@ -71,22 +65,22 @@ static const char *wmi_cmd_to_name(enum wmi_cmd_id wmi_cmd)
                return "WMI_RC_STATE_CHANGE_CMDID";
        case WMI_RC_RATE_UPDATE_CMDID:
                return "WMI_RC_RATE_UPDATE_CMDID";
-        case WMI_DEBUG_INFO_CMDID:
-                return "WMI_DEBUG_INFO_CMDID";
-        case WMI_HOST_ATTACH:
-                return "WMI_HOST_ATTACH";
        case WMI_TARGET_IC_UPDATE_CMDID:
                return "WMI_TARGET_IC_UPDATE_CMDID";
-        case WMI_TGT_STATS_CMDID:
-                return "WMI_TGT_STATS_CMDID";
        case WMI_TX_AGGR_ENABLE_CMDID:
                return "WMI_TX_AGGR_ENABLE_CMDID";
        case WMI_TGT_DETACH_CMDID:
                return "WMI_TGT_DETACH_CMDID";
-        case WMI_TGT_TXQ_ENABLE_CMDID:
+        case WMI_NODE_UPDATE_CMDID:
-                return "WMI_TGT_TXQ_ENABLE_CMDID";
+                return "WMI_NODE_UPDATE_CMDID";
-        case WMI_AGGR_LIMIT_CMD:
+        case WMI_INT_STATS_CMDID:
-                return "WMI_AGGR_LIMIT_CMD";
+                return "WMI_INT_STATS_CMDID";
+        case WMI_TX_STATS_CMDID:
+                return "WMI_TX_STATS_CMDID";
+        case WMI_RX_STATS_CMDID:
+                return "WMI_RX_STATS_CMDID";
+        case WMI_BITRATE_MASK_CMDID:
+                return "WMI_BITRATE_MASK_CMDID";
        }
        return "Bogus";
@@ -102,9 +96,15 @@ struct wmi *ath9k_init_wmi(struct ath9k_htc_priv *priv)
        wmi->drv_priv = priv;
        wmi->stopped = false;
+        skb_queue_head_init(&wmi->wmi_event_queue);
+        spin_lock_init(&wmi->wmi_lock);
+        spin_lock_init(&wmi->event_lock);
        mutex_init(&wmi->op_mutex);
        mutex_init(&wmi->multi_write_mutex);
        init_completion(&wmi->cmd_wait);
+        INIT_LIST_HEAD(&wmi->pending_tx_events);
+        tasklet_init(&wmi->wmi_event_tasklet, ath9k_wmi_event_tasklet,
+                     (unsigned long)wmi);
        return wmi;
 }
@@ -120,11 +120,65 @@ void ath9k_deinit_wmi(struct ath9k_htc_priv *priv)
        kfree(priv->wmi);
 }
-void ath9k_swba_tasklet(unsigned long data)
+void ath9k_wmi_event_drain(struct ath9k_htc_priv *priv)
 {
-        struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *)data;
+        unsigned long flags;
-        ath9k_htc_swba(priv, priv->wmi->beacon_pending);
+        tasklet_kill(&priv->wmi->wmi_event_tasklet);
+        spin_lock_irqsave(&priv->wmi->wmi_lock, flags);
+        __skb_queue_purge(&priv->wmi->wmi_event_queue);
+        spin_unlock_irqrestore(&priv->wmi->wmi_lock, flags);
+}
+void ath9k_wmi_event_tasklet(unsigned long data)
+{
+        struct wmi *wmi = (struct wmi *)data;
+        struct ath9k_htc_priv *priv = wmi->drv_priv;
+        struct wmi_cmd_hdr *hdr;
+        void *wmi_event;
+        struct wmi_event_swba *swba;
+        struct sk_buff *skb = NULL;
+        unsigned long flags;
+        u16 cmd_id;
+        do {
+                spin_lock_irqsave(&wmi->wmi_lock, flags);
+                skb = __skb_dequeue(&wmi->wmi_event_queue);
+                if (!skb) {
+                        spin_unlock_irqrestore(&wmi->wmi_lock, flags);
+                        return;
+                }
+                spin_unlock_irqrestore(&wmi->wmi_lock, flags);
+                hdr = (struct wmi_cmd_hdr *) skb->data;
+                cmd_id = be16_to_cpu(hdr->command_id);
+                wmi_event = skb_pull(skb, sizeof(struct wmi_cmd_hdr));
+                switch (cmd_id) {
+                case WMI_SWBA_EVENTID:
+                        swba = (struct wmi_event_swba *) wmi_event;
+                        ath9k_htc_swba(priv, swba);
+                        break;
+                case WMI_FATAL_EVENTID:
+                        ieee80211_queue_work(wmi->drv_priv->hw,
+                                             &wmi->drv_priv->fatal_work);
+                        break;
+                case WMI_TXSTATUS_EVENTID:
+                        spin_lock_bh(&priv->tx.tx_lock);
+                        if (priv->tx.flags & ATH9K_HTC_OP_TX_DRAIN) {
+                                spin_unlock_bh(&priv->tx.tx_lock);
+                                break;
+                        }
+                        spin_unlock_bh(&priv->tx.tx_lock);
+                        ath9k_htc_txstatus(priv, wmi_event);
+                        break;
+                default:
+                        break;
+                }
+                kfree_skb(skb);
+        } while (1);
 }
 void ath9k_fatal_work(struct work_struct *work)
@@ -153,10 +207,6 @@ static void ath9k_wmi_ctrl_rx(void *priv, struct sk_buff *skb,
        struct wmi *wmi = (struct wmi *) priv;
        struct wmi_cmd_hdr *hdr;
        u16 cmd_id;
-        void *wmi_event;
-#ifdef CONFIG_ATH9K_HTC_DEBUGFS
-        __be32 txrate;
-#endif
        if (unlikely(wmi->stopped))
                goto free_skb;
@@ -165,26 +215,10 @@ static void ath9k_wmi_ctrl_rx(void *priv, struct sk_buff *skb,
        cmd_id = be16_to_cpu(hdr->command_id);
        if (cmd_id & 0x1000) {
-                wmi_event = skb_pull(skb, sizeof(struct wmi_cmd_hdr));
+                spin_lock(&wmi->wmi_lock);
-                switch (cmd_id) {
+                __skb_queue_tail(&wmi->wmi_event_queue, skb);
-                case WMI_SWBA_EVENTID:
+                spin_unlock(&wmi->wmi_lock);
-                        wmi->beacon_pending = *(u8 *)wmi_event;
+                tasklet_schedule(&wmi->wmi_event_tasklet);
-                        tasklet_schedule(&wmi->drv_priv->swba_tasklet);
-                        break;
-                case WMI_FATAL_EVENTID:
-                        ieee80211_queue_work(wmi->drv_priv->hw,
-                                             &wmi->drv_priv->fatal_work);
-                        break;
-                case WMI_TXRATE_EVENTID:
-#ifdef CONFIG_ATH9K_HTC_DEBUGFS
-                        txrate = ((struct wmi_event_txrate *)wmi_event)->txrate;
-                        wmi->drv_priv->debug.txrate = be32_to_cpu(txrate);
-#endif
-                        break;
-                default:
-                        break;
-                }
-                kfree_skb(skb);
                return;
        }
@@ -243,7 +277,7 @@ static int ath9k_wmi_cmd_issue(struct wmi *wmi,
        hdr->command_id = cpu_to_be16(cmd);
        hdr->seq_no = cpu_to_be16(++wmi->tx_seq_id);
-        return htc_send(wmi->htc, skb, wmi->ctrl_epid, NULL);
+        return htc_send_epid(wmi->htc, skb, wmi->ctrl_epid);
 }
 int ath9k_wmi_cmd(struct wmi *wmi, enum wmi_cmd_id cmd_id,
diff --git a/drivers/net/wireless/ath/ath9k/wmi.h b/drivers/net/wireless/ath/ath9k/wmi.h
index 42084277522d..6095eeb6e025 100644
--- a/drivers/net/wireless/ath/ath9k/wmi.h
+++ b/drivers/net/wireless/ath/ath9k/wmi.h
@@ -17,7 +17,6 @@
 #ifndef WMI_H
 #define WMI_H
 struct wmi_event_txrate {
        __be32 txrate;
        struct {
@@ -31,18 +30,65 @@ struct wmi_cmd_hdr {
        __be16 seq_no;
 } __packed;
+struct wmi_fw_version {
+        __be16 major;
+        __be16 minor;
+} __packed;
+struct wmi_event_swba {
+        __be64 tsf;
+        u8 beacon_pending;
+};
+/*
+ * 64 - HTC header - WMI header - 1 / txstatus
+ * And some other hdr. space is also accounted for.
+ * 12 seems to be the magic number.
+ */
+#define HTC_MAX_TX_STATUS 12
+#define ATH9K_HTC_TXSTAT_ACK        BIT(0)
+#define ATH9K_HTC_TXSTAT_FILT       BIT(1)
+#define ATH9K_HTC_TXSTAT_RTC_CTS    BIT(2)
+#define ATH9K_HTC_TXSTAT_MCS        BIT(3)
+#define ATH9K_HTC_TXSTAT_CW40       BIT(4)
+#define ATH9K_HTC_TXSTAT_SGI        BIT(5)
+/*
+ * Legacy rates are indicated as indices.
+ * HT rates are indicated as dot11 numbers.
+ * This allows us to resrict the rate field
+ * to 4 bits.
+ */
+#define ATH9K_HTC_TXSTAT_RATE       0x0f
+#define ATH9K_HTC_TXSTAT_RATE_S     0
+#define ATH9K_HTC_TXSTAT_EPID       0xf0
+#define ATH9K_HTC_TXSTAT_EPID_S     4
+struct __wmi_event_txstatus {
+        u8 cookie;
+        u8 ts_rate; /* Also holds EP ID */
+        u8 ts_flags;
+};
+struct wmi_event_txstatus {
+        u8 cnt;
+        struct __wmi_event_txstatus txstatus[HTC_MAX_TX_STATUS];
+} __packed;
 enum wmi_cmd_id {
        WMI_ECHO_CMDID = 0x0001,
        WMI_ACCESS_MEMORY_CMDID,
        /* Commands to Target */
+        WMI_GET_FW_VERSION,
        WMI_DISABLE_INTR_CMDID,
        WMI_ENABLE_INTR_CMDID,
-        WMI_RX_LINK_CMDID,
        WMI_ATH_INIT_CMDID,
        WMI_ABORT_TXQ_CMDID,
        WMI_STOP_TX_DMA_CMDID,
-        WMI_STOP_DMA_RECV_CMDID,
        WMI_ABORT_TX_DMA_CMDID,
        WMI_DRAIN_TXQ_CMDID,
        WMI_DRAIN_TXQ_ALL_CMDID,
@@ -50,24 +96,22 @@ enum wmi_cmd_id {
        WMI_STOP_RECV_CMDID,
        WMI_FLUSH_RECV_CMDID,
        WMI_SET_MODE_CMDID,
-        WMI_RESET_CMDID,
        WMI_NODE_CREATE_CMDID,
        WMI_NODE_REMOVE_CMDID,
        WMI_VAP_REMOVE_CMDID,
        WMI_VAP_CREATE_CMDID,
-        WMI_BEACON_UPDATE_CMDID,
        WMI_REG_READ_CMDID,
        WMI_REG_WRITE_CMDID,
        WMI_RC_STATE_CHANGE_CMDID,
        WMI_RC_RATE_UPDATE_CMDID,
-        WMI_DEBUG_INFO_CMDID,
-        WMI_HOST_ATTACH,
        WMI_TARGET_IC_UPDATE_CMDID,
-        WMI_TGT_STATS_CMDID,
        WMI_TX_AGGR_ENABLE_CMDID,
        WMI_TGT_DETACH_CMDID,
-        WMI_TGT_TXQ_ENABLE_CMDID,
+        WMI_NODE_UPDATE_CMDID,
-        WMI_AGGR_LIMIT_CMD = 0x0026,
+        WMI_INT_STATS_CMDID,
+        WMI_TX_STATS_CMDID,
+        WMI_RX_STATS_CMDID,
+        WMI_BITRATE_MASK_CMDID,
 };
 enum wmi_event_id {
@@ -76,9 +120,8 @@ enum wmi_event_id {
        WMI_FATAL_EVENTID,
        WMI_TXTO_EVENTID,
        WMI_BMISS_EVENTID,
-        WMI_WLAN_TXCOMP_EVENTID,
        WMI_DELBA_EVENTID,
-        WMI_TXRATE_EVENTID,
+        WMI_TXSTATUS_EVENTID,
 };
 #define MAX_CMD_NUMBER 62
@@ -88,6 +131,12 @@ struct register_write {
        __be32 val;
 };
+struct ath9k_htc_tx_event {
+        int count;
+        struct __wmi_event_txstatus txs;
+        struct list_head list;
+};
 struct wmi {
        struct ath9k_htc_priv *drv_priv;
        struct htc_target *htc;
@@ -95,12 +144,16 @@ struct wmi {
        struct mutex op_mutex;
        struct completion cmd_wait;
        enum wmi_cmd_id last_cmd_id;
+        struct sk_buff_head wmi_event_queue;
+        struct tasklet_struct wmi_event_tasklet;
        u16 tx_seq_id;
        u8 *cmd_rsp_buf;
        u32 cmd_rsp_len;
        bool stopped;
-        u8 beacon_pending;
+        struct list_head pending_tx_events;
+        spinlock_t event_lock;
        spinlock_t wmi_lock;
        atomic_t mwrite_cnt;
@@ -117,8 +170,9 @@ int ath9k_wmi_cmd(struct wmi *wmi, enum wmi_cmd_id cmd_id,
                  u8 *cmd_buf, u32 cmd_len,
                  u8 *rsp_buf, u32 rsp_len,
                  u32 timeout);
-void ath9k_swba_tasklet(unsigned long data);
+void ath9k_wmi_event_tasklet(unsigned long data);
 void ath9k_fatal_work(struct work_struct *work);
+void ath9k_wmi_event_drain(struct ath9k_htc_priv *priv);
 #define WMI_CMD(_wmi_cmd)                                               \
        do {                                                            \
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 88fa7fdffd05..97dd1fac98b6 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -357,6 +357,7 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
        struct ath_frame_info *fi;
        int nframes;
        u8 tidno;
+        bool clear_filter;
        skb = bf->bf_mpdu;
        hdr = (struct ieee80211_hdr *)skb->data;
@@ -441,22 +442,24 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
                        /* transmit completion */
                        acked_cnt++;
                } else {
-                        if (!(tid->state & AGGR_CLEANUP) && retry) {
+                        if ((tid->state & AGGR_CLEANUP) || !retry) {
-                                if (fi->retries < ATH_MAX_SW_RETRIES) {
-                                        ath_tx_set_retry(sc, txq, bf->bf_mpdu);
-                                        txpending = 1;
-                                } else {
-                                        bf->bf_state.bf_type |= BUF_XRETRY;
-                                        txfail = 1;
-                                        sendbar = 1;
-                                        txfail_cnt++;
-                                }
-                        } else {
                                /*
                                 * cleanup in progress, just fail
                                 * the un-acked sub-frames
                                 */
                                txfail = 1;
+                        } else if (fi->retries < ATH_MAX_SW_RETRIES) {
+                                if (!(ts->ts_status & ATH9K_TXERR_FILT) ||
+                                    !an->sleeping)
+                                        ath_tx_set_retry(sc, txq, bf->bf_mpdu);
+                                clear_filter = true;
+                                txpending = 1;
+                        } else {
+                                bf->bf_state.bf_type |= BUF_XRETRY;
+                                txfail = 1;
+                                sendbar = 1;
+                                txfail_cnt++;
                        }
                }
@@ -496,6 +499,7 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
                                !txfail, sendbar);
                } else {
                        /* retry the un-acked ones */
+                        ath9k_hw_set_clrdmask(sc->sc_ah, bf->bf_desc, false);
                        if (!(sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_EDMA)) {
                                if (bf->bf_next == NULL && bf_last->bf_stale) {
                                        struct ath_buf *tbf;
@@ -546,7 +550,12 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
        /* prepend un-acked frames to the beginning of the pending frame queue */
        if (!list_empty(&bf_pending)) {
+                if (an->sleeping)
+                        ieee80211_sta_set_tim(sta);
                spin_lock_bh(&txq->axq_lock);
+                if (clear_filter)
+                        tid->ac->clear_ps_filter = true;
                list_splice(&bf_pending, &tid->buf_q);
                ath_tx_queue_tid(txq, tid);
                spin_unlock_bh(&txq->axq_lock);
@@ -816,6 +825,11 @@ static void ath_tx_sched_aggr(struct ath_softc *sc, struct ath_txq *txq,
                bf = list_first_entry(&bf_q, struct ath_buf, list);
                bf->bf_lastbf = list_entry(bf_q.prev, struct ath_buf, list);
+                if (tid->ac->clear_ps_filter) {
+                        tid->ac->clear_ps_filter = false;
+                        ath9k_hw_set_clrdmask(sc->sc_ah, bf->bf_desc, true);
+                }
                /* if only one frame, send as non-aggregate */
                if (bf == bf->bf_lastbf) {
                        fi = get_frame_info(bf->bf_mpdu);
@@ -896,6 +910,67 @@ void ath_tx_aggr_stop(struct ath_softc *sc, struct ieee80211_sta *sta, u16 tid)
        ath_tx_flush_tid(sc, txtid);
 }
+bool ath_tx_aggr_sleep(struct ath_softc *sc, struct ath_node *an)
+{
+        struct ath_atx_tid *tid;
+        struct ath_atx_ac *ac;
+        struct ath_txq *txq;
+        bool buffered = false;
+        int tidno;
+        for (tidno = 0, tid = &an->tid[tidno];
+             tidno < WME_NUM_TID; tidno++, tid++) {
+                if (!tid->sched)
+                        continue;
+                ac = tid->ac;
+                txq = ac->txq;
+                spin_lock_bh(&txq->axq_lock);
+                if (!list_empty(&tid->buf_q))
+                        buffered = true;
+                tid->sched = false;
+                list_del(&tid->list);
+                if (ac->sched) {
+                        ac->sched = false;
+                        list_del(&ac->list);
+                }
+                spin_unlock_bh(&txq->axq_lock);
+        }
+        return buffered;
+}
+void ath_tx_aggr_wakeup(struct ath_softc *sc, struct ath_node *an)
+{
+        struct ath_atx_tid *tid;
+        struct ath_atx_ac *ac;
+        struct ath_txq *txq;
+        int tidno;
+        for (tidno = 0, tid = &an->tid[tidno];
+             tidno < WME_NUM_TID; tidno++, tid++) {
+                ac = tid->ac;
+                txq = ac->txq;
+                spin_lock_bh(&txq->axq_lock);
+                ac->clear_ps_filter = true;
+                if (!list_empty(&tid->buf_q) && !tid->paused) {
+                        ath_tx_queue_tid(txq, tid);
+                        ath_txq_schedule(sc, txq);
+                }
+                spin_unlock_bh(&txq->axq_lock);
+        }
+}
 void ath_tx_aggr_resume(struct ath_softc *sc, struct ieee80211_sta *sta, u16 tid)
 {
        struct ath_atx_tid *txtid;
@@ -1451,7 +1526,7 @@ static void setup_frame_info(struct ieee80211_hw *hw, struct sk_buff *skb,
        struct ieee80211_key_conf *hw_key = tx_info->control.hw_key;
        struct ieee80211_hdr *hdr;
        struct ath_frame_info *fi = get_frame_info(skb);
-        struct ath_node *an;
+        struct ath_node *an = NULL;
        struct ath_atx_tid *tid;
        enum ath9k_key_type keytype;
        u16 seqno = 0;
@@ -1459,11 +1534,13 @@ static void setup_frame_info(struct ieee80211_hw *hw, struct sk_buff *skb,
        keytype = ath9k_cmn_get_hw_crypto_keytype(skb);
+        if (sta)
+                an = (struct ath_node *) sta->drv_priv;
        hdr = (struct ieee80211_hdr *)skb->data;
-        if (sta && ieee80211_is_data_qos(hdr->frame_control) &&
+        if (an && ieee80211_is_data_qos(hdr->frame_control) &&
                conf_is_ht(&hw->conf) && (sc->sc_flags & SC_OP_TXAGGR)) {
-                an = (struct ath_node *) sta->drv_priv;
                tidno = ieee80211_get_qos_ctl(hdr)[0] & IEEE80211_QOS_CTL_TID_MASK;
                /*
@@ -1479,6 +1556,8 @@ static void setup_frame_info(struct ieee80211_hw *hw, struct sk_buff *skb,
        memset(fi, 0, sizeof(*fi));
        if (hw_key)
                fi->keyix = hw_key->hw_key_idx;
+        else if (an && ieee80211_is_data(hdr->frame_control) && an->ps_key > 0)
+                fi->keyix = an->ps_key;
        else
                fi->keyix = ATH9K_TXKEYIX_INVALID;
        fi->keytype = keytype;
@@ -1491,7 +1570,6 @@ static int setup_tx_flags(struct sk_buff *skb)
        struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
        int flags = 0;
-        flags |= ATH9K_TXDESC_CLRDMASK; /* needed for crypto errors */
        flags |= ATH9K_TXDESC_INTREQ;
        if (tx_info->flags & IEEE80211_TX_CTL_NO_ACK)
@@ -1585,8 +1663,7 @@ static void ath_buf_set_rate(struct ath_softc *sc, struct ath_buf *bf, int len)
                rix = rates[i].idx;
                series[i].Tries = rates[i].count;
-                if ((sc->config.ath_aggr_prot && bf_isaggr(bf)) ||
+                    if (rates[i].flags & IEEE80211_TX_RC_USE_RTS_CTS) {
-                    (rates[i].flags & IEEE80211_TX_RC_USE_RTS_CTS)) {
                        series[i].RateFlags |= ATH9K_RATESERIES_RTS_CTS;
                        flags |= ATH9K_TXDESC_RTSENA;
                } else if (rates[i].flags & IEEE80211_TX_RC_USE_CTS_PROTECT) {
@@ -1655,8 +1732,6 @@ static void ath_buf_set_rate(struct ath_softc *sc, struct ath_buf *bf, int len)
                                     !is_pspoll, ctsrate,
                                     0, series, 4, flags);
-        if (sc->config.ath_aggr_prot && flags)
-                ath9k_hw_set11n_burstduration(sc->sc_ah, bf->bf_desc, 8192);
 }
 static struct ath_buf *ath_tx_setup_buffer(struct ieee80211_hw *hw,
@@ -1754,6 +1829,9 @@ static void ath_tx_start_dma(struct ath_softc *sc, struct ath_buf *bf,
                if (txctl->paprd)
                        bf->bf_state.bfs_paprd_timestamp = jiffies;
+                if (tx_info->flags & IEEE80211_TX_CTL_CLEAR_PS_FILT)
+                        ath9k_hw_set_clrdmask(sc->sc_ah, bf->bf_desc, true);
                ath_tx_send_normal(sc, txctl->txq, tid, &bf_head);
        }
@@ -1767,6 +1845,7 @@ int ath_tx_start(struct ieee80211_hw *hw, struct sk_buff *skb,
        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
        struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
        struct ieee80211_sta *sta = info->control.sta;
+        struct ieee80211_vif *vif = info->control.vif;
        struct ath_softc *sc = hw->priv;
        struct ath_txq *txq = txctl->txq;
        struct ath_buf *bf;
@@ -1804,6 +1883,11 @@ int ath_tx_start(struct ieee80211_hw *hw, struct sk_buff *skb,
                memmove(skb->data, skb->data + padsize, padpos);
        }
+        if ((vif && vif->type != NL80211_IFTYPE_AP &&
+                    vif->type != NL80211_IFTYPE_AP_VLAN) ||
+            !ieee80211_is_data(hdr->frame_control))
+                info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;
        setup_frame_info(hw, skb, frmlen);
        /*
@@ -1980,7 +2064,7 @@ static void ath_tx_rc_status(struct ath_softc *sc, struct ath_buf *bf,
                if (ieee80211_is_data(hdr->frame_control) &&
                    (ts->ts_flags & (ATH9K_TX_DATA_UNDERRUN |
                                     ATH9K_TX_DELIM_UNDERRUN)) &&
-                    ah->tx_trig_level >= sc->sc_ah->caps.tx_triglevel_max)
+                    ah->tx_trig_level >= sc->sc_ah->config.max_txtrig_level)
                        tx_info->status.rates[tx_rateindex].count =
                                hw->max_rate_tries;
        }
@@ -2099,28 +2183,6 @@ static void ath_tx_processq(struct ath_softc *sc, struct ath_txq *txq)
        }
 }
-static void ath_hw_pll_work(struct work_struct *work)
-{
-        struct ath_softc *sc = container_of(work, struct ath_softc,
-                                            hw_pll_work.work);
-        static int count;
-        if (AR_SREV_9485(sc->sc_ah)) {
-                if (ar9003_get_pll_sqsum_dvc(sc->sc_ah) >= 0x40000) {
-                        count++;
-                        if (count == 3) {
-                                /* Rx is hung for more than 500ms. Reset it */
-                                ath_reset(sc, true);
-                                count = 0;
-                        }
-                } else
-                        count = 0;
-                ieee80211_queue_delayed_work(sc->hw, &sc->hw_pll_work, HZ/5);
-        }
-}
 static void ath_tx_complete_poll_work(struct work_struct *work)
 {
        struct ath_softc *sc = container_of(work, struct ath_softc,
@@ -2144,33 +2206,6 @@ static void ath_tx_complete_poll_work(struct work_struct *work)
                                } else {
                                        txq->axq_tx_inprogress = true;
                                }
-                        } else {
-                                /* If the queue has pending buffers, then it
-                                 * should be doing tx work (and have axq_depth).
-                                 * Shouldn't get to this state I think..but
-                                 * we do.
-                                 */
-                                if (!(sc->sc_flags & (SC_OP_OFFCHANNEL)) &&
-                                    (txq->pending_frames > 0 ||
-                                     !list_empty(&txq->axq_acq) ||
-                                     txq->stopped)) {
-                                        ath_err(ath9k_hw_common(sc->sc_ah),
-                                                "txq: %p axq_qnum: %u,"
-                                                " mac80211_qnum: %i"
-                                                " axq_link: %p"
-                                                " pending frames: %i"
-                                                " axq_acq empty: %i"
-                                                " stopped: %i"
-                                                " axq_depth: 0  Attempting to"
-                                                " restart tx logic.\n",
-                                                txq, txq->axq_qnum,
-                                                txq->mac80211_qnum,
-                                                txq->axq_link,
-                                                txq->pending_frames,
-                                                list_empty(&txq->axq_acq),
-                                                txq->stopped);
-                                        ath_txq_schedule(sc, txq);
-                                }
                        }
                        spin_unlock_bh(&txq->axq_lock);
                }
@@ -2342,7 +2377,6 @@ int ath_tx_init(struct ath_softc *sc, int nbufs)
        }
        INIT_DELAYED_WORK(&sc->tx_complete_work, ath_tx_complete_poll_work);
-        INIT_DELAYED_WORK(&sc->hw_pll_work, ath_hw_pll_work);
        if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_EDMA) {
                error = ath_tx_edma_init(sc);
diff --git a/drivers/net/wireless/ath/carl9170/carl9170.h b/drivers/net/wireless/ath/carl9170/carl9170.h
index 3d4ed5863732..bb578690935e 100644
--- a/drivers/net/wireless/ath/carl9170/carl9170.h
+++ b/drivers/net/wireless/ath/carl9170/carl9170.h
@@ -448,6 +448,8 @@ struct carl9170_ba_stats {
 struct carl9170_sta_info {
        bool ht_sta;
+        bool sleeping;
+        atomic_t pending_frames;
        unsigned int ampdu_max_len;
        struct carl9170_sta_tid *agg[CARL9170_NUM_TID];
        struct carl9170_ba_stats stats[CARL9170_NUM_TID];
diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c
index 89fe60accf85..7d5c65ea94e6 100644
--- a/drivers/net/wireless/ath/carl9170/main.c
+++ b/drivers/net/wireless/ath/carl9170/main.c
@@ -883,7 +883,7 @@ static void carl9170_op_configure_filter(struct ieee80211_hw *hw,
         * then checking the error flags, later.
         */
-        if (changed_flags & FIF_ALLMULTI && *new_flags & FIF_ALLMULTI)
+        if (*new_flags & FIF_ALLMULTI)
                multicast = ~0ULL;
        if (multicast != ar->cur_mc_hash)
@@ -1193,6 +1193,8 @@ static int carl9170_op_sta_add(struct ieee80211_hw *hw,
        struct carl9170_sta_info *sta_info = (void *) sta->drv_priv;
        unsigned int i;
+        atomic_set(&sta_info->pending_frames, 0);
        if (sta->ht_cap.ht_supported) {
                if (sta->ht_cap.ampdu_density > 6) {
                        /*
@@ -1467,99 +1469,17 @@ static void carl9170_op_sta_notify(struct ieee80211_hw *hw,
                                   enum sta_notify_cmd cmd,
                                   struct ieee80211_sta *sta)
 {
-        struct ar9170 *ar = hw->priv;
        struct carl9170_sta_info *sta_info = (void *) sta->drv_priv;
-        struct sk_buff *skb, *tmp;
-        struct sk_buff_head free;
-        int i;
        switch (cmd) {
        case STA_NOTIFY_SLEEP:
-                /*
+                sta_info->sleeping = true;
-                 * Since the peer is no longer listening, we have to return
+                if (atomic_read(&sta_info->pending_frames))
-                 * as many SKBs as possible back to the mac80211 stack.
+                        ieee80211_sta_block_awake(hw, sta, true);
-                 * It will deal with the retry procedure, once the peer
-                 * has become available again.
-                 *
-                 * NB: Ideally, the driver should return the all frames in
-                 * the correct, ascending order. However, I think that this
-                 * functionality should be implemented in the stack and not
-                 * here...
-                 */
-                __skb_queue_head_init(&free);
-                if (sta->ht_cap.ht_supported) {
-                        rcu_read_lock();
-                        for (i = 0; i < CARL9170_NUM_TID; i++) {
-                                struct carl9170_sta_tid *tid_info;
-                                tid_info = rcu_dereference(sta_info->agg[i]);
-                                if (!tid_info)
-                                        continue;
-                                spin_lock_bh(&ar->tx_ampdu_list_lock);
-                                if (tid_info->state >
-                                    CARL9170_TID_STATE_SUSPEND)
-                                        tid_info->state =
-                                                CARL9170_TID_STATE_SUSPEND;
-                                spin_unlock_bh(&ar->tx_ampdu_list_lock);
-                                spin_lock_bh(&tid_info->lock);
-                                while ((skb = __skb_dequeue(&tid_info->queue)))
-                                        __skb_queue_tail(&free, skb);
-                                spin_unlock_bh(&tid_info->lock);
-                        }
-                        rcu_read_unlock();
-                }
-                for (i = 0; i < ar->hw->queues; i++) {
-                        spin_lock_bh(&ar->tx_pending[i].lock);
-                        skb_queue_walk_safe(&ar->tx_pending[i], skb, tmp) {
-                                struct _carl9170_tx_superframe *super;
-                                struct ieee80211_hdr *hdr;
-                                struct ieee80211_tx_info *info;
-                                super = (void *) skb->data;
-                                hdr = (void *) super->frame_data;
-                                if (compare_ether_addr(hdr->addr1, sta->addr))
-                                        continue;
-                                __skb_unlink(skb, &ar->tx_pending[i]);
-                                info = IEEE80211_SKB_CB(skb);
-                                if (info->flags & IEEE80211_TX_CTL_AMPDU)
-                                        atomic_dec(&ar->tx_ampdu_upload);
-                                carl9170_tx_status(ar, skb, false);
-                        }
-                        spin_unlock_bh(&ar->tx_pending[i].lock);
-                }
-                while ((skb = __skb_dequeue(&free)))
-                        carl9170_tx_status(ar, skb, false);
                break;
        case STA_NOTIFY_AWAKE:
-                if (!sta->ht_cap.ht_supported)
+                sta_info->sleeping = false;
-                        return;
-                rcu_read_lock();
-                for (i = 0; i < CARL9170_NUM_TID; i++) {
-                        struct carl9170_sta_tid *tid_info;
-                        tid_info = rcu_dereference(sta_info->agg[i]);
-                        if (!tid_info)
-                                continue;
-                        if ((tid_info->state == CARL9170_TID_STATE_SUSPEND))
-                                tid_info->state = CARL9170_TID_STATE_IDLE;
-                }
-                rcu_read_unlock();
                break;
        }
 }
diff --git a/drivers/net/wireless/ath/carl9170/tx.c b/drivers/net/wireless/ath/carl9170/tx.c
index cb70ed7ec5cc..e94084fcf6f5 100644
--- a/drivers/net/wireless/ath/carl9170/tx.c
+++ b/drivers/net/wireless/ath/carl9170/tx.c
@@ -104,12 +104,60 @@ static void carl9170_tx_accounting(struct ar9170 *ar, struct sk_buff *skb)
        spin_unlock_bh(&ar->tx_stats_lock);
 }
+/* needs rcu_read_lock */
+static struct ieee80211_sta *__carl9170_get_tx_sta(struct ar9170 *ar,
+                                                   struct sk_buff *skb)
+{
+        struct _carl9170_tx_superframe *super = (void *) skb->data;
+        struct ieee80211_hdr *hdr = (void *) super->frame_data;
+        struct ieee80211_vif *vif;
+        unsigned int vif_id;
+        vif_id = (super->s.misc & CARL9170_TX_SUPER_MISC_VIF_ID) >>
+                 CARL9170_TX_SUPER_MISC_VIF_ID_S;
+        if (WARN_ON_ONCE(vif_id >= AR9170_MAX_VIRTUAL_MAC))
+                return NULL;
+        vif = rcu_dereference(ar->vif_priv[vif_id].vif);
+        if (unlikely(!vif))
+                return NULL;
+        /*
+         * Normally we should use wrappers like ieee80211_get_DA to get
+         * the correct peer ieee80211_sta.
+         *
+         * But there is a problem with indirect traffic (broadcasts, or
+         * data which is designated for other stations) in station mode.
+         * The frame will be directed to the AP for distribution and not
+         * to the actual destination.
+         */
+        return ieee80211_find_sta(vif, hdr->addr1);
+}
+static void carl9170_tx_ps_unblock(struct ar9170 *ar, struct sk_buff *skb)
+{
+        struct ieee80211_sta *sta;
+        struct carl9170_sta_info *sta_info;
+        rcu_read_lock();
+        sta = __carl9170_get_tx_sta(ar, skb);
+        if (unlikely(!sta))
+                goto out_rcu;
+        sta_info = (struct carl9170_sta_info *) sta->drv_priv;
+        if (atomic_dec_return(&sta_info->pending_frames) == 0)
+                ieee80211_sta_block_awake(ar->hw, sta, false);
+out_rcu:
+        rcu_read_unlock();
+}
 static void carl9170_tx_accounting_free(struct ar9170 *ar, struct sk_buff *skb)
 {
-        struct ieee80211_tx_info *txinfo;
        int queue;
-        txinfo = IEEE80211_SKB_CB(skb);
        queue = skb_get_queue_mapping(skb);
        spin_lock_bh(&ar->tx_stats_lock);
@@ -135,6 +183,7 @@ static void carl9170_tx_accounting_free(struct ar9170 *ar, struct sk_buff *skb)
        }
        spin_unlock_bh(&ar->tx_stats_lock);
        if (atomic_dec_and_test(&ar->tx_total_queued))
                complete(&ar->tx_flush);
 }
@@ -329,13 +378,9 @@ static void carl9170_tx_status_process_ampdu(struct ar9170 *ar,
 {
        struct _carl9170_tx_superframe *super = (void *) skb->data;
        struct ieee80211_hdr *hdr = (void *) super->frame_data;
-        struct ieee80211_tx_info *tx_info;
-        struct carl9170_tx_info *ar_info;
-        struct carl9170_sta_info *sta_info;
        struct ieee80211_sta *sta;
+        struct carl9170_sta_info *sta_info;
        struct carl9170_sta_tid *tid_info;
-        struct ieee80211_vif *vif;
-        unsigned int vif_id;
        u8 tid;
        if (!(txinfo->flags & IEEE80211_TX_CTL_AMPDU) ||
@@ -343,30 +388,8 @@ static void carl9170_tx_status_process_ampdu(struct ar9170 *ar,
           (!(super->f.mac_control & cpu_to_le16(AR9170_TX_MAC_AGGR))))
                return;
-        tx_info = IEEE80211_SKB_CB(skb);
-        ar_info = (void *) tx_info->rate_driver_data;
-        vif_id = (super->s.misc & CARL9170_TX_SUPER_MISC_VIF_ID) >>
-                 CARL9170_TX_SUPER_MISC_VIF_ID_S;
-        if (WARN_ON_ONCE(vif_id >= AR9170_MAX_VIRTUAL_MAC))
-                return;
        rcu_read_lock();
-        vif = rcu_dereference(ar->vif_priv[vif_id].vif);
+        sta = __carl9170_get_tx_sta(ar, skb);
-        if (unlikely(!vif))
-                goto out_rcu;
-        /*
-         * Normally we should use wrappers like ieee80211_get_DA to get
-         * the correct peer ieee80211_sta.
-         *
-         * But there is a problem with indirect traffic (broadcasts, or
-         * data which is designated for other stations) in station mode.
-         * The frame will be directed to the AP for distribution and not
-         * to the actual destination.
-         */
-        sta = ieee80211_find_sta(vif, hdr->addr1);
        if (unlikely(!sta))
                goto out_rcu;
@@ -427,6 +450,7 @@ void carl9170_tx_status(struct ar9170 *ar, struct sk_buff *skb,
        if (txinfo->flags & IEEE80211_TX_CTL_AMPDU)
                carl9170_tx_status_process_ampdu(ar, skb, txinfo);
+        carl9170_tx_ps_unblock(ar, skb);
        carl9170_tx_put_skb(skb);
 }
@@ -540,11 +564,7 @@ static void carl9170_tx_ampdu_timeout(struct ar9170 *ar)
        struct sk_buff *skb;
        struct ieee80211_tx_info *txinfo;
        struct carl9170_tx_info *arinfo;
-        struct _carl9170_tx_superframe *super;
        struct ieee80211_sta *sta;
-        struct ieee80211_vif *vif;
-        struct ieee80211_hdr *hdr;
-        unsigned int vif_id;
        rcu_read_lock();
        list_for_each_entry_rcu(iter, &ar->tx_ampdu_list, list) {
@@ -562,20 +582,7 @@ static void carl9170_tx_ampdu_timeout(struct ar9170 *ar)
                    msecs_to_jiffies(CARL9170_QUEUE_TIMEOUT)))
                        goto unlock;
-                super = (void *) skb->data;
+                sta = __carl9170_get_tx_sta(ar, skb);
-                hdr = (void *) super->frame_data;
-                vif_id = (super->s.misc & CARL9170_TX_SUPER_MISC_VIF_ID) >>
-                         CARL9170_TX_SUPER_MISC_VIF_ID_S;
-                if (WARN_ON(vif_id >= AR9170_MAX_VIRTUAL_MAC))
-                        goto unlock;
-                vif = rcu_dereference(ar->vif_priv[vif_id].vif);
-                if (WARN_ON(!vif))
-                        goto unlock;
-                sta = ieee80211_find_sta(vif, hdr->addr1);
                if (WARN_ON(!sta))
                        goto unlock;
@@ -611,7 +618,6 @@ static void __carl9170_tx_process_status(struct ar9170 *ar,
 {
        struct sk_buff *skb;
        struct ieee80211_tx_info *txinfo;
-        struct carl9170_tx_info *arinfo;
        unsigned int r, t, q;
        bool success = true;
@@ -627,7 +633,6 @@ static void __carl9170_tx_process_status(struct ar9170 *ar,
        }
        txinfo = IEEE80211_SKB_CB(skb);
-        arinfo = (void *) txinfo->rate_driver_data;
        if (!(info & CARL9170_TX_STATUS_SUCCESS))
                success = false;
@@ -1199,15 +1204,6 @@ static struct sk_buff *carl9170_tx_pick_skb(struct ar9170 *ar,
        arinfo = (void *) info->rate_driver_data;
        arinfo->timeout = jiffies;
-        /*
-         * increase ref count to "2".
-         * Ref counting is the easiest way to solve the race between
-         * the the urb's completion routine: carl9170_tx_callback and
-         * wlan tx status functions: carl9170_tx_status/janitor.
-         */
-        carl9170_tx_get_skb(skb);
        return skb;
 err_unlock:
@@ -1228,6 +1224,36 @@ void carl9170_tx_drop(struct ar9170 *ar, struct sk_buff *skb)
        __carl9170_tx_process_status(ar, super->s.cookie, q);
 }
+static bool carl9170_tx_ps_drop(struct ar9170 *ar, struct sk_buff *skb)
+{
+        struct ieee80211_sta *sta;
+        struct carl9170_sta_info *sta_info;
+        rcu_read_lock();
+        sta = __carl9170_get_tx_sta(ar, skb);
+        if (!sta)
+                goto out_rcu;
+        sta_info = (void *) sta->drv_priv;
+        if (unlikely(sta_info->sleeping)) {
+                struct ieee80211_tx_info *tx_info;
+                rcu_read_unlock();
+                tx_info = IEEE80211_SKB_CB(skb);
+                if (tx_info->flags & IEEE80211_TX_CTL_AMPDU)
+                        atomic_dec(&ar->tx_ampdu_upload);
+                tx_info->flags |= IEEE80211_TX_STAT_TX_FILTERED;
+                carl9170_tx_status(ar, skb, false);
+                return true;
+        }
+out_rcu:
+        rcu_read_unlock();
+        return false;
+}
 static void carl9170_tx(struct ar9170 *ar)
 {
        struct sk_buff *skb;
@@ -1247,6 +1273,9 @@ static void carl9170_tx(struct ar9170 *ar)
                        if (unlikely(!skb))
                                break;
+                        if (unlikely(carl9170_tx_ps_drop(ar, skb)))
+                                continue;
                        atomic_inc(&ar->tx_total_pending);
                        q = __carl9170_get_queue(ar, i);
@@ -1256,6 +1285,16 @@ static void carl9170_tx(struct ar9170 *ar)
                         */
                        skb_queue_tail(&ar->tx_status[q], skb);
+                        /*
+                         * increase ref count to "2".
+                         * Ref counting is the easiest way to solve the
+                         * race between the urb's completion routine:
+                         *      carl9170_tx_callback
+                         * and wlan tx status functions:
+                         *      carl9170_tx_status/janitor.
+                         */
+                        carl9170_tx_get_skb(skb);
                        carl9170_usb_tx(ar, skb);
                        schedule_garbagecollector = true;
                }
@@ -1275,7 +1314,6 @@ static bool carl9170_tx_ampdu_queue(struct ar9170 *ar,
        struct carl9170_sta_info *sta_info;
        struct carl9170_sta_tid *agg;
        struct sk_buff *iter;
-        unsigned int max;
        u16 tid, seq, qseq, off;
        bool run = false;
@@ -1285,7 +1323,6 @@ static bool carl9170_tx_ampdu_queue(struct ar9170 *ar,
        rcu_read_lock();
        agg = rcu_dereference(sta_info->agg[tid]);
-        max = sta_info->ampdu_max_len;
        if (!agg)
                goto err_unlock_rcu;
@@ -1368,6 +1405,11 @@ void carl9170_op_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
         * all ressouces which are associated with the frame.
         */
+        if (sta) {
+                struct carl9170_sta_info *stai = (void *) sta->drv_priv;
+                atomic_inc(&stai->pending_frames);
+        }
        if (info->flags & IEEE80211_TX_CTL_AMPDU) {
                run = carl9170_tx_ampdu_queue(ar, sta, skb);
                if (run)
diff --git a/drivers/net/wireless/ath/key.c b/drivers/net/wireless/ath/key.c
index 37b8e115375a..a61ef3d6d89c 100644
--- a/drivers/net/wireless/ath/key.c
+++ b/drivers/net/wireless/ath/key.c
@@ -23,6 +23,14 @@
 #define REG_READ                        (common->ops->read)
 #define REG_WRITE(_ah, _reg, _val)      (common->ops->write)(_ah, _val, _reg)
+#define ENABLE_REGWRITE_BUFFER(_ah)                     \
+        if (common->ops->enable_write_buffer)           \
+                common->ops->enable_write_buffer((_ah));
+#define REGWRITE_BUFFER_FLUSH(_ah)                      \
+        if (common->ops->write_flush)                   \
+                common->ops->write_flush((_ah));
 #define IEEE80211_WEP_NKID      4       /* number of key ids */
@@ -42,6 +50,8 @@ bool ath_hw_keyreset(struct ath_common *common, u16 entry)
        keyType = REG_READ(ah, AR_KEYTABLE_TYPE(entry));
+        ENABLE_REGWRITE_BUFFER(ah);
        REG_WRITE(ah, AR_KEYTABLE_KEY0(entry), 0);
        REG_WRITE(ah, AR_KEYTABLE_KEY1(entry), 0);
        REG_WRITE(ah, AR_KEYTABLE_KEY2(entry), 0);
@@ -66,6 +76,8 @@ bool ath_hw_keyreset(struct ath_common *common, u16 entry)
        }
+        REGWRITE_BUFFER_FLUSH(ah);
        return true;
 }
 EXPORT_SYMBOL(ath_hw_keyreset);
@@ -104,9 +116,13 @@ static bool ath_hw_keysetmac(struct ath_common *common,
        } else {
                macLo = macHi = 0;
        }
+        ENABLE_REGWRITE_BUFFER(ah);
        REG_WRITE(ah, AR_KEYTABLE_MAC0(entry), macLo);
        REG_WRITE(ah, AR_KEYTABLE_MAC1(entry), macHi | unicast_flag);
+        REGWRITE_BUFFER_FLUSH(ah);
        return true;
 }
@@ -223,6 +239,8 @@ static bool ath_hw_set_keycache_entry(struct ath_common *common, u16 entry,
                        mic3 = get_unaligned_le16(k->kv_txmic + 0) & 0xffff;
                        mic4 = get_unaligned_le32(k->kv_txmic + 4);
+                        ENABLE_REGWRITE_BUFFER(ah);
                        /* Write RX[31:0] and TX[31:16] */
                        REG_WRITE(ah, AR_KEYTABLE_KEY0(micentry), mic0);
                        REG_WRITE(ah, AR_KEYTABLE_KEY1(micentry), mic1);
@@ -236,6 +254,8 @@ static bool ath_hw_set_keycache_entry(struct ath_common *common, u16 entry,
                        REG_WRITE(ah, AR_KEYTABLE_TYPE(micentry),
                                  AR_KEYTABLE_TYPE_CLR);
+                        REGWRITE_BUFFER_FLUSH(ah);
                } else {
                        /*
                         * TKIP uses four key cache entries (two for group
@@ -258,6 +278,8 @@ static bool ath_hw_set_keycache_entry(struct ath_common *common, u16 entry,
                        mic0 = get_unaligned_le32(k->kv_mic + 0);
                        mic2 = get_unaligned_le32(k->kv_mic + 4);
+                        ENABLE_REGWRITE_BUFFER(ah);
                        /* Write MIC key[31:0] */
                        REG_WRITE(ah, AR_KEYTABLE_KEY0(micentry), mic0);
                        REG_WRITE(ah, AR_KEYTABLE_KEY1(micentry), 0);
@@ -270,8 +292,12 @@ static bool ath_hw_set_keycache_entry(struct ath_common *common, u16 entry,
                        REG_WRITE(ah, AR_KEYTABLE_KEY4(micentry), 0);
                        REG_WRITE(ah, AR_KEYTABLE_TYPE(micentry),
                                  AR_KEYTABLE_TYPE_CLR);
+                        REGWRITE_BUFFER_FLUSH(ah);
                }
+                ENABLE_REGWRITE_BUFFER(ah);
                /* MAC address registers are reserved for the MIC entry */
                REG_WRITE(ah, AR_KEYTABLE_MAC0(micentry), 0);
                REG_WRITE(ah, AR_KEYTABLE_MAC1(micentry), 0);
@@ -283,7 +309,11 @@ static bool ath_hw_set_keycache_entry(struct ath_common *common, u16 entry,
                 */
                REG_WRITE(ah, AR_KEYTABLE_KEY0(entry), key0);
                REG_WRITE(ah, AR_KEYTABLE_KEY1(entry), key1);
+                REGWRITE_BUFFER_FLUSH(ah);
        } else {
+                ENABLE_REGWRITE_BUFFER(ah);
                /* Write key[47:0] */
                REG_WRITE(ah, AR_KEYTABLE_KEY0(entry), key0);
                REG_WRITE(ah, AR_KEYTABLE_KEY1(entry), key1);
@@ -296,6 +326,8 @@ static bool ath_hw_set_keycache_entry(struct ath_common *common, u16 entry,
                REG_WRITE(ah, AR_KEYTABLE_KEY4(entry), key4);
                REG_WRITE(ah, AR_KEYTABLE_TYPE(entry), keyType);
+                REGWRITE_BUFFER_FLUSH(ah);
                /* Write MAC address for the entry */
                (void) ath_hw_keysetmac(common, entry, mac);
        }
@@ -451,6 +483,9 @@ int ath_key_config(struct ath_common *common,
        memset(&hk, 0, sizeof(hk));
        switch (key->cipher) {
+        case 0:
+                hk.kv_type = ATH_CIPHER_CLR;
+                break;
        case WLAN_CIPHER_SUITE_WEP40:
        case WLAN_CIPHER_SUITE_WEP104:
                hk.kv_type = ATH_CIPHER_WEP;
@@ -466,7 +501,8 @@ int ath_key_config(struct ath_common *common,
        }
        hk.kv_len = key->keylen;
-        memcpy(hk.kv_val, key->key, key->keylen);
+        if (key->keylen)
+                memcpy(hk.kv_val, key->key, key->keylen);
        if (!(key->flags & IEEE80211_KEY_FLAG_PAIRWISE)) {
                switch (vif->type) {
diff --git a/drivers/net/wireless/ath/regd.c b/drivers/net/wireless/ath/regd.c
index 0e1b8793c864..028310f263c8 100644
--- a/drivers/net/wireless/ath/regd.c
+++ b/drivers/net/wireless/ath/regd.c
@@ -97,8 +97,8 @@ static const struct ieee80211_regdomain ath_world_regdom_66_69 = {
        }
 };
-/* Can be used by 0x67, 0x6A and 0x68 */
+/* Can be used by 0x67, 0x68, 0x6A and 0x6C */
-static const struct ieee80211_regdomain ath_world_regdom_67_68_6A = {
+static const struct ieee80211_regdomain ath_world_regdom_67_68_6A_6C = {
        .n_reg_rules = 4,
        .alpha2 =  "99",
        .reg_rules = {
@@ -151,7 +151,8 @@ ieee80211_regdomain *ath_world_regdomain(struct ath_regulatory *reg)
        case 0x67:
        case 0x68:
        case 0x6A:
-                return &ath_world_regdom_67_68_6A;
+        case 0x6C:
+                return &ath_world_regdom_67_68_6A_6C;
        default:
                WARN_ON(1);
                return ath_default_world_regdomain();
@@ -333,6 +334,7 @@ static void ath_reg_apply_world_flags(struct wiphy *wiphy,
        case 0x63:
        case 0x66:
        case 0x67:
+        case 0x6C:
                ath_reg_apply_beaconing_flags(wiphy, initiator);
                break;
        case 0x68:
diff --git a/drivers/net/wireless/ath/regd_common.h b/drivers/net/wireless/ath/regd_common.h
index 5c2cfe694152..24b53839fc3a 100644
--- a/drivers/net/wireless/ath/regd_common.h
+++ b/drivers/net/wireless/ath/regd_common.h
@@ -86,6 +86,7 @@ enum EnumRd {
        WOR9_WORLD = 0x69,
        WORA_WORLD = 0x6A,
        WORB_WORLD = 0x6B,
+        WORC_WORLD = 0x6C,
        MKK3_MKKB = 0x80,
        MKK3_MKKA2 = 0x81,
@@ -282,6 +283,7 @@ static struct reg_dmn_pair_mapping regDomainPairs[] = {
        {WOR9_WORLD, NO_CTL, NO_CTL},
        {WORA_WORLD, NO_CTL, NO_CTL},
        {WORB_WORLD, NO_CTL, NO_CTL},
+        {WORC_WORLD, NO_CTL, NO_CTL},
 };
 static struct country_code_to_enum_rd allCountries[] = {
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 5af40d9170a0..5a43984bdcea 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -2686,6 +2686,17 @@ out:
        dev->mac_suspended++;
 }
+/* http://bcm-v4.sipsolutions.net/802.11/PHY/N/MacPhyClkSet */
+void b43_mac_phy_clock_set(struct b43_wldev *dev, bool on)
+{
+        u32 tmslow = ssb_read32(dev->dev, SSB_TMSLOW);
+        if (on)
+                tmslow |= B43_TMSLOW_MACPHYCLKEN;
+        else
+                tmslow &= ~B43_TMSLOW_MACPHYCLKEN;
+        ssb_write32(dev->dev, SSB_TMSLOW, tmslow);
+}
 static void b43_adjust_opmode(struct b43_wldev *dev)
 {
        struct b43_wl *wl = dev->wl;
@@ -2842,7 +2853,7 @@ static int b43_chip_init(struct b43_wldev *dev)
 {
        struct b43_phy *phy = &dev->phy;
        int err;
-        u32 value32, macctl;
+        u32 macctl;
        u16 value16;
        /* Initialize the MAC control */
@@ -2920,9 +2931,7 @@ static int b43_chip_init(struct b43_wldev *dev)
        b43_write32(dev, B43_MMIO_DMA4_IRQ_MASK, 0x0000DC00);
        b43_write32(dev, B43_MMIO_DMA5_IRQ_MASK, 0x0000DC00);
-        value32 = ssb_read32(dev->dev, SSB_TMSLOW);
+        b43_mac_phy_clock_set(dev, true);
-        value32 |= 0x00100000;
-        ssb_write32(dev->dev, SSB_TMSLOW, value32);
        b43_write16(dev, B43_MMIO_POWERUP_DELAY,
                    dev->dev->bus->chipco.fast_pwrup_delay);
@@ -4213,33 +4222,18 @@ static void b43_bluetooth_coext_disable(struct b43_wldev *dev)
 static void b43_imcfglo_timeouts_workaround(struct b43_wldev *dev)
 {
-#ifdef CONFIG_SSB_DRIVER_PCICORE
        struct ssb_bus *bus = dev->dev->bus;
        u32 tmp;
-        if (bus->pcicore.dev &&
+        if ((bus->chip_id == 0x4311 && bus->chip_rev == 2) ||
-            bus->pcicore.dev->id.coreid == SSB_DEV_PCI &&
+            (bus->chip_id == 0x4312)) {
-            bus->pcicore.dev->id.revision <= 5) {
-                /* IMCFGLO timeouts workaround. */
                tmp = ssb_read32(dev->dev, SSB_IMCFGLO);
-                switch (bus->bustype) {
+                tmp &= ~SSB_IMCFGLO_REQTO;
-                case SSB_BUSTYPE_PCI:
+                tmp &= ~SSB_IMCFGLO_SERTO;
-                case SSB_BUSTYPE_PCMCIA:
+                tmp |= 0x3;
-                        tmp &= ~SSB_IMCFGLO_REQTO;
-                        tmp &= ~SSB_IMCFGLO_SERTO;
-                        tmp |= 0x32;
-                        break;
-                case SSB_BUSTYPE_SSB:
-                        tmp &= ~SSB_IMCFGLO_REQTO;
-                        tmp &= ~SSB_IMCFGLO_SERTO;
-                        tmp |= 0x53;
-                        break;
-                default:
-                        break;
-                }
                ssb_write32(dev->dev, SSB_IMCFGLO, tmp);
+                ssb_commit_settings(bus);
        }
-#endif /* CONFIG_SSB_DRIVER_PCICORE */
 }
 static void b43_set_synth_pu_delay(struct b43_wldev *dev, bool idle)
@@ -4863,25 +4857,8 @@ static void b43_one_core_detach(struct ssb_device *dev)
 static int b43_one_core_attach(struct ssb_device *dev, struct b43_wl *wl)
 {
        struct b43_wldev *wldev;
-        struct pci_dev *pdev;
        int err = -ENOMEM;
-        if (!list_empty(&wl->devlist)) {
-                /* We are not the first core on this chip. */
-                pdev = (dev->bus->bustype == SSB_BUSTYPE_PCI) ? dev->bus->host_pci : NULL;
-                /* Only special chips support more than one wireless
-                 * core, although some of the other chips have more than
-                 * one wireless core as well. Check for this and
-                 * bail out early.
-                 */
-                if (!pdev ||
-                    ((pdev->device != 0x4321) &&
-                     (pdev->device != 0x4313) && (pdev->device != 0x431A))) {
-                        b43dbg(wl, "Ignoring unconnected 802.11 core\n");
-                        return -ENODEV;
-                }
-        }
        wldev = kzalloc(sizeof(*wldev), GFP_KERNEL);
        if (!wldev)
                goto out;
@@ -5002,7 +4979,7 @@ out:
        return err;
 }
-static int b43_probe(struct ssb_device *dev, const struct ssb_device_id *id)
+static int b43_ssb_probe(struct ssb_device *dev, const struct ssb_device_id *id)
 {
        struct b43_wl *wl;
        int err;
@@ -5040,7 +5017,7 @@ static int b43_probe(struct ssb_device *dev, const struct ssb_device_id *id)
        return err;
 }
-static void b43_remove(struct ssb_device *dev)
+static void b43_ssb_remove(struct ssb_device *dev)
 {
        struct b43_wl *wl = ssb_get_devtypedata(dev);
        struct b43_wldev *wldev = ssb_get_drvdata(dev);
@@ -5083,8 +5060,8 @@ void b43_controller_restart(struct b43_wldev *dev, const char *reason)
 static struct ssb_driver b43_ssb_driver = {
        .name           = KBUILD_MODNAME,
        .id_table       = b43_ssb_tbl,
-        .probe          = b43_probe,
+        .probe          = b43_ssb_probe,
-        .remove         = b43_remove,
+        .remove         = b43_ssb_remove,
 };
 static void b43_print_driverinfo(void)
diff --git a/drivers/net/wireless/b43/main.h b/drivers/net/wireless/b43/main.h
index 40db03678d9f..a0d327f13183 100644
--- a/drivers/net/wireless/b43/main.h
+++ b/drivers/net/wireless/b43/main.h
@@ -133,6 +133,7 @@ void b43_power_saving_ctl_bits(struct b43_wldev *dev, unsigned int ps_flags);
 void b43_mac_suspend(struct b43_wldev *dev);
 void b43_mac_enable(struct b43_wldev *dev);
+void b43_mac_phy_clock_set(struct b43_wldev *dev, bool on);
 struct b43_request_fw_context;
diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
index 8a00f9a95dbb..b075a3f82a43 100644
--- a/drivers/net/wireless/b43/phy_n.c
+++ b/drivers/net/wireless/b43/phy_n.c
@@ -2281,6 +2281,7 @@ static int b43_nphy_poll_rssi(struct b43_wldev *dev, u8 type, s32 *buf,
                save_regs_phy[5] = b43_phy_read(dev, B43_NPHY_AFECTL_OVER);
                save_regs_phy[6] = b43_phy_read(dev, B43_NPHY_TXF_40CO_B1S0);
                save_regs_phy[7] = b43_phy_read(dev, B43_NPHY_TXF_40CO_B32S1);
+                save_regs_phy[8] = 0;
        } else {
                save_regs_phy[0] = b43_phy_read(dev, B43_NPHY_AFECTL_C1);
                save_regs_phy[1] = b43_phy_read(dev, B43_NPHY_AFECTL_C2);
@@ -2289,6 +2290,8 @@ static int b43_nphy_poll_rssi(struct b43_wldev *dev, u8 type, s32 *buf,
                save_regs_phy[4] = b43_phy_read(dev, B43_NPHY_RFCTL_OVER);
                save_regs_phy[5] = b43_phy_read(dev, B43_NPHY_RFCTL_RSSIO1);
                save_regs_phy[6] = b43_phy_read(dev, B43_NPHY_RFCTL_RSSIO2);
+                save_regs_phy[7] = 0;
+                save_regs_phy[8] = 0;
        }
        b43_nphy_rssi_select(dev, 5, type);
@@ -3537,17 +3540,6 @@ static int b43_nphy_cal_rx_iq(struct b43_wldev *dev,
                return b43_nphy_rev2_cal_rx_iq(dev, target, type, debug);
 }
-/* http://bcm-v4.sipsolutions.net/802.11/PHY/N/MacPhyClkSet */
-static void b43_nphy_mac_phy_clock_set(struct b43_wldev *dev, bool on)
-{
-        u32 tmslow = ssb_read32(dev->dev, SSB_TMSLOW);
-        if (on)
-                tmslow |= B43_TMSLOW_MACPHYCLKEN;
-        else
-                tmslow &= ~B43_TMSLOW_MACPHYCLKEN;
-        ssb_write32(dev->dev, SSB_TMSLOW, tmslow);
-}
 /* http://bcm-v4.sipsolutions.net/802.11/PHY/N/RxCoreSetState */
 static void b43_nphy_set_rx_core_state(struct b43_wldev *dev, u8 mask)
 {
@@ -3688,7 +3680,7 @@ int b43_phy_initn(struct b43_wldev *dev)
        b43_phy_write(dev, B43_NPHY_BBCFG, tmp & ~B43_NPHY_BBCFG_RSTCCA);
        b43_nphy_bmac_clock_fgc(dev, 0);
-        b43_nphy_mac_phy_clock_set(dev, true);
+        b43_mac_phy_clock_set(dev, true);
        b43_nphy_pa_override(dev, false);
        b43_nphy_force_rf_sequence(dev, B43_RFSEQ_RX2TX);
@@ -3845,8 +3837,8 @@ static int b43_nphy_set_channel(struct b43_wldev *dev,
 {
        struct b43_phy *phy = &dev->phy;
-        const struct b43_nphy_channeltab_entry_rev2 *tabent_r2;
+        const struct b43_nphy_channeltab_entry_rev2 *tabent_r2 = NULL;
-        const struct b43_nphy_channeltab_entry_rev3 *tabent_r3;
+        const struct b43_nphy_channeltab_entry_rev3 *tabent_r3 = NULL;
        u8 tmp;
diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c
index c7fd73e3ad76..1ab8861dd43a 100644
--- a/drivers/net/wireless/b43legacy/main.c
+++ b/drivers/net/wireless/b43legacy/main.c
@@ -2234,7 +2234,7 @@ static int b43legacy_chip_init(struct b43legacy_wldev *dev)
        b43legacy_write32(dev, B43legacy_MMIO_DMA5_IRQ_MASK, 0x0000DC00);
        value32 = ssb_read32(dev->dev, SSB_TMSLOW);
-        value32 |= 0x00100000;
+        value32 |= B43legacy_TMSLOW_MACPHYCLKEN;
        ssb_write32(dev->dev, SSB_TMSLOW, value32);
        b43legacy_write16(dev, B43legacy_MMIO_POWERUP_DELAY,
@@ -3104,37 +3104,6 @@ static void setup_struct_wldev_for_init(struct b43legacy_wldev *dev)
        memset(&dev->noisecalc, 0, sizeof(dev->noisecalc));
 }
-static void b43legacy_imcfglo_timeouts_workaround(struct b43legacy_wldev *dev)
-{
-#ifdef CONFIG_SSB_DRIVER_PCICORE
-        struct ssb_bus *bus = dev->dev->bus;
-        u32 tmp;
-        if (bus->pcicore.dev &&
-            bus->pcicore.dev->id.coreid == SSB_DEV_PCI &&
-            bus->pcicore.dev->id.revision <= 5) {
-                /* IMCFGLO timeouts workaround. */
-                tmp = ssb_read32(dev->dev, SSB_IMCFGLO);
-                switch (bus->bustype) {
-                case SSB_BUSTYPE_PCI:
-                case SSB_BUSTYPE_PCMCIA:
-                        tmp &= ~SSB_IMCFGLO_REQTO;
-                        tmp &= ~SSB_IMCFGLO_SERTO;
-                        tmp |= 0x32;
-                        break;
-                case SSB_BUSTYPE_SSB:
-                        tmp &= ~SSB_IMCFGLO_REQTO;
-                        tmp &= ~SSB_IMCFGLO_SERTO;
-                        tmp |= 0x53;
-                        break;
-                default:
-                        break;
-                }
-                ssb_write32(dev->dev, SSB_IMCFGLO, tmp);
-        }
-#endif /* CONFIG_SSB_DRIVER_PCICORE */
-}
 static void b43legacy_set_synth_pu_delay(struct b43legacy_wldev *dev,
                                          bool idle) {
        u16 pu_delay = 1050;
@@ -3278,7 +3247,6 @@ static int b43legacy_wireless_core_init(struct b43legacy_wldev *dev)
        /* Enable IRQ routing to this device. */
        ssb_pcicore_dev_irqvecs_enable(&bus->pcicore, dev->dev);
-        b43legacy_imcfglo_timeouts_workaround(dev);
        prepare_phy_data_for_init(dev);
        b43legacy_phy_calibrate(dev);
        err = b43legacy_chip_init(dev);
@@ -3728,26 +3696,8 @@ static int b43legacy_one_core_attach(struct ssb_device *dev,
                                     struct b43legacy_wl *wl)
 {
        struct b43legacy_wldev *wldev;
-        struct pci_dev *pdev;
        int err = -ENOMEM;
-        if (!list_empty(&wl->devlist)) {
-                /* We are not the first core on this chip. */
-                pdev = (dev->bus->bustype == SSB_BUSTYPE_PCI) ? dev->bus->host_pci : NULL;
-                /* Only special chips support more than one wireless
-                 * core, although some of the other chips have more than
-                 * one wireless core as well. Check for this and
-                 * bail out early.
-                 */
-                if (!pdev ||
-                    ((pdev->device != 0x4321) &&
-                     (pdev->device != 0x4313) &&
-                     (pdev->device != 0x431A))) {
-                        b43legacydbg(wl, "Ignoring unconnected 802.11 core\n");
-                        return -ENODEV;
-                }
-        }
        wldev = kzalloc(sizeof(*wldev), GFP_KERNEL);
        if (!wldev)
                goto out;
diff --git a/drivers/net/wireless/hostap/hostap_main.c b/drivers/net/wireless/hostap/hostap_main.c
index 1d9aed645723..d5084829c9e5 100644
--- a/drivers/net/wireless/hostap/hostap_main.c
+++ b/drivers/net/wireless/hostap/hostap_main.c
@@ -79,13 +79,8 @@ struct net_device * hostap_add_interface(struct local_info *local,
        if (!rtnl_locked)
                rtnl_lock();
-        ret = 0;
-        if (strchr(dev->name, '%'))
-                ret = dev_alloc_name(dev, dev->name);
        SET_NETDEV_DEV(dev, mdev->dev.parent);
-        if (ret >= 0)
+        ret = register_netdevice(dev);
-                ret = register_netdevice(dev);
        if (!rtnl_locked)
                rtnl_unlock();
diff --git a/drivers/net/wireless/iwlegacy/iwl-4965-lib.c b/drivers/net/wireless/iwlegacy/iwl-4965-lib.c
index 5a8a3cce27bc..7e5e85a017b5 100644
--- a/drivers/net/wireless/iwlegacy/iwl-4965-lib.c
+++ b/drivers/net/wireless/iwlegacy/iwl-4965-lib.c
@@ -955,9 +955,6 @@ int iwl4965_request_scan(struct iwl_priv *priv, struct ieee80211_vif *vif)
        if (priv->cfg->scan_rx_antennas[band])
                rx_ant = priv->cfg->scan_rx_antennas[band];
-        if (priv->cfg->scan_tx_antennas[band])
-                scan_tx_antennas = priv->cfg->scan_tx_antennas[band];
        priv->scan_tx_ant[band] = iwl4965_toggle_tx_ant(priv,
                                                priv->scan_tx_ant[band],
                                                    scan_tx_antennas);
diff --git a/drivers/net/wireless/iwlegacy/iwl-4965-rs.c b/drivers/net/wireless/iwlegacy/iwl-4965-rs.c
index 31ac672b64e1..24d149909ba3 100644
--- a/drivers/net/wireless/iwlegacy/iwl-4965-rs.c
+++ b/drivers/net/wireless/iwlegacy/iwl-4965-rs.c
@@ -2604,7 +2604,7 @@ static ssize_t iwl4965_rs_sta_dbgfs_scale_table_write(struct file *file,
        struct iwl_lq_sta *lq_sta = file->private_data;
        struct iwl_priv *priv;
        char buf[64];
-        int buf_size;
+        size_t buf_size;
        u32 parsed_rate;
        struct iwl_station_priv *sta_priv =
                container_of(lq_sta, struct iwl_station_priv, lq_sta);
@@ -2860,7 +2860,6 @@ static struct rate_control_ops rs_4965_ops = {
 int iwl4965_rate_control_register(void)
 {
-        pr_err("Registering 4965 rate control operations\n");
        return ieee80211_rate_control_register(&rs_4965_ops);
 }
diff --git a/drivers/net/wireless/iwlegacy/iwl-core.c b/drivers/net/wireless/iwlegacy/iwl-core.c
index 42db0fc8b921..42df8321dae8 100644
--- a/drivers/net/wireless/iwlegacy/iwl-core.c
+++ b/drivers/net/wireless/iwlegacy/iwl-core.c
@@ -211,10 +211,7 @@ int iwl_legacy_init_geos(struct iwl_priv *priv)
                if (!iwl_legacy_is_channel_valid(ch))
                        continue;
-                if (iwl_legacy_is_channel_a_band(ch))
+                sband = &priv->bands[ch->band];
-                        sband =  &priv->bands[IEEE80211_BAND_5GHZ];
-                else
-                        sband =  &priv->bands[IEEE80211_BAND_2GHZ];
                geo_ch = &sband->channels[sband->n_channels++];
@@ -2117,10 +2114,9 @@ int iwl_legacy_mac_config(struct ieee80211_hw *hw, u32 changed)
        IWL_DEBUG_MAC80211(priv, "enter to channel %d changed 0x%X\n",
                                        channel->hw_value, changed);
-        if (unlikely(!priv->cfg->mod_params->disable_hw_scan &&
+        if (unlikely(test_bit(STATUS_SCANNING, &priv->status))) {
-                        test_bit(STATUS_SCANNING, &priv->status))) {
                scan_active = 1;
-                IWL_DEBUG_MAC80211(priv, "leave - scanning\n");
+                IWL_DEBUG_MAC80211(priv, "scan active\n");
        }
        if (changed & (IEEE80211_CONF_CHANGE_SMPS |
@@ -2440,11 +2436,13 @@ void iwl_legacy_mac_bss_info_changed(struct ieee80211_hw *hw,
        IWL_DEBUG_MAC80211(priv, "changes = 0x%X\n", changes);
-        if (!iwl_legacy_is_alive(priv))
-                return;
        mutex_lock(&priv->mutex);
+        if (!iwl_legacy_is_alive(priv)) {
+                mutex_unlock(&priv->mutex);
+                return;
+        }
        if (changes & BSS_CHANGED_QOS) {
                unsigned long flags;
@@ -2653,7 +2651,7 @@ unplugged:
 none:
        /* re-enable interrupts here since we don't have anything to service. */
-        /* only Re-enable if diabled by irq */
+        /* only Re-enable if disabled by irq */
        if (test_bit(STATUS_INT_ENABLED, &priv->status))
                iwl_legacy_enable_interrupts(priv);
        spin_unlock_irqrestore(&priv->lock, flags);
diff --git a/drivers/net/wireless/iwlegacy/iwl-core.h b/drivers/net/wireless/iwlegacy/iwl-core.h
index f03b463e4378..bc66c604106c 100644
--- a/drivers/net/wireless/iwlegacy/iwl-core.h
+++ b/drivers/net/wireless/iwlegacy/iwl-core.h
@@ -287,7 +287,6 @@ struct iwl_cfg {
        struct iwl_base_params *base_params;
        /* params likely to change within a device family */
        u8 scan_rx_antennas[IEEE80211_NUM_BANDS];
-        u8 scan_tx_antennas[IEEE80211_NUM_BANDS];
        enum iwl_led_mode led_mode;
 };
diff --git a/drivers/net/wireless/iwlegacy/iwl-dev.h b/drivers/net/wireless/iwlegacy/iwl-dev.h
index f43ac1eb9014..be0106c6a2da 100644
--- a/drivers/net/wireless/iwlegacy/iwl-dev.h
+++ b/drivers/net/wireless/iwlegacy/iwl-dev.h
@@ -134,7 +134,7 @@ struct iwl_queue {
                                * space more than this */
        int high_mark;         /* high watermark, stop queue if free
                                * space less than this */
-} __packed;
+};
 /* One for each TFD */
 struct iwl_tx_info {
@@ -290,6 +290,7 @@ enum {
        CMD_SIZE_HUGE = (1 << 0),
        CMD_ASYNC = (1 << 1),
        CMD_WANT_SKB = (1 << 2),
+        CMD_MAPPED = (1 << 3),
 };
 #define DEF_CMD_PAYLOAD_SIZE 320
@@ -1076,7 +1077,6 @@ struct iwl_priv {
        spinlock_t hcmd_lock;   /* protect hcmd */
        spinlock_t reg_lock;    /* protect hw register access */
        struct mutex mutex;
-        struct mutex sync_cmd_mutex; /* enable serialization of sync commands */
        /* basic pci-network driver stuff */
        struct pci_dev *pci_dev;
diff --git a/drivers/net/wireless/iwlegacy/iwl-hcmd.c b/drivers/net/wireless/iwlegacy/iwl-hcmd.c
index 9d721cbda5bb..62b4b09122cb 100644
--- a/drivers/net/wireless/iwlegacy/iwl-hcmd.c
+++ b/drivers/net/wireless/iwlegacy/iwl-hcmd.c
@@ -145,6 +145,8 @@ int iwl_legacy_send_cmd_sync(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
        int cmd_idx;
        int ret;
+        lockdep_assert_held(&priv->mutex);
        BUG_ON(cmd->flags & CMD_ASYNC);
         /* A synchronous command can not have a callback set. */
@@ -152,7 +154,6 @@ int iwl_legacy_send_cmd_sync(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
        IWL_DEBUG_INFO(priv, "Attempting to send sync command %s\n",
                        iwl_legacy_get_cmd_string(cmd->id));
-        mutex_lock(&priv->sync_cmd_mutex);
        set_bit(STATUS_HCMD_ACTIVE, &priv->status);
        IWL_DEBUG_INFO(priv, "Setting HCMD_ACTIVE for command %s\n",
@@ -224,7 +225,6 @@ fail:
                cmd->reply_page = 0;
        }
 out:
-        mutex_unlock(&priv->sync_cmd_mutex);
        return ret;
 }
 EXPORT_SYMBOL(iwl_legacy_send_cmd_sync);
diff --git a/drivers/net/wireless/iwlegacy/iwl-helpers.h b/drivers/net/wireless/iwlegacy/iwl-helpers.h
index 02132e755831..a6effdae63f9 100644
--- a/drivers/net/wireless/iwlegacy/iwl-helpers.h
+++ b/drivers/net/wireless/iwlegacy/iwl-helpers.h
@@ -149,6 +149,12 @@ static inline void iwl_legacy_disable_interrupts(struct iwl_priv *priv)
        IWL_DEBUG_ISR(priv, "Disabled interrupts\n");
 }
+static inline void iwl_legacy_enable_rfkill_int(struct iwl_priv *priv)
+{
+        IWL_DEBUG_ISR(priv, "Enabling rfkill interrupt\n");
+        iwl_write32(priv, CSR_INT_MASK, CSR_INT_BIT_RF_KILL);
+}
 static inline void iwl_legacy_enable_interrupts(struct iwl_priv *priv)
 {
        IWL_DEBUG_ISR(priv, "Enabling interrupts\n");
diff --git a/drivers/net/wireless/iwlegacy/iwl-tx.c b/drivers/net/wireless/iwlegacy/iwl-tx.c
index a227773cb384..4fff995c6f3e 100644
--- a/drivers/net/wireless/iwlegacy/iwl-tx.c
+++ b/drivers/net/wireless/iwlegacy/iwl-tx.c
@@ -146,33 +146,32 @@ void iwl_legacy_cmd_queue_unmap(struct iwl_priv *priv)
 {
        struct iwl_tx_queue *txq = &priv->txq[priv->cmd_queue];
        struct iwl_queue *q = &txq->q;
-        bool huge = false;
        int i;
        if (q->n_bd == 0)
                return;
        while (q->read_ptr != q->write_ptr) {
-                /* we have no way to tell if it is a huge cmd ATM */
                i = iwl_legacy_get_cmd_index(q, q->read_ptr, 0);
-                if (txq->meta[i].flags & CMD_SIZE_HUGE)
+                if (txq->meta[i].flags & CMD_MAPPED) {
-                        huge = true;
-                else
                        pci_unmap_single(priv->pci_dev,
                                         dma_unmap_addr(&txq->meta[i], mapping),
                                         dma_unmap_len(&txq->meta[i], len),
                                         PCI_DMA_BIDIRECTIONAL);
+                        txq->meta[i].flags = 0;
+                }
                q->read_ptr = iwl_legacy_queue_inc_wrap(q->read_ptr, q->n_bd);
        }
-        if (huge) {
+        i = q->n_window;
-                i = q->n_window;
+        if (txq->meta[i].flags & CMD_MAPPED) {
                pci_unmap_single(priv->pci_dev,
                                 dma_unmap_addr(&txq->meta[i], mapping),
                                 dma_unmap_len(&txq->meta[i], len),
                                 PCI_DMA_BIDIRECTIONAL);
+                txq->meta[i].flags = 0;
        }
 }
 EXPORT_SYMBOL(iwl_legacy_cmd_queue_unmap);
@@ -467,29 +466,27 @@ int iwl_legacy_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
                return -EIO;
        }
+        spin_lock_irqsave(&priv->hcmd_lock, flags);
        if (iwl_legacy_queue_space(q) < ((cmd->flags & CMD_ASYNC) ? 2 : 1)) {
-                IWL_ERR(priv, "No space in command queue\n");
+                spin_unlock_irqrestore(&priv->hcmd_lock, flags);
-                IWL_ERR(priv, "Restarting adapter due to queue full\n");
+                IWL_ERR(priv, "Restarting adapter due to command queue full\n");
                queue_work(priv->workqueue, &priv->restart);
                return -ENOSPC;
        }
-        spin_lock_irqsave(&priv->hcmd_lock, flags);
-        /* If this is a huge cmd, mark the huge flag also on the meta.flags
-         * of the _original_ cmd. This is used for DMA mapping clean up.
-         */
-        if (cmd->flags & CMD_SIZE_HUGE) {
-                idx = iwl_legacy_get_cmd_index(q, q->write_ptr, 0);
-                txq->meta[idx].flags = CMD_SIZE_HUGE;
-        }
        idx = iwl_legacy_get_cmd_index(q, q->write_ptr, cmd->flags & CMD_SIZE_HUGE);
        out_cmd = txq->cmd[idx];
        out_meta = &txq->meta[idx];
+        if (WARN_ON(out_meta->flags & CMD_MAPPED)) {
+                spin_unlock_irqrestore(&priv->hcmd_lock, flags);
+                return -ENOSPC;
+        }
        memset(out_meta, 0, sizeof(*out_meta)); /* re-initialize to NULL */
-        out_meta->flags = cmd->flags;
+        out_meta->flags = cmd->flags | CMD_MAPPED;
        if (cmd->flags & CMD_WANT_SKB)
                out_meta->source = cmd;
        if (cmd->flags & CMD_ASYNC)
@@ -610,6 +607,7 @@ iwl_legacy_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
        struct iwl_device_cmd *cmd;
        struct iwl_cmd_meta *meta;
        struct iwl_tx_queue *txq = &priv->txq[priv->cmd_queue];
+        unsigned long flags;
        /* If a Tx command is being handled and it isn't in the actual
         * command queue then there a command routing bug has been introduced
@@ -623,14 +621,6 @@ iwl_legacy_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
                return;
        }
-        /* If this is a huge cmd, clear the huge flag on the meta.flags
-         * of the _original_ cmd. So that iwl_legacy_cmd_queue_free won't unmap
-         * the DMA buffer for the scan (huge) command.
-         */
-        if (huge) {
-                cmd_index = iwl_legacy_get_cmd_index(&txq->q, index, 0);
-                txq->meta[cmd_index].flags = 0;
-        }
        cmd_index = iwl_legacy_get_cmd_index(&txq->q, index, huge);
        cmd = txq->cmd[cmd_index];
        meta = &txq->meta[cmd_index];
@@ -647,6 +637,8 @@ iwl_legacy_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
        } else if (meta->callback)
                meta->callback(priv, cmd, pkt);
+        spin_lock_irqsave(&priv->hcmd_lock, flags);
        iwl_legacy_hcmd_queue_reclaim(priv, txq_id, index, cmd_index);
        if (!(meta->flags & CMD_ASYNC)) {
@@ -655,6 +647,10 @@ iwl_legacy_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
                               iwl_legacy_get_cmd_string(cmd->hdr.cmd));
                wake_up_interruptible(&priv->wait_command_queue);
        }
+        /* Mark as unmapped */
        meta->flags = 0;
+        spin_unlock_irqrestore(&priv->hcmd_lock, flags);
 }
 EXPORT_SYMBOL(iwl_legacy_tx_cmd_complete);
diff --git a/drivers/net/wireless/iwlegacy/iwl3945-base.c b/drivers/net/wireless/iwlegacy/iwl3945-base.c
index cc7ebcee60e5..0ee6be6a9c5d 100644
--- a/drivers/net/wireless/iwlegacy/iwl3945-base.c
+++ b/drivers/net/wireless/iwlegacy/iwl3945-base.c
@@ -2748,11 +2748,12 @@ static void iwl3945_bg_init_alive_start(struct work_struct *data)
        struct iwl_priv *priv =
            container_of(data, struct iwl_priv, init_alive_start.work);
+        mutex_lock(&priv->mutex);
        if (test_bit(STATUS_EXIT_PENDING, &priv->status))
-                return;
+                goto out;
-        mutex_lock(&priv->mutex);
        iwl3945_init_alive_start(priv);
+out:
        mutex_unlock(&priv->mutex);
 }
@@ -2761,11 +2762,12 @@ static void iwl3945_bg_alive_start(struct work_struct *data)
        struct iwl_priv *priv =
            container_of(data, struct iwl_priv, alive_start.work);
+        mutex_lock(&priv->mutex);
        if (test_bit(STATUS_EXIT_PENDING, &priv->status))
-                return;
+                goto out;
-        mutex_lock(&priv->mutex);
        iwl3945_alive_start(priv);
+out:
        mutex_unlock(&priv->mutex);
 }
@@ -2995,10 +2997,12 @@ static void iwl3945_bg_restart(struct work_struct *data)
        } else {
                iwl3945_down(priv);
-                if (test_bit(STATUS_EXIT_PENDING, &priv->status))
+                mutex_lock(&priv->mutex);
+                if (test_bit(STATUS_EXIT_PENDING, &priv->status)) {
+                        mutex_unlock(&priv->mutex);
                        return;
+                }
-                mutex_lock(&priv->mutex);
                __iwl3945_up(priv);
                mutex_unlock(&priv->mutex);
        }
@@ -3009,11 +3013,12 @@ static void iwl3945_bg_rx_replenish(struct work_struct *data)
        struct iwl_priv *priv =
            container_of(data, struct iwl_priv, rx_replenish);
+        mutex_lock(&priv->mutex);
        if (test_bit(STATUS_EXIT_PENDING, &priv->status))
-                return;
+                goto out;
-        mutex_lock(&priv->mutex);
        iwl3945_rx_replenish(priv);
+out:
        mutex_unlock(&priv->mutex);
 }
@@ -3810,7 +3815,6 @@ static int iwl3945_init_drv(struct iwl_priv *priv)
        INIT_LIST_HEAD(&priv->free_frames);
        mutex_init(&priv->mutex);
-        mutex_init(&priv->sync_cmd_mutex);
        priv->ieee_channels = NULL;
        priv->ieee_rates = NULL;
diff --git a/drivers/net/wireless/iwlegacy/iwl4965-base.c b/drivers/net/wireless/iwlegacy/iwl4965-base.c
index a62fe24ee594..af2ae22fcfd3 100644
--- a/drivers/net/wireless/iwlegacy/iwl4965-base.c
+++ b/drivers/net/wireless/iwlegacy/iwl4965-base.c
@@ -1069,9 +1069,12 @@ static void iwl4965_irq_tasklet(struct iwl_priv *priv)
        }
        /* Re-enable all interrupts */
-        /* only Re-enable if diabled by irq */
+        /* only Re-enable if disabled by irq */
        if (test_bit(STATUS_INT_ENABLED, &priv->status))
                iwl_legacy_enable_interrupts(priv);
+        /* Re-enable RF_KILL if it occurred */
+        else if (handled & CSR_INT_BIT_RF_KILL)
+                iwl_legacy_enable_rfkill_int(priv);
 #ifdef CONFIG_IWLWIFI_LEGACY_DEBUG
        if (iwl_legacy_get_debug_level(priv) & (IWL_DL_ISR)) {
@@ -2139,7 +2142,7 @@ static void iwl4965_cancel_deferred_work(struct iwl_priv *priv);
 static void __iwl4965_down(struct iwl_priv *priv)
 {
        unsigned long flags;
-        int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
+        int exit_pending;
        IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");
@@ -2401,11 +2404,12 @@ static void iwl4965_bg_init_alive_start(struct work_struct *data)
        struct iwl_priv *priv =
            container_of(data, struct iwl_priv, init_alive_start.work);
+        mutex_lock(&priv->mutex);
        if (test_bit(STATUS_EXIT_PENDING, &priv->status))
-                return;
+                goto out;
-        mutex_lock(&priv->mutex);
        priv->cfg->ops->lib->init_alive_start(priv);
+out:
        mutex_unlock(&priv->mutex);
 }
@@ -2414,11 +2418,12 @@ static void iwl4965_bg_alive_start(struct work_struct *data)
        struct iwl_priv *priv =
            container_of(data, struct iwl_priv, alive_start.work);
+        mutex_lock(&priv->mutex);
        if (test_bit(STATUS_EXIT_PENDING, &priv->status))
-                return;
+                goto out;
-        mutex_lock(&priv->mutex);
        iwl4965_alive_start(priv);
+out:
        mutex_unlock(&priv->mutex);
 }
@@ -2468,10 +2473,12 @@ static void iwl4965_bg_restart(struct work_struct *data)
        } else {
                iwl4965_down(priv);
-                if (test_bit(STATUS_EXIT_PENDING, &priv->status))
+                mutex_lock(&priv->mutex);
+                if (test_bit(STATUS_EXIT_PENDING, &priv->status)) {
+                        mutex_unlock(&priv->mutex);
                        return;
+                }
-                mutex_lock(&priv->mutex);
                __iwl4965_up(priv);
                mutex_unlock(&priv->mutex);
        }
@@ -2624,9 +2631,10 @@ void iwl4965_mac_stop(struct ieee80211_hw *hw)
        flush_workqueue(priv->workqueue);
-        /* enable interrupts again in order to receive rfkill changes */
+        /* User space software may expect getting rfkill changes
+         * even if interface is down */
        iwl_write32(priv, CSR_INT, 0xFFFFFFFF);
-        iwl_legacy_enable_interrupts(priv);
+        iwl_legacy_enable_rfkill_int(priv);
        IWL_DEBUG_MAC80211(priv, "leave\n");
 }
@@ -2847,21 +2855,22 @@ void iwl4965_mac_channel_switch(struct ieee80211_hw *hw,
        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->mutex);
        if (iwl_legacy_is_rfkill(priv))
-                goto out_exit;
+                goto out;
        if (test_bit(STATUS_EXIT_PENDING, &priv->status) ||
            test_bit(STATUS_SCANNING, &priv->status))
-                goto out_exit;
+                goto out;
        if (!iwl_legacy_is_associated_ctx(ctx))
-                goto out_exit;
+                goto out;
        /* channel switch in progress */
        if (priv->switch_rxon.switch_in_progress == true)
-                goto out_exit;
+                goto out;
-        mutex_lock(&priv->mutex);
        if (priv->cfg->ops->lib->set_channel_switch) {
                ch = channel->hw_value;
@@ -2917,7 +2926,6 @@ void iwl4965_mac_channel_switch(struct ieee80211_hw *hw,
        }
 out:
        mutex_unlock(&priv->mutex);
-out_exit:
        if (!priv->switch_rxon.switch_in_progress)
                ieee80211_chswitch_done(ctx->vif, false);
        IWL_DEBUG_MAC80211(priv, "leave\n");
@@ -3116,7 +3124,6 @@ static int iwl4965_init_drv(struct iwl_priv *priv)
        INIT_LIST_HEAD(&priv->free_frames);
        mutex_init(&priv->mutex);
-        mutex_init(&priv->sync_cmd_mutex);
        priv->ieee_channels = NULL;
        priv->ieee_rates = NULL;
@@ -3173,7 +3180,7 @@ static void iwl4965_hw_detect(struct iwl_priv *priv)
 {
        priv->hw_rev = _iwl_legacy_read32(priv, CSR_HW_REV);
        priv->hw_wa_rev = _iwl_legacy_read32(priv, CSR_HW_REV_WA_REG);
-        pci_read_config_byte(priv->pci_dev, PCI_REVISION_ID, &priv->rev_id);
+        priv->rev_id = priv->pci_dev->revision;
        IWL_DEBUG_INFO(priv, "HW Revision ID = 0x%X\n", priv->rev_id);
 }
@@ -3406,14 +3413,14 @@ iwl4965_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
         * 8. Enable interrupts and read RFKILL state
         *********************************************/
-        /* enable interrupts if needed: hw bug w/a */
+        /* enable rfkill interrupt: hw bug w/a */
        pci_read_config_word(priv->pci_dev, PCI_COMMAND, &pci_cmd);
        if (pci_cmd & PCI_COMMAND_INTX_DISABLE) {
                pci_cmd &= ~PCI_COMMAND_INTX_DISABLE;
                pci_write_config_word(priv->pci_dev, PCI_COMMAND, pci_cmd);
        }
-        iwl_legacy_enable_interrupts(priv);
+        iwl_legacy_enable_rfkill_int(priv);
        /* If platform's RF_KILL switch is NOT set to KILL */
        if (iwl_read32(priv, CSR_GP_CNTRL) &
diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
index 17d555f2215a..ad3bdba6beed 100644
--- a/drivers/net/wireless/iwlwifi/Kconfig
+++ b/drivers/net/wireless/iwlwifi/Kconfig
@@ -102,6 +102,16 @@ config IWLWIFI_DEVICE_TRACING
          occur.
 endmenu
+config IWLWIFI_DEVICE_SVTOOL
+        bool "iwlwifi device svtool support"
+        depends on IWLAGN
+        select NL80211_TESTMODE
+        help
+          This option enables the svtool support for iwlwifi device through
+          NL80211_TESTMODE. svtool is a software validation tool that runs in
+          the user space and interacts with the device in the kernel space
+          through the generic netlink message via NL80211_TESTMODE channel.
 config IWL_P2P
        bool "iwlwifi experimental P2P support"
        depends on IWLAGN
diff --git a/drivers/net/wireless/iwlwifi/Makefile b/drivers/net/wireless/iwlwifi/Makefile
index 9d6ee836426c..822660483f9f 100644
--- a/drivers/net/wireless/iwlwifi/Makefile
+++ b/drivers/net/wireless/iwlwifi/Makefile
@@ -1,8 +1,8 @@
 # AGN
 obj-$(CONFIG_IWLAGN)    += iwlagn.o
-iwlagn-objs             := iwl-agn.o iwl-agn-rs.o iwl-agn-led.o
+iwlagn-objs             := iwl-agn.o iwl-agn-rs.o
 iwlagn-objs             += iwl-agn-ucode.o iwl-agn-tx.o
-iwlagn-objs             += iwl-agn-lib.o iwl-agn-calib.o
+iwlagn-objs             += iwl-agn-lib.o iwl-agn-calib.o iwl-io.o
 iwlagn-objs             += iwl-agn-tt.o iwl-agn-sta.o iwl-agn-eeprom.o
 iwlagn-objs             += iwl-core.o iwl-eeprom.o iwl-hcmd.o iwl-power.o
@@ -14,9 +14,9 @@ iwlagn-objs             += iwl-6000.o
 iwlagn-objs             += iwl-1000.o
 iwlagn-objs             += iwl-2000.o
-iwlagn-$(CONFIG_IWLWIFI_DEBUGFS) += iwl-agn-debugfs.o
 iwlagn-$(CONFIG_IWLWIFI_DEBUGFS) += iwl-debugfs.o
 iwlagn-$(CONFIG_IWLWIFI_DEVICE_TRACING) += iwl-devtrace.o
+iwlagn-$(CONFIG_IWLWIFI_DEVICE_SVTOOL) += iwl-sv-open.o
 CFLAGS_iwl-devtrace.o := -I$(src)
diff --git a/drivers/net/wireless/iwlwifi/iwl-1000.c b/drivers/net/wireless/iwlwifi/iwl-1000.c
index 27c5007e577c..b4c81931e136 100644
--- a/drivers/net/wireless/iwlwifi/iwl-1000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-1000.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -45,8 +45,6 @@
 #include "iwl-agn.h"
 #include "iwl-helpers.h"
 #include "iwl-agn-hw.h"
-#include "iwl-agn-led.h"
-#include "iwl-agn-debugfs.h"
 /* Highest firmware API version supported */
 #define IWL1000_UCODE_API_MAX 5
@@ -57,12 +55,10 @@
 #define IWL100_UCODE_API_MIN 5
 #define IWL1000_FW_PRE "iwlwifi-1000-"
-#define _IWL1000_MODULE_FIRMWARE(api) IWL1000_FW_PRE #api ".ucode"
+#define IWL1000_MODULE_FIRMWARE(api) IWL1000_FW_PRE #api ".ucode"
-#define IWL1000_MODULE_FIRMWARE(api) _IWL1000_MODULE_FIRMWARE(api)
 #define IWL100_FW_PRE "iwlwifi-100-"
-#define _IWL100_MODULE_FIRMWARE(api) IWL100_FW_PRE #api ".ucode"
+#define IWL100_MODULE_FIRMWARE(api) IWL100_FW_PRE #api ".ucode"
-#define IWL100_MODULE_FIRMWARE(api) _IWL100_MODULE_FIRMWARE(api)
 /*
@@ -124,10 +120,10 @@ static struct iwl_sensitivity_ranges iwl1000_sensitivity = {
 static int iwl1000_hw_set_hw_params(struct iwl_priv *priv)
 {
-        if (priv->cfg->mod_params->num_of_queues >= IWL_MIN_NUM_QUEUES &&
+        if (iwlagn_mod_params.num_of_queues >= IWL_MIN_NUM_QUEUES &&
-            priv->cfg->mod_params->num_of_queues <= IWLAGN_NUM_QUEUES)
+            iwlagn_mod_params.num_of_queues <= IWLAGN_NUM_QUEUES)
                priv->cfg->base_params->num_of_queues =
-                        priv->cfg->mod_params->num_of_queues;
+                        iwlagn_mod_params.num_of_queues;
        priv->hw_params.max_txq_num = priv->cfg->base_params->num_of_queues;
        priv->hw_params.dma_chnl_num = FH50_TCSR_CHNL_NUM;
@@ -141,7 +137,6 @@ static int iwl1000_hw_set_hw_params(struct iwl_priv *priv)
        priv->hw_params.max_data_size = IWLAGN_RTC_DATA_SIZE;
        priv->hw_params.max_inst_size = IWLAGN_RTC_INST_SIZE;
-        priv->hw_params.max_bsm_size = 0;
        priv->hw_params.ht40_channel =  BIT(IEEE80211_BAND_2GHZ) |
                                        BIT(IEEE80211_BAND_5GHZ);
        priv->hw_params.rx_wrt_ptr_reg = FH_RSCSR_CHNL0_WPTR;
@@ -176,24 +171,13 @@ static int iwl1000_hw_set_hw_params(struct iwl_priv *priv)
 static struct iwl_lib_ops iwl1000_lib = {
        .set_hw_params = iwl1000_hw_set_hw_params,
-        .txq_update_byte_cnt_tbl = iwlagn_txq_update_byte_cnt_tbl,
-        .txq_inval_byte_cnt_tbl = iwlagn_txq_inval_byte_cnt_tbl,
        .txq_set_sched = iwlagn_txq_set_sched,
-        .txq_agg_enable = iwlagn_txq_agg_enable,
-        .txq_agg_disable = iwlagn_txq_agg_disable,
        .txq_attach_buf_to_tfd = iwl_hw_txq_attach_buf_to_tfd,
        .txq_free_tfd = iwl_hw_txq_free_tfd,
        .txq_init = iwl_hw_tx_queue_init,
        .rx_handler_setup = iwlagn_rx_handler_setup,
        .setup_deferred_work = iwlagn_setup_deferred_work,
        .is_valid_rtc_data_addr = iwlagn_hw_valid_rtc_data_addr,
-        .load_ucode = iwlagn_load_ucode,
-        .dump_nic_event_log = iwl_dump_nic_event_log,
-        .dump_nic_error_log = iwl_dump_nic_error_log,
-        .dump_csr = iwl_dump_csr,
-        .dump_fh = iwl_dump_fh,
-        .init_alive_start = iwlagn_init_alive_start,
-        .alive_notify = iwlagn_alive_notify,
        .send_tx_power = iwlagn_send_tx_power,
        .update_chain_flags = iwl_update_chain_flags,
        .apm_ops = {
@@ -208,45 +192,21 @@ static struct iwl_lib_ops iwl1000_lib = {
                        EEPROM_REG_BAND_4_CHANNELS,
                        EEPROM_REG_BAND_5_CHANNELS,
                        EEPROM_REG_BAND_24_HT40_CHANNELS,
-                        EEPROM_REG_BAND_52_HT40_CHANNELS
+                        EEPROM_REGULATORY_BAND_NO_HT40,
                },
-                .acquire_semaphore = iwlcore_eeprom_acquire_semaphore,
-                .release_semaphore = iwlcore_eeprom_release_semaphore,
-                .calib_version  = iwlagn_eeprom_calib_version,
                .query_addr = iwlagn_eeprom_query_addr,
        },
-        .isr_ops = {
-                .isr = iwl_isr_ict,
-                .free = iwl_free_isr_ict,
-                .alloc = iwl_alloc_isr_ict,
-                .reset = iwl_reset_ict,
-                .disable = iwl_disable_ict,
-        },
        .temp_ops = {
                .temperature = iwlagn_temperature,
         },
-        .debugfs_ops = {
-                .rx_stats_read = iwl_ucode_rx_stats_read,
-                .tx_stats_read = iwl_ucode_tx_stats_read,
-                .general_stats_read = iwl_ucode_general_stats_read,
-                .bt_stats_read = iwl_ucode_bt_stats_read,
-                .reply_tx_error = iwl_reply_tx_error_read,
-        },
        .txfifo_flush = iwlagn_txfifo_flush,
        .dev_txfifo_flush = iwlagn_dev_txfifo_flush,
-        .tt_ops = {
-                .lower_power_detection = iwl_tt_is_low_power_state,
-                .tt_power_mode = iwl_tt_current_power_mode,
-                .ct_kill_check = iwl_check_for_ct_kill,
-        }
 };
 static const struct iwl_ops iwl1000_ops = {
        .lib = &iwl1000_lib,
        .hcmd = &iwlagn_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
 static struct iwl_base_params iwl1000_base_params = {
@@ -254,8 +214,6 @@ static struct iwl_base_params iwl1000_base_params = {
        .num_of_ampdu_queues = IWLAGN_NUM_AMPDU_QUEUES,
        .eeprom_size = OTP_LOW_IMAGE_SIZE,
        .pll_cfg_val = CSR50_ANA_PLL_CFG_VAL,
-        .set_l0s = true,
-        .use_bsm = false,
        .max_ll_items = OTP_MAX_LL_ITEMS_1000,
        .shadow_ram_support = false,
        .led_compensation = 51,
@@ -265,9 +223,6 @@ static struct iwl_base_params iwl1000_base_params = {
        .chain_noise_scale = 1000,
        .wd_timeout = IWL_DEF_WD_TIMEOUT,
        .max_event_log_size = 128,
-        .ucode_tracing = true,
-        .sensitivity_calib_by_driver = true,
-        .chain_noise_calib_by_driver = true,
 };
 static struct iwl_ht_params iwl1000_ht_params = {
        .ht_greenfield_support = true,
@@ -281,7 +236,6 @@ static struct iwl_ht_params iwl1000_ht_params = {
        .eeprom_ver = EEPROM_1000_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_1000_TX_POWER_VERSION,       \
        .ops = &iwl1000_ops,                                    \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl1000_base_params,                    \
        .led_mode = IWL_LED_BLINK
@@ -303,7 +257,6 @@ struct iwl_cfg iwl1000_bg_cfg = {
        .eeprom_ver = EEPROM_1000_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_1000_TX_POWER_VERSION,       \
        .ops = &iwl1000_ops,                                    \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl1000_base_params,                    \
        .led_mode = IWL_LED_RF_STATE,                           \
        .rx_with_siso_diversity = true
diff --git a/drivers/net/wireless/iwlwifi/iwl-2000.c b/drivers/net/wireless/iwlwifi/iwl-2000.c
index d7b6126408c9..89b8da7a6c8b 100644
--- a/drivers/net/wireless/iwlwifi/iwl-2000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-2000.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -46,30 +46,25 @@
 #include "iwl-helpers.h"
 #include "iwl-agn-hw.h"
 #include "iwl-6000-hw.h"
-#include "iwl-agn-led.h"
-#include "iwl-agn-debugfs.h"
 /* Highest firmware API version supported */
 #define IWL2030_UCODE_API_MAX 5
 #define IWL2000_UCODE_API_MAX 5
-#define IWL200_UCODE_API_MAX 5
+#define IWL105_UCODE_API_MAX 5
 /* Lowest firmware API version supported */
 #define IWL2030_UCODE_API_MIN 5
 #define IWL2000_UCODE_API_MIN 5
-#define IWL200_UCODE_API_MIN 5
+#define IWL105_UCODE_API_MIN 5
 #define IWL2030_FW_PRE "iwlwifi-2030-"
-#define _IWL2030_MODULE_FIRMWARE(api) IWL2030_FW_PRE #api ".ucode"
+#define IWL2030_MODULE_FIRMWARE(api) IWL2030_FW_PRE #api ".ucode"
-#define IWL2030_MODULE_FIRMWARE(api) _IWL2030_MODULE_FIRMWARE(api)
 #define IWL2000_FW_PRE "iwlwifi-2000-"
-#define _IWL2000_MODULE_FIRMWARE(api) IWL2000_FW_PRE #api ".ucode"
+#define IWL2000_MODULE_FIRMWARE(api) IWL2000_FW_PRE #api ".ucode"
-#define IWL2000_MODULE_FIRMWARE(api) _IWL2000_MODULE_FIRMWARE(api)
-#define IWL200_FW_PRE "iwlwifi-200-"
+#define IWL105_FW_PRE "iwlwifi-105-"
-#define _IWL200_MODULE_FIRMWARE(api) IWL200_FW_PRE #api ".ucode"
+#define IWL105_MODULE_FIRMWARE(api) IWL105_FW_PRE #api ".ucode"
-#define IWL200_MODULE_FIRMWARE(api) _IWL200_MODULE_FIRMWARE(api)
 static void iwl2000_set_ct_threshold(struct iwl_priv *priv)
 {
@@ -101,6 +96,8 @@ static void iwl2000_nic_config(struct iwl_priv *priv)
                iwl_set_bit(priv, CSR_GP_DRIVER_REG,
                            CSR_GP_DRIVER_REG_BIT_RADIO_IQ_INVER);
+        if (priv->cfg->disable_otp_refresh)
+                iwl_write_prph(priv, APMG_ANALOG_SVR_REG, 0x80000010);
 }
 static struct iwl_sensitivity_ranges iwl2000_sensitivity = {
@@ -130,10 +127,10 @@ static struct iwl_sensitivity_ranges iwl2000_sensitivity = {
 static int iwl2000_hw_set_hw_params(struct iwl_priv *priv)
 {
-        if (priv->cfg->mod_params->num_of_queues >= IWL_MIN_NUM_QUEUES &&
+        if (iwlagn_mod_params.num_of_queues >= IWL_MIN_NUM_QUEUES &&
-            priv->cfg->mod_params->num_of_queues <= IWLAGN_NUM_QUEUES)
+            iwlagn_mod_params.num_of_queues <= IWLAGN_NUM_QUEUES)
                priv->cfg->base_params->num_of_queues =
-                        priv->cfg->mod_params->num_of_queues;
+                        iwlagn_mod_params.num_of_queues;
        priv->hw_params.max_txq_num = priv->cfg->base_params->num_of_queues;
        priv->hw_params.dma_chnl_num = FH50_TCSR_CHNL_NUM;
@@ -147,7 +144,6 @@ static int iwl2000_hw_set_hw_params(struct iwl_priv *priv)
        priv->hw_params.max_data_size = IWL60_RTC_DATA_SIZE;
        priv->hw_params.max_inst_size = IWL60_RTC_INST_SIZE;
-        priv->hw_params.max_bsm_size = 0;
        priv->hw_params.ht40_channel =  BIT(IEEE80211_BAND_2GHZ) |
                                        BIT(IEEE80211_BAND_5GHZ);
        priv->hw_params.rx_wrt_ptr_reg = FH_RSCSR_CHNL0_WPTR;
@@ -256,11 +252,7 @@ static int iwl2030_hw_channel_switch(struct iwl_priv *priv,
 static struct iwl_lib_ops iwl2000_lib = {
        .set_hw_params = iwl2000_hw_set_hw_params,
-        .txq_update_byte_cnt_tbl = iwlagn_txq_update_byte_cnt_tbl,
-        .txq_inval_byte_cnt_tbl = iwlagn_txq_inval_byte_cnt_tbl,
        .txq_set_sched = iwlagn_txq_set_sched,
-        .txq_agg_enable = iwlagn_txq_agg_enable,
-        .txq_agg_disable = iwlagn_txq_agg_disable,
        .txq_attach_buf_to_tfd = iwl_hw_txq_attach_buf_to_tfd,
        .txq_free_tfd = iwl_hw_txq_free_tfd,
        .txq_init = iwl_hw_tx_queue_init,
@@ -268,13 +260,6 @@ static struct iwl_lib_ops iwl2000_lib = {
        .setup_deferred_work = iwlagn_bt_setup_deferred_work,
        .cancel_deferred_work = iwlagn_bt_cancel_deferred_work,
        .is_valid_rtc_data_addr = iwlagn_hw_valid_rtc_data_addr,
-        .load_ucode = iwlagn_load_ucode,
-        .dump_nic_event_log = iwl_dump_nic_event_log,
-        .dump_nic_error_log = iwl_dump_nic_error_log,
-        .dump_csr = iwl_dump_csr,
-        .dump_fh = iwl_dump_fh,
-        .init_alive_start = iwlagn_init_alive_start,
-        .alive_notify = iwlagn_alive_notify,
        .send_tx_power = iwlagn_send_tx_power,
        .update_chain_flags = iwl_update_chain_flags,
        .set_channel_switch = iwl2030_hw_channel_switch,
@@ -290,70 +275,40 @@ static struct iwl_lib_ops iwl2000_lib = {
                        EEPROM_REG_BAND_4_CHANNELS,
                        EEPROM_REG_BAND_5_CHANNELS,
                        EEPROM_6000_REG_BAND_24_HT40_CHANNELS,
-                        EEPROM_REG_BAND_52_HT40_CHANNELS
+                        EEPROM_REGULATORY_BAND_NO_HT40,
                },
-                .acquire_semaphore = iwlcore_eeprom_acquire_semaphore,
-                .release_semaphore = iwlcore_eeprom_release_semaphore,
-                .calib_version  = iwlagn_eeprom_calib_version,
                .query_addr = iwlagn_eeprom_query_addr,
                .update_enhanced_txpower = iwlcore_eeprom_enhanced_txpower,
        },
-        .isr_ops = {
-                .isr = iwl_isr_ict,
-                .free = iwl_free_isr_ict,
-                .alloc = iwl_alloc_isr_ict,
-                .reset = iwl_reset_ict,
-                .disable = iwl_disable_ict,
-        },
        .temp_ops = {
                .temperature = iwlagn_temperature,
        },
-        .debugfs_ops = {
-                .rx_stats_read = iwl_ucode_rx_stats_read,
-                .tx_stats_read = iwl_ucode_tx_stats_read,
-                .general_stats_read = iwl_ucode_general_stats_read,
-                .bt_stats_read = iwl_ucode_bt_stats_read,
-                .reply_tx_error = iwl_reply_tx_error_read,
-        },
        .txfifo_flush = iwlagn_txfifo_flush,
        .dev_txfifo_flush = iwlagn_dev_txfifo_flush,
-        .tt_ops = {
-                .lower_power_detection = iwl_tt_is_low_power_state,
-                .tt_power_mode = iwl_tt_current_power_mode,
-                .ct_kill_check = iwl_check_for_ct_kill,
-        }
 };
 static const struct iwl_ops iwl2000_ops = {
        .lib = &iwl2000_lib,
        .hcmd = &iwlagn_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
 static const struct iwl_ops iwl2030_ops = {
        .lib = &iwl2000_lib,
        .hcmd = &iwlagn_bt_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
-static const struct iwl_ops iwl200_ops = {
+static const struct iwl_ops iwl105_ops = {
        .lib = &iwl2000_lib,
        .hcmd = &iwlagn_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
-static const struct iwl_ops iwl230_ops = {
+static const struct iwl_ops iwl135_ops = {
        .lib = &iwl2000_lib,
        .hcmd = &iwlagn_bt_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
 static struct iwl_base_params iwl2000_base_params = {
@@ -361,8 +316,6 @@ static struct iwl_base_params iwl2000_base_params = {
        .num_of_queues = IWLAGN_NUM_QUEUES,
        .num_of_ampdu_queues = IWLAGN_NUM_AMPDU_QUEUES,
        .pll_cfg_val = 0,
-        .set_l0s = true,
-        .use_bsm = false,
        .max_ll_items = OTP_MAX_LL_ITEMS_2x00,
        .shadow_ram_support = true,
        .led_compensation = 51,
@@ -373,9 +326,6 @@ static struct iwl_base_params iwl2000_base_params = {
        .chain_noise_scale = 1000,
        .wd_timeout = IWL_DEF_WD_TIMEOUT,
        .max_event_log_size = 512,
-        .ucode_tracing = true,
-        .sensitivity_calib_by_driver = true,
-        .chain_noise_calib_by_driver = true,
        .shadow_reg_enable = true,
 };
@@ -385,8 +335,6 @@ static struct iwl_base_params iwl2030_base_params = {
        .num_of_queues = IWLAGN_NUM_QUEUES,
        .num_of_ampdu_queues = IWLAGN_NUM_AMPDU_QUEUES,
        .pll_cfg_val = 0,
-        .set_l0s = true,
-        .use_bsm = false,
        .max_ll_items = OTP_MAX_LL_ITEMS_2x00,
        .shadow_ram_support = true,
        .led_compensation = 57,
@@ -397,9 +345,6 @@ static struct iwl_base_params iwl2030_base_params = {
        .chain_noise_scale = 1000,
        .wd_timeout = IWL_LONG_WD_TIMEOUT,
        .max_event_log_size = 512,
-        .ucode_tracing = true,
-        .sensitivity_calib_by_driver = true,
-        .chain_noise_calib_by_driver = true,
        .shadow_reg_enable = true,
 };
@@ -409,7 +354,6 @@ static struct iwl_ht_params iwl2000_ht_params = {
 };
 static struct iwl_bt_params iwl2030_bt_params = {
-        .bt_statistics = true,
        /* Due to bluetooth, we transmit 2.4 GHz probes only on antenna A */
        .advanced_bt_coexist = true,
        .agg_time_limit = BT_AGG_THRESHOLD_DEF,
@@ -426,12 +370,12 @@ static struct iwl_bt_params iwl2030_bt_params = {
        .eeprom_ver = EEPROM_2000_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_2000_TX_POWER_VERSION,       \
        .ops = &iwl2000_ops,                                    \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl2000_base_params,                    \
        .need_dc_calib = true,                                  \
        .need_temp_offset_calib = true,                         \
        .led_mode = IWL_LED_RF_STATE,                           \
-        .iq_invert = true                                       \
+        .iq_invert = true,                                      \
+        .disable_otp_refresh = true                             \
 struct iwl_cfg iwl2000_2bgn_cfg = {
        .name = "2000 Series 2x2 BGN",
@@ -451,7 +395,6 @@ struct iwl_cfg iwl2000_2bg_cfg = {
        .eeprom_ver = EEPROM_2000_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_2000_TX_POWER_VERSION,       \
        .ops = &iwl2030_ops,                                    \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl2030_base_params,                    \
        .bt_params = &iwl2030_bt_params,                        \
        .need_dc_calib = true,                                  \
@@ -471,45 +414,13 @@ struct iwl_cfg iwl2030_2bg_cfg = {
        IWL_DEVICE_2030,
 };
-#define IWL_DEVICE_6035                                         \
+#define IWL_DEVICE_105                                          \
-        .fw_name_pre = IWL2030_FW_PRE,                          \
+        .fw_name_pre = IWL105_FW_PRE,                           \
-        .ucode_api_max = IWL2030_UCODE_API_MAX,                 \
+        .ucode_api_max = IWL105_UCODE_API_MAX,                  \
-        .ucode_api_min = IWL2030_UCODE_API_MIN,                 \
+        .ucode_api_min = IWL105_UCODE_API_MIN,                  \
-        .eeprom_ver = EEPROM_6035_EEPROM_VERSION,               \
-        .eeprom_calib_ver = EEPROM_6035_TX_POWER_VERSION,       \
-        .ops = &iwl2030_ops,                                    \
-        .mod_params = &iwlagn_mod_params,                       \
-        .base_params = &iwl2030_base_params,                    \
-        .bt_params = &iwl2030_bt_params,                        \
-        .need_dc_calib = true,                                  \
-        .need_temp_offset_calib = true,                         \
-        .led_mode = IWL_LED_RF_STATE,                           \
-        .adv_pm = true                                          \
-struct iwl_cfg iwl6035_2agn_cfg = {
-        .name = "2000 Series 2x2 AGN/BT",
-        IWL_DEVICE_6035,
-        .ht_params = &iwl2000_ht_params,
-};
-struct iwl_cfg iwl6035_2abg_cfg = {
-        .name = "2000 Series 2x2 ABG/BT",
-        IWL_DEVICE_6035,
-};
-struct iwl_cfg iwl6035_2bg_cfg = {
-        .name = "2000 Series 2x2 BG/BT",
-        IWL_DEVICE_6035,
-};
-#define IWL_DEVICE_200                                          \
-        .fw_name_pre = IWL200_FW_PRE,                           \
-        .ucode_api_max = IWL200_UCODE_API_MAX,                  \
-        .ucode_api_min = IWL200_UCODE_API_MIN,                  \
        .eeprom_ver = EEPROM_2000_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_2000_TX_POWER_VERSION,       \
-        .ops = &iwl200_ops,                                     \
+        .ops = &iwl105_ops,                                     \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl2000_base_params,                    \
        .need_dc_calib = true,                                  \
        .need_temp_offset_calib = true,                         \
@@ -517,25 +428,24 @@ struct iwl_cfg iwl6035_2bg_cfg = {
        .adv_pm = true,                                         \
        .rx_with_siso_diversity = true                          \
-struct iwl_cfg iwl200_bg_cfg = {
+struct iwl_cfg iwl105_bg_cfg = {
-        .name = "200 Series 1x1 BG",
+        .name = "105 Series 1x1 BG",
-        IWL_DEVICE_200,
+        IWL_DEVICE_105,
 };
-struct iwl_cfg iwl200_bgn_cfg = {
+struct iwl_cfg iwl105_bgn_cfg = {
-        .name = "200 Series 1x1 BGN",
+        .name = "105 Series 1x1 BGN",
-        IWL_DEVICE_200,
+        IWL_DEVICE_105,
        .ht_params = &iwl2000_ht_params,
 };
-#define IWL_DEVICE_230                                          \
+#define IWL_DEVICE_135                                          \
-        .fw_name_pre = IWL200_FW_PRE,                           \
+        .fw_name_pre = IWL105_FW_PRE,                           \
-        .ucode_api_max = IWL200_UCODE_API_MAX,                  \
+        .ucode_api_max = IWL105_UCODE_API_MAX,                  \
-        .ucode_api_min = IWL200_UCODE_API_MIN,                  \
+        .ucode_api_min = IWL105_UCODE_API_MIN,                  \
        .eeprom_ver = EEPROM_2000_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_2000_TX_POWER_VERSION,       \
-        .ops = &iwl230_ops,                                     \
+        .ops = &iwl135_ops,                                     \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl2030_base_params,                    \
        .bt_params = &iwl2030_bt_params,                        \
        .need_dc_calib = true,                                  \
@@ -544,17 +454,17 @@ struct iwl_cfg iwl200_bgn_cfg = {
        .adv_pm = true,                                         \
        .rx_with_siso_diversity = true                          \
-struct iwl_cfg iwl230_bg_cfg = {
+struct iwl_cfg iwl135_bg_cfg = {
-        .name = "200 Series 1x1 BG/BT",
+        .name = "105 Series 1x1 BG/BT",
-        IWL_DEVICE_230,
+        IWL_DEVICE_135,
 };
-struct iwl_cfg iwl230_bgn_cfg = {
+struct iwl_cfg iwl135_bgn_cfg = {
-        .name = "200 Series 1x1 BGN/BT",
+        .name = "105 Series 1x1 BGN/BT",
-        IWL_DEVICE_230,
+        IWL_DEVICE_135,
        .ht_params = &iwl2000_ht_params,
 };
 MODULE_FIRMWARE(IWL2000_MODULE_FIRMWARE(IWL2000_UCODE_API_MAX));
 MODULE_FIRMWARE(IWL2030_MODULE_FIRMWARE(IWL2030_UCODE_API_MAX));
-MODULE_FIRMWARE(IWL200_MODULE_FIRMWARE(IWL200_UCODE_API_MAX));
+MODULE_FIRMWARE(IWL105_MODULE_FIRMWARE(IWL105_UCODE_API_MAX));
diff --git a/drivers/net/wireless/iwlwifi/iwl-5000-hw.h b/drivers/net/wireless/iwlwifi/iwl-5000-hw.h
index 3975e45e7500..05ad47628b63 100644
--- a/drivers/net/wireless/iwlwifi/iwl-5000-hw.h
+++ b/drivers/net/wireless/iwlwifi/iwl-5000-hw.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2007 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2007 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c
index 22e045b5bcee..98f81df166e3 100644
--- a/drivers/net/wireless/iwlwifi/iwl-5000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-5000.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2007 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2007 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -45,10 +45,8 @@
 #include "iwl-sta.h"
 #include "iwl-helpers.h"
 #include "iwl-agn.h"
-#include "iwl-agn-led.h"
 #include "iwl-agn-hw.h"
 #include "iwl-5000-hw.h"
-#include "iwl-agn-debugfs.h"
 /* Highest firmware API version supported */
 #define IWL5000_UCODE_API_MAX 5
@@ -59,12 +57,10 @@
 #define IWL5150_UCODE_API_MIN 1
 #define IWL5000_FW_PRE "iwlwifi-5000-"
-#define _IWL5000_MODULE_FIRMWARE(api) IWL5000_FW_PRE #api ".ucode"
+#define IWL5000_MODULE_FIRMWARE(api) IWL5000_FW_PRE #api ".ucode"
-#define IWL5000_MODULE_FIRMWARE(api) _IWL5000_MODULE_FIRMWARE(api)
 #define IWL5150_FW_PRE "iwlwifi-5150-"
-#define _IWL5150_MODULE_FIRMWARE(api) IWL5150_FW_PRE #api ".ucode"
+#define IWL5150_MODULE_FIRMWARE(api) IWL5150_FW_PRE #api ".ucode"
-#define IWL5150_MODULE_FIRMWARE(api) _IWL5150_MODULE_FIRMWARE(api)
 /* NIC configuration for 5000 series */
 static void iwl5000_nic_config(struct iwl_priv *priv)
@@ -168,10 +164,10 @@ static void iwl5000_set_ct_threshold(struct iwl_priv *priv)
 static int iwl5000_hw_set_hw_params(struct iwl_priv *priv)
 {
-        if (priv->cfg->mod_params->num_of_queues >= IWL_MIN_NUM_QUEUES &&
+        if (iwlagn_mod_params.num_of_queues >= IWL_MIN_NUM_QUEUES &&
-            priv->cfg->mod_params->num_of_queues <= IWLAGN_NUM_QUEUES)
+            iwlagn_mod_params.num_of_queues <= IWLAGN_NUM_QUEUES)
                priv->cfg->base_params->num_of_queues =
-                        priv->cfg->mod_params->num_of_queues;
+                        iwlagn_mod_params.num_of_queues;
        priv->hw_params.max_txq_num = priv->cfg->base_params->num_of_queues;
        priv->hw_params.dma_chnl_num = FH50_TCSR_CHNL_NUM;
@@ -185,7 +181,6 @@ static int iwl5000_hw_set_hw_params(struct iwl_priv *priv)
        priv->hw_params.max_data_size = IWLAGN_RTC_DATA_SIZE;
        priv->hw_params.max_inst_size = IWLAGN_RTC_INST_SIZE;
-        priv->hw_params.max_bsm_size = 0;
        priv->hw_params.ht40_channel =  BIT(IEEE80211_BAND_2GHZ) |
                                        BIT(IEEE80211_BAND_5GHZ);
        priv->hw_params.rx_wrt_ptr_reg = FH_RSCSR_CHNL0_WPTR;
@@ -214,10 +209,10 @@ static int iwl5000_hw_set_hw_params(struct iwl_priv *priv)
 static int iwl5150_hw_set_hw_params(struct iwl_priv *priv)
 {
-        if (priv->cfg->mod_params->num_of_queues >= IWL_MIN_NUM_QUEUES &&
+        if (iwlagn_mod_params.num_of_queues >= IWL_MIN_NUM_QUEUES &&
-            priv->cfg->mod_params->num_of_queues <= IWLAGN_NUM_QUEUES)
+            iwlagn_mod_params.num_of_queues <= IWLAGN_NUM_QUEUES)
                priv->cfg->base_params->num_of_queues =
-                        priv->cfg->mod_params->num_of_queues;
+                        iwlagn_mod_params.num_of_queues;
        priv->hw_params.max_txq_num = priv->cfg->base_params->num_of_queues;
        priv->hw_params.dma_chnl_num = FH50_TCSR_CHNL_NUM;
@@ -231,7 +226,6 @@ static int iwl5150_hw_set_hw_params(struct iwl_priv *priv)
        priv->hw_params.max_data_size = IWLAGN_RTC_DATA_SIZE;
        priv->hw_params.max_inst_size = IWLAGN_RTC_INST_SIZE;
-        priv->hw_params.max_bsm_size = 0;
        priv->hw_params.ht40_channel =  BIT(IEEE80211_BAND_2GHZ) |
                                        BIT(IEEE80211_BAND_5GHZ);
        priv->hw_params.rx_wrt_ptr_reg = FH_RSCSR_CHNL0_WPTR;
@@ -263,7 +257,7 @@ static void iwl5150_temperature(struct iwl_priv *priv)
        u32 vt = 0;
        s32 offset =  iwl_temp_calib_to_offset(priv);
-        vt = le32_to_cpu(priv->_agn.statistics.general.common.temperature);
+        vt = le32_to_cpu(priv->statistics.common.temperature);
        vt = vt / IWL_5150_VOLTAGE_TO_TEMPERATURE_COEFF + offset;
        /* now vt hold the temperature in Kelvin */
        priv->temperature = KELVIN_TO_CELSIUS(vt);
@@ -345,24 +339,13 @@ static int iwl5000_hw_channel_switch(struct iwl_priv *priv,
 static struct iwl_lib_ops iwl5000_lib = {
        .set_hw_params = iwl5000_hw_set_hw_params,
-        .txq_update_byte_cnt_tbl = iwlagn_txq_update_byte_cnt_tbl,
-        .txq_inval_byte_cnt_tbl = iwlagn_txq_inval_byte_cnt_tbl,
        .txq_set_sched = iwlagn_txq_set_sched,
-        .txq_agg_enable = iwlagn_txq_agg_enable,
-        .txq_agg_disable = iwlagn_txq_agg_disable,
        .txq_attach_buf_to_tfd = iwl_hw_txq_attach_buf_to_tfd,
        .txq_free_tfd = iwl_hw_txq_free_tfd,
        .txq_init = iwl_hw_tx_queue_init,
        .rx_handler_setup = iwlagn_rx_handler_setup,
        .setup_deferred_work = iwlagn_setup_deferred_work,
        .is_valid_rtc_data_addr = iwlagn_hw_valid_rtc_data_addr,
-        .dump_nic_event_log = iwl_dump_nic_event_log,
-        .dump_nic_error_log = iwl_dump_nic_error_log,
-        .dump_csr = iwl_dump_csr,
-        .dump_fh = iwl_dump_fh,
-        .load_ucode = iwlagn_load_ucode,
-        .init_alive_start = iwlagn_init_alive_start,
-        .alive_notify = iwlagn_alive_notify,
        .send_tx_power = iwlagn_send_tx_power,
        .update_chain_flags = iwl_update_chain_flags,
        .set_channel_switch = iwl5000_hw_channel_switch,
@@ -380,56 +363,24 @@ static struct iwl_lib_ops iwl5000_lib = {
                        EEPROM_REG_BAND_24_HT40_CHANNELS,
                        EEPROM_REG_BAND_52_HT40_CHANNELS
                },
-                .acquire_semaphore = iwlcore_eeprom_acquire_semaphore,
-                .release_semaphore = iwlcore_eeprom_release_semaphore,
-                .calib_version  = iwlagn_eeprom_calib_version,
                .query_addr = iwlagn_eeprom_query_addr,
        },
-        .isr_ops = {
-                .isr = iwl_isr_ict,
-                .free = iwl_free_isr_ict,
-                .alloc = iwl_alloc_isr_ict,
-                .reset = iwl_reset_ict,
-                .disable = iwl_disable_ict,
-        },
        .temp_ops = {
                .temperature = iwlagn_temperature,
         },
-        .debugfs_ops = {
-                .rx_stats_read = iwl_ucode_rx_stats_read,
-                .tx_stats_read = iwl_ucode_tx_stats_read,
-                .general_stats_read = iwl_ucode_general_stats_read,
-                .bt_stats_read = iwl_ucode_bt_stats_read,
-                .reply_tx_error = iwl_reply_tx_error_read,
-        },
        .txfifo_flush = iwlagn_txfifo_flush,
        .dev_txfifo_flush = iwlagn_dev_txfifo_flush,
-        .tt_ops = {
-                .lower_power_detection = iwl_tt_is_low_power_state,
-                .tt_power_mode = iwl_tt_current_power_mode,
-                .ct_kill_check = iwl_check_for_ct_kill,
-        }
 };
 static struct iwl_lib_ops iwl5150_lib = {
        .set_hw_params = iwl5150_hw_set_hw_params,
-        .txq_update_byte_cnt_tbl = iwlagn_txq_update_byte_cnt_tbl,
-        .txq_inval_byte_cnt_tbl = iwlagn_txq_inval_byte_cnt_tbl,
        .txq_set_sched = iwlagn_txq_set_sched,
-        .txq_agg_enable = iwlagn_txq_agg_enable,
-        .txq_agg_disable = iwlagn_txq_agg_disable,
        .txq_attach_buf_to_tfd = iwl_hw_txq_attach_buf_to_tfd,
        .txq_free_tfd = iwl_hw_txq_free_tfd,
        .txq_init = iwl_hw_tx_queue_init,
        .rx_handler_setup = iwlagn_rx_handler_setup,
        .setup_deferred_work = iwlagn_setup_deferred_work,
        .is_valid_rtc_data_addr = iwlagn_hw_valid_rtc_data_addr,
-        .dump_nic_event_log = iwl_dump_nic_event_log,
-        .dump_nic_error_log = iwl_dump_nic_error_log,
-        .dump_csr = iwl_dump_csr,
-        .load_ucode = iwlagn_load_ucode,
-        .init_alive_start = iwlagn_init_alive_start,
-        .alive_notify = iwlagn_alive_notify,
        .send_tx_power = iwlagn_send_tx_power,
        .update_chain_flags = iwl_update_chain_flags,
        .set_channel_switch = iwl5000_hw_channel_switch,
@@ -447,51 +398,25 @@ static struct iwl_lib_ops iwl5150_lib = {
                        EEPROM_REG_BAND_24_HT40_CHANNELS,
                        EEPROM_REG_BAND_52_HT40_CHANNELS
                },
-                .acquire_semaphore = iwlcore_eeprom_acquire_semaphore,
-                .release_semaphore = iwlcore_eeprom_release_semaphore,
-                .calib_version  = iwlagn_eeprom_calib_version,
                .query_addr = iwlagn_eeprom_query_addr,
        },
-        .isr_ops = {
-                .isr = iwl_isr_ict,
-                .free = iwl_free_isr_ict,
-                .alloc = iwl_alloc_isr_ict,
-                .reset = iwl_reset_ict,
-                .disable = iwl_disable_ict,
-        },
        .temp_ops = {
                .temperature = iwl5150_temperature,
         },
-        .debugfs_ops = {
-                .rx_stats_read = iwl_ucode_rx_stats_read,
-                .tx_stats_read = iwl_ucode_tx_stats_read,
-                .general_stats_read = iwl_ucode_general_stats_read,
-                .bt_stats_read = iwl_ucode_bt_stats_read,
-                .reply_tx_error = iwl_reply_tx_error_read,
-        },
        .txfifo_flush = iwlagn_txfifo_flush,
        .dev_txfifo_flush = iwlagn_dev_txfifo_flush,
-        .tt_ops = {
-                .lower_power_detection = iwl_tt_is_low_power_state,
-                .tt_power_mode = iwl_tt_current_power_mode,
-                .ct_kill_check = iwl_check_for_ct_kill,
-        }
 };
 static const struct iwl_ops iwl5000_ops = {
        .lib = &iwl5000_lib,
        .hcmd = &iwlagn_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
 static const struct iwl_ops iwl5150_ops = {
        .lib = &iwl5150_lib,
        .hcmd = &iwlagn_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
 static struct iwl_base_params iwl5000_base_params = {
@@ -499,17 +424,12 @@ static struct iwl_base_params iwl5000_base_params = {
        .num_of_queues = IWLAGN_NUM_QUEUES,
        .num_of_ampdu_queues = IWLAGN_NUM_AMPDU_QUEUES,
        .pll_cfg_val = CSR50_ANA_PLL_CFG_VAL,
-        .set_l0s = true,
-        .use_bsm = false,
        .led_compensation = 51,
        .chain_noise_num_beacons = IWL_CAL_NUM_BEACONS,
        .plcp_delta_threshold = IWL_MAX_PLCP_ERR_LONG_THRESHOLD_DEF,
        .chain_noise_scale = 1000,
        .wd_timeout = IWL_LONG_WD_TIMEOUT,
        .max_event_log_size = 512,
-        .ucode_tracing = true,
-        .sensitivity_calib_by_driver = true,
-        .chain_noise_calib_by_driver = true,
 };
 static struct iwl_ht_params iwl5000_ht_params = {
        .ht_greenfield_support = true,
@@ -523,7 +443,6 @@ static struct iwl_ht_params iwl5000_ht_params = {
        .eeprom_ver = EEPROM_5000_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_5000_TX_POWER_VERSION,       \
        .ops = &iwl5000_ops,                                    \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl5000_base_params,                    \
        .led_mode = IWL_LED_BLINK
@@ -567,7 +486,6 @@ struct iwl_cfg iwl5350_agn_cfg = {
        .eeprom_ver = EEPROM_5050_EEPROM_VERSION,
        .eeprom_calib_ver = EEPROM_5050_TX_POWER_VERSION,
        .ops = &iwl5000_ops,
-        .mod_params = &iwlagn_mod_params,
        .base_params = &iwl5000_base_params,
        .ht_params = &iwl5000_ht_params,
        .led_mode = IWL_LED_BLINK,
@@ -581,7 +499,6 @@ struct iwl_cfg iwl5350_agn_cfg = {
        .eeprom_ver = EEPROM_5050_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_5050_TX_POWER_VERSION,       \
        .ops = &iwl5150_ops,                                    \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl5000_base_params,                    \
        .need_dc_calib = true,                                  \
        .led_mode = IWL_LED_BLINK,                              \
diff --git a/drivers/net/wireless/iwlwifi/iwl-6000-hw.h b/drivers/net/wireless/iwlwifi/iwl-6000-hw.h
index 47891e16a758..b27986e57c92 100644
--- a/drivers/net/wireless/iwlwifi/iwl-6000-hw.h
+++ b/drivers/net/wireless/iwlwifi/iwl-6000-hw.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2007 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2007 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
diff --git a/drivers/net/wireless/iwlwifi/iwl-6000.c b/drivers/net/wireless/iwlwifi/iwl-6000.c
index a745b01c0ec1..a7921f9a03c6 100644
--- a/drivers/net/wireless/iwlwifi/iwl-6000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-6000.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -46,8 +46,6 @@
 #include "iwl-helpers.h"
 #include "iwl-agn-hw.h"
 #include "iwl-6000-hw.h"
-#include "iwl-agn-led.h"
-#include "iwl-agn-debugfs.h"
 /* Highest firmware API version supported */
 #define IWL6000_UCODE_API_MAX 4
@@ -60,20 +58,16 @@
 #define IWL6000G2_UCODE_API_MIN 4
 #define IWL6000_FW_PRE "iwlwifi-6000-"
-#define _IWL6000_MODULE_FIRMWARE(api) IWL6000_FW_PRE #api ".ucode"
+#define IWL6000_MODULE_FIRMWARE(api) IWL6000_FW_PRE #api ".ucode"
-#define IWL6000_MODULE_FIRMWARE(api) _IWL6000_MODULE_FIRMWARE(api)
 #define IWL6050_FW_PRE "iwlwifi-6050-"
-#define _IWL6050_MODULE_FIRMWARE(api) IWL6050_FW_PRE #api ".ucode"
+#define IWL6050_MODULE_FIRMWARE(api) IWL6050_FW_PRE #api ".ucode"
-#define IWL6050_MODULE_FIRMWARE(api) _IWL6050_MODULE_FIRMWARE(api)
 #define IWL6005_FW_PRE "iwlwifi-6000g2a-"
-#define _IWL6005_MODULE_FIRMWARE(api) IWL6005_FW_PRE #api ".ucode"
+#define IWL6005_MODULE_FIRMWARE(api) IWL6005_FW_PRE #api ".ucode"
-#define IWL6005_MODULE_FIRMWARE(api) _IWL6005_MODULE_FIRMWARE(api)
 #define IWL6030_FW_PRE "iwlwifi-6000g2b-"
-#define _IWL6030_MODULE_FIRMWARE(api) IWL6030_FW_PRE #api ".ucode"
+#define IWL6030_MODULE_FIRMWARE(api) IWL6030_FW_PRE #api ".ucode"
-#define IWL6030_MODULE_FIRMWARE(api) _IWL6030_MODULE_FIRMWARE(api)
 static void iwl6000_set_ct_threshold(struct iwl_priv *priv)
 {
@@ -85,7 +79,7 @@ static void iwl6000_set_ct_threshold(struct iwl_priv *priv)
 static void iwl6050_additional_nic_config(struct iwl_priv *priv)
 {
        /* Indicate calibration version to uCode. */
-        if (priv->cfg->ops->lib->eeprom_ops.calib_version(priv) >= 6)
+        if (iwlagn_eeprom_calib_version(priv) >= 6)
                iwl_set_bit(priv, CSR_GP_DRIVER_REG,
                                CSR_GP_DRIVER_REG_BIT_CALIB_VERSION6);
 }
@@ -93,7 +87,7 @@ static void iwl6050_additional_nic_config(struct iwl_priv *priv)
 static void iwl6150_additional_nic_config(struct iwl_priv *priv)
 {
        /* Indicate calibration version to uCode. */
-        if (priv->cfg->ops->lib->eeprom_ops.calib_version(priv) >= 6)
+        if (iwlagn_eeprom_calib_version(priv) >= 6)
                iwl_set_bit(priv, CSR_GP_DRIVER_REG,
                                CSR_GP_DRIVER_REG_BIT_CALIB_VERSION6);
        iwl_set_bit(priv, CSR_GP_DRIVER_REG,
@@ -159,10 +153,10 @@ static struct iwl_sensitivity_ranges iwl6000_sensitivity = {
 static int iwl6000_hw_set_hw_params(struct iwl_priv *priv)
 {
-        if (priv->cfg->mod_params->num_of_queues >= IWL_MIN_NUM_QUEUES &&
+        if (iwlagn_mod_params.num_of_queues >= IWL_MIN_NUM_QUEUES &&
-            priv->cfg->mod_params->num_of_queues <= IWLAGN_NUM_QUEUES)
+            iwlagn_mod_params.num_of_queues <= IWLAGN_NUM_QUEUES)
                priv->cfg->base_params->num_of_queues =
-                        priv->cfg->mod_params->num_of_queues;
+                        iwlagn_mod_params.num_of_queues;
        priv->hw_params.max_txq_num = priv->cfg->base_params->num_of_queues;
        priv->hw_params.dma_chnl_num = FH50_TCSR_CHNL_NUM;
@@ -176,7 +170,6 @@ static int iwl6000_hw_set_hw_params(struct iwl_priv *priv)
        priv->hw_params.max_data_size = IWL60_RTC_DATA_SIZE;
        priv->hw_params.max_inst_size = IWL60_RTC_INST_SIZE;
-        priv->hw_params.max_bsm_size = 0;
        priv->hw_params.ht40_channel =  BIT(IEEE80211_BAND_2GHZ) |
                                        BIT(IEEE80211_BAND_5GHZ);
        priv->hw_params.rx_wrt_ptr_reg = FH_RSCSR_CHNL0_WPTR;
@@ -285,24 +278,13 @@ static int iwl6000_hw_channel_switch(struct iwl_priv *priv,
 static struct iwl_lib_ops iwl6000_lib = {
        .set_hw_params = iwl6000_hw_set_hw_params,
-        .txq_update_byte_cnt_tbl = iwlagn_txq_update_byte_cnt_tbl,
-        .txq_inval_byte_cnt_tbl = iwlagn_txq_inval_byte_cnt_tbl,
        .txq_set_sched = iwlagn_txq_set_sched,
-        .txq_agg_enable = iwlagn_txq_agg_enable,
-        .txq_agg_disable = iwlagn_txq_agg_disable,
        .txq_attach_buf_to_tfd = iwl_hw_txq_attach_buf_to_tfd,
        .txq_free_tfd = iwl_hw_txq_free_tfd,
        .txq_init = iwl_hw_tx_queue_init,
        .rx_handler_setup = iwlagn_rx_handler_setup,
        .setup_deferred_work = iwlagn_setup_deferred_work,
        .is_valid_rtc_data_addr = iwlagn_hw_valid_rtc_data_addr,
-        .load_ucode = iwlagn_load_ucode,
-        .dump_nic_event_log = iwl_dump_nic_event_log,
-        .dump_nic_error_log = iwl_dump_nic_error_log,
-        .dump_csr = iwl_dump_csr,
-        .dump_fh = iwl_dump_fh,
-        .init_alive_start = iwlagn_init_alive_start,
-        .alive_notify = iwlagn_alive_notify,
        .send_tx_power = iwlagn_send_tx_power,
        .update_chain_flags = iwl_update_chain_flags,
        .set_channel_switch = iwl6000_hw_channel_switch,
@@ -320,45 +302,19 @@ static struct iwl_lib_ops iwl6000_lib = {
                        EEPROM_6000_REG_BAND_24_HT40_CHANNELS,
                        EEPROM_REG_BAND_52_HT40_CHANNELS
                },
-                .acquire_semaphore = iwlcore_eeprom_acquire_semaphore,
-                .release_semaphore = iwlcore_eeprom_release_semaphore,
-                .calib_version  = iwlagn_eeprom_calib_version,
                .query_addr = iwlagn_eeprom_query_addr,
                .update_enhanced_txpower = iwlcore_eeprom_enhanced_txpower,
        },
-        .isr_ops = {
-                .isr = iwl_isr_ict,
-                .free = iwl_free_isr_ict,
-                .alloc = iwl_alloc_isr_ict,
-                .reset = iwl_reset_ict,
-                .disable = iwl_disable_ict,
-        },
        .temp_ops = {
                .temperature = iwlagn_temperature,
         },
-        .debugfs_ops = {
-                .rx_stats_read = iwl_ucode_rx_stats_read,
-                .tx_stats_read = iwl_ucode_tx_stats_read,
-                .general_stats_read = iwl_ucode_general_stats_read,
-                .bt_stats_read = iwl_ucode_bt_stats_read,
-                .reply_tx_error = iwl_reply_tx_error_read,
-        },
        .txfifo_flush = iwlagn_txfifo_flush,
        .dev_txfifo_flush = iwlagn_dev_txfifo_flush,
-        .tt_ops = {
-                .lower_power_detection = iwl_tt_is_low_power_state,
-                .tt_power_mode = iwl_tt_current_power_mode,
-                .ct_kill_check = iwl_check_for_ct_kill,
-        }
 };
 static struct iwl_lib_ops iwl6030_lib = {
        .set_hw_params = iwl6000_hw_set_hw_params,
-        .txq_update_byte_cnt_tbl = iwlagn_txq_update_byte_cnt_tbl,
-        .txq_inval_byte_cnt_tbl = iwlagn_txq_inval_byte_cnt_tbl,
        .txq_set_sched = iwlagn_txq_set_sched,
-        .txq_agg_enable = iwlagn_txq_agg_enable,
-        .txq_agg_disable = iwlagn_txq_agg_disable,
        .txq_attach_buf_to_tfd = iwl_hw_txq_attach_buf_to_tfd,
        .txq_free_tfd = iwl_hw_txq_free_tfd,
        .txq_init = iwl_hw_tx_queue_init,
@@ -366,13 +322,6 @@ static struct iwl_lib_ops iwl6030_lib = {
        .setup_deferred_work = iwlagn_bt_setup_deferred_work,
        .cancel_deferred_work = iwlagn_bt_cancel_deferred_work,
        .is_valid_rtc_data_addr = iwlagn_hw_valid_rtc_data_addr,
-        .load_ucode = iwlagn_load_ucode,
-        .dump_nic_event_log = iwl_dump_nic_event_log,
-        .dump_nic_error_log = iwl_dump_nic_error_log,
-        .dump_csr = iwl_dump_csr,
-        .dump_fh = iwl_dump_fh,
-        .init_alive_start = iwlagn_init_alive_start,
-        .alive_notify = iwlagn_alive_notify,
        .send_tx_power = iwlagn_send_tx_power,
        .update_chain_flags = iwl_update_chain_flags,
        .set_channel_switch = iwl6000_hw_channel_switch,
@@ -390,36 +339,14 @@ static struct iwl_lib_ops iwl6030_lib = {
                        EEPROM_6000_REG_BAND_24_HT40_CHANNELS,
                        EEPROM_REG_BAND_52_HT40_CHANNELS
                },
-                .acquire_semaphore = iwlcore_eeprom_acquire_semaphore,
-                .release_semaphore = iwlcore_eeprom_release_semaphore,
-                .calib_version  = iwlagn_eeprom_calib_version,
                .query_addr = iwlagn_eeprom_query_addr,
                .update_enhanced_txpower = iwlcore_eeprom_enhanced_txpower,
        },
-        .isr_ops = {
-                .isr = iwl_isr_ict,
-                .free = iwl_free_isr_ict,
-                .alloc = iwl_alloc_isr_ict,
-                .reset = iwl_reset_ict,
-                .disable = iwl_disable_ict,
-        },
        .temp_ops = {
                .temperature = iwlagn_temperature,
         },
-        .debugfs_ops = {
-                .rx_stats_read = iwl_ucode_rx_stats_read,
-                .tx_stats_read = iwl_ucode_tx_stats_read,
-                .general_stats_read = iwl_ucode_general_stats_read,
-                .bt_stats_read = iwl_ucode_bt_stats_read,
-                .reply_tx_error = iwl_reply_tx_error_read,
-        },
        .txfifo_flush = iwlagn_txfifo_flush,
        .dev_txfifo_flush = iwlagn_dev_txfifo_flush,
-        .tt_ops = {
-                .lower_power_detection = iwl_tt_is_low_power_state,
-                .tt_power_mode = iwl_tt_current_power_mode,
-                .ct_kill_check = iwl_check_for_ct_kill,
-        }
 };
 static struct iwl_nic_ops iwl6050_nic_ops = {
@@ -434,34 +361,26 @@ static const struct iwl_ops iwl6000_ops = {
        .lib = &iwl6000_lib,
        .hcmd = &iwlagn_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
 static const struct iwl_ops iwl6050_ops = {
        .lib = &iwl6000_lib,
        .hcmd = &iwlagn_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
        .nic = &iwl6050_nic_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
 static const struct iwl_ops iwl6150_ops = {
        .lib = &iwl6000_lib,
        .hcmd = &iwlagn_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
        .nic = &iwl6150_nic_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
 static const struct iwl_ops iwl6030_ops = {
        .lib = &iwl6030_lib,
        .hcmd = &iwlagn_bt_hcmd,
        .utils = &iwlagn_hcmd_utils,
-        .led = &iwlagn_led_ops,
-        .ieee80211_ops = &iwlagn_hw_ops,
 };
 static struct iwl_base_params iwl6000_base_params = {
@@ -469,8 +388,6 @@ static struct iwl_base_params iwl6000_base_params = {
        .num_of_queues = IWLAGN_NUM_QUEUES,
        .num_of_ampdu_queues = IWLAGN_NUM_AMPDU_QUEUES,
        .pll_cfg_val = 0,
-        .set_l0s = true,
-        .use_bsm = false,
        .max_ll_items = OTP_MAX_LL_ITEMS_6x00,
        .shadow_ram_support = true,
        .led_compensation = 51,
@@ -481,9 +398,6 @@ static struct iwl_base_params iwl6000_base_params = {
        .chain_noise_scale = 1000,
        .wd_timeout = IWL_DEF_WD_TIMEOUT,
        .max_event_log_size = 512,
-        .ucode_tracing = true,
-        .sensitivity_calib_by_driver = true,
-        .chain_noise_calib_by_driver = true,
        .shadow_reg_enable = true,
 };
@@ -492,8 +406,6 @@ static struct iwl_base_params iwl6050_base_params = {
        .num_of_queues = IWLAGN_NUM_QUEUES,
        .num_of_ampdu_queues = IWLAGN_NUM_AMPDU_QUEUES,
        .pll_cfg_val = 0,
-        .set_l0s = true,
-        .use_bsm = false,
        .max_ll_items = OTP_MAX_LL_ITEMS_6x50,
        .shadow_ram_support = true,
        .led_compensation = 51,
@@ -504,9 +416,6 @@ static struct iwl_base_params iwl6050_base_params = {
        .chain_noise_scale = 1500,
        .wd_timeout = IWL_DEF_WD_TIMEOUT,
        .max_event_log_size = 1024,
-        .ucode_tracing = true,
-        .sensitivity_calib_by_driver = true,
-        .chain_noise_calib_by_driver = true,
        .shadow_reg_enable = true,
 };
 static struct iwl_base_params iwl6000_g2_base_params = {
@@ -514,8 +423,6 @@ static struct iwl_base_params iwl6000_g2_base_params = {
        .num_of_queues = IWLAGN_NUM_QUEUES,
        .num_of_ampdu_queues = IWLAGN_NUM_AMPDU_QUEUES,
        .pll_cfg_val = 0,
-        .set_l0s = true,
-        .use_bsm = false,
        .max_ll_items = OTP_MAX_LL_ITEMS_6x00,
        .shadow_ram_support = true,
        .led_compensation = 57,
@@ -526,9 +433,6 @@ static struct iwl_base_params iwl6000_g2_base_params = {
        .chain_noise_scale = 1000,
        .wd_timeout = IWL_LONG_WD_TIMEOUT,
        .max_event_log_size = 512,
-        .ucode_tracing = true,
-        .sensitivity_calib_by_driver = true,
-        .chain_noise_calib_by_driver = true,
        .shadow_reg_enable = true,
 };
@@ -538,7 +442,6 @@ static struct iwl_ht_params iwl6000_ht_params = {
 };
 static struct iwl_bt_params iwl6000_bt_params = {
-        .bt_statistics = true,
        /* Due to bluetooth, we transmit 2.4 GHz probes only on antenna A */
        .advanced_bt_coexist = true,
        .agg_time_limit = BT_AGG_THRESHOLD_DEF,
@@ -554,7 +457,6 @@ static struct iwl_bt_params iwl6000_bt_params = {
        .eeprom_ver = EEPROM_6005_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_6005_TX_POWER_VERSION,       \
        .ops = &iwl6000_ops,                                    \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl6000_g2_base_params,                 \
        .need_dc_calib = true,                                  \
        .need_temp_offset_calib = true,                         \
@@ -583,7 +485,6 @@ struct iwl_cfg iwl6005_2bg_cfg = {
        .eeprom_ver = EEPROM_6030_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_6030_TX_POWER_VERSION,       \
        .ops = &iwl6030_ops,                                    \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl6000_g2_base_params,                 \
        .bt_params = &iwl6000_bt_params,                        \
        .need_dc_calib = true,                                  \
@@ -613,6 +514,22 @@ struct iwl_cfg iwl6030_2bg_cfg = {
        IWL_DEVICE_6030,
 };
+struct iwl_cfg iwl6035_2agn_cfg = {
+        .name = "6035 Series 2x2 AGN/BT",
+        IWL_DEVICE_6030,
+        .ht_params = &iwl6000_ht_params,
+};
+struct iwl_cfg iwl6035_2abg_cfg = {
+        .name = "6035 Series 2x2 ABG/BT",
+        IWL_DEVICE_6030,
+};
+struct iwl_cfg iwl6035_2bg_cfg = {
+        .name = "6035 Series 2x2 BG/BT",
+        IWL_DEVICE_6030,
+};
 struct iwl_cfg iwl1030_bgn_cfg = {
        .name = "Intel(R) Centrino(R) Wireless-N 1030 BGN",
        IWL_DEVICE_6030,
@@ -649,7 +566,6 @@ struct iwl_cfg iwl130_bg_cfg = {
        .eeprom_ver = EEPROM_6000_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_6000_TX_POWER_VERSION,       \
        .ops = &iwl6000_ops,                                    \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl6000_base_params,                    \
        .pa_type = IWL_PA_INTERNAL,                             \
        .led_mode = IWL_LED_BLINK
@@ -679,7 +595,6 @@ struct iwl_cfg iwl6000i_2bg_cfg = {
        .ops = &iwl6050_ops,                                    \
        .eeprom_ver = EEPROM_6050_EEPROM_VERSION,               \
        .eeprom_calib_ver = EEPROM_6050_TX_POWER_VERSION,       \
-        .mod_params = &iwlagn_mod_params,                       \
        .base_params = &iwl6050_base_params,                    \
        .need_dc_calib = true,                                  \
        .led_mode = IWL_LED_BLINK,                              \
@@ -704,7 +619,6 @@ struct iwl_cfg iwl6150_bgn_cfg = {
        .eeprom_ver = EEPROM_6150_EEPROM_VERSION,
        .eeprom_calib_ver = EEPROM_6150_TX_POWER_VERSION,
        .ops = &iwl6150_ops,
-        .mod_params = &iwlagn_mod_params,
        .base_params = &iwl6050_base_params,
        .ht_params = &iwl6000_ht_params,
        .need_dc_calib = true,
@@ -720,7 +634,6 @@ struct iwl_cfg iwl6000_3agn_cfg = {
        .eeprom_ver = EEPROM_6000_EEPROM_VERSION,
        .eeprom_calib_ver = EEPROM_6000_TX_POWER_VERSION,
        .ops = &iwl6000_ops,
-        .mod_params = &iwlagn_mod_params,
        .base_params = &iwl6000_base_params,
        .ht_params = &iwl6000_ht_params,
        .need_dc_calib = true,
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-calib.c b/drivers/net/wireless/iwlwifi/iwl-agn-calib.c
index 9006293e740c..0f6bb9b2e642 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-calib.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-calib.c
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -605,7 +605,7 @@ void iwl_init_sensitivity(struct iwl_priv *priv)
        IWL_DEBUG_CALIB(priv, "<<return 0x%X\n", ret);
 }
-void iwl_sensitivity_calibration(struct iwl_priv *priv, void *resp)
+void iwl_sensitivity_calibration(struct iwl_priv *priv)
 {
        u32 rx_enable_time;
        u32 fa_cck;
@@ -631,16 +631,9 @@ void iwl_sensitivity_calibration(struct iwl_priv *priv, void *resp)
        }
        spin_lock_irqsave(&priv->lock, flags);
-        if (iwl_bt_statistics(priv)) {
+        rx_info = &priv->statistics.rx_non_phy;
-                rx_info = &(((struct iwl_bt_notif_statistics *)resp)->
+        ofdm = &priv->statistics.rx_ofdm;
-                              rx.general.common);
+        cck = &priv->statistics.rx_cck;
-                ofdm = &(((struct iwl_bt_notif_statistics *)resp)->rx.ofdm);
-                cck = &(((struct iwl_bt_notif_statistics *)resp)->rx.cck);
-        } else {
-                rx_info = &(((struct iwl_notif_statistics *)resp)->rx.general);
-                ofdm = &(((struct iwl_notif_statistics *)resp)->rx.ofdm);
-                cck = &(((struct iwl_notif_statistics *)resp)->rx.cck);
-        }
        if (rx_info->interference_data_flag != INTERFERENCE_DATA_AVAILABLE) {
                IWL_DEBUG_CALIB(priv, "<< invalid data.\n");
                spin_unlock_irqrestore(&priv->lock, flags);
@@ -851,7 +844,7 @@ static void iwl_find_disconn_antenna(struct iwl_priv *priv, u32* average_sig,
 * 1)  Which antennas are connected.
 * 2)  Differential rx gain settings to balance the 3 receivers.
 */
-void iwl_chain_noise_calibration(struct iwl_priv *priv, void *stat_resp)
+void iwl_chain_noise_calibration(struct iwl_priv *priv)
 {
        struct iwl_chain_noise_data *data = NULL;
@@ -896,13 +889,9 @@ void iwl_chain_noise_calibration(struct iwl_priv *priv, void *stat_resp)
        }
        spin_lock_irqsave(&priv->lock, flags);
-        if (iwl_bt_statistics(priv)) {
-                rx_info = &(((struct iwl_bt_notif_statistics *)stat_resp)->
+        rx_info = &priv->statistics.rx_non_phy;
-                              rx.general.common);
-        } else {
-                rx_info = &(((struct iwl_notif_statistics *)stat_resp)->
-                              rx.general);
-        }
        if (rx_info->interference_data_flag != INTERFERENCE_DATA_AVAILABLE) {
                IWL_DEBUG_CALIB(priv, " << Interference data unavailable\n");
                spin_unlock_irqrestore(&priv->lock, flags);
@@ -911,19 +900,9 @@ void iwl_chain_noise_calibration(struct iwl_priv *priv, void *stat_resp)
        rxon_band24 = !!(ctx->staging.flags & RXON_FLG_BAND_24G_MSK);
        rxon_chnum = le16_to_cpu(ctx->staging.channel);
-        if (iwl_bt_statistics(priv)) {
+        stat_band24 =
-                stat_band24 = !!(((struct iwl_bt_notif_statistics *)
+                !!(priv->statistics.flag & STATISTICS_REPLY_FLG_BAND_24G_MSK);
-                                 stat_resp)->flag &
+        stat_chnum = le32_to_cpu(priv->statistics.flag) >> 16;
-                                 STATISTICS_REPLY_FLG_BAND_24G_MSK);
-                stat_chnum = le32_to_cpu(((struct iwl_bt_notif_statistics *)
-                                         stat_resp)->flag) >> 16;
-        } else {
-                stat_band24 = !!(((struct iwl_notif_statistics *)
-                                 stat_resp)->flag &
-                                 STATISTICS_REPLY_FLG_BAND_24G_MSK);
-                stat_chnum = le32_to_cpu(((struct iwl_notif_statistics *)
-                                         stat_resp)->flag) >> 16;
-        }
        /* Make sure we accumulate data for just the associated channel
         *   (even if scanning). */
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-calib.h b/drivers/net/wireless/iwlwifi/iwl-agn-calib.h
index e37ae7261630..4ef4dd934254 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-calib.h
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-calib.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -66,8 +66,8 @@
 #include "iwl-core.h"
 #include "iwl-commands.h"
-void iwl_chain_noise_calibration(struct iwl_priv *priv, void *stat_resp);
+void iwl_chain_noise_calibration(struct iwl_priv *priv);
-void iwl_sensitivity_calibration(struct iwl_priv *priv, void *resp);
+void iwl_sensitivity_calibration(struct iwl_priv *priv);
 void iwl_init_sensitivity(struct iwl_priv *priv);
 void iwl_reset_run_time_calib(struct iwl_priv *priv);
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-debugfs.c b/drivers/net/wireless/iwlwifi/iwl-agn-debugfs.c
deleted file mode 100644
index b500aaae53ec..000000000000
--- a/drivers/net/wireless/iwlwifi/iwl-agn-debugfs.c
+++ /dev/null
@@ -1,1073 +0,0 @@
-/******************************************************************************
-*
-* GPL LICENSE SUMMARY
-*
-* Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
-*
-* This program is free software; you can redistribute it and/or modify
-* it under the terms of version 2 of the GNU General Public License as
-* published by the Free Software Foundation.
-*
-* This program is distributed in the hope that it will be useful, but
-* WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-* General Public License for more details.
-*
-* You should have received a copy of the GNU General Public License
-* along with this program; if not, write to the Free Software
-* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110,
-* USA
-*
-* The full GNU General Public License is included in this distribution
-* in the file called LICENSE.GPL.
-*
-* Contact Information:
-*  Intel Linux Wireless <ilw@linux.intel.com>
-* Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
-*****************************************************************************/
-#include "iwl-agn.h"
-#include "iwl-agn-debugfs.h"
-static const char *fmt_value = "  %-30s %10u\n";
-static const char *fmt_hex   = "  %-30s       0x%02X\n";
-static const char *fmt_table = "  %-30s %10u  %10u  %10u  %10u\n";
-static const char *fmt_header =
-        "%-32s    current  cumulative       delta         max\n";
-static int iwl_statistics_flag(struct iwl_priv *priv, char *buf, int bufsz)
-{
-        int p = 0;
-        u32 flag;
-        if (iwl_bt_statistics(priv))
-                flag = le32_to_cpu(priv->_agn.statistics_bt.flag);
-        else
-                flag = le32_to_cpu(priv->_agn.statistics.flag);
-        p += scnprintf(buf + p, bufsz - p, "Statistics Flag(0x%X):\n", flag);
-        if (flag & UCODE_STATISTICS_CLEAR_MSK)
-                p += scnprintf(buf + p, bufsz - p,
-                "\tStatistics have been cleared\n");
-        p += scnprintf(buf + p, bufsz - p, "\tOperational Frequency: %s\n",
-                (flag & UCODE_STATISTICS_FREQUENCY_MSK)
-                ? "2.4 GHz" : "5.2 GHz");
-        p += scnprintf(buf + p, bufsz - p, "\tTGj Narrow Band: %s\n",
-                (flag & UCODE_STATISTICS_NARROW_BAND_MSK)
-                 ? "enabled" : "disabled");
-        return p;
-}
-ssize_t iwl_ucode_rx_stats_read(struct file *file, char __user *user_buf,
-                                size_t count, loff_t *ppos)
-  {
-        struct iwl_priv *priv = file->private_data;
-        int pos = 0;
-        char *buf;
-        int bufsz = sizeof(struct statistics_rx_phy) * 40 +
-                    sizeof(struct statistics_rx_non_phy) * 40 +
-                    sizeof(struct statistics_rx_ht_phy) * 40 + 400;
-        ssize_t ret;
-        struct statistics_rx_phy *ofdm, *accum_ofdm, *delta_ofdm, *max_ofdm;
-        struct statistics_rx_phy *cck, *accum_cck, *delta_cck, *max_cck;
-        struct statistics_rx_non_phy *general, *accum_general;
-        struct statistics_rx_non_phy *delta_general, *max_general;
-        struct statistics_rx_ht_phy *ht, *accum_ht, *delta_ht, *max_ht;
-        if (!iwl_is_alive(priv))
-                return -EAGAIN;
-        buf = kzalloc(bufsz, GFP_KERNEL);
-        if (!buf) {
-                IWL_ERR(priv, "Can not allocate Buffer\n");
-                return -ENOMEM;
-        }
-        /*
-         * the statistic information display here is based on
-         * the last statistics notification from uCode
-         * might not reflect the current uCode activity
-         */
-        if (iwl_bt_statistics(priv)) {
-                ofdm = &priv->_agn.statistics_bt.rx.ofdm;
-                cck = &priv->_agn.statistics_bt.rx.cck;
-                general = &priv->_agn.statistics_bt.rx.general.common;
-                ht = &priv->_agn.statistics_bt.rx.ofdm_ht;
-                accum_ofdm = &priv->_agn.accum_statistics_bt.rx.ofdm;
-                accum_cck = &priv->_agn.accum_statistics_bt.rx.cck;
-                accum_general =
-                        &priv->_agn.accum_statistics_bt.rx.general.common;
-                accum_ht = &priv->_agn.accum_statistics_bt.rx.ofdm_ht;
-                delta_ofdm = &priv->_agn.delta_statistics_bt.rx.ofdm;
-                delta_cck = &priv->_agn.delta_statistics_bt.rx.cck;
-                delta_general =
-                        &priv->_agn.delta_statistics_bt.rx.general.common;
-                delta_ht = &priv->_agn.delta_statistics_bt.rx.ofdm_ht;
-                max_ofdm = &priv->_agn.max_delta_bt.rx.ofdm;
-                max_cck = &priv->_agn.max_delta_bt.rx.cck;
-                max_general = &priv->_agn.max_delta_bt.rx.general.common;
-                max_ht = &priv->_agn.max_delta_bt.rx.ofdm_ht;
-        } else {
-                ofdm = &priv->_agn.statistics.rx.ofdm;
-                cck = &priv->_agn.statistics.rx.cck;
-                general = &priv->_agn.statistics.rx.general;
-                ht = &priv->_agn.statistics.rx.ofdm_ht;
-                accum_ofdm = &priv->_agn.accum_statistics.rx.ofdm;
-                accum_cck = &priv->_agn.accum_statistics.rx.cck;
-                accum_general = &priv->_agn.accum_statistics.rx.general;
-                accum_ht = &priv->_agn.accum_statistics.rx.ofdm_ht;
-                delta_ofdm = &priv->_agn.delta_statistics.rx.ofdm;
-                delta_cck = &priv->_agn.delta_statistics.rx.cck;
-                delta_general = &priv->_agn.delta_statistics.rx.general;
-                delta_ht = &priv->_agn.delta_statistics.rx.ofdm_ht;
-                max_ofdm = &priv->_agn.max_delta.rx.ofdm;
-                max_cck = &priv->_agn.max_delta.rx.cck;
-                max_general = &priv->_agn.max_delta.rx.general;
-                max_ht = &priv->_agn.max_delta.rx.ofdm_ht;
-        }
-        pos += iwl_statistics_flag(priv, buf, bufsz);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_header, "Statistics_Rx - OFDM:");
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "ina_cnt:",
-                         le32_to_cpu(ofdm->ina_cnt),
-                         accum_ofdm->ina_cnt,
-                         delta_ofdm->ina_cnt, max_ofdm->ina_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "fina_cnt:",
-                         le32_to_cpu(ofdm->fina_cnt), accum_ofdm->fina_cnt,
-                         delta_ofdm->fina_cnt, max_ofdm->fina_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "plcp_err:",
-                         le32_to_cpu(ofdm->plcp_err), accum_ofdm->plcp_err,
-                         delta_ofdm->plcp_err, max_ofdm->plcp_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "crc32_err:",
-                         le32_to_cpu(ofdm->crc32_err), accum_ofdm->crc32_err,
-                         delta_ofdm->crc32_err, max_ofdm->crc32_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "overrun_err:",
-                         le32_to_cpu(ofdm->overrun_err),
-                         accum_ofdm->overrun_err, delta_ofdm->overrun_err,
-                         max_ofdm->overrun_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "early_overrun_err:",
-                         le32_to_cpu(ofdm->early_overrun_err),
-                         accum_ofdm->early_overrun_err,
-                         delta_ofdm->early_overrun_err,
-                         max_ofdm->early_overrun_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "crc32_good:",
-                         le32_to_cpu(ofdm->crc32_good),
-                         accum_ofdm->crc32_good, delta_ofdm->crc32_good,
-                         max_ofdm->crc32_good);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "false_alarm_cnt:",
-                         le32_to_cpu(ofdm->false_alarm_cnt),
-                         accum_ofdm->false_alarm_cnt,
-                         delta_ofdm->false_alarm_cnt,
-                         max_ofdm->false_alarm_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "fina_sync_err_cnt:",
-                         le32_to_cpu(ofdm->fina_sync_err_cnt),
-                         accum_ofdm->fina_sync_err_cnt,
-                         delta_ofdm->fina_sync_err_cnt,
-                         max_ofdm->fina_sync_err_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "sfd_timeout:",
-                         le32_to_cpu(ofdm->sfd_timeout),
-                         accum_ofdm->sfd_timeout, delta_ofdm->sfd_timeout,
-                         max_ofdm->sfd_timeout);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "fina_timeout:",
-                         le32_to_cpu(ofdm->fina_timeout),
-                         accum_ofdm->fina_timeout, delta_ofdm->fina_timeout,
-                         max_ofdm->fina_timeout);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "unresponded_rts:",
-                         le32_to_cpu(ofdm->unresponded_rts),
-                         accum_ofdm->unresponded_rts,
-                         delta_ofdm->unresponded_rts,
-                         max_ofdm->unresponded_rts);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "rxe_frame_lmt_ovrun:",
-                         le32_to_cpu(ofdm->rxe_frame_limit_overrun),
-                         accum_ofdm->rxe_frame_limit_overrun,
-                         delta_ofdm->rxe_frame_limit_overrun,
-                         max_ofdm->rxe_frame_limit_overrun);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "sent_ack_cnt:",
-                         le32_to_cpu(ofdm->sent_ack_cnt),
-                         accum_ofdm->sent_ack_cnt, delta_ofdm->sent_ack_cnt,
-                         max_ofdm->sent_ack_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "sent_cts_cnt:",
-                         le32_to_cpu(ofdm->sent_cts_cnt),
-                         accum_ofdm->sent_cts_cnt, delta_ofdm->sent_cts_cnt,
-                         max_ofdm->sent_cts_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "sent_ba_rsp_cnt:",
-                         le32_to_cpu(ofdm->sent_ba_rsp_cnt),
-                         accum_ofdm->sent_ba_rsp_cnt,
-                         delta_ofdm->sent_ba_rsp_cnt,
-                         max_ofdm->sent_ba_rsp_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "dsp_self_kill:",
-                         le32_to_cpu(ofdm->dsp_self_kill),
-                         accum_ofdm->dsp_self_kill,
-                         delta_ofdm->dsp_self_kill,
-                         max_ofdm->dsp_self_kill);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "mh_format_err:",
-                         le32_to_cpu(ofdm->mh_format_err),
-                         accum_ofdm->mh_format_err,
-                         delta_ofdm->mh_format_err,
-                         max_ofdm->mh_format_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "re_acq_main_rssi_sum:",
-                         le32_to_cpu(ofdm->re_acq_main_rssi_sum),
-                         accum_ofdm->re_acq_main_rssi_sum,
-                         delta_ofdm->re_acq_main_rssi_sum,
-                         max_ofdm->re_acq_main_rssi_sum);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_header, "Statistics_Rx - CCK:");
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "ina_cnt:",
-                         le32_to_cpu(cck->ina_cnt), accum_cck->ina_cnt,
-                         delta_cck->ina_cnt, max_cck->ina_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "fina_cnt:",
-                         le32_to_cpu(cck->fina_cnt), accum_cck->fina_cnt,
-                         delta_cck->fina_cnt, max_cck->fina_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "plcp_err:",
-                         le32_to_cpu(cck->plcp_err), accum_cck->plcp_err,
-                         delta_cck->plcp_err, max_cck->plcp_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "crc32_err:",
-                         le32_to_cpu(cck->crc32_err), accum_cck->crc32_err,
-                         delta_cck->crc32_err, max_cck->crc32_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "overrun_err:",
-                         le32_to_cpu(cck->overrun_err),
-                         accum_cck->overrun_err, delta_cck->overrun_err,
-                         max_cck->overrun_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "early_overrun_err:",
-                         le32_to_cpu(cck->early_overrun_err),
-                         accum_cck->early_overrun_err,
-                         delta_cck->early_overrun_err,
-                         max_cck->early_overrun_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "crc32_good:",
-                         le32_to_cpu(cck->crc32_good), accum_cck->crc32_good,
-                         delta_cck->crc32_good, max_cck->crc32_good);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "false_alarm_cnt:",
-                         le32_to_cpu(cck->false_alarm_cnt),
-                         accum_cck->false_alarm_cnt,
-                         delta_cck->false_alarm_cnt, max_cck->false_alarm_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "fina_sync_err_cnt:",
-                         le32_to_cpu(cck->fina_sync_err_cnt),
-                         accum_cck->fina_sync_err_cnt,
-                         delta_cck->fina_sync_err_cnt,
-                         max_cck->fina_sync_err_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "sfd_timeout:",
-                         le32_to_cpu(cck->sfd_timeout),
-                         accum_cck->sfd_timeout, delta_cck->sfd_timeout,
-                         max_cck->sfd_timeout);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "fina_timeout:",
-                         le32_to_cpu(cck->fina_timeout),
-                         accum_cck->fina_timeout, delta_cck->fina_timeout,
-                         max_cck->fina_timeout);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "unresponded_rts:",
-                         le32_to_cpu(cck->unresponded_rts),
-                         accum_cck->unresponded_rts, delta_cck->unresponded_rts,
-                         max_cck->unresponded_rts);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "rxe_frame_lmt_ovrun:",
-                         le32_to_cpu(cck->rxe_frame_limit_overrun),
-                         accum_cck->rxe_frame_limit_overrun,
-                         delta_cck->rxe_frame_limit_overrun,
-                         max_cck->rxe_frame_limit_overrun);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "sent_ack_cnt:",
-                         le32_to_cpu(cck->sent_ack_cnt),
-                         accum_cck->sent_ack_cnt, delta_cck->sent_ack_cnt,
-                         max_cck->sent_ack_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "sent_cts_cnt:",
-                         le32_to_cpu(cck->sent_cts_cnt),
-                         accum_cck->sent_cts_cnt, delta_cck->sent_cts_cnt,
-                         max_cck->sent_cts_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "sent_ba_rsp_cnt:",
-                         le32_to_cpu(cck->sent_ba_rsp_cnt),
-                         accum_cck->sent_ba_rsp_cnt,
-                         delta_cck->sent_ba_rsp_cnt,
-                         max_cck->sent_ba_rsp_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "dsp_self_kill:",
-                         le32_to_cpu(cck->dsp_self_kill),
-                         accum_cck->dsp_self_kill, delta_cck->dsp_self_kill,
-                         max_cck->dsp_self_kill);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "mh_format_err:",
-                         le32_to_cpu(cck->mh_format_err),
-                         accum_cck->mh_format_err, delta_cck->mh_format_err,
-                         max_cck->mh_format_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "re_acq_main_rssi_sum:",
-                         le32_to_cpu(cck->re_acq_main_rssi_sum),
-                         accum_cck->re_acq_main_rssi_sum,
-                         delta_cck->re_acq_main_rssi_sum,
-                         max_cck->re_acq_main_rssi_sum);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_header, "Statistics_Rx - GENERAL:");
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "bogus_cts:",
-                         le32_to_cpu(general->bogus_cts),
-                         accum_general->bogus_cts, delta_general->bogus_cts,
-                         max_general->bogus_cts);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "bogus_ack:",
-                         le32_to_cpu(general->bogus_ack),
-                         accum_general->bogus_ack, delta_general->bogus_ack,
-                         max_general->bogus_ack);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "non_bssid_frames:",
-                         le32_to_cpu(general->non_bssid_frames),
-                         accum_general->non_bssid_frames,
-                         delta_general->non_bssid_frames,
-                         max_general->non_bssid_frames);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "filtered_frames:",
-                         le32_to_cpu(general->filtered_frames),
-                         accum_general->filtered_frames,
-                         delta_general->filtered_frames,
-                         max_general->filtered_frames);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "non_channel_beacons:",
-                         le32_to_cpu(general->non_channel_beacons),
-                         accum_general->non_channel_beacons,
-                         delta_general->non_channel_beacons,
-                         max_general->non_channel_beacons);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "channel_beacons:",
-                         le32_to_cpu(general->channel_beacons),
-                         accum_general->channel_beacons,
-                         delta_general->channel_beacons,
-                         max_general->channel_beacons);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "num_missed_bcon:",
-                         le32_to_cpu(general->num_missed_bcon),
-                         accum_general->num_missed_bcon,
-                         delta_general->num_missed_bcon,
-                         max_general->num_missed_bcon);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "adc_rx_saturation_time:",
-                         le32_to_cpu(general->adc_rx_saturation_time),
-                         accum_general->adc_rx_saturation_time,
-                         delta_general->adc_rx_saturation_time,
-                         max_general->adc_rx_saturation_time);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "ina_detect_search_tm:",
-                         le32_to_cpu(general->ina_detection_search_time),
-                         accum_general->ina_detection_search_time,
-                         delta_general->ina_detection_search_time,
-                         max_general->ina_detection_search_time);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "beacon_silence_rssi_a:",
-                         le32_to_cpu(general->beacon_silence_rssi_a),
-                         accum_general->beacon_silence_rssi_a,
-                         delta_general->beacon_silence_rssi_a,
-                         max_general->beacon_silence_rssi_a);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "beacon_silence_rssi_b:",
-                         le32_to_cpu(general->beacon_silence_rssi_b),
-                         accum_general->beacon_silence_rssi_b,
-                         delta_general->beacon_silence_rssi_b,
-                         max_general->beacon_silence_rssi_b);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "beacon_silence_rssi_c:",
-                         le32_to_cpu(general->beacon_silence_rssi_c),
-                         accum_general->beacon_silence_rssi_c,
-                         delta_general->beacon_silence_rssi_c,
-                         max_general->beacon_silence_rssi_c);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "interference_data_flag:",
-                         le32_to_cpu(general->interference_data_flag),
-                         accum_general->interference_data_flag,
-                         delta_general->interference_data_flag,
-                         max_general->interference_data_flag);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "channel_load:",
-                         le32_to_cpu(general->channel_load),
-                         accum_general->channel_load,
-                         delta_general->channel_load,
-                         max_general->channel_load);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "dsp_false_alarms:",
-                         le32_to_cpu(general->dsp_false_alarms),
-                         accum_general->dsp_false_alarms,
-                         delta_general->dsp_false_alarms,
-                         max_general->dsp_false_alarms);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "beacon_rssi_a:",
-                         le32_to_cpu(general->beacon_rssi_a),
-                         accum_general->beacon_rssi_a,
-                         delta_general->beacon_rssi_a,
-                         max_general->beacon_rssi_a);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "beacon_rssi_b:",
-                         le32_to_cpu(general->beacon_rssi_b),
-                         accum_general->beacon_rssi_b,
-                         delta_general->beacon_rssi_b,
-                         max_general->beacon_rssi_b);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "beacon_rssi_c:",
-                         le32_to_cpu(general->beacon_rssi_c),
-                         accum_general->beacon_rssi_c,
-                         delta_general->beacon_rssi_c,
-                         max_general->beacon_rssi_c);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "beacon_energy_a:",
-                         le32_to_cpu(general->beacon_energy_a),
-                         accum_general->beacon_energy_a,
-                         delta_general->beacon_energy_a,
-                         max_general->beacon_energy_a);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "beacon_energy_b:",
-                         le32_to_cpu(general->beacon_energy_b),
-                         accum_general->beacon_energy_b,
-                         delta_general->beacon_energy_b,
-                         max_general->beacon_energy_b);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "beacon_energy_c:",
-                         le32_to_cpu(general->beacon_energy_c),
-                         accum_general->beacon_energy_c,
-                         delta_general->beacon_energy_c,
-                         max_general->beacon_energy_c);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_header, "Statistics_Rx - OFDM_HT:");
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "plcp_err:",
-                         le32_to_cpu(ht->plcp_err), accum_ht->plcp_err,
-                         delta_ht->plcp_err, max_ht->plcp_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "overrun_err:",
-                         le32_to_cpu(ht->overrun_err), accum_ht->overrun_err,
-                         delta_ht->overrun_err, max_ht->overrun_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "early_overrun_err:",
-                         le32_to_cpu(ht->early_overrun_err),
-                         accum_ht->early_overrun_err,
-                         delta_ht->early_overrun_err,
-                         max_ht->early_overrun_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "crc32_good:",
-                         le32_to_cpu(ht->crc32_good), accum_ht->crc32_good,
-                         delta_ht->crc32_good, max_ht->crc32_good);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "crc32_err:",
-                         le32_to_cpu(ht->crc32_err), accum_ht->crc32_err,
-                         delta_ht->crc32_err, max_ht->crc32_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "mh_format_err:",
-                         le32_to_cpu(ht->mh_format_err),
-                         accum_ht->mh_format_err,
-                         delta_ht->mh_format_err, max_ht->mh_format_err);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg_crc32_good:",
-                         le32_to_cpu(ht->agg_crc32_good),
-                         accum_ht->agg_crc32_good,
-                         delta_ht->agg_crc32_good, max_ht->agg_crc32_good);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg_mpdu_cnt:",
-                         le32_to_cpu(ht->agg_mpdu_cnt),
-                         accum_ht->agg_mpdu_cnt,
-                         delta_ht->agg_mpdu_cnt, max_ht->agg_mpdu_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg_cnt:",
-                         le32_to_cpu(ht->agg_cnt), accum_ht->agg_cnt,
-                         delta_ht->agg_cnt, max_ht->agg_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "unsupport_mcs:",
-                         le32_to_cpu(ht->unsupport_mcs),
-                         accum_ht->unsupport_mcs,
-                         delta_ht->unsupport_mcs, max_ht->unsupport_mcs);
-        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
-        kfree(buf);
-        return ret;
-}
-ssize_t iwl_ucode_tx_stats_read(struct file *file,
-                                char __user *user_buf,
-                                size_t count, loff_t *ppos)
-{
-        struct iwl_priv *priv = file->private_data;
-        int pos = 0;
-        char *buf;
-        int bufsz = (sizeof(struct statistics_tx) * 48) + 250;
-        ssize_t ret;
-        struct statistics_tx *tx, *accum_tx, *delta_tx, *max_tx;
-        if (!iwl_is_alive(priv))
-                return -EAGAIN;
-        buf = kzalloc(bufsz, GFP_KERNEL);
-        if (!buf) {
-                IWL_ERR(priv, "Can not allocate Buffer\n");
-                return -ENOMEM;
-        }
-        /* the statistic information display here is based on
-          * the last statistics notification from uCode
-          * might not reflect the current uCode activity
-          */
-        if (iwl_bt_statistics(priv)) {
-                tx = &priv->_agn.statistics_bt.tx;
-                accum_tx = &priv->_agn.accum_statistics_bt.tx;
-                delta_tx = &priv->_agn.delta_statistics_bt.tx;
-                max_tx = &priv->_agn.max_delta_bt.tx;
-        } else {
-                tx = &priv->_agn.statistics.tx;
-                accum_tx = &priv->_agn.accum_statistics.tx;
-                delta_tx = &priv->_agn.delta_statistics.tx;
-                max_tx = &priv->_agn.max_delta.tx;
-        }
-        pos += iwl_statistics_flag(priv, buf, bufsz);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_header, "Statistics_Tx:");
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "preamble:",
-                         le32_to_cpu(tx->preamble_cnt),
-                         accum_tx->preamble_cnt,
-                         delta_tx->preamble_cnt, max_tx->preamble_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "rx_detected_cnt:",
-                         le32_to_cpu(tx->rx_detected_cnt),
-                         accum_tx->rx_detected_cnt,
-                         delta_tx->rx_detected_cnt, max_tx->rx_detected_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "bt_prio_defer_cnt:",
-                         le32_to_cpu(tx->bt_prio_defer_cnt),
-                         accum_tx->bt_prio_defer_cnt,
-                         delta_tx->bt_prio_defer_cnt,
-                         max_tx->bt_prio_defer_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "bt_prio_kill_cnt:",
-                         le32_to_cpu(tx->bt_prio_kill_cnt),
-                         accum_tx->bt_prio_kill_cnt,
-                         delta_tx->bt_prio_kill_cnt,
-                         max_tx->bt_prio_kill_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "few_bytes_cnt:",
-                         le32_to_cpu(tx->few_bytes_cnt),
-                         accum_tx->few_bytes_cnt,
-                         delta_tx->few_bytes_cnt, max_tx->few_bytes_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "cts_timeout:",
-                         le32_to_cpu(tx->cts_timeout), accum_tx->cts_timeout,
-                         delta_tx->cts_timeout, max_tx->cts_timeout);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "ack_timeout:",
-                         le32_to_cpu(tx->ack_timeout),
-                         accum_tx->ack_timeout,
-                         delta_tx->ack_timeout, max_tx->ack_timeout);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "expected_ack_cnt:",
-                         le32_to_cpu(tx->expected_ack_cnt),
-                         accum_tx->expected_ack_cnt,
-                         delta_tx->expected_ack_cnt,
-                         max_tx->expected_ack_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "actual_ack_cnt:",
-                         le32_to_cpu(tx->actual_ack_cnt),
-                         accum_tx->actual_ack_cnt,
-                         delta_tx->actual_ack_cnt,
-                         max_tx->actual_ack_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "dump_msdu_cnt:",
-                         le32_to_cpu(tx->dump_msdu_cnt),
-                         accum_tx->dump_msdu_cnt,
-                         delta_tx->dump_msdu_cnt,
-                         max_tx->dump_msdu_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "abort_nxt_frame_mismatch:",
-                         le32_to_cpu(tx->burst_abort_next_frame_mismatch_cnt),
-                         accum_tx->burst_abort_next_frame_mismatch_cnt,
-                         delta_tx->burst_abort_next_frame_mismatch_cnt,
-                         max_tx->burst_abort_next_frame_mismatch_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "abort_missing_nxt_frame:",
-                         le32_to_cpu(tx->burst_abort_missing_next_frame_cnt),
-                         accum_tx->burst_abort_missing_next_frame_cnt,
-                         delta_tx->burst_abort_missing_next_frame_cnt,
-                         max_tx->burst_abort_missing_next_frame_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "cts_timeout_collision:",
-                         le32_to_cpu(tx->cts_timeout_collision),
-                         accum_tx->cts_timeout_collision,
-                         delta_tx->cts_timeout_collision,
-                         max_tx->cts_timeout_collision);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "ack_ba_timeout_collision:",
-                         le32_to_cpu(tx->ack_or_ba_timeout_collision),
-                         accum_tx->ack_or_ba_timeout_collision,
-                         delta_tx->ack_or_ba_timeout_collision,
-                         max_tx->ack_or_ba_timeout_collision);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg ba_timeout:",
-                         le32_to_cpu(tx->agg.ba_timeout),
-                         accum_tx->agg.ba_timeout,
-                         delta_tx->agg.ba_timeout,
-                         max_tx->agg.ba_timeout);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg ba_resched_frames:",
-                         le32_to_cpu(tx->agg.ba_reschedule_frames),
-                         accum_tx->agg.ba_reschedule_frames,
-                         delta_tx->agg.ba_reschedule_frames,
-                         max_tx->agg.ba_reschedule_frames);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg scd_query_agg_frame:",
-                         le32_to_cpu(tx->agg.scd_query_agg_frame_cnt),
-                         accum_tx->agg.scd_query_agg_frame_cnt,
-                         delta_tx->agg.scd_query_agg_frame_cnt,
-                         max_tx->agg.scd_query_agg_frame_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg scd_query_no_agg:",
-                         le32_to_cpu(tx->agg.scd_query_no_agg),
-                         accum_tx->agg.scd_query_no_agg,
-                         delta_tx->agg.scd_query_no_agg,
-                         max_tx->agg.scd_query_no_agg);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg scd_query_agg:",
-                         le32_to_cpu(tx->agg.scd_query_agg),
-                         accum_tx->agg.scd_query_agg,
-                         delta_tx->agg.scd_query_agg,
-                         max_tx->agg.scd_query_agg);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg scd_query_mismatch:",
-                         le32_to_cpu(tx->agg.scd_query_mismatch),
-                         accum_tx->agg.scd_query_mismatch,
-                         delta_tx->agg.scd_query_mismatch,
-                         max_tx->agg.scd_query_mismatch);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg frame_not_ready:",
-                         le32_to_cpu(tx->agg.frame_not_ready),
-                         accum_tx->agg.frame_not_ready,
-                         delta_tx->agg.frame_not_ready,
-                         max_tx->agg.frame_not_ready);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg underrun:",
-                         le32_to_cpu(tx->agg.underrun),
-                         accum_tx->agg.underrun,
-                         delta_tx->agg.underrun, max_tx->agg.underrun);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg bt_prio_kill:",
-                         le32_to_cpu(tx->agg.bt_prio_kill),
-                         accum_tx->agg.bt_prio_kill,
-                         delta_tx->agg.bt_prio_kill,
-                         max_tx->agg.bt_prio_kill);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "agg rx_ba_rsp_cnt:",
-                         le32_to_cpu(tx->agg.rx_ba_rsp_cnt),
-                         accum_tx->agg.rx_ba_rsp_cnt,
-                         delta_tx->agg.rx_ba_rsp_cnt,
-                         max_tx->agg.rx_ba_rsp_cnt);
-        if (tx->tx_power.ant_a || tx->tx_power.ant_b || tx->tx_power.ant_c) {
-                pos += scnprintf(buf + pos, bufsz - pos,
-                        "tx power: (1/2 dB step)\n");
-                if ((priv->cfg->valid_tx_ant & ANT_A) && tx->tx_power.ant_a)
-                        pos += scnprintf(buf + pos, bufsz - pos,
-                                        fmt_hex, "antenna A:",
-                                        tx->tx_power.ant_a);
-                if ((priv->cfg->valid_tx_ant & ANT_B) && tx->tx_power.ant_b)
-                        pos += scnprintf(buf + pos, bufsz - pos,
-                                        fmt_hex, "antenna B:",
-                                        tx->tx_power.ant_b);
-                if ((priv->cfg->valid_tx_ant & ANT_C) && tx->tx_power.ant_c)
-                        pos += scnprintf(buf + pos, bufsz - pos,
-                                        fmt_hex, "antenna C:",
-                                        tx->tx_power.ant_c);
-        }
-        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
-        kfree(buf);
-        return ret;
-}
-ssize_t iwl_ucode_general_stats_read(struct file *file, char __user *user_buf,
-                                     size_t count, loff_t *ppos)
-{
-        struct iwl_priv *priv = file->private_data;
-        int pos = 0;
-        char *buf;
-        int bufsz = sizeof(struct statistics_general) * 10 + 300;
-        ssize_t ret;
-        struct statistics_general_common *general, *accum_general;
-        struct statistics_general_common *delta_general, *max_general;
-        struct statistics_dbg *dbg, *accum_dbg, *delta_dbg, *max_dbg;
-        struct statistics_div *div, *accum_div, *delta_div, *max_div;
-        if (!iwl_is_alive(priv))
-                return -EAGAIN;
-        buf = kzalloc(bufsz, GFP_KERNEL);
-        if (!buf) {
-                IWL_ERR(priv, "Can not allocate Buffer\n");
-                return -ENOMEM;
-        }
-        /* the statistic information display here is based on
-          * the last statistics notification from uCode
-          * might not reflect the current uCode activity
-          */
-        if (iwl_bt_statistics(priv)) {
-                general = &priv->_agn.statistics_bt.general.common;
-                dbg = &priv->_agn.statistics_bt.general.common.dbg;
-                div = &priv->_agn.statistics_bt.general.common.div;
-                accum_general = &priv->_agn.accum_statistics_bt.general.common;
-                accum_dbg = &priv->_agn.accum_statistics_bt.general.common.dbg;
-                accum_div = &priv->_agn.accum_statistics_bt.general.common.div;
-                delta_general = &priv->_agn.delta_statistics_bt.general.common;
-                max_general = &priv->_agn.max_delta_bt.general.common;
-                delta_dbg = &priv->_agn.delta_statistics_bt.general.common.dbg;
-                max_dbg = &priv->_agn.max_delta_bt.general.common.dbg;
-                delta_div = &priv->_agn.delta_statistics_bt.general.common.div;
-                max_div = &priv->_agn.max_delta_bt.general.common.div;
-        } else {
-                general = &priv->_agn.statistics.general.common;
-                dbg = &priv->_agn.statistics.general.common.dbg;
-                div = &priv->_agn.statistics.general.common.div;
-                accum_general = &priv->_agn.accum_statistics.general.common;
-                accum_dbg = &priv->_agn.accum_statistics.general.common.dbg;
-                accum_div = &priv->_agn.accum_statistics.general.common.div;
-                delta_general = &priv->_agn.delta_statistics.general.common;
-                max_general = &priv->_agn.max_delta.general.common;
-                delta_dbg = &priv->_agn.delta_statistics.general.common.dbg;
-                max_dbg = &priv->_agn.max_delta.general.common.dbg;
-                delta_div = &priv->_agn.delta_statistics.general.common.div;
-                max_div = &priv->_agn.max_delta.general.common.div;
-        }
-        pos += iwl_statistics_flag(priv, buf, bufsz);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_header, "Statistics_General:");
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_value, "temperature:",
-                         le32_to_cpu(general->temperature));
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_value, "temperature_m:",
-                         le32_to_cpu(general->temperature_m));
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_value, "ttl_timestamp:",
-                         le32_to_cpu(general->ttl_timestamp));
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "burst_check:",
-                         le32_to_cpu(dbg->burst_check),
-                         accum_dbg->burst_check,
-                         delta_dbg->burst_check, max_dbg->burst_check);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "burst_count:",
-                         le32_to_cpu(dbg->burst_count),
-                         accum_dbg->burst_count,
-                         delta_dbg->burst_count, max_dbg->burst_count);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "wait_for_silence_timeout_count:",
-                         le32_to_cpu(dbg->wait_for_silence_timeout_cnt),
-                         accum_dbg->wait_for_silence_timeout_cnt,
-                         delta_dbg->wait_for_silence_timeout_cnt,
-                         max_dbg->wait_for_silence_timeout_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "sleep_time:",
-                         le32_to_cpu(general->sleep_time),
-                         accum_general->sleep_time,
-                         delta_general->sleep_time, max_general->sleep_time);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "slots_out:",
-                         le32_to_cpu(general->slots_out),
-                         accum_general->slots_out,
-                         delta_general->slots_out, max_general->slots_out);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "slots_idle:",
-                         le32_to_cpu(general->slots_idle),
-                         accum_general->slots_idle,
-                         delta_general->slots_idle, max_general->slots_idle);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "tx_on_a:",
-                         le32_to_cpu(div->tx_on_a), accum_div->tx_on_a,
-                         delta_div->tx_on_a, max_div->tx_on_a);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "tx_on_b:",
-                         le32_to_cpu(div->tx_on_b), accum_div->tx_on_b,
-                         delta_div->tx_on_b, max_div->tx_on_b);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "exec_time:",
-                         le32_to_cpu(div->exec_time), accum_div->exec_time,
-                         delta_div->exec_time, max_div->exec_time);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "probe_time:",
-                         le32_to_cpu(div->probe_time), accum_div->probe_time,
-                         delta_div->probe_time, max_div->probe_time);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "rx_enable_counter:",
-                         le32_to_cpu(general->rx_enable_counter),
-                         accum_general->rx_enable_counter,
-                         delta_general->rx_enable_counter,
-                         max_general->rx_enable_counter);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         fmt_table, "num_of_sos_states:",
-                         le32_to_cpu(general->num_of_sos_states),
-                         accum_general->num_of_sos_states,
-                         delta_general->num_of_sos_states,
-                         max_general->num_of_sos_states);
-        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
-        kfree(buf);
-        return ret;
-}
-ssize_t iwl_ucode_bt_stats_read(struct file *file,
-                                char __user *user_buf,
-                                size_t count, loff_t *ppos)
-{
-        struct iwl_priv *priv = (struct iwl_priv *)file->private_data;
-        int pos = 0;
-        char *buf;
-        int bufsz = (sizeof(struct statistics_bt_activity) * 24) + 200;
-        ssize_t ret;
-        struct statistics_bt_activity *bt, *accum_bt;
-        if (!iwl_is_alive(priv))
-                return -EAGAIN;
-        if (!priv->bt_enable_flag)
-                return -EINVAL;
-        /* make request to uCode to retrieve statistics information */
-        mutex_lock(&priv->mutex);
-        ret = iwl_send_statistics_request(priv, CMD_SYNC, false);
-        mutex_unlock(&priv->mutex);
-        if (ret) {
-                IWL_ERR(priv,
-                        "Error sending statistics request: %zd\n", ret);
-                return -EAGAIN;
-        }
-        buf = kzalloc(bufsz, GFP_KERNEL);
-        if (!buf) {
-                IWL_ERR(priv, "Can not allocate Buffer\n");
-                return -ENOMEM;
-        }
-        /*
-         * the statistic information display here is based on
-         * the last statistics notification from uCode
-         * might not reflect the current uCode activity
-         */
-        bt = &priv->_agn.statistics_bt.general.activity;
-        accum_bt = &priv->_agn.accum_statistics_bt.general.activity;
-        pos += iwl_statistics_flag(priv, buf, bufsz);
-        pos += scnprintf(buf + pos, bufsz - pos, "Statistics_BT:\n");
-        pos += scnprintf(buf + pos, bufsz - pos,
-                        "\t\t\tcurrent\t\t\taccumulative\n");
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         "hi_priority_tx_req_cnt:\t\t%u\t\t\t%u\n",
-                         le32_to_cpu(bt->hi_priority_tx_req_cnt),
-                         accum_bt->hi_priority_tx_req_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         "hi_priority_tx_denied_cnt:\t%u\t\t\t%u\n",
-                         le32_to_cpu(bt->hi_priority_tx_denied_cnt),
-                         accum_bt->hi_priority_tx_denied_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         "lo_priority_tx_req_cnt:\t\t%u\t\t\t%u\n",
-                         le32_to_cpu(bt->lo_priority_tx_req_cnt),
-                         accum_bt->lo_priority_tx_req_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         "lo_priority_tx_denied_cnt:\t%u\t\t\t%u\n",
-                         le32_to_cpu(bt->lo_priority_tx_denied_cnt),
-                         accum_bt->lo_priority_tx_denied_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         "hi_priority_rx_req_cnt:\t\t%u\t\t\t%u\n",
-                         le32_to_cpu(bt->hi_priority_rx_req_cnt),
-                         accum_bt->hi_priority_rx_req_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         "hi_priority_rx_denied_cnt:\t%u\t\t\t%u\n",
-                         le32_to_cpu(bt->hi_priority_rx_denied_cnt),
-                         accum_bt->hi_priority_rx_denied_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         "lo_priority_rx_req_cnt:\t\t%u\t\t\t%u\n",
-                         le32_to_cpu(bt->lo_priority_rx_req_cnt),
-                         accum_bt->lo_priority_rx_req_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         "lo_priority_rx_denied_cnt:\t%u\t\t\t%u\n",
-                         le32_to_cpu(bt->lo_priority_rx_denied_cnt),
-                         accum_bt->lo_priority_rx_denied_cnt);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         "(rx)num_bt_kills:\t\t%u\t\t\t%u\n",
-                         le32_to_cpu(priv->_agn.statistics_bt.rx.
-                                general.num_bt_kills),
-                         priv->_agn.accum_statistics_bt.rx.
-                                general.num_bt_kills);
-        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
-        kfree(buf);
-        return ret;
-}
-ssize_t iwl_reply_tx_error_read(struct file *file,
-                                char __user *user_buf,
-                                size_t count, loff_t *ppos)
-{
-        struct iwl_priv *priv = (struct iwl_priv *)file->private_data;
-        int pos = 0;
-        char *buf;
-        int bufsz = (sizeof(struct reply_tx_error_statistics) * 24) +
-                (sizeof(struct reply_agg_tx_error_statistics) * 24) + 200;
-        ssize_t ret;
-        if (!iwl_is_alive(priv))
-                return -EAGAIN;
-        buf = kzalloc(bufsz, GFP_KERNEL);
-        if (!buf) {
-                IWL_ERR(priv, "Can not allocate Buffer\n");
-                return -ENOMEM;
-        }
-        pos += scnprintf(buf + pos, bufsz - pos, "Statistics_TX_Error:\n");
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_POSTPONE_DELAY),
-                         priv->_agn.reply_tx_stats.pp_delay);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_POSTPONE_FEW_BYTES),
-                         priv->_agn.reply_tx_stats.pp_few_bytes);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_POSTPONE_BT_PRIO),
-                         priv->_agn.reply_tx_stats.pp_bt_prio);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_POSTPONE_QUIET_PERIOD),
-                         priv->_agn.reply_tx_stats.pp_quiet_period);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_POSTPONE_CALC_TTAK),
-                         priv->_agn.reply_tx_stats.pp_calc_ttak);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
-                         iwl_get_tx_fail_reason(
-                                TX_STATUS_FAIL_INTERNAL_CROSSED_RETRY),
-                         priv->_agn.reply_tx_stats.int_crossed_retry);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_SHORT_LIMIT),
-                         priv->_agn.reply_tx_stats.short_limit);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_LONG_LIMIT),
-                         priv->_agn.reply_tx_stats.long_limit);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_FIFO_UNDERRUN),
-                         priv->_agn.reply_tx_stats.fifo_underrun);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_DRAIN_FLOW),
-                         priv->_agn.reply_tx_stats.drain_flow);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_RFKILL_FLUSH),
-                         priv->_agn.reply_tx_stats.rfkill_flush);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_LIFE_EXPIRE),
-                         priv->_agn.reply_tx_stats.life_expire);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_DEST_PS),
-                         priv->_agn.reply_tx_stats.dest_ps);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_HOST_ABORTED),
-                         priv->_agn.reply_tx_stats.host_abort);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_BT_RETRY),
-                         priv->_agn.reply_tx_stats.pp_delay);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_STA_INVALID),
-                         priv->_agn.reply_tx_stats.sta_invalid);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_FRAG_DROPPED),
-                         priv->_agn.reply_tx_stats.frag_drop);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_TID_DISABLE),
-                         priv->_agn.reply_tx_stats.tid_disable);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_FIFO_FLUSHED),
-                         priv->_agn.reply_tx_stats.fifo_flush);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
-                         iwl_get_tx_fail_reason(
-                                TX_STATUS_FAIL_INSUFFICIENT_CF_POLL),
-                         priv->_agn.reply_tx_stats.insuff_cf_poll);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_PASSIVE_NO_RX),
-                         priv->_agn.reply_tx_stats.fail_hw_drop);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
-                         iwl_get_tx_fail_reason(
-                                TX_STATUS_FAIL_NO_BEACON_ON_RADAR),
-                         priv->_agn.reply_tx_stats.sta_color_mismatch);
-        pos += scnprintf(buf + pos, bufsz - pos, "UNKNOWN:\t\t\t%u\n",
-                         priv->_agn.reply_tx_stats.unknown);
-        pos += scnprintf(buf + pos, bufsz - pos,
-                         "\nStatistics_Agg_TX_Error:\n");
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_UNDERRUN_MSK),
-                         priv->_agn.reply_agg_tx_stats.underrun);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_BT_PRIO_MSK),
-                         priv->_agn.reply_agg_tx_stats.bt_prio);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_FEW_BYTES_MSK),
-                         priv->_agn.reply_agg_tx_stats.few_bytes);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_ABORT_MSK),
-                         priv->_agn.reply_agg_tx_stats.abort);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(
-                                AGG_TX_STATE_LAST_SENT_TTL_MSK),
-                         priv->_agn.reply_agg_tx_stats.last_sent_ttl);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(
-                                AGG_TX_STATE_LAST_SENT_TRY_CNT_MSK),
-                         priv->_agn.reply_agg_tx_stats.last_sent_try);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(
-                                AGG_TX_STATE_LAST_SENT_BT_KILL_MSK),
-                         priv->_agn.reply_agg_tx_stats.last_sent_bt_kill);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_SCD_QUERY_MSK),
-                         priv->_agn.reply_agg_tx_stats.scd_query);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(
-                                AGG_TX_STATE_TEST_BAD_CRC32_MSK),
-                         priv->_agn.reply_agg_tx_stats.bad_crc32);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_RESPONSE_MSK),
-                         priv->_agn.reply_agg_tx_stats.response);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_DUMP_TX_MSK),
-                         priv->_agn.reply_agg_tx_stats.dump_tx);
-        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
-                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_DELAY_TX_MSK),
-                         priv->_agn.reply_agg_tx_stats.delay_tx);
-        pos += scnprintf(buf + pos, bufsz - pos, "UNKNOWN:\t\t\t%u\n",
-                         priv->_agn.reply_agg_tx_stats.unknown);
-        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
-        kfree(buf);
-        return ret;
-}
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-debugfs.h b/drivers/net/wireless/iwlwifi/iwl-agn-debugfs.h
deleted file mode 100644
index f2573b5486cd..000000000000
--- a/drivers/net/wireless/iwlwifi/iwl-agn-debugfs.h
+++ /dev/null
@@ -1,70 +0,0 @@
-/******************************************************************************
- *
- * GPL LICENSE SUMMARY
- *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110,
- * USA
- *
- * The full GNU General Public License is included in this distribution
- * in the file called LICENSE.GPL.
- *
- * Contact Information:
- *  Intel Linux Wireless <ilw@linux.intel.com>
- * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
- *****************************************************************************/
-#include "iwl-dev.h"
-#include "iwl-core.h"
-#include "iwl-debug.h"
-#ifdef CONFIG_IWLWIFI_DEBUGFS
-ssize_t iwl_ucode_rx_stats_read(struct file *file, char __user *user_buf,
-                                size_t count, loff_t *ppos);
-ssize_t iwl_ucode_tx_stats_read(struct file *file, char __user *user_buf,
-                                size_t count, loff_t *ppos);
-ssize_t iwl_ucode_general_stats_read(struct file *file, char __user *user_buf,
-                                     size_t count, loff_t *ppos);
-ssize_t iwl_ucode_bt_stats_read(struct file *file, char __user *user_buf,
-                                size_t count, loff_t *ppos);
-ssize_t iwl_reply_tx_error_read(struct file *file, char __user *user_buf,
-                                size_t count, loff_t *ppos);
-#else
-static ssize_t iwl_ucode_rx_stats_read(struct file *file, char __user *user_buf,
-                                       size_t count, loff_t *ppos)
-{
-        return 0;
-}
-static ssize_t iwl_ucode_tx_stats_read(struct file *file, char __user *user_buf,
-                                       size_t count, loff_t *ppos)
-{
-        return 0;
-}
-static ssize_t iwl_ucode_general_stats_read(struct file *file, char __user *user_buf,
-                                            size_t count, loff_t *ppos)
-{
-        return 0;
-}
-static ssize_t iwl_ucode_bt_stats_read(struct file *file, char __user *user_buf,
-                                       size_t count, loff_t *ppos)
-{
-        return 0;
-}
-static ssize_t iwl_reply_tx_error_read(struct file *file, char __user *user_buf,
-                                       size_t count, loff_t *ppos)
-{
-        return 0;
-}
-#endif
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-eeprom.c b/drivers/net/wireless/iwlwifi/iwl-agn-eeprom.c
index 27b5a3eec9dc..2ef9448b1c20 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-eeprom.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-eeprom.c
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -81,52 +81,13 @@
 *
 ******************************************************************************/
-/*
- * The device's EEPROM semaphore prevents conflicts between driver and uCode
- * when accessing the EEPROM; each access is a series of pulses to/from the
- * EEPROM chip, not a single event, so even reads could conflict if they
- * weren't arbitrated by the semaphore.
- */
-int iwlcore_eeprom_acquire_semaphore(struct iwl_priv *priv)
-{
-        u16 count;
-        int ret;
-        for (count = 0; count < EEPROM_SEM_RETRY_LIMIT; count++) {
-                /* Request semaphore */
-                iwl_set_bit(priv, CSR_HW_IF_CONFIG_REG,
-                            CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM);
-                /* See if we got it */
-                ret = iwl_poll_bit(priv, CSR_HW_IF_CONFIG_REG,
-                                CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM,
-                                CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM,
-                                EEPROM_SEM_TIMEOUT);
-                if (ret >= 0) {
-                        IWL_DEBUG_IO(priv,
-                                "Acquired semaphore after %d tries.\n",
-                                count+1);
-                        return ret;
-                }
-        }
-        return ret;
-}
-void iwlcore_eeprom_release_semaphore(struct iwl_priv *priv)
-{
-        iwl_clear_bit(priv, CSR_HW_IF_CONFIG_REG,
-                CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM);
-}
 int iwl_eeprom_check_version(struct iwl_priv *priv)
 {
        u16 eeprom_ver;
        u16 calib_ver;
        eeprom_ver = iwl_eeprom_query16(priv, EEPROM_VERSION);
-        calib_ver = priv->cfg->ops->lib->eeprom_ops.calib_version(priv);
+        calib_ver = iwlagn_eeprom_calib_version(priv);
        if (eeprom_ver < priv->cfg->eeprom_ver ||
            calib_ver < priv->cfg->eeprom_calib_ver)
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-hcmd.c b/drivers/net/wireless/iwlwifi/iwl-agn-hcmd.c
index 41543ad4cb84..b12c72d63ccb 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-hcmd.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-hcmd.c
@@ -2,7 +2,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -37,54 +37,6 @@
 #include "iwl-io.h"
 #include "iwl-agn.h"
-int iwlagn_send_rxon_assoc(struct iwl_priv *priv,
-                           struct iwl_rxon_context *ctx)
-{
-        int ret = 0;
-        struct iwl5000_rxon_assoc_cmd rxon_assoc;
-        const struct iwl_rxon_cmd *rxon1 = &ctx->staging;
-        const struct iwl_rxon_cmd *rxon2 = &ctx->active;
-        if ((rxon1->flags == rxon2->flags) &&
-            (rxon1->filter_flags == rxon2->filter_flags) &&
-            (rxon1->cck_basic_rates == rxon2->cck_basic_rates) &&
-            (rxon1->ofdm_ht_single_stream_basic_rates ==
-             rxon2->ofdm_ht_single_stream_basic_rates) &&
-            (rxon1->ofdm_ht_dual_stream_basic_rates ==
-             rxon2->ofdm_ht_dual_stream_basic_rates) &&
-            (rxon1->ofdm_ht_triple_stream_basic_rates ==
-             rxon2->ofdm_ht_triple_stream_basic_rates) &&
-            (rxon1->acquisition_data == rxon2->acquisition_data) &&
-            (rxon1->rx_chain == rxon2->rx_chain) &&
-            (rxon1->ofdm_basic_rates == rxon2->ofdm_basic_rates)) {
-                IWL_DEBUG_INFO(priv, "Using current RXON_ASSOC.  Not resending.\n");
-                return 0;
-        }
-        rxon_assoc.flags = ctx->staging.flags;
-        rxon_assoc.filter_flags = ctx->staging.filter_flags;
-        rxon_assoc.ofdm_basic_rates = ctx->staging.ofdm_basic_rates;
-        rxon_assoc.cck_basic_rates = ctx->staging.cck_basic_rates;
-        rxon_assoc.reserved1 = 0;
-        rxon_assoc.reserved2 = 0;
-        rxon_assoc.reserved3 = 0;
-        rxon_assoc.ofdm_ht_single_stream_basic_rates =
-            ctx->staging.ofdm_ht_single_stream_basic_rates;
-        rxon_assoc.ofdm_ht_dual_stream_basic_rates =
-            ctx->staging.ofdm_ht_dual_stream_basic_rates;
-        rxon_assoc.rx_chain_select_flags = ctx->staging.rx_chain;
-        rxon_assoc.ofdm_ht_triple_stream_basic_rates =
-                 ctx->staging.ofdm_ht_triple_stream_basic_rates;
-        rxon_assoc.acquisition_data = ctx->staging.acquisition_data;
-        ret = iwl_send_cmd_pdu_async(priv, ctx->rxon_assoc_cmd,
-                                     sizeof(rxon_assoc), &rxon_assoc, NULL);
-        if (ret)
-                return ret;
-        return ret;
-}
 int iwlagn_send_tx_ant_config(struct iwl_priv *priv, u8 valid_tx_ant)
 {
        struct iwl_tx_ant_config_cmd tx_ant_cmd = {
@@ -102,12 +54,6 @@ int iwlagn_send_tx_ant_config(struct iwl_priv *priv, u8 valid_tx_ant)
        }
 }
-/* Currently this is the superset of everything */
-static u16 iwlagn_get_hcmd_size(u8 cmd_id, u16 len)
-{
-        return len;
-}
 static u16 iwlagn_build_addsta_hcmd(const struct iwl_addsta_cmd *cmd, u8 *data)
 {
        u16 size = (u16)sizeof(struct iwl_addsta_cmd);
@@ -364,7 +310,6 @@ static int iwlagn_set_pan_params(struct iwl_priv *priv)
 }
 struct iwl_hcmd_ops iwlagn_hcmd = {
-        .rxon_assoc = iwlagn_send_rxon_assoc,
        .commit_rxon = iwlagn_commit_rxon,
        .set_rxon_chain = iwlagn_set_rxon_chain,
        .set_tx_ant = iwlagn_send_tx_ant_config,
@@ -373,7 +318,6 @@ struct iwl_hcmd_ops iwlagn_hcmd = {
 };
 struct iwl_hcmd_ops iwlagn_bt_hcmd = {
-        .rxon_assoc = iwlagn_send_rxon_assoc,
        .commit_rxon = iwlagn_commit_rxon,
        .set_rxon_chain = iwlagn_set_rxon_chain,
        .set_tx_ant = iwlagn_send_tx_ant_config,
@@ -382,7 +326,6 @@ struct iwl_hcmd_ops iwlagn_bt_hcmd = {
 };
 struct iwl_hcmd_utils_ops iwlagn_hcmd_utils = {
-        .get_hcmd_size = iwlagn_get_hcmd_size,
        .build_addsta_hcmd = iwlagn_build_addsta_hcmd,
        .gain_computation = iwlagn_gain_computation,
        .chain_noise_reset = iwlagn_chain_noise_reset,
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-hw.h b/drivers/net/wireless/iwlwifi/iwl-agn-hw.h
index a52b82c8e7a6..7bd19f4e66de 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-hw.h
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-hw.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2007 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2007 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
index ed0148d714de..0d5fda44c3a3 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
@@ -2,7 +2,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -59,8 +59,6 @@ void iwl_free_isr_ict(struct iwl_priv *priv)
 int iwl_alloc_isr_ict(struct iwl_priv *priv)
 {
-        if (priv->cfg->base_params->use_isr_legacy)
-                return 0;
        /* allocate shrared data table */
        priv->_agn.ict_tbl_vir =
                dma_alloc_coherent(&priv->pci_dev->dev,
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-led.c b/drivers/net/wireless/iwlwifi/iwl-agn-led.c
deleted file mode 100644
index c1190d965614..000000000000
--- a/drivers/net/wireless/iwlwifi/iwl-agn-led.c
+++ /dev/null
@@ -1,73 +0,0 @@
-/******************************************************************************
- *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
- * The full GNU General Public License is included in this distribution in the
- * file called LICENSE.
- *
- * Contact Information:
- *  Intel Linux Wireless <ilw@linux.intel.com>
- * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
- *
- *****************************************************************************/
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/init.h>
-#include <linux/pci.h>
-#include <linux/dma-mapping.h>
-#include <linux/delay.h>
-#include <linux/skbuff.h>
-#include <linux/netdevice.h>
-#include <linux/wireless.h>
-#include <net/mac80211.h>
-#include <linux/etherdevice.h>
-#include <asm/unaligned.h>
-#include "iwl-commands.h"
-#include "iwl-dev.h"
-#include "iwl-core.h"
-#include "iwl-io.h"
-#include "iwl-agn-led.h"
-/* Send led command */
-static int iwl_send_led_cmd(struct iwl_priv *priv, struct iwl_led_cmd *led_cmd)
-{
-        struct iwl_host_cmd cmd = {
-                .id = REPLY_LEDS_CMD,
-                .len = sizeof(struct iwl_led_cmd),
-                .data = led_cmd,
-                .flags = CMD_ASYNC,
-                .callback = NULL,
-        };
-        u32 reg;
-        reg = iwl_read32(priv, CSR_LED_REG);
-        if (reg != (reg & CSR_LED_BSM_CTRL_MSK))
-                iwl_write32(priv, CSR_LED_REG, reg & CSR_LED_BSM_CTRL_MSK);
-        return iwl_send_cmd(priv, &cmd);
-}
-/* Set led register off */
-void iwlagn_led_enable(struct iwl_priv *priv)
-{
-        iwl_write32(priv, CSR_LED_REG, CSR_LED_REG_TRUN_ON);
-}
-const struct iwl_led_ops iwlagn_led_ops = {
-        .cmd = iwl_send_led_cmd,
-};
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
index 08ccb9496f76..8e79653aed9a 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
@@ -2,7 +2,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -172,6 +172,7 @@ static void iwlagn_count_agg_tx_err_status(struct iwl_priv *priv, u16 status)
 static void iwlagn_set_tx_status(struct iwl_priv *priv,
                                 struct ieee80211_tx_info *info,
+                                 struct iwl_rxon_context *ctx,
                                 struct iwlagn_tx_resp *tx_resp,
                                 int txq_id, bool is_agg)
 {
@@ -186,6 +187,13 @@ static void iwlagn_set_tx_status(struct iwl_priv *priv,
        if (!iwl_is_tx_success(status))
                iwlagn_count_tx_err_status(priv, status);
+        if (status == TX_STATUS_FAIL_PASSIVE_NO_RX &&
+            iwl_is_associated_ctx(ctx) && ctx->vif &&
+            ctx->vif->type == NL80211_IFTYPE_STATION) {
+                ctx->last_tx_rejected = true;
+                iwl_stop_queue(priv, &priv->txq[txq_id]);
+        }
        IWL_DEBUG_TX_REPLY(priv, "TXQ %d status %s (0x%08x) rate_n_flags "
                           "0x%x retries %d\n",
                           txq_id,
@@ -242,15 +250,16 @@ static int iwlagn_tx_status_reply_tx(struct iwl_priv *priv,
        /* # frames attempted by Tx command */
        if (agg->frame_count == 1) {
+                struct iwl_tx_info *txb;
                /* Only one frame was attempted; no block-ack will arrive */
                idx = start_idx;
                IWL_DEBUG_TX_REPLY(priv, "FrameCnt = %d, StartIdx=%d idx=%d\n",
                                   agg->frame_count, agg->start_idx, idx);
-                iwlagn_set_tx_status(priv,
+                txb = &priv->txq[txq_id].txb[idx];
-                                     IEEE80211_SKB_CB(
+                iwlagn_set_tx_status(priv, IEEE80211_SKB_CB(txb->skb),
-                                        priv->txq[txq_id].txb[idx].skb),
+                                     txb->ctx, tx_resp, txq_id, true);
-                                     tx_resp, txq_id, true);
                agg->wait_for_ba = 0;
        } else {
                /* Two or more frames were attempted; expect block-ack */
@@ -391,7 +400,8 @@ static void iwlagn_rx_reply_tx(struct iwl_priv *priv,
        struct iwl_tx_queue *txq = &priv->txq[txq_id];
        struct ieee80211_tx_info *info;
        struct iwlagn_tx_resp *tx_resp = (void *)&pkt->u.raw[0];
-        u32  status = le16_to_cpu(tx_resp->status.status);
+        struct iwl_tx_info *txb;
+        u32 status = le16_to_cpu(tx_resp->status.status);
        int tid;
        int sta_id;
        int freed;
@@ -406,7 +416,8 @@ static void iwlagn_rx_reply_tx(struct iwl_priv *priv,
        }
        txq->time_stamp = jiffies;
-        info = IEEE80211_SKB_CB(txq->txb[txq->q.read_ptr].skb);
+        txb = &txq->txb[txq->q.read_ptr];
+        info = IEEE80211_SKB_CB(txb->skb);
        memset(&info->status, 0, sizeof(info->status));
        tid = (tx_resp->ra_tid & IWLAGN_TX_RES_TID_MSK) >>
@@ -450,12 +461,14 @@ static void iwlagn_rx_reply_tx(struct iwl_priv *priv,
                                iwl_wake_queue(priv, txq);
                }
        } else {
-                iwlagn_set_tx_status(priv, info, tx_resp, txq_id, false);
+                iwlagn_set_tx_status(priv, info, txb->ctx, tx_resp,
+                                     txq_id, false);
                freed = iwlagn_tx_queue_reclaim(priv, txq_id, index);
                iwl_free_tfds_in_queue(priv, sta_id, tid, freed);
                if (priv->mac80211_registered &&
-                    (iwl_queue_space(&txq->q) > txq->q.low_mark))
+                    iwl_queue_space(&txq->q) > txq->q.low_mark &&
+                    status != TX_STATUS_FAIL_PASSIVE_NO_RX)
                        iwl_wake_queue(priv, txq);
        }
@@ -470,8 +483,6 @@ void iwlagn_rx_handler_setup(struct iwl_priv *priv)
        /* init calibration handlers */
        priv->rx_handlers[CALIBRATION_RES_NOTIFICATION] =
                                        iwlagn_rx_calib_result;
-        priv->rx_handlers[CALIBRATION_COMPLETE_NOTIFICATION] =
-                                        iwlagn_rx_calib_complete;
        priv->rx_handlers[REPLY_TX] = iwlagn_rx_reply_tx;
        /* set up notification wait support */
@@ -482,8 +493,10 @@ void iwlagn_rx_handler_setup(struct iwl_priv *priv)
 void iwlagn_setup_deferred_work(struct iwl_priv *priv)
 {
-        /* in agn, the tx power calibration is done in uCode */
+        /*
-        priv->disable_tx_power_cal = 1;
+         * nothing need to be done here anymore
+         * still keep for future use if needed
+         */
 }
 int iwlagn_hw_valid_rtc_data_addr(u32 addr)
@@ -534,9 +547,7 @@ int iwlagn_send_tx_power(struct iwl_priv *priv)
 void iwlagn_temperature(struct iwl_priv *priv)
 {
        /* store temperature from correct statistics (in Celsius) */
-        priv->temperature = le32_to_cpu((iwl_bt_statistics(priv)) ?
+        priv->temperature = le32_to_cpu(priv->statistics.common.temperature);
-                priv->_agn.statistics_bt.general.common.temperature :
-                priv->_agn.statistics.general.common.temperature);
        iwl_tt_handler(priv);
 }
@@ -652,10 +663,9 @@ int iwlagn_rx_init(struct iwl_priv *priv, struct iwl_rx_queue *rxq)
        const u32 rfdnlog = RX_QUEUE_SIZE_LOG; /* 256 RBDs */
        u32 rb_timeout = 0; /* FIXME: RX_RB_TIMEOUT for all devices? */
-        if (!priv->cfg->base_params->use_isr_legacy)
+        rb_timeout = RX_RB_TIMEOUT;
-                rb_timeout = RX_RB_TIMEOUT;
-        if (priv->cfg->mod_params->amsdu_size_8K)
+        if (iwlagn_mod_params.amsdu_size_8K)
                rb_size = FH_RCSR_RX_CONFIG_REG_VAL_RB_SIZE_8K;
        else
                rb_size = FH_RCSR_RX_CONFIG_REG_VAL_RB_SIZE_4K;
@@ -913,7 +923,6 @@ void iwlagn_rx_allocate(struct iwl_priv *priv, gfp_t priority)
                list_add_tail(&rxb->list, &rxq->rx_free);
                rxq->free_count++;
-                priv->alloc_rxb_page++;
                spin_unlock_irqrestore(&rxq->lock, flags);
        }
@@ -1285,9 +1294,17 @@ int iwlagn_request_scan(struct iwl_priv *priv, struct ieee80211_vif *vif)
         * mean we never reach it, but at the same time work around
         * the aforementioned issue. Thus use IWL_GOOD_CRC_TH_NEVER
         * here instead of IWL_GOOD_CRC_TH_DISABLED.
+         *
+         * This was fixed in later versions along with some other
+         * scan changes, and the threshold behaves as a flag in those
+         * versions.
         */
-        scan->good_CRC_th = is_active ? IWL_GOOD_CRC_TH_DEFAULT :
+        if (priv->new_scan_threshold_behaviour)
-                                        IWL_GOOD_CRC_TH_NEVER;
+                scan->good_CRC_th = is_active ? IWL_GOOD_CRC_TH_DEFAULT :
+                                                IWL_GOOD_CRC_TH_DISABLED;
+        else
+                scan->good_CRC_th = is_active ? IWL_GOOD_CRC_TH_DEFAULT :
+                                                IWL_GOOD_CRC_TH_NEVER;
        band = priv->scan_band;
@@ -2245,34 +2262,44 @@ int iwl_dump_fh(struct iwl_priv *priv, char **buf, bool display)
 /* notification wait support */
 void iwlagn_init_notification_wait(struct iwl_priv *priv,
                                   struct iwl_notification_wait *wait_entry,
+                                   u8 cmd,
                                   void (*fn)(struct iwl_priv *priv,
-                                              struct iwl_rx_packet *pkt),
+                                              struct iwl_rx_packet *pkt,
-                                   u8 cmd)
+                                              void *data),
+                                   void *fn_data)
 {
        wait_entry->fn = fn;
+        wait_entry->fn_data = fn_data;
        wait_entry->cmd = cmd;
        wait_entry->triggered = false;
+        wait_entry->aborted = false;
        spin_lock_bh(&priv->_agn.notif_wait_lock);
        list_add(&wait_entry->list, &priv->_agn.notif_waits);
        spin_unlock_bh(&priv->_agn.notif_wait_lock);
 }
-signed long iwlagn_wait_notification(struct iwl_priv *priv,
+int iwlagn_wait_notification(struct iwl_priv *priv,
-                                     struct iwl_notification_wait *wait_entry,
+                             struct iwl_notification_wait *wait_entry,
-                                     unsigned long timeout)
+                             unsigned long timeout)
 {
        int ret;
        ret = wait_event_timeout(priv->_agn.notif_waitq,
-                                 wait_entry->triggered,
+                                 wait_entry->triggered || wait_entry->aborted,
                                 timeout);
        spin_lock_bh(&priv->_agn.notif_wait_lock);
        list_del(&wait_entry->list);
        spin_unlock_bh(&priv->_agn.notif_wait_lock);
-        return ret;
+        if (wait_entry->aborted)
+                return -EIO;
+        /* return value is always >= 0 */
+        if (ret <= 0)
+                return -ETIMEDOUT;
+        return 0;
 }
 void iwlagn_remove_notification(struct iwl_priv *priv,
@@ -2282,3 +2309,87 @@ void iwlagn_remove_notification(struct iwl_priv *priv,
        list_del(&wait_entry->list);
        spin_unlock_bh(&priv->_agn.notif_wait_lock);
 }
+int iwlagn_start_device(struct iwl_priv *priv)
+{
+        int ret;
+        if (iwl_prepare_card_hw(priv)) {
+                IWL_WARN(priv, "Exit HW not ready\n");
+                return -EIO;
+        }
+        /* If platform's RF_KILL switch is NOT set to KILL */
+        if (iwl_read32(priv, CSR_GP_CNTRL) & CSR_GP_CNTRL_REG_FLAG_HW_RF_KILL_SW)
+                clear_bit(STATUS_RF_KILL_HW, &priv->status);
+        else
+                set_bit(STATUS_RF_KILL_HW, &priv->status);
+        if (iwl_is_rfkill(priv)) {
+                wiphy_rfkill_set_hw_state(priv->hw->wiphy, true);
+                iwl_enable_interrupts(priv);
+                return -ERFKILL;
+        }
+        iwl_write32(priv, CSR_INT, 0xFFFFFFFF);
+        ret = iwlagn_hw_nic_init(priv);
+        if (ret) {
+                IWL_ERR(priv, "Unable to init nic\n");
+                return ret;
+        }
+        /* make sure rfkill handshake bits are cleared */
+        iwl_write32(priv, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL);
+        iwl_write32(priv, CSR_UCODE_DRV_GP1_CLR,
+                    CSR_UCODE_DRV_GP1_BIT_CMD_BLOCKED);
+        /* clear (again), then enable host interrupts */
+        iwl_write32(priv, CSR_INT, 0xFFFFFFFF);
+        iwl_enable_interrupts(priv);
+        /* really make sure rfkill handshake bits are cleared */
+        iwl_write32(priv, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL);
+        iwl_write32(priv, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL);
+        return 0;
+}
+void iwlagn_stop_device(struct iwl_priv *priv)
+{
+        unsigned long flags;
+        /* stop and reset the on-board processor */
+        iwl_write32(priv, CSR_RESET, CSR_RESET_REG_FLAG_NEVO_RESET);
+        /* tell the device to stop sending interrupts */
+        spin_lock_irqsave(&priv->lock, flags);
+        iwl_disable_interrupts(priv);
+        spin_unlock_irqrestore(&priv->lock, flags);
+        iwl_synchronize_irq(priv);
+        /* device going down, Stop using ICT table */
+        iwl_disable_ict(priv);
+        /*
+         * If a HW restart happens during firmware loading,
+         * then the firmware loading might call this function
+         * and later it might be called again due to the
+         * restart. So don't process again if the device is
+         * already dead.
+         */
+        if (test_bit(STATUS_DEVICE_ENABLED, &priv->status)) {
+                iwlagn_txq_ctx_stop(priv);
+                iwlagn_rxq_stop(priv);
+                /* Power-down device's busmaster DMA clocks */
+                iwl_write_prph(priv, APMG_CLK_DIS_REG, APMG_CLK_VAL_DMA_CLK_RQT);
+                udelay(5);
+        }
+        /* Make sure (redundant) we've released our request to stay awake */
+        iwl_clear_bit(priv, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_MAC_ACCESS_REQ);
+        /* Stop the device, and put it in low power state */
+        iwl_apm_stop(priv);
+}
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
index d03b4734c892..91f26556ac23 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -115,13 +115,18 @@ const struct iwl_rate_info iwl_rates[IWL_RATE_COUNT] = {
        /* FIXME:RS:          ^^    should be INV (legacy) */
 };
+static inline u8 rs_extract_rate(u32 rate_n_flags)
+{
+        return (u8)(rate_n_flags & RATE_MCS_RATE_MSK);
+}
 static int iwl_hwrate_to_plcp_idx(u32 rate_n_flags)
 {
        int idx = 0;
        /* HT rate format */
        if (rate_n_flags & RATE_MCS_HT_MSK) {
-                idx = (rate_n_flags & 0xff);
+                idx = rs_extract_rate(rate_n_flags);
                if (idx >= IWL_RATE_MIMO3_6M_PLCP)
                        idx = idx - IWL_RATE_MIMO3_6M_PLCP;
@@ -138,7 +143,8 @@ static int iwl_hwrate_to_plcp_idx(u32 rate_n_flags)
        /* legacy rate format, search for match in table */
        } else {
                for (idx = 0; idx < ARRAY_SIZE(iwl_rates); idx++)
-                        if (iwl_rates[idx].plcp == (rate_n_flags & 0xFF))
+                        if (iwl_rates[idx].plcp ==
+                                        rs_extract_rate(rate_n_flags))
                                return idx;
        }
@@ -239,11 +245,6 @@ static const struct iwl_rate_mcs_info iwl_rate_mcs[IWL_RATE_COUNT] = {
 #define MCS_INDEX_PER_STREAM    (8)
-static inline u8 rs_extract_rate(u32 rate_n_flags)
-{
-        return (u8)(rate_n_flags & 0xFF);
-}
 static void rs_rate_scale_clear_window(struct iwl_rate_scale_data *window)
 {
        window->data = 0;
@@ -2770,16 +2771,13 @@ static void rs_get_rate(void *priv_r, struct ieee80211_sta *sta, void *priv_sta,
 static void *rs_alloc_sta(void *priv_rate, struct ieee80211_sta *sta,
                          gfp_t gfp)
 {
-        struct iwl_lq_sta *lq_sta;
        struct iwl_station_priv *sta_priv = (struct iwl_station_priv *) sta->drv_priv;
        struct iwl_priv *priv;
        priv = (struct iwl_priv *)priv_rate;
        IWL_DEBUG_RATE(priv, "create station rate scale window\n");
-        lq_sta = &sta_priv->lq_sta;
+        return &sta_priv->lq_sta;
-        return lq_sta;
 }
 /*
@@ -2912,7 +2910,8 @@ static void rs_fill_link_cmd(struct iwl_priv *priv,
                ant_toggle_cnt = 1;
                repeat_rate = IWL_NUMBER_TRY;
        } else {
-                repeat_rate = IWL_HT_NUMBER_TRY;
+                repeat_rate = min(IWL_HT_NUMBER_TRY,
+                                  LINK_QUAL_AGG_DISABLE_START_DEF - 1);
        }
        lq_cmd->general_params.mimo_delimiter =
@@ -3087,7 +3086,7 @@ static ssize_t rs_sta_dbgfs_scale_table_write(struct file *file,
        struct iwl_lq_sta *lq_sta = file->private_data;
        struct iwl_priv *priv;
        char buf[64];
-        int buf_size;
+        size_t buf_size;
        u32 parsed_rate;
        struct iwl_station_priv *sta_priv =
                container_of(lq_sta, struct iwl_station_priv, lq_sta);
@@ -3257,7 +3256,6 @@ static ssize_t rs_sta_dbgfs_rate_scale_data_read(struct file *file,
 {
        char buff[120];
        int desc = 0;
-        ssize_t ret;
        struct iwl_lq_sta *lq_sta = file->private_data;
        struct iwl_priv *priv;
@@ -3274,8 +3272,7 @@ static ssize_t rs_sta_dbgfs_rate_scale_data_read(struct file *file,
                                "Bit Rate= %d Mb/s\n",
                                iwl_rates[lq_sta->last_txrate_idx].ieee >> 1);
-        ret = simple_read_from_buffer(user_buf, count, ppos, buff, desc);
+        return simple_read_from_buffer(user_buf, count, ppos, buff, desc);
-        return ret;
 }
 static const struct file_operations rs_sta_dbgfs_rate_scale_data_ops = {
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rs.h b/drivers/net/wireless/iwlwifi/iwl-agn-rs.h
index 184828c72b31..bdae82e7fa90 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.h
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -41,20 +41,6 @@ struct iwl_rate_info {
        u8 next_rs_tgg;  /* next rate used in TGG rs algo */
 };
-struct iwl3945_rate_info {
-        u8 plcp;                /* uCode API:  IWL_RATE_6M_PLCP, etc. */
-        u8 ieee;                /* MAC header:  IWL_RATE_6M_IEEE, etc. */
-        u8 prev_ieee;           /* previous rate in IEEE speeds */
-        u8 next_ieee;           /* next rate in IEEE speeds */
-        u8 prev_rs;             /* previous rate used in rs algo */
-        u8 next_rs;             /* next rate used in rs algo */
-        u8 prev_rs_tgg;         /* previous rate used in TGG rs algo */
-        u8 next_rs_tgg;         /* next rate used in TGG rs algo */
-        u8 table_rs_index;      /* index in rate scale table cmd */
-        u8 prev_table_rs;       /* prev in rate table cmd */
-};
 /*
 * These serve as indexes into
 * struct iwl_rate_info iwl_rates[IWL_RATE_COUNT];
@@ -75,7 +61,6 @@ enum {
        IWL_RATE_60M_INDEX,
        IWL_RATE_COUNT, /*FIXME:RS:change to IWL_RATE_INDEX_COUNT,*/
        IWL_RATE_COUNT_LEGACY = IWL_RATE_COUNT - 1,     /* Excluding 60M */
-        IWL_RATE_COUNT_3945 = IWL_RATE_COUNT - 1,
        IWL_RATE_INVM_INDEX = IWL_RATE_COUNT,
        IWL_RATE_INVALID = IWL_RATE_COUNT,
 };
@@ -98,7 +83,6 @@ enum {
 enum {
        IWL_FIRST_OFDM_RATE = IWL_RATE_6M_INDEX,
-        IWL39_LAST_OFDM_RATE = IWL_RATE_54M_INDEX,
        IWL_LAST_OFDM_RATE = IWL_RATE_60M_INDEX,
        IWL_FIRST_CCK_RATE = IWL_RATE_1M_INDEX,
        IWL_LAST_CCK_RATE = IWL_RATE_11M_INDEX,
@@ -213,7 +197,6 @@ enum {
         IWL_CCK_BASIC_RATES_MASK)
 #define IWL_RATES_MASK ((1 << IWL_RATE_COUNT) - 1)
-#define IWL_RATES_MASK_3945 ((1 << IWL_RATE_COUNT_3945) - 1)
 #define IWL_INVALID_VALUE    -1
@@ -453,19 +436,9 @@ static inline u8 first_antenna(u8 mask)
 }
-/**
- * iwl3945_rate_scale_init - Initialize the rate scale table based on assoc info
- *
- * The specific throughput table used is based on the type of network
- * the associated with, including A, B, G, and G w/ TGG protection
- */
-extern void iwl3945_rate_scale_init(struct ieee80211_hw *hw, s32 sta_id);
 /* Initialize station's rate scaling information after adding station */
 extern void iwl_rs_rate_init(struct iwl_priv *priv,
                             struct ieee80211_sta *sta, u8 sta_id);
-extern void iwl3945_rs_rate_init(struct iwl_priv *priv,
-                                 struct ieee80211_sta *sta, u8 sta_id);
 /**
 * iwl_rate_control_register - Register the rate control algorithm callbacks
@@ -478,7 +451,6 @@ extern void iwl3945_rs_rate_init(struct iwl_priv *priv,
 *
 */
 extern int iwlagn_rate_control_register(void);
-extern int iwl3945_rate_control_register(void);
 /**
 * iwl_rate_control_unregister - Unregister the rate control callbacks
@@ -487,6 +459,5 @@ extern int iwl3945_rate_control_register(void);
 * the driver is unloaded.
 */
 extern void iwlagn_rate_control_unregister(void);
-extern void iwl3945_rate_control_unregister(void);
 #endif /* __iwl_agn__rs__ */
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c b/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
index fbbde0712fa5..02387430f7fe 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -29,6 +29,7 @@
 #include "iwl-sta.h"
 #include "iwl-core.h"
 #include "iwl-agn-calib.h"
+#include "iwl-helpers.h"
 static int iwlagn_disable_bss(struct iwl_priv *priv,
                              struct iwl_rxon_context *ctx,
@@ -57,8 +58,9 @@ static int iwlagn_disable_pan(struct iwl_priv *priv,
        u8 old_dev_type = send->dev_type;
        int ret;
-        iwlagn_init_notification_wait(priv, &disable_wait, NULL,
+        iwlagn_init_notification_wait(priv, &disable_wait,
-                                      REPLY_WIPAN_DEACTIVATION_COMPLETE);
+                                      REPLY_WIPAN_DEACTIVATION_COMPLETE,
+                                      NULL, NULL);
        send->filter_flags &= ~RXON_FILTER_ASSOC_MSK;
        send->dev_type = RXON_DEV_TYPE_P2P;
@@ -71,13 +73,9 @@ static int iwlagn_disable_pan(struct iwl_priv *priv,
                IWL_ERR(priv, "Error disabling PAN (%d)\n", ret);
                iwlagn_remove_notification(priv, &disable_wait);
        } else {
-                signed long wait_res;
+                ret = iwlagn_wait_notification(priv, &disable_wait, HZ);
+                if (ret)
-                wait_res = iwlagn_wait_notification(priv, &disable_wait, HZ);
-                if (wait_res == 0) {
                        IWL_ERR(priv, "Timed out waiting for PAN disable\n");
-                        ret = -EIO;
-                }
        }
        return ret;
@@ -123,6 +121,151 @@ static int iwlagn_update_beacon(struct iwl_priv *priv,
        return iwlagn_send_beacon_cmd(priv);
 }
+static int iwlagn_send_rxon_assoc(struct iwl_priv *priv,
+                           struct iwl_rxon_context *ctx)
+{
+        int ret = 0;
+        struct iwl_rxon_assoc_cmd rxon_assoc;
+        const struct iwl_rxon_cmd *rxon1 = &ctx->staging;
+        const struct iwl_rxon_cmd *rxon2 = &ctx->active;
+        if ((rxon1->flags == rxon2->flags) &&
+            (rxon1->filter_flags == rxon2->filter_flags) &&
+            (rxon1->cck_basic_rates == rxon2->cck_basic_rates) &&
+            (rxon1->ofdm_ht_single_stream_basic_rates ==
+             rxon2->ofdm_ht_single_stream_basic_rates) &&
+            (rxon1->ofdm_ht_dual_stream_basic_rates ==
+             rxon2->ofdm_ht_dual_stream_basic_rates) &&
+            (rxon1->ofdm_ht_triple_stream_basic_rates ==
+             rxon2->ofdm_ht_triple_stream_basic_rates) &&
+            (rxon1->acquisition_data == rxon2->acquisition_data) &&
+            (rxon1->rx_chain == rxon2->rx_chain) &&
+            (rxon1->ofdm_basic_rates == rxon2->ofdm_basic_rates)) {
+                IWL_DEBUG_INFO(priv, "Using current RXON_ASSOC.  Not resending.\n");
+                return 0;
+        }
+        rxon_assoc.flags = ctx->staging.flags;
+        rxon_assoc.filter_flags = ctx->staging.filter_flags;
+        rxon_assoc.ofdm_basic_rates = ctx->staging.ofdm_basic_rates;
+        rxon_assoc.cck_basic_rates = ctx->staging.cck_basic_rates;
+        rxon_assoc.reserved1 = 0;
+        rxon_assoc.reserved2 = 0;
+        rxon_assoc.reserved3 = 0;
+        rxon_assoc.ofdm_ht_single_stream_basic_rates =
+            ctx->staging.ofdm_ht_single_stream_basic_rates;
+        rxon_assoc.ofdm_ht_dual_stream_basic_rates =
+            ctx->staging.ofdm_ht_dual_stream_basic_rates;
+        rxon_assoc.rx_chain_select_flags = ctx->staging.rx_chain;
+        rxon_assoc.ofdm_ht_triple_stream_basic_rates =
+                 ctx->staging.ofdm_ht_triple_stream_basic_rates;
+        rxon_assoc.acquisition_data = ctx->staging.acquisition_data;
+        ret = iwl_send_cmd_pdu_async(priv, ctx->rxon_assoc_cmd,
+                                     sizeof(rxon_assoc), &rxon_assoc, NULL);
+        if (ret)
+                return ret;
+        return ret;
+}
+static int iwlagn_rxon_disconn(struct iwl_priv *priv,
+                               struct iwl_rxon_context *ctx)
+{
+        int ret;
+        struct iwl_rxon_cmd *active = (void *)&ctx->active;
+        if (ctx->ctxid == IWL_RXON_CTX_BSS)
+                ret = iwlagn_disable_bss(priv, ctx, &ctx->staging);
+        else
+                ret = iwlagn_disable_pan(priv, ctx, &ctx->staging);
+        if (ret)
+                return ret;
+        /*
+         * Un-assoc RXON clears the station table and WEP
+         * keys, so we have to restore those afterwards.
+         */
+        iwl_clear_ucode_stations(priv, ctx);
+        iwl_restore_stations(priv, ctx);
+        ret = iwl_restore_default_wep_keys(priv, ctx);
+        if (ret) {
+                IWL_ERR(priv, "Failed to restore WEP keys (%d)\n", ret);
+                return ret;
+        }
+        memcpy(active, &ctx->staging, sizeof(*active));
+        return 0;
+}
+static int iwlagn_rxon_connect(struct iwl_priv *priv,
+                               struct iwl_rxon_context *ctx)
+{
+        int ret;
+        struct iwl_rxon_cmd *active = (void *)&ctx->active;
+        /* RXON timing must be before associated RXON */
+        ret = iwl_send_rxon_timing(priv, ctx);
+        if (ret) {
+                IWL_ERR(priv, "Failed to send timing (%d)!\n", ret);
+                return ret;
+        }
+        /* QoS info may be cleared by previous un-assoc RXON */
+        iwlagn_update_qos(priv, ctx);
+        /*
+         * We'll run into this code path when beaconing is
+         * enabled, but then we also need to send the beacon
+         * to the device.
+         */
+        if (ctx->vif && (ctx->vif->type == NL80211_IFTYPE_AP)) {
+                ret = iwlagn_update_beacon(priv, ctx->vif);
+                if (ret) {
+                        IWL_ERR(priv,
+                                "Error sending required beacon (%d)!\n",
+                                ret);
+                        return ret;
+                }
+        }
+        priv->start_calib = 0;
+        /*
+         * Apply the new configuration.
+         *
+         * Associated RXON doesn't clear the station table in uCode,
+         * so we don't need to restore stations etc. after this.
+         */
+        ret = iwl_send_cmd_pdu(priv, ctx->rxon_cmd,
+                      sizeof(struct iwl_rxon_cmd), &ctx->staging);
+        if (ret) {
+                IWL_ERR(priv, "Error setting new RXON (%d)\n", ret);
+                return ret;
+        }
+        memcpy(active, &ctx->staging, sizeof(*active));
+        iwl_reprogram_ap_sta(priv, ctx);
+        /* IBSS beacon needs to be sent after setting assoc */
+        if (ctx->vif && (ctx->vif->type == NL80211_IFTYPE_ADHOC))
+                if (iwlagn_update_beacon(priv, ctx->vif))
+                        IWL_ERR(priv, "Error sending IBSS beacon\n");
+        iwl_init_sensitivity(priv);
+        /*
+         * If we issue a new RXON command which required a tune then
+         * we must send a new TXPOWER command or we won't be able to
+         * Tx any frames.
+         *
+         * It's expected we set power here if channel is changing.
+         */
+        ret = iwl_set_tx_power(priv, priv->tx_power_next, true);
+        if (ret) {
+                IWL_ERR(priv, "Error sending TX power (%d)\n", ret);
+                return ret;
+        }
+        return 0;
+}
 /**
 * iwlagn_commit_rxon - commit staging_rxon to hardware
 *
@@ -130,6 +273,16 @@ static int iwlagn_update_beacon(struct iwl_priv *priv,
 * the active_rxon structure is updated with the new data.  This
 * function correctly transitions out of the RXON_ASSOC_MSK state if
 * a HW tune is required based on the RXON structure changes.
+ *
+ * The connect/disconnect flow should be as the following:
+ *
+ * 1. make sure send RXON command with association bit unset if not connect
+ *      this should include the channel and the band for the candidate
+ *      to be connected to
+ * 2. Add Station before RXON association with the AP
+ * 3. RXON_timing has to send before RXON for connection
+ * 4. full RXON command - associated bit set
+ * 5. use RXON_ASSOC command to update any flags changes
 */
 int iwlagn_commit_rxon(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
 {
@@ -179,6 +332,7 @@ int iwlagn_commit_rxon(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
        else
                ctx->staging.flags &= ~RXON_FLG_SHORT_SLOT_MSK;
+        iwl_print_rx_config_cmd(priv, ctx);
        ret = iwl_check_rxon_cmd(priv, ctx);
        if (ret) {
                IWL_ERR(priv, "Invalid RXON configuration. Not committing.\n");
@@ -202,14 +356,13 @@ int iwlagn_commit_rxon(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
         * and other flags for the current radio configuration.
         */
        if (!iwl_full_rxon_required(priv, ctx)) {
-                ret = iwl_send_rxon_assoc(priv, ctx);
+                ret = iwlagn_send_rxon_assoc(priv, ctx);
                if (ret) {
                        IWL_ERR(priv, "Error setting RXON_ASSOC (%d)\n", ret);
                        return ret;
                }
                memcpy(active, &ctx->staging, sizeof(*active));
-                iwl_print_rx_config_cmd(priv, ctx);
                return 0;
        }
@@ -219,7 +372,7 @@ int iwlagn_commit_rxon(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
                        return ret;
        }
-        iwl_set_rxon_hwcrypto(priv, ctx, !priv->cfg->mod_params->sw_crypto);
+        iwl_set_rxon_hwcrypto(priv, ctx, !iwlagn_mod_params.sw_crypto);
        IWL_DEBUG_INFO(priv,
                       "Going to commit RXON\n"
@@ -237,92 +390,13 @@ int iwlagn_commit_rxon(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
         * set up filters in the device.
         */
        if ((old_assoc && new_assoc) || !new_assoc) {
-                if (ctx->ctxid == IWL_RXON_CTX_BSS)
+                ret = iwlagn_rxon_disconn(priv, ctx);
-                        ret = iwlagn_disable_bss(priv, ctx, &ctx->staging);
-                else
-                        ret = iwlagn_disable_pan(priv, ctx, &ctx->staging);
                if (ret)
                        return ret;
-                memcpy(active, &ctx->staging, sizeof(*active));
-                /*
-                 * Un-assoc RXON clears the station table and WEP
-                 * keys, so we have to restore those afterwards.
-                 */
-                iwl_clear_ucode_stations(priv, ctx);
-                iwl_restore_stations(priv, ctx);
-                ret = iwl_restore_default_wep_keys(priv, ctx);
-                if (ret) {
-                        IWL_ERR(priv, "Failed to restore WEP keys (%d)\n", ret);
-                        return ret;
-                }
-        }
-        /* RXON timing must be before associated RXON */
-        ret = iwl_send_rxon_timing(priv, ctx);
-        if (ret) {
-                IWL_ERR(priv, "Failed to send timing (%d)!\n", ret);
-                return ret;
-        }
-        if (new_assoc) {
-                /* QoS info may be cleared by previous un-assoc RXON */
-                iwlagn_update_qos(priv, ctx);
-                /*
-                 * We'll run into this code path when beaconing is
-                 * enabled, but then we also need to send the beacon
-                 * to the device.
-                 */
-                if (ctx->vif && (ctx->vif->type == NL80211_IFTYPE_AP)) {
-                        ret = iwlagn_update_beacon(priv, ctx->vif);
-                        if (ret) {
-                                IWL_ERR(priv,
-                                        "Error sending required beacon (%d)!\n",
-                                        ret);
-                                return ret;
-                        }
-                }
-                priv->start_calib = 0;
-                /*
-                 * Apply the new configuration.
-                 *
-                 * Associated RXON doesn't clear the station table in uCode,
-                 * so we don't need to restore stations etc. after this.
-                 */
-                ret = iwl_send_cmd_pdu(priv, ctx->rxon_cmd,
-                              sizeof(struct iwl_rxon_cmd), &ctx->staging);
-                if (ret) {
-                        IWL_ERR(priv, "Error setting new RXON (%d)\n", ret);
-                        return ret;
-                }
-                memcpy(active, &ctx->staging, sizeof(*active));
-                iwl_reprogram_ap_sta(priv, ctx);
-                /* IBSS beacon needs to be sent after setting assoc */
-                if (ctx->vif && (ctx->vif->type == NL80211_IFTYPE_ADHOC))
-                        if (iwlagn_update_beacon(priv, ctx->vif))
-                                IWL_ERR(priv, "Error sending IBSS beacon\n");
        }
-        iwl_print_rx_config_cmd(priv, ctx);
+        if (new_assoc)
+                return iwlagn_rxon_connect(priv, ctx);
-        iwl_init_sensitivity(priv);
-        /*
-         * If we issue a new RXON command which required a tune then we must
-         * send a new TXPOWER command or we won't be able to Tx any frames.
-         *
-         * It's expected we set power here if channel is changing.
-         */
-        ret = iwl_set_tx_power(priv, priv->tx_power_next, true);
-        if (ret) {
-                IWL_ERR(priv, "Error sending TX power (%d)\n", ret);
-                return ret;
-        }
        return 0;
 }
@@ -595,6 +669,18 @@ void iwlagn_bss_info_changed(struct ieee80211_hw *hw,
                        priv->timestamp = bss_conf->timestamp;
                        ctx->staging.filter_flags |= RXON_FILTER_ASSOC_MSK;
                } else {
+                        /*
+                         * If we disassociate while there are pending
+                         * frames, just wake up the queues and let the
+                         * frames "escape" ... This shouldn't really
+                         * be happening to start with, but we should
+                         * not get stuck in this case either since it
+                         * can happen if userspace gets confused.
+                         */
+                        if (ctx->last_tx_rejected) {
+                                ctx->last_tx_rejected = false;
+                                iwl_wake_any_queue(priv, ctx);
+                        }
                        ctx->staging.filter_flags &= ~RXON_FILTER_ASSOC_MSK;
                }
        }
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-sta.c b/drivers/net/wireless/iwlwifi/iwl-agn-sta.c
index 35f085ac336b..079275f2c64d 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-sta.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-sta.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
@@ -474,7 +474,7 @@ int iwl_remove_dynamic_key(struct iwl_priv *priv,
        memset(&priv->stations[sta_id].keyinfo, 0,
                                        sizeof(struct iwl_hw_key));
        memset(&priv->stations[sta_id].sta.key, 0,
-                                        sizeof(struct iwl4965_keyinfo));
+                                        sizeof(struct iwl_keyinfo));
        priv->stations[sta_id].sta.key.key_flags =
                        STA_KEY_FLG_NO_ENC | STA_KEY_FLG_INVALID;
        priv->stations[sta_id].sta.key.key_offset = WEP_INVALID_OFFSET;
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-tt.c b/drivers/net/wireless/iwlwifi/iwl-agn-tt.c
index e3a8216a033c..348f74f1c8e8 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-tt.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-tt.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2007 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2007 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-tt.h b/drivers/net/wireless/iwlwifi/iwl-agn-tt.h
index d55060427cac..d118ed29bf3f 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-tt.h
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-tt.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2007 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2007 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-tx.c b/drivers/net/wireless/iwlwifi/iwl-agn-tx.c
index 0712b67283a4..342de780a366 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-tx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-tx.c
@@ -2,7 +2,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -98,9 +98,9 @@ static inline int get_fifo_from_tid(struct iwl_rxon_context *ctx, u16 tid)
 /**
 * iwlagn_txq_update_byte_cnt_tbl - Set up entry in Tx byte-count array
 */
-void iwlagn_txq_update_byte_cnt_tbl(struct iwl_priv *priv,
+static void iwlagn_txq_update_byte_cnt_tbl(struct iwl_priv *priv,
-                                            struct iwl_tx_queue *txq,
+                                           struct iwl_tx_queue *txq,
-                                            u16 byte_cnt)
+                                           u16 byte_cnt)
 {
        struct iwlagn_scd_bc_tbl *scd_bc_tbl = priv->scd_bc_tbls.addr;
        int write_ptr = txq->q.write_ptr;
@@ -112,21 +112,19 @@ void iwlagn_txq_update_byte_cnt_tbl(struct iwl_priv *priv,
        WARN_ON(len > 0xFFF || write_ptr >= TFD_QUEUE_SIZE_MAX);
-        if (txq_id != priv->cmd_queue) {
+        sta_id = txq->cmd[txq->q.write_ptr]->cmd.tx.sta_id;
-                sta_id = txq->cmd[txq->q.write_ptr]->cmd.tx.sta_id;
+        sec_ctl = txq->cmd[txq->q.write_ptr]->cmd.tx.sec_ctl;
-                sec_ctl = txq->cmd[txq->q.write_ptr]->cmd.tx.sec_ctl;
+        switch (sec_ctl & TX_CMD_SEC_MSK) {
-                switch (sec_ctl & TX_CMD_SEC_MSK) {
+        case TX_CMD_SEC_CCM:
-                case TX_CMD_SEC_CCM:
+                len += CCMP_MIC_LEN;
-                        len += CCMP_MIC_LEN;
+                break;
-                        break;
+        case TX_CMD_SEC_TKIP:
-                case TX_CMD_SEC_TKIP:
+                len += TKIP_ICV_LEN;
-                        len += TKIP_ICV_LEN;
+                break;
-                        break;
+        case TX_CMD_SEC_WEP:
-                case TX_CMD_SEC_WEP:
+                len += WEP_IV_LEN + WEP_ICV_LEN;
-                        len += WEP_IV_LEN + WEP_ICV_LEN;
+                break;
-                        break;
-                }
        }
        bc_ent = cpu_to_le16((len & 0xFFF) | (sta_id << 12));
@@ -138,8 +136,8 @@ void iwlagn_txq_update_byte_cnt_tbl(struct iwl_priv *priv,
                        tfd_offset[TFD_QUEUE_SIZE_MAX + write_ptr] = bc_ent;
 }
-void iwlagn_txq_inval_byte_cnt_tbl(struct iwl_priv *priv,
+static void iwlagn_txq_inval_byte_cnt_tbl(struct iwl_priv *priv,
-                                           struct iwl_tx_queue *txq)
+                                          struct iwl_tx_queue *txq)
 {
        struct iwlagn_scd_bc_tbl *scd_bc_tbl = priv->scd_bc_tbls.addr;
        int txq_id = txq->q.id;
@@ -222,13 +220,8 @@ void iwlagn_tx_queue_set_status(struct iwl_priv *priv,
                       scd_retry ? "BA" : "AC/CMD", txq_id, tx_fifo_id);
 }
-int iwlagn_txq_agg_enable(struct iwl_priv *priv, int txq_id,
+static int iwlagn_txq_agg_enable(struct iwl_priv *priv, int txq_id, int sta_id, int tid)
-                          int tx_fifo, int sta_id, int tid, u16 ssn_idx)
 {
-        unsigned long flags;
-        u16 ra_tid;
-        int ret;
        if ((IWLAGN_FIRST_AMPDU_QUEUE > txq_id) ||
            (IWLAGN_FIRST_AMPDU_QUEUE +
                priv->cfg->base_params->num_of_ampdu_queues <= txq_id)) {
@@ -240,12 +233,33 @@ int iwlagn_txq_agg_enable(struct iwl_priv *priv, int txq_id,
                return -EINVAL;
        }
-        ra_tid = BUILD_RAxTID(sta_id, tid);
        /* Modify device's station table to Tx this TID */
-        ret = iwl_sta_tx_modify_enable_tid(priv, sta_id, tid);
+        return iwl_sta_tx_modify_enable_tid(priv, sta_id, tid);
-        if (ret)
+}
-                return ret;
+void iwlagn_txq_agg_queue_setup(struct iwl_priv *priv,
+                                struct ieee80211_sta *sta,
+                                int tid, int frame_limit)
+{
+        int sta_id, tx_fifo, txq_id, ssn_idx;
+        u16 ra_tid;
+        unsigned long flags;
+        struct iwl_tid_data *tid_data;
+        sta_id = iwl_sta_id(sta);
+        if (WARN_ON(sta_id == IWL_INVALID_STATION))
+                return;
+        if (WARN_ON(tid >= MAX_TID_COUNT))
+                return;
+        spin_lock_irqsave(&priv->sta_lock, flags);
+        tid_data = &priv->stations[sta_id].tid[tid];
+        ssn_idx = SEQ_TO_SN(tid_data->seq_number);
+        txq_id = tid_data->agg.txq_id;
+        tx_fifo = tid_data->agg.tx_fifo;
+        spin_unlock_irqrestore(&priv->sta_lock, flags);
+        ra_tid = BUILD_RAxTID(sta_id, tid);
        spin_lock_irqsave(&priv->lock, flags);
@@ -271,10 +285,10 @@ int iwlagn_txq_agg_enable(struct iwl_priv *priv, int txq_id,
        iwl_write_targ_mem(priv, priv->scd_base_addr +
                        IWLAGN_SCD_CONTEXT_QUEUE_OFFSET(txq_id) +
                        sizeof(u32),
-                        ((SCD_WIN_SIZE <<
+                        ((frame_limit <<
                        IWLAGN_SCD_QUEUE_CTX_REG2_WIN_SIZE_POS) &
                        IWLAGN_SCD_QUEUE_CTX_REG2_WIN_SIZE_MSK) |
-                        ((SCD_FRAME_LIMIT <<
+                        ((frame_limit <<
                        IWLAGN_SCD_QUEUE_CTX_REG2_FRAME_LIMIT_POS) &
                        IWLAGN_SCD_QUEUE_CTX_REG2_FRAME_LIMIT_MSK));
@@ -284,12 +298,10 @@ int iwlagn_txq_agg_enable(struct iwl_priv *priv, int txq_id,
        iwlagn_tx_queue_set_status(priv, &priv->txq[txq_id], tx_fifo, 1);
        spin_unlock_irqrestore(&priv->lock, flags);
-        return 0;
 }
-int iwlagn_txq_agg_disable(struct iwl_priv *priv, u16 txq_id,
+static int iwlagn_txq_agg_disable(struct iwl_priv *priv, u16 txq_id,
-                           u16 ssn_idx, u8 tx_fifo)
+                                  u16 ssn_idx, u8 tx_fifo)
 {
        if ((IWLAGN_FIRST_AMPDU_QUEUE > txq_id) ||
            (IWLAGN_FIRST_AMPDU_QUEUE +
@@ -525,7 +537,7 @@ int iwlagn_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
        struct iwl_tx_cmd *tx_cmd;
        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_BSS];
        int txq_id;
-        dma_addr_t phys_addr;
+        dma_addr_t phys_addr = 0;
        dma_addr_t txcmd_phys;
        dma_addr_t scratch_phys;
        u16 len, firstlen, secondlen;
@@ -552,7 +564,7 @@ int iwlagn_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
        spin_lock_irqsave(&priv->lock, flags);
        if (iwl_is_rfkill(priv)) {
                IWL_DEBUG_DROP(priv, "Dropping - RF KILL\n");
-                goto drop_unlock;
+                goto drop_unlock_priv;
        }
        fc = hdr->frame_control;
@@ -577,7 +589,7 @@ int iwlagn_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
                if (sta_id == IWL_INVALID_STATION) {
                        IWL_DEBUG_DROP(priv, "Dropping - INVALID STATION: %pM\n",
                                       hdr->addr1);
-                        goto drop_unlock;
+                        goto drop_unlock_priv;
                }
        }
@@ -621,10 +633,10 @@ int iwlagn_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
        if (ieee80211_is_data_qos(fc)) {
                qc = ieee80211_get_qos_ctl(hdr);
                tid = qc[0] & IEEE80211_QOS_CTL_TID_MASK;
-                if (WARN_ON_ONCE(tid >= MAX_TID_COUNT)) {
-                        spin_unlock(&priv->sta_lock);
+                if (WARN_ON_ONCE(tid >= MAX_TID_COUNT))
-                        goto drop_unlock;
+                        goto drop_unlock_sta;
-                }
                seq_number = priv->stations[sta_id].tid[tid].seq_number;
                seq_number &= IEEE80211_SCTL_SEQ;
                hdr->seq_ctrl = hdr->seq_ctrl &
@@ -642,18 +654,8 @@ int iwlagn_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
        txq = &priv->txq[txq_id];
        q = &txq->q;
-        if (unlikely(iwl_queue_space(q) < q->high_mark)) {
+        if (unlikely(iwl_queue_space(q) < q->high_mark))
-                spin_unlock(&priv->sta_lock);
+                goto drop_unlock_sta;
-                goto drop_unlock;
-        }
-        if (ieee80211_is_data_qos(fc)) {
-                priv->stations[sta_id].tid[tid].tfds_in_queue++;
-                if (!ieee80211_has_morefrags(fc))
-                        priv->stations[sta_id].tid[tid].seq_number = seq_number;
-        }
-        spin_unlock(&priv->sta_lock);
        /* Set up driver data for this TFD */
        memset(&(txq->txb[q->write_ptr]), 0, sizeof(struct iwl_tx_info));
@@ -717,12 +719,10 @@ int iwlagn_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
        txcmd_phys = pci_map_single(priv->pci_dev,
                                    &out_cmd->hdr, firstlen,
                                    PCI_DMA_BIDIRECTIONAL);
+        if (unlikely(pci_dma_mapping_error(priv->pci_dev, txcmd_phys)))
+                goto drop_unlock_sta;
        dma_unmap_addr_set(out_meta, mapping, txcmd_phys);
        dma_unmap_len_set(out_meta, len, firstlen);
-        /* Add buffer containing Tx command and MAC(!) header to TFD's
-         * first entry */
-        priv->cfg->ops->lib->txq_attach_buf_to_tfd(priv, txq,
-                                                   txcmd_phys, firstlen, 1, 0);
        if (!ieee80211_has_morefrags(hdr->frame_control)) {
                txq->need_update = 1;
@@ -737,10 +737,30 @@ int iwlagn_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
        if (secondlen > 0) {
                phys_addr = pci_map_single(priv->pci_dev, skb->data + hdr_len,
                                           secondlen, PCI_DMA_TODEVICE);
+                if (unlikely(pci_dma_mapping_error(priv->pci_dev, phys_addr))) {
+                        pci_unmap_single(priv->pci_dev,
+                                         dma_unmap_addr(out_meta, mapping),
+                                         dma_unmap_len(out_meta, len),
+                                         PCI_DMA_BIDIRECTIONAL);
+                        goto drop_unlock_sta;
+                }
+        }
+        if (ieee80211_is_data_qos(fc)) {
+                priv->stations[sta_id].tid[tid].tfds_in_queue++;
+                if (!ieee80211_has_morefrags(fc))
+                        priv->stations[sta_id].tid[tid].seq_number = seq_number;
+        }
+        spin_unlock(&priv->sta_lock);
+        /* Attach buffers to TFD */
+        priv->cfg->ops->lib->txq_attach_buf_to_tfd(priv, txq,
+                                                   txcmd_phys, firstlen, 1, 0);
+        if (secondlen > 0)
                priv->cfg->ops->lib->txq_attach_buf_to_tfd(priv, txq,
                                                           phys_addr, secondlen,
                                                           0, 0);
-        }
        scratch_phys = txcmd_phys + sizeof(struct iwl_cmd_header) +
                                offsetof(struct iwl_tx_cmd, scratch);
@@ -759,8 +779,8 @@ int iwlagn_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
        /* Set up entry for this TFD in Tx byte-count array */
        if (info->flags & IEEE80211_TX_CTL_AMPDU)
-                priv->cfg->ops->lib->txq_update_byte_cnt_tbl(priv, txq,
+                iwlagn_txq_update_byte_cnt_tbl(priv, txq,
-                                                     le16_to_cpu(tx_cmd->len));
+                                               le16_to_cpu(tx_cmd->len));
        pci_dma_sync_single_for_device(priv->pci_dev, txcmd_phys,
                                       firstlen, PCI_DMA_BIDIRECTIONAL);
@@ -806,7 +826,9 @@ int iwlagn_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
        return 0;
-drop_unlock:
+drop_unlock_sta:
+        spin_unlock(&priv->sta_lock);
+drop_unlock_priv:
        spin_unlock_irqrestore(&priv->lock, flags);
        return -1;
 }
@@ -1039,11 +1061,11 @@ int iwlagn_tx_agg_start(struct iwl_priv *priv, struct ieee80211_vif *vif,
        tid_data = &priv->stations[sta_id].tid[tid];
        *ssn = SEQ_TO_SN(tid_data->seq_number);
        tid_data->agg.txq_id = txq_id;
+        tid_data->agg.tx_fifo = tx_fifo;
        iwl_set_swq_id(&priv->txq[txq_id], get_ac_from_tid(tid), txq_id);
        spin_unlock_irqrestore(&priv->sta_lock, flags);
-        ret = priv->cfg->ops->lib->txq_agg_enable(priv, txq_id, tx_fifo,
+        ret = iwlagn_txq_agg_enable(priv, txq_id, sta_id, tid);
-                                                  sta_id, tid, *ssn);
        if (ret)
                return ret;
@@ -1130,8 +1152,7 @@ int iwlagn_tx_agg_stop(struct iwl_priv *priv, struct ieee80211_vif *vif,
         * to deactivate the uCode queue, just return "success" to allow
         *  mac80211 to clean up it own data.
         */
-        priv->cfg->ops->lib->txq_agg_disable(priv, txq_id, ssn,
+        iwlagn_txq_agg_disable(priv, txq_id, ssn, tx_fifo_id);
-                                                   tx_fifo_id);
        spin_unlock_irqrestore(&priv->lock, flags);
        ieee80211_stop_tx_ba_cb_irqsafe(vif, sta->addr, tid);
@@ -1160,8 +1181,7 @@ int iwlagn_txq_check_empty(struct iwl_priv *priv,
                        u16 ssn = SEQ_TO_SN(tid_data->seq_number);
                        int tx_fifo = get_fifo_from_tid(ctx, tid);
                        IWL_DEBUG_HT(priv, "HW queue empty: continue DELBA flow\n");
-                        priv->cfg->ops->lib->txq_agg_disable(priv, txq_id,
+                        iwlagn_txq_agg_disable(priv, txq_id, ssn, tx_fifo);
-                                                             ssn, tx_fifo);
                        tid_data->agg.state = IWL_AGG_OFF;
                        ieee80211_stop_tx_ba_cb_irqsafe(ctx->vif, addr, tid);
                }
@@ -1241,8 +1261,7 @@ int iwlagn_tx_queue_reclaim(struct iwl_priv *priv, int txq_id, int index)
                                 txq_id >= IWLAGN_FIRST_AMPDU_QUEUE);
                tx_info->skb = NULL;
-                if (priv->cfg->ops->lib->txq_inval_byte_cnt_tbl)
+                iwlagn_txq_inval_byte_cnt_tbl(priv, txq);
-                        priv->cfg->ops->lib->txq_inval_byte_cnt_tbl(priv, txq);
                priv->cfg->ops->lib->txq_free_tfd(priv, txq);
        }
@@ -1260,11 +1279,11 @@ static int iwlagn_tx_status_reply_compressed_ba(struct iwl_priv *priv,
                                 struct iwl_compressed_ba_resp *ba_resp)
 {
-        int i, sh, ack;
+        int sh;
        u16 seq_ctl = le16_to_cpu(ba_resp->seq_ctl);
        u16 scd_flow = le16_to_cpu(ba_resp->scd_flow);
-        int successes = 0;
        struct ieee80211_tx_info *info;
+        u64 bitmap, sent_bitmap;
        if (unlikely(!agg->wait_for_ba))  {
                if (unlikely(ba_resp->bitmap))
@@ -1278,70 +1297,42 @@ static int iwlagn_tx_status_reply_compressed_ba(struct iwl_priv *priv,
        /* Calculate shift to align block-ack bits with our Tx window bits */
        sh = agg->start_idx - SEQ_TO_INDEX(seq_ctl >> 4);
-        if (sh < 0) /* tbw something is wrong with indices */
+        if (sh < 0)
                sh += 0x100;
-        if (agg->frame_count > (64 - sh)) {
+        /*
-                IWL_DEBUG_TX_REPLY(priv, "more frames than bitmap size");
+         * Check for success or failure according to the
-                return -1;
+         * transmitted bitmap and block-ack bitmap
-        }
+         */
-        if (!priv->cfg->base_params->no_agg_framecnt_info && ba_resp->txed) {
+        bitmap = le64_to_cpu(ba_resp->bitmap) >> sh;
+        sent_bitmap = bitmap & agg->bitmap;
+        /* Sanity check values reported by uCode */
+        if (ba_resp->txed_2_done > ba_resp->txed) {
+                IWL_DEBUG_TX_REPLY(priv,
+                        "bogus sent(%d) and ack(%d) count\n",
+                        ba_resp->txed, ba_resp->txed_2_done);
                /*
-                 * sent and ack information provided by uCode
+                 * set txed_2_done = txed,
-                 * use it instead of figure out ourself
+                 * so it won't impact rate scale
                 */
-                if (ba_resp->txed_2_done > ba_resp->txed) {
+                ba_resp->txed = ba_resp->txed_2_done;
-                        IWL_DEBUG_TX_REPLY(priv,
+        }
-                                "bogus sent(%d) and ack(%d) count\n",
+        IWL_DEBUG_HT(priv, "agg frames sent:%d, acked:%d\n",
-                                ba_resp->txed, ba_resp->txed_2_done);
+                        ba_resp->txed, ba_resp->txed_2_done);
-                        /*
-                         * set txed_2_done = txed,
-                         * so it won't impact rate scale
-                         */
-                        ba_resp->txed = ba_resp->txed_2_done;
-                }
-                IWL_DEBUG_HT(priv, "agg frames sent:%d, acked:%d\n",
-                                ba_resp->txed, ba_resp->txed_2_done);
-        } else {
-                u64 bitmap, sent_bitmap;
-                /* don't use 64-bit values for now */
-                bitmap = le64_to_cpu(ba_resp->bitmap) >> sh;
-                /* check for success or failure according to the
-                 * transmitted bitmap and block-ack bitmap */
-                sent_bitmap = bitmap & agg->bitmap;
-                /* For each frame attempted in aggregation,
-                 * update driver's record of tx frame's status. */
-                i = 0;
-                while (sent_bitmap) {
-                        ack = sent_bitmap & 1ULL;
-                        successes += ack;
-                        IWL_DEBUG_TX_REPLY(priv, "%s ON i=%d idx=%d raw=%d\n",
-                                ack ? "ACK" : "NACK", i,
-                                (agg->start_idx + i) & 0xff,
-                                agg->start_idx + i);
-                        sent_bitmap >>= 1;
-                        ++i;
-                }
-                IWL_DEBUG_TX_REPLY(priv, "Bitmap %llx\n",
+        /* Find the first ACKed frame to store the TX status */
-                                   (unsigned long long)bitmap);
+        while (sent_bitmap && !(sent_bitmap & 1)) {
+                agg->start_idx = (agg->start_idx + 1) & 0xff;
+                sent_bitmap >>= 1;
        }
        info = IEEE80211_SKB_CB(priv->txq[scd_flow].txb[agg->start_idx].skb);
        memset(&info->status, 0, sizeof(info->status));
        info->flags |= IEEE80211_TX_STAT_ACK;
        info->flags |= IEEE80211_TX_STAT_AMPDU;
-        if (!priv->cfg->base_params->no_agg_framecnt_info && ba_resp->txed) {
+        info->status.ampdu_ack_len = ba_resp->txed_2_done;
-                info->status.ampdu_ack_len = ba_resp->txed_2_done;
+        info->status.ampdu_len = ba_resp->txed;
-                info->status.ampdu_len = ba_resp->txed;
-        } else {
-                info->status.ampdu_ack_len = successes;
-                info->status.ampdu_len = agg->frame_count;
-        }
        iwlagn_hwrate_to_tx_control(priv, agg->rate_n_flags, info);
        return 0;
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-ucode.c b/drivers/net/wireless/iwlwifi/iwl-agn-ucode.c
index d807e5e2b718..8bda0e8d6661 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-ucode.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-ucode.c
@@ -2,7 +2,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -161,47 +161,19 @@ static int iwlagn_load_section(struct iwl_priv *priv, const char *name,
 }
 static int iwlagn_load_given_ucode(struct iwl_priv *priv,
-                struct fw_desc *inst_image,
+                                   struct fw_img *image)
-                struct fw_desc *data_image)
 {
        int ret = 0;
-        ret = iwlagn_load_section(priv, "INST", inst_image,
+        ret = iwlagn_load_section(priv, "INST", &image->code,
                                   IWLAGN_RTC_INST_LOWER_BOUND);
        if (ret)
                return ret;
-        return iwlagn_load_section(priv, "DATA", data_image,
+        return iwlagn_load_section(priv, "DATA", &image->data,
                                    IWLAGN_RTC_DATA_LOWER_BOUND);
 }
-int iwlagn_load_ucode(struct iwl_priv *priv)
-{
-        int ret = 0;
-        /* check whether init ucode should be loaded, or rather runtime ucode */
-        if (priv->ucode_init.len && (priv->ucode_type == UCODE_NONE)) {
-                IWL_DEBUG_INFO(priv, "Init ucode found. Loading init ucode...\n");
-                ret = iwlagn_load_given_ucode(priv,
-                        &priv->ucode_init, &priv->ucode_init_data);
-                if (!ret) {
-                        IWL_DEBUG_INFO(priv, "Init ucode load complete.\n");
-                        priv->ucode_type = UCODE_INIT;
-                }
-        } else {
-                IWL_DEBUG_INFO(priv, "Init ucode not found, or already loaded. "
-                        "Loading runtime ucode...\n");
-                ret = iwlagn_load_given_ucode(priv,
-                        &priv->ucode_code, &priv->ucode_data);
-                if (!ret) {
-                        IWL_DEBUG_INFO(priv, "Runtime ucode load complete.\n");
-                        priv->ucode_type = UCODE_RT;
-                }
-        }
-        return ret;
-}
 /*
 *  Calibration
 */
@@ -297,33 +269,9 @@ void iwlagn_rx_calib_result(struct iwl_priv *priv,
        iwl_calib_set(&priv->calib_results[index], pkt->u.raw, len);
 }
-void iwlagn_rx_calib_complete(struct iwl_priv *priv,
+int iwlagn_init_alive_start(struct iwl_priv *priv)
-                               struct iwl_rx_mem_buffer *rxb)
 {
-        IWL_DEBUG_INFO(priv, "Init. calibration is completed, restarting fw.\n");
+        int ret;
-        queue_work(priv->workqueue, &priv->restart);
-}
-void iwlagn_init_alive_start(struct iwl_priv *priv)
-{
-        int ret = 0;
-        /* initialize uCode was loaded... verify inst image.
-         * This is a paranoid check, because we would not have gotten the
-         * "initialize" alive if code weren't properly loaded.  */
-        if (iwl_verify_ucode(priv)) {
-                /* Runtime instruction load was bad;
-                 * take it all the way back down so we can try again */
-                IWL_DEBUG_INFO(priv, "Bad \"initialize\" uCode load.\n");
-                goto restart;
-        }
-        ret = priv->cfg->ops->lib->alive_notify(priv);
-        if (ret) {
-                IWL_WARN(priv,
-                        "Could not complete ALIVE transition: %d\n", ret);
-                goto restart;
-        }
        if (priv->cfg->bt_params &&
            priv->cfg->bt_params->advanced_bt_coexist) {
@@ -333,24 +281,25 @@ void iwlagn_init_alive_start(struct iwl_priv *priv)
                 * no need to close the envlope since we are going
                 * to load the runtime uCode later.
                 */
-                iwlagn_send_bt_env(priv, IWL_BT_COEX_ENV_OPEN,
+                ret = iwlagn_send_bt_env(priv, IWL_BT_COEX_ENV_OPEN,
                        BT_COEX_PRIO_TBL_EVT_INIT_CALIB2);
+                if (ret)
+                        return ret;
        }
-        iwlagn_send_calib_cfg(priv);
+        ret = iwlagn_send_calib_cfg(priv);
+        if (ret)
+                return ret;
        /**
         * temperature offset calibration is only needed for runtime ucode,
         * so prepare the value now.
         */
        if (priv->cfg->need_temp_offset_calib)
-                iwlagn_set_temperature_offset_calib(priv);
+                return iwlagn_set_temperature_offset_calib(priv);
-        return;
+        return 0;
-restart:
-        /* real restart (first load init_ucode) */
-        queue_work(priv->workqueue, &priv->restart);
 }
 static int iwlagn_send_wimax_coex(struct iwl_priv *priv)
@@ -413,25 +362,30 @@ void iwlagn_send_prio_tbl(struct iwl_priv *priv)
                IWL_ERR(priv, "failed to send BT prio tbl command\n");
 }
-void iwlagn_send_bt_env(struct iwl_priv *priv, u8 action, u8 type)
+int iwlagn_send_bt_env(struct iwl_priv *priv, u8 action, u8 type)
 {
        struct iwl_bt_coex_prot_env_cmd env_cmd;
+        int ret;
        env_cmd.action = action;
        env_cmd.type = type;
-        if (iwl_send_cmd_pdu(priv, REPLY_BT_COEX_PROT_ENV,
+        ret = iwl_send_cmd_pdu(priv, REPLY_BT_COEX_PROT_ENV,
-                             sizeof(env_cmd), &env_cmd))
+                               sizeof(env_cmd), &env_cmd);
+        if (ret)
                IWL_ERR(priv, "failed to send BT env command\n");
+        return ret;
 }
-int iwlagn_alive_notify(struct iwl_priv *priv)
+static int iwlagn_alive_notify(struct iwl_priv *priv)
 {
        const struct queue_to_fifo_ac *queue_to_fifo;
+        struct iwl_rxon_context *ctx;
        u32 a;
        unsigned long flags;
        int i, chan;
        u32 reg_val;
+        int ret;
        spin_lock_irqsave(&priv->lock, flags);
@@ -500,6 +454,8 @@ int iwlagn_alive_notify(struct iwl_priv *priv)
        memset(&priv->queue_stopped[0], 0, sizeof(priv->queue_stopped));
        for (i = 0; i < 4; i++)
                atomic_set(&priv->queue_stop_count[i], 0);
+        for_each_context(priv, ctx)
+                ctx->last_tx_rejected = false;
        /* reset to 0 to enable all the queue first */
        priv->txq_ctx_active_msk = 0;
@@ -527,12 +483,15 @@ int iwlagn_alive_notify(struct iwl_priv *priv)
        iwl_clear_bits_prph(priv, APMG_PCIDEV_STT_REG,
                          APMG_PCIDEV_STT_VAL_L1_ACT_DIS);
-        iwlagn_send_wimax_coex(priv);
+        ret = iwlagn_send_wimax_coex(priv);
+        if (ret)
+                return ret;
-        iwlagn_set_Xtal_calib(priv);
+        ret = iwlagn_set_Xtal_calib(priv);
-        iwl_send_calib_results(priv);
+        if (ret)
+                return ret;
-        return 0;
+        return iwl_send_calib_results(priv);
 }
@@ -541,11 +500,12 @@ int iwlagn_alive_notify(struct iwl_priv *priv)
 *   using sample data 100 bytes apart.  If these sample points are good,
 *   it's a pretty good bet that everything between them is good, too.
 */
-static int iwlcore_verify_inst_sparse(struct iwl_priv *priv, __le32 *image, u32 len)
+static int iwlcore_verify_inst_sparse(struct iwl_priv *priv,
+                                      struct fw_desc *fw_desc)
 {
+        __le32 *image = (__le32 *)fw_desc->v_addr;
+        u32 len = fw_desc->len;
        u32 val;
-        int ret = 0;
-        u32 errcnt = 0;
        u32 i;
        IWL_DEBUG_INFO(priv, "ucode inst image size is %u\n", len);
@@ -556,104 +516,204 @@ static int iwlcore_verify_inst_sparse(struct iwl_priv *priv, __le32 *image, u32
                 * if IWL_DL_IO is set */
                iwl_write_direct32(priv, HBUS_TARG_MEM_RADDR,
                        i + IWLAGN_RTC_INST_LOWER_BOUND);
-                val = _iwl_read_direct32(priv, HBUS_TARG_MEM_RDAT);
+                val = iwl_read32(priv, HBUS_TARG_MEM_RDAT);
-                if (val != le32_to_cpu(*image)) {
+                if (val != le32_to_cpu(*image))
-                        ret = -EIO;
+                        return -EIO;
-                        errcnt++;
-                        if (errcnt >= 3)
-                                break;
-                }
        }
-        return ret;
+        return 0;
 }
-/**
+static void iwl_print_mismatch_inst(struct iwl_priv *priv,
- * iwlcore_verify_inst_full - verify runtime uCode image in card vs. host,
+                                    struct fw_desc *fw_desc)
- *     looking at all data.
- */
-static int iwl_verify_inst_full(struct iwl_priv *priv, __le32 *image,
-                                 u32 len)
 {
+        __le32 *image = (__le32 *)fw_desc->v_addr;
+        u32 len = fw_desc->len;
        u32 val;
-        u32 save_len = len;
+        u32 offs;
-        int ret = 0;
+        int errors = 0;
-        u32 errcnt;
        IWL_DEBUG_INFO(priv, "ucode inst image size is %u\n", len);
        iwl_write_direct32(priv, HBUS_TARG_MEM_RADDR,
                           IWLAGN_RTC_INST_LOWER_BOUND);
-        errcnt = 0;
+        for (offs = 0;
-        for (; len > 0; len -= sizeof(u32), image++) {
+             offs < len && errors < 20;
+             offs += sizeof(u32), image++) {
                /* read data comes through single port, auto-incr addr */
-                /* NOTE: Use the debugless read so we don't flood kernel log
+                val = iwl_read32(priv, HBUS_TARG_MEM_RDAT);
-                 * if IWL_DL_IO is set */
-                val = _iwl_read_direct32(priv, HBUS_TARG_MEM_RDAT);
                if (val != le32_to_cpu(*image)) {
-                        IWL_ERR(priv, "uCode INST section is invalid at "
+                        IWL_ERR(priv, "uCode INST section at "
-                                  "offset 0x%x, is 0x%x, s/b 0x%x\n",
+                                "offset 0x%x, is 0x%x, s/b 0x%x\n",
-                                  save_len - len, val, le32_to_cpu(*image));
+                                offs, val, le32_to_cpu(*image));
-                        ret = -EIO;
+                        errors++;
-                        errcnt++;
-                        if (errcnt >= 20)
-                                break;
                }
        }
-        if (!errcnt)
-                IWL_DEBUG_INFO(priv,
-                    "ucode image in INSTRUCTION memory is good\n");
-        return ret;
 }
 /**
 * iwl_verify_ucode - determine which instruction image is in SRAM,
 *    and verify its contents
 */
-int iwl_verify_ucode(struct iwl_priv *priv)
+static int iwl_verify_ucode(struct iwl_priv *priv, struct fw_img *img)
+{
+        if (!iwlcore_verify_inst_sparse(priv, &img->code)) {
+                IWL_DEBUG_INFO(priv, "uCode is good in inst SRAM\n");
+                return 0;
+        }
+        IWL_ERR(priv, "UCODE IMAGE IN INSTRUCTION SRAM NOT VALID!!\n");
+        iwl_print_mismatch_inst(priv, &img->code);
+        return -EIO;
+}
+struct iwlagn_alive_data {
+        bool valid;
+        u8 subtype;
+};
+static void iwlagn_alive_fn(struct iwl_priv *priv,
+                            struct iwl_rx_packet *pkt,
+                            void *data)
 {
-        __le32 *image;
+        struct iwlagn_alive_data *alive_data = data;
-        u32 len;
+        struct iwl_alive_resp *palive;
+        palive = &pkt->u.alive_frame;
+        IWL_DEBUG_INFO(priv, "Alive ucode status 0x%08X revision "
+                       "0x%01X 0x%01X\n",
+                       palive->is_valid, palive->ver_type,
+                       palive->ver_subtype);
+        priv->device_pointers.error_event_table =
+                le32_to_cpu(palive->error_event_table_ptr);
+        priv->device_pointers.log_event_table =
+                le32_to_cpu(palive->log_event_table_ptr);
+        alive_data->subtype = palive->ver_subtype;
+        alive_data->valid = palive->is_valid == UCODE_VALID_OK;
+}
+#define UCODE_ALIVE_TIMEOUT     HZ
+#define UCODE_CALIB_TIMEOUT     (2*HZ)
+int iwlagn_load_ucode_wait_alive(struct iwl_priv *priv,
+                                 struct fw_img *image,
+                                 int subtype, int alternate_subtype)
+{
+        struct iwl_notification_wait alive_wait;
+        struct iwlagn_alive_data alive_data;
        int ret;
+        enum iwlagn_ucode_subtype old_type;
-        /* Try bootstrap */
+        ret = iwlagn_start_device(priv);
-        image = (__le32 *)priv->ucode_boot.v_addr;
+        if (ret)
-        len = priv->ucode_boot.len;
+                return ret;
-        ret = iwlcore_verify_inst_sparse(priv, image, len);
-        if (!ret) {
+        iwlagn_init_notification_wait(priv, &alive_wait, REPLY_ALIVE,
-                IWL_DEBUG_INFO(priv, "Bootstrap uCode is good in inst SRAM\n");
+                                      iwlagn_alive_fn, &alive_data);
-                return 0;
+        old_type = priv->ucode_type;
+        priv->ucode_type = subtype;
+        ret = iwlagn_load_given_ucode(priv, image);
+        if (ret) {
+                priv->ucode_type = old_type;
+                iwlagn_remove_notification(priv, &alive_wait);
+                return ret;
        }
-        /* Try initialize */
+        /* Remove all resets to allow NIC to operate */
-        image = (__le32 *)priv->ucode_init.v_addr;
+        iwl_write32(priv, CSR_RESET, 0);
-        len = priv->ucode_init.len;
-        ret = iwlcore_verify_inst_sparse(priv, image, len);
+        /*
-        if (!ret) {
+         * Some things may run in the background now, but we
-                IWL_DEBUG_INFO(priv, "Initialize uCode is good in inst SRAM\n");
+         * just wait for the ALIVE notification here.
-                return 0;
+         */
+        ret = iwlagn_wait_notification(priv, &alive_wait, UCODE_ALIVE_TIMEOUT);
+        if (ret) {
+                priv->ucode_type = old_type;
+                return ret;
        }
-        /* Try runtime/protocol */
+        if (!alive_data.valid) {
-        image = (__le32 *)priv->ucode_code.v_addr;
+                IWL_ERR(priv, "Loaded ucode is not valid!\n");
-        len = priv->ucode_code.len;
+                priv->ucode_type = old_type;
-        ret = iwlcore_verify_inst_sparse(priv, image, len);
+                return -EIO;
-        if (!ret) {
+        }
-                IWL_DEBUG_INFO(priv, "Runtime uCode is good in inst SRAM\n");
-                return 0;
+        if (alive_data.subtype != subtype &&
+            alive_data.subtype != alternate_subtype) {
+                IWL_ERR(priv,
+                        "Loaded ucode is not expected type (got %d, expected %d)!\n",
+                        alive_data.subtype, subtype);
+                priv->ucode_type = old_type;
+                return -EIO;
        }
-        IWL_ERR(priv, "NO VALID UCODE IMAGE IN INSTRUCTION SRAM!!\n");
+        ret = iwl_verify_ucode(priv, image);
+        if (ret) {
+                priv->ucode_type = old_type;
+                return ret;
+        }
+        /* delay a bit to give rfkill time to run */
+        msleep(5);
+        ret = iwlagn_alive_notify(priv);
+        if (ret) {
+                IWL_WARN(priv,
+                        "Could not complete ALIVE transition: %d\n", ret);
+                priv->ucode_type = old_type;
+                return ret;
+        }
+        return 0;
+}
+int iwlagn_run_init_ucode(struct iwl_priv *priv)
+{
+        struct iwl_notification_wait calib_wait;
+        int ret;
+        lockdep_assert_held(&priv->mutex);
+        /* No init ucode required? Curious, but maybe ok */
+        if (!priv->ucode_init.code.len)
+                return 0;
+        if (priv->ucode_type != UCODE_SUBTYPE_NONE_LOADED)
+                return 0;
+        iwlagn_init_notification_wait(priv, &calib_wait,
+                                      CALIBRATION_COMPLETE_NOTIFICATION,
+                                      NULL, NULL);
+        /* Will also start the device */
+        ret = iwlagn_load_ucode_wait_alive(priv, &priv->ucode_init,
+                                           UCODE_SUBTYPE_INIT, -1);
+        if (ret)
+                goto error;
+        ret = iwlagn_init_alive_start(priv);
+        if (ret)
+                goto error;
+        /*
+         * Some things may run in the background now, but we
+         * just wait for the calibration complete notification.
+         */
+        ret = iwlagn_wait_notification(priv, &calib_wait, UCODE_CALIB_TIMEOUT);
-        /* Since nothing seems to match, show first several data entries in
+        goto out;
-         * instruction SRAM, so maybe visual inspection will give a clue.
-         * Selection of bootstrap image (vs. other images) is arbitrary. */
-        image = (__le32 *)priv->ucode_boot.v_addr;
-        len = priv->ucode_boot.len;
-        ret = iwl_verify_inst_full(priv, image, len);
+ error:
+        iwlagn_remove_notification(priv, &calib_wait);
+ out:
+        /* Whatever happened, stop the device */
+        iwlagn_stop_device(priv);
        return ret;
 }
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 321b18b59135..3ecc3198d9bf 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
@@ -59,7 +59,6 @@
 #include "iwl-sta.h"
 #include "iwl-agn-calib.h"
 #include "iwl-agn.h"
-#include "iwl-agn-led.h"
 /******************************************************************************
@@ -103,70 +102,6 @@ void iwl_update_chain_flags(struct iwl_priv *priv)
        }
 }
-static void iwl_clear_free_frames(struct iwl_priv *priv)
-{
-        struct list_head *element;
-        IWL_DEBUG_INFO(priv, "%d frames on pre-allocated heap on clear.\n",
-                       priv->frames_count);
-        while (!list_empty(&priv->free_frames)) {
-                element = priv->free_frames.next;
-                list_del(element);
-                kfree(list_entry(element, struct iwl_frame, list));
-                priv->frames_count--;
-        }
-        if (priv->frames_count) {
-                IWL_WARN(priv, "%d frames still in use.  Did we lose one?\n",
-                            priv->frames_count);
-                priv->frames_count = 0;
-        }
-}
-static struct iwl_frame *iwl_get_free_frame(struct iwl_priv *priv)
-{
-        struct iwl_frame *frame;
-        struct list_head *element;
-        if (list_empty(&priv->free_frames)) {
-                frame = kzalloc(sizeof(*frame), GFP_KERNEL);
-                if (!frame) {
-                        IWL_ERR(priv, "Could not allocate frame!\n");
-                        return NULL;
-                }
-                priv->frames_count++;
-                return frame;
-        }
-        element = priv->free_frames.next;
-        list_del(element);
-        return list_entry(element, struct iwl_frame, list);
-}
-static void iwl_free_frame(struct iwl_priv *priv, struct iwl_frame *frame)
-{
-        memset(frame, 0, sizeof(*frame));
-        list_add(&frame->list, &priv->free_frames);
-}
-static u32 iwl_fill_beacon_frame(struct iwl_priv *priv,
-                                 struct ieee80211_hdr *hdr,
-                                 int left)
-{
-        lockdep_assert_held(&priv->mutex);
-        if (!priv->beacon_skb)
-                return 0;
-        if (priv->beacon_skb->len > left)
-                return 0;
-        memcpy(hdr, priv->beacon_skb->data, priv->beacon_skb->len);
-        return priv->beacon_skb->len;
-}
 /* Parse the beacon frame to find the TIM element and set tim_idx & tim_size */
 static void iwl_set_beacon_tim(struct iwl_priv *priv,
                               struct iwl_tx_beacon_cmd *tx_beacon_cmd,
@@ -194,13 +129,18 @@ static void iwl_set_beacon_tim(struct iwl_priv *priv,
                IWL_WARN(priv, "Unable to find TIM Element in beacon\n");
 }
-static unsigned int iwl_hw_get_beacon_cmd(struct iwl_priv *priv,
+int iwlagn_send_beacon_cmd(struct iwl_priv *priv)
-                                       struct iwl_frame *frame)
 {
        struct iwl_tx_beacon_cmd *tx_beacon_cmd;
+        struct iwl_host_cmd cmd = {
+                .id = REPLY_TX_BEACON,
+                .flags = CMD_SIZE_HUGE,
+        };
        u32 frame_size;
        u32 rate_flags;
        u32 rate;
+        int err;
        /*
         * We have to set up the TX command, the TX Beacon command, and the
         * beacon contents.
@@ -213,17 +153,19 @@ static unsigned int iwl_hw_get_beacon_cmd(struct iwl_priv *priv,
                return 0;
        }
-        /* Initialize memory */
+        if (WARN_ON(!priv->beacon_skb))
-        tx_beacon_cmd = &frame->u.beacon;
+                return -EINVAL;
-        memset(tx_beacon_cmd, 0, sizeof(*tx_beacon_cmd));
+        /* Allocate beacon memory */
+        tx_beacon_cmd = kzalloc(sizeof(*tx_beacon_cmd) + priv->beacon_skb->len,
+                                GFP_KERNEL);
+        if (!tx_beacon_cmd)
+                return -ENOMEM;
+        frame_size = priv->beacon_skb->len;
        /* Set up TX beacon contents */
-        frame_size = iwl_fill_beacon_frame(priv, tx_beacon_cmd->frame,
+        memcpy(tx_beacon_cmd->frame, priv->beacon_skb->data, frame_size);
-                                sizeof(frame->u) - sizeof(*tx_beacon_cmd));
-        if (WARN_ON_ONCE(frame_size > MAX_MPDU_SIZE))
-                return 0;
-        if (!frame_size)
-                return 0;
        /* Set up TX command fields */
        tx_beacon_cmd->tx.len = cpu_to_le16((u16)frame_size);
@@ -246,35 +188,16 @@ static unsigned int iwl_hw_get_beacon_cmd(struct iwl_priv *priv,
        tx_beacon_cmd->tx.rate_n_flags = iwl_hw_set_rate_n_flags(rate,
                        rate_flags);
-        return sizeof(*tx_beacon_cmd) + frame_size;
+        /* Submit command */
-}
+        cmd.len = sizeof(*tx_beacon_cmd) + frame_size;
+        cmd.data = tx_beacon_cmd;
-int iwlagn_send_beacon_cmd(struct iwl_priv *priv)
+        err = iwl_send_cmd_sync(priv, &cmd);
-{
-        struct iwl_frame *frame;
-        unsigned int frame_size;
-        int rc;
-        frame = iwl_get_free_frame(priv);
-        if (!frame) {
-                IWL_ERR(priv, "Could not obtain free frame buffer for beacon "
-                          "command.\n");
-                return -ENOMEM;
-        }
-        frame_size = iwl_hw_get_beacon_cmd(priv, frame);
+        /* Free temporary storage */
-        if (!frame_size) {
+        kfree(tx_beacon_cmd);
-                IWL_ERR(priv, "Error configuring the beacon command\n");
-                iwl_free_frame(priv, frame);
-                return -EINVAL;
-        }
-        rc = iwl_send_cmd_pdu(priv, REPLY_TX_BEACON, frame_size,
-                              &frame->u.cmd[0]);
-        iwl_free_frame(priv, frame);
+        return err;
-        return rc;
 }
 static inline dma_addr_t iwl_tfd_tb_get_addr(struct iwl_tfd *tfd, u8 idx)
@@ -395,7 +318,9 @@ int iwl_hw_txq_attach_buf_to_tfd(struct iwl_priv *priv,
                return -EINVAL;
        }
-        BUG_ON(addr & ~DMA_BIT_MASK(36));
+        if (WARN_ON(addr & ~DMA_BIT_MASK(36)))
+                return -EINVAL;
        if (unlikely(addr & ~IWL_TX_DMA_MASK))
                IWL_ERR(priv, "Unaligned address = %llx\n",
                          (unsigned long long)addr);
@@ -409,7 +334,7 @@ int iwl_hw_txq_attach_buf_to_tfd(struct iwl_priv *priv,
 * Tell nic where to find circular buffer of Tx Frame Descriptors for
 * given Tx queue, and enable the DMA channel used for that queue.
 *
- * 4965 supports up to 16 Tx queues in DRAM, mapped to up to 8 Tx DMA
+ * supports up to 16 Tx queues in DRAM, mapped to up to 8 Tx DMA
 * channels supported in hardware.
 */
 int iwl_hw_tx_queue_init(struct iwl_priv *priv,
@@ -483,12 +408,14 @@ static void iwl_bg_bt_full_concurrency(struct work_struct *work)
                container_of(work, struct iwl_priv, bt_full_concurrency);
        struct iwl_rxon_context *ctx;
+        mutex_lock(&priv->mutex);
        if (test_bit(STATUS_EXIT_PENDING, &priv->status))
-                return;
+                goto out;
        /* dont send host command if rf-kill is on */
        if (!iwl_is_ready_rf(priv))
-                return;
+                goto out;
        IWL_DEBUG_INFO(priv, "BT coex in %s mode\n",
                       priv->bt_full_concurrent ?
@@ -498,15 +425,15 @@ static void iwl_bg_bt_full_concurrency(struct work_struct *work)
         * LQ & RXON updated cmds must be sent before BT Config cmd
         * to avoid 3-wire collisions
         */
-        mutex_lock(&priv->mutex);
        for_each_context(priv, ctx) {
                if (priv->cfg->ops->hcmd->set_rxon_chain)
                        priv->cfg->ops->hcmd->set_rxon_chain(priv, ctx);
                iwlcore_commit_rxon(priv, ctx);
        }
-        mutex_unlock(&priv->mutex);
        priv->cfg->ops->hcmd->send_bt_config(priv);
+out:
+        mutex_unlock(&priv->mutex);
 }
 /**
@@ -556,7 +483,7 @@ static void iwl_print_cont_event_trace(struct iwl_priv *priv, u32 base,
        }
        /* Set starting address; reads will auto-increment */
-        _iwl_write_direct32(priv, HBUS_TARG_MEM_RADDR, ptr);
+        iwl_write32(priv, HBUS_TARG_MEM_RADDR, ptr);
        rmb();
        /*
@@ -564,13 +491,13 @@ static void iwl_print_cont_event_trace(struct iwl_priv *priv, u32 base,
         * place event id # at far right for easier visual parsing.
         */
        for (i = 0; i < num_events; i++) {
-                ev = _iwl_read_direct32(priv, HBUS_TARG_MEM_RDAT);
+                ev = iwl_read32(priv, HBUS_TARG_MEM_RDAT);
-                time = _iwl_read_direct32(priv, HBUS_TARG_MEM_RDAT);
+                time = iwl_read32(priv, HBUS_TARG_MEM_RDAT);
                if (mode == 0) {
                        trace_iwlwifi_dev_ucode_cont_event(priv,
                                                        0, time, ev);
                } else {
-                        data = _iwl_read_direct32(priv, HBUS_TARG_MEM_RDAT);
+                        data = iwl_read32(priv, HBUS_TARG_MEM_RDAT);
                        trace_iwlwifi_dev_ucode_cont_event(priv,
                                                time, data, ev);
                }
@@ -588,10 +515,7 @@ static void iwl_continuous_event_trace(struct iwl_priv *priv)
        u32 num_wraps;  /* # times uCode wrapped to top of log */
        u32 next_entry; /* index of next entry to be written by uCode */
-        if (priv->ucode_type == UCODE_INIT)
+        base = priv->device_pointers.error_event_table;
-                base = le32_to_cpu(priv->card_alive_init.error_event_table_ptr);
-        else
-                base = le32_to_cpu(priv->card_alive.log_event_table_ptr);
        if (priv->cfg->ops->lib->is_valid_rtc_data_addr(base)) {
                capacity = iwl_read_targ_mem(priv, base);
                num_wraps = iwl_read_targ_mem(priv, base + (2 * sizeof(u32)));
@@ -720,7 +644,10 @@ static void iwl_rx_handle(struct iwl_priv *priv)
                /* If an RXB doesn't have a Rx queue slot associated with it,
                 * then a bug has been introduced in the queue refilling
                 * routines -- catch it here */
-                BUG_ON(rxb == NULL);
+                if (WARN_ON(rxb == NULL)) {
+                        i = (i + 1) & RX_QUEUE_MASK;
+                        continue;
+                }
                rxq->queue[i] = NULL;
@@ -760,13 +687,15 @@ static void iwl_rx_handle(struct iwl_priv *priv)
                                if (w->cmd == pkt->hdr.cmd) {
                                        w->triggered = true;
                                        if (w->fn)
-                                                w->fn(priv, pkt);
+                                                w->fn(priv, pkt, w->fn_data);
                                }
                        }
                        spin_unlock(&priv->_agn.notif_wait_lock);
                        wake_up_all(&priv->_agn.notif_waitq);
                }
+                if (priv->pre_rx_handler)
+                        priv->pre_rx_handler(priv, rxb);
                /* Based on type of command response or notification,
                 *   handle those that need handling via function in
@@ -837,199 +766,6 @@ static void iwl_rx_handle(struct iwl_priv *priv)
                iwlagn_rx_queue_restock(priv);
 }
-/* call this function to flush any scheduled tasklet */
-static inline void iwl_synchronize_irq(struct iwl_priv *priv)
-{
-        /* wait to make sure we flush pending tasklet*/
-        synchronize_irq(priv->pci_dev->irq);
-        tasklet_kill(&priv->irq_tasklet);
-}
-static void iwl_irq_tasklet_legacy(struct iwl_priv *priv)
-{
-        u32 inta, handled = 0;
-        u32 inta_fh;
-        unsigned long flags;
-        u32 i;
-#ifdef CONFIG_IWLWIFI_DEBUG
-        u32 inta_mask;
-#endif
-        spin_lock_irqsave(&priv->lock, flags);
-        /* Ack/clear/reset pending uCode interrupts.
-         * Note:  Some bits in CSR_INT are "OR" of bits in CSR_FH_INT_STATUS,
-         *  and will clear only when CSR_FH_INT_STATUS gets cleared. */
-        inta = iwl_read32(priv, CSR_INT);
-        iwl_write32(priv, CSR_INT, inta);
-        /* Ack/clear/reset pending flow-handler (DMA) interrupts.
-         * Any new interrupts that happen after this, either while we're
-         * in this tasklet, or later, will show up in next ISR/tasklet. */
-        inta_fh = iwl_read32(priv, CSR_FH_INT_STATUS);
-        iwl_write32(priv, CSR_FH_INT_STATUS, inta_fh);
-#ifdef CONFIG_IWLWIFI_DEBUG
-        if (iwl_get_debug_level(priv) & IWL_DL_ISR) {
-                /* just for debug */
-                inta_mask = iwl_read32(priv, CSR_INT_MASK);
-                IWL_DEBUG_ISR(priv, "inta 0x%08x, enabled 0x%08x, fh 0x%08x\n",
-                              inta, inta_mask, inta_fh);
-        }
-#endif
-        spin_unlock_irqrestore(&priv->lock, flags);
-        /* Since CSR_INT and CSR_FH_INT_STATUS reads and clears are not
-         * atomic, make sure that inta covers all the interrupts that
-         * we've discovered, even if FH interrupt came in just after
-         * reading CSR_INT. */
-        if (inta_fh & CSR49_FH_INT_RX_MASK)
-                inta |= CSR_INT_BIT_FH_RX;
-        if (inta_fh & CSR49_FH_INT_TX_MASK)
-                inta |= CSR_INT_BIT_FH_TX;
-        /* Now service all interrupt bits discovered above. */
-        if (inta & CSR_INT_BIT_HW_ERR) {
-                IWL_ERR(priv, "Hardware error detected.  Restarting.\n");
-                /* Tell the device to stop sending interrupts */
-                iwl_disable_interrupts(priv);
-                priv->isr_stats.hw++;
-                iwl_irq_handle_error(priv);
-                handled |= CSR_INT_BIT_HW_ERR;
-                return;
-        }
-#ifdef CONFIG_IWLWIFI_DEBUG
-        if (iwl_get_debug_level(priv) & (IWL_DL_ISR)) {
-                /* NIC fires this, but we don't use it, redundant with WAKEUP */
-                if (inta & CSR_INT_BIT_SCD) {
-                        IWL_DEBUG_ISR(priv, "Scheduler finished to transmit "
-                                      "the frame/frames.\n");
-                        priv->isr_stats.sch++;
-                }
-                /* Alive notification via Rx interrupt will do the real work */
-                if (inta & CSR_INT_BIT_ALIVE) {
-                        IWL_DEBUG_ISR(priv, "Alive interrupt\n");
-                        priv->isr_stats.alive++;
-                }
-        }
-#endif
-        /* Safely ignore these bits for debug checks below */
-        inta &= ~(CSR_INT_BIT_SCD | CSR_INT_BIT_ALIVE);
-        /* HW RF KILL switch toggled */
-        if (inta & CSR_INT_BIT_RF_KILL) {
-                int hw_rf_kill = 0;
-                if (!(iwl_read32(priv, CSR_GP_CNTRL) &
-                                CSR_GP_CNTRL_REG_FLAG_HW_RF_KILL_SW))
-                        hw_rf_kill = 1;
-                IWL_WARN(priv, "RF_KILL bit toggled to %s.\n",
-                                hw_rf_kill ? "disable radio" : "enable radio");
-                priv->isr_stats.rfkill++;
-                /* driver only loads ucode once setting the interface up.
-                 * the driver allows loading the ucode even if the radio
-                 * is killed. Hence update the killswitch state here. The
-                 * rfkill handler will care about restarting if needed.
-                 */
-                if (!test_bit(STATUS_ALIVE, &priv->status)) {
-                        if (hw_rf_kill)
-                                set_bit(STATUS_RF_KILL_HW, &priv->status);
-                        else
-                                clear_bit(STATUS_RF_KILL_HW, &priv->status);
-                        wiphy_rfkill_set_hw_state(priv->hw->wiphy, hw_rf_kill);
-                }
-                handled |= CSR_INT_BIT_RF_KILL;
-        }
-        /* Chip got too hot and stopped itself */
-        if (inta & CSR_INT_BIT_CT_KILL) {
-                IWL_ERR(priv, "Microcode CT kill error detected.\n");
-                priv->isr_stats.ctkill++;
-                handled |= CSR_INT_BIT_CT_KILL;
-        }
-        /* Error detected by uCode */
-        if (inta & CSR_INT_BIT_SW_ERR) {
-                IWL_ERR(priv, "Microcode SW error detected. "
-                        " Restarting 0x%X.\n", inta);
-                priv->isr_stats.sw++;
-                iwl_irq_handle_error(priv);
-                handled |= CSR_INT_BIT_SW_ERR;
-        }
-        /*
-         * uCode wakes up after power-down sleep.
-         * Tell device about any new tx or host commands enqueued,
-         * and about any Rx buffers made available while asleep.
-         */
-        if (inta & CSR_INT_BIT_WAKEUP) {
-                IWL_DEBUG_ISR(priv, "Wakeup interrupt\n");
-                iwl_rx_queue_update_write_ptr(priv, &priv->rxq);
-                for (i = 0; i < priv->hw_params.max_txq_num; i++)
-                        iwl_txq_update_write_ptr(priv, &priv->txq[i]);
-                priv->isr_stats.wakeup++;
-                handled |= CSR_INT_BIT_WAKEUP;
-        }
-        /* All uCode command responses, including Tx command responses,
-         * Rx "responses" (frame-received notification), and other
-         * notifications from uCode come through here*/
-        if (inta & (CSR_INT_BIT_FH_RX | CSR_INT_BIT_SW_RX)) {
-                iwl_rx_handle(priv);
-                priv->isr_stats.rx++;
-                handled |= (CSR_INT_BIT_FH_RX | CSR_INT_BIT_SW_RX);
-        }
-        /* This "Tx" DMA channel is used only for loading uCode */
-        if (inta & CSR_INT_BIT_FH_TX) {
-                IWL_DEBUG_ISR(priv, "uCode load interrupt\n");
-                priv->isr_stats.tx++;
-                handled |= CSR_INT_BIT_FH_TX;
-                /* Wake up uCode load routine, now that load is complete */
-                priv->ucode_write_complete = 1;
-                wake_up_interruptible(&priv->wait_command_queue);
-        }
-        if (inta & ~handled) {
-                IWL_ERR(priv, "Unhandled INTA bits 0x%08x\n", inta & ~handled);
-                priv->isr_stats.unhandled++;
-        }
-        if (inta & ~(priv->inta_mask)) {
-                IWL_WARN(priv, "Disabled INTA bits 0x%08x were pending\n",
-                         inta & ~priv->inta_mask);
-                IWL_WARN(priv, "   with FH_INT = 0x%08x\n", inta_fh);
-        }
-        /* Re-enable all interrupts */
-        /* only Re-enable if disabled by irq */
-        if (test_bit(STATUS_INT_ENABLED, &priv->status))
-                iwl_enable_interrupts(priv);
-        /* Re-enable RF_KILL if it occurred */
-        else if (handled & CSR_INT_BIT_RF_KILL)
-                iwl_enable_rfkill_int(priv);
-#ifdef CONFIG_IWLWIFI_DEBUG
-        if (iwl_get_debug_level(priv) & (IWL_DL_ISR)) {
-                inta = iwl_read32(priv, CSR_INT);
-                inta_mask = iwl_read32(priv, CSR_INT_MASK);
-                inta_fh = iwl_read32(priv, CSR_FH_INT_STATUS);
-                IWL_DEBUG_ISR(priv, "End inta 0x%08x, enabled 0x%08x, fh 0x%08x, "
-                        "flags 0x%08lx\n", inta, inta_mask, inta_fh, flags);
-        }
-#endif
-}
 /* tasklet for iwlagn interrupt */
 static void iwl_irq_tasklet(struct iwl_priv *priv)
 {
@@ -1171,7 +907,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
                if (inta & (CSR_INT_BIT_FH_RX | CSR_INT_BIT_SW_RX)) {
                        handled |= (CSR_INT_BIT_FH_RX | CSR_INT_BIT_SW_RX);
                        iwl_write32(priv, CSR_FH_INT_STATUS,
-                                        CSR49_FH_INT_RX_MASK);
+                                        CSR_FH_INT_RX_MASK);
                }
                if (inta & CSR_INT_BIT_RX_PERIODIC) {
                        handled |= CSR_INT_BIT_RX_PERIODIC;
@@ -1209,7 +945,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
        /* This "Tx" DMA channel is used only for loading uCode */
        if (inta & CSR_INT_BIT_FH_TX) {
-                iwl_write32(priv, CSR_FH_INT_STATUS, CSR49_FH_INT_TX_MASK);
+                iwl_write32(priv, CSR_FH_INT_STATUS, CSR_FH_INT_TX_MASK);
                IWL_DEBUG_ISR(priv, "uCode load interrupt\n");
                priv->isr_stats.tx++;
                handled |= CSR_INT_BIT_FH_TX;
@@ -1357,26 +1093,48 @@ static struct attribute_group iwl_attribute_group = {
 *
 ******************************************************************************/
-static void iwl_dealloc_ucode_pci(struct iwl_priv *priv)
+static void iwl_free_fw_desc(struct pci_dev *pci_dev, struct fw_desc *desc)
+{
+        if (desc->v_addr)
+                dma_free_coherent(&pci_dev->dev, desc->len,
+                                  desc->v_addr, desc->p_addr);
+        desc->v_addr = NULL;
+        desc->len = 0;
+}
+static void iwl_free_fw_img(struct pci_dev *pci_dev, struct fw_img *img)
+{
+        iwl_free_fw_desc(pci_dev, &img->code);
+        iwl_free_fw_desc(pci_dev, &img->data);
+}
+static int iwl_alloc_fw_desc(struct pci_dev *pci_dev, struct fw_desc *desc,
+                             const void *data, size_t len)
 {
-        iwl_free_fw_desc(priv->pci_dev, &priv->ucode_code);
+        if (!len) {
-        iwl_free_fw_desc(priv->pci_dev, &priv->ucode_data);
+                desc->v_addr = NULL;
-        iwl_free_fw_desc(priv->pci_dev, &priv->ucode_data_backup);
+                return -EINVAL;
-        iwl_free_fw_desc(priv->pci_dev, &priv->ucode_init);
+        }
-        iwl_free_fw_desc(priv->pci_dev, &priv->ucode_init_data);
-        iwl_free_fw_desc(priv->pci_dev, &priv->ucode_boot);
+        desc->v_addr = dma_alloc_coherent(&pci_dev->dev, len,
+                                          &desc->p_addr, GFP_KERNEL);
+        if (!desc->v_addr)
+                return -ENOMEM;
+        desc->len = len;
+        memcpy(desc->v_addr, data, len);
+        return 0;
 }
-static void iwl_nic_start(struct iwl_priv *priv)
+static void iwl_dealloc_ucode_pci(struct iwl_priv *priv)
 {
-        /* Remove all resets to allow NIC to operate */
+        iwl_free_fw_img(priv->pci_dev, &priv->ucode_rt);
-        iwl_write32(priv, CSR_RESET, 0);
+        iwl_free_fw_img(priv->pci_dev, &priv->ucode_init);
 }
 struct iwlagn_ucode_capabilities {
        u32 max_probe_length;
        u32 standard_phy_calibration_size;
-        bool pan;
+        u32 flags;
 };
 static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context);
@@ -1422,8 +1180,8 @@ static int __must_check iwl_request_firmware(struct iwl_priv *priv, bool first)
 }
 struct iwlagn_firmware_pieces {
-        const void *inst, *data, *init, *init_data, *boot;
+        const void *inst, *data, *init, *init_data;
-        size_t inst_size, data_size, init_size, init_data_size, boot_size;
+        size_t inst_size, data_size, init_size, init_data_size;
        u32 build;
@@ -1444,28 +1202,18 @@ static int iwlagn_load_legacy_firmware(struct iwl_priv *priv,
        switch (api_ver) {
        default:
-                /*
+                hdr_size = 28;
-                 * 4965 doesn't revision the firmware file format
+                if (ucode_raw->size < hdr_size) {
-                 * along with the API version, it always uses v1
+                        IWL_ERR(priv, "File size too small!\n");
-                 * file format.
+                        return -EINVAL;
-                 */
-                if ((priv->hw_rev & CSR_HW_REV_TYPE_MSK) !=
-                                CSR_HW_REV_TYPE_4965) {
-                        hdr_size = 28;
-                        if (ucode_raw->size < hdr_size) {
-                                IWL_ERR(priv, "File size too small!\n");
-                                return -EINVAL;
-                        }
-                        pieces->build = le32_to_cpu(ucode->u.v2.build);
-                        pieces->inst_size = le32_to_cpu(ucode->u.v2.inst_size);
-                        pieces->data_size = le32_to_cpu(ucode->u.v2.data_size);
-                        pieces->init_size = le32_to_cpu(ucode->u.v2.init_size);
-                        pieces->init_data_size = le32_to_cpu(ucode->u.v2.init_data_size);
-                        pieces->boot_size = le32_to_cpu(ucode->u.v2.boot_size);
-                        src = ucode->u.v2.data;
-                        break;
                }
-                /* fall through for 4965 */
+                pieces->build = le32_to_cpu(ucode->u.v2.build);
+                pieces->inst_size = le32_to_cpu(ucode->u.v2.inst_size);
+                pieces->data_size = le32_to_cpu(ucode->u.v2.data_size);
+                pieces->init_size = le32_to_cpu(ucode->u.v2.init_size);
+                pieces->init_data_size = le32_to_cpu(ucode->u.v2.init_data_size);
+                src = ucode->u.v2.data;
+                break;
        case 0:
        case 1:
        case 2:
@@ -1479,7 +1227,6 @@ static int iwlagn_load_legacy_firmware(struct iwl_priv *priv,
                pieces->data_size = le32_to_cpu(ucode->u.v1.data_size);
                pieces->init_size = le32_to_cpu(ucode->u.v1.init_size);
                pieces->init_data_size = le32_to_cpu(ucode->u.v1.init_data_size);
-                pieces->boot_size = le32_to_cpu(ucode->u.v1.boot_size);
                src = ucode->u.v1.data;
                break;
        }
@@ -1487,7 +1234,7 @@ static int iwlagn_load_legacy_firmware(struct iwl_priv *priv,
        /* Verify size of file vs. image size info in file's header */
        if (ucode_raw->size != hdr_size + pieces->inst_size +
                                pieces->data_size + pieces->init_size +
-                                pieces->init_data_size + pieces->boot_size) {
+                                pieces->init_data_size) {
                IWL_ERR(priv,
                        "uCode file size %d does not match expected size\n",
@@ -1503,8 +1250,6 @@ static int iwlagn_load_legacy_firmware(struct iwl_priv *priv,
        src += pieces->init_size;
        pieces->init_data = src;
        src += pieces->init_data_size;
-        pieces->boot = src;
-        src += pieces->boot_size;
        return 0;
 }
@@ -1605,8 +1350,7 @@ static int iwlagn_load_firmware(struct iwl_priv *priv,
                        pieces->init_data_size = tlv_len;
                        break;
                case IWL_UCODE_TLV_BOOT:
-                        pieces->boot = tlv_data;
+                        IWL_ERR(priv, "Found unexpected BOOT ucode\n");
-                        pieces->boot_size = tlv_len;
                        break;
                case IWL_UCODE_TLV_PROBE_MAX_LEN:
                        if (tlv_len != sizeof(u32))
@@ -1617,7 +1361,23 @@ static int iwlagn_load_firmware(struct iwl_priv *priv,
                case IWL_UCODE_TLV_PAN:
                        if (tlv_len)
                                goto invalid_tlv_len;
-                        capa->pan = true;
+                        capa->flags |= IWL_UCODE_TLV_FLAGS_PAN;
+                        break;
+                case IWL_UCODE_TLV_FLAGS:
+                        /* must be at least one u32 */
+                        if (tlv_len < sizeof(u32))
+                                goto invalid_tlv_len;
+                        /* and a proper number of u32s */
+                        if (tlv_len % sizeof(u32))
+                                goto invalid_tlv_len;
+                        /*
+                         * This driver only reads the first u32 as
+                         * right now no more features are defined,
+                         * if that changes then either the driver
+                         * will not work with the new firmware, or
+                         * it'll not take advantage of new features.
+                         */
+                        capa->flags = le32_to_cpup((__le32 *)tlv_data);
                        break;
                case IWL_UCODE_TLV_INIT_EVTLOG_PTR:
                        if (tlv_len != sizeof(u32))
@@ -1667,7 +1427,7 @@ static int iwlagn_load_firmware(struct iwl_priv *priv,
                                        le32_to_cpup((__le32 *)tlv_data);
                        break;
                default:
-                        IWL_WARN(priv, "unknown TLV: %d\n", tlv_type);
+                        IWL_DEBUG_INFO(priv, "unknown TLV: %d\n", tlv_type);
                        break;
                }
        }
@@ -1806,8 +1566,6 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context)
                       pieces.init_size);
        IWL_DEBUG_INFO(priv, "f/w package hdr init data size = %Zd\n",
                       pieces.init_data_size);
-        IWL_DEBUG_INFO(priv, "f/w package hdr boot inst size = %Zd\n",
-                       pieces.boot_size);
        /* Verify that uCode images will fit in card's SRAM */
        if (pieces.inst_size > priv->hw_params.max_inst_size) {
@@ -1834,48 +1592,25 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context)
                goto try_again;
        }
-        if (pieces.boot_size > priv->hw_params.max_bsm_size) {
-                IWL_ERR(priv, "uCode boot instr len %Zd too large to fit in\n",
-                        pieces.boot_size);
-                goto try_again;
-        }
        /* Allocate ucode buffers for card's bus-master loading ... */
        /* Runtime instructions and 2 copies of data:
         * 1) unmodified from disk
         * 2) backup cache for save/restore during power-downs */
-        priv->ucode_code.len = pieces.inst_size;
+        if (iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_rt.code,
-        iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_code);
+                              pieces.inst, pieces.inst_size))
+                goto err_pci_alloc;
-        priv->ucode_data.len = pieces.data_size;
+        if (iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_rt.data,
-        iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_data);
+                              pieces.data, pieces.data_size))
-        priv->ucode_data_backup.len = pieces.data_size;
-        iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_data_backup);
-        if (!priv->ucode_code.v_addr || !priv->ucode_data.v_addr ||
-            !priv->ucode_data_backup.v_addr)
                goto err_pci_alloc;
        /* Initialization instructions and data */
        if (pieces.init_size && pieces.init_data_size) {
-                priv->ucode_init.len = pieces.init_size;
+                if (iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_init.code,
-                iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_init);
+                                      pieces.init, pieces.init_size))
-                priv->ucode_init_data.len = pieces.init_data_size;
-                iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_init_data);
-                if (!priv->ucode_init.v_addr || !priv->ucode_init_data.v_addr)
                        goto err_pci_alloc;
-        }
+                if (iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_init.data,
+                                      pieces.init_data, pieces.init_data_size))
-        /* Bootstrap (instructions only, no data) */
-        if (pieces.boot_size) {
-                priv->ucode_boot.len = pieces.boot_size;
-                iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_boot);
-                if (!priv->ucode_boot.v_addr)
                        goto err_pci_alloc;
        }
@@ -1901,50 +1636,19 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context)
                        priv->cfg->base_params->max_event_log_size;
        priv->_agn.inst_errlog_ptr = pieces.inst_errlog_ptr;
-        if (ucode_capa.pan) {
+        priv->new_scan_threshold_behaviour =
+                !!(ucode_capa.flags & IWL_UCODE_TLV_FLAGS_NEWSCAN);
+        if (ucode_capa.flags & IWL_UCODE_TLV_FLAGS_PAN) {
                priv->valid_contexts |= BIT(IWL_RXON_CTX_PAN);
                priv->sta_key_max_num = STA_KEY_MAX_NUM_PAN;
        } else
                priv->sta_key_max_num = STA_KEY_MAX_NUM;
-        /* Copy images into buffers for card's bus-master reads ... */
+        if (priv->valid_contexts != BIT(IWL_RXON_CTX_BSS))
+                priv->cmd_queue = IWL_IPAN_CMD_QUEUE_NUM;
-        /* Runtime instructions (first block of data in file) */
+        else
-        IWL_DEBUG_INFO(priv, "Copying (but not loading) uCode instr len %Zd\n",
+                priv->cmd_queue = IWL_DEFAULT_CMD_QUEUE_NUM;
-                        pieces.inst_size);
-        memcpy(priv->ucode_code.v_addr, pieces.inst, pieces.inst_size);
-        IWL_DEBUG_INFO(priv, "uCode instr buf vaddr = 0x%p, paddr = 0x%08x\n",
-                priv->ucode_code.v_addr, (u32)priv->ucode_code.p_addr);
-        /*
-         * Runtime data
-         * NOTE:  Copy into backup buffer will be done in iwl_up()
-         */
-        IWL_DEBUG_INFO(priv, "Copying (but not loading) uCode data len %Zd\n",
-                        pieces.data_size);
-        memcpy(priv->ucode_data.v_addr, pieces.data, pieces.data_size);
-        memcpy(priv->ucode_data_backup.v_addr, pieces.data, pieces.data_size);
-        /* Initialization instructions */
-        if (pieces.init_size) {
-                IWL_DEBUG_INFO(priv, "Copying (but not loading) init instr len %Zd\n",
-                                pieces.init_size);
-                memcpy(priv->ucode_init.v_addr, pieces.init, pieces.init_size);
-        }
-        /* Initialization data */
-        if (pieces.init_data_size) {
-                IWL_DEBUG_INFO(priv, "Copying (but not loading) init data len %Zd\n",
-                               pieces.init_data_size);
-                memcpy(priv->ucode_init_data.v_addr, pieces.init_data,
-                       pieces.init_data_size);
-        }
-        /* Bootstrap instructions */
-        IWL_DEBUG_INFO(priv, "Copying (but not loading) boot instr len %Zd\n",
-                        pieces.boot_size);
-        memcpy(priv->ucode_boot.v_addr, pieces.boot, pieces.boot_size);
        /*
         * figure out the offset of chain noise reset and gain commands
@@ -2076,13 +1780,13 @@ void iwl_dump_nic_error_log(struct iwl_priv *priv)
        u32 desc, time, count, base, data1;
        u32 blink1, blink2, ilink1, ilink2;
        u32 pc, hcmd;
+        struct iwl_error_event_table table;
-        if (priv->ucode_type == UCODE_INIT) {
+        base = priv->device_pointers.error_event_table;
-                base = le32_to_cpu(priv->card_alive_init.error_event_table_ptr);
+        if (priv->ucode_type == UCODE_SUBTYPE_INIT) {
                if (!base)
                        base = priv->_agn.init_errlog_ptr;
        } else {
-                base = le32_to_cpu(priv->card_alive.error_event_table_ptr);
                if (!base)
                        base = priv->_agn.inst_errlog_ptr;
        }
@@ -2090,11 +1794,15 @@ void iwl_dump_nic_error_log(struct iwl_priv *priv)
        if (!priv->cfg->ops->lib->is_valid_rtc_data_addr(base)) {
                IWL_ERR(priv,
                        "Not valid error log pointer 0x%08X for %s uCode\n",
-                        base, (priv->ucode_type == UCODE_INIT) ? "Init" : "RT");
+                        base,
+                        (priv->ucode_type == UCODE_SUBTYPE_INIT)
+                                        ? "Init" : "RT");
                return;
        }
-        count = iwl_read_targ_mem(priv, base);
+        iwl_read_targ_mem_words(priv, base, &table, sizeof(table));
+        count = table.valid;
        if (ERROR_START_OFFSET <= count * ERROR_ELEM_SIZE) {
                IWL_ERR(priv, "Start IWL Error Log Dump:\n");
@@ -2102,18 +1810,18 @@ void iwl_dump_nic_error_log(struct iwl_priv *priv)
                        priv->status, count);
        }
-        desc = iwl_read_targ_mem(priv, base + 1 * sizeof(u32));
+        desc = table.error_id;
        priv->isr_stats.err_code = desc;
-        pc = iwl_read_targ_mem(priv, base + 2 * sizeof(u32));
+        pc = table.pc;
-        blink1 = iwl_read_targ_mem(priv, base + 3 * sizeof(u32));
+        blink1 = table.blink1;
-        blink2 = iwl_read_targ_mem(priv, base + 4 * sizeof(u32));
+        blink2 = table.blink2;
-        ilink1 = iwl_read_targ_mem(priv, base + 5 * sizeof(u32));
+        ilink1 = table.ilink1;
-        ilink2 = iwl_read_targ_mem(priv, base + 6 * sizeof(u32));
+        ilink2 = table.ilink2;
-        data1 = iwl_read_targ_mem(priv, base + 7 * sizeof(u32));
+        data1 = table.data1;
-        data2 = iwl_read_targ_mem(priv, base + 8 * sizeof(u32));
+        data2 = table.data2;
-        line = iwl_read_targ_mem(priv, base + 9 * sizeof(u32));
+        line = table.line;
-        time = iwl_read_targ_mem(priv, base + 11 * sizeof(u32));
+        time = table.tsf_low;
-        hcmd = iwl_read_targ_mem(priv, base + 22 * sizeof(u32));
+        hcmd = table.hcmd;
        trace_iwlwifi_dev_ucode_error(priv, desc, time, data1, data2, line,
                                      blink1, blink2, ilink1, ilink2);
@@ -2147,12 +1855,11 @@ static int iwl_print_event_log(struct iwl_priv *priv, u32 start_idx,
        if (num_events == 0)
                return pos;
-        if (priv->ucode_type == UCODE_INIT) {
+        base = priv->device_pointers.log_event_table;
-                base = le32_to_cpu(priv->card_alive_init.log_event_table_ptr);
+        if (priv->ucode_type == UCODE_SUBTYPE_INIT) {
                if (!base)
                        base = priv->_agn.init_evtlog_ptr;
        } else {
-                base = le32_to_cpu(priv->card_alive.log_event_table_ptr);
                if (!base)
                        base = priv->_agn.inst_evtlog_ptr;
        }
@@ -2169,14 +1876,14 @@ static int iwl_print_event_log(struct iwl_priv *priv, u32 start_idx,
        iwl_grab_nic_access(priv);
        /* Set starting address; reads will auto-increment */
-        _iwl_write_direct32(priv, HBUS_TARG_MEM_RADDR, ptr);
+        iwl_write32(priv, HBUS_TARG_MEM_RADDR, ptr);
        rmb();
        /* "time" is actually "data" for mode 0 (no timestamp).
        * place event id # at far right for easier visual parsing. */
        for (i = 0; i < num_events; i++) {
-                ev = _iwl_read_direct32(priv, HBUS_TARG_MEM_RDAT);
+                ev = iwl_read32(priv, HBUS_TARG_MEM_RDAT);
-                time = _iwl_read_direct32(priv, HBUS_TARG_MEM_RDAT);
+                time = iwl_read32(priv, HBUS_TARG_MEM_RDAT);
                if (mode == 0) {
                        /* data, ev */
                        if (bufsz) {
@@ -2190,7 +1897,7 @@ static int iwl_print_event_log(struct iwl_priv *priv, u32 start_idx,
                                        time, ev);
                        }
                } else {
-                        data = _iwl_read_direct32(priv, HBUS_TARG_MEM_RDAT);
+                        data = iwl_read32(priv, HBUS_TARG_MEM_RDAT);
                        if (bufsz) {
                                pos += scnprintf(*buf + pos, bufsz - pos,
                                                "EVT_LOGT:%010u:0x%08x:%04u\n",
@@ -2261,13 +1968,12 @@ int iwl_dump_nic_event_log(struct iwl_priv *priv, bool full_log,
        int pos = 0;
        size_t bufsz = 0;
-        if (priv->ucode_type == UCODE_INIT) {
+        base = priv->device_pointers.log_event_table;
-                base = le32_to_cpu(priv->card_alive_init.log_event_table_ptr);
+        if (priv->ucode_type == UCODE_SUBTYPE_INIT) {
                logsize = priv->_agn.init_evtlog_size;
                if (!base)
                        base = priv->_agn.init_evtlog_ptr;
        } else {
-                base = le32_to_cpu(priv->card_alive.log_event_table_ptr);
                logsize = priv->_agn.inst_evtlog_size;
                if (!base)
                        base = priv->_agn.inst_evtlog_ptr;
@@ -2276,7 +1982,9 @@ int iwl_dump_nic_event_log(struct iwl_priv *priv, bool full_log,
        if (!priv->cfg->ops->lib->is_valid_rtc_data_addr(base)) {
                IWL_ERR(priv,
                        "Invalid event log pointer 0x%08X for %s uCode\n",
-                        base, (priv->ucode_type == UCODE_INIT) ? "Init" : "RT");
+                        base,
+                        (priv->ucode_type == UCODE_SUBTYPE_INIT)
+                                        ? "Init" : "RT");
                return -EINVAL;
        }
@@ -2423,30 +2131,14 @@ static int iwlagn_send_calib_cfg_rt(struct iwl_priv *priv, u32 cfg)
 *                   from protocol/runtime uCode (initialization uCode's
 *                   Alive gets handled by iwl_init_alive_start()).
 */
-static void iwl_alive_start(struct iwl_priv *priv)
+int iwl_alive_start(struct iwl_priv *priv)
 {
        int ret = 0;
        struct iwl_rxon_context *ctx = &priv->contexts[IWL_RXON_CTX_BSS];
-        IWL_DEBUG_INFO(priv, "Runtime Alive received.\n");
+        iwl_reset_ict(priv);
-        /* Initialize uCode has loaded Runtime uCode ... verify inst image.
-         * This is a paranoid check, because we would not have gotten the
-         * "runtime" alive if code weren't properly loaded.  */
-        if (iwl_verify_ucode(priv)) {
-                /* Runtime instruction load was bad;
-                 * take it all the way back down so we can try again */
-                IWL_DEBUG_INFO(priv, "Bad runtime uCode load.\n");
-                goto restart;
-        }
-        ret = priv->cfg->ops->lib->alive_notify(priv);
-        if (ret) {
-                IWL_WARN(priv,
-                        "Could not complete ALIVE transition [ntf]: %d\n", ret);
-                goto restart;
-        }
+        IWL_DEBUG_INFO(priv, "Runtime Alive received.\n");
        /* After the ALIVE response, we can send host commands to the uCode */
        set_bit(STATUS_ALIVE, &priv->status);
@@ -2455,7 +2147,7 @@ static void iwl_alive_start(struct iwl_priv *priv)
        iwl_setup_watchdog(priv);
        if (iwl_is_rfkill(priv))
-                return;
+                return -ERFKILL;
        /* download priority table before any calibration request */
        if (priv->cfg->bt_params &&
@@ -2469,10 +2161,14 @@ static void iwl_alive_start(struct iwl_priv *priv)
                iwlagn_send_prio_tbl(priv);
                /* FIXME: w/a to force change uCode BT state machine */
-                iwlagn_send_bt_env(priv, IWL_BT_COEX_ENV_OPEN,
+                ret = iwlagn_send_bt_env(priv, IWL_BT_COEX_ENV_OPEN,
-                        BT_COEX_PRIO_TBL_EVT_INIT_CALIB2);
+                                         BT_COEX_PRIO_TBL_EVT_INIT_CALIB2);
-                iwlagn_send_bt_env(priv, IWL_BT_COEX_ENV_CLOSE,
+                if (ret)
-                        BT_COEX_PRIO_TBL_EVT_INIT_CALIB2);
+                        return ret;
+                ret = iwlagn_send_bt_env(priv, IWL_BT_COEX_ENV_CLOSE,
+                                         BT_COEX_PRIO_TBL_EVT_INIT_CALIB2);
+                if (ret)
+                        return ret;
        }
        if (priv->hw_params.calib_rt_cfg)
                iwlagn_send_calib_cfg_rt(priv, priv->hw_params.calib_rt_cfg);
@@ -2514,30 +2210,23 @@ static void iwl_alive_start(struct iwl_priv *priv)
        set_bit(STATUS_READY, &priv->status);
        /* Configure the adapter for unassociated operation */
-        iwlcore_commit_rxon(priv, ctx);
+        ret = iwlcore_commit_rxon(priv, ctx);
+        if (ret)
+                return ret;
        /* At this point, the NIC is initialized and operational */
        iwl_rf_kill_ct_config(priv);
        IWL_DEBUG_INFO(priv, "ALIVE processing complete.\n");
-        wake_up_interruptible(&priv->wait_command_queue);
-        iwl_power_update_mode(priv, true);
-        IWL_DEBUG_INFO(priv, "Updated power mode\n");
+        return iwl_power_update_mode(priv, true);
-        return;
- restart:
-        queue_work(priv->workqueue, &priv->restart);
 }
 static void iwl_cancel_deferred_work(struct iwl_priv *priv);
 static void __iwl_down(struct iwl_priv *priv)
 {
-        unsigned long flags;
+        int exit_pending;
-        int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
        IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");
@@ -2563,40 +2252,15 @@ static void __iwl_down(struct iwl_priv *priv)
        priv->bt_full_concurrent = false;
        priv->bt_ci_compliance = 0;
-        /* Unblock any waiting calls */
-        wake_up_interruptible_all(&priv->wait_command_queue);
        /* Wipe out the EXIT_PENDING status bit if we are not actually
         * exiting the module */
        if (!exit_pending)
                clear_bit(STATUS_EXIT_PENDING, &priv->status);
-        /* stop and reset the on-board processor */
-        iwl_write32(priv, CSR_RESET, CSR_RESET_REG_FLAG_NEVO_RESET);
-        /* tell the device to stop sending interrupts */
-        spin_lock_irqsave(&priv->lock, flags);
-        iwl_disable_interrupts(priv);
-        spin_unlock_irqrestore(&priv->lock, flags);
-        iwl_synchronize_irq(priv);
        if (priv->mac80211_registered)
                ieee80211_stop_queues(priv->hw);
-        /* If we have not previously called iwl_init() then
+        /* Clear out all status bits but a few that are stable across reset */
-         * clear all bits but the RF Kill bit and return */
-        if (!iwl_is_init(priv)) {
-                priv->status = test_bit(STATUS_RF_KILL_HW, &priv->status) <<
-                                        STATUS_RF_KILL_HW |
-                               test_bit(STATUS_GEO_CONFIGURED, &priv->status) <<
-                                        STATUS_GEO_CONFIGURED |
-                               test_bit(STATUS_EXIT_PENDING, &priv->status) <<
-                                        STATUS_EXIT_PENDING;
-                goto exit;
-        }
-        /* ...otherwise clear out all the status bits but the RF Kill
-         * bit and continue taking the NIC down. */
        priv->status &= test_bit(STATUS_RF_KILL_HW, &priv->status) <<
                                STATUS_RF_KILL_HW |
                        test_bit(STATUS_GEO_CONFIGURED, &priv->status) <<
@@ -2606,31 +2270,10 @@ static void __iwl_down(struct iwl_priv *priv)
                       test_bit(STATUS_EXIT_PENDING, &priv->status) <<
                                STATUS_EXIT_PENDING;
-        /* device going down, Stop using ICT table */
+        iwlagn_stop_device(priv);
-        if (priv->cfg->ops->lib->isr_ops.disable)
-                priv->cfg->ops->lib->isr_ops.disable(priv);
-        iwlagn_txq_ctx_stop(priv);
-        iwlagn_rxq_stop(priv);
-        /* Power-down device's busmaster DMA clocks */
-        iwl_write_prph(priv, APMG_CLK_DIS_REG, APMG_CLK_VAL_DMA_CLK_RQT);
-        udelay(5);
-        /* Make sure (redundant) we've released our request to stay awake */
-        iwl_clear_bit(priv, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_MAC_ACCESS_REQ);
-        /* Stop the device, and put it in low power state */
-        iwl_apm_stop(priv);
- exit:
-        memset(&priv->card_alive, 0, sizeof(struct iwl_alive_resp));
        dev_kfree_skb(priv->beacon_skb);
        priv->beacon_skb = NULL;
-        /* clear out any free frames */
-        iwl_clear_free_frames(priv);
 }
 static void iwl_down(struct iwl_priv *priv)
@@ -2644,9 +2287,10 @@ static void iwl_down(struct iwl_priv *priv)
 #define HW_READY_TIMEOUT (50)
+/* Note: returns poll_bit return value, which is >= 0 if success */
 static int iwl_set_hw_ready(struct iwl_priv *priv)
 {
-        int ret = 0;
+        int ret;
        iwl_set_bit(priv, CSR_HW_IF_CONFIG_REG,
                CSR_HW_IF_CONFIG_REG_BIT_NIC_READY);
@@ -2656,25 +2300,21 @@ static int iwl_set_hw_ready(struct iwl_priv *priv)
                                CSR_HW_IF_CONFIG_REG_BIT_NIC_READY,
                                CSR_HW_IF_CONFIG_REG_BIT_NIC_READY,
                                HW_READY_TIMEOUT);
-        if (ret != -ETIMEDOUT)
-                priv->hw_ready = true;
-        else
-                priv->hw_ready = false;
-        IWL_DEBUG_INFO(priv, "hardware %s\n",
+        IWL_DEBUG_INFO(priv, "hardware%s ready\n", ret < 0 ? " not" : "");
-                      (priv->hw_ready == 1) ? "ready" : "not ready");
        return ret;
 }
-static int iwl_prepare_card_hw(struct iwl_priv *priv)
+/* Note: returns standard 0/-ERROR code */
+int iwl_prepare_card_hw(struct iwl_priv *priv)
 {
-        int ret = 0;
+        int ret;
        IWL_DEBUG_INFO(priv, "iwl_prepare_card_hw enter\n");
        ret = iwl_set_hw_ready(priv);
-        if (priv->hw_ready)
+        if (ret >= 0)
-                return ret;
+                return 0;
        /* If HW is not ready, prepare the conditions to check again */
        iwl_set_bit(priv, CSR_HW_IF_CONFIG_REG,
@@ -2684,10 +2324,13 @@ static int iwl_prepare_card_hw(struct iwl_priv *priv)
                        ~CSR_HW_IF_CONFIG_REG_BIT_NIC_PREPARE_DONE,
                        CSR_HW_IF_CONFIG_REG_BIT_NIC_PREPARE_DONE, 150000);
-        /* HW should be ready by now, check again. */
+        if (ret < 0)
-        if (ret != -ETIMEDOUT)
+                return ret;
-                iwl_set_hw_ready(priv);
+        /* HW should be ready by now, check again. */
+        ret = iwl_set_hw_ready(priv);
+        if (ret >= 0)
+                return 0;
        return ret;
 }
@@ -2696,19 +2339,15 @@ static int iwl_prepare_card_hw(struct iwl_priv *priv)
 static int __iwl_up(struct iwl_priv *priv)
 {
        struct iwl_rxon_context *ctx;
-        int i;
        int ret;
+        lockdep_assert_held(&priv->mutex);
        if (test_bit(STATUS_EXIT_PENDING, &priv->status)) {
                IWL_WARN(priv, "Exit pending; will not bring the NIC up\n");
                return -EIO;
        }
-        if (!priv->ucode_data_backup.v_addr || !priv->ucode_data.v_addr) {
-                IWL_ERR(priv, "ucode not available for device bringup\n");
-                return -EIO;
-        }
        for_each_context(priv, ctx) {
                ret = iwlagn_alloc_bcast_station(priv, ctx);
                if (ret) {
@@ -2717,89 +2356,33 @@ static int __iwl_up(struct iwl_priv *priv)
                }
        }
-        iwl_prepare_card_hw(priv);
+        ret = iwlagn_run_init_ucode(priv);
+        if (ret) {
-        if (!priv->hw_ready) {
+                IWL_ERR(priv, "Failed to run INIT ucode: %d\n", ret);
-                IWL_WARN(priv, "Exit HW not ready\n");
+                goto error;
-                return -EIO;
-        }
-        /* If platform's RF_KILL switch is NOT set to KILL */
-        if (iwl_read32(priv, CSR_GP_CNTRL) & CSR_GP_CNTRL_REG_FLAG_HW_RF_KILL_SW)
-                clear_bit(STATUS_RF_KILL_HW, &priv->status);
-        else
-                set_bit(STATUS_RF_KILL_HW, &priv->status);
-        if (iwl_is_rfkill(priv)) {
-                wiphy_rfkill_set_hw_state(priv->hw->wiphy, true);
-                iwl_enable_interrupts(priv);
-                IWL_WARN(priv, "Radio disabled by HW RF Kill switch\n");
-                return 0;
        }
-        iwl_write32(priv, CSR_INT, 0xFFFFFFFF);
+        ret = iwlagn_load_ucode_wait_alive(priv,
+                                           &priv->ucode_rt,
-        /* must be initialised before iwl_hw_nic_init */
+                                           UCODE_SUBTYPE_REGULAR,
-        if (priv->valid_contexts != BIT(IWL_RXON_CTX_BSS))
+                                           UCODE_SUBTYPE_REGULAR_NEW);
-                priv->cmd_queue = IWL_IPAN_CMD_QUEUE_NUM;
-        else
-                priv->cmd_queue = IWL_DEFAULT_CMD_QUEUE_NUM;
-        ret = iwlagn_hw_nic_init(priv);
        if (ret) {
-                IWL_ERR(priv, "Unable to init nic\n");
+                IWL_ERR(priv, "Failed to start RT ucode: %d\n", ret);
-                return ret;
+                goto error;
        }
-        /* make sure rfkill handshake bits are cleared */
+        ret = iwl_alive_start(priv);
-        iwl_write32(priv, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL);
+        if (ret)
-        iwl_write32(priv, CSR_UCODE_DRV_GP1_CLR,
+                goto error;
-                    CSR_UCODE_DRV_GP1_BIT_CMD_BLOCKED);
+        return 0;
-        /* clear (again), then enable host interrupts */
-        iwl_write32(priv, CSR_INT, 0xFFFFFFFF);
-        iwl_enable_interrupts(priv);
-        /* really make sure rfkill handshake bits are cleared */
-        iwl_write32(priv, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL);
-        iwl_write32(priv, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL);
-        /* Copy original ucode data image from disk into backup cache.
-         * This will be used to initialize the on-board processor's
-         * data SRAM for a clean start when the runtime program first loads. */
-        memcpy(priv->ucode_data_backup.v_addr, priv->ucode_data.v_addr,
-               priv->ucode_data.len);
-        for (i = 0; i < MAX_HW_RESTARTS; i++) {
-                /* load bootstrap state machine,
-                 * load bootstrap program into processor's memory,
-                 * prepare to load the "initialize" uCode */
-                ret = priv->cfg->ops->lib->load_ucode(priv);
-                if (ret) {
-                        IWL_ERR(priv, "Unable to set up bootstrap uCode: %d\n",
-                                ret);
-                        continue;
-                }
-                /* start card; "initialize" will load runtime ucode */
-                iwl_nic_start(priv);
-                IWL_DEBUG_INFO(priv, DRV_NAME " is coming up\n");
-                return 0;
-        }
+ error:
        set_bit(STATUS_EXIT_PENDING, &priv->status);
        __iwl_down(priv);
        clear_bit(STATUS_EXIT_PENDING, &priv->status);
-        /* tried to restart and config the device for as long as our
+        IWL_ERR(priv, "Unable to initialize device.\n");
-         * patience could withstand */
+        return ret;
-        IWL_ERR(priv, "Unable to initialize device after %d attempts.\n", i);
-        return -EIO;
 }
@@ -2809,36 +2392,6 @@ static int __iwl_up(struct iwl_priv *priv)
 *
 *****************************************************************************/
-static void iwl_bg_init_alive_start(struct work_struct *data)
-{
-        struct iwl_priv *priv =
-            container_of(data, struct iwl_priv, init_alive_start.work);
-        if (test_bit(STATUS_EXIT_PENDING, &priv->status))
-                return;
-        mutex_lock(&priv->mutex);
-        priv->cfg->ops->lib->init_alive_start(priv);
-        mutex_unlock(&priv->mutex);
-}
-static void iwl_bg_alive_start(struct work_struct *data)
-{
-        struct iwl_priv *priv =
-            container_of(data, struct iwl_priv, alive_start.work);
-        if (test_bit(STATUS_EXIT_PENDING, &priv->status))
-                return;
-        /* enable dram interrupt */
-        if (priv->cfg->ops->lib->isr_ops.reset)
-                priv->cfg->ops->lib->isr_ops.reset(priv);
-        mutex_lock(&priv->mutex);
-        iwl_alive_start(priv);
-        mutex_unlock(&priv->mutex);
-}
 static void iwl_bg_run_time_calib_work(struct work_struct *work)
 {
        struct iwl_priv *priv = container_of(work, struct iwl_priv,
@@ -2853,22 +2406,49 @@ static void iwl_bg_run_time_calib_work(struct work_struct *work)
        }
        if (priv->start_calib) {
-                if (iwl_bt_statistics(priv)) {
+                iwl_chain_noise_calibration(priv);
-                        iwl_chain_noise_calibration(priv,
+                iwl_sensitivity_calibration(priv);
-                                        (void *)&priv->_agn.statistics_bt);
-                        iwl_sensitivity_calibration(priv,
-                                        (void *)&priv->_agn.statistics_bt);
-                } else {
-                        iwl_chain_noise_calibration(priv,
-                                        (void *)&priv->_agn.statistics);
-                        iwl_sensitivity_calibration(priv,
-                                        (void *)&priv->_agn.statistics);
-                }
        }
        mutex_unlock(&priv->mutex);
 }
+static void iwlagn_prepare_restart(struct iwl_priv *priv)
+{
+        struct iwl_rxon_context *ctx;
+        bool bt_full_concurrent;
+        u8 bt_ci_compliance;
+        u8 bt_load;
+        u8 bt_status;
+        lockdep_assert_held(&priv->mutex);
+        for_each_context(priv, ctx)
+                ctx->vif = NULL;
+        priv->is_open = 0;
+        /*
+         * __iwl_down() will clear the BT status variables,
+         * which is correct, but when we restart we really
+         * want to keep them so restore them afterwards.
+         *
+         * The restart process will later pick them up and
+         * re-configure the hw when we reconfigure the BT
+         * command.
+         */
+        bt_full_concurrent = priv->bt_full_concurrent;
+        bt_ci_compliance = priv->bt_ci_compliance;
+        bt_load = priv->bt_traffic_load;
+        bt_status = priv->bt_status;
+        __iwl_down(priv);
+        priv->bt_full_concurrent = bt_full_concurrent;
+        priv->bt_ci_compliance = bt_ci_compliance;
+        priv->bt_traffic_load = bt_load;
+        priv->bt_status = bt_status;
+}
 static void iwl_bg_restart(struct work_struct *data)
 {
        struct iwl_priv *priv = container_of(data, struct iwl_priv, restart);
@@ -2877,50 +2457,13 @@ static void iwl_bg_restart(struct work_struct *data)
                return;
        if (test_and_clear_bit(STATUS_FW_ERROR, &priv->status)) {
-                struct iwl_rxon_context *ctx;
-                bool bt_full_concurrent;
-                u8 bt_ci_compliance;
-                u8 bt_load;
-                u8 bt_status;
                mutex_lock(&priv->mutex);
-                for_each_context(priv, ctx)
+                iwlagn_prepare_restart(priv);
-                        ctx->vif = NULL;
-                priv->is_open = 0;
-                /*
-                 * __iwl_down() will clear the BT status variables,
-                 * which is correct, but when we restart we really
-                 * want to keep them so restore them afterwards.
-                 *
-                 * The restart process will later pick them up and
-                 * re-configure the hw when we reconfigure the BT
-                 * command.
-                 */
-                bt_full_concurrent = priv->bt_full_concurrent;
-                bt_ci_compliance = priv->bt_ci_compliance;
-                bt_load = priv->bt_traffic_load;
-                bt_status = priv->bt_status;
-                __iwl_down(priv);
-                priv->bt_full_concurrent = bt_full_concurrent;
-                priv->bt_ci_compliance = bt_ci_compliance;
-                priv->bt_traffic_load = bt_load;
-                priv->bt_status = bt_status;
                mutex_unlock(&priv->mutex);
                iwl_cancel_deferred_work(priv);
                ieee80211_restart_hw(priv->hw);
        } else {
-                iwl_down(priv);
+                WARN_ON(1);
-                if (test_bit(STATUS_EXIT_PENDING, &priv->status))
-                        return;
-                mutex_lock(&priv->mutex);
-                __iwl_up(priv);
-                mutex_unlock(&priv->mutex);
        }
 }
@@ -3031,8 +2574,6 @@ unlock:
 *
 *****************************************************************************/
-#define UCODE_READY_TIMEOUT     (4 * HZ)
 /*
 * Not a mac80211 entry point function, but it fits in with all the
 * other mac80211 functions grouped here.
@@ -3055,14 +2596,16 @@ static int iwl_mac_setup_register(struct iwl_priv *priv,
        hw->max_tx_aggregation_subframes = LINK_QUAL_AGG_FRAME_LIMIT_DEF;
-        if (!priv->cfg->base_params->broken_powersave)
+        hw->flags |= IEEE80211_HW_SUPPORTS_PS |
-                hw->flags |= IEEE80211_HW_SUPPORTS_PS |
+                     IEEE80211_HW_SUPPORTS_DYNAMIC_PS;
-                             IEEE80211_HW_SUPPORTS_DYNAMIC_PS;
        if (priv->cfg->sku & IWL_SKU_N)
                hw->flags |= IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS |
                             IEEE80211_HW_SUPPORTS_STATIC_SMPS;
+        if (capa->flags & IWL_UCODE_TLV_FLAGS_MFP)
+                hw->flags |= IEEE80211_HW_MFP_CAPABLE;
        hw->sta_data_size = sizeof(struct iwl_station_priv);
        hw->vif_data_size = sizeof(struct iwl_vif_priv);
@@ -3112,7 +2655,7 @@ static int iwl_mac_setup_register(struct iwl_priv *priv,
 }
-int iwlagn_mac_start(struct ieee80211_hw *hw)
+static int iwlagn_mac_start(struct ieee80211_hw *hw)
 {
        struct iwl_priv *priv = hw->priv;
        int ret;
@@ -3123,37 +2666,23 @@ int iwlagn_mac_start(struct ieee80211_hw *hw)
        mutex_lock(&priv->mutex);
        ret = __iwl_up(priv);
        mutex_unlock(&priv->mutex);
        if (ret)
                return ret;
-        if (iwl_is_rfkill(priv))
-                goto out;
        IWL_DEBUG_INFO(priv, "Start UP work done.\n");
-        /* Wait for START_ALIVE from Run Time ucode. Otherwise callbacks from
+        /* Now we should be done, and the READY bit should be set. */
-         * mac80211 will not be run successfully. */
+        if (WARN_ON(!test_bit(STATUS_READY, &priv->status)))
-        ret = wait_event_interruptible_timeout(priv->wait_command_queue,
+                ret = -EIO;
-                        test_bit(STATUS_READY, &priv->status),
-                        UCODE_READY_TIMEOUT);
-        if (!ret) {
-                if (!test_bit(STATUS_READY, &priv->status)) {
-                        IWL_ERR(priv, "START_ALIVE timeout after %dms.\n",
-                                jiffies_to_msecs(UCODE_READY_TIMEOUT));
-                        return -ETIMEDOUT;
-                }
-        }
        iwlagn_led_enable(priv);
-out:
        priv->is_open = 1;
        IWL_DEBUG_MAC80211(priv, "leave\n");
        return 0;
 }
-void iwlagn_mac_stop(struct ieee80211_hw *hw)
+static void iwlagn_mac_stop(struct ieee80211_hw *hw)
 {
        struct iwl_priv *priv = hw->priv;
@@ -3176,7 +2705,7 @@ void iwlagn_mac_stop(struct ieee80211_hw *hw)
        IWL_DEBUG_MAC80211(priv, "leave\n");
 }
-void iwlagn_mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
+static void iwlagn_mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
 {
        struct iwl_priv *priv = hw->priv;
@@ -3191,11 +2720,11 @@ void iwlagn_mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
        IWL_DEBUG_MACDUMP(priv, "leave\n");
 }
-void iwlagn_mac_update_tkip_key(struct ieee80211_hw *hw,
+static void iwlagn_mac_update_tkip_key(struct ieee80211_hw *hw,
-                                struct ieee80211_vif *vif,
+                                       struct ieee80211_vif *vif,
-                                struct ieee80211_key_conf *keyconf,
+                                       struct ieee80211_key_conf *keyconf,
-                                struct ieee80211_sta *sta,
+                                       struct ieee80211_sta *sta,
-                                u32 iv32, u16 *phase1key)
+                                       u32 iv32, u16 *phase1key)
 {
        struct iwl_priv *priv = hw->priv;
        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
@@ -3208,9 +2737,10 @@ void iwlagn_mac_update_tkip_key(struct ieee80211_hw *hw,
        IWL_DEBUG_MAC80211(priv, "leave\n");
 }
-int iwlagn_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
+static int iwlagn_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
-                       struct ieee80211_vif *vif, struct ieee80211_sta *sta,
+                              struct ieee80211_vif *vif,
-                       struct ieee80211_key_conf *key)
+                              struct ieee80211_sta *sta,
+                              struct ieee80211_key_conf *key)
 {
        struct iwl_priv *priv = hw->priv;
        struct iwl_vif_priv *vif_priv = (void *)vif->drv_priv;
@@ -3221,7 +2751,7 @@ int iwlagn_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
        IWL_DEBUG_MAC80211(priv, "enter\n");
-        if (priv->cfg->mod_params->sw_crypto) {
+        if (iwlagn_mod_params.sw_crypto) {
                IWL_DEBUG_MAC80211(priv, "leave - hwcrypto disabled\n");
                return -EOPNOTSUPP;
        }
@@ -3285,11 +2815,11 @@ int iwlagn_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
        return ret;
 }
-int iwlagn_mac_ampdu_action(struct ieee80211_hw *hw,
+static int iwlagn_mac_ampdu_action(struct ieee80211_hw *hw,
-                            struct ieee80211_vif *vif,
+                                   struct ieee80211_vif *vif,
-                            enum ieee80211_ampdu_mlme_action action,
+                                   enum ieee80211_ampdu_mlme_action action,
-                            struct ieee80211_sta *sta, u16 tid, u16 *ssn,
+                                   struct ieee80211_sta *sta, u16 tid, u16 *ssn,
-                            u8 buf_size)
+                                   u8 buf_size)
 {
        struct iwl_priv *priv = hw->priv;
        int ret = -EINVAL;
@@ -3348,6 +2878,10 @@ int iwlagn_mac_ampdu_action(struct ieee80211_hw *hw,
                }
                break;
        case IEEE80211_AMPDU_TX_OPERATIONAL:
+                buf_size = min_t(int, buf_size, LINK_QUAL_AGG_FRAME_LIMIT_DEF);
+                iwlagn_txq_agg_queue_setup(priv, sta, tid, buf_size);
                /*
                 * If the limit is 0, then it wasn't initialised yet,
                 * use the default. We can do that since we take the
@@ -3392,9 +2926,9 @@ int iwlagn_mac_ampdu_action(struct ieee80211_hw *hw,
        return ret;
 }
-int iwlagn_mac_sta_add(struct ieee80211_hw *hw,
+static int iwlagn_mac_sta_add(struct ieee80211_hw *hw,
-                       struct ieee80211_vif *vif,
+                              struct ieee80211_vif *vif,
-                       struct ieee80211_sta *sta)
+                              struct ieee80211_sta *sta)
 {
        struct iwl_priv *priv = hw->priv;
        struct iwl_station_priv *sta_priv = (void *)sta->drv_priv;
@@ -3435,8 +2969,8 @@ int iwlagn_mac_sta_add(struct ieee80211_hw *hw,
        return 0;
 }
-void iwlagn_mac_channel_switch(struct ieee80211_hw *hw,
+static void iwlagn_mac_channel_switch(struct ieee80211_hw *hw,
-                               struct ieee80211_channel_switch *ch_switch)
+                                struct ieee80211_channel_switch *ch_switch)
 {
        struct iwl_priv *priv = hw->priv;
        const struct iwl_channel_info *ch_info;
@@ -3457,21 +2991,22 @@ void iwlagn_mac_channel_switch(struct ieee80211_hw *hw,
        IWL_DEBUG_MAC80211(priv, "enter\n");
+        mutex_lock(&priv->mutex);
        if (iwl_is_rfkill(priv))
-                goto out_exit;
+                goto out;
        if (test_bit(STATUS_EXIT_PENDING, &priv->status) ||
            test_bit(STATUS_SCANNING, &priv->status))
-                goto out_exit;
+                goto out;
        if (!iwl_is_associated_ctx(ctx))
-                goto out_exit;
+                goto out;
        /* channel switch in progress */
        if (priv->switch_rxon.switch_in_progress == true)
-                goto out_exit;
+                goto out;
-        mutex_lock(&priv->mutex);
        if (priv->cfg->ops->lib->set_channel_switch) {
                ch = channel->hw_value;
@@ -3527,16 +3062,15 @@ void iwlagn_mac_channel_switch(struct ieee80211_hw *hw,
        }
 out:
        mutex_unlock(&priv->mutex);
-out_exit:
        if (!priv->switch_rxon.switch_in_progress)
                ieee80211_chswitch_done(ctx->vif, false);
        IWL_DEBUG_MAC80211(priv, "leave\n");
 }
-void iwlagn_configure_filter(struct ieee80211_hw *hw,
+static void iwlagn_configure_filter(struct ieee80211_hw *hw,
-                             unsigned int changed_flags,
+                                    unsigned int changed_flags,
-                             unsigned int *total_flags,
+                                    unsigned int *total_flags,
-                             u64 multicast)
+                                    u64 multicast)
 {
        struct iwl_priv *priv = hw->priv;
        __le32 filter_or = 0, filter_nand = 0;
@@ -3583,7 +3117,7 @@ void iwlagn_configure_filter(struct ieee80211_hw *hw,
                        FIF_BCN_PRBRESP_PROMISC | FIF_CONTROL;
 }
-void iwlagn_mac_flush(struct ieee80211_hw *hw, bool drop)
+static void iwlagn_mac_flush(struct ieee80211_hw *hw, bool drop)
 {
        struct iwl_priv *priv = hw->priv;
@@ -3729,8 +3263,6 @@ static void iwl_setup_deferred_work(struct iwl_priv *priv)
        INIT_WORK(&priv->tx_flush, iwl_bg_tx_flush);
        INIT_WORK(&priv->bt_full_concurrency, iwl_bg_bt_full_concurrency);
        INIT_WORK(&priv->bt_runtime_config, iwl_bg_bt_runtime_config);
-        INIT_DELAYED_WORK(&priv->init_alive_start, iwl_bg_init_alive_start);
-        INIT_DELAYED_WORK(&priv->alive_start, iwl_bg_alive_start);
        INIT_DELAYED_WORK(&priv->_agn.hw_roc_work, iwlagn_bg_roc_done);
        iwl_setup_scan_deferred_work(priv);
@@ -3750,12 +3282,8 @@ static void iwl_setup_deferred_work(struct iwl_priv *priv)
        priv->watchdog.data = (unsigned long)priv;
        priv->watchdog.function = iwl_bg_watchdog;
-        if (!priv->cfg->base_params->use_isr_legacy)
+        tasklet_init(&priv->irq_tasklet, (void (*)(unsigned long))
-                tasklet_init(&priv->irq_tasklet, (void (*)(unsigned long))
+                iwl_irq_tasklet, (unsigned long)priv);
-                        iwl_irq_tasklet, (unsigned long)priv);
-        else
-                tasklet_init(&priv->irq_tasklet, (void (*)(unsigned long))
-                        iwl_irq_tasklet_legacy, (unsigned long)priv);
 }
 static void iwl_cancel_deferred_work(struct iwl_priv *priv)
@@ -3763,8 +3291,6 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv)
        if (priv->cfg->ops->lib->cancel_deferred_work)
                priv->cfg->ops->lib->cancel_deferred_work(priv);
-        cancel_delayed_work_sync(&priv->init_alive_start);
-        cancel_delayed_work(&priv->alive_start);
        cancel_work_sync(&priv->run_time_calib_work);
        cancel_work_sync(&priv->beacon_update);
@@ -3805,10 +3331,7 @@ static int iwl_init_drv(struct iwl_priv *priv)
        spin_lock_init(&priv->sta_lock);
        spin_lock_init(&priv->hcmd_lock);
-        INIT_LIST_HEAD(&priv->free_frames);
        mutex_init(&priv->mutex);
-        mutex_init(&priv->sync_cmd_mutex);
        priv->ieee_channels = NULL;
        priv->ieee_rates = NULL;
@@ -3845,12 +3368,6 @@ static int iwl_init_drv(struct iwl_priv *priv)
                priv->dynamic_frag_thresh = BT_FRAG_THRESHOLD_DEF;
        }
-        /* Set the tx_power_user_lmt to the lowest power level
-         * this value will get overwritten by channel max power avg
-         * from eeprom */
-        priv->tx_power_user_lmt = IWLAGN_TX_POWER_TARGET_POWER_MIN;
-        priv->tx_power_next = IWLAGN_TX_POWER_TARGET_POWER_MIN;
        ret = iwl_init_channel_map(priv);
        if (ret) {
                IWL_ERR(priv, "initializing regulatory failed: %d\n", ret);
@@ -3905,28 +3422,30 @@ struct ieee80211_ops iwlagn_hw_ops = {
        .cancel_remain_on_channel = iwl_mac_cancel_remain_on_channel,
        .offchannel_tx = iwl_mac_offchannel_tx,
        .offchannel_tx_cancel_wait = iwl_mac_offchannel_tx_cancel_wait,
+        CFG80211_TESTMODE_CMD(iwl_testmode_cmd)
 };
-static void iwl_hw_detect(struct iwl_priv *priv)
+static u32 iwl_hw_detect(struct iwl_priv *priv)
 {
-        priv->hw_rev = _iwl_read32(priv, CSR_HW_REV);
+        u8 rev_id;
-        priv->hw_wa_rev = _iwl_read32(priv, CSR_HW_REV_WA_REG);
-        priv->rev_id = priv->pci_dev->revision;
+        pci_read_config_byte(priv->pci_dev, PCI_REVISION_ID, &rev_id);
-        IWL_DEBUG_INFO(priv, "HW Revision ID = 0x%X\n", priv->rev_id);
+        IWL_DEBUG_INFO(priv, "HW Revision ID = 0x%X\n", rev_id);
+        return iwl_read32(priv, CSR_HW_REV);
 }
 static int iwl_set_hw_params(struct iwl_priv *priv)
 {
        priv->hw_params.max_rxq_size = RX_QUEUE_SIZE;
        priv->hw_params.max_rxq_log = RX_QUEUE_SIZE_LOG;
-        if (priv->cfg->mod_params->amsdu_size_8K)
+        if (iwlagn_mod_params.amsdu_size_8K)
                priv->hw_params.rx_page_order = get_order(IWL_RX_BUF_SIZE_8K);
        else
                priv->hw_params.rx_page_order = get_order(IWL_RX_BUF_SIZE_4K);
        priv->hw_params.max_beacon_itrvl = IWL_MAX_UCODE_BEACON_INTERVAL;
-        if (priv->cfg->mod_params->disable_11n)
+        if (iwlagn_mod_params.disable_11n)
                priv->cfg->sku &= ~IWL_SKU_N;
        /* Device-specific setup */
@@ -3955,6 +3474,28 @@ static const u8 iwlagn_pan_ac_to_queue[] = {
        7, 6, 5, 4,
 };
+/* This function both allocates and initializes hw and priv. */
+static struct ieee80211_hw *iwl_alloc_all(struct iwl_cfg *cfg)
+{
+        struct iwl_priv *priv;
+        /* mac80211 allocates memory for this device instance, including
+         *   space for this driver's private structure */
+        struct ieee80211_hw *hw;
+        hw = ieee80211_alloc_hw(sizeof(struct iwl_priv), &iwlagn_hw_ops);
+        if (hw == NULL) {
+                pr_err("%s: Can not allocate network device\n",
+                       cfg->name);
+                goto out;
+        }
+        priv = hw->priv;
+        priv->hw = hw;
+out:
+        return hw;
+}
 static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
        int err = 0, i;
@@ -3963,19 +3504,12 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        struct iwl_cfg *cfg = (struct iwl_cfg *)(ent->driver_data);
        unsigned long flags;
        u16 pci_cmd, num_mac;
+        u32 hw_rev;
        /************************
         * 1. Allocating HW data
         ************************/
-        /* Disabling hardware scan means that mac80211 will perform scans
-         * "the hard way", rather than using device's scan. */
-        if (cfg->mod_params->disable_hw_scan) {
-                dev_printk(KERN_DEBUG, &(pdev->dev),
-                        "sw scan support is deprecated\n");
-                iwlagn_hw_ops.hw_scan = NULL;
-        }
        hw = iwl_alloc_all(cfg);
        if (!hw) {
                err = -ENOMEM;
@@ -3984,6 +3518,8 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        priv = hw->priv;
        /* At this point both hw and priv are allocated. */
+        priv->ucode_type = UCODE_SUBTYPE_NONE_LOADED;
        /*
         * The default context is always valid,
         * more may be discovered when firmware
@@ -4116,16 +3652,15 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
         */
        iwl_write32(priv, CSR_RESET, CSR_RESET_REG_FLAG_NEVO_RESET);
-        iwl_hw_detect(priv);
+        hw_rev = iwl_hw_detect(priv);
        IWL_INFO(priv, "Detected %s, REV=0x%X\n",
-                priv->cfg->name, priv->hw_rev);
+                priv->cfg->name, hw_rev);
        /* We disable the RETRY_TIMEOUT register (0x41) to keep
         * PCI Tx retries from interfering with C3 CPU state */
        pci_write_config_byte(pdev, PCI_CFG_RETRY_TIMEOUT, 0x00);
-        iwl_prepare_card_hw(priv);
+        if (iwl_prepare_card_hw(priv)) {
-        if (!priv->hw_ready) {
                IWL_WARN(priv, "Failed, HW not ready\n");
                goto out_iounmap;
        }
@@ -4134,7 +3669,7 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
         * 4. Read EEPROM
         *****************/
        /* Read the EEPROM */
-        err = iwl_eeprom_init(priv);
+        err = iwl_eeprom_init(priv, hw_rev);
        if (err) {
                IWL_ERR(priv, "Unable to init EEPROM\n");
                goto out_iounmap;
@@ -4186,10 +3721,9 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        pci_enable_msi(priv->pci_dev);
-        if (priv->cfg->ops->lib->isr_ops.alloc)
+        iwl_alloc_isr_ict(priv);
-                priv->cfg->ops->lib->isr_ops.alloc(priv);
-        err = request_irq(priv->pci_dev->irq, priv->cfg->ops->lib->isr_ops.isr,
+        err = request_irq(priv->pci_dev->irq, iwl_isr_ict,
                          IRQF_SHARED, DRV_NAME, priv);
        if (err) {
                IWL_ERR(priv, "Error allocating IRQ %d\n", priv->pci_dev->irq);
@@ -4198,6 +3732,7 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        iwl_setup_deferred_work(priv);
        iwl_setup_rx_handlers(priv);
+        iwl_testmode_init(priv);
        /*********************************************
         * 8. Enable interrupts and read RFKILL state
@@ -4236,8 +3771,7 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        destroy_workqueue(priv->workqueue);
        priv->workqueue = NULL;
        free_irq(priv->pci_dev->irq, priv);
-        if (priv->cfg->ops->lib->isr_ops.free)
+        iwl_free_isr_ict(priv);
-                priv->cfg->ops->lib->isr_ops.free(priv);
 out_disable_msi:
        pci_disable_msi(priv->pci_dev);
        iwl_uninit_drv(priv);
@@ -4283,17 +3817,9 @@ static void __devexit iwl_pci_remove(struct pci_dev *pdev)
        if (priv->mac80211_registered) {
                ieee80211_unregister_hw(priv->hw);
                priv->mac80211_registered = 0;
-        } else {
-                iwl_down(priv);
        }
-        /*
+        /* Reset to low power before unloading driver. */
-         * Make sure device is reset to low power before unloading driver.
-         * This may be redundant with iwl_down(), but there are paths to
-         * run iwl_down() without calling apm_ops.stop(), and there are
-         * paths to avoid running iwl_down() at all before leaving driver.
-         * This (inexpensive) call *makes sure* device is reset.
-         */
        iwl_apm_stop(priv);
        iwl_tt_exit(priv);
@@ -4335,8 +3861,7 @@ static void __devexit iwl_pci_remove(struct pci_dev *pdev)
        iwl_uninit_drv(priv);
-        if (priv->cfg->ops->lib->isr_ops.free)
+        iwl_free_isr_ict(priv);
-                priv->cfg->ops->lib->isr_ops.free(priv);
        dev_kfree_skb(priv->beacon_skb);
@@ -4521,21 +4046,21 @@ static DEFINE_PCI_DEVICE_TABLE(iwl_hw_card_ids) = {
        {IWL_PCI_DEVICE(0x088F, 0x4266, iwl6035_2bg_cfg)},
        {IWL_PCI_DEVICE(0x088E, 0x4466, iwl6035_2bg_cfg)},
-/* 200 Series */
+/* 105 Series */
-        {IWL_PCI_DEVICE(0x0894, 0x0022, iwl200_bgn_cfg)},
+        {IWL_PCI_DEVICE(0x0894, 0x0022, iwl105_bgn_cfg)},
-        {IWL_PCI_DEVICE(0x0895, 0x0222, iwl200_bgn_cfg)},
+        {IWL_PCI_DEVICE(0x0895, 0x0222, iwl105_bgn_cfg)},
-        {IWL_PCI_DEVICE(0x0894, 0x0422, iwl200_bgn_cfg)},
+        {IWL_PCI_DEVICE(0x0894, 0x0422, iwl105_bgn_cfg)},
-        {IWL_PCI_DEVICE(0x0894, 0x0026, iwl200_bg_cfg)},
+        {IWL_PCI_DEVICE(0x0894, 0x0026, iwl105_bg_cfg)},
-        {IWL_PCI_DEVICE(0x0895, 0x0226, iwl200_bg_cfg)},
+        {IWL_PCI_DEVICE(0x0895, 0x0226, iwl105_bg_cfg)},
-        {IWL_PCI_DEVICE(0x0894, 0x0426, iwl200_bg_cfg)},
+        {IWL_PCI_DEVICE(0x0894, 0x0426, iwl105_bg_cfg)},
-/* 230 Series */
+/* 135 Series */
-        {IWL_PCI_DEVICE(0x0892, 0x0062, iwl230_bgn_cfg)},
+        {IWL_PCI_DEVICE(0x0892, 0x0062, iwl135_bgn_cfg)},
-        {IWL_PCI_DEVICE(0x0893, 0x0262, iwl230_bgn_cfg)},
+        {IWL_PCI_DEVICE(0x0893, 0x0262, iwl135_bgn_cfg)},
-        {IWL_PCI_DEVICE(0x0892, 0x0462, iwl230_bgn_cfg)},
+        {IWL_PCI_DEVICE(0x0892, 0x0462, iwl135_bgn_cfg)},
-        {IWL_PCI_DEVICE(0x0892, 0x0066, iwl230_bg_cfg)},
+        {IWL_PCI_DEVICE(0x0892, 0x0066, iwl135_bg_cfg)},
-        {IWL_PCI_DEVICE(0x0893, 0x0266, iwl230_bg_cfg)},
+        {IWL_PCI_DEVICE(0x0893, 0x0266, iwl135_bg_cfg)},
-        {IWL_PCI_DEVICE(0x0892, 0x0466, iwl230_bg_cfg)},
+        {IWL_PCI_DEVICE(0x0892, 0x0466, iwl135_bg_cfg)},
        {0}
 };
@@ -4585,43 +4110,21 @@ module_exit(iwl_exit);
 module_init(iwl_init);
 #ifdef CONFIG_IWLWIFI_DEBUG
-module_param_named(debug50, iwl_debug_level, uint, S_IRUGO);
-MODULE_PARM_DESC(debug50, "50XX debug output mask (deprecated)");
 module_param_named(debug, iwl_debug_level, uint, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(debug, "debug output mask");
 #endif
-module_param_named(swcrypto50, iwlagn_mod_params.sw_crypto, bool, S_IRUGO);
-MODULE_PARM_DESC(swcrypto50,
-                 "using crypto in software (default 0 [hardware]) (deprecated)");
 module_param_named(swcrypto, iwlagn_mod_params.sw_crypto, int, S_IRUGO);
 MODULE_PARM_DESC(swcrypto, "using crypto in software (default 0 [hardware])");
-module_param_named(queues_num50,
-                   iwlagn_mod_params.num_of_queues, int, S_IRUGO);
-MODULE_PARM_DESC(queues_num50,
-                 "number of hw queues in 50xx series (deprecated)");
 module_param_named(queues_num, iwlagn_mod_params.num_of_queues, int, S_IRUGO);
 MODULE_PARM_DESC(queues_num, "number of hw queues.");
-module_param_named(11n_disable50, iwlagn_mod_params.disable_11n, int, S_IRUGO);
-MODULE_PARM_DESC(11n_disable50, "disable 50XX 11n functionality (deprecated)");
 module_param_named(11n_disable, iwlagn_mod_params.disable_11n, int, S_IRUGO);
 MODULE_PARM_DESC(11n_disable, "disable 11n functionality");
-module_param_named(amsdu_size_8K50, iwlagn_mod_params.amsdu_size_8K,
-                   int, S_IRUGO);
-MODULE_PARM_DESC(amsdu_size_8K50,
-                 "enable 8K amsdu size in 50XX series (deprecated)");
 module_param_named(amsdu_size_8K, iwlagn_mod_params.amsdu_size_8K,
                   int, S_IRUGO);
 MODULE_PARM_DESC(amsdu_size_8K, "enable 8K amsdu size");
-module_param_named(fw_restart50, iwlagn_mod_params.restart_fw, int, S_IRUGO);
-MODULE_PARM_DESC(fw_restart50,
-                 "restart firmware in case of error (deprecated)");
 module_param_named(fw_restart, iwlagn_mod_params.restart_fw, int, S_IRUGO);
 MODULE_PARM_DESC(fw_restart, "restart firmware in case of error");
-module_param_named(
-        disable_hw_scan, iwlagn_mod_params.disable_hw_scan, int, S_IRUGO);
-MODULE_PARM_DESC(disable_hw_scan,
-                 "disable hardware scanning (default 0) (deprecated)");
 module_param_named(ucode_alternative, iwlagn_wanted_ucode_alternative, int,
                   S_IRUGO);
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.h b/drivers/net/wireless/iwlwifi/iwl-agn.h
index 20f8e4188994..fe33fe8aa418 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.h
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -66,7 +66,6 @@
 #include "iwl-dev.h"
 /* configuration for the _agn devices */
-extern struct iwl_cfg iwl4965_agn_cfg;
 extern struct iwl_cfg iwl5300_agn_cfg;
 extern struct iwl_cfg iwl5100_agn_cfg;
 extern struct iwl_cfg iwl5350_agn_cfg;
@@ -103,10 +102,10 @@ extern struct iwl_cfg iwl2030_2bg_cfg;
 extern struct iwl_cfg iwl6035_2agn_cfg;
 extern struct iwl_cfg iwl6035_2abg_cfg;
 extern struct iwl_cfg iwl6035_2bg_cfg;
-extern struct iwl_cfg iwl200_bg_cfg;
+extern struct iwl_cfg iwl105_bg_cfg;
-extern struct iwl_cfg iwl200_bgn_cfg;
+extern struct iwl_cfg iwl105_bgn_cfg;
-extern struct iwl_cfg iwl230_bg_cfg;
+extern struct iwl_cfg iwl135_bg_cfg;
-extern struct iwl_cfg iwl230_bgn_cfg;
+extern struct iwl_cfg iwl135_bgn_cfg;
 extern struct iwl_mod_params iwlagn_mod_params;
 extern struct iwl_hcmd_ops iwlagn_hcmd;
@@ -114,7 +113,6 @@ extern struct iwl_hcmd_ops iwlagn_bt_hcmd;
 extern struct iwl_hcmd_utils_ops iwlagn_hcmd_utils;
 extern struct ieee80211_ops iwlagn_hw_ops;
-extern struct ieee80211_ops iwl4965_hw_ops;
 int iwl_reset_ict(struct iwl_priv *priv);
 void iwl_disable_ict(struct iwl_priv *priv);
@@ -122,21 +120,25 @@ int iwl_alloc_isr_ict(struct iwl_priv *priv);
 void iwl_free_isr_ict(struct iwl_priv *priv);
 irqreturn_t iwl_isr_ict(int irq, void *data);
+/* call this function to flush any scheduled tasklet */
+static inline void iwl_synchronize_irq(struct iwl_priv *priv)
+{
+        /* wait to make sure we flush pending tasklet*/
+        synchronize_irq(priv->pci_dev->irq);
+        tasklet_kill(&priv->irq_tasklet);
+}
+int iwl_prepare_card_hw(struct iwl_priv *priv);
+int iwlagn_start_device(struct iwl_priv *priv);
+void iwlagn_stop_device(struct iwl_priv *priv);
 /* tx queue */
 void iwlagn_set_wr_ptrs(struct iwl_priv *priv,
                     int txq_id, u32 index);
 void iwlagn_tx_queue_set_status(struct iwl_priv *priv,
                             struct iwl_tx_queue *txq,
                             int tx_fifo_id, int scd_retry);
-void iwlagn_txq_update_byte_cnt_tbl(struct iwl_priv *priv,
-                                    struct iwl_tx_queue *txq,
-                                    u16 byte_cnt);
-void iwlagn_txq_inval_byte_cnt_tbl(struct iwl_priv *priv,
-                                   struct iwl_tx_queue *txq);
-int iwlagn_txq_agg_enable(struct iwl_priv *priv, int txq_id,
-                          int tx_fifo, int sta_id, int tid, u16 ssn_idx);
-int iwlagn_txq_agg_disable(struct iwl_priv *priv, u16 txq_id,
-                           u16 ssn_idx, u8 tx_fifo);
 void iwlagn_txq_set_sched(struct iwl_priv *priv, u32 mask);
 void iwl_free_tfds_in_queue(struct iwl_priv *priv,
                            int sta_id, int tid, int freed);
@@ -151,16 +153,14 @@ void iwlagn_bss_info_changed(struct ieee80211_hw *hw,
                             u32 changes);
 /* uCode */
-int iwlagn_load_ucode(struct iwl_priv *priv);
 void iwlagn_rx_calib_result(struct iwl_priv *priv,
                         struct iwl_rx_mem_buffer *rxb);
-void iwlagn_rx_calib_complete(struct iwl_priv *priv,
+int iwlagn_send_bt_env(struct iwl_priv *priv, u8 action, u8 type);
-                           struct iwl_rx_mem_buffer *rxb);
-void iwlagn_init_alive_start(struct iwl_priv *priv);
-int iwlagn_alive_notify(struct iwl_priv *priv);
-int iwl_verify_ucode(struct iwl_priv *priv);
-void iwlagn_send_bt_env(struct iwl_priv *priv, u8 action, u8 type);
 void iwlagn_send_prio_tbl(struct iwl_priv *priv);
+int iwlagn_run_init_ucode(struct iwl_priv *priv);
+int iwlagn_load_ucode_wait_alive(struct iwl_priv *priv,
+                                 struct fw_img *image,
+                                 int subtype, int alternate_subtype);
 /* lib */
 void iwl_check_abort_status(struct iwl_priv *priv,
@@ -179,8 +179,6 @@ int iwlagn_hw_nic_init(struct iwl_priv *priv);
 int iwlagn_wait_tx_queue_empty(struct iwl_priv *priv);
 int iwlagn_txfifo_flush(struct iwl_priv *priv, u16 flush_control);
 void iwlagn_dev_txfifo_flush(struct iwl_priv *priv, u16 flush_control);
-void iwl_dump_csr(struct iwl_priv *priv);
-int iwl_dump_fh(struct iwl_priv *priv, char **buf, bool display);
 /* rx */
 void iwlagn_rx_queue_restock(struct iwl_priv *priv);
@@ -206,6 +204,9 @@ int iwlagn_tx_agg_start(struct iwl_priv *priv, struct ieee80211_vif *vif,
                        struct ieee80211_sta *sta, u16 tid, u16 *ssn);
 int iwlagn_tx_agg_stop(struct iwl_priv *priv, struct ieee80211_vif *vif,
                       struct ieee80211_sta *sta, u16 tid);
+void iwlagn_txq_agg_queue_setup(struct iwl_priv *priv,
+                                struct ieee80211_sta *sta,
+                                int tid, int frame_limit);
 int iwlagn_txq_check_empty(struct iwl_priv *priv,
                           int sta_id, u8 tid, int txq_id);
 void iwlagn_rx_reply_compressed_ba(struct iwl_priv *priv,
@@ -225,6 +226,7 @@ static inline u32 iwl_tx_status_to_mac80211(u32 status)
        case TX_STATUS_DIRECT_DONE:
                return IEEE80211_TX_STAT_ACK;
        case TX_STATUS_FAIL_DEST_PS:
+        case TX_STATUS_FAIL_PASSIVE_NO_RX:
                return IEEE80211_TX_STAT_TX_FILTERED;
        default:
                return 0;
@@ -249,8 +251,6 @@ int iwlagn_manage_ibss_station(struct iwl_priv *priv,
                               struct ieee80211_vif *vif, bool add);
 /* hcmd */
-int iwlagn_send_rxon_assoc(struct iwl_priv *priv,
-                           struct iwl_rxon_context *ctx);
 int iwlagn_send_tx_ant_config(struct iwl_priv *priv, u8 valid_tx_ant);
 int iwlagn_send_beacon_cmd(struct iwl_priv *priv);
@@ -311,7 +311,7 @@ static inline u32 iwl_ant_idx_to_flags(u8 ant_idx)
 static inline u8 iwl_hw_get_rate(__le32 rate_n_flags)
 {
-        return le32_to_cpu(rate_n_flags) & 0xFF;
+        return le32_to_cpu(rate_n_flags) & RATE_MCS_RATE_MSK;
 }
 static inline __le32 iwl_hw_set_rate_n_flags(u8 rate, u32 flags)
@@ -322,50 +322,39 @@ static inline __le32 iwl_hw_set_rate_n_flags(u8 rate, u32 flags)
 /* eeprom */
 void iwlcore_eeprom_enhanced_txpower(struct iwl_priv *priv);
 void iwl_eeprom_get_mac(const struct iwl_priv *priv, u8 *mac);
-int iwlcore_eeprom_acquire_semaphore(struct iwl_priv *priv);
-void iwlcore_eeprom_release_semaphore(struct iwl_priv *priv);
 /* notification wait support */
 void __acquires(wait_entry)
 iwlagn_init_notification_wait(struct iwl_priv *priv,
                              struct iwl_notification_wait *wait_entry,
+                              u8 cmd,
                              void (*fn)(struct iwl_priv *priv,
-                                         struct iwl_rx_packet *pkt),
+                                         struct iwl_rx_packet *pkt,
-                              u8 cmd);
+                                         void *data),
-signed long __releases(wait_entry)
+                              void *fn_data);
+int __must_check __releases(wait_entry)
 iwlagn_wait_notification(struct iwl_priv *priv,
                         struct iwl_notification_wait *wait_entry,
                         unsigned long timeout);
 void __releases(wait_entry)
 iwlagn_remove_notification(struct iwl_priv *priv,
                           struct iwl_notification_wait *wait_entry);
+extern int iwlagn_init_alive_start(struct iwl_priv *priv);
-/* mac80211 handlers (for 4965) */
+extern int iwl_alive_start(struct iwl_priv *priv);
-void iwlagn_mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb);
+/* svtool */
-int iwlagn_mac_start(struct ieee80211_hw *hw);
+#ifdef CONFIG_IWLWIFI_DEVICE_SVTOOL
-void iwlagn_mac_stop(struct ieee80211_hw *hw);
+extern int iwl_testmode_cmd(struct ieee80211_hw *hw, void *data, int len);
-void iwlagn_configure_filter(struct ieee80211_hw *hw,
+extern void iwl_testmode_init(struct iwl_priv *priv);
-                             unsigned int changed_flags,
+#else
-                             unsigned int *total_flags,
+static inline
-                             u64 multicast);
+int iwl_testmode_cmd(struct ieee80211_hw *hw, void *data, int len)
-int iwlagn_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
+{
-                       struct ieee80211_vif *vif, struct ieee80211_sta *sta,
+        return -ENOSYS;
-                       struct ieee80211_key_conf *key);
+}
-void iwlagn_mac_update_tkip_key(struct ieee80211_hw *hw,
+static inline
-                                struct ieee80211_vif *vif,
+void iwl_testmode_init(struct iwl_priv *priv)
-                                struct ieee80211_key_conf *keyconf,
+{
-                                struct ieee80211_sta *sta,
+}
-                                u32 iv32, u16 *phase1key);
+#endif
-int iwlagn_mac_ampdu_action(struct ieee80211_hw *hw,
-                            struct ieee80211_vif *vif,
-                            enum ieee80211_ampdu_mlme_action action,
-                            struct ieee80211_sta *sta, u16 tid, u16 *ssn,
-                            u8 buf_size);
-int iwlagn_mac_sta_add(struct ieee80211_hw *hw,
-                       struct ieee80211_vif *vif,
-                       struct ieee80211_sta *sta);
-void iwlagn_mac_channel_switch(struct ieee80211_hw *hw,
-                               struct ieee80211_channel_switch *ch_switch);
-void iwlagn_mac_flush(struct ieee80211_hw *hw, bool drop);
 #endif /* __iwl_agn_h__ */
diff --git a/drivers/net/wireless/iwlwifi/iwl-commands.h b/drivers/net/wireless/iwlwifi/iwl-commands.h
index ca42ffa63ed7..5fdad6532118 100644
--- a/drivers/net/wireless/iwlwifi/iwl-commands.h
+++ b/drivers/net/wireless/iwlwifi/iwl-commands.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -103,9 +103,7 @@ enum {
        REPLY_WEPKEY = 0x20,
        /* RX, TX, LEDs */
-        REPLY_3945_RX = 0x1b,           /* 3945 only */
        REPLY_TX = 0x1c,
-        REPLY_RATE_SCALE = 0x47,        /* 3945 only */
        REPLY_LEDS_CMD = 0x48,
        REPLY_TX_LINK_QUALITY_CMD = 0x4e, /* for 4965 and up */
@@ -229,7 +227,7 @@ struct iwl_cmd_header {
         * There is one exception:  uCode sets bit 15 when it originates
         * the response/notification, i.e. when the response/notification
         * is not a direct response to a command sent by the driver.  For
-         * example, uCode issues REPLY_3945_RX when it sends a received frame
+         * example, uCode issues REPLY_RX when it sends a received frame
         * to the driver; it is not a direct response to any driver command.
         *
         * The Linux driver uses the following format:
@@ -249,36 +247,6 @@ struct iwl_cmd_header {
 /**
- * struct iwl3945_tx_power
- *
- * Used in REPLY_TX_PWR_TABLE_CMD, REPLY_SCAN_CMD, REPLY_CHANNEL_SWITCH
- *
- * Each entry contains two values:
- * 1)  DSP gain (or sometimes called DSP attenuation).  This is a fine-grained
- *     linear value that multiplies the output of the digital signal processor,
- *     before being sent to the analog radio.
- * 2)  Radio gain.  This sets the analog gain of the radio Tx path.
- *     It is a coarser setting, and behaves in a logarithmic (dB) fashion.
- *
- * Driver obtains values from struct iwl3945_tx_power power_gain_table[][].
- */
-struct iwl3945_tx_power {
-        u8 tx_gain;             /* gain for analog radio */
-        u8 dsp_atten;           /* gain for DSP */
-} __packed;
-/**
- * struct iwl3945_power_per_rate
- *
- * Used in REPLY_TX_PWR_TABLE_CMD, REPLY_CHANNEL_SWITCH
- */
-struct iwl3945_power_per_rate {
-        u8 rate;                /* plcp */
-        struct iwl3945_tx_power tpc;
-        u8 reserved;
-} __packed;
-/**
 * iwlagn rate_n_flags bit fields
 *
 * rate_n_flags format is used in following iwlagn commands:
@@ -324,6 +292,8 @@ struct iwl3945_power_per_rate {
 #define RATE_MCS_SPATIAL_MSK 0x18
 #define RATE_MCS_HT_DUP_POS 5
 #define RATE_MCS_HT_DUP_MSK 0x20
+/* Both legacy and HT use bits 7:0 as the CCK/OFDM rate or HT MCS */
+#define RATE_MCS_RATE_MSK 0xff
 /* Bit 8: (1) HT format, (0) legacy format in bits 7:0 */
 #define RATE_MCS_FLAGS_POS 8
@@ -375,30 +345,6 @@ struct iwl3945_power_per_rate {
 #define IWL_PWR_CCK_ENTRIES                     2
 /**
- * union iwl4965_tx_power_dual_stream
- *
- * Host format used for REPLY_TX_PWR_TABLE_CMD, REPLY_CHANNEL_SWITCH
- * Use __le32 version (struct tx_power_dual_stream) when building command.
- *
- * Driver provides radio gain and DSP attenuation settings to device in pairs,
- * one value for each transmitter chain.  The first value is for transmitter A,
- * second for transmitter B.
- *
- * For SISO bit rates, both values in a pair should be identical.
- * For MIMO rates, one value may be different from the other,
- * in order to balance the Tx output between the two transmitters.
- *
- * See more details in doc for TXPOWER in iwl-4965-hw.h.
- */
-union iwl4965_tx_power_dual_stream {
-        struct {
-                u8 radio_tx_gain[2];
-                u8 dsp_predis_atten[2];
-        } s;
-        u32 dw;
-};
-/**
 * struct tx_power_dual_stream
 *
 * Table entries in REPLY_TX_PWR_TABLE_CMD, REPLY_CHANNEL_SWITCH
@@ -410,15 +356,6 @@ struct tx_power_dual_stream {
 } __packed;
 /**
- * struct iwl4965_tx_power_db
- *
- * Entire table within REPLY_TX_PWR_TABLE_CMD, REPLY_CHANNEL_SWITCH
- */
-struct iwl4965_tx_power_db {
-        struct tx_power_dual_stream power_tbl[POWER_TABLE_NUM_ENTRIES];
-} __packed;
-/**
 * Command REPLY_TX_POWER_DBM_CMD = 0x98
 * struct iwlagn_tx_power_dbm_cmd
 */
@@ -449,55 +386,18 @@ struct iwl_tx_ant_config_cmd {
 *****************************************************************************/
 #define UCODE_VALID_OK  cpu_to_le32(0x1)
-#define INITIALIZE_SUBTYPE    (9)
-/*
+enum iwlagn_ucode_subtype {
- * ("Initialize") REPLY_ALIVE = 0x1 (response only, not a command)
+        UCODE_SUBTYPE_REGULAR   = 0,
- *
+        UCODE_SUBTYPE_REGULAR_NEW = 1,
- * uCode issues this "initialize alive" notification once the initialization
+        UCODE_SUBTYPE_INIT      = 9,
- * uCode image has completed its work, and is ready to load the runtime image.
- * This is the *first* "alive" notification that the driver will receive after
- * rebooting uCode; the "initialize" alive is indicated by subtype field == 9.
- *
- * See comments documenting "BSM" (bootstrap state machine).
- *
- * For 4965, this notification contains important calibration data for
- * calculating txpower settings:
- *
- * 1)  Power supply voltage indication.  The voltage sensor outputs higher
- *     values for lower voltage, and vice verse.
- *
- * 2)  Temperature measurement parameters, for each of two channel widths
- *     (20 MHz and 40 MHz) supported by the radios.  Temperature sensing
- *     is done via one of the receiver chains, and channel width influences
- *     the results.
- *
- * 3)  Tx gain compensation to balance 4965's 2 Tx chains for MIMO operation,
- *     for each of 5 frequency ranges.
- */
-struct iwl_init_alive_resp {
-        u8 ucode_minor;
-        u8 ucode_major;
-        __le16 reserved1;
-        u8 sw_rev[8];
-        u8 ver_type;
-        u8 ver_subtype;         /* "9" for initialize alive */
-        __le16 reserved2;
-        __le32 log_event_table_ptr;
-        __le32 error_event_table_ptr;
-        __le32 timestamp;
-        __le32 is_valid;
-        /* calibration values from "initialize" uCode */
-        __le32 voltage;         /* signed, higher value is lower voltage */
-        __le32 therm_r1[2];     /* signed, 1st for normal, 2nd for HT40 */
-        __le32 therm_r2[2];     /* signed */
-        __le32 therm_r3[2];     /* signed */
-        __le32 therm_r4[2];     /* signed */
-        __le32 tx_atten[5][2];  /* signed MIMO gain comp, 5 freq groups,
-                                 * 2 Tx chains */
-} __packed;
+        /*
+         * Not a valid subtype, the ucode has just a u8, so
+         * we can use something > 0xff for this value.
+         */
+        UCODE_SUBTYPE_NONE_LOADED = 0x100,
+};
 /**
 * REPLY_ALIVE = 0x1 (response only, not a command)
@@ -533,49 +433,61 @@ struct iwl_init_alive_resp {
 *
 * 2)  error_event_table_ptr indicates base of the error log.  This contains
 *     information about any uCode error that occurs.  For agn, the format
- *     of the error log is:
+ *     of the error log is defined by struct iwl_error_event_table.
- *
- *      __le32 valid;        (nonzero) valid, (0) log is empty
- *      __le32 error_id;     type of error
- *      __le32 pc;           program counter
- *      __le32 blink1;       branch link
- *      __le32 blink2;       branch link
- *      __le32 ilink1;       interrupt link
- *      __le32 ilink2;       interrupt link
- *      __le32 data1;        error-specific data
- *      __le32 data2;        error-specific data
- *      __le32 line;         source code line of error
- *      __le32 bcon_time;    beacon timer
- *      __le32 tsf_low;      network timestamp function timer
- *      __le32 tsf_hi;       network timestamp function timer
- *      __le32 gp1;          GP1 timer register
- *      __le32 gp2;          GP2 timer register
- *      __le32 gp3;          GP3 timer register
- *      __le32 ucode_ver;    uCode version
- *      __le32 hw_ver;       HW Silicon version
- *      __le32 brd_ver;      HW board version
- *      __le32 log_pc;       log program counter
- *      __le32 frame_ptr;    frame pointer
- *      __le32 stack_ptr;    stack pointer
- *      __le32 hcmd;         last host command
- *      __le32 isr0;         isr status register LMPM_NIC_ISR0: rxtx_flag
- *      __le32 isr1;         isr status register LMPM_NIC_ISR1: host_flag
- *      __le32 isr2;         isr status register LMPM_NIC_ISR2: enc_flag
- *      __le32 isr3;         isr status register LMPM_NIC_ISR3: time_flag
- *      __le32 isr4;         isr status register LMPM_NIC_ISR4: wico interrupt
- *      __le32 isr_pref;     isr status register LMPM_NIC_PREF_STAT
- *      __le32 wait_event;   wait event() caller address
- *      __le32 l2p_control;  L2pControlField
- *      __le32 l2p_duration; L2pDurationField
- *      __le32 l2p_mhvalid;  L2pMhValidBits
- *      __le32 l2p_addr_match; L2pAddrMatchStat
- *      __le32 lmpm_pmg_sel; indicate which clocks are turned on (LMPM_PMG_SEL)
- *      __le32 u_timestamp;  indicate when the date and time of the compilation
- *      __le32 reserved;
 *
 * The Linux driver can print both logs to the system log when a uCode error
 * occurs.
 */
+/*
+ * Note: This structure is read from the device with IO accesses,
+ * and the reading already does the endian conversion. As it is
+ * read with u32-sized accesses, any members with a different size
+ * need to be ordered correctly though!
+ */
+struct iwl_error_event_table {
+        u32 valid;              /* (nonzero) valid, (0) log is empty */
+        u32 error_id;           /* type of error */
+        u32 pc;                 /* program counter */
+        u32 blink1;             /* branch link */
+        u32 blink2;             /* branch link */
+        u32 ilink1;             /* interrupt link */
+        u32 ilink2;             /* interrupt link */
+        u32 data1;              /* error-specific data */
+        u32 data2;              /* error-specific data */
+        u32 line;               /* source code line of error */
+        u32 bcon_time;          /* beacon timer */
+        u32 tsf_low;            /* network timestamp function timer */
+        u32 tsf_hi;             /* network timestamp function timer */
+        u32 gp1;                /* GP1 timer register */
+        u32 gp2;                /* GP2 timer register */
+        u32 gp3;                /* GP3 timer register */
+        u32 ucode_ver;          /* uCode version */
+        u32 hw_ver;             /* HW Silicon version */
+        u32 brd_ver;            /* HW board version */
+        u32 log_pc;             /* log program counter */
+        u32 frame_ptr;          /* frame pointer */
+        u32 stack_ptr;          /* stack pointer */
+        u32 hcmd;               /* last host command header */
+#if 0
+        /* no need to read the remainder, we don't use the values */
+        u32 isr0;               /* isr status register LMPM_NIC_ISR0: rxtx_flag */
+        u32 isr1;               /* isr status register LMPM_NIC_ISR1: host_flag */
+        u32 isr2;               /* isr status register LMPM_NIC_ISR2: enc_flag */
+        u32 isr3;               /* isr status register LMPM_NIC_ISR3: time_flag */
+        u32 isr4;               /* isr status register LMPM_NIC_ISR4: wico interrupt */
+        u32 isr_pref;           /* isr status register LMPM_NIC_PREF_STAT */
+        u32 wait_event;         /* wait event() caller address */
+        u32 l2p_control;        /* L2pControlField */
+        u32 l2p_duration;       /* L2pDurationField */
+        u32 l2p_mhvalid;        /* L2pMhValidBits */
+        u32 l2p_addr_match;     /* L2pAddrMatchStat */
+        u32 lmpm_pmg_sel;       /* indicate which clocks are turned on (LMPM_PMG_SEL) */
+        u32 u_timestamp;        /* indicate when the date and time of the compilation */
+        u32 flow_handler;       /* FH read/write pointers, RX credit */
+#endif
+} __packed;
 struct iwl_alive_resp {
        u8 ucode_minor;
        u8 ucode_major;
@@ -722,46 +634,6 @@ enum {
 *        regardless of whether RXON_FILTER_ASSOC_MSK is set.
 */
-struct iwl3945_rxon_cmd {
-        u8 node_addr[6];
-        __le16 reserved1;
-        u8 bssid_addr[6];
-        __le16 reserved2;
-        u8 wlap_bssid_addr[6];
-        __le16 reserved3;
-        u8 dev_type;
-        u8 air_propagation;
-        __le16 reserved4;
-        u8 ofdm_basic_rates;
-        u8 cck_basic_rates;
-        __le16 assoc_id;
-        __le32 flags;
-        __le32 filter_flags;
-        __le16 channel;
-        __le16 reserved5;
-} __packed;
-struct iwl4965_rxon_cmd {
-        u8 node_addr[6];
-        __le16 reserved1;
-        u8 bssid_addr[6];
-        __le16 reserved2;
-        u8 wlap_bssid_addr[6];
-        __le16 reserved3;
-        u8 dev_type;
-        u8 air_propagation;
-        __le16 rx_chain;
-        u8 ofdm_basic_rates;
-        u8 cck_basic_rates;
-        __le16 assoc_id;
-        __le32 flags;
-        __le32 filter_flags;
-        __le16 channel;
-        u8 ofdm_ht_single_stream_basic_rates;
-        u8 ofdm_ht_dual_stream_basic_rates;
-} __packed;
-/* 5000 HW just extend this command */
 struct iwl_rxon_cmd {
        u8 node_addr[6];
        __le16 reserved1;
@@ -789,26 +661,7 @@ struct iwl_rxon_cmd {
 /*
 * REPLY_RXON_ASSOC = 0x11 (command, has simple generic response)
 */
-struct iwl3945_rxon_assoc_cmd {
+struct iwl_rxon_assoc_cmd {
-        __le32 flags;
-        __le32 filter_flags;
-        u8 ofdm_basic_rates;
-        u8 cck_basic_rates;
-        __le16 reserved;
-} __packed;
-struct iwl4965_rxon_assoc_cmd {
-        __le32 flags;
-        __le32 filter_flags;
-        u8 ofdm_basic_rates;
-        u8 cck_basic_rates;
-        u8 ofdm_ht_single_stream_basic_rates;
-        u8 ofdm_ht_dual_stream_basic_rates;
-        __le16 rx_chain_select_flags;
-        __le16 reserved;
-} __packed;
-struct iwl5000_rxon_assoc_cmd {
        __le32 flags;
        __le32 filter_flags;
        u8 ofdm_basic_rates;
@@ -843,26 +696,6 @@ struct iwl_rxon_time_cmd {
 /*
 * REPLY_CHANNEL_SWITCH = 0x72 (command, has simple generic response)
 */
-struct iwl3945_channel_switch_cmd {
-        u8 band;
-        u8 expect_beacon;
-        __le16 channel;
-        __le32 rxon_flags;
-        __le32 rxon_filter_flags;
-        __le32 switch_time;
-        struct iwl3945_power_per_rate power[IWL_MAX_RATES];
-} __packed;
-struct iwl4965_channel_switch_cmd {
-        u8 band;
-        u8 expect_beacon;
-        __le16 channel;
-        __le32 rxon_flags;
-        __le32 rxon_filter_flags;
-        __le32 switch_time;
-        struct iwl4965_tx_power_db tx_power;
-} __packed;
 /**
 * struct iwl5000_channel_switch_cmd
 * @band: 0- 5.2GHz, 1- 2.4GHz
@@ -976,15 +809,10 @@ struct iwl_qosparam_cmd {
 #define IWL_AP_ID               0
 #define IWL_AP_ID_PAN           1
 #define IWL_STA_ID              2
-#define IWL3945_BROADCAST_ID    24
-#define IWL3945_STATION_COUNT   25
-#define IWL4965_BROADCAST_ID    31
-#define IWL4965_STATION_COUNT   32
 #define IWLAGN_PAN_BCAST_ID     14
 #define IWLAGN_BROADCAST_ID     15
 #define IWLAGN_STATION_COUNT    16
-#define IWL_STATION_COUNT       32      /* MAX(3945,4965)*/
 #define IWL_INVALID_STATION     255
 #define STA_FLG_TX_RATE_MSK             cpu_to_le32(1 << 2)
@@ -1032,16 +860,6 @@ struct iwl_qosparam_cmd {
 * combined with Traffic ID (QOS priority), in format used by Tx Scheduler */
 #define BUILD_RAxTID(sta_id, tid)       (((sta_id) << 4) + (tid))
-struct iwl4965_keyinfo {
-        __le16 key_flags;
-        u8 tkip_rx_tsc_byte2;   /* TSC[2] for key mix ph1 detection */
-        u8 reserved1;
-        __le16 tkip_rx_ttak[5]; /* 10-byte unicast TKIP TTAK */
-        u8 key_offset;
-        u8 reserved2;
-        u8 key[16];             /* 16-byte unicast decryption key */
-} __packed;
 /* agn */
 struct iwl_keyinfo {
        __le16 key_flags;
@@ -1083,7 +901,6 @@ struct sta_id_modify {
 * with info on security keys, aggregation parameters, and Tx rates for
 * initial Tx attempt and any retries (agn devices uses
 * REPLY_TX_LINK_QUALITY_CMD,
- * 3945 uses REPLY_RATE_SCALE to set up rate tables).
 *
 * REPLY_ADD_STA sets up the table entry for one station, either creating
 * a new entry, or modifying a pre-existing one.
@@ -1103,72 +920,6 @@ struct sta_id_modify {
 *        entries for all STAs in network, starting with index IWL_STA_ID.
 */
-struct iwl3945_addsta_cmd {
-        u8 mode;                /* 1: modify existing, 0: add new station */
-        u8 reserved[3];
-        struct sta_id_modify sta;
-        struct iwl4965_keyinfo key;
-        __le32 station_flags;           /* STA_FLG_* */
-        __le32 station_flags_msk;       /* STA_FLG_* */
-        /* bit field to disable (1) or enable (0) Tx for Traffic ID (TID)
-         * corresponding to bit (e.g. bit 5 controls TID 5).
-         * Set modify_mask bit STA_MODIFY_TID_DISABLE_TX to use this field. */
-        __le16 tid_disable_tx;
-        __le16 rate_n_flags;
-        /* TID for which to add block-ack support.
-         * Set modify_mask bit STA_MODIFY_ADDBA_TID_MSK to use this field. */
-        u8 add_immediate_ba_tid;
-        /* TID for which to remove block-ack support.
-         * Set modify_mask bit STA_MODIFY_DELBA_TID_MSK to use this field. */
-        u8 remove_immediate_ba_tid;
-        /* Starting Sequence Number for added block-ack support.
-         * Set modify_mask bit STA_MODIFY_ADDBA_TID_MSK to use this field. */
-        __le16 add_immediate_ba_ssn;
-} __packed;
-struct iwl4965_addsta_cmd {
-        u8 mode;                /* 1: modify existing, 0: add new station */
-        u8 reserved[3];
-        struct sta_id_modify sta;
-        struct iwl4965_keyinfo key;
-        __le32 station_flags;           /* STA_FLG_* */
-        __le32 station_flags_msk;       /* STA_FLG_* */
-        /* bit field to disable (1) or enable (0) Tx for Traffic ID (TID)
-         * corresponding to bit (e.g. bit 5 controls TID 5).
-         * Set modify_mask bit STA_MODIFY_TID_DISABLE_TX to use this field. */
-        __le16 tid_disable_tx;
-        __le16  reserved1;
-        /* TID for which to add block-ack support.
-         * Set modify_mask bit STA_MODIFY_ADDBA_TID_MSK to use this field. */
-        u8 add_immediate_ba_tid;
-        /* TID for which to remove block-ack support.
-         * Set modify_mask bit STA_MODIFY_DELBA_TID_MSK to use this field. */
-        u8 remove_immediate_ba_tid;
-        /* Starting Sequence Number for added block-ack support.
-         * Set modify_mask bit STA_MODIFY_ADDBA_TID_MSK to use this field. */
-        __le16 add_immediate_ba_ssn;
-        /*
-         * Number of packets OK to transmit to station even though
-         * it is asleep -- used to synchronise PS-poll and u-APSD
-         * responses while ucode keeps track of STA sleep state.
-         */
-        __le16 sleep_tx_count;
-        __le16 reserved2;
-} __packed;
-/* agn */
 struct iwl_addsta_cmd {
        u8 mode;                /* 1: modify existing, 0: add new station */
        u8 reserved[3];
@@ -1337,62 +1088,6 @@ struct iwl_wep_cmd {
 #define RX_MPDU_RES_STATUS_DEC_DONE_MSK (0x800)
-struct iwl3945_rx_frame_stats {
-        u8 phy_count;
-        u8 id;
-        u8 rssi;
-        u8 agc;
-        __le16 sig_avg;
-        __le16 noise_diff;
-        u8 payload[0];
-} __packed;
-struct iwl3945_rx_frame_hdr {
-        __le16 channel;
-        __le16 phy_flags;
-        u8 reserved1;
-        u8 rate;
-        __le16 len;
-        u8 payload[0];
-} __packed;
-struct iwl3945_rx_frame_end {
-        __le32 status;
-        __le64 timestamp;
-        __le32 beacon_timestamp;
-} __packed;
-/*
- * REPLY_3945_RX = 0x1b (response only, not a command)
- *
- * NOTE:  DO NOT dereference from casts to this structure
- * It is provided only for calculating minimum data set size.
- * The actual offsets of the hdr and end are dynamic based on
- * stats.phy_count
- */
-struct iwl3945_rx_frame {
-        struct iwl3945_rx_frame_stats stats;
-        struct iwl3945_rx_frame_hdr hdr;
-        struct iwl3945_rx_frame_end end;
-} __packed;
-#define IWL39_RX_FRAME_SIZE     (4 + sizeof(struct iwl3945_rx_frame))
-/* Fixed (non-configurable) rx data from phy */
-#define IWL49_RX_RES_PHY_CNT 14
-#define IWL49_RX_PHY_FLAGS_ANTENNAE_OFFSET      (4)
-#define IWL49_RX_PHY_FLAGS_ANTENNAE_MASK        (0x70)
-#define IWL49_AGC_DB_MASK                       (0x3f80)        /* MASK(7,13) */
-#define IWL49_AGC_DB_POS                        (7)
-struct iwl4965_rx_non_cfg_phy {
-        __le16 ant_selection;   /* ant A bit 4, ant B bit 5, ant C bit 6 */
-        __le16 agc_info;        /* agc code 0:6, agc dB 7:13, reserved 14:15 */
-        u8 rssi_info[6];        /* we use even entries, 0/2/4 for A/B/C rssi */
-        u8 pad[0];
-} __packed;
 #define IWLAGN_RX_RES_PHY_CNT 8
 #define IWLAGN_RX_RES_AGC_IDX     1
 #define IWLAGN_RX_RES_RSSI_AB_IDX 2
@@ -1576,80 +1271,6 @@ struct iwl_rx_mpdu_res_start {
 * REPLY_TX = 0x1c (command)
 */
-struct iwl3945_tx_cmd {
-        /*
-         * MPDU byte count:
-         * MAC header (24/26/30/32 bytes) + 2 bytes pad if 26/30 header size,
-         * + 8 byte IV for CCM or TKIP (not used for WEP)
-         * + Data payload
-         * + 8-byte MIC (not used for CCM/WEP)
-         * NOTE:  Does not include Tx command bytes, post-MAC pad bytes,
-         *        MIC (CCM) 8 bytes, ICV (WEP/TKIP/CKIP) 4 bytes, CRC 4 bytes.i
-         * Range: 14-2342 bytes.
-         */
-        __le16 len;
-        /*
-         * MPDU or MSDU byte count for next frame.
-         * Used for fragmentation and bursting, but not 11n aggregation.
-         * Same as "len", but for next frame.  Set to 0 if not applicable.
-         */
-        __le16 next_frame_len;
-        __le32 tx_flags;        /* TX_CMD_FLG_* */
-        u8 rate;
-        /* Index of recipient station in uCode's station table */
-        u8 sta_id;
-        u8 tid_tspec;
-        u8 sec_ctl;
-        u8 key[16];
-        union {
-                u8 byte[8];
-                __le16 word[4];
-                __le32 dw[2];
-        } tkip_mic;
-        __le32 next_frame_info;
-        union {
-                __le32 life_time;
-                __le32 attempt;
-        } stop_time;
-        u8 supp_rates[2];
-        u8 rts_retry_limit;     /*byte 50 */
-        u8 data_retry_limit;    /*byte 51 */
-        union {
-                __le16 pm_frame_timeout;
-                __le16 attempt_duration;
-        } timeout;
-        /*
-         * Duration of EDCA burst Tx Opportunity, in 32-usec units.
-         * Set this if txop time is not specified by HCCA protocol (e.g. by AP).
-         */
-        __le16 driver_txop;
-        /*
-         * MAC header goes here, followed by 2 bytes padding if MAC header
-         * length is 26 or 30 bytes, followed by payload data
-         */
-        u8 payload[0];
-        struct ieee80211_hdr hdr[0];
-} __packed;
-/*
- * REPLY_TX = 0x1c (response)
- */
-struct iwl3945_tx_resp {
-        u8 failure_rts;
-        u8 failure_frame;
-        u8 bt_kill_count;
-        u8 rate;
-        __le32 wireless_media_time;
-        __le32 status;          /* TX status */
-} __packed;
 /*
 * 4965 uCode updates these Tx attempt count values in host DRAM.
 * Used for managing Tx retries when expecting block-acks.
@@ -1740,54 +1361,6 @@ struct iwl_tx_cmd {
        struct ieee80211_hdr hdr[0];
 } __packed;
-/* TX command response is sent after *3945* transmission attempts.
- *
- * NOTES:
- *
- * TX_STATUS_FAIL_NEXT_FRAG
- *
- * If the fragment flag in the MAC header for the frame being transmitted
- * is set and there is insufficient time to transmit the next frame, the
- * TX status will be returned with 'TX_STATUS_FAIL_NEXT_FRAG'.
- *
- * TX_STATUS_FIFO_UNDERRUN
- *
- * Indicates the host did not provide bytes to the FIFO fast enough while
- * a TX was in progress.
- *
- * TX_STATUS_FAIL_MGMNT_ABORT
- *
- * This status is only possible if the ABORT ON MGMT RX parameter was
- * set to true with the TX command.
- *
- * If the MSB of the status parameter is set then an abort sequence is
- * required.  This sequence consists of the host activating the TX Abort
- * control line, and then waiting for the TX Abort command response.  This
- * indicates that a the device is no longer in a transmit state, and that the
- * command FIFO has been cleared.  The host must then deactivate the TX Abort
- * control line.  Receiving is still allowed in this case.
- */
-enum {
-        TX_3945_STATUS_SUCCESS = 0x01,
-        TX_3945_STATUS_DIRECT_DONE = 0x02,
-        TX_3945_STATUS_FAIL_SHORT_LIMIT = 0x82,
-        TX_3945_STATUS_FAIL_LONG_LIMIT = 0x83,
-        TX_3945_STATUS_FAIL_FIFO_UNDERRUN = 0x84,
-        TX_3945_STATUS_FAIL_MGMNT_ABORT = 0x85,
-        TX_3945_STATUS_FAIL_NEXT_FRAG = 0x86,
-        TX_3945_STATUS_FAIL_LIFE_EXPIRE = 0x87,
-        TX_3945_STATUS_FAIL_DEST_PS = 0x88,
-        TX_3945_STATUS_FAIL_ABORTED = 0x89,
-        TX_3945_STATUS_FAIL_BT_RETRY = 0x8a,
-        TX_3945_STATUS_FAIL_STA_INVALID = 0x8b,
-        TX_3945_STATUS_FAIL_FRAG_DROPPED = 0x8c,
-        TX_3945_STATUS_FAIL_TID_DISABLE = 0x8d,
-        TX_3945_STATUS_FAIL_FRAME_FLUSHED = 0x8e,
-        TX_3945_STATUS_FAIL_INSUFFICIENT_CF_POLL = 0x8f,
-        TX_3945_STATUS_FAIL_TX_LOCKED = 0x90,
-        TX_3945_STATUS_FAIL_NO_BEACON_ON_RADAR = 0x91,
-};
 /*
 * TX command response is sent after *agn* transmission attempts.
 *
@@ -1905,43 +1478,6 @@ struct agg_tx_status {
        __le16 sequence;
 } __packed;
-struct iwl4965_tx_resp {
-        u8 frame_count;         /* 1 no aggregation, >1 aggregation */
-        u8 bt_kill_count;       /* # blocked by bluetooth (unused for agg) */
-        u8 failure_rts;         /* # failures due to unsuccessful RTS */
-        u8 failure_frame;       /* # failures due to no ACK (unused for agg) */
-        /* For non-agg:  Rate at which frame was successful.
-         * For agg:  Rate at which all frames were transmitted. */
-        __le32 rate_n_flags;    /* RATE_MCS_*  */
-        /* For non-agg:  RTS + CTS + frame tx attempts time + ACK.
-         * For agg:  RTS + CTS + aggregation tx time + block-ack time. */
-        __le16 wireless_media_time;     /* uSecs */
-        __le16 reserved;
-        __le32 pa_power1;       /* RF power amplifier measurement (not used) */
-        __le32 pa_power2;
-        /*
-         * For non-agg:  frame status TX_STATUS_*
-         * For agg:  status of 1st frame, AGG_TX_STATE_*; other frame status
-         *           fields follow this one, up to frame_count.
-         *           Bit fields:
-         *           11- 0:  AGG_TX_STATE_* status code
-         *           15-12:  Retry count for 1st frame in aggregation (retries
-         *                   occur if tx failed for this frame when it was a
-         *                   member of a previous aggregation block).  If rate
-         *                   scaling is used, retry count indicates the rate
-         *                   table entry used for all frames in the new agg.
-         *           31-16:  Sequence # for this frame's Tx cmd (not SSN!)
-         */
-        union {
-                __le32 status;
-                struct agg_tx_status agg_status[0]; /* for each agg frame */
-        } u;
-} __packed;
 /*
 * definitions for initial rate index field
 * bits [3:0] initial rate index
@@ -2030,51 +1566,7 @@ struct iwl_compressed_ba_resp {
 /*
 * REPLY_TX_PWR_TABLE_CMD = 0x97 (command, has simple generic response)
 *
- * See details under "TXPOWER" in iwl-4965-hw.h.
- */
-struct iwl3945_txpowertable_cmd {
-        u8 band;                /* 0: 5 GHz, 1: 2.4 GHz */
-        u8 reserved;
-        __le16 channel;
-        struct iwl3945_power_per_rate power[IWL_MAX_RATES];
-} __packed;
-struct iwl4965_txpowertable_cmd {
-        u8 band;                /* 0: 5 GHz, 1: 2.4 GHz */
-        u8 reserved;
-        __le16 channel;
-        struct iwl4965_tx_power_db tx_power;
-} __packed;
-/**
- * struct iwl3945_rate_scaling_cmd - Rate Scaling Command & Response
- *
- * REPLY_RATE_SCALE = 0x47 (command, has simple generic response)
- *
- * NOTE: The table of rates passed to the uCode via the
- * RATE_SCALE command sets up the corresponding order of
- * rates used for all related commands, including rate
- * masks, etc.
- *
- * For example, if you set 9MB (PLCP 0x0f) as the first
- * rate in the rate table, the bit mask for that rate
- * when passed through ofdm_basic_rates on the REPLY_RXON
- * command would be bit 0 (1 << 0)
 */
-struct iwl3945_rate_scaling_info {
-        __le16 rate_n_flags;
-        u8 try_cnt;
-        u8 next_rate_index;
-} __packed;
-struct iwl3945_rate_scaling_cmd {
-        u8 table_id;
-        u8 reserved[3];
-        struct iwl3945_rate_scaling_info table[IWL_MAX_RATES];
-} __packed;
 /*RS_NEW_API: only TLC_RTS remains and moved to bit 0 */
 #define  LINK_QUAL_FLAGS_SET_STA_TLC_RTS_MSK    (1 << 0)
@@ -2130,7 +1622,7 @@ struct iwl_link_qual_general_params {
 #define LINK_QUAL_AGG_DISABLE_START_MAX (255)
 #define LINK_QUAL_AGG_DISABLE_START_MIN (0)
-#define LINK_QUAL_AGG_FRAME_LIMIT_DEF   (31)
+#define LINK_QUAL_AGG_FRAME_LIMIT_DEF   (63)
 #define LINK_QUAL_AGG_FRAME_LIMIT_MAX   (63)
 #define LINK_QUAL_AGG_FRAME_LIMIT_MIN   (0)
@@ -2696,14 +2188,6 @@ struct iwl_spectrum_notification {
 #define IWL_POWER_BT_SCO_ENA                    cpu_to_le16(BIT(8))
 #define IWL_POWER_ADVANCE_PM_ENA_MSK            cpu_to_le16(BIT(9))
-struct iwl3945_powertable_cmd {
-        __le16 flags;
-        u8 reserved[2];
-        __le32 rx_data_timeout;
-        __le32 tx_data_timeout;
-        __le32 sleep_interval[IWL_POWER_VEC_SIZE];
-} __packed;
 struct iwl_powertable_cmd {
        __le16 flags;
        u8 keep_alive_seconds;          /* 3945 reserved */
@@ -2806,25 +2290,6 @@ struct iwl_ct_kill_throttling_config {
 *     active_dwell < max_out_time
 */
-/* FIXME: rename to AP1, remove tpc */
-struct iwl3945_scan_channel {
-        /*
-         * type is defined as:
-         * 0:0 1 = active, 0 = passive
-         * 1:4 SSID direct bit map; if a bit is set, then corresponding
-         *     SSID IE is transmitted in probe request.
-         * 5:7 reserved
-         */
-        u8 type;
-        u8 channel;     /* band is selected by iwl3945_scan_cmd "flags" field */
-        struct iwl3945_tx_power tpc;
-        __le16 active_dwell;    /* in 1024-uSec TU (time units), typ 5-50 */
-        __le16 passive_dwell;   /* in 1024-uSec TU (time units), typ 20-500 */
-} __packed;
-/* set number of direct probes u8 type */
-#define IWL39_SCAN_PROBE_MASK(n) ((BIT(n) | (BIT(n) - BIT(1))))
 struct iwl_scan_channel {
        /*
         * type is defined as:
@@ -2920,50 +2385,6 @@ struct iwl_ssid_ie {
 * struct iwl_scan_channel.
 */
-struct iwl3945_scan_cmd {
-        __le16 len;
-        u8 reserved0;
-        u8 channel_count;       /* # channels in channel list */
-        __le16 quiet_time;      /* dwell only this # millisecs on quiet channel
-                                 * (only for active scan) */
-        __le16 quiet_plcp_th;   /* quiet chnl is < this # pkts (typ. 1) */
-        __le16 good_CRC_th;     /* passive -> active promotion threshold */
-        __le16 reserved1;
-        __le32 max_out_time;    /* max usec to be away from associated (service)
-                                 * channel */
-        __le32 suspend_time;    /* pause scan this long (in "extended beacon
-                                 * format") when returning to service channel:
-                                 * 3945; 31:24 # beacons, 19:0 additional usec,
-                                 * 4965; 31:22 # beacons, 21:0 additional usec.
-                                 */
-        __le32 flags;           /* RXON_FLG_* */
-        __le32 filter_flags;    /* RXON_FILTER_* */
-        /* For active scans (set to all-0s for passive scans).
-         * Does not include payload.  Must specify Tx rate; no rate scaling. */
-        struct iwl3945_tx_cmd tx_cmd;
-        /* For directed active scans (set to all-0s otherwise) */
-        struct iwl_ssid_ie direct_scan[PROBE_OPTION_MAX_3945];
-        /*
-         * Probe request frame, followed by channel list.
-         *
-         * Size of probe request frame is specified by byte count in tx_cmd.
-         * Channel list follows immediately after probe request frame.
-         * Number of channels in list is specified by channel_count.
-         * Each channel in list is of type:
-         *
-         * struct iwl3945_scan_channel channels[0];
-         *
-         * NOTE:  Only one band of channels can be scanned per pass.  You
-         * must not mix 2.4GHz channels and 5.2GHz channels, and you must wait
-         * for one scan to complete (i.e. receive SCAN_COMPLETE_NOTIFICATION)
-         * before requesting another scan.
-         */
-        u8 data[0];
-} __packed;
 enum iwl_scan_flags {
        /* BIT(0) currently unused */
        IWL_SCAN_FLAGS_ACTION_FRAME_TX  = BIT(1),
@@ -3090,20 +2511,6 @@ enum iwl_ibss_manager {
 * BEACON_NOTIFICATION = 0x90 (notification only, not a command)
 */
-struct iwl3945_beacon_notif {
-        struct iwl3945_tx_resp beacon_notify_hdr;
-        __le32 low_tsf;
-        __le32 high_tsf;
-        __le32 ibss_mgr_status;
-} __packed;
-struct iwl4965_beacon_notif {
-        struct iwl4965_tx_resp beacon_notify_hdr;
-        __le32 low_tsf;
-        __le32 high_tsf;
-        __le32 ibss_mgr_status;
-} __packed;
 struct iwlagn_beacon_notif {
        struct iwlagn_tx_resp beacon_notify_hdr;
        __le32 low_tsf;
@@ -3115,14 +2522,6 @@ struct iwlagn_beacon_notif {
 * REPLY_TX_BEACON = 0x91 (command, has simple generic response)
 */
-struct iwl3945_tx_beacon_cmd {
-        struct iwl3945_tx_cmd tx;
-        __le16 tim_idx;
-        u8 tim_size;
-        u8 reserved1;
-        struct ieee80211_hdr frame[0];  /* beacon frame */
-} __packed;
 struct iwl_tx_beacon_cmd {
        struct iwl_tx_cmd tx;
        __le16 tim_idx;
@@ -3159,53 +2558,6 @@ struct rate_histogram {
 /* statistics command response */
-struct iwl39_statistics_rx_phy {
-        __le32 ina_cnt;
-        __le32 fina_cnt;
-        __le32 plcp_err;
-        __le32 crc32_err;
-        __le32 overrun_err;
-        __le32 early_overrun_err;
-        __le32 crc32_good;
-        __le32 false_alarm_cnt;
-        __le32 fina_sync_err_cnt;
-        __le32 sfd_timeout;
-        __le32 fina_timeout;
-        __le32 unresponded_rts;
-        __le32 rxe_frame_limit_overrun;
-        __le32 sent_ack_cnt;
-        __le32 sent_cts_cnt;
-} __packed;
-struct iwl39_statistics_rx_non_phy {
-        __le32 bogus_cts;       /* CTS received when not expecting CTS */
-        __le32 bogus_ack;       /* ACK received when not expecting ACK */
-        __le32 non_bssid_frames;        /* number of frames with BSSID that
-                                         * doesn't belong to the STA BSSID */
-        __le32 filtered_frames; /* count frames that were dumped in the
-                                 * filtering process */
-        __le32 non_channel_beacons;     /* beacons with our bss id but not on
-                                         * our serving channel */
-} __packed;
-struct iwl39_statistics_rx {
-        struct iwl39_statistics_rx_phy ofdm;
-        struct iwl39_statistics_rx_phy cck;
-        struct iwl39_statistics_rx_non_phy general;
-} __packed;
-struct iwl39_statistics_tx {
-        __le32 preamble_cnt;
-        __le32 rx_detected_cnt;
-        __le32 bt_prio_defer_cnt;
-        __le32 bt_prio_kill_cnt;
-        __le32 few_bytes_cnt;
-        __le32 cts_timeout;
-        __le32 ack_timeout;
-        __le32 expected_ack_cnt;
-        __le32 actual_ack_cnt;
-} __packed;
 struct statistics_dbg {
        __le32 burst_check;
        __le32 burst_count;
@@ -3213,23 +2565,6 @@ struct statistics_dbg {
        __le32 reserved[3];
 } __packed;
-struct iwl39_statistics_div {
-        __le32 tx_on_a;
-        __le32 tx_on_b;
-        __le32 exec_time;
-        __le32 probe_time;
-} __packed;
-struct iwl39_statistics_general {
-        __le32 temperature;
-        struct statistics_dbg dbg;
-        __le32 sleep_time;
-        __le32 slots_out;
-        __le32 slots_idle;
-        __le32 ttl_timestamp;
-        struct iwl39_statistics_div div;
-} __packed;
 struct statistics_rx_phy {
        __le32 ina_cnt;
        __le32 fina_cnt;
@@ -3471,13 +2806,6 @@ struct iwl_statistics_cmd {
 #define STATISTICS_REPLY_FLG_BAND_24G_MSK         cpu_to_le32(0x2)
 #define STATISTICS_REPLY_FLG_HT40_MODE_MSK        cpu_to_le32(0x8)
-struct iwl3945_notif_statistics {
-        __le32 flag;
-        struct iwl39_statistics_rx rx;
-        struct iwl39_statistics_tx tx;
-        struct iwl39_statistics_general general;
-} __packed;
 struct iwl_notif_statistics {
        __le32 flag;
        struct statistics_rx rx;
@@ -4451,10 +3779,6 @@ struct iwl_rx_packet {
        __le32 len_n_flags;
        struct iwl_cmd_header hdr;
        union {
-                struct iwl3945_rx_frame rx_frame;
-                struct iwl3945_tx_resp tx_resp;
-                struct iwl3945_beacon_notif beacon_status;
                struct iwl_alive_resp alive_frame;
                struct iwl_spectrum_notification spectrum_notif;
                struct iwl_csa_notification csa_notif;
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
index bafbe57c9602..4653deada05b 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.c
+++ b/drivers/net/wireless/iwlwifi/iwl-core.c
@@ -2,7 +2,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -41,6 +41,7 @@
 #include "iwl-power.h"
 #include "iwl-sta.h"
 #include "iwl-helpers.h"
+#include "iwl-agn.h"
 /*
@@ -67,30 +68,6 @@ u32 iwl_debug_level;
 const u8 iwl_bcast_addr[ETH_ALEN] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
-/* This function both allocates and initializes hw and priv. */
-struct ieee80211_hw *iwl_alloc_all(struct iwl_cfg *cfg)
-{
-        struct iwl_priv *priv;
-        /* mac80211 allocates memory for this device instance, including
-         *   space for this driver's private structure */
-        struct ieee80211_hw *hw;
-        hw = ieee80211_alloc_hw(sizeof(struct iwl_priv),
-                                cfg->ops->ieee80211_ops);
-        if (hw == NULL) {
-                pr_err("%s: Can not allocate network device\n",
-                       cfg->name);
-                goto out;
-        }
-        priv = hw->priv;
-        priv->hw = hw;
-out:
-        return hw;
-}
 #define MAX_BIT_RATE_40_MHZ 150 /* Mbps */
 #define MAX_BIT_RATE_20_MHZ 72 /* Mbps */
 static void iwlcore_init_ht_hw_capab(const struct iwl_priv *priv,
@@ -118,7 +95,7 @@ static void iwlcore_init_ht_hw_capab(const struct iwl_priv *priv,
                max_bit_rate = MAX_BIT_RATE_40_MHZ;
        }
-        if (priv->cfg->mod_params->amsdu_size_8K)
+        if (iwlagn_mod_params.amsdu_size_8K)
                ht_info->cap |= IEEE80211_HT_CAP_MAX_AMSDU;
        ht_info->ampdu_factor = CFG_HT_RX_AMPDU_FACTOR_DEF;
@@ -159,6 +136,7 @@ int iwlcore_init_geos(struct iwl_priv *priv)
        struct ieee80211_channel *geo_ch;
        struct ieee80211_rate *rates;
        int i = 0;
+        s8 max_tx_power = IWLAGN_TX_POWER_TARGET_POWER_MIN;
        if (priv->bands[IEEE80211_BAND_2GHZ].n_bitrates ||
            priv->bands[IEEE80211_BAND_5GHZ].n_bitrates) {
@@ -232,8 +210,8 @@ int iwlcore_init_geos(struct iwl_priv *priv)
                        geo_ch->flags |= ch->ht40_extension_channel;
-                        if (ch->max_power_avg > priv->tx_power_device_lmt)
+                        if (ch->max_power_avg > max_tx_power)
-                                priv->tx_power_device_lmt = ch->max_power_avg;
+                                max_tx_power = ch->max_power_avg;
                } else {
                        geo_ch->flags |= IEEE80211_CHAN_DISABLED;
                }
@@ -246,6 +224,10 @@ int iwlcore_init_geos(struct iwl_priv *priv)
                                 geo_ch->flags);
        }
+        priv->tx_power_device_lmt = max_tx_power;
+        priv->tx_power_user_lmt = max_tx_power;
+        priv->tx_power_next = max_tx_power;
        if ((priv->bands[IEEE80211_BAND_5GHZ].n_channels == 0) &&
             priv->cfg->sku & IWL_SKU_A) {
                IWL_INFO(priv, "Incorrectly detected BG card as ABG. "
@@ -434,72 +416,72 @@ void iwl_set_rxon_hwcrypto(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
 int iwl_check_rxon_cmd(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
 {
        struct iwl_rxon_cmd *rxon = &ctx->staging;
-        bool error = false;
+        u32 errors = 0;
        if (rxon->flags & RXON_FLG_BAND_24G_MSK) {
                if (rxon->flags & RXON_FLG_TGJ_NARROW_BAND_MSK) {
                        IWL_WARN(priv, "check 2.4G: wrong narrow\n");
-                        error = true;
+                        errors |= BIT(0);
                }
                if (rxon->flags & RXON_FLG_RADAR_DETECT_MSK) {
                        IWL_WARN(priv, "check 2.4G: wrong radar\n");
-                        error = true;
+                        errors |= BIT(1);
                }
        } else {
                if (!(rxon->flags & RXON_FLG_SHORT_SLOT_MSK)) {
                        IWL_WARN(priv, "check 5.2G: not short slot!\n");
-                        error = true;
+                        errors |= BIT(2);
                }
                if (rxon->flags & RXON_FLG_CCK_MSK) {
                        IWL_WARN(priv, "check 5.2G: CCK!\n");
-                        error = true;
+                        errors |= BIT(3);
                }
        }
        if ((rxon->node_addr[0] | rxon->bssid_addr[0]) & 0x1) {
                IWL_WARN(priv, "mac/bssid mcast!\n");
-                error = true;
+                errors |= BIT(4);
        }
        /* make sure basic rates 6Mbps and 1Mbps are supported */
        if ((rxon->ofdm_basic_rates & IWL_RATE_6M_MASK) == 0 &&
            (rxon->cck_basic_rates & IWL_RATE_1M_MASK) == 0) {
                IWL_WARN(priv, "neither 1 nor 6 are basic\n");
-                error = true;
+                errors |= BIT(5);
        }
        if (le16_to_cpu(rxon->assoc_id) > 2007) {
                IWL_WARN(priv, "aid > 2007\n");
-                error = true;
+                errors |= BIT(6);
        }
        if ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK))
                        == (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK)) {
                IWL_WARN(priv, "CCK and short slot\n");
-                error = true;
+                errors |= BIT(7);
        }
        if ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK))
                        == (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK)) {
                IWL_WARN(priv, "CCK and auto detect");
-                error = true;
+                errors |= BIT(8);
        }
        if ((rxon->flags & (RXON_FLG_AUTO_DETECT_MSK |
                            RXON_FLG_TGG_PROTECT_MSK)) ==
                            RXON_FLG_TGG_PROTECT_MSK) {
                IWL_WARN(priv, "TGg but no auto-detect\n");
-                error = true;
+                errors |= BIT(9);
        }
-        if (error)
+        if (rxon->channel == 0) {
-                IWL_WARN(priv, "Tuning to channel %d\n",
+                IWL_WARN(priv, "zero channel is invalid\n");
-                            le16_to_cpu(rxon->channel));
+                errors |= BIT(10);
-        if (error) {
-                IWL_ERR(priv, "Invalid RXON\n");
-                return -EINVAL;
        }
-        return 0;
+        WARN(errors, "Invalid RXON (%#x), channel %d",
+             errors, le16_to_cpu(rxon->channel));
+        return errors ? -EINVAL : 0;
 }
 /**
@@ -890,10 +872,21 @@ void iwl_print_rx_config_cmd(struct iwl_priv *priv,
        IWL_DEBUG_RADIO(priv, "u16 assoc_id: 0x%x\n", le16_to_cpu(rxon->assoc_id));
 }
 #endif
-/**
- * iwl_irq_handle_error - called for HW or SW error interrupt from card
+static void iwlagn_abort_notification_waits(struct iwl_priv *priv)
- */
+{
-void iwl_irq_handle_error(struct iwl_priv *priv)
+        unsigned long flags;
+        struct iwl_notification_wait *wait_entry;
+        spin_lock_irqsave(&priv->_agn.notif_wait_lock, flags);
+        list_for_each_entry(wait_entry, &priv->_agn.notif_waits, list)
+                wait_entry->aborted = true;
+        spin_unlock_irqrestore(&priv->_agn.notif_wait_lock, flags);
+        wake_up_all(&priv->_agn.notif_waitq);
+}
+void iwlagn_fw_error(struct iwl_priv *priv, bool ondemand)
 {
        unsigned int reload_msec;
        unsigned long reload_jiffies;
@@ -904,18 +897,64 @@ void iwl_irq_handle_error(struct iwl_priv *priv)
        /* Cancel currently queued command. */
        clear_bit(STATUS_HCMD_ACTIVE, &priv->status);
+        iwlagn_abort_notification_waits(priv);
+        /* Keep the restart process from trying to send host
+         * commands by clearing the ready bit */
+        clear_bit(STATUS_READY, &priv->status);
+        wake_up_interruptible(&priv->wait_command_queue);
+        if (!ondemand) {
+                /*
+                 * If firmware keep reloading, then it indicate something
+                 * serious wrong and firmware having problem to recover
+                 * from it. Instead of keep trying which will fill the syslog
+                 * and hang the system, let's just stop it
+                 */
+                reload_jiffies = jiffies;
+                reload_msec = jiffies_to_msecs((long) reload_jiffies -
+                                        (long) priv->reload_jiffies);
+                priv->reload_jiffies = reload_jiffies;
+                if (reload_msec <= IWL_MIN_RELOAD_DURATION) {
+                        priv->reload_count++;
+                        if (priv->reload_count >= IWL_MAX_CONTINUE_RELOAD_CNT) {
+                                IWL_ERR(priv, "BUG_ON, Stop restarting\n");
+                                return;
+                        }
+                } else
+                        priv->reload_count = 0;
+        }
+        if (!test_bit(STATUS_EXIT_PENDING, &priv->status)) {
+                if (iwlagn_mod_params.restart_fw) {
+                        IWL_DEBUG(priv, IWL_DL_FW_ERRORS,
+                                  "Restarting adapter due to uCode error.\n");
+                        queue_work(priv->workqueue, &priv->restart);
+                } else
+                        IWL_DEBUG(priv, IWL_DL_FW_ERRORS,
+                                  "Detected FW error, but not restarting\n");
+        }
+}
+/**
+ * iwl_irq_handle_error - called for HW or SW error interrupt from card
+ */
+void iwl_irq_handle_error(struct iwl_priv *priv)
+{
        /* W/A for WiFi/WiMAX coex and WiMAX own the RF */
        if (priv->cfg->internal_wimax_coex &&
            (!(iwl_read_prph(priv, APMG_CLK_CTRL_REG) &
                        APMS_CLK_VAL_MRB_FUNC_MODE) ||
             (iwl_read_prph(priv, APMG_PS_CTRL_REG) &
                        APMG_PS_CTRL_VAL_RESET_REQ))) {
-                wake_up_interruptible(&priv->wait_command_queue);
                /*
-                 *Keep the restart process from trying to send host
+                 * Keep the restart process from trying to send host
-                 * commands by clearing the INIT status bit
+                 * commands by clearing the ready bit.
                 */
                clear_bit(STATUS_READY, &priv->status);
+                clear_bit(STATUS_HCMD_ACTIVE, &priv->status);
+                wake_up_interruptible(&priv->wait_command_queue);
                IWL_ERR(priv, "RF is used by WiMAX\n");
                return;
        }
@@ -923,50 +962,17 @@ void iwl_irq_handle_error(struct iwl_priv *priv)
        IWL_ERR(priv, "Loaded firmware version: %s\n",
                priv->hw->wiphy->fw_version);
-        priv->cfg->ops->lib->dump_nic_error_log(priv);
+        iwl_dump_nic_error_log(priv);
-        if (priv->cfg->ops->lib->dump_csr)
+        iwl_dump_csr(priv);
-                priv->cfg->ops->lib->dump_csr(priv);
+        iwl_dump_fh(priv, NULL, false);
-        if (priv->cfg->ops->lib->dump_fh)
+        iwl_dump_nic_event_log(priv, false, NULL, false);
-                priv->cfg->ops->lib->dump_fh(priv, NULL, false);
-        priv->cfg->ops->lib->dump_nic_event_log(priv, false, NULL, false);
 #ifdef CONFIG_IWLWIFI_DEBUG
        if (iwl_get_debug_level(priv) & IWL_DL_FW_ERRORS)
                iwl_print_rx_config_cmd(priv,
                                        &priv->contexts[IWL_RXON_CTX_BSS]);
 #endif
-        wake_up_interruptible(&priv->wait_command_queue);
+        iwlagn_fw_error(priv, false);
-        /* Keep the restart process from trying to send host
-         * commands by clearing the INIT status bit */
-        clear_bit(STATUS_READY, &priv->status);
-        /*
-         * If firmware keep reloading, then it indicate something
-         * serious wrong and firmware having problem to recover
-         * from it. Instead of keep trying which will fill the syslog
-         * and hang the system, let's just stop it
-         */
-        reload_jiffies = jiffies;
-        reload_msec = jiffies_to_msecs((long) reload_jiffies -
-                                (long) priv->reload_jiffies);
-        priv->reload_jiffies = reload_jiffies;
-        if (reload_msec <= IWL_MIN_RELOAD_DURATION) {
-                priv->reload_count++;
-                if (priv->reload_count >= IWL_MAX_CONTINUE_RELOAD_CNT) {
-                        IWL_ERR(priv, "BUG_ON, Stop restarting\n");
-                        return;
-                }
-        } else
-                priv->reload_count = 0;
-        if (!test_bit(STATUS_EXIT_PENDING, &priv->status)) {
-                IWL_DEBUG(priv, IWL_DL_FW_ERRORS,
-                          "Restarting adapter due to uCode error.\n");
-                if (priv->cfg->mod_params->restart_fw)
-                        queue_work(priv->workqueue, &priv->restart);
-        }
 }
 static int iwl_apm_stop_master(struct iwl_priv *priv)
@@ -990,6 +996,8 @@ void iwl_apm_stop(struct iwl_priv *priv)
 {
        IWL_DEBUG_INFO(priv, "Stop card, put in low power state\n");
+        clear_bit(STATUS_DEVICE_ENABLED, &priv->status);
        /* Stop device's DMA activity */
        iwl_apm_stop_master(priv);
@@ -1040,7 +1048,6 @@ int iwl_apm_init(struct iwl_priv *priv)
        /*
         * Enable HAP INTA (interrupt from management bus) to
         * wake device's PCI Express link L1a -> L0s
-         * NOTE:  This is no-op for 3945 (non-existent bit)
         */
        iwl_set_bit(priv, CSR_HW_IF_CONFIG_REG,
                                    CSR_HW_IF_CONFIG_REG_BIT_HAP_WAKE_L1A);
@@ -1053,20 +1060,18 @@ int iwl_apm_init(struct iwl_priv *priv)
         * If not (unlikely), enable L0S, so there is at least some
         *    power savings, even without L1.
         */
-        if (priv->cfg->base_params->set_l0s) {
+        lctl = iwl_pcie_link_ctl(priv);
-                lctl = iwl_pcie_link_ctl(priv);
+        if ((lctl & PCI_CFG_LINK_CTRL_VAL_L1_EN) ==
-                if ((lctl & PCI_CFG_LINK_CTRL_VAL_L1_EN) ==
+                                PCI_CFG_LINK_CTRL_VAL_L1_EN) {
-                                        PCI_CFG_LINK_CTRL_VAL_L1_EN) {
+                /* L1-ASPM enabled; disable(!) L0S  */
-                        /* L1-ASPM enabled; disable(!) L0S  */
+                iwl_set_bit(priv, CSR_GIO_REG,
-                        iwl_set_bit(priv, CSR_GIO_REG,
+                                CSR_GIO_REG_VAL_L0S_ENABLED);
-                                        CSR_GIO_REG_VAL_L0S_ENABLED);
+                IWL_DEBUG_POWER(priv, "L1 Enabled; Disabling L0S\n");
-                        IWL_DEBUG_POWER(priv, "L1 Enabled; Disabling L0S\n");
+        } else {
-                } else {
+                /* L1-ASPM disabled; enable(!) L0S */
-                        /* L1-ASPM disabled; enable(!) L0S */
+                iwl_clear_bit(priv, CSR_GIO_REG,
-                        iwl_clear_bit(priv, CSR_GIO_REG,
+                                CSR_GIO_REG_VAL_L0S_ENABLED);
-                                        CSR_GIO_REG_VAL_L0S_ENABLED);
+                IWL_DEBUG_POWER(priv, "L1 Disabled; Enabling L0S\n");
-                        IWL_DEBUG_POWER(priv, "L1 Disabled; Enabling L0S\n");
-                }
        }
        /* Configure analog phase-lock-loop before activating to D0A */
@@ -1094,27 +1099,21 @@ int iwl_apm_init(struct iwl_priv *priv)
        }
        /*
-         * Enable DMA and BSM (if used) clocks, wait for them to stabilize.
+         * Enable DMA clock and wait for it to stabilize.
-         * BSM (Boostrap State Machine) is only in 3945 and 4965;
-         * later devices (i.e. 5000 and later) have non-volatile SRAM,
-         * and don't need BSM to restore data after power-saving sleep.
         *
         * Write to "CLK_EN_REG"; "1" bits enable clocks, while "0" bits
         * do not disable clocks.  This preserves any hardware bits already
         * set by default in "CLK_CTRL_REG" after reset.
         */
-        if (priv->cfg->base_params->use_bsm)
+        iwl_write_prph(priv, APMG_CLK_EN_REG, APMG_CLK_VAL_DMA_CLK_RQT);
-                iwl_write_prph(priv, APMG_CLK_EN_REG,
-                        APMG_CLK_VAL_DMA_CLK_RQT | APMG_CLK_VAL_BSM_CLK_RQT);
-        else
-                iwl_write_prph(priv, APMG_CLK_EN_REG,
-                        APMG_CLK_VAL_DMA_CLK_RQT);
        udelay(20);
        /* Disable L1-Active */
        iwl_set_bits_prph(priv, APMG_PCIDEV_STT_REG,
                          APMG_PCIDEV_STT_VAL_L1_ACT_DIS);
+        set_bit(STATUS_DEVICE_ENABLED, &priv->status);
 out:
        return ret;
 }
@@ -1430,7 +1429,6 @@ void iwl_mac_remove_interface(struct ieee80211_hw *hw,
        iwl_teardown_interface(priv, vif, false);
-        memset(priv->bssid, 0, ETH_ALEN);
        mutex_unlock(&priv->mutex);
        IWL_DEBUG_MAC80211(priv, "leave\n");
@@ -1750,21 +1748,13 @@ int iwl_force_reset(struct iwl_priv *priv, int mode, bool external)
                 * detect failure), then fw_restart module parameter
                 * need to be check before performing firmware reload
                 */
-                if (!external && !priv->cfg->mod_params->restart_fw) {
+                if (!external && !iwlagn_mod_params.restart_fw) {
                        IWL_DEBUG_INFO(priv, "Cancel firmware reload based on "
                                       "module parameter setting\n");
                        break;
                }
                IWL_ERR(priv, "On demand firmware reload\n");
-                /* Set the FW error flag -- cleared on iwl_down */
+                iwlagn_fw_error(priv, true);
-                set_bit(STATUS_FW_ERROR, &priv->status);
-                wake_up_interruptible(&priv->wait_command_queue);
-                /*
-                 * Keep the restart process from trying to send host
-                 * commands by clearing the INIT status bit
-                 */
-                clear_bit(STATUS_READY, &priv->status);
-                queue_work(priv->workqueue, &priv->restart);
                break;
        }
        return 0;
@@ -1775,6 +1765,7 @@ int iwl_mac_change_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 {
        struct iwl_priv *priv = hw->priv;
        struct iwl_rxon_context *ctx = iwl_rxon_ctx_from_vif(vif);
+        struct iwl_rxon_context *bss_ctx = &priv->contexts[IWL_RXON_CTX_BSS];
        struct iwl_rxon_context *tmp;
        u32 interface_modes;
        int err;
@@ -1783,6 +1774,15 @@ int iwl_mac_change_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
        mutex_lock(&priv->mutex);
+        if (!ctx->vif || !iwl_is_ready_rf(priv)) {
+                /*
+                 * Huh? But wait ... this can maybe happen when
+                 * we're in the middle of a firmware restart!
+                 */
+                err = -EBUSY;
+                goto out;
+        }
        interface_modes = ctx->interface_modes | ctx->exclusive_interface_modes;
        if (!(interface_modes & BIT(newtype))) {
@@ -1790,6 +1790,19 @@ int iwl_mac_change_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
                goto out;
        }
+        /*
+         * Refuse a change that should be done by moving from the PAN
+         * context to the BSS context instead, if the BSS context is
+         * available and can support the new interface type.
+         */
+        if (ctx->ctxid == IWL_RXON_CTX_PAN && !bss_ctx->vif &&
+            (bss_ctx->interface_modes & BIT(newtype) ||
+             bss_ctx->exclusive_interface_modes & BIT(newtype))) {
+                BUILD_BUG_ON(NUM_IWL_RXON_CTX != 2);
+                err = -EBUSY;
+                goto out;
+        }
        if (ctx->exclusive_interface_modes & BIT(newtype)) {
                for_each_context(priv, tmp) {
                        if (ctx == tmp)
@@ -1810,6 +1823,7 @@ int iwl_mac_change_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
        /* success */
        iwl_teardown_interface(priv, vif, true);
        vif->type = newtype;
+        vif->p2p = newp2p;
        err = iwl_setup_interface(priv, ctx);
        WARN_ON(err);
        /*
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.h b/drivers/net/wireless/iwlwifi/iwl-core.h
index b316d833d9a2..5b5b0cce4a54 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.h
+++ b/drivers/net/wireless/iwlwifi/iwl-core.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -73,7 +73,7 @@ struct iwl_cmd;
 #define IWLWIFI_VERSION "in-tree:"
-#define DRV_COPYRIGHT   "Copyright(c) 2003-2010 Intel Corporation"
+#define DRV_COPYRIGHT   "Copyright(c) 2003-2011 Intel Corporation"
 #define DRV_AUTHOR     "<ilw@linux.intel.com>"
 #define IWL_PCI_DEVICE(dev, subdev, cfg) \
@@ -90,7 +90,6 @@ struct iwl_cmd;
 #define IWL_CMD(x) case x: return #x
 struct iwl_hcmd_ops {
-        int (*rxon_assoc)(struct iwl_priv *priv, struct iwl_rxon_context *ctx);
        int (*commit_rxon)(struct iwl_priv *priv, struct iwl_rxon_context *ctx);
        void (*set_rxon_chain)(struct iwl_priv *priv,
                               struct iwl_rxon_context *ctx);
@@ -100,7 +99,6 @@ struct iwl_hcmd_ops {
 };
 struct iwl_hcmd_utils_ops {
-        u16 (*get_hcmd_size)(u8 cmd_id, u16 len);
        u16 (*build_addsta_hcmd)(const struct iwl_addsta_cmd *cmd, u8 *data);
        void (*gain_computation)(struct iwl_priv *priv,
                        u32 *average_noise,
@@ -122,46 +120,14 @@ struct iwl_apm_ops {
        void (*config)(struct iwl_priv *priv);
 };
-struct iwl_isr_ops {
-        irqreturn_t (*isr) (int irq, void *data);
-        void (*free)(struct iwl_priv *priv);
-        int (*alloc)(struct iwl_priv *priv);
-        int (*reset)(struct iwl_priv *priv);
-        void (*disable)(struct iwl_priv *priv);
-};
-struct iwl_debugfs_ops {
-        ssize_t (*rx_stats_read)(struct file *file, char __user *user_buf,
-                                 size_t count, loff_t *ppos);
-        ssize_t (*tx_stats_read)(struct file *file, char __user *user_buf,
-                                 size_t count, loff_t *ppos);
-        ssize_t (*general_stats_read)(struct file *file, char __user *user_buf,
-                                      size_t count, loff_t *ppos);
-        ssize_t (*bt_stats_read)(struct file *file, char __user *user_buf,
-                                 size_t count, loff_t *ppos);
-        ssize_t (*reply_tx_error)(struct file *file, char __user *user_buf,
-                                 size_t count, loff_t *ppos);
-};
 struct iwl_temp_ops {
        void (*temperature)(struct iwl_priv *priv);
 };
-struct iwl_tt_ops {
-        bool (*lower_power_detection)(struct iwl_priv *priv);
-        u8 (*tt_power_mode)(struct iwl_priv *priv);
-        bool (*ct_kill_check)(struct iwl_priv *priv);
-};
 struct iwl_lib_ops {
        /* set hw dependent parameters */
        int (*set_hw_params)(struct iwl_priv *priv);
        /* Handling TX */
-        void (*txq_update_byte_cnt_tbl)(struct iwl_priv *priv,
-                                        struct iwl_tx_queue *txq,
-                                        u16 byte_cnt);
-        void (*txq_inval_byte_cnt_tbl)(struct iwl_priv *priv,
-                                       struct iwl_tx_queue *txq);
        void (*txq_set_sched)(struct iwl_priv *priv, u32 mask);
        int (*txq_attach_buf_to_tfd)(struct iwl_priv *priv,
                                     struct iwl_tx_queue *txq,
@@ -171,30 +137,14 @@ struct iwl_lib_ops {
                             struct iwl_tx_queue *txq);
        int (*txq_init)(struct iwl_priv *priv,
                        struct iwl_tx_queue *txq);
-        /* aggregations */
-        int (*txq_agg_enable)(struct iwl_priv *priv, int txq_id, int tx_fifo,
-                              int sta_id, int tid, u16 ssn_idx);
-        int (*txq_agg_disable)(struct iwl_priv *priv, u16 txq_id, u16 ssn_idx,
-                               u8 tx_fifo);
        /* setup Rx handler */
        void (*rx_handler_setup)(struct iwl_priv *priv);
        /* setup deferred work */
        void (*setup_deferred_work)(struct iwl_priv *priv);
        /* cancel deferred work */
        void (*cancel_deferred_work)(struct iwl_priv *priv);
-        /* alive notification after init uCode load */
-        void (*init_alive_start)(struct iwl_priv *priv);
-        /* alive notification */
-        int (*alive_notify)(struct iwl_priv *priv);
        /* check validity of rtc data address */
        int (*is_valid_rtc_data_addr)(u32 addr);
-        /* 1st ucode load */
-        int (*load_ucode)(struct iwl_priv *priv);
-        int (*dump_nic_event_log)(struct iwl_priv *priv,
-                                  bool full_log, char **buf, bool display);
-        void (*dump_nic_error_log)(struct iwl_priv *priv);
-        void (*dump_csr)(struct iwl_priv *priv);
-        int (*dump_fh)(struct iwl_priv *priv, char **buf, bool display);
        int (*set_channel_switch)(struct iwl_priv *priv,
                                  struct ieee80211_channel_switch *ch_switch);
        /* power management */
@@ -204,9 +154,6 @@ struct iwl_lib_ops {
        int (*send_tx_power) (struct iwl_priv *priv);
        void (*update_chain_flags)(struct iwl_priv *priv);
-        /* isr */
-        struct iwl_isr_ops isr_ops;
        /* eeprom operations (as defined in iwl-eeprom.h) */
        struct iwl_eeprom_ops eeprom_ops;
@@ -216,14 +163,6 @@ struct iwl_lib_ops {
        int (*txfifo_flush)(struct iwl_priv *priv, u16 flush_control);
        void (*dev_txfifo_flush)(struct iwl_priv *priv, u16 flush_control);
-        struct iwl_debugfs_ops debugfs_ops;
-        /* thermal throttling */
-        struct iwl_tt_ops tt_ops;
-};
-struct iwl_led_ops {
-        int (*cmd)(struct iwl_priv *priv, struct iwl_led_cmd *led_cmd);
 };
 /* NIC specific ops */
@@ -231,28 +170,15 @@ struct iwl_nic_ops {
        void (*additional_nic_config)(struct iwl_priv *priv);
 };
-struct iwl_legacy_ops {
-        void (*post_associate)(struct iwl_priv *priv);
-        void (*config_ap)(struct iwl_priv *priv);
-        /* station management */
-        int (*update_bcast_stations)(struct iwl_priv *priv);
-        int (*manage_ibss_station)(struct iwl_priv *priv,
-                                   struct ieee80211_vif *vif, bool add);
-};
 struct iwl_ops {
        const struct iwl_lib_ops *lib;
        const struct iwl_hcmd_ops *hcmd;
        const struct iwl_hcmd_utils_ops *utils;
-        const struct iwl_led_ops *led;
        const struct iwl_nic_ops *nic;
-        const struct iwl_legacy_ops *legacy;
-        const struct ieee80211_ops *ieee80211_ops;
 };
 struct iwl_mod_params {
        int sw_crypto;          /* def: 0 = using hardware encryption */
-        int disable_hw_scan;    /* def: 0 = use h/w scan */
        int num_of_queues;      /* def: HW dependent */
        int disable_11n;        /* def: 0 = 11n capabilities enabled */
        int amsdu_size_8K;      /* def: 1 = enable 8K amsdu size */
@@ -278,16 +204,7 @@ struct iwl_mod_params {
 * @wd_timeout: TX queues watchdog timeout
 * @temperature_kelvin: temperature report by uCode in kelvin
 * @max_event_log_size: size of event log buffer size for ucode event logging
- * @tx_power_by_driver: tx power calibration performed by driver
- *      instead of uCode
- * @ucode_tracing: support ucode continuous tracing
- * @sensitivity_calib_by_driver: driver has the capability to perform
- *      sensitivity calibration operation
- * @chain_noise_calib_by_driver: driver has the capability to perform
- *      chain noise calibration operation
 * @shadow_reg_enable: HW shadhow register bit
- * @no_agg_framecnt_info: uCode do not provide aggregation frame count
- *      information
 */
 struct iwl_base_params {
        int eeprom_size;
@@ -295,14 +212,10 @@ struct iwl_base_params {
        int num_of_ampdu_queues;/* def: HW dependent */
        /* for iwl_apm_init() */
        u32 pll_cfg_val;
-        bool set_l0s;
-        bool use_bsm;
-        bool use_isr_legacy;
        const u16 max_ll_items;
        const bool shadow_ram_support;
        u16 led_compensation;
-        const bool broken_powersave;
        int chain_noise_num_beacons;
        bool adv_thermal_throttle;
        bool support_ct_kill_exit;
@@ -312,18 +225,12 @@ struct iwl_base_params {
        unsigned int wd_timeout;
        bool temperature_kelvin;
        u32 max_event_log_size;
-        const bool tx_power_by_driver;
-        const bool ucode_tracing;
-        const bool sensitivity_calib_by_driver;
-        const bool chain_noise_calib_by_driver;
        const bool shadow_reg_enable;
-        const bool no_agg_framecnt_info;
 };
 /*
 * @advanced_bt_coexist: support advanced bt coexist
 * @bt_init_traffic_load: specify initial bt traffic load
 * @bt_prio_boost: default bt priority boost value
- * @bt_statistics: use BT version of statistics notification
 * @agg_time_limit: maximum number of uSec in aggregation
 * @ampdu_factor: Maximum A-MPDU length factor
 * @ampdu_density: Minimum A-MPDU spacing
@@ -333,7 +240,6 @@ struct iwl_bt_params {
        bool advanced_bt_coexist;
        u8 bt_init_traffic_load;
        u8 bt_prio_boost;
-        const bool bt_statistics;
        u16 agg_time_limit;
        u8 ampdu_factor;
        u8 ampdu_density;
@@ -364,6 +270,7 @@ struct iwl_ht_params {
 * @rx_with_siso_diversity: 1x1 device with rx antenna diversity
 * @internal_wimax_coex: internal wifi/wimax combo device
 * @iq_invert: I/Q inversion
+ * @disable_otp_refresh: disable OTP refresh current limit
 *
 * We enable the driver to be backward compatible wrt API version. The
 * driver specifies which APIs it supports (with @ucode_api_max being the
@@ -398,8 +305,6 @@ struct iwl_cfg {
        u16  eeprom_ver;
        u16  eeprom_calib_ver;
        const struct iwl_ops *ops;
-        /* module based parameters which can be set from modprobe cmd */
-        const struct iwl_mod_params *mod_params;
        /* params not likely to change within a device family */
        struct iwl_base_params *base_params;
        /* params likely to change within a device family */
@@ -414,13 +319,13 @@ struct iwl_cfg {
        const bool rx_with_siso_diversity;
        const bool internal_wimax_coex;
        const bool iq_invert;
+        const bool disable_otp_refresh;
 };
 /***************************
 *   L i b                 *
 ***************************/
-struct ieee80211_hw *iwl_alloc_all(struct iwl_cfg *cfg);
 int iwl_mac_conf_tx(struct ieee80211_hw *hw, u16 queue,
                    const struct ieee80211_tx_queue_params *params);
 int iwl_mac_tx_last_beacon(struct ieee80211_hw *hw);
@@ -625,6 +530,8 @@ extern const struct dev_pm_ops iwl_pm_ops;
 void iwl_dump_nic_error_log(struct iwl_priv *priv);
 int iwl_dump_nic_event_log(struct iwl_priv *priv,
                           bool full_log, char **buf, bool display);
+void iwl_dump_csr(struct iwl_priv *priv);
+int iwl_dump_fh(struct iwl_priv *priv, char **buf, bool display);
 #ifdef CONFIG_IWLWIFI_DEBUG
 void iwl_print_rx_config_cmd(struct iwl_priv *priv,
                             struct iwl_rxon_context *ctx);
@@ -662,6 +569,7 @@ void iwlcore_free_geos(struct iwl_priv *priv);
 #define STATUS_SCAN_HW          15
 #define STATUS_POWER_PMI        16
 #define STATUS_FW_ERROR         17
+#define STATUS_DEVICE_ENABLED   18
 static inline int iwl_is_ready(struct iwl_priv *priv)
@@ -714,11 +622,6 @@ void iwl_apm_stop(struct iwl_priv *priv);
 int iwl_apm_init(struct iwl_priv *priv);
 int iwl_send_rxon_timing(struct iwl_priv *priv, struct iwl_rxon_context *ctx);
-static inline int iwl_send_rxon_assoc(struct iwl_priv *priv,
-                                      struct iwl_rxon_context *ctx)
-{
-        return priv->cfg->ops->hcmd->rxon_assoc(priv, ctx);
-}
 static inline int iwlcore_commit_rxon(struct iwl_priv *priv,
                                      struct iwl_rxon_context *ctx)
 {
@@ -736,12 +639,10 @@ static inline bool iwl_advanced_bt_coexist(struct iwl_priv *priv)
               priv->cfg->bt_params->advanced_bt_coexist;
 }
-static inline bool iwl_bt_statistics(struct iwl_priv *priv)
-{
-        return priv->cfg->bt_params && priv->cfg->bt_params->bt_statistics;
-}
 extern bool bt_coex_active;
 extern bool bt_siso_mode;
+void iwlagn_fw_error(struct iwl_priv *priv, bool ondemand);
 #endif /* __iwl_core_h__ */
diff --git a/drivers/net/wireless/iwlwifi/iwl-csr.h b/drivers/net/wireless/iwlwifi/iwl-csr.h
index f52bc040bcbf..5ab90ba7a024 100644
--- a/drivers/net/wireless/iwlwifi/iwl-csr.h
+++ b/drivers/net/wireless/iwlwifi/iwl-csr.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -155,18 +155,10 @@
 #define CSR_DBG_LINK_PWR_MGMT_REG       (CSR_BASE+0x250)
 /* Bits for CSR_HW_IF_CONFIG_REG */
-#define CSR49_HW_IF_CONFIG_REG_BIT_4965_R       (0x00000010)
 #define CSR_HW_IF_CONFIG_REG_MSK_BOARD_VER      (0x00000C00)
 #define CSR_HW_IF_CONFIG_REG_BIT_MAC_SI         (0x00000100)
 #define CSR_HW_IF_CONFIG_REG_BIT_RADIO_SI       (0x00000200)
-#define CSR39_HW_IF_CONFIG_REG_BIT_3945_MB         (0x00000100)
-#define CSR39_HW_IF_CONFIG_REG_BIT_3945_MM         (0x00000200)
-#define CSR39_HW_IF_CONFIG_REG_BIT_SKU_MRC            (0x00000400)
-#define CSR39_HW_IF_CONFIG_REG_BIT_BOARD_TYPE         (0x00000800)
-#define CSR39_HW_IF_CONFIG_REG_BITS_SILICON_TYPE_A    (0x00000000)
-#define CSR39_HW_IF_CONFIG_REG_BITS_SILICON_TYPE_B    (0x00001000)
 #define CSR_HW_IF_CONFIG_REG_BIT_HAP_WAKE_L1A   (0x00080000)
 #define CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM (0x00200000)
 #define CSR_HW_IF_CONFIG_REG_BIT_NIC_READY      (0x00400000) /* PCI_OWN_SEM */
@@ -186,7 +178,7 @@
 #define CSR_INT_BIT_SW_ERR       (1 << 25) /* uCode error */
 #define CSR_INT_BIT_RF_KILL      (1 << 7)  /* HW RFKILL switch GP_CNTRL[27] toggled */
 #define CSR_INT_BIT_CT_KILL      (1 << 6)  /* Critical temp (chip too hot) rfkill */
-#define CSR_INT_BIT_SW_RX        (1 << 3)  /* Rx, command responses, 3945 */
+#define CSR_INT_BIT_SW_RX        (1 << 3)  /* Rx, command responses */
 #define CSR_INT_BIT_WAKEUP       (1 << 1)  /* NIC controller waking up (pwr mgmt) */
 #define CSR_INT_BIT_ALIVE        (1 << 0)  /* uCode interrupts once it initializes */
@@ -202,29 +194,17 @@
 /* interrupt flags in FH (flow handler) (PCI busmaster DMA) */
 #define CSR_FH_INT_BIT_ERR       (1 << 31) /* Error */
 #define CSR_FH_INT_BIT_HI_PRIOR  (1 << 30) /* High priority Rx, bypass coalescing */
-#define CSR39_FH_INT_BIT_RX_CHNL2  (1 << 18) /* Rx channel 2 (3945 only) */
 #define CSR_FH_INT_BIT_RX_CHNL1  (1 << 17) /* Rx channel 1 */
 #define CSR_FH_INT_BIT_RX_CHNL0  (1 << 16) /* Rx channel 0 */
-#define CSR39_FH_INT_BIT_TX_CHNL6  (1 << 6)  /* Tx channel 6 (3945 only) */
 #define CSR_FH_INT_BIT_TX_CHNL1  (1 << 1)  /* Tx channel 1 */
 #define CSR_FH_INT_BIT_TX_CHNL0  (1 << 0)  /* Tx channel 0 */
-#define CSR39_FH_INT_RX_MASK    (CSR_FH_INT_BIT_HI_PRIOR | \
+#define CSR_FH_INT_RX_MASK      (CSR_FH_INT_BIT_HI_PRIOR | \
-                                 CSR39_FH_INT_BIT_RX_CHNL2 | \
+                                CSR_FH_INT_BIT_RX_CHNL1 | \
-                                 CSR_FH_INT_BIT_RX_CHNL1 | \
+                                CSR_FH_INT_BIT_RX_CHNL0)
-                                 CSR_FH_INT_BIT_RX_CHNL0)
-#define CSR39_FH_INT_TX_MASK    (CSR39_FH_INT_BIT_TX_CHNL6 | \
-                                 CSR_FH_INT_BIT_TX_CHNL1 | \
-                                 CSR_FH_INT_BIT_TX_CHNL0)
-#define CSR49_FH_INT_RX_MASK    (CSR_FH_INT_BIT_HI_PRIOR | \
-                                 CSR_FH_INT_BIT_RX_CHNL1 | \
-                                 CSR_FH_INT_BIT_RX_CHNL0)
-#define CSR49_FH_INT_TX_MASK    (CSR_FH_INT_BIT_TX_CHNL1 | \
+#define CSR_FH_INT_TX_MASK      (CSR_FH_INT_BIT_TX_CHNL1 | \
-                                 CSR_FH_INT_BIT_TX_CHNL0)
+                                CSR_FH_INT_BIT_TX_CHNL0)
 /* GPIO */
 #define CSR_GPIO_IN_BIT_AUX_POWER                   (0x00000200)
@@ -268,7 +248,7 @@
 *         Indicates MAC (ucode processor, etc.) is powered up and can run.
 *         Internal resources are accessible.
 *         NOTE:  This does not indicate that the processor is actually running.
- *         NOTE:  This does not indicate that 4965 or 3945 has completed
+ *         NOTE:  This does not indicate that device has completed
 *                init or post-power-down restore of internal SRAM memory.
 *                Use CSR_UCODE_DRV_GP1_BIT_MAC_SLEEP as indication that
 *                SRAM is restored and uCode is in normal operation mode.
@@ -291,8 +271,6 @@
 /* HW REV */
 #define CSR_HW_REV_TYPE_MSK            (0x00001F0)
-#define CSR_HW_REV_TYPE_3945           (0x00000D0)
-#define CSR_HW_REV_TYPE_4965           (0x0000000)
 #define CSR_HW_REV_TYPE_5300           (0x0000020)
 #define CSR_HW_REV_TYPE_5350           (0x0000030)
 #define CSR_HW_REV_TYPE_5100           (0x0000050)
@@ -363,7 +341,7 @@
 *     0:  MAC_SLEEP
 *         uCode sets this when preparing a power-saving power-down.
 *         uCode resets this when power-up is complete and SRAM is sane.
- *         NOTE:  3945/4965 saves internal SRAM data to host when powering down,
+ *         NOTE:  device saves internal SRAM data to host when powering down,
 *                and must restore this data after powering back up.
 *                MAC_SLEEP is the best indication that restore is complete.
 *                Later devices (5xxx/6xxx/1xxx) use non-volatile SRAM, and
@@ -394,7 +372,6 @@
 #define CSR_LED_REG_TRUN_OFF (0x38)
 /* ANA_PLL */
-#define CSR39_ANA_PLL_CFG_VAL        (0x01000000)
 #define CSR50_ANA_PLL_CFG_VAL        (0x00880300)
 /* HPET MEM debug */
diff --git a/drivers/net/wireless/iwlwifi/iwl-debug.h b/drivers/net/wireless/iwlwifi/iwl-debug.h
index ebdea3be3ef9..2824ccbcc1fc 100644
--- a/drivers/net/wireless/iwlwifi/iwl-debug.h
+++ b/drivers/net/wireless/iwlwifi/iwl-debug.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project.
 *
@@ -146,7 +146,6 @@ static inline void iwl_dbgfs_unregister(struct iwl_priv *priv)
 #define IWL_DL_RX               (1 << 24)
 #define IWL_DL_ISR              (1 << 25)
 #define IWL_DL_HT               (1 << 26)
-#define IWL_DL_IO               (1 << 27)
 /* 0xF0000000 - 0x10000000 */
 #define IWL_DL_11H              (1 << 28)
 #define IWL_DL_STATS            (1 << 29)
@@ -174,7 +173,6 @@ static inline void iwl_dbgfs_unregister(struct iwl_priv *priv)
                IWL_DEBUG_LIMIT(p, IWL_DL_DROP, f, ## a)
 #define IWL_DEBUG_AP(p, f, a...)        IWL_DEBUG(p, IWL_DL_AP, f, ## a)
 #define IWL_DEBUG_TXPOWER(p, f, a...)   IWL_DEBUG(p, IWL_DL_TXPOWER, f, ## a)
-#define IWL_DEBUG_IO(p, f, a...)        IWL_DEBUG(p, IWL_DL_IO, f, ## a)
 #define IWL_DEBUG_RATE(p, f, a...)      IWL_DEBUG(p, IWL_DL_RATE, f, ## a)
 #define IWL_DEBUG_RATE_LIMIT(p, f, a...)        \
                IWL_DEBUG_LIMIT(p, IWL_DL_RATE, f, ## a)
diff --git a/drivers/net/wireless/iwlwifi/iwl-debugfs.c b/drivers/net/wireless/iwlwifi/iwl-debugfs.c
index 8842411f1cf3..0e6a04b739ad 100644
--- a/drivers/net/wireless/iwlwifi/iwl-debugfs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-debugfs.c
@@ -2,7 +2,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -39,6 +39,7 @@
 #include "iwl-debug.h"
 #include "iwl-core.h"
 #include "iwl-io.h"
+#include "iwl-agn.h"
 /* create and remove of files */
 #define DEBUGFS_ADD_FILE(name, parent, mode) do {                       \
@@ -226,10 +227,10 @@ static ssize_t iwl_dbgfs_sram_read(struct file *file,
        /* default is to dump the entire data segment */
        if (!priv->dbgfs_sram_offset && !priv->dbgfs_sram_len) {
                priv->dbgfs_sram_offset = 0x800000;
-                if (priv->ucode_type == UCODE_INIT)
+                if (priv->ucode_type == UCODE_SUBTYPE_INIT)
-                        priv->dbgfs_sram_len = priv->ucode_init_data.len;
+                        priv->dbgfs_sram_len = priv->ucode_init.data.len;
                else
-                        priv->dbgfs_sram_len = priv->ucode_data.len;
+                        priv->dbgfs_sram_len = priv->ucode_rt.data.len;
        }
        len = priv->dbgfs_sram_len;
@@ -437,8 +438,7 @@ static ssize_t iwl_dbgfs_log_event_read(struct file *file,
        int pos = 0;
        ssize_t ret = -ENOMEM;
-        ret = pos = priv->cfg->ops->lib->dump_nic_event_log(
+        ret = pos = iwl_dump_nic_event_log(priv, true, &buf, true);
-                                        priv, true, &buf, true);
        if (buf) {
                ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
                kfree(buf);
@@ -462,8 +462,7 @@ static ssize_t iwl_dbgfs_log_event_write(struct file *file,
        if (sscanf(buf, "%d", &event_log_flag) != 1)
                return -EFAULT;
        if (event_log_flag == 1)
-                priv->cfg->ops->lib->dump_nic_event_log(priv, true,
+                iwl_dump_nic_event_log(priv, true, NULL, false);
-                                                        NULL, false);
        return count;
 }
@@ -1039,13 +1038,463 @@ static ssize_t iwl_dbgfs_rx_queue_read(struct file *file,
        return simple_read_from_buffer(user_buf, count, ppos, buf, pos);
 }
+static const char *fmt_value = "  %-30s %10u\n";
+static const char *fmt_hex   = "  %-30s       0x%02X\n";
+static const char *fmt_table = "  %-30s %10u  %10u  %10u  %10u\n";
+static const char *fmt_header =
+        "%-32s    current  cumulative       delta         max\n";
+static int iwl_statistics_flag(struct iwl_priv *priv, char *buf, int bufsz)
+{
+        int p = 0;
+        u32 flag;
+        flag = le32_to_cpu(priv->statistics.flag);
+        p += scnprintf(buf + p, bufsz - p, "Statistics Flag(0x%X):\n", flag);
+        if (flag & UCODE_STATISTICS_CLEAR_MSK)
+                p += scnprintf(buf + p, bufsz - p,
+                "\tStatistics have been cleared\n");
+        p += scnprintf(buf + p, bufsz - p, "\tOperational Frequency: %s\n",
+                (flag & UCODE_STATISTICS_FREQUENCY_MSK)
+                ? "2.4 GHz" : "5.2 GHz");
+        p += scnprintf(buf + p, bufsz - p, "\tTGj Narrow Band: %s\n",
+                (flag & UCODE_STATISTICS_NARROW_BAND_MSK)
+                 ? "enabled" : "disabled");
+        return p;
+}
 static ssize_t iwl_dbgfs_ucode_rx_stats_read(struct file *file,
                                        char __user *user_buf,
                                        size_t count, loff_t *ppos)
 {
        struct iwl_priv *priv = file->private_data;
-        return priv->cfg->ops->lib->debugfs_ops.rx_stats_read(file,
+        int pos = 0;
-                        user_buf, count, ppos);
+        char *buf;
+        int bufsz = sizeof(struct statistics_rx_phy) * 40 +
+                    sizeof(struct statistics_rx_non_phy) * 40 +
+                    sizeof(struct statistics_rx_ht_phy) * 40 + 400;
+        ssize_t ret;
+        struct statistics_rx_phy *ofdm, *accum_ofdm, *delta_ofdm, *max_ofdm;
+        struct statistics_rx_phy *cck, *accum_cck, *delta_cck, *max_cck;
+        struct statistics_rx_non_phy *general, *accum_general;
+        struct statistics_rx_non_phy *delta_general, *max_general;
+        struct statistics_rx_ht_phy *ht, *accum_ht, *delta_ht, *max_ht;
+        if (!iwl_is_alive(priv))
+                return -EAGAIN;
+        buf = kzalloc(bufsz, GFP_KERNEL);
+        if (!buf) {
+                IWL_ERR(priv, "Can not allocate Buffer\n");
+                return -ENOMEM;
+        }
+        /*
+         * the statistic information display here is based on
+         * the last statistics notification from uCode
+         * might not reflect the current uCode activity
+         */
+        ofdm = &priv->statistics.rx_ofdm;
+        cck = &priv->statistics.rx_cck;
+        general = &priv->statistics.rx_non_phy;
+        ht = &priv->statistics.rx_ofdm_ht;
+        accum_ofdm = &priv->accum_stats.rx_ofdm;
+        accum_cck = &priv->accum_stats.rx_cck;
+        accum_general = &priv->accum_stats.rx_non_phy;
+        accum_ht = &priv->accum_stats.rx_ofdm_ht;
+        delta_ofdm = &priv->delta_stats.rx_ofdm;
+        delta_cck = &priv->delta_stats.rx_cck;
+        delta_general = &priv->delta_stats.rx_non_phy;
+        delta_ht = &priv->delta_stats.rx_ofdm_ht;
+        max_ofdm = &priv->max_delta_stats.rx_ofdm;
+        max_cck = &priv->max_delta_stats.rx_cck;
+        max_general = &priv->max_delta_stats.rx_non_phy;
+        max_ht = &priv->max_delta_stats.rx_ofdm_ht;
+        pos += iwl_statistics_flag(priv, buf, bufsz);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_header, "Statistics_Rx - OFDM:");
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "ina_cnt:",
+                         le32_to_cpu(ofdm->ina_cnt),
+                         accum_ofdm->ina_cnt,
+                         delta_ofdm->ina_cnt, max_ofdm->ina_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "fina_cnt:",
+                         le32_to_cpu(ofdm->fina_cnt), accum_ofdm->fina_cnt,
+                         delta_ofdm->fina_cnt, max_ofdm->fina_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "plcp_err:",
+                         le32_to_cpu(ofdm->plcp_err), accum_ofdm->plcp_err,
+                         delta_ofdm->plcp_err, max_ofdm->plcp_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "crc32_err:",
+                         le32_to_cpu(ofdm->crc32_err), accum_ofdm->crc32_err,
+                         delta_ofdm->crc32_err, max_ofdm->crc32_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "overrun_err:",
+                         le32_to_cpu(ofdm->overrun_err),
+                         accum_ofdm->overrun_err, delta_ofdm->overrun_err,
+                         max_ofdm->overrun_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "early_overrun_err:",
+                         le32_to_cpu(ofdm->early_overrun_err),
+                         accum_ofdm->early_overrun_err,
+                         delta_ofdm->early_overrun_err,
+                         max_ofdm->early_overrun_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "crc32_good:",
+                         le32_to_cpu(ofdm->crc32_good),
+                         accum_ofdm->crc32_good, delta_ofdm->crc32_good,
+                         max_ofdm->crc32_good);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "false_alarm_cnt:",
+                         le32_to_cpu(ofdm->false_alarm_cnt),
+                         accum_ofdm->false_alarm_cnt,
+                         delta_ofdm->false_alarm_cnt,
+                         max_ofdm->false_alarm_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "fina_sync_err_cnt:",
+                         le32_to_cpu(ofdm->fina_sync_err_cnt),
+                         accum_ofdm->fina_sync_err_cnt,
+                         delta_ofdm->fina_sync_err_cnt,
+                         max_ofdm->fina_sync_err_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "sfd_timeout:",
+                         le32_to_cpu(ofdm->sfd_timeout),
+                         accum_ofdm->sfd_timeout, delta_ofdm->sfd_timeout,
+                         max_ofdm->sfd_timeout);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "fina_timeout:",
+                         le32_to_cpu(ofdm->fina_timeout),
+                         accum_ofdm->fina_timeout, delta_ofdm->fina_timeout,
+                         max_ofdm->fina_timeout);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "unresponded_rts:",
+                         le32_to_cpu(ofdm->unresponded_rts),
+                         accum_ofdm->unresponded_rts,
+                         delta_ofdm->unresponded_rts,
+                         max_ofdm->unresponded_rts);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "rxe_frame_lmt_ovrun:",
+                         le32_to_cpu(ofdm->rxe_frame_limit_overrun),
+                         accum_ofdm->rxe_frame_limit_overrun,
+                         delta_ofdm->rxe_frame_limit_overrun,
+                         max_ofdm->rxe_frame_limit_overrun);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "sent_ack_cnt:",
+                         le32_to_cpu(ofdm->sent_ack_cnt),
+                         accum_ofdm->sent_ack_cnt, delta_ofdm->sent_ack_cnt,
+                         max_ofdm->sent_ack_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "sent_cts_cnt:",
+                         le32_to_cpu(ofdm->sent_cts_cnt),
+                         accum_ofdm->sent_cts_cnt, delta_ofdm->sent_cts_cnt,
+                         max_ofdm->sent_cts_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "sent_ba_rsp_cnt:",
+                         le32_to_cpu(ofdm->sent_ba_rsp_cnt),
+                         accum_ofdm->sent_ba_rsp_cnt,
+                         delta_ofdm->sent_ba_rsp_cnt,
+                         max_ofdm->sent_ba_rsp_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "dsp_self_kill:",
+                         le32_to_cpu(ofdm->dsp_self_kill),
+                         accum_ofdm->dsp_self_kill,
+                         delta_ofdm->dsp_self_kill,
+                         max_ofdm->dsp_self_kill);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "mh_format_err:",
+                         le32_to_cpu(ofdm->mh_format_err),
+                         accum_ofdm->mh_format_err,
+                         delta_ofdm->mh_format_err,
+                         max_ofdm->mh_format_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "re_acq_main_rssi_sum:",
+                         le32_to_cpu(ofdm->re_acq_main_rssi_sum),
+                         accum_ofdm->re_acq_main_rssi_sum,
+                         delta_ofdm->re_acq_main_rssi_sum,
+                         max_ofdm->re_acq_main_rssi_sum);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_header, "Statistics_Rx - CCK:");
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "ina_cnt:",
+                         le32_to_cpu(cck->ina_cnt), accum_cck->ina_cnt,
+                         delta_cck->ina_cnt, max_cck->ina_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "fina_cnt:",
+                         le32_to_cpu(cck->fina_cnt), accum_cck->fina_cnt,
+                         delta_cck->fina_cnt, max_cck->fina_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "plcp_err:",
+                         le32_to_cpu(cck->plcp_err), accum_cck->plcp_err,
+                         delta_cck->plcp_err, max_cck->plcp_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "crc32_err:",
+                         le32_to_cpu(cck->crc32_err), accum_cck->crc32_err,
+                         delta_cck->crc32_err, max_cck->crc32_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "overrun_err:",
+                         le32_to_cpu(cck->overrun_err),
+                         accum_cck->overrun_err, delta_cck->overrun_err,
+                         max_cck->overrun_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "early_overrun_err:",
+                         le32_to_cpu(cck->early_overrun_err),
+                         accum_cck->early_overrun_err,
+                         delta_cck->early_overrun_err,
+                         max_cck->early_overrun_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "crc32_good:",
+                         le32_to_cpu(cck->crc32_good), accum_cck->crc32_good,
+                         delta_cck->crc32_good, max_cck->crc32_good);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "false_alarm_cnt:",
+                         le32_to_cpu(cck->false_alarm_cnt),
+                         accum_cck->false_alarm_cnt,
+                         delta_cck->false_alarm_cnt, max_cck->false_alarm_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "fina_sync_err_cnt:",
+                         le32_to_cpu(cck->fina_sync_err_cnt),
+                         accum_cck->fina_sync_err_cnt,
+                         delta_cck->fina_sync_err_cnt,
+                         max_cck->fina_sync_err_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "sfd_timeout:",
+                         le32_to_cpu(cck->sfd_timeout),
+                         accum_cck->sfd_timeout, delta_cck->sfd_timeout,
+                         max_cck->sfd_timeout);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "fina_timeout:",
+                         le32_to_cpu(cck->fina_timeout),
+                         accum_cck->fina_timeout, delta_cck->fina_timeout,
+                         max_cck->fina_timeout);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "unresponded_rts:",
+                         le32_to_cpu(cck->unresponded_rts),
+                         accum_cck->unresponded_rts, delta_cck->unresponded_rts,
+                         max_cck->unresponded_rts);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "rxe_frame_lmt_ovrun:",
+                         le32_to_cpu(cck->rxe_frame_limit_overrun),
+                         accum_cck->rxe_frame_limit_overrun,
+                         delta_cck->rxe_frame_limit_overrun,
+                         max_cck->rxe_frame_limit_overrun);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "sent_ack_cnt:",
+                         le32_to_cpu(cck->sent_ack_cnt),
+                         accum_cck->sent_ack_cnt, delta_cck->sent_ack_cnt,
+                         max_cck->sent_ack_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "sent_cts_cnt:",
+                         le32_to_cpu(cck->sent_cts_cnt),
+                         accum_cck->sent_cts_cnt, delta_cck->sent_cts_cnt,
+                         max_cck->sent_cts_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "sent_ba_rsp_cnt:",
+                         le32_to_cpu(cck->sent_ba_rsp_cnt),
+                         accum_cck->sent_ba_rsp_cnt,
+                         delta_cck->sent_ba_rsp_cnt,
+                         max_cck->sent_ba_rsp_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "dsp_self_kill:",
+                         le32_to_cpu(cck->dsp_self_kill),
+                         accum_cck->dsp_self_kill, delta_cck->dsp_self_kill,
+                         max_cck->dsp_self_kill);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "mh_format_err:",
+                         le32_to_cpu(cck->mh_format_err),
+                         accum_cck->mh_format_err, delta_cck->mh_format_err,
+                         max_cck->mh_format_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "re_acq_main_rssi_sum:",
+                         le32_to_cpu(cck->re_acq_main_rssi_sum),
+                         accum_cck->re_acq_main_rssi_sum,
+                         delta_cck->re_acq_main_rssi_sum,
+                         max_cck->re_acq_main_rssi_sum);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_header, "Statistics_Rx - GENERAL:");
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "bogus_cts:",
+                         le32_to_cpu(general->bogus_cts),
+                         accum_general->bogus_cts, delta_general->bogus_cts,
+                         max_general->bogus_cts);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "bogus_ack:",
+                         le32_to_cpu(general->bogus_ack),
+                         accum_general->bogus_ack, delta_general->bogus_ack,
+                         max_general->bogus_ack);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "non_bssid_frames:",
+                         le32_to_cpu(general->non_bssid_frames),
+                         accum_general->non_bssid_frames,
+                         delta_general->non_bssid_frames,
+                         max_general->non_bssid_frames);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "filtered_frames:",
+                         le32_to_cpu(general->filtered_frames),
+                         accum_general->filtered_frames,
+                         delta_general->filtered_frames,
+                         max_general->filtered_frames);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "non_channel_beacons:",
+                         le32_to_cpu(general->non_channel_beacons),
+                         accum_general->non_channel_beacons,
+                         delta_general->non_channel_beacons,
+                         max_general->non_channel_beacons);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "channel_beacons:",
+                         le32_to_cpu(general->channel_beacons),
+                         accum_general->channel_beacons,
+                         delta_general->channel_beacons,
+                         max_general->channel_beacons);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "num_missed_bcon:",
+                         le32_to_cpu(general->num_missed_bcon),
+                         accum_general->num_missed_bcon,
+                         delta_general->num_missed_bcon,
+                         max_general->num_missed_bcon);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "adc_rx_saturation_time:",
+                         le32_to_cpu(general->adc_rx_saturation_time),
+                         accum_general->adc_rx_saturation_time,
+                         delta_general->adc_rx_saturation_time,
+                         max_general->adc_rx_saturation_time);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "ina_detect_search_tm:",
+                         le32_to_cpu(general->ina_detection_search_time),
+                         accum_general->ina_detection_search_time,
+                         delta_general->ina_detection_search_time,
+                         max_general->ina_detection_search_time);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "beacon_silence_rssi_a:",
+                         le32_to_cpu(general->beacon_silence_rssi_a),
+                         accum_general->beacon_silence_rssi_a,
+                         delta_general->beacon_silence_rssi_a,
+                         max_general->beacon_silence_rssi_a);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "beacon_silence_rssi_b:",
+                         le32_to_cpu(general->beacon_silence_rssi_b),
+                         accum_general->beacon_silence_rssi_b,
+                         delta_general->beacon_silence_rssi_b,
+                         max_general->beacon_silence_rssi_b);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "beacon_silence_rssi_c:",
+                         le32_to_cpu(general->beacon_silence_rssi_c),
+                         accum_general->beacon_silence_rssi_c,
+                         delta_general->beacon_silence_rssi_c,
+                         max_general->beacon_silence_rssi_c);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "interference_data_flag:",
+                         le32_to_cpu(general->interference_data_flag),
+                         accum_general->interference_data_flag,
+                         delta_general->interference_data_flag,
+                         max_general->interference_data_flag);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "channel_load:",
+                         le32_to_cpu(general->channel_load),
+                         accum_general->channel_load,
+                         delta_general->channel_load,
+                         max_general->channel_load);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "dsp_false_alarms:",
+                         le32_to_cpu(general->dsp_false_alarms),
+                         accum_general->dsp_false_alarms,
+                         delta_general->dsp_false_alarms,
+                         max_general->dsp_false_alarms);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "beacon_rssi_a:",
+                         le32_to_cpu(general->beacon_rssi_a),
+                         accum_general->beacon_rssi_a,
+                         delta_general->beacon_rssi_a,
+                         max_general->beacon_rssi_a);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "beacon_rssi_b:",
+                         le32_to_cpu(general->beacon_rssi_b),
+                         accum_general->beacon_rssi_b,
+                         delta_general->beacon_rssi_b,
+                         max_general->beacon_rssi_b);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "beacon_rssi_c:",
+                         le32_to_cpu(general->beacon_rssi_c),
+                         accum_general->beacon_rssi_c,
+                         delta_general->beacon_rssi_c,
+                         max_general->beacon_rssi_c);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "beacon_energy_a:",
+                         le32_to_cpu(general->beacon_energy_a),
+                         accum_general->beacon_energy_a,
+                         delta_general->beacon_energy_a,
+                         max_general->beacon_energy_a);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "beacon_energy_b:",
+                         le32_to_cpu(general->beacon_energy_b),
+                         accum_general->beacon_energy_b,
+                         delta_general->beacon_energy_b,
+                         max_general->beacon_energy_b);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "beacon_energy_c:",
+                         le32_to_cpu(general->beacon_energy_c),
+                         accum_general->beacon_energy_c,
+                         delta_general->beacon_energy_c,
+                         max_general->beacon_energy_c);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_header, "Statistics_Rx - OFDM_HT:");
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "plcp_err:",
+                         le32_to_cpu(ht->plcp_err), accum_ht->plcp_err,
+                         delta_ht->plcp_err, max_ht->plcp_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "overrun_err:",
+                         le32_to_cpu(ht->overrun_err), accum_ht->overrun_err,
+                         delta_ht->overrun_err, max_ht->overrun_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "early_overrun_err:",
+                         le32_to_cpu(ht->early_overrun_err),
+                         accum_ht->early_overrun_err,
+                         delta_ht->early_overrun_err,
+                         max_ht->early_overrun_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "crc32_good:",
+                         le32_to_cpu(ht->crc32_good), accum_ht->crc32_good,
+                         delta_ht->crc32_good, max_ht->crc32_good);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "crc32_err:",
+                         le32_to_cpu(ht->crc32_err), accum_ht->crc32_err,
+                         delta_ht->crc32_err, max_ht->crc32_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "mh_format_err:",
+                         le32_to_cpu(ht->mh_format_err),
+                         accum_ht->mh_format_err,
+                         delta_ht->mh_format_err, max_ht->mh_format_err);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg_crc32_good:",
+                         le32_to_cpu(ht->agg_crc32_good),
+                         accum_ht->agg_crc32_good,
+                         delta_ht->agg_crc32_good, max_ht->agg_crc32_good);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg_mpdu_cnt:",
+                         le32_to_cpu(ht->agg_mpdu_cnt),
+                         accum_ht->agg_mpdu_cnt,
+                         delta_ht->agg_mpdu_cnt, max_ht->agg_mpdu_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg_cnt:",
+                         le32_to_cpu(ht->agg_cnt), accum_ht->agg_cnt,
+                         delta_ht->agg_cnt, max_ht->agg_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "unsupport_mcs:",
+                         le32_to_cpu(ht->unsupport_mcs),
+                         accum_ht->unsupport_mcs,
+                         delta_ht->unsupport_mcs, max_ht->unsupport_mcs);
+        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
+        kfree(buf);
+        return ret;
 }
 static ssize_t iwl_dbgfs_ucode_tx_stats_read(struct file *file,
@@ -1053,8 +1502,190 @@ static ssize_t iwl_dbgfs_ucode_tx_stats_read(struct file *file,
                                        size_t count, loff_t *ppos)
 {
        struct iwl_priv *priv = file->private_data;
-        return priv->cfg->ops->lib->debugfs_ops.tx_stats_read(file,
+        int pos = 0;
-                        user_buf, count, ppos);
+        char *buf;
+        int bufsz = (sizeof(struct statistics_tx) * 48) + 250;
+        ssize_t ret;
+        struct statistics_tx *tx, *accum_tx, *delta_tx, *max_tx;
+        if (!iwl_is_alive(priv))
+                return -EAGAIN;
+        buf = kzalloc(bufsz, GFP_KERNEL);
+        if (!buf) {
+                IWL_ERR(priv, "Can not allocate Buffer\n");
+                return -ENOMEM;
+        }
+        /* the statistic information display here is based on
+         * the last statistics notification from uCode
+         * might not reflect the current uCode activity
+         */
+        tx = &priv->statistics.tx;
+        accum_tx = &priv->accum_stats.tx;
+        delta_tx = &priv->delta_stats.tx;
+        max_tx = &priv->max_delta_stats.tx;
+        pos += iwl_statistics_flag(priv, buf, bufsz);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_header, "Statistics_Tx:");
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "preamble:",
+                         le32_to_cpu(tx->preamble_cnt),
+                         accum_tx->preamble_cnt,
+                         delta_tx->preamble_cnt, max_tx->preamble_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "rx_detected_cnt:",
+                         le32_to_cpu(tx->rx_detected_cnt),
+                         accum_tx->rx_detected_cnt,
+                         delta_tx->rx_detected_cnt, max_tx->rx_detected_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "bt_prio_defer_cnt:",
+                         le32_to_cpu(tx->bt_prio_defer_cnt),
+                         accum_tx->bt_prio_defer_cnt,
+                         delta_tx->bt_prio_defer_cnt,
+                         max_tx->bt_prio_defer_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "bt_prio_kill_cnt:",
+                         le32_to_cpu(tx->bt_prio_kill_cnt),
+                         accum_tx->bt_prio_kill_cnt,
+                         delta_tx->bt_prio_kill_cnt,
+                         max_tx->bt_prio_kill_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "few_bytes_cnt:",
+                         le32_to_cpu(tx->few_bytes_cnt),
+                         accum_tx->few_bytes_cnt,
+                         delta_tx->few_bytes_cnt, max_tx->few_bytes_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "cts_timeout:",
+                         le32_to_cpu(tx->cts_timeout), accum_tx->cts_timeout,
+                         delta_tx->cts_timeout, max_tx->cts_timeout);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "ack_timeout:",
+                         le32_to_cpu(tx->ack_timeout),
+                         accum_tx->ack_timeout,
+                         delta_tx->ack_timeout, max_tx->ack_timeout);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "expected_ack_cnt:",
+                         le32_to_cpu(tx->expected_ack_cnt),
+                         accum_tx->expected_ack_cnt,
+                         delta_tx->expected_ack_cnt,
+                         max_tx->expected_ack_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "actual_ack_cnt:",
+                         le32_to_cpu(tx->actual_ack_cnt),
+                         accum_tx->actual_ack_cnt,
+                         delta_tx->actual_ack_cnt,
+                         max_tx->actual_ack_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "dump_msdu_cnt:",
+                         le32_to_cpu(tx->dump_msdu_cnt),
+                         accum_tx->dump_msdu_cnt,
+                         delta_tx->dump_msdu_cnt,
+                         max_tx->dump_msdu_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "abort_nxt_frame_mismatch:",
+                         le32_to_cpu(tx->burst_abort_next_frame_mismatch_cnt),
+                         accum_tx->burst_abort_next_frame_mismatch_cnt,
+                         delta_tx->burst_abort_next_frame_mismatch_cnt,
+                         max_tx->burst_abort_next_frame_mismatch_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "abort_missing_nxt_frame:",
+                         le32_to_cpu(tx->burst_abort_missing_next_frame_cnt),
+                         accum_tx->burst_abort_missing_next_frame_cnt,
+                         delta_tx->burst_abort_missing_next_frame_cnt,
+                         max_tx->burst_abort_missing_next_frame_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "cts_timeout_collision:",
+                         le32_to_cpu(tx->cts_timeout_collision),
+                         accum_tx->cts_timeout_collision,
+                         delta_tx->cts_timeout_collision,
+                         max_tx->cts_timeout_collision);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "ack_ba_timeout_collision:",
+                         le32_to_cpu(tx->ack_or_ba_timeout_collision),
+                         accum_tx->ack_or_ba_timeout_collision,
+                         delta_tx->ack_or_ba_timeout_collision,
+                         max_tx->ack_or_ba_timeout_collision);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg ba_timeout:",
+                         le32_to_cpu(tx->agg.ba_timeout),
+                         accum_tx->agg.ba_timeout,
+                         delta_tx->agg.ba_timeout,
+                         max_tx->agg.ba_timeout);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg ba_resched_frames:",
+                         le32_to_cpu(tx->agg.ba_reschedule_frames),
+                         accum_tx->agg.ba_reschedule_frames,
+                         delta_tx->agg.ba_reschedule_frames,
+                         max_tx->agg.ba_reschedule_frames);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg scd_query_agg_frame:",
+                         le32_to_cpu(tx->agg.scd_query_agg_frame_cnt),
+                         accum_tx->agg.scd_query_agg_frame_cnt,
+                         delta_tx->agg.scd_query_agg_frame_cnt,
+                         max_tx->agg.scd_query_agg_frame_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg scd_query_no_agg:",
+                         le32_to_cpu(tx->agg.scd_query_no_agg),
+                         accum_tx->agg.scd_query_no_agg,
+                         delta_tx->agg.scd_query_no_agg,
+                         max_tx->agg.scd_query_no_agg);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg scd_query_agg:",
+                         le32_to_cpu(tx->agg.scd_query_agg),
+                         accum_tx->agg.scd_query_agg,
+                         delta_tx->agg.scd_query_agg,
+                         max_tx->agg.scd_query_agg);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg scd_query_mismatch:",
+                         le32_to_cpu(tx->agg.scd_query_mismatch),
+                         accum_tx->agg.scd_query_mismatch,
+                         delta_tx->agg.scd_query_mismatch,
+                         max_tx->agg.scd_query_mismatch);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg frame_not_ready:",
+                         le32_to_cpu(tx->agg.frame_not_ready),
+                         accum_tx->agg.frame_not_ready,
+                         delta_tx->agg.frame_not_ready,
+                         max_tx->agg.frame_not_ready);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg underrun:",
+                         le32_to_cpu(tx->agg.underrun),
+                         accum_tx->agg.underrun,
+                         delta_tx->agg.underrun, max_tx->agg.underrun);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg bt_prio_kill:",
+                         le32_to_cpu(tx->agg.bt_prio_kill),
+                         accum_tx->agg.bt_prio_kill,
+                         delta_tx->agg.bt_prio_kill,
+                         max_tx->agg.bt_prio_kill);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "agg rx_ba_rsp_cnt:",
+                         le32_to_cpu(tx->agg.rx_ba_rsp_cnt),
+                         accum_tx->agg.rx_ba_rsp_cnt,
+                         delta_tx->agg.rx_ba_rsp_cnt,
+                         max_tx->agg.rx_ba_rsp_cnt);
+        if (tx->tx_power.ant_a || tx->tx_power.ant_b || tx->tx_power.ant_c) {
+                pos += scnprintf(buf + pos, bufsz - pos,
+                        "tx power: (1/2 dB step)\n");
+                if ((priv->cfg->valid_tx_ant & ANT_A) && tx->tx_power.ant_a)
+                        pos += scnprintf(buf + pos, bufsz - pos,
+                                        fmt_hex, "antenna A:",
+                                        tx->tx_power.ant_a);
+                if ((priv->cfg->valid_tx_ant & ANT_B) && tx->tx_power.ant_b)
+                        pos += scnprintf(buf + pos, bufsz - pos,
+                                        fmt_hex, "antenna B:",
+                                        tx->tx_power.ant_b);
+                if ((priv->cfg->valid_tx_ant & ANT_C) && tx->tx_power.ant_c)
+                        pos += scnprintf(buf + pos, bufsz - pos,
+                                        fmt_hex, "antenna C:",
+                                        tx->tx_power.ant_c);
+        }
+        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
+        kfree(buf);
+        return ret;
 }
 static ssize_t iwl_dbgfs_ucode_general_stats_read(struct file *file,
@@ -1062,8 +1693,347 @@ static ssize_t iwl_dbgfs_ucode_general_stats_read(struct file *file,
                                        size_t count, loff_t *ppos)
 {
        struct iwl_priv *priv = file->private_data;
-        return priv->cfg->ops->lib->debugfs_ops.general_stats_read(file,
+        int pos = 0;
-                        user_buf, count, ppos);
+        char *buf;
+        int bufsz = sizeof(struct statistics_general) * 10 + 300;
+        ssize_t ret;
+        struct statistics_general_common *general, *accum_general;
+        struct statistics_general_common *delta_general, *max_general;
+        struct statistics_dbg *dbg, *accum_dbg, *delta_dbg, *max_dbg;
+        struct statistics_div *div, *accum_div, *delta_div, *max_div;
+        if (!iwl_is_alive(priv))
+                return -EAGAIN;
+        buf = kzalloc(bufsz, GFP_KERNEL);
+        if (!buf) {
+                IWL_ERR(priv, "Can not allocate Buffer\n");
+                return -ENOMEM;
+        }
+        /* the statistic information display here is based on
+         * the last statistics notification from uCode
+         * might not reflect the current uCode activity
+         */
+        general = &priv->statistics.common;
+        dbg = &priv->statistics.common.dbg;
+        div = &priv->statistics.common.div;
+        accum_general = &priv->accum_stats.common;
+        accum_dbg = &priv->accum_stats.common.dbg;
+        accum_div = &priv->accum_stats.common.div;
+        delta_general = &priv->delta_stats.common;
+        max_general = &priv->max_delta_stats.common;
+        delta_dbg = &priv->delta_stats.common.dbg;
+        max_dbg = &priv->max_delta_stats.common.dbg;
+        delta_div = &priv->delta_stats.common.div;
+        max_div = &priv->max_delta_stats.common.div;
+        pos += iwl_statistics_flag(priv, buf, bufsz);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_header, "Statistics_General:");
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_value, "temperature:",
+                         le32_to_cpu(general->temperature));
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_value, "temperature_m:",
+                         le32_to_cpu(general->temperature_m));
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_value, "ttl_timestamp:",
+                         le32_to_cpu(general->ttl_timestamp));
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "burst_check:",
+                         le32_to_cpu(dbg->burst_check),
+                         accum_dbg->burst_check,
+                         delta_dbg->burst_check, max_dbg->burst_check);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "burst_count:",
+                         le32_to_cpu(dbg->burst_count),
+                         accum_dbg->burst_count,
+                         delta_dbg->burst_count, max_dbg->burst_count);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "wait_for_silence_timeout_count:",
+                         le32_to_cpu(dbg->wait_for_silence_timeout_cnt),
+                         accum_dbg->wait_for_silence_timeout_cnt,
+                         delta_dbg->wait_for_silence_timeout_cnt,
+                         max_dbg->wait_for_silence_timeout_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "sleep_time:",
+                         le32_to_cpu(general->sleep_time),
+                         accum_general->sleep_time,
+                         delta_general->sleep_time, max_general->sleep_time);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "slots_out:",
+                         le32_to_cpu(general->slots_out),
+                         accum_general->slots_out,
+                         delta_general->slots_out, max_general->slots_out);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "slots_idle:",
+                         le32_to_cpu(general->slots_idle),
+                         accum_general->slots_idle,
+                         delta_general->slots_idle, max_general->slots_idle);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "tx_on_a:",
+                         le32_to_cpu(div->tx_on_a), accum_div->tx_on_a,
+                         delta_div->tx_on_a, max_div->tx_on_a);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "tx_on_b:",
+                         le32_to_cpu(div->tx_on_b), accum_div->tx_on_b,
+                         delta_div->tx_on_b, max_div->tx_on_b);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "exec_time:",
+                         le32_to_cpu(div->exec_time), accum_div->exec_time,
+                         delta_div->exec_time, max_div->exec_time);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "probe_time:",
+                         le32_to_cpu(div->probe_time), accum_div->probe_time,
+                         delta_div->probe_time, max_div->probe_time);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "rx_enable_counter:",
+                         le32_to_cpu(general->rx_enable_counter),
+                         accum_general->rx_enable_counter,
+                         delta_general->rx_enable_counter,
+                         max_general->rx_enable_counter);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         fmt_table, "num_of_sos_states:",
+                         le32_to_cpu(general->num_of_sos_states),
+                         accum_general->num_of_sos_states,
+                         delta_general->num_of_sos_states,
+                         max_general->num_of_sos_states);
+        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
+        kfree(buf);
+        return ret;
+}
+static ssize_t iwl_dbgfs_ucode_bt_stats_read(struct file *file,
+                                        char __user *user_buf,
+                                        size_t count, loff_t *ppos)
+{
+        struct iwl_priv *priv = (struct iwl_priv *)file->private_data;
+        int pos = 0;
+        char *buf;
+        int bufsz = (sizeof(struct statistics_bt_activity) * 24) + 200;
+        ssize_t ret;
+        struct statistics_bt_activity *bt, *accum_bt;
+        if (!iwl_is_alive(priv))
+                return -EAGAIN;
+        if (!priv->bt_enable_flag)
+                return -EINVAL;
+        /* make request to uCode to retrieve statistics information */
+        mutex_lock(&priv->mutex);
+        ret = iwl_send_statistics_request(priv, CMD_SYNC, false);
+        mutex_unlock(&priv->mutex);
+        if (ret) {
+                IWL_ERR(priv,
+                        "Error sending statistics request: %zd\n", ret);
+                return -EAGAIN;
+        }
+        buf = kzalloc(bufsz, GFP_KERNEL);
+        if (!buf) {
+                IWL_ERR(priv, "Can not allocate Buffer\n");
+                return -ENOMEM;
+        }
+        /*
+         * the statistic information display here is based on
+         * the last statistics notification from uCode
+         * might not reflect the current uCode activity
+         */
+        bt = &priv->statistics.bt_activity;
+        accum_bt = &priv->accum_stats.bt_activity;
+        pos += iwl_statistics_flag(priv, buf, bufsz);
+        pos += scnprintf(buf + pos, bufsz - pos, "Statistics_BT:\n");
+        pos += scnprintf(buf + pos, bufsz - pos,
+                        "\t\t\tcurrent\t\t\taccumulative\n");
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         "hi_priority_tx_req_cnt:\t\t%u\t\t\t%u\n",
+                         le32_to_cpu(bt->hi_priority_tx_req_cnt),
+                         accum_bt->hi_priority_tx_req_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         "hi_priority_tx_denied_cnt:\t%u\t\t\t%u\n",
+                         le32_to_cpu(bt->hi_priority_tx_denied_cnt),
+                         accum_bt->hi_priority_tx_denied_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         "lo_priority_tx_req_cnt:\t\t%u\t\t\t%u\n",
+                         le32_to_cpu(bt->lo_priority_tx_req_cnt),
+                         accum_bt->lo_priority_tx_req_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         "lo_priority_tx_denied_cnt:\t%u\t\t\t%u\n",
+                         le32_to_cpu(bt->lo_priority_tx_denied_cnt),
+                         accum_bt->lo_priority_tx_denied_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         "hi_priority_rx_req_cnt:\t\t%u\t\t\t%u\n",
+                         le32_to_cpu(bt->hi_priority_rx_req_cnt),
+                         accum_bt->hi_priority_rx_req_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         "hi_priority_rx_denied_cnt:\t%u\t\t\t%u\n",
+                         le32_to_cpu(bt->hi_priority_rx_denied_cnt),
+                         accum_bt->hi_priority_rx_denied_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         "lo_priority_rx_req_cnt:\t\t%u\t\t\t%u\n",
+                         le32_to_cpu(bt->lo_priority_rx_req_cnt),
+                         accum_bt->lo_priority_rx_req_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         "lo_priority_rx_denied_cnt:\t%u\t\t\t%u\n",
+                         le32_to_cpu(bt->lo_priority_rx_denied_cnt),
+                         accum_bt->lo_priority_rx_denied_cnt);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         "(rx)num_bt_kills:\t\t%u\t\t\t%u\n",
+                         le32_to_cpu(priv->statistics.num_bt_kills),
+                         priv->statistics.accum_num_bt_kills);
+        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
+        kfree(buf);
+        return ret;
+}
+static ssize_t iwl_dbgfs_reply_tx_error_read(struct file *file,
+                                        char __user *user_buf,
+                                        size_t count, loff_t *ppos)
+{
+        struct iwl_priv *priv = (struct iwl_priv *)file->private_data;
+        int pos = 0;
+        char *buf;
+        int bufsz = (sizeof(struct reply_tx_error_statistics) * 24) +
+                (sizeof(struct reply_agg_tx_error_statistics) * 24) + 200;
+        ssize_t ret;
+        if (!iwl_is_alive(priv))
+                return -EAGAIN;
+        buf = kzalloc(bufsz, GFP_KERNEL);
+        if (!buf) {
+                IWL_ERR(priv, "Can not allocate Buffer\n");
+                return -ENOMEM;
+        }
+        pos += scnprintf(buf + pos, bufsz - pos, "Statistics_TX_Error:\n");
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_POSTPONE_DELAY),
+                         priv->_agn.reply_tx_stats.pp_delay);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_POSTPONE_FEW_BYTES),
+                         priv->_agn.reply_tx_stats.pp_few_bytes);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_POSTPONE_BT_PRIO),
+                         priv->_agn.reply_tx_stats.pp_bt_prio);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_POSTPONE_QUIET_PERIOD),
+                         priv->_agn.reply_tx_stats.pp_quiet_period);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_POSTPONE_CALC_TTAK),
+                         priv->_agn.reply_tx_stats.pp_calc_ttak);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
+                         iwl_get_tx_fail_reason(
+                                TX_STATUS_FAIL_INTERNAL_CROSSED_RETRY),
+                         priv->_agn.reply_tx_stats.int_crossed_retry);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_SHORT_LIMIT),
+                         priv->_agn.reply_tx_stats.short_limit);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_LONG_LIMIT),
+                         priv->_agn.reply_tx_stats.long_limit);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_FIFO_UNDERRUN),
+                         priv->_agn.reply_tx_stats.fifo_underrun);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_DRAIN_FLOW),
+                         priv->_agn.reply_tx_stats.drain_flow);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_RFKILL_FLUSH),
+                         priv->_agn.reply_tx_stats.rfkill_flush);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_LIFE_EXPIRE),
+                         priv->_agn.reply_tx_stats.life_expire);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_DEST_PS),
+                         priv->_agn.reply_tx_stats.dest_ps);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_HOST_ABORTED),
+                         priv->_agn.reply_tx_stats.host_abort);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_BT_RETRY),
+                         priv->_agn.reply_tx_stats.pp_delay);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_STA_INVALID),
+                         priv->_agn.reply_tx_stats.sta_invalid);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_FRAG_DROPPED),
+                         priv->_agn.reply_tx_stats.frag_drop);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_TID_DISABLE),
+                         priv->_agn.reply_tx_stats.tid_disable);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_FIFO_FLUSHED),
+                         priv->_agn.reply_tx_stats.fifo_flush);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
+                         iwl_get_tx_fail_reason(
+                                TX_STATUS_FAIL_INSUFFICIENT_CF_POLL),
+                         priv->_agn.reply_tx_stats.insuff_cf_poll);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_tx_fail_reason(TX_STATUS_FAIL_PASSIVE_NO_RX),
+                         priv->_agn.reply_tx_stats.fail_hw_drop);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
+                         iwl_get_tx_fail_reason(
+                                TX_STATUS_FAIL_NO_BEACON_ON_RADAR),
+                         priv->_agn.reply_tx_stats.sta_color_mismatch);
+        pos += scnprintf(buf + pos, bufsz - pos, "UNKNOWN:\t\t\t%u\n",
+                         priv->_agn.reply_tx_stats.unknown);
+        pos += scnprintf(buf + pos, bufsz - pos,
+                         "\nStatistics_Agg_TX_Error:\n");
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_UNDERRUN_MSK),
+                         priv->_agn.reply_agg_tx_stats.underrun);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_BT_PRIO_MSK),
+                         priv->_agn.reply_agg_tx_stats.bt_prio);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_FEW_BYTES_MSK),
+                         priv->_agn.reply_agg_tx_stats.few_bytes);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_ABORT_MSK),
+                         priv->_agn.reply_agg_tx_stats.abort);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(
+                                AGG_TX_STATE_LAST_SENT_TTL_MSK),
+                         priv->_agn.reply_agg_tx_stats.last_sent_ttl);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(
+                                AGG_TX_STATE_LAST_SENT_TRY_CNT_MSK),
+                         priv->_agn.reply_agg_tx_stats.last_sent_try);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(
+                                AGG_TX_STATE_LAST_SENT_BT_KILL_MSK),
+                         priv->_agn.reply_agg_tx_stats.last_sent_bt_kill);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_SCD_QUERY_MSK),
+                         priv->_agn.reply_agg_tx_stats.scd_query);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(
+                                AGG_TX_STATE_TEST_BAD_CRC32_MSK),
+                         priv->_agn.reply_agg_tx_stats.bad_crc32);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_RESPONSE_MSK),
+                         priv->_agn.reply_agg_tx_stats.response);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_DUMP_TX_MSK),
+                         priv->_agn.reply_agg_tx_stats.dump_tx);
+        pos += scnprintf(buf + pos, bufsz - pos, "%s:\t\t\t%u\n",
+                         iwl_get_agg_tx_fail_reason(AGG_TX_STATE_DELAY_TX_MSK),
+                         priv->_agn.reply_agg_tx_stats.delay_tx);
+        pos += scnprintf(buf + pos, bufsz - pos, "UNKNOWN:\t\t\t%u\n",
+                         priv->_agn.reply_agg_tx_stats.unknown);
+        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
+        kfree(buf);
+        return ret;
 }
 static ssize_t iwl_dbgfs_sensitivity_read(struct file *file,
@@ -1268,8 +2238,7 @@ static ssize_t iwl_dbgfs_csr_write(struct file *file,
        if (sscanf(buf, "%d", &csr) != 1)
                return -EFAULT;
-        if (priv->cfg->ops->lib->dump_csr)
+        iwl_dump_csr(priv);
-                priv->cfg->ops->lib->dump_csr(priv);
        return count;
 }
@@ -1359,13 +2328,11 @@ static ssize_t iwl_dbgfs_fh_reg_read(struct file *file,
        int pos = 0;
        ssize_t ret = -EFAULT;
-        if (priv->cfg->ops->lib->dump_fh) {
+        ret = pos = iwl_dump_fh(priv, &buf, true);
-                ret = pos = priv->cfg->ops->lib->dump_fh(priv, &buf, true);
+        if (buf) {
-                if (buf) {
+                ret = simple_read_from_buffer(user_buf,
-                        ret = simple_read_from_buffer(user_buf,
+                                              count, ppos, buf, pos);
-                                                      count, ppos, buf, pos);
+                kfree(buf);
-                        kfree(buf);
-                }
        }
        return ret;
@@ -1531,16 +2498,6 @@ static ssize_t iwl_dbgfs_txfifo_flush_write(struct file *file,
        return count;
 }
-static ssize_t iwl_dbgfs_ucode_bt_stats_read(struct file *file,
-                                        char __user *user_buf,
-                                        size_t count, loff_t *ppos)
-{
-        struct iwl_priv *priv = (struct iwl_priv *)file->private_data;
-        return priv->cfg->ops->lib->debugfs_ops.bt_stats_read(file,
-                        user_buf, count, ppos);
-}
 static ssize_t iwl_dbgfs_wd_timeout_write(struct file *file,
                                        const char __user *user_buf,
                                        size_t count, loff_t *ppos) {
@@ -1572,12 +2529,10 @@ static ssize_t iwl_dbgfs_bt_traffic_read(struct file *file,
        int pos = 0;
        char buf[200];
        const size_t bufsz = sizeof(buf);
-        ssize_t ret;
        if (!priv->bt_enable_flag) {
                pos += scnprintf(buf + pos, bufsz - pos, "BT coex disabled\n");
-                ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
+                return simple_read_from_buffer(user_buf, count, ppos, buf, pos);
-                return ret;
        }
        pos += scnprintf(buf + pos, bufsz - pos, "BT enable flag: 0x%x\n",
                priv->bt_enable_flag);
@@ -1608,8 +2563,7 @@ static ssize_t iwl_dbgfs_bt_traffic_read(struct file *file,
                break;
        }
-        ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
+        return simple_read_from_buffer(user_buf, count, ppos, buf, pos);
-        return ret;
 }
 static ssize_t iwl_dbgfs_protection_mode_read(struct file *file,
@@ -1658,18 +2612,6 @@ static ssize_t iwl_dbgfs_protection_mode_write(struct file *file,
        return count;
 }
-static ssize_t iwl_dbgfs_reply_tx_error_read(struct file *file,
-                                        char __user *user_buf,
-                                        size_t count, loff_t *ppos)
-{
-        struct iwl_priv *priv = file->private_data;
-        if (priv->cfg->ops->lib->debugfs_ops.reply_tx_error)
-                return priv->cfg->ops->lib->debugfs_ops.reply_tx_error(
-                        file, user_buf, count, ppos);
-        else
-                return -ENODATA;
-}
 DEBUGFS_READ_FILE_OPS(rx_statistics);
 DEBUGFS_READ_FILE_OPS(tx_statistics);
 DEBUGFS_READ_WRITE_FILE_OPS(traffic_log);
@@ -1731,11 +2673,8 @@ int iwl_dbgfs_register(struct iwl_priv *priv, const char *name)
        DEBUGFS_ADD_FILE(status, dir_data, S_IRUSR);
        DEBUGFS_ADD_FILE(interrupt, dir_data, S_IWUSR | S_IRUSR);
        DEBUGFS_ADD_FILE(qos, dir_data, S_IRUSR);
-        if (!priv->cfg->base_params->broken_powersave) {
+        DEBUGFS_ADD_FILE(sleep_level_override, dir_data, S_IWUSR | S_IRUSR);
-                DEBUGFS_ADD_FILE(sleep_level_override, dir_data,
+        DEBUGFS_ADD_FILE(current_sleep_command, dir_data, S_IRUSR);
-                                 S_IWUSR | S_IRUSR);
-                DEBUGFS_ADD_FILE(current_sleep_command, dir_data, S_IRUSR);
-        }
        DEBUGFS_ADD_FILE(thermal_throttling, dir_data, S_IRUSR);
        DEBUGFS_ADD_FILE(disable_ht40, dir_data, S_IWUSR | S_IRUSR);
        DEBUGFS_ADD_FILE(rx_statistics, dir_debug, S_IRUSR);
@@ -1758,29 +2697,20 @@ int iwl_dbgfs_register(struct iwl_priv *priv, const char *name)
                DEBUGFS_ADD_FILE(txfifo_flush, dir_debug, S_IWUSR);
        DEBUGFS_ADD_FILE(protection_mode, dir_debug, S_IWUSR | S_IRUSR);
-        if (priv->cfg->base_params->sensitivity_calib_by_driver)
+        DEBUGFS_ADD_FILE(sensitivity, dir_debug, S_IRUSR);
-                DEBUGFS_ADD_FILE(sensitivity, dir_debug, S_IRUSR);
+        DEBUGFS_ADD_FILE(chain_noise, dir_debug, S_IRUSR);
-        if (priv->cfg->base_params->chain_noise_calib_by_driver)
+        DEBUGFS_ADD_FILE(ucode_tracing, dir_debug, S_IWUSR | S_IRUSR);
-                DEBUGFS_ADD_FILE(chain_noise, dir_debug, S_IRUSR);
+        DEBUGFS_ADD_FILE(ucode_bt_stats, dir_debug, S_IRUSR);
-        if (priv->cfg->base_params->ucode_tracing)
-                DEBUGFS_ADD_FILE(ucode_tracing, dir_debug, S_IWUSR | S_IRUSR);
-        if (iwl_bt_statistics(priv))
-                DEBUGFS_ADD_FILE(ucode_bt_stats, dir_debug, S_IRUSR);
        DEBUGFS_ADD_FILE(reply_tx_error, dir_debug, S_IRUSR);
        DEBUGFS_ADD_FILE(rxon_flags, dir_debug, S_IWUSR);
        DEBUGFS_ADD_FILE(rxon_filter_flags, dir_debug, S_IWUSR);
        DEBUGFS_ADD_FILE(wd_timeout, dir_debug, S_IWUSR);
        if (iwl_advanced_bt_coexist(priv))
                DEBUGFS_ADD_FILE(bt_traffic, dir_debug, S_IRUSR);
-        if (priv->cfg->base_params->sensitivity_calib_by_driver)
+        DEBUGFS_ADD_BOOL(disable_sensitivity, dir_rf,
-                DEBUGFS_ADD_BOOL(disable_sensitivity, dir_rf,
+                         &priv->disable_sens_cal);
-                                 &priv->disable_sens_cal);
+        DEBUGFS_ADD_BOOL(disable_chain_noise, dir_rf,
-        if (priv->cfg->base_params->chain_noise_calib_by_driver)
+                         &priv->disable_chain_noise_cal);
-                DEBUGFS_ADD_BOOL(disable_chain_noise, dir_rf,
-                                 &priv->disable_chain_noise_cal);
-        if (priv->cfg->base_params->tx_power_by_driver)
-                DEBUGFS_ADD_BOOL(disable_tx_power, dir_rf,
-                                &priv->disable_tx_power_cal);
        return 0;
 err:
diff --git a/drivers/net/wireless/iwlwifi/iwl-dev.h b/drivers/net/wireless/iwlwifi/iwl-dev.h
index 68b953f2bdc7..214e4658c495 100644
--- a/drivers/net/wireless/iwlwifi/iwl-dev.h
+++ b/drivers/net/wireless/iwlwifi/iwl-dev.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -26,7 +26,6 @@
 /*
 * Please use this file (iwl-dev.h) for driver implementation definitions.
 * Please use iwl-commands.h for uCode API definitions.
- * Please use iwl-4965-hw.h for hardware-related definitions.
 */
 #ifndef __iwl_dev_h__
@@ -179,53 +178,12 @@ struct iwl_tx_queue {
 #define IWL_NUM_SCAN_RATES         (2)
-struct iwl4965_channel_tgd_info {
-        u8 type;
-        s8 max_power;
-};
-struct iwl4965_channel_tgh_info {
-        s64 last_radar_time;
-};
-#define IWL4965_MAX_RATE (33)
-struct iwl3945_clip_group {
-        /* maximum power level to prevent clipping for each rate, derived by
-         *   us from this band's saturation power in EEPROM */
-        const s8 clip_powers[IWL_MAX_RATES];
-};
-/* current Tx power values to use, one for each rate for each channel.
- * requested power is limited by:
- * -- regulatory EEPROM limits for this channel
- * -- hardware capabilities (clip-powers)
- * -- spectrum management
- * -- user preference (e.g. iwconfig)
- * when requested power is set, base power index must also be set. */
-struct iwl3945_channel_power_info {
-        struct iwl3945_tx_power tpc;    /* actual radio and DSP gain settings */
-        s8 power_table_index;   /* actual (compenst'd) index into gain table */
-        s8 base_power_index;    /* gain index for power at factory temp. */
-        s8 requested_power;     /* power (dBm) requested for this chnl/rate */
-};
-/* current scan Tx power values to use, one for each scan rate for each
- * channel. */
-struct iwl3945_scan_power_info {
-        struct iwl3945_tx_power tpc;    /* actual radio and DSP gain settings */
-        s8 power_table_index;   /* actual (compenst'd) index into gain table */
-        s8 requested_power;     /* scan pwr (dBm) requested for chnl/rate */
-};
 /*
 * One for each channel, holds all channel setup data
 * Some of the fields (e.g. eeprom and flags/max_power_avg) are redundant
 *     with one another!
 */
 struct iwl_channel_info {
-        struct iwl4965_channel_tgd_info tgd;
-        struct iwl4965_channel_tgh_info tgh;
        struct iwl_eeprom_channel eeprom;       /* EEPROM regulatory limit */
        struct iwl_eeprom_channel ht40_eeprom;  /* EEPROM regulatory limit for
                                                 * HT40 channel */
@@ -245,14 +203,6 @@ struct iwl_channel_info {
        s8 ht40_max_power_avg;  /* (dBm) regul. eeprom, normal Tx, any rate */
        u8 ht40_flags;          /* flags copied from EEPROM */
        u8 ht40_extension_channel; /* HT_IE_EXT_CHANNEL_* */
-        /* Radio/DSP gain settings for each "normal" data Tx rate.
-         * These include, in addition to RF and DSP gain, a few fields for
-         *   remembering/modifying gain settings (indexes). */
-        struct iwl3945_channel_power_info power_info[IWL4965_MAX_RATE];
-        /* Radio/DSP gain settings for each scan rate, for directed scans. */
-        struct iwl3945_scan_power_info scan_pwr_info[IWL_NUM_SCAN_RATES];
 };
 #define IWL_TX_FIFO_BK          0       /* shared */
@@ -288,15 +238,6 @@ struct iwl_channel_info {
 #define IEEE80211_HLEN                  (IEEE80211_4ADDR_LEN)
 #define IEEE80211_FRAME_LEN             (IEEE80211_DATA_LEN + IEEE80211_HLEN)
-struct iwl_frame {
-        union {
-                struct ieee80211_hdr frame;
-                struct iwl_tx_beacon_cmd beacon;
-                u8 raw[IEEE80211_FRAME_LEN];
-                u8 cmd[360];
-        } u;
-        struct list_head list;
-};
 #define SEQ_TO_SN(seq) (((seq) & IEEE80211_SCTL_SEQ) >> 4)
 #define SN_TO_SEQ(ssn) (((ssn) << 4) & IEEE80211_SCTL_SEQ)
@@ -309,6 +250,7 @@ enum {
        CMD_SIZE_HUGE = (1 << 0),
        CMD_ASYNC = (1 << 1),
        CMD_WANT_SKB = (1 << 2),
+        CMD_MAPPED = (1 << 3),
 };
 #define DEF_CMD_PAYLOAD_SIZE 320
@@ -416,6 +358,7 @@ struct iwl_ht_agg {
 #define IWL_EMPTYING_HW_QUEUE_ADDBA 2
 #define IWL_EMPTYING_HW_QUEUE_DELBA 3
        u8 state;
+        u8 tx_fifo;
 };
@@ -499,9 +442,6 @@ struct iwl_station_priv_common {
 * When mac80211 creates a station it reserves some space (hw->sta_data_size)
 * in the structure for use by driver. This structure is places in that
 * space.
- *
- * The common struct MUST be first because it is shared between
- * 3945 and agn!
 */
 struct iwl_station_priv {
        struct iwl_station_priv_common common;
@@ -530,6 +470,10 @@ struct fw_desc {
        u32 len;                /* bytes */
 };
+struct fw_img {
+        struct fw_desc code, data;
+};
 /* v1/v2 uCode file layout */
 struct iwl_ucode_header {
        __le32 ver;     /* major/minor/API/serial */
@@ -586,6 +530,22 @@ enum iwl_ucode_tlv_type {
        IWL_UCODE_TLV_INIT_ERRLOG_PTR   = 13,
        IWL_UCODE_TLV_ENHANCE_SENS_TBL  = 14,
        IWL_UCODE_TLV_PHY_CALIBRATION_SIZE = 15,
+        /* 16 and 17 reserved for future use */
+        IWL_UCODE_TLV_FLAGS             = 18,
+};
+/**
+ * enum iwl_ucode_tlv_flag - ucode API flags
+ * @IWL_UCODE_TLV_FLAGS_PAN: This is PAN capable microcode; this previously
+ *      was a separate TLV but moved here to save space.
+ * @IWL_UCODE_TLV_FLAGS_NEWSCAN: new uCode scan behaviour on hidden SSID,
+ *      treats good CRC threshold as a boolean
+ * @IWL_UCODE_TLV_FLAGS_MFP: This uCode image supports MFP (802.11w).
+ */
+enum iwl_ucode_tlv_flag {
+        IWL_UCODE_TLV_FLAGS_PAN         = BIT(0),
+        IWL_UCODE_TLV_FLAGS_NEWSCAN     = BIT(1),
+        IWL_UCODE_TLV_FLAGS_MFP         = BIT(2),
 };
 struct iwl_ucode_tlv {
@@ -619,14 +579,6 @@ struct iwl_tlv_ucode_header {
        u8 data[0];
 };
-struct iwl4965_ibss_seq {
-        u8 mac[ETH_ALEN];
-        u16 seq_num;
-        u16 frag_num;
-        unsigned long packet_time;
-        struct list_head list;
-};
 struct iwl_sensitivity_ranges {
        u16 min_nrg_cck;
        u16 max_nrg_cck;
@@ -700,7 +652,6 @@ struct iwl_hw_params {
        u8  max_beacon_itrvl;   /* in 1024 ms */
        u32 max_inst_size;
        u32 max_data_size;
-        u32 max_bsm_size;
        u32 ct_kill_threshold; /* value in hw-dependent units */
        u32 ct_kill_exit_threshold; /* value in hw-dependent units */
                                    /* for 1000, 6000 series and up */
@@ -722,8 +673,6 @@ struct iwl_hw_params {
 * Naming convention --
 * iwl_         <-- Is part of iwlwifi
 * iwlXXXX_     <-- Hardware specific (implemented in iwl-XXXX.c for XXXX)
- * iwl4965_bg_      <-- Called from work queue context
- * iwl4965_mac_     <-- mac80211 callback
 *
 ****************************************************************************/
 extern void iwl_update_chain_flags(struct iwl_priv *priv);
@@ -772,7 +721,6 @@ struct iwl_dma_ptr {
 /* Sensitivity and chain noise calibration */
 #define INITIALIZATION_VALUE            0xFFFF
-#define IWL4965_CAL_NUM_BEACONS         20
 #define IWL_CAL_NUM_BEACONS             16
 #define MAXIMUM_ALLOWED_PATHLOSS        15
@@ -806,24 +754,19 @@ struct iwl_dma_ptr {
 #define NRG_NUM_PREV_STAT_L     20
 #define NUM_RX_CHAINS           3
-enum iwl4965_false_alarm_state {
+enum iwlagn_false_alarm_state {
        IWL_FA_TOO_MANY = 0,
        IWL_FA_TOO_FEW = 1,
        IWL_FA_GOOD_RANGE = 2,
 };
-enum iwl4965_chain_noise_state {
+enum iwlagn_chain_noise_state {
        IWL_CHAIN_NOISE_ALIVE = 0,  /* must be 0 */
        IWL_CHAIN_NOISE_ACCUMULATE,
        IWL_CHAIN_NOISE_CALIBRATED,
        IWL_CHAIN_NOISE_DONE,
 };
-enum iwl4965_calib_enabled_state {
-        IWL_CALIB_DISABLED = 0,  /* must be 0 */
-        IWL_CALIB_ENABLED = 1,
-};
 /*
 * enum iwl_calib
@@ -847,12 +790,6 @@ struct iwl_calib_result {
        size_t buf_len;
 };
-enum ucode_type {
-        UCODE_NONE = 0,
-        UCODE_INIT,
-        UCODE_RT
-};
 /* Sensitivity calib data */
 struct iwl_sensitivity_data {
        u32 auto_corr_ofdm;
@@ -1131,12 +1068,6 @@ struct iwl_force_reset {
 /* extend beacon time format bit shifting  */
 /*
- * for _3945 devices
- * bits 31:24 - extended
- * bits 23:0  - interval
- */
-#define IWL3945_EXT_BEACON_TIME_POS     24
-/*
 * for _agn devices
 * bits 31:22 - extended
 * bits 21:0  - interval
@@ -1164,10 +1095,12 @@ struct iwl_force_reset {
 struct iwl_notification_wait {
        struct list_head list;
-        void (*fn)(struct iwl_priv *priv, struct iwl_rx_packet *pkt);
+        void (*fn)(struct iwl_priv *priv, struct iwl_rx_packet *pkt,
+                   void *data);
+        void *fn_data;
        u8 cmd;
-        bool triggered;
+        bool triggered, aborted;
 };
 enum iwl_rxon_context_id {
@@ -1228,6 +1161,8 @@ struct iwl_rxon_context {
                bool enabled, is_40mhz;
                u8 extension_chan_offset;
        } ht;
+        bool last_tx_rejected;
 };
 enum iwl_scan_type {
@@ -1244,13 +1179,10 @@ struct iwl_priv {
        struct ieee80211_rate *ieee_rates;
        struct iwl_cfg *cfg;
-        /* temporary frame storage list */
-        struct list_head free_frames;
-        int frames_count;
        enum ieee80211_band band;
-        int alloc_rxb_page;
+        void (*pre_rx_handler)(struct iwl_priv *priv,
+                               struct iwl_rx_mem_buffer *rxb);
        void (*rx_handlers[REPLY_MAX])(struct iwl_priv *priv,
                                       struct iwl_rx_mem_buffer *rxb);
@@ -1305,16 +1237,12 @@ struct iwl_priv {
        spinlock_t hcmd_lock;   /* protect hcmd */
        spinlock_t reg_lock;    /* protect hw register access */
        struct mutex mutex;
-        struct mutex sync_cmd_mutex; /* enable serialization of sync commands */
        /* basic pci-network driver stuff */
        struct pci_dev *pci_dev;
        /* pci hardware address support */
        void __iomem *hw_base;
-        u32  hw_rev;
-        u32  hw_wa_rev;
-        u8   rev_id;
        /* microcode/device supports multiple contexts */
        u8 valid_contexts;
@@ -1325,6 +1253,8 @@ struct iwl_priv {
        /* max number of station keys */
        u8 sta_key_max_num;
+        bool new_scan_threshold_behaviour;
        /* EEPROM MAC addresses */
        struct mac_address addresses[2];
@@ -1332,13 +1262,10 @@ struct iwl_priv {
        int fw_index;                   /* firmware we're trying to load */
        u32 ucode_ver;                  /* version of ucode, copy of
                                           iwl_ucode.ver */
-        struct fw_desc ucode_code;      /* runtime inst */
+        struct fw_img ucode_rt;
-        struct fw_desc ucode_data;      /* runtime data original */
+        struct fw_img ucode_init;
-        struct fw_desc ucode_data_backup;       /* runtime data save/restore */
-        struct fw_desc ucode_init;      /* initialization inst */
+        enum iwlagn_ucode_subtype ucode_type;
-        struct fw_desc ucode_init_data; /* initialization data */
-        struct fw_desc ucode_boot;      /* bootstrap inst */
-        enum ucode_type ucode_type;
        u8 ucode_write_complete;        /* the image write is complete */
        char firmware_name[25];
@@ -1346,10 +1273,10 @@ struct iwl_priv {
        struct iwl_switch_rxon switch_rxon;
-        /* 1st responses from initialize and runtime uCode images.
+        struct {
-         * _agn's initialize alive response contains some calibration data. */
+                u32 error_event_table;
-        struct iwl_init_alive_resp card_alive_init;
+                u32 log_event_table;
-        struct iwl_alive_resp card_alive;
+        } device_pointers;
        u16 active_rate;
@@ -1390,15 +1317,12 @@ struct iwl_priv {
        struct iwl_power_mgr power_data;
        struct iwl_tt_mgmt thermal_throttle;
-        /* context information */
-        u8 bssid[ETH_ALEN]; /* used only on 3945 but filled by core */
        /* station table variables */
        /* Note: if lock and sta_lock are needed, lock must be acquired first */
        spinlock_t sta_lock;
        int num_stations;
-        struct iwl_station_entry stations[IWL_STATION_COUNT];
+        struct iwl_station_entry stations[IWLAGN_STATION_COUNT];
        unsigned long ucode_key_table;
        /* queue refcounts */
@@ -1422,101 +1346,81 @@ struct iwl_priv {
        /* Last Rx'd beacon timestamp */
        u64 timestamp;
-        union {
+        struct {
-#if defined(CONFIG_IWL3945) || defined(CONFIG_IWL3945_MODULE)
+                __le32 flag;
-                struct {
+                struct statistics_general_common common;
-                        void *shared_virt;
+                struct statistics_rx_non_phy rx_non_phy;
-                        dma_addr_t shared_phys;
+                struct statistics_rx_phy rx_ofdm;
+                struct statistics_rx_ht_phy rx_ofdm_ht;
-                        struct delayed_work thermal_periodic;
+                struct statistics_rx_phy rx_cck;
-                        struct delayed_work rfkill_poll;
+                struct statistics_tx tx;
-                        struct iwl3945_notif_statistics statistics;
 #ifdef CONFIG_IWLWIFI_DEBUGFS
-                        struct iwl3945_notif_statistics accum_statistics;
+                struct statistics_bt_activity bt_activity;
-                        struct iwl3945_notif_statistics delta_statistics;
+                __le32 num_bt_kills, accum_num_bt_kills;
-                        struct iwl3945_notif_statistics max_delta;
-#endif
-                        u32 sta_supp_rates;
-                        int last_rx_rssi;       /* From Rx packet statistics */
-                        /* Rx'd packet timing information */
-                        u32 last_beacon_time;
-                        u64 last_tsf;
-                        /*
-                         * each calibration channel group in the
-                         * EEPROM has a derived clip setting for
-                         * each rate.
-                         */
-                        const struct iwl3945_clip_group clip_groups[5];
-                } _3945;
 #endif
-#if defined(CONFIG_IWLAGN) || defined(CONFIG_IWLAGN_MODULE)
+        } statistics;
-                struct {
-                        /* INT ICT Table */
-                        __le32 *ict_tbl;
-                        void *ict_tbl_vir;
-                        dma_addr_t ict_tbl_dma;
-                        dma_addr_t aligned_ict_tbl_dma;
-                        int ict_index;
-                        u32 inta;
-                        bool use_ict;
-                        /*
-                         * reporting the number of tids has AGG on. 0 means
-                         * no AGGREGATION
-                         */
-                        u8 agg_tids_count;
-                        struct iwl_rx_phy_res last_phy_res;
-                        bool last_phy_res_valid;
-                        struct completion firmware_loading_complete;
-                        u32 init_evtlog_ptr, init_evtlog_size, init_errlog_ptr;
-                        u32 inst_evtlog_ptr, inst_evtlog_size, inst_errlog_ptr;
-                        /*
-                         * chain noise reset and gain commands are the
-                         * two extra calibration commands follows the standard
-                         * phy calibration commands
-                         */
-                        u8 phy_calib_chain_noise_reset_cmd;
-                        u8 phy_calib_chain_noise_gain_cmd;
-                        struct iwl_notif_statistics statistics;
-                        struct iwl_bt_notif_statistics statistics_bt;
-                        /* counts reply_tx error */
-                        struct reply_tx_error_statistics reply_tx_stats;
-                        struct reply_agg_tx_error_statistics reply_agg_tx_stats;
 #ifdef CONFIG_IWLWIFI_DEBUGFS
-                        struct iwl_notif_statistics accum_statistics;
+        struct {
-                        struct iwl_notif_statistics delta_statistics;
+                struct statistics_general_common common;
-                        struct iwl_notif_statistics max_delta;
+                struct statistics_rx_non_phy rx_non_phy;
-                        struct iwl_bt_notif_statistics accum_statistics_bt;
+                struct statistics_rx_phy rx_ofdm;
-                        struct iwl_bt_notif_statistics delta_statistics_bt;
+                struct statistics_rx_ht_phy rx_ofdm_ht;
-                        struct iwl_bt_notif_statistics max_delta_bt;
+                struct statistics_rx_phy rx_cck;
+                struct statistics_tx tx;
+                struct statistics_bt_activity bt_activity;
+        } accum_stats, delta_stats, max_delta_stats;
 #endif
-                        /* notification wait support */
+        struct {
-                        struct list_head notif_waits;
+                /* INT ICT Table */
-                        spinlock_t notif_wait_lock;
+                __le32 *ict_tbl;
-                        wait_queue_head_t notif_waitq;
+                void *ict_tbl_vir;
+                dma_addr_t ict_tbl_dma;
-                        /* remain-on-channel offload support */
+                dma_addr_t aligned_ict_tbl_dma;
-                        struct ieee80211_channel *hw_roc_channel;
+                int ict_index;
-                        struct delayed_work hw_roc_work;
+                u32 inta;
-                        enum nl80211_channel_type hw_roc_chantype;
+                bool use_ict;
-                        int hw_roc_duration;
+                /*
+                 * reporting the number of tids has AGG on. 0 means
-                        struct sk_buff *offchan_tx_skb;
+                 * no AGGREGATION
-                        int offchan_tx_timeout;
+                 */
-                        struct ieee80211_channel *offchan_tx_chan;
+                u8 agg_tids_count;
-                } _agn;
-#endif
+                struct iwl_rx_phy_res last_phy_res;
-        };
+                bool last_phy_res_valid;
+                struct completion firmware_loading_complete;
+                u32 init_evtlog_ptr, init_evtlog_size, init_errlog_ptr;
+                u32 inst_evtlog_ptr, inst_evtlog_size, inst_errlog_ptr;
+                /*
+                 * chain noise reset and gain commands are the
+                 * two extra calibration commands follows the standard
+                 * phy calibration commands
+                 */
+                u8 phy_calib_chain_noise_reset_cmd;
+                u8 phy_calib_chain_noise_gain_cmd;
+                /* counts reply_tx error */
+                struct reply_tx_error_statistics reply_tx_stats;
+                struct reply_agg_tx_error_statistics reply_agg_tx_stats;
+                /* notification wait support */
+                struct list_head notif_waits;
+                spinlock_t notif_wait_lock;
+                wait_queue_head_t notif_waitq;
+                /* remain-on-channel offload support */
+                struct ieee80211_channel *hw_roc_channel;
+                struct delayed_work hw_roc_work;
+                enum nl80211_channel_type hw_roc_chantype;
+                int hw_roc_duration;
+                bool hw_roc_setup;
+                struct sk_buff *offchan_tx_skb;
+                int offchan_tx_timeout;
+                struct ieee80211_channel *offchan_tx_chan;
+        } _agn;
        /* bt coex */
        u8 bt_enable_flag;
@@ -1559,8 +1463,6 @@ struct iwl_priv {
        struct tasklet_struct irq_tasklet;
-        struct delayed_work init_alive_start;
-        struct delayed_work alive_start;
        struct delayed_work scan_check;
        /* TX Power */
@@ -1589,12 +1491,10 @@ struct iwl_priv {
        struct work_struct txpower_work;
        u32 disable_sens_cal;
        u32 disable_chain_noise_cal;
-        u32 disable_tx_power_cal;
        struct work_struct run_time_calib_work;
        struct timer_list statistics_periodic;
        struct timer_list ucode_trace;
        struct timer_list watchdog;
-        bool hw_ready;
        struct iwl_event_log event_log;
@@ -1658,21 +1558,24 @@ iwl_rxon_ctx_from_vif(struct ieee80211_vif *vif)
             ctx < &priv->contexts[NUM_IWL_RXON_CTX]; ctx++)    \
                if (priv->valid_contexts & BIT(ctx->ctxid))
-static inline int iwl_is_associated(struct iwl_priv *priv,
+static inline int iwl_is_associated_ctx(struct iwl_rxon_context *ctx)
-                                    enum iwl_rxon_context_id ctxid)
 {
-        return (priv->contexts[ctxid].active.filter_flags &
+        return (ctx->active.filter_flags & RXON_FILTER_ASSOC_MSK) ? 1 : 0;
-                        RXON_FILTER_ASSOC_MSK) ? 1 : 0;
 }
-static inline int iwl_is_any_associated(struct iwl_priv *priv)
+static inline int iwl_is_associated(struct iwl_priv *priv,
+                                    enum iwl_rxon_context_id ctxid)
 {
-        return iwl_is_associated(priv, IWL_RXON_CTX_BSS);
+        return iwl_is_associated_ctx(&priv->contexts[ctxid]);
 }
-static inline int iwl_is_associated_ctx(struct iwl_rxon_context *ctx)
+static inline int iwl_is_any_associated(struct iwl_priv *priv)
 {
-        return (ctx->active.filter_flags & RXON_FILTER_ASSOC_MSK) ? 1 : 0;
+        struct iwl_rxon_context *ctx;
+        for_each_context(priv, ctx)
+                if (iwl_is_associated_ctx(ctx))
+                        return true;
+        return false;
 }
 static inline int is_channel_valid(const struct iwl_channel_info *ch_info)
@@ -1710,12 +1613,10 @@ static inline int is_channel_ibss(const struct iwl_channel_info *ch)
 static inline void __iwl_free_pages(struct iwl_priv *priv, struct page *page)
 {
        __free_pages(page, priv->hw_params.rx_page_order);
-        priv->alloc_rxb_page--;
 }
 static inline void iwl_free_pages(struct iwl_priv *priv, unsigned long page)
 {
        free_pages(page, priv->hw_params.rx_page_order);
-        priv->alloc_rxb_page--;
 }
 #endif                          /* __iwl_dev_h__ */
diff --git a/drivers/net/wireless/iwlwifi/iwl-devtrace.c b/drivers/net/wireless/iwlwifi/iwl-devtrace.c
index 4a487639d932..a635a7e75447 100644
--- a/drivers/net/wireless/iwlwifi/iwl-devtrace.c
+++ b/drivers/net/wireless/iwlwifi/iwl-devtrace.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2009 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2009 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
diff --git a/drivers/net/wireless/iwlwifi/iwl-devtrace.h b/drivers/net/wireless/iwlwifi/iwl-devtrace.h
index 4cf864c664ee..f00172cb8a6d 100644
--- a/drivers/net/wireless/iwlwifi/iwl-devtrace.h
+++ b/drivers/net/wireless/iwlwifi/iwl-devtrace.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2009 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2009 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
diff --git a/drivers/net/wireless/iwlwifi/iwl-eeprom.c b/drivers/net/wireless/iwlwifi/iwl-eeprom.c
index 833194a2c639..c8397962632c 100644
--- a/drivers/net/wireless/iwlwifi/iwl-eeprom.c
+++ b/drivers/net/wireless/iwlwifi/iwl-eeprom.c
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -142,6 +142,45 @@ static const u8 iwl_eeprom_band_7[] = {       /* 5.2 ht40 channel */
 *
 ******************************************************************************/
+/*
+ * The device's EEPROM semaphore prevents conflicts between driver and uCode
+ * when accessing the EEPROM; each access is a series of pulses to/from the
+ * EEPROM chip, not a single event, so even reads could conflict if they
+ * weren't arbitrated by the semaphore.
+ */
+static int iwl_eeprom_acquire_semaphore(struct iwl_priv *priv)
+{
+        u16 count;
+        int ret;
+        for (count = 0; count < EEPROM_SEM_RETRY_LIMIT; count++) {
+                /* Request semaphore */
+                iwl_set_bit(priv, CSR_HW_IF_CONFIG_REG,
+                            CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM);
+                /* See if we got it */
+                ret = iwl_poll_bit(priv, CSR_HW_IF_CONFIG_REG,
+                                CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM,
+                                CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM,
+                                EEPROM_SEM_TIMEOUT);
+                if (ret >= 0) {
+                        IWL_DEBUG_EEPROM(priv,
+                                "Acquired semaphore after %d tries.\n",
+                                count+1);
+                        return ret;
+                }
+        }
+        return ret;
+}
+static void iwl_eeprom_release_semaphore(struct iwl_priv *priv)
+{
+        iwl_clear_bit(priv, CSR_HW_IF_CONFIG_REG,
+                CSR_HW_IF_CONFIG_REG_BIT_EEPROM_OWN_SEM);
+}
 static int iwl_eeprom_verify_signature(struct iwl_priv *priv)
 {
        u32 gp = iwl_read32(priv, CSR_EEPROM_GP) & CSR_EEPROM_GP_VALID_MSK;
@@ -188,18 +227,16 @@ static void iwl_set_otp_access(struct iwl_priv *priv, enum iwl_access_mode mode)
                                CSR_OTP_GP_REG_OTP_ACCESS_MODE);
 }
-static int iwlcore_get_nvm_type(struct iwl_priv *priv)
+static int iwlcore_get_nvm_type(struct iwl_priv *priv, u32 hw_rev)
 {
        u32 otpgp;
        int nvm_type;
        /* OTP only valid for CP/PP and after */
-        switch (priv->hw_rev & CSR_HW_REV_TYPE_MSK) {
+        switch (hw_rev & CSR_HW_REV_TYPE_MSK) {
        case CSR_HW_REV_TYPE_NONE:
                IWL_ERR(priv, "Unknown hardware type\n");
                return -ENOENT;
-        case CSR_HW_REV_TYPE_3945:
-        case CSR_HW_REV_TYPE_4965:
        case CSR_HW_REV_TYPE_5300:
        case CSR_HW_REV_TYPE_5350:
        case CSR_HW_REV_TYPE_5100:
@@ -217,26 +254,20 @@ static int iwlcore_get_nvm_type(struct iwl_priv *priv)
        return  nvm_type;
 }
-const u8 *iwlcore_eeprom_query_addr(const struct iwl_priv *priv, size_t offset)
-{
-        BUG_ON(offset >= priv->cfg->base_params->eeprom_size);
-        return &priv->eeprom[offset];
-}
 static int iwl_init_otp_access(struct iwl_priv *priv)
 {
        int ret;
        /* Enable 40MHz radio clock */
-        _iwl_write32(priv, CSR_GP_CNTRL,
+        iwl_write32(priv, CSR_GP_CNTRL,
-                     _iwl_read32(priv, CSR_GP_CNTRL) |
+                    iwl_read32(priv, CSR_GP_CNTRL) |
-                     CSR_GP_CNTRL_REG_FLAG_INIT_DONE);
+                    CSR_GP_CNTRL_REG_FLAG_INIT_DONE);
        /* wait for clock to be ready */
        ret = iwl_poll_bit(priv, CSR_GP_CNTRL,
-                                  CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY,
+                                 CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY,
-                                  CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY,
+                                 CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY,
-                                  25000);
+                                 25000);
        if (ret < 0)
                IWL_ERR(priv, "Time out access OTP\n");
        else {
@@ -263,17 +294,17 @@ static int iwl_read_otp_word(struct iwl_priv *priv, u16 addr, __le16 *eeprom_dat
        u32 r;
        u32 otpgp;
-        _iwl_write32(priv, CSR_EEPROM_REG,
+        iwl_write32(priv, CSR_EEPROM_REG,
-                     CSR_EEPROM_REG_MSK_ADDR & (addr << 1));
+                    CSR_EEPROM_REG_MSK_ADDR & (addr << 1));
        ret = iwl_poll_bit(priv, CSR_EEPROM_REG,
-                                  CSR_EEPROM_REG_READ_VALID_MSK,
+                                 CSR_EEPROM_REG_READ_VALID_MSK,
-                                  CSR_EEPROM_REG_READ_VALID_MSK,
+                                 CSR_EEPROM_REG_READ_VALID_MSK,
-                                  IWL_EEPROM_ACCESS_TIMEOUT);
+                                 IWL_EEPROM_ACCESS_TIMEOUT);
        if (ret < 0) {
                IWL_ERR(priv, "Time out reading OTP[%d]\n", addr);
                return ret;
        }
-        r = _iwl_read_direct32(priv, CSR_EEPROM_REG);
+        r = iwl_read32(priv, CSR_EEPROM_REG);
        /* check for ECC errors: */
        otpgp = iwl_read32(priv, CSR_OTP_GP_REG);
        if (otpgp & CSR_OTP_GP_REG_ECC_UNCORR_STATUS_MSK) {
@@ -396,7 +427,7 @@ u16 iwl_eeprom_query16(const struct iwl_priv *priv, size_t offset)
 *
 * NOTE:  This routine uses the non-debug IO access functions.
 */
-int iwl_eeprom_init(struct iwl_priv *priv)
+int iwl_eeprom_init(struct iwl_priv *priv, u32 hw_rev)
 {
        __le16 *e;
        u32 gp = iwl_read32(priv, CSR_EEPROM_GP);
@@ -406,7 +437,7 @@ int iwl_eeprom_init(struct iwl_priv *priv)
        u16 validblockaddr = 0;
        u16 cache_addr = 0;
-        priv->nvm_device_type = iwlcore_get_nvm_type(priv);
+        priv->nvm_device_type = iwlcore_get_nvm_type(priv, hw_rev);
        if (priv->nvm_device_type == -ENOENT)
                return -ENOENT;
        /* allocate eeprom */
@@ -429,7 +460,7 @@ int iwl_eeprom_init(struct iwl_priv *priv)
        }
        /* Make sure driver (instead of uCode) is allowed to read EEPROM */
-        ret = priv->cfg->ops->lib->eeprom_ops.acquire_semaphore(priv);
+        ret = iwl_eeprom_acquire_semaphore(priv);
        if (ret < 0) {
                IWL_ERR(priv, "Failed to acquire EEPROM semaphore.\n");
                ret = -ENOENT;
@@ -444,9 +475,9 @@ int iwl_eeprom_init(struct iwl_priv *priv)
                        ret = -ENOENT;
                        goto done;
                }
-                _iwl_write32(priv, CSR_EEPROM_GP,
+                iwl_write32(priv, CSR_EEPROM_GP,
-                             iwl_read32(priv, CSR_EEPROM_GP) &
+                            iwl_read32(priv, CSR_EEPROM_GP) &
-                             ~CSR_EEPROM_GP_IF_OWNER_MSK);
+                            ~CSR_EEPROM_GP_IF_OWNER_MSK);
                iwl_set_bit(priv, CSR_OTP_GP_REG,
                             CSR_OTP_GP_REG_ECC_CORR_STATUS_MSK |
@@ -473,8 +504,8 @@ int iwl_eeprom_init(struct iwl_priv *priv)
                for (addr = 0; addr < sz; addr += sizeof(u16)) {
                        u32 r;
-                        _iwl_write32(priv, CSR_EEPROM_REG,
+                        iwl_write32(priv, CSR_EEPROM_REG,
-                                     CSR_EEPROM_REG_MSK_ADDR & (addr << 1));
+                                    CSR_EEPROM_REG_MSK_ADDR & (addr << 1));
                        ret = iwl_poll_bit(priv, CSR_EEPROM_REG,
                                                  CSR_EEPROM_REG_READ_VALID_MSK,
@@ -484,7 +515,7 @@ int iwl_eeprom_init(struct iwl_priv *priv)
                                IWL_ERR(priv, "Time out reading EEPROM[%d]\n", addr);
                                goto done;
                        }
-                        r = _iwl_read_direct32(priv, CSR_EEPROM_REG);
+                        r = iwl_read32(priv, CSR_EEPROM_REG);
                        e[addr / 2] = cpu_to_le16(r >> 16);
                }
        }
@@ -496,7 +527,7 @@ int iwl_eeprom_init(struct iwl_priv *priv)
        ret = 0;
 done:
-        priv->cfg->ops->lib->eeprom_ops.release_semaphore(priv);
+        iwl_eeprom_release_semaphore(priv);
 err:
        if (ret)
@@ -719,13 +750,6 @@ int iwl_init_channel_map(struct iwl_priv *priv)
                                             flags & EEPROM_CHANNEL_RADAR))
                                       ? "" : "not ");
-                        /* Set the tx_power_user_lmt to the highest power
-                         * supported by any channel */
-                        if (eeprom_ch_info[ch].max_power_avg >
-                                                priv->tx_power_user_lmt)
-                                priv->tx_power_user_lmt =
-                                    eeprom_ch_info[ch].max_power_avg;
                        ch_info++;
                }
        }
diff --git a/drivers/net/wireless/iwlwifi/iwl-eeprom.h b/drivers/net/wireless/iwlwifi/iwl-eeprom.h
index 20b66469d68f..c960c6fa009b 100644
--- a/drivers/net/wireless/iwlwifi/iwl-eeprom.h
+++ b/drivers/net/wireless/iwlwifi/iwl-eeprom.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -110,10 +110,6 @@ enum {
 };
 /* SKU Capabilities */
-/* 3945 only */
-#define EEPROM_SKU_CAP_SW_RF_KILL_ENABLE                (1 << 0)
-#define EEPROM_SKU_CAP_HW_RF_KILL_ENABLE                (1 << 1)
 /* 5000 and up */
 #define EEPROM_SKU_CAP_BAND_POS                         (4)
 #define EEPROM_SKU_CAP_BAND_SELECTION                   \
@@ -168,28 +164,6 @@ struct iwl_eeprom_enhanced_txpwr {
        s8 mimo3_max;
 } __packed;
-/* 3945 Specific */
-#define EEPROM_3945_EEPROM_VERSION      (0x2f)
-/* 4965 has two radio transmitters (and 3 radio receivers) */
-#define EEPROM_TX_POWER_TX_CHAINS      (2)
-/* 4965 has room for up to 8 sets of txpower calibration data */
-#define EEPROM_TX_POWER_BANDS          (8)
-/* 4965 factory calibration measures txpower gain settings for
- * each of 3 target output levels */
-#define EEPROM_TX_POWER_MEASUREMENTS   (3)
-/* 4965 Specific */
-/* 4965 driver does not work with txpower calibration version < 5 */
-#define EEPROM_4965_TX_POWER_VERSION    (5)
-#define EEPROM_4965_EEPROM_VERSION      (0x2f)
-#define EEPROM_4965_CALIB_VERSION_OFFSET       (2*0xB6) /* 2 bytes */
-#define EEPROM_4965_CALIB_TXPOWER_OFFSET       (2*0xE8) /* 48  bytes */
-#define EEPROM_4965_BOARD_REVISION             (2*0x4F) /* 2 bytes */
-#define EEPROM_4965_BOARD_PBA                  (2*0x56+1) /* 9 bytes */
 /* 5000 Specific */
 #define EEPROM_5000_TX_POWER_VERSION    (4)
 #define EEPROM_5000_EEPROM_VERSION      (0x11A)
@@ -282,90 +256,6 @@ struct iwl_eeprom_enhanced_txpwr {
 /* 2.4 GHz */
 extern const u8 iwl_eeprom_band_1[14];
-/*
- * factory calibration data for one txpower level, on one channel,
- * measured on one of the 2 tx chains (radio transmitter and associated
- * antenna).  EEPROM contains:
- *
- * 1)  Temperature (degrees Celsius) of device when measurement was made.
- *
- * 2)  Gain table index used to achieve the target measurement power.
- *     This refers to the "well-known" gain tables (see iwl-4965-hw.h).
- *
- * 3)  Actual measured output power, in half-dBm ("34" = 17 dBm).
- *
- * 4)  RF power amplifier detector level measurement (not used).
- */
-struct iwl_eeprom_calib_measure {
-        u8 temperature;         /* Device temperature (Celsius) */
-        u8 gain_idx;            /* Index into gain table */
-        u8 actual_pow;          /* Measured RF output power, half-dBm */
-        s8 pa_det;              /* Power amp detector level (not used) */
-} __packed;
-/*
- * measurement set for one channel.  EEPROM contains:
- *
- * 1)  Channel number measured
- *
- * 2)  Measurements for each of 3 power levels for each of 2 radio transmitters
- *     (a.k.a. "tx chains") (6 measurements altogether)
- */
-struct iwl_eeprom_calib_ch_info {
-        u8 ch_num;
-        struct iwl_eeprom_calib_measure
-                measurements[EEPROM_TX_POWER_TX_CHAINS]
-                        [EEPROM_TX_POWER_MEASUREMENTS];
-} __packed;
-/*
- * txpower subband info.
- *
- * For each frequency subband, EEPROM contains the following:
- *
- * 1)  First and last channels within range of the subband.  "0" values
- *     indicate that this sample set is not being used.
- *
- * 2)  Sample measurement sets for 2 channels close to the range endpoints.
- */
-struct iwl_eeprom_calib_subband_info {
-        u8 ch_from;     /* channel number of lowest channel in subband */
-        u8 ch_to;       /* channel number of highest channel in subband */
-        struct iwl_eeprom_calib_ch_info ch1;
-        struct iwl_eeprom_calib_ch_info ch2;
-} __packed;
-/*
- * txpower calibration info.  EEPROM contains:
- *
- * 1)  Factory-measured saturation power levels (maximum levels at which
- *     tx power amplifier can output a signal without too much distortion).
- *     There is one level for 2.4 GHz band and one for 5 GHz band.  These
- *     values apply to all channels within each of the bands.
- *
- * 2)  Factory-measured power supply voltage level.  This is assumed to be
- *     constant (i.e. same value applies to all channels/bands) while the
- *     factory measurements are being made.
- *
- * 3)  Up to 8 sets of factory-measured txpower calibration values.
- *     These are for different frequency ranges, since txpower gain
- *     characteristics of the analog radio circuitry vary with frequency.
- *
- *     Not all sets need to be filled with data;
- *     struct iwl_eeprom_calib_subband_info contains range of channels
- *     (0 if unused) for each set of data.
- */
-struct iwl_eeprom_calib_info {
-        u8 saturation_power24;  /* half-dBm (e.g. "34" = 17 dBm) */
-        u8 saturation_power52;  /* half-dBm */
-        __le16 voltage;         /* signed */
-        struct iwl_eeprom_calib_subband_info
-                band_info[EEPROM_TX_POWER_BANDS];
-} __packed;
 #define ADDRESS_MSK                 0x0000FFFF
 #define INDIRECT_TYPE_MSK           0x000F0000
 #define INDIRECT_HOST               0x00010000
@@ -398,103 +288,24 @@ struct iwl_eeprom_calib_info {
 #define EEPROM_RF_CFG_TX_ANT_MSK(x) ((x >> 8)  & 0xF) /* bits 8-11  */
 #define EEPROM_RF_CFG_RX_ANT_MSK(x) ((x >> 12) & 0xF) /* bits 12-15 */
-#define EEPROM_3945_RF_CFG_TYPE_MAX  0x0
-#define EEPROM_4965_RF_CFG_TYPE_MAX  0x1
-/* Radio Config for 5000 and up */
-#define EEPROM_RF_CONFIG_TYPE_R3x3      0x0
-#define EEPROM_RF_CONFIG_TYPE_R2x2      0x1
-#define EEPROM_RF_CONFIG_TYPE_R1x2      0x2
 #define EEPROM_RF_CONFIG_TYPE_MAX       0x3
-/*
- * Per-channel regulatory data.
- *
- * Each channel that *might* be supported by iwl has a fixed location
- * in EEPROM containing EEPROM_CHANNEL_* usage flags (LSB) and max regulatory
- * txpower (MSB).
- *
- * Entries immediately below are for 20 MHz channel width.  HT40 (40 MHz)
- * channels (only for 4965, not supported by 3945) appear later in the EEPROM.
- *
- * 2.4 GHz channels 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- */
-#define EEPROM_REGULATORY_SKU_ID            (2*0x60)    /* 4  bytes */
-#define EEPROM_REGULATORY_BAND_1            (2*0x62)    /* 2  bytes */
-#define EEPROM_REGULATORY_BAND_1_CHANNELS   (2*0x63)    /* 28 bytes */
-/*
- * 4.9 GHz channels 183, 184, 185, 187, 188, 189, 192, 196,
- * 5.0 GHz channels 7, 8, 11, 12, 16
- * (4915-5080MHz) (none of these is ever supported)
- */
-#define EEPROM_REGULATORY_BAND_2            (2*0x71)    /* 2  bytes */
-#define EEPROM_REGULATORY_BAND_2_CHANNELS   (2*0x72)    /* 26 bytes */
-/*
- * 5.2 GHz channels 34, 36, 38, 40, 42, 44, 46, 48, 52, 56, 60, 64
- * (5170-5320MHz)
- */
-#define EEPROM_REGULATORY_BAND_3            (2*0x7F)    /* 2  bytes */
-#define EEPROM_REGULATORY_BAND_3_CHANNELS   (2*0x80)    /* 24 bytes */
-/*
- * 5.5 GHz channels 100, 104, 108, 112, 116, 120, 124, 128, 132, 136, 140
- * (5500-5700MHz)
- */
-#define EEPROM_REGULATORY_BAND_4            (2*0x8C)    /* 2  bytes */
-#define EEPROM_REGULATORY_BAND_4_CHANNELS   (2*0x8D)    /* 22 bytes */
-/*
- * 5.7 GHz channels 145, 149, 153, 157, 161, 165
- * (5725-5825MHz)
- */
-#define EEPROM_REGULATORY_BAND_5            (2*0x98)    /* 2  bytes */
-#define EEPROM_REGULATORY_BAND_5_CHANNELS   (2*0x99)    /* 12 bytes */
-/*
- * 2.4 GHz HT40 channels 1 (5), 2 (6), 3 (7), 4 (8), 5 (9), 6 (10), 7 (11)
- *
- * The channel listed is the center of the lower 20 MHz half of the channel.
- * The overall center frequency is actually 2 channels (10 MHz) above that,
- * and the upper half of each HT40 channel is centered 4 channels (20 MHz) away
- * from the lower half; e.g. the upper half of HT40 channel 1 is channel 5,
- * and the overall HT40 channel width centers on channel 3.
- *
- * NOTE:  The RXON command uses 20 MHz channel numbers to specify the
- *        control channel to which to tune.  RXON also specifies whether the
- *        control channel is the upper or lower half of a HT40 channel.
- *
- * NOTE:  4965 does not support HT40 channels on 2.4 GHz.
- */
-#define EEPROM_4965_REGULATORY_BAND_24_HT40_CHANNELS (2*0xA0)   /* 14 bytes */
-/*
- * 5.2 GHz HT40 channels 36 (40), 44 (48), 52 (56), 60 (64),
- * 100 (104), 108 (112), 116 (120), 124 (128), 132 (136), 149 (153), 157 (161)
- */
-#define EEPROM_4965_REGULATORY_BAND_52_HT40_CHANNELS (2*0xA8)   /* 22 bytes */
 #define EEPROM_REGULATORY_BAND_NO_HT40                  (0)
 struct iwl_eeprom_ops {
        const u32 regulatory_bands[7];
-        int (*acquire_semaphore) (struct iwl_priv *priv);
-        void (*release_semaphore) (struct iwl_priv *priv);
-        u16 (*calib_version) (struct iwl_priv *priv);
        const u8* (*query_addr) (const struct iwl_priv *priv, size_t offset);
        void (*update_enhanced_txpower) (struct iwl_priv *priv);
 };
-int iwl_eeprom_init(struct iwl_priv *priv);
+int iwl_eeprom_init(struct iwl_priv *priv, u32 hw_rev);
 void iwl_eeprom_free(struct iwl_priv *priv);
 int  iwl_eeprom_check_version(struct iwl_priv *priv);
 int  iwl_eeprom_check_sku(struct iwl_priv *priv);
 const u8 *iwl_eeprom_query_addr(const struct iwl_priv *priv, size_t offset);
 int iwlcore_eeprom_verify_signature(struct iwl_priv *priv);
 u16 iwl_eeprom_query16(const struct iwl_priv *priv, size_t offset);
-const u8 *iwlcore_eeprom_query_addr(const struct iwl_priv *priv, size_t offset);
 int iwl_init_channel_map(struct iwl_priv *priv);
 void iwl_free_channel_map(struct iwl_priv *priv);
 const struct iwl_channel_info *iwl_get_channel_info(
diff --git a/drivers/net/wireless/iwlwifi/iwl-fh.h b/drivers/net/wireless/iwlwifi/iwl-fh.h
index 474009a244d4..6dfa806aefec 100644
--- a/drivers/net/wireless/iwlwifi/iwl-fh.h
+++ b/drivers/net/wireless/iwlwifi/iwl-fh.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -77,14 +77,14 @@
 /**
 * Keep-Warm (KW) buffer base address.
 *
- * Driver must allocate a 4KByte buffer that is used by 4965 for keeping the
+ * Driver must allocate a 4KByte buffer that is for keeping the
 * host DRAM powered on (via dummy accesses to DRAM) to maintain low-latency
- * DRAM access when 4965 is Txing or Rxing.  The dummy accesses prevent host
+ * DRAM access when doing Txing or Rxing.  The dummy accesses prevent host
 * from going into a power-savings mode that would cause higher DRAM latency,
 * and possible data over/under-runs, before all Tx/Rx is complete.
 *
 * Driver loads FH_KW_MEM_ADDR_REG with the physical address (bits 35:4)
- * of the buffer, which must be 4K aligned.  Once this is set up, the 4965
+ * of the buffer, which must be 4K aligned.  Once this is set up, the device
 * automatically invokes keep-warm accesses when normal accesses might not
 * be sufficient to maintain fast DRAM response.
 *
@@ -97,7 +97,7 @@
 /**
 * TFD Circular Buffers Base (CBBC) addresses
 *
- * 4965 has 16 base pointer registers, one for each of 16 host-DRAM-resident
+ * Device has 16 base pointer registers, one for each of 16 host-DRAM-resident
 * circular buffers (CBs/queues) containing Transmit Frame Descriptors (TFDs)
 * (see struct iwl_tfd_frame).  These 16 pointer registers are offset by 0x04
 * bytes from one another.  Each TFD circular buffer in DRAM must be 256-byte
@@ -116,16 +116,16 @@
 /**
 * Rx SRAM Control and Status Registers (RSCSR)
 *
- * These registers provide handshake between driver and 4965 for the Rx queue
+ * These registers provide handshake between driver and device for the Rx queue
 * (this queue handles *all* command responses, notifications, Rx data, etc.
- * sent from 4965 uCode to host driver).  Unlike Tx, there is only one Rx
+ * sent from uCode to host driver).  Unlike Tx, there is only one Rx
 * queue, and only one Rx DMA/FIFO channel.  Also unlike Tx, which can
 * concatenate up to 20 DRAM buffers to form a Tx frame, each Receive Buffer
 * Descriptor (RBD) points to only one Rx Buffer (RB); there is a 1:1
 * mapping between RBDs and RBs.
 *
 * Driver must allocate host DRAM memory for the following, and set the
- * physical address of each into 4965 registers:
+ * physical address of each into device registers:
 *
 * 1)  Receive Buffer Descriptor (RBD) circular buffer (CB), typically with 256
 *     entries (although any power of 2, up to 4096, is selectable by driver).
@@ -140,20 +140,20 @@
 *     Driver sets physical address [35:8] of base of RBD circular buffer
 *     into FH_RSCSR_CHNL0_RBDCB_BASE_REG [27:0].
 *
- * 2)  Rx status buffer, 8 bytes, in which 4965 indicates which Rx Buffers
+ * 2)  Rx status buffer, 8 bytes, in which uCode indicates which Rx Buffers
 *     (RBs) have been filled, via a "write pointer", actually the index of
 *     the RB's corresponding RBD within the circular buffer.  Driver sets
 *     physical address [35:4] into FH_RSCSR_CHNL0_STTS_WPTR_REG [31:0].
 *
 *     Bit fields in lower dword of Rx status buffer (upper dword not used
- *     by driver; see struct iwl4965_shared, val0):
+ *     by driver:
 *     31-12:  Not used by driver
 *     11- 0:  Index of last filled Rx buffer descriptor
- *             (4965 writes, driver reads this value)
+ *             (device writes, driver reads this value)
 *
- * As the driver prepares Receive Buffers (RBs) for 4965 to fill, driver must
+ * As the driver prepares Receive Buffers (RBs) for device to fill, driver must
 * enter pointers to these RBs into contiguous RBD circular buffer entries,
- * and update the 4965's "write" index register,
+ * and update the device's "write" index register,
 * FH_RSCSR_CHNL0_RBDCB_WPTR_REG.
 *
 * This "write" index corresponds to the *next* RBD that the driver will make
@@ -162,12 +162,12 @@
 * RBs), should be 8 after preparing the first 8 RBs (for example), and must
 * wrap back to 0 at the end of the circular buffer (but don't wrap before
 * "read" index has advanced past 1!  See below).
- * NOTE:  4965 EXPECTS THE WRITE INDEX TO BE INCREMENTED IN MULTIPLES OF 8.
+ * NOTE:  DEVICE EXPECTS THE WRITE INDEX TO BE INCREMENTED IN MULTIPLES OF 8.
 *
- * As the 4965 fills RBs (referenced from contiguous RBDs within the circular
+ * As the device fills RBs (referenced from contiguous RBDs within the circular
 * buffer), it updates the Rx status buffer in host DRAM, 2) described above,
 * to tell the driver the index of the latest filled RBD.  The driver must
- * read this "read" index from DRAM after receiving an Rx interrupt from 4965.
+ * read this "read" index from DRAM after receiving an Rx interrupt from device
 *
 * The driver must also internally keep track of a third index, which is the
 * next RBD to process.  When receiving an Rx interrupt, driver should process
@@ -176,7 +176,7 @@
 * driver may process the RB pointed to by RBD 0.  Depending on volume of
 * traffic, there may be many RBs to process.
 *
- * If read index == write index, 4965 thinks there is no room to put new data.
+ * If read index == write index, device thinks there is no room to put new data.
 * Due to this, the maximum number of filled RBs is 255, instead of 256.  To
 * be safe, make sure that there is a gap of at least 2 RBDs between "write"
 * and "read" indexes; that is, make sure that there are no more than 254
@@ -303,7 +303,7 @@
 /**
 * Transmit DMA Channel Control/Status Registers (TCSR)
 *
- * 4965 has one configuration register for each of 8 Tx DMA/FIFO channels
+ * Device has one configuration register for each of 8 Tx DMA/FIFO channels
 * supported in hardware (don't confuse these with the 16 Tx queues in DRAM,
 * which feed the DMA/FIFO channels); config regs are separated by 0x20 bytes.
 *
@@ -326,7 +326,6 @@
 #define FH_TCSR_UPPER_BOUND  (FH_MEM_LOWER_BOUND + 0xE60)
 /* Find Control/Status reg for given Tx DMA/FIFO channel */
-#define FH49_TCSR_CHNL_NUM                            (7)
 #define FH50_TCSR_CHNL_NUM                            (8)
 /* TCSR: tx_config register values */
@@ -424,7 +423,6 @@
 #define RX_LOW_WATERMARK 8
 /* Size of one Rx buffer in host DRAM */
-#define IWL_RX_BUF_SIZE_3K (3 * 1000) /* 3945 only */
 #define IWL_RX_BUF_SIZE_4K (4 * 1024)
 #define IWL_RX_BUF_SIZE_8K (8 * 1024)
@@ -443,7 +441,7 @@ struct iwl_rb_status {
        __le16 closed_fr_num;
        __le16 finished_rb_num;
        __le16 finished_fr_nam;
-        __le32 __unused; /* 3945 only */
+        __le32 __unused;
 } __packed;
diff --git a/drivers/net/wireless/iwlwifi/iwl-hcmd.c b/drivers/net/wireless/iwlwifi/iwl-hcmd.c
index 02499f684683..8f0beb992ccf 100644
--- a/drivers/net/wireless/iwlwifi/iwl-hcmd.c
+++ b/drivers/net/wireless/iwlwifi/iwl-hcmd.c
@@ -2,7 +2,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -51,9 +51,7 @@ const char *get_cmd_string(u8 cmd)
                IWL_CMD(REPLY_REMOVE_ALL_STA);
                IWL_CMD(REPLY_TXFIFO_FLUSH);
                IWL_CMD(REPLY_WEPKEY);
-                IWL_CMD(REPLY_3945_RX);
                IWL_CMD(REPLY_TX);
-                IWL_CMD(REPLY_RATE_SCALE);
                IWL_CMD(REPLY_LEDS_CMD);
                IWL_CMD(REPLY_TX_LINK_QUALITY_CMD);
                IWL_CMD(COEX_PRIORITY_TABLE_CMD);
@@ -145,10 +143,12 @@ static int iwl_send_cmd_async(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
 {
        int ret;
-        BUG_ON(!(cmd->flags & CMD_ASYNC));
+        if (WARN_ON(!(cmd->flags & CMD_ASYNC)))
+                return -EINVAL;
        /* An asynchronous command can not expect an SKB to be set. */
-        BUG_ON(cmd->flags & CMD_WANT_SKB);
+        if (WARN_ON(cmd->flags & CMD_WANT_SKB))
+                return -EINVAL;
        /* Assign a generic callback if one is not provided */
        if (!cmd->callback)
@@ -171,14 +171,15 @@ int iwl_send_cmd_sync(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
        int cmd_idx;
        int ret;
-        BUG_ON(cmd->flags & CMD_ASYNC);
+        if (WARN_ON(cmd->flags & CMD_ASYNC))
+                return -EINVAL;
         /* A synchronous command can not have a callback set. */
-        BUG_ON(cmd->callback);
+        if (WARN_ON(cmd->callback))
+                return -EINVAL;
        IWL_DEBUG_INFO(priv, "Attempting to send sync command %s\n",
                        get_cmd_string(cmd->id));
-        mutex_lock(&priv->sync_cmd_mutex);
        set_bit(STATUS_HCMD_ACTIVE, &priv->status);
        IWL_DEBUG_INFO(priv, "Setting HCMD_ACTIVE for command %s\n",
@@ -189,7 +190,7 @@ int iwl_send_cmd_sync(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
                ret = cmd_idx;
                IWL_ERR(priv, "Error sending %s: enqueue_hcmd failed: %d\n",
                          get_cmd_string(cmd->id), ret);
-                goto out;
+                return ret;
        }
        ret = wait_event_interruptible_timeout(priv->wait_command_queue,
@@ -229,8 +230,7 @@ int iwl_send_cmd_sync(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
                goto cancel;
        }
-        ret = 0;
+        return 0;
-        goto out;
 cancel:
        if (cmd->flags & CMD_WANT_SKB) {
@@ -248,8 +248,7 @@ fail:
                iwl_free_pages(priv, cmd->reply_page);
                cmd->reply_page = 0;
        }
-out:
-        mutex_unlock(&priv->sync_cmd_mutex);
        return ret;
 }
diff --git a/drivers/net/wireless/iwlwifi/iwl-helpers.h b/drivers/net/wireless/iwlwifi/iwl-helpers.h
index 8821f088ba7f..41207a3645b8 100644
--- a/drivers/net/wireless/iwlwifi/iwl-helpers.h
+++ b/drivers/net/wireless/iwlwifi/iwl-helpers.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
@@ -64,30 +64,6 @@ static inline int iwl_queue_dec_wrap(int index, int n_bd)
        return --index & (n_bd - 1);
 }
-/* TODO: Move fw_desc functions to iwl-pci.ko */
-static inline void iwl_free_fw_desc(struct pci_dev *pci_dev,
-                                    struct fw_desc *desc)
-{
-        if (desc->v_addr)
-                dma_free_coherent(&pci_dev->dev, desc->len,
-                                  desc->v_addr, desc->p_addr);
-        desc->v_addr = NULL;
-        desc->len = 0;
-}
-static inline int iwl_alloc_fw_desc(struct pci_dev *pci_dev,
-                                    struct fw_desc *desc)
-{
-        if (!desc->len) {
-                desc->v_addr = NULL;
-                return -EINVAL;
-        }
-        desc->v_addr = dma_alloc_coherent(&pci_dev->dev, desc->len,
-                                          &desc->p_addr, GFP_KERNEL);
-        return (desc->v_addr != NULL) ? 0 : -ENOMEM;
-}
 /*
 * we have 8 bits used like this:
 *
@@ -131,6 +107,19 @@ static inline void iwl_stop_queue(struct iwl_priv *priv,
                        ieee80211_stop_queue(priv->hw, ac);
 }
+static inline void iwl_wake_any_queue(struct iwl_priv *priv,
+                                      struct iwl_rxon_context *ctx)
+{
+        u8 ac;
+        for (ac = 0; ac < AC_NUM; ac++) {
+                IWL_DEBUG_INFO(priv, "Queue Status: Q[%d] %s\n",
+                        ac, (atomic_read(&priv->queue_stop_count[ac]) > 0)
+                              ? "stopped" : "awake");
+                iwl_wake_queue(priv, &priv->txq[ctx->ac_to_queue[ac]]);
+        }
+}
 #define ieee80211_stop_queue DO_NOT_USE_ieee80211_stop_queue
 #define ieee80211_wake_queue DO_NOT_USE_ieee80211_wake_queue
diff --git a/drivers/net/wireless/iwlwifi/iwl-io.c b/drivers/net/wireless/iwlwifi/iwl-io.c
new file mode 100644
index 000000000000..aa4a90674452
--- /dev/null
+++ b/drivers/net/wireless/iwlwifi/iwl-io.c
@@ -0,0 +1,294 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
+ *
+ * Portions of this file are derived from the ipw3945 project.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ *  Intel Linux Wireless <ilw@linux.intel.com>
+ * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
+ *
+ *****************************************************************************/
+#include "iwl-io.h"
+#define IWL_POLL_INTERVAL 10    /* microseconds */
+static inline void __iwl_set_bit(struct iwl_priv *priv, u32 reg, u32 mask)
+{
+        iwl_write32(priv, reg, iwl_read32(priv, reg) | mask);
+}
+static inline void __iwl_clear_bit(struct iwl_priv *priv, u32 reg, u32 mask)
+{
+        iwl_write32(priv, reg, iwl_read32(priv, reg) & ~mask);
+}
+void iwl_set_bit(struct iwl_priv *priv, u32 reg, u32 mask)
+{
+        unsigned long flags;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        __iwl_set_bit(priv, reg, mask);
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+}
+void iwl_clear_bit(struct iwl_priv *priv, u32 reg, u32 mask)
+{
+        unsigned long flags;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        __iwl_clear_bit(priv, reg, mask);
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+}
+int iwl_poll_bit(struct iwl_priv *priv, u32 addr,
+                 u32 bits, u32 mask, int timeout)
+{
+        int t = 0;
+        do {
+                if ((iwl_read32(priv, addr) & mask) == (bits & mask))
+                        return t;
+                udelay(IWL_POLL_INTERVAL);
+                t += IWL_POLL_INTERVAL;
+        } while (t < timeout);
+        return -ETIMEDOUT;
+}
+int iwl_grab_nic_access_silent(struct iwl_priv *priv)
+{
+        int ret;
+        lockdep_assert_held(&priv->reg_lock);
+        /* this bit wakes up the NIC */
+        __iwl_set_bit(priv, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_MAC_ACCESS_REQ);
+        /*
+         * These bits say the device is running, and should keep running for
+         * at least a short while (at least as long as MAC_ACCESS_REQ stays 1),
+         * but they do not indicate that embedded SRAM is restored yet;
+         * 3945 and 4965 have volatile SRAM, and must save/restore contents
+         * to/from host DRAM when sleeping/waking for power-saving.
+         * Each direction takes approximately 1/4 millisecond; with this
+         * overhead, it's a good idea to grab and hold MAC_ACCESS_REQUEST if a
+         * series of register accesses are expected (e.g. reading Event Log),
+         * to keep device from sleeping.
+         *
+         * CSR_UCODE_DRV_GP1 register bit MAC_SLEEP == 0 indicates that
+         * SRAM is okay/restored.  We don't check that here because this call
+         * is just for hardware register access; but GP1 MAC_SLEEP check is a
+         * good idea before accessing 3945/4965 SRAM (e.g. reading Event Log).
+         *
+         * 5000 series and later (including 1000 series) have non-volatile SRAM,
+         * and do not save/restore SRAM when power cycling.
+         */
+        ret = iwl_poll_bit(priv, CSR_GP_CNTRL,
+                           CSR_GP_CNTRL_REG_VAL_MAC_ACCESS_EN,
+                           (CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY |
+                            CSR_GP_CNTRL_REG_FLAG_GOING_TO_SLEEP), 15000);
+        if (ret < 0) {
+                iwl_write32(priv, CSR_RESET, CSR_RESET_REG_FLAG_FORCE_NMI);
+                return -EIO;
+        }
+        return 0;
+}
+int iwl_grab_nic_access(struct iwl_priv *priv)
+{
+        int ret = iwl_grab_nic_access_silent(priv);
+        if (ret) {
+                u32 val = iwl_read32(priv, CSR_GP_CNTRL);
+                IWL_ERR(priv,
+                        "MAC is in deep sleep!. CSR_GP_CNTRL = 0x%08X\n", val);
+        }
+        return ret;
+}
+void iwl_release_nic_access(struct iwl_priv *priv)
+{
+        lockdep_assert_held(&priv->reg_lock);
+        __iwl_clear_bit(priv, CSR_GP_CNTRL,
+                        CSR_GP_CNTRL_REG_FLAG_MAC_ACCESS_REQ);
+}
+u32 iwl_read_direct32(struct iwl_priv *priv, u32 reg)
+{
+        u32 value;
+        unsigned long flags;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        iwl_grab_nic_access(priv);
+        value = iwl_read32(priv, reg);
+        iwl_release_nic_access(priv);
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+        return value;
+}
+void iwl_write_direct32(struct iwl_priv *priv, u32 reg, u32 value)
+{
+        unsigned long flags;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        if (!iwl_grab_nic_access(priv)) {
+                iwl_write32(priv, reg, value);
+                iwl_release_nic_access(priv);
+        }
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+}
+int iwl_poll_direct_bit(struct iwl_priv *priv, u32 addr, u32 mask,
+                        int timeout)
+{
+        int t = 0;
+        do {
+                if ((iwl_read_direct32(priv, addr) & mask) == mask)
+                        return t;
+                udelay(IWL_POLL_INTERVAL);
+                t += IWL_POLL_INTERVAL;
+        } while (t < timeout);
+        return -ETIMEDOUT;
+}
+static inline u32 __iwl_read_prph(struct iwl_priv *priv, u32 reg)
+{
+        iwl_write32(priv, HBUS_TARG_PRPH_RADDR, reg | (3 << 24));
+        rmb();
+        return iwl_read32(priv, HBUS_TARG_PRPH_RDAT);
+}
+static inline void __iwl_write_prph(struct iwl_priv *priv, u32 addr, u32 val)
+{
+        iwl_write32(priv, HBUS_TARG_PRPH_WADDR,
+                    ((addr & 0x0000FFFF) | (3 << 24)));
+        wmb();
+        iwl_write32(priv, HBUS_TARG_PRPH_WDAT, val);
+}
+u32 iwl_read_prph(struct iwl_priv *priv, u32 reg)
+{
+        unsigned long flags;
+        u32 val;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        iwl_grab_nic_access(priv);
+        val = __iwl_read_prph(priv, reg);
+        iwl_release_nic_access(priv);
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+        return val;
+}
+void iwl_write_prph(struct iwl_priv *priv, u32 addr, u32 val)
+{
+        unsigned long flags;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        if (!iwl_grab_nic_access(priv)) {
+                __iwl_write_prph(priv, addr, val);
+                iwl_release_nic_access(priv);
+        }
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+}
+void iwl_set_bits_prph(struct iwl_priv *priv, u32 reg, u32 mask)
+{
+        unsigned long flags;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        iwl_grab_nic_access(priv);
+        __iwl_write_prph(priv, reg, __iwl_read_prph(priv, reg) | mask);
+        iwl_release_nic_access(priv);
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+}
+void iwl_set_bits_mask_prph(struct iwl_priv *priv, u32 reg,
+                            u32 bits, u32 mask)
+{
+        unsigned long flags;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        iwl_grab_nic_access(priv);
+        __iwl_write_prph(priv, reg,
+                         (__iwl_read_prph(priv, reg) & mask) | bits);
+        iwl_release_nic_access(priv);
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+}
+void iwl_clear_bits_prph(struct iwl_priv *priv, u32 reg, u32 mask)
+{
+        unsigned long flags;
+        u32 val;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        iwl_grab_nic_access(priv);
+        val = __iwl_read_prph(priv, reg);
+        __iwl_write_prph(priv, reg, (val & ~mask));
+        iwl_release_nic_access(priv);
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+}
+void _iwl_read_targ_mem_words(struct iwl_priv *priv, u32 addr,
+                              void *buf, int words)
+{
+        unsigned long flags;
+        int offs;
+        u32 *vals = buf;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        iwl_grab_nic_access(priv);
+        iwl_write32(priv, HBUS_TARG_MEM_RADDR, addr);
+        rmb();
+        for (offs = 0; offs < words; offs++)
+                vals[offs] = iwl_read32(priv, HBUS_TARG_MEM_RDAT);
+        iwl_release_nic_access(priv);
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+}
+u32 iwl_read_targ_mem(struct iwl_priv *priv, u32 addr)
+{
+        u32 value;
+        _iwl_read_targ_mem_words(priv, addr, &value, 1);
+        return value;
+}
+void iwl_write_targ_mem(struct iwl_priv *priv, u32 addr, u32 val)
+{
+        unsigned long flags;
+        spin_lock_irqsave(&priv->reg_lock, flags);
+        if (!iwl_grab_nic_access(priv)) {
+                iwl_write32(priv, HBUS_TARG_MEM_WADDR, addr);
+                wmb();
+                iwl_write32(priv, HBUS_TARG_MEM_WDAT, val);
+                iwl_release_nic_access(priv);
+        }
+        spin_unlock_irqrestore(&priv->reg_lock, flags);
+}
diff --git a/drivers/net/wireless/iwlwifi/iwl-io.h b/drivers/net/wireless/iwlwifi/iwl-io.h
index 0203a3bbf872..869edc580ec6 100644
--- a/drivers/net/wireless/iwlwifi/iwl-io.h
+++ b/drivers/net/wireless/iwlwifi/iwl-io.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project.
 *
@@ -35,494 +35,58 @@
 #include "iwl-debug.h"
 #include "iwl-devtrace.h"
-/*
+static inline void iwl_write8(struct iwl_priv *priv, u32 ofs, u8 val)
- * IO, register, and NIC memory access functions
- *
- * NOTE on naming convention and macro usage for these
- *
- * A single _ prefix before a an access function means that no state
- * check or debug information is printed when that function is called.
- *
- * A double __ prefix before an access function means that state is checked
- * and the current line number and caller function name are printed in addition
- * to any other debug output.
- *
- * The non-prefixed name is the #define that maps the caller into a
- * #define that provides the caller's name and __LINE__ to the double
- * prefix version.
- *
- * If you wish to call the function without any debug or state checking,
- * you should use the single _ prefix version (as is used by dependent IO
- * routines, for example _iwl_read_direct32 calls the non-check version of
- * _iwl_read32.)
- *
- * These declarations are *extremely* useful in quickly isolating code deltas
- * which result in misconfiguration of the hardware I/O.  In combination with
- * git-bisect and the IO debug level you can quickly determine the specific
- * commit which breaks the IO sequence to the hardware.
- *
- */
-static inline void _iwl_write8(struct iwl_priv *priv, u32 ofs, u8 val)
 {
        trace_iwlwifi_dev_iowrite8(priv, ofs, val);
        iowrite8(val, priv->hw_base + ofs);
 }
-#ifdef CONFIG_IWLWIFI_DEBUG
+static inline void iwl_write32(struct iwl_priv *priv, u32 ofs, u32 val)
-static inline void __iwl_write8(const char *f, u32 l, struct iwl_priv *priv,
-                                 u32 ofs, u8 val)
-{
-        IWL_DEBUG_IO(priv, "write8(0x%08X, 0x%02X) - %s %d\n", ofs, val, f, l);
-        _iwl_write8(priv, ofs, val);
-}
-#define iwl_write8(priv, ofs, val) \
-        __iwl_write8(__FILE__, __LINE__, priv, ofs, val)
-#else
-#define iwl_write8(priv, ofs, val) _iwl_write8(priv, ofs, val)
-#endif
-static inline void _iwl_write32(struct iwl_priv *priv, u32 ofs, u32 val)
 {
        trace_iwlwifi_dev_iowrite32(priv, ofs, val);
        iowrite32(val, priv->hw_base + ofs);
 }
-#ifdef CONFIG_IWLWIFI_DEBUG
+static inline u32 iwl_read32(struct iwl_priv *priv, u32 ofs)
-static inline void __iwl_write32(const char *f, u32 l, struct iwl_priv *priv,
-                                 u32 ofs, u32 val)
-{
-        IWL_DEBUG_IO(priv, "write32(0x%08X, 0x%08X) - %s %d\n", ofs, val, f, l);
-        _iwl_write32(priv, ofs, val);
-}
-#define iwl_write32(priv, ofs, val) \
-        __iwl_write32(__FILE__, __LINE__, priv, ofs, val)
-#else
-#define iwl_write32(priv, ofs, val) _iwl_write32(priv, ofs, val)
-#endif
-static inline u32 _iwl_read32(struct iwl_priv *priv, u32 ofs)
 {
        u32 val = ioread32(priv->hw_base + ofs);
        trace_iwlwifi_dev_ioread32(priv, ofs, val);
        return val;
 }
-#ifdef CONFIG_IWLWIFI_DEBUG
+void iwl_set_bit(struct iwl_priv *priv, u32 reg, u32 mask);
-static inline u32 __iwl_read32(char *f, u32 l, struct iwl_priv *priv, u32 ofs)
+void iwl_clear_bit(struct iwl_priv *priv, u32 reg, u32 mask);
-{
-        IWL_DEBUG_IO(priv, "read_direct32(0x%08X) - %s %d\n", ofs, f, l);
-        return _iwl_read32(priv, ofs);
-}
-#define iwl_read32(priv, ofs) __iwl_read32(__FILE__, __LINE__, priv, ofs)
-#else
-#define iwl_read32(p, o) _iwl_read32(p, o)
-#endif
-#define IWL_POLL_INTERVAL 10    /* microseconds */
-static inline int _iwl_poll_bit(struct iwl_priv *priv, u32 addr,
-                                u32 bits, u32 mask, int timeout)
-{
-        int t = 0;
-        do {
-                if ((_iwl_read32(priv, addr) & mask) == (bits & mask))
-                        return t;
-                udelay(IWL_POLL_INTERVAL);
-                t += IWL_POLL_INTERVAL;
-        } while (t < timeout);
-        return -ETIMEDOUT;
-}
-#ifdef CONFIG_IWLWIFI_DEBUG
-static inline int __iwl_poll_bit(const char *f, u32 l,
-                                 struct iwl_priv *priv, u32 addr,
-                                 u32 bits, u32 mask, int timeout)
-{
-        int ret = _iwl_poll_bit(priv, addr, bits, mask, timeout);
-        IWL_DEBUG_IO(priv, "poll_bit(0x%08X, 0x%08X, 0x%08X) - %s- %s %d\n",
-                     addr, bits, mask,
-                     unlikely(ret  == -ETIMEDOUT) ? "timeout" : "", f, l);
-        return ret;
-}
-#define iwl_poll_bit(priv, addr, bits, mask, timeout) \
-        __iwl_poll_bit(__FILE__, __LINE__, priv, addr, bits, mask, timeout)
-#else
-#define iwl_poll_bit(p, a, b, m, t) _iwl_poll_bit(p, a, b, m, t)
-#endif
-static inline void _iwl_set_bit(struct iwl_priv *priv, u32 reg, u32 mask)
-{
-        _iwl_write32(priv, reg, _iwl_read32(priv, reg) | mask);
-}
-#ifdef CONFIG_IWLWIFI_DEBUG
-static inline void __iwl_set_bit(const char *f, u32 l,
-                                 struct iwl_priv *priv, u32 reg, u32 mask)
-{
-        u32 val = _iwl_read32(priv, reg) | mask;
-        IWL_DEBUG_IO(priv, "set_bit(0x%08X, 0x%08X) = 0x%08X\n", reg, mask, val);
-        _iwl_write32(priv, reg, val);
-}
-static inline void iwl_set_bit(struct iwl_priv *p, u32 r, u32 m)
-{
-        unsigned long reg_flags;
-        spin_lock_irqsave(&p->reg_lock, reg_flags);
-        __iwl_set_bit(__FILE__, __LINE__, p, r, m);
-        spin_unlock_irqrestore(&p->reg_lock, reg_flags);
-}
-#else
-static inline void iwl_set_bit(struct iwl_priv *p, u32 r, u32 m)
-{
-        unsigned long reg_flags;
-        spin_lock_irqsave(&p->reg_lock, reg_flags);
-        _iwl_set_bit(p, r, m);
-        spin_unlock_irqrestore(&p->reg_lock, reg_flags);
-}
-#endif
-static inline void _iwl_clear_bit(struct iwl_priv *priv, u32 reg, u32 mask)
-{
-        _iwl_write32(priv, reg, _iwl_read32(priv, reg) & ~mask);
-}
-#ifdef CONFIG_IWLWIFI_DEBUG
-static inline void __iwl_clear_bit(const char *f, u32 l,
-                                   struct iwl_priv *priv, u32 reg, u32 mask)
-{
-        u32 val = _iwl_read32(priv, reg) & ~mask;
-        IWL_DEBUG_IO(priv, "clear_bit(0x%08X, 0x%08X) = 0x%08X\n", reg, mask, val);
-        _iwl_write32(priv, reg, val);
-}
-static inline void iwl_clear_bit(struct iwl_priv *p, u32 r, u32 m)
-{
-        unsigned long reg_flags;
-        spin_lock_irqsave(&p->reg_lock, reg_flags);
-        __iwl_clear_bit(__FILE__, __LINE__, p, r, m);
-        spin_unlock_irqrestore(&p->reg_lock, reg_flags);
-}
-#else
-static inline void iwl_clear_bit(struct iwl_priv *p, u32 r, u32 m)
-{
-        unsigned long reg_flags;
-        spin_lock_irqsave(&p->reg_lock, reg_flags);
-        _iwl_clear_bit(p, r, m);
-        spin_unlock_irqrestore(&p->reg_lock, reg_flags);
-}
-#endif
-static inline int _iwl_grab_nic_access(struct iwl_priv *priv)
-{
-        int ret;
-        u32 val;
-        /* this bit wakes up the NIC */
-        _iwl_set_bit(priv, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_MAC_ACCESS_REQ);
-        /*
-         * These bits say the device is running, and should keep running for
-         * at least a short while (at least as long as MAC_ACCESS_REQ stays 1),
-         * but they do not indicate that embedded SRAM is restored yet;
-         * 3945 and 4965 have volatile SRAM, and must save/restore contents
-         * to/from host DRAM when sleeping/waking for power-saving.
-         * Each direction takes approximately 1/4 millisecond; with this
-         * overhead, it's a good idea to grab and hold MAC_ACCESS_REQUEST if a
-         * series of register accesses are expected (e.g. reading Event Log),
-         * to keep device from sleeping.
-         *
-         * CSR_UCODE_DRV_GP1 register bit MAC_SLEEP == 0 indicates that
-         * SRAM is okay/restored.  We don't check that here because this call
-         * is just for hardware register access; but GP1 MAC_SLEEP check is a
-         * good idea before accessing 3945/4965 SRAM (e.g. reading Event Log).
-         *
-         * 5000 series and later (including 1000 series) have non-volatile SRAM,
-         * and do not save/restore SRAM when power cycling.
-         */
-        ret = _iwl_poll_bit(priv, CSR_GP_CNTRL,
-                           CSR_GP_CNTRL_REG_VAL_MAC_ACCESS_EN,
-                           (CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY |
-                            CSR_GP_CNTRL_REG_FLAG_GOING_TO_SLEEP), 15000);
-        if (ret < 0) {
-                val = _iwl_read32(priv, CSR_GP_CNTRL);
-                IWL_ERR(priv, "MAC is in deep sleep!.  CSR_GP_CNTRL = 0x%08X\n", val);
-                _iwl_write32(priv, CSR_RESET, CSR_RESET_REG_FLAG_FORCE_NMI);
-                return -EIO;
-        }
-        return 0;
-}
-#ifdef CONFIG_IWLWIFI_DEBUG
-static inline int __iwl_grab_nic_access(const char *f, u32 l,
-                                               struct iwl_priv *priv)
-{
-        IWL_DEBUG_IO(priv, "grabbing nic access - %s %d\n", f, l);
-        return _iwl_grab_nic_access(priv);
-}
-#define iwl_grab_nic_access(priv) \
-        __iwl_grab_nic_access(__FILE__, __LINE__, priv)
-#else
-#define iwl_grab_nic_access(priv) \
-        _iwl_grab_nic_access(priv)
-#endif
-static inline void _iwl_release_nic_access(struct iwl_priv *priv)
-{
-        _iwl_clear_bit(priv, CSR_GP_CNTRL,
-                        CSR_GP_CNTRL_REG_FLAG_MAC_ACCESS_REQ);
-}
-#ifdef CONFIG_IWLWIFI_DEBUG
-static inline void __iwl_release_nic_access(const char *f, u32 l,
-                                            struct iwl_priv *priv)
-{
-        IWL_DEBUG_IO(priv, "releasing nic access - %s %d\n", f, l);
-        _iwl_release_nic_access(priv);
-}
-#define iwl_release_nic_access(priv) \
-        __iwl_release_nic_access(__FILE__, __LINE__, priv)
-#else
-#define iwl_release_nic_access(priv) \
-        _iwl_release_nic_access(priv)
-#endif
-static inline u32 _iwl_read_direct32(struct iwl_priv *priv, u32 reg)
-{
-        return _iwl_read32(priv, reg);
-}
-#ifdef CONFIG_IWLWIFI_DEBUG
-static inline u32 __iwl_read_direct32(const char *f, u32 l,
-                                        struct iwl_priv *priv, u32 reg)
-{
-        u32 value = _iwl_read_direct32(priv, reg);
-        IWL_DEBUG_IO(priv, "read_direct32(0x%4X) = 0x%08x - %s %d\n", reg, value,
-                     f, l);
-        return value;
-}
-static inline u32 iwl_read_direct32(struct iwl_priv *priv, u32 reg)
-{
-        u32 value;
-        unsigned long reg_flags;
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
-        iwl_grab_nic_access(priv);
-        value = __iwl_read_direct32(__FILE__, __LINE__, priv, reg);
-        iwl_release_nic_access(priv);
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
-        return value;
-}
-#else
-static inline u32 iwl_read_direct32(struct iwl_priv *priv, u32 reg)
-{
-        u32 value;
-        unsigned long reg_flags;
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
-        iwl_grab_nic_access(priv);
-        value = _iwl_read_direct32(priv, reg);
-        iwl_release_nic_access(priv);
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
-        return value;
-}
-#endif
-static inline void _iwl_write_direct32(struct iwl_priv *priv,
-                                         u32 reg, u32 value)
-{
-        _iwl_write32(priv, reg, value);
-}
-static inline void iwl_write_direct32(struct iwl_priv *priv, u32 reg, u32 value)
-{
-        unsigned long reg_flags;
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
-        if (!iwl_grab_nic_access(priv)) {
-                _iwl_write_direct32(priv, reg, value);
-                iwl_release_nic_access(priv);
-        }
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
-}
-static inline void iwl_write_reg_buf(struct iwl_priv *priv,
-                                               u32 reg, u32 len, u32 *values)
-{
-        u32 count = sizeof(u32);
-        if ((priv != NULL) && (values != NULL)) {
-                for (; 0 < len; len -= count, reg += count, values++)
-                        iwl_write_direct32(priv, reg, *values);
-        }
-}
-static inline int _iwl_poll_direct_bit(struct iwl_priv *priv, u32 addr,
-                                       u32 mask, int timeout)
-{
-        int t = 0;
-        do {
-                if ((iwl_read_direct32(priv, addr) & mask) == mask)
-                        return t;
-                udelay(IWL_POLL_INTERVAL);
-                t += IWL_POLL_INTERVAL;
-        } while (t < timeout);
-        return -ETIMEDOUT;
-}
-#ifdef CONFIG_IWLWIFI_DEBUG
-static inline int __iwl_poll_direct_bit(const char *f, u32 l,
-                                            struct iwl_priv *priv,
-                                            u32 addr, u32 mask, int timeout)
-{
-        int ret  = _iwl_poll_direct_bit(priv, addr, mask, timeout);
-        if (unlikely(ret == -ETIMEDOUT))
-                IWL_DEBUG_IO(priv, "poll_direct_bit(0x%08X, 0x%08X) - "
-                             "timedout - %s %d\n", addr, mask, f, l);
-        else
-                IWL_DEBUG_IO(priv, "poll_direct_bit(0x%08X, 0x%08X) = 0x%08X "
-                             "- %s %d\n", addr, mask, ret, f, l);
-        return ret;
-}
-#define iwl_poll_direct_bit(priv, addr, mask, timeout) \
-        __iwl_poll_direct_bit(__FILE__, __LINE__, priv, addr, mask, timeout)
-#else
-#define iwl_poll_direct_bit _iwl_poll_direct_bit
-#endif
-static inline u32 _iwl_read_prph(struct iwl_priv *priv, u32 reg)
-{
-        _iwl_write_direct32(priv, HBUS_TARG_PRPH_RADDR, reg | (3 << 24));
-        rmb();
-        return _iwl_read_direct32(priv, HBUS_TARG_PRPH_RDAT);
-}
-static inline u32 iwl_read_prph(struct iwl_priv *priv, u32 reg)
-{
-        unsigned long reg_flags;
-        u32 val;
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
-        iwl_grab_nic_access(priv);
-        val = _iwl_read_prph(priv, reg);
-        iwl_release_nic_access(priv);
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
-        return val;
-}
-static inline void _iwl_write_prph(struct iwl_priv *priv,
-                                             u32 addr, u32 val)
-{
-        _iwl_write_direct32(priv, HBUS_TARG_PRPH_WADDR,
-                              ((addr & 0x0000FFFF) | (3 << 24)));
-        wmb();
-        _iwl_write_direct32(priv, HBUS_TARG_PRPH_WDAT, val);
-}
-static inline void iwl_write_prph(struct iwl_priv *priv, u32 addr, u32 val)
-{
-        unsigned long reg_flags;
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
-        if (!iwl_grab_nic_access(priv)) {
-                _iwl_write_prph(priv, addr, val);
-                iwl_release_nic_access(priv);
-        }
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
-}
-#define _iwl_set_bits_prph(priv, reg, mask) \
-        _iwl_write_prph(priv, reg, (_iwl_read_prph(priv, reg) | mask))
-static inline void iwl_set_bits_prph(struct iwl_priv *priv, u32 reg, u32 mask)
-{
-        unsigned long reg_flags;
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
-        iwl_grab_nic_access(priv);
-        _iwl_set_bits_prph(priv, reg, mask);
-        iwl_release_nic_access(priv);
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
-}
-#define _iwl_set_bits_mask_prph(priv, reg, bits, mask) \
-        _iwl_write_prph(priv, reg, ((_iwl_read_prph(priv, reg) & mask) | bits))
-static inline void iwl_set_bits_mask_prph(struct iwl_priv *priv, u32 reg,
+int iwl_poll_bit(struct iwl_priv *priv, u32 addr,
-                                u32 bits, u32 mask)
+                 u32 bits, u32 mask, int timeout);
-{
+int iwl_poll_direct_bit(struct iwl_priv *priv, u32 addr, u32 mask,
-        unsigned long reg_flags;
+                        int timeout);
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
+int iwl_grab_nic_access_silent(struct iwl_priv *priv);
-        iwl_grab_nic_access(priv);
+int iwl_grab_nic_access(struct iwl_priv *priv);
-        _iwl_set_bits_mask_prph(priv, reg, bits, mask);
+void iwl_release_nic_access(struct iwl_priv *priv);
-        iwl_release_nic_access(priv);
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
-}
-static inline void iwl_clear_bits_prph(struct iwl_priv
+u32 iwl_read_direct32(struct iwl_priv *priv, u32 reg);
-                                                 *priv, u32 reg, u32 mask)
+void iwl_write_direct32(struct iwl_priv *priv, u32 reg, u32 value);
-{
-        unsigned long reg_flags;
-        u32 val;
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
-        iwl_grab_nic_access(priv);
-        val = _iwl_read_prph(priv, reg);
-        _iwl_write_prph(priv, reg, (val & ~mask));
-        iwl_release_nic_access(priv);
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
-}
-static inline u32 iwl_read_targ_mem(struct iwl_priv *priv, u32 addr)
-{
-        unsigned long reg_flags;
-        u32 value;
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
+u32 iwl_read_prph(struct iwl_priv *priv, u32 reg);
-        iwl_grab_nic_access(priv);
+void iwl_write_prph(struct iwl_priv *priv, u32 addr, u32 val);
+void iwl_set_bits_prph(struct iwl_priv *priv, u32 reg, u32 mask);
+void iwl_set_bits_mask_prph(struct iwl_priv *priv, u32 reg,
+                            u32 bits, u32 mask);
+void iwl_clear_bits_prph(struct iwl_priv *priv, u32 reg, u32 mask);
-        _iwl_write_direct32(priv, HBUS_TARG_MEM_RADDR, addr);
+void _iwl_read_targ_mem_words(struct iwl_priv *priv, u32 addr,
-        rmb();
+                              void *buf, int words);
-        value = _iwl_read_direct32(priv, HBUS_TARG_MEM_RDAT);
-        iwl_release_nic_access(priv);
+#define iwl_read_targ_mem_words(priv, addr, buf, bufsize)       \
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
+        do {                                                    \
-        return value;
+                BUILD_BUG_ON((bufsize) % sizeof(u32));          \
-}
+                _iwl_read_targ_mem_words(priv, addr, buf,       \
+                                         (bufsize) / sizeof(u32));\
+        } while (0)
-static inline void iwl_write_targ_mem(struct iwl_priv *priv, u32 addr, u32 val)
+u32 iwl_read_targ_mem(struct iwl_priv *priv, u32 addr);
-{
+void iwl_write_targ_mem(struct iwl_priv *priv, u32 addr, u32 val);
-        unsigned long reg_flags;
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
-        if (!iwl_grab_nic_access(priv)) {
-                _iwl_write_direct32(priv, HBUS_TARG_MEM_WADDR, addr);
-                wmb();
-                _iwl_write_direct32(priv, HBUS_TARG_MEM_WDAT, val);
-                iwl_release_nic_access(priv);
-        }
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
-}
-static inline void iwl_write_targ_mem_buf(struct iwl_priv *priv, u32 addr,
-                                          u32 len, u32 *values)
-{
-        unsigned long reg_flags;
-        spin_lock_irqsave(&priv->reg_lock, reg_flags);
-        if (!iwl_grab_nic_access(priv)) {
-                _iwl_write_direct32(priv, HBUS_TARG_MEM_WADDR, addr);
-                wmb();
-                for (; 0 < len; len -= sizeof(u32), values++)
-                        _iwl_write_direct32(priv, HBUS_TARG_MEM_WDAT, *values);
-                iwl_release_nic_access(priv);
-        }
-        spin_unlock_irqrestore(&priv->reg_lock, reg_flags);
-}
 #endif
diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c b/drivers/net/wireless/iwlwifi/iwl-led.c
index d7f2a0bb32c9..439187f903c9 100644
--- a/drivers/net/wireless/iwlwifi/iwl-led.c
+++ b/drivers/net/wireless/iwlwifi/iwl-led.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -48,8 +48,21 @@ module_param(led_mode, int, S_IRUGO);
 MODULE_PARM_DESC(led_mode, "0=system default, "
                "1=On(RF On)/Off(RF Off), 2=blinking");
+/* Throughput           OFF time(ms)    ON time (ms)
+ *      >300                    25              25
+ *      >200 to 300             40              40
+ *      >100 to 200             55              55
+ *      >70 to 100              65              65
+ *      >50 to 70               75              75
+ *      >20 to 50               85              85
+ *      >10 to 20               95              95
+ *      >5 to 10                110             110
+ *      >1 to 5                 130             130
+ *      >0 to 1                 167             167
+ *      <=0                                     SOLID ON
+ */
 static const struct ieee80211_tpt_blink iwl_blink[] = {
-        { .throughput = 0 * 1024 - 1, .blink_time = 334 },
+        { .throughput = 0, .blink_time = 334 },
        { .throughput = 1 * 1024 - 1, .blink_time = 260 },
        { .throughput = 5 * 1024 - 1, .blink_time = 220 },
        { .throughput = 10 * 1024 - 1, .blink_time = 190 },
@@ -61,10 +74,16 @@ static const struct ieee80211_tpt_blink iwl_blink[] = {
        { .throughput = 300 * 1024 - 1, .blink_time = 50 },
 };
+/* Set led register off */
+void iwlagn_led_enable(struct iwl_priv *priv)
+{
+        iwl_write32(priv, CSR_LED_REG, CSR_LED_REG_TRUN_ON);
+}
 /*
 * Adjust led blink rate to compensate on a MAC Clock difference on every HW
- * Led blink rate analysis showed an average deviation of 0% on 3945,
+ * Led blink rate analysis showed an average deviation of 20% on 5000 series
- * 5% on 4965 HW and 20% on 5000 series and up.
+ * and up.
 * Need to compensate on the led on/off time per HW according to the deviation
 * to achieve the desired led frequency
 * The calculation is: (100-averageDeviation)/100 * blinkTime
@@ -84,6 +103,24 @@ static inline u8 iwl_blink_compensation(struct iwl_priv *priv,
        return (u8)((time * compensation) >> 6);
 }
+static int iwl_send_led_cmd(struct iwl_priv *priv, struct iwl_led_cmd *led_cmd)
+{
+        struct iwl_host_cmd cmd = {
+                .id = REPLY_LEDS_CMD,
+                .len = sizeof(struct iwl_led_cmd),
+                .data = led_cmd,
+                .flags = CMD_ASYNC,
+                .callback = NULL,
+        };
+        u32 reg;
+        reg = iwl_read32(priv, CSR_LED_REG);
+        if (reg != (reg & CSR_LED_BSM_CTRL_MSK))
+                iwl_write32(priv, CSR_LED_REG, reg & CSR_LED_BSM_CTRL_MSK);
+        return iwl_send_cmd(priv, &cmd);
+}
 /* Set led pattern command */
 static int iwl_led_cmd(struct iwl_priv *priv,
                       unsigned long on,
@@ -101,6 +138,11 @@ static int iwl_led_cmd(struct iwl_priv *priv,
        if (priv->blink_on == on && priv->blink_off == off)
                return 0;
+        if (off == 0) {
+                /* led is SOLID_ON */
+                on = IWL_LED_SOLID;
+        }
        IWL_DEBUG_LED(priv, "Led blink time compensation=%u\n",
                        priv->cfg->base_params->led_compensation);
        led_cmd.on = iwl_blink_compensation(priv, on,
@@ -108,7 +150,7 @@ static int iwl_led_cmd(struct iwl_priv *priv,
        led_cmd.off = iwl_blink_compensation(priv, off,
                                priv->cfg->base_params->led_compensation);
-        ret = priv->cfg->ops->led->cmd(priv, &led_cmd);
+        ret = iwl_send_led_cmd(priv, &led_cmd);
        if (!ret) {
                priv->blink_on = on;
                priv->blink_off = off;
diff --git a/drivers/net/wireless/iwlwifi/iwl-led.h b/drivers/net/wireless/iwlwifi/iwl-led.h
index 101eef12b3bb..1c93dfef6933 100644
--- a/drivers/net/wireless/iwlwifi/iwl-led.h
+++ b/drivers/net/wireless/iwlwifi/iwl-led.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -50,6 +50,7 @@ enum iwl_led_mode {
        IWL_LED_BLINK,
 };
+void iwlagn_led_enable(struct iwl_priv *priv);
 void iwl_leds_init(struct iwl_priv *priv);
 void iwl_leds_exit(struct iwl_priv *priv);
diff --git a/drivers/net/wireless/iwlwifi/iwl-power.c b/drivers/net/wireless/iwlwifi/iwl-power.c
index 576795e2c75b..595c930b28ae 100644
--- a/drivers/net/wireless/iwlwifi/iwl-power.c
+++ b/drivers/net/wireless/iwlwifi/iwl-power.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2007 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2007 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
@@ -188,9 +188,10 @@ static void iwl_static_sleep_cmd(struct iwl_priv *priv,
                        table = range_0;
        }
-        BUG_ON(lvl < 0 || lvl >= IWL_POWER_NUM);
+        if (WARN_ON(lvl < 0 || lvl >= IWL_POWER_NUM))
+                memset(cmd, 0, sizeof(*cmd));
-        *cmd = table[lvl].cmd;
+        else
+                *cmd = table[lvl].cmd;
        if (period == 0) {
                skip = 0;
@@ -354,16 +355,12 @@ static void iwl_power_build_cmd(struct iwl_priv *priv,
        dtimper = priv->hw->conf.ps_dtim_period ?: 1;
-        if (priv->cfg->base_params->broken_powersave)
+        if (priv->hw->conf.flags & IEEE80211_CONF_IDLE)
-                iwl_power_sleep_cam_cmd(priv, cmd);
-        else if (priv->hw->conf.flags & IEEE80211_CONF_IDLE)
                iwl_static_sleep_cmd(priv, cmd, IWL_POWER_INDEX_5, 20);
-        else if (priv->cfg->ops->lib->tt_ops.lower_power_detection &&
+        else if (iwl_tt_is_low_power_state(priv)) {
-                 priv->cfg->ops->lib->tt_ops.tt_power_mode &&
-                 priv->cfg->ops->lib->tt_ops.lower_power_detection(priv)) {
                /* in thermal throttling low power state */
                iwl_static_sleep_cmd(priv, cmd,
-                    priv->cfg->ops->lib->tt_ops.tt_power_mode(priv), dtimper);
+                    iwl_tt_current_power_mode(priv), dtimper);
        } else if (!enabled)
                iwl_power_sleep_cam_cmd(priv, cmd);
        else if (priv->power_data.debug_sleep_level_override >= 0)
diff --git a/drivers/net/wireless/iwlwifi/iwl-power.h b/drivers/net/wireless/iwlwifi/iwl-power.h
index fe012032c28c..59635d784e27 100644
--- a/drivers/net/wireless/iwlwifi/iwl-power.h
+++ b/drivers/net/wireless/iwlwifi/iwl-power.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2007 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2007 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
diff --git a/drivers/net/wireless/iwlwifi/iwl-prph.h b/drivers/net/wireless/iwlwifi/iwl-prph.h
index 86f5123bccda..f00d188b2cfc 100644
--- a/drivers/net/wireless/iwlwifi/iwl-prph.h
+++ b/drivers/net/wireless/iwlwifi/iwl-prph.h
@@ -5,7 +5,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
@@ -30,7 +30,7 @@
 *
 * BSD LICENSE
 *
- * Copyright(c) 2005 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2005 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
@@ -91,7 +91,6 @@
 #define APMG_PS_CTRL_VAL_RESET_REQ              (0x04000000)
 #define APMG_PS_CTRL_MSK_PWR_SRC                (0x03000000)
 #define APMG_PS_CTRL_VAL_PWR_SRC_VMAIN          (0x00000000)
-#define APMG_PS_CTRL_VAL_PWR_SRC_MAX            (0x01000000) /* 3945 only */
 #define APMG_PS_CTRL_VAL_PWR_SRC_VAUX           (0x02000000)
 #define APMG_SVR_VOLTAGE_CONFIG_BIT_MSK (0x000001E0) /* bit 8:5 */
 #define APMG_SVR_DIGITAL_VOLTAGE_1_32           (0x00000060)
@@ -99,152 +98,6 @@
 #define APMG_PCIDEV_STT_VAL_L1_ACT_DIS          (0x00000800)
 /**
- * BSM (Bootstrap State Machine)
- *
- * The Bootstrap State Machine (BSM) stores a short bootstrap uCode program
- * in special SRAM that does not power down when the embedded control
- * processor is sleeping (e.g. for periodic power-saving shutdowns of radio).
- *
- * When powering back up after sleeps (or during initial uCode load), the BSM
- * internally loads the short bootstrap program from the special SRAM into the
- * embedded processor's instruction SRAM, and starts the processor so it runs
- * the bootstrap program.
- *
- * This bootstrap program loads (via PCI busmaster DMA) instructions and data
- * images for a uCode program from host DRAM locations.  The host driver
- * indicates DRAM locations and sizes for instruction and data images via the
- * four BSM_DRAM_* registers.  Once the bootstrap program loads the new program,
- * the new program starts automatically.
- *
- * The uCode used for open-source drivers includes two programs:
- *
- * 1)  Initialization -- performs hardware calibration and sets up some
- *     internal data, then notifies host via "initialize alive" notification
- *     (struct iwl_init_alive_resp) that it has completed all of its work.
- *     After signal from host, it then loads and starts the runtime program.
- *     The initialization program must be used when initially setting up the
- *     NIC after loading the driver.
- *
- * 2)  Runtime/Protocol -- performs all normal runtime operations.  This
- *     notifies host via "alive" notification (struct iwl_alive_resp) that it
- *     is ready to be used.
- *
- * When initializing the NIC, the host driver does the following procedure:
- *
- * 1)  Load bootstrap program (instructions only, no data image for bootstrap)
- *     into bootstrap memory.  Use dword writes starting at BSM_SRAM_LOWER_BOUND
- *
- * 2)  Point (via BSM_DRAM_*) to the "initialize" uCode data and instruction
- *     images in host DRAM.
- *
- * 3)  Set up BSM to copy from BSM SRAM into uCode instruction SRAM when asked:
- *     BSM_WR_MEM_SRC_REG = 0
- *     BSM_WR_MEM_DST_REG = RTC_INST_LOWER_BOUND
- *     BSM_WR_MEM_DWCOUNT_REG = # dwords in bootstrap instruction image
- *
- * 4)  Load bootstrap into instruction SRAM:
- *     BSM_WR_CTRL_REG = BSM_WR_CTRL_REG_BIT_START
- *
- * 5)  Wait for load completion:
- *     Poll BSM_WR_CTRL_REG for BSM_WR_CTRL_REG_BIT_START = 0
- *
- * 6)  Enable future boot loads whenever NIC's power management triggers it:
- *     BSM_WR_CTRL_REG = BSM_WR_CTRL_REG_BIT_START_EN
- *
- * 7)  Start the NIC by removing all reset bits:
- *     CSR_RESET = 0
- *
- *     The bootstrap uCode (already in instruction SRAM) loads initialization
- *     uCode.  Initialization uCode performs data initialization, sends
- *     "initialize alive" notification to host, and waits for a signal from
- *     host to load runtime code.
- *
- * 4)  Point (via BSM_DRAM_*) to the "runtime" uCode data and instruction
- *     images in host DRAM.  The last register loaded must be the instruction
- *     byte count register ("1" in MSbit tells initialization uCode to load
- *     the runtime uCode):
- *     BSM_DRAM_INST_BYTECOUNT_REG = byte count | BSM_DRAM_INST_LOAD
- *
- * 5)  Wait for "alive" notification, then issue normal runtime commands.
- *
- * Data caching during power-downs:
- *
- * Just before the embedded controller powers down (e.g for automatic
- * power-saving modes, or for RFKILL), uCode stores (via PCI busmaster DMA)
- * a current snapshot of the embedded processor's data SRAM into host DRAM.
- * This caches the data while the embedded processor's memory is powered down.
- * Location and size are controlled by BSM_DRAM_DATA_* registers.
- *
- * NOTE:  Instruction SRAM does not need to be saved, since that doesn't
- *        change during operation; the original image (from uCode distribution
- *        file) can be used for reload.
- *
- * When powering back up, the BSM loads the bootstrap program.  Bootstrap looks
- * at the BSM_DRAM_* registers, which now point to the runtime instruction
- * image and the cached (modified) runtime data (*not* the initialization
- * uCode).  Bootstrap reloads these runtime images into SRAM, and restarts the
- * uCode from where it left off before the power-down.
- *
- * NOTE:  Initialization uCode does *not* run as part of the save/restore
- *        procedure.
- *
- * This save/restore method is mostly for autonomous power management during
- * normal operation (result of POWER_TABLE_CMD).  Platform suspend/resume and
- * RFKILL should use complete restarts (with total re-initialization) of uCode,
- * allowing total shutdown (including BSM memory).
- *
- * Note that, during normal operation, the host DRAM that held the initial
- * startup data for the runtime code is now being used as a backup data cache
- * for modified data!  If you need to completely re-initialize the NIC, make
- * sure that you use the runtime data image from the uCode distribution file,
- * not the modified/saved runtime data.  You may want to store a separate
- * "clean" runtime data image in DRAM to avoid disk reads of distribution file.
- */
-/* BSM bit fields */
-#define BSM_WR_CTRL_REG_BIT_START     (0x80000000) /* start boot load now */
-#define BSM_WR_CTRL_REG_BIT_START_EN  (0x40000000) /* enable boot after pwrup*/
-#define BSM_DRAM_INST_LOAD            (0x80000000) /* start program load now */
-/* BSM addresses */
-#define BSM_BASE                     (PRPH_BASE + 0x3400)
-#define BSM_END                      (PRPH_BASE + 0x3800)
-#define BSM_WR_CTRL_REG              (BSM_BASE + 0x000) /* ctl and status */
-#define BSM_WR_MEM_SRC_REG           (BSM_BASE + 0x004) /* source in BSM mem */
-#define BSM_WR_MEM_DST_REG           (BSM_BASE + 0x008) /* dest in SRAM mem */
-#define BSM_WR_DWCOUNT_REG           (BSM_BASE + 0x00C) /* bytes */
-#define BSM_WR_STATUS_REG            (BSM_BASE + 0x010) /* bit 0:  1 == done */
-/*
- * Pointers and size regs for bootstrap load and data SRAM save/restore.
- * NOTE:  3945 pointers use bits 31:0 of DRAM address.
- *        4965 pointers use bits 35:4 of DRAM address.
- */
-#define BSM_DRAM_INST_PTR_REG        (BSM_BASE + 0x090)
-#define BSM_DRAM_INST_BYTECOUNT_REG  (BSM_BASE + 0x094)
-#define BSM_DRAM_DATA_PTR_REG        (BSM_BASE + 0x098)
-#define BSM_DRAM_DATA_BYTECOUNT_REG  (BSM_BASE + 0x09C)
-/*
- * BSM special memory, stays powered on during power-save sleeps.
- * Read/write, address range from LOWER_BOUND to (LOWER_BOUND + SIZE -1)
- */
-#define BSM_SRAM_LOWER_BOUND         (PRPH_BASE + 0x3800)
-#define BSM_SRAM_SIZE                   (1024) /* bytes */
-/* 3945 Tx scheduler registers */
-#define ALM_SCD_BASE                        (PRPH_BASE + 0x2E00)
-#define ALM_SCD_MODE_REG                    (ALM_SCD_BASE + 0x000)
-#define ALM_SCD_ARASTAT_REG                 (ALM_SCD_BASE + 0x004)
-#define ALM_SCD_TXFACT_REG                  (ALM_SCD_BASE + 0x010)
-#define ALM_SCD_TXF4MF_REG                  (ALM_SCD_BASE + 0x014)
-#define ALM_SCD_TXF5MF_REG                  (ALM_SCD_BASE + 0x020)
-#define ALM_SCD_SBYP_MODE_1_REG             (ALM_SCD_BASE + 0x02C)
-#define ALM_SCD_SBYP_MODE_2_REG             (ALM_SCD_BASE + 0x030)
-/**
 * Tx Scheduler
 *
 * The Tx Scheduler selects the next frame to be transmitted, choosing TFDs
@@ -254,17 +107,7 @@
 * device.  A queue maps to only one (selectable by driver) Tx DMA channel,
 * but one DMA channel may take input from several queues.
 *
- * Tx DMA FIFOs have dedicated purposes.  For 4965, they are used as follows
+ * Tx DMA FIFOs have dedicated purposes.
- * (cf. default_queue_to_tx_fifo in iwl-4965.c):
- *
- * 0 -- EDCA BK (background) frames, lowest priority
- * 1 -- EDCA BE (best effort) frames, normal priority
- * 2 -- EDCA VI (video) frames, higher priority
- * 3 -- EDCA VO (voice) and management frames, highest priority
- * 4 -- Commands (e.g. RXON, etc.)
- * 5 -- unused (HCCA)
- * 6 -- unused (HCCA)
- * 7 -- not used by driver (device-internal only)
 *
 * For 5000 series and up, they are used differently
 * (cf. iwl5000_default_queue_to_tx_fifo in iwl-5000.c):
@@ -298,7 +141,7 @@
 *     Tx completion may end up being out-of-order).
 *
 *     The driver must maintain the queue's Byte Count table in host DRAM
- *     (struct iwl4965_sched_queue_byte_cnt_tbl) for this mode.
+ *     for this mode.
 *     This mode does not support fragmentation.
 *
 * 2)  FIFO (a.k.a. non-Scheduler-ACK), in which each TFD is processed in order.
@@ -311,7 +154,7 @@
 *
 * Driver controls scheduler operation via 3 means:
 * 1)  Scheduler registers
- * 2)  Shared scheduler data base in internal 4956 SRAM
+ * 2)  Shared scheduler data base in internal SRAM
 * 3)  Shared data in host DRAM
 *
 * Initialization:
@@ -330,201 +173,10 @@
 * Max Tx window size is the max number of contiguous TFDs that the scheduler
 * can keep track of at one time when creating block-ack chains of frames.
 * Note that "64" matches the number of ack bits in a block-ack packet.
- * Driver should use SCD_WIN_SIZE and SCD_FRAME_LIMIT values to initialize
- * IWL49_SCD_CONTEXT_QUEUE_OFFSET(x) values.
 */
 #define SCD_WIN_SIZE                            64
 #define SCD_FRAME_LIMIT                         64
-/* SCD registers are internal, must be accessed via HBUS_TARG_PRPH regs */
-#define IWL49_SCD_START_OFFSET          0xa02c00
-/*
- * 4965 tells driver SRAM address for internal scheduler structs via this reg.
- * Value is valid only after "Alive" response from uCode.
- */
-#define IWL49_SCD_SRAM_BASE_ADDR           (IWL49_SCD_START_OFFSET + 0x0)
-/*
- * Driver may need to update queue-empty bits after changing queue's
- * write and read pointers (indexes) during (re-)initialization (i.e. when
- * scheduler is not tracking what's happening).
- * Bit fields:
- * 31-16:  Write mask -- 1: update empty bit, 0: don't change empty bit
- * 15-00:  Empty state, one for each queue -- 1: empty, 0: non-empty
- * NOTE:  This register is not used by Linux driver.
- */
-#define IWL49_SCD_EMPTY_BITS               (IWL49_SCD_START_OFFSET + 0x4)
-/*
- * Physical base address of array of byte count (BC) circular buffers (CBs).
- * Each Tx queue has a BC CB in host DRAM to support Scheduler-ACK mode.
- * This register points to BC CB for queue 0, must be on 1024-byte boundary.
- * Others are spaced by 1024 bytes.
- * Each BC CB is 2 bytes * (256 + 64) = 740 bytes, followed by 384 bytes pad.
- * (Index into a queue's BC CB) = (index into queue's TFD CB) = (SSN & 0xff).
- * Bit fields:
- * 25-00:  Byte Count CB physical address [35:10], must be 1024-byte aligned.
- */
-#define IWL49_SCD_DRAM_BASE_ADDR           (IWL49_SCD_START_OFFSET + 0x10)
-/*
- * Enables any/all Tx DMA/FIFO channels.
- * Scheduler generates requests for only the active channels.
- * Set this to 0xff to enable all 8 channels (normal usage).
- * Bit fields:
- *  7- 0:  Enable (1), disable (0), one bit for each channel 0-7
- */
-#define IWL49_SCD_TXFACT                   (IWL49_SCD_START_OFFSET + 0x1c)
-/*
- * Queue (x) Write Pointers (indexes, really!), one for each Tx queue.
- * Initialized and updated by driver as new TFDs are added to queue.
- * NOTE:  If using Block Ack, index must correspond to frame's
- *        Start Sequence Number; index = (SSN & 0xff)
- * NOTE:  Alternative to HBUS_TARG_WRPTR, which is what Linux driver uses?
- */
-#define IWL49_SCD_QUEUE_WRPTR(x)  (IWL49_SCD_START_OFFSET + 0x24 + (x) * 4)
-/*
- * Queue (x) Read Pointers (indexes, really!), one for each Tx queue.
- * For FIFO mode, index indicates next frame to transmit.
- * For Scheduler-ACK mode, index indicates first frame in Tx window.
- * Initialized by driver, updated by scheduler.
- */
-#define IWL49_SCD_QUEUE_RDPTR(x)  (IWL49_SCD_START_OFFSET + 0x64 + (x) * 4)
-/*
- * Select which queues work in chain mode (1) vs. not (0).
- * Use chain mode to build chains of aggregated frames.
- * Bit fields:
- * 31-16:  Reserved
- * 15-00:  Mode, one bit for each queue -- 1: Chain mode, 0: one-at-a-time
- * NOTE:  If driver sets up queue for chain mode, it should be also set up
- *        Scheduler-ACK mode as well, via SCD_QUEUE_STATUS_BITS(x).
- */
-#define IWL49_SCD_QUEUECHAIN_SEL  (IWL49_SCD_START_OFFSET + 0xd0)
-/*
- * Select which queues interrupt driver when scheduler increments
- * a queue's read pointer (index).
- * Bit fields:
- * 31-16:  Reserved
- * 15-00:  Interrupt enable, one bit for each queue -- 1: enabled, 0: disabled
- * NOTE:  This functionality is apparently a no-op; driver relies on interrupts
- *        from Rx queue to read Tx command responses and update Tx queues.
- */
-#define IWL49_SCD_INTERRUPT_MASK  (IWL49_SCD_START_OFFSET + 0xe4)
-/*
- * Queue search status registers.  One for each queue.
- * Sets up queue mode and assigns queue to Tx DMA channel.
- * Bit fields:
- * 19-10: Write mask/enable bits for bits 0-9
- *     9: Driver should init to "0"
- *     8: Scheduler-ACK mode (1), non-Scheduler-ACK (i.e. FIFO) mode (0).
- *        Driver should init to "1" for aggregation mode, or "0" otherwise.
- *   7-6: Driver should init to "0"
- *     5: Window Size Left; indicates whether scheduler can request
- *        another TFD, based on window size, etc.  Driver should init
- *        this bit to "1" for aggregation mode, or "0" for non-agg.
- *   4-1: Tx FIFO to use (range 0-7).
- *     0: Queue is active (1), not active (0).
- * Other bits should be written as "0"
- *
- * NOTE:  If enabling Scheduler-ACK mode, chain mode should also be enabled
- *        via SCD_QUEUECHAIN_SEL.
- */
-#define IWL49_SCD_QUEUE_STATUS_BITS(x)\
-        (IWL49_SCD_START_OFFSET + 0x104 + (x) * 4)
-/* Bit field positions */
-#define IWL49_SCD_QUEUE_STTS_REG_POS_ACTIVE     (0)
-#define IWL49_SCD_QUEUE_STTS_REG_POS_TXF        (1)
-#define IWL49_SCD_QUEUE_STTS_REG_POS_WSL        (5)
-#define IWL49_SCD_QUEUE_STTS_REG_POS_SCD_ACK    (8)
-/* Write masks */
-#define IWL49_SCD_QUEUE_STTS_REG_POS_SCD_ACT_EN (10)
-#define IWL49_SCD_QUEUE_STTS_REG_MSK            (0x0007FC00)
-/**
- * 4965 internal SRAM structures for scheduler, shared with driver ...
- *
- * Driver should clear and initialize the following areas after receiving
- * "Alive" response from 4965 uCode, i.e. after initial
- * uCode load, or after a uCode load done for error recovery:
- *
- * SCD_CONTEXT_DATA_OFFSET (size 128 bytes)
- * SCD_TX_STTS_BITMAP_OFFSET (size 256 bytes)
- * SCD_TRANSLATE_TBL_OFFSET (size 32 bytes)
- *
- * Driver accesses SRAM via HBUS_TARG_MEM_* registers.
- * Driver reads base address of this scheduler area from SCD_SRAM_BASE_ADDR.
- * All OFFSET values must be added to this base address.
- */
-/*
- * Queue context.  One 8-byte entry for each of 16 queues.
- *
- * Driver should clear this entire area (size 0x80) to 0 after receiving
- * "Alive" notification from uCode.  Additionally, driver should init
- * each queue's entry as follows:
- *
- * LS Dword bit fields:
- *  0-06:  Max Tx window size for Scheduler-ACK.  Driver should init to 64.
- *
- * MS Dword bit fields:
- * 16-22:  Frame limit.  Driver should init to 10 (0xa).
- *
- * Driver should init all other bits to 0.
- *
- * Init must be done after driver receives "Alive" response from 4965 uCode,
- * and when setting up queue for aggregation.
- */
-#define IWL49_SCD_CONTEXT_DATA_OFFSET                   0x380
-#define IWL49_SCD_CONTEXT_QUEUE_OFFSET(x) \
-                        (IWL49_SCD_CONTEXT_DATA_OFFSET + ((x) * 8))
-#define IWL49_SCD_QUEUE_CTX_REG1_WIN_SIZE_POS           (0)
-#define IWL49_SCD_QUEUE_CTX_REG1_WIN_SIZE_MSK           (0x0000007F)
-#define IWL49_SCD_QUEUE_CTX_REG2_FRAME_LIMIT_POS        (16)
-#define IWL49_SCD_QUEUE_CTX_REG2_FRAME_LIMIT_MSK        (0x007F0000)
-/*
- * Tx Status Bitmap
- *
- * Driver should clear this entire area (size 0x100) to 0 after receiving
- * "Alive" notification from uCode.  Area is used only by device itself;
- * no other support (besides clearing) is required from driver.
- */
-#define IWL49_SCD_TX_STTS_BITMAP_OFFSET         0x400
-/*
- * RAxTID to queue translation mapping.
- *
- * When queue is in Scheduler-ACK mode, frames placed in a that queue must be
- * for only one combination of receiver address (RA) and traffic ID (TID), i.e.
- * one QOS priority level destined for one station (for this wireless link,
- * not final destination).  The SCD_TRANSLATE_TABLE area provides 16 16-bit
- * mappings, one for each of the 16 queues.  If queue is not in Scheduler-ACK
- * mode, the device ignores the mapping value.
- *
- * Bit fields, for each 16-bit map:
- * 15-9:  Reserved, set to 0
- *  8-4:  Index into device's station table for recipient station
- *  3-0:  Traffic ID (tid), range 0-15
- *
- * Driver should clear this entire area (size 32 bytes) to 0 after receiving
- * "Alive" notification from uCode.  To update a 16-bit map value, driver
- * must read a dword-aligned value from device SRAM, replace the 16-bit map
- * value of interest, and write the dword value back into device SRAM.
- */
-#define IWL49_SCD_TRANSLATE_TBL_OFFSET          0x500
-/* Find translation table dword to read/write for given queue */
-#define IWL49_SCD_TRANSLATE_TBL_OFFSET_QUEUE(x) \
-        ((IWL49_SCD_TRANSLATE_TBL_OFFSET + ((x) * 2)) & 0xfffffffc)
 #define IWL_SCD_TXFIFO_POS_TID                  (0)
 #define IWL_SCD_TXFIFO_POS_RA                   (4)
 #define IWL_SCD_QUEUE_RA_TID_MAP_RATID_MSK      (0x01FF)
diff --git a/drivers/net/wireless/iwlwifi/iwl-rx.c b/drivers/net/wireless/iwlwifi/iwl-rx.c
index 6f9a2fa04763..0053e9ea9021 100644
--- a/drivers/net/wireless/iwlwifi/iwl-rx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-rx.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
@@ -225,55 +225,6 @@ err_bd:
 *
 ******************************************************************************/
-static void iwl_rx_reply_alive(struct iwl_priv *priv,
-                               struct iwl_rx_mem_buffer *rxb)
-{
-        struct iwl_rx_packet *pkt = rxb_addr(rxb);
-        struct iwl_alive_resp *palive;
-        struct delayed_work *pwork;
-        palive = &pkt->u.alive_frame;
-        IWL_DEBUG_INFO(priv, "Alive ucode status 0x%08X revision "
-                       "0x%01X 0x%01X\n",
-                       palive->is_valid, palive->ver_type,
-                       palive->ver_subtype);
-        if (palive->ver_subtype == INITIALIZE_SUBTYPE) {
-                IWL_DEBUG_INFO(priv, "Initialization Alive received.\n");
-                memcpy(&priv->card_alive_init,
-                       &pkt->u.alive_frame,
-                       sizeof(struct iwl_init_alive_resp));
-                pwork = &priv->init_alive_start;
-        } else {
-                IWL_DEBUG_INFO(priv, "Runtime Alive received.\n");
-                memcpy(&priv->card_alive, &pkt->u.alive_frame,
-                       sizeof(struct iwl_alive_resp));
-                pwork = &priv->alive_start;
-        }
-        /* We delay the ALIVE response by 5ms to
-         * give the HW RF Kill time to activate... */
-        if (palive->is_valid == UCODE_VALID_OK)
-                queue_delayed_work(priv->workqueue, pwork,
-                                   msecs_to_jiffies(5));
-        else {
-                IWL_WARN(priv, "%s uCode did not respond OK.\n",
-                        (palive->ver_subtype == INITIALIZE_SUBTYPE) ?
-                        "init" : "runtime");
-                /*
-                 * If fail to load init uCode,
-                 * let's try to load the init uCode again.
-                 * We should not get into this situation, but if it
-                 * does happen, we should not move on and loading "runtime"
-                 * without proper calibrate the device.
-                 */
-                if (palive->ver_subtype == INITIALIZE_SUBTYPE)
-                        priv->ucode_type = UCODE_NONE;
-                queue_work(priv->workqueue, &priv->restart);
-        }
-}
 static void iwl_rx_reply_error(struct iwl_priv *priv,
                               struct iwl_rx_mem_buffer *rxb)
 {
@@ -390,21 +341,16 @@ static void iwl_rx_beacon_notif(struct iwl_priv *priv,
 * the BA_TIMEOUT_MAX, reload firmware and bring system back to normal
 * operation state.
 */
-static bool iwl_good_ack_health(struct iwl_priv *priv, struct iwl_rx_packet *pkt)
+static bool iwl_good_ack_health(struct iwl_priv *priv,
+                                struct statistics_tx *cur)
 {
        int actual_delta, expected_delta, ba_timeout_delta;
-        struct statistics_tx *cur, *old;
+        struct statistics_tx *old;
        if (priv->_agn.agg_tids_count)
                return true;
-        if (iwl_bt_statistics(priv)) {
+        old = &priv->statistics.tx;
-                cur = &pkt->u.stats_bt.tx;
-                old = &priv->_agn.statistics_bt.tx;
-        } else {
-                cur = &pkt->u.stats.tx;
-                old = &priv->_agn.statistics.tx;
-        }
        actual_delta = le32_to_cpu(cur->actual_ack_cnt) -
                       le32_to_cpu(old->actual_ack_cnt);
@@ -430,10 +376,10 @@ static bool iwl_good_ack_health(struct iwl_priv *priv, struct iwl_rx_packet *pkt
                 * DEBUG is not, these will just compile out.
                 */
                IWL_DEBUG_RADIO(priv, "rx_detected_cnt delta %d\n",
-                                priv->_agn.delta_statistics.tx.rx_detected_cnt);
+                                priv->delta_stats.tx.rx_detected_cnt);
                IWL_DEBUG_RADIO(priv,
                                "ack_or_ba_timeout_collision delta %d\n",
-                                priv->_agn.delta_statistics.tx.ack_or_ba_timeout_collision);
+                                priv->delta_stats.tx.ack_or_ba_timeout_collision);
 #endif
                if (ba_timeout_delta >= BA_TIMEOUT_MAX)
@@ -450,7 +396,9 @@ static bool iwl_good_ack_health(struct iwl_priv *priv, struct iwl_rx_packet *pkt
 * to improve the throughput.
 */
 static bool iwl_good_plcp_health(struct iwl_priv *priv,
-                                 struct iwl_rx_packet *pkt, unsigned int msecs)
+                                 struct statistics_rx_phy *cur_ofdm,
+                                 struct statistics_rx_ht_phy *cur_ofdm_ht,
+                                 unsigned int msecs)
 {
        int delta;
        int threshold = priv->cfg->base_params->plcp_delta_threshold;
@@ -460,29 +408,12 @@ static bool iwl_good_plcp_health(struct iwl_priv *priv,
                return true;
        }
-        if (iwl_bt_statistics(priv)) {
+        delta = le32_to_cpu(cur_ofdm->plcp_err) -
-                struct statistics_rx_bt *cur, *old;
+                le32_to_cpu(priv->statistics.rx_ofdm.plcp_err) +
+                le32_to_cpu(cur_ofdm_ht->plcp_err) -
-                cur = &pkt->u.stats_bt.rx;
+                le32_to_cpu(priv->statistics.rx_ofdm_ht.plcp_err);
-                old = &priv->_agn.statistics_bt.rx;
-                delta = le32_to_cpu(cur->ofdm.plcp_err) -
+        /* Can be negative if firmware reset statistics */
-                        le32_to_cpu(old->ofdm.plcp_err) +
-                        le32_to_cpu(cur->ofdm_ht.plcp_err) -
-                        le32_to_cpu(old->ofdm_ht.plcp_err);
-        } else {
-                struct statistics_rx *cur, *old;
-                cur = &pkt->u.stats.rx;
-                old = &priv->_agn.statistics.rx;
-                delta = le32_to_cpu(cur->ofdm.plcp_err) -
-                        le32_to_cpu(old->ofdm.plcp_err) +
-                        le32_to_cpu(cur->ofdm_ht.plcp_err) -
-                        le32_to_cpu(old->ofdm_ht.plcp_err);
-        }
-        /* Can be negative if firmware reseted statistics */
        if (delta <= 0)
                return true;
@@ -497,44 +428,35 @@ static bool iwl_good_plcp_health(struct iwl_priv *priv,
 }
 static void iwl_recover_from_statistics(struct iwl_priv *priv,
-                                        struct iwl_rx_packet *pkt)
+                                        struct statistics_rx_phy *cur_ofdm,
+                                        struct statistics_rx_ht_phy *cur_ofdm_ht,
+                                        struct statistics_tx *tx,
+                                        unsigned long stamp)
 {
-        const struct iwl_mod_params *mod_params = priv->cfg->mod_params;
        unsigned int msecs;
-        unsigned long stamp;
        if (test_bit(STATUS_EXIT_PENDING, &priv->status))
                return;
-        stamp = jiffies;
        msecs = jiffies_to_msecs(stamp - priv->rx_statistics_jiffies);
        /* Only gather statistics and update time stamp when not associated */
        if (!iwl_is_any_associated(priv))
-                goto out;
+                return;
        /* Do not check/recover when do not have enough statistics data */
        if (msecs < 99)
                return;
-        if (mod_params->ack_check && !iwl_good_ack_health(priv, pkt)) {
+        if (iwlagn_mod_params.ack_check && !iwl_good_ack_health(priv, tx)) {
                IWL_ERR(priv, "low ack count detected, restart firmware\n");
                if (!iwl_force_reset(priv, IWL_FW_RESET, false))
                        return;
        }
-        if (mod_params->plcp_check && !iwl_good_plcp_health(priv, pkt, msecs))
+        if (iwlagn_mod_params.plcp_check &&
+            !iwl_good_plcp_health(priv, cur_ofdm, cur_ofdm_ht, msecs))
                iwl_force_reset(priv, IWL_RF_RESET, false);
-out:
-        if (iwl_bt_statistics(priv))
-                memcpy(&priv->_agn.statistics_bt, &pkt->u.stats_bt,
-                        sizeof(priv->_agn.statistics_bt));
-        else
-                memcpy(&priv->_agn.statistics, &pkt->u.stats,
-                        sizeof(priv->_agn.statistics));
-        priv->rx_statistics_jiffies = stamp;
 }
 /* Calculate noise level, based on measurements during network silence just
@@ -548,10 +470,8 @@ static void iwl_rx_calc_noise(struct iwl_priv *priv)
        int bcn_silence_a, bcn_silence_b, bcn_silence_c;
        int last_rx_noise;
-        if (iwl_bt_statistics(priv))
+        rx_info = &priv->statistics.rx_non_phy;
-                rx_info = &(priv->_agn.statistics_bt.rx.general.common);
-        else
-                rx_info = &(priv->_agn.statistics.rx.general);
        bcn_silence_a =
                le32_to_cpu(rx_info->beacon_silence_rssi_a) & IN_BAND_FILTER;
        bcn_silence_b =
@@ -583,105 +503,153 @@ static void iwl_rx_calc_noise(struct iwl_priv *priv)
                        last_rx_noise);
 }
+#ifdef CONFIG_IWLWIFI_DEBUGFS
 /*
 *  based on the assumption of all statistics counter are in DWORD
 *  FIXME: This function is for debugging, do not deal with
 *  the case of counters roll-over.
 */
-static void iwl_accumulative_statistics(struct iwl_priv *priv,
+static void accum_stats(__le32 *prev, __le32 *cur, __le32 *delta,
-                                        __le32 *stats)
+                        __le32 *max_delta, __le32 *accum, int size)
 {
-#ifdef CONFIG_IWLWIFI_DEBUGFS
+        int i;
-        int i, size;
-        __le32 *prev_stats;
+        for (i = 0;
-        u32 *accum_stats;
+             i < size / sizeof(__le32);
-        u32 *delta, *max_delta;
+             i++, prev++, cur++, delta++, max_delta++, accum++) {
-        struct statistics_general_common *general, *accum_general;
+                if (le32_to_cpu(*cur) > le32_to_cpu(*prev)) {
-        struct statistics_tx *tx, *accum_tx;
+                        *delta = cpu_to_le32(
+                                le32_to_cpu(*cur) - le32_to_cpu(*prev));
-        if (iwl_bt_statistics(priv)) {
+                        le32_add_cpu(accum, le32_to_cpu(*delta));
-                prev_stats = (__le32 *)&priv->_agn.statistics_bt;
+                        if (le32_to_cpu(*delta) > le32_to_cpu(*max_delta))
-                accum_stats = (u32 *)&priv->_agn.accum_statistics_bt;
-                size = sizeof(struct iwl_bt_notif_statistics);
-                general = &priv->_agn.statistics_bt.general.common;
-                accum_general = &priv->_agn.accum_statistics_bt.general.common;
-                tx = &priv->_agn.statistics_bt.tx;
-                accum_tx = &priv->_agn.accum_statistics_bt.tx;
-                delta = (u32 *)&priv->_agn.delta_statistics_bt;
-                max_delta = (u32 *)&priv->_agn.max_delta_bt;
-        } else {
-                prev_stats = (__le32 *)&priv->_agn.statistics;
-                accum_stats = (u32 *)&priv->_agn.accum_statistics;
-                size = sizeof(struct iwl_notif_statistics);
-                general = &priv->_agn.statistics.general.common;
-                accum_general = &priv->_agn.accum_statistics.general.common;
-                tx = &priv->_agn.statistics.tx;
-                accum_tx = &priv->_agn.accum_statistics.tx;
-                delta = (u32 *)&priv->_agn.delta_statistics;
-                max_delta = (u32 *)&priv->_agn.max_delta;
-        }
-        for (i = sizeof(__le32); i < size;
-             i += sizeof(__le32), stats++, prev_stats++, delta++,
-             max_delta++, accum_stats++) {
-                if (le32_to_cpu(*stats) > le32_to_cpu(*prev_stats)) {
-                        *delta = (le32_to_cpu(*stats) -
-                                le32_to_cpu(*prev_stats));
-                        *accum_stats += *delta;
-                        if (*delta > *max_delta)
                                *max_delta = *delta;
                }
        }
+}
-        /* reset accumulative statistics for "no-counter" type statistics */
+static void
-        accum_general->temperature = general->temperature;
+iwl_accumulative_statistics(struct iwl_priv *priv,
-        accum_general->temperature_m = general->temperature_m;
+                            struct statistics_general_common *common,
-        accum_general->ttl_timestamp = general->ttl_timestamp;
+                            struct statistics_rx_non_phy *rx_non_phy,
-        accum_tx->tx_power.ant_a = tx->tx_power.ant_a;
+                            struct statistics_rx_phy *rx_ofdm,
-        accum_tx->tx_power.ant_b = tx->tx_power.ant_b;
+                            struct statistics_rx_ht_phy *rx_ofdm_ht,
-        accum_tx->tx_power.ant_c = tx->tx_power.ant_c;
+                            struct statistics_rx_phy *rx_cck,
-#endif
+                            struct statistics_tx *tx,
+                            struct statistics_bt_activity *bt_activity)
+{
+#define ACCUM(_name)    \
+        accum_stats((__le32 *)&priv->statistics._name,          \
+                    (__le32 *)_name,                            \
+                    (__le32 *)&priv->delta_stats._name,         \
+                    (__le32 *)&priv->max_delta_stats._name,     \
+                    (__le32 *)&priv->accum_stats._name,         \
+                    sizeof(*_name));
+        ACCUM(common);
+        ACCUM(rx_non_phy);
+        ACCUM(rx_ofdm);
+        ACCUM(rx_ofdm_ht);
+        ACCUM(rx_cck);
+        ACCUM(tx);
+        if (bt_activity)
+                ACCUM(bt_activity);
+#undef ACCUM
+}
+#else
+static inline void
+iwl_accumulative_statistics(struct iwl_priv *priv,
+                            struct statistics_general_common *common,
+                            struct statistics_rx_non_phy *rx_non_phy,
+                            struct statistics_rx_phy *rx_ofdm,
+                            struct statistics_rx_ht_phy *rx_ofdm_ht,
+                            struct statistics_rx_phy *rx_cck,
+                            struct statistics_tx *tx,
+                            struct statistics_bt_activity *bt_activity)
+{
 }
+#endif
 static void iwl_rx_statistics(struct iwl_priv *priv,
                              struct iwl_rx_mem_buffer *rxb)
 {
+        unsigned long stamp = jiffies;
        const int reg_recalib_period = 60;
        int change;
        struct iwl_rx_packet *pkt = rxb_addr(rxb);
+        u32 len = le32_to_cpu(pkt->len_n_flags) & FH_RSCSR_FRAME_SIZE_MSK;
+        __le32 *flag;
+        struct statistics_general_common *common;
+        struct statistics_rx_non_phy *rx_non_phy;
+        struct statistics_rx_phy *rx_ofdm;
+        struct statistics_rx_ht_phy *rx_ofdm_ht;
+        struct statistics_rx_phy *rx_cck;
+        struct statistics_tx *tx;
+        struct statistics_bt_activity *bt_activity;
+        len -= sizeof(struct iwl_cmd_header); /* skip header */
+        IWL_DEBUG_RX(priv, "Statistics notification received (%d bytes).\n",
+                     len);
+        if (len == sizeof(struct iwl_bt_notif_statistics)) {
+                struct iwl_bt_notif_statistics *stats;
+                stats = &pkt->u.stats_bt;
+                flag = &stats->flag;
+                common = &stats->general.common;
+                rx_non_phy = &stats->rx.general.common;
+                rx_ofdm = &stats->rx.ofdm;
+                rx_ofdm_ht = &stats->rx.ofdm_ht;
+                rx_cck = &stats->rx.cck;
+                tx = &stats->tx;
+                bt_activity = &stats->general.activity;
-        if (iwl_bt_statistics(priv)) {
+#ifdef CONFIG_IWLWIFI_DEBUGFS
-                IWL_DEBUG_RX(priv,
+                /* handle this exception directly */
-                             "Statistics notification received (%d vs %d).\n",
+                priv->statistics.num_bt_kills = stats->rx.general.num_bt_kills;
-                             (int)sizeof(struct iwl_bt_notif_statistics),
+                le32_add_cpu(&priv->statistics.accum_num_bt_kills,
-                             le32_to_cpu(pkt->len_n_flags) &
+                             le32_to_cpu(stats->rx.general.num_bt_kills));
-                             FH_RSCSR_FRAME_SIZE_MSK);
+#endif
+        } else if (len == sizeof(struct iwl_notif_statistics)) {
-                change = ((priv->_agn.statistics_bt.general.common.temperature !=
+                struct iwl_notif_statistics *stats;
-                           pkt->u.stats_bt.general.common.temperature) ||
+                stats = &pkt->u.stats;
-                           ((priv->_agn.statistics_bt.flag &
+                flag = &stats->flag;
-                           STATISTICS_REPLY_FLG_HT40_MODE_MSK) !=
+                common = &stats->general.common;
-                           (pkt->u.stats_bt.flag &
+                rx_non_phy = &stats->rx.general;
-                           STATISTICS_REPLY_FLG_HT40_MODE_MSK)));
+                rx_ofdm = &stats->rx.ofdm;
+                rx_ofdm_ht = &stats->rx.ofdm_ht;
-                iwl_accumulative_statistics(priv, (__le32 *)&pkt->u.stats_bt);
+                rx_cck = &stats->rx.cck;
+                tx = &stats->tx;
+                bt_activity = NULL;
        } else {
-                IWL_DEBUG_RX(priv,
+                WARN_ONCE(1, "len %d doesn't match BT (%zu) or normal (%zu)\n",
-                             "Statistics notification received (%d vs %d).\n",
+                          len, sizeof(struct iwl_bt_notif_statistics),
-                             (int)sizeof(struct iwl_notif_statistics),
+                          sizeof(struct iwl_notif_statistics));
-                             le32_to_cpu(pkt->len_n_flags) &
+                return;
-                             FH_RSCSR_FRAME_SIZE_MSK);
-                change = ((priv->_agn.statistics.general.common.temperature !=
-                           pkt->u.stats.general.common.temperature) ||
-                           ((priv->_agn.statistics.flag &
-                           STATISTICS_REPLY_FLG_HT40_MODE_MSK) !=
-                           (pkt->u.stats.flag &
-                           STATISTICS_REPLY_FLG_HT40_MODE_MSK)));
-                iwl_accumulative_statistics(priv, (__le32 *)&pkt->u.stats);
        }
-        iwl_recover_from_statistics(priv, pkt);
+        change = common->temperature != priv->statistics.common.temperature ||
+                 (*flag & STATISTICS_REPLY_FLG_HT40_MODE_MSK) !=
+                 (priv->statistics.flag & STATISTICS_REPLY_FLG_HT40_MODE_MSK);
+        iwl_accumulative_statistics(priv, common, rx_non_phy, rx_ofdm,
+                                    rx_ofdm_ht, rx_cck, tx, bt_activity);
+        iwl_recover_from_statistics(priv, rx_ofdm, rx_ofdm_ht, tx, stamp);
+        priv->statistics.flag = *flag;
+        memcpy(&priv->statistics.common, common, sizeof(*common));
+        memcpy(&priv->statistics.rx_non_phy, rx_non_phy, sizeof(*rx_non_phy));
+        memcpy(&priv->statistics.rx_ofdm, rx_ofdm, sizeof(*rx_ofdm));
+        memcpy(&priv->statistics.rx_ofdm_ht, rx_ofdm_ht, sizeof(*rx_ofdm_ht));
+        memcpy(&priv->statistics.rx_cck, rx_cck, sizeof(*rx_cck));
+        memcpy(&priv->statistics.tx, tx, sizeof(*tx));
+#ifdef CONFIG_IWLWIFI_DEBUGFS
+        if (bt_activity)
+                memcpy(&priv->statistics.bt_activity, bt_activity,
+                        sizeof(*bt_activity));
+#endif
+        priv->rx_statistics_jiffies = stamp;
        set_bit(STATUS_STATISTICS, &priv->status);
@@ -708,18 +676,12 @@ static void iwl_rx_reply_statistics(struct iwl_priv *priv,
        if (le32_to_cpu(pkt->u.stats.flag) & UCODE_STATISTICS_CLEAR_MSK) {
 #ifdef CONFIG_IWLWIFI_DEBUGFS
-                memset(&priv->_agn.accum_statistics, 0,
+                memset(&priv->accum_stats, 0,
-                        sizeof(struct iwl_notif_statistics));
+                        sizeof(priv->accum_stats));
-                memset(&priv->_agn.delta_statistics, 0,
+                memset(&priv->delta_stats, 0,
-                        sizeof(struct iwl_notif_statistics));
+                        sizeof(priv->delta_stats));
-                memset(&priv->_agn.max_delta, 0,
+                memset(&priv->max_delta_stats, 0,
-                        sizeof(struct iwl_notif_statistics));
+                        sizeof(priv->max_delta_stats));
-                memset(&priv->_agn.accum_statistics_bt, 0,
-                        sizeof(struct iwl_bt_notif_statistics));
-                memset(&priv->_agn.delta_statistics_bt, 0,
-                        sizeof(struct iwl_bt_notif_statistics));
-                memset(&priv->_agn.max_delta_bt, 0,
-                        sizeof(struct iwl_bt_notif_statistics));
 #endif
                IWL_DEBUG_RX(priv, "Statistics have been cleared\n");
        }
@@ -873,6 +835,7 @@ static void iwl_pass_packet_to_mac80211(struct iwl_priv *priv,
 {
        struct sk_buff *skb;
        __le16 fc = hdr->frame_control;
+        struct iwl_rxon_context *ctx;
        /* We only process data packets if the interface is open */
        if (unlikely(!priv->is_open)) {
@@ -882,7 +845,7 @@ static void iwl_pass_packet_to_mac80211(struct iwl_priv *priv,
        }
        /* In case of HW accelerated crypto and bad decryption, drop */
-        if (!priv->cfg->mod_params->sw_crypto &&
+        if (!iwlagn_mod_params.sw_crypto &&
            iwl_set_decrypted_flag(priv, hdr, ampdu_status, stats))
                return;
@@ -895,10 +858,29 @@ static void iwl_pass_packet_to_mac80211(struct iwl_priv *priv,
        skb_add_rx_frag(skb, 0, rxb->page, (void *)hdr - rxb_addr(rxb), len);
        iwl_update_stats(priv, false, fc, len);
+        /*
+        * Wake any queues that were stopped due to a passive channel tx
+        * failure. This can happen because the regulatory enforcement in
+        * the device waits for a beacon before allowing transmission,
+        * sometimes even after already having transmitted frames for the
+        * association because the new RXON may reset the information.
+        */
+        if (unlikely(ieee80211_is_beacon(fc))) {
+                for_each_context(priv, ctx) {
+                        if (!ctx->last_tx_rejected)
+                                continue;
+                        if (compare_ether_addr(hdr->addr3,
+                                               ctx->active.bssid_addr))
+                                continue;
+                        ctx->last_tx_rejected = false;
+                        iwl_wake_any_queue(priv, ctx);
+                }
+        }
        memcpy(IEEE80211_SKB_RXCB(skb), stats, sizeof(*stats));
        ieee80211_rx(priv->hw, skb);
-        priv->alloc_rxb_page--;
        rxb->page = NULL;
 }
@@ -1093,7 +1075,6 @@ void iwl_setup_rx_handlers(struct iwl_priv *priv)
        handlers = priv->rx_handlers;
-        handlers[REPLY_ALIVE]                   = iwl_rx_reply_alive;
        handlers[REPLY_ERROR]                   = iwl_rx_reply_error;
        handlers[CHANNEL_SWITCH_NOTIFICATION]   = iwl_rx_csa;
        handlers[SPECTRUM_MEASURE_NOTIFICATION] = iwl_rx_spectrum_measure_notif;
diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
index 914c77e44588..d60d630cb93a 100644
--- a/drivers/net/wireless/iwlwifi/iwl-scan.c
+++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
@@ -2,7 +2,7 @@
 *
 * GPL LICENSE SUMMARY
 *
- * Copyright(c) 2008 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
diff --git a/drivers/net/wireless/iwlwifi/iwl-spectrum.h b/drivers/net/wireless/iwlwifi/iwl-spectrum.h
deleted file mode 100644
index c4ca0b5d77da..000000000000
--- a/drivers/net/wireless/iwlwifi/iwl-spectrum.h
+++ /dev/null
@@ -1,92 +0,0 @@
-/******************************************************************************
- *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
- *
- * Portions of this file are derived from the ieee80211 subsystem header files.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
- * The full GNU General Public License is included in this distribution in the
- * file called LICENSE.
- *
- * Contact Information:
- *  Intel Linux Wireless <ilw@linux.intel.com>
- * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
- *
- *****************************************************************************/
-#ifndef __iwl_spectrum_h__
-#define __iwl_spectrum_h__
-enum {                          /* ieee80211_basic_report.map */
-        IEEE80211_BASIC_MAP_BSS = (1 << 0),
-        IEEE80211_BASIC_MAP_OFDM = (1 << 1),
-        IEEE80211_BASIC_MAP_UNIDENTIFIED = (1 << 2),
-        IEEE80211_BASIC_MAP_RADAR = (1 << 3),
-        IEEE80211_BASIC_MAP_UNMEASURED = (1 << 4),
-        /* Bits 5-7 are reserved */
-};
-struct ieee80211_basic_report {
-        u8 channel;
-        __le64 start_time;
-        __le16 duration;
-        u8 map;
-} __packed;
-enum {                          /* ieee80211_measurement_request.mode */
-        /* Bit 0 is reserved */
-        IEEE80211_MEASUREMENT_ENABLE = (1 << 1),
-        IEEE80211_MEASUREMENT_REQUEST = (1 << 2),
-        IEEE80211_MEASUREMENT_REPORT = (1 << 3),
-        /* Bits 4-7 are reserved */
-};
-enum {
-        IEEE80211_REPORT_BASIC = 0,     /* required */
-        IEEE80211_REPORT_CCA = 1,       /* optional */
-        IEEE80211_REPORT_RPI = 2,       /* optional */
-        /* 3-255 reserved */
-};
-struct ieee80211_measurement_params {
-        u8 channel;
-        __le64 start_time;
-        __le16 duration;
-} __packed;
-struct ieee80211_info_element {
-        u8 id;
-        u8 len;
-        u8 data[0];
-} __packed;
-struct ieee80211_measurement_request {
-        struct ieee80211_info_element ie;
-        u8 token;
-        u8 mode;
-        u8 type;
-        struct ieee80211_measurement_params params[0];
-} __packed;
-struct ieee80211_measurement_report {
-        struct ieee80211_info_element ie;
-        u8 token;
-        u8 mode;
-        u8 type;
-        union {
-                struct ieee80211_basic_report basic[0];
-        } u;
-} __packed;
-#endif
diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c
index bc90a12408a3..3c8cebde16cc 100644
--- a/drivers/net/wireless/iwlwifi/iwl-sta.c
+++ b/drivers/net/wireless/iwlwifi/iwl-sta.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
@@ -233,7 +233,6 @@ u8 iwl_prep_station(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
        struct iwl_station_entry *station;
        int i;
        u8 sta_id = IWL_INVALID_STATION;
-        u16 rate;
        if (is_ap)
                sta_id = ctx->ap_sta_id;
@@ -306,12 +305,6 @@ u8 iwl_prep_station(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
         */
        iwl_set_ht_add_station(priv, sta_id, sta, ctx);
-        /* 3945 only */
-        rate = (priv->band == IEEE80211_BAND_5GHZ) ?
-                IWL_RATE_6M_PLCP : IWL_RATE_1M_PLCP;
-        /* Turn on both antennas for the station... */
-        station->sta.rate_n_flags = cpu_to_le16(rate | RATE_MCS_ANT_AB_MSK);
        return sta_id;
 }
@@ -501,7 +494,8 @@ int iwl_remove_station(struct iwl_priv *priv, const u8 sta_id,
        priv->num_stations--;
-        BUG_ON(priv->num_stations < 0);
+        if (WARN_ON(priv->num_stations < 0))
+                priv->num_stations = 0;
        spin_unlock_irqrestore(&priv->sta_lock, flags);
@@ -686,7 +680,8 @@ void iwl_dealloc_bcast_stations(struct iwl_priv *priv)
                priv->stations[i].used &= ~IWL_STA_UCODE_ACTIVE;
                priv->num_stations--;
-                BUG_ON(priv->num_stations < 0);
+                if (WARN_ON(priv->num_stations < 0))
+                        priv->num_stations = 0;
                kfree(priv->stations[i].lq);
                priv->stations[i].lq = NULL;
        }
@@ -782,7 +777,8 @@ int iwl_send_lq_cmd(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
        spin_unlock_irqrestore(&priv->sta_lock, flags_spin);
        iwl_dump_lq_cmd(priv, lq);
-        BUG_ON(init && (cmd.flags & CMD_ASYNC));
+        if (WARN_ON(init && (cmd.flags & CMD_ASYNC)))
+                return -EINVAL;
        if (is_lq_table_valid(priv, ctx, lq))
                ret = iwl_send_cmd(priv, &cmd);
diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.h b/drivers/net/wireless/iwlwifi/iwl-sta.h
index 206f1e1a0caf..ff64027ff4cb 100644
--- a/drivers/net/wireless/iwlwifi/iwl-sta.h
+++ b/drivers/net/wireless/iwlwifi/iwl-sta.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
diff --git a/drivers/net/wireless/iwlwifi/iwl-sv-open.c b/drivers/net/wireless/iwlwifi/iwl-sv-open.c
new file mode 100644
index 000000000000..89b6696622c1
--- /dev/null
+++ b/drivers/net/wireless/iwlwifi/iwl-sv-open.c
@@ -0,0 +1,469 @@
+/******************************************************************************
+ *
+ * This file is provided under a dual BSD/GPLv2 license.  When using or
+ * redistributing this file, you may do so under either license.
+ *
+ * GPL LICENSE SUMMARY
+ *
+ * Copyright(c) 2010 - 2011 Intel Corporation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110,
+ * USA
+ *
+ * The full GNU General Public License is included in this distribution
+ * in the file called LICENSE.GPL.
+ *
+ * Contact Information:
+ *  Intel Linux Wireless <ilw@linux.intel.com>
+ * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
+ *
+ * BSD LICENSE
+ *
+ * Copyright(c) 2010 - 2011 Intel Corporation. All rights reserved.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ *  * Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ *  * Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in
+ *    the documentation and/or other materials provided with the
+ *    distribution.
+ *  * Neither the name Intel Corporation nor the names of its
+ *    contributors may be used to endorse or promote products derived
+ *    from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ *****************************************************************************/
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <net/net_namespace.h>
+#include <linux/netdevice.h>
+#include <net/cfg80211.h>
+#include <net/mac80211.h>
+#include <net/netlink.h>
+#include "iwl-dev.h"
+#include "iwl-core.h"
+#include "iwl-debug.h"
+#include "iwl-fh.h"
+#include "iwl-io.h"
+#include "iwl-agn.h"
+#include "iwl-testmode.h"
+/* The TLVs used in the gnl message policy between the kernel module and
+ * user space application. iwl_testmode_gnl_msg_policy is to be carried
+ * through the NL80211_CMD_TESTMODE channel regulated by nl80211.
+ * See iwl-testmode.h
+ */
+static
+struct nla_policy iwl_testmode_gnl_msg_policy[IWL_TM_ATTR_MAX] = {
+        [IWL_TM_ATTR_COMMAND] = { .type = NLA_U32, },
+        [IWL_TM_ATTR_UCODE_CMD_ID] = { .type = NLA_U8, },
+        [IWL_TM_ATTR_UCODE_CMD_DATA] = { .type = NLA_UNSPEC, },
+        [IWL_TM_ATTR_REG_OFFSET] = { .type = NLA_U32, },
+        [IWL_TM_ATTR_REG_VALUE8] = { .type = NLA_U8, },
+        [IWL_TM_ATTR_REG_VALUE32] = { .type = NLA_U32, },
+        [IWL_TM_ATTR_SYNC_RSP] = { .type = NLA_UNSPEC, },
+        [IWL_TM_ATTR_UCODE_RX_PKT] = { .type = NLA_UNSPEC, },
+};
+/*
+ * See the struct iwl_rx_packet in iwl-commands.h for the format of the
+ * received events from the device
+ */
+static inline int get_event_length(struct iwl_rx_mem_buffer *rxb)
+{
+        struct iwl_rx_packet *pkt = rxb_addr(rxb);
+        if (pkt)
+                return le32_to_cpu(pkt->len_n_flags) & FH_RSCSR_FRAME_SIZE_MSK;
+        else
+                return 0;
+}
+/*
+ * This function multicasts the spontaneous messages from the device to the
+ * user space. It is invoked whenever there is a received messages
+ * from the device. This function is called within the ISR of the rx handlers
+ * in iwlagn driver.
+ *
+ * The parsing of the message content is left to the user space application,
+ * The message content is treated as unattacked raw data and is encapsulated
+ * with IWL_TM_ATTR_UCODE_RX_PKT multicasting to the user space.
+ *
+ * @priv: the instance of iwlwifi device
+ * @rxb: pointer to rx data content received by the ISR
+ *
+ * See the message policies and TLVs in iwl_testmode_gnl_msg_policy[].
+ * For the messages multicasting to the user application, the mandatory
+ * TLV fields are :
+ *      IWL_TM_ATTR_COMMAND must be IWL_TM_CMD_DEV2APP_UCODE_RX_PKT
+ *      IWL_TM_ATTR_UCODE_RX_PKT for carrying the message content
+ */
+static void iwl_testmode_ucode_rx_pkt(struct iwl_priv *priv,
+                                struct iwl_rx_mem_buffer *rxb)
+{
+        struct ieee80211_hw *hw = priv->hw;
+        struct sk_buff *skb;
+        void *data;
+        int length;
+        data = (void *)rxb_addr(rxb);
+        length = get_event_length(rxb);
+        if (!data || length == 0)
+                return;
+        skb = cfg80211_testmode_alloc_event_skb(hw->wiphy, 20 + length,
+                                                                GFP_ATOMIC);
+        if (skb == NULL) {
+                IWL_DEBUG_INFO(priv,
+                         "Run out of memory for messages to user space ?\n");
+                return;
+        }
+        NLA_PUT_U32(skb, IWL_TM_ATTR_COMMAND, IWL_TM_CMD_DEV2APP_UCODE_RX_PKT);
+        NLA_PUT(skb, IWL_TM_ATTR_UCODE_RX_PKT, length, data);
+        cfg80211_testmode_event(skb, GFP_ATOMIC);
+        return;
+nla_put_failure:
+        kfree_skb(skb);
+        IWL_DEBUG_INFO(priv, "Ouch, overran buffer, check allocation!\n");
+}
+void iwl_testmode_init(struct iwl_priv *priv)
+{
+        priv->pre_rx_handler = iwl_testmode_ucode_rx_pkt;
+}
+/*
+ * This function handles the user application commands to the ucode.
+ *
+ * It retrieves the mandatory fields IWL_TM_ATTR_UCODE_CMD_ID and
+ * IWL_TM_ATTR_UCODE_CMD_DATA and calls to the handler to send the
+ * host command to the ucode.
+ *
+ * If any mandatory field is missing, -ENOMSG is replied to the user space
+ * application; otherwise, the actual execution result of the host command to
+ * ucode is replied.
+ *
+ * @hw: ieee80211_hw object that represents the device
+ * @tb: gnl message fields from the user space
+ */
+static int iwl_testmode_ucode(struct ieee80211_hw *hw, struct nlattr **tb)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct iwl_host_cmd cmd;
+        memset(&cmd, 0, sizeof(struct iwl_host_cmd));
+        if (!tb[IWL_TM_ATTR_UCODE_CMD_ID] ||
+            !tb[IWL_TM_ATTR_UCODE_CMD_DATA]) {
+                IWL_DEBUG_INFO(priv,
+                        "Error finding ucode command mandatory fields\n");
+                return -ENOMSG;
+        }
+        cmd.id = nla_get_u8(tb[IWL_TM_ATTR_UCODE_CMD_ID]);
+        cmd.data = nla_data(tb[IWL_TM_ATTR_UCODE_CMD_DATA]);
+        cmd.len = nla_len(tb[IWL_TM_ATTR_UCODE_CMD_DATA]);
+        IWL_INFO(priv, "testmode ucode command ID 0x%x, flags 0x%x,"
+                                " len %d\n", cmd.id, cmd.flags, cmd.len);
+        /* ok, let's submit the command to ucode */
+        return iwl_send_cmd(priv, &cmd);
+}
+/*
+ * This function handles the user application commands for register access.
+ *
+ * It retrieves command ID carried with IWL_TM_ATTR_COMMAND and calls to the
+ * handlers respectively.
+ *
+ * If it's an unknown commdn ID, -ENOSYS is returned; or -ENOMSG if the
+ * mandatory fields(IWL_TM_ATTR_REG_OFFSET,IWL_TM_ATTR_REG_VALUE32,
+ * IWL_TM_ATTR_REG_VALUE8) are missing; Otherwise 0 is replied indicating
+ * the success of the command execution.
+ *
+ * If IWL_TM_ATTR_COMMAND is IWL_TM_CMD_APP2DEV_REG_READ32, the register read
+ * value is returned with IWL_TM_ATTR_REG_VALUE32.
+ *
+ * @hw: ieee80211_hw object that represents the device
+ * @tb: gnl message fields from the user space
+ */
+static int iwl_testmode_reg(struct ieee80211_hw *hw, struct nlattr **tb)
+{
+        struct iwl_priv *priv = hw->priv;
+        u32 ofs, val32;
+        u8 val8;
+        struct sk_buff *skb;
+        int status = 0;
+        if (!tb[IWL_TM_ATTR_REG_OFFSET]) {
+                IWL_DEBUG_INFO(priv, "Error finding register offset\n");
+                return -ENOMSG;
+        }
+        ofs = nla_get_u32(tb[IWL_TM_ATTR_REG_OFFSET]);
+        IWL_INFO(priv, "testmode register access command offset 0x%x\n", ofs);
+        switch (nla_get_u32(tb[IWL_TM_ATTR_COMMAND])) {
+        case IWL_TM_CMD_APP2DEV_REG_READ32:
+                val32 = iwl_read32(priv, ofs);
+                IWL_INFO(priv, "32bit value to read 0x%x\n", val32);
+                skb = cfg80211_testmode_alloc_reply_skb(hw->wiphy, 20);
+                if (!skb) {
+                        IWL_DEBUG_INFO(priv, "Error allocating memory\n");
+                        return -ENOMEM;
+                }
+                NLA_PUT_U32(skb, IWL_TM_ATTR_REG_VALUE32, val32);
+                status = cfg80211_testmode_reply(skb);
+                if (status < 0)
+                        IWL_DEBUG_INFO(priv,
+                                       "Error sending msg : %d\n", status);
+                break;
+        case IWL_TM_CMD_APP2DEV_REG_WRITE32:
+                if (!tb[IWL_TM_ATTR_REG_VALUE32]) {
+                        IWL_DEBUG_INFO(priv,
+                                       "Error finding value to write\n");
+                        return -ENOMSG;
+                } else {
+                        val32 = nla_get_u32(tb[IWL_TM_ATTR_REG_VALUE32]);
+                        IWL_INFO(priv, "32bit value to write 0x%x\n", val32);
+                        iwl_write32(priv, ofs, val32);
+                }
+                break;
+        case IWL_TM_CMD_APP2DEV_REG_WRITE8:
+                if (!tb[IWL_TM_ATTR_REG_VALUE8]) {
+                        IWL_DEBUG_INFO(priv, "Error finding value to write\n");
+                        return -ENOMSG;
+                } else {
+                        val8 = nla_get_u8(tb[IWL_TM_ATTR_REG_VALUE8]);
+                        IWL_INFO(priv, "8bit value to write 0x%x\n", val8);
+                        iwl_write8(priv, ofs, val8);
+                }
+                break;
+        default:
+                IWL_DEBUG_INFO(priv, "Unknown testmode register command ID\n");
+                return -ENOSYS;
+        }
+        return status;
+nla_put_failure:
+        kfree_skb(skb);
+        return -EMSGSIZE;
+}
+static int iwl_testmode_cfg_init_calib(struct iwl_priv *priv)
+{
+        struct iwl_notification_wait calib_wait;
+        int ret;
+        iwlagn_init_notification_wait(priv, &calib_wait,
+                                      CALIBRATION_COMPLETE_NOTIFICATION,
+                                      NULL, NULL);
+        ret = iwlagn_init_alive_start(priv);
+        if (ret) {
+                IWL_DEBUG_INFO(priv,
+                        "Error configuring init calibration: %d\n", ret);
+                goto cfg_init_calib_error;
+        }
+        ret = iwlagn_wait_notification(priv, &calib_wait, 2 * HZ);
+        if (ret)
+                IWL_DEBUG_INFO(priv, "Error detecting"
+                        " CALIBRATION_COMPLETE_NOTIFICATION: %d\n", ret);
+        return ret;
+cfg_init_calib_error:
+        iwlagn_remove_notification(priv, &calib_wait);
+        return ret;
+}
+/*
+ * This function handles the user application commands for driver.
+ *
+ * It retrieves command ID carried with IWL_TM_ATTR_COMMAND and calls to the
+ * handlers respectively.
+ *
+ * If it's an unknown commdn ID, -ENOSYS is replied; otherwise, the returned
+ * value of the actual command execution is replied to the user application.
+ *
+ * If there's any message responding to the user space, IWL_TM_ATTR_SYNC_RSP
+ * is used for carry the message while IWL_TM_ATTR_COMMAND must set to
+ * IWL_TM_CMD_DEV2APP_SYNC_RSP.
+ *
+ * @hw: ieee80211_hw object that represents the device
+ * @tb: gnl message fields from the user space
+ */
+static int iwl_testmode_driver(struct ieee80211_hw *hw, struct nlattr **tb)
+{
+        struct iwl_priv *priv = hw->priv;
+        struct sk_buff *skb;
+        unsigned char *rsp_data_ptr = NULL;
+        int status = 0, rsp_data_len = 0;
+        switch (nla_get_u32(tb[IWL_TM_ATTR_COMMAND])) {
+        case IWL_TM_CMD_APP2DEV_GET_DEVICENAME:
+                rsp_data_ptr = (unsigned char *)priv->cfg->name;
+                rsp_data_len = strlen(priv->cfg->name);
+                skb = cfg80211_testmode_alloc_reply_skb(hw->wiphy,
+                                                        rsp_data_len + 20);
+                if (!skb) {
+                        IWL_DEBUG_INFO(priv,
+                                       "Error allocating memory\n");
+                        return -ENOMEM;
+                }
+                NLA_PUT_U32(skb, IWL_TM_ATTR_COMMAND,
+                            IWL_TM_CMD_DEV2APP_SYNC_RSP);
+                NLA_PUT(skb, IWL_TM_ATTR_SYNC_RSP,
+                        rsp_data_len, rsp_data_ptr);
+                status = cfg80211_testmode_reply(skb);
+                if (status < 0)
+                        IWL_DEBUG_INFO(priv, "Error sending msg : %d\n",
+                                       status);
+                break;
+        case IWL_TM_CMD_APP2DEV_LOAD_INIT_FW:
+                status = iwlagn_load_ucode_wait_alive(priv, &priv->ucode_init,
+                                           UCODE_SUBTYPE_INIT, -1);
+                if (status)
+                        IWL_DEBUG_INFO(priv,
+                                "Error loading init ucode: %d\n", status);
+                break;
+        case IWL_TM_CMD_APP2DEV_CFG_INIT_CALIB:
+                iwl_testmode_cfg_init_calib(priv);
+                iwlagn_stop_device(priv);
+                break;
+        case IWL_TM_CMD_APP2DEV_LOAD_RUNTIME_FW:
+                status = iwlagn_load_ucode_wait_alive(priv,
+                                           &priv->ucode_rt,
+                                           UCODE_SUBTYPE_REGULAR,
+                                           UCODE_SUBTYPE_REGULAR_NEW);
+                if (status) {
+                        IWL_DEBUG_INFO(priv,
+                                "Error loading runtime ucode: %d\n", status);
+                        break;
+                }
+                status = iwl_alive_start(priv);
+                if (status)
+                        IWL_DEBUG_INFO(priv,
+                                "Error starting the device: %d\n", status);
+                break;
+        default:
+                IWL_DEBUG_INFO(priv, "Unknown testmode driver command ID\n");
+                return -ENOSYS;
+        }
+        return status;
+nla_put_failure:
+        kfree_skb(skb);
+        return -EMSGSIZE;
+}
+/* The testmode gnl message handler that takes the gnl message from the
+ * user space and parses it per the policy iwl_testmode_gnl_msg_policy, then
+ * invoke the corresponding handlers.
+ *
+ * This function is invoked when there is user space application sending
+ * gnl message through the testmode tunnel NL80211_CMD_TESTMODE regulated
+ * by nl80211.
+ *
+ * It retrieves the mandatory field, IWL_TM_ATTR_COMMAND, before
+ * dispatching it to the corresponding handler.
+ *
+ * If IWL_TM_ATTR_COMMAND is missing, -ENOMSG is replied to user application;
+ * -ENOSYS is replied to the user application if the command is unknown;
+ * Otherwise, the command is dispatched to the respective handler.
+ *
+ * @hw: ieee80211_hw object that represents the device
+ * @data: pointer to user space message
+ * @len: length in byte of @data
+ */
+int iwl_testmode_cmd(struct ieee80211_hw *hw, void *data, int len)
+{
+        struct nlattr *tb[IWL_TM_ATTR_MAX - 1];
+        struct iwl_priv *priv = hw->priv;
+        int result;
+        result = nla_parse(tb, IWL_TM_ATTR_MAX - 1, data, len,
+                        iwl_testmode_gnl_msg_policy);
+        if (result != 0) {
+                IWL_DEBUG_INFO(priv,
+                               "Error parsing the gnl message : %d\n", result);
+                return result;
+        }
+        /* IWL_TM_ATTR_COMMAND is absolutely mandatory */
+        if (!tb[IWL_TM_ATTR_COMMAND]) {
+                IWL_DEBUG_INFO(priv, "Error finding testmode command type\n");
+                return -ENOMSG;
+        }
+        /* in case multiple accesses to the device happens */
+        mutex_lock(&priv->mutex);
+        switch (nla_get_u32(tb[IWL_TM_ATTR_COMMAND])) {
+        case IWL_TM_CMD_APP2DEV_UCODE:
+                IWL_DEBUG_INFO(priv, "testmode cmd to uCode\n");
+                result = iwl_testmode_ucode(hw, tb);
+                break;
+        case IWL_TM_CMD_APP2DEV_REG_READ32:
+        case IWL_TM_CMD_APP2DEV_REG_WRITE32:
+        case IWL_TM_CMD_APP2DEV_REG_WRITE8:
+                IWL_DEBUG_INFO(priv, "testmode cmd to register\n");
+                result = iwl_testmode_reg(hw, tb);
+                break;
+        case IWL_TM_CMD_APP2DEV_GET_DEVICENAME:
+        case IWL_TM_CMD_APP2DEV_LOAD_INIT_FW:
+        case IWL_TM_CMD_APP2DEV_CFG_INIT_CALIB:
+        case IWL_TM_CMD_APP2DEV_LOAD_RUNTIME_FW:
+                IWL_DEBUG_INFO(priv, "testmode cmd to driver\n");
+                result = iwl_testmode_driver(hw, tb);
+                break;
+        default:
+                IWL_DEBUG_INFO(priv, "Unknown testmode command\n");
+                result = -ENOSYS;
+                break;
+        }
+        mutex_unlock(&priv->mutex);
+        return result;
+}
diff --git a/drivers/net/wireless/iwlwifi/iwl-testmode.h b/drivers/net/wireless/iwlwifi/iwl-testmode.h
new file mode 100644
index 000000000000..31f8949f2801
--- /dev/null
+++ b/drivers/net/wireless/iwlwifi/iwl-testmode.h
@@ -0,0 +1,151 @@
+/******************************************************************************
+ *
+ * This file is provided under a dual BSD/GPLv2 license.  When using or
+ * redistributing this file, you may do so under either license.
+ *
+ * GPL LICENSE SUMMARY
+ *
+ * Copyright(c) 2010 - 2011 Intel Corporation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110,
+ * USA
+ *
+ * The full GNU General Public License is included in this distribution
+ * in the file called LICENSE.GPL.
+ *
+ * Contact Information:
+ *  Intel Linux Wireless <ilw@linux.intel.com>
+ * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
+ *
+ * BSD LICENSE
+ *
+ * Copyright(c) 2010 - 2011 Intel Corporation. All rights reserved.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ *  * Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ *  * Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in
+ *    the documentation and/or other materials provided with the
+ *    distribution.
+ *  * Neither the name Intel Corporation nor the names of its
+ *    contributors may be used to endorse or promote products derived
+ *    from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ *****************************************************************************/
+#ifndef __IWL_TESTMODE_H__
+#define __IWL_TESTMODE_H__
+#include <linux/types.h>
+/* Commands from user space to kernel space(IWL_TM_CMD_ID_APP2DEV_XX) and
+ * from and kernel space to user space(IWL_TM_CMD_ID_DEV2APP_XX).
+ * The command ID is carried with IWL_TM_ATTR_COMMAND. There are three types of
+ * of command from user space and two types of command from kernel space.
+ * See below.
+ */
+enum iwl_tm_cmd_t {
+        /* commands from user application to the uCode,
+         * the actual uCode host command ID is carried with
+         * IWL_TM_ATTR_UCODE_CMD_ID */
+        IWL_TM_CMD_APP2DEV_UCODE = 1,
+        /* commands from user applicaiton to access register */
+        IWL_TM_CMD_APP2DEV_REG_READ32,
+        IWL_TM_CMD_APP2DEV_REG_WRITE32,
+        IWL_TM_CMD_APP2DEV_REG_WRITE8,
+        /* commands fom user space for pure driver level operations */
+        IWL_TM_CMD_APP2DEV_GET_DEVICENAME,
+        IWL_TM_CMD_APP2DEV_LOAD_INIT_FW,
+        IWL_TM_CMD_APP2DEV_CFG_INIT_CALIB,
+        IWL_TM_CMD_APP2DEV_LOAD_RUNTIME_FW,
+        /* if there is other new command for the driver layer operation,
+         * append them here */
+        /* commands from kernel space to carry the synchronous response
+         * to user application */
+        IWL_TM_CMD_DEV2APP_SYNC_RSP,
+        /* commands from kernel space to multicast the spontaneous messages
+         * to user application */
+        IWL_TM_CMD_DEV2APP_UCODE_RX_PKT,
+        IWL_TM_CMD_MAX,
+};
+enum iwl_tm_attr_t {
+        IWL_TM_ATTR_NOT_APPLICABLE = 0,
+        /* From user space to kernel space:
+         * the command either destines to ucode, driver, or register;
+         * See enum iwl_tm_cmd_t.
+         *
+         * From kernel space to user space:
+         * the command either carries synchronous response,
+         * or the spontaneous message multicast from the device;
+         * See enum iwl_tm_cmd_t. */
+        IWL_TM_ATTR_COMMAND,
+        /* When IWL_TM_ATTR_COMMAND is IWL_TM_CMD_APP2DEV_UCODE,
+         * The mandatory fields are :
+         * IWL_TM_ATTR_UCODE_CMD_ID for recognizable command ID;
+         * IWL_TM_ATTR_COMMAND_FLAG for the flags of the commands;
+         * The optional fields are:
+         * IWL_TM_ATTR_UCODE_CMD_DATA for the actual command payload
+         * to the ucode */
+        IWL_TM_ATTR_UCODE_CMD_ID,
+        IWL_TM_ATTR_UCODE_CMD_DATA,
+        /* When IWL_TM_ATTR_COMMAND is IWL_TM_CMD_APP2DEV_REG_XXX,
+         * The mandatory fields are:
+         * IWL_TM_ATTR_REG_OFFSET for the offset of the target register;
+         * IWL_TM_ATTR_REG_VALUE8 or IWL_TM_ATTR_REG_VALUE32 for value */
+        IWL_TM_ATTR_REG_OFFSET,
+        IWL_TM_ATTR_REG_VALUE8,
+        IWL_TM_ATTR_REG_VALUE32,
+        /* When IWL_TM_ATTR_COMMAND is IWL_TM_CMD_DEV2APP_SYNC_RSP,
+         * The mandatory fields are:
+         * IWL_TM_ATTR_SYNC_RSP for the data content responding to the user
+         * application command */
+        IWL_TM_ATTR_SYNC_RSP,
+        /* When IWL_TM_ATTR_COMMAND is IWL_TM_CMD_DEV2APP_UCODE_RX_PKT,
+         * The mandatory fields are:
+         * IWL_TM_ATTR_UCODE_RX_PKT for the data content multicast to the user
+         * application */
+        IWL_TM_ATTR_UCODE_RX_PKT,
+        IWL_TM_ATTR_MAX,
+};
+#endif
diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c
index 277c9175dcf6..e69597ea43e2 100644
--- a/drivers/net/wireless/iwlwifi/iwl-tx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2003 - 2011 Intel Corporation. All rights reserved.
 *
 * Portions of this file are derived from the ipw3945 project, as well
 * as portions of the ieee80211 subsystem header files.
@@ -149,32 +149,31 @@ void iwl_cmd_queue_unmap(struct iwl_priv *priv)
        struct iwl_tx_queue *txq = &priv->txq[priv->cmd_queue];
        struct iwl_queue *q = &txq->q;
        int i;
-        bool huge = false;
        if (q->n_bd == 0)
                return;
        while (q->read_ptr != q->write_ptr) {
-                /* we have no way to tell if it is a huge cmd ATM */
                i = get_cmd_index(q, q->read_ptr, 0);
-                if (txq->meta[i].flags & CMD_SIZE_HUGE)
+                if (txq->meta[i].flags & CMD_MAPPED) {
-                        huge = true;
-                else
                        pci_unmap_single(priv->pci_dev,
                                         dma_unmap_addr(&txq->meta[i], mapping),
                                         dma_unmap_len(&txq->meta[i], len),
                                         PCI_DMA_BIDIRECTIONAL);
+                        txq->meta[i].flags = 0;
+                }
-             q->read_ptr = iwl_queue_inc_wrap(q->read_ptr, q->n_bd);
+                q->read_ptr = iwl_queue_inc_wrap(q->read_ptr, q->n_bd);
        }
-        if (huge) {
+        i = q->n_window;
-                i = q->n_window;
+        if (txq->meta[i].flags & CMD_MAPPED) {
                pci_unmap_single(priv->pci_dev,
                                 dma_unmap_addr(&txq->meta[i], mapping),
                                 dma_unmap_len(&txq->meta[i], len),
                                 PCI_DMA_BIDIRECTIONAL);
+                txq->meta[i].flags = 0;
        }
 }
@@ -233,7 +232,6 @@ void iwl_cmd_queue_free(struct iwl_priv *priv)
 * reclaiming packets (on 'tx done IRQ), if free space become > high mark,
 * Tx queue resumed.
 *
- * See more detailed info in iwl-4965-hw.h.
 ***************************************************/
 int iwl_queue_space(const struct iwl_queue *q)
@@ -265,11 +263,13 @@ static int iwl_queue_init(struct iwl_priv *priv, struct iwl_queue *q,
        /* count must be power-of-two size, otherwise iwl_queue_inc_wrap
         * and iwl_queue_dec_wrap are broken. */
-        BUG_ON(!is_power_of_2(count));
+        if (WARN_ON(!is_power_of_2(count)))
+                return -EINVAL;
        /* slots_num must be power-of-two size, otherwise
         * get_cmd_index is broken. */
-        BUG_ON(!is_power_of_2(slots_num));
+        if (WARN_ON(!is_power_of_2(slots_num)))
+                return -EINVAL;
        q->low_mark = q->n_window / 4;
        if (q->low_mark < 4)
@@ -386,7 +386,9 @@ int iwl_tx_queue_init(struct iwl_priv *priv, struct iwl_tx_queue *txq,
        BUILD_BUG_ON(TFD_QUEUE_SIZE_MAX & (TFD_QUEUE_SIZE_MAX - 1));
        /* Initialize queue's high/low-water marks, and head/tail indexes */
-        iwl_queue_init(priv, &txq->q, TFD_QUEUE_SIZE_MAX, slots_num, txq_id);
+        ret = iwl_queue_init(priv, &txq->q, TFD_QUEUE_SIZE_MAX, slots_num, txq_id);
+        if (ret)
+                return ret;
        /* Tell device where to find queue */
        priv->cfg->ops->lib->txq_init(priv, txq);
@@ -440,22 +442,25 @@ int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
        struct iwl_cmd_meta *out_meta;
        dma_addr_t phys_addr;
        unsigned long flags;
-        int len;
        u32 idx;
        u16 fix_size;
        bool is_ct_kill = false;
-        cmd->len = priv->cfg->ops->utils->get_hcmd_size(cmd->id, cmd->len);
        fix_size = (u16)(cmd->len + sizeof(out_cmd->hdr));
-        /* If any of the command structures end up being larger than
+        /*
+         * If any of the command structures end up being larger than
         * the TFD_MAX_PAYLOAD_SIZE, and it sent as a 'small' command then
         * we will need to increase the size of the TFD entries
         * Also, check to see if command buffer should not exceed the size
-         * of device_cmd and max_cmd_size. */
+         * of device_cmd and max_cmd_size.
-        BUG_ON((fix_size > TFD_MAX_PAYLOAD_SIZE) &&
+         */
-               !(cmd->flags & CMD_SIZE_HUGE));
+        if (WARN_ON((fix_size > TFD_MAX_PAYLOAD_SIZE) &&
-        BUG_ON(fix_size > IWL_MAX_CMD_SIZE);
+                    !(cmd->flags & CMD_SIZE_HUGE)))
+                return -EINVAL;
+        if (WARN_ON(fix_size > IWL_MAX_CMD_SIZE))
+                return -EINVAL;
        if (iwl_is_rfkill(priv) || iwl_is_ctkill(priv)) {
                IWL_WARN(priv, "Not sending command - %s KILL\n",
@@ -463,35 +468,38 @@ int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
                return -EIO;
        }
+        /*
+         * As we only have a single huge buffer, check that the command
+         * is synchronous (otherwise buffers could end up being reused).
+         */
+        if (WARN_ON((cmd->flags & CMD_ASYNC) && (cmd->flags & CMD_SIZE_HUGE)))
+                return -EINVAL;
+        spin_lock_irqsave(&priv->hcmd_lock, flags);
        if (iwl_queue_space(q) < ((cmd->flags & CMD_ASYNC) ? 2 : 1)) {
+                spin_unlock_irqrestore(&priv->hcmd_lock, flags);
                IWL_ERR(priv, "No space in command queue\n");
-                if (priv->cfg->ops->lib->tt_ops.ct_kill_check) {
+                is_ct_kill = iwl_check_for_ct_kill(priv);
-                        is_ct_kill =
-                                priv->cfg->ops->lib->tt_ops.ct_kill_check(priv);
-                }
                if (!is_ct_kill) {
                        IWL_ERR(priv, "Restarting adapter due to queue full\n");
-                        queue_work(priv->workqueue, &priv->restart);
+                        iwlagn_fw_error(priv, false);
                }
                return -ENOSPC;
        }
-        spin_lock_irqsave(&priv->hcmd_lock, flags);
-        /* If this is a huge cmd, mark the huge flag also on the meta.flags
-         * of the _original_ cmd. This is used for DMA mapping clean up.
-         */
-        if (cmd->flags & CMD_SIZE_HUGE) {
-                idx = get_cmd_index(q, q->write_ptr, 0);
-                txq->meta[idx].flags = CMD_SIZE_HUGE;
-        }
        idx = get_cmd_index(q, q->write_ptr, cmd->flags & CMD_SIZE_HUGE);
        out_cmd = txq->cmd[idx];
        out_meta = &txq->meta[idx];
+        if (WARN_ON(out_meta->flags & CMD_MAPPED)) {
+                spin_unlock_irqrestore(&priv->hcmd_lock, flags);
+                return -ENOSPC;
+        }
        memset(out_meta, 0, sizeof(*out_meta)); /* re-initialize to NULL */
-        out_meta->flags = cmd->flags;
        if (cmd->flags & CMD_WANT_SKB)
                out_meta->source = cmd;
        if (cmd->flags & CMD_ASYNC)
@@ -508,9 +516,6 @@ int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
                        INDEX_TO_SEQ(q->write_ptr));
        if (cmd->flags & CMD_SIZE_HUGE)
                out_cmd->hdr.sequence |= SEQ_HUGE_FRAME;
-        len = sizeof(struct iwl_device_cmd);
-        if (idx == TFD_CMD_SLOTS)
-                len = IWL_MAX_CMD_SIZE;
 #ifdef CONFIG_IWLWIFI_DEBUG
        switch (out_cmd->hdr.cmd) {
@@ -532,17 +537,20 @@ int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
                                q->write_ptr, idx, priv->cmd_queue);
        }
 #endif
-        txq->need_update = 1;
-        if (priv->cfg->ops->lib->txq_update_byte_cnt_tbl)
-                /* Set up entry in queue's byte count circular buffer */
-                priv->cfg->ops->lib->txq_update_byte_cnt_tbl(priv, txq, 0);
        phys_addr = pci_map_single(priv->pci_dev, &out_cmd->hdr,
                                   fix_size, PCI_DMA_BIDIRECTIONAL);
+        if (unlikely(pci_dma_mapping_error(priv->pci_dev, phys_addr))) {
+                idx = -ENOMEM;
+                goto out;
+        }
        dma_unmap_addr_set(out_meta, mapping, phys_addr);
        dma_unmap_len_set(out_meta, len, fix_size);
+        out_meta->flags = cmd->flags | CMD_MAPPED;
+        txq->need_update = 1;
        trace_iwlwifi_dev_hcmd(priv, &out_cmd->hdr, fix_size, cmd->flags);
        priv->cfg->ops->lib->txq_attach_buf_to_tfd(priv, txq,
@@ -553,6 +561,7 @@ int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
        q->write_ptr = iwl_queue_inc_wrap(q->write_ptr, q->n_bd);
        iwl_txq_update_write_ptr(priv, txq);
+ out:
        spin_unlock_irqrestore(&priv->hcmd_lock, flags);
        return idx;
 }
@@ -584,7 +593,7 @@ static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id,
                if (nfreed++ > 0) {
                        IWL_ERR(priv, "HCMD skipped: index (%d) %d %d\n", idx,
                                        q->write_ptr, q->read_ptr);
-                        queue_work(priv->workqueue, &priv->restart);
+                        iwlagn_fw_error(priv, false);
                }
        }
@@ -609,6 +618,7 @@ void iwl_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
        struct iwl_device_cmd *cmd;
        struct iwl_cmd_meta *meta;
        struct iwl_tx_queue *txq = &priv->txq[priv->cmd_queue];
+        unsigned long flags;
        /* If a Tx command is being handled and it isn't in the actual
         * command queue then there a command routing bug has been introduced
@@ -622,14 +632,6 @@ void iwl_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
                return;
        }
-        /* If this is a huge cmd, clear the huge flag on the meta.flags
-         * of the _original_ cmd. So that iwl_cmd_queue_free won't unmap
-         * the DMA buffer for the scan (huge) command.
-         */
-        if (huge) {
-                cmd_index = get_cmd_index(&txq->q, index, 0);
-                txq->meta[cmd_index].flags = 0;
-        }
        cmd_index = get_cmd_index(&txq->q, index, huge);
        cmd = txq->cmd[cmd_index];
        meta = &txq->meta[cmd_index];
@@ -646,6 +648,8 @@ void iwl_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
        } else if (meta->callback)
                meta->callback(priv, cmd, pkt);
+        spin_lock_irqsave(&priv->hcmd_lock, flags);
        iwl_hcmd_queue_reclaim(priv, txq_id, index, cmd_index);
        if (!(meta->flags & CMD_ASYNC)) {
@@ -654,5 +658,9 @@ void iwl_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
                               get_cmd_string(cmd->hdr.cmd));
                wake_up_interruptible(&priv->wait_command_queue);
        }
+        /* Mark as unmapped */
        meta->flags = 0;
+        spin_unlock_irqrestore(&priv->hcmd_lock, flags);
 }
diff --git a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c
index 9a57cf6a488f..5665a1a9b99e 100644
--- a/drivers/net/wireless/iwmc3200wifi/rx.c
+++ b/drivers/net/wireless/iwmc3200wifi/rx.c
@@ -1576,7 +1576,8 @@ static void iwm_rx_process_amsdu(struct iwm_priv *iwm, struct sk_buff *skb)
        IWM_HEXDUMP(iwm, DBG, RX, "A-MSDU: ", skb->data, skb->len);
        __skb_queue_head_init(&list);
-        ieee80211_amsdu_to_8023s(skb, &list, ndev->dev_addr, wdev->iftype, 0);
+        ieee80211_amsdu_to_8023s(skb, &list, ndev->dev_addr, wdev->iftype, 0,
+                                                                        true);
        while ((frame = __skb_dequeue(&list))) {
                ndev->stats.rx_packets++;
diff --git a/drivers/net/wireless/libertas/cfg.c b/drivers/net/wireless/libertas/cfg.c
index 5caa2ac14d61..5d637af2d7c3 100644
--- a/drivers/net/wireless/libertas/cfg.c
+++ b/drivers/net/wireless/libertas/cfg.c
@@ -6,6 +6,8 @@
 *
 */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #include <linux/sched.h>
 #include <linux/wait.h>
 #include <linux/slab.h>
@@ -122,8 +124,10 @@ static u8 lbs_auth_to_authtype(enum nl80211_auth_type auth_type)
 }
-/* Various firmware commands need the list of supported rates, but with
+/*
-   the hight-bit set for basic rates */
+ * Various firmware commands need the list of supported rates, but with
+ * the hight-bit set for basic rates
+ */
 static int lbs_add_rates(u8 *rates)
 {
        size_t i;
@@ -425,7 +429,7 @@ static int lbs_add_wpa_tlv(u8 *tlv, const u8 *ie, u8 ie_len)
        return ie_len + 2;
 }
-/***************************************************************************
+/*
 * Set Channel
 */
@@ -452,7 +456,7 @@ static int lbs_cfg_set_channel(struct wiphy *wiphy,
-/***************************************************************************
+/*
 * Scanning
 */
@@ -538,8 +542,10 @@ static int lbs_ret_scan(struct lbs_private *priv, unsigned long dummy,
                goto done;
        }
-        /* Validity check: the TLV holds TSF values with 8 bytes each, so
+        /*
-         * the size in the TLV must match the nr_sets value */
+         * Validity check: the TLV holds TSF values with 8 bytes each, so
+         * the size in the TLV must match the nr_sets value
+         */
        i = get_unaligned_le16(tsfdesc);
        tsfdesc += 2;
        if (i / 8 != scanresp->nr_sets) {
@@ -581,8 +587,10 @@ static int lbs_ret_scan(struct lbs_private *priv, unsigned long dummy,
                /* To find out the channel, we must parse the IEs */
                ie = pos;
-                /* 6+1+8+2+2: size of BSSID, RSSI, time stamp, beacon
+                /*
-                   interval, capabilities */
+                 * 6+1+8+2+2: size of BSSID, RSSI, time stamp, beacon
+                 * interval, capabilities
+                 */
                ielen = left = len - (6 + 1 + 8 + 2 + 2);
                while (left >= 2) {
                        u8 id, elen;
@@ -790,7 +798,7 @@ static int lbs_cfg_scan(struct wiphy *wiphy,
-/***************************************************************************
+/*
 * Events
 */
@@ -825,7 +833,7 @@ void lbs_send_mic_failureevent(struct lbs_private *priv, u32 event)
-/***************************************************************************
+/*
 * Connect/disconnect
 */
@@ -950,8 +958,10 @@ static int lbs_enable_rsn(struct lbs_private *priv, int enable)
 * Set WPA/WPA key material
 */
-/* like "struct cmd_ds_802_11_key_material", but with cmd_header. Once we
+/*
- * get rid of WEXT, this should go into host.h */
+ * like "struct cmd_ds_802_11_key_material", but with cmd_header. Once we
+ * get rid of WEXT, this should go into host.h
+ */
 struct cmd_key_material {
        struct cmd_header hdr;
@@ -1314,8 +1324,8 @@ static int lbs_cfg_connect(struct wiphy *wiphy, struct net_device *dev,
                sme->ssid, sme->ssid_len,
                WLAN_CAPABILITY_ESS, WLAN_CAPABILITY_ESS);
        if (!bss) {
-                lbs_pr_err("assoc: bss %pM not in scan results\n",
+                wiphy_err(wiphy, "assoc: bss %pM not in scan results\n",
-                           sme->bssid);
+                          sme->bssid);
                ret = -ENOENT;
                goto done;
        }
@@ -1372,8 +1382,8 @@ static int lbs_cfg_connect(struct wiphy *wiphy, struct net_device *dev,
                lbs_enable_rsn(priv, sme->crypto.cipher_group != 0);
                break;
        default:
-                lbs_pr_err("unsupported cipher group 0x%x\n",
+                wiphy_err(wiphy, "unsupported cipher group 0x%x\n",
-                           sme->crypto.cipher_group);
+                          sme->crypto.cipher_group);
                ret = -ENOTSUPP;
                goto done;
        }
@@ -1491,7 +1501,7 @@ static int lbs_cfg_add_key(struct wiphy *wiphy, struct net_device *netdev,
                                     params->key, params->key_len);
                break;
        default:
-                lbs_pr_err("unhandled cipher 0x%x\n", params->cipher);
+                wiphy_err(wiphy, "unhandled cipher 0x%x\n", params->cipher);
                ret = -ENOTSUPP;
                break;
        }
@@ -1536,7 +1546,7 @@ static int lbs_cfg_del_key(struct wiphy *wiphy, struct net_device *netdev,
 }
-/***************************************************************************
+/*
 * Get station
 */
@@ -1581,7 +1591,7 @@ static int lbs_cfg_get_station(struct wiphy *wiphy, struct net_device *dev,
-/***************************************************************************
+/*
 * "Site survey", here just current channel and noise level
 */
@@ -1614,7 +1624,7 @@ static int lbs_get_survey(struct wiphy *wiphy, struct net_device *dev,
-/***************************************************************************
+/*
 * Change interface
 */
@@ -1656,11 +1666,12 @@ static int lbs_change_intf(struct wiphy *wiphy, struct net_device *dev,
-/***************************************************************************
+/*
 * IBSS (Ad-Hoc)
 */
-/* The firmware needs the following bits masked out of the beacon-derived
+/*
+ * The firmware needs the following bits masked out of the beacon-derived
 * capability field when associating/joining to a BSS:
 *  9 (QoS), 11 (APSD), 12 (unused), 14 (unused), 15 (unused)
 */
@@ -1999,7 +2010,7 @@ static int lbs_leave_ibss(struct wiphy *wiphy, struct net_device *dev)
-/***************************************************************************
+/*
 * Initialization
 */
@@ -2118,13 +2129,13 @@ int lbs_cfg_register(struct lbs_private *priv)
        ret = wiphy_register(wdev->wiphy);
        if (ret < 0)
-                lbs_pr_err("cannot register wiphy device\n");
+                pr_err("cannot register wiphy device\n");
        priv->wiphy_registered = true;
        ret = register_netdev(priv->dev);
        if (ret)
-                lbs_pr_err("cannot register network device\n");
+                pr_err("cannot register network device\n");
        INIT_DELAYED_WORK(&priv->scan_work, lbs_scan_worker);
diff --git a/drivers/net/wireless/libertas/cmd.c b/drivers/net/wireless/libertas/cmd.c
index f3ac62431a30..84566db486d2 100644
--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -1,7 +1,7 @@
-/**
+/*
-  * This file contains the handling of command.
+ * This file contains the handling of command.
-  * It prepares command and sends it to firmware when it is ready.
+ * It prepares command and sends it to firmware when it is ready.
-  */
+ */
 #include <linux/kfifo.h>
 #include <linux/sched.h>
@@ -16,14 +16,14 @@
 #define CAL_RSSI(snr, nf)       ((s32)((s32)(snr) + CAL_NF(nf)))
 /**
- *  @brief Simple callback that copies response back into command
+ * lbs_cmd_copyback - Simple callback that copies response back into command
 *
- *  @param priv         A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
- *  @param extra        A pointer to the original command structure for which
+ * @extra:      A pointer to the original command structure for which
- *                      'resp' is a response
+ *              'resp' is a response
- *  @param resp         A pointer to the command response
+ * @resp:       A pointer to the command response
 *
- *  @return             0 on success, error on failure
+ * returns:     0 on success, error on failure
 */
 int lbs_cmd_copyback(struct lbs_private *priv, unsigned long extra,
                     struct cmd_header *resp)
@@ -38,15 +38,15 @@ int lbs_cmd_copyback(struct lbs_private *priv, unsigned long extra,
 EXPORT_SYMBOL_GPL(lbs_cmd_copyback);
 /**
- *  @brief Simple callback that ignores the result. Use this if
+ *  lbs_cmd_async_callback - Simple callback that ignores the result.
- *  you just want to send a command to the hardware, but don't
+ *  Use this if you just want to send a command to the hardware, but don't
 *  care for the result.
 *
- *  @param priv         ignored
+ *  @priv:      ignored
- *  @param extra        ignored
+ *  @extra:     ignored
- *  @param resp         ignored
+ *  @resp:      ignored
 *
- *  @return             0 for success
+ *  returns:    0 for success
 */
 static int lbs_cmd_async_callback(struct lbs_private *priv, unsigned long extra,
                     struct cmd_header *resp)
@@ -56,10 +56,11 @@ static int lbs_cmd_async_callback(struct lbs_private *priv, unsigned long extra,
 /**
- *  @brief Checks whether a command is allowed in Power Save mode
+ *  is_command_allowed_in_ps - tests if a command is allowed in Power Save mode
+ *
+ *  @cmd:       the command ID
 *
- *  @param command the command ID
+ *  returns:    1 if allowed, 0 if not allowed
- *  @return        1 if allowed, 0 if not allowed
 */
 static u8 is_command_allowed_in_ps(u16 cmd)
 {
@@ -75,11 +76,12 @@ static u8 is_command_allowed_in_ps(u16 cmd)
 }
 /**
- *  @brief Updates the hardware details like MAC address and regulatory region
+ *  lbs_update_hw_spec - Updates the hardware details like MAC address
+ *  and regulatory region
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
 *
- *  @return             0 on success, error on failure
+ *  returns:    0 on success, error on failure
 */
 int lbs_update_hw_spec(struct lbs_private *priv)
 {
@@ -108,7 +110,7 @@ int lbs_update_hw_spec(struct lbs_private *priv)
         * CF card    firmware 5.0.16p0:   cap 0x00000303
         * USB dongle firmware 5.110.17p2: cap 0x00000303
         */
-        lbs_pr_info("%pM, fw %u.%u.%up%u, cap 0x%08x\n",
+        netdev_info(priv->dev, "%pM, fw %u.%u.%up%u, cap 0x%08x\n",
                cmd.permanentaddr,
                priv->fwrelease >> 24 & 0xff,
                priv->fwrelease >> 16 & 0xff,
@@ -139,7 +141,8 @@ int lbs_update_hw_spec(struct lbs_private *priv)
        /* if it's unidentified region code, use the default (USA) */
        if (i >= MRVDRV_MAX_REGION_CODE) {
                priv->regioncode = 0x10;
-                lbs_pr_info("unidentified region code; using the default (USA)\n");
+                netdev_info(priv->dev,
+                            "unidentified region code; using the default (USA)\n");
        }
        if (priv->current_addr[0] == 0xff)
@@ -209,7 +212,7 @@ int lbs_host_sleep_cfg(struct lbs_private *priv, uint32_t criteria,
                                        (uint8_t *)&cmd_config.wol_conf,
                                        sizeof(struct wol_config));
        } else {
-                lbs_pr_info("HOST_SLEEP_CFG failed %d\n", ret);
+                netdev_info(priv->dev, "HOST_SLEEP_CFG failed %d\n", ret);
        }
        return ret;
@@ -217,14 +220,14 @@ int lbs_host_sleep_cfg(struct lbs_private *priv, uint32_t criteria,
 EXPORT_SYMBOL_GPL(lbs_host_sleep_cfg);
 /**
- *  @brief Sets the Power Save mode
+ *  lbs_set_ps_mode - Sets the Power Save mode
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
- *  @param cmd_action   The Power Save operation (PS_MODE_ACTION_ENTER_PS or
+ *  @cmd_action: The Power Save operation (PS_MODE_ACTION_ENTER_PS or
 *                         PS_MODE_ACTION_EXIT_PS)
- *  @param block        Whether to block on a response or not
+ *  @block:     Whether to block on a response or not
 *
- *  @return             0 on success, error on failure
+ *  returns:    0 on success, error on failure
 */
 int lbs_set_ps_mode(struct lbs_private *priv, u16 cmd_action, bool block)
 {
@@ -312,7 +315,7 @@ static int lbs_wait_for_ds_awake(struct lbs_private *priv)
        if (priv->is_deep_sleep) {
                if (!wait_event_interruptible_timeout(priv->ds_awake_q,
                                        !priv->is_deep_sleep, (10 * HZ))) {
-                        lbs_pr_err("ds_awake_q: timer expired\n");
+                        netdev_err(priv->dev, "ds_awake_q: timer expired\n");
                        ret = -1;
                }
        }
@@ -337,7 +340,7 @@ int lbs_set_deep_sleep(struct lbs_private *priv, int deep_sleep)
                                netif_carrier_off(priv->dev);
                        }
                } else {
-                        lbs_pr_err("deep sleep: already enabled\n");
+                        netdev_err(priv->dev, "deep sleep: already enabled\n");
                }
        } else {
                if (priv->is_deep_sleep) {
@@ -347,8 +350,8 @@ int lbs_set_deep_sleep(struct lbs_private *priv, int deep_sleep)
                        if (!ret) {
                                ret = lbs_wait_for_ds_awake(priv);
                                if (ret)
-                                        lbs_pr_err("deep sleep: wakeup"
+                                        netdev_err(priv->dev,
-                                                        "failed\n");
+                                                   "deep sleep: wakeup failed\n");
                        }
                }
        }
@@ -382,8 +385,9 @@ int lbs_set_host_sleep(struct lbs_private *priv, int host_sleep)
                        ret = lbs_host_sleep_cfg(priv, priv->wol_criteria,
                                        (struct wol_config *)NULL);
                        if (ret) {
-                                lbs_pr_info("Host sleep configuration failed: "
+                                netdev_info(priv->dev,
-                                                "%d\n", ret);
+                                            "Host sleep configuration failed: %d\n",
+                                            ret);
                                return ret;
                        }
                        if (priv->psstate == PS_STATE_FULL_POWER) {
@@ -393,19 +397,21 @@ int lbs_set_host_sleep(struct lbs_private *priv, int host_sleep)
                                                sizeof(cmd),
                                                lbs_ret_host_sleep_activate, 0);
                                if (ret)
-                                        lbs_pr_info("HOST_SLEEP_ACTIVATE "
+                                        netdev_info(priv->dev,
-                                                        "failed: %d\n", ret);
+                                                    "HOST_SLEEP_ACTIVATE failed: %d\n",
+                                                    ret);
                        }
                        if (!wait_event_interruptible_timeout(
                                                priv->host_sleep_q,
                                                priv->is_host_sleep_activated,
                                                (10 * HZ))) {
-                                lbs_pr_err("host_sleep_q: timer expired\n");
+                                netdev_err(priv->dev,
+                                           "host_sleep_q: timer expired\n");
                                ret = -1;
                        }
                } else {
-                        lbs_pr_err("host sleep: already enabled\n");
+                        netdev_err(priv->dev, "host sleep: already enabled\n");
                }
        } else {
                if (priv->is_host_sleep_activated)
@@ -417,13 +423,13 @@ int lbs_set_host_sleep(struct lbs_private *priv, int host_sleep)
 }
 /**
- *  @brief Set an SNMP MIB value
+ *  lbs_set_snmp_mib - Set an SNMP MIB value
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
- *  @param oid          The OID to set in the firmware
+ *  @oid:       The OID to set in the firmware
- *  @param val          Value to set the OID to
+ *  @val:       Value to set the OID to
 *
- *  @return             0 on success, error on failure
+ *  returns:            0 on success, error on failure
 */
 int lbs_set_snmp_mib(struct lbs_private *priv, u32 oid, u16 val)
 {
@@ -467,13 +473,13 @@ out:
 }
 /**
- *  @brief Get an SNMP MIB value
+ *  lbs_get_snmp_mib - Get an SNMP MIB value
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
- *  @param oid          The OID to retrieve from the firmware
+ *  @oid:       The OID to retrieve from the firmware
- *  @param out_val      Location for the returned value
+ *  @out_val:   Location for the returned value
 *
- *  @return             0 on success, error on failure
+ *  returns:    0 on success, error on failure
 */
 int lbs_get_snmp_mib(struct lbs_private *priv, u32 oid, u16 *out_val)
 {
@@ -510,14 +516,14 @@ out:
 }
 /**
- *  @brief Get the min, max, and current TX power
+ *  lbs_get_tx_power - Get the min, max, and current TX power
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
- *  @param curlevel     Current power level in dBm
+ *  @curlevel:  Current power level in dBm
- *  @param minlevel     Minimum supported power level in dBm (optional)
+ *  @minlevel:  Minimum supported power level in dBm (optional)
- *  @param maxlevel     Maximum supported power level in dBm (optional)
+ *  @maxlevel:  Maximum supported power level in dBm (optional)
 *
- *  @return             0 on success, error on failure
+ *  returns:    0 on success, error on failure
 */
 int lbs_get_tx_power(struct lbs_private *priv, s16 *curlevel, s16 *minlevel,
                     s16 *maxlevel)
@@ -545,12 +551,12 @@ int lbs_get_tx_power(struct lbs_private *priv, s16 *curlevel, s16 *minlevel,
 }
 /**
- *  @brief Set the TX power
+ *  lbs_set_tx_power - Set the TX power
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
- *  @param dbm          The desired power level in dBm
+ *  @dbm:       The desired power level in dBm
 *
- *  @return             0 on success, error on failure
+ *  returns:            0 on success, error on failure
 */
 int lbs_set_tx_power(struct lbs_private *priv, s16 dbm)
 {
@@ -573,12 +579,13 @@ int lbs_set_tx_power(struct lbs_private *priv, s16 dbm)
 }
 /**
- *  @brief Enable or disable monitor mode (only implemented on OLPC usb8388 FW)
+ *  lbs_set_monitor_mode - Enable or disable monitor mode
+ *  (only implemented on OLPC usb8388 FW)
 *
- *  @param priv        A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
- *  @param enable      1 to enable monitor mode, 0 to disable
+ *  @enable:    1 to enable monitor mode, 0 to disable
 *
- *  @return            0 on success, error on failure
+ *  returns:    0 on success, error on failure
 */
 int lbs_set_monitor_mode(struct lbs_private *priv, int enable)
 {
@@ -604,11 +611,11 @@ int lbs_set_monitor_mode(struct lbs_private *priv, int enable)
 }
 /**
- *  @brief Get the radio channel
+ *  lbs_get_channel - Get the radio channel
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
 *
- *  @return             The channel on success, error on failure
+ *  returns:    The channel on success, error on failure
 */
 static int lbs_get_channel(struct lbs_private *priv)
 {
@@ -650,12 +657,12 @@ int lbs_update_channel(struct lbs_private *priv)
 }
 /**
- *  @brief Set the radio channel
+ *  lbs_set_channel - Set the radio channel
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
- *  @param channel      The desired channel, or 0 to clear a locked channel
+ *  @channel:   The desired channel, or 0 to clear a locked channel
 *
- *  @return             0 on success, error on failure
+ *  returns:    0 on success, error on failure
 */
 int lbs_set_channel(struct lbs_private *priv, u8 channel)
 {
@@ -686,12 +693,13 @@ out:
 }
 /**
- *  @brief Get current RSSI and noise floor
+ * lbs_get_rssi - Get current RSSI and noise floor
 *
- *  @param priv         A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
- *  @param rssi         On successful return, signal level in mBm
+ * @rssi:       On successful return, signal level in mBm
+ * @nf:         On successful return, Noise floor
 *
- *  @return             The channel on success, error on failure
+ * returns:     The channel on success, error on failure
 */
 int lbs_get_rssi(struct lbs_private *priv, s8 *rssi, s8 *nf)
 {
@@ -719,13 +727,14 @@ int lbs_get_rssi(struct lbs_private *priv, s8 *rssi, s8 *nf)
 }
 /**
- *  @brief Send regulatory and 802.11d domain information to the firmware
+ *  lbs_set_11d_domain_info - Send regulatory and 802.11d domain information
+ *  to the firmware
 *
- *  @param priv         pointer to struct lbs_private
+ *  @priv:      pointer to &struct lbs_private
- *  @param request      cfg80211 regulatory request structure
+ *  @request:   cfg80211 regulatory request structure
- *  @param bands        the device's supported bands and channels
+ *  @bands:     the device's supported bands and channels
 *
- *  @return             0 on success, error code on failure
+ *  returns:    0 on success, error code on failure
 */
 int lbs_set_11d_domain_info(struct lbs_private *priv,
                            struct regulatory_request *request,
@@ -842,15 +851,15 @@ int lbs_set_11d_domain_info(struct lbs_private *priv,
 }
 /**
- *  @brief Read a MAC, Baseband, or RF register
+ *  lbs_get_reg - Read a MAC, Baseband, or RF register
 *
- *  @param priv         pointer to struct lbs_private
+ *  @priv:      pointer to &struct lbs_private
- *  @param cmd          register command, one of CMD_MAC_REG_ACCESS,
+ *  @reg:       register command, one of CMD_MAC_REG_ACCESS,
- *                        CMD_BBP_REG_ACCESS, or CMD_RF_REG_ACCESS
+ *              CMD_BBP_REG_ACCESS, or CMD_RF_REG_ACCESS
- *  @param offset       byte offset of the register to get
+ *  @offset:    byte offset of the register to get
- *  @param value        on success, the value of the register at 'offset'
+ *  @value:     on success, the value of the register at 'offset'
 *
- *  @return             0 on success, error code on failure
+ *  returns:    0 on success, error code on failure
 */
 int lbs_get_reg(struct lbs_private *priv, u16 reg, u16 offset, u32 *value)
 {
@@ -886,15 +895,15 @@ out:
 }
 /**
- *  @brief Write a MAC, Baseband, or RF register
+ *  lbs_set_reg - Write a MAC, Baseband, or RF register
 *
- *  @param priv         pointer to struct lbs_private
+ *  @priv:      pointer to &struct lbs_private
- *  @param cmd          register command, one of CMD_MAC_REG_ACCESS,
+ *  @reg:       register command, one of CMD_MAC_REG_ACCESS,
- *                        CMD_BBP_REG_ACCESS, or CMD_RF_REG_ACCESS
+ *              CMD_BBP_REG_ACCESS, or CMD_RF_REG_ACCESS
- *  @param offset       byte offset of the register to set
+ *  @offset:    byte offset of the register to set
- *  @param value        the value to write to the register at 'offset'
+ *  @value:     the value to write to the register at 'offset'
 *
- *  @return             0 on success, error code on failure
+ *  returns:    0 on success, error code on failure
 */
 int lbs_set_reg(struct lbs_private *priv, u16 reg, u16 offset, u32 value)
 {
@@ -1002,7 +1011,8 @@ static void lbs_submit_command(struct lbs_private *priv,
        ret = priv->hw_host_to_card(priv, MVMS_CMD, (u8 *) cmd, cmdsize);
        if (ret) {
-                lbs_pr_info("DNLD_CMD: hw_host_to_card failed: %d\n", ret);
+                netdev_info(priv->dev, "DNLD_CMD: hw_host_to_card failed: %d\n",
+                            ret);
                /* Let the timer kick in and retry, and potentially reset
                   the whole thing if the condition persists */
                timeo = HZ/4;
@@ -1023,7 +1033,7 @@ static void lbs_submit_command(struct lbs_private *priv,
        lbs_deb_leave(LBS_DEB_HOST);
 }
-/**
+/*
 *  This function inserts command node to cmdfreeq
 *  after cleans it. Requires priv->driver_lock held.
 */
@@ -1125,11 +1135,12 @@ void lbs_set_mac_control(struct lbs_private *priv)
 }
 /**
- *  @brief This function allocates the command buffer and link
+ *  lbs_allocate_cmd_buffer - allocates the command buffer and links
- *  it to command free queue.
+ *  it to command free queue
+ *
+ *  @priv:      A pointer to &struct lbs_private structure
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  returns:    0 for success or -1 on error
- *  @return             0 or -1
 */
 int lbs_allocate_cmd_buffer(struct lbs_private *priv)
 {
@@ -1171,10 +1182,11 @@ done:
 }
 /**
- *  @brief This function frees the command buffer.
+ *  lbs_free_cmd_buffer - free the command buffer
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
- *  @return             0 or -1
+ *
+ *  returns:    0 for success
 */
 int lbs_free_cmd_buffer(struct lbs_private *priv)
 {
@@ -1211,11 +1223,13 @@ done:
 }
 /**
- *  @brief This function gets a free command node if available in
+ *  lbs_get_free_cmd_node - gets a free command node if available in
- *  command free queue.
+ *  command free queue
+ *
+ *  @priv:      A pointer to &struct lbs_private structure
 *
- *  @param priv         A pointer to struct lbs_private structure
+ *  returns:    A pointer to &cmd_ctrl_node structure on success
- *  @return cmd_ctrl_node A pointer to cmd_ctrl_node structure or NULL
+ *              or %NULL on error
 */
 static struct cmd_ctrl_node *lbs_get_free_cmd_node(struct lbs_private *priv)
 {
@@ -1245,12 +1259,12 @@ static struct cmd_ctrl_node *lbs_get_free_cmd_node(struct lbs_private *priv)
 }
 /**
- *  @brief This function executes next command in command
+ *  lbs_execute_next_command - execute next command in command
- *  pending queue. It will put firmware back to PS mode
+ *  pending queue. Will put firmware back to PS mode if applicable.
- *  if applicable.
 *
- *  @param priv     A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
- *  @return        0 or -1
+ *
+ *  returns:    0 on success or -1 on error
 */
 int lbs_execute_next_command(struct lbs_private *priv)
 {
@@ -1267,7 +1281,8 @@ int lbs_execute_next_command(struct lbs_private *priv)
        spin_lock_irqsave(&priv->driver_lock, flags);
        if (priv->cur_cmd) {
-                lbs_pr_alert( "EXEC_NEXT_CMD: already processing command!\n");
+                netdev_alert(priv->dev,
+                             "EXEC_NEXT_CMD: already processing command!\n");
                spin_unlock_irqrestore(&priv->driver_lock, flags);
                ret = -1;
                goto done;
@@ -1431,7 +1446,7 @@ static void lbs_send_confirmsleep(struct lbs_private *priv)
        ret = priv->hw_host_to_card(priv, MVMS_CMD, (u8 *) &confirm_sleep,
                sizeof(confirm_sleep));
        if (ret) {
-                lbs_pr_alert("confirm_sleep failed\n");
+                netdev_alert(priv->dev, "confirm_sleep failed\n");
                goto out;
        }
@@ -1456,12 +1471,12 @@ out:
 }
 /**
- *  @brief This function checks condition and prepares to
+ * lbs_ps_confirm_sleep - checks condition and prepares to
- *  send sleep confirm command to firmware if ok.
+ * send sleep confirm command to firmware if ok
+ *
+ * @priv:       A pointer to &struct lbs_private structure
 *
- *  @param priv         A pointer to struct lbs_private structure
+ * returns:     n/a
- *  @param psmode       Power Saving mode
- *  @return             n/a
 */
 void lbs_ps_confirm_sleep(struct lbs_private *priv)
 {
@@ -1501,16 +1516,16 @@ void lbs_ps_confirm_sleep(struct lbs_private *priv)
 /**
- * @brief Configures the transmission power control functionality.
+ * lbs_set_tpc_cfg - Configures the transmission power control functionality
 *
- * @param priv          A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
- * @param enable        Transmission power control enable
+ * @enable:     Transmission power control enable
- * @param p0            Power level when link quality is good (dBm).
+ * @p0:         Power level when link quality is good (dBm).
- * @param p1            Power level when link quality is fair (dBm).
+ * @p1:         Power level when link quality is fair (dBm).
- * @param p2            Power level when link quality is poor (dBm).
+ * @p2:         Power level when link quality is poor (dBm).
- * @param usesnr        Use Signal to Noise Ratio in TPC
+ * @usesnr:     Use Signal to Noise Ratio in TPC
 *
- * @return 0 on success
+ * returns:     0 on success
 */
 int lbs_set_tpc_cfg(struct lbs_private *priv, int enable, int8_t p0, int8_t p1,
                int8_t p2, int usesnr)
@@ -1533,15 +1548,15 @@ int lbs_set_tpc_cfg(struct lbs_private *priv, int enable, int8_t p0, int8_t p1,
 }
 /**
- * @brief Configures the power adaptation settings.
+ * lbs_set_power_adapt_cfg - Configures the power adaptation settings
 *
- * @param priv          A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
- * @param enable        Power adaptation enable
+ * @enable:     Power adaptation enable
- * @param p0            Power level for 1, 2, 5.5 and 11 Mbps (dBm).
+ * @p0:         Power level for 1, 2, 5.5 and 11 Mbps (dBm).
- * @param p1            Power level for 6, 9, 12, 18, 22, 24 and 36 Mbps (dBm).
+ * @p1:         Power level for 6, 9, 12, 18, 22, 24 and 36 Mbps (dBm).
- * @param p2            Power level for 48 and 54 Mbps (dBm).
+ * @p2:         Power level for 48 and 54 Mbps (dBm).
 *
- * @return 0 on Success
+ * returns:     0 on Success
 */
 int lbs_set_power_adapt_cfg(struct lbs_private *priv, int enable, int8_t p0,
@@ -1657,7 +1672,7 @@ int __lbs_cmd(struct lbs_private *priv, uint16_t command,
        spin_lock_irqsave(&priv->driver_lock, flags);
        ret = cmdnode->result;
        if (ret)
-                lbs_pr_info("PREP_CMD: command 0x%04x failed: %d\n",
+                netdev_info(priv->dev, "PREP_CMD: command 0x%04x failed: %d\n",
                            command, ret);
        __lbs_cleanup_and_insert_cmd(priv, cmdnode);
diff --git a/drivers/net/wireless/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
index 5e95da9dcc2e..207fc361db84 100644
--- a/drivers/net/wireless/libertas/cmdresp.c
+++ b/drivers/net/wireless/libertas/cmdresp.c
@@ -1,7 +1,8 @@
-/**
+/*
-  * This file contains the handling of command
+ * This file contains the handling of command
-  * responses as well as events generated by firmware.
+ * responses as well as events generated by firmware.
-  */
+ */
 #include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/sched.h>
@@ -12,12 +13,13 @@
 #include "cmd.h"
 /**
- *  @brief This function handles disconnect event. it
+ * lbs_mac_event_disconnected - handles disconnect event. It
- *  reports disconnect to upper layer, clean tx/rx packets,
+ * reports disconnect to upper layer, clean tx/rx packets,
- *  reset link state etc.
+ * reset link state etc.
+ *
+ * @priv:       A pointer to struct lbs_private structure
 *
- *  @param priv    A pointer to struct lbs_private structure
+ * returns:     n/a
- *  @return        n/a
 */
 void lbs_mac_event_disconnected(struct lbs_private *priv)
 {
@@ -84,15 +86,18 @@ int lbs_process_command_response(struct lbs_private *priv, u8 *data, u32 len)
        lbs_deb_hex(LBS_DEB_CMD, "CMD_RESP", (void *) resp, len);
        if (resp->seqnum != priv->cur_cmd->cmdbuf->seqnum) {
-                lbs_pr_info("Received CMD_RESP with invalid sequence %d (expected %d)\n",
+                netdev_info(priv->dev,
-                            le16_to_cpu(resp->seqnum), le16_to_cpu(priv->cur_cmd->cmdbuf->seqnum));
+                            "Received CMD_RESP with invalid sequence %d (expected %d)\n",
+                            le16_to_cpu(resp->seqnum),
+                            le16_to_cpu(priv->cur_cmd->cmdbuf->seqnum));
                spin_unlock_irqrestore(&priv->driver_lock, flags);
                ret = -1;
                goto done;
        }
        if (respcmd != CMD_RET(curcmd) &&
            respcmd != CMD_RET_802_11_ASSOCIATE && curcmd != CMD_802_11_ASSOCIATE) {
-                lbs_pr_info("Invalid CMD_RESP %x to command %x!\n", respcmd, curcmd);
+                netdev_info(priv->dev, "Invalid CMD_RESP %x to command %x!\n",
+                            respcmd, curcmd);
                spin_unlock_irqrestore(&priv->driver_lock, flags);
                ret = -1;
                goto done;
@@ -101,7 +106,8 @@ int lbs_process_command_response(struct lbs_private *priv, u8 *data, u32 len)
        if (resp->result == cpu_to_le16(0x0004)) {
                /* 0x0004 means -EAGAIN. Drop the response, let it time out
                   and be resubmitted */
-                lbs_pr_info("Firmware returns DEFER to command %x. Will let it time out...\n",
+                netdev_info(priv->dev,
+                            "Firmware returns DEFER to command %x. Will let it time out...\n",
                            le16_to_cpu(resp->command));
                spin_unlock_irqrestore(&priv->driver_lock, flags);
                ret = -1;
@@ -313,28 +319,28 @@ int lbs_process_event(struct lbs_private *priv, u32 event)
                lbs_deb_cmd("EVENT: ADHOC beacon lost\n");
                break;
        case MACREG_INT_CODE_RSSI_LOW:
-                lbs_pr_alert("EVENT: rssi low\n");
+                netdev_alert(priv->dev, "EVENT: rssi low\n");
                break;
        case MACREG_INT_CODE_SNR_LOW:
-                lbs_pr_alert("EVENT: snr low\n");
+                netdev_alert(priv->dev, "EVENT: snr low\n");
                break;
        case MACREG_INT_CODE_MAX_FAIL:
-                lbs_pr_alert("EVENT: max fail\n");
+                netdev_alert(priv->dev, "EVENT: max fail\n");
                break;
        case MACREG_INT_CODE_RSSI_HIGH:
-                lbs_pr_alert("EVENT: rssi high\n");
+                netdev_alert(priv->dev, "EVENT: rssi high\n");
                break;
        case MACREG_INT_CODE_SNR_HIGH:
-                lbs_pr_alert("EVENT: snr high\n");
+                netdev_alert(priv->dev, "EVENT: snr high\n");
                break;
        case MACREG_INT_CODE_MESH_AUTO_STARTED:
                /* Ignore spurious autostart events */
-                lbs_pr_info("EVENT: MESH_AUTO_STARTED (ignoring)\n");
+                netdev_info(priv->dev, "EVENT: MESH_AUTO_STARTED (ignoring)\n");
                break;
        default:
-                lbs_pr_alert("EVENT: unknown event id %d\n", event);
+                netdev_alert(priv->dev, "EVENT: unknown event id %d\n", event);
                break;
        }
diff --git a/drivers/net/wireless/libertas/debugfs.c b/drivers/net/wireless/libertas/debugfs.c
index fbf3b0332bb7..23250f621761 100644
--- a/drivers/net/wireless/libertas/debugfs.c
+++ b/drivers/net/wireless/libertas/debugfs.c
@@ -151,13 +151,14 @@ static ssize_t lbs_host_sleep_write(struct file *file,
                ret = lbs_set_host_sleep(priv, 0);
        else if (host_sleep == 1) {
                if (priv->wol_criteria == EHS_REMOVE_WAKEUP) {
-                        lbs_pr_info("wake parameters not configured");
+                        netdev_info(priv->dev,
+                                    "wake parameters not configured\n");
                        ret = -EINVAL;
                        goto out_unlock;
                }
                ret = lbs_set_host_sleep(priv, 1);
        } else {
-                lbs_pr_err("invalid option\n");
+                netdev_err(priv->dev, "invalid option\n");
                ret = -EINVAL;
        }
@@ -849,15 +850,14 @@ static struct debug_data items[] = {
 static int num_of_items = ARRAY_SIZE(items);
 /**
- *  @brief proc read function
+ * lbs_debugfs_read - proc read function
 *
- *  @param page    pointer to buffer
+ * @file:       file to read
- *  @param s       read data starting position
+ * @userbuf:    pointer to buffer
- *  @param off     offset
+ * @count:      number of bytes to read
- *  @param cnt     counter
+ * @ppos:       read data starting position
- *  @param eof     end of file flag
+ *
- *  @param data    data to output
+ * returns:     amount of data read or negative error code
- *  @return        number of output data
 */
 static ssize_t lbs_debugfs_read(struct file *file, char __user *userbuf,
                        size_t count, loff_t *ppos)
@@ -897,13 +897,14 @@ static ssize_t lbs_debugfs_read(struct file *file, char __user *userbuf,
 }
 /**
- *  @brief proc write function
+ * lbs_debugfs_write - proc write function
+ *
+ * @f:          file pointer
+ * @buf:        pointer to data buffer
+ * @cnt:        data number to write
+ * @ppos:       file position
 *
- *  @param f       file pointer
+ * returns:     amount of data written
- *  @param buf     pointer to data buffer
- *  @param cnt     data number to write
- *  @param data    data to write
- *  @return        number of data
 */
 static ssize_t lbs_debugfs_write(struct file *f, const char __user *buf,
                            size_t cnt, loff_t *ppos)
@@ -966,11 +967,11 @@ static const struct file_operations lbs_debug_fops = {
 };
 /**
- *  @brief create debug proc file
+ * lbs_debug_init - create debug proc file
+ *
+ * @priv:       pointer to &struct lbs_private
 *
- *  @param priv    pointer struct lbs_private
+ * returns:     N/A
- *  @param dev     pointer net_device
- *  @return        N/A
 */
 static void lbs_debug_init(struct lbs_private *priv)
 {
diff --git a/drivers/net/wireless/libertas/decl.h b/drivers/net/wireless/libertas/decl.h
index 2ae752d10065..da0b05bb89fe 100644
--- a/drivers/net/wireless/libertas/decl.h
+++ b/drivers/net/wireless/libertas/decl.h
@@ -1,8 +1,8 @@
-/**
+/*
-  *  This file contains declaration referring to
+ *  This file contains declaration referring to
-  *  functions defined in other source files
+ *  functions defined in other source files
-  */
+ */
 #ifndef _LBS_DECL_H_
 #define _LBS_DECL_H_
diff --git a/drivers/net/wireless/libertas/defs.h b/drivers/net/wireless/libertas/defs.h
index d00c728cec47..ab966f08024a 100644
--- a/drivers/net/wireless/libertas/defs.h
+++ b/drivers/net/wireless/libertas/defs.h
@@ -1,7 +1,7 @@
-/**
+/*
-  * This header file contains global constant/enum definitions,
+ * This header file contains global constant/enum definitions,
-  * global variable declaration.
+ * global variable declaration.
-  */
+ */
 #ifndef _LBS_DEFS_H_
 #define _LBS_DEFS_H_
@@ -89,13 +89,6 @@ do { if ((lbs_debug & (grp)) == (grp)) \
 #define lbs_deb_spi(fmt, args...)       LBS_DEB_LL(LBS_DEB_SPI, " spi", fmt, ##args)
 #define lbs_deb_cfg80211(fmt, args...)  LBS_DEB_LL(LBS_DEB_CFG80211, " cfg80211", fmt, ##args)
-#define lbs_pr_info(format, args...) \
-        printk(KERN_INFO DRV_NAME": " format, ## args)
-#define lbs_pr_err(format, args...) \
-        printk(KERN_ERR DRV_NAME": " format, ## args)
-#define lbs_pr_alert(format, args...) \
-        printk(KERN_ALERT DRV_NAME": " format, ## args)
 #ifdef DEBUG
 static inline void lbs_deb_hex(unsigned int grp, const char *prompt, u8 *buf, int len)
 {
@@ -123,19 +116,19 @@ static inline void lbs_deb_hex(unsigned int grp, const char *prompt, u8 *buf, in
-/** Buffer Constants */
+/* Buffer Constants */
 /*      The size of SQ memory PPA, DPA are 8 DWORDs, that keep the physical
-*       addresses of TxPD buffers. Station has only 8 TxPD available, Whereas
+ *      addresses of TxPD buffers. Station has only 8 TxPD available, Whereas
-*       driver has more local TxPDs. Each TxPD on the host memory is associated
+ *      driver has more local TxPDs. Each TxPD on the host memory is associated
-*       with a Tx control node. The driver maintains 8 RxPD descriptors for
+ *      with a Tx control node. The driver maintains 8 RxPD descriptors for
-*       station firmware to store Rx packet information.
+ *      station firmware to store Rx packet information.
-*
+ *
-*       Current version of MAC has a 32x6 multicast address buffer.
+ *      Current version of MAC has a 32x6 multicast address buffer.
-*
+ *
-*       802.11b can have up to  14 channels, the driver keeps the
+ *      802.11b can have up to  14 channels, the driver keeps the
-*       BSSID(MAC address) of each APs or Ad hoc stations it has sensed.
+ *      BSSID(MAC address) of each APs or Ad hoc stations it has sensed.
-*/
+ */
 #define MRVDRV_MAX_MULTICAST_LIST_SIZE  32
 #define LBS_NUM_CMD_BUFFERS             10
@@ -166,7 +159,7 @@ static inline void lbs_deb_hex(unsigned int grp, const char *prompt, u8 *buf, in
 #define WOL_RESULT_NOSPC_ERR            1
 #define WOL_RESULT_EEXIST_ERR           2
-/** Misc constants */
+/* Misc constants */
 /* This section defines 802.11 specific contants */
 #define MRVDRV_MAX_BSS_DESCRIPTS                16
@@ -183,7 +176,8 @@ static inline void lbs_deb_hex(unsigned int grp, const char *prompt, u8 *buf, in
 #define MARVELL_MESH_IE_LENGTH          9
-/* Values used to populate the struct mrvl_mesh_ie.  The only time you need this
+/*
+ * Values used to populate the struct mrvl_mesh_ie.  The only time you need this
 * is when enabling the mesh using CMD_MESH_CONFIG.
 */
 #define MARVELL_MESH_IE_TYPE            4
@@ -193,7 +187,7 @@ static inline void lbs_deb_hex(unsigned int grp, const char *prompt, u8 *buf, in
 #define MARVELL_MESH_METRIC_ID          0
 #define MARVELL_MESH_CAPABILITY         0
-/** INT status Bit Definition*/
+/* INT status Bit Definition */
 #define MRVDRV_TX_DNLD_RDY              0x0001
 #define MRVDRV_RX_UPLD_RDY              0x0002
 #define MRVDRV_CMD_DNLD_RDY             0x0004
@@ -208,59 +202,63 @@ static inline void lbs_deb_hex(unsigned int grp, const char *prompt, u8 *buf, in
 #define TPC_DEFAULT_P1 10
 #define TPC_DEFAULT_P2 13
-/** TxPD status */
+/* TxPD status */
-/*      Station firmware use TxPD status field to report final Tx transmit
+/*
-*       result, Bit masks are used to present combined situations.
+ *      Station firmware use TxPD status field to report final Tx transmit
-*/
+ *      result, Bit masks are used to present combined situations.
+ */
 #define MRVDRV_TxPD_POWER_MGMT_NULL_PACKET 0x01
 #define MRVDRV_TxPD_POWER_MGMT_LAST_PACKET 0x08
-/** Tx mesh flag */
+/* Tx mesh flag */
-/* Currently we are using normal WDS flag as mesh flag.
+/*
+ * Currently we are using normal WDS flag as mesh flag.
 * TODO: change to proper mesh flag when MAC understands it.
 */
 #define TxPD_CONTROL_WDS_FRAME (1<<17)
 #define TxPD_MESH_FRAME TxPD_CONTROL_WDS_FRAME
-/** Mesh interface ID */
+/* Mesh interface ID */
 #define MESH_IFACE_ID                                   0x0001
-/** Mesh id should be in bits 14-13-12 */
+/* Mesh id should be in bits 14-13-12 */
 #define MESH_IFACE_BIT_OFFSET                           0x000c
-/** Mesh enable bit in FW capability */
+/* Mesh enable bit in FW capability */
 #define MESH_CAPINFO_ENABLE_MASK                        (1<<16)
-/** FW definition from Marvell v4 */
+/* FW definition from Marvell v4 */
 #define MRVL_FW_V4                                      (0x04)
-/** FW definition from Marvell v5 */
+/* FW definition from Marvell v5 */
 #define MRVL_FW_V5                                      (0x05)
-/** FW definition from Marvell v10 */
+/* FW definition from Marvell v10 */
 #define MRVL_FW_V10                                     (0x0a)
-/** FW major revision definition */
+/* FW major revision definition */
 #define MRVL_FW_MAJOR_REV(x)                            ((x)>>24)
-/** RxPD status */
+/* RxPD status */
 #define MRVDRV_RXPD_STATUS_OK                0x0001
-/** RxPD status - Received packet types */
+/* RxPD status - Received packet types */
-/** Rx mesh flag */
+/* Rx mesh flag */
-/* Currently we are using normal WDS flag as mesh flag.
+/*
+ * Currently we are using normal WDS flag as mesh flag.
 * TODO: change to proper mesh flag when MAC understands it.
 */
 #define RxPD_CONTROL_WDS_FRAME (0x40)
 #define RxPD_MESH_FRAME RxPD_CONTROL_WDS_FRAME
-/** RSSI-related defines */
+/* RSSI-related defines */
-/*      RSSI constants are used to implement 802.11 RSSI threshold
+/*
-*       indication. if the Rx packet signal got too weak for 5 consecutive
+ *      RSSI constants are used to implement 802.11 RSSI threshold
-*       times, miniport driver (driver) will report this event to wrapper
+ *      indication. if the Rx packet signal got too weak for 5 consecutive
-*/
+ *      times, miniport driver (driver) will report this event to wrapper
+ */
 #define MRVDRV_NF_DEFAULT_SCAN_VALUE            (-96)
-/** RTS/FRAG related defines */
+/* RTS/FRAG related defines */
 #define MRVDRV_RTS_MIN_VALUE            0
 #define MRVDRV_RTS_MAX_VALUE            2347
 #define MRVDRV_FRAG_MIN_VALUE           256
@@ -300,36 +298,36 @@ static inline void lbs_deb_hex(unsigned int grp, const char *prompt, u8 *buf, in
 #define MAX_LEDS                        8
-/** Global Variable Declaration */
+/* Global Variable Declaration */
 extern const char lbs_driver_version[];
 extern u16 lbs_region_code_to_index[MRVDRV_MAX_REGION_CODE];
-/** ENUM definition*/
+/* ENUM definition */
-/** SNRNF_TYPE */
+/* SNRNF_TYPE */
 enum SNRNF_TYPE {
        TYPE_BEACON = 0,
        TYPE_RXPD,
        MAX_TYPE_B
 };
-/** SNRNF_DATA*/
+/* SNRNF_DATA */
 enum SNRNF_DATA {
        TYPE_NOAVG = 0,
        TYPE_AVG,
        MAX_TYPE_AVG
 };
-/** LBS_802_11_POWER_MODE */
+/* LBS_802_11_POWER_MODE */
 enum LBS_802_11_POWER_MODE {
        LBS802_11POWERMODECAM,
        LBS802_11POWERMODEMAX_PSP,
        LBS802_11POWERMODEFAST_PSP,
-        /*not a real mode, defined as an upper bound */
+        /* not a real mode, defined as an upper bound */
        LBS802_11POWEMODEMAX
 };
-/** PS_STATE */
+/* PS_STATE */
 enum PS_STATE {
        PS_STATE_FULL_POWER,
        PS_STATE_AWAKE,
@@ -337,7 +335,7 @@ enum PS_STATE {
        PS_STATE_SLEEP
 };
-/** DNLD_STATE */
+/* DNLD_STATE */
 enum DNLD_STATE {
        DNLD_RES_RECEIVED,
        DNLD_DATA_SENT,
@@ -345,19 +343,19 @@ enum DNLD_STATE {
        DNLD_BOOTCMD_SENT,
 };
-/** LBS_MEDIA_STATE */
+/* LBS_MEDIA_STATE */
 enum LBS_MEDIA_STATE {
        LBS_CONNECTED,
        LBS_DISCONNECTED
 };
-/** LBS_802_11_PRIVACY_FILTER */
+/* LBS_802_11_PRIVACY_FILTER */
 enum LBS_802_11_PRIVACY_FILTER {
        LBS802_11PRIVFILTERACCEPTALL,
        LBS802_11PRIVFILTER8021XWEP
 };
-/** mv_ms_type */
+/* mv_ms_type */
 enum mv_ms_type {
        MVMS_DAT = 0,
        MVMS_CMD = 1,
@@ -365,14 +363,14 @@ enum mv_ms_type {
        MVMS_EVENT
 };
-/** KEY_TYPE_ID */
+/* KEY_TYPE_ID */
 enum KEY_TYPE_ID {
        KEY_TYPE_ID_WEP = 0,
        KEY_TYPE_ID_TKIP,
        KEY_TYPE_ID_AES
 };
-/** KEY_INFO_WPA (applies to both TKIP and AES/CCMP) */
+/* KEY_INFO_WPA (applies to both TKIP and AES/CCMP) */
 enum KEY_INFO_WPA {
        KEY_INFO_WPA_MCAST = 0x01,
        KEY_INFO_WPA_UNICAST = 0x02,
diff --git a/drivers/net/wireless/libertas/dev.h b/drivers/net/wireless/libertas/dev.h
index bc461eb39660..76d018beebf4 100644
--- a/drivers/net/wireless/libertas/dev.h
+++ b/drivers/net/wireless/libertas/dev.h
@@ -1,8 +1,8 @@
-/**
+/*
-  * This file contains definitions and data structures specific
+ * This file contains definitions and data structures specific
-  * to Marvell 802.11 NIC. It contains the Device Information
+ * to Marvell 802.11 NIC. It contains the Device Information
-  * structure struct lbs_private..
+ * structure struct lbs_private..
-  */
+ */
 #ifndef _LBS_DEV_H_
 #define _LBS_DEV_H_
@@ -12,7 +12,7 @@
 #include <linux/kfifo.h>
-/** sleep_params */
+/* sleep_params */
 struct sleep_params {
        uint16_t sp_error;
        uint16_t sp_offset;
@@ -23,7 +23,7 @@ struct sleep_params {
 };
-/** Private structure for the MV device */
+/* Private structure for the MV device */
 struct lbs_private {
        /* Basic networking */
@@ -125,12 +125,12 @@ struct lbs_private {
        /* Events sent from hardware to driver */
        struct kfifo event_fifo;
-        /** thread to service interrupts */
+        /* thread to service interrupts */
        struct task_struct *main_thread;
        wait_queue_head_t waitq;
        struct workqueue_struct *work_thread;
-        /** Encryption stuff */
+        /* Encryption stuff */
        u8 authtype_auto;
        u8 wep_tx_key;
        u8 wep_key[4][WLAN_KEY_LEN_WEP104];
@@ -162,7 +162,7 @@ struct lbs_private {
        s16 txpower_min;
        s16 txpower_max;
-        /** Scanning */
+        /* Scanning */
        struct delayed_work scan_work;
        int scan_channel;
        /* Queue of things waiting for scan completion */
diff --git a/drivers/net/wireless/libertas/ethtool.c b/drivers/net/wireless/libertas/ethtool.c
index 50193aac679e..29dbce4a9f86 100644
--- a/drivers/net/wireless/libertas/ethtool.c
+++ b/drivers/net/wireless/libertas/ethtool.c
@@ -20,7 +20,8 @@ static void lbs_ethtool_get_drvinfo(struct net_device *dev,
        strcpy(info->version, lbs_driver_version);
 }
-/* All 8388 parts have 16KiB EEPROM size at the time of writing.
+/*
+ * All 8388 parts have 16KiB EEPROM size at the time of writing.
 * In case that changes this needs fixing.
 */
 #define LBS_EEPROM_LEN 16384
diff --git a/drivers/net/wireless/libertas/host.h b/drivers/net/wireless/libertas/host.h
index 6cb6935ee4a3..2e2dbfa2ee50 100644
--- a/drivers/net/wireless/libertas/host.h
+++ b/drivers/net/wireless/libertas/host.h
@@ -1,7 +1,7 @@
-/**
+/*
-  * This file function prototypes, data structure
+ * This file function prototypes, data structure
-  * and  definitions for all the host/station commands
+ * and  definitions for all the host/station commands
-  */
+ */
 #ifndef _LBS_HOST_H_
 #define _LBS_HOST_H_
@@ -13,9 +13,10 @@
 #define CMD_OPTION_WAITFORRSP                   0x0002
-/** Host command IDs */
+/* Host command IDs */
-/* Return command are almost always the same as the host command, but with
+/*
+ * Return command are almost always the same as the host command, but with
 * bit 15 set high.  There are a few exceptions, though...
 */
 #define CMD_RET(cmd)                            (0x8000 | cmd)
@@ -251,7 +252,7 @@ enum cmd_mesh_config_types {
        CMD_TYPE_MESH_GET_MESH_IE, /* GET_DEFAULTS is superset of GET_MESHIE */
 };
-/** Card Event definition */
+/* Card Event definition */
 #define MACREG_INT_CODE_TX_PPA_FREE             0
 #define MACREG_INT_CODE_TX_DMA_DONE             1
 #define MACREG_INT_CODE_LINK_LOST_W_SCAN        2
@@ -624,12 +625,14 @@ struct cmd_ds_802_11_rf_channel {
 struct cmd_ds_802_11_rssi {
        struct cmd_header hdr;
-        /* request:  number of beacons (N) to average the SNR and NF over
+        /*
+         * request:  number of beacons (N) to average the SNR and NF over
         * response: SNR of most recent beacon
         */
        __le16 n_or_snr;
-        /* The following fields are only set in the response.
+        /*
+         * The following fields are only set in the response.
         * In the request these are reserved and should be set to 0.
         */
        __le16 nf;       /* most recent beacon noise floor */
@@ -680,14 +683,16 @@ struct cmd_ds_802_11_ps_mode {
        __le16 action;
-        /* Interval for keepalive in PS mode:
+        /*
+         * Interval for keepalive in PS mode:
         * 0x0000 = don't change
         * 0x001E = firmware default
         * 0xFFFF = disable
         */
        __le16 nullpktinterval;
-        /* Number of DTIM intervals to wake up for:
+        /*
+         * Number of DTIM intervals to wake up for:
         * 0 = don't change
         * 1 = firmware default
         * 5 = max
@@ -697,7 +702,8 @@ struct cmd_ds_802_11_ps_mode {
        __le16 reserved;
        __le16 locallisteninterval;
-        /* AdHoc awake period (FW v9+ only):
+        /*
+         * AdHoc awake period (FW v9+ only):
         * 0 = don't change
         * 1 = always awake (IEEE standard behavior)
         * 2 - 31 = sleep for (n - 1) periods and awake for 1 period
@@ -771,7 +777,8 @@ struct adhoc_bssdesc {
        __le16 capability;
        u8 rates[MAX_RATES];
-        /* DO NOT ADD ANY FIELDS TO THIS STRUCTURE. It is used below in the
+        /*
+         * DO NOT ADD ANY FIELDS TO THIS STRUCTURE. It is used below in the
         * Adhoc join command and will cause a binary layout mismatch with
         * the firmware
         */
diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
index 8712cb213f2f..63ed5798365c 100644
--- a/drivers/net/wireless/libertas/if_cs.c
+++ b/drivers/net/wireless/libertas/if_cs.c
@@ -21,6 +21,8 @@
 */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
@@ -312,7 +314,8 @@ static int if_cs_poll_while_fw_download(struct if_cs_card *card, uint addr, u8 r
 #define CF8385_MANFID           0x02df
 #define CF8385_CARDID           0x8103
-/* FIXME: just use the 'driver_info' field of 'struct pcmcia_device_id' when
+/*
+ * FIXME: just use the 'driver_info' field of 'struct pcmcia_device_id' when
 * that gets fixed.  Currently there's no way to access it from the probe hook.
 */
 static inline u32 get_model(u16 manf_id, u16 card_id)
@@ -361,7 +364,7 @@ static int if_cs_send_cmd(struct lbs_private *priv, u8 *buf, u16 nb)
                if (status & IF_CS_BIT_COMMAND)
                        break;
                if (++loops > 100) {
-                        lbs_pr_err("card not ready for commands\n");
+                        netdev_err(priv->dev, "card not ready for commands\n");
                        goto done;
                }
                mdelay(1);
@@ -431,14 +434,16 @@ static int if_cs_receive_cmdres(struct lbs_private *priv, u8 *data, u32 *len)
        /* is hardware ready? */
        status = if_cs_read16(priv->card, IF_CS_CARD_STATUS);
        if ((status & IF_CS_BIT_RESP) == 0) {
-                lbs_pr_err("no cmd response in card\n");
+                netdev_err(priv->dev, "no cmd response in card\n");
                *len = 0;
                goto out;
        }
        *len = if_cs_read16(priv->card, IF_CS_RESP_LEN);
        if ((*len == 0) || (*len > LBS_CMD_BUFFER_SIZE)) {
-                lbs_pr_err("card cmd buffer has invalid # of bytes (%d)\n", *len);
+                netdev_err(priv->dev,
+                           "card cmd buffer has invalid # of bytes (%d)\n",
+                           *len);
                goto out;
        }
@@ -472,7 +477,9 @@ static struct sk_buff *if_cs_receive_data(struct lbs_private *priv)
        len = if_cs_read16(priv->card, IF_CS_READ_LEN);
        if (len == 0 || len > MRVDRV_ETH_RX_PACKET_BUFFER_SIZE) {
-                lbs_pr_err("card data buffer has invalid # of bytes (%d)\n", len);
+                netdev_err(priv->dev,
+                           "card data buffer has invalid # of bytes (%d)\n",
+                           len);
                priv->dev->stats.rx_dropped++;
                goto dat_err;
        }
@@ -621,8 +628,10 @@ static int if_cs_prog_helper(struct if_cs_card *card, const struct firmware *fw)
                if (remain < count)
                        count = remain;
-                /* "write the number of bytes to be sent to the I/O Command
+                /*
-                 * write length register" */
+                 * "write the number of bytes to be sent to the I/O Command
+                 * write length register"
+                 */
                if_cs_write16(card, IF_CS_CMD_LEN, count);
                /* "write this to I/O Command port register as 16 bit writes */
@@ -631,21 +640,27 @@ static int if_cs_prog_helper(struct if_cs_card *card, const struct firmware *fw)
                                &fw->data[sent],
                                count >> 1);
-                /* "Assert the download over interrupt command in the Host
+                /*
-                 * status register" */
+                 * "Assert the download over interrupt command in the Host
+                 * status register"
+                 */
                if_cs_write8(card, IF_CS_HOST_STATUS, IF_CS_BIT_COMMAND);
-                /* "Assert the download over interrupt command in the Card
+                /*
-                 * interrupt case register" */
+                 * "Assert the download over interrupt command in the Card
+                 * interrupt case register"
+                 */
                if_cs_write16(card, IF_CS_HOST_INT_CAUSE, IF_CS_BIT_COMMAND);
-                /* "The host polls the Card Status register ... for 50 ms before
+                /*
-                   declaring a failure */
+                 * "The host polls the Card Status register ... for 50 ms before
+                 * declaring a failure"
+                 */
                ret = if_cs_poll_while_fw_download(card, IF_CS_CARD_STATUS,
                        IF_CS_BIT_COMMAND);
                if (ret < 0) {
-                        lbs_pr_err("can't download helper at 0x%x, ret %d\n",
+                        pr_err("can't download helper at 0x%x, ret %d\n",
-                                sent, ret);
+                               sent, ret);
                        goto done;
                }
@@ -675,7 +690,7 @@ static int if_cs_prog_real(struct if_cs_card *card, const struct firmware *fw)
        ret = if_cs_poll_while_fw_download(card, IF_CS_SQ_READ_LOW,
                IF_CS_SQ_HELPER_OK);
        if (ret < 0) {
-                lbs_pr_err("helper firmware doesn't answer\n");
+                pr_err("helper firmware doesn't answer\n");
                goto done;
        }
@@ -683,13 +698,13 @@ static int if_cs_prog_real(struct if_cs_card *card, const struct firmware *fw)
                len = if_cs_read16(card, IF_CS_SQ_READ_LOW);
                if (len & 1) {
                        retry++;
-                        lbs_pr_info("odd, need to retry this firmware block\n");
+                        pr_info("odd, need to retry this firmware block\n");
                } else {
                        retry = 0;
                }
                if (retry > 20) {
-                        lbs_pr_err("could not download firmware\n");
+                        pr_err("could not download firmware\n");
                        ret = -ENODEV;
                        goto done;
                }
@@ -709,14 +724,14 @@ static int if_cs_prog_real(struct if_cs_card *card, const struct firmware *fw)
                ret = if_cs_poll_while_fw_download(card, IF_CS_CARD_STATUS,
                        IF_CS_BIT_COMMAND);
                if (ret < 0) {
-                        lbs_pr_err("can't download firmware at 0x%x\n", sent);
+                        pr_err("can't download firmware at 0x%x\n", sent);
                        goto done;
                }
        }
        ret = if_cs_poll_while_fw_download(card, IF_CS_SCRATCH, 0x5a);
        if (ret < 0)
-                lbs_pr_err("firmware download failed\n");
+                pr_err("firmware download failed\n");
 done:
        lbs_deb_leave_args(LBS_DEB_CS, "ret %d", ret);
@@ -750,7 +765,8 @@ static int if_cs_host_to_card(struct lbs_private *priv,
                ret = if_cs_send_cmd(priv, buf, nb);
                break;
        default:
-                lbs_pr_err("%s: unsupported type %d\n", __func__, type);
+                netdev_err(priv->dev, "%s: unsupported type %d\n",
+                           __func__, type);
        }
        lbs_deb_leave_args(LBS_DEB_CS, "ret %d", ret);
@@ -779,7 +795,7 @@ static int if_cs_ioprobe(struct pcmcia_device *p_dev, void *priv_data)
        p_dev->resource[0]->flags |= IO_DATA_PATH_WIDTH_AUTO;
        if (p_dev->resource[1]->end) {
-                lbs_pr_err("wrong CIS (check number of IO windows)\n");
+                pr_err("wrong CIS (check number of IO windows)\n");
                return -ENODEV;
        }
@@ -800,7 +816,7 @@ static int if_cs_probe(struct pcmcia_device *p_dev)
        card = kzalloc(sizeof(struct if_cs_card), GFP_KERNEL);
        if (!card) {
-                lbs_pr_err("error in kzalloc\n");
+                pr_err("error in kzalloc\n");
                goto out;
        }
        card->p_dev = p_dev;
@@ -809,7 +825,7 @@ static int if_cs_probe(struct pcmcia_device *p_dev)
        p_dev->config_flags |= CONF_ENABLE_IRQ | CONF_AUTO_SET_IO;
        if (pcmcia_loop_config(p_dev, if_cs_ioprobe, NULL)) {
-                lbs_pr_err("error in pcmcia_loop_config\n");
+                pr_err("error in pcmcia_loop_config\n");
                goto out1;
        }
@@ -825,14 +841,14 @@ static int if_cs_probe(struct pcmcia_device *p_dev)
        card->iobase = ioport_map(p_dev->resource[0]->start,
                                resource_size(p_dev->resource[0]));
        if (!card->iobase) {
-                lbs_pr_err("error in ioport_map\n");
+                pr_err("error in ioport_map\n");
                ret = -EIO;
                goto out1;
        }
        ret = pcmcia_enable_device(p_dev);
        if (ret) {
-                lbs_pr_err("error in pcmcia_enable_device\n");
+                pr_err("error in pcmcia_enable_device\n");
                goto out2;
        }
@@ -841,14 +857,14 @@ static int if_cs_probe(struct pcmcia_device *p_dev)
        /*
         * Most of the libertas cards can do unaligned register access, but some
-         * weird ones can not. That's especially true for the CF8305 card.
+         * weird ones cannot. That's especially true for the CF8305 card.
         */
        card->align_regs = 0;
        card->model = get_model(p_dev->manf_id, p_dev->card_id);
        if (card->model == MODEL_UNKNOWN) {
-                lbs_pr_err("unsupported manf_id 0x%04x / card_id 0x%04x\n",
+                pr_err("unsupported manf_id 0x%04x / card_id 0x%04x\n",
-                           p_dev->manf_id, p_dev->card_id);
+                       p_dev->manf_id, p_dev->card_id);
                goto out2;
        }
@@ -857,20 +873,20 @@ static int if_cs_probe(struct pcmcia_device *p_dev)
        if (card->model == MODEL_8305) {
                card->align_regs = 1;
                if (prod_id < IF_CS_CF8305_B1_REV) {
-                        lbs_pr_err("8305 rev B0 and older are not supported\n");
+                        pr_err("8305 rev B0 and older are not supported\n");
                        ret = -ENODEV;
                        goto out2;
                }
        }
        if ((card->model == MODEL_8381) && prod_id < IF_CS_CF8381_B3_REV) {
-                lbs_pr_err("8381 rev B2 and older are not supported\n");
+                pr_err("8381 rev B2 and older are not supported\n");
                ret = -ENODEV;
                goto out2;
        }
        if ((card->model == MODEL_8385) && prod_id < IF_CS_CF8385_B1_REV) {
-                lbs_pr_err("8385 rev B0 and older are not supported\n");
+                pr_err("8385 rev B0 and older are not supported\n");
                ret = -ENODEV;
                goto out2;
        }
@@ -878,7 +894,7 @@ static int if_cs_probe(struct pcmcia_device *p_dev)
        ret = lbs_get_firmware(&p_dev->dev, NULL, NULL, card->model,
                                &fw_table[0], &helper, &mainfw);
        if (ret) {
-                lbs_pr_err("failed to find firmware (%d)\n", ret);
+                pr_err("failed to find firmware (%d)\n", ret);
                goto out2;
        }
@@ -909,18 +925,20 @@ static int if_cs_probe(struct pcmcia_device *p_dev)
        ret = request_irq(p_dev->irq, if_cs_interrupt,
                IRQF_SHARED, DRV_NAME, card);
        if (ret) {
-                lbs_pr_err("error in request_irq\n");
+                pr_err("error in request_irq\n");
                goto out3;
        }
-        /* Clear any interrupt cause that happened while sending
+        /*
-         * firmware/initializing card */
+         * Clear any interrupt cause that happened while sending
+         * firmware/initializing card
+         */
        if_cs_write16(card, IF_CS_CARD_INT_CAUSE, IF_CS_BIT_MASK);
        if_cs_enable_ints(card);
        /* And finally bring the card up */
        if (lbs_start_card(priv) != 0) {
-                lbs_pr_err("could not activate card\n");
+                pr_err("could not activate card\n");
                goto out3;
        }
diff --git a/drivers/net/wireless/libertas/if_sdio.c b/drivers/net/wireless/libertas/if_sdio.c
index b4de0ca10feb..a7b5cb0c2753 100644
--- a/drivers/net/wireless/libertas/if_sdio.c
+++ b/drivers/net/wireless/libertas/if_sdio.c
@@ -26,6 +26,8 @@
 * if_sdio_card_to_host() to pad the data.
 */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #include <linux/kernel.h>
 #include <linux/moduleparam.h>
 #include <linux/slab.h>
@@ -409,7 +411,7 @@ static int if_sdio_card_to_host(struct if_sdio_card *card)
 out:
        if (ret)
-                lbs_pr_err("problem fetching packet from firmware\n");
+                pr_err("problem fetching packet from firmware\n");
        lbs_deb_leave_args(LBS_DEB_SDIO, "ret %d", ret);
@@ -446,7 +448,7 @@ static void if_sdio_host_to_card_worker(struct work_struct *work)
                }
                if (ret)
-                        lbs_pr_err("error %d sending packet to firmware\n", ret);
+                        pr_err("error %d sending packet to firmware\n", ret);
                sdio_release_host(card->func);
@@ -555,7 +557,7 @@ release:
 out:
        if (ret)
-                lbs_pr_err("failed to load helper firmware\n");
+                pr_err("failed to load helper firmware\n");
        lbs_deb_leave_args(LBS_DEB_SDIO, "ret %d", ret);
        return ret;
@@ -669,7 +671,7 @@ release:
 out:
        if (ret)
-                lbs_pr_err("failed to load firmware\n");
+                pr_err("failed to load firmware\n");
        lbs_deb_leave_args(LBS_DEB_SDIO, "ret %d", ret);
        return ret;
@@ -723,7 +725,7 @@ static int if_sdio_prog_firmware(struct if_sdio_card *card)
        ret = lbs_get_firmware(&card->func->dev, lbs_helper_name, lbs_fw_name,
                                card->model, &fw_table[0], &helper, &mainfw);
        if (ret) {
-                lbs_pr_err("failed to find firmware (%d)\n", ret);
+                pr_err("failed to find firmware (%d)\n", ret);
                goto out;
        }
@@ -849,7 +851,7 @@ static int if_sdio_enter_deep_sleep(struct lbs_private *priv)
        ret = __lbs_cmd(priv, CMD_802_11_DEEP_SLEEP, &cmd, sizeof(cmd),
                        lbs_cmd_copyback, (unsigned long) &cmd);
        if (ret)
-                lbs_pr_err("DEEP_SLEEP cmd failed\n");
+                netdev_err(priv->dev, "DEEP_SLEEP cmd failed\n");
        mdelay(200);
        return ret;
@@ -865,7 +867,7 @@ static int if_sdio_exit_deep_sleep(struct lbs_private *priv)
        sdio_writeb(card->func, HOST_POWER_UP, CONFIGURATION_REG, &ret);
        if (ret)
-                lbs_pr_err("sdio_writeb failed!\n");
+                netdev_err(priv->dev, "sdio_writeb failed!\n");
        sdio_release_host(card->func);
        lbs_deb_leave_args(LBS_DEB_SDIO, "ret %d", ret);
@@ -882,7 +884,7 @@ static int if_sdio_reset_deep_sleep_wakeup(struct lbs_private *priv)
        sdio_writeb(card->func, 0, CONFIGURATION_REG, &ret);
        if (ret)
-                lbs_pr_err("sdio_writeb failed!\n");
+                netdev_err(priv->dev, "sdio_writeb failed!\n");
        sdio_release_host(card->func);
        lbs_deb_leave_args(LBS_DEB_SDIO, "ret %d", ret);
@@ -961,7 +963,7 @@ static int if_sdio_probe(struct sdio_func *func,
        }
        if (i == func->card->num_info) {
-                lbs_pr_err("unable to identify card model\n");
+                pr_err("unable to identify card model\n");
                return -ENODEV;
        }
@@ -995,7 +997,7 @@ static int if_sdio_probe(struct sdio_func *func,
                        break;
        }
        if (i == ARRAY_SIZE(fw_table)) {
-                lbs_pr_err("unknown card model 0x%x\n", card->model);
+                pr_err("unknown card model 0x%x\n", card->model);
                ret = -ENODEV;
                goto free;
        }
@@ -1101,7 +1103,7 @@ static int if_sdio_probe(struct sdio_func *func,
                lbs_deb_sdio("send function INIT command\n");
                if (__lbs_cmd(priv, CMD_FUNC_INIT, &cmd, sizeof(cmd),
                                lbs_cmd_copyback, (unsigned long) &cmd))
-                        lbs_pr_alert("CMD_FUNC_INIT cmd failed\n");
+                        netdev_alert(priv->dev, "CMD_FUNC_INIT cmd failed\n");
        }
        ret = lbs_start_card(priv);
@@ -1163,7 +1165,7 @@ static void if_sdio_remove(struct sdio_func *func)
                if (__lbs_cmd(card->priv, CMD_FUNC_SHUTDOWN,
                                &cmd, sizeof(cmd), lbs_cmd_copyback,
                                (unsigned long) &cmd))
-                        lbs_pr_alert("CMD_FUNC_SHUTDOWN cmd failed\n");
+                        pr_alert("CMD_FUNC_SHUTDOWN cmd failed\n");
        }
@@ -1202,20 +1204,19 @@ static int if_sdio_suspend(struct device *dev)
        mmc_pm_flag_t flags = sdio_get_host_pm_caps(func);
-        lbs_pr_info("%s: suspend: PM flags = 0x%x\n",
+        dev_info(dev, "%s: suspend: PM flags = 0x%x\n",
-                                                sdio_func_id(func), flags);
+                 sdio_func_id(func), flags);
        /* If we aren't being asked to wake on anything, we should bail out
         * and let the SD stack power down the card.
         */
        if (card->priv->wol_criteria == EHS_REMOVE_WAKEUP) {
-                lbs_pr_info("Suspend without wake params -- "
+                dev_info(dev, "Suspend without wake params -- powering down card\n");
-                                                "powering down card.");
                return -ENOSYS;
        }
        if (!(flags & MMC_PM_KEEP_POWER)) {
-                lbs_pr_err("%s: cannot remain alive while host is suspended\n",
+                dev_err(dev, "%s: cannot remain alive while host is suspended\n",
                        sdio_func_id(func));
                return -ENOSYS;
        }
@@ -1237,7 +1238,7 @@ static int if_sdio_resume(struct device *dev)
        struct if_sdio_card *card = sdio_get_drvdata(func);
        int ret;
-        lbs_pr_info("%s: resume: we're back\n", sdio_func_id(func));
+        dev_info(dev, "%s: resume: we're back\n", sdio_func_id(func));
        ret = lbs_resume(card->priv);
diff --git a/drivers/net/wireless/libertas/if_spi.c b/drivers/net/wireless/libertas/if_spi.c
index f6c2cd665f49..463352c890d7 100644
--- a/drivers/net/wireless/libertas/if_spi.c
+++ b/drivers/net/wireless/libertas/if_spi.c
@@ -17,6 +17,8 @@
 * (at your option) any later version.
 */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #include <linux/moduleparam.h>
 #include <linux/firmware.h>
 #include <linux/jiffies.h>
@@ -57,6 +59,7 @@ struct if_spi_card {
        /* Handles all SPI communication (except for FW load) */
        struct workqueue_struct         *workqueue;
        struct work_struct              packet_work;
+        struct work_struct              resume_work;
        u8                              cmd_buffer[IF_SPI_CMD_BUF_SIZE];
@@ -68,6 +71,9 @@ struct if_spi_card {
        /* Protects cmd_packet_list and data_packet_list */
        spinlock_t                      buffer_lock;
+        /* True is card suspended */
+        u8                              suspended;
 };
 static void free_if_spi_card(struct if_spi_card *card)
@@ -139,8 +145,10 @@ static void spu_transaction_finish(struct if_spi_card *card)
        card->prev_xfer_time = jiffies;
 }
-/* Write out a byte buffer to an SPI register,
+/*
- * using a series of 16-bit transfers. */
+ * Write out a byte buffer to an SPI register,
+ * using a series of 16-bit transfers.
+ */
 static int spu_write(struct if_spi_card *card, u16 reg, const u8 *buf, int len)
 {
        int err = 0;
@@ -204,8 +212,10 @@ static int spu_read(struct if_spi_card *card, u16 reg, u8 *buf, int len)
        struct spi_transfer dummy_trans;
        struct spi_transfer data_trans;
-        /* You must take an even number of bytes from the SPU, even if you
+        /*
-         * don't care about the last one.  */
+         * You must take an even number of bytes from the SPU, even if you
+         * don't care about the last one.
+         */
        BUG_ON(len & 0x1);
        spu_transaction_init(card);
@@ -254,8 +264,10 @@ static inline int spu_read_u16(struct if_spi_card *card, u16 reg, u16 *val)
        return ret;
 }
-/* Read 32 bits from an SPI register.
+/*
- * The low 16 bits are read first. */
+ * Read 32 bits from an SPI register.
+ * The low 16 bits are read first.
+ */
 static int spu_read_u32(struct if_spi_card *card, u16 reg, u32 *val)
 {
        __le32 buf;
@@ -267,13 +279,15 @@ static int spu_read_u32(struct if_spi_card *card, u16 reg, u32 *val)
        return err;
 }
-/* Keep reading 16 bits from an SPI register until you get the correct result.
+/*
+ * Keep reading 16 bits from an SPI register until you get the correct result.
 *
 * If mask = 0, the correct result is any non-zero number.
 * If mask != 0, the correct result is any number where
 * number & target_mask == target
 *
- * Returns -ETIMEDOUT if a second passes without the correct result. */
+ * Returns -ETIMEDOUT if a second passes without the correct result.
+ */
 static int spu_wait_for_u16(struct if_spi_card *card, u16 reg,
                        u16 target_mask, u16 target)
 {
@@ -293,16 +307,17 @@ static int spu_wait_for_u16(struct if_spi_card *card, u16 reg,
                }
                udelay(100);
                if (time_after(jiffies, timeout)) {
-                        lbs_pr_err("%s: timeout with val=%02x, "
+                        pr_err("%s: timeout with val=%02x, target_mask=%02x, target=%02x\n",
-                               "target_mask=%02x, target=%02x\n",
                               __func__, val, target_mask, target);
                        return -ETIMEDOUT;
                }
        }
 }
-/* Read 16 bits from an SPI register until you receive a specific value.
+/*
- * Returns -ETIMEDOUT if a 4 tries pass without success. */
+ * Read 16 bits from an SPI register until you receive a specific value.
+ * Returns -ETIMEDOUT if a 4 tries pass without success.
+ */
 static int spu_wait_for_u32(struct if_spi_card *card, u32 reg, u32 target)
 {
        int err, try;
@@ -324,8 +339,10 @@ static int spu_set_interrupt_mode(struct if_spi_card *card,
 {
        int err = 0;
-        /* We can suppress a host interrupt by clearing the appropriate
+        /*
-         * bit in the "host interrupt status mask" register */
+         * We can suppress a host interrupt by clearing the appropriate
+         * bit in the "host interrupt status mask" register
+         */
        if (suppress_host_int) {
                err = spu_write_u16(card, IF_SPI_HOST_INT_STATUS_MASK_REG, 0);
                if (err)
@@ -341,10 +358,12 @@ static int spu_set_interrupt_mode(struct if_spi_card *card,
                        return err;
        }
-        /* If auto-interrupts are on, the completion of certain transactions
+        /*
+         * If auto-interrupts are on, the completion of certain transactions
         * will trigger an interrupt automatically. If auto-interrupts
         * are off, we need to set the "Card Interrupt Cause" register to
-         * trigger a card interrupt. */
+         * trigger a card interrupt.
+         */
        if (auto_int) {
                err = spu_write_u16(card, IF_SPI_HOST_INT_CTRL_REG,
                                IF_SPI_HICT_TX_DOWNLOAD_OVER_AUTO |
@@ -387,7 +406,7 @@ static int spu_set_bus_mode(struct if_spi_card *card, u16 mode)
        if (err)
                return err;
        if ((rval & 0xF) != mode) {
-                lbs_pr_err("Can't read bus mode register.\n");
+                pr_err("Can't read bus mode register\n");
                return -EIO;
        }
        return 0;
@@ -398,8 +417,10 @@ static int spu_init(struct if_spi_card *card, int use_dummy_writes)
        int err = 0;
        u32 delay;
-        /* We have to start up in timed delay mode so that we can safely
+        /*
-         * read the Delay Read Register. */
+         * We have to start up in timed delay mode so that we can safely
+         * read the Delay Read Register.
+         */
        card->use_dummy_writes = 0;
        err = spu_set_bus_mode(card,
                                IF_SPI_BUS_MODE_SPI_CLOCK_PHASE_RISING |
@@ -455,8 +476,10 @@ static int if_spi_prog_helper_firmware(struct if_spi_card *card,
        /* Load helper firmware image */
        while (bytes_remaining > 0) {
-                /* Scratch pad 1 should contain the number of bytes we
+                /*
-                 * want to download to the firmware */
+                 * Scratch pad 1 should contain the number of bytes we
+                 * want to download to the firmware
+                 */
                err = spu_write_u16(card, IF_SPI_SCRATCH_1_REG,
                                        HELPER_FW_LOAD_CHUNK_SZ);
                if (err)
@@ -468,8 +491,10 @@ static int if_spi_prog_helper_firmware(struct if_spi_card *card,
                if (err)
                        goto out;
-                /* Feed the data into the command read/write port reg
+                /*
-                 * in chunks of 64 bytes */
+                 * Feed the data into the command read/write port reg
+                 * in chunks of 64 bytes
+                 */
                memset(temp, 0, sizeof(temp));
                memcpy(temp, fw,
                       min(bytes_remaining, HELPER_FW_LOAD_CHUNK_SZ));
@@ -491,9 +516,11 @@ static int if_spi_prog_helper_firmware(struct if_spi_card *card,
                fw += HELPER_FW_LOAD_CHUNK_SZ;
        }
-        /* Once the helper / single stage firmware download is complete,
+        /*
+         * Once the helper / single stage firmware download is complete,
         * write 0 to scratch pad 1 and interrupt the
-         * bootloader. This completes the helper download. */
+         * bootloader. This completes the helper download.
+         */
        err = spu_write_u16(card, IF_SPI_SCRATCH_1_REG, FIRMWARE_DNLD_OK);
        if (err)
                goto out;
@@ -508,26 +535,30 @@ static int if_spi_prog_helper_firmware(struct if_spi_card *card,
 out:
        if (err)
-                lbs_pr_err("failed to load helper firmware (err=%d)\n", err);
+                pr_err("failed to load helper firmware (err=%d)\n", err);
        lbs_deb_leave_args(LBS_DEB_SPI, "err %d", err);
        return err;
 }
-/* Returns the length of the next packet the firmware expects us to send
+/*
- * Sets crc_err if the previous transfer had a CRC error. */
+ * Returns the length of the next packet the firmware expects us to send.
+ * Sets crc_err if the previous transfer had a CRC error.
+ */
 static int if_spi_prog_main_firmware_check_len(struct if_spi_card *card,
                                                int *crc_err)
 {
        u16 len;
        int err = 0;
-        /* wait until the host interrupt status register indicates
+        /*
-         * that we are ready to download */
+         * wait until the host interrupt status register indicates
+         * that we are ready to download
+         */
        err = spu_wait_for_u16(card, IF_SPI_HOST_INT_STATUS_REG,
                                IF_SPI_HIST_CMD_DOWNLOAD_RDY,
                                IF_SPI_HIST_CMD_DOWNLOAD_RDY);
        if (err) {
-                lbs_pr_err("timed out waiting for host_int_status\n");
+                pr_err("timed out waiting for host_int_status\n");
                return err;
        }
@@ -537,9 +568,8 @@ static int if_spi_prog_main_firmware_check_len(struct if_spi_card *card,
                return err;
        if (len > IF_SPI_CMD_BUF_SIZE) {
-                lbs_pr_err("firmware load device requested a larger "
+                pr_err("firmware load device requested a larger transfer than we are prepared to handle (len = %d)\n",
-                           "tranfer than we are prepared to "
+                       len);
-                           "handle. (len = %d)\n", len);
                return -EIO;
        }
        if (len & 0x1) {
@@ -555,6 +585,7 @@ static int if_spi_prog_main_firmware_check_len(struct if_spi_card *card,
 static int if_spi_prog_main_firmware(struct if_spi_card *card,
                                        const struct firmware *firmware)
 {
+        struct lbs_private *priv = card->priv;
        int len, prev_len;
        int bytes, crc_err = 0, err = 0;
        const u8 *fw;
@@ -568,8 +599,9 @@ static int if_spi_prog_main_firmware(struct if_spi_card *card,
        err = spu_wait_for_u16(card, IF_SPI_SCRATCH_1_REG, 0, 0);
        if (err) {
-                lbs_pr_err("%s: timed out waiting for initial "
+                netdev_err(priv->dev,
-                           "scratch reg = 0\n", __func__);
+                           "%s: timed out waiting for initial scratch reg = 0\n",
+                           __func__);
                goto out;
        }
@@ -583,17 +615,18 @@ static int if_spi_prog_main_firmware(struct if_spi_card *card,
                        goto out;
                }
                if (bytes < 0) {
-                        /* If there are no more bytes left, we would normally
+                        /*
-                         * expect to have terminated with len = 0 */
+                         * If there are no more bytes left, we would normally
-                        lbs_pr_err("Firmware load wants more bytes "
+                         * expect to have terminated with len = 0
-                                   "than we have to offer.\n");
+                         */
+                        netdev_err(priv->dev,
+                                   "Firmware load wants more bytes than we have to offer.\n");
                        break;
                }
                if (crc_err) {
                        /* Previous transfer failed. */
                        if (++num_crc_errs > MAX_MAIN_FW_LOAD_CRC_ERR) {
-                                lbs_pr_err("Too many CRC errors encountered "
+                                pr_err("Too many CRC errors encountered in firmware load.\n");
-                                           "in firmware load.\n");
                                err = -EIO;
                                goto out;
                        }
@@ -622,21 +655,20 @@ static int if_spi_prog_main_firmware(struct if_spi_card *card,
                prev_len = len;
        }
        if (bytes > prev_len) {
-                lbs_pr_err("firmware load wants fewer bytes than "
+                pr_err("firmware load wants fewer bytes than we have to offer\n");
-                           "we have to offer.\n");
        }
        /* Confirm firmware download */
        err = spu_wait_for_u32(card, IF_SPI_SCRATCH_4_REG,
                                        SUCCESSFUL_FW_DOWNLOAD_MAGIC);
        if (err) {
-                lbs_pr_err("failed to confirm the firmware download\n");
+                pr_err("failed to confirm the firmware download\n");
                goto out;
        }
 out:
        if (err)
-                lbs_pr_err("failed to load firmware (err=%d)\n", err);
+                pr_err("failed to load firmware (err=%d)\n", err);
        lbs_deb_leave_args(LBS_DEB_SPI, "err %d", err);
        return err;
 }
@@ -656,14 +688,18 @@ static int if_spi_c2h_cmd(struct if_spi_card *card)
        u16 len;
        u8 i;
-        /* We need a buffer big enough to handle whatever people send to
+        /*
-         * hw_host_to_card */
+         * We need a buffer big enough to handle whatever people send to
+         * hw_host_to_card
+         */
        BUILD_BUG_ON(IF_SPI_CMD_BUF_SIZE < LBS_CMD_BUFFER_SIZE);
        BUILD_BUG_ON(IF_SPI_CMD_BUF_SIZE < LBS_UPLD_SIZE);
-        /* It's just annoying if the buffer size isn't a multiple of 4, because
+        /*
-         * then we might have len <  IF_SPI_CMD_BUF_SIZE but
+         * It's just annoying if the buffer size isn't a multiple of 4, because
-         * ALIGN(len, 4) > IF_SPI_CMD_BUF_SIZE */
+         * then we might have len < IF_SPI_CMD_BUF_SIZE but
+         * ALIGN(len, 4) > IF_SPI_CMD_BUF_SIZE
+         */
        BUILD_BUG_ON(IF_SPI_CMD_BUF_SIZE % 4 != 0);
        lbs_deb_enter(LBS_DEB_SPI);
@@ -673,13 +709,13 @@ static int if_spi_c2h_cmd(struct if_spi_card *card)
        if (err)
                goto out;
        if (!len) {
-                lbs_pr_err("%s: error: card has no data for host\n",
+                netdev_err(priv->dev, "%s: error: card has no data for host\n",
                           __func__);
                err = -EINVAL;
                goto out;
        } else if (len > IF_SPI_CMD_BUF_SIZE) {
-                lbs_pr_err("%s: error: response packet too large: "
+                netdev_err(priv->dev,
-                           "%d bytes, but maximum is %d\n",
+                           "%s: error: response packet too large: %d bytes, but maximum is %d\n",
                           __func__, len, IF_SPI_CMD_BUF_SIZE);
                err = -EINVAL;
                goto out;
@@ -701,7 +737,7 @@ static int if_spi_c2h_cmd(struct if_spi_card *card)
 out:
        if (err)
-                lbs_pr_err("%s: err=%d\n", __func__, err);
+                netdev_err(priv->dev, "%s: err=%d\n", __func__, err);
        lbs_deb_leave(LBS_DEB_SPI);
        return err;
 }
@@ -709,6 +745,7 @@ out:
 /* Move data from the card to the host */
 static int if_spi_c2h_data(struct if_spi_card *card)
 {
+        struct lbs_private *priv = card->priv;
        struct sk_buff *skb;
        char *data;
        u16 len;
@@ -721,13 +758,13 @@ static int if_spi_c2h_data(struct if_spi_card *card)
        if (err)
                goto out;
        if (!len) {
-                lbs_pr_err("%s: error: card has no data for host\n",
+                netdev_err(priv->dev, "%s: error: card has no data for host\n",
                           __func__);
                err = -EINVAL;
                goto out;
        } else if (len > MRVDRV_ETH_RX_PACKET_BUFFER_SIZE) {
-                lbs_pr_err("%s: error: card has %d bytes of data, but "
+                netdev_err(priv->dev,
-                           "our maximum skb size is %zu\n",
+                           "%s: error: card has %d bytes of data, but our maximum skb size is %zu\n",
                           __func__, len, MRVDRV_ETH_RX_PACKET_BUFFER_SIZE);
                err = -EINVAL;
                goto out;
@@ -759,7 +796,7 @@ free_skb:
        dev_kfree_skb(skb);
 out:
        if (err)
-                lbs_pr_err("%s: err=%d\n", __func__, err);
+                netdev_err(priv->dev, "%s: err=%d\n", __func__, err);
        lbs_deb_leave(LBS_DEB_SPI);
        return err;
 }
@@ -768,6 +805,7 @@ out:
 static void if_spi_h2c(struct if_spi_card *card,
                        struct if_spi_packet *packet, int type)
 {
+        struct lbs_private *priv = card->priv;
        int err = 0;
        u16 int_type, port_reg;
@@ -781,7 +819,8 @@ static void if_spi_h2c(struct if_spi_card *card,
                port_reg = IF_SPI_CMD_RDWRPORT_REG;
                break;
        default:
-                lbs_pr_err("can't transfer buffer of type %d\n", type);
+                netdev_err(priv->dev, "can't transfer buffer of type %d\n",
+                           type);
                err = -EINVAL;
                goto out;
        }
@@ -795,7 +834,7 @@ out:
        kfree(packet);
        if (err)
-                lbs_pr_err("%s: error %d\n", __func__, err);
+                netdev_err(priv->dev, "%s: error %d\n", __func__, err);
 }
 /* Inform the host about a card event */
@@ -819,7 +858,7 @@ static void if_spi_e2h(struct if_spi_card *card)
        lbs_queue_event(priv, cause & 0xff);
 out:
        if (err)
-                lbs_pr_err("%s: error %d\n", __func__, err);
+                netdev_err(priv->dev, "%s: error %d\n", __func__, err);
 }
 static void if_spi_host_to_card_worker(struct work_struct *work)
@@ -829,17 +868,21 @@ static void if_spi_host_to_card_worker(struct work_struct *work)
        u16 hiStatus;
        unsigned long flags;
        struct if_spi_packet *packet;
+        struct lbs_private *priv;
        card = container_of(work, struct if_spi_card, packet_work);
+        priv = card->priv;
        lbs_deb_enter(LBS_DEB_SPI);
-        /* Read the host interrupt status register to see what we
+        /*
-         * can do. */
+         * Read the host interrupt status register to see what we
+         * can do.
+         */
        err = spu_read_u16(card, IF_SPI_HOST_INT_STATUS_REG,
                                &hiStatus);
        if (err) {
-                lbs_pr_err("I/O error\n");
+                netdev_err(priv->dev, "I/O error\n");
                goto err;
        }
@@ -854,12 +897,15 @@ static void if_spi_host_to_card_worker(struct work_struct *work)
                        goto err;
        }
-        /* workaround: in PS mode, the card does not set the Command
+        /*
-         * Download Ready bit, but it sets TX Download Ready. */
+         * workaround: in PS mode, the card does not set the Command
+         * Download Ready bit, but it sets TX Download Ready.
+         */
        if (hiStatus & IF_SPI_HIST_CMD_DOWNLOAD_RDY ||
           (card->priv->psstate != PS_STATE_FULL_POWER &&
            (hiStatus & IF_SPI_HIST_TX_DOWNLOAD_RDY))) {
-                /* This means two things. First of all,
+                /*
+                 * This means two things. First of all,
                 * if there was a previous command sent, the card has
                 * successfully received it.
                 * Secondly, it is now ready to download another
@@ -867,8 +913,7 @@ static void if_spi_host_to_card_worker(struct work_struct *work)
                 */
                lbs_host_to_card_done(card->priv);
-                /* Do we have any command packets from the host to
+                /* Do we have any command packets from the host to send? */
-                 * send? */
                packet = NULL;
                spin_lock_irqsave(&card->buffer_lock, flags);
                if (!list_empty(&card->cmd_packet_list)) {
@@ -882,8 +927,7 @@ static void if_spi_host_to_card_worker(struct work_struct *work)
                        if_spi_h2c(card, packet, MVMS_CMD);
        }
        if (hiStatus & IF_SPI_HIST_TX_DOWNLOAD_RDY) {
-                /* Do we have any data packets from the host to
+                /* Do we have any data packets from the host to send? */
-                 * send? */
                packet = NULL;
                spin_lock_irqsave(&card->buffer_lock, flags);
                if (!list_empty(&card->data_packet_list)) {
@@ -901,7 +945,7 @@ static void if_spi_host_to_card_worker(struct work_struct *work)
 err:
        if (err)
-                lbs_pr_err("%s: got error %d\n", __func__, err);
+                netdev_err(priv->dev, "%s: got error %d\n", __func__, err);
        lbs_deb_leave(LBS_DEB_SPI);
 }
@@ -910,7 +954,8 @@ err:
 * Host to Card
 *
 * Called from Libertas to transfer some data to the WLAN device
- * We can't sleep here. */
+ * We can't sleep here.
+ */
 static int if_spi_host_to_card(struct lbs_private *priv,
                                u8 type, u8 *buf, u16 nb)
 {
@@ -923,7 +968,8 @@ static int if_spi_host_to_card(struct lbs_private *priv,
        lbs_deb_enter_args(LBS_DEB_SPI, "type %d, bytes %d", type, nb);
        if (nb == 0) {
-                lbs_pr_err("%s: invalid size requested: %d\n", __func__, nb);
+                netdev_err(priv->dev, "%s: invalid size requested: %d\n",
+                           __func__, nb);
                err = -EINVAL;
                goto out;
        }
@@ -951,7 +997,8 @@ static int if_spi_host_to_card(struct lbs_private *priv,
                spin_unlock_irqrestore(&card->buffer_lock, flags);
                break;
        default:
-                lbs_pr_err("can't transfer buffer of type %d", type);
+                netdev_err(priv->dev, "can't transfer buffer of type %d\n",
+                           type);
                err = -EINVAL;
                break;
        }
@@ -984,6 +1031,7 @@ static irqreturn_t if_spi_host_interrupt(int irq, void *dev_id)
 static int if_spi_init_card(struct if_spi_card *card)
 {
+        struct lbs_private *priv = card->priv;
        struct spi_device *spi = card->spi;
        int err, i;
        u32 scratch;
@@ -1012,8 +1060,8 @@ static int if_spi_init_card(struct if_spi_card *card)
                                break;
                }
                if (i == ARRAY_SIZE(fw_table)) {
-                        lbs_pr_err("Unsupported chip_id: 0x%02x\n",
+                        netdev_err(priv->dev, "Unsupported chip_id: 0x%02x\n",
-                                        card->card_id);
+                                   card->card_id);
                        err = -ENODEV;
                        goto out;
                }
@@ -1022,7 +1070,8 @@ static int if_spi_init_card(struct if_spi_card *card)
                                        card->card_id, &fw_table[0], &helper,
                                        &mainfw);
                if (err) {
-                        lbs_pr_err("failed to find firmware (%d)\n", err);
+                        netdev_err(priv->dev, "failed to find firmware (%d)\n",
+                                   err);
                        goto out;
                }
@@ -1057,6 +1106,28 @@ out:
        return err;
 }
+static void if_spi_resume_worker(struct work_struct *work)
+{
+        struct if_spi_card *card;
+        card = container_of(work, struct if_spi_card, resume_work);
+        if (card->suspended) {
+                if (card->pdata->setup)
+                        card->pdata->setup(card->spi);
+                /* Init card ... */
+                if_spi_init_card(card);
+                enable_irq(card->spi->irq);
+                /* And resume it ... */
+                lbs_resume(card->priv);
+                card->suspended = 0;
+        }
+}
 static int __devinit if_spi_probe(struct spi_device *spi)
 {
        struct if_spi_card *card;
@@ -1099,14 +1170,17 @@ static int __devinit if_spi_probe(struct spi_device *spi)
        if (err)
                goto free_card;
-        /* Register our card with libertas.
+        /*
-         * This will call alloc_etherdev */
+         * Register our card with libertas.
+         * This will call alloc_etherdev.
+         */
        priv = lbs_add_card(card, &spi->dev);
        if (!priv) {
                err = -ENOMEM;
                goto free_card;
        }
        card->priv = priv;
+        priv->setup_fw_on_resume = 1;
        priv->card = card;
        priv->hw_host_to_card = if_spi_host_to_card;
        priv->enter_deep_sleep = NULL;
@@ -1117,17 +1191,20 @@ static int __devinit if_spi_probe(struct spi_device *spi)
        /* Initialize interrupt handling stuff. */
        card->workqueue = create_workqueue("libertas_spi");
        INIT_WORK(&card->packet_work, if_spi_host_to_card_worker);
+        INIT_WORK(&card->resume_work, if_spi_resume_worker);
        err = request_irq(spi->irq, if_spi_host_interrupt,
                        IRQF_TRIGGER_FALLING, "libertas_spi", card);
        if (err) {
-                lbs_pr_err("can't get host irq line-- request_irq failed\n");
+                pr_err("can't get host irq line-- request_irq failed\n");
                goto terminate_workqueue;
        }
-        /* Start the card.
+        /*
+         * Start the card.
         * This will call register_netdev, and we'll start
-         * getting interrupts... */
+         * getting interrupts...
+         */
        err = lbs_start_card(priv);
        if (err)
                goto release_irq;
@@ -1161,6 +1238,8 @@ static int __devexit libertas_spi_remove(struct spi_device *spi)
        lbs_deb_spi("libertas_spi_remove\n");
        lbs_deb_enter(LBS_DEB_SPI);
+        cancel_work_sync(&card->resume_work);
        lbs_stop_card(priv);
        lbs_remove_card(priv); /* will call free_netdev */
@@ -1174,6 +1253,40 @@ static int __devexit libertas_spi_remove(struct spi_device *spi)
        return 0;
 }
+static int if_spi_suspend(struct device *dev)
+{
+        struct spi_device *spi = to_spi_device(dev);
+        struct if_spi_card *card = spi_get_drvdata(spi);
+        if (!card->suspended) {
+                lbs_suspend(card->priv);
+                flush_workqueue(card->workqueue);
+                disable_irq(spi->irq);
+                if (card->pdata->teardown)
+                        card->pdata->teardown(spi);
+                card->suspended = 1;
+        }
+        return 0;
+}
+static int if_spi_resume(struct device *dev)
+{
+        struct spi_device *spi = to_spi_device(dev);
+        struct if_spi_card *card = spi_get_drvdata(spi);
+        /* Schedule delayed work */
+        schedule_work(&card->resume_work);
+        return 0;
+}
+static const struct dev_pm_ops if_spi_pm_ops = {
+        .suspend        = if_spi_suspend,
+        .resume         = if_spi_resume,
+};
 static struct spi_driver libertas_spi_driver = {
        .probe  = if_spi_probe,
        .remove = __devexit_p(libertas_spi_remove),
@@ -1181,6 +1294,7 @@ static struct spi_driver libertas_spi_driver = {
                .name   = "libertas_spi",
                .bus    = &spi_bus_type,
                .owner  = THIS_MODULE,
+                .pm     = &if_spi_pm_ops,
        },
 };
diff --git a/drivers/net/wireless/libertas/if_spi.h b/drivers/net/wireless/libertas/if_spi.h
index d2ac1dcd7e2e..e450e31fd11d 100644
--- a/drivers/net/wireless/libertas/if_spi.h
+++ b/drivers/net/wireless/libertas/if_spi.h
@@ -86,34 +86,34 @@
 #define IF_SPI_DEVICEID_CTRL_REG_TO_CARD_REV(dc) (dc & 0x000000ff)
 /***************** IF_SPI_HOST_INT_CTRL_REG *****************/
-/** Host Interrupt Control bit : Wake up */
+/* Host Interrupt Control bit : Wake up */
 #define IF_SPI_HICT_WAKE_UP                             (1<<0)
-/** Host Interrupt Control bit : WLAN ready */
+/* Host Interrupt Control bit : WLAN ready */
 #define IF_SPI_HICT_WLAN_READY                          (1<<1)
 /*#define IF_SPI_HICT_FIFO_FIRST_HALF_EMPTY             (1<<2) */
 /*#define IF_SPI_HICT_FIFO_SECOND_HALF_EMPTY            (1<<3) */
 /*#define IF_SPI_HICT_IRQSRC_WLAN                       (1<<4) */
-/** Host Interrupt Control bit : Tx auto download */
+/* Host Interrupt Control bit : Tx auto download */
 #define IF_SPI_HICT_TX_DOWNLOAD_OVER_AUTO               (1<<5)
-/** Host Interrupt Control bit : Rx auto upload */
+/* Host Interrupt Control bit : Rx auto upload */
 #define IF_SPI_HICT_RX_UPLOAD_OVER_AUTO                 (1<<6)
-/** Host Interrupt Control bit : Command auto download */
+/* Host Interrupt Control bit : Command auto download */
 #define IF_SPI_HICT_CMD_DOWNLOAD_OVER_AUTO              (1<<7)
-/** Host Interrupt Control bit : Command auto upload */
+/* Host Interrupt Control bit : Command auto upload */
 #define IF_SPI_HICT_CMD_UPLOAD_OVER_AUTO                (1<<8)
 /***************** IF_SPI_CARD_INT_CAUSE_REG *****************/
-/** Card Interrupt Case bit : Tx download over */
+/* Card Interrupt Case bit : Tx download over */
 #define IF_SPI_CIC_TX_DOWNLOAD_OVER                     (1<<0)
-/** Card Interrupt Case bit : Rx upload over */
+/* Card Interrupt Case bit : Rx upload over */
 #define IF_SPI_CIC_RX_UPLOAD_OVER                       (1<<1)
-/** Card Interrupt Case bit : Command download over */
+/* Card Interrupt Case bit : Command download over */
 #define IF_SPI_CIC_CMD_DOWNLOAD_OVER                    (1<<2)
-/** Card Interrupt Case bit : Host event */
+/* Card Interrupt Case bit : Host event */
 #define IF_SPI_CIC_HOST_EVENT                           (1<<3)
-/** Card Interrupt Case bit : Command upload over */
+/* Card Interrupt Case bit : Command upload over */
 #define IF_SPI_CIC_CMD_UPLOAD_OVER                      (1<<4)
-/** Card Interrupt Case bit : Power down */
+/* Card Interrupt Case bit : Power down */
 #define IF_SPI_CIC_POWER_DOWN                           (1<<5)
 /***************** IF_SPI_CARD_INT_STATUS_REG *****************/
@@ -138,51 +138,51 @@
 #define IF_SPI_HICU_CMD_RD_FIFO_UNDERFLOW               (1<<10)
 /***************** IF_SPI_HOST_INT_STATUS_REG *****************/
-/** Host Interrupt Status bit : Tx download ready */
+/* Host Interrupt Status bit : Tx download ready */
 #define IF_SPI_HIST_TX_DOWNLOAD_RDY                     (1<<0)
-/** Host Interrupt Status bit : Rx upload ready */
+/* Host Interrupt Status bit : Rx upload ready */
 #define IF_SPI_HIST_RX_UPLOAD_RDY                       (1<<1)
-/** Host Interrupt Status bit : Command download ready */
+/* Host Interrupt Status bit : Command download ready */
 #define IF_SPI_HIST_CMD_DOWNLOAD_RDY                    (1<<2)
-/** Host Interrupt Status bit : Card event */
+/* Host Interrupt Status bit : Card event */
 #define IF_SPI_HIST_CARD_EVENT                          (1<<3)
-/** Host Interrupt Status bit : Command upload ready */
+/* Host Interrupt Status bit : Command upload ready */
 #define IF_SPI_HIST_CMD_UPLOAD_RDY                      (1<<4)
-/** Host Interrupt Status bit : I/O write FIFO overflow */
+/* Host Interrupt Status bit : I/O write FIFO overflow */
 #define IF_SPI_HIST_IO_WR_FIFO_OVERFLOW                 (1<<5)
-/** Host Interrupt Status bit : I/O read FIFO underflow */
+/* Host Interrupt Status bit : I/O read FIFO underflow */
 #define IF_SPI_HIST_IO_RD_FIFO_UNDRFLOW                 (1<<6)
-/** Host Interrupt Status bit : Data write FIFO overflow */
+/* Host Interrupt Status bit : Data write FIFO overflow */
 #define IF_SPI_HIST_DATA_WR_FIFO_OVERFLOW               (1<<7)
-/** Host Interrupt Status bit : Data read FIFO underflow */
+/* Host Interrupt Status bit : Data read FIFO underflow */
 #define IF_SPI_HIST_DATA_RD_FIFO_UNDERFLOW              (1<<8)
-/** Host Interrupt Status bit : Command write FIFO overflow */
+/* Host Interrupt Status bit : Command write FIFO overflow */
 #define IF_SPI_HIST_CMD_WR_FIFO_OVERFLOW                (1<<9)
-/** Host Interrupt Status bit : Command read FIFO underflow */
+/* Host Interrupt Status bit : Command read FIFO underflow */
 #define IF_SPI_HIST_CMD_RD_FIFO_UNDERFLOW               (1<<10)
 /***************** IF_SPI_HOST_INT_STATUS_MASK_REG *****************/
-/** Host Interrupt Status Mask bit : Tx download ready */
+/* Host Interrupt Status Mask bit : Tx download ready */
 #define IF_SPI_HISM_TX_DOWNLOAD_RDY                     (1<<0)
-/** Host Interrupt Status Mask bit : Rx upload ready */
+/* Host Interrupt Status Mask bit : Rx upload ready */
 #define IF_SPI_HISM_RX_UPLOAD_RDY                       (1<<1)
-/** Host Interrupt Status Mask bit : Command download ready */
+/* Host Interrupt Status Mask bit : Command download ready */
 #define IF_SPI_HISM_CMD_DOWNLOAD_RDY                    (1<<2)
-/** Host Interrupt Status Mask bit : Card event */
+/* Host Interrupt Status Mask bit : Card event */
 #define IF_SPI_HISM_CARDEVENT                           (1<<3)
-/** Host Interrupt Status Mask bit : Command upload ready */
+/* Host Interrupt Status Mask bit : Command upload ready */
 #define IF_SPI_HISM_CMD_UPLOAD_RDY                      (1<<4)
-/** Host Interrupt Status Mask bit : I/O write FIFO overflow */
+/* Host Interrupt Status Mask bit : I/O write FIFO overflow */
 #define IF_SPI_HISM_IO_WR_FIFO_OVERFLOW                 (1<<5)
-/** Host Interrupt Status Mask bit : I/O read FIFO underflow */
+/* Host Interrupt Status Mask bit : I/O read FIFO underflow */
 #define IF_SPI_HISM_IO_RD_FIFO_UNDERFLOW                (1<<6)
-/** Host Interrupt Status Mask bit : Data write FIFO overflow */
+/* Host Interrupt Status Mask bit : Data write FIFO overflow */
 #define IF_SPI_HISM_DATA_WR_FIFO_OVERFLOW               (1<<7)
-/** Host Interrupt Status Mask bit : Data write FIFO underflow */
+/* Host Interrupt Status Mask bit : Data write FIFO underflow */
 #define IF_SPI_HISM_DATA_RD_FIFO_UNDERFLOW              (1<<8)
-/** Host Interrupt Status Mask bit : Command write FIFO overflow */
+/* Host Interrupt Status Mask bit : Command write FIFO overflow */
 #define IF_SPI_HISM_CMD_WR_FIFO_OVERFLOW                (1<<9)
-/** Host Interrupt Status Mask bit : Command write FIFO underflow */
+/* Host Interrupt Status Mask bit : Command write FIFO underflow */
 #define IF_SPI_HISM_CMD_RD_FIFO_UNDERFLOW               (1<<10)
 /***************** IF_SPI_SPU_BUS_MODE_REG *****************/
diff --git a/drivers/net/wireless/libertas/if_usb.c b/drivers/net/wireless/libertas/if_usb.c
index 6524c70363d9..b5acc393a65a 100644
--- a/drivers/net/wireless/libertas/if_usb.c
+++ b/drivers/net/wireless/libertas/if_usb.c
@@ -1,6 +1,9 @@
-/**
+/*
-  * This file contains functions used in USB interface module.
+ * This file contains functions used in USB interface module.
-  */
+ */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #include <linux/delay.h>
 #include <linux/moduleparam.h>
 #include <linux/firmware.h>
@@ -66,7 +69,7 @@ static int if_usb_reset_device(struct if_usb_card *cardp);
 /* sysfs hooks */
-/**
+/*
 *  Set function to write firmware to device's persistent memory
 */
 static ssize_t if_usb_firmware_set(struct device *dev,
@@ -85,7 +88,7 @@ static ssize_t if_usb_firmware_set(struct device *dev,
        return ret;
 }
-/**
+/*
 * lbs_flash_fw attribute to be exported per ethX interface through sysfs
 * (/sys/class/net/ethX/lbs_flash_fw).  Use this like so to write firmware to
 * the device's persistent memory:
@@ -94,7 +97,14 @@ static ssize_t if_usb_firmware_set(struct device *dev,
 static DEVICE_ATTR(lbs_flash_fw, 0200, NULL, if_usb_firmware_set);
 /**
- *  Set function to write firmware to device's persistent memory
+ * if_usb_boot2_set - write firmware to device's persistent memory
+ *
+ * @dev: target device
+ * @attr: device attributes
+ * @buf: firmware buffer to write
+ * @count: number of bytes to write
+ *
+ * returns: number of bytes written or negative error code
 */
 static ssize_t if_usb_boot2_set(struct device *dev,
                struct device_attribute *attr, const char *buf, size_t count)
@@ -112,7 +122,7 @@ static ssize_t if_usb_boot2_set(struct device *dev,
        return ret;
 }
-/**
+/*
 * lbs_flash_boot2 attribute to be exported per ethX interface through sysfs
 * (/sys/class/net/ethX/lbs_flash_boot2).  Use this like so to write firmware
 * to the device's persistent memory:
@@ -121,9 +131,10 @@ static ssize_t if_usb_boot2_set(struct device *dev,
 static DEVICE_ATTR(lbs_flash_boot2, 0200, NULL, if_usb_boot2_set);
 /**
- *  @brief  call back function to handle the status of the URB
+ * if_usb_write_bulk_callback - callback function to handle the status
- *  @param urb          pointer to urb structure
+ * of the URB
- *  @return             N/A
+ * @urb:        pointer to &urb structure
+ * returns:     N/A
 */
 static void if_usb_write_bulk_callback(struct urb *urb)
 {
@@ -145,14 +156,14 @@ static void if_usb_write_bulk_callback(struct urb *urb)
                        lbs_host_to_card_done(priv);
        } else {
                /* print the failure status number for debug */
-                lbs_pr_info("URB in failure status: %d\n", urb->status);
+                pr_info("URB in failure status: %d\n", urb->status);
        }
 }
 /**
- *  @brief  free tx/rx urb, skb and rx buffer
+ * if_usb_free - free tx/rx urb, skb and rx buffer
- *  @param cardp        pointer if_usb_card
+ * @cardp:      pointer to &if_usb_card
- *  @return             N/A
+ * returns:     N/A
 */
 static void if_usb_free(struct if_usb_card *cardp)
 {
@@ -195,7 +206,7 @@ static void if_usb_setup_firmware(struct lbs_private *priv)
        wake_method.hdr.size = cpu_to_le16(sizeof(wake_method));
        wake_method.action = cpu_to_le16(CMD_ACT_GET);
        if (lbs_cmd_with_response(priv, CMD_802_11_FW_WAKE_METHOD, &wake_method)) {
-                lbs_pr_info("Firmware does not seem to support PS mode\n");
+                netdev_info(priv->dev, "Firmware does not seem to support PS mode\n");
                priv->fwcapinfo &= ~FW_CAPINFO_PS;
        } else {
                if (le16_to_cpu(wake_method.method) == CMD_WAKE_METHOD_COMMAND_INT) {
@@ -204,7 +215,8 @@ static void if_usb_setup_firmware(struct lbs_private *priv)
                        /* The versions which boot up this way don't seem to
                           work even if we set it to the command interrupt */
                        priv->fwcapinfo &= ~FW_CAPINFO_PS;
-                        lbs_pr_info("Firmware doesn't wake via command interrupt; disabling PS mode\n");
+                        netdev_info(priv->dev,
+                                    "Firmware doesn't wake via command interrupt; disabling PS mode\n");
                }
        }
 }
@@ -216,7 +228,7 @@ static void if_usb_fw_timeo(unsigned long priv)
        if (cardp->fwdnldover) {
                lbs_deb_usb("Download complete, no event. Assuming success\n");
        } else {
-                lbs_pr_err("Download timed out\n");
+                pr_err("Download timed out\n");
                cardp->surprise_removed = 1;
        }
        wake_up(&cardp->fw_wq);
@@ -231,10 +243,10 @@ static void if_usb_reset_olpc_card(struct lbs_private *priv)
 #endif
 /**
- *  @brief sets the configuration values
+ * if_usb_probe - sets the configuration values
- *  @param ifnum        interface number
+ * @intf:       &usb_interface pointer
- *  @param id           pointer to usb_device_id
+ * @id: pointer to usb_device_id
- *  @return             0 on success, error code on failure
+ * returns:     0 on success, error code on failure
 */
 static int if_usb_probe(struct usb_interface *intf,
                        const struct usb_device_id *id)
@@ -250,7 +262,7 @@ static int if_usb_probe(struct usb_interface *intf,
        cardp = kzalloc(sizeof(struct if_usb_card), GFP_KERNEL);
        if (!cardp) {
-                lbs_pr_err("Out of memory allocating private data.\n");
+                pr_err("Out of memory allocating private data\n");
                goto error;
        }
@@ -340,10 +352,12 @@ static int if_usb_probe(struct usb_interface *intf,
        usb_set_intfdata(intf, cardp);
        if (device_create_file(&priv->dev->dev, &dev_attr_lbs_flash_fw))
-                lbs_pr_err("cannot register lbs_flash_fw attribute\n");
+                netdev_err(priv->dev,
+                           "cannot register lbs_flash_fw attribute\n");
        if (device_create_file(&priv->dev->dev, &dev_attr_lbs_flash_boot2))
-                lbs_pr_err("cannot register lbs_flash_boot2 attribute\n");
+                netdev_err(priv->dev,
+                           "cannot register lbs_flash_boot2 attribute\n");
        /*
         * EHS_REMOVE_WAKEUP is not supported on all versions of the firmware.
@@ -366,9 +380,9 @@ error:
 }
 /**
- *  @brief free resource and cleanup
+ * if_usb_disconnect - free resource and cleanup
- *  @param intf         USB interface structure
+ * @intf:       USB interface structure
- *  @return             N/A
+ * returns:     N/A
 */
 static void if_usb_disconnect(struct usb_interface *intf)
 {
@@ -398,9 +412,9 @@ static void if_usb_disconnect(struct usb_interface *intf)
 }
 /**
- *  @brief  This function download FW
+ * if_usb_send_fw_pkt - download FW
- *  @param priv         pointer to struct lbs_private
+ * @cardp:      pointer to &struct if_usb_card
- *  @return             0
+ * returns:     0
 */
 static int if_usb_send_fw_pkt(struct if_usb_card *cardp)
 {
@@ -486,11 +500,11 @@ static int if_usb_reset_device(struct if_usb_card *cardp)
 }
 /**
- *  @brief This function transfer the data to the device.
+ *  usb_tx_block - transfer the data to the device
- *  @param priv         pointer to struct lbs_private
+ *  @cardp:     pointer to &struct if_usb_card
- *  @param payload      pointer to payload data
+ *  @payload:   pointer to payload data
- *  @param nb           data length
+ *  @nb:        data length
- *  @return             0 or -1
+ *  returns:    0 for success or negative error code
 */
 static int usb_tx_block(struct if_usb_card *cardp, uint8_t *payload, uint16_t nb)
 {
@@ -528,7 +542,7 @@ static int __if_usb_submit_rx_urb(struct if_usb_card *cardp,
        int ret = -1;
        if (!(skb = dev_alloc_skb(MRVDRV_ETH_RX_PACKET_BUFFER_SIZE))) {
-                lbs_pr_err("No free skb\n");
+                pr_err("No free skb\n");
                goto rx_ret;
        }
@@ -587,7 +601,7 @@ static void if_usb_receive_fwload(struct urb *urb)
                if (tmp[0] == cpu_to_le32(CMD_TYPE_INDICATION) &&
                    tmp[1] == cpu_to_le32(MACREG_INT_CODE_FIRMWARE_READY)) {
-                        lbs_pr_info("Firmware ready event received\n");
+                        pr_info("Firmware ready event received\n");
                        wake_up(&cardp->fw_wq);
                } else {
                        lbs_deb_usb("Waiting for confirmation; got %x %x\n",
@@ -614,20 +628,20 @@ static void if_usb_receive_fwload(struct urb *urb)
                            bootcmdresp.magic == cpu_to_le32(CMD_TYPE_DATA) ||
                            bootcmdresp.magic == cpu_to_le32(CMD_TYPE_INDICATION)) {
                                if (!cardp->bootcmdresp)
-                                        lbs_pr_info("Firmware already seems alive; resetting\n");
+                                        pr_info("Firmware already seems alive; resetting\n");
                                cardp->bootcmdresp = -1;
                        } else {
-                                lbs_pr_info("boot cmd response wrong magic number (0x%x)\n",
+                                pr_info("boot cmd response wrong magic number (0x%x)\n",
                                            le32_to_cpu(bootcmdresp.magic));
                        }
                } else if ((bootcmdresp.cmd != BOOT_CMD_FW_BY_USB) &&
                           (bootcmdresp.cmd != BOOT_CMD_UPDATE_FW) &&
                           (bootcmdresp.cmd != BOOT_CMD_UPDATE_BOOT2)) {
-                        lbs_pr_info("boot cmd response cmd_tag error (%d)\n",
+                        pr_info("boot cmd response cmd_tag error (%d)\n",
-                                    bootcmdresp.cmd);
+                                bootcmdresp.cmd);
                } else if (bootcmdresp.result != BOOT_CMD_RESP_OK) {
-                        lbs_pr_info("boot cmd response result error (%d)\n",
+                        pr_info("boot cmd response result error (%d)\n",
-                                    bootcmdresp.result);
+                                bootcmdresp.result);
                } else {
                        cardp->bootcmdresp = 1;
                        lbs_deb_usbd(&cardp->udev->dev,
@@ -727,11 +741,11 @@ static inline void process_cmdrequest(int recvlength, uint8_t *recvbuff,
 }
 /**
- *  @brief This function reads of the packet into the upload buff,
+ *  if_usb_receive - read the packet into the upload buffer,
- *  wake up the main thread and initialise the Rx callack.
+ *  wake up the main thread and initialise the Rx callack
 *
- *  @param urb          pointer to struct urb
+ *  @urb:       pointer to &struct urb
- *  @return             N/A
+ *  returns:    N/A
 */
 static void if_usb_receive(struct urb *urb)
 {
@@ -802,12 +816,12 @@ rx_exit:
 }
 /**
- *  @brief This function downloads data to FW
+ *  if_usb_host_to_card - downloads data to FW
- *  @param priv         pointer to struct lbs_private structure
+ *  @priv:      pointer to &struct lbs_private structure
- *  @param type         type of data
+ *  @type:      type of data
- *  @param buf          pointer to data buffer
+ *  @payload:   pointer to data buffer
- *  @param len          number of bytes
+ *  @nb:        number of bytes
- *  @return             0 or -1
+ *  returns:    0 for success or negative error code
 */
 static int if_usb_host_to_card(struct lbs_private *priv, uint8_t type,
                               uint8_t *payload, uint16_t nb)
@@ -831,10 +845,11 @@ static int if_usb_host_to_card(struct lbs_private *priv, uint8_t type,
 }
 /**
- *  @brief This function issues Boot command to the Boot2 code
+ *  if_usb_issue_boot_command - issues Boot command to the Boot2 code
- *  @param ivalue   1:Boot from FW by USB-Download
+ *  @cardp:     pointer to &if_usb_card
- *                  2:Boot from FW in EEPROM
+ *  @ivalue:    1:Boot from FW by USB-Download
- *  @return             0
+ *              2:Boot from FW in EEPROM
+ *  returns:    0 for success or negative error code
 */
 static int if_usb_issue_boot_command(struct if_usb_card *cardp, int ivalue)
 {
@@ -853,11 +868,11 @@ static int if_usb_issue_boot_command(struct if_usb_card *cardp, int ivalue)
 /**
- *  @brief This function checks the validity of Boot2/FW image.
+ *  check_fwfile_format - check the validity of Boot2/FW image
 *
- *  @param data              pointer to image
+ *  @data:      pointer to image
- *         len               image length
+ *  @totlen:    image length
- *  @return     0 or -1
+ *  returns:     0 (good) or 1 (failure)
 */
 static int check_fwfile_format(const uint8_t *data, uint32_t totlen)
 {
@@ -892,7 +907,7 @@ static int check_fwfile_format(const uint8_t *data, uint32_t totlen)
        } while (!exit);
        if (ret)
-                lbs_pr_err("firmware file format check FAIL\n");
+                pr_err("firmware file format check FAIL\n");
        else
                lbs_deb_fw("firmware file format check PASS\n");
@@ -901,13 +916,13 @@ static int check_fwfile_format(const uint8_t *data, uint32_t totlen)
 /**
-*  @brief This function programs the firmware subject to cmd
+*  if_usb_prog_firmware - programs the firmware subject to cmd
 *
-*  @param cardp             the if_usb_card descriptor
+*  @cardp:      the if_usb_card descriptor
-*         fwname            firmware or boot2 image file name
+*  @fwname:     firmware or boot2 image file name
-*         cmd               either BOOT_CMD_FW_BY_USB, BOOT_CMD_UPDATE_FW,
+*  @cmd:        either BOOT_CMD_FW_BY_USB, BOOT_CMD_UPDATE_FW,
-*                           or BOOT_CMD_UPDATE_BOOT2.
+*               or BOOT_CMD_UPDATE_BOOT2.
-*  @return     0 or error code
+*  returns:     0 or error code
 */
 static int if_usb_prog_firmware(struct if_usb_card *cardp,
                                const char *fwname, int cmd)
@@ -989,7 +1004,7 @@ static int __if_usb_prog_firmware(struct if_usb_card *cardp,
        ret = get_fw(cardp, fwname);
        if (ret) {
-                lbs_pr_err("failed to find firmware (%d)\n", ret);
+                pr_err("failed to find firmware (%d)\n", ret);
                goto done;
        }
@@ -1064,13 +1079,13 @@ restart:
        usb_kill_urb(cardp->rx_urb);
        if (!cardp->fwdnldover) {
-                lbs_pr_info("failed to load fw, resetting device!\n");
+                pr_info("failed to load fw, resetting device!\n");
                if (--reset_count >= 0) {
                        if_usb_reset_device(cardp);
                        goto restart;
                }
-                lbs_pr_info("FW download failure, time = %d ms\n", i * 100);
+                pr_info("FW download failure, time = %d ms\n", i * 100);
                ret = -EIO;
                goto release_fw;
        }
diff --git a/drivers/net/wireless/libertas/if_usb.h b/drivers/net/wireless/libertas/if_usb.h
index d819e7e3c9aa..6e42eac331de 100644
--- a/drivers/net/wireless/libertas/if_usb.h
+++ b/drivers/net/wireless/libertas/if_usb.h
@@ -6,9 +6,9 @@
 struct lbs_private;
-/**
+/*
-  * This file contains definition for USB interface.
+ * This file contains definition for USB interface.
-  */
+ */
 #define CMD_TYPE_REQUEST                0xF00DFACE
 #define CMD_TYPE_DATA                   0xBEADC0DE
 #define CMD_TYPE_INDICATION             0xBEEFFACE
@@ -40,7 +40,7 @@ struct bootcmdresp
        uint8_t pad[2];
 };
-/** USB card description structure*/
+/* USB card description structure*/
 struct if_usb_card {
        struct usb_device *udev;
        uint32_t model;  /* MODEL_* */
@@ -77,7 +77,7 @@ struct if_usb_card {
        __le16 boot2_version;
 };
-/** fwheader */
+/* fwheader */
 struct fwheader {
        __le32 dnldcmd;
        __le32 baseaddr;
@@ -86,14 +86,14 @@ struct fwheader {
 };
 #define FW_MAX_DATA_BLK_SIZE    600
-/** FWData */
+/* FWData */
 struct fwdata {
        struct fwheader hdr;
        __le32 seqnum;
        uint8_t data[0];
 };
-/** fwsyncheader */
+/* fwsyncheader */
 struct fwsyncheader {
        __le32 cmd;
        __le32 seqnum;
diff --git a/drivers/net/wireless/libertas/main.c b/drivers/net/wireless/libertas/main.c
index ca8149cd5bd9..8c40949cb076 100644
--- a/drivers/net/wireless/libertas/main.c
+++ b/drivers/net/wireless/libertas/main.c
@@ -1,8 +1,10 @@
-/**
+/*
-  * This file contains the major functions in WLAN
+ * This file contains the major functions in WLAN
-  * driver. It includes init, exit, open, close and main
+ * driver. It includes init, exit, open, close and main
-  * thread etc..
+ * thread etc..
-  */
+ */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #include <linux/moduleparam.h>
 #include <linux/delay.h>
@@ -34,19 +36,25 @@ unsigned int lbs_debug;
 EXPORT_SYMBOL_GPL(lbs_debug);
 module_param_named(libertas_debug, lbs_debug, int, 0644);
+unsigned int lbs_disablemesh;
+EXPORT_SYMBOL_GPL(lbs_disablemesh);
+module_param_named(libertas_disablemesh, lbs_disablemesh, int, 0644);
-/* This global structure is used to send the confirm_sleep command as
- * fast as possible down to the firmware. */
+/*
+ * This global structure is used to send the confirm_sleep command as
+ * fast as possible down to the firmware.
+ */
 struct cmd_confirm_sleep confirm_sleep;
-/**
+/*
 * the table to keep region code
 */
 u16 lbs_region_code_to_index[MRVDRV_MAX_REGION_CODE] =
    { 0x10, 0x20, 0x30, 0x31, 0x32, 0x40 };
-/**
+/*
 * FW rate table.  FW refers to rates by their index in this table, not by the
 * rate value itself.  Values of 0x00 are
 * reserved positions.
@@ -57,10 +65,10 @@ static u8 fw_data_rates[MAX_RATES] =
 };
 /**
- *  @brief use index to get the data rate
+ *  lbs_fw_index_to_data_rate - use index to get the data rate
 *
- *  @param idx                The index of data rate
+ *  @idx:       The index of data rate
- *  @return                     data rate or 0
+ *  returns:    data rate or 0
 */
 u32 lbs_fw_index_to_data_rate(u8 idx)
 {
@@ -70,10 +78,10 @@ u32 lbs_fw_index_to_data_rate(u8 idx)
 }
 /**
- *  @brief use rate to get the index
+ *  lbs_data_rate_to_fw_index - use rate to get the index
 *
- *  @param rate                 data rate
+ *  @rate:      data rate
- *  @return                     index or 0
+ *  returns:    index or 0
 */
 u8 lbs_data_rate_to_fw_index(u32 rate)
 {
@@ -91,10 +99,10 @@ u8 lbs_data_rate_to_fw_index(u32 rate)
 /**
- *  @brief This function opens the ethX interface
+ *  lbs_dev_open - open the ethX interface
 *
- *  @param dev     A pointer to net_device structure
+ *  @dev:       A pointer to &net_device structure
- *  @return        0 or -EBUSY if monitor mode active
+ *  returns:    0 or -EBUSY if monitor mode active
 */
 static int lbs_dev_open(struct net_device *dev)
 {
@@ -120,10 +128,10 @@ static int lbs_dev_open(struct net_device *dev)
 }
 /**
- *  @brief This function closes the ethX interface
+ *  lbs_eth_stop - close the ethX interface
 *
- *  @param dev     A pointer to net_device structure
+ *  @dev:       A pointer to &net_device structure
- *  @return        0
+ *  returns:    0
 */
 static int lbs_eth_stop(struct net_device *dev)
 {
@@ -147,28 +155,6 @@ static int lbs_eth_stop(struct net_device *dev)
        return 0;
 }
-static void lbs_tx_timeout(struct net_device *dev)
-{
-        struct lbs_private *priv = dev->ml_priv;
-        lbs_deb_enter(LBS_DEB_TX);
-        lbs_pr_err("tx watch dog timeout\n");
-        dev->trans_start = jiffies; /* prevent tx timeout */
-        if (priv->currenttxskb)
-                lbs_send_tx_feedback(priv, 0);
-        /* XX: Shouldn't we also call into the hw-specific driver
-           to kick it somehow? */
-        lbs_host_to_card_done(priv);
-        /* FIXME: reset the card */
-        lbs_deb_leave(LBS_DEB_TX);
-}
 void lbs_host_to_card_done(struct lbs_private *priv)
 {
        unsigned long flags;
@@ -336,12 +322,12 @@ void lbs_set_multicast_list(struct net_device *dev)
 }
 /**
- *  @brief This function handles the major jobs in the LBS driver.
+ *  lbs_thread - handles the major jobs in the LBS driver.
 *  It handles all events generated by firmware, RX data received
 *  from firmware and TX data sent from kernel.
 *
- *  @param data    A pointer to lbs_thread structure
+ *  @data:      A pointer to &lbs_thread structure
- *  @return        0
+ *  returns:    0
 */
 static int lbs_thread(void *data)
 {
@@ -462,8 +448,8 @@ static int lbs_thread(void *data)
                if (priv->cmd_timed_out && priv->cur_cmd) {
                        struct cmd_ctrl_node *cmdnode = priv->cur_cmd;
-                        lbs_pr_info("Timeout submitting command 0x%04x\n",
+                        netdev_info(dev, "Timeout submitting command 0x%04x\n",
-                                le16_to_cpu(cmdnode->cmdbuf->command));
+                                    le16_to_cpu(cmdnode->cmdbuf->command));
                        lbs_complete_command(priv, cmdnode, -ETIMEDOUT);
                        if (priv->reset_card)
                                priv->reset_card(priv);
@@ -490,8 +476,8 @@ static int lbs_thread(void *data)
                                 * after firmware fixes it
                                 */
                                priv->psstate = PS_STATE_AWAKE;
-                                lbs_pr_alert("ignore PS_SleepConfirm in "
+                                netdev_alert(dev,
-                                        "non-connected state\n");
+                                             "ignore PS_SleepConfirm in non-connected state\n");
                        }
                }
@@ -540,11 +526,11 @@ static int lbs_thread(void *data)
 }
 /**
- * @brief This function gets the HW spec from the firmware and sets
+ * lbs_setup_firmware - gets the HW spec from the firmware and sets
- *        some basic parameters.
+ *        some basic parameters
 *
- *  @param priv    A pointer to struct lbs_private structure
+ *  @priv:      A pointer to &struct lbs_private structure
- *  @return        0 or -1
+ *  returns:    0 or -1
 */
 static int lbs_setup_firmware(struct lbs_private *priv)
 {
@@ -585,7 +571,8 @@ int lbs_suspend(struct lbs_private *priv)
        if (priv->is_deep_sleep) {
                ret = lbs_set_deep_sleep(priv, 0);
                if (ret) {
-                        lbs_pr_err("deep sleep cancellation failed: %d\n", ret);
+                        netdev_err(priv->dev,
+                                   "deep sleep cancellation failed: %d\n", ret);
                        return ret;
                }
                priv->deep_sleep_required = 1;
@@ -618,7 +605,8 @@ int lbs_resume(struct lbs_private *priv)
                priv->deep_sleep_required = 0;
                ret = lbs_set_deep_sleep(priv, 1);
                if (ret)
-                        lbs_pr_err("deep sleep activation failed: %d\n", ret);
+                        netdev_err(priv->dev,
+                                   "deep sleep activation failed: %d\n", ret);
        }
        if (priv->setup_fw_on_resume)
@@ -630,8 +618,10 @@ int lbs_resume(struct lbs_private *priv)
 EXPORT_SYMBOL_GPL(lbs_resume);
 /**
- *  This function handles the timeout of command sending.
+ * lbs_cmd_timeout_handler - handles the timeout of command sending.
- *  It will re-send the same command again.
+ * It will re-send the same command again.
+ *
+ * @data: &struct lbs_private pointer
 */
 static void lbs_cmd_timeout_handler(unsigned long data)
 {
@@ -644,8 +634,8 @@ static void lbs_cmd_timeout_handler(unsigned long data)
        if (!priv->cur_cmd)
                goto out;
-        lbs_pr_info("command 0x%04x timed out\n",
+        netdev_info(priv->dev, "command 0x%04x timed out\n",
-                le16_to_cpu(priv->cur_cmd->cmdbuf->command));
+                    le16_to_cpu(priv->cur_cmd->cmdbuf->command));
        priv->cmd_timed_out = 1;
        wake_up_interruptible(&priv->waitq);
@@ -655,8 +645,10 @@ out:
 }
 /**
- *  This function put the device back to deep sleep mode when timer expires
+ * auto_deepsleep_timer_fn - put the device back to deep sleep mode when
- *  and no activity (command, event, data etc.) is detected.
+ * timer expires and no activity (command, event, data etc.) is detected.
+ * @data:       &struct lbs_private pointer
+ * returns:     N/A
 */
 static void auto_deepsleep_timer_fn(unsigned long data)
 {
@@ -748,7 +740,7 @@ static int lbs_init_adapter(struct lbs_private *priv)
        /* Allocate the command buffers */
        if (lbs_allocate_cmd_buffer(priv)) {
-                lbs_pr_err("Out of memory allocating command buffers\n");
+                pr_err("Out of memory allocating command buffers\n");
                ret = -ENOMEM;
                goto out;
        }
@@ -758,7 +750,7 @@ static int lbs_init_adapter(struct lbs_private *priv)
        /* Create the event FIFO */
        ret = kfifo_alloc(&priv->event_fifo, sizeof(u32) * 16, GFP_KERNEL);
        if (ret) {
-                lbs_pr_err("Out of memory allocating event FIFO buffer\n");
+                pr_err("Out of memory allocating event FIFO buffer\n");
                goto out;
        }
@@ -785,18 +777,18 @@ static const struct net_device_ops lbs_netdev_ops = {
        .ndo_stop               = lbs_eth_stop,
        .ndo_start_xmit         = lbs_hard_start_xmit,
        .ndo_set_mac_address    = lbs_set_mac_address,
-        .ndo_tx_timeout         = lbs_tx_timeout,
        .ndo_set_multicast_list = lbs_set_multicast_list,
        .ndo_change_mtu         = eth_change_mtu,
        .ndo_validate_addr      = eth_validate_addr,
 };
 /**
- * @brief This function adds the card. it will probe the
+ * lbs_add_card - adds the card. It will probe the
 * card, allocate the lbs_priv and initialize the device.
 *
- *  @param card    A pointer to card
+ * @card:       A pointer to card
- *  @return        A pointer to struct lbs_private structure
+ * @dmdev:      A pointer to &struct device
+ * returns:     A pointer to &struct lbs_private structure
 */
 struct lbs_private *lbs_add_card(void *card, struct device *dmdev)
 {
@@ -809,7 +801,7 @@ struct lbs_private *lbs_add_card(void *card, struct device *dmdev)
        /* Allocate an Ethernet device and register it */
        wdev = lbs_cfg_alloc(dmdev);
        if (IS_ERR(wdev)) {
-                lbs_pr_err("cfg80211 init failed\n");
+                pr_err("cfg80211 init failed\n");
                goto done;
        }
@@ -818,7 +810,7 @@ struct lbs_private *lbs_add_card(void *card, struct device *dmdev)
        priv->wdev = wdev;
        if (lbs_init_adapter(priv)) {
-                lbs_pr_err("failed to initialize adapter structure.\n");
+                pr_err("failed to initialize adapter structure\n");
                goto err_wdev;
        }
@@ -950,17 +942,20 @@ int lbs_start_card(struct lbs_private *priv)
                goto done;
        if (lbs_cfg_register(priv)) {
-                lbs_pr_err("cannot register device\n");
+                pr_err("cannot register device\n");
                goto done;
        }
        lbs_update_channel(priv);
-        lbs_init_mesh(priv);
+        if (!lbs_disablemesh)
+                lbs_init_mesh(priv);
+        else
+                pr_info("%s: mesh disabled\n", dev->name);
        lbs_debugfs_init_one(priv, dev);
-        lbs_pr_info("%s: Marvell WLAN 802.11 adapter\n", dev->name);
+        netdev_info(dev, "Marvell WLAN 802.11 adapter\n");
        ret = 0;
@@ -1057,19 +1052,19 @@ void lbs_notify_command_response(struct lbs_private *priv, u8 resp_idx)
 EXPORT_SYMBOL_GPL(lbs_notify_command_response);
 /**
- *  @brief Retrieves two-stage firmware
+ *  lbs_get_firmware - Retrieves two-stage firmware
 *
- *  @param dev          A pointer to device structure
+ *  @dev:       A pointer to &device structure
- *  @param user_helper  User-defined helper firmware file
+ *  @user_helper: User-defined helper firmware file
- *  @param user_mainfw  User-defined main firmware file
+ *  @user_mainfw: User-defined main firmware file
- *  @param card_model   Bus-specific card model ID used to filter firmware table
+ *  @card_model: Bus-specific card model ID used to filter firmware table
- *                         elements
+ *              elements
- *  @param fw_table     Table of firmware file names and device model numbers
+ *  @fw_table:  Table of firmware file names and device model numbers
- *                         terminated by an entry with a NULL helper name
+ *              terminated by an entry with a NULL helper name
- *  @param helper       On success, the helper firmware; caller must free
+ *  @helper:    On success, the helper firmware; caller must free
- *  @param mainfw       On success, the main firmware; caller must free
+ *  @mainfw:    On success, the main firmware; caller must free
 *
- *  @return             0 on success, non-zero on failure
+ *  returns:            0 on success, non-zero on failure
 */
 int lbs_get_firmware(struct device *dev, const char *user_helper,
                        const char *user_mainfw, u32 card_model,
@@ -1087,16 +1082,16 @@ int lbs_get_firmware(struct device *dev, const char *user_helper,
        if (user_helper) {
                ret = request_firmware(helper, user_helper, dev);
                if (ret) {
-                        lbs_pr_err("couldn't find helper firmware %s",
+                        dev_err(dev, "couldn't find helper firmware %s\n",
-                                        user_helper);
+                                user_helper);
                        goto fail;
                }
        }
        if (user_mainfw) {
                ret = request_firmware(mainfw, user_mainfw, dev);
                if (ret) {
-                        lbs_pr_err("couldn't find main firmware %s",
+                        dev_err(dev, "couldn't find main firmware %s\n",
-                                        user_mainfw);
+                                user_mainfw);
                        goto fail;
                }
        }
diff --git a/drivers/net/wireless/libertas/mesh.c b/drivers/net/wireless/libertas/mesh.c
index 9d097b9c8005..24cf06680c6b 100644
--- a/drivers/net/wireless/libertas/mesh.c
+++ b/drivers/net/wireless/libertas/mesh.c
@@ -1,3 +1,5 @@
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #include <linux/delay.h>
 #include <linux/etherdevice.h>
 #include <linux/netdevice.h>
@@ -16,12 +18,15 @@
 * Mesh sysfs support
 */
-/**
+/*
 * Attributes exported through sysfs
 */
 /**
- * @brief Get function for sysfs attribute anycast_mask
+ * lbs_anycast_get - Get function for sysfs attribute anycast_mask
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer where data will be returned
 */
 static ssize_t lbs_anycast_get(struct device *dev,
                struct device_attribute *attr, char * buf)
@@ -40,7 +45,11 @@ static ssize_t lbs_anycast_get(struct device *dev,
 }
 /**
- * @brief Set function for sysfs attribute anycast_mask
+ * lbs_anycast_set - Set function for sysfs attribute anycast_mask
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer that contains new attribute value
+ * @count: size of buffer
 */
 static ssize_t lbs_anycast_set(struct device *dev,
                struct device_attribute *attr, const char * buf, size_t count)
@@ -62,7 +71,10 @@ static ssize_t lbs_anycast_set(struct device *dev,
 }
 /**
- * @brief Get function for sysfs attribute prb_rsp_limit
+ * lbs_prb_rsp_limit_get - Get function for sysfs attribute prb_rsp_limit
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer where data will be returned
 */
 static ssize_t lbs_prb_rsp_limit_get(struct device *dev,
                struct device_attribute *attr, char *buf)
@@ -85,7 +97,11 @@ static ssize_t lbs_prb_rsp_limit_get(struct device *dev,
 }
 /**
- * @brief Set function for sysfs attribute prb_rsp_limit
+ * lbs_prb_rsp_limit_set - Set function for sysfs attribute prb_rsp_limit
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer that contains new attribute value
+ * @count: size of buffer
 */
 static ssize_t lbs_prb_rsp_limit_set(struct device *dev,
                struct device_attribute *attr, const char *buf, size_t count)
@@ -114,7 +130,10 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev,
 }
 /**
- * Get function for sysfs attribute mesh
+ * lbs_mesh_get - Get function for sysfs attribute mesh
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer where data will be returned
 */
 static ssize_t lbs_mesh_get(struct device *dev,
                struct device_attribute *attr, char * buf)
@@ -124,7 +143,11 @@ static ssize_t lbs_mesh_get(struct device *dev,
 }
 /**
- *  Set function for sysfs attribute mesh
+ * lbs_mesh_set - Set function for sysfs attribute mesh
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer that contains new attribute value
+ * @count: size of buffer
 */
 static ssize_t lbs_mesh_set(struct device *dev,
                struct device_attribute *attr, const char * buf, size_t count)
@@ -151,19 +174,19 @@ static ssize_t lbs_mesh_set(struct device *dev,
        return count;
 }
-/**
+/*
 * lbs_mesh attribute to be exported per ethX interface
 * through sysfs (/sys/class/net/ethX/lbs_mesh)
 */
 static DEVICE_ATTR(lbs_mesh, 0644, lbs_mesh_get, lbs_mesh_set);
-/**
+/*
 * anycast_mask attribute to be exported per mshX interface
 * through sysfs (/sys/class/net/mshX/anycast_mask)
 */
 static DEVICE_ATTR(anycast_mask, 0644, lbs_anycast_get, lbs_anycast_set);
-/**
+/*
 * prb_rsp_limit attribute to be exported per mshX interface
 * through sysfs (/sys/class/net/mshX/prb_rsp_limit)
 */
@@ -246,7 +269,7 @@ int lbs_init_mesh(struct lbs_private *priv)
                lbs_add_mesh(priv);
                if (device_create_file(&dev->dev, &dev_attr_lbs_mesh))
-                        lbs_pr_err("cannot register lbs_mesh attribute\n");
+                        netdev_err(dev, "cannot register lbs_mesh attribute\n");
                ret = 1;
        }
@@ -274,10 +297,10 @@ int lbs_deinit_mesh(struct lbs_private *priv)
 /**
- *  @brief This function closes the mshX interface
+ * lbs_mesh_stop - close the mshX interface
 *
- *  @param dev     A pointer to net_device structure
+ * @dev:        A pointer to &net_device structure
- *  @return        0
+ * returns:     0
 */
 static int lbs_mesh_stop(struct net_device *dev)
 {
@@ -301,10 +324,10 @@ static int lbs_mesh_stop(struct net_device *dev)
 }
 /**
- *  @brief This function opens the mshX interface
+ * lbs_mesh_dev_open - open the mshX interface
 *
- *  @param dev     A pointer to net_device structure
+ * @dev:        A pointer to &net_device structure
- *  @return        0 or -EBUSY if monitor mode active
+ * returns:     0 or -EBUSY if monitor mode active
 */
 static int lbs_mesh_dev_open(struct net_device *dev)
 {
@@ -342,10 +365,10 @@ static const struct net_device_ops mesh_netdev_ops = {
 };
 /**
- * @brief This function adds mshX interface
+ * lbs_add_mesh - add mshX interface
 *
- *  @param priv    A pointer to the struct lbs_private structure
+ * @priv:       A pointer to the &struct lbs_private structure
- *  @return        0 if successful, -X otherwise
+ * returns:     0 if successful, -X otherwise
 */
 int lbs_add_mesh(struct lbs_private *priv)
 {
@@ -374,7 +397,7 @@ int lbs_add_mesh(struct lbs_private *priv)
        /* Register virtual mesh interface */
        ret = register_netdev(mesh_dev);
        if (ret) {
-                lbs_pr_err("cannot register mshX virtual interface\n");
+                pr_err("cannot register mshX virtual interface\n");
                goto err_free;
        }
@@ -456,13 +479,13 @@ void lbs_mesh_set_txpd(struct lbs_private *priv,
 */
 /**
- *  @brief Add or delete Mesh Blinding Table entries
+ * lbs_mesh_bt_add_del - Add or delete Mesh Blinding Table entries
 *
- *  @param priv         A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
- *  @param add          TRUE to add the entry, FALSE to delete it
+ * @add:        TRUE to add the entry, FALSE to delete it
- *  @param addr1        Destination address to blind or unblind
+ * @addr1:      Destination address to blind or unblind
 *
- *  @return             0 on success, error on failure
+ * returns:     0 on success, error on failure
 */
 int lbs_mesh_bt_add_del(struct lbs_private *priv, bool add, u8 *addr1)
 {
@@ -493,11 +516,11 @@ int lbs_mesh_bt_add_del(struct lbs_private *priv, bool add, u8 *addr1)
 }
 /**
- *  @brief Reset/clear the mesh blinding table
+ * lbs_mesh_bt_reset - Reset/clear the mesh blinding table
 *
- *  @param priv         A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
 *
- *  @return             0 on success, error on failure
+ * returns:     0 on success, error on failure
 */
 int lbs_mesh_bt_reset(struct lbs_private *priv)
 {
@@ -517,17 +540,18 @@ int lbs_mesh_bt_reset(struct lbs_private *priv)
 }
 /**
- *  @brief Gets the inverted status of the mesh blinding table
+ * lbs_mesh_bt_get_inverted - Gets the inverted status of the mesh
+ * blinding table
 *
- *  Normally the firmware "blinds" or ignores traffic from mesh nodes in the
+ * Normally the firmware "blinds" or ignores traffic from mesh nodes in the
- *  table, but an inverted table allows *only* traffic from nodes listed in
+ * table, but an inverted table allows *only* traffic from nodes listed in
- *  the table.
+ * the table.
 *
- *  @param priv         A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
- *  @param invert       On success, TRUE if the blinding table is inverted,
+ * @inverted:   On success, TRUE if the blinding table is inverted,
- *                        FALSE if it is not inverted
+ *              FALSE if it is not inverted
 *
- *  @return             0 on success, error on failure
+ * returns:     0 on success, error on failure
 */
 int lbs_mesh_bt_get_inverted(struct lbs_private *priv, bool *inverted)
 {
@@ -551,18 +575,19 @@ int lbs_mesh_bt_get_inverted(struct lbs_private *priv, bool *inverted)
 }
 /**
- *  @brief Sets the inverted status of the mesh blinding table
+ * lbs_mesh_bt_set_inverted - Sets the inverted status of the mesh
+ * blinding table
 *
- *  Normally the firmware "blinds" or ignores traffic from mesh nodes in the
+ * Normally the firmware "blinds" or ignores traffic from mesh nodes in the
- *  table, but an inverted table allows *only* traffic from nodes listed in
+ * table, but an inverted table allows *only* traffic from nodes listed in
- *  the table.
+ * the table.
 *
- *  @param priv         A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
- *  @param invert       TRUE to invert the blinding table (only traffic from
+ * @inverted:   TRUE to invert the blinding table (only traffic from
- *                         listed nodes allowed), FALSE to return it
+ *              listed nodes allowed), FALSE to return it
- *                         to normal state (listed nodes ignored)
+ *              to normal state (listed nodes ignored)
 *
- *  @return             0 on success, error on failure
+ * returns:     0 on success, error on failure
 */
 int lbs_mesh_bt_set_inverted(struct lbs_private *priv, bool inverted)
 {
@@ -583,13 +608,13 @@ int lbs_mesh_bt_set_inverted(struct lbs_private *priv, bool inverted)
 }
 /**
- *  @brief List an entry in the mesh blinding table
+ * lbs_mesh_bt_get_entry - List an entry in the mesh blinding table
 *
- *  @param priv         A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
- *  @param id           The ID of the entry to list
+ * @id:         The ID of the entry to list
- *  @param addr1        MAC address associated with the table entry
+ * @addr1:      MAC address associated with the table entry
 *
- *  @return             0 on success, error on failure
+ * returns:             0 on success, error on failure
 */
 int lbs_mesh_bt_get_entry(struct lbs_private *priv, u32 id, u8 *addr1)
 {
@@ -614,14 +639,14 @@ int lbs_mesh_bt_get_entry(struct lbs_private *priv, u32 id, u8 *addr1)
 }
 /**
- *  @brief Access the mesh forwarding table
+ * lbs_cmd_fwt_access - Access the mesh forwarding table
 *
- *  @param priv         A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
- *  @param cmd_action   The forwarding table action to perform
+ * @cmd_action: The forwarding table action to perform
- *  @param cmd          The pre-filled FWT_ACCESS command
+ * @cmd:        The pre-filled FWT_ACCESS command
 *
- *  @return             0 on success and 'cmd' will be filled with the
+ * returns:     0 on success and 'cmd' will be filled with the
- *                        firmware's response
+ *              firmware's response
 */
 int lbs_cmd_fwt_access(struct lbs_private *priv, u16 cmd_action,
                        struct cmd_ds_fwt_access *cmd)
@@ -774,7 +799,10 @@ static int mesh_get_default_parameters(struct device *dev,
 }
 /**
- * @brief Get function for sysfs attribute bootflag
+ * bootflag_get - Get function for sysfs attribute bootflag
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer where data will be returned
 */
 static ssize_t bootflag_get(struct device *dev,
                            struct device_attribute *attr, char *buf)
@@ -791,7 +819,11 @@ static ssize_t bootflag_get(struct device *dev,
 }
 /**
- * @brief Set function for sysfs attribute bootflag
+ * bootflag_set - Set function for sysfs attribute bootflag
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer that contains new attribute value
+ * @count: size of buffer
 */
 static ssize_t bootflag_set(struct device *dev, struct device_attribute *attr,
                            const char *buf, size_t count)
@@ -817,7 +849,10 @@ static ssize_t bootflag_set(struct device *dev, struct device_attribute *attr,
 }
 /**
- * @brief Get function for sysfs attribute boottime
+ * boottime_get - Get function for sysfs attribute boottime
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer where data will be returned
 */
 static ssize_t boottime_get(struct device *dev,
                            struct device_attribute *attr, char *buf)
@@ -834,7 +869,11 @@ static ssize_t boottime_get(struct device *dev,
 }
 /**
- * @brief Set function for sysfs attribute boottime
+ * boottime_set - Set function for sysfs attribute boottime
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer that contains new attribute value
+ * @count: size of buffer
 */
 static ssize_t boottime_set(struct device *dev,
                struct device_attribute *attr, const char *buf, size_t count)
@@ -869,7 +908,10 @@ static ssize_t boottime_set(struct device *dev,
 }
 /**
- * @brief Get function for sysfs attribute channel
+ * channel_get - Get function for sysfs attribute channel
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer where data will be returned
 */
 static ssize_t channel_get(struct device *dev,
                           struct device_attribute *attr, char *buf)
@@ -886,7 +928,11 @@ static ssize_t channel_get(struct device *dev,
 }
 /**
- * @brief Set function for sysfs attribute channel
+ * channel_set - Set function for sysfs attribute channel
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer that contains new attribute value
+ * @count: size of buffer
 */
 static ssize_t channel_set(struct device *dev, struct device_attribute *attr,
                           const char *buf, size_t count)
@@ -912,7 +958,10 @@ static ssize_t channel_set(struct device *dev, struct device_attribute *attr,
 }
 /**
- * @brief Get function for sysfs attribute mesh_id
+ * mesh_id_get - Get function for sysfs attribute mesh_id
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer where data will be returned
 */
 static ssize_t mesh_id_get(struct device *dev, struct device_attribute *attr,
                           char *buf)
@@ -926,7 +975,7 @@ static ssize_t mesh_id_get(struct device *dev, struct device_attribute *attr,
                return ret;
        if (defs.meshie.val.mesh_id_len > IEEE80211_MAX_SSID_LEN) {
-                lbs_pr_err("inconsistent mesh ID length");
+                dev_err(dev, "inconsistent mesh ID length\n");
                defs.meshie.val.mesh_id_len = IEEE80211_MAX_SSID_LEN;
        }
@@ -938,7 +987,11 @@ static ssize_t mesh_id_get(struct device *dev, struct device_attribute *attr,
 }
 /**
- * @brief Set function for sysfs attribute mesh_id
+ * mesh_id_set - Set function for sysfs attribute mesh_id
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer that contains new attribute value
+ * @count: size of buffer
 */
 static ssize_t mesh_id_set(struct device *dev, struct device_attribute *attr,
                           const char *buf, size_t count)
@@ -980,7 +1033,10 @@ static ssize_t mesh_id_set(struct device *dev, struct device_attribute *attr,
 }
 /**
- * @brief Get function for sysfs attribute protocol_id
+ * protocol_id_get - Get function for sysfs attribute protocol_id
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer where data will be returned
 */
 static ssize_t protocol_id_get(struct device *dev,
                               struct device_attribute *attr, char *buf)
@@ -997,7 +1053,11 @@ static ssize_t protocol_id_get(struct device *dev,
 }
 /**
- * @brief Set function for sysfs attribute protocol_id
+ * protocol_id_set - Set function for sysfs attribute protocol_id
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer that contains new attribute value
+ * @count: size of buffer
 */
 static ssize_t protocol_id_set(struct device *dev,
                struct device_attribute *attr, const char *buf, size_t count)
@@ -1034,7 +1094,10 @@ static ssize_t protocol_id_set(struct device *dev,
 }
 /**
- * @brief Get function for sysfs attribute metric_id
+ * metric_id_get - Get function for sysfs attribute metric_id
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer where data will be returned
 */
 static ssize_t metric_id_get(struct device *dev,
                struct device_attribute *attr, char *buf)
@@ -1051,7 +1114,11 @@ static ssize_t metric_id_get(struct device *dev,
 }
 /**
- * @brief Set function for sysfs attribute metric_id
+ * metric_id_set - Set function for sysfs attribute metric_id
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer that contains new attribute value
+ * @count: size of buffer
 */
 static ssize_t metric_id_set(struct device *dev, struct device_attribute *attr,
                             const char *buf, size_t count)
@@ -1088,7 +1155,10 @@ static ssize_t metric_id_set(struct device *dev, struct device_attribute *attr,
 }
 /**
- * @brief Get function for sysfs attribute capability
+ * capability_get - Get function for sysfs attribute capability
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer where data will be returned
 */
 static ssize_t capability_get(struct device *dev,
                struct device_attribute *attr, char *buf)
@@ -1105,7 +1175,11 @@ static ssize_t capability_get(struct device *dev,
 }
 /**
- * @brief Set function for sysfs attribute capability
+ * capability_set - Set function for sysfs attribute capability
+ * @dev: the &struct device
+ * @attr: device attributes
+ * @buf: buffer that contains new attribute value
+ * @count: size of buffer
 */
 static ssize_t capability_set(struct device *dev, struct device_attribute *attr,
                              const char *buf, size_t count)
diff --git a/drivers/net/wireless/libertas/mesh.h b/drivers/net/wireless/libertas/mesh.h
index afb2e8dead3f..ee95c73ed5f4 100644
--- a/drivers/net/wireless/libertas/mesh.h
+++ b/drivers/net/wireless/libertas/mesh.h
@@ -1,6 +1,6 @@
-/**
+/*
-  * Contains all definitions needed for the Libertas' MESH implementation.
+ * Contains all definitions needed for the Libertas' MESH implementation.
-  */
+ */
 #ifndef _LBS_MESH_H_
 #define _LBS_MESH_H_
diff --git a/drivers/net/wireless/libertas/rx.c b/drivers/net/wireless/libertas/rx.c
index a2b1df21d286..fdb0448301a0 100644
--- a/drivers/net/wireless/libertas/rx.c
+++ b/drivers/net/wireless/libertas/rx.c
@@ -1,6 +1,9 @@
-/**
+/*
-  * This file contains the handling of RX in wlan driver.
+ * This file contains the handling of RX in wlan driver.
-  */
+ */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 #include <linux/etherdevice.h>
 #include <linux/slab.h>
 #include <linux/types.h>
@@ -40,12 +43,12 @@ static int process_rxed_802_11_packet(struct lbs_private *priv,
        struct sk_buff *skb);
 /**
- *  @brief This function processes received packet and forwards it
+ * lbs_process_rxed_packet - processes received packet and forwards it
- *  to kernel/upper layer
+ * to kernel/upper layer
 *
- *  @param      priv    A pointer to struct lbs_private
+ * @priv:       A pointer to &struct lbs_private
- *  @param      skb             A pointer to skb which includes the received packet
+ * @skb:        A pointer to skb which includes the received packet
- *  @return     0 or -1
+ * returns:     0 or -1
 */
 int lbs_process_rxed_packet(struct lbs_private *priv, struct sk_buff *skb)
 {
@@ -156,11 +159,11 @@ done:
 EXPORT_SYMBOL_GPL(lbs_process_rxed_packet);
 /**
- *  @brief This function converts Tx/Rx rates from the Marvell WLAN format
+ * convert_mv_rate_to_radiotap - converts Tx/Rx rates from Marvell WLAN format
- *  (see Table 2 in Section 3.1) to IEEE80211_RADIOTAP_RATE units (500 Kb/s)
+ * (see Table 2 in Section 3.1) to IEEE80211_RADIOTAP_RATE units (500 Kb/s)
 *
- *  @param      rate    Input rate
+ * @rate:       Input rate
- *  @return     Output Rate (0 if invalid)
+ * returns:     Output Rate (0 if invalid)
 */
 static u8 convert_mv_rate_to_radiotap(u8 rate)
 {
@@ -191,17 +194,17 @@ static u8 convert_mv_rate_to_radiotap(u8 rate)
        case 12:                /*  54 Mbps */
                return 108;
        }
-        lbs_pr_alert("Invalid Marvell WLAN rate %i\n", rate);
+        pr_alert("Invalid Marvell WLAN rate %i\n", rate);
        return 0;
 }
 /**
- *  @brief This function processes a received 802.11 packet and forwards it
+ * process_rxed_802_11_packet - processes a received 802.11 packet and forwards
- *  to kernel/upper layer
+ * it to kernel/upper layer
 *
- *  @param      priv    A pointer to struct lbs_private
+ * @priv:       A pointer to &struct lbs_private
- *  @param      skb             A pointer to skb which includes the received packet
+ * @skb:        A pointer to skb which includes the received packet
- *  @return     0 or -1
+ * returns:     0 or -1
 */
 static int process_rxed_802_11_packet(struct lbs_private *priv,
        struct sk_buff *skb)
@@ -248,7 +251,7 @@ static int process_rxed_802_11_packet(struct lbs_private *priv,
        /* add space for the new radio header */
        if ((skb_headroom(skb) < sizeof(struct rx_radiotap_hdr)) &&
            pskb_expand_head(skb, sizeof(struct rx_radiotap_hdr), 0, GFP_ATOMIC)) {
-                lbs_pr_alert("%s: couldn't pskb_expand_head\n", __func__);
+                netdev_alert(dev, "%s: couldn't pskb_expand_head\n", __func__);
                ret = -ENOMEM;
                kfree_skb(skb);
                goto done;
diff --git a/drivers/net/wireless/libertas/tx.c b/drivers/net/wireless/libertas/tx.c
index 8000ca6165d0..bbb95f88dc01 100644
--- a/drivers/net/wireless/libertas/tx.c
+++ b/drivers/net/wireless/libertas/tx.c
@@ -1,6 +1,6 @@
-/**
+/*
-  * This file contains the handling of TX in wlan driver.
+ * This file contains the handling of TX in wlan driver.
-  */
+ */
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
 #include <linux/sched.h>
@@ -13,11 +13,11 @@
 #include "dev.h"
 /**
- *  @brief This function converts Tx/Rx rates from IEEE80211_RADIOTAP_RATE
+ * convert_radiotap_rate_to_mv - converts Tx/Rx rates from IEEE80211_RADIOTAP_RATE
- *  units (500 Kb/s) into Marvell WLAN format (see Table 8 in Section 3.2.1)
+ * units (500 Kb/s) into Marvell WLAN format (see Table 8 in Section 3.2.1)
 *
- *  @param rate    Input rate
+ * @rate:       Input rate
- *  @return      Output Rate (0 if invalid)
+ * returns:     Output Rate (0 if invalid)
 */
 static u32 convert_radiotap_rate_to_mv(u8 rate)
 {
@@ -51,12 +51,12 @@ static u32 convert_radiotap_rate_to_mv(u8 rate)
 }
 /**
- *  @brief This function checks the conditions and sends packet to IF
+ * lbs_hard_start_xmit - checks the conditions and sends packet to IF
- *  layer if everything is ok.
+ * layer if everything is ok
 *
- *  @param priv    A pointer to struct lbs_private structure
+ * @skb:        A pointer to skb which includes TX packet
- *  @param skb     A pointer to skb which includes TX packet
+ * @dev:        A pointer to the &struct net_device
- *  @return        0 or -1
+ * returns:     0 or -1
 */
 netdev_tx_t lbs_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 {
@@ -168,13 +168,13 @@ netdev_tx_t lbs_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 }
 /**
- *  @brief This function sends to the host the last transmitted packet,
+ * lbs_send_tx_feedback - sends to the host the last transmitted packet,
- *  filling the radiotap headers with transmission information.
+ * filling the radiotap headers with transmission information.
 *
- *  @param priv     A pointer to struct lbs_private structure
+ * @priv:       A pointer to &struct lbs_private structure
- *  @param status   A 32 bit value containing transmission status.
+ * @try_count:  A 32-bit value containing transmission retry status.
 *
- *  @returns void
+ * returns:     void
 */
 void lbs_send_tx_feedback(struct lbs_private *priv, u32 try_count)
 {
diff --git a/drivers/net/wireless/libertas/types.h b/drivers/net/wireless/libertas/types.h
index 462fbb4cb743..cf1d9b047ee6 100644
--- a/drivers/net/wireless/libertas/types.h
+++ b/drivers/net/wireless/libertas/types.h
@@ -1,6 +1,6 @@
-/**
+/*
-  * This header file contains definition for global types
+ * This header file contains definition for global types
-  */
+ */
 #ifndef _LBS_TYPES_H_
 #define _LBS_TYPES_H_
@@ -54,7 +54,7 @@ union ieee_phy_param_set {
        struct ieee_ie_ds_param_set ds;
 } __packed;
-/** TLV  type ID definition */
+/* TLV  type ID definition */
 #define PROPRIETARY_TLV_BASE_ID         0x0100
 /* Terminating TLV type */
@@ -96,7 +96,7 @@ union ieee_phy_param_set {
 #define TLV_TYPE_MESH_ID            (PROPRIETARY_TLV_BASE_ID + 37)
 #define TLV_TYPE_OLD_MESH_ID        (PROPRIETARY_TLV_BASE_ID + 291)
-/** TLV related data structures*/
+/* TLV related data structures */
 struct mrvl_ie_header {
        __le16 type;
        __le16 len;
@@ -177,7 +177,7 @@ struct mrvl_ie_auth_type {
        __le16 auth;
 } __packed;
-/**  Local Power capability */
+/*  Local Power capability */
 struct mrvl_ie_power_capability {
        struct mrvl_ie_header header;
        s8 minpower;
@@ -235,9 +235,11 @@ struct mrvl_ie_ledbhv {
        struct led_bhv ledbhv[1];
 } __packed;
-/* Meant to be packed as the value member of a struct ieee80211_info_element.
+/*
+ * Meant to be packed as the value member of a struct ieee80211_info_element.
 * Note that the len member of the ieee80211_info_element varies depending on
- * the mesh_id_len */
+ * the mesh_id_len
+ */
 struct mrvl_meshie_val {
        uint8_t oui[3];
        uint8_t type;
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index f4f4257a9d67..9d4a40ee16c4 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -1515,19 +1515,10 @@ static int __init init_mac80211_hwsim(void)
        if (hwsim_mon == NULL)
                goto failed;
-        rtnl_lock();
+        err = register_netdev(hwsim_mon);
-        err = dev_alloc_name(hwsim_mon, hwsim_mon->name);
        if (err < 0)
                goto failed_mon;
-        err = register_netdevice(hwsim_mon);
-        if (err < 0)
-                goto failed_mon;
-        rtnl_unlock();
        return 0;
 failed_mon:
diff --git a/drivers/net/wireless/mwifiex/11n.c b/drivers/net/wireless/mwifiex/11n.c
new file mode 100644
index 000000000000..916183d39009
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/11n.c
@@ -0,0 +1,744 @@
+/*
+ * Marvell Wireless LAN device driver: 802.11n
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+/*
+ * Fills HT capability information field, AMPDU Parameters field, HT extended
+ * capability field, and supported MCS set fields.
+ *
+ * HT capability information field, AMPDU Parameters field, supported MCS set
+ * fields are retrieved from cfg80211 stack
+ *
+ * RD responder bit to set to clear in the extended capability header.
+ */
+void
+mwifiex_fill_cap_info(struct mwifiex_private *priv, u8 radio_type,
+                      struct mwifiex_ie_types_htcap *ht_cap)
+{
+        uint16_t ht_ext_cap = le16_to_cpu(ht_cap->ht_cap.extended_ht_cap_info);
+        struct ieee80211_supported_band *sband =
+                                        priv->wdev->wiphy->bands[radio_type];
+        ht_cap->ht_cap.ampdu_params_info =
+                (sband->ht_cap.ampdu_factor &
+                 IEEE80211_HT_AMPDU_PARM_FACTOR)|
+                ((sband->ht_cap.ampdu_density <<
+                 IEEE80211_HT_AMPDU_PARM_DENSITY_SHIFT) &
+                 IEEE80211_HT_AMPDU_PARM_DENSITY);
+        memcpy((u8 *) &ht_cap->ht_cap.mcs, &sband->ht_cap.mcs,
+                                                sizeof(sband->ht_cap.mcs));
+        if (priv->bss_mode == NL80211_IFTYPE_STATION ||
+                        (sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40))
+                /* Set MCS32 for infra mode or ad-hoc mode with 40MHz support */
+                SETHT_MCS32(ht_cap->ht_cap.mcs.rx_mask);
+        /* Clear RD responder bit */
+        ht_ext_cap &= ~IEEE80211_HT_EXT_CAP_RD_RESPONDER;
+        ht_cap->ht_cap.cap_info = cpu_to_le16(sband->ht_cap.cap);
+        ht_cap->ht_cap.extended_ht_cap_info = cpu_to_le16(ht_ext_cap);
+}
+/*
+ * This function returns the pointer to an entry in BA Stream
+ * table which matches the requested BA status.
+ */
+static struct mwifiex_tx_ba_stream_tbl *
+mwifiex_11n_get_tx_ba_stream_status(struct mwifiex_private *priv,
+                                  enum mwifiex_ba_status ba_status)
+{
+        struct mwifiex_tx_ba_stream_tbl *tx_ba_tsr_tbl;
+        unsigned long flags;
+        spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags);
+        list_for_each_entry(tx_ba_tsr_tbl, &priv->tx_ba_stream_tbl_ptr, list) {
+                if (tx_ba_tsr_tbl->ba_status == ba_status) {
+                        spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock,
+                                               flags);
+                        return tx_ba_tsr_tbl;
+                }
+        }
+        spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock, flags);
+        return NULL;
+}
+/*
+ * This function handles the command response of delete a block
+ * ack request.
+ *
+ * The function checks the response success status and takes action
+ * accordingly (send an add BA request in case of success, or recreate
+ * the deleted stream in case of failure, if the add BA was also
+ * initiated by us).
+ */
+int mwifiex_ret_11n_delba(struct mwifiex_private *priv,
+                          struct host_cmd_ds_command *resp)
+{
+        int tid;
+        struct mwifiex_tx_ba_stream_tbl *tx_ba_tbl;
+        struct host_cmd_ds_11n_delba *del_ba =
+                (struct host_cmd_ds_11n_delba *) &resp->params.del_ba;
+        uint16_t del_ba_param_set = le16_to_cpu(del_ba->del_ba_param_set);
+        tid = del_ba_param_set >> DELBA_TID_POS;
+        if (del_ba->del_result == BA_RESULT_SUCCESS) {
+                mwifiex_11n_delete_ba_stream_tbl(priv, tid,
+                                del_ba->peer_mac_addr, TYPE_DELBA_SENT,
+                                INITIATOR_BIT(del_ba_param_set));
+                tx_ba_tbl = mwifiex_11n_get_tx_ba_stream_status(priv,
+                                                BA_STREAM_SETUP_INPROGRESS);
+                if (tx_ba_tbl)
+                        mwifiex_send_addba(priv, tx_ba_tbl->tid,
+                                           tx_ba_tbl->ra);
+        } else { /*
+                  * In case of failure, recreate the deleted stream in case
+                  * we initiated the ADDBA
+                  */
+                if (INITIATOR_BIT(del_ba_param_set)) {
+                        mwifiex_11n_create_tx_ba_stream_tbl(priv,
+                                        del_ba->peer_mac_addr, tid,
+                                        BA_STREAM_SETUP_INPROGRESS);
+                        tx_ba_tbl = mwifiex_11n_get_tx_ba_stream_status(priv,
+                                        BA_STREAM_SETUP_INPROGRESS);
+                        if (tx_ba_tbl)
+                                mwifiex_11n_delete_ba_stream_tbl(priv,
+                                                tx_ba_tbl->tid, tx_ba_tbl->ra,
+                                                TYPE_DELBA_SENT, true);
+                }
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of add a block
+ * ack request.
+ *
+ * Handling includes changing the header fields to CPU formats, checking
+ * the response success status and taking actions accordingly (delete the
+ * BA stream table in case of failure).
+ */
+int mwifiex_ret_11n_addba_req(struct mwifiex_private *priv,
+                              struct host_cmd_ds_command *resp)
+{
+        int tid;
+        struct host_cmd_ds_11n_addba_rsp *add_ba_rsp =
+                (struct host_cmd_ds_11n_addba_rsp *) &resp->params.add_ba_rsp;
+        struct mwifiex_tx_ba_stream_tbl *tx_ba_tbl;
+        add_ba_rsp->ssn = cpu_to_le16((le16_to_cpu(add_ba_rsp->ssn))
+                        & SSN_MASK);
+        tid = (le16_to_cpu(add_ba_rsp->block_ack_param_set)
+                & IEEE80211_ADDBA_PARAM_TID_MASK)
+                >> BLOCKACKPARAM_TID_POS;
+        if (le16_to_cpu(add_ba_rsp->status_code) == BA_RESULT_SUCCESS) {
+                tx_ba_tbl = mwifiex_11n_get_tx_ba_stream_tbl(priv, tid,
+                                                add_ba_rsp->peer_mac_addr);
+                if (tx_ba_tbl) {
+                        dev_dbg(priv->adapter->dev, "info: BA stream complete\n");
+                        tx_ba_tbl->ba_status = BA_STREAM_SETUP_COMPLETE;
+                } else {
+                        dev_err(priv->adapter->dev, "BA stream not created\n");
+                }
+        } else {
+                mwifiex_11n_delete_ba_stream_tbl(priv, tid,
+                                                add_ba_rsp->peer_mac_addr,
+                                                TYPE_DELBA_SENT, true);
+                if (add_ba_rsp->add_rsp_result != BA_RESULT_TIMEOUT)
+                        priv->aggr_prio_tbl[tid].ampdu_ap =
+                                BA_STREAM_NOT_ALLOWED;
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of 11n configuration request.
+ *
+ * Handling includes changing the header fields into CPU format.
+ */
+int mwifiex_ret_11n_cfg(struct host_cmd_ds_command *resp, void *data_buf)
+{
+        struct mwifiex_ds_11n_tx_cfg *tx_cfg;
+        struct host_cmd_ds_11n_cfg *htcfg = &resp->params.htcfg;
+        if (data_buf) {
+                tx_cfg = (struct mwifiex_ds_11n_tx_cfg *) data_buf;
+                tx_cfg->tx_htcap = le16_to_cpu(htcfg->ht_tx_cap);
+                tx_cfg->tx_htinfo = le16_to_cpu(htcfg->ht_tx_info);
+        }
+        return 0;
+}
+/*
+ * This function prepares command of reconfigure Tx buffer.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting Tx buffer size (for SET only)
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_recfg_tx_buf(struct mwifiex_private *priv,
+                             struct host_cmd_ds_command *cmd, int cmd_action,
+                             void *data_buf)
+{
+        struct host_cmd_ds_txbuf_cfg *tx_buf = &cmd->params.tx_buf;
+        u16 action = (u16) cmd_action;
+        u16 buf_size = *((u16 *) data_buf);
+        cmd->command = cpu_to_le16(HostCmd_CMD_RECONFIGURE_TX_BUFF);
+        cmd->size =
+                cpu_to_le16(sizeof(struct host_cmd_ds_txbuf_cfg) + S_DS_GEN);
+        tx_buf->action = cpu_to_le16(action);
+        switch (action) {
+        case HostCmd_ACT_GEN_SET:
+                dev_dbg(priv->adapter->dev, "cmd: set tx_buf=%d\n", buf_size);
+                tx_buf->buff_size = cpu_to_le16(buf_size);
+                break;
+        case HostCmd_ACT_GEN_GET:
+        default:
+                tx_buf->buff_size = 0;
+                break;
+        }
+        return 0;
+}
+/*
+ * This function prepares command of AMSDU aggregation control.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting AMSDU control parameters (for SET only)
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_amsdu_aggr_ctrl(struct host_cmd_ds_command *cmd,
+                                int cmd_action, void *data_buf)
+{
+        struct host_cmd_ds_amsdu_aggr_ctrl *amsdu_ctrl =
+                &cmd->params.amsdu_aggr_ctrl;
+        u16 action = (u16) cmd_action;
+        struct mwifiex_ds_11n_amsdu_aggr_ctrl *aa_ctrl =
+                (struct mwifiex_ds_11n_amsdu_aggr_ctrl *) data_buf;
+        cmd->command = cpu_to_le16(HostCmd_CMD_AMSDU_AGGR_CTRL);
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_amsdu_aggr_ctrl)
+                                + S_DS_GEN);
+        amsdu_ctrl->action = cpu_to_le16(action);
+        switch (action) {
+        case HostCmd_ACT_GEN_SET:
+                amsdu_ctrl->enable = cpu_to_le16(aa_ctrl->enable);
+                amsdu_ctrl->curr_buf_size = 0;
+                break;
+        case HostCmd_ACT_GEN_GET:
+        default:
+                amsdu_ctrl->curr_buf_size = 0;
+                break;
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of AMSDU aggregation
+ * control request.
+ *
+ * Handling includes changing the header fields into CPU format.
+ */
+int mwifiex_ret_amsdu_aggr_ctrl(struct host_cmd_ds_command *resp,
+                                void *data_buf)
+{
+        struct mwifiex_ds_11n_amsdu_aggr_ctrl *amsdu_aggr_ctrl;
+        struct host_cmd_ds_amsdu_aggr_ctrl *amsdu_ctrl =
+                &resp->params.amsdu_aggr_ctrl;
+        if (data_buf) {
+                amsdu_aggr_ctrl =
+                        (struct mwifiex_ds_11n_amsdu_aggr_ctrl *) data_buf;
+                amsdu_aggr_ctrl->enable = le16_to_cpu(amsdu_ctrl->enable);
+                amsdu_aggr_ctrl->curr_buf_size =
+                        le16_to_cpu(amsdu_ctrl->curr_buf_size);
+        }
+        return 0;
+}
+/*
+ * This function prepares 11n configuration command.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting HT Tx capability and HT Tx information fields
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_11n_cfg(struct host_cmd_ds_command *cmd,
+                        u16 cmd_action, void *data_buf)
+{
+        struct host_cmd_ds_11n_cfg *htcfg = &cmd->params.htcfg;
+        struct mwifiex_ds_11n_tx_cfg *txcfg =
+                (struct mwifiex_ds_11n_tx_cfg *) data_buf;
+        cmd->command = cpu_to_le16(HostCmd_CMD_11N_CFG);
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_11n_cfg) + S_DS_GEN);
+        htcfg->action = cpu_to_le16(cmd_action);
+        htcfg->ht_tx_cap = cpu_to_le16(txcfg->tx_htcap);
+        htcfg->ht_tx_info = cpu_to_le16(txcfg->tx_htinfo);
+        return 0;
+}
+/*
+ * This function appends an 11n TLV to a buffer.
+ *
+ * Buffer allocation is responsibility of the calling
+ * function. No size validation is made here.
+ *
+ * The function fills up the following sections, if applicable -
+ *      - HT capability IE
+ *      - HT information IE (with channel list)
+ *      - 20/40 BSS Coexistence IE
+ *      - HT Extended Capabilities IE
+ */
+int
+mwifiex_cmd_append_11n_tlv(struct mwifiex_private *priv,
+                           struct mwifiex_bssdescriptor *bss_desc,
+                           u8 **buffer)
+{
+        struct mwifiex_ie_types_htcap *ht_cap;
+        struct mwifiex_ie_types_htinfo *ht_info;
+        struct mwifiex_ie_types_chan_list_param_set *chan_list;
+        struct mwifiex_ie_types_2040bssco *bss_co_2040;
+        struct mwifiex_ie_types_extcap *ext_cap;
+        int ret_len = 0;
+        struct ieee80211_supported_band *sband;
+        u8 radio_type;
+        if (!buffer || !*buffer)
+                return ret_len;
+        radio_type = mwifiex_band_to_radio_type((u8) bss_desc->bss_band);
+        sband = priv->wdev->wiphy->bands[radio_type];
+        if (bss_desc->bcn_ht_cap) {
+                ht_cap = (struct mwifiex_ie_types_htcap *) *buffer;
+                memset(ht_cap, 0, sizeof(struct mwifiex_ie_types_htcap));
+                ht_cap->header.type = cpu_to_le16(WLAN_EID_HT_CAPABILITY);
+                ht_cap->header.len =
+                                cpu_to_le16(sizeof(struct ieee80211_ht_cap));
+                memcpy((u8 *) ht_cap + sizeof(struct mwifiex_ie_types_header),
+                       (u8 *) bss_desc->bcn_ht_cap +
+                       sizeof(struct ieee_types_header),
+                       le16_to_cpu(ht_cap->header.len));
+                mwifiex_fill_cap_info(priv, radio_type, ht_cap);
+                *buffer += sizeof(struct mwifiex_ie_types_htcap);
+                ret_len += sizeof(struct mwifiex_ie_types_htcap);
+        }
+        if (bss_desc->bcn_ht_info) {
+                if (priv->bss_mode == NL80211_IFTYPE_ADHOC) {
+                        ht_info = (struct mwifiex_ie_types_htinfo *) *buffer;
+                        memset(ht_info, 0,
+                               sizeof(struct mwifiex_ie_types_htinfo));
+                        ht_info->header.type =
+                                        cpu_to_le16(WLAN_EID_HT_INFORMATION);
+                        ht_info->header.len =
+                                cpu_to_le16(sizeof(struct ieee80211_ht_info));
+                        memcpy((u8 *) ht_info +
+                               sizeof(struct mwifiex_ie_types_header),
+                               (u8 *) bss_desc->bcn_ht_info +
+                               sizeof(struct ieee_types_header),
+                               le16_to_cpu(ht_info->header.len));
+                        if (!(sband->ht_cap.cap &
+                                        IEEE80211_HT_CAP_SUP_WIDTH_20_40))
+                                ht_info->ht_info.ht_param &=
+                                        ~(IEEE80211_HT_PARAM_CHAN_WIDTH_ANY |
+                                        IEEE80211_HT_PARAM_CHA_SEC_OFFSET);
+                        *buffer += sizeof(struct mwifiex_ie_types_htinfo);
+                        ret_len += sizeof(struct mwifiex_ie_types_htinfo);
+                }
+                chan_list =
+                        (struct mwifiex_ie_types_chan_list_param_set *) *buffer;
+                memset(chan_list, 0,
+                       sizeof(struct mwifiex_ie_types_chan_list_param_set));
+                chan_list->header.type = cpu_to_le16(TLV_TYPE_CHANLIST);
+                chan_list->header.len = cpu_to_le16(
+                        sizeof(struct mwifiex_ie_types_chan_list_param_set) -
+                        sizeof(struct mwifiex_ie_types_header));
+                chan_list->chan_scan_param[0].chan_number =
+                        bss_desc->bcn_ht_info->control_chan;
+                chan_list->chan_scan_param[0].radio_type =
+                        mwifiex_band_to_radio_type((u8) bss_desc->bss_band);
+                if ((sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40)
+                        && (bss_desc->bcn_ht_info->ht_param &
+                                IEEE80211_HT_PARAM_CHAN_WIDTH_ANY))
+                        SET_SECONDARYCHAN(chan_list->chan_scan_param[0].
+                                          radio_type,
+                                          (bss_desc->bcn_ht_info->ht_param &
+                                          IEEE80211_HT_PARAM_CHA_SEC_OFFSET));
+                *buffer += sizeof(struct mwifiex_ie_types_chan_list_param_set);
+                ret_len += sizeof(struct mwifiex_ie_types_chan_list_param_set);
+        }
+        if (bss_desc->bcn_bss_co_2040) {
+                bss_co_2040 = (struct mwifiex_ie_types_2040bssco *) *buffer;
+                memset(bss_co_2040, 0,
+                       sizeof(struct mwifiex_ie_types_2040bssco));
+                bss_co_2040->header.type = cpu_to_le16(WLAN_EID_BSS_COEX_2040);
+                bss_co_2040->header.len =
+                       cpu_to_le16(sizeof(bss_co_2040->bss_co_2040));
+                memcpy((u8 *) bss_co_2040 +
+                       sizeof(struct mwifiex_ie_types_header),
+                       (u8 *) bss_desc->bcn_bss_co_2040 +
+                       sizeof(struct ieee_types_header),
+                       le16_to_cpu(bss_co_2040->header.len));
+                *buffer += sizeof(struct mwifiex_ie_types_2040bssco);
+                ret_len += sizeof(struct mwifiex_ie_types_2040bssco);
+        }
+        if (bss_desc->bcn_ext_cap) {
+                ext_cap = (struct mwifiex_ie_types_extcap *) *buffer;
+                memset(ext_cap, 0, sizeof(struct mwifiex_ie_types_extcap));
+                ext_cap->header.type = cpu_to_le16(WLAN_EID_EXT_CAPABILITY);
+                ext_cap->header.len = cpu_to_le16(sizeof(ext_cap->ext_cap));
+                memcpy((u8 *) ext_cap +
+                       sizeof(struct mwifiex_ie_types_header),
+                       (u8 *) bss_desc->bcn_ext_cap +
+                       sizeof(struct ieee_types_header),
+                       le16_to_cpu(ext_cap->header.len));
+                *buffer += sizeof(struct mwifiex_ie_types_extcap);
+                ret_len += sizeof(struct mwifiex_ie_types_extcap);
+        }
+        return ret_len;
+}
+/*
+ * This function reconfigures the Tx buffer size in firmware.
+ *
+ * This function prepares a firmware command and issues it, if
+ * the current Tx buffer size is different from the one requested.
+ * Maximum configurable Tx buffer size is limited by the HT capability
+ * field value.
+ */
+void
+mwifiex_cfg_tx_buf(struct mwifiex_private *priv,
+                   struct mwifiex_bssdescriptor *bss_desc)
+{
+        u16 max_amsdu = MWIFIEX_TX_DATA_BUF_SIZE_2K;
+        u16 tx_buf, curr_tx_buf_size = 0;
+        if (bss_desc->bcn_ht_cap) {
+                if (le16_to_cpu(bss_desc->bcn_ht_cap->cap_info) &
+                                IEEE80211_HT_CAP_MAX_AMSDU)
+                        max_amsdu = MWIFIEX_TX_DATA_BUF_SIZE_8K;
+                else
+                        max_amsdu = MWIFIEX_TX_DATA_BUF_SIZE_4K;
+        }
+        tx_buf = min(priv->adapter->max_tx_buf_size, max_amsdu);
+        dev_dbg(priv->adapter->dev, "info: max_amsdu=%d, max_tx_buf=%d\n",
+                        max_amsdu, priv->adapter->max_tx_buf_size);
+        if (priv->adapter->curr_tx_buf_size <= MWIFIEX_TX_DATA_BUF_SIZE_2K)
+                curr_tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_2K;
+        else if (priv->adapter->curr_tx_buf_size <= MWIFIEX_TX_DATA_BUF_SIZE_4K)
+                curr_tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_4K;
+        else if (priv->adapter->curr_tx_buf_size <= MWIFIEX_TX_DATA_BUF_SIZE_8K)
+                curr_tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_8K;
+        if (curr_tx_buf_size != tx_buf)
+                mwifiex_send_cmd_async(priv, HostCmd_CMD_RECONFIGURE_TX_BUFF,
+                                       HostCmd_ACT_GEN_SET, 0, &tx_buf);
+}
+/*
+ * This function checks if the given pointer is valid entry of
+ * Tx BA Stream table.
+ */
+static int mwifiex_is_tx_ba_stream_ptr_valid(struct mwifiex_private *priv,
+                                struct mwifiex_tx_ba_stream_tbl *tx_tbl_ptr)
+{
+        struct mwifiex_tx_ba_stream_tbl *tx_ba_tsr_tbl;
+        list_for_each_entry(tx_ba_tsr_tbl, &priv->tx_ba_stream_tbl_ptr, list) {
+                if (tx_ba_tsr_tbl == tx_tbl_ptr)
+                        return true;
+        }
+        return false;
+}
+/*
+ * This function deletes the given entry in Tx BA Stream table.
+ *
+ * The function also performs a validity check on the supplied
+ * pointer before trying to delete.
+ */
+void mwifiex_11n_delete_tx_ba_stream_tbl_entry(struct mwifiex_private *priv,
+                                struct mwifiex_tx_ba_stream_tbl *tx_ba_tsr_tbl)
+{
+        if (!tx_ba_tsr_tbl &&
+                        mwifiex_is_tx_ba_stream_ptr_valid(priv, tx_ba_tsr_tbl))
+                return;
+        dev_dbg(priv->adapter->dev, "info: tx_ba_tsr_tbl %p\n", tx_ba_tsr_tbl);
+        list_del(&tx_ba_tsr_tbl->list);
+        kfree(tx_ba_tsr_tbl);
+}
+/*
+ * This function deletes all the entries in Tx BA Stream table.
+ */
+void mwifiex_11n_delete_all_tx_ba_stream_tbl(struct mwifiex_private *priv)
+{
+        int i;
+        struct mwifiex_tx_ba_stream_tbl *del_tbl_ptr, *tmp_node;
+        unsigned long flags;
+        spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags);
+        list_for_each_entry_safe(del_tbl_ptr, tmp_node,
+                                 &priv->tx_ba_stream_tbl_ptr, list)
+                mwifiex_11n_delete_tx_ba_stream_tbl_entry(priv, del_tbl_ptr);
+        spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock, flags);
+        INIT_LIST_HEAD(&priv->tx_ba_stream_tbl_ptr);
+        for (i = 0; i < MAX_NUM_TID; ++i)
+                priv->aggr_prio_tbl[i].ampdu_ap =
+                        priv->aggr_prio_tbl[i].ampdu_user;
+}
+/*
+ * This function returns the pointer to an entry in BA Stream
+ * table which matches the given RA/TID pair.
+ */
+struct mwifiex_tx_ba_stream_tbl *
+mwifiex_11n_get_tx_ba_stream_tbl(struct mwifiex_private *priv,
+                                 int tid, u8 *ra)
+{
+        struct mwifiex_tx_ba_stream_tbl *tx_ba_tsr_tbl;
+        unsigned long flags;
+        spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags);
+        list_for_each_entry(tx_ba_tsr_tbl, &priv->tx_ba_stream_tbl_ptr, list) {
+                if ((!memcmp(tx_ba_tsr_tbl->ra, ra, ETH_ALEN))
+                    && (tx_ba_tsr_tbl->tid == tid)) {
+                        spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock,
+                                               flags);
+                        return tx_ba_tsr_tbl;
+                }
+        }
+        spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock, flags);
+        return NULL;
+}
+/*
+ * This function creates an entry in Tx BA stream table for the
+ * given RA/TID pair.
+ */
+void mwifiex_11n_create_tx_ba_stream_tbl(struct mwifiex_private *priv,
+                                         u8 *ra, int tid,
+                                         enum mwifiex_ba_status ba_status)
+{
+        struct mwifiex_tx_ba_stream_tbl *new_node;
+        unsigned long flags;
+        if (!mwifiex_11n_get_tx_ba_stream_tbl(priv, tid, ra)) {
+                new_node = kzalloc(sizeof(struct mwifiex_tx_ba_stream_tbl),
+                                   GFP_ATOMIC);
+                if (!new_node) {
+                        dev_err(priv->adapter->dev,
+                                "%s: failed to alloc new_node\n", __func__);
+                        return;
+                }
+                INIT_LIST_HEAD(&new_node->list);
+                new_node->tid = tid;
+                new_node->ba_status = ba_status;
+                memcpy(new_node->ra, ra, ETH_ALEN);
+                spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags);
+                list_add_tail(&new_node->list, &priv->tx_ba_stream_tbl_ptr);
+                spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock, flags);
+        }
+}
+/*
+ * This function sends an add BA request to the given TID/RA pair.
+ */
+int mwifiex_send_addba(struct mwifiex_private *priv, int tid, u8 *peer_mac)
+{
+        struct host_cmd_ds_11n_addba_req add_ba_req;
+        static u8 dialog_tok;
+        int ret;
+        dev_dbg(priv->adapter->dev, "cmd: %s: tid %d\n", __func__, tid);
+        add_ba_req.block_ack_param_set = cpu_to_le16(
+                (u16) ((tid << BLOCKACKPARAM_TID_POS) |
+                         (priv->add_ba_param.
+                          tx_win_size << BLOCKACKPARAM_WINSIZE_POS) |
+                         IMMEDIATE_BLOCK_ACK));
+        add_ba_req.block_ack_tmo = cpu_to_le16((u16)priv->add_ba_param.timeout);
+        ++dialog_tok;
+        if (dialog_tok == 0)
+                dialog_tok = 1;
+        add_ba_req.dialog_token = dialog_tok;
+        memcpy(&add_ba_req.peer_mac_addr, peer_mac, ETH_ALEN);
+        /* We don't wait for the response of this command */
+        ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_11N_ADDBA_REQ,
+                                     0, 0, &add_ba_req);
+        return ret;
+}
+/*
+ * This function sends a delete BA request to the given TID/RA pair.
+ */
+int mwifiex_send_delba(struct mwifiex_private *priv, int tid, u8 *peer_mac,
+                       int initiator)
+{
+        struct host_cmd_ds_11n_delba delba;
+        int ret;
+        uint16_t del_ba_param_set;
+        memset(&delba, 0, sizeof(delba));
+        delba.del_ba_param_set = cpu_to_le16(tid << DELBA_TID_POS);
+        del_ba_param_set = le16_to_cpu(delba.del_ba_param_set);
+        if (initiator)
+                del_ba_param_set |= IEEE80211_DELBA_PARAM_INITIATOR_MASK;
+        else
+                del_ba_param_set &= ~IEEE80211_DELBA_PARAM_INITIATOR_MASK;
+        memcpy(&delba.peer_mac_addr, peer_mac, ETH_ALEN);
+        /* We don't wait for the response of this command */
+        ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_11N_DELBA,
+                                     HostCmd_ACT_GEN_SET, 0, &delba);
+        return ret;
+}
+/*
+ * This function handles the command response of a delete BA request.
+ */
+void mwifiex_11n_delete_ba_stream(struct mwifiex_private *priv, u8 *del_ba)
+{
+        struct host_cmd_ds_11n_delba *cmd_del_ba =
+                (struct host_cmd_ds_11n_delba *) del_ba;
+        uint16_t del_ba_param_set = le16_to_cpu(cmd_del_ba->del_ba_param_set);
+        int tid;
+        tid = del_ba_param_set >> DELBA_TID_POS;
+        mwifiex_11n_delete_ba_stream_tbl(priv, tid, cmd_del_ba->peer_mac_addr,
+                                         TYPE_DELBA_RECEIVE,
+                                         INITIATOR_BIT(del_ba_param_set));
+}
+/*
+ * This function retrieves the Rx reordering table.
+ */
+int mwifiex_get_rx_reorder_tbl(struct mwifiex_private *priv,
+                               struct mwifiex_ds_rx_reorder_tbl *buf)
+{
+        int i;
+        struct mwifiex_ds_rx_reorder_tbl *rx_reo_tbl = buf;
+        struct mwifiex_rx_reorder_tbl *rx_reorder_tbl_ptr;
+        int count = 0;
+        unsigned long flags;
+        spin_lock_irqsave(&priv->rx_reorder_tbl_lock, flags);
+        list_for_each_entry(rx_reorder_tbl_ptr, &priv->rx_reorder_tbl_ptr,
+                            list) {
+                rx_reo_tbl->tid = (u16) rx_reorder_tbl_ptr->tid;
+                memcpy(rx_reo_tbl->ta, rx_reorder_tbl_ptr->ta, ETH_ALEN);
+                rx_reo_tbl->start_win = rx_reorder_tbl_ptr->start_win;
+                rx_reo_tbl->win_size = rx_reorder_tbl_ptr->win_size;
+                for (i = 0; i < rx_reorder_tbl_ptr->win_size; ++i) {
+                        if (rx_reorder_tbl_ptr->rx_reorder_ptr[i])
+                                rx_reo_tbl->buffer[i] = true;
+                        else
+                                rx_reo_tbl->buffer[i] = false;
+                }
+                rx_reo_tbl++;
+                count++;
+                if (count >= MWIFIEX_MAX_RX_BASTREAM_SUPPORTED)
+                        break;
+        }
+        spin_unlock_irqrestore(&priv->rx_reorder_tbl_lock, flags);
+        return count;
+}
+/*
+ * This function retrieves the Tx BA stream table.
+ */
+int mwifiex_get_tx_ba_stream_tbl(struct mwifiex_private *priv,
+                                 struct mwifiex_ds_tx_ba_stream_tbl *buf)
+{
+        struct mwifiex_tx_ba_stream_tbl *tx_ba_tsr_tbl;
+        struct mwifiex_ds_tx_ba_stream_tbl *rx_reo_tbl = buf;
+        int count = 0;
+        unsigned long flags;
+        spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags);
+        list_for_each_entry(tx_ba_tsr_tbl, &priv->tx_ba_stream_tbl_ptr, list) {
+                rx_reo_tbl->tid = (u16) tx_ba_tsr_tbl->tid;
+                dev_dbg(priv->adapter->dev, "data: %s tid=%d\n",
+                                                __func__, rx_reo_tbl->tid);
+                memcpy(rx_reo_tbl->ra, tx_ba_tsr_tbl->ra, ETH_ALEN);
+                rx_reo_tbl++;
+                count++;
+                if (count >= MWIFIEX_MAX_TX_BASTREAM_SUPPORTED)
+                        break;
+        }
+        spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock, flags);
+        return count;
+}
diff --git a/drivers/net/wireless/mwifiex/11n.h b/drivers/net/wireless/mwifiex/11n.h
new file mode 100644
index 000000000000..a4390a1a2a9f
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/11n.h
@@ -0,0 +1,161 @@
+/*
+ * Marvell Wireless LAN device driver: 802.11n
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef _MWIFIEX_11N_H_
+#define _MWIFIEX_11N_H_
+#include "11n_aggr.h"
+#include "11n_rxreorder.h"
+#include "wmm.h"
+int mwifiex_ret_11n_delba(struct mwifiex_private *priv,
+                          struct host_cmd_ds_command *resp);
+int mwifiex_ret_11n_addba_req(struct mwifiex_private *priv,
+                              struct host_cmd_ds_command *resp);
+int mwifiex_ret_11n_cfg(struct host_cmd_ds_command *resp,
+                        void *data_buf);
+int mwifiex_cmd_11n_cfg(struct host_cmd_ds_command *cmd,
+                        u16 cmd_action, void *data_buf);
+int mwifiex_cmd_append_11n_tlv(struct mwifiex_private *priv,
+                               struct mwifiex_bssdescriptor *bss_desc,
+                               u8 **buffer);
+void mwifiex_cfg_tx_buf(struct mwifiex_private *priv,
+                        struct mwifiex_bssdescriptor *bss_desc);
+void mwifiex_fill_cap_info(struct mwifiex_private *, u8 radio_type,
+                           struct mwifiex_ie_types_htcap *);
+int mwifiex_set_get_11n_htcap_cfg(struct mwifiex_private *priv,
+                                  u16 action, int *htcap_cfg);
+void mwifiex_11n_delete_tx_ba_stream_tbl_entry(struct mwifiex_private *priv,
+                                             struct mwifiex_tx_ba_stream_tbl
+                                             *tx_tbl);
+void mwifiex_11n_delete_all_tx_ba_stream_tbl(struct mwifiex_private *priv);
+struct mwifiex_tx_ba_stream_tbl *mwifiex_11n_get_tx_ba_stream_tbl(struct
+                                                             mwifiex_private
+                                                             *priv, int tid,
+                                                             u8 *ra);
+void mwifiex_11n_create_tx_ba_stream_tbl(struct mwifiex_private *priv, u8 *ra,
+                                       int tid,
+                                       enum mwifiex_ba_status ba_status);
+int mwifiex_send_addba(struct mwifiex_private *priv, int tid, u8 *peer_mac);
+int mwifiex_send_delba(struct mwifiex_private *priv, int tid, u8 *peer_mac,
+                       int initiator);
+void mwifiex_11n_delete_ba_stream(struct mwifiex_private *priv, u8 *del_ba);
+int mwifiex_get_rx_reorder_tbl(struct mwifiex_private *priv,
+                              struct mwifiex_ds_rx_reorder_tbl *buf);
+int mwifiex_get_tx_ba_stream_tbl(struct mwifiex_private *priv,
+                               struct mwifiex_ds_tx_ba_stream_tbl *buf);
+int mwifiex_ret_amsdu_aggr_ctrl(struct host_cmd_ds_command *resp,
+                                void *data_buf);
+int mwifiex_cmd_recfg_tx_buf(struct mwifiex_private *priv,
+                             struct host_cmd_ds_command *cmd,
+                             int cmd_action, void *data_buf);
+int mwifiex_cmd_amsdu_aggr_ctrl(struct host_cmd_ds_command *cmd,
+                                int cmd_action, void *data_buf);
+/*
+ * This function checks whether AMPDU is allowed or not for a particular TID.
+ */
+static inline u8
+mwifiex_is_ampdu_allowed(struct mwifiex_private *priv, int tid)
+{
+        return ((priv->aggr_prio_tbl[tid].ampdu_ap != BA_STREAM_NOT_ALLOWED)
+                ? true : false);
+}
+/*
+ * This function checks whether AMSDU is allowed or not for a particular TID.
+ */
+static inline u8
+mwifiex_is_amsdu_allowed(struct mwifiex_private *priv, int tid)
+{
+        return (((priv->aggr_prio_tbl[tid].amsdu != BA_STREAM_NOT_ALLOWED)
+                        && ((priv->is_data_rate_auto)
+                        || !((priv->bitmap_rates[2]) & 0x03)))
+                ? true : false);
+}
+/*
+ * This function checks whether a space is available for new BA stream or not.
+ */
+static inline u8 mwifiex_space_avail_for_new_ba_stream(
+                                        struct mwifiex_adapter *adapter)
+{
+        struct mwifiex_private *priv;
+        u8 i;
+        u32 ba_stream_num = 0;
+        for (i = 0; i < adapter->priv_num; i++) {
+                priv = adapter->priv[i];
+                if (priv)
+                        ba_stream_num += mwifiex_wmm_list_len(
+                                                (struct list_head *)
+                                                &priv->tx_ba_stream_tbl_ptr);
+        }
+        return ((ba_stream_num <
+                 MWIFIEX_MAX_TX_BASTREAM_SUPPORTED) ? true : false);
+}
+/*
+ * This function finds the correct Tx BA stream to delete.
+ *
+ * Upon successfully locating, both the TID and the RA are returned.
+ */
+static inline u8
+mwifiex_find_stream_to_delete(struct mwifiex_private *priv, int ptr_tid,
+                              int *ptid, u8 *ra)
+{
+        int tid;
+        u8 ret = false;
+        struct mwifiex_tx_ba_stream_tbl *tx_tbl;
+        unsigned long flags;
+        tid = priv->aggr_prio_tbl[ptr_tid].ampdu_user;
+        spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags);
+        list_for_each_entry(tx_tbl, &priv->tx_ba_stream_tbl_ptr, list) {
+                if (tid > priv->aggr_prio_tbl[tx_tbl->tid].ampdu_user) {
+                        tid = priv->aggr_prio_tbl[tx_tbl->tid].ampdu_user;
+                        *ptid = tx_tbl->tid;
+                        memcpy(ra, tx_tbl->ra, ETH_ALEN);
+                        ret = true;
+                }
+        }
+        spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock, flags);
+        return ret;
+}
+/*
+ * This function checks whether BA stream is set up or not.
+ */
+static inline int
+mwifiex_is_ba_stream_setup(struct mwifiex_private *priv,
+                          struct mwifiex_ra_list_tbl *ptr, int tid)
+{
+        struct mwifiex_tx_ba_stream_tbl *tx_tbl;
+        tx_tbl = mwifiex_11n_get_tx_ba_stream_tbl(priv, tid, ptr->ra);
+        if (tx_tbl && IS_BASTREAM_SETUP(tx_tbl))
+                return true;
+        return false;
+}
+#endif /* !_MWIFIEX_11N_H_ */
diff --git a/drivers/net/wireless/mwifiex/11n_aggr.c b/drivers/net/wireless/mwifiex/11n_aggr.c
new file mode 100644
index 000000000000..d3d5e0853c45
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/11n_aggr.c
@@ -0,0 +1,298 @@
+/*
+ * Marvell Wireless LAN device driver: 802.11n Aggregation
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+#include "11n_aggr.h"
+/*
+ * Creates an AMSDU subframe for aggregation into one AMSDU packet.
+ *
+ * The resultant AMSDU subframe format is -
+ *
+ * +---- ~ -----+---- ~ ------+---- ~ -----+----- ~ -----+---- ~ -----+
+ * |     DA     |     SA      |   Length   | SNAP header |   MSDU     |
+ * | data[0..5] | data[6..11] |            |             | data[14..] |
+ * +---- ~ -----+---- ~ ------+---- ~ -----+----- ~ -----+---- ~ -----+
+ * <--6-bytes--> <--6-bytes--> <--2-bytes--><--8-bytes--> <--n-bytes-->
+ *
+ * This function also computes the amount of padding required to make the
+ * buffer length multiple of 4 bytes.
+ *
+ * Data => |DA|SA|SNAP-TYPE|........    .|
+ * MSDU => |DA|SA|Length|SNAP|......   ..|
+ */
+static int
+mwifiex_11n_form_amsdu_pkt(struct sk_buff *skb_aggr,
+                           struct sk_buff *skb_src, int *pad)
+{
+        int dt_offset;
+        struct rfc_1042_hdr snap = {
+                0xaa,           /* LLC DSAP */
+                0xaa,           /* LLC SSAP */
+                0x03,           /* LLC CTRL */
+                {0x00, 0x00, 0x00},     /* SNAP OUI */
+                0x0000          /* SNAP type */
+                        /*
+                         * This field will be overwritten
+                         * later with ethertype
+                         */
+        };
+        struct tx_packet_hdr *tx_header;
+        skb_put(skb_aggr, sizeof(*tx_header));
+        tx_header = (struct tx_packet_hdr *) skb_aggr->data;
+        /* Copy DA and SA */
+        dt_offset = 2 * ETH_ALEN;
+        memcpy(&tx_header->eth803_hdr, skb_src->data, dt_offset);
+        /* Copy SNAP header */
+        snap.snap_type = *(u16 *) ((u8 *)skb_src->data + dt_offset);
+        dt_offset += sizeof(u16);
+        memcpy(&tx_header->rfc1042_hdr, &snap, sizeof(struct rfc_1042_hdr));
+        skb_pull(skb_src, dt_offset);
+        /* Update Length field */
+        tx_header->eth803_hdr.h_proto = htons(skb_src->len + LLC_SNAP_LEN);
+        /* Add payload */
+        skb_put(skb_aggr, skb_src->len);
+        memcpy(skb_aggr->data + sizeof(*tx_header), skb_src->data,
+                                                        skb_src->len);
+        *pad = (((skb_src->len + LLC_SNAP_LEN) & 3)) ? (4 - (((skb_src->len +
+                                                      LLC_SNAP_LEN)) & 3)) : 0;
+        skb_put(skb_aggr, *pad);
+        return skb_aggr->len + *pad;
+}
+/*
+ * Adds TxPD to AMSDU header.
+ *
+ * Each AMSDU packet will contain one TxPD at the beginning,
+ * followed by multiple AMSDU subframes.
+ */
+static void
+mwifiex_11n_form_amsdu_txpd(struct mwifiex_private *priv,
+                            struct sk_buff *skb)
+{
+        struct txpd *local_tx_pd;
+        skb_push(skb, sizeof(*local_tx_pd));
+        local_tx_pd = (struct txpd *) skb->data;
+        memset(local_tx_pd, 0, sizeof(struct txpd));
+        /* Original priority has been overwritten */
+        local_tx_pd->priority = (u8) skb->priority;
+        local_tx_pd->pkt_delay_2ms =
+                mwifiex_wmm_compute_drv_pkt_delay(priv, skb);
+        local_tx_pd->bss_num = priv->bss_num;
+        local_tx_pd->bss_type = priv->bss_type;
+        /* Always zero as the data is followed by struct txpd */
+        local_tx_pd->tx_pkt_offset = cpu_to_le16(sizeof(struct txpd));
+        local_tx_pd->tx_pkt_type = cpu_to_le16(PKT_TYPE_AMSDU);
+        local_tx_pd->tx_pkt_length = cpu_to_le16(skb->len -
+                        sizeof(*local_tx_pd));
+        if (local_tx_pd->tx_control == 0)
+                /* TxCtrl set by user or default */
+                local_tx_pd->tx_control = cpu_to_le32(priv->pkt_tx_ctrl);
+        if ((GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA) &&
+                (priv->adapter->pps_uapsd_mode)) {
+                if (true == mwifiex_check_last_packet_indication(priv)) {
+                        priv->adapter->tx_lock_flag = true;
+                        local_tx_pd->flags =
+                                MWIFIEX_TxPD_POWER_MGMT_LAST_PACKET;
+                }
+        }
+}
+/*
+ * Create aggregated packet.
+ *
+ * This function creates an aggregated MSDU packet, by combining buffers
+ * from the RA list. Each individual buffer is encapsulated as an AMSDU
+ * subframe and all such subframes are concatenated together to form the
+ * AMSDU packet.
+ *
+ * A TxPD is also added to the front of the resultant AMSDU packets for
+ * transmission. The resultant packets format is -
+ *
+ * +---- ~ ----+------ ~ ------+------ ~ ------+-..-+------ ~ ------+
+ * |    TxPD   |AMSDU sub-frame|AMSDU sub-frame| .. |AMSDU sub-frame|
+ * |           |       1       |       2       | .. |       n       |
+ * +---- ~ ----+------ ~ ------+------ ~ ------+ .. +------ ~ ------+
+ */
+int
+mwifiex_11n_aggregate_pkt(struct mwifiex_private *priv,
+                          struct mwifiex_ra_list_tbl *pra_list, int headroom,
+                          int ptrindex, unsigned long ra_list_flags)
+                          __releases(&priv->wmm.ra_list_spinlock)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct sk_buff *skb_aggr, *skb_src;
+        struct mwifiex_txinfo *tx_info_aggr, *tx_info_src;
+        int pad = 0, ret;
+        struct mwifiex_tx_param tx_param;
+        struct txpd *ptx_pd = NULL;
+        if (skb_queue_empty(&pra_list->skb_head)) {
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+                return 0;
+        }
+        skb_src = skb_peek(&pra_list->skb_head);
+        tx_info_src = MWIFIEX_SKB_TXCB(skb_src);
+        skb_aggr = dev_alloc_skb(adapter->tx_buf_size);
+        if (!skb_aggr) {
+                dev_err(adapter->dev, "%s: alloc skb_aggr\n", __func__);
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+                return -1;
+        }
+        skb_reserve(skb_aggr, headroom + sizeof(struct txpd));
+        tx_info_aggr =  MWIFIEX_SKB_TXCB(skb_aggr);
+        tx_info_aggr->bss_index = tx_info_src->bss_index;
+        skb_aggr->priority = skb_src->priority;
+        while (skb_src && ((skb_headroom(skb_aggr) + skb_src->len
+                                        + LLC_SNAP_LEN)
+                                <= adapter->tx_buf_size)) {
+                if (!skb_queue_empty(&pra_list->skb_head))
+                        skb_src = skb_dequeue(&pra_list->skb_head);
+                else
+                        skb_src = NULL;
+                if (skb_src)
+                        pra_list->total_pkts_size -= skb_src->len;
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+                mwifiex_11n_form_amsdu_pkt(skb_aggr, skb_src, &pad);
+                mwifiex_write_data_complete(adapter, skb_src, 0);
+                spin_lock_irqsave(&priv->wmm.ra_list_spinlock, ra_list_flags);
+                if (!mwifiex_is_ralist_valid(priv, pra_list, ptrindex)) {
+                        spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                               ra_list_flags);
+                        return -1;
+                }
+                if (!skb_queue_empty(&pra_list->skb_head))
+                        skb_src = skb_peek(&pra_list->skb_head);
+                else
+                        skb_src = NULL;
+        }
+        spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock, ra_list_flags);
+        /* Last AMSDU packet does not need padding */
+        skb_trim(skb_aggr, skb_aggr->len - pad);
+        /* Form AMSDU */
+        mwifiex_11n_form_amsdu_txpd(priv, skb_aggr);
+        if (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA)
+                ptx_pd = (struct txpd *)skb_aggr->data;
+        skb_push(skb_aggr, headroom);
+        tx_param.next_pkt_len = ((pra_list->total_pkts_size) ?
+                                 (((pra_list->total_pkts_size) >
+                                   adapter->tx_buf_size) ? adapter->
+                                  tx_buf_size : pra_list->total_pkts_size +
+                                  LLC_SNAP_LEN + sizeof(struct txpd)) : 0);
+        ret = adapter->if_ops.host_to_card(adapter, MWIFIEX_TYPE_DATA,
+                                             skb_aggr->data,
+                                             skb_aggr->len, &tx_param);
+        switch (ret) {
+        case -EBUSY:
+                spin_lock_irqsave(&priv->wmm.ra_list_spinlock, ra_list_flags);
+                if (!mwifiex_is_ralist_valid(priv, pra_list, ptrindex)) {
+                        spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                               ra_list_flags);
+                        mwifiex_write_data_complete(adapter, skb_aggr, -1);
+                        return -1;
+                }
+                if ((GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA) &&
+                        (adapter->pps_uapsd_mode) &&
+                        (adapter->tx_lock_flag)) {
+                                priv->adapter->tx_lock_flag = false;
+                                if (ptx_pd)
+                                        ptx_pd->flags = 0;
+                }
+                skb_queue_tail(&pra_list->skb_head, skb_aggr);
+                pra_list->total_pkts_size += skb_aggr->len;
+                tx_info_aggr->flags |= MWIFIEX_BUF_FLAG_REQUEUED_PKT;
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+                dev_dbg(adapter->dev, "data: -EBUSY is returned\n");
+                break;
+        case -1:
+                adapter->data_sent = false;
+                dev_err(adapter->dev, "%s: host_to_card failed: %#x\n",
+                                                __func__, ret);
+                adapter->dbg.num_tx_host_to_card_failure++;
+                mwifiex_write_data_complete(adapter, skb_aggr, ret);
+                return 0;
+        case -EINPROGRESS:
+                adapter->data_sent = false;
+                break;
+        case 0:
+                mwifiex_write_data_complete(adapter, skb_aggr, ret);
+                break;
+        default:
+                break;
+        }
+        if (ret != -EBUSY) {
+                spin_lock_irqsave(&priv->wmm.ra_list_spinlock, ra_list_flags);
+                if (mwifiex_is_ralist_valid(priv, pra_list, ptrindex)) {
+                        priv->wmm.packets_out[ptrindex]++;
+                        priv->wmm.tid_tbl_ptr[ptrindex].ra_list_curr = pra_list;
+                }
+                /* Now bss_prio_cur pointer points to next node */
+                adapter->bss_prio_tbl[priv->bss_priority].bss_prio_cur =
+                        list_first_entry(
+                                &adapter->bss_prio_tbl[priv->bss_priority]
+                                .bss_prio_cur->list,
+                                struct mwifiex_bss_prio_node, list);
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+        }
+        return 0;
+}
diff --git a/drivers/net/wireless/mwifiex/11n_aggr.h b/drivers/net/wireless/mwifiex/11n_aggr.h
new file mode 100644
index 000000000000..9c6dca7ab02c
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/11n_aggr.h
@@ -0,0 +1,32 @@
+/*
+ * Marvell Wireless LAN device driver: 802.11n Aggregation
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef _MWIFIEX_11N_AGGR_H_
+#define _MWIFIEX_11N_AGGR_H_
+#define PKT_TYPE_AMSDU  0xE6
+int mwifiex_11n_deaggregate_pkt(struct mwifiex_private *priv,
+                                struct sk_buff *skb);
+int mwifiex_11n_aggregate_pkt(struct mwifiex_private *priv,
+                              struct mwifiex_ra_list_tbl *ptr, int headroom,
+                              int ptr_index, unsigned long flags)
+                              __releases(&priv->wmm.ra_list_spinlock);
+#endif /* !_MWIFIEX_11N_AGGR_H_ */
diff --git a/drivers/net/wireless/mwifiex/11n_rxreorder.c b/drivers/net/wireless/mwifiex/11n_rxreorder.c
new file mode 100644
index 000000000000..e5dfdc39a921
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/11n_rxreorder.c
@@ -0,0 +1,616 @@
+/*
+ * Marvell Wireless LAN device driver: 802.11n RX Re-ordering
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+#include "11n_rxreorder.h"
+/*
+ * This function dispatches all packets in the Rx reorder table.
+ *
+ * There could be holes in the buffer, which are skipped by the function.
+ * Since the buffer is linear, the function uses rotation to simulate
+ * circular buffer.
+ */
+static int
+mwifiex_11n_dispatch_pkt_until_start_win(struct mwifiex_private *priv,
+                                         struct mwifiex_rx_reorder_tbl
+                                         *rx_reor_tbl_ptr, int start_win)
+{
+        int no_pkt_to_send, i;
+        void *rx_tmp_ptr;
+        unsigned long flags;
+        no_pkt_to_send = (start_win > rx_reor_tbl_ptr->start_win) ?
+                min((start_win - rx_reor_tbl_ptr->start_win),
+                    rx_reor_tbl_ptr->win_size) : rx_reor_tbl_ptr->win_size;
+        for (i = 0; i < no_pkt_to_send; ++i) {
+                spin_lock_irqsave(&priv->rx_pkt_lock, flags);
+                rx_tmp_ptr = NULL;
+                if (rx_reor_tbl_ptr->rx_reorder_ptr[i]) {
+                        rx_tmp_ptr = rx_reor_tbl_ptr->rx_reorder_ptr[i];
+                        rx_reor_tbl_ptr->rx_reorder_ptr[i] = NULL;
+                }
+                spin_unlock_irqrestore(&priv->rx_pkt_lock, flags);
+                if (rx_tmp_ptr)
+                        mwifiex_process_rx_packet(priv->adapter, rx_tmp_ptr);
+        }
+        spin_lock_irqsave(&priv->rx_pkt_lock, flags);
+        /*
+         * We don't have a circular buffer, hence use rotation to simulate
+         * circular buffer
+         */
+        for (i = 0; i < rx_reor_tbl_ptr->win_size - no_pkt_to_send; ++i) {
+                rx_reor_tbl_ptr->rx_reorder_ptr[i] =
+                        rx_reor_tbl_ptr->rx_reorder_ptr[no_pkt_to_send + i];
+                rx_reor_tbl_ptr->rx_reorder_ptr[no_pkt_to_send + i] = NULL;
+        }
+        rx_reor_tbl_ptr->start_win = start_win;
+        spin_unlock_irqrestore(&priv->rx_pkt_lock, flags);
+        return 0;
+}
+/*
+ * This function dispatches all packets in the Rx reorder table until
+ * a hole is found.
+ *
+ * The start window is adjusted automatically when a hole is located.
+ * Since the buffer is linear, the function uses rotation to simulate
+ * circular buffer.
+ */
+static int
+mwifiex_11n_scan_and_dispatch(struct mwifiex_private *priv,
+                              struct mwifiex_rx_reorder_tbl *rx_reor_tbl_ptr)
+{
+        int i, j, xchg;
+        void *rx_tmp_ptr;
+        unsigned long flags;
+        for (i = 0; i < rx_reor_tbl_ptr->win_size; ++i) {
+                spin_lock_irqsave(&priv->rx_pkt_lock, flags);
+                if (!rx_reor_tbl_ptr->rx_reorder_ptr[i]) {
+                        spin_unlock_irqrestore(&priv->rx_pkt_lock, flags);
+                        break;
+                }
+                rx_tmp_ptr = rx_reor_tbl_ptr->rx_reorder_ptr[i];
+                rx_reor_tbl_ptr->rx_reorder_ptr[i] = NULL;
+                spin_unlock_irqrestore(&priv->rx_pkt_lock, flags);
+                mwifiex_process_rx_packet(priv->adapter, rx_tmp_ptr);
+        }
+        spin_lock_irqsave(&priv->rx_pkt_lock, flags);
+        /*
+         * We don't have a circular buffer, hence use rotation to simulate
+         * circular buffer
+         */
+        if (i > 0) {
+                xchg = rx_reor_tbl_ptr->win_size - i;
+                for (j = 0; j < xchg; ++j) {
+                        rx_reor_tbl_ptr->rx_reorder_ptr[j] =
+                                rx_reor_tbl_ptr->rx_reorder_ptr[i + j];
+                        rx_reor_tbl_ptr->rx_reorder_ptr[i + j] = NULL;
+                }
+        }
+        rx_reor_tbl_ptr->start_win = (rx_reor_tbl_ptr->start_win + i)
+                &(MAX_TID_VALUE - 1);
+        spin_unlock_irqrestore(&priv->rx_pkt_lock, flags);
+        return 0;
+}
+/*
+ * This function deletes the Rx reorder table and frees the memory.
+ *
+ * The function stops the associated timer and dispatches all the
+ * pending packets in the Rx reorder table before deletion.
+ */
+static void
+mwifiex_11n_delete_rx_reorder_tbl_entry(struct mwifiex_private *priv,
+                                       struct mwifiex_rx_reorder_tbl
+                                       *rx_reor_tbl_ptr)
+{
+        unsigned long flags;
+        if (!rx_reor_tbl_ptr)
+                return;
+        mwifiex_11n_dispatch_pkt_until_start_win(priv, rx_reor_tbl_ptr,
+                                                 (rx_reor_tbl_ptr->start_win +
+                                                  rx_reor_tbl_ptr->win_size)
+                                                 &(MAX_TID_VALUE - 1));
+        del_timer(&rx_reor_tbl_ptr->timer_context.timer);
+        spin_lock_irqsave(&priv->rx_reorder_tbl_lock, flags);
+        list_del(&rx_reor_tbl_ptr->list);
+        spin_unlock_irqrestore(&priv->rx_reorder_tbl_lock, flags);
+        kfree(rx_reor_tbl_ptr->rx_reorder_ptr);
+        kfree(rx_reor_tbl_ptr);
+}
+/*
+ * This function returns the pointer to an entry in Rx reordering
+ * table which matches the given TA/TID pair.
+ */
+static struct mwifiex_rx_reorder_tbl *
+mwifiex_11n_get_rx_reorder_tbl(struct mwifiex_private *priv, int tid, u8 *ta)
+{
+        struct mwifiex_rx_reorder_tbl *rx_reor_tbl_ptr;
+        unsigned long flags;
+        spin_lock_irqsave(&priv->rx_reorder_tbl_lock, flags);
+        list_for_each_entry(rx_reor_tbl_ptr, &priv->rx_reorder_tbl_ptr, list) {
+                if ((!memcmp(rx_reor_tbl_ptr->ta, ta, ETH_ALEN))
+                    && (rx_reor_tbl_ptr->tid == tid)) {
+                        spin_unlock_irqrestore(&priv->rx_reorder_tbl_lock,
+                                               flags);
+                        return rx_reor_tbl_ptr;
+                }
+        }
+        spin_unlock_irqrestore(&priv->rx_reorder_tbl_lock, flags);
+        return NULL;
+}
+/*
+ * This function finds the last sequence number used in the packets
+ * buffered in Rx reordering table.
+ */
+static int
+mwifiex_11n_find_last_seq_num(struct mwifiex_rx_reorder_tbl *rx_reorder_tbl_ptr)
+{
+        int i;
+        for (i = (rx_reorder_tbl_ptr->win_size - 1); i >= 0; --i)
+                if (rx_reorder_tbl_ptr->rx_reorder_ptr[i])
+                        return i;
+        return -1;
+}
+/*
+ * This function flushes all the packets in Rx reordering table.
+ *
+ * The function checks if any packets are currently buffered in the
+ * table or not. In case there are packets available, it dispatches
+ * them and then dumps the Rx reordering table.
+ */
+static void
+mwifiex_flush_data(unsigned long context)
+{
+        struct reorder_tmr_cnxt *reorder_cnxt =
+                (struct reorder_tmr_cnxt *) context;
+        int start_win;
+        start_win = mwifiex_11n_find_last_seq_num(reorder_cnxt->ptr);
+        if (start_win >= 0) {
+                dev_dbg(reorder_cnxt->priv->adapter->dev,
+                                "info: flush data %d\n", start_win);
+                mwifiex_11n_dispatch_pkt_until_start_win(reorder_cnxt->priv,
+                                reorder_cnxt->ptr,
+                                ((reorder_cnxt->ptr->start_win +
+                                  start_win + 1) & (MAX_TID_VALUE - 1)));
+        }
+}
+/*
+ * This function creates an entry in Rx reordering table for the
+ * given TA/TID.
+ *
+ * The function also initializes the entry with sequence number, window
+ * size as well as initializes the timer.
+ *
+ * If the received TA/TID pair is already present, all the packets are
+ * dispatched and the window size is moved until the SSN.
+ */
+static void
+mwifiex_11n_create_rx_reorder_tbl(struct mwifiex_private *priv, u8 *ta,
+                                 int tid, int win_size, int seq_num)
+{
+        int i;
+        struct mwifiex_rx_reorder_tbl *rx_reor_tbl_ptr, *new_node;
+        u16 last_seq = 0;
+        unsigned long flags;
+        /*
+         * If we get a TID, ta pair which is already present dispatch all the
+         * the packets and move the window size until the ssn
+         */
+        rx_reor_tbl_ptr = mwifiex_11n_get_rx_reorder_tbl(priv, tid, ta);
+        if (rx_reor_tbl_ptr) {
+                mwifiex_11n_dispatch_pkt_until_start_win(priv, rx_reor_tbl_ptr,
+                                                         seq_num);
+                return;
+        }
+        /* if !rx_reor_tbl_ptr then create one */
+        new_node = kzalloc(sizeof(struct mwifiex_rx_reorder_tbl), GFP_KERNEL);
+        if (!new_node) {
+                dev_err(priv->adapter->dev, "%s: failed to alloc new_node\n",
+                       __func__);
+                return;
+        }
+        INIT_LIST_HEAD(&new_node->list);
+        new_node->tid = tid;
+        memcpy(new_node->ta, ta, ETH_ALEN);
+        new_node->start_win = seq_num;
+        if (mwifiex_queuing_ra_based(priv))
+                /* TODO for adhoc */
+                dev_dbg(priv->adapter->dev,
+                        "info: ADHOC:last_seq=%d start_win=%d\n",
+                        last_seq, new_node->start_win);
+        else
+                last_seq = priv->rx_seq[tid];
+        if (last_seq >= new_node->start_win)
+                new_node->start_win = last_seq + 1;
+        new_node->win_size = win_size;
+        new_node->rx_reorder_ptr = kzalloc(sizeof(void *) * win_size,
+                                        GFP_KERNEL);
+        if (!new_node->rx_reorder_ptr) {
+                kfree((u8 *) new_node);
+                dev_err(priv->adapter->dev,
+                        "%s: failed to alloc reorder_ptr\n", __func__);
+                return;
+        }
+        new_node->timer_context.ptr = new_node;
+        new_node->timer_context.priv = priv;
+        init_timer(&new_node->timer_context.timer);
+        new_node->timer_context.timer.function = mwifiex_flush_data;
+        new_node->timer_context.timer.data =
+                        (unsigned long) &new_node->timer_context;
+        for (i = 0; i < win_size; ++i)
+                new_node->rx_reorder_ptr[i] = NULL;
+        spin_lock_irqsave(&priv->rx_reorder_tbl_lock, flags);
+        list_add_tail(&new_node->list, &priv->rx_reorder_tbl_ptr);
+        spin_unlock_irqrestore(&priv->rx_reorder_tbl_lock, flags);
+}
+/*
+ * This function prepares command for adding a BA request.
+ *
+ * Preparation includes -
+ *      - Setting command ID and proper size
+ *      - Setting add BA request buffer
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_11n_addba_req(struct host_cmd_ds_command *cmd, void *data_buf)
+{
+        struct host_cmd_ds_11n_addba_req *add_ba_req =
+                (struct host_cmd_ds_11n_addba_req *)
+                &cmd->params.add_ba_req;
+        cmd->command = cpu_to_le16(HostCmd_CMD_11N_ADDBA_REQ);
+        cmd->size = cpu_to_le16(sizeof(*add_ba_req) + S_DS_GEN);
+        memcpy(add_ba_req, data_buf, sizeof(*add_ba_req));
+        return 0;
+}
+/*
+ * This function prepares command for adding a BA response.
+ *
+ * Preparation includes -
+ *      - Setting command ID and proper size
+ *      - Setting add BA response buffer
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_11n_addba_rsp_gen(struct mwifiex_private *priv,
+                                  struct host_cmd_ds_command *cmd,
+                                  void *data_buf)
+{
+        struct host_cmd_ds_11n_addba_rsp *add_ba_rsp =
+                (struct host_cmd_ds_11n_addba_rsp *)
+                &cmd->params.add_ba_rsp;
+        struct host_cmd_ds_11n_addba_req *cmd_addba_req =
+                (struct host_cmd_ds_11n_addba_req *) data_buf;
+        u8 tid;
+        int win_size;
+        uint16_t block_ack_param_set;
+        cmd->command = cpu_to_le16(HostCmd_CMD_11N_ADDBA_RSP);
+        cmd->size = cpu_to_le16(sizeof(*add_ba_rsp) + S_DS_GEN);
+        memcpy(add_ba_rsp->peer_mac_addr, cmd_addba_req->peer_mac_addr,
+               ETH_ALEN);
+        add_ba_rsp->dialog_token = cmd_addba_req->dialog_token;
+        add_ba_rsp->block_ack_tmo = cmd_addba_req->block_ack_tmo;
+        add_ba_rsp->ssn = cmd_addba_req->ssn;
+        block_ack_param_set = le16_to_cpu(cmd_addba_req->block_ack_param_set);
+        tid = (block_ack_param_set & IEEE80211_ADDBA_PARAM_TID_MASK)
+                >> BLOCKACKPARAM_TID_POS;
+        add_ba_rsp->status_code = cpu_to_le16(ADDBA_RSP_STATUS_ACCEPT);
+        block_ack_param_set &= ~IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK;
+        /* We donot support AMSDU inside AMPDU, hence reset the bit */
+        block_ack_param_set &= ~BLOCKACKPARAM_AMSDU_SUPP_MASK;
+        block_ack_param_set |= (priv->add_ba_param.rx_win_size <<
+                                             BLOCKACKPARAM_WINSIZE_POS);
+        add_ba_rsp->block_ack_param_set = cpu_to_le16(block_ack_param_set);
+        win_size = (le16_to_cpu(add_ba_rsp->block_ack_param_set)
+                                        & IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK)
+                                        >> BLOCKACKPARAM_WINSIZE_POS;
+        cmd_addba_req->block_ack_param_set = cpu_to_le16(block_ack_param_set);
+        mwifiex_11n_create_rx_reorder_tbl(priv, cmd_addba_req->peer_mac_addr,
+                            tid, win_size, le16_to_cpu(cmd_addba_req->ssn));
+        return 0;
+}
+/*
+ * This function prepares command for deleting a BA request.
+ *
+ * Preparation includes -
+ *      - Setting command ID and proper size
+ *      - Setting del BA request buffer
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_11n_delba(struct host_cmd_ds_command *cmd, void *data_buf)
+{
+        struct host_cmd_ds_11n_delba *del_ba = (struct host_cmd_ds_11n_delba *)
+                &cmd->params.del_ba;
+        cmd->command = cpu_to_le16(HostCmd_CMD_11N_DELBA);
+        cmd->size = cpu_to_le16(sizeof(*del_ba) + S_DS_GEN);
+        memcpy(del_ba, data_buf, sizeof(*del_ba));
+        return 0;
+}
+/*
+ * This function identifies if Rx reordering is needed for a received packet.
+ *
+ * In case reordering is required, the function will do the reordering
+ * before sending it to kernel.
+ *
+ * The Rx reorder table is checked first with the received TID/TA pair. If
+ * not found, the received packet is dispatched immediately. But if found,
+ * the packet is reordered and all the packets in the updated Rx reordering
+ * table is dispatched until a hole is found.
+ *
+ * For sequence number less than the starting window, the packet is dropped.
+ */
+int mwifiex_11n_rx_reorder_pkt(struct mwifiex_private *priv,
+                                u16 seq_num, u16 tid,
+                                u8 *ta, u8 pkt_type, void *payload)
+{
+        struct mwifiex_rx_reorder_tbl *rx_reor_tbl_ptr;
+        int start_win, end_win, win_size, ret;
+        u16 pkt_index;
+        rx_reor_tbl_ptr =
+                mwifiex_11n_get_rx_reorder_tbl((struct mwifiex_private *) priv,
+                                                tid, ta);
+        if (!rx_reor_tbl_ptr) {
+                if (pkt_type != PKT_TYPE_BAR)
+                        mwifiex_process_rx_packet(priv->adapter, payload);
+                return 0;
+        }
+        start_win = rx_reor_tbl_ptr->start_win;
+        win_size = rx_reor_tbl_ptr->win_size;
+        end_win = ((start_win + win_size) - 1) & (MAX_TID_VALUE - 1);
+        del_timer(&rx_reor_tbl_ptr->timer_context.timer);
+        mod_timer(&rx_reor_tbl_ptr->timer_context.timer, jiffies
+                        + (MIN_FLUSH_TIMER_MS * win_size * HZ) / 1000);
+        /*
+         * If seq_num is less then starting win then ignore and drop the
+         * packet
+         */
+        if ((start_win + TWOPOW11) > (MAX_TID_VALUE - 1)) {/* Wrap */
+                if (seq_num >= ((start_win + (TWOPOW11)) & (MAX_TID_VALUE - 1))
+                                && (seq_num < start_win))
+                        return -1;
+        } else if ((seq_num < start_win)
+                        || (seq_num > (start_win + (TWOPOW11)))) {
+                return -1;
+        }
+        /*
+         * If this packet is a BAR we adjust seq_num as
+         * WinStart = seq_num
+         */
+        if (pkt_type == PKT_TYPE_BAR)
+                seq_num = ((seq_num + win_size) - 1) & (MAX_TID_VALUE - 1);
+        if (((end_win < start_win)
+             && (seq_num < (TWOPOW11 - (MAX_TID_VALUE - start_win)))
+             && (seq_num > end_win)) || ((end_win > start_win)
+             && ((seq_num > end_win) || (seq_num < start_win)))) {
+                end_win = seq_num;
+                if (((seq_num - win_size) + 1) >= 0)
+                        start_win = (end_win - win_size) + 1;
+                else
+                        start_win = (MAX_TID_VALUE - (win_size - seq_num)) + 1;
+                ret = mwifiex_11n_dispatch_pkt_until_start_win(priv,
+                                                rx_reor_tbl_ptr, start_win);
+                if (ret)
+                        return ret;
+        }
+        if (pkt_type != PKT_TYPE_BAR) {
+                if (seq_num >= start_win)
+                        pkt_index = seq_num - start_win;
+                else
+                        pkt_index = (seq_num+MAX_TID_VALUE) - start_win;
+                if (rx_reor_tbl_ptr->rx_reorder_ptr[pkt_index])
+                        return -1;
+                rx_reor_tbl_ptr->rx_reorder_ptr[pkt_index] = payload;
+        }
+        /*
+         * Dispatch all packets sequentially from start_win until a
+         * hole is found and adjust the start_win appropriately
+         */
+        ret = mwifiex_11n_scan_and_dispatch(priv, rx_reor_tbl_ptr);
+        return ret;
+}
+/*
+ * This function deletes an entry for a given TID/TA pair.
+ *
+ * The TID/TA are taken from del BA event body.
+ */
+void
+mwifiex_11n_delete_ba_stream_tbl(struct mwifiex_private *priv, int tid,
+                                u8 *peer_mac, u8 type, int initiator)
+{
+        struct mwifiex_rx_reorder_tbl *rx_reor_tbl_ptr;
+        struct mwifiex_tx_ba_stream_tbl *ptx_tbl;
+        u8 cleanup_rx_reorder_tbl;
+        unsigned long flags;
+        if (type == TYPE_DELBA_RECEIVE)
+                cleanup_rx_reorder_tbl = (initiator) ? true : false;
+        else
+                cleanup_rx_reorder_tbl = (initiator) ? false : true;
+        dev_dbg(priv->adapter->dev, "event: DELBA: %pM tid=%d, "
+               "initiator=%d\n", peer_mac, tid, initiator);
+        if (cleanup_rx_reorder_tbl) {
+                rx_reor_tbl_ptr = mwifiex_11n_get_rx_reorder_tbl(priv, tid,
+                                                                 peer_mac);
+                if (!rx_reor_tbl_ptr) {
+                        dev_dbg(priv->adapter->dev,
+                                        "event: TID, TA not found in table\n");
+                        return;
+                }
+                mwifiex_11n_delete_rx_reorder_tbl_entry(priv, rx_reor_tbl_ptr);
+        } else {
+                ptx_tbl = mwifiex_11n_get_tx_ba_stream_tbl(priv, tid, peer_mac);
+                if (!ptx_tbl) {
+                        dev_dbg(priv->adapter->dev,
+                                        "event: TID, RA not found in table\n");
+                        return;
+                }
+                spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags);
+                mwifiex_11n_delete_tx_ba_stream_tbl_entry(priv, ptx_tbl);
+                spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock, flags);
+        }
+}
+/*
+ * This function handles the command response of an add BA response.
+ *
+ * Handling includes changing the header fields into CPU format and
+ * creating the stream, provided the add BA is accepted.
+ */
+int mwifiex_ret_11n_addba_resp(struct mwifiex_private *priv,
+                               struct host_cmd_ds_command *resp)
+{
+        struct host_cmd_ds_11n_addba_rsp *add_ba_rsp =
+                (struct host_cmd_ds_11n_addba_rsp *)
+                &resp->params.add_ba_rsp;
+        int tid, win_size;
+        struct mwifiex_rx_reorder_tbl *rx_reor_tbl_ptr;
+        uint16_t block_ack_param_set;
+        block_ack_param_set = le16_to_cpu(add_ba_rsp->block_ack_param_set);
+        tid = (block_ack_param_set & IEEE80211_ADDBA_PARAM_TID_MASK)
+                >> BLOCKACKPARAM_TID_POS;
+        /*
+         * Check if we had rejected the ADDBA, if yes then do not create
+         * the stream
+         */
+        if (le16_to_cpu(add_ba_rsp->status_code) == BA_RESULT_SUCCESS) {
+                win_size = (block_ack_param_set &
+                        IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK)
+                        >> BLOCKACKPARAM_WINSIZE_POS;
+                dev_dbg(priv->adapter->dev, "cmd: ADDBA RSP: %pM"
+                       " tid=%d ssn=%d win_size=%d\n",
+                       add_ba_rsp->peer_mac_addr,
+                       tid, add_ba_rsp->ssn, win_size);
+        } else {
+                dev_err(priv->adapter->dev, "ADDBA RSP: failed %pM tid=%d)\n",
+                                        add_ba_rsp->peer_mac_addr, tid);
+                rx_reor_tbl_ptr = mwifiex_11n_get_rx_reorder_tbl(priv,
+                                        tid, add_ba_rsp->peer_mac_addr);
+                if (rx_reor_tbl_ptr)
+                        mwifiex_11n_delete_rx_reorder_tbl_entry(priv,
+                                rx_reor_tbl_ptr);
+        }
+        return 0;
+}
+/*
+ * This function handles BA stream timeout event by preparing and sending
+ * a command to the firmware.
+ */
+void mwifiex_11n_ba_stream_timeout(struct mwifiex_private *priv,
+                                   struct host_cmd_ds_11n_batimeout *event)
+{
+        struct host_cmd_ds_11n_delba delba;
+        memset(&delba, 0, sizeof(struct host_cmd_ds_11n_delba));
+        memcpy(delba.peer_mac_addr, event->peer_mac_addr, ETH_ALEN);
+        delba.del_ba_param_set |=
+                cpu_to_le16((u16) event->tid << DELBA_TID_POS);
+        delba.del_ba_param_set |= cpu_to_le16(
+                (u16) event->origninator << DELBA_INITIATOR_POS);
+        delba.reason_code = cpu_to_le16(WLAN_REASON_QSTA_TIMEOUT);
+        mwifiex_send_cmd_async(priv, HostCmd_CMD_11N_DELBA, 0, 0, &delba);
+}
+/*
+ * This function cleans up the Rx reorder table by deleting all the entries
+ * and re-initializing.
+ */
+void mwifiex_11n_cleanup_reorder_tbl(struct mwifiex_private *priv)
+{
+        struct mwifiex_rx_reorder_tbl *del_tbl_ptr, *tmp_node;
+        unsigned long flags;
+        spin_lock_irqsave(&priv->rx_reorder_tbl_lock, flags);
+        list_for_each_entry_safe(del_tbl_ptr, tmp_node,
+                                 &priv->rx_reorder_tbl_ptr, list) {
+                spin_unlock_irqrestore(&priv->rx_reorder_tbl_lock, flags);
+                mwifiex_11n_delete_rx_reorder_tbl_entry(priv, del_tbl_ptr);
+                spin_lock_irqsave(&priv->rx_reorder_tbl_lock, flags);
+        }
+        spin_unlock_irqrestore(&priv->rx_reorder_tbl_lock, flags);
+        INIT_LIST_HEAD(&priv->rx_reorder_tbl_ptr);
+        memset(priv->rx_seq, 0, sizeof(priv->rx_seq));
+}
diff --git a/drivers/net/wireless/mwifiex/11n_rxreorder.h b/drivers/net/wireless/mwifiex/11n_rxreorder.h
new file mode 100644
index 000000000000..f3ca8c8c18f9
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/11n_rxreorder.h
@@ -0,0 +1,65 @@
+/*
+ * Marvell Wireless LAN device driver: 802.11n RX Re-ordering
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef _MWIFIEX_11N_RXREORDER_H_
+#define _MWIFIEX_11N_RXREORDER_H_
+#define MIN_FLUSH_TIMER_MS              50
+#define PKT_TYPE_BAR 0xE7
+#define MAX_TID_VALUE                   (2 << 11)
+#define TWOPOW11                        (2 << 10)
+#define BLOCKACKPARAM_TID_POS           2
+#define BLOCKACKPARAM_AMSDU_SUPP_MASK   0x1
+#define BLOCKACKPARAM_WINSIZE_POS       6
+#define DELBA_TID_POS                   12
+#define DELBA_INITIATOR_POS             11
+#define TYPE_DELBA_SENT                 1
+#define TYPE_DELBA_RECEIVE              2
+#define IMMEDIATE_BLOCK_ACK             0x2
+#define ADDBA_RSP_STATUS_ACCEPT 0
+int mwifiex_11n_rx_reorder_pkt(struct mwifiex_private *,
+                               u16 seqNum,
+                               u16 tid, u8 *ta,
+                               u8 pkttype, void *payload);
+void mwifiex_11n_delete_ba_stream_tbl(struct mwifiex_private *priv, int Tid,
+                                     u8 *PeerMACAddr, u8 type,
+                                     int initiator);
+void mwifiex_11n_ba_stream_timeout(struct mwifiex_private *priv,
+                                   struct host_cmd_ds_11n_batimeout *event);
+int mwifiex_ret_11n_addba_resp(struct mwifiex_private *priv,
+                               struct host_cmd_ds_command
+                               *resp);
+int mwifiex_cmd_11n_delba(struct host_cmd_ds_command *cmd,
+                          void *data_buf);
+int mwifiex_cmd_11n_addba_rsp_gen(struct mwifiex_private *priv,
+                                  struct host_cmd_ds_command
+                                  *cmd, void *data_buf);
+int mwifiex_cmd_11n_addba_req(struct host_cmd_ds_command *cmd,
+                              void *data_buf);
+void mwifiex_11n_cleanup_reorder_tbl(struct mwifiex_private *priv);
+struct mwifiex_rx_reorder_tbl *mwifiex_11n_get_rxreorder_tbl(struct
+                                                           mwifiex_private
+                                                           *priv, int tid,
+                                                           u8 *ta);
+#endif /* _MWIFIEX_11N_RXREORDER_H_ */
diff --git a/drivers/net/wireless/mwifiex/Kconfig b/drivers/net/wireless/mwifiex/Kconfig
new file mode 100644
index 000000000000..86962920cef3
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/Kconfig
@@ -0,0 +1,21 @@
+config MWIFIEX
+        tristate "Marvell WiFi-Ex Driver"
+        depends on CFG80211
+        select LIB80211
+        ---help---
+          This adds support for wireless adapters based on Marvell
+          802.11n chipsets.
+          If you choose to build it as a module, it will be called
+          mwifiex.
+config MWIFIEX_SDIO
+        tristate "Marvell WiFi-Ex Driver for SD8787"
+        depends on MWIFIEX && MMC
+        select FW_LOADER
+        ---help---
+          This adds support for wireless adapters based on Marvell
+          8787 chipset with SDIO interface.
+          If you choose to build it as a module, it will be called
+          mwifiex_sdio.
diff --git a/drivers/net/wireless/mwifiex/Makefile b/drivers/net/wireless/mwifiex/Makefile
new file mode 100644
index 000000000000..42cb733ea33a
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/Makefile
@@ -0,0 +1,41 @@
+#
+# Copyright (C) 2011, Marvell International Ltd.
+#
+# This software file (the "File") is distributed by Marvell International
+# Ltd. under the terms of the GNU General Public License Version 2, June 1991
+# (the "License").  You may use, redistribute and/or modify this File in
+# accordance with the terms and conditions of the License, a copy of which
+# is available by writing to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+# worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+#
+# THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+# ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+# this warranty disclaimer.
+mwifiex-y += main.o
+mwifiex-y += init.o
+mwifiex-y += cfp.o
+mwifiex-y += cmdevt.o
+mwifiex-y += util.o
+mwifiex-y += txrx.o
+mwifiex-y += wmm.o
+mwifiex-y += 11n.o
+mwifiex-y += 11n_aggr.o
+mwifiex-y += 11n_rxreorder.o
+mwifiex-y += scan.o
+mwifiex-y += join.o
+mwifiex-y += sta_ioctl.o
+mwifiex-y += sta_cmd.o
+mwifiex-y += sta_cmdresp.o
+mwifiex-y += sta_event.o
+mwifiex-y += sta_tx.o
+mwifiex-y += sta_rx.o
+mwifiex-y += cfg80211.o
+mwifiex-$(CONFIG_DEBUG_FS) += debugfs.o
+obj-$(CONFIG_MWIFIEX) += mwifiex.o
+mwifiex_sdio-y += sdio.o
+obj-$(CONFIG_MWIFIEX_SDIO) += mwifiex_sdio.o
diff --git a/drivers/net/wireless/mwifiex/README b/drivers/net/wireless/mwifiex/README
new file mode 100644
index 000000000000..b55badef4660
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/README
@@ -0,0 +1,204 @@
+# Copyright (C) 2011, Marvell International Ltd.
+#
+# This software file (the "File") is distributed by Marvell International
+# Ltd. under the terms of the GNU General Public License Version 2, June 1991
+# (the "License").  You may use, redistribute and/or modify this File in
+# accordance with the terms and conditions of the License, a copy of which
+# is available by writing to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+# worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+#
+# THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+# ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+# this warranty disclaimer.
+===============================================================================
+                        U S E R  M A N U A L
+1) FOR DRIVER INSTALL
+        a) Copy sd8787.bin to /lib/firmware/mrvl/ directory,
+           create the directory if it doesn't exist.
+        b) Install WLAN driver,
+                insmod mwifiex.ko
+        c) Uninstall WLAN driver,
+                ifconfig mlanX down
+                rmmod mwifiex
+2) FOR DRIVER CONFIGURATION AND INFO
+        The configurations can be done either using the 'iw' user space
+        utility or debugfs.
+        a) 'iw' utility commands
+        Following are some useful iw commands:-
+iw dev mlan0 scan
+        This command will trigger a scan.
+        The command will then display the scan table entries
+iw dev mlan0 connect -w <SSID> [<freq in MHz>] [<bssid>] [key 0:abcde d:1123456789a]
+        The above command can be used to connect to an AP with a particular SSID.
+        Ap's operating frequency can be specified or even the bssid. If the AP is using
+        WEP encryption, wep keys can be specified in the command.
+        Note: Every time before connecting to an AP scan command (iw dev mlan0 scan) should be used by user.
+iw dev mlan0 disconnect
+        This command will be used to disconnect from an AP.
+iw dev mlan0 ibss join <SSID> <freq in MHz> [fixed-freq] [fixed-bssid] [key 0:abcde]
+        The command will be used to join or create an ibss. Optionally, operating frequency,
+        bssid and the security related parameters can be specified while joining/creating
+        and ibss.
+iw dev mlan0 ibss leave
+        The command will be used to leave an ibss network.
+iw dev mlan0 link
+        The command will be used to get the connection status. The command will return parameters
+        such as SSID, operating frequency, rx/tx packets, signal strength, tx bitrate.
+        Apart from the iw utility all standard configurations using the 'iwconfig' utility are also supported.
+        b) Debugfs interface
+        The debugfs interface can be used for configurations and for getting
+        some useful information from the driver.
+        The section below explains the configurations that can be
+        done.
+        Mount debugfs to /debugfs mount point:
+                mkdir /debugfs
+                mount -t debugfs debugfs /debugfs
+        The information is provided in /debugfs/mwifiex/mlanX/:
+iw reg set <country code>
+        The command will be used to change the regulatory domain.
+iw reg get
+        The command will be used to get current regulatory domain.
+info
+        This command is used to get driver info.
+        Usage:
+                cat info
+        driver_name = "mwifiex"
+        driver_version = <driver_name, driver_version, (firmware_version)>
+        interface_name = "mlanX"
+        bss_mode = "Ad-hoc" | "Managed" | "Auto" | "Unknown"
+        media_state = "Disconnected" | "Connected"
+        mac_address = <6-byte adapter MAC address>
+        multicase_count = <multicast address count>
+        essid = <current SSID>
+        bssid = <current BSSID>
+        channel = <current channel>
+        region_code = <current region code>
+        multicasr_address[n] = <multicast address>
+        num_tx_bytes = <number of bytes sent to device>
+        num_rx_bytes = <number of bytes received from device and sent to kernel>
+        num_tx_pkts = <number of packets sent to device>
+        num_rx_pkts = <number of packets received from device and sent to kernel>
+        num_tx_pkts_dropped = <number of Tx packets dropped by driver>
+        num_rx_pkts_dropped = <number of Rx packets dropped by driver>
+        num_tx_pkts_err = <number of Tx packets failed to send to device>
+        num_rx_pkts_err = <number of Rx packets failed to receive from device>
+        carrier "on" | "off"
+        tx queue "stopped" | "started"
+        The following debug info are provided in /debugfs/mwifiex/mlanX/debug:
+        int_counter = <interrupt count, cleared when interrupt handled>
+        wmm_ac_vo = <number of packets sent to device from WMM AcVo queue>
+        wmm_ac_vi = <number of packets sent to device from WMM AcVi queue>
+        wmm_ac_be = <number of packets sent to device from WMM AcBE queue>
+        wmm_ac_bk = <number of packets sent to device from WMM AcBK queue>
+        max_tx_buf_size = <maximum Tx buffer size>
+        tx_buf_size = <current Tx buffer size>
+        curr_tx_buf_size = <current Tx buffer size>
+        ps_mode = <0/1, CAM mode/PS mode>
+        ps_state = <0/1/2/3, full power state/awake state/pre-sleep state/sleep state>
+        is_deep_sleep = <0/1, not deep sleep state/deep sleep state>
+        wakeup_dev_req = <0/1, wakeup device not required/required>
+        wakeup_tries = <wakeup device count, cleared when device awake>
+        hs_configured = <0/1, host sleep not configured/configured>
+        hs_activated = <0/1, extended host sleep not activated/activated>
+        num_tx_timeout = <number of Tx timeout>
+        num_cmd_timeout = <number of timeout commands>
+        timeout_cmd_id = <command id of the last timeout command>
+        timeout_cmd_act = <command action of the last timeout command>
+        last_cmd_id = <command id of the last several commands sent to device>
+        last_cmd_act = <command action of the last several commands sent to device>
+        last_cmd_index = <0 based last command index>
+        last_cmd_resp_id = <command id of the last several command responses received from device>
+        last_cmd_resp_index = <0 based last command response index>
+        last_event = <event id of the last several events received from device>
+        last_event_index = <0 based last event index>
+        num_cmd_h2c_fail = <number of commands failed to send to device>
+        num_cmd_sleep_cfm_fail = <number of sleep confirm failed to send to device>
+        num_tx_h2c_fail = <number of data packets failed to send to device>
+        num_evt_deauth = <number of deauthenticated events received from device>
+        num_evt_disassoc = <number of disassociated events received from device>
+        num_evt_link_lost = <number of link lost events received from device>
+        num_cmd_deauth = <number of deauthenticate commands sent to device>
+        num_cmd_assoc_ok = <number of associate commands with success return>
+        num_cmd_assoc_fail = <number of associate commands with failure return>
+        cmd_sent = <0/1, send command resources available/sending command to device>
+        data_sent = <0/1, send data resources available/sending data to device>
+        mp_rd_bitmap = <SDIO multi-port read bitmap>
+        mp_wr_bitmap = <SDIO multi-port write bitmap>
+        cmd_resp_received = <0/1, no cmd response to process/response received and yet to process>
+        event_received = <0/1, no event to process/event received and yet to process>
+        cmd_pending = <number of cmd pending>
+        tx_pending = <number of Tx packet pending>
+        rx_pending = <number of Rx packet pending>
+3) FOR DRIVER CONFIGURATION
+regrdwr
+        This command is used to read/write the adapter register.
+        Usage:
+                echo " <type> <offset> [value]" > regrdwr
+                cat regrdwr
+        where the parameters are,
+                <type>:     1:MAC/SOC, 2:BBP, 3:RF, 4:PMIC, 5:CAU
+                <offset>:   offset of register
+                [value]:    value to be written
+        Examples:
+                echo "1 0xa060" > regrdwr           : Read the MAC register
+                echo "1 0xa060 0x12" > regrdwr      : Write the MAC register
+                echo "1 0xa794 0x80000000" > regrdwr
+                                                    : Write 0x80000000 to MAC register
+rdeeprom
+        This command is used to read the EEPROM contents of the card.
+        Usage:
+                echo "<offset> <length>" > rdeeprom
+                cat rdeeprom
+        where the parameters are,
+                <offset>:   multiples of 4
+                <length>:   4-20, multiples of 4
+        Example:
+                echo "0 20" > rdeeprom      : Read 20 bytes of EEPROM data from offset 0
+getlog
+        This command is used to get the statistics available in the station.
+        Usage:
+        cat getlog
+===============================================================================
diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c
new file mode 100644
index 000000000000..660831ce293c
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/cfg80211.c
@@ -0,0 +1,1417 @@
+/*
+ * Marvell Wireless LAN device driver: CFG80211
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "cfg80211.h"
+#include "main.h"
+/*
+ * This function maps the nl802.11 channel type into driver channel type.
+ *
+ * The mapping is as follows -
+ *      NL80211_CHAN_NO_HT     -> NO_SEC_CHANNEL
+ *      NL80211_CHAN_HT20      -> NO_SEC_CHANNEL
+ *      NL80211_CHAN_HT40PLUS  -> SEC_CHANNEL_ABOVE
+ *      NL80211_CHAN_HT40MINUS -> SEC_CHANNEL_BELOW
+ *      Others                 -> NO_SEC_CHANNEL
+ */
+static int
+mwifiex_cfg80211_channel_type_to_mwifiex_channels(enum nl80211_channel_type
+                                                  channel_type)
+{
+        switch (channel_type) {
+        case NL80211_CHAN_NO_HT:
+        case NL80211_CHAN_HT20:
+                return NO_SEC_CHANNEL;
+        case NL80211_CHAN_HT40PLUS:
+                return SEC_CHANNEL_ABOVE;
+        case NL80211_CHAN_HT40MINUS:
+                return SEC_CHANNEL_BELOW;
+        default:
+                return NO_SEC_CHANNEL;
+        }
+}
+/*
+ * This function maps the driver channel type into nl802.11 channel type.
+ *
+ * The mapping is as follows -
+ *      NO_SEC_CHANNEL      -> NL80211_CHAN_HT20
+ *      SEC_CHANNEL_ABOVE   -> NL80211_CHAN_HT40PLUS
+ *      SEC_CHANNEL_BELOW   -> NL80211_CHAN_HT40MINUS
+ *      Others              -> NL80211_CHAN_HT20
+ */
+static enum nl80211_channel_type
+mwifiex_channels_to_cfg80211_channel_type(int channel_type)
+{
+        switch (channel_type) {
+        case NO_SEC_CHANNEL:
+                return NL80211_CHAN_HT20;
+        case SEC_CHANNEL_ABOVE:
+                return NL80211_CHAN_HT40PLUS;
+        case SEC_CHANNEL_BELOW:
+                return NL80211_CHAN_HT40MINUS;
+        default:
+                return NL80211_CHAN_HT20;
+        }
+}
+/*
+ * This function checks whether WEP is set.
+ */
+static int
+mwifiex_is_alg_wep(u32 cipher)
+{
+        switch (cipher) {
+        case WLAN_CIPHER_SUITE_WEP40:
+        case WLAN_CIPHER_SUITE_WEP104:
+                return 1;
+        default:
+                break;
+        }
+        return 0;
+}
+/*
+ * This function retrieves the private structure from kernel wiphy structure.
+ */
+static void *mwifiex_cfg80211_get_priv(struct wiphy *wiphy)
+{
+        return (void *) (*(unsigned long *) wiphy_priv(wiphy));
+}
+/*
+ * CFG802.11 operation handler to delete a network key.
+ */
+static int
+mwifiex_cfg80211_del_key(struct wiphy *wiphy, struct net_device *netdev,
+                         u8 key_index, bool pairwise, const u8 *mac_addr)
+{
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        if (mwifiex_set_encode(priv, NULL, 0, key_index, 1)) {
+                wiphy_err(wiphy, "deleting the crypto keys\n");
+                return -EFAULT;
+        }
+        wiphy_dbg(wiphy, "info: crypto keys deleted\n");
+        return 0;
+}
+/*
+ * CFG802.11 operation handler to set Tx power.
+ */
+static int
+mwifiex_cfg80211_set_tx_power(struct wiphy *wiphy,
+                              enum nl80211_tx_power_setting type,
+                              int dbm)
+{
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        struct mwifiex_power_cfg power_cfg;
+        if (type == NL80211_TX_POWER_FIXED) {
+                power_cfg.is_power_auto = 0;
+                power_cfg.power_level = dbm;
+        } else {
+                power_cfg.is_power_auto = 1;
+        }
+        return mwifiex_set_tx_power(priv, &power_cfg);
+}
+/*
+ * CFG802.11 operation handler to set Power Save option.
+ *
+ * The timeout value, if provided, is currently ignored.
+ */
+static int
+mwifiex_cfg80211_set_power_mgmt(struct wiphy *wiphy,
+                                struct net_device *dev,
+                                bool enabled, int timeout)
+{
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        u32 ps_mode;
+        if (timeout)
+                wiphy_dbg(wiphy,
+                        "info: ignoring the timeout value"
+                        " for IEEE power save\n");
+        ps_mode = enabled;
+        return mwifiex_drv_set_power(priv, &ps_mode);
+}
+/*
+ * CFG802.11 operation handler to set the default network key.
+ */
+static int
+mwifiex_cfg80211_set_default_key(struct wiphy *wiphy, struct net_device *netdev,
+                                 u8 key_index, bool unicast,
+                                 bool multicast)
+{
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        /* Return if WEP key not configured */
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_DISABLED)
+                return 0;
+        if (mwifiex_set_encode(priv, NULL, 0, key_index, 0)) {
+                wiphy_err(wiphy, "set default Tx key index\n");
+                return -EFAULT;
+        }
+        return 0;
+}
+/*
+ * CFG802.11 operation handler to add a network key.
+ */
+static int
+mwifiex_cfg80211_add_key(struct wiphy *wiphy, struct net_device *netdev,
+                         u8 key_index, bool pairwise, const u8 *mac_addr,
+                         struct key_params *params)
+{
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        if (mwifiex_set_encode(priv, params->key, params->key_len,
+                                                        key_index, 0)) {
+                wiphy_err(wiphy, "crypto keys added\n");
+                return -EFAULT;
+        }
+        return 0;
+}
+/*
+ * This function sends domain information to the firmware.
+ *
+ * The following information are passed to the firmware -
+ *      - Country codes
+ *      - Sub bands (first channel, number of channels, maximum Tx power)
+ */
+static int mwifiex_send_domain_info_cmd_fw(struct wiphy *wiphy)
+{
+        u8 no_of_triplet = 0;
+        struct ieee80211_country_ie_triplet *t;
+        u8 no_of_parsed_chan = 0;
+        u8 first_chan = 0, next_chan = 0, max_pwr = 0;
+        u8 i, flag = 0;
+        enum ieee80211_band band;
+        struct ieee80211_supported_band *sband;
+        struct ieee80211_channel *ch;
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_802_11d_domain_reg *domain_info = &adapter->domain_reg;
+        /* Set country code */
+        domain_info->country_code[0] = priv->country_code[0];
+        domain_info->country_code[1] = priv->country_code[1];
+        domain_info->country_code[2] = ' ';
+        band = mwifiex_band_to_radio_type(adapter->config_bands);
+        if (!wiphy->bands[band]) {
+                wiphy_err(wiphy, "11D: setting domain info in FW\n");
+                return -1;
+        }
+        sband = wiphy->bands[band];
+        for (i = 0; i < sband->n_channels ; i++) {
+                ch = &sband->channels[i];
+                if (ch->flags & IEEE80211_CHAN_DISABLED)
+                        continue;
+                if (!flag) {
+                        flag = 1;
+                        first_chan = (u32) ch->hw_value;
+                        next_chan = first_chan;
+                        max_pwr = ch->max_power;
+                        no_of_parsed_chan = 1;
+                        continue;
+                }
+                if (ch->hw_value == next_chan + 1 &&
+                                ch->max_power == max_pwr) {
+                        next_chan++;
+                        no_of_parsed_chan++;
+                } else {
+                        t = &domain_info->triplet[no_of_triplet];
+                        t->chans.first_channel = first_chan;
+                        t->chans.num_channels = no_of_parsed_chan;
+                        t->chans.max_power = max_pwr;
+                        no_of_triplet++;
+                        first_chan = (u32) ch->hw_value;
+                        next_chan = first_chan;
+                        max_pwr = ch->max_power;
+                        no_of_parsed_chan = 1;
+                }
+        }
+        if (flag) {
+                t = &domain_info->triplet[no_of_triplet];
+                t->chans.first_channel = first_chan;
+                t->chans.num_channels = no_of_parsed_chan;
+                t->chans.max_power = max_pwr;
+                no_of_triplet++;
+        }
+        domain_info->no_of_triplet = no_of_triplet;
+        if (mwifiex_send_cmd_async(priv, HostCmd_CMD_802_11D_DOMAIN_INFO,
+                                     HostCmd_ACT_GEN_SET, 0, NULL)) {
+                wiphy_err(wiphy, "11D: setting domain info in FW\n");
+                return -1;
+        }
+        return 0;
+}
+/*
+ * CFG802.11 regulatory domain callback function.
+ *
+ * This function is called when the regulatory domain is changed due to the
+ * following reasons -
+ *      - Set by driver
+ *      - Set by system core
+ *      - Set by user
+ *      - Set bt Country IE
+ */
+static int mwifiex_reg_notifier(struct wiphy *wiphy,
+                struct regulatory_request *request)
+{
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        wiphy_dbg(wiphy, "info: cfg80211 regulatory domain callback for domain"
+                        " %c%c\n", request->alpha2[0], request->alpha2[1]);
+        memcpy(priv->country_code, request->alpha2, sizeof(request->alpha2));
+        switch (request->initiator) {
+        case NL80211_REGDOM_SET_BY_DRIVER:
+        case NL80211_REGDOM_SET_BY_CORE:
+        case NL80211_REGDOM_SET_BY_USER:
+                break;
+                /* Todo: apply driver specific changes in channel flags based
+                   on the request initiator if necessary. */
+        case NL80211_REGDOM_SET_BY_COUNTRY_IE:
+                break;
+        }
+        mwifiex_send_domain_info_cmd_fw(wiphy);
+        return 0;
+}
+/*
+ * This function sets the RF channel.
+ *
+ * This function creates multiple IOCTL requests, populates them accordingly
+ * and issues them to set the band/channel and frequency.
+ */
+static int
+mwifiex_set_rf_channel(struct mwifiex_private *priv,
+                       struct ieee80211_channel *chan,
+                       enum nl80211_channel_type channel_type)
+{
+        struct mwifiex_chan_freq_power cfp;
+        struct mwifiex_ds_band_cfg band_cfg;
+        u32 config_bands = 0;
+        struct wiphy *wiphy = priv->wdev->wiphy;
+        if (chan) {
+                memset(&band_cfg, 0, sizeof(band_cfg));
+                /* Set appropriate bands */
+                if (chan->band == IEEE80211_BAND_2GHZ)
+                        config_bands = BAND_B | BAND_G | BAND_GN;
+                else
+                        config_bands = BAND_AN | BAND_A;
+                if (priv->bss_mode == NL80211_IFTYPE_STATION
+                    || priv->bss_mode == NL80211_IFTYPE_UNSPECIFIED) {
+                        band_cfg.config_bands = config_bands;
+                } else if (priv->bss_mode == NL80211_IFTYPE_ADHOC) {
+                        band_cfg.config_bands = config_bands;
+                        band_cfg.adhoc_start_band = config_bands;
+                }
+                band_cfg.sec_chan_offset =
+                        mwifiex_cfg80211_channel_type_to_mwifiex_channels
+                        (channel_type);
+                if (mwifiex_set_radio_band_cfg(priv, &band_cfg))
+                        return -EFAULT;
+                mwifiex_send_domain_info_cmd_fw(wiphy);
+        }
+        wiphy_dbg(wiphy, "info: setting band %d, channel offset %d and "
+                "mode %d\n", config_bands, band_cfg.sec_chan_offset,
+                priv->bss_mode);
+        if (!chan)
+                return 0;
+        memset(&cfp, 0, sizeof(cfp));
+        cfp.freq = chan->center_freq;
+        cfp.channel = ieee80211_frequency_to_channel(chan->center_freq);
+        if (mwifiex_bss_set_channel(priv, &cfp))
+                return -EFAULT;
+        return mwifiex_drv_change_adhoc_chan(priv, cfp.channel);
+}
+/*
+ * CFG802.11 operation handler to set channel.
+ *
+ * This function can only be used when station is not connected.
+ */
+static int
+mwifiex_cfg80211_set_channel(struct wiphy *wiphy, struct net_device *dev,
+                             struct ieee80211_channel *chan,
+                             enum nl80211_channel_type channel_type)
+{
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        if (priv->media_connected) {
+                wiphy_err(wiphy, "This setting is valid only when station "
+                                "is not connected\n");
+                return -EINVAL;
+        }
+        return mwifiex_set_rf_channel(priv, chan, channel_type);
+}
+/*
+ * This function sets the fragmentation threshold.
+ *
+ * The fragmentation threshold value must lie between MWIFIEX_FRAG_MIN_VALUE
+ * and MWIFIEX_FRAG_MAX_VALUE.
+ */
+static int
+mwifiex_set_frag(struct mwifiex_private *priv, u32 frag_thr)
+{
+        int ret;
+        if (frag_thr < MWIFIEX_FRAG_MIN_VALUE
+            || frag_thr > MWIFIEX_FRAG_MAX_VALUE)
+                return -EINVAL;
+        /* Send request to firmware */
+        ret = mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_SNMP_MIB,
+                                    HostCmd_ACT_GEN_SET, FRAG_THRESH_I,
+                                    &frag_thr);
+        return ret;
+}
+/*
+ * This function sets the RTS threshold.
+ * The rts value must lie between MWIFIEX_RTS_MIN_VALUE
+ * and MWIFIEX_RTS_MAX_VALUE.
+ */
+static int
+mwifiex_set_rts(struct mwifiex_private *priv, u32 rts_thr)
+{
+        if (rts_thr < MWIFIEX_RTS_MIN_VALUE || rts_thr > MWIFIEX_RTS_MAX_VALUE)
+                rts_thr = MWIFIEX_RTS_MAX_VALUE;
+        return mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_SNMP_MIB,
+                                    HostCmd_ACT_GEN_SET, RTS_THRESH_I,
+                                    &rts_thr);
+}
+/*
+ * CFG802.11 operation handler to set wiphy parameters.
+ *
+ * This function can be used to set the RTS threshold and the
+ * Fragmentation threshold of the driver.
+ */
+static int
+mwifiex_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed)
+{
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        int ret = 0;
+        if (changed & WIPHY_PARAM_RTS_THRESHOLD) {
+                ret = mwifiex_set_rts(priv, wiphy->rts_threshold);
+                if (ret)
+                        return ret;
+        }
+        if (changed & WIPHY_PARAM_FRAG_THRESHOLD)
+                ret = mwifiex_set_frag(priv, wiphy->frag_threshold);
+        return ret;
+}
+/*
+ * CFG802.11 operation handler to change interface type.
+ */
+static int
+mwifiex_cfg80211_change_virtual_intf(struct wiphy *wiphy,
+                                     struct net_device *dev,
+                                     enum nl80211_iftype type, u32 *flags,
+                                     struct vif_params *params)
+{
+        int ret;
+        struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
+        if (priv->bss_mode == type) {
+                wiphy_warn(wiphy, "already set to required type\n");
+                return 0;
+        }
+        priv->bss_mode = type;
+        switch (type) {
+        case NL80211_IFTYPE_ADHOC:
+                dev->ieee80211_ptr->iftype = NL80211_IFTYPE_ADHOC;
+                wiphy_dbg(wiphy, "info: setting interface type to adhoc\n");
+                break;
+        case NL80211_IFTYPE_STATION:
+                dev->ieee80211_ptr->iftype = NL80211_IFTYPE_STATION;
+                wiphy_dbg(wiphy, "info: setting interface type to managed\n");
+                break;
+        case NL80211_IFTYPE_UNSPECIFIED:
+                dev->ieee80211_ptr->iftype = NL80211_IFTYPE_STATION;
+                wiphy_dbg(wiphy, "info: setting interface type to auto\n");
+                return 0;
+        default:
+                wiphy_err(wiphy, "unknown interface type: %d\n", type);
+                return -EINVAL;
+        }
+        mwifiex_deauthenticate(priv, NULL);
+        priv->sec_info.authentication_mode = NL80211_AUTHTYPE_OPEN_SYSTEM;
+        ret = mwifiex_send_cmd_sync(priv, HostCmd_CMD_SET_BSS_MODE,
+                                    HostCmd_ACT_GEN_SET, 0, NULL);
+        return ret;
+}
+/*
+ * This function dumps the station information on a buffer.
+ *
+ * The following information are shown -
+ *      - Total bytes transmitted
+ *      - Total bytes received
+ *      - Total packets transmitted
+ *      - Total packets received
+ *      - Signal quality level
+ *      - Transmission rate
+ */
+static int
+mwifiex_dump_station_info(struct mwifiex_private *priv,
+                          struct station_info *sinfo)
+{
+        struct mwifiex_ds_get_signal signal;
+        struct mwifiex_rate_cfg rate;
+        int ret = 0;
+        sinfo->filled = STATION_INFO_RX_BYTES | STATION_INFO_TX_BYTES |
+                STATION_INFO_RX_PACKETS |
+                STATION_INFO_TX_PACKETS
+                | STATION_INFO_SIGNAL | STATION_INFO_TX_BITRATE;
+        /* Get signal information from the firmware */
+        memset(&signal, 0, sizeof(struct mwifiex_ds_get_signal));
+        if (mwifiex_get_signal_info(priv, &signal)) {
+                dev_err(priv->adapter->dev, "getting signal information\n");
+                ret = -EFAULT;
+        }
+        if (mwifiex_drv_get_data_rate(priv, &rate)) {
+                dev_err(priv->adapter->dev, "getting data rate\n");
+                ret = -EFAULT;
+        }
+        sinfo->rx_bytes = priv->stats.rx_bytes;
+        sinfo->tx_bytes = priv->stats.tx_bytes;
+        sinfo->rx_packets = priv->stats.rx_packets;
+        sinfo->tx_packets = priv->stats.tx_packets;
+        sinfo->signal = priv->w_stats.qual.level;
+        sinfo->txrate.legacy = rate.rate;
+        return ret;
+}
+/*
+ * CFG802.11 operation handler to get station information.
+ *
+ * This function only works in connected mode, and dumps the
+ * requested station information, if available.
+ */
+static int
+mwifiex_cfg80211_get_station(struct wiphy *wiphy, struct net_device *dev,
+                             u8 *mac, struct station_info *sinfo)
+{
+        struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
+        mwifiex_dump_station_info(priv, sinfo);
+        if (!priv->media_connected)
+                return -ENOENT;
+        if (memcmp(mac, priv->cfg_bssid, ETH_ALEN))
+                return -ENOENT;
+        return mwifiex_dump_station_info(priv, sinfo);
+}
+/* Supported rates to be advertised to the cfg80211 */
+static struct ieee80211_rate mwifiex_rates[] = {
+        {.bitrate = 10, .hw_value = 2, },
+        {.bitrate = 20, .hw_value = 4, },
+        {.bitrate = 55, .hw_value = 11, },
+        {.bitrate = 110, .hw_value = 22, },
+        {.bitrate = 220, .hw_value = 44, },
+        {.bitrate = 60, .hw_value = 12, },
+        {.bitrate = 90, .hw_value = 18, },
+        {.bitrate = 120, .hw_value = 24, },
+        {.bitrate = 180, .hw_value = 36, },
+        {.bitrate = 240, .hw_value = 48, },
+        {.bitrate = 360, .hw_value = 72, },
+        {.bitrate = 480, .hw_value = 96, },
+        {.bitrate = 540, .hw_value = 108, },
+        {.bitrate = 720, .hw_value = 144, },
+};
+/* Channel definitions to be advertised to cfg80211 */
+static struct ieee80211_channel mwifiex_channels_2ghz[] = {
+        {.center_freq = 2412, .hw_value = 1, },
+        {.center_freq = 2417, .hw_value = 2, },
+        {.center_freq = 2422, .hw_value = 3, },
+        {.center_freq = 2427, .hw_value = 4, },
+        {.center_freq = 2432, .hw_value = 5, },
+        {.center_freq = 2437, .hw_value = 6, },
+        {.center_freq = 2442, .hw_value = 7, },
+        {.center_freq = 2447, .hw_value = 8, },
+        {.center_freq = 2452, .hw_value = 9, },
+        {.center_freq = 2457, .hw_value = 10, },
+        {.center_freq = 2462, .hw_value = 11, },
+        {.center_freq = 2467, .hw_value = 12, },
+        {.center_freq = 2472, .hw_value = 13, },
+        {.center_freq = 2484, .hw_value = 14, },
+};
+static struct ieee80211_supported_band mwifiex_band_2ghz = {
+        .channels = mwifiex_channels_2ghz,
+        .n_channels = ARRAY_SIZE(mwifiex_channels_2ghz),
+        .bitrates = mwifiex_rates,
+        .n_bitrates = 14,
+};
+static struct ieee80211_channel mwifiex_channels_5ghz[] = {
+        {.center_freq = 5040, .hw_value = 8, },
+        {.center_freq = 5060, .hw_value = 12, },
+        {.center_freq = 5080, .hw_value = 16, },
+        {.center_freq = 5170, .hw_value = 34, },
+        {.center_freq = 5190, .hw_value = 38, },
+        {.center_freq = 5210, .hw_value = 42, },
+        {.center_freq = 5230, .hw_value = 46, },
+        {.center_freq = 5180, .hw_value = 36, },
+        {.center_freq = 5200, .hw_value = 40, },
+        {.center_freq = 5220, .hw_value = 44, },
+        {.center_freq = 5240, .hw_value = 48, },
+        {.center_freq = 5260, .hw_value = 52, },
+        {.center_freq = 5280, .hw_value = 56, },
+        {.center_freq = 5300, .hw_value = 60, },
+        {.center_freq = 5320, .hw_value = 64, },
+        {.center_freq = 5500, .hw_value = 100, },
+        {.center_freq = 5520, .hw_value = 104, },
+        {.center_freq = 5540, .hw_value = 108, },
+        {.center_freq = 5560, .hw_value = 112, },
+        {.center_freq = 5580, .hw_value = 116, },
+        {.center_freq = 5600, .hw_value = 120, },
+        {.center_freq = 5620, .hw_value = 124, },
+        {.center_freq = 5640, .hw_value = 128, },
+        {.center_freq = 5660, .hw_value = 132, },
+        {.center_freq = 5680, .hw_value = 136, },
+        {.center_freq = 5700, .hw_value = 140, },
+        {.center_freq = 5745, .hw_value = 149, },
+        {.center_freq = 5765, .hw_value = 153, },
+        {.center_freq = 5785, .hw_value = 157, },
+        {.center_freq = 5805, .hw_value = 161, },
+        {.center_freq = 5825, .hw_value = 165, },
+};
+static struct ieee80211_supported_band mwifiex_band_5ghz = {
+        .channels = mwifiex_channels_5ghz,
+        .n_channels = ARRAY_SIZE(mwifiex_channels_5ghz),
+        .bitrates = mwifiex_rates - 4,
+        .n_bitrates = ARRAY_SIZE(mwifiex_rates) + 4,
+};
+/* Supported crypto cipher suits to be advertised to cfg80211 */
+static const u32 mwifiex_cipher_suites[] = {
+        WLAN_CIPHER_SUITE_WEP40,
+        WLAN_CIPHER_SUITE_WEP104,
+        WLAN_CIPHER_SUITE_TKIP,
+        WLAN_CIPHER_SUITE_CCMP,
+};
+/*
+ * CFG802.11 operation handler for disconnection request.
+ *
+ * This function does not work when there is already a disconnection
+ * procedure going on.
+ */
+static int
+mwifiex_cfg80211_disconnect(struct wiphy *wiphy, struct net_device *dev,
+                            u16 reason_code)
+{
+        struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
+        if (priv->disconnect)
+                return -EBUSY;
+        priv->disconnect = 1;
+        if (mwifiex_deauthenticate(priv, NULL))
+                return -EFAULT;
+        wiphy_dbg(wiphy, "info: successfully disconnected from %pM:"
+                " reason code %d\n", priv->cfg_bssid, reason_code);
+        queue_work(priv->workqueue, &priv->cfg_workqueue);
+        return 0;
+}
+/*
+ * This function informs the CFG802.11 subsystem of a new IBSS.
+ *
+ * The following information are sent to the CFG802.11 subsystem
+ * to register the new IBSS. If we do not register the new IBSS,
+ * a kernel panic will result.
+ *      - SSID
+ *      - SSID length
+ *      - BSSID
+ *      - Channel
+ */
+static int mwifiex_cfg80211_inform_ibss_bss(struct mwifiex_private *priv)
+{
+        struct ieee80211_channel *chan;
+        struct mwifiex_bss_info bss_info;
+        int ie_len;
+        u8 ie_buf[IEEE80211_MAX_SSID_LEN + sizeof(struct ieee_types_header)];
+        if (mwifiex_get_bss_info(priv, &bss_info))
+                return -1;
+        ie_buf[0] = WLAN_EID_SSID;
+        ie_buf[1] = bss_info.ssid.ssid_len;
+        memcpy(&ie_buf[sizeof(struct ieee_types_header)],
+                        &bss_info.ssid.ssid,
+                        bss_info.ssid.ssid_len);
+        ie_len = ie_buf[1] + sizeof(struct ieee_types_header);
+        chan = __ieee80211_get_channel(priv->wdev->wiphy,
+                        ieee80211_channel_to_frequency(bss_info.bss_chan,
+                                                priv->curr_bss_params.band));
+        cfg80211_inform_bss(priv->wdev->wiphy, chan,
+                bss_info.bssid, 0, WLAN_CAPABILITY_IBSS,
+                0, ie_buf, ie_len, 0, GFP_KERNEL);
+        memcpy(priv->cfg_bssid, bss_info.bssid, ETH_ALEN);
+        return 0;
+}
+/*
+ * This function informs the CFG802.11 subsystem of a new BSS connection.
+ *
+ * The following information are sent to the CFG802.11 subsystem
+ * to register the new BSS connection. If we do not register the new BSS,
+ * a kernel panic will result.
+ *      - MAC address
+ *      - Capabilities
+ *      - Beacon period
+ *      - RSSI value
+ *      - Channel
+ *      - Supported rates IE
+ *      - Extended capabilities IE
+ *      - DS parameter set IE
+ *      - HT Capability IE
+ *      - Vendor Specific IE (221)
+ *      - WPA IE
+ *      - RSN IE
+ */
+static int mwifiex_inform_bss_from_scan_result(struct mwifiex_private *priv,
+                                               struct mwifiex_802_11_ssid *ssid)
+{
+        struct mwifiex_bssdescriptor *scan_table;
+        int i, j;
+        struct ieee80211_channel *chan;
+        u8 *ie, *ie_buf;
+        u32 ie_len;
+        u8 *beacon;
+        int beacon_size;
+        u8 element_id, element_len;
+#define MAX_IE_BUF      2048
+        ie_buf = kzalloc(MAX_IE_BUF, GFP_KERNEL);
+        if (!ie_buf) {
+                dev_err(priv->adapter->dev, "%s: failed to alloc ie_buf\n",
+                                                __func__);
+                return -ENOMEM;
+        }
+        scan_table = priv->adapter->scan_table;
+        for (i = 0; i < priv->adapter->num_in_scan_table; i++) {
+                if (ssid) {
+                        /* Inform specific BSS only */
+                        if (memcmp(ssid->ssid, scan_table[i].ssid.ssid,
+                                           ssid->ssid_len))
+                                continue;
+                }
+                memset(ie_buf, 0, MAX_IE_BUF);
+                ie_buf[0] = WLAN_EID_SSID;
+                ie_buf[1] = scan_table[i].ssid.ssid_len;
+                memcpy(&ie_buf[sizeof(struct ieee_types_header)],
+                       scan_table[i].ssid.ssid, ie_buf[1]);
+                ie = ie_buf + ie_buf[1] + sizeof(struct ieee_types_header);
+                ie_len = ie_buf[1] + sizeof(struct ieee_types_header);
+                ie[0] = WLAN_EID_SUPP_RATES;
+                for (j = 0; j < sizeof(scan_table[i].supported_rates); j++) {
+                        if (!scan_table[i].supported_rates[j])
+                                break;
+                        else
+                                ie[j + sizeof(struct ieee_types_header)] =
+                                        scan_table[i].supported_rates[j];
+                }
+                ie[1] = j;
+                ie_len += ie[1] + sizeof(struct ieee_types_header);
+                beacon = scan_table[i].beacon_buf;
+                beacon_size = scan_table[i].beacon_buf_size;
+                /* Skip time stamp, beacon interval and capability */
+                if (beacon) {
+                        beacon += sizeof(scan_table[i].beacon_period)
+                                + sizeof(scan_table[i].time_stamp) +
+                                +sizeof(scan_table[i].cap_info_bitmap);
+                        beacon_size -= sizeof(scan_table[i].beacon_period)
+                                + sizeof(scan_table[i].time_stamp)
+                                + sizeof(scan_table[i].cap_info_bitmap);
+                }
+                while (beacon_size >= sizeof(struct ieee_types_header)) {
+                        ie = ie_buf + ie_len;
+                        element_id = *beacon;
+                        element_len = *(beacon + 1);
+                        if (beacon_size < (int) element_len +
+                            sizeof(struct ieee_types_header)) {
+                                dev_err(priv->adapter->dev, "%s: in processing"
+                                        " IE, bytes left < IE length\n",
+                                        __func__);
+                                break;
+                        }
+                        switch (element_id) {
+                        case WLAN_EID_EXT_CAPABILITY:
+                        case WLAN_EID_DS_PARAMS:
+                        case WLAN_EID_HT_CAPABILITY:
+                        case WLAN_EID_VENDOR_SPECIFIC:
+                        case WLAN_EID_RSN:
+                        case WLAN_EID_BSS_AC_ACCESS_DELAY:
+                                ie[0] = element_id;
+                                ie[1] = element_len;
+                                memcpy(&ie[sizeof(struct ieee_types_header)],
+                                       (u8 *) beacon
+                                       + sizeof(struct ieee_types_header),
+                                       element_len);
+                                ie_len += ie[1] +
+                                        sizeof(struct ieee_types_header);
+                                break;
+                        default:
+                                break;
+                        }
+                        beacon += element_len +
+                                        sizeof(struct ieee_types_header);
+                        beacon_size -= element_len +
+                                        sizeof(struct ieee_types_header);
+                }
+                chan = ieee80211_get_channel(priv->wdev->wiphy,
+                                                scan_table[i].freq);
+                cfg80211_inform_bss(priv->wdev->wiphy, chan,
+                                        scan_table[i].mac_address,
+                                        0, scan_table[i].cap_info_bitmap,
+                                        scan_table[i].beacon_period,
+                                        ie_buf, ie_len,
+                                        scan_table[i].rssi, GFP_KERNEL);
+        }
+        kfree(ie_buf);
+        return 0;
+}
+/*
+ * This function connects with a BSS.
+ *
+ * This function handles both Infra and Ad-Hoc modes. It also performs
+ * validity checking on the provided parameters, disconnects from the
+ * current BSS (if any), sets up the association/scan parameters,
+ * including security settings, and performs specific SSID scan before
+ * trying to connect.
+ *
+ * For Infra mode, the function returns failure if the specified SSID
+ * is not found in scan table. However, for Ad-Hoc mode, it can create
+ * the IBSS if it does not exist. On successful completion in either case,
+ * the function notifies the CFG802.11 subsystem of the new BSS connection,
+ * otherwise the kernel will panic.
+ */
+static int
+mwifiex_cfg80211_assoc(struct mwifiex_private *priv, size_t ssid_len, u8 *ssid,
+                       u8 *bssid, int mode, struct ieee80211_channel *channel,
+                       struct cfg80211_connect_params *sme, bool privacy)
+{
+        struct mwifiex_802_11_ssid req_ssid;
+        struct mwifiex_ssid_bssid ssid_bssid;
+        int ret, auth_type = 0;
+        memset(&req_ssid, 0, sizeof(struct mwifiex_802_11_ssid));
+        memset(&ssid_bssid, 0, sizeof(struct mwifiex_ssid_bssid));
+        req_ssid.ssid_len = ssid_len;
+        if (ssid_len > IEEE80211_MAX_SSID_LEN) {
+                dev_err(priv->adapter->dev, "invalid SSID - aborting\n");
+                return -EINVAL;
+        }
+        memcpy(req_ssid.ssid, ssid, ssid_len);
+        if (!req_ssid.ssid_len || req_ssid.ssid[0] < 0x20) {
+                dev_err(priv->adapter->dev, "invalid SSID - aborting\n");
+                return -EINVAL;
+        }
+        /* disconnect before try to associate */
+        mwifiex_deauthenticate(priv, NULL);
+        if (channel)
+                ret = mwifiex_set_rf_channel(priv, channel,
+                                mwifiex_channels_to_cfg80211_channel_type
+                                (priv->adapter->chan_offset));
+        ret = mwifiex_set_encode(priv, NULL, 0, 0, 1);  /* Disable keys */
+        if (mode == NL80211_IFTYPE_ADHOC) {
+                /* "privacy" is set only for ad-hoc mode */
+                if (privacy) {
+                        /*
+                         * Keep WLAN_CIPHER_SUITE_WEP104 for now so that
+                         * the firmware can find a matching network from the
+                         * scan. The cfg80211 does not give us the encryption
+                         * mode at this stage so just setting it to WEP here.
+                         */
+                        priv->sec_info.encryption_mode =
+                                        WLAN_CIPHER_SUITE_WEP104;
+                        priv->sec_info.authentication_mode =
+                                        NL80211_AUTHTYPE_OPEN_SYSTEM;
+                }
+                goto done;
+        }
+        /* Now handle infra mode. "sme" is valid for infra mode only */
+        if (sme->auth_type == NL80211_AUTHTYPE_AUTOMATIC
+                        || sme->auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM)
+                auth_type = NL80211_AUTHTYPE_OPEN_SYSTEM;
+        else if (sme->auth_type == NL80211_AUTHTYPE_SHARED_KEY)
+                auth_type = NL80211_AUTHTYPE_SHARED_KEY;
+        if (sme->crypto.n_ciphers_pairwise) {
+                priv->sec_info.encryption_mode =
+                                                sme->crypto.ciphers_pairwise[0];
+                priv->sec_info.authentication_mode = auth_type;
+        }
+        if (sme->crypto.cipher_group) {
+                priv->sec_info.encryption_mode = sme->crypto.cipher_group;
+                priv->sec_info.authentication_mode = auth_type;
+        }
+        if (sme->ie)
+                ret = mwifiex_set_gen_ie(priv, sme->ie, sme->ie_len);
+        if (sme->key) {
+                if (mwifiex_is_alg_wep(0) | mwifiex_is_alg_wep(0)) {
+                        dev_dbg(priv->adapter->dev,
+                                "info: setting wep encryption"
+                                " with key len %d\n", sme->key_len);
+                        ret = mwifiex_set_encode(priv, sme->key, sme->key_len,
+                                                        sme->key_idx, 0);
+                }
+        }
+done:
+        /* Do specific SSID scanning */
+        if (mwifiex_request_scan(priv, &req_ssid)) {
+                dev_err(priv->adapter->dev, "scan error\n");
+                return -EFAULT;
+        }
+        memcpy(&ssid_bssid.ssid, &req_ssid, sizeof(struct mwifiex_802_11_ssid));
+        if (mode != NL80211_IFTYPE_ADHOC) {
+                if (mwifiex_find_best_bss(priv, &ssid_bssid))
+                        return -EFAULT;
+                /* Inform the BSS information to kernel, otherwise
+                 * kernel will give a panic after successful assoc */
+                if (mwifiex_inform_bss_from_scan_result(priv, &req_ssid))
+                        return -EFAULT;
+        }
+        dev_dbg(priv->adapter->dev, "info: trying to associate to %s and bssid %pM\n",
+               (char *) req_ssid.ssid, ssid_bssid.bssid);
+        memcpy(&priv->cfg_bssid, ssid_bssid.bssid, 6);
+        /* Connect to BSS by ESSID */
+        memset(&ssid_bssid.bssid, 0, ETH_ALEN);
+        if (!netif_queue_stopped(priv->netdev))
+                netif_stop_queue(priv->netdev);
+        if (mwifiex_bss_start(priv, &ssid_bssid))
+                return -EFAULT;
+        if (mode == NL80211_IFTYPE_ADHOC) {
+                /* Inform the BSS information to kernel, otherwise
+                 * kernel will give a panic after successful assoc */
+                if (mwifiex_cfg80211_inform_ibss_bss(priv))
+                        return -EFAULT;
+        }
+        return ret;
+}
+/*
+ * CFG802.11 operation handler for association request.
+ *
+ * This function does not work when the current mode is set to Ad-Hoc, or
+ * when there is already an association procedure going on. The given BSS
+ * information is used to associate.
+ */
+static int
+mwifiex_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev,
+                         struct cfg80211_connect_params *sme)
+{
+        struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
+        int ret = 0;
+        if (priv->assoc_request)
+                return -EBUSY;
+        if (priv->bss_mode == NL80211_IFTYPE_ADHOC) {
+                wiphy_err(wiphy, "received infra assoc request "
+                                "when station is in ibss mode\n");
+                goto done;
+        }
+        priv->assoc_request = -EINPROGRESS;
+        wiphy_dbg(wiphy, "info: Trying to associate to %s and bssid %pM\n",
+               (char *) sme->ssid, sme->bssid);
+        ret = mwifiex_cfg80211_assoc(priv, sme->ssid_len, sme->ssid, sme->bssid,
+                                     priv->bss_mode, sme->channel, sme, 0);
+        priv->assoc_request = 1;
+done:
+        priv->assoc_result = ret;
+        queue_work(priv->workqueue, &priv->cfg_workqueue);
+        return ret;
+}
+/*
+ * CFG802.11 operation handler to join an IBSS.
+ *
+ * This function does not work in any mode other than Ad-Hoc, or if
+ * a join operation is already in progress.
+ */
+static int
+mwifiex_cfg80211_join_ibss(struct wiphy *wiphy, struct net_device *dev,
+                           struct cfg80211_ibss_params *params)
+{
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        int ret = 0;
+        if (priv->ibss_join_request)
+                return -EBUSY;
+        if (priv->bss_mode != NL80211_IFTYPE_ADHOC) {
+                wiphy_err(wiphy, "request to join ibss received "
+                                "when station is not in ibss mode\n");
+                goto done;
+        }
+        priv->ibss_join_request = -EINPROGRESS;
+        wiphy_dbg(wiphy, "info: trying to join to %s and bssid %pM\n",
+               (char *) params->ssid, params->bssid);
+        ret = mwifiex_cfg80211_assoc(priv, params->ssid_len, params->ssid,
+                                params->bssid, priv->bss_mode,
+                                params->channel, NULL, params->privacy);
+        priv->ibss_join_request = 1;
+done:
+        priv->ibss_join_result = ret;
+        queue_work(priv->workqueue, &priv->cfg_workqueue);
+        return ret;
+}
+/*
+ * CFG802.11 operation handler to leave an IBSS.
+ *
+ * This function does not work if a leave operation is
+ * already in progress.
+ */
+static int
+mwifiex_cfg80211_leave_ibss(struct wiphy *wiphy, struct net_device *dev)
+{
+        struct mwifiex_private *priv = mwifiex_cfg80211_get_priv(wiphy);
+        if (priv->disconnect)
+                return -EBUSY;
+        priv->disconnect = 1;
+        wiphy_dbg(wiphy, "info: disconnecting from essid %pM\n",
+                        priv->cfg_bssid);
+        if (mwifiex_deauthenticate(priv, NULL))
+                return -EFAULT;
+        queue_work(priv->workqueue, &priv->cfg_workqueue);
+        return 0;
+}
+/*
+ * CFG802.11 operation handler for scan request.
+ *
+ * This function issues a scan request to the firmware based upon
+ * the user specified scan configuration. On successfull completion,
+ * it also informs the results.
+ */
+static int
+mwifiex_cfg80211_scan(struct wiphy *wiphy, struct net_device *dev,
+                      struct cfg80211_scan_request *request)
+{
+        struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
+        wiphy_dbg(wiphy, "info: received scan request on %s\n", dev->name);
+        if (priv->scan_request && priv->scan_request != request)
+                return -EBUSY;
+        priv->scan_request = request;
+        queue_work(priv->workqueue, &priv->cfg_workqueue);
+        return 0;
+}
+/*
+ * This function sets up the CFG802.11 specific HT capability fields
+ * with default values.
+ *
+ * The following default values are set -
+ *      - HT Supported = True
+ *      - Maximum AMPDU length factor = IEEE80211_HT_MAX_AMPDU_64K
+ *      - Minimum AMPDU spacing = IEEE80211_HT_MPDU_DENSITY_NONE
+ *      - HT Capabilities supported by firmware
+ *      - MCS information, Rx mask = 0xff
+ *      - MCD information, Tx parameters = IEEE80211_HT_MCS_TX_DEFINED (0x01)
+ */
+static void
+mwifiex_setup_ht_caps(struct ieee80211_sta_ht_cap *ht_info,
+                      struct mwifiex_private *priv)
+{
+        int rx_mcs_supp;
+        struct ieee80211_mcs_info mcs_set;
+        u8 *mcs = (u8 *)&mcs_set;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        ht_info->ht_supported = true;
+        ht_info->ampdu_factor = IEEE80211_HT_MAX_AMPDU_64K;
+        ht_info->ampdu_density = IEEE80211_HT_MPDU_DENSITY_NONE;
+        memset(&ht_info->mcs, 0, sizeof(ht_info->mcs));
+        /* Fill HT capability information */
+        if (ISSUPP_CHANWIDTH40(adapter->hw_dot_11n_dev_cap))
+                ht_info->cap |= IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+        else
+                ht_info->cap &= ~IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+        if (ISSUPP_SHORTGI20(adapter->hw_dot_11n_dev_cap))
+                ht_info->cap |= IEEE80211_HT_CAP_SGI_20;
+        else
+                ht_info->cap &= ~IEEE80211_HT_CAP_SGI_20;
+        if (ISSUPP_SHORTGI40(adapter->hw_dot_11n_dev_cap))
+                ht_info->cap |= IEEE80211_HT_CAP_SGI_40;
+        else
+                ht_info->cap &= ~IEEE80211_HT_CAP_SGI_40;
+        if (ISSUPP_RXSTBC(adapter->hw_dot_11n_dev_cap))
+                ht_info->cap |= 1 << IEEE80211_HT_CAP_RX_STBC_SHIFT;
+        else
+                ht_info->cap &= ~(3 << IEEE80211_HT_CAP_RX_STBC_SHIFT);
+        if (ISSUPP_TXSTBC(adapter->hw_dot_11n_dev_cap))
+                ht_info->cap |= IEEE80211_HT_CAP_TX_STBC;
+        else
+                ht_info->cap &= ~IEEE80211_HT_CAP_TX_STBC;
+        ht_info->cap &= ~IEEE80211_HT_CAP_MAX_AMSDU;
+        ht_info->cap |= IEEE80211_HT_CAP_SM_PS;
+        rx_mcs_supp = GET_RXMCSSUPP(adapter->hw_dev_mcs_support);
+        /* Set MCS for 1x1 */
+        memset(mcs, 0xff, rx_mcs_supp);
+        /* Clear all the other values */
+        memset(&mcs[rx_mcs_supp], 0,
+                        sizeof(struct ieee80211_mcs_info) - rx_mcs_supp);
+        if (priv->bss_mode == NL80211_IFTYPE_STATION ||
+                        ISSUPP_CHANWIDTH40(adapter->hw_dot_11n_dev_cap))
+                /* Set MCS32 for infra mode or ad-hoc mode with 40MHz support */
+                SETHT_MCS32(mcs_set.rx_mask);
+        memcpy((u8 *) &ht_info->mcs, mcs, sizeof(struct ieee80211_mcs_info));
+        ht_info->mcs.tx_params = IEEE80211_HT_MCS_TX_DEFINED;
+}
+/* station cfg80211 operations */
+static struct cfg80211_ops mwifiex_cfg80211_ops = {
+        .change_virtual_intf = mwifiex_cfg80211_change_virtual_intf,
+        .scan = mwifiex_cfg80211_scan,
+        .connect = mwifiex_cfg80211_connect,
+        .disconnect = mwifiex_cfg80211_disconnect,
+        .get_station = mwifiex_cfg80211_get_station,
+        .set_wiphy_params = mwifiex_cfg80211_set_wiphy_params,
+        .set_channel = mwifiex_cfg80211_set_channel,
+        .join_ibss = mwifiex_cfg80211_join_ibss,
+        .leave_ibss = mwifiex_cfg80211_leave_ibss,
+        .add_key = mwifiex_cfg80211_add_key,
+        .del_key = mwifiex_cfg80211_del_key,
+        .set_default_key = mwifiex_cfg80211_set_default_key,
+        .set_power_mgmt = mwifiex_cfg80211_set_power_mgmt,
+        .set_tx_power = mwifiex_cfg80211_set_tx_power,
+};
+/*
+ * This function registers the device with CFG802.11 subsystem.
+ *
+ * The function creates the wireless device/wiphy, populates it with
+ * default parameters and handler function pointers, and finally
+ * registers the device.
+ */
+int mwifiex_register_cfg80211(struct net_device *dev, u8 *mac,
+                              struct mwifiex_private *priv)
+{
+        int ret;
+        void *wdev_priv;
+        struct wireless_dev *wdev;
+        wdev = kzalloc(sizeof(struct wireless_dev), GFP_KERNEL);
+        if (!wdev) {
+                dev_err(priv->adapter->dev, "%s: allocating wireless device\n",
+                                                __func__);
+                return -ENOMEM;
+        }
+        wdev->wiphy =
+                wiphy_new(&mwifiex_cfg80211_ops,
+                          sizeof(struct mwifiex_private *));
+        if (!wdev->wiphy) {
+                kfree(wdev);
+                return -ENOMEM;
+        }
+        wdev->iftype = NL80211_IFTYPE_STATION;
+        wdev->wiphy->max_scan_ssids = 10;
+        wdev->wiphy->interface_modes =
+                BIT(NL80211_IFTYPE_STATION) | BIT(NL80211_IFTYPE_ADHOC);
+        wdev->wiphy->bands[IEEE80211_BAND_2GHZ] = &mwifiex_band_2ghz;
+        mwifiex_setup_ht_caps(
+                &wdev->wiphy->bands[IEEE80211_BAND_2GHZ]->ht_cap, priv);
+        if (priv->adapter->config_bands & BAND_A) {
+                wdev->wiphy->bands[IEEE80211_BAND_5GHZ] = &mwifiex_band_5ghz;
+                mwifiex_setup_ht_caps(
+                        &wdev->wiphy->bands[IEEE80211_BAND_5GHZ]->ht_cap, priv);
+        } else {
+                wdev->wiphy->bands[IEEE80211_BAND_5GHZ] = NULL;
+        }
+        /* Initialize cipher suits */
+        wdev->wiphy->cipher_suites = mwifiex_cipher_suites;
+        wdev->wiphy->n_cipher_suites = ARRAY_SIZE(mwifiex_cipher_suites);
+        memcpy(wdev->wiphy->perm_addr, mac, 6);
+        wdev->wiphy->signal_type = CFG80211_SIGNAL_TYPE_MBM;
+        /* We are using custom domains */
+        wdev->wiphy->flags |= WIPHY_FLAG_CUSTOM_REGULATORY;
+        wdev->wiphy->reg_notifier = mwifiex_reg_notifier;
+        /* Set struct mwifiex_private pointer in wiphy_priv */
+        wdev_priv = wiphy_priv(wdev->wiphy);
+        *(unsigned long *) wdev_priv = (unsigned long) priv;
+        ret = wiphy_register(wdev->wiphy);
+        if (ret < 0) {
+                dev_err(priv->adapter->dev, "%s: registering cfg80211 device\n",
+                                                __func__);
+                wiphy_free(wdev->wiphy);
+                kfree(wdev);
+                return ret;
+        } else {
+                dev_dbg(priv->adapter->dev,
+                                "info: successfully registered wiphy device\n");
+        }
+        dev_net_set(dev, wiphy_net(wdev->wiphy));
+        dev->ieee80211_ptr = wdev;
+        memcpy(dev->dev_addr, wdev->wiphy->perm_addr, 6);
+        memcpy(dev->perm_addr, wdev->wiphy->perm_addr, 6);
+        SET_NETDEV_DEV(dev, wiphy_dev(wdev->wiphy));
+        priv->wdev = wdev;
+        dev->flags |= IFF_BROADCAST | IFF_MULTICAST;
+        dev->watchdog_timeo = MWIFIEX_DEFAULT_WATCHDOG_TIMEOUT;
+        dev->hard_header_len += MWIFIEX_MIN_DATA_HEADER_LEN;
+        return ret;
+}
+/*
+ * This function handles the result of different pending network operations.
+ *
+ * The following operations are handled and CFG802.11 subsystem is
+ * notified accordingly -
+ *      - Scan request completion
+ *      - Association request completion
+ *      - IBSS join request completion
+ *      - Disconnect request completion
+ */
+void
+mwifiex_cfg80211_results(struct work_struct *work)
+{
+        struct mwifiex_private *priv =
+                container_of(work, struct mwifiex_private, cfg_workqueue);
+        struct mwifiex_user_scan_cfg *scan_req;
+        int ret = 0, i;
+        struct ieee80211_channel *chan;
+        if (priv->scan_request) {
+                scan_req = kzalloc(sizeof(struct mwifiex_user_scan_cfg),
+                                   GFP_KERNEL);
+                if (!scan_req) {
+                        dev_err(priv->adapter->dev, "failed to alloc "
+                                                    "scan_req\n");
+                        return;
+                }
+                for (i = 0; i < priv->scan_request->n_ssids; i++) {
+                        memcpy(scan_req->ssid_list[i].ssid,
+                                        priv->scan_request->ssids[i].ssid,
+                                        priv->scan_request->ssids[i].ssid_len);
+                        scan_req->ssid_list[i].max_len =
+                                        priv->scan_request->ssids[i].ssid_len;
+                }
+                for (i = 0; i < priv->scan_request->n_channels; i++) {
+                        chan = priv->scan_request->channels[i];
+                        scan_req->chan_list[i].chan_number = chan->hw_value;
+                        scan_req->chan_list[i].radio_type = chan->band;
+                        if (chan->flags & IEEE80211_CHAN_DISABLED)
+                                scan_req->chan_list[i].scan_type =
+                                        MWIFIEX_SCAN_TYPE_PASSIVE;
+                        else
+                                scan_req->chan_list[i].scan_type =
+                                        MWIFIEX_SCAN_TYPE_ACTIVE;
+                        scan_req->chan_list[i].scan_time = 0;
+                }
+                if (mwifiex_set_user_scan_ioctl(priv, scan_req)) {
+                        ret = -EFAULT;
+                        goto done;
+                }
+                if (mwifiex_inform_bss_from_scan_result(priv, NULL))
+                        ret = -EFAULT;
+done:
+                priv->scan_result_status = ret;
+                dev_dbg(priv->adapter->dev, "info: %s: sending scan results\n",
+                                                        __func__);
+                cfg80211_scan_done(priv->scan_request,
+                                (priv->scan_result_status < 0));
+                priv->scan_request = NULL;
+                kfree(scan_req);
+        }
+        if (priv->assoc_request == 1) {
+                if (!priv->assoc_result) {
+                        cfg80211_connect_result(priv->netdev, priv->cfg_bssid,
+                                                NULL, 0, NULL, 0,
+                                                WLAN_STATUS_SUCCESS,
+                                                GFP_KERNEL);
+                        dev_dbg(priv->adapter->dev,
+                                "info: associated to bssid %pM successfully\n",
+                               priv->cfg_bssid);
+                } else {
+                        dev_dbg(priv->adapter->dev,
+                                "info: association to bssid %pM failed\n",
+                               priv->cfg_bssid);
+                        memset(priv->cfg_bssid, 0, ETH_ALEN);
+                }
+                priv->assoc_request = 0;
+                priv->assoc_result = 0;
+        }
+        if (priv->ibss_join_request == 1) {
+                if (!priv->ibss_join_result) {
+                        cfg80211_ibss_joined(priv->netdev, priv->cfg_bssid,
+                                             GFP_KERNEL);
+                        dev_dbg(priv->adapter->dev,
+                                "info: joined/created adhoc network with bssid"
+                                        " %pM successfully\n", priv->cfg_bssid);
+                } else {
+                        dev_dbg(priv->adapter->dev,
+                                "info: failed creating/joining adhoc network\n");
+                }
+                priv->ibss_join_request = 0;
+                priv->ibss_join_result = 0;
+        }
+        if (priv->disconnect) {
+                memset(priv->cfg_bssid, 0, ETH_ALEN);
+                priv->disconnect = 0;
+        }
+}
diff --git a/drivers/net/wireless/mwifiex/cfg80211.h b/drivers/net/wireless/mwifiex/cfg80211.h
new file mode 100644
index 000000000000..c4db8f36aa16
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/cfg80211.h
@@ -0,0 +1,31 @@
+/*
+ * Marvell Wireless LAN device driver: CFG80211
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef __MWIFIEX_CFG80211__
+#define __MWIFIEX_CFG80211__
+#include <net/cfg80211.h>
+#include "main.h"
+int mwifiex_register_cfg80211(struct net_device *, u8 *,
+                                struct mwifiex_private *);
+void mwifiex_cfg80211_results(struct work_struct *work);
+#endif
diff --git a/drivers/net/wireless/mwifiex/cfp.c b/drivers/net/wireless/mwifiex/cfp.c
new file mode 100644
index 000000000000..d0cada5a29a0
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/cfp.c
@@ -0,0 +1,360 @@
+/*
+ * Marvell Wireless LAN device driver: Channel, Frequence and Power
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "cfg80211.h"
+/* 100mW */
+#define MWIFIEX_TX_PWR_DEFAULT     20
+/* 100mW */
+#define MWIFIEX_TX_PWR_US_DEFAULT      20
+/* 50mW */
+#define MWIFIEX_TX_PWR_JP_DEFAULT      16
+/* 100mW */
+#define MWIFIEX_TX_PWR_FR_100MW        20
+/* 10mW */
+#define MWIFIEX_TX_PWR_FR_10MW         10
+/* 100mW */
+#define MWIFIEX_TX_PWR_EMEA_DEFAULT    20
+static u8 adhoc_rates_b[B_SUPPORTED_RATES] = { 0x82, 0x84, 0x8b, 0x96, 0 };
+static u8 adhoc_rates_g[G_SUPPORTED_RATES] = { 0x8c, 0x12, 0x98, 0x24,
+                                               0xb0, 0x48, 0x60, 0x6c, 0 };
+static u8 adhoc_rates_bg[BG_SUPPORTED_RATES] = { 0x82, 0x84, 0x8b, 0x96,
+                                                 0x0c, 0x12, 0x18, 0x24,
+                                                 0x30, 0x48, 0x60, 0x6c, 0 };
+static u8 adhoc_rates_a[A_SUPPORTED_RATES] = { 0x8c, 0x12, 0x98, 0x24,
+                                               0xb0, 0x48, 0x60, 0x6c, 0 };
+u8 supported_rates_a[A_SUPPORTED_RATES] = { 0x0c, 0x12, 0x18, 0x24,
+                                        0xb0, 0x48, 0x60, 0x6c, 0 };
+static u16 mwifiex_data_rates[MWIFIEX_SUPPORTED_RATES_EXT] = { 0x02, 0x04,
+                                        0x0B, 0x16, 0x00, 0x0C, 0x12, 0x18,
+                                        0x24, 0x30, 0x48, 0x60, 0x6C, 0x90,
+                                        0x0D, 0x1A, 0x27, 0x34, 0x4E, 0x68,
+                                        0x75, 0x82, 0x0C, 0x1B, 0x36, 0x51,
+                                        0x6C, 0xA2, 0xD8, 0xF3, 0x10E, 0x00 };
+u8 supported_rates_b[B_SUPPORTED_RATES] = { 0x02, 0x04, 0x0b, 0x16, 0 };
+u8 supported_rates_g[G_SUPPORTED_RATES] = { 0x0c, 0x12, 0x18, 0x24,
+                                        0x30, 0x48, 0x60, 0x6c, 0 };
+u8 supported_rates_bg[BG_SUPPORTED_RATES] = { 0x02, 0x04, 0x0b, 0x0c,
+                                        0x12, 0x16, 0x18, 0x24, 0x30, 0x48,
+                                        0x60, 0x6c, 0 };
+u16 region_code_index[MWIFIEX_MAX_REGION_CODE] = { 0x10, 0x20, 0x30,
+                                                0x32, 0x40, 0x41, 0xff };
+u8 supported_rates_n[N_SUPPORTED_RATES] = { 0x02, 0x04, 0 };
+/*
+ * This function maps an index in supported rates table into
+ * the corresponding data rate.
+ */
+u32 mwifiex_index_to_data_rate(u8 index, u8 ht_info)
+{
+        u16 mcs_rate[4][8] = {
+                {0x1b, 0x36, 0x51, 0x6c, 0xa2, 0xd8, 0xf3, 0x10e}
+        ,                       /* LG 40M */
+        {0x1e, 0x3c, 0x5a, 0x78, 0xb4, 0xf0, 0x10e, 0x12c}
+        ,                       /* SG 40M */
+        {0x0d, 0x1a, 0x27, 0x34, 0x4e, 0x68, 0x75, 0x82}
+        ,                       /* LG 20M */
+        {0x0e, 0x1c, 0x2b, 0x39, 0x56, 0x73, 0x82, 0x90}
+        };                      /* SG 20M */
+        u32 rate;
+        if (ht_info & BIT(0)) {
+                if (index == MWIFIEX_RATE_BITMAP_MCS0) {
+                        if (ht_info & BIT(2))
+                                rate = 0x0D;    /* MCS 32 SGI rate */
+                        else
+                                rate = 0x0C;    /* MCS 32 LGI rate */
+                } else if (index < 8) {
+                        if (ht_info & BIT(1)) {
+                                if (ht_info & BIT(2))
+                                        /* SGI, 40M */
+                                        rate = mcs_rate[1][index];
+                                else
+                                        /* LGI, 40M */
+                                        rate = mcs_rate[0][index];
+                        } else {
+                                if (ht_info & BIT(2))
+                                        /* SGI, 20M */
+                                        rate = mcs_rate[3][index];
+                                else
+                                        /* LGI, 20M */
+                                        rate = mcs_rate[2][index];
+                        }
+                } else
+                        rate = mwifiex_data_rates[0];
+        } else {
+                if (index >= MWIFIEX_SUPPORTED_RATES_EXT)
+                        index = 0;
+                rate = mwifiex_data_rates[index];
+        }
+        return rate;
+}
+/*
+ * This function maps a data rate value into corresponding index in supported
+ * rates table.
+ */
+u8 mwifiex_data_rate_to_index(u32 rate)
+{
+        u16 *ptr;
+        if (rate) {
+                ptr = memchr(mwifiex_data_rates, rate,
+                                sizeof(mwifiex_data_rates));
+                if (ptr)
+                        return (u8) (ptr - mwifiex_data_rates);
+        }
+        return 0;
+}
+/*
+ * This function returns the current active data rates.
+ *
+ * The result may vary depending upon connection status.
+ */
+u32 mwifiex_get_active_data_rates(struct mwifiex_private *priv, u8 *rates)
+{
+        if (!priv->media_connected)
+                return mwifiex_get_supported_rates(priv, rates);
+        else
+                return mwifiex_copy_rates(rates, 0,
+                                       priv->curr_bss_params.data_rates,
+                                       priv->curr_bss_params.num_of_rates);
+}
+/*
+ * This function locates the Channel-Frequency-Power triplet based upon
+ * band and channel parameters.
+ */
+struct mwifiex_chan_freq_power *
+mwifiex_get_cfp_by_band_and_channel_from_cfg80211(struct mwifiex_private
+                                                  *priv, u8 band, u16 channel)
+{
+        struct mwifiex_chan_freq_power *cfp = NULL;
+        struct ieee80211_supported_band *sband;
+        struct ieee80211_channel *ch;
+        int i;
+        if (mwifiex_band_to_radio_type(band) == HostCmd_SCAN_RADIO_TYPE_BG)
+                sband = priv->wdev->wiphy->bands[IEEE80211_BAND_2GHZ];
+        else
+                sband = priv->wdev->wiphy->bands[IEEE80211_BAND_5GHZ];
+        if (!sband) {
+                dev_err(priv->adapter->dev, "%s: cannot find cfp by band %d"
+                                " & channel %d\n", __func__, band, channel);
+                return cfp;
+        }
+        for (i = 0; i < sband->n_channels; i++) {
+                ch = &sband->channels[i];
+                if (((ch->hw_value == channel) ||
+                        (channel == FIRST_VALID_CHANNEL))
+                        && !(ch->flags & IEEE80211_CHAN_DISABLED)) {
+                        priv->cfp.channel = channel;
+                        priv->cfp.freq = ch->center_freq;
+                        priv->cfp.max_tx_power = ch->max_power;
+                        cfp = &priv->cfp;
+                        break;
+                }
+        }
+        if (i == sband->n_channels)
+                dev_err(priv->adapter->dev, "%s: cannot find cfp by band %d"
+                                " & channel %d\n", __func__, band, channel);
+        return cfp;
+}
+/*
+ * This function locates the Channel-Frequency-Power triplet based upon
+ * band and frequency parameters.
+ */
+struct mwifiex_chan_freq_power *
+mwifiex_get_cfp_by_band_and_freq_from_cfg80211(struct mwifiex_private *priv,
+                                               u8 band, u32 freq)
+{
+        struct mwifiex_chan_freq_power *cfp = NULL;
+        struct ieee80211_supported_band *sband;
+        struct ieee80211_channel *ch;
+        int i;
+        if (mwifiex_band_to_radio_type(band) == HostCmd_SCAN_RADIO_TYPE_BG)
+                sband = priv->wdev->wiphy->bands[IEEE80211_BAND_2GHZ];
+        else
+                sband = priv->wdev->wiphy->bands[IEEE80211_BAND_5GHZ];
+        if (!sband) {
+                dev_err(priv->adapter->dev, "%s: cannot find cfp by band %d"
+                                " & freq %d\n", __func__, band, freq);
+                return cfp;
+        }
+        for (i = 0; i < sband->n_channels; i++) {
+                ch = &sband->channels[i];
+                if ((ch->center_freq == freq) &&
+                        !(ch->flags & IEEE80211_CHAN_DISABLED)) {
+                        priv->cfp.channel = ch->hw_value;
+                        priv->cfp.freq = freq;
+                        priv->cfp.max_tx_power = ch->max_power;
+                        cfp = &priv->cfp;
+                        break;
+                }
+        }
+        if (i == sband->n_channels)
+                dev_err(priv->adapter->dev, "%s: cannot find cfp by band %d"
+                                " & freq %d\n", __func__, band, freq);
+        return cfp;
+}
+/*
+ * This function checks if the data rate is set to auto.
+ */
+u8
+mwifiex_is_rate_auto(struct mwifiex_private *priv)
+{
+        u32 i;
+        int rate_num = 0;
+        for (i = 0; i < ARRAY_SIZE(priv->bitmap_rates); i++)
+                if (priv->bitmap_rates[i])
+                        rate_num++;
+        if (rate_num > 1)
+                return true;
+        else
+                return false;
+}
+/*
+ * This function converts rate bitmap into rate index.
+ */
+int mwifiex_get_rate_index(u16 *rate_bitmap, int size)
+{
+        int i;
+        for (i = 0; i < size * 8; i++)
+                if (rate_bitmap[i / 16] & (1 << (i % 16)))
+                        return i;
+        return 0;
+}
+/*
+ * This function gets the supported data rates.
+ *
+ * The function works in both Ad-Hoc and infra mode by printing the
+ * band and returning the data rates.
+ */
+u32 mwifiex_get_supported_rates(struct mwifiex_private *priv, u8 *rates)
+{
+        u32 k = 0;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        if (priv->bss_mode == NL80211_IFTYPE_STATION) {
+                switch (adapter->config_bands) {
+                case BAND_B:
+                        dev_dbg(adapter->dev, "info: infra band=%d "
+                                "supported_rates_b\n", adapter->config_bands);
+                        k = mwifiex_copy_rates(rates, k, supported_rates_b,
+                                               sizeof(supported_rates_b));
+                        break;
+                case BAND_G:
+                case BAND_G | BAND_GN:
+                        dev_dbg(adapter->dev, "info: infra band=%d "
+                                "supported_rates_g\n", adapter->config_bands);
+                        k = mwifiex_copy_rates(rates, k, supported_rates_g,
+                                               sizeof(supported_rates_g));
+                        break;
+                case BAND_B | BAND_G:
+                case BAND_A | BAND_B | BAND_G:
+                case BAND_A | BAND_B:
+                case BAND_A | BAND_B | BAND_G | BAND_GN | BAND_AN:
+                case BAND_B | BAND_G | BAND_GN:
+                        dev_dbg(adapter->dev, "info: infra band=%d "
+                                "supported_rates_bg\n", adapter->config_bands);
+                        k = mwifiex_copy_rates(rates, k, supported_rates_bg,
+                                               sizeof(supported_rates_bg));
+                        break;
+                case BAND_A:
+                case BAND_A | BAND_G:
+                        dev_dbg(adapter->dev, "info: infra band=%d "
+                                "supported_rates_a\n", adapter->config_bands);
+                        k = mwifiex_copy_rates(rates, k, supported_rates_a,
+                                               sizeof(supported_rates_a));
+                        break;
+                case BAND_A | BAND_AN:
+                case BAND_A | BAND_G | BAND_AN | BAND_GN:
+                        dev_dbg(adapter->dev, "info: infra band=%d "
+                                "supported_rates_a\n", adapter->config_bands);
+                        k = mwifiex_copy_rates(rates, k, supported_rates_a,
+                                               sizeof(supported_rates_a));
+                        break;
+                case BAND_GN:
+                        dev_dbg(adapter->dev, "info: infra band=%d "
+                                "supported_rates_n\n", adapter->config_bands);
+                        k = mwifiex_copy_rates(rates, k, supported_rates_n,
+                                               sizeof(supported_rates_n));
+                        break;
+                }
+        } else {
+                /* Ad-hoc mode */
+                switch (adapter->adhoc_start_band) {
+                case BAND_B:
+                        dev_dbg(adapter->dev, "info: adhoc B\n");
+                        k = mwifiex_copy_rates(rates, k, adhoc_rates_b,
+                                               sizeof(adhoc_rates_b));
+                        break;
+                case BAND_G:
+                case BAND_G | BAND_GN:
+                        dev_dbg(adapter->dev, "info: adhoc G only\n");
+                        k = mwifiex_copy_rates(rates, k, adhoc_rates_g,
+                                               sizeof(adhoc_rates_g));
+                        break;
+                case BAND_B | BAND_G:
+                case BAND_B | BAND_G | BAND_GN:
+                        dev_dbg(adapter->dev, "info: adhoc BG\n");
+                        k = mwifiex_copy_rates(rates, k, adhoc_rates_bg,
+                                               sizeof(adhoc_rates_bg));
+                        break;
+                case BAND_A:
+                case BAND_A | BAND_AN:
+                        dev_dbg(adapter->dev, "info: adhoc A\n");
+                        k = mwifiex_copy_rates(rates, k, adhoc_rates_a,
+                                               sizeof(adhoc_rates_a));
+                        break;
+                }
+        }
+        return k;
+}
diff --git a/drivers/net/wireless/mwifiex/cmdevt.c b/drivers/net/wireless/mwifiex/cmdevt.c
new file mode 100644
index 000000000000..cd89fed206ae
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/cmdevt.c
@@ -0,0 +1,1414 @@
+/*
+ * Marvell Wireless LAN device driver: commands and events
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+/*
+ * This function initializes a command node.
+ *
+ * The actual allocation of the node is not done by this function. It only
+ * initiates a node by filling it with default parameters. Similarly,
+ * allocation of the different buffers used (IOCTL buffer, data buffer) are
+ * not done by this function either.
+ */
+static void
+mwifiex_init_cmd_node(struct mwifiex_private *priv,
+                      struct cmd_ctrl_node *cmd_node,
+                      u32 cmd_oid, void *data_buf)
+{
+        cmd_node->priv = priv;
+        cmd_node->cmd_oid = cmd_oid;
+        cmd_node->wait_q_enabled = priv->adapter->cmd_wait_q_required;
+        priv->adapter->cmd_wait_q_required = false;
+        cmd_node->data_buf = data_buf;
+        cmd_node->cmd_skb = cmd_node->skb;
+}
+/*
+ * This function returns a command node from the free queue depending upon
+ * availability.
+ */
+static struct cmd_ctrl_node *
+mwifiex_get_cmd_node(struct mwifiex_adapter *adapter)
+{
+        struct cmd_ctrl_node *cmd_node;
+        unsigned long flags;
+        spin_lock_irqsave(&adapter->cmd_free_q_lock, flags);
+        if (list_empty(&adapter->cmd_free_q)) {
+                dev_err(adapter->dev, "GET_CMD_NODE: cmd node not available\n");
+                spin_unlock_irqrestore(&adapter->cmd_free_q_lock, flags);
+                return NULL;
+        }
+        cmd_node = list_first_entry(&adapter->cmd_free_q,
+                        struct cmd_ctrl_node, list);
+        list_del(&cmd_node->list);
+        spin_unlock_irqrestore(&adapter->cmd_free_q_lock, flags);
+        return cmd_node;
+}
+/*
+ * This function cleans up a command node.
+ *
+ * The function resets the fields including the buffer pointers.
+ * This function does not try to free the buffers. They must be
+ * freed before calling this function.
+ *
+ * This function will however call the receive completion callback
+ * in case a response buffer is still available before resetting
+ * the pointer.
+ */
+static void
+mwifiex_clean_cmd_node(struct mwifiex_adapter *adapter,
+                       struct cmd_ctrl_node *cmd_node)
+{
+        cmd_node->cmd_oid = 0;
+        cmd_node->cmd_flag = 0;
+        cmd_node->data_buf = NULL;
+        cmd_node->wait_q_enabled = false;
+        if (cmd_node->resp_skb) {
+                dev_kfree_skb_any(cmd_node->resp_skb);
+                cmd_node->resp_skb = NULL;
+        }
+}
+/*
+ * This function sends a host command to the firmware.
+ *
+ * The function copies the host command into the driver command
+ * buffer, which will be transferred to the firmware later by the
+ * main thread.
+ */
+static int mwifiex_cmd_host_cmd(struct mwifiex_private *priv,
+                                struct host_cmd_ds_command *cmd, void *data_buf)
+{
+        struct mwifiex_ds_misc_cmd *pcmd_ptr =
+                (struct mwifiex_ds_misc_cmd *) data_buf;
+        /* Copy the HOST command to command buffer */
+        memcpy((void *) cmd, pcmd_ptr->cmd, pcmd_ptr->len);
+        dev_dbg(priv->adapter->dev, "cmd: host cmd size = %d\n", pcmd_ptr->len);
+        return 0;
+}
+/*
+ * This function downloads a command to the firmware.
+ *
+ * The function performs sanity tests, sets the command sequence
+ * number and size, converts the header fields to CPU format before
+ * sending. Afterwards, it logs the command ID and action for debugging
+ * and sets up the command timeout timer.
+ */
+static int mwifiex_dnld_cmd_to_fw(struct mwifiex_private *priv,
+                                  struct cmd_ctrl_node *cmd_node)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        int ret;
+        struct host_cmd_ds_command *host_cmd;
+        uint16_t cmd_code;
+        uint16_t cmd_size;
+        struct timeval tstamp;
+        unsigned long flags;
+        if (!adapter || !cmd_node)
+                return -1;
+        host_cmd = (struct host_cmd_ds_command *) (cmd_node->cmd_skb->data);
+        /* Sanity test */
+        if (host_cmd == NULL || host_cmd->size == 0) {
+                dev_err(adapter->dev, "DNLD_CMD: host_cmd is null"
+                        " or cmd size is 0, not sending\n");
+                if (cmd_node->wait_q_enabled)
+                        adapter->cmd_wait_q.status = -1;
+                mwifiex_insert_cmd_to_free_q(adapter, cmd_node);
+                return -1;
+        }
+        /* Set command sequence number */
+        adapter->seq_num++;
+        host_cmd->seq_num = cpu_to_le16(HostCmd_SET_SEQ_NO_BSS_INFO
+                            (adapter->seq_num, cmd_node->priv->bss_num,
+                             cmd_node->priv->bss_type));
+        spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+        adapter->curr_cmd = cmd_node;
+        spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+        cmd_code = le16_to_cpu(host_cmd->command);
+        cmd_size = le16_to_cpu(host_cmd->size);
+        skb_trim(cmd_node->cmd_skb, cmd_size);
+        do_gettimeofday(&tstamp);
+        dev_dbg(adapter->dev, "cmd: DNLD_CMD: (%lu.%lu): %#x, act %#x, len %d,"
+                " seqno %#x\n",
+                tstamp.tv_sec, tstamp.tv_usec, cmd_code,
+               le16_to_cpu(*(__le16 *) ((u8 *) host_cmd + S_DS_GEN)), cmd_size,
+               le16_to_cpu(host_cmd->seq_num));
+        skb_push(cmd_node->cmd_skb, INTF_HEADER_LEN);
+        ret = adapter->if_ops.host_to_card(adapter, MWIFIEX_TYPE_CMD,
+                                             cmd_node->cmd_skb->data,
+                                             cmd_node->cmd_skb->len, NULL);
+        skb_pull(cmd_node->cmd_skb, INTF_HEADER_LEN);
+        if (ret == -1) {
+                dev_err(adapter->dev, "DNLD_CMD: host to card failed\n");
+                if (cmd_node->wait_q_enabled)
+                        adapter->cmd_wait_q.status = -1;
+                mwifiex_insert_cmd_to_free_q(adapter, adapter->curr_cmd);
+                spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+                adapter->curr_cmd = NULL;
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+                adapter->dbg.num_cmd_host_to_card_failure++;
+                return -1;
+        }
+        /* Save the last command id and action to debug log */
+        adapter->dbg.last_cmd_index =
+                (adapter->dbg.last_cmd_index + 1) % DBG_CMD_NUM;
+        adapter->dbg.last_cmd_id[adapter->dbg.last_cmd_index] = cmd_code;
+        adapter->dbg.last_cmd_act[adapter->dbg.last_cmd_index] =
+                le16_to_cpu(*(__le16 *) ((u8 *) host_cmd + S_DS_GEN));
+        /* Clear BSS_NO_BITS from HostCmd */
+        cmd_code &= HostCmd_CMD_ID_MASK;
+        /* Setup the timer after transmit command */
+        mod_timer(&adapter->cmd_timer,
+                jiffies + (MWIFIEX_TIMER_10S * HZ) / 1000);
+        return 0;
+}
+/*
+ * This function downloads a sleep confirm command to the firmware.
+ *
+ * The function performs sanity tests, sets the command sequence
+ * number and size, converts the header fields to CPU format before
+ * sending.
+ *
+ * No responses are needed for sleep confirm command.
+ */
+static int mwifiex_dnld_sleep_confirm_cmd(struct mwifiex_adapter *adapter)
+{
+        int ret;
+        struct mwifiex_private *priv;
+        struct mwifiex_opt_sleep_confirm *sleep_cfm_buf =
+                                (struct mwifiex_opt_sleep_confirm *)
+                                adapter->sleep_cfm->data;
+        priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+        sleep_cfm_buf->seq_num =
+                cpu_to_le16((HostCmd_SET_SEQ_NO_BSS_INFO
+                                        (adapter->seq_num, priv->bss_num,
+                                         priv->bss_type)));
+        adapter->seq_num++;
+        skb_push(adapter->sleep_cfm, INTF_HEADER_LEN);
+        ret = adapter->if_ops.host_to_card(adapter, MWIFIEX_TYPE_CMD,
+                                             adapter->sleep_cfm->data,
+                                             adapter->sleep_cfm->len, NULL);
+        skb_pull(adapter->sleep_cfm, INTF_HEADER_LEN);
+        if (ret == -1) {
+                dev_err(adapter->dev, "SLEEP_CFM: failed\n");
+                adapter->dbg.num_cmd_sleep_cfm_host_to_card_failure++;
+                return -1;
+        }
+        if (GET_BSS_ROLE(mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY))
+                        == MWIFIEX_BSS_ROLE_STA) {
+                if (!sleep_cfm_buf->resp_ctrl)
+                        /* Response is not needed for sleep
+                           confirm command */
+                        adapter->ps_state = PS_STATE_SLEEP;
+                else
+                        adapter->ps_state = PS_STATE_SLEEP_CFM;
+                if (!sleep_cfm_buf->resp_ctrl
+                                && (adapter->is_hs_configured
+                                        && !adapter->sleep_period.period)) {
+                        adapter->pm_wakeup_card_req = true;
+                        mwifiex_hs_activated_event(mwifiex_get_priv(adapter,
+                                                MWIFIEX_BSS_ROLE_STA), true);
+                }
+        }
+        return ret;
+}
+/*
+ * This function allocates the command buffers and links them to
+ * the command free queue.
+ *
+ * The driver uses a pre allocated number of command buffers, which
+ * are created at driver initializations and freed at driver cleanup.
+ * Every command needs to obtain a command buffer from this pool before
+ * it can be issued. The command free queue lists the command buffers
+ * currently free to use, while the command pending queue lists the
+ * command buffers already in use and awaiting handling. Command buffers
+ * are returned to the free queue after use.
+ */
+int mwifiex_alloc_cmd_buffer(struct mwifiex_adapter *adapter)
+{
+        struct cmd_ctrl_node *cmd_array;
+        u32 buf_size;
+        u32 i;
+        /* Allocate and initialize struct cmd_ctrl_node */
+        buf_size = sizeof(struct cmd_ctrl_node) * MWIFIEX_NUM_OF_CMD_BUFFER;
+        cmd_array = kzalloc(buf_size, GFP_KERNEL);
+        if (!cmd_array) {
+                dev_err(adapter->dev, "%s: failed to alloc cmd_array\n",
+                                __func__);
+                return -ENOMEM;
+        }
+        adapter->cmd_pool = cmd_array;
+        memset(adapter->cmd_pool, 0, buf_size);
+        /* Allocate and initialize command buffers */
+        for (i = 0; i < MWIFIEX_NUM_OF_CMD_BUFFER; i++) {
+                cmd_array[i].skb = dev_alloc_skb(MWIFIEX_SIZE_OF_CMD_BUFFER);
+                if (!cmd_array[i].skb) {
+                        dev_err(adapter->dev, "ALLOC_CMD_BUF: out of memory\n");
+                        return -1;
+                }
+        }
+        for (i = 0; i < MWIFIEX_NUM_OF_CMD_BUFFER; i++)
+                mwifiex_insert_cmd_to_free_q(adapter, &cmd_array[i]);
+        return 0;
+}
+/*
+ * This function frees the command buffers.
+ *
+ * The function calls the completion callback for all the command
+ * buffers that still have response buffers associated with them.
+ */
+int mwifiex_free_cmd_buffer(struct mwifiex_adapter *adapter)
+{
+        struct cmd_ctrl_node *cmd_array;
+        u32 i;
+        /* Need to check if cmd pool is allocated or not */
+        if (!adapter->cmd_pool) {
+                dev_dbg(adapter->dev, "info: FREE_CMD_BUF: cmd_pool is null\n");
+                return 0;
+        }
+        cmd_array = adapter->cmd_pool;
+        /* Release shared memory buffers */
+        for (i = 0; i < MWIFIEX_NUM_OF_CMD_BUFFER; i++) {
+                if (cmd_array[i].skb) {
+                        dev_dbg(adapter->dev, "cmd: free cmd buffer %d\n", i);
+                        dev_kfree_skb_any(cmd_array[i].skb);
+                }
+                if (!cmd_array[i].resp_skb)
+                        continue;
+                dev_kfree_skb_any(cmd_array[i].resp_skb);
+        }
+        /* Release struct cmd_ctrl_node */
+        if (adapter->cmd_pool) {
+                dev_dbg(adapter->dev, "cmd: free cmd pool\n");
+                kfree(adapter->cmd_pool);
+                adapter->cmd_pool = NULL;
+        }
+        return 0;
+}
+/*
+ * This function handles events generated by firmware.
+ *
+ * Event body of events received from firmware are not used (though they are
+ * saved), only the event ID is used. Some events are re-invoked by
+ * the driver, with a new event body.
+ *
+ * After processing, the function calls the completion callback
+ * for cleanup.
+ */
+int mwifiex_process_event(struct mwifiex_adapter *adapter)
+{
+        int ret;
+        struct mwifiex_private *priv =
+                mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+        struct sk_buff *skb = adapter->event_skb;
+        u32 eventcause = adapter->event_cause;
+        struct timeval tstamp;
+        struct mwifiex_rxinfo *rx_info;
+        /* Save the last event to debug log */
+        adapter->dbg.last_event_index =
+                (adapter->dbg.last_event_index + 1) % DBG_CMD_NUM;
+        adapter->dbg.last_event[adapter->dbg.last_event_index] =
+                (u16) eventcause;
+        /* Get BSS number and corresponding priv */
+        priv = mwifiex_get_priv_by_id(adapter, EVENT_GET_BSS_NUM(eventcause),
+                                      EVENT_GET_BSS_TYPE(eventcause));
+        if (!priv)
+                priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+        /* Clear BSS_NO_BITS from event */
+        eventcause &= EVENT_ID_MASK;
+        adapter->event_cause = eventcause;
+        if (skb) {
+                rx_info = MWIFIEX_SKB_RXCB(skb);
+                rx_info->bss_index = priv->bss_index;
+        }
+        if (eventcause != EVENT_PS_SLEEP && eventcause != EVENT_PS_AWAKE) {
+                do_gettimeofday(&tstamp);
+                dev_dbg(adapter->dev, "event: %lu.%lu: cause: %#x\n",
+                       tstamp.tv_sec, tstamp.tv_usec, eventcause);
+        }
+        ret = mwifiex_process_sta_event(priv);
+        adapter->event_cause = 0;
+        adapter->event_skb = NULL;
+        dev_kfree_skb_any(skb);
+        return ret;
+}
+/*
+ * This function is used to send synchronous command to the firmware.
+ *
+ * it allocates a wait queue for the command and wait for the command
+ * response.
+ */
+int mwifiex_send_cmd_sync(struct mwifiex_private *priv, uint16_t cmd_no,
+                          u16 cmd_action, u32 cmd_oid, void *data_buf)
+{
+        int ret = 0;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        adapter->cmd_wait_q_required = true;
+        adapter->cmd_wait_q.condition = false;
+        ret = mwifiex_send_cmd_async(priv, cmd_no, cmd_action, cmd_oid,
+                                     data_buf);
+        if (!ret)
+                ret = mwifiex_wait_queue_complete(adapter);
+        return ret;
+}
+/*
+ * This function prepares a command and asynchronously send it to the firmware.
+ *
+ * Preparation includes -
+ *      - Sanity tests to make sure the card is still present or the FW
+ *        is not reset
+ *      - Getting a new command node from the command free queue
+ *      - Initializing the command node for default parameters
+ *      - Fill up the non-default parameters and buffer pointers
+ *      - Add the command to pending queue
+ */
+int mwifiex_send_cmd_async(struct mwifiex_private *priv, uint16_t cmd_no,
+                           u16 cmd_action, u32 cmd_oid, void *data_buf)
+{
+        int ret;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct cmd_ctrl_node *cmd_node;
+        struct host_cmd_ds_command *cmd_ptr;
+        if (!adapter) {
+                pr_err("PREP_CMD: adapter is NULL\n");
+                return -1;
+        }
+        if (adapter->is_suspended) {
+                dev_err(adapter->dev, "PREP_CMD: device in suspended state\n");
+                return -1;
+        }
+        if (adapter->surprise_removed) {
+                dev_err(adapter->dev, "PREP_CMD: card is removed\n");
+                return -1;
+        }
+        if (adapter->hw_status == MWIFIEX_HW_STATUS_RESET) {
+                if (cmd_no != HostCmd_CMD_FUNC_INIT) {
+                        dev_err(adapter->dev, "PREP_CMD: FW in reset state\n");
+                        return -1;
+                }
+        }
+        /* Get a new command node */
+        cmd_node = mwifiex_get_cmd_node(adapter);
+        if (!cmd_node) {
+                dev_err(adapter->dev, "PREP_CMD: no free cmd node\n");
+                return -1;
+        }
+        /* Initialize the command node */
+        mwifiex_init_cmd_node(priv, cmd_node, cmd_oid, data_buf);
+        if (!cmd_node->cmd_skb) {
+                dev_err(adapter->dev, "PREP_CMD: no free cmd buf\n");
+                return -1;
+        }
+        memset(skb_put(cmd_node->cmd_skb, sizeof(struct host_cmd_ds_command)),
+               0, sizeof(struct host_cmd_ds_command));
+        cmd_ptr = (struct host_cmd_ds_command *) (cmd_node->cmd_skb->data);
+        cmd_ptr->command = cpu_to_le16(cmd_no);
+        cmd_ptr->result = 0;
+        /* Prepare command */
+        if (cmd_no) {
+                ret = mwifiex_sta_prepare_cmd(priv, cmd_no, cmd_action,
+                                              cmd_oid, data_buf, cmd_ptr);
+        } else {
+                ret = mwifiex_cmd_host_cmd(priv, cmd_ptr, data_buf);
+                cmd_node->cmd_flag |= CMD_F_HOSTCMD;
+        }
+        /* Return error, since the command preparation failed */
+        if (ret) {
+                dev_err(adapter->dev, "PREP_CMD: cmd %#x preparation failed\n",
+                                                        cmd_no);
+                mwifiex_insert_cmd_to_free_q(adapter, cmd_node);
+                return -1;
+        }
+        /* Send command */
+        if (cmd_no == HostCmd_CMD_802_11_SCAN)
+                mwifiex_queue_scan_cmd(priv, cmd_node);
+        else
+                mwifiex_insert_cmd_to_pending_q(adapter, cmd_node, true);
+        return ret;
+}
+/*
+ * This function returns a command to the command free queue.
+ *
+ * The function also calls the completion callback if required, before
+ * cleaning the command node and re-inserting it into the free queue.
+ */
+void
+mwifiex_insert_cmd_to_free_q(struct mwifiex_adapter *adapter,
+                             struct cmd_ctrl_node *cmd_node)
+{
+        unsigned long flags;
+        if (!cmd_node)
+                return;
+        if (cmd_node->wait_q_enabled)
+                mwifiex_complete_cmd(adapter);
+        /* Clean the node */
+        mwifiex_clean_cmd_node(adapter, cmd_node);
+        /* Insert node into cmd_free_q */
+        spin_lock_irqsave(&adapter->cmd_free_q_lock, flags);
+        list_add_tail(&cmd_node->list, &adapter->cmd_free_q);
+        spin_unlock_irqrestore(&adapter->cmd_free_q_lock, flags);
+}
+/*
+ * This function queues a command to the command pending queue.
+ *
+ * This in effect adds the command to the command list to be executed.
+ * Exit PS command is handled specially, by placing it always to the
+ * front of the command queue.
+ */
+void
+mwifiex_insert_cmd_to_pending_q(struct mwifiex_adapter *adapter,
+                                struct cmd_ctrl_node *cmd_node, u32 add_tail)
+{
+        struct host_cmd_ds_command *host_cmd = NULL;
+        u16 command;
+        unsigned long flags;
+        host_cmd = (struct host_cmd_ds_command *) (cmd_node->cmd_skb->data);
+        if (!host_cmd) {
+                dev_err(adapter->dev, "QUEUE_CMD: host_cmd is NULL\n");
+                return;
+        }
+        command = le16_to_cpu(host_cmd->command);
+        /* Exit_PS command needs to be queued in the header always. */
+        if (command == HostCmd_CMD_802_11_PS_MODE_ENH) {
+                struct host_cmd_ds_802_11_ps_mode_enh *pm =
+                        &host_cmd->params.psmode_enh;
+                if ((le16_to_cpu(pm->action) == DIS_PS)
+                    || (le16_to_cpu(pm->action) == DIS_AUTO_PS)) {
+                        if (adapter->ps_state != PS_STATE_AWAKE)
+                                add_tail = false;
+                }
+        }
+        spin_lock_irqsave(&adapter->cmd_pending_q_lock, flags);
+        if (add_tail)
+                list_add_tail(&cmd_node->list, &adapter->cmd_pending_q);
+        else
+                list_add(&cmd_node->list, &adapter->cmd_pending_q);
+        spin_unlock_irqrestore(&adapter->cmd_pending_q_lock, flags);
+        dev_dbg(adapter->dev, "cmd: QUEUE_CMD: cmd=%#x is queued\n", command);
+}
+/*
+ * This function executes the next command in command pending queue.
+ *
+ * This function will fail if a command is already in processing stage,
+ * otherwise it will dequeue the first command from the command pending
+ * queue and send to the firmware.
+ *
+ * If the device is currently in host sleep mode, any commands, except the
+ * host sleep configuration command will de-activate the host sleep. For PS
+ * mode, the function will put the firmware back to sleep if applicable.
+ */
+int mwifiex_exec_next_cmd(struct mwifiex_adapter *adapter)
+{
+        struct mwifiex_private *priv;
+        struct cmd_ctrl_node *cmd_node;
+        int ret = 0;
+        struct host_cmd_ds_command *host_cmd;
+        unsigned long cmd_flags;
+        unsigned long cmd_pending_q_flags;
+        /* Check if already in processing */
+        if (adapter->curr_cmd) {
+                dev_err(adapter->dev, "EXEC_NEXT_CMD: cmd in processing\n");
+                return -1;
+        }
+        spin_lock_irqsave(&adapter->mwifiex_cmd_lock, cmd_flags);
+        /* Check if any command is pending */
+        spin_lock_irqsave(&adapter->cmd_pending_q_lock, cmd_pending_q_flags);
+        if (list_empty(&adapter->cmd_pending_q)) {
+                spin_unlock_irqrestore(&adapter->cmd_pending_q_lock,
+                                       cmd_pending_q_flags);
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, cmd_flags);
+                return 0;
+        }
+        cmd_node = list_first_entry(&adapter->cmd_pending_q,
+                                    struct cmd_ctrl_node, list);
+        spin_unlock_irqrestore(&adapter->cmd_pending_q_lock,
+                               cmd_pending_q_flags);
+        host_cmd = (struct host_cmd_ds_command *) (cmd_node->cmd_skb->data);
+        priv = cmd_node->priv;
+        if (adapter->ps_state != PS_STATE_AWAKE) {
+                dev_err(adapter->dev, "%s: cannot send cmd in sleep state,"
+                                " this should not happen\n", __func__);
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, cmd_flags);
+                return ret;
+        }
+        spin_lock_irqsave(&adapter->cmd_pending_q_lock, cmd_pending_q_flags);
+        list_del(&cmd_node->list);
+        spin_unlock_irqrestore(&adapter->cmd_pending_q_lock,
+                               cmd_pending_q_flags);
+        spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, cmd_flags);
+        ret = mwifiex_dnld_cmd_to_fw(priv, cmd_node);
+        priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+        /* Any command sent to the firmware when host is in sleep
+         * mode should de-configure host sleep. We should skip the
+         * host sleep configuration command itself though
+         */
+        if (priv && (host_cmd->command !=
+             cpu_to_le16(HostCmd_CMD_802_11_HS_CFG_ENH))) {
+                if (adapter->hs_activated) {
+                        adapter->is_hs_configured = false;
+                        mwifiex_hs_activated_event(priv, false);
+                }
+        }
+        return ret;
+}
+/*
+ * This function handles the command response.
+ *
+ * After processing, the function cleans the command node and puts
+ * it back to the command free queue.
+ */
+int mwifiex_process_cmdresp(struct mwifiex_adapter *adapter)
+{
+        struct host_cmd_ds_command *resp;
+        struct mwifiex_private *priv =
+                mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+        int ret = 0;
+        uint16_t orig_cmdresp_no;
+        uint16_t cmdresp_no;
+        uint16_t cmdresp_result;
+        struct timeval tstamp;
+        unsigned long flags;
+        /* Now we got response from FW, cancel the command timer */
+        del_timer(&adapter->cmd_timer);
+        if (!adapter->curr_cmd || !adapter->curr_cmd->resp_skb) {
+                resp = (struct host_cmd_ds_command *) adapter->upld_buf;
+                dev_err(adapter->dev, "CMD_RESP: NULL curr_cmd, %#x\n",
+                       le16_to_cpu(resp->command));
+                return -1;
+        }
+        adapter->num_cmd_timeout = 0;
+        resp = (struct host_cmd_ds_command *) adapter->curr_cmd->resp_skb->data;
+        if (adapter->curr_cmd->cmd_flag & CMD_F_CANCELED) {
+                dev_err(adapter->dev, "CMD_RESP: %#x been canceled\n",
+                                le16_to_cpu(resp->command));
+                mwifiex_insert_cmd_to_free_q(adapter, adapter->curr_cmd);
+                spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+                adapter->curr_cmd = NULL;
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+                return -1;
+        }
+        if (adapter->curr_cmd->cmd_flag & CMD_F_HOSTCMD) {
+                /* Copy original response back to response buffer */
+                struct mwifiex_ds_misc_cmd *hostcmd = NULL;
+                uint16_t size = le16_to_cpu(resp->size);
+                dev_dbg(adapter->dev, "info: host cmd resp size = %d\n", size);
+                size = min_t(u16, size, MWIFIEX_SIZE_OF_CMD_BUFFER);
+                if (adapter->curr_cmd->data_buf) {
+                        hostcmd = (struct mwifiex_ds_misc_cmd *)
+                                                adapter->curr_cmd->data_buf;
+                        hostcmd->len = size;
+                        memcpy(hostcmd->cmd, (void *) resp, size);
+                }
+        }
+        orig_cmdresp_no = le16_to_cpu(resp->command);
+        /* Get BSS number and corresponding priv */
+        priv = mwifiex_get_priv_by_id(adapter,
+                        HostCmd_GET_BSS_NO(le16_to_cpu(resp->seq_num)),
+                        HostCmd_GET_BSS_TYPE(le16_to_cpu(resp->seq_num)));
+        if (!priv)
+                priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+        /* Clear RET_BIT from HostCmd */
+        resp->command = cpu_to_le16(orig_cmdresp_no & HostCmd_CMD_ID_MASK);
+        cmdresp_no = le16_to_cpu(resp->command);
+        cmdresp_result = le16_to_cpu(resp->result);
+        /* Save the last command response to debug log */
+        adapter->dbg.last_cmd_resp_index =
+                (adapter->dbg.last_cmd_resp_index + 1) % DBG_CMD_NUM;
+        adapter->dbg.last_cmd_resp_id[adapter->dbg.last_cmd_resp_index] =
+                orig_cmdresp_no;
+        do_gettimeofday(&tstamp);
+        dev_dbg(adapter->dev, "cmd: CMD_RESP: (%lu.%lu): 0x%x, result %d,"
+                " len %d, seqno 0x%x\n",
+               tstamp.tv_sec, tstamp.tv_usec, orig_cmdresp_no, cmdresp_result,
+               le16_to_cpu(resp->size), le16_to_cpu(resp->seq_num));
+        if (!(orig_cmdresp_no & HostCmd_RET_BIT)) {
+                dev_err(adapter->dev, "CMD_RESP: invalid cmd resp\n");
+                if (adapter->curr_cmd->wait_q_enabled)
+                        adapter->cmd_wait_q.status = -1;
+                mwifiex_insert_cmd_to_free_q(adapter, adapter->curr_cmd);
+                spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+                adapter->curr_cmd = NULL;
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+                return -1;
+        }
+        if (adapter->curr_cmd->cmd_flag & CMD_F_HOSTCMD) {
+                adapter->curr_cmd->cmd_flag &= ~CMD_F_HOSTCMD;
+                if ((cmdresp_result == HostCmd_RESULT_OK)
+                    && (cmdresp_no == HostCmd_CMD_802_11_HS_CFG_ENH))
+                        ret = mwifiex_ret_802_11_hs_cfg(priv, resp);
+        } else {
+                /* handle response */
+                ret = mwifiex_process_sta_cmdresp(priv, cmdresp_no, resp);
+        }
+        /* Check init command response */
+        if (adapter->hw_status == MWIFIEX_HW_STATUS_INITIALIZING) {
+                if (ret == -1) {
+                        dev_err(adapter->dev, "%s: cmd %#x failed during "
+                                "initialization\n", __func__, cmdresp_no);
+                        mwifiex_init_fw_complete(adapter);
+                        return -1;
+                } else if (adapter->last_init_cmd == cmdresp_no)
+                        adapter->hw_status = MWIFIEX_HW_STATUS_INIT_DONE;
+        }
+        if (adapter->curr_cmd) {
+                if (adapter->curr_cmd->wait_q_enabled && (!ret))
+                        adapter->cmd_wait_q.status = 0;
+                else if (adapter->curr_cmd->wait_q_enabled && (ret == -1))
+                        adapter->cmd_wait_q.status = -1;
+                /* Clean up and put current command back to cmd_free_q */
+                mwifiex_insert_cmd_to_free_q(adapter, adapter->curr_cmd);
+                spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+                adapter->curr_cmd = NULL;
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+        }
+        return ret;
+}
+/*
+ * This function handles the timeout of command sending.
+ *
+ * It will re-send the same command again.
+ */
+void
+mwifiex_cmd_timeout_func(unsigned long function_context)
+{
+        struct mwifiex_adapter *adapter =
+                (struct mwifiex_adapter *) function_context;
+        struct cmd_ctrl_node *cmd_node;
+        struct timeval tstamp;
+        adapter->num_cmd_timeout++;
+        adapter->dbg.num_cmd_timeout++;
+        if (!adapter->curr_cmd) {
+                dev_dbg(adapter->dev, "cmd: empty curr_cmd\n");
+                return;
+        }
+        cmd_node = adapter->curr_cmd;
+        if (cmd_node->wait_q_enabled)
+                adapter->cmd_wait_q.status = -ETIMEDOUT;
+        if (cmd_node) {
+                adapter->dbg.timeout_cmd_id =
+                        adapter->dbg.last_cmd_id[adapter->dbg.last_cmd_index];
+                adapter->dbg.timeout_cmd_act =
+                        adapter->dbg.last_cmd_act[adapter->dbg.last_cmd_index];
+                do_gettimeofday(&tstamp);
+                dev_err(adapter->dev, "%s: Timeout cmd id (%lu.%lu) = %#x,"
+                        " act = %#x\n", __func__,
+                       tstamp.tv_sec, tstamp.tv_usec,
+                       adapter->dbg.timeout_cmd_id,
+                       adapter->dbg.timeout_cmd_act);
+                dev_err(adapter->dev, "num_data_h2c_failure = %d\n",
+                       adapter->dbg.num_tx_host_to_card_failure);
+                dev_err(adapter->dev, "num_cmd_h2c_failure = %d\n",
+                       adapter->dbg.num_cmd_host_to_card_failure);
+                dev_err(adapter->dev, "num_cmd_timeout = %d\n",
+                       adapter->dbg.num_cmd_timeout);
+                dev_err(adapter->dev, "num_tx_timeout = %d\n",
+                       adapter->dbg.num_tx_timeout);
+                dev_err(adapter->dev, "last_cmd_index = %d\n",
+                       adapter->dbg.last_cmd_index);
+                print_hex_dump_bytes("last_cmd_id: ", DUMP_PREFIX_OFFSET,
+                                adapter->dbg.last_cmd_id, DBG_CMD_NUM);
+                print_hex_dump_bytes("last_cmd_act: ", DUMP_PREFIX_OFFSET,
+                                adapter->dbg.last_cmd_act, DBG_CMD_NUM);
+                dev_err(adapter->dev, "last_cmd_resp_index = %d\n",
+                       adapter->dbg.last_cmd_resp_index);
+                print_hex_dump_bytes("last_cmd_resp_id: ", DUMP_PREFIX_OFFSET,
+                                adapter->dbg.last_cmd_resp_id, DBG_CMD_NUM);
+                dev_err(adapter->dev, "last_event_index = %d\n",
+                       adapter->dbg.last_event_index);
+                print_hex_dump_bytes("last_event: ", DUMP_PREFIX_OFFSET,
+                                adapter->dbg.last_event, DBG_CMD_NUM);
+                dev_err(adapter->dev, "data_sent=%d cmd_sent=%d\n",
+                       adapter->data_sent, adapter->cmd_sent);
+                dev_err(adapter->dev, "ps_mode=%d ps_state=%d\n",
+                                adapter->ps_mode, adapter->ps_state);
+        }
+        if (adapter->hw_status == MWIFIEX_HW_STATUS_INITIALIZING)
+                mwifiex_init_fw_complete(adapter);
+}
+/*
+ * This function cancels all the pending commands.
+ *
+ * The current command, all commands in command pending queue and all scan
+ * commands in scan pending queue are cancelled. All the completion callbacks
+ * are called with failure status to ensure cleanup.
+ */
+void
+mwifiex_cancel_all_pending_cmd(struct mwifiex_adapter *adapter)
+{
+        struct cmd_ctrl_node *cmd_node = NULL, *tmp_node;
+        unsigned long flags;
+        /* Cancel current cmd */
+        if ((adapter->curr_cmd) && (adapter->curr_cmd->wait_q_enabled)) {
+                spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+                adapter->curr_cmd->wait_q_enabled = false;
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+                adapter->cmd_wait_q.status = -1;
+                mwifiex_complete_cmd(adapter);
+        }
+        /* Cancel all pending command */
+        spin_lock_irqsave(&adapter->cmd_pending_q_lock, flags);
+        list_for_each_entry_safe(cmd_node, tmp_node,
+                                 &adapter->cmd_pending_q, list) {
+                list_del(&cmd_node->list);
+                spin_unlock_irqrestore(&adapter->cmd_pending_q_lock, flags);
+                if (cmd_node->wait_q_enabled) {
+                        adapter->cmd_wait_q.status = -1;
+                        mwifiex_complete_cmd(adapter);
+                        cmd_node->wait_q_enabled = false;
+                }
+                mwifiex_insert_cmd_to_free_q(adapter, cmd_node);
+                spin_lock_irqsave(&adapter->cmd_pending_q_lock, flags);
+        }
+        spin_unlock_irqrestore(&adapter->cmd_pending_q_lock, flags);
+        /* Cancel all pending scan command */
+        spin_lock_irqsave(&adapter->scan_pending_q_lock, flags);
+        list_for_each_entry_safe(cmd_node, tmp_node,
+                                 &adapter->scan_pending_q, list) {
+                list_del(&cmd_node->list);
+                spin_unlock_irqrestore(&adapter->scan_pending_q_lock, flags);
+                cmd_node->wait_q_enabled = false;
+                mwifiex_insert_cmd_to_free_q(adapter, cmd_node);
+                spin_lock_irqsave(&adapter->scan_pending_q_lock, flags);
+        }
+        spin_unlock_irqrestore(&adapter->scan_pending_q_lock, flags);
+        spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+        adapter->scan_processing = false;
+        spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+}
+/*
+ * This function cancels all pending commands that matches with
+ * the given IOCTL request.
+ *
+ * Both the current command buffer and the pending command queue are
+ * searched for matching IOCTL request. The completion callback of
+ * the matched command is called with failure status to ensure cleanup.
+ * In case of scan commands, all pending commands in scan pending queue
+ * are cancelled.
+ */
+void
+mwifiex_cancel_pending_ioctl(struct mwifiex_adapter *adapter)
+{
+        struct cmd_ctrl_node *cmd_node = NULL, *tmp_node = NULL;
+        unsigned long cmd_flags;
+        unsigned long cmd_pending_q_flags;
+        unsigned long scan_pending_q_flags;
+        uint16_t cancel_scan_cmd = false;
+        if ((adapter->curr_cmd) &&
+             (adapter->curr_cmd->wait_q_enabled)) {
+                spin_lock_irqsave(&adapter->mwifiex_cmd_lock, cmd_flags);
+                cmd_node = adapter->curr_cmd;
+                cmd_node->wait_q_enabled = false;
+                cmd_node->cmd_flag |= CMD_F_CANCELED;
+                spin_lock_irqsave(&adapter->cmd_pending_q_lock,
+                                  cmd_pending_q_flags);
+                list_del(&cmd_node->list);
+                spin_unlock_irqrestore(&adapter->cmd_pending_q_lock,
+                                       cmd_pending_q_flags);
+                mwifiex_insert_cmd_to_free_q(adapter, cmd_node);
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, cmd_flags);
+        }
+        /* Cancel all pending scan command */
+        spin_lock_irqsave(&adapter->scan_pending_q_lock,
+                          scan_pending_q_flags);
+        list_for_each_entry_safe(cmd_node, tmp_node,
+                                 &adapter->scan_pending_q, list) {
+                list_del(&cmd_node->list);
+                spin_unlock_irqrestore(&adapter->scan_pending_q_lock,
+                                       scan_pending_q_flags);
+                cmd_node->wait_q_enabled = false;
+                mwifiex_insert_cmd_to_free_q(adapter, cmd_node);
+                spin_lock_irqsave(&adapter->scan_pending_q_lock,
+                                  scan_pending_q_flags);
+                cancel_scan_cmd = true;
+        }
+        spin_unlock_irqrestore(&adapter->scan_pending_q_lock,
+                               scan_pending_q_flags);
+        if (cancel_scan_cmd) {
+                spin_lock_irqsave(&adapter->mwifiex_cmd_lock, cmd_flags);
+                adapter->scan_processing = false;
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, cmd_flags);
+        }
+        adapter->cmd_wait_q.status = -1;
+        mwifiex_complete_cmd(adapter);
+}
+/*
+ * This function sends the sleep confirm command to firmware, if
+ * possible.
+ *
+ * The sleep confirm command cannot be issued if command response,
+ * data response or event response is awaiting handling, or if we
+ * are in the middle of sending a command, or expecting a command
+ * response.
+ */
+void
+mwifiex_check_ps_cond(struct mwifiex_adapter *adapter)
+{
+        if (!adapter->cmd_sent &&
+            !adapter->curr_cmd && !IS_CARD_RX_RCVD(adapter))
+                mwifiex_dnld_sleep_confirm_cmd(adapter);
+        else
+                dev_dbg(adapter->dev,
+                        "cmd: Delay Sleep Confirm (%s%s%s)\n",
+                       (adapter->cmd_sent) ? "D" : "",
+                       (adapter->curr_cmd) ? "C" : "",
+                       (IS_CARD_RX_RCVD(adapter)) ? "R" : "");
+}
+/*
+ * This function sends a Host Sleep activated event to applications.
+ *
+ * This event is generated by the driver, with a blank event body.
+ */
+void
+mwifiex_hs_activated_event(struct mwifiex_private *priv, u8 activated)
+{
+        if (activated) {
+                if (priv->adapter->is_hs_configured) {
+                        priv->adapter->hs_activated = true;
+                        dev_dbg(priv->adapter->dev, "event: hs_activated\n");
+                        priv->adapter->hs_activate_wait_q_woken = true;
+                        wake_up_interruptible(
+                                &priv->adapter->hs_activate_wait_q);
+                } else {
+                        dev_dbg(priv->adapter->dev, "event: HS not configured\n");
+                }
+        } else {
+                dev_dbg(priv->adapter->dev, "event: hs_deactivated\n");
+                priv->adapter->hs_activated = false;
+        }
+}
+/*
+ * This function handles the command response of a Host Sleep configuration
+ * command.
+ *
+ * Handling includes changing the header fields into CPU format
+ * and setting the current host sleep activation status in driver.
+ *
+ * In case host sleep status change, the function generates an event to
+ * notify the applications.
+ */
+int mwifiex_ret_802_11_hs_cfg(struct mwifiex_private *priv,
+                              struct host_cmd_ds_command *resp)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct host_cmd_ds_802_11_hs_cfg_enh *phs_cfg =
+                &resp->params.opt_hs_cfg;
+        uint32_t conditions = le32_to_cpu(phs_cfg->params.hs_config.conditions);
+        if (phs_cfg->action == cpu_to_le16(HS_ACTIVATE)) {
+                mwifiex_hs_activated_event(priv, true);
+                return 0;
+        } else {
+                dev_dbg(adapter->dev, "cmd: CMD_RESP: HS_CFG cmd reply"
+                        " result=%#x, conditions=0x%x gpio=0x%x gap=0x%x\n",
+                        resp->result, conditions,
+                       phs_cfg->params.hs_config.gpio,
+                       phs_cfg->params.hs_config.gap);
+        }
+        if (conditions != HOST_SLEEP_CFG_CANCEL) {
+                adapter->is_hs_configured = true;
+        } else {
+                adapter->is_hs_configured = false;
+                if (adapter->hs_activated)
+                        mwifiex_hs_activated_event(priv, false);
+        }
+        return 0;
+}
+/*
+ * This function wakes up the adapter and generates a Host Sleep
+ * cancel event on receiving the power up interrupt.
+ */
+void
+mwifiex_process_hs_config(struct mwifiex_adapter *adapter)
+{
+        dev_dbg(adapter->dev, "info: %s: auto cancelling host sleep"
+                " since there is interrupt from the firmware\n", __func__);
+        adapter->if_ops.wakeup(adapter);
+        adapter->hs_activated = false;
+        adapter->is_hs_configured = false;
+        mwifiex_hs_activated_event(mwifiex_get_priv(adapter,
+                                   MWIFIEX_BSS_ROLE_ANY), false);
+}
+/*
+ * This function handles the command response of a sleep confirm command.
+ *
+ * The function sets the card state to SLEEP if the response indicates success.
+ */
+void
+mwifiex_process_sleep_confirm_resp(struct mwifiex_adapter *adapter,
+                                   u8 *pbuf, u32 upld_len)
+{
+        struct host_cmd_ds_command *cmd = (struct host_cmd_ds_command *) pbuf;
+        struct mwifiex_private *priv =
+                mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+        uint16_t result = le16_to_cpu(cmd->result);
+        uint16_t command = le16_to_cpu(cmd->command);
+        uint16_t seq_num = le16_to_cpu(cmd->seq_num);
+        if (!upld_len) {
+                dev_err(adapter->dev, "%s: cmd size is 0\n", __func__);
+                return;
+        }
+        /* Get BSS number and corresponding priv */
+        priv = mwifiex_get_priv_by_id(adapter, HostCmd_GET_BSS_NO(seq_num),
+                                      HostCmd_GET_BSS_TYPE(seq_num));
+        if (!priv)
+                priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+        /* Update sequence number */
+        seq_num = HostCmd_GET_SEQ_NO(seq_num);
+        /* Clear RET_BIT from HostCmd */
+        command &= HostCmd_CMD_ID_MASK;
+        if (command != HostCmd_CMD_802_11_PS_MODE_ENH) {
+                dev_err(adapter->dev, "%s: received unexpected response for"
+                        " cmd %x, result = %x\n", __func__, command, result);
+                return;
+        }
+        if (result) {
+                dev_err(adapter->dev, "%s: sleep confirm cmd failed\n",
+                                                __func__);
+                adapter->pm_wakeup_card_req = false;
+                adapter->ps_state = PS_STATE_AWAKE;
+                return;
+        }
+        adapter->pm_wakeup_card_req = true;
+        if (adapter->is_hs_configured)
+                mwifiex_hs_activated_event(mwifiex_get_priv(adapter,
+                                           MWIFIEX_BSS_ROLE_ANY), true);
+        adapter->ps_state = PS_STATE_SLEEP;
+        cmd->command = cpu_to_le16(command);
+        cmd->seq_num = cpu_to_le16(seq_num);
+}
+EXPORT_SYMBOL_GPL(mwifiex_process_sleep_confirm_resp);
+/*
+ * This function prepares an enhanced power mode command.
+ *
+ * This function can be used to disable power save or to configure
+ * power save with auto PS or STA PS or auto deep sleep.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting Power Save bitmap, PS parameters TLV, PS mode TLV,
+ *        auto deep sleep TLV (as required)
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_enh_power_mode(struct mwifiex_private *priv,
+                               struct host_cmd_ds_command *cmd,
+                               u16 cmd_action, uint16_t ps_bitmap,
+                               void *data_buf)
+{
+        struct host_cmd_ds_802_11_ps_mode_enh *psmode_enh =
+                &cmd->params.psmode_enh;
+        u8 *tlv;
+        u16 cmd_size = 0;
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_PS_MODE_ENH);
+        if (cmd_action == DIS_AUTO_PS) {
+                psmode_enh->action = cpu_to_le16(DIS_AUTO_PS);
+                psmode_enh->params.ps_bitmap = cpu_to_le16(ps_bitmap);
+                cmd->size = cpu_to_le16(S_DS_GEN + sizeof(psmode_enh->action) +
+                                sizeof(psmode_enh->params.ps_bitmap));
+        } else if (cmd_action == GET_PS) {
+                psmode_enh->action = cpu_to_le16(GET_PS);
+                psmode_enh->params.ps_bitmap = cpu_to_le16(ps_bitmap);
+                cmd->size = cpu_to_le16(S_DS_GEN + sizeof(psmode_enh->action) +
+                                sizeof(psmode_enh->params.ps_bitmap));
+        } else if (cmd_action == EN_AUTO_PS) {
+                psmode_enh->action = cpu_to_le16(EN_AUTO_PS);
+                psmode_enh->params.ps_bitmap = cpu_to_le16(ps_bitmap);
+                cmd_size = S_DS_GEN + sizeof(psmode_enh->action) +
+                                sizeof(psmode_enh->params.ps_bitmap);
+                tlv = (u8 *) cmd + cmd_size;
+                if (ps_bitmap & BITMAP_STA_PS) {
+                        struct mwifiex_adapter *adapter = priv->adapter;
+                        struct mwifiex_ie_types_ps_param *ps_tlv =
+                                (struct mwifiex_ie_types_ps_param *) tlv;
+                        struct mwifiex_ps_param *ps_mode = &ps_tlv->param;
+                        ps_tlv->header.type = cpu_to_le16(TLV_TYPE_PS_PARAM);
+                        ps_tlv->header.len = cpu_to_le16(sizeof(*ps_tlv) -
+                                        sizeof(struct mwifiex_ie_types_header));
+                        cmd_size += sizeof(*ps_tlv);
+                        tlv += sizeof(*ps_tlv);
+                        dev_dbg(adapter->dev, "cmd: PS Command: Enter PS\n");
+                        ps_mode->null_pkt_interval =
+                                cpu_to_le16(adapter->null_pkt_interval);
+                        ps_mode->multiple_dtims =
+                                cpu_to_le16(adapter->multiple_dtim);
+                        ps_mode->bcn_miss_timeout =
+                                cpu_to_le16(adapter->bcn_miss_time_out);
+                        ps_mode->local_listen_interval =
+                                cpu_to_le16(adapter->local_listen_interval);
+                        ps_mode->adhoc_wake_period =
+                                cpu_to_le16(adapter->adhoc_awake_period);
+                        ps_mode->delay_to_ps =
+                                cpu_to_le16(adapter->delay_to_ps);
+                        ps_mode->mode =
+                                cpu_to_le16(adapter->enhanced_ps_mode);
+                }
+                if (ps_bitmap & BITMAP_AUTO_DS) {
+                        struct mwifiex_ie_types_auto_ds_param *auto_ds_tlv =
+                                (struct mwifiex_ie_types_auto_ds_param *) tlv;
+                        u16 idletime = 0;
+                        auto_ds_tlv->header.type =
+                                cpu_to_le16(TLV_TYPE_AUTO_DS_PARAM);
+                        auto_ds_tlv->header.len =
+                                cpu_to_le16(sizeof(*auto_ds_tlv) -
+                                        sizeof(struct mwifiex_ie_types_header));
+                        cmd_size += sizeof(*auto_ds_tlv);
+                        tlv += sizeof(*auto_ds_tlv);
+                        if (data_buf)
+                                idletime = ((struct mwifiex_ds_auto_ds *)
+                                             data_buf)->idle_time;
+                        dev_dbg(priv->adapter->dev,
+                                        "cmd: PS Command: Enter Auto Deep Sleep\n");
+                        auto_ds_tlv->deep_sleep_timeout = cpu_to_le16(idletime);
+                }
+                cmd->size = cpu_to_le16(cmd_size);
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of an enhanced power mode
+ * command.
+ *
+ * Handling includes changing the header fields into CPU format
+ * and setting the current enhanced power mode in driver.
+ */
+int mwifiex_ret_enh_power_mode(struct mwifiex_private *priv,
+                               struct host_cmd_ds_command *resp,
+                               void *data_buf)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct host_cmd_ds_802_11_ps_mode_enh *ps_mode =
+                &resp->params.psmode_enh;
+        uint16_t action = le16_to_cpu(ps_mode->action);
+        uint16_t ps_bitmap = le16_to_cpu(ps_mode->params.ps_bitmap);
+        uint16_t auto_ps_bitmap =
+                le16_to_cpu(ps_mode->params.ps_bitmap);
+        dev_dbg(adapter->dev, "info: %s: PS_MODE cmd reply result=%#x action=%#X\n",
+                                        __func__, resp->result, action);
+        if (action == EN_AUTO_PS) {
+                if (auto_ps_bitmap & BITMAP_AUTO_DS) {
+                        dev_dbg(adapter->dev, "cmd: Enabled auto deep sleep\n");
+                        priv->adapter->is_deep_sleep = true;
+                }
+                if (auto_ps_bitmap & BITMAP_STA_PS) {
+                        dev_dbg(adapter->dev, "cmd: Enabled STA power save\n");
+                        if (adapter->sleep_period.period)
+                                dev_dbg(adapter->dev, "cmd: set to uapsd/pps mode\n");
+                }
+        } else if (action == DIS_AUTO_PS) {
+                if (ps_bitmap & BITMAP_AUTO_DS) {
+                        priv->adapter->is_deep_sleep = false;
+                        dev_dbg(adapter->dev, "cmd: Disabled auto deep sleep\n");
+                }
+                if (ps_bitmap & BITMAP_STA_PS) {
+                        dev_dbg(adapter->dev, "cmd: Disabled STA power save\n");
+                        if (adapter->sleep_period.period) {
+                                adapter->delay_null_pkt = false;
+                                adapter->tx_lock_flag = false;
+                                adapter->pps_uapsd_mode = false;
+                        }
+                }
+        } else if (action == GET_PS) {
+                if (ps_bitmap & BITMAP_STA_PS)
+                        adapter->ps_mode = MWIFIEX_802_11_POWER_MODE_PSP;
+                else
+                        adapter->ps_mode = MWIFIEX_802_11_POWER_MODE_CAM;
+                dev_dbg(adapter->dev, "cmd: ps_bitmap=%#x\n", ps_bitmap);
+                if (data_buf) {
+                        /* This section is for get power save mode */
+                        struct mwifiex_ds_pm_cfg *pm_cfg =
+                                        (struct mwifiex_ds_pm_cfg *)data_buf;
+                        if (ps_bitmap & BITMAP_STA_PS)
+                                pm_cfg->param.ps_mode = 1;
+                        else
+                                pm_cfg->param.ps_mode = 0;
+                }
+        }
+        return 0;
+}
+/*
+ * This function prepares command to get hardware specifications.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting permanent address parameter
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_get_hw_spec(struct mwifiex_private *priv,
+                            struct host_cmd_ds_command *cmd)
+{
+        struct host_cmd_ds_get_hw_spec *hw_spec = &cmd->params.hw_spec;
+        cmd->command = cpu_to_le16(HostCmd_CMD_GET_HW_SPEC);
+        cmd->size =
+                cpu_to_le16(sizeof(struct host_cmd_ds_get_hw_spec) + S_DS_GEN);
+        memcpy(hw_spec->permanent_addr, priv->curr_addr, ETH_ALEN);
+        return 0;
+}
+/*
+ * This function handles the command response of get hardware
+ * specifications.
+ *
+ * Handling includes changing the header fields into CPU format
+ * and saving/updating the following parameters in driver -
+ *      - Firmware capability information
+ *      - Firmware band settings
+ *      - Ad-hoc start band and channel
+ *      - Ad-hoc 11n activation status
+ *      - Firmware release number
+ *      - Number of antennas
+ *      - Hardware address
+ *      - Hardware interface version
+ *      - Firmware version
+ *      - Region code
+ *      - 11n capabilities
+ *      - MCS support fields
+ *      - MP end port
+ */
+int mwifiex_ret_get_hw_spec(struct mwifiex_private *priv,
+                            struct host_cmd_ds_command *resp)
+{
+        struct host_cmd_ds_get_hw_spec *hw_spec = &resp->params.hw_spec;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        int i;
+        adapter->fw_cap_info = le32_to_cpu(hw_spec->fw_cap_info);
+        if (IS_SUPPORT_MULTI_BANDS(adapter))
+                adapter->fw_bands = (u8) GET_FW_DEFAULT_BANDS(adapter);
+        else
+                adapter->fw_bands = BAND_B;
+        adapter->config_bands = adapter->fw_bands;
+        if (adapter->fw_bands & BAND_A) {
+                if (adapter->fw_bands & BAND_GN) {
+                        adapter->config_bands |= BAND_AN;
+                        adapter->fw_bands |= BAND_AN;
+                }
+                if (adapter->fw_bands & BAND_AN) {
+                        adapter->adhoc_start_band = BAND_A | BAND_AN;
+                        adapter->adhoc_11n_enabled = true;
+                } else {
+                        adapter->adhoc_start_band = BAND_A;
+                }
+                priv->adhoc_channel = DEFAULT_AD_HOC_CHANNEL_A;
+        } else if (adapter->fw_bands & BAND_GN) {
+                adapter->adhoc_start_band = BAND_G | BAND_B | BAND_GN;
+                priv->adhoc_channel = DEFAULT_AD_HOC_CHANNEL;
+                adapter->adhoc_11n_enabled = true;
+        } else if (adapter->fw_bands & BAND_G) {
+                adapter->adhoc_start_band = BAND_G | BAND_B;
+                priv->adhoc_channel = DEFAULT_AD_HOC_CHANNEL;
+        } else if (adapter->fw_bands & BAND_B) {
+                adapter->adhoc_start_band = BAND_B;
+                priv->adhoc_channel = DEFAULT_AD_HOC_CHANNEL;
+        }
+        adapter->fw_release_number = le32_to_cpu(hw_spec->fw_release_number);
+        adapter->number_of_antenna = le16_to_cpu(hw_spec->number_of_antenna);
+        dev_dbg(adapter->dev, "info: GET_HW_SPEC: fw_release_number- %#x\n",
+               adapter->fw_release_number);
+        dev_dbg(adapter->dev, "info: GET_HW_SPEC: permanent addr: %pM\n",
+                                        hw_spec->permanent_addr);
+        dev_dbg(adapter->dev, "info: GET_HW_SPEC: hw_if_version=%#x  version=%#x\n",
+                le16_to_cpu(hw_spec->hw_if_version),
+               le16_to_cpu(hw_spec->version));
+        if (priv->curr_addr[0] == 0xff)
+                memmove(priv->curr_addr, hw_spec->permanent_addr, ETH_ALEN);
+        adapter->region_code = le16_to_cpu(hw_spec->region_code);
+        for (i = 0; i < MWIFIEX_MAX_REGION_CODE; i++)
+                /* Use the region code to search for the index */
+                if (adapter->region_code == region_code_index[i])
+                        break;
+        /* If it's unidentified region code, use the default (USA) */
+        if (i >= MWIFIEX_MAX_REGION_CODE) {
+                adapter->region_code = 0x10;
+                dev_dbg(adapter->dev, "cmd: unknown region code, use default (USA)\n");
+        }
+        adapter->hw_dot_11n_dev_cap = le32_to_cpu(hw_spec->dot_11n_dev_cap);
+        adapter->hw_dev_mcs_support = hw_spec->dev_mcs_support;
+        if (adapter->if_ops.update_mp_end_port)
+                adapter->if_ops.update_mp_end_port(adapter,
+                                        le16_to_cpu(hw_spec->mp_end_port));
+        return 0;
+}
diff --git a/drivers/net/wireless/mwifiex/debugfs.c b/drivers/net/wireless/mwifiex/debugfs.c
new file mode 100644
index 000000000000..46d65e02c7ba
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/debugfs.c
@@ -0,0 +1,770 @@
+/*
+ * Marvell Wireless LAN device driver: debugfs
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include <linux/debugfs.h>
+#include "main.h"
+#include "11n.h"
+static struct dentry *mwifiex_dfs_dir;
+static char *bss_modes[] = {
+        "Unknown",
+        "Managed",
+        "Ad-hoc",
+        "Auto"
+};
+/* size/addr for mwifiex_debug_info */
+#define item_size(n)            (FIELD_SIZEOF(struct mwifiex_debug_info, n))
+#define item_addr(n)            (offsetof(struct mwifiex_debug_info, n))
+/* size/addr for struct mwifiex_adapter */
+#define adapter_item_size(n)    (FIELD_SIZEOF(struct mwifiex_adapter, n))
+#define adapter_item_addr(n)    (offsetof(struct mwifiex_adapter, n))
+struct mwifiex_debug_data {
+        char name[32];          /* variable/array name */
+        u32 size;               /* size of the variable/array */
+        size_t addr;            /* address of the variable/array */
+        int num;                /* number of variables in an array */
+};
+static struct mwifiex_debug_data items[] = {
+        {"int_counter", item_size(int_counter),
+         item_addr(int_counter), 1},
+        {"wmm_ac_vo", item_size(packets_out[WMM_AC_VO]),
+         item_addr(packets_out[WMM_AC_VO]), 1},
+        {"wmm_ac_vi", item_size(packets_out[WMM_AC_VI]),
+         item_addr(packets_out[WMM_AC_VI]), 1},
+        {"wmm_ac_be", item_size(packets_out[WMM_AC_BE]),
+         item_addr(packets_out[WMM_AC_BE]), 1},
+        {"wmm_ac_bk", item_size(packets_out[WMM_AC_BK]),
+         item_addr(packets_out[WMM_AC_BK]), 1},
+        {"max_tx_buf_size", item_size(max_tx_buf_size),
+         item_addr(max_tx_buf_size), 1},
+        {"tx_buf_size", item_size(tx_buf_size),
+         item_addr(tx_buf_size), 1},
+        {"curr_tx_buf_size", item_size(curr_tx_buf_size),
+         item_addr(curr_tx_buf_size), 1},
+        {"ps_mode", item_size(ps_mode),
+         item_addr(ps_mode), 1},
+        {"ps_state", item_size(ps_state),
+         item_addr(ps_state), 1},
+        {"is_deep_sleep", item_size(is_deep_sleep),
+         item_addr(is_deep_sleep), 1},
+        {"wakeup_dev_req", item_size(pm_wakeup_card_req),
+         item_addr(pm_wakeup_card_req), 1},
+        {"wakeup_tries", item_size(pm_wakeup_fw_try),
+         item_addr(pm_wakeup_fw_try), 1},
+        {"hs_configured", item_size(is_hs_configured),
+         item_addr(is_hs_configured), 1},
+        {"hs_activated", item_size(hs_activated),
+         item_addr(hs_activated), 1},
+        {"num_tx_timeout", item_size(num_tx_timeout),
+         item_addr(num_tx_timeout), 1},
+        {"num_cmd_timeout", item_size(num_cmd_timeout),
+         item_addr(num_cmd_timeout), 1},
+        {"timeout_cmd_id", item_size(timeout_cmd_id),
+         item_addr(timeout_cmd_id), 1},
+        {"timeout_cmd_act", item_size(timeout_cmd_act),
+         item_addr(timeout_cmd_act), 1},
+        {"last_cmd_id", item_size(last_cmd_id),
+         item_addr(last_cmd_id), DBG_CMD_NUM},
+        {"last_cmd_act", item_size(last_cmd_act),
+         item_addr(last_cmd_act), DBG_CMD_NUM},
+        {"last_cmd_index", item_size(last_cmd_index),
+         item_addr(last_cmd_index), 1},
+        {"last_cmd_resp_id", item_size(last_cmd_resp_id),
+         item_addr(last_cmd_resp_id), DBG_CMD_NUM},
+        {"last_cmd_resp_index", item_size(last_cmd_resp_index),
+         item_addr(last_cmd_resp_index), 1},
+        {"last_event", item_size(last_event),
+         item_addr(last_event), DBG_CMD_NUM},
+        {"last_event_index", item_size(last_event_index),
+         item_addr(last_event_index), 1},
+        {"num_cmd_h2c_fail", item_size(num_cmd_host_to_card_failure),
+         item_addr(num_cmd_host_to_card_failure), 1},
+        {"num_cmd_sleep_cfm_fail",
+         item_size(num_cmd_sleep_cfm_host_to_card_failure),
+         item_addr(num_cmd_sleep_cfm_host_to_card_failure), 1},
+        {"num_tx_h2c_fail", item_size(num_tx_host_to_card_failure),
+         item_addr(num_tx_host_to_card_failure), 1},
+        {"num_evt_deauth", item_size(num_event_deauth),
+         item_addr(num_event_deauth), 1},
+        {"num_evt_disassoc", item_size(num_event_disassoc),
+         item_addr(num_event_disassoc), 1},
+        {"num_evt_link_lost", item_size(num_event_link_lost),
+         item_addr(num_event_link_lost), 1},
+        {"num_cmd_deauth", item_size(num_cmd_deauth),
+         item_addr(num_cmd_deauth), 1},
+        {"num_cmd_assoc_ok", item_size(num_cmd_assoc_success),
+         item_addr(num_cmd_assoc_success), 1},
+        {"num_cmd_assoc_fail", item_size(num_cmd_assoc_failure),
+         item_addr(num_cmd_assoc_failure), 1},
+        {"cmd_sent", item_size(cmd_sent),
+         item_addr(cmd_sent), 1},
+        {"data_sent", item_size(data_sent),
+         item_addr(data_sent), 1},
+        {"cmd_resp_received", item_size(cmd_resp_received),
+         item_addr(cmd_resp_received), 1},
+        {"event_received", item_size(event_received),
+         item_addr(event_received), 1},
+        /* variables defined in struct mwifiex_adapter */
+        {"cmd_pending", adapter_item_size(cmd_pending),
+         adapter_item_addr(cmd_pending), 1},
+        {"tx_pending", adapter_item_size(tx_pending),
+         adapter_item_addr(tx_pending), 1},
+        {"rx_pending", adapter_item_size(rx_pending),
+         adapter_item_addr(rx_pending), 1},
+};
+static int num_of_items = ARRAY_SIZE(items);
+/*
+ * Generic proc file open handler.
+ *
+ * This function is called every time a file is accessed for read or write.
+ */
+static int
+mwifiex_open_generic(struct inode *inode, struct file *file)
+{
+        file->private_data = inode->i_private;
+        return 0;
+}
+/*
+ * Proc info file read handler.
+ *
+ * This function is called when the 'info' file is opened for reading.
+ * It prints the following driver related information -
+ *      - Driver name
+ *      - Driver version
+ *      - Driver extended version
+ *      - Interface name
+ *      - BSS mode
+ *      - Media state (connected or disconnected)
+ *      - MAC address
+ *      - Total number of Tx bytes
+ *      - Total number of Rx bytes
+ *      - Total number of Tx packets
+ *      - Total number of Rx packets
+ *      - Total number of dropped Tx packets
+ *      - Total number of dropped Rx packets
+ *      - Total number of corrupted Tx packets
+ *      - Total number of corrupted Rx packets
+ *      - Carrier status (on or off)
+ *      - Tx queue status (started or stopped)
+ *
+ * For STA mode drivers, it also prints the following extra -
+ *      - ESSID
+ *      - BSSID
+ *      - Channel
+ *      - Region code
+ *      - Multicast count
+ *      - Multicast addresses
+ */
+static ssize_t
+mwifiex_info_read(struct file *file, char __user *ubuf,
+                  size_t count, loff_t *ppos)
+{
+        struct mwifiex_private *priv =
+                (struct mwifiex_private *) file->private_data;
+        struct net_device *netdev = priv->netdev;
+        struct netdev_hw_addr *ha;
+        unsigned long page = get_zeroed_page(GFP_KERNEL);
+        char *p = (char *) page, fmt[64];
+        struct mwifiex_bss_info info;
+        ssize_t ret;
+        int i = 0;
+        if (!p)
+                return -ENOMEM;
+        memset(&info, 0, sizeof(info));
+        ret = mwifiex_get_bss_info(priv, &info);
+        if (ret)
+                goto free_and_exit;
+        mwifiex_drv_get_driver_version(priv->adapter, fmt, sizeof(fmt) - 1);
+        if (!priv->version_str[0])
+                mwifiex_get_ver_ext(priv);
+        p += sprintf(p, "driver_name = " "\"mwifiex\"\n");
+        p += sprintf(p, "driver_version = %s", fmt);
+        p += sprintf(p, "\nverext = %s", priv->version_str);
+        p += sprintf(p, "\ninterface_name=\"%s\"\n", netdev->name);
+        p += sprintf(p, "bss_mode=\"%s\"\n", bss_modes[info.bss_mode]);
+        p += sprintf(p, "media_state=\"%s\"\n",
+                     (!priv->media_connected ? "Disconnected" : "Connected"));
+        p += sprintf(p, "mac_address=\"%02x:%02x:%02x:%02x:%02x:%02x\"\n",
+                     netdev->dev_addr[0], netdev->dev_addr[1],
+                     netdev->dev_addr[2], netdev->dev_addr[3],
+                     netdev->dev_addr[4], netdev->dev_addr[5]);
+        if (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA) {
+                p += sprintf(p, "multicast_count=\"%d\"\n",
+                             netdev_mc_count(netdev));
+                p += sprintf(p, "essid=\"%s\"\n", info.ssid.ssid);
+                p += sprintf(p, "bssid=\"%02x:%02x:%02x:%02x:%02x:%02x\"\n",
+                             info.bssid[0], info.bssid[1],
+                             info.bssid[2], info.bssid[3],
+                             info.bssid[4], info.bssid[5]);
+                p += sprintf(p, "channel=\"%d\"\n", (int) info.bss_chan);
+                p += sprintf(p, "region_code = \"%02x\"\n", info.region_code);
+                netdev_for_each_mc_addr(ha, netdev)
+                        p += sprintf(p, "multicast_address[%d]="
+                                     "\"%02x:%02x:%02x:%02x:%02x:%02x\"\n", i++,
+                                     ha->addr[0], ha->addr[1],
+                                     ha->addr[2], ha->addr[3],
+                                     ha->addr[4], ha->addr[5]);
+        }
+        p += sprintf(p, "num_tx_bytes = %lu\n", priv->stats.tx_bytes);
+        p += sprintf(p, "num_rx_bytes = %lu\n", priv->stats.rx_bytes);
+        p += sprintf(p, "num_tx_pkts = %lu\n", priv->stats.tx_packets);
+        p += sprintf(p, "num_rx_pkts = %lu\n", priv->stats.rx_packets);
+        p += sprintf(p, "num_tx_pkts_dropped = %lu\n", priv->stats.tx_dropped);
+        p += sprintf(p, "num_rx_pkts_dropped = %lu\n", priv->stats.rx_dropped);
+        p += sprintf(p, "num_tx_pkts_err = %lu\n", priv->stats.tx_errors);
+        p += sprintf(p, "num_rx_pkts_err = %lu\n", priv->stats.rx_errors);
+        p += sprintf(p, "carrier %s\n", ((netif_carrier_ok(priv->netdev))
+                                         ? "on" : "off"));
+        p += sprintf(p, "tx queue %s\n", ((netif_queue_stopped(priv->netdev))
+                                          ? "stopped" : "started"));
+        ret = simple_read_from_buffer(ubuf, count, ppos, (char *) page,
+                                      (unsigned long) p - page);
+free_and_exit:
+        free_page(page);
+        return ret;
+}
+/*
+ * Proc getlog file read handler.
+ *
+ * This function is called when the 'getlog' file is opened for reading
+ * It prints the following log information -
+ *      - Number of multicast Tx frames
+ *      - Number of failed packets
+ *      - Number of Tx retries
+ *      - Number of multicast Tx retries
+ *      - Number of duplicate frames
+ *      - Number of RTS successes
+ *      - Number of RTS failures
+ *      - Number of ACK failures
+ *      - Number of fragmented Rx frames
+ *      - Number of multicast Rx frames
+ *      - Number of FCS errors
+ *      - Number of Tx frames
+ *      - WEP ICV error counts
+ */
+static ssize_t
+mwifiex_getlog_read(struct file *file, char __user *ubuf,
+                    size_t count, loff_t *ppos)
+{
+        struct mwifiex_private *priv =
+                (struct mwifiex_private *) file->private_data;
+        unsigned long page = get_zeroed_page(GFP_KERNEL);
+        char *p = (char *) page;
+        ssize_t ret;
+        struct mwifiex_ds_get_stats stats;
+        if (!p)
+                return -ENOMEM;
+        memset(&stats, 0, sizeof(stats));
+        ret = mwifiex_get_stats_info(priv, &stats);
+        if (ret)
+                goto free_and_exit;
+        p += sprintf(p, "\n"
+                     "mcasttxframe     %u\n"
+                     "failed           %u\n"
+                     "retry            %u\n"
+                     "multiretry       %u\n"
+                     "framedup         %u\n"
+                     "rtssuccess       %u\n"
+                     "rtsfailure       %u\n"
+                     "ackfailure       %u\n"
+                     "rxfrag           %u\n"
+                     "mcastrxframe     %u\n"
+                     "fcserror         %u\n"
+                     "txframe          %u\n"
+                     "wepicverrcnt-1   %u\n"
+                     "wepicverrcnt-2   %u\n"
+                     "wepicverrcnt-3   %u\n"
+                     "wepicverrcnt-4   %u\n",
+                     stats.mcast_tx_frame,
+                     stats.failed,
+                     stats.retry,
+                     stats.multi_retry,
+                     stats.frame_dup,
+                     stats.rts_success,
+                     stats.rts_failure,
+                     stats.ack_failure,
+                     stats.rx_frag,
+                     stats.mcast_rx_frame,
+                     stats.fcs_error,
+                     stats.tx_frame,
+                     stats.wep_icv_error[0],
+                     stats.wep_icv_error[1],
+                     stats.wep_icv_error[2],
+                     stats.wep_icv_error[3]);
+        ret = simple_read_from_buffer(ubuf, count, ppos, (char *) page,
+                                      (unsigned long) p - page);
+free_and_exit:
+        free_page(page);
+        return ret;
+}
+static struct mwifiex_debug_info info;
+/*
+ * Proc debug file read handler.
+ *
+ * This function is called when the 'debug' file is opened for reading
+ * It prints the following log information -
+ *      - Interrupt count
+ *      - WMM AC VO packets count
+ *      - WMM AC VI packets count
+ *      - WMM AC BE packets count
+ *      - WMM AC BK packets count
+ *      - Maximum Tx buffer size
+ *      - Tx buffer size
+ *      - Current Tx buffer size
+ *      - Power Save mode
+ *      - Power Save state
+ *      - Deep Sleep status
+ *      - Device wakeup required status
+ *      - Number of wakeup tries
+ *      - Host Sleep configured status
+ *      - Host Sleep activated status
+ *      - Number of Tx timeouts
+ *      - Number of command timeouts
+ *      - Last timed out command ID
+ *      - Last timed out command action
+ *      - Last command ID
+ *      - Last command action
+ *      - Last command index
+ *      - Last command response ID
+ *      - Last command response index
+ *      - Last event
+ *      - Last event index
+ *      - Number of host to card command failures
+ *      - Number of sleep confirm command failures
+ *      - Number of host to card data failure
+ *      - Number of deauthentication events
+ *      - Number of disassociation events
+ *      - Number of link lost events
+ *      - Number of deauthentication commands
+ *      - Number of association success commands
+ *      - Number of association failure commands
+ *      - Number of commands sent
+ *      - Number of data packets sent
+ *      - Number of command responses received
+ *      - Number of events received
+ *      - Tx BA stream table (TID, RA)
+ *      - Rx reorder table (TID, TA, Start window, Window size, Buffer)
+ */
+static ssize_t
+mwifiex_debug_read(struct file *file, char __user *ubuf,
+                   size_t count, loff_t *ppos)
+{
+        struct mwifiex_private *priv =
+                (struct mwifiex_private *) file->private_data;
+        struct mwifiex_debug_data *d = &items[0];
+        unsigned long page = get_zeroed_page(GFP_KERNEL);
+        char *p = (char *) page;
+        ssize_t ret;
+        size_t size, addr;
+        long val;
+        int i, j;
+        if (!p)
+                return -ENOMEM;
+        ret = mwifiex_get_debug_info(priv, &info);
+        if (ret)
+                goto free_and_exit;
+        for (i = 0; i < num_of_items; i++) {
+                p += sprintf(p, "%s=", d[i].name);
+                size = d[i].size / d[i].num;
+                if (i < (num_of_items - 3))
+                        addr = d[i].addr + (size_t) &info;
+                else /* The last 3 items are struct mwifiex_adapter variables */
+                        addr = d[i].addr + (size_t) priv->adapter;
+                for (j = 0; j < d[i].num; j++) {
+                        switch (size) {
+                        case 1:
+                                val = *((u8 *) addr);
+                                break;
+                        case 2:
+                                val = *((u16 *) addr);
+                                break;
+                        case 4:
+                                val = *((u32 *) addr);
+                                break;
+                        case 8:
+                                val = *((long long *) addr);
+                                break;
+                        default:
+                                val = -1;
+                                break;
+                        }
+                        p += sprintf(p, "%#lx ", val);
+                        addr += size;
+                }
+                p += sprintf(p, "\n");
+        }
+        if (info.tx_tbl_num) {
+                p += sprintf(p, "Tx BA stream table:\n");
+                for (i = 0; i < info.tx_tbl_num; i++)
+                        p += sprintf(p, "tid = %d, "
+                                     "ra = %02x:%02x:%02x:%02x:%02x:%02x\n",
+                                     info.tx_tbl[i].tid, info.tx_tbl[i].ra[0],
+                                     info.tx_tbl[i].ra[1], info.tx_tbl[i].ra[2],
+                                     info.tx_tbl[i].ra[3], info.tx_tbl[i].ra[4],
+                                     info.tx_tbl[i].ra[5]);
+        }
+        if (info.rx_tbl_num) {
+                p += sprintf(p, "Rx reorder table:\n");
+                for (i = 0; i < info.rx_tbl_num; i++) {
+                        p += sprintf(p, "tid = %d, "
+                                     "ta = %02x:%02x:%02x:%02x:%02x:%02x, "
+                                     "start_win = %d, "
+                                     "win_size = %d, buffer: ",
+                                     info.rx_tbl[i].tid,
+                                     info.rx_tbl[i].ta[0], info.rx_tbl[i].ta[1],
+                                     info.rx_tbl[i].ta[2], info.rx_tbl[i].ta[3],
+                                     info.rx_tbl[i].ta[4], info.rx_tbl[i].ta[5],
+                                     info.rx_tbl[i].start_win,
+                                     info.rx_tbl[i].win_size);
+                        for (j = 0; j < info.rx_tbl[i].win_size; j++)
+                                p += sprintf(p, "%c ",
+                                             info.rx_tbl[i].buffer[j] ?
+                                             '1' : '0');
+                        p += sprintf(p, "\n");
+                }
+        }
+        ret = simple_read_from_buffer(ubuf, count, ppos, (char *) page,
+                                      (unsigned long) p - page);
+free_and_exit:
+        free_page(page);
+        return ret;
+}
+static u32 saved_reg_type, saved_reg_offset, saved_reg_value;
+/*
+ * Proc regrdwr file write handler.
+ *
+ * This function is called when the 'regrdwr' file is opened for writing
+ *
+ * This function can be used to write to a register.
+ */
+static ssize_t
+mwifiex_regrdwr_write(struct file *file,
+                      const char __user *ubuf, size_t count, loff_t *ppos)
+{
+        unsigned long addr = get_zeroed_page(GFP_KERNEL);
+        char *buf = (char *) addr;
+        size_t buf_size = min(count, (size_t) (PAGE_SIZE - 1));
+        int ret;
+        u32 reg_type = 0, reg_offset = 0, reg_value = UINT_MAX;
+        if (!buf)
+                return -ENOMEM;
+        if (copy_from_user(buf, ubuf, buf_size)) {
+                ret = -EFAULT;
+                goto done;
+        }
+        sscanf(buf, "%u %x %x", &reg_type, &reg_offset, &reg_value);
+        if (reg_type == 0 || reg_offset == 0) {
+                ret = -EINVAL;
+                goto done;
+        } else {
+                saved_reg_type = reg_type;
+                saved_reg_offset = reg_offset;
+                saved_reg_value = reg_value;
+                ret = count;
+        }
+done:
+        free_page(addr);
+        return ret;
+}
+/*
+ * Proc regrdwr file read handler.
+ *
+ * This function is called when the 'regrdwr' file is opened for reading
+ *
+ * This function can be used to read from a register.
+ */
+static ssize_t
+mwifiex_regrdwr_read(struct file *file, char __user *ubuf,
+                     size_t count, loff_t *ppos)
+{
+        struct mwifiex_private *priv =
+                (struct mwifiex_private *) file->private_data;
+        unsigned long addr = get_zeroed_page(GFP_KERNEL);
+        char *buf = (char *) addr;
+        int pos = 0, ret = 0;
+        u32 reg_value;
+        if (!buf)
+                return -ENOMEM;
+        if (!saved_reg_type) {
+                /* No command has been given */
+                pos += snprintf(buf, PAGE_SIZE, "0");
+                goto done;
+        }
+        /* Set command has been given */
+        if (saved_reg_value != UINT_MAX) {
+                ret = mwifiex_reg_write(priv, saved_reg_type, saved_reg_offset,
+                                        saved_reg_value);
+                pos += snprintf(buf, PAGE_SIZE, "%u 0x%x 0x%x\n",
+                                saved_reg_type, saved_reg_offset,
+                                saved_reg_value);
+                ret = simple_read_from_buffer(ubuf, count, ppos, buf, pos);
+                goto done;
+        }
+        /* Get command has been given */
+        ret = mwifiex_reg_read(priv, saved_reg_type,
+                               saved_reg_offset, &reg_value);
+        if (ret) {
+                ret = -EINVAL;
+                goto done;
+        }
+        pos += snprintf(buf, PAGE_SIZE, "%u 0x%x 0x%x\n", saved_reg_type,
+                        saved_reg_offset, reg_value);
+        ret = simple_read_from_buffer(ubuf, count, ppos, buf, pos);
+done:
+        free_page(addr);
+        return ret;
+}
+static u32 saved_offset = -1, saved_bytes = -1;
+/*
+ * Proc rdeeprom file write handler.
+ *
+ * This function is called when the 'rdeeprom' file is opened for writing
+ *
+ * This function can be used to write to a RDEEPROM location.
+ */
+static ssize_t
+mwifiex_rdeeprom_write(struct file *file,
+                       const char __user *ubuf, size_t count, loff_t *ppos)
+{
+        unsigned long addr = get_zeroed_page(GFP_KERNEL);
+        char *buf = (char *) addr;
+        size_t buf_size = min(count, (size_t) (PAGE_SIZE - 1));
+        int ret = 0;
+        int offset = -1, bytes = -1;
+        if (!buf)
+                return -ENOMEM;
+        if (copy_from_user(buf, ubuf, buf_size)) {
+                ret = -EFAULT;
+                goto done;
+        }
+        sscanf(buf, "%d %d", &offset, &bytes);
+        if (offset == -1 || bytes == -1) {
+                ret = -EINVAL;
+                goto done;
+        } else {
+                saved_offset = offset;
+                saved_bytes = bytes;
+                ret = count;
+        }
+done:
+        free_page(addr);
+        return ret;
+}
+/*
+ * Proc rdeeprom read write handler.
+ *
+ * This function is called when the 'rdeeprom' file is opened for reading
+ *
+ * This function can be used to read from a RDEEPROM location.
+ */
+static ssize_t
+mwifiex_rdeeprom_read(struct file *file, char __user *ubuf,
+                      size_t count, loff_t *ppos)
+{
+        struct mwifiex_private *priv =
+                (struct mwifiex_private *) file->private_data;
+        unsigned long addr = get_zeroed_page(GFP_KERNEL);
+        char *buf = (char *) addr;
+        int pos = 0, ret = 0, i;
+        u8 value[MAX_EEPROM_DATA];
+        if (!buf)
+                return -ENOMEM;
+        if (saved_offset == -1) {
+                /* No command has been given */
+                pos += snprintf(buf, PAGE_SIZE, "0");
+                goto done;
+        }
+        /* Get command has been given */
+        ret = mwifiex_eeprom_read(priv, (u16) saved_offset,
+                                  (u16) saved_bytes, value);
+        if (ret) {
+                ret = -EINVAL;
+                goto done;
+        }
+        pos += snprintf(buf, PAGE_SIZE, "%d %d ", saved_offset, saved_bytes);
+        for (i = 0; i < saved_bytes; i++)
+                pos += snprintf(buf + strlen(buf), PAGE_SIZE, "%d ", value[i]);
+        ret = simple_read_from_buffer(ubuf, count, ppos, buf, pos);
+done:
+        free_page(addr);
+        return ret;
+}
+#define MWIFIEX_DFS_ADD_FILE(name) do {                                 \
+        if (!debugfs_create_file(#name, 0644, priv->dfs_dev_dir,        \
+                        priv, &mwifiex_dfs_##name##_fops))              \
+                return;                                                 \
+} while (0);
+#define MWIFIEX_DFS_FILE_OPS(name)                                      \
+static const struct file_operations mwifiex_dfs_##name##_fops = {       \
+        .read = mwifiex_##name##_read,                                  \
+        .write = mwifiex_##name##_write,                                \
+        .open = mwifiex_open_generic,                                   \
+};
+#define MWIFIEX_DFS_FILE_READ_OPS(name)                                 \
+static const struct file_operations mwifiex_dfs_##name##_fops = {       \
+        .read = mwifiex_##name##_read,                                  \
+        .open = mwifiex_open_generic,                                   \
+};
+#define MWIFIEX_DFS_FILE_WRITE_OPS(name)                                \
+static const struct file_operations mwifiex_dfs_##name##_fops = {       \
+        .write = mwifiex_##name##_write,                                \
+        .open = mwifiex_open_generic,                                   \
+};
+MWIFIEX_DFS_FILE_READ_OPS(info);
+MWIFIEX_DFS_FILE_READ_OPS(debug);
+MWIFIEX_DFS_FILE_READ_OPS(getlog);
+MWIFIEX_DFS_FILE_OPS(regrdwr);
+MWIFIEX_DFS_FILE_OPS(rdeeprom);
+/*
+ * This function creates the debug FS directory structure and the files.
+ */
+void
+mwifiex_dev_debugfs_init(struct mwifiex_private *priv)
+{
+        if (!mwifiex_dfs_dir || !priv)
+                return;
+        priv->dfs_dev_dir = debugfs_create_dir(priv->netdev->name,
+                                               mwifiex_dfs_dir);
+        if (!priv->dfs_dev_dir)
+                return;
+        MWIFIEX_DFS_ADD_FILE(info);
+        MWIFIEX_DFS_ADD_FILE(debug);
+        MWIFIEX_DFS_ADD_FILE(getlog);
+        MWIFIEX_DFS_ADD_FILE(regrdwr);
+        MWIFIEX_DFS_ADD_FILE(rdeeprom);
+}
+/*
+ * This function removes the debug FS directory structure and the files.
+ */
+void
+mwifiex_dev_debugfs_remove(struct mwifiex_private *priv)
+{
+        if (!priv)
+                return;
+        debugfs_remove_recursive(priv->dfs_dev_dir);
+}
+/*
+ * This function creates the top level proc directory.
+ */
+void
+mwifiex_debugfs_init(void)
+{
+        if (!mwifiex_dfs_dir)
+                mwifiex_dfs_dir = debugfs_create_dir("mwifiex", NULL);
+}
+/*
+ * This function removes the top level proc directory.
+ */
+void
+mwifiex_debugfs_remove(void)
+{
+        if (mwifiex_dfs_dir)
+                debugfs_remove(mwifiex_dfs_dir);
+}
diff --git a/drivers/net/wireless/mwifiex/decl.h b/drivers/net/wireless/mwifiex/decl.h
new file mode 100644
index 000000000000..0e90b0986ed8
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/decl.h
@@ -0,0 +1,129 @@
+/*
+ * Marvell Wireless LAN device driver: generic data structures and APIs
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef _MWIFIEX_DECL_H_
+#define _MWIFIEX_DECL_H_
+#undef pr_fmt
+#define pr_fmt(fmt)     KBUILD_MODNAME ": " fmt
+#include <linux/wait.h>
+#include <linux/timer.h>
+#include <linux/ieee80211.h>
+#define MWIFIEX_MAX_BSS_NUM         (1)
+#define MWIFIEX_MIN_DATA_HEADER_LEN 32  /* (sizeof(mwifiex_txpd)) */
+#define MWIFIEX_MAX_TX_BASTREAM_SUPPORTED       2
+#define MWIFIEX_MAX_RX_BASTREAM_SUPPORTED       16
+#define MWIFIEX_AMPDU_DEF_TXWINSIZE        32
+#define MWIFIEX_AMPDU_DEF_RXWINSIZE        16
+#define MWIFIEX_DEFAULT_BLOCK_ACK_TIMEOUT  0xffff
+#define MWIFIEX_RATE_INDEX_HRDSSS0 0
+#define MWIFIEX_RATE_INDEX_HRDSSS3 3
+#define MWIFIEX_RATE_INDEX_OFDM0   4
+#define MWIFIEX_RATE_INDEX_OFDM7   11
+#define MWIFIEX_RATE_INDEX_MCS0    12
+#define MWIFIEX_RATE_BITMAP_OFDM0  16
+#define MWIFIEX_RATE_BITMAP_OFDM7  23
+#define MWIFIEX_RATE_BITMAP_MCS0   32
+#define MWIFIEX_RATE_BITMAP_MCS127 159
+#define MWIFIEX_RX_DATA_BUF_SIZE     (4 * 1024)
+#define MWIFIEX_RTS_MIN_VALUE              (0)
+#define MWIFIEX_RTS_MAX_VALUE              (2347)
+#define MWIFIEX_FRAG_MIN_VALUE             (256)
+#define MWIFIEX_FRAG_MAX_VALUE             (2346)
+#define MWIFIEX_SDIO_BLOCK_SIZE            256
+#define MWIFIEX_BUF_FLAG_REQUEUED_PKT      BIT(0)
+enum mwifiex_bss_type {
+        MWIFIEX_BSS_TYPE_STA = 0,
+        MWIFIEX_BSS_TYPE_UAP = 1,
+        MWIFIEX_BSS_TYPE_ANY = 0xff,
+};
+enum mwifiex_bss_role {
+        MWIFIEX_BSS_ROLE_STA = 0,
+        MWIFIEX_BSS_ROLE_UAP = 1,
+        MWIFIEX_BSS_ROLE_ANY = 0xff,
+};
+#define BSS_ROLE_BIT_MASK    BIT(0)
+#define GET_BSS_ROLE(priv)   ((priv)->bss_role & BSS_ROLE_BIT_MASK)
+enum mwifiex_data_frame_type {
+        MWIFIEX_DATA_FRAME_TYPE_ETH_II = 0,
+        MWIFIEX_DATA_FRAME_TYPE_802_11,
+};
+struct mwifiex_fw_image {
+        u8 *helper_buf;
+        u32 helper_len;
+        u8 *fw_buf;
+        u32 fw_len;
+};
+struct mwifiex_802_11_ssid {
+        u32 ssid_len;
+        u8 ssid[IEEE80211_MAX_SSID_LEN];
+};
+struct mwifiex_wait_queue {
+        wait_queue_head_t wait;
+        u16 condition;
+        int status;
+};
+struct mwifiex_rxinfo {
+        u8 bss_index;
+        struct sk_buff *parent;
+        u8 use_count;
+};
+struct mwifiex_txinfo {
+        u32 status_code;
+        u8 flags;
+        u8 bss_index;
+};
+struct mwifiex_bss_attr {
+        u8 bss_type;
+        u8 frame_type;
+        u8 active;
+        u8 bss_priority;
+        u8 bss_num;
+};
+enum mwifiex_wmm_ac_e {
+        WMM_AC_BK,
+        WMM_AC_BE,
+        WMM_AC_VI,
+        WMM_AC_VO
+} __packed;
+#endif /* !_MWIFIEX_DECL_H_ */
diff --git a/drivers/net/wireless/mwifiex/fw.h b/drivers/net/wireless/mwifiex/fw.h
new file mode 100644
index 000000000000..afdd145dff0b
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/fw.h
@@ -0,0 +1,1187 @@
+/*
+ * Marvell Wireless LAN device driver: Firmware specific macros & structures
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef _MWIFIEX_FW_H_
+#define _MWIFIEX_FW_H_
+#include <linux/if_ether.h>
+#define INTF_HEADER_LEN     4
+struct rfc_1042_hdr {
+        u8 llc_dsap;
+        u8 llc_ssap;
+        u8 llc_ctrl;
+        u8 snap_oui[3];
+        u16 snap_type;
+};
+struct rx_packet_hdr {
+        struct ethhdr eth803_hdr;
+        struct rfc_1042_hdr rfc1042_hdr;
+};
+struct tx_packet_hdr {
+        struct ethhdr eth803_hdr;
+        struct rfc_1042_hdr rfc1042_hdr;
+};
+#define B_SUPPORTED_RATES               5
+#define G_SUPPORTED_RATES               9
+#define BG_SUPPORTED_RATES              13
+#define A_SUPPORTED_RATES               9
+#define HOSTCMD_SUPPORTED_RATES         14
+#define N_SUPPORTED_RATES               3
+#define ALL_802_11_BANDS           (BAND_A | BAND_B | BAND_G | BAND_GN)
+#define FW_MULTI_BANDS_SUPPORT  (BIT(8) | BIT(9) | BIT(10) | BIT(11))
+#define IS_SUPPORT_MULTI_BANDS(adapter)        \
+        (adapter->fw_cap_info & FW_MULTI_BANDS_SUPPORT)
+#define GET_FW_DEFAULT_BANDS(adapter)  \
+        ((adapter->fw_cap_info >> 8) & ALL_802_11_BANDS)
+extern u8 supported_rates_b[B_SUPPORTED_RATES];
+extern u8 supported_rates_g[G_SUPPORTED_RATES];
+extern u8 supported_rates_bg[BG_SUPPORTED_RATES];
+extern u8 supported_rates_a[A_SUPPORTED_RATES];
+extern u8 supported_rates_n[N_SUPPORTED_RATES];
+#define HostCmd_WEP_KEY_INDEX_MASK              0x3fff
+#define KEY_INFO_ENABLED        0x01
+enum KEY_TYPE_ID {
+        KEY_TYPE_ID_WEP = 0,
+        KEY_TYPE_ID_TKIP,
+        KEY_TYPE_ID_AES,
+        KEY_TYPE_ID_WAPI,
+};
+#define KEY_MCAST       BIT(0)
+#define KEY_UNICAST     BIT(1)
+#define KEY_ENABLED     BIT(2)
+#define WAPI_KEY_LEN                    50
+#define MAX_POLL_TRIES                  100
+#define MAX_MULTI_INTERFACE_POLL_TRIES  1000
+#define MAX_FIRMWARE_POLL_TRIES                 100
+#define FIRMWARE_READY                          0xfedc
+enum MWIFIEX_802_11_PRIVACY_FILTER {
+        MWIFIEX_802_11_PRIV_FILTER_ACCEPT_ALL,
+        MWIFIEX_802_11_PRIV_FILTER_8021X_WEP
+};
+enum MWIFIEX_802_11_WEP_STATUS {
+        MWIFIEX_802_11_WEP_ENABLED,
+        MWIFIEX_802_11_WEP_DISABLED,
+};
+#define CAL_SNR(RSSI, NF)               ((s16)((s16)(RSSI)-(s16)(NF)))
+#define PROPRIETARY_TLV_BASE_ID                 0x0100
+#define TLV_TYPE_KEY_MATERIAL       (PROPRIETARY_TLV_BASE_ID + 0)
+#define TLV_TYPE_CHANLIST           (PROPRIETARY_TLV_BASE_ID + 1)
+#define TLV_TYPE_NUMPROBES          (PROPRIETARY_TLV_BASE_ID + 2)
+#define TLV_TYPE_PASSTHROUGH        (PROPRIETARY_TLV_BASE_ID + 10)
+#define TLV_TYPE_WMMQSTATUS         (PROPRIETARY_TLV_BASE_ID + 16)
+#define TLV_TYPE_WILDCARDSSID       (PROPRIETARY_TLV_BASE_ID + 18)
+#define TLV_TYPE_TSFTIMESTAMP       (PROPRIETARY_TLV_BASE_ID + 19)
+#define TLV_TYPE_AUTH_TYPE          (PROPRIETARY_TLV_BASE_ID + 31)
+#define TLV_TYPE_CHANNELBANDLIST    (PROPRIETARY_TLV_BASE_ID + 42)
+#define TLV_TYPE_RATE_DROP_CONTROL  (PROPRIETARY_TLV_BASE_ID + 82)
+#define TLV_TYPE_RATE_SCOPE         (PROPRIETARY_TLV_BASE_ID + 83)
+#define TLV_TYPE_POWER_GROUP        (PROPRIETARY_TLV_BASE_ID + 84)
+#define TLV_TYPE_WAPI_IE            (PROPRIETARY_TLV_BASE_ID + 94)
+#define TLV_TYPE_AUTO_DS_PARAM      (PROPRIETARY_TLV_BASE_ID + 113)
+#define TLV_TYPE_PS_PARAM           (PROPRIETARY_TLV_BASE_ID + 114)
+#define MWIFIEX_TX_DATA_BUF_SIZE_2K        2048
+#define SSN_MASK         0xfff0
+#define BA_RESULT_SUCCESS        0x0
+#define BA_RESULT_TIMEOUT        0x2
+#define IS_BASTREAM_SETUP(ptr)  (ptr->ba_status)
+#define BA_STREAM_NOT_ALLOWED   0xff
+#define IS_11N_ENABLED(priv) ((priv->adapter->config_bands & BAND_GN || \
+                        priv->adapter->config_bands & BAND_AN) \
+                        && priv->curr_bss_params.bss_descriptor.bcn_ht_cap)
+#define INITIATOR_BIT(DelBAParamSet) (((DelBAParamSet) &\
+                        BIT(DELBA_INITIATOR_POS)) >> DELBA_INITIATOR_POS)
+#define MWIFIEX_TX_DATA_BUF_SIZE_4K        4096
+#define MWIFIEX_TX_DATA_BUF_SIZE_8K        8192
+#define ISSUPP_11NENABLED(FwCapInfo) (FwCapInfo & BIT(11))
+/* dev_cap bitmap
+ * BIT
+ * 0-16         reserved
+ * 17           IEEE80211_HT_CAP_SUP_WIDTH_20_40
+ * 18-22        reserved
+ * 23           IEEE80211_HT_CAP_SGI_20
+ * 24           IEEE80211_HT_CAP_SGI_40
+ * 25           IEEE80211_HT_CAP_TX_STBC
+ * 26           IEEE80211_HT_CAP_RX_STBC
+ * 27-28        reserved
+ * 29           IEEE80211_HT_CAP_GRN_FLD
+ * 30-31        reserved
+ */
+#define ISSUPP_CHANWIDTH40(Dot11nDevCap) (Dot11nDevCap & BIT(17))
+#define ISSUPP_SHORTGI20(Dot11nDevCap) (Dot11nDevCap & BIT(23))
+#define ISSUPP_SHORTGI40(Dot11nDevCap) (Dot11nDevCap & BIT(24))
+#define ISSUPP_TXSTBC(Dot11nDevCap) (Dot11nDevCap & BIT(25))
+#define ISSUPP_RXSTBC(Dot11nDevCap) (Dot11nDevCap & BIT(26))
+#define ISSUPP_GREENFIELD(Dot11nDevCap) (Dot11nDevCap & BIT(29))
+#define GET_RXMCSSUPP(DevMCSSupported) (DevMCSSupported & 0x0f)
+#define SETHT_MCS32(x) (x[4] |= 1)
+#define SET_SECONDARYCHAN(RadioType, SECCHAN) (RadioType |= (SECCHAN << 4))
+#define LLC_SNAP_LEN    8
+#define MOD_CLASS_HR_DSSS       0x03
+#define MOD_CLASS_OFDM          0x07
+#define MOD_CLASS_HT            0x08
+#define HT_BW_20    0
+#define HT_BW_40    1
+#define HostCmd_CMD_GET_HW_SPEC                       0x0003
+#define HostCmd_CMD_802_11_SCAN                       0x0006
+#define HostCmd_CMD_802_11_GET_LOG                    0x000b
+#define HostCmd_CMD_MAC_MULTICAST_ADR                 0x0010
+#define HostCmd_CMD_802_11_EEPROM_ACCESS              0x0059
+#define HostCmd_CMD_802_11_ASSOCIATE                  0x0012
+#define HostCmd_CMD_802_11_SNMP_MIB                   0x0016
+#define HostCmd_CMD_MAC_REG_ACCESS                    0x0019
+#define HostCmd_CMD_BBP_REG_ACCESS                    0x001a
+#define HostCmd_CMD_RF_REG_ACCESS                     0x001b
+#define HostCmd_CMD_PMIC_REG_ACCESS                   0x00ad
+#define HostCmd_CMD_802_11_RF_CHANNEL                 0x001d
+#define HostCmd_CMD_802_11_DEAUTHENTICATE             0x0024
+#define HostCmd_CMD_MAC_CONTROL                       0x0028
+#define HostCmd_CMD_802_11_AD_HOC_START               0x002b
+#define HostCmd_CMD_802_11_AD_HOC_JOIN                0x002c
+#define HostCmd_CMD_802_11_AD_HOC_STOP                0x0040
+#define HostCmd_CMD_802_11_MAC_ADDRESS                0x004D
+#define HostCmd_CMD_802_11D_DOMAIN_INFO               0x005b
+#define HostCmd_CMD_802_11_KEY_MATERIAL               0x005e
+#define HostCmd_CMD_802_11_BG_SCAN_QUERY              0x006c
+#define HostCmd_CMD_WMM_GET_STATUS                    0x0071
+#define HostCmd_CMD_802_11_TX_RATE_QUERY              0x007f
+#define HostCmd_CMD_802_11_IBSS_COALESCING_STATUS     0x0083
+#define HostCmd_CMD_VERSION_EXT                       0x0097
+#define HostCmd_CMD_RSSI_INFO                         0x00a4
+#define HostCmd_CMD_FUNC_INIT                         0x00a9
+#define HostCmd_CMD_FUNC_SHUTDOWN                     0x00aa
+#define HostCmd_CMD_11N_CFG                           0x00cd
+#define HostCmd_CMD_11N_ADDBA_REQ                     0x00ce
+#define HostCmd_CMD_11N_ADDBA_RSP                     0x00cf
+#define HostCmd_CMD_11N_DELBA                         0x00d0
+#define HostCmd_CMD_RECONFIGURE_TX_BUFF               0x00d9
+#define HostCmd_CMD_AMSDU_AGGR_CTRL                   0x00df
+#define HostCmd_CMD_TXPWR_CFG                         0x00d1
+#define HostCmd_CMD_TX_RATE_CFG                       0x00d6
+#define HostCmd_CMD_802_11_PS_MODE_ENH                0x00e4
+#define HostCmd_CMD_802_11_HS_CFG_ENH                 0x00e5
+#define HostCmd_CMD_CAU_REG_ACCESS                    0x00ed
+#define HostCmd_CMD_SET_BSS_MODE                      0x00f7
+enum ENH_PS_MODES {
+        EN_PS = 1,
+        DIS_PS = 2,
+        EN_AUTO_DS = 3,
+        DIS_AUTO_DS = 4,
+        SLEEP_CONFIRM = 5,
+        GET_PS = 0,
+        EN_AUTO_PS = 0xff,
+        DIS_AUTO_PS = 0xfe,
+};
+#define HostCmd_RET_BIT                       0x8000
+#define HostCmd_ACT_GEN_GET                   0x0000
+#define HostCmd_ACT_GEN_SET                   0x0001
+#define HostCmd_RESULT_OK                     0x0000
+#define HostCmd_ACT_MAC_RX_ON                 0x0001
+#define HostCmd_ACT_MAC_TX_ON                 0x0002
+#define HostCmd_ACT_MAC_WEP_ENABLE            0x0008
+#define HostCmd_ACT_MAC_ETHERNETII_ENABLE     0x0010
+#define HostCmd_ACT_MAC_PROMISCUOUS_ENABLE    0x0080
+#define HostCmd_ACT_MAC_ALL_MULTICAST_ENABLE  0x0100
+#define HostCmd_ACT_MAC_ADHOC_G_PROTECTION_ON     0x2000
+#define HostCmd_BSS_MODE_IBSS               0x0002
+#define HostCmd_BSS_MODE_ANY                0x0003
+#define HostCmd_SCAN_RADIO_TYPE_BG          0
+#define HostCmd_SCAN_RADIO_TYPE_A           1
+#define HOST_SLEEP_CFG_CANCEL           0xffffffff
+#define HOST_SLEEP_CFG_COND_DEF         0x0000000f
+#define HOST_SLEEP_CFG_GPIO_DEF         0xff
+#define HOST_SLEEP_CFG_GAP_DEF          0
+#define CMD_F_HOSTCMD           (1 << 0)
+#define CMD_F_CANCELED          (1 << 1)
+#define HostCmd_CMD_ID_MASK             0x0fff
+#define HostCmd_SEQ_NUM_MASK            0x00ff
+#define HostCmd_BSS_NUM_MASK            0x0f00
+#define HostCmd_BSS_TYPE_MASK           0xf000
+#define HostCmd_SET_SEQ_NO_BSS_INFO(seq, num, type) {   \
+        (((seq) & 0x00ff) |                             \
+         (((num) & 0x000f) << 8)) |                     \
+        (((type) & 0x000f) << 12);                  }
+#define HostCmd_GET_SEQ_NO(seq)       \
+        ((seq) & HostCmd_SEQ_NUM_MASK)
+#define HostCmd_GET_BSS_NO(seq)         \
+        (((seq) & HostCmd_BSS_NUM_MASK) >> 8)
+#define HostCmd_GET_BSS_TYPE(seq)       \
+        (((seq) & HostCmd_BSS_TYPE_MASK) >> 12)
+#define EVENT_DUMMY_HOST_WAKEUP_SIGNAL  0x00000001
+#define EVENT_LINK_LOST                 0x00000003
+#define EVENT_LINK_SENSED               0x00000004
+#define EVENT_MIB_CHANGED               0x00000006
+#define EVENT_INIT_DONE                 0x00000007
+#define EVENT_DEAUTHENTICATED           0x00000008
+#define EVENT_DISASSOCIATED             0x00000009
+#define EVENT_PS_AWAKE                  0x0000000a
+#define EVENT_PS_SLEEP                  0x0000000b
+#define EVENT_MIC_ERR_MULTICAST         0x0000000d
+#define EVENT_MIC_ERR_UNICAST           0x0000000e
+#define EVENT_DEEP_SLEEP_AWAKE          0x00000010
+#define EVENT_ADHOC_BCN_LOST            0x00000011
+#define EVENT_WMM_STATUS_CHANGE         0x00000017
+#define EVENT_BG_SCAN_REPORT            0x00000018
+#define EVENT_RSSI_LOW                  0x00000019
+#define EVENT_SNR_LOW                   0x0000001a
+#define EVENT_MAX_FAIL                  0x0000001b
+#define EVENT_RSSI_HIGH                 0x0000001c
+#define EVENT_SNR_HIGH                  0x0000001d
+#define EVENT_IBSS_COALESCED            0x0000001e
+#define EVENT_DATA_RSSI_LOW             0x00000024
+#define EVENT_DATA_SNR_LOW              0x00000025
+#define EVENT_DATA_RSSI_HIGH            0x00000026
+#define EVENT_DATA_SNR_HIGH             0x00000027
+#define EVENT_LINK_QUALITY              0x00000028
+#define EVENT_PORT_RELEASE              0x0000002b
+#define EVENT_PRE_BEACON_LOST           0x00000031
+#define EVENT_ADDBA                     0x00000033
+#define EVENT_DELBA                     0x00000034
+#define EVENT_BA_STREAM_TIEMOUT         0x00000037
+#define EVENT_AMSDU_AGGR_CTRL           0x00000042
+#define EVENT_WEP_ICV_ERR               0x00000046
+#define EVENT_HS_ACT_REQ                0x00000047
+#define EVENT_BW_CHANGE                 0x00000048
+#define EVENT_HOSTWAKE_STAIE            0x0000004d
+#define EVENT_ID_MASK                   0xffff
+#define BSS_NUM_MASK                    0xf
+#define EVENT_GET_BSS_NUM(event_cause)          \
+        (((event_cause) >> 16) & BSS_NUM_MASK)
+#define EVENT_GET_BSS_TYPE(event_cause)         \
+        (((event_cause) >> 24) & 0x00ff)
+struct mwifiex_ie_types_header {
+        __le16 type;
+        __le16 len;
+} __packed;
+struct mwifiex_ie_types_data {
+        struct mwifiex_ie_types_header header;
+        u8 data[1];
+} __packed;
+#define MWIFIEX_TxPD_POWER_MGMT_NULL_PACKET 0x01
+#define MWIFIEX_TxPD_POWER_MGMT_LAST_PACKET 0x08
+struct txpd {
+        u8 bss_type;
+        u8 bss_num;
+        __le16 tx_pkt_length;
+        __le16 tx_pkt_offset;
+        __le16 tx_pkt_type;
+        __le32 tx_control;
+        u8 priority;
+        u8 flags;
+        u8 pkt_delay_2ms;
+        u8 reserved1;
+} __packed;
+struct rxpd {
+        u8 bss_type;
+        u8 bss_num;
+        u16 rx_pkt_length;
+        u16 rx_pkt_offset;
+        u16 rx_pkt_type;
+        u16 seq_num;
+        u8 priority;
+        u8 rx_rate;
+        s8 snr;
+        s8 nf;
+        /* Ht Info [Bit 0] RxRate format: LG=0, HT=1
+         * [Bit 1]  HT Bandwidth: BW20 = 0, BW40 = 1
+         * [Bit 2]  HT Guard Interval: LGI = 0, SGI = 1 */
+        u8 ht_info;
+        u8 reserved;
+} __packed;
+enum mwifiex_chan_scan_mode_bitmasks {
+        MWIFIEX_PASSIVE_SCAN = BIT(0),
+        MWIFIEX_DISABLE_CHAN_FILT = BIT(1),
+};
+#define SECOND_CHANNEL_BELOW    0x30
+#define SECOND_CHANNEL_ABOVE    0x10
+struct mwifiex_chan_scan_param_set {
+        u8 radio_type;
+        u8 chan_number;
+        u8 chan_scan_mode_bitmap;
+        __le16 min_scan_time;
+        __le16 max_scan_time;
+} __packed;
+struct mwifiex_ie_types_chan_list_param_set {
+        struct mwifiex_ie_types_header header;
+        struct mwifiex_chan_scan_param_set chan_scan_param[1];
+} __packed;
+struct chan_band_param_set {
+        u8 radio_type;
+        u8 chan_number;
+};
+struct mwifiex_ie_types_chan_band_list_param_set {
+        struct mwifiex_ie_types_header header;
+        struct chan_band_param_set chan_band_param[1];
+} __packed;
+struct mwifiex_ie_types_rates_param_set {
+        struct mwifiex_ie_types_header header;
+        u8 rates[1];
+} __packed;
+struct mwifiex_ie_types_ssid_param_set {
+        struct mwifiex_ie_types_header header;
+        u8 ssid[1];
+} __packed;
+struct mwifiex_ie_types_num_probes {
+        struct mwifiex_ie_types_header header;
+        __le16 num_probes;
+} __packed;
+struct mwifiex_ie_types_wildcard_ssid_params {
+        struct mwifiex_ie_types_header header;
+        u8 max_ssid_length;
+        u8 ssid[1];
+} __packed;
+#define TSF_DATA_SIZE            8
+struct mwifiex_ie_types_tsf_timestamp {
+        struct mwifiex_ie_types_header header;
+        u8 tsf_data[1];
+} __packed;
+struct mwifiex_cf_param_set {
+        u8 cfp_cnt;
+        u8 cfp_period;
+        u16 cfp_max_duration;
+        u16 cfp_duration_remaining;
+} __packed;
+struct mwifiex_ibss_param_set {
+        u16 atim_window;
+} __packed;
+struct mwifiex_ie_types_ss_param_set {
+        struct mwifiex_ie_types_header header;
+        union {
+                struct mwifiex_cf_param_set cf_param_set[1];
+                struct mwifiex_ibss_param_set ibss_param_set[1];
+        } cf_ibss;
+} __packed;
+struct mwifiex_fh_param_set {
+        u16 dwell_time;
+        u8 hop_set;
+        u8 hop_pattern;
+        u8 hop_index;
+} __packed;
+struct mwifiex_ds_param_set {
+        u8 current_chan;
+} __packed;
+struct mwifiex_ie_types_phy_param_set {
+        struct mwifiex_ie_types_header header;
+        union {
+                struct mwifiex_fh_param_set fh_param_set[1];
+                struct mwifiex_ds_param_set ds_param_set[1];
+        } fh_ds;
+} __packed;
+struct mwifiex_ie_types_auth_type {
+        struct mwifiex_ie_types_header header;
+        __le16 auth_type;
+} __packed;
+struct mwifiex_ie_types_vendor_param_set {
+        struct mwifiex_ie_types_header header;
+        u8 ie[MWIFIEX_MAX_VSIE_LEN];
+};
+struct mwifiex_ie_types_rsn_param_set {
+        struct mwifiex_ie_types_header header;
+        u8 rsn_ie[1];
+} __packed;
+#define KEYPARAMSET_FIXED_LEN 6
+struct mwifiex_ie_type_key_param_set {
+        __le16 type;
+        __le16 length;
+        __le16 key_type_id;
+        __le16 key_info;
+        __le16 key_len;
+        u8 key[50];
+} __packed;
+struct host_cmd_ds_802_11_key_material {
+        __le16 action;
+        struct mwifiex_ie_type_key_param_set key_param_set;
+} __packed;
+struct host_cmd_ds_gen {
+        u16 command;
+        u16 size;
+        u16 seq_num;
+        u16 result;
+};
+#define S_DS_GEN        sizeof(struct host_cmd_ds_gen)
+enum sleep_resp_ctrl {
+        RESP_NOT_NEEDED = 0,
+        RESP_NEEDED,
+};
+struct mwifiex_ps_param {
+        __le16 null_pkt_interval;
+        __le16 multiple_dtims;
+        __le16 bcn_miss_timeout;
+        __le16 local_listen_interval;
+        __le16 adhoc_wake_period;
+        __le16 mode;
+        __le16 delay_to_ps;
+};
+#define BITMAP_AUTO_DS         0x01
+#define BITMAP_STA_PS          0x10
+struct mwifiex_ie_types_auto_ds_param {
+        struct mwifiex_ie_types_header header;
+        __le16 deep_sleep_timeout;
+} __packed;
+struct mwifiex_ie_types_ps_param {
+        struct mwifiex_ie_types_header header;
+        struct mwifiex_ps_param param;
+} __packed;
+struct host_cmd_ds_802_11_ps_mode_enh {
+        __le16 action;
+        union {
+                struct mwifiex_ps_param opt_ps;
+                __le16 ps_bitmap;
+        } params;
+} __packed;
+struct host_cmd_ds_get_hw_spec {
+        __le16 hw_if_version;
+        __le16 version;
+        __le16 reserved;
+        __le16 num_of_mcast_adr;
+        u8 permanent_addr[ETH_ALEN];
+        __le16 region_code;
+        __le16 number_of_antenna;
+        __le32 fw_release_number;
+        __le32 reserved_1;
+        __le32 reserved_2;
+        __le32 reserved_3;
+        __le32 fw_cap_info;
+        __le32 dot_11n_dev_cap;
+        u8 dev_mcs_support;
+        __le16 mp_end_port;     /* SDIO only, reserved for other interfacces */
+        __le16 reserved_4;
+} __packed;
+struct host_cmd_ds_802_11_rssi_info {
+        __le16 action;
+        __le16 ndata;
+        __le16 nbcn;
+        __le16 reserved[9];
+        long long reserved_1;
+};
+struct host_cmd_ds_802_11_rssi_info_rsp {
+        __le16 action;
+        __le16 ndata;
+        __le16 nbcn;
+        __le16 data_rssi_last;
+        __le16 data_nf_last;
+        __le16 data_rssi_avg;
+        __le16 data_nf_avg;
+        __le16 bcn_rssi_last;
+        __le16 bcn_nf_last;
+        __le16 bcn_rssi_avg;
+        __le16 bcn_nf_avg;
+        long long tsf_bcn;
+};
+struct host_cmd_ds_802_11_mac_address {
+        __le16 action;
+        u8 mac_addr[ETH_ALEN];
+};
+struct host_cmd_ds_mac_control {
+        __le16 action;
+        __le16 reserved;
+};
+struct host_cmd_ds_mac_multicast_adr {
+        __le16 action;
+        __le16 num_of_adrs;
+        u8 mac_list[MWIFIEX_MAX_MULTICAST_LIST_SIZE][ETH_ALEN];
+} __packed;
+struct host_cmd_ds_802_11_deauthenticate {
+        u8 mac_addr[ETH_ALEN];
+        __le16 reason_code;
+} __packed;
+struct host_cmd_ds_802_11_associate {
+        u8 peer_sta_addr[ETH_ALEN];
+        __le16 cap_info_bitmap;
+        __le16 listen_interval;
+        __le16 beacon_period;
+        u8 dtim_period;
+} __packed;
+struct ieee_types_assoc_rsp {
+        __le16 cap_info_bitmap;
+        __le16 status_code;
+        __le16 a_id;
+        u8 ie_buffer[1];
+} __packed;
+struct host_cmd_ds_802_11_associate_rsp {
+        struct ieee_types_assoc_rsp assoc_rsp;
+} __packed;
+struct ieee_types_cf_param_set {
+        u8 element_id;
+        u8 len;
+        u8 cfp_cnt;
+        u8 cfp_period;
+        u16 cfp_max_duration;
+        u16 cfp_duration_remaining;
+} __packed;
+struct ieee_types_ibss_param_set {
+        u8 element_id;
+        u8 len;
+        __le16 atim_window;
+} __packed;
+union ieee_types_ss_param_set {
+        struct ieee_types_cf_param_set cf_param_set;
+        struct ieee_types_ibss_param_set ibss_param_set;
+} __packed;
+struct ieee_types_fh_param_set {
+        u8 element_id;
+        u8 len;
+        __le16 dwell_time;
+        u8 hop_set;
+        u8 hop_pattern;
+        u8 hop_index;
+} __packed;
+struct ieee_types_ds_param_set {
+        u8 element_id;
+        u8 len;
+        u8 current_chan;
+} __packed;
+union ieee_types_phy_param_set {
+        struct ieee_types_fh_param_set fh_param_set;
+        struct ieee_types_ds_param_set ds_param_set;
+} __packed;
+struct host_cmd_ds_802_11_ad_hoc_start {
+        u8 ssid[IEEE80211_MAX_SSID_LEN];
+        u8 bss_mode;
+        __le16 beacon_period;
+        u8 dtim_period;
+        union ieee_types_ss_param_set ss_param_set;
+        union ieee_types_phy_param_set phy_param_set;
+        u16 reserved1;
+        __le16 cap_info_bitmap;
+        u8 DataRate[HOSTCMD_SUPPORTED_RATES];
+} __packed;
+struct host_cmd_ds_802_11_ad_hoc_result {
+        u8 pad[3];
+        u8 bssid[ETH_ALEN];
+} __packed;
+struct adhoc_bss_desc {
+        u8 bssid[ETH_ALEN];
+        u8 ssid[IEEE80211_MAX_SSID_LEN];
+        u8 bss_mode;
+        __le16 beacon_period;
+        u8 dtim_period;
+        u8 time_stamp[8];
+        u8 local_time[8];
+        union ieee_types_phy_param_set phy_param_set;
+        union ieee_types_ss_param_set ss_param_set;
+        __le16 cap_info_bitmap;
+        u8 data_rates[HOSTCMD_SUPPORTED_RATES];
+        /*
+         *  DO NOT ADD ANY FIELDS TO THIS STRUCTURE.
+         *  It is used in the Adhoc join command and will cause a
+         *  binary layout mismatch with the firmware
+         */
+} __packed;
+struct host_cmd_ds_802_11_ad_hoc_join {
+        struct adhoc_bss_desc bss_descriptor;
+        u16 reserved1;
+        u16 reserved2;
+} __packed;
+struct host_cmd_ds_802_11_get_log {
+        __le32 mcast_tx_frame;
+        __le32 failed;
+        __le32 retry;
+        __le32 multi_retry;
+        __le32 frame_dup;
+        __le32 rts_success;
+        __le32 rts_failure;
+        __le32 ack_failure;
+        __le32 rx_frag;
+        __le32 mcast_rx_frame;
+        __le32 fcs_error;
+        __le32 tx_frame;
+        __le32 reserved;
+        __le32 wep_icv_err_cnt[4];
+};
+struct host_cmd_ds_tx_rate_query {
+        u8 tx_rate;
+        /* Ht Info [Bit 0] RxRate format: LG=0, HT=1
+         * [Bit 1]  HT Bandwidth: BW20 = 0, BW40 = 1
+         * [Bit 2]  HT Guard Interval: LGI = 0, SGI = 1 */
+        u8 ht_info;
+} __packed;
+enum Host_Sleep_Action {
+        HS_CONFIGURE = 0x0001,
+        HS_ACTIVATE  = 0x0002,
+};
+struct mwifiex_hs_config_param {
+        __le32 conditions;
+        u8 gpio;
+        u8 gap;
+} __packed;
+struct hs_activate_param {
+        u16 resp_ctrl;
+} __packed;
+struct host_cmd_ds_802_11_hs_cfg_enh {
+        __le16 action;
+        union {
+                struct mwifiex_hs_config_param hs_config;
+                struct hs_activate_param hs_activate;
+        } params;
+} __packed;
+enum SNMP_MIB_INDEX {
+        OP_RATE_SET_I = 1,
+        DTIM_PERIOD_I = 3,
+        RTS_THRESH_I = 5,
+        SHORT_RETRY_LIM_I = 6,
+        LONG_RETRY_LIM_I = 7,
+        FRAG_THRESH_I = 8,
+        DOT11D_I = 9,
+};
+#define MAX_SNMP_BUF_SIZE   128
+struct host_cmd_ds_802_11_snmp_mib {
+        __le16 query_type;
+        __le16 oid;
+        __le16 buf_size;
+        u8 value[1];
+} __packed;
+struct mwifiex_rate_scope {
+        __le16 type;
+        __le16 length;
+        __le16 hr_dsss_rate_bitmap;
+        __le16 ofdm_rate_bitmap;
+        __le16 ht_mcs_rate_bitmap[8];
+} __packed;
+struct mwifiex_rate_drop_pattern {
+        __le16 type;
+        __le16 length;
+        __le32 rate_drop_mode;
+} __packed;
+struct host_cmd_ds_tx_rate_cfg {
+        __le16 action;
+        __le16 cfg_index;
+} __packed;
+struct mwifiex_power_group {
+        u8 modulation_class;
+        u8 first_rate_code;
+        u8 last_rate_code;
+        s8 power_step;
+        s8 power_min;
+        s8 power_max;
+        u8 ht_bandwidth;
+        u8 reserved;
+} __packed;
+struct mwifiex_types_power_group {
+        u16 type;
+        u16 length;
+} __packed;
+struct host_cmd_ds_txpwr_cfg {
+        __le16 action;
+        __le16 cfg_index;
+        __le32 mode;
+} __packed;
+#define MWIFIEX_USER_SCAN_CHAN_MAX             50
+#define MWIFIEX_MAX_SSID_LIST_LENGTH         10
+struct mwifiex_scan_cmd_config {
+        /*
+         *  BSS mode to be sent in the firmware command
+         */
+        u8 bss_mode;
+        /* Specific BSSID used to filter scan results in the firmware */
+        u8 specific_bssid[ETH_ALEN];
+        /* Length of TLVs sent in command starting at tlvBuffer */
+        u32 tlv_buf_len;
+        /*
+         *  SSID TLV(s) and ChanList TLVs to be sent in the firmware command
+         *
+         *  TLV_TYPE_CHANLIST, mwifiex_ie_types_chan_list_param_set
+         *  WLAN_EID_SSID, mwifiex_ie_types_ssid_param_set
+         */
+        u8 tlv_buf[1];  /* SSID TLV(s) and ChanList TLVs are stored
+                                   here */
+} __packed;
+struct mwifiex_user_scan_chan {
+        u8 chan_number;
+        u8 radio_type;
+        u8 scan_type;
+        u8 reserved;
+        u32 scan_time;
+} __packed;
+struct mwifiex_user_scan_ssid {
+        u8 ssid[IEEE80211_MAX_SSID_LEN + 1];
+        u8 max_len;
+} __packed;
+struct mwifiex_user_scan_cfg {
+        /*
+         *  Flag set to keep the previous scan table intact
+         *
+         *  If set, the scan results will accumulate, replacing any previous
+         *   matched entries for a BSS with the new scan data
+         */
+        u8 keep_previous_scan;
+        /*
+         *  BSS mode to be sent in the firmware command
+         */
+        u8 bss_mode;
+        /* Configure the number of probe requests for active chan scans */
+        u8 num_probes;
+        u8 reserved;
+        /* BSSID filter sent in the firmware command to limit the results */
+        u8 specific_bssid[ETH_ALEN];
+        /* SSID filter list used in the to limit the scan results */
+        struct mwifiex_user_scan_ssid ssid_list[MWIFIEX_MAX_SSID_LIST_LENGTH];
+        /* Variable number (fixed maximum) of channels to scan up */
+        struct mwifiex_user_scan_chan chan_list[MWIFIEX_USER_SCAN_CHAN_MAX];
+} __packed;
+struct ie_body {
+        u8 grp_key_oui[4];
+        u8 ptk_cnt[2];
+        u8 ptk_body[4];
+} __packed;
+struct host_cmd_ds_802_11_scan {
+        u8 bss_mode;
+        u8 bssid[ETH_ALEN];
+        u8 tlv_buffer[1];
+} __packed;
+struct host_cmd_ds_802_11_scan_rsp {
+        __le16 bss_descript_size;
+        u8 number_of_sets;
+        u8 bss_desc_and_tlv_buffer[1];
+} __packed;
+struct host_cmd_ds_802_11_bg_scan_query {
+        u8 flush;
+} __packed;
+struct host_cmd_ds_802_11_bg_scan_query_rsp {
+        u32 report_condition;
+        struct host_cmd_ds_802_11_scan_rsp scan_resp;
+} __packed;
+struct mwifiex_ietypes_domain_param_set {
+        struct mwifiex_ie_types_header header;
+        u8 country_code[IEEE80211_COUNTRY_STRING_LEN];
+        struct ieee80211_country_ie_triplet triplet[1];
+} __packed;
+struct host_cmd_ds_802_11d_domain_info {
+        __le16 action;
+        struct mwifiex_ietypes_domain_param_set domain;
+} __packed;
+struct host_cmd_ds_802_11d_domain_info_rsp {
+        __le16 action;
+        struct mwifiex_ietypes_domain_param_set domain;
+} __packed;
+struct host_cmd_ds_11n_addba_req {
+        u8 add_req_result;
+        u8 peer_mac_addr[ETH_ALEN];
+        u8 dialog_token;
+        __le16 block_ack_param_set;
+        __le16 block_ack_tmo;
+        __le16 ssn;
+} __packed;
+struct host_cmd_ds_11n_addba_rsp {
+        u8 add_rsp_result;
+        u8 peer_mac_addr[ETH_ALEN];
+        u8 dialog_token;
+        __le16 status_code;
+        __le16 block_ack_param_set;
+        __le16 block_ack_tmo;
+        __le16 ssn;
+} __packed;
+struct host_cmd_ds_11n_delba {
+        u8 del_result;
+        u8 peer_mac_addr[ETH_ALEN];
+        __le16 del_ba_param_set;
+        __le16 reason_code;
+        u8 reserved;
+} __packed;
+struct host_cmd_ds_11n_batimeout {
+        u8 tid;
+        u8 peer_mac_addr[ETH_ALEN];
+        u8 origninator;
+} __packed;
+struct host_cmd_ds_11n_cfg {
+        __le16 action;
+        __le16 ht_tx_cap;
+        __le16 ht_tx_info;
+} __packed;
+struct host_cmd_ds_txbuf_cfg {
+        __le16 action;
+        __le16 buff_size;
+        __le16 mp_end_port;     /* SDIO only, reserved for other interfacces */
+        __le16 reserved3;
+} __packed;
+struct host_cmd_ds_amsdu_aggr_ctrl {
+        __le16 action;
+        __le16 enable;
+        __le16 curr_buf_size;
+} __packed;
+struct mwifiex_ie_types_wmm_param_set {
+        struct mwifiex_ie_types_header header;
+        u8 wmm_ie[1];
+};
+struct mwifiex_ie_types_wmm_queue_status {
+        struct mwifiex_ie_types_header header;
+        u8 queue_index;
+        u8 disabled;
+        u16 medium_time;
+        u8 flow_required;
+        u8 flow_created;
+        u32 reserved;
+};
+struct ieee_types_vendor_header {
+        u8 element_id;
+        u8 len;
+        u8 oui[3];
+        u8 oui_type;
+        u8 oui_subtype;
+        u8 version;
+} __packed;
+struct ieee_types_wmm_ac_parameters {
+        u8 aci_aifsn_bitmap;
+        u8 ecw_bitmap;
+        __le16 tx_op_limit;
+} __packed;
+struct ieee_types_wmm_parameter {
+        /*
+         * WMM Parameter IE - Vendor Specific Header:
+         *   element_id  [221/0xdd]
+         *   Len         [24]
+         *   Oui         [00:50:f2]
+         *   OuiType     [2]
+         *   OuiSubType  [1]
+         *   Version     [1]
+         */
+        struct ieee_types_vendor_header vend_hdr;
+        u8 qos_info_bitmap;
+        u8 reserved;
+        struct ieee_types_wmm_ac_parameters ac_params[IEEE80211_MAX_QUEUES];
+} __packed;
+struct ieee_types_wmm_info {
+        /*
+         * WMM Info IE - Vendor Specific Header:
+         *   element_id  [221/0xdd]
+         *   Len         [7]
+         *   Oui         [00:50:f2]
+         *   OuiType     [2]
+         *   OuiSubType  [0]
+         *   Version     [1]
+         */
+        struct ieee_types_vendor_header vend_hdr;
+        u8 qos_info_bitmap;
+} __packed;
+struct host_cmd_ds_wmm_get_status {
+        u8 queue_status_tlv[sizeof(struct mwifiex_ie_types_wmm_queue_status) *
+                              IEEE80211_MAX_QUEUES];
+        u8 wmm_param_tlv[sizeof(struct ieee_types_wmm_parameter) + 2];
+} __packed;
+struct mwifiex_wmm_ac_status {
+        u8 disabled;
+        u8 flow_required;
+        u8 flow_created;
+};
+struct mwifiex_ie_types_htcap {
+        struct mwifiex_ie_types_header header;
+        struct ieee80211_ht_cap ht_cap;
+} __packed;
+struct mwifiex_ie_types_htinfo {
+        struct mwifiex_ie_types_header header;
+        struct ieee80211_ht_info ht_info;
+} __packed;
+struct mwifiex_ie_types_2040bssco {
+        struct mwifiex_ie_types_header header;
+        u8 bss_co_2040;
+} __packed;
+struct mwifiex_ie_types_extcap {
+        struct mwifiex_ie_types_header header;
+        u8 ext_cap;
+} __packed;
+struct host_cmd_ds_mac_reg_access {
+        __le16 action;
+        __le16 offset;
+        __le32 value;
+} __packed;
+struct host_cmd_ds_bbp_reg_access {
+        __le16 action;
+        __le16 offset;
+        u8 value;
+        u8 reserved[3];
+} __packed;
+struct host_cmd_ds_rf_reg_access {
+        __le16 action;
+        __le16 offset;
+        u8 value;
+        u8 reserved[3];
+} __packed;
+struct host_cmd_ds_pmic_reg_access {
+        __le16 action;
+        __le16 offset;
+        u8 value;
+        u8 reserved[3];
+} __packed;
+struct host_cmd_ds_802_11_eeprom_access {
+        __le16 action;
+        __le16 offset;
+        __le16 byte_count;
+        u8 value;
+} __packed;
+struct host_cmd_ds_802_11_rf_channel {
+        __le16 action;
+        __le16 current_channel;
+        __le16 rf_type;
+        __le16 reserved;
+        u8 reserved_1[32];
+} __packed;
+struct host_cmd_ds_version_ext {
+        u8 version_str_sel;
+        char version_str[128];
+} __packed;
+struct host_cmd_ds_802_11_ibss_status {
+        __le16 action;
+        __le16 enable;
+        u8 bssid[ETH_ALEN];
+        __le16 beacon_interval;
+        __le16 atim_window;
+        __le16 use_g_rate_protect;
+} __packed;
+#define CONNECTION_TYPE_INFRA   0
+#define CONNECTION_TYPE_ADHOC   1
+struct host_cmd_ds_set_bss_mode {
+        u8 con_type;
+} __packed;
+struct host_cmd_ds_command {
+        __le16 command;
+        __le16 size;
+        __le16 seq_num;
+        __le16 result;
+        union {
+                struct host_cmd_ds_get_hw_spec hw_spec;
+                struct host_cmd_ds_mac_control mac_ctrl;
+                struct host_cmd_ds_802_11_mac_address mac_addr;
+                struct host_cmd_ds_mac_multicast_adr mc_addr;
+                struct host_cmd_ds_802_11_get_log get_log;
+                struct host_cmd_ds_802_11_rssi_info rssi_info;
+                struct host_cmd_ds_802_11_rssi_info_rsp rssi_info_rsp;
+                struct host_cmd_ds_802_11_snmp_mib smib;
+                struct host_cmd_ds_802_11_rf_channel rf_channel;
+                struct host_cmd_ds_tx_rate_query tx_rate;
+                struct host_cmd_ds_tx_rate_cfg tx_rate_cfg;
+                struct host_cmd_ds_txpwr_cfg txp_cfg;
+                struct host_cmd_ds_802_11_ps_mode_enh psmode_enh;
+                struct host_cmd_ds_802_11_hs_cfg_enh opt_hs_cfg;
+                struct host_cmd_ds_802_11_scan scan;
+                struct host_cmd_ds_802_11_scan_rsp scan_resp;
+                struct host_cmd_ds_802_11_bg_scan_query bg_scan_query;
+                struct host_cmd_ds_802_11_bg_scan_query_rsp bg_scan_query_resp;
+                struct host_cmd_ds_802_11_associate associate;
+                struct host_cmd_ds_802_11_associate_rsp associate_rsp;
+                struct host_cmd_ds_802_11_deauthenticate deauth;
+                struct host_cmd_ds_802_11_ad_hoc_start adhoc_start;
+                struct host_cmd_ds_802_11_ad_hoc_result adhoc_result;
+                struct host_cmd_ds_802_11_ad_hoc_join adhoc_join;
+                struct host_cmd_ds_802_11d_domain_info domain_info;
+                struct host_cmd_ds_802_11d_domain_info_rsp domain_info_resp;
+                struct host_cmd_ds_11n_addba_req add_ba_req;
+                struct host_cmd_ds_11n_addba_rsp add_ba_rsp;
+                struct host_cmd_ds_11n_delba del_ba;
+                struct host_cmd_ds_txbuf_cfg tx_buf;
+                struct host_cmd_ds_amsdu_aggr_ctrl amsdu_aggr_ctrl;
+                struct host_cmd_ds_11n_cfg htcfg;
+                struct host_cmd_ds_wmm_get_status get_wmm_status;
+                struct host_cmd_ds_802_11_key_material key_material;
+                struct host_cmd_ds_version_ext verext;
+                struct host_cmd_ds_802_11_ibss_status ibss_coalescing;
+                struct host_cmd_ds_mac_reg_access mac_reg;
+                struct host_cmd_ds_bbp_reg_access bbp_reg;
+                struct host_cmd_ds_rf_reg_access rf_reg;
+                struct host_cmd_ds_pmic_reg_access pmic_reg;
+                struct host_cmd_ds_set_bss_mode bss_mode;
+                struct host_cmd_ds_802_11_eeprom_access eeprom;
+        } params;
+} __packed;
+struct mwifiex_opt_sleep_confirm {
+        __le16 command;
+        __le16 size;
+        __le16 seq_num;
+        __le16 result;
+        __le16 action;
+        __le16 resp_ctrl;
+} __packed;
+#endif /* !_MWIFIEX_FW_H_ */
diff --git a/drivers/net/wireless/mwifiex/init.c b/drivers/net/wireless/mwifiex/init.c
new file mode 100644
index 000000000000..3f1559e61320
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/init.c
@@ -0,0 +1,645 @@
+/*
+ * Marvell Wireless LAN device driver: HW/FW Initialization
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+/*
+ * This function adds a BSS priority table to the table list.
+ *
+ * The function allocates a new BSS priority table node and adds it to
+ * the end of BSS priority table list, kept in driver memory.
+ */
+static int mwifiex_add_bss_prio_tbl(struct mwifiex_private *priv)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_bss_prio_node *bss_prio;
+        unsigned long flags;
+        bss_prio = kzalloc(sizeof(struct mwifiex_bss_prio_node), GFP_KERNEL);
+        if (!bss_prio) {
+                dev_err(adapter->dev, "%s: failed to alloc bss_prio\n",
+                                                __func__);
+                return -ENOMEM;
+        }
+        bss_prio->priv = priv;
+        INIT_LIST_HEAD(&bss_prio->list);
+        if (!adapter->bss_prio_tbl[priv->bss_priority].bss_prio_cur)
+                adapter->bss_prio_tbl[priv->bss_priority].bss_prio_cur =
+                        bss_prio;
+        spin_lock_irqsave(&adapter->bss_prio_tbl[priv->bss_priority]
+                        .bss_prio_lock, flags);
+        list_add_tail(&bss_prio->list,
+                        &adapter->bss_prio_tbl[priv->bss_priority]
+                        .bss_prio_head);
+        spin_unlock_irqrestore(&adapter->bss_prio_tbl[priv->bss_priority]
+                        .bss_prio_lock, flags);
+        return 0;
+}
+/*
+ * This function initializes the private structure and sets default
+ * values to the members.
+ *
+ * Additionally, it also initializes all the locks and sets up all the
+ * lists.
+ */
+static int mwifiex_init_priv(struct mwifiex_private *priv)
+{
+        u32 i;
+        priv->media_connected = false;
+        memset(priv->curr_addr, 0xff, ETH_ALEN);
+        priv->pkt_tx_ctrl = 0;
+        priv->bss_mode = NL80211_IFTYPE_STATION;
+        priv->data_rate = 0;    /* Initially indicate the rate as auto */
+        priv->is_data_rate_auto = true;
+        priv->bcn_avg_factor = DEFAULT_BCN_AVG_FACTOR;
+        priv->data_avg_factor = DEFAULT_DATA_AVG_FACTOR;
+        priv->sec_info.wep_status = MWIFIEX_802_11_WEP_DISABLED;
+        priv->sec_info.authentication_mode = NL80211_AUTHTYPE_OPEN_SYSTEM;
+        priv->sec_info.encryption_mode = 0;
+        for (i = 0; i < ARRAY_SIZE(priv->wep_key); i++)
+                memset(&priv->wep_key[i], 0, sizeof(struct mwifiex_wep_key));
+        priv->wep_key_curr_index = 0;
+        priv->curr_pkt_filter = HostCmd_ACT_MAC_RX_ON | HostCmd_ACT_MAC_TX_ON |
+                                HostCmd_ACT_MAC_ETHERNETII_ENABLE;
+        priv->beacon_period = 100; /* beacon interval */ ;
+        priv->attempted_bss_desc = NULL;
+        memset(&priv->curr_bss_params, 0, sizeof(priv->curr_bss_params));
+        priv->listen_interval = MWIFIEX_DEFAULT_LISTEN_INTERVAL;
+        memset(&priv->prev_ssid, 0, sizeof(priv->prev_ssid));
+        memset(&priv->prev_bssid, 0, sizeof(priv->prev_bssid));
+        memset(&priv->assoc_rsp_buf, 0, sizeof(priv->assoc_rsp_buf));
+        priv->assoc_rsp_size = 0;
+        priv->adhoc_channel = DEFAULT_AD_HOC_CHANNEL;
+        priv->atim_window = 0;
+        priv->adhoc_state = ADHOC_IDLE;
+        priv->tx_power_level = 0;
+        priv->max_tx_power_level = 0;
+        priv->min_tx_power_level = 0;
+        priv->tx_rate = 0;
+        priv->rxpd_htinfo = 0;
+        priv->rxpd_rate = 0;
+        priv->rate_bitmap = 0;
+        priv->data_rssi_last = 0;
+        priv->data_rssi_avg = 0;
+        priv->data_nf_avg = 0;
+        priv->data_nf_last = 0;
+        priv->bcn_rssi_last = 0;
+        priv->bcn_rssi_avg = 0;
+        priv->bcn_nf_avg = 0;
+        priv->bcn_nf_last = 0;
+        memset(&priv->wpa_ie, 0, sizeof(priv->wpa_ie));
+        memset(&priv->aes_key, 0, sizeof(priv->aes_key));
+        priv->wpa_ie_len = 0;
+        priv->wpa_is_gtk_set = false;
+        memset(&priv->assoc_tlv_buf, 0, sizeof(priv->assoc_tlv_buf));
+        priv->assoc_tlv_buf_len = 0;
+        memset(&priv->wps, 0, sizeof(priv->wps));
+        memset(&priv->gen_ie_buf, 0, sizeof(priv->gen_ie_buf));
+        priv->gen_ie_buf_len = 0;
+        memset(priv->vs_ie, 0, sizeof(priv->vs_ie));
+        priv->wmm_required = true;
+        priv->wmm_enabled = false;
+        priv->wmm_qosinfo = 0;
+        priv->curr_bcn_buf = NULL;
+        priv->curr_bcn_size = 0;
+        priv->scan_block = false;
+        return mwifiex_add_bss_prio_tbl(priv);
+}
+/*
+ * This function allocates buffers for members of the adapter
+ * structure.
+ *
+ * The memory allocated includes scan table, command buffers, and
+ * sleep confirm command buffer. In addition, the queues are
+ * also initialized.
+ */
+static int mwifiex_allocate_adapter(struct mwifiex_adapter *adapter)
+{
+        int ret;
+        u32 buf_size;
+        struct mwifiex_bssdescriptor *temp_scan_table;
+        /* Allocate buffer to store the BSSID list */
+        buf_size = sizeof(struct mwifiex_bssdescriptor) * IW_MAX_AP;
+        temp_scan_table = kzalloc(buf_size, GFP_KERNEL);
+        if (!temp_scan_table) {
+                dev_err(adapter->dev, "%s: failed to alloc temp_scan_table\n",
+                       __func__);
+                return -ENOMEM;
+        }
+        adapter->scan_table = temp_scan_table;
+        /* Allocate command buffer */
+        ret = mwifiex_alloc_cmd_buffer(adapter);
+        if (ret) {
+                dev_err(adapter->dev, "%s: failed to alloc cmd buffer\n",
+                       __func__);
+                return -1;
+        }
+        adapter->sleep_cfm =
+                dev_alloc_skb(sizeof(struct mwifiex_opt_sleep_confirm)
+                                + INTF_HEADER_LEN);
+        if (!adapter->sleep_cfm) {
+                dev_err(adapter->dev, "%s: failed to alloc sleep cfm"
+                        " cmd buffer\n", __func__);
+                return -1;
+        }
+        skb_reserve(adapter->sleep_cfm, INTF_HEADER_LEN);
+        return 0;
+}
+/*
+ * This function initializes the adapter structure and sets default
+ * values to the members of adapter.
+ *
+ * This also initializes the WMM related parameters in the driver private
+ * structures.
+ */
+static void mwifiex_init_adapter(struct mwifiex_adapter *adapter)
+{
+        struct mwifiex_opt_sleep_confirm *sleep_cfm_buf = NULL;
+        skb_put(adapter->sleep_cfm, sizeof(struct mwifiex_opt_sleep_confirm));
+        sleep_cfm_buf = (struct mwifiex_opt_sleep_confirm *)
+                                                (adapter->sleep_cfm->data);
+        adapter->cmd_sent = false;
+        adapter->data_sent = true;
+        adapter->cmd_resp_received = false;
+        adapter->event_received = false;
+        adapter->data_received = false;
+        adapter->surprise_removed = false;
+        adapter->hw_status = MWIFIEX_HW_STATUS_INITIALIZING;
+        adapter->ps_mode = MWIFIEX_802_11_POWER_MODE_CAM;
+        adapter->ps_state = PS_STATE_AWAKE;
+        adapter->need_to_wakeup = false;
+        adapter->scan_mode = HostCmd_BSS_MODE_ANY;
+        adapter->specific_scan_time = MWIFIEX_SPECIFIC_SCAN_CHAN_TIME;
+        adapter->active_scan_time = MWIFIEX_ACTIVE_SCAN_CHAN_TIME;
+        adapter->passive_scan_time = MWIFIEX_PASSIVE_SCAN_CHAN_TIME;
+        adapter->num_in_scan_table = 0;
+        memset(adapter->scan_table, 0,
+               (sizeof(struct mwifiex_bssdescriptor) * IW_MAX_AP));
+        adapter->scan_probes = 1;
+        memset(adapter->bcn_buf, 0, sizeof(adapter->bcn_buf));
+        adapter->bcn_buf_end = adapter->bcn_buf;
+        adapter->multiple_dtim = 1;
+        adapter->local_listen_interval = 0;     /* default value in firmware
+                                                   will be used */
+        adapter->is_deep_sleep = false;
+        adapter->delay_null_pkt = false;
+        adapter->delay_to_ps = 1000;
+        adapter->enhanced_ps_mode = PS_MODE_AUTO;
+        adapter->gen_null_pkt = false;  /* Disable NULL Pkg generation by
+                                           default */
+        adapter->pps_uapsd_mode = false; /* Disable pps/uapsd mode by
+                                           default */
+        adapter->pm_wakeup_card_req = false;
+        adapter->pm_wakeup_fw_try = false;
+        adapter->max_tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_2K;
+        adapter->tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_2K;
+        adapter->curr_tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_2K;
+        adapter->is_hs_configured = false;
+        adapter->hs_cfg.conditions = cpu_to_le32(HOST_SLEEP_CFG_COND_DEF);
+        adapter->hs_cfg.gpio = HOST_SLEEP_CFG_GPIO_DEF;
+        adapter->hs_cfg.gap = HOST_SLEEP_CFG_GAP_DEF;
+        adapter->hs_activated = false;
+        memset(adapter->event_body, 0, sizeof(adapter->event_body));
+        adapter->hw_dot_11n_dev_cap = 0;
+        adapter->hw_dev_mcs_support = 0;
+        adapter->chan_offset = 0;
+        adapter->adhoc_11n_enabled = false;
+        mwifiex_wmm_init(adapter);
+        if (adapter->sleep_cfm) {
+                memset(sleep_cfm_buf, 0, adapter->sleep_cfm->len);
+                sleep_cfm_buf->command =
+                                cpu_to_le16(HostCmd_CMD_802_11_PS_MODE_ENH);
+                sleep_cfm_buf->size =
+                                cpu_to_le16(adapter->sleep_cfm->len);
+                sleep_cfm_buf->result = 0;
+                sleep_cfm_buf->action = cpu_to_le16(SLEEP_CONFIRM);
+                sleep_cfm_buf->resp_ctrl = cpu_to_le16(RESP_NEEDED);
+        }
+        memset(&adapter->sleep_params, 0, sizeof(adapter->sleep_params));
+        memset(&adapter->sleep_period, 0, sizeof(adapter->sleep_period));
+        adapter->tx_lock_flag = false;
+        adapter->null_pkt_interval = 0;
+        adapter->fw_bands = 0;
+        adapter->config_bands = 0;
+        adapter->adhoc_start_band = 0;
+        adapter->scan_channels = NULL;
+        adapter->fw_release_number = 0;
+        adapter->fw_cap_info = 0;
+        memset(&adapter->upld_buf, 0, sizeof(adapter->upld_buf));
+        adapter->event_cause = 0;
+        adapter->region_code = 0;
+        adapter->bcn_miss_time_out = DEFAULT_BCN_MISS_TIMEOUT;
+        adapter->adhoc_awake_period = 0;
+        memset(&adapter->arp_filter, 0, sizeof(adapter->arp_filter));
+        adapter->arp_filter_size = 0;
+}
+/*
+ * This function frees the adapter structure.
+ *
+ * The freeing operation is done recursively, by canceling all
+ * pending commands, freeing the member buffers previously
+ * allocated (command buffers, scan table buffer, sleep confirm
+ * command buffer), stopping the timers and calling the cleanup
+ * routines for every interface, before the actual adapter
+ * structure is freed.
+ */
+static void
+mwifiex_free_adapter(struct mwifiex_adapter *adapter)
+{
+        if (!adapter) {
+                pr_err("%s: adapter is NULL\n", __func__);
+                return;
+        }
+        mwifiex_cancel_all_pending_cmd(adapter);
+        /* Free lock variables */
+        mwifiex_free_lock_list(adapter);
+        /* Free command buffer */
+        dev_dbg(adapter->dev, "info: free cmd buffer\n");
+        mwifiex_free_cmd_buffer(adapter);
+        del_timer(&adapter->cmd_timer);
+        dev_dbg(adapter->dev, "info: free scan table\n");
+        kfree(adapter->scan_table);
+        adapter->scan_table = NULL;
+        adapter->if_ops.cleanup_if(adapter);
+        dev_kfree_skb_any(adapter->sleep_cfm);
+}
+/*
+ *  This function intializes the lock variables and
+ *  the list heads.
+ */
+int mwifiex_init_lock_list(struct mwifiex_adapter *adapter)
+{
+        struct mwifiex_private *priv;
+        s32 i, j;
+        spin_lock_init(&adapter->mwifiex_lock);
+        spin_lock_init(&adapter->int_lock);
+        spin_lock_init(&adapter->main_proc_lock);
+        spin_lock_init(&adapter->mwifiex_cmd_lock);
+        for (i = 0; i < adapter->priv_num; i++) {
+                if (adapter->priv[i]) {
+                        priv = adapter->priv[i];
+                        spin_lock_init(&priv->rx_pkt_lock);
+                        spin_lock_init(&priv->wmm.ra_list_spinlock);
+                        spin_lock_init(&priv->curr_bcn_buf_lock);
+                }
+        }
+        /* Initialize cmd_free_q */
+        INIT_LIST_HEAD(&adapter->cmd_free_q);
+        /* Initialize cmd_pending_q */
+        INIT_LIST_HEAD(&adapter->cmd_pending_q);
+        /* Initialize scan_pending_q */
+        INIT_LIST_HEAD(&adapter->scan_pending_q);
+        spin_lock_init(&adapter->cmd_free_q_lock);
+        spin_lock_init(&adapter->cmd_pending_q_lock);
+        spin_lock_init(&adapter->scan_pending_q_lock);
+        for (i = 0; i < adapter->priv_num; ++i) {
+                INIT_LIST_HEAD(&adapter->bss_prio_tbl[i].bss_prio_head);
+                adapter->bss_prio_tbl[i].bss_prio_cur = NULL;
+                spin_lock_init(&adapter->bss_prio_tbl[i].bss_prio_lock);
+        }
+        for (i = 0; i < adapter->priv_num; i++) {
+                if (!adapter->priv[i])
+                        continue;
+                priv = adapter->priv[i];
+                for (j = 0; j < MAX_NUM_TID; ++j) {
+                        INIT_LIST_HEAD(&priv->wmm.tid_tbl_ptr[j].ra_list);
+                        spin_lock_init(&priv->wmm.tid_tbl_ptr[j].tid_tbl_lock);
+                }
+                INIT_LIST_HEAD(&priv->tx_ba_stream_tbl_ptr);
+                INIT_LIST_HEAD(&priv->rx_reorder_tbl_ptr);
+                spin_lock_init(&priv->tx_ba_stream_tbl_lock);
+                spin_lock_init(&priv->rx_reorder_tbl_lock);
+        }
+        return 0;
+}
+/*
+ *  This function releases the lock variables and frees the locks and
+ *  associated locks.
+ */
+void mwifiex_free_lock_list(struct mwifiex_adapter *adapter)
+{
+        struct mwifiex_private *priv;
+        s32 i, j;
+        /* Free lists */
+        list_del(&adapter->cmd_free_q);
+        list_del(&adapter->cmd_pending_q);
+        list_del(&adapter->scan_pending_q);
+        for (i = 0; i < adapter->priv_num; i++)
+                list_del(&adapter->bss_prio_tbl[i].bss_prio_head);
+        for (i = 0; i < adapter->priv_num; i++) {
+                if (adapter->priv[i]) {
+                        priv = adapter->priv[i];
+                        for (j = 0; j < MAX_NUM_TID; ++j)
+                                list_del(&priv->wmm.tid_tbl_ptr[j].ra_list);
+                        list_del(&priv->tx_ba_stream_tbl_ptr);
+                        list_del(&priv->rx_reorder_tbl_ptr);
+                }
+        }
+}
+/*
+ * This function initializes the firmware.
+ *
+ * The following operations are performed sequentially -
+ *      - Allocate adapter structure
+ *      - Initialize the adapter structure
+ *      - Initialize the private structure
+ *      - Add BSS priority tables to the adapter structure
+ *      - For each interface, send the init commands to firmware
+ *      - Send the first command in command pending queue, if available
+ */
+int mwifiex_init_fw(struct mwifiex_adapter *adapter)
+{
+        int ret;
+        struct mwifiex_private *priv;
+        u8 i, first_sta = true;
+        int is_cmd_pend_q_empty;
+        unsigned long flags;
+        adapter->hw_status = MWIFIEX_HW_STATUS_INITIALIZING;
+        /* Allocate memory for member of adapter structure */
+        ret = mwifiex_allocate_adapter(adapter);
+        if (ret)
+                return -1;
+        /* Initialize adapter structure */
+        mwifiex_init_adapter(adapter);
+        for (i = 0; i < adapter->priv_num; i++) {
+                if (adapter->priv[i]) {
+                        priv = adapter->priv[i];
+                        /* Initialize private structure */
+                        ret = mwifiex_init_priv(priv);
+                        if (ret)
+                                return -1;
+                }
+        }
+        for (i = 0; i < adapter->priv_num; i++) {
+                if (adapter->priv[i]) {
+                        ret = mwifiex_sta_init_cmd(adapter->priv[i], first_sta);
+                        if (ret == -1)
+                                return -1;
+                        first_sta = false;
+                }
+        }
+        spin_lock_irqsave(&adapter->cmd_pending_q_lock, flags);
+        is_cmd_pend_q_empty = list_empty(&adapter->cmd_pending_q);
+        spin_unlock_irqrestore(&adapter->cmd_pending_q_lock, flags);
+        if (!is_cmd_pend_q_empty) {
+                /* Send the first command in queue and return */
+                if (mwifiex_main_process(adapter) != -1)
+                        ret = -EINPROGRESS;
+        } else {
+                adapter->hw_status = MWIFIEX_HW_STATUS_READY;
+        }
+        return ret;
+}
+/*
+ * This function deletes the BSS priority tables.
+ *
+ * The function traverses through all the allocated BSS priority nodes
+ * in every BSS priority table and frees them.
+ */
+static void mwifiex_delete_bss_prio_tbl(struct mwifiex_private *priv)
+{
+        int i;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_bss_prio_node *bssprio_node, *tmp_node, **cur;
+        struct list_head *head;
+        spinlock_t *lock;
+        unsigned long flags;
+        for (i = 0; i < adapter->priv_num; ++i) {
+                head = &adapter->bss_prio_tbl[i].bss_prio_head;
+                cur = &adapter->bss_prio_tbl[i].bss_prio_cur;
+                lock = &adapter->bss_prio_tbl[i].bss_prio_lock;
+                dev_dbg(adapter->dev, "info: delete BSS priority table,"
+                                " index = %d, i = %d, head = %p, cur = %p\n",
+                              priv->bss_index, i, head, *cur);
+                if (*cur) {
+                        spin_lock_irqsave(lock, flags);
+                        if (list_empty(head)) {
+                                spin_unlock_irqrestore(lock, flags);
+                                continue;
+                        }
+                        bssprio_node = list_first_entry(head,
+                                        struct mwifiex_bss_prio_node, list);
+                        spin_unlock_irqrestore(lock, flags);
+                        list_for_each_entry_safe(bssprio_node, tmp_node, head,
+                                                 list) {
+                                if (bssprio_node->priv == priv) {
+                                        dev_dbg(adapter->dev, "info: Delete "
+                                                "node %p, next = %p\n",
+                                                bssprio_node, tmp_node);
+                                        spin_lock_irqsave(lock, flags);
+                                        list_del(&bssprio_node->list);
+                                        spin_unlock_irqrestore(lock, flags);
+                                        kfree(bssprio_node);
+                                }
+                        }
+                        *cur = (struct mwifiex_bss_prio_node *)head;
+                }
+        }
+}
+/*
+ * This function is used to shutdown the driver.
+ *
+ * The following operations are performed sequentially -
+ *      - Check if already shut down
+ *      - Make sure the main process has stopped
+ *      - Clean up the Tx and Rx queues
+ *      - Delete BSS priority tables
+ *      - Free the adapter
+ *      - Notify completion
+ */
+int
+mwifiex_shutdown_drv(struct mwifiex_adapter *adapter)
+{
+        int ret = -EINPROGRESS;
+        struct mwifiex_private *priv;
+        s32 i;
+        unsigned long flags;
+        /* mwifiex already shutdown */
+        if (adapter->hw_status == MWIFIEX_HW_STATUS_NOT_READY)
+                return 0;
+        adapter->hw_status = MWIFIEX_HW_STATUS_CLOSING;
+        /* wait for mwifiex_process to complete */
+        if (adapter->mwifiex_processing) {
+                dev_warn(adapter->dev, "main process is still running\n");
+                return ret;
+        }
+        /* shut down mwifiex */
+        dev_dbg(adapter->dev, "info: shutdown mwifiex...\n");
+        /* Clean up Tx/Rx queues and delete BSS priority table */
+        for (i = 0; i < adapter->priv_num; i++) {
+                if (adapter->priv[i]) {
+                        priv = adapter->priv[i];
+                        mwifiex_clean_txrx(priv);
+                        mwifiex_delete_bss_prio_tbl(priv);
+                }
+        }
+        spin_lock_irqsave(&adapter->mwifiex_lock, flags);
+        /* Free adapter structure */
+        mwifiex_free_adapter(adapter);
+        spin_unlock_irqrestore(&adapter->mwifiex_lock, flags);
+        /* Notify completion */
+        ret = mwifiex_shutdown_fw_complete(adapter);
+        return ret;
+}
+/*
+ * This function downloads the firmware to the card.
+ *
+ * The actual download is preceded by two sanity checks -
+ *      - Check if firmware is already running
+ *      - Check if the interface is the winner to download the firmware
+ *
+ * ...and followed by another -
+ *      - Check if the firmware is downloaded successfully
+ *
+ * After download is successfully completed, the host interrupts are enabled.
+ */
+int mwifiex_dnld_fw(struct mwifiex_adapter *adapter,
+                    struct mwifiex_fw_image *pmfw)
+{
+        int ret, winner;
+        u32 poll_num = 1;
+        /* Check if firmware is already running */
+        ret = adapter->if_ops.check_fw_status(adapter, poll_num, &winner);
+        if (!ret) {
+                dev_notice(adapter->dev,
+                                "WLAN FW already running! Skip FW download\n");
+                goto done;
+        }
+        poll_num = MAX_FIRMWARE_POLL_TRIES;
+        /* Check if we are the winner for downloading FW */
+        if (!winner) {
+                dev_notice(adapter->dev,
+                                "Other interface already running!"
+                                " Skip FW download\n");
+                poll_num = MAX_MULTI_INTERFACE_POLL_TRIES;
+                goto poll_fw;
+        }
+        if (pmfw) {
+                /* Download firmware with helper */
+                ret = adapter->if_ops.prog_fw(adapter, pmfw);
+                if (ret) {
+                        dev_err(adapter->dev, "prog_fw failed ret=%#x\n", ret);
+                        return ret;
+                }
+        }
+poll_fw:
+        /* Check if the firmware is downloaded successfully or not */
+        ret = adapter->if_ops.check_fw_status(adapter, poll_num, NULL);
+        if (ret) {
+                dev_err(adapter->dev, "FW failed to be active in time\n");
+                return -1;
+        }
+done:
+        /* re-enable host interrupt for mwifiex after fw dnld is successful */
+        adapter->if_ops.enable_int(adapter);
+        return ret;
+}
diff --git a/drivers/net/wireless/mwifiex/ioctl.h b/drivers/net/wireless/mwifiex/ioctl.h
new file mode 100644
index 000000000000..7c1c5ee40eb9
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/ioctl.h
@@ -0,0 +1,331 @@
+/*
+ * Marvell Wireless LAN device driver: ioctl data structures & APIs
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef _MWIFIEX_IOCTL_H_
+#define _MWIFIEX_IOCTL_H_
+#include <net/mac80211.h>
+enum {
+        MWIFIEX_SCAN_TYPE_UNCHANGED = 0,
+        MWIFIEX_SCAN_TYPE_ACTIVE,
+        MWIFIEX_SCAN_TYPE_PASSIVE
+};
+struct mwifiex_user_scan {
+        u32 scan_cfg_len;
+        u8 scan_cfg_buf[1];
+};
+#define MWIFIEX_PROMISC_MODE            1
+#define MWIFIEX_MULTICAST_MODE          2
+#define MWIFIEX_ALL_MULTI_MODE          4
+#define MWIFIEX_MAX_MULTICAST_LIST_SIZE 32
+struct mwifiex_multicast_list {
+        u32 mode;
+        u32 num_multicast_addr;
+        u8 mac_list[MWIFIEX_MAX_MULTICAST_LIST_SIZE][ETH_ALEN];
+};
+struct mwifiex_chan_freq {
+        u32 channel;
+        u32 freq;
+};
+struct mwifiex_ssid_bssid {
+        struct mwifiex_802_11_ssid ssid;
+        u8 bssid[ETH_ALEN];
+};
+enum {
+        BAND_B = 1,
+        BAND_G = 2,
+        BAND_A = 4,
+        BAND_GN = 8,
+        BAND_AN = 16,
+};
+#define NO_SEC_CHANNEL               0
+#define SEC_CHANNEL_ABOVE            1
+#define SEC_CHANNEL_BELOW            3
+struct mwifiex_ds_band_cfg {
+        u32 config_bands;
+        u32 adhoc_start_band;
+        u32 adhoc_channel;
+        u32 sec_chan_offset;
+};
+enum {
+        ADHOC_IDLE,
+        ADHOC_STARTED,
+        ADHOC_JOINED,
+        ADHOC_COALESCED
+};
+struct mwifiex_ds_get_stats {
+        u32 mcast_tx_frame;
+        u32 failed;
+        u32 retry;
+        u32 multi_retry;
+        u32 frame_dup;
+        u32 rts_success;
+        u32 rts_failure;
+        u32 ack_failure;
+        u32 rx_frag;
+        u32 mcast_rx_frame;
+        u32 fcs_error;
+        u32 tx_frame;
+        u32 wep_icv_error[4];
+};
+#define BCN_RSSI_AVG_MASK               0x00000002
+#define BCN_NF_AVG_MASK                 0x00000200
+#define ALL_RSSI_INFO_MASK              0x00000fff
+struct mwifiex_ds_get_signal {
+        /*
+         * Bit0:  Last Beacon RSSI,  Bit1:  Average Beacon RSSI,
+         * Bit2:  Last Data RSSI,    Bit3:  Average Data RSSI,
+         * Bit4:  Last Beacon SNR,   Bit5:  Average Beacon SNR,
+         * Bit6:  Last Data SNR,     Bit7:  Average Data SNR,
+         * Bit8:  Last Beacon NF,    Bit9:  Average Beacon NF,
+         * Bit10: Last Data NF,      Bit11: Average Data NF
+         */
+        u16 selector;
+        s16 bcn_rssi_last;
+        s16 bcn_rssi_avg;
+        s16 data_rssi_last;
+        s16 data_rssi_avg;
+        s16 bcn_snr_last;
+        s16 bcn_snr_avg;
+        s16 data_snr_last;
+        s16 data_snr_avg;
+        s16 bcn_nf_last;
+        s16 bcn_nf_avg;
+        s16 data_nf_last;
+        s16 data_nf_avg;
+};
+#define MWIFIEX_MAX_VER_STR_LEN    128
+struct mwifiex_ver_ext {
+        u32 version_str_sel;
+        char version_str[MWIFIEX_MAX_VER_STR_LEN];
+};
+struct mwifiex_bss_info {
+        u32 bss_mode;
+        struct mwifiex_802_11_ssid ssid;
+        u32 scan_table_idx;
+        u32 bss_chan;
+        u32 region_code;
+        u32 media_connected;
+        u32 max_power_level;
+        u32 min_power_level;
+        u32 adhoc_state;
+        signed int bcn_nf_last;
+        u32 wep_status;
+        u32 is_hs_configured;
+        u32 is_deep_sleep;
+        u8 bssid[ETH_ALEN];
+};
+#define MAX_NUM_TID     8
+#define MAX_RX_WINSIZE  64
+struct mwifiex_ds_rx_reorder_tbl {
+        u16 tid;
+        u8 ta[ETH_ALEN];
+        u32 start_win;
+        u32 win_size;
+        u32 buffer[MAX_RX_WINSIZE];
+};
+struct mwifiex_ds_tx_ba_stream_tbl {
+        u16 tid;
+        u8 ra[ETH_ALEN];
+};
+#define DBG_CMD_NUM     5
+struct mwifiex_debug_info {
+        u32 int_counter;
+        u32 packets_out[MAX_NUM_TID];
+        u32 max_tx_buf_size;
+        u32 tx_buf_size;
+        u32 curr_tx_buf_size;
+        u32 tx_tbl_num;
+        struct mwifiex_ds_tx_ba_stream_tbl
+                tx_tbl[MWIFIEX_MAX_TX_BASTREAM_SUPPORTED];
+        u32 rx_tbl_num;
+        struct mwifiex_ds_rx_reorder_tbl rx_tbl
+                [MWIFIEX_MAX_RX_BASTREAM_SUPPORTED];
+        u16 ps_mode;
+        u32 ps_state;
+        u8 is_deep_sleep;
+        u8 pm_wakeup_card_req;
+        u32 pm_wakeup_fw_try;
+        u8 is_hs_configured;
+        u8 hs_activated;
+        u32 num_cmd_host_to_card_failure;
+        u32 num_cmd_sleep_cfm_host_to_card_failure;
+        u32 num_tx_host_to_card_failure;
+        u32 num_event_deauth;
+        u32 num_event_disassoc;
+        u32 num_event_link_lost;
+        u32 num_cmd_deauth;
+        u32 num_cmd_assoc_success;
+        u32 num_cmd_assoc_failure;
+        u32 num_tx_timeout;
+        u32 num_cmd_timeout;
+        u16 timeout_cmd_id;
+        u16 timeout_cmd_act;
+        u16 last_cmd_id[DBG_CMD_NUM];
+        u16 last_cmd_act[DBG_CMD_NUM];
+        u16 last_cmd_index;
+        u16 last_cmd_resp_id[DBG_CMD_NUM];
+        u16 last_cmd_resp_index;
+        u16 last_event[DBG_CMD_NUM];
+        u16 last_event_index;
+        u8 data_sent;
+        u8 cmd_sent;
+        u8 cmd_resp_received;
+        u8 event_received;
+};
+#define MWIFIEX_KEY_INDEX_UNICAST       0x40000000
+#define WAPI_RXPN_LEN                   16
+struct mwifiex_ds_encrypt_key {
+        u32 key_disable;
+        u32 key_index;
+        u32 key_len;
+        u8 key_material[WLAN_MAX_KEY_LEN];
+        u8 mac_addr[ETH_ALEN];
+        u32 is_wapi_key;
+        u8 wapi_rxpn[WAPI_RXPN_LEN];
+};
+struct mwifiex_rate_cfg {
+        u32 action;
+        u32 is_rate_auto;
+        u32 rate;
+};
+struct mwifiex_power_cfg {
+        u32 is_power_auto;
+        u32 power_level;
+};
+struct mwifiex_ds_hs_cfg {
+        u32 is_invoke_hostcmd;
+        /*  Bit0: non-unicast data
+         *  Bit1: unicast data
+         *  Bit2: mac events
+         *  Bit3: magic packet
+         */
+        u32 conditions;
+        u32 gpio;
+        u32 gap;
+};
+#define DEEP_SLEEP_ON  1
+#define DEEP_SLEEP_IDLE_TIME    100
+#define PS_MODE_AUTO            1
+struct mwifiex_ds_auto_ds {
+        u16 auto_ds;
+        u16 idle_time;
+};
+struct mwifiex_ds_pm_cfg {
+        union {
+                u32 ps_mode;
+                struct mwifiex_ds_hs_cfg hs_cfg;
+                struct mwifiex_ds_auto_ds auto_deep_sleep;
+                u32 sleep_period;
+        } param;
+};
+struct mwifiex_ds_11n_tx_cfg {
+        u16 tx_htcap;
+        u16 tx_htinfo;
+};
+struct mwifiex_ds_11n_amsdu_aggr_ctrl {
+        u16 enable;
+        u16 curr_buf_size;
+};
+#define MWIFIEX_NUM_OF_CMD_BUFFER       20
+#define MWIFIEX_SIZE_OF_CMD_BUFFER      2048
+enum {
+        MWIFIEX_IE_TYPE_GEN_IE = 0,
+        MWIFIEX_IE_TYPE_ARP_FILTER,
+};
+enum {
+        MWIFIEX_REG_MAC = 1,
+        MWIFIEX_REG_BBP,
+        MWIFIEX_REG_RF,
+        MWIFIEX_REG_PMIC,
+        MWIFIEX_REG_CAU,
+};
+struct mwifiex_ds_reg_rw {
+        __le32 type;
+        __le32 offset;
+        __le32 value;
+};
+#define MAX_EEPROM_DATA 256
+struct mwifiex_ds_read_eeprom {
+        __le16 offset;
+        __le16 byte_count;
+        u8 value[MAX_EEPROM_DATA];
+};
+struct mwifiex_ds_misc_gen_ie {
+        u32 type;
+        u32 len;
+        u8 ie_data[IW_CUSTOM_MAX];
+};
+struct mwifiex_ds_misc_cmd {
+        u32 len;
+        u8 cmd[MWIFIEX_SIZE_OF_CMD_BUFFER];
+};
+#define MWIFIEX_MAX_VSIE_LEN       (256)
+#define MWIFIEX_MAX_VSIE_NUM       (8)
+#define MWIFIEX_VSIE_MASK_SCAN     0x01
+#define MWIFIEX_VSIE_MASK_ASSOC    0x02
+#define MWIFIEX_VSIE_MASK_ADHOC    0x04
+enum {
+        MWIFIEX_FUNC_INIT = 1,
+        MWIFIEX_FUNC_SHUTDOWN,
+};
+#endif /* !_MWIFIEX_IOCTL_H_ */
diff --git a/drivers/net/wireless/mwifiex/join.c b/drivers/net/wireless/mwifiex/join.c
new file mode 100644
index 000000000000..5eab3dc29b1c
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/join.c
@@ -0,0 +1,1423 @@
+/*
+ * Marvell Wireless LAN device driver: association and ad-hoc start/join
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+#define CAPINFO_MASK    (~(BIT(15) | BIT(14) | BIT(12) | BIT(11) | BIT(9)))
+/*
+ * Append a generic IE as a pass through TLV to a TLV buffer.
+ *
+ * This function is called from the network join command preparation routine.
+ *
+ * If the IE buffer has been setup by the application, this routine appends
+ * the buffer as a pass through TLV type to the request.
+ */
+static int
+mwifiex_cmd_append_generic_ie(struct mwifiex_private *priv, u8 **buffer)
+{
+        int ret_len = 0;
+        struct mwifiex_ie_types_header ie_header;
+        /* Null Checks */
+        if (!buffer)
+                return 0;
+        if (!(*buffer))
+                return 0;
+        /*
+         * If there is a generic ie buffer setup, append it to the return
+         *   parameter buffer pointer.
+         */
+        if (priv->gen_ie_buf_len) {
+                dev_dbg(priv->adapter->dev, "info: %s: append generic %d to %p\n",
+                                __func__, priv->gen_ie_buf_len, *buffer);
+                /* Wrap the generic IE buffer with a pass through TLV type */
+                ie_header.type = cpu_to_le16(TLV_TYPE_PASSTHROUGH);
+                ie_header.len = cpu_to_le16(priv->gen_ie_buf_len);
+                memcpy(*buffer, &ie_header, sizeof(ie_header));
+                /* Increment the return size and the return buffer pointer
+                   param */
+                *buffer += sizeof(ie_header);
+                ret_len += sizeof(ie_header);
+                /* Copy the generic IE buffer to the output buffer, advance
+                   pointer */
+                memcpy(*buffer, priv->gen_ie_buf, priv->gen_ie_buf_len);
+                /* Increment the return size and the return buffer pointer
+                   param */
+                *buffer += priv->gen_ie_buf_len;
+                ret_len += priv->gen_ie_buf_len;
+                /* Reset the generic IE buffer */
+                priv->gen_ie_buf_len = 0;
+        }
+        /* return the length appended to the buffer */
+        return ret_len;
+}
+/*
+ * Append TSF tracking info from the scan table for the target AP.
+ *
+ * This function is called from the network join command preparation routine.
+ *
+ * The TSF table TSF sent to the firmware contains two TSF values:
+ *      - The TSF of the target AP from its previous beacon/probe response
+ *      - The TSF timestamp of our local MAC at the time we observed the
+ *        beacon/probe response.
+ *
+ * The firmware uses the timestamp values to set an initial TSF value
+ * in the MAC for the new association after a reassociation attempt.
+ */
+static int
+mwifiex_cmd_append_tsf_tlv(struct mwifiex_private *priv, u8 **buffer,
+                           struct mwifiex_bssdescriptor *bss_desc)
+{
+        struct mwifiex_ie_types_tsf_timestamp tsf_tlv;
+        __le64 tsf_val;
+        /* Null Checks */
+        if (buffer == NULL)
+                return 0;
+        if (*buffer == NULL)
+                return 0;
+        memset(&tsf_tlv, 0x00, sizeof(struct mwifiex_ie_types_tsf_timestamp));
+        tsf_tlv.header.type = cpu_to_le16(TLV_TYPE_TSFTIMESTAMP);
+        tsf_tlv.header.len = cpu_to_le16(2 * sizeof(tsf_val));
+        memcpy(*buffer, &tsf_tlv, sizeof(tsf_tlv.header));
+        *buffer += sizeof(tsf_tlv.header);
+        /* TSF at the time when beacon/probe_response was received */
+        tsf_val = cpu_to_le64(bss_desc->network_tsf);
+        memcpy(*buffer, &tsf_val, sizeof(tsf_val));
+        *buffer += sizeof(tsf_val);
+        memcpy(&tsf_val, bss_desc->time_stamp, sizeof(tsf_val));
+        dev_dbg(priv->adapter->dev, "info: %s: TSF offset calc: %016llx - "
+                        "%016llx\n", __func__, tsf_val, bss_desc->network_tsf);
+        memcpy(*buffer, &tsf_val, sizeof(tsf_val));
+        *buffer += sizeof(tsf_val);
+        return sizeof(tsf_tlv.header) + (2 * sizeof(tsf_val));
+}
+/*
+ * This function finds out the common rates between rate1 and rate2.
+ *
+ * It will fill common rates in rate1 as output if found.
+ *
+ * NOTE: Setting the MSB of the basic rates needs to be taken
+ * care of, either before or after calling this function.
+ */
+static int mwifiex_get_common_rates(struct mwifiex_private *priv, u8 *rate1,
+                                    u32 rate1_size, u8 *rate2, u32 rate2_size)
+{
+        int ret;
+        u8 *ptr = rate1, *tmp;
+        u32 i, j;
+        tmp = kmalloc(rate1_size, GFP_KERNEL);
+        if (!tmp) {
+                dev_err(priv->adapter->dev, "failed to alloc tmp buf\n");
+                return -ENOMEM;
+        }
+        memcpy(tmp, rate1, rate1_size);
+        memset(rate1, 0, rate1_size);
+        for (i = 0; rate2[i] && i < rate2_size; i++) {
+                for (j = 0; tmp[j] && j < rate1_size; j++) {
+                        /* Check common rate, excluding the bit for
+                           basic rate */
+                        if ((rate2[i] & 0x7F) == (tmp[j] & 0x7F)) {
+                                *rate1++ = tmp[j];
+                                break;
+                        }
+                }
+        }
+        dev_dbg(priv->adapter->dev, "info: Tx data rate set to %#x\n",
+                                                priv->data_rate);
+        if (!priv->is_data_rate_auto) {
+                while (*ptr) {
+                        if ((*ptr & 0x7f) == priv->data_rate) {
+                                ret = 0;
+                                goto done;
+                        }
+                        ptr++;
+                }
+                dev_err(priv->adapter->dev, "previously set fixed data rate %#x"
+                        " is not compatible with the network\n",
+                        priv->data_rate);
+                ret = -1;
+                goto done;
+        }
+        ret = 0;
+done:
+        kfree(tmp);
+        return ret;
+}
+/*
+ * This function creates the intersection of the rates supported by a
+ * target BSS and our adapter settings for use in an assoc/join command.
+ */
+static int
+mwifiex_setup_rates_from_bssdesc(struct mwifiex_private *priv,
+                                 struct mwifiex_bssdescriptor *bss_desc,
+                                 u8 *out_rates, u32 *out_rates_size)
+{
+        u8 card_rates[MWIFIEX_SUPPORTED_RATES];
+        u32 card_rates_size;
+        /* Copy AP supported rates */
+        memcpy(out_rates, bss_desc->supported_rates, MWIFIEX_SUPPORTED_RATES);
+        /* Get the STA supported rates */
+        card_rates_size = mwifiex_get_active_data_rates(priv, card_rates);
+        /* Get the common rates between AP and STA supported rates */
+        if (mwifiex_get_common_rates(priv, out_rates, MWIFIEX_SUPPORTED_RATES,
+                                     card_rates, card_rates_size)) {
+                *out_rates_size = 0;
+                dev_err(priv->adapter->dev, "%s: cannot get common rates\n",
+                                                __func__);
+                return -1;
+        }
+        *out_rates_size =
+                min_t(size_t, strlen(out_rates), MWIFIEX_SUPPORTED_RATES);
+        return 0;
+}
+/*
+ * This function updates the scan entry TSF timestamps to reflect
+ * a new association.
+ */
+static void
+mwifiex_update_tsf_timestamps(struct mwifiex_private *priv,
+                              struct mwifiex_bssdescriptor *new_bss_desc)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        u32 table_idx;
+        long long new_tsf_base;
+        signed long long tsf_delta;
+        memcpy(&new_tsf_base, new_bss_desc->time_stamp, sizeof(new_tsf_base));
+        tsf_delta = new_tsf_base - new_bss_desc->network_tsf;
+        dev_dbg(adapter->dev, "info: TSF: update TSF timestamps, "
+                "0x%016llx -> 0x%016llx\n",
+               new_bss_desc->network_tsf, new_tsf_base);
+        for (table_idx = 0; table_idx < adapter->num_in_scan_table;
+             table_idx++)
+                adapter->scan_table[table_idx].network_tsf += tsf_delta;
+}
+/*
+ * This function appends a WAPI IE.
+ *
+ * This function is called from the network join command preparation routine.
+ *
+ * If the IE buffer has been setup by the application, this routine appends
+ * the buffer as a WAPI TLV type to the request.
+ */
+static int
+mwifiex_cmd_append_wapi_ie(struct mwifiex_private *priv, u8 **buffer)
+{
+        int retLen = 0;
+        struct mwifiex_ie_types_header ie_header;
+        /* Null Checks */
+        if (buffer == NULL)
+                return 0;
+        if (*buffer == NULL)
+                return 0;
+        /*
+         * If there is a wapi ie buffer setup, append it to the return
+         *   parameter buffer pointer.
+         */
+        if (priv->wapi_ie_len) {
+                dev_dbg(priv->adapter->dev, "cmd: append wapi ie %d to %p\n",
+                                priv->wapi_ie_len, *buffer);
+                /* Wrap the generic IE buffer with a pass through TLV type */
+                ie_header.type = cpu_to_le16(TLV_TYPE_WAPI_IE);
+                ie_header.len = cpu_to_le16(priv->wapi_ie_len);
+                memcpy(*buffer, &ie_header, sizeof(ie_header));
+                /* Increment the return size and the return buffer pointer
+                   param */
+                *buffer += sizeof(ie_header);
+                retLen += sizeof(ie_header);
+                /* Copy the wapi IE buffer to the output buffer, advance
+                   pointer */
+                memcpy(*buffer, priv->wapi_ie, priv->wapi_ie_len);
+                /* Increment the return size and the return buffer pointer
+                   param */
+                *buffer += priv->wapi_ie_len;
+                retLen += priv->wapi_ie_len;
+        }
+        /* return the length appended to the buffer */
+        return retLen;
+}
+/*
+ * This function appends rsn ie tlv for wpa/wpa2 security modes.
+ * It is called from the network join command preparation routine.
+ */
+static int mwifiex_append_rsn_ie_wpa_wpa2(struct mwifiex_private *priv,
+                                          u8 **buffer)
+{
+        struct mwifiex_ie_types_rsn_param_set *rsn_ie_tlv;
+        int rsn_ie_len;
+        if (!buffer || !(*buffer))
+                return 0;
+        rsn_ie_tlv = (struct mwifiex_ie_types_rsn_param_set *) (*buffer);
+        rsn_ie_tlv->header.type = cpu_to_le16((u16) priv->wpa_ie[0]);
+        rsn_ie_tlv->header.type = cpu_to_le16(
+                                 le16_to_cpu(rsn_ie_tlv->header.type) & 0x00FF);
+        rsn_ie_tlv->header.len = cpu_to_le16((u16) priv->wpa_ie[1]);
+        rsn_ie_tlv->header.len = cpu_to_le16(le16_to_cpu(rsn_ie_tlv->header.len)
+                                                        & 0x00FF);
+        if (le16_to_cpu(rsn_ie_tlv->header.len) <= (sizeof(priv->wpa_ie) - 2))
+                memcpy(rsn_ie_tlv->rsn_ie, &priv->wpa_ie[2],
+                                        le16_to_cpu(rsn_ie_tlv->header.len));
+        else
+                return -1;
+        rsn_ie_len = sizeof(rsn_ie_tlv->header) +
+                                        le16_to_cpu(rsn_ie_tlv->header.len);
+        *buffer += rsn_ie_len;
+        return rsn_ie_len;
+}
+/*
+ * This function prepares command for association.
+ *
+ * This sets the following parameters -
+ *      - Peer MAC address
+ *      - Listen interval
+ *      - Beacon interval
+ *      - Capability information
+ *
+ * ...and the following TLVs, as required -
+ *      - SSID TLV
+ *      - PHY TLV
+ *      - SS TLV
+ *      - Rates TLV
+ *      - Authentication TLV
+ *      - Channel TLV
+ *      - WPA/WPA2 IE
+ *      - 11n TLV
+ *      - Vendor specific TLV
+ *      - WMM TLV
+ *      - WAPI IE
+ *      - Generic IE
+ *      - TSF TLV
+ *
+ * Preparation also includes -
+ *      - Setting command ID and proper size
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_802_11_associate(struct mwifiex_private *priv,
+                                 struct host_cmd_ds_command *cmd,
+                                 void *data_buf)
+{
+        struct host_cmd_ds_802_11_associate *assoc = &cmd->params.associate;
+        struct mwifiex_bssdescriptor *bss_desc;
+        struct mwifiex_ie_types_ssid_param_set *ssid_tlv;
+        struct mwifiex_ie_types_phy_param_set *phy_tlv;
+        struct mwifiex_ie_types_ss_param_set *ss_tlv;
+        struct mwifiex_ie_types_rates_param_set *rates_tlv;
+        struct mwifiex_ie_types_auth_type *auth_tlv;
+        struct mwifiex_ie_types_chan_list_param_set *chan_tlv;
+        u8 rates[MWIFIEX_SUPPORTED_RATES];
+        u32 rates_size;
+        u16 tmp_cap;
+        u8 *pos;
+        int rsn_ie_len = 0;
+        bss_desc = (struct mwifiex_bssdescriptor *) data_buf;
+        pos = (u8 *) assoc;
+        mwifiex_cfg_tx_buf(priv, bss_desc);
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_ASSOCIATE);
+        /* Save so we know which BSS Desc to use in the response handler */
+        priv->attempted_bss_desc = bss_desc;
+        memcpy(assoc->peer_sta_addr,
+               bss_desc->mac_address, sizeof(assoc->peer_sta_addr));
+        pos += sizeof(assoc->peer_sta_addr);
+        /* Set the listen interval */
+        assoc->listen_interval = cpu_to_le16(priv->listen_interval);
+        /* Set the beacon period */
+        assoc->beacon_period = cpu_to_le16(bss_desc->beacon_period);
+        pos += sizeof(assoc->cap_info_bitmap);
+        pos += sizeof(assoc->listen_interval);
+        pos += sizeof(assoc->beacon_period);
+        pos += sizeof(assoc->dtim_period);
+        ssid_tlv = (struct mwifiex_ie_types_ssid_param_set *) pos;
+        ssid_tlv->header.type = cpu_to_le16(WLAN_EID_SSID);
+        ssid_tlv->header.len = cpu_to_le16((u16) bss_desc->ssid.ssid_len);
+        memcpy(ssid_tlv->ssid, bss_desc->ssid.ssid,
+                le16_to_cpu(ssid_tlv->header.len));
+        pos += sizeof(ssid_tlv->header) + le16_to_cpu(ssid_tlv->header.len);
+        phy_tlv = (struct mwifiex_ie_types_phy_param_set *) pos;
+        phy_tlv->header.type = cpu_to_le16(WLAN_EID_DS_PARAMS);
+        phy_tlv->header.len = cpu_to_le16(sizeof(phy_tlv->fh_ds.ds_param_set));
+        memcpy(&phy_tlv->fh_ds.ds_param_set,
+               &bss_desc->phy_param_set.ds_param_set.current_chan,
+               sizeof(phy_tlv->fh_ds.ds_param_set));
+        pos += sizeof(phy_tlv->header) + le16_to_cpu(phy_tlv->header.len);
+        ss_tlv = (struct mwifiex_ie_types_ss_param_set *) pos;
+        ss_tlv->header.type = cpu_to_le16(WLAN_EID_CF_PARAMS);
+        ss_tlv->header.len = cpu_to_le16(sizeof(ss_tlv->cf_ibss.cf_param_set));
+        pos += sizeof(ss_tlv->header) + le16_to_cpu(ss_tlv->header.len);
+        /* Get the common rates supported between the driver and the BSS Desc */
+        if (mwifiex_setup_rates_from_bssdesc
+            (priv, bss_desc, rates, &rates_size))
+                return -1;
+        /* Save the data rates into Current BSS state structure */
+        priv->curr_bss_params.num_of_rates = rates_size;
+        memcpy(&priv->curr_bss_params.data_rates, rates, rates_size);
+        /* Setup the Rates TLV in the association command */
+        rates_tlv = (struct mwifiex_ie_types_rates_param_set *) pos;
+        rates_tlv->header.type = cpu_to_le16(WLAN_EID_SUPP_RATES);
+        rates_tlv->header.len = cpu_to_le16((u16) rates_size);
+        memcpy(rates_tlv->rates, rates, rates_size);
+        pos += sizeof(rates_tlv->header) + rates_size;
+        dev_dbg(priv->adapter->dev, "info: ASSOC_CMD: rates size = %d\n",
+                                        rates_size);
+        /* Add the Authentication type to be used for Auth frames */
+        auth_tlv = (struct mwifiex_ie_types_auth_type *) pos;
+        auth_tlv->header.type = cpu_to_le16(TLV_TYPE_AUTH_TYPE);
+        auth_tlv->header.len = cpu_to_le16(sizeof(auth_tlv->auth_type));
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_ENABLED)
+                auth_tlv->auth_type = cpu_to_le16(
+                                (u16) priv->sec_info.authentication_mode);
+        else
+                auth_tlv->auth_type = cpu_to_le16(NL80211_AUTHTYPE_OPEN_SYSTEM);
+        pos += sizeof(auth_tlv->header) + le16_to_cpu(auth_tlv->header.len);
+        if (IS_SUPPORT_MULTI_BANDS(priv->adapter)
+            && !(ISSUPP_11NENABLED(priv->adapter->fw_cap_info)
+                && (!bss_desc->disable_11n)
+                 && (priv->adapter->config_bands & BAND_GN
+                     || priv->adapter->config_bands & BAND_AN)
+                 && (bss_desc->bcn_ht_cap)
+            )
+                ) {
+                /* Append a channel TLV for the channel the attempted AP was
+                   found on */
+                chan_tlv = (struct mwifiex_ie_types_chan_list_param_set *) pos;
+                chan_tlv->header.type = cpu_to_le16(TLV_TYPE_CHANLIST);
+                chan_tlv->header.len =
+                        cpu_to_le16(sizeof(struct mwifiex_chan_scan_param_set));
+                memset(chan_tlv->chan_scan_param, 0x00,
+                       sizeof(struct mwifiex_chan_scan_param_set));
+                chan_tlv->chan_scan_param[0].chan_number =
+                        (bss_desc->phy_param_set.ds_param_set.current_chan);
+                dev_dbg(priv->adapter->dev, "info: Assoc: TLV Chan = %d\n",
+                       chan_tlv->chan_scan_param[0].chan_number);
+                chan_tlv->chan_scan_param[0].radio_type =
+                        mwifiex_band_to_radio_type((u8) bss_desc->bss_band);
+                dev_dbg(priv->adapter->dev, "info: Assoc: TLV Band = %d\n",
+                       chan_tlv->chan_scan_param[0].radio_type);
+                pos += sizeof(chan_tlv->header) +
+                        sizeof(struct mwifiex_chan_scan_param_set);
+        }
+        if (!priv->wps.session_enable) {
+                if (priv->sec_info.wpa_enabled || priv->sec_info.wpa2_enabled)
+                        rsn_ie_len = mwifiex_append_rsn_ie_wpa_wpa2(priv, &pos);
+                if (rsn_ie_len == -1)
+                        return -1;
+        }
+        if (ISSUPP_11NENABLED(priv->adapter->fw_cap_info)
+                && (!bss_desc->disable_11n)
+            && (priv->adapter->config_bands & BAND_GN
+                || priv->adapter->config_bands & BAND_AN))
+                mwifiex_cmd_append_11n_tlv(priv, bss_desc, &pos);
+        /* Append vendor specific IE TLV */
+        mwifiex_cmd_append_vsie_tlv(priv, MWIFIEX_VSIE_MASK_ASSOC, &pos);
+        mwifiex_wmm_process_association_req(priv, &pos, &bss_desc->wmm_ie,
+                                            bss_desc->bcn_ht_cap);
+        if (priv->sec_info.wapi_enabled && priv->wapi_ie_len)
+                mwifiex_cmd_append_wapi_ie(priv, &pos);
+        mwifiex_cmd_append_generic_ie(priv, &pos);
+        mwifiex_cmd_append_tsf_tlv(priv, &pos, bss_desc);
+        cmd->size = cpu_to_le16((u16) (pos - (u8 *) assoc) + S_DS_GEN);
+        /* Set the Capability info at last */
+        tmp_cap = bss_desc->cap_info_bitmap;
+        if (priv->adapter->config_bands == BAND_B)
+                tmp_cap &= ~WLAN_CAPABILITY_SHORT_SLOT_TIME;
+        tmp_cap &= CAPINFO_MASK;
+        dev_dbg(priv->adapter->dev, "info: ASSOC_CMD: tmp_cap=%4X CAPINFO_MASK=%4lX\n",
+               tmp_cap, CAPINFO_MASK);
+        assoc->cap_info_bitmap = cpu_to_le16(tmp_cap);
+        return 0;
+}
+/*
+ * Association firmware command response handler
+ *
+ * The response buffer for the association command has the following
+ * memory layout.
+ *
+ * For cases where an association response was not received (indicated
+ * by the CapInfo and AId field):
+ *
+ *     .------------------------------------------------------------.
+ *     |  Header(4 * sizeof(t_u16)):  Standard command response hdr |
+ *     .------------------------------------------------------------.
+ *     |  cap_info/Error Return(t_u16):                             |
+ *     |           0xFFFF(-1): Internal error                       |
+ *     |           0xFFFE(-2): Authentication unhandled message     |
+ *     |           0xFFFD(-3): Authentication refused               |
+ *     |           0xFFFC(-4): Timeout waiting for AP response      |
+ *     .------------------------------------------------------------.
+ *     |  status_code(t_u16):                                       |
+ *     |        If cap_info is -1:                                  |
+ *     |           An internal firmware failure prevented the       |
+ *     |           command from being processed.  The status_code   |
+ *     |           will be set to 1.                                |
+ *     |                                                            |
+ *     |        If cap_info is -2:                                  |
+ *     |           An authentication frame was received but was     |
+ *     |           not handled by the firmware.  IEEE Status        |
+ *     |           code for the failure is returned.                |
+ *     |                                                            |
+ *     |        If cap_info is -3:                                  |
+ *     |           An authentication frame was received and the     |
+ *     |           status_code is the IEEE Status reported in the   |
+ *     |           response.                                        |
+ *     |                                                            |
+ *     |        If cap_info is -4:                                  |
+ *     |           (1) Association response timeout                 |
+ *     |           (2) Authentication response timeout              |
+ *     .------------------------------------------------------------.
+ *     |  a_id(t_u16): 0xFFFF                                       |
+ *     .------------------------------------------------------------.
+ *
+ *
+ * For cases where an association response was received, the IEEE
+ * standard association response frame is returned:
+ *
+ *     .------------------------------------------------------------.
+ *     |  Header(4 * sizeof(t_u16)):  Standard command response hdr |
+ *     .------------------------------------------------------------.
+ *     |  cap_info(t_u16): IEEE Capability                          |
+ *     .------------------------------------------------------------.
+ *     |  status_code(t_u16): IEEE Status Code                      |
+ *     .------------------------------------------------------------.
+ *     |  a_id(t_u16): IEEE Association ID                          |
+ *     .------------------------------------------------------------.
+ *     |  IEEE IEs(variable): Any received IEs comprising the       |
+ *     |                      remaining portion of a received       |
+ *     |                      association response frame.           |
+ *     .------------------------------------------------------------.
+ *
+ * For simplistic handling, the status_code field can be used to determine
+ * an association success (0) or failure (non-zero).
+ */
+int mwifiex_ret_802_11_associate(struct mwifiex_private *priv,
+                             struct host_cmd_ds_command *resp)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        int ret = 0;
+        struct ieee_types_assoc_rsp *assoc_rsp;
+        struct mwifiex_bssdescriptor *bss_desc;
+        u8 enable_data = true;
+        assoc_rsp = (struct ieee_types_assoc_rsp *) &resp->params;
+        priv->assoc_rsp_size = min(le16_to_cpu(resp->size) - S_DS_GEN,
+                                     sizeof(priv->assoc_rsp_buf));
+        memcpy(priv->assoc_rsp_buf, &resp->params, priv->assoc_rsp_size);
+        if (le16_to_cpu(assoc_rsp->status_code)) {
+                priv->adapter->dbg.num_cmd_assoc_failure++;
+                dev_err(priv->adapter->dev, "ASSOC_RESP: association failed, "
+                       "status code = %d, error = 0x%x, a_id = 0x%x\n",
+                       le16_to_cpu(assoc_rsp->status_code),
+                       le16_to_cpu(assoc_rsp->cap_info_bitmap),
+                       le16_to_cpu(assoc_rsp->a_id));
+                ret = -1;
+                goto done;
+        }
+        /* Send a Media Connected event, according to the Spec */
+        priv->media_connected = true;
+        priv->adapter->ps_state = PS_STATE_AWAKE;
+        priv->adapter->pps_uapsd_mode = false;
+        priv->adapter->tx_lock_flag = false;
+        /* Set the attempted BSSID Index to current */
+        bss_desc = priv->attempted_bss_desc;
+        dev_dbg(priv->adapter->dev, "info: ASSOC_RESP: %s\n",
+                                                bss_desc->ssid.ssid);
+        /* Make a copy of current BSSID descriptor */
+        memcpy(&priv->curr_bss_params.bss_descriptor,
+               bss_desc, sizeof(struct mwifiex_bssdescriptor));
+        /* Update curr_bss_params */
+        priv->curr_bss_params.bss_descriptor.channel
+                = bss_desc->phy_param_set.ds_param_set.current_chan;
+        priv->curr_bss_params.band = (u8) bss_desc->bss_band;
+        /*
+         * Adjust the timestamps in the scan table to be relative to the newly
+         * associated AP's TSF
+         */
+        mwifiex_update_tsf_timestamps(priv, bss_desc);
+        if (bss_desc->wmm_ie.vend_hdr.element_id == WLAN_EID_VENDOR_SPECIFIC)
+                priv->curr_bss_params.wmm_enabled = true;
+        else
+                priv->curr_bss_params.wmm_enabled = false;
+        if ((priv->wmm_required || bss_desc->bcn_ht_cap)
+                        && priv->curr_bss_params.wmm_enabled)
+                priv->wmm_enabled = true;
+        else
+                priv->wmm_enabled = false;
+        priv->curr_bss_params.wmm_uapsd_enabled = false;
+        if (priv->wmm_enabled)
+                priv->curr_bss_params.wmm_uapsd_enabled
+                        = ((bss_desc->wmm_ie.qos_info_bitmap &
+                                IEEE80211_WMM_IE_AP_QOSINFO_UAPSD) ? 1 : 0);
+        dev_dbg(priv->adapter->dev, "info: ASSOC_RESP: curr_pkt_filter is %#x\n",
+               priv->curr_pkt_filter);
+        if (priv->sec_info.wpa_enabled || priv->sec_info.wpa2_enabled)
+                priv->wpa_is_gtk_set = false;
+        if (priv->wmm_enabled) {
+                /* Don't re-enable carrier until we get the WMM_GET_STATUS
+                   event */
+                enable_data = false;
+        } else {
+                /* Since WMM is not enabled, setup the queues with the
+                   defaults */
+                mwifiex_wmm_setup_queue_priorities(priv, NULL);
+                mwifiex_wmm_setup_ac_downgrade(priv);
+        }
+        if (enable_data)
+                dev_dbg(priv->adapter->dev,
+                        "info: post association, re-enabling data flow\n");
+        /* Reset SNR/NF/RSSI values */
+        priv->data_rssi_last = 0;
+        priv->data_nf_last = 0;
+        priv->data_rssi_avg = 0;
+        priv->data_nf_avg = 0;
+        priv->bcn_rssi_last = 0;
+        priv->bcn_nf_last = 0;
+        priv->bcn_rssi_avg = 0;
+        priv->bcn_nf_avg = 0;
+        priv->rxpd_rate = 0;
+        priv->rxpd_htinfo = 0;
+        mwifiex_save_curr_bcn(priv);
+        priv->adapter->dbg.num_cmd_assoc_success++;
+        dev_dbg(priv->adapter->dev, "info: ASSOC_RESP: associated\n");
+        /* Add the ra_list here for infra mode as there will be only 1 ra
+           always */
+        mwifiex_ralist_add(priv,
+                           priv->curr_bss_params.bss_descriptor.mac_address);
+        if (!netif_carrier_ok(priv->netdev))
+                netif_carrier_on(priv->netdev);
+        if (netif_queue_stopped(priv->netdev))
+                netif_wake_queue(priv->netdev);
+        if (priv->sec_info.wpa_enabled || priv->sec_info.wpa2_enabled)
+                priv->scan_block = true;
+done:
+        /* Need to indicate IOCTL complete */
+        if (adapter->curr_cmd->wait_q_enabled) {
+                if (ret)
+                        adapter->cmd_wait_q.status = -1;
+                else
+                        adapter->cmd_wait_q.status = 0;
+        }
+        return ret;
+}
+/*
+ * This function prepares command for ad-hoc start.
+ *
+ * Driver will fill up SSID, BSS mode, IBSS parameters, physical
+ * parameters, probe delay, and capability information. Firmware
+ * will fill up beacon period, basic rates and operational rates.
+ *
+ * In addition, the following TLVs are added -
+ *      - Channel TLV
+ *      - Vendor specific IE
+ *      - WPA/WPA2 IE
+ *      - HT Capabilities IE
+ *      - HT Information IE
+ *
+ * Preparation also includes -
+ *      - Setting command ID and proper size
+ *      - Ensuring correct endian-ness
+ */
+int
+mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv,
+                                struct host_cmd_ds_command *cmd, void *data_buf)
+{
+        int rsn_ie_len = 0;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct host_cmd_ds_802_11_ad_hoc_start *adhoc_start =
+                &cmd->params.adhoc_start;
+        struct mwifiex_bssdescriptor *bss_desc;
+        u32 cmd_append_size = 0;
+        u32 i;
+        u16 tmp_cap;
+        uint16_t ht_cap_info;
+        struct mwifiex_ie_types_chan_list_param_set *chan_tlv;
+        struct mwifiex_ie_types_htcap *ht_cap;
+        struct mwifiex_ie_types_htinfo *ht_info;
+        u8 *pos = (u8 *) adhoc_start +
+                        sizeof(struct host_cmd_ds_802_11_ad_hoc_start);
+        if (!adapter)
+                return -1;
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_AD_HOC_START);
+        bss_desc = &priv->curr_bss_params.bss_descriptor;
+        priv->attempted_bss_desc = bss_desc;
+        /*
+         * Fill in the parameters for 2 data structures:
+         *   1. struct host_cmd_ds_802_11_ad_hoc_start command
+         *   2. bss_desc
+         * Driver will fill up SSID, bss_mode,IBSS param, Physical Param,
+         * probe delay, and Cap info.
+         * Firmware will fill up beacon period, Basic rates
+         * and operational rates.
+         */
+        memset(adhoc_start->ssid, 0, IEEE80211_MAX_SSID_LEN);
+        memcpy(adhoc_start->ssid,
+               ((struct mwifiex_802_11_ssid *) data_buf)->ssid,
+               ((struct mwifiex_802_11_ssid *) data_buf)->ssid_len);
+        dev_dbg(adapter->dev, "info: ADHOC_S_CMD: SSID = %s\n",
+                                adhoc_start->ssid);
+        memset(bss_desc->ssid.ssid, 0, IEEE80211_MAX_SSID_LEN);
+        memcpy(bss_desc->ssid.ssid,
+               ((struct mwifiex_802_11_ssid *) data_buf)->ssid,
+               ((struct mwifiex_802_11_ssid *) data_buf)->ssid_len);
+        bss_desc->ssid.ssid_len =
+                ((struct mwifiex_802_11_ssid *) data_buf)->ssid_len;
+        /* Set the BSS mode */
+        adhoc_start->bss_mode = HostCmd_BSS_MODE_IBSS;
+        bss_desc->bss_mode = NL80211_IFTYPE_ADHOC;
+        adhoc_start->beacon_period = cpu_to_le16(priv->beacon_period);
+        bss_desc->beacon_period = priv->beacon_period;
+        /* Set Physical param set */
+/* Parameter IE Id */
+#define DS_PARA_IE_ID   3
+/* Parameter IE length */
+#define DS_PARA_IE_LEN  1
+        adhoc_start->phy_param_set.ds_param_set.element_id = DS_PARA_IE_ID;
+        adhoc_start->phy_param_set.ds_param_set.len = DS_PARA_IE_LEN;
+        if (!mwifiex_get_cfp_by_band_and_channel_from_cfg80211
+                        (priv, adapter->adhoc_start_band, (u16)
+                                priv->adhoc_channel)) {
+                struct mwifiex_chan_freq_power *cfp;
+                cfp = mwifiex_get_cfp_by_band_and_channel_from_cfg80211(priv,
+                                adapter->adhoc_start_band, FIRST_VALID_CHANNEL);
+                if (cfp)
+                        priv->adhoc_channel = (u8) cfp->channel;
+        }
+        if (!priv->adhoc_channel) {
+                dev_err(adapter->dev, "ADHOC_S_CMD: adhoc_channel cannot be 0\n");
+                return -1;
+        }
+        dev_dbg(adapter->dev, "info: ADHOC_S_CMD: creating ADHOC on channel %d\n",
+                                priv->adhoc_channel);
+        priv->curr_bss_params.bss_descriptor.channel = priv->adhoc_channel;
+        priv->curr_bss_params.band = adapter->adhoc_start_band;
+        bss_desc->channel = priv->adhoc_channel;
+        adhoc_start->phy_param_set.ds_param_set.current_chan =
+                priv->adhoc_channel;
+        memcpy(&bss_desc->phy_param_set, &adhoc_start->phy_param_set,
+               sizeof(union ieee_types_phy_param_set));
+        /* Set IBSS param set */
+/* IBSS parameter IE Id */
+#define IBSS_PARA_IE_ID   6
+/* IBSS parameter IE length */
+#define IBSS_PARA_IE_LEN  2
+        adhoc_start->ss_param_set.ibss_param_set.element_id = IBSS_PARA_IE_ID;
+        adhoc_start->ss_param_set.ibss_param_set.len = IBSS_PARA_IE_LEN;
+        adhoc_start->ss_param_set.ibss_param_set.atim_window
+                = cpu_to_le16(priv->atim_window);
+        memcpy(&bss_desc->ss_param_set, &adhoc_start->ss_param_set,
+               sizeof(union ieee_types_ss_param_set));
+        /* Set Capability info */
+        bss_desc->cap_info_bitmap |= WLAN_CAPABILITY_IBSS;
+        tmp_cap = le16_to_cpu(adhoc_start->cap_info_bitmap);
+        tmp_cap &= ~WLAN_CAPABILITY_ESS;
+        tmp_cap |= WLAN_CAPABILITY_IBSS;
+        /* Set up privacy in bss_desc */
+        if (priv->sec_info.encryption_mode) {
+                /* Ad-Hoc capability privacy on */
+                dev_dbg(adapter->dev,
+                        "info: ADHOC_S_CMD: wep_status set privacy to WEP\n");
+                bss_desc->privacy = MWIFIEX_802_11_PRIV_FILTER_8021X_WEP;
+                tmp_cap |= WLAN_CAPABILITY_PRIVACY;
+        } else {
+                dev_dbg(adapter->dev, "info: ADHOC_S_CMD: wep_status NOT set,"
+                                " setting privacy to ACCEPT ALL\n");
+                bss_desc->privacy = MWIFIEX_802_11_PRIV_FILTER_ACCEPT_ALL;
+        }
+        memset(adhoc_start->DataRate, 0, sizeof(adhoc_start->DataRate));
+        mwifiex_get_active_data_rates(priv, adhoc_start->DataRate);
+        if ((adapter->adhoc_start_band & BAND_G) &&
+            (priv->curr_pkt_filter & HostCmd_ACT_MAC_ADHOC_G_PROTECTION_ON)) {
+                if (mwifiex_send_cmd_async(priv, HostCmd_CMD_MAC_CONTROL,
+                                             HostCmd_ACT_GEN_SET, 0,
+                                             &priv->curr_pkt_filter)) {
+                        dev_err(adapter->dev,
+                               "ADHOC_S_CMD: G Protection config failed\n");
+                        return -1;
+                }
+        }
+        /* Find the last non zero */
+        for (i = 0; i < sizeof(adhoc_start->DataRate) &&
+                        adhoc_start->DataRate[i];
+                        i++)
+                        ;
+        priv->curr_bss_params.num_of_rates = i;
+        /* Copy the ad-hoc creating rates into Current BSS rate structure */
+        memcpy(&priv->curr_bss_params.data_rates,
+               &adhoc_start->DataRate, priv->curr_bss_params.num_of_rates);
+        dev_dbg(adapter->dev, "info: ADHOC_S_CMD: rates=%02x %02x %02x %02x\n",
+               adhoc_start->DataRate[0], adhoc_start->DataRate[1],
+               adhoc_start->DataRate[2], adhoc_start->DataRate[3]);
+        dev_dbg(adapter->dev, "info: ADHOC_S_CMD: AD-HOC Start command is ready\n");
+        if (IS_SUPPORT_MULTI_BANDS(adapter)) {
+                /* Append a channel TLV */
+                chan_tlv = (struct mwifiex_ie_types_chan_list_param_set *) pos;
+                chan_tlv->header.type = cpu_to_le16(TLV_TYPE_CHANLIST);
+                chan_tlv->header.len =
+                        cpu_to_le16(sizeof(struct mwifiex_chan_scan_param_set));
+                memset(chan_tlv->chan_scan_param, 0x00,
+                       sizeof(struct mwifiex_chan_scan_param_set));
+                chan_tlv->chan_scan_param[0].chan_number =
+                        (u8) priv->curr_bss_params.bss_descriptor.channel;
+                dev_dbg(adapter->dev, "info: ADHOC_S_CMD: TLV Chan = %d\n",
+                       chan_tlv->chan_scan_param[0].chan_number);
+                chan_tlv->chan_scan_param[0].radio_type
+                       = mwifiex_band_to_radio_type(priv->curr_bss_params.band);
+                if (adapter->adhoc_start_band & BAND_GN
+                    || adapter->adhoc_start_band & BAND_AN) {
+                        if (adapter->chan_offset == SEC_CHANNEL_ABOVE)
+                                chan_tlv->chan_scan_param[0].radio_type |=
+                                        SECOND_CHANNEL_ABOVE;
+                        else if (adapter->chan_offset == SEC_CHANNEL_BELOW)
+                                chan_tlv->chan_scan_param[0].radio_type |=
+                                        SECOND_CHANNEL_BELOW;
+                }
+                dev_dbg(adapter->dev, "info: ADHOC_S_CMD: TLV Band = %d\n",
+                       chan_tlv->chan_scan_param[0].radio_type);
+                pos += sizeof(chan_tlv->header) +
+                        sizeof(struct mwifiex_chan_scan_param_set);
+                cmd_append_size +=
+                        sizeof(chan_tlv->header) +
+                        sizeof(struct mwifiex_chan_scan_param_set);
+        }
+        /* Append vendor specific IE TLV */
+        cmd_append_size += mwifiex_cmd_append_vsie_tlv(priv,
+                                MWIFIEX_VSIE_MASK_ADHOC, &pos);
+        if (priv->sec_info.wpa_enabled) {
+                rsn_ie_len = mwifiex_append_rsn_ie_wpa_wpa2(priv, &pos);
+                if (rsn_ie_len == -1)
+                        return -1;
+                cmd_append_size += rsn_ie_len;
+        }
+        if (adapter->adhoc_11n_enabled) {
+                {
+                        ht_cap = (struct mwifiex_ie_types_htcap *) pos;
+                        memset(ht_cap, 0,
+                               sizeof(struct mwifiex_ie_types_htcap));
+                        ht_cap->header.type =
+                                cpu_to_le16(WLAN_EID_HT_CAPABILITY);
+                        ht_cap->header.len =
+                               cpu_to_le16(sizeof(struct ieee80211_ht_cap));
+                        ht_cap_info = le16_to_cpu(ht_cap->ht_cap.cap_info);
+                        ht_cap_info |= IEEE80211_HT_CAP_SGI_20;
+                        if (adapter->chan_offset) {
+                                ht_cap_info |= IEEE80211_HT_CAP_SGI_40;
+                                ht_cap_info |= IEEE80211_HT_CAP_DSSSCCK40;
+                                ht_cap_info |= IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+                                SETHT_MCS32(ht_cap->ht_cap.mcs.rx_mask);
+                        }
+                        ht_cap->ht_cap.ampdu_params_info
+                                        = IEEE80211_HT_MAX_AMPDU_64K;
+                        ht_cap->ht_cap.mcs.rx_mask[0] = 0xff;
+                        pos += sizeof(struct mwifiex_ie_types_htcap);
+                        cmd_append_size +=
+                                sizeof(struct mwifiex_ie_types_htcap);
+                }
+                {
+                        ht_info = (struct mwifiex_ie_types_htinfo *) pos;
+                        memset(ht_info, 0,
+                               sizeof(struct mwifiex_ie_types_htinfo));
+                        ht_info->header.type =
+                                cpu_to_le16(WLAN_EID_HT_INFORMATION);
+                        ht_info->header.len =
+                                cpu_to_le16(sizeof(struct ieee80211_ht_info));
+                        ht_info->ht_info.control_chan =
+                                (u8) priv->curr_bss_params.bss_descriptor.
+                                channel;
+                        if (adapter->chan_offset) {
+                                ht_info->ht_info.ht_param =
+                                        adapter->chan_offset;
+                                ht_info->ht_info.ht_param |=
+                                        IEEE80211_HT_PARAM_CHAN_WIDTH_ANY;
+                        }
+                        ht_info->ht_info.operation_mode =
+                             cpu_to_le16(IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT);
+                        ht_info->ht_info.basic_set[0] = 0xff;
+                        pos += sizeof(struct mwifiex_ie_types_htinfo);
+                        cmd_append_size +=
+                                sizeof(struct mwifiex_ie_types_htinfo);
+                }
+        }
+        cmd->size = cpu_to_le16((u16)
+                            (sizeof(struct host_cmd_ds_802_11_ad_hoc_start)
+                             + S_DS_GEN + cmd_append_size));
+        if (adapter->adhoc_start_band == BAND_B)
+                tmp_cap &= ~WLAN_CAPABILITY_SHORT_SLOT_TIME;
+        else
+                tmp_cap |= WLAN_CAPABILITY_SHORT_SLOT_TIME;
+        adhoc_start->cap_info_bitmap = cpu_to_le16(tmp_cap);
+        return 0;
+}
+/*
+ * This function prepares command for ad-hoc join.
+ *
+ * Most of the parameters are set up by copying from the target BSS descriptor
+ * from the scan response.
+ *
+ * In addition, the following TLVs are added -
+ *      - Channel TLV
+ *      - Vendor specific IE
+ *      - WPA/WPA2 IE
+ *      - 11n IE
+ *
+ * Preparation also includes -
+ *      - Setting command ID and proper size
+ *      - Ensuring correct endian-ness
+ */
+int
+mwifiex_cmd_802_11_ad_hoc_join(struct mwifiex_private *priv,
+                               struct host_cmd_ds_command *cmd, void *data_buf)
+{
+        int rsn_ie_len = 0;
+        struct host_cmd_ds_802_11_ad_hoc_join *adhoc_join =
+                &cmd->params.adhoc_join;
+        struct mwifiex_bssdescriptor *bss_desc =
+                (struct mwifiex_bssdescriptor *) data_buf;
+        struct mwifiex_ie_types_chan_list_param_set *chan_tlv;
+        u32 cmd_append_size = 0;
+        u16 tmp_cap;
+        u32 i, rates_size = 0;
+        u16 curr_pkt_filter;
+        u8 *pos =
+                (u8 *) adhoc_join +
+                sizeof(struct host_cmd_ds_802_11_ad_hoc_join);
+/* Use G protection */
+#define USE_G_PROTECTION        0x02
+        if (bss_desc->erp_flags & USE_G_PROTECTION) {
+                curr_pkt_filter =
+                        priv->
+                        curr_pkt_filter | HostCmd_ACT_MAC_ADHOC_G_PROTECTION_ON;
+                if (mwifiex_send_cmd_async(priv, HostCmd_CMD_MAC_CONTROL,
+                                             HostCmd_ACT_GEN_SET, 0,
+                                             &curr_pkt_filter)) {
+                        dev_err(priv->adapter->dev,
+                               "ADHOC_J_CMD: G Protection config failed\n");
+                        return -1;
+                }
+        }
+        priv->attempted_bss_desc = bss_desc;
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_AD_HOC_JOIN);
+        adhoc_join->bss_descriptor.bss_mode = HostCmd_BSS_MODE_IBSS;
+        adhoc_join->bss_descriptor.beacon_period
+                = cpu_to_le16(bss_desc->beacon_period);
+        memcpy(&adhoc_join->bss_descriptor.bssid,
+               &bss_desc->mac_address, ETH_ALEN);
+        memcpy(&adhoc_join->bss_descriptor.ssid,
+               &bss_desc->ssid.ssid, bss_desc->ssid.ssid_len);
+        memcpy(&adhoc_join->bss_descriptor.phy_param_set,
+               &bss_desc->phy_param_set,
+               sizeof(union ieee_types_phy_param_set));
+        memcpy(&adhoc_join->bss_descriptor.ss_param_set,
+               &bss_desc->ss_param_set, sizeof(union ieee_types_ss_param_set));
+        tmp_cap = bss_desc->cap_info_bitmap;
+        tmp_cap &= CAPINFO_MASK;
+        dev_dbg(priv->adapter->dev, "info: ADHOC_J_CMD: tmp_cap=%4X"
+                        " CAPINFO_MASK=%4lX\n", tmp_cap, CAPINFO_MASK);
+        /* Information on BSSID descriptor passed to FW */
+        dev_dbg(priv->adapter->dev, "info: ADHOC_J_CMD: BSSID = %pM, SSID = %s\n",
+                                adhoc_join->bss_descriptor.bssid,
+                                adhoc_join->bss_descriptor.ssid);
+        for (i = 0; bss_desc->supported_rates[i] &&
+                        i < MWIFIEX_SUPPORTED_RATES;
+                        i++)
+                        ;
+        rates_size = i;
+        /* Copy Data Rates from the Rates recorded in scan response */
+        memset(adhoc_join->bss_descriptor.data_rates, 0,
+               sizeof(adhoc_join->bss_descriptor.data_rates));
+        memcpy(adhoc_join->bss_descriptor.data_rates,
+               bss_desc->supported_rates, rates_size);
+        /* Copy the adhoc join rates into Current BSS state structure */
+        priv->curr_bss_params.num_of_rates = rates_size;
+        memcpy(&priv->curr_bss_params.data_rates, bss_desc->supported_rates,
+               rates_size);
+        /* Copy the channel information */
+        priv->curr_bss_params.bss_descriptor.channel = bss_desc->channel;
+        priv->curr_bss_params.band = (u8) bss_desc->bss_band;
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_ENABLED
+            || priv->sec_info.wpa_enabled)
+                tmp_cap |= WLAN_CAPABILITY_PRIVACY;
+        if (IS_SUPPORT_MULTI_BANDS(priv->adapter)) {
+                /* Append a channel TLV */
+                chan_tlv = (struct mwifiex_ie_types_chan_list_param_set *) pos;
+                chan_tlv->header.type = cpu_to_le16(TLV_TYPE_CHANLIST);
+                chan_tlv->header.len =
+                        cpu_to_le16(sizeof(struct mwifiex_chan_scan_param_set));
+                memset(chan_tlv->chan_scan_param, 0x00,
+                       sizeof(struct mwifiex_chan_scan_param_set));
+                chan_tlv->chan_scan_param[0].chan_number =
+                        (bss_desc->phy_param_set.ds_param_set.current_chan);
+                dev_dbg(priv->adapter->dev, "info: ADHOC_J_CMD: TLV Chan = %d\n",
+                       chan_tlv->chan_scan_param[0].chan_number);
+                chan_tlv->chan_scan_param[0].radio_type =
+                        mwifiex_band_to_radio_type((u8) bss_desc->bss_band);
+                dev_dbg(priv->adapter->dev, "info: ADHOC_J_CMD: TLV Band = %d\n",
+                       chan_tlv->chan_scan_param[0].radio_type);
+                pos += sizeof(chan_tlv->header) +
+                        sizeof(struct mwifiex_chan_scan_param_set);
+                cmd_append_size += sizeof(chan_tlv->header) +
+                        sizeof(struct mwifiex_chan_scan_param_set);
+        }
+        if (priv->sec_info.wpa_enabled)
+                rsn_ie_len = mwifiex_append_rsn_ie_wpa_wpa2(priv, &pos);
+        if (rsn_ie_len == -1)
+                return -1;
+        cmd_append_size += rsn_ie_len;
+        if (ISSUPP_11NENABLED(priv->adapter->fw_cap_info))
+                cmd_append_size += mwifiex_cmd_append_11n_tlv(priv,
+                        bss_desc, &pos);
+        /* Append vendor specific IE TLV */
+        cmd_append_size += mwifiex_cmd_append_vsie_tlv(priv,
+                        MWIFIEX_VSIE_MASK_ADHOC, &pos);
+        cmd->size = cpu_to_le16((u16)
+                            (sizeof(struct host_cmd_ds_802_11_ad_hoc_join)
+                             + S_DS_GEN + cmd_append_size));
+        adhoc_join->bss_descriptor.cap_info_bitmap = cpu_to_le16(tmp_cap);
+        return 0;
+}
+/*
+ * This function handles the command response of ad-hoc start and
+ * ad-hoc join.
+ *
+ * The function generates a device-connected event to notify
+ * the applications, in case of successful ad-hoc start/join, and
+ * saves the beacon buffer.
+ */
+int mwifiex_ret_802_11_ad_hoc(struct mwifiex_private *priv,
+                              struct host_cmd_ds_command *resp)
+{
+        int ret = 0;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct host_cmd_ds_802_11_ad_hoc_result *adhoc_result;
+        struct mwifiex_bssdescriptor *bss_desc;
+        adhoc_result = &resp->params.adhoc_result;
+        bss_desc = priv->attempted_bss_desc;
+        /* Join result code 0 --> SUCCESS */
+        if (le16_to_cpu(resp->result)) {
+                dev_err(priv->adapter->dev, "ADHOC_RESP: failed\n");
+                if (priv->media_connected)
+                        mwifiex_reset_connect_state(priv);
+                memset(&priv->curr_bss_params.bss_descriptor,
+                       0x00, sizeof(struct mwifiex_bssdescriptor));
+                ret = -1;
+                goto done;
+        }
+        /* Send a Media Connected event, according to the Spec */
+        priv->media_connected = true;
+        if (le16_to_cpu(resp->command) == HostCmd_CMD_802_11_AD_HOC_START) {
+                dev_dbg(priv->adapter->dev, "info: ADHOC_S_RESP %s\n",
+                                bss_desc->ssid.ssid);
+                /* Update the created network descriptor with the new BSSID */
+                memcpy(bss_desc->mac_address,
+                       adhoc_result->bssid, ETH_ALEN);
+                priv->adhoc_state = ADHOC_STARTED;
+        } else {
+                /*
+                 * Now the join cmd should be successful.
+                 * If BSSID has changed use SSID to compare instead of BSSID
+                 */
+                dev_dbg(priv->adapter->dev, "info: ADHOC_J_RESP %s\n",
+                                bss_desc->ssid.ssid);
+                /*
+                 * Make a copy of current BSSID descriptor, only needed for
+                 * join since the current descriptor is already being used
+                 * for adhoc start
+                 */
+                memcpy(&priv->curr_bss_params.bss_descriptor,
+                       bss_desc, sizeof(struct mwifiex_bssdescriptor));
+                priv->adhoc_state = ADHOC_JOINED;
+        }
+        dev_dbg(priv->adapter->dev, "info: ADHOC_RESP: channel = %d\n",
+                                priv->adhoc_channel);
+        dev_dbg(priv->adapter->dev, "info: ADHOC_RESP: BSSID = %pM\n",
+               priv->curr_bss_params.bss_descriptor.mac_address);
+        if (!netif_carrier_ok(priv->netdev))
+                netif_carrier_on(priv->netdev);
+        if (netif_queue_stopped(priv->netdev))
+                netif_wake_queue(priv->netdev);
+        mwifiex_save_curr_bcn(priv);
+done:
+        /* Need to indicate IOCTL complete */
+        if (adapter->curr_cmd->wait_q_enabled) {
+                if (ret)
+                        adapter->cmd_wait_q.status = -1;
+                else
+                        adapter->cmd_wait_q.status = 0;
+        }
+        return ret;
+}
+/*
+ * This function associates to a specific BSS discovered in a scan.
+ *
+ * It clears any past association response stored for application
+ * retrieval and calls the command preparation routine to send the
+ * command to firmware.
+ */
+int mwifiex_associate(struct mwifiex_private *priv,
+                      struct mwifiex_bssdescriptor *bss_desc)
+{
+        u8 current_bssid[ETH_ALEN];
+        /* Return error if the adapter or table entry is not marked as infra */
+        if ((priv->bss_mode != NL80211_IFTYPE_STATION) ||
+            (bss_desc->bss_mode != NL80211_IFTYPE_STATION))
+                return -1;
+        memcpy(&current_bssid,
+               &priv->curr_bss_params.bss_descriptor.mac_address,
+               sizeof(current_bssid));
+        /* Clear any past association response stored for application
+           retrieval */
+        priv->assoc_rsp_size = 0;
+        return mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_ASSOCIATE,
+                                    HostCmd_ACT_GEN_SET, 0, bss_desc);
+}
+/*
+ * This function starts an ad-hoc network.
+ *
+ * It calls the command preparation routine to send the command to firmware.
+ */
+int
+mwifiex_adhoc_start(struct mwifiex_private *priv,
+                    struct mwifiex_802_11_ssid *adhoc_ssid)
+{
+        dev_dbg(priv->adapter->dev, "info: Adhoc Channel = %d\n",
+                priv->adhoc_channel);
+        dev_dbg(priv->adapter->dev, "info: curr_bss_params.channel = %d\n",
+               priv->curr_bss_params.bss_descriptor.channel);
+        dev_dbg(priv->adapter->dev, "info: curr_bss_params.band = %d\n",
+               priv->curr_bss_params.band);
+        return mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_AD_HOC_START,
+                                    HostCmd_ACT_GEN_SET, 0, adhoc_ssid);
+}
+/*
+ * This function joins an ad-hoc network found in a previous scan.
+ *
+ * It calls the command preparation routine to send the command to firmware,
+ * if already not connected to the requested SSID.
+ */
+int mwifiex_adhoc_join(struct mwifiex_private *priv,
+                       struct mwifiex_bssdescriptor *bss_desc)
+{
+        dev_dbg(priv->adapter->dev, "info: adhoc join: curr_bss ssid =%s\n",
+               priv->curr_bss_params.bss_descriptor.ssid.ssid);
+        dev_dbg(priv->adapter->dev, "info: adhoc join: curr_bss ssid_len =%u\n",
+               priv->curr_bss_params.bss_descriptor.ssid.ssid_len);
+        dev_dbg(priv->adapter->dev, "info: adhoc join: ssid =%s\n",
+                bss_desc->ssid.ssid);
+        dev_dbg(priv->adapter->dev, "info: adhoc join: ssid_len =%u\n",
+               bss_desc->ssid.ssid_len);
+        /* Check if the requested SSID is already joined */
+        if (priv->curr_bss_params.bss_descriptor.ssid.ssid_len &&
+            !mwifiex_ssid_cmp(&bss_desc->ssid,
+                              &priv->curr_bss_params.bss_descriptor.ssid) &&
+            (priv->curr_bss_params.bss_descriptor.bss_mode ==
+                                                        NL80211_IFTYPE_ADHOC)) {
+                dev_dbg(priv->adapter->dev, "info: ADHOC_J_CMD: new ad-hoc SSID"
+                        " is the same as current; not attempting to re-join\n");
+                return -1;
+        }
+        dev_dbg(priv->adapter->dev, "info: curr_bss_params.channel = %d\n",
+               priv->curr_bss_params.bss_descriptor.channel);
+        dev_dbg(priv->adapter->dev, "info: curr_bss_params.band = %c\n",
+               priv->curr_bss_params.band);
+        return mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_AD_HOC_JOIN,
+                                    HostCmd_ACT_GEN_SET, 0, bss_desc);
+}
+/*
+ * This function deauthenticates/disconnects from infra network by sending
+ * deauthentication request.
+ */
+static int mwifiex_deauthenticate_infra(struct mwifiex_private *priv, u8 *mac)
+{
+        u8 mac_address[ETH_ALEN];
+        int ret;
+        u8 zero_mac[ETH_ALEN] = { 0, 0, 0, 0, 0, 0 };
+        if (mac) {
+                if (!memcmp(mac, zero_mac, sizeof(zero_mac)))
+                        memcpy((u8 *) &mac_address,
+                               (u8 *) &priv->curr_bss_params.bss_descriptor.
+                               mac_address, ETH_ALEN);
+                else
+                        memcpy((u8 *) &mac_address, (u8 *) mac, ETH_ALEN);
+        } else {
+                memcpy((u8 *) &mac_address, (u8 *) &priv->curr_bss_params.
+                       bss_descriptor.mac_address, ETH_ALEN);
+        }
+        ret = mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_DEAUTHENTICATE,
+                                    HostCmd_ACT_GEN_SET, 0, &mac_address);
+        return ret;
+}
+/*
+ * This function deauthenticates/disconnects from a BSS.
+ *
+ * In case of infra made, it sends deauthentication request, and
+ * in case of ad-hoc mode, a stop network request is sent to the firmware.
+ */
+int mwifiex_deauthenticate(struct mwifiex_private *priv, u8 *mac)
+{
+        int ret = 0;
+        if (priv->media_connected) {
+                if (priv->bss_mode == NL80211_IFTYPE_STATION) {
+                        ret = mwifiex_deauthenticate_infra(priv, mac);
+                } else if (priv->bss_mode == NL80211_IFTYPE_ADHOC) {
+                        ret = mwifiex_send_cmd_sync(priv,
+                                                HostCmd_CMD_802_11_AD_HOC_STOP,
+                                                HostCmd_ACT_GEN_SET, 0, NULL);
+                }
+        }
+        return ret;
+}
+EXPORT_SYMBOL_GPL(mwifiex_deauthenticate);
+/*
+ * This function converts band to radio type used in channel TLV.
+ */
+u8
+mwifiex_band_to_radio_type(u8 band)
+{
+        switch (band) {
+        case BAND_A:
+        case BAND_AN:
+        case BAND_A | BAND_AN:
+                return HostCmd_SCAN_RADIO_TYPE_A;
+        case BAND_B:
+        case BAND_G:
+        case BAND_B | BAND_G:
+        default:
+                return HostCmd_SCAN_RADIO_TYPE_BG;
+        }
+}
diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
new file mode 100644
index 000000000000..f0582259c935
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/main.c
@@ -0,0 +1,1055 @@
+/*
+ * Marvell Wireless LAN device driver: major functions
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "main.h"
+#include "wmm.h"
+#include "cfg80211.h"
+#include "11n.h"
+#define VERSION "1.0"
+const char driver_version[] = "mwifiex " VERSION " (%s) ";
+struct mwifiex_adapter *g_adapter;
+EXPORT_SYMBOL_GPL(g_adapter);
+static struct mwifiex_bss_attr mwifiex_bss_sta[] = {
+        {MWIFIEX_BSS_TYPE_STA, MWIFIEX_DATA_FRAME_TYPE_ETH_II, true, 0, 0},
+};
+static int drv_mode = DRV_MODE_STA;
+static char fw_name[32] = DEFAULT_FW_NAME;
+/* Supported drv_mode table */
+static struct mwifiex_drv_mode mwifiex_drv_mode_tbl[] = {
+        {
+                .drv_mode = DRV_MODE_STA,
+                .intf_num = ARRAY_SIZE(mwifiex_bss_sta),
+                .bss_attr = mwifiex_bss_sta,
+        },
+};
+/*
+ * This function registers the device and performs all the necessary
+ * initializations.
+ *
+ * The following initialization operations are performed -
+ *      - Allocate adapter structure
+ *      - Save interface specific operations table in adapter
+ *      - Call interface specific initialization routine
+ *      - Allocate private structures
+ *      - Set default adapter structure parameters
+ *      - Initialize locks
+ *
+ * In case of any errors during inittialization, this function also ensures
+ * proper cleanup before exiting.
+ */
+static int mwifiex_register(void *card, struct mwifiex_if_ops *if_ops,
+                            struct mwifiex_drv_mode *drv_mode_ptr)
+{
+        struct mwifiex_adapter *adapter;
+        int i;
+        adapter = kzalloc(sizeof(struct mwifiex_adapter), GFP_KERNEL);
+        if (!adapter)
+                return -ENOMEM;
+        g_adapter = adapter;
+        adapter->card = card;
+        /* Save interface specific operations in adapter */
+        memmove(&adapter->if_ops, if_ops, sizeof(struct mwifiex_if_ops));
+        /* card specific initialization has been deferred until now .. */
+        if (adapter->if_ops.init_if(adapter))
+                goto error;
+        adapter->priv_num = 0;
+        for (i = 0; i < drv_mode_ptr->intf_num; i++) {
+                adapter->priv[i] = NULL;
+                if (!drv_mode_ptr->bss_attr[i].active)
+                        continue;
+                /* Allocate memory for private structure */
+                adapter->priv[i] = kzalloc(sizeof(struct mwifiex_private),
+                                GFP_KERNEL);
+                if (!adapter->priv[i]) {
+                        dev_err(adapter->dev, "%s: failed to alloc priv[%d]\n",
+                               __func__, i);
+                        goto error;
+                }
+                adapter->priv_num++;
+                adapter->priv[i]->adapter = adapter;
+                /* Save bss_type, frame_type & bss_priority */
+                adapter->priv[i]->bss_type = drv_mode_ptr->bss_attr[i].bss_type;
+                adapter->priv[i]->frame_type =
+                                        drv_mode_ptr->bss_attr[i].frame_type;
+                adapter->priv[i]->bss_priority =
+                                        drv_mode_ptr->bss_attr[i].bss_priority;
+                if (drv_mode_ptr->bss_attr[i].bss_type == MWIFIEX_BSS_TYPE_STA)
+                        adapter->priv[i]->bss_role = MWIFIEX_BSS_ROLE_STA;
+                else if (drv_mode_ptr->bss_attr[i].bss_type ==
+                                                        MWIFIEX_BSS_TYPE_UAP)
+                        adapter->priv[i]->bss_role = MWIFIEX_BSS_ROLE_UAP;
+                /* Save bss_index & bss_num */
+                adapter->priv[i]->bss_index = i;
+                adapter->priv[i]->bss_num = drv_mode_ptr->bss_attr[i].bss_num;
+        }
+        adapter->drv_mode = drv_mode_ptr;
+        if (mwifiex_init_lock_list(adapter))
+                goto error;
+        init_timer(&adapter->cmd_timer);
+        adapter->cmd_timer.function = mwifiex_cmd_timeout_func;
+        adapter->cmd_timer.data = (unsigned long) adapter;
+        return 0;
+error:
+        dev_dbg(adapter->dev, "info: leave mwifiex_register with error\n");
+        mwifiex_free_lock_list(adapter);
+        for (i = 0; i < drv_mode_ptr->intf_num; i++)
+                kfree(adapter->priv[i]);
+        kfree(adapter);
+        return -1;
+}
+/*
+ * This function unregisters the device and performs all the necessary
+ * cleanups.
+ *
+ * The following cleanup operations are performed -
+ *      - Free the timers
+ *      - Free beacon buffers
+ *      - Free private structures
+ *      - Free adapter structure
+ */
+static int mwifiex_unregister(struct mwifiex_adapter *adapter)
+{
+        s32 i;
+        del_timer(&adapter->cmd_timer);
+        /* Free private structures */
+        for (i = 0; i < adapter->priv_num; i++) {
+                if (adapter->priv[i]) {
+                        mwifiex_free_curr_bcn(adapter->priv[i]);
+                        kfree(adapter->priv[i]);
+                }
+        }
+        kfree(adapter);
+        return 0;
+}
+/*
+ * The main process.
+ *
+ * This function is the main procedure of the driver and handles various driver
+ * operations. It runs in a loop and provides the core functionalities.
+ *
+ * The main responsibilities of this function are -
+ *      - Ensure concurrency control
+ *      - Handle pending interrupts and call interrupt handlers
+ *      - Wake up the card if required
+ *      - Handle command responses and call response handlers
+ *      - Handle events and call event handlers
+ *      - Execute pending commands
+ *      - Transmit pending data packets
+ */
+int mwifiex_main_process(struct mwifiex_adapter *adapter)
+{
+        int ret = 0;
+        unsigned long flags;
+        spin_lock_irqsave(&adapter->main_proc_lock, flags);
+        /* Check if already processing */
+        if (adapter->mwifiex_processing) {
+                spin_unlock_irqrestore(&adapter->main_proc_lock, flags);
+                goto exit_main_proc;
+        } else {
+                adapter->mwifiex_processing = true;
+                spin_unlock_irqrestore(&adapter->main_proc_lock, flags);
+        }
+process_start:
+        do {
+                if ((adapter->hw_status == MWIFIEX_HW_STATUS_CLOSING) ||
+                    (adapter->hw_status == MWIFIEX_HW_STATUS_NOT_READY))
+                        break;
+                /* Handle pending interrupt if any */
+                if (adapter->int_status) {
+                        if (adapter->hs_activated)
+                                mwifiex_process_hs_config(adapter);
+                        adapter->if_ops.process_int_status(adapter);
+                }
+                /* Need to wake up the card ? */
+                if ((adapter->ps_state == PS_STATE_SLEEP) &&
+                    (adapter->pm_wakeup_card_req &&
+                     !adapter->pm_wakeup_fw_try) &&
+                    (is_command_pending(adapter)
+                     || !mwifiex_wmm_lists_empty(adapter))) {
+                        adapter->pm_wakeup_fw_try = true;
+                        adapter->if_ops.wakeup(adapter);
+                        continue;
+                }
+                if (IS_CARD_RX_RCVD(adapter)) {
+                        adapter->pm_wakeup_fw_try = false;
+                        if (adapter->ps_state == PS_STATE_SLEEP)
+                                adapter->ps_state = PS_STATE_AWAKE;
+                } else {
+                        /* We have tried to wakeup the card already */
+                        if (adapter->pm_wakeup_fw_try)
+                                break;
+                        if (adapter->ps_state != PS_STATE_AWAKE ||
+                            adapter->tx_lock_flag)
+                                break;
+                        if (adapter->scan_processing || adapter->data_sent
+                            || mwifiex_wmm_lists_empty(adapter)) {
+                                if (adapter->cmd_sent || adapter->curr_cmd
+                                    || (!is_command_pending(adapter)))
+                                        break;
+                        }
+                }
+                /* Check for Cmd Resp */
+                if (adapter->cmd_resp_received) {
+                        adapter->cmd_resp_received = false;
+                        mwifiex_process_cmdresp(adapter);
+                        /* call mwifiex back when init_fw is done */
+                        if (adapter->hw_status == MWIFIEX_HW_STATUS_INIT_DONE) {
+                                adapter->hw_status = MWIFIEX_HW_STATUS_READY;
+                                mwifiex_init_fw_complete(adapter);
+                        }
+                }
+                /* Check for event */
+                if (adapter->event_received) {
+                        adapter->event_received = false;
+                        mwifiex_process_event(adapter);
+                }
+                /* Check if we need to confirm Sleep Request
+                   received previously */
+                if (adapter->ps_state == PS_STATE_PRE_SLEEP) {
+                        if (!adapter->cmd_sent && !adapter->curr_cmd)
+                                mwifiex_check_ps_cond(adapter);
+                }
+                /* * The ps_state may have been changed during processing of
+                 * Sleep Request event.
+                 */
+                if ((adapter->ps_state == PS_STATE_SLEEP)
+                    || (adapter->ps_state == PS_STATE_PRE_SLEEP)
+                    || (adapter->ps_state == PS_STATE_SLEEP_CFM)
+                    || adapter->tx_lock_flag)
+                        continue;
+                if (!adapter->cmd_sent && !adapter->curr_cmd) {
+                        if (mwifiex_exec_next_cmd(adapter) == -1) {
+                                ret = -1;
+                                break;
+                        }
+                }
+                if (!adapter->scan_processing && !adapter->data_sent &&
+                    !mwifiex_wmm_lists_empty(adapter)) {
+                        mwifiex_wmm_process_tx(adapter);
+                        if (adapter->hs_activated) {
+                                adapter->is_hs_configured = false;
+                                mwifiex_hs_activated_event
+                                        (mwifiex_get_priv
+                                         (adapter, MWIFIEX_BSS_ROLE_ANY),
+                                         false);
+                        }
+                }
+                if (adapter->delay_null_pkt && !adapter->cmd_sent &&
+                    !adapter->curr_cmd && !is_command_pending(adapter)
+                    && mwifiex_wmm_lists_empty(adapter)) {
+                        if (!mwifiex_send_null_packet
+                            (mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_STA),
+                             MWIFIEX_TxPD_POWER_MGMT_NULL_PACKET |
+                             MWIFIEX_TxPD_POWER_MGMT_LAST_PACKET)) {
+                                adapter->delay_null_pkt = false;
+                                adapter->ps_state = PS_STATE_SLEEP;
+                        }
+                        break;
+                }
+        } while (true);
+        if ((adapter->int_status) || IS_CARD_RX_RCVD(adapter))
+                goto process_start;
+        spin_lock_irqsave(&adapter->main_proc_lock, flags);
+        adapter->mwifiex_processing = false;
+        spin_unlock_irqrestore(&adapter->main_proc_lock, flags);
+exit_main_proc:
+        if (adapter->hw_status == MWIFIEX_HW_STATUS_CLOSING)
+                mwifiex_shutdown_drv(adapter);
+        return ret;
+}
+/*
+ * This function initializes the software.
+ *
+ * The main work includes allocating and initializing the adapter structure
+ * and initializing the private structures.
+ */
+static int
+mwifiex_init_sw(void *card, struct mwifiex_if_ops *if_ops)
+{
+        int i;
+        struct mwifiex_drv_mode *drv_mode_ptr;
+        /* find mwifiex_drv_mode entry from mwifiex_drv_mode_tbl */
+        drv_mode_ptr = NULL;
+        for (i = 0; i < ARRAY_SIZE(mwifiex_drv_mode_tbl); i++) {
+                if (mwifiex_drv_mode_tbl[i].drv_mode == drv_mode) {
+                        drv_mode_ptr = &mwifiex_drv_mode_tbl[i];
+                        break;
+                }
+        }
+        if (!drv_mode_ptr) {
+                pr_err("invalid drv_mode=%d\n", drv_mode);
+                return -1;
+        }
+        if (mwifiex_register(card, if_ops, drv_mode_ptr))
+                return -1;
+        return 0;
+}
+/*
+ * This function frees the adapter structure.
+ *
+ * Additionally, this closes the netlink socket, frees the timers
+ * and private structures.
+ */
+static void mwifiex_free_adapter(struct mwifiex_adapter *adapter)
+{
+        if (!adapter) {
+                pr_err("%s: adapter is NULL\n", __func__);
+                return;
+        }
+        mwifiex_unregister(adapter);
+        pr_debug("info: %s: free adapter\n", __func__);
+}
+/*
+ * This function initializes the hardware and firmware.
+ *
+ * The main initialization steps followed are -
+ *      - Download the correct firmware to card
+ *      - Allocate and initialize the adapter structure
+ *      - Initialize the private structures
+ *      - Issue the init commands to firmware
+ */
+static int mwifiex_init_hw_fw(struct mwifiex_adapter *adapter)
+{
+        int ret, err;
+        struct mwifiex_fw_image fw;
+        memset(&fw, 0, sizeof(struct mwifiex_fw_image));
+        switch (adapter->revision_id) {
+        case SD8787_W0:
+        case SD8787_W1:
+                strcpy(fw_name, SD8787_W1_FW_NAME);
+                break;
+        case SD8787_A0:
+        case SD8787_A1:
+                strcpy(fw_name, SD8787_AX_FW_NAME);
+                break;
+        default:
+                break;
+        }
+        err = request_firmware(&adapter->firmware, fw_name, adapter->dev);
+        if (err < 0) {
+                dev_err(adapter->dev, "request_firmware() returned"
+                                " error code %#x\n", err);
+                ret = -1;
+                goto done;
+        }
+        fw.fw_buf = (u8 *) adapter->firmware->data;
+        fw.fw_len = adapter->firmware->size;
+        ret = mwifiex_dnld_fw(adapter, &fw);
+        if (ret == -1)
+                goto done;
+        dev_notice(adapter->dev, "WLAN FW is active\n");
+        adapter->init_wait_q_woken = false;
+        ret = mwifiex_init_fw(adapter);
+        if (ret == -1) {
+                goto done;
+        } else if (!ret) {
+                adapter->hw_status = MWIFIEX_HW_STATUS_READY;
+                goto done;
+        }
+        /* Wait for mwifiex_init to complete */
+        wait_event_interruptible(adapter->init_wait_q,
+                                 adapter->init_wait_q_woken);
+        if (adapter->hw_status != MWIFIEX_HW_STATUS_READY) {
+                ret = -1;
+                goto done;
+        }
+        ret = 0;
+done:
+        if (adapter->firmware)
+                release_firmware(adapter->firmware);
+        if (ret)
+                ret = -1;
+        return ret;
+}
+/*
+ * This function fills a driver buffer.
+ *
+ * The function associates a given SKB with the provided driver buffer
+ * and also updates some of the SKB parameters, including IP header,
+ * priority and timestamp.
+ */
+static void
+mwifiex_fill_buffer(struct sk_buff *skb)
+{
+        struct ethhdr *eth;
+        struct iphdr *iph;
+        struct timeval tv;
+        u8 tid = 0;
+        eth = (struct ethhdr *) skb->data;
+        switch (eth->h_proto) {
+        case __constant_htons(ETH_P_IP):
+                iph = ip_hdr(skb);
+                tid = IPTOS_PREC(iph->tos);
+                pr_debug("data: packet type ETH_P_IP: %04x, tid=%#x prio=%#x\n",
+                       eth->h_proto, tid, skb->priority);
+                break;
+        case __constant_htons(ETH_P_ARP):
+                pr_debug("data: ARP packet: %04x\n", eth->h_proto);
+        default:
+                break;
+        }
+/* Offset for TOS field in the IP header */
+#define IPTOS_OFFSET 5
+        tid = (tid >> IPTOS_OFFSET);
+        skb->priority = tid;
+        /* Record the current time the packet was queued; used to
+           determine the amount of time the packet was queued in
+           the driver before it was sent to the firmware.
+           The delay is then sent along with the packet to the
+           firmware for aggregate delay calculation for stats and
+           MSDU lifetime expiry.
+         */
+        do_gettimeofday(&tv);
+        skb->tstamp = timeval_to_ktime(tv);
+}
+/*
+ * CFG802.11 network device handler for open.
+ *
+ * Starts the data queue.
+ */
+static int
+mwifiex_open(struct net_device *dev)
+{
+        netif_start_queue(dev);
+        return 0;
+}
+/*
+ * CFG802.11 network device handler for close.
+ */
+static int
+mwifiex_close(struct net_device *dev)
+{
+        return 0;
+}
+/*
+ * CFG802.11 network device handler for data transmission.
+ */
+static int
+mwifiex_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
+{
+        struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
+        struct sk_buff *new_skb;
+        struct mwifiex_txinfo *tx_info;
+        dev_dbg(priv->adapter->dev, "data: %lu BSS(%d): Data <= kernel\n",
+                                jiffies, priv->bss_index);
+        if (priv->adapter->surprise_removed) {
+                kfree_skb(skb);
+                priv->stats.tx_dropped++;
+                return 0;
+        }
+        if (!skb->len || (skb->len > ETH_FRAME_LEN)) {
+                dev_err(priv->adapter->dev, "Tx: bad skb len %d\n", skb->len);
+                kfree_skb(skb);
+                priv->stats.tx_dropped++;
+                return 0;
+        }
+        if (skb_headroom(skb) < MWIFIEX_MIN_DATA_HEADER_LEN) {
+                dev_dbg(priv->adapter->dev,
+                        "data: Tx: insufficient skb headroom %d\n",
+                       skb_headroom(skb));
+                /* Insufficient skb headroom - allocate a new skb */
+                new_skb =
+                        skb_realloc_headroom(skb, MWIFIEX_MIN_DATA_HEADER_LEN);
+                if (unlikely(!new_skb)) {
+                        dev_err(priv->adapter->dev, "Tx: cannot alloca new_skb\n");
+                        kfree_skb(skb);
+                        priv->stats.tx_dropped++;
+                        return 0;
+                }
+                kfree_skb(skb);
+                skb = new_skb;
+                dev_dbg(priv->adapter->dev, "info: new skb headroomd %d\n",
+                                skb_headroom(skb));
+        }
+        tx_info = MWIFIEX_SKB_TXCB(skb);
+        tx_info->bss_index = priv->bss_index;
+        mwifiex_fill_buffer(skb);
+        mwifiex_wmm_add_buf_txqueue(priv->adapter, skb);
+        atomic_inc(&priv->adapter->tx_pending);
+        if (atomic_read(&priv->adapter->tx_pending) >= MAX_TX_PENDING) {
+                netif_stop_queue(priv->netdev);
+                dev->trans_start = jiffies;
+        }
+        queue_work(priv->adapter->workqueue, &priv->adapter->main_work);
+        return 0;
+}
+/*
+ * CFG802.11 network device handler for setting MAC address.
+ */
+static int
+mwifiex_set_mac_address(struct net_device *dev, void *addr)
+{
+        struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
+        struct sockaddr *hw_addr = (struct sockaddr *) addr;
+        int ret;
+        memcpy(priv->curr_addr, hw_addr->sa_data, ETH_ALEN);
+        /* Send request to firmware */
+        ret = mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_MAC_ADDRESS,
+                                    HostCmd_ACT_GEN_SET, 0, NULL);
+        if (!ret)
+                memcpy(priv->netdev->dev_addr, priv->curr_addr, ETH_ALEN);
+        else
+                dev_err(priv->adapter->dev, "set mac address failed: ret=%d"
+                                            "\n", ret);
+        memcpy(dev->dev_addr, priv->curr_addr, ETH_ALEN);
+        return ret;
+}
+/*
+ * CFG802.11 network device handler for setting multicast list.
+ */
+static void mwifiex_set_multicast_list(struct net_device *dev)
+{
+        struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
+        struct mwifiex_multicast_list mcast_list;
+        if (dev->flags & IFF_PROMISC) {
+                mcast_list.mode = MWIFIEX_PROMISC_MODE;
+        } else if (dev->flags & IFF_ALLMULTI ||
+                   netdev_mc_count(dev) > MWIFIEX_MAX_MULTICAST_LIST_SIZE) {
+                mcast_list.mode = MWIFIEX_ALL_MULTI_MODE;
+        } else {
+                mcast_list.mode = MWIFIEX_MULTICAST_MODE;
+                if (netdev_mc_count(dev))
+                        mcast_list.num_multicast_addr =
+                                mwifiex_copy_mcast_addr(&mcast_list, dev);
+        }
+        mwifiex_request_set_multicast_list(priv, &mcast_list);
+}
+/*
+ * CFG802.11 network device handler for transmission timeout.
+ */
+static void
+mwifiex_tx_timeout(struct net_device *dev)
+{
+        struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
+        dev_err(priv->adapter->dev, "%lu : Tx timeout, bss_index=%d\n",
+                                jiffies, priv->bss_index);
+        dev->trans_start = jiffies;
+        priv->num_tx_timeout++;
+}
+/*
+ * CFG802.11 network device handler for statistics retrieval.
+ */
+static struct net_device_stats *mwifiex_get_stats(struct net_device *dev)
+{
+        struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
+        return &priv->stats;
+}
+/* Network device handlers */
+static const struct net_device_ops mwifiex_netdev_ops = {
+        .ndo_open = mwifiex_open,
+        .ndo_stop = mwifiex_close,
+        .ndo_start_xmit = mwifiex_hard_start_xmit,
+        .ndo_set_mac_address = mwifiex_set_mac_address,
+        .ndo_tx_timeout = mwifiex_tx_timeout,
+        .ndo_get_stats = mwifiex_get_stats,
+        .ndo_set_multicast_list = mwifiex_set_multicast_list,
+};
+/*
+ * This function initializes the private structure parameters.
+ *
+ * The following wait queues are initialized -
+ *      - IOCTL wait queue
+ *      - Command wait queue
+ *      - Statistics wait queue
+ *
+ * ...and the following default parameters are set -
+ *      - Current key index     : Set to 0
+ *      - Rate index            : Set to auto
+ *      - Media connected       : Set to disconnected
+ *      - Adhoc link sensed     : Set to false
+ *      - Nick name             : Set to null
+ *      - Number of Tx timeout  : Set to 0
+ *      - Device address        : Set to current address
+ *
+ * In addition, the CFG80211 work queue is also created.
+ */
+static void
+mwifiex_init_priv_params(struct mwifiex_private *priv, struct net_device *dev)
+{
+        dev->netdev_ops = &mwifiex_netdev_ops;
+        /* Initialize private structure */
+        priv->current_key_index = 0;
+        priv->media_connected = false;
+        memset(&priv->nick_name, 0, sizeof(priv->nick_name));
+        priv->num_tx_timeout = 0;
+        priv->workqueue = create_singlethread_workqueue("cfg80211_wq");
+        INIT_WORK(&priv->cfg_workqueue, mwifiex_cfg80211_results);
+        memcpy(dev->dev_addr, priv->curr_addr, ETH_ALEN);
+}
+/*
+ * This function adds a new logical interface.
+ *
+ * It allocates, initializes and registers the interface by performing
+ * the following opearations -
+ *      - Allocate a new net device structure
+ *      - Assign device name
+ *      - Register the new device with CFG80211 subsystem
+ *      - Initialize semaphore and private structure
+ *      - Register the new device with kernel
+ *      - Create the complete debug FS structure if configured
+ */
+static struct mwifiex_private *mwifiex_add_interface(
+                        struct mwifiex_adapter *adapter,
+                        u8 bss_index, u8 bss_type)
+{
+        struct net_device *dev;
+        struct mwifiex_private *priv;
+        void *mdev_priv;
+        dev = alloc_netdev_mq(sizeof(struct mwifiex_private *), "mlan%d",
+                              ether_setup, 1);
+        if (!dev) {
+                dev_err(adapter->dev, "no memory available for netdevice\n");
+                goto error;
+        }
+        if (mwifiex_register_cfg80211(dev, adapter->priv[bss_index]->curr_addr,
+                                      adapter->priv[bss_index]) != 0) {
+                dev_err(adapter->dev, "cannot register netdevice with cfg80211\n");
+                goto error;
+        }
+        /* Save the priv pointer in netdev */
+        priv = adapter->priv[bss_index];
+        mdev_priv = netdev_priv(dev);
+        *((unsigned long *) mdev_priv) = (unsigned long) priv;
+        priv->netdev = dev;
+        sema_init(&priv->async_sem, 1);
+        priv->scan_pending_on_block = false;
+        mwifiex_init_priv_params(priv, dev);
+        SET_NETDEV_DEV(dev, adapter->dev);
+        /* Register network device */
+        if (register_netdev(dev)) {
+                dev_err(adapter->dev, "cannot register virtual network device\n");
+                goto error;
+        }
+        dev_dbg(adapter->dev, "info: %s: Marvell 802.11 Adapter\n", dev->name);
+#ifdef CONFIG_DEBUG_FS
+        mwifiex_dev_debugfs_init(priv);
+#endif
+        return priv;
+error:
+        if (dev)
+                free_netdev(dev);
+        return NULL;
+}
+/*
+ * This function removes a logical interface.
+ *
+ * It deregisters, resets and frees the interface by performing
+ * the following operations -
+ *      - Disconnect the device if connected, send wireless event to
+ *        notify applications.
+ *      - Remove the debug FS structure if configured
+ *      - Unregister the device from kernel
+ *      - Free the net device structure
+ *      - Cancel all works and destroy work queue
+ *      - Unregister and free the wireless device from CFG80211 subsystem
+ */
+static void
+mwifiex_remove_interface(struct mwifiex_adapter *adapter, u8 bss_index)
+{
+        struct net_device *dev;
+        struct mwifiex_private *priv = adapter->priv[bss_index];
+        if (!priv)
+                return;
+        dev = priv->netdev;
+        if (priv->media_connected)
+                priv->media_connected = false;
+#ifdef CONFIG_DEBUG_FS
+        mwifiex_dev_debugfs_remove(priv);
+#endif
+        /* Last reference is our one */
+        dev_dbg(adapter->dev, "info: %s: refcnt = %d\n",
+                                dev->name, netdev_refcnt_read(dev));
+        if (dev->reg_state == NETREG_REGISTERED)
+                unregister_netdev(dev);
+        /* Clear the priv in adapter */
+        priv->netdev = NULL;
+        if (dev)
+                free_netdev(dev);
+        cancel_work_sync(&priv->cfg_workqueue);
+        flush_workqueue(priv->workqueue);
+        destroy_workqueue(priv->workqueue);
+        wiphy_unregister(priv->wdev->wiphy);
+        wiphy_free(priv->wdev->wiphy);
+        kfree(priv->wdev);
+}
+/*
+ * This function check if command is pending.
+ */
+int is_command_pending(struct mwifiex_adapter *adapter)
+{
+        unsigned long flags;
+        int is_cmd_pend_q_empty;
+        spin_lock_irqsave(&adapter->cmd_pending_q_lock, flags);
+        is_cmd_pend_q_empty = list_empty(&adapter->cmd_pending_q);
+        spin_unlock_irqrestore(&adapter->cmd_pending_q_lock, flags);
+        return !is_cmd_pend_q_empty;
+}
+/*
+ * This function returns the correct private structure pointer based
+ * upon the BSS number.
+ */
+struct mwifiex_private *
+mwifiex_bss_index_to_priv(struct mwifiex_adapter *adapter, u8 bss_index)
+{
+        if (!adapter || (bss_index >= adapter->priv_num))
+                return NULL;
+        return adapter->priv[bss_index];
+}
+/*
+ * This is the main work queue function.
+ *
+ * It handles the main process, which in turn handles the complete
+ * driver operations.
+ */
+static void mwifiex_main_work_queue(struct work_struct *work)
+{
+        struct mwifiex_adapter *adapter =
+                container_of(work, struct mwifiex_adapter, main_work);
+        if (adapter->surprise_removed)
+                return;
+        mwifiex_main_process(adapter);
+}
+/*
+ * This function cancels all works in the queue and destroys
+ * the main workqueue.
+ */
+static void
+mwifiex_terminate_workqueue(struct mwifiex_adapter *adapter)
+{
+        flush_workqueue(adapter->workqueue);
+        destroy_workqueue(adapter->workqueue);
+        adapter->workqueue = NULL;
+}
+/*
+ * This function adds the card.
+ *
+ * This function follows the following major steps to set up the device -
+ *      - Initialize software. This includes probing the card, registering
+ *        the interface operations table, and allocating/initializing the
+ *        adapter structure
+ *      - Set up the netlink socket
+ *      - Create and start the main work queue
+ *      - Register the device
+ *      - Initialize firmware and hardware
+ *      - Add logical interfaces
+ */
+int
+mwifiex_add_card(void *card, struct semaphore *sem,
+                 struct mwifiex_if_ops *if_ops)
+{
+        int i;
+        struct mwifiex_adapter *adapter;
+        if (down_interruptible(sem))
+                goto exit_sem_err;
+        if (mwifiex_init_sw(card, if_ops)) {
+                pr_err("%s: software init failed\n", __func__);
+                goto err_init_sw;
+        }
+        adapter = g_adapter;
+        adapter->hw_status = MWIFIEX_HW_STATUS_INITIALIZING;
+        adapter->surprise_removed = false;
+        init_waitqueue_head(&adapter->init_wait_q);
+        adapter->is_suspended = false;
+        adapter->hs_activated = false;
+        init_waitqueue_head(&adapter->hs_activate_wait_q);
+        adapter->cmd_wait_q_required = false;
+        init_waitqueue_head(&adapter->cmd_wait_q.wait);
+        adapter->cmd_wait_q.condition = false;
+        adapter->cmd_wait_q.status = 0;
+        adapter->workqueue = create_workqueue("MWIFIEX_WORK_QUEUE");
+        if (!adapter->workqueue)
+                goto err_kmalloc;
+        INIT_WORK(&adapter->main_work, mwifiex_main_work_queue);
+        /* Register the device. Fill up the private data structure with relevant
+           information from the card and request for the required IRQ. */
+        if (adapter->if_ops.register_dev(adapter)) {
+                pr_err("%s: failed to register mwifiex device\n", __func__);
+                goto err_registerdev;
+        }
+        if (mwifiex_init_hw_fw(adapter)) {
+                pr_err("%s: firmware init failed\n", __func__);
+                goto err_init_fw;
+        }
+        /* Add interfaces */
+        for (i = 0; i < adapter->drv_mode->intf_num; i++) {
+                if (!mwifiex_add_interface(adapter, i,
+                                adapter->drv_mode->bss_attr[i].bss_type)) {
+                        goto err_add_intf;
+                }
+        }
+        up(sem);
+        return 0;
+err_add_intf:
+        for (i = 0; i < adapter->priv_num; i++)
+                mwifiex_remove_interface(adapter, i);
+err_init_fw:
+        pr_debug("info: %s: unregister device\n", __func__);
+        adapter->if_ops.unregister_dev(adapter);
+err_registerdev:
+        adapter->surprise_removed = true;
+        mwifiex_terminate_workqueue(adapter);
+err_kmalloc:
+        if ((adapter->hw_status == MWIFIEX_HW_STATUS_FW_READY) ||
+            (adapter->hw_status == MWIFIEX_HW_STATUS_READY)) {
+                pr_debug("info: %s: shutdown mwifiex\n", __func__);
+                adapter->init_wait_q_woken = false;
+                if (mwifiex_shutdown_drv(adapter) == -EINPROGRESS)
+                        wait_event_interruptible(adapter->init_wait_q,
+                                                 adapter->init_wait_q_woken);
+        }
+        mwifiex_free_adapter(adapter);
+err_init_sw:
+        up(sem);
+exit_sem_err:
+        return -1;
+}
+EXPORT_SYMBOL_GPL(mwifiex_add_card);
+/*
+ * This function removes the card.
+ *
+ * This function follows the following major steps to remove the device -
+ *      - Stop data traffic
+ *      - Shutdown firmware
+ *      - Remove the logical interfaces
+ *      - Terminate the work queue
+ *      - Unregister the device
+ *      - Free the adapter structure
+ */
+int mwifiex_remove_card(struct mwifiex_adapter *adapter, struct semaphore *sem)
+{
+        struct mwifiex_private *priv = NULL;
+        int i;
+        if (down_interruptible(sem))
+                goto exit_sem_err;
+        if (!adapter)
+                goto exit_remove;
+        adapter->surprise_removed = true;
+        /* Stop data */
+        for (i = 0; i < adapter->priv_num; i++) {
+                priv = adapter->priv[i];
+                if (priv) {
+                        if (!netif_queue_stopped(priv->netdev))
+                                netif_stop_queue(priv->netdev);
+                        if (netif_carrier_ok(priv->netdev))
+                                netif_carrier_off(priv->netdev);
+                }
+        }
+        dev_dbg(adapter->dev, "cmd: calling mwifiex_shutdown_drv...\n");
+        adapter->init_wait_q_woken = false;
+        if (mwifiex_shutdown_drv(adapter) == -EINPROGRESS)
+                wait_event_interruptible(adapter->init_wait_q,
+                                         adapter->init_wait_q_woken);
+        dev_dbg(adapter->dev, "cmd: mwifiex_shutdown_drv done\n");
+        if (atomic_read(&adapter->rx_pending) ||
+            atomic_read(&adapter->tx_pending) ||
+            atomic_read(&adapter->cmd_pending)) {
+                dev_err(adapter->dev, "rx_pending=%d, tx_pending=%d, "
+                       "cmd_pending=%d\n",
+                       atomic_read(&adapter->rx_pending),
+                       atomic_read(&adapter->tx_pending),
+                       atomic_read(&adapter->cmd_pending));
+        }
+        /* Remove interface */
+        for (i = 0; i < adapter->priv_num; i++)
+                mwifiex_remove_interface(adapter, i);
+        mwifiex_terminate_workqueue(adapter);
+        /* Unregister device */
+        dev_dbg(adapter->dev, "info: unregister device\n");
+        adapter->if_ops.unregister_dev(adapter);
+        /* Free adapter structure */
+        dev_dbg(adapter->dev, "info: free adapter\n");
+        mwifiex_free_adapter(adapter);
+exit_remove:
+        up(sem);
+exit_sem_err:
+        return 0;
+}
+EXPORT_SYMBOL_GPL(mwifiex_remove_card);
+/*
+ * This function initializes the module.
+ *
+ * The debug FS is also initialized if configured.
+ */
+static int
+mwifiex_init_module(void)
+{
+#ifdef CONFIG_DEBUG_FS
+        mwifiex_debugfs_init();
+#endif
+        return 0;
+}
+/*
+ * This function cleans up the module.
+ *
+ * The debug FS is removed if available.
+ */
+static void
+mwifiex_cleanup_module(void)
+{
+#ifdef CONFIG_DEBUG_FS
+        mwifiex_debugfs_remove();
+#endif
+}
+module_init(mwifiex_init_module);
+module_exit(mwifiex_cleanup_module);
+MODULE_AUTHOR("Marvell International Ltd.");
+MODULE_DESCRIPTION("Marvell WiFi-Ex Driver version " VERSION);
+MODULE_VERSION(VERSION);
+MODULE_LICENSE("GPL v2");
diff --git a/drivers/net/wireless/mwifiex/main.h b/drivers/net/wireless/mwifiex/main.h
new file mode 100644
index 000000000000..672701dc2721
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/main.h
@@ -0,0 +1,1004 @@
+/*
+ * Marvell Wireless LAN device driver: major data structures and prototypes
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef _MWIFIEX_MAIN_H_
+#define _MWIFIEX_MAIN_H_
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/sched.h>
+#include <linux/semaphore.h>
+#include <linux/ip.h>
+#include <linux/skbuff.h>
+#include <linux/if_arp.h>
+#include <linux/etherdevice.h>
+#include <net/sock.h>
+#include <net/lib80211.h>
+#include <linux/firmware.h>
+#include <linux/ctype.h>
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+extern const char driver_version[];
+extern struct mwifiex_adapter *g_adapter;
+enum {
+        MWIFIEX_ASYNC_CMD,
+        MWIFIEX_SYNC_CMD
+};
+#define DRV_MODE_STA       0x1
+#define SD8787_W0   0x30
+#define SD8787_W1   0x31
+#define SD8787_A0   0x40
+#define SD8787_A1   0x41
+#define DEFAULT_FW_NAME "mrvl/sd8787_uapsta.bin"
+#define SD8787_W1_FW_NAME "mrvl/sd8787_uapsta_w1.bin"
+#define SD8787_AX_FW_NAME "mrvl/sd8787_uapsta.bin"
+struct mwifiex_drv_mode {
+        u16 drv_mode;
+        u16 intf_num;
+        struct mwifiex_bss_attr *bss_attr;
+};
+#define MWIFIEX_DEFAULT_WATCHDOG_TIMEOUT        (5 * HZ)
+#define MWIFIEX_TIMER_10S                       10000
+#define MWIFIEX_TIMER_1S                        1000
+#define MAX_TX_PENDING      60
+#define MWIFIEX_UPLD_SIZE               (2312)
+#define MAX_EVENT_SIZE                  1024
+#define ARP_FILTER_MAX_BUF_SIZE         68
+#define MWIFIEX_KEY_BUFFER_SIZE                 16
+#define MWIFIEX_DEFAULT_LISTEN_INTERVAL 10
+#define MWIFIEX_MAX_REGION_CODE         7
+#define DEFAULT_BCN_AVG_FACTOR          8
+#define DEFAULT_DATA_AVG_FACTOR         8
+#define FIRST_VALID_CHANNEL                             0xff
+#define DEFAULT_AD_HOC_CHANNEL                  6
+#define DEFAULT_AD_HOC_CHANNEL_A                36
+#define DEFAULT_BCN_MISS_TIMEOUT                5
+#define MAX_SCAN_BEACON_BUFFER                  8000
+#define SCAN_BEACON_ENTRY_PAD                   6
+#define MWIFIEX_PASSIVE_SCAN_CHAN_TIME  200
+#define MWIFIEX_ACTIVE_SCAN_CHAN_TIME   200
+#define MWIFIEX_SPECIFIC_SCAN_CHAN_TIME 110
+#define SCAN_RSSI(RSSI)                                 (0x100 - ((u8)(RSSI)))
+#define MWIFIEX_MAX_TOTAL_SCAN_TIME     (MWIFIEX_TIMER_10S - MWIFIEX_TIMER_1S)
+#define RSN_GTK_OUI_OFFSET                              2
+#define MWIFIEX_OUI_NOT_PRESENT                 0
+#define MWIFIEX_OUI_PRESENT                             1
+#define IS_CARD_RX_RCVD(adapter) (adapter->cmd_resp_received || \
+                                        adapter->event_received || \
+                                        adapter->data_received)
+#define MWIFIEX_TYPE_CMD                                1
+#define MWIFIEX_TYPE_DATA                               0
+#define MWIFIEX_TYPE_EVENT                              3
+#define DBG_CMD_NUM                                             5
+#define MAX_BITMAP_RATES_SIZE                   10
+#define MAX_CHANNEL_BAND_BG     14
+#define MAX_FREQUENCY_BAND_BG   2484
+struct mwifiex_dbg {
+        u32 num_cmd_host_to_card_failure;
+        u32 num_cmd_sleep_cfm_host_to_card_failure;
+        u32 num_tx_host_to_card_failure;
+        u32 num_event_deauth;
+        u32 num_event_disassoc;
+        u32 num_event_link_lost;
+        u32 num_cmd_deauth;
+        u32 num_cmd_assoc_success;
+        u32 num_cmd_assoc_failure;
+        u32 num_tx_timeout;
+        u32 num_cmd_timeout;
+        u16 timeout_cmd_id;
+        u16 timeout_cmd_act;
+        u16 last_cmd_id[DBG_CMD_NUM];
+        u16 last_cmd_act[DBG_CMD_NUM];
+        u16 last_cmd_index;
+        u16 last_cmd_resp_id[DBG_CMD_NUM];
+        u16 last_cmd_resp_index;
+        u16 last_event[DBG_CMD_NUM];
+        u16 last_event_index;
+};
+enum MWIFIEX_HARDWARE_STATUS {
+        MWIFIEX_HW_STATUS_READY,
+        MWIFIEX_HW_STATUS_INITIALIZING,
+        MWIFIEX_HW_STATUS_FW_READY,
+        MWIFIEX_HW_STATUS_INIT_DONE,
+        MWIFIEX_HW_STATUS_RESET,
+        MWIFIEX_HW_STATUS_CLOSING,
+        MWIFIEX_HW_STATUS_NOT_READY
+};
+enum MWIFIEX_802_11_POWER_MODE {
+        MWIFIEX_802_11_POWER_MODE_CAM,
+        MWIFIEX_802_11_POWER_MODE_PSP
+};
+struct mwifiex_tx_param {
+        u32 next_pkt_len;
+};
+enum MWIFIEX_PS_STATE {
+        PS_STATE_AWAKE,
+        PS_STATE_PRE_SLEEP,
+        PS_STATE_SLEEP_CFM,
+        PS_STATE_SLEEP
+};
+struct mwifiex_add_ba_param {
+        u32 tx_win_size;
+        u32 rx_win_size;
+        u32 timeout;
+};
+struct mwifiex_tx_aggr {
+        u8 ampdu_user;
+        u8 ampdu_ap;
+        u8 amsdu;
+};
+struct mwifiex_ra_list_tbl {
+        struct list_head list;
+        struct sk_buff_head skb_head;
+        u8 ra[ETH_ALEN];
+        u32 total_pkts_size;
+        u32 is_11n_enabled;
+};
+struct mwifiex_tid_tbl {
+        struct list_head ra_list;
+        /* spin lock for tid table */
+        spinlock_t tid_tbl_lock;
+        struct mwifiex_ra_list_tbl *ra_list_curr;
+};
+#define WMM_HIGHEST_PRIORITY            7
+#define HIGH_PRIO_TID                           7
+#define LOW_PRIO_TID                            0
+struct mwifiex_wmm_desc {
+        struct mwifiex_tid_tbl tid_tbl_ptr[MAX_NUM_TID];
+        u32 packets_out[MAX_NUM_TID];
+        /* spin lock to protect ra_list */
+        spinlock_t ra_list_spinlock;
+        struct mwifiex_wmm_ac_status ac_status[IEEE80211_MAX_QUEUES];
+        enum mwifiex_wmm_ac_e ac_down_graded_vals[IEEE80211_MAX_QUEUES];
+        u32 drv_pkt_delay_max;
+        u8 queue_priority[IEEE80211_MAX_QUEUES];
+        u32 user_pri_pkt_tx_ctrl[WMM_HIGHEST_PRIORITY + 1];     /* UP: 0 to 7 */
+};
+struct mwifiex_802_11_security {
+        u8 wpa_enabled;
+        u8 wpa2_enabled;
+        u8 wapi_enabled;
+        u8 wapi_key_on;
+        enum MWIFIEX_802_11_WEP_STATUS wep_status;
+        u32 authentication_mode;
+        u32 encryption_mode;
+};
+struct ieee_types_header {
+        u8 element_id;
+        u8 len;
+} __packed;
+struct ieee_obss_scan_param {
+        u16 obss_scan_passive_dwell;
+        u16 obss_scan_active_dwell;
+        u16 bss_chan_width_trigger_scan_int;
+        u16 obss_scan_passive_total;
+        u16 obss_scan_active_total;
+        u16 bss_width_chan_trans_delay;
+        u16 obss_scan_active_threshold;
+} __packed;
+struct ieee_types_obss_scan_param {
+        struct ieee_types_header ieee_hdr;
+        struct ieee_obss_scan_param obss_scan;
+} __packed;
+#define MWIFIEX_SUPPORTED_RATES                 14
+#define MWIFIEX_SUPPORTED_RATES_EXT             32
+#define IEEE_MAX_IE_SIZE                        256
+struct ieee_types_vendor_specific {
+        struct ieee_types_vendor_header vend_hdr;
+        u8 data[IEEE_MAX_IE_SIZE - sizeof(struct ieee_types_vendor_header)];
+} __packed;
+struct ieee_types_generic {
+        struct ieee_types_header ieee_hdr;
+        u8 data[IEEE_MAX_IE_SIZE - sizeof(struct ieee_types_header)];
+} __packed;
+struct mwifiex_bssdescriptor {
+        u8 mac_address[ETH_ALEN];
+        struct mwifiex_802_11_ssid ssid;
+        u32 privacy;
+        s32 rssi;
+        u32 channel;
+        u32 freq;
+        u16 beacon_period;
+        u8 erp_flags;
+        u32 bss_mode;
+        u8 supported_rates[MWIFIEX_SUPPORTED_RATES];
+        u8 data_rates[MWIFIEX_SUPPORTED_RATES];
+        /* Network band.
+         * BAND_B(0x01): 'b' band
+         * BAND_G(0x02): 'g' band
+         * BAND_A(0X04): 'a' band
+         */
+        u16 bss_band;
+        u64 network_tsf;
+        u8 time_stamp[8];
+        union ieee_types_phy_param_set phy_param_set;
+        union ieee_types_ss_param_set ss_param_set;
+        u16 cap_info_bitmap;
+        struct ieee_types_wmm_parameter wmm_ie;
+        u8  disable_11n;
+        struct ieee80211_ht_cap *bcn_ht_cap;
+        u16 ht_cap_offset;
+        struct ieee80211_ht_info *bcn_ht_info;
+        u16 ht_info_offset;
+        u8 *bcn_bss_co_2040;
+        u16 bss_co_2040_offset;
+        u8 *bcn_ext_cap;
+        u16 ext_cap_offset;
+        struct ieee_types_obss_scan_param *bcn_obss_scan;
+        u16 overlap_bss_offset;
+        struct ieee_types_vendor_specific *bcn_wpa_ie;
+        u16 wpa_offset;
+        struct ieee_types_generic *bcn_rsn_ie;
+        u16 rsn_offset;
+        struct ieee_types_generic *bcn_wapi_ie;
+        u16 wapi_offset;
+        u8 *beacon_buf;
+        u32 beacon_buf_size;
+        u32 beacon_buf_size_max;
+};
+struct mwifiex_current_bss_params {
+        struct mwifiex_bssdescriptor bss_descriptor;
+        u8 wmm_enabled;
+        u8 wmm_uapsd_enabled;
+        u8 band;
+        u32 num_of_rates;
+        u8 data_rates[MWIFIEX_SUPPORTED_RATES];
+};
+struct mwifiex_sleep_params {
+        u16 sp_error;
+        u16 sp_offset;
+        u16 sp_stable_time;
+        u8 sp_cal_control;
+        u8 sp_ext_sleep_clk;
+        u16 sp_reserved;
+};
+struct mwifiex_sleep_period {
+        u16 period;
+        u16 reserved;
+};
+struct mwifiex_wep_key {
+        u32 length;
+        u32 key_index;
+        u32 key_length;
+        u8 key_material[MWIFIEX_KEY_BUFFER_SIZE];
+};
+#define MAX_REGION_CHANNEL_NUM  2
+struct mwifiex_chan_freq_power {
+        u16 channel;
+        u32 freq;
+        u16 max_tx_power;
+        u8 unsupported;
+};
+enum state_11d_t {
+        DISABLE_11D = 0,
+        ENABLE_11D = 1,
+};
+#define MWIFIEX_MAX_TRIPLET_802_11D             83
+struct mwifiex_802_11d_domain_reg {
+        u8 country_code[IEEE80211_COUNTRY_STRING_LEN];
+        u8 no_of_triplet;
+        struct ieee80211_country_ie_triplet
+                triplet[MWIFIEX_MAX_TRIPLET_802_11D];
+};
+struct mwifiex_vendor_spec_cfg_ie {
+        u16 mask;
+        u16 flag;
+        u8 ie[MWIFIEX_MAX_VSIE_LEN];
+};
+struct wps {
+        u8 session_enable;
+};
+struct mwifiex_adapter;
+struct mwifiex_private;
+struct mwifiex_private {
+        struct mwifiex_adapter *adapter;
+        u8 bss_index;
+        u8 bss_type;
+        u8 bss_role;
+        u8 bss_priority;
+        u8 bss_num;
+        u8 frame_type;
+        u8 curr_addr[ETH_ALEN];
+        u8 media_connected;
+        u32 num_tx_timeout;
+        struct net_device *netdev;
+        struct net_device_stats stats;
+        u16 curr_pkt_filter;
+        u32 bss_mode;
+        u32 pkt_tx_ctrl;
+        u16 tx_power_level;
+        u8 max_tx_power_level;
+        u8 min_tx_power_level;
+        u8 tx_rate;
+        u8 tx_htinfo;
+        u8 rxpd_htinfo;
+        u8 rxpd_rate;
+        u16 rate_bitmap;
+        u16 bitmap_rates[MAX_BITMAP_RATES_SIZE];
+        u32 data_rate;
+        u8 is_data_rate_auto;
+        u16 bcn_avg_factor;
+        u16 data_avg_factor;
+        s16 data_rssi_last;
+        s16 data_nf_last;
+        s16 data_rssi_avg;
+        s16 data_nf_avg;
+        s16 bcn_rssi_last;
+        s16 bcn_nf_last;
+        s16 bcn_rssi_avg;
+        s16 bcn_nf_avg;
+        struct mwifiex_bssdescriptor *attempted_bss_desc;
+        struct mwifiex_802_11_ssid prev_ssid;
+        u8 prev_bssid[ETH_ALEN];
+        struct mwifiex_current_bss_params curr_bss_params;
+        u16 beacon_period;
+        u16 listen_interval;
+        u16 atim_window;
+        u8 adhoc_channel;
+        u8 adhoc_is_link_sensed;
+        u8 adhoc_state;
+        struct mwifiex_802_11_security sec_info;
+        struct mwifiex_wep_key wep_key[NUM_WEP_KEYS];
+        u16 wep_key_curr_index;
+        u8 wpa_ie[256];
+        u8 wpa_ie_len;
+        u8 wpa_is_gtk_set;
+        struct host_cmd_ds_802_11_key_material aes_key;
+        u8 wapi_ie[256];
+        u8 wapi_ie_len;
+        u8 wmm_required;
+        u8 wmm_enabled;
+        u8 wmm_qosinfo;
+        struct mwifiex_wmm_desc wmm;
+        struct list_head tx_ba_stream_tbl_ptr;
+        /* spin lock for tx_ba_stream_tbl_ptr queue */
+        spinlock_t tx_ba_stream_tbl_lock;
+        struct mwifiex_tx_aggr aggr_prio_tbl[MAX_NUM_TID];
+        struct mwifiex_add_ba_param add_ba_param;
+        u16 rx_seq[MAX_NUM_TID];
+        struct list_head rx_reorder_tbl_ptr;
+        /* spin lock for rx_reorder_tbl_ptr queue */
+        spinlock_t rx_reorder_tbl_lock;
+        /* spin lock for Rx packets */
+        spinlock_t rx_pkt_lock;
+#define MWIFIEX_ASSOC_RSP_BUF_SIZE  500
+        u8 assoc_rsp_buf[MWIFIEX_ASSOC_RSP_BUF_SIZE];
+        u32 assoc_rsp_size;
+#define MWIFIEX_GENIE_BUF_SIZE      256
+        u8 gen_ie_buf[MWIFIEX_GENIE_BUF_SIZE];
+        u8 gen_ie_buf_len;
+        struct mwifiex_vendor_spec_cfg_ie vs_ie[MWIFIEX_MAX_VSIE_NUM];
+#define MWIFIEX_ASSOC_TLV_BUF_SIZE  256
+        u8 assoc_tlv_buf[MWIFIEX_ASSOC_TLV_BUF_SIZE];
+        u8 assoc_tlv_buf_len;
+        u8 *curr_bcn_buf;
+        u32 curr_bcn_size;
+        /* spin lock for beacon buffer */
+        spinlock_t curr_bcn_buf_lock;
+        struct wireless_dev *wdev;
+        struct mwifiex_chan_freq_power cfp;
+        char version_str[128];
+#ifdef CONFIG_DEBUG_FS
+        struct dentry *dfs_dev_dir;
+#endif
+        u8 nick_name[16];
+        struct iw_statistics w_stats;
+        u16 current_key_index;
+        struct semaphore async_sem;
+        u8 scan_pending_on_block;
+        u8 report_scan_result;
+        struct cfg80211_scan_request *scan_request;
+        int scan_result_status;
+        int assoc_request;
+        u16 assoc_result;
+        int ibss_join_request;
+        u16 ibss_join_result;
+        bool disconnect;
+        u8 cfg_bssid[6];
+        struct workqueue_struct *workqueue;
+        struct work_struct cfg_workqueue;
+        u8 country_code[IEEE80211_COUNTRY_STRING_LEN];
+        struct wps wps;
+        u8 scan_block;
+};
+enum mwifiex_ba_status {
+        BA_STREAM_NOT_SETUP = 0,
+        BA_STREAM_SETUP_INPROGRESS,
+        BA_STREAM_SETUP_COMPLETE
+};
+struct mwifiex_tx_ba_stream_tbl {
+        struct list_head list;
+        int tid;
+        u8 ra[ETH_ALEN];
+        enum mwifiex_ba_status ba_status;
+};
+struct mwifiex_rx_reorder_tbl;
+struct reorder_tmr_cnxt {
+        struct timer_list timer;
+        struct mwifiex_rx_reorder_tbl *ptr;
+        struct mwifiex_private *priv;
+};
+struct mwifiex_rx_reorder_tbl {
+        struct list_head list;
+        int tid;
+        u8 ta[ETH_ALEN];
+        int start_win;
+        int win_size;
+        void **rx_reorder_ptr;
+        struct reorder_tmr_cnxt timer_context;
+};
+struct mwifiex_bss_prio_node {
+        struct list_head list;
+        struct mwifiex_private *priv;
+};
+struct mwifiex_bss_prio_tbl {
+        struct list_head bss_prio_head;
+        /* spin lock for bss priority  */
+        spinlock_t bss_prio_lock;
+        struct mwifiex_bss_prio_node *bss_prio_cur;
+};
+struct cmd_ctrl_node {
+        struct list_head list;
+        struct mwifiex_private *priv;
+        u32 cmd_oid;
+        u32 cmd_flag;
+        struct sk_buff *cmd_skb;
+        struct sk_buff *resp_skb;
+        void *data_buf;
+        u32 wait_q_enabled;
+        struct sk_buff *skb;
+};
+struct mwifiex_if_ops {
+        int (*init_if) (struct mwifiex_adapter *);
+        void (*cleanup_if) (struct mwifiex_adapter *);
+        int (*check_fw_status) (struct mwifiex_adapter *, u32, int *);
+        int (*prog_fw) (struct mwifiex_adapter *, struct mwifiex_fw_image *);
+        int (*register_dev) (struct mwifiex_adapter *);
+        void (*unregister_dev) (struct mwifiex_adapter *);
+        int (*enable_int) (struct mwifiex_adapter *);
+        int (*process_int_status) (struct mwifiex_adapter *);
+        int (*host_to_card) (struct mwifiex_adapter *, u8,
+                             u8 *payload, u32 pkt_len,
+                             struct mwifiex_tx_param *);
+        int (*wakeup) (struct mwifiex_adapter *);
+        int (*wakeup_complete) (struct mwifiex_adapter *);
+        void (*update_mp_end_port) (struct mwifiex_adapter *, u16);
+        void (*cleanup_mpa_buf) (struct mwifiex_adapter *);
+};
+struct mwifiex_adapter {
+        struct mwifiex_private *priv[MWIFIEX_MAX_BSS_NUM];
+        u8 priv_num;
+        struct mwifiex_drv_mode *drv_mode;
+        const struct firmware *firmware;
+        struct device *dev;
+        bool surprise_removed;
+        u32 fw_release_number;
+        u32 revision_id;
+        u16 init_wait_q_woken;
+        wait_queue_head_t init_wait_q;
+        void *card;
+        struct mwifiex_if_ops if_ops;
+        atomic_t rx_pending;
+        atomic_t tx_pending;
+        atomic_t cmd_pending;
+        struct workqueue_struct *workqueue;
+        struct work_struct main_work;
+        struct mwifiex_bss_prio_tbl bss_prio_tbl[MWIFIEX_MAX_BSS_NUM];
+        /* spin lock for init/shutdown */
+        spinlock_t mwifiex_lock;
+        /* spin lock for main process */
+        spinlock_t main_proc_lock;
+        u32 mwifiex_processing;
+        u16 max_tx_buf_size;
+        u16 tx_buf_size;
+        u16 curr_tx_buf_size;
+        u32 ioport;
+        enum MWIFIEX_HARDWARE_STATUS hw_status;
+        u16 number_of_antenna;
+        u32 fw_cap_info;
+        /* spin lock for interrupt handling */
+        spinlock_t int_lock;
+        u8 int_status;
+        u32 event_cause;
+        struct sk_buff *event_skb;
+        u8 upld_buf[MWIFIEX_UPLD_SIZE];
+        u8 data_sent;
+        u8 cmd_sent;
+        u8 cmd_resp_received;
+        u8 event_received;
+        u8 data_received;
+        u16 seq_num;
+        struct cmd_ctrl_node *cmd_pool;
+        struct cmd_ctrl_node *curr_cmd;
+        /* spin lock for command */
+        spinlock_t mwifiex_cmd_lock;
+        u32 num_cmd_timeout;
+        u16 last_init_cmd;
+        struct timer_list cmd_timer;
+        struct list_head cmd_free_q;
+        /* spin lock for cmd_free_q */
+        spinlock_t cmd_free_q_lock;
+        struct list_head cmd_pending_q;
+        /* spin lock for cmd_pending_q */
+        spinlock_t cmd_pending_q_lock;
+        struct list_head scan_pending_q;
+        /* spin lock for scan_pending_q */
+        spinlock_t scan_pending_q_lock;
+        u32 scan_processing;
+        u16 region_code;
+        struct mwifiex_802_11d_domain_reg domain_reg;
+        struct mwifiex_bssdescriptor *scan_table;
+        u32 num_in_scan_table;
+        u16 scan_probes;
+        u32 scan_mode;
+        u16 specific_scan_time;
+        u16 active_scan_time;
+        u16 passive_scan_time;
+        u8 bcn_buf[MAX_SCAN_BEACON_BUFFER];
+        u8 *bcn_buf_end;
+        u8 fw_bands;
+        u8 adhoc_start_band;
+        u8 config_bands;
+        struct mwifiex_chan_scan_param_set *scan_channels;
+        u8 tx_lock_flag;
+        struct mwifiex_sleep_params sleep_params;
+        struct mwifiex_sleep_period sleep_period;
+        u16 ps_mode;
+        u32 ps_state;
+        u8 need_to_wakeup;
+        u16 multiple_dtim;
+        u16 local_listen_interval;
+        u16 null_pkt_interval;
+        struct sk_buff *sleep_cfm;
+        u16 bcn_miss_time_out;
+        u16 adhoc_awake_period;
+        u8 is_deep_sleep;
+        u8 delay_null_pkt;
+        u16 delay_to_ps;
+        u16 enhanced_ps_mode;
+        u8 pm_wakeup_card_req;
+        u16 gen_null_pkt;
+        u16 pps_uapsd_mode;
+        u32 pm_wakeup_fw_try;
+        u8 is_hs_configured;
+        struct mwifiex_hs_config_param hs_cfg;
+        u8 hs_activated;
+        u16 hs_activate_wait_q_woken;
+        wait_queue_head_t hs_activate_wait_q;
+        bool is_suspended;
+        u8 event_body[MAX_EVENT_SIZE];
+        u32 hw_dot_11n_dev_cap;
+        u8 hw_dev_mcs_support;
+        u8 adhoc_11n_enabled;
+        u8 chan_offset;
+        struct mwifiex_dbg dbg;
+        u8 arp_filter[ARP_FILTER_MAX_BUF_SIZE];
+        u32 arp_filter_size;
+        u16 cmd_wait_q_required;
+        struct mwifiex_wait_queue cmd_wait_q;
+};
+int mwifiex_init_lock_list(struct mwifiex_adapter *adapter);
+void mwifiex_free_lock_list(struct mwifiex_adapter *adapter);
+int mwifiex_init_fw(struct mwifiex_adapter *adapter);
+int mwifiex_init_fw_complete(struct mwifiex_adapter *adapter);
+int mwifiex_shutdown_drv(struct mwifiex_adapter *adapter);
+int mwifiex_shutdown_fw_complete(struct mwifiex_adapter *adapter);
+int mwifiex_dnld_fw(struct mwifiex_adapter *, struct mwifiex_fw_image *);
+int mwifiex_recv_packet(struct mwifiex_adapter *, struct sk_buff *skb);
+int mwifiex_process_event(struct mwifiex_adapter *adapter);
+int mwifiex_complete_cmd(struct mwifiex_adapter *adapter);
+int mwifiex_send_cmd_async(struct mwifiex_private *priv, uint16_t cmd_no,
+                           u16 cmd_action, u32 cmd_oid, void *data_buf);
+int mwifiex_send_cmd_sync(struct mwifiex_private *priv, uint16_t cmd_no,
+                          u16 cmd_action, u32 cmd_oid, void *data_buf);
+void mwifiex_cmd_timeout_func(unsigned long function_context);
+int mwifiex_get_debug_info(struct mwifiex_private *,
+                           struct mwifiex_debug_info *);
+int mwifiex_alloc_cmd_buffer(struct mwifiex_adapter *adapter);
+int mwifiex_free_cmd_buffer(struct mwifiex_adapter *adapter);
+void mwifiex_cancel_all_pending_cmd(struct mwifiex_adapter *adapter);
+void mwifiex_cancel_pending_ioctl(struct mwifiex_adapter *adapter);
+void mwifiex_insert_cmd_to_free_q(struct mwifiex_adapter *adapter,
+                                  struct cmd_ctrl_node *cmd_node);
+void mwifiex_insert_cmd_to_pending_q(struct mwifiex_adapter *adapter,
+                                     struct cmd_ctrl_node *cmd_node,
+                                     u32 addtail);
+int mwifiex_exec_next_cmd(struct mwifiex_adapter *adapter);
+int mwifiex_process_cmdresp(struct mwifiex_adapter *adapter);
+int mwifiex_handle_rx_packet(struct mwifiex_adapter *adapter,
+                             struct sk_buff *skb);
+int mwifiex_process_tx(struct mwifiex_private *priv, struct sk_buff *skb,
+                       struct mwifiex_tx_param *tx_param);
+int mwifiex_send_null_packet(struct mwifiex_private *priv, u8 flags);
+int mwifiex_write_data_complete(struct mwifiex_adapter *adapter,
+                                struct sk_buff *skb, int status);
+int mwifiex_recv_packet_complete(struct mwifiex_adapter *,
+                                 struct sk_buff *skb, int status);
+void mwifiex_clean_txrx(struct mwifiex_private *priv);
+u8 mwifiex_check_last_packet_indication(struct mwifiex_private *priv);
+void mwifiex_check_ps_cond(struct mwifiex_adapter *adapter);
+void mwifiex_process_sleep_confirm_resp(struct mwifiex_adapter *, u8 *,
+                                        u32);
+int mwifiex_cmd_enh_power_mode(struct mwifiex_private *priv,
+                               struct host_cmd_ds_command *cmd,
+                               u16 cmd_action, uint16_t ps_bitmap,
+                               void *data_buf);
+int mwifiex_ret_enh_power_mode(struct mwifiex_private *priv,
+                               struct host_cmd_ds_command *resp,
+                               void *data_buf);
+void mwifiex_process_hs_config(struct mwifiex_adapter *adapter);
+void mwifiex_hs_activated_event(struct mwifiex_private *priv,
+                                        u8 activated);
+int mwifiex_ret_802_11_hs_cfg(struct mwifiex_private *priv,
+                              struct host_cmd_ds_command *resp);
+int mwifiex_process_rx_packet(struct mwifiex_adapter *adapter,
+                              struct sk_buff *skb);
+int mwifiex_sta_prepare_cmd(struct mwifiex_private *, uint16_t cmd_no,
+                            u16 cmd_action, u32 cmd_oid,
+                            void *data_buf, void *cmd_buf);
+int mwifiex_process_sta_cmdresp(struct mwifiex_private *, u16 cmdresp_no,
+                                void *cmd_buf);
+int mwifiex_process_sta_rx_packet(struct mwifiex_adapter *,
+                                  struct sk_buff *skb);
+int mwifiex_process_sta_event(struct mwifiex_private *);
+void *mwifiex_process_sta_txpd(struct mwifiex_private *, struct sk_buff *skb);
+int mwifiex_sta_init_cmd(struct mwifiex_private *, u8 first_sta);
+int mwifiex_scan_networks(struct mwifiex_private *priv,
+                          const struct mwifiex_user_scan_cfg *user_scan_in);
+int mwifiex_cmd_802_11_scan(struct host_cmd_ds_command *cmd,
+                            void *data_buf);
+void mwifiex_queue_scan_cmd(struct mwifiex_private *priv,
+                            struct cmd_ctrl_node *cmd_node);
+int mwifiex_ret_802_11_scan(struct mwifiex_private *priv,
+                            struct host_cmd_ds_command *resp);
+s32 mwifiex_find_ssid_in_list(struct mwifiex_private *priv,
+                                struct mwifiex_802_11_ssid *ssid, u8 *bssid,
+                                u32 mode);
+s32 mwifiex_find_bssid_in_list(struct mwifiex_private *priv, u8 *bssid,
+                                 u32 mode);
+int mwifiex_find_best_network(struct mwifiex_private *priv,
+                              struct mwifiex_ssid_bssid *req_ssid_bssid);
+s32 mwifiex_ssid_cmp(struct mwifiex_802_11_ssid *ssid1,
+                       struct mwifiex_802_11_ssid *ssid2);
+int mwifiex_associate(struct mwifiex_private *priv,
+                      struct mwifiex_bssdescriptor *bss_desc);
+int mwifiex_cmd_802_11_associate(struct mwifiex_private *priv,
+                                 struct host_cmd_ds_command
+                                 *cmd, void *data_buf);
+int mwifiex_ret_802_11_associate(struct mwifiex_private *priv,
+                                 struct host_cmd_ds_command *resp);
+void mwifiex_reset_connect_state(struct mwifiex_private *priv);
+void mwifiex_2040_coex_event(struct mwifiex_private *priv);
+u8 mwifiex_band_to_radio_type(u8 band);
+int mwifiex_deauthenticate(struct mwifiex_private *priv, u8 *mac);
+int mwifiex_adhoc_start(struct mwifiex_private *priv,
+                        struct mwifiex_802_11_ssid *adhoc_ssid);
+int mwifiex_adhoc_join(struct mwifiex_private *priv,
+                       struct mwifiex_bssdescriptor *bss_desc);
+int mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv,
+                                    struct host_cmd_ds_command *cmd,
+                                    void *data_buf);
+int mwifiex_cmd_802_11_ad_hoc_join(struct mwifiex_private *priv,
+                                   struct host_cmd_ds_command *cmd,
+                                   void *data_buf);
+int mwifiex_ret_802_11_ad_hoc(struct mwifiex_private *priv,
+                              struct host_cmd_ds_command *resp);
+int mwifiex_cmd_802_11_bg_scan_query(struct host_cmd_ds_command *cmd);
+struct mwifiex_chan_freq_power *
+                        mwifiex_get_cfp_by_band_and_channel_from_cfg80211(
+                                                struct mwifiex_private *priv,
+                                                u8 band, u16 channel);
+struct mwifiex_chan_freq_power *mwifiex_get_cfp_by_band_and_freq_from_cfg80211(
+                                                struct mwifiex_private *priv,
+                                                u8 band, u32 freq);
+u32 mwifiex_index_to_data_rate(u8 index, u8 ht_info);
+u32 mwifiex_find_freq_from_band_chan(u8, u8);
+int mwifiex_cmd_append_vsie_tlv(struct mwifiex_private *priv, u16 vsie_mask,
+                                u8 **buffer);
+u32 mwifiex_get_active_data_rates(struct mwifiex_private *priv,
+                                    u8 *rates);
+u32 mwifiex_get_supported_rates(struct mwifiex_private *priv, u8 *rates);
+u8 mwifiex_data_rate_to_index(u32 rate);
+u8 mwifiex_is_rate_auto(struct mwifiex_private *priv);
+int mwifiex_get_rate_index(u16 *rateBitmap, int size);
+extern u16 region_code_index[MWIFIEX_MAX_REGION_CODE];
+void mwifiex_save_curr_bcn(struct mwifiex_private *priv);
+void mwifiex_free_curr_bcn(struct mwifiex_private *priv);
+int mwifiex_cmd_get_hw_spec(struct mwifiex_private *priv,
+                            struct host_cmd_ds_command *cmd);
+int mwifiex_ret_get_hw_spec(struct mwifiex_private *priv,
+                            struct host_cmd_ds_command *resp);
+int is_command_pending(struct mwifiex_adapter *adapter);
+/*
+ * This function checks if the queuing is RA based or not.
+ */
+static inline u8
+mwifiex_queuing_ra_based(struct mwifiex_private *priv)
+{
+        /*
+         * Currently we assume if we are in Infra, then DA=RA. This might not be
+         * true in the future
+         */
+        if ((priv->bss_mode == NL80211_IFTYPE_STATION) &&
+            (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA))
+                return false;
+        return true;
+}
+/*
+ * This function copies rates.
+ */
+static inline u32
+mwifiex_copy_rates(u8 *dest, u32 pos, u8 *src, int len)
+{
+        int i;
+        for (i = 0; i < len && src[i]; i++, pos++) {
+                if (pos >= MWIFIEX_SUPPORTED_RATES)
+                        break;
+                dest[pos] = src[i];
+        }
+        return pos;
+}
+/*
+ * This function returns the correct private structure pointer based
+ * upon the BSS type and BSS number.
+ */
+static inline struct mwifiex_private *
+mwifiex_get_priv_by_id(struct mwifiex_adapter *adapter,
+                       u8 bss_num, u8 bss_type)
+{
+        int i;
+        for (i = 0; i < adapter->priv_num; i++) {
+                if (adapter->priv[i]) {
+                        if ((adapter->priv[i]->bss_num == bss_num)
+                            && (adapter->priv[i]->bss_type == bss_type))
+                                break;
+                }
+        }
+        return ((i < adapter->priv_num) ? adapter->priv[i] : NULL);
+}
+/*
+ * This function returns the first available private structure pointer
+ * based upon the BSS role.
+ */
+static inline struct mwifiex_private *
+mwifiex_get_priv(struct mwifiex_adapter *adapter,
+                 enum mwifiex_bss_role bss_role)
+{
+        int i;
+        for (i = 0; i < adapter->priv_num; i++) {
+                if (adapter->priv[i]) {
+                        if (bss_role == MWIFIEX_BSS_ROLE_ANY ||
+                            GET_BSS_ROLE(adapter->priv[i]) == bss_role)
+                                break;
+                }
+        }
+        return ((i < adapter->priv_num) ? adapter->priv[i] : NULL);
+}
+/*
+ * This function returns the driver private structure of a network device.
+ */
+static inline struct mwifiex_private *
+mwifiex_netdev_get_priv(struct net_device *dev)
+{
+        return (struct mwifiex_private *) (*(unsigned long *) netdev_priv(dev));
+}
+struct mwifiex_private *mwifiex_bss_index_to_priv(struct mwifiex_adapter
+                                                *adapter, u8 bss_index);
+int mwifiex_init_shutdown_fw(struct mwifiex_private *priv,
+                             u32 func_init_shutdown);
+int mwifiex_add_card(void *, struct semaphore *, struct mwifiex_if_ops *);
+int mwifiex_remove_card(struct mwifiex_adapter *, struct semaphore *);
+void mwifiex_get_version(struct mwifiex_adapter *adapter, char *version,
+                         int maxlen);
+int mwifiex_request_set_multicast_list(struct mwifiex_private *priv,
+                        struct mwifiex_multicast_list *mcast_list);
+int mwifiex_copy_mcast_addr(struct mwifiex_multicast_list *mlist,
+                            struct net_device *dev);
+int mwifiex_wait_queue_complete(struct mwifiex_adapter *adapter);
+int mwifiex_bss_start(struct mwifiex_private *priv,
+                      struct mwifiex_ssid_bssid *ssid_bssid);
+int mwifiex_set_hs_params(struct mwifiex_private *priv,
+                              u16 action, int cmd_type,
+                              struct mwifiex_ds_hs_cfg *hscfg);
+int mwifiex_cancel_hs(struct mwifiex_private *priv, int cmd_type);
+int mwifiex_enable_hs(struct mwifiex_adapter *adapter);
+int mwifiex_get_signal_info(struct mwifiex_private *priv,
+                            struct mwifiex_ds_get_signal *signal);
+int mwifiex_drv_get_data_rate(struct mwifiex_private *priv,
+                              struct mwifiex_rate_cfg *rate);
+int mwifiex_find_best_bss(struct mwifiex_private *priv,
+                          struct mwifiex_ssid_bssid *ssid_bssid);
+int mwifiex_request_scan(struct mwifiex_private *priv,
+                         struct mwifiex_802_11_ssid *req_ssid);
+int mwifiex_set_user_scan_ioctl(struct mwifiex_private *priv,
+                                struct mwifiex_user_scan_cfg *scan_req);
+int mwifiex_change_adhoc_chan(struct mwifiex_private *priv, int channel);
+int mwifiex_set_radio(struct mwifiex_private *priv, u8 option);
+int mwifiex_drv_change_adhoc_chan(struct mwifiex_private *priv, int channel);
+int mwifiex_set_encode(struct mwifiex_private *priv, const u8 *key,
+                       int key_len, u8 key_index, int disable);
+int mwifiex_set_gen_ie(struct mwifiex_private *priv, u8 *ie, int ie_len);
+int mwifiex_get_ver_ext(struct mwifiex_private *priv);
+int mwifiex_get_stats_info(struct mwifiex_private *priv,
+                           struct mwifiex_ds_get_stats *log);
+int mwifiex_reg_write(struct mwifiex_private *priv, u32 reg_type,
+                      u32 reg_offset, u32 reg_value);
+int mwifiex_reg_read(struct mwifiex_private *priv, u32 reg_type,
+                     u32 reg_offset, u32 *value);
+int mwifiex_eeprom_read(struct mwifiex_private *priv, u16 offset, u16 bytes,
+                        u8 *value);
+int mwifiex_set_11n_httx_cfg(struct mwifiex_private *priv, int data);
+int mwifiex_get_11n_httx_cfg(struct mwifiex_private *priv, int *data);
+int mwifiex_set_tx_rate_cfg(struct mwifiex_private *priv, int tx_rate_index);
+int mwifiex_get_tx_rate_cfg(struct mwifiex_private *priv, int *tx_rate_index);
+int mwifiex_drv_set_power(struct mwifiex_private *priv, u32 *ps_mode);
+int mwifiex_drv_get_driver_version(struct mwifiex_adapter *adapter,
+                                   char *version, int max_len);
+int mwifiex_set_tx_power(struct mwifiex_private *priv,
+                         struct mwifiex_power_cfg *power_cfg);
+int mwifiex_main_process(struct mwifiex_adapter *);
+int mwifiex_bss_set_channel(struct mwifiex_private *,
+                            struct mwifiex_chan_freq_power *cfp);
+int mwifiex_bss_ioctl_find_bss(struct mwifiex_private *,
+                               struct mwifiex_ssid_bssid *);
+int mwifiex_set_radio_band_cfg(struct mwifiex_private *,
+                         struct mwifiex_ds_band_cfg *);
+int mwifiex_get_bss_info(struct mwifiex_private *,
+                         struct mwifiex_bss_info *);
+#ifdef CONFIG_DEBUG_FS
+void mwifiex_debugfs_init(void);
+void mwifiex_debugfs_remove(void);
+void mwifiex_dev_debugfs_init(struct mwifiex_private *priv);
+void mwifiex_dev_debugfs_remove(struct mwifiex_private *priv);
+#endif
+#endif /* !_MWIFIEX_MAIN_H_ */
diff --git a/drivers/net/wireless/mwifiex/scan.c b/drivers/net/wireless/mwifiex/scan.c
new file mode 100644
index 000000000000..5c22860fb40a
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/scan.c
@@ -0,0 +1,3025 @@
+/*
+ * Marvell Wireless LAN device driver: scan ioctl and command handling
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "11n.h"
+#include "cfg80211.h"
+/* The maximum number of channels the firmware can scan per command */
+#define MWIFIEX_MAX_CHANNELS_PER_SPECIFIC_SCAN   14
+#define MWIFIEX_CHANNELS_PER_SCAN_CMD            4
+/* Memory needed to store a max sized Channel List TLV for a firmware scan */
+#define CHAN_TLV_MAX_SIZE  (sizeof(struct mwifiex_ie_types_header)         \
+                                + (MWIFIEX_MAX_CHANNELS_PER_SPECIFIC_SCAN     \
+                                *sizeof(struct mwifiex_chan_scan_param_set)))
+/* Memory needed to store supported rate */
+#define RATE_TLV_MAX_SIZE   (sizeof(struct mwifiex_ie_types_rates_param_set) \
+                                + HOSTCMD_SUPPORTED_RATES)
+/* Memory needed to store a max number/size WildCard SSID TLV for a firmware
+        scan */
+#define WILDCARD_SSID_TLV_MAX_SIZE  \
+        (MWIFIEX_MAX_SSID_LIST_LENGTH *                                 \
+                (sizeof(struct mwifiex_ie_types_wildcard_ssid_params)   \
+                        + IEEE80211_MAX_SSID_LEN))
+/* Maximum memory needed for a mwifiex_scan_cmd_config with all TLVs at max */
+#define MAX_SCAN_CFG_ALLOC (sizeof(struct mwifiex_scan_cmd_config)        \
+                                + sizeof(struct mwifiex_ie_types_num_probes)   \
+                                + sizeof(struct mwifiex_ie_types_htcap)       \
+                                + CHAN_TLV_MAX_SIZE                 \
+                                + RATE_TLV_MAX_SIZE                 \
+                                + WILDCARD_SSID_TLV_MAX_SIZE)
+union mwifiex_scan_cmd_config_tlv {
+        /* Scan configuration (variable length) */
+        struct mwifiex_scan_cmd_config config;
+        /* Max allocated block */
+        u8 config_alloc_buf[MAX_SCAN_CFG_ALLOC];
+};
+enum cipher_suite {
+        CIPHER_SUITE_TKIP,
+        CIPHER_SUITE_CCMP,
+        CIPHER_SUITE_MAX
+};
+static u8 mwifiex_wpa_oui[CIPHER_SUITE_MAX][4] = {
+        { 0x00, 0x50, 0xf2, 0x02 },     /* TKIP */
+        { 0x00, 0x50, 0xf2, 0x04 },     /* AES  */
+};
+static u8 mwifiex_rsn_oui[CIPHER_SUITE_MAX][4] = {
+        { 0x00, 0x0f, 0xac, 0x02 },     /* TKIP */
+        { 0x00, 0x0f, 0xac, 0x04 },     /* AES  */
+};
+/*
+ * This function parses a given IE for a given OUI.
+ *
+ * This is used to parse a WPA/RSN IE to find if it has
+ * a given oui in PTK.
+ */
+static u8
+mwifiex_search_oui_in_ie(struct ie_body *iebody, u8 *oui)
+{
+        u8 count;
+        count = iebody->ptk_cnt[0];
+        /* There could be multiple OUIs for PTK hence
+           1) Take the length.
+           2) Check all the OUIs for AES.
+           3) If one of them is AES then pass success. */
+        while (count) {
+                if (!memcmp(iebody->ptk_body, oui, sizeof(iebody->ptk_body)))
+                        return MWIFIEX_OUI_PRESENT;
+                --count;
+                if (count)
+                        iebody = (struct ie_body *) ((u8 *) iebody +
+                                                sizeof(iebody->ptk_body));
+        }
+        pr_debug("info: %s: OUI is not found in PTK\n", __func__);
+        return MWIFIEX_OUI_NOT_PRESENT;
+}
+/*
+ * This function checks if a given OUI is present in a RSN IE.
+ *
+ * The function first checks if a RSN IE is present or not in the
+ * BSS descriptor. It tries to locate the OUI only if such an IE is
+ * present.
+ */
+static u8
+mwifiex_is_rsn_oui_present(struct mwifiex_bssdescriptor *bss_desc, u32 cipher)
+{
+        u8 *oui;
+        struct ie_body *iebody;
+        u8 ret = MWIFIEX_OUI_NOT_PRESENT;
+        if (((bss_desc->bcn_rsn_ie) && ((*(bss_desc->bcn_rsn_ie)).
+                                        ieee_hdr.element_id == WLAN_EID_RSN))) {
+                iebody = (struct ie_body *)
+                         (((u8 *) bss_desc->bcn_rsn_ie->data) +
+                         RSN_GTK_OUI_OFFSET);
+                oui = &mwifiex_rsn_oui[cipher][0];
+                ret = mwifiex_search_oui_in_ie(iebody, oui);
+                if (ret)
+                        return ret;
+        }
+        return ret;
+}
+/*
+ * This function checks if a given OUI is present in a WPA IE.
+ *
+ * The function first checks if a WPA IE is present or not in the
+ * BSS descriptor. It tries to locate the OUI only if such an IE is
+ * present.
+ */
+static u8
+mwifiex_is_wpa_oui_present(struct mwifiex_bssdescriptor *bss_desc, u32 cipher)
+{
+        u8 *oui;
+        struct ie_body *iebody;
+        u8 ret = MWIFIEX_OUI_NOT_PRESENT;
+        if (((bss_desc->bcn_wpa_ie) && ((*(bss_desc->bcn_wpa_ie)).
+                                      vend_hdr.element_id == WLAN_EID_WPA))) {
+                iebody = (struct ie_body *) bss_desc->bcn_wpa_ie->data;
+                oui = &mwifiex_wpa_oui[cipher][0];
+                ret = mwifiex_search_oui_in_ie(iebody, oui);
+                if (ret)
+                        return ret;
+        }
+        return ret;
+}
+/*
+ * This function compares two SSIDs and checks if they match.
+ */
+s32
+mwifiex_ssid_cmp(struct mwifiex_802_11_ssid *ssid1,
+                 struct mwifiex_802_11_ssid *ssid2)
+{
+        if (!ssid1 || !ssid2 || (ssid1->ssid_len != ssid2->ssid_len))
+                return -1;
+        return memcmp(ssid1->ssid, ssid2->ssid, ssid1->ssid_len);
+}
+/*
+ * Sends IOCTL request to get the best BSS.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int mwifiex_find_best_bss(struct mwifiex_private *priv,
+                          struct mwifiex_ssid_bssid *ssid_bssid)
+{
+        struct mwifiex_ssid_bssid tmp_ssid_bssid;
+        u8 *mac;
+        if (!ssid_bssid)
+                return -1;
+        memcpy(&tmp_ssid_bssid, ssid_bssid,
+               sizeof(struct mwifiex_ssid_bssid));
+        if (!mwifiex_bss_ioctl_find_bss(priv, &tmp_ssid_bssid)) {
+                memcpy(ssid_bssid, &tmp_ssid_bssid,
+                       sizeof(struct mwifiex_ssid_bssid));
+                mac = (u8 *) &ssid_bssid->bssid;
+                dev_dbg(priv->adapter->dev, "cmd: found network: ssid=%s,"
+                                " %pM\n", ssid_bssid->ssid.ssid, mac);
+                return 0;
+        }
+        return -1;
+}
+/*
+ * Sends IOCTL request to start a scan with user configurations.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ *
+ * Upon completion, it also generates a wireless event to notify
+ * applications.
+ */
+int mwifiex_set_user_scan_ioctl(struct mwifiex_private *priv,
+                                struct mwifiex_user_scan_cfg *scan_req)
+{
+        int status;
+        priv->adapter->cmd_wait_q.condition = false;
+        status = mwifiex_scan_networks(priv, scan_req);
+        if (!status)
+                status = mwifiex_wait_queue_complete(priv->adapter);
+        return status;
+}
+/*
+ * This function checks if wapi is enabled in driver and scanned network is
+ * compatible with it.
+ */
+static bool
+mwifiex_is_network_compatible_for_wapi(struct mwifiex_private *priv,
+                                       struct mwifiex_bssdescriptor *bss_desc)
+{
+        if (priv->sec_info.wapi_enabled &&
+            (bss_desc->bcn_wapi_ie &&
+             ((*(bss_desc->bcn_wapi_ie)).ieee_hdr.element_id ==
+                        WLAN_EID_BSS_AC_ACCESS_DELAY))) {
+                return true;
+        }
+        return false;
+}
+/*
+ * This function checks if driver is configured with no security mode and
+ * scanned network is compatible with it.
+ */
+static bool
+mwifiex_is_network_compatible_for_no_sec(struct mwifiex_private *priv,
+                                       struct mwifiex_bssdescriptor *bss_desc)
+{
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_DISABLED
+            && !priv->sec_info.wpa_enabled && !priv->sec_info.wpa2_enabled
+            && ((!bss_desc->bcn_wpa_ie) ||
+                ((*(bss_desc->bcn_wpa_ie)).vend_hdr.element_id !=
+            WLAN_EID_WPA))
+            && ((!bss_desc->bcn_rsn_ie) ||
+                ((*(bss_desc->bcn_rsn_ie)).ieee_hdr.element_id !=
+            WLAN_EID_RSN))
+            && !priv->sec_info.encryption_mode
+            && !bss_desc->privacy) {
+                return true;
+        }
+        return false;
+}
+/*
+ * This function checks if static WEP is enabled in driver and scanned network
+ * is compatible with it.
+ */
+static bool
+mwifiex_is_network_compatible_for_static_wep(struct mwifiex_private *priv,
+                                       struct mwifiex_bssdescriptor *bss_desc)
+{
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_ENABLED
+            && !priv->sec_info.wpa_enabled && !priv->sec_info.wpa2_enabled
+            && bss_desc->privacy) {
+                return true;
+        }
+        return false;
+}
+/*
+ * This function checks if wpa is enabled in driver and scanned network is
+ * compatible with it.
+ */
+static bool
+mwifiex_is_network_compatible_for_wpa(struct mwifiex_private *priv,
+                                      struct mwifiex_bssdescriptor *bss_desc,
+                                      int index)
+{
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_DISABLED
+            && priv->sec_info.wpa_enabled && !priv->sec_info.wpa2_enabled
+            && ((bss_desc->bcn_wpa_ie) && ((*(bss_desc->bcn_wpa_ie)).vend_hdr.
+                                                element_id == WLAN_EID_WPA))
+           /*
+            * Privacy bit may NOT be set in some APs like
+            * LinkSys WRT54G && bss_desc->privacy
+            */
+         ) {
+                dev_dbg(priv->adapter->dev, "info: %s: WPA: index=%d"
+                        " wpa_ie=%#x wpa2_ie=%#x WEP=%s WPA=%s WPA2=%s "
+                        "EncMode=%#x privacy=%#x\n", __func__, index,
+                        (bss_desc->bcn_wpa_ie) ?
+                        (*(bss_desc->bcn_wpa_ie)).
+                        vend_hdr.element_id : 0,
+                        (bss_desc->bcn_rsn_ie) ?
+                        (*(bss_desc->bcn_rsn_ie)).
+                        ieee_hdr.element_id : 0,
+                        (priv->sec_info.wep_status ==
+                        MWIFIEX_802_11_WEP_ENABLED) ? "e" : "d",
+                        (priv->sec_info.wpa_enabled) ? "e" : "d",
+                        (priv->sec_info.wpa2_enabled) ? "e" : "d",
+                        priv->sec_info.encryption_mode,
+                        bss_desc->privacy);
+                return true;
+        }
+        return false;
+}
+/*
+ * This function checks if wpa2 is enabled in driver and scanned network is
+ * compatible with it.
+ */
+static bool
+mwifiex_is_network_compatible_for_wpa2(struct mwifiex_private *priv,
+                                       struct mwifiex_bssdescriptor *bss_desc,
+                                       int index)
+{
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_DISABLED
+           && !priv->sec_info.wpa_enabled && priv->sec_info.wpa2_enabled
+           && ((bss_desc->bcn_rsn_ie) && ((*(bss_desc->bcn_rsn_ie)).ieee_hdr.
+                                                element_id == WLAN_EID_RSN))
+           /*
+            * Privacy bit may NOT be set in some APs like
+            * LinkSys WRT54G && bss_desc->privacy
+            */
+         ) {
+                dev_dbg(priv->adapter->dev, "info: %s: WPA2: index=%d"
+                        " wpa_ie=%#x wpa2_ie=%#x WEP=%s WPA=%s WPA2=%s "
+                        "EncMode=%#x privacy=%#x\n", __func__, index,
+                        (bss_desc->bcn_wpa_ie) ?
+                        (*(bss_desc->bcn_wpa_ie)).
+                        vend_hdr.element_id : 0,
+                        (bss_desc->bcn_rsn_ie) ?
+                        (*(bss_desc->bcn_rsn_ie)).
+                        ieee_hdr.element_id : 0,
+                        (priv->sec_info.wep_status ==
+                        MWIFIEX_802_11_WEP_ENABLED) ? "e" : "d",
+                        (priv->sec_info.wpa_enabled) ? "e" : "d",
+                        (priv->sec_info.wpa2_enabled) ? "e" : "d",
+                        priv->sec_info.encryption_mode,
+                        bss_desc->privacy);
+                return true;
+        }
+        return false;
+}
+/*
+ * This function checks if adhoc AES is enabled in driver and scanned network is
+ * compatible with it.
+ */
+static bool
+mwifiex_is_network_compatible_for_adhoc_aes(struct mwifiex_private *priv,
+                                       struct mwifiex_bssdescriptor *bss_desc)
+{
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_DISABLED
+            && !priv->sec_info.wpa_enabled && !priv->sec_info.wpa2_enabled
+            && ((!bss_desc->bcn_wpa_ie) || ((*(bss_desc->bcn_wpa_ie)).vend_hdr.
+                   element_id != WLAN_EID_WPA))
+            && ((!bss_desc->bcn_rsn_ie) || ((*(bss_desc->bcn_rsn_ie)).ieee_hdr.
+                   element_id != WLAN_EID_RSN))
+            && !priv->sec_info.encryption_mode
+            && bss_desc->privacy) {
+                return true;
+        }
+        return false;
+}
+/*
+ * This function checks if dynamic WEP is enabled in driver and scanned network
+ * is compatible with it.
+ */
+static bool
+mwifiex_is_network_compatible_for_dynamic_wep(struct mwifiex_private *priv,
+                                       struct mwifiex_bssdescriptor *bss_desc,
+                                       int index)
+{
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_DISABLED
+            && !priv->sec_info.wpa_enabled && !priv->sec_info.wpa2_enabled
+            && ((!bss_desc->bcn_wpa_ie) || ((*(bss_desc->bcn_wpa_ie)).vend_hdr.
+                   element_id != WLAN_EID_WPA))
+            && ((!bss_desc->bcn_rsn_ie) || ((*(bss_desc->bcn_rsn_ie)).ieee_hdr.
+                   element_id != WLAN_EID_RSN))
+            && priv->sec_info.encryption_mode
+            && bss_desc->privacy) {
+                dev_dbg(priv->adapter->dev, "info: %s: dynamic "
+                        "WEP: index=%d wpa_ie=%#x wpa2_ie=%#x "
+                        "EncMode=%#x privacy=%#x\n",
+                        __func__, index,
+                        (bss_desc->bcn_wpa_ie) ?
+                        (*(bss_desc->bcn_wpa_ie)).
+                        vend_hdr.element_id : 0,
+                        (bss_desc->bcn_rsn_ie) ?
+                        (*(bss_desc->bcn_rsn_ie)).
+                        ieee_hdr.element_id : 0,
+                        priv->sec_info.encryption_mode,
+                        bss_desc->privacy);
+                return true;
+        }
+        return false;
+}
+/*
+ * This function checks if a scanned network is compatible with the driver
+ * settings.
+ *
+ *   WEP     WPA    WPA2   ad-hoc encrypt                  Network
+ * enabled enabled enabled  AES    mode   Privacy WPA WPA2 Compatible
+ *    0       0       0      0     NONE      0     0   0   yes No security
+ *    0       1       0      0      x        1x    1   x   yes WPA (disable
+ *                                                         HT if no AES)
+ *    0       0       1      0      x        1x    x   1   yes WPA2 (disable
+ *                                                         HT if no AES)
+ *    0       0       0      1     NONE      1     0   0   yes Ad-hoc AES
+ *    1       0       0      0     NONE      1     0   0   yes Static WEP
+ *                                                         (disable HT)
+ *    0       0       0      0    !=NONE     1     0   0   yes Dynamic WEP
+ *
+ * Compatibility is not matched while roaming, except for mode.
+ */
+static s32
+mwifiex_is_network_compatible(struct mwifiex_private *priv, u32 index, u32 mode)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_bssdescriptor *bss_desc;
+        bss_desc = &adapter->scan_table[index];
+        bss_desc->disable_11n = false;
+        /* Don't check for compatibility if roaming */
+        if (priv->media_connected && (priv->bss_mode == NL80211_IFTYPE_STATION)
+            && (bss_desc->bss_mode == NL80211_IFTYPE_STATION))
+                return index;
+        if (priv->wps.session_enable) {
+                dev_dbg(adapter->dev,
+                        "info: return success directly in WPS period\n");
+                return index;
+        }
+        if (mwifiex_is_network_compatible_for_wapi(priv, bss_desc)) {
+                dev_dbg(adapter->dev, "info: return success for WAPI AP\n");
+                return index;
+        }
+        if (bss_desc->bss_mode == mode) {
+                if (mwifiex_is_network_compatible_for_no_sec(priv, bss_desc)) {
+                        /* No security */
+                        return index;
+                } else if (mwifiex_is_network_compatible_for_static_wep(priv,
+                                                                bss_desc)) {
+                        /* Static WEP enabled */
+                        dev_dbg(adapter->dev, "info: Disable 11n in WEP mode.\n");
+                        bss_desc->disable_11n = true;
+                        return index;
+                } else if (mwifiex_is_network_compatible_for_wpa(priv, bss_desc,
+                                                                 index)) {
+                        /* WPA enabled */
+                        if (((priv->adapter->config_bands & BAND_GN
+                              || priv->adapter->config_bands & BAND_AN)
+                              && bss_desc->bcn_ht_cap)
+                              && !mwifiex_is_wpa_oui_present(bss_desc,
+                                        CIPHER_SUITE_CCMP)) {
+                                if (mwifiex_is_wpa_oui_present(bss_desc,
+                                            CIPHER_SUITE_TKIP)) {
+                                        dev_dbg(adapter->dev,
+                                                "info: Disable 11n if AES "
+                                                "is not supported by AP\n");
+                                        bss_desc->disable_11n = true;
+                                } else {
+                                        return -1;
+                                }
+                        }
+                        return index;
+                } else if (mwifiex_is_network_compatible_for_wpa2(priv,
+                                                        bss_desc, index)) {
+                        /* WPA2 enabled */
+                        if (((priv->adapter->config_bands & BAND_GN
+                              || priv->adapter->config_bands & BAND_AN)
+                              && bss_desc->bcn_ht_cap)
+                              && !mwifiex_is_rsn_oui_present(bss_desc,
+                                        CIPHER_SUITE_CCMP)) {
+                                if (mwifiex_is_rsn_oui_present(bss_desc,
+                                            CIPHER_SUITE_TKIP)) {
+                                        dev_dbg(adapter->dev,
+                                                "info: Disable 11n if AES "
+                                                "is not supported by AP\n");
+                                        bss_desc->disable_11n = true;
+                                } else {
+                                        return -1;
+                                }
+                        }
+                        return index;
+                } else if (mwifiex_is_network_compatible_for_adhoc_aes(priv,
+                                                                bss_desc)) {
+                        /* Ad-hoc AES enabled */
+                        return index;
+                } else if (mwifiex_is_network_compatible_for_dynamic_wep(priv,
+                                                        bss_desc, index)) {
+                        /* Dynamic WEP enabled */
+                        return index;
+                }
+                /* Security doesn't match */
+                dev_dbg(adapter->dev, "info: %s: failed: index=%d "
+                       "wpa_ie=%#x wpa2_ie=%#x WEP=%s WPA=%s WPA2=%s EncMode"
+                       "=%#x privacy=%#x\n",
+                       __func__, index,
+                       (bss_desc->bcn_wpa_ie) ?
+                       (*(bss_desc->bcn_wpa_ie)).vend_hdr.
+                       element_id : 0,
+                       (bss_desc->bcn_rsn_ie) ?
+                       (*(bss_desc->bcn_rsn_ie)).ieee_hdr.
+                       element_id : 0,
+                       (priv->sec_info.wep_status ==
+                                MWIFIEX_802_11_WEP_ENABLED) ? "e" : "d",
+                       (priv->sec_info.wpa_enabled) ? "e" : "d",
+                       (priv->sec_info.wpa2_enabled) ? "e" : "d",
+                       priv->sec_info.encryption_mode, bss_desc->privacy);
+                return -1;
+        }
+        /* Mode doesn't match */
+        return -1;
+}
+/*
+ * This function finds the best SSID in the scan list.
+ *
+ * It searches the scan table for the best SSID that also matches the current
+ * adapter network preference (mode, security etc.).
+ */
+static s32
+mwifiex_find_best_network_in_list(struct mwifiex_private *priv)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        u32 mode = priv->bss_mode;
+        s32 best_net = -1;
+        s32 best_rssi = 0;
+        u32 i;
+        dev_dbg(adapter->dev, "info: num of BSSIDs = %d\n",
+                                adapter->num_in_scan_table);
+        for (i = 0; i < adapter->num_in_scan_table; i++) {
+                switch (mode) {
+                case NL80211_IFTYPE_STATION:
+                case NL80211_IFTYPE_ADHOC:
+                        if (mwifiex_is_network_compatible(priv, i, mode) >= 0) {
+                                if (SCAN_RSSI(adapter->scan_table[i].rssi) >
+                                    best_rssi) {
+                                        best_rssi = SCAN_RSSI(adapter->
+                                                          scan_table[i].rssi);
+                                        best_net = i;
+                                }
+                        }
+                        break;
+                case NL80211_IFTYPE_UNSPECIFIED:
+                default:
+                        if (SCAN_RSSI(adapter->scan_table[i].rssi) >
+                            best_rssi) {
+                                best_rssi = SCAN_RSSI(adapter->scan_table[i].
+                                                      rssi);
+                                best_net = i;
+                        }
+                        break;
+                }
+        }
+        return best_net;
+}
+/*
+ * This function creates a channel list for the driver to scan, based
+ * on region/band information.
+ *
+ * This routine is used for any scan that is not provided with a
+ * specific channel list to scan.
+ */
+static void
+mwifiex_scan_create_channel_list(struct mwifiex_private *priv,
+                                const struct mwifiex_user_scan_cfg
+                                *user_scan_in,
+                                struct mwifiex_chan_scan_param_set
+                                *scan_chan_list,
+                                u8 filtered_scan)
+{
+        enum ieee80211_band band;
+        struct ieee80211_supported_band *sband;
+        struct ieee80211_channel *ch;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        int chan_idx = 0, i;
+        u8 scan_type;
+        for (band = 0; (band < IEEE80211_NUM_BANDS) ; band++) {
+                if (!priv->wdev->wiphy->bands[band])
+                        continue;
+                sband = priv->wdev->wiphy->bands[band];
+                for (i = 0; (i < sband->n_channels) ; i++, chan_idx++) {
+                        ch = &sband->channels[i];
+                        if (ch->flags & IEEE80211_CHAN_DISABLED)
+                                continue;
+                        scan_chan_list[chan_idx].radio_type = band;
+                        scan_type = ch->flags & IEEE80211_CHAN_PASSIVE_SCAN;
+                        if (user_scan_in &&
+                                user_scan_in->chan_list[0].scan_time)
+                                scan_chan_list[chan_idx].max_scan_time =
+                                        cpu_to_le16((u16) user_scan_in->
+                                        chan_list[0].scan_time);
+                        else if (scan_type == MWIFIEX_SCAN_TYPE_PASSIVE)
+                                scan_chan_list[chan_idx].max_scan_time =
+                                        cpu_to_le16(adapter->passive_scan_time);
+                        else
+                                scan_chan_list[chan_idx].max_scan_time =
+                                        cpu_to_le16(adapter->active_scan_time);
+                        if (scan_type == MWIFIEX_SCAN_TYPE_PASSIVE)
+                                scan_chan_list[chan_idx].chan_scan_mode_bitmap
+                                        |= MWIFIEX_PASSIVE_SCAN;
+                        else
+                                scan_chan_list[chan_idx].chan_scan_mode_bitmap
+                                        &= ~MWIFIEX_PASSIVE_SCAN;
+                        scan_chan_list[chan_idx].chan_number =
+                                                        (u32) ch->hw_value;
+                        if (filtered_scan) {
+                                scan_chan_list[chan_idx].max_scan_time =
+                                cpu_to_le16(adapter->specific_scan_time);
+                                scan_chan_list[chan_idx].chan_scan_mode_bitmap
+                                        |= MWIFIEX_DISABLE_CHAN_FILT;
+                        }
+                }
+        }
+}
+/*
+ * This function constructs and sends multiple scan config commands to
+ * the firmware.
+ *
+ * Previous routines in the code flow have created a scan command configuration
+ * with any requested TLVs.  This function splits the channel TLV into maximum
+ * channels supported per scan lists and sends the portion of the channel TLV,
+ * along with the other TLVs, to the firmware.
+ */
+static int
+mwifiex_scan_channel_list(struct mwifiex_private *priv,
+                          u32 max_chan_per_scan, u8 filtered_scan,
+                          struct mwifiex_scan_cmd_config *scan_cfg_out,
+                          struct mwifiex_ie_types_chan_list_param_set
+                          *chan_tlv_out,
+                          struct mwifiex_chan_scan_param_set *scan_chan_list)
+{
+        int ret = 0;
+        struct mwifiex_chan_scan_param_set *tmp_chan_list;
+        struct mwifiex_chan_scan_param_set *start_chan;
+        u32 tlv_idx;
+        u32 total_scan_time;
+        u32 done_early;
+        if (!scan_cfg_out || !chan_tlv_out || !scan_chan_list) {
+                dev_dbg(priv->adapter->dev,
+                        "info: Scan: Null detect: %p, %p, %p\n",
+                       scan_cfg_out, chan_tlv_out, scan_chan_list);
+                return -1;
+        }
+        chan_tlv_out->header.type = cpu_to_le16(TLV_TYPE_CHANLIST);
+        /* Set the temp channel struct pointer to the start of the desired
+           list */
+        tmp_chan_list = scan_chan_list;
+        /* Loop through the desired channel list, sending a new firmware scan
+           commands for each max_chan_per_scan channels (or for 1,6,11
+           individually if configured accordingly) */
+        while (tmp_chan_list->chan_number) {
+                tlv_idx = 0;
+                total_scan_time = 0;
+                chan_tlv_out->header.len = 0;
+                start_chan = tmp_chan_list;
+                done_early = false;
+                /*
+                 * Construct the Channel TLV for the scan command.  Continue to
+                 * insert channel TLVs until:
+                 *   - the tlv_idx hits the maximum configured per scan command
+                 *   - the next channel to insert is 0 (end of desired channel
+                 *     list)
+                 *   - done_early is set (controlling individual scanning of
+                 *     1,6,11)
+                 */
+                while (tlv_idx < max_chan_per_scan
+                       && tmp_chan_list->chan_number && !done_early) {
+                        dev_dbg(priv->adapter->dev,
+                                "info: Scan: Chan(%3d), Radio(%d),"
+                                " Mode(%d, %d), Dur(%d)\n",
+                               tmp_chan_list->chan_number,
+                               tmp_chan_list->radio_type,
+                               tmp_chan_list->chan_scan_mode_bitmap
+                               & MWIFIEX_PASSIVE_SCAN,
+                               (tmp_chan_list->chan_scan_mode_bitmap
+                               & MWIFIEX_DISABLE_CHAN_FILT) >> 1,
+                               le16_to_cpu(tmp_chan_list->max_scan_time));
+                        /* Copy the current channel TLV to the command being
+                           prepared */
+                        memcpy(chan_tlv_out->chan_scan_param + tlv_idx,
+                               tmp_chan_list,
+                               sizeof(chan_tlv_out->chan_scan_param));
+                        /* Increment the TLV header length by the size
+                           appended */
+                        chan_tlv_out->header.len =
+                        cpu_to_le16(le16_to_cpu(chan_tlv_out->header.len) +
+                        (sizeof(chan_tlv_out->chan_scan_param)));
+                        /*
+                         * The tlv buffer length is set to the number of bytes
+                         * of the between the channel tlv pointer and the start
+                         * of the tlv buffer.  This compensates for any TLVs
+                         * that were appended before the channel list.
+                         */
+                        scan_cfg_out->tlv_buf_len = (u32) ((u8 *) chan_tlv_out -
+                                                        scan_cfg_out->tlv_buf);
+                        /* Add the size of the channel tlv header and the data
+                           length */
+                        scan_cfg_out->tlv_buf_len +=
+                                (sizeof(chan_tlv_out->header)
+                                 + le16_to_cpu(chan_tlv_out->header.len));
+                        /* Increment the index to the channel tlv we are
+                           constructing */
+                        tlv_idx++;
+                        /* Count the total scan time per command */
+                        total_scan_time +=
+                                le16_to_cpu(tmp_chan_list->max_scan_time);
+                        done_early = false;
+                        /* Stop the loop if the *current* channel is in the
+                           1,6,11 set and we are not filtering on a BSSID
+                           or SSID. */
+                        if (!filtered_scan && (tmp_chan_list->chan_number == 1
+                                || tmp_chan_list->chan_number == 6
+                                || tmp_chan_list->chan_number == 11))
+                                done_early = true;
+                        /* Increment the tmp pointer to the next channel to
+                           be scanned */
+                        tmp_chan_list++;
+                        /* Stop the loop if the *next* channel is in the 1,6,11
+                           set.  This will cause it to be the only channel
+                           scanned on the next interation */
+                        if (!filtered_scan && (tmp_chan_list->chan_number == 1
+                                || tmp_chan_list->chan_number == 6
+                                || tmp_chan_list->chan_number == 11))
+                                done_early = true;
+                }
+                /* The total scan time should be less than scan command timeout
+                   value */
+                if (total_scan_time > MWIFIEX_MAX_TOTAL_SCAN_TIME) {
+                        dev_err(priv->adapter->dev, "total scan time %dms"
+                                " is over limit (%dms), scan skipped\n",
+                                total_scan_time, MWIFIEX_MAX_TOTAL_SCAN_TIME);
+                        ret = -1;
+                        break;
+                }
+                priv->adapter->scan_channels = start_chan;
+                /* Send the scan command to the firmware with the specified
+                   cfg */
+                ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_802_11_SCAN,
+                                             HostCmd_ACT_GEN_SET, 0,
+                                             scan_cfg_out);
+                if (ret)
+                        break;
+        }
+        if (ret)
+                return -1;
+        return 0;
+}
+/*
+ * This function constructs a scan command configuration structure to use
+ * in scan commands.
+ *
+ * Application layer or other functions can invoke network scanning
+ * with a scan configuration supplied in a user scan configuration structure.
+ * This structure is used as the basis of one or many scan command configuration
+ * commands that are sent to the command processing module and eventually to the
+ * firmware.
+ *
+ * This function creates a scan command configuration structure  based on the
+ * following user supplied parameters (if present):
+ *      - SSID filter
+ *      - BSSID filter
+ *      - Number of Probes to be sent
+ *      - Channel list
+ *
+ * If the SSID or BSSID filter is not present, the filter is disabled/cleared.
+ * If the number of probes is not set, adapter default setting is used.
+ */
+static void
+mwifiex_scan_setup_scan_config(struct mwifiex_private *priv,
+                               const struct mwifiex_user_scan_cfg *user_scan_in,
+                               struct mwifiex_scan_cmd_config *scan_cfg_out,
+                               struct mwifiex_ie_types_chan_list_param_set
+                               **chan_list_out,
+                               struct mwifiex_chan_scan_param_set
+                               *scan_chan_list,
+                               u8 *max_chan_per_scan, u8 *filtered_scan,
+                               u8 *scan_current_only)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_ie_types_num_probes *num_probes_tlv;
+        struct mwifiex_ie_types_wildcard_ssid_params *wildcard_ssid_tlv;
+        struct mwifiex_ie_types_rates_param_set *rates_tlv;
+        const u8 zero_mac[ETH_ALEN] = { 0, 0, 0, 0, 0, 0 };
+        u8 *tlv_pos;
+        u32 num_probes;
+        u32 ssid_len;
+        u32 chan_idx;
+        u32 scan_type;
+        u16 scan_dur;
+        u8 channel;
+        u8 radio_type;
+        u32 ssid_idx;
+        u8 ssid_filter;
+        u8 rates[MWIFIEX_SUPPORTED_RATES];
+        u32 rates_size;
+        struct mwifiex_ie_types_htcap *ht_cap;
+        /* The tlv_buf_len is calculated for each scan command.  The TLVs added
+           in this routine will be preserved since the routine that sends the
+           command will append channelTLVs at *chan_list_out.  The difference
+           between the *chan_list_out and the tlv_buf start will be used to
+           calculate the size of anything we add in this routine. */
+        scan_cfg_out->tlv_buf_len = 0;
+        /* Running tlv pointer.  Assigned to chan_list_out at end of function
+           so later routines know where channels can be added to the command
+           buf */
+        tlv_pos = scan_cfg_out->tlv_buf;
+        /* Initialize the scan as un-filtered; the flag is later set to TRUE
+           below if a SSID or BSSID filter is sent in the command */
+        *filtered_scan = false;
+        /* Initialize the scan as not being only on the current channel.  If
+           the channel list is customized, only contains one channel, and is
+           the active channel, this is set true and data flow is not halted. */
+        *scan_current_only = false;
+        if (user_scan_in) {
+                /* Default the ssid_filter flag to TRUE, set false under
+                   certain wildcard conditions and qualified by the existence
+                   of an SSID list before marking the scan as filtered */
+                ssid_filter = true;
+                /* Set the BSS type scan filter, use Adapter setting if
+                   unset */
+                scan_cfg_out->bss_mode =
+                        (user_scan_in->bss_mode ? (u8) user_scan_in->
+                         bss_mode : (u8) adapter->scan_mode);
+                /* Set the number of probes to send, use Adapter setting
+                   if unset */
+                num_probes =
+                        (user_scan_in->num_probes ? user_scan_in->
+                         num_probes : adapter->scan_probes);
+                /*
+                 * Set the BSSID filter to the incoming configuration,
+                 * if non-zero.  If not set, it will remain disabled
+                 * (all zeros).
+                 */
+                memcpy(scan_cfg_out->specific_bssid,
+                       user_scan_in->specific_bssid,
+                       sizeof(scan_cfg_out->specific_bssid));
+                for (ssid_idx = 0;
+                     ((ssid_idx < ARRAY_SIZE(user_scan_in->ssid_list))
+                      && (*user_scan_in->ssid_list[ssid_idx].ssid
+                          || user_scan_in->ssid_list[ssid_idx].max_len));
+                     ssid_idx++) {
+                        ssid_len = strlen(user_scan_in->ssid_list[ssid_idx].
+                                          ssid) + 1;
+                        wildcard_ssid_tlv =
+                                (struct mwifiex_ie_types_wildcard_ssid_params *)
+                                tlv_pos;
+                        wildcard_ssid_tlv->header.type =
+                                cpu_to_le16(TLV_TYPE_WILDCARDSSID);
+                        wildcard_ssid_tlv->header.len = cpu_to_le16(
+                                (u16) (ssid_len + sizeof(wildcard_ssid_tlv->
+                                                         max_ssid_length)));
+                        wildcard_ssid_tlv->max_ssid_length =
+                                user_scan_in->ssid_list[ssid_idx].max_len;
+                        memcpy(wildcard_ssid_tlv->ssid,
+                               user_scan_in->ssid_list[ssid_idx].ssid,
+                               ssid_len);
+                        tlv_pos += (sizeof(wildcard_ssid_tlv->header)
+                                + le16_to_cpu(wildcard_ssid_tlv->header.len));
+                        dev_dbg(adapter->dev, "info: scan: ssid_list[%d]: %s, %d\n",
+                                ssid_idx, wildcard_ssid_tlv->ssid,
+                                wildcard_ssid_tlv->max_ssid_length);
+                        /* Empty wildcard ssid with a maxlen will match many or
+                           potentially all SSIDs (maxlen == 32), therefore do
+                           not treat the scan as
+                           filtered. */
+                        if (!ssid_len && wildcard_ssid_tlv->max_ssid_length)
+                                ssid_filter = false;
+                }
+                /*
+                 *  The default number of channels sent in the command is low to
+                 *  ensure the response buffer from the firmware does not
+                 *  truncate scan results.  That is not an issue with an SSID
+                 *  or BSSID filter applied to the scan results in the firmware.
+                 */
+                if ((ssid_idx && ssid_filter)
+                    || memcmp(scan_cfg_out->specific_bssid, &zero_mac,
+                              sizeof(zero_mac)))
+                        *filtered_scan = true;
+        } else {
+                scan_cfg_out->bss_mode = (u8) adapter->scan_mode;
+                num_probes = adapter->scan_probes;
+        }
+        /*
+         *  If a specific BSSID or SSID is used, the number of channels in the
+         *  scan command will be increased to the absolute maximum.
+         */
+        if (*filtered_scan)
+                *max_chan_per_scan = MWIFIEX_MAX_CHANNELS_PER_SPECIFIC_SCAN;
+        else
+                *max_chan_per_scan = MWIFIEX_CHANNELS_PER_SCAN_CMD;
+        /* If the input config or adapter has the number of Probes set,
+           add tlv */
+        if (num_probes) {
+                dev_dbg(adapter->dev, "info: scan: num_probes = %d\n",
+                                                num_probes);
+                num_probes_tlv = (struct mwifiex_ie_types_num_probes *) tlv_pos;
+                num_probes_tlv->header.type = cpu_to_le16(TLV_TYPE_NUMPROBES);
+                num_probes_tlv->header.len =
+                        cpu_to_le16(sizeof(num_probes_tlv->num_probes));
+                num_probes_tlv->num_probes = cpu_to_le16((u16) num_probes);
+                tlv_pos += sizeof(num_probes_tlv->header) +
+                        le16_to_cpu(num_probes_tlv->header.len);
+        }
+        /* Append rates tlv */
+        memset(rates, 0, sizeof(rates));
+        rates_size = mwifiex_get_supported_rates(priv, rates);
+        rates_tlv = (struct mwifiex_ie_types_rates_param_set *) tlv_pos;
+        rates_tlv->header.type = cpu_to_le16(WLAN_EID_SUPP_RATES);
+        rates_tlv->header.len = cpu_to_le16((u16) rates_size);
+        memcpy(rates_tlv->rates, rates, rates_size);
+        tlv_pos += sizeof(rates_tlv->header) + rates_size;
+        dev_dbg(adapter->dev, "info: SCAN_CMD: Rates size = %d\n", rates_size);
+        if (ISSUPP_11NENABLED(priv->adapter->fw_cap_info)
+            && (priv->adapter->config_bands & BAND_GN
+                || priv->adapter->config_bands & BAND_AN)) {
+                ht_cap = (struct mwifiex_ie_types_htcap *) tlv_pos;
+                memset(ht_cap, 0, sizeof(struct mwifiex_ie_types_htcap));
+                ht_cap->header.type = cpu_to_le16(WLAN_EID_HT_CAPABILITY);
+                ht_cap->header.len =
+                                cpu_to_le16(sizeof(struct ieee80211_ht_cap));
+                radio_type =
+                        mwifiex_band_to_radio_type(priv->adapter->config_bands);
+                mwifiex_fill_cap_info(priv, radio_type, ht_cap);
+                tlv_pos += sizeof(struct mwifiex_ie_types_htcap);
+        }
+        /* Append vendor specific IE TLV */
+        mwifiex_cmd_append_vsie_tlv(priv, MWIFIEX_VSIE_MASK_SCAN, &tlv_pos);
+        /*
+         * Set the output for the channel TLV to the address in the tlv buffer
+         *   past any TLVs that were added in this function (SSID, num_probes).
+         *   Channel TLVs will be added past this for each scan command,
+         *   preserving the TLVs that were previously added.
+         */
+        *chan_list_out =
+                (struct mwifiex_ie_types_chan_list_param_set *) tlv_pos;
+        if (user_scan_in && user_scan_in->chan_list[0].chan_number) {
+                dev_dbg(adapter->dev, "info: Scan: Using supplied channel list\n");
+                for (chan_idx = 0;
+                     chan_idx < MWIFIEX_USER_SCAN_CHAN_MAX
+                     && user_scan_in->chan_list[chan_idx].chan_number;
+                     chan_idx++) {
+                        channel = user_scan_in->chan_list[chan_idx].chan_number;
+                        (scan_chan_list + chan_idx)->chan_number = channel;
+                        radio_type =
+                                user_scan_in->chan_list[chan_idx].radio_type;
+                        (scan_chan_list + chan_idx)->radio_type = radio_type;
+                        scan_type = user_scan_in->chan_list[chan_idx].scan_type;
+                        if (scan_type == MWIFIEX_SCAN_TYPE_PASSIVE)
+                                (scan_chan_list +
+                                 chan_idx)->chan_scan_mode_bitmap
+                                        |= MWIFIEX_PASSIVE_SCAN;
+                        else
+                                (scan_chan_list +
+                                 chan_idx)->chan_scan_mode_bitmap
+                                        &= ~MWIFIEX_PASSIVE_SCAN;
+                        if (user_scan_in->chan_list[chan_idx].scan_time) {
+                                scan_dur = (u16) user_scan_in->
+                                        chan_list[chan_idx].scan_time;
+                        } else {
+                                if (scan_type == MWIFIEX_SCAN_TYPE_PASSIVE)
+                                        scan_dur = adapter->passive_scan_time;
+                                else if (*filtered_scan)
+                                        scan_dur = adapter->specific_scan_time;
+                                else
+                                        scan_dur = adapter->active_scan_time;
+                        }
+                        (scan_chan_list + chan_idx)->min_scan_time =
+                                cpu_to_le16(scan_dur);
+                        (scan_chan_list + chan_idx)->max_scan_time =
+                                cpu_to_le16(scan_dur);
+                }
+                /* Check if we are only scanning the current channel */
+                if ((chan_idx == 1)
+                    && (user_scan_in->chan_list[0].chan_number
+                        == priv->curr_bss_params.bss_descriptor.channel)) {
+                        *scan_current_only = true;
+                        dev_dbg(adapter->dev,
+                                "info: Scan: Scanning current channel only\n");
+                }
+        } else {
+                dev_dbg(adapter->dev,
+                                "info: Scan: Creating full region channel list\n");
+                mwifiex_scan_create_channel_list(priv, user_scan_in,
+                                                 scan_chan_list,
+                                                 *filtered_scan);
+        }
+}
+/*
+ * This function inspects the scan response buffer for pointers to
+ * expected TLVs.
+ *
+ * TLVs can be included at the end of the scan response BSS information.
+ *
+ * Data in the buffer is parsed pointers to TLVs that can potentially
+ * be passed back in the response.
+ */
+static void
+mwifiex_ret_802_11_scan_get_tlv_ptrs(struct mwifiex_adapter *adapter,
+                                     struct mwifiex_ie_types_data *tlv,
+                                     u32 tlv_buf_size, u32 req_tlv_type,
+                                     struct mwifiex_ie_types_data **tlv_data)
+{
+        struct mwifiex_ie_types_data *current_tlv;
+        u32 tlv_buf_left;
+        u32 tlv_type;
+        u32 tlv_len;
+        current_tlv = tlv;
+        tlv_buf_left = tlv_buf_size;
+        *tlv_data = NULL;
+        dev_dbg(adapter->dev, "info: SCAN_RESP: tlv_buf_size = %d\n",
+                                                tlv_buf_size);
+        while (tlv_buf_left >= sizeof(struct mwifiex_ie_types_header)) {
+                tlv_type = le16_to_cpu(current_tlv->header.type);
+                tlv_len = le16_to_cpu(current_tlv->header.len);
+                if (sizeof(tlv->header) + tlv_len > tlv_buf_left) {
+                        dev_err(adapter->dev, "SCAN_RESP: TLV buffer corrupt\n");
+                        break;
+                }
+                if (req_tlv_type == tlv_type) {
+                        switch (tlv_type) {
+                        case TLV_TYPE_TSFTIMESTAMP:
+                                dev_dbg(adapter->dev, "info: SCAN_RESP: TSF "
+                                        "timestamp TLV, len = %d\n", tlv_len);
+                                *tlv_data = (struct mwifiex_ie_types_data *)
+                                        current_tlv;
+                                break;
+                        case TLV_TYPE_CHANNELBANDLIST:
+                                dev_dbg(adapter->dev, "info: SCAN_RESP: channel"
+                                        " band list TLV, len = %d\n", tlv_len);
+                                *tlv_data = (struct mwifiex_ie_types_data *)
+                                        current_tlv;
+                                break;
+                        default:
+                                dev_err(adapter->dev,
+                                        "SCAN_RESP: unhandled TLV = %d\n",
+                                       tlv_type);
+                                /* Give up, this seems corrupted */
+                                return;
+                        }
+                }
+                if (*tlv_data)
+                        break;
+                tlv_buf_left -= (sizeof(tlv->header) + tlv_len);
+                current_tlv =
+                        (struct mwifiex_ie_types_data *) (current_tlv->data +
+                                                          tlv_len);
+        }                       /* while */
+}
+/*
+ * This function interprets a BSS scan response returned from the firmware.
+ *
+ * The various fixed fields and IEs are parsed and passed back for a BSS
+ * probe response or beacon from scan command. Information is recorded as
+ * needed in the scan table for that entry.
+ *
+ * The following IE types are recognized and parsed -
+ *      - SSID
+ *      - Supported rates
+ *      - FH parameters set
+ *      - DS parameters set
+ *      - CF parameters set
+ *      - IBSS parameters set
+ *      - ERP information
+ *      - Extended supported rates
+ *      - Vendor specific (221)
+ *      - RSN IE
+ *      - WAPI IE
+ *      - HT capability
+ *      - HT operation
+ *      - BSS Coexistence 20/40
+ *      - Extended capability
+ *      - Overlapping BSS scan parameters
+ */
+static int
+mwifiex_interpret_bss_desc_with_ie(struct mwifiex_adapter *adapter,
+                                   struct mwifiex_bssdescriptor *bss_entry,
+                                   u8 **beacon_info, u32 *bytes_left)
+{
+        int ret = 0;
+        u8 element_id;
+        struct ieee_types_fh_param_set *fh_param_set;
+        struct ieee_types_ds_param_set *ds_param_set;
+        struct ieee_types_cf_param_set *cf_param_set;
+        struct ieee_types_ibss_param_set *ibss_param_set;
+        __le16 beacon_interval;
+        __le16 capabilities;
+        u8 *current_ptr;
+        u8 *rate;
+        u8 element_len;
+        u16 total_ie_len;
+        u8 bytes_to_copy;
+        u8 rate_size;
+        u16 beacon_size;
+        u8 found_data_rate_ie;
+        u32 bytes_left_for_current_beacon;
+        struct ieee_types_vendor_specific *vendor_ie;
+        const u8 wpa_oui[4] = { 0x00, 0x50, 0xf2, 0x01 };
+        const u8 wmm_oui[4] = { 0x00, 0x50, 0xf2, 0x02 };
+        found_data_rate_ie = false;
+        rate_size = 0;
+        beacon_size = 0;
+        if (*bytes_left >= sizeof(beacon_size)) {
+                /* Extract & convert beacon size from the command buffer */
+                memcpy(&beacon_size, *beacon_info, sizeof(beacon_size));
+                *bytes_left -= sizeof(beacon_size);
+                *beacon_info += sizeof(beacon_size);
+        }
+        if (!beacon_size || beacon_size > *bytes_left) {
+                *beacon_info += *bytes_left;
+                *bytes_left = 0;
+                return -1;
+        }
+        /* Initialize the current working beacon pointer for this BSS
+           iteration */
+        current_ptr = *beacon_info;
+        /* Advance the return beacon pointer past the current beacon */
+        *beacon_info += beacon_size;
+        *bytes_left -= beacon_size;
+        bytes_left_for_current_beacon = beacon_size;
+        memcpy(bss_entry->mac_address, current_ptr, ETH_ALEN);
+        dev_dbg(adapter->dev, "info: InterpretIE: AP MAC Addr: %pM\n",
+                                                bss_entry->mac_address);
+        current_ptr += ETH_ALEN;
+        bytes_left_for_current_beacon -= ETH_ALEN;
+        if (bytes_left_for_current_beacon < 12) {
+                dev_err(adapter->dev, "InterpretIE: not enough bytes left\n");
+                return -1;
+        }
+        /*
+         * Next 4 fields are RSSI, time stamp, beacon interval,
+         *   and capability information
+         */
+        /* RSSI is 1 byte long */
+        bss_entry->rssi = (s32) (*current_ptr);
+        dev_dbg(adapter->dev, "info: InterpretIE: RSSI=%02X\n", *current_ptr);
+        current_ptr += 1;
+        bytes_left_for_current_beacon -= 1;
+        /*
+         *  The RSSI is not part of the beacon/probe response.  After we have
+         *    advanced current_ptr past the RSSI field, save the remaining
+         *    data for use at the application layer
+         */
+        bss_entry->beacon_buf = current_ptr;
+        bss_entry->beacon_buf_size = bytes_left_for_current_beacon;
+        /* Time stamp is 8 bytes long */
+        memcpy(bss_entry->time_stamp, current_ptr, 8);
+        current_ptr += 8;
+        bytes_left_for_current_beacon -= 8;
+        /* Beacon interval is 2 bytes long */
+        memcpy(&beacon_interval, current_ptr, 2);
+        bss_entry->beacon_period = le16_to_cpu(beacon_interval);
+        current_ptr += 2;
+        bytes_left_for_current_beacon -= 2;
+        /* Capability information is 2 bytes long */
+        memcpy(&capabilities, current_ptr, 2);
+        dev_dbg(adapter->dev, "info: InterpretIE: capabilities=0x%X\n",
+               capabilities);
+        bss_entry->cap_info_bitmap = le16_to_cpu(capabilities);
+        current_ptr += 2;
+        bytes_left_for_current_beacon -= 2;
+        /* Rest of the current buffer are IE's */
+        dev_dbg(adapter->dev, "info: InterpretIE: IELength for this AP = %d\n",
+               bytes_left_for_current_beacon);
+        if (bss_entry->cap_info_bitmap & WLAN_CAPABILITY_PRIVACY) {
+                dev_dbg(adapter->dev, "info: InterpretIE: AP WEP enabled\n");
+                bss_entry->privacy = MWIFIEX_802_11_PRIV_FILTER_8021X_WEP;
+        } else {
+                bss_entry->privacy = MWIFIEX_802_11_PRIV_FILTER_ACCEPT_ALL;
+        }
+        if (bss_entry->cap_info_bitmap & WLAN_CAPABILITY_IBSS)
+                bss_entry->bss_mode = NL80211_IFTYPE_ADHOC;
+        else
+                bss_entry->bss_mode = NL80211_IFTYPE_STATION;
+        /* Process variable IE */
+        while (bytes_left_for_current_beacon >= 2) {
+                element_id = *current_ptr;
+                element_len = *(current_ptr + 1);
+                total_ie_len = element_len + sizeof(struct ieee_types_header);
+                if (bytes_left_for_current_beacon < total_ie_len) {
+                        dev_err(adapter->dev, "err: InterpretIE: in processing"
+                                " IE, bytes left < IE length\n");
+                        bytes_left_for_current_beacon = 0;
+                        ret = -1;
+                        continue;
+                }
+                switch (element_id) {
+                case WLAN_EID_SSID:
+                        bss_entry->ssid.ssid_len = element_len;
+                        memcpy(bss_entry->ssid.ssid, (current_ptr + 2),
+                               element_len);
+                        dev_dbg(adapter->dev, "info: InterpretIE: ssid: %-32s\n",
+                               bss_entry->ssid.ssid);
+                        break;
+                case WLAN_EID_SUPP_RATES:
+                        memcpy(bss_entry->data_rates, current_ptr + 2,
+                               element_len);
+                        memcpy(bss_entry->supported_rates, current_ptr + 2,
+                               element_len);
+                        rate_size = element_len;
+                        found_data_rate_ie = true;
+                        break;
+                case WLAN_EID_FH_PARAMS:
+                        fh_param_set =
+                                (struct ieee_types_fh_param_set *) current_ptr;
+                        memcpy(&bss_entry->phy_param_set.fh_param_set,
+                               fh_param_set,
+                               sizeof(struct ieee_types_fh_param_set));
+                        break;
+                case WLAN_EID_DS_PARAMS:
+                        ds_param_set =
+                                (struct ieee_types_ds_param_set *) current_ptr;
+                        bss_entry->channel = ds_param_set->current_chan;
+                        memcpy(&bss_entry->phy_param_set.ds_param_set,
+                               ds_param_set,
+                               sizeof(struct ieee_types_ds_param_set));
+                        break;
+                case WLAN_EID_CF_PARAMS:
+                        cf_param_set =
+                                (struct ieee_types_cf_param_set *) current_ptr;
+                        memcpy(&bss_entry->ss_param_set.cf_param_set,
+                               cf_param_set,
+                               sizeof(struct ieee_types_cf_param_set));
+                        break;
+                case WLAN_EID_IBSS_PARAMS:
+                        ibss_param_set =
+                                (struct ieee_types_ibss_param_set *)
+                                current_ptr;
+                        memcpy(&bss_entry->ss_param_set.ibss_param_set,
+                               ibss_param_set,
+                               sizeof(struct ieee_types_ibss_param_set));
+                        break;
+                case WLAN_EID_ERP_INFO:
+                        bss_entry->erp_flags = *(current_ptr + 2);
+                        break;
+                case WLAN_EID_EXT_SUPP_RATES:
+                        /*
+                         * Only process extended supported rate
+                         * if data rate is already found.
+                         * Data rate IE should come before
+                         * extended supported rate IE
+                         */
+                        if (found_data_rate_ie) {
+                                if ((element_len + rate_size) >
+                                    MWIFIEX_SUPPORTED_RATES)
+                                        bytes_to_copy =
+                                                (MWIFIEX_SUPPORTED_RATES -
+                                                 rate_size);
+                                else
+                                        bytes_to_copy = element_len;
+                                rate = (u8 *) bss_entry->data_rates;
+                                rate += rate_size;
+                                memcpy(rate, current_ptr + 2, bytes_to_copy);
+                                rate = (u8 *) bss_entry->supported_rates;
+                                rate += rate_size;
+                                memcpy(rate, current_ptr + 2, bytes_to_copy);
+                        }
+                        break;
+                case WLAN_EID_VENDOR_SPECIFIC:
+                        vendor_ie = (struct ieee_types_vendor_specific *)
+                                        current_ptr;
+                        if (!memcmp
+                            (vendor_ie->vend_hdr.oui, wpa_oui,
+                             sizeof(wpa_oui))) {
+                                bss_entry->bcn_wpa_ie =
+                                        (struct ieee_types_vendor_specific *)
+                                        current_ptr;
+                                bss_entry->wpa_offset = (u16) (current_ptr -
+                                                        bss_entry->beacon_buf);
+                        } else if (!memcmp(vendor_ie->vend_hdr.oui, wmm_oui,
+                                    sizeof(wmm_oui))) {
+                                if (total_ie_len ==
+                                    sizeof(struct ieee_types_wmm_parameter)
+                                    || total_ie_len ==
+                                    sizeof(struct ieee_types_wmm_info))
+                                        /*
+                                         * Only accept and copy the WMM IE if
+                                         * it matches the size expected for the
+                                         * WMM Info IE or the WMM Parameter IE.
+                                         */
+                                        memcpy((u8 *) &bss_entry->wmm_ie,
+                                               current_ptr, total_ie_len);
+                        }
+                        break;
+                case WLAN_EID_RSN:
+                        bss_entry->bcn_rsn_ie =
+                                (struct ieee_types_generic *) current_ptr;
+                        bss_entry->rsn_offset = (u16) (current_ptr -
+                                                        bss_entry->beacon_buf);
+                        break;
+                case WLAN_EID_BSS_AC_ACCESS_DELAY:
+                        bss_entry->bcn_wapi_ie =
+                                (struct ieee_types_generic *) current_ptr;
+                        bss_entry->wapi_offset = (u16) (current_ptr -
+                                                        bss_entry->beacon_buf);
+                        break;
+                case WLAN_EID_HT_CAPABILITY:
+                        bss_entry->bcn_ht_cap = (struct ieee80211_ht_cap *)
+                                        (current_ptr +
+                                        sizeof(struct ieee_types_header));
+                        bss_entry->ht_cap_offset = (u16) (current_ptr +
+                                        sizeof(struct ieee_types_header) -
+                                        bss_entry->beacon_buf);
+                        break;
+                case WLAN_EID_HT_INFORMATION:
+                        bss_entry->bcn_ht_info = (struct ieee80211_ht_info *)
+                                        (current_ptr +
+                                        sizeof(struct ieee_types_header));
+                        bss_entry->ht_info_offset = (u16) (current_ptr +
+                                        sizeof(struct ieee_types_header) -
+                                        bss_entry->beacon_buf);
+                        break;
+                case WLAN_EID_BSS_COEX_2040:
+                        bss_entry->bcn_bss_co_2040 = (u8 *) (current_ptr +
+                                        sizeof(struct ieee_types_header));
+                        bss_entry->bss_co_2040_offset = (u16) (current_ptr +
+                                        sizeof(struct ieee_types_header) -
+                                                bss_entry->beacon_buf);
+                        break;
+                case WLAN_EID_EXT_CAPABILITY:
+                        bss_entry->bcn_ext_cap = (u8 *) (current_ptr +
+                                        sizeof(struct ieee_types_header));
+                        bss_entry->ext_cap_offset = (u16) (current_ptr +
+                                        sizeof(struct ieee_types_header) -
+                                        bss_entry->beacon_buf);
+                        break;
+                case WLAN_EID_OVERLAP_BSS_SCAN_PARAM:
+                        bss_entry->bcn_obss_scan =
+                                (struct ieee_types_obss_scan_param *)
+                                current_ptr;
+                        bss_entry->overlap_bss_offset = (u16) (current_ptr -
+                                                        bss_entry->beacon_buf);
+                        break;
+                default:
+                        break;
+                }
+                current_ptr += element_len + 2;
+                /* Need to account for IE ID and IE Len */
+                bytes_left_for_current_beacon -= (element_len + 2);
+        }       /* while (bytes_left_for_current_beacon > 2) */
+        return ret;
+}
+/*
+ * This function adjusts the pointers used in beacon buffers to reflect
+ * shifts.
+ *
+ * The memory allocated for beacon buffers is of fixed sizes where all the
+ * saved beacons must be stored. New beacons are added in the free portion
+ * of this memory, space permitting; while duplicate beacon buffers are
+ * placed at the same start location. However, since duplicate beacon
+ * buffers may not match the size of the old one, all the following buffers
+ * in the memory must be shifted to either make space, or to fill up freed
+ * up space.
+ *
+ * This function is used to update the beacon buffer pointers that are past
+ * an existing beacon buffer that is updated with a new one of different
+ * size. The pointers are shifted by a fixed amount, either forward or
+ * backward.
+ *
+ * the following pointers in every affected beacon buffers are changed, if
+ * present -
+ *      - WPA IE pointer
+ *      - RSN IE pointer
+ *      - WAPI IE pointer
+ *      - HT capability IE pointer
+ *      - HT information IE pointer
+ *      - BSS coexistence 20/40 IE pointer
+ *      - Extended capability IE pointer
+ *      - Overlapping BSS scan parameter IE pointer
+ */
+static void
+mwifiex_adjust_beacon_buffer_ptrs(struct mwifiex_private *priv, u8 advance,
+                                  u8 *bcn_store, u32 rem_bcn_size,
+                                  u32 num_of_ent)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        u32 adj_idx;
+        for (adj_idx = 0; adj_idx < num_of_ent; adj_idx++) {
+                if (adapter->scan_table[adj_idx].beacon_buf > bcn_store) {
+                        if (advance)
+                                adapter->scan_table[adj_idx].beacon_buf +=
+                                        rem_bcn_size;
+                        else
+                                adapter->scan_table[adj_idx].beacon_buf -=
+                                        rem_bcn_size;
+                        if (adapter->scan_table[adj_idx].bcn_wpa_ie)
+                                adapter->scan_table[adj_idx].bcn_wpa_ie =
+                                (struct ieee_types_vendor_specific *)
+                                (adapter->scan_table[adj_idx].beacon_buf +
+                                 adapter->scan_table[adj_idx].wpa_offset);
+                        if (adapter->scan_table[adj_idx].bcn_rsn_ie)
+                                adapter->scan_table[adj_idx].bcn_rsn_ie =
+                                (struct ieee_types_generic *)
+                                (adapter->scan_table[adj_idx].beacon_buf +
+                                 adapter->scan_table[adj_idx].rsn_offset);
+                        if (adapter->scan_table[adj_idx].bcn_wapi_ie)
+                                adapter->scan_table[adj_idx].bcn_wapi_ie =
+                                (struct ieee_types_generic *)
+                                (adapter->scan_table[adj_idx].beacon_buf +
+                                 adapter->scan_table[adj_idx].wapi_offset);
+                        if (adapter->scan_table[adj_idx].bcn_ht_cap)
+                                adapter->scan_table[adj_idx].bcn_ht_cap =
+                                (struct ieee80211_ht_cap *)
+                                (adapter->scan_table[adj_idx].beacon_buf +
+                                 adapter->scan_table[adj_idx].ht_cap_offset);
+                        if (adapter->scan_table[adj_idx].bcn_ht_info)
+                                adapter->scan_table[adj_idx].bcn_ht_info =
+                                (struct ieee80211_ht_info *)
+                                (adapter->scan_table[adj_idx].beacon_buf +
+                                 adapter->scan_table[adj_idx].ht_info_offset);
+                        if (adapter->scan_table[adj_idx].bcn_bss_co_2040)
+                                adapter->scan_table[adj_idx].bcn_bss_co_2040 =
+                                (u8 *)
+                                (adapter->scan_table[adj_idx].beacon_buf +
+                               adapter->scan_table[adj_idx].bss_co_2040_offset);
+                        if (adapter->scan_table[adj_idx].bcn_ext_cap)
+                                adapter->scan_table[adj_idx].bcn_ext_cap =
+                                (u8 *)
+                                (adapter->scan_table[adj_idx].beacon_buf +
+                                 adapter->scan_table[adj_idx].ext_cap_offset);
+                        if (adapter->scan_table[adj_idx].bcn_obss_scan)
+                                adapter->scan_table[adj_idx].bcn_obss_scan =
+                                (struct ieee_types_obss_scan_param *)
+                                (adapter->scan_table[adj_idx].beacon_buf +
+                               adapter->scan_table[adj_idx].overlap_bss_offset);
+                }
+        }
+}
+/*
+ * This function updates the pointers used in beacon buffer for given bss
+ * descriptor to reflect shifts
+ *
+ * Following pointers are updated
+ *      - WPA IE pointer
+ *      - RSN IE pointer
+ *      - WAPI IE pointer
+ *      - HT capability IE pointer
+ *      - HT information IE pointer
+ *      - BSS coexistence 20/40 IE pointer
+ *      - Extended capability IE pointer
+ *      - Overlapping BSS scan parameter IE pointer
+ */
+static void
+mwifiex_update_beacon_buffer_ptrs(struct mwifiex_bssdescriptor *beacon)
+{
+        if (beacon->bcn_wpa_ie)
+                beacon->bcn_wpa_ie = (struct ieee_types_vendor_specific *)
+                        (beacon->beacon_buf + beacon->wpa_offset);
+        if (beacon->bcn_rsn_ie)
+                beacon->bcn_rsn_ie = (struct ieee_types_generic *)
+                        (beacon->beacon_buf + beacon->rsn_offset);
+        if (beacon->bcn_wapi_ie)
+                beacon->bcn_wapi_ie = (struct ieee_types_generic *)
+                        (beacon->beacon_buf + beacon->wapi_offset);
+        if (beacon->bcn_ht_cap)
+                beacon->bcn_ht_cap = (struct ieee80211_ht_cap *)
+                        (beacon->beacon_buf + beacon->ht_cap_offset);
+        if (beacon->bcn_ht_info)
+                beacon->bcn_ht_info = (struct ieee80211_ht_info *)
+                        (beacon->beacon_buf + beacon->ht_info_offset);
+        if (beacon->bcn_bss_co_2040)
+                beacon->bcn_bss_co_2040 = (u8 *) (beacon->beacon_buf +
+                        beacon->bss_co_2040_offset);
+        if (beacon->bcn_ext_cap)
+                beacon->bcn_ext_cap = (u8 *) (beacon->beacon_buf +
+                        beacon->ext_cap_offset);
+        if (beacon->bcn_obss_scan)
+                beacon->bcn_obss_scan = (struct ieee_types_obss_scan_param *)
+                        (beacon->beacon_buf + beacon->overlap_bss_offset);
+}
+/*
+ * This function stores a beacon or probe response for a BSS returned
+ * in the scan.
+ *
+ * This stores a new scan response or an update for a previous scan response.
+ * New entries need to verify that they do not exceed the total amount of
+ * memory allocated for the table.
+ *
+ * Replacement entries need to take into consideration the amount of space
+ * currently allocated for the beacon/probe response and adjust the entry
+ * as needed.
+ *
+ * A small amount of extra pad (SCAN_BEACON_ENTRY_PAD) is generally reserved
+ * for an entry in case it is a beacon since a probe response for the
+ * network will by larger per the standard.  This helps to reduce the
+ * amount of memory copying to fit a new probe response into an entry
+ * already occupied by a network's previously stored beacon.
+ */
+static void
+mwifiex_ret_802_11_scan_store_beacon(struct mwifiex_private *priv,
+                                     u32 beacon_idx, u32 num_of_ent,
+                                     struct mwifiex_bssdescriptor *new_beacon)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        u8 *bcn_store;
+        u32 new_bcn_size;
+        u32 old_bcn_size;
+        u32 bcn_space;
+        if (adapter->scan_table[beacon_idx].beacon_buf) {
+                new_bcn_size = new_beacon->beacon_buf_size;
+                old_bcn_size = adapter->scan_table[beacon_idx].beacon_buf_size;
+                bcn_space = adapter->scan_table[beacon_idx].beacon_buf_size_max;
+                bcn_store = adapter->scan_table[beacon_idx].beacon_buf;
+                /* Set the max to be the same as current entry unless changed
+                   below */
+                new_beacon->beacon_buf_size_max = bcn_space;
+                if (new_bcn_size == old_bcn_size) {
+                        /*
+                         * Beacon is the same size as the previous entry.
+                         *   Replace the previous contents with the scan result
+                         */
+                        memcpy(bcn_store, new_beacon->beacon_buf,
+                               new_beacon->beacon_buf_size);
+                } else if (new_bcn_size <= bcn_space) {
+                        /*
+                         * New beacon size will fit in the amount of space
+                         *   we have previously allocated for it
+                         */
+                        /* Copy the new beacon buffer entry over the old one */
+                        memcpy(bcn_store, new_beacon->beacon_buf, new_bcn_size);
+                        /*
+                         *  If the old beacon size was less than the maximum
+                         *  we had alloted for the entry, and the new entry
+                         *  is even smaller, reset the max size to the old
+                         *  beacon entry and compress the storage space
+                         *  (leaving a new pad space of (old_bcn_size -
+                         *  new_bcn_size).
+                         */
+                        if (old_bcn_size < bcn_space
+                            && new_bcn_size <= old_bcn_size) {
+                                /*
+                                 * Old Beacon size is smaller than the alloted
+                                 * storage size. Shrink the alloted storage
+                                 * space.
+                                 */
+                                dev_dbg(adapter->dev, "info: AppControl:"
+                                        " smaller duplicate beacon "
+                                       "(%d), old = %d, new = %d, space = %d,"
+                                       "left = %d\n",
+                                       beacon_idx, old_bcn_size, new_bcn_size,
+                                       bcn_space,
+                                       (int)(sizeof(adapter->bcn_buf) -
+                                        (adapter->bcn_buf_end -
+                                         adapter->bcn_buf)));
+                                /*
+                                 *  memmove (since the memory overlaps) the
+                                 *  data after the beacon we just stored to the
+                                 *  end of the current beacon.  This cleans up
+                                 *  any unused space the old larger beacon was
+                                 *  using in the buffer
+                                 */
+                                memmove(bcn_store + old_bcn_size,
+                                        bcn_store + bcn_space,
+                                        adapter->bcn_buf_end - (bcn_store +
+                                                                   bcn_space));
+                                /*
+                                 * Decrement the end pointer by the difference
+                                 * between the old larger size and the new
+                                 * smaller size since we are using less space
+                                 * due to the new beacon being smaller
+                                 */
+                                adapter->bcn_buf_end -=
+                                        (bcn_space - old_bcn_size);
+                                /* Set the maximum storage size to the old
+                                   beacon size */
+                                new_beacon->beacon_buf_size_max = old_bcn_size;
+                                /* Adjust beacon buffer pointers that are past
+                                   the current */
+                                mwifiex_adjust_beacon_buffer_ptrs(priv, 0,
+                                        bcn_store, (bcn_space - old_bcn_size),
+                                        num_of_ent);
+                        }
+                } else if (adapter->bcn_buf_end + (new_bcn_size - bcn_space)
+                           < (adapter->bcn_buf + sizeof(adapter->bcn_buf))) {
+                        /*
+                         * Beacon is larger than space previously allocated
+                         * (bcn_space) and there is enough space left in the
+                         * beaconBuffer to store the additional data
+                         */
+                        dev_dbg(adapter->dev, "info: AppControl:"
+                                " larger duplicate beacon (%d), "
+                               "old = %d, new = %d, space = %d, left = %d\n",
+                               beacon_idx, old_bcn_size, new_bcn_size,
+                               bcn_space,
+                               (int)(sizeof(adapter->bcn_buf) -
+                                (adapter->bcn_buf_end -
+                                 adapter->bcn_buf)));
+                        /*
+                         * memmove (since the memory overlaps) the data
+                         *  after the beacon we just stored to the end of
+                         *  the current beacon.  This moves the data for
+                         *  the beacons after this further in memory to
+                         *  make space for the new larger beacon we are
+                         *  about to copy in.
+                         */
+                        memmove(bcn_store + new_bcn_size,
+                                bcn_store + bcn_space,
+                                adapter->bcn_buf_end - (bcn_store + bcn_space));
+                        /* Copy the new beacon buffer entry over the old one */
+                        memcpy(bcn_store, new_beacon->beacon_buf, new_bcn_size);
+                        /* Move the beacon end pointer by the amount of new
+                           beacon data we are adding */
+                        adapter->bcn_buf_end += (new_bcn_size - bcn_space);
+                        /*
+                         * This entry is bigger than the alloted max space
+                         *  previously reserved.  Increase the max space to
+                         *  be equal to the new beacon size
+                         */
+                        new_beacon->beacon_buf_size_max = new_bcn_size;
+                        /* Adjust beacon buffer pointers that are past the
+                           current */
+                        mwifiex_adjust_beacon_buffer_ptrs(priv, 1, bcn_store,
+                                                (new_bcn_size - bcn_space),
+                                                num_of_ent);
+                } else {
+                        /*
+                         * Beacon is larger than the previously allocated space,
+                         * but there is not enough free space to store the
+                         * additional data.
+                         */
+                        dev_err(adapter->dev, "AppControl: larger duplicate "
+                                " beacon (%d), old = %d new = %d, space = %d,"
+                                " left = %d\n", beacon_idx, old_bcn_size,
+                                new_bcn_size, bcn_space,
+                                (int)(sizeof(adapter->bcn_buf) -
+                                (adapter->bcn_buf_end - adapter->bcn_buf)));
+                        /* Storage failure, keep old beacon intact */
+                        new_beacon->beacon_buf_size = old_bcn_size;
+                        if (new_beacon->bcn_wpa_ie)
+                                new_beacon->wpa_offset =
+                                        adapter->scan_table[beacon_idx].
+                                        wpa_offset;
+                        if (new_beacon->bcn_rsn_ie)
+                                new_beacon->rsn_offset =
+                                        adapter->scan_table[beacon_idx].
+                                        rsn_offset;
+                        if (new_beacon->bcn_wapi_ie)
+                                new_beacon->wapi_offset =
+                                        adapter->scan_table[beacon_idx].
+                                        wapi_offset;
+                        if (new_beacon->bcn_ht_cap)
+                                new_beacon->ht_cap_offset =
+                                        adapter->scan_table[beacon_idx].
+                                        ht_cap_offset;
+                        if (new_beacon->bcn_ht_info)
+                                new_beacon->ht_info_offset =
+                                        adapter->scan_table[beacon_idx].
+                                        ht_info_offset;
+                        if (new_beacon->bcn_bss_co_2040)
+                                new_beacon->bss_co_2040_offset =
+                                        adapter->scan_table[beacon_idx].
+                                        bss_co_2040_offset;
+                        if (new_beacon->bcn_ext_cap)
+                                new_beacon->ext_cap_offset =
+                                        adapter->scan_table[beacon_idx].
+                                        ext_cap_offset;
+                        if (new_beacon->bcn_obss_scan)
+                                new_beacon->overlap_bss_offset =
+                                        adapter->scan_table[beacon_idx].
+                                        overlap_bss_offset;
+                }
+                /* Point the new entry to its permanent storage space */
+                new_beacon->beacon_buf = bcn_store;
+                mwifiex_update_beacon_buffer_ptrs(new_beacon);
+        } else {
+                /*
+                 * No existing beacon data exists for this entry, check to see
+                 *   if we can fit it in the remaining space
+                 */
+                if (adapter->bcn_buf_end + new_beacon->beacon_buf_size +
+                    SCAN_BEACON_ENTRY_PAD < (adapter->bcn_buf +
+                                             sizeof(adapter->bcn_buf))) {
+                        /*
+                         * Copy the beacon buffer data from the local entry to
+                         * the adapter dev struct buffer space used to store
+                         * the raw beacon data for each entry in the scan table
+                         */
+                        memcpy(adapter->bcn_buf_end, new_beacon->beacon_buf,
+                               new_beacon->beacon_buf_size);
+                        /* Update the beacon ptr to point to the table save
+                           area */
+                        new_beacon->beacon_buf = adapter->bcn_buf_end;
+                        new_beacon->beacon_buf_size_max =
+                                (new_beacon->beacon_buf_size +
+                                 SCAN_BEACON_ENTRY_PAD);
+                        mwifiex_update_beacon_buffer_ptrs(new_beacon);
+                        /* Increment the end pointer by the size reserved */
+                        adapter->bcn_buf_end += new_beacon->beacon_buf_size_max;
+                        dev_dbg(adapter->dev, "info: AppControl: beacon[%02d]"
+                                " sz=%03d, used = %04d, left = %04d\n",
+                               beacon_idx,
+                               new_beacon->beacon_buf_size,
+                               (int)(adapter->bcn_buf_end - adapter->bcn_buf),
+                               (int)(sizeof(adapter->bcn_buf) -
+                                (adapter->bcn_buf_end -
+                                 adapter->bcn_buf)));
+                } else {
+                        /* No space for new beacon */
+                        dev_dbg(adapter->dev, "info: AppControl: no space for"
+                                " beacon (%d): %pM sz=%03d, left=%03d\n",
+                               beacon_idx, new_beacon->mac_address,
+                               new_beacon->beacon_buf_size,
+                               (int)(sizeof(adapter->bcn_buf) -
+                                (adapter->bcn_buf_end -
+                                 adapter->bcn_buf)));
+                        /* Storage failure; clear storage records for this
+                           bcn */
+                        new_beacon->beacon_buf = NULL;
+                        new_beacon->beacon_buf_size = 0;
+                        new_beacon->beacon_buf_size_max = 0;
+                        new_beacon->bcn_wpa_ie = NULL;
+                        new_beacon->wpa_offset = 0;
+                        new_beacon->bcn_rsn_ie = NULL;
+                        new_beacon->rsn_offset = 0;
+                        new_beacon->bcn_wapi_ie = NULL;
+                        new_beacon->wapi_offset = 0;
+                        new_beacon->bcn_ht_cap = NULL;
+                        new_beacon->ht_cap_offset = 0;
+                        new_beacon->bcn_ht_info = NULL;
+                        new_beacon->ht_info_offset = 0;
+                        new_beacon->bcn_bss_co_2040 = NULL;
+                        new_beacon->bss_co_2040_offset = 0;
+                        new_beacon->bcn_ext_cap = NULL;
+                        new_beacon->ext_cap_offset = 0;
+                        new_beacon->bcn_obss_scan = NULL;
+                        new_beacon->overlap_bss_offset = 0;
+                }
+        }
+}
+/*
+ * This function restores a beacon buffer of the current BSS descriptor.
+ */
+static void mwifiex_restore_curr_bcn(struct mwifiex_private *priv)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_bssdescriptor *curr_bss =
+                &priv->curr_bss_params.bss_descriptor;
+        unsigned long flags;
+        if (priv->curr_bcn_buf &&
+            ((adapter->bcn_buf_end + priv->curr_bcn_size) <
+             (adapter->bcn_buf + sizeof(adapter->bcn_buf)))) {
+                spin_lock_irqsave(&priv->curr_bcn_buf_lock, flags);
+                /* restore the current beacon buffer */
+                memcpy(adapter->bcn_buf_end, priv->curr_bcn_buf,
+                       priv->curr_bcn_size);
+                curr_bss->beacon_buf = adapter->bcn_buf_end;
+                curr_bss->beacon_buf_size = priv->curr_bcn_size;
+                adapter->bcn_buf_end += priv->curr_bcn_size;
+                /* adjust the pointers in the current BSS descriptor */
+                if (curr_bss->bcn_wpa_ie)
+                        curr_bss->bcn_wpa_ie =
+                                (struct ieee_types_vendor_specific *)
+                                (curr_bss->beacon_buf +
+                                 curr_bss->wpa_offset);
+                if (curr_bss->bcn_rsn_ie)
+                        curr_bss->bcn_rsn_ie = (struct ieee_types_generic *)
+                                (curr_bss->beacon_buf +
+                                 curr_bss->rsn_offset);
+                if (curr_bss->bcn_ht_cap)
+                        curr_bss->bcn_ht_cap = (struct ieee80211_ht_cap *)
+                                (curr_bss->beacon_buf +
+                                 curr_bss->ht_cap_offset);
+                if (curr_bss->bcn_ht_info)
+                        curr_bss->bcn_ht_info = (struct ieee80211_ht_info *)
+                                (curr_bss->beacon_buf +
+                                 curr_bss->ht_info_offset);
+                if (curr_bss->bcn_bss_co_2040)
+                        curr_bss->bcn_bss_co_2040 =
+                                (u8 *) (curr_bss->beacon_buf +
+                                 curr_bss->bss_co_2040_offset);
+                if (curr_bss->bcn_ext_cap)
+                        curr_bss->bcn_ext_cap = (u8 *) (curr_bss->beacon_buf +
+                                 curr_bss->ext_cap_offset);
+                if (curr_bss->bcn_obss_scan)
+                        curr_bss->bcn_obss_scan =
+                                (struct ieee_types_obss_scan_param *)
+                                (curr_bss->beacon_buf +
+                                 curr_bss->overlap_bss_offset);
+                spin_unlock_irqrestore(&priv->curr_bcn_buf_lock, flags);
+                dev_dbg(adapter->dev, "info: current beacon restored %d\n",
+                       priv->curr_bcn_size);
+        } else {
+                dev_warn(adapter->dev,
+                        "curr_bcn_buf not saved or bcn_buf has no space\n");
+        }
+}
+/*
+ * This function post processes the scan table after a new scan command has
+ * completed.
+ *
+ * It inspects each entry of the scan table and tries to find an entry that
+ * matches with our current associated/joined network from the scan. If
+ * one is found, the stored copy of the BSS descriptor of our current network
+ * is updated.
+ *
+ * It also debug dumps the current scan table contents after processing is over.
+ */
+static void
+mwifiex_process_scan_results(struct mwifiex_private *priv)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        s32 j;
+        u32 i;
+        unsigned long flags;
+        if (priv->media_connected) {
+                j = mwifiex_find_ssid_in_list(priv, &priv->curr_bss_params.
+                                              bss_descriptor.ssid,
+                                              priv->curr_bss_params.
+                                              bss_descriptor.mac_address,
+                                              priv->bss_mode);
+                if (j >= 0) {
+                        spin_lock_irqsave(&priv->curr_bcn_buf_lock, flags);
+                        priv->curr_bss_params.bss_descriptor.bcn_wpa_ie = NULL;
+                        priv->curr_bss_params.bss_descriptor.wpa_offset = 0;
+                        priv->curr_bss_params.bss_descriptor.bcn_rsn_ie = NULL;
+                        priv->curr_bss_params.bss_descriptor.rsn_offset = 0;
+                        priv->curr_bss_params.bss_descriptor.bcn_wapi_ie = NULL;
+                        priv->curr_bss_params.bss_descriptor.wapi_offset = 0;
+                        priv->curr_bss_params.bss_descriptor.bcn_ht_cap = NULL;
+                        priv->curr_bss_params.bss_descriptor.ht_cap_offset =
+                                0;
+                        priv->curr_bss_params.bss_descriptor.bcn_ht_info = NULL;
+                        priv->curr_bss_params.bss_descriptor.ht_info_offset =
+                                0;
+                        priv->curr_bss_params.bss_descriptor.bcn_bss_co_2040 =
+                                NULL;
+                        priv->curr_bss_params.bss_descriptor.
+                                bss_co_2040_offset = 0;
+                        priv->curr_bss_params.bss_descriptor.bcn_ext_cap = NULL;
+                        priv->curr_bss_params.bss_descriptor.ext_cap_offset = 0;
+                        priv->curr_bss_params.bss_descriptor.
+                                bcn_obss_scan = NULL;
+                        priv->curr_bss_params.bss_descriptor.
+                                overlap_bss_offset = 0;
+                        priv->curr_bss_params.bss_descriptor.beacon_buf = NULL;
+                        priv->curr_bss_params.bss_descriptor.beacon_buf_size =
+                                0;
+                        priv->curr_bss_params.bss_descriptor.
+                                beacon_buf_size_max = 0;
+                        dev_dbg(adapter->dev, "info: Found current ssid/bssid"
+                                " in list @ index #%d\n", j);
+                        /* Make a copy of current BSSID descriptor */
+                        memcpy(&priv->curr_bss_params.bss_descriptor,
+                               &adapter->scan_table[j],
+                               sizeof(priv->curr_bss_params.bss_descriptor));
+                        mwifiex_save_curr_bcn(priv);
+                        spin_unlock_irqrestore(&priv->curr_bcn_buf_lock, flags);
+                } else {
+                        mwifiex_restore_curr_bcn(priv);
+                }
+        }
+        for (i = 0; i < adapter->num_in_scan_table; i++)
+                dev_dbg(adapter->dev, "info: scan:(%02d) %pM "
+                       "RSSI[%03d], SSID[%s]\n",
+                       i, adapter->scan_table[i].mac_address,
+                       (s32) adapter->scan_table[i].rssi,
+                       adapter->scan_table[i].ssid.ssid);
+}
+/*
+ * This function converts radio type scan parameter to a band configuration
+ * to be used in join command.
+ */
+static u8
+mwifiex_radio_type_to_band(u8 radio_type)
+{
+        switch (radio_type) {
+        case HostCmd_SCAN_RADIO_TYPE_A:
+                return BAND_A;
+        case HostCmd_SCAN_RADIO_TYPE_BG:
+        default:
+                return BAND_G;
+        }
+}
+/*
+ * This function deletes a specific indexed entry from the scan table.
+ *
+ * This also compacts the remaining entries and adjusts any buffering
+ * of beacon/probe response data if needed.
+ */
+static void
+mwifiex_scan_delete_table_entry(struct mwifiex_private *priv, s32 table_idx)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        u32 del_idx;
+        u32 beacon_buf_adj;
+        u8 *beacon_buf;
+        /*
+         * Shift the saved beacon buffer data for the scan table back over the
+         *   entry being removed.  Update the end of buffer pointer.  Save the
+         *   deleted buffer allocation size for pointer adjustments for entries
+         *   compacted after the deleted index.
+         */
+        beacon_buf_adj = adapter->scan_table[table_idx].beacon_buf_size_max;
+        dev_dbg(adapter->dev, "info: Scan: Delete Entry %d, beacon buffer "
+                "removal = %d bytes\n", table_idx, beacon_buf_adj);
+        /* Check if the table entry had storage allocated for its beacon */
+        if (beacon_buf_adj) {
+                beacon_buf = adapter->scan_table[table_idx].beacon_buf;
+                /*
+                 * Remove the entry's buffer space, decrement the table end
+                 * pointer by the amount we are removing
+                 */
+                adapter->bcn_buf_end -= beacon_buf_adj;
+                dev_dbg(adapter->dev, "info: scan: delete entry %d,"
+                        " compact data: %p <- %p (sz = %d)\n",
+                       table_idx, beacon_buf,
+                       beacon_buf + beacon_buf_adj,
+                       (int)(adapter->bcn_buf_end - beacon_buf));
+                /*
+                 * Compact data storage.  Copy all data after the deleted
+                 * entry's end address (beacon_buf + beacon_buf_adj) back
+                 * to the original start address (beacon_buf).
+                 *
+                 * Scan table entries affected by the move will have their
+                 * entry pointer adjusted below.
+                 *
+                 * Use memmove since the dest/src memory regions overlap.
+                 */
+                memmove(beacon_buf, beacon_buf + beacon_buf_adj,
+                        adapter->bcn_buf_end - beacon_buf);
+        }
+        dev_dbg(adapter->dev,
+                "info: Scan: Delete Entry %d, num_in_scan_table = %d\n",
+               table_idx, adapter->num_in_scan_table);
+        /* Shift all of the entries after the table_idx back by one, compacting
+           the table and removing the requested entry */
+        for (del_idx = table_idx; (del_idx + 1) < adapter->num_in_scan_table;
+             del_idx++) {
+                /* Copy the next entry over this one */
+                memcpy(adapter->scan_table + del_idx,
+                       adapter->scan_table + del_idx + 1,
+                       sizeof(struct mwifiex_bssdescriptor));
+                /*
+                 * Adjust this entry's pointer to its beacon buffer based on
+                 * the removed/compacted entry from the deleted index.  Don't
+                 * decrement if the buffer pointer is NULL (no data stored for
+                 * this entry).
+                 */
+                if (adapter->scan_table[del_idx].beacon_buf) {
+                        adapter->scan_table[del_idx].beacon_buf -=
+                                beacon_buf_adj;
+                        if (adapter->scan_table[del_idx].bcn_wpa_ie)
+                                adapter->scan_table[del_idx].bcn_wpa_ie =
+                                        (struct ieee_types_vendor_specific *)
+                                        (adapter->scan_table[del_idx].
+                                         beacon_buf +
+                                         adapter->scan_table[del_idx].
+                                         wpa_offset);
+                        if (adapter->scan_table[del_idx].bcn_rsn_ie)
+                                adapter->scan_table[del_idx].bcn_rsn_ie =
+                                        (struct ieee_types_generic *)
+                                        (adapter->scan_table[del_idx].
+                                         beacon_buf +
+                                         adapter->scan_table[del_idx].
+                                         rsn_offset);
+                        if (adapter->scan_table[del_idx].bcn_wapi_ie)
+                                adapter->scan_table[del_idx].bcn_wapi_ie =
+                                        (struct ieee_types_generic *)
+                                        (adapter->scan_table[del_idx].beacon_buf
+                                         + adapter->scan_table[del_idx].
+                                         wapi_offset);
+                        if (adapter->scan_table[del_idx].bcn_ht_cap)
+                                adapter->scan_table[del_idx].bcn_ht_cap =
+                                        (struct ieee80211_ht_cap *)
+                                        (adapter->scan_table[del_idx].beacon_buf
+                                         + adapter->scan_table[del_idx].
+                                          ht_cap_offset);
+                        if (adapter->scan_table[del_idx].bcn_ht_info)
+                                adapter->scan_table[del_idx].bcn_ht_info =
+                                        (struct ieee80211_ht_info *)
+                                        (adapter->scan_table[del_idx].beacon_buf
+                                         + adapter->scan_table[del_idx].
+                                          ht_info_offset);
+                        if (adapter->scan_table[del_idx].bcn_bss_co_2040)
+                                adapter->scan_table[del_idx].bcn_bss_co_2040 =
+                                        (u8 *)
+                                        (adapter->scan_table[del_idx].beacon_buf
+                                         + adapter->scan_table[del_idx].
+                                           bss_co_2040_offset);
+                        if (adapter->scan_table[del_idx].bcn_ext_cap)
+                                adapter->scan_table[del_idx].bcn_ext_cap =
+                                        (u8 *)
+                                        (adapter->scan_table[del_idx].beacon_buf
+                                         + adapter->scan_table[del_idx].
+                                             ext_cap_offset);
+                        if (adapter->scan_table[del_idx].bcn_obss_scan)
+                                adapter->scan_table[del_idx].
+                                        bcn_obss_scan =
+                                        (struct ieee_types_obss_scan_param *)
+                                        (adapter->scan_table[del_idx].beacon_buf
+                                         + adapter->scan_table[del_idx].
+                                             overlap_bss_offset);
+                }
+        }
+        /* The last entry is invalid now that it has been deleted or moved
+           back */
+        memset(adapter->scan_table + adapter->num_in_scan_table - 1,
+               0x00, sizeof(struct mwifiex_bssdescriptor));
+        adapter->num_in_scan_table--;
+}
+/*
+ * This function deletes all occurrences of a given SSID from the scan table.
+ *
+ * This iterates through the scan table and deletes all entries that match
+ * the given SSID. It also compacts the remaining scan table entries.
+ */
+static int
+mwifiex_scan_delete_ssid_table_entry(struct mwifiex_private *priv,
+                                     struct mwifiex_802_11_ssid *del_ssid)
+{
+        s32 table_idx = -1;
+        dev_dbg(priv->adapter->dev, "info: scan: delete ssid entry: %-32s\n",
+                        del_ssid->ssid);
+        /* If the requested SSID is found in the table, delete it.  Then keep
+           searching the table for multiple entires for the SSID until no
+           more are found */
+        while ((table_idx = mwifiex_find_ssid_in_list(priv, del_ssid, NULL,
+                                        NL80211_IFTYPE_UNSPECIFIED)) >= 0) {
+                dev_dbg(priv->adapter->dev,
+                        "info: Scan: Delete SSID Entry: Found Idx = %d\n",
+                       table_idx);
+                mwifiex_scan_delete_table_entry(priv, table_idx);
+        }
+        return table_idx == -1 ? -1 : 0;
+}
+/*
+ * This is an internal function used to start a scan based on an input
+ * configuration.
+ *
+ * This uses the input user scan configuration information when provided in
+ * order to send the appropriate scan commands to firmware to populate or
+ * update the internal driver scan table.
+ */
+int mwifiex_scan_networks(struct mwifiex_private *priv,
+                          const struct mwifiex_user_scan_cfg *user_scan_in)
+{
+        int ret = 0;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct cmd_ctrl_node *cmd_node;
+        union mwifiex_scan_cmd_config_tlv *scan_cfg_out;
+        struct mwifiex_ie_types_chan_list_param_set *chan_list_out;
+        u32 buf_size;
+        struct mwifiex_chan_scan_param_set *scan_chan_list;
+        u8 keep_previous_scan;
+        u8 filtered_scan;
+        u8 scan_current_chan_only;
+        u8 max_chan_per_scan;
+        unsigned long flags;
+        if (adapter->scan_processing) {
+                dev_dbg(adapter->dev, "cmd: Scan already in process...\n");
+                return ret;
+        }
+        spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+        adapter->scan_processing = true;
+        spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+        if (priv->scan_block) {
+                dev_dbg(adapter->dev,
+                        "cmd: Scan is blocked during association...\n");
+                return ret;
+        }
+        scan_cfg_out = kzalloc(sizeof(union mwifiex_scan_cmd_config_tlv),
+                                        GFP_KERNEL);
+        if (!scan_cfg_out) {
+                dev_err(adapter->dev, "failed to alloc scan_cfg_out\n");
+                return -ENOMEM;
+        }
+        buf_size = sizeof(struct mwifiex_chan_scan_param_set) *
+                        MWIFIEX_USER_SCAN_CHAN_MAX;
+        scan_chan_list = kzalloc(buf_size, GFP_KERNEL);
+        if (!scan_chan_list) {
+                dev_err(adapter->dev, "failed to alloc scan_chan_list\n");
+                kfree(scan_cfg_out);
+                return -ENOMEM;
+        }
+        keep_previous_scan = false;
+        mwifiex_scan_setup_scan_config(priv, user_scan_in,
+                                       &scan_cfg_out->config, &chan_list_out,
+                                       scan_chan_list, &max_chan_per_scan,
+                                       &filtered_scan, &scan_current_chan_only);
+        if (user_scan_in)
+                keep_previous_scan = user_scan_in->keep_previous_scan;
+        if (!keep_previous_scan) {
+                memset(adapter->scan_table, 0x00,
+                       sizeof(struct mwifiex_bssdescriptor) * IW_MAX_AP);
+                adapter->num_in_scan_table = 0;
+                adapter->bcn_buf_end = adapter->bcn_buf;
+        }
+        ret = mwifiex_scan_channel_list(priv, max_chan_per_scan, filtered_scan,
+                                        &scan_cfg_out->config, chan_list_out,
+                                        scan_chan_list);
+        /* Get scan command from scan_pending_q and put to cmd_pending_q */
+        if (!ret) {
+                spin_lock_irqsave(&adapter->scan_pending_q_lock, flags);
+                if (!list_empty(&adapter->scan_pending_q)) {
+                        cmd_node = list_first_entry(&adapter->scan_pending_q,
+                                                struct cmd_ctrl_node, list);
+                        list_del(&cmd_node->list);
+                        spin_unlock_irqrestore(&adapter->scan_pending_q_lock,
+                                                                        flags);
+                        mwifiex_insert_cmd_to_pending_q(adapter, cmd_node,
+                                                        true);
+                } else {
+                        spin_unlock_irqrestore(&adapter->scan_pending_q_lock,
+                                               flags);
+                }
+        } else {
+                spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+                adapter->scan_processing = true;
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+        }
+        kfree(scan_cfg_out);
+        kfree(scan_chan_list);
+        return ret;
+}
+/*
+ * This function prepares a scan command to be sent to the firmware.
+ *
+ * This uses the scan command configuration sent to the command processing
+ * module in command preparation stage to configure a scan command structure
+ * to send to firmware.
+ *
+ * The fixed fields specifying the BSS type and BSSID filters as well as a
+ * variable number/length of TLVs are sent in the command to firmware.
+ *
+ * Preparation also includes -
+ *      - Setting command ID, and proper size
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_802_11_scan(struct host_cmd_ds_command *cmd, void *data_buf)
+{
+        struct host_cmd_ds_802_11_scan *scan_cmd = &cmd->params.scan;
+        struct mwifiex_scan_cmd_config *scan_cfg;
+        scan_cfg = (struct mwifiex_scan_cmd_config *) data_buf;
+        /* Set fixed field variables in scan command */
+        scan_cmd->bss_mode = scan_cfg->bss_mode;
+        memcpy(scan_cmd->bssid, scan_cfg->specific_bssid,
+               sizeof(scan_cmd->bssid));
+        memcpy(scan_cmd->tlv_buffer, scan_cfg->tlv_buf, scan_cfg->tlv_buf_len);
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_SCAN);
+        /* Size is equal to the sizeof(fixed portions) + the TLV len + header */
+        cmd->size = cpu_to_le16((u16) (sizeof(scan_cmd->bss_mode)
+                                          + sizeof(scan_cmd->bssid)
+                                          + scan_cfg->tlv_buf_len + S_DS_GEN));
+        return 0;
+}
+/*
+ * This function handles the command response of scan.
+ *
+ * The response buffer for the scan command has the following
+ * memory layout:
+ *
+ *      .-------------------------------------------------------------.
+ *      |  Header (4 * sizeof(t_u16)):  Standard command response hdr |
+ *      .-------------------------------------------------------------.
+ *      |  BufSize (t_u16) : sizeof the BSS Description data          |
+ *      .-------------------------------------------------------------.
+ *      |  NumOfSet (t_u8) : Number of BSS Descs returned             |
+ *      .-------------------------------------------------------------.
+ *      |  BSSDescription data (variable, size given in BufSize)      |
+ *      .-------------------------------------------------------------.
+ *      |  TLV data (variable, size calculated using Header->Size,    |
+ *      |            BufSize and sizeof the fixed fields above)       |
+ *      .-------------------------------------------------------------.
+ */
+int mwifiex_ret_802_11_scan(struct mwifiex_private *priv,
+                            struct host_cmd_ds_command *resp)
+{
+        int ret = 0;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct cmd_ctrl_node *cmd_node;
+        struct host_cmd_ds_802_11_scan_rsp *scan_rsp;
+        struct mwifiex_bssdescriptor *bss_new_entry = NULL;
+        struct mwifiex_ie_types_data *tlv_data;
+        struct mwifiex_ie_types_tsf_timestamp *tsf_tlv;
+        u8 *bss_info;
+        u32 scan_resp_size;
+        u32 bytes_left;
+        u32 num_in_table;
+        u32 bss_idx;
+        u32 idx;
+        u32 tlv_buf_size;
+        long long tsf_val;
+        struct mwifiex_chan_freq_power *cfp;
+        struct mwifiex_ie_types_chan_band_list_param_set *chan_band_tlv;
+        struct chan_band_param_set *chan_band;
+        u8 band;
+        u8 is_bgscan_resp;
+        unsigned long flags;
+        is_bgscan_resp = (le16_to_cpu(resp->command)
+                == HostCmd_CMD_802_11_BG_SCAN_QUERY);
+        if (is_bgscan_resp)
+                scan_rsp = &resp->params.bg_scan_query_resp.scan_resp;
+        else
+                scan_rsp = &resp->params.scan_resp;
+        if (scan_rsp->number_of_sets > IW_MAX_AP) {
+                dev_err(adapter->dev, "SCAN_RESP: too many AP returned (%d)\n",
+                       scan_rsp->number_of_sets);
+                ret = -1;
+                goto done;
+        }
+        bytes_left = le16_to_cpu(scan_rsp->bss_descript_size);
+        dev_dbg(adapter->dev, "info: SCAN_RESP: bss_descript_size %d\n",
+                                                bytes_left);
+        scan_resp_size = le16_to_cpu(resp->size);
+        dev_dbg(adapter->dev,
+                "info: SCAN_RESP: returned %d APs before parsing\n",
+               scan_rsp->number_of_sets);
+        num_in_table = adapter->num_in_scan_table;
+        bss_info = scan_rsp->bss_desc_and_tlv_buffer;
+        /*
+         * The size of the TLV buffer is equal to the entire command response
+         *   size (scan_resp_size) minus the fixed fields (sizeof()'s), the
+         *   BSS Descriptions (bss_descript_size as bytesLef) and the command
+         *   response header (S_DS_GEN)
+         */
+        tlv_buf_size = scan_resp_size - (bytes_left
+                                         + sizeof(scan_rsp->bss_descript_size)
+                                         + sizeof(scan_rsp->number_of_sets)
+                                         + S_DS_GEN);
+        tlv_data = (struct mwifiex_ie_types_data *) (scan_rsp->
+                                                 bss_desc_and_tlv_buffer +
+                                                 bytes_left);
+        /* Search the TLV buffer space in the scan response for any valid
+           TLVs */
+        mwifiex_ret_802_11_scan_get_tlv_ptrs(adapter, tlv_data, tlv_buf_size,
+                                             TLV_TYPE_TSFTIMESTAMP,
+                                             (struct mwifiex_ie_types_data **)
+                                             &tsf_tlv);
+        /* Search the TLV buffer space in the scan response for any valid
+           TLVs */
+        mwifiex_ret_802_11_scan_get_tlv_ptrs(adapter, tlv_data, tlv_buf_size,
+                                             TLV_TYPE_CHANNELBANDLIST,
+                                             (struct mwifiex_ie_types_data **)
+                                             &chan_band_tlv);
+        /*
+         *  Process each scan response returned (scan_rsp->number_of_sets).
+         *  Save the information in the bss_new_entry and then insert into the
+         *  driver scan table either as an update to an existing entry
+         *  or as an addition at the end of the table
+         */
+        bss_new_entry = kzalloc(sizeof(struct mwifiex_bssdescriptor),
+                                GFP_KERNEL);
+        if (!bss_new_entry) {
+                dev_err(adapter->dev, " failed to alloc bss_new_entry\n");
+                return -ENOMEM;
+        }
+        for (idx = 0; idx < scan_rsp->number_of_sets && bytes_left; idx++) {
+                /* Zero out the bss_new_entry we are about to store info in */
+                memset(bss_new_entry, 0x00,
+                       sizeof(struct mwifiex_bssdescriptor));
+                if (mwifiex_interpret_bss_desc_with_ie(adapter, bss_new_entry,
+                                                        &bss_info,
+                                                        &bytes_left)) {
+                        /* Error parsing/interpreting scan response, skipped */
+                        dev_err(adapter->dev, "SCAN_RESP: "
+                               "mwifiex_interpret_bss_desc_with_ie "
+                               "returned ERROR\n");
+                        continue;
+                }
+                /* Process the data fields and IEs returned for this BSS */
+                dev_dbg(adapter->dev, "info: SCAN_RESP: BSSID = %pM\n",
+                       bss_new_entry->mac_address);
+                /* Search the scan table for the same bssid */
+                for (bss_idx = 0; bss_idx < num_in_table; bss_idx++) {
+                        if (memcmp(bss_new_entry->mac_address,
+                                adapter->scan_table[bss_idx].mac_address,
+                                sizeof(bss_new_entry->mac_address))) {
+                                continue;
+                        }
+                        /*
+                         * If the SSID matches as well, it is a
+                         * duplicate of this entry.  Keep the bss_idx
+                         * set to this entry so we replace the old
+                         * contents in the table
+                         */
+                        if ((bss_new_entry->ssid.ssid_len
+                                == adapter->scan_table[bss_idx]. ssid.ssid_len)
+                                        && (!memcmp(bss_new_entry->ssid.ssid,
+                                        adapter->scan_table[bss_idx].ssid.ssid,
+                                        bss_new_entry->ssid.ssid_len))) {
+                                dev_dbg(adapter->dev, "info: SCAN_RESP:"
+                                        " duplicate of index: %d\n", bss_idx);
+                                break;
+                        }
+                }
+                /*
+                 * If the bss_idx is equal to the number of entries in
+                 * the table, the new entry was not a duplicate; append
+                 * it to the scan table
+                 */
+                if (bss_idx == num_in_table) {
+                        /* Range check the bss_idx, keep it limited to
+                           the last entry */
+                        if (bss_idx == IW_MAX_AP)
+                                bss_idx--;
+                        else
+                                num_in_table++;
+                }
+                /*
+                 * Save the beacon/probe response returned for later application
+                 * retrieval.  Duplicate beacon/probe responses are updated if
+                 * possible
+                 */
+                mwifiex_ret_802_11_scan_store_beacon(priv, bss_idx,
+                                                num_in_table, bss_new_entry);
+                /*
+                 * If the TSF TLV was appended to the scan results, save this
+                 * entry's TSF value in the networkTSF field.The networkTSF is
+                 * the firmware's TSF value at the time the beacon or probe
+                 * response was received.
+                 */
+                if (tsf_tlv) {
+                        memcpy(&tsf_val, &tsf_tlv->tsf_data[idx * TSF_DATA_SIZE]
+                                        , sizeof(tsf_val));
+                        memcpy(&bss_new_entry->network_tsf, &tsf_val,
+                                        sizeof(bss_new_entry->network_tsf));
+                }
+                band = BAND_G;
+                if (chan_band_tlv) {
+                        chan_band = &chan_band_tlv->chan_band_param[idx];
+                        band = mwifiex_radio_type_to_band(chan_band->radio_type
+                                        & (BIT(0) | BIT(1)));
+                }
+                /* Save the band designation for this entry for use in join */
+                bss_new_entry->bss_band = band;
+                cfp = mwifiex_get_cfp_by_band_and_channel_from_cfg80211(priv,
+                                        (u8) bss_new_entry->bss_band,
+                                        (u16)bss_new_entry->channel);
+                if (cfp)
+                        bss_new_entry->freq = cfp->freq;
+                else
+                        bss_new_entry->freq = 0;
+                /* Copy the locally created bss_new_entry to the scan table */
+                memcpy(&adapter->scan_table[bss_idx], bss_new_entry,
+                       sizeof(adapter->scan_table[bss_idx]));
+        }
+        dev_dbg(adapter->dev,
+                "info: SCAN_RESP: Scanned %2d APs, %d valid, %d total\n",
+               scan_rsp->number_of_sets,
+               num_in_table - adapter->num_in_scan_table, num_in_table);
+        /* Update the total number of BSSIDs in the scan table */
+        adapter->num_in_scan_table = num_in_table;
+        spin_lock_irqsave(&adapter->scan_pending_q_lock, flags);
+        if (list_empty(&adapter->scan_pending_q)) {
+                spin_unlock_irqrestore(&adapter->scan_pending_q_lock, flags);
+                spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+                adapter->scan_processing = false;
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+                /*
+                 * Process the resulting scan table:
+                 *   - Remove any bad ssids
+                 *   - Update our current BSS information from scan data
+                 */
+                mwifiex_process_scan_results(priv);
+                /* Need to indicate IOCTL complete */
+                if (adapter->curr_cmd->wait_q_enabled) {
+                        adapter->cmd_wait_q.status = 0;
+                        mwifiex_complete_cmd(adapter);
+                }
+                if (priv->report_scan_result)
+                        priv->report_scan_result = false;
+                if (priv->scan_pending_on_block) {
+                        priv->scan_pending_on_block = false;
+                        up(&priv->async_sem);
+                }
+        } else {
+                /* Get scan command from scan_pending_q and put to
+                   cmd_pending_q */
+                cmd_node = list_first_entry(&adapter->scan_pending_q,
+                                            struct cmd_ctrl_node, list);
+                list_del(&cmd_node->list);
+                spin_unlock_irqrestore(&adapter->scan_pending_q_lock, flags);
+                mwifiex_insert_cmd_to_pending_q(adapter, cmd_node, true);
+        }
+done:
+        kfree((u8 *) bss_new_entry);
+        return ret;
+}
+/*
+ * This function prepares command for background scan query.
+ *
+ * Preparation includes -
+ *      - Setting command ID and proper size
+ *      - Setting background scan flush parameter
+ *      - Ensuring correct endian-ness
+ */
+int mwifiex_cmd_802_11_bg_scan_query(struct host_cmd_ds_command *cmd)
+{
+        struct host_cmd_ds_802_11_bg_scan_query *bg_query =
+                &cmd->params.bg_scan_query;
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_BG_SCAN_QUERY);
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_802_11_bg_scan_query)
+                                + S_DS_GEN);
+        bg_query->flush = 1;
+        return 0;
+}
+/*
+ * This function finds a SSID in the scan table.
+ *
+ * A BSSID may optionally be provided to qualify the SSID.
+ * For non-Auto mode, further check is made to make sure the
+ * BSS found in the scan table is compatible with the current
+ * settings of the driver.
+ */
+s32
+mwifiex_find_ssid_in_list(struct mwifiex_private *priv,
+                          struct mwifiex_802_11_ssid *ssid, u8 *bssid,
+                          u32 mode)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        s32 net = -1, j;
+        u8 best_rssi = 0;
+        u32 i;
+        dev_dbg(adapter->dev, "info: num of entries in table = %d\n",
+               adapter->num_in_scan_table);
+        /*
+         * Loop through the table until the maximum is reached or until a match
+         *   is found based on the bssid field comparison
+         */
+        for (i = 0;
+             i < adapter->num_in_scan_table && (!bssid || (bssid && net < 0));
+             i++) {
+                if (!mwifiex_ssid_cmp(&adapter->scan_table[i].ssid, ssid) &&
+                    (!bssid
+                     || !memcmp(adapter->scan_table[i].mac_address, bssid,
+                                ETH_ALEN))
+                    &&
+                    (mwifiex_get_cfp_by_band_and_channel_from_cfg80211
+                     (priv, (u8) adapter->scan_table[i].bss_band,
+                      (u16) adapter->scan_table[i].channel))) {
+                        switch (mode) {
+                        case NL80211_IFTYPE_STATION:
+                        case NL80211_IFTYPE_ADHOC:
+                                j = mwifiex_is_network_compatible(priv, i,
+                                                                  mode);
+                                if (j >= 0) {
+                                        if (SCAN_RSSI
+                                            (adapter->scan_table[i].rssi) >
+                                            best_rssi) {
+                                                best_rssi = SCAN_RSSI(adapter->
+                                                                  scan_table
+                                                                  [i].rssi);
+                                                net = i;
+                                        }
+                                } else {
+                                        if (net == -1)
+                                                net = j;
+                                }
+                                break;
+                        case NL80211_IFTYPE_UNSPECIFIED:
+                        default:
+                                /*
+                                 * Do not check compatibility if the mode
+                                 * requested is Auto/Unknown.  Allows generic
+                                 * find to work without verifying against the
+                                 * Adapter security settings
+                                 */
+                                if (SCAN_RSSI(adapter->scan_table[i].rssi) >
+                                    best_rssi) {
+                                        best_rssi = SCAN_RSSI(adapter->
+                                                          scan_table[i].rssi);
+                                        net = i;
+                                }
+                                break;
+                        }
+                }
+        }
+        return net;
+}
+/*
+ * This function finds a specific compatible BSSID in the scan list.
+ *
+ * This function loops through the scan table looking for a compatible
+ * match. If a BSSID matches, but the BSS is found to be not compatible
+ * the function ignores it and continues to search through the rest of
+ * the entries in case there is an AP with multiple SSIDs assigned to
+ * the same BSSID.
+ */
+s32
+mwifiex_find_bssid_in_list(struct mwifiex_private *priv, u8 *bssid,
+                           u32 mode)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        s32 net = -1;
+        u32 i;
+        if (!bssid)
+                return -1;
+        dev_dbg(adapter->dev, "info: FindBSSID: Num of BSSIDs = %d\n",
+               adapter->num_in_scan_table);
+        /*
+         * Look through the scan table for a compatible match. The ret return
+         *   variable will be equal to the index in the scan table (greater
+         *   than zero) if the network is compatible.  The loop will continue
+         *   past a matched bssid that is not compatible in case there is an
+         *   AP with multiple SSIDs assigned to the same BSSID
+         */
+        for (i = 0; net < 0 && i < adapter->num_in_scan_table; i++) {
+                if (!memcmp
+                    (adapter->scan_table[i].mac_address, bssid, ETH_ALEN)
+                        && mwifiex_get_cfp_by_band_and_channel_from_cfg80211
+                                                                (priv,
+                                                            (u8) adapter->
+                                                            scan_table[i].
+                                                            bss_band,
+                                                            (u16) adapter->
+                                                            scan_table[i].
+                                                            channel)) {
+                        switch (mode) {
+                        case NL80211_IFTYPE_STATION:
+                        case NL80211_IFTYPE_ADHOC:
+                                net = mwifiex_is_network_compatible(priv, i,
+                                                                    mode);
+                                break;
+                        default:
+                                net = i;
+                                break;
+                        }
+                }
+        }
+        return net;
+}
+/*
+ * This function inserts scan command node to the scan pending queue.
+ */
+void
+mwifiex_queue_scan_cmd(struct mwifiex_private *priv,
+                       struct cmd_ctrl_node *cmd_node)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        unsigned long flags;
+        cmd_node->wait_q_enabled = true;
+        spin_lock_irqsave(&adapter->scan_pending_q_lock, flags);
+        list_add_tail(&cmd_node->list, &adapter->scan_pending_q);
+        spin_unlock_irqrestore(&adapter->scan_pending_q_lock, flags);
+}
+/*
+ * This function finds an AP with specific ssid in the scan list.
+ */
+int mwifiex_find_best_network(struct mwifiex_private *priv,
+                              struct mwifiex_ssid_bssid *req_ssid_bssid)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_bssdescriptor *req_bss;
+        s32 i;
+        memset(req_ssid_bssid, 0, sizeof(struct mwifiex_ssid_bssid));
+        i = mwifiex_find_best_network_in_list(priv);
+        if (i >= 0) {
+                req_bss = &adapter->scan_table[i];
+                memcpy(&req_ssid_bssid->ssid, &req_bss->ssid,
+                       sizeof(struct mwifiex_802_11_ssid));
+                memcpy((u8 *) &req_ssid_bssid->bssid,
+                       (u8 *) &req_bss->mac_address, ETH_ALEN);
+                /* Make sure we are in the right mode */
+                if (priv->bss_mode == NL80211_IFTYPE_UNSPECIFIED)
+                        priv->bss_mode = req_bss->bss_mode;
+        }
+        if (!req_ssid_bssid->ssid.ssid_len)
+                return -1;
+        dev_dbg(adapter->dev, "info: Best network found = [%s], "
+               "[%pM]\n", req_ssid_bssid->ssid.ssid,
+               req_ssid_bssid->bssid);
+        return 0;
+}
+/*
+ * This function sends a scan command for all available channels to the
+ * firmware, filtered on a specific SSID.
+ */
+static int mwifiex_scan_specific_ssid(struct mwifiex_private *priv,
+                                      struct mwifiex_802_11_ssid *req_ssid)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        int ret = 0;
+        struct mwifiex_user_scan_cfg *scan_cfg;
+        if (!req_ssid)
+                return -1;
+        if (adapter->scan_processing) {
+                dev_dbg(adapter->dev, "cmd: Scan already in process...\n");
+                return ret;
+        }
+        if (priv->scan_block) {
+                dev_dbg(adapter->dev,
+                        "cmd: Scan is blocked during association...\n");
+                return ret;
+        }
+        mwifiex_scan_delete_ssid_table_entry(priv, req_ssid);
+        scan_cfg = kzalloc(sizeof(struct mwifiex_user_scan_cfg), GFP_KERNEL);
+        if (!scan_cfg) {
+                dev_err(adapter->dev, "failed to alloc scan_cfg\n");
+                return -ENOMEM;
+        }
+        memcpy(scan_cfg->ssid_list[0].ssid, req_ssid->ssid,
+               req_ssid->ssid_len);
+        scan_cfg->keep_previous_scan = true;
+        ret = mwifiex_scan_networks(priv, scan_cfg);
+        kfree(scan_cfg);
+        return ret;
+}
+/*
+ * Sends IOCTL request to start a scan.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ *
+ * Scan command can be issued for both normal scan and specific SSID
+ * scan, depending upon whether an SSID is provided or not.
+ */
+int mwifiex_request_scan(struct mwifiex_private *priv,
+                         struct mwifiex_802_11_ssid *req_ssid)
+{
+        int ret;
+        if (down_interruptible(&priv->async_sem)) {
+                dev_err(priv->adapter->dev, "%s: acquire semaphore\n",
+                                                __func__);
+                return -1;
+        }
+        priv->scan_pending_on_block = true;
+        priv->adapter->cmd_wait_q.condition = false;
+        if (req_ssid && req_ssid->ssid_len != 0)
+                /* Specific SSID scan */
+                ret = mwifiex_scan_specific_ssid(priv, req_ssid);
+        else
+                /* Normal scan */
+                ret = mwifiex_scan_networks(priv, NULL);
+        if (!ret)
+                ret = mwifiex_wait_queue_complete(priv->adapter);
+        if (ret == -1) {
+                priv->scan_pending_on_block = false;
+                up(&priv->async_sem);
+        }
+        return ret;
+}
+/*
+ * This function appends the vendor specific IE TLV to a buffer.
+ */
+int
+mwifiex_cmd_append_vsie_tlv(struct mwifiex_private *priv,
+                            u16 vsie_mask, u8 **buffer)
+{
+        int id, ret_len = 0;
+        struct mwifiex_ie_types_vendor_param_set *vs_param_set;
+        if (!buffer)
+                return 0;
+        if (!(*buffer))
+                return 0;
+        /*
+         * Traverse through the saved vendor specific IE array and append
+         * the selected(scan/assoc/adhoc) IE as TLV to the command
+         */
+        for (id = 0; id < MWIFIEX_MAX_VSIE_NUM; id++) {
+                if (priv->vs_ie[id].mask & vsie_mask) {
+                        vs_param_set =
+                                (struct mwifiex_ie_types_vendor_param_set *)
+                                *buffer;
+                        vs_param_set->header.type =
+                                cpu_to_le16(TLV_TYPE_PASSTHROUGH);
+                        vs_param_set->header.len =
+                                cpu_to_le16((((u16) priv->vs_ie[id].ie[1])
+                                & 0x00FF) + 2);
+                        memcpy(vs_param_set->ie, priv->vs_ie[id].ie,
+                               le16_to_cpu(vs_param_set->header.len));
+                        *buffer += le16_to_cpu(vs_param_set->header.len) +
+                                   sizeof(struct mwifiex_ie_types_header);
+                        ret_len += le16_to_cpu(vs_param_set->header.len) +
+                                   sizeof(struct mwifiex_ie_types_header);
+                }
+        }
+        return ret_len;
+}
+/*
+ * This function saves a beacon buffer of the current BSS descriptor.
+ *
+ * The current beacon buffer is saved so that it can be restored in the
+ * following cases that makes the beacon buffer not to contain the current
+ * ssid's beacon buffer.
+ *      - The current ssid was not found somehow in the last scan.
+ *      - The current ssid was the last entry of the scan table and overloaded.
+ */
+void
+mwifiex_save_curr_bcn(struct mwifiex_private *priv)
+{
+        struct mwifiex_bssdescriptor *curr_bss =
+                &priv->curr_bss_params.bss_descriptor;
+        if (!curr_bss->beacon_buf_size)
+                return;
+        /* allocate beacon buffer at 1st time; or if it's size has changed */
+        if (!priv->curr_bcn_buf ||
+                        priv->curr_bcn_size != curr_bss->beacon_buf_size) {
+                priv->curr_bcn_size = curr_bss->beacon_buf_size;
+                kfree(priv->curr_bcn_buf);
+                priv->curr_bcn_buf = kzalloc(curr_bss->beacon_buf_size,
+                                                GFP_KERNEL);
+                if (!priv->curr_bcn_buf) {
+                        dev_err(priv->adapter->dev,
+                                        "failed to alloc curr_bcn_buf\n");
+                        return;
+                }
+        }
+        memcpy(priv->curr_bcn_buf, curr_bss->beacon_buf,
+                curr_bss->beacon_buf_size);
+        dev_dbg(priv->adapter->dev, "info: current beacon saved %d\n",
+                priv->curr_bcn_size);
+}
+/*
+ * This function frees the current BSS descriptor beacon buffer.
+ */
+void
+mwifiex_free_curr_bcn(struct mwifiex_private *priv)
+{
+        kfree(priv->curr_bcn_buf);
+        priv->curr_bcn_buf = NULL;
+}
diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c
new file mode 100644
index 000000000000..d425dbd91d19
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/sdio.c
@@ -0,0 +1,1754 @@
+/*
+ * Marvell Wireless LAN device driver: SDIO specific handling
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include <linux/firmware.h>
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+#include "sdio.h"
+#define SDIO_VERSION    "1.0"
+static struct mwifiex_if_ops sdio_ops;
+static struct semaphore add_remove_card_sem;
+/*
+ * SDIO probe.
+ *
+ * This function probes an mwifiex device and registers it. It allocates
+ * the card structure, enables SDIO function number and initiates the
+ * device registration and initialization procedure by adding a logical
+ * interface.
+ */
+static int
+mwifiex_sdio_probe(struct sdio_func *func, const struct sdio_device_id *id)
+{
+        int ret;
+        struct sdio_mmc_card *card = NULL;
+        pr_debug("info: vendor=0x%4.04X device=0x%4.04X class=%d function=%d\n",
+               func->vendor, func->device, func->class, func->num);
+        card = kzalloc(sizeof(struct sdio_mmc_card), GFP_KERNEL);
+        if (!card) {
+                pr_err("%s: failed to alloc memory\n", __func__);
+                return -ENOMEM;
+        }
+        card->func = func;
+        func->card->quirks |= MMC_QUIRK_BLKSZ_FOR_BYTE_MODE;
+        sdio_claim_host(func);
+        ret = sdio_enable_func(func);
+        sdio_release_host(func);
+        if (ret) {
+                pr_err("%s: failed to enable function\n", __func__);
+                kfree(card);
+                return -EIO;
+        }
+        if (mwifiex_add_card(card, &add_remove_card_sem, &sdio_ops)) {
+                pr_err("%s: add card failed\n", __func__);
+                kfree(card);
+                sdio_claim_host(func);
+                ret = sdio_disable_func(func);
+                sdio_release_host(func);
+                ret = -1;
+        }
+        return ret;
+}
+/*
+ * SDIO remove.
+ *
+ * This function removes the interface and frees up the card structure.
+ */
+static void
+mwifiex_sdio_remove(struct sdio_func *func)
+{
+        struct sdio_mmc_card *card;
+        pr_debug("info: SDIO func num=%d\n", func->num);
+        if (func) {
+                card = sdio_get_drvdata(func);
+                if (card) {
+                        mwifiex_remove_card(card->adapter,
+                                        &add_remove_card_sem);
+                        kfree(card);
+                }
+        }
+}
+/*
+ * SDIO suspend.
+ *
+ * Kernel needs to suspend all functions separately. Therefore all
+ * registered functions must have drivers with suspend and resume
+ * methods. Failing that the kernel simply removes the whole card.
+ *
+ * If already not suspended, this function allocates and sends a host
+ * sleep activate request to the firmware and turns off the traffic.
+ */
+static int mwifiex_sdio_suspend(struct device *dev)
+{
+        struct sdio_func *func = dev_to_sdio_func(dev);
+        struct sdio_mmc_card *card;
+        struct mwifiex_adapter *adapter;
+        mmc_pm_flag_t pm_flag = 0;
+        int hs_actived = 0;
+        int i;
+        int ret = 0;
+        if (func) {
+                pm_flag = sdio_get_host_pm_caps(func);
+                pr_debug("cmd: %s: suspend: PM flag = 0x%x\n",
+                       sdio_func_id(func), pm_flag);
+                if (!(pm_flag & MMC_PM_KEEP_POWER)) {
+                        pr_err("%s: cannot remain alive while host is"
+                                " suspended\n", sdio_func_id(func));
+                        return -ENOSYS;
+                }
+                card = sdio_get_drvdata(func);
+                if (!card || !card->adapter) {
+                        pr_err("suspend: invalid card or adapter\n");
+                        return 0;
+                }
+        } else {
+                pr_err("suspend: sdio_func is not specified\n");
+                return 0;
+        }
+        adapter = card->adapter;
+        /* Enable the Host Sleep */
+        hs_actived = mwifiex_enable_hs(adapter);
+        if (hs_actived) {
+                pr_debug("cmd: suspend with MMC_PM_KEEP_POWER\n");
+                ret = sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER);
+        }
+        /* Indicate device suspended */
+        adapter->is_suspended = true;
+        for (i = 0; i < adapter->priv_num; i++)
+                netif_carrier_off(adapter->priv[i]->netdev);
+        return ret;
+}
+/*
+ * SDIO resume.
+ *
+ * Kernel needs to suspend all functions separately. Therefore all
+ * registered functions must have drivers with suspend and resume
+ * methods. Failing that the kernel simply removes the whole card.
+ *
+ * If already not resumed, this function turns on the traffic and
+ * sends a host sleep cancel request to the firmware.
+ */
+static int mwifiex_sdio_resume(struct device *dev)
+{
+        struct sdio_func *func = dev_to_sdio_func(dev);
+        struct sdio_mmc_card *card;
+        struct mwifiex_adapter *adapter;
+        mmc_pm_flag_t pm_flag = 0;
+        int i;
+        if (func) {
+                pm_flag = sdio_get_host_pm_caps(func);
+                card = sdio_get_drvdata(func);
+                if (!card || !card->adapter) {
+                        pr_err("resume: invalid card or adapter\n");
+                        return 0;
+                }
+        } else {
+                pr_err("resume: sdio_func is not specified\n");
+                return 0;
+        }
+        adapter = card->adapter;
+        if (!adapter->is_suspended) {
+                dev_warn(adapter->dev, "device already resumed\n");
+                return 0;
+        }
+        adapter->is_suspended = false;
+        for (i = 0; i < adapter->priv_num; i++)
+                if (adapter->priv[i]->media_connected)
+                        netif_carrier_on(adapter->priv[i]->netdev);
+        /* Disable Host Sleep */
+        mwifiex_cancel_hs(mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_STA),
+                          MWIFIEX_ASYNC_CMD);
+        return 0;
+}
+/* Device ID for SD8787 */
+#define SDIO_DEVICE_ID_MARVELL_8787   (0x9119)
+/* WLAN IDs */
+static const struct sdio_device_id mwifiex_ids[] = {
+        {SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, SDIO_DEVICE_ID_MARVELL_8787)},
+        {},
+};
+MODULE_DEVICE_TABLE(sdio, mwifiex_ids);
+static const struct dev_pm_ops mwifiex_sdio_pm_ops = {
+        .suspend = mwifiex_sdio_suspend,
+        .resume = mwifiex_sdio_resume,
+};
+static struct sdio_driver mwifiex_sdio = {
+        .name = "mwifiex_sdio",
+        .id_table = mwifiex_ids,
+        .probe = mwifiex_sdio_probe,
+        .remove = mwifiex_sdio_remove,
+        .drv = {
+                .owner = THIS_MODULE,
+                .pm = &mwifiex_sdio_pm_ops,
+        }
+};
+/*
+ * This function writes data into SDIO card register.
+ */
+static int
+mwifiex_write_reg(struct mwifiex_adapter *adapter, u32 reg, u32 data)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        int ret = -1;
+        sdio_claim_host(card->func);
+        sdio_writeb(card->func, (u8) data, reg, &ret);
+        sdio_release_host(card->func);
+        return ret;
+}
+/*
+ * This function reads data from SDIO card register.
+ */
+static int
+mwifiex_read_reg(struct mwifiex_adapter *adapter, u32 reg, u32 *data)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        int ret = -1;
+        u8 val;
+        sdio_claim_host(card->func);
+        val = sdio_readb(card->func, reg, &ret);
+        sdio_release_host(card->func);
+        *data = val;
+        return ret;
+}
+/*
+ * This function writes multiple data into SDIO card memory.
+ *
+ * This does not work in suspended mode.
+ */
+static int
+mwifiex_write_data_sync(struct mwifiex_adapter *adapter,
+                        u8 *buffer, u32 pkt_len, u32 port)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        int ret = -1;
+        u8 blk_mode =
+                (port & MWIFIEX_SDIO_BYTE_MODE_MASK) ? BYTE_MODE : BLOCK_MODE;
+        u32 blk_size = (blk_mode == BLOCK_MODE) ? MWIFIEX_SDIO_BLOCK_SIZE : 1;
+        u32 blk_cnt =
+                (blk_mode ==
+                 BLOCK_MODE) ? (pkt_len /
+                                MWIFIEX_SDIO_BLOCK_SIZE) : pkt_len;
+        u32 ioport = (port & MWIFIEX_SDIO_IO_PORT_MASK);
+        if (adapter->is_suspended) {
+                dev_err(adapter->dev,
+                        "%s: not allowed while suspended\n", __func__);
+                return -1;
+        }
+        sdio_claim_host(card->func);
+        if (!sdio_writesb(card->func, ioport, buffer, blk_cnt * blk_size))
+                ret = 0;
+        sdio_release_host(card->func);
+        return ret;
+}
+/*
+ * This function reads multiple data from SDIO card memory.
+ */
+static int mwifiex_read_data_sync(struct mwifiex_adapter *adapter, u8 *buffer,
+                                  u32 len, u32 port, u8 claim)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        int ret = -1;
+        u8 blk_mode =
+                (port & MWIFIEX_SDIO_BYTE_MODE_MASK) ? BYTE_MODE : BLOCK_MODE;
+        u32 blk_size = (blk_mode == BLOCK_MODE) ? MWIFIEX_SDIO_BLOCK_SIZE : 1;
+        u32 blk_cnt =
+                (blk_mode ==
+                 BLOCK_MODE) ? (len / MWIFIEX_SDIO_BLOCK_SIZE) : len;
+        u32 ioport = (port & MWIFIEX_SDIO_IO_PORT_MASK);
+        if (claim)
+                sdio_claim_host(card->func);
+        if (!sdio_readsb(card->func, buffer, ioport, blk_cnt * blk_size))
+                ret = 0;
+        if (claim)
+                sdio_release_host(card->func);
+        return ret;
+}
+/*
+ * This function wakes up the card.
+ *
+ * A host power up command is written to the card configuration
+ * register to wake up the card.
+ */
+static int mwifiex_pm_wakeup_card(struct mwifiex_adapter *adapter)
+{
+        dev_dbg(adapter->dev, "event: wakeup device...\n");
+        return mwifiex_write_reg(adapter, CONFIGURATION_REG, HOST_POWER_UP);
+}
+/*
+ * This function is called after the card has woken up.
+ *
+ * The card configuration register is reset.
+ */
+static int mwifiex_pm_wakeup_card_complete(struct mwifiex_adapter *adapter)
+{
+        dev_dbg(adapter->dev, "cmd: wakeup device completed\n");
+        return mwifiex_write_reg(adapter, CONFIGURATION_REG, 0);
+}
+/*
+ * This function initializes the IO ports.
+ *
+ * The following operations are performed -
+ *      - Read the IO ports (0, 1 and 2)
+ *      - Set host interrupt Reset-To-Read to clear
+ *      - Set auto re-enable interrupt
+ */
+static int mwifiex_init_sdio_ioport(struct mwifiex_adapter *adapter)
+{
+        u32 reg;
+        adapter->ioport = 0;
+        /* Read the IO port */
+        if (!mwifiex_read_reg(adapter, IO_PORT_0_REG, &reg))
+                adapter->ioport |= (reg & 0xff);
+        else
+                return -1;
+        if (!mwifiex_read_reg(adapter, IO_PORT_1_REG, &reg))
+                adapter->ioport |= ((reg & 0xff) << 8);
+        else
+                return -1;
+        if (!mwifiex_read_reg(adapter, IO_PORT_2_REG, &reg))
+                adapter->ioport |= ((reg & 0xff) << 16);
+        else
+                return -1;
+        pr_debug("info: SDIO FUNC1 IO port: %#x\n", adapter->ioport);
+        /* Set Host interrupt reset to read to clear */
+        if (!mwifiex_read_reg(adapter, HOST_INT_RSR_REG, &reg))
+                mwifiex_write_reg(adapter, HOST_INT_RSR_REG,
+                                  reg | SDIO_INT_MASK);
+        else
+                return -1;
+        /* Dnld/Upld ready set to auto reset */
+        if (!mwifiex_read_reg(adapter, CARD_MISC_CFG_REG, &reg))
+                mwifiex_write_reg(adapter, CARD_MISC_CFG_REG,
+                                  reg | AUTO_RE_ENABLE_INT);
+        else
+                return -1;
+        return 0;
+}
+/*
+ * This function sends data to the card.
+ */
+static int mwifiex_write_data_to_card(struct mwifiex_adapter *adapter,
+                                      u8 *payload, u32 pkt_len, u32 port)
+{
+        u32 i = 0;
+        int ret;
+        do {
+                ret = mwifiex_write_data_sync(adapter, payload, pkt_len, port);
+                if (ret) {
+                        i++;
+                        dev_err(adapter->dev, "host_to_card, write iomem"
+                                        " (%d) failed: %d\n", i, ret);
+                        if (mwifiex_write_reg(adapter,
+                                        CONFIGURATION_REG, 0x04))
+                                dev_err(adapter->dev, "write CFG reg failed\n");
+                        ret = -1;
+                        if (i > MAX_WRITE_IOMEM_RETRY)
+                                return ret;
+                }
+        } while (ret == -1);
+        return ret;
+}
+/*
+ * This function gets the read port.
+ *
+ * If control port bit is set in MP read bitmap, the control port
+ * is returned, otherwise the current read port is returned and
+ * the value is increased (provided it does not reach the maximum
+ * limit, in which case it is reset to 1)
+ */
+static int mwifiex_get_rd_port(struct mwifiex_adapter *adapter, u8 *port)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        u16 rd_bitmap = card->mp_rd_bitmap;
+        dev_dbg(adapter->dev, "data: mp_rd_bitmap=0x%04x\n", rd_bitmap);
+        if (!(rd_bitmap & (CTRL_PORT_MASK | DATA_PORT_MASK)))
+                return -1;
+        if (card->mp_rd_bitmap & CTRL_PORT_MASK) {
+                card->mp_rd_bitmap &= (u16) (~CTRL_PORT_MASK);
+                *port = CTRL_PORT;
+                dev_dbg(adapter->dev, "data: port=%d mp_rd_bitmap=0x%04x\n",
+                       *port, card->mp_rd_bitmap);
+        } else {
+                if (card->mp_rd_bitmap & (1 << card->curr_rd_port)) {
+                        card->mp_rd_bitmap &=
+                                (u16) (~(1 << card->curr_rd_port));
+                        *port = card->curr_rd_port;
+                        if (++card->curr_rd_port == MAX_PORT)
+                                card->curr_rd_port = 1;
+                } else {
+                        return -1;
+                }
+                dev_dbg(adapter->dev,
+                        "data: port=%d mp_rd_bitmap=0x%04x -> 0x%04x\n",
+                       *port, rd_bitmap, card->mp_rd_bitmap);
+        }
+        return 0;
+}
+/*
+ * This function gets the write port for data.
+ *
+ * The current write port is returned if available and the value is
+ * increased (provided it does not reach the maximum limit, in which
+ * case it is reset to 1)
+ */
+static int mwifiex_get_wr_port_data(struct mwifiex_adapter *adapter, u8 *port)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        u16 wr_bitmap = card->mp_wr_bitmap;
+        dev_dbg(adapter->dev, "data: mp_wr_bitmap=0x%04x\n", wr_bitmap);
+        if (!(wr_bitmap & card->mp_data_port_mask))
+                return -1;
+        if (card->mp_wr_bitmap & (1 << card->curr_wr_port)) {
+                card->mp_wr_bitmap &= (u16) (~(1 << card->curr_wr_port));
+                *port = card->curr_wr_port;
+                if (++card->curr_wr_port == card->mp_end_port)
+                        card->curr_wr_port = 1;
+        } else {
+                adapter->data_sent = true;
+                return -EBUSY;
+        }
+        if (*port == CTRL_PORT) {
+                dev_err(adapter->dev, "invalid data port=%d cur port=%d"
+                                " mp_wr_bitmap=0x%04x -> 0x%04x\n",
+                                *port, card->curr_wr_port, wr_bitmap,
+                                card->mp_wr_bitmap);
+                return -1;
+        }
+        dev_dbg(adapter->dev, "data: port=%d mp_wr_bitmap=0x%04x -> 0x%04x\n",
+               *port, wr_bitmap, card->mp_wr_bitmap);
+        return 0;
+}
+/*
+ * This function polls the card status.
+ */
+static int
+mwifiex_sdio_poll_card_status(struct mwifiex_adapter *adapter, u8 bits)
+{
+        u32 tries;
+        u32 cs;
+        for (tries = 0; tries < MAX_POLL_TRIES; tries++) {
+                if (mwifiex_read_reg(adapter, CARD_STATUS_REG, &cs))
+                        break;
+                else if ((cs & bits) == bits)
+                        return 0;
+                udelay(10);
+        }
+        dev_err(adapter->dev, "poll card status failed, tries = %d\n",
+               tries);
+        return -1;
+}
+/*
+ * This function reads the firmware status.
+ */
+static int
+mwifiex_sdio_read_fw_status(struct mwifiex_adapter *adapter, u16 *dat)
+{
+        u32 fws0, fws1;
+        if (mwifiex_read_reg(adapter, CARD_FW_STATUS0_REG, &fws0))
+                return -1;
+        if (mwifiex_read_reg(adapter, CARD_FW_STATUS1_REG, &fws1))
+                return -1;
+        *dat = (u16) ((fws1 << 8) | fws0);
+        return 0;
+}
+/*
+ * This function disables the host interrupt.
+ *
+ * The host interrupt mask is read, the disable bit is reset and
+ * written back to the card host interrupt mask register.
+ */
+static int mwifiex_sdio_disable_host_int(struct mwifiex_adapter *adapter)
+{
+        u32 host_int_mask;
+        /* Read back the host_int_mask register */
+        if (mwifiex_read_reg(adapter, HOST_INT_MASK_REG, &host_int_mask))
+                return -1;
+        /* Update with the mask and write back to the register */
+        host_int_mask &= ~HOST_INT_DISABLE;
+        if (mwifiex_write_reg(adapter, HOST_INT_MASK_REG, host_int_mask)) {
+                dev_err(adapter->dev, "disable host interrupt failed\n");
+                return -1;
+        }
+        return 0;
+}
+/*
+ * This function enables the host interrupt.
+ *
+ * The host interrupt enable mask is written to the card
+ * host interrupt mask register.
+ */
+static int mwifiex_sdio_enable_host_int(struct mwifiex_adapter *adapter)
+{
+        /* Simply write the mask to the register */
+        if (mwifiex_write_reg(adapter, HOST_INT_MASK_REG, HOST_INT_ENABLE)) {
+                dev_err(adapter->dev, "enable host interrupt failed\n");
+                return -1;
+        }
+        return 0;
+}
+/*
+ * This function sends a data buffer to the card.
+ */
+static int mwifiex_sdio_card_to_host(struct mwifiex_adapter *adapter,
+                                     u32 *type, u8 *buffer,
+                                     u32 npayload, u32 ioport)
+{
+        int ret;
+        u32 nb;
+        if (!buffer) {
+                dev_err(adapter->dev, "%s: buffer is NULL\n", __func__);
+                return -1;
+        }
+        ret = mwifiex_read_data_sync(adapter, buffer, npayload, ioport, 1);
+        if (ret) {
+                dev_err(adapter->dev, "%s: read iomem failed: %d\n", __func__,
+                                ret);
+                return -1;
+        }
+        nb = le16_to_cpu(*(__le16 *) (buffer));
+        if (nb > npayload) {
+                dev_err(adapter->dev, "%s: invalid packet, nb=%d, npayload=%d\n",
+                                __func__, nb, npayload);
+                return -1;
+        }
+        *type = le16_to_cpu(*(__le16 *) (buffer + 2));
+        return ret;
+}
+/*
+ * This function downloads the firmware to the card.
+ *
+ * Firmware is downloaded to the card in blocks. Every block download
+ * is tested for CRC errors, and retried a number of times before
+ * returning failure.
+ */
+static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
+                                    struct mwifiex_fw_image *fw)
+{
+        int ret;
+        u8 *firmware = fw->fw_buf;
+        u32 firmware_len = fw->fw_len;
+        u32 offset = 0;
+        u32 base0, base1;
+        u8 *fwbuf;
+        u16 len = 0;
+        u32 txlen, tx_blocks = 0, tries;
+        u32 i = 0;
+        if (!firmware_len) {
+                dev_err(adapter->dev, "firmware image not found!"
+                                " Terminating download\n");
+                return -1;
+        }
+        dev_dbg(adapter->dev, "info: downloading FW image (%d bytes)\n",
+                        firmware_len);
+        /* Assume that the allocated buffer is 8-byte aligned */
+        fwbuf = kzalloc(MWIFIEX_UPLD_SIZE, GFP_KERNEL);
+        if (!fwbuf) {
+                dev_err(adapter->dev, "unable to alloc buffer for firmware."
+                                " Terminating download\n");
+                return -ENOMEM;
+        }
+        /* Perform firmware data transfer */
+        do {
+                /* The host polls for the DN_LD_CARD_RDY and CARD_IO_READY
+                   bits */
+                ret = mwifiex_sdio_poll_card_status(adapter, CARD_IO_READY |
+                                                    DN_LD_CARD_RDY);
+                if (ret) {
+                        dev_err(adapter->dev, "FW download with helper:"
+                                        " poll status timeout @ %d\n", offset);
+                        goto done;
+                }
+                /* More data? */
+                if (offset >= firmware_len)
+                        break;
+                for (tries = 0; tries < MAX_POLL_TRIES; tries++) {
+                        ret = mwifiex_read_reg(adapter, HOST_F1_RD_BASE_0,
+                                               &base0);
+                        if (ret) {
+                                dev_err(adapter->dev, "dev BASE0 register read"
+                                        " failed: base0=0x%04X(%d). Terminating "
+                                       "download\n", base0, base0);
+                                goto done;
+                        }
+                        ret = mwifiex_read_reg(adapter, HOST_F1_RD_BASE_1,
+                                               &base1);
+                        if (ret) {
+                                dev_err(adapter->dev, "dev BASE1 register read"
+                                        " failed: base1=0x%04X(%d). Terminating "
+                                       "download\n", base1, base1);
+                                goto done;
+                        }
+                        len = (u16) (((base1 & 0xff) << 8) | (base0 & 0xff));
+                        if (len)
+                                break;
+                        udelay(10);
+                }
+                if (!len) {
+                        break;
+                } else if (len > MWIFIEX_UPLD_SIZE) {
+                        dev_err(adapter->dev, "FW download failed @ %d,"
+                                " invalid length %d\n", offset, len);
+                        ret = -1;
+                        goto done;
+                }
+                txlen = len;
+                if (len & BIT(0)) {
+                        i++;
+                        if (i > MAX_WRITE_IOMEM_RETRY) {
+                                dev_err(adapter->dev, "FW download failed @"
+                                        " %d, over max retry count\n", offset);
+                                ret = -1;
+                                goto done;
+                        }
+                        dev_err(adapter->dev, "CRC indicated by the helper:"
+                               " len = 0x%04X, txlen = %d\n", len, txlen);
+                        len &= ~BIT(0);
+                        /* Setting this to 0 to resend from same offset */
+                        txlen = 0;
+                } else {
+                        i = 0;
+                        /* Set blocksize to transfer - checking for last
+                           block */
+                        if (firmware_len - offset < txlen)
+                                txlen = firmware_len - offset;
+                        tx_blocks = (txlen + MWIFIEX_SDIO_BLOCK_SIZE -
+                                        1) / MWIFIEX_SDIO_BLOCK_SIZE;
+                        /* Copy payload to buffer */
+                        memmove(fwbuf, &firmware[offset], txlen);
+                }
+                ret = mwifiex_write_data_sync(adapter, fwbuf, tx_blocks *
+                                              MWIFIEX_SDIO_BLOCK_SIZE,
+                                              adapter->ioport);
+                if (ret) {
+                        dev_err(adapter->dev, "FW download, write iomem (%d)"
+                                        " failed @ %d\n", i, offset);
+                        if (mwifiex_write_reg(adapter, CONFIGURATION_REG, 0x04))
+                                dev_err(adapter->dev, "write CFG reg failed\n");
+                        ret = -1;
+                        goto done;
+                }
+                offset += txlen;
+        } while (true);
+        dev_dbg(adapter->dev, "info: FW download over, size %d bytes\n",
+                                                offset);
+        ret = 0;
+done:
+        kfree(fwbuf);
+        return ret;
+}
+/*
+ * This function checks the firmware status in card.
+ *
+ * The winner interface is also determined by this function.
+ */
+static int mwifiex_check_fw_status(struct mwifiex_adapter *adapter,
+                                   u32 poll_num, int *winner)
+{
+        int ret = 0;
+        u16 firmware_stat;
+        u32 tries;
+        u32 winner_status;
+        /* Wait for firmware initialization event */
+        for (tries = 0; tries < poll_num; tries++) {
+                ret = mwifiex_sdio_read_fw_status(adapter, &firmware_stat);
+                if (ret)
+                        continue;
+                if (firmware_stat == FIRMWARE_READY) {
+                        ret = 0;
+                        break;
+                } else {
+                        mdelay(100);
+                        ret = -1;
+                }
+        }
+        if (winner && ret) {
+                if (mwifiex_read_reg
+                    (adapter, CARD_FW_STATUS0_REG, &winner_status))
+                        winner_status = 0;
+                if (winner_status)
+                        *winner = 0;
+                else
+                        *winner = 1;
+        }
+        return ret;
+}
+/*
+ * This function reads the interrupt status from card.
+ */
+static void mwifiex_interrupt_status(struct mwifiex_adapter *adapter)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        u32 sdio_ireg;
+        unsigned long flags;
+        if (mwifiex_read_data_sync(adapter, card->mp_regs, MAX_MP_REGS,
+                                   REG_PORT | MWIFIEX_SDIO_BYTE_MODE_MASK,
+                                   0)) {
+                dev_err(adapter->dev, "read mp_regs failed\n");
+                return;
+        }
+        sdio_ireg = card->mp_regs[HOST_INTSTATUS_REG];
+        if (sdio_ireg) {
+                /*
+                 * DN_LD_HOST_INT_STATUS and/or UP_LD_HOST_INT_STATUS
+                 * Clear the interrupt status register
+                 */
+                dev_dbg(adapter->dev, "int: sdio_ireg = %#x\n", sdio_ireg);
+                spin_lock_irqsave(&adapter->int_lock, flags);
+                adapter->int_status |= sdio_ireg;
+                spin_unlock_irqrestore(&adapter->int_lock, flags);
+        }
+}
+/*
+ * SDIO interrupt handler.
+ *
+ * This function reads the interrupt status from firmware and assigns
+ * the main process in workqueue which will handle the interrupt.
+ */
+static void
+mwifiex_sdio_interrupt(struct sdio_func *func)
+{
+        struct mwifiex_adapter *adapter;
+        struct sdio_mmc_card *card;
+        card = sdio_get_drvdata(func);
+        if (!card || !card->adapter) {
+                pr_debug("int: func=%p card=%p adapter=%p\n",
+                       func, card, card ? card->adapter : NULL);
+                return;
+        }
+        adapter = card->adapter;
+        if (adapter->surprise_removed)
+                return;
+        if (!adapter->pps_uapsd_mode && adapter->ps_state == PS_STATE_SLEEP)
+                adapter->ps_state = PS_STATE_AWAKE;
+        mwifiex_interrupt_status(adapter);
+        queue_work(adapter->workqueue, &adapter->main_work);
+}
+/*
+ * This function decodes a received packet.
+ *
+ * Based on the type, the packet is treated as either a data, or
+ * a command response, or an event, and the correct handler
+ * function is invoked.
+ */
+static int mwifiex_decode_rx_packet(struct mwifiex_adapter *adapter,
+                                    struct sk_buff *skb, u32 upld_typ)
+{
+        u8 *cmd_buf;
+        skb_pull(skb, INTF_HEADER_LEN);
+        switch (upld_typ) {
+        case MWIFIEX_TYPE_DATA:
+                dev_dbg(adapter->dev, "info: --- Rx: Data packet ---\n");
+                mwifiex_handle_rx_packet(adapter, skb);
+                break;
+        case MWIFIEX_TYPE_CMD:
+                dev_dbg(adapter->dev, "info: --- Rx: Cmd Response ---\n");
+                /* take care of curr_cmd = NULL case */
+                if (!adapter->curr_cmd) {
+                        cmd_buf = adapter->upld_buf;
+                        if (adapter->ps_state == PS_STATE_SLEEP_CFM)
+                                mwifiex_process_sleep_confirm_resp(adapter,
+                                                        skb->data, skb->len);
+                        memcpy(cmd_buf, skb->data, min_t(u32,
+                                       MWIFIEX_SIZE_OF_CMD_BUFFER, skb->len));
+                        dev_kfree_skb_any(skb);
+                } else {
+                        adapter->cmd_resp_received = true;
+                        adapter->curr_cmd->resp_skb = skb;
+                }
+                break;
+        case MWIFIEX_TYPE_EVENT:
+                dev_dbg(adapter->dev, "info: --- Rx: Event ---\n");
+                adapter->event_cause = *(u32 *) skb->data;
+                skb_pull(skb, MWIFIEX_EVENT_HEADER_LEN);
+                if ((skb->len > 0) && (skb->len  < MAX_EVENT_SIZE))
+                        memcpy(adapter->event_body, skb->data, skb->len);
+                /* event cause has been saved to adapter->event_cause */
+                adapter->event_received = true;
+                adapter->event_skb = skb;
+                break;
+        default:
+                dev_err(adapter->dev, "unknown upload type %#x\n", upld_typ);
+                dev_kfree_skb_any(skb);
+                break;
+        }
+        return 0;
+}
+/*
+ * This function transfers received packets from card to driver, performing
+ * aggregation if required.
+ *
+ * For data received on control port, or if aggregation is disabled, the
+ * received buffers are uploaded as separate packets. However, if aggregation
+ * is enabled and required, the buffers are copied onto an aggregation buffer,
+ * provided there is space left, processed and finally uploaded.
+ */
+static int mwifiex_sdio_card_to_host_mp_aggr(struct mwifiex_adapter *adapter,
+                                             struct sk_buff *skb, u8 port)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        s32 f_do_rx_aggr = 0;
+        s32 f_do_rx_cur = 0;
+        s32 f_aggr_cur = 0;
+        struct sk_buff *skb_deaggr;
+        u32 pind;
+        u32 pkt_len, pkt_type = 0;
+        u8 *curr_ptr;
+        u32 rx_len = skb->len;
+        if (port == CTRL_PORT) {
+                /* Read the command Resp without aggr */
+                dev_dbg(adapter->dev, "info: %s: no aggregation for cmd "
+                                "response\n", __func__);
+                f_do_rx_cur = 1;
+                goto rx_curr_single;
+        }
+        if (!card->mpa_rx.enabled) {
+                dev_dbg(adapter->dev, "info: %s: rx aggregation disabled\n",
+                                                __func__);
+                f_do_rx_cur = 1;
+                goto rx_curr_single;
+        }
+        if (card->mp_rd_bitmap & (~((u16) CTRL_PORT_MASK))) {
+                /* Some more data RX pending */
+                dev_dbg(adapter->dev, "info: %s: not last packet\n", __func__);
+                if (MP_RX_AGGR_IN_PROGRESS(card)) {
+                        if (MP_RX_AGGR_BUF_HAS_ROOM(card, skb->len)) {
+                                f_aggr_cur = 1;
+                        } else {
+                                /* No room in Aggr buf, do rx aggr now */
+                                f_do_rx_aggr = 1;
+                                f_do_rx_cur = 1;
+                        }
+                } else {
+                        /* Rx aggr not in progress */
+                        f_aggr_cur = 1;
+                }
+        } else {
+                /* No more data RX pending */
+                dev_dbg(adapter->dev, "info: %s: last packet\n", __func__);
+                if (MP_RX_AGGR_IN_PROGRESS(card)) {
+                        f_do_rx_aggr = 1;
+                        if (MP_RX_AGGR_BUF_HAS_ROOM(card, skb->len))
+                                f_aggr_cur = 1;
+                        else
+                                /* No room in Aggr buf, do rx aggr now */
+                                f_do_rx_cur = 1;
+                } else {
+                        f_do_rx_cur = 1;
+                }
+        }
+        if (f_aggr_cur) {
+                dev_dbg(adapter->dev, "info: current packet aggregation\n");
+                /* Curr pkt can be aggregated */
+                MP_RX_AGGR_SETUP(card, skb, port);
+                if (MP_RX_AGGR_PKT_LIMIT_REACHED(card) ||
+                    MP_RX_AGGR_PORT_LIMIT_REACHED(card)) {
+                        dev_dbg(adapter->dev, "info: %s: aggregated packet "
+                                        "limit reached\n", __func__);
+                        /* No more pkts allowed in Aggr buf, rx it */
+                        f_do_rx_aggr = 1;
+                }
+        }
+        if (f_do_rx_aggr) {
+                /* do aggr RX now */
+                dev_dbg(adapter->dev, "info: do_rx_aggr: num of packets: %d\n",
+                       card->mpa_rx.pkt_cnt);
+                if (mwifiex_read_data_sync(adapter, card->mpa_rx.buf,
+                                           card->mpa_rx.buf_len,
+                                           (adapter->ioport | 0x1000 |
+                                            (card->mpa_rx.ports << 4)) +
+                                           card->mpa_rx.start_port, 1))
+                        return -1;
+                curr_ptr = card->mpa_rx.buf;
+                for (pind = 0; pind < card->mpa_rx.pkt_cnt; pind++) {
+                        /* get curr PKT len & type */
+                        pkt_len = *(u16 *) &curr_ptr[0];
+                        pkt_type = *(u16 *) &curr_ptr[2];
+                        /* copy pkt to deaggr buf */
+                        skb_deaggr = card->mpa_rx.skb_arr[pind];
+                        if ((pkt_type == MWIFIEX_TYPE_DATA) && (pkt_len <=
+                                         card->mpa_rx.len_arr[pind])) {
+                                memcpy(skb_deaggr->data, curr_ptr, pkt_len);
+                                skb_trim(skb_deaggr, pkt_len);
+                                /* Process de-aggr packet */
+                                mwifiex_decode_rx_packet(adapter, skb_deaggr,
+                                                         pkt_type);
+                        } else {
+                                dev_err(adapter->dev, "wrong aggr pkt:"
+                                        " type=%d len=%d max_len=%d\n",
+                                        pkt_type, pkt_len,
+                                        card->mpa_rx.len_arr[pind]);
+                                dev_kfree_skb_any(skb_deaggr);
+                        }
+                        curr_ptr += card->mpa_rx.len_arr[pind];
+                }
+                MP_RX_AGGR_BUF_RESET(card);
+        }
+rx_curr_single:
+        if (f_do_rx_cur) {
+                dev_dbg(adapter->dev, "info: RX: port: %d, rx_len: %d\n",
+                        port, rx_len);
+                if (mwifiex_sdio_card_to_host(adapter, &pkt_type,
+                                              skb->data, skb->len,
+                                              adapter->ioport + port))
+                        return -1;
+                mwifiex_decode_rx_packet(adapter, skb, pkt_type);
+        }
+        return 0;
+}
+/*
+ * This function checks the current interrupt status.
+ *
+ * The following interrupts are checked and handled by this function -
+ *      - Data sent
+ *      - Command sent
+ *      - Packets received
+ *
+ * Since the firmware does not generate download ready interrupt if the
+ * port updated is command port only, command sent interrupt checking
+ * should be done manually, and for every SDIO interrupt.
+ *
+ * In case of Rx packets received, the packets are uploaded from card to
+ * host and processed accordingly.
+ */
+static int mwifiex_process_int_status(struct mwifiex_adapter *adapter)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        int ret = 0;
+        u8 sdio_ireg;
+        struct sk_buff *skb;
+        u8 port = CTRL_PORT;
+        u32 len_reg_l, len_reg_u;
+        u32 rx_blocks;
+        u16 rx_len;
+        unsigned long flags;
+        spin_lock_irqsave(&adapter->int_lock, flags);
+        sdio_ireg = adapter->int_status;
+        adapter->int_status = 0;
+        spin_unlock_irqrestore(&adapter->int_lock, flags);
+        if (!sdio_ireg)
+                return ret;
+        if (sdio_ireg & DN_LD_HOST_INT_STATUS) {
+                card->mp_wr_bitmap = ((u16) card->mp_regs[WR_BITMAP_U]) << 8;
+                card->mp_wr_bitmap |= (u16) card->mp_regs[WR_BITMAP_L];
+                dev_dbg(adapter->dev, "int: DNLD: wr_bitmap=0x%04x\n",
+                                card->mp_wr_bitmap);
+                if (adapter->data_sent &&
+                    (card->mp_wr_bitmap & card->mp_data_port_mask)) {
+                        dev_dbg(adapter->dev,
+                                "info:  <--- Tx DONE Interrupt --->\n");
+                        adapter->data_sent = false;
+                }
+        }
+        /* As firmware will not generate download ready interrupt if the port
+           updated is command port only, cmd_sent should be done for any SDIO
+           interrupt. */
+        if (adapter->cmd_sent) {
+                /* Check if firmware has attach buffer at command port and
+                   update just that in wr_bit_map. */
+                card->mp_wr_bitmap |=
+                        (u16) card->mp_regs[WR_BITMAP_L] & CTRL_PORT_MASK;
+                if (card->mp_wr_bitmap & CTRL_PORT_MASK)
+                        adapter->cmd_sent = false;
+        }
+        dev_dbg(adapter->dev, "info: cmd_sent=%d data_sent=%d\n",
+               adapter->cmd_sent, adapter->data_sent);
+        if (sdio_ireg & UP_LD_HOST_INT_STATUS) {
+                card->mp_rd_bitmap = ((u16) card->mp_regs[RD_BITMAP_U]) << 8;
+                card->mp_rd_bitmap |= (u16) card->mp_regs[RD_BITMAP_L];
+                dev_dbg(adapter->dev, "int: UPLD: rd_bitmap=0x%04x\n",
+                                card->mp_rd_bitmap);
+                while (true) {
+                        ret = mwifiex_get_rd_port(adapter, &port);
+                        if (ret) {
+                                dev_dbg(adapter->dev,
+                                        "info: no more rd_port available\n");
+                                break;
+                        }
+                        len_reg_l = RD_LEN_P0_L + (port << 1);
+                        len_reg_u = RD_LEN_P0_U + (port << 1);
+                        rx_len = ((u16) card->mp_regs[len_reg_u]) << 8;
+                        rx_len |= (u16) card->mp_regs[len_reg_l];
+                        dev_dbg(adapter->dev, "info: RX: port=%d rx_len=%u\n",
+                                        port, rx_len);
+                        rx_blocks =
+                                (rx_len + MWIFIEX_SDIO_BLOCK_SIZE -
+                                 1) / MWIFIEX_SDIO_BLOCK_SIZE;
+                        if (rx_len <= INTF_HEADER_LEN
+                            || (rx_blocks * MWIFIEX_SDIO_BLOCK_SIZE) >
+                            MWIFIEX_RX_DATA_BUF_SIZE) {
+                                dev_err(adapter->dev, "invalid rx_len=%d\n",
+                                                rx_len);
+                                return -1;
+                        }
+                        rx_len = (u16) (rx_blocks * MWIFIEX_SDIO_BLOCK_SIZE);
+                        skb = dev_alloc_skb(rx_len);
+                        if (!skb) {
+                                dev_err(adapter->dev, "%s: failed to alloc skb",
+                                                                __func__);
+                                return -1;
+                        }
+                        skb_put(skb, rx_len);
+                        dev_dbg(adapter->dev, "info: rx_len = %d skb->len = %d\n",
+                                        rx_len, skb->len);
+                        if (mwifiex_sdio_card_to_host_mp_aggr(adapter, skb,
+                                                              port)) {
+                                u32 cr = 0;
+                                dev_err(adapter->dev, "card_to_host_mpa failed:"
+                                                " int status=%#x\n", sdio_ireg);
+                                if (mwifiex_read_reg(adapter,
+                                                     CONFIGURATION_REG, &cr))
+                                        dev_err(adapter->dev,
+                                                        "read CFG reg failed\n");
+                                dev_dbg(adapter->dev,
+                                                "info: CFG reg val = %d\n", cr);
+                                if (mwifiex_write_reg(adapter,
+                                                      CONFIGURATION_REG,
+                                                      (cr | 0x04)))
+                                        dev_err(adapter->dev,
+                                                        "write CFG reg failed\n");
+                                dev_dbg(adapter->dev, "info: write success\n");
+                                if (mwifiex_read_reg(adapter,
+                                                     CONFIGURATION_REG, &cr))
+                                        dev_err(adapter->dev,
+                                                        "read CFG reg failed\n");
+                                dev_dbg(adapter->dev,
+                                                "info: CFG reg val =%x\n", cr);
+                                dev_kfree_skb_any(skb);
+                                return -1;
+                        }
+                }
+        }
+        return 0;
+}
+/*
+ * This function aggregates transmission buffers in driver and downloads
+ * the aggregated packet to card.
+ *
+ * The individual packets are aggregated by copying into an aggregation
+ * buffer and then downloaded to the card. Previous unsent packets in the
+ * aggregation buffer are pre-copied first before new packets are added.
+ * Aggregation is done till there is space left in the aggregation buffer,
+ * or till new packets are available.
+ *
+ * The function will only download the packet to the card when aggregation
+ * stops, otherwise it will just aggregate the packet in aggregation buffer
+ * and return.
+ */
+static int mwifiex_host_to_card_mp_aggr(struct mwifiex_adapter *adapter,
+                                        u8 *payload, u32 pkt_len, u8 port,
+                                        u32 next_pkt_len)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        int ret = 0;
+        s32 f_send_aggr_buf = 0;
+        s32 f_send_cur_buf = 0;
+        s32 f_precopy_cur_buf = 0;
+        s32 f_postcopy_cur_buf = 0;
+        if ((!card->mpa_tx.enabled) || (port == CTRL_PORT)) {
+                dev_dbg(adapter->dev, "info: %s: tx aggregation disabled\n",
+                                                __func__);
+                f_send_cur_buf = 1;
+                goto tx_curr_single;
+        }
+        if (next_pkt_len) {
+                /* More pkt in TX queue */
+                dev_dbg(adapter->dev, "info: %s: more packets in queue.\n",
+                                                __func__);
+                if (MP_TX_AGGR_IN_PROGRESS(card)) {
+                        if (!MP_TX_AGGR_PORT_LIMIT_REACHED(card) &&
+                            MP_TX_AGGR_BUF_HAS_ROOM(card, pkt_len)) {
+                                f_precopy_cur_buf = 1;
+                                if (!(card->mp_wr_bitmap &
+                                                (1 << card->curr_wr_port))
+                                                || !MP_TX_AGGR_BUF_HAS_ROOM(
+                                                        card, next_pkt_len))
+                                        f_send_aggr_buf = 1;
+                        } else {
+                                /* No room in Aggr buf, send it */
+                                f_send_aggr_buf = 1;
+                                if (MP_TX_AGGR_PORT_LIMIT_REACHED(card) ||
+                                    !(card->mp_wr_bitmap &
+                                      (1 << card->curr_wr_port)))
+                                        f_send_cur_buf = 1;
+                                else
+                                        f_postcopy_cur_buf = 1;
+                        }
+                } else {
+                        if (MP_TX_AGGR_BUF_HAS_ROOM(card, pkt_len)
+                            && (card->mp_wr_bitmap & (1 << card->curr_wr_port)))
+                                f_precopy_cur_buf = 1;
+                        else
+                                f_send_cur_buf = 1;
+                }
+        } else {
+                /* Last pkt in TX queue */
+                dev_dbg(adapter->dev, "info: %s: Last packet in Tx Queue.\n",
+                                                __func__);
+                if (MP_TX_AGGR_IN_PROGRESS(card)) {
+                        /* some packs in Aggr buf already */
+                        f_send_aggr_buf = 1;
+                        if (MP_TX_AGGR_BUF_HAS_ROOM(card, pkt_len))
+                                f_precopy_cur_buf = 1;
+                        else
+                                /* No room in Aggr buf, send it */
+                                f_send_cur_buf = 1;
+                } else {
+                        f_send_cur_buf = 1;
+                }
+        }
+        if (f_precopy_cur_buf) {
+                dev_dbg(adapter->dev, "data: %s: precopy current buffer\n",
+                                                __func__);
+                MP_TX_AGGR_BUF_PUT(card, payload, pkt_len, port);
+                if (MP_TX_AGGR_PKT_LIMIT_REACHED(card) ||
+                    MP_TX_AGGR_PORT_LIMIT_REACHED(card))
+                        /* No more pkts allowed in Aggr buf, send it */
+                        f_send_aggr_buf = 1;
+        }
+        if (f_send_aggr_buf) {
+                dev_dbg(adapter->dev, "data: %s: send aggr buffer: %d %d\n",
+                                __func__,
+                                card->mpa_tx.start_port, card->mpa_tx.ports);
+                ret = mwifiex_write_data_to_card(adapter, card->mpa_tx.buf,
+                                                 card->mpa_tx.buf_len,
+                                                 (adapter->ioport | 0x1000 |
+                                                 (card->mpa_tx.ports << 4)) +
+                                                  card->mpa_tx.start_port);
+                MP_TX_AGGR_BUF_RESET(card);
+        }
+tx_curr_single:
+        if (f_send_cur_buf) {
+                dev_dbg(adapter->dev, "data: %s: send current buffer %d\n",
+                                                __func__, port);
+                ret = mwifiex_write_data_to_card(adapter, payload, pkt_len,
+                                                 adapter->ioport + port);
+        }
+        if (f_postcopy_cur_buf) {
+                dev_dbg(adapter->dev, "data: %s: postcopy current buffer\n",
+                                                __func__);
+                MP_TX_AGGR_BUF_PUT(card, payload, pkt_len, port);
+        }
+        return ret;
+}
+/*
+ * This function downloads data from driver to card.
+ *
+ * Both commands and data packets are transferred to the card by this
+ * function.
+ *
+ * This function adds the SDIO specific header to the front of the buffer
+ * before transferring. The header contains the length of the packet and
+ * the type. The firmware handles the packets based upon this set type.
+ */
+static int mwifiex_sdio_host_to_card(struct mwifiex_adapter *adapter,
+                                     u8 type, u8 *payload, u32 pkt_len,
+                                     struct mwifiex_tx_param *tx_param)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        int ret;
+        u32 buf_block_len;
+        u32 blk_size;
+        u8 port = CTRL_PORT;
+        /* Allocate buffer and copy payload */
+        blk_size = MWIFIEX_SDIO_BLOCK_SIZE;
+        buf_block_len = (pkt_len + blk_size - 1) / blk_size;
+        *(u16 *) &payload[0] = (u16) pkt_len;
+        *(u16 *) &payload[2] = type;
+        /*
+         * This is SDIO specific header
+         *  u16 length,
+         *  u16 type (MWIFIEX_TYPE_DATA = 0, MWIFIEX_TYPE_CMD = 1,
+         *  MWIFIEX_TYPE_EVENT = 3)
+         */
+        if (type == MWIFIEX_TYPE_DATA) {
+                ret = mwifiex_get_wr_port_data(adapter, &port);
+                if (ret) {
+                        dev_err(adapter->dev, "%s: no wr_port available\n",
+                                                __func__);
+                        return ret;
+                }
+        } else {
+                adapter->cmd_sent = true;
+                /* Type must be MWIFIEX_TYPE_CMD */
+                if (pkt_len <= INTF_HEADER_LEN ||
+                    pkt_len > MWIFIEX_UPLD_SIZE)
+                        dev_err(adapter->dev, "%s: payload=%p, nb=%d\n",
+                                        __func__, payload, pkt_len);
+        }
+        /* Transfer data to card */
+        pkt_len = buf_block_len * blk_size;
+        if (tx_param)
+                ret = mwifiex_host_to_card_mp_aggr(adapter, payload, pkt_len,
+                                port, tx_param->next_pkt_len);
+        else
+                ret = mwifiex_host_to_card_mp_aggr(adapter, payload, pkt_len,
+                                port, 0);
+        if (ret) {
+                if (type == MWIFIEX_TYPE_CMD)
+                        adapter->cmd_sent = false;
+                if (type == MWIFIEX_TYPE_DATA)
+                        adapter->data_sent = false;
+        } else {
+                if (type == MWIFIEX_TYPE_DATA) {
+                        if (!(card->mp_wr_bitmap & (1 << card->curr_wr_port)))
+                                adapter->data_sent = true;
+                        else
+                                adapter->data_sent = false;
+                }
+        }
+        return ret;
+}
+/*
+ * This function allocates the MPA Tx and Rx buffers.
+ */
+static int mwifiex_alloc_sdio_mpa_buffers(struct mwifiex_adapter *adapter,
+                                   u32 mpa_tx_buf_size, u32 mpa_rx_buf_size)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        int ret = 0;
+        card->mpa_tx.buf = kzalloc(mpa_tx_buf_size, GFP_KERNEL);
+        if (!card->mpa_tx.buf) {
+                dev_err(adapter->dev, "could not alloc buffer for MP-A TX\n");
+                ret = -1;
+                goto error;
+        }
+        card->mpa_tx.buf_size = mpa_tx_buf_size;
+        card->mpa_rx.buf = kzalloc(mpa_rx_buf_size, GFP_KERNEL);
+        if (!card->mpa_rx.buf) {
+                dev_err(adapter->dev, "could not alloc buffer for MP-A RX\n");
+                ret = -1;
+                goto error;
+        }
+        card->mpa_rx.buf_size = mpa_rx_buf_size;
+error:
+        if (ret) {
+                kfree(card->mpa_tx.buf);
+                kfree(card->mpa_rx.buf);
+        }
+        return ret;
+}
+/*
+ * This function unregisters the SDIO device.
+ *
+ * The SDIO IRQ is released, the function is disabled and driver
+ * data is set to null.
+ */
+static void
+mwifiex_unregister_dev(struct mwifiex_adapter *adapter)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        if (adapter->card) {
+                /* Release the SDIO IRQ */
+                sdio_claim_host(card->func);
+                sdio_release_irq(card->func);
+                sdio_disable_func(card->func);
+                sdio_release_host(card->func);
+                sdio_set_drvdata(card->func, NULL);
+        }
+}
+/*
+ * This function registers the SDIO device.
+ *
+ * SDIO IRQ is claimed, block size is set and driver data is initialized.
+ */
+static int mwifiex_register_dev(struct mwifiex_adapter *adapter)
+{
+        int ret = 0;
+        struct sdio_mmc_card *card = adapter->card;
+        struct sdio_func *func = card->func;
+        /* save adapter pointer in card */
+        card->adapter = adapter;
+        sdio_claim_host(func);
+        /* Request the SDIO IRQ */
+        ret = sdio_claim_irq(func, mwifiex_sdio_interrupt);
+        if (ret) {
+                pr_err("claim irq failed: ret=%d\n", ret);
+                goto disable_func;
+        }
+        /* Set block size */
+        ret = sdio_set_block_size(card->func, MWIFIEX_SDIO_BLOCK_SIZE);
+        if (ret) {
+                pr_err("cannot set SDIO block size\n");
+                ret = -1;
+                goto release_irq;
+        }
+        sdio_release_host(func);
+        sdio_set_drvdata(func, card);
+        adapter->dev = &func->dev;
+        return 0;
+release_irq:
+        sdio_release_irq(func);
+disable_func:
+        sdio_disable_func(func);
+        sdio_release_host(func);
+        adapter->card = NULL;
+        return -1;
+}
+/*
+ * This function initializes the SDIO driver.
+ *
+ * The following initializations steps are followed -
+ *      - Read the Host interrupt status register to acknowledge
+ *        the first interrupt got from bootloader
+ *      - Disable host interrupt mask register
+ *      - Get SDIO port
+ *      - Get revision ID
+ *      - Initialize SDIO variables in card
+ *      - Allocate MP registers
+ *      - Allocate MPA Tx and Rx buffers
+ */
+static int mwifiex_init_sdio(struct mwifiex_adapter *adapter)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        int ret;
+        u32 sdio_ireg;
+        /*
+         * Read the HOST_INT_STATUS_REG for ACK the first interrupt got
+         * from the bootloader. If we don't do this we get a interrupt
+         * as soon as we register the irq.
+         */
+        mwifiex_read_reg(adapter, HOST_INTSTATUS_REG, &sdio_ireg);
+        /* Disable host interrupt mask register for SDIO */
+        mwifiex_sdio_disable_host_int(adapter);
+        /* Get SDIO ioport */
+        mwifiex_init_sdio_ioport(adapter);
+        /* Get revision ID */
+#define REV_ID_REG      0x5c
+        mwifiex_read_reg(adapter, REV_ID_REG, &adapter->revision_id);
+        /* Initialize SDIO variables in card */
+        card->mp_rd_bitmap = 0;
+        card->mp_wr_bitmap = 0;
+        card->curr_rd_port = 1;
+        card->curr_wr_port = 1;
+        card->mp_data_port_mask = DATA_PORT_MASK;
+        card->mpa_tx.buf_len = 0;
+        card->mpa_tx.pkt_cnt = 0;
+        card->mpa_tx.start_port = 0;
+        card->mpa_tx.enabled = 0;
+        card->mpa_tx.pkt_aggr_limit = SDIO_MP_AGGR_DEF_PKT_LIMIT;
+        card->mpa_rx.buf_len = 0;
+        card->mpa_rx.pkt_cnt = 0;
+        card->mpa_rx.start_port = 0;
+        card->mpa_rx.enabled = 0;
+        card->mpa_rx.pkt_aggr_limit = SDIO_MP_AGGR_DEF_PKT_LIMIT;
+        /* Allocate buffers for SDIO MP-A */
+        card->mp_regs = kzalloc(MAX_MP_REGS, GFP_KERNEL);
+        if (!card->mp_regs) {
+                dev_err(adapter->dev, "failed to alloc mp_regs\n");
+                return -ENOMEM;
+        }
+        ret = mwifiex_alloc_sdio_mpa_buffers(adapter,
+                                             SDIO_MP_TX_AGGR_DEF_BUF_SIZE,
+                                             SDIO_MP_RX_AGGR_DEF_BUF_SIZE);
+        if (ret) {
+                dev_err(adapter->dev, "failed to alloc sdio mp-a buffers\n");
+                kfree(card->mp_regs);
+                return -1;
+        }
+        return ret;
+}
+/*
+ * This function resets the MPA Tx and Rx buffers.
+ */
+static void mwifiex_cleanup_mpa_buf(struct mwifiex_adapter *adapter)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        MP_TX_AGGR_BUF_RESET(card);
+        MP_RX_AGGR_BUF_RESET(card);
+}
+/*
+ * This function cleans up the allocated card buffers.
+ *
+ * The following are freed by this function -
+ *      - MP registers
+ *      - MPA Tx buffer
+ *      - MPA Rx buffer
+ */
+static void mwifiex_cleanup_sdio(struct mwifiex_adapter *adapter)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        kfree(card->mp_regs);
+        kfree(card->mpa_tx.buf);
+        kfree(card->mpa_rx.buf);
+}
+/*
+ * This function updates the MP end port in card.
+ */
+static void
+mwifiex_update_mp_end_port(struct mwifiex_adapter *adapter, u16 port)
+{
+        struct sdio_mmc_card *card = adapter->card;
+        int i;
+        card->mp_end_port = port;
+        card->mp_data_port_mask = DATA_PORT_MASK;
+        for (i = 1; i <= MAX_PORT - card->mp_end_port; i++)
+                card->mp_data_port_mask &= ~(1 << (MAX_PORT - i));
+        card->curr_wr_port = 1;
+        dev_dbg(adapter->dev, "cmd: mp_end_port %d, data port mask 0x%x\n",
+               port, card->mp_data_port_mask);
+}
+static struct mwifiex_if_ops sdio_ops = {
+        .init_if = mwifiex_init_sdio,
+        .cleanup_if = mwifiex_cleanup_sdio,
+        .check_fw_status = mwifiex_check_fw_status,
+        .prog_fw = mwifiex_prog_fw_w_helper,
+        .register_dev = mwifiex_register_dev,
+        .unregister_dev = mwifiex_unregister_dev,
+        .enable_int = mwifiex_sdio_enable_host_int,
+        .process_int_status = mwifiex_process_int_status,
+        .host_to_card = mwifiex_sdio_host_to_card,
+        .wakeup = mwifiex_pm_wakeup_card,
+        .wakeup_complete = mwifiex_pm_wakeup_card_complete,
+        /* SDIO specific */
+        .update_mp_end_port = mwifiex_update_mp_end_port,
+        .cleanup_mpa_buf = mwifiex_cleanup_mpa_buf,
+};
+/*
+ * This function initializes the SDIO driver.
+ *
+ * This initiates the semaphore and registers the device with
+ * SDIO bus.
+ */
+static int
+mwifiex_sdio_init_module(void)
+{
+        sema_init(&add_remove_card_sem, 1);
+        return sdio_register_driver(&mwifiex_sdio);
+}
+/*
+ * This function cleans up the SDIO driver.
+ *
+ * The following major steps are followed for cleanup -
+ *      - Resume the device if its suspended
+ *      - Disconnect the device if connected
+ *      - Shutdown the firmware
+ *      - Unregister the device from SDIO bus.
+ */
+static void
+mwifiex_sdio_cleanup_module(void)
+{
+        struct mwifiex_adapter *adapter = g_adapter;
+        int i;
+        if (down_interruptible(&add_remove_card_sem))
+                goto exit_sem_err;
+        if (!adapter || !adapter->priv_num)
+                goto exit;
+        if (adapter->is_suspended)
+                mwifiex_sdio_resume(adapter->dev);
+        for (i = 0; i < adapter->priv_num; i++)
+                if ((GET_BSS_ROLE(adapter->priv[i]) == MWIFIEX_BSS_ROLE_STA) &&
+                    adapter->priv[i]->media_connected)
+                        mwifiex_deauthenticate(adapter->priv[i], NULL);
+        if (!adapter->surprise_removed)
+                mwifiex_init_shutdown_fw(mwifiex_get_priv(adapter,
+                                                          MWIFIEX_BSS_ROLE_ANY),
+                                         MWIFIEX_FUNC_SHUTDOWN);
+exit:
+        up(&add_remove_card_sem);
+exit_sem_err:
+        sdio_unregister_driver(&mwifiex_sdio);
+}
+module_init(mwifiex_sdio_init_module);
+module_exit(mwifiex_sdio_cleanup_module);
+MODULE_AUTHOR("Marvell International Ltd.");
+MODULE_DESCRIPTION("Marvell WiFi-Ex SDIO Driver version " SDIO_VERSION);
+MODULE_VERSION(SDIO_VERSION);
+MODULE_LICENSE("GPL v2");
+MODULE_FIRMWARE("sd8787.bin");
diff --git a/drivers/net/wireless/mwifiex/sdio.h b/drivers/net/wireless/mwifiex/sdio.h
new file mode 100644
index 000000000000..a0e9bc5253e0
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/sdio.h
@@ -0,0 +1,305 @@
+/*
+ * Marvell Wireless LAN device driver: SDIO specific definitions
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef _MWIFIEX_SDIO_H
+#define _MWIFIEX_SDIO_H
+#include <linux/mmc/sdio.h>
+#include <linux/mmc/sdio_ids.h>
+#include <linux/mmc/sdio_func.h>
+#include <linux/mmc/card.h>
+#include "main.h"
+#define BLOCK_MODE      1
+#define BYTE_MODE       0
+#define REG_PORT                        0
+#define RD_BITMAP_L                     0x04
+#define RD_BITMAP_U                     0x05
+#define WR_BITMAP_L                     0x06
+#define WR_BITMAP_U                     0x07
+#define RD_LEN_P0_L                     0x08
+#define RD_LEN_P0_U                     0x09
+#define MWIFIEX_SDIO_IO_PORT_MASK               0xfffff
+#define MWIFIEX_SDIO_BYTE_MODE_MASK     0x80000000
+#define CTRL_PORT                       0
+#define CTRL_PORT_MASK                  0x0001
+#define DATA_PORT_MASK                  0xfffe
+#define MAX_MP_REGS                     64
+#define MAX_PORT                        16
+#define SDIO_MP_AGGR_DEF_PKT_LIMIT      8
+#define SDIO_MP_TX_AGGR_DEF_BUF_SIZE        (4096)      /* 4K */
+/* Multi port RX aggregation buffer size */
+#define SDIO_MP_RX_AGGR_DEF_BUF_SIZE        (4096)      /* 4K */
+/* Misc. Config Register : Auto Re-enable interrupts */
+#define AUTO_RE_ENABLE_INT              BIT(4)
+/* Host Control Registers */
+/* Host Control Registers : I/O port 0 */
+#define IO_PORT_0_REG                   0x78
+/* Host Control Registers : I/O port 1 */
+#define IO_PORT_1_REG                   0x79
+/* Host Control Registers : I/O port 2 */
+#define IO_PORT_2_REG                   0x7A
+/* Host Control Registers : Configuration */
+#define CONFIGURATION_REG               0x00
+/* Host Control Registers : Host without Command 53 finish host*/
+#define HOST_TO_CARD_EVENT       (0x1U << 3)
+/* Host Control Registers : Host without Command 53 finish host */
+#define HOST_WO_CMD53_FINISH_HOST       (0x1U << 2)
+/* Host Control Registers : Host power up */
+#define HOST_POWER_UP                   (0x1U << 1)
+/* Host Control Registers : Host power down */
+#define HOST_POWER_DOWN                 (0x1U << 0)
+/* Host Control Registers : Host interrupt mask */
+#define HOST_INT_MASK_REG               0x02
+/* Host Control Registers : Upload host interrupt mask */
+#define UP_LD_HOST_INT_MASK             (0x1U)
+/* Host Control Registers : Download host interrupt mask */
+#define DN_LD_HOST_INT_MASK             (0x2U)
+/* Enable Host interrupt mask */
+#define HOST_INT_ENABLE (UP_LD_HOST_INT_MASK | DN_LD_HOST_INT_MASK)
+/* Disable Host interrupt mask */
+#define HOST_INT_DISABLE                0xff
+/* Host Control Registers : Host interrupt status */
+#define HOST_INTSTATUS_REG              0x03
+/* Host Control Registers : Upload host interrupt status */
+#define UP_LD_HOST_INT_STATUS           (0x1U)
+/* Host Control Registers : Download host interrupt status */
+#define DN_LD_HOST_INT_STATUS           (0x2U)
+/* Host Control Registers : Host interrupt RSR */
+#define HOST_INT_RSR_REG                0x01
+/* Host Control Registers : Upload host interrupt RSR */
+#define UP_LD_HOST_INT_RSR              (0x1U)
+#define SDIO_INT_MASK                   0x3F
+/* Host Control Registers : Host interrupt status */
+#define HOST_INT_STATUS_REG             0x28
+/* Host Control Registers : Upload CRC error */
+#define UP_LD_CRC_ERR                   (0x1U << 2)
+/* Host Control Registers : Upload restart */
+#define UP_LD_RESTART                   (0x1U << 1)
+/* Host Control Registers : Download restart */
+#define DN_LD_RESTART                   (0x1U << 0)
+/* Card Control Registers : Card status register */
+#define CARD_STATUS_REG                 0x30
+/* Card Control Registers : Card I/O ready */
+#define CARD_IO_READY                   (0x1U << 3)
+/* Card Control Registers : CIS card ready */
+#define CIS_CARD_RDY                    (0x1U << 2)
+/* Card Control Registers : Upload card ready */
+#define UP_LD_CARD_RDY                  (0x1U << 1)
+/* Card Control Registers : Download card ready */
+#define DN_LD_CARD_RDY                  (0x1U << 0)
+/* Card Control Registers : Host interrupt mask register */
+#define HOST_INTERRUPT_MASK_REG         0x34
+/* Card Control Registers : Host power interrupt mask */
+#define HOST_POWER_INT_MASK             (0x1U << 3)
+/* Card Control Registers : Abort card interrupt mask */
+#define ABORT_CARD_INT_MASK             (0x1U << 2)
+/* Card Control Registers : Upload card interrupt mask */
+#define UP_LD_CARD_INT_MASK             (0x1U << 1)
+/* Card Control Registers : Download card interrupt mask */
+#define DN_LD_CARD_INT_MASK             (0x1U << 0)
+/* Card Control Registers : Card interrupt status register */
+#define CARD_INTERRUPT_STATUS_REG       0x38
+/* Card Control Registers : Power up interrupt */
+#define POWER_UP_INT                    (0x1U << 4)
+/* Card Control Registers : Power down interrupt */
+#define POWER_DOWN_INT                  (0x1U << 3)
+/* Card Control Registers : Card interrupt RSR register */
+#define CARD_INTERRUPT_RSR_REG          0x3c
+/* Card Control Registers : Power up RSR */
+#define POWER_UP_RSR                    (0x1U << 4)
+/* Card Control Registers : Power down RSR */
+#define POWER_DOWN_RSR                  (0x1U << 3)
+/* Card Control Registers : Miscellaneous Configuration Register */
+#define CARD_MISC_CFG_REG               0x6C
+/* Host F1 read base 0 */
+#define HOST_F1_RD_BASE_0               0x0040
+/* Host F1 read base 1 */
+#define HOST_F1_RD_BASE_1               0x0041
+/* Host F1 card ready */
+#define HOST_F1_CARD_RDY                0x0020
+/* Firmware status 0 register */
+#define CARD_FW_STATUS0_REG             0x60
+/* Firmware status 1 register */
+#define CARD_FW_STATUS1_REG             0x61
+/* Rx length register */
+#define CARD_RX_LEN_REG                 0x62
+/* Rx unit register */
+#define CARD_RX_UNIT_REG                0x63
+/* Event header Len*/
+#define MWIFIEX_EVENT_HEADER_LEN           8
+/* Max retry number of CMD53 write */
+#define MAX_WRITE_IOMEM_RETRY           2
+/* SDIO Tx aggregation in progress ? */
+#define MP_TX_AGGR_IN_PROGRESS(a) (a->mpa_tx.pkt_cnt > 0)
+/* SDIO Tx aggregation buffer room for next packet ? */
+#define MP_TX_AGGR_BUF_HAS_ROOM(a, len) ((a->mpa_tx.buf_len+len)        \
+                                                <= a->mpa_tx.buf_size)
+/* Copy current packet (SDIO Tx aggregation buffer) to SDIO buffer */
+#define MP_TX_AGGR_BUF_PUT(a, payload, pkt_len, port) do {              \
+        memmove(&a->mpa_tx.buf[a->mpa_tx.buf_len],                      \
+                        payload, pkt_len);                              \
+        a->mpa_tx.buf_len += pkt_len;                                   \
+        if (!a->mpa_tx.pkt_cnt)                                         \
+                a->mpa_tx.start_port = port;                            \
+        if (a->mpa_tx.start_port <= port)                               \
+                a->mpa_tx.ports |= (1<<(a->mpa_tx.pkt_cnt));            \
+        else                                                            \
+                a->mpa_tx.ports |= (1<<(a->mpa_tx.pkt_cnt+1+(MAX_PORT - \
+                                                a->mp_end_port)));      \
+        a->mpa_tx.pkt_cnt++;                                            \
+} while (0);
+/* SDIO Tx aggregation limit ? */
+#define MP_TX_AGGR_PKT_LIMIT_REACHED(a)                                 \
+                        (a->mpa_tx.pkt_cnt == a->mpa_tx.pkt_aggr_limit)
+/* SDIO Tx aggregation port limit ? */
+#define MP_TX_AGGR_PORT_LIMIT_REACHED(a) ((a->curr_wr_port <            \
+                        a->mpa_tx.start_port) && (((MAX_PORT -          \
+                        a->mpa_tx.start_port) + a->curr_wr_port) >=     \
+                                SDIO_MP_AGGR_DEF_PKT_LIMIT))
+/* Reset SDIO Tx aggregation buffer parameters */
+#define MP_TX_AGGR_BUF_RESET(a) do {                                    \
+        a->mpa_tx.pkt_cnt = 0;                                          \
+        a->mpa_tx.buf_len = 0;                                          \
+        a->mpa_tx.ports = 0;                                            \
+        a->mpa_tx.start_port = 0;                                       \
+} while (0);
+/* SDIO Rx aggregation limit ? */
+#define MP_RX_AGGR_PKT_LIMIT_REACHED(a)                                 \
+                        (a->mpa_rx.pkt_cnt == a->mpa_rx.pkt_aggr_limit)
+/* SDIO Tx aggregation port limit ? */
+#define MP_RX_AGGR_PORT_LIMIT_REACHED(a) ((a->curr_rd_port <            \
+                        a->mpa_rx.start_port) && (((MAX_PORT -          \
+                        a->mpa_rx.start_port) + a->curr_rd_port) >=     \
+                        SDIO_MP_AGGR_DEF_PKT_LIMIT))
+/* SDIO Rx aggregation in progress ? */
+#define MP_RX_AGGR_IN_PROGRESS(a) (a->mpa_rx.pkt_cnt > 0)
+/* SDIO Rx aggregation buffer room for next packet ? */
+#define MP_RX_AGGR_BUF_HAS_ROOM(a, rx_len)                              \
+                        ((a->mpa_rx.buf_len+rx_len) <= a->mpa_rx.buf_size)
+/* Prepare to copy current packet from card to SDIO Rx aggregation buffer */
+#define MP_RX_AGGR_SETUP(a, skb, port) do {                             \
+        a->mpa_rx.buf_len += skb->len;                                  \
+        if (!a->mpa_rx.pkt_cnt)                                         \
+                a->mpa_rx.start_port = port;                            \
+        if (a->mpa_rx.start_port <= port)                               \
+                a->mpa_rx.ports |= (1<<(a->mpa_rx.pkt_cnt));            \
+        else                                                            \
+                a->mpa_rx.ports |= (1<<(a->mpa_rx.pkt_cnt+1));          \
+        a->mpa_rx.skb_arr[a->mpa_rx.pkt_cnt] = skb;                     \
+        a->mpa_rx.len_arr[a->mpa_rx.pkt_cnt] = skb->len;                \
+        a->mpa_rx.pkt_cnt++;                                            \
+} while (0);
+/* Reset SDIO Rx aggregation buffer parameters */
+#define MP_RX_AGGR_BUF_RESET(a) do {                                    \
+        a->mpa_rx.pkt_cnt = 0;                                          \
+        a->mpa_rx.buf_len = 0;                                          \
+        a->mpa_rx.ports = 0;                                            \
+        a->mpa_rx.start_port = 0;                                       \
+} while (0);
+/* data structure for SDIO MPA TX */
+struct mwifiex_sdio_mpa_tx {
+        /* multiport tx aggregation buffer pointer */
+        u8 *buf;
+        u32 buf_len;
+        u32 pkt_cnt;
+        u16 ports;
+        u16 start_port;
+        u8 enabled;
+        u32 buf_size;
+        u32 pkt_aggr_limit;
+};
+struct mwifiex_sdio_mpa_rx {
+        u8 *buf;
+        u32 buf_len;
+        u32 pkt_cnt;
+        u16 ports;
+        u16 start_port;
+        struct sk_buff *skb_arr[SDIO_MP_AGGR_DEF_PKT_LIMIT];
+        u32 len_arr[SDIO_MP_AGGR_DEF_PKT_LIMIT];
+        u8 enabled;
+        u32 buf_size;
+        u32 pkt_aggr_limit;
+};
+int mwifiex_bus_register(void);
+void mwifiex_bus_unregister(void);
+struct sdio_mmc_card {
+        struct sdio_func *func;
+        struct mwifiex_adapter *adapter;
+        u16 mp_rd_bitmap;
+        u16 mp_wr_bitmap;
+        u16 mp_end_port;
+        u16 mp_data_port_mask;
+        u8 curr_rd_port;
+        u8 curr_wr_port;
+        u8 *mp_regs;
+        struct mwifiex_sdio_mpa_tx mpa_tx;
+        struct mwifiex_sdio_mpa_rx mpa_rx;
+};
+#endif /* _MWIFIEX_SDIO_H */
diff --git a/drivers/net/wireless/mwifiex/sta_cmd.c b/drivers/net/wireless/mwifiex/sta_cmd.c
new file mode 100644
index 000000000000..8af3a78d2723
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/sta_cmd.c
@@ -0,0 +1,1219 @@
+/*
+ * Marvell Wireless LAN device driver: station command handling
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+/*
+ * This function prepares command to set/get RSSI information.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting data/beacon average factors
+ *      - Resetting SNR/NF/RSSI values in private structure
+ *      - Ensuring correct endian-ness
+ */
+static int
+mwifiex_cmd_802_11_rssi_info(struct mwifiex_private *priv,
+                             struct host_cmd_ds_command *cmd, u16 cmd_action)
+{
+        cmd->command = cpu_to_le16(HostCmd_CMD_RSSI_INFO);
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_802_11_rssi_info) +
+                                S_DS_GEN);
+        cmd->params.rssi_info.action = cpu_to_le16(cmd_action);
+        cmd->params.rssi_info.ndata = cpu_to_le16(priv->data_avg_factor);
+        cmd->params.rssi_info.nbcn = cpu_to_le16(priv->bcn_avg_factor);
+        /* Reset SNR/NF/RSSI values in private structure */
+        priv->data_rssi_last = 0;
+        priv->data_nf_last = 0;
+        priv->data_rssi_avg = 0;
+        priv->data_nf_avg = 0;
+        priv->bcn_rssi_last = 0;
+        priv->bcn_nf_last = 0;
+        priv->bcn_rssi_avg = 0;
+        priv->bcn_nf_avg = 0;
+        return 0;
+}
+/*
+ * This function prepares command to set MAC control.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_mac_control(struct mwifiex_private *priv,
+                                   struct host_cmd_ds_command *cmd,
+                                   u16 cmd_action, void *data_buf)
+{
+        struct host_cmd_ds_mac_control *mac_ctrl = &cmd->params.mac_ctrl;
+        u16 action = *((u16 *) data_buf);
+        if (cmd_action != HostCmd_ACT_GEN_SET) {
+                dev_err(priv->adapter->dev,
+                        "mac_control: only support set cmd\n");
+                return -1;
+        }
+        cmd->command = cpu_to_le16(HostCmd_CMD_MAC_CONTROL);
+        cmd->size =
+                cpu_to_le16(sizeof(struct host_cmd_ds_mac_control) + S_DS_GEN);
+        mac_ctrl->action = cpu_to_le16(action);
+        return 0;
+}
+/*
+ * This function prepares command to set/get SNMP MIB.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting SNMP MIB OID number and value
+ *        (as required)
+ *      - Ensuring correct endian-ness
+ *
+ * The following SNMP MIB OIDs are supported -
+ *      - FRAG_THRESH_I     : Fragmentation threshold
+ *      - RTS_THRESH_I      : RTS threshold
+ *      - SHORT_RETRY_LIM_I : Short retry limit
+ *      - DOT11D_I          : 11d support
+ */
+static int mwifiex_cmd_802_11_snmp_mib(struct mwifiex_private *priv,
+                                       struct host_cmd_ds_command *cmd,
+                                       u16 cmd_action, u32 cmd_oid,
+                                       void *data_buf)
+{
+        struct host_cmd_ds_802_11_snmp_mib *snmp_mib = &cmd->params.smib;
+        u32 ul_temp;
+        dev_dbg(priv->adapter->dev, "cmd: SNMP_CMD: cmd_oid = 0x%x\n", cmd_oid);
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_SNMP_MIB);
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_802_11_snmp_mib)
+                - 1 + S_DS_GEN);
+        if (cmd_action == HostCmd_ACT_GEN_GET) {
+                snmp_mib->query_type = cpu_to_le16(HostCmd_ACT_GEN_GET);
+                snmp_mib->buf_size = cpu_to_le16(MAX_SNMP_BUF_SIZE);
+                cmd->size = cpu_to_le16(le16_to_cpu(cmd->size)
+                        + MAX_SNMP_BUF_SIZE);
+        }
+        switch (cmd_oid) {
+        case FRAG_THRESH_I:
+                snmp_mib->oid = cpu_to_le16((u16) FRAG_THRESH_I);
+                if (cmd_action == HostCmd_ACT_GEN_SET) {
+                        snmp_mib->query_type = cpu_to_le16(HostCmd_ACT_GEN_SET);
+                        snmp_mib->buf_size = cpu_to_le16(sizeof(u16));
+                        ul_temp = *((u32 *) data_buf);
+                        *((__le16 *) (snmp_mib->value)) =
+                                cpu_to_le16((u16) ul_temp);
+                        cmd->size = cpu_to_le16(le16_to_cpu(cmd->size)
+                                + sizeof(u16));
+                }
+                break;
+        case RTS_THRESH_I:
+                snmp_mib->oid = cpu_to_le16((u16) RTS_THRESH_I);
+                if (cmd_action == HostCmd_ACT_GEN_SET) {
+                        snmp_mib->query_type = cpu_to_le16(HostCmd_ACT_GEN_SET);
+                        snmp_mib->buf_size = cpu_to_le16(sizeof(u16));
+                        ul_temp = *((u32 *) data_buf);
+                        *(__le16 *) (snmp_mib->value) =
+                                cpu_to_le16((u16) ul_temp);
+                        cmd->size = cpu_to_le16(le16_to_cpu(cmd->size)
+                                + sizeof(u16));
+                }
+                break;
+        case SHORT_RETRY_LIM_I:
+                snmp_mib->oid = cpu_to_le16((u16) SHORT_RETRY_LIM_I);
+                if (cmd_action == HostCmd_ACT_GEN_SET) {
+                        snmp_mib->query_type = cpu_to_le16(HostCmd_ACT_GEN_SET);
+                        snmp_mib->buf_size = cpu_to_le16(sizeof(u16));
+                        ul_temp = (*(u32 *) data_buf);
+                        *((__le16 *) (snmp_mib->value)) =
+                                cpu_to_le16((u16) ul_temp);
+                        cmd->size = cpu_to_le16(le16_to_cpu(cmd->size)
+                                + sizeof(u16));
+                }
+                break;
+        case DOT11D_I:
+                snmp_mib->oid = cpu_to_le16((u16) DOT11D_I);
+                if (cmd_action == HostCmd_ACT_GEN_SET) {
+                        snmp_mib->query_type = cpu_to_le16(HostCmd_ACT_GEN_SET);
+                        snmp_mib->buf_size = cpu_to_le16(sizeof(u16));
+                        ul_temp = *(u32 *) data_buf;
+                        *((__le16 *) (snmp_mib->value)) =
+                                cpu_to_le16((u16) ul_temp);
+                        cmd->size = cpu_to_le16(le16_to_cpu(cmd->size)
+                                + sizeof(u16));
+                }
+                break;
+        default:
+                break;
+        }
+        dev_dbg(priv->adapter->dev,
+                "cmd: SNMP_CMD: Action=0x%x, OID=0x%x, OIDSize=0x%x,"
+                " Value=0x%x\n",
+               cmd_action, cmd_oid, le16_to_cpu(snmp_mib->buf_size),
+               le16_to_cpu(*(__le16 *) snmp_mib->value));
+        return 0;
+}
+/*
+ * This function prepares command to get log.
+ *
+ * Preparation includes -
+ *      - Setting command ID and proper size
+ *      - Ensuring correct endian-ness
+ */
+static int
+mwifiex_cmd_802_11_get_log(struct host_cmd_ds_command *cmd)
+{
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_GET_LOG);
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_802_11_get_log) +
+                                S_DS_GEN);
+        return 0;
+}
+/*
+ * This function prepares command to set/get Tx data rate configuration.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting configuration index, rate scope and rate drop pattern
+ *        parameters (as required)
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_tx_rate_cfg(struct mwifiex_private *priv,
+                                   struct host_cmd_ds_command *cmd,
+                                   u16 cmd_action, void *data_buf)
+{
+        struct host_cmd_ds_tx_rate_cfg *rate_cfg = &cmd->params.tx_rate_cfg;
+        struct mwifiex_rate_scope *rate_scope;
+        struct mwifiex_rate_drop_pattern *rate_drop;
+        u16 *pbitmap_rates = (u16 *) data_buf;
+        u32 i;
+        cmd->command = cpu_to_le16(HostCmd_CMD_TX_RATE_CFG);
+        rate_cfg->action = cpu_to_le16(cmd_action);
+        rate_cfg->cfg_index = 0;
+        rate_scope = (struct mwifiex_rate_scope *) ((u8 *) rate_cfg +
+                      sizeof(struct host_cmd_ds_tx_rate_cfg));
+        rate_scope->type = cpu_to_le16(TLV_TYPE_RATE_SCOPE);
+        rate_scope->length = cpu_to_le16(sizeof(struct mwifiex_rate_scope) -
+                        sizeof(struct mwifiex_ie_types_header));
+        if (pbitmap_rates != NULL) {
+                rate_scope->hr_dsss_rate_bitmap = cpu_to_le16(pbitmap_rates[0]);
+                rate_scope->ofdm_rate_bitmap = cpu_to_le16(pbitmap_rates[1]);
+                for (i = 0;
+                     i < sizeof(rate_scope->ht_mcs_rate_bitmap) / sizeof(u16);
+                     i++)
+                        rate_scope->ht_mcs_rate_bitmap[i] =
+                                cpu_to_le16(pbitmap_rates[2 + i]);
+        } else {
+                rate_scope->hr_dsss_rate_bitmap =
+                        cpu_to_le16(priv->bitmap_rates[0]);
+                rate_scope->ofdm_rate_bitmap =
+                        cpu_to_le16(priv->bitmap_rates[1]);
+                for (i = 0;
+                     i < sizeof(rate_scope->ht_mcs_rate_bitmap) / sizeof(u16);
+                     i++)
+                        rate_scope->ht_mcs_rate_bitmap[i] =
+                                cpu_to_le16(priv->bitmap_rates[2 + i]);
+        }
+        rate_drop = (struct mwifiex_rate_drop_pattern *) ((u8 *) rate_scope +
+                        sizeof(struct mwifiex_rate_scope));
+        rate_drop->type = cpu_to_le16(TLV_TYPE_RATE_DROP_CONTROL);
+        rate_drop->length = cpu_to_le16(sizeof(rate_drop->rate_drop_mode));
+        rate_drop->rate_drop_mode = 0;
+        cmd->size =
+                cpu_to_le16(S_DS_GEN + sizeof(struct host_cmd_ds_tx_rate_cfg) +
+                            sizeof(struct mwifiex_rate_scope) +
+                            sizeof(struct mwifiex_rate_drop_pattern));
+        return 0;
+}
+/*
+ * This function prepares command to set/get Tx power configuration.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting Tx power mode, power group TLV
+ *        (as required)
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_tx_power_cfg(struct host_cmd_ds_command *cmd,
+                                    u16 cmd_action, void *data_buf)
+{
+        struct mwifiex_types_power_group *pg_tlv;
+        struct host_cmd_ds_txpwr_cfg *txp;
+        struct host_cmd_ds_txpwr_cfg *cmd_txp_cfg = &cmd->params.txp_cfg;
+        cmd->command = cpu_to_le16(HostCmd_CMD_TXPWR_CFG);
+        cmd->size =
+                cpu_to_le16(S_DS_GEN + sizeof(struct host_cmd_ds_txpwr_cfg));
+        switch (cmd_action) {
+        case HostCmd_ACT_GEN_SET:
+                txp = (struct host_cmd_ds_txpwr_cfg *) data_buf;
+                if (txp->mode) {
+                        pg_tlv = (struct mwifiex_types_power_group
+                                  *) ((unsigned long) data_buf +
+                                     sizeof(struct host_cmd_ds_txpwr_cfg));
+                        memmove(cmd_txp_cfg, data_buf,
+                                sizeof(struct host_cmd_ds_txpwr_cfg) +
+                                sizeof(struct mwifiex_types_power_group) +
+                                pg_tlv->length);
+                        pg_tlv = (struct mwifiex_types_power_group *) ((u8 *)
+                                  cmd_txp_cfg +
+                                  sizeof(struct host_cmd_ds_txpwr_cfg));
+                        cmd->size = cpu_to_le16(le16_to_cpu(cmd->size) +
+                                  sizeof(struct mwifiex_types_power_group) +
+                                  pg_tlv->length);
+                } else {
+                        memmove(cmd_txp_cfg, data_buf,
+                                sizeof(struct host_cmd_ds_txpwr_cfg));
+                }
+                cmd_txp_cfg->action = cpu_to_le16(cmd_action);
+                break;
+        case HostCmd_ACT_GEN_GET:
+                cmd_txp_cfg->action = cpu_to_le16(cmd_action);
+                break;
+        }
+        return 0;
+}
+/*
+ * This function prepares command to set Host Sleep configuration.
+ *
+ * Preparation includes -
+ *      - Setting command ID and proper size
+ *      - Setting Host Sleep action, conditions, ARP filters
+ *        (as required)
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_802_11_hs_cfg(struct mwifiex_private *priv,
+                                     struct host_cmd_ds_command *cmd,
+                                     u16 cmd_action,
+                                     struct mwifiex_hs_config_param *data_buf)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct host_cmd_ds_802_11_hs_cfg_enh *hs_cfg = &cmd->params.opt_hs_cfg;
+        u16 hs_activate = false;
+        if (data_buf == NULL)
+                /* New Activate command */
+                hs_activate = true;
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_HS_CFG_ENH);
+        if (!hs_activate &&
+            (data_buf->conditions
+            != cpu_to_le32(HOST_SLEEP_CFG_CANCEL))
+            && ((adapter->arp_filter_size > 0)
+                && (adapter->arp_filter_size <= ARP_FILTER_MAX_BUF_SIZE))) {
+                dev_dbg(adapter->dev,
+                        "cmd: Attach %d bytes ArpFilter to HSCfg cmd\n",
+                       adapter->arp_filter_size);
+                memcpy(((u8 *) hs_cfg) +
+                       sizeof(struct host_cmd_ds_802_11_hs_cfg_enh),
+                       adapter->arp_filter, adapter->arp_filter_size);
+                cmd->size = cpu_to_le16(adapter->arp_filter_size +
+                                    sizeof(struct host_cmd_ds_802_11_hs_cfg_enh)
+                                    + S_DS_GEN);
+        } else {
+                cmd->size = cpu_to_le16(S_DS_GEN + sizeof(struct
+                                           host_cmd_ds_802_11_hs_cfg_enh));
+        }
+        if (hs_activate) {
+                hs_cfg->action = cpu_to_le16(HS_ACTIVATE);
+                hs_cfg->params.hs_activate.resp_ctrl = RESP_NEEDED;
+        } else {
+                hs_cfg->action = cpu_to_le16(HS_CONFIGURE);
+                hs_cfg->params.hs_config.conditions = data_buf->conditions;
+                hs_cfg->params.hs_config.gpio = data_buf->gpio;
+                hs_cfg->params.hs_config.gap = data_buf->gap;
+                dev_dbg(adapter->dev,
+                        "cmd: HS_CFG_CMD: condition:0x%x gpio:0x%x gap:0x%x\n",
+                       hs_cfg->params.hs_config.conditions,
+                       hs_cfg->params.hs_config.gpio,
+                       hs_cfg->params.hs_config.gap);
+        }
+        return 0;
+}
+/*
+ * This function prepares command to set/get MAC address.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting MAC address (for SET only)
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_802_11_mac_address(struct mwifiex_private *priv,
+                                          struct host_cmd_ds_command *cmd,
+                                          u16 cmd_action)
+{
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_MAC_ADDRESS);
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_802_11_mac_address) +
+                                S_DS_GEN);
+        cmd->result = 0;
+        cmd->params.mac_addr.action = cpu_to_le16(cmd_action);
+        if (cmd_action == HostCmd_ACT_GEN_SET)
+                memcpy(cmd->params.mac_addr.mac_addr, priv->curr_addr,
+                       ETH_ALEN);
+        return 0;
+}
+/*
+ * This function prepares command to set MAC multicast address.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting MAC multicast address
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_mac_multicast_adr(struct host_cmd_ds_command *cmd,
+                                         u16 cmd_action, void *data_buf)
+{
+        struct mwifiex_multicast_list *mcast_list =
+                (struct mwifiex_multicast_list *) data_buf;
+        struct host_cmd_ds_mac_multicast_adr *mcast_addr = &cmd->params.mc_addr;
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_mac_multicast_adr) +
+                                S_DS_GEN);
+        cmd->command = cpu_to_le16(HostCmd_CMD_MAC_MULTICAST_ADR);
+        mcast_addr->action = cpu_to_le16(cmd_action);
+        mcast_addr->num_of_adrs =
+                cpu_to_le16((u16) mcast_list->num_multicast_addr);
+        memcpy(mcast_addr->mac_list, mcast_list->mac_list,
+               mcast_list->num_multicast_addr * ETH_ALEN);
+        return 0;
+}
+/*
+ * This function prepares command to deauthenticate.
+ *
+ * Preparation includes -
+ *      - Setting command ID and proper size
+ *      - Setting AP MAC address and reason code
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_802_11_deauthenticate(struct mwifiex_private *priv,
+                                             struct host_cmd_ds_command *cmd,
+                                             void *data_buf)
+{
+        struct host_cmd_ds_802_11_deauthenticate *deauth = &cmd->params.deauth;
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_DEAUTHENTICATE);
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_802_11_deauthenticate)
+                                + S_DS_GEN);
+        /* Set AP MAC address */
+        memcpy(deauth->mac_addr, (u8 *) data_buf, ETH_ALEN);
+        dev_dbg(priv->adapter->dev, "cmd: Deauth: %pM\n", deauth->mac_addr);
+        deauth->reason_code = cpu_to_le16(WLAN_REASON_DEAUTH_LEAVING);
+        return 0;
+}
+/*
+ * This function prepares command to stop Ad-Hoc network.
+ *
+ * Preparation includes -
+ *      - Setting command ID and proper size
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_802_11_ad_hoc_stop(struct host_cmd_ds_command *cmd)
+{
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_AD_HOC_STOP);
+        cmd->size = cpu_to_le16(S_DS_GEN);
+        return 0;
+}
+/*
+ * This function sets WEP key(s) to key parameter TLV(s).
+ *
+ * Multi-key parameter TLVs are supported, so we can send multiple
+ * WEP keys in a single buffer.
+ */
+static int
+mwifiex_set_keyparamset_wep(struct mwifiex_private *priv,
+                            struct mwifiex_ie_type_key_param_set *key_param_set,
+                            u16 *key_param_len)
+{
+        int cur_key_param_len;
+        u8 i;
+        /* Multi-key_param_set TLV is supported */
+        for (i = 0; i < NUM_WEP_KEYS; i++) {
+                if ((priv->wep_key[i].key_length == WLAN_KEY_LEN_WEP40) ||
+                    (priv->wep_key[i].key_length == WLAN_KEY_LEN_WEP104)) {
+                        key_param_set->type =
+                                cpu_to_le16(TLV_TYPE_KEY_MATERIAL);
+/* Key_param_set WEP fixed length */
+#define KEYPARAMSET_WEP_FIXED_LEN 8
+                        key_param_set->length = cpu_to_le16((u16)
+                                        (priv->wep_key[i].
+                                         key_length +
+                                         KEYPARAMSET_WEP_FIXED_LEN));
+                        key_param_set->key_type_id =
+                                cpu_to_le16(KEY_TYPE_ID_WEP);
+                        key_param_set->key_info =
+                                cpu_to_le16(KEY_ENABLED | KEY_UNICAST |
+                                            KEY_MCAST);
+                        key_param_set->key_len =
+                                cpu_to_le16(priv->wep_key[i].key_length);
+                        /* Set WEP key index */
+                        key_param_set->key[0] = i;
+                        /* Set default Tx key flag */
+                        if (i ==
+                            (priv->
+                             wep_key_curr_index & HostCmd_WEP_KEY_INDEX_MASK))
+                                key_param_set->key[1] = 1;
+                        else
+                                key_param_set->key[1] = 0;
+                        memmove(&key_param_set->key[2],
+                                priv->wep_key[i].key_material,
+                                priv->wep_key[i].key_length);
+                        cur_key_param_len = priv->wep_key[i].key_length +
+                                KEYPARAMSET_WEP_FIXED_LEN +
+                                sizeof(struct mwifiex_ie_types_header);
+                        *key_param_len += (u16) cur_key_param_len;
+                        key_param_set =
+                                (struct mwifiex_ie_type_key_param_set *)
+                                                ((u8 *)key_param_set +
+                                                cur_key_param_len);
+                } else if (!priv->wep_key[i].key_length) {
+                        continue;
+                } else {
+                        dev_err(priv->adapter->dev,
+                                "key%d Length = %d is incorrect\n",
+                               (i + 1), priv->wep_key[i].key_length);
+                        return -1;
+                }
+        }
+        return 0;
+}
+/*
+ * This function prepares command to set/get/reset network key(s).
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting WEP keys, WAPI keys or WPA keys along with required
+ *        encryption (TKIP, AES) (as required)
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_802_11_key_material(struct mwifiex_private *priv,
+                                           struct host_cmd_ds_command *cmd,
+                                           u16 cmd_action,
+                                           u32 cmd_oid, void *data_buf)
+{
+        struct host_cmd_ds_802_11_key_material *key_material =
+                &cmd->params.key_material;
+        struct mwifiex_ds_encrypt_key *enc_key =
+                (struct mwifiex_ds_encrypt_key *) data_buf;
+        u16 key_param_len = 0;
+        int ret = 0;
+        const u8 bc_mac[] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_KEY_MATERIAL);
+        key_material->action = cpu_to_le16(cmd_action);
+        if (cmd_action == HostCmd_ACT_GEN_GET) {
+                cmd->size =
+                        cpu_to_le16(sizeof(key_material->action) + S_DS_GEN);
+                return ret;
+        }
+        if (!enc_key) {
+                memset(&key_material->key_param_set, 0,
+                       (NUM_WEP_KEYS *
+                        sizeof(struct mwifiex_ie_type_key_param_set)));
+                ret = mwifiex_set_keyparamset_wep(priv,
+                                                  &key_material->key_param_set,
+                                                  &key_param_len);
+                cmd->size = cpu_to_le16(key_param_len +
+                                    sizeof(key_material->action) + S_DS_GEN);
+                return ret;
+        } else
+                memset(&key_material->key_param_set, 0,
+                       sizeof(struct mwifiex_ie_type_key_param_set));
+        if (enc_key->is_wapi_key) {
+                dev_dbg(priv->adapter->dev, "info: Set WAPI Key\n");
+                key_material->key_param_set.key_type_id =
+                        cpu_to_le16(KEY_TYPE_ID_WAPI);
+                if (cmd_oid == KEY_INFO_ENABLED)
+                        key_material->key_param_set.key_info =
+                                cpu_to_le16(KEY_ENABLED);
+                else
+                        key_material->key_param_set.key_info =
+                                cpu_to_le16(!KEY_ENABLED);
+                key_material->key_param_set.key[0] = enc_key->key_index;
+                if (!priv->sec_info.wapi_key_on)
+                        key_material->key_param_set.key[1] = 1;
+                else
+                        /* set 0 when re-key */
+                        key_material->key_param_set.key[1] = 0;
+                if (0 != memcmp(enc_key->mac_addr, bc_mac, sizeof(bc_mac))) {
+                        /* WAPI pairwise key: unicast */
+                        key_material->key_param_set.key_info |=
+                                cpu_to_le16(KEY_UNICAST);
+                } else {        /* WAPI group key: multicast */
+                        key_material->key_param_set.key_info |=
+                                cpu_to_le16(KEY_MCAST);
+                        priv->sec_info.wapi_key_on = true;
+                }
+                key_material->key_param_set.type =
+                        cpu_to_le16(TLV_TYPE_KEY_MATERIAL);
+                key_material->key_param_set.key_len =
+                        cpu_to_le16(WAPI_KEY_LEN);
+                memcpy(&key_material->key_param_set.key[2],
+                       enc_key->key_material, enc_key->key_len);
+                memcpy(&key_material->key_param_set.key[2 + enc_key->key_len],
+                       enc_key->wapi_rxpn, WAPI_RXPN_LEN);
+                key_material->key_param_set.length =
+                        cpu_to_le16(WAPI_KEY_LEN + KEYPARAMSET_FIXED_LEN);
+                key_param_len = (WAPI_KEY_LEN + KEYPARAMSET_FIXED_LEN) +
+                                 sizeof(struct mwifiex_ie_types_header);
+                cmd->size = cpu_to_le16(key_param_len +
+                                sizeof(key_material->action) + S_DS_GEN);
+                return ret;
+        }
+        if (enc_key->key_len == WLAN_KEY_LEN_CCMP) {
+                dev_dbg(priv->adapter->dev, "cmd: WPA_AES\n");
+                key_material->key_param_set.key_type_id =
+                        cpu_to_le16(KEY_TYPE_ID_AES);
+                if (cmd_oid == KEY_INFO_ENABLED)
+                        key_material->key_param_set.key_info =
+                                cpu_to_le16(KEY_ENABLED);
+                else
+                        key_material->key_param_set.key_info =
+                                cpu_to_le16(!KEY_ENABLED);
+                if (enc_key->key_index & MWIFIEX_KEY_INDEX_UNICAST)
+                                /* AES pairwise key: unicast */
+                        key_material->key_param_set.key_info |=
+                                cpu_to_le16(KEY_UNICAST);
+                else            /* AES group key: multicast */
+                        key_material->key_param_set.key_info |=
+                                cpu_to_le16(KEY_MCAST);
+        } else if (enc_key->key_len == WLAN_KEY_LEN_TKIP) {
+                dev_dbg(priv->adapter->dev, "cmd: WPA_TKIP\n");
+                key_material->key_param_set.key_type_id =
+                        cpu_to_le16(KEY_TYPE_ID_TKIP);
+                key_material->key_param_set.key_info =
+                        cpu_to_le16(KEY_ENABLED);
+                if (enc_key->key_index & MWIFIEX_KEY_INDEX_UNICAST)
+                                /* TKIP pairwise key: unicast */
+                        key_material->key_param_set.key_info |=
+                                cpu_to_le16(KEY_UNICAST);
+                else            /* TKIP group key: multicast */
+                        key_material->key_param_set.key_info |=
+                                cpu_to_le16(KEY_MCAST);
+        }
+        if (key_material->key_param_set.key_type_id) {
+                key_material->key_param_set.type =
+                        cpu_to_le16(TLV_TYPE_KEY_MATERIAL);
+                key_material->key_param_set.key_len =
+                        cpu_to_le16((u16) enc_key->key_len);
+                memcpy(key_material->key_param_set.key, enc_key->key_material,
+                       enc_key->key_len);
+                key_material->key_param_set.length =
+                        cpu_to_le16((u16) enc_key->key_len +
+                                    KEYPARAMSET_FIXED_LEN);
+                key_param_len = (u16) (enc_key->key_len + KEYPARAMSET_FIXED_LEN)
+                                      + sizeof(struct mwifiex_ie_types_header);
+                cmd->size = cpu_to_le16(key_param_len +
+                                    sizeof(key_material->action) + S_DS_GEN);
+        }
+        return ret;
+}
+/*
+ * This function prepares command to set/get 11d domain information.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting domain information fields (for SET only)
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_802_11d_domain_info(struct mwifiex_private *priv,
+                                           struct host_cmd_ds_command *cmd,
+                                           u16 cmd_action)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct host_cmd_ds_802_11d_domain_info *domain_info =
+                &cmd->params.domain_info;
+        struct mwifiex_ietypes_domain_param_set *domain =
+                &domain_info->domain;
+        u8 no_of_triplet = adapter->domain_reg.no_of_triplet;
+        dev_dbg(adapter->dev, "info: 11D: no_of_triplet=0x%x\n", no_of_triplet);
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11D_DOMAIN_INFO);
+        domain_info->action = cpu_to_le16(cmd_action);
+        if (cmd_action == HostCmd_ACT_GEN_GET) {
+                cmd->size = cpu_to_le16(sizeof(domain_info->action) + S_DS_GEN);
+                return 0;
+        }
+        /* Set domain info fields */
+        domain->header.type = cpu_to_le16(WLAN_EID_COUNTRY);
+        memcpy(domain->country_code, adapter->domain_reg.country_code,
+                        sizeof(domain->country_code));
+        domain->header.len = cpu_to_le16((no_of_triplet *
+                                sizeof(struct ieee80211_country_ie_triplet)) +
+                                sizeof(domain->country_code));
+        if (no_of_triplet) {
+                memcpy(domain->triplet, adapter->domain_reg.triplet,
+                                no_of_triplet *
+                                sizeof(struct ieee80211_country_ie_triplet));
+                cmd->size = cpu_to_le16(sizeof(domain_info->action) +
+                                le16_to_cpu(domain->header.len) +
+                                sizeof(struct mwifiex_ie_types_header)
+                                + S_DS_GEN);
+        } else {
+                cmd->size = cpu_to_le16(sizeof(domain_info->action) + S_DS_GEN);
+        }
+        return 0;
+}
+/*
+ * This function prepares command to set/get RF channel.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting RF type and current RF channel (for SET only)
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_802_11_rf_channel(struct mwifiex_private *priv,
+                                         struct host_cmd_ds_command *cmd,
+                                         u16 cmd_action, void *data_buf)
+{
+        struct host_cmd_ds_802_11_rf_channel *rf_chan =
+                &cmd->params.rf_channel;
+        uint16_t rf_type = le16_to_cpu(rf_chan->rf_type);
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_RF_CHANNEL);
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_802_11_rf_channel)
+                                + S_DS_GEN);
+        if (cmd_action == HostCmd_ACT_GEN_SET) {
+                if ((priv->adapter->adhoc_start_band & BAND_A)
+                    || (priv->adapter->adhoc_start_band & BAND_AN))
+                        rf_chan->rf_type =
+                                cpu_to_le16(HostCmd_SCAN_RADIO_TYPE_A);
+                rf_type = le16_to_cpu(rf_chan->rf_type);
+                SET_SECONDARYCHAN(rf_type, priv->adapter->chan_offset);
+                rf_chan->current_channel = cpu_to_le16(*((u16 *) data_buf));
+        }
+        rf_chan->action = cpu_to_le16(cmd_action);
+        return 0;
+}
+/*
+ * This function prepares command to set/get IBSS coalescing status.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting status to enable or disable (for SET only)
+ *      - Ensuring correct endian-ness
+ */
+static int mwifiex_cmd_ibss_coalescing_status(struct host_cmd_ds_command *cmd,
+                                              u16 cmd_action, void *data_buf)
+{
+        struct host_cmd_ds_802_11_ibss_status *ibss_coal =
+                &(cmd->params.ibss_coalescing);
+        u16 enable = 0;
+        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_IBSS_COALESCING_STATUS);
+        cmd->size = cpu_to_le16(sizeof(struct host_cmd_ds_802_11_ibss_status) +
+                                S_DS_GEN);
+        cmd->result = 0;
+        ibss_coal->action = cpu_to_le16(cmd_action);
+        switch (cmd_action) {
+        case HostCmd_ACT_GEN_SET:
+                if (data_buf != NULL)
+                        enable = *(u16 *) data_buf;
+                ibss_coal->enable = cpu_to_le16(enable);
+                break;
+                /* In other case.. Nothing to do */
+        case HostCmd_ACT_GEN_GET:
+        default:
+                break;
+        }
+        return 0;
+}
+/*
+ * This function prepares command to set/get register value.
+ *
+ * Preparation includes -
+ *      - Setting command ID, action and proper size
+ *      - Setting register offset (for both GET and SET) and
+ *        register value (for SET only)
+ *      - Ensuring correct endian-ness
+ *
+ * The following type of registers can be accessed with this function -
+ *      - MAC register
+ *      - BBP register
+ *      - RF register
+ *      - PMIC register
+ *      - CAU register
+ *      - EEPROM
+ */
+static int mwifiex_cmd_reg_access(struct host_cmd_ds_command *cmd,
+                                  u16 cmd_action, void *data_buf)
+{
+        struct mwifiex_ds_reg_rw *reg_rw;
+        reg_rw = (struct mwifiex_ds_reg_rw *) data_buf;
+        switch (le16_to_cpu(cmd->command)) {
+        case HostCmd_CMD_MAC_REG_ACCESS:
+        {
+                struct host_cmd_ds_mac_reg_access *mac_reg;
+                cmd->size = cpu_to_le16(sizeof(*mac_reg) + S_DS_GEN);
+                mac_reg = (struct host_cmd_ds_mac_reg_access *) &cmd->
+                        params.mac_reg;
+                mac_reg->action = cpu_to_le16(cmd_action);
+                mac_reg->offset =
+                        cpu_to_le16((u16) le32_to_cpu(reg_rw->offset));
+                mac_reg->value = reg_rw->value;
+                break;
+        }
+        case HostCmd_CMD_BBP_REG_ACCESS:
+        {
+                struct host_cmd_ds_bbp_reg_access *bbp_reg;
+                cmd->size = cpu_to_le16(sizeof(*bbp_reg) + S_DS_GEN);
+                bbp_reg = (struct host_cmd_ds_bbp_reg_access *) &cmd->
+                        params.bbp_reg;
+                bbp_reg->action = cpu_to_le16(cmd_action);
+                bbp_reg->offset =
+                        cpu_to_le16((u16) le32_to_cpu(reg_rw->offset));
+                bbp_reg->value = (u8) le32_to_cpu(reg_rw->value);
+                break;
+        }
+        case HostCmd_CMD_RF_REG_ACCESS:
+        {
+                struct host_cmd_ds_rf_reg_access *rf_reg;
+                cmd->size = cpu_to_le16(sizeof(*rf_reg) + S_DS_GEN);
+                rf_reg = (struct host_cmd_ds_rf_reg_access *) &cmd->
+                        params.rf_reg;
+                rf_reg->action = cpu_to_le16(cmd_action);
+                rf_reg->offset =
+                        cpu_to_le16((u16) le32_to_cpu(reg_rw->offset));
+                rf_reg->value = (u8) le32_to_cpu(reg_rw->value);
+                break;
+        }
+        case HostCmd_CMD_PMIC_REG_ACCESS:
+        {
+                struct host_cmd_ds_pmic_reg_access *pmic_reg;
+                cmd->size = cpu_to_le16(sizeof(*pmic_reg) + S_DS_GEN);
+                pmic_reg = (struct host_cmd_ds_pmic_reg_access *) &cmd->
+                                params.pmic_reg;
+                pmic_reg->action = cpu_to_le16(cmd_action);
+                pmic_reg->offset =
+                        cpu_to_le16((u16) le32_to_cpu(reg_rw->offset));
+                pmic_reg->value = (u8) le32_to_cpu(reg_rw->value);
+                break;
+        }
+        case HostCmd_CMD_CAU_REG_ACCESS:
+        {
+                struct host_cmd_ds_rf_reg_access *cau_reg;
+                cmd->size = cpu_to_le16(sizeof(*cau_reg) + S_DS_GEN);
+                cau_reg = (struct host_cmd_ds_rf_reg_access *) &cmd->
+                                params.rf_reg;
+                cau_reg->action = cpu_to_le16(cmd_action);
+                cau_reg->offset =
+                        cpu_to_le16((u16) le32_to_cpu(reg_rw->offset));
+                cau_reg->value = (u8) le32_to_cpu(reg_rw->value);
+                break;
+        }
+        case HostCmd_CMD_802_11_EEPROM_ACCESS:
+        {
+                struct mwifiex_ds_read_eeprom *rd_eeprom =
+                        (struct mwifiex_ds_read_eeprom *) data_buf;
+                struct host_cmd_ds_802_11_eeprom_access *cmd_eeprom =
+                        (struct host_cmd_ds_802_11_eeprom_access *)
+                        &cmd->params.eeprom;
+                cmd->size = cpu_to_le16(sizeof(*cmd_eeprom) + S_DS_GEN);
+                cmd_eeprom->action = cpu_to_le16(cmd_action);
+                cmd_eeprom->offset = rd_eeprom->offset;
+                cmd_eeprom->byte_count = rd_eeprom->byte_count;
+                cmd_eeprom->value = 0;
+                break;
+        }
+        default:
+                return -1;
+        }
+        return 0;
+}
+/*
+ * This function prepares the commands before sending them to the firmware.
+ *
+ * This is a generic function which calls specific command preparation
+ * routines based upon the command number.
+ */
+int mwifiex_sta_prepare_cmd(struct mwifiex_private *priv, uint16_t cmd_no,
+                            u16 cmd_action, u32 cmd_oid,
+                            void *data_buf, void *cmd_buf)
+{
+        struct host_cmd_ds_command *cmd_ptr =
+                (struct host_cmd_ds_command *) cmd_buf;
+        int ret = 0;
+        /* Prepare command */
+        switch (cmd_no) {
+        case HostCmd_CMD_GET_HW_SPEC:
+                ret = mwifiex_cmd_get_hw_spec(priv, cmd_ptr);
+                break;
+        case HostCmd_CMD_MAC_CONTROL:
+                ret = mwifiex_cmd_mac_control(priv, cmd_ptr, cmd_action,
+                                              data_buf);
+                break;
+        case HostCmd_CMD_802_11_MAC_ADDRESS:
+                ret = mwifiex_cmd_802_11_mac_address(priv, cmd_ptr,
+                                                     cmd_action);
+                break;
+        case HostCmd_CMD_MAC_MULTICAST_ADR:
+                ret = mwifiex_cmd_mac_multicast_adr(cmd_ptr, cmd_action,
+                                                    data_buf);
+                break;
+        case HostCmd_CMD_TX_RATE_CFG:
+                ret = mwifiex_cmd_tx_rate_cfg(priv, cmd_ptr, cmd_action,
+                                              data_buf);
+                break;
+        case HostCmd_CMD_TXPWR_CFG:
+                ret = mwifiex_cmd_tx_power_cfg(cmd_ptr, cmd_action,
+                                               data_buf);
+                break;
+        case HostCmd_CMD_802_11_PS_MODE_ENH:
+                ret = mwifiex_cmd_enh_power_mode(priv, cmd_ptr, cmd_action,
+                                                 (uint16_t)cmd_oid, data_buf);
+                break;
+        case HostCmd_CMD_802_11_HS_CFG_ENH:
+                ret = mwifiex_cmd_802_11_hs_cfg(priv, cmd_ptr, cmd_action,
+                                (struct mwifiex_hs_config_param *) data_buf);
+                break;
+        case HostCmd_CMD_802_11_SCAN:
+                ret = mwifiex_cmd_802_11_scan(cmd_ptr, data_buf);
+                break;
+        case HostCmd_CMD_802_11_BG_SCAN_QUERY:
+                ret = mwifiex_cmd_802_11_bg_scan_query(cmd_ptr);
+                break;
+        case HostCmd_CMD_802_11_ASSOCIATE:
+                ret = mwifiex_cmd_802_11_associate(priv, cmd_ptr, data_buf);
+                break;
+        case HostCmd_CMD_802_11_DEAUTHENTICATE:
+                ret = mwifiex_cmd_802_11_deauthenticate(priv, cmd_ptr,
+                                                        data_buf);
+                break;
+        case HostCmd_CMD_802_11_AD_HOC_START:
+                ret = mwifiex_cmd_802_11_ad_hoc_start(priv, cmd_ptr,
+                                                      data_buf);
+                break;
+        case HostCmd_CMD_802_11_GET_LOG:
+                ret = mwifiex_cmd_802_11_get_log(cmd_ptr);
+                break;
+        case HostCmd_CMD_802_11_AD_HOC_JOIN:
+                ret = mwifiex_cmd_802_11_ad_hoc_join(priv, cmd_ptr,
+                                                     data_buf);
+                break;
+        case HostCmd_CMD_802_11_AD_HOC_STOP:
+                ret = mwifiex_cmd_802_11_ad_hoc_stop(cmd_ptr);
+                break;
+        case HostCmd_CMD_RSSI_INFO:
+                ret = mwifiex_cmd_802_11_rssi_info(priv, cmd_ptr, cmd_action);
+                break;
+        case HostCmd_CMD_802_11_SNMP_MIB:
+                ret = mwifiex_cmd_802_11_snmp_mib(priv, cmd_ptr, cmd_action,
+                                                  cmd_oid, data_buf);
+                break;
+        case HostCmd_CMD_802_11_TX_RATE_QUERY:
+                cmd_ptr->command =
+                        cpu_to_le16(HostCmd_CMD_802_11_TX_RATE_QUERY);
+                cmd_ptr->size =
+                        cpu_to_le16(sizeof(struct host_cmd_ds_tx_rate_query) +
+                                    S_DS_GEN);
+                priv->tx_rate = 0;
+                ret = 0;
+                break;
+        case HostCmd_CMD_VERSION_EXT:
+                cmd_ptr->command = cpu_to_le16(cmd_no);
+                cmd_ptr->params.verext.version_str_sel =
+                        (u8) (*((u32 *) data_buf));
+                memcpy(&cmd_ptr->params, data_buf,
+                       sizeof(struct host_cmd_ds_version_ext));
+                cmd_ptr->size =
+                        cpu_to_le16(sizeof(struct host_cmd_ds_version_ext) +
+                                    S_DS_GEN);
+                ret = 0;
+                break;
+        case HostCmd_CMD_802_11_RF_CHANNEL:
+                ret = mwifiex_cmd_802_11_rf_channel(priv, cmd_ptr, cmd_action,
+                                                    data_buf);
+                break;
+        case HostCmd_CMD_FUNC_INIT:
+                if (priv->adapter->hw_status == MWIFIEX_HW_STATUS_RESET)
+                        priv->adapter->hw_status = MWIFIEX_HW_STATUS_READY;
+                cmd_ptr->command = cpu_to_le16(cmd_no);
+                cmd_ptr->size = cpu_to_le16(S_DS_GEN);
+                break;
+        case HostCmd_CMD_FUNC_SHUTDOWN:
+                priv->adapter->hw_status = MWIFIEX_HW_STATUS_RESET;
+                cmd_ptr->command = cpu_to_le16(cmd_no);
+                cmd_ptr->size = cpu_to_le16(S_DS_GEN);
+                break;
+        case HostCmd_CMD_11N_ADDBA_REQ:
+                ret = mwifiex_cmd_11n_addba_req(cmd_ptr, data_buf);
+                break;
+        case HostCmd_CMD_11N_DELBA:
+                ret = mwifiex_cmd_11n_delba(cmd_ptr, data_buf);
+                break;
+        case HostCmd_CMD_11N_ADDBA_RSP:
+                ret = mwifiex_cmd_11n_addba_rsp_gen(priv, cmd_ptr, data_buf);
+                break;
+        case HostCmd_CMD_802_11_KEY_MATERIAL:
+                ret = mwifiex_cmd_802_11_key_material(priv, cmd_ptr,
+                                                cmd_action, cmd_oid,
+                                                data_buf);
+                break;
+        case HostCmd_CMD_802_11D_DOMAIN_INFO:
+                ret = mwifiex_cmd_802_11d_domain_info(priv, cmd_ptr,
+                                                cmd_action);
+                break;
+        case HostCmd_CMD_RECONFIGURE_TX_BUFF:
+                ret = mwifiex_cmd_recfg_tx_buf(priv, cmd_ptr, cmd_action,
+                                               data_buf);
+                break;
+        case HostCmd_CMD_AMSDU_AGGR_CTRL:
+                ret = mwifiex_cmd_amsdu_aggr_ctrl(cmd_ptr, cmd_action,
+                                                  data_buf);
+                break;
+        case HostCmd_CMD_11N_CFG:
+                ret = mwifiex_cmd_11n_cfg(cmd_ptr, cmd_action,
+                                          data_buf);
+                break;
+        case HostCmd_CMD_WMM_GET_STATUS:
+                dev_dbg(priv->adapter->dev,
+                        "cmd: WMM: WMM_GET_STATUS cmd sent\n");
+                cmd_ptr->command = cpu_to_le16(HostCmd_CMD_WMM_GET_STATUS);
+                cmd_ptr->size =
+                        cpu_to_le16(sizeof(struct host_cmd_ds_wmm_get_status) +
+                                    S_DS_GEN);
+                ret = 0;
+                break;
+        case HostCmd_CMD_802_11_IBSS_COALESCING_STATUS:
+                ret = mwifiex_cmd_ibss_coalescing_status(cmd_ptr, cmd_action,
+                                                         data_buf);
+                break;
+        case HostCmd_CMD_MAC_REG_ACCESS:
+        case HostCmd_CMD_BBP_REG_ACCESS:
+        case HostCmd_CMD_RF_REG_ACCESS:
+        case HostCmd_CMD_PMIC_REG_ACCESS:
+        case HostCmd_CMD_CAU_REG_ACCESS:
+        case HostCmd_CMD_802_11_EEPROM_ACCESS:
+                ret = mwifiex_cmd_reg_access(cmd_ptr, cmd_action, data_buf);
+                break;
+        case HostCmd_CMD_SET_BSS_MODE:
+                cmd_ptr->command = cpu_to_le16(cmd_no);
+                if (priv->bss_mode == NL80211_IFTYPE_ADHOC)
+                        cmd_ptr->params.bss_mode.con_type =
+                                CONNECTION_TYPE_ADHOC;
+                else if (priv->bss_mode == NL80211_IFTYPE_STATION)
+                        cmd_ptr->params.bss_mode.con_type =
+                                CONNECTION_TYPE_INFRA;
+                cmd_ptr->size = cpu_to_le16(sizeof(struct
+                                host_cmd_ds_set_bss_mode) + S_DS_GEN);
+                ret = 0;
+                break;
+        default:
+                dev_err(priv->adapter->dev,
+                        "PREP_CMD: unknown cmd- %#x\n", cmd_no);
+                ret = -1;
+                break;
+        }
+        return ret;
+}
+/*
+ * This function issues commands to initialize firmware.
+ *
+ * This is called after firmware download to bring the card to
+ * working state.
+ *
+ * The following commands are issued sequentially -
+ *      - Function init (for first interface only)
+ *      - Read MAC address (for first interface only)
+ *      - Reconfigure Tx buffer size (for first interface only)
+ *      - Enable auto deep sleep (for first interface only)
+ *      - Get Tx rate
+ *      - Get Tx power
+ *      - Set IBSS coalescing status
+ *      - Set AMSDU aggregation control
+ *      - Set 11d control
+ *      - Set MAC control (this must be the last command to initialize firmware)
+ */
+int mwifiex_sta_init_cmd(struct mwifiex_private *priv, u8 first_sta)
+{
+        int ret;
+        u16 enable = true;
+        struct mwifiex_ds_11n_amsdu_aggr_ctrl amsdu_aggr_ctrl;
+        struct mwifiex_ds_auto_ds auto_ds;
+        enum state_11d_t state_11d;
+        if (first_sta) {
+                ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_FUNC_INIT,
+                                             HostCmd_ACT_GEN_SET, 0, NULL);
+                if (ret)
+                        return -1;
+                /* Read MAC address from HW */
+                ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_GET_HW_SPEC,
+                                             HostCmd_ACT_GEN_GET, 0, NULL);
+                if (ret)
+                        return -1;
+                /* Reconfigure tx buf size */
+                ret = mwifiex_send_cmd_async(priv,
+                                             HostCmd_CMD_RECONFIGURE_TX_BUFF,
+                                             HostCmd_ACT_GEN_SET, 0,
+                                             &priv->adapter->tx_buf_size);
+                if (ret)
+                        return -1;
+                /* Enable IEEE PS by default */
+                priv->adapter->ps_mode = MWIFIEX_802_11_POWER_MODE_PSP;
+                ret = mwifiex_send_cmd_async(priv,
+                                             HostCmd_CMD_802_11_PS_MODE_ENH,
+                                             EN_AUTO_PS, BITMAP_STA_PS, NULL);
+                if (ret)
+                        return -1;
+        }
+        /* get tx rate */
+        ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_TX_RATE_CFG,
+                                     HostCmd_ACT_GEN_GET, 0, NULL);
+        if (ret)
+                return -1;
+        priv->data_rate = 0;
+        /* get tx power */
+        ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_TXPWR_CFG,
+                                     HostCmd_ACT_GEN_GET, 0, NULL);
+        if (ret)
+                return -1;
+        /* set ibss coalescing_status */
+        ret = mwifiex_send_cmd_async(priv,
+                                     HostCmd_CMD_802_11_IBSS_COALESCING_STATUS,
+                                     HostCmd_ACT_GEN_SET, 0, &enable);
+        if (ret)
+                return -1;
+        memset(&amsdu_aggr_ctrl, 0, sizeof(amsdu_aggr_ctrl));
+        amsdu_aggr_ctrl.enable = true;
+        /* Send request to firmware */
+        ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_AMSDU_AGGR_CTRL,
+                                     HostCmd_ACT_GEN_SET, 0,
+                                     (void *) &amsdu_aggr_ctrl);
+        if (ret)
+                return -1;
+        /* MAC Control must be the last command in init_fw */
+        /* set MAC Control */
+        ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_MAC_CONTROL,
+                                     HostCmd_ACT_GEN_SET, 0,
+                                     &priv->curr_pkt_filter);
+        if (ret)
+                return -1;
+        if (first_sta) {
+                /* Enable auto deep sleep */
+                auto_ds.auto_ds = DEEP_SLEEP_ON;
+                auto_ds.idle_time = DEEP_SLEEP_IDLE_TIME;
+                ret = mwifiex_send_cmd_async(priv,
+                                             HostCmd_CMD_802_11_PS_MODE_ENH,
+                                             EN_AUTO_PS, BITMAP_AUTO_DS,
+                                             &auto_ds);
+                if (ret)
+                        return -1;
+        }
+        /* Send cmd to FW to enable/disable 11D function */
+        state_11d = ENABLE_11D;
+        ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_802_11_SNMP_MIB,
+                                     HostCmd_ACT_GEN_SET, DOT11D_I, &state_11d);
+        if (ret)
+                dev_err(priv->adapter->dev, "11D: failed to enable 11D\n");
+        /* set last_init_cmd */
+        priv->adapter->last_init_cmd = HostCmd_CMD_802_11_SNMP_MIB;
+        ret = -EINPROGRESS;
+        return ret;
+}
diff --git a/drivers/net/wireless/mwifiex/sta_cmdresp.c b/drivers/net/wireless/mwifiex/sta_cmdresp.c
new file mode 100644
index 000000000000..d08f76429a0a
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/sta_cmdresp.c
@@ -0,0 +1,972 @@
+/*
+ * Marvell Wireless LAN device driver: station command response handling
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+/*
+ * This function handles the command response error case.
+ *
+ * For scan response error, the function cancels all the pending
+ * scan commands and generates an event to inform the applications
+ * of the scan completion.
+ *
+ * For Power Save command failure, we do not retry enter PS
+ * command in case of Ad-hoc mode.
+ *
+ * For all other response errors, the current command buffer is freed
+ * and returned to the free command queue.
+ */
+static void
+mwifiex_process_cmdresp_error(struct mwifiex_private *priv,
+                              struct host_cmd_ds_command *resp)
+{
+        struct cmd_ctrl_node *cmd_node = NULL, *tmp_node;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct host_cmd_ds_802_11_ps_mode_enh *pm;
+        unsigned long flags;
+        dev_err(adapter->dev, "CMD_RESP: cmd %#x error, result=%#x\n",
+                        resp->command, resp->result);
+        if (adapter->curr_cmd->wait_q_enabled)
+                adapter->cmd_wait_q.status = -1;
+        switch (le16_to_cpu(resp->command)) {
+        case HostCmd_CMD_802_11_PS_MODE_ENH:
+                pm = &resp->params.psmode_enh;
+                dev_err(adapter->dev, "PS_MODE_ENH cmd failed: "
+                                        "result=0x%x action=0x%X\n",
+                                resp->result, le16_to_cpu(pm->action));
+                /* We do not re-try enter-ps command in ad-hoc mode. */
+                if (le16_to_cpu(pm->action) == EN_AUTO_PS &&
+                        (le16_to_cpu(pm->params.ps_bitmap) & BITMAP_STA_PS) &&
+                                priv->bss_mode == NL80211_IFTYPE_ADHOC)
+                        adapter->ps_mode = MWIFIEX_802_11_POWER_MODE_CAM;
+                break;
+        case HostCmd_CMD_802_11_SCAN:
+                /* Cancel all pending scan command */
+                spin_lock_irqsave(&adapter->scan_pending_q_lock, flags);
+                list_for_each_entry_safe(cmd_node, tmp_node,
+                                         &adapter->scan_pending_q, list) {
+                        list_del(&cmd_node->list);
+                        spin_unlock_irqrestore(&adapter->scan_pending_q_lock,
+                                               flags);
+                        mwifiex_insert_cmd_to_free_q(adapter, cmd_node);
+                        spin_lock_irqsave(&adapter->scan_pending_q_lock, flags);
+                }
+                spin_unlock_irqrestore(&adapter->scan_pending_q_lock, flags);
+                spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+                adapter->scan_processing = false;
+                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+                if (priv->report_scan_result)
+                        priv->report_scan_result = false;
+                if (priv->scan_pending_on_block) {
+                        priv->scan_pending_on_block = false;
+                        up(&priv->async_sem);
+                }
+                break;
+        case HostCmd_CMD_MAC_CONTROL:
+                break;
+        default:
+                break;
+        }
+        /* Handling errors here */
+        mwifiex_insert_cmd_to_free_q(adapter, adapter->curr_cmd);
+        spin_lock_irqsave(&adapter->mwifiex_cmd_lock, flags);
+        adapter->curr_cmd = NULL;
+        spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
+}
+/*
+ * This function handles the command response of get RSSI info.
+ *
+ * Handling includes changing the header fields into CPU format
+ * and saving the following parameters in driver -
+ *      - Last data and beacon RSSI value
+ *      - Average data and beacon RSSI value
+ *      - Last data and beacon NF value
+ *      - Average data and beacon NF value
+ *
+ * The parameters are send to the application as well, along with
+ * calculated SNR values.
+ */
+static int mwifiex_ret_802_11_rssi_info(struct mwifiex_private *priv,
+                                        struct host_cmd_ds_command *resp,
+                                        void *data_buf)
+{
+        struct host_cmd_ds_802_11_rssi_info_rsp *rssi_info_rsp =
+                &resp->params.rssi_info_rsp;
+        struct mwifiex_ds_get_signal *signal;
+        priv->data_rssi_last = le16_to_cpu(rssi_info_rsp->data_rssi_last);
+        priv->data_nf_last = le16_to_cpu(rssi_info_rsp->data_nf_last);
+        priv->data_rssi_avg = le16_to_cpu(rssi_info_rsp->data_rssi_avg);
+        priv->data_nf_avg = le16_to_cpu(rssi_info_rsp->data_nf_avg);
+        priv->bcn_rssi_last = le16_to_cpu(rssi_info_rsp->bcn_rssi_last);
+        priv->bcn_nf_last = le16_to_cpu(rssi_info_rsp->bcn_nf_last);
+        priv->bcn_rssi_avg = le16_to_cpu(rssi_info_rsp->bcn_rssi_avg);
+        priv->bcn_nf_avg = le16_to_cpu(rssi_info_rsp->bcn_nf_avg);
+        /* Need to indicate IOCTL complete */
+        if (data_buf) {
+                signal = (struct mwifiex_ds_get_signal *) data_buf;
+                memset(signal, 0, sizeof(struct mwifiex_ds_get_signal));
+                signal->selector = ALL_RSSI_INFO_MASK;
+                /* RSSI */
+                signal->bcn_rssi_last = priv->bcn_rssi_last;
+                signal->bcn_rssi_avg = priv->bcn_rssi_avg;
+                signal->data_rssi_last = priv->data_rssi_last;
+                signal->data_rssi_avg = priv->data_rssi_avg;
+                /* SNR */
+                signal->bcn_snr_last =
+                        CAL_SNR(priv->bcn_rssi_last, priv->bcn_nf_last);
+                signal->bcn_snr_avg =
+                        CAL_SNR(priv->bcn_rssi_avg, priv->bcn_nf_avg);
+                signal->data_snr_last =
+                        CAL_SNR(priv->data_rssi_last, priv->data_nf_last);
+                signal->data_snr_avg =
+                        CAL_SNR(priv->data_rssi_avg, priv->data_nf_avg);
+                /* NF */
+                signal->bcn_nf_last = priv->bcn_nf_last;
+                signal->bcn_nf_avg = priv->bcn_nf_avg;
+                signal->data_nf_last = priv->data_nf_last;
+                signal->data_nf_avg = priv->data_nf_avg;
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of set/get SNMP
+ * MIB parameters.
+ *
+ * Handling includes changing the header fields into CPU format
+ * and saving the parameter in driver.
+ *
+ * The following parameters are supported -
+ *      - Fragmentation threshold
+ *      - RTS threshold
+ *      - Short retry limit
+ */
+static int mwifiex_ret_802_11_snmp_mib(struct mwifiex_private *priv,
+                                       struct host_cmd_ds_command *resp,
+                                       void *data_buf)
+{
+        struct host_cmd_ds_802_11_snmp_mib *smib = &resp->params.smib;
+        u16 oid = le16_to_cpu(smib->oid);
+        u16 query_type = le16_to_cpu(smib->query_type);
+        u32 ul_temp;
+        dev_dbg(priv->adapter->dev, "info: SNMP_RESP: oid value = %#x,"
+                        " query_type = %#x, buf size = %#x\n",
+                        oid, query_type, le16_to_cpu(smib->buf_size));
+        if (query_type == HostCmd_ACT_GEN_GET) {
+                ul_temp = le16_to_cpu(*((__le16 *) (smib->value)));
+                if (data_buf)
+                        *(u32 *)data_buf = ul_temp;
+                switch (oid) {
+                case FRAG_THRESH_I:
+                        dev_dbg(priv->adapter->dev,
+                                "info: SNMP_RESP: FragThsd =%u\n", ul_temp);
+                        break;
+                case RTS_THRESH_I:
+                        dev_dbg(priv->adapter->dev,
+                                "info: SNMP_RESP: RTSThsd =%u\n", ul_temp);
+                        break;
+                case SHORT_RETRY_LIM_I:
+                        dev_dbg(priv->adapter->dev,
+                                "info: SNMP_RESP: TxRetryCount=%u\n", ul_temp);
+                        break;
+                default:
+                        break;
+                }
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of get log request
+ *
+ * Handling includes changing the header fields into CPU format
+ * and sending the received parameters to application.
+ */
+static int mwifiex_ret_get_log(struct mwifiex_private *priv,
+                               struct host_cmd_ds_command *resp,
+                               void *data_buf)
+{
+        struct host_cmd_ds_802_11_get_log *get_log =
+                (struct host_cmd_ds_802_11_get_log *) &resp->params.get_log;
+        struct mwifiex_ds_get_stats *stats;
+        if (data_buf) {
+                stats = (struct mwifiex_ds_get_stats *) data_buf;
+                stats->mcast_tx_frame = le32_to_cpu(get_log->mcast_tx_frame);
+                stats->failed = le32_to_cpu(get_log->failed);
+                stats->retry = le32_to_cpu(get_log->retry);
+                stats->multi_retry = le32_to_cpu(get_log->multi_retry);
+                stats->frame_dup = le32_to_cpu(get_log->frame_dup);
+                stats->rts_success = le32_to_cpu(get_log->rts_success);
+                stats->rts_failure = le32_to_cpu(get_log->rts_failure);
+                stats->ack_failure = le32_to_cpu(get_log->ack_failure);
+                stats->rx_frag = le32_to_cpu(get_log->rx_frag);
+                stats->mcast_rx_frame = le32_to_cpu(get_log->mcast_rx_frame);
+                stats->fcs_error = le32_to_cpu(get_log->fcs_error);
+                stats->tx_frame = le32_to_cpu(get_log->tx_frame);
+                stats->wep_icv_error[0] =
+                        le32_to_cpu(get_log->wep_icv_err_cnt[0]);
+                stats->wep_icv_error[1] =
+                        le32_to_cpu(get_log->wep_icv_err_cnt[1]);
+                stats->wep_icv_error[2] =
+                        le32_to_cpu(get_log->wep_icv_err_cnt[2]);
+                stats->wep_icv_error[3] =
+                        le32_to_cpu(get_log->wep_icv_err_cnt[3]);
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of set/get Tx rate
+ * configurations.
+ *
+ * Handling includes changing the header fields into CPU format
+ * and saving the following parameters in driver -
+ *      - DSSS rate bitmap
+ *      - OFDM rate bitmap
+ *      - HT MCS rate bitmaps
+ *
+ * Based on the new rate bitmaps, the function re-evaluates if
+ * auto data rate has been activated. If not, it sends another
+ * query to the firmware to get the current Tx data rate and updates
+ * the driver value.
+ */
+static int mwifiex_ret_tx_rate_cfg(struct mwifiex_private *priv,
+                                   struct host_cmd_ds_command *resp,
+                                   void *data_buf)
+{
+        struct mwifiex_rate_cfg *ds_rate;
+        struct host_cmd_ds_tx_rate_cfg *rate_cfg = &resp->params.tx_rate_cfg;
+        struct mwifiex_rate_scope *rate_scope;
+        struct mwifiex_ie_types_header *head;
+        u16 tlv, tlv_buf_len;
+        u8 *tlv_buf;
+        u32 i;
+        int ret = 0;
+        tlv_buf = (u8 *) ((u8 *) rate_cfg) +
+                        sizeof(struct host_cmd_ds_tx_rate_cfg);
+        tlv_buf_len = *(u16 *) (tlv_buf + sizeof(u16));
+        while (tlv_buf && tlv_buf_len > 0) {
+                tlv = (*tlv_buf);
+                tlv = tlv | (*(tlv_buf + 1) << 8);
+                switch (tlv) {
+                case TLV_TYPE_RATE_SCOPE:
+                        rate_scope = (struct mwifiex_rate_scope *) tlv_buf;
+                        priv->bitmap_rates[0] =
+                                le16_to_cpu(rate_scope->hr_dsss_rate_bitmap);
+                        priv->bitmap_rates[1] =
+                                le16_to_cpu(rate_scope->ofdm_rate_bitmap);
+                        for (i = 0;
+                             i <
+                             sizeof(rate_scope->ht_mcs_rate_bitmap) /
+                             sizeof(u16); i++)
+                                priv->bitmap_rates[2 + i] =
+                                        le16_to_cpu(rate_scope->
+                                                    ht_mcs_rate_bitmap[i]);
+                        break;
+                        /* Add RATE_DROP tlv here */
+                }
+                head = (struct mwifiex_ie_types_header *) tlv_buf;
+                tlv_buf += le16_to_cpu(head->len) + sizeof(*head);
+                tlv_buf_len -= le16_to_cpu(head->len);
+        }
+        priv->is_data_rate_auto = mwifiex_is_rate_auto(priv);
+        if (priv->is_data_rate_auto)
+                priv->data_rate = 0;
+        else
+                ret = mwifiex_send_cmd_async(priv,
+                                          HostCmd_CMD_802_11_TX_RATE_QUERY,
+                                          HostCmd_ACT_GEN_GET, 0, NULL);
+        if (data_buf) {
+                ds_rate = (struct mwifiex_rate_cfg *) data_buf;
+                if (le16_to_cpu(rate_cfg->action) == HostCmd_ACT_GEN_GET) {
+                        if (priv->is_data_rate_auto) {
+                                ds_rate->is_rate_auto = 1;
+                        } else {
+                                ds_rate->rate = mwifiex_get_rate_index(priv->
+                                                               bitmap_rates,
+                                                               sizeof(priv->
+                                                               bitmap_rates));
+                                if (ds_rate->rate >=
+                                    MWIFIEX_RATE_BITMAP_OFDM0
+                                    && ds_rate->rate <=
+                                    MWIFIEX_RATE_BITMAP_OFDM7)
+                                        ds_rate->rate -=
+                                                (MWIFIEX_RATE_BITMAP_OFDM0 -
+                                                 MWIFIEX_RATE_INDEX_OFDM0);
+                                if (ds_rate->rate >=
+                                    MWIFIEX_RATE_BITMAP_MCS0
+                                    && ds_rate->rate <=
+                                    MWIFIEX_RATE_BITMAP_MCS127)
+                                        ds_rate->rate -=
+                                                (MWIFIEX_RATE_BITMAP_MCS0 -
+                                                 MWIFIEX_RATE_INDEX_MCS0);
+                        }
+                }
+        }
+        return ret;
+}
+/*
+ * This function handles the command response of get Tx power level.
+ *
+ * Handling includes saving the maximum and minimum Tx power levels
+ * in driver, as well as sending the values to user.
+ */
+static int mwifiex_get_power_level(struct mwifiex_private *priv, void *data_buf)
+{
+        int length, max_power = -1, min_power = -1;
+        struct mwifiex_types_power_group *pg_tlv_hdr;
+        struct mwifiex_power_group *pg;
+        if (data_buf) {
+                pg_tlv_hdr =
+                        (struct mwifiex_types_power_group *) ((u8 *) data_buf
+                                        + sizeof(struct host_cmd_ds_txpwr_cfg));
+                pg = (struct mwifiex_power_group *) ((u8 *) pg_tlv_hdr +
+                                sizeof(struct mwifiex_types_power_group));
+                length = pg_tlv_hdr->length;
+                if (length > 0) {
+                        max_power = pg->power_max;
+                        min_power = pg->power_min;
+                        length -= sizeof(struct mwifiex_power_group);
+                }
+                while (length) {
+                        pg++;
+                        if (max_power < pg->power_max)
+                                max_power = pg->power_max;
+                        if (min_power > pg->power_min)
+                                min_power = pg->power_min;
+                        length -= sizeof(struct mwifiex_power_group);
+                }
+                if (pg_tlv_hdr->length > 0) {
+                        priv->min_tx_power_level = (u8) min_power;
+                        priv->max_tx_power_level = (u8) max_power;
+                }
+        } else {
+                return -1;
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of set/get Tx power
+ * configurations.
+ *
+ * Handling includes changing the header fields into CPU format
+ * and saving the current Tx power level in driver.
+ */
+static int mwifiex_ret_tx_power_cfg(struct mwifiex_private *priv,
+                                    struct host_cmd_ds_command *resp,
+                                    void *data_buf)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct host_cmd_ds_txpwr_cfg *txp_cfg = &resp->params.txp_cfg;
+        struct mwifiex_types_power_group *pg_tlv_hdr;
+        struct mwifiex_power_group *pg;
+        u16 action = le16_to_cpu(txp_cfg->action);
+        switch (action) {
+        case HostCmd_ACT_GEN_GET:
+                {
+                        pg_tlv_hdr =
+                                (struct mwifiex_types_power_group *) ((u8 *)
+                                                txp_cfg +
+                                                sizeof
+                                                (struct
+                                                 host_cmd_ds_txpwr_cfg));
+                        pg = (struct mwifiex_power_group *) ((u8 *)
+                                                pg_tlv_hdr +
+                                                sizeof(struct
+                                                mwifiex_types_power_group));
+                        if (adapter->hw_status ==
+                            MWIFIEX_HW_STATUS_INITIALIZING)
+                                mwifiex_get_power_level(priv, txp_cfg);
+                        priv->tx_power_level = (u16) pg->power_min;
+                        break;
+                }
+        case HostCmd_ACT_GEN_SET:
+                if (le32_to_cpu(txp_cfg->mode)) {
+                        pg_tlv_hdr =
+                                (struct mwifiex_types_power_group *) ((u8 *)
+                                                txp_cfg +
+                                                sizeof
+                                                (struct
+                                                 host_cmd_ds_txpwr_cfg));
+                        pg = (struct mwifiex_power_group *) ((u8 *) pg_tlv_hdr
+                                                +
+                                                sizeof(struct
+                                                mwifiex_types_power_group));
+                        if (pg->power_max == pg->power_min)
+                                priv->tx_power_level = (u16) pg->power_min;
+                }
+                break;
+        default:
+                dev_err(adapter->dev, "CMD_RESP: unknown cmd action %d\n",
+                                action);
+                return 0;
+        }
+        dev_dbg(adapter->dev,
+                "info: Current TxPower Level = %d, Max Power=%d, Min Power=%d\n",
+               priv->tx_power_level, priv->max_tx_power_level,
+               priv->min_tx_power_level);
+        return 0;
+}
+/*
+ * This function handles the command response of set/get MAC address.
+ *
+ * Handling includes saving the MAC address in driver.
+ */
+static int mwifiex_ret_802_11_mac_address(struct mwifiex_private *priv,
+                                          struct host_cmd_ds_command *resp)
+{
+        struct host_cmd_ds_802_11_mac_address *cmd_mac_addr =
+                &resp->params.mac_addr;
+        memcpy(priv->curr_addr, cmd_mac_addr->mac_addr, ETH_ALEN);
+        dev_dbg(priv->adapter->dev,
+                "info: set mac address: %pM\n", priv->curr_addr);
+        return 0;
+}
+/*
+ * This function handles the command response of set/get MAC multicast
+ * address.
+ */
+static int mwifiex_ret_mac_multicast_adr(struct mwifiex_private *priv,
+                                         struct host_cmd_ds_command *resp)
+{
+        return 0;
+}
+/*
+ * This function handles the command response of get Tx rate query.
+ *
+ * Handling includes changing the header fields into CPU format
+ * and saving the Tx rate and HT information parameters in driver.
+ *
+ * Both rate configuration and current data rate can be retrieved
+ * with this request.
+ */
+static int mwifiex_ret_802_11_tx_rate_query(struct mwifiex_private *priv,
+                                            struct host_cmd_ds_command *resp)
+{
+        priv->tx_rate = resp->params.tx_rate.tx_rate;
+        priv->tx_htinfo = resp->params.tx_rate.ht_info;
+        if (!priv->is_data_rate_auto)
+                priv->data_rate =
+                        mwifiex_index_to_data_rate(priv->tx_rate,
+                                                   priv->tx_htinfo);
+        return 0;
+}
+/*
+ * This function handles the command response of a deauthenticate
+ * command.
+ *
+ * If the deauthenticated MAC matches the current BSS MAC, the connection
+ * state is reset.
+ */
+static int mwifiex_ret_802_11_deauthenticate(struct mwifiex_private *priv,
+                                             struct host_cmd_ds_command *resp)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        adapter->dbg.num_cmd_deauth++;
+        if (!memcmp(resp->params.deauth.mac_addr,
+                    &priv->curr_bss_params.bss_descriptor.mac_address,
+                    sizeof(resp->params.deauth.mac_addr)))
+                mwifiex_reset_connect_state(priv);
+        return 0;
+}
+/*
+ * This function handles the command response of ad-hoc stop.
+ *
+ * The function resets the connection state in driver.
+ */
+static int mwifiex_ret_802_11_ad_hoc_stop(struct mwifiex_private *priv,
+                                          struct host_cmd_ds_command *resp)
+{
+        mwifiex_reset_connect_state(priv);
+        return 0;
+}
+/*
+ * This function handles the command response of set/get key material.
+ *
+ * Handling includes updating the driver parameters to reflect the
+ * changes.
+ */
+static int mwifiex_ret_802_11_key_material(struct mwifiex_private *priv,
+                                           struct host_cmd_ds_command *resp)
+{
+        struct host_cmd_ds_802_11_key_material *key =
+                &resp->params.key_material;
+        if (le16_to_cpu(key->action) == HostCmd_ACT_GEN_SET) {
+                if ((le16_to_cpu(key->key_param_set.key_info) & KEY_MCAST)) {
+                        dev_dbg(priv->adapter->dev, "info: key: GTK is set\n");
+                        priv->wpa_is_gtk_set = true;
+                        priv->scan_block = false;
+                }
+        }
+        memset(priv->aes_key.key_param_set.key, 0,
+               sizeof(key->key_param_set.key));
+        priv->aes_key.key_param_set.key_len = key->key_param_set.key_len;
+        memcpy(priv->aes_key.key_param_set.key, key->key_param_set.key,
+               le16_to_cpu(priv->aes_key.key_param_set.key_len));
+        return 0;
+}
+/*
+ * This function handles the command response of get 11d domain information.
+ */
+static int mwifiex_ret_802_11d_domain_info(struct mwifiex_private *priv,
+                                           struct host_cmd_ds_command *resp)
+{
+        struct host_cmd_ds_802_11d_domain_info_rsp *domain_info =
+                &resp->params.domain_info_resp;
+        struct mwifiex_ietypes_domain_param_set *domain = &domain_info->domain;
+        u16 action = le16_to_cpu(domain_info->action);
+        u8 no_of_triplet;
+        no_of_triplet = (u8) ((le16_to_cpu(domain->header.len) -
+                                        IEEE80211_COUNTRY_STRING_LEN) /
+                                sizeof(struct ieee80211_country_ie_triplet));
+        dev_dbg(priv->adapter->dev, "info: 11D Domain Info Resp:"
+                        " no_of_triplet=%d\n", no_of_triplet);
+        if (no_of_triplet > MWIFIEX_MAX_TRIPLET_802_11D) {
+                dev_warn(priv->adapter->dev,
+                        "11D: invalid number of triplets %d "
+                        "returned!!\n", no_of_triplet);
+                return -1;
+        }
+        switch (action) {
+        case HostCmd_ACT_GEN_SET:  /* Proc Set Action */
+                break;
+        case HostCmd_ACT_GEN_GET:
+                break;
+        default:
+                dev_err(priv->adapter->dev,
+                        "11D: invalid action:%d\n", domain_info->action);
+                return -1;
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of get RF channel.
+ *
+ * Handling includes changing the header fields into CPU format
+ * and saving the new channel in driver.
+ */
+static int mwifiex_ret_802_11_rf_channel(struct mwifiex_private *priv,
+                                         struct host_cmd_ds_command *resp,
+                                         void *data_buf)
+{
+        struct host_cmd_ds_802_11_rf_channel *rf_channel =
+                &resp->params.rf_channel;
+        u16 new_channel = le16_to_cpu(rf_channel->current_channel);
+        if (priv->curr_bss_params.bss_descriptor.channel != new_channel) {
+                dev_dbg(priv->adapter->dev, "cmd: Channel Switch: %d to %d\n",
+                       priv->curr_bss_params.bss_descriptor.channel,
+                       new_channel);
+                /* Update the channel again */
+                priv->curr_bss_params.bss_descriptor.channel = new_channel;
+        }
+        if (data_buf)
+                *((u16 *)data_buf) = new_channel;
+        return 0;
+}
+/*
+ * This function handles the command response of get extended version.
+ *
+ * Handling includes forming the extended version string and sending it
+ * to application.
+ */
+static int mwifiex_ret_ver_ext(struct mwifiex_private *priv,
+                               struct host_cmd_ds_command *resp,
+                               void *data_buf)
+{
+        struct host_cmd_ds_version_ext *ver_ext = &resp->params.verext;
+        struct host_cmd_ds_version_ext *version_ext;
+        if (data_buf) {
+                version_ext = (struct host_cmd_ds_version_ext *)data_buf;
+                version_ext->version_str_sel = ver_ext->version_str_sel;
+                memcpy(version_ext->version_str, ver_ext->version_str,
+                       sizeof(char) * 128);
+                memcpy(priv->version_str, ver_ext->version_str, 128);
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of register access.
+ *
+ * The register value and offset are returned to the user. For EEPROM
+ * access, the byte count is also returned.
+ */
+static int mwifiex_ret_reg_access(u16 type, struct host_cmd_ds_command *resp,
+                                  void *data_buf)
+{
+        struct mwifiex_ds_reg_rw *reg_rw;
+        struct mwifiex_ds_read_eeprom *eeprom;
+        if (data_buf) {
+                reg_rw = (struct mwifiex_ds_reg_rw *) data_buf;
+                eeprom = (struct mwifiex_ds_read_eeprom *) data_buf;
+                switch (type) {
+                case HostCmd_CMD_MAC_REG_ACCESS:
+                        {
+                                struct host_cmd_ds_mac_reg_access *reg;
+                                reg = (struct host_cmd_ds_mac_reg_access *)
+                                        &resp->params.mac_reg;
+                                reg_rw->offset = cpu_to_le32(
+                                        (u32) le16_to_cpu(reg->offset));
+                                reg_rw->value = reg->value;
+                                break;
+                        }
+                case HostCmd_CMD_BBP_REG_ACCESS:
+                        {
+                                struct host_cmd_ds_bbp_reg_access *reg;
+                                reg = (struct host_cmd_ds_bbp_reg_access *)
+                                        &resp->params.bbp_reg;
+                                reg_rw->offset = cpu_to_le32(
+                                        (u32) le16_to_cpu(reg->offset));
+                                reg_rw->value = cpu_to_le32((u32) reg->value);
+                                break;
+                        }
+                case HostCmd_CMD_RF_REG_ACCESS:
+                        {
+                                struct host_cmd_ds_rf_reg_access *reg;
+                                reg = (struct host_cmd_ds_rf_reg_access *)
+                                        &resp->params.rf_reg;
+                                reg_rw->offset = cpu_to_le32(
+                                        (u32) le16_to_cpu(reg->offset));
+                                reg_rw->value = cpu_to_le32((u32) reg->value);
+                                break;
+                        }
+                case HostCmd_CMD_PMIC_REG_ACCESS:
+                        {
+                                struct host_cmd_ds_pmic_reg_access *reg;
+                                reg = (struct host_cmd_ds_pmic_reg_access *)
+                                        &resp->params.pmic_reg;
+                                reg_rw->offset = cpu_to_le32(
+                                        (u32) le16_to_cpu(reg->offset));
+                                reg_rw->value = cpu_to_le32((u32) reg->value);
+                                break;
+                        }
+                case HostCmd_CMD_CAU_REG_ACCESS:
+                        {
+                                struct host_cmd_ds_rf_reg_access *reg;
+                                reg = (struct host_cmd_ds_rf_reg_access *)
+                                        &resp->params.rf_reg;
+                                reg_rw->offset = cpu_to_le32(
+                                        (u32) le16_to_cpu(reg->offset));
+                                reg_rw->value = cpu_to_le32((u32) reg->value);
+                                break;
+                        }
+                case HostCmd_CMD_802_11_EEPROM_ACCESS:
+                        {
+                                struct host_cmd_ds_802_11_eeprom_access
+                                        *cmd_eeprom =
+                                        (struct host_cmd_ds_802_11_eeprom_access
+                                         *) &resp->params.eeprom;
+                                pr_debug("info: EEPROM read len=%x\n",
+                                       cmd_eeprom->byte_count);
+                                if (le16_to_cpu(eeprom->byte_count) <
+                                                le16_to_cpu(
+                                                cmd_eeprom->byte_count)) {
+                                        eeprom->byte_count = cpu_to_le16(0);
+                                        pr_debug("info: EEPROM read "
+                                                        "length is too big\n");
+                                        return -1;
+                                }
+                                eeprom->offset = cmd_eeprom->offset;
+                                eeprom->byte_count = cmd_eeprom->byte_count;
+                                if (le16_to_cpu(eeprom->byte_count) > 0)
+                                        memcpy(&eeprom->value,
+                                               &cmd_eeprom->value,
+                                               le16_to_cpu(eeprom->byte_count));
+                                break;
+                        }
+                default:
+                        return -1;
+                }
+        }
+        return 0;
+}
+/*
+ * This function handles the command response of get IBSS coalescing status.
+ *
+ * If the received BSSID is different than the current one, the current BSSID,
+ * beacon interval, ATIM window and ERP information are updated, along with
+ * changing the ad-hoc state accordingly.
+ */
+static int mwifiex_ret_ibss_coalescing_status(struct mwifiex_private *priv,
+                                              struct host_cmd_ds_command *resp)
+{
+        struct host_cmd_ds_802_11_ibss_status *ibss_coal_resp =
+                &(resp->params.ibss_coalescing);
+        u8 zero_mac[ETH_ALEN] = { 0, 0, 0, 0, 0, 0 };
+        if (le16_to_cpu(ibss_coal_resp->action) == HostCmd_ACT_GEN_SET)
+                return 0;
+        dev_dbg(priv->adapter->dev,
+                "info: new BSSID %pM\n", ibss_coal_resp->bssid);
+        /* If rsp has NULL BSSID, Just return..... No Action */
+        if (!memcmp(ibss_coal_resp->bssid, zero_mac, ETH_ALEN)) {
+                dev_warn(priv->adapter->dev, "new BSSID is NULL\n");
+                return 0;
+        }
+        /* If BSSID is diff, modify current BSS parameters */
+        if (memcmp(priv->curr_bss_params.bss_descriptor.mac_address,
+                   ibss_coal_resp->bssid, ETH_ALEN)) {
+                /* BSSID */
+                memcpy(priv->curr_bss_params.bss_descriptor.mac_address,
+                       ibss_coal_resp->bssid, ETH_ALEN);
+                /* Beacon Interval */
+                priv->curr_bss_params.bss_descriptor.beacon_period
+                        = le16_to_cpu(ibss_coal_resp->beacon_interval);
+                /* ERP Information */
+                priv->curr_bss_params.bss_descriptor.erp_flags =
+                        (u8) le16_to_cpu(ibss_coal_resp->use_g_rate_protect);
+                priv->adhoc_state = ADHOC_COALESCED;
+        }
+        return 0;
+}
+/*
+ * This function handles the command responses.
+ *
+ * This is a generic function, which calls command specific
+ * response handlers based on the command ID.
+ */
+int mwifiex_process_sta_cmdresp(struct mwifiex_private *priv,
+                                u16 cmdresp_no, void *cmd_buf)
+{
+        int ret = 0;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct host_cmd_ds_command *resp =
+                (struct host_cmd_ds_command *) cmd_buf;
+        void *data_buf = adapter->curr_cmd->data_buf;
+        /* If the command is not successful, cleanup and return failure */
+        if (resp->result != HostCmd_RESULT_OK) {
+                mwifiex_process_cmdresp_error(priv, resp);
+                return -1;
+        }
+        /* Command successful, handle response */
+        switch (cmdresp_no) {
+        case HostCmd_CMD_GET_HW_SPEC:
+                ret = mwifiex_ret_get_hw_spec(priv, resp);
+                break;
+        case HostCmd_CMD_MAC_CONTROL:
+                break;
+        case HostCmd_CMD_802_11_MAC_ADDRESS:
+                ret = mwifiex_ret_802_11_mac_address(priv, resp);
+                break;
+        case HostCmd_CMD_MAC_MULTICAST_ADR:
+                ret = mwifiex_ret_mac_multicast_adr(priv, resp);
+                break;
+        case HostCmd_CMD_TX_RATE_CFG:
+                ret = mwifiex_ret_tx_rate_cfg(priv, resp, data_buf);
+                break;
+        case HostCmd_CMD_802_11_SCAN:
+                ret = mwifiex_ret_802_11_scan(priv, resp);
+                adapter->curr_cmd->wait_q_enabled = false;
+                break;
+        case HostCmd_CMD_802_11_BG_SCAN_QUERY:
+                ret = mwifiex_ret_802_11_scan(priv, resp);
+                dev_dbg(adapter->dev,
+                        "info: CMD_RESP: BG_SCAN result is ready!\n");
+                break;
+        case HostCmd_CMD_TXPWR_CFG:
+                ret = mwifiex_ret_tx_power_cfg(priv, resp, data_buf);
+                break;
+        case HostCmd_CMD_802_11_PS_MODE_ENH:
+                ret = mwifiex_ret_enh_power_mode(priv, resp, data_buf);
+                break;
+        case HostCmd_CMD_802_11_HS_CFG_ENH:
+                ret = mwifiex_ret_802_11_hs_cfg(priv, resp);
+                break;
+        case HostCmd_CMD_802_11_ASSOCIATE:
+                ret = mwifiex_ret_802_11_associate(priv, resp);
+                break;
+        case HostCmd_CMD_802_11_DEAUTHENTICATE:
+                ret = mwifiex_ret_802_11_deauthenticate(priv, resp);
+                break;
+        case HostCmd_CMD_802_11_AD_HOC_START:
+        case HostCmd_CMD_802_11_AD_HOC_JOIN:
+                ret = mwifiex_ret_802_11_ad_hoc(priv, resp);
+                break;
+        case HostCmd_CMD_802_11_AD_HOC_STOP:
+                ret = mwifiex_ret_802_11_ad_hoc_stop(priv, resp);
+                break;
+        case HostCmd_CMD_802_11_GET_LOG:
+                ret = mwifiex_ret_get_log(priv, resp, data_buf);
+                break;
+        case HostCmd_CMD_RSSI_INFO:
+                ret = mwifiex_ret_802_11_rssi_info(priv, resp, data_buf);
+                break;
+        case HostCmd_CMD_802_11_SNMP_MIB:
+                ret = mwifiex_ret_802_11_snmp_mib(priv, resp, data_buf);
+                break;
+        case HostCmd_CMD_802_11_TX_RATE_QUERY:
+                ret = mwifiex_ret_802_11_tx_rate_query(priv, resp);
+                break;
+        case HostCmd_CMD_802_11_RF_CHANNEL:
+                ret = mwifiex_ret_802_11_rf_channel(priv, resp, data_buf);
+                break;
+        case HostCmd_CMD_VERSION_EXT:
+                ret = mwifiex_ret_ver_ext(priv, resp, data_buf);
+                break;
+        case HostCmd_CMD_FUNC_INIT:
+        case HostCmd_CMD_FUNC_SHUTDOWN:
+                break;
+        case HostCmd_CMD_802_11_KEY_MATERIAL:
+                ret = mwifiex_ret_802_11_key_material(priv, resp);
+                break;
+        case HostCmd_CMD_802_11D_DOMAIN_INFO:
+                ret = mwifiex_ret_802_11d_domain_info(priv, resp);
+                break;
+        case HostCmd_CMD_11N_ADDBA_REQ:
+                ret = mwifiex_ret_11n_addba_req(priv, resp);
+                break;
+        case HostCmd_CMD_11N_DELBA:
+                ret = mwifiex_ret_11n_delba(priv, resp);
+                break;
+        case HostCmd_CMD_11N_ADDBA_RSP:
+                ret = mwifiex_ret_11n_addba_resp(priv, resp);
+                break;
+        case HostCmd_CMD_RECONFIGURE_TX_BUFF:
+                adapter->tx_buf_size = (u16) le16_to_cpu(resp->params.
+                                                             tx_buf.buff_size);
+                adapter->tx_buf_size = (adapter->tx_buf_size /
+                                                MWIFIEX_SDIO_BLOCK_SIZE) *
+                                                MWIFIEX_SDIO_BLOCK_SIZE;
+                adapter->curr_tx_buf_size = adapter->tx_buf_size;
+                dev_dbg(adapter->dev,
+                        "cmd: max_tx_buf_size=%d, tx_buf_size=%d\n",
+                       adapter->max_tx_buf_size, adapter->tx_buf_size);
+                if (adapter->if_ops.update_mp_end_port)
+                        adapter->if_ops.update_mp_end_port(adapter,
+                                        le16_to_cpu(resp->
+                                                params.
+                                                tx_buf.
+                                                mp_end_port));
+                break;
+        case HostCmd_CMD_AMSDU_AGGR_CTRL:
+                ret = mwifiex_ret_amsdu_aggr_ctrl(resp, data_buf);
+                break;
+        case HostCmd_CMD_WMM_GET_STATUS:
+                ret = mwifiex_ret_wmm_get_status(priv, resp);
+                break;
+        case HostCmd_CMD_802_11_IBSS_COALESCING_STATUS:
+                ret = mwifiex_ret_ibss_coalescing_status(priv, resp);
+                break;
+        case HostCmd_CMD_MAC_REG_ACCESS:
+        case HostCmd_CMD_BBP_REG_ACCESS:
+        case HostCmd_CMD_RF_REG_ACCESS:
+        case HostCmd_CMD_PMIC_REG_ACCESS:
+        case HostCmd_CMD_CAU_REG_ACCESS:
+        case HostCmd_CMD_802_11_EEPROM_ACCESS:
+                ret = mwifiex_ret_reg_access(cmdresp_no, resp, data_buf);
+                break;
+        case HostCmd_CMD_SET_BSS_MODE:
+                break;
+        case HostCmd_CMD_11N_CFG:
+                ret = mwifiex_ret_11n_cfg(resp, data_buf);
+                break;
+        default:
+                dev_err(adapter->dev, "CMD_RESP: unknown cmd response %#x\n",
+                       resp->command);
+                break;
+        }
+        return ret;
+}
diff --git a/drivers/net/wireless/mwifiex/sta_event.c b/drivers/net/wireless/mwifiex/sta_event.c
new file mode 100644
index 000000000000..fc265cab0907
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/sta_event.c
@@ -0,0 +1,406 @@
+/*
+ * Marvell Wireless LAN device driver: station event handling
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+/*
+ * This function resets the connection state.
+ *
+ * The function is invoked after receiving a disconnect event from firmware,
+ * and performs the following actions -
+ *      - Set media status to disconnected
+ *      - Clean up Tx and Rx packets
+ *      - Resets SNR/NF/RSSI value in driver
+ *      - Resets security configurations in driver
+ *      - Enables auto data rate
+ *      - Saves the previous SSID and BSSID so that they can
+ *        be used for re-association, if required
+ *      - Erases current SSID and BSSID information
+ *      - Sends a disconnect event to upper layers/applications.
+ */
+void
+mwifiex_reset_connect_state(struct mwifiex_private *priv)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        if (!priv->media_connected)
+                return;
+        dev_dbg(adapter->dev, "info: handles disconnect event\n");
+        priv->media_connected = false;
+        priv->scan_block = false;
+        /* Free Tx and Rx packets, report disconnect to upper layer */
+        mwifiex_clean_txrx(priv);
+        /* Reset SNR/NF/RSSI values */
+        priv->data_rssi_last = 0;
+        priv->data_nf_last = 0;
+        priv->data_rssi_avg = 0;
+        priv->data_nf_avg = 0;
+        priv->bcn_rssi_last = 0;
+        priv->bcn_nf_last = 0;
+        priv->bcn_rssi_avg = 0;
+        priv->bcn_nf_avg = 0;
+        priv->rxpd_rate = 0;
+        priv->rxpd_htinfo = 0;
+        priv->sec_info.wpa_enabled = false;
+        priv->sec_info.wpa2_enabled = false;
+        priv->wpa_ie_len = 0;
+        priv->sec_info.wapi_enabled = false;
+        priv->wapi_ie_len = 0;
+        priv->sec_info.wapi_key_on = false;
+        priv->sec_info.encryption_mode = 0;
+        /* Enable auto data rate */
+        priv->is_data_rate_auto = true;
+        priv->data_rate = 0;
+        if (priv->bss_mode == NL80211_IFTYPE_ADHOC) {
+                priv->adhoc_state = ADHOC_IDLE;
+                priv->adhoc_is_link_sensed = false;
+        }
+        /*
+         * Memorize the previous SSID and BSSID so
+         * it could be used for re-assoc
+         */
+        dev_dbg(adapter->dev, "info: previous SSID=%s, SSID len=%u\n",
+               priv->prev_ssid.ssid, priv->prev_ssid.ssid_len);
+        dev_dbg(adapter->dev, "info: current SSID=%s, SSID len=%u\n",
+               priv->curr_bss_params.bss_descriptor.ssid.ssid,
+               priv->curr_bss_params.bss_descriptor.ssid.ssid_len);
+        memcpy(&priv->prev_ssid,
+               &priv->curr_bss_params.bss_descriptor.ssid,
+               sizeof(struct mwifiex_802_11_ssid));
+        memcpy(priv->prev_bssid,
+               priv->curr_bss_params.bss_descriptor.mac_address, ETH_ALEN);
+        /* Need to erase the current SSID and BSSID info */
+        memset(&priv->curr_bss_params, 0x00, sizeof(priv->curr_bss_params));
+        adapter->tx_lock_flag = false;
+        adapter->pps_uapsd_mode = false;
+        if (adapter->num_cmd_timeout && adapter->curr_cmd)
+                return;
+        priv->media_connected = false;
+        if (!priv->disconnect) {
+                priv->disconnect = 1;
+                dev_dbg(adapter->dev, "info: successfully disconnected from"
+                                " %pM: reason code %d\n", priv->cfg_bssid,
+                                WLAN_REASON_DEAUTH_LEAVING);
+                cfg80211_disconnected(priv->netdev,
+                                WLAN_REASON_DEAUTH_LEAVING, NULL, 0,
+                                GFP_KERNEL);
+                queue_work(priv->workqueue, &priv->cfg_workqueue);
+        }
+        if (!netif_queue_stopped(priv->netdev))
+                netif_stop_queue(priv->netdev);
+        if (netif_carrier_ok(priv->netdev))
+                netif_carrier_off(priv->netdev);
+        /* Reset wireless stats signal info */
+        priv->w_stats.qual.level = 0;
+        priv->w_stats.qual.noise = 0;
+}
+/*
+ * This function handles events generated by firmware.
+ *
+ * This is a generic function and handles all events.
+ *
+ * Event specific routines are called by this function based
+ * upon the generated event cause.
+ *
+ * For the following events, the function just forwards them to upper
+ * layers, optionally recording the change -
+ *      - EVENT_LINK_SENSED
+ *      - EVENT_MIC_ERR_UNICAST
+ *      - EVENT_MIC_ERR_MULTICAST
+ *      - EVENT_PORT_RELEASE
+ *      - EVENT_RSSI_LOW
+ *      - EVENT_SNR_LOW
+ *      - EVENT_MAX_FAIL
+ *      - EVENT_RSSI_HIGH
+ *      - EVENT_SNR_HIGH
+ *      - EVENT_DATA_RSSI_LOW
+ *      - EVENT_DATA_SNR_LOW
+ *      - EVENT_DATA_RSSI_HIGH
+ *      - EVENT_DATA_SNR_HIGH
+ *      - EVENT_LINK_QUALITY
+ *      - EVENT_PRE_BEACON_LOST
+ *      - EVENT_IBSS_COALESCED
+ *      - EVENT_WEP_ICV_ERR
+ *      - EVENT_BW_CHANGE
+ *      - EVENT_HOSTWAKE_STAIE
+  *
+ * For the following events, no action is taken -
+ *      - EVENT_MIB_CHANGED
+ *      - EVENT_INIT_DONE
+ *      - EVENT_DUMMY_HOST_WAKEUP_SIGNAL
+ *
+ * Rest of the supported events requires driver handling -
+ *      - EVENT_DEAUTHENTICATED
+ *      - EVENT_DISASSOCIATED
+ *      - EVENT_LINK_LOST
+ *      - EVENT_PS_SLEEP
+ *      - EVENT_PS_AWAKE
+ *      - EVENT_DEEP_SLEEP_AWAKE
+ *      - EVENT_HS_ACT_REQ
+ *      - EVENT_ADHOC_BCN_LOST
+ *      - EVENT_BG_SCAN_REPORT
+ *      - EVENT_WMM_STATUS_CHANGE
+ *      - EVENT_ADDBA
+ *      - EVENT_DELBA
+ *      - EVENT_BA_STREAM_TIEMOUT
+ *      - EVENT_AMSDU_AGGR_CTRL
+ */
+int mwifiex_process_sta_event(struct mwifiex_private *priv)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        int ret = 0;
+        u32 eventcause = adapter->event_cause;
+        switch (eventcause) {
+        case EVENT_DUMMY_HOST_WAKEUP_SIGNAL:
+                dev_err(adapter->dev, "invalid EVENT: DUMMY_HOST_WAKEUP_SIGNAL,"
+                                " ignoring it\n");
+                break;
+        case EVENT_LINK_SENSED:
+                dev_dbg(adapter->dev, "event: LINK_SENSED\n");
+                if (!netif_carrier_ok(priv->netdev))
+                        netif_carrier_on(priv->netdev);
+                if (netif_queue_stopped(priv->netdev))
+                        netif_wake_queue(priv->netdev);
+                break;
+        case EVENT_DEAUTHENTICATED:
+                dev_dbg(adapter->dev, "event: Deauthenticated\n");
+                adapter->dbg.num_event_deauth++;
+                if (priv->media_connected)
+                        mwifiex_reset_connect_state(priv);
+                break;
+        case EVENT_DISASSOCIATED:
+                dev_dbg(adapter->dev, "event: Disassociated\n");
+                adapter->dbg.num_event_disassoc++;
+                if (priv->media_connected)
+                        mwifiex_reset_connect_state(priv);
+                break;
+        case EVENT_LINK_LOST:
+                dev_dbg(adapter->dev, "event: Link lost\n");
+                adapter->dbg.num_event_link_lost++;
+                if (priv->media_connected)
+                        mwifiex_reset_connect_state(priv);
+                break;
+        case EVENT_PS_SLEEP:
+                dev_dbg(adapter->dev, "info: EVENT: SLEEP\n");
+                adapter->ps_state = PS_STATE_PRE_SLEEP;
+                mwifiex_check_ps_cond(adapter);
+                break;
+        case EVENT_PS_AWAKE:
+                dev_dbg(adapter->dev, "info: EVENT: AWAKE\n");
+                if (!adapter->pps_uapsd_mode &&
+                        priv->media_connected &&
+                        adapter->sleep_period.period) {
+                                adapter->pps_uapsd_mode = true;
+                                dev_dbg(adapter->dev,
+                                        "event: PPS/UAPSD mode activated\n");
+                }
+                adapter->tx_lock_flag = false;
+                if (adapter->pps_uapsd_mode && adapter->gen_null_pkt) {
+                        if (mwifiex_check_last_packet_indication(priv)) {
+                                if (!adapter->data_sent) {
+                                        if (!mwifiex_send_null_packet(priv,
+                                        MWIFIEX_TxPD_POWER_MGMT_NULL_PACKET
+                                        |
+                                        MWIFIEX_TxPD_POWER_MGMT_LAST_PACKET))
+                                                adapter->ps_state =
+                                                        PS_STATE_SLEEP;
+                                        return 0;
+                                }
+                        }
+                }
+                adapter->ps_state = PS_STATE_AWAKE;
+                adapter->pm_wakeup_card_req = false;
+                adapter->pm_wakeup_fw_try = false;
+                break;
+        case EVENT_DEEP_SLEEP_AWAKE:
+                adapter->if_ops.wakeup_complete(adapter);
+                dev_dbg(adapter->dev, "event: DS_AWAKE\n");
+                if (adapter->is_deep_sleep)
+                        adapter->is_deep_sleep = false;
+                break;
+        case EVENT_HS_ACT_REQ:
+                dev_dbg(adapter->dev, "event: HS_ACT_REQ\n");
+                ret = mwifiex_send_cmd_async(priv,
+                                             HostCmd_CMD_802_11_HS_CFG_ENH,
+                                             0, 0, NULL);
+                break;
+        case EVENT_MIC_ERR_UNICAST:
+                dev_dbg(adapter->dev, "event: UNICAST MIC ERROR\n");
+                break;
+        case EVENT_MIC_ERR_MULTICAST:
+                dev_dbg(adapter->dev, "event: MULTICAST MIC ERROR\n");
+                break;
+        case EVENT_MIB_CHANGED:
+        case EVENT_INIT_DONE:
+                break;
+        case EVENT_ADHOC_BCN_LOST:
+                dev_dbg(adapter->dev, "event: ADHOC_BCN_LOST\n");
+                priv->adhoc_is_link_sensed = false;
+                mwifiex_clean_txrx(priv);
+                if (!netif_queue_stopped(priv->netdev))
+                        netif_stop_queue(priv->netdev);
+                if (netif_carrier_ok(priv->netdev))
+                        netif_carrier_off(priv->netdev);
+                break;
+        case EVENT_BG_SCAN_REPORT:
+                dev_dbg(adapter->dev, "event: BGS_REPORT\n");
+                /* Clear the previous scan result */
+                memset(adapter->scan_table, 0x00,
+                       sizeof(struct mwifiex_bssdescriptor) * IW_MAX_AP);
+                adapter->num_in_scan_table = 0;
+                adapter->bcn_buf_end = adapter->bcn_buf;
+                ret = mwifiex_send_cmd_async(priv,
+                                             HostCmd_CMD_802_11_BG_SCAN_QUERY,
+                                             HostCmd_ACT_GEN_GET, 0, NULL);
+                break;
+        case EVENT_PORT_RELEASE:
+                dev_dbg(adapter->dev, "event: PORT RELEASE\n");
+                break;
+        case EVENT_WMM_STATUS_CHANGE:
+                dev_dbg(adapter->dev, "event: WMM status changed\n");
+                ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_WMM_GET_STATUS,
+                                             0, 0, NULL);
+                break;
+        case EVENT_RSSI_LOW:
+                dev_dbg(adapter->dev, "event: Beacon RSSI_LOW\n");
+                break;
+        case EVENT_SNR_LOW:
+                dev_dbg(adapter->dev, "event: Beacon SNR_LOW\n");
+                break;
+        case EVENT_MAX_FAIL:
+                dev_dbg(adapter->dev, "event: MAX_FAIL\n");
+                break;
+        case EVENT_RSSI_HIGH:
+                dev_dbg(adapter->dev, "event: Beacon RSSI_HIGH\n");
+                break;
+        case EVENT_SNR_HIGH:
+                dev_dbg(adapter->dev, "event: Beacon SNR_HIGH\n");
+                break;
+        case EVENT_DATA_RSSI_LOW:
+                dev_dbg(adapter->dev, "event: Data RSSI_LOW\n");
+                break;
+        case EVENT_DATA_SNR_LOW:
+                dev_dbg(adapter->dev, "event: Data SNR_LOW\n");
+                break;
+        case EVENT_DATA_RSSI_HIGH:
+                dev_dbg(adapter->dev, "event: Data RSSI_HIGH\n");
+                break;
+        case EVENT_DATA_SNR_HIGH:
+                dev_dbg(adapter->dev, "event: Data SNR_HIGH\n");
+                break;
+        case EVENT_LINK_QUALITY:
+                dev_dbg(adapter->dev, "event: Link Quality\n");
+                break;
+        case EVENT_PRE_BEACON_LOST:
+                dev_dbg(adapter->dev, "event: Pre-Beacon Lost\n");
+                break;
+        case EVENT_IBSS_COALESCED:
+                dev_dbg(adapter->dev, "event: IBSS_COALESCED\n");
+                ret = mwifiex_send_cmd_async(priv,
+                                HostCmd_CMD_802_11_IBSS_COALESCING_STATUS,
+                                HostCmd_ACT_GEN_GET, 0, NULL);
+                break;
+        case EVENT_ADDBA:
+                dev_dbg(adapter->dev, "event: ADDBA Request\n");
+                mwifiex_send_cmd_async(priv, HostCmd_CMD_11N_ADDBA_RSP,
+                                       HostCmd_ACT_GEN_SET, 0,
+                                       adapter->event_body);
+                break;
+        case EVENT_DELBA:
+                dev_dbg(adapter->dev, "event: DELBA Request\n");
+                mwifiex_11n_delete_ba_stream(priv, adapter->event_body);
+                break;
+        case EVENT_BA_STREAM_TIEMOUT:
+                dev_dbg(adapter->dev, "event:  BA Stream timeout\n");
+                mwifiex_11n_ba_stream_timeout(priv,
+                                              (struct host_cmd_ds_11n_batimeout
+                                               *)
+                                              adapter->event_body);
+                break;
+        case EVENT_AMSDU_AGGR_CTRL:
+                dev_dbg(adapter->dev, "event:  AMSDU_AGGR_CTRL %d\n",
+                       *(u16 *) adapter->event_body);
+                adapter->tx_buf_size =
+                        min(adapter->curr_tx_buf_size,
+                            le16_to_cpu(*(__le16 *) adapter->event_body));
+                dev_dbg(adapter->dev, "event: tx_buf_size %d\n",
+                                adapter->tx_buf_size);
+                break;
+        case EVENT_WEP_ICV_ERR:
+                dev_dbg(adapter->dev, "event: WEP ICV error\n");
+                break;
+        case EVENT_BW_CHANGE:
+                dev_dbg(adapter->dev, "event: BW Change\n");
+                break;
+        case EVENT_HOSTWAKE_STAIE:
+                dev_dbg(adapter->dev, "event: HOSTWAKE_STAIE %d\n", eventcause);
+                break;
+        default:
+                dev_dbg(adapter->dev, "event: unknown event id: %#x\n",
+                                                eventcause);
+                break;
+        }
+        return ret;
+}
diff --git a/drivers/net/wireless/mwifiex/sta_ioctl.c b/drivers/net/wireless/mwifiex/sta_ioctl.c
new file mode 100644
index 000000000000..d05907d05039
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/sta_ioctl.c
@@ -0,0 +1,1593 @@
+/*
+ * Marvell Wireless LAN device driver: functions for station ioctl
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+#include "cfg80211.h"
+/*
+ * Copies the multicast address list from device to driver.
+ *
+ * This function does not validate the destination memory for
+ * size, and the calling function must ensure enough memory is
+ * available.
+ */
+int mwifiex_copy_mcast_addr(struct mwifiex_multicast_list *mlist,
+                            struct net_device *dev)
+{
+        int i = 0;
+        struct netdev_hw_addr *ha;
+        netdev_for_each_mc_addr(ha, dev)
+                memcpy(&mlist->mac_list[i++], ha->addr, ETH_ALEN);
+        return i;
+}
+/*
+ * Wait queue completion handler.
+ *
+ * This function waits on a cmd wait queue. It also cancels the pending
+ * request after waking up, in case of errors.
+ */
+int mwifiex_wait_queue_complete(struct mwifiex_adapter *adapter)
+{
+        bool cancel_flag = false;
+        int status = adapter->cmd_wait_q.status;
+        dev_dbg(adapter->dev, "cmd pending\n");
+        atomic_inc(&adapter->cmd_pending);
+        /* Status pending, wake up main process */
+        queue_work(adapter->workqueue, &adapter->main_work);
+        /* Wait for completion */
+        wait_event_interruptible(adapter->cmd_wait_q.wait,
+                                        adapter->cmd_wait_q.condition);
+        if (!adapter->cmd_wait_q.condition)
+                cancel_flag = true;
+        if (cancel_flag) {
+                mwifiex_cancel_pending_ioctl(adapter);
+                dev_dbg(adapter->dev, "cmd cancel\n");
+        }
+        adapter->cmd_wait_q.status = 0;
+        return status;
+}
+/*
+ * This function prepares the correct firmware command and
+ * issues it to set the multicast list.
+ *
+ * This function can be used to enable promiscuous mode, or enable all
+ * multicast packets, or to enable selective multicast.
+ */
+int mwifiex_request_set_multicast_list(struct mwifiex_private *priv,
+                                struct mwifiex_multicast_list *mcast_list)
+{
+        int ret = 0;
+        u16 old_pkt_filter;
+        old_pkt_filter = priv->curr_pkt_filter;
+        if (mcast_list->mode == MWIFIEX_PROMISC_MODE) {
+                dev_dbg(priv->adapter->dev, "info: Enable Promiscuous mode\n");
+                priv->curr_pkt_filter |= HostCmd_ACT_MAC_PROMISCUOUS_ENABLE;
+                priv->curr_pkt_filter &=
+                        ~HostCmd_ACT_MAC_ALL_MULTICAST_ENABLE;
+        } else {
+                /* Multicast */
+                priv->curr_pkt_filter &= ~HostCmd_ACT_MAC_PROMISCUOUS_ENABLE;
+                if (mcast_list->mode == MWIFIEX_MULTICAST_MODE) {
+                        dev_dbg(priv->adapter->dev,
+                                "info: Enabling All Multicast!\n");
+                        priv->curr_pkt_filter |=
+                                HostCmd_ACT_MAC_ALL_MULTICAST_ENABLE;
+                } else {
+                        priv->curr_pkt_filter &=
+                                ~HostCmd_ACT_MAC_ALL_MULTICAST_ENABLE;
+                        if (mcast_list->num_multicast_addr) {
+                                dev_dbg(priv->adapter->dev,
+                                        "info: Set multicast list=%d\n",
+                                       mcast_list->num_multicast_addr);
+                                /* Set multicast addresses to firmware */
+                                if (old_pkt_filter == priv->curr_pkt_filter) {
+                                        /* Send request to firmware */
+                                        ret = mwifiex_send_cmd_async(priv,
+                                                HostCmd_CMD_MAC_MULTICAST_ADR,
+                                                HostCmd_ACT_GEN_SET, 0,
+                                                mcast_list);
+                                } else {
+                                        /* Send request to firmware */
+                                        ret = mwifiex_send_cmd_async(priv,
+                                                HostCmd_CMD_MAC_MULTICAST_ADR,
+                                                HostCmd_ACT_GEN_SET, 0,
+                                                mcast_list);
+                                }
+                        }
+                }
+        }
+        dev_dbg(priv->adapter->dev,
+                "info: old_pkt_filter=%#x, curr_pkt_filter=%#x\n",
+               old_pkt_filter, priv->curr_pkt_filter);
+        if (old_pkt_filter != priv->curr_pkt_filter) {
+                ret = mwifiex_send_cmd_async(priv, HostCmd_CMD_MAC_CONTROL,
+                                             HostCmd_ACT_GEN_SET,
+                                             0, &priv->curr_pkt_filter);
+        }
+        return ret;
+}
+/*
+ * In Ad-Hoc mode, the IBSS is created if not found in scan list.
+ * In both Ad-Hoc and infra mode, an deauthentication is performed
+ * first.
+ */
+int mwifiex_bss_start(struct mwifiex_private *priv,
+                      struct mwifiex_ssid_bssid *ssid_bssid)
+{
+        int ret;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        s32 i = -1;
+        priv->scan_block = false;
+        if (!ssid_bssid)
+                return -1;
+        if (priv->bss_mode == NL80211_IFTYPE_STATION) {
+                /* Infra mode */
+                ret = mwifiex_deauthenticate(priv, NULL);
+                if (ret)
+                        return ret;
+                /* Search for the requested SSID in the scan table */
+                if (ssid_bssid->ssid.ssid_len)
+                        i = mwifiex_find_ssid_in_list(priv, &ssid_bssid->ssid,
+                                                NULL, NL80211_IFTYPE_STATION);
+                else
+                        i = mwifiex_find_bssid_in_list(priv,
+                                                (u8 *) &ssid_bssid->bssid,
+                                                NL80211_IFTYPE_STATION);
+                if (i < 0)
+                        return -1;
+                dev_dbg(adapter->dev,
+                        "info: SSID found in scan list ... associating...\n");
+                /* Clear any past association response stored for
+                 * application retrieval */
+                priv->assoc_rsp_size = 0;
+                ret = mwifiex_associate(priv, &adapter->scan_table[i]);
+                if (ret)
+                        return ret;
+        } else {
+                /* Adhoc mode */
+                /* If the requested SSID matches current SSID, return */
+                if (ssid_bssid->ssid.ssid_len &&
+                    (!mwifiex_ssid_cmp
+                     (&priv->curr_bss_params.bss_descriptor.ssid,
+                      &ssid_bssid->ssid)))
+                        return 0;
+                /* Exit Adhoc mode first */
+                dev_dbg(adapter->dev, "info: Sending Adhoc Stop\n");
+                ret = mwifiex_deauthenticate(priv, NULL);
+                if (ret)
+                        return ret;
+                priv->adhoc_is_link_sensed = false;
+                /* Search for the requested network in the scan table */
+                if (ssid_bssid->ssid.ssid_len)
+                        i = mwifiex_find_ssid_in_list(priv,
+                                                      &ssid_bssid->ssid, NULL,
+                                                      NL80211_IFTYPE_ADHOC);
+                else
+                        i = mwifiex_find_bssid_in_list(priv,
+                                                       (u8 *)&ssid_bssid->bssid,
+                                                       NL80211_IFTYPE_ADHOC);
+                if (i >= 0) {
+                        dev_dbg(adapter->dev, "info: network found in scan"
+                                                        " list. Joining...\n");
+                        ret = mwifiex_adhoc_join(priv, &adapter->scan_table[i]);
+                        if (ret)
+                                return ret;
+                } else {
+                        dev_dbg(adapter->dev, "info: Network not found in "
+                                "the list, creating adhoc with ssid = %s\n",
+                               ssid_bssid->ssid.ssid);
+                        ret = mwifiex_adhoc_start(priv, &ssid_bssid->ssid);
+                        if (ret)
+                                return ret;
+                }
+        }
+        return ret;
+}
+/*
+ * IOCTL request handler to set host sleep configuration.
+ *
+ * This function prepares the correct firmware command and
+ * issues it.
+ */
+int mwifiex_set_hs_params(struct mwifiex_private *priv, u16 action,
+                          int cmd_type, struct mwifiex_ds_hs_cfg *hs_cfg)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        int status = 0;
+        u32 prev_cond = 0;
+        if (!hs_cfg)
+                return -ENOMEM;
+        switch (action) {
+        case HostCmd_ACT_GEN_SET:
+                if (adapter->pps_uapsd_mode) {
+                        dev_dbg(adapter->dev, "info: Host Sleep IOCTL"
+                                " is blocked in UAPSD/PPS mode\n");
+                        status = -1;
+                        break;
+                }
+                if (hs_cfg->is_invoke_hostcmd) {
+                        if (hs_cfg->conditions == HOST_SLEEP_CFG_CANCEL) {
+                                if (!adapter->is_hs_configured)
+                                        /* Already cancelled */
+                                        break;
+                                /* Save previous condition */
+                                prev_cond = le32_to_cpu(adapter->hs_cfg
+                                                        .conditions);
+                                adapter->hs_cfg.conditions =
+                                                cpu_to_le32(hs_cfg->conditions);
+                        } else if (hs_cfg->conditions) {
+                                adapter->hs_cfg.conditions =
+                                                cpu_to_le32(hs_cfg->conditions);
+                                adapter->hs_cfg.gpio = (u8)hs_cfg->gpio;
+                                if (hs_cfg->gap)
+                                        adapter->hs_cfg.gap = (u8)hs_cfg->gap;
+                        } else if (adapter->hs_cfg.conditions ==
+                                                cpu_to_le32(
+                                                HOST_SLEEP_CFG_CANCEL)) {
+                                /* Return failure if no parameters for HS
+                                   enable */
+                                status = -1;
+                                break;
+                        }
+                        if (cmd_type == MWIFIEX_SYNC_CMD)
+                                status = mwifiex_send_cmd_sync(priv,
+                                                HostCmd_CMD_802_11_HS_CFG_ENH,
+                                                HostCmd_ACT_GEN_SET, 0,
+                                                &adapter->hs_cfg);
+                        else
+                                status = mwifiex_send_cmd_async(priv,
+                                                HostCmd_CMD_802_11_HS_CFG_ENH,
+                                                HostCmd_ACT_GEN_SET, 0,
+                                                &adapter->hs_cfg);
+                        if (hs_cfg->conditions == HOST_SLEEP_CFG_CANCEL)
+                                /* Restore previous condition */
+                                adapter->hs_cfg.conditions =
+                                                cpu_to_le32(prev_cond);
+                } else {
+                        adapter->hs_cfg.conditions =
+                                cpu_to_le32(hs_cfg->conditions);
+                        adapter->hs_cfg.gpio = (u8)hs_cfg->gpio;
+                        adapter->hs_cfg.gap = (u8)hs_cfg->gap;
+                }
+                break;
+        case HostCmd_ACT_GEN_GET:
+                hs_cfg->conditions = le32_to_cpu(adapter->hs_cfg.conditions);
+                hs_cfg->gpio = adapter->hs_cfg.gpio;
+                hs_cfg->gap = adapter->hs_cfg.gap;
+                break;
+        default:
+                status = -1;
+                break;
+        }
+        return status;
+}
+/*
+ * Sends IOCTL request to cancel the existing Host Sleep configuration.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int mwifiex_cancel_hs(struct mwifiex_private *priv, int cmd_type)
+{
+        struct mwifiex_ds_hs_cfg hscfg;
+        hscfg.conditions = HOST_SLEEP_CFG_CANCEL;
+        hscfg.is_invoke_hostcmd = true;
+        return mwifiex_set_hs_params(priv, HostCmd_ACT_GEN_SET,
+                                    cmd_type, &hscfg);
+}
+EXPORT_SYMBOL_GPL(mwifiex_cancel_hs);
+/*
+ * Sends IOCTL request to cancel the existing Host Sleep configuration.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int mwifiex_enable_hs(struct mwifiex_adapter *adapter)
+{
+        struct mwifiex_ds_hs_cfg hscfg;
+        if (adapter->hs_activated) {
+                dev_dbg(adapter->dev, "cmd: HS Already actived\n");
+                return true;
+        }
+        adapter->hs_activate_wait_q_woken = false;
+        memset(&hscfg, 0, sizeof(struct mwifiex_hs_config_param));
+        hscfg.is_invoke_hostcmd = true;
+        if (mwifiex_set_hs_params(mwifiex_get_priv(adapter,
+                                                       MWIFIEX_BSS_ROLE_STA),
+                                  HostCmd_ACT_GEN_SET, MWIFIEX_SYNC_CMD,
+                                  &hscfg)) {
+                dev_err(adapter->dev, "IOCTL request HS enable failed\n");
+                return false;
+        }
+        wait_event_interruptible(adapter->hs_activate_wait_q,
+                        adapter->hs_activate_wait_q_woken);
+        return true;
+}
+EXPORT_SYMBOL_GPL(mwifiex_enable_hs);
+/*
+ * IOCTL request handler to get BSS information.
+ *
+ * This function collates the information from different driver structures
+ * to send to the user.
+ */
+int mwifiex_get_bss_info(struct mwifiex_private *priv,
+                         struct mwifiex_bss_info *info)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_bssdescriptor *bss_desc;
+        s32 tbl_idx;
+        if (!info)
+                return -1;
+        bss_desc = &priv->curr_bss_params.bss_descriptor;
+        info->bss_mode = priv->bss_mode;
+        memcpy(&info->ssid, &bss_desc->ssid,
+               sizeof(struct mwifiex_802_11_ssid));
+        memcpy(&info->bssid, &bss_desc->mac_address, ETH_ALEN);
+        info->bss_chan = bss_desc->channel;
+        info->region_code = adapter->region_code;
+        /* Scan table index if connected */
+        info->scan_table_idx = 0;
+        if (priv->media_connected) {
+                tbl_idx =
+                        mwifiex_find_ssid_in_list(priv, &bss_desc->ssid,
+                                                  bss_desc->mac_address,
+                                                  priv->bss_mode);
+                if (tbl_idx >= 0)
+                        info->scan_table_idx = tbl_idx;
+        }
+        info->media_connected = priv->media_connected;
+        info->max_power_level = priv->max_tx_power_level;
+        info->min_power_level = priv->min_tx_power_level;
+        info->adhoc_state = priv->adhoc_state;
+        info->bcn_nf_last = priv->bcn_nf_last;
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_ENABLED)
+                info->wep_status = true;
+        else
+                info->wep_status = false;
+        info->is_hs_configured = adapter->is_hs_configured;
+        info->is_deep_sleep = adapter->is_deep_sleep;
+        return 0;
+}
+/*
+ * The function sets band configurations.
+ *
+ * it performs extra checks to make sure the Ad-Hoc
+ * band and channel are compatible. Otherwise it returns an error.
+ *
+ */
+int mwifiex_set_radio_band_cfg(struct mwifiex_private *priv,
+                               struct mwifiex_ds_band_cfg *radio_cfg)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        u8 infra_band, adhoc_band;
+        u32 adhoc_channel;
+        infra_band = (u8) radio_cfg->config_bands;
+        adhoc_band = (u8) radio_cfg->adhoc_start_band;
+        adhoc_channel = radio_cfg->adhoc_channel;
+        /* SET Infra band */
+        if ((infra_band | adapter->fw_bands) & ~adapter->fw_bands)
+                return -1;
+        adapter->config_bands = infra_band;
+        /* SET Ad-hoc Band */
+        if ((adhoc_band | adapter->fw_bands) & ~adapter->fw_bands)
+                return -1;
+        if (adhoc_band)
+                adapter->adhoc_start_band = adhoc_band;
+        adapter->chan_offset = (u8) radio_cfg->sec_chan_offset;
+        /*
+         * If no adhoc_channel is supplied verify if the existing adhoc
+         * channel compiles with new adhoc_band
+         */
+        if (!adhoc_channel) {
+                if (!mwifiex_get_cfp_by_band_and_channel_from_cfg80211
+                     (priv, adapter->adhoc_start_band,
+                     priv->adhoc_channel)) {
+                        /* Pass back the default channel */
+                        radio_cfg->adhoc_channel = DEFAULT_AD_HOC_CHANNEL;
+                        if ((adapter->adhoc_start_band & BAND_A)
+                            || (adapter->adhoc_start_band & BAND_AN))
+                                radio_cfg->adhoc_channel =
+                                        DEFAULT_AD_HOC_CHANNEL_A;
+                }
+        } else {        /* Retrurn error if adhoc_band and
+                           adhoc_channel combination is invalid */
+                if (!mwifiex_get_cfp_by_band_and_channel_from_cfg80211
+                    (priv, adapter->adhoc_start_band, (u16) adhoc_channel))
+                        return -1;
+                priv->adhoc_channel = (u8) adhoc_channel;
+        }
+        if ((adhoc_band & BAND_GN) || (adhoc_band & BAND_AN))
+                adapter->adhoc_11n_enabled = true;
+        else
+                adapter->adhoc_11n_enabled = false;
+        return 0;
+}
+/*
+ * IOCTL request handler to set/get active channel.
+ *
+ * This function performs validity checking on channel/frequency
+ * compatibility and returns failure if not valid.
+ */
+int mwifiex_bss_set_channel(struct mwifiex_private *priv,
+                            struct mwifiex_chan_freq_power *chan)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_chan_freq_power *cfp = NULL;
+        if (!chan)
+                return -1;
+        if (!chan->channel && !chan->freq)
+                return -1;
+        if (adapter->adhoc_start_band & BAND_AN)
+                adapter->adhoc_start_band = BAND_G | BAND_B | BAND_GN;
+        else if (adapter->adhoc_start_band & BAND_A)
+                adapter->adhoc_start_band = BAND_G | BAND_B;
+        if (chan->channel) {
+                if (chan->channel <= MAX_CHANNEL_BAND_BG)
+                        cfp = mwifiex_get_cfp_by_band_and_channel_from_cfg80211
+                                        (priv, 0, (u16) chan->channel);
+                if (!cfp) {
+                        cfp = mwifiex_get_cfp_by_band_and_channel_from_cfg80211
+                                        (priv, BAND_A, (u16) chan->channel);
+                        if (cfp) {
+                                if (adapter->adhoc_11n_enabled)
+                                        adapter->adhoc_start_band = BAND_A
+                                                | BAND_AN;
+                                else
+                                        adapter->adhoc_start_band = BAND_A;
+                        }
+                }
+        } else {
+                if (chan->freq <= MAX_FREQUENCY_BAND_BG)
+                        cfp = mwifiex_get_cfp_by_band_and_freq_from_cfg80211(
+                                                        priv, 0, chan->freq);
+                if (!cfp) {
+                        cfp = mwifiex_get_cfp_by_band_and_freq_from_cfg80211
+                                                  (priv, BAND_A, chan->freq);
+                        if (cfp) {
+                                if (adapter->adhoc_11n_enabled)
+                                        adapter->adhoc_start_band = BAND_A
+                                                | BAND_AN;
+                                else
+                                        adapter->adhoc_start_band = BAND_A;
+                        }
+                }
+        }
+        if (!cfp || !cfp->channel) {
+                dev_err(adapter->dev, "invalid channel/freq\n");
+                return -1;
+        }
+        priv->adhoc_channel = (u8) cfp->channel;
+        chan->channel = cfp->channel;
+        chan->freq = cfp->freq;
+        return 0;
+}
+/*
+ * IOCTL request handler to set/get Ad-Hoc channel.
+ *
+ * This function prepares the correct firmware command and
+ * issues it to set or get the ad-hoc channel.
+ */
+static int mwifiex_bss_ioctl_ibss_channel(struct mwifiex_private *priv,
+                                          u16 action, u16 *channel)
+{
+        if (action == HostCmd_ACT_GEN_GET) {
+                if (!priv->media_connected) {
+                        *channel = priv->adhoc_channel;
+                        return 0;
+                }
+        } else {
+                priv->adhoc_channel = (u8) *channel;
+        }
+        return mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_RF_CHANNEL,
+                                    action, 0, channel);
+}
+/*
+ * IOCTL request handler to find a particular BSS.
+ *
+ * The BSS can be searched with either a BSSID or a SSID. If none of
+ * these are provided, just the best BSS (best RSSI) is returned.
+ */
+int mwifiex_bss_ioctl_find_bss(struct mwifiex_private *priv,
+                               struct mwifiex_ssid_bssid *ssid_bssid)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_bssdescriptor *bss_desc;
+        u8 zero_mac[ETH_ALEN] = { 0, 0, 0, 0, 0, 0 };
+        u8 mac[ETH_ALEN];
+        int i = 0;
+        if (memcmp(ssid_bssid->bssid, zero_mac, sizeof(zero_mac))) {
+                i = mwifiex_find_bssid_in_list(priv,
+                                               (u8 *) ssid_bssid->bssid,
+                                               priv->bss_mode);
+                if (i < 0) {
+                        memcpy(mac, ssid_bssid->bssid, sizeof(mac));
+                        dev_err(adapter->dev, "cannot find bssid %pM\n", mac);
+                        return -1;
+                }
+                bss_desc = &adapter->scan_table[i];
+                memcpy(&ssid_bssid->ssid, &bss_desc->ssid,
+                                sizeof(struct mwifiex_802_11_ssid));
+        } else if (ssid_bssid->ssid.ssid_len) {
+                i = mwifiex_find_ssid_in_list(priv, &ssid_bssid->ssid, NULL,
+                                              priv->bss_mode);
+                if (i < 0) {
+                        dev_err(adapter->dev, "cannot find ssid %s\n",
+                                        ssid_bssid->ssid.ssid);
+                        return -1;
+                }
+                bss_desc = &adapter->scan_table[i];
+                memcpy(ssid_bssid->bssid, bss_desc->mac_address, ETH_ALEN);
+        } else {
+                return mwifiex_find_best_network(priv, ssid_bssid);
+        }
+        return 0;
+}
+/*
+ * IOCTL request handler to change Ad-Hoc channel.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ *
+ * The function follows the following steps to perform the change -
+ *      - Get current IBSS information
+ *      - Get current channel
+ *      - If no change is required, return
+ *      - If not connected, change channel and return
+ *      - If connected,
+ *          - Disconnect
+ *          - Change channel
+ *          - Perform specific SSID scan with same SSID
+ *          - Start/Join the IBSS
+ */
+int
+mwifiex_drv_change_adhoc_chan(struct mwifiex_private *priv, int channel)
+{
+        int ret;
+        struct mwifiex_bss_info bss_info;
+        struct mwifiex_ssid_bssid ssid_bssid;
+        u16 curr_chan = 0;
+        memset(&bss_info, 0, sizeof(bss_info));
+        /* Get BSS information */
+        if (mwifiex_get_bss_info(priv, &bss_info))
+                return -1;
+        /* Get current channel */
+        ret = mwifiex_bss_ioctl_ibss_channel(priv, HostCmd_ACT_GEN_GET,
+                                             &curr_chan);
+        if (curr_chan == channel) {
+                ret = 0;
+                goto done;
+        }
+        dev_dbg(priv->adapter->dev, "cmd: updating channel from %d to %d\n",
+                        curr_chan, channel);
+        if (!bss_info.media_connected) {
+                ret = 0;
+                goto done;
+        }
+        /* Do disonnect */
+        memset(&ssid_bssid, 0, ETH_ALEN);
+        ret = mwifiex_deauthenticate(priv, ssid_bssid.bssid);
+        ret = mwifiex_bss_ioctl_ibss_channel(priv, HostCmd_ACT_GEN_SET,
+                                             (u16 *) &channel);
+        /* Do specific SSID scanning */
+        if (mwifiex_request_scan(priv, &bss_info.ssid)) {
+                ret = -1;
+                goto done;
+        }
+        /* Start/Join Adhoc network */
+        memset(&ssid_bssid, 0, sizeof(struct mwifiex_ssid_bssid));
+        memcpy(&ssid_bssid.ssid, &bss_info.ssid,
+               sizeof(struct mwifiex_802_11_ssid));
+        ret = mwifiex_bss_start(priv, &ssid_bssid);
+done:
+        return ret;
+}
+/*
+ * IOCTL request handler to get rate.
+ *
+ * This function prepares the correct firmware command and
+ * issues it to get the current rate if it is connected,
+ * otherwise, the function returns the lowest supported rate
+ * for the band.
+ */
+static int mwifiex_rate_ioctl_get_rate_value(struct mwifiex_private *priv,
+                                             struct mwifiex_rate_cfg *rate_cfg)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        rate_cfg->is_rate_auto = priv->is_data_rate_auto;
+        if (!priv->media_connected) {
+                switch (adapter->config_bands) {
+                case BAND_B:
+                        /* Return the lowest supported rate for B band */
+                        rate_cfg->rate = supported_rates_b[0] & 0x7f;
+                        break;
+                case BAND_G:
+                case BAND_G | BAND_GN:
+                        /* Return the lowest supported rate for G band */
+                        rate_cfg->rate = supported_rates_g[0] & 0x7f;
+                        break;
+                case BAND_B | BAND_G:
+                case BAND_A | BAND_B | BAND_G:
+                case BAND_A | BAND_B:
+                case BAND_A | BAND_B | BAND_G | BAND_AN | BAND_GN:
+                case BAND_B | BAND_G | BAND_GN:
+                        /* Return the lowest supported rate for BG band */
+                        rate_cfg->rate = supported_rates_bg[0] & 0x7f;
+                        break;
+                case BAND_A:
+                case BAND_A | BAND_G:
+                case BAND_A | BAND_G | BAND_AN | BAND_GN:
+                case BAND_A | BAND_AN:
+                        /* Return the lowest supported rate for A band */
+                        rate_cfg->rate = supported_rates_a[0] & 0x7f;
+                        break;
+                case BAND_GN:
+                        /* Return the lowest supported rate for N band */
+                        rate_cfg->rate = supported_rates_n[0] & 0x7f;
+                        break;
+                default:
+                        dev_warn(adapter->dev, "invalid band %#x\n",
+                               adapter->config_bands);
+                        break;
+                }
+        } else {
+                return mwifiex_send_cmd_sync(priv,
+                                            HostCmd_CMD_802_11_TX_RATE_QUERY,
+                                            HostCmd_ACT_GEN_GET, 0, NULL);
+        }
+        return 0;
+}
+/*
+ * IOCTL request handler to set rate.
+ *
+ * This function prepares the correct firmware command and
+ * issues it to set the current rate.
+ *
+ * The function also performs validation checking on the supplied value.
+ */
+static int mwifiex_rate_ioctl_set_rate_value(struct mwifiex_private *priv,
+                                             struct mwifiex_rate_cfg *rate_cfg)
+{
+        u8 rates[MWIFIEX_SUPPORTED_RATES];
+        u8 *rate;
+        int rate_index, ret;
+        u16 bitmap_rates[MAX_BITMAP_RATES_SIZE];
+        u32 i;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        if (rate_cfg->is_rate_auto) {
+                memset(bitmap_rates, 0, sizeof(bitmap_rates));
+                /* Support all HR/DSSS rates */
+                bitmap_rates[0] = 0x000F;
+                /* Support all OFDM rates */
+                bitmap_rates[1] = 0x00FF;
+                /* Support all HT-MCSs rate */
+                for (i = 0; i < ARRAY_SIZE(priv->bitmap_rates) - 3; i++)
+                        bitmap_rates[i + 2] = 0xFFFF;
+                bitmap_rates[9] = 0x3FFF;
+        } else {
+                memset(rates, 0, sizeof(rates));
+                mwifiex_get_active_data_rates(priv, rates);
+                rate = rates;
+                for (i = 0; (rate[i] && i < MWIFIEX_SUPPORTED_RATES); i++) {
+                        dev_dbg(adapter->dev, "info: rate=%#x wanted=%#x\n",
+                                rate[i], rate_cfg->rate);
+                        if ((rate[i] & 0x7f) == (rate_cfg->rate & 0x7f))
+                                break;
+                }
+                if (!rate[i] || (i == MWIFIEX_SUPPORTED_RATES)) {
+                        dev_err(adapter->dev, "fixed data rate %#x is out "
+                               "of range\n", rate_cfg->rate);
+                        return -1;
+                }
+                memset(bitmap_rates, 0, sizeof(bitmap_rates));
+                rate_index = mwifiex_data_rate_to_index(rate_cfg->rate);
+                /* Only allow b/g rates to be set */
+                if (rate_index >= MWIFIEX_RATE_INDEX_HRDSSS0 &&
+                    rate_index <= MWIFIEX_RATE_INDEX_HRDSSS3) {
+                        bitmap_rates[0] = 1 << rate_index;
+                } else {
+                        rate_index -= 1; /* There is a 0x00 in the table */
+                        if (rate_index >= MWIFIEX_RATE_INDEX_OFDM0 &&
+                            rate_index <= MWIFIEX_RATE_INDEX_OFDM7)
+                                bitmap_rates[1] = 1 << (rate_index -
+                                                   MWIFIEX_RATE_INDEX_OFDM0);
+                }
+        }
+        ret = mwifiex_send_cmd_sync(priv, HostCmd_CMD_TX_RATE_CFG,
+                                    HostCmd_ACT_GEN_SET, 0, bitmap_rates);
+        return ret;
+}
+/*
+ * IOCTL request handler to set/get rate.
+ *
+ * This function can be used to set/get either the rate value or the
+ * rate index.
+ */
+static int mwifiex_rate_ioctl_cfg(struct mwifiex_private *priv,
+                                  struct mwifiex_rate_cfg *rate_cfg)
+{
+        int status;
+        if (!rate_cfg)
+                return -1;
+        if (rate_cfg->action == HostCmd_ACT_GEN_GET)
+                status = mwifiex_rate_ioctl_get_rate_value(priv, rate_cfg);
+        else
+                status = mwifiex_rate_ioctl_set_rate_value(priv, rate_cfg);
+        return status;
+}
+/*
+ * Sends IOCTL request to get the data rate.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int mwifiex_drv_get_data_rate(struct mwifiex_private *priv,
+                              struct mwifiex_rate_cfg *rate)
+{
+        int ret;
+        memset(rate, 0, sizeof(struct mwifiex_rate_cfg));
+        rate->action = HostCmd_ACT_GEN_GET;
+        ret = mwifiex_rate_ioctl_cfg(priv, rate);
+        if (!ret) {
+                if (rate && rate->is_rate_auto)
+                        rate->rate = mwifiex_index_to_data_rate(priv->tx_rate,
+                                                        priv->tx_htinfo);
+                else if (rate)
+                        rate->rate = priv->data_rate;
+        } else {
+                ret = -1;
+        }
+        return ret;
+}
+/*
+ * IOCTL request handler to set tx power configuration.
+ *
+ * This function prepares the correct firmware command and
+ * issues it.
+ *
+ * For non-auto power mode, all the following power groups are set -
+ *      - Modulation class HR/DSSS
+ *      - Modulation class OFDM
+ *      - Modulation class HTBW20
+ *      - Modulation class HTBW40
+ */
+int mwifiex_set_tx_power(struct mwifiex_private *priv,
+                         struct mwifiex_power_cfg *power_cfg)
+{
+        int ret;
+        struct host_cmd_ds_txpwr_cfg *txp_cfg;
+        struct mwifiex_types_power_group *pg_tlv;
+        struct mwifiex_power_group *pg;
+        u8 *buf;
+        u16 dbm = 0;
+        if (!power_cfg->is_power_auto) {
+                dbm = (u16) power_cfg->power_level;
+                if ((dbm < priv->min_tx_power_level) ||
+                    (dbm > priv->max_tx_power_level)) {
+                        dev_err(priv->adapter->dev, "txpower value %d dBm"
+                                        " is out of range (%d dBm-%d dBm)\n",
+                                        dbm, priv->min_tx_power_level,
+                                        priv->max_tx_power_level);
+                        return -1;
+                }
+        }
+        buf = kzalloc(MWIFIEX_SIZE_OF_CMD_BUFFER, GFP_KERNEL);
+        if (!buf) {
+                dev_err(priv->adapter->dev, "%s: failed to alloc cmd buffer\n",
+                                __func__);
+                return -ENOMEM;
+        }
+        txp_cfg = (struct host_cmd_ds_txpwr_cfg *) buf;
+        txp_cfg->action = cpu_to_le16(HostCmd_ACT_GEN_SET);
+        if (!power_cfg->is_power_auto) {
+                txp_cfg->mode = cpu_to_le32(1);
+                pg_tlv = (struct mwifiex_types_power_group *) (buf +
+                                sizeof(struct host_cmd_ds_txpwr_cfg));
+                pg_tlv->type = TLV_TYPE_POWER_GROUP;
+                pg_tlv->length = 4 * sizeof(struct mwifiex_power_group);
+                pg = (struct mwifiex_power_group *) (buf +
+                                sizeof(struct host_cmd_ds_txpwr_cfg) +
+                                sizeof(struct mwifiex_types_power_group));
+                /* Power group for modulation class HR/DSSS */
+                pg->first_rate_code = 0x00;
+                pg->last_rate_code = 0x03;
+                pg->modulation_class = MOD_CLASS_HR_DSSS;
+                pg->power_step = 0;
+                pg->power_min = (s8) dbm;
+                pg->power_max = (s8) dbm;
+                pg++;
+                /* Power group for modulation class OFDM */
+                pg->first_rate_code = 0x00;
+                pg->last_rate_code = 0x07;
+                pg->modulation_class = MOD_CLASS_OFDM;
+                pg->power_step = 0;
+                pg->power_min = (s8) dbm;
+                pg->power_max = (s8) dbm;
+                pg++;
+                /* Power group for modulation class HTBW20 */
+                pg->first_rate_code = 0x00;
+                pg->last_rate_code = 0x20;
+                pg->modulation_class = MOD_CLASS_HT;
+                pg->power_step = 0;
+                pg->power_min = (s8) dbm;
+                pg->power_max = (s8) dbm;
+                pg->ht_bandwidth = HT_BW_20;
+                pg++;
+                /* Power group for modulation class HTBW40 */
+                pg->first_rate_code = 0x00;
+                pg->last_rate_code = 0x20;
+                pg->modulation_class = MOD_CLASS_HT;
+                pg->power_step = 0;
+                pg->power_min = (s8) dbm;
+                pg->power_max = (s8) dbm;
+                pg->ht_bandwidth = HT_BW_40;
+        }
+        ret = mwifiex_send_cmd_sync(priv, HostCmd_CMD_TXPWR_CFG,
+                                    HostCmd_ACT_GEN_SET, 0, buf);
+        kfree(buf);
+        return ret;
+}
+/*
+ * IOCTL request handler to get power save mode.
+ *
+ * This function prepares the correct firmware command and
+ * issues it.
+ */
+int mwifiex_drv_set_power(struct mwifiex_private *priv, u32 *ps_mode)
+{
+        int ret;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        u16 sub_cmd;
+        if (*ps_mode)
+                adapter->ps_mode = MWIFIEX_802_11_POWER_MODE_PSP;
+        else
+                adapter->ps_mode = MWIFIEX_802_11_POWER_MODE_CAM;
+        sub_cmd = (*ps_mode) ? EN_AUTO_PS : DIS_AUTO_PS;
+        ret = mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_PS_MODE_ENH,
+                                    sub_cmd, BITMAP_STA_PS, NULL);
+        if ((!ret) && (sub_cmd == DIS_AUTO_PS))
+                ret = mwifiex_send_cmd_async(priv,
+                                HostCmd_CMD_802_11_PS_MODE_ENH, GET_PS,
+                                0, NULL);
+        return ret;
+}
+/*
+ * IOCTL request handler to set/reset WPA IE.
+ *
+ * The supplied WPA IE is treated as a opaque buffer. Only the first field
+ * is checked to determine WPA version. If buffer length is zero, the existing
+ * WPA IE is reset.
+ */
+static int mwifiex_set_wpa_ie_helper(struct mwifiex_private *priv,
+                                     u8 *ie_data_ptr, u16 ie_len)
+{
+        if (ie_len) {
+                if (ie_len > sizeof(priv->wpa_ie)) {
+                        dev_err(priv->adapter->dev,
+                                "failed to copy WPA IE, too big\n");
+                        return -1;
+                }
+                memcpy(priv->wpa_ie, ie_data_ptr, ie_len);
+                priv->wpa_ie_len = (u8) ie_len;
+                dev_dbg(priv->adapter->dev, "cmd: Set Wpa_ie_len=%d IE=%#x\n",
+                                priv->wpa_ie_len, priv->wpa_ie[0]);
+                if (priv->wpa_ie[0] == WLAN_EID_WPA) {
+                        priv->sec_info.wpa_enabled = true;
+                } else if (priv->wpa_ie[0] == WLAN_EID_RSN) {
+                        priv->sec_info.wpa2_enabled = true;
+                } else {
+                        priv->sec_info.wpa_enabled = false;
+                        priv->sec_info.wpa2_enabled = false;
+                }
+        } else {
+                memset(priv->wpa_ie, 0, sizeof(priv->wpa_ie));
+                priv->wpa_ie_len = 0;
+                dev_dbg(priv->adapter->dev, "info: reset wpa_ie_len=%d IE=%#x\n",
+                        priv->wpa_ie_len, priv->wpa_ie[0]);
+                priv->sec_info.wpa_enabled = false;
+                priv->sec_info.wpa2_enabled = false;
+        }
+        return 0;
+}
+/*
+ * IOCTL request handler to set/reset WAPI IE.
+ *
+ * The supplied WAPI IE is treated as a opaque buffer. Only the first field
+ * is checked to internally enable WAPI. If buffer length is zero, the existing
+ * WAPI IE is reset.
+ */
+static int mwifiex_set_wapi_ie(struct mwifiex_private *priv,
+                               u8 *ie_data_ptr, u16 ie_len)
+{
+        if (ie_len) {
+                if (ie_len > sizeof(priv->wapi_ie)) {
+                        dev_dbg(priv->adapter->dev,
+                                "info: failed to copy WAPI IE, too big\n");
+                        return -1;
+                }
+                memcpy(priv->wapi_ie, ie_data_ptr, ie_len);
+                priv->wapi_ie_len = ie_len;
+                dev_dbg(priv->adapter->dev, "cmd: Set wapi_ie_len=%d IE=%#x\n",
+                                priv->wapi_ie_len, priv->wapi_ie[0]);
+                if (priv->wapi_ie[0] == WLAN_EID_BSS_AC_ACCESS_DELAY)
+                        priv->sec_info.wapi_enabled = true;
+        } else {
+                memset(priv->wapi_ie, 0, sizeof(priv->wapi_ie));
+                priv->wapi_ie_len = ie_len;
+                dev_dbg(priv->adapter->dev,
+                        "info: Reset wapi_ie_len=%d IE=%#x\n",
+                       priv->wapi_ie_len, priv->wapi_ie[0]);
+                priv->sec_info.wapi_enabled = false;
+        }
+        return 0;
+}
+/*
+ * IOCTL request handler to set WAPI key.
+ *
+ * This function prepares the correct firmware command and
+ * issues it.
+ */
+static int mwifiex_sec_ioctl_set_wapi_key(struct mwifiex_private *priv,
+                               struct mwifiex_ds_encrypt_key *encrypt_key)
+{
+        return mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_KEY_MATERIAL,
+                                    HostCmd_ACT_GEN_SET, KEY_INFO_ENABLED,
+                                    encrypt_key);
+}
+/*
+ * IOCTL request handler to set WEP network key.
+ *
+ * This function prepares the correct firmware command and
+ * issues it, after validation checks.
+ */
+static int mwifiex_sec_ioctl_set_wep_key(struct mwifiex_private *priv,
+                              struct mwifiex_ds_encrypt_key *encrypt_key)
+{
+        int ret;
+        struct mwifiex_wep_key *wep_key;
+        int index;
+        if (priv->wep_key_curr_index >= NUM_WEP_KEYS)
+                priv->wep_key_curr_index = 0;
+        wep_key = &priv->wep_key[priv->wep_key_curr_index];
+        index = encrypt_key->key_index;
+        if (encrypt_key->key_disable) {
+                priv->sec_info.wep_status = MWIFIEX_802_11_WEP_DISABLED;
+        } else if (!encrypt_key->key_len) {
+                /* Copy the required key as the current key */
+                wep_key = &priv->wep_key[index];
+                if (!wep_key->key_length) {
+                        dev_err(priv->adapter->dev,
+                                "key not set, so cannot enable it\n");
+                        return -1;
+                }
+                priv->wep_key_curr_index = (u16) index;
+                priv->sec_info.wep_status = MWIFIEX_802_11_WEP_ENABLED;
+        } else {
+                wep_key = &priv->wep_key[index];
+                memset(wep_key, 0, sizeof(struct mwifiex_wep_key));
+                /* Copy the key in the driver */
+                memcpy(wep_key->key_material,
+                       encrypt_key->key_material,
+                       encrypt_key->key_len);
+                wep_key->key_index = index;
+                wep_key->key_length = encrypt_key->key_len;
+                priv->sec_info.wep_status = MWIFIEX_802_11_WEP_ENABLED;
+        }
+        if (wep_key->key_length) {
+                /* Send request to firmware */
+                ret = mwifiex_send_cmd_async(priv,
+                                             HostCmd_CMD_802_11_KEY_MATERIAL,
+                                             HostCmd_ACT_GEN_SET, 0, NULL);
+                if (ret)
+                        return ret;
+        }
+        if (priv->sec_info.wep_status == MWIFIEX_802_11_WEP_ENABLED)
+                priv->curr_pkt_filter |= HostCmd_ACT_MAC_WEP_ENABLE;
+        else
+                priv->curr_pkt_filter &= ~HostCmd_ACT_MAC_WEP_ENABLE;
+        ret = mwifiex_send_cmd_sync(priv, HostCmd_CMD_MAC_CONTROL,
+                                    HostCmd_ACT_GEN_SET, 0,
+                                    &priv->curr_pkt_filter);
+        return ret;
+}
+/*
+ * IOCTL request handler to set WPA key.
+ *
+ * This function prepares the correct firmware command and
+ * issues it, after validation checks.
+ *
+ * Current driver only supports key length of up to 32 bytes.
+ *
+ * This function can also be used to disable a currently set key.
+ */
+static int mwifiex_sec_ioctl_set_wpa_key(struct mwifiex_private *priv,
+                              struct mwifiex_ds_encrypt_key *encrypt_key)
+{
+        int ret;
+        u8 remove_key = false;
+        struct host_cmd_ds_802_11_key_material *ibss_key;
+        /* Current driver only supports key length of up to 32 bytes */
+        if (encrypt_key->key_len > WLAN_MAX_KEY_LEN) {
+                dev_err(priv->adapter->dev, "key length too long\n");
+                return -1;
+        }
+        if (priv->bss_mode == NL80211_IFTYPE_ADHOC) {
+                /*
+                 * IBSS/WPA-None uses only one key (Group) for both receiving
+                 * and sending unicast and multicast packets.
+                 */
+                /* Send the key as PTK to firmware */
+                encrypt_key->key_index = MWIFIEX_KEY_INDEX_UNICAST;
+                ret = mwifiex_send_cmd_async(priv,
+                                        HostCmd_CMD_802_11_KEY_MATERIAL,
+                                        HostCmd_ACT_GEN_SET, KEY_INFO_ENABLED,
+                                        encrypt_key);
+                if (ret)
+                        return ret;
+                ibss_key = &priv->aes_key;
+                memset(ibss_key, 0,
+                       sizeof(struct host_cmd_ds_802_11_key_material));
+                /* Copy the key in the driver */
+                memcpy(ibss_key->key_param_set.key, encrypt_key->key_material,
+                       encrypt_key->key_len);
+                memcpy(&ibss_key->key_param_set.key_len, &encrypt_key->key_len,
+                       sizeof(ibss_key->key_param_set.key_len));
+                ibss_key->key_param_set.key_type_id
+                        = cpu_to_le16(KEY_TYPE_ID_TKIP);
+                ibss_key->key_param_set.key_info = cpu_to_le16(KEY_ENABLED);
+                /* Send the key as GTK to firmware */
+                encrypt_key->key_index = ~MWIFIEX_KEY_INDEX_UNICAST;
+        }
+        if (!encrypt_key->key_index)
+                encrypt_key->key_index = MWIFIEX_KEY_INDEX_UNICAST;
+        if (remove_key)
+                ret = mwifiex_send_cmd_sync(priv,
+                                       HostCmd_CMD_802_11_KEY_MATERIAL,
+                                       HostCmd_ACT_GEN_SET, !(KEY_INFO_ENABLED),
+                                       encrypt_key);
+        else
+                ret = mwifiex_send_cmd_sync(priv,
+                                        HostCmd_CMD_802_11_KEY_MATERIAL,
+                                        HostCmd_ACT_GEN_SET, KEY_INFO_ENABLED,
+                                        encrypt_key);
+        return ret;
+}
+/*
+ * IOCTL request handler to set/get network keys.
+ *
+ * This is a generic key handling function which supports WEP, WPA
+ * and WAPI.
+ */
+static int
+mwifiex_sec_ioctl_encrypt_key(struct mwifiex_private *priv,
+                              struct mwifiex_ds_encrypt_key *encrypt_key)
+{
+        int status;
+        if (encrypt_key->is_wapi_key)
+                status = mwifiex_sec_ioctl_set_wapi_key(priv, encrypt_key);
+        else if (encrypt_key->key_len > WLAN_KEY_LEN_WEP104)
+                status = mwifiex_sec_ioctl_set_wpa_key(priv, encrypt_key);
+        else
+                status = mwifiex_sec_ioctl_set_wep_key(priv, encrypt_key);
+        return status;
+}
+/*
+ * This function returns the driver version.
+ */
+int
+mwifiex_drv_get_driver_version(struct mwifiex_adapter *adapter, char *version,
+                               int max_len)
+{
+        union {
+                u32 l;
+                u8 c[4];
+        } ver;
+        char fw_ver[32];
+        ver.l = adapter->fw_release_number;
+        sprintf(fw_ver, "%u.%u.%u.p%u", ver.c[2], ver.c[1], ver.c[0], ver.c[3]);
+        snprintf(version, max_len, driver_version, fw_ver);
+        dev_dbg(adapter->dev, "info: MWIFIEX VERSION: %s\n", version);
+        return 0;
+}
+/*
+ * Sends IOCTL request to get signal information.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int mwifiex_get_signal_info(struct mwifiex_private *priv,
+                            struct mwifiex_ds_get_signal *signal)
+{
+        int status;
+        signal->selector = ALL_RSSI_INFO_MASK;
+        /* Signal info can be obtained only if connected */
+        if (!priv->media_connected) {
+                dev_dbg(priv->adapter->dev,
+                        "info: Can not get signal in disconnected state\n");
+                return -1;
+        }
+        status = mwifiex_send_cmd_sync(priv, HostCmd_CMD_RSSI_INFO,
+                                       HostCmd_ACT_GEN_GET, 0, signal);
+        if (!status) {
+                if (signal->selector & BCN_RSSI_AVG_MASK)
+                        priv->w_stats.qual.level = signal->bcn_rssi_avg;
+                if (signal->selector & BCN_NF_AVG_MASK)
+                        priv->w_stats.qual.noise = signal->bcn_nf_avg;
+        }
+        return status;
+}
+/*
+ * Sends IOCTL request to set encoding parameters.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int mwifiex_set_encode(struct mwifiex_private *priv, const u8 *key,
+                        int key_len, u8 key_index, int disable)
+{
+        struct mwifiex_ds_encrypt_key encrypt_key;
+        memset(&encrypt_key, 0, sizeof(struct mwifiex_ds_encrypt_key));
+        encrypt_key.key_len = key_len;
+        if (!disable) {
+                encrypt_key.key_index = key_index;
+                if (key_len)
+                        memcpy(encrypt_key.key_material, key, key_len);
+        } else {
+                encrypt_key.key_disable = true;
+        }
+        return mwifiex_sec_ioctl_encrypt_key(priv, &encrypt_key);
+}
+/*
+ * Sends IOCTL request to get extended version.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int
+mwifiex_get_ver_ext(struct mwifiex_private *priv)
+{
+        struct mwifiex_ver_ext ver_ext;
+        memset(&ver_ext, 0, sizeof(struct host_cmd_ds_version_ext));
+        if (mwifiex_send_cmd_sync(priv, HostCmd_CMD_VERSION_EXT,
+                                    HostCmd_ACT_GEN_GET, 0, &ver_ext))
+                return -1;
+        return 0;
+}
+/*
+ * Sends IOCTL request to get statistics information.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int
+mwifiex_get_stats_info(struct mwifiex_private *priv,
+                       struct mwifiex_ds_get_stats *log)
+{
+        int ret;
+        ret = mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_GET_LOG,
+                                    HostCmd_ACT_GEN_GET, 0, log);
+        if (!ret) {
+                priv->w_stats.discard.fragment = log->fcs_error;
+                priv->w_stats.discard.retries = log->retry;
+                priv->w_stats.discard.misc = log->ack_failure;
+        }
+        return ret;
+}
+/*
+ * IOCTL request handler to read/write register.
+ *
+ * This function prepares the correct firmware command and
+ * issues it.
+ *
+ * Access to the following registers are supported -
+ *      - MAC
+ *      - BBP
+ *      - RF
+ *      - PMIC
+ *      - CAU
+ */
+static int mwifiex_reg_mem_ioctl_reg_rw(struct mwifiex_private *priv,
+                                        struct mwifiex_ds_reg_rw *reg_rw,
+                                        u16 action)
+{
+        u16 cmd_no;
+        switch (le32_to_cpu(reg_rw->type)) {
+        case MWIFIEX_REG_MAC:
+                cmd_no = HostCmd_CMD_MAC_REG_ACCESS;
+                break;
+        case MWIFIEX_REG_BBP:
+                cmd_no = HostCmd_CMD_BBP_REG_ACCESS;
+                break;
+        case MWIFIEX_REG_RF:
+                cmd_no = HostCmd_CMD_RF_REG_ACCESS;
+                break;
+        case MWIFIEX_REG_PMIC:
+                cmd_no = HostCmd_CMD_PMIC_REG_ACCESS;
+                break;
+        case MWIFIEX_REG_CAU:
+                cmd_no = HostCmd_CMD_CAU_REG_ACCESS;
+                break;
+        default:
+                return -1;
+        }
+        return mwifiex_send_cmd_sync(priv, cmd_no, action, 0, reg_rw);
+}
+/*
+ * Sends IOCTL request to write to a register.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int
+mwifiex_reg_write(struct mwifiex_private *priv, u32 reg_type,
+                  u32 reg_offset, u32 reg_value)
+{
+        struct mwifiex_ds_reg_rw reg_rw;
+        reg_rw.type = cpu_to_le32(reg_type);
+        reg_rw.offset = cpu_to_le32(reg_offset);
+        reg_rw.value = cpu_to_le32(reg_value);
+        return mwifiex_reg_mem_ioctl_reg_rw(priv, &reg_rw, HostCmd_ACT_GEN_SET);
+}
+/*
+ * Sends IOCTL request to read from a register.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int
+mwifiex_reg_read(struct mwifiex_private *priv, u32 reg_type,
+                 u32 reg_offset, u32 *value)
+{
+        int ret;
+        struct mwifiex_ds_reg_rw reg_rw;
+        reg_rw.type = cpu_to_le32(reg_type);
+        reg_rw.offset = cpu_to_le32(reg_offset);
+        ret = mwifiex_reg_mem_ioctl_reg_rw(priv, &reg_rw, HostCmd_ACT_GEN_GET);
+        if (ret)
+                goto done;
+        *value = le32_to_cpu(reg_rw.value);
+done:
+        return ret;
+}
+/*
+ * Sends IOCTL request to read from EEPROM.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int
+mwifiex_eeprom_read(struct mwifiex_private *priv, u16 offset, u16 bytes,
+                    u8 *value)
+{
+        int ret;
+        struct mwifiex_ds_read_eeprom rd_eeprom;
+        rd_eeprom.offset = cpu_to_le16((u16) offset);
+        rd_eeprom.byte_count = cpu_to_le16((u16) bytes);
+        /* Send request to firmware */
+        ret = mwifiex_send_cmd_sync(priv, HostCmd_CMD_802_11_EEPROM_ACCESS,
+                                    HostCmd_ACT_GEN_GET, 0, &rd_eeprom);
+        if (!ret)
+                memcpy(value, rd_eeprom.value, MAX_EEPROM_DATA);
+        return ret;
+}
+/*
+ * This function sets a generic IE. In addition to generic IE, it can
+ * also handle WPA, WPA2 and WAPI IEs.
+ */
+static int
+mwifiex_set_gen_ie_helper(struct mwifiex_private *priv, u8 *ie_data_ptr,
+                          u16 ie_len)
+{
+        int ret = 0;
+        struct ieee_types_vendor_header *pvendor_ie;
+        const u8 wpa_oui[] = { 0x00, 0x50, 0xf2, 0x01 };
+        const u8 wps_oui[] = { 0x00, 0x50, 0xf2, 0x04 };
+        /* If the passed length is zero, reset the buffer */
+        if (!ie_len) {
+                priv->gen_ie_buf_len = 0;
+                priv->wps.session_enable = false;
+                return 0;
+        } else if (!ie_data_ptr) {
+                return -1;
+        }
+        pvendor_ie = (struct ieee_types_vendor_header *) ie_data_ptr;
+        /* Test to see if it is a WPA IE, if not, then it is a gen IE */
+        if (((pvendor_ie->element_id == WLAN_EID_WPA)
+             && (!memcmp(pvendor_ie->oui, wpa_oui, sizeof(wpa_oui))))
+                        || (pvendor_ie->element_id == WLAN_EID_RSN)) {
+                /* IE is a WPA/WPA2 IE so call set_wpa function */
+                ret = mwifiex_set_wpa_ie_helper(priv, ie_data_ptr, ie_len);
+                priv->wps.session_enable = false;
+                return ret;
+        } else if (pvendor_ie->element_id == WLAN_EID_BSS_AC_ACCESS_DELAY) {
+                /* IE is a WAPI IE so call set_wapi function */
+                ret = mwifiex_set_wapi_ie(priv, ie_data_ptr, ie_len);
+                return ret;
+        }
+        /*
+         * Verify that the passed length is not larger than the
+         * available space remaining in the buffer
+         */
+        if (ie_len < (sizeof(priv->gen_ie_buf) - priv->gen_ie_buf_len)) {
+                /* Test to see if it is a WPS IE, if so, enable
+                 * wps session flag
+                 */
+                pvendor_ie = (struct ieee_types_vendor_header *) ie_data_ptr;
+                if ((pvendor_ie->element_id == WLAN_EID_VENDOR_SPECIFIC)
+                                && (!memcmp(pvendor_ie->oui, wps_oui,
+                                                sizeof(wps_oui)))) {
+                        priv->wps.session_enable = true;
+                        dev_dbg(priv->adapter->dev,
+                                "info: WPS Session Enabled.\n");
+                }
+                /* Append the passed data to the end of the
+                   genIeBuffer */
+                memcpy(priv->gen_ie_buf + priv->gen_ie_buf_len, ie_data_ptr,
+                                                                        ie_len);
+                /* Increment the stored buffer length by the
+                   size passed */
+                priv->gen_ie_buf_len += ie_len;
+        } else {
+                /* Passed data does not fit in the remaining
+                   buffer space */
+                ret = -1;
+        }
+        /* Return 0, or -1 for error case */
+        return ret;
+}
+/*
+ * IOCTL request handler to set/get generic IE.
+ *
+ * In addition to various generic IEs, this function can also be
+ * used to set the ARP filter.
+ */
+static int mwifiex_misc_ioctl_gen_ie(struct mwifiex_private *priv,
+                                     struct mwifiex_ds_misc_gen_ie *gen_ie,
+                                     u16 action)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        switch (gen_ie->type) {
+        case MWIFIEX_IE_TYPE_GEN_IE:
+                if (action == HostCmd_ACT_GEN_GET) {
+                        gen_ie->len = priv->wpa_ie_len;
+                        memcpy(gen_ie->ie_data, priv->wpa_ie, gen_ie->len);
+                } else {
+                        mwifiex_set_gen_ie_helper(priv, gen_ie->ie_data,
+                                                  (u16) gen_ie->len);
+                }
+                break;
+        case MWIFIEX_IE_TYPE_ARP_FILTER:
+                memset(adapter->arp_filter, 0, sizeof(adapter->arp_filter));
+                if (gen_ie->len > ARP_FILTER_MAX_BUF_SIZE) {
+                        adapter->arp_filter_size = 0;
+                        dev_err(adapter->dev, "invalid ARP filter size\n");
+                        return -1;
+                } else {
+                        memcpy(adapter->arp_filter, gen_ie->ie_data,
+                                                                gen_ie->len);
+                        adapter->arp_filter_size = gen_ie->len;
+                }
+                break;
+        default:
+                dev_err(adapter->dev, "invalid IE type\n");
+                return -1;
+        }
+        return 0;
+}
+/*
+ * Sends IOCTL request to set a generic IE.
+ *
+ * This function allocates the IOCTL request buffer, fills it
+ * with requisite parameters and calls the IOCTL handler.
+ */
+int
+mwifiex_set_gen_ie(struct mwifiex_private *priv, u8 *ie, int ie_len)
+{
+        struct mwifiex_ds_misc_gen_ie gen_ie;
+        if (ie_len > IW_CUSTOM_MAX)
+                return -EFAULT;
+        gen_ie.type = MWIFIEX_IE_TYPE_GEN_IE;
+        gen_ie.len = ie_len;
+        memcpy(gen_ie.ie_data, ie, ie_len);
+        if (mwifiex_misc_ioctl_gen_ie(priv, &gen_ie, HostCmd_ACT_GEN_SET))
+                return -EFAULT;
+        return 0;
+}
diff --git a/drivers/net/wireless/mwifiex/sta_rx.c b/drivers/net/wireless/mwifiex/sta_rx.c
new file mode 100644
index 000000000000..1fdddece7479
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/sta_rx.c
@@ -0,0 +1,200 @@
+/*
+ * Marvell Wireless LAN device driver: station RX data handling
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "11n_aggr.h"
+#include "11n_rxreorder.h"
+/*
+ * This function processes the received packet and forwards it
+ * to kernel/upper layer.
+ *
+ * This function parses through the received packet and determines
+ * if it is a debug packet or normal packet.
+ *
+ * For non-debug packets, the function chops off unnecessary leading
+ * header bytes, reconstructs the packet as an ethernet frame or
+ * 802.2/llc/snap frame as required, and sends it to kernel/upper layer.
+ *
+ * The completion callback is called after processing in complete.
+ */
+int mwifiex_process_rx_packet(struct mwifiex_adapter *adapter,
+                              struct sk_buff *skb)
+{
+        int ret;
+        struct mwifiex_rxinfo *rx_info = MWIFIEX_SKB_RXCB(skb);
+        struct mwifiex_private *priv = adapter->priv[rx_info->bss_index];
+        struct rx_packet_hdr *rx_pkt_hdr;
+        struct rxpd *local_rx_pd;
+        int hdr_chop;
+        struct ethhdr *eth_hdr;
+        u8 rfc1042_eth_hdr[ETH_ALEN] = { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 };
+        local_rx_pd = (struct rxpd *) (skb->data);
+        rx_pkt_hdr = (struct rx_packet_hdr *) ((u8 *) local_rx_pd +
+                                local_rx_pd->rx_pkt_offset);
+        if (!memcmp(&rx_pkt_hdr->rfc1042_hdr,
+                    rfc1042_eth_hdr, sizeof(rfc1042_eth_hdr))) {
+                /*
+                 *  Replace the 803 header and rfc1042 header (llc/snap) with an
+                 *    EthernetII header, keep the src/dst and snap_type
+                 *    (ethertype).
+                 *  The firmware only passes up SNAP frames converting
+                 *    all RX Data from 802.11 to 802.2/LLC/SNAP frames.
+                 *  To create the Ethernet II, just move the src, dst address
+                 *    right before the snap_type.
+                 */
+                eth_hdr = (struct ethhdr *)
+                        ((u8 *) &rx_pkt_hdr->eth803_hdr
+                         + sizeof(rx_pkt_hdr->eth803_hdr) +
+                         sizeof(rx_pkt_hdr->rfc1042_hdr)
+                         - sizeof(rx_pkt_hdr->eth803_hdr.h_dest)
+                         - sizeof(rx_pkt_hdr->eth803_hdr.h_source)
+                         - sizeof(rx_pkt_hdr->rfc1042_hdr.snap_type));
+                memcpy(eth_hdr->h_source, rx_pkt_hdr->eth803_hdr.h_source,
+                       sizeof(eth_hdr->h_source));
+                memcpy(eth_hdr->h_dest, rx_pkt_hdr->eth803_hdr.h_dest,
+                       sizeof(eth_hdr->h_dest));
+                /* Chop off the rxpd + the excess memory from the 802.2/llc/snap
+                   header that was removed. */
+                hdr_chop = (u8 *) eth_hdr - (u8 *) local_rx_pd;
+        } else {
+                /* Chop off the rxpd */
+                hdr_chop = (u8 *) &rx_pkt_hdr->eth803_hdr -
+                        (u8 *) local_rx_pd;
+        }
+        /* Chop off the leading header bytes so the it points to the start of
+           either the reconstructed EthII frame or the 802.2/llc/snap frame */
+        skb_pull(skb, hdr_chop);
+        priv->rxpd_rate = local_rx_pd->rx_rate;
+        priv->rxpd_htinfo = local_rx_pd->ht_info;
+        ret = mwifiex_recv_packet(adapter, skb);
+        if (ret == -1)
+                dev_err(adapter->dev, "recv packet failed\n");
+        return ret;
+}
+/*
+ * This function processes the received buffer.
+ *
+ * The function looks into the RxPD and performs sanity tests on the
+ * received buffer to ensure its a valid packet, before processing it
+ * further. If the packet is determined to be aggregated, it is
+ * de-aggregated accordingly. Non-unicast packets are sent directly to
+ * the kernel/upper layers. Unicast packets are handed over to the
+ * Rx reordering routine if 11n is enabled.
+ *
+ * The completion callback is called after processing in complete.
+ */
+int mwifiex_process_sta_rx_packet(struct mwifiex_adapter *adapter,
+                                  struct sk_buff *skb)
+{
+        int ret = 0;
+        struct rxpd *local_rx_pd;
+        struct mwifiex_rxinfo *rx_info = MWIFIEX_SKB_RXCB(skb);
+        struct rx_packet_hdr *rx_pkt_hdr;
+        u8 ta[ETH_ALEN];
+        u16 rx_pkt_type;
+        struct mwifiex_private *priv = adapter->priv[rx_info->bss_index];
+        local_rx_pd = (struct rxpd *) (skb->data);
+        rx_pkt_type = local_rx_pd->rx_pkt_type;
+        rx_pkt_hdr = (struct rx_packet_hdr *) ((u8 *) local_rx_pd +
+                                        local_rx_pd->rx_pkt_offset);
+        if ((local_rx_pd->rx_pkt_offset + local_rx_pd->rx_pkt_length) >
+            (u16) skb->len) {
+                dev_err(adapter->dev, "wrong rx packet: len=%d,"
+                        " rx_pkt_offset=%d, rx_pkt_length=%d\n", skb->len,
+                       local_rx_pd->rx_pkt_offset, local_rx_pd->rx_pkt_length);
+                priv->stats.rx_dropped++;
+                dev_kfree_skb_any(skb);
+                return ret;
+        }
+        if (local_rx_pd->rx_pkt_type == PKT_TYPE_AMSDU) {
+                struct sk_buff_head list;
+                struct sk_buff *rx_skb;
+                __skb_queue_head_init(&list);
+                skb_pull(skb, local_rx_pd->rx_pkt_offset);
+                skb_trim(skb, local_rx_pd->rx_pkt_length);
+                ieee80211_amsdu_to_8023s(skb, &list, priv->curr_addr,
+                                priv->wdev->iftype, 0, false);
+                while (!skb_queue_empty(&list)) {
+                        rx_skb = __skb_dequeue(&list);
+                        ret = mwifiex_recv_packet(adapter, rx_skb);
+                        if (ret == -1)
+                                dev_err(adapter->dev, "Rx of A-MSDU failed");
+                }
+                return 0;
+        }
+        /*
+         * If the packet is not an unicast packet then send the packet
+         * directly to os. Don't pass thru rx reordering
+         */
+        if (!IS_11N_ENABLED(priv) ||
+            memcmp(priv->curr_addr, rx_pkt_hdr->eth803_hdr.h_dest, ETH_ALEN)) {
+                mwifiex_process_rx_packet(adapter, skb);
+                return ret;
+        }
+        if (mwifiex_queuing_ra_based(priv)) {
+                memcpy(ta, rx_pkt_hdr->eth803_hdr.h_source, ETH_ALEN);
+        } else {
+                if (rx_pkt_type != PKT_TYPE_BAR)
+                        priv->rx_seq[local_rx_pd->priority] =
+                                                local_rx_pd->seq_num;
+                memcpy(ta, priv->curr_bss_params.bss_descriptor.mac_address,
+                       ETH_ALEN);
+        }
+        /* Reorder and send to OS */
+        ret = mwifiex_11n_rx_reorder_pkt(priv, local_rx_pd->seq_num,
+                                             local_rx_pd->priority, ta,
+                                             (u8) local_rx_pd->rx_pkt_type,
+                                                (void *) skb);
+        if (ret || (rx_pkt_type == PKT_TYPE_BAR)) {
+                if (priv && (ret == -1))
+                        priv->stats.rx_dropped++;
+                dev_kfree_skb_any(skb);
+        }
+        return ret;
+}
diff --git a/drivers/net/wireless/mwifiex/sta_tx.c b/drivers/net/wireless/mwifiex/sta_tx.c
new file mode 100644
index 000000000000..fa6221bc9104
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/sta_tx.c
@@ -0,0 +1,198 @@
+/*
+ * Marvell Wireless LAN device driver: station TX data handling
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+/*
+ * This function fills the TxPD for tx packets.
+ *
+ * The Tx buffer received by this function should already have the
+ * header space allocated for TxPD.
+ *
+ * This function inserts the TxPD in between interface header and actual
+ * data and adjusts the buffer pointers accordingly.
+ *
+ * The following TxPD fields are set by this function, as required -
+ *      - BSS number
+ *      - Tx packet length and offset
+ *      - Priority
+ *      - Packet delay
+ *      - Priority specific Tx control
+ *      - Flags
+ */
+void *mwifiex_process_sta_txpd(struct mwifiex_private *priv,
+                                struct sk_buff *skb)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct txpd *local_tx_pd;
+        struct mwifiex_txinfo *tx_info = MWIFIEX_SKB_TXCB(skb);
+        if (!skb->len) {
+                dev_err(adapter->dev, "Tx: bad packet length: %d\n",
+                       skb->len);
+                tx_info->status_code = -1;
+                return skb->data;
+        }
+        BUG_ON(skb_headroom(skb) < (sizeof(*local_tx_pd) + INTF_HEADER_LEN));
+        skb_push(skb, sizeof(*local_tx_pd));
+        local_tx_pd = (struct txpd *) skb->data;
+        memset(local_tx_pd, 0, sizeof(struct txpd));
+        local_tx_pd->bss_num = priv->bss_num;
+        local_tx_pd->bss_type = priv->bss_type;
+        local_tx_pd->tx_pkt_length = cpu_to_le16((u16) (skb->len -
+                                                        sizeof(struct txpd)));
+        local_tx_pd->priority = (u8) skb->priority;
+        local_tx_pd->pkt_delay_2ms =
+                mwifiex_wmm_compute_drv_pkt_delay(priv, skb);
+        if (local_tx_pd->priority <
+            ARRAY_SIZE(priv->wmm.user_pri_pkt_tx_ctrl))
+                /*
+                 * Set the priority specific tx_control field, setting of 0 will
+                 *   cause the default value to be used later in this function
+                 */
+                local_tx_pd->tx_control =
+                        cpu_to_le32(priv->wmm.user_pri_pkt_tx_ctrl[local_tx_pd->
+                                                         priority]);
+        if (adapter->pps_uapsd_mode) {
+                if (mwifiex_check_last_packet_indication(priv)) {
+                        adapter->tx_lock_flag = true;
+                        local_tx_pd->flags =
+                                MWIFIEX_TxPD_POWER_MGMT_LAST_PACKET;
+                }
+        }
+        /* Offset of actual data */
+        local_tx_pd->tx_pkt_offset = cpu_to_le16(sizeof(struct txpd));
+        /* make space for INTF_HEADER_LEN */
+        skb_push(skb, INTF_HEADER_LEN);
+        if (!local_tx_pd->tx_control)
+                /* TxCtrl set by user or default */
+                local_tx_pd->tx_control = cpu_to_le32(priv->pkt_tx_ctrl);
+        return skb->data;
+}
+/*
+ * This function tells firmware to send a NULL data packet.
+ *
+ * The function creates a NULL data packet with TxPD and sends to the
+ * firmware for transmission, with highest priority setting.
+ */
+int mwifiex_send_null_packet(struct mwifiex_private *priv, u8 flags)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct txpd *local_tx_pd;
+/* sizeof(struct txpd) + Interface specific header */
+#define NULL_PACKET_HDR 64
+        u32 data_len = NULL_PACKET_HDR;
+        struct sk_buff *skb;
+        int ret;
+        struct mwifiex_txinfo *tx_info = NULL;
+        if (adapter->surprise_removed)
+                return -1;
+        if (!priv->media_connected)
+                return -1;
+        if (adapter->data_sent)
+                return -1;
+        skb = dev_alloc_skb(data_len);
+        if (!skb)
+                return -1;
+        tx_info = MWIFIEX_SKB_TXCB(skb);
+        tx_info->bss_index = priv->bss_index;
+        skb_reserve(skb, sizeof(struct txpd) + INTF_HEADER_LEN);
+        skb_push(skb, sizeof(struct txpd));
+        local_tx_pd = (struct txpd *) skb->data;
+        local_tx_pd->tx_control = cpu_to_le32(priv->pkt_tx_ctrl);
+        local_tx_pd->flags = flags;
+        local_tx_pd->priority = WMM_HIGHEST_PRIORITY;
+        local_tx_pd->tx_pkt_offset = cpu_to_le16(sizeof(struct txpd));
+        local_tx_pd->bss_num = priv->bss_num;
+        local_tx_pd->bss_type = priv->bss_type;
+        skb_push(skb, INTF_HEADER_LEN);
+        ret = adapter->if_ops.host_to_card(adapter, MWIFIEX_TYPE_DATA,
+                                             skb->data, skb->len, NULL);
+        switch (ret) {
+        case -EBUSY:
+                adapter->data_sent = true;
+                /* Fall through FAILURE handling */
+        case -1:
+                dev_kfree_skb_any(skb);
+                dev_err(adapter->dev, "%s: host_to_card failed: ret=%d\n",
+                                                __func__, ret);
+                adapter->dbg.num_tx_host_to_card_failure++;
+                break;
+        case 0:
+                dev_kfree_skb_any(skb);
+                dev_dbg(adapter->dev, "data: %s: host_to_card succeeded\n",
+                                                __func__);
+                adapter->tx_lock_flag = true;
+                break;
+        case -EINPROGRESS:
+                break;
+        default:
+                break;
+        }
+        return ret;
+}
+/*
+ * This function checks if we need to send last packet indication.
+ */
+u8
+mwifiex_check_last_packet_indication(struct mwifiex_private *priv)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        u8 ret = false;
+        if (!adapter->sleep_period.period)
+                return ret;
+        if (mwifiex_wmm_lists_empty(adapter))
+                        ret = true;
+        if (ret && !adapter->cmd_sent && !adapter->curr_cmd
+            && !is_command_pending(adapter)) {
+                adapter->delay_null_pkt = false;
+                ret = true;
+        } else {
+                ret = false;
+                adapter->delay_null_pkt = true;
+        }
+        return ret;
+}
diff --git a/drivers/net/wireless/mwifiex/txrx.c b/drivers/net/wireless/mwifiex/txrx.c
new file mode 100644
index 000000000000..210120889dfe
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/txrx.c
@@ -0,0 +1,200 @@
+/*
+ * Marvell Wireless LAN device driver: generic TX/RX data handling
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+/*
+ * This function processes the received buffer.
+ *
+ * Main responsibility of this function is to parse the RxPD to
+ * identify the correct interface this packet is headed for and
+ * forwarding it to the associated handling function, where the
+ * packet will be further processed and sent to kernel/upper layer
+ * if required.
+ */
+int mwifiex_handle_rx_packet(struct mwifiex_adapter *adapter,
+                             struct sk_buff *skb)
+{
+        struct mwifiex_private *priv =
+                mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+        struct rxpd *local_rx_pd;
+        struct mwifiex_rxinfo *rx_info = MWIFIEX_SKB_RXCB(skb);
+        local_rx_pd = (struct rxpd *) (skb->data);
+        /* Get the BSS number from rxpd, get corresponding priv */
+        priv = mwifiex_get_priv_by_id(adapter, local_rx_pd->bss_num &
+                                      BSS_NUM_MASK, local_rx_pd->bss_type);
+        if (!priv)
+                priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+        rx_info->bss_index = priv->bss_index;
+        return mwifiex_process_sta_rx_packet(adapter, skb);
+}
+EXPORT_SYMBOL_GPL(mwifiex_handle_rx_packet);
+/*
+ * This function sends a packet to device.
+ *
+ * It processes the packet to add the TxPD, checks condition and
+ * sends the processed packet to firmware for transmission.
+ *
+ * On successful completion, the function calls the completion callback
+ * and logs the time.
+ */
+int mwifiex_process_tx(struct mwifiex_private *priv, struct sk_buff *skb,
+                       struct mwifiex_tx_param *tx_param)
+{
+        int ret = -1;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        u8 *head_ptr;
+        struct txpd *local_tx_pd = NULL;
+        head_ptr = (u8 *) mwifiex_process_sta_txpd(priv, skb);
+        if (head_ptr) {
+                if (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA)
+                        local_tx_pd =
+                                (struct txpd *) (head_ptr + INTF_HEADER_LEN);
+                ret = adapter->if_ops.host_to_card(adapter, MWIFIEX_TYPE_DATA,
+                                             skb->data, skb->len, tx_param);
+        }
+        switch (ret) {
+        case -EBUSY:
+                if ((GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_STA) &&
+                        (adapter->pps_uapsd_mode) &&
+                        (adapter->tx_lock_flag)) {
+                                priv->adapter->tx_lock_flag = false;
+                                local_tx_pd->flags = 0;
+                }
+                dev_dbg(adapter->dev, "data: -EBUSY is returned\n");
+                break;
+        case -1:
+                adapter->data_sent = false;
+                dev_err(adapter->dev, "mwifiex_write_data_async failed: 0x%X\n",
+                       ret);
+                adapter->dbg.num_tx_host_to_card_failure++;
+                mwifiex_write_data_complete(adapter, skb, ret);
+                break;
+        case -EINPROGRESS:
+                adapter->data_sent = false;
+                break;
+        case 0:
+                mwifiex_write_data_complete(adapter, skb, ret);
+                break;
+        default:
+                break;
+        }
+        return ret;
+}
+/*
+ * Packet send completion callback handler.
+ *
+ * It either frees the buffer directly or forwards it to another
+ * completion callback which checks conditions, updates statistics,
+ * wakes up stalled traffic queue if required, and then frees the buffer.
+ */
+int mwifiex_write_data_complete(struct mwifiex_adapter *adapter,
+                                struct sk_buff *skb, int status)
+{
+        struct mwifiex_private *priv, *tpriv;
+        struct mwifiex_txinfo *tx_info;
+        int i;
+        if (!skb)
+                return 0;
+        tx_info = MWIFIEX_SKB_TXCB(skb);
+        priv = mwifiex_bss_index_to_priv(adapter, tx_info->bss_index);
+        if (!priv)
+                goto done;
+        priv->netdev->trans_start = jiffies;
+        if (!status) {
+                priv->stats.tx_packets++;
+                priv->stats.tx_bytes += skb->len;
+        } else {
+                priv->stats.tx_errors++;
+        }
+        atomic_dec(&adapter->tx_pending);
+        for (i = 0; i < adapter->priv_num; i++) {
+                tpriv = adapter->priv[i];
+                if ((GET_BSS_ROLE(tpriv) == MWIFIEX_BSS_ROLE_STA)
+                                && (tpriv->media_connected)) {
+                        if (netif_queue_stopped(tpriv->netdev))
+                                netif_wake_queue(tpriv->netdev);
+                }
+        }
+done:
+        dev_kfree_skb_any(skb);
+        return 0;
+}
+/*
+ * Packet receive completion callback handler.
+ *
+ * This function calls another completion callback handler which
+ * updates the statistics, and optionally updates the parent buffer
+ * use count before freeing the received packet.
+ */
+int mwifiex_recv_packet_complete(struct mwifiex_adapter *adapter,
+                                 struct sk_buff *skb, int status)
+{
+        struct mwifiex_rxinfo *rx_info = MWIFIEX_SKB_RXCB(skb);
+        struct mwifiex_rxinfo *rx_info_parent;
+        struct mwifiex_private *priv;
+        struct sk_buff *skb_parent;
+        unsigned long flags;
+        priv = adapter->priv[rx_info->bss_index];
+        if (priv && (status == -1))
+                priv->stats.rx_dropped++;
+        if (rx_info->parent) {
+                skb_parent = rx_info->parent;
+                rx_info_parent = MWIFIEX_SKB_RXCB(skb_parent);
+                spin_lock_irqsave(&priv->rx_pkt_lock, flags);
+                --rx_info_parent->use_count;
+                if (!rx_info_parent->use_count) {
+                        spin_unlock_irqrestore(&priv->rx_pkt_lock, flags);
+                        dev_kfree_skb_any(skb_parent);
+                } else {
+                        spin_unlock_irqrestore(&priv->rx_pkt_lock, flags);
+                }
+        } else {
+                dev_kfree_skb_any(skb);
+        }
+        return 0;
+}
diff --git a/drivers/net/wireless/mwifiex/util.c b/drivers/net/wireless/mwifiex/util.c
new file mode 100644
index 000000000000..d41291529bc0
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/util.c
@@ -0,0 +1,202 @@
+/*
+ * Marvell Wireless LAN device driver: utility functions
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+/*
+ * Firmware initialization complete callback handler.
+ *
+ * This function wakes up the function waiting on the init
+ * wait queue for the firmware initialization to complete.
+ */
+int mwifiex_init_fw_complete(struct mwifiex_adapter *adapter)
+{
+        adapter->init_wait_q_woken = true;
+        wake_up_interruptible(&adapter->init_wait_q);
+        return 0;
+}
+/*
+ * Firmware shutdown complete callback handler.
+ *
+ * This function sets the hardware status to not ready and wakes up
+ * the function waiting on the init wait queue for the firmware
+ * shutdown to complete.
+ */
+int mwifiex_shutdown_fw_complete(struct mwifiex_adapter *adapter)
+{
+        adapter->hw_status = MWIFIEX_HW_STATUS_NOT_READY;
+        adapter->init_wait_q_woken = true;
+        wake_up_interruptible(&adapter->init_wait_q);
+        return 0;
+}
+/*
+ * This function sends init/shutdown command
+ * to firmware.
+ */
+int mwifiex_init_shutdown_fw(struct mwifiex_private *priv,
+                             u32 func_init_shutdown)
+{
+        u16 cmd;
+        if (func_init_shutdown == MWIFIEX_FUNC_INIT) {
+                cmd = HostCmd_CMD_FUNC_INIT;
+        } else if (func_init_shutdown == MWIFIEX_FUNC_SHUTDOWN) {
+                cmd = HostCmd_CMD_FUNC_SHUTDOWN;
+        } else {
+                dev_err(priv->adapter->dev, "unsupported parameter\n");
+                return -1;
+        }
+        return mwifiex_send_cmd_sync(priv, cmd, HostCmd_ACT_GEN_SET, 0, NULL);
+}
+EXPORT_SYMBOL_GPL(mwifiex_init_shutdown_fw);
+/*
+ * IOCTL request handler to set/get debug information.
+ *
+ * This function collates/sets the information from/to different driver
+ * structures.
+ */
+int mwifiex_get_debug_info(struct mwifiex_private *priv,
+                           struct mwifiex_debug_info *info)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        if (info) {
+                memcpy(info->packets_out,
+                       priv->wmm.packets_out,
+                       sizeof(priv->wmm.packets_out));
+                info->max_tx_buf_size = (u32) adapter->max_tx_buf_size;
+                info->tx_buf_size = (u32) adapter->tx_buf_size;
+                info->rx_tbl_num = mwifiex_get_rx_reorder_tbl(
+                                        priv, info->rx_tbl);
+                info->tx_tbl_num = mwifiex_get_tx_ba_stream_tbl(
+                                        priv, info->tx_tbl);
+                info->ps_mode = adapter->ps_mode;
+                info->ps_state = adapter->ps_state;
+                info->is_deep_sleep = adapter->is_deep_sleep;
+                info->pm_wakeup_card_req = adapter->pm_wakeup_card_req;
+                info->pm_wakeup_fw_try = adapter->pm_wakeup_fw_try;
+                info->is_hs_configured = adapter->is_hs_configured;
+                info->hs_activated = adapter->hs_activated;
+                info->num_cmd_host_to_card_failure
+                        = adapter->dbg.num_cmd_host_to_card_failure;
+                info->num_cmd_sleep_cfm_host_to_card_failure
+                        = adapter->dbg.num_cmd_sleep_cfm_host_to_card_failure;
+                info->num_tx_host_to_card_failure
+                        = adapter->dbg.num_tx_host_to_card_failure;
+                info->num_event_deauth = adapter->dbg.num_event_deauth;
+                info->num_event_disassoc = adapter->dbg.num_event_disassoc;
+                info->num_event_link_lost = adapter->dbg.num_event_link_lost;
+                info->num_cmd_deauth = adapter->dbg.num_cmd_deauth;
+                info->num_cmd_assoc_success =
+                        adapter->dbg.num_cmd_assoc_success;
+                info->num_cmd_assoc_failure =
+                        adapter->dbg.num_cmd_assoc_failure;
+                info->num_tx_timeout = adapter->dbg.num_tx_timeout;
+                info->num_cmd_timeout = adapter->dbg.num_cmd_timeout;
+                info->timeout_cmd_id = adapter->dbg.timeout_cmd_id;
+                info->timeout_cmd_act = adapter->dbg.timeout_cmd_act;
+                memcpy(info->last_cmd_id, adapter->dbg.last_cmd_id,
+                       sizeof(adapter->dbg.last_cmd_id));
+                memcpy(info->last_cmd_act, adapter->dbg.last_cmd_act,
+                       sizeof(adapter->dbg.last_cmd_act));
+                info->last_cmd_index = adapter->dbg.last_cmd_index;
+                memcpy(info->last_cmd_resp_id, adapter->dbg.last_cmd_resp_id,
+                       sizeof(adapter->dbg.last_cmd_resp_id));
+                info->last_cmd_resp_index = adapter->dbg.last_cmd_resp_index;
+                memcpy(info->last_event, adapter->dbg.last_event,
+                       sizeof(adapter->dbg.last_event));
+                info->last_event_index = adapter->dbg.last_event_index;
+                info->data_sent = adapter->data_sent;
+                info->cmd_sent = adapter->cmd_sent;
+                info->cmd_resp_received = adapter->cmd_resp_received;
+        }
+        return 0;
+}
+/*
+ * This function processes the received packet before sending it to the
+ * kernel.
+ *
+ * It extracts the SKB from the received buffer and sends it to kernel.
+ * In case the received buffer does not contain the data in SKB format,
+ * the function creates a blank SKB, fills it with the data from the
+ * received buffer and then sends this new SKB to the kernel.
+ */
+int mwifiex_recv_packet(struct mwifiex_adapter *adapter, struct sk_buff *skb)
+{
+        struct mwifiex_rxinfo *rx_info;
+        struct mwifiex_private *priv;
+        if (!skb)
+                return -1;
+        rx_info = MWIFIEX_SKB_RXCB(skb);
+        priv = mwifiex_bss_index_to_priv(adapter, rx_info->bss_index);
+        if (!priv)
+                return -1;
+        skb->dev = priv->netdev;
+        skb->protocol = eth_type_trans(skb, priv->netdev);
+        skb->ip_summed = CHECKSUM_NONE;
+        priv->stats.rx_bytes += skb->len;
+        priv->stats.rx_packets++;
+        if (in_interrupt())
+                netif_rx(skb);
+        else
+                netif_rx_ni(skb);
+        return 0;
+}
+/*
+ * IOCTL completion callback handler.
+ *
+ * This function is called when a pending IOCTL is completed.
+ *
+ * If work queue support is enabled, the function wakes up the
+ * corresponding waiting function. Otherwise, it processes the
+ * IOCTL response and frees the response buffer.
+ */
+int mwifiex_complete_cmd(struct mwifiex_adapter *adapter)
+{
+        atomic_dec(&adapter->cmd_pending);
+        dev_dbg(adapter->dev, "cmd completed: status=%d\n",
+                                        adapter->cmd_wait_q.status);
+        adapter->cmd_wait_q.condition = true;
+        if (adapter->cmd_wait_q.status == -ETIMEDOUT)
+                dev_err(adapter->dev, "cmd timeout\n");
+        else
+                wake_up_interruptible(&adapter->cmd_wait_q.wait);
+        return 0;
+}
diff --git a/drivers/net/wireless/mwifiex/util.h b/drivers/net/wireless/mwifiex/util.h
new file mode 100644
index 000000000000..9506afc6c0e4
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/util.h
@@ -0,0 +1,32 @@
+/*
+ * Marvell Wireless LAN device driver: utility functions
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef _MWIFIEX_UTIL_H_
+#define _MWIFIEX_UTIL_H_
+static inline struct mwifiex_rxinfo *MWIFIEX_SKB_RXCB(struct sk_buff *skb)
+{
+        return (struct mwifiex_rxinfo *)skb->cb;
+}
+static inline struct mwifiex_txinfo *MWIFIEX_SKB_TXCB(struct sk_buff *skb)
+{
+        return (struct mwifiex_txinfo *)skb->cb;
+}
+#endif /* !_MWIFIEX_UTIL_H_ */
diff --git a/drivers/net/wireless/mwifiex/wmm.c b/drivers/net/wireless/mwifiex/wmm.c
new file mode 100644
index 000000000000..faa09e32902e
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/wmm.c
@@ -0,0 +1,1231 @@
+/*
+ * Marvell Wireless LAN device driver: WMM
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#include "decl.h"
+#include "ioctl.h"
+#include "util.h"
+#include "fw.h"
+#include "main.h"
+#include "wmm.h"
+#include "11n.h"
+/* Maximum value FW can accept for driver delay in packet transmission */
+#define DRV_PKT_DELAY_TO_FW_MAX   512
+#define WMM_QUEUED_PACKET_LOWER_LIMIT   180
+#define WMM_QUEUED_PACKET_UPPER_LIMIT   200
+/* Offset for TOS field in the IP header */
+#define IPTOS_OFFSET 5
+/* WMM information IE */
+static const u8 wmm_info_ie[] = { WLAN_EID_VENDOR_SPECIFIC, 0x07,
+        0x00, 0x50, 0xf2, 0x02,
+        0x00, 0x01, 0x00
+};
+static const u8 wmm_aci_to_qidx_map[] = { WMM_AC_BE,
+        WMM_AC_BK,
+        WMM_AC_VI,
+        WMM_AC_VO
+};
+static u8 tos_to_tid[] = {
+        /* TID DSCP_P2 DSCP_P1 DSCP_P0 WMM_AC */
+        0x01,                   /* 0 1 0 AC_BK */
+        0x02,                   /* 0 0 0 AC_BK */
+        0x00,                   /* 0 0 1 AC_BE */
+        0x03,                   /* 0 1 1 AC_BE */
+        0x04,                   /* 1 0 0 AC_VI */
+        0x05,                   /* 1 0 1 AC_VI */
+        0x06,                   /* 1 1 0 AC_VO */
+        0x07                    /* 1 1 1 AC_VO */
+};
+/*
+ * This table inverses the tos_to_tid operation to get a priority
+ * which is in sequential order, and can be compared.
+ * Use this to compare the priority of two different TIDs.
+ */
+static u8 tos_to_tid_inv[] = {
+        0x02,  /* from tos_to_tid[2] = 0 */
+        0x00,  /* from tos_to_tid[0] = 1 */
+        0x01,  /* from tos_to_tid[1] = 2 */
+        0x03,
+        0x04,
+        0x05,
+        0x06,
+        0x07};
+static u8 ac_to_tid[4][2] = { {1, 2}, {0, 3}, {4, 5}, {6, 7} };
+/*
+ * This function debug prints the priority parameters for a WMM AC.
+ */
+static void
+mwifiex_wmm_ac_debug_print(const struct ieee_types_wmm_ac_parameters *ac_param)
+{
+        const char *ac_str[] = { "BK", "BE", "VI", "VO" };
+        pr_debug("info: WMM AC_%s: ACI=%d, ACM=%d, Aifsn=%d, "
+               "EcwMin=%d, EcwMax=%d, TxopLimit=%d\n",
+               ac_str[wmm_aci_to_qidx_map[(ac_param->aci_aifsn_bitmap
+               & MWIFIEX_ACI) >> 5]],
+               (ac_param->aci_aifsn_bitmap & MWIFIEX_ACI) >> 5,
+               (ac_param->aci_aifsn_bitmap & MWIFIEX_ACM) >> 4,
+               ac_param->aci_aifsn_bitmap & MWIFIEX_AIFSN,
+               ac_param->ecw_bitmap & MWIFIEX_ECW_MIN,
+               (ac_param->ecw_bitmap & MWIFIEX_ECW_MAX) >> 4,
+               le16_to_cpu(ac_param->tx_op_limit));
+}
+/*
+ * This function allocates a route address list.
+ *
+ * The function also initializes the list with the provided RA.
+ */
+static struct mwifiex_ra_list_tbl *
+mwifiex_wmm_allocate_ralist_node(struct mwifiex_adapter *adapter, u8 *ra)
+{
+        struct mwifiex_ra_list_tbl *ra_list;
+        ra_list = kzalloc(sizeof(struct mwifiex_ra_list_tbl), GFP_ATOMIC);
+        if (!ra_list) {
+                dev_err(adapter->dev, "%s: failed to alloc ra_list\n",
+                                                __func__);
+                return NULL;
+        }
+        INIT_LIST_HEAD(&ra_list->list);
+        skb_queue_head_init(&ra_list->skb_head);
+        memcpy(ra_list->ra, ra, ETH_ALEN);
+        ra_list->total_pkts_size = 0;
+        dev_dbg(adapter->dev, "info: allocated ra_list %p\n", ra_list);
+        return ra_list;
+}
+/*
+ * This function allocates and adds a RA list for all TIDs
+ * with the given RA.
+ */
+void
+mwifiex_ralist_add(struct mwifiex_private *priv, u8 *ra)
+{
+        int i;
+        struct mwifiex_ra_list_tbl *ra_list;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        for (i = 0; i < MAX_NUM_TID; ++i) {
+                ra_list = mwifiex_wmm_allocate_ralist_node(adapter, ra);
+                dev_dbg(adapter->dev, "info: created ra_list %p\n", ra_list);
+                if (!ra_list)
+                        break;
+                if (!mwifiex_queuing_ra_based(priv))
+                        ra_list->is_11n_enabled = IS_11N_ENABLED(priv);
+                else
+                        ra_list->is_11n_enabled = false;
+                dev_dbg(adapter->dev, "data: ralist %p: is_11n_enabled=%d\n",
+                        ra_list, ra_list->is_11n_enabled);
+                list_add_tail(&ra_list->list,
+                                &priv->wmm.tid_tbl_ptr[i].ra_list);
+                if (!priv->wmm.tid_tbl_ptr[i].ra_list_curr)
+                        priv->wmm.tid_tbl_ptr[i].ra_list_curr = ra_list;
+        }
+}
+/*
+ * This function sets the WMM queue priorities to their default values.
+ */
+static void mwifiex_wmm_default_queue_priorities(struct mwifiex_private *priv)
+{
+        /* Default queue priorities: VO->VI->BE->BK */
+        priv->wmm.queue_priority[0] = WMM_AC_VO;
+        priv->wmm.queue_priority[1] = WMM_AC_VI;
+        priv->wmm.queue_priority[2] = WMM_AC_BE;
+        priv->wmm.queue_priority[3] = WMM_AC_BK;
+}
+/*
+ * This function map ACs to TIDs.
+ */
+static void
+mwifiex_wmm_queue_priorities_tid(u8 queue_priority[])
+{
+        int i;
+        for (i = 0; i < 4; ++i) {
+                tos_to_tid[7 - (i * 2)] = ac_to_tid[queue_priority[i]][1];
+                tos_to_tid[6 - (i * 2)] = ac_to_tid[queue_priority[i]][0];
+        }
+}
+/*
+ * This function initializes WMM priority queues.
+ */
+void
+mwifiex_wmm_setup_queue_priorities(struct mwifiex_private *priv,
+                                   struct ieee_types_wmm_parameter *wmm_ie)
+{
+        u16 cw_min, avg_back_off, tmp[4];
+        u32 i, j, num_ac;
+        u8 ac_idx;
+        if (!wmm_ie || !priv->wmm_enabled) {
+                /* WMM is not enabled, just set the defaults and return */
+                mwifiex_wmm_default_queue_priorities(priv);
+                return;
+        }
+        dev_dbg(priv->adapter->dev, "info: WMM Parameter IE: version=%d, "
+                "qos_info Parameter Set Count=%d, Reserved=%#x\n",
+                wmm_ie->vend_hdr.version, wmm_ie->qos_info_bitmap &
+                IEEE80211_WMM_IE_AP_QOSINFO_PARAM_SET_CNT_MASK,
+                wmm_ie->reserved);
+        for (num_ac = 0; num_ac < ARRAY_SIZE(wmm_ie->ac_params); num_ac++) {
+                cw_min = (1 << (wmm_ie->ac_params[num_ac].ecw_bitmap &
+                        MWIFIEX_ECW_MIN)) - 1;
+                avg_back_off = (cw_min >> 1) +
+                        (wmm_ie->ac_params[num_ac].aci_aifsn_bitmap &
+                        MWIFIEX_AIFSN);
+                ac_idx = wmm_aci_to_qidx_map[(wmm_ie->ac_params[num_ac].
+                                             aci_aifsn_bitmap &
+                                             MWIFIEX_ACI) >> 5];
+                priv->wmm.queue_priority[ac_idx] = ac_idx;
+                tmp[ac_idx] = avg_back_off;
+                dev_dbg(priv->adapter->dev, "info: WMM: CWmax=%d CWmin=%d Avg Back-off=%d\n",
+                       (1 << ((wmm_ie->ac_params[num_ac].ecw_bitmap &
+                       MWIFIEX_ECW_MAX) >> 4)) - 1,
+                       cw_min, avg_back_off);
+                mwifiex_wmm_ac_debug_print(&wmm_ie->ac_params[num_ac]);
+        }
+        /* Bubble sort */
+        for (i = 0; i < num_ac; i++) {
+                for (j = 1; j < num_ac - i; j++) {
+                        if (tmp[j - 1] > tmp[j]) {
+                                swap(tmp[j - 1], tmp[j]);
+                                swap(priv->wmm.queue_priority[j - 1],
+                                     priv->wmm.queue_priority[j]);
+                        } else if (tmp[j - 1] == tmp[j]) {
+                                if (priv->wmm.queue_priority[j - 1]
+                                    < priv->wmm.queue_priority[j])
+                                        swap(priv->wmm.queue_priority[j - 1],
+                                             priv->wmm.queue_priority[j]);
+                        }
+                }
+        }
+        mwifiex_wmm_queue_priorities_tid(priv->wmm.queue_priority);
+}
+/*
+ * This function evaluates whether or not an AC is to be downgraded.
+ *
+ * In case the AC is not enabled, the highest AC is returned that is
+ * enabled and does not require admission control.
+ */
+static enum mwifiex_wmm_ac_e
+mwifiex_wmm_eval_downgrade_ac(struct mwifiex_private *priv,
+                              enum mwifiex_wmm_ac_e eval_ac)
+{
+        int down_ac;
+        enum mwifiex_wmm_ac_e ret_ac;
+        struct mwifiex_wmm_ac_status *ac_status;
+        ac_status = &priv->wmm.ac_status[eval_ac];
+        if (!ac_status->disabled)
+                /* Okay to use this AC, its enabled */
+                return eval_ac;
+        /* Setup a default return value of the lowest priority */
+        ret_ac = WMM_AC_BK;
+        /*
+         *  Find the highest AC that is enabled and does not require
+         *  admission control. The spec disallows downgrading to an AC,
+         *  which is enabled due to a completed admission control.
+         *  Unadmitted traffic is not to be sent on an AC with admitted
+         *  traffic.
+         */
+        for (down_ac = WMM_AC_BK; down_ac < eval_ac; down_ac++) {
+                ac_status = &priv->wmm.ac_status[down_ac];
+                if (!ac_status->disabled && !ac_status->flow_required)
+                        /* AC is enabled and does not require admission
+                           control */
+                        ret_ac = (enum mwifiex_wmm_ac_e) down_ac;
+        }
+        return ret_ac;
+}
+/*
+ * This function downgrades WMM priority queue.
+ */
+void
+mwifiex_wmm_setup_ac_downgrade(struct mwifiex_private *priv)
+{
+        int ac_val;
+        dev_dbg(priv->adapter->dev, "info: WMM: AC Priorities:"
+                        "BK(0), BE(1), VI(2), VO(3)\n");
+        if (!priv->wmm_enabled) {
+                /* WMM is not enabled, default priorities */
+                for (ac_val = WMM_AC_BK; ac_val <= WMM_AC_VO; ac_val++)
+                        priv->wmm.ac_down_graded_vals[ac_val] =
+                                (enum mwifiex_wmm_ac_e) ac_val;
+        } else {
+                for (ac_val = WMM_AC_BK; ac_val <= WMM_AC_VO; ac_val++) {
+                        priv->wmm.ac_down_graded_vals[ac_val]
+                                = mwifiex_wmm_eval_downgrade_ac(priv,
+                                                (enum mwifiex_wmm_ac_e) ac_val);
+                        dev_dbg(priv->adapter->dev, "info: WMM: AC PRIO %d maps to %d\n",
+                                ac_val, priv->wmm.ac_down_graded_vals[ac_val]);
+                }
+        }
+}
+/*
+ * This function converts the IP TOS field to an WMM AC
+ * Queue assignment.
+ */
+static enum mwifiex_wmm_ac_e
+mwifiex_wmm_convert_tos_to_ac(struct mwifiex_adapter *adapter, u32 tos)
+{
+        /* Map of TOS UP values to WMM AC */
+        const enum mwifiex_wmm_ac_e tos_to_ac[] = { WMM_AC_BE,
+                WMM_AC_BK,
+                WMM_AC_BK,
+                WMM_AC_BE,
+                WMM_AC_VI,
+                WMM_AC_VI,
+                WMM_AC_VO,
+                WMM_AC_VO
+        };
+        if (tos >= ARRAY_SIZE(tos_to_ac))
+                return WMM_AC_BE;
+        return tos_to_ac[tos];
+}
+/*
+ * This function evaluates a given TID and downgrades it to a lower
+ * TID if the WMM Parameter IE received from the AP indicates that the
+ * AP is disabled (due to call admission control (ACM bit). Mapping
+ * of TID to AC is taken care of internally.
+ */
+static u8
+mwifiex_wmm_downgrade_tid(struct mwifiex_private *priv, u32 tid)
+{
+        enum mwifiex_wmm_ac_e ac, ac_down;
+        u8 new_tid;
+        ac = mwifiex_wmm_convert_tos_to_ac(priv->adapter, tid);
+        ac_down = priv->wmm.ac_down_graded_vals[ac];
+        /* Send the index to tid array, picking from the array will be
+         * taken care by dequeuing function
+         */
+        new_tid = ac_to_tid[ac_down][tid % 2];
+        return new_tid;
+}
+/*
+ * This function initializes the WMM state information and the
+ * WMM data path queues.
+ */
+void
+mwifiex_wmm_init(struct mwifiex_adapter *adapter)
+{
+        int i, j;
+        struct mwifiex_private *priv;
+        for (j = 0; j < adapter->priv_num; ++j) {
+                priv = adapter->priv[j];
+                if (!priv)
+                        continue;
+                for (i = 0; i < MAX_NUM_TID; ++i) {
+                        priv->aggr_prio_tbl[i].amsdu = tos_to_tid_inv[i];
+                        priv->aggr_prio_tbl[i].ampdu_ap = tos_to_tid_inv[i];
+                        priv->aggr_prio_tbl[i].ampdu_user = tos_to_tid_inv[i];
+                        priv->wmm.tid_tbl_ptr[i].ra_list_curr = NULL;
+                }
+                priv->aggr_prio_tbl[6].amsdu
+                        = priv->aggr_prio_tbl[6].ampdu_ap
+                        = priv->aggr_prio_tbl[6].ampdu_user
+                        = BA_STREAM_NOT_ALLOWED;
+                priv->aggr_prio_tbl[7].amsdu = priv->aggr_prio_tbl[7].ampdu_ap
+                        = priv->aggr_prio_tbl[7].ampdu_user
+                        = BA_STREAM_NOT_ALLOWED;
+                priv->add_ba_param.timeout = MWIFIEX_DEFAULT_BLOCK_ACK_TIMEOUT;
+                priv->add_ba_param.tx_win_size = MWIFIEX_AMPDU_DEF_TXWINSIZE;
+                priv->add_ba_param.rx_win_size = MWIFIEX_AMPDU_DEF_RXWINSIZE;
+        }
+}
+/*
+ * This function checks if WMM Tx queue is empty.
+ */
+int
+mwifiex_wmm_lists_empty(struct mwifiex_adapter *adapter)
+{
+        int i, j;
+        struct mwifiex_private *priv;
+        for (j = 0; j < adapter->priv_num; ++j) {
+                priv = adapter->priv[j];
+                if (priv) {
+                        for (i = 0; i < MAX_NUM_TID; i++)
+                                if (!mwifiex_wmm_is_ra_list_empty(
+                                             &priv->wmm.tid_tbl_ptr[i].ra_list))
+                                        return false;
+                }
+        }
+        return true;
+}
+/*
+ * This function deletes all packets in an RA list node.
+ *
+ * The packet sent completion callback handler are called with
+ * status failure, after they are dequeued to ensure proper
+ * cleanup. The RA list node itself is freed at the end.
+ */
+static void
+mwifiex_wmm_del_pkts_in_ralist_node(struct mwifiex_private *priv,
+                                    struct mwifiex_ra_list_tbl *ra_list)
+{
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct sk_buff *skb, *tmp;
+        skb_queue_walk_safe(&ra_list->skb_head, skb, tmp)
+                mwifiex_write_data_complete(adapter, skb, -1);
+}
+/*
+ * This function deletes all packets in an RA list.
+ *
+ * Each nodes in the RA list are freed individually first, and then
+ * the RA list itself is freed.
+ */
+static void
+mwifiex_wmm_del_pkts_in_ralist(struct mwifiex_private *priv,
+                               struct list_head *ra_list_head)
+{
+        struct mwifiex_ra_list_tbl *ra_list;
+        list_for_each_entry(ra_list, ra_list_head, list)
+                mwifiex_wmm_del_pkts_in_ralist_node(priv, ra_list);
+}
+/*
+ * This function deletes all packets in all RA lists.
+ */
+static void mwifiex_wmm_cleanup_queues(struct mwifiex_private *priv)
+{
+        int i;
+        for (i = 0; i < MAX_NUM_TID; i++)
+                mwifiex_wmm_del_pkts_in_ralist(priv, &priv->wmm.tid_tbl_ptr[i].
+                                                     ra_list);
+}
+/*
+ * This function deletes all route addresses from all RA lists.
+ */
+static void mwifiex_wmm_delete_all_ralist(struct mwifiex_private *priv)
+{
+        struct mwifiex_ra_list_tbl *ra_list, *tmp_node;
+        int i;
+        for (i = 0; i < MAX_NUM_TID; ++i) {
+                dev_dbg(priv->adapter->dev,
+                                "info: ra_list: freeing buf for tid %d\n", i);
+                list_for_each_entry_safe(ra_list, tmp_node,
+                                &priv->wmm.tid_tbl_ptr[i].ra_list, list) {
+                        list_del(&ra_list->list);
+                        kfree(ra_list);
+                }
+                INIT_LIST_HEAD(&priv->wmm.tid_tbl_ptr[i].ra_list);
+                priv->wmm.tid_tbl_ptr[i].ra_list_curr = NULL;
+        }
+}
+/*
+ * This function cleans up the Tx and Rx queues.
+ *
+ * Cleanup includes -
+ *      - All packets in RA lists
+ *      - All entries in Rx reorder table
+ *      - All entries in Tx BA stream table
+ *      - MPA buffer (if required)
+ *      - All RA lists
+ */
+void
+mwifiex_clean_txrx(struct mwifiex_private *priv)
+{
+        unsigned long flags;
+        mwifiex_11n_cleanup_reorder_tbl(priv);
+        spin_lock_irqsave(&priv->wmm.ra_list_spinlock, flags);
+        mwifiex_wmm_cleanup_queues(priv);
+        mwifiex_11n_delete_all_tx_ba_stream_tbl(priv);
+        if (priv->adapter->if_ops.cleanup_mpa_buf)
+                priv->adapter->if_ops.cleanup_mpa_buf(priv->adapter);
+        mwifiex_wmm_delete_all_ralist(priv);
+        memcpy(tos_to_tid, ac_to_tid, sizeof(tos_to_tid));
+        spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock, flags);
+}
+/*
+ * This function retrieves a particular RA list node, matching with the
+ * given TID and RA address.
+ */
+static struct mwifiex_ra_list_tbl *
+mwifiex_wmm_get_ralist_node(struct mwifiex_private *priv, u8 tid,
+                            u8 *ra_addr)
+{
+        struct mwifiex_ra_list_tbl *ra_list;
+        list_for_each_entry(ra_list, &priv->wmm.tid_tbl_ptr[tid].ra_list,
+                            list) {
+                if (!memcmp(ra_list->ra, ra_addr, ETH_ALEN))
+                        return ra_list;
+        }
+        return NULL;
+}
+/*
+ * This function retrieves an RA list node for a given TID and
+ * RA address pair.
+ *
+ * If no such node is found, a new node is added first and then
+ * retrieved.
+ */
+static struct mwifiex_ra_list_tbl *
+mwifiex_wmm_get_queue_raptr(struct mwifiex_private *priv, u8 tid, u8 *ra_addr)
+{
+        struct mwifiex_ra_list_tbl *ra_list;
+        ra_list = mwifiex_wmm_get_ralist_node(priv, tid, ra_addr);
+        if (ra_list)
+                return ra_list;
+        mwifiex_ralist_add(priv, ra_addr);
+        return mwifiex_wmm_get_ralist_node(priv, tid, ra_addr);
+}
+/*
+ * This function checks if a particular RA list node exists in a given TID
+ * table index.
+ */
+int
+mwifiex_is_ralist_valid(struct mwifiex_private *priv,
+                        struct mwifiex_ra_list_tbl *ra_list, int ptr_index)
+{
+        struct mwifiex_ra_list_tbl *rlist;
+        list_for_each_entry(rlist, &priv->wmm.tid_tbl_ptr[ptr_index].ra_list,
+                            list) {
+                if (rlist == ra_list)
+                        return true;
+        }
+        return false;
+}
+/*
+ * This function adds a packet to WMM queue.
+ *
+ * In disconnected state the packet is immediately dropped and the
+ * packet send completion callback is called with status failure.
+ *
+ * Otherwise, the correct RA list node is located and the packet
+ * is queued at the list tail.
+ */
+void
+mwifiex_wmm_add_buf_txqueue(struct mwifiex_adapter *adapter,
+                            struct sk_buff *skb)
+{
+        struct mwifiex_txinfo *tx_info = MWIFIEX_SKB_TXCB(skb);
+        struct mwifiex_private *priv = adapter->priv[tx_info->bss_index];
+        u32 tid;
+        struct mwifiex_ra_list_tbl *ra_list;
+        u8 ra[ETH_ALEN], tid_down;
+        unsigned long flags;
+        if (!priv->media_connected) {
+                dev_dbg(adapter->dev, "data: drop packet in disconnect\n");
+                mwifiex_write_data_complete(adapter, skb, -1);
+                return;
+        }
+        tid = skb->priority;
+        spin_lock_irqsave(&priv->wmm.ra_list_spinlock, flags);
+        tid_down = mwifiex_wmm_downgrade_tid(priv, tid);
+        /* In case of infra as we have already created the list during
+           association we just don't have to call get_queue_raptr, we will
+           have only 1 raptr for a tid in case of infra */
+        if (!mwifiex_queuing_ra_based(priv)) {
+                if (!list_empty(&priv->wmm.tid_tbl_ptr[tid_down].ra_list))
+                        ra_list = list_first_entry(
+                                &priv->wmm.tid_tbl_ptr[tid_down].ra_list,
+                                struct mwifiex_ra_list_tbl, list);
+                else
+                        ra_list = NULL;
+        } else {
+                memcpy(ra, skb->data, ETH_ALEN);
+                ra_list = mwifiex_wmm_get_queue_raptr(priv, tid_down, ra);
+        }
+        if (!ra_list) {
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock, flags);
+                mwifiex_write_data_complete(adapter, skb, -1);
+                return;
+        }
+        skb_queue_tail(&ra_list->skb_head, skb);
+        ra_list->total_pkts_size += skb->len;
+        spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock, flags);
+}
+/*
+ * This function processes the get WMM status command response from firmware.
+ *
+ * The response may contain multiple TLVs -
+ *      - AC Queue status TLVs
+ *      - Current WMM Parameter IE TLV
+ *      - Admission Control action frame TLVs
+ *
+ * This function parses the TLVs and then calls further specific functions
+ * to process any changes in the queue prioritize or state.
+ */
+int mwifiex_ret_wmm_get_status(struct mwifiex_private *priv,
+                               const struct host_cmd_ds_command *resp)
+{
+        u8 *curr = (u8 *) &resp->params.get_wmm_status;
+        uint16_t resp_len = le16_to_cpu(resp->size), tlv_len;
+        int valid = true;
+        struct mwifiex_ie_types_data *tlv_hdr;
+        struct mwifiex_ie_types_wmm_queue_status *tlv_wmm_qstatus;
+        struct ieee_types_wmm_parameter *wmm_param_ie = NULL;
+        struct mwifiex_wmm_ac_status *ac_status;
+        dev_dbg(priv->adapter->dev, "info: WMM: WMM_GET_STATUS cmdresp received: %d\n",
+                        resp_len);
+        while ((resp_len >= sizeof(tlv_hdr->header)) && valid) {
+                tlv_hdr = (struct mwifiex_ie_types_data *) curr;
+                tlv_len = le16_to_cpu(tlv_hdr->header.len);
+                switch (le16_to_cpu(tlv_hdr->header.type)) {
+                case TLV_TYPE_WMMQSTATUS:
+                        tlv_wmm_qstatus =
+                                (struct mwifiex_ie_types_wmm_queue_status *)
+                                tlv_hdr;
+                        dev_dbg(priv->adapter->dev,
+                                "info: CMD_RESP: WMM_GET_STATUS:"
+                                " QSTATUS TLV: %d, %d, %d\n",
+                               tlv_wmm_qstatus->queue_index,
+                               tlv_wmm_qstatus->flow_required,
+                               tlv_wmm_qstatus->disabled);
+                        ac_status = &priv->wmm.ac_status[tlv_wmm_qstatus->
+                                                         queue_index];
+                        ac_status->disabled = tlv_wmm_qstatus->disabled;
+                        ac_status->flow_required =
+                                tlv_wmm_qstatus->flow_required;
+                        ac_status->flow_created = tlv_wmm_qstatus->flow_created;
+                        break;
+                case WLAN_EID_VENDOR_SPECIFIC:
+                        /*
+                         * Point the regular IEEE IE 2 bytes into the Marvell IE
+                         *   and setup the IEEE IE type and length byte fields
+                         */
+                        wmm_param_ie =
+                                (struct ieee_types_wmm_parameter *) (curr +
+                                                                    2);
+                        wmm_param_ie->vend_hdr.len = (u8) tlv_len;
+                        wmm_param_ie->vend_hdr.element_id =
+                                                WLAN_EID_VENDOR_SPECIFIC;
+                        dev_dbg(priv->adapter->dev,
+                                "info: CMD_RESP: WMM_GET_STATUS:"
+                                " WMM Parameter Set Count: %d\n",
+                                wmm_param_ie->qos_info_bitmap &
+                                IEEE80211_WMM_IE_AP_QOSINFO_PARAM_SET_CNT_MASK);
+                        memcpy((u8 *) &priv->curr_bss_params.bss_descriptor.
+                               wmm_ie, wmm_param_ie,
+                               wmm_param_ie->vend_hdr.len + 2);
+                        break;
+                default:
+                        valid = false;
+                        break;
+                }
+                curr += (tlv_len + sizeof(tlv_hdr->header));
+                resp_len -= (tlv_len + sizeof(tlv_hdr->header));
+        }
+        mwifiex_wmm_setup_queue_priorities(priv, wmm_param_ie);
+        mwifiex_wmm_setup_ac_downgrade(priv);
+        return 0;
+}
+/*
+ * Callback handler from the command module to allow insertion of a WMM TLV.
+ *
+ * If the BSS we are associating to supports WMM, this function adds the
+ * required WMM Information IE to the association request command buffer in
+ * the form of a Marvell extended IEEE IE.
+ */
+u32
+mwifiex_wmm_process_association_req(struct mwifiex_private *priv,
+                                    u8 **assoc_buf,
+                                    struct ieee_types_wmm_parameter *wmm_ie,
+                                    struct ieee80211_ht_cap *ht_cap)
+{
+        struct mwifiex_ie_types_wmm_param_set *wmm_tlv;
+        u32 ret_len = 0;
+        /* Null checks */
+        if (!assoc_buf)
+                return 0;
+        if (!(*assoc_buf))
+                return 0;
+        if (!wmm_ie)
+                return 0;
+        dev_dbg(priv->adapter->dev, "info: WMM: process assoc req:"
+                        "bss->wmmIe=0x%x\n",
+                        wmm_ie->vend_hdr.element_id);
+        if ((priv->wmm_required
+             || (ht_cap && (priv->adapter->config_bands & BAND_GN
+                     || priv->adapter->config_bands & BAND_AN))
+            )
+            && wmm_ie->vend_hdr.element_id == WLAN_EID_VENDOR_SPECIFIC) {
+                wmm_tlv = (struct mwifiex_ie_types_wmm_param_set *) *assoc_buf;
+                wmm_tlv->header.type = cpu_to_le16((u16) wmm_info_ie[0]);
+                wmm_tlv->header.len = cpu_to_le16((u16) wmm_info_ie[1]);
+                memcpy(wmm_tlv->wmm_ie, &wmm_info_ie[2],
+                        le16_to_cpu(wmm_tlv->header.len));
+                if (wmm_ie->qos_info_bitmap & IEEE80211_WMM_IE_AP_QOSINFO_UAPSD)
+                        memcpy((u8 *) (wmm_tlv->wmm_ie
+                                        + le16_to_cpu(wmm_tlv->header.len)
+                                         - sizeof(priv->wmm_qosinfo)),
+                                        &priv->wmm_qosinfo,
+                                        sizeof(priv->wmm_qosinfo));
+                ret_len = sizeof(wmm_tlv->header)
+                        + le16_to_cpu(wmm_tlv->header.len);
+                *assoc_buf += ret_len;
+        }
+        return ret_len;
+}
+/*
+ * This function computes the time delay in the driver queues for a
+ * given packet.
+ *
+ * When the packet is received at the OS/Driver interface, the current
+ * time is set in the packet structure. The difference between the present
+ * time and that received time is computed in this function and limited
+ * based on pre-compiled limits in the driver.
+ */
+u8
+mwifiex_wmm_compute_drv_pkt_delay(struct mwifiex_private *priv,
+                                        const struct sk_buff *skb)
+{
+        u8 ret_val;
+        struct timeval out_tstamp, in_tstamp;
+        u32 queue_delay;
+        do_gettimeofday(&out_tstamp);
+        in_tstamp = ktime_to_timeval(skb->tstamp);
+        queue_delay = (out_tstamp.tv_sec - in_tstamp.tv_sec) * 1000;
+        queue_delay += (out_tstamp.tv_usec - in_tstamp.tv_usec) / 1000;
+        /*
+         * Queue delay is passed as a uint8 in units of 2ms (ms shifted
+         *  by 1). Min value (other than 0) is therefore 2ms, max is 510ms.
+         *
+         * Pass max value if queue_delay is beyond the uint8 range
+         */
+        ret_val = (u8) (min(queue_delay, priv->wmm.drv_pkt_delay_max) >> 1);
+        dev_dbg(priv->adapter->dev, "data: WMM: Pkt Delay: %d ms,"
+                                " %d ms sent to FW\n", queue_delay, ret_val);
+        return ret_val;
+}
+/*
+ * This function retrieves the highest priority RA list table pointer.
+ */
+static struct mwifiex_ra_list_tbl *
+mwifiex_wmm_get_highest_priolist_ptr(struct mwifiex_adapter *adapter,
+                                     struct mwifiex_private **priv, int *tid)
+{
+        struct mwifiex_private *priv_tmp;
+        struct mwifiex_ra_list_tbl *ptr, *head;
+        struct mwifiex_bss_prio_node *bssprio_node, *bssprio_head;
+        struct mwifiex_tid_tbl *tid_ptr;
+        int is_list_empty;
+        unsigned long flags;
+        int i, j;
+        for (j = adapter->priv_num - 1; j >= 0; --j) {
+                spin_lock_irqsave(&adapter->bss_prio_tbl[j].bss_prio_lock,
+                                flags);
+                is_list_empty = list_empty(&adapter->bss_prio_tbl[j]
+                                .bss_prio_head);
+                spin_unlock_irqrestore(&adapter->bss_prio_tbl[j].bss_prio_lock,
+                                flags);
+                if (is_list_empty)
+                        continue;
+                if (adapter->bss_prio_tbl[j].bss_prio_cur ==
+                    (struct mwifiex_bss_prio_node *)
+                    &adapter->bss_prio_tbl[j].bss_prio_head) {
+                        bssprio_node =
+                                list_first_entry(&adapter->bss_prio_tbl[j]
+                                                 .bss_prio_head,
+                                                 struct mwifiex_bss_prio_node,
+                                                 list);
+                        bssprio_head = bssprio_node;
+                } else {
+                        bssprio_node = adapter->bss_prio_tbl[j].bss_prio_cur;
+                        bssprio_head = bssprio_node;
+                }
+                do {
+                        priv_tmp = bssprio_node->priv;
+                        for (i = HIGH_PRIO_TID; i >= LOW_PRIO_TID; --i) {
+                                tid_ptr = &(priv_tmp)->wmm.
+                                        tid_tbl_ptr[tos_to_tid[i]];
+                                spin_lock_irqsave(&tid_ptr->tid_tbl_lock,
+                                                  flags);
+                                is_list_empty =
+                                        list_empty(&adapter->bss_prio_tbl[j]
+                                                   .bss_prio_head);
+                                spin_unlock_irqrestore(&tid_ptr->tid_tbl_lock,
+                                                       flags);
+                                if (is_list_empty)
+                                        continue;
+                                /*
+                                 * Always choose the next ra we transmitted
+                                 * last time, this way we pick the ra's in
+                                 * round robin fashion.
+                                 */
+                                ptr = list_first_entry(
+                                                &tid_ptr->ra_list_curr->list,
+                                                struct mwifiex_ra_list_tbl,
+                                                list);
+                                head = ptr;
+                                if (ptr == (struct mwifiex_ra_list_tbl *)
+                                                &tid_ptr->ra_list) {
+                                        /* Get next ra */
+                                        ptr = list_first_entry(&ptr->list,
+                                            struct mwifiex_ra_list_tbl, list);
+                                        head = ptr;
+                                }
+                                do {
+                                        is_list_empty =
+                                                skb_queue_empty(&ptr->skb_head);
+                                        if (!is_list_empty) {
+                                                *priv = priv_tmp;
+                                                *tid = tos_to_tid[i];
+                                                return ptr;
+                                        }
+                                        /* Get next ra */
+                                        ptr = list_first_entry(&ptr->list,
+                                                 struct mwifiex_ra_list_tbl,
+                                                 list);
+                                        if (ptr ==
+                                            (struct mwifiex_ra_list_tbl *)
+                                            &tid_ptr->ra_list)
+                                                ptr = list_first_entry(
+                                                    &ptr->list,
+                                                    struct mwifiex_ra_list_tbl,
+                                                    list);
+                                } while (ptr != head);
+                        }
+                        /* Get next bss priority node */
+                        bssprio_node = list_first_entry(&bssprio_node->list,
+                                                struct mwifiex_bss_prio_node,
+                                                list);
+                        if (bssprio_node ==
+                            (struct mwifiex_bss_prio_node *)
+                            &adapter->bss_prio_tbl[j].bss_prio_head)
+                                /* Get next bss priority node */
+                                bssprio_node = list_first_entry(
+                                                &bssprio_node->list,
+                                                struct mwifiex_bss_prio_node,
+                                                list);
+                } while (bssprio_node != bssprio_head);
+        }
+        return NULL;
+}
+/*
+ * This function gets the number of packets in the Tx queue of a
+ * particular RA list.
+ */
+static int
+mwifiex_num_pkts_in_txq(struct mwifiex_private *priv,
+                        struct mwifiex_ra_list_tbl *ptr, int max_buf_size)
+{
+        int count = 0, total_size = 0;
+        struct sk_buff *skb, *tmp;
+        skb_queue_walk_safe(&ptr->skb_head, skb, tmp) {
+                total_size += skb->len;
+                if (total_size < max_buf_size)
+                        ++count;
+                else
+                        break;
+        }
+        return count;
+}
+/*
+ * This function sends a single packet to firmware for transmission.
+ */
+static void
+mwifiex_send_single_packet(struct mwifiex_private *priv,
+                           struct mwifiex_ra_list_tbl *ptr, int ptr_index,
+                           unsigned long ra_list_flags)
+                           __releases(&priv->wmm.ra_list_spinlock)
+{
+        struct sk_buff *skb, *skb_next;
+        struct mwifiex_tx_param tx_param;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        struct mwifiex_txinfo *tx_info;
+        if (skb_queue_empty(&ptr->skb_head)) {
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+                dev_dbg(adapter->dev, "data: nothing to send\n");
+                return;
+        }
+        skb = skb_dequeue(&ptr->skb_head);
+        tx_info = MWIFIEX_SKB_TXCB(skb);
+        dev_dbg(adapter->dev, "data: dequeuing the packet %p %p\n", ptr, skb);
+        ptr->total_pkts_size -= skb->len;
+        if (!skb_queue_empty(&ptr->skb_head))
+                skb_next = skb_peek(&ptr->skb_head);
+        else
+                skb_next = NULL;
+        spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock, ra_list_flags);
+        tx_param.next_pkt_len = ((skb_next) ? skb_next->len +
+                                sizeof(struct txpd) : 0);
+        if (mwifiex_process_tx(priv, skb, &tx_param) == -EBUSY) {
+                /* Queue the packet back at the head */
+                spin_lock_irqsave(&priv->wmm.ra_list_spinlock, ra_list_flags);
+                if (!mwifiex_is_ralist_valid(priv, ptr, ptr_index)) {
+                        spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                               ra_list_flags);
+                        mwifiex_write_data_complete(adapter, skb, -1);
+                        return;
+                }
+                skb_queue_tail(&ptr->skb_head, skb);
+                ptr->total_pkts_size += skb->len;
+                tx_info->flags |= MWIFIEX_BUF_FLAG_REQUEUED_PKT;
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+        } else {
+                spin_lock_irqsave(&priv->wmm.ra_list_spinlock, ra_list_flags);
+                if (mwifiex_is_ralist_valid(priv, ptr, ptr_index)) {
+                        priv->wmm.packets_out[ptr_index]++;
+                        priv->wmm.tid_tbl_ptr[ptr_index].ra_list_curr = ptr;
+                }
+                adapter->bss_prio_tbl[priv->bss_priority].bss_prio_cur =
+                        list_first_entry(
+                                &adapter->bss_prio_tbl[priv->bss_priority]
+                                .bss_prio_cur->list,
+                                struct mwifiex_bss_prio_node,
+                                list);
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+        }
+}
+/*
+ * This function checks if the first packet in the given RA list
+ * is already processed or not.
+ */
+static int
+mwifiex_is_ptr_processed(struct mwifiex_private *priv,
+                         struct mwifiex_ra_list_tbl *ptr)
+{
+        struct sk_buff *skb;
+        struct mwifiex_txinfo *tx_info;
+        if (skb_queue_empty(&ptr->skb_head))
+                return false;
+        skb = skb_peek(&ptr->skb_head);
+        tx_info = MWIFIEX_SKB_TXCB(skb);
+        if (tx_info->flags & MWIFIEX_BUF_FLAG_REQUEUED_PKT)
+                return true;
+        return false;
+}
+/*
+ * This function sends a single processed packet to firmware for
+ * transmission.
+ */
+static void
+mwifiex_send_processed_packet(struct mwifiex_private *priv,
+                              struct mwifiex_ra_list_tbl *ptr, int ptr_index,
+                              unsigned long ra_list_flags)
+                                __releases(&priv->wmm.ra_list_spinlock)
+{
+        struct mwifiex_tx_param tx_param;
+        struct mwifiex_adapter *adapter = priv->adapter;
+        int ret = -1;
+        struct sk_buff *skb, *skb_next;
+        struct mwifiex_txinfo *tx_info;
+        if (skb_queue_empty(&ptr->skb_head)) {
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+                return;
+        }
+        skb = skb_dequeue(&ptr->skb_head);
+        if (!skb_queue_empty(&ptr->skb_head))
+                skb_next = skb_peek(&ptr->skb_head);
+        else
+                skb_next = NULL;
+        tx_info = MWIFIEX_SKB_TXCB(skb);
+        spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock, ra_list_flags);
+        tx_param.next_pkt_len =
+                ((skb_next) ? skb_next->len +
+                 sizeof(struct txpd) : 0);
+        ret = adapter->if_ops.host_to_card(adapter, MWIFIEX_TYPE_DATA,
+                                           skb->data, skb->len, &tx_param);
+        switch (ret) {
+        case -EBUSY:
+                dev_dbg(adapter->dev, "data: -EBUSY is returned\n");
+                spin_lock_irqsave(&priv->wmm.ra_list_spinlock, ra_list_flags);
+                if (!mwifiex_is_ralist_valid(priv, ptr, ptr_index)) {
+                        spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                               ra_list_flags);
+                        mwifiex_write_data_complete(adapter, skb, -1);
+                        return;
+                }
+                skb_queue_tail(&ptr->skb_head, skb);
+                tx_info->flags |= MWIFIEX_BUF_FLAG_REQUEUED_PKT;
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+                break;
+        case -1:
+                adapter->data_sent = false;
+                dev_err(adapter->dev, "host_to_card failed: %#x\n", ret);
+                adapter->dbg.num_tx_host_to_card_failure++;
+                mwifiex_write_data_complete(adapter, skb, ret);
+                break;
+        case -EINPROGRESS:
+                adapter->data_sent = false;
+        default:
+                break;
+        }
+        if (ret != -EBUSY) {
+                spin_lock_irqsave(&priv->wmm.ra_list_spinlock, ra_list_flags);
+                if (mwifiex_is_ralist_valid(priv, ptr, ptr_index)) {
+                        priv->wmm.packets_out[ptr_index]++;
+                        priv->wmm.tid_tbl_ptr[ptr_index].ra_list_curr = ptr;
+                }
+                adapter->bss_prio_tbl[priv->bss_priority].bss_prio_cur =
+                        list_first_entry(
+                                &adapter->bss_prio_tbl[priv->bss_priority]
+                                .bss_prio_cur->list,
+                                struct mwifiex_bss_prio_node,
+                                list);
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,
+                                       ra_list_flags);
+        }
+}
+/*
+ * This function dequeues a packet from the highest priority list
+ * and transmits it.
+ */
+static int
+mwifiex_dequeue_tx_packet(struct mwifiex_adapter *adapter)
+{
+        struct mwifiex_ra_list_tbl *ptr;
+        struct mwifiex_private *priv = NULL;
+        int ptr_index = 0;
+        u8 ra[ETH_ALEN];
+        int tid_del = 0, tid = 0;
+        unsigned long flags;
+        ptr = mwifiex_wmm_get_highest_priolist_ptr(adapter, &priv, &ptr_index);
+        if (!ptr)
+                return -1;
+        tid = mwifiex_get_tid(ptr);
+        dev_dbg(adapter->dev, "data: tid=%d\n", tid);
+        spin_lock_irqsave(&priv->wmm.ra_list_spinlock, flags);
+        if (!mwifiex_is_ralist_valid(priv, ptr, ptr_index)) {
+                spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock, flags);
+                return -1;
+        }
+        if (mwifiex_is_ptr_processed(priv, ptr)) {
+                mwifiex_send_processed_packet(priv, ptr, ptr_index, flags);
+                /* ra_list_spinlock has been freed in
+                   mwifiex_send_processed_packet() */
+                return 0;
+        }
+        if (!ptr->is_11n_enabled || mwifiex_is_ba_stream_setup(priv, ptr, tid)
+            || ((priv->sec_info.wpa_enabled
+                  || priv->sec_info.wpa2_enabled) && !priv->wpa_is_gtk_set)
+                ) {
+                mwifiex_send_single_packet(priv, ptr, ptr_index, flags);
+                /* ra_list_spinlock has been freed in
+                   mwifiex_send_single_packet() */
+        } else {
+                if (mwifiex_is_ampdu_allowed(priv, tid)) {
+                        if (mwifiex_space_avail_for_new_ba_stream(adapter)) {
+                                mwifiex_11n_create_tx_ba_stream_tbl(priv,
+                                                ptr->ra, tid,
+                                                BA_STREAM_SETUP_INPROGRESS);
+                                mwifiex_send_addba(priv, tid, ptr->ra);
+                        } else if (mwifiex_find_stream_to_delete
+                                   (priv, tid, &tid_del, ra)) {
+                                mwifiex_11n_create_tx_ba_stream_tbl(priv,
+                                                ptr->ra, tid,
+                                                BA_STREAM_SETUP_INPROGRESS);
+                                mwifiex_send_delba(priv, tid_del, ra, 1);
+                        }
+                }
+/* Minimum number of AMSDU */
+#define MIN_NUM_AMSDU 2
+                if (mwifiex_is_amsdu_allowed(priv, tid) &&
+                    (mwifiex_num_pkts_in_txq(priv, ptr, adapter->tx_buf_size) >=
+                     MIN_NUM_AMSDU))
+                        mwifiex_11n_aggregate_pkt(priv, ptr, INTF_HEADER_LEN,
+                                                  ptr_index, flags);
+                        /* ra_list_spinlock has been freed in
+                           mwifiex_11n_aggregate_pkt() */
+                else
+                        mwifiex_send_single_packet(priv, ptr, ptr_index, flags);
+                        /* ra_list_spinlock has been freed in
+                           mwifiex_send_single_packet() */
+        }
+        return 0;
+}
+/*
+ * This function transmits the highest priority packet awaiting in the
+ * WMM Queues.
+ */
+void
+mwifiex_wmm_process_tx(struct mwifiex_adapter *adapter)
+{
+        do {
+                /* Check if busy */
+                if (adapter->data_sent || adapter->tx_lock_flag)
+                        break;
+                if (mwifiex_dequeue_tx_packet(adapter))
+                        break;
+        } while (true);
+}
diff --git a/drivers/net/wireless/mwifiex/wmm.h b/drivers/net/wireless/mwifiex/wmm.h
new file mode 100644
index 000000000000..fcea1f68792f
--- /dev/null
+++ b/drivers/net/wireless/mwifiex/wmm.h
@@ -0,0 +1,110 @@
+/*
+ * Marvell Wireless LAN device driver: WMM
+ *
+ * Copyright (C) 2011, Marvell International Ltd.
+ *
+ * This software file (the "File") is distributed by Marvell International
+ * Ltd. under the terms of the GNU General Public License Version 2, June 1991
+ * (the "License").  You may use, redistribute and/or modify this File in
+ * accordance with the terms and conditions of the License, a copy of which
+ * is available by writing to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
+ * worldwide web at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+ *
+ * THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, AND THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE
+ * ARE EXPRESSLY DISCLAIMED.  The License provides additional details about
+ * this warranty disclaimer.
+ */
+#ifndef _MWIFIEX_WMM_H_
+#define _MWIFIEX_WMM_H_
+enum ieee_types_wmm_aciaifsn_bitmasks {
+        MWIFIEX_AIFSN = (BIT(0) | BIT(1) | BIT(2) | BIT(3)),
+        MWIFIEX_ACM = BIT(4),
+        MWIFIEX_ACI = (BIT(5) | BIT(6)),
+};
+enum ieee_types_wmm_ecw_bitmasks {
+        MWIFIEX_ECW_MIN = (BIT(0) | BIT(1) | BIT(2) | BIT(3)),
+        MWIFIEX_ECW_MAX = (BIT(4) | BIT(5) | BIT(6) | BIT(7)),
+};
+/*
+ * This function retrieves the TID of the given RA list.
+ */
+static inline int
+mwifiex_get_tid(struct mwifiex_ra_list_tbl *ptr)
+{
+        struct sk_buff *skb;
+        if (skb_queue_empty(&ptr->skb_head))
+                return 0;
+        skb = skb_peek(&ptr->skb_head);
+        return skb->priority;
+}
+/*
+ * This function gets the length of a list.
+ */
+static inline int
+mwifiex_wmm_list_len(struct list_head *head)
+{
+        struct list_head *pos;
+        int count = 0;
+        list_for_each(pos, head)
+                ++count;
+        return count;
+}
+/*
+ * This function checks if a RA list is empty or not.
+ */
+static inline u8
+mwifiex_wmm_is_ra_list_empty(struct list_head *ra_list_hhead)
+{
+        struct mwifiex_ra_list_tbl *ra_list;
+        int is_list_empty;
+        list_for_each_entry(ra_list, ra_list_hhead, list) {
+                is_list_empty = skb_queue_empty(&ra_list->skb_head);
+                if (!is_list_empty)
+                        return false;
+        }
+        return true;
+}
+void mwifiex_wmm_add_buf_txqueue(struct mwifiex_adapter *adapter,
+                                 struct sk_buff *skb);
+void mwifiex_ralist_add(struct mwifiex_private *priv, u8 *ra);
+int mwifiex_wmm_lists_empty(struct mwifiex_adapter *adapter);
+void mwifiex_wmm_process_tx(struct mwifiex_adapter *adapter);
+int mwifiex_is_ralist_valid(struct mwifiex_private *priv,
+                            struct mwifiex_ra_list_tbl *ra_list, int tid);
+u8 mwifiex_wmm_compute_drv_pkt_delay(struct mwifiex_private *priv,
+                                             const struct sk_buff *skb);
+void mwifiex_wmm_init(struct mwifiex_adapter *adapter);
+extern u32 mwifiex_wmm_process_association_req(struct mwifiex_private *priv,
+                                                 u8 **assoc_buf,
+                                                 struct ieee_types_wmm_parameter
+                                                 *wmmie,
+                                                 struct ieee80211_ht_cap
+                                                 *htcap);
+void mwifiex_wmm_setup_queue_priorities(struct mwifiex_private *priv,
+                                        struct ieee_types_wmm_parameter
+                                        *wmm_ie);
+void mwifiex_wmm_setup_ac_downgrade(struct mwifiex_private *priv);
+extern int mwifiex_ret_wmm_get_status(struct mwifiex_private *priv,
+                                      const struct host_cmd_ds_command *resp);
+#endif /* !_MWIFIEX_WMM_H_ */
diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index c1ceb4b23971..32261189bcef 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -63,6 +63,7 @@ MODULE_PARM_DESC(ap_mode_default,
 #define MWL8K_HIU_A2H_INTERRUPT_CLEAR_SEL       0x00000c38
 #define MWL8K_HIU_A2H_INTERRUPT_STATUS_MASK     0x00000c3c
 #define  MWL8K_A2H_INT_DUMMY                     (1 << 20)
+#define  MWL8K_A2H_INT_BA_WATCHDOG               (1 << 14)
 #define  MWL8K_A2H_INT_CHNL_SWITCHED             (1 << 11)
 #define  MWL8K_A2H_INT_QUEUE_EMPTY               (1 << 10)
 #define  MWL8K_A2H_INT_RADAR_DETECT              (1 << 7)
@@ -73,6 +74,14 @@ MODULE_PARM_DESC(ap_mode_default,
 #define  MWL8K_A2H_INT_RX_READY                  (1 << 1)
 #define  MWL8K_A2H_INT_TX_DONE                   (1 << 0)
+/* HW micro second timer register
+ * located at offset 0xA600. This
+ * will be used to timestamp tx
+ * packets.
+ */
+#define MWL8K_HW_TIMER_REGISTER                 0x0000a600
 #define MWL8K_A2H_EVENTS        (MWL8K_A2H_INT_DUMMY | \
                                 MWL8K_A2H_INT_CHNL_SWITCHED | \
                                 MWL8K_A2H_INT_QUEUE_EMPTY | \
@@ -82,10 +91,14 @@ MODULE_PARM_DESC(ap_mode_default,
                                 MWL8K_A2H_INT_MAC_EVENT | \
                                 MWL8K_A2H_INT_OPC_DONE | \
                                 MWL8K_A2H_INT_RX_READY | \
-                                 MWL8K_A2H_INT_TX_DONE)
+                                 MWL8K_A2H_INT_TX_DONE | \
+                                 MWL8K_A2H_INT_BA_WATCHDOG)
 #define MWL8K_RX_QUEUES         1
-#define MWL8K_TX_QUEUES         4
+#define MWL8K_TX_WMM_QUEUES     4
+#define MWL8K_MAX_AMPDU_QUEUES  8
+#define MWL8K_MAX_TX_QUEUES     (MWL8K_TX_WMM_QUEUES + MWL8K_MAX_AMPDU_QUEUES)
+#define mwl8k_tx_queues(priv)   (MWL8K_TX_WMM_QUEUES + (priv)->num_ampdu_queues)
 struct rxd_ops {
        int rxd_size;
@@ -134,6 +147,21 @@ struct mwl8k_tx_queue {
        struct sk_buff **skb;
 };
+enum {
+        AMPDU_NO_STREAM,
+        AMPDU_STREAM_NEW,
+        AMPDU_STREAM_IN_PROGRESS,
+        AMPDU_STREAM_ACTIVE,
+};
+struct mwl8k_ampdu_stream {
+        struct ieee80211_sta *sta;
+        u8 tid;
+        u8 state;
+        u8 idx;
+        u8 txq_idx; /* index of this stream in priv->txq */
+};
 struct mwl8k_priv {
        struct ieee80211_hw *hw;
        struct pci_dev *pdev;
@@ -160,6 +188,12 @@ struct mwl8k_priv {
        u32 ap_macids_supported;
        u32 sta_macids_supported;
+        /* Ampdu stream information */
+        u8 num_ampdu_queues;
+        spinlock_t stream_lock;
+        struct mwl8k_ampdu_stream ampdu[MWL8K_MAX_AMPDU_QUEUES];
+        struct work_struct watchdog_ba_handle;
        /* firmware access */
        struct mutex fw_mutex;
        struct task_struct *fw_mutex_owner;
@@ -191,7 +225,8 @@ struct mwl8k_priv {
        int pending_tx_pkts;
        struct mwl8k_rx_queue rxq[MWL8K_RX_QUEUES];
-        struct mwl8k_tx_queue txq[MWL8K_TX_QUEUES];
+        struct mwl8k_tx_queue txq[MWL8K_MAX_TX_QUEUES];
+        u32 txq_offset[MWL8K_MAX_TX_QUEUES];
        bool radio_on;
        bool radio_short_preamble;
@@ -224,7 +259,7 @@ struct mwl8k_priv {
         * preserve the queue configurations so they can be restored if/when
         * the firmware image is swapped.
         */
-        struct ieee80211_tx_queue_params wmm_params[MWL8K_TX_QUEUES];
+        struct ieee80211_tx_queue_params wmm_params[MWL8K_TX_WMM_QUEUES];
        /* async firmware loading state */
        unsigned fw_state;
@@ -262,9 +297,17 @@ struct mwl8k_vif {
 #define MWL8K_VIF(_vif) ((struct mwl8k_vif *)&((_vif)->drv_priv))
 #define IEEE80211_KEY_CONF(_u8) ((struct ieee80211_key_conf *)(_u8))
+struct tx_traffic_info {
+        u32 start_time;
+        u32 pkts;
+};
+#define MWL8K_MAX_TID 8
 struct mwl8k_sta {
        /* Index into station database. Returned by UPDATE_STADB.  */
        u8 peer_id;
+        u8 is_ampdu_allowed;
+        struct tx_traffic_info tx_stats[MWL8K_MAX_TID];
 };
 #define MWL8K_STA(_sta) ((struct mwl8k_sta *)&((_sta)->drv_priv))
@@ -352,10 +395,12 @@ static const struct ieee80211_rate mwl8k_rates_50[] = {
 #define MWL8K_CMD_ENABLE_SNIFFER        0x0150
 #define MWL8K_CMD_SET_MAC_ADDR          0x0202          /* per-vif */
 #define MWL8K_CMD_SET_RATEADAPT_MODE    0x0203
+#define MWL8K_CMD_GET_WATCHDOG_BITMAP   0x0205
 #define MWL8K_CMD_BSS_START             0x1100          /* per-vif */
 #define MWL8K_CMD_SET_NEW_STN           0x1111          /* per-vif */
 #define MWL8K_CMD_UPDATE_ENCRYPTION     0x1122          /* per-vif */
 #define MWL8K_CMD_UPDATE_STADB          0x1123
+#define MWL8K_CMD_BASTREAM              0x1125
 static const char *mwl8k_cmd_name(__le16 cmd, char *buf, int bufsize)
 {
@@ -395,6 +440,8 @@ static const char *mwl8k_cmd_name(__le16 cmd, char *buf, int bufsize)
                MWL8K_CMDNAME(SET_NEW_STN);
                MWL8K_CMDNAME(UPDATE_ENCRYPTION);
                MWL8K_CMDNAME(UPDATE_STADB);
+                MWL8K_CMDNAME(BASTREAM);
+                MWL8K_CMDNAME(GET_WATCHDOG_BITMAP);
        default:
                snprintf(buf, bufsize, "0x%x", cmd);
        }
@@ -669,7 +716,7 @@ static int mwl8k_load_firmware(struct ieee80211_hw *hw)
                               "helper image\n", pci_name(priv->pdev));
                        return rc;
                }
-                msleep(5);
+                msleep(20);
                rc = mwl8k_feed_fw_image(priv, fw->data, fw->size);
        } else {
@@ -734,8 +781,11 @@ static inline void mwl8k_remove_dma_header(struct sk_buff *skb, __le16 qos)
                skb_pull(skb, sizeof(*tr) - hdrlen);
 }
+#define REDUCED_TX_HEADROOM     8
 static void
-mwl8k_add_dma_header(struct sk_buff *skb, int tail_pad)
+mwl8k_add_dma_header(struct mwl8k_priv *priv, struct sk_buff *skb,
+                                                int head_pad, int tail_pad)
 {
        struct ieee80211_hdr *wh;
        int hdrlen;
@@ -751,7 +801,23 @@ mwl8k_add_dma_header(struct sk_buff *skb, int tail_pad)
        wh = (struct ieee80211_hdr *)skb->data;
        hdrlen = ieee80211_hdrlen(wh->frame_control);
-        reqd_hdrlen = sizeof(*tr);
+        /*
+         * Check if skb_resize is required because of
+         * tx_headroom adjustment.
+         */
+        if (priv->ap_fw && (hdrlen < (sizeof(struct ieee80211_cts)
+                                                + REDUCED_TX_HEADROOM))) {
+                if (pskb_expand_head(skb, REDUCED_TX_HEADROOM, 0, GFP_ATOMIC)) {
+                        wiphy_err(priv->hw->wiphy,
+                                        "Failed to reallocate TX buffer\n");
+                        return;
+                }
+                skb->truesize += REDUCED_TX_HEADROOM;
+        }
+        reqd_hdrlen = sizeof(*tr) + head_pad;
        if (hdrlen != reqd_hdrlen)
                skb_push(skb, reqd_hdrlen - hdrlen);
@@ -773,12 +839,14 @@ mwl8k_add_dma_header(struct sk_buff *skb, int tail_pad)
        tr->fwlen = cpu_to_le16(skb->len - sizeof(*tr) + tail_pad);
 }
-static void mwl8k_encapsulate_tx_frame(struct sk_buff *skb)
+static void mwl8k_encapsulate_tx_frame(struct mwl8k_priv *priv,
+                struct sk_buff *skb)
 {
        struct ieee80211_hdr *wh;
        struct ieee80211_tx_info *tx_info;
        struct ieee80211_key_conf *key_conf;
        int data_pad;
+        int head_pad = 0;
        wh = (struct ieee80211_hdr *)skb->data;
@@ -790,9 +858,7 @@ static void mwl8k_encapsulate_tx_frame(struct sk_buff *skb)
        /*
         * Make sure the packet header is in the DMA header format (4-address
-         * without QoS), the necessary crypto padding between the header and the
+         * without QoS), and add head & tail padding when HW crypto is enabled.
-         * payload has already been provided by mac80211, but it doesn't add tail
-         * padding when HW crypto is enabled.
         *
         * We have the following trailer padding requirements:
         * - WEP: 4 trailer bytes (ICV)
@@ -801,6 +867,7 @@ static void mwl8k_encapsulate_tx_frame(struct sk_buff *skb)
         */
        data_pad = 0;
        if (key_conf != NULL) {
+                head_pad = key_conf->iv_len;
                switch (key_conf->cipher) {
                case WLAN_CIPHER_SUITE_WEP40:
                case WLAN_CIPHER_SUITE_WEP104:
@@ -814,7 +881,7 @@ static void mwl8k_encapsulate_tx_frame(struct sk_buff *skb)
                        break;
                }
        }
-        mwl8k_add_dma_header(skb, data_pad);
+        mwl8k_add_dma_header(priv, skb, head_pad, data_pad);
 }
 /*
@@ -1127,6 +1194,9 @@ static void mwl8k_rxq_deinit(struct ieee80211_hw *hw, int index)
        struct mwl8k_rx_queue *rxq = priv->rxq + index;
        int i;
+        if (rxq->rxd == NULL)
+                return;
        for (i = 0; i < MWL8K_RX_DESCS; i++) {
                if (rxq->buf[i].skb != NULL) {
                        pci_unmap_single(priv->pdev,
@@ -1319,7 +1389,7 @@ struct mwl8k_tx_desc {
        __le16 pkt_len;
        __u8 dest_MAC_addr[ETH_ALEN];
        __le32 next_txd_phys_addr;
-        __le32 reserved;
+        __le32 timestamp;
        __le16 rate_info;
        __u8 peer_id;
        __u8 tx_frag_cnt;
@@ -1383,7 +1453,7 @@ static void mwl8k_dump_tx_rings(struct ieee80211_hw *hw)
        struct mwl8k_priv *priv = hw->priv;
        int i;
-        for (i = 0; i < MWL8K_TX_QUEUES; i++) {
+        for (i = 0; i < mwl8k_tx_queues(priv); i++) {
                struct mwl8k_tx_queue *txq = priv->txq + i;
                int fw_owned = 0;
                int drv_owned = 0;
@@ -1452,9 +1522,8 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw)
                if (timeout) {
                        WARN_ON(priv->pending_tx_pkts);
-                        if (retry) {
+                        if (retry)
                                wiphy_notice(hw->wiphy, "tx rings drained\n");
-                        }
                        break;
                }
@@ -1484,6 +1553,41 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw)
                     MWL8K_TXD_STATUS_OK_RETRY |                \
                     MWL8K_TXD_STATUS_OK_MORE_RETRY))
+static int mwl8k_tid_queue_mapping(u8 tid)
+{
+        BUG_ON(tid > 7);
+        switch (tid) {
+        case 0:
+        case 3:
+                return IEEE80211_AC_BE;
+                break;
+        case 1:
+        case 2:
+                return IEEE80211_AC_BK;
+                break;
+        case 4:
+        case 5:
+                return IEEE80211_AC_VI;
+                break;
+        case 6:
+        case 7:
+                return IEEE80211_AC_VO;
+                break;
+        default:
+                return -1;
+                break;
+        }
+}
+/* The firmware will fill in the rate information
+ * for each packet that gets queued in the hardware
+ * and these macros will interpret that info.
+ */
+#define RI_FORMAT(a)              (a & 0x0001)
+#define RI_RATE_ID_MCS(a)        ((a & 0x01f8) >> 3)
 static int
 mwl8k_txq_reclaim(struct ieee80211_hw *hw, int index, int limit, int force)
 {
@@ -1500,6 +1604,10 @@ mwl8k_txq_reclaim(struct ieee80211_hw *hw, int index, int limit, int force)
                struct sk_buff *skb;
                struct ieee80211_tx_info *info;
                u32 status;
+                struct ieee80211_sta *sta;
+                struct mwl8k_sta *sta_info = NULL;
+                u16 rate_info;
+                struct ieee80211_hdr *wh;
                tx = txq->head;
                tx_desc = txq->txd + tx;
@@ -1528,18 +1636,40 @@ mwl8k_txq_reclaim(struct ieee80211_hw *hw, int index, int limit, int force)
                mwl8k_remove_dma_header(skb, tx_desc->qos_control);
+                wh = (struct ieee80211_hdr *) skb->data;
                /* Mark descriptor as unused */
                tx_desc->pkt_phys_addr = 0;
                tx_desc->pkt_len = 0;
                info = IEEE80211_SKB_CB(skb);
+                if (ieee80211_is_data(wh->frame_control)) {
+                        sta = info->control.sta;
+                        if (sta) {
+                                sta_info = MWL8K_STA(sta);
+                                BUG_ON(sta_info == NULL);
+                                rate_info = le16_to_cpu(tx_desc->rate_info);
+                                /* If rate is < 6.5 Mpbs for an ht station
+                                 * do not form an ampdu. If the station is a
+                                 * legacy station (format = 0), do not form an
+                                 * ampdu
+                                 */
+                                if (RI_RATE_ID_MCS(rate_info) < 1 ||
+                                    RI_FORMAT(rate_info) == 0) {
+                                        sta_info->is_ampdu_allowed = false;
+                                } else {
+                                        sta_info->is_ampdu_allowed = true;
+                                }
+                        }
+                }
                ieee80211_tx_info_clear_status(info);
                /* Rate control is happening in the firmware.
                 * Ensure no tx rate is being reported.
                 */
-                info->status.rates[0].idx = -1;
+                info->status.rates[0].idx = -1;
-                info->status.rates[0].count = 1;
+                info->status.rates[0].count = 1;
                if (MWL8K_TXD_SUCCESS(status))
                        info->flags |= IEEE80211_TX_STAT_ACK;
@@ -1549,9 +1679,6 @@ mwl8k_txq_reclaim(struct ieee80211_hw *hw, int index, int limit, int force)
                processed++;
        }
-        if (processed && priv->radio_on && !mutex_is_locked(&priv->fw_mutex))
-                ieee80211_wake_queue(hw, index);
        return processed;
 }
@@ -1561,6 +1688,9 @@ static void mwl8k_txq_deinit(struct ieee80211_hw *hw, int index)
        struct mwl8k_priv *priv = hw->priv;
        struct mwl8k_tx_queue *txq = priv->txq + index;
+        if (txq->txd == NULL)
+                return;
        mwl8k_txq_reclaim(hw, index, INT_MAX, 1);
        kfree(txq->skb);
@@ -1572,12 +1702,116 @@ static void mwl8k_txq_deinit(struct ieee80211_hw *hw, int index)
        txq->txd = NULL;
 }
+/* caller must hold priv->stream_lock when calling the stream functions */
+static struct mwl8k_ampdu_stream *
+mwl8k_add_stream(struct ieee80211_hw *hw, struct ieee80211_sta *sta, u8 tid)
+{
+        struct mwl8k_ampdu_stream *stream;
+        struct mwl8k_priv *priv = hw->priv;
+        int i;
+        for (i = 0; i < priv->num_ampdu_queues; i++) {
+                stream = &priv->ampdu[i];
+                if (stream->state == AMPDU_NO_STREAM) {
+                        stream->sta = sta;
+                        stream->state = AMPDU_STREAM_NEW;
+                        stream->tid = tid;
+                        stream->idx = i;
+                        stream->txq_idx = MWL8K_TX_WMM_QUEUES + i;
+                        wiphy_debug(hw->wiphy, "Added a new stream for %pM %d",
+                                    sta->addr, tid);
+                        return stream;
+                }
+        }
+        return NULL;
+}
+static int
+mwl8k_start_stream(struct ieee80211_hw *hw, struct mwl8k_ampdu_stream *stream)
+{
+        int ret;
+        /* if the stream has already been started, don't start it again */
+        if (stream->state != AMPDU_STREAM_NEW)
+                return 0;
+        ret = ieee80211_start_tx_ba_session(stream->sta, stream->tid, 0);
+        if (ret)
+                wiphy_debug(hw->wiphy, "Failed to start stream for %pM %d: "
+                            "%d\n", stream->sta->addr, stream->tid, ret);
+        else
+                wiphy_debug(hw->wiphy, "Started stream for %pM %d\n",
+                            stream->sta->addr, stream->tid);
+        return ret;
+}
+static void
+mwl8k_remove_stream(struct ieee80211_hw *hw, struct mwl8k_ampdu_stream *stream)
+{
+        wiphy_debug(hw->wiphy, "Remove stream for %pM %d\n", stream->sta->addr,
+                    stream->tid);
+        memset(stream, 0, sizeof(*stream));
+}
+static struct mwl8k_ampdu_stream *
+mwl8k_lookup_stream(struct ieee80211_hw *hw, u8 *addr, u8 tid)
+{
+        struct mwl8k_priv *priv = hw->priv;
+        int i;
+        for (i = 0 ; i < priv->num_ampdu_queues; i++) {
+                struct mwl8k_ampdu_stream *stream;
+                stream = &priv->ampdu[i];
+                if (stream->state == AMPDU_NO_STREAM)
+                        continue;
+                if (!memcmp(stream->sta->addr, addr, ETH_ALEN) &&
+                    stream->tid == tid)
+                        return stream;
+        }
+        return NULL;
+}
+#define MWL8K_AMPDU_PACKET_THRESHOLD 64
+static inline bool mwl8k_ampdu_allowed(struct ieee80211_sta *sta, u8 tid)
+{
+        struct mwl8k_sta *sta_info = MWL8K_STA(sta);
+        struct tx_traffic_info *tx_stats;
+        BUG_ON(tid >= MWL8K_MAX_TID);
+        tx_stats = &sta_info->tx_stats[tid];
+        return sta_info->is_ampdu_allowed &&
+                tx_stats->pkts > MWL8K_AMPDU_PACKET_THRESHOLD;
+}
+static inline void mwl8k_tx_count_packet(struct ieee80211_sta *sta, u8 tid)
+{
+        struct mwl8k_sta *sta_info = MWL8K_STA(sta);
+        struct tx_traffic_info *tx_stats;
+        BUG_ON(tid >= MWL8K_MAX_TID);
+        tx_stats = &sta_info->tx_stats[tid];
+        if (tx_stats->start_time == 0)
+                tx_stats->start_time = jiffies;
+        /* reset the packet count after each second elapses.  If the number of
+         * packets ever exceeds the ampdu_min_traffic threshold, we will allow
+         * an ampdu stream to be started.
+         */
+        if (jiffies - tx_stats->start_time > HZ) {
+                tx_stats->pkts = 0;
+                tx_stats->start_time = 0;
+        } else
+                tx_stats->pkts++;
+}
 static void
 mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
 {
        struct mwl8k_priv *priv = hw->priv;
        struct ieee80211_tx_info *tx_info;
        struct mwl8k_vif *mwl8k_vif;
+        struct ieee80211_sta *sta;
        struct ieee80211_hdr *wh;
        struct mwl8k_tx_queue *txq;
        struct mwl8k_tx_desc *tx;
@@ -1585,6 +1819,12 @@ mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
        u32 txstatus;
        u8 txdatarate;
        u16 qos;
+        int txpriority;
+        u8 tid = 0;
+        struct mwl8k_ampdu_stream *stream = NULL;
+        bool start_ba_session = false;
+        bool mgmtframe = false;
+        struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)skb->data;
        wh = (struct ieee80211_hdr *)skb->data;
        if (ieee80211_is_data_qos(wh->frame_control))
@@ -1592,14 +1832,18 @@ mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
        else
                qos = 0;
+        if (ieee80211_is_mgmt(wh->frame_control))
+                mgmtframe = true;
        if (priv->ap_fw)
-                mwl8k_encapsulate_tx_frame(skb);
+                mwl8k_encapsulate_tx_frame(priv, skb);
        else
-                mwl8k_add_dma_header(skb, 0);
+                mwl8k_add_dma_header(priv, skb, 0, 0);
        wh = &((struct mwl8k_dma_data *)skb->data)->wh;
        tx_info = IEEE80211_SKB_CB(skb);
+        sta = tx_info->control.sta;
        mwl8k_vif = MWL8K_VIF(tx_info->control.vif);
        if (tx_info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ) {
@@ -1627,12 +1871,91 @@ mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
                        qos |= MWL8K_QOS_ACK_POLICY_NORMAL;
        }
+        /* Queue ADDBA request in the respective data queue.  While setting up
+         * the ampdu stream, mac80211 queues further packets for that
+         * particular ra/tid pair.  However, packets piled up in the hardware
+         * for that ra/tid pair will still go out. ADDBA request and the
+         * related data packets going out from different queues asynchronously
+         * will cause a shift in the receiver window which might result in
+         * ampdu packets getting dropped at the receiver after the stream has
+         * been setup.
+         */
+        if (unlikely(ieee80211_is_action(wh->frame_control) &&
+            mgmt->u.action.category == WLAN_CATEGORY_BACK &&
+            mgmt->u.action.u.addba_req.action_code == WLAN_ACTION_ADDBA_REQ &&
+            priv->ap_fw)) {
+                u16 capab = le16_to_cpu(mgmt->u.action.u.addba_req.capab);
+                tid = (capab & IEEE80211_ADDBA_PARAM_TID_MASK) >> 2;
+                index = mwl8k_tid_queue_mapping(tid);
+        }
+        txpriority = index;
+        if (ieee80211_is_data_qos(wh->frame_control) &&
+            skb->protocol != cpu_to_be16(ETH_P_PAE) &&
+            sta->ht_cap.ht_supported && priv->ap_fw) {
+                tid = qos & 0xf;
+                mwl8k_tx_count_packet(sta, tid);
+                spin_lock(&priv->stream_lock);
+                stream = mwl8k_lookup_stream(hw, sta->addr, tid);
+                if (stream != NULL) {
+                        if (stream->state == AMPDU_STREAM_ACTIVE) {
+                                txpriority = stream->txq_idx;
+                                index = stream->txq_idx;
+                        } else if (stream->state == AMPDU_STREAM_NEW) {
+                                /* We get here if the driver sends us packets
+                                 * after we've initiated a stream, but before
+                                 * our ampdu_action routine has been called
+                                 * with IEEE80211_AMPDU_TX_START to get the SSN
+                                 * for the ADDBA request.  So this packet can
+                                 * go out with no risk of sequence number
+                                 * mismatch.  No special handling is required.
+                                 */
+                        } else {
+                                /* Drop packets that would go out after the
+                                 * ADDBA request was sent but before the ADDBA
+                                 * response is received.  If we don't do this,
+                                 * the recipient would probably receive it
+                                 * after the ADDBA request with SSN 0.  This
+                                 * will cause the recipient's BA receive window
+                                 * to shift, which would cause the subsequent
+                                 * packets in the BA stream to be discarded.
+                                 * mac80211 queues our packets for us in this
+                                 * case, so this is really just a safety check.
+                                 */
+                                wiphy_warn(hw->wiphy,
+                                           "Cannot send packet while ADDBA "
+                                           "dialog is underway.\n");
+                                spin_unlock(&priv->stream_lock);
+                                dev_kfree_skb(skb);
+                                return;
+                        }
+                } else {
+                        /* Defer calling mwl8k_start_stream so that the current
+                         * skb can go out before the ADDBA request.  This
+                         * prevents sequence number mismatch at the recepient
+                         * as described above.
+                         */
+                        if (mwl8k_ampdu_allowed(sta, tid)) {
+                                stream = mwl8k_add_stream(hw, sta, tid);
+                                if (stream != NULL)
+                                        start_ba_session = true;
+                        }
+                }
+                spin_unlock(&priv->stream_lock);
+        }
        dma = pci_map_single(priv->pdev, skb->data,
                                skb->len, PCI_DMA_TODEVICE);
        if (pci_dma_mapping_error(priv->pdev, dma)) {
                wiphy_debug(hw->wiphy,
                            "failed to dma map skb, dropping TX frame.\n");
+                if (start_ba_session) {
+                        spin_lock(&priv->stream_lock);
+                        mwl8k_remove_stream(hw, stream);
+                        spin_unlock(&priv->stream_lock);
+                }
                dev_kfree_skb(skb);
                return;
        }
@@ -1641,12 +1964,34 @@ mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
        txq = priv->txq + index;
+        /* Mgmt frames that go out frequently are probe
+         * responses. Other mgmt frames got out relatively
+         * infrequently. Hence reserve 2 buffers so that
+         * other mgmt frames do not get dropped due to an
+         * already queued probe response in one of the
+         * reserved buffers.
+         */
+        if (txq->len >= MWL8K_TX_DESCS - 2) {
+                if (mgmtframe == false ||
+                        txq->len == MWL8K_TX_DESCS) {
+                        if (start_ba_session) {
+                                spin_lock(&priv->stream_lock);
+                                mwl8k_remove_stream(hw, stream);
+                                spin_unlock(&priv->stream_lock);
+                        }
+                        spin_unlock_bh(&priv->tx_lock);
+                        dev_kfree_skb(skb);
+                        return;
+                }
+        }
        BUG_ON(txq->skb[txq->tail] != NULL);
        txq->skb[txq->tail] = skb;
        tx = txq->txd + txq->tail;
        tx->data_rate = txdatarate;
-        tx->tx_priority = index;
+        tx->tx_priority = txpriority;
        tx->qos_control = cpu_to_le16(qos);
        tx->pkt_phys_addr = cpu_to_le32(dma);
        tx->pkt_len = cpu_to_le16(skb->len);
@@ -1655,6 +2000,11 @@ mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
                tx->peer_id = MWL8K_STA(tx_info->control.sta)->peer_id;
        else
                tx->peer_id = 0;
+        if (priv->ap_fw)
+                tx->timestamp = cpu_to_le32(ioread32(priv->regs +
+                                                MWL8K_HW_TIMER_REGISTER));
        wmb();
        tx->status = cpu_to_le32(MWL8K_TXD_STATUS_FW_OWNED | txstatus);
@@ -1665,12 +2015,17 @@ mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
        if (txq->tail == MWL8K_TX_DESCS)
                txq->tail = 0;
-        if (txq->head == txq->tail)
-                ieee80211_stop_queue(hw, index);
        mwl8k_tx_start(priv);
        spin_unlock_bh(&priv->tx_lock);
+        /* Initiate the ampdu session here */
+        if (start_ba_session) {
+                spin_lock(&priv->stream_lock);
+                if (mwl8k_start_stream(hw, stream))
+                        mwl8k_remove_stream(hw, stream);
+                spin_unlock(&priv->stream_lock);
+        }
 }
@@ -1868,7 +2223,7 @@ struct mwl8k_cmd_get_hw_spec_sta {
        __u8 mcs_bitmap[16];
        __le32 rx_queue_ptr;
        __le32 num_tx_queues;
-        __le32 tx_queue_ptrs[MWL8K_TX_QUEUES];
+        __le32 tx_queue_ptrs[MWL8K_TX_WMM_QUEUES];
        __le32 caps2;
        __le32 num_tx_desc_per_queue;
        __le32 total_rxd;
@@ -1974,8 +2329,8 @@ static int mwl8k_cmd_get_hw_spec_sta(struct ieee80211_hw *hw)
        memset(cmd->perm_addr, 0xff, sizeof(cmd->perm_addr));
        cmd->ps_cookie = cpu_to_le32(priv->cookie_dma);
        cmd->rx_queue_ptr = cpu_to_le32(priv->rxq[0].rxd_dma);
-        cmd->num_tx_queues = cpu_to_le32(MWL8K_TX_QUEUES);
+        cmd->num_tx_queues = cpu_to_le32(mwl8k_tx_queues(priv));
-        for (i = 0; i < MWL8K_TX_QUEUES; i++)
+        for (i = 0; i < mwl8k_tx_queues(priv); i++)
                cmd->tx_queue_ptrs[i] = cpu_to_le32(priv->txq[i].txd_dma);
        cmd->num_tx_desc_per_queue = cpu_to_le32(MWL8K_TX_DESCS);
        cmd->total_rxd = cpu_to_le32(MWL8K_RX_DESCS);
@@ -2017,13 +2372,16 @@ struct mwl8k_cmd_get_hw_spec_ap {
        __le32 wcbbase2;
        __le32 wcbbase3;
        __le32 fw_api_version;
+        __le32 caps;
+        __le32 num_of_ampdu_queues;
+        __le32 wcbbase_ampdu[MWL8K_MAX_AMPDU_QUEUES];
 } __packed;
 static int mwl8k_cmd_get_hw_spec_ap(struct ieee80211_hw *hw)
 {
        struct mwl8k_priv *priv = hw->priv;
        struct mwl8k_cmd_get_hw_spec_ap *cmd;
-        int rc;
+        int rc, i;
        u32 api_version;
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
@@ -2055,27 +2413,31 @@ static int mwl8k_cmd_get_hw_spec_ap(struct ieee80211_hw *hw)
                priv->num_mcaddrs = le16_to_cpu(cmd->num_mcaddrs);
                priv->fw_rev = le32_to_cpu(cmd->fw_rev);
                priv->hw_rev = cmd->hw_rev;
-                mwl8k_setup_2ghz_band(hw);
+                mwl8k_set_caps(hw, le32_to_cpu(cmd->caps));
                priv->ap_macids_supported = 0x000000ff;
                priv->sta_macids_supported = 0x00000000;
+                priv->num_ampdu_queues = le32_to_cpu(cmd->num_of_ampdu_queues);
-                off = le32_to_cpu(cmd->wcbbase0) & 0xffff;
+                if (priv->num_ampdu_queues > MWL8K_MAX_AMPDU_QUEUES) {
-                iowrite32(priv->txq[0].txd_dma, priv->sram + off);
+                        wiphy_warn(hw->wiphy, "fw reported %d ampdu queues"
+                                   " but we only support %d.\n",
+                                   priv->num_ampdu_queues,
+                                   MWL8K_MAX_AMPDU_QUEUES);
+                        priv->num_ampdu_queues = MWL8K_MAX_AMPDU_QUEUES;
+                }
                off = le32_to_cpu(cmd->rxwrptr) & 0xffff;
                iowrite32(priv->rxq[0].rxd_dma, priv->sram + off);
                off = le32_to_cpu(cmd->rxrdptr) & 0xffff;
                iowrite32(priv->rxq[0].rxd_dma, priv->sram + off);
-                off = le32_to_cpu(cmd->wcbbase1) & 0xffff;
+                priv->txq_offset[0] = le32_to_cpu(cmd->wcbbase0) & 0xffff;
-                iowrite32(priv->txq[1].txd_dma, priv->sram + off);
+                priv->txq_offset[1] = le32_to_cpu(cmd->wcbbase1) & 0xffff;
+                priv->txq_offset[2] = le32_to_cpu(cmd->wcbbase2) & 0xffff;
+                priv->txq_offset[3] = le32_to_cpu(cmd->wcbbase3) & 0xffff;
-                off = le32_to_cpu(cmd->wcbbase2) & 0xffff;
+                for (i = 0; i < priv->num_ampdu_queues; i++)
-                iowrite32(priv->txq[2].txd_dma, priv->sram + off);
+                        priv->txq_offset[i + MWL8K_TX_WMM_QUEUES] =
+                                le32_to_cpu(cmd->wcbbase_ampdu[i]) & 0xffff;
-                off = le32_to_cpu(cmd->wcbbase3) & 0xffff;
-                iowrite32(priv->txq[3].txd_dma, priv->sram + off);
        }
 done:
@@ -2098,12 +2460,20 @@ struct mwl8k_cmd_set_hw_spec {
        __le32 caps;
        __le32 rx_queue_ptr;
        __le32 num_tx_queues;
-        __le32 tx_queue_ptrs[MWL8K_TX_QUEUES];
+        __le32 tx_queue_ptrs[MWL8K_MAX_TX_QUEUES];
        __le32 flags;
        __le32 num_tx_desc_per_queue;
        __le32 total_rxd;
 } __packed;
+/* If enabled, MWL8K_SET_HW_SPEC_FLAG_ENABLE_LIFE_TIME_EXPIRY will cause
+ * packets to expire 500 ms after the timestamp in the tx descriptor.  That is,
+ * the packets that are queued for more than 500ms, will be dropped in the
+ * hardware. This helps minimizing the issues caused due to head-of-line
+ * blocking where a slow client can hog the bandwidth and affect traffic to a
+ * faster client.
+ */
+#define MWL8K_SET_HW_SPEC_FLAG_ENABLE_LIFE_TIME_EXPIRY  0x00000400
 #define MWL8K_SET_HW_SPEC_FLAG_HOST_DECR_MGMT           0x00000080
 #define MWL8K_SET_HW_SPEC_FLAG_HOSTFORM_PROBERESP       0x00000020
 #define MWL8K_SET_HW_SPEC_FLAG_HOSTFORM_BEACON          0x00000010
@@ -2124,7 +2494,7 @@ static int mwl8k_cmd_set_hw_spec(struct ieee80211_hw *hw)
        cmd->ps_cookie = cpu_to_le32(priv->cookie_dma);
        cmd->rx_queue_ptr = cpu_to_le32(priv->rxq[0].rxd_dma);
-        cmd->num_tx_queues = cpu_to_le32(MWL8K_TX_QUEUES);
+        cmd->num_tx_queues = cpu_to_le32(mwl8k_tx_queues(priv));
        /*
         * Mac80211 stack has Q0 as highest priority and Q3 as lowest in
@@ -2132,14 +2502,15 @@ static int mwl8k_cmd_set_hw_spec(struct ieee80211_hw *hw)
         * in that order. Map Q3 of mac80211 to Q0 of firmware so that the
         * priority is interpreted the right way in firmware.
         */
-        for (i = 0; i < MWL8K_TX_QUEUES; i++) {
+        for (i = 0; i < mwl8k_tx_queues(priv); i++) {
-                int j = MWL8K_TX_QUEUES - 1 - i;
+                int j = mwl8k_tx_queues(priv) - 1 - i;
                cmd->tx_queue_ptrs[i] = cpu_to_le32(priv->txq[j].txd_dma);
        }
        cmd->flags = cpu_to_le32(MWL8K_SET_HW_SPEC_FLAG_HOST_DECR_MGMT |
                                 MWL8K_SET_HW_SPEC_FLAG_HOSTFORM_PROBERESP |
-                                 MWL8K_SET_HW_SPEC_FLAG_HOSTFORM_BEACON);
+                                 MWL8K_SET_HW_SPEC_FLAG_HOSTFORM_BEACON |
+                                 MWL8K_SET_HW_SPEC_FLAG_ENABLE_LIFE_TIME_EXPIRY);
        cmd->num_tx_desc_per_queue = cpu_to_le32(MWL8K_TX_DESCS);
        cmd->total_rxd = cpu_to_le32(MWL8K_RX_DESCS);
@@ -2356,7 +2727,7 @@ struct mwl8k_cmd_tx_power {
        __le16 bw;
        __le16 sub_ch;
        __le16 power_level_list[MWL8K_TX_POWER_LEVEL_TOTAL];
-} __attribute__((packed));
+} __packed;
 static int mwl8k_cmd_tx_power(struct ieee80211_hw *hw,
                                     struct ieee80211_conf *conf,
@@ -3123,6 +3494,65 @@ static int mwl8k_cmd_set_rateadapt_mode(struct ieee80211_hw *hw, __u16 mode)
 }
 /*
+ * CMD_GET_WATCHDOG_BITMAP.
+ */
+struct mwl8k_cmd_get_watchdog_bitmap {
+        struct mwl8k_cmd_pkt header;
+        u8      bitmap;
+} __packed;
+static int mwl8k_cmd_get_watchdog_bitmap(struct ieee80211_hw *hw, u8 *bitmap)
+{
+        struct mwl8k_cmd_get_watchdog_bitmap *cmd;
+        int rc;
+        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+        if (cmd == NULL)
+                return -ENOMEM;
+        cmd->header.code = cpu_to_le16(MWL8K_CMD_GET_WATCHDOG_BITMAP);
+        cmd->header.length = cpu_to_le16(sizeof(*cmd));
+        rc = mwl8k_post_cmd(hw, &cmd->header);
+        if (!rc)
+                *bitmap = cmd->bitmap;
+        kfree(cmd);
+        return rc;
+}
+#define INVALID_BA      0xAA
+static void mwl8k_watchdog_ba_events(struct work_struct *work)
+{
+        int rc;
+        u8 bitmap = 0, stream_index;
+        struct mwl8k_ampdu_stream *streams;
+        struct mwl8k_priv *priv =
+                container_of(work, struct mwl8k_priv, watchdog_ba_handle);
+        rc = mwl8k_cmd_get_watchdog_bitmap(priv->hw, &bitmap);
+        if (rc)
+                return;
+        if (bitmap == INVALID_BA)
+                return;
+        /* the bitmap is the hw queue number.  Map it to the ampdu queue. */
+        stream_index = bitmap - MWL8K_TX_WMM_QUEUES;
+        BUG_ON(stream_index >= priv->num_ampdu_queues);
+        streams = &priv->ampdu[stream_index];
+        if (streams->state == AMPDU_STREAM_ACTIVE)
+                ieee80211_stop_tx_ba_session(streams->sta, streams->tid);
+        return;
+}
+/*
 * CMD_BSS_START.
 */
 struct mwl8k_cmd_bss_start {
@@ -3151,6 +3581,152 @@ static int mwl8k_cmd_bss_start(struct ieee80211_hw *hw,
 }
 /*
+ * CMD_BASTREAM.
+ */
+/*
+ * UPSTREAM is tx direction
+ */
+#define BASTREAM_FLAG_DIRECTION_UPSTREAM        0x00
+#define BASTREAM_FLAG_IMMEDIATE_TYPE            0x01
+enum ba_stream_action_type {
+        MWL8K_BA_CREATE,
+        MWL8K_BA_UPDATE,
+        MWL8K_BA_DESTROY,
+        MWL8K_BA_FLUSH,
+        MWL8K_BA_CHECK,
+};
+struct mwl8k_create_ba_stream {
+        __le32  flags;
+        __le32  idle_thrs;
+        __le32  bar_thrs;
+        __le32  window_size;
+        u8      peer_mac_addr[6];
+        u8      dialog_token;
+        u8      tid;
+        u8      queue_id;
+        u8      param_info;
+        __le32  ba_context;
+        u8      reset_seq_no_flag;
+        __le16  curr_seq_no;
+        u8      sta_src_mac_addr[6];
+} __packed;
+struct mwl8k_destroy_ba_stream {
+        __le32  flags;
+        __le32  ba_context;
+} __packed;
+struct mwl8k_cmd_bastream {
+        struct mwl8k_cmd_pkt    header;
+        __le32  action;
+        union {
+                struct mwl8k_create_ba_stream   create_params;
+                struct mwl8k_destroy_ba_stream  destroy_params;
+        };
+} __packed;
+static int
+mwl8k_check_ba(struct ieee80211_hw *hw, struct mwl8k_ampdu_stream *stream)
+{
+        struct mwl8k_cmd_bastream *cmd;
+        int rc;
+        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+        if (cmd == NULL)
+                return -ENOMEM;
+        cmd->header.code = cpu_to_le16(MWL8K_CMD_BASTREAM);
+        cmd->header.length = cpu_to_le16(sizeof(*cmd));
+        cmd->action = cpu_to_le32(MWL8K_BA_CHECK);
+        cmd->create_params.queue_id = stream->idx;
+        memcpy(&cmd->create_params.peer_mac_addr[0], stream->sta->addr,
+               ETH_ALEN);
+        cmd->create_params.tid = stream->tid;
+        cmd->create_params.flags =
+                cpu_to_le32(BASTREAM_FLAG_IMMEDIATE_TYPE) |
+                cpu_to_le32(BASTREAM_FLAG_DIRECTION_UPSTREAM);
+        rc = mwl8k_post_cmd(hw, &cmd->header);
+        kfree(cmd);
+        return rc;
+}
+static int
+mwl8k_create_ba(struct ieee80211_hw *hw, struct mwl8k_ampdu_stream *stream,
+                u8 buf_size)
+{
+        struct mwl8k_cmd_bastream *cmd;
+        int rc;
+        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+        if (cmd == NULL)
+                return -ENOMEM;
+        cmd->header.code = cpu_to_le16(MWL8K_CMD_BASTREAM);
+        cmd->header.length = cpu_to_le16(sizeof(*cmd));
+        cmd->action = cpu_to_le32(MWL8K_BA_CREATE);
+        cmd->create_params.bar_thrs = cpu_to_le32((u32)buf_size);
+        cmd->create_params.window_size = cpu_to_le32((u32)buf_size);
+        cmd->create_params.queue_id = stream->idx;
+        memcpy(cmd->create_params.peer_mac_addr, stream->sta->addr, ETH_ALEN);
+        cmd->create_params.tid = stream->tid;
+        cmd->create_params.curr_seq_no = cpu_to_le16(0);
+        cmd->create_params.reset_seq_no_flag = 1;
+        cmd->create_params.param_info =
+                (stream->sta->ht_cap.ampdu_factor &
+                 IEEE80211_HT_AMPDU_PARM_FACTOR) |
+                ((stream->sta->ht_cap.ampdu_density << 2) &
+                 IEEE80211_HT_AMPDU_PARM_DENSITY);
+        cmd->create_params.flags =
+                cpu_to_le32(BASTREAM_FLAG_IMMEDIATE_TYPE |
+                                        BASTREAM_FLAG_DIRECTION_UPSTREAM);
+        rc = mwl8k_post_cmd(hw, &cmd->header);
+        wiphy_debug(hw->wiphy, "Created a BA stream for %pM : tid %d\n",
+                stream->sta->addr, stream->tid);
+        kfree(cmd);
+        return rc;
+}
+static void mwl8k_destroy_ba(struct ieee80211_hw *hw,
+                             struct mwl8k_ampdu_stream *stream)
+{
+        struct mwl8k_cmd_bastream *cmd;
+        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+        if (cmd == NULL)
+                return;
+        cmd->header.code = cpu_to_le16(MWL8K_CMD_BASTREAM);
+        cmd->header.length = cpu_to_le16(sizeof(*cmd));
+        cmd->action = cpu_to_le32(MWL8K_BA_DESTROY);
+        cmd->destroy_params.ba_context = cpu_to_le32(stream->idx);
+        mwl8k_post_cmd(hw, &cmd->header);
+        wiphy_debug(hw->wiphy, "Deleted BA stream index %d\n", stream->idx);
+        kfree(cmd);
+}
+/*
 * CMD_SET_NEW_STN.
 */
 struct mwl8k_cmd_set_new_stn {
@@ -3274,7 +3850,7 @@ struct mwl8k_cmd_update_encryption {
        __u8 mac_addr[6];
        __u8 encr_type;
-} __attribute__((packed));
+} __packed;
 struct mwl8k_cmd_set_key {
        struct mwl8k_cmd_pkt header;
@@ -3294,7 +3870,7 @@ struct mwl8k_cmd_set_key {
        __le16 tkip_tsc_low;
        __le32 tkip_tsc_high;
        __u8 mac_addr[6];
-} __attribute__((packed));
+} __packed;
 enum {
        MWL8K_ENCR_ENABLE,
@@ -3422,7 +3998,7 @@ static int mwl8k_cmd_encryption_set_key(struct ieee80211_hw *hw,
                        mwl8k_vif->wep_key_conf[idx].enabled = 1;
                }
-                keymlen = 0;
+                keymlen = key->keylen;
                action = MWL8K_ENCR_SET_KEY;
                break;
        case WLAN_CIPHER_SUITE_TKIP:
@@ -3496,7 +4072,6 @@ static int mwl8k_set_key(struct ieee80211_hw *hw,
                addr = sta->addr;
        if (cmd_param == SET_KEY) {
-                key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
                rc = mwl8k_cmd_encryption_set_key(hw, vif, addr, key);
                if (rc)
                        goto out;
@@ -3671,6 +4246,11 @@ static irqreturn_t mwl8k_interrupt(int irq, void *dev_id)
                tasklet_schedule(&priv->poll_rx_task);
        }
+        if (status & MWL8K_A2H_INT_BA_WATCHDOG) {
+                status &= ~MWL8K_A2H_INT_BA_WATCHDOG;
+                ieee80211_queue_work(hw, &priv->watchdog_ba_handle);
+        }
        if (status)
                iowrite32(~status, priv->regs + MWL8K_HIU_A2H_INTERRUPT_STATUS);
@@ -3699,7 +4279,7 @@ static void mwl8k_tx_poll(unsigned long data)
        spin_lock_bh(&priv->tx_lock);
-        for (i = 0; i < MWL8K_TX_QUEUES; i++)
+        for (i = 0; i < mwl8k_tx_queues(priv); i++)
                limit -= mwl8k_txq_reclaim(hw, i, limit, 0);
        if (!priv->pending_tx_pkts && priv->tx_wait != NULL) {
@@ -3774,6 +4354,8 @@ static int mwl8k_start(struct ieee80211_hw *hw)
        /* Enable interrupts */
        iowrite32(MWL8K_A2H_EVENTS, priv->regs + MWL8K_HIU_A2H_INTERRUPT_MASK);
+        iowrite32(MWL8K_A2H_EVENTS,
+                  priv->regs + MWL8K_HIU_A2H_INTERRUPT_STATUS_MASK);
        rc = mwl8k_fw_lock(hw);
        if (!rc) {
@@ -3829,6 +4411,7 @@ static void mwl8k_stop(struct ieee80211_hw *hw)
        /* Stop finalize join worker */
        cancel_work_sync(&priv->finalize_join_worker);
+        cancel_work_sync(&priv->watchdog_ba_handle);
        if (priv->beacon_skb != NULL)
                dev_kfree_skb(priv->beacon_skb);
@@ -3837,7 +4420,7 @@ static void mwl8k_stop(struct ieee80211_hw *hw)
        tasklet_disable(&priv->poll_rx_task);
        /* Return all skbs to mac80211 */
-        for (i = 0; i < MWL8K_TX_QUEUES; i++)
+        for (i = 0; i < mwl8k_tx_queues(priv); i++)
                mwl8k_txq_reclaim(hw, i, INT_MAX, 1);
 }
@@ -3958,9 +4541,12 @@ static int mwl8k_config(struct ieee80211_hw *hw, u32 changed)
                conf->power_level = 18;
        if (priv->ap_fw) {
-                rc = mwl8k_cmd_tx_power(hw, conf, conf->power_level);
-                if (rc)
+                if (conf->flags & IEEE80211_CONF_CHANGE_POWER) {
-                        goto out;
+                        rc = mwl8k_cmd_tx_power(hw, conf, conf->power_level);
+                        if (rc)
+                                goto out;
+                }
                rc = mwl8k_cmd_rf_antenna(hw, MWL8K_RF_ANTENNA_RX, 0x3);
                if (rc)
@@ -3987,7 +4573,7 @@ mwl8k_bss_info_changed_sta(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
                           struct ieee80211_bss_conf *info, u32 changed)
 {
        struct mwl8k_priv *priv = hw->priv;
-        u32 ap_legacy_rates;
+        u32 ap_legacy_rates = 0;
        u8 ap_mcs_rates[16];
        int rc;
@@ -4312,6 +4898,8 @@ static int mwl8k_sta_add(struct ieee80211_hw *hw,
                ret = mwl8k_cmd_update_stadb_add(hw, vif, sta);
                if (ret >= 0) {
                        MWL8K_STA(sta)->peer_id = ret;
+                        if (sta->ht_cap.ht_supported)
+                                MWL8K_STA(sta)->is_ampdu_allowed = true;
                        ret = 0;
                }
@@ -4335,14 +4923,14 @@ static int mwl8k_conf_tx(struct ieee80211_hw *hw, u16 queue,
        rc = mwl8k_fw_lock(hw);
        if (!rc) {
-                BUG_ON(queue > MWL8K_TX_QUEUES - 1);
+                BUG_ON(queue > MWL8K_TX_WMM_QUEUES - 1);
                memcpy(&priv->wmm_params[queue], params, sizeof(*params));
                if (!priv->wmm_enabled)
                        rc = mwl8k_cmd_set_wmm_mode(hw, 1);
                if (!rc) {
-                        int q = MWL8K_TX_QUEUES - 1 - queue;
+                        int q = MWL8K_TX_WMM_QUEUES - 1 - queue;
                        rc = mwl8k_cmd_set_edca_params(hw, q,
                                                       params->cw_min,
                                                       params->cw_max,
@@ -4378,21 +4966,118 @@ static int mwl8k_get_survey(struct ieee80211_hw *hw, int idx,
        return 0;
 }
+#define MAX_AMPDU_ATTEMPTS 5
 static int
 mwl8k_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
                   enum ieee80211_ampdu_mlme_action action,
                   struct ieee80211_sta *sta, u16 tid, u16 *ssn,
                   u8 buf_size)
 {
+        int i, rc = 0;
+        struct mwl8k_priv *priv = hw->priv;
+        struct mwl8k_ampdu_stream *stream;
+        u8 *addr = sta->addr;
+        if (!(hw->flags & IEEE80211_HW_AMPDU_AGGREGATION))
+                return -ENOTSUPP;
+        spin_lock(&priv->stream_lock);
+        stream = mwl8k_lookup_stream(hw, addr, tid);
        switch (action) {
        case IEEE80211_AMPDU_RX_START:
        case IEEE80211_AMPDU_RX_STOP:
-                if (!(hw->flags & IEEE80211_HW_AMPDU_AGGREGATION))
+                break;
-                        return -ENOTSUPP;
+        case IEEE80211_AMPDU_TX_START:
-                return 0;
+                /* By the time we get here the hw queues may contain outgoing
+                 * packets for this RA/TID that are not part of this BA
+                 * session.  The hw will assign sequence numbers to these
+                 * packets as they go out.  So if we query the hw for its next
+                 * sequence number and use that for the SSN here, it may end up
+                 * being wrong, which will lead to sequence number mismatch at
+                 * the recipient.  To avoid this, we reset the sequence number
+                 * to O for the first MPDU in this BA stream.
+                 */
+                *ssn = 0;
+                if (stream == NULL) {
+                        /* This means that somebody outside this driver called
+                         * ieee80211_start_tx_ba_session.  This is unexpected
+                         * because we do our own rate control.  Just warn and
+                         * move on.
+                         */
+                        wiphy_warn(hw->wiphy, "Unexpected call to %s.  "
+                                   "Proceeding anyway.\n", __func__);
+                        stream = mwl8k_add_stream(hw, sta, tid);
+                }
+                if (stream == NULL) {
+                        wiphy_debug(hw->wiphy, "no free AMPDU streams\n");
+                        rc = -EBUSY;
+                        break;
+                }
+                stream->state = AMPDU_STREAM_IN_PROGRESS;
+                /* Release the lock before we do the time consuming stuff */
+                spin_unlock(&priv->stream_lock);
+                for (i = 0; i < MAX_AMPDU_ATTEMPTS; i++) {
+                        rc = mwl8k_check_ba(hw, stream);
+                        if (!rc)
+                                break;
+                        /*
+                         * HW queues take time to be flushed, give them
+                         * sufficient time
+                         */
+                        msleep(1000);
+                }
+                spin_lock(&priv->stream_lock);
+                if (rc) {
+                        wiphy_err(hw->wiphy, "Stream for tid %d busy after %d"
+                                " attempts\n", tid, MAX_AMPDU_ATTEMPTS);
+                        mwl8k_remove_stream(hw, stream);
+                        rc = -EBUSY;
+                        break;
+                }
+                ieee80211_start_tx_ba_cb_irqsafe(vif, addr, tid);
+                break;
+        case IEEE80211_AMPDU_TX_STOP:
+                if (stream == NULL)
+                        break;
+                if (stream->state == AMPDU_STREAM_ACTIVE) {
+                        spin_unlock(&priv->stream_lock);
+                        mwl8k_destroy_ba(hw, stream);
+                        spin_lock(&priv->stream_lock);
+                }
+                mwl8k_remove_stream(hw, stream);
+                ieee80211_stop_tx_ba_cb_irqsafe(vif, addr, tid);
+                break;
+        case IEEE80211_AMPDU_TX_OPERATIONAL:
+                BUG_ON(stream == NULL);
+                BUG_ON(stream->state != AMPDU_STREAM_IN_PROGRESS);
+                spin_unlock(&priv->stream_lock);
+                rc = mwl8k_create_ba(hw, stream, buf_size);
+                spin_lock(&priv->stream_lock);
+                if (!rc)
+                        stream->state = AMPDU_STREAM_ACTIVE;
+                else {
+                        spin_unlock(&priv->stream_lock);
+                        mwl8k_destroy_ba(hw, stream);
+                        spin_lock(&priv->stream_lock);
+                        wiphy_debug(hw->wiphy,
+                                "Failed adding stream for sta %pM tid %d\n",
+                                addr, tid);
+                        mwl8k_remove_stream(hw, stream);
+                }
+                break;
        default:
-                return -ENOTSUPP;
+                rc = -ENOTSUPP;
        }
+        spin_unlock(&priv->stream_lock);
+        return rc;
 }
 static const struct ieee80211_ops mwl8k_ops = {
@@ -4441,7 +5126,7 @@ enum {
        MWL8366,
 };
-#define MWL8K_8366_AP_FW_API 1
+#define MWL8K_8366_AP_FW_API 2
 #define _MWL8K_8366_AP_FW(api) "mwl8k/fmimage_8366_ap-" #api ".fw"
 #define MWL8K_8366_AP_FW(api) _MWL8K_8366_AP_FW(api)
@@ -4607,6 +5292,23 @@ static int mwl8k_init_firmware(struct ieee80211_hw *hw, char *fw_image,
        return rc;
 }
+static int mwl8k_init_txqs(struct ieee80211_hw *hw)
+{
+        struct mwl8k_priv *priv = hw->priv;
+        int rc = 0;
+        int i;
+        for (i = 0; i < mwl8k_tx_queues(priv); i++) {
+                rc = mwl8k_txq_init(hw, i);
+                if (rc)
+                        break;
+                if (priv->ap_fw)
+                        iowrite32(priv->txq[i].txd_dma,
+                                  priv->sram + priv->txq_offset[i]);
+        }
+        return rc;
+}
 /* initialize hw after successfully loading a firmware image */
 static int mwl8k_probe_hw(struct ieee80211_hw *hw)
 {
@@ -4634,17 +5336,26 @@ static int mwl8k_probe_hw(struct ieee80211_hw *hw)
                goto err_stop_firmware;
        rxq_refill(hw, 0, INT_MAX);
-        for (i = 0; i < MWL8K_TX_QUEUES; i++) {
+        /* For the sta firmware, we need to know the dma addresses of tx queues
-                rc = mwl8k_txq_init(hw, i);
+         * before sending MWL8K_CMD_GET_HW_SPEC.  So we must initialize them
+         * prior to issuing this command.  But for the AP case, we learn the
+         * total number of queues from the result CMD_GET_HW_SPEC, so for this
+         * case we must initialize the tx queues after.
+         */
+        priv->num_ampdu_queues = 0;
+        if (!priv->ap_fw) {
+                rc = mwl8k_init_txqs(hw);
                if (rc)
                        goto err_free_queues;
        }
        iowrite32(0, priv->regs + MWL8K_HIU_A2H_INTERRUPT_STATUS);
        iowrite32(0, priv->regs + MWL8K_HIU_A2H_INTERRUPT_MASK);
-        iowrite32(MWL8K_A2H_INT_TX_DONE | MWL8K_A2H_INT_RX_READY,
+        iowrite32(MWL8K_A2H_INT_TX_DONE|MWL8K_A2H_INT_RX_READY|
+                  MWL8K_A2H_INT_BA_WATCHDOG,
                  priv->regs + MWL8K_HIU_A2H_INTERRUPT_CLEAR_SEL);
-        iowrite32(0xffffffff, priv->regs + MWL8K_HIU_A2H_INTERRUPT_STATUS_MASK);
+        iowrite32(MWL8K_A2H_INT_OPC_DONE,
+                  priv->regs + MWL8K_HIU_A2H_INTERRUPT_STATUS_MASK);
        rc = request_irq(priv->pdev->irq, mwl8k_interrupt,
                         IRQF_SHARED, MWL8K_NAME, hw);
@@ -4653,6 +5364,8 @@ static int mwl8k_probe_hw(struct ieee80211_hw *hw)
                goto err_free_queues;
        }
+        memset(priv->ampdu, 0, sizeof(priv->ampdu));
        /*
         * Temporarily enable interrupts.  Initial firmware host
         * commands use interrupts and avoid polling.  Disable
@@ -4664,6 +5377,8 @@ static int mwl8k_probe_hw(struct ieee80211_hw *hw)
        if (priv->ap_fw) {
                rc = mwl8k_cmd_get_hw_spec_ap(hw);
                if (!rc)
+                        rc = mwl8k_init_txqs(hw);
+                if (!rc)
                        rc = mwl8k_cmd_set_hw_spec(hw);
        } else {
                rc = mwl8k_cmd_get_hw_spec_sta(hw);
@@ -4705,7 +5420,7 @@ err_free_irq:
        free_irq(priv->pdev->irq, hw);
 err_free_queues:
-        for (i = 0; i < MWL8K_TX_QUEUES; i++)
+        for (i = 0; i < mwl8k_tx_queues(priv); i++)
                mwl8k_txq_deinit(hw, i);
        mwl8k_rxq_deinit(hw, 0);
@@ -4727,7 +5442,7 @@ static int mwl8k_reload_firmware(struct ieee80211_hw *hw, char *fw_image)
        mwl8k_stop(hw);
        mwl8k_rxq_deinit(hw, 0);
-        for (i = 0; i < MWL8K_TX_QUEUES; i++)
+        for (i = 0; i < mwl8k_tx_queues(priv); i++)
                mwl8k_txq_deinit(hw, i);
        rc = mwl8k_init_firmware(hw, fw_image, false);
@@ -4746,7 +5461,7 @@ static int mwl8k_reload_firmware(struct ieee80211_hw *hw, char *fw_image)
        if (rc)
                goto fail;
-        for (i = 0; i < MWL8K_TX_QUEUES; i++) {
+        for (i = 0; i < MWL8K_TX_WMM_QUEUES; i++) {
                rc = mwl8k_conf_tx(hw, i, &priv->wmm_params[i]);
                if (rc)
                        goto fail;
@@ -4778,9 +5493,11 @@ static int mwl8k_firmware_load_success(struct mwl8k_priv *priv)
        hw->extra_tx_headroom =
                sizeof(struct mwl8k_dma_data) - sizeof(struct ieee80211_cts);
+        hw->extra_tx_headroom -= priv->ap_fw ? REDUCED_TX_HEADROOM : 0;
        hw->channel_change_time = 10;
-        hw->queues = MWL8K_TX_QUEUES;
+        hw->queues = MWL8K_TX_WMM_QUEUES;
        /* Set rssi values to dBm */
        hw->flags |= IEEE80211_HW_SIGNAL_DBM | IEEE80211_HW_HAS_RATE_CONTROL;
@@ -4796,6 +5513,8 @@ static int mwl8k_firmware_load_success(struct mwl8k_priv *priv)
        /* Finalize join worker */
        INIT_WORK(&priv->finalize_join_worker, mwl8k_finalize_join_worker);
+        /* Handle watchdog ba events */
+        INIT_WORK(&priv->watchdog_ba_handle, mwl8k_watchdog_ba_events);
        /* TX reclaim and RX tasklets.  */
        tasklet_init(&priv->poll_tx_task, mwl8k_tx_poll, (unsigned long)hw);
@@ -4815,6 +5534,8 @@ static int mwl8k_firmware_load_success(struct mwl8k_priv *priv)
        spin_lock_init(&priv->tx_lock);
+        spin_lock_init(&priv->stream_lock);
        priv->tx_wait = NULL;
        rc = mwl8k_probe_hw(hw);
@@ -4836,7 +5557,7 @@ static int mwl8k_firmware_load_success(struct mwl8k_priv *priv)
        return 0;
 err_unprobe_hw:
-        for (i = 0; i < MWL8K_TX_QUEUES; i++)
+        for (i = 0; i < mwl8k_tx_queues(priv); i++)
                mwl8k_txq_deinit(hw, i);
        mwl8k_rxq_deinit(hw, 0);
@@ -4995,10 +5716,10 @@ static void __devexit mwl8k_remove(struct pci_dev *pdev)
        mwl8k_hw_reset(priv);
        /* Return all skbs to mac80211 */
-        for (i = 0; i < MWL8K_TX_QUEUES; i++)
+        for (i = 0; i < mwl8k_tx_queues(priv); i++)
                mwl8k_txq_reclaim(hw, i, INT_MAX, 1);
-        for (i = 0; i < MWL8K_TX_QUEUES; i++)
+        for (i = 0; i < mwl8k_tx_queues(priv); i++)
                mwl8k_txq_deinit(hw, i);
        mwl8k_rxq_deinit(hw, 0);
diff --git a/drivers/net/wireless/p54/eeprom.c b/drivers/net/wireless/p54/eeprom.c
index 13d750da9301..54cc0bba66b9 100644
--- a/drivers/net/wireless/p54/eeprom.c
+++ b/drivers/net/wireless/p54/eeprom.c
@@ -491,7 +491,7 @@ static int p54_parse_rssical(struct ieee80211_hw *dev,
                struct pda_rssi_cal_entry *cal = (void *) &data[offset];
                for (i = 0; i < entries; i++) {
-                        u16 freq;
+                        u16 freq = 0;
                        switch (i) {
                        case IEEE80211_BAND_2GHZ:
                                freq = 2437;
diff --git a/drivers/net/wireless/p54/fwio.c b/drivers/net/wireless/p54/fwio.c
index 2fab7d20ffc2..b6a061cbbdec 100644
--- a/drivers/net/wireless/p54/fwio.c
+++ b/drivers/net/wireless/p54/fwio.c
@@ -727,3 +727,34 @@ int p54_fetch_statistics(struct p54_common *priv)
        p54_tx(priv, skb);
        return 0;
 }
+int p54_set_groupfilter(struct p54_common *priv)
+{
+        struct p54_group_address_table *grp;
+        struct sk_buff *skb;
+        bool on = false;
+        skb = p54_alloc_skb(priv, P54_HDR_FLAG_CONTROL_OPSET, sizeof(*grp),
+                            P54_CONTROL_TYPE_GROUP_ADDRESS_TABLE, GFP_KERNEL);
+        if (!skb)
+                return -ENOMEM;
+        grp = (struct p54_group_address_table *)skb_put(skb, sizeof(*grp));
+        on = !(priv->filter_flags & FIF_ALLMULTI) &&
+             (priv->mc_maclist_num > 0 &&
+              priv->mc_maclist_num <= MC_FILTER_ADDRESS_NUM);
+        if (on) {
+                grp->filter_enable = cpu_to_le16(1);
+                grp->num_address = cpu_to_le16(priv->mc_maclist_num);
+                memcpy(grp->mac_list, priv->mc_maclist, sizeof(grp->mac_list));
+        } else {
+                grp->filter_enable = cpu_to_le16(0);
+                grp->num_address = cpu_to_le16(0);
+                memset(grp->mac_list, 0, sizeof(grp->mac_list));
+        }
+        p54_tx(priv, skb);
+        return 0;
+}
diff --git a/drivers/net/wireless/p54/lmac.h b/drivers/net/wireless/p54/lmac.h
index eb581abc1079..3d8d622bec55 100644
--- a/drivers/net/wireless/p54/lmac.h
+++ b/drivers/net/wireless/p54/lmac.h
@@ -540,6 +540,7 @@ int p54_update_beacon_tim(struct p54_common *priv, u16 aid, bool set);
 int p54_setup_mac(struct p54_common *priv);
 int p54_set_ps(struct p54_common *priv);
 int p54_fetch_statistics(struct p54_common *priv);
+int p54_set_groupfilter(struct p54_common *priv);
 /* e/v DCF setup */
 int p54_set_edcf(struct p54_common *priv);
diff --git a/drivers/net/wireless/p54/main.c b/drivers/net/wireless/p54/main.c
index a946991989c6..a5a6d9e647bb 100644
--- a/drivers/net/wireless/p54/main.c
+++ b/drivers/net/wireless/p54/main.c
@@ -308,6 +308,31 @@ out:
        return ret;
 }
+static u64 p54_prepare_multicast(struct ieee80211_hw *dev,
+                                 struct netdev_hw_addr_list *mc_list)
+{
+        struct p54_common *priv = dev->priv;
+        struct netdev_hw_addr *ha;
+        int i;
+        BUILD_BUG_ON(ARRAY_SIZE(priv->mc_maclist) !=
+                ARRAY_SIZE(((struct p54_group_address_table *)NULL)->mac_list));
+        /*
+         * The first entry is reserved for the global broadcast MAC.
+         * Otherwise the firmware will drop it and ARP will no longer work.
+         */
+        i = 1;
+        priv->mc_maclist_num = netdev_hw_addr_list_count(mc_list) + i;
+        netdev_hw_addr_list_for_each(ha, mc_list) {
+                memcpy(&priv->mc_maclist[i], ha->addr, ETH_ALEN);
+                i++;
+                if (i >= ARRAY_SIZE(priv->mc_maclist))
+                        break;
+        }
+        return 1; /* update */
+}
 static void p54_configure_filter(struct ieee80211_hw *dev,
                                 unsigned int changed_flags,
                                 unsigned int *total_flags,
@@ -316,12 +341,16 @@ static void p54_configure_filter(struct ieee80211_hw *dev,
        struct p54_common *priv = dev->priv;
        *total_flags &= FIF_PROMISC_IN_BSS |
+                        FIF_ALLMULTI |
                        FIF_OTHER_BSS;
        priv->filter_flags = *total_flags;
        if (changed_flags & (FIF_PROMISC_IN_BSS | FIF_OTHER_BSS))
                p54_setup_mac(priv);
+        if (changed_flags & FIF_ALLMULTI || multicast)
+                p54_set_groupfilter(priv);
 }
 static int p54_conf_tx(struct ieee80211_hw *dev, u16 queue,
@@ -591,6 +620,7 @@ static const struct ieee80211_ops p54_ops = {
        .config                 = p54_config,
        .flush                  = p54_flush,
        .bss_info_changed       = p54_bss_info_changed,
+        .prepare_multicast      = p54_prepare_multicast,
        .configure_filter       = p54_configure_filter,
        .conf_tx                = p54_conf_tx,
        .get_stats              = p54_get_stats,
@@ -660,6 +690,7 @@ struct ieee80211_hw *p54_init_common(size_t priv_data_len)
        init_completion(&priv->beacon_comp);
        INIT_DELAYED_WORK(&priv->work, p54_work);
+        memset(&priv->mc_maclist[0], ~0, ETH_ALEN);
        return dev;
 }
 EXPORT_SYMBOL_GPL(p54_init_common);
diff --git a/drivers/net/wireless/p54/p54.h b/drivers/net/wireless/p54/p54.h
index 50730fc23fe5..799d05e12595 100644
--- a/drivers/net/wireless/p54/p54.h
+++ b/drivers/net/wireless/p54/p54.h
@@ -211,8 +211,10 @@ struct p54_common {
        /* BBP/MAC state */
        u8 mac_addr[ETH_ALEN];
        u8 bssid[ETH_ALEN];
+        u8 mc_maclist[4][ETH_ALEN];
        u16 wakeup_timer;
        unsigned int filter_flags;
+        int mc_maclist_num;
        int mode;
        u32 tsf_low32, tsf_high32;
        u32 basic_rate_mask;
diff --git a/drivers/net/wireless/p54/p54pci.c b/drivers/net/wireless/p54/p54pci.c
index 0494d7b102d4..1b753173680f 100644
--- a/drivers/net/wireless/p54/p54pci.c
+++ b/drivers/net/wireless/p54/p54pci.c
@@ -331,10 +331,9 @@ static void p54p_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
        struct p54p_ring_control *ring_control = priv->ring_control;
        struct p54p_desc *desc;
        dma_addr_t mapping;
-        u32 device_idx, idx, i;
+        u32 idx, i;
        spin_lock_irqsave(&priv->lock, flags);
-        device_idx = le32_to_cpu(ring_control->device_idx[1]);
        idx = le32_to_cpu(ring_control->host_idx[1]);
        i = idx % ARRAY_SIZE(ring_control->tx_data);
diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
index f630552427b7..9def1e5369a1 100644
--- a/drivers/net/wireless/rt2x00/Kconfig
+++ b/drivers/net/wireless/rt2x00/Kconfig
@@ -59,7 +59,6 @@ config RT2800PCI
        select RT2800_LIB
        select RT2X00_LIB_PCI if PCI
        select RT2X00_LIB_SOC if RALINK_RT288X || RALINK_RT305X
-        select RT2X00_LIB_HT
        select RT2X00_LIB_FIRMWARE
        select RT2X00_LIB_CRYPTO
        select CRC_CCITT
@@ -74,17 +73,13 @@ config RT2800PCI
 if RT2800PCI
 config RT2800PCI_RT33XX
-        bool "rt2800pci - Include support for rt33xx devices (EXPERIMENTAL)"
+        bool "rt2800pci - Include support for rt33xx devices"
-        depends on EXPERIMENTAL
+        default y
-        default n
        ---help---
          This adds support for rt33xx wireless chipset family to the
          rt2800pci driver.
          Supported chips: RT3390
-          Support for these devices is non-functional at the moment and is
-          intended for testers and developers.
 config RT2800PCI_RT35XX
        bool "rt2800pci - Include support for rt35xx devices (EXPERIMENTAL)"
        depends on EXPERIMENTAL
@@ -98,17 +93,14 @@ config RT2800PCI_RT35XX
          intended for testers and developers.
 config RT2800PCI_RT53XX
-       bool "rt2800-pci - Include support for rt53xx devices (EXPERIMENTAL)"
+       bool "rt2800pci - Include support for rt53xx devices (EXPERIMENTAL)"
       depends on EXPERIMENTAL
-       default n
+       default y
       ---help---
         This adds support for rt53xx wireless chipset family to the
         rt2800pci driver.
         Supported chips: RT5390
-         Support for these devices is non-functional at the moment and is
-         intended for testers and developers.
 endif
 config RT2500USB
@@ -140,7 +132,6 @@ config RT2800USB
        depends on USB
        select RT2800_LIB
        select RT2X00_LIB_USB
-        select RT2X00_LIB_HT
        select RT2X00_LIB_FIRMWARE
        select RT2X00_LIB_CRYPTO
        select CRC_CCITT
@@ -153,17 +144,13 @@ config RT2800USB
 if RT2800USB
 config RT2800USB_RT33XX
-        bool "rt2800usb - Include support for rt33xx devices (EXPERIMENTAL)"
+        bool "rt2800usb - Include support for rt33xx devices"
-        depends on EXPERIMENTAL
+        default y
-        default n
        ---help---
          This adds support for rt33xx wireless chipset family to the
          rt2800usb driver.
          Supported chips: RT3370
-          Support for these devices is non-functional at the moment and is
-          intended for testers and developers.
 config RT2800USB_RT35XX
        bool "rt2800usb - Include support for rt35xx devices (EXPERIMENTAL)"
        depends on EXPERIMENTAL
@@ -176,6 +163,15 @@ config RT2800USB_RT35XX
          Support for these devices is non-functional at the moment and is
          intended for testers and developers.
+config RT2800USB_RT53XX
+       bool "rt2800usb - Include support for rt53xx devices (EXPERIMENTAL)"
+       depends on EXPERIMENTAL
+       default y
+       ---help---
+         This adds support for rt53xx wireless chipset family to the
+         rt2800pci driver.
+         Supported chips: RT5370
 config RT2800USB_UNKNOWN
        bool "rt2800usb - Include support for unknown (USB) devices"
        default n
@@ -207,9 +203,6 @@ config RT2X00_LIB_USB
 config RT2X00_LIB
        tristate
-config RT2X00_LIB_HT
-        boolean
 config RT2X00_LIB_FIRMWARE
        boolean
        select FW_LOADER
diff --git a/drivers/net/wireless/rt2x00/Makefile b/drivers/net/wireless/rt2x00/Makefile
index 971339858297..349d5b8284a4 100644
--- a/drivers/net/wireless/rt2x00/Makefile
+++ b/drivers/net/wireless/rt2x00/Makefile
@@ -7,7 +7,6 @@ rt2x00lib-$(CONFIG_RT2X00_LIB_DEBUGFS)	+= rt2x00debug.o
 rt2x00lib-$(CONFIG_RT2X00_LIB_CRYPTO)   += rt2x00crypto.o
 rt2x00lib-$(CONFIG_RT2X00_LIB_FIRMWARE) += rt2x00firmware.o
 rt2x00lib-$(CONFIG_RT2X00_LIB_LEDS)     += rt2x00leds.o
-rt2x00lib-$(CONFIG_RT2X00_LIB_HT)       += rt2x00ht.o
 obj-$(CONFIG_RT2X00_LIB)                += rt2x00lib.o
 obj-$(CONFIG_RT2X00_LIB_PCI)            += rt2x00pci.o
diff --git a/drivers/net/wireless/rt2x00/rt2400pci.c b/drivers/net/wireless/rt2x00/rt2400pci.c
index 329f3283697b..937f9e8bf05f 100644
--- a/drivers/net/wireless/rt2x00/rt2400pci.c
+++ b/drivers/net/wireless/rt2x00/rt2400pci.c
@@ -1314,8 +1314,8 @@ static void rt2400pci_txdone(struct rt2x00_dev *rt2x00dev,
        }
 }
-static void rt2400pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,
+static inline void rt2400pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,
-                                       struct rt2x00_field32 irq_field)
+                                              struct rt2x00_field32 irq_field)
 {
        u32 reg;
@@ -1368,8 +1368,10 @@ static void rt2400pci_tbtt_tasklet(unsigned long data)
 static void rt2400pci_rxdone_tasklet(unsigned long data)
 {
        struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data;
-        rt2x00pci_rxdone(rt2x00dev);
+        if (rt2x00pci_rxdone(rt2x00dev))
-        rt2400pci_enable_interrupt(rt2x00dev, CSR8_RXDONE);
+                tasklet_schedule(&rt2x00dev->rxdone_tasklet);
+        else
+                rt2400pci_enable_interrupt(rt2x00dev, CSR8_RXDONE);
 }
 static irqreturn_t rt2400pci_interrupt(int irq, void *dev_instance)
@@ -1534,13 +1536,13 @@ static int rt2400pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
         * Detect if this device has an hardware controlled radio.
         */
        if (rt2x00_get_field16(eeprom, EEPROM_ANTENNA_HARDWARE_RADIO))
-                __set_bit(CONFIG_SUPPORT_HW_BUTTON, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_BUTTON, &rt2x00dev->cap_flags);
        /*
         * Check if the BBP tuning should be enabled.
         */
        if (rt2x00_get_field16(eeprom, EEPROM_ANTENNA_RX_AGCVGC_TUNING))
-                __set_bit(DRIVER_SUPPORT_LINK_TUNING, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_LINK_TUNING, &rt2x00dev->cap_flags);
        return 0;
 }
@@ -1638,9 +1640,9 @@ static int rt2400pci_probe_hw(struct rt2x00_dev *rt2x00dev)
        /*
         * This device requires the atim queue and DMA-mapped skbs.
         */
-        __set_bit(DRIVER_REQUIRE_ATIM_QUEUE, &rt2x00dev->flags);
+        __set_bit(REQUIRE_ATIM_QUEUE, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_DMA, &rt2x00dev->flags);
+        __set_bit(REQUIRE_DMA, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_SW_SEQNO, &rt2x00dev->flags);
+        __set_bit(REQUIRE_SW_SEQNO, &rt2x00dev->cap_flags);
        /*
         * Set the rssi offset.
@@ -1718,6 +1720,9 @@ static const struct ieee80211_ops rt2400pci_mac80211_ops = {
        .tx_last_beacon         = rt2400pci_tx_last_beacon,
        .rfkill_poll            = rt2x00mac_rfkill_poll,
        .flush                  = rt2x00mac_flush,
+        .set_antenna            = rt2x00mac_set_antenna,
+        .get_antenna            = rt2x00mac_get_antenna,
+        .get_ringparam          = rt2x00mac_get_ringparam,
 };
 static const struct rt2x00lib_ops rt2400pci_rt2x00_ops = {
@@ -1738,6 +1743,7 @@ static const struct rt2x00lib_ops rt2400pci_rt2x00_ops = {
        .start_queue            = rt2400pci_start_queue,
        .kick_queue             = rt2400pci_kick_queue,
        .stop_queue             = rt2400pci_stop_queue,
+        .flush_queue            = rt2x00pci_flush_queue,
        .write_tx_desc          = rt2400pci_write_tx_desc,
        .write_beacon           = rt2400pci_write_beacon,
        .fill_rxdone            = rt2400pci_fill_rxdone,
@@ -1799,10 +1805,11 @@ static const struct rt2x00_ops rt2400pci_ops = {
 * RT2400pci module information.
 */
 static DEFINE_PCI_DEVICE_TABLE(rt2400pci_device_table) = {
-        { PCI_DEVICE(0x1814, 0x0101), PCI_DEVICE_DATA(&rt2400pci_ops) },
+        { PCI_DEVICE(0x1814, 0x0101) },
        { 0, }
 };
 MODULE_AUTHOR(DRV_PROJECT);
 MODULE_VERSION(DRV_VERSION);
 MODULE_DESCRIPTION("Ralink RT2400 PCI & PCMCIA Wireless LAN driver.");
@@ -1810,10 +1817,16 @@ MODULE_SUPPORTED_DEVICE("Ralink RT2460 PCI & PCMCIA chipset based cards");
 MODULE_DEVICE_TABLE(pci, rt2400pci_device_table);
 MODULE_LICENSE("GPL");
+static int rt2400pci_probe(struct pci_dev *pci_dev,
+                           const struct pci_device_id *id)
+{
+        return rt2x00pci_probe(pci_dev, &rt2400pci_ops);
+}
 static struct pci_driver rt2400pci_driver = {
        .name           = KBUILD_MODNAME,
        .id_table       = rt2400pci_device_table,
-        .probe          = rt2x00pci_probe,
+        .probe          = rt2400pci_probe,
        .remove         = __devexit_p(rt2x00pci_remove),
        .suspend        = rt2x00pci_suspend,
        .resume         = rt2x00pci_resume,
diff --git a/drivers/net/wireless/rt2x00/rt2500pci.c b/drivers/net/wireless/rt2x00/rt2500pci.c
index 58277878889e..d27d7b8ba3b6 100644
--- a/drivers/net/wireless/rt2x00/rt2500pci.c
+++ b/drivers/net/wireless/rt2x00/rt2500pci.c
@@ -1446,8 +1446,8 @@ static void rt2500pci_txdone(struct rt2x00_dev *rt2x00dev,
        }
 }
-static void rt2500pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,
+static inline void rt2500pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,
-                                       struct rt2x00_field32 irq_field)
+                                              struct rt2x00_field32 irq_field)
 {
        u32 reg;
@@ -1500,8 +1500,10 @@ static void rt2500pci_tbtt_tasklet(unsigned long data)
 static void rt2500pci_rxdone_tasklet(unsigned long data)
 {
        struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data;
-        rt2x00pci_rxdone(rt2x00dev);
+        if (rt2x00pci_rxdone(rt2x00dev))
-        rt2500pci_enable_interrupt(rt2x00dev, CSR8_RXDONE);
+                tasklet_schedule(&rt2x00dev->rxdone_tasklet);
+        else
+                rt2500pci_enable_interrupt(rt2x00dev, CSR8_RXDONE);
 }
 static irqreturn_t rt2500pci_interrupt(int irq, void *dev_instance)
@@ -1685,14 +1687,14 @@ static int rt2500pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
         * Detect if this device has an hardware controlled radio.
         */
        if (rt2x00_get_field16(eeprom, EEPROM_ANTENNA_HARDWARE_RADIO))
-                __set_bit(CONFIG_SUPPORT_HW_BUTTON, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_BUTTON, &rt2x00dev->cap_flags);
        /*
         * Check if the BBP tuning should be enabled.
         */
        rt2x00_eeprom_read(rt2x00dev, EEPROM_NIC, &eeprom);
        if (!rt2x00_get_field16(eeprom, EEPROM_NIC_DYN_BBP_TUNE))
-                __set_bit(DRIVER_SUPPORT_LINK_TUNING, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_LINK_TUNING, &rt2x00dev->cap_flags);
        /*
         * Read the RSSI <-> dBm offset information.
@@ -1956,9 +1958,9 @@ static int rt2500pci_probe_hw(struct rt2x00_dev *rt2x00dev)
        /*
         * This device requires the atim queue and DMA-mapped skbs.
         */
-        __set_bit(DRIVER_REQUIRE_ATIM_QUEUE, &rt2x00dev->flags);
+        __set_bit(REQUIRE_ATIM_QUEUE, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_DMA, &rt2x00dev->flags);
+        __set_bit(REQUIRE_DMA, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_SW_SEQNO, &rt2x00dev->flags);
+        __set_bit(REQUIRE_SW_SEQNO, &rt2x00dev->cap_flags);
        /*
         * Set the rssi offset.
@@ -2011,6 +2013,9 @@ static const struct ieee80211_ops rt2500pci_mac80211_ops = {
        .tx_last_beacon         = rt2500pci_tx_last_beacon,
        .rfkill_poll            = rt2x00mac_rfkill_poll,
        .flush                  = rt2x00mac_flush,
+        .set_antenna            = rt2x00mac_set_antenna,
+        .get_antenna            = rt2x00mac_get_antenna,
+        .get_ringparam          = rt2x00mac_get_ringparam,
 };
 static const struct rt2x00lib_ops rt2500pci_rt2x00_ops = {
@@ -2031,6 +2036,7 @@ static const struct rt2x00lib_ops rt2500pci_rt2x00_ops = {
        .start_queue            = rt2500pci_start_queue,
        .kick_queue             = rt2500pci_kick_queue,
        .stop_queue             = rt2500pci_stop_queue,
+        .flush_queue            = rt2x00pci_flush_queue,
        .write_tx_desc          = rt2500pci_write_tx_desc,
        .write_beacon           = rt2500pci_write_beacon,
        .fill_rxdone            = rt2500pci_fill_rxdone,
@@ -2092,7 +2098,7 @@ static const struct rt2x00_ops rt2500pci_ops = {
 * RT2500pci module information.
 */
 static DEFINE_PCI_DEVICE_TABLE(rt2500pci_device_table) = {
-        { PCI_DEVICE(0x1814, 0x0201), PCI_DEVICE_DATA(&rt2500pci_ops) },
+        { PCI_DEVICE(0x1814, 0x0201) },
        { 0, }
 };
@@ -2103,10 +2109,16 @@ MODULE_SUPPORTED_DEVICE("Ralink RT2560 PCI & PCMCIA chipset based cards");
 MODULE_DEVICE_TABLE(pci, rt2500pci_device_table);
 MODULE_LICENSE("GPL");
+static int rt2500pci_probe(struct pci_dev *pci_dev,
+                           const struct pci_device_id *id)
+{
+        return rt2x00pci_probe(pci_dev, &rt2500pci_ops);
+}
 static struct pci_driver rt2500pci_driver = {
        .name           = KBUILD_MODNAME,
        .id_table       = rt2500pci_device_table,
-        .probe          = rt2x00pci_probe,
+        .probe          = rt2500pci_probe,
        .remove         = __devexit_p(rt2x00pci_remove),
        .suspend        = rt2x00pci_suspend,
        .resume         = rt2x00pci_resume,
diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
index 979fe6596a2d..15237c275486 100644
--- a/drivers/net/wireless/rt2x00/rt2500usb.c
+++ b/drivers/net/wireless/rt2x00/rt2500usb.c
@@ -1519,7 +1519,7 @@ static int rt2500usb_init_eeprom(struct rt2x00_dev *rt2x00dev)
         * Detect if this device has an hardware controlled radio.
         */
        if (rt2x00_get_field16(eeprom, EEPROM_ANTENNA_HARDWARE_RADIO))
-                __set_bit(CONFIG_SUPPORT_HW_BUTTON, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_BUTTON, &rt2x00dev->cap_flags);
        /*
         * Read the RSSI <-> dBm offset information.
@@ -1790,14 +1790,14 @@ static int rt2500usb_probe_hw(struct rt2x00_dev *rt2x00dev)
        /*
         * This device requires the atim queue
         */
-        __set_bit(DRIVER_REQUIRE_ATIM_QUEUE, &rt2x00dev->flags);
+        __set_bit(REQUIRE_ATIM_QUEUE, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_BEACON_GUARD, &rt2x00dev->flags);
+        __set_bit(REQUIRE_BEACON_GUARD, &rt2x00dev->cap_flags);
        if (!modparam_nohwcrypt) {
-                __set_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags);
-                __set_bit(DRIVER_REQUIRE_COPY_IV, &rt2x00dev->flags);
+                __set_bit(REQUIRE_COPY_IV, &rt2x00dev->cap_flags);
        }
-        __set_bit(DRIVER_SUPPORT_WATCHDOG, &rt2x00dev->flags);
+        __set_bit(REQUIRE_SW_SEQNO, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_SW_SEQNO, &rt2x00dev->flags);
+        __set_bit(REQUIRE_PS_AUTOWAKE, &rt2x00dev->cap_flags);
        /*
         * Set the rssi offset.
@@ -1824,6 +1824,9 @@ static const struct ieee80211_ops rt2500usb_mac80211_ops = {
        .conf_tx                = rt2x00mac_conf_tx,
        .rfkill_poll            = rt2x00mac_rfkill_poll,
        .flush                  = rt2x00mac_flush,
+        .set_antenna            = rt2x00mac_set_antenna,
+        .get_antenna            = rt2x00mac_get_antenna,
+        .get_ringparam          = rt2x00mac_get_ringparam,
 };
 static const struct rt2x00lib_ops rt2500usb_rt2x00_ops = {
@@ -1905,58 +1908,54 @@ static const struct rt2x00_ops rt2500usb_ops = {
 */
 static struct usb_device_id rt2500usb_device_table[] = {
        /* ASUS */
-        { USB_DEVICE(0x0b05, 0x1706), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0b05, 0x1706) },
-        { USB_DEVICE(0x0b05, 0x1707), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0b05, 0x1707) },
        /* Belkin */
-        { USB_DEVICE(0x050d, 0x7050), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x050d, 0x7050) },
-        { USB_DEVICE(0x050d, 0x7051), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x050d, 0x7051) },
-        { USB_DEVICE(0x050d, 0x705a), USB_DEVICE_DATA(&rt2500usb_ops) },
        /* Cisco Systems */
-        { USB_DEVICE(0x13b1, 0x000d), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x13b1, 0x000d) },
-        { USB_DEVICE(0x13b1, 0x0011), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x13b1, 0x0011) },
-        { USB_DEVICE(0x13b1, 0x001a), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x13b1, 0x001a) },
-        /* CNet */
-        { USB_DEVICE(0x1371, 0x9022), USB_DEVICE_DATA(&rt2500usb_ops) },
        /* Conceptronic */
-        { USB_DEVICE(0x14b2, 0x3c02), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x14b2, 0x3c02) },
        /* D-LINK */
-        { USB_DEVICE(0x2001, 0x3c00), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x2001, 0x3c00) },
        /* Gigabyte */
-        { USB_DEVICE(0x1044, 0x8001), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x1044, 0x8001) },
-        { USB_DEVICE(0x1044, 0x8007), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x1044, 0x8007) },
        /* Hercules */
-        { USB_DEVICE(0x06f8, 0xe000), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x06f8, 0xe000) },
        /* Melco */
-        { USB_DEVICE(0x0411, 0x005e), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0411, 0x005e) },
-        { USB_DEVICE(0x0411, 0x0066), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0411, 0x0066) },
-        { USB_DEVICE(0x0411, 0x0067), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0411, 0x0067) },
-        { USB_DEVICE(0x0411, 0x008b), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0411, 0x008b) },
-        { USB_DEVICE(0x0411, 0x0097), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0411, 0x0097) },
        /* MSI */
-        { USB_DEVICE(0x0db0, 0x6861), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0db0, 0x6861) },
-        { USB_DEVICE(0x0db0, 0x6865), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0db0, 0x6865) },
-        { USB_DEVICE(0x0db0, 0x6869), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0db0, 0x6869) },
        /* Ralink */
-        { USB_DEVICE(0x148f, 0x1706), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x148f, 0x1706) },
-        { USB_DEVICE(0x148f, 0x2570), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x148f, 0x2570) },
-        { USB_DEVICE(0x148f, 0x2573), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x148f, 0x9020) },
-        { USB_DEVICE(0x148f, 0x9020), USB_DEVICE_DATA(&rt2500usb_ops) },
        /* Sagem */
-        { USB_DEVICE(0x079b, 0x004b), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x079b, 0x004b) },
        /* Siemens */
-        { USB_DEVICE(0x0681, 0x3c06), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0681, 0x3c06) },
        /* SMC */
-        { USB_DEVICE(0x0707, 0xee13), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0707, 0xee13) },
        /* Spairon */
-        { USB_DEVICE(0x114b, 0x0110), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x114b, 0x0110) },
        /* SURECOM */
-        { USB_DEVICE(0x0769, 0x11f3), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0769, 0x11f3) },
        /* Trust */
-        { USB_DEVICE(0x0eb0, 0x9020), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0eb0, 0x9020) },
        /* VTech */
-        { USB_DEVICE(0x0f88, 0x3012), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x0f88, 0x3012) },
        /* Zinwell */
-        { USB_DEVICE(0x5a57, 0x0260), USB_DEVICE_DATA(&rt2500usb_ops) },
+        { USB_DEVICE(0x5a57, 0x0260) },
        { 0, }
 };
@@ -1967,10 +1966,16 @@ MODULE_SUPPORTED_DEVICE("Ralink RT2570 USB chipset based cards");
 MODULE_DEVICE_TABLE(usb, rt2500usb_device_table);
 MODULE_LICENSE("GPL");
+static int rt2500usb_probe(struct usb_interface *usb_intf,
+                           const struct usb_device_id *id)
+{
+        return rt2x00usb_probe(usb_intf, &rt2500usb_ops);
+}
 static struct usb_driver rt2500usb_driver = {
        .name           = KBUILD_MODNAME,
        .id_table       = rt2500usb_device_table,
-        .probe          = rt2x00usb_probe,
+        .probe          = rt2500usb_probe,
        .disconnect     = rt2x00usb_disconnect,
        .suspend        = rt2x00usb_suspend,
        .resume         = rt2x00usb_resume,
diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
index 8fbc5fa965e0..f67bc9b31b28 100644
--- a/drivers/net/wireless/rt2x00/rt2800.h
+++ b/drivers/net/wireless/rt2x00/rt2800.h
@@ -51,6 +51,7 @@
 * RF3320 2.4G 1T1R(RT3350/RT3370/RT3390)
 * RF3322 2.4G 2T2R(RT3352/RT3371/RT3372/RT3391/RT3392)
 * RF3853 2.4G/5G 3T3R(RT3883/RT3563/RT3573/RT3593/RT3662)
+ * RF5370 2.4G 1T1R
 * RF5390 2.4G 1T1R
 */
 #define RF2820                          0x0001
@@ -66,6 +67,7 @@
 #define RF3320                          0x000b
 #define RF3322                          0x000c
 #define RF3853                          0x000d
+#define RF5370                          0x5370
 #define RF5390                          0x5390
 /*
@@ -2104,6 +2106,59 @@ struct mac_iveiv_entry {
 #define EEPROM_TXPOWER_BG_2             FIELD16(0xff00)
 /*
+ * EEPROM temperature compensation boundaries 802.11BG
+ * MINUS4: If the actual TSSI is below this boundary, tx power needs to be
+ *         reduced by (agc_step * -4)
+ * MINUS3: If the actual TSSI is below this boundary, tx power needs to be
+ *         reduced by (agc_step * -3)
+ */
+#define EEPROM_TSSI_BOUND_BG1           0x0037
+#define EEPROM_TSSI_BOUND_BG1_MINUS4    FIELD16(0x00ff)
+#define EEPROM_TSSI_BOUND_BG1_MINUS3    FIELD16(0xff00)
+/*
+ * EEPROM temperature compensation boundaries 802.11BG
+ * MINUS2: If the actual TSSI is below this boundary, tx power needs to be
+ *         reduced by (agc_step * -2)
+ * MINUS1: If the actual TSSI is below this boundary, tx power needs to be
+ *         reduced by (agc_step * -1)
+ */
+#define EEPROM_TSSI_BOUND_BG2           0x0038
+#define EEPROM_TSSI_BOUND_BG2_MINUS2    FIELD16(0x00ff)
+#define EEPROM_TSSI_BOUND_BG2_MINUS1    FIELD16(0xff00)
+/*
+ * EEPROM temperature compensation boundaries 802.11BG
+ * REF: Reference TSSI value, no tx power changes needed
+ * PLUS1: If the actual TSSI is above this boundary, tx power needs to be
+ *        increased by (agc_step * 1)
+ */
+#define EEPROM_TSSI_BOUND_BG3           0x0039
+#define EEPROM_TSSI_BOUND_BG3_REF       FIELD16(0x00ff)
+#define EEPROM_TSSI_BOUND_BG3_PLUS1     FIELD16(0xff00)
+/*
+ * EEPROM temperature compensation boundaries 802.11BG
+ * PLUS2: If the actual TSSI is above this boundary, tx power needs to be
+ *        increased by (agc_step * 2)
+ * PLUS3: If the actual TSSI is above this boundary, tx power needs to be
+ *        increased by (agc_step * 3)
+ */
+#define EEPROM_TSSI_BOUND_BG4           0x003a
+#define EEPROM_TSSI_BOUND_BG4_PLUS2     FIELD16(0x00ff)
+#define EEPROM_TSSI_BOUND_BG4_PLUS3     FIELD16(0xff00)
+/*
+ * EEPROM temperature compensation boundaries 802.11BG
+ * PLUS4: If the actual TSSI is above this boundary, tx power needs to be
+ *        increased by (agc_step * 4)
+ * AGC_STEP: Temperature compensation step.
+ */
+#define EEPROM_TSSI_BOUND_BG5           0x003b
+#define EEPROM_TSSI_BOUND_BG5_PLUS4     FIELD16(0x00ff)
+#define EEPROM_TSSI_BOUND_BG5_AGC_STEP  FIELD16(0xff00)
+/*
 * EEPROM TXPOWER 802.11A
 */
 #define EEPROM_TXPOWER_A1               0x003c
@@ -2113,6 +2168,59 @@ struct mac_iveiv_entry {
 #define EEPROM_TXPOWER_A_2              FIELD16(0xff00)
 /*
+ * EEPROM temperature compensation boundaries 802.11A
+ * MINUS4: If the actual TSSI is below this boundary, tx power needs to be
+ *         reduced by (agc_step * -4)
+ * MINUS3: If the actual TSSI is below this boundary, tx power needs to be
+ *         reduced by (agc_step * -3)
+ */
+#define EEPROM_TSSI_BOUND_A1            0x006a
+#define EEPROM_TSSI_BOUND_A1_MINUS4     FIELD16(0x00ff)
+#define EEPROM_TSSI_BOUND_A1_MINUS3     FIELD16(0xff00)
+/*
+ * EEPROM temperature compensation boundaries 802.11A
+ * MINUS2: If the actual TSSI is below this boundary, tx power needs to be
+ *         reduced by (agc_step * -2)
+ * MINUS1: If the actual TSSI is below this boundary, tx power needs to be
+ *         reduced by (agc_step * -1)
+ */
+#define EEPROM_TSSI_BOUND_A2            0x006b
+#define EEPROM_TSSI_BOUND_A2_MINUS2     FIELD16(0x00ff)
+#define EEPROM_TSSI_BOUND_A2_MINUS1     FIELD16(0xff00)
+/*
+ * EEPROM temperature compensation boundaries 802.11A
+ * REF: Reference TSSI value, no tx power changes needed
+ * PLUS1: If the actual TSSI is above this boundary, tx power needs to be
+ *        increased by (agc_step * 1)
+ */
+#define EEPROM_TSSI_BOUND_A3            0x006c
+#define EEPROM_TSSI_BOUND_A3_REF        FIELD16(0x00ff)
+#define EEPROM_TSSI_BOUND_A3_PLUS1      FIELD16(0xff00)
+/*
+ * EEPROM temperature compensation boundaries 802.11A
+ * PLUS2: If the actual TSSI is above this boundary, tx power needs to be
+ *        increased by (agc_step * 2)
+ * PLUS3: If the actual TSSI is above this boundary, tx power needs to be
+ *        increased by (agc_step * 3)
+ */
+#define EEPROM_TSSI_BOUND_A4            0x006d
+#define EEPROM_TSSI_BOUND_A4_PLUS2      FIELD16(0x00ff)
+#define EEPROM_TSSI_BOUND_A4_PLUS3      FIELD16(0xff00)
+/*
+ * EEPROM temperature compensation boundaries 802.11A
+ * PLUS4: If the actual TSSI is above this boundary, tx power needs to be
+ *        increased by (agc_step * 4)
+ * AGC_STEP: Temperature compensation step.
+ */
+#define EEPROM_TSSI_BOUND_A5            0x006e
+#define EEPROM_TSSI_BOUND_A5_PLUS4      FIELD16(0x00ff)
+#define EEPROM_TSSI_BOUND_A5_AGC_STEP   FIELD16(0xff00)
+/*
 * EEPROM TXPOWER by rate: tx power per tx rate for HT20 mode
 */
 #define EEPROM_TXPOWER_BYRATE           0x006f
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index dbf74d07d947..2a6aa85cc6c9 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -687,6 +687,9 @@ void rt2800_txdone_entry(struct queue_entry *entry, u32 status)
                mcs = real_mcs;
        }
+        if (aggr == 1 || ampdu == 1)
+                __set_bit(TXDONE_AMPDU, &txdesc.flags);
        /*
         * Ralink has a retry mechanism using a global fallback
         * table. We setup this fallback table to try the immediate
@@ -727,34 +730,20 @@ void rt2800_txdone(struct rt2x00_dev *rt2x00dev)
        struct data_queue *queue;
        struct queue_entry *entry;
        u32 reg;
-        u8 pid;
+        u8 qid;
-        int i;
-        /*
+        while (kfifo_get(&rt2x00dev->txstatus_fifo, &reg)) {
-         * TX_STA_FIFO is a stack of X entries, hence read TX_STA_FIFO
-         * at most X times and also stop processing once the TX_STA_FIFO_VALID
-         * flag is not set anymore.
-         *
-         * The legacy drivers use X=TX_RING_SIZE but state in a comment
-         * that the TX_STA_FIFO stack has a size of 16. We stick to our
-         * tx ring size for now.
-         */
-        for (i = 0; i < rt2x00dev->ops->tx->entry_num; i++) {
-                rt2800_register_read(rt2x00dev, TX_STA_FIFO, &reg);
-                if (!rt2x00_get_field32(reg, TX_STA_FIFO_VALID))
-                        break;
-                /*
+                /* TX_STA_FIFO_PID_QUEUE is a 2-bit field, thus
-                 * Skip this entry when it contains an invalid
+                 * qid is guaranteed to be one of the TX QIDs
-                 * queue identication number.
                 */
-                pid = rt2x00_get_field32(reg, TX_STA_FIFO_PID_QUEUE);
+                qid = rt2x00_get_field32(reg, TX_STA_FIFO_PID_QUEUE);
-                if (pid >= QID_RX)
+                queue = rt2x00queue_get_tx_queue(rt2x00dev, qid);
-                        continue;
+                if (unlikely(!queue)) {
+                        WARNING(rt2x00dev, "Got TX status for an unavailable "
-                queue = rt2x00queue_get_tx_queue(rt2x00dev, pid);
+                                           "queue %u, dropping\n", qid);
-                if (unlikely(!queue))
                        continue;
+                }
                /*
                 * Inside each queue, we process each entry in a chronological
@@ -946,25 +935,49 @@ static void rt2800_brightness_set(struct led_classdev *led_cdev,
        unsigned int ledmode =
                rt2x00_get_field16(led->rt2x00dev->led_mcu_reg,
                                   EEPROM_FREQ_LED_MODE);
+        u32 reg;
-        if (led->type == LED_TYPE_RADIO) {
+        /* Check for SoC (SOC devices don't support MCU requests) */
-                rt2800_mcu_request(led->rt2x00dev, MCU_LED, 0xff, ledmode,
+        if (rt2x00_is_soc(led->rt2x00dev)) {
-                                      enabled ? 0x20 : 0);
+                rt2800_register_read(led->rt2x00dev, LED_CFG, &reg);
-        } else if (led->type == LED_TYPE_ASSOC) {
-                rt2800_mcu_request(led->rt2x00dev, MCU_LED, 0xff, ledmode,
+                /* Set LED Polarity */
-                                      enabled ? (bg_mode ? 0x60 : 0xa0) : 0x20);
+                rt2x00_set_field32(&reg, LED_CFG_LED_POLAR, polarity);
-        } else if (led->type == LED_TYPE_QUALITY) {
-                /*
+                /* Set LED Mode */
-                 * The brightness is divided into 6 levels (0 - 5),
+                if (led->type == LED_TYPE_RADIO) {
-                 * The specs tell us the following levels:
+                        rt2x00_set_field32(&reg, LED_CFG_G_LED_MODE,
-                 *      0, 1 ,3, 7, 15, 31
+                                           enabled ? 3 : 0);
-                 * to determine the level in a simple way we can simply
+                } else if (led->type == LED_TYPE_ASSOC) {
-                 * work with bitshifting:
+                        rt2x00_set_field32(&reg, LED_CFG_Y_LED_MODE,
-                 *      (1 << level) - 1
+                                           enabled ? 3 : 0);
-                 */
+                } else if (led->type == LED_TYPE_QUALITY) {
-                rt2800_mcu_request(led->rt2x00dev, MCU_LED_STRENGTH, 0xff,
+                        rt2x00_set_field32(&reg, LED_CFG_R_LED_MODE,
-                                      (1 << brightness / (LED_FULL / 6)) - 1,
+                                           enabled ? 3 : 0);
-                                      polarity);
+                }
+                rt2800_register_write(led->rt2x00dev, LED_CFG, reg);
+        } else {
+                if (led->type == LED_TYPE_RADIO) {
+                        rt2800_mcu_request(led->rt2x00dev, MCU_LED, 0xff, ledmode,
+                                              enabled ? 0x20 : 0);
+                } else if (led->type == LED_TYPE_ASSOC) {
+                        rt2800_mcu_request(led->rt2x00dev, MCU_LED, 0xff, ledmode,
+                                              enabled ? (bg_mode ? 0x60 : 0xa0) : 0x20);
+                } else if (led->type == LED_TYPE_QUALITY) {
+                        /*
+                         * The brightness is divided into 6 levels (0 - 5),
+                         * The specs tell us the following levels:
+                         *      0, 1 ,3, 7, 15, 31
+                         * to determine the level in a simple way we can simply
+                         * work with bitshifting:
+                         *      (1 << level) - 1
+                         */
+                        rt2800_mcu_request(led->rt2x00dev, MCU_LED_STRENGTH, 0xff,
+                                              (1 << brightness / (LED_FULL / 6)) - 1,
+                                              polarity);
+                }
        }
 }
@@ -1218,6 +1231,25 @@ void rt2800_config_intf(struct rt2x00_dev *rt2x00dev, struct rt2x00_intf *intf,
                rt2800_register_read(rt2x00dev, BCN_TIME_CFG, &reg);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_TSF_SYNC, conf->sync);
                rt2800_register_write(rt2x00dev, BCN_TIME_CFG, reg);
+                if (conf->sync == TSF_SYNC_AP_NONE) {
+                        /*
+                         * Tune beacon queue transmit parameters for AP mode
+                         */
+                        rt2800_register_read(rt2x00dev, TBTT_SYNC_CFG, &reg);
+                        rt2x00_set_field32(&reg, TBTT_SYNC_CFG_BCN_CWMIN, 0);
+                        rt2x00_set_field32(&reg, TBTT_SYNC_CFG_BCN_AIFSN, 1);
+                        rt2x00_set_field32(&reg, TBTT_SYNC_CFG_BCN_EXP_WIN, 32);
+                        rt2x00_set_field32(&reg, TBTT_SYNC_CFG_TBTT_ADJUST, 0);
+                        rt2800_register_write(rt2x00dev, TBTT_SYNC_CFG, reg);
+                } else {
+                        rt2800_register_read(rt2x00dev, TBTT_SYNC_CFG, &reg);
+                        rt2x00_set_field32(&reg, TBTT_SYNC_CFG_BCN_CWMIN, 4);
+                        rt2x00_set_field32(&reg, TBTT_SYNC_CFG_BCN_AIFSN, 2);
+                        rt2x00_set_field32(&reg, TBTT_SYNC_CFG_BCN_EXP_WIN, 32);
+                        rt2x00_set_field32(&reg, TBTT_SYNC_CFG_TBTT_ADJUST, 16);
+                        rt2800_register_write(rt2x00dev, TBTT_SYNC_CFG, reg);
+                }
        }
        if (flags & CONFIG_UPDATE_MAC) {
@@ -1608,7 +1640,6 @@ static void rt2800_config_channel_rf53xx(struct rt2x00_dev *rt2x00dev,
                                         struct channel_info *info)
 {
        u8 rfcsr;
-        u16 eeprom;
        rt2800_rfcsr_write(rt2x00dev, 8, rf->rf1);
        rt2800_rfcsr_write(rt2x00dev, 9, rf->rf3);
@@ -1638,11 +1669,10 @@ static void rt2800_config_channel_rf53xx(struct rt2x00_dev *rt2x00dev,
                rt2x00_set_field8(&rfcsr, RFCSR17_CODE, rt2x00dev->freq_offset);
        rt2800_rfcsr_write(rt2x00dev, 17, rfcsr);
-        rt2x00_eeprom_read(rt2x00dev, EEPROM_NIC_CONF1, &eeprom);
        if (rf->channel <= 14) {
                int idx = rf->channel-1;
-                if (rt2x00_get_field16(eeprom, EEPROM_NIC_CONF1_BT_COEXIST)) {
+                if (test_bit(CAPABILITY_BT_COEXIST, &rt2x00dev->cap_flags)) {
                        if (rt2x00_rt_rev_gte(rt2x00dev, RT5390, REV_RT5390F)) {
                                /* r55/r59 value array of channel 1~14 */
                                static const char r55_bt_rev[] = {0x83, 0x83,
@@ -1721,7 +1751,8 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
            rt2x00_rf(rt2x00dev, RF3052) ||
            rt2x00_rf(rt2x00dev, RF3320))
                rt2800_config_channel_rf3xxx(rt2x00dev, conf, rf, info);
-        else if (rt2x00_rf(rt2x00dev, RF5390))
+        else if (rt2x00_rf(rt2x00dev, RF5370) ||
+                 rt2x00_rf(rt2x00dev, RF5390))
                rt2800_config_channel_rf53xx(rt2x00dev, conf, rf, info);
        else
                rt2800_config_channel_rf2xxx(rt2x00dev, conf, rf, info);
@@ -1736,8 +1767,8 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
        if (rf->channel <= 14) {
                if (!rt2x00_rt(rt2x00dev, RT5390)) {
-                        if (test_bit(CONFIG_EXTERNAL_LNA_BG,
+                        if (test_bit(CAPABILITY_EXTERNAL_LNA_BG,
-                                     &rt2x00dev->flags)) {
+                                     &rt2x00dev->cap_flags)) {
                                rt2800_bbp_write(rt2x00dev, 82, 0x62);
                                rt2800_bbp_write(rt2x00dev, 75, 0x46);
                        } else {
@@ -1748,7 +1779,7 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
        } else {
                rt2800_bbp_write(rt2x00dev, 82, 0xf2);
-                if (test_bit(CONFIG_EXTERNAL_LNA_A, &rt2x00dev->flags))
+                if (test_bit(CAPABILITY_EXTERNAL_LNA_A, &rt2x00dev->cap_flags))
                        rt2800_bbp_write(rt2x00dev, 75, 0x46);
                else
                        rt2800_bbp_write(rt2x00dev, 75, 0x50);
@@ -1813,17 +1844,131 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
        rt2800_register_read(rt2x00dev, CH_BUSY_STA_SEC, &reg);
 }
+static int rt2800_get_gain_calibration_delta(struct rt2x00_dev *rt2x00dev)
+{
+        u8 tssi_bounds[9];
+        u8 current_tssi;
+        u16 eeprom;
+        u8 step;
+        int i;
+        /*
+         * Read TSSI boundaries for temperature compensation from
+         * the EEPROM.
+         *
+         * Array idx               0    1    2    3    4    5    6    7    8
+         * Matching Delta value   -4   -3   -2   -1    0   +1   +2   +3   +4
+         * Example TSSI bounds  0xF0 0xD0 0xB5 0xA0 0x88 0x45 0x25 0x15 0x00
+         */
+        if (rt2x00dev->curr_band == IEEE80211_BAND_2GHZ) {
+                rt2x00_eeprom_read(rt2x00dev, EEPROM_TSSI_BOUND_BG1, &eeprom);
+                tssi_bounds[0] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_BG1_MINUS4);
+                tssi_bounds[1] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_BG1_MINUS3);
+                rt2x00_eeprom_read(rt2x00dev, EEPROM_TSSI_BOUND_BG2, &eeprom);
+                tssi_bounds[2] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_BG2_MINUS2);
+                tssi_bounds[3] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_BG2_MINUS1);
+                rt2x00_eeprom_read(rt2x00dev, EEPROM_TSSI_BOUND_BG3, &eeprom);
+                tssi_bounds[4] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_BG3_REF);
+                tssi_bounds[5] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_BG3_PLUS1);
+                rt2x00_eeprom_read(rt2x00dev, EEPROM_TSSI_BOUND_BG4, &eeprom);
+                tssi_bounds[6] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_BG4_PLUS2);
+                tssi_bounds[7] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_BG4_PLUS3);
+                rt2x00_eeprom_read(rt2x00dev, EEPROM_TSSI_BOUND_BG5, &eeprom);
+                tssi_bounds[8] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_BG5_PLUS4);
+                step = rt2x00_get_field16(eeprom,
+                                          EEPROM_TSSI_BOUND_BG5_AGC_STEP);
+        } else {
+                rt2x00_eeprom_read(rt2x00dev, EEPROM_TSSI_BOUND_A1, &eeprom);
+                tssi_bounds[0] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_A1_MINUS4);
+                tssi_bounds[1] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_A1_MINUS3);
+                rt2x00_eeprom_read(rt2x00dev, EEPROM_TSSI_BOUND_A2, &eeprom);
+                tssi_bounds[2] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_A2_MINUS2);
+                tssi_bounds[3] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_A2_MINUS1);
+                rt2x00_eeprom_read(rt2x00dev, EEPROM_TSSI_BOUND_A3, &eeprom);
+                tssi_bounds[4] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_A3_REF);
+                tssi_bounds[5] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_A3_PLUS1);
+                rt2x00_eeprom_read(rt2x00dev, EEPROM_TSSI_BOUND_A4, &eeprom);
+                tssi_bounds[6] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_A4_PLUS2);
+                tssi_bounds[7] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_A4_PLUS3);
+                rt2x00_eeprom_read(rt2x00dev, EEPROM_TSSI_BOUND_A5, &eeprom);
+                tssi_bounds[8] = rt2x00_get_field16(eeprom,
+                                        EEPROM_TSSI_BOUND_A5_PLUS4);
+                step = rt2x00_get_field16(eeprom,
+                                          EEPROM_TSSI_BOUND_A5_AGC_STEP);
+        }
+        /*
+         * Check if temperature compensation is supported.
+         */
+        if (tssi_bounds[4] == 0xff)
+                return 0;
+        /*
+         * Read current TSSI (BBP 49).
+         */
+        rt2800_bbp_read(rt2x00dev, 49, &current_tssi);
+        /*
+         * Compare TSSI value (BBP49) with the compensation boundaries
+         * from the EEPROM and increase or decrease tx power.
+         */
+        for (i = 0; i <= 3; i++) {
+                if (current_tssi > tssi_bounds[i])
+                        break;
+        }
+        if (i == 4) {
+                for (i = 8; i >= 5; i--) {
+                        if (current_tssi < tssi_bounds[i])
+                                break;
+                }
+        }
+        return (i - 4) * step;
+}
 static int rt2800_get_txpower_bw_comp(struct rt2x00_dev *rt2x00dev,
                                      enum ieee80211_band band)
 {
        u16 eeprom;
        u8 comp_en;
        u8 comp_type;
-        int comp_value;
+        int comp_value = 0;
        rt2x00_eeprom_read(rt2x00dev, EEPROM_TXPOWER_DELTA, &eeprom);
-        if (eeprom == 0xffff)
+        /*
+         * HT40 compensation not required.
+         */
+        if (eeprom == 0xffff ||
+            !test_bit(CONFIG_CHANNEL_HT40, &rt2x00dev->flags))
                return 0;
        if (band == IEEE80211_BAND_2GHZ) {
@@ -1853,11 +1998,9 @@ static int rt2800_get_txpower_bw_comp(struct rt2x00_dev *rt2x00dev,
        return comp_value;
 }
-static u8 rt2800_compesate_txpower(struct rt2x00_dev *rt2x00dev,
+static u8 rt2800_compensate_txpower(struct rt2x00_dev *rt2x00dev, int is_rate_b,
-                                     int is_rate_b,
+                                   enum ieee80211_band band, int power_level,
-                                     enum ieee80211_band band,
+                                   u8 txpower, int delta)
-                                     int power_level,
-                                     u8 txpower)
 {
        u32 reg;
        u16 eeprom;
@@ -1865,15 +2008,11 @@ static u8 rt2800_compesate_txpower(struct rt2x00_dev *rt2x00dev,
        u8 eirp_txpower;
        u8 eirp_txpower_criterion;
        u8 reg_limit;
-        int bw_comp = 0;
        if (!((band == IEEE80211_BAND_5GHZ) && is_rate_b))
                return txpower;
-        if (test_bit(CONFIG_CHANNEL_HT40, &rt2x00dev->flags))
+        if (test_bit(CAPABILITY_POWER_LIMIT, &rt2x00dev->cap_flags)) {
-                bw_comp = rt2800_get_txpower_bw_comp(rt2x00dev, band);
-        if (test_bit(CONFIG_SUPPORT_POWER_LIMIT, &rt2x00dev->flags)) {
                /*
                 * Check if eirp txpower exceed txpower_limit.
                 * We use OFDM 6M as criterion and its eirp txpower
@@ -1895,18 +2034,19 @@ static u8 rt2800_compesate_txpower(struct rt2x00_dev *rt2x00dev,
                                                 EEPROM_EIRP_MAX_TX_POWER_5GHZ);
                eirp_txpower = eirp_txpower_criterion + (txpower - criterion) +
-                                       (is_rate_b ? 4 : 0) + bw_comp;
+                               (is_rate_b ? 4 : 0) + delta;
                reg_limit = (eirp_txpower > power_level) ?
                                        (eirp_txpower - power_level) : 0;
        } else
                reg_limit = 0;
-        return txpower + bw_comp - reg_limit;
+        return txpower + delta - reg_limit;
 }
 static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
-                                  struct ieee80211_conf *conf)
+                                  enum ieee80211_band band,
+                                  int power_level)
 {
        u8 txpower;
        u16 eeprom;
@@ -1914,8 +2054,17 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
        u32 reg;
        u8 r1;
        u32 offset;
-        enum ieee80211_band band = conf->channel->band;
+        int delta;
-        int power_level = conf->power_level;
+        /*
+         * Calculate HT40 compensation delta
+         */
+        delta = rt2800_get_txpower_bw_comp(rt2x00dev, band);
+        /*
+         * calculate temperature compensation delta
+         */
+        delta += rt2800_get_gain_calibration_delta(rt2x00dev);
        /*
         * set to normal bbp tx power control mode: +/- 0dBm
@@ -1944,8 +2093,8 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
                 */
                txpower = rt2x00_get_field16(eeprom,
                                             EEPROM_TXPOWER_BYRATE_RATE0);
-                txpower = rt2800_compesate_txpower(rt2x00dev, is_rate_b, band,
+                txpower = rt2800_compensate_txpower(rt2x00dev, is_rate_b, band,
-                                             power_level, txpower);
+                                             power_level, txpower, delta);
                rt2x00_set_field32(&reg, TX_PWR_CFG_RATE0, txpower);
                /*
@@ -1955,8 +2104,8 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
                 */
                txpower = rt2x00_get_field16(eeprom,
                                             EEPROM_TXPOWER_BYRATE_RATE1);
-                txpower = rt2800_compesate_txpower(rt2x00dev, is_rate_b, band,
+                txpower = rt2800_compensate_txpower(rt2x00dev, is_rate_b, band,
-                                             power_level, txpower);
+                                             power_level, txpower, delta);
                rt2x00_set_field32(&reg, TX_PWR_CFG_RATE1, txpower);
                /*
@@ -1966,8 +2115,8 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
                 */
                txpower = rt2x00_get_field16(eeprom,
                                             EEPROM_TXPOWER_BYRATE_RATE2);
-                txpower = rt2800_compesate_txpower(rt2x00dev, is_rate_b, band,
+                txpower = rt2800_compensate_txpower(rt2x00dev, is_rate_b, band,
-                                             power_level, txpower);
+                                             power_level, txpower, delta);
                rt2x00_set_field32(&reg, TX_PWR_CFG_RATE2, txpower);
                /*
@@ -1977,8 +2126,8 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
                 */
                txpower = rt2x00_get_field16(eeprom,
                                             EEPROM_TXPOWER_BYRATE_RATE3);
-                txpower = rt2800_compesate_txpower(rt2x00dev, is_rate_b, band,
+                txpower = rt2800_compensate_txpower(rt2x00dev, is_rate_b, band,
-                                             power_level, txpower);
+                                             power_level, txpower, delta);
                rt2x00_set_field32(&reg, TX_PWR_CFG_RATE3, txpower);
                /* read the next four txpower values */
@@ -1993,8 +2142,8 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
                 */
                txpower = rt2x00_get_field16(eeprom,
                                             EEPROM_TXPOWER_BYRATE_RATE0);
-                txpower = rt2800_compesate_txpower(rt2x00dev, is_rate_b, band,
+                txpower = rt2800_compensate_txpower(rt2x00dev, is_rate_b, band,
-                                             power_level, txpower);
+                                             power_level, txpower, delta);
                rt2x00_set_field32(&reg, TX_PWR_CFG_RATE4, txpower);
                /*
@@ -2004,8 +2153,8 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
                 */
                txpower = rt2x00_get_field16(eeprom,
                                             EEPROM_TXPOWER_BYRATE_RATE1);
-                txpower = rt2800_compesate_txpower(rt2x00dev, is_rate_b, band,
+                txpower = rt2800_compensate_txpower(rt2x00dev, is_rate_b, band,
-                                             power_level, txpower);
+                                             power_level, txpower, delta);
                rt2x00_set_field32(&reg, TX_PWR_CFG_RATE5, txpower);
                /*
@@ -2015,8 +2164,8 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
                 */
                txpower = rt2x00_get_field16(eeprom,
                                             EEPROM_TXPOWER_BYRATE_RATE2);
-                txpower = rt2800_compesate_txpower(rt2x00dev, is_rate_b, band,
+                txpower = rt2800_compensate_txpower(rt2x00dev, is_rate_b, band,
-                                             power_level, txpower);
+                                             power_level, txpower, delta);
                rt2x00_set_field32(&reg, TX_PWR_CFG_RATE6, txpower);
                /*
@@ -2026,8 +2175,8 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
                 */
                txpower = rt2x00_get_field16(eeprom,
                                             EEPROM_TXPOWER_BYRATE_RATE3);
-                txpower = rt2800_compesate_txpower(rt2x00dev, is_rate_b, band,
+                txpower = rt2800_compensate_txpower(rt2x00dev, is_rate_b, band,
-                                             power_level, txpower);
+                                             power_level, txpower, delta);
                rt2x00_set_field32(&reg, TX_PWR_CFG_RATE7, txpower);
                rt2800_register_write(rt2x00dev, offset, reg);
@@ -2037,6 +2186,13 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
        }
 }
+void rt2800_gain_calibration(struct rt2x00_dev *rt2x00dev)
+{
+        rt2800_config_txpower(rt2x00dev, rt2x00dev->curr_band,
+                              rt2x00dev->tx_power);
+}
+EXPORT_SYMBOL_GPL(rt2800_gain_calibration);
 static void rt2800_config_retry_limit(struct rt2x00_dev *rt2x00dev,
                                      struct rt2x00lib_conf *libconf)
 {
@@ -2090,10 +2246,12 @@ void rt2800_config(struct rt2x00_dev *rt2x00dev,
        if (flags & IEEE80211_CONF_CHANGE_CHANNEL) {
                rt2800_config_channel(rt2x00dev, libconf->conf,
                                      &libconf->rf, &libconf->channel);
-                rt2800_config_txpower(rt2x00dev, libconf->conf);
+                rt2800_config_txpower(rt2x00dev, libconf->conf->channel->band,
+                                      libconf->conf->power_level);
        }
        if (flags & IEEE80211_CONF_CHANGE_POWER)
-                rt2800_config_txpower(rt2x00dev, libconf->conf);
+                rt2800_config_txpower(rt2x00dev, libconf->conf->channel->band,
+                                      libconf->conf->power_level);
        if (flags & IEEE80211_CONF_CHANGE_RETRY_LIMITS)
                rt2800_config_retry_limit(rt2x00dev, libconf);
        if (flags & IEEE80211_CONF_CHANGE_PS)
@@ -2254,7 +2412,7 @@ static int rt2800_init_registers(struct rt2x00_dev *rt2x00dev)
        } else if (rt2800_is_305x_soc(rt2x00dev)) {
                rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000400);
                rt2800_register_write(rt2x00dev, TX_SW_CFG1, 0x00000000);
-                rt2800_register_write(rt2x00dev, TX_SW_CFG2, 0x0000001f);
+                rt2800_register_write(rt2x00dev, TX_SW_CFG2, 0x00000030);
        } else if (rt2x00_rt(rt2x00dev, RT5390)) {
                rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404);
                rt2800_register_write(rt2x00dev, TX_SW_CFG1, 0x00080606);
@@ -2758,8 +2916,7 @@ static int rt2800_init_bbp(struct rt2x00_dev *rt2x00dev)
                ant = (div_mode == 3) ? 1 : 0;
                /* check if this is a Bluetooth combo card */
-                rt2x00_eeprom_read(rt2x00dev, EEPROM_NIC_CONF1, &eeprom);
+                if (test_bit(CAPABILITY_BT_COEXIST, &rt2x00dev->cap_flags)) {
-                if (rt2x00_get_field16(eeprom, EEPROM_NIC_CONF1_BT_COEXIST)) {
                        u32 reg;
                        rt2800_register_read(rt2x00dev, GPIO_CTRL_CFG, &reg);
@@ -3155,8 +3312,8 @@ static int rt2800_init_rfcsr(struct rt2x00_dev *rt2x00dev)
                    rt2x00_rt_rev_lt(rt2x00dev, RT3071, REV_RT3071E) ||
                    rt2x00_rt_rev_lt(rt2x00dev, RT3090, REV_RT3090E) ||
                    rt2x00_rt_rev_lt(rt2x00dev, RT3390, REV_RT3390E)) {
-                        if (!test_bit(CONFIG_EXTERNAL_LNA_BG,
+                        if (!test_bit(CAPABILITY_EXTERNAL_LNA_BG,
-                                      &rt2x00dev->flags))
+                                      &rt2x00dev->cap_flags))
                                rt2x00_set_field8(&rfcsr, RFCSR17_R, 1);
                }
                rt2x00_eeprom_read(rt2x00dev, EEPROM_TXMIXER_GAIN_BG, &eeprom);
@@ -3530,6 +3687,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
            !rt2x00_rf(rt2x00dev, RF3022) &&
            !rt2x00_rf(rt2x00dev, RF3052) &&
            !rt2x00_rf(rt2x00dev, RF3320) &&
+            !rt2x00_rf(rt2x00dev, RF5370) &&
            !rt2x00_rf(rt2x00dev, RF5390)) {
                ERROR(rt2x00dev, "Invalid RF chipset detected.\n");
                return -ENODEV;
@@ -3568,26 +3726,30 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
        }
        /*
-         * Read frequency offset and RF programming sequence.
+         * Determine external LNA informations.
         */
-        rt2x00_eeprom_read(rt2x00dev, EEPROM_FREQ, &eeprom);
-        rt2x00dev->freq_offset = rt2x00_get_field16(eeprom, EEPROM_FREQ_OFFSET);
-        /*
-         * Read external LNA informations.
-         */
-        rt2x00_eeprom_read(rt2x00dev, EEPROM_NIC_CONF1, &eeprom);
        if (rt2x00_get_field16(eeprom, EEPROM_NIC_CONF1_EXTERNAL_LNA_5G))
-                __set_bit(CONFIG_EXTERNAL_LNA_A, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_EXTERNAL_LNA_A, &rt2x00dev->cap_flags);
        if (rt2x00_get_field16(eeprom, EEPROM_NIC_CONF1_EXTERNAL_LNA_2G))
-                __set_bit(CONFIG_EXTERNAL_LNA_BG, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_EXTERNAL_LNA_BG, &rt2x00dev->cap_flags);
        /*
         * Detect if this device has an hardware controlled radio.
         */
        if (rt2x00_get_field16(eeprom, EEPROM_NIC_CONF1_HW_RADIO))
-                __set_bit(CONFIG_SUPPORT_HW_BUTTON, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_BUTTON, &rt2x00dev->cap_flags);
+        /*
+         * Detect if this device has Bluetooth co-existence.
+         */
+        if (rt2x00_get_field16(eeprom, EEPROM_NIC_CONF1_BT_COEXIST))
+                __set_bit(CAPABILITY_BT_COEXIST, &rt2x00dev->cap_flags);
+        /*
+         * Read frequency offset and RF programming sequence.
+         */
+        rt2x00_eeprom_read(rt2x00dev, EEPROM_FREQ, &eeprom);
+        rt2x00dev->freq_offset = rt2x00_get_field16(eeprom, EEPROM_FREQ_OFFSET);
        /*
         * Store led settings, for correct led behaviour.
@@ -3597,7 +3759,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
        rt2800_init_led(rt2x00dev, &rt2x00dev->led_assoc, LED_TYPE_ASSOC);
        rt2800_init_led(rt2x00dev, &rt2x00dev->led_qual, LED_TYPE_QUALITY);
-        rt2x00_eeprom_read(rt2x00dev, EEPROM_FREQ, &rt2x00dev->led_mcu_reg);
+        rt2x00dev->led_mcu_reg = eeprom;
 #endif /* CONFIG_RT2X00_LIB_LEDS */
        /*
@@ -3607,7 +3769,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
        if (rt2x00_get_field16(eeprom, EEPROM_EIRP_MAX_TX_POWER_2GHZ) <
                                        EIRP_MAX_TX_POWER_LIMIT)
-                __set_bit(CONFIG_SUPPORT_POWER_LIMIT, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_POWER_LIMIT, &rt2x00dev->cap_flags);
        return 0;
 }
@@ -3828,6 +3990,7 @@ int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
                   rt2x00_rf(rt2x00dev, RF3021) ||
                   rt2x00_rf(rt2x00dev, RF3022) ||
                   rt2x00_rf(rt2x00dev, RF3320) ||
+                   rt2x00_rf(rt2x00dev, RF5370) ||
                   rt2x00_rf(rt2x00dev, RF5390)) {
                spec->num_channels = 14;
                spec->channels = rf_vals_3x;
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.h b/drivers/net/wireless/rt2x00/rt2800lib.h
index 0c92d86a36f4..f2d15941c71a 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.h
+++ b/drivers/net/wireless/rt2x00/rt2800lib.h
@@ -181,6 +181,7 @@ void rt2800_link_stats(struct rt2x00_dev *rt2x00dev, struct link_qual *qual);
 void rt2800_reset_tuner(struct rt2x00_dev *rt2x00dev, struct link_qual *qual);
 void rt2800_link_tuner(struct rt2x00_dev *rt2x00dev, struct link_qual *qual,
                       const u32 count);
+void rt2800_gain_calibration(struct rt2x00_dev *rt2x00dev);
 int rt2800_enable_radio(struct rt2x00_dev *rt2x00dev);
 void rt2800_disable_radio(struct rt2x00_dev *rt2x00dev);
diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
index 808073aa9dcc..cc4a54f571b8 100644
--- a/drivers/net/wireless/rt2x00/rt2800pci.c
+++ b/drivers/net/wireless/rt2x00/rt2800pci.c
@@ -66,7 +66,7 @@ static void rt2800pci_mcu_status(struct rt2x00_dev *rt2x00dev, const u8 token)
                return;
        for (i = 0; i < 200; i++) {
-                rt2800_register_read(rt2x00dev, H2M_MAILBOX_CID, &reg);
+                rt2x00pci_register_read(rt2x00dev, H2M_MAILBOX_CID, &reg);
                if ((rt2x00_get_field32(reg, H2M_MAILBOX_CID_CMD0) == token) ||
                    (rt2x00_get_field32(reg, H2M_MAILBOX_CID_CMD1) == token) ||
@@ -80,8 +80,8 @@ static void rt2800pci_mcu_status(struct rt2x00_dev *rt2x00dev, const u8 token)
        if (i == 200)
                ERROR(rt2x00dev, "MCU request failed, no response from hardware\n");
-        rt2800_register_write(rt2x00dev, H2M_MAILBOX_STATUS, ~0);
+        rt2x00pci_register_write(rt2x00dev, H2M_MAILBOX_STATUS, ~0);
-        rt2800_register_write(rt2x00dev, H2M_MAILBOX_CID, ~0);
+        rt2x00pci_register_write(rt2x00dev, H2M_MAILBOX_CID, ~0);
 }
 #if defined(CONFIG_RALINK_RT288X) || defined(CONFIG_RALINK_RT305X)
@@ -105,7 +105,7 @@ static void rt2800pci_eepromregister_read(struct eeprom_93cx6 *eeprom)
        struct rt2x00_dev *rt2x00dev = eeprom->data;
        u32 reg;
-        rt2800_register_read(rt2x00dev, E2PROM_CSR, &reg);
+        rt2x00pci_register_read(rt2x00dev, E2PROM_CSR, &reg);
        eeprom->reg_data_in = !!rt2x00_get_field32(reg, E2PROM_CSR_DATA_IN);
        eeprom->reg_data_out = !!rt2x00_get_field32(reg, E2PROM_CSR_DATA_OUT);
@@ -127,7 +127,7 @@ static void rt2800pci_eepromregister_write(struct eeprom_93cx6 *eeprom)
        rt2x00_set_field32(&reg, E2PROM_CSR_CHIP_SELECT,
                           !!eeprom->reg_chip_select);
-        rt2800_register_write(rt2x00dev, E2PROM_CSR, reg);
+        rt2x00pci_register_write(rt2x00dev, E2PROM_CSR, reg);
 }
 static void rt2800pci_read_eeprom_pci(struct rt2x00_dev *rt2x00dev)
@@ -135,7 +135,7 @@ static void rt2800pci_read_eeprom_pci(struct rt2x00_dev *rt2x00dev)
        struct eeprom_93cx6 eeprom;
        u32 reg;
-        rt2800_register_read(rt2x00dev, E2PROM_CSR, &reg);
+        rt2x00pci_register_read(rt2x00dev, E2PROM_CSR, &reg);
        eeprom.data = rt2x00dev;
        eeprom.register_read = rt2800pci_eepromregister_read;
@@ -195,9 +195,9 @@ static void rt2800pci_start_queue(struct data_queue *queue)
        switch (queue->qid) {
        case QID_RX:
-                rt2800_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
+                rt2x00pci_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
                rt2x00_set_field32(&reg, MAC_SYS_CTRL_ENABLE_RX, 1);
-                rt2800_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
+                rt2x00pci_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
                break;
        case QID_BEACON:
                /*
@@ -207,15 +207,15 @@ static void rt2800pci_start_queue(struct data_queue *queue)
                tasklet_enable(&rt2x00dev->tbtt_tasklet);
                tasklet_enable(&rt2x00dev->pretbtt_tasklet);
-                rt2800_register_read(rt2x00dev, BCN_TIME_CFG, &reg);
+                rt2x00pci_register_read(rt2x00dev, BCN_TIME_CFG, &reg);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_TSF_TICKING, 1);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_TBTT_ENABLE, 1);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_BEACON_GEN, 1);
-                rt2800_register_write(rt2x00dev, BCN_TIME_CFG, reg);
+                rt2x00pci_register_write(rt2x00dev, BCN_TIME_CFG, reg);
-                rt2800_register_read(rt2x00dev, INT_TIMER_EN, &reg);
+                rt2x00pci_register_read(rt2x00dev, INT_TIMER_EN, &reg);
                rt2x00_set_field32(&reg, INT_TIMER_EN_PRE_TBTT_TIMER, 1);
-                rt2800_register_write(rt2x00dev, INT_TIMER_EN, reg);
+                rt2x00pci_register_write(rt2x00dev, INT_TIMER_EN, reg);
                break;
        default:
                break;
@@ -233,11 +233,13 @@ static void rt2800pci_kick_queue(struct data_queue *queue)
        case QID_AC_BE:
        case QID_AC_BK:
                entry = rt2x00queue_get_entry(queue, Q_INDEX);
-                rt2800_register_write(rt2x00dev, TX_CTX_IDX(queue->qid), entry->entry_idx);
+                rt2x00pci_register_write(rt2x00dev, TX_CTX_IDX(queue->qid),
+                                         entry->entry_idx);
                break;
        case QID_MGMT:
                entry = rt2x00queue_get_entry(queue, Q_INDEX);
-                rt2800_register_write(rt2x00dev, TX_CTX_IDX(5), entry->entry_idx);
+                rt2x00pci_register_write(rt2x00dev, TX_CTX_IDX(5),
+                                         entry->entry_idx);
                break;
        default:
                break;
@@ -251,20 +253,20 @@ static void rt2800pci_stop_queue(struct data_queue *queue)
        switch (queue->qid) {
        case QID_RX:
-                rt2800_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
+                rt2x00pci_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
                rt2x00_set_field32(&reg, MAC_SYS_CTRL_ENABLE_RX, 0);
-                rt2800_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
+                rt2x00pci_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
                break;
        case QID_BEACON:
-                rt2800_register_read(rt2x00dev, BCN_TIME_CFG, &reg);
+                rt2x00pci_register_read(rt2x00dev, BCN_TIME_CFG, &reg);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_TSF_TICKING, 0);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_TBTT_ENABLE, 0);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_BEACON_GEN, 0);
-                rt2800_register_write(rt2x00dev, BCN_TIME_CFG, reg);
+                rt2x00pci_register_write(rt2x00dev, BCN_TIME_CFG, reg);
-                rt2800_register_read(rt2x00dev, INT_TIMER_EN, &reg);
+                rt2x00pci_register_read(rt2x00dev, INT_TIMER_EN, &reg);
                rt2x00_set_field32(&reg, INT_TIMER_EN_PRE_TBTT_TIMER, 0);
-                rt2800_register_write(rt2x00dev, INT_TIMER_EN, reg);
+                rt2x00pci_register_write(rt2x00dev, INT_TIMER_EN, reg);
                /*
                 * Wait for tbtt tasklets to finish.
@@ -295,19 +297,19 @@ static int rt2800pci_write_firmware(struct rt2x00_dev *rt2x00dev,
         */
        reg = 0;
        rt2x00_set_field32(&reg, PBF_SYS_CTRL_HOST_RAM_WRITE, 1);
-        rt2800_register_write(rt2x00dev, PBF_SYS_CTRL, reg);
+        rt2x00pci_register_write(rt2x00dev, PBF_SYS_CTRL, reg);
        /*
         * Write firmware to device.
         */
-        rt2800_register_multiwrite(rt2x00dev, FIRMWARE_IMAGE_BASE,
+        rt2x00pci_register_multiwrite(rt2x00dev, FIRMWARE_IMAGE_BASE,
-                                   data, len);
+                                      data, len);
-        rt2800_register_write(rt2x00dev, PBF_SYS_CTRL, 0x00000);
+        rt2x00pci_register_write(rt2x00dev, PBF_SYS_CTRL, 0x00000);
-        rt2800_register_write(rt2x00dev, PBF_SYS_CTRL, 0x00001);
+        rt2x00pci_register_write(rt2x00dev, PBF_SYS_CTRL, 0x00001);
-        rt2800_register_write(rt2x00dev, H2M_BBP_AGENT, 0);
+        rt2x00pci_register_write(rt2x00dev, H2M_BBP_AGENT, 0);
-        rt2800_register_write(rt2x00dev, H2M_MAILBOX_CSR, 0);
+        rt2x00pci_register_write(rt2x00dev, H2M_MAILBOX_CSR, 0);
        return 0;
 }
@@ -351,7 +353,7 @@ static void rt2800pci_clear_entry(struct queue_entry *entry)
                 * Set RX IDX in register to inform hardware that we have
                 * handled this entry and it is available for reuse again.
                 */
-                rt2800_register_write(rt2x00dev, RX_CRX_IDX,
+                rt2x00pci_register_write(rt2x00dev, RX_CRX_IDX,
                                      entry->entry_idx);
        } else {
                rt2x00_desc_read(entry_priv->desc, 1, &word);
@@ -369,45 +371,51 @@ static int rt2800pci_init_queues(struct rt2x00_dev *rt2x00dev)
         * Initialize registers.
         */
        entry_priv = rt2x00dev->tx[0].entries[0].priv_data;
-        rt2800_register_write(rt2x00dev, TX_BASE_PTR0, entry_priv->desc_dma);
+        rt2x00pci_register_write(rt2x00dev, TX_BASE_PTR0, entry_priv->desc_dma);
-        rt2800_register_write(rt2x00dev, TX_MAX_CNT0, rt2x00dev->tx[0].limit);
+        rt2x00pci_register_write(rt2x00dev, TX_MAX_CNT0,
-        rt2800_register_write(rt2x00dev, TX_CTX_IDX0, 0);
+                                 rt2x00dev->tx[0].limit);
-        rt2800_register_write(rt2x00dev, TX_DTX_IDX0, 0);
+        rt2x00pci_register_write(rt2x00dev, TX_CTX_IDX0, 0);
+        rt2x00pci_register_write(rt2x00dev, TX_DTX_IDX0, 0);
        entry_priv = rt2x00dev->tx[1].entries[0].priv_data;
-        rt2800_register_write(rt2x00dev, TX_BASE_PTR1, entry_priv->desc_dma);
+        rt2x00pci_register_write(rt2x00dev, TX_BASE_PTR1, entry_priv->desc_dma);
-        rt2800_register_write(rt2x00dev, TX_MAX_CNT1, rt2x00dev->tx[1].limit);
+        rt2x00pci_register_write(rt2x00dev, TX_MAX_CNT1,
-        rt2800_register_write(rt2x00dev, TX_CTX_IDX1, 0);
+                                 rt2x00dev->tx[1].limit);
-        rt2800_register_write(rt2x00dev, TX_DTX_IDX1, 0);
+        rt2x00pci_register_write(rt2x00dev, TX_CTX_IDX1, 0);
+        rt2x00pci_register_write(rt2x00dev, TX_DTX_IDX1, 0);
        entry_priv = rt2x00dev->tx[2].entries[0].priv_data;
-        rt2800_register_write(rt2x00dev, TX_BASE_PTR2, entry_priv->desc_dma);
+        rt2x00pci_register_write(rt2x00dev, TX_BASE_PTR2, entry_priv->desc_dma);
-        rt2800_register_write(rt2x00dev, TX_MAX_CNT2, rt2x00dev->tx[2].limit);
+        rt2x00pci_register_write(rt2x00dev, TX_MAX_CNT2,
-        rt2800_register_write(rt2x00dev, TX_CTX_IDX2, 0);
+                                 rt2x00dev->tx[2].limit);
-        rt2800_register_write(rt2x00dev, TX_DTX_IDX2, 0);
+        rt2x00pci_register_write(rt2x00dev, TX_CTX_IDX2, 0);
+        rt2x00pci_register_write(rt2x00dev, TX_DTX_IDX2, 0);
        entry_priv = rt2x00dev->tx[3].entries[0].priv_data;
-        rt2800_register_write(rt2x00dev, TX_BASE_PTR3, entry_priv->desc_dma);
+        rt2x00pci_register_write(rt2x00dev, TX_BASE_PTR3, entry_priv->desc_dma);
-        rt2800_register_write(rt2x00dev, TX_MAX_CNT3, rt2x00dev->tx[3].limit);
+        rt2x00pci_register_write(rt2x00dev, TX_MAX_CNT3,
-        rt2800_register_write(rt2x00dev, TX_CTX_IDX3, 0);
+                                 rt2x00dev->tx[3].limit);
-        rt2800_register_write(rt2x00dev, TX_DTX_IDX3, 0);
+        rt2x00pci_register_write(rt2x00dev, TX_CTX_IDX3, 0);
+        rt2x00pci_register_write(rt2x00dev, TX_DTX_IDX3, 0);
        entry_priv = rt2x00dev->rx->entries[0].priv_data;
-        rt2800_register_write(rt2x00dev, RX_BASE_PTR, entry_priv->desc_dma);
+        rt2x00pci_register_write(rt2x00dev, RX_BASE_PTR, entry_priv->desc_dma);
-        rt2800_register_write(rt2x00dev, RX_MAX_CNT, rt2x00dev->rx[0].limit);
+        rt2x00pci_register_write(rt2x00dev, RX_MAX_CNT,
-        rt2800_register_write(rt2x00dev, RX_CRX_IDX, rt2x00dev->rx[0].limit - 1);
+                                 rt2x00dev->rx[0].limit);
-        rt2800_register_write(rt2x00dev, RX_DRX_IDX, 0);
+        rt2x00pci_register_write(rt2x00dev, RX_CRX_IDX,
+                                 rt2x00dev->rx[0].limit - 1);
+        rt2x00pci_register_write(rt2x00dev, RX_DRX_IDX, 0);
        /*
         * Enable global DMA configuration
         */
-        rt2800_register_read(rt2x00dev, WPDMA_GLO_CFG, &reg);
+        rt2x00pci_register_read(rt2x00dev, WPDMA_GLO_CFG, &reg);
        rt2x00_set_field32(&reg, WPDMA_GLO_CFG_ENABLE_TX_DMA, 0);
        rt2x00_set_field32(&reg, WPDMA_GLO_CFG_ENABLE_RX_DMA, 0);
        rt2x00_set_field32(&reg, WPDMA_GLO_CFG_TX_WRITEBACK_DONE, 1);
-        rt2800_register_write(rt2x00dev, WPDMA_GLO_CFG, reg);
+        rt2x00pci_register_write(rt2x00dev, WPDMA_GLO_CFG, reg);
-        rt2800_register_write(rt2x00dev, DELAY_INT_CFG, 0);
+        rt2x00pci_register_write(rt2x00dev, DELAY_INT_CFG, 0);
        return 0;
 }
@@ -427,8 +435,8 @@ static void rt2800pci_toggle_irq(struct rt2x00_dev *rt2x00dev,
         * should clear the register to assure a clean state.
         */
        if (state == STATE_RADIO_IRQ_ON) {
-                rt2800_register_read(rt2x00dev, INT_SOURCE_CSR, &reg);
+                rt2x00pci_register_read(rt2x00dev, INT_SOURCE_CSR, &reg);
-                rt2800_register_write(rt2x00dev, INT_SOURCE_CSR, reg);
+                rt2x00pci_register_write(rt2x00dev, INT_SOURCE_CSR, reg);
                /*
                 * Enable tasklets. The beacon related tasklets are
@@ -440,7 +448,7 @@ static void rt2800pci_toggle_irq(struct rt2x00_dev *rt2x00dev,
        }
        spin_lock_irqsave(&rt2x00dev->irqmask_lock, flags);
-        rt2800_register_read(rt2x00dev, INT_MASK_CSR, &reg);
+        rt2x00pci_register_read(rt2x00dev, INT_MASK_CSR, &reg);
        rt2x00_set_field32(&reg, INT_MASK_CSR_RXDELAYINT, 0);
        rt2x00_set_field32(&reg, INT_MASK_CSR_TXDELAYINT, 0);
        rt2x00_set_field32(&reg, INT_MASK_CSR_RX_DONE, mask);
@@ -459,7 +467,7 @@ static void rt2800pci_toggle_irq(struct rt2x00_dev *rt2x00dev,
        rt2x00_set_field32(&reg, INT_MASK_CSR_GPTIMER, 0);
        rt2x00_set_field32(&reg, INT_MASK_CSR_RX_COHERENT, 0);
        rt2x00_set_field32(&reg, INT_MASK_CSR_TX_COHERENT, 0);
-        rt2800_register_write(rt2x00dev, INT_MASK_CSR, reg);
+        rt2x00pci_register_write(rt2x00dev, INT_MASK_CSR, reg);
        spin_unlock_irqrestore(&rt2x00dev->irqmask_lock, flags);
        if (state == STATE_RADIO_IRQ_OFF) {
@@ -480,7 +488,7 @@ static int rt2800pci_init_registers(struct rt2x00_dev *rt2x00dev)
        /*
         * Reset DMA indexes
         */
-        rt2800_register_read(rt2x00dev, WPDMA_RST_IDX, &reg);
+        rt2x00pci_register_read(rt2x00dev, WPDMA_RST_IDX, &reg);
        rt2x00_set_field32(&reg, WPDMA_RST_IDX_DTX_IDX0, 1);
        rt2x00_set_field32(&reg, WPDMA_RST_IDX_DTX_IDX1, 1);
        rt2x00_set_field32(&reg, WPDMA_RST_IDX_DTX_IDX2, 1);
@@ -488,26 +496,26 @@ static int rt2800pci_init_registers(struct rt2x00_dev *rt2x00dev)
        rt2x00_set_field32(&reg, WPDMA_RST_IDX_DTX_IDX4, 1);
        rt2x00_set_field32(&reg, WPDMA_RST_IDX_DTX_IDX5, 1);
        rt2x00_set_field32(&reg, WPDMA_RST_IDX_DRX_IDX0, 1);
-        rt2800_register_write(rt2x00dev, WPDMA_RST_IDX, reg);
+        rt2x00pci_register_write(rt2x00dev, WPDMA_RST_IDX, reg);
-        rt2800_register_write(rt2x00dev, PBF_SYS_CTRL, 0x00000e1f);
+        rt2x00pci_register_write(rt2x00dev, PBF_SYS_CTRL, 0x00000e1f);
-        rt2800_register_write(rt2x00dev, PBF_SYS_CTRL, 0x00000e00);
+        rt2x00pci_register_write(rt2x00dev, PBF_SYS_CTRL, 0x00000e00);
        if (rt2x00_rt(rt2x00dev, RT5390)) {
-                rt2800_register_read(rt2x00dev, AUX_CTRL, &reg);
+                rt2x00pci_register_read(rt2x00dev, AUX_CTRL, &reg);
                rt2x00_set_field32(&reg, AUX_CTRL_FORCE_PCIE_CLK, 1);
                rt2x00_set_field32(&reg, AUX_CTRL_WAKE_PCIE_EN, 1);
-                rt2800_register_write(rt2x00dev, AUX_CTRL, reg);
+                rt2x00pci_register_write(rt2x00dev, AUX_CTRL, reg);
        }
-        rt2800_register_write(rt2x00dev, PWR_PIN_CFG, 0x00000003);
+        rt2x00pci_register_write(rt2x00dev, PWR_PIN_CFG, 0x00000003);
-        rt2800_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
+        rt2x00pci_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
        rt2x00_set_field32(&reg, MAC_SYS_CTRL_RESET_CSR, 1);
        rt2x00_set_field32(&reg, MAC_SYS_CTRL_RESET_BBP, 1);
-        rt2800_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
+        rt2x00pci_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
-        rt2800_register_write(rt2x00dev, MAC_SYS_CTRL, 0x00000000);
+        rt2x00pci_register_write(rt2x00dev, MAC_SYS_CTRL, 0x00000000);
        return 0;
 }
@@ -525,8 +533,8 @@ static void rt2800pci_disable_radio(struct rt2x00_dev *rt2x00dev)
 {
        if (rt2x00_is_soc(rt2x00dev)) {
                rt2800_disable_radio(rt2x00dev);
-                rt2800_register_write(rt2x00dev, PWR_PIN_CFG, 0);
+                rt2x00pci_register_write(rt2x00dev, PWR_PIN_CFG, 0);
-                rt2800_register_write(rt2x00dev, TX_PIN_CFG, 0);
+                rt2x00pci_register_write(rt2x00dev, TX_PIN_CFG, 0);
        }
 }
@@ -537,8 +545,10 @@ static int rt2800pci_set_state(struct rt2x00_dev *rt2x00dev,
                rt2800_mcu_request(rt2x00dev, MCU_WAKEUP, TOKEN_WAKUP, 0, 0x02);
                rt2800pci_mcu_status(rt2x00dev, TOKEN_WAKUP);
        } else if (state == STATE_SLEEP) {
-                rt2800_register_write(rt2x00dev, H2M_MAILBOX_STATUS, 0xffffffff);
+                rt2x00pci_register_write(rt2x00dev, H2M_MAILBOX_STATUS,
-                rt2800_register_write(rt2x00dev, H2M_MAILBOX_CID, 0xffffffff);
+                                         0xffffffff);
+                rt2x00pci_register_write(rt2x00dev, H2M_MAILBOX_CID,
+                                         0xffffffff);
                rt2800_mcu_request(rt2x00dev, MCU_SLEEP, 0x01, 0xff, 0x01);
        }
@@ -717,12 +727,13 @@ static void rt2800pci_wakeup(struct rt2x00_dev *rt2x00dev)
        rt2800_config(rt2x00dev, &libconf, IEEE80211_CONF_CHANGE_PS);
 }
-static void rt2800pci_txdone(struct rt2x00_dev *rt2x00dev)
+static bool rt2800pci_txdone(struct rt2x00_dev *rt2x00dev)
 {
        struct data_queue *queue;
        struct queue_entry *entry;
        u32 status;
        u8 qid;
+        int max_tx_done = 16;
        while (kfifo_get(&rt2x00dev->txstatus_fifo, &status)) {
                qid = rt2x00_get_field32(status, TX_STA_FIFO_PID_QUEUE);
@@ -759,11 +770,16 @@ static void rt2800pci_txdone(struct rt2x00_dev *rt2x00dev)
                entry = rt2x00queue_get_entry(queue, Q_INDEX_DONE);
                rt2800_txdone_entry(entry, status);
+                if (--max_tx_done == 0)
+                        break;
        }
+        return !max_tx_done;
 }
-static void rt2800pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,
+static inline void rt2800pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,
-                                       struct rt2x00_field32 irq_field)
+                                              struct rt2x00_field32 irq_field)
 {
        u32 reg;
@@ -772,15 +788,17 @@ static void rt2800pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,
         * access needs locking.
         */
        spin_lock_irq(&rt2x00dev->irqmask_lock);
-        rt2800_register_read(rt2x00dev, INT_MASK_CSR, &reg);
+        rt2x00pci_register_read(rt2x00dev, INT_MASK_CSR, &reg);
        rt2x00_set_field32(&reg, irq_field, 1);
-        rt2800_register_write(rt2x00dev, INT_MASK_CSR, reg);
+        rt2x00pci_register_write(rt2x00dev, INT_MASK_CSR, reg);
        spin_unlock_irq(&rt2x00dev->irqmask_lock);
 }
 static void rt2800pci_txstatus_tasklet(unsigned long data)
 {
-        rt2800pci_txdone((struct rt2x00_dev *)data);
+        struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data;
+        if (rt2800pci_txdone(rt2x00dev))
+                tasklet_schedule(&rt2x00dev->txstatus_tasklet);
        /*
         * No need to enable the tx status interrupt here as we always
@@ -806,8 +824,10 @@ static void rt2800pci_tbtt_tasklet(unsigned long data)
 static void rt2800pci_rxdone_tasklet(unsigned long data)
 {
        struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data;
-        rt2x00pci_rxdone(rt2x00dev);
+        if (rt2x00pci_rxdone(rt2x00dev))
-        rt2800pci_enable_interrupt(rt2x00dev, INT_MASK_CSR_RX_DONE);
+                tasklet_schedule(&rt2x00dev->rxdone_tasklet);
+        else
+                rt2800pci_enable_interrupt(rt2x00dev, INT_MASK_CSR_RX_DONE);
 }
 static void rt2800pci_autowake_tasklet(unsigned long data)
@@ -841,7 +861,7 @@ static void rt2800pci_txstatus_interrupt(struct rt2x00_dev *rt2x00dev)
         * need to lock the kfifo.
         */
        for (i = 0; i < rt2x00dev->ops->tx->entry_num; i++) {
-                rt2800_register_read(rt2x00dev, TX_STA_FIFO, &status);
+                rt2x00pci_register_read(rt2x00dev, TX_STA_FIFO, &status);
                if (!rt2x00_get_field32(status, TX_STA_FIFO_VALID))
                        break;
@@ -863,8 +883,8 @@ static irqreturn_t rt2800pci_interrupt(int irq, void *dev_instance)
        u32 reg, mask;
        /* Read status and ACK all interrupts */
-        rt2800_register_read(rt2x00dev, INT_SOURCE_CSR, &reg);
+        rt2x00pci_register_read(rt2x00dev, INT_SOURCE_CSR, &reg);
-        rt2800_register_write(rt2x00dev, INT_SOURCE_CSR, reg);
+        rt2x00pci_register_write(rt2x00dev, INT_SOURCE_CSR, reg);
        if (!reg)
                return IRQ_NONE;
@@ -904,9 +924,9 @@ static irqreturn_t rt2800pci_interrupt(int irq, void *dev_instance)
         * the tasklet will reenable the appropriate interrupts.
         */
        spin_lock(&rt2x00dev->irqmask_lock);
-        rt2800_register_read(rt2x00dev, INT_MASK_CSR, &reg);
+        rt2x00pci_register_read(rt2x00dev, INT_MASK_CSR, &reg);
        reg &= mask;
-        rt2800_register_write(rt2x00dev, INT_MASK_CSR, reg);
+        rt2x00pci_register_write(rt2x00dev, INT_MASK_CSR, reg);
        spin_unlock(&rt2x00dev->irqmask_lock);
        return IRQ_HANDLED;
@@ -956,28 +976,28 @@ static int rt2800pci_probe_hw(struct rt2x00_dev *rt2x00dev)
         * This device has multiple filters for control frames
         * and has a separate filter for PS Poll frames.
         */
-        __set_bit(DRIVER_SUPPORT_CONTROL_FILTERS, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_CONTROL_FILTERS, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_SUPPORT_CONTROL_FILTER_PSPOLL, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_CONTROL_FILTER_PSPOLL, &rt2x00dev->cap_flags);
        /*
         * This device has a pre tbtt interrupt and thus fetches
         * a new beacon directly prior to transmission.
         */
-        __set_bit(DRIVER_SUPPORT_PRE_TBTT_INTERRUPT, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_PRE_TBTT_INTERRUPT, &rt2x00dev->cap_flags);
        /*
         * This device requires firmware.
         */
        if (!rt2x00_is_soc(rt2x00dev))
-                __set_bit(DRIVER_REQUIRE_FIRMWARE, &rt2x00dev->flags);
+                __set_bit(REQUIRE_FIRMWARE, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_DMA, &rt2x00dev->flags);
+        __set_bit(REQUIRE_DMA, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_L2PAD, &rt2x00dev->flags);
+        __set_bit(REQUIRE_L2PAD, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_TXSTATUS_FIFO, &rt2x00dev->flags);
+        __set_bit(REQUIRE_TXSTATUS_FIFO, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_TASKLET_CONTEXT, &rt2x00dev->flags);
+        __set_bit(REQUIRE_TASKLET_CONTEXT, &rt2x00dev->cap_flags);
        if (!modparam_nohwcrypt)
-                __set_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_SUPPORT_LINK_TUNING, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_LINK_TUNING, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_HT_TX_DESC, &rt2x00dev->flags);
+        __set_bit(REQUIRE_HT_TX_DESC, &rt2x00dev->cap_flags);
        /*
         * Set the rssi offset.
@@ -1008,6 +1028,7 @@ static const struct ieee80211_ops rt2800pci_mac80211_ops = {
        .ampdu_action           = rt2800_ampdu_action,
        .flush                  = rt2x00mac_flush,
        .get_survey             = rt2800_get_survey,
+        .get_ringparam          = rt2x00mac_get_ringparam,
 };
 static const struct rt2800_ops rt2800pci_rt2800_ops = {
@@ -1043,9 +1064,11 @@ static const struct rt2x00lib_ops rt2800pci_rt2x00_ops = {
        .link_stats             = rt2800_link_stats,
        .reset_tuner            = rt2800_reset_tuner,
        .link_tuner             = rt2800_link_tuner,
+        .gain_calibration       = rt2800_gain_calibration,
        .start_queue            = rt2800pci_start_queue,
        .kick_queue             = rt2800pci_kick_queue,
        .stop_queue             = rt2800pci_stop_queue,
+        .flush_queue            = rt2x00pci_flush_queue,
        .write_tx_desc          = rt2800pci_write_tx_desc,
        .write_tx_data          = rt2800_write_tx_data,
        .write_beacon           = rt2800_write_beacon,
@@ -1105,36 +1128,36 @@ static const struct rt2x00_ops rt2800pci_ops = {
 */
 #ifdef CONFIG_PCI
 static DEFINE_PCI_DEVICE_TABLE(rt2800pci_device_table) = {
-        { PCI_DEVICE(0x1814, 0x0601), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x0601) },
-        { PCI_DEVICE(0x1814, 0x0681), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x0681) },
-        { PCI_DEVICE(0x1814, 0x0701), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x0701) },
-        { PCI_DEVICE(0x1814, 0x0781), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x0781) },
-        { PCI_DEVICE(0x1814, 0x3090), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x3090) },
-        { PCI_DEVICE(0x1814, 0x3091), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x3091) },
-        { PCI_DEVICE(0x1814, 0x3092), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x3092) },
-        { PCI_DEVICE(0x1432, 0x7708), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1432, 0x7708) },
-        { PCI_DEVICE(0x1432, 0x7727), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1432, 0x7727) },
-        { PCI_DEVICE(0x1432, 0x7728), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1432, 0x7728) },
-        { PCI_DEVICE(0x1432, 0x7738), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1432, 0x7738) },
-        { PCI_DEVICE(0x1432, 0x7748), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1432, 0x7748) },
-        { PCI_DEVICE(0x1432, 0x7758), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1432, 0x7758) },
-        { PCI_DEVICE(0x1432, 0x7768), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1432, 0x7768) },
-        { PCI_DEVICE(0x1462, 0x891a), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1462, 0x891a) },
-        { PCI_DEVICE(0x1a3b, 0x1059), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1a3b, 0x1059) },
 #ifdef CONFIG_RT2800PCI_RT33XX
-        { PCI_DEVICE(0x1814, 0x3390), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x3390) },
 #endif
 #ifdef CONFIG_RT2800PCI_RT35XX
-        { PCI_DEVICE(0x1432, 0x7711), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1432, 0x7711) },
-        { PCI_DEVICE(0x1432, 0x7722), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1432, 0x7722) },
-        { PCI_DEVICE(0x1814, 0x3060), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x3060) },
-        { PCI_DEVICE(0x1814, 0x3062), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x3062) },
-        { PCI_DEVICE(0x1814, 0x3562), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x3562) },
-        { PCI_DEVICE(0x1814, 0x3592), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x3592) },
-        { PCI_DEVICE(0x1814, 0x3593), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x3593) },
 #endif
 #ifdef CONFIG_RT2800PCI_RT53XX
-        { PCI_DEVICE(0x1814, 0x5390), PCI_DEVICE_DATA(&rt2800pci_ops) },
+        { PCI_DEVICE(0x1814, 0x5390) },
 #endif
        { 0, }
 };
@@ -1170,10 +1193,16 @@ static struct platform_driver rt2800soc_driver = {
 #endif /* CONFIG_RALINK_RT288X || CONFIG_RALINK_RT305X */
 #ifdef CONFIG_PCI
+static int rt2800pci_probe(struct pci_dev *pci_dev,
+                           const struct pci_device_id *id)
+{
+        return rt2x00pci_probe(pci_dev, &rt2800pci_ops);
+}
 static struct pci_driver rt2800pci_driver = {
        .name           = KBUILD_MODNAME,
        .id_table       = rt2800pci_device_table,
-        .probe          = rt2x00pci_probe,
+        .probe          = rt2800pci_probe,
        .remove         = __devexit_p(rt2x00pci_remove),
        .suspend        = rt2x00pci_suspend,
        .resume         = rt2x00pci_resume,
diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
index 37509d019910..ba82c972703a 100644
--- a/drivers/net/wireless/rt2x00/rt2800usb.c
+++ b/drivers/net/wireless/rt2x00/rt2800usb.c
@@ -59,16 +59,16 @@ static void rt2800usb_start_queue(struct data_queue *queue)
        switch (queue->qid) {
        case QID_RX:
-                rt2800_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
+                rt2x00usb_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
                rt2x00_set_field32(&reg, MAC_SYS_CTRL_ENABLE_RX, 1);
-                rt2800_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
+                rt2x00usb_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
                break;
        case QID_BEACON:
-                rt2800_register_read(rt2x00dev, BCN_TIME_CFG, &reg);
+                rt2x00usb_register_read(rt2x00dev, BCN_TIME_CFG, &reg);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_TSF_TICKING, 1);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_TBTT_ENABLE, 1);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_BEACON_GEN, 1);
-                rt2800_register_write(rt2x00dev, BCN_TIME_CFG, reg);
+                rt2x00usb_register_write(rt2x00dev, BCN_TIME_CFG, reg);
                break;
        default:
                break;
@@ -82,16 +82,16 @@ static void rt2800usb_stop_queue(struct data_queue *queue)
        switch (queue->qid) {
        case QID_RX:
-                rt2800_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
+                rt2x00usb_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
                rt2x00_set_field32(&reg, MAC_SYS_CTRL_ENABLE_RX, 0);
-                rt2800_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
+                rt2x00usb_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
                break;
        case QID_BEACON:
-                rt2800_register_read(rt2x00dev, BCN_TIME_CFG, &reg);
+                rt2x00usb_register_read(rt2x00dev, BCN_TIME_CFG, &reg);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_TSF_TICKING, 0);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_TBTT_ENABLE, 0);
                rt2x00_set_field32(&reg, BCN_TIME_CFG_BEACON_GEN, 0);
-                rt2800_register_write(rt2x00dev, BCN_TIME_CFG, reg);
+                rt2x00usb_register_write(rt2x00dev, BCN_TIME_CFG, reg);
                break;
        default:
                break;
@@ -99,6 +99,63 @@ static void rt2800usb_stop_queue(struct data_queue *queue)
 }
 /*
+ * test if there is an entry in any TX queue for which DMA is done
+ * but the TX status has not been returned yet
+ */
+static bool rt2800usb_txstatus_pending(struct rt2x00_dev *rt2x00dev)
+{
+        struct data_queue *queue;
+        tx_queue_for_each(rt2x00dev, queue) {
+                if (rt2x00queue_get_entry(queue, Q_INDEX_DMA_DONE) !=
+                    rt2x00queue_get_entry(queue, Q_INDEX_DONE))
+                        return true;
+        }
+        return false;
+}
+static bool rt2800usb_tx_sta_fifo_read_completed(struct rt2x00_dev *rt2x00dev,
+                                                 int urb_status, u32 tx_status)
+{
+        if (urb_status) {
+                WARNING(rt2x00dev, "rt2x00usb_register_read_async failed: %d\n", urb_status);
+                return false;
+        }
+        /* try to read all TX_STA_FIFO entries before scheduling txdone_work */
+        if (rt2x00_get_field32(tx_status, TX_STA_FIFO_VALID)) {
+                if (!kfifo_put(&rt2x00dev->txstatus_fifo, &tx_status)) {
+                        WARNING(rt2x00dev, "TX status FIFO overrun, "
+                                "drop tx status report.\n");
+                        queue_work(rt2x00dev->workqueue, &rt2x00dev->txdone_work);
+                } else
+                        return true;
+        } else if (!kfifo_is_empty(&rt2x00dev->txstatus_fifo)) {
+                queue_work(rt2x00dev->workqueue, &rt2x00dev->txdone_work);
+        } else if (rt2800usb_txstatus_pending(rt2x00dev)) {
+                mod_timer(&rt2x00dev->txstatus_timer, jiffies + msecs_to_jiffies(2));
+        }
+        return false;
+}
+static void rt2800usb_tx_dma_done(struct queue_entry *entry)
+{
+        struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
+        rt2x00usb_register_read_async(rt2x00dev, TX_STA_FIFO,
+                                      rt2800usb_tx_sta_fifo_read_completed);
+}
+static void rt2800usb_tx_sta_fifo_timeout(unsigned long data)
+{
+        struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data;
+        rt2x00usb_register_read_async(rt2x00dev, TX_STA_FIFO,
+                                      rt2800usb_tx_sta_fifo_read_completed);
+}
+/*
 * Firmware functions
 */
 static char *rt2800usb_get_firmware_name(struct rt2x00_dev *rt2x00dev)
@@ -129,11 +186,11 @@ static int rt2800usb_write_firmware(struct rt2x00_dev *rt2x00dev,
        /*
         * Write firmware to device.
         */
-        rt2800_register_multiwrite(rt2x00dev, FIRMWARE_IMAGE_BASE,
+        rt2x00usb_register_multiwrite(rt2x00dev, FIRMWARE_IMAGE_BASE,
-                                   data + offset, length);
+                                      data + offset, length);
-        rt2800_register_write(rt2x00dev, H2M_MAILBOX_CID, ~0);
+        rt2x00usb_register_write(rt2x00dev, H2M_MAILBOX_CID, ~0);
-        rt2800_register_write(rt2x00dev, H2M_MAILBOX_STATUS, ~0);
+        rt2x00usb_register_write(rt2x00dev, H2M_MAILBOX_STATUS, ~0);
        /*
         * Send firmware request to device to load firmware,
@@ -148,7 +205,7 @@ static int rt2800usb_write_firmware(struct rt2x00_dev *rt2x00dev,
        }
        msleep(10);
-        rt2800_register_write(rt2x00dev, H2M_MAILBOX_CSR, 0);
+        rt2x00usb_register_write(rt2x00dev, H2M_MAILBOX_CSR, 0);
        return 0;
 }
@@ -166,22 +223,22 @@ static int rt2800usb_init_registers(struct rt2x00_dev *rt2x00dev)
        if (rt2800_wait_csr_ready(rt2x00dev))
                return -EBUSY;
-        rt2800_register_read(rt2x00dev, PBF_SYS_CTRL, &reg);
+        rt2x00usb_register_read(rt2x00dev, PBF_SYS_CTRL, &reg);
-        rt2800_register_write(rt2x00dev, PBF_SYS_CTRL, reg & ~0x00002000);
+        rt2x00usb_register_write(rt2x00dev, PBF_SYS_CTRL, reg & ~0x00002000);
-        rt2800_register_write(rt2x00dev, PWR_PIN_CFG, 0x00000003);
+        rt2x00usb_register_write(rt2x00dev, PWR_PIN_CFG, 0x00000003);
-        rt2800_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
+        rt2x00usb_register_read(rt2x00dev, MAC_SYS_CTRL, &reg);
        rt2x00_set_field32(&reg, MAC_SYS_CTRL_RESET_CSR, 1);
        rt2x00_set_field32(&reg, MAC_SYS_CTRL_RESET_BBP, 1);
-        rt2800_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
+        rt2x00usb_register_write(rt2x00dev, MAC_SYS_CTRL, reg);
-        rt2800_register_write(rt2x00dev, USB_DMA_CFG, 0x00000000);
+        rt2x00usb_register_write(rt2x00dev, USB_DMA_CFG, 0x00000000);
        rt2x00usb_vendor_request_sw(rt2x00dev, USB_DEVICE_MODE, 0,
                                    USB_MODE_RESET, REGISTER_TIMEOUT);
-        rt2800_register_write(rt2x00dev, MAC_SYS_CTRL, 0x00000000);
+        rt2x00usb_register_write(rt2x00dev, MAC_SYS_CTRL, 0x00000000);
        return 0;
 }
@@ -193,7 +250,7 @@ static int rt2800usb_enable_radio(struct rt2x00_dev *rt2x00dev)
        if (unlikely(rt2800_wait_wpdma_ready(rt2x00dev)))
                return -EIO;
-        rt2800_register_read(rt2x00dev, USB_DMA_CFG, &reg);
+        rt2x00usb_register_read(rt2x00dev, USB_DMA_CFG, &reg);
        rt2x00_set_field32(&reg, USB_DMA_CFG_PHY_CLEAR, 0);
        rt2x00_set_field32(&reg, USB_DMA_CFG_RX_BULK_AGG_EN, 0);
        rt2x00_set_field32(&reg, USB_DMA_CFG_RX_BULK_AGG_TIMEOUT, 128);
@@ -206,7 +263,7 @@ static int rt2800usb_enable_radio(struct rt2x00_dev *rt2x00dev)
                            / 1024) - 3);
        rt2x00_set_field32(&reg, USB_DMA_CFG_RX_BULK_EN, 1);
        rt2x00_set_field32(&reg, USB_DMA_CFG_TX_BULK_EN, 1);
-        rt2800_register_write(rt2x00dev, USB_DMA_CFG, reg);
+        rt2x00usb_register_write(rt2x00dev, USB_DMA_CFG, reg);
        return rt2800_enable_radio(rt2x00dev);
 }
@@ -282,12 +339,12 @@ static void rt2800usb_watchdog(struct rt2x00_dev *rt2x00dev)
        unsigned int i;
        u32 reg;
-        rt2800_register_read(rt2x00dev, TXRXQ_PCNT, &reg);
+        rt2x00usb_register_read(rt2x00dev, TXRXQ_PCNT, &reg);
        if (rt2x00_get_field32(reg, TXRXQ_PCNT_TX0Q)) {
                WARNING(rt2x00dev, "TX HW queue 0 timed out,"
                        " invoke forced kick\n");
-                rt2800_register_write(rt2x00dev, PBF_CFG, 0xf40012);
+                rt2x00usb_register_write(rt2x00dev, PBF_CFG, 0xf40012);
                for (i = 0; i < 10; i++) {
                        udelay(10);
@@ -295,15 +352,15 @@ static void rt2800usb_watchdog(struct rt2x00_dev *rt2x00dev)
                                break;
                }
-                rt2800_register_write(rt2x00dev, PBF_CFG, 0xf40006);
+                rt2x00usb_register_write(rt2x00dev, PBF_CFG, 0xf40006);
        }
-        rt2800_register_read(rt2x00dev, TXRXQ_PCNT, &reg);
+        rt2x00usb_register_read(rt2x00dev, TXRXQ_PCNT, &reg);
        if (rt2x00_get_field32(reg, TXRXQ_PCNT_TX1Q)) {
                WARNING(rt2x00dev, "TX HW queue 1 timed out,"
                        " invoke forced kick\n");
-                rt2800_register_write(rt2x00dev, PBF_CFG, 0xf4000a);
+                rt2x00usb_register_write(rt2x00dev, PBF_CFG, 0xf4000a);
                for (i = 0; i < 10; i++) {
                        udelay(10);
@@ -311,7 +368,7 @@ static void rt2800usb_watchdog(struct rt2x00_dev *rt2x00dev)
                                break;
                }
-                rt2800_register_write(rt2x00dev, PBF_CFG, 0xf40006);
+                rt2x00usb_register_write(rt2x00dev, PBF_CFG, 0xf40006);
        }
        rt2x00usb_watchdog(rt2x00dev);
@@ -420,13 +477,24 @@ static void rt2800usb_work_txdone(struct work_struct *work)
                while (!rt2x00queue_empty(queue)) {
                        entry = rt2x00queue_get_entry(queue, Q_INDEX_DONE);
-                        if (test_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags) ||
+                        if (test_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
-                            !test_bit(ENTRY_DATA_IO_FAILED, &entry->flags))
+                                break;
+                        if (test_bit(ENTRY_DATA_IO_FAILED, &entry->flags))
+                                rt2x00lib_txdone_noinfo(entry, TXDONE_FAILURE);
+                        else if (rt2x00queue_status_timeout(entry))
+                                rt2x00lib_txdone_noinfo(entry, TXDONE_UNKNOWN);
+                        else
                                break;
-                        rt2x00lib_txdone_noinfo(entry, TXDONE_FAILURE);
                }
        }
+        /*
+         * The hw may delay sending the packet after DMA complete
+         * if the medium is busy, thus the TX_STA_FIFO entry is
+         * also delayed -> use a timer to retrieve it.
+         */
+        if (rt2800usb_txstatus_pending(rt2x00dev))
+                mod_timer(&rt2x00dev->txstatus_timer, jiffies + msecs_to_jiffies(2));
 }
 /*
@@ -553,19 +621,24 @@ static int rt2800usb_probe_hw(struct rt2x00_dev *rt2x00dev)
         * This device has multiple filters for control frames
         * and has a separate filter for PS Poll frames.
         */
-        __set_bit(DRIVER_SUPPORT_CONTROL_FILTERS, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_CONTROL_FILTERS, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_SUPPORT_CONTROL_FILTER_PSPOLL, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_CONTROL_FILTER_PSPOLL, &rt2x00dev->cap_flags);
        /*
         * This device requires firmware.
         */
-        __set_bit(DRIVER_REQUIRE_FIRMWARE, &rt2x00dev->flags);
+        __set_bit(REQUIRE_FIRMWARE, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_L2PAD, &rt2x00dev->flags);
+        __set_bit(REQUIRE_L2PAD, &rt2x00dev->cap_flags);
        if (!modparam_nohwcrypt)
-                __set_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_SUPPORT_LINK_TUNING, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_LINK_TUNING, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_SUPPORT_WATCHDOG, &rt2x00dev->flags);
+        __set_bit(REQUIRE_HT_TX_DESC, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_HT_TX_DESC, &rt2x00dev->flags);
+        __set_bit(REQUIRE_TXSTATUS_FIFO, &rt2x00dev->cap_flags);
+        __set_bit(REQUIRE_PS_AUTOWAKE, &rt2x00dev->cap_flags);
+        setup_timer(&rt2x00dev->txstatus_timer,
+                    rt2800usb_tx_sta_fifo_timeout,
+                    (unsigned long) rt2x00dev);
        /*
         * Set the rssi offset.
@@ -602,6 +675,7 @@ static const struct ieee80211_ops rt2800usb_mac80211_ops = {
        .ampdu_action           = rt2800_ampdu_action,
        .flush                  = rt2x00mac_flush,
        .get_survey             = rt2800_get_survey,
+        .get_ringparam          = rt2x00mac_get_ringparam,
 };
 static const struct rt2800_ops rt2800usb_rt2800_ops = {
@@ -630,11 +704,13 @@ static const struct rt2x00lib_ops rt2800usb_rt2x00_ops = {
        .link_stats             = rt2800_link_stats,
        .reset_tuner            = rt2800_reset_tuner,
        .link_tuner             = rt2800_link_tuner,
+        .gain_calibration       = rt2800_gain_calibration,
        .watchdog               = rt2800usb_watchdog,
        .start_queue            = rt2800usb_start_queue,
        .kick_queue             = rt2x00usb_kick_queue,
        .stop_queue             = rt2800usb_stop_queue,
        .flush_queue            = rt2x00usb_flush_queue,
+        .tx_dma_done            = rt2800usb_tx_dma_done,
        .write_tx_desc          = rt2800usb_write_tx_desc,
        .write_tx_data          = rt2800usb_write_tx_data,
        .write_beacon           = rt2800_write_beacon,
@@ -695,294 +771,340 @@ static const struct rt2x00_ops rt2800usb_ops = {
 */
 static struct usb_device_id rt2800usb_device_table[] = {
        /* Abocom */
-        { USB_DEVICE(0x07b8, 0x2870), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07b8, 0x2870) },
-        { USB_DEVICE(0x07b8, 0x2770), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07b8, 0x2770) },
-        { USB_DEVICE(0x07b8, 0x3070), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07b8, 0x3070) },
-        { USB_DEVICE(0x07b8, 0x3071), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07b8, 0x3071) },
-        { USB_DEVICE(0x07b8, 0x3072), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07b8, 0x3072) },
-        { USB_DEVICE(0x1482, 0x3c09), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1482, 0x3c09) },
        /* AirTies */
-        { USB_DEVICE(0x1eda, 0x2310), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1eda, 0x2012) },
+        { USB_DEVICE(0x1eda, 0x2310) },
        /* Allwin */
-        { USB_DEVICE(0x8516, 0x2070), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x8516, 0x2070) },
-        { USB_DEVICE(0x8516, 0x2770), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x8516, 0x2770) },
-        { USB_DEVICE(0x8516, 0x2870), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x8516, 0x2870) },
-        { USB_DEVICE(0x8516, 0x3070), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x8516, 0x3070) },
-        { USB_DEVICE(0x8516, 0x3071), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x8516, 0x3071) },
-        { USB_DEVICE(0x8516, 0x3072), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x8516, 0x3072) },
+        /* Alpha Networks */
+        { USB_DEVICE(0x14b2, 0x3c06) },
+        { USB_DEVICE(0x14b2, 0x3c07) },
+        { USB_DEVICE(0x14b2, 0x3c09) },
+        { USB_DEVICE(0x14b2, 0x3c12) },
+        { USB_DEVICE(0x14b2, 0x3c23) },
+        { USB_DEVICE(0x14b2, 0x3c25) },
+        { USB_DEVICE(0x14b2, 0x3c27) },
+        { USB_DEVICE(0x14b2, 0x3c28) },
+        { USB_DEVICE(0x14b2, 0x3c2c) },
        /* Amit */
-        { USB_DEVICE(0x15c5, 0x0008), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x15c5, 0x0008) },
        /* Askey */
-        { USB_DEVICE(0x1690, 0x0740), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1690, 0x0740) },
        /* ASUS */
-        { USB_DEVICE(0x0b05, 0x1731), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0b05, 0x1731) },
-        { USB_DEVICE(0x0b05, 0x1732), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0b05, 0x1732) },
-        { USB_DEVICE(0x0b05, 0x1742), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0b05, 0x1742) },
-        { USB_DEVICE(0x0b05, 0x1784), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0b05, 0x1784) },
-        { USB_DEVICE(0x1761, 0x0b05), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1761, 0x0b05) },
        /* AzureWave */
-        { USB_DEVICE(0x13d3, 0x3247), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x13d3, 0x3247) },
-        { USB_DEVICE(0x13d3, 0x3273), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x13d3, 0x3273) },
-        { USB_DEVICE(0x13d3, 0x3305), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x13d3, 0x3305) },
-        { USB_DEVICE(0x13d3, 0x3307), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x13d3, 0x3307) },
-        { USB_DEVICE(0x13d3, 0x3321), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x13d3, 0x3321) },
        /* Belkin */
-        { USB_DEVICE(0x050d, 0x8053), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x050d, 0x8053) },
-        { USB_DEVICE(0x050d, 0x805c), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x050d, 0x805c) },
-        { USB_DEVICE(0x050d, 0x815c), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x050d, 0x815c) },
-        { USB_DEVICE(0x050d, 0x825b), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x050d, 0x825b) },
-        { USB_DEVICE(0x050d, 0x935a), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x050d, 0x935a) },
-        { USB_DEVICE(0x050d, 0x935b), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x050d, 0x935b) },
        /* Buffalo */
-        { USB_DEVICE(0x0411, 0x00e8), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0411, 0x00e8) },
-        { USB_DEVICE(0x0411, 0x016f), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0411, 0x016f) },
-        /* Conceptronic */
+        { USB_DEVICE(0x0411, 0x01a2) },
-        { USB_DEVICE(0x14b2, 0x3c06), USB_DEVICE_DATA(&rt2800usb_ops) },
-        { USB_DEVICE(0x14b2, 0x3c07), USB_DEVICE_DATA(&rt2800usb_ops) },
-        { USB_DEVICE(0x14b2, 0x3c09), USB_DEVICE_DATA(&rt2800usb_ops) },
-        { USB_DEVICE(0x14b2, 0x3c12), USB_DEVICE_DATA(&rt2800usb_ops) },
-        { USB_DEVICE(0x14b2, 0x3c23), USB_DEVICE_DATA(&rt2800usb_ops) },
-        { USB_DEVICE(0x14b2, 0x3c25), USB_DEVICE_DATA(&rt2800usb_ops) },
-        { USB_DEVICE(0x14b2, 0x3c27), USB_DEVICE_DATA(&rt2800usb_ops) },
-        { USB_DEVICE(0x14b2, 0x3c28), USB_DEVICE_DATA(&rt2800usb_ops) },
        /* Corega */
-        { USB_DEVICE(0x07aa, 0x002f), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07aa, 0x002f) },
-        { USB_DEVICE(0x07aa, 0x003c), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07aa, 0x003c) },
-        { USB_DEVICE(0x07aa, 0x003f), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07aa, 0x003f) },
-        { USB_DEVICE(0x18c5, 0x0012), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x18c5, 0x0012) },
        /* D-Link */
-        { USB_DEVICE(0x07d1, 0x3c09), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c09) },
-        { USB_DEVICE(0x07d1, 0x3c0a), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c0a) },
-        { USB_DEVICE(0x07d1, 0x3c0d), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c0d) },
-        { USB_DEVICE(0x07d1, 0x3c0e), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c0e) },
-        { USB_DEVICE(0x07d1, 0x3c0f), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c0f) },
-        { USB_DEVICE(0x07d1, 0x3c11), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c11) },
-        { USB_DEVICE(0x07d1, 0x3c16), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c16) },
        /* Draytek */
-        { USB_DEVICE(0x07fa, 0x7712), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07fa, 0x7712) },
        /* Edimax */
-        { USB_DEVICE(0x7392, 0x7711), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x7392, 0x7711) },
-        { USB_DEVICE(0x7392, 0x7717), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x7392, 0x7717) },
-        { USB_DEVICE(0x7392, 0x7718), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x7392, 0x7718) },
        /* Encore */
-        { USB_DEVICE(0x203d, 0x1480), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x203d, 0x1480) },
-        { USB_DEVICE(0x203d, 0x14a9), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x203d, 0x14a9) },
        /* EnGenius */
-        { USB_DEVICE(0x1740, 0x9701), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x9701) },
-        { USB_DEVICE(0x1740, 0x9702), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x9702) },
-        { USB_DEVICE(0x1740, 0x9703), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x9703) },
-        { USB_DEVICE(0x1740, 0x9705), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x9705) },
-        { USB_DEVICE(0x1740, 0x9706), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x9706) },
-        { USB_DEVICE(0x1740, 0x9707), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x9707) },
-        { USB_DEVICE(0x1740, 0x9708), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x9708) },
-        { USB_DEVICE(0x1740, 0x9709), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x9709) },
+        /* Gemtek */
+        { USB_DEVICE(0x15a9, 0x0012) },
        /* Gigabyte */
-        { USB_DEVICE(0x1044, 0x800b), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1044, 0x800b) },
-        { USB_DEVICE(0x1044, 0x800d), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1044, 0x800d) },
        /* Hawking */
-        { USB_DEVICE(0x0e66, 0x0001), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0e66, 0x0001) },
-        { USB_DEVICE(0x0e66, 0x0003), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0e66, 0x0003) },
-        { USB_DEVICE(0x0e66, 0x0009), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0e66, 0x0009) },
-        { USB_DEVICE(0x0e66, 0x000b), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0e66, 0x000b) },
-        { USB_DEVICE(0x0e66, 0x0013), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0e66, 0x0013) },
-        { USB_DEVICE(0x0e66, 0x0017), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0e66, 0x0017) },
-        { USB_DEVICE(0x0e66, 0x0018), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0e66, 0x0018) },
        /* I-O DATA */
-        { USB_DEVICE(0x04bb, 0x0945), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x04bb, 0x0945) },
-        { USB_DEVICE(0x04bb, 0x0947), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x04bb, 0x0947) },
-        { USB_DEVICE(0x04bb, 0x0948), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x04bb, 0x0948) },
        /* Linksys */
-        { USB_DEVICE(0x1737, 0x0070), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x13b1, 0x0031) },
-        { USB_DEVICE(0x1737, 0x0071), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1737, 0x0070) },
+        { USB_DEVICE(0x1737, 0x0071) },
        /* Logitec */
-        { USB_DEVICE(0x0789, 0x0162), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0789, 0x0162) },
-        { USB_DEVICE(0x0789, 0x0163), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0789, 0x0163) },
-        { USB_DEVICE(0x0789, 0x0164), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0789, 0x0164) },
-        { USB_DEVICE(0x0789, 0x0166), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0789, 0x0166) },
        /* Motorola */
-        { USB_DEVICE(0x100d, 0x9031), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x100d, 0x9031) },
        /* MSI */
-        { USB_DEVICE(0x0db0, 0x3820), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x3820) },
-        { USB_DEVICE(0x0db0, 0x3821), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x3821) },
-        { USB_DEVICE(0x0db0, 0x3822), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x3822) },
-        { USB_DEVICE(0x0db0, 0x3870), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x3870) },
-        { USB_DEVICE(0x0db0, 0x3871), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x3871) },
-        { USB_DEVICE(0x0db0, 0x6899), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x6899) },
-        { USB_DEVICE(0x0db0, 0x821a), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x821a) },
-        { USB_DEVICE(0x0db0, 0x822a), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x822a) },
-        { USB_DEVICE(0x0db0, 0x822b), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x822b) },
-        { USB_DEVICE(0x0db0, 0x822c), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x822c) },
-        { USB_DEVICE(0x0db0, 0x870a), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x870a) },
-        { USB_DEVICE(0x0db0, 0x871a), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x871a) },
-        { USB_DEVICE(0x0db0, 0x871b), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x871b) },
-        { USB_DEVICE(0x0db0, 0x871c), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x871c) },
-        { USB_DEVICE(0x0db0, 0x899a), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0db0, 0x899a) },
        /* Para */
-        { USB_DEVICE(0x20b8, 0x8888), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x20b8, 0x8888) },
        /* Pegatron */
-        { USB_DEVICE(0x1d4d, 0x000c), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1d4d, 0x000c) },
-        { USB_DEVICE(0x1d4d, 0x000e), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1d4d, 0x000e) },
-        { USB_DEVICE(0x1d4d, 0x0011), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1d4d, 0x0011) },
        /* Philips */
-        { USB_DEVICE(0x0471, 0x200f), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0471, 0x200f) },
        /* Planex */
-        { USB_DEVICE(0x2019, 0xab25), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x2019, 0xab25) },
-        { USB_DEVICE(0x2019, 0xed06), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x2019, 0xed06) },
        /* Quanta */
-        { USB_DEVICE(0x1a32, 0x0304), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1a32, 0x0304) },
        /* Ralink */
-        { USB_DEVICE(0x148f, 0x2070), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x148f, 0x2070) },
-        { USB_DEVICE(0x148f, 0x2770), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x148f, 0x2770) },
-        { USB_DEVICE(0x148f, 0x2870), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x148f, 0x2870) },
-        { USB_DEVICE(0x148f, 0x3070), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x148f, 0x3070) },
-        { USB_DEVICE(0x148f, 0x3071), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x148f, 0x3071) },
-        { USB_DEVICE(0x148f, 0x3072), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x148f, 0x3072) },
        /* Samsung */
-        { USB_DEVICE(0x04e8, 0x2018), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x04e8, 0x2018) },
        /* Siemens */
-        { USB_DEVICE(0x129b, 0x1828), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x129b, 0x1828) },
        /* Sitecom */
-        { USB_DEVICE(0x0df6, 0x0017), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x0017) },
-        { USB_DEVICE(0x0df6, 0x002b), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x002b) },
-        { USB_DEVICE(0x0df6, 0x002c), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x002c) },
-        { USB_DEVICE(0x0df6, 0x002d), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x002d) },
-        { USB_DEVICE(0x0df6, 0x0039), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x0039) },
-        { USB_DEVICE(0x0df6, 0x003b), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x003b) },
-        { USB_DEVICE(0x0df6, 0x003d), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x003d) },
-        { USB_DEVICE(0x0df6, 0x003e), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x003e) },
-        { USB_DEVICE(0x0df6, 0x003f), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x003f) },
-        { USB_DEVICE(0x0df6, 0x0040), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x0040) },
-        { USB_DEVICE(0x0df6, 0x0042), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x0042) },
-        { USB_DEVICE(0x0df6, 0x0047), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x0047) },
-        { USB_DEVICE(0x0df6, 0x0048), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x0048) },
+        { USB_DEVICE(0x0df6, 0x0051) },
+        { USB_DEVICE(0x0df6, 0x005f) },
        /* SMC */
-        { USB_DEVICE(0x083a, 0x6618), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0x6618) },
-        { USB_DEVICE(0x083a, 0x7511), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0x7511) },
-        { USB_DEVICE(0x083a, 0x7512), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0x7512) },
-        { USB_DEVICE(0x083a, 0x7522), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0x7522) },
-        { USB_DEVICE(0x083a, 0x8522), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0x8522) },
-        { USB_DEVICE(0x083a, 0xa618), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0xa618) },
-        { USB_DEVICE(0x083a, 0xa701), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0xa701) },
-        { USB_DEVICE(0x083a, 0xa702), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0xa702) },
-        { USB_DEVICE(0x083a, 0xa703), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0xa703) },
-        { USB_DEVICE(0x083a, 0xb522), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0xb522) },
        /* Sparklan */
-        { USB_DEVICE(0x15a9, 0x0006), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x15a9, 0x0006) },
        /* Sweex */
-        { USB_DEVICE(0x177f, 0x0302), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x177f, 0x0302) },
-        /* U-Media*/
+        /* U-Media */
-        { USB_DEVICE(0x157e, 0x300e), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x157e, 0x300e) },
+        { USB_DEVICE(0x157e, 0x3013) },
        /* ZCOM */
-        { USB_DEVICE(0x0cde, 0x0022), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0cde, 0x0022) },
-        { USB_DEVICE(0x0cde, 0x0025), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0cde, 0x0025) },
        /* Zinwell */
-        { USB_DEVICE(0x5a57, 0x0280), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x5a57, 0x0280) },
-        { USB_DEVICE(0x5a57, 0x0282), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x5a57, 0x0282) },
-        { USB_DEVICE(0x5a57, 0x0283), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x5a57, 0x0283) },
-        { USB_DEVICE(0x5a57, 0x5257), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x5a57, 0x5257) },
        /* Zyxel */
-        { USB_DEVICE(0x0586, 0x3416), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0586, 0x3416) },
+        { USB_DEVICE(0x0586, 0x3418) },
+        { USB_DEVICE(0x0586, 0x341e) },
+        { USB_DEVICE(0x0586, 0x343e) },
 #ifdef CONFIG_RT2800USB_RT33XX
        /* Ralink */
-        { USB_DEVICE(0x148f, 0x3370), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x148f, 0x3370) },
-        { USB_DEVICE(0x148f, 0x8070), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x148f, 0x8070) },
        /* Sitecom */
-        { USB_DEVICE(0x0df6, 0x0050), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x0050) },
 #endif
 #ifdef CONFIG_RT2800USB_RT35XX
        /* Allwin */
-        { USB_DEVICE(0x8516, 0x3572), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x8516, 0x3572) },
        /* Askey */
-        { USB_DEVICE(0x1690, 0x0744), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1690, 0x0744) },
        /* Cisco */
-        { USB_DEVICE(0x167b, 0x4001), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x167b, 0x4001) },
        /* EnGenius */
-        { USB_DEVICE(0x1740, 0x9801), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x9801) },
        /* I-O DATA */
-        { USB_DEVICE(0x04bb, 0x0944), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x04bb, 0x0944) },
+        /* Linksys */
+        { USB_DEVICE(0x13b1, 0x002f) },
+        { USB_DEVICE(0x1737, 0x0079) },
        /* Ralink */
-        { USB_DEVICE(0x148f, 0x3572), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x148f, 0x3572) },
        /* Sitecom */
-        { USB_DEVICE(0x0df6, 0x0041), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0df6, 0x0041) },
        /* Toshiba */
-        { USB_DEVICE(0x0930, 0x0a07), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0930, 0x0a07) },
        /* Zinwell */
-        { USB_DEVICE(0x5a57, 0x0284), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x5a57, 0x0284) },
+#endif
+#ifdef CONFIG_RT2800USB_RT53XX
+        /* Azurewave */
+        { USB_DEVICE(0x13d3, 0x3329) },
+        { USB_DEVICE(0x13d3, 0x3365) },
+        /* Ralink */
+        { USB_DEVICE(0x148f, 0x5370) },
+        { USB_DEVICE(0x148f, 0x5372) },
 #endif
 #ifdef CONFIG_RT2800USB_UNKNOWN
        /*
         * Unclear what kind of devices these are (they aren't supported by the
         * vendor linux driver).
         */
+        /* Abocom */
+        { USB_DEVICE(0x07b8, 0x3073) },
+        { USB_DEVICE(0x07b8, 0x3074) },
+        /* Alpha Networks */
+        { USB_DEVICE(0x14b2, 0x3c08) },
+        { USB_DEVICE(0x14b2, 0x3c11) },
        /* Amigo */
-        { USB_DEVICE(0x0e0b, 0x9031), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0e0b, 0x9031) },
-        { USB_DEVICE(0x0e0b, 0x9041), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0e0b, 0x9041) },
        /* ASUS */
-        { USB_DEVICE(0x0b05, 0x1760), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0b05, 0x166a) },
-        { USB_DEVICE(0x0b05, 0x1761), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0b05, 0x1760) },
-        { USB_DEVICE(0x0b05, 0x1790), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0b05, 0x1761) },
+        { USB_DEVICE(0x0b05, 0x1790) },
+        { USB_DEVICE(0x0b05, 0x179d) },
        /* AzureWave */
-        { USB_DEVICE(0x13d3, 0x3262), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x13d3, 0x3262) },
-        { USB_DEVICE(0x13d3, 0x3284), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x13d3, 0x3284) },
-        { USB_DEVICE(0x13d3, 0x3322), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x13d3, 0x3322) },
        /* Belkin */
-        { USB_DEVICE(0x050d, 0x825a), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x050d, 0x1003) },
+        { USB_DEVICE(0x050d, 0x825a) },
        /* Buffalo */
-        { USB_DEVICE(0x0411, 0x012e), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0411, 0x012e) },
-        { USB_DEVICE(0x0411, 0x0148), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0411, 0x0148) },
-        { USB_DEVICE(0x0411, 0x0150), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0411, 0x0150) },
-        { USB_DEVICE(0x0411, 0x015d), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0411, 0x015d) },
-        /* Conceptronic */
-        { USB_DEVICE(0x14b2, 0x3c08), USB_DEVICE_DATA(&rt2800usb_ops) },
-        { USB_DEVICE(0x14b2, 0x3c11), USB_DEVICE_DATA(&rt2800usb_ops) },
        /* Corega */
-        { USB_DEVICE(0x07aa, 0x0041), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07aa, 0x0041) },
-        { USB_DEVICE(0x07aa, 0x0042), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07aa, 0x0042) },
-        { USB_DEVICE(0x18c5, 0x0008), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x18c5, 0x0008) },
        /* D-Link */
-        { USB_DEVICE(0x07d1, 0x3c0b), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c0b) },
-        { USB_DEVICE(0x07d1, 0x3c13), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c13) },
-        { USB_DEVICE(0x07d1, 0x3c15), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c15) },
-        { USB_DEVICE(0x07d1, 0x3c17), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c17) },
+        { USB_DEVICE(0x2001, 0x3c17) },
        /* Edimax */
-        { USB_DEVICE(0x7392, 0x4085), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x7392, 0x4085) },
+        { USB_DEVICE(0x7392, 0x7722) },
        /* Encore */
-        { USB_DEVICE(0x203d, 0x14a1), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x203d, 0x14a1) },
        /* Gemtek */
-        { USB_DEVICE(0x15a9, 0x0010), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x15a9, 0x0010) },
        /* Gigabyte */
-        { USB_DEVICE(0x1044, 0x800c), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1044, 0x800c) },
+        /* Huawei */
+        { USB_DEVICE(0x148f, 0xf101) },
+        /* I-O DATA */
+        { USB_DEVICE(0x04bb, 0x094b) },
        /* LevelOne */
-        { USB_DEVICE(0x1740, 0x0605), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x0605) },
-        { USB_DEVICE(0x1740, 0x0615), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1740, 0x0615) },
        /* Linksys */
-        { USB_DEVICE(0x1737, 0x0077), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1737, 0x0077) },
-        { USB_DEVICE(0x1737, 0x0078), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1737, 0x0078) },
-        { USB_DEVICE(0x1737, 0x0079), USB_DEVICE_DATA(&rt2800usb_ops) },
+        /* Logitec */
+        { USB_DEVICE(0x0789, 0x0168) },
+        { USB_DEVICE(0x0789, 0x0169) },
        /* Motorola */
-        { USB_DEVICE(0x100d, 0x9032), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x100d, 0x9032) },
        /* Ovislink */
-        { USB_DEVICE(0x1b75, 0x3071), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1b75, 0x3071) },
-        { USB_DEVICE(0x1b75, 0x3072), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1b75, 0x3072) },
        /* Pegatron */
-        { USB_DEVICE(0x05a6, 0x0101), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x05a6, 0x0101) },
-        { USB_DEVICE(0x1d4d, 0x0002), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1d4d, 0x0002) },
-        { USB_DEVICE(0x1d4d, 0x0010), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x1d4d, 0x0010) },
        /* Planex */
-        { USB_DEVICE(0x2019, 0x5201), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x2019, 0x5201) },
-        { USB_DEVICE(0x2019, 0xab24), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x2019, 0xab24) },
        /* Qcom */
-        { USB_DEVICE(0x18e8, 0x6259), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x18e8, 0x6259) },
+        /* RadioShack */
+        { USB_DEVICE(0x08b9, 0x1197) },
+        /* Sitecom */
+        { USB_DEVICE(0x0df6, 0x003c) },
+        { USB_DEVICE(0x0df6, 0x004a) },
+        { USB_DEVICE(0x0df6, 0x004d) },
+        { USB_DEVICE(0x0df6, 0x0053) },
+        { USB_DEVICE(0x0df6, 0x0060) },
+        { USB_DEVICE(0x0df6, 0x0062) },
        /* SMC */
-        { USB_DEVICE(0x083a, 0xa512), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0xa512) },
-        { USB_DEVICE(0x083a, 0xc522), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0xc522) },
-        { USB_DEVICE(0x083a, 0xd522), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0xd522) },
-        { USB_DEVICE(0x083a, 0xf511), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x083a, 0xf511) },
        /* Sweex */
-        { USB_DEVICE(0x177f, 0x0153), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x177f, 0x0153) },
-        { USB_DEVICE(0x177f, 0x0313), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x177f, 0x0313) },
        /* Zyxel */
-        { USB_DEVICE(0x0586, 0x341a), USB_DEVICE_DATA(&rt2800usb_ops) },
+        { USB_DEVICE(0x0586, 0x341a) },
 #endif
        { 0, }
 };
@@ -995,10 +1117,16 @@ MODULE_DEVICE_TABLE(usb, rt2800usb_device_table);
 MODULE_FIRMWARE(FIRMWARE_RT2870);
 MODULE_LICENSE("GPL");
+static int rt2800usb_probe(struct usb_interface *usb_intf,
+                           const struct usb_device_id *id)
+{
+        return rt2x00usb_probe(usb_intf, &rt2800usb_ops);
+}
 static struct usb_driver rt2800usb_driver = {
        .name           = KBUILD_MODNAME,
        .id_table       = rt2800usb_device_table,
-        .probe          = rt2x00usb_probe,
+        .probe          = rt2800usb_probe,
        .disconnect     = rt2x00usb_disconnect,
        .suspend        = rt2x00usb_suspend,
        .resume         = rt2x00usb_resume,
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
index 7f10239f56a8..c446db69bd3c 100644
--- a/drivers/net/wireless/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/rt2x00/rt2x00.h
@@ -37,6 +37,7 @@
 #include <linux/etherdevice.h>
 #include <linux/input-polldev.h>
 #include <linux/kfifo.h>
+#include <linux/timer.h>
 #include <net/mac80211.h>
@@ -348,6 +349,11 @@ struct link {
         * to bring the device/driver back into the desired state.
         */
        struct delayed_work watchdog_work;
+        /*
+         * Work structure for scheduling periodic AGC adjustments.
+         */
+        struct delayed_work agc_work;
 };
 enum rt2x00_delayed_flags {
@@ -556,6 +562,7 @@ struct rt2x00lib_ops {
                             struct link_qual *qual);
        void (*link_tuner) (struct rt2x00_dev *rt2x00dev,
                            struct link_qual *qual, const u32 count);
+        void (*gain_calibration) (struct rt2x00_dev *rt2x00dev);
        /*
         * Data queue handlers.
@@ -564,7 +571,8 @@ struct rt2x00lib_ops {
        void (*start_queue) (struct data_queue *queue);
        void (*kick_queue) (struct data_queue *queue);
        void (*stop_queue) (struct data_queue *queue);
-        void (*flush_queue) (struct data_queue *queue);
+        void (*flush_queue) (struct data_queue *queue, bool drop);
+        void (*tx_dma_done) (struct queue_entry *entry);
        /*
         * TX control handlers
@@ -637,11 +645,11 @@ struct rt2x00_ops {
 };
 /*
- * rt2x00 device flags
+ * rt2x00 state flags
 */
-enum rt2x00_flags {
+enum rt2x00_state_flags {
        /*
-         * Device state flags
+         * Device flags
         */
        DEVICE_STATE_PRESENT,
        DEVICE_STATE_REGISTERED_HW,
@@ -651,40 +659,47 @@ enum rt2x00_flags {
        DEVICE_STATE_SCANNING,
        /*
-         * Driver requirements
-         */
-        DRIVER_REQUIRE_FIRMWARE,
-        DRIVER_REQUIRE_BEACON_GUARD,
-        DRIVER_REQUIRE_ATIM_QUEUE,
-        DRIVER_REQUIRE_DMA,
-        DRIVER_REQUIRE_COPY_IV,
-        DRIVER_REQUIRE_L2PAD,
-        DRIVER_REQUIRE_TXSTATUS_FIFO,
-        DRIVER_REQUIRE_TASKLET_CONTEXT,
-        DRIVER_REQUIRE_SW_SEQNO,
-        DRIVER_REQUIRE_HT_TX_DESC,
-        /*
-         * Driver features
-         */
-        CONFIG_SUPPORT_HW_BUTTON,
-        CONFIG_SUPPORT_HW_CRYPTO,
-        CONFIG_SUPPORT_POWER_LIMIT,
-        DRIVER_SUPPORT_CONTROL_FILTERS,
-        DRIVER_SUPPORT_CONTROL_FILTER_PSPOLL,
-        DRIVER_SUPPORT_PRE_TBTT_INTERRUPT,
-        DRIVER_SUPPORT_LINK_TUNING,
-        DRIVER_SUPPORT_WATCHDOG,
-        /*
         * Driver configuration
         */
-        CONFIG_FRAME_TYPE,
-        CONFIG_RF_SEQUENCE,
-        CONFIG_EXTERNAL_LNA_A,
-        CONFIG_EXTERNAL_LNA_BG,
-        CONFIG_DOUBLE_ANTENNA,
        CONFIG_CHANNEL_HT40,
+        CONFIG_POWERSAVING,
+};
+/*
+ * rt2x00 capability flags
+ */
+enum rt2x00_capability_flags {
+        /*
+         * Requirements
+         */
+        REQUIRE_FIRMWARE,
+        REQUIRE_BEACON_GUARD,
+        REQUIRE_ATIM_QUEUE,
+        REQUIRE_DMA,
+        REQUIRE_COPY_IV,
+        REQUIRE_L2PAD,
+        REQUIRE_TXSTATUS_FIFO,
+        REQUIRE_TASKLET_CONTEXT,
+        REQUIRE_SW_SEQNO,
+        REQUIRE_HT_TX_DESC,
+        REQUIRE_PS_AUTOWAKE,
+        /*
+         * Capabilities
+         */
+        CAPABILITY_HW_BUTTON,
+        CAPABILITY_HW_CRYPTO,
+        CAPABILITY_POWER_LIMIT,
+        CAPABILITY_CONTROL_FILTERS,
+        CAPABILITY_CONTROL_FILTER_PSPOLL,
+        CAPABILITY_PRE_TBTT_INTERRUPT,
+        CAPABILITY_LINK_TUNING,
+        CAPABILITY_FRAME_TYPE,
+        CAPABILITY_RF_SEQUENCE,
+        CAPABILITY_EXTERNAL_LNA_A,
+        CAPABILITY_EXTERNAL_LNA_BG,
+        CAPABILITY_DOUBLE_ANTENNA,
+        CAPABILITY_BT_COEXIST,
 };
 /*
@@ -733,13 +748,20 @@ struct rt2x00_dev {
 #endif /* CONFIG_RT2X00_LIB_LEDS */
        /*
-         * Device flags.
+         * Device state flags.
-         * In these flags the current status and some
+         * In these flags the current status is stored.
-         * of the device capabilities are stored.
+         * Access to these flags should occur atomically.
         */
        unsigned long flags;
        /*
+         * Device capabiltiy flags.
+         * In these flags the device/driver capabilities are stored.
+         * Access to these flags should occur non-atomically.
+         */
+        unsigned long cap_flags;
+        /*
         * Device information, Bus IRQ and name (PCI, SoC)
         */
        int irq;
@@ -855,10 +877,20 @@ struct rt2x00_dev {
        u8 calibration[2];
        /*
+         * Association id.
+         */
+        u16 aid;
+        /*
         * Beacon interval.
         */
        u16 beacon_int;
+        /**
+         * Timestamp of last received beacon
+         */
+        unsigned long last_beacon;
        /*
         * Low level statistics which will have
         * to be kept up to date while device is running.
@@ -887,6 +919,11 @@ struct rt2x00_dev {
        struct work_struct txdone_work;
        /*
+         * Powersaving work
+         */
+        struct delayed_work autowakeup_work;
+        /*
         * Data queue arrays for RX, TX, Beacon and ATIM.
         */
        unsigned int data_queues;
@@ -906,6 +943,11 @@ struct rt2x00_dev {
        DECLARE_KFIFO_PTR(txstatus_fifo, u32);
        /*
+         * Timer to ensure tx status reports are read (rt2800usb).
+         */
+        struct timer_list txstatus_timer;
+        /*
         * Tasklet for processing tx status reports (rt2800pci).
         */
        struct tasklet_struct txstatus_tasklet;
@@ -1230,6 +1272,10 @@ int rt2x00mac_conf_tx(struct ieee80211_hw *hw, u16 queue,
                      const struct ieee80211_tx_queue_params *params);
 void rt2x00mac_rfkill_poll(struct ieee80211_hw *hw);
 void rt2x00mac_flush(struct ieee80211_hw *hw, bool drop);
+int rt2x00mac_set_antenna(struct ieee80211_hw *hw, u32 tx_ant, u32 rx_ant);
+int rt2x00mac_get_antenna(struct ieee80211_hw *hw, u32 *tx_ant, u32 *rx_ant);
+void rt2x00mac_get_ringparam(struct ieee80211_hw *hw,
+                             u32 *tx, u32 *tx_max, u32 *rx, u32 *rx_max);
 /*
 * Driver allocation handlers.
diff --git a/drivers/net/wireless/rt2x00/rt2x00config.c b/drivers/net/wireless/rt2x00/rt2x00config.c
index 9416e36de29e..555180d8f4aa 100644
--- a/drivers/net/wireless/rt2x00/rt2x00config.c
+++ b/drivers/net/wireless/rt2x00/rt2x00config.c
@@ -100,6 +100,10 @@ void rt2x00lib_config_erp(struct rt2x00_dev *rt2x00dev,
        erp.basic_rates = bss_conf->basic_rates;
        erp.beacon_int = bss_conf->beacon_int;
+        /* Update the AID, this is needed for dynamic PS support */
+        rt2x00dev->aid = bss_conf->assoc ? bss_conf->aid : 0;
+        rt2x00dev->last_beacon = bss_conf->timestamp;
        /* Update global beacon interval time, this is needed for PS support */
        rt2x00dev->beacon_int = bss_conf->beacon_int;
@@ -109,15 +113,6 @@ void rt2x00lib_config_erp(struct rt2x00_dev *rt2x00dev,
        rt2x00dev->ops->lib->config_erp(rt2x00dev, &erp, changed);
 }
-static inline
-enum antenna rt2x00lib_config_antenna_check(enum antenna current_ant,
-                                            enum antenna default_ant)
-{
-        if (current_ant != ANTENNA_SW_DIVERSITY)
-                return current_ant;
-        return (default_ant != ANTENNA_SW_DIVERSITY) ? default_ant : ANTENNA_B;
-}
 void rt2x00lib_config_antenna(struct rt2x00_dev *rt2x00dev,
                              struct antenna_setup config)
 {
@@ -126,19 +121,35 @@ void rt2x00lib_config_antenna(struct rt2x00_dev *rt2x00dev,
        struct antenna_setup *active = &rt2x00dev->link.ant.active;
        /*
-         * Failsafe: Make sure we are not sending the
+         * When the caller tries to send the SW diversity,
-         * ANTENNA_SW_DIVERSITY state to the driver.
+         * we must update the ANTENNA_RX_DIVERSITY flag to
-         * If that happens, fallback to hardware defaults,
+         * enable the antenna diversity in the link tuner.
-         * or our own default.
+         *
+         * Secondly, we must guarentee we never send the
+         * software antenna diversity command to the driver.
         */
-        if (!(ant->flags & ANTENNA_RX_DIVERSITY))
+        if (!(ant->flags & ANTENNA_RX_DIVERSITY)) {
-                config.rx = rt2x00lib_config_antenna_check(config.rx, def->rx);
+                if (config.rx == ANTENNA_SW_DIVERSITY) {
-        else if (config.rx == ANTENNA_SW_DIVERSITY)
+                        ant->flags |= ANTENNA_RX_DIVERSITY;
+                        if (def->rx == ANTENNA_SW_DIVERSITY)
+                                config.rx = ANTENNA_B;
+                        else
+                                config.rx = def->rx;
+                }
+        } else if (config.rx == ANTENNA_SW_DIVERSITY)
                config.rx = active->rx;
-        if (!(ant->flags & ANTENNA_TX_DIVERSITY))
+        if (!(ant->flags & ANTENNA_TX_DIVERSITY)) {
-                config.tx = rt2x00lib_config_antenna_check(config.tx, def->tx);
+                if (config.tx == ANTENNA_SW_DIVERSITY) {
-        else if (config.tx == ANTENNA_SW_DIVERSITY)
+                        ant->flags |= ANTENNA_TX_DIVERSITY;
+                        if (def->tx == ANTENNA_SW_DIVERSITY)
+                                config.tx = ANTENNA_B;
+                        else
+                                config.tx = def->tx;
+                }
+        } else if (config.tx == ANTENNA_SW_DIVERSITY)
                config.tx = active->tx;
        /*
@@ -163,12 +174,43 @@ void rt2x00lib_config_antenna(struct rt2x00_dev *rt2x00dev,
                rt2x00queue_start_queue(rt2x00dev->rx);
 }
+static u16 rt2x00ht_center_channel(struct rt2x00_dev *rt2x00dev,
+                                   struct ieee80211_conf *conf)
+{
+        struct hw_mode_spec *spec = &rt2x00dev->spec;
+        int center_channel;
+        u16 i;
+        /*
+         * Initialize center channel to current channel.
+         */
+        center_channel = spec->channels[conf->channel->hw_value].channel;
+        /*
+         * Adjust center channel to HT40+ and HT40- operation.
+         */
+        if (conf_is_ht40_plus(conf))
+                center_channel += 2;
+        else if (conf_is_ht40_minus(conf))
+                center_channel -= (center_channel == 14) ? 1 : 2;
+        for (i = 0; i < spec->num_channels; i++)
+                if (spec->channels[i].channel == center_channel)
+                        return i;
+        WARN_ON(1);
+        return conf->channel->hw_value;
+}
 void rt2x00lib_config(struct rt2x00_dev *rt2x00dev,
                      struct ieee80211_conf *conf,
                      unsigned int ieee80211_flags)
 {
        struct rt2x00lib_conf libconf;
        u16 hw_value;
+        u16 autowake_timeout;
+        u16 beacon_int;
+        u16 beacon_diff;
        memset(&libconf, 0, sizeof(libconf));
@@ -176,10 +218,10 @@ void rt2x00lib_config(struct rt2x00_dev *rt2x00dev,
        if (ieee80211_flags & IEEE80211_CONF_CHANGE_CHANNEL) {
                if (conf_is_ht40(conf)) {
-                        __set_bit(CONFIG_CHANNEL_HT40, &rt2x00dev->flags);
+                        set_bit(CONFIG_CHANNEL_HT40, &rt2x00dev->flags);
                        hw_value = rt2x00ht_center_channel(rt2x00dev, conf);
                } else {
-                        __clear_bit(CONFIG_CHANNEL_HT40, &rt2x00dev->flags);
+                        clear_bit(CONFIG_CHANNEL_HT40, &rt2x00dev->flags);
                        hw_value = conf->channel->hw_value;
                }
@@ -192,6 +234,10 @@ void rt2x00lib_config(struct rt2x00_dev *rt2x00dev,
                       sizeof(libconf.channel));
        }
+        if (test_bit(REQUIRE_PS_AUTOWAKE, &rt2x00dev->cap_flags) &&
+            (ieee80211_flags & IEEE80211_CONF_CHANGE_PS))
+                cancel_delayed_work_sync(&rt2x00dev->autowakeup_work);
        /*
         * Start configuration.
         */
@@ -204,6 +250,26 @@ void rt2x00lib_config(struct rt2x00_dev *rt2x00dev,
        if (ieee80211_flags & IEEE80211_CONF_CHANGE_CHANNEL)
                rt2x00link_reset_tuner(rt2x00dev, false);
+        if (test_bit(REQUIRE_PS_AUTOWAKE, &rt2x00dev->cap_flags) &&
+            (ieee80211_flags & IEEE80211_CONF_CHANGE_PS) &&
+            (conf->flags & IEEE80211_CONF_PS)) {
+                beacon_diff = (long)jiffies - (long)rt2x00dev->last_beacon;
+                beacon_int = msecs_to_jiffies(rt2x00dev->beacon_int);
+                if (beacon_diff > beacon_int)
+                        beacon_diff = 0;
+                autowake_timeout = (conf->max_sleep_period * beacon_int) - beacon_diff;
+                queue_delayed_work(rt2x00dev->workqueue,
+                                   &rt2x00dev->autowakeup_work,
+                                   autowake_timeout - 15);
+        }
+        if (conf->flags & IEEE80211_CONF_PS)
+                set_bit(CONFIG_POWERSAVING, &rt2x00dev->flags);
+        else
+                clear_bit(CONFIG_POWERSAVING, &rt2x00dev->flags);
        rt2x00dev->curr_band = conf->channel->band;
        rt2x00dev->curr_freq = conf->channel->center_freq;
        rt2x00dev->tx_power = conf->power_level;
diff --git a/drivers/net/wireless/rt2x00/rt2x00crypto.c b/drivers/net/wireless/rt2x00/rt2x00crypto.c
index 3f5688fbf3f7..1bb9d46077ff 100644
--- a/drivers/net/wireless/rt2x00/rt2x00crypto.c
+++ b/drivers/net/wireless/rt2x00/rt2x00crypto.c
@@ -52,7 +52,7 @@ void rt2x00crypto_create_tx_descriptor(struct queue_entry *entry,
        struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(entry->skb);
        struct ieee80211_key_conf *hw_key = tx_info->control.hw_key;
-        if (!test_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags) || !hw_key)
+        if (!test_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags) || !hw_key)
                return;
        __set_bit(ENTRY_TXD_ENCRYPT, &txdesc->flags);
@@ -80,7 +80,7 @@ unsigned int rt2x00crypto_tx_overhead(struct rt2x00_dev *rt2x00dev,
        struct ieee80211_key_conf *key = tx_info->control.hw_key;
        unsigned int overhead = 0;
-        if (!test_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags) || !key)
+        if (!test_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags) || !key)
                return overhead;
        /*
diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
index c92db3264741..78787fcc919e 100644
--- a/drivers/net/wireless/rt2x00/rt2x00debug.c
+++ b/drivers/net/wireless/rt2x00/rt2x00debug.c
@@ -63,7 +63,8 @@ struct rt2x00debug_intf {
         * - driver folder
         *   - driver file
         *   - chipset file
-         *   - device flags file
+         *   - device state flags file
+         *   - device capability flags file
         *   - register folder
         *     - csr offset/value files
         *     - eeprom offset/value files
@@ -78,6 +79,7 @@ struct rt2x00debug_intf {
        struct dentry *driver_entry;
        struct dentry *chipset_entry;
        struct dentry *dev_flags;
+        struct dentry *cap_flags;
        struct dentry *register_folder;
        struct dentry *csr_off_entry;
        struct dentry *csr_val_entry;
@@ -553,6 +555,35 @@ static const struct file_operations rt2x00debug_fop_dev_flags = {
        .llseek         = default_llseek,
 };
+static ssize_t rt2x00debug_read_cap_flags(struct file *file,
+                                          char __user *buf,
+                                          size_t length,
+                                          loff_t *offset)
+{
+        struct rt2x00debug_intf *intf = file->private_data;
+        char line[16];
+        size_t size;
+        if (*offset)
+                return 0;
+        size = sprintf(line, "0x%.8x\n", (unsigned int)intf->rt2x00dev->cap_flags);
+        if (copy_to_user(buf, line, size))
+                return -EFAULT;
+        *offset += size;
+        return size;
+}
+static const struct file_operations rt2x00debug_fop_cap_flags = {
+        .owner          = THIS_MODULE,
+        .read           = rt2x00debug_read_cap_flags,
+        .open           = rt2x00debug_file_open,
+        .release        = rt2x00debug_file_release,
+        .llseek         = default_llseek,
+};
 static struct dentry *rt2x00debug_create_file_driver(const char *name,
                                                     struct rt2x00debug_intf
                                                     *intf,
@@ -568,7 +599,6 @@ static struct dentry *rt2x00debug_create_file_driver(const char *name,
        blob->data = data;
        data += sprintf(data, "driver:\t%s\n", intf->rt2x00dev->ops->name);
        data += sprintf(data, "version:\t%s\n", DRV_VERSION);
-        data += sprintf(data, "compiled:\t%s %s\n", __DATE__, __TIME__);
        blob->size = strlen(blob->data);
        return debugfs_create_blob(name, S_IRUSR, intf->driver_folder, blob);
@@ -653,6 +683,12 @@ void rt2x00debug_register(struct rt2x00_dev *rt2x00dev)
        if (IS_ERR(intf->dev_flags) || !intf->dev_flags)
                goto exit;
+        intf->cap_flags = debugfs_create_file("cap_flags", S_IRUSR,
+                                              intf->driver_folder, intf,
+                                              &rt2x00debug_fop_cap_flags);
+        if (IS_ERR(intf->cap_flags) || !intf->cap_flags)
+                goto exit;
        intf->register_folder =
            debugfs_create_dir("register", intf->driver_folder);
        if (IS_ERR(intf->register_folder) || !intf->register_folder)
@@ -706,7 +742,7 @@ void rt2x00debug_register(struct rt2x00_dev *rt2x00dev)
                                intf, &rt2x00debug_fop_queue_stats);
 #ifdef CONFIG_RT2X00_LIB_CRYPTO
-        if (test_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags))
+        if (test_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags))
                intf->crypto_stats_entry =
                    debugfs_create_file("crypto", S_IRUGO, intf->queue_folder,
                                        intf, &rt2x00debug_fop_crypto_stats);
@@ -744,6 +780,7 @@ void rt2x00debug_deregister(struct rt2x00_dev *rt2x00dev)
        debugfs_remove(intf->csr_off_entry);
        debugfs_remove(intf->register_folder);
        debugfs_remove(intf->dev_flags);
+        debugfs_remove(intf->cap_flags);
        debugfs_remove(intf->chipset_entry);
        debugfs_remove(intf->driver_entry);
        debugfs_remove(intf->driver_folder);
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 84eb6ad36377..c018d67aab8e 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -27,6 +27,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/slab.h>
+#include <linux/log2.h>
 #include "rt2x00.h"
 #include "rt2x00lib.h"
@@ -70,6 +71,7 @@ int rt2x00lib_enable_radio(struct rt2x00_dev *rt2x00dev)
         */
        rt2x00queue_start_queues(rt2x00dev);
        rt2x00link_start_tuner(rt2x00dev);
+        rt2x00link_start_agc(rt2x00dev);
        /*
         * Start watchdog monitoring.
@@ -92,6 +94,7 @@ void rt2x00lib_disable_radio(struct rt2x00_dev *rt2x00dev)
        /*
         * Stop all queues
         */
+        rt2x00link_stop_agc(rt2x00dev);
        rt2x00link_stop_tuner(rt2x00dev);
        rt2x00queue_stop_queues(rt2x00dev);
        rt2x00queue_flush_queues(rt2x00dev, true);
@@ -138,6 +141,16 @@ static void rt2x00lib_intf_scheduled(struct work_struct *work)
                                            rt2x00dev);
 }
+static void rt2x00lib_autowakeup(struct work_struct *work)
+{
+        struct rt2x00_dev *rt2x00dev =
+            container_of(work, struct rt2x00_dev, autowakeup_work.work);
+        if (rt2x00dev->ops->lib->set_device_state(rt2x00dev, STATE_AWAKE))
+                ERROR(rt2x00dev, "Device failed to wakeup.\n");
+        clear_bit(CONFIG_POWERSAVING, &rt2x00dev->flags);
+}
 /*
 * Interrupt context handlers.
 */
@@ -197,7 +210,7 @@ void rt2x00lib_beacondone(struct rt2x00_dev *rt2x00dev)
         * here as they will fetch the next beacon directly prior to
         * transmission.
         */
-        if (test_bit(DRIVER_SUPPORT_PRE_TBTT_INTERRUPT, &rt2x00dev->flags))
+        if (test_bit(CAPABILITY_PRE_TBTT_INTERRUPT, &rt2x00dev->cap_flags))
                return;
        /* fetch next beacon */
@@ -222,7 +235,7 @@ EXPORT_SYMBOL_GPL(rt2x00lib_pretbtt);
 void rt2x00lib_dmastart(struct queue_entry *entry)
 {
        set_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags);
-        rt2x00queue_index_inc(entry->queue, Q_INDEX);
+        rt2x00queue_index_inc(entry, Q_INDEX);
 }
 EXPORT_SYMBOL_GPL(rt2x00lib_dmastart);
@@ -230,7 +243,7 @@ void rt2x00lib_dmadone(struct queue_entry *entry)
 {
        set_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags);
        clear_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags);
-        rt2x00queue_index_inc(entry->queue, Q_INDEX_DMA_DONE);
+        rt2x00queue_index_inc(entry, Q_INDEX_DMA_DONE);
 }
 EXPORT_SYMBOL_GPL(rt2x00lib_dmadone);
@@ -268,7 +281,7 @@ void rt2x00lib_txdone(struct queue_entry *entry,
        /*
         * Remove L2 padding which was added during
         */
-        if (test_bit(DRIVER_REQUIRE_L2PAD, &rt2x00dev->flags))
+        if (test_bit(REQUIRE_L2PAD, &rt2x00dev->cap_flags))
                rt2x00queue_remove_l2pad(entry->skb, header_length);
        /*
@@ -277,7 +290,7 @@ void rt2x00lib_txdone(struct queue_entry *entry,
         * mac80211 will expect the same data to be present it the
         * frame as it was passed to us.
         */
-        if (test_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags))
+        if (test_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags))
                rt2x00crypto_tx_insert_iv(entry->skb, header_length);
        /*
@@ -350,10 +363,14 @@ void rt2x00lib_txdone(struct queue_entry *entry,
         * which would allow the rc algorithm to better decide on
         * which rates are suitable.
         */
-        if (tx_info->flags & IEEE80211_TX_CTL_AMPDU) {
+        if (test_bit(TXDONE_AMPDU, &txdesc->flags) ||
+            tx_info->flags & IEEE80211_TX_CTL_AMPDU) {
                tx_info->flags |= IEEE80211_TX_STAT_AMPDU;
                tx_info->status.ampdu_len = 1;
                tx_info->status.ampdu_ack_len = success ? 1 : 0;
+                if (!success)
+                        tx_info->flags |= IEEE80211_TX_STAT_AMPDU_NO_BACK;
        }
        if (rate_flags & IEEE80211_TX_RC_USE_RTS_CTS) {
@@ -370,7 +387,7 @@ void rt2x00lib_txdone(struct queue_entry *entry,
         * send the status report back.
         */
        if (!(skbdesc_flags & SKBDESC_NOT_MAC80211)) {
-                if (test_bit(DRIVER_REQUIRE_TASKLET_CONTEXT, &rt2x00dev->flags))
+                if (test_bit(REQUIRE_TASKLET_CONTEXT, &rt2x00dev->cap_flags))
                        ieee80211_tx_status(rt2x00dev->hw, entry->skb);
                else
                        ieee80211_tx_status_ni(rt2x00dev->hw, entry->skb);
@@ -385,7 +402,7 @@ void rt2x00lib_txdone(struct queue_entry *entry,
        rt2x00dev->ops->lib->clear_entry(entry);
-        rt2x00queue_index_inc(entry->queue, Q_INDEX_DONE);
+        rt2x00queue_index_inc(entry, Q_INDEX_DONE);
        /*
         * If the data queue was below the threshold before the txdone
@@ -409,6 +426,77 @@ void rt2x00lib_txdone_noinfo(struct queue_entry *entry, u32 status)
 }
 EXPORT_SYMBOL_GPL(rt2x00lib_txdone_noinfo);
+static u8 *rt2x00lib_find_ie(u8 *data, unsigned int len, u8 ie)
+{
+        struct ieee80211_mgmt *mgmt = (void *)data;
+        u8 *pos, *end;
+        pos = (u8 *)mgmt->u.beacon.variable;
+        end = data + len;
+        while (pos < end) {
+                if (pos + 2 + pos[1] > end)
+                        return NULL;
+                if (pos[0] == ie)
+                        return pos;
+                pos += 2 + pos[1];
+        }
+        return NULL;
+}
+static void rt2x00lib_rxdone_check_ps(struct rt2x00_dev *rt2x00dev,
+                                      struct sk_buff *skb,
+                                      struct rxdone_entry_desc *rxdesc)
+{
+        struct ieee80211_hdr *hdr = (void *) skb->data;
+        struct ieee80211_tim_ie *tim_ie;
+        u8 *tim;
+        u8 tim_len;
+        bool cam;
+        /* If this is not a beacon, or if mac80211 has no powersaving
+         * configured, or if the device is already in powersaving mode
+         * we can exit now. */
+        if (likely(!ieee80211_is_beacon(hdr->frame_control) ||
+                   !(rt2x00dev->hw->conf.flags & IEEE80211_CONF_PS)))
+                return;
+        /* min. beacon length + FCS_LEN */
+        if (skb->len <= 40 + FCS_LEN)
+                return;
+        /* and only beacons from the associated BSSID, please */
+        if (!(rxdesc->dev_flags & RXDONE_MY_BSS) ||
+            !rt2x00dev->aid)
+                return;
+        rt2x00dev->last_beacon = jiffies;
+        tim = rt2x00lib_find_ie(skb->data, skb->len - FCS_LEN, WLAN_EID_TIM);
+        if (!tim)
+                return;
+        if (tim[1] < sizeof(*tim_ie))
+                return;
+        tim_len = tim[1];
+        tim_ie = (struct ieee80211_tim_ie *) &tim[2];
+        /* Check whenever the PHY can be turned off again. */
+        /* 1. What about buffered unicast traffic for our AID? */
+        cam = ieee80211_check_tim(tim_ie, tim_len, rt2x00dev->aid);
+        /* 2. Maybe the AP wants to send multicast/broadcast data? */
+        cam |= (tim_ie->bitmap_ctrl & 0x01);
+        if (!cam && !test_bit(CONFIG_POWERSAVING, &rt2x00dev->flags))
+                rt2x00lib_config(rt2x00dev, &rt2x00dev->hw->conf,
+                                 IEEE80211_CONF_CHANGE_PS);
+}
 static int rt2x00lib_rxdone_read_signal(struct rt2x00_dev *rt2x00dev,
                                        struct rxdone_entry_desc *rxdesc)
 {
@@ -511,8 +599,6 @@ void rt2x00lib_rxdone(struct queue_entry *entry)
                 (rxdesc.size > header_length) &&
                 (rxdesc.dev_flags & RXDONE_L2PAD))
                rt2x00queue_remove_l2pad(entry->skb, header_length);
-        else
-                rt2x00queue_align_payload(entry->skb, header_length);
        /* Trim buffer to correct size */
        skb_trim(entry->skb, rxdesc.size);
@@ -526,6 +612,12 @@ void rt2x00lib_rxdone(struct queue_entry *entry)
                rxdesc.flags |= RX_FLAG_HT;
        /*
+         * Check if this is a beacon, and more frames have been
+         * buffered while we were in powersaving mode.
+         */
+        rt2x00lib_rxdone_check_ps(rt2x00dev, entry->skb, &rxdesc);
+        /*
         * Update extra components
         */
        rt2x00link_update_stats(rt2x00dev, entry->skb, &rxdesc);
@@ -554,7 +646,7 @@ void rt2x00lib_rxdone(struct queue_entry *entry)
 submit_entry:
        entry->flags = 0;
-        rt2x00queue_index_inc(entry->queue, Q_INDEX_DONE);
+        rt2x00queue_index_inc(entry, Q_INDEX_DONE);
        if (test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags) &&
            test_bit(DEVICE_STATE_ENABLED_RADIO, &rt2x00dev->flags))
                rt2x00dev->ops->lib->clear_entry(entry);
@@ -801,23 +893,28 @@ static int rt2x00lib_probe_hw(struct rt2x00_dev *rt2x00dev)
        /*
         * Take TX headroom required for alignment into account.
         */
-        if (test_bit(DRIVER_REQUIRE_L2PAD, &rt2x00dev->flags))
+        if (test_bit(REQUIRE_L2PAD, &rt2x00dev->cap_flags))
                rt2x00dev->hw->extra_tx_headroom += RT2X00_L2PAD_SIZE;
-        else if (test_bit(DRIVER_REQUIRE_DMA, &rt2x00dev->flags))
+        else if (test_bit(REQUIRE_DMA, &rt2x00dev->cap_flags))
                rt2x00dev->hw->extra_tx_headroom += RT2X00_ALIGN_SIZE;
        /*
         * Allocate tx status FIFO for driver use.
         */
-        if (test_bit(DRIVER_REQUIRE_TXSTATUS_FIFO, &rt2x00dev->flags)) {
+        if (test_bit(REQUIRE_TXSTATUS_FIFO, &rt2x00dev->cap_flags)) {
                /*
-                 * Allocate txstatus fifo and tasklet, we use a size of 512
+                 * Allocate the txstatus fifo. In the worst case the tx
-                 * for the kfifo which is big enough to store 512/4=128 tx
+                 * status fifo has to hold the tx status of all entries
-                 * status reports. In the worst case (tx status for all tx
+                 * in all tx queues. Hence, calculate the kfifo size as
-                 * queues gets reported before we've got a chance to handle
+                 * tx_queues * entry_num and round up to the nearest
-                 * them) 24*4=384 tx status reports need to be cached.
+                 * power of 2.
                 */
-                status = kfifo_alloc(&rt2x00dev->txstatus_fifo, 512,
+                int kfifo_size =
+                        roundup_pow_of_two(rt2x00dev->ops->tx_queues *
+                                           rt2x00dev->ops->tx->entry_num *
+                                           sizeof(u32));
+                status = kfifo_alloc(&rt2x00dev->txstatus_fifo, kfifo_size,
                                     GFP_KERNEL);
                if (status)
                        return status;
@@ -1007,6 +1104,7 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
        }
        INIT_WORK(&rt2x00dev->intf_work, rt2x00lib_intf_scheduled);
+        INIT_DELAYED_WORK(&rt2x00dev->autowakeup_work, rt2x00lib_autowakeup);
        /*
         * Let the driver probe the device to detect the capabilities.
@@ -1063,6 +1161,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
         */
        cancel_work_sync(&rt2x00dev->intf_work);
        if (rt2x00_is_usb(rt2x00dev)) {
+                del_timer_sync(&rt2x00dev->txstatus_timer);
                cancel_work_sync(&rt2x00dev->rxdone_work);
                cancel_work_sync(&rt2x00dev->txdone_work);
        }
diff --git a/drivers/net/wireless/rt2x00/rt2x00firmware.c b/drivers/net/wireless/rt2x00/rt2x00firmware.c
index be0ff78c1b16..f316aad30612 100644
--- a/drivers/net/wireless/rt2x00/rt2x00firmware.c
+++ b/drivers/net/wireless/rt2x00/rt2x00firmware.c
@@ -99,7 +99,7 @@ int rt2x00lib_load_firmware(struct rt2x00_dev *rt2x00dev)
 {
        int retval;
-        if (!test_bit(DRIVER_REQUIRE_FIRMWARE, &rt2x00dev->flags))
+        if (!test_bit(REQUIRE_FIRMWARE, &rt2x00dev->cap_flags))
                return 0;
        if (!rt2x00dev->fw) {
diff --git a/drivers/net/wireless/rt2x00/rt2x00ht.c b/drivers/net/wireless/rt2x00/rt2x00ht.c
deleted file mode 100644
index ae1219dffaae..000000000000
--- a/drivers/net/wireless/rt2x00/rt2x00ht.c
+++ /dev/null
@@ -1,133 +0,0 @@
-/*
-        Copyright (C) 2004 - 2009 Ivo van Doorn <IvDoorn@gmail.com>
-        <http://rt2x00.serialmonkey.com>
-        This program is free software; you can redistribute it and/or modify
-        it under the terms of the GNU General Public License as published by
-        the Free Software Foundation; either version 2 of the License, or
-        (at your option) any later version.
-        This program is distributed in the hope that it will be useful,
-        but WITHOUT ANY WARRANTY; without even the implied warranty of
-        MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-        GNU General Public License for more details.
-        You should have received a copy of the GNU General Public License
-        along with this program; if not, write to the
-        Free Software Foundation, Inc.,
-        59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
- */
-/*
-        Module: rt2x00lib
-        Abstract: rt2x00 HT specific routines.
- */
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include "rt2x00.h"
-#include "rt2x00lib.h"
-void rt2x00ht_create_tx_descriptor(struct queue_entry *entry,
-                                   struct txentry_desc *txdesc,
-                                   const struct rt2x00_rate *hwrate)
-{
-        struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(entry->skb);
-        struct ieee80211_tx_rate *txrate = &tx_info->control.rates[0];
-        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)entry->skb->data;
-        if (tx_info->control.sta)
-                txdesc->u.ht.mpdu_density =
-                    tx_info->control.sta->ht_cap.ampdu_density;
-        txdesc->u.ht.ba_size = 7;       /* FIXME: What value is needed? */
-        txdesc->u.ht.stbc =
-            (tx_info->flags & IEEE80211_TX_CTL_STBC) >> IEEE80211_TX_CTL_STBC_SHIFT;
-        /*
-         * If IEEE80211_TX_RC_MCS is set txrate->idx just contains the
-         * mcs rate to be used
-         */
-        if (txrate->flags & IEEE80211_TX_RC_MCS) {
-                txdesc->u.ht.mcs = txrate->idx;
-                /*
-                 * MIMO PS should be set to 1 for STA's using dynamic SM PS
-                 * when using more then one tx stream (>MCS7).
-                 */
-                if (tx_info->control.sta && txdesc->u.ht.mcs > 7 &&
-                    ((tx_info->control.sta->ht_cap.cap &
-                      IEEE80211_HT_CAP_SM_PS) >>
-                     IEEE80211_HT_CAP_SM_PS_SHIFT) ==
-                    WLAN_HT_CAP_SM_PS_DYNAMIC)
-                        __set_bit(ENTRY_TXD_HT_MIMO_PS, &txdesc->flags);
-        } else {
-                txdesc->u.ht.mcs = rt2x00_get_rate_mcs(hwrate->mcs);
-                if (txrate->flags & IEEE80211_TX_RC_USE_SHORT_PREAMBLE)
-                        txdesc->u.ht.mcs |= 0x08;
-        }
-        /*
-         * This frame is eligible for an AMPDU, however, don't aggregate
-         * frames that are intended to probe a specific tx rate.
-         */
-        if (tx_info->flags & IEEE80211_TX_CTL_AMPDU &&
-            !(tx_info->flags & IEEE80211_TX_CTL_RATE_CTRL_PROBE))
-                __set_bit(ENTRY_TXD_HT_AMPDU, &txdesc->flags);
-        /*
-         * Set 40Mhz mode if necessary (for legacy rates this will
-         * duplicate the frame to both channels).
-         */
-        if (txrate->flags & IEEE80211_TX_RC_40_MHZ_WIDTH ||
-            txrate->flags & IEEE80211_TX_RC_DUP_DATA)
-                __set_bit(ENTRY_TXD_HT_BW_40, &txdesc->flags);
-        if (txrate->flags & IEEE80211_TX_RC_SHORT_GI)
-                __set_bit(ENTRY_TXD_HT_SHORT_GI, &txdesc->flags);
-        /*
-         * Determine IFS values
-         * - Use TXOP_BACKOFF for management frames
-         * - Use TXOP_SIFS for fragment bursts
-         * - Use TXOP_HTTXOP for everything else
-         *
-         * Note: rt2800 devices won't use CTS protection (if used)
-         * for frames not transmitted with TXOP_HTTXOP
-         */
-        if (ieee80211_is_mgmt(hdr->frame_control))
-                txdesc->u.ht.txop = TXOP_BACKOFF;
-        else if (!(tx_info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT))
-                txdesc->u.ht.txop = TXOP_SIFS;
-        else
-                txdesc->u.ht.txop = TXOP_HTTXOP;
-}
-u16 rt2x00ht_center_channel(struct rt2x00_dev *rt2x00dev,
-                            struct ieee80211_conf *conf)
-{
-        struct hw_mode_spec *spec = &rt2x00dev->spec;
-        int center_channel;
-        u16 i;
-        /*
-         * Initialize center channel to current channel.
-         */
-        center_channel = spec->channels[conf->channel->hw_value].channel;
-        /*
-         * Adjust center channel to HT40+ and HT40- operation.
-         */
-        if (conf_is_ht40_plus(conf))
-                center_channel += 2;
-        else if (conf_is_ht40_minus(conf))
-                center_channel -= (center_channel == 14) ? 1 : 2;
-        for (i = 0; i < spec->num_channels; i++)
-                if (spec->channels[i].channel == center_channel)
-                        return i;
-        WARN_ON(1);
-        return conf->channel->hw_value;
-}
diff --git a/drivers/net/wireless/rt2x00/rt2x00lib.h b/drivers/net/wireless/rt2x00/rt2x00lib.h
index 2d94cbaf5f4a..322cc4f3de5d 100644
--- a/drivers/net/wireless/rt2x00/rt2x00lib.h
+++ b/drivers/net/wireless/rt2x00/rt2x00lib.h
@@ -32,6 +32,7 @@
 */
 #define WATCHDOG_INTERVAL       round_jiffies_relative(HZ)
 #define LINK_TUNE_INTERVAL      round_jiffies_relative(HZ)
+#define AGC_INTERVAL            round_jiffies_relative(4 * HZ)
 /*
 * rt2x00_rate: Per rate device information
@@ -119,16 +120,6 @@ void rt2x00queue_free_skb(struct queue_entry *entry);
 void rt2x00queue_align_frame(struct sk_buff *skb);
 /**
- * rt2x00queue_align_payload - Align 802.11 payload to 4-byte boundary
- * @skb: The skb to align
- * @header_length: Length of 802.11 header
- *
- * Align the 802.11 payload to a 4-byte boundary, this could
- * mean the header is not aligned properly though.
- */
-void rt2x00queue_align_payload(struct sk_buff *skb, unsigned int header_length);
-/**
 * rt2x00queue_insert_l2pad - Align 802.11 header & payload to 4-byte boundary
 * @skb: The skb to align
 * @header_length: Length of 802.11 header
@@ -184,14 +175,14 @@ int rt2x00queue_clear_beacon(struct rt2x00_dev *rt2x00dev,
 /**
 * rt2x00queue_index_inc - Index incrementation function
- * @queue: Queue (&struct data_queue) to perform the action on.
+ * @entry: Queue entry (&struct queue_entry) to perform the action on.
 * @index: Index type (&enum queue_index) to perform the action on.
 *
- * This function will increase the requested index on the queue,
+ * This function will increase the requested index on the entry's queue,
 * it will grab the appropriate locks and handle queue overflow events by
 * resetting the index to the start of the queue.
 */
-void rt2x00queue_index_inc(struct data_queue *queue, enum queue_index index);
+void rt2x00queue_index_inc(struct queue_entry *entry, enum queue_index index);
 /**
 * rt2x00queue_init_queues - Initialize all data queues
@@ -281,6 +272,18 @@ void rt2x00link_start_watchdog(struct rt2x00_dev *rt2x00dev);
 void rt2x00link_stop_watchdog(struct rt2x00_dev *rt2x00dev);
 /**
+ * rt2x00link_start_agc - Start periodic gain calibration
+ * @rt2x00dev: Pointer to &struct rt2x00_dev.
+ */
+void rt2x00link_start_agc(struct rt2x00_dev *rt2x00dev);
+/**
+ * rt2x00link_stop_agc - Stop periodic gain calibration
+ * @rt2x00dev: Pointer to &struct rt2x00_dev.
+ */
+void rt2x00link_stop_agc(struct rt2x00_dev *rt2x00dev);
+/**
 * rt2x00link_register - Initialize link tuning & watchdog functionality
 * @rt2x00dev: Pointer to &struct rt2x00_dev.
 *
@@ -385,41 +388,17 @@ static inline void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
 #endif /* CONFIG_RT2X00_LIB_CRYPTO */
 /*
- * HT handlers.
- */
-#ifdef CONFIG_RT2X00_LIB_HT
-void rt2x00ht_create_tx_descriptor(struct queue_entry *entry,
-                                   struct txentry_desc *txdesc,
-                                   const struct rt2x00_rate *hwrate);
-u16 rt2x00ht_center_channel(struct rt2x00_dev *rt2x00dev,
-                            struct ieee80211_conf *conf);
-#else
-static inline void rt2x00ht_create_tx_descriptor(struct queue_entry *entry,
-                                                 struct txentry_desc *txdesc,
-                                                 const struct rt2x00_rate *hwrate)
-{
-}
-static inline u16 rt2x00ht_center_channel(struct rt2x00_dev *rt2x00dev,
-                                          struct ieee80211_conf *conf)
-{
-        return conf->channel->hw_value;
-}
-#endif /* CONFIG_RT2X00_LIB_HT */
-/*
 * RFkill handlers.
 */
 static inline void rt2x00rfkill_register(struct rt2x00_dev *rt2x00dev)
 {
-        if (test_bit(CONFIG_SUPPORT_HW_BUTTON, &rt2x00dev->flags))
+        if (test_bit(CAPABILITY_HW_BUTTON, &rt2x00dev->cap_flags))
                wiphy_rfkill_start_polling(rt2x00dev->hw->wiphy);
 }
 static inline void rt2x00rfkill_unregister(struct rt2x00_dev *rt2x00dev)
 {
-        if (test_bit(CONFIG_SUPPORT_HW_BUTTON, &rt2x00dev->flags))
+        if (test_bit(CAPABILITY_HW_BUTTON, &rt2x00dev->cap_flags))
                wiphy_rfkill_stop_polling(rt2x00dev->hw->wiphy);
 }
diff --git a/drivers/net/wireless/rt2x00/rt2x00link.c b/drivers/net/wireless/rt2x00/rt2x00link.c
index 29abfdeb0b65..ea10b0068f82 100644
--- a/drivers/net/wireless/rt2x00/rt2x00link.c
+++ b/drivers/net/wireless/rt2x00/rt2x00link.c
@@ -192,17 +192,7 @@ static bool rt2x00lib_antenna_diversity(struct rt2x00_dev *rt2x00dev)
        /*
         * Determine if software diversity is enabled for
         * either the TX or RX antenna (or both).
-         * Always perform this check since within the link
-         * tuner interval the configuration might have changed.
         */
-        ant->flags &= ~ANTENNA_RX_DIVERSITY;
-        ant->flags &= ~ANTENNA_TX_DIVERSITY;
-        if (rt2x00dev->default_ant.rx == ANTENNA_SW_DIVERSITY)
-                ant->flags |= ANTENNA_RX_DIVERSITY;
-        if (rt2x00dev->default_ant.tx == ANTENNA_SW_DIVERSITY)
-                ant->flags |= ANTENNA_TX_DIVERSITY;
        if (!(ant->flags & ANTENNA_RX_DIVERSITY) &&
            !(ant->flags & ANTENNA_TX_DIVERSITY)) {
                ant->flags = 0;
@@ -383,7 +373,7 @@ static void rt2x00link_tuner(struct work_struct *work)
         * do not support link tuning at all, while other devices can disable
         * the feature from the EEPROM.
         */
-        if (test_bit(DRIVER_SUPPORT_LINK_TUNING, &rt2x00dev->flags))
+        if (test_bit(CAPABILITY_LINK_TUNING, &rt2x00dev->cap_flags))
                rt2x00dev->ops->lib->link_tuner(rt2x00dev, qual, link->count);
        /*
@@ -413,12 +403,11 @@ void rt2x00link_start_watchdog(struct rt2x00_dev *rt2x00dev)
 {
        struct link *link = &rt2x00dev->link;
-        if (!test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags) ||
+        if (test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags) &&
-            !test_bit(DRIVER_SUPPORT_WATCHDOG, &rt2x00dev->flags))
+            rt2x00dev->ops->lib->watchdog)
-                return;
+                ieee80211_queue_delayed_work(rt2x00dev->hw,
+                                             &link->watchdog_work,
-        ieee80211_queue_delayed_work(rt2x00dev->hw,
+                                             WATCHDOG_INTERVAL);
-                                     &link->watchdog_work, WATCHDOG_INTERVAL);
 }
 void rt2x00link_stop_watchdog(struct rt2x00_dev *rt2x00dev)
@@ -447,8 +436,46 @@ static void rt2x00link_watchdog(struct work_struct *work)
                                             WATCHDOG_INTERVAL);
 }
+void rt2x00link_start_agc(struct rt2x00_dev *rt2x00dev)
+{
+        struct link *link = &rt2x00dev->link;
+        if (test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags) &&
+            rt2x00dev->ops->lib->gain_calibration)
+                ieee80211_queue_delayed_work(rt2x00dev->hw,
+                                             &link->agc_work,
+                                             AGC_INTERVAL);
+}
+void rt2x00link_stop_agc(struct rt2x00_dev *rt2x00dev)
+{
+        cancel_delayed_work_sync(&rt2x00dev->link.agc_work);
+}
+static void rt2x00link_agc(struct work_struct *work)
+{
+        struct rt2x00_dev *rt2x00dev =
+            container_of(work, struct rt2x00_dev, link.agc_work.work);
+        struct link *link = &rt2x00dev->link;
+        /*
+         * When the radio is shutting down we should
+         * immediately cease the watchdog monitoring.
+         */
+        if (!test_bit(DEVICE_STATE_ENABLED_RADIO, &rt2x00dev->flags))
+                return;
+        rt2x00dev->ops->lib->gain_calibration(rt2x00dev);
+        if (test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags))
+                ieee80211_queue_delayed_work(rt2x00dev->hw,
+                                             &link->agc_work,
+                                             AGC_INTERVAL);
+}
 void rt2x00link_register(struct rt2x00_dev *rt2x00dev)
 {
+        INIT_DELAYED_WORK(&rt2x00dev->link.agc_work, rt2x00link_agc);
        INIT_DELAYED_WORK(&rt2x00dev->link.watchdog_work, rt2x00link_watchdog);
        INIT_DELAYED_WORK(&rt2x00dev->link.work, rt2x00link_tuner);
 }
diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c
index 661c6baad2b9..93bec140e598 100644
--- a/drivers/net/wireless/rt2x00/rt2x00mac.c
+++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
@@ -119,7 +119,7 @@ void rt2x00mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
         * Use the ATIM queue if appropriate and present.
         */
        if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM &&
-            test_bit(DRIVER_REQUIRE_ATIM_QUEUE, &rt2x00dev->flags))
+            test_bit(REQUIRE_ATIM_QUEUE, &rt2x00dev->cap_flags))
                qid = QID_ATIM;
        queue = rt2x00queue_get_tx_queue(rt2x00dev, qid);
@@ -158,7 +158,7 @@ void rt2x00mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
        return;
 exit_fail:
-        ieee80211_stop_queue(rt2x00dev->hw, qid);
+        rt2x00queue_pause_queue(queue);
        dev_kfree_skb_any(skb);
 }
 EXPORT_SYMBOL_GPL(rt2x00mac_tx);
@@ -411,11 +411,11 @@ void rt2x00mac_configure_filter(struct ieee80211_hw *hw,
         * of different types, but has no a separate filter for PS Poll frames,
         * FIF_CONTROL flag implies FIF_PSPOLL.
         */
-        if (!test_bit(DRIVER_SUPPORT_CONTROL_FILTERS, &rt2x00dev->flags)) {
+        if (!test_bit(CAPABILITY_CONTROL_FILTERS, &rt2x00dev->cap_flags)) {
                if (*total_flags & FIF_CONTROL || *total_flags & FIF_PSPOLL)
                        *total_flags |= FIF_CONTROL | FIF_PSPOLL;
        }
-        if (!test_bit(DRIVER_SUPPORT_CONTROL_FILTER_PSPOLL, &rt2x00dev->flags)) {
+        if (!test_bit(CAPABILITY_CONTROL_FILTER_PSPOLL, &rt2x00dev->cap_flags)) {
                if (*total_flags & FIF_CONTROL)
                        *total_flags |= FIF_PSPOLL;
        }
@@ -496,7 +496,7 @@ int rt2x00mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
        if (!test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags))
                return 0;
-        else if (!test_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags))
+        else if (!test_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags))
                return -EOPNOTSUPP;
        else if (key->keylen > 32)
                return -ENOSPC;
@@ -562,7 +562,7 @@ EXPORT_SYMBOL_GPL(rt2x00mac_set_key);
 void rt2x00mac_sw_scan_start(struct ieee80211_hw *hw)
 {
        struct rt2x00_dev *rt2x00dev = hw->priv;
-        __set_bit(DEVICE_STATE_SCANNING, &rt2x00dev->flags);
+        set_bit(DEVICE_STATE_SCANNING, &rt2x00dev->flags);
        rt2x00link_stop_tuner(rt2x00dev);
 }
 EXPORT_SYMBOL_GPL(rt2x00mac_sw_scan_start);
@@ -570,7 +570,7 @@ EXPORT_SYMBOL_GPL(rt2x00mac_sw_scan_start);
 void rt2x00mac_sw_scan_complete(struct ieee80211_hw *hw)
 {
        struct rt2x00_dev *rt2x00dev = hw->priv;
-        __clear_bit(DEVICE_STATE_SCANNING, &rt2x00dev->flags);
+        clear_bit(DEVICE_STATE_SCANNING, &rt2x00dev->flags);
        rt2x00link_start_tuner(rt2x00dev);
 }
 EXPORT_SYMBOL_GPL(rt2x00mac_sw_scan_complete);
@@ -737,3 +737,84 @@ void rt2x00mac_flush(struct ieee80211_hw *hw, bool drop)
                rt2x00queue_flush_queue(queue, drop);
 }
 EXPORT_SYMBOL_GPL(rt2x00mac_flush);
+int rt2x00mac_set_antenna(struct ieee80211_hw *hw, u32 tx_ant, u32 rx_ant)
+{
+        struct rt2x00_dev *rt2x00dev = hw->priv;
+        struct link_ant *ant = &rt2x00dev->link.ant;
+        struct antenna_setup *def = &rt2x00dev->default_ant;
+        struct antenna_setup setup;
+        // The antenna value is not supposed to be 0,
+        // or exceed the maximum number of antenna's.
+        if (!tx_ant || (tx_ant & ~3) || !rx_ant || (rx_ant & ~3))
+                return -EINVAL;
+        // When the client tried to configure the antenna to or from
+        // diversity mode, we must reset the default antenna as well
+        // as that controls the diversity switch.
+        if (ant->flags & ANTENNA_TX_DIVERSITY && tx_ant != 3)
+                ant->flags &= ~ANTENNA_TX_DIVERSITY;
+        if (ant->flags & ANTENNA_RX_DIVERSITY && rx_ant != 3)
+                ant->flags &= ~ANTENNA_RX_DIVERSITY;
+        // If diversity is being enabled, check if we need hardware
+        // or software diversity. In the latter case, reset the value,
+        // and make sure we update the antenna flags to have the
+        // link tuner pick up the diversity tuning.
+        if (tx_ant == 3 && def->tx == ANTENNA_SW_DIVERSITY) {
+                tx_ant = ANTENNA_SW_DIVERSITY;
+                ant->flags |= ANTENNA_TX_DIVERSITY;
+        }
+        if (rx_ant == 3 && def->rx == ANTENNA_SW_DIVERSITY) {
+                rx_ant = ANTENNA_SW_DIVERSITY;
+                ant->flags |= ANTENNA_RX_DIVERSITY;
+        }
+        setup.tx = tx_ant;
+        setup.rx = rx_ant;
+        rt2x00lib_config_antenna(rt2x00dev, setup);
+        return 0;
+}
+EXPORT_SYMBOL_GPL(rt2x00mac_set_antenna);
+int rt2x00mac_get_antenna(struct ieee80211_hw *hw, u32 *tx_ant, u32 *rx_ant)
+{
+        struct rt2x00_dev *rt2x00dev = hw->priv;
+        struct link_ant *ant = &rt2x00dev->link.ant;
+        struct antenna_setup *active = &rt2x00dev->link.ant.active;
+        // When software diversity is active, we must report this to the
+        // client and not the current active antenna state.
+        if (ant->flags & ANTENNA_TX_DIVERSITY)
+                *tx_ant = ANTENNA_HW_DIVERSITY;
+        else
+                *tx_ant = active->tx;
+        if (ant->flags & ANTENNA_RX_DIVERSITY)
+                *rx_ant = ANTENNA_HW_DIVERSITY;
+        else
+                *rx_ant = active->rx;
+        return 0;
+}
+EXPORT_SYMBOL_GPL(rt2x00mac_get_antenna);
+void rt2x00mac_get_ringparam(struct ieee80211_hw *hw,
+                             u32 *tx, u32 *tx_max, u32 *rx, u32 *rx_max)
+{
+        struct rt2x00_dev *rt2x00dev = hw->priv;
+        struct data_queue *queue;
+        tx_queue_for_each(rt2x00dev, queue) {
+                *tx += queue->length;
+                *tx_max += queue->limit;
+        }
+        *rx = rt2x00dev->rx->length;
+        *rx_max = rt2x00dev->rx->limit;
+}
+EXPORT_SYMBOL_GPL(rt2x00mac_get_ringparam);
diff --git a/drivers/net/wireless/rt2x00/rt2x00pci.c b/drivers/net/wireless/rt2x00/rt2x00pci.c
index 4dd82b0b0520..17148bb24426 100644
--- a/drivers/net/wireless/rt2x00/rt2x00pci.c
+++ b/drivers/net/wireless/rt2x00/rt2x00pci.c
@@ -60,14 +60,15 @@ int rt2x00pci_regbusy_read(struct rt2x00_dev *rt2x00dev,
 }
 EXPORT_SYMBOL_GPL(rt2x00pci_regbusy_read);
-void rt2x00pci_rxdone(struct rt2x00_dev *rt2x00dev)
+bool rt2x00pci_rxdone(struct rt2x00_dev *rt2x00dev)
 {
        struct data_queue *queue = rt2x00dev->rx;
        struct queue_entry *entry;
        struct queue_entry_priv_pci *entry_priv;
        struct skb_frame_desc *skbdesc;
+        int max_rx = 16;
-        while (1) {
+        while (--max_rx) {
                entry = rt2x00queue_get_entry(queue, Q_INDEX);
                entry_priv = entry->priv_data;
@@ -93,9 +94,20 @@ void rt2x00pci_rxdone(struct rt2x00_dev *rt2x00dev)
                 */
                rt2x00lib_rxdone(entry);
        }
+        return !max_rx;
 }
 EXPORT_SYMBOL_GPL(rt2x00pci_rxdone);
+void rt2x00pci_flush_queue(struct data_queue *queue, bool drop)
+{
+        unsigned int i;
+        for (i = 0; !rt2x00queue_empty(queue) && i < 10; i++)
+                msleep(10);
+}
+EXPORT_SYMBOL_GPL(rt2x00pci_flush_queue);
 /*
 * Device initialization handlers.
 */
@@ -239,9 +251,8 @@ exit:
        return -ENOMEM;
 }
-int rt2x00pci_probe(struct pci_dev *pci_dev, const struct pci_device_id *id)
+int rt2x00pci_probe(struct pci_dev *pci_dev, const struct rt2x00_ops *ops)
 {
-        struct rt2x00_ops *ops = (struct rt2x00_ops *)id->driver_data;
        struct ieee80211_hw *hw;
        struct rt2x00_dev *rt2x00dev;
        int retval;
diff --git a/drivers/net/wireless/rt2x00/rt2x00pci.h b/drivers/net/wireless/rt2x00/rt2x00pci.h
index 746ce8fe8cf4..e2c99f2b9a14 100644
--- a/drivers/net/wireless/rt2x00/rt2x00pci.h
+++ b/drivers/net/wireless/rt2x00/rt2x00pci.h
@@ -101,8 +101,21 @@ struct queue_entry_priv_pci {
 /**
 * rt2x00pci_rxdone - Handle RX done events
 * @rt2x00dev: Device pointer, see &struct rt2x00_dev.
+ *
+ * Returns true if there are still rx frames pending and false if all
+ * pending rx frames were processed.
+ */
+bool rt2x00pci_rxdone(struct rt2x00_dev *rt2x00dev);
+/**
+ * rt2x00pci_flush_queue - Flush data queue
+ * @queue: Data queue to stop
+ * @drop: True to drop all pending frames.
+ *
+ * This will wait for a maximum of 100ms, waiting for the queues
+ * to become empty.
 */
-void rt2x00pci_rxdone(struct rt2x00_dev *rt2x00dev);
+void rt2x00pci_flush_queue(struct data_queue *queue, bool drop);
 /*
 * Device initialization handlers.
@@ -113,7 +126,7 @@ void rt2x00pci_uninitialize(struct rt2x00_dev *rt2x00dev);
 /*
 * PCI driver handlers.
 */
-int rt2x00pci_probe(struct pci_dev *pci_dev, const struct pci_device_id *id);
+int rt2x00pci_probe(struct pci_dev *pci_dev, const struct rt2x00_ops *ops);
 void rt2x00pci_remove(struct pci_dev *pci_dev);
 #ifdef CONFIG_PM
 int rt2x00pci_suspend(struct pci_dev *pci_dev, pm_message_t state);
diff --git a/drivers/net/wireless/rt2x00/rt2x00queue.c b/drivers/net/wireless/rt2x00/rt2x00queue.c
index 4358051bfe1a..ab8c16f8bcaf 100644
--- a/drivers/net/wireless/rt2x00/rt2x00queue.c
+++ b/drivers/net/wireless/rt2x00/rt2x00queue.c
@@ -60,7 +60,7 @@ struct sk_buff *rt2x00queue_alloc_rxskb(struct queue_entry *entry)
         * at least 8 bytes bytes available in headroom for IV/EIV
         * and 8 bytes for ICV data as tailroon.
         */
-        if (test_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags)) {
+        if (test_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags)) {
                head_size += 8;
                tail_size += 8;
        }
@@ -86,7 +86,7 @@ struct sk_buff *rt2x00queue_alloc_rxskb(struct queue_entry *entry)
        memset(skbdesc, 0, sizeof(*skbdesc));
        skbdesc->entry = entry;
-        if (test_bit(DRIVER_REQUIRE_DMA, &rt2x00dev->flags)) {
+        if (test_bit(REQUIRE_DMA, &rt2x00dev->cap_flags)) {
                skbdesc->skb_dma = dma_map_single(rt2x00dev->dev,
                                                  skb->data,
                                                  skb->len,
@@ -148,19 +148,6 @@ void rt2x00queue_align_frame(struct sk_buff *skb)
        skb_trim(skb, frame_length);
 }
-void rt2x00queue_align_payload(struct sk_buff *skb, unsigned int header_length)
-{
-        unsigned int frame_length = skb->len;
-        unsigned int align = ALIGN_SIZE(skb, header_length);
-        if (!align)
-                return;
-        skb_push(skb, align);
-        memmove(skb->data, skb->data + align, frame_length);
-        skb_trim(skb, frame_length);
-}
 void rt2x00queue_insert_l2pad(struct sk_buff *skb, unsigned int header_length)
 {
        unsigned int payload_length = skb->len - header_length;
@@ -226,7 +213,7 @@ static void rt2x00queue_create_tx_descriptor_seq(struct queue_entry *entry,
        __set_bit(ENTRY_TXD_GENERATE_SEQ, &txdesc->flags);
-        if (!test_bit(DRIVER_REQUIRE_SW_SEQNO, &entry->queue->rt2x00dev->flags))
+        if (!test_bit(REQUIRE_SW_SEQNO, &entry->queue->rt2x00dev->cap_flags))
                return;
        /*
@@ -315,6 +302,85 @@ static void rt2x00queue_create_tx_descriptor_plcp(struct queue_entry *entry,
        }
 }
+static void rt2x00queue_create_tx_descriptor_ht(struct queue_entry *entry,
+                                                struct txentry_desc *txdesc,
+                                                const struct rt2x00_rate *hwrate)
+{
+        struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(entry->skb);
+        struct ieee80211_tx_rate *txrate = &tx_info->control.rates[0];
+        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)entry->skb->data;
+        if (tx_info->control.sta)
+                txdesc->u.ht.mpdu_density =
+                    tx_info->control.sta->ht_cap.ampdu_density;
+        txdesc->u.ht.ba_size = 7;       /* FIXME: What value is needed? */
+        /*
+         * Only one STBC stream is supported for now.
+         */
+        if (tx_info->flags & IEEE80211_TX_CTL_STBC)
+                txdesc->u.ht.stbc = 1;
+        /*
+         * If IEEE80211_TX_RC_MCS is set txrate->idx just contains the
+         * mcs rate to be used
+         */
+        if (txrate->flags & IEEE80211_TX_RC_MCS) {
+                txdesc->u.ht.mcs = txrate->idx;
+                /*
+                 * MIMO PS should be set to 1 for STA's using dynamic SM PS
+                 * when using more then one tx stream (>MCS7).
+                 */
+                if (tx_info->control.sta && txdesc->u.ht.mcs > 7 &&
+                    ((tx_info->control.sta->ht_cap.cap &
+                      IEEE80211_HT_CAP_SM_PS) >>
+                     IEEE80211_HT_CAP_SM_PS_SHIFT) ==
+                    WLAN_HT_CAP_SM_PS_DYNAMIC)
+                        __set_bit(ENTRY_TXD_HT_MIMO_PS, &txdesc->flags);
+        } else {
+                txdesc->u.ht.mcs = rt2x00_get_rate_mcs(hwrate->mcs);
+                if (txrate->flags & IEEE80211_TX_RC_USE_SHORT_PREAMBLE)
+                        txdesc->u.ht.mcs |= 0x08;
+        }
+        /*
+         * This frame is eligible for an AMPDU, however, don't aggregate
+         * frames that are intended to probe a specific tx rate.
+         */
+        if (tx_info->flags & IEEE80211_TX_CTL_AMPDU &&
+            !(tx_info->flags & IEEE80211_TX_CTL_RATE_CTRL_PROBE))
+                __set_bit(ENTRY_TXD_HT_AMPDU, &txdesc->flags);
+        /*
+         * Set 40Mhz mode if necessary (for legacy rates this will
+         * duplicate the frame to both channels).
+         */
+        if (txrate->flags & IEEE80211_TX_RC_40_MHZ_WIDTH ||
+            txrate->flags & IEEE80211_TX_RC_DUP_DATA)
+                __set_bit(ENTRY_TXD_HT_BW_40, &txdesc->flags);
+        if (txrate->flags & IEEE80211_TX_RC_SHORT_GI)
+                __set_bit(ENTRY_TXD_HT_SHORT_GI, &txdesc->flags);
+        /*
+         * Determine IFS values
+         * - Use TXOP_BACKOFF for management frames except beacons
+         * - Use TXOP_SIFS for fragment bursts
+         * - Use TXOP_HTTXOP for everything else
+         *
+         * Note: rt2800 devices won't use CTS protection (if used)
+         * for frames not transmitted with TXOP_HTTXOP
+         */
+        if (ieee80211_is_mgmt(hdr->frame_control) &&
+            !ieee80211_is_beacon(hdr->frame_control))
+                txdesc->u.ht.txop = TXOP_BACKOFF;
+        else if (!(tx_info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT))
+                txdesc->u.ht.txop = TXOP_SIFS;
+        else
+                txdesc->u.ht.txop = TXOP_HTTXOP;
+}
 static void rt2x00queue_create_tx_descriptor(struct queue_entry *entry,
                                             struct txentry_desc *txdesc)
 {
@@ -409,8 +475,8 @@ static void rt2x00queue_create_tx_descriptor(struct queue_entry *entry,
        rt2x00crypto_create_tx_descriptor(entry, txdesc);
        rt2x00queue_create_tx_descriptor_seq(entry, txdesc);
-        if (test_bit(DRIVER_REQUIRE_HT_TX_DESC, &rt2x00dev->flags))
+        if (test_bit(REQUIRE_HT_TX_DESC, &rt2x00dev->cap_flags))
-                rt2x00ht_create_tx_descriptor(entry, txdesc, hwrate);
+                rt2x00queue_create_tx_descriptor_ht(entry, txdesc, hwrate);
        else
                rt2x00queue_create_tx_descriptor_plcp(entry, txdesc, hwrate);
 }
@@ -449,7 +515,7 @@ static int rt2x00queue_write_tx_data(struct queue_entry *entry,
        /*
         * Map the skb to DMA.
         */
-        if (test_bit(DRIVER_REQUIRE_DMA, &rt2x00dev->flags))
+        if (test_bit(REQUIRE_DMA, &rt2x00dev->cap_flags))
                rt2x00queue_map_txskb(entry);
        return 0;
@@ -495,8 +561,11 @@ int rt2x00queue_write_tx_frame(struct data_queue *queue, struct sk_buff *skb,
        struct skb_frame_desc *skbdesc;
        u8 rate_idx, rate_flags;
-        if (unlikely(rt2x00queue_full(queue)))
+        if (unlikely(rt2x00queue_full(queue))) {
+                ERROR(queue->rt2x00dev,
+                      "Dropping frame due to full tx queue %d.\n", queue->qid);
                return -ENOBUFS;
+        }
        if (unlikely(test_and_set_bit(ENTRY_OWNER_DEVICE_DATA,
                                      &entry->flags))) {
@@ -539,7 +608,7 @@ int rt2x00queue_write_tx_frame(struct data_queue *queue, struct sk_buff *skb,
         */
        if (test_bit(ENTRY_TXD_ENCRYPT, &txdesc.flags) &&
            !test_bit(ENTRY_TXD_ENCRYPT_IV, &txdesc.flags)) {
-                if (test_bit(DRIVER_REQUIRE_COPY_IV, &queue->rt2x00dev->flags))
+                if (test_bit(REQUIRE_COPY_IV, &queue->rt2x00dev->cap_flags))
                        rt2x00crypto_tx_copy_iv(skb, &txdesc);
                else
                        rt2x00crypto_tx_remove_iv(skb, &txdesc);
@@ -553,9 +622,9 @@ int rt2x00queue_write_tx_frame(struct data_queue *queue, struct sk_buff *skb,
         * PCI and USB devices, while header alignment only is valid
         * for PCI devices.
         */
-        if (test_bit(DRIVER_REQUIRE_L2PAD, &queue->rt2x00dev->flags))
+        if (test_bit(REQUIRE_L2PAD, &queue->rt2x00dev->cap_flags))
                rt2x00queue_insert_l2pad(entry->skb, txdesc.header_length);
-        else if (test_bit(DRIVER_REQUIRE_DMA, &queue->rt2x00dev->flags))
+        else if (test_bit(REQUIRE_DMA, &queue->rt2x00dev->cap_flags))
                rt2x00queue_align_frame(entry->skb);
        /*
@@ -571,7 +640,7 @@ int rt2x00queue_write_tx_frame(struct data_queue *queue, struct sk_buff *skb,
        set_bit(ENTRY_DATA_PENDING, &entry->flags);
-        rt2x00queue_index_inc(queue, Q_INDEX);
+        rt2x00queue_index_inc(entry, Q_INDEX);
        rt2x00queue_write_tx_descriptor(entry, &txdesc);
        rt2x00queue_kick_tx_queue(queue, &txdesc);
@@ -660,10 +729,12 @@ int rt2x00queue_update_beacon(struct rt2x00_dev *rt2x00dev,
        return ret;
 }
-void rt2x00queue_for_each_entry(struct data_queue *queue,
+bool rt2x00queue_for_each_entry(struct data_queue *queue,
                                enum queue_index start,
                                enum queue_index end,
-                                void (*fn)(struct queue_entry *entry))
+                                void *data,
+                                bool (*fn)(struct queue_entry *entry,
+                                           void *data))
 {
        unsigned long irqflags;
        unsigned int index_start;
@@ -674,7 +745,7 @@ void rt2x00queue_for_each_entry(struct data_queue *queue,
                ERROR(queue->rt2x00dev,
                      "Entry requested from invalid index range (%d - %d)\n",
                      start, end);
-                return;
+                return true;
        }
        /*
@@ -693,15 +764,23 @@ void rt2x00queue_for_each_entry(struct data_queue *queue,
         * send out all frames in the correct order.
         */
        if (index_start < index_end) {
-                for (i = index_start; i < index_end; i++)
+                for (i = index_start; i < index_end; i++) {
-                        fn(&queue->entries[i]);
+                        if (fn(&queue->entries[i], data))
+                                return true;
+                }
        } else {
-                for (i = index_start; i < queue->limit; i++)
+                for (i = index_start; i < queue->limit; i++) {
-                        fn(&queue->entries[i]);
+                        if (fn(&queue->entries[i], data))
+                                return true;
+                }
-                for (i = 0; i < index_end; i++)
+                for (i = 0; i < index_end; i++) {
-                        fn(&queue->entries[i]);
+                        if (fn(&queue->entries[i], data))
+                                return true;
+                }
        }
+        return false;
 }
 EXPORT_SYMBOL_GPL(rt2x00queue_for_each_entry);
@@ -727,8 +806,9 @@ struct queue_entry *rt2x00queue_get_entry(struct data_queue *queue,
 }
 EXPORT_SYMBOL_GPL(rt2x00queue_get_entry);
-void rt2x00queue_index_inc(struct data_queue *queue, enum queue_index index)
+void rt2x00queue_index_inc(struct queue_entry *entry, enum queue_index index)
 {
+        struct data_queue *queue = entry->queue;
        unsigned long irqflags;
        if (unlikely(index >= Q_INDEX_MAX)) {
@@ -743,7 +823,7 @@ void rt2x00queue_index_inc(struct data_queue *queue, enum queue_index index)
        if (queue->index[index] >= queue->limit)
                queue->index[index] = 0;
-        queue->last_action[index] = jiffies;
+        entry->last_action = jiffies;
        if (index == Q_INDEX) {
                queue->length++;
@@ -848,7 +928,6 @@ EXPORT_SYMBOL_GPL(rt2x00queue_stop_queue);
 void rt2x00queue_flush_queue(struct data_queue *queue, bool drop)
 {
-        unsigned int i;
        bool started;
        bool tx_queue =
                (queue->qid == QID_AC_VO) ||
@@ -883,20 +962,12 @@ void rt2x00queue_flush_queue(struct data_queue *queue, bool drop)
        }
        /*
-         * Check if driver supports flushing, we can only guarantee
+         * Check if driver supports flushing, if that is the case we can
-         * full support for flushing if the driver is able
+         * defer the flushing to the driver. Otherwise we must use the
-         * to cancel all pending frames (drop = true).
+         * alternative which just waits for the queue to become empty.
-         */
-        if (drop && queue->rt2x00dev->ops->lib->flush_queue)
-                queue->rt2x00dev->ops->lib->flush_queue(queue);
-        /*
-         * When we don't want to drop any frames, or when
-         * the driver doesn't fully flush the queue correcly,
-         * we must wait for the queue to become empty.
         */
-        for (i = 0; !rt2x00queue_empty(queue) && i < 100; i++)
+        if (likely(queue->rt2x00dev->ops->lib->flush_queue))
-                msleep(10);
+                queue->rt2x00dev->ops->lib->flush_queue(queue, drop);
        /*
         * The queue flush has failed...
@@ -969,10 +1040,8 @@ static void rt2x00queue_reset(struct data_queue *queue)
        queue->count = 0;
        queue->length = 0;
-        for (i = 0; i < Q_INDEX_MAX; i++) {
+        for (i = 0; i < Q_INDEX_MAX; i++)
                queue->index[i] = 0;
-                queue->last_action[i] = jiffies;
-        }
        spin_unlock_irqrestore(&queue->index_lock, irqflags);
 }
@@ -1079,7 +1148,7 @@ int rt2x00queue_initialize(struct rt2x00_dev *rt2x00dev)
        if (status)
                goto exit;
-        if (test_bit(DRIVER_REQUIRE_ATIM_QUEUE, &rt2x00dev->flags)) {
+        if (test_bit(REQUIRE_ATIM_QUEUE, &rt2x00dev->cap_flags)) {
                status = rt2x00queue_alloc_entries(rt2x00dev->atim,
                                                   rt2x00dev->ops->atim);
                if (status)
@@ -1131,7 +1200,7 @@ int rt2x00queue_allocate(struct rt2x00_dev *rt2x00dev)
        struct data_queue *queue;
        enum data_queue_qid qid;
        unsigned int req_atim =
-            !!test_bit(DRIVER_REQUIRE_ATIM_QUEUE, &rt2x00dev->flags);
+            !!test_bit(REQUIRE_ATIM_QUEUE, &rt2x00dev->cap_flags);
        /*
         * We need the following queues:
diff --git a/drivers/net/wireless/rt2x00/rt2x00queue.h b/drivers/net/wireless/rt2x00/rt2x00queue.h
index 217861f8d95f..167d45873dca 100644
--- a/drivers/net/wireless/rt2x00/rt2x00queue.h
+++ b/drivers/net/wireless/rt2x00/rt2x00queue.h
@@ -217,6 +217,7 @@ enum txdone_entry_desc_flags {
        TXDONE_FALLBACK,
        TXDONE_FAILURE,
        TXDONE_EXCESSIVE_RETRY,
+        TXDONE_AMPDU,
 };
 /**
@@ -363,6 +364,7 @@ enum queue_entry_flags {
 * struct queue_entry: Entry inside the &struct data_queue
 *
 * @flags: Entry flags, see &enum queue_entry_flags.
+ * @last_action: Timestamp of last change.
 * @queue: The data queue (&struct data_queue) to which this entry belongs.
 * @skb: The buffer which is currently being transmitted (for TX queue),
 *      or used to directly receive data in (for RX queue).
@@ -372,6 +374,7 @@ enum queue_entry_flags {
 */
 struct queue_entry {
        unsigned long flags;
+        unsigned long last_action;
        struct data_queue *queue;
@@ -462,7 +465,6 @@ struct data_queue {
        unsigned short threshold;
        unsigned short length;
        unsigned short index[Q_INDEX_MAX];
-        unsigned long last_action[Q_INDEX_MAX];
        unsigned short txop;
        unsigned short aifs;
@@ -579,16 +581,22 @@ struct data_queue_desc {
 * @queue: Pointer to @data_queue
 * @start: &enum queue_index Pointer to start index
 * @end: &enum queue_index Pointer to end index
+ * @data: Data to pass to the callback function
 * @fn: The function to call for each &struct queue_entry
 *
 * This will walk through all entries in the queue, in chronological
 * order. This means it will start at the current @start pointer
 * and will walk through the queue until it reaches the @end pointer.
+ *
+ * If fn returns true for an entry rt2x00queue_for_each_entry will stop
+ * processing and return true as well.
 */
-void rt2x00queue_for_each_entry(struct data_queue *queue,
+bool rt2x00queue_for_each_entry(struct data_queue *queue,
                                enum queue_index start,
                                enum queue_index end,
-                                void (*fn)(struct queue_entry *entry));
+                                void *data,
+                                bool (*fn)(struct queue_entry *entry,
+                                           void *data));
 /**
 * rt2x00queue_empty - Check if the queue is empty.
@@ -628,22 +636,24 @@ static inline int rt2x00queue_threshold(struct data_queue *queue)
 /**
 * rt2x00queue_status_timeout - Check if a timeout occurred for STATUS reports
- * @queue: Queue to check.
+ * @entry: Queue entry to check.
 */
-static inline int rt2x00queue_status_timeout(struct data_queue *queue)
+static inline int rt2x00queue_status_timeout(struct queue_entry *entry)
 {
-        return time_after(queue->last_action[Q_INDEX_DMA_DONE],
+        if (!test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
-                          queue->last_action[Q_INDEX_DONE] + (HZ / 10));
+                return false;
+        return time_after(jiffies, entry->last_action + msecs_to_jiffies(100));
 }
 /**
- * rt2x00queue_timeout - Check if a timeout occurred for DMA transfers
+ * rt2x00queue_dma_timeout - Check if a timeout occurred for DMA transfers
- * @queue: Queue to check.
+ * @entry: Queue entry to check.
 */
-static inline int rt2x00queue_dma_timeout(struct data_queue *queue)
+static inline int rt2x00queue_dma_timeout(struct queue_entry *entry)
 {
-        return time_after(queue->last_action[Q_INDEX],
+        if (!test_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
-                          queue->last_action[Q_INDEX_DMA_DONE] + (HZ / 10));
+                return false;
+        return time_after(jiffies, entry->last_action + msecs_to_jiffies(100));
 }
 /**
diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c b/drivers/net/wireless/rt2x00/rt2x00usb.c
index 36f388f97d65..8f90f6268077 100644
--- a/drivers/net/wireless/rt2x00/rt2x00usb.c
+++ b/drivers/net/wireless/rt2x00/rt2x00usb.c
@@ -165,6 +165,59 @@ int rt2x00usb_regbusy_read(struct rt2x00_dev *rt2x00dev,
 }
 EXPORT_SYMBOL_GPL(rt2x00usb_regbusy_read);
+struct rt2x00_async_read_data {
+        __le32 reg;
+        struct usb_ctrlrequest cr;
+        struct rt2x00_dev *rt2x00dev;
+        bool (*callback)(struct rt2x00_dev *, int, u32);
+};
+static void rt2x00usb_register_read_async_cb(struct urb *urb)
+{
+        struct rt2x00_async_read_data *rd = urb->context;
+        if (rd->callback(rd->rt2x00dev, urb->status, le32_to_cpu(rd->reg))) {
+                if (usb_submit_urb(urb, GFP_ATOMIC) < 0)
+                        kfree(rd);
+        } else
+                kfree(rd);
+}
+void rt2x00usb_register_read_async(struct rt2x00_dev *rt2x00dev,
+                                   const unsigned int offset,
+                                   bool (*callback)(struct rt2x00_dev*, int, u32))
+{
+        struct usb_device *usb_dev = to_usb_device_intf(rt2x00dev->dev);
+        struct urb *urb;
+        struct rt2x00_async_read_data *rd;
+        rd = kmalloc(sizeof(*rd), GFP_ATOMIC);
+        if (!rd)
+                return;
+        urb = usb_alloc_urb(0, GFP_ATOMIC);
+        if (!urb) {
+                kfree(rd);
+                return;
+        }
+        rd->rt2x00dev = rt2x00dev;
+        rd->callback = callback;
+        rd->cr.bRequestType = USB_VENDOR_REQUEST_IN;
+        rd->cr.bRequest = USB_MULTI_READ;
+        rd->cr.wValue = 0;
+        rd->cr.wIndex = cpu_to_le16(offset);
+        rd->cr.wLength = cpu_to_le16(sizeof(u32));
+        usb_fill_control_urb(urb, usb_dev, usb_rcvctrlpipe(usb_dev, 0),
+                             (unsigned char *)(&rd->cr), &rd->reg, sizeof(rd->reg),
+                             rt2x00usb_register_read_async_cb, rd);
+        if (usb_submit_urb(urb, GFP_ATOMIC) < 0)
+                kfree(rd);
+        usb_free_urb(urb);
+}
+EXPORT_SYMBOL_GPL(rt2x00usb_register_read_async);
 /*
 * TX data handlers.
 */
@@ -212,6 +265,9 @@ static void rt2x00usb_interrupt_txdone(struct urb *urb)
        if (!test_and_clear_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
                return;
+        if (rt2x00dev->ops->lib->tx_dma_done)
+                rt2x00dev->ops->lib->tx_dma_done(entry);
        /*
         * Report the frame as DMA done
         */
@@ -227,10 +283,12 @@ static void rt2x00usb_interrupt_txdone(struct urb *urb)
         * Schedule the delayed work for reading the TX status
         * from the device.
         */
-        queue_work(rt2x00dev->workqueue, &rt2x00dev->txdone_work);
+        if (!test_bit(REQUIRE_TXSTATUS_FIFO, &rt2x00dev->cap_flags) ||
+            !kfifo_is_empty(&rt2x00dev->txstatus_fifo))
+                queue_work(rt2x00dev->workqueue, &rt2x00dev->txdone_work);
 }
-static void rt2x00usb_kick_tx_entry(struct queue_entry *entry)
+static bool rt2x00usb_kick_tx_entry(struct queue_entry *entry, void* data)
 {
        struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
        struct usb_device *usb_dev = to_usb_device_intf(rt2x00dev->dev);
@@ -240,7 +298,7 @@ static void rt2x00usb_kick_tx_entry(struct queue_entry *entry)
        if (!test_and_clear_bit(ENTRY_DATA_PENDING, &entry->flags) ||
            test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
-                return;
+                return false;
        /*
         * USB devices cannot blindly pass the skb->len as the
@@ -261,6 +319,8 @@ static void rt2x00usb_kick_tx_entry(struct queue_entry *entry)
                set_bit(ENTRY_DATA_IO_FAILED, &entry->flags);
                rt2x00lib_dmadone(entry);
        }
+        return false;
 }
 /*
@@ -323,7 +383,7 @@ static void rt2x00usb_interrupt_rxdone(struct urb *urb)
        queue_work(rt2x00dev->workqueue, &rt2x00dev->rxdone_work);
 }
-static void rt2x00usb_kick_rx_entry(struct queue_entry *entry)
+static bool rt2x00usb_kick_rx_entry(struct queue_entry *entry, void* data)
 {
        struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
        struct usb_device *usb_dev = to_usb_device_intf(rt2x00dev->dev);
@@ -332,7 +392,7 @@ static void rt2x00usb_kick_rx_entry(struct queue_entry *entry)
        if (test_and_set_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags) ||
            test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
-                return;
+                return false;
        rt2x00lib_dmastart(entry);
@@ -348,6 +408,8 @@ static void rt2x00usb_kick_rx_entry(struct queue_entry *entry)
                set_bit(ENTRY_DATA_IO_FAILED, &entry->flags);
                rt2x00lib_dmadone(entry);
        }
+        return false;
 }
 void rt2x00usb_kick_queue(struct data_queue *queue)
@@ -358,12 +420,18 @@ void rt2x00usb_kick_queue(struct data_queue *queue)
        case QID_AC_BE:
        case QID_AC_BK:
                if (!rt2x00queue_empty(queue))
-                        rt2x00queue_for_each_entry(queue, Q_INDEX_DONE, Q_INDEX,
+                        rt2x00queue_for_each_entry(queue,
+                                                   Q_INDEX_DONE,
+                                                   Q_INDEX,
+                                                   NULL,
                                                   rt2x00usb_kick_tx_entry);
                break;
        case QID_RX:
                if (!rt2x00queue_full(queue))
-                        rt2x00queue_for_each_entry(queue, Q_INDEX_DONE, Q_INDEX,
+                        rt2x00queue_for_each_entry(queue,
+                                                   Q_INDEX_DONE,
+                                                   Q_INDEX,
+                                                   NULL,
                                                   rt2x00usb_kick_rx_entry);
                break;
        default:
@@ -372,14 +440,14 @@ void rt2x00usb_kick_queue(struct data_queue *queue)
 }
 EXPORT_SYMBOL_GPL(rt2x00usb_kick_queue);
-static void rt2x00usb_flush_entry(struct queue_entry *entry)
+static bool rt2x00usb_flush_entry(struct queue_entry *entry, void* data)
 {
        struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
        struct queue_entry_priv_usb *entry_priv = entry->priv_data;
        struct queue_entry_priv_usb_bcn *bcn_priv = entry->priv_data;
        if (!test_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
-                return;
+                return false;
        usb_kill_urb(entry_priv->urb);
@@ -387,17 +455,20 @@ static void rt2x00usb_flush_entry(struct queue_entry *entry)
         * Kill guardian urb (if required by driver).
         */
        if ((entry->queue->qid == QID_BEACON) &&
-            (test_bit(DRIVER_REQUIRE_BEACON_GUARD, &rt2x00dev->flags)))
+            (test_bit(REQUIRE_BEACON_GUARD, &rt2x00dev->cap_flags)))
                usb_kill_urb(bcn_priv->guardian_urb);
+        return false;
 }
-void rt2x00usb_flush_queue(struct data_queue *queue)
+void rt2x00usb_flush_queue(struct data_queue *queue, bool drop)
 {
        struct work_struct *completion;
        unsigned int i;
-        rt2x00queue_for_each_entry(queue, Q_INDEX_DONE, Q_INDEX,
+        if (drop)
-                                   rt2x00usb_flush_entry);
+                rt2x00queue_for_each_entry(queue, Q_INDEX_DONE, Q_INDEX, NULL,
+                                           rt2x00usb_flush_entry);
        /*
         * Obtain the queue completion handler
@@ -416,7 +487,7 @@ void rt2x00usb_flush_queue(struct data_queue *queue)
                return;
        }
-        for (i = 0; i < 20; i++) {
+        for (i = 0; i < 10; i++) {
                /*
                 * Check if the driver is already done, otherwise we
                 * have to sleep a little while to give the driver/hw
@@ -456,15 +527,31 @@ static void rt2x00usb_watchdog_tx_status(struct data_queue *queue)
        queue_work(queue->rt2x00dev->workqueue, &queue->rt2x00dev->txdone_work);
 }
+static int rt2x00usb_status_timeout(struct data_queue *queue)
+{
+        struct queue_entry *entry;
+        entry = rt2x00queue_get_entry(queue, Q_INDEX_DONE);
+        return rt2x00queue_status_timeout(entry);
+}
+static int rt2x00usb_dma_timeout(struct data_queue *queue)
+{
+        struct queue_entry *entry;
+        entry = rt2x00queue_get_entry(queue, Q_INDEX_DMA_DONE);
+        return rt2x00queue_dma_timeout(entry);
+}
 void rt2x00usb_watchdog(struct rt2x00_dev *rt2x00dev)
 {
        struct data_queue *queue;
        tx_queue_for_each(rt2x00dev, queue) {
                if (!rt2x00queue_empty(queue)) {
-                        if (rt2x00queue_dma_timeout(queue))
+                        if (rt2x00usb_dma_timeout(queue))
                                rt2x00usb_watchdog_tx_dma(queue);
-                        if (rt2x00queue_status_timeout(queue))
+                        if (rt2x00usb_status_timeout(queue))
                                rt2x00usb_watchdog_tx_status(queue);
                }
        }
@@ -489,7 +576,7 @@ void rt2x00usb_clear_entry(struct queue_entry *entry)
        entry->flags = 0;
        if (entry->queue->qid == QID_RX)
-                rt2x00usb_kick_rx_entry(entry);
+                rt2x00usb_kick_rx_entry(entry, NULL);
 }
 EXPORT_SYMBOL_GPL(rt2x00usb_clear_entry);
@@ -583,7 +670,7 @@ static int rt2x00usb_alloc_entries(struct data_queue *queue)
         * then we are done.
         */
        if (queue->qid != QID_BEACON ||
-            !test_bit(DRIVER_REQUIRE_BEACON_GUARD, &rt2x00dev->flags))
+            !test_bit(REQUIRE_BEACON_GUARD, &rt2x00dev->cap_flags))
                return 0;
        for (i = 0; i < queue->limit; i++) {
@@ -618,7 +705,7 @@ static void rt2x00usb_free_entries(struct data_queue *queue)
         * then we are done.
         */
        if (queue->qid != QID_BEACON ||
-            !test_bit(DRIVER_REQUIRE_BEACON_GUARD, &rt2x00dev->flags))
+            !test_bit(REQUIRE_BEACON_GUARD, &rt2x00dev->cap_flags))
                return;
        for (i = 0; i < queue->limit; i++) {
@@ -707,10 +794,9 @@ exit:
 }
 int rt2x00usb_probe(struct usb_interface *usb_intf,
-                    const struct usb_device_id *id)
+                    const struct rt2x00_ops *ops)
 {
        struct usb_device *usb_dev = interface_to_usbdev(usb_intf);
-        struct rt2x00_ops *ops = (struct rt2x00_ops *)id->driver_info;
        struct ieee80211_hw *hw;
        struct rt2x00_dev *rt2x00dev;
        int retval;
@@ -735,6 +821,7 @@ int rt2x00usb_probe(struct usb_interface *usb_intf,
        INIT_WORK(&rt2x00dev->rxdone_work, rt2x00usb_work_rxdone);
        INIT_WORK(&rt2x00dev->txdone_work, rt2x00usb_work_txdone);
+        init_timer(&rt2x00dev->txstatus_timer);
        retval = rt2x00usb_alloc_reg(rt2x00dev);
        if (retval)
diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.h b/drivers/net/wireless/rt2x00/rt2x00usb.h
index e11c759ac9ed..323ca7b2b095 100644
--- a/drivers/net/wireless/rt2x00/rt2x00usb.h
+++ b/drivers/net/wireless/rt2x00/rt2x00usb.h
@@ -35,12 +35,6 @@
 })
 /*
- * This variable should be used with the
- * usb_driver structure initialization.
- */
-#define USB_DEVICE_DATA(__ops)  .driver_info = (kernel_ulong_t)(__ops)
-/*
 * For USB vendor requests we need to pass a timeout
 * time in ms, for this we use the REGISTER_TIMEOUT,
 * however when loading firmware a higher value is
@@ -345,6 +339,23 @@ int rt2x00usb_regbusy_read(struct rt2x00_dev *rt2x00dev,
                           const struct rt2x00_field32 field,
                           u32 *reg);
+/**
+ * rt2x00usb_register_read_async - Asynchronously read 32bit register word
+ * @rt2x00dev: Device pointer, see &struct rt2x00_dev.
+ * @offset: Register offset
+ * @callback: Functon to call when read completes.
+ *
+ * Submit a control URB to read a 32bit register. This safe to
+ * be called from atomic context.  The callback will be called
+ * when the URB completes. Otherwise the function is similar
+ * to rt2x00usb_register_read().
+ * When the callback function returns false, the memory will be cleaned up,
+ * when it returns true, the urb will be fired again.
+ */
+void rt2x00usb_register_read_async(struct rt2x00_dev *rt2x00dev,
+                                   const unsigned int offset,
+                                   bool (*callback)(struct rt2x00_dev*, int, u32));
 /*
 * Radio handlers
 */
@@ -389,11 +400,13 @@ void rt2x00usb_kick_queue(struct data_queue *queue);
 /**
 * rt2x00usb_flush_queue - Flush data queue
 * @queue: Data queue to stop
+ * @drop: True to drop all pending frames.
 *
- * This will walk through all entries of the queue and kill all
+ * This will walk through all entries of the queue and will optionally
- * URB's which were send to the device.
+ * kill all URB's which were send to the device, or at least wait until
+ * they have been returned from the device..
 */
-void rt2x00usb_flush_queue(struct data_queue *queue);
+void rt2x00usb_flush_queue(struct data_queue *queue, bool drop);
 /**
 * rt2x00usb_watchdog - Watchdog for USB communication
@@ -416,7 +429,7 @@ void rt2x00usb_uninitialize(struct rt2x00_dev *rt2x00dev);
 * USB driver handlers.
 */
 int rt2x00usb_probe(struct usb_interface *usb_intf,
-                    const struct usb_device_id *id);
+                    const struct rt2x00_ops *ops);
 void rt2x00usb_disconnect(struct usb_interface *usb_intf);
 #ifdef CONFIG_PM
 int rt2x00usb_suspend(struct usb_interface *usb_intf, pm_message_t state);
diff --git a/drivers/net/wireless/rt2x00/rt61pci.c b/drivers/net/wireless/rt2x00/rt61pci.c
index 77e8113b91e1..9d35ec16a3a5 100644
--- a/drivers/net/wireless/rt2x00/rt61pci.c
+++ b/drivers/net/wireless/rt2x00/rt61pci.c
@@ -683,7 +683,7 @@ static void rt61pci_config_antenna_2x(struct rt2x00_dev *rt2x00dev,
        rt2x00_set_field8(&r3, BBP_R3_SMART_MODE, rt2x00_rf(rt2x00dev, RF2529));
        rt2x00_set_field8(&r4, BBP_R4_RX_FRAME_END,
-                          !test_bit(CONFIG_FRAME_TYPE, &rt2x00dev->flags));
+                          !test_bit(CAPABILITY_FRAME_TYPE, &rt2x00dev->cap_flags));
        /*
         * Configure the RX antenna.
@@ -811,10 +811,10 @@ static void rt61pci_config_ant(struct rt2x00_dev *rt2x00dev,
        if (rt2x00dev->curr_band == IEEE80211_BAND_5GHZ) {
                sel = antenna_sel_a;
-                lna = test_bit(CONFIG_EXTERNAL_LNA_A, &rt2x00dev->flags);
+                lna = test_bit(CAPABILITY_EXTERNAL_LNA_A, &rt2x00dev->cap_flags);
        } else {
                sel = antenna_sel_bg;
-                lna = test_bit(CONFIG_EXTERNAL_LNA_BG, &rt2x00dev->flags);
+                lna = test_bit(CAPABILITY_EXTERNAL_LNA_BG, &rt2x00dev->cap_flags);
        }
        for (i = 0; i < ARRAY_SIZE(antenna_sel_a); i++)
@@ -834,7 +834,7 @@ static void rt61pci_config_ant(struct rt2x00_dev *rt2x00dev,
        else if (rt2x00_rf(rt2x00dev, RF2527))
                rt61pci_config_antenna_2x(rt2x00dev, ant);
        else if (rt2x00_rf(rt2x00dev, RF2529)) {
-                if (test_bit(CONFIG_DOUBLE_ANTENNA, &rt2x00dev->flags))
+                if (test_bit(CAPABILITY_DOUBLE_ANTENNA, &rt2x00dev->cap_flags))
                        rt61pci_config_antenna_2x(rt2x00dev, ant);
                else
                        rt61pci_config_antenna_2529(rt2x00dev, ant);
@@ -848,13 +848,13 @@ static void rt61pci_config_lna_gain(struct rt2x00_dev *rt2x00dev,
        short lna_gain = 0;
        if (libconf->conf->channel->band == IEEE80211_BAND_2GHZ) {
-                if (test_bit(CONFIG_EXTERNAL_LNA_BG, &rt2x00dev->flags))
+                if (test_bit(CAPABILITY_EXTERNAL_LNA_BG, &rt2x00dev->cap_flags))
                        lna_gain += 14;
                rt2x00_eeprom_read(rt2x00dev, EEPROM_RSSI_OFFSET_BG, &eeprom);
                lna_gain -= rt2x00_get_field16(eeprom, EEPROM_RSSI_OFFSET_BG_1);
        } else {
-                if (test_bit(CONFIG_EXTERNAL_LNA_A, &rt2x00dev->flags))
+                if (test_bit(CAPABILITY_EXTERNAL_LNA_A, &rt2x00dev->cap_flags))
                        lna_gain += 14;
                rt2x00_eeprom_read(rt2x00dev, EEPROM_RSSI_OFFSET_A, &eeprom);
@@ -1050,14 +1050,14 @@ static void rt61pci_link_tuner(struct rt2x00_dev *rt2x00dev,
        if (rt2x00dev->curr_band == IEEE80211_BAND_5GHZ) {
                low_bound = 0x28;
                up_bound = 0x48;
-                if (test_bit(CONFIG_EXTERNAL_LNA_A, &rt2x00dev->flags)) {
+                if (test_bit(CAPABILITY_EXTERNAL_LNA_A, &rt2x00dev->cap_flags)) {
                        low_bound += 0x10;
                        up_bound += 0x10;
                }
        } else {
                low_bound = 0x20;
                up_bound = 0x40;
-                if (test_bit(CONFIG_EXTERNAL_LNA_BG, &rt2x00dev->flags)) {
+                if (test_bit(CAPABILITY_EXTERNAL_LNA_BG, &rt2x00dev->cap_flags)) {
                        low_bound += 0x10;
                        up_bound += 0x10;
                }
@@ -2260,8 +2260,8 @@ static void rt61pci_wakeup(struct rt2x00_dev *rt2x00dev)
        rt61pci_config(rt2x00dev, &libconf, IEEE80211_CONF_CHANGE_PS);
 }
-static void rt61pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,
+static inline void rt61pci_enable_interrupt(struct rt2x00_dev *rt2x00dev,
-                                     struct rt2x00_field32 irq_field)
+                                            struct rt2x00_field32 irq_field)
 {
        u32 reg;
@@ -2313,8 +2313,10 @@ static void rt61pci_tbtt_tasklet(unsigned long data)
 static void rt61pci_rxdone_tasklet(unsigned long data)
 {
        struct rt2x00_dev *rt2x00dev = (struct rt2x00_dev *)data;
-        rt2x00pci_rxdone(rt2x00dev);
+        if (rt2x00pci_rxdone(rt2x00dev))
-        rt61pci_enable_interrupt(rt2x00dev, INT_MASK_CSR_RXDONE);
+                rt2x00pci_rxdone(rt2x00dev);
+        else
+                rt61pci_enable_interrupt(rt2x00dev, INT_MASK_CSR_RXDONE);
 }
 static void rt61pci_autowake_tasklet(unsigned long data)
@@ -2535,7 +2537,7 @@ static int rt61pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
         * Determine number of antennas.
         */
        if (rt2x00_get_field16(eeprom, EEPROM_ANTENNA_NUM) == 2)
-                __set_bit(CONFIG_DOUBLE_ANTENNA, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_DOUBLE_ANTENNA, &rt2x00dev->cap_flags);
        /*
         * Identify default antenna configuration.
@@ -2549,20 +2551,20 @@ static int rt61pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
         * Read the Frame type.
         */
        if (rt2x00_get_field16(eeprom, EEPROM_ANTENNA_FRAME_TYPE))
-                __set_bit(CONFIG_FRAME_TYPE, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_FRAME_TYPE, &rt2x00dev->cap_flags);
        /*
         * Detect if this device has a hardware controlled radio.
         */
        if (rt2x00_get_field16(eeprom, EEPROM_ANTENNA_HARDWARE_RADIO))
-                __set_bit(CONFIG_SUPPORT_HW_BUTTON, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_BUTTON, &rt2x00dev->cap_flags);
        /*
         * Read frequency offset and RF programming sequence.
         */
        rt2x00_eeprom_read(rt2x00dev, EEPROM_FREQ, &eeprom);
        if (rt2x00_get_field16(eeprom, EEPROM_FREQ_SEQ))
-                __set_bit(CONFIG_RF_SEQUENCE, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_RF_SEQUENCE, &rt2x00dev->cap_flags);
        rt2x00dev->freq_offset = rt2x00_get_field16(eeprom, EEPROM_FREQ_OFFSET);
@@ -2572,9 +2574,9 @@ static int rt61pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
        rt2x00_eeprom_read(rt2x00dev, EEPROM_NIC, &eeprom);
        if (rt2x00_get_field16(eeprom, EEPROM_NIC_EXTERNAL_LNA_A))
-                __set_bit(CONFIG_EXTERNAL_LNA_A, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_EXTERNAL_LNA_A, &rt2x00dev->cap_flags);
        if (rt2x00_get_field16(eeprom, EEPROM_NIC_EXTERNAL_LNA_BG))
-                __set_bit(CONFIG_EXTERNAL_LNA_BG, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_EXTERNAL_LNA_BG, &rt2x00dev->cap_flags);
        /*
         * When working with a RF2529 chip without double antenna,
@@ -2582,7 +2584,7 @@ static int rt61pci_init_eeprom(struct rt2x00_dev *rt2x00dev)
         * eeprom word.
         */
        if (rt2x00_rf(rt2x00dev, RF2529) &&
-            !test_bit(CONFIG_DOUBLE_ANTENNA, &rt2x00dev->flags)) {
+            !test_bit(CAPABILITY_DOUBLE_ANTENNA, &rt2x00dev->cap_flags)) {
                rt2x00dev->default_ant.rx =
                    ANTENNA_A + rt2x00_get_field16(eeprom, EEPROM_NIC_RX_FIXED);
                rt2x00dev->default_ant.tx =
@@ -2797,7 +2799,7 @@ static int rt61pci_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
        spec->supported_bands = SUPPORT_BAND_2GHZ;
        spec->supported_rates = SUPPORT_RATE_CCK | SUPPORT_RATE_OFDM;
-        if (!test_bit(CONFIG_RF_SEQUENCE, &rt2x00dev->flags)) {
+        if (!test_bit(CAPABILITY_RF_SEQUENCE, &rt2x00dev->cap_flags)) {
                spec->num_channels = 14;
                spec->channels = rf_vals_noseq;
        } else {
@@ -2867,16 +2869,16 @@ static int rt61pci_probe_hw(struct rt2x00_dev *rt2x00dev)
         * This device has multiple filters for control frames,
         * but has no a separate filter for PS Poll frames.
         */
-        __set_bit(DRIVER_SUPPORT_CONTROL_FILTERS, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_CONTROL_FILTERS, &rt2x00dev->cap_flags);
        /*
         * This device requires firmware and DMA mapped skbs.
         */
-        __set_bit(DRIVER_REQUIRE_FIRMWARE, &rt2x00dev->flags);
+        __set_bit(REQUIRE_FIRMWARE, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_REQUIRE_DMA, &rt2x00dev->flags);
+        __set_bit(REQUIRE_DMA, &rt2x00dev->cap_flags);
        if (!modparam_nohwcrypt)
-                __set_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_SUPPORT_LINK_TUNING, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_LINK_TUNING, &rt2x00dev->cap_flags);
        /*
         * Set the rssi offset.
@@ -2977,6 +2979,9 @@ static const struct ieee80211_ops rt61pci_mac80211_ops = {
        .get_tsf                = rt61pci_get_tsf,
        .rfkill_poll            = rt2x00mac_rfkill_poll,
        .flush                  = rt2x00mac_flush,
+        .set_antenna            = rt2x00mac_set_antenna,
+        .get_antenna            = rt2x00mac_get_antenna,
+        .get_ringparam          = rt2x00mac_get_ringparam,
 };
 static const struct rt2x00lib_ops rt61pci_rt2x00_ops = {
@@ -3001,6 +3006,7 @@ static const struct rt2x00lib_ops rt61pci_rt2x00_ops = {
        .start_queue            = rt61pci_start_queue,
        .kick_queue             = rt61pci_kick_queue,
        .stop_queue             = rt61pci_stop_queue,
+        .flush_queue            = rt2x00pci_flush_queue,
        .write_tx_desc          = rt61pci_write_tx_desc,
        .write_beacon           = rt61pci_write_beacon,
        .clear_beacon           = rt61pci_clear_beacon,
@@ -3058,11 +3064,11 @@ static const struct rt2x00_ops rt61pci_ops = {
 */
 static DEFINE_PCI_DEVICE_TABLE(rt61pci_device_table) = {
        /* RT2561s */
-        { PCI_DEVICE(0x1814, 0x0301), PCI_DEVICE_DATA(&rt61pci_ops) },
+        { PCI_DEVICE(0x1814, 0x0301) },
        /* RT2561 v2 */
-        { PCI_DEVICE(0x1814, 0x0302), PCI_DEVICE_DATA(&rt61pci_ops) },
+        { PCI_DEVICE(0x1814, 0x0302) },
        /* RT2661 */
-        { PCI_DEVICE(0x1814, 0x0401), PCI_DEVICE_DATA(&rt61pci_ops) },
+        { PCI_DEVICE(0x1814, 0x0401) },
        { 0, }
 };
@@ -3077,10 +3083,16 @@ MODULE_FIRMWARE(FIRMWARE_RT2561s);
 MODULE_FIRMWARE(FIRMWARE_RT2661);
 MODULE_LICENSE("GPL");
+static int rt61pci_probe(struct pci_dev *pci_dev,
+                         const struct pci_device_id *id)
+{
+        return rt2x00pci_probe(pci_dev, &rt61pci_ops);
+}
 static struct pci_driver rt61pci_driver = {
        .name           = KBUILD_MODNAME,
        .id_table       = rt61pci_device_table,
-        .probe          = rt2x00pci_probe,
+        .probe          = rt61pci_probe,
        .remove         = __devexit_p(rt2x00pci_remove),
        .suspend        = rt2x00pci_suspend,
        .resume         = rt2x00pci_resume,
diff --git a/drivers/net/wireless/rt2x00/rt73usb.c b/drivers/net/wireless/rt2x00/rt73usb.c
index 02f1148c577e..ad20953cbf05 100644
--- a/drivers/net/wireless/rt2x00/rt73usb.c
+++ b/drivers/net/wireless/rt2x00/rt73usb.c
@@ -595,7 +595,7 @@ static void rt73usb_config_antenna_5x(struct rt2x00_dev *rt2x00dev,
        switch (ant->rx) {
        case ANTENNA_HW_DIVERSITY:
                rt2x00_set_field8(&r4, BBP_R4_RX_ANTENNA_CONTROL, 2);
-                temp = !test_bit(CONFIG_FRAME_TYPE, &rt2x00dev->flags)
+                temp = !test_bit(CAPABILITY_FRAME_TYPE, &rt2x00dev->cap_flags)
                       && (rt2x00dev->curr_band != IEEE80211_BAND_5GHZ);
                rt2x00_set_field8(&r4, BBP_R4_RX_FRAME_END, temp);
                break;
@@ -636,7 +636,7 @@ static void rt73usb_config_antenna_2x(struct rt2x00_dev *rt2x00dev,
        rt2x00_set_field8(&r3, BBP_R3_SMART_MODE, 0);
        rt2x00_set_field8(&r4, BBP_R4_RX_FRAME_END,
-                          !test_bit(CONFIG_FRAME_TYPE, &rt2x00dev->flags));
+                          !test_bit(CAPABILITY_FRAME_TYPE, &rt2x00dev->cap_flags));
        /*
         * Configure the RX antenna.
@@ -709,10 +709,10 @@ static void rt73usb_config_ant(struct rt2x00_dev *rt2x00dev,
        if (rt2x00dev->curr_band == IEEE80211_BAND_5GHZ) {
                sel = antenna_sel_a;
-                lna = test_bit(CONFIG_EXTERNAL_LNA_A, &rt2x00dev->flags);
+                lna = test_bit(CAPABILITY_EXTERNAL_LNA_A, &rt2x00dev->cap_flags);
        } else {
                sel = antenna_sel_bg;
-                lna = test_bit(CONFIG_EXTERNAL_LNA_BG, &rt2x00dev->flags);
+                lna = test_bit(CAPABILITY_EXTERNAL_LNA_BG, &rt2x00dev->cap_flags);
        }
        for (i = 0; i < ARRAY_SIZE(antenna_sel_a); i++)
@@ -740,7 +740,7 @@ static void rt73usb_config_lna_gain(struct rt2x00_dev *rt2x00dev,
        short lna_gain = 0;
        if (libconf->conf->channel->band == IEEE80211_BAND_2GHZ) {
-                if (test_bit(CONFIG_EXTERNAL_LNA_BG, &rt2x00dev->flags))
+                if (test_bit(CAPABILITY_EXTERNAL_LNA_BG, &rt2x00dev->cap_flags))
                        lna_gain += 14;
                rt2x00_eeprom_read(rt2x00dev, EEPROM_RSSI_OFFSET_BG, &eeprom);
@@ -930,7 +930,7 @@ static void rt73usb_link_tuner(struct rt2x00_dev *rt2x00dev,
                low_bound = 0x28;
                up_bound = 0x48;
-                if (test_bit(CONFIG_EXTERNAL_LNA_A, &rt2x00dev->flags)) {
+                if (test_bit(CAPABILITY_EXTERNAL_LNA_A, &rt2x00dev->cap_flags)) {
                        low_bound += 0x10;
                        up_bound += 0x10;
                }
@@ -946,7 +946,7 @@ static void rt73usb_link_tuner(struct rt2x00_dev *rt2x00dev,
                        up_bound = 0x1c;
                }
-                if (test_bit(CONFIG_EXTERNAL_LNA_BG, &rt2x00dev->flags)) {
+                if (test_bit(CAPABILITY_EXTERNAL_LNA_BG, &rt2x00dev->cap_flags)) {
                        low_bound += 0x14;
                        up_bound += 0x10;
                }
@@ -1661,7 +1661,7 @@ static int rt73usb_agc_to_rssi(struct rt2x00_dev *rt2x00dev, int rxd_w1)
        }
        if (rt2x00dev->curr_band == IEEE80211_BAND_5GHZ) {
-                if (test_bit(CONFIG_EXTERNAL_LNA_A, &rt2x00dev->flags)) {
+                if (test_bit(CAPABILITY_EXTERNAL_LNA_A, &rt2x00dev->cap_flags)) {
                        if (lna == 3 || lna == 2)
                                offset += 10;
                } else {
@@ -1899,13 +1899,13 @@ static int rt73usb_init_eeprom(struct rt2x00_dev *rt2x00dev)
         * Read the Frame type.
         */
        if (rt2x00_get_field16(eeprom, EEPROM_ANTENNA_FRAME_TYPE))
-                __set_bit(CONFIG_FRAME_TYPE, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_FRAME_TYPE, &rt2x00dev->cap_flags);
        /*
         * Detect if this device has an hardware controlled radio.
         */
        if (rt2x00_get_field16(eeprom, EEPROM_ANTENNA_HARDWARE_RADIO))
-                __set_bit(CONFIG_SUPPORT_HW_BUTTON, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_BUTTON, &rt2x00dev->cap_flags);
        /*
         * Read frequency offset.
@@ -1919,8 +1919,8 @@ static int rt73usb_init_eeprom(struct rt2x00_dev *rt2x00dev)
        rt2x00_eeprom_read(rt2x00dev, EEPROM_NIC, &eeprom);
        if (rt2x00_get_field16(eeprom, EEPROM_NIC_EXTERNAL_LNA)) {
-                __set_bit(CONFIG_EXTERNAL_LNA_A, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_EXTERNAL_LNA_A, &rt2x00dev->cap_flags);
-                __set_bit(CONFIG_EXTERNAL_LNA_BG, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_EXTERNAL_LNA_BG, &rt2x00dev->cap_flags);
        }
        /*
@@ -2200,16 +2200,16 @@ static int rt73usb_probe_hw(struct rt2x00_dev *rt2x00dev)
         * This device has multiple filters for control frames,
         * but has no a separate filter for PS Poll frames.
         */
-        __set_bit(DRIVER_SUPPORT_CONTROL_FILTERS, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_CONTROL_FILTERS, &rt2x00dev->cap_flags);
        /*
         * This device requires firmware.
         */
-        __set_bit(DRIVER_REQUIRE_FIRMWARE, &rt2x00dev->flags);
+        __set_bit(REQUIRE_FIRMWARE, &rt2x00dev->cap_flags);
        if (!modparam_nohwcrypt)
-                __set_bit(CONFIG_SUPPORT_HW_CRYPTO, &rt2x00dev->flags);
+                __set_bit(CAPABILITY_HW_CRYPTO, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_SUPPORT_LINK_TUNING, &rt2x00dev->flags);
+        __set_bit(CAPABILITY_LINK_TUNING, &rt2x00dev->cap_flags);
-        __set_bit(DRIVER_SUPPORT_WATCHDOG, &rt2x00dev->flags);
+        __set_bit(REQUIRE_PS_AUTOWAKE, &rt2x00dev->cap_flags);
        /*
         * Set the rssi offset.
@@ -2311,6 +2311,9 @@ static const struct ieee80211_ops rt73usb_mac80211_ops = {
        .get_tsf                = rt73usb_get_tsf,
        .rfkill_poll            = rt2x00mac_rfkill_poll,
        .flush                  = rt2x00mac_flush,
+        .set_antenna            = rt2x00mac_set_antenna,
+        .get_antenna            = rt2x00mac_get_antenna,
+        .get_ringparam          = rt2x00mac_get_ringparam,
 };
 static const struct rt2x00lib_ops rt73usb_rt2x00_ops = {
@@ -2389,114 +2392,113 @@ static const struct rt2x00_ops rt73usb_ops = {
 */
 static struct usb_device_id rt73usb_device_table[] = {
        /* AboCom */
-        { USB_DEVICE(0x07b8, 0xb21b), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x07b8, 0xb21b) },
-        { USB_DEVICE(0x07b8, 0xb21c), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x07b8, 0xb21c) },
-        { USB_DEVICE(0x07b8, 0xb21d), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x07b8, 0xb21d) },
-        { USB_DEVICE(0x07b8, 0xb21e), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x07b8, 0xb21e) },
-        { USB_DEVICE(0x07b8, 0xb21f), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x07b8, 0xb21f) },
        /* AL */
-        { USB_DEVICE(0x14b2, 0x3c10), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x14b2, 0x3c10) },
        /* Amigo */
-        { USB_DEVICE(0x148f, 0x9021), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x148f, 0x9021) },
-        { USB_DEVICE(0x0eb0, 0x9021), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0eb0, 0x9021) },
        /* AMIT  */
-        { USB_DEVICE(0x18c5, 0x0002), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x18c5, 0x0002) },
        /* Askey */
-        { USB_DEVICE(0x1690, 0x0722), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x1690, 0x0722) },
        /* ASUS */
-        { USB_DEVICE(0x0b05, 0x1723), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0b05, 0x1723) },
-        { USB_DEVICE(0x0b05, 0x1724), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0b05, 0x1724) },
        /* Belkin */
-        { USB_DEVICE(0x050d, 0x7050), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x050d, 0x705a) },
-        { USB_DEVICE(0x050d, 0x705a), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x050d, 0x905b) },
-        { USB_DEVICE(0x050d, 0x905b), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x050d, 0x905c) },
-        { USB_DEVICE(0x050d, 0x905c), USB_DEVICE_DATA(&rt73usb_ops) },
        /* Billionton */
-        { USB_DEVICE(0x1631, 0xc019), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x1631, 0xc019) },
-        { USB_DEVICE(0x08dd, 0x0120), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x08dd, 0x0120) },
        /* Buffalo */
-        { USB_DEVICE(0x0411, 0x00d8), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0411, 0x00d8) },
-        { USB_DEVICE(0x0411, 0x00d9), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0411, 0x00d9) },
-        { USB_DEVICE(0x0411, 0x00f4), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0411, 0x00f4) },
-        { USB_DEVICE(0x0411, 0x0116), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0411, 0x0116) },
-        { USB_DEVICE(0x0411, 0x0119), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0411, 0x0119) },
-        { USB_DEVICE(0x0411, 0x0137), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0411, 0x0137) },
        /* CEIVA */
-        { USB_DEVICE(0x178d, 0x02be), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x178d, 0x02be) },
        /* CNet */
-        { USB_DEVICE(0x1371, 0x9022), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x1371, 0x9022) },
-        { USB_DEVICE(0x1371, 0x9032), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x1371, 0x9032) },
        /* Conceptronic */
-        { USB_DEVICE(0x14b2, 0x3c22), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x14b2, 0x3c22) },
        /* Corega */
-        { USB_DEVICE(0x07aa, 0x002e), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x07aa, 0x002e) },
        /* D-Link */
-        { USB_DEVICE(0x07d1, 0x3c03), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c03) },
-        { USB_DEVICE(0x07d1, 0x3c04), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c04) },
-        { USB_DEVICE(0x07d1, 0x3c06), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c06) },
-        { USB_DEVICE(0x07d1, 0x3c07), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x07d1, 0x3c07) },
        /* Edimax */
-        { USB_DEVICE(0x7392, 0x7318), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x7392, 0x7318) },
-        { USB_DEVICE(0x7392, 0x7618), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x7392, 0x7618) },
        /* EnGenius */
-        { USB_DEVICE(0x1740, 0x3701), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x1740, 0x3701) },
        /* Gemtek */
-        { USB_DEVICE(0x15a9, 0x0004), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x15a9, 0x0004) },
        /* Gigabyte */
-        { USB_DEVICE(0x1044, 0x8008), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x1044, 0x8008) },
-        { USB_DEVICE(0x1044, 0x800a), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x1044, 0x800a) },
        /* Huawei-3Com */
-        { USB_DEVICE(0x1472, 0x0009), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x1472, 0x0009) },
        /* Hercules */
-        { USB_DEVICE(0x06f8, 0xe002), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x06f8, 0xe002) },
-        { USB_DEVICE(0x06f8, 0xe010), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x06f8, 0xe010) },
-        { USB_DEVICE(0x06f8, 0xe020), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x06f8, 0xe020) },
        /* Linksys */
-        { USB_DEVICE(0x13b1, 0x0020), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x13b1, 0x0020) },
-        { USB_DEVICE(0x13b1, 0x0023), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x13b1, 0x0023) },
-        { USB_DEVICE(0x13b1, 0x0028), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x13b1, 0x0028) },
        /* MSI */
-        { USB_DEVICE(0x0db0, 0x4600), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0db0, 0x4600) },
-        { USB_DEVICE(0x0db0, 0x6877), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0db0, 0x6877) },
-        { USB_DEVICE(0x0db0, 0x6874), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0db0, 0x6874) },
-        { USB_DEVICE(0x0db0, 0xa861), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0db0, 0xa861) },
-        { USB_DEVICE(0x0db0, 0xa874), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0db0, 0xa874) },
        /* Ovislink */
-        { USB_DEVICE(0x1b75, 0x7318), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x1b75, 0x7318) },
        /* Ralink */
-        { USB_DEVICE(0x04bb, 0x093d), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x04bb, 0x093d) },
-        { USB_DEVICE(0x148f, 0x2573), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x148f, 0x2573) },
-        { USB_DEVICE(0x148f, 0x2671), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x148f, 0x2671) },
-        { USB_DEVICE(0x0812, 0x3101), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0812, 0x3101) },
        /* Qcom */
-        { USB_DEVICE(0x18e8, 0x6196), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x18e8, 0x6196) },
-        { USB_DEVICE(0x18e8, 0x6229), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x18e8, 0x6229) },
-        { USB_DEVICE(0x18e8, 0x6238), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x18e8, 0x6238) },
        /* Samsung */
-        { USB_DEVICE(0x04e8, 0x4471), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x04e8, 0x4471) },
        /* Senao */
-        { USB_DEVICE(0x1740, 0x7100), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x1740, 0x7100) },
        /* Sitecom */
-        { USB_DEVICE(0x0df6, 0x0024), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0df6, 0x0024) },
-        { USB_DEVICE(0x0df6, 0x0027), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0df6, 0x0027) },
-        { USB_DEVICE(0x0df6, 0x002f), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0df6, 0x002f) },
-        { USB_DEVICE(0x0df6, 0x90ac), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0df6, 0x90ac) },
-        { USB_DEVICE(0x0df6, 0x9712), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0df6, 0x9712) },
        /* Surecom */
-        { USB_DEVICE(0x0769, 0x31f3), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0769, 0x31f3) },
        /* Tilgin */
-        { USB_DEVICE(0x6933, 0x5001), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x6933, 0x5001) },
        /* Philips */
-        { USB_DEVICE(0x0471, 0x200a), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0471, 0x200a) },
        /* Planex */
-        { USB_DEVICE(0x2019, 0xab01), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x2019, 0xab01) },
-        { USB_DEVICE(0x2019, 0xab50), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x2019, 0xab50) },
        /* WideTell */
-        { USB_DEVICE(0x7167, 0x3840), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x7167, 0x3840) },
        /* Zcom */
-        { USB_DEVICE(0x0cde, 0x001c), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0cde, 0x001c) },
        /* ZyXEL */
-        { USB_DEVICE(0x0586, 0x3415), USB_DEVICE_DATA(&rt73usb_ops) },
+        { USB_DEVICE(0x0586, 0x3415) },
        { 0, }
 };
@@ -2508,10 +2510,16 @@ MODULE_DEVICE_TABLE(usb, rt73usb_device_table);
 MODULE_FIRMWARE(FIRMWARE_RT2571);
 MODULE_LICENSE("GPL");
+static int rt73usb_probe(struct usb_interface *usb_intf,
+                         const struct usb_device_id *id)
+{
+        return rt2x00usb_probe(usb_intf, &rt73usb_ops);
+}
 static struct usb_driver rt73usb_driver = {
        .name           = KBUILD_MODNAME,
        .id_table       = rt73usb_device_table,
-        .probe          = rt2x00usb_probe,
+        .probe          = rt73usb_probe,
        .disconnect     = rt2x00usb_disconnect,
        .suspend        = rt2x00usb_suspend,
        .resume         = rt2x00usb_resume,
diff --git a/drivers/net/wireless/rtlwifi/Kconfig b/drivers/net/wireless/rtlwifi/Kconfig
index ce49e0ce7cad..5aee8b22d74e 100644
--- a/drivers/net/wireless/rtlwifi/Kconfig
+++ b/drivers/net/wireless/rtlwifi/Kconfig
@@ -10,6 +10,17 @@ config RTL8192CE
        If you choose to build it as a module, it will be called rtl8192ce
+config RTL8192SE
+        tristate "Realtek RTL8192SE/RTL8191SE PCIe Wireless Network Adapter"
+        depends on MAC80211 && EXPERIMENTAL
+        select FW_LOADER
+        select RTLWIFI
+        ---help---
+        This is the driver for Realtek RTL8192SE/RTL8191SE 802.11n PCIe
+        wireless network adapters.
+        If you choose to build it as a module, it will be called rtl8192se
 config RTL8192CU
        tristate "Realtek RTL8192CU/RTL8188CU USB Wireless Network Adapter"
        depends on MAC80211 && USB && EXPERIMENTAL
@@ -24,10 +35,10 @@ config RTL8192CU
 config RTLWIFI
        tristate
-        depends on RTL8192CE || RTL8192CU
+        depends on RTL8192CE || RTL8192CU || RTL8192SE
        default m
 config RTL8192C_COMMON
        tristate
-        depends on RTL8192CE || RTL8192CU
+        depends on RTL8192CE || RTL8192CU || RTL8192SE
        default m
diff --git a/drivers/net/wireless/rtlwifi/Makefile b/drivers/net/wireless/rtlwifi/Makefile
index ec9393f24799..7acce83c3785 100644
--- a/drivers/net/wireless/rtlwifi/Makefile
+++ b/drivers/net/wireless/rtlwifi/Makefile
@@ -22,5 +22,6 @@ endif
 obj-$(CONFIG_RTL8192C_COMMON)   += rtl8192c/
 obj-$(CONFIG_RTL8192CE)         += rtl8192ce/
 obj-$(CONFIG_RTL8192CU)         += rtl8192cu/
+obj-$(CONFIG_RTL8192SE)         += rtl8192se/
 ccflags-y += -D__CHECK_ENDIAN__
diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c
index 0d7d93e1d398..ccb6da38fe22 100644
--- a/drivers/net/wireless/rtlwifi/base.c
+++ b/drivers/net/wireless/rtlwifi/base.c
@@ -50,8 +50,9 @@
 *3) functions called by core.c
 *4) wq & timer callback functions
 *5) frame process functions
- *6) sysfs functions
+ *6) IOT functions
- *7) ...
+ *7) sysfs functions
+ *8) ...
 */
 /*********************************************************
@@ -59,7 +60,7 @@
 * mac80211 init functions
 *
 *********************************************************/
-static struct ieee80211_channel rtl_channeltable[] = {
+static struct ieee80211_channel rtl_channeltable_2g[] = {
        {.center_freq = 2412, .hw_value = 1,},
        {.center_freq = 2417, .hw_value = 2,},
        {.center_freq = 2422, .hw_value = 3,},
@@ -76,7 +77,34 @@ static struct ieee80211_channel rtl_channeltable[] = {
        {.center_freq = 2484, .hw_value = 14,},
 };
-static struct ieee80211_rate rtl_ratetable[] = {
+static struct ieee80211_channel rtl_channeltable_5g[] = {
+        {.center_freq = 5180, .hw_value = 36,},
+        {.center_freq = 5200, .hw_value = 40,},
+        {.center_freq = 5220, .hw_value = 44,},
+        {.center_freq = 5240, .hw_value = 48,},
+        {.center_freq = 5260, .hw_value = 52,},
+        {.center_freq = 5280, .hw_value = 56,},
+        {.center_freq = 5300, .hw_value = 60,},
+        {.center_freq = 5320, .hw_value = 64,},
+        {.center_freq = 5500, .hw_value = 100,},
+        {.center_freq = 5520, .hw_value = 104,},
+        {.center_freq = 5540, .hw_value = 108,},
+        {.center_freq = 5560, .hw_value = 112,},
+        {.center_freq = 5580, .hw_value = 116,},
+        {.center_freq = 5600, .hw_value = 120,},
+        {.center_freq = 5620, .hw_value = 124,},
+        {.center_freq = 5640, .hw_value = 128,},
+        {.center_freq = 5660, .hw_value = 132,},
+        {.center_freq = 5680, .hw_value = 136,},
+        {.center_freq = 5700, .hw_value = 140,},
+        {.center_freq = 5745, .hw_value = 149,},
+        {.center_freq = 5765, .hw_value = 153,},
+        {.center_freq = 5785, .hw_value = 157,},
+        {.center_freq = 5805, .hw_value = 161,},
+        {.center_freq = 5825, .hw_value = 165,},
+};
+static struct ieee80211_rate rtl_ratetable_2g[] = {
        {.bitrate = 10, .hw_value = 0x00,},
        {.bitrate = 20, .hw_value = 0x01,},
        {.bitrate = 55, .hw_value = 0x02,},
@@ -91,18 +119,57 @@ static struct ieee80211_rate rtl_ratetable[] = {
        {.bitrate = 540, .hw_value = 0x0b,},
 };
+static struct ieee80211_rate rtl_ratetable_5g[] = {
+        {.bitrate = 60, .hw_value = 0x04,},
+        {.bitrate = 90, .hw_value = 0x05,},
+        {.bitrate = 120, .hw_value = 0x06,},
+        {.bitrate = 180, .hw_value = 0x07,},
+        {.bitrate = 240, .hw_value = 0x08,},
+        {.bitrate = 360, .hw_value = 0x09,},
+        {.bitrate = 480, .hw_value = 0x0a,},
+        {.bitrate = 540, .hw_value = 0x0b,},
+};
 static const struct ieee80211_supported_band rtl_band_2ghz = {
        .band = IEEE80211_BAND_2GHZ,
-        .channels = rtl_channeltable,
+        .channels = rtl_channeltable_2g,
-        .n_channels = ARRAY_SIZE(rtl_channeltable),
+        .n_channels = ARRAY_SIZE(rtl_channeltable_2g),
-        .bitrates = rtl_ratetable,
+        .bitrates = rtl_ratetable_2g,
-        .n_bitrates = ARRAY_SIZE(rtl_ratetable),
+        .n_bitrates = ARRAY_SIZE(rtl_ratetable_2g),
        .ht_cap = {0},
 };
+static struct ieee80211_supported_band rtl_band_5ghz = {
+        .band = IEEE80211_BAND_5GHZ,
+        .channels = rtl_channeltable_5g,
+        .n_channels = ARRAY_SIZE(rtl_channeltable_5g),
+        .bitrates = rtl_ratetable_5g,
+        .n_bitrates = ARRAY_SIZE(rtl_ratetable_5g),
+        .ht_cap = {0},
+};
+static const u8 tid_to_ac[] = {
+        2, /* IEEE80211_AC_BE */
+        3, /* IEEE80211_AC_BK */
+        3, /* IEEE80211_AC_BK */
+        2, /* IEEE80211_AC_BE */
+        1, /* IEEE80211_AC_VI */
+        1, /* IEEE80211_AC_VI */
+        0, /* IEEE80211_AC_VO */
+        0, /* IEEE80211_AC_VO */
+};
+u8 rtl_tid_to_ac(struct ieee80211_hw *hw, u8 tid)
+{
+        return tid_to_ac[tid];
+}
 static void _rtl_init_hw_ht_capab(struct ieee80211_hw *hw,
                                  struct ieee80211_sta_ht_cap *ht_cap)
 {
@@ -115,6 +182,9 @@ static void _rtl_init_hw_ht_capab(struct ieee80211_hw *hw,
            IEEE80211_HT_CAP_SGI_20 |
            IEEE80211_HT_CAP_DSSSCCK40 | IEEE80211_HT_CAP_MAX_AMSDU;
+        if (rtlpriv->rtlhal.disable_amsdu_8k)
+                ht_cap->cap &= ~IEEE80211_HT_CAP_MAX_AMSDU;
        /*
         *Maximum length of AMPDU that the STA can receive.
         *Length = 2 ^ (13 + max_ampdu_length_exp) - 1 (octets)
@@ -159,37 +229,99 @@ static void _rtl_init_hw_ht_capab(struct ieee80211_hw *hw,
 static void _rtl_init_mac80211(struct ieee80211_hw *hw)
 {
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtlpriv);
        struct rtl_mac *rtlmac = rtl_mac(rtl_priv(hw));
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
        struct ieee80211_supported_band *sband;
-        /* <1> use  mac->bands as mem for hw->wiphy->bands */
-        sband = &(rtlmac->bands[IEEE80211_BAND_2GHZ]);
-        /*
+        if (rtlhal->macphymode == SINGLEMAC_SINGLEPHY && rtlhal->bandset ==
-         * <2> set hw->wiphy->bands[IEEE80211_BAND_2GHZ]
+            BAND_ON_BOTH) {
-         * to default value(1T1R)
+                /* 1: 2.4 G bands */
-         */
+                /* <1> use  mac->bands as mem for hw->wiphy->bands */
-        memcpy(&(rtlmac->bands[IEEE80211_BAND_2GHZ]), &rtl_band_2ghz,
+                sband = &(rtlmac->bands[IEEE80211_BAND_2GHZ]);
-               sizeof(struct ieee80211_supported_band));
+                /* <2> set hw->wiphy->bands[IEEE80211_BAND_2GHZ]
+                 * to default value(1T1R) */
+                memcpy(&(rtlmac->bands[IEEE80211_BAND_2GHZ]), &rtl_band_2ghz,
+                                sizeof(struct ieee80211_supported_band));
-        /* <3> init ht cap base on ant_num */
+                /* <3> init ht cap base on ant_num */
-        _rtl_init_hw_ht_capab(hw, &sband->ht_cap);
+                _rtl_init_hw_ht_capab(hw, &sband->ht_cap);
-        /* <4> set mac->sband to wiphy->sband */
+                /* <4> set mac->sband to wiphy->sband */
-        hw->wiphy->bands[IEEE80211_BAND_2GHZ] = sband;
+                hw->wiphy->bands[IEEE80211_BAND_2GHZ] = sband;
+                /* 2: 5 G bands */
+                /* <1> use  mac->bands as mem for hw->wiphy->bands */
+                sband = &(rtlmac->bands[IEEE80211_BAND_5GHZ]);
+                /* <2> set hw->wiphy->bands[IEEE80211_BAND_5GHZ]
+                 * to default value(1T1R) */
+                memcpy(&(rtlmac->bands[IEEE80211_BAND_5GHZ]), &rtl_band_5ghz,
+                                sizeof(struct ieee80211_supported_band));
+                /* <3> init ht cap base on ant_num */
+                _rtl_init_hw_ht_capab(hw, &sband->ht_cap);
+                /* <4> set mac->sband to wiphy->sband */
+                hw->wiphy->bands[IEEE80211_BAND_5GHZ] = sband;
+        } else {
+                if (rtlhal->current_bandtype == BAND_ON_2_4G) {
+                        /* <1> use  mac->bands as mem for hw->wiphy->bands */
+                        sband = &(rtlmac->bands[IEEE80211_BAND_2GHZ]);
+                        /* <2> set hw->wiphy->bands[IEEE80211_BAND_2GHZ]
+                         * to default value(1T1R) */
+                        memcpy(&(rtlmac->bands[IEEE80211_BAND_2GHZ]),
+                                 &rtl_band_2ghz,
+                                 sizeof(struct ieee80211_supported_band));
+                        /* <3> init ht cap base on ant_num */
+                        _rtl_init_hw_ht_capab(hw, &sband->ht_cap);
+                        /* <4> set mac->sband to wiphy->sband */
+                        hw->wiphy->bands[IEEE80211_BAND_2GHZ] = sband;
+                } else if (rtlhal->current_bandtype == BAND_ON_5G) {
+                        /* <1> use  mac->bands as mem for hw->wiphy->bands */
+                        sband = &(rtlmac->bands[IEEE80211_BAND_5GHZ]);
+                        /* <2> set hw->wiphy->bands[IEEE80211_BAND_5GHZ]
+                         * to default value(1T1R) */
+                        memcpy(&(rtlmac->bands[IEEE80211_BAND_5GHZ]),
+                                 &rtl_band_5ghz,
+                                 sizeof(struct ieee80211_supported_band));
+                        /* <3> init ht cap base on ant_num */
+                        _rtl_init_hw_ht_capab(hw, &sband->ht_cap);
+                        /* <4> set mac->sband to wiphy->sband */
+                        hw->wiphy->bands[IEEE80211_BAND_5GHZ] = sband;
+                } else {
+                        RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
+                                 ("Err BAND %d\n",
+                                 rtlhal->current_bandtype));
+                }
+        }
        /* <5> set hw caps */
        hw->flags = IEEE80211_HW_SIGNAL_DBM |
            IEEE80211_HW_RX_INCLUDES_FCS |
-            IEEE80211_HW_BEACON_FILTER | IEEE80211_HW_AMPDU_AGGREGATION | /*PS*/
+            IEEE80211_HW_BEACON_FILTER |
-            /*IEEE80211_HW_SUPPORTS_PS | */
+            IEEE80211_HW_AMPDU_AGGREGATION |
-            /*IEEE80211_HW_PS_NULLFUNC_STACK | */
-            /*IEEE80211_HW_SUPPORTS_DYNAMIC_PS | */
            IEEE80211_HW_REPORTS_TX_ACK_STATUS | 0;
+        /* swlps or hwlps has been set in diff chip in init_sw_vars */
+        if (rtlpriv->psc.swctrl_lps)
+                hw->flags |= IEEE80211_HW_SUPPORTS_PS |
+                        IEEE80211_HW_PS_NULLFUNC_STACK |
+                        /* IEEE80211_HW_SUPPORTS_DYNAMIC_PS | */
+                        0;
        hw->wiphy->interface_modes =
-            BIT(NL80211_IFTYPE_STATION) | BIT(NL80211_IFTYPE_ADHOC);
+            BIT(NL80211_IFTYPE_AP) |
+            BIT(NL80211_IFTYPE_STATION) |
+            BIT(NL80211_IFTYPE_ADHOC);
        hw->wiphy->rts_threshold = 2347;
@@ -199,9 +331,10 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
        /* TODO: Correct this value for our hw */
        /* TODO: define these hard code value */
        hw->channel_change_time = 100;
-        hw->max_listen_interval = 5;
+        hw->max_listen_interval = 10;
        hw->max_rate_tries = 4;
        /* hw->max_rates = 1; */
+        hw->sta_data_size = sizeof(struct rtl_sta_info);
        /* <6> mac address */
        if (is_valid_ether_addr(rtlefuse->dev_addr)) {
@@ -230,6 +363,10 @@ static void _rtl_init_deferred_work(struct ieee80211_hw *hw)
                          (void *)rtl_watchdog_wq_callback);
        INIT_DELAYED_WORK(&rtlpriv->works.ips_nic_off_wq,
                          (void *)rtl_ips_nic_off_wq_callback);
+        INIT_DELAYED_WORK(&rtlpriv->works.ps_work,
+                          (void *)rtl_swlps_wq_callback);
+        INIT_DELAYED_WORK(&rtlpriv->works.ps_rfon_wq,
+                          (void *)rtl_swlps_rfon_wq_callback);
 }
@@ -241,6 +378,8 @@ void rtl_deinit_deferred_work(struct ieee80211_hw *hw)
        cancel_delayed_work(&rtlpriv->works.watchdog_wq);
        cancel_delayed_work(&rtlpriv->works.ips_nic_off_wq);
+        cancel_delayed_work(&rtlpriv->works.ps_work);
+        cancel_delayed_work(&rtlpriv->works.ps_rfon_wq);
 }
 void rtl_init_rfkill(struct ieee80211_hw *hw)
@@ -251,14 +390,16 @@ void rtl_init_rfkill(struct ieee80211_hw *hw)
        bool blocked;
        u8 valid = 0;
-        radio_state = rtlpriv->cfg->ops->radio_onoff_checking(hw, &valid);
+        /*set init state to on */
+        rtlpriv->rfkill.rfkill_state = 1;
+        wiphy_rfkill_set_hw_state(hw->wiphy, 0);
-        /*set init state to that of switch */
+        radio_state = rtlpriv->cfg->ops->radio_onoff_checking(hw, &valid);
-        rtlpriv->rfkill.rfkill_state = radio_state;
-        printk(KERN_INFO "rtlwifi: wireless switch is %s\n",
-               rtlpriv->rfkill.rfkill_state ? "on" : "off");
        if (valid) {
+                printk(KERN_INFO "rtlwifi: wireless switch is %s\n",
+                                rtlpriv->rfkill.rfkill_state ? "on" : "off");
                rtlpriv->rfkill.rfkill_state = radio_state;
                blocked = (rtlpriv->rfkill.rfkill_state == 1) ? 0 : 1;
@@ -308,6 +449,8 @@ int rtl_init_core(struct ieee80211_hw *hw)
        spin_lock_init(&rtlpriv->locks.rf_ps_lock);
        spin_lock_init(&rtlpriv->locks.rf_lock);
        spin_lock_init(&rtlpriv->locks.lps_lock);
+        spin_lock_init(&rtlpriv->locks.waitq_lock);
+        spin_lock_init(&rtlpriv->locks.cck_and_rw_pagea_lock);
        rtlmac->link_state = MAC80211_NOLINK;
@@ -327,12 +470,6 @@ void rtl_init_rx_config(struct ieee80211_hw *hw)
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        rtlpriv->cfg->ops->get_hw_reg(hw, HW_VAR_RCR, (u8 *) (&mac->rx_conf));
-        rtlpriv->cfg->ops->get_hw_reg(hw, HW_VAR_MGT_FILTER,
-                                      (u8 *) (&mac->rx_mgt_filter));
-        rtlpriv->cfg->ops->get_hw_reg(hw, HW_VAR_CTRL_FILTER,
-                                      (u8 *) (&mac->rx_ctrl_filter));
-        rtlpriv->cfg->ops->get_hw_reg(hw, HW_VAR_DATA_FILTER,
-                                      (u8 *) (&mac->rx_data_filter));
 }
 /*********************************************************
@@ -359,28 +496,40 @@ static void _rtl_qurey_shortpreamble_mode(struct ieee80211_hw *hw,
 }
 static void _rtl_query_shortgi(struct ieee80211_hw *hw,
+                               struct ieee80211_sta *sta,
                               struct rtl_tcb_desc *tcb_desc,
                               struct ieee80211_tx_info *info)
 {
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        u8 rate_flag = info->control.rates[0].flags;
+        u8 sgi_40 = 0, sgi_20 = 0, bw_40 = 0;
        tcb_desc->use_shortgi = false;
-        if (!mac->ht_enable)
+        if (sta == NULL)
+                return;
+        sgi_40 = sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40;
+        sgi_20 = sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20;
+        if (!(sta->ht_cap.ht_supported))
                return;
-        if (!mac->sgi_40 && !mac->sgi_20)
+        if (!sgi_40 && !sgi_20)
                return;
-        if ((mac->bw_40 == true) && mac->sgi_40)
+        if (mac->opmode == NL80211_IFTYPE_STATION)
+                bw_40 = mac->bw_40;
+        else if (mac->opmode == NL80211_IFTYPE_AP ||
+                mac->opmode == NL80211_IFTYPE_ADHOC)
+                bw_40 = sta->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+        if ((bw_40 == true) && sgi_40)
                tcb_desc->use_shortgi = true;
-        else if ((mac->bw_40 == false) && mac->sgi_20)
+        else if ((bw_40 == false) && sgi_20)
                tcb_desc->use_shortgi = true;
        if (!(rate_flag & IEEE80211_TX_RC_SHORT_GI))
                tcb_desc->use_shortgi = false;
 }
 static void _rtl_query_protection_mode(struct ieee80211_hw *hw,
@@ -408,19 +557,25 @@ static void _rtl_query_protection_mode(struct ieee80211_hw *hw,
                tcb_desc->rts_enable = true;
                tcb_desc->rts_rate = rtlpriv->cfg->maps[RTL_RC_OFDM_RATE24M];
        }
 }
 static void _rtl_txrate_selectmode(struct ieee80211_hw *hw,
+                                   struct ieee80211_sta *sta,
                                   struct rtl_tcb_desc *tcb_desc)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_sta_info *sta_entry = NULL;
+        u8 ratr_index = 7;
+        if (sta) {
+                sta_entry = (struct rtl_sta_info *) sta->drv_priv;
+                ratr_index = sta_entry->ratr_index;
+        }
        if (!tcb_desc->disable_ratefallback || !tcb_desc->use_driver_rate) {
-                if (mac->opmode == NL80211_IFTYPE_STATION)
+                if (mac->opmode == NL80211_IFTYPE_STATION) {
                        tcb_desc->ratr_index = 0;
-                else if (mac->opmode == NL80211_IFTYPE_ADHOC) {
+                } else if (mac->opmode == NL80211_IFTYPE_ADHOC) {
                        if (tcb_desc->multicast || tcb_desc->broadcast) {
                                tcb_desc->hw_rate =
                                    rtlpriv->cfg->maps[RTL_RC_CCK_RATE2M];
@@ -428,36 +583,61 @@ static void _rtl_txrate_selectmode(struct ieee80211_hw *hw,
                        } else {
                                /* TODO */
                        }
+                        tcb_desc->ratr_index = ratr_index;
+                } else if (mac->opmode == NL80211_IFTYPE_AP) {
+                        tcb_desc->ratr_index = ratr_index;
                }
        }
        if (rtlpriv->dm.useramask) {
                /* TODO we will differentiate adhoc and station futrue  */
-                tcb_desc->mac_id = 0;
+                if (mac->opmode == NL80211_IFTYPE_STATION) {
+                        tcb_desc->mac_id = 0;
-                if ((mac->mode == WIRELESS_MODE_N_24G) ||
-                    (mac->mode == WIRELESS_MODE_N_5G)) {
+                        if (mac->mode == WIRELESS_MODE_N_24G)
-                        tcb_desc->ratr_index = RATR_INX_WIRELESS_NGB;
+                                tcb_desc->ratr_index = RATR_INX_WIRELESS_NGB;
-                } else if (mac->mode & WIRELESS_MODE_G) {
+                        else if (mac->mode == WIRELESS_MODE_N_5G)
-                        tcb_desc->ratr_index = RATR_INX_WIRELESS_GB;
+                                tcb_desc->ratr_index = RATR_INX_WIRELESS_NG;
-                } else if (mac->mode & WIRELESS_MODE_B) {
+                        else if (mac->mode & WIRELESS_MODE_G)
-                        tcb_desc->ratr_index = RATR_INX_WIRELESS_B;
+                                tcb_desc->ratr_index = RATR_INX_WIRELESS_GB;
+                        else if (mac->mode & WIRELESS_MODE_B)
+                                tcb_desc->ratr_index = RATR_INX_WIRELESS_B;
+                        else if (mac->mode & WIRELESS_MODE_A)
+                                tcb_desc->ratr_index = RATR_INX_WIRELESS_G;
+                } else if (mac->opmode == NL80211_IFTYPE_AP ||
+                        mac->opmode == NL80211_IFTYPE_ADHOC) {
+                        if (NULL != sta) {
+                                if (sta->aid > 0)
+                                        tcb_desc->mac_id = sta->aid + 1;
+                                else
+                                        tcb_desc->mac_id = 1;
+                        } else {
+                                tcb_desc->mac_id = 0;
+                        }
                }
        }
 }
 static void _rtl_query_bandwidth_mode(struct ieee80211_hw *hw,
+                                      struct ieee80211_sta *sta,
                                      struct rtl_tcb_desc *tcb_desc)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        tcb_desc->packet_bw = false;
+        if (!sta)
-        if (!mac->bw_40 || !mac->ht_enable)
                return;
+        if (mac->opmode == NL80211_IFTYPE_AP ||
+            mac->opmode == NL80211_IFTYPE_ADHOC) {
+                if (!(sta->ht_cap.ht_supported) ||
+                    !(sta->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40))
+                        return;
+        } else if (mac->opmode == NL80211_IFTYPE_STATION) {
+                if (!mac->bw_40 || !(sta->ht_cap.ht_supported))
+                        return;
+        }
        if (tcb_desc->multicast || tcb_desc->broadcast)
                return;
@@ -484,22 +664,21 @@ static u8 _rtl_get_highest_n_rate(struct ieee80211_hw *hw)
 void rtl_get_tcb_desc(struct ieee80211_hw *hw,
                      struct ieee80211_tx_info *info,
+                      struct ieee80211_sta *sta,
                      struct sk_buff *skb, struct rtl_tcb_desc *tcb_desc)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_mac *rtlmac = rtl_mac(rtl_priv(hw));
-        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data);
+        struct ieee80211_hdr *hdr = rtl_get_hdr(skb);
        struct ieee80211_rate *txrate;
        __le16 fc = hdr->frame_control;
-        memset(tcb_desc, 0, sizeof(struct rtl_tcb_desc));
+        txrate = ieee80211_get_tx_rate(hw, info);
+        tcb_desc->hw_rate = txrate->hw_value;
        if (ieee80211_is_data(fc)) {
-                txrate = ieee80211_get_tx_rate(hw, info);
-                tcb_desc->hw_rate = txrate->hw_value;
                /*
-                 *we set data rate RTL_RC_CCK_RATE1M
+                 *we set data rate INX 0
                 *in rtl_rc.c   if skb is special data or
                 *mgt which need low data rate.
                 */
@@ -508,12 +687,11 @@ void rtl_get_tcb_desc(struct ieee80211_hw *hw,
                 *So tcb_desc->hw_rate is just used for
                 *special data and mgt frames
                 */
-                if (tcb_desc->hw_rate < rtlpriv->cfg->maps[RTL_RC_CCK_RATE11M]) {
+                if (info->control.rates[0].idx == 0 &&
+                                ieee80211_is_nullfunc(fc)) {
                        tcb_desc->use_driver_rate = true;
-                        tcb_desc->ratr_index = 7;
+                        tcb_desc->ratr_index = RATR_INX_WIRELESS_MC;
-                        tcb_desc->hw_rate =
-                            rtlpriv->cfg->maps[RTL_RC_CCK_RATE1M];
                        tcb_desc->disable_ratefallback = 1;
                } else {
                        /*
@@ -523,7 +701,7 @@ void rtl_get_tcb_desc(struct ieee80211_hw *hw,
                         *and N rate will all be controlled by FW
                         *when tcb_desc->use_driver_rate = false
                         */
-                        if (rtlmac->ht_enable) {
+                        if (sta && (sta->ht_cap.ht_supported)) {
                                tcb_desc->hw_rate = _rtl_get_highest_n_rate(hw);
                        } else {
                                if (rtlmac->mode == WIRELESS_MODE_B) {
@@ -541,43 +719,25 @@ void rtl_get_tcb_desc(struct ieee80211_hw *hw,
                else if (is_broadcast_ether_addr(ieee80211_get_DA(hdr)))
                        tcb_desc->broadcast = 1;
-                _rtl_txrate_selectmode(hw, tcb_desc);
+                _rtl_txrate_selectmode(hw, sta, tcb_desc);
-                _rtl_query_bandwidth_mode(hw, tcb_desc);
+                _rtl_query_bandwidth_mode(hw, sta, tcb_desc);
                _rtl_qurey_shortpreamble_mode(hw, tcb_desc, info);
-                _rtl_query_shortgi(hw, tcb_desc, info);
+                _rtl_query_shortgi(hw, sta, tcb_desc, info);
                _rtl_query_protection_mode(hw, tcb_desc, info);
        } else {
                tcb_desc->use_driver_rate = true;
-                tcb_desc->ratr_index = 7;
+                tcb_desc->ratr_index = RATR_INX_WIRELESS_MC;
                tcb_desc->disable_ratefallback = 1;
                tcb_desc->mac_id = 0;
+                tcb_desc->packet_bw = false;
-                tcb_desc->hw_rate = rtlpriv->cfg->maps[RTL_RC_CCK_RATE1M];
        }
 }
 EXPORT_SYMBOL(rtl_get_tcb_desc);
-bool rtl_tx_mgmt_proc(struct ieee80211_hw *hw, struct sk_buff *skb)
-{
-        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
-        struct rtl_priv *rtlpriv = rtl_priv(hw);
-        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data);
-        __le16 fc = hdr->frame_control;
-        if (ieee80211_is_auth(fc)) {
-                RT_TRACE(rtlpriv, COMP_SEND, DBG_DMESG, ("MAC80211_LINKING\n"));
-                rtl_ips_nic_on(hw);
-                mac->link_state = MAC80211_LINKING;
-        }
-        return true;
-}
 bool rtl_action_proc(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx)
 {
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
-        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data);
+        struct ieee80211_hdr *hdr = rtl_get_hdr(skb);
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        __le16 fc = hdr->frame_control;
        u8 *act = (u8 *) (((u8 *) skb->data + MAC80211_3ADDR_LEN));
@@ -622,22 +782,20 @@ bool rtl_action_proc(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx)
 u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data);
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
-        __le16 fc = hdr->frame_control;
+        __le16 fc = rtl_get_fc(skb);
        u16 ether_type;
        u8 mac_hdr_len = ieee80211_get_hdrlen_from_skb(skb);
        const struct iphdr *ip;
        if (!ieee80211_is_data(fc))
-                goto end;
+                return false;
-        if (ieee80211_is_nullfunc(fc))
-                return true;
        ip = (struct iphdr *)((u8 *) skb->data + mac_hdr_len +
                              SNAP_SIZE + PROTOC_TYPE_SIZE);
        ether_type = *(u16 *) ((u8 *) skb->data + mac_hdr_len + SNAP_SIZE);
+        /*      ether_type = ntohs(ether_type); */
        if (ETH_P_IP == ether_type) {
                if (IPPROTO_UDP == ip->protocol) {
@@ -686,7 +844,6 @@ u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx)
                return true;
        }
-end:
        return false;
 }
@@ -695,61 +852,92 @@ end:
 * functions called by core.c
 *
 *********************************************************/
-int rtl_tx_agg_start(struct ieee80211_hw *hw, const u8 *ra, u16 tid, u16 *ssn)
+int rtl_tx_agg_start(struct ieee80211_hw *hw,
+                struct ieee80211_sta *sta, u16 tid, u16 *ssn)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_tid_data *tid_data;
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_sta_info *sta_entry = NULL;
-        RT_TRACE(rtlpriv, COMP_SEND, DBG_DMESG,
+        if (sta == NULL)
-                 ("on ra = %pM tid = %d\n", ra, tid));
+                return -EINVAL;
        if (unlikely(tid >= MAX_TID_COUNT))
                return -EINVAL;
-        if (mac->tids[tid].agg.agg_state != RTL_AGG_OFF) {
+        sta_entry = (struct rtl_sta_info *)sta->drv_priv;
-                RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
+        if (!sta_entry)
-                         ("Start AGG when state is not RTL_AGG_OFF !\n"));
                return -ENXIO;
-        }
+        tid_data = &sta_entry->tids[tid];
-        tid_data = &mac->tids[tid];
-        *ssn = SEQ_TO_SN(tid_data->seq_number);
        RT_TRACE(rtlpriv, COMP_SEND, DBG_DMESG,
-                 ("HW queue is empty tid:%d\n", tid));
+                 ("on ra = %pM tid = %d seq:%d\n", sta->addr, tid,
-        tid_data->agg.agg_state = RTL_AGG_ON;
+                 tid_data->seq_number));
+        *ssn = tid_data->seq_number;
+        tid_data->agg.agg_state = RTL_AGG_START;
-        ieee80211_start_tx_ba_cb_irqsafe(mac->vif, ra, tid);
+        ieee80211_start_tx_ba_cb_irqsafe(mac->vif, sta->addr, tid);
        return 0;
 }
-int rtl_tx_agg_stop(struct ieee80211_hw *hw, const u8 * ra, u16 tid)
+int rtl_tx_agg_stop(struct ieee80211_hw *hw,
+                struct ieee80211_sta *sta, u16 tid)
 {
-        int ssn = -1;
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct rtl_tid_data *tid_data;
+        struct rtl_sta_info *sta_entry = NULL;
+        if (sta == NULL)
+                return -EINVAL;
-        if (!ra) {
+        if (!sta->addr) {
                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, ("ra = NULL\n"));
                return -EINVAL;
        }
+        RT_TRACE(rtlpriv, COMP_SEND, DBG_DMESG,
+                 ("on ra = %pM tid = %d\n", sta->addr, tid));
        if (unlikely(tid >= MAX_TID_COUNT))
                return -EINVAL;
-        if (mac->tids[tid].agg.agg_state != RTL_AGG_ON)
+        sta_entry = (struct rtl_sta_info *)sta->drv_priv;
-                RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
+        tid_data = &sta_entry->tids[tid];
-                         ("Stopping AGG while state not ON or starting\n"));
+        sta_entry->tids[tid].agg.agg_state = RTL_AGG_STOP;
+        ieee80211_stop_tx_ba_cb_irqsafe(mac->vif, sta->addr, tid);
-        tid_data = &mac->tids[tid];
+        return 0;
-        ssn = (tid_data->seq_number & IEEE80211_SCTL_SEQ) >> 4;
+}
-        mac->tids[tid].agg.agg_state = RTL_AGG_OFF;
+int rtl_tx_agg_oper(struct ieee80211_hw *hw,
+                struct ieee80211_sta *sta, u16 tid)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_tid_data *tid_data;
+        struct rtl_sta_info *sta_entry = NULL;
-        ieee80211_stop_tx_ba_cb_irqsafe(mac->vif, ra, tid);
+        if (sta == NULL)
+                return -EINVAL;
+        if (!sta->addr) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, ("ra = NULL\n"));
+                return -EINVAL;
+        }
+        RT_TRACE(rtlpriv, COMP_SEND, DBG_DMESG,
+                 ("on ra = %pM tid = %d\n", sta->addr, tid));
+        if (unlikely(tid >= MAX_TID_COUNT))
+                return -EINVAL;
+        sta_entry = (struct rtl_sta_info *)sta->drv_priv;
+        tid_data = &sta_entry->tids[tid];
+        sta_entry->tids[tid].agg.agg_state = RTL_AGG_OPERATIONAL;
        return 0;
 }
@@ -768,18 +956,16 @@ void rtl_watchdog_wq_callback(void *data)
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        bool busytraffic = false;
        bool higher_busytraffic = false;
        bool higher_busyrxtraffic = false;
-        bool higher_busytxtraffic = false;
+        u8 idx, tid;
-        u8 idx = 0;
        u32 rx_cnt_inp4eriod = 0;
        u32 tx_cnt_inp4eriod = 0;
        u32 aver_rx_cnt_inperiod = 0;
        u32 aver_tx_cnt_inperiod = 0;
+        u32 aver_tidtx_inperiod[MAX_TID_COUNT] = {0};
+        u32 tidtx_inp4eriod[MAX_TID_COUNT] = {0};
        bool enter_ps = false;
        if (is_hal_stop(rtlhal))
@@ -793,9 +979,6 @@ void rtl_watchdog_wq_callback(void *data)
                mac->cnt_after_linked = 0;
        }
-        /* <2> DM */
-        rtlpriv->cfg->ops->dm_watchdog(hw);
        /*
         *<3> to check if traffic busy, if
         * busytraffic we don't change channel
@@ -834,8 +1017,27 @@ void rtl_watchdog_wq_callback(void *data)
                        /* Extremely high Rx data. */
                        if (aver_rx_cnt_inperiod > 5000)
                                higher_busyrxtraffic = true;
+                }
+                /* check every tid's tx traffic */
+                for (tid = 0; tid <= 7; tid++) {
+                        for (idx = 0; idx <= 2; idx++)
+                                rtlpriv->link_info.tidtx_in4period[tid][idx] =
+                                  rtlpriv->link_info.tidtx_in4period[tid]
+                                  [idx + 1];
+                        rtlpriv->link_info.tidtx_in4period[tid][3] =
+                                rtlpriv->link_info.tidtx_inperiod[tid];
+                        for (idx = 0; idx <= 3; idx++)
+                                tidtx_inp4eriod[tid] +=
+                                  rtlpriv->link_info.tidtx_in4period[tid][idx];
+                        aver_tidtx_inperiod[tid] = tidtx_inp4eriod[tid] / 4;
+                        if (aver_tidtx_inperiod[tid] > 5000)
+                                rtlpriv->link_info.higher_busytxtraffic[tid] =
+                                                   true;
                        else
-                                higher_busytxtraffic = false;
+                                rtlpriv->link_info.higher_busytxtraffic[tid] =
+                                                   false;
                }
                if (((rtlpriv->link_info.num_rx_inperiod +
@@ -854,11 +1056,15 @@ void rtl_watchdog_wq_callback(void *data)
        rtlpriv->link_info.num_rx_inperiod = 0;
        rtlpriv->link_info.num_tx_inperiod = 0;
+        for (tid = 0; tid <= 7; tid++)
+                rtlpriv->link_info.tidtx_inperiod[tid] = 0;
        rtlpriv->link_info.busytraffic = busytraffic;
        rtlpriv->link_info.higher_busytraffic = higher_busytraffic;
        rtlpriv->link_info.higher_busyrxtraffic = higher_busyrxtraffic;
+        /* <3> DM */
+        rtlpriv->cfg->ops->dm_watchdog(hw);
 }
 void rtl_watch_dog_timer_callback(unsigned long data)
@@ -875,6 +1081,268 @@ void rtl_watch_dog_timer_callback(unsigned long data)
 /*********************************************************
 *
+ * frame process functions
+ *
+ *********************************************************/
+u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie)
+{
+        struct ieee80211_mgmt *mgmt = (void *)data;
+        u8 *pos, *end;
+        pos = (u8 *)mgmt->u.beacon.variable;
+        end = data + len;
+        while (pos < end) {
+                if (pos + 2 + pos[1] > end)
+                        return NULL;
+                if (pos[0] == ie)
+                        return pos;
+                pos += 2 + pos[1];
+        }
+        return NULL;
+}
+/* when we use 2 rx ants we send IEEE80211_SMPS_OFF */
+/* when we use 1 rx ant we send IEEE80211_SMPS_STATIC */
+static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
+                enum ieee80211_smps_mode smps, u8 *da, u8 *bssid)
+{
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        struct sk_buff *skb;
+        struct ieee80211_mgmt *action_frame;
+        /* 27 = header + category + action + smps mode */
+        skb = dev_alloc_skb(27 + hw->extra_tx_headroom);
+        if (!skb)
+                return NULL;
+        skb_reserve(skb, hw->extra_tx_headroom);
+        action_frame = (void *)skb_put(skb, 27);
+        memset(action_frame, 0, 27);
+        memcpy(action_frame->da, da, ETH_ALEN);
+        memcpy(action_frame->sa, rtlefuse->dev_addr, ETH_ALEN);
+        memcpy(action_frame->bssid, bssid, ETH_ALEN);
+        action_frame->frame_control = cpu_to_le16(IEEE80211_FTYPE_MGMT |
+                                                  IEEE80211_STYPE_ACTION);
+        action_frame->u.action.category = WLAN_CATEGORY_HT;
+        action_frame->u.action.u.ht_smps.action = WLAN_HT_ACTION_SMPS;
+        switch (smps) {
+        case IEEE80211_SMPS_AUTOMATIC:/* 0 */
+        case IEEE80211_SMPS_NUM_MODES:/* 4 */
+                WARN_ON(1);
+        case IEEE80211_SMPS_OFF:/* 1 */ /*MIMO_PS_NOLIMIT*/
+                action_frame->u.action.u.ht_smps.smps_control =
+                                WLAN_HT_SMPS_CONTROL_DISABLED;/* 0 */
+                break;
+        case IEEE80211_SMPS_STATIC:/* 2 */ /*MIMO_PS_STATIC*/
+                action_frame->u.action.u.ht_smps.smps_control =
+                                WLAN_HT_SMPS_CONTROL_STATIC;/* 1 */
+                break;
+        case IEEE80211_SMPS_DYNAMIC:/* 3 */ /*MIMO_PS_DYNAMIC*/
+                action_frame->u.action.u.ht_smps.smps_control =
+                                WLAN_HT_SMPS_CONTROL_DYNAMIC;/* 3 */
+                break;
+        }
+        return skb;
+}
+int rtl_send_smps_action(struct ieee80211_hw *hw,
+                struct ieee80211_sta *sta, u8 *da, u8 *bssid,
+                enum ieee80211_smps_mode smps)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        struct sk_buff *skb = rtl_make_smps_action(hw, smps, da, bssid);
+        struct rtl_tcb_desc tcb_desc;
+        memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
+        if (rtlpriv->mac80211.act_scanning)
+                goto err_free;
+        if (!sta)
+                goto err_free;
+        if (unlikely(is_hal_stop(rtlhal) || ppsc->rfpwr_state != ERFON))
+                goto err_free;
+        if (!test_bit(RTL_STATUS_INTERFACE_START, &rtlpriv->status))
+                goto err_free;
+        /* this is a type = mgmt * stype = action frame */
+        if (skb) {
+                struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
+                struct rtl_sta_info *sta_entry =
+                        (struct rtl_sta_info *) sta->drv_priv;
+                sta_entry->mimo_ps = smps;
+                rtlpriv->cfg->ops->update_rate_tbl(hw, sta, 0);
+                info->control.rates[0].idx = 0;
+                info->control.sta = sta;
+                info->band = hw->conf.channel->band;
+                rtlpriv->intf_ops->adapter_tx(hw, skb, &tcb_desc);
+        }
+err_free:
+        return 0;
+}
+/*********************************************************
+ *
+ * IOT functions
+ *
+ *********************************************************/
+static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw,
+                struct octet_string vendor_ie)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        bool matched = false;
+        static u8 athcap_1[] = { 0x00, 0x03, 0x7F };
+        static u8 athcap_2[] = { 0x00, 0x13, 0x74 };
+        static u8 broadcap_1[] = { 0x00, 0x10, 0x18 };
+        static u8 broadcap_2[] = { 0x00, 0x0a, 0xf7 };
+        static u8 broadcap_3[] = { 0x00, 0x05, 0xb5 };
+        static u8 racap[] = { 0x00, 0x0c, 0x43 };
+        static u8 ciscocap[] = { 0x00, 0x40, 0x96 };
+        static u8 marvcap[] = { 0x00, 0x50, 0x43 };
+        if (memcmp(vendor_ie.octet, athcap_1, 3) == 0 ||
+                memcmp(vendor_ie.octet, athcap_2, 3) == 0) {
+                rtlpriv->mac80211.vendor = PEER_ATH;
+                matched = true;
+        } else if (memcmp(vendor_ie.octet, broadcap_1, 3) == 0 ||
+                memcmp(vendor_ie.octet, broadcap_2, 3) == 0 ||
+                memcmp(vendor_ie.octet, broadcap_3, 3) == 0) {
+                rtlpriv->mac80211.vendor = PEER_BROAD;
+                matched = true;
+        } else if (memcmp(vendor_ie.octet, racap, 3) == 0) {
+                rtlpriv->mac80211.vendor = PEER_RAL;
+                matched = true;
+        } else if (memcmp(vendor_ie.octet, ciscocap, 3) == 0) {
+                rtlpriv->mac80211.vendor = PEER_CISCO;
+                matched = true;
+        } else if (memcmp(vendor_ie.octet, marvcap, 3) == 0) {
+                rtlpriv->mac80211.vendor = PEER_MARV;
+                matched = true;
+        }
+        return matched;
+}
+static bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
+                unsigned int len)
+{
+        struct ieee80211_mgmt *mgmt = (void *)data;
+        struct octet_string vendor_ie;
+        u8 *pos, *end;
+        pos = (u8 *)mgmt->u.beacon.variable;
+        end = data + len;
+        while (pos < end) {
+                if (pos[0] == 221) {
+                        vendor_ie.length = pos[1];
+                        vendor_ie.octet = &pos[2];
+                        if (rtl_chk_vendor_ouisub(hw, vendor_ie))
+                                return true;
+                }
+                if (pos + 2 + pos[1] > end)
+                        return false;
+                pos += 2 + pos[1];
+        }
+        return false;
+}
+void rtl_recognize_peer(struct ieee80211_hw *hw, u8 *data, unsigned int len)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct ieee80211_hdr *hdr = (void *)data;
+        u32 vendor = PEER_UNKNOWN;
+        static u8 ap3_1[3] = { 0x00, 0x14, 0xbf };
+        static u8 ap3_2[3] = { 0x00, 0x1a, 0x70 };
+        static u8 ap3_3[3] = { 0x00, 0x1d, 0x7e };
+        static u8 ap4_1[3] = { 0x00, 0x90, 0xcc };
+        static u8 ap4_2[3] = { 0x00, 0x0e, 0x2e };
+        static u8 ap4_3[3] = { 0x00, 0x18, 0x02 };
+        static u8 ap4_4[3] = { 0x00, 0x17, 0x3f };
+        static u8 ap4_5[3] = { 0x00, 0x1c, 0xdf };
+        static u8 ap5_1[3] = { 0x00, 0x1c, 0xf0 };
+        static u8 ap5_2[3] = { 0x00, 0x21, 0x91 };
+        static u8 ap5_3[3] = { 0x00, 0x24, 0x01 };
+        static u8 ap5_4[3] = { 0x00, 0x15, 0xe9 };
+        static u8 ap5_5[3] = { 0x00, 0x17, 0x9A };
+        static u8 ap5_6[3] = { 0x00, 0x18, 0xE7 };
+        static u8 ap6_1[3] = { 0x00, 0x17, 0x94 };
+        static u8 ap7_1[3] = { 0x00, 0x14, 0xa4 };
+        if (mac->opmode != NL80211_IFTYPE_STATION)
+                return;
+        if (mac->link_state == MAC80211_NOLINK) {
+                mac->vendor = PEER_UNKNOWN;
+                return;
+        }
+        if (mac->cnt_after_linked > 2)
+                return;
+        /* check if this really is a beacon */
+        if (!ieee80211_is_beacon(hdr->frame_control))
+                return;
+        /* min. beacon length + FCS_LEN */
+        if (len <= 40 + FCS_LEN)
+                return;
+        /* and only beacons from the associated BSSID, please */
+        if (compare_ether_addr(hdr->addr3, rtlpriv->mac80211.bssid))
+                return;
+        if (rtl_find_221_ie(hw, data, len))
+                vendor = mac->vendor;
+        if ((memcmp(mac->bssid, ap5_1, 3) == 0) ||
+                (memcmp(mac->bssid, ap5_2, 3) == 0) ||
+                (memcmp(mac->bssid, ap5_3, 3) == 0) ||
+                (memcmp(mac->bssid, ap5_4, 3) == 0) ||
+                (memcmp(mac->bssid, ap5_5, 3) == 0) ||
+                (memcmp(mac->bssid, ap5_6, 3) == 0) ||
+                vendor == PEER_ATH) {
+                vendor = PEER_ATH;
+                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD, ("=>ath find\n"));
+        } else if ((memcmp(mac->bssid, ap4_4, 3) == 0) ||
+                (memcmp(mac->bssid, ap4_5, 3) == 0) ||
+                (memcmp(mac->bssid, ap4_1, 3) == 0) ||
+                (memcmp(mac->bssid, ap4_2, 3) == 0) ||
+                (memcmp(mac->bssid, ap4_3, 3) == 0) ||
+                vendor == PEER_RAL) {
+                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD, ("=>ral findn\n"));
+                vendor = PEER_RAL;
+        } else if (memcmp(mac->bssid, ap6_1, 3) == 0 ||
+                vendor == PEER_CISCO) {
+                vendor = PEER_CISCO;
+                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD, ("=>cisco find\n"));
+        } else if ((memcmp(mac->bssid, ap3_1, 3) == 0) ||
+                (memcmp(mac->bssid, ap3_2, 3) == 0) ||
+                (memcmp(mac->bssid, ap3_3, 3) == 0) ||
+                vendor == PEER_BROAD) {
+                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD, ("=>broad find\n"));
+                vendor = PEER_BROAD;
+        } else if (memcmp(mac->bssid, ap7_1, 3) == 0 ||
+                vendor == PEER_MARV) {
+                vendor = PEER_MARV;
+                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD, ("=>marv find\n"));
+        }
+        mac->vendor = vendor;
+}
+/*********************************************************
+ *
 * sysfs functions
 *
 *********************************************************/
@@ -940,12 +1408,13 @@ static int __init rtl_core_module_init(void)
        if (rtl_rate_control_register())
                printk(KERN_ERR "rtlwifi: Unable to register rtl_rc,"
                       "use default RC !!\n");
        return 0;
 }
 static void __exit rtl_core_module_exit(void)
 {
-         /*RC*/
+        /*RC*/
        rtl_rate_control_unregister();
 }
diff --git a/drivers/net/wireless/rtlwifi/base.h b/drivers/net/wireless/rtlwifi/base.h
index 043045342bc7..a91f3eee59c8 100644
--- a/drivers/net/wireless/rtlwifi/base.h
+++ b/drivers/net/wireless/rtlwifi/base.h
@@ -24,13 +24,26 @@
 * Hsinchu 300, Taiwan.
 *
 * Larry Finger <Larry.Finger@lwfinger.net>
+ *
 *****************************************************************************/
 #ifndef __RTL_BASE_H__
 #define __RTL_BASE_H__
+enum ap_peer {
+        PEER_UNKNOWN = 0,
+        PEER_RTL = 1,
+        PEER_RTL_92SE = 2,
+        PEER_BROAD = 3,
+        PEER_RAL = 4,
+        PEER_ATH = 5,
+        PEER_CISCO = 6,
+        PEER_MARV = 7,
+        PEER_AIRGO = 9,
+        PEER_MAX = 10,
+} ;
 #define RTL_DUMMY_OFFSET        0
-#define RTL_RX_DESC_SIZE        24
 #define RTL_DUMMY_UNIT          8
 #define RTL_TX_DUMMY_SIZE       (RTL_DUMMY_OFFSET * RTL_DUMMY_UNIT)
 #define RTL_TX_DESC_SIZE        32
@@ -53,6 +66,14 @@
 #define FRAME_OFFSET_SEQUENCE           22
 #define FRAME_OFFSET_ADDRESS4           24
+#define SET_80211_HDR_FRAME_CONTROL(_hdr, _val)         \
+        WRITEEF2BYTE(_hdr, _val)
+#define SET_80211_HDR_TYPE_AND_SUBTYPE(_hdr, _val)      \
+        WRITEEF1BYTE(_hdr, _val)
+#define SET_80211_HDR_PWR_MGNT(_hdr, _val)              \
+        SET_BITS_TO_LE_2BYTE(_hdr, 12, 1, _val)
+#define SET_80211_HDR_TO_DS(_hdr, _val)                 \
+        SET_BITS_TO_LE_2BYTE(_hdr, 8, 1, _val)
 #define SET_80211_PS_POLL_AID(_hdr, _val)               \
        (*(u16 *)((u8 *)(_hdr) + 2) = le16_to_cpu(_val))
@@ -64,11 +85,27 @@
 #define SET_80211_HDR_DURATION(_hdr, _val)      \
        (*(u16 *)((u8 *)(_hdr) + FRAME_OFFSET_DURATION) = le16_to_cpu(_val))
 #define SET_80211_HDR_ADDRESS1(_hdr, _val)      \
-        memcpy((u8 *)(_hdr)+FRAME_OFFSET_ADDRESS1, (u8*)(_val), ETH_ALEN)
+        CP_MACADDR((u8 *)(_hdr)+FRAME_OFFSET_ADDRESS1, (u8 *)(_val))
 #define SET_80211_HDR_ADDRESS2(_hdr, _val)      \
-        memcpy((u8 *)(_hdr) + FRAME_OFFSET_ADDRESS2, (u8 *)(_val), ETH_ALEN)
+        CP_MACADDR((u8 *)(_hdr)+FRAME_OFFSET_ADDRESS2, (u8 *)(_val))
 #define SET_80211_HDR_ADDRESS3(_hdr, _val)      \
-        memcpy((u8 *)(_hdr)+FRAME_OFFSET_ADDRESS3, (u8 *)(_val), ETH_ALEN)
+        CP_MACADDR((u8 *)(_hdr)+FRAME_OFFSET_ADDRESS3, (u8 *)(_val))
+#define SET_80211_HDR_FRAGMENT_SEQUENCE(_hdr, _val)  \
+        WRITEEF2BYTE((u8 *)(_hdr)+FRAME_OFFSET_SEQUENCE, _val)
+#define SET_BEACON_PROBE_RSP_TIME_STAMP_LOW(__phdr, __val)      \
+        WRITEEF4BYTE(((u8 *)(__phdr)) + 24, __val)
+#define SET_BEACON_PROBE_RSP_TIME_STAMP_HIGH(__phdr, __val) \
+        WRITEEF4BYTE(((u8 *)(__phdr)) + 28, __val)
+#define SET_BEACON_PROBE_RSP_BEACON_INTERVAL(__phdr, __val) \
+        WRITEEF2BYTE(((u8 *)(__phdr)) + 32, __val)
+#define GET_BEACON_PROBE_RSP_CAPABILITY_INFO(__phdr)            \
+        READEF2BYTE(((u8 *)(__phdr)) + 34)
+#define SET_BEACON_PROBE_RSP_CAPABILITY_INFO(__phdr, __val) \
+        WRITEEF2BYTE(((u8 *)(__phdr)) + 34, __val)
+#define MASK_BEACON_PROBE_RSP_CAPABILITY_INFO(__phdr, __val) \
+        SET_BEACON_PROBE_RSP_CAPABILITY_INFO(__phdr, \
+        (GET_BEACON_PROBE_RSP_CAPABILITY_INFO(__phdr) & (~(__val))))
 int rtl_init_core(struct ieee80211_hw *hw);
 void rtl_deinit_core(struct ieee80211_hw *hw);
@@ -80,18 +117,27 @@ void rtl_watch_dog_timer_callback(unsigned long data);
 void rtl_deinit_deferred_work(struct ieee80211_hw *hw);
 bool rtl_action_proc(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx);
-bool rtl_tx_mgmt_proc(struct ieee80211_hw *hw, struct sk_buff *skb);
 u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx);
 void rtl_watch_dog_timer_callback(unsigned long data);
-int rtl_tx_agg_start(struct ieee80211_hw *hw, const u8 *ra,
+int rtl_tx_agg_start(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
                     u16 tid, u16 *ssn);
-int rtl_tx_agg_stop(struct ieee80211_hw *hw, const u8 *ra, u16 tid);
+int rtl_tx_agg_stop(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
+                    u16 tid);
+int rtl_tx_agg_oper(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
+                    u16 tid);
 void rtl_watchdog_wq_callback(void *data);
 void rtl_get_tcb_desc(struct ieee80211_hw *hw,
                      struct ieee80211_tx_info *info,
+                      struct ieee80211_sta *sta,
                      struct sk_buff *skb, struct rtl_tcb_desc *tcb_desc);
+int rtl_send_smps_action(struct ieee80211_hw *hw,
+                struct ieee80211_sta *sta, u8 *da, u8 *bssid,
+                enum ieee80211_smps_mode smps);
+u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie);
+void rtl_recognize_peer(struct ieee80211_hw *hw, u8 *data, unsigned int len);
+u8 rtl_tid_to_ac(struct ieee80211_hw *hw, u8 tid);
 extern struct attribute_group rtl_attribute_group;
 #endif
diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
index 52c9c1367cac..7295af0536b7 100644
--- a/drivers/net/wireless/rtlwifi/cam.c
+++ b/drivers/net/wireless/rtlwifi/cam.c
@@ -23,6 +23,8 @@
 * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
 * Hsinchu 300, Taiwan.
 *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
 *****************************************************************************/
 #include "wifi.h"
@@ -49,7 +51,7 @@ static void rtl_cam_program_entry(struct ieee80211_hw *hw, u32 entry_no,
        u32 target_content = 0;
        u8 entry_i;
-        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
                 ("key_cont_128:\n %x:%x:%x:%x:%x:%x\n",
                  key_cont_128[0], key_cont_128[1],
                  key_cont_128[2], key_cont_128[3],
@@ -68,15 +70,13 @@ static void rtl_cam_program_entry(struct ieee80211_hw *hw, u32 entry_no,
                        rtl_write_dword(rtlpriv, rtlpriv->cfg->maps[RWCAM],
                                        target_command);
-                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
-                                 ("rtl_cam_program_entry(): "
+                                 ("WRITE %x: %x\n",
-                                  "WRITE %x: %x\n",
                                  rtlpriv->cfg->maps[WCAMI], target_content));
-                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
                                 ("The Key ID is %d\n", entry_no));
-                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
-                                 ("rtl_cam_program_entry(): "
+                                 ("WRITE %x: %x\n",
-                                  "WRITE %x: %x\n",
                                  rtlpriv->cfg->maps[RWCAM], target_command));
                } else if (entry_i == 1) {
@@ -91,12 +91,10 @@ static void rtl_cam_program_entry(struct ieee80211_hw *hw, u32 entry_no,
                        rtl_write_dword(rtlpriv, rtlpriv->cfg->maps[RWCAM],
                                        target_command);
-                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
-                                 ("rtl_cam_program_entry(): WRITE A4: %x\n",
+                                 ("WRITE A4: %x\n", target_content));
-                                  target_content));
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
-                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                                 ("WRITE A0: %x\n", target_command));
-                                 ("rtl_cam_program_entry(): WRITE A0: %x\n",
-                                  target_command));
                } else {
@@ -113,16 +111,14 @@ static void rtl_cam_program_entry(struct ieee80211_hw *hw, u32 entry_no,
                                        target_command);
                        udelay(100);
-                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
-                                 ("rtl_cam_program_entry(): WRITE A4: %x\n",
+                                 ("WRITE A4: %x\n", target_content));
-                                  target_content));
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
-                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                                 ("WRITE A0: %x\n", target_command));
-                                 ("rtl_cam_program_entry(): WRITE A0: %x\n",
-                                  target_command));
                }
        }
-        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
                 ("after set key, usconfig:%x\n", us_config));
 }
@@ -289,3 +285,71 @@ void rtl_cam_empty_entry(struct ieee80211_hw *hw, u8 uc_index)
 }
 EXPORT_SYMBOL(rtl_cam_empty_entry);
+u8 rtl_cam_get_free_entry(struct ieee80211_hw *hw, u8 *sta_addr)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u32 bitmap = (rtlpriv->sec.hwsec_cam_bitmap) >> 4;
+        u8 entry_idx = 0;
+        u8 i, *addr;
+        if (NULL == sta_addr) {
+                RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG,
+                        ("sta_addr is NULL.\n"));
+                return TOTAL_CAM_ENTRY;
+        }
+        /* Does STA already exist? */
+        for (i = 4; i < TOTAL_CAM_ENTRY; i++) {
+                addr = rtlpriv->sec.hwsec_cam_sta_addr[i];
+                if (memcmp(addr, sta_addr, ETH_ALEN) == 0)
+                        return i;
+        }
+        /* Get a free CAM entry. */
+        for (entry_idx = 4; entry_idx < TOTAL_CAM_ENTRY; entry_idx++) {
+                if ((bitmap & BIT(0)) == 0) {
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG,
+                                ("-----hwsec_cam_bitmap: 0x%x entry_idx=%d\n",
+                                 rtlpriv->sec.hwsec_cam_bitmap, entry_idx));
+                        rtlpriv->sec.hwsec_cam_bitmap |= BIT(0) << entry_idx;
+                        memcpy(rtlpriv->sec.hwsec_cam_sta_addr[entry_idx],
+                               sta_addr, ETH_ALEN);
+                        return entry_idx;
+                }
+                bitmap = bitmap >> 1;
+        }
+        return TOTAL_CAM_ENTRY;
+}
+EXPORT_SYMBOL(rtl_cam_get_free_entry);
+void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u32 bitmap;
+        u8 i, *addr;
+        if (NULL == sta_addr) {
+                RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG,
+                        ("sta_addr is NULL.\n"));
+        }
+        if ((sta_addr[0]|sta_addr[1]|sta_addr[2]|sta_addr[3]|\
+                                sta_addr[4]|sta_addr[5]) == 0) {
+                RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG,
+                        ("sta_addr is 00:00:00:00:00:00.\n"));
+                return;
+        }
+        /* Does STA already exist? */
+        for (i = 4; i < TOTAL_CAM_ENTRY; i++) {
+                addr = rtlpriv->sec.hwsec_cam_sta_addr[i];
+                bitmap = (rtlpriv->sec.hwsec_cam_bitmap) >> i;
+                if (((bitmap & BIT(0)) == BIT(0)) &&
+                    (memcmp(addr, sta_addr, ETH_ALEN) == 0)) {
+                        /* Remove from HW Security CAM */
+                        memset(rtlpriv->sec.hwsec_cam_sta_addr[i], 0, ETH_ALEN);
+                        rtlpriv->sec.hwsec_cam_bitmap &= ~(BIT(0) << i);
+                        printk(KERN_INFO "&&&&&&&&&del entry %d\n", i);
+                }
+        }
+        return;
+}
+EXPORT_SYMBOL(rtl_cam_del_entry);
diff --git a/drivers/net/wireless/rtlwifi/cam.h b/drivers/net/wireless/rtlwifi/cam.h
index dd82f057d53d..c62da4eefc75 100644
--- a/drivers/net/wireless/rtlwifi/cam.h
+++ b/drivers/net/wireless/rtlwifi/cam.h
@@ -23,12 +23,13 @@
 * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
 * Hsinchu 300, Taiwan.
 *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
 *****************************************************************************/
 #ifndef __RTL_CAM_H_
 #define __RTL_CAM_H_
-#define TOTAL_CAM_ENTRY                                 32
 #define CAM_CONTENT_COUNT                               8
 #define CFG_DEFAULT_KEY                                 BIT(5)
@@ -49,5 +50,7 @@ int rtl_cam_delete_one_entry(struct ieee80211_hw *hw, u8 *mac_addr,
 void rtl_cam_mark_invalid(struct ieee80211_hw *hw, u8 uc_index);
 void rtl_cam_empty_entry(struct ieee80211_hw *hw, u8 uc_index);
 void rtl_cam_reset_sec_info(struct ieee80211_hw *hw);
+u8 rtl_cam_get_free_entry(struct ieee80211_hw *hw, u8 *sta_addr);
+void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/core.c b/drivers/net/wireless/rtlwifi/core.c
index e4f4aee8f298..fc89cd8c8320 100644
--- a/drivers/net/wireless/rtlwifi/core.c
+++ b/drivers/net/wireless/rtlwifi/core.c
@@ -24,6 +24,7 @@
 * Hsinchu 300, Taiwan.
 *
 * Larry Finger <Larry.Finger@lwfinger.net>
+ *
 *****************************************************************************/
 #include "wifi.h"
@@ -35,7 +36,7 @@
 /*mutex for start & stop is must here. */
 static int rtl_op_start(struct ieee80211_hw *hw)
 {
-        int err = 0;
+        int err;
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
@@ -45,10 +46,8 @@ static int rtl_op_start(struct ieee80211_hw *hw)
                return 0;
        mutex_lock(&rtlpriv->locks.conf_mutex);
        err = rtlpriv->intf_ops->adapter_start(hw);
-        if (err)
+        if (!err)
-                goto out;
+                rtl_watch_dog_timer_callback((unsigned long)hw);
-        rtl_watch_dog_timer_callback((unsigned long)hw);
-out:
        mutex_unlock(&rtlpriv->locks.conf_mutex);
        return err;
 }
@@ -72,6 +71,7 @@ static void rtl_op_stop(struct ieee80211_hw *hw)
        mac->link_state = MAC80211_NOLINK;
        memset(mac->bssid, 0, 6);
+        mac->vendor = PEER_UNKNOWN;
        /*reset sec info */
        rtl_cam_reset_sec_info(hw);
@@ -87,6 +87,8 @@ static void rtl_op_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        struct rtl_tcb_desc tcb_desc;
+        memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
        if (unlikely(is_hal_stop(rtlhal) || ppsc->rfpwr_state != ERFON))
                goto err_free;
@@ -94,8 +96,8 @@ static void rtl_op_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
        if (!test_bit(RTL_STATUS_INTERFACE_START, &rtlpriv->status))
                goto err_free;
+        if (!rtlpriv->intf_ops->waitq_insert(hw, skb))
-        rtlpriv->intf_ops->adapter_tx(hw, skb);
+                rtlpriv->intf_ops->adapter_tx(hw, skb, &tcb_desc);
        return;
@@ -136,10 +138,26 @@ static int rtl_op_add_interface(struct ieee80211_hw *hw,
                mac->link_state = MAC80211_LINKED;
                rtlpriv->cfg->ops->set_bcn_reg(hw);
+                if (rtlpriv->rtlhal.current_bandtype == BAND_ON_2_4G)
+                        mac->basic_rates = 0xfff;
+                else
+                        mac->basic_rates = 0xff0;
+                rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_BASIC_RATE,
+                                (u8 *) (&mac->basic_rates));
                break;
        case NL80211_IFTYPE_AP:
                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD,
                         ("NL80211_IFTYPE_AP\n"));
+                mac->link_state = MAC80211_LINKED;
+                rtlpriv->cfg->ops->set_bcn_reg(hw);
+                if (rtlpriv->rtlhal.current_bandtype == BAND_ON_2_4G)
+                        mac->basic_rates = 0xfff;
+                else
+                        mac->basic_rates = 0xff0;
+                rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_BASIC_RATE,
+                                (u8 *) (&mac->basic_rates));
                break;
        default:
                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
@@ -186,13 +204,12 @@ static void rtl_op_remove_interface(struct ieee80211_hw *hw,
        mac->vif = NULL;
        mac->link_state = MAC80211_NOLINK;
        memset(mac->bssid, 0, 6);
+        mac->vendor = PEER_UNKNOWN;
        mac->opmode = NL80211_IFTYPE_UNSPECIFIED;
        rtlpriv->cfg->ops->set_network_type(hw, mac->opmode);
        mutex_unlock(&rtlpriv->locks.conf_mutex);
 }
 static int rtl_op_config(struct ieee80211_hw *hw, u32 changed)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
@@ -224,10 +241,25 @@ static int rtl_op_config(struct ieee80211_hw *hw, u32 changed)
        /*For LPS */
        if (changed & IEEE80211_CONF_CHANGE_PS) {
-                if (conf->flags & IEEE80211_CONF_PS)
+                cancel_delayed_work(&rtlpriv->works.ps_work);
-                        rtl_lps_enter(hw);
+                cancel_delayed_work(&rtlpriv->works.ps_rfon_wq);
-                else
+                if (conf->flags & IEEE80211_CONF_PS) {
-                        rtl_lps_leave(hw);
+                        rtlpriv->psc.sw_ps_enabled = true;
+                        /* sleep here is must, or we may recv the beacon and
+                         * cause mac80211 into wrong ps state, this will cause
+                         * power save nullfunc send fail, and further cause
+                         * pkt loss, So sleep must quickly but not immediatly
+                         * because that will cause nullfunc send by mac80211
+                         * fail, and cause pkt loss, we have tested that 5mA
+                         * is worked very well */
+                        if (!rtlpriv->psc.multi_buffered)
+                                queue_delayed_work(rtlpriv->works.rtl_wq,
+                                                &rtlpriv->works.ps_work,
+                                                MSECS(5));
+                } else {
+                        rtl_swlps_rf_awake(hw);
+                        rtlpriv->psc.sw_ps_enabled = false;
+                }
        }
        if (changed & IEEE80211_CONF_CHANGE_RETRY_LIMITS) {
@@ -259,7 +291,7 @@ static int rtl_op_config(struct ieee80211_hw *hw, u32 changed)
                case NL80211_CHAN_NO_HT:
                        /* SC */
                        mac->cur_40_prime_sc =
-                            PRIME_CHNL_OFFSET_DONT_CARE;
+                                PRIME_CHNL_OFFSET_DONT_CARE;
                        rtlphy->current_chan_bw = HT_CHANNEL_WIDTH_20;
                        mac->bw_40 = false;
                        break;
@@ -267,7 +299,7 @@ static int rtl_op_config(struct ieee80211_hw *hw, u32 changed)
                        /* SC */
                        mac->cur_40_prime_sc = PRIME_CHNL_OFFSET_UPPER;
                        rtlphy->current_chan_bw =
-                            HT_CHANNEL_WIDTH_20_40;
+                                HT_CHANNEL_WIDTH_20_40;
                        mac->bw_40 = true;
                        /*wide channel */
@@ -278,7 +310,7 @@ static int rtl_op_config(struct ieee80211_hw *hw, u32 changed)
                        /* SC */
                        mac->cur_40_prime_sc = PRIME_CHNL_OFFSET_LOWER;
                        rtlphy->current_chan_bw =
-                            HT_CHANNEL_WIDTH_20_40;
+                                HT_CHANNEL_WIDTH_20_40;
                        mac->bw_40 = true;
                        /*wide channel */
@@ -288,16 +320,29 @@ static int rtl_op_config(struct ieee80211_hw *hw, u32 changed)
                default:
                        mac->bw_40 = false;
                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
-                                 ("switch case not processed\n"));
+                                        ("switch case not processed\n"));
                        break;
                }
                if (wide_chan <= 0)
                        wide_chan = 1;
+                /* In scanning, before we go offchannel we may send a ps=1 null
+                 * to AP, and then we may send a ps = 0 null to AP quickly, but
+                 * first null may have caused AP to put lots of packet to hw tx
+                 * buffer. These packets must be tx'd before we go off channel
+                 * so we must delay more time to let AP flush these packets
+                 * before going offchannel, or dis-association or delete BA will
+                 * happen by AP
+                 */
+                if (rtlpriv->mac80211.offchan_deley) {
+                        rtlpriv->mac80211.offchan_deley = false;
+                        mdelay(50);
+                }
                rtlphy->current_channel = wide_chan;
-                rtlpriv->cfg->ops->set_channel_access(hw);
                rtlpriv->cfg->ops->switch_channel(hw);
+                rtlpriv->cfg->ops->set_channel_access(hw);
                rtlpriv->cfg->ops->set_bw_mode(hw,
                                               hw->conf.channel_type);
        }
@@ -345,27 +390,28 @@ static void rtl_op_configure_filter(struct ieee80211_hw *hw,
                }
        }
-        if (changed_flags & FIF_BCN_PRBRESP_PROMISC) {
+        /* if ssid not set to hw don't check bssid
-                /*
+         * here just used for linked scanning, & linked
-                 *TODO: BIT(5) is probe response BIT(8) is beacon
+         * and nolink check bssid is set in set network_type */
-                 *TODO: Use define for BIT(5) and BIT(8)
+        if ((changed_flags & FIF_BCN_PRBRESP_PROMISC) &&
-                 */
+                (mac->link_state >= MAC80211_LINKED)) {
-                if (*new_flags & FIF_BCN_PRBRESP_PROMISC)
+                if (mac->opmode != NL80211_IFTYPE_AP) {
-                        mac->rx_mgt_filter |= (BIT(5) | BIT(8));
+                        if (*new_flags & FIF_BCN_PRBRESP_PROMISC) {
-                else
+                                rtlpriv->cfg->ops->set_chk_bssid(hw, false);
-                        mac->rx_mgt_filter &= ~(BIT(5) | BIT(8));
+                        } else {
+                                rtlpriv->cfg->ops->set_chk_bssid(hw, true);
+                        }
+                }
        }
        if (changed_flags & FIF_CONTROL) {
                if (*new_flags & FIF_CONTROL) {
                        mac->rx_conf |= rtlpriv->cfg->maps[MAC_RCR_ACF];
-                        mac->rx_ctrl_filter |= RTL_SUPPORTED_CTRL_FILTER;
                        RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD,
                                 ("Enable receive control frame.\n"));
                } else {
                        mac->rx_conf &= ~rtlpriv->cfg->maps[MAC_RCR_ACF];
-                        mac->rx_ctrl_filter &= ~RTL_SUPPORTED_CTRL_FILTER;
                        RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD,
                                 ("Disable receive control frame.\n"));
                }
@@ -382,14 +428,54 @@ static void rtl_op_configure_filter(struct ieee80211_hw *hw,
                                 ("Disable receive other BSS's frame.\n"));
                }
        }
-        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_RCR, (u8 *) (&mac->rx_conf));
-        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_MGT_FILTER,
-                                      (u8 *) (&mac->rx_mgt_filter));
-        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_CTRL_FILTER,
-                                      (u8 *) (&mac->rx_ctrl_filter));
 }
+static int rtl_op_sta_add(struct ieee80211_hw *hw,
+                         struct ieee80211_vif *vif,
+                         struct ieee80211_sta *sta)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_sta_info *sta_entry;
+        if (sta) {
+                sta_entry = (struct rtl_sta_info *) sta->drv_priv;
+                if (rtlhal->current_bandtype == BAND_ON_2_4G) {
+                        sta_entry->wireless_mode = WIRELESS_MODE_G;
+                        if (sta->supp_rates[0] <= 0xf)
+                                sta_entry->wireless_mode = WIRELESS_MODE_B;
+                        if (sta->ht_cap.ht_supported == true)
+                                sta_entry->wireless_mode = WIRELESS_MODE_N_24G;
+                } else if (rtlhal->current_bandtype == BAND_ON_5G) {
+                        sta_entry->wireless_mode = WIRELESS_MODE_A;
+                        if (sta->ht_cap.ht_supported == true)
+                                sta_entry->wireless_mode = WIRELESS_MODE_N_24G;
+                }
+                /* I found some times mac80211 give wrong supp_rates for adhoc*/
+                if (rtlpriv->mac80211.opmode == NL80211_IFTYPE_ADHOC)
+                        sta_entry->wireless_mode = WIRELESS_MODE_G;
+                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_DMESG,
+                        ("Add sta addr is "MAC_FMT"\n", MAC_ARG(sta->addr)));
+                rtlpriv->cfg->ops->update_rate_tbl(hw, sta, 0);
+        }
+        return 0;
+}
+static int rtl_op_sta_remove(struct ieee80211_hw *hw,
+                                struct ieee80211_vif *vif,
+                                struct ieee80211_sta *sta)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_sta_info *sta_entry;
+        if (sta) {
+                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_DMESG,
+                        ("Remove sta addr is "MAC_FMT"\n", MAC_ARG(sta->addr)));
+                sta_entry = (struct rtl_sta_info *) sta->drv_priv;
+                sta_entry->wireless_mode = 0;
+                sta_entry->ratr_index = 0;
+        }
+        return 0;
+}
 static int _rtl_get_hal_qnum(u16 queue)
 {
        int qnum;
@@ -446,19 +532,18 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
                             struct ieee80211_bss_conf *bss_conf, u32 changed)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtlpriv);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        struct ieee80211_sta *sta = NULL;
        mutex_lock(&rtlpriv->locks.conf_mutex);
        if ((vif->type == NL80211_IFTYPE_ADHOC) ||
            (vif->type == NL80211_IFTYPE_AP) ||
            (vif->type == NL80211_IFTYPE_MESH_POINT)) {
                if ((changed & BSS_CHANGED_BEACON) ||
                    (changed & BSS_CHANGED_BEACON_ENABLED &&
                     bss_conf->enable_beacon)) {
                        if (mac->beacon_enabled == 0) {
                                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_DMESG,
                                         ("BSS_CHANGED_BEACON_ENABLED\n"));
@@ -470,8 +555,13 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
                                                rtlpriv->cfg->maps
                                                [RTL_IBSS_INT_MASKS],
                                                0);
+                                if (rtlpriv->cfg->ops->linked_set_reg)
+                                        rtlpriv->cfg->ops->linked_set_reg(hw);
                        }
-                } else {
+                }
+                if ((changed & BSS_CHANGED_BEACON_ENABLED &&
+                        !bss_conf->enable_beacon)) {
                        if (mac->beacon_enabled == 1) {
                                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_DMESG,
                                         ("ADHOC DISABLE BEACON\n"));
@@ -482,7 +572,6 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
                                                [RTL_IBSS_INT_MASKS]);
                        }
                }
                if (changed & BSS_CHANGED_BEACON_INT) {
                        RT_TRACE(rtlpriv, COMP_BEACON, DBG_TRACE,
                                 ("BSS_CHANGED_BEACON_INT\n"));
@@ -494,11 +583,25 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
        /*TODO: reference to enum ieee80211_bss_change */
        if (changed & BSS_CHANGED_ASSOC) {
                if (bss_conf->assoc) {
+                        /* we should reset all sec info & cam
+                         * before set cam after linked, we should not
+                         * reset in disassoc, that will cause tkip->wep
+                         * fail because some flag will be wrong */
+                        /* reset sec info */
+                        rtl_cam_reset_sec_info(hw);
+                        /* reset cam to fix wep fail issue
+                         * when change from wpa to wep */
+                        rtl_cam_reset_all_entry(hw);
                        mac->link_state = MAC80211_LINKED;
                        mac->cnt_after_linked = 0;
                        mac->assoc_id = bss_conf->aid;
                        memcpy(mac->bssid, bss_conf->bssid, 6);
+                        if (rtlpriv->cfg->ops->linked_set_reg)
+                                rtlpriv->cfg->ops->linked_set_reg(hw);
+                        if (mac->opmode == NL80211_IFTYPE_STATION && sta)
+                                rtlpriv->cfg->ops->update_rate_tbl(hw, sta, 0);
                        RT_TRACE(rtlpriv, COMP_MAC80211, DBG_DMESG,
                                 ("BSS_CHANGED_ASSOC\n"));
                } else {
@@ -507,9 +610,7 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
                        mac->link_state = MAC80211_NOLINK;
                        memset(mac->bssid, 0, 6);
+                        mac->vendor = PEER_UNKNOWN;
-                        /* reset sec info */
-                        rtl_cam_reset_sec_info(hw);
                        RT_TRACE(rtlpriv, COMP_MAC80211, DBG_DMESG,
                                 ("BSS_CHANGED_UN_ASSOC\n"));
@@ -546,14 +647,10 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
        }
        if (changed & BSS_CHANGED_HT) {
-                struct ieee80211_sta *sta = NULL;
                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_TRACE,
                         ("BSS_CHANGED_HT\n"));
                rcu_read_lock();
-                sta = ieee80211_find_sta(mac->vif, mac->bssid);
+                sta = get_sta(hw, vif, (u8 *)bss_conf->bssid);
                if (sta) {
                        if (sta->ht_cap.ampdu_density >
                            mac->current_ampdu_density)
@@ -575,9 +672,7 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
        }
        if (changed & BSS_CHANGED_BSSID) {
-                struct ieee80211_sta *sta = NULL;
                u32 basic_rates;
-                u8 i;
                rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_BSSID,
                                              (u8 *) bss_conf->bssid);
@@ -585,96 +680,65 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_DMESG,
                         (MAC_FMT "\n", MAC_ARG(bss_conf->bssid)));
+                mac->vendor = PEER_UNKNOWN;
                memcpy(mac->bssid, bss_conf->bssid, 6);
-                if (is_valid_ether_addr(bss_conf->bssid)) {
+                rtlpriv->cfg->ops->set_network_type(hw, vif->type);
-                        switch (vif->type) {
-                        case NL80211_IFTYPE_UNSPECIFIED:
-                                break;
-                        case NL80211_IFTYPE_ADHOC:
-                                break;
-                        case NL80211_IFTYPE_STATION:
-                                break;
-                        case NL80211_IFTYPE_AP:
-                                break;
-                        default:
-                                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
-                                         ("switch case not process\n"));
-                                break;
-                        }
-                        rtlpriv->cfg->ops->set_network_type(hw, vif->type);
-                } else
-                        rtlpriv->cfg->ops->set_network_type(hw,
-                                        NL80211_IFTYPE_UNSPECIFIED);
-                memset(mac->mcs, 0, 16);
-                mac->ht_enable = false;
-                mac->sgi_40 = false;
-                mac->sgi_20 = false;
-                if (!bss_conf->use_short_slot)
-                        mac->mode = WIRELESS_MODE_B;
-                else
-                        mac->mode = WIRELESS_MODE_G;
                rcu_read_lock();
-                sta = ieee80211_find_sta(mac->vif, mac->bssid);
+                sta = get_sta(hw, vif, (u8 *)bss_conf->bssid);
+                if (!sta) {
+                        rcu_read_unlock();
+                        goto out;
+                }
-                if (sta) {
+                if (rtlhal->current_bandtype == BAND_ON_5G) {
-                        if (sta->ht_cap.ht_supported) {
+                        mac->mode = WIRELESS_MODE_A;
+                } else {
+                        if (sta->supp_rates[0] <= 0xf)
+                                mac->mode = WIRELESS_MODE_B;
+                        else
+                                mac->mode = WIRELESS_MODE_G;
+                }
+                if (sta->ht_cap.ht_supported) {
+                        if (rtlhal->current_bandtype == BAND_ON_2_4G)
                                mac->mode = WIRELESS_MODE_N_24G;
-                                mac->ht_enable = true;
+                        else
-                        }
+                                mac->mode = WIRELESS_MODE_N_5G;
+                }
-                        if (mac->ht_enable) {
+                /* just station need it, because ibss & ap mode will
-                                u16 ht_cap = sta->ht_cap.cap;
+                 * set in sta_add, and will be NULL here */
-                                memcpy(mac->mcs, (u8 *) (&sta->ht_cap.mcs), 16);
+                if (mac->opmode == NL80211_IFTYPE_STATION) {
+                        struct rtl_sta_info *sta_entry;
-                                for (i = 0; i < 16; i++)
+                        sta_entry = (struct rtl_sta_info *) sta->drv_priv;
-                                        RT_TRACE(rtlpriv, COMP_MAC80211,
+                        sta_entry->wireless_mode = mac->mode;
-                                                 DBG_LOUD, ("%x ",
+                }
-                                                            mac->mcs[i]));
-                                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD,
+                if (sta->ht_cap.ht_supported) {
-                                         ("\n"));
+                        mac->ht_enable = true;
-                                if (ht_cap & IEEE80211_HT_CAP_SGI_40)
+                        /*
-                                        mac->sgi_40 = true;
+                         * for cisco 1252 bw20 it's wrong
+                         * if (ht_cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40) {
-                                if (ht_cap & IEEE80211_HT_CAP_SGI_20)
+                         *      mac->bw_40 = true;
-                                        mac->sgi_20 = true;
+                         * }
+                         * */
-                                /*
-                                 * for cisco 1252 bw20 it's wrong
-                                 * if (ht_cap &
-                                 *     IEEE80211_HT_CAP_SUP_WIDTH_20_40) {
-                                 *      mac->bw_40 = true;
-                                 * }
-                                 */
-                        }
                }
-                rcu_read_unlock();
-                /*mac80211 just give us CCK rates any time
-                 *So we add G rate in basic rates when
-                 not in B mode*/
                if (changed & BSS_CHANGED_BASIC_RATES) {
-                        if (mac->mode == WIRELESS_MODE_B)
+                        /* for 5G must << RATE_6M_INDEX=4,
-                                basic_rates = bss_conf->basic_rates | 0x00f;
+                         * because 5G have no cck rate*/
+                        if (rtlhal->current_bandtype == BAND_ON_5G)
+                                basic_rates = sta->supp_rates[1] << 4;
                        else
-                                basic_rates = bss_conf->basic_rates | 0xff0;
+                                basic_rates = sta->supp_rates[0];
-                        if (!vif)
-                                goto out;
                        mac->basic_rates = basic_rates;
                        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_BASIC_RATE,
                                        (u8 *) (&basic_rates));
-                        if (rtlpriv->dm.useramask)
-                                rtlpriv->cfg->ops->update_rate_mask(hw, 0);
-                        else
-                                rtlpriv->cfg->ops->update_rate_table(hw);
                }
+                rcu_read_unlock();
        }
        /*
@@ -760,16 +824,17 @@ static int rtl_op_ampdu_action(struct ieee80211_hw *hw,
        case IEEE80211_AMPDU_TX_START:
                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_TRACE,
                         ("IEEE80211_AMPDU_TX_START: TID:%d\n", tid));
-                return rtl_tx_agg_start(hw, sta->addr, tid, ssn);
+                return rtl_tx_agg_start(hw, sta, tid, ssn);
                break;
        case IEEE80211_AMPDU_TX_STOP:
                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_TRACE,
                         ("IEEE80211_AMPDU_TX_STOP: TID:%d\n", tid));
-                return rtl_tx_agg_stop(hw, sta->addr, tid);
+                return rtl_tx_agg_stop(hw, sta, tid);
                break;
        case IEEE80211_AMPDU_TX_OPERATIONAL:
                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_TRACE,
                         ("IEEE80211_AMPDU_TX_OPERATIONAL:TID:%d\n", tid));
+                rtl_tx_agg_oper(hw, sta, tid);
                break;
        case IEEE80211_AMPDU_RX_START:
                RT_TRACE(rtlpriv, COMP_MAC80211, DBG_TRACE,
@@ -799,8 +864,12 @@ static void rtl_op_sw_scan_start(struct ieee80211_hw *hw)
        if (mac->link_state == MAC80211_LINKED) {
                rtl_lps_leave(hw);
                mac->link_state = MAC80211_LINKED_SCANNING;
-        } else
+        } else {
                rtl_ips_nic_on(hw);
+        }
+        /* Dual mac */
+        rtlpriv->rtlhal.load_imrandiqk_setting_for2g = false;
        rtlpriv->cfg->ops->led_control(hw, LED_CTL_SITE_SURVEY);
        rtlpriv->cfg->ops->scan_operation_backup(hw, SCAN_OPT_BACKUP);
@@ -812,22 +881,19 @@ static void rtl_op_sw_scan_complete(struct ieee80211_hw *hw)
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD, ("\n"));
-        rtlpriv->cfg->ops->scan_operation_backup(hw, SCAN_OPT_RESTORE);
        mac->act_scanning = false;
+        /* Dual mac */
+        rtlpriv->rtlhal.load_imrandiqk_setting_for2g = false;
        if (mac->link_state == MAC80211_LINKED_SCANNING) {
                mac->link_state = MAC80211_LINKED;
+                if (mac->opmode == NL80211_IFTYPE_STATION) {
-                /* fix fwlps issue */
+                        /* fix fwlps issue */
-                rtlpriv->cfg->ops->set_network_type(hw, mac->opmode);
+                        rtlpriv->cfg->ops->set_network_type(hw, mac->opmode);
+                }
-                if (rtlpriv->dm.useramask)
-                        rtlpriv->cfg->ops->update_rate_mask(hw, 0);
-                else
-                        rtlpriv->cfg->ops->update_rate_table(hw);
        }
+        rtlpriv->cfg->ops->scan_operation_backup(hw, SCAN_OPT_RESTORE);
 }
 static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
@@ -858,49 +924,73 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
        rtl_ips_nic_on(hw);
        mutex_lock(&rtlpriv->locks.conf_mutex);
        /* <1> get encryption alg */
        switch (key->cipher) {
        case WLAN_CIPHER_SUITE_WEP40:
                key_type = WEP40_ENCRYPTION;
                RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG, ("alg:WEP40\n"));
-                rtlpriv->sec.use_defaultkey = true;
                break;
        case WLAN_CIPHER_SUITE_WEP104:
                RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
                         ("alg:WEP104\n"));
                key_type = WEP104_ENCRYPTION;
-                rtlpriv->sec.use_defaultkey = true;
                break;
        case WLAN_CIPHER_SUITE_TKIP:
                key_type = TKIP_ENCRYPTION;
                RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG, ("alg:TKIP\n"));
-                if (mac->opmode == NL80211_IFTYPE_ADHOC)
-                        rtlpriv->sec.use_defaultkey = true;
                break;
        case WLAN_CIPHER_SUITE_CCMP:
                key_type = AESCCMP_ENCRYPTION;
                RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG, ("alg:CCMP\n"));
-                if (mac->opmode == NL80211_IFTYPE_ADHOC)
-                        rtlpriv->sec.use_defaultkey = true;
                break;
        default:
                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
                         ("alg_err:%x!!!!:\n", key->cipher));
                goto out_unlock;
        }
+        if (key_type == WEP40_ENCRYPTION ||
+                        key_type == WEP104_ENCRYPTION ||
+                        mac->opmode == NL80211_IFTYPE_ADHOC)
+                rtlpriv->sec.use_defaultkey = true;
        /* <2> get key_idx */
        key_idx = (u8) (key->keyidx);
        if (key_idx > 3)
                goto out_unlock;
        /* <3> if pairwise key enable_hw_sec */
        group_key = !(key->flags & IEEE80211_KEY_FLAG_PAIRWISE);
-        if ((!group_key) || (mac->opmode == NL80211_IFTYPE_ADHOC) ||
-            rtlpriv->sec.pairwise_enc_algorithm == NO_ENCRYPTION) {
+        /* wep always be group key, but there are two conditions:
-                if (rtlpriv->sec.pairwise_enc_algorithm == NO_ENCRYPTION &&
+         * 1) wep only: is just for wep enc, in this condition
-                    (key_type == WEP40_ENCRYPTION ||
+         * rtlpriv->sec.pairwise_enc_algorithm == NO_ENCRYPTION
-                     key_type == WEP104_ENCRYPTION))
+         * will be true & enable_hw_sec will be set when wep
-                        wep_only = true;
+         * ke setting.
-                rtlpriv->sec.pairwise_enc_algorithm = key_type;
+         * 2) wep(group) + AES(pairwise): some AP like cisco
-                rtlpriv->cfg->ops->enable_hw_sec(hw);
+         * may use it, in this condition enable_hw_sec will not
+         * be set when wep key setting */
+        /* we must reset sec_info after lingked before set key,
+         * or some flag will be wrong*/
+        if (mac->opmode == NL80211_IFTYPE_AP) {
+                if (!group_key || key_type == WEP40_ENCRYPTION ||
+                        key_type == WEP104_ENCRYPTION) {
+                        if (group_key)
+                                wep_only = true;
+                        rtlpriv->cfg->ops->enable_hw_sec(hw);
+                }
+        } else {
+                if ((!group_key) || (mac->opmode == NL80211_IFTYPE_ADHOC) ||
+                     rtlpriv->sec.pairwise_enc_algorithm == NO_ENCRYPTION) {
+                        if (rtlpriv->sec.pairwise_enc_algorithm ==
+                            NO_ENCRYPTION &&
+                            (key_type == WEP40_ENCRYPTION ||
+                            key_type == WEP104_ENCRYPTION))
+                                wep_only = true;
+                        rtlpriv->sec.pairwise_enc_algorithm = key_type;
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                                ("set enable_hw_sec, key_type:%x(OPEN:0 WEP40:1"
+                                " TKIP:2 AES:4 WEP104:5)\n", key_type));
+                        rtlpriv->cfg->ops->enable_hw_sec(hw);
+                }
        }
        /* <4> set key based on cmd */
        switch (cmd) {
@@ -932,6 +1022,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
                        if (!sta) {
                                RT_ASSERT(false, ("pairwise key withnot"
                                                  "mac_addr\n"));
                                err = -EOPNOTSUPP;
                                goto out_unlock;
                        }
@@ -959,6 +1050,10 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
                RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
                         ("disable key delete one entry\n"));
                /*set local buf about wep key. */
+                if (mac->opmode == NL80211_IFTYPE_AP) {
+                        if (sta)
+                                rtl_cam_del_entry(hw, sta->addr);
+                }
                memset(rtlpriv->sec.key_buf[key_idx], 0, key->keylen);
                rtlpriv->sec.key_len[key_idx] = 0;
                memcpy(mac_addr, zero_addr, ETH_ALEN);
@@ -1011,6 +1106,18 @@ static void rtl_op_rfkill_poll(struct ieee80211_hw *hw)
        mutex_unlock(&rtlpriv->locks.conf_mutex);
 }
+/* this function is called by mac80211 to flush tx buffer
+ * before switch channle or power save, or tx buffer packet
+ * maybe send after offchannel or rf sleep, this may cause
+ * dis-association by AP */
+static void rtl_op_flush(struct ieee80211_hw *hw, bool drop)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        if (rtlpriv->intf_ops->flush)
+                rtlpriv->intf_ops->flush(hw, drop);
+}
 const struct ieee80211_ops rtl_ops = {
        .start = rtl_op_start,
        .stop = rtl_op_stop,
@@ -1019,6 +1126,8 @@ const struct ieee80211_ops rtl_ops = {
        .remove_interface = rtl_op_remove_interface,
        .config = rtl_op_config,
        .configure_filter = rtl_op_configure_filter,
+        .sta_add = rtl_op_sta_add,
+        .sta_remove = rtl_op_sta_remove,
        .set_key = rtl_op_set_key,
        .conf_tx = rtl_op_conf_tx,
        .bss_info_changed = rtl_op_bss_info_changed,
@@ -1030,4 +1139,5 @@ const struct ieee80211_ops rtl_ops = {
        .sw_scan_start = rtl_op_sw_scan_start,
        .sw_scan_complete = rtl_op_sw_scan_complete,
        .rfkill_poll = rtl_op_rfkill_poll,
+        .flush = rtl_op_flush,
 };
diff --git a/drivers/net/wireless/rtlwifi/core.h b/drivers/net/wireless/rtlwifi/core.h
index 0ef31c3c6196..4b247db2861d 100644
--- a/drivers/net/wireless/rtlwifi/core.h
+++ b/drivers/net/wireless/rtlwifi/core.h
@@ -24,6 +24,7 @@
 * Hsinchu 300, Taiwan.
 *
 * Larry Finger <Larry.Finger@lwfinger.net>
+ *
 *****************************************************************************/
 #ifndef __RTL_CORE_H__
diff --git a/drivers/net/wireless/rtlwifi/efuse.c b/drivers/net/wireless/rtlwifi/efuse.c
index 590f14f45a89..50de6f5d8a56 100644
--- a/drivers/net/wireless/rtlwifi/efuse.c
+++ b/drivers/net/wireless/rtlwifi/efuse.c
@@ -52,8 +52,6 @@ static const struct efuse_map RTL8712_SDIO_EFUSE_TABLE[] = {
        {11, 0, 0, 28}
 };
-static void read_efuse_byte(struct ieee80211_hw *hw, u16 _offset,
-                                        u8 *pbuf);
 static void efuse_shadow_read_1byte(struct ieee80211_hw *hw, u16 offset,
                                    u8 *value);
 static void efuse_shadow_read_2byte(struct ieee80211_hw *hw, u16 offset,
@@ -79,7 +77,7 @@ static void efuse_word_enable_data_read(u8 word_en, u8 *sourdata,
                                        u8 *targetdata);
 static u8 efuse_word_enable_data_write(struct ieee80211_hw *hw,
                                       u16 efuse_addr, u8 word_en, u8 *data);
-static void efuse_power_switch(struct ieee80211_hw *hw, u8 bwrite,
+static void efuse_power_switch(struct ieee80211_hw *hw, u8 write,
                                        u8 pwrstate);
 static u16 efuse_get_current_size(struct ieee80211_hw *hw);
 static u8 efuse_calculate_word_cnts(u8 word_en);
@@ -115,8 +113,10 @@ u8 efuse_read_1byte(struct ieee80211_hw *hw, u16 address)
        u8 bytetemp;
        u8 temp;
        u32 k = 0;
+        const u32 efuse_len =
+                rtlpriv->cfg->maps[EFUSE_REAL_CONTENT_SIZE];
-        if (address < EFUSE_REAL_CONTENT_LEN) {
+        if (address < efuse_len) {
                temp = address & 0xFF;
                rtl_write_byte(rtlpriv, rtlpriv->cfg->maps[EFUSE_CTRL] + 1,
                               temp);
@@ -158,11 +158,13 @@ void efuse_write_1byte(struct ieee80211_hw *hw, u16 address, u8 value)
        u8 bytetemp;
        u8 temp;
        u32 k = 0;
+        const u32 efuse_len =
+                rtlpriv->cfg->maps[EFUSE_REAL_CONTENT_SIZE];
        RT_TRACE(rtlpriv, COMP_EFUSE, DBG_LOUD,
                 ("Addr=%x Data =%x\n", address, value));
-        if (address < EFUSE_REAL_CONTENT_LEN) {
+        if (address < efuse_len) {
                rtl_write_byte(rtlpriv, rtlpriv->cfg->maps[EFUSE_CTRL], value);
                temp = address & 0xFF;
@@ -198,7 +200,7 @@ void efuse_write_1byte(struct ieee80211_hw *hw, u16 address, u8 value)
 }
-static void read_efuse_byte(struct ieee80211_hw *hw, u16 _offset, u8 *pbuf)
+void read_efuse_byte(struct ieee80211_hw *hw, u16 _offset, u8 *pbuf)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        u32 value32;
@@ -233,26 +235,45 @@ void read_efuse(struct ieee80211_hw *hw, u16 _offset, u16 _size_byte, u8 *pbuf)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
-        u8 efuse_tbl[EFUSE_MAP_LEN];
+        u8 *efuse_tbl;
        u8 rtemp8[1];
        u16 efuse_addr = 0;
        u8 offset, wren;
        u16 i;
        u16 j;
-        u16 efuse_word[EFUSE_MAX_SECTION][EFUSE_MAX_WORD_UNIT];
+        const u16 efuse_max_section =
+                rtlpriv->cfg->maps[EFUSE_MAX_SECTION_MAP];
+        const u32 efuse_len =
+                rtlpriv->cfg->maps[EFUSE_REAL_CONTENT_SIZE];
+        u16 **efuse_word;
        u16 efuse_utilized = 0;
        u8 efuse_usage;
-        if ((_offset + _size_byte) > EFUSE_MAP_LEN) {
+        if ((_offset + _size_byte) > rtlpriv->cfg->maps[EFUSE_HWSET_MAX_SIZE]) {
                RT_TRACE(rtlpriv, COMP_EFUSE, DBG_LOUD,
                         ("read_efuse(): Invalid offset(%#x) with read "
                          "bytes(%#x)!!\n", _offset, _size_byte));
                return;
        }
-        for (i = 0; i < EFUSE_MAX_SECTION; i++)
+        /* allocate memory for efuse_tbl and efuse_word */
+        efuse_tbl = kmalloc(rtlpriv->cfg->maps[EFUSE_HWSET_MAX_SIZE] *
+                            sizeof(u8), GFP_ATOMIC);
+        if (!efuse_tbl)
+                return;
+        efuse_word = kmalloc(EFUSE_MAX_WORD_UNIT * sizeof(u16 *), GFP_ATOMIC);
+        if (!efuse_word)
+                goto done;
+        for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++) {
+                efuse_word[i] = kmalloc(efuse_max_section * sizeof(u16),
+                                        GFP_ATOMIC);
+                if (!efuse_word[i])
+                        goto done;
+        }
+        for (i = 0; i < efuse_max_section; i++)
                for (j = 0; j < EFUSE_MAX_WORD_UNIT; j++)
-                        efuse_word[i][j] = 0xFFFF;
+                        efuse_word[j][i] = 0xFFFF;
        read_efuse_byte(hw, efuse_addr, rtemp8);
        if (*rtemp8 != 0xFF) {
@@ -262,10 +283,10 @@ void read_efuse(struct ieee80211_hw *hw, u16 _offset, u16 _size_byte, u8 *pbuf)
                efuse_addr++;
        }
-        while ((*rtemp8 != 0xFF) && (efuse_addr < EFUSE_REAL_CONTENT_LEN)) {
+        while ((*rtemp8 != 0xFF) && (efuse_addr < efuse_len)) {
                offset = ((*rtemp8 >> 4) & 0x0f);
-                if (offset < EFUSE_MAX_SECTION) {
+                if (offset < efuse_max_section) {
                        wren = (*rtemp8 & 0x0f);
                        RTPRINT(rtlpriv, FEEPROM, EFUSE_READ_ALL,
                                ("offset-%d Worden=%x\n", offset, wren));
@@ -279,9 +300,10 @@ void read_efuse(struct ieee80211_hw *hw, u16 _offset, u16 _size_byte, u8 *pbuf)
                                        read_efuse_byte(hw, efuse_addr, rtemp8);
                                        efuse_addr++;
                                        efuse_utilized++;
-                                        efuse_word[offset][i] = (*rtemp8 & 0xff);
+                                        efuse_word[i][offset] =
+                                                         (*rtemp8 & 0xff);
-                                        if (efuse_addr >= EFUSE_REAL_CONTENT_LEN)
+                                        if (efuse_addr >= efuse_len)
                                                break;
                                        RTPRINT(rtlpriv, FEEPROM,
@@ -291,10 +313,10 @@ void read_efuse(struct ieee80211_hw *hw, u16 _offset, u16 _size_byte, u8 *pbuf)
                                        read_efuse_byte(hw, efuse_addr, rtemp8);
                                        efuse_addr++;
                                        efuse_utilized++;
-                                        efuse_word[offset][i] |=
+                                        efuse_word[i][offset] |=
                                            (((u16)*rtemp8 << 8) & 0xff00);
-                                        if (efuse_addr >= EFUSE_REAL_CONTENT_LEN)
+                                        if (efuse_addr >= efuse_len)
                                                break;
                                }
@@ -305,18 +327,18 @@ void read_efuse(struct ieee80211_hw *hw, u16 _offset, u16 _size_byte, u8 *pbuf)
                RTPRINT(rtlpriv, FEEPROM, EFUSE_READ_ALL,
                        ("Addr=%d\n", efuse_addr));
                read_efuse_byte(hw, efuse_addr, rtemp8);
-                if (*rtemp8 != 0xFF && (efuse_addr < 512)) {
+                if (*rtemp8 != 0xFF && (efuse_addr < efuse_len)) {
                        efuse_utilized++;
                        efuse_addr++;
                }
        }
-        for (i = 0; i < EFUSE_MAX_SECTION; i++) {
+        for (i = 0; i < efuse_max_section; i++) {
                for (j = 0; j < EFUSE_MAX_WORD_UNIT; j++) {
                        efuse_tbl[(i * 8) + (j * 2)] =
-                            (efuse_word[i][j] & 0xff);
+                            (efuse_word[j][i] & 0xff);
                        efuse_tbl[(i * 8) + ((j * 2) + 1)] =
-                            ((efuse_word[i][j] >> 8) & 0xff);
+                            ((efuse_word[j][i] >> 8) & 0xff);
                }
        }
@@ -324,12 +346,17 @@ void read_efuse(struct ieee80211_hw *hw, u16 _offset, u16 _size_byte, u8 *pbuf)
                pbuf[i] = efuse_tbl[_offset + i];
        rtlefuse->efuse_usedbytes = efuse_utilized;
-        efuse_usage = (u8)((efuse_utilized * 100) / EFUSE_REAL_CONTENT_LEN);
+        efuse_usage = (u8) ((efuse_utilized * 100) / efuse_len);
        rtlefuse->efuse_usedpercentage = efuse_usage;
        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_EFUSE_BYTES,
                                      (u8 *)&efuse_utilized);
        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_EFUSE_USAGE,
                                      (u8 *)&efuse_usage);
+done:
+        for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++)
+                kfree(efuse_word[i]);
+        kfree(efuse_word);
+        kfree(efuse_tbl);
 }
 bool efuse_shadow_update_chk(struct ieee80211_hw *hw)
@@ -338,11 +365,11 @@ bool efuse_shadow_update_chk(struct ieee80211_hw *hw)
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
        u8 section_idx, i, Base;
        u16 words_need = 0, hdr_num = 0, totalbytes, efuse_used;
-        bool bwordchanged, bresult = true;
+        bool wordchanged, result = true;
        for (section_idx = 0; section_idx < 16; section_idx++) {
                Base = section_idx * 8;
-                bwordchanged = false;
+                wordchanged = false;
                for (i = 0; i < 8; i = i + 2) {
                        if ((rtlefuse->efuse_map[EFUSE_INIT_MAP][Base + i] !=
@@ -351,11 +378,11 @@ bool efuse_shadow_update_chk(struct ieee80211_hw *hw)
                             rtlefuse->efuse_map[EFUSE_MODIFY_MAP][Base + i +
                                                                   1])) {
                                words_need++;
-                                bwordchanged = true;
+                                wordchanged = true;
                        }
                }
-                if (bwordchanged == true)
+                if (wordchanged == true)
                        hdr_num++;
        }
@@ -364,14 +391,14 @@ bool efuse_shadow_update_chk(struct ieee80211_hw *hw)
        if ((totalbytes + efuse_used) >=
            (EFUSE_MAX_SIZE - EFUSE_OOB_PROTECT_BYTES))
-                bresult = false;
+                result = false;
        RT_TRACE(rtlpriv, COMP_EFUSE, DBG_LOUD,
                 ("efuse_shadow_update_chk(): totalbytes(%#x), "
                  "hdr_num(%#x), words_need(%#x), efuse_used(%d)\n",
                  totalbytes, hdr_num, words_need, efuse_used));
-        return bresult;
+        return result;
 }
 void efuse_shadow_read(struct ieee80211_hw *hw, u8 type,
@@ -394,7 +421,7 @@ void efuse_shadow_write(struct ieee80211_hw *hw, u8 type, u16 offset,
        else if (type == 2)
                efuse_shadow_write_2byte(hw, offset, (u16) value);
        else if (type == 4)
-                efuse_shadow_write_4byte(hw, offset, (u32) value);
+                efuse_shadow_write_4byte(hw, offset, value);
 }
@@ -478,9 +505,10 @@ void rtl_efuse_shadow_map_update(struct ieee80211_hw *hw)
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
-        if (rtlefuse->autoload_failflag == true) {
+        if (rtlefuse->autoload_failflag == true)
-                memset(&rtlefuse->efuse_map[EFUSE_INIT_MAP][0], 0xFF, 128);
+                memset(&rtlefuse->efuse_map[EFUSE_INIT_MAP][0], 0xFF,
-        } else
+                        rtlpriv->cfg->maps[EFUSE_HWSET_MAX_SIZE]);
+        else
                efuse_read_all_map(hw, &rtlefuse->efuse_map[EFUSE_INIT_MAP][0]);
        memcpy(&rtlefuse->efuse_map[EFUSE_MODIFY_MAP][0],
@@ -572,7 +600,7 @@ static int efuse_one_byte_read(struct ieee80211_hw *hw, u16 addr, u8 *data)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        u8 tmpidx = 0;
-        int bresult;
+        int result;
        rtl_write_byte(rtlpriv, rtlpriv->cfg->maps[EFUSE_CTRL] + 1,
                       (u8) (addr & 0xff));
@@ -592,19 +620,18 @@ static int efuse_one_byte_read(struct ieee80211_hw *hw, u16 addr, u8 *data)
        if (tmpidx < 100) {
                *data = rtl_read_byte(rtlpriv, rtlpriv->cfg->maps[EFUSE_CTRL]);
-                bresult = true;
+                result = true;
        } else {
                *data = 0xff;
-                bresult = false;
+                result = false;
        }
-        return bresult;
+        return result;
 }
 static int efuse_one_byte_write(struct ieee80211_hw *hw, u16 addr, u8 data)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        u8 tmpidx = 0;
-        bool bresult;
        RT_TRACE(rtlpriv, COMP_EFUSE, DBG_LOUD,
                 ("Addr = %x Data=%x\n", addr, data));
@@ -626,17 +653,16 @@ static int efuse_one_byte_write(struct ieee80211_hw *hw, u16 addr, u8 data)
        }
        if (tmpidx < 100)
-                bresult = true;
+                return true;
-        else
-                bresult = false;
-        return bresult;
+        return false;
 }
 static void efuse_read_all_map(struct ieee80211_hw *hw, u8 * efuse)
 {
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
        efuse_power_switch(hw, false, true);
-        read_efuse(hw, 0, 128, efuse);
+        read_efuse(hw, 0, rtlpriv->cfg->maps[EFUSE_HWSET_MAX_SIZE], efuse);
        efuse_power_switch(hw, false, false);
 }
@@ -644,7 +670,7 @@ static void efuse_read_data_case1(struct ieee80211_hw *hw, u16 *efuse_addr,
                                u8 efuse_data, u8 offset, u8 *tmpdata,
                                u8 *readstate)
 {
-        bool bdataempty = true;
+        bool dataempty = true;
        u8 hoffset;
        u8 tmpidx;
        u8 hworden;
@@ -660,13 +686,13 @@ static void efuse_read_data_case1(struct ieee80211_hw *hw, u16 *efuse_addr,
                            &efuse_data)) {
                                tmpdata[tmpidx] = efuse_data;
                                if (efuse_data != 0xff)
-                                        bdataempty = true;
+                                        dataempty = true;
                        }
                }
-                if (bdataempty == true)
+                if (dataempty == true) {
                        *readstate = PG_STATE_DATA;
-                else {
+                } else {
                        *efuse_addr = *efuse_addr + (word_cnts * 2) + 1;
                        *readstate = PG_STATE_HEADER;
                }
@@ -680,12 +706,9 @@ static void efuse_read_data_case1(struct ieee80211_hw *hw, u16 *efuse_addr,
 static int efuse_pg_packet_read(struct ieee80211_hw *hw, u8 offset, u8 *data)
 {
        u8 readstate = PG_STATE_HEADER;
+        bool continual = true;
-        bool bcontinual = true;
        u8 efuse_data, word_cnts = 0;
        u16 efuse_addr = 0;
-        u8 hworden = 0;
        u8 tmpdata[8];
        if (data == NULL)
@@ -696,7 +719,7 @@ static int efuse_pg_packet_read(struct ieee80211_hw *hw, u8 offset, u8 *data)
        memset(data, 0xff, PGPKT_DATA_SIZE * sizeof(u8));
        memset(tmpdata, 0xff, PGPKT_DATA_SIZE * sizeof(u8));
-        while (bcontinual && (efuse_addr < EFUSE_MAX_SIZE)) {
+        while (continual && (efuse_addr < EFUSE_MAX_SIZE)) {
                if (readstate & PG_STATE_HEADER) {
                        if (efuse_one_byte_read(hw, efuse_addr, &efuse_data)
                            && (efuse_data != 0xFF))
@@ -705,9 +728,9 @@ static int efuse_pg_packet_read(struct ieee80211_hw *hw, u8 offset, u8 *data)
                                                      offset, tmpdata,
                                                      &readstate);
                        else
-                                bcontinual = false;
+                                continual = false;
                } else if (readstate & PG_STATE_DATA) {
-                        efuse_word_enable_data_read(hworden, tmpdata, data);
+                        efuse_word_enable_data_read(0, tmpdata, data);
                        efuse_addr = efuse_addr + (word_cnts * 2) + 1;
                        readstate = PG_STATE_HEADER;
                }
@@ -725,13 +748,13 @@ static int efuse_pg_packet_read(struct ieee80211_hw *hw, u8 offset, u8 *data)
 }
 static void efuse_write_data_case1(struct ieee80211_hw *hw, u16 *efuse_addr,
-                        u8 efuse_data, u8 offset, int *bcontinual,
+                        u8 efuse_data, u8 offset, int *continual,
                        u8 *write_state, struct pgpkt_struct *target_pkt,
-                        int *repeat_times, int *bresult, u8 word_en)
+                        int *repeat_times, int *result, u8 word_en)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct pgpkt_struct tmp_pkt;
-        int bdataempty = true;
+        bool dataempty = true;
        u8 originaldata[8 * sizeof(u8)];
        u8 badworden = 0x0F;
        u8 match_word_en, tmp_word_en;
@@ -751,10 +774,10 @@ static void efuse_write_data_case1(struct ieee80211_hw *hw, u16 *efuse_addr,
                        u16 address = *efuse_addr + 1 + tmpindex;
                        if (efuse_one_byte_read(hw, address,
                             &efuse_data) && (efuse_data != 0xFF))
-                                bdataempty = false;
+                                dataempty = false;
                }
-                if (bdataempty == false) {
+                if (dataempty == false) {
                        *efuse_addr = *efuse_addr + (tmp_word_cnts * 2) + 1;
                        *write_state = PG_STATE_HEADER;
                } else {
@@ -799,24 +822,25 @@ static void efuse_write_data_case1(struct ieee80211_hw *hw, u16 *efuse_addr,
                                        tmp_word_en &= (~BIT(1));
                                if ((target_pkt->word_en & BIT(2)) ^
-                                        (match_word_en & BIT(2)))
+                                     (match_word_en & BIT(2)))
                                        tmp_word_en &= (~BIT(2));
                                if ((target_pkt->word_en & BIT(3)) ^
-                                    (match_word_en & BIT(3)))
+                                     (match_word_en & BIT(3)))
                                        tmp_word_en &= (~BIT(3));
                                if ((tmp_word_en & 0x0F) != 0x0F) {
                                        *efuse_addr = efuse_get_current_size(hw);
                                        target_pkt->offset = offset;
                                        target_pkt->word_en = tmp_word_en;
-                                } else
+                                } else {
-                                        *bcontinual = false;
+                                        *continual = false;
+                                }
                                *write_state = PG_STATE_HEADER;
                                *repeat_times += 1;
                                if (*repeat_times > EFUSE_REPEAT_THRESHOLD_) {
-                                        *bcontinual = false;
+                                        *continual = false;
-                                        *bresult = false;
+                                        *result = false;
                                }
                        } else {
                                *efuse_addr += (2 * tmp_word_cnts) + 1;
@@ -830,9 +854,9 @@ static void efuse_write_data_case1(struct ieee80211_hw *hw, u16 *efuse_addr,
 }
 static void efuse_write_data_case2(struct ieee80211_hw *hw, u16 *efuse_addr,
-                                   int *bcontinual, u8 *write_state,
+                                   int *continual, u8 *write_state,
                                   struct pgpkt_struct target_pkt,
-                                   int *repeat_times, int *bresult)
+                                   int *repeat_times, int *result)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct pgpkt_struct tmp_pkt;
@@ -846,14 +870,14 @@ static void efuse_write_data_case2(struct ieee80211_hw *hw, u16 *efuse_addr,
        efuse_one_byte_write(hw, *efuse_addr, pg_header);
        efuse_one_byte_read(hw, *efuse_addr, &tmp_header);
-        if (tmp_header == pg_header)
+        if (tmp_header == pg_header) {
                *write_state = PG_STATE_DATA;
-        else if (tmp_header == 0xFF) {
+        } else if (tmp_header == 0xFF) {
                *write_state = PG_STATE_HEADER;
                *repeat_times += 1;
                if (*repeat_times > EFUSE_REPEAT_THRESHOLD_) {
-                        *bcontinual = false;
+                        *continual = false;
-                        *bresult = false;
+                        *result = false;
                }
        } else {
                tmp_pkt.offset = (tmp_header >> 4) & 0x0F;
@@ -875,17 +899,19 @@ static void efuse_write_data_case2(struct ieee80211_hw *hw, u16 *efuse_addr,
                                                      reorg_worden,
                                                      originaldata);
                                *efuse_addr = efuse_get_current_size(hw);
-                         } else
+                        } else {
                                *efuse_addr = *efuse_addr + (tmp_word_cnts * 2)
                                              + 1;
-                } else
+                        }
+                } else {
                        *efuse_addr = *efuse_addr + (tmp_word_cnts * 2) + 1;
+                }
                *write_state = PG_STATE_HEADER;
                *repeat_times += 1;
                if (*repeat_times > EFUSE_REPEAT_THRESHOLD_) {
-                        *bcontinual = false;
+                        *continual = false;
-                        *bresult = false;
+                        *result = false;
                }
                RTPRINT(rtlpriv, FEEPROM, EFUSE_PG,
@@ -899,7 +925,7 @@ static int efuse_pg_packet_write(struct ieee80211_hw *hw,
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct pgpkt_struct target_pkt;
        u8 write_state = PG_STATE_HEADER;
-        int bcontinual = true, bdataempty = true, bresult = true;
+        int continual = true, dataempty = true, result = true;
        u16 efuse_addr = 0;
        u8 efuse_data;
        u8 target_word_cnts = 0;
@@ -923,11 +949,11 @@ static int efuse_pg_packet_write(struct ieee80211_hw *hw,
        RTPRINT(rtlpriv, FEEPROM, EFUSE_PG, ("efuse Power ON\n"));
-        while (bcontinual && (efuse_addr <
+        while (continual && (efuse_addr <
               (EFUSE_MAX_SIZE - EFUSE_OOB_PROTECT_BYTES))) {
                if (write_state == PG_STATE_HEADER) {
-                        bdataempty = true;
+                        dataempty = true;
                        badworden = 0x0F;
                        RTPRINT(rtlpriv, FEEPROM, EFUSE_PG,
                                ("efuse PG_STATE_HEADER\n"));
@@ -936,32 +962,30 @@ static int efuse_pg_packet_write(struct ieee80211_hw *hw,
                            (efuse_data != 0xFF))
                                efuse_write_data_case1(hw, &efuse_addr,
                                                       efuse_data, offset,
-                                                       &bcontinual,
+                                                       &continual,
                                                       &write_state, &target_pkt,
-                                                       &repeat_times, &bresult,
+                                                       &repeat_times, &result,
                                                       word_en);
                        else
                                efuse_write_data_case2(hw, &efuse_addr,
-                                                       &bcontinual,
+                                                       &continual,
                                                       &write_state,
                                                       target_pkt,
                                                       &repeat_times,
-                                                       &bresult);
+                                                       &result);
                } else if (write_state == PG_STATE_DATA) {
                        RTPRINT(rtlpriv, FEEPROM, EFUSE_PG,
                                ("efuse PG_STATE_DATA\n"));
-                        badworden = 0x0f;
                        badworden =
                            efuse_word_enable_data_write(hw, efuse_addr + 1,
                                                         target_pkt.word_en,
                                                         target_pkt.data);
                        if ((badworden & 0x0F) == 0x0F) {
-                                bcontinual = false;
+                                continual = false;
                        } else {
-                                efuse_addr =
+                                efuse_addr += (2 * target_word_cnts) + 1;
-                                    efuse_addr + (2 * target_word_cnts) + 1;
                                target_pkt.offset = offset;
                                target_pkt.word_en = badworden;
@@ -971,8 +995,8 @@ static int efuse_pg_packet_write(struct ieee80211_hw *hw,
                                write_state = PG_STATE_HEADER;
                                repeat_times++;
                                if (repeat_times > EFUSE_REPEAT_THRESHOLD_) {
-                                        bcontinual = false;
+                                        continual = false;
-                                        bresult = false;
+                                        result = false;
                                }
                                RTPRINT(rtlpriv, FEEPROM, EFUSE_PG,
                                        ("efuse PG_STATE_HEADER-3\n"));
@@ -1072,13 +1096,15 @@ static u8 efuse_word_enable_data_write(struct ieee80211_hw *hw,
        return badworden;
 }
-static void efuse_power_switch(struct ieee80211_hw *hw, u8 bwrite, u8 pwrstate)
+static void efuse_power_switch(struct ieee80211_hw *hw, u8 write, u8 pwrstate)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
        u8 tempval;
        u16 tmpV16;
-        if (pwrstate == true) {
+        if (pwrstate && (rtlhal->hw_type !=
+                HARDWARE_TYPE_RTL8192SE)) {
                tmpV16 = rtl_read_word(rtlpriv,
                                       rtlpriv->cfg->maps[SYS_ISO_CTRL]);
                if (!(tmpV16 & rtlpriv->cfg->maps[EFUSE_PWC_EV12V])) {
@@ -1106,20 +1132,29 @@ static void efuse_power_switch(struct ieee80211_hw *hw, u8 bwrite, u8 pwrstate)
                }
        }
-        if (pwrstate == true) {
+        if (pwrstate) {
-                if (bwrite == true) {
+                if (write) {
                        tempval = rtl_read_byte(rtlpriv,
                                                rtlpriv->cfg->maps[EFUSE_TEST] +
                                                3);
-                        tempval &= 0x0F;
-                        tempval |= (VOLTAGE_V25 << 4);
+                        if (rtlhal->hw_type != HARDWARE_TYPE_RTL8192SE) {
+                                tempval &= 0x0F;
+                                tempval |= (VOLTAGE_V25 << 4);
+                        }
                        rtl_write_byte(rtlpriv,
                                       rtlpriv->cfg->maps[EFUSE_TEST] + 3,
                                       (tempval | 0x80));
                }
+                if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE) {
+                        rtl_write_byte(rtlpriv, rtlpriv->cfg->maps[EFUSE_CLK],
+                                                0x03);
+                }
        } else {
-                if (bwrite == true) {
+                if (write) {
                        tempval = rtl_read_byte(rtlpriv,
                                                rtlpriv->cfg->maps[EFUSE_TEST] +
                                                3);
@@ -1128,18 +1163,23 @@ static void efuse_power_switch(struct ieee80211_hw *hw, u8 bwrite, u8 pwrstate)
                                       (tempval & 0x7F));
                }
+                if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE) {
+                        rtl_write_byte(rtlpriv, rtlpriv->cfg->maps[EFUSE_CLK],
+                                                0x02);
+                }
        }
 }
 static u16 efuse_get_current_size(struct ieee80211_hw *hw)
 {
-        int bcontinual = true;
+        int continual = true;
        u16 efuse_addr = 0;
        u8 hoffset, hworden;
        u8 efuse_data, word_cnts;
-        while (bcontinual && efuse_one_byte_read(hw, efuse_addr, &efuse_data)
+        while (continual && efuse_one_byte_read(hw, efuse_addr, &efuse_data)
               && (efuse_addr < EFUSE_MAX_SIZE)) {
                if (efuse_data != 0xFF) {
                        hoffset = (efuse_data >> 4) & 0x0F;
@@ -1147,7 +1187,7 @@ static u16 efuse_get_current_size(struct ieee80211_hw *hw)
                        word_cnts = efuse_calculate_word_cnts(hworden);
                        efuse_addr = efuse_addr + (word_cnts * 2) + 1;
                } else {
-                        bcontinual = false;
+                        continual = false;
                }
        }
diff --git a/drivers/net/wireless/rtlwifi/efuse.h b/drivers/net/wireless/rtlwifi/efuse.h
index 47774dd4c2a6..164dabaa7615 100644
--- a/drivers/net/wireless/rtlwifi/efuse.h
+++ b/drivers/net/wireless/rtlwifi/efuse.h
@@ -30,9 +30,10 @@
 #ifndef __RTL_EFUSE_H_
 #define __RTL_EFUSE_H_
+#define EFUSE_IC_ID_OFFSET              506
 #define EFUSE_REAL_CONTENT_LEN          512
 #define EFUSE_MAP_LEN                   128
-#define EFUSE_MAX_SECTION               16
 #define EFUSE_MAX_WORD_UNIT             4
 #define EFUSE_INIT_MAP                  0
@@ -52,6 +53,7 @@
 #define _PRE_EXECUTE_READ_CMD_
 #define EFUSE_REPEAT_THRESHOLD_         3
+#define EFUSE_ERROE_HANDLE              1
 struct efuse_map {
        u8 offset;
@@ -103,6 +105,7 @@ struct efuse_priv {
        u8 tx_power_g[14];
 };
+extern void read_efuse_byte(struct ieee80211_hw *hw, u16 _offset, u8 *pbuf);
 extern void efuse_initialize(struct ieee80211_hw *hw);
 extern u8 efuse_read_1byte(struct ieee80211_hw *hw, u16 address);
 extern void efuse_write_1byte(struct ieee80211_hw *hw, u16 address, u8 value);
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 5938f6ee21e4..a40952845436 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -32,6 +32,7 @@
 #include "pci.h"
 #include "base.h"
 #include "ps.h"
+#include "efuse.h"
 static const u16 pcibridge_vendors[PCI_BRIDGE_VENDOR_MAX] = {
        INTEL_VENDOR_ID,
@@ -40,6 +41,31 @@ static const u16 pcibridge_vendors[PCI_BRIDGE_VENDOR_MAX] = {
        SIS_VENDOR_ID
 };
+static const u8 ac_to_hwq[] = {
+        VO_QUEUE,
+        VI_QUEUE,
+        BE_QUEUE,
+        BK_QUEUE
+};
+static u8 _rtl_mac_to_hwqueue(struct ieee80211_hw *hw,
+                       struct sk_buff *skb)
+{
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        __le16 fc = rtl_get_fc(skb);
+        u8 queue_index = skb_get_queue_mapping(skb);
+        if (unlikely(ieee80211_is_beacon(fc)))
+                return BEACON_QUEUE;
+        if (ieee80211_is_mgmt(fc))
+                return MGNT_QUEUE;
+        if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE)
+                if (ieee80211_is_nullfunc(fc))
+                        return HIGH_QUEUE;
+        return ac_to_hwq[queue_index];
+}
 /* Update PCI dependent default settings*/
 static void _rtl_pci_update_default_setting(struct ieee80211_hw *hw)
 {
@@ -48,6 +74,7 @@ static void _rtl_pci_update_default_setting(struct ieee80211_hw *hw)
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
        u8 pcibridge_vendor = pcipriv->ndis_adapter.pcibridge_vendor;
+        u8 init_aspm;
        ppsc->reg_rfps_level = 0;
        ppsc->support_aspm = 0;
@@ -125,7 +152,7 @@ static void _rtl_pci_update_default_setting(struct ieee80211_hw *hw)
                        bool support_backdoor = true;
                        ppsc->support_aspm = support_aspm;
-                        /*if(priv->oem_id == RT_CID_TOSHIBA &&
+                        /*if (priv->oem_id == RT_CID_TOSHIBA &&
                           !priv->ndis_adapter.amd_l1_patch)
                           support_backdoor = false; */
@@ -145,6 +172,13 @@ static void _rtl_pci_update_default_setting(struct ieee80211_hw *hw)
                         ("switch case not process\n"));
                break;
        }
+        /* toshiba aspm issue, toshiba will set aspm selfly
+         * so we should not set aspm in driver */
+        pci_read_config_byte(rtlpci->pdev, 0x80, &init_aspm);
+        if (rtlpriv->rtlhal.hw_type == HARDWARE_TYPE_RTL8192SE &&
+                init_aspm == 0x43)
+                ppsc->support_aspm = false;
 }
 static bool _rtl_pci_platform_switch_device_pci_aspm(
@@ -152,28 +186,28 @@ static bool _rtl_pci_platform_switch_device_pci_aspm(
                        u8 value)
 {
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
-        bool bresult = false;
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
-        value |= 0x40;
+        if (rtlhal->hw_type != HARDWARE_TYPE_RTL8192SE)
+                value |= 0x40;
        pci_write_config_byte(rtlpci->pdev, 0x80, value);
-        return bresult;
+        return false;
 }
 /*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/
 static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
 {
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
-        u8 buffer;
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
-        bool bresult = false;
-        buffer = value;
        pci_write_config_byte(rtlpci->pdev, 0x81, value);
-        bresult = true;
-        return bresult;
+        if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE)
+                udelay(100);
+        return true;
 }
 /*Disable RTL8192SE ASPM & Disable Pci Bridge ASPM*/
@@ -191,6 +225,10 @@ static void rtl_pci_disable_aspm(struct ieee80211_hw *hw)
        u16 pcibridge_linkctrlreg = pcipriv->ndis_adapter.
                                pcibridge_linkctrlreg;
        u16 aspmlevel = 0;
+        u8 tmp_u1b = 0;
+        if (!ppsc->support_aspm)
+                return;
        if (pcibridge_vendor == PCI_BRIDGE_VENDOR_UNKNOWN) {
                RT_TRACE(rtlpriv, COMP_POWER, DBG_TRACE,
@@ -204,11 +242,8 @@ static void rtl_pci_disable_aspm(struct ieee80211_hw *hw)
                _rtl_pci_switch_clk_req(hw, 0x0);
        }
-        if (1) {
+        /*for promising device will in L0 state after an I/O. */
-                /*for promising device will in L0 state after an I/O. */
+        pci_read_config_byte(rtlpci->pdev, 0x80, &tmp_u1b);
-                u8 tmp_u1b;
-                pci_read_config_byte(rtlpci->pdev, 0x80, &tmp_u1b);
-        }
        /*Set corresponding value. */
        aspmlevel |= BIT(0) | BIT(1);
@@ -224,7 +259,6 @@ static void rtl_pci_disable_aspm(struct ieee80211_hw *hw)
        rtl_pci_raw_write_port_uchar(PCI_CONF_DATA, pcibridge_linkctrlreg);
        udelay(50);
 }
 /*
@@ -249,6 +283,9 @@ static void rtl_pci_enable_aspm(struct ieee80211_hw *hw)
        u8 u_pcibridge_aspmsetting;
        u8 u_device_aspmsetting;
+        if (!ppsc->support_aspm)
+                return;
        if (pcibridge_vendor == PCI_BRIDGE_VENDOR_UNKNOWN) {
                RT_TRACE(rtlpriv, COMP_POWER, DBG_TRACE,
                         ("PCI(Bridge) UNKNOWN.\n"));
@@ -293,7 +330,7 @@ static void rtl_pci_enable_aspm(struct ieee80211_hw *hw)
                                             RT_RF_OFF_LEVL_CLK_REQ) ? 1 : 0);
                RT_SET_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_CLK_REQ);
        }
-        udelay(200);
+        udelay(100);
 }
 static bool rtl_pci_get_amd_l1_patch(struct ieee80211_hw *hw)
@@ -330,13 +367,13 @@ static void rtl_pci_get_linkcontrol_field(struct ieee80211_hw *hw)
        u8 capabilityoffset = pcipriv->ndis_adapter.pcibridge_pciehdr_offset;
        u32 pcicfg_addrport = pcipriv->ndis_adapter.pcicfg_addrport;
        u8 linkctrl_reg;
-        u8 num4bBytes;
+        u8 num4bbytes;
-        num4bBytes = (capabilityoffset + 0x10) / 4;
+        num4bbytes = (capabilityoffset + 0x10) / 4;
        /*Read  Link Control Register */
        rtl_pci_raw_write_port_ulong(PCI_CONF_ADDRESS,
-                                     pcicfg_addrport + (num4bBytes << 2));
+                                     pcicfg_addrport + (num4bbytes << 2));
        rtl_pci_raw_read_port_uchar(PCI_CONF_DATA, &linkctrl_reg);
        pcipriv->ndis_adapter.pcibridge_linkctrlreg = linkctrl_reg;
@@ -369,7 +406,7 @@ static void rtl_pci_parse_configuration(struct pci_dev *pdev,
        pci_write_config_byte(pdev, 0x70f, tmp);
 }
-static void _rtl_pci_initialize_adapter_common(struct ieee80211_hw *hw)
+static void rtl_pci_init_aspm(struct ieee80211_hw *hw)
 {
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
@@ -383,52 +420,6 @@ static void _rtl_pci_initialize_adapter_common(struct ieee80211_hw *hw)
 }
-static void rtl_pci_init_aspm(struct ieee80211_hw *hw)
-{
-        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
-        /*close ASPM for AMD defaultly */
-        rtlpci->const_amdpci_aspm = 0;
-        /*
-         * ASPM PS mode.
-         * 0 - Disable ASPM,
-         * 1 - Enable ASPM without Clock Req,
-         * 2 - Enable ASPM with Clock Req,
-         * 3 - Always Enable ASPM with Clock Req,
-         * 4 - Always Enable ASPM without Clock Req.
-         * set defult to RTL8192CE:3 RTL8192E:2
-         * */
-        rtlpci->const_pci_aspm = 3;
-        /*Setting for PCI-E device */
-        rtlpci->const_devicepci_aspm_setting = 0x03;
-        /*Setting for PCI-E bridge */
-        rtlpci->const_hostpci_aspm_setting = 0x02;
-        /*
-         * In Hw/Sw Radio Off situation.
-         * 0 - Default,
-         * 1 - From ASPM setting without low Mac Pwr,
-         * 2 - From ASPM setting with low Mac Pwr,
-         * 3 - Bus D3
-         * set default to RTL8192CE:0 RTL8192SE:2
-         */
-        rtlpci->const_hwsw_rfoff_d3 = 0;
-        /*
-         * This setting works for those device with
-         * backdoor ASPM setting such as EPHY setting.
-         * 0 - Not support ASPM,
-         * 1 - Support ASPM,
-         * 2 - According to chipset.
-         */
-        rtlpci->const_support_pciaspm = 1;
-        _rtl_pci_initialize_adapter_common(hw);
-}
 static void _rtl_pci_io_handler_init(struct device *dev,
                                     struct ieee80211_hw *hw)
 {
@@ -450,6 +441,90 @@ static void _rtl_pci_io_handler_release(struct ieee80211_hw *hw)
 {
 }
+static bool _rtl_update_earlymode_info(struct ieee80211_hw *hw,
+                struct sk_buff *skb, struct rtl_tcb_desc *tcb_desc, u8 tid)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
+        u8 additionlen = FCS_LEN;
+        struct sk_buff *next_skb;
+        /* here open is 4, wep/tkip is 8, aes is 12*/
+        if (info->control.hw_key)
+                additionlen += info->control.hw_key->icv_len;
+        /* The most skb num is 6 */
+        tcb_desc->empkt_num = 0;
+        spin_lock_bh(&rtlpriv->locks.waitq_lock);
+        skb_queue_walk(&rtlpriv->mac80211.skb_waitq[tid], next_skb) {
+                struct ieee80211_tx_info *next_info;
+                next_info = IEEE80211_SKB_CB(next_skb);
+                if (next_info->flags & IEEE80211_TX_CTL_AMPDU) {
+                        tcb_desc->empkt_len[tcb_desc->empkt_num] =
+                                next_skb->len + additionlen;
+                        tcb_desc->empkt_num++;
+                } else {
+                        break;
+                }
+                if (skb_queue_is_last(&rtlpriv->mac80211.skb_waitq[tid],
+                                      next_skb))
+                        break;
+                if (tcb_desc->empkt_num >= 5)
+                        break;
+        }
+        spin_unlock_bh(&rtlpriv->locks.waitq_lock);
+        return true;
+}
+/* just for early mode now */
+static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct sk_buff *skb = NULL;
+        struct ieee80211_tx_info *info = NULL;
+        int tid; /* should be int */
+        if (!rtlpriv->rtlhal.earlymode_enable)
+                return;
+        /* we juse use em for BE/BK/VI/VO */
+        for (tid = 7; tid >= 0; tid--) {
+                u8 hw_queue = ac_to_hwq[rtl_tid_to_ac(hw, tid)];
+                struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[hw_queue];
+                while (!mac->act_scanning &&
+                       rtlpriv->psc.rfpwr_state == ERFON) {
+                        struct rtl_tcb_desc tcb_desc;
+                        memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
+                        spin_lock_bh(&rtlpriv->locks.waitq_lock);
+                        if (!skb_queue_empty(&mac->skb_waitq[tid]) &&
+                           (ring->entries - skb_queue_len(&ring->queue) > 5)) {
+                                skb = skb_dequeue(&mac->skb_waitq[tid]);
+                        } else {
+                                spin_unlock_bh(&rtlpriv->locks.waitq_lock);
+                                break;
+                        }
+                        spin_unlock_bh(&rtlpriv->locks.waitq_lock);
+                        /* Some macaddr can't do early mode. like
+                         * multicast/broadcast/no_qos data */
+                        info = IEEE80211_SKB_CB(skb);
+                        if (info->flags & IEEE80211_TX_CTL_AMPDU)
+                                _rtl_update_earlymode_info(hw, skb,
+                                                           &tcb_desc, tid);
+                        rtlpriv->intf_ops->adapter_tx(hw, skb, &tcb_desc);
+                }
+        }
+}
 static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int prio)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
@@ -461,6 +536,8 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int prio)
                struct rtl_tx_desc *entry = &ring->desc[ring->idx];
                struct sk_buff *skb;
                struct ieee80211_tx_info *info;
+                __le16 fc;
+                u8 tid;
                u8 own = (u8) rtlpriv->cfg->ops->get_desc((u8 *) entry, true,
                                                          HW_DESC_OWN);
@@ -481,6 +558,10 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int prio)
                                                      HW_DESC_TXBUFF_ADDR),
                                 skb->len, PCI_DMA_TODEVICE);
+                /* remove early mode header */
+                if (rtlpriv->rtlhal.earlymode_enable)
+                        skb_pull(skb, EM_HDR_LEN);
                RT_TRACE(rtlpriv, (COMP_INTR | COMP_SEND), DBG_TRACE,
                         ("new ring->idx:%d, "
                          "free: skb_queue_len:%d, free: seq:%x\n",
@@ -488,6 +569,30 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int prio)
                          skb_queue_len(&ring->queue),
                          *(u16 *) (skb->data + 22)));
+                if (prio == TXCMD_QUEUE) {
+                        dev_kfree_skb(skb);
+                        goto tx_status_ok;
+                }
+                /* for sw LPS, just after NULL skb send out, we can
+                 * sure AP kown we are sleeped, our we should not let
+                 * rf to sleep*/
+                fc = rtl_get_fc(skb);
+                if (ieee80211_is_nullfunc(fc)) {
+                        if (ieee80211_has_pm(fc)) {
+                                rtlpriv->mac80211.offchan_deley = true;
+                                rtlpriv->psc.state_inap = 1;
+                        } else {
+                                rtlpriv->psc.state_inap = 0;
+                        }
+                }
+                /* update tid tx pkt num */
+                tid = rtl_get_tid(skb);
+                if (tid <= 7)
+                        rtlpriv->link_info.tidtx_inperiod[tid]++;
                info = IEEE80211_SKB_CB(skb);
                ieee80211_tx_info_clear_status(info);
@@ -510,7 +615,7 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int prio)
                                        skb_get_queue_mapping
                                        (skb));
                }
+tx_status_ok:
                skb = NULL;
        }
@@ -582,23 +687,21 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
                         *skb_trim(skb, skb->len - 4);
                         */
-                        hdr = (struct ieee80211_hdr *)(skb->data);
+                        hdr = rtl_get_hdr(skb);
-                        fc = hdr->frame_control;
+                        fc = rtl_get_fc(skb);
-                        if (!stats.crc) {
+                        if (!stats.crc || !stats.hwerror) {
                                memcpy(IEEE80211_SKB_RXCB(skb), &rx_status,
                                       sizeof(rx_status));
-                                if (is_broadcast_ether_addr(hdr->addr1))
+                                if (is_broadcast_ether_addr(hdr->addr1)) {
                                        ;/*TODO*/
-                                else {
+                                } else if (is_multicast_ether_addr(hdr->addr1)) {
-                                        if (is_multicast_ether_addr(hdr->addr1))
+                                        ;/*TODO*/
-                                                ;/*TODO*/
+                                } else {
-                                        else {
+                                        unicast = true;
-                                                unicast = true;
+                                        rtlpriv->stats.rxbytesunicast +=
-                                                rtlpriv->stats.rxbytesunicast +=
+                                            skb->len;
-                                                    skb->len;
-                                        }
                                }
                                rtl_is_special_data(hw, skb, false);
@@ -612,28 +715,38 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
                                                    num_rx_inperiod++;
                                }
-                                if (unlikely(!rtl_action_proc(hw, skb,
+                                /* for sw lps */
-                                    false))) {
+                                rtl_swlps_beacon(hw, (void *)skb->data,
+                                                 skb->len);
+                                rtl_recognize_peer(hw, (void *)skb->data,
+                                                   skb->len);
+                                if ((rtlpriv->mac80211.opmode ==
+                                     NL80211_IFTYPE_AP) &&
+                                    (rtlpriv->rtlhal.current_bandtype ==
+                                     BAND_ON_2_4G) &&
+                                     (ieee80211_is_beacon(fc) ||
+                                     ieee80211_is_probe_resp(fc))) {
                                        dev_kfree_skb_any(skb);
                                } else {
-                                        struct sk_buff *uskb = NULL;
+                                        if (unlikely(!rtl_action_proc(hw, skb,
-                                        u8 *pdata;
+                                            false))) {
-                                        uskb = dev_alloc_skb(skb->len + 128);
+                                                dev_kfree_skb_any(skb);
-                                        if (!uskb) {
+                                        } else {
-                                                RT_TRACE(rtlpriv,
+                                                struct sk_buff *uskb = NULL;
-                                                        (COMP_INTR | COMP_RECV),
+                                                u8 *pdata;
-                                                        DBG_EMERG,
+                                                uskb = dev_alloc_skb(skb->len
-                                                        ("can't alloc rx skb\n"));
+                                                                     + 128);
-                                                goto done;
+                                                memcpy(IEEE80211_SKB_RXCB(uskb),
+                                                       &rx_status,
+                                                       sizeof(rx_status));
+                                                pdata = (u8 *)skb_put(uskb,
+                                                        skb->len);
+                                                memcpy(pdata, skb->data,
+                                                       skb->len);
+                                                dev_kfree_skb_any(skb);
+                                                ieee80211_rx_irqsafe(hw, uskb);
                                        }
-                                        memcpy(IEEE80211_SKB_RXCB(uskb),
-                                                        &rx_status,
-                                                        sizeof(rx_status));
-                                        pdata = (u8 *)skb_put(uskb, skb->len);
-                                        memcpy(pdata, skb->data, skb->len);
-                                        dev_kfree_skb_any(skb);
-                                        ieee80211_rx_irqsafe(hw, uskb);
                                }
                        } else {
                                dev_kfree_skb_any(skb);
@@ -648,7 +761,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
                        new_skb = dev_alloc_skb(rtlpci->rxbuffersize);
                        if (unlikely(!new_skb)) {
                                RT_TRACE(rtlpriv, (COMP_INTR | COMP_RECV),
-                                         DBG_EMERG,
+                                         DBG_DMESG,
                                         ("can't alloc skb for rx\n"));
                                goto done;
                        }
@@ -666,7 +779,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
                }
 done:
-                bufferaddress = (u32)(*((dma_addr_t *) skb->cb));
+                bufferaddress = (*((dma_addr_t *)skb->cb));
                tmp_one = 1;
                rtlpriv->cfg->ops->set_desc((u8 *) pdesc, false,
                                            HW_DESC_RXBUFF_ADDR,
@@ -695,6 +808,7 @@ static irqreturn_t _rtl_pci_interrupt(int irq, void *dev_id)
        struct ieee80211_hw *hw = dev_id;
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
        unsigned long flags;
        u32 inta = 0;
        u32 intb = 0;
@@ -781,23 +895,36 @@ static irqreturn_t _rtl_pci_interrupt(int irq, void *dev_id)
                _rtl_pci_tx_isr(hw, VO_QUEUE);
        }
+        if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE) {
+                if (inta & rtlpriv->cfg->maps[RTL_IMR_COMDOK]) {
+                        rtlpriv->link_info.num_tx_inperiod++;
+                        RT_TRACE(rtlpriv, COMP_INTR, DBG_TRACE,
+                                        ("CMD TX OK interrupt!\n"));
+                        _rtl_pci_tx_isr(hw, TXCMD_QUEUE);
+                }
+        }
        /*<2> Rx related */
        if (inta & rtlpriv->cfg->maps[RTL_IMR_ROK]) {
                RT_TRACE(rtlpriv, COMP_INTR, DBG_TRACE, ("Rx ok interrupt!\n"));
-                tasklet_schedule(&rtlpriv->works.irq_tasklet);
+                _rtl_pci_rx_interrupt(hw);
        }
        if (unlikely(inta & rtlpriv->cfg->maps[RTL_IMR_RDU])) {
                RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
                         ("rx descriptor unavailable!\n"));
-                tasklet_schedule(&rtlpriv->works.irq_tasklet);
+                _rtl_pci_rx_interrupt(hw);
        }
        if (unlikely(inta & rtlpriv->cfg->maps[RTL_IMR_RXFOVW])) {
                RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING, ("rx overflow !\n"));
-                tasklet_schedule(&rtlpriv->works.irq_tasklet);
+                _rtl_pci_rx_interrupt(hw);
        }
+        if (rtlpriv->rtlhal.earlymode_enable)
+                tasklet_schedule(&rtlpriv->works.irq_tasklet);
        spin_unlock_irqrestore(&rtlpriv->locks.irq_th_lock, flags);
        return IRQ_HANDLED;
@@ -808,7 +935,7 @@ done:
 static void _rtl_pci_irq_tasklet(struct ieee80211_hw *hw)
 {
-        _rtl_pci_rx_interrupt(hw);
+        _rtl_pci_tx_chk_waitq(hw);
 }
 static void _rtl_pci_prepare_bcn_tasklet(struct ieee80211_hw *hw)
@@ -816,14 +943,15 @@ static void _rtl_pci_prepare_bcn_tasklet(struct ieee80211_hw *hw)
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
-        struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[BEACON_QUEUE];
+        struct rtl8192_tx_ring *ring = NULL;
        struct ieee80211_hdr *hdr = NULL;
        struct ieee80211_tx_info *info = NULL;
        struct sk_buff *pskb = NULL;
        struct rtl_tx_desc *pdesc = NULL;
-        unsigned int queue_index;
+        struct rtl_tcb_desc tcb_desc;
        u8 temp_one = 1;
+        memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
        ring = &rtlpci->tx_ring[BEACON_QUEUE];
        pskb = __skb_dequeue(&ring->queue);
        if (pskb)
@@ -833,14 +961,11 @@ static void _rtl_pci_prepare_bcn_tasklet(struct ieee80211_hw *hw)
        pskb = ieee80211_beacon_get(hw, mac->vif);
        if (pskb == NULL)
                return;
-        hdr = (struct ieee80211_hdr *)(pskb->data);
+        hdr = rtl_get_hdr(pskb);
        info = IEEE80211_SKB_CB(pskb);
-        queue_index = BEACON_QUEUE;
        pdesc = &ring->desc[0];
        rtlpriv->cfg->ops->fill_tx_desc(hw, hdr, (u8 *) pdesc,
-                                        info, pskb, queue_index);
+                info, pskb, BEACON_QUEUE, &tcb_desc);
        __skb_queue_tail(&ring->queue, pskb);
@@ -882,7 +1007,6 @@ static void _rtl_pci_init_struct(struct ieee80211_hw *hw,
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
-        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
        rtlpci->up_first_time = true;
        rtlpci->being_init_adapter = false;
@@ -890,31 +1014,20 @@ static void _rtl_pci_init_struct(struct ieee80211_hw *hw,
        rtlhal->hw = hw;
        rtlpci->pdev = pdev;
-        ppsc->inactiveps = false;
-        ppsc->leisure_ps = true;
-        ppsc->fwctrl_lps = true;
-        ppsc->reg_fwctrl_lps = 3;
-        ppsc->reg_max_lps_awakeintvl = 5;
-        if (ppsc->reg_fwctrl_lps == 1)
-                ppsc->fwctrl_psmode = FW_PS_MIN_MODE;
-        else if (ppsc->reg_fwctrl_lps == 2)
-                ppsc->fwctrl_psmode = FW_PS_MAX_MODE;
-        else if (ppsc->reg_fwctrl_lps == 3)
-                ppsc->fwctrl_psmode = FW_PS_DTIM_MODE;
        /*Tx/Rx related var */
        _rtl_pci_init_trx_var(hw);
-         /*IBSS*/ mac->beacon_interval = 100;
+        /*IBSS*/ mac->beacon_interval = 100;
-         /*AMPDU*/ mac->min_space_cfg = 0;
+        /*AMPDU*/
+        mac->min_space_cfg = 0;
        mac->max_mss_density = 0;
        /*set sane AMPDU defaults */
        mac->current_ampdu_density = 7;
        mac->current_ampdu_factor = 3;
-         /*QOS*/ rtlpci->acm_method = eAcmWay2_SW;
+        /*QOS*/
+        rtlpci->acm_method = eAcmWay2_SW;
        /*task */
        tasklet_init(&rtlpriv->works.irq_tasklet,
@@ -955,7 +1068,8 @@ static int _rtl_pci_init_tx_ring(struct ieee80211_hw *hw,
                 ("queue:%d, ring_addr:%p\n", prio, ring));
        for (i = 0; i < entries; i++) {
-                nextdescaddress = (u32) dma + ((i + 1) % entries) *
+                nextdescaddress = (u32) dma +
+                                              ((i + 1) % entries) *
                                              sizeof(*ring);
                rtlpriv->cfg->ops->set_desc((u8 *)&(ring[i]),
@@ -1020,7 +1134,7 @@ static int _rtl_pci_init_rx_ring(struct ieee80211_hw *hw)
                                           rtlpci->rxbuffersize,
                                           PCI_DMA_FROMDEVICE);
-                        bufferaddress = (u32)(*((dma_addr_t *)skb->cb));
+                        bufferaddress = (*((dma_addr_t *)skb->cb));
                        rtlpriv->cfg->ops->set_desc((u8 *)entry, false,
                                                    HW_DESC_RXBUFF_ADDR,
                                                    (u8 *)&bufferaddress);
@@ -1203,72 +1317,73 @@ int rtl_pci_reset_trx_ring(struct ieee80211_hw *hw)
        return 0;
 }
-static unsigned int _rtl_mac_to_hwqueue(__le16 fc,
+static bool rtl_pci_tx_chk_waitq_insert(struct ieee80211_hw *hw,
-                unsigned int mac80211_queue_index)
+                                        struct sk_buff *skb)
 {
-        unsigned int hw_queue_index;
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
-        if (unlikely(ieee80211_is_beacon(fc))) {
+        struct ieee80211_sta *sta = info->control.sta;
-                hw_queue_index = BEACON_QUEUE;
+        struct rtl_sta_info *sta_entry = NULL;
-                goto out;
+        u8 tid = rtl_get_tid(skb);
-        }
+        if (!sta)
-        if (ieee80211_is_mgmt(fc)) {
+                return false;
-                hw_queue_index = MGNT_QUEUE;
+        sta_entry = (struct rtl_sta_info *)sta->drv_priv;
-                goto out;
-        }
+        if (!rtlpriv->rtlhal.earlymode_enable)
+                return false;
-        switch (mac80211_queue_index) {
+        if (sta_entry->tids[tid].agg.agg_state != RTL_AGG_OPERATIONAL)
-        case 0:
+                return false;
-                hw_queue_index = VO_QUEUE;
+        if (_rtl_mac_to_hwqueue(hw, skb) > VO_QUEUE)
-                break;
+                return false;
-        case 1:
+        if (tid > 7)
-                hw_queue_index = VI_QUEUE;
+                return false;
-                break;
-        case 2:
+        /* maybe every tid should be checked */
-                hw_queue_index = BE_QUEUE;;
+        if (!rtlpriv->link_info.higher_busytxtraffic[tid])
-                break;
+                return false;
-        case 3:
-                hw_queue_index = BK_QUEUE;
+        spin_lock_bh(&rtlpriv->locks.waitq_lock);
-                break;
+        skb_queue_tail(&rtlpriv->mac80211.skb_waitq[tid], skb);
-        default:
+        spin_unlock_bh(&rtlpriv->locks.waitq_lock);
-                hw_queue_index = BE_QUEUE;
-                RT_ASSERT(false, ("QSLT_BE queue, skb_queue:%d\n",
-                                  mac80211_queue_index));
-                break;
-        }
-out:
+        return true;
-        return hw_queue_index;
 }
-static int rtl_pci_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
+static int rtl_pci_tx(struct ieee80211_hw *hw, struct sk_buff *skb,
+                struct rtl_tcb_desc *ptcb_desc)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_sta_info *sta_entry = NULL;
        struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
+        struct ieee80211_sta *sta = info->control.sta;
        struct rtl8192_tx_ring *ring;
        struct rtl_tx_desc *pdesc;
        u8 idx;
-        unsigned int queue_index, hw_queue;
+        u8 hw_queue = _rtl_mac_to_hwqueue(hw, skb);
        unsigned long flags;
-        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data);
+        struct ieee80211_hdr *hdr = rtl_get_hdr(skb);
-        __le16 fc = hdr->frame_control;
+        __le16 fc = rtl_get_fc(skb);
        u8 *pda_addr = hdr->addr1;
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
        /*ssn */
-        u8 *qc = NULL;
        u8 tid = 0;
        u16 seq_number = 0;
        u8 own;
        u8 temp_one = 1;
-        if (ieee80211_is_mgmt(fc))
+        if (ieee80211_is_auth(fc)) {
-                rtl_tx_mgmt_proc(hw, skb);
+                RT_TRACE(rtlpriv, COMP_SEND, DBG_DMESG, ("MAC80211_LINKING\n"));
-        rtl_action_proc(hw, skb, true);
+                rtl_ips_nic_on(hw);
+        }
+        if (rtlpriv->psc.sw_ps_enabled) {
+                if (ieee80211_is_data(fc) && !ieee80211_is_nullfunc(fc) &&
+                        !ieee80211_has_pm(fc))
+                        hdr->frame_control |= cpu_to_le16(IEEE80211_FCTL_PM);
+        }
-        queue_index = skb_get_queue_mapping(skb);
+        rtl_action_proc(hw, skb, true);
-        hw_queue = _rtl_mac_to_hwqueue(fc, queue_index);
        if (is_multicast_ether_addr(pda_addr))
                rtlpriv->stats.txbytesmulticast += skb->len;
@@ -1278,7 +1393,6 @@ static int rtl_pci_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
                rtlpriv->stats.txbytesunicast += skb->len;
        spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
        ring = &rtlpci->tx_ring[hw_queue];
        if (hw_queue != BEACON_QUEUE)
                idx = (ring->idx + skb_queue_len(&ring->queue)) %
@@ -1301,43 +1415,30 @@ static int rtl_pci_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
                return skb->len;
        }
-        /*
-         *if(ieee80211_is_nullfunc(fc)) {
-         *      spin_unlock_irqrestore(&rtlpriv->locks.irq_th_lock, flags);
-         *      return 1;
-         *}
-         */
        if (ieee80211_is_data_qos(fc)) {
-                qc = ieee80211_get_qos_ctl(hdr);
+                tid = rtl_get_tid(skb);
-                tid = qc[0] & IEEE80211_QOS_CTL_TID_MASK;
+                if (sta) {
+                        sta_entry = (struct rtl_sta_info *)sta->drv_priv;
-                seq_number = mac->tids[tid].seq_number;
+                        seq_number = (le16_to_cpu(hdr->seq_ctrl) &
-                seq_number &= IEEE80211_SCTL_SEQ;
+                                      IEEE80211_SCTL_SEQ) >> 4;
-                /*
+                        seq_number += 1;
-                 *hdr->seq_ctrl = hdr->seq_ctrl &
-                 *cpu_to_le16(IEEE80211_SCTL_FRAG);
+                        if (!ieee80211_has_morefrags(hdr->frame_control))
-                 *hdr->seq_ctrl |= cpu_to_le16(seq_number);
+                                sta_entry->tids[tid].seq_number = seq_number;
-                 */
+                }
-                seq_number += 1;
        }
        if (ieee80211_is_data(fc))
                rtlpriv->cfg->ops->led_control(hw, LED_CTL_TX);
-        rtlpriv->cfg->ops->fill_tx_desc(hw, hdr, (u8 *) pdesc,
+        rtlpriv->cfg->ops->fill_tx_desc(hw, hdr, (u8 *)pdesc,
-                                        info, skb, hw_queue);
+                        info, skb, hw_queue, ptcb_desc);
        __skb_queue_tail(&ring->queue, skb);
-        rtlpriv->cfg->ops->set_desc((u8 *) pdesc, true,
+        rtlpriv->cfg->ops->set_desc((u8 *)pdesc, true,
                                    HW_DESC_OWN, (u8 *)&temp_one);
-        if (!ieee80211_has_morefrags(hdr->frame_control)) {
-                if (qc)
-                        mac->tids[tid].seq_number = seq_number;
-        }
        if ((ring->entries - skb_queue_len(&ring->queue)) < 2 &&
            hw_queue != BEACON_QUEUE) {
@@ -1359,6 +1460,35 @@ static int rtl_pci_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
        return 0;
 }
+static void rtl_pci_flush(struct ieee80211_hw *hw, bool drop)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        u16 i = 0;
+        int queue_id;
+        struct rtl8192_tx_ring *ring;
+        for (queue_id = RTL_PCI_MAX_TX_QUEUE_COUNT - 1; queue_id >= 0;) {
+                u32 queue_len;
+                ring = &pcipriv->dev.tx_ring[queue_id];
+                queue_len = skb_queue_len(&ring->queue);
+                if (queue_len == 0 || queue_id == BEACON_QUEUE ||
+                        queue_id == TXCMD_QUEUE) {
+                        queue_id--;
+                        continue;
+                } else {
+                        msleep(20);
+                        i++;
+                }
+                /* we just wait 1s for all queues */
+                if (rtlpriv->psc.rfpwr_state == ERFOFF ||
+                        is_hal_stop(rtlhal) || i >= 200)
+                        return;
+        }
+}
 static void rtl_pci_deinit(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
@@ -1477,11 +1607,14 @@ static bool _rtl_pci_find_adapter(struct pci_dev *pdev,
        struct pci_dev *bridge_pdev = pdev->bus->self;
        u16 venderid;
        u16 deviceid;
+        u8 revisionid;
        u16 irqline;
        u8 tmp;
+        pcipriv->ndis_adapter.pcibridge_vendor = PCI_BRIDGE_VENDOR_UNKNOWN;
        venderid = pdev->vendor;
        deviceid = pdev->device;
+        pci_read_config_byte(pdev, 0x8, &revisionid);
        pci_read_config_word(pdev, 0x3C, &irqline);
        if (deviceid == RTL_PCI_8192_DID ||
@@ -1492,7 +1625,7 @@ static bool _rtl_pci_find_adapter(struct pci_dev *pdev,
            deviceid == RTL_PCI_8173_DID ||
            deviceid == RTL_PCI_8172_DID ||
            deviceid == RTL_PCI_8171_DID) {
-                switch (pdev->revision) {
+                switch (revisionid) {
                case RTL_PCI_REVISION_ID_8192PCIE:
                        RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
                                 ("8192 PCI-E is found - "
@@ -1521,6 +1654,12 @@ static bool _rtl_pci_find_adapter(struct pci_dev *pdev,
                RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
                         ("8192C PCI-E is found - "
                          "vid/did=%x/%x\n", venderid, deviceid));
+        } else if (deviceid == RTL_PCI_8192DE_DID ||
+                   deviceid == RTL_PCI_8192DE_DID2) {
+                rtlhal->hw_type = HARDWARE_TYPE_RTL8192DE;
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
+                         ("8192D PCI-E is found - "
+                          "vid/did=%x/%x\n", venderid, deviceid));
        } else {
                RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
                         ("Err: Unknown device -"
@@ -1529,6 +1668,25 @@ static bool _rtl_pci_find_adapter(struct pci_dev *pdev,
                rtlhal->hw_type = RTL_DEFAULT_HARDWARE_TYPE;
        }
+        if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192DE) {
+                if (revisionid == 0 || revisionid == 1) {
+                        if (revisionid == 0) {
+                                RT_TRACE(rtlpriv, COMP_INIT,
+                                         DBG_LOUD, ("Find 92DE MAC0.\n"));
+                                rtlhal->interfaceindex = 0;
+                        } else if (revisionid == 1) {
+                                RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                                        ("Find 92DE MAC1.\n"));
+                                rtlhal->interfaceindex = 1;
+                        }
+                } else {
+                        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                                ("Unknown device - "
+                                "VendorID/DeviceID=%x/%x, Revision=%x\n",
+                                venderid, deviceid, revisionid));
+                        rtlhal->interfaceindex = 0;
+                }
+        }
        /*find bus info */
        pcipriv->ndis_adapter.busnumber = pdev->bus->number;
        pcipriv->ndis_adapter.devnumber = PCI_SLOT(pdev->devfn);
@@ -1554,12 +1712,12 @@ static bool _rtl_pci_find_adapter(struct pci_dev *pdev,
                    PCI_SLOT(bridge_pdev->devfn);
                pcipriv->ndis_adapter.pcibridge_funcnum =
                    PCI_FUNC(bridge_pdev->devfn);
-                pcipriv->ndis_adapter.pcibridge_pciehdr_offset =
-                    pci_pcie_cap(bridge_pdev);
                pcipriv->ndis_adapter.pcicfg_addrport =
                    (pcipriv->ndis_adapter.pcibridge_busnum << 16) |
                    (pcipriv->ndis_adapter.pcibridge_devnum << 11) |
                    (pcipriv->ndis_adapter.pcibridge_funcnum << 8) | (1 << 31);
+                pcipriv->ndis_adapter.pcibridge_pciehdr_offset =
+                    pci_pcie_cap(bridge_pdev);
                pcipriv->ndis_adapter.num4bytes =
                    (pcipriv->ndis_adapter.pcibridge_pciehdr_offset + 0x10) / 4;
@@ -1642,6 +1800,11 @@ int __devinit rtl_pci_probe(struct pci_dev *pdev,
        pcipriv = (void *)rtlpriv->priv;
        pcipriv->dev.pdev = pdev;
+        /* init cfg & intf_ops */
+        rtlpriv->rtlhal.interface = INTF_PCI;
+        rtlpriv->cfg = (struct rtl_hal_cfg *)(id->driver_data);
+        rtlpriv->intf_ops = &rtl_pci_ops;
        /*
         *init dbgp flags before all
         *other functions, because we will
@@ -1659,13 +1822,14 @@ int __devinit rtl_pci_probe(struct pci_dev *pdev,
                return err;
        }
-        pmem_start = pci_resource_start(pdev, 2);
+        pmem_start = pci_resource_start(pdev, rtlpriv->cfg->bar_id);
-        pmem_len = pci_resource_len(pdev, 2);
+        pmem_len = pci_resource_len(pdev, rtlpriv->cfg->bar_id);
-        pmem_flags = pci_resource_flags(pdev, 2);
+        pmem_flags = pci_resource_flags(pdev, rtlpriv->cfg->bar_id);
        /*shared mem start */
        rtlpriv->io.pci_mem_start =
-                        (unsigned long)pci_iomap(pdev, 2, pmem_len);
+                        (unsigned long)pci_iomap(pdev,
+                        rtlpriv->cfg->bar_id, pmem_len);
        if (rtlpriv->io.pci_mem_start == 0) {
                RT_ASSERT(false, ("Can't map PCI mem\n"));
                goto fail2;
@@ -1684,11 +1848,6 @@ int __devinit rtl_pci_probe(struct pci_dev *pdev,
        pci_write_config_byte(pdev, 0x04, 0x06);
        pci_write_config_byte(pdev, 0x04, 0x07);
-        /* init cfg & intf_ops */
-        rtlpriv->rtlhal.interface = INTF_PCI;
-        rtlpriv->cfg = (struct rtl_hal_cfg *)(id->driver_data);
-        rtlpriv->intf_ops = &rtl_pci_ops;
        /* find adapter */
        _rtl_pci_find_adapter(pdev, hw);
@@ -1806,7 +1965,6 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
        rtl_pci_deinit(hw);
        rtl_deinit_core(hw);
-        rtlpriv->cfg->ops->deinit_sw_leds(hw);
        _rtl_pci_io_handler_release(hw);
        rtlpriv->cfg->ops->deinit_sw_vars(hw);
@@ -1821,6 +1979,9 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
        }
        pci_disable_device(pdev);
+        rtl_pci_disable_aspm(hw);
        pci_set_drvdata(pdev, NULL);
        ieee80211_free_hw(hw);
@@ -1844,10 +2005,15 @@ no need to call hw_disable here.
 ****************************************/
 int rtl_pci_suspend(struct pci_dev *pdev, pm_message_t state)
 {
+        struct ieee80211_hw *hw = pci_get_drvdata(pdev);
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        rtlpriv->cfg->ops->hw_suspend(hw);
+        rtl_deinit_rfkill(hw);
        pci_save_state(pdev);
        pci_disable_device(pdev);
        pci_set_power_state(pdev, PCI_D3hot);
        return 0;
 }
 EXPORT_SYMBOL(rtl_pci_suspend);
@@ -1855,6 +2021,8 @@ EXPORT_SYMBOL(rtl_pci_suspend);
 int rtl_pci_resume(struct pci_dev *pdev)
 {
        int ret;
+        struct ieee80211_hw *hw = pci_get_drvdata(pdev);
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
        pci_set_power_state(pdev, PCI_D0);
        ret = pci_enable_device(pdev);
@@ -1865,15 +2033,20 @@ int rtl_pci_resume(struct pci_dev *pdev)
        pci_restore_state(pdev);
+        rtlpriv->cfg->ops->hw_resume(hw);
+        rtl_init_rfkill(hw);
        return 0;
 }
 EXPORT_SYMBOL(rtl_pci_resume);
 struct rtl_intf_ops rtl_pci_ops = {
+        .read_efuse_byte = read_efuse_byte,
        .adapter_start = rtl_pci_start,
        .adapter_stop = rtl_pci_stop,
        .adapter_tx = rtl_pci_tx,
+        .flush = rtl_pci_flush,
        .reset_trx_ring = rtl_pci_reset_trx_ring,
+        .waitq_insert = rtl_pci_tx_chk_waitq_insert,
        .disable_aspm = rtl_pci_disable_aspm,
        .enable_aspm = rtl_pci_enable_aspm,
diff --git a/drivers/net/wireless/rtlwifi/pci.h b/drivers/net/wireless/rtlwifi/pci.h
index 0caa81429726..671b1f5aa0cf 100644
--- a/drivers/net/wireless/rtlwifi/pci.h
+++ b/drivers/net/wireless/rtlwifi/pci.h
@@ -102,8 +102,8 @@
 #define RTL_PCI_8191CE_DID      0x8177  /*8192ce */
 #define RTL_PCI_8188CE_DID      0x8176  /*8192ce */
 #define RTL_PCI_8192CU_DID      0x8191  /*8192ce */
-#define RTL_PCI_8192DE_DID      0x092D  /*8192ce */
+#define RTL_PCI_8192DE_DID      0x8193  /*8192de */
-#define RTL_PCI_8192DU_DID      0x092D  /*8192ce */
+#define RTL_PCI_8192DE_DID2     0x002B  /*92DE*/
 /*8192 support 16 pages of IO registers*/
 #define RTL_MEM_MAPPED_IO_RANGE_8190PCI         0x1000
@@ -129,6 +129,11 @@ enum pci_bridge_vendor {
        PCI_BRIDGE_VENDOR_MAX,
 };
+struct rtl_pci_capabilities_header {
+        u8 capability_id;
+        u8 next;
+};
 struct rtl_rx_desc {
        u32 dword[8];
 } __packed;
@@ -161,7 +166,9 @@ struct rtl_pci {
        bool driver_is_goingto_unload;
        bool up_first_time;
+        bool first_init;
        bool being_init_adapter;
+        bool init_ready;
        bool irq_enabled;
        /*Tx */
@@ -192,11 +199,14 @@ struct rtl_pci {
        u8 const_devicepci_aspm_setting;
        /*If it supports ASPM, Offset[560h] = 0x40,
           otherwise Offset[560h] = 0x00. */
-        bool b_support_aspm;
+        bool support_aspm;
-        bool b_support_backdoor;
+        bool support_backdoor;
        /*QOS & EDCA */
        enum acm_method acm_method;
+        u16 shortretry_limit;
+        u16 longretry_limit;
 };
 struct mp_adapter {
@@ -227,6 +237,7 @@ struct rtl_pci_priv {
        struct rtl_pci dev;
        struct mp_adapter ndis_adapter;
        struct rtl_led_ctl ledctl;
+        struct bt_coexist_info bt_coexist;
 };
 #define rtl_pcipriv(hw)         (((struct rtl_pci_priv *)(rtl_priv(hw))->priv))
diff --git a/drivers/net/wireless/rtlwifi/ps.c b/drivers/net/wireless/rtlwifi/ps.c
index 6b7e217b6b89..2bb71195e976 100644
--- a/drivers/net/wireless/rtlwifi/ps.c
+++ b/drivers/net/wireless/rtlwifi/ps.c
@@ -36,7 +36,6 @@ bool rtl_ps_enable_nic(struct ieee80211_hw *hw)
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
-        bool init_status = true;
        /*<1> reset trx ring */
        if (rtlhal->interface == INTF_PCI)
@@ -49,7 +48,6 @@ bool rtl_ps_enable_nic(struct ieee80211_hw *hw)
        /*<2> Enable Adapter */
        rtlpriv->cfg->ops->hw_init(hw);
        RT_CLEAR_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_HALT_NIC);
-        /*init_status = false; */
        /*<3> Enable Interrupt */
        rtlpriv->cfg->ops->enable_interrupt(hw);
@@ -57,13 +55,12 @@ bool rtl_ps_enable_nic(struct ieee80211_hw *hw)
        /*<enable timer> */
        rtl_watch_dog_timer_callback((unsigned long)hw);
-        return init_status;
+        return true;
 }
 EXPORT_SYMBOL(rtl_ps_enable_nic);
 bool rtl_ps_disable_nic(struct ieee80211_hw *hw)
 {
-        bool status = true;
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        /*<1> Stop all timer */
@@ -75,7 +72,7 @@ bool rtl_ps_disable_nic(struct ieee80211_hw *hw)
        /*<3> Disable Adapter */
        rtlpriv->cfg->ops->hw_disable(hw);
-        return status;
+        return true;
 }
 EXPORT_SYMBOL(rtl_ps_disable_nic);
@@ -193,12 +190,13 @@ static void _rtl_ps_inactive_ps(struct ieee80211_hw *hw)
        ppsc->swrf_processing = true;
-        if (ppsc->inactive_pwrstate == ERFON && rtlhal->interface == INTF_PCI) {
+        if (ppsc->inactive_pwrstate == ERFOFF &&
+            rtlhal->interface == INTF_PCI) {
                if ((ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM) &&
-                    RT_IN_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_ASPM) &&
+                    RT_IN_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM) &&
                    rtlhal->interface == INTF_PCI) {
                        rtlpriv->intf_ops->disable_aspm(hw);
-                        RT_CLEAR_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_ASPM);
+                        RT_CLEAR_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM);
                }
        }
@@ -207,9 +205,10 @@ static void _rtl_ps_inactive_ps(struct ieee80211_hw *hw)
        if (ppsc->inactive_pwrstate == ERFOFF &&
            rtlhal->interface == INTF_PCI) {
-                if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM) {
+                if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM &&
+                        !RT_IN_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM)) {
                        rtlpriv->intf_ops->enable_aspm(hw);
-                        RT_SET_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_ASPM);
+                        RT_SET_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM);
                }
        }
@@ -233,6 +232,9 @@ void rtl_ips_nic_off_wq_callback(void *data)
                return;
        }
+        if (mac->link_state > MAC80211_NOLINK)
+                return;
        if (is_hal_stop(rtlhal))
                return;
@@ -284,10 +286,14 @@ void rtl_ips_nic_off(struct ieee80211_hw *hw)
 void rtl_ips_nic_on(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
        enum rf_pwrstate rtstate;
        unsigned long flags;
+        if (mac->opmode != NL80211_IFTYPE_STATION)
+                return;
        spin_lock_irqsave(&rtlpriv->locks.ips_lock, flags);
        if (ppsc->inactiveps) {
@@ -370,8 +376,7 @@ static void rtl_lps_set_psmode(struct ieee80211_hw *hw, u8 rt_psmode)
         *   mode and set RPWM to turn RF on.
         */
-        if ((ppsc->fwctrl_lps) && (ppsc->leisure_ps) &&
+        if ((ppsc->fwctrl_lps) && ppsc->report_linked) {
-             ppsc->report_linked) {
                bool fw_current_inps;
                if (ppsc->dot11_psmode == EACTIVE) {
                        RT_TRACE(rtlpriv, COMP_RF, DBG_DMESG,
@@ -425,7 +430,7 @@ void rtl_lps_enter(struct ieee80211_hw *hw)
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        unsigned long flag;
-        if (!(ppsc->fwctrl_lps && ppsc->leisure_ps))
+        if (!ppsc->fwctrl_lps)
                return;
        if (rtlpriv->sec.being_setkey)
@@ -446,17 +451,16 @@ void rtl_lps_enter(struct ieee80211_hw *hw)
        spin_lock_irqsave(&rtlpriv->locks.lps_lock, flag);
-        if (ppsc->leisure_ps) {
+        /* Idle for a while if we connect to AP a while ago. */
-                /* Idle for a while if we connect to AP a while ago. */
+        if (mac->cnt_after_linked >= 2) {
-                if (mac->cnt_after_linked >= 2) {
+                if (ppsc->dot11_psmode == EACTIVE) {
-                        if (ppsc->dot11_psmode == EACTIVE) {
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
-                                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
                                        ("Enter 802.11 power save mode...\n"));
-                                rtl_lps_set_psmode(hw, EAUTOPS);
+                        rtl_lps_set_psmode(hw, EAUTOPS);
-                        }
                }
        }
        spin_unlock_irqrestore(&rtlpriv->locks.lps_lock, flag);
 }
@@ -470,17 +474,17 @@ void rtl_lps_leave(struct ieee80211_hw *hw)
        spin_lock_irqsave(&rtlpriv->locks.lps_lock, flag);
-        if (ppsc->fwctrl_lps && ppsc->leisure_ps) {
+        if (ppsc->fwctrl_lps) {
                if (ppsc->dot11_psmode != EACTIVE) {
                        /*FIX ME */
                        rtlpriv->cfg->ops->enable_interrupt(hw);
                        if (ppsc->reg_rfps_level & RT_RF_LPS_LEVEL_ASPM &&
-                            RT_IN_PS_LEVEL(ppsc, RT_RF_LPS_LEVEL_ASPM) &&
+                            RT_IN_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM) &&
                            rtlhal->interface == INTF_PCI) {
                                rtlpriv->intf_ops->disable_aspm(hw);
-                                RT_CLEAR_PS_LEVEL(ppsc, RT_RF_LPS_LEVEL_ASPM);
+                                RT_CLEAR_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM);
                        }
                        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
@@ -491,3 +495,214 @@ void rtl_lps_leave(struct ieee80211_hw *hw)
        }
        spin_unlock_irqrestore(&rtlpriv->locks.lps_lock, flag);
 }
+/* For sw LPS*/
+void rtl_swlps_beacon(struct ieee80211_hw *hw, void *data, unsigned int len)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct ieee80211_hdr *hdr = (void *) data;
+        struct ieee80211_tim_ie *tim_ie;
+        u8 *tim;
+        u8 tim_len;
+        bool u_buffed;
+        bool m_buffed;
+        if (mac->opmode != NL80211_IFTYPE_STATION)
+                return;
+        if (!rtlpriv->psc.swctrl_lps)
+                return;
+        if (rtlpriv->mac80211.link_state != MAC80211_LINKED)
+                return;
+        if (!rtlpriv->psc.sw_ps_enabled)
+                return;
+        if (rtlpriv->psc.fwctrl_lps)
+                return;
+        if (likely(!(hw->conf.flags & IEEE80211_CONF_PS)))
+                return;
+        /* check if this really is a beacon */
+        if (!ieee80211_is_beacon(hdr->frame_control))
+                return;
+        /* min. beacon length + FCS_LEN */
+        if (len <= 40 + FCS_LEN)
+                return;
+        /* and only beacons from the associated BSSID, please */
+        if (compare_ether_addr(hdr->addr3, rtlpriv->mac80211.bssid))
+                return;
+        rtlpriv->psc.last_beacon = jiffies;
+        tim = rtl_find_ie(data, len - FCS_LEN, WLAN_EID_TIM);
+        if (!tim)
+                return;
+        if (tim[1] < sizeof(*tim_ie))
+                return;
+        tim_len = tim[1];
+        tim_ie = (struct ieee80211_tim_ie *) &tim[2];
+        if (!WARN_ON_ONCE(!hw->conf.ps_dtim_period))
+                rtlpriv->psc.dtim_counter = tim_ie->dtim_count;
+        /* Check whenever the PHY can be turned off again. */
+        /* 1. What about buffered unicast traffic for our AID? */
+        u_buffed = ieee80211_check_tim(tim_ie, tim_len,
+                                       rtlpriv->mac80211.assoc_id);
+        /* 2. Maybe the AP wants to send multicast/broadcast data? */
+        m_buffed = tim_ie->bitmap_ctrl & 0x01;
+        rtlpriv->psc.multi_buffered = m_buffed;
+        /* unicast will process by mac80211 through
+         * set ~IEEE80211_CONF_PS, So we just check
+         * multicast frames here */
+        if (!m_buffed) {
+                /* back to low-power land. and delay is
+                 * prevent null power save frame tx fail */
+                queue_delayed_work(rtlpriv->works.rtl_wq,
+                                &rtlpriv->works.ps_work, MSECS(5));
+        } else {
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_DMESG, ("u_bufferd: %x, "
+                                "m_buffered: %x\n", u_buffed, m_buffed));
+        }
+}
+void rtl_swlps_rf_awake(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        unsigned long flag;
+        if (!rtlpriv->psc.swctrl_lps)
+                return;
+        if (mac->link_state != MAC80211_LINKED)
+                return;
+        if (ppsc->reg_rfps_level & RT_RF_LPS_LEVEL_ASPM &&
+                RT_IN_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM)) {
+                rtlpriv->intf_ops->disable_aspm(hw);
+                RT_CLEAR_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM);
+        }
+        spin_lock_irqsave(&rtlpriv->locks.lps_lock, flag);
+        rtl_ps_set_rf_state(hw, ERFON, RF_CHANGE_BY_PS, false);
+        spin_unlock_irqrestore(&rtlpriv->locks.lps_lock, flag);
+}
+void rtl_swlps_rfon_wq_callback(void *data)
+{
+        struct rtl_works *rtlworks =
+            container_of_dwork_rtl(data, struct rtl_works, ps_rfon_wq);
+        struct ieee80211_hw *hw = rtlworks->hw;
+        rtl_swlps_rf_awake(hw);
+}
+void rtl_swlps_rf_sleep(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        unsigned long flag;
+        u8 sleep_intv;
+        if (!rtlpriv->psc.sw_ps_enabled)
+                return;
+        if ((rtlpriv->sec.being_setkey) ||
+            (mac->opmode == NL80211_IFTYPE_ADHOC))
+                return;
+        /*sleep after linked 10s, to let DHCP and 4-way handshake ok enough!! */
+        if ((mac->link_state != MAC80211_LINKED) || (mac->cnt_after_linked < 5))
+                return;
+        if (rtlpriv->link_info.busytraffic)
+                return;
+        spin_lock_irqsave(&rtlpriv->locks.rf_ps_lock, flag);
+        if (rtlpriv->psc.rfchange_inprogress) {
+                spin_unlock_irqrestore(&rtlpriv->locks.rf_ps_lock, flag);
+                return;
+        }
+        spin_unlock_irqrestore(&rtlpriv->locks.rf_ps_lock, flag);
+        spin_lock_irqsave(&rtlpriv->locks.lps_lock, flag);
+        rtl_ps_set_rf_state(hw, ERFSLEEP, RF_CHANGE_BY_PS, false);
+        spin_unlock_irqrestore(&rtlpriv->locks.lps_lock, flag);
+        if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM &&
+                !RT_IN_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM)) {
+                rtlpriv->intf_ops->enable_aspm(hw);
+                RT_SET_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM);
+        }
+        /* here is power save alg, when this beacon is DTIM
+         * we will set sleep time to dtim_period * n;
+         * when this beacon is not DTIM, we will set sleep
+         * time to sleep_intv = rtlpriv->psc.dtim_counter or
+         * MAX_SW_LPS_SLEEP_INTV(default set to 5) */
+        if (rtlpriv->psc.dtim_counter == 0) {
+                if (hw->conf.ps_dtim_period == 1)
+                        sleep_intv = hw->conf.ps_dtim_period * 2;
+                else
+                        sleep_intv = hw->conf.ps_dtim_period;
+        } else {
+                sleep_intv = rtlpriv->psc.dtim_counter;
+        }
+        if (sleep_intv > MAX_SW_LPS_SLEEP_INTV)
+                sleep_intv = MAX_SW_LPS_SLEEP_INTV;
+        /* this print should always be dtim_conter = 0 &
+         * sleep  = dtim_period, that meaons, we should
+         * awake before every dtim */
+        RT_TRACE(rtlpriv, COMP_POWER, DBG_DMESG,
+                 ("dtim_counter:%x will sleep :%d"
+                 " beacon_intv\n", rtlpriv->psc.dtim_counter, sleep_intv));
+        /* we tested that 40ms is enough for sw & hw sw delay */
+        queue_delayed_work(rtlpriv->works.rtl_wq, &rtlpriv->works.ps_rfon_wq,
+                        MSECS(sleep_intv * mac->vif->bss_conf.beacon_int - 40));
+}
+void rtl_swlps_wq_callback(void *data)
+{
+        struct rtl_works *rtlworks = container_of_dwork_rtl(data,
+                                     struct rtl_works,
+                                     ps_work);
+        struct ieee80211_hw *hw = rtlworks->hw;
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        bool ps = false;
+        ps = (hw->conf.flags & IEEE80211_CONF_PS);
+        /* we can sleep after ps null send ok */
+        if (rtlpriv->psc.state_inap) {
+                rtl_swlps_rf_sleep(hw);
+                if (rtlpriv->psc.state && !ps) {
+                        rtlpriv->psc.sleep_ms = jiffies_to_msecs(jiffies -
+                                        rtlpriv->psc.last_action);
+                }
+                if (ps)
+                        rtlpriv->psc.last_slept = jiffies;
+                rtlpriv->psc.last_action = jiffies;
+                rtlpriv->psc.state = ps;
+        }
+}
diff --git a/drivers/net/wireless/rtlwifi/ps.h b/drivers/net/wireless/rtlwifi/ps.h
index ae56da801a23..e3bf89840370 100644
--- a/drivers/net/wireless/rtlwifi/ps.h
+++ b/drivers/net/wireless/rtlwifi/ps.h
@@ -30,6 +30,8 @@
 #ifndef __REALTEK_RTL_PCI_PS_H__
 #define __REALTEK_RTL_PCI_PS_H__
+#define MAX_SW_LPS_SLEEP_INTV   5
 bool rtl_ps_set_rf_state(struct ieee80211_hw *hw,
                         enum rf_pwrstate state_toset, u32 changesource,
                         bool protect_or_not);
@@ -40,4 +42,11 @@ void rtl_ips_nic_on(struct ieee80211_hw *hw);
 void rtl_ips_nic_off_wq_callback(void *data);
 void rtl_lps_enter(struct ieee80211_hw *hw);
 void rtl_lps_leave(struct ieee80211_hw *hw);
+void rtl_swlps_beacon(struct ieee80211_hw *hw, void *data, unsigned int len);
+void rtl_swlps_wq_callback(void *data);
+void rtl_swlps_rfon_wq_callback(void *data);
+void rtl_swlps_rf_awake(struct ieee80211_hw *hw);
+void rtl_swlps_rf_sleep(struct ieee80211_hw *hw);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rc.c b/drivers/net/wireless/rtlwifi/rc.c
index 91634107434a..30da68a77786 100644
--- a/drivers/net/wireless/rtlwifi/rc.c
+++ b/drivers/net/wireless/rtlwifi/rc.c
@@ -38,17 +38,14 @@
 *CCK11M or OFDM_54M based on wireless mode.
 */
 static u8 _rtl_rc_get_highest_rix(struct rtl_priv *rtlpriv,
+                                  struct ieee80211_sta *sta,
                                  struct sk_buff *skb, bool not_data)
 {
        struct rtl_mac *rtlmac = rtl_mac(rtlpriv);
+        struct rtl_hal *rtlhal = rtl_hal(rtlpriv);
-        /*
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
-         *mgt use 1M, although we have check it
+        struct rtl_sta_info *sta_entry = NULL;
-         *before this function use rate_control_send_low,
+        u8 wireless_mode = 0;
-         *we still check it here
-         */
-        if (not_data)
-                return rtlpriv->cfg->maps[RTL_RC_CCK_RATE1M];
        /*
         *this rate is no use for true rate, firmware
@@ -57,35 +54,78 @@ static u8 _rtl_rc_get_highest_rix(struct rtl_priv *rtlpriv,
         *2.in rtl_get_tcb_desc when we check rate is
         *      1M we will not use FW rate but user rate.
         */
-        if (rtl_is_special_data(rtlpriv->mac80211.hw, skb, true)) {
+        if (rtlmac->opmode == NL80211_IFTYPE_AP ||
-                return rtlpriv->cfg->maps[RTL_RC_CCK_RATE1M];
+                rtlmac->opmode == NL80211_IFTYPE_ADHOC) {
+                if (sta) {
+                        sta_entry = (struct rtl_sta_info *) sta->drv_priv;
+                        wireless_mode = sta_entry->wireless_mode;
+                } else {
+                        return 0;
+                }
+        } else {
+                wireless_mode = rtlmac->mode;
+        }
+        if (rtl_is_special_data(rtlpriv->mac80211.hw, skb, true) ||
+                        not_data) {
+                return 0;
        } else {
-                if (rtlmac->mode == WIRELESS_MODE_B)
+                if (rtlhal->current_bandtype == BAND_ON_2_4G) {
-                        return rtlpriv->cfg->maps[RTL_RC_CCK_RATE11M];
+                        if (wireless_mode == WIRELESS_MODE_B) {
-                else
+                                return B_MODE_MAX_RIX;
-                        return rtlpriv->cfg->maps[RTL_RC_OFDM_RATE54M];
+                        } else if (wireless_mode == WIRELESS_MODE_G) {
+                                return G_MODE_MAX_RIX;
+                        } else {
+                                if (get_rf_type(rtlphy) != RF_2T2R)
+                                        return N_MODE_MCS7_RIX;
+                                else
+                                        return N_MODE_MCS15_RIX;
+                        }
+                } else {
+                        if (wireless_mode == WIRELESS_MODE_A) {
+                                return A_MODE_MAX_RIX;
+                        } else {
+                                if (get_rf_type(rtlphy) != RF_2T2R)
+                                        return N_MODE_MCS7_RIX;
+                                else
+                                        return N_MODE_MCS15_RIX;
+                        }
+                }
        }
 }
 static void _rtl_rc_rate_set_series(struct rtl_priv *rtlpriv,
+                                    struct ieee80211_sta *sta,
                                    struct ieee80211_tx_rate *rate,
                                    struct ieee80211_tx_rate_control *txrc,
-                                    u8 tries, u8 rix, int rtsctsenable,
+                                    u8 tries, char rix, int rtsctsenable,
                                    bool not_data)
 {
        struct rtl_mac *mac = rtl_mac(rtlpriv);
+        u8 sgi_20 = 0, sgi_40 = 0;
+        if (sta) {
+                sgi_20 = sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20;
+                sgi_40 = sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40;
+        }
        rate->count = tries;
-        rate->idx = (rix > 0x2) ? rix : 0x2;
+        rate->idx = rix >= 0x00 ? rix : 0x00;
        if (!not_data) {
                if (txrc->short_preamble)
                        rate->flags |= IEEE80211_TX_RC_USE_SHORT_PREAMBLE;
-                if (mac->bw_40)
+                if (mac->opmode == NL80211_IFTYPE_AP ||
-                        rate->flags |= IEEE80211_TX_RC_40_MHZ_WIDTH;
+                        mac->opmode == NL80211_IFTYPE_ADHOC) {
-                if (mac->sgi_20 || mac->sgi_40)
+                        if (sta && (sta->ht_cap.cap &
+                            IEEE80211_HT_CAP_SUP_WIDTH_20_40))
+                                rate->flags |= IEEE80211_TX_RC_40_MHZ_WIDTH;
+                } else {
+                        if (mac->bw_40)
+                                rate->flags |= IEEE80211_TX_RC_40_MHZ_WIDTH;
+                }
+                if (sgi_20 || sgi_40)
                        rate->flags |= IEEE80211_TX_RC_SHORT_GI;
-                if (mac->ht_enable)
+                if (sta && sta->ht_cap.ht_supported)
                        rate->flags |= IEEE80211_TX_RC_MCS;
        }
 }
@@ -97,39 +137,39 @@ static void rtl_get_rate(void *ppriv, struct ieee80211_sta *sta,
        struct sk_buff *skb = txrc->skb;
        struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
        struct ieee80211_tx_rate *rates = tx_info->control.rates;
-        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;
+        __le16 fc = rtl_get_fc(skb);
-        __le16 fc = hdr->frame_control;
        u8 try_per_rate, i, rix;
        bool not_data = !ieee80211_is_data(fc);
        if (rate_control_send_low(sta, priv_sta, txrc))
                return;
-        rix = _rtl_rc_get_highest_rix(rtlpriv, skb, not_data);
+        rix = _rtl_rc_get_highest_rix(rtlpriv, sta, skb, not_data);
        try_per_rate = 1;
-        _rtl_rc_rate_set_series(rtlpriv, &rates[0], txrc,
+        _rtl_rc_rate_set_series(rtlpriv, sta, &rates[0], txrc,
                                try_per_rate, rix, 1, not_data);
        if (!not_data) {
                for (i = 1; i < 4; i++)
-                        _rtl_rc_rate_set_series(rtlpriv, &rates[i],
+                        _rtl_rc_rate_set_series(rtlpriv, sta, &rates[i],
                                                txrc, i, (rix - i), 1,
                                                not_data);
        }
 }
-static bool _rtl_tx_aggr_check(struct rtl_priv *rtlpriv, u16 tid)
+static bool _rtl_tx_aggr_check(struct rtl_priv *rtlpriv,
+                struct rtl_sta_info *sta_entry, u16 tid)
 {
        struct rtl_mac *mac = rtl_mac(rtlpriv);
        if (mac->act_scanning)
                return false;
-        if (mac->cnt_after_linked < 3)
+        if (mac->opmode == NL80211_IFTYPE_STATION &&
+                mac->cnt_after_linked < 3)
                return false;
-        if (mac->tids[tid].agg.agg_state == RTL_AGG_OFF)
+        if (sta_entry->tids[tid].agg.agg_state == RTL_AGG_STOP)
                return true;
        return false;
@@ -143,11 +183,9 @@ static void rtl_tx_status(void *ppriv,
 {
        struct rtl_priv *rtlpriv = ppriv;
        struct rtl_mac *mac = rtl_mac(rtlpriv);
-        struct ieee80211_hdr *hdr;
+        struct ieee80211_hdr *hdr = rtl_get_hdr(skb);
-        __le16 fc;
+        __le16 fc = rtl_get_fc(skb);
+        struct rtl_sta_info *sta_entry;
-        hdr = (struct ieee80211_hdr *)skb->data;
-        fc = hdr->frame_control;
        if (!priv_sta || !ieee80211_is_data(fc))
                return;
@@ -159,17 +197,21 @@ static void rtl_tx_status(void *ppriv,
            || is_broadcast_ether_addr(ieee80211_get_DA(hdr)))
                return;
-        /* Check if aggregation has to be enabled for this tid */
+        if (sta) {
-        if (conf_is_ht(&mac->hw->conf) &&
+                /* Check if aggregation has to be enabled for this tid */
-            !(skb->protocol == cpu_to_be16(ETH_P_PAE))) {
+                sta_entry = (struct rtl_sta_info *) sta->drv_priv;
-                if (ieee80211_is_data_qos(fc)) {
+                if ((sta->ht_cap.ht_supported == true) &&
-                        u8 *qc, tid;
+                                !(skb->protocol == cpu_to_be16(ETH_P_PAE))) {
+                        if (ieee80211_is_data_qos(fc)) {
-                        qc = ieee80211_get_qos_ctl(hdr);
+                                u8 tid = rtl_get_tid(skb);
-                        tid = qc[0] & 0xf;
+                                if (_rtl_tx_aggr_check(rtlpriv, sta_entry,
+                                    tid)) {
-                        if (_rtl_tx_aggr_check(rtlpriv, tid))
+                                        sta_entry->tids[tid].agg.agg_state =
-                                ieee80211_start_tx_ba_session(sta, tid, 5000);
+                                                         RTL_AGG_PROGRESS;
+                                        ieee80211_start_tx_ba_session(sta,
+                                                                 tid, 5000);
+                                }
+                        }
                }
        }
 }
@@ -178,43 +220,6 @@ static void rtl_rate_init(void *ppriv,
                          struct ieee80211_supported_band *sband,
                          struct ieee80211_sta *sta, void *priv_sta)
 {
-        struct rtl_priv *rtlpriv = ppriv;
-        struct rtl_mac *mac = rtl_mac(rtlpriv);
-        u8 is_ht = conf_is_ht(&mac->hw->conf);
-        if ((mac->opmode == NL80211_IFTYPE_STATION) ||
-            (mac->opmode == NL80211_IFTYPE_MESH_POINT) ||
-            (mac->opmode == NL80211_IFTYPE_ADHOC)) {
-                switch (sband->band) {
-                case IEEE80211_BAND_2GHZ:
-                        rtlpriv->rate_priv->cur_ratetab_idx =
-                            RATR_INX_WIRELESS_G;
-                        if (is_ht)
-                                rtlpriv->rate_priv->cur_ratetab_idx =
-                                    RATR_INX_WIRELESS_NGB;
-                        break;
-                case IEEE80211_BAND_5GHZ:
-                        rtlpriv->rate_priv->cur_ratetab_idx =
-                            RATR_INX_WIRELESS_A;
-                        if (is_ht)
-                                rtlpriv->rate_priv->cur_ratetab_idx =
-                                    RATR_INX_WIRELESS_NGB;
-                        break;
-                default:
-                        RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
-                                 ("Invalid band\n"));
-                        rtlpriv->rate_priv->cur_ratetab_idx =
-                            RATR_INX_WIRELESS_NGB;
-                        break;
-                }
-                RT_TRACE(rtlpriv, COMP_RATE, DBG_DMESG,
-                         ("Choosing rate table index: %d\n",
-                          rtlpriv->rate_priv->cur_ratetab_idx));
-        }
 }
 static void rtl_rate_update(void *ppriv,
@@ -223,49 +228,6 @@ static void rtl_rate_update(void *ppriv,
                            u32 changed,
                            enum nl80211_channel_type oper_chan_type)
 {
-        struct rtl_priv *rtlpriv = ppriv;
-        struct rtl_mac *mac = rtl_mac(rtlpriv);
-        struct rtl_hal *rtlhal = rtl_hal(rtlpriv);
-        bool oper_cw40 = false, oper_sgi40;
-        bool local_cw40 = mac->bw_40;
-        bool local_sgi40 = mac->sgi_40;
-        u8 is_ht = conf_is_ht(&mac->hw->conf);
-        if (changed & IEEE80211_RC_HT_CHANGED) {
-                if (mac->opmode != NL80211_IFTYPE_STATION)
-                        return;
-                if (rtlhal->hw->conf.channel_type == NL80211_CHAN_HT40MINUS ||
-                    rtlhal->hw->conf.channel_type == NL80211_CHAN_HT40PLUS)
-                        oper_cw40 = true;
-                oper_sgi40 = mac->sgi_40;
-                if ((local_cw40 != oper_cw40) || (local_sgi40 != oper_sgi40)) {
-                        switch (sband->band) {
-                        case IEEE80211_BAND_2GHZ:
-                                rtlpriv->rate_priv->cur_ratetab_idx =
-                                    RATR_INX_WIRELESS_G;
-                                if (is_ht)
-                                        rtlpriv->rate_priv->cur_ratetab_idx =
-                                            RATR_INX_WIRELESS_NGB;
-                                break;
-                        case IEEE80211_BAND_5GHZ:
-                                rtlpriv->rate_priv->cur_ratetab_idx =
-                                    RATR_INX_WIRELESS_A;
-                                if (is_ht)
-                                        rtlpriv->rate_priv->cur_ratetab_idx =
-                                            RATR_INX_WIRELESS_NGB;
-                                break;
-                        default:
-                                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
-                                         ("Invalid band\n"));
-                                rtlpriv->rate_priv->cur_ratetab_idx =
-                                    RATR_INX_WIRELESS_NGB;
-                                break;
-                        }
-                }
-        }
 }
 static void *rtl_rate_alloc(struct ieee80211_hw *hw,
diff --git a/drivers/net/wireless/rtlwifi/rc.h b/drivers/net/wireless/rtlwifi/rc.h
index b4667c035f0b..4afa2c20adcf 100644
--- a/drivers/net/wireless/rtlwifi/rc.h
+++ b/drivers/net/wireless/rtlwifi/rc.h
@@ -30,8 +30,15 @@
 #ifndef __RTL_RC_H__
 #define __RTL_RC_H__
+#define B_MODE_MAX_RIX 3
+#define G_MODE_MAX_RIX 11
+#define A_MODE_MAX_RIX 7
+/* in mac80211 mcs0-mcs15 is idx0-idx15*/
+#define N_MODE_MCS7_RIX 7
+#define N_MODE_MCS15_RIX 15
 struct rtl_rate_priv {
-        u8 cur_ratetab_idx;
        u8 ht_cap;
 };
diff --git a/drivers/net/wireless/rtlwifi/regd.c b/drivers/net/wireless/rtlwifi/regd.c
index d26f957981ad..8f6718f163e5 100644
--- a/drivers/net/wireless/rtlwifi/regd.c
+++ b/drivers/net/wireless/rtlwifi/regd.c
@@ -66,31 +66,83 @@ static struct country_code_to_enum_rd allCountries[] = {
        NL80211_RRF_PASSIVE_SCAN | \
        NL80211_RRF_NO_OFDM)
+/* 5G chan 36 - chan 64*/
+#define RTL819x_5GHZ_5150_5350  \
+        REG_RULE(5150-10, 5350+10, 40, 0, 30, \
+        NL80211_RRF_PASSIVE_SCAN | \
+        NL80211_RRF_NO_IBSS)
+/* 5G chan 100 - chan 165*/
+#define RTL819x_5GHZ_5470_5850  \
+        REG_RULE(5470-10, 5850+10, 40, 0, 30, \
+        NL80211_RRF_PASSIVE_SCAN | \
+        NL80211_RRF_NO_IBSS)
+/* 5G chan 149 - chan 165*/
+#define RTL819x_5GHZ_5725_5850  \
+        REG_RULE(5725-10, 5850+10, 40, 0, 30, \
+        NL80211_RRF_PASSIVE_SCAN | \
+        NL80211_RRF_NO_IBSS)
+#define RTL819x_5GHZ_ALL        \
+        (RTL819x_5GHZ_5150_5350, RTL819x_5GHZ_5470_5850)
 static const struct ieee80211_regdomain rtl_regdom_11 = {
        .n_reg_rules = 1,
        .alpha2 = "99",
        .reg_rules = {
                      RTL819x_2GHZ_CH01_11,
-        }
+                      }
+};
+static const struct ieee80211_regdomain rtl_regdom_12_13 = {
+        .n_reg_rules = 2,
+        .alpha2 = "99",
+        .reg_rules = {
+                      RTL819x_2GHZ_CH01_11,
+                          RTL819x_2GHZ_CH12_13,
+                      }
 };
-static const struct ieee80211_regdomain rtl_regdom_global = {
+static const struct ieee80211_regdomain rtl_regdom_no_midband = {
        .n_reg_rules = 3,
        .alpha2 = "99",
        .reg_rules = {
                      RTL819x_2GHZ_CH01_11,
-                      RTL819x_2GHZ_CH12_13,
+                          RTL819x_5GHZ_5150_5350,
-                      RTL819x_2GHZ_CH14,
+                          RTL819x_5GHZ_5725_5850,
-        }
+                      }
 };
-static const struct ieee80211_regdomain rtl_regdom_world = {
+static const struct ieee80211_regdomain rtl_regdom_60_64 = {
-        .n_reg_rules = 2,
+        .n_reg_rules = 3,
        .alpha2 = "99",
        .reg_rules = {
                      RTL819x_2GHZ_CH01_11,
-                      RTL819x_2GHZ_CH12_13,
+                          RTL819x_2GHZ_CH12_13,
-        }
+                          RTL819x_5GHZ_5725_5850,
+                      }
+};
+static const struct ieee80211_regdomain rtl_regdom_14_60_64 = {
+        .n_reg_rules = 4,
+        .alpha2 = "99",
+        .reg_rules = {
+                      RTL819x_2GHZ_CH01_11,
+                          RTL819x_2GHZ_CH12_13,
+                          RTL819x_2GHZ_CH14,
+                          RTL819x_5GHZ_5725_5850,
+                      }
+};
+static const struct ieee80211_regdomain rtl_regdom_14 = {
+        .n_reg_rules = 3,
+        .alpha2 = "99",
+        .reg_rules = {
+                      RTL819x_2GHZ_CH01_11,
+                          RTL819x_2GHZ_CH12_13,
+                          RTL819x_2GHZ_CH14,
+                      }
 };
 static bool _rtl_is_radar_freq(u16 center_freq)
@@ -162,6 +214,8 @@ static void _rtl_reg_apply_active_scan_flags(struct wiphy *wiphy,
        u32 bandwidth = 0;
        int r;
+        if (!wiphy->bands[IEEE80211_BAND_2GHZ])
+                return;
        sband = wiphy->bands[IEEE80211_BAND_2GHZ];
        /*
@@ -292,25 +346,26 @@ static const struct ieee80211_regdomain *_rtl_regdomain_select(
 {
        switch (reg->country_code) {
        case COUNTRY_CODE_FCC:
+                return &rtl_regdom_no_midband;
        case COUNTRY_CODE_IC:
                return &rtl_regdom_11;
        case COUNTRY_CODE_ETSI:
+        case COUNTRY_CODE_TELEC_NETGEAR:
+                return &rtl_regdom_60_64;
        case COUNTRY_CODE_SPAIN:
        case COUNTRY_CODE_FRANCE:
        case COUNTRY_CODE_ISRAEL:
-        case COUNTRY_CODE_TELEC_NETGEAR:
+        case COUNTRY_CODE_WORLD_WIDE_13:
-                return &rtl_regdom_world;
+                return &rtl_regdom_12_13;
        case COUNTRY_CODE_MKK:
        case COUNTRY_CODE_MKK1:
        case COUNTRY_CODE_TELEC:
        case COUNTRY_CODE_MIC:
-                return &rtl_regdom_global;
+                return &rtl_regdom_14_60_64;
        case COUNTRY_CODE_GLOBAL_DOMAIN:
-                return &rtl_regdom_global;
+                return &rtl_regdom_14;
-        case COUNTRY_CODE_WORLD_WIDE_13:
-                return &rtl_regdom_world;
        default:
-                return &rtl_regdom_world;
+                return &rtl_regdom_no_midband;
        }
 }
@@ -323,9 +378,11 @@ static int _rtl_regd_init_wiphy(struct rtl_regulatory *reg,
        const struct ieee80211_regdomain *regd;
        wiphy->reg_notifier = reg_notifier;
        wiphy->flags |= WIPHY_FLAG_CUSTOM_REGULATORY;
        wiphy->flags &= ~WIPHY_FLAG_STRICT_REGULATORY;
        wiphy->flags &= ~WIPHY_FLAG_DISABLE_BEACON_HINTS;
        regd = _rtl_regdomain_select(reg);
        wiphy_apply_custom_regulatory(wiphy, regd);
        _rtl_reg_apply_radar_flags(wiphy);
@@ -355,8 +412,8 @@ int rtl_regd_init(struct ieee80211_hw *hw,
        if (wiphy == NULL || &rtlpriv->regd == NULL)
                return -EINVAL;
-        /* force the channel plan to world wide 13 */
+        /* init country_code from efuse channel plan */
-        rtlpriv->regd.country_code = COUNTRY_CODE_WORLD_WIDE_13;
+        rtlpriv->regd.country_code = rtlpriv->efuse.channel_plan;
        RT_TRACE(rtlpriv, COMP_REGD, DBG_TRACE,
                 (KERN_DEBUG "rtl: EEPROM regdomain: 0x%0x\n",
@@ -373,8 +430,8 @@ int rtl_regd_init(struct ieee80211_hw *hw,
        country = _rtl_regd_find_country(rtlpriv->regd.country_code);
        if (country) {
-                rtlpriv->regd.alpha2[0] = country->isoName[0];
+                rtlpriv->regd.alpha2[0] = country->iso_name[0];
-                rtlpriv->regd.alpha2[1] = country->isoName[1];
+                rtlpriv->regd.alpha2[1] = country->iso_name[1];
        } else {
                rtlpriv->regd.alpha2[0] = '0';
                rtlpriv->regd.alpha2[1] = '0';
diff --git a/drivers/net/wireless/rtlwifi/regd.h b/drivers/net/wireless/rtlwifi/regd.h
index 4cdbc4ae76d4..d23118938fac 100644
--- a/drivers/net/wireless/rtlwifi/regd.h
+++ b/drivers/net/wireless/rtlwifi/regd.h
@@ -32,7 +32,7 @@
 struct country_code_to_enum_rd {
        u16 countrycode;
-        const char *isoName;
+        const char *iso_name;
 };
 enum country_code_type_t {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index bb023274414c..97183829b9be 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
@@ -28,10 +28,26 @@
 *****************************************************************************/
 #include "dm_common.h"
+#include "phy_common.h"
+#include "../pci.h"
+#include "../base.h"
 struct dig_t dm_digtable;
 static struct ps_t dm_pstable;
+#define BT_RSSI_STATE_NORMAL_POWER      BIT_OFFSET_LEN_MASK_32(0, 1)
+#define BT_RSSI_STATE_AMDPU_OFF         BIT_OFFSET_LEN_MASK_32(1, 1)
+#define BT_RSSI_STATE_SPECIAL_LOW       BIT_OFFSET_LEN_MASK_32(2, 1)
+#define BT_RSSI_STATE_BG_EDCA_LOW       BIT_OFFSET_LEN_MASK_32(3, 1)
+#define BT_RSSI_STATE_TXPOWER_LOW       BIT_OFFSET_LEN_MASK_32(4, 1)
+#define RTLPRIV                 (struct rtl_priv *)
+#define GET_UNDECORATED_AVERAGE_RSSI(_priv)     \
+        ((RTLPRIV(_priv))->mac80211.opmode == \
+                             NL80211_IFTYPE_ADHOC) ?    \
+        ((RTLPRIV(_priv))->dm.entry_min_undecoratedsmoothed_pwdb) : \
+        ((RTLPRIV(_priv))->dm.undecorated_smoothed_pwdb)
 static const u32 ofdmswing_table[OFDM_TABLE_SIZE] = {
        0x7f8001fe,
        0x788001e2,
@@ -304,7 +320,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct ieee80211_hw *hw)
 static void rtl92c_dm_initial_gain_multi_sta(struct ieee80211_hw *hw)
 {
-        static u8 binitialized; /* initialized to false */
+        static u8 initialized; /* initialized to false */
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        long rssi_strength = rtlpriv->dm.entry_min_undecoratedsmoothed_pwdb;
@@ -315,11 +331,11 @@ static void rtl92c_dm_initial_gain_multi_sta(struct ieee80211_hw *hw)
        if ((multi_sta == false) || (dm_digtable.cursta_connectctate !=
                                     DIG_STA_DISCONNECT)) {
-                binitialized = false;
+                initialized = false;
                dm_digtable.dig_ext_port_stage = DIG_EXT_PORT_STAGE_MAX;
                return;
-        } else if (binitialized == false) {
+        } else if (initialized == false) {
-                binitialized = true;
+                initialized = true;
                dm_digtable.dig_ext_port_stage = DIG_EXT_PORT_STAGE_0;
                dm_digtable.cur_igvalue = 0x20;
                rtl92c_dm_write_dig(hw);
@@ -461,10 +477,7 @@ static void rtl92c_dm_ctrl_initgain_by_twoport(struct ieee80211_hw *hw)
        if (mac->act_scanning == true)
                return;
-        if ((mac->link_state > MAC80211_NOLINK) &&
+        if (mac->link_state >= MAC80211_LINKED)
-            (mac->link_state < MAC80211_LINKED))
-                dm_digtable.cursta_connectctate = DIG_STA_BEFORE_CONNECT;
-        else if (mac->link_state >= MAC80211_LINKED)
                dm_digtable.cursta_connectctate = DIG_STA_CONNECT;
        else
                dm_digtable.cursta_connectctate = DIG_STA_DISCONNECT;
@@ -562,23 +575,42 @@ EXPORT_SYMBOL(rtl92c_dm_init_edca_turbo);
 static void rtl92c_dm_check_edca_turbo(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        static u64 last_txok_cnt;
        static u64 last_rxok_cnt;
-        u64 cur_txok_cnt;
+        static u32 last_bt_edca_ul;
-        u64 cur_rxok_cnt;
+        static u32 last_bt_edca_dl;
+        u64 cur_txok_cnt = 0;
+        u64 cur_rxok_cnt = 0;
        u32 edca_be_ul = 0x5ea42b;
        u32 edca_be_dl = 0x5ea42b;
+        bool bt_change_edca = false;
-        if (mac->opmode == NL80211_IFTYPE_ADHOC)
+        if ((last_bt_edca_ul != rtlpcipriv->bt_coexist.bt_edca_ul) ||
-                goto dm_checkedcaturbo_exit;
+            (last_bt_edca_dl != rtlpcipriv->bt_coexist.bt_edca_dl)) {
+                rtlpriv->dm.current_turbo_edca = false;
+                last_bt_edca_ul = rtlpcipriv->bt_coexist.bt_edca_ul;
+                last_bt_edca_dl = rtlpcipriv->bt_coexist.bt_edca_dl;
+        }
+        if (rtlpcipriv->bt_coexist.bt_edca_ul != 0) {
+                edca_be_ul = rtlpcipriv->bt_coexist.bt_edca_ul;
+                bt_change_edca = true;
+        }
+        if (rtlpcipriv->bt_coexist.bt_edca_dl != 0) {
+                edca_be_ul = rtlpcipriv->bt_coexist.bt_edca_dl;
+                bt_change_edca = true;
+        }
        if (mac->link_state != MAC80211_LINKED) {
                rtlpriv->dm.current_turbo_edca = false;
                return;
        }
-        if (!mac->ht_enable) {  /*FIX MERGE */
+        if ((!mac->ht_enable) && (!rtlpcipriv->bt_coexist.bt_coexistence)) {
                if (!(edca_be_ul & 0xffff0000))
                        edca_be_ul |= 0x005e0000;
@@ -586,10 +618,12 @@ static void rtl92c_dm_check_edca_turbo(struct ieee80211_hw *hw)
                        edca_be_dl |= 0x005e0000;
        }
-        if ((!rtlpriv->dm.is_any_nonbepkts) &&
+        if ((bt_change_edca) || ((!rtlpriv->dm.is_any_nonbepkts) &&
-            (!rtlpriv->dm.disable_framebursting)) {
+             (!rtlpriv->dm.disable_framebursting))) {
                cur_txok_cnt = rtlpriv->stats.txbytesunicast - last_txok_cnt;
                cur_rxok_cnt = rtlpriv->stats.rxbytesunicast - last_rxok_cnt;
                if (cur_rxok_cnt > 4 * cur_txok_cnt) {
                        if (!rtlpriv->dm.is_cur_rdlstate ||
                            !rtlpriv->dm.current_turbo_edca) {
@@ -618,7 +652,6 @@ static void rtl92c_dm_check_edca_turbo(struct ieee80211_hw *hw)
                }
        }
-dm_checkedcaturbo_exit:
        rtlpriv->dm.is_any_nonbepkts = false;
        last_txok_cnt = rtlpriv->stats.txbytesunicast;
        last_rxok_cnt = rtlpriv->stats.rxbytesunicast;
@@ -633,14 +666,14 @@ static void rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
        u8 thermalvalue, delta, delta_lck, delta_iqk;
        long ele_a, ele_d, temp_cck, val_x, value32;
-        long val_y, ele_c;
+        long val_y, ele_c = 0;
-        u8 ofdm_index[2], cck_index, ofdm_index_old[2], cck_index_old;
+        u8 ofdm_index[2], cck_index = 0, ofdm_index_old[2], cck_index_old = 0;
        int i;
        bool is2t = IS_92C_SERIAL(rtlhal->version);
        u8 txpwr_level[2] = {0, 0};
        u8 ofdm_min_index = 6, rf;
-        rtlpriv->dm.txpower_trackingInit = true;
+        rtlpriv->dm.txpower_trackinginit = true;
        RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
                 ("rtl92c_dm_txpower_tracking_callback_thermalmeter\n"));
@@ -683,7 +716,6 @@ static void rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
                        for (i = 0; i < OFDM_TABLE_LENGTH; i++) {
                                if (ele_d == (ofdmswing_table[i] &
                                    MASKOFDM_D)) {
-                                        ofdm_index_old[1] = (u8) i;
                                        RT_TRACE(rtlpriv, COMP_POWER_TRACKING,
                                           DBG_LOUD,
@@ -1062,7 +1094,7 @@ static void rtl92c_dm_initialize_txpower_tracking_thermalmeter(
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        rtlpriv->dm.txpower_tracking = true;
-        rtlpriv->dm.txpower_trackingInit = false;
+        rtlpriv->dm.txpower_trackinginit = false;
        RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
                 ("pMgntInfo->txpower_tracking = %d\n",
@@ -1132,6 +1164,7 @@ static void rtl92c_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct rate_adaptive *p_ra = &(rtlpriv->ra);
        u32 low_rssithresh_for_ra, high_rssithresh_for_ra;
+        struct ieee80211_sta *sta = NULL;
        if (is_hal_stop(rtlhal)) {
                RT_TRACE(rtlpriv, COMP_RATE, DBG_LOUD,
@@ -1145,8 +1178,8 @@ static void rtl92c_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
                return;
        }
-        if (mac->link_state == MAC80211_LINKED) {
+        if (mac->link_state == MAC80211_LINKED &&
+            mac->opmode == NL80211_IFTYPE_STATION) {
                switch (p_ra->pre_ratr_state) {
                case DM_RATR_STA_HIGH:
                        high_rssithresh_for_ra = 50;
@@ -1185,10 +1218,13 @@ static void rtl92c_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
                                 ("PreState = %d, CurState = %d\n",
                                  p_ra->pre_ratr_state, p_ra->ratr_state));
-                        rtlpriv->cfg->ops->update_rate_mask(hw,
+                        rcu_read_lock();
+                        sta = ieee80211_find_sta(mac->vif, mac->bssid);
+                        rtlpriv->cfg->ops->update_rate_tbl(hw, sta,
                                        p_ra->ratr_state);
                        p_ra->pre_ratr_state = p_ra->ratr_state;
+                        rcu_read_unlock();
                }
        }
 }
@@ -1202,51 +1238,6 @@ static void rtl92c_dm_init_dynamic_bb_powersaving(struct ieee80211_hw *hw)
        dm_pstable.rssi_val_min = 0;
 }
-static void rtl92c_dm_1r_cca(struct ieee80211_hw *hw)
-{
-        struct rtl_priv *rtlpriv = rtl_priv(hw);
-        struct rtl_phy *rtlphy = &(rtlpriv->phy);
-        if (dm_pstable.rssi_val_min != 0) {
-                if (dm_pstable.pre_ccastate == CCA_2R) {
-                        if (dm_pstable.rssi_val_min >= 35)
-                                dm_pstable.cur_ccasate = CCA_1R;
-                        else
-                                dm_pstable.cur_ccasate = CCA_2R;
-                } else {
-                        if (dm_pstable.rssi_val_min <= 30)
-                                dm_pstable.cur_ccasate = CCA_2R;
-                        else
-                                dm_pstable.cur_ccasate = CCA_1R;
-                }
-        } else {
-                dm_pstable.cur_ccasate = CCA_MAX;
-        }
-        if (dm_pstable.pre_ccastate != dm_pstable.cur_ccasate) {
-                if (dm_pstable.cur_ccasate == CCA_1R) {
-                        if (get_rf_type(rtlphy) == RF_2T2R) {
-                                rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE,
-                                              MASKBYTE0, 0x13);
-                                rtl_set_bbreg(hw, 0xe70, MASKBYTE3, 0x20);
-                        } else {
-                                rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE,
-                                              MASKBYTE0, 0x23);
-                                rtl_set_bbreg(hw, 0xe70, 0x7fc00000, 0x10c);
-                        }
-                } else {
-                        rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, MASKBYTE0,
-                                      0x33);
-                        rtl_set_bbreg(hw, 0xe70, MASKBYTE3, 0x63);
-                }
-                dm_pstable.pre_ccastate = dm_pstable.cur_ccasate;
-        }
-        RT_TRACE(rtlpriv, DBG_LOUD, DBG_LOUD, ("CCAStage = %s\n",
-                                               (dm_pstable.cur_ccasate ==
-                                                0) ? "1RCCA" : "2RCCA"));
-}
 void rtl92c_dm_rf_saving(struct ieee80211_hw *hw, u8 bforce_in_normal)
 {
        static u8 initialize;
@@ -1352,7 +1343,9 @@ static void rtl92c_dm_dynamic_bb_powersaving(struct ieee80211_hw *hw)
        }
        if (IS_92C_SERIAL(rtlhal->version))
-                rtl92c_dm_1r_cca(hw);
+                ;/* rtl92c_dm_1r_cca(hw); */
+        else
+                rtl92c_dm_rf_saving(hw, false);
 }
 void rtl92c_dm_init(struct ieee80211_hw *hw)
@@ -1369,6 +1362,84 @@ void rtl92c_dm_init(struct ieee80211_hw *hw)
 }
 EXPORT_SYMBOL(rtl92c_dm_init);
+void rtl92c_dm_dynamic_txpower(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        long undecorated_smoothed_pwdb;
+        if (!rtlpriv->dm.dynamic_txpower_enable)
+                return;
+        if (rtlpriv->dm.dm_flag & HAL_DM_HIPWR_DISABLE) {
+                rtlpriv->dm.dynamic_txhighpower_lvl = TXHIGHPWRLEVEL_NORMAL;
+                return;
+        }
+        if ((mac->link_state < MAC80211_LINKED) &&
+            (rtlpriv->dm.entry_min_undecoratedsmoothed_pwdb == 0)) {
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_TRACE,
+                         ("Not connected to any\n"));
+                rtlpriv->dm.dynamic_txhighpower_lvl = TXHIGHPWRLEVEL_NORMAL;
+                rtlpriv->dm.last_dtp_lvl = TXHIGHPWRLEVEL_NORMAL;
+                return;
+        }
+        if (mac->link_state >= MAC80211_LINKED) {
+                if (mac->opmode == NL80211_IFTYPE_ADHOC) {
+                        undecorated_smoothed_pwdb =
+                            rtlpriv->dm.entry_min_undecoratedsmoothed_pwdb;
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                                 ("AP Client PWDB = 0x%lx\n",
+                                  undecorated_smoothed_pwdb));
+                } else {
+                        undecorated_smoothed_pwdb =
+                            rtlpriv->dm.undecorated_smoothed_pwdb;
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                                 ("STA Default Port PWDB = 0x%lx\n",
+                                  undecorated_smoothed_pwdb));
+                }
+        } else {
+                undecorated_smoothed_pwdb =
+                    rtlpriv->dm.entry_min_undecoratedsmoothed_pwdb;
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("AP Ext Port PWDB = 0x%lx\n",
+                          undecorated_smoothed_pwdb));
+        }
+        if (undecorated_smoothed_pwdb >= TX_POWER_NEAR_FIELD_THRESH_LVL2) {
+                rtlpriv->dm.dynamic_txhighpower_lvl = TXHIGHPWRLEVEL_LEVEL1;
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("TXHIGHPWRLEVEL_LEVEL1 (TxPwr=0x0)\n"));
+        } else if ((undecorated_smoothed_pwdb <
+                    (TX_POWER_NEAR_FIELD_THRESH_LVL2 - 3)) &&
+                   (undecorated_smoothed_pwdb >=
+                    TX_POWER_NEAR_FIELD_THRESH_LVL1)) {
+                rtlpriv->dm.dynamic_txhighpower_lvl = TXHIGHPWRLEVEL_LEVEL1;
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("TXHIGHPWRLEVEL_LEVEL1 (TxPwr=0x10)\n"));
+        } else if (undecorated_smoothed_pwdb <
+                   (TX_POWER_NEAR_FIELD_THRESH_LVL1 - 5)) {
+                rtlpriv->dm.dynamic_txhighpower_lvl = TXHIGHPWRLEVEL_NORMAL;
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("TXHIGHPWRLEVEL_NORMAL\n"));
+        }
+        if ((rtlpriv->dm.dynamic_txhighpower_lvl != rtlpriv->dm.last_dtp_lvl)) {
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("PHY_SetTxPowerLevel8192S() Channel = %d\n",
+                          rtlphy->current_channel));
+                rtl92c_phy_set_txpower_level(hw, rtlphy->current_channel);
+        }
+        rtlpriv->dm.last_dtp_lvl = rtlpriv->dm.dynamic_txhighpower_lvl;
+}
 void rtl92c_dm_watchdog(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
@@ -1388,11 +1459,321 @@ void rtl92c_dm_watchdog(struct ieee80211_hw *hw)
                rtl92c_dm_dig(hw);
                rtl92c_dm_false_alarm_counter_statistics(hw);
                rtl92c_dm_dynamic_bb_powersaving(hw);
-                rtlpriv->cfg->ops->dm_dynamic_txpower(hw);
+                rtl92c_dm_dynamic_txpower(hw);
                rtl92c_dm_check_txpower_tracking(hw);
                rtl92c_dm_refresh_rate_adaptive_mask(hw);
+                rtl92c_dm_bt_coexist(hw);
                rtl92c_dm_check_edca_turbo(hw);
        }
 }
 EXPORT_SYMBOL(rtl92c_dm_watchdog);
+u8 rtl92c_bt_rssi_state_change(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
+        long undecorated_smoothed_pwdb;
+        u8 curr_bt_rssi_state = 0x00;
+        if (rtlpriv->mac80211.link_state == MAC80211_LINKED) {
+                undecorated_smoothed_pwdb =
+                                 GET_UNDECORATED_AVERAGE_RSSI(rtlpriv);
+        } else {
+                if (rtlpriv->dm.entry_min_undecoratedsmoothed_pwdb == 0)
+                        undecorated_smoothed_pwdb = 100;
+                else
+                        undecorated_smoothed_pwdb =
+                                rtlpriv->dm.entry_min_undecoratedsmoothed_pwdb;
+        }
+        /* Check RSSI to determine HighPower/NormalPower state for
+         * BT coexistence. */
+        if (undecorated_smoothed_pwdb >= 67)
+                curr_bt_rssi_state &= (~BT_RSSI_STATE_NORMAL_POWER);
+        else if (undecorated_smoothed_pwdb < 62)
+                curr_bt_rssi_state |= BT_RSSI_STATE_NORMAL_POWER;
+        /* Check RSSI to determine AMPDU setting for BT coexistence. */
+        if (undecorated_smoothed_pwdb >= 40)
+                curr_bt_rssi_state &= (~BT_RSSI_STATE_AMDPU_OFF);
+        else if (undecorated_smoothed_pwdb <= 32)
+                curr_bt_rssi_state |= BT_RSSI_STATE_AMDPU_OFF;
+        /* Marked RSSI state. It will be used to determine BT coexistence
+         * setting later. */
+        if (undecorated_smoothed_pwdb < 35)
+                curr_bt_rssi_state |=  BT_RSSI_STATE_SPECIAL_LOW;
+        else
+                curr_bt_rssi_state &= (~BT_RSSI_STATE_SPECIAL_LOW);
+        /* Set Tx Power according to BT status. */
+        if (undecorated_smoothed_pwdb >= 30)
+                curr_bt_rssi_state |=  BT_RSSI_STATE_TXPOWER_LOW;
+        else if (undecorated_smoothed_pwdb < 25)
+                curr_bt_rssi_state &= (~BT_RSSI_STATE_TXPOWER_LOW);
+        /* Check BT state related to BT_Idle in B/G mode. */
+        if (undecorated_smoothed_pwdb < 15)
+                curr_bt_rssi_state |=  BT_RSSI_STATE_BG_EDCA_LOW;
+        else
+                curr_bt_rssi_state &= (~BT_RSSI_STATE_BG_EDCA_LOW);
+        if (curr_bt_rssi_state != rtlpcipriv->bt_coexist.bt_rssi_state) {
+                rtlpcipriv->bt_coexist.bt_rssi_state = curr_bt_rssi_state;
+                return true;
+        } else {
+                return false;
+        }
+}
+EXPORT_SYMBOL(rtl92c_bt_rssi_state_change);
+static bool rtl92c_bt_state_change(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
+        u32 polling, ratio_tx, ratio_pri;
+        u32 bt_tx, bt_pri;
+        u8 bt_state;
+        u8 cur_service_type;
+        if (rtlpriv->mac80211.link_state < MAC80211_LINKED)
+                return false;
+        bt_state = rtl_read_byte(rtlpriv, 0x4fd);
+        bt_tx = rtl_read_dword(rtlpriv, 0x488);
+        bt_tx = bt_tx & 0x00ffffff;
+        bt_pri = rtl_read_dword(rtlpriv, 0x48c);
+        bt_pri = bt_pri & 0x00ffffff;
+        polling = rtl_read_dword(rtlpriv, 0x490);
+        if (bt_tx == 0xffffffff && bt_pri == 0xffffffff &&
+            polling == 0xffffffff && bt_state == 0xff)
+                return false;
+        bt_state &= BIT_OFFSET_LEN_MASK_32(0, 1);
+        if (bt_state != rtlpcipriv->bt_coexist.bt_cur_state) {
+                rtlpcipriv->bt_coexist.bt_cur_state = bt_state;
+                if (rtlpcipriv->bt_coexist.reg_bt_sco == 3) {
+                        rtlpcipriv->bt_coexist.bt_service = BT_IDLE;
+                        bt_state = bt_state |
+                          ((rtlpcipriv->bt_coexist.bt_ant_isolation == 1) ?
+                          0 : BIT_OFFSET_LEN_MASK_32(1, 1)) |
+                          BIT_OFFSET_LEN_MASK_32(2, 1);
+                        rtl_write_byte(rtlpriv, 0x4fd, bt_state);
+                }
+                return true;
+        }
+        ratio_tx = bt_tx * 1000 / polling;
+        ratio_pri = bt_pri * 1000 / polling;
+        rtlpcipriv->bt_coexist.ratio_tx = ratio_tx;
+        rtlpcipriv->bt_coexist.ratio_pri = ratio_pri;
+        if (bt_state && rtlpcipriv->bt_coexist.reg_bt_sco == 3) {
+                if ((ratio_tx < 30)  && (ratio_pri < 30))
+                        cur_service_type = BT_IDLE;
+                else if ((ratio_pri > 110) && (ratio_pri < 250))
+                        cur_service_type = BT_SCO;
+                else if ((ratio_tx >= 200) && (ratio_pri >= 200))
+                        cur_service_type = BT_BUSY;
+                else if ((ratio_tx >= 350) && (ratio_tx < 500))
+                        cur_service_type = BT_OTHERBUSY;
+                else if (ratio_tx >= 500)
+                        cur_service_type = BT_PAN;
+                else
+                        cur_service_type = BT_OTHER_ACTION;
+                if (cur_service_type != rtlpcipriv->bt_coexist.bt_service) {
+                        rtlpcipriv->bt_coexist.bt_service = cur_service_type;
+                        bt_state = bt_state |
+                           ((rtlpcipriv->bt_coexist.bt_ant_isolation == 1) ?
+                           0 : BIT_OFFSET_LEN_MASK_32(1, 1)) |
+                           ((rtlpcipriv->bt_coexist.bt_service != BT_IDLE) ?
+                           0 : BIT_OFFSET_LEN_MASK_32(2, 1));
+                        /* Add interrupt migration when bt is not ini
+                         * idle state (no traffic). */
+                        if (rtlpcipriv->bt_coexist.bt_service != BT_IDLE) {
+                                rtl_write_word(rtlpriv, 0x504, 0x0ccc);
+                                rtl_write_byte(rtlpriv, 0x506, 0x54);
+                                rtl_write_byte(rtlpriv, 0x507, 0x54);
+                        } else {
+                                rtl_write_byte(rtlpriv, 0x506, 0x00);
+                                rtl_write_byte(rtlpriv, 0x507, 0x00);
+                        }
+                        rtl_write_byte(rtlpriv, 0x4fd, bt_state);
+                        return true;
+                }
+        }
+        return false;
+}
+static bool rtl92c_bt_wifi_connect_change(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        static bool media_connect;
+        if (rtlpriv->mac80211.link_state < MAC80211_LINKED) {
+                media_connect = false;
+        } else {
+                if (!media_connect) {
+                        media_connect = true;
+                        return true;
+                }
+                media_connect = true;
+        }
+        return false;
+}
+static void rtl92c_bt_set_normal(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
+        if (rtlpcipriv->bt_coexist.bt_service == BT_OTHERBUSY) {
+                rtlpcipriv->bt_coexist.bt_edca_ul = 0x5ea72b;
+                rtlpcipriv->bt_coexist.bt_edca_dl = 0x5ea72b;
+        } else if (rtlpcipriv->bt_coexist.bt_service == BT_BUSY) {
+                rtlpcipriv->bt_coexist.bt_edca_ul = 0x5eb82f;
+                rtlpcipriv->bt_coexist.bt_edca_dl = 0x5eb82f;
+        } else if (rtlpcipriv->bt_coexist.bt_service == BT_SCO) {
+                if (rtlpcipriv->bt_coexist.ratio_tx > 160) {
+                        rtlpcipriv->bt_coexist.bt_edca_ul = 0x5ea72f;
+                        rtlpcipriv->bt_coexist.bt_edca_dl = 0x5ea72f;
+                } else {
+                        rtlpcipriv->bt_coexist.bt_edca_ul = 0x5ea32b;
+                        rtlpcipriv->bt_coexist.bt_edca_dl = 0x5ea42b;
+                }
+        } else {
+                rtlpcipriv->bt_coexist.bt_edca_ul = 0;
+                rtlpcipriv->bt_coexist.bt_edca_dl = 0;
+        }
+        if ((rtlpcipriv->bt_coexist.bt_service != BT_IDLE) &&
+             (rtlpriv->mac80211.mode == WIRELESS_MODE_G ||
+             (rtlpriv->mac80211.mode == (WIRELESS_MODE_G | WIRELESS_MODE_B))) &&
+             (rtlpcipriv->bt_coexist.bt_rssi_state &
+             BT_RSSI_STATE_BG_EDCA_LOW)) {
+                rtlpcipriv->bt_coexist.bt_edca_ul = 0x5eb82b;
+                rtlpcipriv->bt_coexist.bt_edca_dl = 0x5eb82b;
+        }
+}
+static void rtl92c_bt_ant_isolation(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
+        /* Only enable HW BT coexist when BT in "Busy" state. */
+        if (rtlpriv->mac80211.vendor == PEER_CISCO &&
+            rtlpcipriv->bt_coexist.bt_service == BT_OTHER_ACTION) {
+                rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0xa0);
+        } else {
+                if ((rtlpcipriv->bt_coexist.bt_service == BT_BUSY) &&
+                    (rtlpcipriv->bt_coexist.bt_rssi_state &
+                     BT_RSSI_STATE_NORMAL_POWER)) {
+                        rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0xa0);
+                } else if ((rtlpcipriv->bt_coexist.bt_service ==
+                            BT_OTHER_ACTION) && (rtlpriv->mac80211.mode <
+                            WIRELESS_MODE_N_24G) &&
+                            (rtlpcipriv->bt_coexist.bt_rssi_state &
+                            BT_RSSI_STATE_SPECIAL_LOW)) {
+                        rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0xa0);
+                } else if (rtlpcipriv->bt_coexist.bt_service == BT_PAN) {
+                        rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0x00);
+                } else {
+                        rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0x00);
+                }
+        }
+        if (rtlpcipriv->bt_coexist.bt_service == BT_PAN)
+                rtl_write_dword(rtlpriv, REG_GPIO_PIN_CTRL, 0x10100);
+        else
+                rtl_write_dword(rtlpriv, REG_GPIO_PIN_CTRL, 0x0);
+        if (rtlpcipriv->bt_coexist.bt_rssi_state &
+            BT_RSSI_STATE_NORMAL_POWER) {
+                rtl92c_bt_set_normal(hw);
+        } else {
+                rtlpcipriv->bt_coexist.bt_edca_ul = 0;
+                rtlpcipriv->bt_coexist.bt_edca_dl = 0;
+        }
+        if (rtlpcipriv->bt_coexist.bt_service != BT_IDLE) {
+                rtlpriv->cfg->ops->set_rfreg(hw,
+                                 RF90_PATH_A,
+                                 0x1e,
+                                 0xf0, 0xf);
+        } else {
+                rtlpriv->cfg->ops->set_rfreg(hw,
+                     RF90_PATH_A, 0x1e, 0xf0,
+                     rtlpcipriv->bt_coexist.bt_rfreg_origin_1e);
+        }
+        if (!rtlpriv->dm.dynamic_txpower_enable) {
+                if (rtlpcipriv->bt_coexist.bt_service != BT_IDLE) {
+                        if (rtlpcipriv->bt_coexist.bt_rssi_state &
+                                BT_RSSI_STATE_TXPOWER_LOW) {
+                                rtlpriv->dm.dynamic_txhighpower_lvl =
+                                                        TXHIGHPWRLEVEL_BT2;
+                        } else {
+                                rtlpriv->dm.dynamic_txhighpower_lvl =
+                                        TXHIGHPWRLEVEL_BT1;
+                        }
+                } else {
+                        rtlpriv->dm.dynamic_txhighpower_lvl =
+                                TXHIGHPWRLEVEL_NORMAL;
+                }
+                rtl92c_phy_set_txpower_level(hw,
+                        rtlpriv->phy.current_channel);
+        }
+}
+static void rtl92c_check_bt_change(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
+        if (rtlpcipriv->bt_coexist.bt_cur_state) {
+                if (rtlpcipriv->bt_coexist.bt_ant_isolation)
+                        rtl92c_bt_ant_isolation(hw);
+        } else {
+                rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0x00);
+                rtlpriv->cfg->ops->set_rfreg(hw, RF90_PATH_A, 0x1e, 0xf0,
+                                rtlpcipriv->bt_coexist.bt_rfreg_origin_1e);
+                rtlpcipriv->bt_coexist.bt_edca_ul = 0;
+                rtlpcipriv->bt_coexist.bt_edca_dl = 0;
+        }
+}
+void rtl92c_dm_bt_coexist(struct ieee80211_hw *hw)
+{
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
+        bool wifi_connect_change;
+        bool bt_state_change;
+        bool rssi_state_change;
+        if ((rtlpcipriv->bt_coexist.bt_coexistence) &&
+             (rtlpcipriv->bt_coexist.bt_coexist_type == BT_CSR_BC4)) {
+                wifi_connect_change = rtl92c_bt_wifi_connect_change(hw);
+                bt_state_change = rtl92c_bt_state_change(hw);
+                rssi_state_change = rtl92c_bt_rssi_state_change(hw);
+                if (wifi_connect_change || bt_state_change || rssi_state_change)
+                        rtl92c_check_bt_change(hw);
+        }
+}
+EXPORT_SYMBOL(rtl92c_dm_bt_coexist);
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.h b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.h
index b9cbb0a3c03f..b9736d3e9a39 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.h
@@ -200,5 +200,7 @@ void rtl92c_dm_rf_saving(struct ieee80211_hw *hw, u8 bforce_in_normal);
 void rtl92c_phy_ap_calibrate(struct ieee80211_hw *hw, char delta);
 void rtl92c_phy_lc_calibrate(struct ieee80211_hw *hw);
 void rtl92c_phy_iq_calibrate(struct ieee80211_hw *hw, bool recovery);
+void rtl92c_dm_dynamic_txpower(struct ieee80211_hw *hw);
+void rtl92c_dm_bt_coexist(struct ieee80211_hw *hw);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c
index 28a6ce3bc239..50303e1adff1 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c
@@ -171,7 +171,6 @@ static void _rtl92c_write_fw(struct ieee80211_hw *hw,
 static int _rtl92c_fw_free_to_go(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-        int err = -EIO;
        u32 counter = 0;
        u32 value32;
@@ -184,7 +183,7 @@ static int _rtl92c_fw_free_to_go(struct ieee80211_hw *hw)
                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
                         ("chksum report faill ! REG_MCUFWDL:0x%08x .\n",
                          value32));
-                goto exit;
+                return -EIO;
        }
        RT_TRACE(rtlpriv, COMP_FW, DBG_TRACE,
@@ -204,8 +203,7 @@ static int _rtl92c_fw_free_to_go(struct ieee80211_hw *hw)
                                 ("Polling FW ready success!!"
                                 " REG_MCUFWDL:0x%08x .\n",
                                 value32));
-                        err = 0;
+                        return 0;
-                        goto exit;
                }
                mdelay(FW_8192C_POLLING_DELAY);
@@ -214,9 +212,7 @@ static int _rtl92c_fw_free_to_go(struct ieee80211_hw *hw)
        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
                 ("Polling FW ready fail!! REG_MCUFWDL:0x%08x .\n", value32));
+        return -EIO;
-exit:
-        return err;
 }
 int rtl92c_download_fw(struct ieee80211_hw *hw)
@@ -226,32 +222,16 @@ int rtl92c_download_fw(struct ieee80211_hw *hw)
        struct rtl92c_firmware_header *pfwheader;
        u8 *pfwdata;
        u32 fwsize;
-        int err;
        enum version_8192c version = rtlhal->version;
-        const struct firmware *firmware;
-        printk(KERN_INFO "rtl8192cu: Loading firmware file %s\n",
+        printk(KERN_INFO "rtl8192c: Loading firmware file %s\n",
               rtlpriv->cfg->fw_name);
-        err = request_firmware(&firmware, rtlpriv->cfg->fw_name,
+        if (!rtlhal->pfirmware)
-                               rtlpriv->io.dev);
-        if (err) {
-                printk(KERN_ERR "rtl8192cu: Firmware loading failed\n");
-                return 1;
-        }
-        if (firmware->size > 0x4000) {
-                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
-                         ("Firmware is too big!\n"));
-                release_firmware(firmware);
                return 1;
-        }
-        memcpy(rtlhal->pfirmware, firmware->data, firmware->size);
-        fwsize = firmware->size;
-        release_firmware(firmware);
        pfwheader = (struct rtl92c_firmware_header *)rtlhal->pfirmware;
        pfwdata = (u8 *) rtlhal->pfirmware;
+        fwsize = rtlhal->fwsize;
        if (IS_FW_HEADER_EXIST(pfwheader)) {
                RT_TRACE(rtlpriv, COMP_FW, DBG_DMESG,
@@ -267,8 +247,7 @@ int rtl92c_download_fw(struct ieee80211_hw *hw)
        _rtl92c_write_fw(hw, version, pfwdata, fwsize);
        _rtl92c_enable_fw_download(hw, false);
-        err = _rtl92c_fw_free_to_go(hw);
+        if (_rtl92c_fw_free_to_go(hw)) {
-        if (err) {
                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
                         ("Firmware is not ready to run!\n"));
        } else {
@@ -300,10 +279,9 @@ static void _rtl92c_fill_h2c_command(struct ieee80211_hw *hw,
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
        u8 boxnum;
-        u16 box_reg, box_extreg;
+        u16 box_reg = 0, box_extreg = 0;
        u8 u1b_tmp;
        bool isfw_read = false;
-        u8 buf_index = 0;
        bool bwrite_sucess = false;
        u8 wait_h2c_limmit = 100;
        u8 wait_writeh2c_limmit = 100;
@@ -414,7 +392,7 @@ static void _rtl92c_fill_h2c_command(struct ieee80211_hw *hw,
                case 1:
                        boxcontent[0] &= ~(BIT(7));
                        memcpy((u8 *) (boxcontent) + 1,
-                               p_cmdbuffer + buf_index, 1);
+                               p_cmdbuffer, 1);
                        for (idx = 0; idx < 4; idx++) {
                                rtl_write_byte(rtlpriv, box_reg + idx,
@@ -424,7 +402,7 @@ static void _rtl92c_fill_h2c_command(struct ieee80211_hw *hw,
                case 2:
                        boxcontent[0] &= ~(BIT(7));
                        memcpy((u8 *) (boxcontent) + 1,
-                               p_cmdbuffer + buf_index, 2);
+                               p_cmdbuffer, 2);
                        for (idx = 0; idx < 4; idx++) {
                                rtl_write_byte(rtlpriv, box_reg + idx,
@@ -434,7 +412,7 @@ static void _rtl92c_fill_h2c_command(struct ieee80211_hw *hw,
                case 3:
                        boxcontent[0] &= ~(BIT(7));
                        memcpy((u8 *) (boxcontent) + 1,
-                               p_cmdbuffer + buf_index, 3);
+                               p_cmdbuffer, 3);
                        for (idx = 0; idx < 4; idx++) {
                                rtl_write_byte(rtlpriv, box_reg + idx,
@@ -444,9 +422,9 @@ static void _rtl92c_fill_h2c_command(struct ieee80211_hw *hw,
                case 4:
                        boxcontent[0] |= (BIT(7));
                        memcpy((u8 *) (boxextcontent),
-                               p_cmdbuffer + buf_index, 2);
+                               p_cmdbuffer, 2);
                        memcpy((u8 *) (boxcontent) + 1,
-                               p_cmdbuffer + buf_index + 2, 2);
+                               p_cmdbuffer + 2, 2);
                        for (idx = 0; idx < 2; idx++) {
                                rtl_write_byte(rtlpriv, box_extreg + idx,
@@ -461,9 +439,9 @@ static void _rtl92c_fill_h2c_command(struct ieee80211_hw *hw,
                case 5:
                        boxcontent[0] |= (BIT(7));
                        memcpy((u8 *) (boxextcontent),
-                               p_cmdbuffer + buf_index, 2);
+                               p_cmdbuffer, 2);
                        memcpy((u8 *) (boxcontent) + 1,
-                               p_cmdbuffer + buf_index + 2, 3);
+                               p_cmdbuffer + 2, 3);
                        for (idx = 0; idx < 2; idx++) {
                                rtl_write_byte(rtlpriv, box_extreg + idx,
@@ -561,6 +539,39 @@ void rtl92c_set_fw_pwrmode_cmd(struct ieee80211_hw *hw, u8 mode)
 }
 EXPORT_SYMBOL(rtl92c_set_fw_pwrmode_cmd);
+static bool _rtl92c_cmd_send_packet(struct ieee80211_hw *hw,
+                                struct sk_buff *skb)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl8192_tx_ring *ring;
+        struct rtl_tx_desc *pdesc;
+        u8 own;
+        unsigned long flags;
+        struct sk_buff *pskb = NULL;
+        ring = &rtlpci->tx_ring[BEACON_QUEUE];
+        pskb = __skb_dequeue(&ring->queue);
+        if (pskb)
+                kfree_skb(pskb);
+        spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
+        pdesc = &ring->desc[0];
+        own = (u8) rtlpriv->cfg->ops->get_desc((u8 *) pdesc, true, HW_DESC_OWN);
+        rtlpriv->cfg->ops->fill_tx_cmddesc(hw, (u8 *) pdesc, 1, 1, skb);
+        __skb_queue_tail(&ring->queue, skb);
+        spin_unlock_irqrestore(&rtlpriv->locks.irq_th_lock, flags);
+        rtlpriv->cfg->ops->tx_polling(hw, BEACON_QUEUE);
+        return true;
+}
 #define BEACON_PG               0 /*->1*/
 #define PSPOLL_PG               2
 #define NULL_PG                 3
@@ -678,7 +689,7 @@ static u8 reserved_page_packet[TOTAL_RESERVED_PKT_LEN] = {
        0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
 };
-void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
+void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool dl_finished)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
@@ -687,12 +698,12 @@ void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
        u32 totalpacketlen;
        bool rtstatus;
        u8 u1RsvdPageLoc[3] = {0};
-        bool b_dlok = false;
+        bool dlok = false;
        u8 *beacon;
-        u8 *p_pspoll;
+        u8 *pspoll;
        u8 *nullfunc;
-        u8 *p_probersp;
+        u8 *probersp;
        /*---------------------------------------------------------
                                (1) beacon
        ---------------------------------------------------------*/
@@ -703,10 +714,10 @@ void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
        /*-------------------------------------------------------
                                (2) ps-poll
        --------------------------------------------------------*/
-        p_pspoll = &reserved_page_packet[PSPOLL_PG * 128];
+        pspoll = &reserved_page_packet[PSPOLL_PG * 128];
-        SET_80211_PS_POLL_AID(p_pspoll, (mac->assoc_id | 0xc000));
+        SET_80211_PS_POLL_AID(pspoll, (mac->assoc_id | 0xc000));
-        SET_80211_PS_POLL_BSSID(p_pspoll, mac->bssid);
+        SET_80211_PS_POLL_BSSID(pspoll, mac->bssid);
-        SET_80211_PS_POLL_TA(p_pspoll, mac->mac_addr);
+        SET_80211_PS_POLL_TA(pspoll, mac->mac_addr);
        SET_H2CCMD_RSVDPAGE_LOC_PSPOLL(u1RsvdPageLoc, PSPOLL_PG);
@@ -723,10 +734,10 @@ void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
        /*---------------------------------------------------------
                                (4) probe response
        ----------------------------------------------------------*/
-        p_probersp = &reserved_page_packet[PROBERSP_PG * 128];
+        probersp = &reserved_page_packet[PROBERSP_PG * 128];
-        SET_80211_HDR_ADDRESS1(p_probersp, mac->bssid);
+        SET_80211_HDR_ADDRESS1(probersp, mac->bssid);
-        SET_80211_HDR_ADDRESS2(p_probersp, mac->mac_addr);
+        SET_80211_HDR_ADDRESS2(probersp, mac->mac_addr);
-        SET_80211_HDR_ADDRESS3(p_probersp, mac->bssid);
+        SET_80211_HDR_ADDRESS3(probersp, mac->bssid);
        SET_H2CCMD_RSVDPAGE_LOC_PROBE_RSP(u1RsvdPageLoc, PROBERSP_PG);
@@ -744,12 +755,12 @@ void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
        memcpy((u8 *) skb_put(skb, totalpacketlen),
               &reserved_page_packet, totalpacketlen);
-        rtstatus = rtlpriv->cfg->ops->cmd_send_packet(hw, skb);
+        rtstatus = _rtl92c_cmd_send_packet(hw, skb);
        if (rtstatus)
-                b_dlok = true;
+                dlok = true;
-        if (b_dlok) {
+        if (dlok) {
                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
                         ("Set RSVD page location to Fw.\n"));
                RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_DMESG,
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.h b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.h
index 3db33bd14666..3d5823c12621 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.h
@@ -27,8 +27,8 @@
 *
 *****************************************************************************/
-#ifndef __RTL92C__FW__H__
+#ifndef __RTL92C__FW__COMMON__H__
-#define __RTL92C__FW__H__
+#define __RTL92C__FW__COMMON__H__
 #define FW_8192C_SIZE                           0x3000
 #define FW_8192C_START_ADDRESS                  0x1000
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
index a70228278398..c5424cad43cb 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
@@ -78,27 +78,29 @@ void rtl92c_phy_set_bb_reg(struct ieee80211_hw *hw,
        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, ("regaddr(%#x), bitmask(%#x),"
                                               " data(%#x)\n", regaddr, bitmask,
                                               data));
 }
 EXPORT_SYMBOL(rtl92c_phy_set_bb_reg);
 u32 _rtl92c_phy_fw_rf_serial_read(struct ieee80211_hw *hw,
-                                         enum radio_path rfpath, u32 offset)
+                                  enum radio_path rfpath, u32 offset)
 {
        RT_ASSERT(false, ("deprecated!\n"));
        return 0;
 }
 EXPORT_SYMBOL(_rtl92c_phy_fw_rf_serial_read);
 void _rtl92c_phy_fw_rf_serial_write(struct ieee80211_hw *hw,
-                                           enum radio_path rfpath, u32 offset,
+                                    enum radio_path rfpath, u32 offset,
-                                           u32 data)
+                                    u32 data)
 {
        RT_ASSERT(false, ("deprecated!\n"));
 }
 EXPORT_SYMBOL(_rtl92c_phy_fw_rf_serial_write);
 u32 _rtl92c_phy_rf_serial_read(struct ieee80211_hw *hw,
-                                      enum radio_path rfpath, u32 offset)
+                               enum radio_path rfpath, u32 offset)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
@@ -149,8 +151,8 @@ u32 _rtl92c_phy_rf_serial_read(struct ieee80211_hw *hw,
 EXPORT_SYMBOL(_rtl92c_phy_rf_serial_read);
 void _rtl92c_phy_rf_serial_write(struct ieee80211_hw *hw,
-                                        enum radio_path rfpath, u32 offset,
+                                 enum radio_path rfpath, u32 offset,
-                                        u32 data)
+                                 u32 data)
 {
        u32 data_and_addr;
        u32 newoffset;
@@ -197,6 +199,7 @@ static void _rtl92c_phy_bb_config_1t(struct ieee80211_hw *hw)
        rtl_set_bbreg(hw, 0xe80, 0x0c000000, 0x2);
        rtl_set_bbreg(hw, 0xe88, 0x0c000000, 0x2);
 }
 bool rtl92c_phy_rf_config(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
@@ -241,13 +244,14 @@ bool _rtl92c_phy_bb8192c_config_parafile(struct ieee80211_hw *hw)
        rtlphy->cck_high_power = (bool) (rtl_get_bbreg(hw,
                                                RFPGA0_XA_HSSIPARAMETER2,
                                                0x200));
        return true;
 }
 EXPORT_SYMBOL(_rtl92c_phy_bb8192c_config_parafile);
 void _rtl92c_store_pwrIndex_diffrate_offset(struct ieee80211_hw *hw,
-                                                   u32 regaddr, u32 bitmask,
+                                            u32 regaddr, u32 bitmask,
-                                                   u32 data)
+                                            u32 data)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
@@ -317,61 +321,48 @@ void _rtl92c_store_pwrIndex_diffrate_offset(struct ieee80211_hw *hw,
        }
        if (regaddr == RTXAGC_B_RATE54_24) {
                rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][9] = data;
                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
                         ("MCSTxPowerLevelOriginalOffset[%d][9] = 0x%x\n",
                          rtlphy->pwrgroup_cnt,
                          rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][9]));
        }
        if (regaddr == RTXAGC_B_CCK1_55_MCS32) {
                rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][14] = data;
                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
                         ("MCSTxPowerLevelOriginalOffset[%d][14] = 0x%x\n",
                          rtlphy->pwrgroup_cnt,
                          rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][14]));
        }
        if (regaddr == RTXAGC_B_CCK11_A_CCK2_11 && bitmask == 0x000000ff) {
                rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][15] = data;
                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
                         ("MCSTxPowerLevelOriginalOffset[%d][15] = 0x%x\n",
                          rtlphy->pwrgroup_cnt,
                          rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][15]));
        }
        if (regaddr == RTXAGC_B_MCS03_MCS00) {
                rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][10] = data;
                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
                         ("MCSTxPowerLevelOriginalOffset[%d][10] = 0x%x\n",
                          rtlphy->pwrgroup_cnt,
                          rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][10]));
        }
        if (regaddr == RTXAGC_B_MCS07_MCS04) {
                rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][11] = data;
                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
                         ("MCSTxPowerLevelOriginalOffset[%d][11] = 0x%x\n",
                          rtlphy->pwrgroup_cnt,
                          rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][11]));
        }
        if (regaddr == RTXAGC_B_MCS11_MCS08) {
                rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][12] = data;
                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
                         ("MCSTxPowerLevelOriginalOffset[%d][12] = 0x%x\n",
                          rtlphy->pwrgroup_cnt,
                          rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][12]));
        }
        if (regaddr == RTXAGC_B_MCS15_MCS12) {
                rtlphy->MCS_TXPWR[rtlphy->pwrgroup_cnt][13] = data;
                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
                         ("MCSTxPowerLevelOriginalOffset[%d][13] = 0x%x\n",
                          rtlphy->pwrgroup_cnt,
@@ -583,6 +574,7 @@ static void _rtl92c_ccxpower_index_check(struct ieee80211_hw *hw,
        rtlphy->cur_cck_txpwridx = cckpowerlevel[0];
        rtlphy->cur_ofdm24g_txpwridx = ofdmpowerlevel[0];
 }
 void rtl92c_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel)
@@ -611,7 +603,6 @@ bool rtl92c_phy_update_txpower_dbm(struct ieee80211_hw *hw, long power_indbm)
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
        u8 idx;
        u8 rf_path;
        u8 ccktxpwridx = _rtl92c_phy_dbm_to_txpwr_Idx(hw,
                                                      WIRELESS_MODE_B,
                                                      power_indbm);
@@ -639,11 +630,6 @@ bool rtl92c_phy_update_txpower_dbm(struct ieee80211_hw *hw, long power_indbm)
 }
 EXPORT_SYMBOL(rtl92c_phy_update_txpower_dbm);
-void rtl92c_phy_set_beacon_hw_reg(struct ieee80211_hw *hw, u16 beaconinterval)
-{
-}
-EXPORT_SYMBOL(rtl92c_phy_set_beacon_hw_reg);
 u8 _rtl92c_phy_dbm_to_txpwr_Idx(struct ieee80211_hw *hw,
                                enum wireless_mode wirelessmode,
                                long power_indbm)
@@ -741,9 +727,9 @@ void rtl92c_phy_set_bw_mode(struct ieee80211_hw *hw,
        if (rtlphy->set_bwmode_inprogress)
                return;
        rtlphy->set_bwmode_inprogress = true;
-        if ((!is_hal_stop(rtlhal)) && !(RT_CANNOT_IO(hw)))
+        if ((!is_hal_stop(rtlhal)) && !(RT_CANNOT_IO(hw))) {
-                rtlpriv->cfg->ops->phy_set_bw_mode_callback(hw);
+                rtlphy->set_bwmode_inprogress = false;
-        else {
+        } else {
                RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
                         ("FALSE driver sleep or unload\n"));
                rtlphy->set_bwmode_inprogress = false;
@@ -773,8 +759,9 @@ void rtl92c_phy_sw_chnl_callback(struct ieee80211_hw *hw)
                                mdelay(delay);
                        else
                                continue;
-                } else
+                } else {
                        rtlphy->sw_chnl_inprogress = false;
+                }
                break;
        } while (true);
        RT_TRACE(rtlpriv, COMP_SCAN, DBG_TRACE, ("<==\n"));
@@ -811,9 +798,32 @@ u8 rtl92c_phy_sw_chnl(struct ieee80211_hw *hw)
 }
 EXPORT_SYMBOL(rtl92c_phy_sw_chnl);
-static bool _rtl92c_phy_sw_chnl_step_by_step(struct ieee80211_hw *hw,
+static bool _rtl92c_phy_set_sw_chnl_cmdarray(struct swchnlcmd *cmdtable,
-                                             u8 channel, u8 *stage, u8 *step,
+                                             u32 cmdtableidx, u32 cmdtablesz,
-                                             u32 *delay)
+                                             enum swchnlcmd_id cmdid,
+                                             u32 para1, u32 para2, u32 msdelay)
+{
+        struct swchnlcmd *pcmd;
+        if (cmdtable == NULL) {
+                RT_ASSERT(false, ("cmdtable cannot be NULL.\n"));
+                return false;
+        }
+        if (cmdtableidx >= cmdtablesz)
+                return false;
+        pcmd = cmdtable + cmdtableidx;
+        pcmd->cmdid = cmdid;
+        pcmd->para1 = para1;
+        pcmd->para2 = para2;
+        pcmd->msdelay = msdelay;
+        return true;
+}
+bool _rtl92c_phy_sw_chnl_step_by_step(struct ieee80211_hw *hw,
+                                      u8 channel, u8 *stage, u8 *step,
+                                      u32 *delay)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
@@ -917,29 +927,6 @@ static bool _rtl92c_phy_sw_chnl_step_by_step(struct ieee80211_hw *hw,
        return false;
 }
-static bool _rtl92c_phy_set_sw_chnl_cmdarray(struct swchnlcmd *cmdtable,
-                                             u32 cmdtableidx, u32 cmdtablesz,
-                                             enum swchnlcmd_id cmdid,
-                                             u32 para1, u32 para2, u32 msdelay)
-{
-        struct swchnlcmd *pcmd;
-        if (cmdtable == NULL) {
-                RT_ASSERT(false, ("cmdtable cannot be NULL.\n"));
-                return false;
-        }
-        if (cmdtableidx >= cmdtablesz)
-                return false;
-        pcmd = cmdtable + cmdtableidx;
-        pcmd->cmdid = cmdid;
-        pcmd->para1 = para1;
-        pcmd->para2 = para2;
-        pcmd->msdelay = msdelay;
-        return true;
-}
 bool rtl8192_phy_check_is_legal_rfpath(struct ieee80211_hw *hw, u32 rfpath)
 {
        return true;
@@ -1002,13 +989,13 @@ static u8 _rtl92c_phy_path_b_iqk(struct ieee80211_hw *hw)
        reg_ebc = rtl_get_bbreg(hw, 0xebc, MASKDWORD);
        reg_ec4 = rtl_get_bbreg(hw, 0xec4, MASKDWORD);
        reg_ecc = rtl_get_bbreg(hw, 0xecc, MASKDWORD);
        if (!(reg_eac & BIT(31)) &&
            (((reg_eb4 & 0x03FF0000) >> 16) != 0x142) &&
            (((reg_ebc & 0x03FF0000) >> 16) != 0x42))
                result |= 0x01;
        else
                return result;
        if (!(reg_eac & BIT(30)) &&
            (((reg_ec4 & 0x03FF0000) >> 16) != 0x132) &&
            (((reg_ecc & 0x03FF0000) >> 16) != 0x36))
@@ -1023,9 +1010,9 @@ static void _rtl92c_phy_path_a_fill_iqk_matrix(struct ieee80211_hw *hw,
        u32 oldval_0, x, tx0_a, reg;
        long y, tx0_c;
-        if (final_candidate == 0xFF)
+        if (final_candidate == 0xFF) {
                return;
-        else if (iqk_ok) {
+        } else if (iqk_ok) {
                oldval_0 = (rtl_get_bbreg(hw, ROFDM0_XATXIQIMBALANCE,
                                          MASKDWORD) >> 22) & 0x3FF;
                x = result[final_candidate][0];
@@ -1063,9 +1050,9 @@ static void _rtl92c_phy_path_b_fill_iqk_matrix(struct ieee80211_hw *hw,
        u32 oldval_1, x, tx1_a, reg;
        long y, tx1_c;
-        if (final_candidate == 0xFF)
+        if (final_candidate == 0xFF) {
                return;
-        else if (iqk_ok) {
+        } else if (iqk_ok) {
                oldval_1 = (rtl_get_bbreg(hw, ROFDM0_XBTXIQIMBALANCE,
                                          MASKDWORD) >> 22) & 0x3FF;
                x = result[final_candidate][4];
@@ -1282,6 +1269,7 @@ static void _rtl92c_phy_iq_calibrate(struct ieee80211_hw *hw,
                                                   RFPGA0_XA_HSSIPARAMETER1,
                                                   BIT(8));
        }
        if (!rtlphy->rfpi_enable)
                _rtl92c_phy_pi_mode_switch(hw, true);
        if (t == 0) {
@@ -1317,9 +1305,10 @@ static void _rtl92c_phy_iq_calibrate(struct ieee80211_hw *hw,
                                        0x3FF0000) >> 16;
                        break;
                } else if (i == (retrycount - 1) && patha_ok == 0x01)
                        result[t][0] = (rtl_get_bbreg(hw, 0xe94,
                                                      MASKDWORD) & 0x3FF0000) >>
-                                                      16;
+                            16;
                result[t][1] =
                    (rtl_get_bbreg(hw, 0xe9c, MASKDWORD) & 0x3FF0000) >> 16;
@@ -1375,8 +1364,7 @@ static void _rtl92c_phy_iq_calibrate(struct ieee80211_hw *hw,
 static void _rtl92c_phy_ap_calibrate(struct ieee80211_hw *hw,
                                     char delta, bool is2t)
 {
-        /* This routine is deliberately dummied out for later fixes */
+#if 0 /* This routine is deliberately dummied out for later fixes */
-#if 0
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
@@ -1434,7 +1422,7 @@ static void _rtl92c_phy_ap_calibrate(struct ieee80211_hw *hw,
                0x04db25a4, 0x0b1b25a4
        };
-        u32 apk_offset[PATH_NUM] = { 0xb68, 0xb6c };
+        const u32 apk_offset[PATH_NUM] = { 0xb68, 0xb6c };
        u32 apk_normal_offset[PATH_NUM] = { 0xb28, 0xb98 };
@@ -1463,13 +1451,15 @@ static void _rtl92c_phy_ap_calibrate(struct ieee80211_hw *hw,
                0x00050006
        };
-        const u32 apk_result[PATH_NUM][APK_BB_REG_NUM];
+        u32 apk_result[PATH_NUM][APK_BB_REG_NUM];
        long bb_offset, delta_v, delta_offset;
        if (!is2t)
                pathbound = 1;
+        return;
        for (index = 0; index < PATH_NUM; index++) {
                apk_offset[index] = apk_normal_offset[index];
                apk_value[index] = apk_normal_value[index];
@@ -1730,8 +1720,7 @@ static void _rtl92c_phy_ap_calibrate(struct ieee80211_hw *hw,
                               0x08));
        }
+        rtlphy->b_apk_done = true;
-        rtlphy->apk_done = true;
 #endif
 }
@@ -1758,6 +1747,7 @@ static void _rtl92c_phy_set_rfpath_switch(struct ieee80211_hw *hw,
                        rtl_set_bbreg(hw, RFPGA0_XA_RFINTERFACEOE, 0x300, 0x1);
        }
 }
 #undef IQK_ADDA_REG_NUM
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.h b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.h
index 53ffb0981586..9a264c0d6127 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.h
@@ -27,8 +27,8 @@
 *
 *****************************************************************************/
-#ifndef __RTL92C_PHY_H__
+#ifndef __RTL92C_PHY_COMMON_H__
-#define __RTL92C_PHY_H__
+#define __RTL92C_PHY_COMMON_H__
 #define MAX_PRECMD_CNT                  16
 #define MAX_RFDEPENDCMD_CNT             16
@@ -39,6 +39,7 @@
 #define RT_CANNOT_IO(hw)                false
 #define HIGHPOWER_RADIOA_ARRAYLEN       22
+#define IQK_ADDA_REG_NUM                16
 #define MAX_TOLERANCE                   5
 #define IQK_DELAY_TIME                  1
@@ -56,6 +57,7 @@
 #define IQK_ADDA_REG_NUM                16
 #define IQK_MAC_REG_NUM                 4
+#define IQK_DELAY_TIME                  1
 #define RF90_PATH_MAX                   2
 #define CT_OFFSET_MAC_ADDR              0X16
@@ -77,6 +79,7 @@
 #define RTL92C_MAX_PATH_NUM             2
 #define LLT_LAST_ENTRY_OF_TX_PKT_BUFFER 255
 enum swchnlcmd_id {
        CMDID_END,
        CMDID_SET_TXPOWEROWER_LEVEL,
@@ -184,45 +187,41 @@ struct tx_power_struct {
        u32 mcs_original_offset[4][16];
 };
-extern u32 rtl92c_phy_query_bb_reg(struct ieee80211_hw *hw,
+u32 rtl92c_phy_query_bb_reg(struct ieee80211_hw *hw,
                                   u32 regaddr, u32 bitmask);
-extern void rtl92c_phy_set_bb_reg(struct ieee80211_hw *hw,
+void rtl92c_phy_set_bb_reg(struct ieee80211_hw *hw,
                                  u32 regaddr, u32 bitmask, u32 data);
-extern u32 rtl92c_phy_query_rf_reg(struct ieee80211_hw *hw,
+u32 rtl92c_phy_query_rf_reg(struct ieee80211_hw *hw,
                                   enum radio_path rfpath, u32 regaddr,
                                   u32 bitmask);
-extern void rtl92c_phy_set_rf_reg(struct ieee80211_hw *hw,
+bool rtl92c_phy_mac_config(struct ieee80211_hw *hw);
-                                  enum radio_path rfpath, u32 regaddr,
+bool rtl92c_phy_bb_config(struct ieee80211_hw *hw);
-                                  u32 bitmask, u32 data);
+bool rtl92c_phy_rf_config(struct ieee80211_hw *hw);
-extern bool rtl92c_phy_mac_config(struct ieee80211_hw *hw);
+bool rtl92c_phy_config_rf_with_feaderfile(struct ieee80211_hw *hw,
-extern bool rtl92c_phy_bb_config(struct ieee80211_hw *hw);
-extern bool rtl92c_phy_rf_config(struct ieee80211_hw *hw);
-extern bool rtl92c_phy_config_rf_with_feaderfile(struct ieee80211_hw *hw,
                                                 enum radio_path rfpath);
-extern void rtl92c_phy_get_hw_reg_originalvalue(struct ieee80211_hw *hw);
+void rtl92c_phy_get_hw_reg_originalvalue(struct ieee80211_hw *hw);
-extern void rtl92c_phy_get_txpower_level(struct ieee80211_hw *hw,
+void rtl92c_phy_get_txpower_level(struct ieee80211_hw *hw,
                                         long *powerlevel);
-extern void rtl92c_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel);
+void rtl92c_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel);
-extern bool rtl92c_phy_update_txpower_dbm(struct ieee80211_hw *hw,
+bool rtl92c_phy_update_txpower_dbm(struct ieee80211_hw *hw,
                                          long power_indbm);
-extern void rtl92c_phy_scan_operation_backup(struct ieee80211_hw *hw,
+void rtl92c_phy_scan_operation_backup(struct ieee80211_hw *hw,
                                             u8 operation);
-extern void rtl92c_phy_set_bw_mode_callback(struct ieee80211_hw *hw);
+void rtl92c_phy_set_bw_mode(struct ieee80211_hw *hw,
-extern void rtl92c_phy_set_bw_mode(struct ieee80211_hw *hw,
                                   enum nl80211_channel_type ch_type);
-extern void rtl92c_phy_sw_chnl_callback(struct ieee80211_hw *hw);
+void rtl92c_phy_sw_chnl_callback(struct ieee80211_hw *hw);
-extern u8 rtl92c_phy_sw_chnl(struct ieee80211_hw *hw);
+u8 rtl92c_phy_sw_chnl(struct ieee80211_hw *hw);
-extern void rtl92c_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery);
+void rtl92c_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery);
-extern void rtl92c_phy_set_beacon_hw_reg(struct ieee80211_hw *hw,
+void rtl92c_phy_set_beacon_hw_reg(struct ieee80211_hw *hw,
                                         u16 beaconinterval);
 void rtl92c_phy_ap_calibrate(struct ieee80211_hw *hw, char delta);
 void rtl92c_phy_lc_calibrate(struct ieee80211_hw *hw);
 void rtl92c_phy_set_rfpath_switch(struct ieee80211_hw *hw, bool bmain);
 bool rtl92c_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
                                          enum radio_path rfpath);
-extern bool rtl8192_phy_check_is_legal_rfpath(struct ieee80211_hw *hw,
+bool rtl8192_phy_check_is_legal_rfpath(struct ieee80211_hw *hw,
                                              u32 rfpath);
-extern bool rtl92c_phy_set_rf_power_state(struct ieee80211_hw *hw,
+bool rtl92c_phy_set_rf_power_state(struct ieee80211_hw *hw,
                                          enum rf_pwrstate rfpwr_state);
 void rtl92ce_phy_set_rf_on(struct ieee80211_hw *hw);
 void rtl92c_phy_set_io(struct ieee80211_hw *hw);
@@ -235,12 +234,25 @@ u8 _rtl92c_phy_dbm_to_txpwr_Idx(struct ieee80211_hw *hw,
                                enum wireless_mode wirelessmode,
                                long power_indbm);
 void _rtl92c_phy_init_bb_rf_register_definition(struct ieee80211_hw *hw);
-static bool _rtl92c_phy_set_sw_chnl_cmdarray(struct swchnlcmd *cmdtable,
+void _rtl92c_phy_set_rf_sleep(struct ieee80211_hw *hw);
-                                             u32 cmdtableidx, u32 cmdtablesz,
+bool _rtl92c_phy_sw_chnl_step_by_step(struct ieee80211_hw *hw,
-                                             enum swchnlcmd_id cmdid, u32 para1,
+                                      u8 channel, u8 *stage, u8 *step,
-                                             u32 para2, u32 msdelay);
+                                      u32 *delay);
-static bool _rtl92c_phy_sw_chnl_step_by_step(struct ieee80211_hw *hw,
+u8 rtl92c_bt_rssi_state_change(struct ieee80211_hw *hw);
-                                             u8 channel, u8 *stage, u8 *step,
+u32 _rtl92c_phy_fw_rf_serial_read(struct ieee80211_hw *hw,
-                                             u32 *delay);
+                                  enum radio_path rfpath, u32 offset);
+void _rtl92c_phy_fw_rf_serial_write(struct ieee80211_hw *hw,
+                                    enum radio_path rfpath, u32 offset,
+                                    u32 data);
+u32 _rtl92c_phy_rf_serial_read(struct ieee80211_hw *hw,
+                               enum radio_path rfpath, u32 offset);
+void _rtl92c_phy_rf_serial_write(struct ieee80211_hw *hw,
+                                 enum radio_path rfpath, u32 offset,
+                                 u32 data);
+bool _rtl92c_phy_bb8192c_config_parafile(struct ieee80211_hw *hw);
+void _rtl92c_store_pwrIndex_diffrate_offset(struct ieee80211_hw *hw,
+                                            u32 regaddr, u32 bitmask,
+                                            u32 data);
+bool rtl92c_phy_set_io_cmd(struct ieee80211_hw *hw, enum io_type iotype);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/def.h b/drivers/net/wireless/rtlwifi/rtl8192ce/def.h
index 2f577c8828fc..35ff7df41a1d 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/def.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/def.h
@@ -121,19 +121,6 @@
 #define CHIP_92C                        0x01
 #define CHIP_88C                        0x00
-/* Add vendor information into chip version definition.
- * Add UMC B-Cut and RTL8723 chip info definition.
- *
- * BIT 7        Reserved
- * BIT 6        UMC BCut
- * BIT 5        Manufacturer(TSMC/UMC)
- * BIT 4        TEST/NORMAL
- * BIT 3        8723 Version
- * BIT 2        8723?
- * BIT 1        1T2R?
- * BIT 0        88C/92C
-*/
 enum version_8192c {
        VERSION_A_CHIP_92C = 0x01,
        VERSION_A_CHIP_88C = 0x00,
@@ -280,20 +267,6 @@ struct h2c_cmd_8192c {
        u8 *p_cmdbuffer;
 };
-static inline u8 _rtl92c_get_chnl_group(u8 chnl)
-{
-        u8 group = 0;
-        if (chnl < 3)
-                group = 0;
-        else if (chnl < 9)
-                group = 1;
-        else
-                group = 2;
-        return group;
-}
 /* NOTE: reference to rtl8192c_rates struct */
 static inline int _rtl92c_rate_mapping(struct ieee80211_hw *hw, bool isHT,
                                       u8 desc_rate, bool first_ampdu)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/dm.c b/drivers/net/wireless/rtlwifi/rtl8192ce/dm.c
index 7d76504df4d1..2df33e53e15a 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/dm.c
@@ -29,10 +29,12 @@
 #include "../wifi.h"
 #include "../base.h"
+#include "../pci.h"
 #include "reg.h"
 #include "def.h"
 #include "phy.h"
 #include "dm.h"
+#include "../rtl8192c/fw_common.h"
 void rtl92ce_dm_dynamic_txpower(struct ieee80211_hw *hw)
 {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/dm.h b/drivers/net/wireless/rtlwifi/rtl8192ce/dm.h
index 36302ebae4a3..07dd9552e82f 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/dm.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/dm.h
@@ -192,6 +192,7 @@ void rtl92c_dm_init_edca_turbo(struct ieee80211_hw *hw);
 void rtl92c_dm_check_txpower_tracking(struct ieee80211_hw *hw);
 void rtl92c_dm_init_rate_adaptive_mask(struct ieee80211_hw *hw);
 void rtl92c_dm_rf_saving(struct ieee80211_hw *hw, u8 bforce_in_normal);
+void rtl92c_dm_bt_coexist(struct ieee80211_hw *hw);
 void rtl92ce_dm_dynamic_txpower(struct ieee80211_hw *hw);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c b/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
index 05477f465a75..4a56138eb33c 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
@@ -30,12 +30,14 @@
 #include "../wifi.h"
 #include "../efuse.h"
 #include "../base.h"
+#include "../regd.h"
 #include "../cam.h"
 #include "../ps.h"
 #include "../pci.h"
 #include "reg.h"
 #include "def.h"
 #include "phy.h"
+#include "../rtl8192c/fw_common.h"
 #include "dm.h"
 #include "led.h"
 #include "hw.h"
@@ -137,15 +139,6 @@ void rtl92ce_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
                break;
                }
-        case HW_VAR_MGT_FILTER:
-                *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP0);
-                break;
-        case HW_VAR_CTRL_FILTER:
-                *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP1);
-                break;
-        case HW_VAR_DATA_FILTER:
-                *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
-                break;
        default:
                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
                         ("switch case not process\n"));
@@ -156,6 +149,7 @@ void rtl92ce_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
 void rtl92ce_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
@@ -178,7 +172,7 @@ void rtl92ce_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
                        rate_cfg |= 0x01;
                        rtl_write_byte(rtlpriv, REG_RRSR, rate_cfg & 0xff);
                        rtl_write_byte(rtlpriv, REG_RRSR + 1,
-                                       (rate_cfg >> 8)&0xff);
+                                       (rate_cfg >> 8) & 0xff);
                        while (rate_cfg > 0x1) {
                                rate_cfg = (rate_cfg >> 1);
                                rate_index++;
@@ -276,13 +270,19 @@ void rtl92ce_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
                        break;
                }
        case HW_VAR_AMPDU_FACTOR:{
-                        u8 regtoset_normal[4] = { 0x41, 0xa8, 0x72, 0xb9 };
+                        u8 regtoset_normal[4] = {0x41, 0xa8, 0x72, 0xb9};
+                        u8 regtoset_bt[4] = {0x31, 0x74, 0x42, 0x97};
                        u8 factor_toset;
                        u8 *p_regtoset = NULL;
                        u8 index = 0;
-                        p_regtoset = regtoset_normal;
+                        if ((rtlpcipriv->bt_coexist.bt_coexistence) &&
+                            (rtlpcipriv->bt_coexist.bt_coexist_type ==
+                            BT_CSR_BC4))
+                                p_regtoset = regtoset_bt;
+                        else
+                                p_regtoset = regtoset_normal;
                        factor_toset = *((u8 *) val);
                        if (factor_toset <= 3) {
@@ -317,45 +317,7 @@ void rtl92ce_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
                }
        case HW_VAR_AC_PARAM:{
                        u8 e_aci = *((u8 *) val);
-                        u32 u4b_ac_param;
+                        rtl92c_dm_init_edca_turbo(hw);
-                        u16 cw_min = le16_to_cpu(mac->ac[e_aci].cw_min);
-                        u16 cw_max = le16_to_cpu(mac->ac[e_aci].cw_max);
-                        u16 tx_op = le16_to_cpu(mac->ac[e_aci].tx_op);
-                        u4b_ac_param = (u32) mac->ac[e_aci].aifs;
-                        u4b_ac_param |= ((u32)cw_min
-                                         & 0xF) << AC_PARAM_ECW_MIN_OFFSET;
-                        u4b_ac_param |= ((u32)cw_max &
-                                         0xF) << AC_PARAM_ECW_MAX_OFFSET;
-                        u4b_ac_param |= (u32)tx_op << AC_PARAM_TXOP_OFFSET;
-                        RT_TRACE(rtlpriv, COMP_MLME, DBG_LOUD,
-                                 ("queue:%x, ac_param:%x\n", e_aci,
-                                  u4b_ac_param));
-                        switch (e_aci) {
-                        case AC1_BK:
-                                rtl_write_dword(rtlpriv, REG_EDCA_BK_PARAM,
-                                                u4b_ac_param);
-                                break;
-                        case AC0_BE:
-                                rtl_write_dword(rtlpriv, REG_EDCA_BE_PARAM,
-                                                u4b_ac_param);
-                                break;
-                        case AC2_VI:
-                                rtl_write_dword(rtlpriv, REG_EDCA_VI_PARAM,
-                                                u4b_ac_param);
-                                break;
-                        case AC3_VO:
-                                rtl_write_dword(rtlpriv, REG_EDCA_VO_PARAM,
-                                                u4b_ac_param);
-                                break;
-                        default:
-                                RT_ASSERT(false,
-                                  ("SetHwReg8185(): invalid aci: %d !\n",
-                                   e_aci));
-                                break;
-                        }
                        if (rtlpci->acm_method != eAcmWay2_SW)
                                rtlpriv->cfg->ops->set_hw_reg(hw,
@@ -526,9 +488,6 @@ void rtl92ce_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
        case HW_VAR_CORRECT_TSF:{
                        u8 btype_ibss = ((u8 *) (val))[0];
-                        /*btype_ibss = (mac->opmode == NL80211_IFTYPE_ADHOC) ?
-                                        1 : 0;*/
                        if (btype_ibss == true)
                                _rtl92ce_stop_tx_beacon(hw);
@@ -537,7 +496,7 @@ void rtl92ce_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
                        rtl_write_dword(rtlpriv, REG_TSFTR,
                                        (u32) (mac->tsf & 0xffffffff));
                        rtl_write_dword(rtlpriv, REG_TSFTR + 4,
-                                        (u32) ((mac->tsf >> 32)&0xffffffff));
+                                        (u32) ((mac->tsf >> 32) & 0xffffffff));
                        _rtl92ce_set_bcn_ctrl_reg(hw, BIT(3), 0);
@@ -547,15 +506,6 @@ void rtl92ce_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
                        break;
                }
-        case HW_VAR_MGT_FILTER:
-                rtl_write_word(rtlpriv, REG_RXFLTMAP0, *(u16 *) val);
-                break;
-        case HW_VAR_CTRL_FILTER:
-                rtl_write_word(rtlpriv, REG_RXFLTMAP1, *(u16 *) val);
-                break;
-        case HW_VAR_DATA_FILTER:
-                rtl_write_word(rtlpriv, REG_RXFLTMAP2, *(u16 *) val);
-                break;
        default:
                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, ("switch case "
                                                        "not process\n"));
@@ -679,12 +629,12 @@ static void _rtl92ce_gen_refresh_led_state(struct ieee80211_hw *hw)
                rtl92ce_sw_led_on(hw, pLed0);
        else
                rtl92ce_sw_led_off(hw, pLed0);
 }
 static bool _rtl92ce_init_mac(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
@@ -693,9 +643,22 @@ static bool _rtl92ce_init_mac(struct ieee80211_hw *hw)
        u16 retry;
        rtl_write_byte(rtlpriv, REG_RSV_CTRL, 0x00);
+        if (rtlpcipriv->bt_coexist.bt_coexistence) {
+                u32 value32;
+                value32 = rtl_read_dword(rtlpriv, REG_APS_FSMCO);
+                value32 |= (SOP_ABG | SOP_AMB | XOP_BTCK);
+                rtl_write_dword(rtlpriv, REG_APS_FSMCO, value32);
+        }
        rtl_write_byte(rtlpriv, REG_SPS0_CTRL, 0x2b);
        rtl_write_byte(rtlpriv, REG_AFE_XTAL_CTRL, 0x0F);
+        if (rtlpcipriv->bt_coexist.bt_coexistence) {
+                u32 u4b_tmp = rtl_read_dword(rtlpriv, REG_AFE_XTAL_CTRL);
+                u4b_tmp &= (~0x00024800);
+                rtl_write_dword(rtlpriv, REG_AFE_XTAL_CTRL, u4b_tmp);
+        }
        bytetmp = rtl_read_byte(rtlpriv, REG_APS_FSMCO + 1) | BIT(0);
        udelay(2);
@@ -726,6 +689,11 @@ static bool _rtl92ce_init_mac(struct ieee80211_hw *hw)
        rtl_write_byte(rtlpriv, REG_SYS_ISO_CTRL + 1, 0x82);
        udelay(2);
+        if (rtlpcipriv->bt_coexist.bt_coexistence) {
+                bytetmp = rtl_read_byte(rtlpriv, REG_AFE_XTAL_CTRL+2) & 0xfd;
+                rtl_write_byte(rtlpriv, REG_AFE_XTAL_CTRL+2, bytetmp);
+        }
        rtl_write_word(rtlpriv, REG_CR, 0x2ff);
        if (_rtl92ce_llt_table_init(hw) == false)
@@ -793,6 +761,7 @@ static void _rtl92ce_hw_configure(struct ieee80211_hw *hw)
 {
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
        u8 reg_bw_opmode;
        u32 reg_ratr, reg_prsr;
@@ -824,7 +793,11 @@ static void _rtl92ce_hw_configure(struct ieee80211_hw *hw)
        rtl_write_dword(rtlpriv, REG_RARFRC, 0x01000000);
        rtl_write_dword(rtlpriv, REG_RARFRC + 4, 0x07060504);
-        rtl_write_dword(rtlpriv, REG_AGGLEN_LMT, 0xb972a841);
+        if ((rtlpcipriv->bt_coexist.bt_coexistence) &&
+            (rtlpcipriv->bt_coexist.bt_coexist_type == BT_CSR_BC4))
+                rtl_write_dword(rtlpriv, REG_AGGLEN_LMT, 0x97427431);
+        else
+                rtl_write_dword(rtlpriv, REG_AGGLEN_LMT, 0xb972a841);
        rtl_write_byte(rtlpriv, REG_ATIMWND, 0x2);
@@ -840,11 +813,20 @@ static void _rtl92ce_hw_configure(struct ieee80211_hw *hw)
        rtl_write_byte(rtlpriv, REG_PIFS, 0x1C);
        rtl_write_byte(rtlpriv, REG_AGGR_BREAK_TIME, 0x16);
-        rtl_write_word(rtlpriv, REG_NAV_PROT_LEN, 0x0020);
+        if ((rtlpcipriv->bt_coexist.bt_coexistence) &&
+            (rtlpcipriv->bt_coexist.bt_coexist_type == BT_CSR_BC4)) {
-        rtl_write_word(rtlpriv, REG_NAV_PROT_LEN, 0x0020);
+                rtl_write_word(rtlpriv, REG_NAV_PROT_LEN, 0x0020);
+                rtl_write_word(rtlpriv, REG_PROT_MODE_CTRL, 0x0402);
+        } else {
+                rtl_write_word(rtlpriv, REG_NAV_PROT_LEN, 0x0020);
+                rtl_write_word(rtlpriv, REG_NAV_PROT_LEN, 0x0020);
+        }
-        rtl_write_dword(rtlpriv, REG_FAST_EDCA_CTRL, 0x086666);
+        if ((rtlpcipriv->bt_coexist.bt_coexistence) &&
+             (rtlpcipriv->bt_coexist.bt_coexist_type == BT_CSR_BC4))
+                rtl_write_dword(rtlpriv, REG_FAST_EDCA_CTRL, 0x03086666);
+        else
+                rtl_write_dword(rtlpriv, REG_FAST_EDCA_CTRL, 0x086666);
        rtl_write_byte(rtlpriv, REG_ACKTO, 0x40);
@@ -948,8 +930,8 @@ int rtl92ce_hw_init(struct ieee80211_hw *hw)
        }
        rtlhal->last_hmeboxnum = 0;
-        rtl92ce_phy_mac_config(hw);
+        rtl92c_phy_mac_config(hw);
-        rtl92ce_phy_bb_config(hw);
+        rtl92c_phy_bb_config(hw);
        rtlphy->rf_mode = RF_OP_BY_SW_3WIRE;
        rtl92c_phy_rf_config(hw);
        rtlphy->rfreg_chnlval[0] = rtl_get_rfreg(hw, (enum radio_path)0,
@@ -962,15 +944,20 @@ int rtl92ce_hw_init(struct ieee80211_hw *hw)
        _rtl92ce_hw_configure(hw);
        rtl_cam_reset_all_entry(hw);
        rtl92ce_enable_hw_security_config(hw);
        ppsc->rfpwr_state = ERFON;
        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_ETHER_ADDR, mac->mac_addr);
        _rtl92ce_enable_aspm_back_door(hw);
        rtlpriv->intf_ops->enable_aspm(hw);
+        rtl8192ce_bt_hw_init(hw);
        if (ppsc->rfpwr_state == ERFON) {
                rtl92c_phy_set_rfpath_switch(hw, 1);
-                if (iqk_initialized)
+                if (iqk_initialized) {
                        rtl92c_phy_iq_calibrate(hw, true);
-                else {
+                } else {
                        rtl92c_phy_iq_calibrate(hw, false);
                        iqk_initialized = true;
                }
@@ -1128,75 +1115,62 @@ static int _rtl92ce_set_media_status(struct ieee80211_hw *hw,
        return 0;
 }
-static void _rtl92ce_set_check_bssid(struct ieee80211_hw *hw,
+void rtl92ce_set_check_bssid(struct ieee80211_hw *hw, bool check_bssid)
-                                     enum nl80211_iftype type)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        u32 reg_rcr = rtl_read_dword(rtlpriv, REG_RCR);
-        u8 filterout_non_associated_bssid = false;
-        switch (type) {
+        if (rtlpriv->psc.rfpwr_state != ERFON)
-        case NL80211_IFTYPE_ADHOC:
+                return;
-        case NL80211_IFTYPE_STATION:
-                filterout_non_associated_bssid = true;
-                break;
-        case NL80211_IFTYPE_UNSPECIFIED:
-        case NL80211_IFTYPE_AP:
-        default:
-                break;
-        }
-        if (filterout_non_associated_bssid == true) {
+        if (check_bssid == true) {
                reg_rcr |= (RCR_CBSSID_DATA | RCR_CBSSID_BCN);
                rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_RCR,
                                              (u8 *) (&reg_rcr));
                _rtl92ce_set_bcn_ctrl_reg(hw, 0, BIT(4));
-        } else if (filterout_non_associated_bssid == false) {
+        } else if (check_bssid == false) {
                reg_rcr &= (~(RCR_CBSSID_DATA | RCR_CBSSID_BCN));
                _rtl92ce_set_bcn_ctrl_reg(hw, BIT(4), 0);
                rtlpriv->cfg->ops->set_hw_reg(hw,
                                              HW_VAR_RCR, (u8 *) (&reg_rcr));
        }
 }
 int rtl92ce_set_network_type(struct ieee80211_hw *hw, enum nl80211_iftype type)
 {
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
        if (_rtl92ce_set_media_status(hw, type))
                return -EOPNOTSUPP;
-        _rtl92ce_set_check_bssid(hw, type);
+        if (rtlpriv->mac80211.link_state == MAC80211_LINKED) {
+                if (type != NL80211_IFTYPE_AP)
+                        rtl92ce_set_check_bssid(hw, true);
+        } else {
+                rtl92ce_set_check_bssid(hw, false);
+        }
        return 0;
 }
+/* don't set REG_EDCA_BE_PARAM here because mac80211 will send pkt when scan */
 void rtl92ce_set_qos(struct ieee80211_hw *hw, int aci)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
-        u32 u4b_ac_param;
-        u16 cw_min = le16_to_cpu(mac->ac[aci].cw_min);
-        u16 cw_max = le16_to_cpu(mac->ac[aci].cw_max);
-        u16 tx_op = le16_to_cpu(mac->ac[aci].tx_op);
        rtl92c_dm_init_edca_turbo(hw);
-        u4b_ac_param = (u32) mac->ac[aci].aifs;
-        u4b_ac_param |= (u32) ((cw_min & 0xF) << AC_PARAM_ECW_MIN_OFFSET);
-        u4b_ac_param |= (u32) ((cw_max & 0xF) << AC_PARAM_ECW_MAX_OFFSET);
-        u4b_ac_param |= (u32) (tx_op << AC_PARAM_TXOP_OFFSET);
-        RT_TRACE(rtlpriv, COMP_QOS, DBG_DMESG,
-                 ("queue:%x, ac_param:%x aifs:%x cwmin:%x cwmax:%x txop:%x\n",
-                  aci, u4b_ac_param, mac->ac[aci].aifs, cw_min,
-                  cw_max, tx_op));
        switch (aci) {
        case AC1_BK:
-                rtl_write_dword(rtlpriv, REG_EDCA_BK_PARAM, u4b_ac_param);
+                rtl_write_dword(rtlpriv, REG_EDCA_BK_PARAM, 0xa44f);
                break;
        case AC0_BE:
-                rtl_write_dword(rtlpriv, REG_EDCA_BE_PARAM, u4b_ac_param);
+                /* rtl_write_dword(rtlpriv, REG_EDCA_BE_PARAM, u4b_ac_param); */
                break;
        case AC2_VI:
-                rtl_write_dword(rtlpriv, REG_EDCA_VI_PARAM, u4b_ac_param);
+                rtl_write_dword(rtlpriv, REG_EDCA_VI_PARAM, 0x5e4322);
                break;
        case AC3_VO:
-                rtl_write_dword(rtlpriv, REG_EDCA_VO_PARAM, u4b_ac_param);
+                rtl_write_dword(rtlpriv, REG_EDCA_VO_PARAM, 0x2f3222);
                break;
        default:
                RT_ASSERT(false, ("invalid aci: %d !\n", aci));
@@ -1227,8 +1201,10 @@ void rtl92ce_disable_interrupt(struct ieee80211_hw *hw)
 static void _rtl92ce_poweroff_adapter(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
        u8 u1b_tmp;
+        u32 u4b_tmp;
        rtlpriv->intf_ops->enable_aspm(hw);
        rtl_write_byte(rtlpriv, REG_TXPAUSE, 0xFF);
@@ -1243,13 +1219,27 @@ static void _rtl92ce_poweroff_adapter(struct ieee80211_hw *hw)
        rtl_write_byte(rtlpriv, REG_MCUFWDL, 0x00);
        rtl_write_dword(rtlpriv, REG_GPIO_PIN_CTRL, 0x00000000);
        u1b_tmp = rtl_read_byte(rtlpriv, REG_GPIO_PIN_CTRL);
-        rtl_write_dword(rtlpriv, REG_GPIO_PIN_CTRL, 0x00FF0000 |
+        if ((rtlpcipriv->bt_coexist.bt_coexistence) &&
-                        (u1b_tmp << 8));
+             ((rtlpcipriv->bt_coexist.bt_coexist_type == BT_CSR_BC4) ||
+             (rtlpcipriv->bt_coexist.bt_coexist_type == BT_CSR_BC8))) {
+                rtl_write_dword(rtlpriv, REG_GPIO_PIN_CTRL, 0x00F30000 |
+                                (u1b_tmp << 8));
+        } else {
+                rtl_write_dword(rtlpriv, REG_GPIO_PIN_CTRL, 0x00FF0000 |
+                                (u1b_tmp << 8));
+        }
        rtl_write_word(rtlpriv, REG_GPIO_IO_SEL, 0x0790);
        rtl_write_word(rtlpriv, REG_LEDCFG0, 0x8080);
        rtl_write_byte(rtlpriv, REG_AFE_PLL_CTRL, 0x80);
        rtl_write_byte(rtlpriv, REG_SPS0_CTRL, 0x23);
-        rtl_write_byte(rtlpriv, REG_AFE_XTAL_CTRL, 0x0e);
+        if (rtlpcipriv->bt_coexist.bt_coexistence) {
+                u4b_tmp = rtl_read_dword(rtlpriv, REG_AFE_XTAL_CTRL);
+                u4b_tmp |= 0x03824800;
+                rtl_write_dword(rtlpriv, REG_AFE_XTAL_CTRL, u4b_tmp);
+        } else {
+                rtl_write_dword(rtlpriv, REG_AFE_XTAL_CTRL, 0x0e);
+        }
        rtl_write_byte(rtlpriv, REG_RSV_CTRL, 0x0e);
        rtl_write_byte(rtlpriv, REG_APS_FSMCO + 1, 0x10);
 }
@@ -1327,6 +1317,7 @@ void rtl92ce_update_interrupt_mask(struct ieee80211_hw *hw,
        RT_TRACE(rtlpriv, COMP_INTR, DBG_LOUD,
                 ("add_msr:%x, rm_msr:%x\n", add_msr, rm_msr));
        if (add_msr)
                rtlpci->irq_mask[0] |= add_msr;
        if (rm_msr)
@@ -1582,7 +1573,7 @@ static void _rtl92ce_read_adapter_info(struct ieee80211_hw *hw)
                         ("RTL819X Not boot from eeprom, check it !!"));
        }
-        RT_PRINT_DATA(rtlpriv, COMP_INIT, DBG_LOUD, ("MAP\n"),
+        RT_PRINT_DATA(rtlpriv, COMP_INIT, DBG_DMESG, ("MAP\n"),
                      hwinfo, HWSET_MAX_SIZE);
        eeprom_id = *((u16 *)&hwinfo[0]);
@@ -1610,6 +1601,10 @@ static void _rtl92ce_read_adapter_info(struct ieee80211_hw *hw)
                                             rtlefuse->autoload_failflag,
                                             hwinfo);
+        rtl8192ce_read_bt_coexist_info_from_hwpg(hw,
+                                                 rtlefuse->autoload_failflag,
+                                                 hwinfo);
        rtlefuse->eeprom_channelplan = *(u8 *)&hwinfo[EEPROM_CHANNELPLAN];
        rtlefuse->eeprom_version = *(u16 *)&hwinfo[EEPROM_VERSION];
        rtlefuse->txpwr_fromeprom = true;
@@ -1618,6 +1613,9 @@ static void _rtl92ce_read_adapter_info(struct ieee80211_hw *hw)
        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
                 ("EEPROM Customer ID: 0x%2x\n", rtlefuse->eeprom_oemid));
+        /* set channel paln to world wide 13 */
+        rtlefuse->channel_plan = COUNTRY_CODE_WORLD_WIDE_13;
        if (rtlhal->oem_id == RT_CID_DEFAULT) {
                switch (rtlefuse->eeprom_oemid) {
                case EEPROM_CID_DEFAULT:
@@ -1701,30 +1699,36 @@ void rtl92ce_read_eeprom_info(struct ieee80211_hw *hw)
        } else {
                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, ("Autoload ERR!!\n"));
        }
        _rtl92ce_hal_customized_behavior(hw);
 }
-void rtl92ce_update_hal_rate_table(struct ieee80211_hw *hw)
+static void rtl92ce_update_hal_rate_table(struct ieee80211_hw *hw,
+                struct ieee80211_sta *sta)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
-        u32 ratr_value = (u32) mac->basic_rates;
+        u32 ratr_value;
-        u8 *mcsrate = mac->mcs;
        u8 ratr_index = 0;
        u8 nmode = mac->ht_enable;
-        u8 mimo_ps = 1;
+        u8 mimo_ps = IEEE80211_SMPS_OFF;
        u16 shortgi_rate;
        u32 tmp_ratr_value;
        u8 curtxbw_40mhz = mac->bw_40;
-        u8 curshortgi_40mhz = mac->sgi_40;
+        u8 curshortgi_40mhz = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40) ?
-        u8 curshortgi_20mhz = mac->sgi_20;
+                               1 : 0;
+        u8 curshortgi_20mhz = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20) ?
+                               1 : 0;
        enum wireless_mode wirelessmode = mac->mode;
-        ratr_value |= ((*(u16 *) (mcsrate))) << 12;
+        if (rtlhal->current_bandtype == BAND_ON_5G)
+                ratr_value = sta->supp_rates[1] << 4;
+        else
+                ratr_value = sta->supp_rates[0];
+        ratr_value |= (sta->ht_cap.mcs.rx_mask[1] << 20 |
+                        sta->ht_cap.mcs.rx_mask[0] << 12);
        switch (wirelessmode) {
        case WIRELESS_MODE_B:
                if (ratr_value & 0x0000000c)
@@ -1738,7 +1742,7 @@ void rtl92ce_update_hal_rate_table(struct ieee80211_hw *hw)
        case WIRELESS_MODE_N_24G:
        case WIRELESS_MODE_N_5G:
                nmode = 1;
-                if (mimo_ps == 0) {
+                if (mimo_ps == IEEE80211_SMPS_STATIC) {
                        ratr_value &= 0x0007F005;
                } else {
                        u32 ratr_mask;
@@ -1761,10 +1765,19 @@ void rtl92ce_update_hal_rate_table(struct ieee80211_hw *hw)
                break;
        }
-        ratr_value &= 0x0FFFFFFF;
+        if ((rtlpcipriv->bt_coexist.bt_coexistence) &&
+            (rtlpcipriv->bt_coexist.bt_coexist_type == BT_CSR_BC4) &&
+            (rtlpcipriv->bt_coexist.bt_cur_state) &&
+            (rtlpcipriv->bt_coexist.bt_ant_isolation) &&
+            ((rtlpcipriv->bt_coexist.bt_service == BT_SCO) ||
+            (rtlpcipriv->bt_coexist.bt_service == BT_BUSY)))
+                ratr_value &= 0x0fffcfc0;
+        else
+                ratr_value &= 0x0FFFFFFF;
-        if (nmode && ((curtxbw_40mhz && curshortgi_40mhz) || (!curtxbw_40mhz &&
+        if (nmode && ((curtxbw_40mhz &&
-                       curshortgi_20mhz))) {
+                         curshortgi_40mhz) || (!curtxbw_40mhz &&
+                                               curshortgi_20mhz))) {
                ratr_value |= 0x10000000;
                tmp_ratr_value = (ratr_value >> 12);
@@ -1784,24 +1797,42 @@ void rtl92ce_update_hal_rate_table(struct ieee80211_hw *hw)
                 ("%x\n", rtl_read_dword(rtlpriv, REG_ARFR0)));
 }
-void rtl92ce_update_hal_rate_mask(struct ieee80211_hw *hw, u8 rssi_level)
+static void rtl92ce_update_hal_rate_mask(struct ieee80211_hw *hw,
+                struct ieee80211_sta *sta, u8 rssi_level)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
-        u32 ratr_bitmap = (u32) mac->basic_rates;
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
-        u8 *p_mcsrate = mac->mcs;
+        struct rtl_sta_info *sta_entry = NULL;
+        u32 ratr_bitmap;
        u8 ratr_index;
-        u8 curtxbw_40mhz = mac->bw_40;
+        u8 curtxbw_40mhz = (sta->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40)
-        u8 curshortgi_40mhz = mac->sgi_40;
+                                ? 1 : 0;
-        u8 curshortgi_20mhz = mac->sgi_20;
+        u8 curshortgi_40mhz = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40) ?
-        enum wireless_mode wirelessmode = mac->mode;
+                                1 : 0;
+        u8 curshortgi_20mhz = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20) ?
+                                1 : 0;
+        enum wireless_mode wirelessmode = 0;
        bool shortgi = false;
        u8 rate_mask[5];
        u8 macid = 0;
-        u8 mimops = 1;
+        u8 mimo_ps = IEEE80211_SMPS_OFF;
-        ratr_bitmap |= (p_mcsrate[1] << 20) | (p_mcsrate[0] << 12);
+        sta_entry = (struct rtl_sta_info *) sta->drv_priv;
+        wirelessmode = sta_entry->wireless_mode;
+        if (mac->opmode == NL80211_IFTYPE_STATION)
+                curtxbw_40mhz = mac->bw_40;
+        else if (mac->opmode == NL80211_IFTYPE_AP ||
+                mac->opmode == NL80211_IFTYPE_ADHOC)
+                macid = sta->aid + 1;
+        if (rtlhal->current_bandtype == BAND_ON_5G)
+                ratr_bitmap = sta->supp_rates[1] << 4;
+        else
+                ratr_bitmap = sta->supp_rates[0];
+        ratr_bitmap |= (sta->ht_cap.mcs.rx_mask[1] << 20 |
+                        sta->ht_cap.mcs.rx_mask[0] << 12);
        switch (wirelessmode) {
        case WIRELESS_MODE_B:
                ratr_index = RATR_INX_WIRELESS_B;
@@ -1828,7 +1859,7 @@ void rtl92ce_update_hal_rate_mask(struct ieee80211_hw *hw, u8 rssi_level)
        case WIRELESS_MODE_N_5G:
                ratr_index = RATR_INX_WIRELESS_NGB;
-                if (mimops == 0) {
+                if (mimo_ps == IEEE80211_SMPS_STATIC) {
                        if (rssi_level == 1)
                                ratr_bitmap &= 0x00070000;
                        else if (rssi_level == 2)
@@ -1892,8 +1923,8 @@ void rtl92ce_update_hal_rate_mask(struct ieee80211_hw *hw, u8 rssi_level)
        }
        RT_TRACE(rtlpriv, COMP_RATR, DBG_DMESG,
                 ("ratr_bitmap :%x\n", ratr_bitmap));
-        *(u32 *)&rate_mask = (ratr_bitmap & 0x0fffffff) |
+        *(u32 *)&rate_mask = EF4BYTE((ratr_bitmap & 0x0fffffff) |
-                                       (ratr_index << 28);
+                                     (ratr_index << 28));
        rate_mask[4] = macid | (shortgi ? 0x20 : 0x00) | 0x80;
        RT_TRACE(rtlpriv, COMP_RATR, DBG_DMESG, ("Rate_index:%x, "
                                                 "ratr_val:%x, %x:%x:%x:%x:%x\n",
@@ -1902,6 +1933,20 @@ void rtl92ce_update_hal_rate_mask(struct ieee80211_hw *hw, u8 rssi_level)
                                                 rate_mask[2], rate_mask[3],
                                                 rate_mask[4]));
        rtl92c_fill_h2c_cmd(hw, H2C_RA_MASK, 5, rate_mask);
+        if (macid != 0)
+                sta_entry->ratr_index = ratr_index;
+}
+void rtl92ce_update_hal_rate_tbl(struct ieee80211_hw *hw,
+                struct ieee80211_sta *sta, u8 rssi_level)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        if (rtlpriv->dm.useramask)
+                rtl92ce_update_hal_rate_mask(hw, sta, rssi_level);
+        else
+                rtl92ce_update_hal_rate_table(hw, sta);
 }
 void rtl92ce_update_channel_access_setting(struct ieee80211_hw *hw)
@@ -1919,7 +1964,7 @@ void rtl92ce_update_channel_access_setting(struct ieee80211_hw *hw)
        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_SIFS, (u8 *)&sifs_timer);
 }
-bool rtl92ce_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 * valid)
+bool rtl92ce_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 *valid)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
@@ -1929,7 +1974,7 @@ bool rtl92ce_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 * valid)
        bool actuallyset = false;
        unsigned long flag;
-        if ((rtlpci->up_first_time == 1) || (rtlpci->being_init_adapter))
+        if (rtlpci->being_init_adapter)
                return false;
        if (ppsc->swrf_processing)
@@ -1946,12 +1991,6 @@ bool rtl92ce_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 * valid)
        cur_rfstate = ppsc->rfpwr_state;
-        if ((ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM) &&
-            RT_IN_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_ASPM)) {
-                rtlpriv->intf_ops->disable_aspm(hw);
-                RT_CLEAR_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_ASPM);
-        }
        rtl_write_byte(rtlpriv, REG_MAC_PINMUX_CFG, rtl_read_byte(rtlpriv,
                       REG_MAC_PINMUX_CFG)&~(BIT(3)));
@@ -1976,38 +2015,13 @@ bool rtl92ce_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 * valid)
        }
        if (actuallyset) {
-                if (e_rfpowerstate_toset == ERFON) {
-                        if ((ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM) &&
-                            RT_IN_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_ASPM)) {
-                                rtlpriv->intf_ops->disable_aspm(hw);
-                                RT_CLEAR_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_ASPM);
-                        }
-                }
                spin_lock_irqsave(&rtlpriv->locks.rf_ps_lock, flag);
                ppsc->rfchange_inprogress = false;
                spin_unlock_irqrestore(&rtlpriv->locks.rf_ps_lock, flag);
+        } else {
-                if (e_rfpowerstate_toset == ERFOFF) {
-                        if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM) {
-                                rtlpriv->intf_ops->enable_aspm(hw);
-                                RT_SET_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_ASPM);
-                        }
-                }
-        } else if (e_rfpowerstate_toset == ERFOFF || cur_rfstate == ERFOFF) {
                if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_HALT_NIC)
                        RT_SET_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_HALT_NIC);
-                if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM) {
-                        rtlpriv->intf_ops->enable_aspm(hw);
-                        RT_SET_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_ASPM);
-                }
-                spin_lock_irqsave(&rtlpriv->locks.rf_ps_lock, flag);
-                ppsc->rfchange_inprogress = false;
-                spin_unlock_irqrestore(&rtlpriv->locks.rf_ps_lock, flag);
-        } else {
                spin_lock_irqsave(&rtlpriv->locks.rf_ps_lock, flag);
                ppsc->rfchange_inprogress = false;
                spin_unlock_irqrestore(&rtlpriv->locks.rf_ps_lock, flag);
@@ -2086,15 +2100,31 @@ void rtl92ce_set_key(struct ieee80211_hw *hw, u32 key_index,
                                macaddr = cam_const_broad;
                                entry_id = key_index;
                        } else {
+                                if (mac->opmode == NL80211_IFTYPE_AP) {
+                                        entry_id = rtl_cam_get_free_entry(hw,
+                                                                 p_macaddr);
+                                        if (entry_id >=  TOTAL_CAM_ENTRY) {
+                                                RT_TRACE(rtlpriv, COMP_SEC,
+                                                     DBG_EMERG,
+                                                     ("Can not find free hw"
+                                                     " security cam entry\n"));
+                                                return;
+                                        }
+                                } else {
+                                        entry_id = CAM_PAIRWISE_KEY_POSITION;
+                                }
                                key_index = PAIRWISE_KEYIDX;
-                                entry_id = CAM_PAIRWISE_KEY_POSITION;
                                is_pairwise = true;
                        }
                }
                if (rtlpriv->sec.key_len[key_index] == 0) {
                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
-                                 ("delete one entry\n"));
+                                 ("delete one entry, entry_id is %d\n",
+                                 entry_id));
+                        if (mac->opmode == NL80211_IFTYPE_AP)
+                                rtl_cam_del_entry(hw, p_macaddr);
                        rtl_cam_delete_one_entry(hw, p_macaddr, entry_id);
                } else {
                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
@@ -2146,3 +2176,132 @@ void rtl92ce_set_key(struct ieee80211_hw *hw, u32 key_index,
                }
        }
 }
+static void rtl8192ce_bt_var_init(struct ieee80211_hw *hw)
+{
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
+        rtlpcipriv->bt_coexist.bt_coexistence =
+                        rtlpcipriv->bt_coexist.eeprom_bt_coexist;
+        rtlpcipriv->bt_coexist.bt_ant_num =
+                        rtlpcipriv->bt_coexist.eeprom_bt_ant_num;
+        rtlpcipriv->bt_coexist.bt_coexist_type =
+                        rtlpcipriv->bt_coexist.eeprom_bt_type;
+        if (rtlpcipriv->bt_coexist.reg_bt_iso == 2)
+                rtlpcipriv->bt_coexist.bt_ant_isolation =
+                        rtlpcipriv->bt_coexist.eeprom_bt_ant_isolation;
+        else
+                rtlpcipriv->bt_coexist.bt_ant_isolation =
+                        rtlpcipriv->bt_coexist.reg_bt_iso;
+        rtlpcipriv->bt_coexist.bt_radio_shared_type =
+                        rtlpcipriv->bt_coexist.eeprom_bt_radio_shared;
+        if (rtlpcipriv->bt_coexist.bt_coexistence) {
+                if (rtlpcipriv->bt_coexist.reg_bt_sco == 1)
+                        rtlpcipriv->bt_coexist.bt_service = BT_OTHER_ACTION;
+                else if (rtlpcipriv->bt_coexist.reg_bt_sco == 2)
+                        rtlpcipriv->bt_coexist.bt_service = BT_SCO;
+                else if (rtlpcipriv->bt_coexist.reg_bt_sco == 4)
+                        rtlpcipriv->bt_coexist.bt_service = BT_BUSY;
+                else if (rtlpcipriv->bt_coexist.reg_bt_sco == 5)
+                        rtlpcipriv->bt_coexist.bt_service = BT_OTHERBUSY;
+                else
+                        rtlpcipriv->bt_coexist.bt_service = BT_IDLE;
+                rtlpcipriv->bt_coexist.bt_edca_ul = 0;
+                rtlpcipriv->bt_coexist.bt_edca_dl = 0;
+                rtlpcipriv->bt_coexist.bt_rssi_state = 0xff;
+        }
+}
+void rtl8192ce_read_bt_coexist_info_from_hwpg(struct ieee80211_hw *hw,
+                                              bool auto_load_fail, u8 *hwinfo)
+{
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
+        u8 value;
+        if (!auto_load_fail) {
+                rtlpcipriv->bt_coexist.eeprom_bt_coexist =
+                                        ((hwinfo[RF_OPTION1] & 0xe0) >> 5);
+                value = hwinfo[RF_OPTION4];
+                rtlpcipriv->bt_coexist.eeprom_bt_type = ((value & 0xe) >> 1);
+                rtlpcipriv->bt_coexist.eeprom_bt_ant_num = (value & 0x1);
+                rtlpcipriv->bt_coexist.eeprom_bt_ant_isolation =
+                                                         ((value & 0x10) >> 4);
+                rtlpcipriv->bt_coexist.eeprom_bt_radio_shared =
+                                                         ((value & 0x20) >> 5);
+        } else {
+                rtlpcipriv->bt_coexist.eeprom_bt_coexist = 0;
+                rtlpcipriv->bt_coexist.eeprom_bt_type = BT_2WIRE;
+                rtlpcipriv->bt_coexist.eeprom_bt_ant_num = ANT_X2;
+                rtlpcipriv->bt_coexist.eeprom_bt_ant_isolation = 0;
+                rtlpcipriv->bt_coexist.eeprom_bt_radio_shared = BT_RADIO_SHARED;
+        }
+        rtl8192ce_bt_var_init(hw);
+}
+void rtl8192ce_bt_reg_init(struct ieee80211_hw *hw)
+{
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
+        /* 0:Low, 1:High, 2:From Efuse. */
+        rtlpcipriv->bt_coexist.reg_bt_iso = 2;
+        /* 0:Idle, 1:None-SCO, 2:SCO, 3:From Counter. */
+        rtlpcipriv->bt_coexist.reg_bt_sco = 3;
+        /* 0:Disable BT control A-MPDU, 1:Enable BT control A-MPDU. */
+        rtlpcipriv->bt_coexist.reg_bt_sco = 0;
+}
+void rtl8192ce_bt_hw_init(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
+        u8 u1_tmp;
+        if (rtlpcipriv->bt_coexist.bt_coexistence &&
+            ((rtlpcipriv->bt_coexist.bt_coexist_type == BT_CSR_BC4) ||
+              rtlpcipriv->bt_coexist.bt_coexist_type == BT_CSR_BC8)) {
+                if (rtlpcipriv->bt_coexist.bt_ant_isolation)
+                        rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0xa0);
+                u1_tmp = rtl_read_byte(rtlpriv, 0x4fd) &
+                         BIT_OFFSET_LEN_MASK_32(0, 1);
+                u1_tmp = u1_tmp |
+                         ((rtlpcipriv->bt_coexist.bt_ant_isolation == 1) ?
+                         0 : BIT_OFFSET_LEN_MASK_32(1, 1)) |
+                         ((rtlpcipriv->bt_coexist.bt_service == BT_SCO) ?
+                         0 : BIT_OFFSET_LEN_MASK_32(2, 1));
+                rtl_write_byte(rtlpriv, 0x4fd, u1_tmp);
+                rtl_write_dword(rtlpriv, REG_BT_COEX_TABLE+4, 0xaaaa9aaa);
+                rtl_write_dword(rtlpriv, REG_BT_COEX_TABLE+8, 0xffbd0040);
+                rtl_write_dword(rtlpriv, REG_BT_COEX_TABLE+0xc, 0x40000010);
+                /* Config to 1T1R. */
+                if (rtlphy->rf_type == RF_1T1R) {
+                        u1_tmp = rtl_read_byte(rtlpriv, ROFDM0_TRXPATHENABLE);
+                        u1_tmp &= ~(BIT_OFFSET_LEN_MASK_32(1, 1));
+                        rtl_write_byte(rtlpriv, ROFDM0_TRXPATHENABLE, u1_tmp);
+                        u1_tmp = rtl_read_byte(rtlpriv, ROFDM1_TRXPATHENABLE);
+                        u1_tmp &= ~(BIT_OFFSET_LEN_MASK_32(1, 1));
+                        rtl_write_byte(rtlpriv, ROFDM1_TRXPATHENABLE, u1_tmp);
+                }
+        }
+}
+void rtl92ce_suspend(struct ieee80211_hw *hw)
+{
+}
+void rtl92ce_resume(struct ieee80211_hw *hw)
+{
+}
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/hw.h b/drivers/net/wireless/rtlwifi/rtl8192ce/hw.h
index a3dfdb635168..07dbe3e340a5 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/hw.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/hw.h
@@ -30,7 +30,18 @@
 #ifndef __RTL92CE_HW_H__
 #define __RTL92CE_HW_H__
-#define H2C_RA_MASK     6
+static inline u8 _rtl92c_get_chnl_group(u8 chnl)
+{
+        u8 group;
+        if (chnl < 3)
+                group = 0;
+        else if (chnl < 9)
+                group = 1;
+        else
+                group = 2;
+        return group;
+}
 void rtl92ce_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val);
 void rtl92ce_read_eeprom_info(struct ieee80211_hw *hw);
@@ -41,28 +52,27 @@ void rtl92ce_card_disable(struct ieee80211_hw *hw);
 void rtl92ce_enable_interrupt(struct ieee80211_hw *hw);
 void rtl92ce_disable_interrupt(struct ieee80211_hw *hw);
 int rtl92ce_set_network_type(struct ieee80211_hw *hw, enum nl80211_iftype type);
+void rtl92ce_set_check_bssid(struct ieee80211_hw *hw, bool check_bssid);
 void rtl92ce_set_qos(struct ieee80211_hw *hw, int aci);
 void rtl92ce_set_beacon_related_registers(struct ieee80211_hw *hw);
 void rtl92ce_set_beacon_interval(struct ieee80211_hw *hw);
 void rtl92ce_update_interrupt_mask(struct ieee80211_hw *hw,
                                   u32 add_msr, u32 rm_msr);
 void rtl92ce_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val);
-void rtl92ce_update_hal_rate_table(struct ieee80211_hw *hw);
+void rtl92ce_update_hal_rate_tbl(struct ieee80211_hw *hw,
-void rtl92ce_update_hal_rate_mask(struct ieee80211_hw *hw, u8 rssi_level);
+                                 struct ieee80211_sta *sta, u8 rssi_level);
 void rtl92ce_update_channel_access_setting(struct ieee80211_hw *hw);
 bool rtl92ce_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 *valid);
 void rtl92ce_enable_hw_security_config(struct ieee80211_hw *hw);
 void rtl92ce_set_key(struct ieee80211_hw *hw, u32 key_index,
                     u8 *p_macaddr, bool is_group, u8 enc_algo,
                     bool is_wepkey, bool clear_all);
-bool _rtl92ce_phy_config_mac_with_headerfile(struct ieee80211_hw *hw);
-void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished);
+void rtl8192ce_read_bt_coexist_info_from_hwpg(struct ieee80211_hw *hw,
-void rtl92c_set_fw_pwrmode_cmd(struct ieee80211_hw *hw, u8 mode);
+                        bool autoload_fail, u8 *hwinfo);
-void rtl92c_set_fw_joinbss_report_cmd(struct ieee80211_hw *hw, u8 mstatus);
+void rtl8192ce_bt_reg_init(struct ieee80211_hw *hw);
-int rtl92c_download_fw(struct ieee80211_hw *hw);
+void rtl8192ce_bt_hw_init(struct ieee80211_hw *hw);
-void rtl92c_firmware_selfreset(struct ieee80211_hw *hw);
+void rtl92ce_suspend(struct ieee80211_hw *hw);
-void rtl92c_fill_h2c_cmd(struct ieee80211_hw *hw,
+void rtl92ce_resume(struct ieee80211_hw *hw);
-                         u8 element_id, u32 cmd_len, u8 *p_cmdbuffer);
-bool rtl92ce_phy_mac_config(struct ieee80211_hw *hw);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/led.c b/drivers/net/wireless/rtlwifi/rtl8192ce/led.c
index 7b1da8d7508f..9dd1ed7b6422 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/led.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/led.c
@@ -32,6 +32,14 @@
 #include "reg.h"
 #include "led.h"
+static void _rtl92ce_init_led(struct ieee80211_hw *hw,
+                              struct rtl_led *pled, enum rtl_led_pin ledpin)
+{
+        pled->hw = hw;
+        pled->ledpin = ledpin;
+        pled->ledon = false;
+}
 void rtl92ce_sw_led_on(struct ieee80211_hw *hw, struct rtl_led *pled)
 {
        u8 ledcfg;
@@ -97,13 +105,12 @@ void rtl92ce_sw_led_off(struct ieee80211_hw *hw, struct rtl_led *pled)
 void rtl92ce_init_sw_leds(struct ieee80211_hw *hw)
 {
+        struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw);
+        _rtl92ce_init_led(hw, &(pcipriv->ledctl.sw_led0), LED_PIN_LED0);
+        _rtl92ce_init_led(hw, &(pcipriv->ledctl.sw_led1), LED_PIN_LED1);
 }
-void rtl92ce_deinit_sw_leds(struct ieee80211_hw *hw)
+static void _rtl92ce_sw_led_control(struct ieee80211_hw *hw,
-{
-}
-void _rtl92ce_sw_led_control(struct ieee80211_hw *hw,
                                    enum led_ctl_mode ledaction)
 {
        struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw);
@@ -138,7 +145,7 @@ void rtl92ce_led_control(struct ieee80211_hw *hw,
             ledaction == LED_CTL_POWER_ON)) {
                return;
        }
-        RT_TRACE(rtlpriv, COMP_LED, DBG_LOUD, ("ledaction %d,\n",
+        RT_TRACE(rtlpriv, COMP_LED, DBG_LOUD, ("ledaction %d.\n",
                                ledaction));
        _rtl92ce_sw_led_control(hw, ledaction);
 }
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/led.h b/drivers/net/wireless/rtlwifi/rtl8192ce/led.h
index 10da3018f4b7..7dfccea2095b 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/led.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/led.h
@@ -31,11 +31,8 @@
 #define __RTL92CE_LED_H__
 void rtl92ce_init_sw_leds(struct ieee80211_hw *hw);
-void rtl92ce_deinit_sw_leds(struct ieee80211_hw *hw);
 void rtl92ce_sw_led_on(struct ieee80211_hw *hw, struct rtl_led *pled);
 void rtl92ce_sw_led_off(struct ieee80211_hw *hw, struct rtl_led *pled);
 void rtl92ce_led_control(struct ieee80211_hw *hw, enum led_ctl_mode ledaction);
-void _rtl92ce_sw_led_control(struct ieee80211_hw *hw,
-                                    enum led_ctl_mode ledaction);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c b/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c
index d0541e8c6012..73ae8a431848 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c
@@ -38,7 +38,9 @@
 #include "dm.h"
 #include "table.h"
-u32 rtl92ce_phy_query_rf_reg(struct ieee80211_hw *hw,
+static bool _rtl92c_phy_config_mac_with_headerfile(struct ieee80211_hw *hw);
+u32 rtl92c_phy_query_rf_reg(struct ieee80211_hw *hw,
                            enum radio_path rfpath, u32 regaddr, u32 bitmask)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
@@ -73,9 +75,47 @@ u32 rtl92ce_phy_query_rf_reg(struct ieee80211_hw *hw,
        return readback_value;
 }
+bool rtl92c_phy_mac_config(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        bool is92c = IS_92C_SERIAL(rtlhal->version);
+        bool rtstatus = _rtl92c_phy_config_mac_with_headerfile(hw);
+        if (is92c)
+                rtl_write_byte(rtlpriv, 0x14, 0x71);
+        return rtstatus;
+}
+bool rtl92c_phy_bb_config(struct ieee80211_hw *hw)
+{
+        bool rtstatus = true;
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u16 regval;
+        u32 regvaldw;
+        u8 reg_hwparafile = 1;
+        _rtl92c_phy_init_bb_rf_register_definition(hw);
+        regval = rtl_read_word(rtlpriv, REG_SYS_FUNC_EN);
+        rtl_write_word(rtlpriv, REG_SYS_FUNC_EN,
+                       regval | BIT(13) | BIT(0) | BIT(1));
+        rtl_write_byte(rtlpriv, REG_AFE_PLL_CTRL, 0x83);
+        rtl_write_byte(rtlpriv, REG_AFE_PLL_CTRL + 1, 0xdb);
+        rtl_write_byte(rtlpriv, REG_RF_CTRL, RF_EN | RF_RSTB | RF_SDMRSTB);
+        rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN,
+                       FEN_PPLL | FEN_PCIEA | FEN_DIO_PCIE |
+                       FEN_BB_GLB_RSTn | FEN_BBRSTB);
+        rtl_write_byte(rtlpriv, REG_AFE_XTAL_CTRL + 1, 0x80);
+        regvaldw = rtl_read_dword(rtlpriv, REG_LEDCFG0);
+        rtl_write_dword(rtlpriv, REG_LEDCFG0, regvaldw | BIT(23));
+        if (reg_hwparafile == 1)
+                rtstatus = _rtl92c_phy_bb8192c_config_parafile(hw);
+        return rtstatus;
+}
 void rtl92ce_phy_set_rf_reg(struct ieee80211_hw *hw,
-                           enum radio_path rfpath,
+                            enum radio_path rfpath,
-                           u32 regaddr, u32 bitmask, u32 data)
+                            u32 regaddr, u32 bitmask, u32 data)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
@@ -121,45 +161,7 @@ void rtl92ce_phy_set_rf_reg(struct ieee80211_hw *hw,
                                               bitmask, data, rfpath));
 }
-bool rtl92ce_phy_mac_config(struct ieee80211_hw *hw)
+static bool _rtl92c_phy_config_mac_with_headerfile(struct ieee80211_hw *hw)
-{
-        struct rtl_priv *rtlpriv = rtl_priv(hw);
-        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
-        bool is92c = IS_92C_SERIAL(rtlhal->version);
-        bool rtstatus = _rtl92ce_phy_config_mac_with_headerfile(hw);
-        if (is92c)
-                rtl_write_byte(rtlpriv, 0x14, 0x71);
-        return rtstatus;
-}
-bool rtl92ce_phy_bb_config(struct ieee80211_hw *hw)
-{
-        bool rtstatus = true;
-        struct rtl_priv *rtlpriv = rtl_priv(hw);
-        u16 regval;
-        u32 regvaldw;
-        u8 reg_hwparafile = 1;
-        _rtl92c_phy_init_bb_rf_register_definition(hw);
-        regval = rtl_read_word(rtlpriv, REG_SYS_FUNC_EN);
-        rtl_write_word(rtlpriv, REG_SYS_FUNC_EN,
-                       regval | BIT(13) | BIT(0) | BIT(1));
-        rtl_write_byte(rtlpriv, REG_AFE_PLL_CTRL, 0x83);
-        rtl_write_byte(rtlpriv, REG_AFE_PLL_CTRL + 1, 0xdb);
-        rtl_write_byte(rtlpriv, REG_RF_CTRL, RF_EN | RF_RSTB | RF_SDMRSTB);
-        rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN,
-                       FEN_PPLL | FEN_PCIEA | FEN_DIO_PCIE |
-                       FEN_BB_GLB_RSTn | FEN_BBRSTB);
-        rtl_write_byte(rtlpriv, REG_AFE_XTAL_CTRL + 1, 0x80);
-        regvaldw = rtl_read_dword(rtlpriv, REG_LEDCFG0);
-        rtl_write_dword(rtlpriv, REG_LEDCFG0, regvaldw | BIT(23));
-        if (reg_hwparafile == 1)
-                rtstatus = _rtl92c_phy_bb8192c_config_parafile(hw);
-        return rtstatus;
-}
-bool _rtl92ce_phy_config_mac_with_headerfile(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        u32 i;
@@ -177,7 +179,7 @@ bool _rtl92ce_phy_config_mac_with_headerfile(struct ieee80211_hw *hw)
 }
 bool _rtl92ce_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
-                                                  u8 configtype)
+                                            u8 configtype)
 {
        int i;
        u32 *phy_regarray_table;
@@ -236,7 +238,7 @@ bool _rtl92ce_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
 }
 bool _rtl92ce_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw,
-                                                    u8 configtype)
+                                              u8 configtype)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        int i;
@@ -274,7 +276,7 @@ bool _rtl92ce_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw,
        return true;
 }
-bool rtl92ce_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
+bool rtl92c_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
                                          enum radio_path rfpath)
 {
@@ -364,74 +366,6 @@ bool rtl92ce_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
        return true;
 }
-void rtl92ce_phy_set_bw_mode_callback(struct ieee80211_hw *hw)
-{
-        struct rtl_priv *rtlpriv = rtl_priv(hw);
-        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
-        struct rtl_phy *rtlphy = &(rtlpriv->phy);
-        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
-        u8 reg_bw_opmode;
-        u8 reg_prsr_rsc;
-        RT_TRACE(rtlpriv, COMP_SCAN, DBG_TRACE,
-                 ("Switch to %s bandwidth\n",
-                  rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20 ?
-                  "20MHz" : "40MHz"))
-            if (is_hal_stop(rtlhal))
-                return;
-        reg_bw_opmode = rtl_read_byte(rtlpriv, REG_BWOPMODE);
-        reg_prsr_rsc = rtl_read_byte(rtlpriv, REG_RRSR + 2);
-        switch (rtlphy->current_chan_bw) {
-        case HT_CHANNEL_WIDTH_20:
-                reg_bw_opmode |= BW_OPMODE_20MHZ;
-                rtl_write_byte(rtlpriv, REG_BWOPMODE, reg_bw_opmode);
-                break;
-        case HT_CHANNEL_WIDTH_20_40:
-                reg_bw_opmode &= ~BW_OPMODE_20MHZ;
-                rtl_write_byte(rtlpriv, REG_BWOPMODE, reg_bw_opmode);
-                reg_prsr_rsc =
-                    (reg_prsr_rsc & 0x90) | (mac->cur_40_prime_sc << 5);
-                rtl_write_byte(rtlpriv, REG_RRSR + 2, reg_prsr_rsc);
-                break;
-        default:
-                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
-                         ("unknown bandwidth: %#X\n", rtlphy->current_chan_bw));
-                break;
-        }
-        switch (rtlphy->current_chan_bw) {
-        case HT_CHANNEL_WIDTH_20:
-                rtl_set_bbreg(hw, RFPGA0_RFMOD, BRFMOD, 0x0);
-                rtl_set_bbreg(hw, RFPGA1_RFMOD, BRFMOD, 0x0);
-                rtl_set_bbreg(hw, RFPGA0_ANALOGPARAMETER2, BIT(10), 1);
-                break;
-        case HT_CHANNEL_WIDTH_20_40:
-                rtl_set_bbreg(hw, RFPGA0_RFMOD, BRFMOD, 0x1);
-                rtl_set_bbreg(hw, RFPGA1_RFMOD, BRFMOD, 0x1);
-                rtl_set_bbreg(hw, RCCK0_SYSTEM, BCCK_SIDEBAND,
-                              (mac->cur_40_prime_sc >> 1));
-                rtl_set_bbreg(hw, ROFDM1_LSTF, 0xC00, mac->cur_40_prime_sc);
-                rtl_set_bbreg(hw, RFPGA0_ANALOGPARAMETER2, BIT(10), 0);
-                rtl_set_bbreg(hw, 0x818, (BIT(26) | BIT(27)),
-                              (mac->cur_40_prime_sc ==
-                               HAL_PRIME_CHNL_OFFSET_LOWER) ? 2 : 1);
-                break;
-        default:
-                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
-                         ("unknown bandwidth: %#X\n", rtlphy->current_chan_bw));
-                break;
-        }
-        rtl92c_phy_rf6052_set_bandwidth(hw, rtlphy->current_chan_bw);
-        rtlphy->set_bwmode_inprogress = false;
-        RT_TRACE(rtlpriv, COMP_SCAN, DBG_TRACE, ("<==\n"));
-}
 void _rtl92ce_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t)
 {
        u8 tmpreg;
@@ -477,6 +411,36 @@ void _rtl92ce_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t)
        }
 }
+static void _rtl92ce_phy_set_rf_sleep(struct ieee80211_hw *hw)
+{
+        u32 u4b_tmp;
+        u8 delay = 5;
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        rtl_write_byte(rtlpriv, REG_TXPAUSE, 0xFF);
+        rtl_set_rfreg(hw, RF90_PATH_A, 0x00, RFREG_OFFSET_MASK, 0x00);
+        rtl_write_byte(rtlpriv, REG_APSD_CTRL, 0x40);
+        u4b_tmp = rtl_get_rfreg(hw, RF90_PATH_A, 0, RFREG_OFFSET_MASK);
+        while (u4b_tmp != 0 && delay > 0) {
+                rtl_write_byte(rtlpriv, REG_APSD_CTRL, 0x0);
+                rtl_set_rfreg(hw, RF90_PATH_A, 0x00, RFREG_OFFSET_MASK, 0x00);
+                rtl_write_byte(rtlpriv, REG_APSD_CTRL, 0x40);
+                u4b_tmp = rtl_get_rfreg(hw, RF90_PATH_A, 0, RFREG_OFFSET_MASK);
+                delay--;
+        }
+        if (delay == 0) {
+                rtl_write_byte(rtlpriv, REG_APSD_CTRL, 0x00);
+                rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN, 0xE2);
+                rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN, 0xE3);
+                rtl_write_byte(rtlpriv, REG_TXPAUSE, 0x00);
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_TRACE,
+                         ("Switch RF timeout !!!.\n"));
+                return;
+        }
+        rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN, 0xE2);
+        rtl_write_byte(rtlpriv, REG_SPS0_CTRL, 0x22);
+}
 static bool _rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw,
                                            enum rf_pwrstate rfpwr_state)
 {
@@ -523,33 +487,6 @@ static bool _rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw,
                        break;
                }
        case ERFOFF:{
-                        for (queue_id = 0, i = 0;
-                             queue_id < RTL_PCI_MAX_TX_QUEUE_COUNT;) {
-                                ring = &pcipriv->dev.tx_ring[queue_id];
-                                if (skb_queue_len(&ring->queue) == 0 ||
-                                    queue_id == BEACON_QUEUE) {
-                                        queue_id++;
-                                        continue;
-                                } else {
-                                        RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
-                                                 ("eRf Off/Sleep: %d times "
-                                                  "TcbBusyQueue[%d] "
-                                                  "=%d before doze!\n", (i + 1),
-                                                  queue_id,
-                                                  skb_queue_len(&ring->queue)));
-                                        udelay(10);
-                                        i++;
-                                }
-                                if (i >= MAX_DOZE_WAITING_TIMES_9x) {
-                                        RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
-                                                 ("\nERFOFF: %d times "
-                                                  "TcbBusyQueue[%d] = %d !\n",
-                                                  MAX_DOZE_WAITING_TIMES_9x,
-                                                  queue_id,
-                                                  skb_queue_len(&ring->queue)));
-                                        break;
-                                }
-                        }
                        if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_HALT_NIC) {
                                RT_TRACE(rtlpriv, COMP_RF, DBG_DMESG,
                                         ("IPS Set eRf nic disable\n"));
@@ -581,6 +518,7 @@ static bool _rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw,
                                                  "TcbBusyQueue[%d] =%d before "
                                                  "doze!\n", (i + 1), queue_id,
                                                  skb_queue_len(&ring->queue)));
                                        udelay(10);
                                        i++;
                                }
@@ -599,7 +537,7 @@ static bool _rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw,
                                  jiffies_to_msecs(jiffies -
                                                   ppsc->last_awake_jiffies)));
                        ppsc->last_sleep_jiffies = jiffies;
-                        _rtl92c_phy_set_rf_sleep(hw);
+                        _rtl92ce_phy_set_rf_sleep(hw);
                        break;
                }
        default:
@@ -614,10 +552,11 @@ static bool _rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw,
        return bresult;
 }
-bool rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw,
+bool rtl92c_phy_set_rf_power_state(struct ieee80211_hw *hw,
                                   enum rf_pwrstate rfpwr_state)
 {
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
        bool bresult = false;
        if (rfpwr_state == ppsc->rfpwr_state)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/phy.h b/drivers/net/wireless/rtlwifi/rtl8192ce/phy.h
index a37267e3fc22..ad580852cc76 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/phy.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/phy.h
@@ -39,6 +39,7 @@
 #define RT_CANNOT_IO(hw)                false
 #define HIGHPOWER_RADIOA_ARRAYLEN       22
+#define IQK_ADDA_REG_NUM                16
 #define MAX_TOLERANCE                   5
 #define IQK_DELAY_TIME                  1
@@ -56,6 +57,8 @@
 #define IQK_ADDA_REG_NUM                16
 #define IQK_MAC_REG_NUM                 4
+#define IQK_DELAY_TIME                  1
 #define RF90_PATH_MAX                   2
 #define CT_OFFSET_MAC_ADDR              0X16
@@ -76,7 +79,7 @@
 #define CT_OFFSET_CUSTOMER_ID           0x7F
 #define RTL92C_MAX_PATH_NUM             2
-#define LLT_LAST_ENTRY_OF_TX_PKT_BUFFER 255
 enum swchnlcmd_id {
        CMDID_END,
        CMDID_SET_TXPOWEROWER_LEVEL,
@@ -184,43 +187,44 @@ struct tx_power_struct {
        u32 mcs_original_offset[4][16];
 };
-extern u32 rtl92c_phy_query_bb_reg(struct ieee80211_hw *hw,
+bool rtl92c_phy_bb_config(struct ieee80211_hw *hw);
+u32 rtl92c_phy_query_bb_reg(struct ieee80211_hw *hw,
                                   u32 regaddr, u32 bitmask);
-extern void rtl92c_phy_set_bb_reg(struct ieee80211_hw *hw,
+void rtl92c_phy_set_bb_reg(struct ieee80211_hw *hw,
                                  u32 regaddr, u32 bitmask, u32 data);
-extern u32 rtl92c_phy_query_rf_reg(struct ieee80211_hw *hw,
+u32 rtl92c_phy_query_rf_reg(struct ieee80211_hw *hw,
                                   enum radio_path rfpath, u32 regaddr,
                                   u32 bitmask);
 extern void rtl92ce_phy_set_rf_reg(struct ieee80211_hw *hw,
-                                  enum radio_path rfpath, u32 regaddr,
+                                   enum radio_path rfpath, u32 regaddr,
-                                  u32 bitmask, u32 data);
+                                   u32 bitmask, u32 data);
-extern bool rtl92c_phy_mac_config(struct ieee80211_hw *hw);
+bool rtl92c_phy_mac_config(struct ieee80211_hw *hw);
 bool rtl92ce_phy_bb_config(struct ieee80211_hw *hw);
-extern bool rtl92c_phy_rf_config(struct ieee80211_hw *hw);
+bool rtl92c_phy_rf_config(struct ieee80211_hw *hw);
-extern bool rtl92c_phy_config_rf_with_feaderfile(struct ieee80211_hw *hw,
+bool rtl92c_phy_config_rf_with_feaderfile(struct ieee80211_hw *hw,
                                                 enum radio_path rfpath);
-extern void rtl92c_phy_get_hw_reg_originalvalue(struct ieee80211_hw *hw);
+void rtl92c_phy_get_hw_reg_originalvalue(struct ieee80211_hw *hw);
-extern void rtl92c_phy_get_txpower_level(struct ieee80211_hw *hw,
+void rtl92c_phy_get_txpower_level(struct ieee80211_hw *hw,
                                         long *powerlevel);
-extern void rtl92c_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel);
+void rtl92c_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel);
-extern bool rtl92c_phy_update_txpower_dbm(struct ieee80211_hw *hw,
+bool rtl92c_phy_update_txpower_dbm(struct ieee80211_hw *hw,
                                          long power_indbm);
-extern void rtl92c_phy_scan_operation_backup(struct ieee80211_hw *hw,
+void rtl92c_phy_scan_operation_backup(struct ieee80211_hw *hw,
                                             u8 operation);
-extern void rtl92c_phy_set_bw_mode_callback(struct ieee80211_hw *hw);
+void rtl92c_phy_set_bw_mode(struct ieee80211_hw *hw,
-extern void rtl92c_phy_set_bw_mode(struct ieee80211_hw *hw,
                                   enum nl80211_channel_type ch_type);
-extern void rtl92c_phy_sw_chnl_callback(struct ieee80211_hw *hw);
+void rtl92c_phy_sw_chnl_callback(struct ieee80211_hw *hw);
-extern u8 rtl92c_phy_sw_chnl(struct ieee80211_hw *hw);
+u8 rtl92c_phy_sw_chnl(struct ieee80211_hw *hw);
-extern void rtl92c_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery);
+void rtl92c_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery);
-extern void rtl92c_phy_set_beacon_hw_reg(struct ieee80211_hw *hw,
+void rtl92c_phy_set_beacon_hw_reg(struct ieee80211_hw *hw,
                                         u16 beaconinterval);
 void rtl92c_phy_ap_calibrate(struct ieee80211_hw *hw, char delta);
 void rtl92c_phy_lc_calibrate(struct ieee80211_hw *hw);
+void _rtl92ce_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t);
 void rtl92c_phy_set_rfpath_switch(struct ieee80211_hw *hw, bool bmain);
 bool rtl92c_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
                                          enum radio_path rfpath);
-extern bool rtl8192_phy_check_is_legal_rfpath(struct ieee80211_hw *hw,
+bool rtl8192_phy_check_is_legal_rfpath(struct ieee80211_hw *hw,
                                              u32 rfpath);
 bool rtl92c_phy_set_io_cmd(struct ieee80211_hw *hw, enum io_type iotype);
 bool rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw,
@@ -237,9 +241,6 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask);
 void _rtl92c_phy_rf_serial_write(struct ieee80211_hw *hw,
                                        enum radio_path rfpath, u32 offset,
                                        u32 data);
-void _rtl92c_store_pwrIndex_diffrate_offset(struct ieee80211_hw *hw,
-                                                   u32 regaddr, u32 bitmask,
-                                                   u32 data);
 void _rtl92c_phy_fw_rf_serial_write(struct ieee80211_hw *hw,
                                           enum radio_path rfpath, u32 offset,
                                           u32 data);
@@ -250,5 +251,11 @@ bool _rtl92ce_phy_config_mac_with_headerfile(struct ieee80211_hw *hw);
 void _rtl92c_phy_init_bb_rf_register_definition(struct ieee80211_hw *hw);
 bool _rtl92c_phy_bb8192c_config_parafile(struct ieee80211_hw *hw);
 void _rtl92c_phy_set_rf_sleep(struct ieee80211_hw *hw);
+bool rtl92c_phy_set_rf_power_state(struct ieee80211_hw *hw,
+                                   enum rf_pwrstate rfpwr_state);
+bool _rtl92ce_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
+                                            u8 configtype);
+bool _rtl92ce_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw,
+                                              u8 configtype);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/reg.h b/drivers/net/wireless/rtlwifi/rtl8192ce/reg.h
index b0868a613841..598cecc63f41 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/reg.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/reg.h
@@ -72,6 +72,7 @@
 #define REG_GPIO_IO_SEL_2                       0x0062
 /* RTL8723 WIFI/BT/GPS Multi-Function control source. */
 #define REG_MULTI_FUNC_CTRL                     0x0068
 #define REG_MCUFWDL                             0x0080
 #define REG_HMEBOX_EXT_0                        0x0088
@@ -542,7 +543,7 @@
 #define IMR_OCPINT                              BIT(1)
 #define IMR_WLANOFF                             BIT(0)
-#define HWSET_MAX_SIZE                          128
+#define EFUSE_REAL_CONTENT_LEN                  512
 #define EEPROM_DEFAULT_TSSI                     0x0
 #define EEPROM_DEFAULT_TXPOWERDIFF              0x0
@@ -656,6 +657,7 @@
 #define STOPBE                                  BIT(1)
 #define STOPBK                                  BIT(0)
+#define RCR_APPFCS                              BIT(31)
 #define RCR_APP_FCS                             BIT(31)
 #define RCR_APP_MIC                             BIT(30)
 #define RCR_APP_ICV                             BIT(29)
@@ -688,6 +690,7 @@
 #define REG_USB_INFO                            0xFE17
 #define REG_USB_SPECIAL_OPTION                  0xFE55
 #define REG_USB_DMA_AGG_TO                      0xFE5B
 #define REG_USB_AGG_TO                          0xFE5C
 #define REG_USB_AGG_TH                          0xFE5D
@@ -775,7 +778,6 @@
 #define BOOT_FROM_EEPROM                        BIT(4)
 #define EEPROM_EN                               BIT(5)
-#define EEPROMSEL                               BOOT_FROM_EEPROM
 #define AFE_BGEN                                BIT(0)
 #define AFE_MBEN                                BIT(1)
@@ -901,28 +903,7 @@
 #define BD_PKG_SEL                              BIT(25)
 #define BD_HCI_SEL                              BIT(26)
 #define TYPE_ID                                 BIT(27)
+#define RF_RL_ID                (BIT(31) | BIT(30) | BIT(29) | BIT(28))
-/* REG_GPIO_OUTSTS (For RTL8723 only) */
-#define EFS_HCI_SEL                             (BIT(0)|BIT(1))
-#define PAD_HCI_SEL                             (BIT(2)|BIT(3))
-#define HCI_SEL                                 (BIT(4)|BIT(5))
-#define PKG_SEL_HCI                             BIT(6)
-#define FEN_GPS                                 BIT(7)
-#define FEN_BT                                  BIT(8)
-#define FEN_WL                                  BIT(9)
-#define FEN_PCI                                 BIT(10)
-#define FEN_USB                                 BIT(11)
-#define BTRF_HWPDN_N                            BIT(12)
-#define WLRF_HWPDN_N                            BIT(13)
-#define PDN_BT_N                                BIT(14)
-#define PDN_GPS_N                               BIT(15)
-#define BT_CTL_HWPDN                            BIT(16)
-#define GPS_CTL_HWPDN                           BIT(17)
-#define PPHY_SUSB                               BIT(20)
-#define UPHY_SUSB                               BIT(21)
-#define PCI_SUSEN                               BIT(22)
-#define USB_SUSEN                               BIT(23)
-#define RF_RL_ID                        (BIT(31) | BIT(30) | BIT(29) | BIT(28))
 #define CHIP_VER_RTL_MASK                       0xF000
 #define CHIP_VER_RTL_SHIFT                      12
@@ -1077,6 +1058,7 @@
 #define _RARF_RC8(x)                            (((x) & 0x1F) << 24)
 #define AC_PARAM_TXOP_OFFSET                    16
+#define AC_PARAM_TXOP_LIMIT_OFFSET              16
 #define AC_PARAM_ECW_MAX_OFFSET                 12
 #define AC_PARAM_ECW_MIN_OFFSET                 8
 #define AC_PARAM_AIFS_OFFSET                    0
@@ -1221,33 +1203,11 @@
 #define EPROM_CMD_CONFIG                        0x3
 #define EPROM_CMD_LOAD                          1
-#define HWSET_MAX_SIZE_92S              HWSET_MAX_SIZE
+#define HWSET_MAX_SIZE_92S                      HWSET_MAX_SIZE
-#define HAL_8192C_HW_GPIO_WPS_BIT               BIT(2)
-/* REG_MULTI_FUNC_CTRL(For RTL8723 Only) */
-/* Enable GPIO[9] as WiFi HW PDn source */
 #define WL_HWPDN_EN                             BIT(0)
-/* WiFi HW PDn polarity control */
-#define WL_HWPDN_SL                             BIT(1)
+#define HAL_8192C_HW_GPIO_WPS_BIT               BIT(2)
-/* WiFi function enable */
-#define WL_FUNC_EN                              BIT(2)
-/* Enable GPIO[9] as WiFi RF HW PDn source */
-#define WL_HWROF_EN                             BIT(3)
-/* Enable GPIO[11] as BT HW PDn source */
-#define BT_HWPDN_EN                             BIT(16)
-/* BT HW PDn polarity control */
-#define BT_HWPDN_SL                             BIT(17)
-/* BT function enable */
-#define BT_FUNC_EN                              BIT(18)
-/* Enable GPIO[11] as BT/GPS RF HW PDn source */
-#define BT_HWROF_EN                             BIT(19)
-/* Enable GPIO[10] as GPS HW PDn source */
-#define GPS_HWPDN_EN                            BIT(20)
-/* GPS HW PDn polarity control */
-#define GPS_HWPDN_SL                            BIT(21)
-/* GPS function enable */
-#define GPS_FUNC_EN                             BIT(22)
 #define RPMAC_RESET                             0x100
 #define RPMAC_TXSTART                           0x104
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/rf.c b/drivers/net/wireless/rtlwifi/rtl8192ce/rf.c
index 669b1168dbec..90d0f2cf3b27 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/rf.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/rf.c
@@ -34,9 +34,9 @@
 #include "rf.h"
 #include "dm.h"
-static bool _rtl92c_phy_rf6052_config_parafile(struct ieee80211_hw *hw);
+static bool _rtl92ce_phy_rf6052_config_parafile(struct ieee80211_hw *hw);
-void rtl92c_phy_rf6052_set_bandwidth(struct ieee80211_hw *hw, u8 bandwidth)
+void rtl92ce_phy_rf6052_set_bandwidth(struct ieee80211_hw *hw, u8 bandwidth)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
@@ -62,7 +62,7 @@ void rtl92c_phy_rf6052_set_bandwidth(struct ieee80211_hw *hw, u8 bandwidth)
 }
 void rtl92ce_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
-                                       u8 *ppowerlevel)
+                                        u8 *ppowerlevel)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
@@ -128,8 +128,7 @@ void rtl92ce_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
        tmpval = tx_agc[RF90_PATH_A] >> 8;
-        if (mac->mode == WIRELESS_MODE_B)
+        tmpval = tmpval & 0xff00ffff;
-                tmpval = tmpval & 0xff00ffff;
        rtl_set_bbreg(hw, RTXAGC_B_CCK11_A_CCK2_11, 0xffffff00, tmpval);
@@ -202,7 +201,7 @@ static void _rtl92c_get_txpower_writeval_by_regulatory(struct ieee80211_hw *hw,
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
-        u8 i, chnlgroup, pwr_diff_limit[4];
+        u8 i, chnlgroup = 0, pwr_diff_limit[4];
        u32 writeVal, customer_limit, rf;
        for (rf = 0; rf < 2; rf++) {
@@ -440,16 +439,17 @@ bool rtl92ce_phy_rf6052_config(struct ieee80211_hw *hw)
        else
                rtlphy->num_total_rfpath = 2;
-        return _rtl92c_phy_rf6052_config_parafile(hw);
+        return _rtl92ce_phy_rf6052_config_parafile(hw);
 }
-static bool _rtl92c_phy_rf6052_config_parafile(struct ieee80211_hw *hw)
+static bool _rtl92ce_phy_rf6052_config_parafile(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
-        u32 u4_regvalue;
+        u32 u4_regvalue = 0;
        u8 rfpath;
-        bool rtstatus;
+        bool rtstatus = true;
        struct bb_reg_def *pphyreg;
        for (rfpath = 0; rfpath < rtlphy->num_total_rfpath; rfpath++) {
@@ -484,12 +484,12 @@ static bool _rtl92c_phy_rf6052_config_parafile(struct ieee80211_hw *hw)
                switch (rfpath) {
                case RF90_PATH_A:
-                        rtstatus = rtl92ce_phy_config_rf_with_headerfile(hw,
+                        rtstatus = rtl92c_phy_config_rf_with_headerfile(hw,
-                                        (enum radio_path) rfpath);
+                                                (enum radio_path)rfpath);
                        break;
                case RF90_PATH_B:
-                        rtstatus = rtl92ce_phy_config_rf_with_headerfile(hw,
+                        rtstatus = rtl92c_phy_config_rf_with_headerfile(hw,
-                                        (enum radio_path) rfpath);
+                                                (enum radio_path)rfpath);
                        break;
                case RF90_PATH_C:
                        break;
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/rf.h b/drivers/net/wireless/rtlwifi/rtl8192ce/rf.h
index 3aa520c1c171..39ff03685986 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/rf.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/rf.h
@@ -34,14 +34,11 @@
 #define RF6052_MAX_REG                  0x3F
 #define RF6052_MAX_PATH                 2
-extern void rtl92c_phy_rf6052_set_bandwidth(struct ieee80211_hw *hw,
+extern void rtl92ce_phy_rf6052_set_bandwidth(struct ieee80211_hw *hw,
-                                            u8 bandwidth);
+                                             u8 bandwidth);
-extern void rtl92c_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
+extern void rtl92ce_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
-                                              u8 *ppowerlevel);
+                                               u8 *ppowerlevel);
-extern void rtl92c_phy_rf6052_set_ofdm_txpower(struct ieee80211_hw *hw,
+extern void rtl92ce_phy_rf6052_set_ofdm_txpower(struct ieee80211_hw *hw,
-                                               u8 *ppowerlevel, u8 channel);
+                                                u8 *ppowerlevel, u8 channel);
-bool rtl92ce_phy_rf6052_config(struct ieee80211_hw *hw);
+extern bool rtl92ce_phy_rf6052_config(struct ieee80211_hw *hw);
-bool rtl92ce_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
-                                          enum radio_path rfpath);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c b/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
index b1cc4d44f534..390bbb5ee11d 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
@@ -42,10 +42,58 @@
 #include "trx.h"
 #include "led.h"
+static void rtl92c_init_aspm_vars(struct ieee80211_hw *hw)
+{
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        /*close ASPM for AMD defaultly */
+        rtlpci->const_amdpci_aspm = 0;
+        /*
+         * ASPM PS mode.
+         * 0 - Disable ASPM,
+         * 1 - Enable ASPM without Clock Req,
+         * 2 - Enable ASPM with Clock Req,
+         * 3 - Alwyas Enable ASPM with Clock Req,
+         * 4 - Always Enable ASPM without Clock Req.
+         * set defult to RTL8192CE:3 RTL8192E:2
+         * */
+        rtlpci->const_pci_aspm = 3;
+        /*Setting for PCI-E device */
+        rtlpci->const_devicepci_aspm_setting = 0x03;
+        /*Setting for PCI-E bridge */
+        rtlpci->const_hostpci_aspm_setting = 0x02;
+        /*
+         * In Hw/Sw Radio Off situation.
+         * 0 - Default,
+         * 1 - From ASPM setting without low Mac Pwr,
+         * 2 - From ASPM setting with low Mac Pwr,
+         * 3 - Bus D3
+         * set default to RTL8192CE:0 RTL8192SE:2
+         */
+        rtlpci->const_hwsw_rfoff_d3 = 0;
+        /*
+         * This setting works for those device with
+         * backdoor ASPM setting such as EPHY setting.
+         * 0 - Not support ASPM,
+         * 1 - Support ASPM,
+         * 2 - According to chipset.
+         */
+        rtlpci->const_support_pciaspm = 1;
+}
 int rtl92c_init_sw_vars(struct ieee80211_hw *hw)
 {
+        int err;
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        const struct firmware *firmware;
+        rtl8192ce_bt_reg_init(hw);
        rtlpriv->dm.dm_initialgain_enable = 1;
        rtlpriv->dm.dm_flag = 0;
@@ -53,7 +101,12 @@ int rtl92c_init_sw_vars(struct ieee80211_hw *hw)
        rtlpriv->dm.thermalvalue = 0;
        rtlpci->transmit_config = CFENDFORM | BIT(12) | BIT(13);
-        rtlpci->receive_config = (RCR_APP_FCS |
+        /* compatible 5G band 88ce just 2.4G band & smsp */
+        rtlpriv->rtlhal.current_bandtype = BAND_ON_2_4G;
+        rtlpriv->rtlhal.bandset = BAND_ON_2_4G;
+        rtlpriv->rtlhal.macphymode = SINGLEMAC_SINGLEPHY;
+        rtlpci->receive_config = (RCR_APPFCS |
                                  RCR_AMF |
                                  RCR_ADF |
                                  RCR_APP_MIC |
@@ -76,13 +129,49 @@ int rtl92c_init_sw_vars(struct ieee80211_hw *hw)
        rtlpci->irq_mask[1] = (u32) (IMR_CPWM | IMR_C2HCMD | 0);
-        rtlpriv->rtlhal.pfirmware = (u8 *) vmalloc(0x4000);
+        /* for LPS & IPS */
+        rtlpriv->psc.inactiveps = rtlpriv->cfg->mod_params->inactiveps;
+        rtlpriv->psc.swctrl_lps = rtlpriv->cfg->mod_params->swctrl_lps;
+        rtlpriv->psc.fwctrl_lps = rtlpriv->cfg->mod_params->fwctrl_lps;
+        rtlpriv->psc.reg_fwctrl_lps = 3;
+        rtlpriv->psc.reg_max_lps_awakeintvl = 5;
+        /* for ASPM, you can close aspm through
+         * set const_support_pciaspm = 0 */
+        rtl92c_init_aspm_vars(hw);
+        if (rtlpriv->psc.reg_fwctrl_lps == 1)
+                rtlpriv->psc.fwctrl_psmode = FW_PS_MIN_MODE;
+        else if (rtlpriv->psc.reg_fwctrl_lps == 2)
+                rtlpriv->psc.fwctrl_psmode = FW_PS_MAX_MODE;
+        else if (rtlpriv->psc.reg_fwctrl_lps == 3)
+                rtlpriv->psc.fwctrl_psmode = FW_PS_DTIM_MODE;
+        /* for firmware buf */
+        rtlpriv->rtlhal.pfirmware = vzalloc(0x4000);
        if (!rtlpriv->rtlhal.pfirmware) {
                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
                         ("Can't alloc buffer for fw.\n"));
                return 1;
        }
+        /* request fw */
+        err = request_firmware(&firmware, rtlpriv->cfg->fw_name,
+                        rtlpriv->io.dev);
+        if (err) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("Failed to request firmware!\n"));
+                return 1;
+        }
+        if (firmware->size > 0x4000) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("Firmware is too big!\n"));
+                release_firmware(firmware);
+                return 1;
+        }
+        memcpy(rtlpriv->rtlhal.pfirmware, firmware->data, firmware->size);
+        rtlpriv->rtlhal.fwsize = firmware->size;
+        release_firmware(firmware);
        return 0;
 }
@@ -103,17 +192,19 @@ static struct rtl_hal_ops rtl8192ce_hal_ops = {
        .interrupt_recognized = rtl92ce_interrupt_recognized,
        .hw_init = rtl92ce_hw_init,
        .hw_disable = rtl92ce_card_disable,
+        .hw_suspend = rtl92ce_suspend,
+        .hw_resume = rtl92ce_resume,
        .enable_interrupt = rtl92ce_enable_interrupt,
        .disable_interrupt = rtl92ce_disable_interrupt,
        .set_network_type = rtl92ce_set_network_type,
+        .set_chk_bssid = rtl92ce_set_check_bssid,
        .set_qos = rtl92ce_set_qos,
        .set_bcn_reg = rtl92ce_set_beacon_related_registers,
        .set_bcn_intv = rtl92ce_set_beacon_interval,
        .update_interrupt_mask = rtl92ce_update_interrupt_mask,
        .get_hw_reg = rtl92ce_get_hw_reg,
        .set_hw_reg = rtl92ce_set_hw_reg,
-        .update_rate_table = rtl92ce_update_hal_rate_table,
+        .update_rate_tbl = rtl92ce_update_hal_rate_tbl,
-        .update_rate_mask = rtl92ce_update_hal_rate_mask,
        .fill_tx_desc = rtl92ce_tx_fill_desc,
        .fill_tx_cmddesc = rtl92ce_tx_fill_cmddesc,
        .query_rx_desc = rtl92ce_rx_query_desc,
@@ -123,7 +214,7 @@ static struct rtl_hal_ops rtl8192ce_hal_ops = {
        .switch_channel = rtl92c_phy_sw_chnl,
        .dm_watchdog = rtl92c_dm_watchdog,
        .scan_operation_backup = rtl92c_phy_scan_operation_backup,
-        .set_rf_power_state = rtl92ce_phy_set_rf_power_state,
+        .set_rf_power_state = rtl92c_phy_set_rf_power_state,
        .led_control = rtl92ce_led_control,
        .set_desc = rtl92ce_set_desc,
        .get_desc = rtl92ce_get_desc,
@@ -131,27 +222,29 @@ static struct rtl_hal_ops rtl8192ce_hal_ops = {
        .enable_hw_sec = rtl92ce_enable_hw_security_config,
        .set_key = rtl92ce_set_key,
        .init_sw_leds = rtl92ce_init_sw_leds,
-        .deinit_sw_leds = rtl92ce_deinit_sw_leds,
        .get_bbreg = rtl92c_phy_query_bb_reg,
        .set_bbreg = rtl92c_phy_set_bb_reg,
-        .get_rfreg = rtl92ce_phy_query_rf_reg,
        .set_rfreg = rtl92ce_phy_set_rf_reg,
-        .cmd_send_packet = _rtl92c_cmd_send_packet,
+        .get_rfreg = rtl92c_phy_query_rf_reg,
        .phy_rf6052_config = rtl92ce_phy_rf6052_config,
        .phy_rf6052_set_cck_txpower = rtl92ce_phy_rf6052_set_cck_txpower,
        .phy_rf6052_set_ofdm_txpower = rtl92ce_phy_rf6052_set_ofdm_txpower,
        .config_bb_with_headerfile = _rtl92ce_phy_config_bb_with_headerfile,
        .config_bb_with_pgheaderfile = _rtl92ce_phy_config_bb_with_pgheaderfile,
        .phy_lc_calibrate = _rtl92ce_phy_lc_calibrate,
-        .phy_set_bw_mode_callback = rtl92ce_phy_set_bw_mode_callback,
        .dm_dynamic_txpower = rtl92ce_dm_dynamic_txpower,
 };
 static struct rtl_mod_params rtl92ce_mod_params = {
-        .sw_crypto = 0,
+        .sw_crypto = false,
+        .inactiveps = true,
+        .swctrl_lps = false,
+        .fwctrl_lps = true,
 };
 static struct rtl_hal_cfg rtl92ce_hal_cfg = {
+        .bar_id = 2,
+        .write_readback = true,
        .name = "rtl92c_pci",
        .fw_name = "rtlwifi/rtl8192cfw.bin",
        .ops = &rtl8192ce_hal_ops,
@@ -175,6 +268,8 @@ static struct rtl_hal_cfg rtl92ce_hal_cfg = {
        .maps[EFUSE_LOADER_CLK_EN] = LOADER_CLK_EN,
        .maps[EFUSE_ANA8M] = EFUSE_ANA8M,
        .maps[EFUSE_HWSET_MAX_SIZE] = HWSET_MAX_SIZE,
+        .maps[EFUSE_MAX_SECTION_MAP] = EFUSE_MAX_SECTION,
+        .maps[EFUSE_REAL_CONTENT_SIZE] = EFUSE_REAL_CONTENT_LEN,
        .maps[RWCAM] = REG_CAMCMD,
        .maps[WCAMI] = REG_CAMWRITE,
@@ -239,7 +334,7 @@ static struct rtl_hal_cfg rtl92ce_hal_cfg = {
        .maps[RTL_RC_HT_RATEMCS15] = DESC92C_RATEMCS15,
 };
-static struct pci_device_id rtl92ce_pci_ids[] __devinitdata = {
+DEFINE_PCI_DEVICE_TABLE(rtl92ce_pci_ids) = {
        {RTL_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8191, rtl92ce_hal_cfg)},
        {RTL_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8178, rtl92ce_hal_cfg)},
        {RTL_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8177, rtl92ce_hal_cfg)},
@@ -257,7 +352,13 @@ MODULE_DESCRIPTION("Realtek 8192C/8188C 802.11n PCI wireless");
 MODULE_FIRMWARE("rtlwifi/rtl8192cfw.bin");
 module_param_named(swenc, rtl92ce_mod_params.sw_crypto, bool, 0444);
+module_param_named(ips, rtl92ce_mod_params.inactiveps, bool, 0444);
+module_param_named(swlps, rtl92ce_mod_params.swctrl_lps, bool, 0444);
+module_param_named(fwlps, rtl92ce_mod_params.fwctrl_lps, bool, 0444);
 MODULE_PARM_DESC(swenc, "using hardware crypto (default 0 [hardware])\n");
+MODULE_PARM_DESC(ips, "using no link power save (default 1 is open)\n");
+MODULE_PARM_DESC(fwlps, "using linked fw control power save "
+                 "(default 1 is open)\n");
 static struct pci_driver rtl92ce_driver = {
        .name = KBUILD_MODNAME,
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/sw.h b/drivers/net/wireless/rtlwifi/rtl8192ce/sw.h
index 36e657668c1e..b7dc3263e433 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/sw.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/sw.h
@@ -33,19 +33,9 @@
 int rtl92c_init_sw_vars(struct ieee80211_hw *hw);
 void rtl92c_deinit_sw_vars(struct ieee80211_hw *hw);
 void rtl92c_init_var_map(struct ieee80211_hw *hw);
-bool _rtl92c_cmd_send_packet(struct ieee80211_hw *hw,
-                             struct sk_buff *skb);
-void rtl92ce_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
-                                        u8 *ppowerlevel);
-void rtl92ce_phy_rf6052_set_ofdm_txpower(struct ieee80211_hw *hw,
-                                         u8 *ppowerlevel, u8 channel);
 bool _rtl92ce_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
-                                                  u8 configtype);
+                                            u8 configtype);
 bool _rtl92ce_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw,
-                                                    u8 configtype);
+                                              u8 configtype);
-void _rtl92ce_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t);
-u32 rtl92ce_phy_query_rf_reg(struct ieee80211_hw *hw,
-                            enum radio_path rfpath, u32 regaddr, u32 bitmask);
-void rtl92ce_phy_set_bw_mode_callback(struct ieee80211_hw *hw);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
index aa2b5815600f..54b2bd53d36a 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
@@ -36,42 +36,16 @@
 #include "trx.h"
 #include "led.h"
-static enum rtl_desc_qsel _rtl92ce_map_hwqueue_to_fwqueue(__le16 fc,
+static u8 _rtl92ce_map_hwqueue_to_fwqueue(struct sk_buff *skb, u8 hw_queue)
-                                                          unsigned int
-                                                          skb_queue)
 {
-        enum rtl_desc_qsel qsel;
+        __le16 fc = rtl_get_fc(skb);
-        if (unlikely(ieee80211_is_beacon(fc))) {
+        if (unlikely(ieee80211_is_beacon(fc)))
-                qsel = QSLT_BEACON;
+                return QSLT_BEACON;
-                return qsel;
+        if (ieee80211_is_mgmt(fc))
-        }
+                return QSLT_MGNT;
-        if (ieee80211_is_mgmt(fc)) {
-                qsel = QSLT_MGNT;
-                return qsel;
-        }
-        switch (skb_queue) {
+        return skb->priority;
-        case VO_QUEUE:
-                qsel = QSLT_VO;
-                break;
-        case VI_QUEUE:
-                qsel = QSLT_VI;
-                break;
-        case BE_QUEUE:
-                qsel = QSLT_BE;
-                break;
-        case BK_QUEUE:
-                qsel = QSLT_BK;
-                break;
-        default:
-                qsel = QSLT_BE;
-                RT_ASSERT(false, ("BE queue, skb_queue:%d,"
-                                  " set qsel = 0x%X\n", skb_queue, QSLT_BE));
-                break;
-        }
-        return qsel;
 }
 static int _rtl92ce_rate_mapping(bool isht, u8 desc_rate, bool first_ampdu)
@@ -255,6 +229,7 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
        u8 evm, pwdb_all, rf_rx_num = 0;
        u8 i, max_spatial_stream;
        u32 rssi, total_rssi = 0;
+        bool in_powersavemode = false;
        bool is_cck_rate;
        is_cck_rate = RX_HAL_IS_CCK_RATE(pdesc);
@@ -270,9 +245,13 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
                u8 report, cck_highpwr;
                cck_buf = (struct phy_sts_cck_8192s_t *)p_drvinfo;
-                cck_highpwr = (u8) rtl_get_bbreg(hw,
+                if (!in_powersavemode)
-                                         RFPGA0_XA_HSSIPARAMETER2,
+                        cck_highpwr = (u8) rtl_get_bbreg(hw,
-                                         BIT(9));
+                                                 RFPGA0_XA_HSSIPARAMETER2,
+                                                 BIT(9));
+                else
+                        cck_highpwr = false;
                if (!cck_highpwr) {
                        u8 cck_agc_rpt = cck_buf->cck_agc_rpt;
                        report = cck_buf->cck_agc_rpt & 0xc0;
@@ -398,6 +377,7 @@ static void _rtl92ce_process_ui_rssi(struct ieee80211_hw *hw,
                if (rtlpriv->stats.ui_rssi.total_num++ >=
                    PHY_RSSI_SLID_WIN_MAX) {
                        rtlpriv->stats.ui_rssi.total_num =
                            PHY_RSSI_SLID_WIN_MAX;
                        last_rssi =
@@ -424,10 +404,6 @@ static void _rtl92ce_process_ui_rssi(struct ieee80211_hw *hw,
        if (!pstats->is_cck && pstats->packet_toself) {
                for (rfpath = RF90_PATH_A; rfpath < rtlphy->num_total_rfpath;
                     rfpath++) {
-                        if (!rtl8192_phy_check_is_legal_rfpath(hw, rfpath))
-                                continue;
                        if (rtlpriv->stats.rx_rssi_percentage[rfpath] == 0) {
                                rtlpriv->stats.rx_rssi_percentage[rfpath] =
                                    pstats->rx_mimo_signalstrength[rfpath];
@@ -723,7 +699,7 @@ bool rtl92ce_rx_query_desc(struct ieee80211_hw *hw,
 void rtl92ce_tx_fill_desc(struct ieee80211_hw *hw,
                          struct ieee80211_hdr *hdr, u8 *pdesc_tx,
                          struct ieee80211_tx_info *info, struct sk_buff *skb,
-                          unsigned int queue_index)
+                          u8 hw_queue, struct rtl_tcb_desc *tcb_desc)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
@@ -732,16 +708,9 @@ void rtl92ce_tx_fill_desc(struct ieee80211_hw *hw,
        bool defaultadapter = true;
        struct ieee80211_sta *sta;
        u8 *pdesc = (u8 *) pdesc_tx;
-        struct rtl_tcb_desc tcb_desc;
-        u8 *qc = ieee80211_get_qos_ctl(hdr);
-        u8 tid = qc[0] & IEEE80211_QOS_CTL_TID_MASK;
        u16 seq_number;
        __le16 fc = hdr->frame_control;
-        u8 rate_flag = info->control.rates[0].flags;
+        u8 fw_qsel = _rtl92ce_map_hwqueue_to_fwqueue(skb, hw_queue);
-        enum rtl_desc_qsel fw_qsel =
-            _rtl92ce_map_hwqueue_to_fwqueue(fc, queue_index);
        bool firstseg = ((hdr->seq_ctrl &
                          cpu_to_le16(IEEE80211_SCTL_FRAG)) == 0);
@@ -751,56 +720,68 @@ void rtl92ce_tx_fill_desc(struct ieee80211_hw *hw,
        dma_addr_t mapping = pci_map_single(rtlpci->pdev,
                                            skb->data, skb->len,
                                            PCI_DMA_TODEVICE);
+        u8 bw_40 = 0;
+        rcu_read_lock();
+        sta = get_sta(hw, mac->vif, mac->bssid);
+        if (mac->opmode == NL80211_IFTYPE_STATION) {
+                bw_40 = mac->bw_40;
+        } else if (mac->opmode == NL80211_IFTYPE_AP ||
+                mac->opmode == NL80211_IFTYPE_ADHOC) {
+                if (sta)
+                        bw_40 = sta->ht_cap.cap &
+                                IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+        }
        seq_number = (le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_SEQ) >> 4;
-        rtl_get_tcb_desc(hw, info, skb, &tcb_desc);
+        rtl_get_tcb_desc(hw, info, sta, skb, tcb_desc);
        CLEAR_PCI_TX_DESC_CONTENT(pdesc, sizeof(struct tx_desc_92c));
+        if (ieee80211_is_nullfunc(fc) || ieee80211_is_ctl(fc)) {
+                firstseg = true;
+                lastseg = true;
+        }
        if (firstseg) {
                SET_TX_DESC_OFFSET(pdesc, USB_HWDESC_HEADER_LEN);
-                SET_TX_DESC_TX_RATE(pdesc, tcb_desc.hw_rate);
+                SET_TX_DESC_TX_RATE(pdesc, tcb_desc->hw_rate);
-                if (tcb_desc.use_shortgi || tcb_desc.use_shortpreamble)
+                if (tcb_desc->use_shortgi || tcb_desc->use_shortpreamble)
                        SET_TX_DESC_DATA_SHORTGI(pdesc, 1);
-                if (mac->tids[tid].agg.agg_state == RTL_AGG_ON &&
+                if (info->flags & IEEE80211_TX_CTL_AMPDU) {
-                    info->flags & IEEE80211_TX_CTL_AMPDU) {
                        SET_TX_DESC_AGG_BREAK(pdesc, 1);
                        SET_TX_DESC_MAX_AGG_NUM(pdesc, 0x14);
                }
                SET_TX_DESC_SEQ(pdesc, seq_number);
-                SET_TX_DESC_RTS_ENABLE(pdesc, ((tcb_desc.rts_enable &&
+                SET_TX_DESC_RTS_ENABLE(pdesc, ((tcb_desc->rts_enable &&
-                                                !tcb_desc.
+                                                !tcb_desc->
                                                cts_enable) ? 1 : 0));
                SET_TX_DESC_HW_RTS_ENABLE(pdesc,
-                                          ((tcb_desc.rts_enable
+                                          ((tcb_desc->rts_enable
-                                            || tcb_desc.cts_enable) ? 1 : 0));
+                                            || tcb_desc->cts_enable) ? 1 : 0));
-                SET_TX_DESC_CTS2SELF(pdesc, ((tcb_desc.cts_enable) ? 1 : 0));
+                SET_TX_DESC_CTS2SELF(pdesc, ((tcb_desc->cts_enable) ? 1 : 0));
-                SET_TX_DESC_RTS_STBC(pdesc, ((tcb_desc.rts_stbc) ? 1 : 0));
+                SET_TX_DESC_RTS_STBC(pdesc, ((tcb_desc->rts_stbc) ? 1 : 0));
-                SET_TX_DESC_RTS_RATE(pdesc, tcb_desc.rts_rate);
+                SET_TX_DESC_RTS_RATE(pdesc, tcb_desc->rts_rate);
                SET_TX_DESC_RTS_BW(pdesc, 0);
-                SET_TX_DESC_RTS_SC(pdesc, tcb_desc.rts_sc);
+                SET_TX_DESC_RTS_SC(pdesc, tcb_desc->rts_sc);
                SET_TX_DESC_RTS_SHORT(pdesc,
-                                      ((tcb_desc.rts_rate <= DESC92C_RATE54M) ?
+                                      ((tcb_desc->rts_rate <= DESC92C_RATE54M) ?
-                                      (tcb_desc.rts_use_shortpreamble ? 1 : 0)
+                                       (tcb_desc->rts_use_shortpreamble ? 1 : 0)
-                                      : (tcb_desc.rts_use_shortgi ? 1 : 0)));
+                                       : (tcb_desc->rts_use_shortgi ? 1 : 0)));
-                if (mac->bw_40) {
+                if (bw_40) {
-                        if (tcb_desc.packet_bw) {
+                        if (tcb_desc->packet_bw) {
                                SET_TX_DESC_DATA_BW(pdesc, 1);
                                SET_TX_DESC_TX_SUB_CARRIER(pdesc, 3);
                        } else {
                                SET_TX_DESC_DATA_BW(pdesc, 0);
+                                SET_TX_DESC_TX_SUB_CARRIER(pdesc,
-                                if (rate_flag & IEEE80211_TX_RC_DUP_DATA) {
+                                                 mac->cur_40_prime_sc);
-                                        SET_TX_DESC_TX_SUB_CARRIER(pdesc,
-                                                        mac->cur_40_prime_sc);
-                                }
                        }
                } else {
                        SET_TX_DESC_DATA_BW(pdesc, 0);
@@ -810,13 +791,10 @@ void rtl92ce_tx_fill_desc(struct ieee80211_hw *hw,
                SET_TX_DESC_LINIP(pdesc, 0);
                SET_TX_DESC_PKT_SIZE(pdesc, (u16) skb->len);
-                rcu_read_lock();
-                sta = ieee80211_find_sta(mac->vif, mac->bssid);
                if (sta) {
                        u8 ampdu_density = sta->ht_cap.ampdu_density;
                        SET_TX_DESC_AMPDU_DENSITY(pdesc, ampdu_density);
                }
-                rcu_read_unlock();
                if (info->control.hw_key) {
                        struct ieee80211_key_conf *keyconf =
@@ -844,7 +822,7 @@ void rtl92ce_tx_fill_desc(struct ieee80211_hw *hw,
                SET_TX_DESC_DATA_RATE_FB_LIMIT(pdesc, 0x1F);
                SET_TX_DESC_RTS_RATE_FB_LIMIT(pdesc, 0xF);
                SET_TX_DESC_DISABLE_FB(pdesc, 0);
-                SET_TX_DESC_USE_RATE(pdesc, tcb_desc.use_driver_rate ? 1 : 0);
+                SET_TX_DESC_USE_RATE(pdesc, tcb_desc->use_driver_rate ? 1 : 0);
                if (ieee80211_is_data_qos(fc)) {
                        if (mac->rdg_en) {
@@ -855,24 +833,24 @@ void rtl92ce_tx_fill_desc(struct ieee80211_hw *hw,
                        }
                }
        }
+        rcu_read_unlock();
        SET_TX_DESC_FIRST_SEG(pdesc, (firstseg ? 1 : 0));
        SET_TX_DESC_LAST_SEG(pdesc, (lastseg ? 1 : 0));
        SET_TX_DESC_TX_BUFFER_SIZE(pdesc, (u16) skb->len);
-        SET_TX_DESC_TX_BUFFER_ADDRESS(pdesc, cpu_to_le32(mapping));
+        SET_TX_DESC_TX_BUFFER_ADDRESS(pdesc, mapping);
        if (rtlpriv->dm.useramask) {
-                SET_TX_DESC_RATE_ID(pdesc, tcb_desc.ratr_index);
+                SET_TX_DESC_RATE_ID(pdesc, tcb_desc->ratr_index);
-                SET_TX_DESC_MACID(pdesc, tcb_desc.mac_id);
+                SET_TX_DESC_MACID(pdesc, tcb_desc->mac_id);
        } else {
-                SET_TX_DESC_RATE_ID(pdesc, 0xC + tcb_desc.ratr_index);
+                SET_TX_DESC_RATE_ID(pdesc, 0xC + tcb_desc->ratr_index);
-                SET_TX_DESC_MACID(pdesc, tcb_desc.ratr_index);
+                SET_TX_DESC_MACID(pdesc, tcb_desc->ratr_index);
        }
-        if ((!ieee80211_is_data_qos(fc)) && ppsc->leisure_ps &&
+        if ((!ieee80211_is_data_qos(fc)) && ppsc->fwctrl_lps) {
-            ppsc->fwctrl_lps) {
                SET_TX_DESC_HWSEQ_EN(pdesc, 1);
                SET_TX_DESC_PKT_ID(pdesc, 8);
@@ -923,7 +901,7 @@ void rtl92ce_tx_fill_cmddesc(struct ieee80211_hw *hw,
        SET_TX_DESC_TX_BUFFER_SIZE(pdesc, (u16) (skb->len));
-        SET_TX_DESC_TX_BUFFER_ADDRESS(pdesc, cpu_to_le32(mapping));
+        SET_TX_DESC_TX_BUFFER_ADDRESS(pdesc, mapping);
        SET_TX_DESC_RATE_ID(pdesc, 7);
        SET_TX_DESC_MACID(pdesc, 0);
@@ -1021,7 +999,7 @@ u32 rtl92ce_get_desc(u8 *p_desc, bool istx, u8 desc_name)
        return ret;
 }
-void rtl92ce_tx_polling(struct ieee80211_hw *hw, unsigned int hw_queue)
+void rtl92ce_tx_polling(struct ieee80211_hw *hw, u8 hw_queue)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        if (hw_queue == BEACON_QUEUE) {
@@ -1032,35 +1010,3 @@ void rtl92ce_tx_polling(struct ieee80211_hw *hw, unsigned int hw_queue)
        }
 }
-bool _rtl92c_cmd_send_packet(struct ieee80211_hw *hw,
-                             struct sk_buff *skb)
-{
-        struct rtl_priv *rtlpriv = rtl_priv(hw);
-        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
-        struct rtl8192_tx_ring *ring;
-        struct rtl_tx_desc *pdesc;
-        u8 own;
-        unsigned long flags;
-        struct sk_buff *pskb = NULL;
-        ring = &rtlpci->tx_ring[BEACON_QUEUE];
-        spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
-        pskb = __skb_dequeue(&ring->queue);
-        if (pskb)
-                kfree_skb(pskb);
-        pdesc = &ring->desc[0];
-        own = (u8) rtlpriv->cfg->ops->get_desc((u8 *) pdesc, true, HW_DESC_OWN);
-        rtlpriv->cfg->ops->fill_tx_cmddesc(hw, (u8 *) pdesc, 1, 1, skb);
-        __skb_queue_tail(&ring->queue, skb);
-        spin_unlock_irqrestore(&rtlpriv->locks.irq_th_lock, flags);
-        rtlpriv->cfg->ops->tx_polling(hw, BEACON_QUEUE);
-        return true;
-}
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.h b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.h
index 803adcc80c96..0f1177137501 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.h
@@ -532,9 +532,9 @@
 #define CLEAR_PCI_TX_DESC_CONTENT(__pdesc, _size)       \
 do {                                                    \
        if (_size > TX_DESC_NEXT_DESC_OFFSET)           \
-                memset((void *)__pdesc, 0, TX_DESC_NEXT_DESC_OFFSET);   \
+                memset(__pdesc, 0, TX_DESC_NEXT_DESC_OFFSET);   \
        else                                            \
-                memset((void *)__pdesc, 0, _size);      \
+                memset(__pdesc, 0, _size);      \
 } while (0);
 #define RX_HAL_IS_CCK_RATE(_pdesc)\
@@ -724,17 +724,16 @@ struct rx_desc_92c {
 void rtl92ce_tx_fill_desc(struct ieee80211_hw *hw,
                          struct ieee80211_hdr *hdr,
                          u8 *pdesc, struct ieee80211_tx_info *info,
-                          struct sk_buff *skb, unsigned int qsel);
+                          struct sk_buff *skb, u8 hw_queue,
+                          struct rtl_tcb_desc *ptcb_desc);
 bool rtl92ce_rx_query_desc(struct ieee80211_hw *hw,
                           struct rtl_stats *stats,
                           struct ieee80211_rx_status *rx_status,
                           u8 *pdesc, struct sk_buff *skb);
 void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val);
 u32 rtl92ce_get_desc(u8 *pdesc, bool istx, u8 desc_name);
-void rtl92ce_tx_polling(struct ieee80211_hw *hw, unsigned int hw_queue);
+void rtl92ce_tx_polling(struct ieee80211_hw *hw, u8 hw_queue);
 void rtl92ce_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc,
                             bool b_firstseg, bool b_lastseg,
                             struct sk_buff *skb);
-bool _rtl92c_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
index 9444e76838cf..52e2af58c1ed 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -39,6 +39,7 @@
 #include "mac.h"
 #include "dm.h"
 #include "hw.h"
+#include "../rtl8192ce/hw.h"
 #include "trx.h"
 #include "led.h"
 #include "table.h"
@@ -605,10 +606,10 @@ void rtl92cu_read_eeprom_info(struct ieee80211_hw *hw)
        if (!IS_NORMAL_CHIP(rtlhal->version))
                return;
        tmp_u1b = rtl_read_byte(rtlpriv, REG_9346CR);
-        rtlefuse->epromtype = (tmp_u1b & EEPROMSEL) ?
+        rtlefuse->epromtype = (tmp_u1b & BOOT_FROM_EEPROM) ?
                               EEPROM_93C46 : EEPROM_BOOT_EFUSE;
        RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG, ("Boot from %s\n",
-                 (tmp_u1b & EEPROMSEL) ? "EERROM" : "EFUSE"));
+                 (tmp_u1b & BOOT_FROM_EEPROM) ? "EERROM" : "EFUSE"));
        rtlefuse->autoload_failflag = (tmp_u1b & EEPROM_EN) ? false : true;
        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, ("Autoload %s\n",
                 (tmp_u1b & EEPROM_EN) ? "OK!!" : "ERR!!"));
@@ -921,7 +922,7 @@ static void _rtl92cu_init_chipT_queue_priority(struct ieee80211_hw *hw,
                                               u8 out_ep_num,
                                               u8 queue_sel)
 {
-        u8      hq_sele;
+        u8 hq_sele = 0;
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        switch (out_ep_num) {
@@ -977,7 +978,7 @@ static void _rtl92cu_init_wmac_setting(struct ieee80211_hw *hw)
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
-        mac->rx_conf = (RCR_APM | RCR_AM | RCR_ADF | RCR_AB | RCR_APP_FCS |
+        mac->rx_conf = (RCR_APM | RCR_AM | RCR_ADF | RCR_AB | RCR_APPFCS |
                      RCR_APP_ICV | RCR_AMF | RCR_HTC_LOC_CTRL |
                      RCR_APP_MIC | RCR_APP_PHYSTS | RCR_ACRC32);
        rtl_write_dword(rtlpriv, REG_RCR, mac->rx_conf);
@@ -2182,7 +2183,9 @@ void rtl92cu_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
        }
 }
-void rtl92cu_update_hal_rate_table(struct ieee80211_hw *hw)
+void rtl92cu_update_hal_rate_table(struct ieee80211_hw *hw,
+                                   struct ieee80211_sta *sta,
+                                   u8 rssi_level)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h
index 62af555bb61c..32f85cba106a 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h
@@ -98,13 +98,14 @@ void rtl92cu_update_interrupt_mask(struct ieee80211_hw *hw,
                                   u32 add_msr, u32 rm_msr);
 void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val);
 void rtl92cu_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val);
-void rtl92cu_update_hal_rate_table(struct ieee80211_hw *hw);
+void rtl92cu_update_hal_rate_table(struct ieee80211_hw *hw,
+                                   struct ieee80211_sta *sta,
+                                   u8 rssi_level);
 void rtl92cu_update_hal_rate_mask(struct ieee80211_hw *hw, u8 rssi_level);
 void rtl92cu_update_channel_access_setting(struct ieee80211_hw *hw);
 bool rtl92cu_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 * valid);
 void rtl92cu_set_check_bssid(struct ieee80211_hw *hw, bool check_bssid);
-u8 _rtl92c_get_chnl_group(u8 chnl);
 int rtl92c_download_fw(struct ieee80211_hw *hw);
 void rtl92c_set_fw_pwrmode_cmd(struct ieee80211_hw *hw, u8 mode);
 void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool dl_finished);
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c
index 4e020e654e6b..9a3d0239e27e 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c
@@ -38,7 +38,7 @@
 #include "table.h"
 u32 rtl92cu_phy_query_rf_reg(struct ieee80211_hw *hw,
-                            enum radio_path rfpath, u32 regaddr, u32 bitmask)
+                             enum radio_path rfpath, u32 regaddr, u32 bitmask)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        u32 original_value, readback_value, bitshift;
@@ -64,8 +64,8 @@ u32 rtl92cu_phy_query_rf_reg(struct ieee80211_hw *hw,
 }
 void rtl92cu_phy_set_rf_reg(struct ieee80211_hw *hw,
-                           enum radio_path rfpath,
+                            enum radio_path rfpath,
-                           u32 regaddr, u32 bitmask, u32 data)
+                            u32 regaddr, u32 bitmask, u32 data)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
@@ -163,7 +163,7 @@ bool _rtl92cu_phy_config_mac_with_headerfile(struct ieee80211_hw *hw)
 }
 bool _rtl92cu_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
-                                                  u8 configtype)
+                                            u8 configtype)
 {
        int i;
        u32 *phy_regarray_table;
@@ -223,7 +223,7 @@ bool _rtl92cu_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
 }
 bool _rtl92cu_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw,
-                                                    u8 configtype)
+                                              u8 configtype)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
@@ -459,7 +459,7 @@ void _rtl92cu_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t)
        }
 }
-bool _rtl92cu_phy_set_rf_power_state(struct ieee80211_hw *hw,
+static bool _rtl92cu_phy_set_rf_power_state(struct ieee80211_hw *hw,
                                            enum rf_pwrstate rfpwr_state)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
@@ -595,7 +595,7 @@ bool _rtl92cu_phy_set_rf_power_state(struct ieee80211_hw *hw,
 }
 bool rtl92cu_phy_set_rf_power_state(struct ieee80211_hw *hw,
-                                   enum rf_pwrstate rfpwr_state)
+                                    enum rf_pwrstate rfpwr_state)
 {
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
        bool bresult = false;
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.h b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.h
index 06299559ab68..ff81a61729d7 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.h
@@ -34,3 +34,17 @@ bool rtl8192_phy_check_is_legal_rfpath(struct ieee80211_hw *hw, u32 rfpath);
 void rtl92c_phy_set_io(struct ieee80211_hw *hw);
 bool _rtl92cu_phy_config_mac_with_headerfile(struct ieee80211_hw *hw);
 bool rtl92cu_phy_bb_config(struct ieee80211_hw *hw);
+u32 rtl92cu_phy_query_rf_reg(struct ieee80211_hw *hw,
+                             enum radio_path rfpath, u32 regaddr, u32 bitmask);
+void rtl92cu_phy_set_rf_reg(struct ieee80211_hw *hw,
+                            enum radio_path rfpath,
+                            u32 regaddr, u32 bitmask, u32 data);
+bool rtl92cu_phy_mac_config(struct ieee80211_hw *hw);
+bool _rtl92cu_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw,
+                                              u8 configtype);
+void _rtl92cu_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t);
+bool _rtl92cu_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
+                                            u8 configtype);
+void rtl92cu_phy_set_bw_mode_callback(struct ieee80211_hw *hw);
+bool rtl92cu_phy_set_rf_power_state(struct ieee80211_hw *hw,
+                                    enum rf_pwrstate rfpwr_state);
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
index 1c79c226f145..c7576ec4744e 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
@@ -62,7 +62,7 @@ void rtl92cu_phy_rf6052_set_bandwidth(struct ieee80211_hw *hw, u8 bandwidth)
 }
 void rtl92cu_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
-                                       u8 *ppowerlevel)
+                                        u8 *ppowerlevel)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_phy *rtlphy = &(rtlpriv->phy);
@@ -389,7 +389,7 @@ static void _rtl92c_write_ofdm_power_reg(struct ieee80211_hw *hw,
 }
 void rtl92cu_phy_rf6052_set_ofdm_txpower(struct ieee80211_hw *hw,
-                                        u8 *ppowerlevel, u8 channel)
+                                         u8 *ppowerlevel, u8 channel)
 {
        u32 writeVal[2], powerBase0[2], powerBase1[2];
        u8 index = 0;
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.h b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.h
index 86c2728cfa00..500a2094b6bb 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.h
@@ -43,5 +43,9 @@ extern void rtl92c_phy_rf6052_set_ofdm_txpower(struct ieee80211_hw *hw,
 bool rtl92cu_phy_rf6052_config(struct ieee80211_hw *hw);
 bool rtl92cu_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
                                          enum radio_path rfpath);
+void rtl92cu_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
+                                        u8 *ppowerlevel);
+void rtl92cu_phy_rf6052_set_ofdm_txpower(struct ieee80211_hw *hw,
+                                         u8 *ppowerlevel, u8 channel);
 #endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
index 71244a38d49e..bee7c1480f63 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
@@ -94,7 +94,7 @@ static struct rtl_hal_ops rtl8192cu_hal_ops = {
        .update_interrupt_mask = rtl92cu_update_interrupt_mask,
        .get_hw_reg = rtl92cu_get_hw_reg,
        .set_hw_reg = rtl92cu_set_hw_reg,
-        .update_rate_table = rtl92cu_update_hal_rate_table,
+        .update_rate_tbl = rtl92cu_update_hal_rate_table,
        .update_rate_mask = rtl92cu_update_hal_rate_mask,
        .fill_tx_desc = rtl92cu_tx_fill_desc,
        .fill_fake_txdesc = rtl92cu_fill_fake_txdesc,
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c
index d0b0d43b9a6d..3a92ba3c4a1e 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c
@@ -372,7 +372,7 @@ static void _rtl_rx_process(struct ieee80211_hw *hw, struct sk_buff *skb)
        __le16 fc;
        struct ieee80211_hdr *hdr;
-        memset(rx_status, 0, sizeof(rx_status));
+        memset(rx_status, 0, sizeof(*rx_status));
        rxdesc  = skb->data;
        skb_len = skb->len;
        drvinfo_len = (GET_RX_DESC_DRVINFO_SIZE(rxdesc) * RTL_RX_DRV_INFO_UNIT);
@@ -434,7 +434,7 @@ static void _rtl_rx_process(struct ieee80211_hw *hw, struct sk_buff *skb)
                 "0x%02X\n", fc, (u32)hdr->addr1[0], (u32)hdr->addr1[1],
                 (u32)hdr->addr1[2], (u32)hdr->addr1[3], (u32)hdr->addr1[4],
                 (u32)hdr->addr1[5]));
-        memcpy(IEEE80211_SKB_RXCB(skb), &rx_status, sizeof(rx_status));
+        memcpy(IEEE80211_SKB_RXCB(skb), rx_status, sizeof(*rx_status));
        ieee80211_rx_irqsafe(hw, skb);
 }
@@ -498,14 +498,14 @@ static void _rtl_tx_desc_checksum(u8 *txdesc)
 void rtl92cu_tx_fill_desc(struct ieee80211_hw *hw,
                          struct ieee80211_hdr *hdr, u8 *pdesc_tx,
                          struct ieee80211_tx_info *info, struct sk_buff *skb,
-                          unsigned int queue_index)
+                          u8 queue_index,
+                          struct rtl_tcb_desc *tcb_desc)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
        bool defaultadapter = true;
-        struct ieee80211_sta *sta;
+        struct ieee80211_sta *sta = info->control.sta = info->control.sta;
-        struct rtl_tcb_desc tcb_desc;
        u8 *qc = ieee80211_get_qos_ctl(hdr);
        u8 tid = qc[0] & IEEE80211_QOS_CTL_TID_MASK;
        u16 seq_number;
@@ -517,15 +517,15 @@ void rtl92cu_tx_fill_desc(struct ieee80211_hw *hw,
        u8 *txdesc;
        seq_number = (le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_SEQ) >> 4;
-        rtl_get_tcb_desc(hw, info, skb, &tcb_desc);
+        rtl_get_tcb_desc(hw, info, sta, skb, tcb_desc);
        txdesc = (u8 *)skb_push(skb, RTL_TX_HEADER_SIZE);
        memset(txdesc, 0, RTL_TX_HEADER_SIZE);
        SET_TX_DESC_PKT_SIZE(txdesc, pktlen);
        SET_TX_DESC_LINIP(txdesc, 0);
        SET_TX_DESC_PKT_OFFSET(txdesc, RTL_DUMMY_OFFSET);
        SET_TX_DESC_OFFSET(txdesc, RTL_TX_HEADER_SIZE);
-        SET_TX_DESC_TX_RATE(txdesc, tcb_desc.hw_rate);
+        SET_TX_DESC_TX_RATE(txdesc, tcb_desc->hw_rate);
-        if (tcb_desc.use_shortgi || tcb_desc.use_shortpreamble)
+        if (tcb_desc->use_shortgi || tcb_desc->use_shortpreamble)
                SET_TX_DESC_DATA_SHORTGI(txdesc, 1);
        if (mac->tids[tid].agg.agg_state == RTL_AGG_ON &&
                    info->flags & IEEE80211_TX_CTL_AMPDU) {
@@ -535,21 +535,21 @@ void rtl92cu_tx_fill_desc(struct ieee80211_hw *hw,
                SET_TX_DESC_AGG_BREAK(txdesc, 1);
        }
        SET_TX_DESC_SEQ(txdesc, seq_number);
-        SET_TX_DESC_RTS_ENABLE(txdesc, ((tcb_desc.rts_enable &&
+        SET_TX_DESC_RTS_ENABLE(txdesc, ((tcb_desc->rts_enable &&
-                               !tcb_desc.cts_enable) ? 1 : 0));
+                               !tcb_desc->cts_enable) ? 1 : 0));
-        SET_TX_DESC_HW_RTS_ENABLE(txdesc, ((tcb_desc.rts_enable ||
+        SET_TX_DESC_HW_RTS_ENABLE(txdesc, ((tcb_desc->rts_enable ||
-                                  tcb_desc.cts_enable) ? 1 : 0));
+                                  tcb_desc->cts_enable) ? 1 : 0));
-        SET_TX_DESC_CTS2SELF(txdesc, ((tcb_desc.cts_enable) ? 1 : 0));
+        SET_TX_DESC_CTS2SELF(txdesc, ((tcb_desc->cts_enable) ? 1 : 0));
-        SET_TX_DESC_RTS_STBC(txdesc, ((tcb_desc.rts_stbc) ? 1 : 0));
+        SET_TX_DESC_RTS_STBC(txdesc, ((tcb_desc->rts_stbc) ? 1 : 0));
-        SET_TX_DESC_RTS_RATE(txdesc, tcb_desc.rts_rate);
+        SET_TX_DESC_RTS_RATE(txdesc, tcb_desc->rts_rate);
        SET_TX_DESC_RTS_BW(txdesc, 0);
-        SET_TX_DESC_RTS_SC(txdesc, tcb_desc.rts_sc);
+        SET_TX_DESC_RTS_SC(txdesc, tcb_desc->rts_sc);
        SET_TX_DESC_RTS_SHORT(txdesc,
-                              ((tcb_desc.rts_rate <= DESC92C_RATE54M) ?
+                              ((tcb_desc->rts_rate <= DESC92C_RATE54M) ?
-                               (tcb_desc.rts_use_shortpreamble ? 1 : 0)
+                               (tcb_desc->rts_use_shortpreamble ? 1 : 0)
-                               : (tcb_desc.rts_use_shortgi ? 1 : 0)));
+                               : (tcb_desc->rts_use_shortgi ? 1 : 0)));
        if (mac->bw_40) {
-                if (tcb_desc.packet_bw) {
+                if (tcb_desc->packet_bw) {
                        SET_TX_DESC_DATA_BW(txdesc, 1);
                        SET_TX_DESC_DATA_SC(txdesc, 3);
                } else {
@@ -590,7 +590,7 @@ void rtl92cu_tx_fill_desc(struct ieee80211_hw *hw,
        SET_TX_DESC_DATA_RATE_FB_LIMIT(txdesc, 0x1F);
        SET_TX_DESC_RTS_RATE_FB_LIMIT(txdesc, 0xF);
        SET_TX_DESC_DISABLE_FB(txdesc, 0);
-        SET_TX_DESC_USE_RATE(txdesc, tcb_desc.use_driver_rate ? 1 : 0);
+        SET_TX_DESC_USE_RATE(txdesc, tcb_desc->use_driver_rate ? 1 : 0);
        if (ieee80211_is_data_qos(fc)) {
                if (mac->rdg_en) {
                        RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
@@ -600,11 +600,11 @@ void rtl92cu_tx_fill_desc(struct ieee80211_hw *hw,
                }
        }
        if (rtlpriv->dm.useramask) {
-                SET_TX_DESC_RATE_ID(txdesc, tcb_desc.ratr_index);
+                SET_TX_DESC_RATE_ID(txdesc, tcb_desc->ratr_index);
-                SET_TX_DESC_MACID(txdesc, tcb_desc.mac_id);
+                SET_TX_DESC_MACID(txdesc, tcb_desc->mac_id);
        } else {
-                SET_TX_DESC_RATE_ID(txdesc, 0xC + tcb_desc.ratr_index);
+                SET_TX_DESC_RATE_ID(txdesc, 0xC + tcb_desc->ratr_index);
-                SET_TX_DESC_MACID(txdesc, tcb_desc.ratr_index);
+                SET_TX_DESC_MACID(txdesc, tcb_desc->ratr_index);
        }
        if ((!ieee80211_is_data_qos(fc)) && ppsc->leisure_ps &&
              ppsc->fwctrl_lps) {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.h b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.h
index b396d46edbb7..53de5f66e242 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.h
@@ -37,6 +37,8 @@
 #define RTL92C_SIZE_MAX_RX_BUFFER               15360   /* 8192 */
 #define RX_DRV_INFO_SIZE_UNIT                   8
+#define RTL_AGG_ON                              1
 enum usb_rx_agg_mode {
        USB_RX_AGG_DISABLE,
        USB_RX_AGG_DMA,
@@ -419,7 +421,8 @@ struct sk_buff *rtl8192c_tx_aggregate_hdl(struct ieee80211_hw *,
 void rtl92cu_tx_fill_desc(struct ieee80211_hw *hw,
                          struct ieee80211_hdr *hdr, u8 *pdesc_tx,
                          struct ieee80211_tx_info *info, struct sk_buff *skb,
-                          unsigned int queue_index);
+                          u8 queue_index,
+                          struct rtl_tcb_desc *tcb_desc);
 void rtl92cu_fill_fake_txdesc(struct ieee80211_hw *hw, u8 * pDesc,
                              u32 buffer_len, bool bIsPsPoll);
 void rtl92cu_tx_fill_cmddesc(struct ieee80211_hw *hw,
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/Makefile b/drivers/net/wireless/rtlwifi/rtl8192se/Makefile
new file mode 100644
index 000000000000..b7eb13819cbc
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/Makefile
@@ -0,0 +1,15 @@
+rtl8192se-objs :=               \
+                dm.o            \
+                fw.o            \
+                hw.o            \
+                led.o           \
+                phy.o           \
+                rf.o            \
+                sw.o            \
+                table.o         \
+                trx.o
+obj-$(CONFIG_RTL8192SE) += rtl8192se.o
+ccflags-y += -D__CHECK_ENDIAN__
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/def.h b/drivers/net/wireless/rtlwifi/rtl8192se/def.h
new file mode 100644
index 000000000000..69828f2b3fab
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/def.h
@@ -0,0 +1,598 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#ifndef __REALTEK_92S_DEF_H__
+#define __REALTEK_92S_DEF_H__
+#define RX_MPDU_QUEUE                           0
+#define RX_CMD_QUEUE                            1
+#define RX_MAX_QUEUE                            2
+#define DESC92S_RATE1M                          0x00
+#define DESC92S_RATE2M                          0x01
+#define DESC92S_RATE5_5M                        0x02
+#define DESC92S_RATE11M                         0x03
+#define DESC92S_RATE6M                          0x04
+#define DESC92S_RATE9M                          0x05
+#define DESC92S_RATE12M                         0x06
+#define DESC92S_RATE18M                         0x07
+#define DESC92S_RATE24M                         0x08
+#define DESC92S_RATE36M                         0x09
+#define DESC92S_RATE48M                         0x0a
+#define DESC92S_RATE54M                         0x0b
+#define DESC92S_RATEMCS0                        0x0c
+#define DESC92S_RATEMCS1                        0x0d
+#define DESC92S_RATEMCS2                        0x0e
+#define DESC92S_RATEMCS3                        0x0f
+#define DESC92S_RATEMCS4                        0x10
+#define DESC92S_RATEMCS5                        0x11
+#define DESC92S_RATEMCS6                        0x12
+#define DESC92S_RATEMCS7                        0x13
+#define DESC92S_RATEMCS8                        0x14
+#define DESC92S_RATEMCS9                        0x15
+#define DESC92S_RATEMCS10                       0x16
+#define DESC92S_RATEMCS11                       0x17
+#define DESC92S_RATEMCS12                       0x18
+#define DESC92S_RATEMCS13                       0x19
+#define DESC92S_RATEMCS14                       0x1a
+#define DESC92S_RATEMCS15                       0x1b
+#define DESC92S_RATEMCS15_SG                    0x1c
+#define DESC92S_RATEMCS32                       0x20
+#define SHORT_SLOT_TIME                         9
+#define NON_SHORT_SLOT_TIME                     20
+/* Rx smooth factor */
+#define RX_SMOOTH_FACTOR                        20
+/* Queue Select Value in TxDesc */
+#define QSLT_BK                                 0x2
+#define QSLT_BE                                 0x0
+#define QSLT_VI                                 0x5
+#define QSLT_VO                                 0x6
+#define QSLT_BEACON                             0x10
+#define QSLT_HIGH                               0x11
+#define QSLT_MGNT                               0x12
+#define QSLT_CMD                                0x13
+#define PHY_RSSI_SLID_WIN_MAX                   100
+#define PHY_LINKQUALITY_SLID_WIN_MAX            20
+#define PHY_BEACON_RSSI_SLID_WIN_MAX            10
+/* Tx Desc */
+#define TX_DESC_SIZE_RTL8192S                   (16 * 4)
+#define TX_CMDDESC_SIZE_RTL8192S                (16 * 4)
+/* Define a macro that takes a le32 word, converts it to host ordering,
+ * right shifts by a specified count, creates a mask of the specified
+ * bit count, and extracts that number of bits.
+ */
+#define SHIFT_AND_MASK_LE(__pdesc, __shift, __mask)             \
+        ((le32_to_cpu(*(((__le32 *)(__pdesc)))) >> (__shift)) & \
+        BIT_LEN_MASK_32(__mask))
+/* Define a macro that clears a bit field in an le32 word and
+ * sets the specified value into that bit field. The resulting
+ * value remains in le32 ordering; however, it is properly converted
+ * to host ordering for the clear and set operations before conversion
+ * back to le32.
+ */
+#define SET_BITS_OFFSET_LE(__pdesc, __shift, __len, __val)      \
+        (*(__le32 *)(__pdesc) =                                 \
+        (cpu_to_le32((le32_to_cpu(*((__le32 *)(__pdesc))) &     \
+        (~(BIT_OFFSET_LEN_MASK_32((__shift), __len)))) |        \
+        (((u32)(__val) & BIT_LEN_MASK_32(__len)) << (__shift)))));
+/* macros to read/write various fields in RX or TX descriptors */
+/* Dword 0 */
+#define SET_TX_DESC_PKT_SIZE(__pdesc, __val)                    \
+        SET_BITS_OFFSET_LE(__pdesc, 0, 16, __val)
+#define SET_TX_DESC_OFFSET(__pdesc, __val)                      \
+        SET_BITS_OFFSET_LE(__pdesc, 16, 8, __val)
+#define SET_TX_DESC_TYPE(__pdesc, __val)                        \
+        SET_BITS_OFFSET_LE(__pdesc, 24, 2, __val)
+#define SET_TX_DESC_LAST_SEG(__pdesc, __val)                    \
+        SET_BITS_OFFSET_LE(__pdesc, 26, 1, __val)
+#define SET_TX_DESC_FIRST_SEG(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc, 27, 1, __val)
+#define SET_TX_DESC_LINIP(__pdesc, __val)                       \
+        SET_BITS_OFFSET_LE(__pdesc, 28, 1, __val)
+#define SET_TX_DESC_AMSDU(__pdesc, __val)                       \
+        SET_BITS_OFFSET_LE(__pdesc, 29, 1, __val)
+#define SET_TX_DESC_GREEN_FIELD(__pdesc, __val)                 \
+        SET_BITS_OFFSET_LE(__pdesc, 30, 1, __val)
+#define SET_TX_DESC_OWN(__pdesc, __val)                         \
+        SET_BITS_OFFSET_LE(__pdesc, 31, 1, __val)
+#define GET_TX_DESC_OWN(__pdesc)                                \
+        SHIFT_AND_MASK_LE(__pdesc, 31, 1)
+/* Dword 1 */
+#define SET_TX_DESC_MACID(__pdesc, __val)                       \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 0, 5, __val)
+#define SET_TX_DESC_MORE_DATA(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 5, 1, __val)
+#define SET_TX_DESC_MORE_FRAG(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 6, 1, __val)
+#define SET_TX_DESC_PIFS(__pdesc, __val)                        \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 7, 1, __val)
+#define SET_TX_DESC_QUEUE_SEL(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 8, 5, __val)
+#define SET_TX_DESC_ACK_POLICY(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 13, 2, __val)
+#define SET_TX_DESC_NO_ACM(__pdesc, __val)                      \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 15, 1, __val)
+#define SET_TX_DESC_NON_QOS(__pdesc, __val)                     \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 16, 1, __val)
+#define SET_TX_DESC_KEY_ID(__pdesc, __val)                      \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 17, 2, __val)
+#define SET_TX_DESC_OUI(__pdesc, __val)                         \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 19, 1, __val)
+#define SET_TX_DESC_PKT_TYPE(__pdesc, __val)                    \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 20, 1, __val)
+#define SET_TX_DESC_EN_DESC_ID(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 21, 1, __val)
+#define SET_TX_DESC_SEC_TYPE(__pdesc, __val)                    \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 22, 2, __val)
+#define SET_TX_DESC_WDS(__pdesc, __val)                         \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 24, 1, __val)
+#define SET_TX_DESC_HTC(__pdesc, __val)                         \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 25, 1, __val)
+#define SET_TX_DESC_PKT_OFFSET(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 26, 5, __val)
+#define SET_TX_DESC_HWPC(__pdesc, __val)                        \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 27, 1, __val)
+/* Dword 2 */
+#define SET_TX_DESC_DATA_RETRY_LIMIT(__pdesc, __val)            \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 0, 6, __val)
+#define SET_TX_DESC_RETRY_LIMIT_ENABLE(__pdesc, __val)          \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 6, 1, __val)
+#define SET_TX_DESC_TSFL(__pdesc, __val)                        \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 7, 5, __val)
+#define SET_TX_DESC_RTS_RETRY_COUNT(__pdesc, __val)             \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 12, 6, __val)
+#define SET_TX_DESC_DATA_RETRY_COUNT(__pdesc, __val)            \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 18, 6, __val)
+#define SET_TX_DESC_RSVD_MACID(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(((__pdesc) + 8), 24, 5, __val)
+#define SET_TX_DESC_AGG_ENABLE(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 29, 1, __val)
+#define SET_TX_DESC_AGG_BREAK(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 30, 1, __val)
+#define SET_TX_DESC_OWN_MAC(__pdesc, __val)                     \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 31, 1, __val)
+/* Dword 3 */
+#define SET_TX_DESC_NEXT_HEAP_PAGE(__pdesc, __val)              \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 0, 8, __val)
+#define SET_TX_DESC_TAIL_PAGE(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 8, 8, __val)
+#define SET_TX_DESC_SEQ(__pdesc, __val)                         \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 16, 12, __val)
+#define SET_TX_DESC_FRAG(__pdesc, __val)                        \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 28, 4, __val)
+/* Dword 4 */
+#define SET_TX_DESC_RTS_RATE(__pdesc, __val)                    \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 0, 6, __val)
+#define SET_TX_DESC_DISABLE_RTS_FB(__pdesc, __val)              \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 6, 1, __val)
+#define SET_TX_DESC_RTS_RATE_FB_LIMIT(__pdesc, __val)           \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 7, 4, __val)
+#define SET_TX_DESC_CTS_ENABLE(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 11, 1, __val)
+#define SET_TX_DESC_RTS_ENABLE(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 12, 1, __val)
+#define SET_TX_DESC_RA_BRSR_ID(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 13, 3, __val)
+#define SET_TX_DESC_TXHT(__pdesc, __val)                        \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 16, 1, __val)
+#define SET_TX_DESC_TX_SHORT(__pdesc, __val)                    \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 17, 1, __val)
+#define SET_TX_DESC_TX_BANDWIDTH(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 18, 1, __val)
+#define SET_TX_DESC_TX_SUB_CARRIER(__pdesc, __val)              \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 19, 2, __val)
+#define SET_TX_DESC_TX_STBC(__pdesc, __val)                     \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 21, 2, __val)
+#define SET_TX_DESC_TX_REVERSE_DIRECTION(__pdesc, __val)        \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 23, 1, __val)
+#define SET_TX_DESC_RTS_HT(__pdesc, __val)                      \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 24, 1, __val)
+#define SET_TX_DESC_RTS_SHORT(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 25, 1, __val)
+#define SET_TX_DESC_RTS_BANDWIDTH(__pdesc, __val)               \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 26, 1, __val)
+#define SET_TX_DESC_RTS_SUB_CARRIER(__pdesc, __val)             \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 27, 2, __val)
+#define SET_TX_DESC_RTS_STBC(__pdesc, __val)                    \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 29, 2, __val)
+#define SET_TX_DESC_USER_RATE(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 31, 1, __val)
+/* Dword 5 */
+#define SET_TX_DESC_PACKET_ID(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 20, 0, 9, __val)
+#define SET_TX_DESC_TX_RATE(__pdesc, __val)                     \
+        SET_BITS_OFFSET_LE(__pdesc + 20, 9, 6, __val)
+#define SET_TX_DESC_DISABLE_FB(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 20, 15, 1, __val)
+#define SET_TX_DESC_DATA_RATE_FB_LIMIT(__pdesc, __val)          \
+        SET_BITS_OFFSET_LE(__pdesc + 20, 16, 5, __val)
+#define SET_TX_DESC_TX_AGC(__pdesc, __val)                      \
+        SET_BITS_OFFSET_LE(__pdesc + 20, 21, 11, __val)
+/* Dword 6 */
+#define SET_TX_DESC_IP_CHECK_SUM(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc + 24, 0, 16, __val)
+#define SET_TX_DESC_TCP_CHECK_SUM(__pdesc, __val)               \
+        SET_BITS_OFFSET_LE(__pdesc + 24, 16, 16, __val)
+/* Dword 7 */
+#define SET_TX_DESC_TX_BUFFER_SIZE(__pdesc, __val)              \
+        SET_BITS_OFFSET_LE(__pdesc + 28, 0, 16, __val)
+#define SET_TX_DESC_IP_HEADER_OFFSET(__pdesc, __val)            \
+        SET_BITS_OFFSET_LE(__pdesc + 28, 16, 8, __val)
+#define SET_TX_DESC_TCP_ENABLE(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 28, 31, 1, __val)
+/* Dword 8 */
+#define SET_TX_DESC_TX_BUFFER_ADDRESS(__pdesc, __val)           \
+        SET_BITS_OFFSET_LE(__pdesc + 32, 0, 32, __val)
+#define GET_TX_DESC_TX_BUFFER_ADDRESS(__pdesc)                  \
+        SHIFT_AND_MASK_LE(__pdesc + 32, 0, 32)
+/* Dword 9 */
+#define SET_TX_DESC_NEXT_DESC_ADDRESS(__pdesc, __val)           \
+        SET_BITS_OFFSET_LE(__pdesc + 36, 0, 32, __val)
+/* Because the PCI Tx descriptors are chaied at the
+ * initialization and all the NextDescAddresses in
+ * these descriptors cannot not be cleared (,or
+ * driver/HW cannot find the next descriptor), the
+ * offset 36 (NextDescAddresses) is reserved when
+ * the desc is cleared. */
+#define TX_DESC_NEXT_DESC_OFFSET                        36
+#define CLEAR_PCI_TX_DESC_CONTENT(__pdesc, _size)               \
+do {                                                            \
+        if (_size > TX_DESC_NEXT_DESC_OFFSET)                   \
+                memset(__pdesc, 0, TX_DESC_NEXT_DESC_OFFSET);   \
+        else                                                    \
+                memset(__pdesc, 0, _size);                      \
+} while (0);
+/* Rx Desc */
+#define RX_STATUS_DESC_SIZE                             24
+#define RX_DRV_INFO_SIZE_UNIT                           8
+/* DWORD 0 */
+#define SET_RX_STATUS_DESC_PKT_LEN(__pdesc, __val)              \
+        SET_BITS_OFFSET_LE(__pdesc, 0, 14, __val)
+#define SET_RX_STATUS_DESC_CRC32(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc, 14, 1, __val)
+#define SET_RX_STATUS_DESC_ICV(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc, 15, 1, __val)
+#define SET_RX_STATUS_DESC_DRVINFO_SIZE(__pdesc, __val)         \
+        SET_BITS_OFFSET_LE(__pdesc, 16, 4, __val)
+#define SET_RX_STATUS_DESC_SECURITY(__pdesc, __val)             \
+        SET_BITS_OFFSET_LE(__pdesc, 20, 3, __val)
+#define SET_RX_STATUS_DESC_QOS(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc, 23, 1, __val)
+#define SET_RX_STATUS_DESC_SHIFT(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc, 24, 2, __val)
+#define SET_RX_STATUS_DESC_PHY_STATUS(__pdesc, __val)           \
+        SET_BITS_OFFSET_LE(__pdesc, 26, 1, __val)
+#define SET_RX_STATUS_DESC_SWDEC(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc, 27, 1, __val)
+#define SET_RX_STATUS_DESC_LAST_SEG(__pdesc, __val)             \
+        SET_BITS_OFFSET_LE(__pdesc, 28, 1, __val)
+#define SET_RX_STATUS_DESC_FIRST_SEG(__pdesc, __val)            \
+        SET_BITS_OFFSET_LE(__pdesc, 29, 1, __val)
+#define SET_RX_STATUS_DESC_EOR(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc, 30, 1, __val)
+#define SET_RX_STATUS_DESC_OWN(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc, 31, 1, __val)
+#define GET_RX_STATUS_DESC_PKT_LEN(__pdesc)                     \
+        SHIFT_AND_MASK_LE(__pdesc, 0, 14)
+#define GET_RX_STATUS_DESC_CRC32(__pdesc)                       \
+        SHIFT_AND_MASK_LE(__pdesc, 14, 1)
+#define GET_RX_STATUS_DESC_ICV(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc, 15, 1)
+#define GET_RX_STATUS_DESC_DRVINFO_SIZE(__pdesc)                \
+        SHIFT_AND_MASK_LE(__pdesc, 16, 4)
+#define GET_RX_STATUS_DESC_SECURITY(__pdesc)                    \
+        SHIFT_AND_MASK_LE(__pdesc, 20, 3)
+#define GET_RX_STATUS_DESC_QOS(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc, 23, 1)
+#define GET_RX_STATUS_DESC_SHIFT(__pdesc)                       \
+        SHIFT_AND_MASK_LE(__pdesc, 24, 2)
+#define GET_RX_STATUS_DESC_PHY_STATUS(__pdesc)                  \
+        SHIFT_AND_MASK_LE(__pdesc, 26, 1)
+#define GET_RX_STATUS_DESC_SWDEC(__pdesc)                       \
+        SHIFT_AND_MASK_LE(__pdesc, 27, 1)
+#define GET_RX_STATUS_DESC_LAST_SEG(__pdesc)                    \
+        SHIFT_AND_MASK_LE(__pdesc, 28, 1)
+#define GET_RX_STATUS_DESC_FIRST_SEG(__pdesc)                   \
+        SHIFT_AND_MASK_LE(__pdesc, 29, 1)
+#define GET_RX_STATUS_DESC_EOR(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc, 30, 1)
+#define GET_RX_STATUS_DESC_OWN(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc, 31, 1)
+/* DWORD 1 */
+#define SET_RX_STATUS_DESC_MACID(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 0, 5, __val)
+#define SET_RX_STATUS_DESC_TID(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 5, 4, __val)
+#define SET_RX_STATUS_DESC_PAGGR(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 14, 1, __val)
+#define SET_RX_STATUS_DESC_FAGGR(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 15, 1, __val)
+#define SET_RX_STATUS_DESC_A1_FIT(__pdesc, __val)               \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 16, 4, __val)
+#define SET_RX_STATUS_DESC_A2_FIT(__pdesc, __val)               \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 20, 4, __val)
+#define SET_RX_STATUS_DESC_PAM(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 24, 1, __val)
+#define SET_RX_STATUS_DESC_PWR(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 25, 1, __val)
+#define SET_RX_STATUS_DESC_MOREDATA(__pdesc, __val)             \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 26, 1, __val)
+#define SET_RX_STATUS_DESC_MOREFRAG(__pdesc, __val)             \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 27, 1, __val)
+#define SET_RX_STATUS_DESC_TYPE(__pdesc, __val)                 \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 28, 2, __val)
+#define SET_RX_STATUS_DESC_MC(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 30, 1, __val)
+#define SET_RX_STATUS_DESC_BC(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 4, 31, 1, __val)
+#define GET_RX_STATUS_DEC_MACID(__pdesc)                        \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 0, 5)
+#define GET_RX_STATUS_DESC_TID(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 5, 4)
+#define GET_RX_STATUS_DESC_PAGGR(__pdesc)                       \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 14, 1)
+#define GET_RX_STATUS_DESC_FAGGR(__pdesc)                       \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 15, 1)
+#define GET_RX_STATUS_DESC_A1_FIT(__pdesc)                      \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 16, 4)
+#define GET_RX_STATUS_DESC_A2_FIT(__pdesc)                      \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 20, 4)
+#define GET_RX_STATUS_DESC_PAM(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 24, 1)
+#define GET_RX_STATUS_DESC_PWR(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 25, 1)
+#define GET_RX_STATUS_DESC_MORE_DATA(__pdesc)                   \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 26, 1)
+#define GET_RX_STATUS_DESC_MORE_FRAG(__pdesc)                   \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 27, 1)
+#define GET_RX_STATUS_DESC_TYPE(__pdesc)                        \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 28, 2)
+#define GET_RX_STATUS_DESC_MC(__pdesc)                          \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 30, 1)
+#define GET_RX_STATUS_DESC_BC(__pdesc)                          \
+        SHIFT_AND_MASK_LE(__pdesc + 4, 31, 1)
+/* DWORD 2 */
+#define SET_RX_STATUS_DESC_SEQ(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 0, 12, __val)
+#define SET_RX_STATUS_DESC_FRAG(__pdesc, __val)                 \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 12, 4, __val)
+#define SET_RX_STATUS_DESC_NEXT_PKTLEN(__pdesc, __val)          \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 16, 8, __val)
+#define SET_RX_STATUS_DESC_NEXT_IND(__pdesc, __val)             \
+        SET_BITS_OFFSET_LE(__pdesc + 8, 30, 1, __val)
+#define GET_RX_STATUS_DESC_SEQ(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc + 8, 0, 12)
+#define GET_RX_STATUS_DESC_FRAG(__pdesc)                        \
+        SHIFT_AND_MASK_LE(__pdesc + 8, 12, 4)
+#define GET_RX_STATUS_DESC_NEXT_PKTLEN(__pdesc)                 \
+        SHIFT_AND_MASK_LE(__pdesc + 8, 16, 8)
+#define GET_RX_STATUS_DESC_NEXT_IND(__pdesc)                    \
+        SHIFT_AND_MASK_LE(__pdesc + 8, 30, 1)
+/* DWORD 3 */
+#define SET_RX_STATUS_DESC_RX_MCS(__pdesc, __val)               \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 0, 6, __val)
+#define SET_RX_STATUS_DESC_RX_HT(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 6, 1, __val)
+#define SET_RX_STATUS_DESC_AMSDU(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 7, 1, __val)
+#define SET_RX_STATUS_DESC_SPLCP(__pdesc, __val)                \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 8, 1, __val)
+#define SET_RX_STATUS_DESC_BW(__pdesc, __val)                   \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 9, 1, __val)
+#define SET_RX_STATUS_DESC_HTC(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 10, 1, __val)
+#define SET_RX_STATUS_DESC_TCP_CHK_RPT(__pdesc, __val)          \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 11, 1, __val)
+#define SET_RX_STATUS_DESC_IP_CHK_RPT(__pdesc, __val)           \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 12, 1, __val)
+#define SET_RX_STATUS_DESC_TCP_CHK_VALID(__pdesc, __val)        \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 13, 1, __val)
+#define SET_RX_STATUS_DESC_HWPC_ERR(__pdesc, __val)             \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 14, 1, __val)
+#define SET_RX_STATUS_DESC_HWPC_IND(__pdesc, __val)             \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 15, 1, __val)
+#define SET_RX_STATUS_DESC_IV0(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 12, 16, 16, __val)
+#define GET_RX_STATUS_DESC_RX_MCS(__pdesc)                      \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 0, 6)
+#define GET_RX_STATUS_DESC_RX_HT(__pdesc)                       \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 6, 1)
+#define GET_RX_STATUS_DESC_AMSDU(__pdesc)                       \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 7, 1)
+#define GET_RX_STATUS_DESC_SPLCP(__pdesc)                       \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 8, 1)
+#define GET_RX_STATUS_DESC_BW(__pdesc)                          \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 9, 1)
+#define GET_RX_STATUS_DESC_HTC(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 10, 1)
+#define GET_RX_STATUS_DESC_TCP_CHK_RPT(__pdesc)                 \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 11, 1)
+#define GET_RX_STATUS_DESC_IP_CHK_RPT(__pdesc)                  \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 12, 1)
+#define GET_RX_STATUS_DESC_TCP_CHK_VALID(__pdesc)               \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 13, 1)
+#define GET_RX_STATUS_DESC_HWPC_ERR(__pdesc)                    \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 14, 1)
+#define GET_RX_STATUS_DESC_HWPC_IND(__pdesc)                    \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 15, 1)
+#define GET_RX_STATUS_DESC_IV0(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc + 12, 16, 16)
+/* DWORD 4 */
+#define SET_RX_STATUS_DESC_IV1(__pdesc, __val)                  \
+        SET_BITS_OFFSET_LE(__pdesc + 16, 0, 32, __val)
+#define GET_RX_STATUS_DESC_IV1(__pdesc)                         \
+        SHIFT_AND_MASK_LE(__pdesc + 16, 0, 32)
+/* DWORD 5 */
+#define SET_RX_STATUS_DESC_TSFL(__pdesc, __val)                 \
+        SET_BITS_OFFSET_LE(__pdesc + 20, 0, 32, __val)
+#define GET_RX_STATUS_DESC_TSFL(__pdesc)                        \
+        SHIFT_AND_MASK_LE(__pdesc + 20, 0, 32)
+/* DWORD 6 */
+#define SET_RX_STATUS__DESC_BUFF_ADDR(__pdesc, __val)   \
+        SET_BITS_OFFSET_LE(__pdesc + 24, 0, 32, __val)
+#define RX_HAL_IS_CCK_RATE(_pdesc)\
+        (GET_RX_STATUS_DESC_RX_MCS(_pdesc) == DESC92S_RATE1M || \
+         GET_RX_STATUS_DESC_RX_MCS(_pdesc) == DESC92S_RATE2M || \
+         GET_RX_STATUS_DESC_RX_MCS(_pdesc) == DESC92S_RATE5_5M ||\
+         GET_RX_STATUS_DESC_RX_MCS(_pdesc) == DESC92S_RATE11M)
+enum rf_optype {
+        RF_OP_BY_SW_3WIRE = 0,
+        RF_OP_BY_FW,
+        RF_OP_MAX
+};
+enum ic_inferiority {
+        IC_INFERIORITY_A = 0,
+        IC_INFERIORITY_B = 1,
+};
+enum fwcmd_iotype {
+        /* For DIG DM */
+        FW_CMD_DIG_ENABLE = 0,
+        FW_CMD_DIG_DISABLE = 1,
+        FW_CMD_DIG_HALT = 2,
+        FW_CMD_DIG_RESUME = 3,
+        /* For High Power DM */
+        FW_CMD_HIGH_PWR_ENABLE = 4,
+        FW_CMD_HIGH_PWR_DISABLE = 5,
+        /* For Rate adaptive DM */
+        FW_CMD_RA_RESET = 6,
+        FW_CMD_RA_ACTIVE = 7,
+        FW_CMD_RA_REFRESH_N = 8,
+        FW_CMD_RA_REFRESH_BG = 9,
+        FW_CMD_RA_INIT = 10,
+        /* For FW supported IQK */
+        FW_CMD_IQK_INIT = 11,
+        /* Tx power tracking switch,
+         * MP driver only */
+        FW_CMD_TXPWR_TRACK_ENABLE = 12,
+        /* Tx power tracking switch,
+         * MP driver only */
+        FW_CMD_TXPWR_TRACK_DISABLE = 13,
+        /* Tx power tracking with thermal
+         * indication, for Normal driver */
+        FW_CMD_TXPWR_TRACK_THERMAL = 14,
+        FW_CMD_PAUSE_DM_BY_SCAN = 15,
+        FW_CMD_RESUME_DM_BY_SCAN = 16,
+        FW_CMD_RA_REFRESH_N_COMB = 17,
+        FW_CMD_RA_REFRESH_BG_COMB = 18,
+        FW_CMD_ANTENNA_SW_ENABLE = 19,
+        FW_CMD_ANTENNA_SW_DISABLE = 20,
+        /* Tx Status report for CCX from FW */
+        FW_CMD_TX_FEEDBACK_CCX_ENABLE = 21,
+        /* Indifate firmware that driver
+         * enters LPS, For PS-Poll issue */
+        FW_CMD_LPS_ENTER = 22,
+        /* Indicate firmware that driver
+         * leave LPS*/
+        FW_CMD_LPS_LEAVE = 23,
+        /* Set DIG mode to signal strength */
+        FW_CMD_DIG_MODE_SS = 24,
+        /* Set DIG mode to false alarm. */
+        FW_CMD_DIG_MODE_FA = 25,
+        FW_CMD_ADD_A2_ENTRY = 26,
+        FW_CMD_CTRL_DM_BY_DRIVER = 27,
+        FW_CMD_CTRL_DM_BY_DRIVER_NEW = 28,
+        FW_CMD_PAPE_CONTROL = 29,
+        FW_CMD_IQK_ENABLE = 30,
+};
+/*
+ * Driver info contain PHY status
+ * and other variabel size info
+ * PHY Status content as below
+ */
+struct  rx_fwinfo {
+        /* DWORD 0 */
+        u8 gain_trsw[4];
+        /* DWORD 1 */
+        u8 pwdb_all;
+        u8 cfosho[4];
+        /* DWORD 2 */
+        u8 cfotail[4];
+        /* DWORD 3 */
+        s8 rxevm[2];
+        s8 rxsnr[4];
+        /* DWORD 4 */
+        u8 pdsnr[2];
+        /* DWORD 5 */
+        u8 csi_current[2];
+        u8 csi_target[2];
+        /* DWORD 6 */
+        u8 sigevm;
+        u8 max_ex_pwr;
+        u8 ex_intf_flag:1;
+        u8 sgi_en:1;
+        u8 rxsc:2;
+        u8 reserve:4;
+};
+struct phy_sts_cck_8192s_t {
+        u8 adc_pwdb_x[4];
+        u8 sq_rpt;
+        u8 cck_agc_rpt;
+};
+#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/dm.c b/drivers/net/wireless/rtlwifi/rtl8192se/dm.c
new file mode 100644
index 000000000000..da86db86fa4a
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/dm.c
@@ -0,0 +1,733 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#include "../wifi.h"
+#include "../base.h"
+#include "reg.h"
+#include "def.h"
+#include "phy.h"
+#include "dm.h"
+#include "fw.h"
+struct dig_t digtable;
+static const u32 edca_setting_dl[PEER_MAX] = {
+        0xa44f,         /* 0 UNKNOWN */
+        0x5ea44f,       /* 1 REALTEK_90 */
+        0x5ea44f,       /* 2 REALTEK_92SE */
+        0xa630,         /* 3 BROAD      */
+        0xa44f,         /* 4 RAL */
+        0xa630,         /* 5 ATH */
+        0xa630,         /* 6 CISCO */
+        0xa42b,         /* 7 MARV */
+};
+static const u32 edca_setting_dl_gmode[PEER_MAX] = {
+        0x4322,         /* 0 UNKNOWN */
+        0xa44f,         /* 1 REALTEK_90 */
+        0x5ea44f,       /* 2 REALTEK_92SE */
+        0xa42b,         /* 3 BROAD */
+        0x5e4322,       /* 4 RAL */
+        0x4322,         /* 5 ATH */
+        0xa430,         /* 6 CISCO */
+        0x5ea44f,       /* 7 MARV */
+};
+static const u32 edca_setting_ul[PEER_MAX] = {
+        0x5e4322,       /* 0 UNKNOWN */
+        0xa44f,         /* 1 REALTEK_90 */
+        0x5ea44f,       /* 2 REALTEK_92SE */
+        0x5ea322,       /* 3 BROAD */
+        0x5ea422,       /* 4 RAL */
+        0x5ea322,       /* 5 ATH */
+        0x3ea44f,       /* 6 CISCO */
+        0x5ea44f,       /* 7 MARV */
+};
+static void _rtl92s_dm_check_edca_turbo(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        static u64 last_txok_cnt;
+        static u64 last_rxok_cnt;
+        u64 cur_txok_cnt = 0;
+        u64 cur_rxok_cnt = 0;
+        u32 edca_be_ul = edca_setting_ul[mac->vendor];
+        u32 edca_be_dl = edca_setting_dl[mac->vendor];
+        u32 edca_gmode = edca_setting_dl_gmode[mac->vendor];
+        if (mac->link_state != MAC80211_LINKED) {
+                rtlpriv->dm.current_turbo_edca = false;
+                goto dm_checkedcaturbo_exit;
+        }
+        if ((!rtlpriv->dm.is_any_nonbepkts) &&
+            (!rtlpriv->dm.disable_framebursting)) {
+                cur_txok_cnt = rtlpriv->stats.txbytesunicast - last_txok_cnt;
+                cur_rxok_cnt = rtlpriv->stats.rxbytesunicast - last_rxok_cnt;
+                if (rtlpriv->phy.rf_type == RF_1T2R) {
+                        if (cur_txok_cnt > 4 * cur_rxok_cnt) {
+                                /* Uplink TP is present. */
+                                if (rtlpriv->dm.is_cur_rdlstate ||
+                                        !rtlpriv->dm.current_turbo_edca) {
+                                        rtl_write_dword(rtlpriv, EDCAPARA_BE,
+                                                        edca_be_ul);
+                                        rtlpriv->dm.is_cur_rdlstate = false;
+                                }
+                        } else {/* Balance TP is present. */
+                                if (!rtlpriv->dm.is_cur_rdlstate ||
+                                        !rtlpriv->dm.current_turbo_edca) {
+                                        if (mac->mode == WIRELESS_MODE_G ||
+                                            mac->mode == WIRELESS_MODE_B)
+                                                rtl_write_dword(rtlpriv,
+                                                                EDCAPARA_BE,
+                                                                edca_gmode);
+                                        else
+                                                rtl_write_dword(rtlpriv,
+                                                                EDCAPARA_BE,
+                                                                edca_be_dl);
+                                        rtlpriv->dm.is_cur_rdlstate = true;
+                                }
+                        }
+                        rtlpriv->dm.current_turbo_edca = true;
+                } else {
+                        if (cur_rxok_cnt > 4 * cur_txok_cnt) {
+                                if (!rtlpriv->dm.is_cur_rdlstate ||
+                                        !rtlpriv->dm.current_turbo_edca) {
+                                        if (mac->mode == WIRELESS_MODE_G ||
+                                            mac->mode == WIRELESS_MODE_B)
+                                                rtl_write_dword(rtlpriv,
+                                                                EDCAPARA_BE,
+                                                                edca_gmode);
+                                        else
+                                                rtl_write_dword(rtlpriv,
+                                                                EDCAPARA_BE,
+                                                                edca_be_dl);
+                                        rtlpriv->dm.is_cur_rdlstate = true;
+                                }
+                        } else {
+                                if (rtlpriv->dm.is_cur_rdlstate ||
+                                        !rtlpriv->dm.current_turbo_edca) {
+                                        rtl_write_dword(rtlpriv, EDCAPARA_BE,
+                                                        edca_be_ul);
+                                        rtlpriv->dm.is_cur_rdlstate = false;
+                                }
+                        }
+                        rtlpriv->dm.current_turbo_edca = true;
+                }
+        } else {
+                if (rtlpriv->dm.current_turbo_edca) {
+                        u8 tmp = AC0_BE;
+                        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_AC_PARAM,
+                                                      (u8 *)(&tmp));
+                        rtlpriv->dm.current_turbo_edca = false;
+                }
+        }
+dm_checkedcaturbo_exit:
+        rtlpriv->dm.is_any_nonbepkts = false;
+        last_txok_cnt = rtlpriv->stats.txbytesunicast;
+        last_rxok_cnt = rtlpriv->stats.rxbytesunicast;
+}
+static void _rtl92s_dm_txpowertracking_callback_thermalmeter(
+                                        struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        u8 thermalvalue = 0;
+        rtlpriv->dm.txpower_trackinginit = true;
+        thermalvalue = (u8)rtl_get_rfreg(hw, RF90_PATH_A, RF_T_METER, 0x1f);
+        RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
+                 ("Readback Thermal Meter = 0x%x pre thermal meter 0x%x "
+                  "eeprom_thermalmeter 0x%x\n", thermalvalue,
+                  rtlpriv->dm.thermalvalue, rtlefuse->eeprom_thermalmeter));
+        if (thermalvalue) {
+                rtlpriv->dm.thermalvalue = thermalvalue;
+                rtl92s_phy_set_fw_cmd(hw, FW_CMD_TXPWR_TRACK_THERMAL);
+        }
+        rtlpriv->dm.txpowercount = 0;
+}
+static void _rtl92s_dm_check_txpowertracking_thermalmeter(
+                                        struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        static u8 tm_trigger;
+        u8 tx_power_checkcnt = 5;
+        /* 2T2R TP issue */
+        if (rtlphy->rf_type == RF_2T2R)
+                return;
+        if (!rtlpriv->dm.txpower_tracking)
+                return;
+        if (rtlpriv->dm.txpowercount <= tx_power_checkcnt) {
+                rtlpriv->dm.txpowercount++;
+                return;
+        }
+        if (!tm_trigger) {
+                rtl_set_rfreg(hw, RF90_PATH_A, RF_T_METER,
+                              RFREG_OFFSET_MASK, 0x60);
+                tm_trigger = 1;
+        } else {
+                _rtl92s_dm_txpowertracking_callback_thermalmeter(hw);
+                tm_trigger = 0;
+        }
+}
+static void _rtl92s_dm_refresh_rateadaptive_mask(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rate_adaptive *ra = &(rtlpriv->ra);
+        u32 low_rssi_thresh = 0;
+        u32 middle_rssi_thresh = 0;
+        u32 high_rssi_thresh = 0;
+        u8 rssi_level;
+        struct ieee80211_sta *sta = NULL;
+        if (is_hal_stop(rtlhal))
+                return;
+        if (!rtlpriv->dm.useramask)
+                return;
+        if (!rtlpriv->dm.inform_fw_driverctrldm) {
+                rtl92s_phy_set_fw_cmd(hw, FW_CMD_CTRL_DM_BY_DRIVER);
+                rtlpriv->dm.inform_fw_driverctrldm = true;
+        }
+        rcu_read_lock();
+        if (mac->opmode == NL80211_IFTYPE_STATION)
+                sta = get_sta(hw, mac->vif, mac->bssid);
+        if ((mac->link_state == MAC80211_LINKED) &&
+            (mac->opmode == NL80211_IFTYPE_STATION)) {
+                switch (ra->pre_ratr_state) {
+                case DM_RATR_STA_HIGH:
+                        high_rssi_thresh = 40;
+                        middle_rssi_thresh = 30;
+                        low_rssi_thresh = 20;
+                        break;
+                case DM_RATR_STA_MIDDLE:
+                        high_rssi_thresh = 44;
+                        middle_rssi_thresh = 30;
+                        low_rssi_thresh = 20;
+                        break;
+                case DM_RATR_STA_LOW:
+                        high_rssi_thresh = 44;
+                        middle_rssi_thresh = 34;
+                        low_rssi_thresh = 20;
+                        break;
+                case DM_RATR_STA_ULTRALOW:
+                        high_rssi_thresh = 44;
+                        middle_rssi_thresh = 34;
+                        low_rssi_thresh = 24;
+                        break;
+                default:
+                        high_rssi_thresh = 44;
+                        middle_rssi_thresh = 34;
+                        low_rssi_thresh = 24;
+                        break;
+                }
+                if (rtlpriv->dm.undecorated_smoothed_pwdb >
+                    (long)high_rssi_thresh) {
+                        ra->ratr_state = DM_RATR_STA_HIGH;
+                        rssi_level = 1;
+                } else if (rtlpriv->dm.undecorated_smoothed_pwdb >
+                           (long)middle_rssi_thresh) {
+                        ra->ratr_state = DM_RATR_STA_LOW;
+                        rssi_level = 3;
+                } else if (rtlpriv->dm.undecorated_smoothed_pwdb >
+                           (long)low_rssi_thresh) {
+                        ra->ratr_state = DM_RATR_STA_LOW;
+                        rssi_level = 5;
+                } else {
+                        ra->ratr_state = DM_RATR_STA_ULTRALOW;
+                        rssi_level = 6;
+                }
+                if (ra->pre_ratr_state != ra->ratr_state) {
+                        RT_TRACE(rtlpriv, COMP_RATE, DBG_LOUD, ("RSSI = %ld "
+                                "RSSI_LEVEL = %d PreState = %d, CurState = %d\n",
+                                rtlpriv->dm.undecorated_smoothed_pwdb,
+                                ra->ratr_state,
+                                ra->pre_ratr_state, ra->ratr_state));
+                        rtlpriv->cfg->ops->update_rate_tbl(hw, sta,
+                                                           ra->ratr_state);
+                        ra->pre_ratr_state = ra->ratr_state;
+                }
+        }
+        rcu_read_unlock();
+}
+static void _rtl92s_dm_switch_baseband_mrc(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        bool current_mrc;
+        bool enable_mrc = true;
+        long tmpentry_maxpwdb = 0;
+        u8 rssi_a = 0;
+        u8 rssi_b = 0;
+        if (is_hal_stop(rtlhal))
+                return;
+        if ((rtlphy->rf_type == RF_1T1R) || (rtlphy->rf_type == RF_2T2R))
+                return;
+        rtlpriv->cfg->ops->get_hw_reg(hw, HW_VAR_MRC, (u8 *)(&current_mrc));
+        if (mac->link_state >= MAC80211_LINKED) {
+                if (rtlpriv->dm.undecorated_smoothed_pwdb > tmpentry_maxpwdb) {
+                        rssi_a = rtlpriv->stats.rx_rssi_percentage[RF90_PATH_A];
+                        rssi_b = rtlpriv->stats.rx_rssi_percentage[RF90_PATH_B];
+                }
+        }
+        /* MRC settings would NOT affect TP on Wireless B mode. */
+        if (mac->mode != WIRELESS_MODE_B) {
+                if ((rssi_a == 0) && (rssi_b == 0)) {
+                        enable_mrc = true;
+                } else if (rssi_b > 30) {
+                        /* Turn on B-Path */
+                        enable_mrc = true;
+                } else if (rssi_b < 5) {
+                        /* Turn off B-path  */
+                        enable_mrc = false;
+                /* Take care of RSSI differentiation. */
+                } else if (rssi_a > 15 && (rssi_a >= rssi_b)) {
+                        if ((rssi_a - rssi_b) > 15)
+                                /* Turn off B-path  */
+                                enable_mrc = false;
+                        else if ((rssi_a - rssi_b) < 10)
+                                /* Turn on B-Path */
+                                enable_mrc = true;
+                        else
+                                enable_mrc = current_mrc;
+                } else {
+                        /* Turn on B-Path */
+                        enable_mrc = true;
+                }
+        }
+        /* Update MRC settings if needed. */
+        if (enable_mrc != current_mrc)
+                rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_MRC,
+                                              (u8 *)&enable_mrc);
+}
+void rtl92s_dm_init_edca_turbo(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        rtlpriv->dm.current_turbo_edca = false;
+        rtlpriv->dm.is_any_nonbepkts = false;
+        rtlpriv->dm.is_cur_rdlstate = false;
+}
+static void _rtl92s_dm_init_rate_adaptive_mask(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rate_adaptive *ra = &(rtlpriv->ra);
+        ra->ratr_state = DM_RATR_STA_MAX;
+        ra->pre_ratr_state = DM_RATR_STA_MAX;
+        if (rtlpriv->dm.dm_type == DM_TYPE_BYDRIVER)
+                rtlpriv->dm.useramask = true;
+        else
+                rtlpriv->dm.useramask = false;
+        rtlpriv->dm.useramask = false;
+        rtlpriv->dm.inform_fw_driverctrldm = false;
+}
+static void _rtl92s_dm_init_txpowertracking_thermalmeter(
+                                struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        rtlpriv->dm.txpower_tracking = true;
+        rtlpriv->dm.txpowercount = 0;
+        rtlpriv->dm.txpower_trackinginit = false;
+}
+static void _rtl92s_dm_false_alarm_counter_statistics(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct false_alarm_statistics *falsealm_cnt = &(rtlpriv->falsealm_cnt);
+        u32 ret_value;
+        ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER1, MASKDWORD);
+        falsealm_cnt->cnt_parity_fail = ((ret_value & 0xffff0000) >> 16);
+        ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER2, MASKDWORD);
+        falsealm_cnt->cnt_rate_illegal = (ret_value & 0xffff);
+        falsealm_cnt->cnt_crc8_fail = ((ret_value & 0xffff0000) >> 16);
+        ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER3, MASKDWORD);
+        falsealm_cnt->cnt_mcs_fail = (ret_value & 0xffff);
+        falsealm_cnt->cnt_ofdm_fail = falsealm_cnt->cnt_parity_fail +
+                falsealm_cnt->cnt_rate_illegal + falsealm_cnt->cnt_crc8_fail +
+                falsealm_cnt->cnt_mcs_fail;
+        /* read CCK false alarm */
+        ret_value = rtl_get_bbreg(hw, 0xc64, MASKDWORD);
+        falsealm_cnt->cnt_cck_fail = (ret_value & 0xffff);
+        falsealm_cnt->cnt_all = falsealm_cnt->cnt_ofdm_fail +
+                falsealm_cnt->cnt_cck_fail;
+}
+static void rtl92s_backoff_enable_flag(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct false_alarm_statistics *falsealm_cnt = &(rtlpriv->falsealm_cnt);
+        if (falsealm_cnt->cnt_all > digtable.fa_highthresh) {
+                if ((digtable.backoff_val - 6) <
+                        digtable.backoffval_range_min)
+                        digtable.backoff_val = digtable.backoffval_range_min;
+                else
+                        digtable.backoff_val -= 6;
+        } else if (falsealm_cnt->cnt_all < digtable.fa_lowthresh) {
+                if ((digtable.backoff_val + 6) >
+                        digtable.backoffval_range_max)
+                        digtable.backoff_val =
+                                 digtable.backoffval_range_max;
+                else
+                        digtable.backoff_val += 6;
+        }
+}
+static void _rtl92s_dm_initial_gain_sta_beforeconnect(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct false_alarm_statistics *falsealm_cnt = &(rtlpriv->falsealm_cnt);
+        static u8 initialized, force_write;
+        u8 initial_gain = 0;
+        if ((digtable.pre_sta_connectstate == digtable.cur_sta_connectstate) ||
+                (digtable.cur_sta_connectstate == DIG_STA_BEFORE_CONNECT)) {
+                if (digtable.cur_sta_connectstate == DIG_STA_BEFORE_CONNECT) {
+                        if (rtlpriv->psc.rfpwr_state != ERFON)
+                                return;
+                        if (digtable.backoff_enable_flag == true)
+                                rtl92s_backoff_enable_flag(hw);
+                        else
+                                digtable.backoff_val = DM_DIG_BACKOFF;
+                        if ((digtable.rssi_val + 10 - digtable.backoff_val) >
+                                digtable.rx_gain_range_max)
+                                digtable.cur_igvalue =
+                                                digtable.rx_gain_range_max;
+                        else if ((digtable.rssi_val + 10 - digtable.backoff_val)
+                                 < digtable.rx_gain_range_min)
+                                digtable.cur_igvalue =
+                                                digtable.rx_gain_range_min;
+                        else
+                                digtable.cur_igvalue = digtable.rssi_val + 10 -
+                                                digtable.backoff_val;
+                        if (falsealm_cnt->cnt_all > 10000)
+                                digtable.cur_igvalue =
+                                         (digtable.cur_igvalue > 0x33) ?
+                                         digtable.cur_igvalue : 0x33;
+                        if (falsealm_cnt->cnt_all > 16000)
+                                digtable.cur_igvalue =
+                                                 digtable.rx_gain_range_max;
+                /* connected -> connected or disconnected -> disconnected  */
+                } else {
+                        /* Firmware control DIG, do nothing in driver dm */
+                        return;
+                }
+                /* disconnected -> connected or connected ->
+                 * disconnected or beforeconnect->(dis)connected */
+        } else {
+                /* Enable FW DIG */
+                digtable.dig_ext_port_stage = DIG_EXT_PORT_STAGE_MAX;
+                rtl92s_phy_set_fw_cmd(hw, FW_CMD_DIG_ENABLE);
+                digtable.backoff_val = DM_DIG_BACKOFF;
+                digtable.cur_igvalue = rtlpriv->phy.default_initialgain[0];
+                digtable.pre_igvalue = 0;
+                return;
+        }
+        /* Forced writing to prevent from fw-dig overwriting. */
+        if (digtable.pre_igvalue != rtl_get_bbreg(hw, ROFDM0_XAAGCCORE1,
+                                                  MASKBYTE0))
+                force_write = 1;
+        if ((digtable.pre_igvalue != digtable.cur_igvalue) ||
+            !initialized || force_write) {
+                /* Disable FW DIG */
+                rtl92s_phy_set_fw_cmd(hw, FW_CMD_DIG_DISABLE);
+                initial_gain = (u8)digtable.cur_igvalue;
+                /* Set initial gain. */
+                rtl_set_bbreg(hw, ROFDM0_XAAGCCORE1, MASKBYTE0, initial_gain);
+                rtl_set_bbreg(hw, ROFDM0_XBAGCCORE1, MASKBYTE0, initial_gain);
+                digtable.pre_igvalue = digtable.cur_igvalue;
+                initialized = 1;
+                force_write = 0;
+        }
+}
+static void _rtl92s_dm_ctrl_initgain_bytwoport(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        if (rtlpriv->mac80211.act_scanning)
+                return;
+        /* Decide the current status and if modify initial gain or not */
+        if (rtlpriv->mac80211.link_state >= MAC80211_LINKED ||
+            rtlpriv->mac80211.opmode == NL80211_IFTYPE_ADHOC)
+                digtable.cur_sta_connectstate = DIG_STA_CONNECT;
+        else
+                digtable.cur_sta_connectstate = DIG_STA_DISCONNECT;
+        digtable.rssi_val = rtlpriv->dm.undecorated_smoothed_pwdb;
+        /* Change dig mode to rssi */
+        if (digtable.cur_sta_connectstate != DIG_STA_DISCONNECT) {
+                if (digtable.dig_twoport_algorithm ==
+                    DIG_TWO_PORT_ALGO_FALSE_ALARM) {
+                        digtable.dig_twoport_algorithm = DIG_TWO_PORT_ALGO_RSSI;
+                        rtl92s_phy_set_fw_cmd(hw, FW_CMD_DIG_MODE_SS);
+                }
+        }
+        _rtl92s_dm_false_alarm_counter_statistics(hw);
+        _rtl92s_dm_initial_gain_sta_beforeconnect(hw);
+        digtable.pre_sta_connectstate = digtable.cur_sta_connectstate;
+}
+static void _rtl92s_dm_ctrl_initgain_byrssi(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        /* 2T2R TP issue */
+        if (rtlphy->rf_type == RF_2T2R)
+                return;
+        if (!rtlpriv->dm.dm_initialgain_enable)
+                return;
+        if (digtable.dig_enable_flag == false)
+                return;
+        _rtl92s_dm_ctrl_initgain_bytwoport(hw);
+}
+static void _rtl92s_dm_dynamic_txpower(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        long undecorated_smoothed_pwdb;
+        long txpwr_threshold_lv1, txpwr_threshold_lv2;
+        /* 2T2R TP issue */
+        if (rtlphy->rf_type == RF_2T2R)
+                return;
+        if (!rtlpriv->dm.dynamic_txpower_enable ||
+            rtlpriv->dm.dm_flag & HAL_DM_HIPWR_DISABLE) {
+                rtlpriv->dm.dynamic_txhighpower_lvl = TX_HIGHPWR_LEVEL_NORMAL;
+                return;
+        }
+        if ((mac->link_state < MAC80211_LINKED) &&
+            (rtlpriv->dm.entry_min_undecoratedsmoothed_pwdb == 0)) {
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_TRACE,
+                         ("Not connected to any\n"));
+                rtlpriv->dm.dynamic_txhighpower_lvl = TX_HIGHPWR_LEVEL_NORMAL;
+                rtlpriv->dm.last_dtp_lvl = TX_HIGHPWR_LEVEL_NORMAL;
+                return;
+        }
+        if (mac->link_state >= MAC80211_LINKED) {
+                if (mac->opmode == NL80211_IFTYPE_ADHOC) {
+                        undecorated_smoothed_pwdb =
+                            rtlpriv->dm.entry_min_undecoratedsmoothed_pwdb;
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                                 ("AP Client PWDB = 0x%lx\n",
+                                  undecorated_smoothed_pwdb));
+                } else {
+                        undecorated_smoothed_pwdb =
+                            rtlpriv->dm.undecorated_smoothed_pwdb;
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                                 ("STA Default Port PWDB = 0x%lx\n",
+                                  undecorated_smoothed_pwdb));
+                }
+        } else {
+                undecorated_smoothed_pwdb =
+                    rtlpriv->dm.entry_min_undecoratedsmoothed_pwdb;
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("AP Ext Port PWDB = 0x%lx\n",
+                          undecorated_smoothed_pwdb));
+        }
+        txpwr_threshold_lv2 = TX_POWER_NEAR_FIELD_THRESH_LVL2;
+        txpwr_threshold_lv1 = TX_POWER_NEAR_FIELD_THRESH_LVL1;
+        if (rtl_get_bbreg(hw, 0xc90, MASKBYTE0) == 1)
+                rtlpriv->dm.dynamic_txhighpower_lvl = TX_HIGHPWR_LEVEL_NORMAL;
+        else if (undecorated_smoothed_pwdb >= txpwr_threshold_lv2)
+                rtlpriv->dm.dynamic_txhighpower_lvl = TX_HIGHPWR_LEVEL_NORMAL2;
+        else if ((undecorated_smoothed_pwdb < (txpwr_threshold_lv2 - 3)) &&
+                (undecorated_smoothed_pwdb >= txpwr_threshold_lv1))
+                rtlpriv->dm.dynamic_txhighpower_lvl = TX_HIGHPWR_LEVEL_NORMAL1;
+        else if (undecorated_smoothed_pwdb < (txpwr_threshold_lv1 - 3))
+                rtlpriv->dm.dynamic_txhighpower_lvl = TX_HIGHPWR_LEVEL_NORMAL;
+        if ((rtlpriv->dm.dynamic_txhighpower_lvl != rtlpriv->dm.last_dtp_lvl))
+                rtl92s_phy_set_txpower(hw, rtlphy->current_channel);
+        rtlpriv->dm.last_dtp_lvl = rtlpriv->dm.dynamic_txhighpower_lvl;
+}
+static void _rtl92s_dm_init_dig(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        /* Disable DIG scheme now.*/
+        digtable.dig_enable_flag = true;
+        digtable.backoff_enable_flag = true;
+        if ((rtlpriv->dm.dm_type == DM_TYPE_BYDRIVER) &&
+            (hal_get_firmwareversion(rtlpriv) >= 0x3c))
+                digtable.dig_algorithm = DIG_ALGO_BY_TOW_PORT;
+        else
+                digtable.dig_algorithm =
+                         DIG_ALGO_BEFORE_CONNECT_BY_RSSI_AND_ALARM;
+        digtable.dig_twoport_algorithm = DIG_TWO_PORT_ALGO_RSSI;
+        digtable.dig_ext_port_stage = DIG_EXT_PORT_STAGE_MAX;
+        /* off=by real rssi value, on=by digtable.rssi_val for new dig */
+        digtable.dig_dbgmode = DM_DBG_OFF;
+        digtable.dig_slgorithm_switch = 0;
+        /* 2007/10/04 MH Define init gain threshol. */
+        digtable.dig_state = DM_STA_DIG_MAX;
+        digtable.dig_highpwrstate = DM_STA_DIG_MAX;
+        digtable.cur_sta_connectstate = DIG_STA_DISCONNECT;
+        digtable.pre_sta_connectstate = DIG_STA_DISCONNECT;
+        digtable.cur_ap_connectstate = DIG_AP_DISCONNECT;
+        digtable.pre_ap_connectstate = DIG_AP_DISCONNECT;
+        digtable.rssi_lowthresh = DM_DIG_THRESH_LOW;
+        digtable.rssi_highthresh = DM_DIG_THRESH_HIGH;
+        digtable.fa_lowthresh = DM_FALSEALARM_THRESH_LOW;
+        digtable.fa_highthresh = DM_FALSEALARM_THRESH_HIGH;
+        digtable.rssi_highpower_lowthresh = DM_DIG_HIGH_PWR_THRESH_LOW;
+        digtable.rssi_highpower_highthresh = DM_DIG_HIGH_PWR_THRESH_HIGH;
+        /* for dig debug rssi value */
+        digtable.rssi_val = 50;
+        digtable.backoff_val = DM_DIG_BACKOFF;
+        digtable.rx_gain_range_max = DM_DIG_MAX;
+        digtable.rx_gain_range_min = DM_DIG_MIN;
+        digtable.backoffval_range_max = DM_DIG_BACKOFF_MAX;
+        digtable.backoffval_range_min = DM_DIG_BACKOFF_MIN;
+}
+static void _rtl92s_dm_init_dynamic_txpower(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        if ((hal_get_firmwareversion(rtlpriv) >= 60) &&
+            (rtlpriv->dm.dm_type == DM_TYPE_BYDRIVER))
+                rtlpriv->dm.dynamic_txpower_enable = true;
+        else
+                rtlpriv->dm.dynamic_txpower_enable = false;
+        rtlpriv->dm.last_dtp_lvl = TX_HIGHPWR_LEVEL_NORMAL;
+        rtlpriv->dm.dynamic_txhighpower_lvl = TX_HIGHPWR_LEVEL_NORMAL;
+}
+void rtl92s_dm_init(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        rtlpriv->dm.dm_type = DM_TYPE_BYDRIVER;
+        rtlpriv->dm.undecorated_smoothed_pwdb = -1;
+        _rtl92s_dm_init_dynamic_txpower(hw);
+        rtl92s_dm_init_edca_turbo(hw);
+        _rtl92s_dm_init_rate_adaptive_mask(hw);
+        _rtl92s_dm_init_txpowertracking_thermalmeter(hw);
+        _rtl92s_dm_init_dig(hw);
+        rtl_write_dword(rtlpriv, WFM5, FW_CCA_CHK_ENABLE);
+}
+void rtl92s_dm_watchdog(struct ieee80211_hw *hw)
+{
+        _rtl92s_dm_check_edca_turbo(hw);
+        _rtl92s_dm_check_txpowertracking_thermalmeter(hw);
+        _rtl92s_dm_ctrl_initgain_byrssi(hw);
+        _rtl92s_dm_dynamic_txpower(hw);
+        _rtl92s_dm_refresh_rateadaptive_mask(hw);
+        _rtl92s_dm_switch_baseband_mrc(hw);
+}
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/dm.h b/drivers/net/wireless/rtlwifi/rtl8192se/dm.h
new file mode 100644
index 000000000000..9051a556acc4
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/dm.h
@@ -0,0 +1,164 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#ifndef __RTL_92S_DM_H__
+#define __RTL_92S_DM_H__
+struct dig_t {
+        u8 dig_enable_flag;
+        u8 dig_algorithm;
+        u8 dig_twoport_algorithm;
+        u8 dig_ext_port_stage;
+        u8 dig_dbgmode;
+        u8 dig_slgorithm_switch;
+        long rssi_lowthresh;
+        long rssi_highthresh;
+        u32 fa_lowthresh;
+        u32 fa_highthresh;
+        long rssi_highpower_lowthresh;
+        long rssi_highpower_highthresh;
+        u8 dig_state;
+        u8 dig_highpwrstate;
+        u8 cur_sta_connectstate;
+        u8 pre_sta_connectstate;
+        u8 cur_ap_connectstate;
+        u8 pre_ap_connectstate;
+        u8 cur_pd_thstate;
+        u8 pre_pd_thstate;
+        u8 cur_cs_ratiostate;
+        u8 pre_cs_ratiostate;
+        u32 pre_igvalue;
+        u32     cur_igvalue;
+        u8 backoff_enable_flag;
+        char backoff_val;
+        char backoffval_range_max;
+        char backoffval_range_min;
+        u8 rx_gain_range_max;
+        u8 rx_gain_range_min;
+        long rssi_val;
+};
+enum dm_dig_alg {
+        DIG_ALGO_BY_FALSE_ALARM = 0,
+        DIG_ALGO_BY_RSSI        = 1,
+        DIG_ALGO_BEFORE_CONNECT_BY_RSSI_AND_ALARM = 2,
+        DIG_ALGO_BY_TOW_PORT = 3,
+        DIG_ALGO_MAX
+};
+enum dm_dig_two_port_alg {
+        DIG_TWO_PORT_ALGO_RSSI = 0,
+        DIG_TWO_PORT_ALGO_FALSE_ALARM = 1,
+};
+enum dm_dig_dbg {
+        DM_DBG_OFF = 0,
+        DM_DBG_ON = 1,
+        DM_DBG_MAX
+};
+enum dm_dig_sta {
+        DM_STA_DIG_OFF = 0,
+        DM_STA_DIG_ON,
+        DM_STA_DIG_MAX
+};
+enum dm_dig_connect {
+        DIG_STA_DISCONNECT = 0,
+        DIG_STA_CONNECT = 1,
+        DIG_STA_BEFORE_CONNECT = 2,
+        DIG_AP_DISCONNECT = 3,
+        DIG_AP_CONNECT = 4,
+        DIG_AP_ADD_STATION = 5,
+        DIG_CONNECT_MAX
+};
+enum dm_dig_ext_port_alg {
+        DIG_EXT_PORT_STAGE_0 = 0,
+        DIG_EXT_PORT_STAGE_1 = 1,
+        DIG_EXT_PORT_STAGE_2 = 2,
+        DIG_EXT_PORT_STAGE_3 = 3,
+        DIG_EXT_PORT_STAGE_MAX = 4,
+};
+enum dm_ratr_sta {
+        DM_RATR_STA_HIGH = 0,
+        DM_RATR_STA_MIDDLEHIGH = 1,
+        DM_RATR_STA_MIDDLE = 2,
+        DM_RATR_STA_MIDDLELOW = 3,
+        DM_RATR_STA_LOW = 4,
+        DM_RATR_STA_ULTRALOW = 5,
+        DM_RATR_STA_MAX
+};
+#define DM_TYPE_BYFW                    0
+#define DM_TYPE_BYDRIVER                1
+#define TX_HIGH_PWR_LEVEL_NORMAL        0
+#define TX_HIGH_PWR_LEVEL_LEVEL1        1
+#define TX_HIGH_PWR_LEVEL_LEVEL2        2
+#define HAL_DM_DIG_DISABLE              BIT(0)  /* Disable Dig */
+#define HAL_DM_HIPWR_DISABLE            BIT(1)  /* Disable High Power */
+#define TX_HIGHPWR_LEVEL_NORMAL         0
+#define TX_HIGHPWR_LEVEL_NORMAL1        1
+#define TX_HIGHPWR_LEVEL_NORMAL2        2
+#define TX_POWER_NEAR_FIELD_THRESH_LVL2 74
+#define TX_POWER_NEAR_FIELD_THRESH_LVL1 67
+#define DM_DIG_THRESH_HIGH              40
+#define DM_DIG_THRESH_LOW               35
+#define DM_FALSEALARM_THRESH_LOW        40
+#define DM_FALSEALARM_THRESH_HIGH       1000
+#define DM_DIG_HIGH_PWR_THRESH_HIGH     75
+#define DM_DIG_HIGH_PWR_THRESH_LOW      70
+#define DM_DIG_BACKOFF                  12
+#define DM_DIG_MAX                      0x3e
+#define DM_DIG_MIN                      0x1c
+#define DM_DIG_MIN_Netcore              0x12
+#define DM_DIG_BACKOFF_MAX              12
+#define DM_DIG_BACKOFF_MIN              -4
+extern struct dig_t digtable;
+void rtl92s_dm_watchdog(struct ieee80211_hw *hw);
+void rtl92s_dm_init(struct ieee80211_hw *hw);
+void rtl92s_dm_init_edca_turbo(struct ieee80211_hw *hw);
+#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/fw.c b/drivers/net/wireless/rtlwifi/rtl8192se/fw.c
new file mode 100644
index 000000000000..3b5af0113d7f
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/fw.c
@@ -0,0 +1,654 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#include "../wifi.h"
+#include "../pci.h"
+#include "../base.h"
+#include "reg.h"
+#include "def.h"
+#include "fw.h"
+static void _rtl92s_fw_set_rqpn(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        rtl_write_dword(rtlpriv, RQPN, 0xffffffff);
+        rtl_write_dword(rtlpriv, RQPN + 4, 0xffffffff);
+        rtl_write_byte(rtlpriv, RQPN + 8, 0xff);
+        rtl_write_byte(rtlpriv, RQPN + 0xB, 0x80);
+}
+static bool _rtl92s_firmware_enable_cpu(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u32 ichecktime = 200;
+        u16 tmpu2b;
+        u8 tmpu1b, cpustatus = 0;
+        _rtl92s_fw_set_rqpn(hw);
+        /* Enable CPU. */
+        tmpu1b = rtl_read_byte(rtlpriv, SYS_CLKR);
+        /* AFE source */
+        rtl_write_byte(rtlpriv, SYS_CLKR, (tmpu1b | SYS_CPU_CLKSEL));
+        tmpu2b = rtl_read_word(rtlpriv, REG_SYS_FUNC_EN);
+        rtl_write_word(rtlpriv, REG_SYS_FUNC_EN, (tmpu2b | FEN_CPUEN));
+        /* Polling IMEM Ready after CPU has refilled. */
+        do {
+                cpustatus = rtl_read_byte(rtlpriv, TCR);
+                if (cpustatus & IMEM_RDY) {
+                        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                                ("IMEM Ready after CPU has refilled.\n"));
+                        break;
+                }
+                udelay(100);
+        } while (ichecktime--);
+        if (!(cpustatus & IMEM_RDY))
+                return false;
+        return true;
+}
+static enum fw_status _rtl92s_firmware_get_nextstatus(
+                enum fw_status fw_currentstatus)
+{
+        enum fw_status  next_fwstatus = 0;
+        switch (fw_currentstatus) {
+        case FW_STATUS_INIT:
+                next_fwstatus = FW_STATUS_LOAD_IMEM;
+                break;
+        case FW_STATUS_LOAD_IMEM:
+                next_fwstatus = FW_STATUS_LOAD_EMEM;
+                break;
+        case FW_STATUS_LOAD_EMEM:
+                next_fwstatus = FW_STATUS_LOAD_DMEM;
+                break;
+        case FW_STATUS_LOAD_DMEM:
+                next_fwstatus = FW_STATUS_READY;
+                break;
+        default:
+                break;
+        }
+        return next_fwstatus;
+}
+static u8 _rtl92s_firmware_header_map_rftype(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        switch (rtlphy->rf_type) {
+        case RF_1T1R:
+                return 0x11;
+                break;
+        case RF_1T2R:
+                return 0x12;
+                break;
+        case RF_2T2R:
+                return 0x22;
+                break;
+        default:
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
+                         ("Unknown RF type(%x)\n",
+                         rtlphy->rf_type));
+                break;
+        }
+        return 0x22;
+}
+static void _rtl92s_firmwareheader_priveupdate(struct ieee80211_hw *hw,
+                struct fw_priv *pfw_priv)
+{
+        /* Update RF types for RATR settings. */
+        pfw_priv->rf_config = _rtl92s_firmware_header_map_rftype(hw);
+}
+static bool _rtl92s_cmd_send_packet(struct ieee80211_hw *hw,
+                struct sk_buff *skb, u8 last)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl8192_tx_ring *ring;
+        struct rtl_tx_desc *pdesc;
+        unsigned long flags;
+        u8 idx = 0;
+        ring = &rtlpci->tx_ring[TXCMD_QUEUE];
+        spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
+        idx = (ring->idx + skb_queue_len(&ring->queue)) % ring->entries;
+        pdesc = &ring->desc[idx];
+        rtlpriv->cfg->ops->fill_tx_cmddesc(hw, (u8 *)pdesc, 1, 1, skb);
+        __skb_queue_tail(&ring->queue, skb);
+        spin_unlock_irqrestore(&rtlpriv->locks.irq_th_lock, flags);
+        return true;
+}
+static bool _rtl92s_firmware_downloadcode(struct ieee80211_hw *hw,
+                u8 *code_virtual_address, u32 buffer_len)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct sk_buff *skb;
+        struct rtl_tcb_desc *tcb_desc;
+        unsigned char *seg_ptr;
+        u16 frag_threshold = MAX_FIRMWARE_CODE_SIZE;
+        u16 frag_length, frag_offset = 0;
+        u16 extra_descoffset = 0;
+        u8 last_inipkt = 0;
+        _rtl92s_fw_set_rqpn(hw);
+        if (buffer_len >= MAX_FIRMWARE_CODE_SIZE) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                        ("Size over FIRMWARE_CODE_SIZE!\n"));
+                return false;
+        }
+        extra_descoffset = 0;
+        do {
+                if ((buffer_len - frag_offset) > frag_threshold) {
+                        frag_length = frag_threshold + extra_descoffset;
+                } else {
+                        frag_length = (u16)(buffer_len - frag_offset +
+                                            extra_descoffset);
+                        last_inipkt = 1;
+                }
+                /* Allocate skb buffer to contain firmware */
+                /* info and tx descriptor info. */
+                skb = dev_alloc_skb(frag_length);
+                skb_reserve(skb, extra_descoffset);
+                seg_ptr = (u8 *)skb_put(skb, (u32)(frag_length -
+                                        extra_descoffset));
+                memcpy(seg_ptr, code_virtual_address + frag_offset,
+                       (u32)(frag_length - extra_descoffset));
+                tcb_desc = (struct rtl_tcb_desc *)(skb->cb);
+                tcb_desc->queue_index = TXCMD_QUEUE;
+                tcb_desc->cmd_or_init = DESC_PACKET_TYPE_INIT;
+                tcb_desc->last_inipkt = last_inipkt;
+                _rtl92s_cmd_send_packet(hw, skb, last_inipkt);
+                frag_offset += (frag_length - extra_descoffset);
+        } while (frag_offset < buffer_len);
+        rtl_write_byte(rtlpriv, TP_POLL, TPPOLL_CQ);
+        return true ;
+}
+static bool _rtl92s_firmware_checkready(struct ieee80211_hw *hw,
+                u8 loadfw_status)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rt_firmware *firmware = (struct rt_firmware *)rtlhal->pfirmware;
+        u32 tmpu4b;
+        u8 cpustatus = 0;
+        short pollingcnt = 1000;
+        bool rtstatus = true;
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, ("LoadStaus(%d)\n",
+                 loadfw_status));
+        firmware->fwstatus = (enum fw_status)loadfw_status;
+        switch (loadfw_status) {
+        case FW_STATUS_LOAD_IMEM:
+                /* Polling IMEM code done. */
+                do {
+                        cpustatus = rtl_read_byte(rtlpriv, TCR);
+                        if (cpustatus & IMEM_CODE_DONE)
+                                break;
+                        udelay(5);
+                } while (pollingcnt--);
+                if (!(cpustatus & IMEM_CHK_RPT) || (pollingcnt <= 0)) {
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                 ("FW_STATUS_LOAD_IMEM"
+                                 " FAIL CPU, Status=%x\r\n", cpustatus));
+                        goto status_check_fail;
+                }
+                break;
+        case FW_STATUS_LOAD_EMEM:
+                /* Check Put Code OK and Turn On CPU */
+                /* Polling EMEM code done. */
+                do {
+                        cpustatus = rtl_read_byte(rtlpriv, TCR);
+                        if (cpustatus & EMEM_CODE_DONE)
+                                break;
+                        udelay(5);
+                } while (pollingcnt--);
+                if (!(cpustatus & EMEM_CHK_RPT) || (pollingcnt <= 0)) {
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                 ("FW_STATUS_LOAD_EMEM"
+                                 " FAIL CPU, Status=%x\r\n", cpustatus));
+                        goto status_check_fail;
+                }
+                /* Turn On CPU */
+                rtstatus = _rtl92s_firmware_enable_cpu(hw);
+                if (rtstatus != true) {
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                 ("Enable CPU fail!\n"));
+                        goto status_check_fail;
+                }
+                break;
+        case FW_STATUS_LOAD_DMEM:
+                /* Polling DMEM code done */
+                do {
+                        cpustatus = rtl_read_byte(rtlpriv, TCR);
+                        if (cpustatus & DMEM_CODE_DONE)
+                                break;
+                        udelay(5);
+                } while (pollingcnt--);
+                if (!(cpustatus & DMEM_CODE_DONE) || (pollingcnt <= 0)) {
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                 ("Polling  DMEM code done"
+                                 " fail ! cpustatus(%#x)\n", cpustatus));
+                        goto status_check_fail;
+                }
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                         ("DMEM code download success,"
+                        " cpustatus(%#x)\n", cpustatus));
+                /* Prevent Delay too much and being scheduled out */
+                /* Polling Load Firmware ready */
+                pollingcnt = 2000;
+                do {
+                        cpustatus = rtl_read_byte(rtlpriv, TCR);
+                        if (cpustatus & FWRDY)
+                                break;
+                        udelay(40);
+                } while (pollingcnt--);
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                         ("Polling Load Firmware ready,"
+                        " cpustatus(%x)\n",     cpustatus));
+                if (((cpustatus & LOAD_FW_READY) != LOAD_FW_READY) ||
+                    (pollingcnt <= 0)) {
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                 ("Polling Load Firmware"
+                                " ready fail ! cpustatus(%x)\n", cpustatus));
+                        goto status_check_fail;
+                }
+                /* If right here, we can set TCR/RCR to desired value  */
+                /* and config MAC lookback mode to normal mode */
+                tmpu4b = rtl_read_dword(rtlpriv, TCR);
+                rtl_write_dword(rtlpriv, TCR, (tmpu4b & (~TCR_ICV)));
+                tmpu4b = rtl_read_dword(rtlpriv, RCR);
+                rtl_write_dword(rtlpriv, RCR, (tmpu4b | RCR_APPFCS |
+                                RCR_APP_ICV | RCR_APP_MIC));
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                         ("Current RCR settings(%#x)\n", tmpu4b));
+                /* Set to normal mode. */
+                rtl_write_byte(rtlpriv, LBKMD_SEL, LBK_NORMAL);
+                break;
+        default:
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
+                         ("Unknown status check!\n"));
+                rtstatus = false;
+                break;
+        }
+status_check_fail:
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, ("loadfw_status(%d), "
+                 "rtstatus(%x)\n", loadfw_status, rtstatus));
+        return rtstatus;
+}
+int rtl92s_download_fw(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rt_firmware *firmware = NULL;
+        struct fw_hdr *pfwheader;
+        struct fw_priv *pfw_priv = NULL;
+        u8 *puc_mappedfile = NULL;
+        u32 ul_filelength = 0;
+        u32 file_length = 0;
+        u8 fwhdr_size = RT_8192S_FIRMWARE_HDR_SIZE;
+        u8 fwstatus = FW_STATUS_INIT;
+        bool rtstatus = true;
+        if (!rtlhal->pfirmware)
+                return 1;
+        firmware = (struct rt_firmware *)rtlhal->pfirmware;
+        firmware->fwstatus = FW_STATUS_INIT;
+        puc_mappedfile = firmware->sz_fw_tmpbuffer;
+        file_length = firmware->sz_fw_tmpbufferlen;
+        /* 1. Retrieve FW header. */
+        firmware->pfwheader = (struct fw_hdr *) puc_mappedfile;
+        pfwheader = firmware->pfwheader;
+        firmware->firmwareversion =  byte(pfwheader->version, 0);
+        firmware->pfwheader->fwpriv.hci_sel = 1;/* pcie */
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, ("signature:%x, version:"
+                 "%x, size:%x,"
+                 "imemsize:%x, sram size:%x\n", pfwheader->signature,
+                 pfwheader->version, pfwheader->dmem_size,
+                 pfwheader->img_imem_size, pfwheader->img_sram_size));
+        /* 2. Retrieve IMEM image. */
+        if ((pfwheader->img_imem_size == 0) || (pfwheader->img_imem_size >
+            sizeof(firmware->fw_imem))) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                        ("memory for data image is less than IMEM required\n"));
+                goto fail;
+        } else {
+                puc_mappedfile += fwhdr_size;
+                memcpy(firmware->fw_imem, puc_mappedfile,
+                       pfwheader->img_imem_size);
+                firmware->fw_imem_len = pfwheader->img_imem_size;
+        }
+        /* 3. Retriecve EMEM image. */
+        if (pfwheader->img_sram_size > sizeof(firmware->fw_emem)) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                        ("memory for data image is less than EMEM required\n"));
+                goto fail;
+        } else {
+                puc_mappedfile += firmware->fw_imem_len;
+                memcpy(firmware->fw_emem, puc_mappedfile,
+                       pfwheader->img_sram_size);
+                firmware->fw_emem_len = pfwheader->img_sram_size;
+        }
+        /* 4. download fw now */
+        fwstatus = _rtl92s_firmware_get_nextstatus(firmware->fwstatus);
+        while (fwstatus != FW_STATUS_READY) {
+                /* Image buffer redirection. */
+                switch (fwstatus) {
+                case FW_STATUS_LOAD_IMEM:
+                        puc_mappedfile = firmware->fw_imem;
+                        ul_filelength = firmware->fw_imem_len;
+                        break;
+                case FW_STATUS_LOAD_EMEM:
+                        puc_mappedfile = firmware->fw_emem;
+                        ul_filelength = firmware->fw_emem_len;
+                        break;
+                case FW_STATUS_LOAD_DMEM:
+                        /* Partial update the content of header private. */
+                        pfwheader = firmware->pfwheader;
+                        pfw_priv = &pfwheader->fwpriv;
+                        _rtl92s_firmwareheader_priveupdate(hw, pfw_priv);
+                        puc_mappedfile = (u8 *)(firmware->pfwheader) +
+                                        RT_8192S_FIRMWARE_HDR_EXCLUDE_PRI_SIZE;
+                        ul_filelength = fwhdr_size -
+                                        RT_8192S_FIRMWARE_HDR_EXCLUDE_PRI_SIZE;
+                        break;
+                default:
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                        ("Unexpected Download step!!\n"));
+                        goto fail;
+                        break;
+                }
+                /* <2> Download image file */
+                rtstatus = _rtl92s_firmware_downloadcode(hw, puc_mappedfile,
+                                ul_filelength);
+                if (rtstatus != true) {
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, ("fail!\n"));
+                        goto fail;
+                }
+                /* <3> Check whether load FW process is ready */
+                rtstatus = _rtl92s_firmware_checkready(hw, fwstatus);
+                if (rtstatus != true) {
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, ("fail!\n"));
+                        goto fail;
+                }
+                fwstatus = _rtl92s_firmware_get_nextstatus(firmware->fwstatus);
+        }
+        return rtstatus;
+fail:
+        return 0;
+}
+static u32 _rtl92s_fill_h2c_cmd(struct sk_buff *skb, u32 h2cbufferlen,
+                                u32 cmd_num, u32 *pelement_id, u32 *pcmd_len,
+                                u8 **pcmb_buffer, u8 *cmd_start_seq)
+{
+        u32 totallen = 0, len = 0, tx_desclen = 0;
+        u32 pre_continueoffset = 0;
+        u8 *ph2c_buffer;
+        u8 i = 0;
+        do {
+                /* 8 - Byte aligment */
+                len = H2C_TX_CMD_HDR_LEN + N_BYTE_ALIGMENT(pcmd_len[i], 8);
+                /* Buffer length is not enough */
+                if (h2cbufferlen < totallen + len + tx_desclen)
+                        break;
+                /* Clear content */
+                ph2c_buffer = (u8 *)skb_put(skb, (u32)len);
+                memset((ph2c_buffer + totallen + tx_desclen), 0, len);
+                /* CMD len */
+                SET_BITS_TO_LE_4BYTE((ph2c_buffer + totallen + tx_desclen),
+                                      0, 16, pcmd_len[i]);
+                /* CMD ID */
+                SET_BITS_TO_LE_4BYTE((ph2c_buffer + totallen + tx_desclen),
+                                      16, 8, pelement_id[i]);
+                /* CMD Sequence */
+                *cmd_start_seq = *cmd_start_seq % 0x80;
+                SET_BITS_TO_LE_4BYTE((ph2c_buffer + totallen + tx_desclen),
+                                      24, 7, *cmd_start_seq);
+                ++*cmd_start_seq;
+                /* Copy memory */
+                memcpy((ph2c_buffer + totallen + tx_desclen +
+                        H2C_TX_CMD_HDR_LEN), pcmb_buffer[i], pcmd_len[i]);
+                /* CMD continue */
+                /* set the continue in prevoius cmd. */
+                if (i < cmd_num - 1)
+                        SET_BITS_TO_LE_4BYTE((ph2c_buffer + pre_continueoffset),
+                                              31, 1, 1);
+                pre_continueoffset = totallen;
+                totallen += len;
+        } while (++i < cmd_num);
+        return totallen;
+}
+static u32 _rtl92s_get_h2c_cmdlen(u32 h2cbufferlen, u32 cmd_num, u32 *pcmd_len)
+{
+        u32 totallen = 0, len = 0, tx_desclen = 0;
+        u8 i = 0;
+        do {
+                /* 8 - Byte aligment */
+                len = H2C_TX_CMD_HDR_LEN + N_BYTE_ALIGMENT(pcmd_len[i], 8);
+                /* Buffer length is not enough */
+                if (h2cbufferlen < totallen + len + tx_desclen)
+                        break;
+                totallen += len;
+        } while (++i < cmd_num);
+        return totallen + tx_desclen;
+}
+static bool _rtl92s_firmware_set_h2c_cmd(struct ieee80211_hw *hw, u8 h2c_cmd,
+                                         u8 *pcmd_buffer)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_tcb_desc *cb_desc;
+        struct sk_buff *skb;
+        u32     element_id = 0;
+        u32     cmd_len = 0;
+        u32     len;
+        switch (h2c_cmd) {
+        case FW_H2C_SETPWRMODE:
+                element_id = H2C_SETPWRMODE_CMD ;
+                cmd_len = sizeof(struct h2c_set_pwrmode_parm);
+                break;
+        case FW_H2C_JOINBSSRPT:
+                element_id = H2C_JOINBSSRPT_CMD;
+                cmd_len = sizeof(struct h2c_joinbss_rpt_parm);
+                break;
+        case FW_H2C_WOWLAN_UPDATE_GTK:
+                element_id = H2C_WOWLAN_UPDATE_GTK_CMD;
+                cmd_len = sizeof(struct h2c_wpa_two_way_parm);
+                break;
+        case FW_H2C_WOWLAN_UPDATE_IV:
+                element_id = H2C_WOWLAN_UPDATE_IV_CMD;
+                cmd_len = sizeof(unsigned long long);
+                break;
+        case FW_H2C_WOWLAN_OFFLOAD:
+                element_id = H2C_WOWLAN_FW_OFFLOAD;
+                cmd_len = sizeof(u8);
+                break;
+        default:
+                break;
+        }
+        len = _rtl92s_get_h2c_cmdlen(MAX_TRANSMIT_BUFFER_SIZE, 1, &cmd_len);
+        skb = dev_alloc_skb(len);
+        cb_desc = (struct rtl_tcb_desc *)(skb->cb);
+        cb_desc->queue_index = TXCMD_QUEUE;
+        cb_desc->cmd_or_init = DESC_PACKET_TYPE_NORMAL;
+        cb_desc->last_inipkt = false;
+        _rtl92s_fill_h2c_cmd(skb, MAX_TRANSMIT_BUFFER_SIZE, 1, &element_id,
+                        &cmd_len, &pcmd_buffer, &rtlhal->h2c_txcmd_seq);
+        _rtl92s_cmd_send_packet(hw, skb, false);
+        rtlpriv->cfg->ops->tx_polling(hw, TXCMD_QUEUE);
+        return true;
+}
+void rtl92s_set_fw_pwrmode_cmd(struct ieee80211_hw *hw, u8 Mode)
+{
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        struct h2c_set_pwrmode_parm     pwrmode;
+        u16 max_wakeup_period = 0;
+        pwrmode.mode = Mode;
+        pwrmode.flag_low_traffic_en = 0;
+        pwrmode.flag_lpnav_en = 0;
+        pwrmode.flag_rf_low_snr_en = 0;
+        pwrmode.flag_dps_en = 0;
+        pwrmode.bcn_rx_en = 0;
+        pwrmode.bcn_to = 0;
+        SET_BITS_TO_LE_2BYTE((u8 *)(&pwrmode) + 8, 0, 16,
+                        mac->vif->bss_conf.beacon_int);
+        pwrmode.app_itv = 0;
+        pwrmode.awake_bcn_itvl = ppsc->reg_max_lps_awakeintvl;
+        pwrmode.smart_ps = 1;
+        pwrmode.bcn_pass_period = 10;
+        /* Set beacon pass count */
+        if (pwrmode.mode == FW_PS_MIN_MODE)
+                max_wakeup_period = mac->vif->bss_conf.beacon_int;
+        else if (pwrmode.mode == FW_PS_MAX_MODE)
+                max_wakeup_period = mac->vif->bss_conf.beacon_int *
+                        mac->vif->bss_conf.dtim_period;
+        if (max_wakeup_period >= 500)
+                pwrmode.bcn_pass_cnt = 1;
+        else if ((max_wakeup_period >= 300) && (max_wakeup_period < 500))
+                pwrmode.bcn_pass_cnt = 2;
+        else if ((max_wakeup_period >= 200) && (max_wakeup_period < 300))
+                pwrmode.bcn_pass_cnt = 3;
+        else if ((max_wakeup_period >= 20) && (max_wakeup_period < 200))
+                pwrmode.bcn_pass_cnt = 5;
+        else
+                pwrmode.bcn_pass_cnt = 1;
+        _rtl92s_firmware_set_h2c_cmd(hw, FW_H2C_SETPWRMODE, (u8 *)&pwrmode);
+}
+void rtl92s_set_fw_joinbss_report_cmd(struct ieee80211_hw *hw,
+                u8 mstatus, u8 ps_qosinfo)
+{
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct h2c_joinbss_rpt_parm joinbss_rpt;
+        joinbss_rpt.opmode = mstatus;
+        joinbss_rpt.ps_qos_info = ps_qosinfo;
+        joinbss_rpt.bssid[0] = mac->bssid[0];
+        joinbss_rpt.bssid[1] = mac->bssid[1];
+        joinbss_rpt.bssid[2] = mac->bssid[2];
+        joinbss_rpt.bssid[3] = mac->bssid[3];
+        joinbss_rpt.bssid[4] = mac->bssid[4];
+        joinbss_rpt.bssid[5] = mac->bssid[5];
+        SET_BITS_TO_LE_2BYTE((u8 *)(&joinbss_rpt) + 8, 0, 16,
+                        mac->vif->bss_conf.beacon_int);
+        SET_BITS_TO_LE_2BYTE((u8 *)(&joinbss_rpt) + 10, 0, 16, mac->assoc_id);
+        _rtl92s_firmware_set_h2c_cmd(hw, FW_H2C_JOINBSSRPT, (u8 *)&joinbss_rpt);
+}
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/fw.h b/drivers/net/wireless/rtlwifi/rtl8192se/fw.h
new file mode 100644
index 000000000000..74cc503efe8a
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/fw.h
@@ -0,0 +1,375 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#ifndef __REALTEK_FIRMWARE92S_H__
+#define __REALTEK_FIRMWARE92S_H__
+#define RTL8190_MAX_FIRMWARE_CODE_SIZE          64000
+#define RTL8190_CPU_START_OFFSET                0x80
+/* Firmware Local buffer size. 64k */
+#define MAX_FIRMWARE_CODE_SIZE                  0xFF00
+#define RT_8192S_FIRMWARE_HDR_SIZE              80
+#define RT_8192S_FIRMWARE_HDR_EXCLUDE_PRI_SIZE  32
+/* support till 64 bit bus width OS */
+#define MAX_DEV_ADDR_SIZE                       8
+#define MAX_FIRMWARE_INFORMATION_SIZE           32
+#define MAX_802_11_HEADER_LENGTH                (40 + \
+                                                MAX_FIRMWARE_INFORMATION_SIZE)
+#define ENCRYPTION_MAX_OVERHEAD                 128
+#define MAX_FRAGMENT_COUNT                      8
+#define MAX_TRANSMIT_BUFFER_SIZE                (1600 + \
+                                                (MAX_802_11_HEADER_LENGTH + \
+                                                ENCRYPTION_MAX_OVERHEAD) *\
+                                                MAX_FRAGMENT_COUNT)
+#define H2C_TX_CMD_HDR_LEN                      8
+/* The following DM control code are for Reg0x364, */
+#define FW_DIG_ENABLE_CTL                       BIT(0)
+#define FW_HIGH_PWR_ENABLE_CTL                  BIT(1)
+#define FW_SS_CTL                               BIT(2)
+#define FW_RA_INIT_CTL                          BIT(3)
+#define FW_RA_BG_CTL                            BIT(4)
+#define FW_RA_N_CTL                             BIT(5)
+#define FW_PWR_TRK_CTL                          BIT(6)
+#define FW_IQK_CTL                              BIT(7)
+#define FW_FA_CTL                               BIT(8)
+#define FW_DRIVER_CTRL_DM_CTL                   BIT(9)
+#define FW_PAPE_CTL_BY_SW_HW                    BIT(10)
+#define FW_DISABLE_ALL_DM                       0
+#define FW_PWR_TRK_PARAM_CLR                    0x0000ffff
+#define FW_RA_PARAM_CLR                         0xffff0000
+enum desc_packet_type {
+        DESC_PACKET_TYPE_INIT = 0,
+        DESC_PACKET_TYPE_NORMAL = 1,
+};
+/* 8-bytes alignment required */
+struct fw_priv {
+        /* --- long word 0 ---- */
+        /* 0x12: CE product, 0x92: IT product */
+        u8 signature_0;
+        /* 0x87: CE product, 0x81: IT product */
+        u8 signature_1;
+        /* 0x81: PCI-AP, 01:PCIe, 02: 92S-U,
+         * 0x82: USB-AP, 0x12: 72S-U, 03:SDIO */
+        u8 hci_sel;
+        /* the same value as reigster value  */
+        u8 chip_version;
+        /* customer  ID low byte */
+        u8 customer_id_0;
+        /* customer  ID high byte */
+        u8 customer_id_1;
+        /* 0x11:  1T1R, 0x12: 1T2R,
+         * 0x92: 1T2R turbo, 0x22: 2T2R */
+        u8 rf_config;
+        /* 4: 4EP, 6: 6EP, 11: 11EP */
+        u8 usb_ep_num;
+        /* --- long word 1 ---- */
+        /* regulatory class bit map 0 */
+        u8 regulatory_class_0;
+        /* regulatory class bit map 1 */
+        u8 regulatory_class_1;
+        /* regulatory class bit map 2 */
+        u8 regulatory_class_2;
+        /* regulatory class bit map 3 */
+        u8 regulatory_class_3;
+        /* 0:SWSI, 1:HWSI, 2:HWPI */
+        u8 rfintfs;
+        u8 def_nettype;
+        u8 rsvd010;
+        u8 rsvd011;
+        /* --- long word 2 ---- */
+        /* 0x00: normal, 0x03: MACLBK, 0x01: PHYLBK */
+        u8 lbk_mode;
+        /* 1: for MP use, 0: for normal
+         * driver (to be discussed) */
+        u8 mp_mode;
+        u8 rsvd020;
+        u8 rsvd021;
+        u8 rsvd022;
+        u8 rsvd023;
+        u8 rsvd024;
+        u8 rsvd025;
+        /* --- long word 3 ---- */
+        /* QoS enable */
+        u8 qos_en;
+        /* 40MHz BW enable */
+        /* 4181 convert AMSDU to AMPDU, 0: disable */
+        u8 bw_40mhz_en;
+        u8 amsdu2ampdu_en;
+        /* 11n AMPDU enable */
+        u8 ampdu_en;
+        /* FW offloads, 0: driver handles */
+        u8 rate_control_offload;
+        /* FW offloads, 0: driver handles */
+        u8 aggregation_offload;
+        u8 rsvd030;
+        u8 rsvd031;
+        /* --- long word 4 ---- */
+        /* 1. FW offloads, 0: driver handles */
+        u8 beacon_offload;
+        /* 2. FW offloads, 0: driver handles */
+        u8 mlme_offload;
+        /* 3. FW offloads, 0: driver handles */
+        u8 hwpc_offload;
+        /* 4. FW offloads, 0: driver handles */
+        u8 tcp_checksum_offload;
+        /* 5. FW offloads, 0: driver handles */
+        u8 tcp_offload;
+        /* 6. FW offloads, 0: driver handles */
+        u8 ps_control_offload;
+        /* 7. FW offloads, 0: driver handles */
+        u8 wwlan_offload;
+        u8 rsvd040;
+        /* --- long word 5 ---- */
+        /* tcp tx packet length low byte */
+        u8 tcp_tx_frame_len_L;
+        /* tcp tx packet length high byte */
+        u8 tcp_tx_frame_len_H;
+        /* tcp rx packet length low byte */
+        u8 tcp_rx_frame_len_L;
+        /* tcp rx packet length high byte */
+        u8 tcp_rx_frame_len_H;
+        u8 rsvd050;
+        u8 rsvd051;
+        u8 rsvd052;
+        u8 rsvd053;
+};
+/* 8-byte alinment required */
+struct fw_hdr {
+        /* --- LONG WORD 0 ---- */
+        u16 signature;
+        /* 0x8000 ~ 0x8FFF for FPGA version,
+         * 0x0000 ~ 0x7FFF for ASIC version, */
+        u16 version;
+        /* define the size of boot loader */
+        u32 dmem_size;
+        /* --- LONG WORD 1 ---- */
+        /* define the size of FW in IMEM */
+        u32 img_imem_size;
+        /* define the size of FW in SRAM */
+        u32 img_sram_size;
+        /* --- LONG WORD 2 ---- */
+        /* define the size of DMEM variable */
+        u32 fw_priv_size;
+        u32 rsvd0;
+        /* --- LONG WORD 3 ---- */
+        u32 rsvd1;
+        u32 rsvd2;
+        struct fw_priv fwpriv;
+} ;
+enum fw_status {
+        FW_STATUS_INIT = 0,
+        FW_STATUS_LOAD_IMEM = 1,
+        FW_STATUS_LOAD_EMEM = 2,
+        FW_STATUS_LOAD_DMEM = 3,
+        FW_STATUS_READY = 4,
+};
+struct rt_firmware {
+        struct fw_hdr *pfwheader;
+        enum fw_status fwstatus;
+        u16 firmwareversion;
+        u8 fw_imem[RTL8190_MAX_FIRMWARE_CODE_SIZE];
+        u8 fw_emem[RTL8190_MAX_FIRMWARE_CODE_SIZE];
+        u32 fw_imem_len;
+        u32 fw_emem_len;
+        u8 sz_fw_tmpbuffer[164000];
+        u32 sz_fw_tmpbufferlen;
+        u16 cmdpacket_fragthresold;
+};
+struct h2c_set_pwrmode_parm {
+        u8 mode;
+        u8 flag_low_traffic_en;
+        u8 flag_lpnav_en;
+        u8 flag_rf_low_snr_en;
+        /* 1: dps, 0: 32k */
+        u8 flag_dps_en;
+        u8 bcn_rx_en;
+        u8 bcn_pass_cnt;
+        /* beacon TO (ms). ¡§=0¡¨ no limit. */
+        u8 bcn_to;
+        u16     bcn_itv;
+        /* only for VOIP mode. */
+        u8 app_itv;
+        u8 awake_bcn_itvl;
+        u8 smart_ps;
+        /* unit: 100 ms */
+        u8 bcn_pass_period;
+};
+struct h2c_joinbss_rpt_parm {
+        u8 opmode;
+        u8 ps_qos_info;
+        u8 bssid[6];
+        u16 bcnitv;
+        u16 aid;
+} ;
+struct h2c_wpa_ptk {
+        /* EAPOL-Key Key Confirmation Key (KCK) */
+        u8 kck[16];
+        /* EAPOL-Key Key Encryption Key (KEK) */
+        u8 kek[16];
+        /* Temporal Key 1 (TK1) */
+        u8 tk1[16];
+        union {
+                /* Temporal Key 2 (TK2) */
+                u8 tk2[16];
+                struct {
+                        u8 tx_mic_key[8];
+                        u8 rx_mic_key[8];
+                } athu;
+        } u;
+};
+struct h2c_wpa_two_way_parm {
+        /* algorithm TKIP or AES */
+        u8 pairwise_en_alg;
+        u8 group_en_alg;
+        struct h2c_wpa_ptk wpa_ptk_value;
+} ;
+enum h2c_cmd {
+        FW_H2C_SETPWRMODE = 0,
+        FW_H2C_JOINBSSRPT = 1,
+        FW_H2C_WOWLAN_UPDATE_GTK = 2,
+        FW_H2C_WOWLAN_UPDATE_IV = 3,
+        FW_H2C_WOWLAN_OFFLOAD = 4,
+};
+enum fw_h2c_cmd {
+        H2C_READ_MACREG_CMD,                            /*0*/
+        H2C_WRITE_MACREG_CMD,
+        H2C_READBB_CMD,
+        H2C_WRITEBB_CMD,
+        H2C_READRF_CMD,
+        H2C_WRITERF_CMD,                                /*5*/
+        H2C_READ_EEPROM_CMD,
+        H2C_WRITE_EEPROM_CMD,
+        H2C_READ_EFUSE_CMD,
+        H2C_WRITE_EFUSE_CMD,
+        H2C_READ_CAM_CMD,                               /*10*/
+        H2C_WRITE_CAM_CMD,
+        H2C_SETBCNITV_CMD,
+        H2C_SETMBIDCFG_CMD,
+        H2C_JOINBSS_CMD,
+        H2C_DISCONNECT_CMD,                             /*15*/
+        H2C_CREATEBSS_CMD,
+        H2C_SETOPMode_CMD,
+        H2C_SITESURVEY_CMD,
+        H2C_SETAUTH_CMD,
+        H2C_SETKEY_CMD,                                 /*20*/
+        H2C_SETSTAKEY_CMD,
+        H2C_SETASSOCSTA_CMD,
+        H2C_DELASSOCSTA_CMD,
+        H2C_SETSTAPWRSTATE_CMD,
+        H2C_SETBASICRATE_CMD,                           /*25*/
+        H2C_GETBASICRATE_CMD,
+        H2C_SETDATARATE_CMD,
+        H2C_GETDATARATE_CMD,
+        H2C_SETPHYINFO_CMD,
+        H2C_GETPHYINFO_CMD,                             /*30*/
+        H2C_SETPHY_CMD,
+        H2C_GETPHY_CMD,
+        H2C_READRSSI_CMD,
+        H2C_READGAIN_CMD,
+        H2C_SETATIM_CMD,                                /*35*/
+        H2C_SETPWRMODE_CMD,
+        H2C_JOINBSSRPT_CMD,
+        H2C_SETRATABLE_CMD,
+        H2C_GETRATABLE_CMD,
+        H2C_GETCCXREPORT_CMD,                           /*40*/
+        H2C_GETDTMREPORT_CMD,
+        H2C_GETTXRATESTATICS_CMD,
+        H2C_SETUSBSUSPEND_CMD,
+        H2C_SETH2CLBK_CMD,
+        H2C_TMP1,                                       /*45*/
+        H2C_WOWLAN_UPDATE_GTK_CMD,
+        H2C_WOWLAN_FW_OFFLOAD,
+        H2C_TMP2,
+        H2C_TMP3,
+        H2C_WOWLAN_UPDATE_IV_CMD,                       /*50*/
+        H2C_TMP4,
+        MAX_H2CCMD                                      /*52*/
+};
+/* The following macros are used for FW
+ * CMD map and parameter updated. */
+#define FW_CMD_IO_CLR(rtlpriv, _Bit)                            \
+        do {                                                    \
+                udelay(1000);                                   \
+                rtlpriv->rtlhal.fwcmd_iomap &= (~_Bit);         \
+        } while (0);
+#define FW_CMD_IO_UPDATE(rtlpriv, _val)                         \
+        rtlpriv->rtlhal.fwcmd_iomap = _val;
+#define FW_CMD_IO_SET(rtlpriv, _val)                            \
+        do {                                                    \
+                rtl_write_word(rtlpriv, LBUS_MON_ADDR, (u16)_val);      \
+                FW_CMD_IO_UPDATE(rtlpriv, _val);                \
+        } while (0);
+#define FW_CMD_PARA_SET(rtlpriv, _val)                          \
+        do {                                                    \
+                rtl_write_dword(rtlpriv, LBUS_ADDR_MASK, _val); \
+                rtlpriv->rtlhal.fwcmd_ioparam = _val;           \
+        } while (0);
+#define FW_CMD_IO_QUERY(rtlpriv)                                \
+        (u16)(rtlpriv->rtlhal.fwcmd_iomap)
+#define FW_CMD_IO_PARA_QUERY(rtlpriv)                           \
+        ((u32)(rtlpriv->rtlhal.fwcmd_ioparam))
+int rtl92s_download_fw(struct ieee80211_hw *hw);
+void rtl92s_set_fw_pwrmode_cmd(struct ieee80211_hw *hw, u8 mode);
+void rtl92s_set_fw_joinbss_report_cmd(struct ieee80211_hw *hw,
+                                      u8 mstatus, u8 ps_qosinfo);
+#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/hw.c b/drivers/net/wireless/rtlwifi/rtl8192se/hw.c
new file mode 100644
index 000000000000..2e9005d0454b
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/hw.c
@@ -0,0 +1,2512 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#include "../wifi.h"
+#include "../efuse.h"
+#include "../base.h"
+#include "../regd.h"
+#include "../cam.h"
+#include "../ps.h"
+#include "../pci.h"
+#include "reg.h"
+#include "def.h"
+#include "phy.h"
+#include "dm.h"
+#include "fw.h"
+#include "led.h"
+#include "hw.h"
+void rtl92se_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        switch (variable) {
+        case HW_VAR_RCR: {
+                        *((u32 *) (val)) = rtlpci->receive_config;
+                        break;
+                }
+        case HW_VAR_RF_STATE: {
+                        *((enum rf_pwrstate *)(val)) = ppsc->rfpwr_state;
+                        break;
+                }
+        case HW_VAR_FW_PSMODE_STATUS: {
+                        *((bool *) (val)) = ppsc->fw_current_inpsmode;
+                        break;
+                }
+        case HW_VAR_CORRECT_TSF: {
+                        u64 tsf;
+                        u32 *ptsf_low = (u32 *)&tsf;
+                        u32 *ptsf_high = ((u32 *)&tsf) + 1;
+                        *ptsf_high = rtl_read_dword(rtlpriv, (TSFR + 4));
+                        *ptsf_low = rtl_read_dword(rtlpriv, TSFR);
+                        *((u64 *) (val)) = tsf;
+                        break;
+                }
+        case HW_VAR_MRC: {
+                        *((bool *)(val)) = rtlpriv->dm.current_mrc_switch;
+                        break;
+                }
+        default: {
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                 ("switch case not process\n"));
+                        break;
+                }
+        }
+}
+void rtl92se_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        switch (variable) {
+        case HW_VAR_ETHER_ADDR:{
+                        rtl_write_dword(rtlpriv, IDR0, ((u32 *)(val))[0]);
+                        rtl_write_word(rtlpriv, IDR4, ((u16 *)(val + 4))[0]);
+                        break;
+                }
+        case HW_VAR_BASIC_RATE:{
+                        u16 rate_cfg = ((u16 *) val)[0];
+                        u8 rate_index = 0;
+                        if (rtlhal->version == VERSION_8192S_ACUT)
+                                rate_cfg = rate_cfg & 0x150;
+                        else
+                                rate_cfg = rate_cfg & 0x15f;
+                        rate_cfg |= 0x01;
+                        rtl_write_byte(rtlpriv, RRSR, rate_cfg & 0xff);
+                        rtl_write_byte(rtlpriv, RRSR + 1,
+                                       (rate_cfg >> 8) & 0xff);
+                        while (rate_cfg > 0x1) {
+                                rate_cfg = (rate_cfg >> 1);
+                                rate_index++;
+                        }
+                        rtl_write_byte(rtlpriv, INIRTSMCS_SEL, rate_index);
+                        break;
+                }
+        case HW_VAR_BSSID:{
+                        rtl_write_dword(rtlpriv, BSSIDR, ((u32 *)(val))[0]);
+                        rtl_write_word(rtlpriv, BSSIDR + 4,
+                                       ((u16 *)(val + 4))[0]);
+                        break;
+                }
+        case HW_VAR_SIFS:{
+                        rtl_write_byte(rtlpriv, SIFS_OFDM, val[0]);
+                        rtl_write_byte(rtlpriv, SIFS_OFDM + 1, val[1]);
+                        break;
+                }
+        case HW_VAR_SLOT_TIME:{
+                        u8 e_aci;
+                        RT_TRACE(rtlpriv, COMP_MLME, DBG_LOUD,
+                                 ("HW_VAR_SLOT_TIME %x\n", val[0]));
+                        rtl_write_byte(rtlpriv, SLOT_TIME, val[0]);
+                        for (e_aci = 0; e_aci < AC_MAX; e_aci++) {
+                                rtlpriv->cfg->ops->set_hw_reg(hw,
+                                                HW_VAR_AC_PARAM,
+                                                (u8 *)(&e_aci));
+                        }
+                        break;
+                }
+        case HW_VAR_ACK_PREAMBLE:{
+                        u8 reg_tmp;
+                        u8 short_preamble = (bool) (*(u8 *) val);
+                        reg_tmp = (mac->cur_40_prime_sc) << 5;
+                        if (short_preamble)
+                                reg_tmp |= 0x80;
+                        rtl_write_byte(rtlpriv, RRSR + 2, reg_tmp);
+                        break;
+                }
+        case HW_VAR_AMPDU_MIN_SPACE:{
+                        u8 min_spacing_to_set;
+                        u8 sec_min_space;
+                        min_spacing_to_set = *((u8 *)val);
+                        if (min_spacing_to_set <= 7) {
+                                if (rtlpriv->sec.pairwise_enc_algorithm ==
+                                    NO_ENCRYPTION)
+                                        sec_min_space = 0;
+                                else
+                                        sec_min_space = 1;
+                                if (min_spacing_to_set < sec_min_space)
+                                        min_spacing_to_set = sec_min_space;
+                                if (min_spacing_to_set > 5)
+                                        min_spacing_to_set = 5;
+                                mac->min_space_cfg =
+                                                ((mac->min_space_cfg & 0xf8) |
+                                                min_spacing_to_set);
+                                *val = min_spacing_to_set;
+                                RT_TRACE(rtlpriv, COMP_MLME, DBG_LOUD,
+                                         ("Set HW_VAR_AMPDU_MIN_SPACE: %#x\n",
+                                          mac->min_space_cfg));
+                                rtl_write_byte(rtlpriv, AMPDU_MIN_SPACE,
+                                               mac->min_space_cfg);
+                        }
+                        break;
+                }
+        case HW_VAR_SHORTGI_DENSITY:{
+                        u8 density_to_set;
+                        density_to_set = *((u8 *) val);
+                        mac->min_space_cfg = rtlpriv->rtlhal.minspace_cfg;
+                        mac->min_space_cfg |= (density_to_set << 3);
+                        RT_TRACE(rtlpriv, COMP_MLME, DBG_LOUD,
+                                 ("Set HW_VAR_SHORTGI_DENSITY: %#x\n",
+                                  mac->min_space_cfg));
+                        rtl_write_byte(rtlpriv, AMPDU_MIN_SPACE,
+                                       mac->min_space_cfg);
+                        break;
+                }
+        case HW_VAR_AMPDU_FACTOR:{
+                        u8 factor_toset;
+                        u8 regtoset;
+                        u8 factorlevel[18] = {
+                                2, 4, 4, 7, 7, 13, 13,
+                                13, 2, 7, 7, 13, 13,
+                                15, 15, 15, 15, 0};
+                        u8 index = 0;
+                        factor_toset = *((u8 *) val);
+                        if (factor_toset <= 3) {
+                                factor_toset = (1 << (factor_toset + 2));
+                                if (factor_toset > 0xf)
+                                        factor_toset = 0xf;
+                                for (index = 0; index < 17; index++) {
+                                        if (factorlevel[index] > factor_toset)
+                                                factorlevel[index] =
+                                                                 factor_toset;
+                                }
+                                for (index = 0; index < 8; index++) {
+                                        regtoset = ((factorlevel[index * 2]) |
+                                                    (factorlevel[index *
+                                                    2 + 1] << 4));
+                                        rtl_write_byte(rtlpriv,
+                                                       AGGLEN_LMT_L + index,
+                                                       regtoset);
+                                }
+                                regtoset = ((factorlevel[16]) |
+                                            (factorlevel[17] << 4));
+                                rtl_write_byte(rtlpriv, AGGLEN_LMT_H, regtoset);
+                                RT_TRACE(rtlpriv, COMP_MLME, DBG_LOUD,
+                                         ("Set HW_VAR_AMPDU_FACTOR: %#x\n",
+                                          factor_toset));
+                        }
+                        break;
+                }
+        case HW_VAR_AC_PARAM:{
+                        u8 e_aci = *((u8 *) val);
+                        rtl92s_dm_init_edca_turbo(hw);
+                        if (rtlpci->acm_method != eAcmWay2_SW)
+                                rtlpriv->cfg->ops->set_hw_reg(hw,
+                                                 HW_VAR_ACM_CTRL,
+                                                 (u8 *)(&e_aci));
+                        break;
+                }
+        case HW_VAR_ACM_CTRL:{
+                        u8 e_aci = *((u8 *) val);
+                        union aci_aifsn *p_aci_aifsn = (union aci_aifsn *)(&(
+                                                        mac->ac[0].aifs));
+                        u8 acm = p_aci_aifsn->f.acm;
+                        u8 acm_ctrl = rtl_read_byte(rtlpriv, AcmHwCtrl);
+                        acm_ctrl = acm_ctrl | ((rtlpci->acm_method == 2) ?
+                                   0x0 : 0x1);
+                        if (acm) {
+                                switch (e_aci) {
+                                case AC0_BE:
+                                        acm_ctrl |= AcmHw_BeqEn;
+                                        break;
+                                case AC2_VI:
+                                        acm_ctrl |= AcmHw_ViqEn;
+                                        break;
+                                case AC3_VO:
+                                        acm_ctrl |= AcmHw_VoqEn;
+                                        break;
+                                default:
+                                        RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
+                                                 ("HW_VAR_ACM_CTRL acm set "
+                                                  "failed: eACI is %d\n", acm));
+                                        break;
+                                }
+                        } else {
+                                switch (e_aci) {
+                                case AC0_BE:
+                                        acm_ctrl &= (~AcmHw_BeqEn);
+                                        break;
+                                case AC2_VI:
+                                        acm_ctrl &= (~AcmHw_ViqEn);
+                                        break;
+                                case AC3_VO:
+                                        acm_ctrl &= (~AcmHw_BeqEn);
+                                        break;
+                                default:
+                                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                                 ("switch case not process\n"));
+                                        break;
+                                }
+                        }
+                        RT_TRACE(rtlpriv, COMP_QOS, DBG_TRACE,
+                                 ("HW_VAR_ACM_CTRL Write 0x%X\n", acm_ctrl));
+                        rtl_write_byte(rtlpriv, AcmHwCtrl, acm_ctrl);
+                        break;
+                }
+        case HW_VAR_RCR:{
+                        rtl_write_dword(rtlpriv, RCR, ((u32 *) (val))[0]);
+                        rtlpci->receive_config = ((u32 *) (val))[0];
+                        break;
+                }
+        case HW_VAR_RETRY_LIMIT:{
+                        u8 retry_limit = ((u8 *) (val))[0];
+                        rtl_write_word(rtlpriv, RETRY_LIMIT,
+                                       retry_limit << RETRY_LIMIT_SHORT_SHIFT |
+                                       retry_limit << RETRY_LIMIT_LONG_SHIFT);
+                        break;
+                }
+        case HW_VAR_DUAL_TSF_RST: {
+                        break;
+                }
+        case HW_VAR_EFUSE_BYTES: {
+                        rtlefuse->efuse_usedbytes = *((u16 *) val);
+                        break;
+                }
+        case HW_VAR_EFUSE_USAGE: {
+                        rtlefuse->efuse_usedpercentage = *((u8 *) val);
+                        break;
+                }
+        case HW_VAR_IO_CMD: {
+                        break;
+                }
+        case HW_VAR_WPA_CONFIG: {
+                        rtl_write_byte(rtlpriv, REG_SECR, *((u8 *) val));
+                        break;
+                }
+        case HW_VAR_SET_RPWM:{
+                        break;
+                }
+        case HW_VAR_H2C_FW_PWRMODE:{
+                        break;
+                }
+        case HW_VAR_FW_PSMODE_STATUS: {
+                        ppsc->fw_current_inpsmode = *((bool *) val);
+                        break;
+                }
+        case HW_VAR_H2C_FW_JOINBSSRPT:{
+                        break;
+                }
+        case HW_VAR_AID:{
+                        break;
+                }
+        case HW_VAR_CORRECT_TSF:{
+                        break;
+                }
+        case HW_VAR_MRC: {
+                        bool bmrc_toset = *((bool *)val);
+                        u8 u1bdata = 0;
+                        if (bmrc_toset) {
+                                rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE,
+                                              MASKBYTE0, 0x33);
+                                u1bdata = (u8)rtl_get_bbreg(hw,
+                                                ROFDM1_TRXPATHENABLE,
+                                                MASKBYTE0);
+                                rtl_set_bbreg(hw, ROFDM1_TRXPATHENABLE,
+                                              MASKBYTE0,
+                                              ((u1bdata & 0xf0) | 0x03));
+                                u1bdata = (u8)rtl_get_bbreg(hw,
+                                                ROFDM0_TRXPATHENABLE,
+                                                MASKBYTE1);
+                                rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE,
+                                              MASKBYTE1,
+                                              (u1bdata | 0x04));
+                                /* Update current settings. */
+                                rtlpriv->dm.current_mrc_switch = bmrc_toset;
+                        } else {
+                                rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE,
+                                              MASKBYTE0, 0x13);
+                                u1bdata = (u8)rtl_get_bbreg(hw,
+                                                 ROFDM1_TRXPATHENABLE,
+                                                 MASKBYTE0);
+                                rtl_set_bbreg(hw, ROFDM1_TRXPATHENABLE,
+                                              MASKBYTE0,
+                                              ((u1bdata & 0xf0) | 0x01));
+                                u1bdata = (u8)rtl_get_bbreg(hw,
+                                                ROFDM0_TRXPATHENABLE,
+                                                MASKBYTE1);
+                                rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE,
+                                              MASKBYTE1, (u1bdata & 0xfb));
+                                /* Update current settings. */
+                                rtlpriv->dm.current_mrc_switch = bmrc_toset;
+                        }
+                        break;
+                }
+        default:
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("switch case not process\n"));
+                break;
+        }
+}
+void rtl92se_enable_hw_security_config(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u8 sec_reg_value = 0x0;
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, ("PairwiseEncAlgorithm = %d "
+                 "GroupEncAlgorithm = %d\n",
+                 rtlpriv->sec.pairwise_enc_algorithm,
+                 rtlpriv->sec.group_enc_algorithm));
+        if (rtlpriv->cfg->mod_params->sw_crypto || rtlpriv->sec.use_sw_sec) {
+                RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                         ("not open hw encryption\n"));
+                return;
+        }
+        sec_reg_value = SCR_TXENCENABLE | SCR_RXENCENABLE;
+        if (rtlpriv->sec.use_defaultkey) {
+                sec_reg_value |= SCR_TXUSEDK;
+                sec_reg_value |= SCR_RXUSEDK;
+        }
+        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD, ("The SECR-value %x\n",
+                        sec_reg_value));
+        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_WPA_CONFIG, &sec_reg_value);
+}
+static u8 _rtl92ce_halset_sysclk(struct ieee80211_hw *hw, u8 data)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u8 waitcount = 100;
+        bool bresult = false;
+        u8 tmpvalue;
+        rtl_write_byte(rtlpriv, SYS_CLKR + 1, data);
+        /* Wait the MAC synchronized. */
+        udelay(400);
+        /* Check if it is set ready. */
+        tmpvalue = rtl_read_byte(rtlpriv, SYS_CLKR + 1);
+        bresult = ((tmpvalue & BIT(7)) == (data & BIT(7)));
+        if ((data & (BIT(6) | BIT(7))) == false) {
+                waitcount = 100;
+                tmpvalue = 0;
+                while (1) {
+                        waitcount--;
+                        tmpvalue = rtl_read_byte(rtlpriv, SYS_CLKR + 1);
+                        if ((tmpvalue & BIT(6)))
+                                break;
+                        printk(KERN_ERR "wait for BIT(6) return value %x\n",
+                               tmpvalue);
+                        if (waitcount == 0)
+                                break;
+                        udelay(10);
+                }
+                if (waitcount == 0)
+                        bresult = false;
+                else
+                        bresult = true;
+        }
+        return bresult;
+}
+void rtl8192se_gpiobit3_cfg_inputmode(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u8 u1tmp;
+        /* The following config GPIO function */
+        rtl_write_byte(rtlpriv, MAC_PINMUX_CFG, (GPIOMUX_EN | GPIOSEL_GPIO));
+        u1tmp = rtl_read_byte(rtlpriv, GPIO_IO_SEL);
+        /* config GPIO3 to input */
+        u1tmp &= HAL_8192S_HW_GPIO_OFF_MASK;
+        rtl_write_byte(rtlpriv, GPIO_IO_SEL, u1tmp);
+}
+static u8 _rtl92se_rf_onoff_detect(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u8 u1tmp;
+        u8 retval = ERFON;
+        /* The following config GPIO function */
+        rtl_write_byte(rtlpriv, MAC_PINMUX_CFG, (GPIOMUX_EN | GPIOSEL_GPIO));
+        u1tmp = rtl_read_byte(rtlpriv, GPIO_IO_SEL);
+        /* config GPIO3 to input */
+        u1tmp &= HAL_8192S_HW_GPIO_OFF_MASK;
+        rtl_write_byte(rtlpriv, GPIO_IO_SEL, u1tmp);
+        /* On some of the platform, driver cannot read correct
+         * value without delay between Write_GPIO_SEL and Read_GPIO_IN */
+        mdelay(10);
+        /* check GPIO3 */
+        u1tmp = rtl_read_byte(rtlpriv, GPIO_IN);
+        retval = (u1tmp & HAL_8192S_HW_GPIO_OFF_BIT) ? ERFON : ERFOFF;
+        return retval;
+}
+static void _rtl92se_macconfig_before_fwdownload(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        u8 i;
+        u8 tmpu1b;
+        u16 tmpu2b;
+        u8 pollingcnt = 20;
+        if (rtlpci->first_init) {
+                /* Reset PCIE Digital */
+                tmpu1b = rtl_read_byte(rtlpriv, REG_SYS_FUNC_EN + 1);
+                tmpu1b &= 0xFE;
+                rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN + 1, tmpu1b);
+                udelay(1);
+                rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN + 1, tmpu1b | BIT(0));
+        }
+        /* Switch to SW IO control */
+        tmpu1b = rtl_read_byte(rtlpriv, (SYS_CLKR + 1));
+        if (tmpu1b & BIT(7)) {
+                tmpu1b &= ~(BIT(6) | BIT(7));
+                /* Set failed, return to prevent hang. */
+                if (!_rtl92ce_halset_sysclk(hw, tmpu1b))
+                        return;
+        }
+        rtl_write_byte(rtlpriv, AFE_PLL_CTRL, 0x0);
+        udelay(50);
+        rtl_write_byte(rtlpriv, LDOA15_CTRL, 0x34);
+        udelay(50);
+        /* Clear FW RPWM for FW control LPS.*/
+        rtl_write_byte(rtlpriv, RPWM, 0x0);
+        /* Reset MAC-IO and CPU and Core Digital BIT(10)/11/15 */
+        tmpu1b = rtl_read_byte(rtlpriv, REG_SYS_FUNC_EN + 1);
+        tmpu1b &= 0x73;
+        rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN + 1, tmpu1b);
+        /* wait for BIT 10/11/15 to pull high automatically!! */
+        mdelay(1);
+        rtl_write_byte(rtlpriv, CMDR, 0);
+        rtl_write_byte(rtlpriv, TCR, 0);
+        /* Data sheet not define 0x562!!! Copy from WMAC!!!!! */
+        tmpu1b = rtl_read_byte(rtlpriv, 0x562);
+        tmpu1b |= 0x08;
+        rtl_write_byte(rtlpriv, 0x562, tmpu1b);
+        tmpu1b &= ~(BIT(3));
+        rtl_write_byte(rtlpriv, 0x562, tmpu1b);
+        /* Enable AFE clock source */
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_XTAL_CTRL);
+        rtl_write_byte(rtlpriv, AFE_XTAL_CTRL, (tmpu1b | 0x01));
+        /* Delay 1.5ms */
+        mdelay(2);
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_XTAL_CTRL + 1);
+        rtl_write_byte(rtlpriv, AFE_XTAL_CTRL + 1, (tmpu1b & 0xfb));
+        /* Enable AFE Macro Block's Bandgap */
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_MISC);
+        rtl_write_byte(rtlpriv, AFE_MISC, (tmpu1b | BIT(0)));
+        mdelay(1);
+        /* Enable AFE Mbias */
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_MISC);
+        rtl_write_byte(rtlpriv, AFE_MISC, (tmpu1b | 0x02));
+        mdelay(1);
+        /* Enable LDOA15 block  */
+        tmpu1b = rtl_read_byte(rtlpriv, LDOA15_CTRL);
+        rtl_write_byte(rtlpriv, LDOA15_CTRL, (tmpu1b | BIT(0)));
+        /* Set Digital Vdd to Retention isolation Path. */
+        tmpu2b = rtl_read_word(rtlpriv, REG_SYS_ISO_CTRL);
+        rtl_write_word(rtlpriv, REG_SYS_ISO_CTRL, (tmpu2b | BIT(11)));
+        /* For warm reboot NIC disappera bug. */
+        tmpu2b = rtl_read_word(rtlpriv, REG_SYS_FUNC_EN);
+        rtl_write_word(rtlpriv, REG_SYS_FUNC_EN, (tmpu2b | BIT(13)));
+        rtl_write_byte(rtlpriv, REG_SYS_ISO_CTRL + 1, 0x68);
+        /* Enable AFE PLL Macro Block */
+        /* We need to delay 100u before enabling PLL. */
+        udelay(200);
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_PLL_CTRL);
+        rtl_write_byte(rtlpriv, AFE_PLL_CTRL, (tmpu1b | BIT(0) | BIT(4)));
+        /* for divider reset  */
+        udelay(100);
+        rtl_write_byte(rtlpriv, AFE_PLL_CTRL, (tmpu1b | BIT(0) |
+                       BIT(4) | BIT(6)));
+        udelay(10);
+        rtl_write_byte(rtlpriv, AFE_PLL_CTRL, (tmpu1b | BIT(0) | BIT(4)));
+        udelay(10);
+        /* Enable MAC 80MHZ clock  */
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_PLL_CTRL + 1);
+        rtl_write_byte(rtlpriv, AFE_PLL_CTRL + 1, (tmpu1b | BIT(0)));
+        mdelay(1);
+        /* Release isolation AFE PLL & MD */
+        rtl_write_byte(rtlpriv, REG_SYS_ISO_CTRL, 0xA6);
+        /* Enable MAC clock */
+        tmpu2b = rtl_read_word(rtlpriv, SYS_CLKR);
+        rtl_write_word(rtlpriv, SYS_CLKR, (tmpu2b | BIT(12) | BIT(11)));
+        /* Enable Core digital and enable IOREG R/W */
+        tmpu2b = rtl_read_word(rtlpriv, REG_SYS_FUNC_EN);
+        rtl_write_word(rtlpriv, REG_SYS_FUNC_EN, (tmpu2b | BIT(11)));
+        tmpu1b = rtl_read_byte(rtlpriv, REG_SYS_FUNC_EN + 1);
+        rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN + 1, tmpu1b & ~(BIT(7)));
+        /* enable REG_EN */
+        rtl_write_word(rtlpriv, REG_SYS_FUNC_EN, (tmpu2b | BIT(11) | BIT(15)));
+        /* Switch the control path. */
+        tmpu2b = rtl_read_word(rtlpriv, SYS_CLKR);
+        rtl_write_word(rtlpriv, SYS_CLKR, (tmpu2b & (~BIT(2))));
+        tmpu1b = rtl_read_byte(rtlpriv, (SYS_CLKR + 1));
+        tmpu1b = ((tmpu1b | BIT(7)) & (~BIT(6)));
+        if (!_rtl92ce_halset_sysclk(hw, tmpu1b))
+                return; /* Set failed, return to prevent hang. */
+        rtl_write_word(rtlpriv, CMDR, 0x07FC);
+        /* MH We must enable the section of code to prevent load IMEM fail. */
+        /* Load MAC register from WMAc temporarily We simulate macreg. */
+        /* txt HW will provide MAC txt later  */
+        rtl_write_byte(rtlpriv, 0x6, 0x30);
+        rtl_write_byte(rtlpriv, 0x49, 0xf0);
+        rtl_write_byte(rtlpriv, 0x4b, 0x81);
+        rtl_write_byte(rtlpriv, 0xb5, 0x21);
+        rtl_write_byte(rtlpriv, 0xdc, 0xff);
+        rtl_write_byte(rtlpriv, 0xdd, 0xff);
+        rtl_write_byte(rtlpriv, 0xde, 0xff);
+        rtl_write_byte(rtlpriv, 0xdf, 0xff);
+        rtl_write_byte(rtlpriv, 0x11a, 0x00);
+        rtl_write_byte(rtlpriv, 0x11b, 0x00);
+        for (i = 0; i < 32; i++)
+                rtl_write_byte(rtlpriv, INIMCS_SEL + i, 0x1b);
+        rtl_write_byte(rtlpriv, 0x236, 0xff);
+        rtl_write_byte(rtlpriv, 0x503, 0x22);
+        if (ppsc->support_aspm && !ppsc->support_backdoor)
+                rtl_write_byte(rtlpriv, 0x560, 0x40);
+        else
+                rtl_write_byte(rtlpriv, 0x560, 0x00);
+        rtl_write_byte(rtlpriv, DBG_PORT, 0x91);
+        /* Set RX Desc Address */
+        rtl_write_dword(rtlpriv, RDQDA, rtlpci->rx_ring[RX_MPDU_QUEUE].dma);
+        rtl_write_dword(rtlpriv, RCDA, rtlpci->rx_ring[RX_CMD_QUEUE].dma);
+        /* Set TX Desc Address */
+        rtl_write_dword(rtlpriv, TBKDA, rtlpci->tx_ring[BK_QUEUE].dma);
+        rtl_write_dword(rtlpriv, TBEDA, rtlpci->tx_ring[BE_QUEUE].dma);
+        rtl_write_dword(rtlpriv, TVIDA, rtlpci->tx_ring[VI_QUEUE].dma);
+        rtl_write_dword(rtlpriv, TVODA, rtlpci->tx_ring[VO_QUEUE].dma);
+        rtl_write_dword(rtlpriv, TBDA, rtlpci->tx_ring[BEACON_QUEUE].dma);
+        rtl_write_dword(rtlpriv, TCDA, rtlpci->tx_ring[TXCMD_QUEUE].dma);
+        rtl_write_dword(rtlpriv, TMDA, rtlpci->tx_ring[MGNT_QUEUE].dma);
+        rtl_write_dword(rtlpriv, THPDA, rtlpci->tx_ring[HIGH_QUEUE].dma);
+        rtl_write_dword(rtlpriv, HDA, rtlpci->tx_ring[HCCA_QUEUE].dma);
+        rtl_write_word(rtlpriv, CMDR, 0x37FC);
+        /* To make sure that TxDMA can ready to download FW. */
+        /* We should reset TxDMA if IMEM RPT was not ready. */
+        do {
+                tmpu1b = rtl_read_byte(rtlpriv, TCR);
+                if ((tmpu1b & TXDMA_INIT_VALUE) == TXDMA_INIT_VALUE)
+                        break;
+                udelay(5);
+        } while (pollingcnt--);
+        if (pollingcnt <= 0) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("Polling TXDMA_INIT_VALUE "
+                         "timeout!! Current TCR(%#x)\n", tmpu1b));
+                tmpu1b = rtl_read_byte(rtlpriv, CMDR);
+                rtl_write_byte(rtlpriv, CMDR, tmpu1b & (~TXDMA_EN));
+                udelay(2);
+                /* Reset TxDMA */
+                rtl_write_byte(rtlpriv, CMDR, tmpu1b | TXDMA_EN);
+        }
+        /* After MACIO reset,we must refresh LED state. */
+        if ((ppsc->rfoff_reason == RF_CHANGE_BY_IPS) ||
+           (ppsc->rfoff_reason == 0)) {
+                struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw);
+                struct rtl_led *pLed0 = &(pcipriv->ledctl.sw_led0);
+                enum rf_pwrstate rfpwr_state_toset;
+                rfpwr_state_toset = _rtl92se_rf_onoff_detect(hw);
+                if (rfpwr_state_toset == ERFON)
+                        rtl92se_sw_led_on(hw, pLed0);
+        }
+}
+static void _rtl92se_macconfig_after_fwdownload(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        u8 i;
+        u16 tmpu2b;
+        /* 1. System Configure Register (Offset: 0x0000 - 0x003F) */
+        /* 2. Command Control Register (Offset: 0x0040 - 0x004F) */
+        /* Turn on 0x40 Command register */
+        rtl_write_word(rtlpriv, CMDR, (BBRSTN | BB_GLB_RSTN |
+                        SCHEDULE_EN | MACRXEN | MACTXEN | DDMA_EN | FW2HW_EN |
+                        RXDMA_EN | TXDMA_EN | HCI_RXDMA_EN | HCI_TXDMA_EN));
+        /* Set TCR TX DMA pre 2 FULL enable bit */
+        rtl_write_dword(rtlpriv, TCR, rtl_read_dword(rtlpriv, TCR) |
+                        TXDMAPRE2FULL);
+        /* Set RCR      */
+        rtl_write_dword(rtlpriv, RCR, rtlpci->receive_config);
+        /* 3. MACID Setting Register (Offset: 0x0050 - 0x007F) */
+        /* 4. Timing Control Register  (Offset: 0x0080 - 0x009F) */
+        /* Set CCK/OFDM SIFS */
+        /* CCK SIFS shall always be 10us. */
+        rtl_write_word(rtlpriv, SIFS_CCK, 0x0a0a);
+        rtl_write_word(rtlpriv, SIFS_OFDM, 0x1010);
+        /* Set AckTimeout */
+        rtl_write_byte(rtlpriv, ACK_TIMEOUT, 0x40);
+        /* Beacon related */
+        rtl_write_word(rtlpriv, BCN_INTERVAL, 100);
+        rtl_write_word(rtlpriv, ATIMWND, 2);
+        /* 5. FIFO Control Register (Offset: 0x00A0 - 0x015F) */
+        /* 5.1 Initialize Number of Reserved Pages in Firmware Queue */
+        /* Firmware allocate now, associate with FW internal setting.!!! */
+        /* 5.2 Setting TX/RX page size 0/1/2/3/4=64/128/256/512/1024 */
+        /* 5.3 Set driver info, we only accept PHY status now. */
+        /* 5.4 Set RXDMA arbitration to control RXDMA/MAC/FW R/W for RXFIFO  */
+        rtl_write_byte(rtlpriv, RXDMA, rtl_read_byte(rtlpriv, RXDMA) | BIT(6));
+        /* 6. Adaptive Control Register  (Offset: 0x0160 - 0x01CF) */
+        /* Set RRSR to all legacy rate and HT rate
+         * CCK rate is supported by default.
+         * CCK rate will be filtered out only when associated
+         * AP does not support it.
+         * Only enable ACK rate to OFDM 24M
+         * Disable RRSR for CCK rate in A-Cut   */
+        if (rtlhal->version == VERSION_8192S_ACUT)
+                rtl_write_byte(rtlpriv, RRSR, 0xf0);
+        else if (rtlhal->version == VERSION_8192S_BCUT)
+                rtl_write_byte(rtlpriv, RRSR, 0xff);
+        rtl_write_byte(rtlpriv, RRSR + 1, 0x01);
+        rtl_write_byte(rtlpriv, RRSR + 2, 0x00);
+        /* A-Cut IC do not support CCK rate. We forbid ARFR to */
+        /* fallback to CCK rate */
+        for (i = 0; i < 8; i++) {
+                /*Disable RRSR for CCK rate in A-Cut */
+                if (rtlhal->version == VERSION_8192S_ACUT)
+                        rtl_write_dword(rtlpriv, ARFR0 + i * 4, 0x1f0ff0f0);
+        }
+        /* Different rate use different AMPDU size */
+        /* MCS32/ MCS15_SG use max AMPDU size 15*2=30K */
+        rtl_write_byte(rtlpriv, AGGLEN_LMT_H, 0x0f);
+        /* MCS0/1/2/3 use max AMPDU size 4*2=8K */
+        rtl_write_word(rtlpriv, AGGLEN_LMT_L, 0x7442);
+        /* MCS4/5 use max AMPDU size 8*2=16K 6/7 use 10*2=20K */
+        rtl_write_word(rtlpriv, AGGLEN_LMT_L + 2, 0xddd7);
+        /* MCS8/9 use max AMPDU size 8*2=16K 10/11 use 10*2=20K */
+        rtl_write_word(rtlpriv, AGGLEN_LMT_L + 4, 0xd772);
+        /* MCS12/13/14/15 use max AMPDU size 15*2=30K */
+        rtl_write_word(rtlpriv, AGGLEN_LMT_L + 6, 0xfffd);
+        /* Set Data / Response auto rate fallack retry count */
+        rtl_write_dword(rtlpriv, DARFRC, 0x04010000);
+        rtl_write_dword(rtlpriv, DARFRC + 4, 0x09070605);
+        rtl_write_dword(rtlpriv, RARFRC, 0x04010000);
+        rtl_write_dword(rtlpriv, RARFRC + 4, 0x09070605);
+        /* 7. EDCA Setting Register (Offset: 0x01D0 - 0x01FF) */
+        /* Set all rate to support SG */
+        rtl_write_word(rtlpriv, SG_RATE, 0xFFFF);
+        /* 8. WMAC, BA, and CCX related Register (Offset: 0x0200 - 0x023F) */
+        /* Set NAV protection length */
+        rtl_write_word(rtlpriv, NAV_PROT_LEN, 0x0080);
+        /* CF-END Threshold */
+        rtl_write_byte(rtlpriv, CFEND_TH, 0xFF);
+        /* Set AMPDU minimum space */
+        rtl_write_byte(rtlpriv, AMPDU_MIN_SPACE, 0x07);
+        /* Set TXOP stall control for several queue/HI/BCN/MGT/ */
+        rtl_write_byte(rtlpriv, TXOP_STALL_CTRL, 0x00);
+        /* 9. Security Control Register (Offset: 0x0240 - 0x025F) */
+        /* 10. Power Save Control Register (Offset: 0x0260 - 0x02DF) */
+        /* 11. General Purpose Register (Offset: 0x02E0 - 0x02FF) */
+        /* 12. Host Interrupt Status Register (Offset: 0x0300 - 0x030F) */
+        /* 13. Test Mode and Debug Control Register (Offset: 0x0310 - 0x034F) */
+        /* 14. Set driver info, we only accept PHY status now. */
+        rtl_write_byte(rtlpriv, RXDRVINFO_SZ, 4);
+        /* 15. For EEPROM R/W Workaround */
+        /* 16. For EFUSE to share REG_SYS_FUNC_EN with EEPROM!!! */
+        tmpu2b = rtl_read_byte(rtlpriv, REG_SYS_FUNC_EN);
+        rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN, tmpu2b | BIT(13));
+        tmpu2b = rtl_read_byte(rtlpriv, REG_SYS_ISO_CTRL);
+        rtl_write_byte(rtlpriv, REG_SYS_ISO_CTRL, tmpu2b & (~BIT(8)));
+        /* 17. For EFUSE */
+        /* We may R/W EFUSE in EEPROM mode */
+        if (rtlefuse->epromtype == EEPROM_BOOT_EFUSE) {
+                u8      tempval;
+                tempval = rtl_read_byte(rtlpriv, REG_SYS_ISO_CTRL + 1);
+                tempval &= 0xFE;
+                rtl_write_byte(rtlpriv, REG_SYS_ISO_CTRL + 1, tempval);
+                /* Change Program timing */
+                rtl_write_byte(rtlpriv, REG_EFUSE_CTRL + 3, 0x72);
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG, ("EFUSE CONFIG OK\n"));
+        }
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG, ("OK\n"));
+}
+static void _rtl92se_hw_configure(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        u8 reg_bw_opmode = 0;
+        u32 reg_ratr = 0, reg_rrsr = 0;
+        u8 regtmp = 0;
+        reg_bw_opmode = BW_OPMODE_20MHZ;
+        reg_ratr = RATE_ALL_CCK | RATE_ALL_OFDM_AG | RATE_ALL_OFDM_1SS |
+                                RATE_ALL_OFDM_2SS;
+        reg_rrsr = RATE_ALL_CCK | RATE_ALL_OFDM_AG;
+        regtmp = rtl_read_byte(rtlpriv, INIRTSMCS_SEL);
+        reg_rrsr = ((reg_rrsr & 0x000fffff) << 8) | regtmp;
+        rtl_write_dword(rtlpriv, INIRTSMCS_SEL, reg_rrsr);
+        rtl_write_byte(rtlpriv, BW_OPMODE, reg_bw_opmode);
+        /* Set Retry Limit here */
+        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_RETRY_LIMIT,
+                        (u8 *)(&rtlpci->shortretry_limit));
+        rtl_write_byte(rtlpriv, MLT, 0x8f);
+        /* For Min Spacing configuration. */
+        switch (rtlphy->rf_type) {
+        case RF_1T2R:
+        case RF_1T1R:
+                rtlhal->minspace_cfg = (MAX_MSS_DENSITY_1T << 3);
+                break;
+        case RF_2T2R:
+        case RF_2T2R_GREEN:
+                rtlhal->minspace_cfg = (MAX_MSS_DENSITY_2T << 3);
+                break;
+        }
+        rtl_write_byte(rtlpriv, AMPDU_MIN_SPACE, rtlhal->minspace_cfg);
+}
+int rtl92se_hw_init(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        u8 tmp_byte = 0;
+        bool rtstatus = true;
+        u8 tmp_u1b;
+        int err = false;
+        u8 i;
+        int wdcapra_add[] = {
+                EDCAPARA_BE, EDCAPARA_BK,
+                EDCAPARA_VI, EDCAPARA_VO};
+        u8 secr_value = 0x0;
+        rtlpci->being_init_adapter = true;
+        rtlpriv->intf_ops->disable_aspm(hw);
+        /* 1. MAC Initialize */
+        /* Before FW download, we have to set some MAC register */
+        _rtl92se_macconfig_before_fwdownload(hw);
+        rtlhal->version = (enum version_8192s)((rtl_read_dword(rtlpriv,
+                        PMC_FSM) >> 16) & 0xF);
+        rtl8192se_gpiobit3_cfg_inputmode(hw);
+        /* 2. download firmware */
+        rtstatus = rtl92s_download_fw(hw);
+        if (!rtstatus) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
+                         ("Failed to download FW. "
+                         "Init HW without FW now.., Please copy FW into"
+                         "/lib/firmware/rtlwifi\n"));
+                rtlhal->fw_ready = false;
+        } else {
+                rtlhal->fw_ready = true;
+        }
+        /* After FW download, we have to reset MAC register */
+        _rtl92se_macconfig_after_fwdownload(hw);
+        /*Retrieve default FW Cmd IO map. */
+        rtlhal->fwcmd_iomap =   rtl_read_word(rtlpriv, LBUS_MON_ADDR);
+        rtlhal->fwcmd_ioparam = rtl_read_dword(rtlpriv, LBUS_ADDR_MASK);
+        /* 3. Initialize MAC/PHY Config by MACPHY_reg.txt */
+        if (rtl92s_phy_mac_config(hw) != true) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, ("MAC Config failed\n"));
+                return rtstatus;
+        }
+        /* Make sure BB/RF write OK. We should prevent enter IPS. radio off. */
+        /* We must set flag avoid BB/RF config period later!! */
+        rtl_write_dword(rtlpriv, CMDR, 0x37FC);
+        /* 4. Initialize BB After MAC Config PHY_reg.txt, AGC_Tab.txt */
+        if (rtl92s_phy_bb_config(hw) != true) {
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG, ("BB Config failed\n"));
+                return rtstatus;
+        }
+        /* 5. Initiailze RF RAIO_A.txt RF RAIO_B.txt */
+        /* Before initalizing RF. We can not use FW to do RF-R/W. */
+        rtlphy->rf_mode = RF_OP_BY_SW_3WIRE;
+        /* RF Power Save */
+#if 0
+        /* H/W or S/W RF OFF before sleep. */
+        if (rtlpriv->psc.rfoff_reason > RF_CHANGE_BY_PS) {
+                u32 rfoffreason = rtlpriv->psc.rfoff_reason;
+                rtlpriv->psc.rfoff_reason = RF_CHANGE_BY_INIT;
+                rtlpriv->psc.rfpwr_state = ERFON;
+                rtl_ps_set_rf_state(hw, ERFOFF, rfoffreason, true);
+        } else {
+                /* gpio radio on/off is out of adapter start */
+                if (rtlpriv->psc.hwradiooff == false) {
+                        rtlpriv->psc.rfpwr_state = ERFON;
+                        rtlpriv->psc.rfoff_reason = 0;
+                }
+        }
+#endif
+        /* Before RF-R/W we must execute the IO from Scott's suggestion. */
+        rtl_write_byte(rtlpriv, AFE_XTAL_CTRL + 1, 0xDB);
+        if (rtlhal->version == VERSION_8192S_ACUT)
+                rtl_write_byte(rtlpriv, SPS1_CTRL + 3, 0x07);
+        else
+                rtl_write_byte(rtlpriv, RF_CTRL, 0x07);
+        if (rtl92s_phy_rf_config(hw) != true) {
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG, ("RF Config failed\n"));
+                return rtstatus;
+        }
+        /* After read predefined TXT, we must set BB/MAC/RF
+         * register as our requirement */
+        rtlphy->rfreg_chnlval[0] = rtl92s_phy_query_rf_reg(hw,
+                                                           (enum radio_path)0,
+                                                           RF_CHNLBW,
+                                                           RFREG_OFFSET_MASK);
+        rtlphy->rfreg_chnlval[1] = rtl92s_phy_query_rf_reg(hw,
+                                                           (enum radio_path)1,
+                                                           RF_CHNLBW,
+                                                           RFREG_OFFSET_MASK);
+        /*---- Set CCK and OFDM Block "ON"----*/
+        rtl_set_bbreg(hw, RFPGA0_RFMOD, BCCKEN, 0x1);
+        rtl_set_bbreg(hw, RFPGA0_RFMOD, BOFDMEN, 0x1);
+        /*3 Set Hardware(Do nothing now) */
+        _rtl92se_hw_configure(hw);
+        /* Read EEPROM TX power index and PHY_REG_PG.txt to capture correct */
+        /* TX power index for different rate set. */
+        /* Get original hw reg values */
+        rtl92s_phy_get_hw_reg_originalvalue(hw);
+        /* Write correct tx power index */
+        rtl92s_phy_set_txpower(hw, rtlphy->current_channel);
+        /* We must set MAC address after firmware download. */
+        for (i = 0; i < 6; i++)
+                rtl_write_byte(rtlpriv, MACIDR0 + i, rtlefuse->dev_addr[i]);
+        /* EEPROM R/W workaround */
+        tmp_u1b = rtl_read_byte(rtlpriv, MAC_PINMUX_CFG);
+        rtl_write_byte(rtlpriv, MAC_PINMUX_CFG, tmp_u1b & (~BIT(3)));
+        rtl_write_byte(rtlpriv, 0x4d, 0x0);
+        if (hal_get_firmwareversion(rtlpriv) >= 0x49) {
+                tmp_byte = rtl_read_byte(rtlpriv, FW_RSVD_PG_CRTL) & (~BIT(4));
+                tmp_byte = tmp_byte | BIT(5);
+                rtl_write_byte(rtlpriv, FW_RSVD_PG_CRTL, tmp_byte);
+                rtl_write_dword(rtlpriv, TXDESC_MSK, 0xFFFFCFFF);
+        }
+        /* We enable high power and RA related mechanism after NIC
+         * initialized. */
+        rtl92s_phy_set_fw_cmd(hw, FW_CMD_RA_INIT);
+        /* Add to prevent ASPM bug. */
+        /* Always enable hst and NIC clock request. */
+        rtl92s_phy_switch_ephy_parameter(hw);
+        /* Security related
+         * 1. Clear all H/W keys.
+         * 2. Enable H/W encryption/decryption. */
+        rtl_cam_reset_all_entry(hw);
+        secr_value |= SCR_TXENCENABLE;
+        secr_value |= SCR_RXENCENABLE;
+        secr_value |= SCR_NOSKMC;
+        rtl_write_byte(rtlpriv, REG_SECR, secr_value);
+        for (i = 0; i < 4; i++)
+                rtl_write_dword(rtlpriv, wdcapra_add[i], 0x5e4322);
+        if (rtlphy->rf_type == RF_1T2R) {
+                bool mrc2set = true;
+                /* Turn on B-Path */
+                rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_MRC, (u8 *)&mrc2set);
+        }
+        rtlpriv->cfg->ops->led_control(hw, LED_CTL_POWER_ON);
+        rtl92s_dm_init(hw);
+        rtlpci->being_init_adapter = false;
+        return err;
+}
+void rtl92se_set_mac_addr(struct rtl_io *io, const u8 * addr)
+{
+}
+void rtl92se_set_check_bssid(struct ieee80211_hw *hw, bool check_bssid)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        u32 reg_rcr = rtlpci->receive_config;
+        if (rtlpriv->psc.rfpwr_state != ERFON)
+                return;
+        if (check_bssid == true) {
+                reg_rcr |= (RCR_CBSSID);
+                rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_RCR, (u8 *)(&reg_rcr));
+        } else if (check_bssid == false) {
+                reg_rcr &= (~RCR_CBSSID);
+                rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_RCR, (u8 *)(&reg_rcr));
+        }
+}
+static int _rtl92se_set_media_status(struct ieee80211_hw *hw,
+                                     enum nl80211_iftype type)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u8 bt_msr = rtl_read_byte(rtlpriv, MSR);
+        enum led_ctl_mode ledaction = LED_CTL_NO_LINK;
+        u32 temp;
+        bt_msr &= ~MSR_LINK_MASK;
+        switch (type) {
+        case NL80211_IFTYPE_UNSPECIFIED:
+                bt_msr |= (MSR_LINK_NONE << MSR_LINK_SHIFT);
+                ledaction = LED_CTL_LINK;
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
+                         ("Set Network type to NO LINK!\n"));
+                break;
+        case NL80211_IFTYPE_ADHOC:
+                bt_msr |= (MSR_LINK_ADHOC << MSR_LINK_SHIFT);
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
+                         ("Set Network type to Ad Hoc!\n"));
+                break;
+        case NL80211_IFTYPE_STATION:
+                bt_msr |= (MSR_LINK_MANAGED << MSR_LINK_SHIFT);
+                ledaction = LED_CTL_LINK;
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
+                         ("Set Network type to STA!\n"));
+                break;
+        case NL80211_IFTYPE_AP:
+                bt_msr |= (MSR_LINK_MASTER << MSR_LINK_SHIFT);
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
+                         ("Set Network type to AP!\n"));
+                break;
+        default:
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("Network type %d not support!\n", type));
+                return 1;
+                break;
+        }
+        rtl_write_byte(rtlpriv, (MSR), bt_msr);
+        temp = rtl_read_dword(rtlpriv, TCR);
+        rtl_write_dword(rtlpriv, TCR, temp & (~BIT(8)));
+        rtl_write_dword(rtlpriv, TCR, temp | BIT(8));
+        return 0;
+}
+/* HW_VAR_MEDIA_STATUS & HW_VAR_CECHK_BSSID */
+int rtl92se_set_network_type(struct ieee80211_hw *hw, enum nl80211_iftype type)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        if (_rtl92se_set_media_status(hw, type))
+                return -EOPNOTSUPP;
+        if (rtlpriv->mac80211.link_state == MAC80211_LINKED) {
+                if (type != NL80211_IFTYPE_AP)
+                        rtl92se_set_check_bssid(hw, true);
+        } else {
+                rtl92se_set_check_bssid(hw, false);
+        }
+        return 0;
+}
+/* don't set REG_EDCA_BE_PARAM here because mac80211 will send pkt when scan */
+void rtl92se_set_qos(struct ieee80211_hw *hw, int aci)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        rtl92s_dm_init_edca_turbo(hw);
+        switch (aci) {
+        case AC1_BK:
+                rtl_write_dword(rtlpriv, EDCAPARA_BK, 0xa44f);
+                break;
+        case AC0_BE:
+                /* rtl_write_dword(rtlpriv, EDCAPARA_BE, u4b_ac_param); */
+                break;
+        case AC2_VI:
+                rtl_write_dword(rtlpriv, EDCAPARA_VI, 0x5e4322);
+                break;
+        case AC3_VO:
+                rtl_write_dword(rtlpriv, EDCAPARA_VO, 0x2f3222);
+                break;
+        default:
+                RT_ASSERT(false, ("invalid aci: %d !\n", aci));
+                break;
+        }
+}
+void rtl92se_enable_interrupt(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        rtl_write_dword(rtlpriv, INTA_MASK, rtlpci->irq_mask[0]);
+        /* Support Bit 32-37(Assign as Bit 0-5) interrupt setting now */
+        rtl_write_dword(rtlpriv, INTA_MASK + 4, rtlpci->irq_mask[1] & 0x3F);
+        rtlpci->irq_enabled = true;
+}
+void rtl92se_disable_interrupt(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        rtl_write_dword(rtlpriv, INTA_MASK, 0);
+        rtl_write_dword(rtlpriv, INTA_MASK + 4, 0);
+        rtlpci->irq_enabled = false;
+}
+static u8 _rtl92s_set_sysclk(struct ieee80211_hw *hw, u8 data)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u8 waitcnt = 100;
+        bool result = false;
+        u8 tmp;
+        rtl_write_byte(rtlpriv, SYS_CLKR + 1, data);
+        /* Wait the MAC synchronized. */
+        udelay(400);
+        /* Check if it is set ready. */
+        tmp = rtl_read_byte(rtlpriv, SYS_CLKR + 1);
+        result = ((tmp & BIT(7)) == (data & BIT(7)));
+        if ((data & (BIT(6) | BIT(7))) == false) {
+                waitcnt = 100;
+                tmp = 0;
+                while (1) {
+                        waitcnt--;
+                        tmp = rtl_read_byte(rtlpriv, SYS_CLKR + 1);
+                        if ((tmp & BIT(6)))
+                                break;
+                        printk(KERN_ERR "wait for BIT(6) return value %x\n",
+                               tmp);
+                        if (waitcnt == 0)
+                                break;
+                        udelay(10);
+                }
+                if (waitcnt == 0)
+                        result = false;
+                else
+                        result = true;
+        }
+        return result;
+}
+static void _rtl92s_phy_set_rfhalt(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        u8 u1btmp;
+        if (rtlhal->driver_going2unload)
+                rtl_write_byte(rtlpriv, 0x560, 0x0);
+        /* Power save for BB/RF */
+        u1btmp = rtl_read_byte(rtlpriv, LDOV12D_CTRL);
+        u1btmp |= BIT(0);
+        rtl_write_byte(rtlpriv, LDOV12D_CTRL, u1btmp);
+        rtl_write_byte(rtlpriv, SPS1_CTRL, 0x0);
+        rtl_write_byte(rtlpriv, TXPAUSE, 0xFF);
+        rtl_write_word(rtlpriv, CMDR, 0x57FC);
+        udelay(100);
+        rtl_write_word(rtlpriv, CMDR, 0x77FC);
+        rtl_write_byte(rtlpriv, PHY_CCA, 0x0);
+        udelay(10);
+        rtl_write_word(rtlpriv, CMDR, 0x37FC);
+        udelay(10);
+        rtl_write_word(rtlpriv, CMDR, 0x77FC);
+        udelay(10);
+        rtl_write_word(rtlpriv, CMDR, 0x57FC);
+        rtl_write_word(rtlpriv, CMDR, 0x0000);
+        if (rtlhal->driver_going2unload) {
+                u1btmp = rtl_read_byte(rtlpriv, (REG_SYS_FUNC_EN + 1));
+                u1btmp &= ~(BIT(0));
+                rtl_write_byte(rtlpriv, REG_SYS_FUNC_EN + 1, u1btmp);
+        }
+        u1btmp = rtl_read_byte(rtlpriv, (SYS_CLKR + 1));
+        /* Add description. After switch control path. register
+         * after page1 will be invisible. We can not do any IO
+         * for register>0x40. After resume&MACIO reset, we need
+         * to remember previous reg content. */
+        if (u1btmp & BIT(7)) {
+                u1btmp &= ~(BIT(6) | BIT(7));
+                if (!_rtl92s_set_sysclk(hw, u1btmp)) {
+                        printk(KERN_ERR "Switch ctrl path fail\n");
+                        return;
+                }
+        }
+        /* Power save for MAC */
+        if (ppsc->rfoff_reason == RF_CHANGE_BY_IPS  &&
+                !rtlhal->driver_going2unload) {
+                /* enable LED function */
+                rtl_write_byte(rtlpriv, 0x03, 0xF9);
+        /* SW/HW radio off or halt adapter!! For example S3/S4 */
+        } else {
+                /* LED function disable. Power range is about 8mA now. */
+                /* if write 0xF1 disconnet_pci power
+                 *       ifconfig wlan0 down power are both high 35:70 */
+                /* if write oxF9 disconnet_pci power
+                 * ifconfig wlan0 down power are both low  12:45*/
+                rtl_write_byte(rtlpriv, 0x03, 0xF9);
+        }
+        rtl_write_byte(rtlpriv, SYS_CLKR + 1, 0x70);
+        rtl_write_byte(rtlpriv, AFE_PLL_CTRL + 1, 0x68);
+        rtl_write_byte(rtlpriv,  AFE_PLL_CTRL, 0x00);
+        rtl_write_byte(rtlpriv, LDOA15_CTRL, 0x34);
+        rtl_write_byte(rtlpriv, AFE_XTAL_CTRL, 0x0E);
+        RT_SET_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_HALT_NIC);
+}
+static void _rtl92se_gen_refreshledstate(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw);
+        struct rtl_led *pLed0 = &(pcipriv->ledctl.sw_led0);
+        if (rtlpci->up_first_time == 1)
+                return;
+        if (rtlpriv->psc.rfoff_reason == RF_CHANGE_BY_IPS)
+                rtl92se_sw_led_on(hw, pLed0);
+        else
+                rtl92se_sw_led_off(hw, pLed0);
+}
+static void _rtl92se_power_domain_init(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u16 tmpu2b;
+        u8 tmpu1b;
+        rtlpriv->psc.pwrdomain_protect = true;
+        tmpu1b = rtl_read_byte(rtlpriv, (SYS_CLKR + 1));
+        if (tmpu1b & BIT(7)) {
+                tmpu1b &= ~(BIT(6) | BIT(7));
+                if (!_rtl92s_set_sysclk(hw, tmpu1b)) {
+                        rtlpriv->psc.pwrdomain_protect = false;
+                        return;
+                }
+        }
+        rtl_write_byte(rtlpriv, AFE_PLL_CTRL, 0x0);
+        rtl_write_byte(rtlpriv, LDOA15_CTRL, 0x34);
+        /* Reset MAC-IO and CPU and Core Digital BIT10/11/15 */
+        tmpu1b = rtl_read_byte(rtlpriv, SYS_FUNC_EN + 1);
+        /* If IPS we need to turn LED on. So we not
+         * not disable BIT 3/7 of reg3. */
+        if (rtlpriv->psc.rfoff_reason & (RF_CHANGE_BY_IPS | RF_CHANGE_BY_HW))
+                tmpu1b &= 0xFB;
+        else
+                tmpu1b &= 0x73;
+        rtl_write_byte(rtlpriv, SYS_FUNC_EN + 1, tmpu1b);
+        /* wait for BIT 10/11/15 to pull high automatically!! */
+        mdelay(1);
+        rtl_write_byte(rtlpriv, CMDR, 0);
+        rtl_write_byte(rtlpriv, TCR, 0);
+        /* Data sheet not define 0x562!!! Copy from WMAC!!!!! */
+        tmpu1b = rtl_read_byte(rtlpriv, 0x562);
+        tmpu1b |= 0x08;
+        rtl_write_byte(rtlpriv, 0x562, tmpu1b);
+        tmpu1b &= ~(BIT(3));
+        rtl_write_byte(rtlpriv, 0x562, tmpu1b);
+        /* Enable AFE clock source */
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_XTAL_CTRL);
+        rtl_write_byte(rtlpriv, AFE_XTAL_CTRL, (tmpu1b | 0x01));
+        /* Delay 1.5ms */
+        udelay(1500);
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_XTAL_CTRL + 1);
+        rtl_write_byte(rtlpriv, AFE_XTAL_CTRL + 1, (tmpu1b & 0xfb));
+        /* Enable AFE Macro Block's Bandgap */
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_MISC);
+        rtl_write_byte(rtlpriv, AFE_MISC, (tmpu1b | BIT(0)));
+        mdelay(1);
+        /* Enable AFE Mbias */
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_MISC);
+        rtl_write_byte(rtlpriv, AFE_MISC, (tmpu1b | 0x02));
+        mdelay(1);
+        /* Enable LDOA15 block */
+        tmpu1b = rtl_read_byte(rtlpriv, LDOA15_CTRL);
+        rtl_write_byte(rtlpriv, LDOA15_CTRL, (tmpu1b | BIT(0)));
+        /* Set Digital Vdd to Retention isolation Path. */
+        tmpu2b = rtl_read_word(rtlpriv, SYS_ISO_CTRL);
+        rtl_write_word(rtlpriv, SYS_ISO_CTRL, (tmpu2b | BIT(11)));
+        /* For warm reboot NIC disappera bug. */
+        tmpu2b = rtl_read_word(rtlpriv, SYS_FUNC_EN);
+        rtl_write_word(rtlpriv, SYS_FUNC_EN, (tmpu2b | BIT(13)));
+        rtl_write_byte(rtlpriv, SYS_ISO_CTRL + 1, 0x68);
+        /* Enable AFE PLL Macro Block */
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_PLL_CTRL);
+        rtl_write_byte(rtlpriv, AFE_PLL_CTRL, (tmpu1b | BIT(0) | BIT(4)));
+        /* Enable MAC 80MHZ clock */
+        tmpu1b = rtl_read_byte(rtlpriv, AFE_PLL_CTRL + 1);
+        rtl_write_byte(rtlpriv, AFE_PLL_CTRL + 1, (tmpu1b | BIT(0)));
+        mdelay(1);
+        /* Release isolation AFE PLL & MD */
+        rtl_write_byte(rtlpriv, SYS_ISO_CTRL, 0xA6);
+        /* Enable MAC clock */
+        tmpu2b = rtl_read_word(rtlpriv, SYS_CLKR);
+        rtl_write_word(rtlpriv, SYS_CLKR, (tmpu2b | BIT(12) | BIT(11)));
+        /* Enable Core digital and enable IOREG R/W */
+        tmpu2b = rtl_read_word(rtlpriv, SYS_FUNC_EN);
+        rtl_write_word(rtlpriv, SYS_FUNC_EN, (tmpu2b | BIT(11)));
+        /* enable REG_EN */
+        rtl_write_word(rtlpriv, SYS_FUNC_EN, (tmpu2b | BIT(11) | BIT(15)));
+        /* Switch the control path. */
+        tmpu2b = rtl_read_word(rtlpriv, SYS_CLKR);
+        rtl_write_word(rtlpriv, SYS_CLKR, (tmpu2b & (~BIT(2))));
+        tmpu1b = rtl_read_byte(rtlpriv, (SYS_CLKR + 1));
+        tmpu1b = ((tmpu1b | BIT(7)) & (~BIT(6)));
+        if (!_rtl92s_set_sysclk(hw, tmpu1b)) {
+                rtlpriv->psc.pwrdomain_protect = false;
+                return;
+        }
+        rtl_write_word(rtlpriv, CMDR, 0x37FC);
+        /* After MACIO reset,we must refresh LED state. */
+        _rtl92se_gen_refreshledstate(hw);
+        rtlpriv->psc.pwrdomain_protect = false;
+}
+void rtl92se_card_disable(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        enum nl80211_iftype opmode;
+        u8 wait = 30;
+        rtlpriv->intf_ops->enable_aspm(hw);
+        if (rtlpci->driver_is_goingto_unload ||
+                ppsc->rfoff_reason > RF_CHANGE_BY_PS)
+                rtlpriv->cfg->ops->led_control(hw, LED_CTL_POWER_OFF);
+        /* we should chnge GPIO to input mode
+         * this will drop away current about 25mA*/
+        rtl8192se_gpiobit3_cfg_inputmode(hw);
+        /* this is very important for ips power save */
+        while (wait-- >= 10 && rtlpriv->psc.pwrdomain_protect) {
+                if (rtlpriv->psc.pwrdomain_protect)
+                        mdelay(20);
+                else
+                        break;
+        }
+        mac->link_state = MAC80211_NOLINK;
+        opmode = NL80211_IFTYPE_UNSPECIFIED;
+        _rtl92se_set_media_status(hw, opmode);
+        _rtl92s_phy_set_rfhalt(hw);
+        udelay(100);
+}
+void rtl92se_interrupt_recognized(struct ieee80211_hw *hw, u32 *p_inta,
+                             u32 *p_intb)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        *p_inta = rtl_read_dword(rtlpriv, ISR) & rtlpci->irq_mask[0];
+        rtl_write_dword(rtlpriv, ISR, *p_inta);
+        *p_intb = rtl_read_dword(rtlpriv, ISR + 4) & rtlpci->irq_mask[1];
+        rtl_write_dword(rtlpriv, ISR + 4, *p_intb);
+}
+void rtl92se_set_beacon_related_registers(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        u16 bcntime_cfg = 0;
+        u16 bcn_cw = 6, bcn_ifs = 0xf;
+        u16 atim_window = 2;
+        /* ATIM Window (in unit of TU). */
+        rtl_write_word(rtlpriv, ATIMWND, atim_window);
+        /* Beacon interval (in unit of TU). */
+        rtl_write_word(rtlpriv, BCN_INTERVAL, mac->beacon_interval);
+        /* DrvErlyInt (in unit of TU). (Time to send
+         * interrupt to notify driver to change
+         * beacon content) */
+        rtl_write_word(rtlpriv, BCN_DRV_EARLY_INT, 10 << 4);
+        /* BcnDMATIM(in unit of us). Indicates the
+         * time before TBTT to perform beacon queue DMA  */
+        rtl_write_word(rtlpriv, BCN_DMATIME, 256);
+        /* Force beacon frame transmission even
+         * after receiving beacon frame from
+         * other ad hoc STA */
+        rtl_write_byte(rtlpriv, BCN_ERR_THRESH, 100);
+        /* Beacon Time Configuration */
+        if (mac->opmode == NL80211_IFTYPE_ADHOC)
+                bcntime_cfg |= (bcn_cw << BCN_TCFG_CW_SHIFT);
+        /* TODO: bcn_ifs may required to be changed on ASIC */
+        bcntime_cfg |= bcn_ifs << BCN_TCFG_IFS;
+        /*for beacon changed */
+        rtl92s_phy_set_beacon_hwreg(hw, mac->beacon_interval);
+}
+void rtl92se_set_beacon_interval(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        u16 bcn_interval = mac->beacon_interval;
+        /* Beacon interval (in unit of TU). */
+        rtl_write_word(rtlpriv, BCN_INTERVAL, bcn_interval);
+        /* 2008.10.24 added by tynli for beacon changed. */
+        rtl92s_phy_set_beacon_hwreg(hw, bcn_interval);
+}
+void rtl92se_update_interrupt_mask(struct ieee80211_hw *hw,
+                u32 add_msr, u32 rm_msr)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        RT_TRACE(rtlpriv, COMP_INTR, DBG_LOUD,
+                 ("add_msr:%x, rm_msr:%x\n", add_msr, rm_msr));
+        if (add_msr)
+                rtlpci->irq_mask[0] |= add_msr;
+        if (rm_msr)
+                rtlpci->irq_mask[0] &= (~rm_msr);
+        rtl92se_disable_interrupt(hw);
+        rtl92se_enable_interrupt(hw);
+}
+static void _rtl8192se_get_IC_Inferiority(struct ieee80211_hw *hw)
+{
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        u8 efuse_id;
+        rtlhal->ic_class = IC_INFERIORITY_A;
+        /* Only retrieving while using EFUSE. */
+        if ((rtlefuse->epromtype == EEPROM_BOOT_EFUSE) &&
+                !rtlefuse->autoload_failflag) {
+                efuse_id = efuse_read_1byte(hw, EFUSE_IC_ID_OFFSET);
+                if (efuse_id == 0xfe)
+                        rtlhal->ic_class = IC_INFERIORITY_B;
+        }
+}
+static void _rtl92se_read_adapter_info(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        u16 i, usvalue;
+        u16     eeprom_id;
+        u8 tempval;
+        u8 hwinfo[HWSET_MAX_SIZE_92S];
+        u8 rf_path, index;
+        if (rtlefuse->epromtype == EEPROM_93C46) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("RTL819X Not boot from eeprom, check it !!"));
+        } else if (rtlefuse->epromtype == EEPROM_BOOT_EFUSE) {
+                rtl_efuse_shadow_map_update(hw);
+                memcpy((void *)hwinfo, (void *)
+                        &rtlefuse->efuse_map[EFUSE_INIT_MAP][0],
+                        HWSET_MAX_SIZE_92S);
+        }
+        RT_PRINT_DATA(rtlpriv, COMP_INIT, DBG_DMESG, ("MAP\n"),
+                      hwinfo, HWSET_MAX_SIZE_92S);
+        eeprom_id = *((u16 *)&hwinfo[0]);
+        if (eeprom_id != RTL8190_EEPROM_ID) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
+                         ("EEPROM ID(%#x) is invalid!!\n", eeprom_id));
+                rtlefuse->autoload_failflag = true;
+        } else {
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, ("Autoload OK\n"));
+                rtlefuse->autoload_failflag = false;
+        }
+        if (rtlefuse->autoload_failflag == true)
+                return;
+        _rtl8192se_get_IC_Inferiority(hw);
+        /* Read IC Version && Channel Plan */
+        /* VID, DID      SE     0xA-D */
+        rtlefuse->eeprom_vid = *(u16 *)&hwinfo[EEPROM_VID];
+        rtlefuse->eeprom_did = *(u16 *)&hwinfo[EEPROM_DID];
+        rtlefuse->eeprom_svid = *(u16 *)&hwinfo[EEPROM_SVID];
+        rtlefuse->eeprom_smid = *(u16 *)&hwinfo[EEPROM_SMID];
+        rtlefuse->eeprom_version = *(u16 *)&hwinfo[EEPROM_VERSION];
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                        ("EEPROMId = 0x%4x\n", eeprom_id));
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                        ("EEPROM VID = 0x%4x\n", rtlefuse->eeprom_vid));
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                        ("EEPROM DID = 0x%4x\n", rtlefuse->eeprom_did));
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                        ("EEPROM SVID = 0x%4x\n", rtlefuse->eeprom_svid));
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                        ("EEPROM SMID = 0x%4x\n", rtlefuse->eeprom_smid));
+        for (i = 0; i < 6; i += 2) {
+                usvalue = *(u16 *)&hwinfo[EEPROM_MAC_ADDR + i];
+                *((u16 *) (&rtlefuse->dev_addr[i])) = usvalue;
+        }
+        for (i = 0; i < 6; i++)
+                rtl_write_byte(rtlpriv, MACIDR0 + i, rtlefuse->dev_addr[i]);
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
+                 (MAC_FMT "\n", MAC_ARG(rtlefuse->dev_addr)));
+        /* Get Tx Power Level by Channel */
+        /* Read Tx power of Channel 1 ~ 14 from EEPROM. */
+        /* 92S suupport RF A & B */
+        for (rf_path = 0; rf_path < 2; rf_path++) {
+                for (i = 0; i < 3; i++) {
+                        /* Read CCK RF A & B Tx power  */
+                        rtlefuse->eeprom_chnlarea_txpwr_cck[rf_path][i] =
+                        hwinfo[EEPROM_TXPOWERBASE + rf_path * 3 + i];
+                        /* Read OFDM RF A & B Tx power for 1T */
+                        rtlefuse->eeprom_chnlarea_txpwr_ht40_1s[rf_path][i] =
+                        hwinfo[EEPROM_TXPOWERBASE + 6 + rf_path * 3 + i];
+                        /* Read OFDM RF A & B Tx power for 2T */
+                        rtlefuse->eeprom_chnlarea_txpwr_ht40_2sdiif[rf_path][i]
+                                 = hwinfo[EEPROM_TXPOWERBASE + 12 +
+                                   rf_path * 3 + i];
+                }
+        }
+        for (rf_path = 0; rf_path < 2; rf_path++)
+                for (i = 0; i < 3; i++)
+                        RTPRINT(rtlpriv, FINIT, INIT_EEPROM,
+                                ("RF(%d) EEPROM CCK Area(%d) = 0x%x\n", rf_path,
+                                i, rtlefuse->eeprom_chnlarea_txpwr_cck
+                                        [rf_path][i]));
+        for (rf_path = 0; rf_path < 2; rf_path++)
+                for (i = 0; i < 3; i++)
+                        RTPRINT(rtlpriv, FINIT, INIT_EEPROM,
+                                ("RF(%d) EEPROM HT40 1S Area(%d) = 0x%x\n",
+                                 rf_path, i,
+                                 rtlefuse->eeprom_chnlarea_txpwr_ht40_1s
+                                                [rf_path][i]));
+        for (rf_path = 0; rf_path < 2; rf_path++)
+                for (i = 0; i < 3; i++)
+                        RTPRINT(rtlpriv, FINIT, INIT_EEPROM,
+                                ("RF(%d) EEPROM HT40 2S Diff Area(%d) = 0x%x\n",
+                                 rf_path, i,
+                                 rtlefuse->eeprom_chnlarea_txpwr_ht40_2sdiif
+                                        [rf_path][i]));
+        for (rf_path = 0; rf_path < 2; rf_path++) {
+                /* Assign dedicated channel tx power */
+                for (i = 0; i < 14; i++)        {
+                        /* channel 1~3 use the same Tx Power Level. */
+                        if (i < 3)
+                                index = 0;
+                        /* Channel 4-8 */
+                        else if (i < 8)
+                                index = 1;
+                        /* Channel 9-14 */
+                        else
+                                index = 2;
+                        /* Record A & B CCK /OFDM - 1T/2T Channel area
+                         * tx power */
+                        rtlefuse->txpwrlevel_cck[rf_path][i]  =
+                                rtlefuse->eeprom_chnlarea_txpwr_cck
+                                                        [rf_path][index];
+                        rtlefuse->txpwrlevel_ht40_1s[rf_path][i]  =
+                                rtlefuse->eeprom_chnlarea_txpwr_ht40_1s
+                                                        [rf_path][index];
+                        rtlefuse->txpwrlevel_ht40_2s[rf_path][i]  =
+                                rtlefuse->eeprom_chnlarea_txpwr_ht40_2sdiif
+                                                        [rf_path][index];
+                }
+                for (i = 0; i < 14; i++) {
+                        RTPRINT(rtlpriv, FINIT, INIT_TxPower,
+                                ("RF(%d)-Ch(%d) [CCK / HT40_1S / HT40_2S] = "
+                                 "[0x%x / 0x%x / 0x%x]\n", rf_path, i,
+                                 rtlefuse->txpwrlevel_cck[rf_path][i],
+                                 rtlefuse->txpwrlevel_ht40_1s[rf_path][i],
+                                 rtlefuse->txpwrlevel_ht40_2s[rf_path][i]));
+                }
+        }
+        for (rf_path = 0; rf_path < 2; rf_path++) {
+                for (i = 0; i < 3; i++) {
+                        /* Read Power diff limit. */
+                        rtlefuse->eeprom_pwrgroup[rf_path][i] =
+                                hwinfo[EEPROM_TXPWRGROUP + rf_path * 3 + i];
+                }
+        }
+        for (rf_path = 0; rf_path < 2; rf_path++) {
+                /* Fill Pwr group */
+                for (i = 0; i < 14; i++) {
+                        /* Chanel 1-3 */
+                        if (i < 3)
+                                index = 0;
+                        /* Channel 4-8 */
+                        else if (i < 8)
+                                index = 1;
+                        /* Channel 9-13 */
+                        else
+                                index = 2;
+                        rtlefuse->pwrgroup_ht20[rf_path][i] =
+                                (rtlefuse->eeprom_pwrgroup[rf_path][index] &
+                                0xf);
+                        rtlefuse->pwrgroup_ht40[rf_path][i] =
+                                ((rtlefuse->eeprom_pwrgroup[rf_path][index] &
+                                0xf0) >> 4);
+                        RTPRINT(rtlpriv, FINIT, INIT_TxPower,
+                                ("RF-%d pwrgroup_ht20[%d] = 0x%x\n",
+                                 rf_path, i,
+                                 rtlefuse->pwrgroup_ht20[rf_path][i]));
+                        RTPRINT(rtlpriv, FINIT, INIT_TxPower,
+                                ("RF-%d pwrgroup_ht40[%d] = 0x%x\n",
+                                 rf_path, i,
+                                 rtlefuse->pwrgroup_ht40[rf_path][i]));
+                        }
+        }
+        for (i = 0; i < 14; i++) {
+                /* Read tx power difference between HT OFDM 20/40 MHZ */
+                /* channel 1-3 */
+                if (i < 3)
+                        index = 0;
+                /* Channel 4-8 */
+                else if (i < 8)
+                        index = 1;
+                /* Channel 9-14 */
+                else
+                        index = 2;
+                tempval = (*(u8 *)&hwinfo[EEPROM_TX_PWR_HT20_DIFF +
+                           index]) & 0xff;
+                rtlefuse->txpwr_ht20diff[RF90_PATH_A][i] = (tempval & 0xF);
+                rtlefuse->txpwr_ht20diff[RF90_PATH_B][i] =
+                                                 ((tempval >> 4) & 0xF);
+                /* Read OFDM<->HT tx power diff */
+                /* Channel 1-3 */
+                if (i < 3)
+                        index = 0;
+                /* Channel 4-8 */
+                else if (i < 8)
+                        index = 0x11;
+                /* Channel 9-14 */
+                else
+                        index = 1;
+                tempval = (*(u8 *)&hwinfo[EEPROM_TX_PWR_OFDM_DIFF + index])
+                                  & 0xff;
+                rtlefuse->txpwr_legacyhtdiff[RF90_PATH_A][i] =
+                                 (tempval & 0xF);
+                rtlefuse->txpwr_legacyhtdiff[RF90_PATH_B][i] =
+                                 ((tempval >> 4) & 0xF);
+                tempval = (*(u8 *)&hwinfo[TX_PWR_SAFETY_CHK]);
+                rtlefuse->txpwr_safetyflag = (tempval & 0x01);
+        }
+        rtlefuse->eeprom_regulatory = 0;
+        if (rtlefuse->eeprom_version >= 2) {
+                /* BIT(0)~2 */
+                if (rtlefuse->eeprom_version >= 4)
+                        rtlefuse->eeprom_regulatory =
+                                 (hwinfo[EEPROM_REGULATORY] & 0x7);
+                else /* BIT(0) */
+                        rtlefuse->eeprom_regulatory =
+                                 (hwinfo[EEPROM_REGULATORY] & 0x1);
+        }
+        RTPRINT(rtlpriv, FINIT, INIT_TxPower,
+                ("eeprom_regulatory = 0x%x\n", rtlefuse->eeprom_regulatory));
+        for (i = 0; i < 14; i++)
+                RTPRINT(rtlpriv, FINIT, INIT_TxPower,
+                        ("RF-A Ht20 to HT40 Diff[%d] = 0x%x\n", i,
+                         rtlefuse->txpwr_ht20diff[RF90_PATH_A][i]));
+        for (i = 0; i < 14; i++)
+                RTPRINT(rtlpriv, FINIT, INIT_TxPower,
+                        ("RF-A Legacy to Ht40 Diff[%d] = 0x%x\n", i,
+                         rtlefuse->txpwr_legacyhtdiff[RF90_PATH_A][i]));
+        for (i = 0; i < 14; i++)
+                RTPRINT(rtlpriv, FINIT, INIT_TxPower,
+                        ("RF-B Ht20 to HT40 Diff[%d] = 0x%x\n", i,
+                         rtlefuse->txpwr_ht20diff[RF90_PATH_B][i]));
+        for (i = 0; i < 14; i++)
+                RTPRINT(rtlpriv, FINIT, INIT_TxPower,
+                        ("RF-B Legacy to HT40 Diff[%d] = 0x%x\n", i,
+                         rtlefuse->txpwr_legacyhtdiff[RF90_PATH_B][i]));
+        RTPRINT(rtlpriv, FINIT, INIT_TxPower, ("TxPwrSafetyFlag = %d\n",
+                rtlefuse->txpwr_safetyflag));
+        /* Read RF-indication and Tx Power gain
+         * index diff of legacy to HT OFDM rate. */
+        tempval = (*(u8 *)&hwinfo[EEPROM_RFIND_POWERDIFF]) & 0xff;
+        rtlefuse->eeprom_txpowerdiff = tempval;
+        rtlefuse->legacy_httxpowerdiff =
+                rtlefuse->txpwr_legacyhtdiff[RF90_PATH_A][0];
+        RTPRINT(rtlpriv, FINIT, INIT_TxPower, ("TxPowerDiff = %#x\n",
+                rtlefuse->eeprom_txpowerdiff));
+        /* Get TSSI value for each path. */
+        usvalue = *(u16 *)&hwinfo[EEPROM_TSSI_A];
+        rtlefuse->eeprom_tssi[RF90_PATH_A] = (u8)((usvalue & 0xff00) >> 8);
+        usvalue = *(u8 *)&hwinfo[EEPROM_TSSI_B];
+        rtlefuse->eeprom_tssi[RF90_PATH_B] = (u8)(usvalue & 0xff);
+        RTPRINT(rtlpriv, FINIT, INIT_TxPower, ("TSSI_A = 0x%x, TSSI_B = 0x%x\n",
+                 rtlefuse->eeprom_tssi[RF90_PATH_A],
+                 rtlefuse->eeprom_tssi[RF90_PATH_B]));
+        /* Read antenna tx power offset of B/C/D to A  from EEPROM */
+        /* and read ThermalMeter from EEPROM */
+        tempval = *(u8 *)&hwinfo[EEPROM_THERMALMETER];
+        rtlefuse->eeprom_thermalmeter = tempval;
+        RTPRINT(rtlpriv, FINIT, INIT_TxPower, ("thermalmeter = 0x%x\n",
+                rtlefuse->eeprom_thermalmeter));
+        /* ThermalMeter, BIT(0)~3 for RFIC1, BIT(4)~7 for RFIC2 */
+        rtlefuse->thermalmeter[0] = (rtlefuse->eeprom_thermalmeter & 0x1f);
+        rtlefuse->tssi_13dbm = rtlefuse->eeprom_thermalmeter * 100;
+        /* Read CrystalCap from EEPROM */
+        tempval = (*(u8 *)&hwinfo[EEPROM_CRYSTALCAP]) >> 4;
+        rtlefuse->eeprom_crystalcap = tempval;
+        /* CrystalCap, BIT(12)~15 */
+        rtlefuse->crystalcap = rtlefuse->eeprom_crystalcap;
+        /* Read IC Version && Channel Plan */
+        /* Version ID, Channel plan */
+        rtlefuse->eeprom_channelplan = *(u8 *)&hwinfo[EEPROM_CHANNELPLAN];
+        rtlefuse->txpwr_fromeprom = true;
+        RTPRINT(rtlpriv, FINIT, INIT_TxPower, ("EEPROM ChannelPlan = 0x%4x\n",
+                rtlefuse->eeprom_channelplan));
+        /* Read Customer ID or Board Type!!! */
+        tempval = *(u8 *)&hwinfo[EEPROM_BOARDTYPE];
+        /* Change RF type definition */
+        if (tempval == 0)
+                rtlphy->rf_type = RF_2T2R;
+        else if (tempval == 1)
+                rtlphy->rf_type = RF_1T2R;
+        else if (tempval == 2)
+                rtlphy->rf_type = RF_1T2R;
+        else if (tempval == 3)
+                rtlphy->rf_type = RF_1T1R;
+        /* 1T2R but 1SS (1x1 receive combining) */
+        rtlefuse->b1x1_recvcombine = false;
+        if (rtlphy->rf_type == RF_1T2R) {
+                tempval = rtl_read_byte(rtlpriv, 0x07);
+                if (!(tempval & BIT(0))) {
+                        rtlefuse->b1x1_recvcombine = true;
+                        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                                ("RF_TYPE=1T2R but only 1SS\n"));
+                }
+        }
+        rtlefuse->b1ss_support = rtlefuse->b1x1_recvcombine;
+        rtlefuse->eeprom_oemid = *(u8 *)&hwinfo[EEPROM_CUSTOMID];
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, ("EEPROM Customer ID: 0x%2x",
+                        rtlefuse->eeprom_oemid));
+        /* set channel paln to world wide 13 */
+        rtlefuse->channel_plan = COUNTRY_CODE_WORLD_WIDE_13;
+}
+void rtl92se_read_eeprom_info(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        u8 tmp_u1b = 0;
+        tmp_u1b = rtl_read_byte(rtlpriv, EPROM_CMD);
+        if (tmp_u1b & BIT(4)) {
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG, ("Boot from EEPROM\n"));
+                rtlefuse->epromtype = EEPROM_93C46;
+        } else {
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG, ("Boot from EFUSE\n"));
+                rtlefuse->epromtype = EEPROM_BOOT_EFUSE;
+        }
+        if (tmp_u1b & BIT(5)) {
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, ("Autoload OK\n"));
+                rtlefuse->autoload_failflag = false;
+                _rtl92se_read_adapter_info(hw);
+        } else {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, ("Autoload ERR!!\n"));
+                rtlefuse->autoload_failflag = true;
+        }
+}
+static void rtl92se_update_hal_rate_table(struct ieee80211_hw *hw,
+                                          struct ieee80211_sta *sta)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        u32 ratr_value;
+        u8 ratr_index = 0;
+        u8 nmode = mac->ht_enable;
+        u8 mimo_ps = IEEE80211_SMPS_OFF;
+        u16 shortgi_rate = 0;
+        u32 tmp_ratr_value = 0;
+        u8 curtxbw_40mhz = mac->bw_40;
+        u8 curshortgi_40mhz = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40) ?
+                                1 : 0;
+        u8 curshortgi_20mhz = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20) ?
+                                1 : 0;
+        enum wireless_mode wirelessmode = mac->mode;
+        if (rtlhal->current_bandtype == BAND_ON_5G)
+                ratr_value = sta->supp_rates[1] << 4;
+        else
+                ratr_value = sta->supp_rates[0];
+        ratr_value |= (sta->ht_cap.mcs.rx_mask[1] << 20 |
+                        sta->ht_cap.mcs.rx_mask[0] << 12);
+        switch (wirelessmode) {
+        case WIRELESS_MODE_B:
+                ratr_value &= 0x0000000D;
+                break;
+        case WIRELESS_MODE_G:
+                ratr_value &= 0x00000FF5;
+                break;
+        case WIRELESS_MODE_N_24G:
+        case WIRELESS_MODE_N_5G:
+                nmode = 1;
+                if (mimo_ps == IEEE80211_SMPS_STATIC) {
+                        ratr_value &= 0x0007F005;
+                } else {
+                        u32 ratr_mask;
+                        if (get_rf_type(rtlphy) == RF_1T2R ||
+                            get_rf_type(rtlphy) == RF_1T1R) {
+                                if (curtxbw_40mhz)
+                                        ratr_mask = 0x000ff015;
+                                else
+                                        ratr_mask = 0x000ff005;
+                        } else {
+                                if (curtxbw_40mhz)
+                                        ratr_mask = 0x0f0ff015;
+                                else
+                                        ratr_mask = 0x0f0ff005;
+                        }
+                        ratr_value &= ratr_mask;
+                }
+                break;
+        default:
+                if (rtlphy->rf_type == RF_1T2R)
+                        ratr_value &= 0x000ff0ff;
+                else
+                        ratr_value &= 0x0f0ff0ff;
+                break;
+        }
+        if (rtlpriv->rtlhal.version >= VERSION_8192S_BCUT)
+                ratr_value &= 0x0FFFFFFF;
+        else if (rtlpriv->rtlhal.version == VERSION_8192S_ACUT)
+                ratr_value &= 0x0FFFFFF0;
+        if (nmode && ((curtxbw_40mhz &&
+                         curshortgi_40mhz) || (!curtxbw_40mhz &&
+                                                 curshortgi_20mhz))) {
+                ratr_value |= 0x10000000;
+                tmp_ratr_value = (ratr_value >> 12);
+                for (shortgi_rate = 15; shortgi_rate > 0; shortgi_rate--) {
+                        if ((1 << shortgi_rate) & tmp_ratr_value)
+                                break;
+                }
+                shortgi_rate = (shortgi_rate << 12) | (shortgi_rate << 8) |
+                    (shortgi_rate << 4) | (shortgi_rate);
+                rtl_write_byte(rtlpriv, SG_RATE, shortgi_rate);
+        }
+        rtl_write_dword(rtlpriv, ARFR0 + ratr_index * 4, ratr_value);
+        if (ratr_value & 0xfffff000)
+                rtl92s_phy_set_fw_cmd(hw, FW_CMD_RA_REFRESH_N);
+        else
+                rtl92s_phy_set_fw_cmd(hw, FW_CMD_RA_REFRESH_BG);
+        RT_TRACE(rtlpriv, COMP_RATR, DBG_DMESG,
+                 ("%x\n", rtl_read_dword(rtlpriv, ARFR0)));
+}
+static void rtl92se_update_hal_rate_mask(struct ieee80211_hw *hw,
+                                         struct ieee80211_sta *sta,
+                                         u8 rssi_level)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_sta_info *sta_entry = NULL;
+        u32 ratr_bitmap;
+        u8 ratr_index = 0;
+        u8 curtxbw_40mhz = (sta->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40)
+                                ? 1 : 0;
+        u8 curshortgi_40mhz = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40) ?
+                                1 : 0;
+        u8 curshortgi_20mhz = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20) ?
+                                1 : 0;
+        enum wireless_mode wirelessmode = 0;
+        bool shortgi = false;
+        u32 ratr_value = 0;
+        u8 shortgi_rate = 0;
+        u32 mask = 0;
+        u32 band = 0;
+        bool bmulticast = false;
+        u8 macid = 0;
+        u8 mimo_ps = IEEE80211_SMPS_OFF;
+        sta_entry = (struct rtl_sta_info *) sta->drv_priv;
+        wirelessmode = sta_entry->wireless_mode;
+        if (mac->opmode == NL80211_IFTYPE_STATION)
+                curtxbw_40mhz = mac->bw_40;
+        else if (mac->opmode == NL80211_IFTYPE_AP ||
+                mac->opmode == NL80211_IFTYPE_ADHOC)
+                macid = sta->aid + 1;
+        if (rtlhal->current_bandtype == BAND_ON_5G)
+                ratr_bitmap = sta->supp_rates[1] << 4;
+        else
+                ratr_bitmap = sta->supp_rates[0];
+        ratr_bitmap |= (sta->ht_cap.mcs.rx_mask[1] << 20 |
+                        sta->ht_cap.mcs.rx_mask[0] << 12);
+        switch (wirelessmode) {
+        case WIRELESS_MODE_B:
+                band |= WIRELESS_11B;
+                ratr_index = RATR_INX_WIRELESS_B;
+                if (ratr_bitmap & 0x0000000c)
+                        ratr_bitmap &= 0x0000000d;
+                else
+                        ratr_bitmap &= 0x0000000f;
+                break;
+        case WIRELESS_MODE_G:
+                band |= (WIRELESS_11G | WIRELESS_11B);
+                ratr_index = RATR_INX_WIRELESS_GB;
+                if (rssi_level == 1)
+                        ratr_bitmap &= 0x00000f00;
+                else if (rssi_level == 2)
+                        ratr_bitmap &= 0x00000ff0;
+                else
+                        ratr_bitmap &= 0x00000ff5;
+                break;
+        case WIRELESS_MODE_A:
+                band |= WIRELESS_11A;
+                ratr_index = RATR_INX_WIRELESS_A;
+                ratr_bitmap &= 0x00000ff0;
+                break;
+        case WIRELESS_MODE_N_24G:
+        case WIRELESS_MODE_N_5G:
+                band |= (WIRELESS_11N | WIRELESS_11G | WIRELESS_11B);
+                ratr_index = RATR_INX_WIRELESS_NGB;
+                if (mimo_ps == IEEE80211_SMPS_STATIC) {
+                        if (rssi_level == 1)
+                                ratr_bitmap &= 0x00070000;
+                        else if (rssi_level == 2)
+                                ratr_bitmap &= 0x0007f000;
+                        else
+                                ratr_bitmap &= 0x0007f005;
+                } else {
+                        if (rtlphy->rf_type == RF_1T2R ||
+                                rtlphy->rf_type == RF_1T1R) {
+                                if (rssi_level == 1) {
+                                                ratr_bitmap &= 0x000f0000;
+                                } else if (rssi_level == 3) {
+                                        ratr_bitmap &= 0x000fc000;
+                                } else if (rssi_level == 5) {
+                                                ratr_bitmap &= 0x000ff000;
+                                } else {
+                                        if (curtxbw_40mhz)
+                                                ratr_bitmap &= 0x000ff015;
+                                        else
+                                                ratr_bitmap &= 0x000ff005;
+                                }
+                        } else {
+                                if (rssi_level == 1) {
+                                        ratr_bitmap &= 0x0f8f0000;
+                                } else if (rssi_level == 3) {
+                                        ratr_bitmap &= 0x0f8fc000;
+                                } else if (rssi_level == 5) {
+                                        ratr_bitmap &= 0x0f8ff000;
+                                } else {
+                                        if (curtxbw_40mhz)
+                                                ratr_bitmap &= 0x0f8ff015;
+                                        else
+                                                ratr_bitmap &= 0x0f8ff005;
+                                }
+                        }
+                }
+                if ((curtxbw_40mhz && curshortgi_40mhz) ||
+                    (!curtxbw_40mhz && curshortgi_20mhz)) {
+                        if (macid == 0)
+                                shortgi = true;
+                        else if (macid == 1)
+                                shortgi = false;
+                }
+                break;
+        default:
+                band |= (WIRELESS_11N | WIRELESS_11G | WIRELESS_11B);
+                ratr_index = RATR_INX_WIRELESS_NGB;
+                if (rtlphy->rf_type == RF_1T2R)
+                        ratr_bitmap &= 0x000ff0ff;
+                else
+                        ratr_bitmap &= 0x0f8ff0ff;
+                break;
+        }
+        if (rtlpriv->rtlhal.version >= VERSION_8192S_BCUT)
+                ratr_bitmap &= 0x0FFFFFFF;
+        else if (rtlpriv->rtlhal.version == VERSION_8192S_ACUT)
+                ratr_bitmap &= 0x0FFFFFF0;
+        if (shortgi) {
+                ratr_bitmap |= 0x10000000;
+                /* Get MAX MCS available. */
+                ratr_value = (ratr_bitmap >> 12);
+                for (shortgi_rate = 15; shortgi_rate > 0; shortgi_rate--) {
+                        if ((1 << shortgi_rate) & ratr_value)
+                                break;
+                }
+                shortgi_rate = (shortgi_rate << 12) | (shortgi_rate << 8) |
+                        (shortgi_rate << 4) | (shortgi_rate);
+                rtl_write_byte(rtlpriv, SG_RATE, shortgi_rate);
+        }
+        mask |= (bmulticast ? 1 : 0) << 9 | (macid & 0x1f) << 4 | (band & 0xf);
+        RT_TRACE(rtlpriv, COMP_RATR, DBG_TRACE, ("mask = %x, bitmap = %x\n",
+                        mask, ratr_bitmap));
+        rtl_write_dword(rtlpriv, 0x2c4, ratr_bitmap);
+        rtl_write_dword(rtlpriv, WFM5, (FW_RA_UPDATE_MASK | (mask << 8)));
+        if (macid != 0)
+                sta_entry->ratr_index = ratr_index;
+}
+void rtl92se_update_hal_rate_tbl(struct ieee80211_hw *hw,
+                struct ieee80211_sta *sta, u8 rssi_level)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        if (rtlpriv->dm.useramask)
+                rtl92se_update_hal_rate_mask(hw, sta, rssi_level);
+        else
+                rtl92se_update_hal_rate_table(hw, sta);
+}
+void rtl92se_update_channel_access_setting(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        u16 sifs_timer;
+        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_SLOT_TIME,
+                                      (u8 *)&mac->slot_time);
+        sifs_timer = 0x0e0e;
+        rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_SIFS, (u8 *)&sifs_timer);
+}
+/* this ifunction is for RFKILL, it's different with windows,
+ * because UI will disable wireless when GPIO Radio Off.
+ * And here we not check or Disable/Enable ASPM like windows*/
+bool rtl92se_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 *valid)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        enum rf_pwrstate rfpwr_toset, cur_rfstate;
+        unsigned long flag = 0;
+        bool actuallyset = false;
+        bool turnonbypowerdomain = false;
+        /* just 8191se can check gpio before firstup, 92c/92d have fixed it */
+        if ((rtlpci->up_first_time == 1) || (rtlpci->being_init_adapter))
+                return false;
+        if (ppsc->swrf_processing)
+                return false;
+        spin_lock_irqsave(&rtlpriv->locks.rf_ps_lock, flag);
+        if (ppsc->rfchange_inprogress) {
+                spin_unlock_irqrestore(&rtlpriv->locks.rf_ps_lock, flag);
+                return false;
+        } else {
+                ppsc->rfchange_inprogress = true;
+                spin_unlock_irqrestore(&rtlpriv->locks.rf_ps_lock, flag);
+        }
+        cur_rfstate = ppsc->rfpwr_state;
+        /* because after _rtl92s_phy_set_rfhalt, all power
+         * closed, so we must open some power for GPIO check,
+         * or we will always check GPIO RFOFF here,
+         * And we should close power after GPIO check */
+        if (RT_IN_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_HALT_NIC)) {
+                _rtl92se_power_domain_init(hw);
+                turnonbypowerdomain = true;
+        }
+        rfpwr_toset = _rtl92se_rf_onoff_detect(hw);
+        if ((ppsc->hwradiooff == true) && (rfpwr_toset == ERFON)) {
+                RT_TRACE(rtlpriv, COMP_RF, DBG_DMESG,
+                         ("RFKILL-HW Radio ON, RF ON\n"));
+                rfpwr_toset = ERFON;
+                ppsc->hwradiooff = false;
+                actuallyset = true;
+        } else if ((ppsc->hwradiooff == false) && (rfpwr_toset == ERFOFF)) {
+                RT_TRACE(rtlpriv, COMP_RF, DBG_DMESG,
+                         ("RFKILL-HW Radio OFF, RF OFF\n"));
+                rfpwr_toset = ERFOFF;
+                ppsc->hwradiooff = true;
+                actuallyset = true;
+        }
+        if (actuallyset) {
+                spin_lock_irqsave(&rtlpriv->locks.rf_ps_lock, flag);
+                ppsc->rfchange_inprogress = false;
+                spin_unlock_irqrestore(&rtlpriv->locks.rf_ps_lock, flag);
+        /* this not include ifconfig wlan0 down case */
+        /* } else if (rfpwr_toset == ERFOFF || cur_rfstate == ERFOFF) { */
+        } else {
+                /* because power_domain_init may be happen when
+                 * _rtl92s_phy_set_rfhalt, this will open some powers
+                 * and cause current increasing about 40 mA for ips,
+                 * rfoff and ifconfig down, so we set
+                 * _rtl92s_phy_set_rfhalt again here */
+                if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_HALT_NIC &&
+                        turnonbypowerdomain) {
+                        _rtl92s_phy_set_rfhalt(hw);
+                        RT_SET_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_HALT_NIC);
+                }
+                spin_lock_irqsave(&rtlpriv->locks.rf_ps_lock, flag);
+                ppsc->rfchange_inprogress = false;
+                spin_unlock_irqrestore(&rtlpriv->locks.rf_ps_lock, flag);
+        }
+        *valid = 1;
+        return !ppsc->hwradiooff;
+}
+/* Is_wepkey just used for WEP used as group & pairwise key
+ * if pairwise is AES ang group is WEP Is_wepkey == false.*/
+void rtl92se_set_key(struct ieee80211_hw *hw, u32 key_index, u8 *p_macaddr,
+        bool is_group, u8 enc_algo, bool is_wepkey, bool clear_all)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        u8 *macaddr = p_macaddr;
+        u32 entry_id = 0;
+        bool is_pairwise = false;
+        static u8 cam_const_addr[4][6] = {
+                {0x00, 0x00, 0x00, 0x00, 0x00, 0x00},
+                {0x00, 0x00, 0x00, 0x00, 0x00, 0x01},
+                {0x00, 0x00, 0x00, 0x00, 0x00, 0x02},
+                {0x00, 0x00, 0x00, 0x00, 0x00, 0x03}
+        };
+        static u8 cam_const_broad[] = {
+                0xff, 0xff, 0xff, 0xff, 0xff, 0xff
+        };
+        if (clear_all) {
+                u8 idx = 0;
+                u8 cam_offset = 0;
+                u8 clear_number = 5;
+                RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG, ("clear_all\n"));
+                for (idx = 0; idx < clear_number; idx++) {
+                        rtl_cam_mark_invalid(hw, cam_offset + idx);
+                        rtl_cam_empty_entry(hw, cam_offset + idx);
+                        if (idx < 5) {
+                                memset(rtlpriv->sec.key_buf[idx], 0,
+                                       MAX_KEY_LEN);
+                                rtlpriv->sec.key_len[idx] = 0;
+                        }
+                }
+        } else {
+                switch (enc_algo) {
+                case WEP40_ENCRYPTION:
+                        enc_algo = CAM_WEP40;
+                        break;
+                case WEP104_ENCRYPTION:
+                        enc_algo = CAM_WEP104;
+                        break;
+                case TKIP_ENCRYPTION:
+                        enc_algo = CAM_TKIP;
+                        break;
+                case AESCCMP_ENCRYPTION:
+                        enc_algo = CAM_AES;
+                        break;
+                default:
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                        ("switch case not process\n"));
+                        enc_algo = CAM_TKIP;
+                        break;
+                }
+                if (is_wepkey || rtlpriv->sec.use_defaultkey) {
+                        macaddr = cam_const_addr[key_index];
+                        entry_id = key_index;
+                } else {
+                        if (is_group) {
+                                macaddr = cam_const_broad;
+                                entry_id = key_index;
+                        } else {
+                                if (mac->opmode == NL80211_IFTYPE_AP) {
+                                        entry_id = rtl_cam_get_free_entry(hw,
+                                                                 p_macaddr);
+                                        if (entry_id >=  TOTAL_CAM_ENTRY) {
+                                                RT_TRACE(rtlpriv,
+                                                   COMP_SEC, DBG_EMERG,
+                                                   ("Can not find free hw"
+                                                   " security cam entry\n"));
+                                                return;
+                                        }
+                                } else {
+                                        entry_id = CAM_PAIRWISE_KEY_POSITION;
+                                }
+                                key_index = PAIRWISE_KEYIDX;
+                                is_pairwise = true;
+                        }
+                }
+                if (rtlpriv->sec.key_len[key_index] == 0) {
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                                 ("delete one entry, entry_id is %d\n",
+                                 entry_id));
+                        if (mac->opmode == NL80211_IFTYPE_AP)
+                                rtl_cam_del_entry(hw, p_macaddr);
+                        rtl_cam_delete_one_entry(hw, p_macaddr, entry_id);
+                } else {
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
+                                 ("The insert KEY length is %d\n",
+                                  rtlpriv->sec.key_len[PAIRWISE_KEYIDX]));
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
+                                 ("The insert KEY  is %x %x\n",
+                                  rtlpriv->sec.key_buf[0][0],
+                                  rtlpriv->sec.key_buf[0][1]));
+                        RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                                 ("add one entry\n"));
+                        if (is_pairwise) {
+                                RT_PRINT_DATA(rtlpriv, COMP_SEC, DBG_LOUD,
+                                      "Pairwiase Key content :",
+                                       rtlpriv->sec.pairwise_key,
+                                       rtlpriv->sec.key_len[PAIRWISE_KEYIDX]);
+                                RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                                         ("set Pairwiase key\n"));
+                                rtl_cam_add_one_entry(hw, macaddr, key_index,
+                                        entry_id, enc_algo,
+                                        CAM_CONFIG_NO_USEDK,
+                                        rtlpriv->sec.key_buf[key_index]);
+                        } else {
+                                RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
+                                         ("set group key\n"));
+                                if (mac->opmode == NL80211_IFTYPE_ADHOC) {
+                                        rtl_cam_add_one_entry(hw,
+                                                rtlefuse->dev_addr,
+                                                PAIRWISE_KEYIDX,
+                                                CAM_PAIRWISE_KEY_POSITION,
+                                                enc_algo, CAM_CONFIG_NO_USEDK,
+                                                rtlpriv->sec.key_buf[entry_id]);
+                                }
+                                rtl_cam_add_one_entry(hw, macaddr, key_index,
+                                              entry_id, enc_algo,
+                                              CAM_CONFIG_NO_USEDK,
+                                              rtlpriv->sec.key_buf[entry_id]);
+                        }
+                }
+        }
+}
+void rtl92se_suspend(struct ieee80211_hw *hw)
+{
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        rtlpci->up_first_time = true;
+}
+void rtl92se_resume(struct ieee80211_hw *hw)
+{
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        u32 val;
+        pci_read_config_dword(rtlpci->pdev, 0x40, &val);
+        if ((val & 0x0000ff00) != 0)
+                pci_write_config_dword(rtlpci->pdev, 0x40,
+                        val & 0xffff00ff);
+}
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/hw.h b/drivers/net/wireless/rtlwifi/rtl8192se/hw.h
new file mode 100644
index 000000000000..6160a9bfe98a
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/hw.h
@@ -0,0 +1,79 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#ifndef __REALTEK_PCI92SE_HW_H__
+#define __REALTEK_PCI92SE_HW_H__
+#define MSR_LINK_MANAGED   2
+#define MSR_LINK_NONE      0
+#define MSR_LINK_SHIFT     0
+#define MSR_LINK_ADHOC     1
+#define MSR_LINK_MASTER    3
+enum WIRELESS_NETWORK_TYPE {
+        WIRELESS_11B = 1,
+        WIRELESS_11G = 2,
+        WIRELESS_11A = 4,
+        WIRELESS_11N = 8
+};
+void rtl92se_get_hw_reg(struct ieee80211_hw *hw,
+                        u8 variable, u8 *val);
+void rtl92se_read_eeprom_info(struct ieee80211_hw *hw);
+void rtl92se_interrupt_recognized(struct ieee80211_hw *hw,
+                                  u32 *inta, u32 *intb);
+int rtl92se_hw_init(struct ieee80211_hw *hw);
+void rtl92se_card_disable(struct ieee80211_hw *hw);
+void rtl92se_enable_interrupt(struct ieee80211_hw *hw);
+void rtl92se_disable_interrupt(struct ieee80211_hw *hw);
+int rtl92se_set_network_type(struct ieee80211_hw *hw,
+                             enum nl80211_iftype type);
+void rtl92se_set_check_bssid(struct ieee80211_hw *hw, bool check_bssid);
+void rtl92se_set_mac_addr(struct rtl_io *io, const u8 * addr);
+void rtl92se_set_qos(struct ieee80211_hw *hw, int aci);
+void rtl92se_set_beacon_related_registers(struct ieee80211_hw *hw);
+void rtl92se_set_beacon_interval(struct ieee80211_hw *hw);
+void rtl92se_update_interrupt_mask(struct ieee80211_hw *hw,
+                                   u32 add_msr, u32 rm_msr);
+void rtl92se_set_hw_reg(struct ieee80211_hw *hw, u8 variable,
+                        u8 *val);
+void rtl92se_update_hal_rate_tbl(struct ieee80211_hw *hw,
+                struct ieee80211_sta *sta, u8 rssi_level);
+void rtl92se_update_channel_access_setting(struct ieee80211_hw *hw);
+bool rtl92se_gpio_radio_on_off_checking(struct ieee80211_hw *hw,
+                                        u8 *valid);
+void rtl8192se_gpiobit3_cfg_inputmode(struct ieee80211_hw *hw);
+void rtl92se_enable_hw_security_config(struct ieee80211_hw *hw);
+void rtl92se_set_key(struct ieee80211_hw *hw,
+                     u32 key_index, u8 *macaddr, bool is_group,
+                     u8 enc_algo, bool is_wepkey, bool clear_all);
+void rtl92se_suspend(struct ieee80211_hw *hw);
+void rtl92se_resume(struct ieee80211_hw *hw);
+#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/led.c b/drivers/net/wireless/rtlwifi/rtl8192se/led.c
new file mode 100644
index 000000000000..6d4f66616680
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/led.c
@@ -0,0 +1,149 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#include "../wifi.h"
+#include "../pci.h"
+#include "reg.h"
+#include "led.h"
+static void _rtl92se_init_led(struct ieee80211_hw *hw,
+                              struct rtl_led *pled, enum rtl_led_pin ledpin)
+{
+        pled->hw = hw;
+        pled->ledpin = ledpin;
+        pled->ledon = false;
+}
+void rtl92se_init_sw_leds(struct ieee80211_hw *hw)
+{
+        struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw);
+        _rtl92se_init_led(hw, &(pcipriv->ledctl.sw_led0), LED_PIN_LED0);
+        _rtl92se_init_led(hw, &(pcipriv->ledctl.sw_led1), LED_PIN_LED1);
+}
+void rtl92se_sw_led_on(struct ieee80211_hw *hw, struct rtl_led *pled)
+{
+        u8 ledcfg;
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        RT_TRACE(rtlpriv, COMP_LED, DBG_LOUD,
+                 ("LedAddr:%X ledpin=%d\n", LEDCFG, pled->ledpin));
+        ledcfg = rtl_read_byte(rtlpriv, LEDCFG);
+        switch (pled->ledpin) {
+        case LED_PIN_GPIO0:
+                break;
+        case LED_PIN_LED0:
+                rtl_write_byte(rtlpriv, LEDCFG, ledcfg & 0xf0);
+                break;
+        case LED_PIN_LED1:
+                rtl_write_byte(rtlpriv, LEDCFG, ledcfg & 0x0f);
+                break;
+        default:
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("switch case not process\n"));
+                break;
+        }
+        pled->ledon = true;
+}
+void rtl92se_sw_led_off(struct ieee80211_hw *hw, struct rtl_led *pled)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw);
+        u8 ledcfg;
+        RT_TRACE(rtlpriv, COMP_LED, DBG_LOUD,
+                 ("LedAddr:%X ledpin=%d\n", LEDCFG, pled->ledpin));
+        ledcfg = rtl_read_byte(rtlpriv, LEDCFG);
+        switch (pled->ledpin) {
+        case LED_PIN_GPIO0:
+                break;
+        case LED_PIN_LED0:
+                ledcfg &= 0xf0;
+                if (pcipriv->ledctl.led_opendrain == true)
+                        rtl_write_byte(rtlpriv, LEDCFG, (ledcfg | BIT(1)));
+                else
+                        rtl_write_byte(rtlpriv, LEDCFG, (ledcfg | BIT(3)));
+                break;
+        case LED_PIN_LED1:
+                ledcfg &= 0x0f;
+                rtl_write_byte(rtlpriv, LEDCFG, (ledcfg | BIT(3)));
+                break;
+        default:
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("switch case not process\n"));
+                break;
+        }
+        pled->ledon = false;
+}
+static void _rtl92se_sw_led_control(struct ieee80211_hw *hw,
+                                    enum led_ctl_mode ledaction)
+{
+        struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw);
+        struct rtl_led *pLed0 = &(pcipriv->ledctl.sw_led0);
+        switch (ledaction) {
+        case LED_CTL_POWER_ON:
+        case LED_CTL_LINK:
+        case LED_CTL_NO_LINK:
+                rtl92se_sw_led_on(hw, pLed0);
+                break;
+        case LED_CTL_POWER_OFF:
+                rtl92se_sw_led_off(hw, pLed0);
+                break;
+        default:
+                break;
+        }
+}
+void rtl92se_led_control(struct ieee80211_hw *hw, enum led_ctl_mode ledaction)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        if ((ppsc->rfoff_reason > RF_CHANGE_BY_PS) &&
+            (ledaction == LED_CTL_TX ||
+            ledaction == LED_CTL_RX ||
+            ledaction == LED_CTL_SITE_SURVEY ||
+            ledaction == LED_CTL_LINK ||
+            ledaction == LED_CTL_NO_LINK ||
+            ledaction == LED_CTL_START_TO_LINK ||
+            ledaction == LED_CTL_POWER_ON)) {
+                return;
+        }
+        RT_TRACE(rtlpriv, COMP_LED, DBG_LOUD, ("ledaction %d,\n",
+                 ledaction));
+        _rtl92se_sw_led_control(hw, ledaction);
+}
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/led.h b/drivers/net/wireless/rtlwifi/rtl8192se/led.h
new file mode 100644
index 000000000000..8cce3870af3c
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/led.h
@@ -0,0 +1,37 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#ifndef __REALTEK_PCI92SE_LED_H__
+#define __REALTEK_PCI92SE_LED_H__
+void rtl92se_init_sw_leds(struct ieee80211_hw *hw);
+void rtl92se_sw_led_on(struct ieee80211_hw *hw, struct rtl_led *pled);
+void rtl92se_sw_led_off(struct ieee80211_hw *hw, struct rtl_led *pled);
+void rtl92se_led_control(struct ieee80211_hw *hw, enum led_ctl_mode ledaction);
+#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/phy.c b/drivers/net/wireless/rtlwifi/rtl8192se/phy.c
new file mode 100644
index 000000000000..63b45e60a95e
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/phy.c
@@ -0,0 +1,1740 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#include "../wifi.h"
+#include "../pci.h"
+#include "../ps.h"
+#include "reg.h"
+#include "def.h"
+#include "phy.h"
+#include "rf.h"
+#include "dm.h"
+#include "fw.h"
+#include "hw.h"
+#include "table.h"
+static u32 _rtl92s_phy_calculate_bit_shift(u32 bitmask)
+{
+        u32 i;
+        for (i = 0; i <= 31; i++) {
+                if (((bitmask >> i) & 0x1) == 1)
+                        break;
+        }
+        return i;
+}
+u32 rtl92s_phy_query_bb_reg(struct ieee80211_hw *hw, u32 regaddr, u32 bitmask)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u32 returnvalue = 0, originalvalue, bitshift;
+        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, ("regaddr(%#x), bitmask(%#x)\n",
+                        regaddr, bitmask));
+        originalvalue = rtl_read_dword(rtlpriv, regaddr);
+        bitshift = _rtl92s_phy_calculate_bit_shift(bitmask);
+        returnvalue = (originalvalue & bitmask) >> bitshift;
+        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE,
+                 ("BBR MASK=0x%x Addr[0x%x]=0x%x\n",
+                 bitmask, regaddr, originalvalue));
+        return returnvalue;
+}
+void rtl92s_phy_set_bb_reg(struct ieee80211_hw *hw, u32 regaddr, u32 bitmask,
+                           u32 data)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u32 originalvalue, bitshift;
+        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, ("regaddr(%#x), bitmask(%#x),"
+                        " data(%#x)\n", regaddr, bitmask, data));
+        if (bitmask != MASKDWORD) {
+                originalvalue = rtl_read_dword(rtlpriv, regaddr);
+                bitshift = _rtl92s_phy_calculate_bit_shift(bitmask);
+                data = ((originalvalue & (~bitmask)) | (data << bitshift));
+        }
+        rtl_write_dword(rtlpriv, regaddr, data);
+        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, ("regaddr(%#x), bitmask(%#x),"
+                        " data(%#x)\n", regaddr, bitmask, data));
+}
+static u32 _rtl92s_phy_rf_serial_read(struct ieee80211_hw *hw,
+                                      enum radio_path rfpath, u32 offset)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct bb_reg_def *pphyreg = &rtlphy->phyreg_def[rfpath];
+        u32 newoffset;
+        u32 tmplong, tmplong2;
+        u8 rfpi_enable = 0;
+        u32 retvalue = 0;
+        offset &= 0x3f;
+        newoffset = offset;
+        tmplong = rtl_get_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2, MASKDWORD);
+        if (rfpath == RF90_PATH_A)
+                tmplong2 = tmplong;
+        else
+                tmplong2 = rtl_get_bbreg(hw, pphyreg->rfhssi_para2, MASKDWORD);
+        tmplong2 = (tmplong2 & (~BLSSI_READADDRESS)) | (newoffset << 23) |
+                        BLSSI_READEDGE;
+        rtl_set_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2, MASKDWORD,
+                      tmplong & (~BLSSI_READEDGE));
+        mdelay(1);
+        rtl_set_bbreg(hw, pphyreg->rfhssi_para2, MASKDWORD, tmplong2);
+        mdelay(1);
+        rtl_set_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2, MASKDWORD, tmplong |
+                      BLSSI_READEDGE);
+        mdelay(1);
+        if (rfpath == RF90_PATH_A)
+                rfpi_enable = (u8)rtl_get_bbreg(hw, RFPGA0_XA_HSSIPARAMETER1,
+                                                BIT(8));
+        else if (rfpath == RF90_PATH_B)
+                rfpi_enable = (u8)rtl_get_bbreg(hw, RFPGA0_XB_HSSIPARAMETER1,
+                                                BIT(8));
+        if (rfpi_enable)
+                retvalue = rtl_get_bbreg(hw, pphyreg->rflssi_readbackpi,
+                                         BLSSI_READBACK_DATA);
+        else
+                retvalue = rtl_get_bbreg(hw, pphyreg->rflssi_readback,
+                                         BLSSI_READBACK_DATA);
+        retvalue = rtl_get_bbreg(hw, pphyreg->rflssi_readback,
+                                 BLSSI_READBACK_DATA);
+        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, ("RFR-%d Addr[0x%x]=0x%x\n",
+                 rfpath, pphyreg->rflssi_readback, retvalue));
+        return retvalue;
+}
+static void _rtl92s_phy_rf_serial_write(struct ieee80211_hw *hw,
+                                        enum radio_path rfpath, u32 offset,
+                                        u32 data)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct bb_reg_def *pphyreg = &rtlphy->phyreg_def[rfpath];
+        u32 data_and_addr = 0;
+        u32 newoffset;
+        offset &= 0x3f;
+        newoffset = offset;
+        data_and_addr = ((newoffset << 20) | (data & 0x000fffff)) & 0x0fffffff;
+        rtl_set_bbreg(hw, pphyreg->rf3wire_offset, MASKDWORD, data_and_addr);
+        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, ("RFW-%d Addr[0x%x]=0x%x\n",
+                 rfpath, pphyreg->rf3wire_offset, data_and_addr));
+}
+u32 rtl92s_phy_query_rf_reg(struct ieee80211_hw *hw, enum radio_path rfpath,
+                            u32 regaddr, u32 bitmask)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u32 original_value, readback_value, bitshift;
+        unsigned long flags;
+        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, ("regaddr(%#x), rfpath(%#x), "
+                 "bitmask(%#x)\n", regaddr, rfpath, bitmask));
+        spin_lock_irqsave(&rtlpriv->locks.rf_lock, flags);
+        original_value = _rtl92s_phy_rf_serial_read(hw, rfpath, regaddr);
+        bitshift = _rtl92s_phy_calculate_bit_shift(bitmask);
+        readback_value = (original_value & bitmask) >> bitshift;
+        spin_unlock_irqrestore(&rtlpriv->locks.rf_lock, flags);
+        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, ("regaddr(%#x), rfpath(%#x), "
+                 "bitmask(%#x), original_value(%#x)\n", regaddr, rfpath,
+                 bitmask, original_value));
+        return readback_value;
+}
+void rtl92s_phy_set_rf_reg(struct ieee80211_hw *hw, enum radio_path rfpath,
+                           u32 regaddr, u32 bitmask, u32 data)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        u32 original_value, bitshift;
+        unsigned long flags;
+        if (!((rtlphy->rf_pathmap >> rfpath) & 0x1))
+                return;
+        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, ("regaddr(%#x), bitmask(%#x),"
+                 " data(%#x), rfpath(%#x)\n", regaddr, bitmask, data, rfpath));
+        spin_lock_irqsave(&rtlpriv->locks.rf_lock, flags);
+        if (bitmask != RFREG_OFFSET_MASK) {
+                original_value = _rtl92s_phy_rf_serial_read(hw, rfpath,
+                                                            regaddr);
+                bitshift = _rtl92s_phy_calculate_bit_shift(bitmask);
+                data = ((original_value & (~bitmask)) | (data << bitshift));
+        }
+        _rtl92s_phy_rf_serial_write(hw, rfpath, regaddr, data);
+        spin_unlock_irqrestore(&rtlpriv->locks.rf_lock, flags);
+        RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, ("regaddr(%#x), bitmask(%#x), "
+                 "data(%#x), rfpath(%#x)\n", regaddr, bitmask, data, rfpath));
+}
+void rtl92s_phy_scan_operation_backup(struct ieee80211_hw *hw,
+                                      u8 operation)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        if (!is_hal_stop(rtlhal)) {
+                switch (operation) {
+                case SCAN_OPT_BACKUP:
+                        rtl92s_phy_set_fw_cmd(hw, FW_CMD_PAUSE_DM_BY_SCAN);
+                        break;
+                case SCAN_OPT_RESTORE:
+                        rtl92s_phy_set_fw_cmd(hw, FW_CMD_RESUME_DM_BY_SCAN);
+                        break;
+                default:
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                 ("Unknown operation.\n"));
+                        break;
+                }
+        }
+}
+void rtl92s_phy_set_bw_mode(struct ieee80211_hw *hw,
+                            enum nl80211_channel_type ch_type)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        u8 reg_bw_opmode;
+        u8 reg_prsr_rsc;
+        RT_TRACE(rtlpriv, COMP_SCAN, DBG_TRACE, ("Switch to %s bandwidth\n",
+                  rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20 ?
+                  "20MHz" : "40MHz"));
+        if (rtlphy->set_bwmode_inprogress)
+                return;
+        if (is_hal_stop(rtlhal))
+                return;
+        rtlphy->set_bwmode_inprogress = true;
+        reg_bw_opmode = rtl_read_byte(rtlpriv, BW_OPMODE);
+        reg_prsr_rsc = rtl_read_byte(rtlpriv, RRSR + 2);
+        switch (rtlphy->current_chan_bw) {
+        case HT_CHANNEL_WIDTH_20:
+                reg_bw_opmode |= BW_OPMODE_20MHZ;
+                rtl_write_byte(rtlpriv, BW_OPMODE, reg_bw_opmode);
+                break;
+        case HT_CHANNEL_WIDTH_20_40:
+                reg_bw_opmode &= ~BW_OPMODE_20MHZ;
+                rtl_write_byte(rtlpriv, BW_OPMODE, reg_bw_opmode);
+                break;
+        default:
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("unknown bandwidth: %#X\n",
+                         rtlphy->current_chan_bw));
+                break;
+        }
+        switch (rtlphy->current_chan_bw) {
+        case HT_CHANNEL_WIDTH_20:
+                rtl_set_bbreg(hw, RFPGA0_RFMOD, BRFMOD, 0x0);
+                rtl_set_bbreg(hw, RFPGA1_RFMOD, BRFMOD, 0x0);
+                if (rtlhal->version >= VERSION_8192S_BCUT)
+                        rtl_write_byte(rtlpriv, RFPGA0_ANALOGPARAMETER2, 0x58);
+                break;
+        case HT_CHANNEL_WIDTH_20_40:
+                rtl_set_bbreg(hw, RFPGA0_RFMOD, BRFMOD, 0x1);
+                rtl_set_bbreg(hw, RFPGA1_RFMOD, BRFMOD, 0x1);
+                rtl_set_bbreg(hw, RCCK0_SYSTEM, BCCK_SIDEBAND,
+                                (mac->cur_40_prime_sc >> 1));
+                rtl_set_bbreg(hw, ROFDM1_LSTF, 0xC00, mac->cur_40_prime_sc);
+                if (rtlhal->version >= VERSION_8192S_BCUT)
+                        rtl_write_byte(rtlpriv, RFPGA0_ANALOGPARAMETER2, 0x18);
+                break;
+        default:
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("unknown bandwidth: %#X\n", rtlphy->current_chan_bw));
+                break;
+        }
+        rtl92s_phy_rf6052_set_bandwidth(hw, rtlphy->current_chan_bw);
+        rtlphy->set_bwmode_inprogress = false;
+        RT_TRACE(rtlpriv, COMP_SCAN, DBG_TRACE, ("<==\n"));
+}
+static bool _rtl92s_phy_set_sw_chnl_cmdarray(struct swchnlcmd *cmdtable,
+                u32 cmdtableidx, u32 cmdtablesz, enum swchnlcmd_id cmdid,
+                u32 para1, u32 para2, u32 msdelay)
+{
+        struct swchnlcmd *pcmd;
+        if (cmdtable == NULL) {
+                RT_ASSERT(false, ("cmdtable cannot be NULL.\n"));
+                return false;
+        }
+        if (cmdtableidx >= cmdtablesz)
+                return false;
+        pcmd = cmdtable + cmdtableidx;
+        pcmd->cmdid = cmdid;
+        pcmd->para1 = para1;
+        pcmd->para2 = para2;
+        pcmd->msdelay = msdelay;
+        return true;
+}
+static bool _rtl92s_phy_sw_chnl_step_by_step(struct ieee80211_hw *hw,
+             u8 channel, u8 *stage, u8 *step, u32 *delay)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct swchnlcmd precommoncmd[MAX_PRECMD_CNT];
+        u32 precommoncmdcnt;
+        struct swchnlcmd postcommoncmd[MAX_POSTCMD_CNT];
+        u32 postcommoncmdcnt;
+        struct swchnlcmd rfdependcmd[MAX_RFDEPENDCMD_CNT];
+        u32 rfdependcmdcnt;
+        struct swchnlcmd *currentcmd = NULL;
+        u8 rfpath;
+        u8 num_total_rfpath = rtlphy->num_total_rfpath;
+        precommoncmdcnt = 0;
+        _rtl92s_phy_set_sw_chnl_cmdarray(precommoncmd, precommoncmdcnt++,
+                        MAX_PRECMD_CNT, CMDID_SET_TXPOWEROWER_LEVEL, 0, 0, 0);
+        _rtl92s_phy_set_sw_chnl_cmdarray(precommoncmd, precommoncmdcnt++,
+                        MAX_PRECMD_CNT, CMDID_END, 0, 0, 0);
+        postcommoncmdcnt = 0;
+        _rtl92s_phy_set_sw_chnl_cmdarray(postcommoncmd, postcommoncmdcnt++,
+                        MAX_POSTCMD_CNT, CMDID_END, 0, 0, 0);
+        rfdependcmdcnt = 0;
+        RT_ASSERT((channel >= 1 && channel <= 14),
+                  ("illegal channel for Zebra: %d\n", channel));
+        _rtl92s_phy_set_sw_chnl_cmdarray(rfdependcmd, rfdependcmdcnt++,
+                                         MAX_RFDEPENDCMD_CNT, CMDID_RF_WRITEREG,
+                                         RF_CHNLBW, channel, 10);
+        _rtl92s_phy_set_sw_chnl_cmdarray(rfdependcmd, rfdependcmdcnt++,
+                        MAX_RFDEPENDCMD_CNT, CMDID_END, 0, 0, 0);
+        do {
+                switch (*stage) {
+                case 0:
+                        currentcmd = &precommoncmd[*step];
+                        break;
+                case 1:
+                        currentcmd = &rfdependcmd[*step];
+                        break;
+                case 2:
+                        currentcmd = &postcommoncmd[*step];
+                        break;
+                }
+                if (currentcmd->cmdid == CMDID_END) {
+                        if ((*stage) == 2) {
+                                return true;
+                        } else {
+                                (*stage)++;
+                                (*step) = 0;
+                                continue;
+                        }
+                }
+                switch (currentcmd->cmdid) {
+                case CMDID_SET_TXPOWEROWER_LEVEL:
+                        rtl92s_phy_set_txpower(hw, channel);
+                        break;
+                case CMDID_WRITEPORT_ULONG:
+                        rtl_write_dword(rtlpriv, currentcmd->para1,
+                                        currentcmd->para2);
+                        break;
+                case CMDID_WRITEPORT_USHORT:
+                        rtl_write_word(rtlpriv, currentcmd->para1,
+                                       (u16)currentcmd->para2);
+                        break;
+                case CMDID_WRITEPORT_UCHAR:
+                        rtl_write_byte(rtlpriv, currentcmd->para1,
+                                       (u8)currentcmd->para2);
+                        break;
+                case CMDID_RF_WRITEREG:
+                        for (rfpath = 0; rfpath < num_total_rfpath; rfpath++) {
+                                rtlphy->rfreg_chnlval[rfpath] =
+                                         ((rtlphy->rfreg_chnlval[rfpath] &
+                                         0xfffffc00) | currentcmd->para2);
+                                rtl_set_rfreg(hw, (enum radio_path)rfpath,
+                                              currentcmd->para1,
+                                              RFREG_OFFSET_MASK,
+                                              rtlphy->rfreg_chnlval[rfpath]);
+                        }
+                        break;
+                default:
+                        RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                                 ("switch case not process\n"));
+                        break;
+                }
+                break;
+        } while (true);
+        (*delay) = currentcmd->msdelay;
+        (*step)++;
+        return false;
+}
+u8 rtl92s_phy_sw_chnl(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        u32 delay;
+        bool ret;
+        RT_TRACE(rtlpriv, COMP_SCAN, DBG_TRACE,
+                 ("switch to channel%d\n",
+                 rtlphy->current_channel));
+        if (rtlphy->sw_chnl_inprogress)
+                return 0;
+        if (rtlphy->set_bwmode_inprogress)
+                return 0;
+        if (is_hal_stop(rtlhal))
+                return 0;
+        rtlphy->sw_chnl_inprogress = true;
+        rtlphy->sw_chnl_stage = 0;
+        rtlphy->sw_chnl_step = 0;
+        do {
+                if (!rtlphy->sw_chnl_inprogress)
+                        break;
+                ret = _rtl92s_phy_sw_chnl_step_by_step(hw,
+                                 rtlphy->current_channel,
+                                 &rtlphy->sw_chnl_stage,
+                                 &rtlphy->sw_chnl_step, &delay);
+                if (!ret) {
+                        if (delay > 0)
+                                mdelay(delay);
+                        else
+                                continue;
+                } else {
+                        rtlphy->sw_chnl_inprogress = false;
+                }
+                break;
+        } while (true);
+        rtlphy->sw_chnl_inprogress = false;
+        RT_TRACE(rtlpriv, COMP_SCAN, DBG_TRACE, ("<==\n"));
+        return 1;
+}
+static void _rtl92se_phy_set_rf_sleep(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u8 u1btmp;
+        u1btmp = rtl_read_byte(rtlpriv, LDOV12D_CTRL);
+        u1btmp |= BIT(0);
+        rtl_write_byte(rtlpriv, LDOV12D_CTRL, u1btmp);
+        rtl_write_byte(rtlpriv, SPS1_CTRL, 0x0);
+        rtl_write_byte(rtlpriv, TXPAUSE, 0xFF);
+        rtl_write_word(rtlpriv, CMDR, 0x57FC);
+        udelay(100);
+        rtl_write_word(rtlpriv, CMDR, 0x77FC);
+        rtl_write_byte(rtlpriv, PHY_CCA, 0x0);
+        udelay(10);
+        rtl_write_word(rtlpriv, CMDR, 0x37FC);
+        udelay(10);
+        rtl_write_word(rtlpriv, CMDR, 0x77FC);
+        udelay(10);
+        rtl_write_word(rtlpriv, CMDR, 0x57FC);
+        /* we should chnge GPIO to input mode
+         * this will drop away current about 25mA*/
+        rtl8192se_gpiobit3_cfg_inputmode(hw);
+}
+bool rtl92s_phy_set_rf_power_state(struct ieee80211_hw *hw,
+                                   enum rf_pwrstate rfpwr_state)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        bool bresult = true;
+        u8 i, queue_id;
+        struct rtl8192_tx_ring *ring = NULL;
+        if (rfpwr_state == ppsc->rfpwr_state)
+                return false;
+        ppsc->set_rfpowerstate_inprogress = true;
+        switch (rfpwr_state) {
+        case ERFON:{
+                        if ((ppsc->rfpwr_state == ERFOFF) &&
+                            RT_IN_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_HALT_NIC)) {
+                                bool rtstatus;
+                                u32 InitializeCount = 0;
+                                do {
+                                        InitializeCount++;
+                                        RT_TRACE(rtlpriv, COMP_RF, DBG_DMESG,
+                                                 ("IPS Set eRf nic enable\n"));
+                                        rtstatus = rtl_ps_enable_nic(hw);
+                                } while ((rtstatus != true) &&
+                                         (InitializeCount < 10));
+                                RT_CLEAR_PS_LEVEL(ppsc,
+                                                  RT_RF_OFF_LEVL_HALT_NIC);
+                        } else {
+                                RT_TRACE(rtlpriv, COMP_POWER, DBG_DMESG,
+                                         ("awake, sleeped:%d ms "
+                                        "state_inap:%x\n",
+                                        jiffies_to_msecs(jiffies -
+                                        ppsc->last_sleep_jiffies),
+                                        rtlpriv->psc.state_inap));
+                                ppsc->last_awake_jiffies = jiffies;
+                                rtl_write_word(rtlpriv, CMDR, 0x37FC);
+                                rtl_write_byte(rtlpriv, TXPAUSE, 0x00);
+                                rtl_write_byte(rtlpriv, PHY_CCA, 0x3);
+                        }
+                        if (mac->link_state == MAC80211_LINKED)
+                                rtlpriv->cfg->ops->led_control(hw,
+                                                         LED_CTL_LINK);
+                        else
+                                rtlpriv->cfg->ops->led_control(hw,
+                                                         LED_CTL_NO_LINK);
+                        break;
+                }
+        case ERFOFF:{
+                        if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_HALT_NIC) {
+                                RT_TRACE(rtlpriv, COMP_RF, DBG_DMESG,
+                                         ("IPS Set eRf nic disable\n"));
+                                rtl_ps_disable_nic(hw);
+                                RT_SET_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_HALT_NIC);
+                        } else {
+                                if (ppsc->rfoff_reason == RF_CHANGE_BY_IPS)
+                                        rtlpriv->cfg->ops->led_control(hw,
+                                                         LED_CTL_NO_LINK);
+                                else
+                                        rtlpriv->cfg->ops->led_control(hw,
+                                                         LED_CTL_POWER_OFF);
+                        }
+                        break;
+                }
+        case ERFSLEEP:
+                        if (ppsc->rfpwr_state == ERFOFF)
+                                break;
+                        for (queue_id = 0, i = 0;
+                             queue_id < RTL_PCI_MAX_TX_QUEUE_COUNT;) {
+                                ring = &pcipriv->dev.tx_ring[queue_id];
+                                if (skb_queue_len(&ring->queue) == 0 ||
+                                        queue_id == BEACON_QUEUE) {
+                                        queue_id++;
+                                        continue;
+                                } else {
+                                        RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
+                                                 ("eRf Off/Sleep: "
+                                                 "%d times TcbBusyQueue[%d] = "
+                                                 "%d before doze!\n",
+                                                 (i + 1), queue_id,
+                                                 skb_queue_len(&ring->queue)));
+                                        udelay(10);
+                                        i++;
+                                }
+                                if (i >= MAX_DOZE_WAITING_TIMES_9x) {
+                                        RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
+                                                 ("\nERFOFF: %d times"
+                                                 "TcbBusyQueue[%d] = %d !\n",
+                                                 MAX_DOZE_WAITING_TIMES_9x,
+                                                 queue_id,
+                                                 skb_queue_len(&ring->queue)));
+                                        break;
+                                }
+                        }
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_DMESG,
+                                 ("Set ERFSLEEP awaked:%d ms\n",
+                                 jiffies_to_msecs(jiffies -
+                                 ppsc->last_awake_jiffies)));
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_DMESG,
+                                 ("sleep awaked:%d ms "
+                                "state_inap:%x\n", jiffies_to_msecs(jiffies -
+                                ppsc->last_awake_jiffies),
+                                rtlpriv->psc.state_inap));
+                        ppsc->last_sleep_jiffies = jiffies;
+                        _rtl92se_phy_set_rf_sleep(hw);
+            break;
+        default:
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("switch case not process\n"));
+                bresult = false;
+                break;
+        }
+        if (bresult)
+                ppsc->rfpwr_state = rfpwr_state;
+        ppsc->set_rfpowerstate_inprogress = false;
+        return bresult;
+}
+static bool _rtl92s_phy_config_rfpa_bias_current(struct ieee80211_hw *hw,
+                                                 enum radio_path rfpath)
+{
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        bool rtstatus = true;
+        u32 tmpval = 0;
+        /* If inferiority IC, we have to increase the PA bias current */
+        if (rtlhal->ic_class != IC_INFERIORITY_A) {
+                tmpval = rtl92s_phy_query_rf_reg(hw, rfpath, RF_IPA, 0xf);
+                rtl92s_phy_set_rf_reg(hw, rfpath, RF_IPA, 0xf, tmpval + 1);
+        }
+        return rtstatus;
+}
+static void _rtl92s_store_pwrindex_diffrate_offset(struct ieee80211_hw *hw,
+                u32 reg_addr, u32 bitmask, u32 data)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        if (reg_addr == RTXAGC_RATE18_06)
+                rtlphy->mcs_txpwrlevel_origoffset[rtlphy->pwrgroup_cnt][0] =
+                                                                         data;
+        if (reg_addr == RTXAGC_RATE54_24)
+                rtlphy->mcs_txpwrlevel_origoffset[rtlphy->pwrgroup_cnt][1] =
+                                                                         data;
+        if (reg_addr == RTXAGC_CCK_MCS32)
+                rtlphy->mcs_txpwrlevel_origoffset[rtlphy->pwrgroup_cnt][6] =
+                                                                         data;
+        if (reg_addr == RTXAGC_MCS03_MCS00)
+                rtlphy->mcs_txpwrlevel_origoffset[rtlphy->pwrgroup_cnt][2] =
+                                                                         data;
+        if (reg_addr == RTXAGC_MCS07_MCS04)
+                rtlphy->mcs_txpwrlevel_origoffset[rtlphy->pwrgroup_cnt][3] =
+                                                                         data;
+        if (reg_addr == RTXAGC_MCS11_MCS08)
+                rtlphy->mcs_txpwrlevel_origoffset[rtlphy->pwrgroup_cnt][4] =
+                                                                         data;
+        if (reg_addr == RTXAGC_MCS15_MCS12) {
+                rtlphy->mcs_txpwrlevel_origoffset[rtlphy->pwrgroup_cnt][5] =
+                                                                         data;
+                rtlphy->pwrgroup_cnt++;
+        }
+}
+static void _rtl92s_phy_init_register_definition(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        /*RF Interface Sowrtware Control */
+        rtlphy->phyreg_def[RF90_PATH_A].rfintfs = RFPGA0_XAB_RFINTERFACESW;
+        rtlphy->phyreg_def[RF90_PATH_B].rfintfs = RFPGA0_XAB_RFINTERFACESW;
+        rtlphy->phyreg_def[RF90_PATH_C].rfintfs = RFPGA0_XCD_RFINTERFACESW;
+        rtlphy->phyreg_def[RF90_PATH_D].rfintfs = RFPGA0_XCD_RFINTERFACESW;
+        /* RF Interface Readback Value */
+        rtlphy->phyreg_def[RF90_PATH_A].rfintfi = RFPGA0_XAB_RFINTERFACERB;
+        rtlphy->phyreg_def[RF90_PATH_B].rfintfi = RFPGA0_XAB_RFINTERFACERB;
+        rtlphy->phyreg_def[RF90_PATH_C].rfintfi = RFPGA0_XCD_RFINTERFACERB;
+        rtlphy->phyreg_def[RF90_PATH_D].rfintfi = RFPGA0_XCD_RFINTERFACERB;
+        /* RF Interface Output (and Enable) */
+        rtlphy->phyreg_def[RF90_PATH_A].rfintfo = RFPGA0_XA_RFINTERFACEOE;
+        rtlphy->phyreg_def[RF90_PATH_B].rfintfo = RFPGA0_XB_RFINTERFACEOE;
+        rtlphy->phyreg_def[RF90_PATH_C].rfintfo = RFPGA0_XC_RFINTERFACEOE;
+        rtlphy->phyreg_def[RF90_PATH_D].rfintfo = RFPGA0_XD_RFINTERFACEOE;
+        /* RF Interface (Output and)  Enable */
+        rtlphy->phyreg_def[RF90_PATH_A].rfintfe = RFPGA0_XA_RFINTERFACEOE;
+        rtlphy->phyreg_def[RF90_PATH_B].rfintfe = RFPGA0_XB_RFINTERFACEOE;
+        rtlphy->phyreg_def[RF90_PATH_C].rfintfe = RFPGA0_XC_RFINTERFACEOE;
+        rtlphy->phyreg_def[RF90_PATH_D].rfintfe = RFPGA0_XD_RFINTERFACEOE;
+        /* Addr of LSSI. Wirte RF register by driver */
+        rtlphy->phyreg_def[RF90_PATH_A].rf3wire_offset =
+                                                 RFPGA0_XA_LSSIPARAMETER;
+        rtlphy->phyreg_def[RF90_PATH_B].rf3wire_offset =
+                                                 RFPGA0_XB_LSSIPARAMETER;
+        rtlphy->phyreg_def[RF90_PATH_C].rf3wire_offset =
+                                                 RFPGA0_XC_LSSIPARAMETER;
+        rtlphy->phyreg_def[RF90_PATH_D].rf3wire_offset =
+                                                 RFPGA0_XD_LSSIPARAMETER;
+        /* RF parameter */
+        rtlphy->phyreg_def[RF90_PATH_A].rflssi_select = RFPGA0_XAB_RFPARAMETER;
+        rtlphy->phyreg_def[RF90_PATH_B].rflssi_select = RFPGA0_XAB_RFPARAMETER;
+        rtlphy->phyreg_def[RF90_PATH_C].rflssi_select = RFPGA0_XCD_RFPARAMETER;
+        rtlphy->phyreg_def[RF90_PATH_D].rflssi_select = RFPGA0_XCD_RFPARAMETER;
+        /* Tx AGC Gain Stage (same for all path. Should we remove this?) */
+        rtlphy->phyreg_def[RF90_PATH_A].rftxgain_stage = RFPGA0_TXGAINSTAGE;
+        rtlphy->phyreg_def[RF90_PATH_B].rftxgain_stage = RFPGA0_TXGAINSTAGE;
+        rtlphy->phyreg_def[RF90_PATH_C].rftxgain_stage = RFPGA0_TXGAINSTAGE;
+        rtlphy->phyreg_def[RF90_PATH_D].rftxgain_stage = RFPGA0_TXGAINSTAGE;
+        /* Tranceiver A~D HSSI Parameter-1 */
+        rtlphy->phyreg_def[RF90_PATH_A].rfhssi_para1 = RFPGA0_XA_HSSIPARAMETER1;
+        rtlphy->phyreg_def[RF90_PATH_B].rfhssi_para1 = RFPGA0_XB_HSSIPARAMETER1;
+        rtlphy->phyreg_def[RF90_PATH_C].rfhssi_para1 = RFPGA0_XC_HSSIPARAMETER1;
+        rtlphy->phyreg_def[RF90_PATH_D].rfhssi_para1 = RFPGA0_XD_HSSIPARAMETER1;
+        /* Tranceiver A~D HSSI Parameter-2 */
+        rtlphy->phyreg_def[RF90_PATH_A].rfhssi_para2 = RFPGA0_XA_HSSIPARAMETER2;
+        rtlphy->phyreg_def[RF90_PATH_B].rfhssi_para2 = RFPGA0_XB_HSSIPARAMETER2;
+        rtlphy->phyreg_def[RF90_PATH_C].rfhssi_para2 = RFPGA0_XC_HSSIPARAMETER2;
+        rtlphy->phyreg_def[RF90_PATH_D].rfhssi_para2 = RFPGA0_XD_HSSIPARAMETER2;
+        /* RF switch Control */
+        rtlphy->phyreg_def[RF90_PATH_A].rfswitch_control =
+                                                 RFPGA0_XAB_SWITCHCONTROL;
+        rtlphy->phyreg_def[RF90_PATH_B].rfswitch_control =
+                                                 RFPGA0_XAB_SWITCHCONTROL;
+        rtlphy->phyreg_def[RF90_PATH_C].rfswitch_control =
+                                                 RFPGA0_XCD_SWITCHCONTROL;
+        rtlphy->phyreg_def[RF90_PATH_D].rfswitch_control =
+                                                 RFPGA0_XCD_SWITCHCONTROL;
+        /* AGC control 1  */
+        rtlphy->phyreg_def[RF90_PATH_A].rfagc_control1 = ROFDM0_XAAGCCORE1;
+        rtlphy->phyreg_def[RF90_PATH_B].rfagc_control1 = ROFDM0_XBAGCCORE1;
+        rtlphy->phyreg_def[RF90_PATH_C].rfagc_control1 = ROFDM0_XCAGCCORE1;
+        rtlphy->phyreg_def[RF90_PATH_D].rfagc_control1 = ROFDM0_XDAGCCORE1;
+        /* AGC control 2  */
+        rtlphy->phyreg_def[RF90_PATH_A].rfagc_control2 = ROFDM0_XAAGCCORE2;
+        rtlphy->phyreg_def[RF90_PATH_B].rfagc_control2 = ROFDM0_XBAGCCORE2;
+        rtlphy->phyreg_def[RF90_PATH_C].rfagc_control2 = ROFDM0_XCAGCCORE2;
+        rtlphy->phyreg_def[RF90_PATH_D].rfagc_control2 = ROFDM0_XDAGCCORE2;
+        /* RX AFE control 1  */
+        rtlphy->phyreg_def[RF90_PATH_A].rfrxiq_imbalance =
+                                                 ROFDM0_XARXIQIMBALANCE;
+        rtlphy->phyreg_def[RF90_PATH_B].rfrxiq_imbalance =
+                                                 ROFDM0_XBRXIQIMBALANCE;
+        rtlphy->phyreg_def[RF90_PATH_C].rfrxiq_imbalance =
+                                                 ROFDM0_XCRXIQIMBALANCE;
+        rtlphy->phyreg_def[RF90_PATH_D].rfrxiq_imbalance =
+                                                 ROFDM0_XDRXIQIMBALANCE;
+        /* RX AFE control 1   */
+        rtlphy->phyreg_def[RF90_PATH_A].rfrx_afe = ROFDM0_XARXAFE;
+        rtlphy->phyreg_def[RF90_PATH_B].rfrx_afe = ROFDM0_XBRXAFE;
+        rtlphy->phyreg_def[RF90_PATH_C].rfrx_afe = ROFDM0_XCRXAFE;
+        rtlphy->phyreg_def[RF90_PATH_D].rfrx_afe = ROFDM0_XDRXAFE;
+        /* Tx AFE control 1  */
+        rtlphy->phyreg_def[RF90_PATH_A].rftxiq_imbalance =
+                                                 ROFDM0_XATXIQIMBALANCE;
+        rtlphy->phyreg_def[RF90_PATH_B].rftxiq_imbalance =
+                                                 ROFDM0_XBTXIQIMBALANCE;
+        rtlphy->phyreg_def[RF90_PATH_C].rftxiq_imbalance =
+                                                 ROFDM0_XCTXIQIMBALANCE;
+        rtlphy->phyreg_def[RF90_PATH_D].rftxiq_imbalance =
+                                                 ROFDM0_XDTXIQIMBALANCE;
+        /* Tx AFE control 2  */
+        rtlphy->phyreg_def[RF90_PATH_A].rftx_afe = ROFDM0_XATXAFE;
+        rtlphy->phyreg_def[RF90_PATH_B].rftx_afe = ROFDM0_XBTXAFE;
+        rtlphy->phyreg_def[RF90_PATH_C].rftx_afe = ROFDM0_XCTXAFE;
+        rtlphy->phyreg_def[RF90_PATH_D].rftx_afe = ROFDM0_XDTXAFE;
+        /* Tranceiver LSSI Readback */
+        rtlphy->phyreg_def[RF90_PATH_A].rflssi_readback =
+                         RFPGA0_XA_LSSIREADBACK;
+        rtlphy->phyreg_def[RF90_PATH_B].rflssi_readback =
+                         RFPGA0_XB_LSSIREADBACK;
+        rtlphy->phyreg_def[RF90_PATH_C].rflssi_readback =
+                         RFPGA0_XC_LSSIREADBACK;
+        rtlphy->phyreg_def[RF90_PATH_D].rflssi_readback =
+                         RFPGA0_XD_LSSIREADBACK;
+        /* Tranceiver LSSI Readback PI mode  */
+        rtlphy->phyreg_def[RF90_PATH_A].rflssi_readbackpi =
+                         TRANSCEIVERA_HSPI_READBACK;
+        rtlphy->phyreg_def[RF90_PATH_B].rflssi_readbackpi =
+                         TRANSCEIVERB_HSPI_READBACK;
+}
+static bool _rtl92s_phy_config_bb(struct ieee80211_hw *hw, u8 configtype)
+{
+        int i;
+        u32 *phy_reg_table;
+        u32 *agc_table;
+        u16 phy_reg_len, agc_len;
+        agc_len = AGCTAB_ARRAYLENGTH;
+        agc_table = rtl8192seagctab_array;
+        /* Default RF_type: 2T2R */
+        phy_reg_len = PHY_REG_2T2RARRAYLENGTH;
+        phy_reg_table = rtl8192sephy_reg_2t2rarray;
+        if (configtype == BASEBAND_CONFIG_PHY_REG) {
+                for (i = 0; i < phy_reg_len; i = i + 2) {
+                        if (phy_reg_table[i] == 0xfe)
+                                mdelay(50);
+                        else if (phy_reg_table[i] == 0xfd)
+                                mdelay(5);
+                        else if (phy_reg_table[i] == 0xfc)
+                                mdelay(1);
+                        else if (phy_reg_table[i] == 0xfb)
+                                udelay(50);
+                        else if (phy_reg_table[i] == 0xfa)
+                                udelay(5);
+                        else if (phy_reg_table[i] == 0xf9)
+                                udelay(1);
+                        /* Add delay for ECS T20 & LG malow platform, */
+                        udelay(1);
+                        rtl92s_phy_set_bb_reg(hw, phy_reg_table[i], MASKDWORD,
+                                        phy_reg_table[i + 1]);
+                }
+        } else if (configtype == BASEBAND_CONFIG_AGC_TAB) {
+                for (i = 0; i < agc_len; i = i + 2) {
+                        rtl92s_phy_set_bb_reg(hw, agc_table[i], MASKDWORD,
+                                        agc_table[i + 1]);
+                        /* Add delay for ECS T20 & LG malow platform */
+                        udelay(1);
+                }
+        }
+        return true;
+}
+static bool _rtl92s_phy_set_bb_to_diff_rf(struct ieee80211_hw *hw,
+                                          u8 configtype)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        u32 *phy_regarray2xtxr_table;
+        u16 phy_regarray2xtxr_len;
+        int i;
+        if (rtlphy->rf_type == RF_1T1R) {
+                phy_regarray2xtxr_table = rtl8192sephy_changeto_1t1rarray;
+                phy_regarray2xtxr_len = PHY_CHANGETO_1T1RARRAYLENGTH;
+        } else if (rtlphy->rf_type == RF_1T2R) {
+                phy_regarray2xtxr_table = rtl8192sephy_changeto_1t2rarray;
+                phy_regarray2xtxr_len = PHY_CHANGETO_1T2RARRAYLENGTH;
+        } else {
+                return false;
+        }
+        if (configtype == BASEBAND_CONFIG_PHY_REG) {
+                for (i = 0; i < phy_regarray2xtxr_len; i = i + 3) {
+                        if (phy_regarray2xtxr_table[i] == 0xfe)
+                                mdelay(50);
+                        else if (phy_regarray2xtxr_table[i] == 0xfd)
+                                mdelay(5);
+                        else if (phy_regarray2xtxr_table[i] == 0xfc)
+                                mdelay(1);
+                        else if (phy_regarray2xtxr_table[i] == 0xfb)
+                                udelay(50);
+                        else if (phy_regarray2xtxr_table[i] == 0xfa)
+                                udelay(5);
+                        else if (phy_regarray2xtxr_table[i] == 0xf9)
+                                udelay(1);
+                        rtl92s_phy_set_bb_reg(hw, phy_regarray2xtxr_table[i],
+                                phy_regarray2xtxr_table[i + 1],
+                                phy_regarray2xtxr_table[i + 2]);
+                }
+        }
+        return true;
+}
+static bool _rtl92s_phy_config_bb_with_pg(struct ieee80211_hw *hw,
+                                          u8 configtype)
+{
+        int i;
+        u32 *phy_table_pg;
+        u16 phy_pg_len;
+        phy_pg_len = PHY_REG_ARRAY_PGLENGTH;
+        phy_table_pg = rtl8192sephy_reg_array_pg;
+        if (configtype == BASEBAND_CONFIG_PHY_REG) {
+                for (i = 0; i < phy_pg_len; i = i + 3) {
+                        if (phy_table_pg[i] == 0xfe)
+                                mdelay(50);
+                        else if (phy_table_pg[i] == 0xfd)
+                                mdelay(5);
+                        else if (phy_table_pg[i] == 0xfc)
+                                mdelay(1);
+                        else if (phy_table_pg[i] == 0xfb)
+                                udelay(50);
+                        else if (phy_table_pg[i] == 0xfa)
+                                udelay(5);
+                        else if (phy_table_pg[i] == 0xf9)
+                                udelay(1);
+                        _rtl92s_store_pwrindex_diffrate_offset(hw,
+                                        phy_table_pg[i],
+                                        phy_table_pg[i + 1],
+                                        phy_table_pg[i + 2]);
+                        rtl92s_phy_set_bb_reg(hw, phy_table_pg[i],
+                                        phy_table_pg[i + 1],
+                                        phy_table_pg[i + 2]);
+                }
+        }
+        return true;
+}
+static bool _rtl92s_phy_bb_config_parafile(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        bool rtstatus = true;
+        /* 1. Read PHY_REG.TXT BB INIT!! */
+        /* We will separate as 1T1R/1T2R/1T2R_GREEN/2T2R */
+        if (rtlphy->rf_type == RF_1T2R || rtlphy->rf_type == RF_2T2R ||
+            rtlphy->rf_type == RF_1T1R || rtlphy->rf_type == RF_2T2R_GREEN) {
+                rtstatus = _rtl92s_phy_config_bb(hw, BASEBAND_CONFIG_PHY_REG);
+                if (rtlphy->rf_type != RF_2T2R &&
+                    rtlphy->rf_type != RF_2T2R_GREEN)
+                        /* so we should reconfig BB reg with the right
+                         * PHY parameters. */
+                        rtstatus = _rtl92s_phy_set_bb_to_diff_rf(hw,
+                                                BASEBAND_CONFIG_PHY_REG);
+        } else {
+                rtstatus = false;
+        }
+        if (rtstatus != true) {
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
+                         ("Write BB Reg Fail!!"));
+                goto phy_BB8190_Config_ParaFile_Fail;
+        }
+        /* 2. If EEPROM or EFUSE autoload OK, We must config by
+         *    PHY_REG_PG.txt */
+        if (rtlefuse->autoload_failflag == false) {
+                rtlphy->pwrgroup_cnt = 0;
+                rtstatus = _rtl92s_phy_config_bb_with_pg(hw,
+                                                 BASEBAND_CONFIG_PHY_REG);
+        }
+        if (rtstatus != true) {
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
+                         ("_rtl92s_phy_bb_config_parafile(): "
+                         "BB_PG Reg Fail!!"));
+                goto phy_BB8190_Config_ParaFile_Fail;
+        }
+        /* 3. BB AGC table Initialization */
+        rtstatus = _rtl92s_phy_config_bb(hw, BASEBAND_CONFIG_AGC_TAB);
+        if (rtstatus != true) {
+                printk(KERN_ERR  "_rtl92s_phy_bb_config_parafile(): "
+                       "AGC Table Fail\n");
+                goto phy_BB8190_Config_ParaFile_Fail;
+        }
+        /* Check if the CCK HighPower is turned ON. */
+        /* This is used to calculate PWDB. */
+        rtlphy->cck_high_power = (bool)(rtl92s_phy_query_bb_reg(hw,
+                        RFPGA0_XA_HSSIPARAMETER2, 0x200));
+phy_BB8190_Config_ParaFile_Fail:
+        return rtstatus;
+}
+u8 rtl92s_phy_config_rf(struct ieee80211_hw *hw, enum radio_path rfpath)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        int i;
+        bool rtstatus = true;
+        u32 *radio_a_table;
+        u32 *radio_b_table;
+        u16 radio_a_tblen, radio_b_tblen;
+        radio_a_tblen = RADIOA_1T_ARRAYLENGTH;
+        radio_a_table = rtl8192seradioa_1t_array;
+        /* Using Green mode array table for RF_2T2R_GREEN */
+        if (rtlphy->rf_type == RF_2T2R_GREEN) {
+                radio_b_table = rtl8192seradiob_gm_array;
+                radio_b_tblen = RADIOB_GM_ARRAYLENGTH;
+        } else {
+                radio_b_table = rtl8192seradiob_array;
+                radio_b_tblen = RADIOB_ARRAYLENGTH;
+        }
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, ("Radio No %x\n", rfpath));
+        rtstatus = true;
+        switch (rfpath) {
+        case RF90_PATH_A:
+                for (i = 0; i < radio_a_tblen; i = i + 2) {
+                        if (radio_a_table[i] == 0xfe)
+                                /* Delay specific ms. Only RF configuration
+                                 * requires delay. */
+                                mdelay(50);
+                        else if (radio_a_table[i] == 0xfd)
+                                mdelay(5);
+                        else if (radio_a_table[i] == 0xfc)
+                                mdelay(1);
+                        else if (radio_a_table[i] == 0xfb)
+                                udelay(50);
+                        else if (radio_a_table[i] == 0xfa)
+                                udelay(5);
+                        else if (radio_a_table[i] == 0xf9)
+                                udelay(1);
+                        else
+                                rtl92s_phy_set_rf_reg(hw, rfpath,
+                                                      radio_a_table[i],
+                                                      MASK20BITS,
+                                                      radio_a_table[i + 1]);
+                        /* Add delay for ECS T20 & LG malow platform */
+                        udelay(1);
+                }
+                /* PA Bias current for inferiority IC */
+                _rtl92s_phy_config_rfpa_bias_current(hw, rfpath);
+                break;
+        case RF90_PATH_B:
+                for (i = 0; i < radio_b_tblen; i = i + 2) {
+                        if (radio_b_table[i] == 0xfe)
+                                /* Delay specific ms. Only RF configuration
+                                 * requires delay.*/
+                                mdelay(50);
+                        else if (radio_b_table[i] == 0xfd)
+                                mdelay(5);
+                        else if (radio_b_table[i] == 0xfc)
+                                mdelay(1);
+                        else if (radio_b_table[i] == 0xfb)
+                                udelay(50);
+                        else if (radio_b_table[i] == 0xfa)
+                                udelay(5);
+                        else if (radio_b_table[i] == 0xf9)
+                                udelay(1);
+                        else
+                                rtl92s_phy_set_rf_reg(hw, rfpath,
+                                                      radio_b_table[i],
+                                                      MASK20BITS,
+                                                      radio_b_table[i + 1]);
+                        /* Add delay for ECS T20 & LG malow platform */
+                        udelay(1);
+                }
+                break;
+        case RF90_PATH_C:
+                ;
+                break;
+        case RF90_PATH_D:
+                ;
+                break;
+        default:
+                break;
+        }
+        return rtstatus;
+}
+bool rtl92s_phy_mac_config(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u32 i;
+        u32 arraylength;
+        u32 *ptraArray;
+        arraylength = MAC_2T_ARRAYLENGTH;
+        ptraArray = rtl8192semac_2t_array;
+        for (i = 0; i < arraylength; i = i + 2)
+                rtl_write_byte(rtlpriv, ptraArray[i], (u8)ptraArray[i + 1]);
+        return true;
+}
+bool rtl92s_phy_bb_config(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        bool rtstatus = true;
+        u8 pathmap, index, rf_num = 0;
+        u8 path1, path2;
+        _rtl92s_phy_init_register_definition(hw);
+        /* Config BB and AGC */
+        rtstatus = _rtl92s_phy_bb_config_parafile(hw);
+        /* Check BB/RF confiuration setting. */
+        /* We only need to configure RF which is turned on. */
+        path1 = (u8)(rtl92s_phy_query_bb_reg(hw, RFPGA0_TXINFO, 0xf));
+        mdelay(10);
+        path2 = (u8)(rtl92s_phy_query_bb_reg(hw, ROFDM0_TRXPATHENABLE, 0xf));
+        pathmap = path1 | path2;
+        rtlphy->rf_pathmap = pathmap;
+        for (index = 0; index < 4; index++) {
+                if ((pathmap >> index) & 0x1)
+                        rf_num++;
+        }
+        if ((rtlphy->rf_type == RF_1T1R && rf_num != 1) ||
+            (rtlphy->rf_type == RF_1T2R && rf_num != 2) ||
+            (rtlphy->rf_type == RF_2T2R && rf_num != 2) ||
+            (rtlphy->rf_type == RF_2T2R_GREEN && rf_num != 2)) {
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
+                         ("RF_Type(%x) does not match "
+                         "RF_Num(%x)!!\n", rtlphy->rf_type, rf_num));
+                RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
+                         ("path1 0x%x, path2 0x%x, pathmap "
+                          "0x%x\n", path1, path2, pathmap));
+        }
+        return rtstatus;
+}
+bool rtl92s_phy_rf_config(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        /* Initialize general global value */
+        if (rtlphy->rf_type == RF_1T1R)
+                rtlphy->num_total_rfpath = 1;
+        else
+                rtlphy->num_total_rfpath = 2;
+        /* Config BB and RF */
+        return rtl92s_phy_rf6052_config(hw);
+}
+void rtl92s_phy_get_hw_reg_originalvalue(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        /* read rx initial gain */
+        rtlphy->default_initialgain[0] = rtl_get_bbreg(hw,
+                        ROFDM0_XAAGCCORE1, MASKBYTE0);
+        rtlphy->default_initialgain[1] = rtl_get_bbreg(hw,
+                        ROFDM0_XBAGCCORE1, MASKBYTE0);
+        rtlphy->default_initialgain[2] = rtl_get_bbreg(hw,
+                        ROFDM0_XCAGCCORE1, MASKBYTE0);
+        rtlphy->default_initialgain[3] = rtl_get_bbreg(hw,
+                        ROFDM0_XDAGCCORE1, MASKBYTE0);
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, ("Default initial gain "
+                 "(c50=0x%x, c58=0x%x, c60=0x%x, c68=0x%x)\n",
+                 rtlphy->default_initialgain[0],
+                 rtlphy->default_initialgain[1],
+                 rtlphy->default_initialgain[2],
+                 rtlphy->default_initialgain[3]));
+        /* read framesync */
+        rtlphy->framesync = rtl_get_bbreg(hw, ROFDM0_RXDETECTOR3, MASKBYTE0);
+        rtlphy->framesync_c34 = rtl_get_bbreg(hw, ROFDM0_RXDETECTOR2,
+                                              MASKDWORD);
+        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
+                 ("Default framesync (0x%x) = 0x%x\n",
+                 ROFDM0_RXDETECTOR3, rtlphy->framesync));
+}
+static void _rtl92s_phy_get_txpower_index(struct ieee80211_hw *hw, u8 channel,
+                                          u8 *cckpowerlevel, u8 *ofdmpowerLevel)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        u8 index = (channel - 1);
+        /* 1. CCK */
+        /* RF-A */
+        cckpowerlevel[0] = rtlefuse->txpwrlevel_cck[0][index];
+        /* RF-B */
+        cckpowerlevel[1] = rtlefuse->txpwrlevel_cck[1][index];
+        /* 2. OFDM for 1T or 2T */
+        if (rtlphy->rf_type == RF_1T2R || rtlphy->rf_type == RF_1T1R) {
+                /* Read HT 40 OFDM TX power */
+                ofdmpowerLevel[0] = rtlefuse->txpwrlevel_ht40_1s[0][index];
+                ofdmpowerLevel[1] = rtlefuse->txpwrlevel_ht40_1s[1][index];
+        } else if (rtlphy->rf_type == RF_2T2R) {
+                /* Read HT 40 OFDM TX power */
+                ofdmpowerLevel[0] = rtlefuse->txpwrlevel_ht40_2s[0][index];
+                ofdmpowerLevel[1] = rtlefuse->txpwrlevel_ht40_2s[1][index];
+        }
+}
+static void _rtl92s_phy_ccxpower_indexcheck(struct ieee80211_hw *hw,
+                u8 channel, u8 *cckpowerlevel, u8 *ofdmpowerlevel)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        rtlphy->cur_cck_txpwridx = cckpowerlevel[0];
+        rtlphy->cur_ofdm24g_txpwridx = ofdmpowerlevel[0];
+}
+void rtl92s_phy_set_txpower(struct ieee80211_hw *hw, u8 channel)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        /* [0]:RF-A, [1]:RF-B */
+        u8 cckpowerlevel[2], ofdmpowerLevel[2];
+        if (rtlefuse->txpwr_fromeprom == false)
+                return;
+        /* Mainly we use RF-A Tx Power to write the Tx Power registers,
+         * but the RF-B Tx Power must be calculated by the antenna diff.
+         * So we have to rewrite Antenna gain offset register here.
+         * Please refer to BB register 0x80c
+         * 1. For CCK.
+         * 2. For OFDM 1T or 2T */
+        _rtl92s_phy_get_txpower_index(hw, channel, &cckpowerlevel[0],
+                        &ofdmpowerLevel[0]);
+        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                        ("Channel-%d, cckPowerLevel (A / B) = "
+                        "0x%x / 0x%x,   ofdmPowerLevel (A / B) = 0x%x / 0x%x\n",
+                        channel, cckpowerlevel[0], cckpowerlevel[1],
+                        ofdmpowerLevel[0], ofdmpowerLevel[1]));
+        _rtl92s_phy_ccxpower_indexcheck(hw, channel, &cckpowerlevel[0],
+                        &ofdmpowerLevel[0]);
+        rtl92s_phy_rf6052_set_ccktxpower(hw, cckpowerlevel[0]);
+        rtl92s_phy_rf6052_set_ofdmtxpower(hw, &ofdmpowerLevel[0], channel);
+}
+void rtl92s_phy_chk_fwcmd_iodone(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u16 pollingcnt = 10000;
+        u32 tmpvalue;
+        /* Make sure that CMD IO has be accepted by FW. */
+        do {
+                udelay(10);
+                tmpvalue = rtl_read_dword(rtlpriv, WFM5);
+                if (tmpvalue == 0)
+                        break;
+        } while (--pollingcnt);
+        if (pollingcnt == 0)
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, ("Set FW Cmd fail!!\n"));
+}
+static void _rtl92s_phy_set_fwcmd_io(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        u32 input, current_aid = 0;
+        if (is_hal_stop(rtlhal))
+                return;
+        /* We re-map RA related CMD IO to combinational ones */
+        /* if FW version is v.52 or later. */
+        switch (rtlhal->current_fwcmd_io) {
+        case FW_CMD_RA_REFRESH_N:
+                rtlhal->current_fwcmd_io = FW_CMD_RA_REFRESH_N_COMB;
+                break;
+        case FW_CMD_RA_REFRESH_BG:
+                rtlhal->current_fwcmd_io = FW_CMD_RA_REFRESH_BG_COMB;
+                break;
+        default:
+                break;
+        }
+        switch (rtlhal->current_fwcmd_io) {
+        case FW_CMD_RA_RESET:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_DMESG,
+                         ("FW_CMD_RA_RESET\n"));
+                rtl_write_dword(rtlpriv, WFM5, FW_RA_RESET);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                break;
+        case FW_CMD_RA_ACTIVE:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_DMESG,
+                         ("FW_CMD_RA_ACTIVE\n"));
+                rtl_write_dword(rtlpriv, WFM5, FW_RA_ACTIVE);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                break;
+        case FW_CMD_RA_REFRESH_N:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_DMESG,
+                         ("FW_CMD_RA_REFRESH_N\n"));
+                input = FW_RA_REFRESH;
+                rtl_write_dword(rtlpriv, WFM5, input);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                rtl_write_dword(rtlpriv, WFM5, FW_RA_ENABLE_RSSI_MASK);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                break;
+        case FW_CMD_RA_REFRESH_BG:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_DMESG,
+                         ("FW_CMD_RA_REFRESH_BG\n"));
+                rtl_write_dword(rtlpriv, WFM5, FW_RA_REFRESH);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                rtl_write_dword(rtlpriv, WFM5, FW_RA_DISABLE_RSSI_MASK);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                break;
+        case FW_CMD_RA_REFRESH_N_COMB:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_DMESG,
+                         ("FW_CMD_RA_REFRESH_N_COMB\n"));
+                input = FW_RA_IOT_N_COMB;
+                rtl_write_dword(rtlpriv, WFM5, input);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                break;
+        case FW_CMD_RA_REFRESH_BG_COMB:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_DMESG,
+                         ("FW_CMD_RA_REFRESH_BG_COMB\n"));
+                input = FW_RA_IOT_BG_COMB;
+                rtl_write_dword(rtlpriv, WFM5, input);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                break;
+        case FW_CMD_IQK_ENABLE:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_DMESG,
+                         ("FW_CMD_IQK_ENABLE\n"));
+                rtl_write_dword(rtlpriv, WFM5, FW_IQK_ENABLE);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                break;
+        case FW_CMD_PAUSE_DM_BY_SCAN:
+                /* Lower initial gain */
+                rtl_set_bbreg(hw, ROFDM0_XAAGCCORE1, MASKBYTE0, 0x17);
+                rtl_set_bbreg(hw, ROFDM0_XBAGCCORE1, MASKBYTE0, 0x17);
+                /* CCA threshold */
+                rtl_set_bbreg(hw, RCCK0_CCA, MASKBYTE2, 0x40);
+                break;
+        case FW_CMD_RESUME_DM_BY_SCAN:
+                /* CCA threshold */
+                rtl_set_bbreg(hw, RCCK0_CCA, MASKBYTE2, 0xcd);
+                rtl92s_phy_set_txpower(hw, rtlphy->current_channel);
+                break;
+        case FW_CMD_HIGH_PWR_DISABLE:
+                if (rtlpriv->dm.dm_flag & HAL_DM_HIPWR_DISABLE)
+                        break;
+                /* Lower initial gain */
+                rtl_set_bbreg(hw, ROFDM0_XAAGCCORE1, MASKBYTE0, 0x17);
+                rtl_set_bbreg(hw, ROFDM0_XBAGCCORE1, MASKBYTE0, 0x17);
+                /* CCA threshold */
+                rtl_set_bbreg(hw, RCCK0_CCA, MASKBYTE2, 0x40);
+                break;
+        case FW_CMD_HIGH_PWR_ENABLE:
+                if ((rtlpriv->dm.dm_flag & HAL_DM_HIPWR_DISABLE) ||
+                        (rtlpriv->dm.dynamic_txpower_enable == true))
+                        break;
+                /* CCA threshold */
+                rtl_set_bbreg(hw, RCCK0_CCA, MASKBYTE2, 0xcd);
+                break;
+        case FW_CMD_LPS_ENTER:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_DMESG,
+                         ("FW_CMD_LPS_ENTER\n"));
+                current_aid = rtlpriv->mac80211.assoc_id;
+                rtl_write_dword(rtlpriv, WFM5, (FW_LPS_ENTER |
+                                ((current_aid | 0xc000) << 8)));
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                /* FW set TXOP disable here, so disable EDCA
+                 * turbo mode until driver leave LPS */
+                break;
+        case FW_CMD_LPS_LEAVE:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_DMESG,
+                         ("FW_CMD_LPS_LEAVE\n"));
+                rtl_write_dword(rtlpriv, WFM5, FW_LPS_LEAVE);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                break;
+        case FW_CMD_ADD_A2_ENTRY:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_DMESG,
+                         ("FW_CMD_ADD_A2_ENTRY\n"));
+                rtl_write_dword(rtlpriv, WFM5, FW_ADD_A2_ENTRY);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                break;
+        case FW_CMD_CTRL_DM_BY_DRIVER:
+                RT_TRACE(rtlpriv, COMP_CMD, DBG_LOUD,
+                         ("FW_CMD_CTRL_DM_BY_DRIVER\n"));
+                rtl_write_dword(rtlpriv, WFM5, FW_CTRL_DM_BY_DRIVER);
+                rtl92s_phy_chk_fwcmd_iodone(hw);
+                break;
+        default:
+                break;
+        }
+        rtl92s_phy_chk_fwcmd_iodone(hw);
+        /* Clear FW CMD operation flag. */
+        rtlhal->set_fwcmd_inprogress = false;
+}
+bool rtl92s_phy_set_fw_cmd(struct ieee80211_hw *hw, enum fwcmd_iotype fw_cmdio)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        u32     fw_param = FW_CMD_IO_PARA_QUERY(rtlpriv);
+        u16     fw_cmdmap = FW_CMD_IO_QUERY(rtlpriv);
+        bool bPostProcessing = false;
+        RT_TRACE(rtlpriv, COMP_CMD, DBG_LOUD,
+                        ("Set FW Cmd(%#x), set_fwcmd_inprogress(%d)\n",
+                        fw_cmdio, rtlhal->set_fwcmd_inprogress));
+        do {
+                /* We re-map to combined FW CMD ones if firmware version */
+                /* is v.53 or later. */
+                switch (fw_cmdio) {
+                case FW_CMD_RA_REFRESH_N:
+                        fw_cmdio = FW_CMD_RA_REFRESH_N_COMB;
+                        break;
+                case FW_CMD_RA_REFRESH_BG:
+                        fw_cmdio = FW_CMD_RA_REFRESH_BG_COMB;
+                        break;
+                default:
+                        break;
+                }
+                /* If firmware version is v.62 or later,
+                 * use FW_CMD_IO_SET for FW_CMD_CTRL_DM_BY_DRIVER */
+                if (hal_get_firmwareversion(rtlpriv) >= 0x3E) {
+                        if (fw_cmdio == FW_CMD_CTRL_DM_BY_DRIVER)
+                                fw_cmdio = FW_CMD_CTRL_DM_BY_DRIVER_NEW;
+                }
+                /* We shall revise all FW Cmd IO into Reg0x364
+                 * DM map table in the future. */
+                switch (fw_cmdio) {
+                case FW_CMD_RA_INIT:
+                        RT_TRACE(rtlpriv, COMP_CMD, DBG_LOUD, ("RA init!!\n"));
+                        fw_cmdmap |= FW_RA_INIT_CTL;
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        /* Clear control flag to sync with FW. */
+                        FW_CMD_IO_CLR(rtlpriv, FW_RA_INIT_CTL);
+                        break;
+                case FW_CMD_DIG_DISABLE:
+                        RT_TRACE(rtlpriv, COMP_CMD, DBG_LOUD,
+                                 ("Set DIG disable!!\n"));
+                        fw_cmdmap &= ~FW_DIG_ENABLE_CTL;
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        break;
+                case FW_CMD_DIG_ENABLE:
+                case FW_CMD_DIG_RESUME:
+                        if (!(rtlpriv->dm.dm_flag & HAL_DM_DIG_DISABLE)) {
+                                RT_TRACE(rtlpriv, COMP_CMD, DBG_LOUD,
+                                        ("Set DIG enable or resume!!\n"));
+                                fw_cmdmap |= (FW_DIG_ENABLE_CTL | FW_SS_CTL);
+                                FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        }
+                        break;
+                case FW_CMD_DIG_HALT:
+                        RT_TRACE(rtlpriv, COMP_CMD, DBG_LOUD,
+                                 ("Set DIG halt!!\n"));
+                        fw_cmdmap &= ~(FW_DIG_ENABLE_CTL | FW_SS_CTL);
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        break;
+                case FW_CMD_TXPWR_TRACK_THERMAL: {
+                        u8      thermalval = 0;
+                        fw_cmdmap |= FW_PWR_TRK_CTL;
+                        /* Clear FW parameter in terms of thermal parts. */
+                        fw_param &= FW_PWR_TRK_PARAM_CLR;
+                        thermalval = rtlpriv->dm.thermalvalue;
+                        fw_param |= ((thermalval << 24) |
+                                     (rtlefuse->thermalmeter[0] << 16));
+                        RT_TRACE(rtlpriv, COMP_CMD, DBG_LOUD,
+                                 ("Set TxPwr tracking!! "
+                                 "FwCmdMap(%#x), FwParam(%#x)\n",
+                                 fw_cmdmap, fw_param));
+                        FW_CMD_PARA_SET(rtlpriv, fw_param);
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        /* Clear control flag to sync with FW. */
+                        FW_CMD_IO_CLR(rtlpriv, FW_PWR_TRK_CTL);
+                        }
+                        break;
+                /* The following FW CMDs are only compatible to
+                 * v.53 or later. */
+                case FW_CMD_RA_REFRESH_N_COMB:
+                        fw_cmdmap |= FW_RA_N_CTL;
+                        /* Clear RA BG mode control. */
+                        fw_cmdmap &= ~(FW_RA_BG_CTL | FW_RA_INIT_CTL);
+                        /* Clear FW parameter in terms of RA parts. */
+                        fw_param &= FW_RA_PARAM_CLR;
+                        RT_TRACE(rtlpriv, COMP_CMD, DBG_LOUD,
+                                 ("[FW CMD] [New Version] "
+                                 "Set RA/IOT Comb in n mode!! FwCmdMap(%#x), "
+                                 "FwParam(%#x)\n", fw_cmdmap, fw_param));
+                        FW_CMD_PARA_SET(rtlpriv, fw_param);
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        /* Clear control flag to sync with FW. */
+                        FW_CMD_IO_CLR(rtlpriv, FW_RA_N_CTL);
+                        break;
+                case FW_CMD_RA_REFRESH_BG_COMB:
+                        fw_cmdmap |= FW_RA_BG_CTL;
+                        /* Clear RA n-mode control. */
+                        fw_cmdmap &= ~(FW_RA_N_CTL | FW_RA_INIT_CTL);
+                        /* Clear FW parameter in terms of RA parts. */
+                        fw_param &= FW_RA_PARAM_CLR;
+                        FW_CMD_PARA_SET(rtlpriv, fw_param);
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        /* Clear control flag to sync with FW. */
+                        FW_CMD_IO_CLR(rtlpriv, FW_RA_BG_CTL);
+                        break;
+                case FW_CMD_IQK_ENABLE:
+                        fw_cmdmap |= FW_IQK_CTL;
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        /* Clear control flag to sync with FW. */
+                        FW_CMD_IO_CLR(rtlpriv, FW_IQK_CTL);
+                        break;
+                /* The following FW CMD is compatible to v.62 or later.  */
+                case FW_CMD_CTRL_DM_BY_DRIVER_NEW:
+                        fw_cmdmap |= FW_DRIVER_CTRL_DM_CTL;
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        break;
+                /*  The followed FW Cmds needs post-processing later. */
+                case FW_CMD_RESUME_DM_BY_SCAN:
+                        fw_cmdmap |= (FW_DIG_ENABLE_CTL |
+                                      FW_HIGH_PWR_ENABLE_CTL |
+                                      FW_SS_CTL);
+                        if (rtlpriv->dm.dm_flag & HAL_DM_DIG_DISABLE ||
+                                !digtable.dig_enable_flag)
+                                fw_cmdmap &= ~FW_DIG_ENABLE_CTL;
+                        if ((rtlpriv->dm.dm_flag & HAL_DM_HIPWR_DISABLE) ||
+                            (rtlpriv->dm.dynamic_txpower_enable == true))
+                                fw_cmdmap &= ~FW_HIGH_PWR_ENABLE_CTL;
+                        if ((digtable.dig_ext_port_stage ==
+                            DIG_EXT_PORT_STAGE_0) ||
+                            (digtable.dig_ext_port_stage ==
+                            DIG_EXT_PORT_STAGE_1))
+                                fw_cmdmap &= ~FW_DIG_ENABLE_CTL;
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        bPostProcessing = true;
+                        break;
+                case FW_CMD_PAUSE_DM_BY_SCAN:
+                        fw_cmdmap &= ~(FW_DIG_ENABLE_CTL |
+                                       FW_HIGH_PWR_ENABLE_CTL |
+                                       FW_SS_CTL);
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        bPostProcessing = true;
+                        break;
+                case FW_CMD_HIGH_PWR_DISABLE:
+                        fw_cmdmap &= ~FW_HIGH_PWR_ENABLE_CTL;
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        bPostProcessing = true;
+                        break;
+                case FW_CMD_HIGH_PWR_ENABLE:
+                        if (!(rtlpriv->dm.dm_flag & HAL_DM_HIPWR_DISABLE) &&
+                                (rtlpriv->dm.dynamic_txpower_enable != true)) {
+                                fw_cmdmap |= (FW_HIGH_PWR_ENABLE_CTL |
+                                              FW_SS_CTL);
+                                FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                                bPostProcessing = true;
+                        }
+                        break;
+                case FW_CMD_DIG_MODE_FA:
+                        fw_cmdmap |= FW_FA_CTL;
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        break;
+                case FW_CMD_DIG_MODE_SS:
+                        fw_cmdmap &= ~FW_FA_CTL;
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        break;
+                case FW_CMD_PAPE_CONTROL:
+                        RT_TRACE(rtlpriv, COMP_CMD, DBG_LOUD,
+                                 ("[FW CMD] Set PAPE Control\n"));
+                        fw_cmdmap &= ~FW_PAPE_CTL_BY_SW_HW;
+                        FW_CMD_IO_SET(rtlpriv, fw_cmdmap);
+                        break;
+                default:
+                        /* Pass to original FW CMD processing callback
+                         * routine. */
+                        bPostProcessing = true;
+                        break;
+                }
+        } while (false);
+        /* We shall post processing these FW CMD if
+         * variable bPostProcessing is set. */
+        if (bPostProcessing && !rtlhal->set_fwcmd_inprogress) {
+                rtlhal->set_fwcmd_inprogress = true;
+                /* Update current FW Cmd for callback use. */
+                rtlhal->current_fwcmd_io = fw_cmdio;
+        } else {
+                return false;
+        }
+        _rtl92s_phy_set_fwcmd_io(hw);
+        return true;
+}
+static  void _rtl92s_phy_check_ephy_switchready(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u32     delay = 100;
+        u8      regu1;
+        regu1 = rtl_read_byte(rtlpriv, 0x554);
+        while ((regu1 & BIT(5)) && (delay > 0)) {
+                regu1 = rtl_read_byte(rtlpriv, 0x554);
+                delay--;
+                /* We delay only 50us to prevent
+                 * being scheduled out. */
+                udelay(50);
+        }
+}
+void rtl92s_phy_switch_ephy_parameter(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
+        /* The way to be capable to switch clock request
+         * when the PG setting does not support clock request.
+         * This is the backdoor solution to switch clock
+         * request before ASPM or D3. */
+        rtl_write_dword(rtlpriv, 0x540, 0x73c11);
+        rtl_write_dword(rtlpriv, 0x548, 0x2407c);
+        /* Switch EPHY parameter!!!! */
+        rtl_write_word(rtlpriv, 0x550, 0x1000);
+        rtl_write_byte(rtlpriv, 0x554, 0x20);
+        _rtl92s_phy_check_ephy_switchready(hw);
+        rtl_write_word(rtlpriv, 0x550, 0xa0eb);
+        rtl_write_byte(rtlpriv, 0x554, 0x3e);
+        _rtl92s_phy_check_ephy_switchready(hw);
+        rtl_write_word(rtlpriv, 0x550, 0xff80);
+        rtl_write_byte(rtlpriv, 0x554, 0x39);
+        _rtl92s_phy_check_ephy_switchready(hw);
+        /* Delay L1 enter time */
+        if (ppsc->support_aspm && !ppsc->support_backdoor)
+                rtl_write_byte(rtlpriv, 0x560, 0x40);
+        else
+                rtl_write_byte(rtlpriv, 0x560, 0x00);
+}
+void rtl92s_phy_set_beacon_hwreg(struct ieee80211_hw *hw, u16 BeaconInterval)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        rtl_write_dword(rtlpriv, WFM5, 0xF1000000 | (BeaconInterval << 8));
+}
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/phy.h b/drivers/net/wireless/rtlwifi/rtl8192se/phy.h
new file mode 100644
index 000000000000..37e504af6446
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/phy.h
@@ -0,0 +1,101 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#ifndef __RTL92S_PHY_H__
+#define __RTL92S_PHY_H__
+#define MAX_TXPWR_IDX_NMODE_92S         63
+#define MAX_DOZE_WAITING_TIMES_9x       64
+/* Channel switch:The size of
+ * command tables for switch channel */
+#define MAX_PRECMD_CNT                  16
+#define MAX_RFDEPENDCMD_CNT             16
+#define MAX_POSTCMD_CNT                 16
+#define RF90_PATH_MAX                   4
+enum version_8192s {
+        VERSION_8192S_ACUT,
+        VERSION_8192S_BCUT,
+        VERSION_8192S_CCUT
+};
+enum swchnlcmd_id {
+        CMDID_END,
+        CMDID_SET_TXPOWEROWER_LEVEL,
+        CMDID_BBREGWRITE10,
+        CMDID_WRITEPORT_ULONG,
+        CMDID_WRITEPORT_USHORT,
+        CMDID_WRITEPORT_UCHAR,
+        CMDID_RF_WRITEREG,
+};
+struct swchnlcmd {
+        enum swchnlcmd_id cmdid;
+        u32 para1;
+        u32 para2;
+        u32 msdelay;
+};
+enum baseband_config_type {
+        /* Radio Path A */
+        BASEBAND_CONFIG_PHY_REG = 0,
+        /* Radio Path B */
+        BASEBAND_CONFIG_AGC_TAB = 1,
+};
+#define hal_get_firmwareversion(rtlpriv) \
+        (((struct rt_firmware *)(rtlpriv->rtlhal.pfirmware))->firmwareversion)
+u32 rtl92s_phy_query_bb_reg(struct ieee80211_hw *hw, u32 regaddr, u32 bitmask);
+void rtl92s_phy_set_bb_reg(struct ieee80211_hw *hw, u32 regaddr, u32 bitmask,
+                           u32 data);
+void rtl92s_phy_scan_operation_backup(struct ieee80211_hw *hw, u8 operation);
+u32 rtl92s_phy_query_rf_reg(struct ieee80211_hw *hw, enum radio_path rfpath,
+                            u32 regaddr, u32 bitmask);
+void rtl92s_phy_set_rf_reg(struct ieee80211_hw *hw,     enum radio_path rfpath,
+                           u32 regaddr, u32 bitmask, u32 data);
+void rtl92s_phy_set_bw_mode(struct ieee80211_hw *hw,
+                            enum nl80211_channel_type ch_type);
+u8 rtl92s_phy_sw_chnl(struct ieee80211_hw *hw);
+bool rtl92s_phy_set_rf_power_state(struct ieee80211_hw *hw,
+                                   enum rf_pwrstate rfpower_state);
+bool rtl92s_phy_mac_config(struct ieee80211_hw *hw);
+void rtl92s_phy_switch_ephy_parameter(struct ieee80211_hw *hw);
+bool rtl92s_phy_bb_config(struct ieee80211_hw *hw);
+bool rtl92s_phy_rf_config(struct ieee80211_hw *hw);
+void rtl92s_phy_get_hw_reg_originalvalue(struct ieee80211_hw *hw);
+void rtl92s_phy_set_txpower(struct ieee80211_hw *hw, u8 channel);
+bool rtl92s_phy_set_fw_cmd(struct ieee80211_hw *hw, enum fwcmd_iotype fwcmd_io);
+void rtl92s_phy_chk_fwcmd_iodone(struct ieee80211_hw *hw);
+void rtl92s_phy_set_beacon_hwreg(struct ieee80211_hw *hw, u16 beaconinterval);
+u8 rtl92s_phy_config_rf(struct ieee80211_hw *hw, enum radio_path rfpath) ;
+#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/reg.h b/drivers/net/wireless/rtlwifi/rtl8192se/reg.h
new file mode 100644
index 000000000000..0116eaddbfac
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/reg.h
@@ -0,0 +1,1188 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#ifndef __REALTEK_92S_REG_H__
+#define __REALTEK_92S_REG_H__
+/* 1. System Configuration Registers  */
+#define REG_SYS_ISO_CTRL                        0x0000
+#define REG_SYS_FUNC_EN                         0x0002
+#define PMC_FSM                                 0x0004
+#define SYS_CLKR                                0x0008
+#define EPROM_CMD                               0x000A
+#define EE_VPD                                  0x000C
+#define AFE_MISC                                0x0010
+#define SPS0_CTRL                               0x0011
+#define SPS1_CTRL                               0x0018
+#define RF_CTRL                                 0x001F
+#define LDOA15_CTRL                             0x0020
+#define LDOV12D_CTRL                            0x0021
+#define LDOHCI12_CTRL                           0x0022
+#define LDO_USB_SDIO                            0x0023
+#define LPLDO_CTRL                              0x0024
+#define AFE_XTAL_CTRL                           0x0026
+#define AFE_PLL_CTRL                            0x0028
+#define REG_EFUSE_CTRL                          0x0030
+#define REG_EFUSE_TEST                          0x0034
+#define PWR_DATA                                0x0038
+#define DBG_PORT                                0x003A
+#define DPS_TIMER                               0x003C
+#define RCLK_MON                                0x003E
+/* 2. Command Control Registers   */
+#define CMDR                                    0x0040
+#define TXPAUSE                                 0x0042
+#define LBKMD_SEL                               0x0043
+#define TCR                                     0x0044
+#define RCR                                     0x0048
+#define MSR                                     0x004C
+#define SYSF_CFG                                0x004D
+#define RX_PKY_LIMIT                            0x004E
+#define MBIDCTRL                                0x004F
+/* 3. MACID Setting Registers    */
+#define MACIDR                                  0x0050
+#define MACIDR0                                 0x0050
+#define MACIDR4                                 0x0054
+#define BSSIDR                                  0x0058
+#define HWVID                                   0x005E
+#define MAR                                     0x0060
+#define MBIDCAMCONTENT                          0x0068
+#define MBIDCAMCFG                              0x0070
+#define BUILDTIME                               0x0074
+#define BUILDUSER                               0x0078
+#define IDR0                                    MACIDR0
+#define IDR4                                    MACIDR4
+/* 4. Timing Control Registers   */
+#define TSFR                                    0x0080
+#define SLOT_TIME                               0x0089
+#define USTIME                                  0x008A
+#define SIFS_CCK                                0x008C
+#define SIFS_OFDM                               0x008E
+#define PIFS_TIME                               0x0090
+#define ACK_TIMEOUT                             0x0091
+#define EIFSTR                                  0x0092
+#define BCN_INTERVAL                            0x0094
+#define ATIMWND                                 0x0096
+#define BCN_DRV_EARLY_INT                       0x0098
+#define BCN_DMATIME                             0x009A
+#define BCN_ERR_THRESH                          0x009C
+#define MLT                                     0x009D
+#define RSVD_MAC_TUNE_US                        0x009E
+/* 5. FIFO Control Registers      */
+#define RQPN                                    0x00A0
+#define RQPN1                                   0x00A0
+#define RQPN2                                   0x00A1
+#define RQPN3                                   0x00A2
+#define RQPN4                                   0x00A3
+#define RQPN5                                   0x00A4
+#define RQPN6                                   0x00A5
+#define RQPN7                                   0x00A6
+#define RQPN8                                   0x00A7
+#define RQPN9                                   0x00A8
+#define RQPN10                                  0x00A9
+#define LD_RQPN                                 0x00AB
+#define RXFF_BNDY                               0x00AC
+#define RXRPT_BNDY                              0x00B0
+#define TXPKTBUF_PGBNDY                         0x00B4
+#define PBP                                     0x00B5
+#define RXDRVINFO_SZ                            0x00B6
+#define TXFF_STATUS                             0x00B7
+#define RXFF_STATUS                             0x00B8
+#define TXFF_EMPTY_TH                           0x00B9
+#define SDIO_RX_BLKSZ                           0x00BC
+#define RXDMA                                   0x00BD
+#define RXPKT_NUM                               0x00BE
+#define C2HCMD_UDT_SIZE                         0x00C0
+#define C2HCMD_UDT_ADDR                         0x00C2
+#define FIFOPAGE1                               0x00C4
+#define FIFOPAGE2                               0x00C8
+#define FIFOPAGE3                               0x00CC
+#define FIFOPAGE4                               0x00D0
+#define FIFOPAGE5                               0x00D4
+#define FW_RSVD_PG_CRTL                         0x00D8
+#define RXDMA_AGG_PG_TH                         0x00D9
+#define TXDESC_MSK                              0x00DC
+#define TXRPTFF_RDPTR                           0x00E0
+#define TXRPTFF_WTPTR                           0x00E4
+#define C2HFF_RDPTR                             0x00E8
+#define C2HFF_WTPTR                             0x00EC
+#define RXFF0_RDPTR                             0x00F0
+#define RXFF0_WTPTR                             0x00F4
+#define RXFF1_RDPTR                             0x00F8
+#define RXFF1_WTPTR                             0x00FC
+#define RXRPT0_RDPTR                            0x0100
+#define RXRPT0_WTPTR                            0x0104
+#define RXRPT1_RDPTR                            0x0108
+#define RXRPT1_WTPTR                            0x010C
+#define RX0_UDT_SIZE                            0x0110
+#define RX1PKTNUM                               0x0114
+#define RXFILTERMAP                             0x0116
+#define RXFILTERMAP_GP1                         0x0118
+#define RXFILTERMAP_GP2                         0x011A
+#define RXFILTERMAP_GP3                         0x011C
+#define BCNQ_CTRL                               0x0120
+#define MGTQ_CTRL                               0x0124
+#define HIQ_CTRL                                0x0128
+#define VOTID7_CTRL                             0x012c
+#define VOTID6_CTRL                             0x0130
+#define VITID5_CTRL                             0x0134
+#define VITID4_CTRL                             0x0138
+#define BETID3_CTRL                             0x013c
+#define BETID0_CTRL                             0x0140
+#define BKTID2_CTRL                             0x0144
+#define BKTID1_CTRL                             0x0148
+#define CMDQ_CTRL                               0x014c
+#define TXPKT_NUM_CTRL                          0x0150
+#define TXQ_PGADD                               0x0152
+#define TXFF_PG_NUM                             0x0154
+#define TRXDMA_STATUS                           0x0156
+/* 6. Adaptive Control Registers   */
+#define INIMCS_SEL                              0x0160
+#define TX_RATE_REG                             INIMCS_SEL
+#define INIRTSMCS_SEL                           0x0180
+#define RRSR                                    0x0181
+#define ARFR0                                   0x0184
+#define ARFR1                                   0x0188
+#define ARFR2                                   0x018C
+#define ARFR3                                   0x0190
+#define ARFR4                                   0x0194
+#define ARFR5                                   0x0198
+#define ARFR6                                   0x019C
+#define ARFR7                                   0x01A0
+#define AGGLEN_LMT_H                            0x01A7
+#define AGGLEN_LMT_L                            0x01A8
+#define DARFRC                                  0x01B0
+#define RARFRC                                  0x01B8
+#define MCS_TXAGC                               0x01C0
+#define CCK_TXAGC                               0x01C8
+/* 7. EDCA Setting Registers */
+#define EDCAPARA_VO                             0x01D0
+#define EDCAPARA_VI                             0x01D4
+#define EDCAPARA_BE                             0x01D8
+#define EDCAPARA_BK                             0x01DC
+#define BCNTCFG                                 0x01E0
+#define CWRR                                    0x01E2
+#define ACMAVG                                  0x01E4
+#define AcmHwCtrl                               0x01E7
+#define VO_ADMTM                                0x01E8
+#define VI_ADMTM                                0x01EC
+#define BE_ADMTM                                0x01F0
+#define RETRY_LIMIT                             0x01F4
+#define SG_RATE                                 0x01F6
+/* 8. WMAC, BA and CCX related Register. */
+#define NAV_CTRL                                0x0200
+#define BW_OPMODE                               0x0203
+#define BACAMCMD                                0x0204
+#define BACAMCONTENT                            0x0208
+/* the 0x2xx register WMAC definition */
+#define LBDLY                                   0x0210
+#define FWDLY                                   0x0211
+#define HWPC_RX_CTRL                            0x0218
+#define MQIR                                    0x0220
+#define MAIR                                    0x0222
+#define MSIR                                    0x0224
+#define CLM_RESULT                              0x0227
+#define NHM_RPI_CNT                             0x0228
+#define RXERR_RPT                               0x0230
+#define NAV_PROT_LEN                            0x0234
+#define CFEND_TH                                0x0236
+#define AMPDU_MIN_SPACE                         0x0237
+#define TXOP_STALL_CTRL                         0x0238
+/* 9. Security Control Registers */
+#define REG_RWCAM                               0x0240
+#define REG_WCAMI                               0x0244
+#define REG_RCAMO                               0x0248
+#define REG_CAMDBG                              0x024C
+#define REG_SECR                                0x0250
+/* 10. Power Save Control Registers */
+#define WOW_CTRL                                0x0260
+#define PSSTATUS                                0x0261
+#define PSSWITCH                                0x0262
+#define MIMOPS_WAIT_PERIOD                      0x0263
+#define LPNAV_CTRL                              0x0264
+#define WFM0                                    0x0270
+#define WFM1                                    0x0280
+#define WFM2                                    0x0290
+#define WFM3                                    0x02A0
+#define WFM4                                    0x02B0
+#define WFM5                                    0x02C0
+#define WFCRC                                   0x02D0
+#define FW_RPT_REG                              0x02c4
+/* 11. General Purpose Registers */
+#define PSTIME                                  0x02E0
+#define TIMER0                                  0x02E4
+#define TIMER1                                  0x02E8
+#define GPIO_CTRL                               0x02EC
+#define GPIO_IN                                 0x02EC
+#define GPIO_OUT                                0x02ED
+#define GPIO_IO_SEL                             0x02EE
+#define GPIO_MOD                                0x02EF
+#define GPIO_INTCTRL                            0x02F0
+#define MAC_PINMUX_CFG                          0x02F1
+#define LEDCFG                                  0x02F2
+#define PHY_REG                                 0x02F3
+#define PHY_REG_DATA                            0x02F4
+#define REG_EFUSE_CLK                           0x02F8
+/* 12. Host Interrupt Status Registers */
+#define INTA_MASK                               0x0300
+#define ISR                                     0x0308
+/* 13. Test Mode and Debug Control Registers */
+#define DBG_PORT_SWITCH                         0x003A
+#define BIST                                    0x0310
+#define DBS                                     0x0314
+#define CPUINST                                 0x0318
+#define CPUCAUSE                                0x031C
+#define LBUS_ERR_ADDR                           0x0320
+#define LBUS_ERR_CMD                            0x0324
+#define LBUS_ERR_DATA_L                         0x0328
+#define LBUS_ERR_DATA_H                         0x032C
+#define LX_EXCEPTION_ADDR                       0x0330
+#define WDG_CTRL                                0x0334
+#define INTMTU                                  0x0338
+#define INTM                                    0x033A
+#define FDLOCKTURN0                             0x033C
+#define FDLOCKTURN1                             0x033D
+#define TRXPKTBUF_DBG_DATA                      0x0340
+#define TRXPKTBUF_DBG_CTRL                      0x0348
+#define DPLL                                    0x034A
+#define CBUS_ERR_ADDR                           0x0350
+#define CBUS_ERR_CMD                            0x0354
+#define CBUS_ERR_DATA_L                         0x0358
+#define CBUS_ERR_DATA_H                         0x035C
+#define USB_SIE_INTF_ADDR                       0x0360
+#define USB_SIE_INTF_WD                         0x0361
+#define USB_SIE_INTF_RD                         0x0362
+#define USB_SIE_INTF_CTRL                       0x0363
+#define LBUS_MON_ADDR                           0x0364
+#define LBUS_ADDR_MASK                          0x0368
+/* Boundary is 0x37F */
+/* 14. PCIE config register */
+#define TP_POLL                                 0x0500
+#define PM_CTRL                                 0x0502
+#define PCIF                                    0x0503
+#define THPDA                                   0x0514
+#define TMDA                                    0x0518
+#define TCDA                                    0x051C
+#define HDA                                     0x0520
+#define TVODA                                   0x0524
+#define TVIDA                                   0x0528
+#define TBEDA                                   0x052C
+#define TBKDA                                   0x0530
+#define TBDA                                    0x0534
+#define RCDA                                    0x0538
+#define RDQDA                                   0x053C
+#define DBI_WDATA                               0x0540
+#define DBI_RDATA                               0x0544
+#define DBI_CTRL                                0x0548
+#define MDIO_DATA                               0x0550
+#define MDIO_CTRL                               0x0554
+#define PCI_RPWM                                0x0561
+#define PCI_CPWM                                0x0563
+/* Config register      (Offset 0x800-) */
+#define PHY_CCA                                 0x803
+/* Min Spacing related settings. */
+#define MAX_MSS_DENSITY_2T                      0x13
+#define MAX_MSS_DENSITY_1T                      0x0A
+/* Rx DMA Control related settings */
+#define RXDMA_AGG_EN                            BIT(7)
+#define RPWM                                    PCI_RPWM
+/* Regsiter Bit and Content definition  */
+#define ISO_MD2PP                               BIT(0)
+#define ISO_PA2PCIE                             BIT(3)
+#define ISO_PLL2MD                              BIT(4)
+#define ISO_PWC_DV2RP                           BIT(11)
+#define ISO_PWC_RV2RP                           BIT(12)
+#define FEN_MREGEN                              BIT(15)
+#define FEN_DCORE                               BIT(11)
+#define FEN_CPUEN                               BIT(10)
+#define PAD_HWPD_IDN                            BIT(22)
+#define SYS_CLKSEL_80M                          BIT(0)
+#define SYS_PS_CLKSEL                           BIT(1)
+#define SYS_CPU_CLKSEL                          BIT(2)
+#define SYS_MAC_CLK_EN                          BIT(11)
+#define SYS_SWHW_SEL                            BIT(14)
+#define SYS_FWHW_SEL                            BIT(15)
+#define CmdEEPROM_En                            BIT(5)
+#define CmdEERPOMSEL                            BIT(4)
+#define Cmd9346CR_9356SEL                       BIT(4)
+#define AFE_MBEN                                BIT(1)
+#define AFE_BGEN                                BIT(0)
+#define SPS1_SWEN                               BIT(1)
+#define SPS1_LDEN                               BIT(0)
+#define RF_EN                                   BIT(0)
+#define RF_RSTB                                 BIT(1)
+#define RF_SDMRSTB                              BIT(2)
+#define LDA15_EN                                BIT(0)
+#define LDV12_EN                                BIT(0)
+#define LDV12_SDBY                              BIT(1)
+#define XTAL_GATE_AFE                           BIT(10)
+#define APLL_EN                                 BIT(0)
+#define AFR_CardBEn                             BIT(0)
+#define AFR_CLKRUN_SEL                          BIT(1)
+#define AFR_FuncRegEn                           BIT(2)
+#define APSDOFF_STATUS                          BIT(15)
+#define APSDOFF                                 BIT(14)
+#define BBRSTN                                  BIT(13)
+#define BB_GLB_RSTN                             BIT(12)
+#define SCHEDULE_EN                             BIT(10)
+#define MACRXEN                                 BIT(9)
+#define MACTXEN                                 BIT(8)
+#define DDMA_EN                                 BIT(7)
+#define FW2HW_EN                                BIT(6)
+#define RXDMA_EN                                BIT(5)
+#define TXDMA_EN                                BIT(4)
+#define HCI_RXDMA_EN                            BIT(3)
+#define HCI_TXDMA_EN                            BIT(2)
+#define StopHCCA                                BIT(6)
+#define StopHigh                                BIT(5)
+#define StopMgt                                 BIT(4)
+#define StopVO                                  BIT(3)
+#define StopVI                                  BIT(2)
+#define StopBE                                  BIT(1)
+#define StopBK                                  BIT(0)
+#define LBK_NORMAL                              0x00
+#define LBK_MAC_LB                              (BIT(0) | BIT(1) | BIT(3))
+#define LBK_MAC_DLB                             (BIT(0) | BIT(1))
+#define LBK_DMA_LB                              (BIT(0) | BIT(1) | BIT(2))
+#define TCP_OFDL_EN                             BIT(25)
+#define HWPC_TX_EN                              BIT(24)
+#define TXDMAPRE2FULL                           BIT(23)
+#define DISCW                                   BIT(20)
+#define TCRICV                                  BIT(19)
+#define CfendForm                               BIT(17)
+#define TCRCRC                                  BIT(16)
+#define FAKE_IMEM_EN                            BIT(15)
+#define TSFRST                                  BIT(9)
+#define TSFEN                                   BIT(8)
+#define FWALLRDY                                (BIT(0) | BIT(1) | BIT(2) | \
+                                                BIT(3) | BIT(4) | BIT(5) | \
+                                                BIT(6) | BIT(7))
+#define FWRDY                                   BIT(7)
+#define BASECHG                                 BIT(6)
+#define IMEM                                    BIT(5)
+#define DMEM_CODE_DONE                          BIT(4)
+#define EXT_IMEM_CHK_RPT                        BIT(3)
+#define EXT_IMEM_CODE_DONE                      BIT(2)
+#define IMEM_CHK_RPT                            BIT(1)
+#define IMEM_CODE_DONE                          BIT(0)
+#define IMEM_CODE_DONE                          BIT(0)
+#define IMEM_CHK_RPT                            BIT(1)
+#define EMEM_CODE_DONE                          BIT(2)
+#define EMEM_CHK_RPT                            BIT(3)
+#define DMEM_CODE_DONE                          BIT(4)
+#define IMEM_RDY                                BIT(5)
+#define BASECHG                                 BIT(6)
+#define FWRDY                                   BIT(7)
+#define LOAD_FW_READY                           (IMEM_CODE_DONE | \
+                                                IMEM_CHK_RPT | \
+                                                EMEM_CODE_DONE | \
+                                                EMEM_CHK_RPT | \
+                                                DMEM_CODE_DONE | \
+                                                IMEM_RDY | \
+                                                BASECHG | \
+                                                FWRDY)
+#define TCR_TSFEN                               BIT(8)
+#define TCR_TSFRST                              BIT(9)
+#define TCR_FAKE_IMEM_EN                        BIT(15)
+#define TCR_CRC                                 BIT(16)
+#define TCR_ICV                                 BIT(19)
+#define TCR_DISCW                               BIT(20)
+#define TCR_HWPC_TX_EN                          BIT(24)
+#define TCR_TCP_OFDL_EN                         BIT(25)
+#define TXDMA_INIT_VALUE                        (IMEM_CHK_RPT | \
+                                                EXT_IMEM_CHK_RPT)
+#define RCR_APPFCS                              BIT(31)
+#define RCR_DIS_ENC_2BYTE                       BIT(30)
+#define RCR_DIS_AES_2BYTE                       BIT(29)
+#define RCR_HTC_LOC_CTRL                        BIT(28)
+#define RCR_ENMBID                              BIT(27)
+#define RCR_RX_TCPOFDL_EN                       BIT(26)
+#define RCR_APP_PHYST_RXFF                      BIT(25)
+#define RCR_APP_PHYST_STAFF                     BIT(24)
+#define RCR_CBSSID                              BIT(23)
+#define RCR_APWRMGT                             BIT(22)
+#define RCR_ADD3                                BIT(21)
+#define RCR_AMF                                 BIT(20)
+#define RCR_ACF                                 BIT(19)
+#define RCR_ADF                                 BIT(18)
+#define RCR_APP_MIC                             BIT(17)
+#define RCR_APP_ICV                             BIT(16)
+#define RCR_RXFTH                               BIT(13)
+#define RCR_AICV                                BIT(12)
+#define RCR_RXDESC_LK_EN                        BIT(11)
+#define RCR_APP_BA_SSN                          BIT(6)
+#define RCR_ACRC32                              BIT(5)
+#define RCR_RXSHFT_EN                           BIT(4)
+#define RCR_AB                                  BIT(3)
+#define RCR_AM                                  BIT(2)
+#define RCR_APM                                 BIT(1)
+#define RCR_AAP                                 BIT(0)
+#define RCR_MXDMA_OFFSET                        8
+#define RCR_FIFO_OFFSET                         13
+#define MSR_LINK_MASK                           ((1 << 0) | (1 << 1))
+#define MSR_LINK_MANAGED                        2
+#define MSR_LINK_NONE                           0
+#define MSR_LINK_SHIFT                          0
+#define MSR_LINK_ADHOC                          1
+#define MSR_LINK_MASTER                         3
+#define MSR_NOLINK                              0x00
+#define MSR_ADHOC                               0x01
+#define MSR_INFRA                               0x02
+#define MSR_AP                                  0x03
+#define ENUART                                  BIT(7)
+#define ENJTAG                                  BIT(3)
+#define BTMODE                                  (BIT(2) | BIT(1))
+#define ENBT                                    BIT(0)
+#define ENMBID                                  BIT(7)
+#define BCNUM                                   (BIT(6) | BIT(5) | BIT(4))
+#define USTIME_EDCA                             0xFF00
+#define USTIME_TSF                              0x00FF
+#define SIFS_TRX                                0xFF00
+#define SIFS_CTX                                0x00FF
+#define ENSWBCN                                 BIT(15)
+#define DRVERLY_TU                              0x0FF0
+#define DRVERLY_US                              0x000F
+#define BCN_TCFG_CW_SHIFT                       8
+#define BCN_TCFG_IFS                            0
+#define RRSR_RSC_OFFSET                         21
+#define RRSR_SHORT_OFFSET                       23
+#define RRSR_RSC_BW_40M                         0x600000
+#define RRSR_RSC_UPSUBCHNL                      0x400000
+#define RRSR_RSC_LOWSUBCHNL                     0x200000
+#define RRSR_SHORT                              0x800000
+#define RRSR_1M                                 BIT(0)
+#define RRSR_2M                                 BIT(1)
+#define RRSR_5_5M                               BIT(2)
+#define RRSR_11M                                BIT(3)
+#define RRSR_6M                                 BIT(4)
+#define RRSR_9M                                 BIT(5)
+#define RRSR_12M                                BIT(6)
+#define RRSR_18M                                BIT(7)
+#define RRSR_24M                                BIT(8)
+#define RRSR_36M                                BIT(9)
+#define RRSR_48M                                BIT(10)
+#define RRSR_54M                                BIT(11)
+#define RRSR_MCS0                               BIT(12)
+#define RRSR_MCS1                               BIT(13)
+#define RRSR_MCS2                               BIT(14)
+#define RRSR_MCS3                               BIT(15)
+#define RRSR_MCS4                               BIT(16)
+#define RRSR_MCS5                               BIT(17)
+#define RRSR_MCS6                               BIT(18)
+#define RRSR_MCS7                               BIT(19)
+#define BRSR_AckShortPmb                        BIT(23)
+#define RATR_1M                                 0x00000001
+#define RATR_2M                                 0x00000002
+#define RATR_55M                                0x00000004
+#define RATR_11M                                0x00000008
+#define RATR_6M                                 0x00000010
+#define RATR_9M                                 0x00000020
+#define RATR_12M                                0x00000040
+#define RATR_18M                                0x00000080
+#define RATR_24M                                0x00000100
+#define RATR_36M                                0x00000200
+#define RATR_48M                                0x00000400
+#define RATR_54M                                0x00000800
+#define RATR_MCS0                               0x00001000
+#define RATR_MCS1                               0x00002000
+#define RATR_MCS2                               0x00004000
+#define RATR_MCS3                               0x00008000
+#define RATR_MCS4                               0x00010000
+#define RATR_MCS5                               0x00020000
+#define RATR_MCS6                               0x00040000
+#define RATR_MCS7                               0x00080000
+#define RATR_MCS8                               0x00100000
+#define RATR_MCS9                               0x00200000
+#define RATR_MCS10                              0x00400000
+#define RATR_MCS11                              0x00800000
+#define RATR_MCS12                              0x01000000
+#define RATR_MCS13                              0x02000000
+#define RATR_MCS14                              0x04000000
+#define RATR_MCS15                              0x08000000
+#define RATE_ALL_CCK                            (RATR_1M | RATR_2M | \
+                                                RATR_55M | RATR_11M)
+#define RATE_ALL_OFDM_AG                        (RATR_6M | RATR_9M | \
+                                                RATR_12M | RATR_18M | \
+                                                RATR_24M | RATR_36M | \
+                                                RATR_48M | RATR_54M)
+#define RATE_ALL_OFDM_1SS                       (RATR_MCS0 | RATR_MCS1 | \
+                                                RATR_MCS2 | RATR_MCS3 | \
+                                                RATR_MCS4 | RATR_MCS5 | \
+                                                RATR_MCS6 | RATR_MCS7)
+#define RATE_ALL_OFDM_2SS                       (RATR_MCS8 | RATR_MCS9 | \
+                                                RATR_MCS10 | RATR_MCS11 | \
+                                                RATR_MCS12 | RATR_MCS13 | \
+                                                RATR_MCS14 | RATR_MCS15)
+#define AC_PARAM_TXOP_LIMIT_OFFSET              16
+#define AC_PARAM_ECW_MAX_OFFSET                 12
+#define AC_PARAM_ECW_MIN_OFFSET                 8
+#define AC_PARAM_AIFS_OFFSET                    0
+#define AcmHw_HwEn                              BIT(0)
+#define AcmHw_BeqEn                             BIT(1)
+#define AcmHw_ViqEn                             BIT(2)
+#define AcmHw_VoqEn                             BIT(3)
+#define AcmHw_BeqStatus                         BIT(4)
+#define AcmHw_ViqStatus                         BIT(5)
+#define AcmHw_VoqStatus                         BIT(6)
+#define RETRY_LIMIT_SHORT_SHIFT                 8
+#define RETRY_LIMIT_LONG_SHIFT                  0
+#define NAV_UPPER_EN                            BIT(16)
+#define NAV_UPPER                               0xFF00
+#define NAV_RTSRST                              0xFF
+#define BW_OPMODE_20MHZ                         BIT(2)
+#define BW_OPMODE_5G                            BIT(1)
+#define BW_OPMODE_11J                           BIT(0)
+#define RXERR_RPT_RST                           BIT(27)
+#define RXERR_OFDM_PPDU                         0
+#define RXERR_OFDM_FALSE_ALARM                  1
+#define RXERR_OFDM_MPDU_OK                      2
+#define RXERR_OFDM_MPDU_FAIL                    3
+#define RXERR_CCK_PPDU                          4
+#define RXERR_CCK_FALSE_ALARM                   5
+#define RXERR_CCK_MPDU_OK                       6
+#define RXERR_CCK_MPDU_FAIL                     7
+#define RXERR_HT_PPDU                           8
+#define RXERR_HT_FALSE_ALARM                    9
+#define RXERR_HT_MPDU_TOTAL                     10
+#define RXERR_HT_MPDU_OK                        11
+#define RXERR_HT_MPDU_FAIL                      12
+#define RXERR_RX_FULL_DROP                      15
+#define SCR_TXUSEDK                             BIT(0)
+#define SCR_RXUSEDK                             BIT(1)
+#define SCR_TXENCENABLE                         BIT(2)
+#define SCR_RXENCENABLE                         BIT(3)
+#define SCR_SKBYA2                              BIT(4)
+#define SCR_NOSKMC                              BIT(5)
+#define CAM_VALID                               BIT(15)
+#define CAM_NOTVALID                            0x0000
+#define CAM_USEDK                               BIT(5)
+#define CAM_NONE                                0x0
+#define CAM_WEP40                               0x01
+#define CAM_TKIP                                0x02
+#define CAM_AES                                 0x04
+#define CAM_WEP104                              0x05
+#define TOTAL_CAM_ENTRY                         32
+#define HALF_CAM_ENTRY                          16
+#define CAM_WRITE                               BIT(16)
+#define CAM_READ                                0x00000000
+#define CAM_POLLINIG                            BIT(31)
+#define WOW_PMEN                                BIT(0)
+#define WOW_WOMEN                               BIT(1)
+#define WOW_MAGIC                               BIT(2)
+#define WOW_UWF                                 BIT(3)
+#define GPIOMUX_EN                              BIT(3)
+#define GPIOSEL_GPIO                            0
+#define GPIOSEL_PHYDBG                          1
+#define GPIOSEL_BT                              2
+#define GPIOSEL_WLANDBG                         3
+#define GPIOSEL_GPIO_MASK                       (~(BIT(0)|BIT(1)))
+#define HST_RDBUSY                              BIT(0)
+#define CPU_WTBUSY                              BIT(1)
+#define IMR8190_DISABLED                        0x0
+#define IMR_CPUERR                              BIT(5)
+#define IMR_ATIMEND                             BIT(4)
+#define IMR_TBDOK                               BIT(3)
+#define IMR_TBDER                               BIT(2)
+#define IMR_BCNDMAINT8                          BIT(1)
+#define IMR_BCNDMAINT7                          BIT(0)
+#define IMR_BCNDMAINT6                          BIT(31)
+#define IMR_BCNDMAINT5                          BIT(30)
+#define IMR_BCNDMAINT4                          BIT(29)
+#define IMR_BCNDMAINT3                          BIT(28)
+#define IMR_BCNDMAINT2                          BIT(27)
+#define IMR_BCNDMAINT1                          BIT(26)
+#define IMR_BCNDOK8                             BIT(25)
+#define IMR_BCNDOK7                             BIT(24)
+#define IMR_BCNDOK6                             BIT(23)
+#define IMR_BCNDOK5                             BIT(22)
+#define IMR_BCNDOK4                             BIT(21)
+#define IMR_BCNDOK3                             BIT(20)
+#define IMR_BCNDOK2                             BIT(19)
+#define IMR_BCNDOK1                             BIT(18)
+#define IMR_TIMEOUT2                            BIT(17)
+#define IMR_TIMEOUT1                            BIT(16)
+#define IMR_TXFOVW                              BIT(15)
+#define IMR_PSTIMEOUT                           BIT(14)
+#define IMR_BCNINT                              BIT(13)
+#define IMR_RXFOVW                              BIT(12)
+#define IMR_RDU                                 BIT(11)
+#define IMR_RXCMDOK                             BIT(10)
+#define IMR_BDOK                                BIT(9)
+#define IMR_HIGHDOK                             BIT(8)
+#define IMR_COMDOK                              BIT(7)
+#define IMR_MGNTDOK                             BIT(6)
+#define IMR_HCCADOK                             BIT(5)
+#define IMR_BKDOK                               BIT(4)
+#define IMR_BEDOK                               BIT(3)
+#define IMR_VIDOK                               BIT(2)
+#define IMR_VODOK                               BIT(1)
+#define IMR_ROK                                 BIT(0)
+#define TPPOLL_BKQ                              BIT(0)
+#define TPPOLL_BEQ                              BIT(1)
+#define TPPOLL_VIQ                              BIT(2)
+#define TPPOLL_VOQ                              BIT(3)
+#define TPPOLL_BQ                               BIT(4)
+#define TPPOLL_CQ                               BIT(5)
+#define TPPOLL_MQ                               BIT(6)
+#define TPPOLL_HQ                               BIT(7)
+#define TPPOLL_HCCAQ                            BIT(8)
+#define TPPOLL_STOPBK                           BIT(9)
+#define TPPOLL_STOPBE                           BIT(10)
+#define TPPOLL_STOPVI                           BIT(11)
+#define TPPOLL_STOPVO                           BIT(12)
+#define TPPOLL_STOPMGT                          BIT(13)
+#define TPPOLL_STOPHIGH                         BIT(14)
+#define TPPOLL_STOPHCCA                         BIT(15)
+#define TPPOLL_SHIFT                            8
+#define CCX_CMD_CLM_ENABLE                      BIT(0)
+#define CCX_CMD_NHM_ENABLE                      BIT(1)
+#define CCX_CMD_FUNCTION_ENABLE                 BIT(8)
+#define CCX_CMD_IGNORE_CCA                      BIT(9)
+#define CCX_CMD_IGNORE_TXON                     BIT(10)
+#define CCX_CLM_RESULT_READY                    BIT(16)
+#define CCX_NHM_RESULT_READY                    BIT(16)
+#define CCX_CMD_RESET                           0x0
+#define HWSET_MAX_SIZE_92S                      128
+#define EFUSE_MAX_SECTION                       16
+#define EFUSE_REAL_CONTENT_LEN                  512
+#define RTL8190_EEPROM_ID                       0x8129
+#define EEPROM_HPON                             0x02
+#define EEPROM_CLK                              0x06
+#define EEPROM_TESTR                            0x08
+#define EEPROM_VID                              0x0A
+#define EEPROM_DID                              0x0C
+#define EEPROM_SVID                             0x0E
+#define EEPROM_SMID                             0x10
+#define EEPROM_MAC_ADDR                         0x12
+#define EEPROM_NODE_ADDRESS_BYTE_0              0x12
+#define EEPROM_PWDIFF                           0x54
+#define EEPROM_TXPOWERBASE                      0x50
+#define EEPROM_TX_PWR_INDEX_RANGE               28
+#define EEPROM_TX_PWR_HT20_DIFF                 0x62
+#define DEFAULT_HT20_TXPWR_DIFF                 2
+#define EEPROM_TX_PWR_OFDM_DIFF                 0x65
+#define EEPROM_TXPWRGROUP                       0x67
+#define EEPROM_REGULATORY                       0x6D
+#define TX_PWR_SAFETY_CHK                       0x6D
+#define EEPROM_TXPWINDEX_CCK_24G                0x5D
+#define EEPROM_TXPWINDEX_OFDM_24G               0x6B
+#define EEPROM_HT2T_CH1_A                       0x6c
+#define EEPROM_HT2T_CH7_A                       0x6d
+#define EEPROM_HT2T_CH13_A                      0x6e
+#define EEPROM_HT2T_CH1_B                       0x6f
+#define EEPROM_HT2T_CH7_B                       0x70
+#define EEPROM_HT2T_CH13_B                      0x71
+#define EEPROM_TSSI_A                           0x74
+#define EEPROM_TSSI_B                           0x75
+#define EEPROM_RFIND_POWERDIFF                  0x76
+#define EEPROM_DEFAULT_LEGACYHTTXPOWERDIFF      0x3
+#define EEPROM_THERMALMETER                     0x77
+#define EEPROM_BLUETOOTH_COEXIST                0x78
+#define EEPROM_BLUETOOTH_TYPE                   0x4f
+#define EEPROM_OPTIONAL                         0x78
+#define EEPROM_WOWLAN                           0x78
+#define EEPROM_CRYSTALCAP                       0x79
+#define EEPROM_CHANNELPLAN                      0x7B
+#define EEPROM_VERSION                          0x7C
+#define EEPROM_CUSTOMID                         0x7A
+#define EEPROM_BOARDTYPE                        0x7E
+#define EEPROM_CHANNEL_PLAN_FCC                 0x0
+#define EEPROM_CHANNEL_PLAN_IC                  0x1
+#define EEPROM_CHANNEL_PLAN_ETSI                0x2
+#define EEPROM_CHANNEL_PLAN_SPAIN               0x3
+#define EEPROM_CHANNEL_PLAN_FRANCE              0x4
+#define EEPROM_CHANNEL_PLAN_MKK                 0x5
+#define EEPROM_CHANNEL_PLAN_MKK1                0x6
+#define EEPROM_CHANNEL_PLAN_ISRAEL              0x7
+#define EEPROM_CHANNEL_PLAN_TELEC               0x8
+#define EEPROM_CHANNEL_PLAN_GLOBAL_DOMAIN       0x9
+#define EEPROM_CHANNEL_PLAN_WORLD_WIDE_13       0xA
+#define EEPROM_CHANNEL_PLAN_NCC                 0xB
+#define EEPROM_CHANNEL_PLAN_BY_HW_MASK          0x80
+#define FW_DIG_DISABLE                          0xfd00cc00
+#define FW_DIG_ENABLE                           0xfd000000
+#define FW_DIG_HALT                             0xfd000001
+#define FW_DIG_RESUME                           0xfd000002
+#define FW_HIGH_PWR_DISABLE                     0xfd000008
+#define FW_HIGH_PWR_ENABLE                      0xfd000009
+#define FW_ADD_A2_ENTRY                         0xfd000016
+#define FW_TXPWR_TRACK_ENABLE                   0xfd000017
+#define FW_TXPWR_TRACK_DISABLE                  0xfd000018
+#define FW_TXPWR_TRACK_THERMAL                  0xfd000019
+#define FW_TXANT_SWITCH_ENABLE                  0xfd000023
+#define FW_TXANT_SWITCH_DISABLE                 0xfd000024
+#define FW_RA_INIT                              0xfd000026
+#define FW_CTRL_DM_BY_DRIVER                    0Xfd00002a
+#define FW_RA_IOT_BG_COMB                       0xfd000030
+#define FW_RA_IOT_N_COMB                        0xfd000031
+#define FW_RA_REFRESH                           0xfd0000a0
+#define FW_RA_UPDATE_MASK                       0xfd0000a2
+#define FW_RA_DISABLE                           0xfd0000a4
+#define FW_RA_ACTIVE                            0xfd0000a6
+#define FW_RA_DISABLE_RSSI_MASK                 0xfd0000ac
+#define FW_RA_ENABLE_RSSI_MASK                  0xfd0000ad
+#define FW_RA_RESET                             0xfd0000af
+#define FW_DM_DISABLE                           0xfd00aa00
+#define FW_IQK_ENABLE                           0xf0000020
+#define FW_IQK_SUCCESS                          0x0000dddd
+#define FW_IQK_FAIL                             0x0000ffff
+#define FW_OP_FAILURE                           0xffffffff
+#define FW_TX_FEEDBACK_NONE                     0xfb000000
+#define FW_TX_FEEDBACK_DTM_ENABLE               (FW_TX_FEEDBACK_NONE | 0x1)
+#define FW_TX_FEEDBACK_CCX_ENABL                (FW_TX_FEEDBACK_NONE | 0x2)
+#define FW_BB_RESET_ENABLE                      0xff00000d
+#define FW_BB_RESET_DISABLE                     0xff00000e
+#define FW_CCA_CHK_ENABLE                       0xff000011
+#define FW_CCK_RESET_CNT                        0xff000013
+#define FW_LPS_ENTER                            0xfe000010
+#define FW_LPS_LEAVE                            0xfe000011
+#define FW_INDIRECT_READ                        0xf2000000
+#define FW_INDIRECT_WRITE                       0xf2000001
+#define FW_CHAN_SET                             0xf3000001
+#define RFPC                                    0x5F
+#define RCR_9356SEL                             BIT(6)
+#define TCR_LRL_OFFSET                          0
+#define TCR_SRL_OFFSET                          8
+#define TCR_MXDMA_OFFSET                        21
+#define TCR_SAT                                 BIT(24)
+#define RCR_MXDMA_OFFSET                        8
+#define RCR_FIFO_OFFSET                         13
+#define RCR_OnlyErlPkt                          BIT(31)
+#define CWR                                     0xDC
+#define RETRYCTR                                0xDE
+#define CPU_GEN_SYSTEM_RESET                    0x00000001
+#define CCX_COMMAND_REG                         0x890
+#define CLM_PERIOD_REG                          0x894
+#define NHM_PERIOD_REG                          0x896
+#define NHM_THRESHOLD0                          0x898
+#define NHM_THRESHOLD1                          0x899
+#define NHM_THRESHOLD2                          0x89A
+#define NHM_THRESHOLD3                          0x89B
+#define NHM_THRESHOLD4                          0x89C
+#define NHM_THRESHOLD5                          0x89D
+#define NHM_THRESHOLD6                          0x89E
+#define CLM_RESULT_REG                          0x8D0
+#define NHM_RESULT_REG                          0x8D4
+#define NHM_RPI_COUNTER0                        0x8D8
+#define NHM_RPI_COUNTER1                        0x8D9
+#define NHM_RPI_COUNTER2                        0x8DA
+#define NHM_RPI_COUNTER3                        0x8DB
+#define NHM_RPI_COUNTER4                        0x8DC
+#define NHM_RPI_COUNTER5                        0x8DD
+#define NHM_RPI_COUNTER6                        0x8DE
+#define NHM_RPI_COUNTER7                        0x8DF
+#define HAL_8192S_HW_GPIO_OFF_BIT               BIT(3)
+#define HAL_8192S_HW_GPIO_OFF_MASK              0xF7
+#define HAL_8192S_HW_GPIO_WPS_BIT               BIT(4)
+#define RPMAC_RESET                             0x100
+#define RPMAC_TXSTART                           0x104
+#define RPMAC_TXLEGACYSIG                       0x108
+#define RPMAC_TXHTSIG1                          0x10c
+#define RPMAC_TXHTSIG2                          0x110
+#define RPMAC_PHYDEBUG                          0x114
+#define RPMAC_TXPACKETNNM                       0x118
+#define RPMAC_TXIDLE                            0x11c
+#define RPMAC_TXMACHEADER0                      0x120
+#define RPMAC_TXMACHEADER1                      0x124
+#define RPMAC_TXMACHEADER2                      0x128
+#define RPMAC_TXMACHEADER3                      0x12c
+#define RPMAC_TXMACHEADER4                      0x130
+#define RPMAC_TXMACHEADER5                      0x134
+#define RPMAC_TXDATATYPE                        0x138
+#define RPMAC_TXRANDOMSEED                      0x13c
+#define RPMAC_CCKPLCPPREAMBLE                   0x140
+#define RPMAC_CCKPLCPHEADER                     0x144
+#define RPMAC_CCKCRC16                          0x148
+#define RPMAC_OFDMRXCRC32OK                     0x170
+#define RPMAC_OFDMRXCRC32ER                     0x174
+#define RPMAC_OFDMRXPARITYER                    0x178
+#define RPMAC_OFDMRXCRC8ER                      0x17c
+#define RPMAC_CCKCRXRC16ER                      0x180
+#define RPMAC_CCKCRXRC32ER                      0x184
+#define RPMAC_CCKCRXRC32OK                      0x188
+#define RPMAC_TXSTATUS                          0x18c
+#define RF_BB_CMD_ADDR                          0x02c0
+#define RF_BB_CMD_DATA                          0x02c4
+#define RFPGA0_RFMOD                            0x800
+#define RFPGA0_TXINFO                           0x804
+#define RFPGA0_PSDFUNCTION                      0x808
+#define RFPGA0_TXGAINSTAGE                      0x80c
+#define RFPGA0_RFTIMING1                        0x810
+#define RFPGA0_RFTIMING2                        0x814
+#define RFPGA0_XA_HSSIPARAMETER1                0x820
+#define RFPGA0_XA_HSSIPARAMETER2                0x824
+#define RFPGA0_XB_HSSIPARAMETER1                0x828
+#define RFPGA0_XB_HSSIPARAMETER2                0x82c
+#define RFPGA0_XC_HSSIPARAMETER1                0x830
+#define RFPGA0_XC_HSSIPARAMETER2                0x834
+#define RFPGA0_XD_HSSIPARAMETER1                0x838
+#define RFPGA0_XD_HSSIPARAMETER2                0x83c
+#define RFPGA0_XA_LSSIPARAMETER                 0x840
+#define RFPGA0_XB_LSSIPARAMETER                 0x844
+#define RFPGA0_XC_LSSIPARAMETER                 0x848
+#define RFPGA0_XD_LSSIPARAMETER                 0x84c
+#define RFPGA0_RFWAKEUP_PARAMETER               0x850
+#define RFPGA0_RFSLEEPUP_PARAMETER              0x854
+#define RFPGA0_XAB_SWITCHCONTROL                0x858
+#define RFPGA0_XCD_SWITCHCONTROL                0x85c
+#define RFPGA0_XA_RFINTERFACEOE                 0x860
+#define RFPGA0_XB_RFINTERFACEOE                 0x864
+#define RFPGA0_XC_RFINTERFACEOE                 0x868
+#define RFPGA0_XD_RFINTERFACEOE                 0x86c
+#define RFPGA0_XAB_RFINTERFACESW                0x870
+#define RFPGA0_XCD_RFINTERFACESW                0x874
+#define RFPGA0_XAB_RFPARAMETER                  0x878
+#define RFPGA0_XCD_RFPARAMETER                  0x87c
+#define RFPGA0_ANALOGPARAMETER1                 0x880
+#define RFPGA0_ANALOGPARAMETER2                 0x884
+#define RFPGA0_ANALOGPARAMETER3                 0x888
+#define RFPGA0_ANALOGPARAMETER4                 0x88c
+#define RFPGA0_XA_LSSIREADBACK                  0x8a0
+#define RFPGA0_XB_LSSIREADBACK                  0x8a4
+#define RFPGA0_XC_LSSIREADBACK                  0x8a8
+#define RFPGA0_XD_LSSIREADBACK                  0x8ac
+#define RFPGA0_PSDREPORT                        0x8b4
+#define TRANSCEIVERA_HSPI_READBACK              0x8b8
+#define TRANSCEIVERB_HSPI_READBACK              0x8bc
+#define RFPGA0_XAB_RFINTERFACERB                0x8e0
+#define RFPGA0_XCD_RFINTERFACERB                0x8e4
+#define RFPGA1_RFMOD                            0x900
+#define RFPGA1_TXBLOCK                          0x904
+#define RFPGA1_DEBUGSELECT                      0x908
+#define RFPGA1_TXINFO                           0x90c
+#define RCCK0_SYSTEM                            0xa00
+#define RCCK0_AFESETTING                        0xa04
+#define RCCK0_CCA                               0xa08
+#define RCCK0_RXAGC1                            0xa0c
+#define RCCK0_RXAGC2                            0xa10
+#define RCCK0_RXHP                              0xa14
+#define RCCK0_DSPPARAMETER1                     0xa18
+#define RCCK0_DSPPARAMETER2                     0xa1c
+#define RCCK0_TXFILTER1                         0xa20
+#define RCCK0_TXFILTER2                         0xa24
+#define RCCK0_DEBUGPORT                         0xa28
+#define RCCK0_FALSEALARMREPORT                  0xa2c
+#define RCCK0_TRSSIREPORT                       0xa50
+#define RCCK0_RXREPORT                          0xa54
+#define RCCK0_FACOUNTERLOWER                    0xa5c
+#define RCCK0_FACOUNTERUPPER                    0xa58
+#define ROFDM0_LSTF                             0xc00
+#define ROFDM0_TRXPATHENABLE                    0xc04
+#define ROFDM0_TRMUXPAR                         0xc08
+#define ROFDM0_TRSWISOLATION                    0xc0c
+#define ROFDM0_XARXAFE                          0xc10
+#define ROFDM0_XARXIQIMBALANCE                  0xc14
+#define ROFDM0_XBRXAFE                          0xc18
+#define ROFDM0_XBRXIQIMBALANCE                  0xc1c
+#define ROFDM0_XCRXAFE                          0xc20
+#define ROFDM0_XCRXIQIMBALANCE                  0xc24
+#define ROFDM0_XDRXAFE                          0xc28
+#define ROFDM0_XDRXIQIMBALANCE                  0xc2c
+#define ROFDM0_RXDETECTOR1                      0xc30
+#define ROFDM0_RXDETECTOR2                      0xc34
+#define ROFDM0_RXDETECTOR3                      0xc38
+#define ROFDM0_RXDETECTOR4                      0xc3c
+#define ROFDM0_RXDSP                            0xc40
+#define ROFDM0_CFO_AND_DAGC                     0xc44
+#define ROFDM0_CCADROP_THRESHOLD                0xc48
+#define ROFDM0_ECCA_THRESHOLD                   0xc4c
+#define ROFDM0_XAAGCCORE1                       0xc50
+#define ROFDM0_XAAGCCORE2                       0xc54
+#define ROFDM0_XBAGCCORE1                       0xc58
+#define ROFDM0_XBAGCCORE2                       0xc5c
+#define ROFDM0_XCAGCCORE1                       0xc60
+#define ROFDM0_XCAGCCORE2                       0xc64
+#define ROFDM0_XDAGCCORE1                       0xc68
+#define ROFDM0_XDAGCCORE2                       0xc6c
+#define ROFDM0_AGCPARAMETER1                    0xc70
+#define ROFDM0_AGCPARAMETER2                    0xc74
+#define ROFDM0_AGCRSSITABLE                     0xc78
+#define ROFDM0_HTSTFAGC                         0xc7c
+#define ROFDM0_XATXIQIMBALANCE                  0xc80
+#define ROFDM0_XATXAFE                          0xc84
+#define ROFDM0_XBTXIQIMBALANCE                  0xc88
+#define ROFDM0_XBTXAFE                          0xc8c
+#define ROFDM0_XCTXIQIMBALANCE                  0xc90
+#define ROFDM0_XCTXAFE                          0xc94
+#define ROFDM0_XDTXIQIMBALANCE                  0xc98
+#define ROFDM0_XDTXAFE                          0xc9c
+#define ROFDM0_RXHP_PARAMETER                   0xce0
+#define ROFDM0_TXPSEUDO_NOISE_WGT               0xce4
+#define ROFDM0_FRAME_SYNC                       0xcf0
+#define ROFDM0_DFSREPORT                        0xcf4
+#define ROFDM0_TXCOEFF1                         0xca4
+#define ROFDM0_TXCOEFF2                         0xca8
+#define ROFDM0_TXCOEFF3                         0xcac
+#define ROFDM0_TXCOEFF4                         0xcb0
+#define ROFDM0_TXCOEFF5                         0xcb4
+#define ROFDM0_TXCOEFF6                         0xcb8
+#define ROFDM1_LSTF                             0xd00
+#define ROFDM1_TRXPATHENABLE                    0xd04
+#define ROFDM1_CFO                              0xd08
+#define ROFDM1_CSI1                             0xd10
+#define ROFDM1_SBD                              0xd14
+#define ROFDM1_CSI2                             0xd18
+#define ROFDM1_CFOTRACKING                      0xd2c
+#define ROFDM1_TRXMESAURE1                      0xd34
+#define ROFDM1_INTF_DET                         0xd3c
+#define ROFDM1_PSEUDO_NOISESTATEAB              0xd50
+#define ROFDM1_PSEUDO_NOISESTATECD              0xd54
+#define ROFDM1_RX_PSEUDO_NOISE_WGT              0xd58
+#define ROFDM_PHYCOUNTER1                       0xda0
+#define ROFDM_PHYCOUNTER2                       0xda4
+#define ROFDM_PHYCOUNTER3                       0xda8
+#define ROFDM_SHORT_CFOAB                       0xdac
+#define ROFDM_SHORT_CFOCD                       0xdb0
+#define ROFDM_LONG_CFOAB                        0xdb4
+#define ROFDM_LONG_CFOCD                        0xdb8
+#define ROFDM_TAIL_CFOAB                        0xdbc
+#define ROFDM_TAIL_CFOCD                        0xdc0
+#define ROFDM_PW_MEASURE1                       0xdc4
+#define ROFDM_PW_MEASURE2                       0xdc8
+#define ROFDM_BW_REPORT                         0xdcc
+#define ROFDM_AGC_REPORT                        0xdd0
+#define ROFDM_RXSNR                             0xdd4
+#define ROFDM_RXEVMCSI                          0xdd8
+#define ROFDM_SIG_REPORT                        0xddc
+#define RTXAGC_RATE18_06                        0xe00
+#define RTXAGC_RATE54_24                        0xe04
+#define RTXAGC_CCK_MCS32                        0xe08
+#define RTXAGC_MCS03_MCS00                      0xe10
+#define RTXAGC_MCS07_MCS04                      0xe14
+#define RTXAGC_MCS11_MCS08                      0xe18
+#define RTXAGC_MCS15_MCS12                      0xe1c
+#define RF_AC                                   0x00
+#define RF_IQADJ_G1                             0x01
+#define RF_IQADJ_G2                             0x02
+#define RF_POW_TRSW                             0x05
+#define RF_GAIN_RX                              0x06
+#define RF_GAIN_TX                              0x07
+#define RF_TXM_IDAC                             0x08
+#define RF_BS_IQGEN                             0x0F
+#define RF_MODE1                                0x10
+#define RF_MODE2                                0x11
+#define RF_RX_AGC_HP                            0x12
+#define RF_TX_AGC                               0x13
+#define RF_BIAS                                 0x14
+#define RF_IPA                                  0x15
+#define RF_POW_ABILITY                          0x17
+#define RF_MODE_AG                              0x18
+#define RF_CHANNEL                              0x18
+#define RF_CHNLBW                               0x18
+#define RF_TOP                                  0x19
+#define RF_RX_G1                                0x1A
+#define RF_RX_G2                                0x1B
+#define RF_RX_BB2                               0x1C
+#define RF_RX_BB1                               0x1D
+#define RF_RCK1                                 0x1E
+#define RF_RCK2                                 0x1F
+#define RF_TX_G1                                0x20
+#define RF_TX_G2                                0x21
+#define RF_TX_G3                                0x22
+#define RF_TX_BB1                               0x23
+#define RF_T_METER                              0x24
+#define RF_SYN_G1                               0x25
+#define RF_SYN_G2                               0x26
+#define RF_SYN_G3                               0x27
+#define RF_SYN_G4                               0x28
+#define RF_SYN_G5                               0x29
+#define RF_SYN_G6                               0x2A
+#define RF_SYN_G7                               0x2B
+#define RF_SYN_G8                               0x2C
+#define RF_RCK_OS                               0x30
+#define RF_TXPA_G1                              0x31
+#define RF_TXPA_G2                              0x32
+#define RF_TXPA_G3                              0x33
+#define BRFMOD                                  0x1
+#define BCCKEN                                  0x1000000
+#define BOFDMEN                                 0x2000000
+#define BXBTXAGC                                0xf00
+#define BXCTXAGC                                0xf000
+#define BXDTXAGC                                0xf0000
+#define B3WIRE_DATALENGTH                       0x800
+#define B3WIRE_ADDRESSLENGTH                    0x400
+#define BRFSI_RFENV                             0x10
+#define BLSSI_READADDRESS                       0x7f800000
+#define BLSSI_READEDGE                          0x80000000
+#define BLSSI_READBACK_DATA                     0xfffff
+#define BADCLKPHASE                             0x4000000
+#define BCCK_SIDEBAND                           0x10
+#define BTX_AGCRATECCK                          0x7f00
+#define MASKBYTE0                               0xff
+#define MASKBYTE1                               0xff00
+#define MASKBYTE2                               0xff0000
+#define MASKBYTE3                               0xff000000
+#define MASKHWORD                               0xffff0000
+#define MASKLWORD                               0x0000ffff
+#define MASKDWORD                               0xffffffff
+#define MAKS12BITS                              0xfffff
+#define MASK20BITS                              0xfffff
+#define RFREG_OFFSET_MASK                       0xfffff
+#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/rf.c b/drivers/net/wireless/rtlwifi/rtl8192se/rf.c
new file mode 100644
index 000000000000..1d3a48330399
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/rf.c
@@ -0,0 +1,546 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#include "../wifi.h"
+#include "reg.h"
+#include "def.h"
+#include "phy.h"
+#include "rf.h"
+#include "dm.h"
+static void _rtl92s_get_powerbase(struct ieee80211_hw *hw, u8 *p_pwrlevel,
+                                  u8 chnl, u32 *ofdmbase, u32 *mcsbase,
+                                  u8 *p_final_pwridx)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        u32 pwrbase0, pwrbase1;
+        u8 legacy_pwrdiff = 0, ht20_pwrdiff = 0;
+        u8 i, pwrlevel[4];
+        for (i = 0; i < 2; i++)
+                pwrlevel[i] = p_pwrlevel[i];
+        /* We only care about the path A for legacy. */
+        if (rtlefuse->eeprom_version < 2) {
+                pwrbase0 = pwrlevel[0] + (rtlefuse->legacy_httxpowerdiff & 0xf);
+        } else if (rtlefuse->eeprom_version >= 2) {
+                legacy_pwrdiff = rtlefuse->txpwr_legacyhtdiff
+                                                [RF90_PATH_A][chnl - 1];
+                /* For legacy OFDM, tx pwr always > HT OFDM pwr.
+                 * We do not care Path B
+                 * legacy OFDM pwr diff. NO BB register
+                 * to notify HW. */
+                pwrbase0 = pwrlevel[0] + legacy_pwrdiff;
+        }
+        pwrbase0 = (pwrbase0 << 24) | (pwrbase0 << 16) | (pwrbase0 << 8) |
+                    pwrbase0;
+        *ofdmbase = pwrbase0;
+        /* MCS rates */
+        if (rtlefuse->eeprom_version >= 2) {
+                /* Check HT20 to HT40 diff      */
+                if (rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20) {
+                        for (i = 0; i < 2; i++) {
+                                /* rf-A, rf-B */
+                                /* HT 20<->40 pwr diff */
+                                ht20_pwrdiff = rtlefuse->txpwr_ht20diff
+                                                        [i][chnl - 1];
+                                if (ht20_pwrdiff < 8) /* 0~+7 */
+                                        pwrlevel[i] += ht20_pwrdiff;
+                                else /* index8-15=-8~-1 */
+                                        pwrlevel[i] -= (16 - ht20_pwrdiff);
+                        }
+                }
+        }
+        /* use index of rf-A */
+        pwrbase1 = pwrlevel[0];
+        pwrbase1 = (pwrbase1 << 24) | (pwrbase1 << 16) | (pwrbase1 << 8) |
+                                pwrbase1;
+        *mcsbase = pwrbase1;
+        /* The following is for Antenna
+         * diff from Ant-B to Ant-A */
+        p_final_pwridx[0] = pwrlevel[0];
+        p_final_pwridx[1] = pwrlevel[1];
+        switch (rtlefuse->eeprom_regulatory) {
+        case 3:
+                /* The following is for calculation
+                 * of the power diff for Ant-B to Ant-A. */
+                if (rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20_40) {
+                        p_final_pwridx[0] += rtlefuse->pwrgroup_ht40
+                                                [RF90_PATH_A][
+                                                chnl - 1];
+                        p_final_pwridx[1] += rtlefuse->pwrgroup_ht40
+                                                [RF90_PATH_B][
+                                                chnl - 1];
+                } else {
+                        p_final_pwridx[0] += rtlefuse->pwrgroup_ht20
+                                                [RF90_PATH_A][
+                                                chnl - 1];
+                        p_final_pwridx[1] += rtlefuse->pwrgroup_ht20
+                                                [RF90_PATH_B][
+                                                chnl - 1];
+                }
+                break;
+        default:
+                break;
+        }
+        if (rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20_40) {
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD, ("40MHz finalpwr_idx "
+                        "(A / B) = 0x%x / 0x%x\n", p_final_pwridx[0],
+                        p_final_pwridx[1]));
+        } else {
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD, ("20MHz finalpwr_idx "
+                        "(A / B) = 0x%x / 0x%x\n", p_final_pwridx[0],
+                         p_final_pwridx[1]));
+        }
+}
+static void _rtl92s_set_antennadiff(struct ieee80211_hw *hw,
+                                    u8 *p_final_pwridx)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        char ant_pwr_diff = 0;
+        u32     u4reg_val = 0;
+        if (rtlphy->rf_type == RF_2T2R) {
+                ant_pwr_diff = p_final_pwridx[1] - p_final_pwridx[0];
+                /* range is from 7~-8,
+                 * index = 0x0~0xf */
+                if (ant_pwr_diff > 7)
+                        ant_pwr_diff = 7;
+                if (ant_pwr_diff < -8)
+                        ant_pwr_diff = -8;
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("Antenna Diff from RF-B "
+                        "to RF-A = %d (0x%x)\n", ant_pwr_diff,
+                         ant_pwr_diff & 0xf));
+                ant_pwr_diff &= 0xf;
+        }
+        /* Antenna TX power difference */
+        rtlefuse->antenna_txpwdiff[2] = 0;/* RF-D, don't care */
+        rtlefuse->antenna_txpwdiff[1] = 0;/* RF-C, don't care */
+        rtlefuse->antenna_txpwdiff[0] = (u8)(ant_pwr_diff);     /* RF-B */
+        u4reg_val = rtlefuse->antenna_txpwdiff[2] << 8 |
+                                rtlefuse->antenna_txpwdiff[1] << 4 |
+                                rtlefuse->antenna_txpwdiff[0];
+        rtl_set_bbreg(hw, RFPGA0_TXGAINSTAGE, (BXBTXAGC | BXCTXAGC | BXDTXAGC),
+                      u4reg_val);
+        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                 ("Write BCD-Diff(0x%x) = 0x%x\n",
+                 RFPGA0_TXGAINSTAGE, u4reg_val));
+}
+static void _rtl92s_get_txpower_writeval_byregulatory(struct ieee80211_hw *hw,
+                                                      u8 chnl, u8 index,
+                                                      u32 pwrbase0,
+                                                      u32 pwrbase1,
+                                                      u32 *p_outwrite_val)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        u8 i, chnlgroup, pwrdiff_limit[4];
+        u32 writeval, customer_limit;
+        /* Index 0 & 1= legacy OFDM, 2-5=HT_MCS rate */
+        switch (rtlefuse->eeprom_regulatory) {
+        case 0:
+                /* Realtek better performance increase power diff
+                 * defined by Realtek for large power */
+                chnlgroup = 0;
+                writeval = rtlphy->mcs_txpwrlevel_origoffset
+                                [chnlgroup][index] +
+                                ((index < 2) ? pwrbase0 : pwrbase1);
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("RTK better performance, "
+                         "writeval = 0x%x\n", writeval));
+                break;
+        case 1:
+                /* Realtek regulatory increase power diff defined
+                 * by Realtek for regulatory */
+                if (rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20_40) {
+                        writeval = ((index < 2) ? pwrbase0 : pwrbase1);
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                                 ("Realtek regulatory, "
+                                 "40MHz, writeval = 0x%x\n", writeval));
+                } else {
+                        if (rtlphy->pwrgroup_cnt == 1)
+                                chnlgroup = 0;
+                        if (rtlphy->pwrgroup_cnt >= 3) {
+                                if (chnl <= 3)
+                                        chnlgroup = 0;
+                                else if (chnl >= 4 && chnl <= 8)
+                                        chnlgroup = 1;
+                                else if (chnl > 8)
+                                        chnlgroup = 2;
+                                if (rtlphy->pwrgroup_cnt == 4)
+                                        chnlgroup++;
+                        }
+                        writeval = rtlphy->mcs_txpwrlevel_origoffset
+                                        [chnlgroup][index]
+                                        + ((index < 2) ?
+                                        pwrbase0 : pwrbase1);
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                                 ("Realtek regulatory, "
+                                 "20MHz, writeval = 0x%x\n", writeval));
+                }
+                break;
+        case 2:
+                /* Better regulatory don't increase any power diff */
+                writeval = ((index < 2) ? pwrbase0 : pwrbase1);
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("Better regulatory, "
+                         "writeval = 0x%x\n", writeval));
+                break;
+        case 3:
+                /* Customer defined power diff. increase power diff
+                  defined by customer. */
+                chnlgroup = 0;
+                if (rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20_40) {
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                                ("customer's limit, 40MHz = 0x%x\n",
+                                rtlefuse->pwrgroup_ht40
+                                [RF90_PATH_A][chnl - 1]));
+                } else {
+                        RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                                ("customer's limit, 20MHz = 0x%x\n",
+                                rtlefuse->pwrgroup_ht20
+                                [RF90_PATH_A][chnl - 1]));
+                }
+                for (i = 0; i < 4; i++) {
+                        pwrdiff_limit[i] =
+                                (u8)((rtlphy->mcs_txpwrlevel_origoffset
+                                [chnlgroup][index] & (0x7f << (i * 8)))
+                                >> (i * 8));
+                        if (rtlphy->current_chan_bw ==
+                            HT_CHANNEL_WIDTH_20_40) {
+                                if (pwrdiff_limit[i] >
+                                    rtlefuse->pwrgroup_ht40
+                                    [RF90_PATH_A][chnl - 1]) {
+                                        pwrdiff_limit[i] =
+                                          rtlefuse->pwrgroup_ht20
+                                          [RF90_PATH_A][chnl - 1];
+                                }
+                        } else {
+                                if (pwrdiff_limit[i] >
+                                    rtlefuse->pwrgroup_ht20
+                                    [RF90_PATH_A][chnl - 1]) {
+                                        pwrdiff_limit[i] =
+                                            rtlefuse->pwrgroup_ht20
+                                            [RF90_PATH_A][chnl - 1];
+                                }
+                        }
+                }
+                customer_limit = (pwrdiff_limit[3] << 24) |
+                                (pwrdiff_limit[2] << 16) |
+                                (pwrdiff_limit[1] << 8) |
+                                (pwrdiff_limit[0]);
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("Customer's limit = 0x%x\n",
+                         customer_limit));
+                writeval = customer_limit + ((index < 2) ?
+                                             pwrbase0 : pwrbase1);
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("Customer, writeval = "
+                         "0x%x\n", writeval));
+                break;
+        default:
+                chnlgroup = 0;
+                writeval = rtlphy->mcs_txpwrlevel_origoffset[chnlgroup][index] +
+                                ((index < 2) ? pwrbase0 : pwrbase1);
+                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
+                         ("RTK better performance, "
+                         "writeval = 0x%x\n", writeval));
+                break;
+        }
+        if (rtlpriv->dm.dynamic_txhighpower_lvl == TX_HIGH_PWR_LEVEL_LEVEL1)
+                writeval = 0x10101010;
+        else if (rtlpriv->dm.dynamic_txhighpower_lvl ==
+                 TX_HIGH_PWR_LEVEL_LEVEL2)
+                writeval = 0x0;
+        *p_outwrite_val = writeval;
+}
+static void _rtl92s_write_ofdm_powerreg(struct ieee80211_hw *hw,
+                                        u8 index, u32 val)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        u16 regoffset[6] = {0xe00, 0xe04, 0xe10, 0xe14, 0xe18, 0xe1c};
+        u8 i, rfa_pwr[4];
+        u8 rfa_lower_bound = 0, rfa_upper_bound = 0, rf_pwr_diff = 0;
+        u32 writeval = val;
+        /* If path A and Path B coexist, we must limit Path A tx power.
+         * Protect Path B pwr over or under flow. We need to calculate
+         * upper and lower bound of path A tx power. */
+        if (rtlphy->rf_type == RF_2T2R) {
+                rf_pwr_diff = rtlefuse->antenna_txpwdiff[0];
+                /* Diff=-8~-1 */
+                if (rf_pwr_diff >= 8) {
+                        /* Prevent underflow!! */
+                        rfa_lower_bound = 0x10 - rf_pwr_diff;
+                /* if (rf_pwr_diff >= 0) Diff = 0-7 */
+                } else {
+                        rfa_upper_bound = RF6052_MAX_TX_PWR - rf_pwr_diff;
+                }
+        }
+        for (i = 0; i < 4; i++) {
+                rfa_pwr[i] = (u8)((writeval & (0x7f << (i * 8))) >> (i * 8));
+                if (rfa_pwr[i]  > RF6052_MAX_TX_PWR)
+                        rfa_pwr[i]  = RF6052_MAX_TX_PWR;
+                /* If path A and Path B coexist, we must limit Path A tx power.
+                 * Protect Path B pwr over or under flow. We need to calculate
+                 * upper and lower bound of path A tx power. */
+                if (rtlphy->rf_type == RF_2T2R) {
+                        /* Diff=-8~-1 */
+                        if (rf_pwr_diff >= 8) {
+                                /* Prevent underflow!! */
+                                if (rfa_pwr[i] < rfa_lower_bound)
+                                        rfa_pwr[i] = rfa_lower_bound;
+                        /* Diff = 0-7 */
+                        } else if (rf_pwr_diff >= 1) {
+                                /* Prevent overflow */
+                                if (rfa_pwr[i] > rfa_upper_bound)
+                                        rfa_pwr[i] = rfa_upper_bound;
+                        }
+                }
+        }
+        writeval = (rfa_pwr[3] << 24) | (rfa_pwr[2] << 16) | (rfa_pwr[1] << 8) |
+                                rfa_pwr[0];
+        rtl_set_bbreg(hw, regoffset[index], 0x7f7f7f7f, writeval);
+}
+void rtl92s_phy_rf6052_set_ofdmtxpower(struct ieee80211_hw *hw,
+                                       u8 *p_pwrlevel, u8 chnl)
+{
+        u32 writeval, pwrbase0, pwrbase1;
+        u8 index = 0;
+        u8 finalpwr_idx[4];
+        _rtl92s_get_powerbase(hw, p_pwrlevel, chnl, &pwrbase0, &pwrbase1,
+                        &finalpwr_idx[0]);
+        _rtl92s_set_antennadiff(hw, &finalpwr_idx[0]);
+        for (index = 0; index < 6; index++) {
+                _rtl92s_get_txpower_writeval_byregulatory(hw, chnl, index,
+                                pwrbase0, pwrbase1, &writeval);
+                _rtl92s_write_ofdm_powerreg(hw, index, writeval);
+        }
+}
+void rtl92s_phy_rf6052_set_ccktxpower(struct ieee80211_hw *hw, u8 pwrlevel)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        u32 txagc = 0;
+        bool dont_inc_cck_or_turboscanoff = false;
+        if (((rtlefuse->eeprom_version >= 2) &&
+              (rtlefuse->txpwr_safetyflag == 1)) ||
+              ((rtlefuse->eeprom_version >= 2) &&
+              (rtlefuse->eeprom_regulatory != 0)))
+                dont_inc_cck_or_turboscanoff = true;
+        if (mac->act_scanning == true) {
+                txagc = 0x3f;
+                if (dont_inc_cck_or_turboscanoff)
+                        txagc = pwrlevel;
+        } else {
+                txagc = pwrlevel;
+                if (rtlpriv->dm.dynamic_txhighpower_lvl ==
+                    TX_HIGH_PWR_LEVEL_LEVEL1)
+                        txagc = 0x10;
+                else if (rtlpriv->dm.dynamic_txhighpower_lvl ==
+                        TX_HIGH_PWR_LEVEL_LEVEL2)
+                        txagc = 0x0;
+        }
+        if (txagc > RF6052_MAX_TX_PWR)
+                txagc = RF6052_MAX_TX_PWR;
+        rtl_set_bbreg(hw, RTXAGC_CCK_MCS32, BTX_AGCRATECCK, txagc);
+}
+bool rtl92s_phy_rf6052_config(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        u32 u4reg_val = 0;
+        u8 rfpath;
+        bool rtstatus = true;
+        struct bb_reg_def *pphyreg;
+        /* Initialize RF */
+        for (rfpath = 0; rfpath < rtlphy->num_total_rfpath; rfpath++) {
+                pphyreg = &rtlphy->phyreg_def[rfpath];
+                /* Store original RFENV control type */
+                switch (rfpath) {
+                case RF90_PATH_A:
+                case RF90_PATH_C:
+                        u4reg_val = rtl92s_phy_query_bb_reg(hw,
+                                                            pphyreg->rfintfs,
+                                                            BRFSI_RFENV);
+                        break;
+                case RF90_PATH_B:
+                case RF90_PATH_D:
+                        u4reg_val = rtl92s_phy_query_bb_reg(hw,
+                                                            pphyreg->rfintfs,
+                                                            BRFSI_RFENV << 16);
+                        break;
+                }
+                /* Set RF_ENV enable */
+                rtl92s_phy_set_bb_reg(hw, pphyreg->rfintfe,
+                                      BRFSI_RFENV << 16, 0x1);
+                /* Set RF_ENV output high */
+                rtl92s_phy_set_bb_reg(hw, pphyreg->rfintfo, BRFSI_RFENV, 0x1);
+                /* Set bit number of Address and Data for RF register */
+                rtl92s_phy_set_bb_reg(hw, pphyreg->rfhssi_para2,
+                                B3WIRE_ADDRESSLENGTH, 0x0);
+                rtl92s_phy_set_bb_reg(hw, pphyreg->rfhssi_para2,
+                                B3WIRE_DATALENGTH, 0x0);
+                /* Initialize RF fom connfiguration file */
+                switch (rfpath) {
+                case RF90_PATH_A:
+                        rtstatus = rtl92s_phy_config_rf(hw,
+                                                (enum radio_path)rfpath);
+                        break;
+                case RF90_PATH_B:
+                        rtstatus = rtl92s_phy_config_rf(hw,
+                                                (enum radio_path)rfpath);
+                        break;
+                case RF90_PATH_C:
+                        break;
+                case RF90_PATH_D:
+                        break;
+                }
+                /* Restore RFENV control type */
+                switch (rfpath) {
+                case RF90_PATH_A:
+                case RF90_PATH_C:
+                        rtl92s_phy_set_bb_reg(hw, pphyreg->rfintfs, BRFSI_RFENV,
+                                              u4reg_val);
+                        break;
+                case RF90_PATH_B:
+                case RF90_PATH_D:
+                        rtl92s_phy_set_bb_reg(hw, pphyreg->rfintfs,
+                                              BRFSI_RFENV << 16,
+                                              u4reg_val);
+                        break;
+                }
+                if (rtstatus != true) {
+                        printk(KERN_ERR "Radio[%d] Fail!!", rfpath);
+                        goto fail;
+                }
+        }
+        return rtstatus;
+fail:
+        return rtstatus;
+}
+void rtl92s_phy_rf6052_set_bandwidth(struct ieee80211_hw *hw, u8 bandwidth)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        switch (bandwidth) {
+        case HT_CHANNEL_WIDTH_20:
+                rtlphy->rfreg_chnlval[0] = ((rtlphy->rfreg_chnlval[0] &
+                                           0xfffff3ff) | 0x0400);
+                rtl_set_rfreg(hw, RF90_PATH_A, RF_CHNLBW, RFREG_OFFSET_MASK,
+                                        rtlphy->rfreg_chnlval[0]);
+                break;
+        case HT_CHANNEL_WIDTH_20_40:
+                rtlphy->rfreg_chnlval[0] = ((rtlphy->rfreg_chnlval[0] &
+                                            0xfffff3ff));
+                rtl_set_rfreg(hw, RF90_PATH_A, RF_CHNLBW, RFREG_OFFSET_MASK,
+                                        rtlphy->rfreg_chnlval[0]);
+                break;
+        default:
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("unknown bandwidth: %#X\n",
+                         bandwidth));
+                break;
+        }
+}
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/rf.h b/drivers/net/wireless/rtlwifi/rtl8192se/rf.h
new file mode 100644
index 000000000000..3843baa1a874
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/rf.h
@@ -0,0 +1,43 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#ifndef __INC_RTL92S_RF_H
+#define __INC_RTL92S_RF_H
+#define RF6052_MAX_TX_PWR       0x3F
+void rtl92s_phy_rf6052_set_bandwidth(struct ieee80211_hw *hw,
+                                     u8 bandwidth);
+bool rtl92s_phy_rf6052_config(struct ieee80211_hw *hw) ;
+void rtl92s_phy_rf6052_set_ccktxpower(struct ieee80211_hw *hw,
+                                      u8 powerlevel);
+void rtl92s_phy_rf6052_set_ofdmtxpower(struct ieee80211_hw *hw,
+                                       u8 *p_pwrlevel, u8 chnl);
+#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/sw.c b/drivers/net/wireless/rtlwifi/rtl8192se/sw.c
new file mode 100644
index 000000000000..1c6cb1d7d660
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/sw.c
@@ -0,0 +1,423 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#include <linux/vmalloc.h>
+#include "../wifi.h"
+#include "../core.h"
+#include "../pci.h"
+#include "reg.h"
+#include "def.h"
+#include "phy.h"
+#include "dm.h"
+#include "fw.h"
+#include "hw.h"
+#include "sw.h"
+#include "trx.h"
+#include "led.h"
+static void rtl92s_init_aspm_vars(struct ieee80211_hw *hw)
+{
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        /*close ASPM for AMD defaultly */
+        rtlpci->const_amdpci_aspm = 0;
+        /*
+         * ASPM PS mode.
+         * 0 - Disable ASPM,
+         * 1 - Enable ASPM without Clock Req,
+         * 2 - Enable ASPM with Clock Req,
+         * 3 - Alwyas Enable ASPM with Clock Req,
+         * 4 - Always Enable ASPM without Clock Req.
+         * set defult to RTL8192CE:3 RTL8192E:2
+         * */
+        rtlpci->const_pci_aspm = 2;
+        /*Setting for PCI-E device */
+        rtlpci->const_devicepci_aspm_setting = 0x03;
+        /*Setting for PCI-E bridge */
+        rtlpci->const_hostpci_aspm_setting = 0x02;
+        /*
+         * In Hw/Sw Radio Off situation.
+         * 0 - Default,
+         * 1 - From ASPM setting without low Mac Pwr,
+         * 2 - From ASPM setting with low Mac Pwr,
+         * 3 - Bus D3
+         * set default to RTL8192CE:0 RTL8192SE:2
+         */
+        rtlpci->const_hwsw_rfoff_d3 = 2;
+        /*
+         * This setting works for those device with
+         * backdoor ASPM setting such as EPHY setting.
+         * 0 - Not support ASPM,
+         * 1 - Support ASPM,
+         * 2 - According to chipset.
+         */
+        rtlpci->const_support_pciaspm = 2;
+}
+static int rtl92s_init_sw_vars(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        const struct firmware *firmware;
+        struct rt_firmware *pfirmware = NULL;
+        int err = 0;
+        u16 earlyrxthreshold = 7;
+        rtlpriv->dm.dm_initialgain_enable = 1;
+        rtlpriv->dm.dm_flag = 0;
+        rtlpriv->dm.disable_framebursting = 0;
+        rtlpriv->dm.thermalvalue = 0;
+        rtlpriv->dm.useramask = true;
+        /* compatible 5G band 91se just 2.4G band & smsp */
+        rtlpriv->rtlhal.current_bandtype = BAND_ON_2_4G;
+        rtlpriv->rtlhal.bandset = BAND_ON_2_4G;
+        rtlpriv->rtlhal.macphymode = SINGLEMAC_SINGLEPHY;
+        rtlpci->transmit_config = 0;
+        rtlpci->receive_config =
+                        RCR_APPFCS |
+                        RCR_APWRMGT |
+                        /*RCR_ADD3 |*/
+                        RCR_AMF |
+                        RCR_ADF |
+                        RCR_APP_MIC |
+                        RCR_APP_ICV |
+                        RCR_AICV |
+                        /* Accept ICV error, CRC32 Error */
+                        RCR_ACRC32 |
+                        RCR_AB |
+                        /* Accept Broadcast, Multicast */
+                        RCR_AM  |
+                        /* Accept Physical match */
+                        RCR_APM |
+                        /* Accept Destination Address packets */
+                        /*RCR_AAP |*/
+                        RCR_APP_PHYST_STAFF |
+                        /* Accept PHY status */
+                        RCR_APP_PHYST_RXFF |
+                        (earlyrxthreshold << RCR_FIFO_OFFSET);
+        rtlpci->irq_mask[0] = (u32)
+                        (IMR_ROK |
+                        IMR_VODOK |
+                        IMR_VIDOK |
+                        IMR_BEDOK |
+                        IMR_BKDOK |
+                        IMR_HCCADOK |
+                        IMR_MGNTDOK |
+                        IMR_COMDOK |
+                        IMR_HIGHDOK |
+                        IMR_BDOK |
+                        IMR_RXCMDOK |
+                        /*IMR_TIMEOUT0 |*/
+                        IMR_RDU |
+                        IMR_RXFOVW      |
+                        IMR_BCNINT
+                        /*| IMR_TXFOVW*/
+                        /*| IMR_TBDOK |
+                        IMR_TBDER*/);
+        rtlpci->irq_mask[1] = (u32) 0;
+        rtlpci->shortretry_limit = 0x30;
+        rtlpci->longretry_limit = 0x30;
+        rtlpci->first_init = true;
+        /* for LPS & IPS */
+        rtlpriv->psc.inactiveps = rtlpriv->cfg->mod_params->inactiveps;
+        rtlpriv->psc.swctrl_lps = rtlpriv->cfg->mod_params->swctrl_lps;
+        rtlpriv->psc.fwctrl_lps = rtlpriv->cfg->mod_params->fwctrl_lps;
+        rtlpriv->psc.reg_fwctrl_lps = 3;
+        rtlpriv->psc.reg_max_lps_awakeintvl = 5;
+        /* for ASPM, you can close aspm through
+         * set const_support_pciaspm = 0 */
+        rtl92s_init_aspm_vars(hw);
+        if (rtlpriv->psc.reg_fwctrl_lps == 1)
+                rtlpriv->psc.fwctrl_psmode = FW_PS_MIN_MODE;
+        else if (rtlpriv->psc.reg_fwctrl_lps == 2)
+                rtlpriv->psc.fwctrl_psmode = FW_PS_MAX_MODE;
+        else if (rtlpriv->psc.reg_fwctrl_lps == 3)
+                rtlpriv->psc.fwctrl_psmode = FW_PS_DTIM_MODE;
+        /* for firmware buf */
+        rtlpriv->rtlhal.pfirmware = vzalloc(sizeof(struct rt_firmware));
+        if (!rtlpriv->rtlhal.pfirmware) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("Can't alloc buffer for fw.\n"));
+                return 1;
+        }
+        printk(KERN_INFO "rtl8192se: Driver for Realtek RTL8192SE/RTL8191SE\n"
+               "           Loading firmware %s\n", rtlpriv->cfg->fw_name);
+        /* request fw */
+        err = request_firmware(&firmware, rtlpriv->cfg->fw_name,
+                        rtlpriv->io.dev);
+        if (err) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("Failed to request firmware!\n"));
+                return 1;
+        }
+        if (firmware->size > sizeof(struct rt_firmware)) {
+                RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
+                         ("Firmware is too big!\n"));
+                release_firmware(firmware);
+                return 1;
+        }
+        pfirmware = (struct rt_firmware *)rtlpriv->rtlhal.pfirmware;
+        memcpy(pfirmware->sz_fw_tmpbuffer, firmware->data, firmware->size);
+        pfirmware->sz_fw_tmpbufferlen = firmware->size;
+        release_firmware(firmware);
+        return err;
+}
+static void rtl92s_deinit_sw_vars(struct ieee80211_hw *hw)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        if (rtlpriv->rtlhal.pfirmware) {
+                vfree(rtlpriv->rtlhal.pfirmware);
+                rtlpriv->rtlhal.pfirmware = NULL;
+        }
+}
+static struct rtl_hal_ops rtl8192se_hal_ops = {
+        .init_sw_vars = rtl92s_init_sw_vars,
+        .deinit_sw_vars = rtl92s_deinit_sw_vars,
+        .read_eeprom_info = rtl92se_read_eeprom_info,
+        .interrupt_recognized = rtl92se_interrupt_recognized,
+        .hw_init = rtl92se_hw_init,
+        .hw_disable = rtl92se_card_disable,
+        .hw_suspend = rtl92se_suspend,
+        .hw_resume = rtl92se_resume,
+        .enable_interrupt = rtl92se_enable_interrupt,
+        .disable_interrupt = rtl92se_disable_interrupt,
+        .set_network_type = rtl92se_set_network_type,
+        .set_chk_bssid = rtl92se_set_check_bssid,
+        .set_qos = rtl92se_set_qos,
+        .set_bcn_reg = rtl92se_set_beacon_related_registers,
+        .set_bcn_intv = rtl92se_set_beacon_interval,
+        .update_interrupt_mask = rtl92se_update_interrupt_mask,
+        .get_hw_reg = rtl92se_get_hw_reg,
+        .set_hw_reg = rtl92se_set_hw_reg,
+        .update_rate_tbl = rtl92se_update_hal_rate_tbl,
+        .fill_tx_desc = rtl92se_tx_fill_desc,
+        .fill_tx_cmddesc = rtl92se_tx_fill_cmddesc,
+        .query_rx_desc = rtl92se_rx_query_desc,
+        .set_channel_access = rtl92se_update_channel_access_setting,
+        .radio_onoff_checking = rtl92se_gpio_radio_on_off_checking,
+        .set_bw_mode = rtl92s_phy_set_bw_mode,
+        .switch_channel = rtl92s_phy_sw_chnl,
+        .dm_watchdog = rtl92s_dm_watchdog,
+        .scan_operation_backup = rtl92s_phy_scan_operation_backup,
+        .set_rf_power_state = rtl92s_phy_set_rf_power_state,
+        .led_control = rtl92se_led_control,
+        .set_desc = rtl92se_set_desc,
+        .get_desc = rtl92se_get_desc,
+        .tx_polling = rtl92se_tx_polling,
+        .enable_hw_sec = rtl92se_enable_hw_security_config,
+        .set_key = rtl92se_set_key,
+        .init_sw_leds = rtl92se_init_sw_leds,
+        .get_bbreg = rtl92s_phy_query_bb_reg,
+        .set_bbreg = rtl92s_phy_set_bb_reg,
+        .get_rfreg = rtl92s_phy_query_rf_reg,
+        .set_rfreg = rtl92s_phy_set_rf_reg,
+};
+static struct rtl_mod_params rtl92se_mod_params = {
+        .sw_crypto = false,
+        .inactiveps = true,
+        .swctrl_lps = true,
+        .fwctrl_lps = false,
+};
+/* Because memory R/W bursting will cause system hang/crash
+ * for 92se, so we don't read back after every write action */
+static struct rtl_hal_cfg rtl92se_hal_cfg = {
+        .bar_id = 1,
+        .write_readback = false,
+        .name = "rtl92s_pci",
+        .fw_name = "rtlwifi/rtl8192sefw.bin",
+        .ops = &rtl8192se_hal_ops,
+        .mod_params = &rtl92se_mod_params,
+        .maps[SYS_ISO_CTRL] = REG_SYS_ISO_CTRL,
+        .maps[SYS_FUNC_EN] = REG_SYS_FUNC_EN,
+        .maps[SYS_CLK] = SYS_CLKR,
+        .maps[MAC_RCR_AM] = RCR_AM,
+        .maps[MAC_RCR_AB] = RCR_AB,
+        .maps[MAC_RCR_ACRC32] = RCR_ACRC32,
+        .maps[MAC_RCR_ACF] = RCR_ACF,
+        .maps[MAC_RCR_AAP] = RCR_AAP,
+        .maps[EFUSE_TEST] = REG_EFUSE_TEST,
+        .maps[EFUSE_CTRL] = REG_EFUSE_CTRL,
+        .maps[EFUSE_CLK] = REG_EFUSE_CLK,
+        .maps[EFUSE_CLK_CTRL] = REG_EFUSE_CTRL,
+        .maps[EFUSE_PWC_EV12V] = 0, /* nouse for 8192se */
+        .maps[EFUSE_FEN_ELDR] = 0, /* nouse for 8192se */
+        .maps[EFUSE_LOADER_CLK_EN] = 0,/* nouse for 8192se */
+        .maps[EFUSE_ANA8M] = EFUSE_ANA8M,
+        .maps[EFUSE_HWSET_MAX_SIZE] = HWSET_MAX_SIZE_92S,
+        .maps[EFUSE_MAX_SECTION_MAP] = EFUSE_MAX_SECTION,
+        .maps[EFUSE_REAL_CONTENT_SIZE] = EFUSE_REAL_CONTENT_LEN,
+        .maps[RWCAM] = REG_RWCAM,
+        .maps[WCAMI] = REG_WCAMI,
+        .maps[RCAMO] = REG_RCAMO,
+        .maps[CAMDBG] = REG_CAMDBG,
+        .maps[SECR] = REG_SECR,
+        .maps[SEC_CAM_NONE] = CAM_NONE,
+        .maps[SEC_CAM_WEP40] = CAM_WEP40,
+        .maps[SEC_CAM_TKIP] = CAM_TKIP,
+        .maps[SEC_CAM_AES] = CAM_AES,
+        .maps[SEC_CAM_WEP104] = CAM_WEP104,
+        .maps[RTL_IMR_BCNDMAINT6] = IMR_BCNDMAINT6,
+        .maps[RTL_IMR_BCNDMAINT5] = IMR_BCNDMAINT5,
+        .maps[RTL_IMR_BCNDMAINT4] = IMR_BCNDMAINT4,
+        .maps[RTL_IMR_BCNDMAINT3] = IMR_BCNDMAINT3,
+        .maps[RTL_IMR_BCNDMAINT2] = IMR_BCNDMAINT2,
+        .maps[RTL_IMR_BCNDMAINT1] = IMR_BCNDMAINT1,
+        .maps[RTL_IMR_BCNDOK8] = IMR_BCNDOK8,
+        .maps[RTL_IMR_BCNDOK7] = IMR_BCNDOK7,
+        .maps[RTL_IMR_BCNDOK6] = IMR_BCNDOK6,
+        .maps[RTL_IMR_BCNDOK5] = IMR_BCNDOK5,
+        .maps[RTL_IMR_BCNDOK4] = IMR_BCNDOK4,
+        .maps[RTL_IMR_BCNDOK3] = IMR_BCNDOK3,
+        .maps[RTL_IMR_BCNDOK2] = IMR_BCNDOK2,
+        .maps[RTL_IMR_BCNDOK1] = IMR_BCNDOK1,
+        .maps[RTL_IMR_TIMEOUT2] = IMR_TIMEOUT2,
+        .maps[RTL_IMR_TIMEOUT1] = IMR_TIMEOUT1,
+        .maps[RTL_IMR_TXFOVW] = IMR_TXFOVW,
+        .maps[RTL_IMR_PSTIMEOUT] = IMR_PSTIMEOUT,
+        .maps[RTL_IMR_BcnInt] = IMR_BCNINT,
+        .maps[RTL_IMR_RXFOVW] = IMR_RXFOVW,
+        .maps[RTL_IMR_RDU] = IMR_RDU,
+        .maps[RTL_IMR_ATIMEND] = IMR_ATIMEND,
+        .maps[RTL_IMR_BDOK] = IMR_BDOK,
+        .maps[RTL_IMR_MGNTDOK] = IMR_MGNTDOK,
+        .maps[RTL_IMR_TBDER] = IMR_TBDER,
+        .maps[RTL_IMR_HIGHDOK] = IMR_HIGHDOK,
+        .maps[RTL_IMR_COMDOK] = IMR_COMDOK,
+        .maps[RTL_IMR_TBDOK] = IMR_TBDOK,
+        .maps[RTL_IMR_BKDOK] = IMR_BKDOK,
+        .maps[RTL_IMR_BEDOK] = IMR_BEDOK,
+        .maps[RTL_IMR_VIDOK] = IMR_VIDOK,
+        .maps[RTL_IMR_VODOK] = IMR_VODOK,
+        .maps[RTL_IMR_ROK] = IMR_ROK,
+        .maps[RTL_IBSS_INT_MASKS] = (IMR_BCNINT | IMR_TBDOK | IMR_TBDER),
+        .maps[RTL_RC_CCK_RATE1M] = DESC92S_RATE1M,
+        .maps[RTL_RC_CCK_RATE2M] = DESC92S_RATE2M,
+        .maps[RTL_RC_CCK_RATE5_5M] = DESC92S_RATE5_5M,
+        .maps[RTL_RC_CCK_RATE11M] = DESC92S_RATE11M,
+        .maps[RTL_RC_OFDM_RATE6M] = DESC92S_RATE6M,
+        .maps[RTL_RC_OFDM_RATE9M] = DESC92S_RATE9M,
+        .maps[RTL_RC_OFDM_RATE12M] = DESC92S_RATE12M,
+        .maps[RTL_RC_OFDM_RATE18M] = DESC92S_RATE18M,
+        .maps[RTL_RC_OFDM_RATE24M] = DESC92S_RATE24M,
+        .maps[RTL_RC_OFDM_RATE36M] = DESC92S_RATE36M,
+        .maps[RTL_RC_OFDM_RATE48M] = DESC92S_RATE48M,
+        .maps[RTL_RC_OFDM_RATE54M] = DESC92S_RATE54M,
+        .maps[RTL_RC_HT_RATEMCS7] = DESC92S_RATEMCS7,
+        .maps[RTL_RC_HT_RATEMCS15] = DESC92S_RATEMCS15,
+};
+static struct pci_device_id rtl92se_pci_ids[] __devinitdata = {
+        {RTL_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8192, rtl92se_hal_cfg)},
+        {RTL_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8171, rtl92se_hal_cfg)},
+        {RTL_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8172, rtl92se_hal_cfg)},
+        {RTL_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8173, rtl92se_hal_cfg)},
+        {RTL_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8174, rtl92se_hal_cfg)},
+        {},
+};
+MODULE_DEVICE_TABLE(pci, rtl92se_pci_ids);
+MODULE_AUTHOR("lizhaoming       <chaoming_li@realsil.com.cn>");
+MODULE_AUTHOR("Realtek WlanFAE  <wlanfae@realtek.com>");
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Realtek 8192S/8191S 802.11n PCI wireless");
+MODULE_FIRMWARE("rtlwifi/rtl8192sefw.bin");
+module_param_named(swenc, rtl92se_mod_params.sw_crypto, bool, 0444);
+module_param_named(ips, rtl92se_mod_params.inactiveps, bool, 0444);
+module_param_named(swlps, rtl92se_mod_params.swctrl_lps, bool, 0444);
+module_param_named(fwlps, rtl92se_mod_params.fwctrl_lps, bool, 0444);
+MODULE_PARM_DESC(swenc, "using hardware crypto (default 0 [hardware])\n");
+MODULE_PARM_DESC(ips, "using no link power save (default 1 is open)\n");
+MODULE_PARM_DESC(swlps, "using linked sw control power save (default 1 is "
+                 "open)\n");
+static struct pci_driver rtl92se_driver = {
+        .name = KBUILD_MODNAME,
+        .id_table = rtl92se_pci_ids,
+        .probe = rtl_pci_probe,
+        .remove = rtl_pci_disconnect,
+#ifdef CONFIG_PM
+        .suspend = rtl_pci_suspend,
+        .resume = rtl_pci_resume,
+#endif
+};
+static int __init rtl92se_module_init(void)
+{
+        int ret = 0;
+        ret = pci_register_driver(&rtl92se_driver);
+        if (ret)
+                RT_ASSERT(false, (": No device found\n"));
+        return ret;
+}
+static void __exit rtl92se_module_exit(void)
+{
+        pci_unregister_driver(&rtl92se_driver);
+}
+module_init(rtl92se_module_init);
+module_exit(rtl92se_module_exit);
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-led.h b/drivers/net/wireless/rtlwifi/rtl8192se/sw.h
index 96f323dc5dd6..fc4eb285a0ac 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-led.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/sw.h
@@ -1,6 +1,6 @@
 /******************************************************************************
 *
- * Copyright(c) 2003 - 2010 Intel Corporation. All rights reserved.
+ * Copyright(c) 2009-2010  Realtek Corporation.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of version 2 of the GNU General Public License as
@@ -19,15 +19,18 @@
 * file called LICENSE.
 *
 * Contact Information:
- *  Intel Linux Wireless <ilw@linux.intel.com>
+ * wlanfae <wlanfae@realtek.com>
- * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
 *
 *****************************************************************************/
+#ifndef __REALTEK_PCI92SE_SW_H__
+#define __REALTEK_PCI92SE_SW_H__
-#ifndef __iwl_agn_led_h__
+#define EFUSE_MAX_SECTION       16
-#define __iwl_agn_led_h__
-extern const struct iwl_led_ops iwlagn_led_ops;
+int rtl92se_init_sw(struct ieee80211_hw *hw);
-void iwlagn_led_enable(struct iwl_priv *priv);
+void rtl92se_deinit_sw(struct ieee80211_hw *hw);
+void rtl92se_init_var_map(struct ieee80211_hw *hw);
-#endif /* __iwl_agn_led_h__ */
+#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/table.c b/drivers/net/wireless/rtlwifi/rtl8192se/table.c
new file mode 100644
index 000000000000..154185b3969d
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/table.c
@@ -0,0 +1,634 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ * Created on  2010/ 5/18,  1:41
+ *****************************************************************************/
+#include "table.h"
+u32 rtl8192sephy_reg_2t2rarray[PHY_REG_2T2RARRAYLENGTH] = {
+        0x01c, 0x07000000,
+        0x800, 0x00040000,
+        0x804, 0x00008003,
+        0x808, 0x0000fc00,
+        0x80c, 0x0000000a,
+        0x810, 0x10005088,
+        0x814, 0x020c3d10,
+        0x818, 0x00200185,
+        0x81c, 0x00000000,
+        0x820, 0x01000000,
+        0x824, 0x00390004,
+        0x828, 0x01000000,
+        0x82c, 0x00390004,
+        0x830, 0x00000004,
+        0x834, 0x00690200,
+        0x838, 0x00000004,
+        0x83c, 0x00690200,
+        0x840, 0x00010000,
+        0x844, 0x00010000,
+        0x848, 0x00000000,
+        0x84c, 0x00000000,
+        0x850, 0x00000000,
+        0x854, 0x00000000,
+        0x858, 0x48484848,
+        0x85c, 0x65a965a9,
+        0x860, 0x0f7f0130,
+        0x864, 0x0f7f0130,
+        0x868, 0x0f7f0130,
+        0x86c, 0x0f7f0130,
+        0x870, 0x03000700,
+        0x874, 0x03000300,
+        0x878, 0x00020002,
+        0x87c, 0x004f0201,
+        0x880, 0xa8300ac1,
+        0x884, 0x00000058,
+        0x888, 0x00000008,
+        0x88c, 0x00000004,
+        0x890, 0x00000000,
+        0x894, 0xfffffffe,
+        0x898, 0x40302010,
+        0x89c, 0x00706050,
+        0x8b0, 0x00000000,
+        0x8e0, 0x00000000,
+        0x8e4, 0x00000000,
+        0xe00, 0x30333333,
+        0xe04, 0x2a2d2e2f,
+        0xe08, 0x00003232,
+        0xe10, 0x30333333,
+        0xe14, 0x2a2d2e2f,
+        0xe18, 0x30333333,
+        0xe1c, 0x2a2d2e2f,
+        0xe30, 0x01007c00,
+        0xe34, 0x01004800,
+        0xe38, 0x1000dc1f,
+        0xe3c, 0x10008c1f,
+        0xe40, 0x021400a0,
+        0xe44, 0x281600a0,
+        0xe48, 0xf8000001,
+        0xe4c, 0x00002910,
+        0xe50, 0x01007c00,
+        0xe54, 0x01004800,
+        0xe58, 0x1000dc1f,
+        0xe5c, 0x10008c1f,
+        0xe60, 0x021400a0,
+        0xe64, 0x281600a0,
+        0xe6c, 0x00002910,
+        0xe70, 0x31ed92fb,
+        0xe74, 0x361536fb,
+        0xe78, 0x361536fb,
+        0xe7c, 0x361536fb,
+        0xe80, 0x361536fb,
+        0xe84, 0x000d92fb,
+        0xe88, 0x000d92fb,
+        0xe8c, 0x31ed92fb,
+        0xed0, 0x31ed92fb,
+        0xed4, 0x31ed92fb,
+        0xed8, 0x000d92fb,
+        0xedc, 0x000d92fb,
+        0xee0, 0x000d92fb,
+        0xee4, 0x015e5448,
+        0xee8, 0x21555448,
+        0x900, 0x00000000,
+        0x904, 0x00000023,
+        0x908, 0x00000000,
+        0x90c, 0x01121313,
+        0xa00, 0x00d047c8,
+        0xa04, 0x80ff0008,
+        0xa08, 0x8ccd8300,
+        0xa0c, 0x2e62120f,
+        0xa10, 0x9500bb78,
+        0xa14, 0x11144028,
+        0xa18, 0x00881117,
+        0xa1c, 0x89140f00,
+        0xa20, 0x1a1b0000,
+        0xa24, 0x090e1317,
+        0xa28, 0x00000204,
+        0xa2c, 0x10d30000,
+        0xc00, 0x40071d40,
+        0xc04, 0x00a05633,
+        0xc08, 0x000000e4,
+        0xc0c, 0x6c6c6c6c,
+        0xc10, 0x08800000,
+        0xc14, 0x40000100,
+        0xc18, 0x08000000,
+        0xc1c, 0x40000100,
+        0xc20, 0x08000000,
+        0xc24, 0x40000100,
+        0xc28, 0x08000000,
+        0xc2c, 0x40000100,
+        0xc30, 0x6de9ac44,
+        0xc34, 0x469652cf,
+        0xc38, 0x49795994,
+        0xc3c, 0x0a979764,
+        0xc40, 0x1f7c403f,
+        0xc44, 0x000100b7,
+        0xc48, 0xec020000,
+        0xc4c, 0x007f037f,
+        0xc50, 0x69543420,
+        0xc54, 0x433c0094,
+        0xc58, 0x69543420,
+        0xc5c, 0x433c0094,
+        0xc60, 0x69543420,
+        0xc64, 0x433c0094,
+        0xc68, 0x69543420,
+        0xc6c, 0x433c0094,
+        0xc70, 0x2c7f000d,
+        0xc74, 0x0186155b,
+        0xc78, 0x0000001f,
+        0xc7c, 0x00b91612,
+        0xc80, 0x40000100,
+        0xc84, 0x20f60000,
+        0xc88, 0x20000080,
+        0xc8c, 0x20200000,
+        0xc90, 0x40000100,
+        0xc94, 0x00000000,
+        0xc98, 0x40000100,
+        0xc9c, 0x00000000,
+        0xca0, 0x00492492,
+        0xca4, 0x00000000,
+        0xca8, 0x00000000,
+        0xcac, 0x00000000,
+        0xcb0, 0x00000000,
+        0xcb4, 0x00000000,
+        0xcb8, 0x00000000,
+        0xcbc, 0x28000000,
+        0xcc0, 0x00000000,
+        0xcc4, 0x00000000,
+        0xcc8, 0x00000000,
+        0xccc, 0x00000000,
+        0xcd0, 0x00000000,
+        0xcd4, 0x00000000,
+        0xcd8, 0x64b22427,
+        0xcdc, 0x00766932,
+        0xce0, 0x00222222,
+        0xce4, 0x00000000,
+        0xce8, 0x37644302,
+        0xcec, 0x2f97d40c,
+        0xd00, 0x00000750,
+        0xd04, 0x00000403,
+        0xd08, 0x0000907f,
+        0xd0c, 0x00000001,
+        0xd10, 0xa0633333,
+        0xd14, 0x33333c63,
+        0xd18, 0x6a8f5b6b,
+        0xd1c, 0x00000000,
+        0xd20, 0x00000000,
+        0xd24, 0x00000000,
+        0xd28, 0x00000000,
+        0xd2c, 0xcc979975,
+        0xd30, 0x00000000,
+        0xd34, 0x00000000,
+        0xd38, 0x00000000,
+        0xd3c, 0x00027293,
+        0xd40, 0x00000000,
+        0xd44, 0x00000000,
+        0xd48, 0x00000000,
+        0xd50, 0x6437140a,
+        0xd54, 0x024dbd02,
+        0xd58, 0x00000000,
+        0xd5c, 0x30032064,
+        0xd60, 0x4653de68,
+        0xd64, 0x00518a3c,
+        0xd68, 0x00002101,
+        0xf14, 0x00000003,
+        0xf4c, 0x00000000,
+        0xf00, 0x00000300,
+};
+u32 rtl8192sephy_changeto_1t1rarray[PHY_CHANGETO_1T1RARRAYLENGTH] = {
+        0x844, 0xffffffff, 0x00010000,
+        0x804, 0x0000000f, 0x00000001,
+        0x824, 0x00f0000f, 0x00300004,
+        0x82c, 0x00f0000f, 0x00100002,
+        0x870, 0x04000000, 0x00000001,
+        0x864, 0x00000400, 0x00000000,
+        0x878, 0x000f000f, 0x00000002,
+        0xe74, 0x0f000000, 0x00000002,
+        0xe78, 0x0f000000, 0x00000002,
+        0xe7c, 0x0f000000, 0x00000002,
+        0xe80, 0x0f000000, 0x00000002,
+        0x90c, 0x000000ff, 0x00000011,
+        0xc04, 0x000000ff, 0x00000011,
+        0xd04, 0x0000000f, 0x00000001,
+        0x1f4, 0xffff0000, 0x00007777,
+        0x234, 0xf8000000, 0x0000000a,
+};
+u32 rtl8192sephy_changeto_1t2rarray[PHY_CHANGETO_1T2RARRAYLENGTH] = {
+        0x804, 0x0000000f, 0x00000003,
+        0x824, 0x00f0000f, 0x00300004,
+        0x82c, 0x00f0000f, 0x00300002,
+        0x870, 0x04000000, 0x00000001,
+        0x864, 0x00000400, 0x00000000,
+        0x878, 0x000f000f, 0x00000002,
+        0xe74, 0x0f000000, 0x00000002,
+        0xe78, 0x0f000000, 0x00000002,
+        0xe7c, 0x0f000000, 0x00000002,
+        0xe80, 0x0f000000, 0x00000002,
+        0x90c, 0x000000ff, 0x00000011,
+        0xc04, 0x000000ff, 0x00000033,
+        0xd04, 0x0000000f, 0x00000003,
+        0x1f4, 0xffff0000, 0x00007777,
+        0x234, 0xf8000000, 0x0000000a,
+};
+u32 rtl8192sephy_reg_array_pg[PHY_REG_ARRAY_PGLENGTH] = {
+        0xe00, 0xffffffff, 0x06090909,
+        0xe04, 0xffffffff, 0x00030406,
+        0xe08, 0x0000ff00, 0x00000000,
+        0xe10, 0xffffffff, 0x0a0c0d0e,
+        0xe14, 0xffffffff, 0x04070809,
+        0xe18, 0xffffffff, 0x0a0c0d0e,
+        0xe1c, 0xffffffff, 0x04070809,
+        0xe00, 0xffffffff, 0x04040404,
+        0xe04, 0xffffffff, 0x00020204,
+        0xe08, 0x0000ff00, 0x00000000,
+        0xe10, 0xffffffff, 0x02040404,
+        0xe14, 0xffffffff, 0x00000002,
+        0xe18, 0xffffffff, 0x02040404,
+        0xe1c, 0xffffffff, 0x00000002,
+        0xe00, 0xffffffff, 0x04040404,
+        0xe04, 0xffffffff, 0x00020204,
+        0xe08, 0x0000ff00, 0x00000000,
+        0xe10, 0xffffffff, 0x02040404,
+        0xe14, 0xffffffff, 0x00000002,
+        0xe18, 0xffffffff, 0x02040404,
+        0xe1c, 0xffffffff, 0x00000002,
+        0xe00, 0xffffffff, 0x02020202,
+        0xe04, 0xffffffff, 0x00020202,
+        0xe08, 0x0000ff00, 0x00000000,
+        0xe10, 0xffffffff, 0x02020202,
+        0xe14, 0xffffffff, 0x00000002,
+        0xe18, 0xffffffff, 0x02020202,
+        0xe1c, 0xffffffff, 0x00000002,
+};
+u32 rtl8192seradioa_1t_array[RADIOA_1T_ARRAYLENGTH] = {
+        0x000, 0x00030159,
+        0x001, 0x00030250,
+        0x002, 0x00010000,
+        0x010, 0x0008000f,
+        0x011, 0x000231fc,
+        0x010, 0x000c000f,
+        0x011, 0x0003f9f8,
+        0x010, 0x0002000f,
+        0x011, 0x00020101,
+        0x014, 0x0001093e,
+        0x014, 0x0009093e,
+        0x015, 0x0000f8f4,
+        0x017, 0x000f6500,
+        0x01a, 0x00013056,
+        0x01b, 0x00060000,
+        0x01c, 0x00000300,
+        0x01e, 0x00031059,
+        0x021, 0x00054000,
+        0x022, 0x0000083c,
+        0x023, 0x00001558,
+        0x024, 0x00000060,
+        0x025, 0x00022583,
+        0x026, 0x0000f200,
+        0x027, 0x000eacf1,
+        0x028, 0x0009bd54,
+        0x029, 0x00004582,
+        0x02a, 0x00000001,
+        0x02b, 0x00021334,
+        0x02a, 0x00000000,
+        0x02b, 0x0000000a,
+        0x02a, 0x00000001,
+        0x02b, 0x00000808,
+        0x02b, 0x00053333,
+        0x02c, 0x0000000c,
+        0x02a, 0x00000002,
+        0x02b, 0x00000808,
+        0x02b, 0x0005b333,
+        0x02c, 0x0000000d,
+        0x02a, 0x00000003,
+        0x02b, 0x00000808,
+        0x02b, 0x00063333,
+        0x02c, 0x0000000d,
+        0x02a, 0x00000004,
+        0x02b, 0x00000808,
+        0x02b, 0x0006b333,
+        0x02c, 0x0000000d,
+        0x02a, 0x00000005,
+        0x02b, 0x00000709,
+        0x02b, 0x00053333,
+        0x02c, 0x0000000d,
+        0x02a, 0x00000006,
+        0x02b, 0x00000709,
+        0x02b, 0x0005b333,
+        0x02c, 0x0000000d,
+        0x02a, 0x00000007,
+        0x02b, 0x00000709,
+        0x02b, 0x00063333,
+        0x02c, 0x0000000d,
+        0x02a, 0x00000008,
+        0x02b, 0x00000709,
+        0x02b, 0x0006b333,
+        0x02c, 0x0000000d,
+        0x02a, 0x00000009,
+        0x02b, 0x0000060a,
+        0x02b, 0x00053333,
+        0x02c, 0x0000000d,
+        0x02a, 0x0000000a,
+        0x02b, 0x0000060a,
+        0x02b, 0x0005b333,
+        0x02c, 0x0000000d,
+        0x02a, 0x0000000b,
+        0x02b, 0x0000060a,
+        0x02b, 0x00063333,
+        0x02c, 0x0000000d,
+        0x02a, 0x0000000c,
+        0x02b, 0x0000060a,
+        0x02b, 0x0006b333,
+        0x02c, 0x0000000d,
+        0x02a, 0x0000000d,
+        0x02b, 0x0000050b,
+        0x02b, 0x00053333,
+        0x02c, 0x0000000d,
+        0x02a, 0x0000000e,
+        0x02b, 0x0000050b,
+        0x02b, 0x00066623,
+        0x02c, 0x0000001a,
+        0x02a, 0x000e4000,
+        0x030, 0x00020000,
+        0x031, 0x000b9631,
+        0x032, 0x0000130d,
+        0x033, 0x00000187,
+        0x013, 0x00019e6c,
+        0x013, 0x00015e94,
+        0x000, 0x00010159,
+        0x018, 0x0000f401,
+        0x0fe, 0x00000000,
+        0x01e, 0x0003105b,
+        0x0fe, 0x00000000,
+        0x000, 0x00030159,
+        0x010, 0x0004000f,
+        0x011, 0x000203f9,
+};
+u32 rtl8192seradiob_array[RADIOB_ARRAYLENGTH] = {
+        0x000, 0x00030159,
+        0x001, 0x00001041,
+        0x002, 0x00011000,
+        0x005, 0x00080fc0,
+        0x007, 0x000fc803,
+        0x013, 0x00017cb0,
+        0x013, 0x00011cc0,
+        0x013, 0x0000dc60,
+        0x013, 0x00008c60,
+        0x013, 0x00004450,
+        0x013, 0x00000020,
+};
+u32 rtl8192seradiob_gm_array[RADIOB_GM_ARRAYLENGTH] = {
+        0x000, 0x00030159,
+        0x001, 0x00001041,
+        0x002, 0x00011000,
+        0x005, 0x00080fc0,
+        0x007, 0x000fc803,
+};
+u32 rtl8192semac_2t_array[MAC_2T_ARRAYLENGTH] = {
+        0x020, 0x00000035,
+        0x048, 0x0000000e,
+        0x049, 0x000000f0,
+        0x04a, 0x00000077,
+        0x04b, 0x00000083,
+        0x0b5, 0x00000021,
+        0x0dc, 0x000000ff,
+        0x0dd, 0x000000ff,
+        0x0de, 0x000000ff,
+        0x0df, 0x000000ff,
+        0x116, 0x00000000,
+        0x117, 0x00000000,
+        0x118, 0x00000000,
+        0x119, 0x00000000,
+        0x11a, 0x00000000,
+        0x11b, 0x00000000,
+        0x11c, 0x00000000,
+        0x11d, 0x00000000,
+        0x160, 0x0000000b,
+        0x161, 0x0000000b,
+        0x162, 0x0000000b,
+        0x163, 0x0000000b,
+        0x164, 0x0000000b,
+        0x165, 0x0000000b,
+        0x166, 0x0000000b,
+        0x167, 0x0000000b,
+        0x168, 0x0000000b,
+        0x169, 0x0000000b,
+        0x16a, 0x0000000b,
+        0x16b, 0x0000000b,
+        0x16c, 0x0000000b,
+        0x16d, 0x0000000b,
+        0x16e, 0x0000000b,
+        0x16f, 0x0000000b,
+        0x170, 0x0000000b,
+        0x171, 0x0000000b,
+        0x172, 0x0000000b,
+        0x173, 0x0000000b,
+        0x174, 0x0000000b,
+        0x175, 0x0000000b,
+        0x176, 0x0000000b,
+        0x177, 0x0000000b,
+        0x178, 0x0000000b,
+        0x179, 0x0000000b,
+        0x17a, 0x0000000b,
+        0x17b, 0x0000000b,
+        0x17c, 0x0000000b,
+        0x17d, 0x0000000b,
+        0x17e, 0x0000000b,
+        0x17f, 0x0000000b,
+        0x236, 0x0000000c,
+        0x503, 0x00000022,
+        0x560, 0x00000000,
+};
+u32 rtl8192seagctab_array[AGCTAB_ARRAYLENGTH] = {
+        0xc78, 0x7f000001,
+        0xc78, 0x7f010001,
+        0xc78, 0x7e020001,
+        0xc78, 0x7d030001,
+        0xc78, 0x7c040001,
+        0xc78, 0x7b050001,
+        0xc78, 0x7a060001,
+        0xc78, 0x79070001,
+        0xc78, 0x78080001,
+        0xc78, 0x77090001,
+        0xc78, 0x760a0001,
+        0xc78, 0x750b0001,
+        0xc78, 0x740c0001,
+        0xc78, 0x730d0001,
+        0xc78, 0x720e0001,
+        0xc78, 0x710f0001,
+        0xc78, 0x70100001,
+        0xc78, 0x6f110001,
+        0xc78, 0x6f120001,
+        0xc78, 0x6e130001,
+        0xc78, 0x6d140001,
+        0xc78, 0x6d150001,
+        0xc78, 0x6c160001,
+        0xc78, 0x6b170001,
+        0xc78, 0x6a180001,
+        0xc78, 0x6a190001,
+        0xc78, 0x691a0001,
+        0xc78, 0x681b0001,
+        0xc78, 0x671c0001,
+        0xc78, 0x661d0001,
+        0xc78, 0x651e0001,
+        0xc78, 0x641f0001,
+        0xc78, 0x63200001,
+        0xc78, 0x4c210001,
+        0xc78, 0x4b220001,
+        0xc78, 0x4a230001,
+        0xc78, 0x49240001,
+        0xc78, 0x48250001,
+        0xc78, 0x47260001,
+        0xc78, 0x46270001,
+        0xc78, 0x45280001,
+        0xc78, 0x44290001,
+        0xc78, 0x2c2a0001,
+        0xc78, 0x2b2b0001,
+        0xc78, 0x2a2c0001,
+        0xc78, 0x292d0001,
+        0xc78, 0x282e0001,
+        0xc78, 0x272f0001,
+        0xc78, 0x26300001,
+        0xc78, 0x25310001,
+        0xc78, 0x24320001,
+        0xc78, 0x23330001,
+        0xc78, 0x22340001,
+        0xc78, 0x09350001,
+        0xc78, 0x08360001,
+        0xc78, 0x07370001,
+        0xc78, 0x06380001,
+        0xc78, 0x05390001,
+        0xc78, 0x043a0001,
+        0xc78, 0x033b0001,
+        0xc78, 0x023c0001,
+        0xc78, 0x013d0001,
+        0xc78, 0x003e0001,
+        0xc78, 0x003f0001,
+        0xc78, 0x7f400001,
+        0xc78, 0x7f410001,
+        0xc78, 0x7e420001,
+        0xc78, 0x7d430001,
+        0xc78, 0x7c440001,
+        0xc78, 0x7b450001,
+        0xc78, 0x7a460001,
+        0xc78, 0x79470001,
+        0xc78, 0x78480001,
+        0xc78, 0x77490001,
+        0xc78, 0x764a0001,
+        0xc78, 0x754b0001,
+        0xc78, 0x744c0001,
+        0xc78, 0x734d0001,
+        0xc78, 0x724e0001,
+        0xc78, 0x714f0001,
+        0xc78, 0x70500001,
+        0xc78, 0x6f510001,
+        0xc78, 0x6f520001,
+        0xc78, 0x6e530001,
+        0xc78, 0x6d540001,
+        0xc78, 0x6d550001,
+        0xc78, 0x6c560001,
+        0xc78, 0x6b570001,
+        0xc78, 0x6a580001,
+        0xc78, 0x6a590001,
+        0xc78, 0x695a0001,
+        0xc78, 0x685b0001,
+        0xc78, 0x675c0001,
+        0xc78, 0x665d0001,
+        0xc78, 0x655e0001,
+        0xc78, 0x645f0001,
+        0xc78, 0x63600001,
+        0xc78, 0x4c610001,
+        0xc78, 0x4b620001,
+        0xc78, 0x4a630001,
+        0xc78, 0x49640001,
+        0xc78, 0x48650001,
+        0xc78, 0x47660001,
+        0xc78, 0x46670001,
+        0xc78, 0x45680001,
+        0xc78, 0x44690001,
+        0xc78, 0x2c6a0001,
+        0xc78, 0x2b6b0001,
+        0xc78, 0x2a6c0001,
+        0xc78, 0x296d0001,
+        0xc78, 0x286e0001,
+        0xc78, 0x276f0001,
+        0xc78, 0x26700001,
+        0xc78, 0x25710001,
+        0xc78, 0x24720001,
+        0xc78, 0x23730001,
+        0xc78, 0x22740001,
+        0xc78, 0x09750001,
+        0xc78, 0x08760001,
+        0xc78, 0x07770001,
+        0xc78, 0x06780001,
+        0xc78, 0x05790001,
+        0xc78, 0x047a0001,
+        0xc78, 0x037b0001,
+        0xc78, 0x027c0001,
+        0xc78, 0x017d0001,
+        0xc78, 0x007e0001,
+        0xc78, 0x007f0001,
+        0xc78, 0x3000001e,
+        0xc78, 0x3001001e,
+        0xc78, 0x3002001e,
+        0xc78, 0x3003001e,
+        0xc78, 0x3004001e,
+        0xc78, 0x3405001e,
+        0xc78, 0x3806001e,
+        0xc78, 0x3e07001e,
+        0xc78, 0x3e08001e,
+        0xc78, 0x4409001e,
+        0xc78, 0x460a001e,
+        0xc78, 0x480b001e,
+        0xc78, 0x480c001e,
+        0xc78, 0x4e0d001e,
+        0xc78, 0x560e001e,
+        0xc78, 0x5a0f001e,
+        0xc78, 0x5e10001e,
+        0xc78, 0x6211001e,
+        0xc78, 0x6c12001e,
+        0xc78, 0x7213001e,
+        0xc78, 0x7214001e,
+        0xc78, 0x7215001e,
+        0xc78, 0x7216001e,
+        0xc78, 0x7217001e,
+        0xc78, 0x7218001e,
+        0xc78, 0x7219001e,
+        0xc78, 0x721a001e,
+        0xc78, 0x721b001e,
+        0xc78, 0x721c001e,
+        0xc78, 0x721d001e,
+        0xc78, 0x721e001e,
+        0xc78, 0x721f001e,
+};
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/table.h b/drivers/net/wireless/rtlwifi/rtl8192se/table.h
new file mode 100644
index 000000000000..b4ed6d951ebb
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/table.h
@@ -0,0 +1,49 @@
+/******************************************************************************
+ * Copyright(c) 2008 - 2010 Realtek Corporation. All rights reserved.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ ******************************************************************************/
+#ifndef __INC_HAL8192SE_FW_IMG_H
+#define __INC_HAL8192SE_FW_IMG_H
+#include <linux/types.h>
+/*Created on  2010/ 4/12,  5:56*/
+#define PHY_REG_2T2RARRAYLENGTH 372
+extern u32 rtl8192sephy_reg_2t2rarray[PHY_REG_2T2RARRAYLENGTH];
+#define PHY_CHANGETO_1T1RARRAYLENGTH 48
+extern u32 rtl8192sephy_changeto_1t1rarray[PHY_CHANGETO_1T1RARRAYLENGTH];
+#define PHY_CHANGETO_1T2RARRAYLENGTH 45
+extern u32 rtl8192sephy_changeto_1t2rarray[PHY_CHANGETO_1T2RARRAYLENGTH];
+#define PHY_REG_ARRAY_PGLENGTH 84
+extern u32 rtl8192sephy_reg_array_pg[PHY_REG_ARRAY_PGLENGTH];
+#define RADIOA_1T_ARRAYLENGTH 202
+extern u32 rtl8192seradioa_1t_array[RADIOA_1T_ARRAYLENGTH];
+#define RADIOB_ARRAYLENGTH 22
+extern u32 rtl8192seradiob_array[RADIOB_ARRAYLENGTH];
+#define RADIOB_GM_ARRAYLENGTH 10
+extern u32 rtl8192seradiob_gm_array[RADIOB_GM_ARRAYLENGTH];
+#define MAC_2T_ARRAYLENGTH 106
+extern u32 rtl8192semac_2t_array[MAC_2T_ARRAYLENGTH];
+#define AGCTAB_ARRAYLENGTH 320
+extern u32 rtl8192seagctab_array[AGCTAB_ARRAYLENGTH];
+#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c
new file mode 100644
index 000000000000..5cf442373d46
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c
@@ -0,0 +1,976 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#include "../wifi.h"
+#include "../pci.h"
+#include "../base.h"
+#include "reg.h"
+#include "def.h"
+#include "phy.h"
+#include "fw.h"
+#include "trx.h"
+#include "led.h"
+static u8 _rtl92se_map_hwqueue_to_fwqueue(struct sk_buff *skb,  u8 skb_queue)
+{
+        __le16 fc = rtl_get_fc(skb);
+        if (unlikely(ieee80211_is_beacon(fc)))
+                return QSLT_BEACON;
+        if (ieee80211_is_mgmt(fc))
+                return QSLT_MGNT;
+        if (ieee80211_is_nullfunc(fc))
+                return QSLT_HIGH;
+        return skb->priority;
+}
+static int _rtl92se_rate_mapping(bool isht, u8 desc_rate, bool first_ampdu)
+{
+        int rate_idx = 0;
+        if (first_ampdu) {
+                if (false == isht) {
+                        switch (desc_rate) {
+                        case DESC92S_RATE1M:
+                                rate_idx = 0;
+                                break;
+                        case DESC92S_RATE2M:
+                                rate_idx = 1;
+                                break;
+                        case DESC92S_RATE5_5M:
+                                rate_idx = 2;
+                                break;
+                        case DESC92S_RATE11M:
+                                rate_idx = 3;
+                                break;
+                        case DESC92S_RATE6M:
+                                rate_idx = 4;
+                                break;
+                        case DESC92S_RATE9M:
+                                rate_idx = 5;
+                                break;
+                        case DESC92S_RATE12M:
+                                rate_idx = 6;
+                                break;
+                        case DESC92S_RATE18M:
+                                rate_idx = 7;
+                                break;
+                        case DESC92S_RATE24M:
+                                rate_idx = 8;
+                                break;
+                        case DESC92S_RATE36M:
+                                rate_idx = 9;
+                                break;
+                        case DESC92S_RATE48M:
+                                rate_idx = 10;
+                                break;
+                        case DESC92S_RATE54M:
+                                rate_idx = 11;
+                                break;
+                        default:
+                                rate_idx = 0;
+                                break;
+                        }
+                } else {
+                        rate_idx = 11;
+                }
+                return rate_idx;
+        }
+        switch (desc_rate) {
+        case DESC92S_RATE1M:
+                rate_idx = 0;
+                break;
+        case DESC92S_RATE2M:
+                rate_idx = 1;
+                break;
+        case DESC92S_RATE5_5M:
+                rate_idx = 2;
+                break;
+        case DESC92S_RATE11M:
+                rate_idx = 3;
+                break;
+        case DESC92S_RATE6M:
+                rate_idx = 4;
+                break;
+        case DESC92S_RATE9M:
+                rate_idx = 5;
+                break;
+        case DESC92S_RATE12M:
+                rate_idx = 6;
+                break;
+        case DESC92S_RATE18M:
+                rate_idx = 7;
+                break;
+        case DESC92S_RATE24M:
+                rate_idx = 8;
+                break;
+        case DESC92S_RATE36M:
+                rate_idx = 9;
+                break;
+        case DESC92S_RATE48M:
+                rate_idx = 10;
+                break;
+        case DESC92S_RATE54M:
+                rate_idx = 11;
+                break;
+        default:
+                rate_idx = 11;
+                break;
+        }
+        return rate_idx;
+}
+static u8 _rtl92s_query_rxpwrpercentage(char antpower)
+{
+        if ((antpower <= -100) || (antpower >= 20))
+                return 0;
+        else if (antpower >= 0)
+                return 100;
+        else
+                return 100 + antpower;
+}
+static u8 _rtl92s_evm_db_to_percentage(char value)
+{
+        char ret_val;
+        ret_val = value;
+        if (ret_val >= 0)
+                ret_val = 0;
+        if (ret_val <= -33)
+                ret_val = -33;
+        ret_val = 0 - ret_val;
+        ret_val *= 3;
+        if (ret_val == 99)
+                ret_val = 100;
+        return ret_val;
+}
+static long _rtl92se_translate_todbm(struct ieee80211_hw *hw,
+                                     u8 signal_strength_index)
+{
+        long signal_power;
+        signal_power = (long)((signal_strength_index + 1) >> 1);
+        signal_power -= 95;
+        return signal_power;
+}
+static long _rtl92se_signal_scale_mapping(struct ieee80211_hw *hw,
+                long currsig)
+{
+        long retsig = 0;
+        /* Step 1. Scale mapping. */
+        if (currsig > 47)
+                retsig = 100;
+        else if (currsig > 14 && currsig <= 47)
+                retsig = 100 - ((47 - currsig) * 3) / 2;
+        else if (currsig > 2 && currsig <= 14)
+                retsig = 48 - ((14 - currsig) * 15) / 7;
+        else if (currsig >= 0)
+                retsig = currsig * 9 + 1;
+        return retsig;
+}
+static void _rtl92se_query_rxphystatus(struct ieee80211_hw *hw,
+                                       struct rtl_stats *pstats, u8 *pdesc,
+                                       struct rx_fwinfo *p_drvinfo,
+                                       bool packet_match_bssid,
+                                       bool packet_toself,
+                                       bool packet_beacon)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct phy_sts_cck_8192s_t *cck_buf;
+        s8 rx_pwr_all = 0, rx_pwr[4];
+        u8 rf_rx_num = 0, evm, pwdb_all;
+        u8 i, max_spatial_stream;
+        u32 rssi, total_rssi = 0;
+        bool in_powersavemode = false;
+        bool is_cck_rate;
+        is_cck_rate = RX_HAL_IS_CCK_RATE(pdesc);
+        pstats->packet_matchbssid = packet_match_bssid;
+        pstats->packet_toself = packet_toself;
+        pstats->is_cck = is_cck_rate;
+        pstats->packet_beacon = packet_beacon;
+        pstats->is_cck = is_cck_rate;
+        pstats->rx_mimo_signalquality[0] = -1;
+        pstats->rx_mimo_signalquality[1] = -1;
+        if (is_cck_rate) {
+                u8 report, cck_highpwr;
+                cck_buf = (struct phy_sts_cck_8192s_t *)p_drvinfo;
+                if (!in_powersavemode)
+                        cck_highpwr = (u8) rtl_get_bbreg(hw,
+                                                RFPGA0_XA_HSSIPARAMETER2,
+                                                0x200);
+                else
+                        cck_highpwr = false;
+                if (!cck_highpwr) {
+                        u8 cck_agc_rpt = cck_buf->cck_agc_rpt;
+                        report = cck_buf->cck_agc_rpt & 0xc0;
+                        report = report >> 6;
+                        switch (report) {
+                        case 0x3:
+                                rx_pwr_all = -40 - (cck_agc_rpt & 0x3e);
+                                break;
+                        case 0x2:
+                                rx_pwr_all = -20 - (cck_agc_rpt & 0x3e);
+                                break;
+                        case 0x1:
+                                rx_pwr_all = -2 - (cck_agc_rpt & 0x3e);
+                                break;
+                        case 0x0:
+                                rx_pwr_all = 14 - (cck_agc_rpt & 0x3e);
+                                break;
+                        }
+                } else {
+                        u8 cck_agc_rpt = cck_buf->cck_agc_rpt;
+                        report = p_drvinfo->cfosho[0] & 0x60;
+                        report = report >> 5;
+                        switch (report) {
+                        case 0x3:
+                                rx_pwr_all = -40 - ((cck_agc_rpt & 0x1f) << 1);
+                                break;
+                        case 0x2:
+                                rx_pwr_all = -20 - ((cck_agc_rpt & 0x1f) << 1);
+                                break;
+                        case 0x1:
+                                rx_pwr_all = -2 - ((cck_agc_rpt & 0x1f) << 1);
+                                break;
+                        case 0x0:
+                                rx_pwr_all = 14 - ((cck_agc_rpt & 0x1f) << 1);
+                                break;
+                        }
+                }
+                pwdb_all = _rtl92s_query_rxpwrpercentage(rx_pwr_all);
+                /* CCK gain is smaller than OFDM/MCS gain,  */
+                /* so we add gain diff by experiences, the val is 6 */
+                pwdb_all += 6;
+                if (pwdb_all > 100)
+                        pwdb_all = 100;
+                /* modify the offset to make the same gain index with OFDM. */
+                if (pwdb_all > 34 && pwdb_all <= 42)
+                        pwdb_all -= 2;
+                else if (pwdb_all > 26 && pwdb_all <= 34)
+                        pwdb_all -= 6;
+                else if (pwdb_all > 14 && pwdb_all <= 26)
+                        pwdb_all -= 8;
+                else if (pwdb_all > 4 && pwdb_all <= 14)
+                        pwdb_all -= 4;
+                pstats->rx_pwdb_all = pwdb_all;
+                pstats->recvsignalpower = rx_pwr_all;
+                if (packet_match_bssid) {
+                        u8 sq;
+                        if (pstats->rx_pwdb_all > 40) {
+                                sq = 100;
+                        } else {
+                                sq = cck_buf->sq_rpt;
+                                if (sq > 64)
+                                        sq = 0;
+                                else if (sq < 20)
+                                        sq = 100;
+                                else
+                                        sq = ((64 - sq) * 100) / 44;
+                        }
+                        pstats->signalquality = sq;
+                        pstats->rx_mimo_signalquality[0] = sq;
+                        pstats->rx_mimo_signalquality[1] = -1;
+                }
+        } else {
+                rtlpriv->dm.rfpath_rxenable[0] =
+                    rtlpriv->dm.rfpath_rxenable[1] = true;
+                for (i = RF90_PATH_A; i < RF90_PATH_MAX; i++) {
+                        if (rtlpriv->dm.rfpath_rxenable[i])
+                                rf_rx_num++;
+                        rx_pwr[i] = ((p_drvinfo->gain_trsw[i] &
+                                    0x3f) * 2) - 110;
+                        rssi = _rtl92s_query_rxpwrpercentage(rx_pwr[i]);
+                        total_rssi += rssi;
+                        rtlpriv->stats.rx_snr_db[i] =
+                                         (long)(p_drvinfo->rxsnr[i] / 2);
+                        if (packet_match_bssid)
+                                pstats->rx_mimo_signalstrength[i] = (u8) rssi;
+                }
+                rx_pwr_all = ((p_drvinfo->pwdb_all >> 1) & 0x7f) - 110;
+                pwdb_all = _rtl92s_query_rxpwrpercentage(rx_pwr_all);
+                pstats->rx_pwdb_all = pwdb_all;
+                pstats->rxpower = rx_pwr_all;
+                pstats->recvsignalpower = rx_pwr_all;
+                if (GET_RX_STATUS_DESC_RX_HT(pdesc) &&
+                        GET_RX_STATUS_DESC_RX_MCS(pdesc) >= DESC92S_RATEMCS8 &&
+                    GET_RX_STATUS_DESC_RX_MCS(pdesc) <= DESC92S_RATEMCS15)
+                        max_spatial_stream = 2;
+                else
+                        max_spatial_stream = 1;
+                for (i = 0; i < max_spatial_stream; i++) {
+                        evm = _rtl92s_evm_db_to_percentage(p_drvinfo->rxevm[i]);
+                        if (packet_match_bssid) {
+                                if (i == 0)
+                                        pstats->signalquality = (u8)(evm &
+                                                                 0xff);
+                                pstats->rx_mimo_signalquality[i] =
+                                                         (u8) (evm & 0xff);
+                        }
+                }
+        }
+        if (is_cck_rate)
+                pstats->signalstrength = (u8)(_rtl92se_signal_scale_mapping(hw,
+                                         pwdb_all));
+        else if (rf_rx_num != 0)
+                pstats->signalstrength = (u8) (_rtl92se_signal_scale_mapping(hw,
+                                total_rssi /= rf_rx_num));
+}
+static void _rtl92se_process_ui_rssi(struct ieee80211_hw *hw,
+                                     struct rtl_stats *pstats)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_phy *rtlphy = &(rtlpriv->phy);
+        u8 rfpath;
+        u32 last_rssi, tmpval;
+        if (pstats->packet_toself || pstats->packet_beacon) {
+                rtlpriv->stats.rssi_calculate_cnt++;
+                if (rtlpriv->stats.ui_rssi.total_num++ >=
+                    PHY_RSSI_SLID_WIN_MAX) {
+                        rtlpriv->stats.ui_rssi.total_num =
+                                         PHY_RSSI_SLID_WIN_MAX;
+                        last_rssi = rtlpriv->stats.ui_rssi.elements[
+                                rtlpriv->stats.ui_rssi.index];
+                        rtlpriv->stats.ui_rssi.total_val -= last_rssi;
+                }
+                rtlpriv->stats.ui_rssi.total_val += pstats->signalstrength;
+                rtlpriv->stats.ui_rssi.elements[rtlpriv->stats.ui_rssi.index++]
+                         = pstats->signalstrength;
+                if (rtlpriv->stats.ui_rssi.index >= PHY_RSSI_SLID_WIN_MAX)
+                        rtlpriv->stats.ui_rssi.index = 0;
+                tmpval = rtlpriv->stats.ui_rssi.total_val /
+                        rtlpriv->stats.ui_rssi.total_num;
+                rtlpriv->stats.signal_strength = _rtl92se_translate_todbm(hw,
+                                                                (u8) tmpval);
+                pstats->rssi = rtlpriv->stats.signal_strength;
+        }
+        if (!pstats->is_cck && pstats->packet_toself) {
+                for (rfpath = RF90_PATH_A; rfpath < rtlphy->num_total_rfpath;
+                     rfpath++) {
+                        if (rtlpriv->stats.rx_rssi_percentage[rfpath] == 0) {
+                                rtlpriv->stats.rx_rssi_percentage[rfpath] =
+                                    pstats->rx_mimo_signalstrength[rfpath];
+                        }
+                        if (pstats->rx_mimo_signalstrength[rfpath] >
+                            rtlpriv->stats.rx_rssi_percentage[rfpath]) {
+                                rtlpriv->stats.rx_rssi_percentage[rfpath] =
+                                    ((rtlpriv->stats.rx_rssi_percentage[rfpath]
+                                    * (RX_SMOOTH_FACTOR - 1)) +
+                                    (pstats->rx_mimo_signalstrength[rfpath])) /
+                                    (RX_SMOOTH_FACTOR);
+                                rtlpriv->stats.rx_rssi_percentage[rfpath] =
+                                    rtlpriv->stats.rx_rssi_percentage[rfpath]
+                                    + 1;
+                        } else {
+                                rtlpriv->stats.rx_rssi_percentage[rfpath] =
+                                    ((rtlpriv->stats.rx_rssi_percentage[rfpath]
+                                    * (RX_SMOOTH_FACTOR - 1)) +
+                                    (pstats->rx_mimo_signalstrength[rfpath])) /
+                                    (RX_SMOOTH_FACTOR);
+                        }
+                }
+        }
+}
+static void _rtl92se_update_rxsignalstatistics(struct ieee80211_hw *hw,
+                                               struct rtl_stats *pstats)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        int weighting = 0;
+        if (rtlpriv->stats.recv_signal_power == 0)
+                rtlpriv->stats.recv_signal_power = pstats->recvsignalpower;
+        if (pstats->recvsignalpower > rtlpriv->stats.recv_signal_power)
+                weighting = 5;
+        else if (pstats->recvsignalpower < rtlpriv->stats.recv_signal_power)
+                weighting = (-5);
+        rtlpriv->stats.recv_signal_power = (rtlpriv->stats.recv_signal_power * 5
+                                           + pstats->recvsignalpower +
+                                           weighting) / 6;
+}
+static void _rtl92se_process_pwdb(struct ieee80211_hw *hw,
+                                  struct rtl_stats *pstats)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        long undec_sm_pwdb = 0;
+        if (mac->opmode == NL80211_IFTYPE_ADHOC) {
+                return;
+        } else {
+                undec_sm_pwdb =
+                    rtlpriv->dm.undecorated_smoothed_pwdb;
+        }
+        if (pstats->packet_toself || pstats->packet_beacon) {
+                if (undec_sm_pwdb < 0)
+                        undec_sm_pwdb = pstats->rx_pwdb_all;
+                if (pstats->rx_pwdb_all > (u32) undec_sm_pwdb) {
+                        undec_sm_pwdb =
+                            (((undec_sm_pwdb) *
+                            (RX_SMOOTH_FACTOR - 1)) +
+                            (pstats->rx_pwdb_all)) / (RX_SMOOTH_FACTOR);
+                        undec_sm_pwdb = undec_sm_pwdb + 1;
+                } else {
+                        undec_sm_pwdb = (((undec_sm_pwdb) *
+                              (RX_SMOOTH_FACTOR - 1)) + (pstats->rx_pwdb_all)) /
+                              (RX_SMOOTH_FACTOR);
+                }
+                rtlpriv->dm.undecorated_smoothed_pwdb = undec_sm_pwdb;
+                _rtl92se_update_rxsignalstatistics(hw, pstats);
+        }
+}
+static void rtl_92s_process_streams(struct ieee80211_hw *hw,
+                                    struct rtl_stats *pstats)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u32 stream;
+        for (stream = 0; stream < 2; stream++) {
+                if (pstats->rx_mimo_signalquality[stream] != -1) {
+                        if (rtlpriv->stats.rx_evm_percentage[stream] == 0) {
+                                rtlpriv->stats.rx_evm_percentage[stream] =
+                                    pstats->rx_mimo_signalquality[stream];
+                        }
+                        rtlpriv->stats.rx_evm_percentage[stream] =
+                            ((rtlpriv->stats.rx_evm_percentage[stream] *
+                                        (RX_SMOOTH_FACTOR - 1)) +
+                             (pstats->rx_mimo_signalquality[stream] *
+                                        1)) / (RX_SMOOTH_FACTOR);
+                }
+        }
+}
+static void _rtl92se_process_ui_link_quality(struct ieee80211_hw *hw,
+                                             struct rtl_stats *pstats)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        u32 last_evm = 0, tmpval;
+        if (pstats->signalquality != 0) {
+                if (pstats->packet_toself || pstats->packet_beacon) {
+                        if (rtlpriv->stats.ui_link_quality.total_num++ >=
+                            PHY_LINKQUALITY_SLID_WIN_MAX) {
+                                rtlpriv->stats.ui_link_quality.total_num =
+                                    PHY_LINKQUALITY_SLID_WIN_MAX;
+                                last_evm =
+                                    rtlpriv->stats.ui_link_quality.elements[
+                                    rtlpriv->stats.ui_link_quality.index];
+                                rtlpriv->stats.ui_link_quality.total_val -=
+                                    last_evm;
+                        }
+                        rtlpriv->stats.ui_link_quality.total_val +=
+                            pstats->signalquality;
+                        rtlpriv->stats.ui_link_quality.elements[
+                                rtlpriv->stats.ui_link_quality.index++] =
+                            pstats->signalquality;
+                        if (rtlpriv->stats.ui_link_quality.index >=
+                            PHY_LINKQUALITY_SLID_WIN_MAX)
+                                rtlpriv->stats.ui_link_quality.index = 0;
+                        tmpval = rtlpriv->stats.ui_link_quality.total_val /
+                            rtlpriv->stats.ui_link_quality.total_num;
+                        rtlpriv->stats.signal_quality = tmpval;
+                        rtlpriv->stats.last_sigstrength_inpercent = tmpval;
+                        rtl_92s_process_streams(hw, pstats);
+                }
+        }
+}
+static void _rtl92se_process_phyinfo(struct ieee80211_hw *hw,
+                                     u8 *buffer,
+                                     struct rtl_stats *pcurrent_stats)
+{
+        if (!pcurrent_stats->packet_matchbssid &&
+            !pcurrent_stats->packet_beacon)
+                return;
+        _rtl92se_process_ui_rssi(hw, pcurrent_stats);
+        _rtl92se_process_pwdb(hw, pcurrent_stats);
+        _rtl92se_process_ui_link_quality(hw, pcurrent_stats);
+}
+static void _rtl92se_translate_rx_signal_stuff(struct ieee80211_hw *hw,
+                struct sk_buff *skb, struct rtl_stats *pstats,
+                u8 *pdesc, struct rx_fwinfo *p_drvinfo)
+{
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
+        struct ieee80211_hdr *hdr;
+        u8 *tmp_buf;
+        u8 *praddr;
+        u8 *psaddr;
+        __le16 fc;
+        u16 type, cfc;
+        bool packet_matchbssid, packet_toself, packet_beacon;
+        tmp_buf = skb->data + pstats->rx_drvinfo_size + pstats->rx_bufshift;
+        hdr = (struct ieee80211_hdr *)tmp_buf;
+        fc = hdr->frame_control;
+        cfc = le16_to_cpu(fc);
+        type = WLAN_FC_GET_TYPE(fc);
+        praddr = hdr->addr1;
+        psaddr = hdr->addr2;
+        packet_matchbssid = ((IEEE80211_FTYPE_CTL != type) &&
+             (!compare_ether_addr(mac->bssid, (cfc & IEEE80211_FCTL_TODS) ?
+                        hdr->addr1 : (cfc & IEEE80211_FCTL_FROMDS) ?
+                        hdr->addr2 : hdr->addr3)) && (!pstats->hwerror) &&
+                        (!pstats->crc) && (!pstats->icv));
+        packet_toself = packet_matchbssid &&
+            (!compare_ether_addr(praddr, rtlefuse->dev_addr));
+        if (ieee80211_is_beacon(fc))
+                packet_beacon = true;
+        _rtl92se_query_rxphystatus(hw, pstats, pdesc, p_drvinfo,
+                        packet_matchbssid, packet_toself, packet_beacon);
+        _rtl92se_process_phyinfo(hw, tmp_buf, pstats);
+}
+bool rtl92se_rx_query_desc(struct ieee80211_hw *hw, struct rtl_stats *stats,
+                           struct ieee80211_rx_status *rx_status, u8 *pdesc,
+                           struct sk_buff *skb)
+{
+        struct rx_fwinfo *p_drvinfo;
+        u32 phystatus = (u32)GET_RX_STATUS_DESC_PHY_STATUS(pdesc);
+        stats->length = (u16)GET_RX_STATUS_DESC_PKT_LEN(pdesc);
+        stats->rx_drvinfo_size = (u8)GET_RX_STATUS_DESC_DRVINFO_SIZE(pdesc) * 8;
+        stats->rx_bufshift = (u8)(GET_RX_STATUS_DESC_SHIFT(pdesc) & 0x03);
+        stats->icv = (u16)GET_RX_STATUS_DESC_ICV(pdesc);
+        stats->crc = (u16)GET_RX_STATUS_DESC_CRC32(pdesc);
+        stats->hwerror = (u16)(stats->crc | stats->icv);
+        stats->decrypted = !GET_RX_STATUS_DESC_SWDEC(pdesc);
+        stats->rate = (u8)GET_RX_STATUS_DESC_RX_MCS(pdesc);
+        stats->shortpreamble = (u16)GET_RX_STATUS_DESC_SPLCP(pdesc);
+        stats->isampdu = (bool)(GET_RX_STATUS_DESC_PAGGR(pdesc) == 1);
+        stats->timestamp_low = GET_RX_STATUS_DESC_TSFL(pdesc);
+        stats->rx_is40Mhzpacket = (bool)GET_RX_STATUS_DESC_BW(pdesc);
+        if (stats->hwerror)
+                return false;
+        rx_status->freq = hw->conf.channel->center_freq;
+        rx_status->band = hw->conf.channel->band;
+        if (GET_RX_STATUS_DESC_CRC32(pdesc))
+                rx_status->flag |= RX_FLAG_FAILED_FCS_CRC;
+        if (!GET_RX_STATUS_DESC_SWDEC(pdesc))
+                rx_status->flag |= RX_FLAG_DECRYPTED;
+        if (GET_RX_STATUS_DESC_BW(pdesc))
+                rx_status->flag |= RX_FLAG_40MHZ;
+        if (GET_RX_STATUS_DESC_RX_HT(pdesc))
+                rx_status->flag |= RX_FLAG_HT;
+        rx_status->flag |= RX_FLAG_MACTIME_MPDU;
+        if (stats->decrypted)
+                rx_status->flag |= RX_FLAG_DECRYPTED;
+        rx_status->rate_idx = _rtl92se_rate_mapping((bool)
+                        GET_RX_STATUS_DESC_RX_HT(pdesc),
+                        (u8)GET_RX_STATUS_DESC_RX_MCS(pdesc),
+                        (bool)GET_RX_STATUS_DESC_PAGGR(pdesc));
+        rx_status->mactime = GET_RX_STATUS_DESC_TSFL(pdesc);
+        if (phystatus == true) {
+                p_drvinfo = (struct rx_fwinfo *)(skb->data +
+                                                 stats->rx_bufshift);
+                _rtl92se_translate_rx_signal_stuff(hw, skb, stats, pdesc,
+                                                   p_drvinfo);
+        }
+        /*rx_status->qual = stats->signal; */
+        rx_status->signal = stats->rssi + 10;
+        /*rx_status->noise = -stats->noise; */
+        return true;
+}
+void rtl92se_tx_fill_desc(struct ieee80211_hw *hw,
+                struct ieee80211_hdr *hdr, u8 *pdesc_tx,
+                struct ieee80211_tx_info *info, struct sk_buff *skb,
+                u8 hw_queue, struct rtl_tcb_desc *ptcb_desc)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct ieee80211_sta *sta = info->control.sta;
+        u8 *pdesc = (u8 *) pdesc_tx;
+        u16 seq_number;
+        __le16 fc = hdr->frame_control;
+        u8 reserved_macid = 0;
+        u8 fw_qsel = _rtl92se_map_hwqueue_to_fwqueue(skb, hw_queue);
+        bool firstseg = (!(hdr->seq_ctrl & cpu_to_le16(IEEE80211_SCTL_FRAG)));
+        bool lastseg = (!(hdr->frame_control &
+                        cpu_to_le16(IEEE80211_FCTL_MOREFRAGS)));
+        dma_addr_t mapping = pci_map_single(rtlpci->pdev, skb->data, skb->len,
+                    PCI_DMA_TODEVICE);
+        u8 bw_40 = 0;
+        if (mac->opmode == NL80211_IFTYPE_STATION) {
+                bw_40 = mac->bw_40;
+        } else if (mac->opmode == NL80211_IFTYPE_AP ||
+                mac->opmode == NL80211_IFTYPE_ADHOC) {
+                if (sta)
+                        bw_40 = sta->ht_cap.cap &
+                                    IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+        }
+        seq_number = (le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_SEQ) >> 4;
+        rtl_get_tcb_desc(hw, info, sta, skb, ptcb_desc);
+        CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE_RTL8192S);
+        if (firstseg) {
+                if (rtlpriv->dm.useramask) {
+                        /* set txdesc macId */
+                        if (ptcb_desc->mac_id < 32) {
+                                SET_TX_DESC_MACID(pdesc, ptcb_desc->mac_id);
+                                reserved_macid |= ptcb_desc->mac_id;
+                        }
+                }
+                SET_TX_DESC_RSVD_MACID(pdesc, reserved_macid);
+                SET_TX_DESC_TXHT(pdesc, ((ptcb_desc->hw_rate >=
+                                 DESC92S_RATEMCS0) ? 1 : 0));
+                if (rtlhal->version == VERSION_8192S_ACUT) {
+                        if (ptcb_desc->hw_rate == DESC92S_RATE1M ||
+                                ptcb_desc->hw_rate  == DESC92S_RATE2M ||
+                                ptcb_desc->hw_rate == DESC92S_RATE5_5M ||
+                                ptcb_desc->hw_rate == DESC92S_RATE11M) {
+                                ptcb_desc->hw_rate = DESC92S_RATE12M;
+                        }
+                }
+                SET_TX_DESC_TX_RATE(pdesc, ptcb_desc->hw_rate);
+                if (ptcb_desc->use_shortgi || ptcb_desc->use_shortpreamble)
+                        SET_TX_DESC_TX_SHORT(pdesc, 0);
+                /* Aggregation related */
+                if (info->flags & IEEE80211_TX_CTL_AMPDU)
+                        SET_TX_DESC_AGG_ENABLE(pdesc, 1);
+                /* For AMPDU, we must insert SSN into TX_DESC */
+                SET_TX_DESC_SEQ(pdesc, seq_number);
+                /* Protection mode related */
+                /* For 92S, if RTS/CTS are set, HW will execute RTS. */
+                /* We choose only one protection mode to execute */
+                SET_TX_DESC_RTS_ENABLE(pdesc, ((ptcb_desc->rts_enable &&
+                                !ptcb_desc->cts_enable) ? 1 : 0));
+                SET_TX_DESC_CTS_ENABLE(pdesc, ((ptcb_desc->cts_enable) ?
+                                       1 : 0));
+                SET_TX_DESC_RTS_STBC(pdesc, ((ptcb_desc->rts_stbc) ? 1 : 0));
+                SET_TX_DESC_RTS_RATE(pdesc, ptcb_desc->rts_rate);
+                SET_TX_DESC_RTS_BANDWIDTH(pdesc, 0);
+                SET_TX_DESC_RTS_SUB_CARRIER(pdesc, ptcb_desc->rts_sc);
+                SET_TX_DESC_RTS_SHORT(pdesc, ((ptcb_desc->rts_rate <=
+                       DESC92S_RATE54M) ?
+                       (ptcb_desc->rts_use_shortpreamble ? 1 : 0)
+                       : (ptcb_desc->rts_use_shortgi ? 1 : 0)));
+                /* Set Bandwidth and sub-channel settings. */
+                if (bw_40) {
+                        if (ptcb_desc->packet_bw) {
+                                SET_TX_DESC_TX_BANDWIDTH(pdesc, 1);
+                                /* use duplicated mode */
+                                SET_TX_DESC_TX_SUB_CARRIER(pdesc, 0);
+                        } else {
+                                SET_TX_DESC_TX_BANDWIDTH(pdesc, 0);
+                                SET_TX_DESC_TX_SUB_CARRIER(pdesc,
+                                                   mac->cur_40_prime_sc);
+                        }
+                } else {
+                        SET_TX_DESC_TX_BANDWIDTH(pdesc, 0);
+                        SET_TX_DESC_TX_SUB_CARRIER(pdesc, 0);
+                }
+                /* 3 Fill necessary field in First Descriptor */
+                /*DWORD 0*/
+                SET_TX_DESC_LINIP(pdesc, 0);
+                SET_TX_DESC_OFFSET(pdesc, 32);
+                SET_TX_DESC_PKT_SIZE(pdesc, (u16) skb->len);
+                /*DWORD 1*/
+                SET_TX_DESC_RA_BRSR_ID(pdesc, ptcb_desc->ratr_index);
+                /* Fill security related */
+                if (info->control.hw_key) {
+                        struct ieee80211_key_conf *keyconf;
+                        keyconf = info->control.hw_key;
+                        switch (keyconf->cipher) {
+                        case WLAN_CIPHER_SUITE_WEP40:
+                        case WLAN_CIPHER_SUITE_WEP104:
+                                SET_TX_DESC_SEC_TYPE(pdesc, 0x1);
+                                break;
+                        case WLAN_CIPHER_SUITE_TKIP:
+                                SET_TX_DESC_SEC_TYPE(pdesc, 0x2);
+                                break;
+                        case WLAN_CIPHER_SUITE_CCMP:
+                                SET_TX_DESC_SEC_TYPE(pdesc, 0x3);
+                                break;
+                        default:
+                                SET_TX_DESC_SEC_TYPE(pdesc, 0x0);
+                                break;
+                        }
+                }
+                /* Set Packet ID */
+                SET_TX_DESC_PACKET_ID(pdesc, 0);
+                /* We will assign magement queue to BK. */
+                SET_TX_DESC_QUEUE_SEL(pdesc, fw_qsel);
+                /* Alwasy enable all rate fallback range */
+                SET_TX_DESC_DATA_RATE_FB_LIMIT(pdesc, 0x1F);
+                /* Fix: I don't kown why hw use 6.5M to tx when set it */
+                SET_TX_DESC_USER_RATE(pdesc,
+                                      ptcb_desc->use_driver_rate ? 1 : 0);
+                /* Set NON_QOS bit. */
+                if (!ieee80211_is_data_qos(fc))
+                        SET_TX_DESC_NON_QOS(pdesc, 1);
+        }
+        /* Fill fields that are required to be initialized
+         * in all of the descriptors */
+        /*DWORD 0 */
+        SET_TX_DESC_FIRST_SEG(pdesc, (firstseg ? 1 : 0));
+        SET_TX_DESC_LAST_SEG(pdesc, (lastseg ? 1 : 0));
+        /* DWORD 7 */
+        SET_TX_DESC_TX_BUFFER_SIZE(pdesc, (u16) skb->len);
+        /* DOWRD 8 */
+        SET_TX_DESC_TX_BUFFER_ADDRESS(pdesc, cpu_to_le32(mapping));
+        RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, ("\n"));
+}
+void rtl92se_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc,
+        bool firstseg, bool lastseg, struct sk_buff *skb)
+{
+        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
+        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
+        struct rtl_tcb_desc *tcb_desc = (struct rtl_tcb_desc *)(skb->cb);
+        dma_addr_t mapping = pci_map_single(rtlpci->pdev, skb->data, skb->len,
+                        PCI_DMA_TODEVICE);
+    /* Clear all status */
+        CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_CMDDESC_SIZE_RTL8192S);
+        /* This bit indicate this packet is used for FW download. */
+        if (tcb_desc->cmd_or_init == DESC_PACKET_TYPE_INIT) {
+                /* For firmware downlaod we only need to set LINIP */
+                SET_TX_DESC_LINIP(pdesc, tcb_desc->last_inipkt);
+                /* 92SE must set as 1 for firmware download HW DMA error */
+                SET_TX_DESC_FIRST_SEG(pdesc, 1);
+                SET_TX_DESC_LAST_SEG(pdesc, 1);
+                /* 92SE need not to set TX packet size when firmware download */
+                SET_TX_DESC_PKT_SIZE(pdesc, (u16)(skb->len));
+                SET_TX_DESC_TX_BUFFER_SIZE(pdesc, (u16)(skb->len));
+                SET_TX_DESC_TX_BUFFER_ADDRESS(pdesc, cpu_to_le32(mapping));
+                SET_TX_DESC_OWN(pdesc, 1);
+        } else { /* H2C Command Desc format (Host TXCMD) */
+                /* 92SE must set as 1 for firmware download HW DMA error */
+                SET_TX_DESC_FIRST_SEG(pdesc, 1);
+                SET_TX_DESC_LAST_SEG(pdesc, 1);
+                SET_TX_DESC_OFFSET(pdesc, 0x20);
+                /* Buffer size + command header */
+                SET_TX_DESC_PKT_SIZE(pdesc, (u16)(skb->len));
+                /* Fixed queue of H2C command */
+                SET_TX_DESC_QUEUE_SEL(pdesc, 0x13);
+                SET_BITS_TO_LE_4BYTE(skb->data, 24, 7, rtlhal->h2c_txcmd_seq);
+                SET_TX_DESC_TX_BUFFER_SIZE(pdesc, (u16)(skb->len));
+                SET_TX_DESC_TX_BUFFER_ADDRESS(pdesc, cpu_to_le32(mapping));
+                SET_TX_DESC_OWN(pdesc, 1);
+        }
+}
+void rtl92se_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
+{
+        if (istx == true) {
+                switch (desc_name) {
+                case HW_DESC_OWN:
+                        SET_TX_DESC_OWN(pdesc, 1);
+                        break;
+                case HW_DESC_TX_NEXTDESC_ADDR:
+                        SET_TX_DESC_NEXT_DESC_ADDRESS(pdesc, *(u32 *) val);
+                        break;
+                default:
+                        RT_ASSERT(false, ("ERR txdesc :%d not process\n",
+                                  desc_name));
+                        break;
+                }
+        } else {
+                switch (desc_name) {
+                case HW_DESC_RXOWN:
+                        SET_RX_STATUS_DESC_OWN(pdesc, 1);
+                        break;
+                case HW_DESC_RXBUFF_ADDR:
+                        SET_RX_STATUS__DESC_BUFF_ADDR(pdesc, *(u32 *) val);
+                        break;
+                case HW_DESC_RXPKT_LEN:
+                        SET_RX_STATUS_DESC_PKT_LEN(pdesc, *(u32 *) val);
+                        break;
+                case HW_DESC_RXERO:
+                        SET_RX_STATUS_DESC_EOR(pdesc, 1);
+                        break;
+                default:
+                        RT_ASSERT(false, ("ERR rxdesc :%d not process\n",
+                                  desc_name));
+                        break;
+                }
+        }
+}
+u32 rtl92se_get_desc(u8 *desc, bool istx, u8 desc_name)
+{
+        u32 ret = 0;
+        if (istx == true) {
+                switch (desc_name) {
+                case HW_DESC_OWN:
+                        ret = GET_TX_DESC_OWN(desc);
+                        break;
+                case HW_DESC_TXBUFF_ADDR:
+                        ret = GET_TX_DESC_TX_BUFFER_ADDRESS(desc);
+                        break;
+                default:
+                        RT_ASSERT(false, ("ERR txdesc :%d not process\n",
+                                  desc_name));
+                        break;
+                }
+        } else {
+                switch (desc_name) {
+                case HW_DESC_OWN:
+                        ret = GET_RX_STATUS_DESC_OWN(desc);
+                        break;
+                case HW_DESC_RXPKT_LEN:
+                        ret = GET_RX_STATUS_DESC_PKT_LEN(desc);
+                        break;
+                default:
+                        RT_ASSERT(false, ("ERR rxdesc :%d not process\n",
+                                  desc_name));
+                        break;
+                }
+        }
+        return ret;
+}
+void rtl92se_tx_polling(struct ieee80211_hw *hw, u8 hw_queue)
+{
+        struct rtl_priv *rtlpriv = rtl_priv(hw);
+        rtl_write_word(rtlpriv, TP_POLL, BIT(0) << (hw_queue));
+}
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/trx.h b/drivers/net/wireless/rtlwifi/rtl8192se/trx.h
new file mode 100644
index 000000000000..05862c51b861
--- /dev/null
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/trx.h
@@ -0,0 +1,45 @@
+/******************************************************************************
+ *
+ * Copyright(c) 2009-2010  Realtek Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
+ *
+ * The full GNU General Public License is included in this distribution in the
+ * file called LICENSE.
+ *
+ * Contact Information:
+ * wlanfae <wlanfae@realtek.com>
+ * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
+ * Hsinchu 300, Taiwan.
+ *
+ * Larry Finger <Larry.Finger@lwfinger.net>
+ *
+ *****************************************************************************/
+#ifndef __REALTEK_PCI92SE_TRX_H__
+#define __REALTEK_PCI92SE_TRX_H__
+void rtl92se_tx_fill_desc(struct ieee80211_hw *hw, struct ieee80211_hdr *hdr,
+                          u8 *pdesc, struct ieee80211_tx_info *info,
+                          struct sk_buff *skb, u8 hw_queue,
+                          struct rtl_tcb_desc *ptcb_desc);
+void rtl92se_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc, bool firstseg,
+                             bool lastseg, struct sk_buff *skb);
+bool rtl92se_rx_query_desc(struct ieee80211_hw *hw, struct rtl_stats *stats,
+                           struct ieee80211_rx_status *rx_status, u8 *pdesc,
+                           struct sk_buff *skb);
+void rtl92se_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val);
+u32 rtl92se_get_desc(u8 *pdesc, bool istx, u8 desc_name);
+void rtl92se_tx_polling(struct ieee80211_hw *hw, u8 hw_queue);
+#endif
diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c
index f5d85735d642..a9367eba1ea7 100644
--- a/drivers/net/wireless/rtlwifi/usb.c
+++ b/drivers/net/wireless/rtlwifi/usb.c
@@ -852,6 +852,7 @@ static void _rtl_usb_tx_preprocess(struct ieee80211_hw *hw, struct sk_buff *skb,
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
        struct rtl_tx_desc *pdesc = NULL;
+        struct rtl_tcb_desc tcb_desc;
        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data);
        __le16 fc = hdr->frame_control;
        u8 *pda_addr = hdr->addr1;
@@ -860,8 +861,17 @@ static void _rtl_usb_tx_preprocess(struct ieee80211_hw *hw, struct sk_buff *skb,
        u8 tid = 0;
        u16 seq_number = 0;
-        if (ieee80211_is_mgmt(fc))
+        if (ieee80211_is_auth(fc)) {
-                rtl_tx_mgmt_proc(hw, skb);
+                RT_TRACE(rtlpriv, COMP_SEND, DBG_DMESG, ("MAC80211_LINKING\n"));
+                rtl_ips_nic_on(hw);
+        }
+        if (rtlpriv->psc.sw_ps_enabled) {
+                if (ieee80211_is_data(fc) && !ieee80211_is_nullfunc(fc) &&
+                    !ieee80211_has_pm(fc))
+                        hdr->frame_control |= cpu_to_le16(IEEE80211_FCTL_PM);
+        }
        rtl_action_proc(hw, skb, true);
        if (is_multicast_ether_addr(pda_addr))
                rtlpriv->stats.txbytesmulticast += skb->len;
@@ -878,7 +888,7 @@ static void _rtl_usb_tx_preprocess(struct ieee80211_hw *hw, struct sk_buff *skb,
                seq_number <<= 4;
        }
        rtlpriv->cfg->ops->fill_tx_desc(hw, hdr, (u8 *)pdesc, info, skb,
-                                        hw_queue);
+                                        hw_queue, &tcb_desc);
        if (!ieee80211_has_morefrags(hdr->frame_control)) {
                if (qc)
                        mac->tids[tid].seq_number = seq_number;
@@ -887,7 +897,8 @@ static void _rtl_usb_tx_preprocess(struct ieee80211_hw *hw, struct sk_buff *skb,
                rtlpriv->cfg->ops->led_control(hw, LED_CTL_TX);
 }
-static int rtl_usb_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
+static int rtl_usb_tx(struct ieee80211_hw *hw, struct sk_buff *skb,
+                      struct rtl_tcb_desc *dummy)
 {
        struct rtl_usb *rtlusb = rtl_usbdev(rtl_usbpriv(hw));
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
diff --git a/drivers/net/wireless/rtlwifi/usb.h b/drivers/net/wireless/rtlwifi/usb.h
index abadfe918d30..d2a63fb3e1e6 100644
--- a/drivers/net/wireless/rtlwifi/usb.h
+++ b/drivers/net/wireless/rtlwifi/usb.h
@@ -31,6 +31,8 @@
 #include <linux/usb.h>
 #include <linux/skbuff.h>
+#define RTL_RX_DESC_SIZE                24
 #define RTL_USB_DEVICE(vend, prod, cfg) \
        .match_flags = USB_DEVICE_ID_MATCH_DEVICE, \
        .idVendor = (vend), \
diff --git a/drivers/net/wireless/rtlwifi/wifi.h b/drivers/net/wireless/rtlwifi/wifi.h
index 07db95ff9bc5..693395ee98f9 100644
--- a/drivers/net/wireless/rtlwifi/wifi.h
+++ b/drivers/net/wireless/rtlwifi/wifi.h
@@ -68,6 +68,8 @@
 #define QBSS_LOAD_SIZE                          5
 #define MAX_WMMELE_LENGTH                       64
+#define TOTAL_CAM_ENTRY                         32
 /*slot time for 11g. */
 #define RTL_SLOT_TIME_9                         9
 #define RTL_SLOT_TIME_20                        20
@@ -94,8 +96,10 @@
 #define CHANNEL_GROUP_MAX_5G            9
 #define CHANNEL_MAX_NUMBER_2G           14
 #define AVG_THERMAL_NUM                 8
+#define MAX_TID_COUNT                   9
 /* for early mode */
+#define FCS_LEN                         4
 #define EM_HDR_LEN                      8
 enum intf_type {
        INTF_PCI = 0,
@@ -159,6 +163,8 @@ enum hardware_type {
 (IS_HARDWARE_TYPE_8192DE(rtlhal) || IS_HARDWARE_TYPE_8192DU(rtlhal))
 #define IS_HARDWARE_TYPE_8723(rtlhal)                   \
 (IS_HARDWARE_TYPE_8723E(rtlhal) || IS_HARDWARE_TYPE_8723U(rtlhal))
+#define IS_HARDWARE_TYPE_8723U(rtlhal)                  \
+        (rtlhal->hw_type == HARDWARE_TYPE_RTL8723U)
 enum scan_operation_backup_opt {
        SCAN_OPT_BACKUP = 0,
@@ -297,6 +303,9 @@ enum hw_variables {
        HW_VAR_DATA_FILTER,
 };
+#define HWSET_MAX_SIZE                          128
+#define EFUSE_MAX_SECTION                       16
 enum _RT_MEDIA_STATUS {
        RT_MEDIA_DISCONNECT = 0,
        RT_MEDIA_CONNECT = 1
@@ -766,7 +775,7 @@ struct rtl_rfkill {
 #define IQK_MATRIX_REG_NUM      8
 #define IQK_MATRIX_SETTINGS_NUM (1 + 24 + 21)
 struct iqk_matrix_regs {
-        bool b_iqk_done;
+        bool iqk_done;
        long value[1][IQK_MATRIX_REG_NUM];
 };
@@ -843,6 +852,7 @@ struct rtl_phy {
        bool apk_done;
        u32 reg_rf3c[2];        /* pathA / pathB  */
+        /* bfsync */
        u8 framesync;
        u32 framesync_c34;
@@ -852,6 +862,10 @@ struct rtl_phy {
 };
 #define MAX_TID_COUNT                           9
+#define RTL_AGG_STOP                            0
+#define RTL_AGG_PROGRESS                        1
+#define RTL_AGG_START                           2
+#define RTL_AGG_OPERATIONAL                     3
 #define RTL_AGG_OFF                             0
 #define RTL_AGG_ON                              1
 #define RTL_AGG_EMPTYING_HW_QUEUE_ADDBA         2
@@ -871,6 +885,13 @@ struct rtl_tid_data {
        struct rtl_ht_agg agg;
 };
+struct rtl_sta_info {
+        u8 ratr_index;
+        u8 wireless_mode;
+        u8 mimo_ps;
+        struct rtl_tid_data tids[MAX_TID_COUNT];
+} __packed;
 struct rtl_priv;
 struct rtl_io {
        struct device *dev;
@@ -894,6 +915,7 @@ struct rtl_io {
        u32(*read32_sync) (struct rtl_priv *rtlpriv, u32 addr);
        int (*readN_sync) (struct rtl_priv *rtlpriv, u32 addr, u16 len,
                            u8 *pdata);
 };
 struct rtl_mac {
@@ -916,6 +938,8 @@ struct rtl_mac {
        int n_channels;
        int n_bitrates;
+        bool offchan_deley;
        /*filters */
        u32 rx_conf;
        u16 rx_mgt_filter;
@@ -1032,7 +1056,9 @@ struct rtl_security {
        enum rt_enc_alg pairwise_enc_algorithm;
        /*Encryption Algorithm for Brocast/Multicast */
        enum rt_enc_alg group_enc_algorithm;
+        /*Cam Entry Bitmap */
+        u32 hwsec_cam_bitmap;
+        u8 hwsec_cam_sta_addr[TOTAL_CAM_ENTRY][ETH_ALEN];
        /*local Key buffer, indx 0 is for
           pairwise key 1-4 is for agoup key. */
        u8 key_buf[KEY_BUF_SIZE][MAX_KEY_LEN];
@@ -1053,7 +1079,7 @@ struct rtl_dm {
        bool current_turbo_edca;
        bool is_any_nonbepkts;  /*out dm */
        bool is_cur_rdlstate;
-        bool txpower_trackingInit;
+        bool txpower_trackinginit;
        bool disable_framebursting;
        bool cck_inch14;
        bool txpower_tracking;
@@ -1079,7 +1105,6 @@ struct rtl_dm {
        bool disable_tx_int;
        char ofdm_index[2];
        char cck_index;
-        u8 power_index_backup[6];
 };
 #define EFUSE_MAX_LOGICAL_SIZE                  256
@@ -1175,6 +1200,7 @@ struct rtl_ps_ctl {
         * otherwise Offset[560h] = 0x00.
         * */
        bool support_aspm;
        bool support_backdoor;
        /*for LPS */
@@ -1201,7 +1227,6 @@ struct rtl_ps_ctl {
        /*just for PCIE ASPM */
        u8 const_amdpci_aspm;
        bool pwrdown_mode;
        enum rf_pwrstate inactive_pwrstate;
@@ -1282,6 +1307,10 @@ struct rt_link_detect {
        bool busytraffic;
        bool higher_busytraffic;
        bool higher_busyrxtraffic;
+        u32 tidtx_in4period[MAX_TID_COUNT][4];
+        u32 tidtx_inperiod[MAX_TID_COUNT];
+        bool higher_busytxtraffic[MAX_TID_COUNT];
 };
 struct rtl_tcb_desc {
@@ -1344,13 +1373,15 @@ struct rtl_hal_ops {
                                       u32 add_msr, u32 rm_msr);
        void (*get_hw_reg) (struct ieee80211_hw *hw, u8 variable, u8 *val);
        void (*set_hw_reg) (struct ieee80211_hw *hw, u8 variable, u8 *val);
-        void (*update_rate_table) (struct ieee80211_hw *hw);
+        void (*update_rate_tbl) (struct ieee80211_hw *hw,
+                              struct ieee80211_sta *sta, u8 rssi_level);
        void (*update_rate_mask) (struct ieee80211_hw *hw, u8 rssi_level);
        void (*fill_tx_desc) (struct ieee80211_hw *hw,
                              struct ieee80211_hdr *hdr, u8 *pdesc_tx,
                              struct ieee80211_tx_info *info,
-                              struct sk_buff *skb, unsigned int queue_index);
+                              struct sk_buff *skb, u8 hw_queue,
-        void (*fill_fake_txdesc) (struct ieee80211_hw *hw, u8 * pDesc,
+                              struct rtl_tcb_desc *ptcb_desc);
+        void (*fill_fake_txdesc) (struct ieee80211_hw *hw, u8 *pDesc,
                                  u32 buffer_len, bool bIsPsPoll);
        void (*fill_tx_cmddesc) (struct ieee80211_hw *hw, u8 *pdesc,
                                 bool firstseg, bool lastseg,
@@ -1370,10 +1401,10 @@ struct rtl_hal_ops {
                             enum led_ctl_mode ledaction);
        void (*set_desc) (u8 *pdesc, bool istx, u8 desc_name, u8 *val);
        u32 (*get_desc) (u8 *pdesc, bool istx, u8 desc_name);
-        void (*tx_polling) (struct ieee80211_hw *hw, unsigned int hw_queue);
+        void (*tx_polling) (struct ieee80211_hw *hw, u8 hw_queue);
        void (*enable_hw_sec) (struct ieee80211_hw *hw);
        void (*set_key) (struct ieee80211_hw *hw, u32 key_index,
-                         u8 *p_macaddr, bool is_group, u8 enc_algo,
+                         u8 *macaddr, bool is_group, u8 enc_algo,
                         bool is_wepkey, bool clear_all);
        void (*init_sw_leds) (struct ieee80211_hw *hw);
        void (*deinit_sw_leds) (struct ieee80211_hw *hw);
@@ -1384,6 +1415,7 @@ struct rtl_hal_ops {
                          u32 regaddr, u32 bitmask);
        void (*set_rfreg) (struct ieee80211_hw *hw, enum radio_path rfpath,
                           u32 regaddr, u32 bitmask, u32 data);
+        void (*linked_set_reg) (struct ieee80211_hw *hw);
        bool (*phy_rf6052_config) (struct ieee80211_hw *hw);
        void (*phy_rf6052_set_cck_txpower) (struct ieee80211_hw *hw,
                                            u8 *powerlevel);
@@ -1404,7 +1436,9 @@ struct rtl_intf_ops {
        int (*adapter_start) (struct ieee80211_hw *hw);
        void (*adapter_stop) (struct ieee80211_hw *hw);
-        int (*adapter_tx) (struct ieee80211_hw *hw, struct sk_buff *skb);
+        int (*adapter_tx) (struct ieee80211_hw *hw, struct sk_buff *skb,
+                        struct rtl_tcb_desc *ptcb_desc);
+        void (*flush)(struct ieee80211_hw *hw, bool drop);
        int (*reset_trx_ring) (struct ieee80211_hw *hw);
        bool (*waitq_insert) (struct ieee80211_hw *hw, struct sk_buff *skb);
@@ -1418,6 +1452,15 @@ struct rtl_intf_ops {
 struct rtl_mod_params {
        /* default: 0 = using hardware encryption */
        int sw_crypto;
+        /* default: 1 = using no linked power save */
+        bool inactiveps;
+        /* default: 1 = using linked sw power save */
+        bool swctrl_lps;
+        /* default: 1 = using linked fw power save */
+        bool fwctrl_lps;
 };
 struct rtl_hal_usbint_cfg {
@@ -1445,6 +1488,7 @@ struct rtl_hal_usbint_cfg {
 struct rtl_hal_cfg {
        u8 bar_id;
+        bool write_readback;
        char *name;
        char *fw_name;
        struct rtl_hal_ops *ops;
@@ -1469,7 +1513,6 @@ struct rtl_locks {
        spinlock_t rf_lock;
        spinlock_t lps_lock;
        spinlock_t waitq_lock;
-        spinlock_t tx_urb_lock;
        /*Dual mac*/
        spinlock_t cck_and_rw_pagea_lock;
@@ -1621,19 +1664,19 @@ struct bt_coexist_info {
        u32 bt_edca_ul;
        u32 bt_edca_dl;
-        bool b_init_set;
+        bool init_set;
-        bool b_bt_busy_traffic;
+        bool bt_busy_traffic;
-        bool b_bt_traffic_mode_set;
+        bool bt_traffic_mode_set;
-        bool b_bt_non_traffic_mode_set;
+        bool bt_non_traffic_mode_set;
-        bool b_fw_coexist_all_off;
+        bool fw_coexist_all_off;
-        bool b_sw_coexist_all_off;
+        bool sw_coexist_all_off;
        u32 current_state;
        u32 previous_state;
        u8 bt_pre_rssi_state;
-        u8 b_reg_bt_iso;
+        u8 reg_bt_iso;
-        u8 b_reg_bt_sco;
+        u8 reg_bt_sco;
 };
@@ -1653,13 +1696,23 @@ struct bt_coexist_info {
 #define EF4BYTE(_val)           \
        (le32_to_cpu(_val))
+/* Read data from memory */
+#define READEF1BYTE(_ptr)       \
+        EF1BYTE(*((u8 *)(_ptr)))
 /* Read le16 data from memory and convert to host ordering */
 #define READEF2BYTE(_ptr)       \
        EF2BYTE(*((u16 *)(_ptr)))
+#define READEF4BYTE(_ptr)       \
+        EF4BYTE(*((u32 *)(_ptr)))
+/* Write data to memory */
+#define WRITEEF1BYTE(_ptr, _val)        \
+        (*((u8 *)(_ptr))) = EF1BYTE(_val)
 /* Write le16 data to memory in host ordering */
 #define WRITEEF2BYTE(_ptr, _val)        \
        (*((u16 *)(_ptr))) = EF2BYTE(_val)
+#define WRITEEF4BYTE(_ptr, _val)        \
+        (*((u16 *)(_ptr))) = EF2BYTE(_val)
 /* Create a bit mask
 * Examples:
@@ -1698,6 +1751,25 @@ struct bt_coexist_info {
 #define LE_P1BYTE_TO_HOST_1BYTE(__pstart) \
        (EF1BYTE(*((u8 *)(__pstart))))
+/*Description:
+Translate subfield (continuous bits in little-endian) of 4-byte
+value to host byte ordering.*/
+#define LE_BITS_TO_4BYTE(__pstart, __bitoffset, __bitlen) \
+        ( \
+                (LE_P4BYTE_TO_HOST_4BYTE(__pstart) >> (__bitoffset))  & \
+                BIT_LEN_MASK_32(__bitlen) \
+        )
+#define LE_BITS_TO_2BYTE(__pstart, __bitoffset, __bitlen) \
+        ( \
+                (LE_P2BYTE_TO_HOST_2BYTE(__pstart) >> (__bitoffset)) & \
+                BIT_LEN_MASK_16(__bitlen) \
+        )
+#define LE_BITS_TO_1BYTE(__pstart, __bitoffset, __bitlen) \
+        ( \
+                (LE_P1BYTE_TO_HOST_1BYTE(__pstart) >> (__bitoffset)) & \
+                BIT_LEN_MASK_8(__bitlen) \
+        )
 /* Description:
 * Mask subfield (continuous bits in little-endian) of 4-byte value
 * and return the result in 4-byte value in host byte ordering.
@@ -1721,6 +1793,18 @@ struct bt_coexist_info {
 /* Description:
 * Set subfield of little-endian 4-byte value to specified value.
 */
+#define SET_BITS_TO_LE_4BYTE(__pstart, __bitoffset, __bitlen, __val) \
+        *((u32 *)(__pstart)) = EF4BYTE \
+        ( \
+                LE_BITS_CLEARED_TO_4BYTE(__pstart, __bitoffset, __bitlen) | \
+                ((((u32)__val) & BIT_LEN_MASK_32(__bitlen)) << (__bitoffset)) \
+        );
+#define SET_BITS_TO_LE_2BYTE(__pstart, __bitoffset, __bitlen, __val) \
+        *((u16 *)(__pstart)) = EF2BYTE \
+        ( \
+                LE_BITS_CLEARED_TO_2BYTE(__pstart, __bitoffset, __bitlen) | \
+                ((((u16)__val) & BIT_LEN_MASK_16(__bitlen)) << (__bitoffset)) \
+        );
 #define SET_BITS_TO_LE_1BYTE(__pstart, __bitoffset, __bitlen, __val) \
        *((u8 *)(__pstart)) = EF1BYTE \
        ( \
@@ -1728,12 +1812,16 @@ struct bt_coexist_info {
                ((((u8)__val) & BIT_LEN_MASK_8(__bitlen)) << (__bitoffset)) \
        );
+#define N_BYTE_ALIGMENT(__value, __aligment) ((__aligment == 1) ? \
+        (__value) : (((__value + __aligment - 1) / __aligment) * __aligment))
 /****************************************
        mem access macro define end
 ****************************************/
 #define byte(x, n) ((x >> (8 * n)) & 0xff)
+#define packet_get_type(_packet) (EF1BYTE((_packet).octet[0]) & 0xFC)
 #define RTL_WATCH_DOG_TIME      2000
 #define MSECS(t)                msecs_to_jiffies(t)
 #define WLAN_FC_GET_VERS(fc)    (le16_to_cpu(fc) & IEEE80211_FCTL_VERS)
@@ -1768,6 +1856,15 @@ struct bt_coexist_info {
 #define container_of_dwork_rtl(x, y, z) \
        container_of(container_of(x, struct delayed_work, work), y, z)
+#define FILL_OCTET_STRING(_os, _octet, _len)    \
+                (_os).octet = (u8 *)(_octet);           \
+                (_os).length = (_len);
+#define CP_MACADDR(des, src)    \
+        ((des)[0] = (src)[0], (des)[1] = (src)[1],\
+        (des)[2] = (src)[2], (des)[3] = (src)[3],\
+        (des)[4] = (src)[4], (des)[5] = (src)[5])
 static inline u8 rtl_read_byte(struct rtl_priv *rtlpriv, u32 addr)
 {
        return rtlpriv->io.read8_sync(rtlpriv, addr);
@@ -1786,17 +1883,26 @@ static inline u32 rtl_read_dword(struct rtl_priv *rtlpriv, u32 addr)
 static inline void rtl_write_byte(struct rtl_priv *rtlpriv, u32 addr, u8 val8)
 {
        rtlpriv->io.write8_async(rtlpriv, addr, val8);
+        if (rtlpriv->cfg->write_readback)
+                rtlpriv->io.read8_sync(rtlpriv, addr);
 }
 static inline void rtl_write_word(struct rtl_priv *rtlpriv, u32 addr, u16 val16)
 {
        rtlpriv->io.write16_async(rtlpriv, addr, val16);
+        if (rtlpriv->cfg->write_readback)
+                rtlpriv->io.read16_sync(rtlpriv, addr);
 }
 static inline void rtl_write_dword(struct rtl_priv *rtlpriv,
                                   u32 addr, u32 val32)
 {
        rtlpriv->io.write32_async(rtlpriv, addr, val32);
+        if (rtlpriv->cfg->write_readback)
+                rtlpriv->io.read32_sync(rtlpriv, addr);
 }
 static inline u32 rtl_get_bbreg(struct ieee80211_hw *hw,
@@ -1855,4 +1961,31 @@ static inline u8 get_rf_type(struct rtl_phy *rtlphy)
        return rtlphy->rf_type;
 }
+static inline struct ieee80211_hdr *rtl_get_hdr(struct sk_buff *skb)
+{
+        return (struct ieee80211_hdr *)(skb->data);
+}
+static inline __le16 rtl_get_fc(struct sk_buff *skb)
+{
+        return rtl_get_hdr(skb)->frame_control;
+}
+static inline u16 rtl_get_tid_h(struct ieee80211_hdr *hdr)
+{
+        return (ieee80211_get_qos_ctl(hdr))[0] & IEEE80211_QOS_CTL_TID_MASK;
+}
+static inline u16 rtl_get_tid(struct sk_buff *skb)
+{
+        return rtl_get_tid_h(rtl_get_hdr(skb));
+}
+static inline struct ieee80211_sta *get_sta(struct ieee80211_hw *hw,
+                                            struct ieee80211_vif *vif,
+                                            u8 *bssid)
+{
+        return ieee80211_find_sta(vif, bssid);
+}
 #endif
diff --git a/drivers/net/wireless/wl1251/cmd.h b/drivers/net/wireless/wl1251/cmd.h
index e5c74c631374..79ca5273c9e9 100644
--- a/drivers/net/wireless/wl1251/cmd.h
+++ b/drivers/net/wireless/wl1251/cmd.h
@@ -313,8 +313,8 @@ struct wl1251_cmd_vbm_update {
 } __packed;
 enum wl1251_cmd_ps_mode {
-        STATION_ACTIVE_MODE,
+        CHIP_ACTIVE_MODE,
-        STATION_POWER_SAVE_MODE
+        CHIP_POWER_SAVE_MODE
 };
 struct wl1251_cmd_ps_params {
diff --git a/drivers/net/wireless/wl1251/event.c b/drivers/net/wireless/wl1251/event.c
index dfc4579acb06..9f15ccaf8f05 100644
--- a/drivers/net/wireless/wl1251/event.c
+++ b/drivers/net/wireless/wl1251/event.c
@@ -68,14 +68,16 @@ static int wl1251_event_process(struct wl1251 *wl, struct event_mailbox *mbox)
        if (vector & BSS_LOSE_EVENT_ID) {
                wl1251_debug(DEBUG_EVENT, "BSS_LOSE_EVENT");
-                if (wl->psm_requested && wl->psm) {
+                if (wl->psm_requested &&
+                    wl->station_mode != STATION_ACTIVE_MODE) {
                        ret = wl1251_ps_set_mode(wl, STATION_ACTIVE_MODE);
                        if (ret < 0)
                                return ret;
                }
        }
-        if (vector & SYNCHRONIZATION_TIMEOUT_EVENT_ID && wl->psm) {
+        if (vector & SYNCHRONIZATION_TIMEOUT_EVENT_ID &&
+            wl->station_mode != STATION_ACTIVE_MODE) {
                wl1251_debug(DEBUG_EVENT, "SYNCHRONIZATION_TIMEOUT_EVENT");
                /* indicate to the stack, that beacons have been lost */
diff --git a/drivers/net/wireless/wl1251/main.c b/drivers/net/wireless/wl1251/main.c
index 12c9e635a6d6..a14a48c99cdc 100644
--- a/drivers/net/wireless/wl1251/main.c
+++ b/drivers/net/wireless/wl1251/main.c
@@ -497,7 +497,7 @@ static void wl1251_op_stop(struct ieee80211_hw *hw)
        wl->rx_last_id = 0;
        wl->next_tx_complete = 0;
        wl->elp = false;
-        wl->psm = 0;
+        wl->station_mode = STATION_ACTIVE_MODE;
        wl->tx_queue_stopped = false;
        wl->power_level = WL1251_DEFAULT_POWER_LEVEL;
        wl->rssi_thold = 0;
@@ -632,13 +632,29 @@ static int wl1251_op_config(struct ieee80211_hw *hw, u32 changed)
                wl->psm_requested = false;
-                if (wl->psm) {
+                if (wl->station_mode != STATION_ACTIVE_MODE) {
                        ret = wl1251_ps_set_mode(wl, STATION_ACTIVE_MODE);
                        if (ret < 0)
                                goto out_sleep;
                }
        }
+        if (changed & IEEE80211_CONF_CHANGE_IDLE) {
+                if (conf->flags & IEEE80211_CONF_IDLE) {
+                        ret = wl1251_ps_set_mode(wl, STATION_IDLE);
+                        if (ret < 0)
+                                goto out_sleep;
+                } else {
+                        ret = wl1251_ps_set_mode(wl, STATION_ACTIVE_MODE);
+                        if (ret < 0)
+                                goto out_sleep;
+                        ret = wl1251_join(wl, wl->bss_type, wl->channel,
+                                          wl->beacon_int, wl->dtim_period);
+                        if (ret < 0)
+                                goto out_sleep;
+                }
+        }
        if (conf->power_level != wl->power_level) {
                ret = wl1251_acx_tx_power(wl, conf->power_level);
                if (ret < 0)
@@ -1384,7 +1400,7 @@ struct ieee80211_hw *wl1251_alloc_hw(void)
        wl->rx_config = WL1251_DEFAULT_RX_CONFIG;
        wl->rx_filter = WL1251_DEFAULT_RX_FILTER;
        wl->elp = false;
-        wl->psm = 0;
+        wl->station_mode = STATION_ACTIVE_MODE;
        wl->psm_requested = false;
        wl->tx_queue_stopped = false;
        wl->power_level = WL1251_DEFAULT_POWER_LEVEL;
diff --git a/drivers/net/wireless/wl1251/ps.c b/drivers/net/wireless/wl1251/ps.c
index 9cc514703d2a..db719f7d2692 100644
--- a/drivers/net/wireless/wl1251/ps.c
+++ b/drivers/net/wireless/wl1251/ps.c
@@ -39,7 +39,7 @@ void wl1251_elp_work(struct work_struct *work)
        mutex_lock(&wl->mutex);
-        if (wl->elp || !wl->psm)
+        if (wl->elp || wl->station_mode == STATION_ACTIVE_MODE)
                goto out;
        wl1251_debug(DEBUG_PSM, "chip to elp");
@@ -57,7 +57,7 @@ void wl1251_ps_elp_sleep(struct wl1251 *wl)
 {
        unsigned long delay;
-        if (wl->psm) {
+        if (wl->station_mode != STATION_ACTIVE_MODE) {
                delay = msecs_to_jiffies(ELP_ENTRY_DELAY);
                ieee80211_queue_delayed_work(wl->hw, &wl->elp_work, delay);
        }
@@ -104,7 +104,7 @@ int wl1251_ps_elp_wakeup(struct wl1251 *wl)
        return 0;
 }
-int wl1251_ps_set_mode(struct wl1251 *wl, enum wl1251_cmd_ps_mode mode)
+int wl1251_ps_set_mode(struct wl1251 *wl, enum wl1251_station_mode mode)
 {
        int ret;
@@ -128,15 +128,24 @@ int wl1251_ps_set_mode(struct wl1251 *wl, enum wl1251_cmd_ps_mode mode)
                if (ret < 0)
                        return ret;
-                ret = wl1251_cmd_ps_mode(wl, STATION_POWER_SAVE_MODE);
+                ret = wl1251_cmd_ps_mode(wl, CHIP_POWER_SAVE_MODE);
                if (ret < 0)
                        return ret;
                ret = wl1251_acx_sleep_auth(wl, WL1251_PSM_ELP);
                if (ret < 0)
                        return ret;
+                break;
+        case STATION_IDLE:
+                wl1251_debug(DEBUG_PSM, "entering idle");
-                wl->psm = 1;
+                ret = wl1251_acx_sleep_auth(wl, WL1251_PSM_ELP);
+                if (ret < 0)
+                        return ret;
+                ret = wl1251_cmd_template_set(wl, CMD_DISCONNECT, NULL, 0);
+                if (ret < 0)
+                        return ret;
                break;
        case STATION_ACTIVE_MODE:
        default:
@@ -163,13 +172,13 @@ int wl1251_ps_set_mode(struct wl1251 *wl, enum wl1251_cmd_ps_mode mode)
                if (ret < 0)
                        return ret;
-                ret = wl1251_cmd_ps_mode(wl, STATION_ACTIVE_MODE);
+                ret = wl1251_cmd_ps_mode(wl, CHIP_ACTIVE_MODE);
                if (ret < 0)
                        return ret;
-                wl->psm = 0;
                break;
        }
+        wl->station_mode = mode;
        return ret;
 }
diff --git a/drivers/net/wireless/wl1251/ps.h b/drivers/net/wireless/wl1251/ps.h
index 55c3dda75e69..75efad246d67 100644
--- a/drivers/net/wireless/wl1251/ps.h
+++ b/drivers/net/wireless/wl1251/ps.h
@@ -26,7 +26,7 @@
 #include "wl1251.h"
 #include "acx.h"
-int wl1251_ps_set_mode(struct wl1251 *wl, enum wl1251_cmd_ps_mode mode);
+int wl1251_ps_set_mode(struct wl1251 *wl, enum wl1251_station_mode mode);
 void wl1251_ps_elp_sleep(struct wl1251 *wl);
 int wl1251_ps_elp_wakeup(struct wl1251 *wl);
 void wl1251_elp_work(struct work_struct *work);
diff --git a/drivers/net/wireless/wl1251/wl1251.h b/drivers/net/wireless/wl1251/wl1251.h
index bb23cd522b22..a77f1bbbed0a 100644
--- a/drivers/net/wireless/wl1251/wl1251.h
+++ b/drivers/net/wireless/wl1251/wl1251.h
@@ -129,6 +129,12 @@ enum wl1251_partition_type {
        PART_TABLE_LEN
 };
+enum wl1251_station_mode {
+        STATION_ACTIVE_MODE,
+        STATION_POWER_SAVE_MODE,
+        STATION_IDLE,
+};
 struct wl1251_partition {
        u32 size;
        u32 start;
@@ -358,8 +364,7 @@ struct wl1251 {
        struct delayed_work elp_work;
-        /* we can be in psm, but not in elp, we have to differentiate */
+        enum wl1251_station_mode station_mode;
-        bool psm;
        /* PSM mode requested */
        bool psm_requested;
diff --git a/drivers/net/wireless/wl12xx/Kconfig b/drivers/net/wireless/wl12xx/Kconfig
index 692ebff38fc8..35ce7b0f4a60 100644
--- a/drivers/net/wireless/wl12xx/Kconfig
+++ b/drivers/net/wireless/wl12xx/Kconfig
@@ -3,7 +3,7 @@ menuconfig WL12XX_MENU
        depends on MAC80211 && EXPERIMENTAL
        ---help---
          This will enable TI wl12xx driver support for the following chips:
-          wl1271 and wl1273.
+          wl1271, wl1273, wl1281 and wl1283.
          The drivers make use of the mac80211 stack.
 config WL12XX
diff --git a/drivers/net/wireless/wl12xx/acx.c b/drivers/net/wireless/wl12xx/acx.c
index a3db755ceeda..c6ee530e5bf7 100644
--- a/drivers/net/wireless/wl12xx/acx.c
+++ b/drivers/net/wireless/wl12xx/acx.c
@@ -325,12 +325,19 @@ out:
        return ret;
 }
-int wl1271_acx_rts_threshold(struct wl1271 *wl, u16 rts_threshold)
+int wl1271_acx_rts_threshold(struct wl1271 *wl, u32 rts_threshold)
 {
        struct acx_rts_threshold *rts;
        int ret;
-        wl1271_debug(DEBUG_ACX, "acx rts threshold");
+        /*
+         * If the RTS threshold is not configured or out of range, use the
+         * default value.
+         */
+        if (rts_threshold > IEEE80211_MAX_RTS_THRESHOLD)
+                rts_threshold = wl->conf.rx.rts_threshold;
+        wl1271_debug(DEBUG_ACX, "acx rts threshold: %d", rts_threshold);
        rts = kzalloc(sizeof(*rts), GFP_KERNEL);
        if (!rts) {
@@ -338,7 +345,7 @@ int wl1271_acx_rts_threshold(struct wl1271 *wl, u16 rts_threshold)
                goto out;
        }
-        rts->threshold = cpu_to_le16(rts_threshold);
+        rts->threshold = cpu_to_le16((u16)rts_threshold);
        ret = wl1271_cmd_configure(wl, DOT11_RTS_THRESHOLD, rts, sizeof(*rts));
        if (ret < 0) {
@@ -540,13 +547,13 @@ out:
        return ret;
 }
-int wl1271_acx_sg_cfg(struct wl1271 *wl)
+int wl1271_acx_sta_sg_cfg(struct wl1271 *wl)
 {
-        struct acx_bt_wlan_coex_param *param;
+        struct acx_sta_bt_wlan_coex_param *param;
        struct conf_sg_settings *c = &wl->conf.sg;
        int i, ret;
-        wl1271_debug(DEBUG_ACX, "acx sg cfg");
+        wl1271_debug(DEBUG_ACX, "acx sg sta cfg");
        param = kzalloc(sizeof(*param), GFP_KERNEL);
        if (!param) {
@@ -555,8 +562,38 @@ int wl1271_acx_sg_cfg(struct wl1271 *wl)
        }
        /* BT-WLAN coext parameters */
-        for (i = 0; i < CONF_SG_PARAMS_MAX; i++)
+        for (i = 0; i < CONF_SG_STA_PARAMS_MAX; i++)
-                param->params[i] = cpu_to_le32(c->params[i]);
+                param->params[i] = cpu_to_le32(c->sta_params[i]);
+        param->param_idx = CONF_SG_PARAMS_ALL;
+        ret = wl1271_cmd_configure(wl, ACX_SG_CFG, param, sizeof(*param));
+        if (ret < 0) {
+                wl1271_warning("failed to set sg config: %d", ret);
+                goto out;
+        }
+out:
+        kfree(param);
+        return ret;
+}
+int wl1271_acx_ap_sg_cfg(struct wl1271 *wl)
+{
+        struct acx_ap_bt_wlan_coex_param *param;
+        struct conf_sg_settings *c = &wl->conf.sg;
+        int i, ret;
+        wl1271_debug(DEBUG_ACX, "acx sg ap cfg");
+        param = kzalloc(sizeof(*param), GFP_KERNEL);
+        if (!param) {
+                ret = -ENOMEM;
+                goto out;
+        }
+        /* BT-WLAN coext parameters */
+        for (i = 0; i < CONF_SG_AP_PARAMS_MAX; i++)
+                param->params[i] = cpu_to_le32(c->ap_params[i]);
        param->param_idx = CONF_SG_PARAMS_ALL;
        ret = wl1271_cmd_configure(wl, ACX_SG_CFG, param, sizeof(*param));
@@ -804,7 +841,8 @@ int wl1271_acx_ap_rate_policy(struct wl1271 *wl, struct conf_tx_rate_class *c,
        struct acx_ap_rate_policy *acx;
        int ret = 0;
-        wl1271_debug(DEBUG_ACX, "acx ap rate policy");
+        wl1271_debug(DEBUG_ACX, "acx ap rate policy %d rates 0x%x",
+                     idx, c->enabled_rates);
        acx = kzalloc(sizeof(*acx), GFP_KERNEL);
        if (!acx) {
@@ -898,12 +936,19 @@ out:
        return ret;
 }
-int wl1271_acx_frag_threshold(struct wl1271 *wl, u16 frag_threshold)
+int wl1271_acx_frag_threshold(struct wl1271 *wl, u32 frag_threshold)
 {
        struct acx_frag_threshold *acx;
        int ret = 0;
-        wl1271_debug(DEBUG_ACX, "acx frag threshold");
+        /*
+         * If the fragmentation is not configured or out of range, use the
+         * default value.
+         */
+        if (frag_threshold > IEEE80211_MAX_FRAG_THRESHOLD)
+                frag_threshold = wl->conf.tx.frag_threshold;
+        wl1271_debug(DEBUG_ACX, "acx frag threshold: %d", frag_threshold);
        acx = kzalloc(sizeof(*acx), GFP_KERNEL);
@@ -912,7 +957,7 @@ int wl1271_acx_frag_threshold(struct wl1271 *wl, u16 frag_threshold)
                goto out;
        }
-        acx->frag_threshold = cpu_to_le16(frag_threshold);
+        acx->frag_threshold = cpu_to_le16((u16)frag_threshold);
        ret = wl1271_cmd_configure(wl, ACX_FRAG_CFG, acx, sizeof(*acx));
        if (ret < 0) {
                wl1271_warning("Setting of frag threshold failed: %d", ret);
@@ -954,6 +999,7 @@ out:
 int wl1271_acx_ap_mem_cfg(struct wl1271 *wl)
 {
        struct wl1271_acx_ap_config_memory *mem_conf;
+        struct conf_memory_settings *mem;
        int ret;
        wl1271_debug(DEBUG_ACX, "wl1271 mem cfg");
@@ -964,11 +1010,21 @@ int wl1271_acx_ap_mem_cfg(struct wl1271 *wl)
                goto out;
        }
+        if (wl->chip.id == CHIP_ID_1283_PG20)
+                /*
+                 * FIXME: The 128x AP FW does not yet support dynamic memory.
+                 * Use the base memory configuration for 128x for now. This
+                 * should be fine tuned in the future.
+                 */
+                mem = &wl->conf.mem_wl128x;
+        else
+                mem = &wl->conf.mem_wl127x;
        /* memory config */
-        mem_conf->num_stations = wl->conf.mem.num_stations;
+        mem_conf->num_stations = mem->num_stations;
-        mem_conf->rx_mem_block_num = wl->conf.mem.rx_block_num;
+        mem_conf->rx_mem_block_num = mem->rx_block_num;
-        mem_conf->tx_min_mem_block_num = wl->conf.mem.tx_min_block_num;
+        mem_conf->tx_min_mem_block_num = mem->tx_min_block_num;
-        mem_conf->num_ssid_profiles = wl->conf.mem.ssid_profiles;
+        mem_conf->num_ssid_profiles = mem->ssid_profiles;
        mem_conf->total_tx_descriptors = cpu_to_le32(ACX_TX_DESCRIPTORS);
        ret = wl1271_cmd_configure(wl, ACX_MEM_CFG, mem_conf,
@@ -986,6 +1042,7 @@ out:
 int wl1271_acx_sta_mem_cfg(struct wl1271 *wl)
 {
        struct wl1271_acx_sta_config_memory *mem_conf;
+        struct conf_memory_settings *mem;
        int ret;
        wl1271_debug(DEBUG_ACX, "wl1271 mem cfg");
@@ -996,16 +1053,21 @@ int wl1271_acx_sta_mem_cfg(struct wl1271 *wl)
                goto out;
        }
+        if (wl->chip.id == CHIP_ID_1283_PG20)
+                mem = &wl->conf.mem_wl128x;
+        else
+                mem = &wl->conf.mem_wl127x;
        /* memory config */
-        mem_conf->num_stations = wl->conf.mem.num_stations;
+        mem_conf->num_stations = mem->num_stations;
-        mem_conf->rx_mem_block_num = wl->conf.mem.rx_block_num;
+        mem_conf->rx_mem_block_num = mem->rx_block_num;
-        mem_conf->tx_min_mem_block_num = wl->conf.mem.tx_min_block_num;
+        mem_conf->tx_min_mem_block_num = mem->tx_min_block_num;
-        mem_conf->num_ssid_profiles = wl->conf.mem.ssid_profiles;
+        mem_conf->num_ssid_profiles = mem->ssid_profiles;
        mem_conf->total_tx_descriptors = cpu_to_le32(ACX_TX_DESCRIPTORS);
-        mem_conf->dyn_mem_enable = wl->conf.mem.dynamic_memory;
+        mem_conf->dyn_mem_enable = mem->dynamic_memory;
-        mem_conf->tx_free_req = wl->conf.mem.min_req_tx_blocks;
+        mem_conf->tx_free_req = mem->min_req_tx_blocks;
-        mem_conf->rx_free_req = wl->conf.mem.min_req_rx_blocks;
+        mem_conf->rx_free_req = mem->min_req_rx_blocks;
-        mem_conf->tx_min = wl->conf.mem.tx_min;
+        mem_conf->tx_min = mem->tx_min;
        ret = wl1271_cmd_configure(wl, ACX_MEM_CFG, mem_conf,
                                   sizeof(*mem_conf));
@@ -1019,6 +1081,32 @@ out:
        return ret;
 }
+int wl1271_acx_host_if_cfg_bitmap(struct wl1271 *wl, u32 host_cfg_bitmap)
+{
+        struct wl1271_acx_host_config_bitmap *bitmap_conf;
+        int ret;
+        bitmap_conf = kzalloc(sizeof(*bitmap_conf), GFP_KERNEL);
+        if (!bitmap_conf) {
+                ret = -ENOMEM;
+                goto out;
+        }
+        bitmap_conf->host_cfg_bitmap = cpu_to_le32(host_cfg_bitmap);
+        ret = wl1271_cmd_configure(wl, ACX_HOST_IF_CFG_BITMAP,
+                                   bitmap_conf, sizeof(*bitmap_conf));
+        if (ret < 0) {
+                wl1271_warning("wl1271 bitmap config opt failed: %d", ret);
+                goto out;
+        }
+out:
+        kfree(bitmap_conf);
+        return ret;
+}
 int wl1271_acx_init_mem_config(struct wl1271 *wl)
 {
        int ret;
@@ -1567,3 +1655,68 @@ out:
        kfree(acx);
        return ret;
 }
+int wl1271_acx_set_ap_beacon_filter(struct wl1271 *wl, bool enable)
+{
+        struct acx_ap_beacon_filter *acx = NULL;
+        int ret;
+        wl1271_debug(DEBUG_ACX, "acx set ap beacon filter: %d", enable);
+        acx = kzalloc(sizeof(*acx), GFP_KERNEL);
+        if (!acx)
+                return -ENOMEM;
+        acx->enable = enable ? 1 : 0;
+        ret = wl1271_cmd_configure(wl, ACX_AP_BEACON_FILTER_OPT,
+                                   acx, sizeof(*acx));
+        if (ret < 0) {
+                wl1271_warning("acx set ap beacon filter failed: %d", ret);
+                goto out;
+        }
+out:
+        kfree(acx);
+        return ret;
+}
+int wl1271_acx_fm_coex(struct wl1271 *wl)
+{
+        struct wl1271_acx_fm_coex *acx;
+        int ret;
+        wl1271_debug(DEBUG_ACX, "acx fm coex setting");
+        acx = kzalloc(sizeof(*acx), GFP_KERNEL);
+        if (!acx) {
+                ret = -ENOMEM;
+                goto out;
+        }
+        acx->enable = wl->conf.fm_coex.enable;
+        acx->swallow_period = wl->conf.fm_coex.swallow_period;
+        acx->n_divider_fref_set_1 = wl->conf.fm_coex.n_divider_fref_set_1;
+        acx->n_divider_fref_set_2 = wl->conf.fm_coex.n_divider_fref_set_2;
+        acx->m_divider_fref_set_1 =
+                cpu_to_le16(wl->conf.fm_coex.m_divider_fref_set_1);
+        acx->m_divider_fref_set_2 =
+                cpu_to_le16(wl->conf.fm_coex.m_divider_fref_set_2);
+        acx->coex_pll_stabilization_time =
+                cpu_to_le32(wl->conf.fm_coex.coex_pll_stabilization_time);
+        acx->ldo_stabilization_time =
+                cpu_to_le16(wl->conf.fm_coex.ldo_stabilization_time);
+        acx->fm_disturbed_band_margin =
+                wl->conf.fm_coex.fm_disturbed_band_margin;
+        acx->swallow_clk_diff = wl->conf.fm_coex.swallow_clk_diff;
+        ret = wl1271_cmd_configure(wl, ACX_FM_COEX_CFG, acx, sizeof(*acx));
+        if (ret < 0) {
+                wl1271_warning("acx fm coex setting failed: %d", ret);
+                goto out;
+        }
+out:
+        kfree(acx);
+        return ret;
+}
diff --git a/drivers/net/wireless/wl12xx/acx.h b/drivers/net/wireless/wl12xx/acx.h
index dd19b01d807b..9a895e3cc613 100644
--- a/drivers/net/wireless/wl12xx/acx.h
+++ b/drivers/net/wireless/wl12xx/acx.h
@@ -303,7 +303,6 @@ struct acx_beacon_filter_option {
        struct acx_header header;
        u8 enable;
        /*
         * The number of beacons without the unicast TIM
         * bit set that the firmware buffers before
@@ -370,14 +369,23 @@ struct acx_bt_wlan_coex {
        u8 pad[3];
 } __packed;
-struct acx_bt_wlan_coex_param {
+struct acx_sta_bt_wlan_coex_param {
        struct acx_header header;
-        __le32 params[CONF_SG_PARAMS_MAX];
+        __le32 params[CONF_SG_STA_PARAMS_MAX];
        u8 param_idx;
        u8 padding[3];
 } __packed;
+struct acx_ap_bt_wlan_coex_param {
+        struct acx_header header;
+        __le32 params[CONF_SG_AP_PARAMS_MAX];
+        u8 param_idx;
+        u8 padding[3];
+} __packed;
 struct acx_dco_itrim_params {
        struct acx_header header;
@@ -939,6 +947,16 @@ struct wl1271_acx_keep_alive_config {
        u8 padding;
 } __packed;
+#define HOST_IF_CFG_RX_FIFO_ENABLE     BIT(0)
+#define HOST_IF_CFG_TX_EXTRA_BLKS_SWAP BIT(1)
+#define HOST_IF_CFG_TX_PAD_TO_SDIO_BLK BIT(3)
+struct wl1271_acx_host_config_bitmap {
+        struct acx_header header;
+        __le32 host_cfg_bitmap;
+} __packed;
 enum {
        WL1271_ACX_TRIG_TYPE_LEVEL = 0,
        WL1271_ACX_TRIG_TYPE_EDGE,
@@ -1162,6 +1180,72 @@ struct wl1271_acx_inconnection_sta {
        u8 padding1[2];
 } __packed;
+struct acx_ap_beacon_filter {
+        struct acx_header header;
+        u8 enable;
+        u8 pad[3];
+} __packed;
+/*
+ * ACX_FM_COEX_CFG
+ * set the FM co-existence parameters.
+ */
+struct wl1271_acx_fm_coex {
+        struct acx_header header;
+        /* enable(1) / disable(0) the FM Coex feature */
+        u8 enable;
+        /*
+         * Swallow period used in COEX PLL swallowing mechanism.
+         * 0xFF = use FW default
+         */
+        u8 swallow_period;
+        /*
+         * The N divider used in COEX PLL swallowing mechanism for Fref of
+         * 38.4/19.2 Mhz. 0xFF = use FW default
+         */
+        u8 n_divider_fref_set_1;
+        /*
+         * The N divider used in COEX PLL swallowing mechanism for Fref of
+         * 26/52 Mhz. 0xFF = use FW default
+         */
+        u8 n_divider_fref_set_2;
+        /*
+         * The M divider used in COEX PLL swallowing mechanism for Fref of
+         * 38.4/19.2 Mhz. 0xFFFF = use FW default
+         */
+        __le16 m_divider_fref_set_1;
+        /*
+         * The M divider used in COEX PLL swallowing mechanism for Fref of
+         * 26/52 Mhz. 0xFFFF = use FW default
+         */
+        __le16 m_divider_fref_set_2;
+        /*
+         * The time duration in uSec required for COEX PLL to stabilize.
+         * 0xFFFFFFFF = use FW default
+         */
+        __le32 coex_pll_stabilization_time;
+        /*
+         * The time duration in uSec required for LDO to stabilize.
+         * 0xFFFFFFFF = use FW default
+         */
+        __le16 ldo_stabilization_time;
+        /*
+         * The disturbed frequency band margin around the disturbed frequency
+         * center (single sided).
+         * For example, if 2 is configured, the following channels will be
+         * considered disturbed channel:
+         *   80 +- 0.1 MHz, 91 +- 0.1 MHz, 98 +- 0.1 MHz, 102 +- 0.1 MH
+         * 0xFF = use FW default
+         */
+        u8 fm_disturbed_band_margin;
+        /*
+         * The swallow clock difference of the swallowing mechanism.
+         * 0xFF = use FW default
+         */
+        u8 swallow_clk_diff;
+} __packed;
 enum {
        ACX_WAKE_UP_CONDITIONS      = 0x0002,
        ACX_MEM_CFG                 = 0x0003,
@@ -1180,6 +1264,7 @@ enum {
        ACX_TID_CFG                 = 0x001A,
        ACX_PS_RX_STREAMING         = 0x001B,
        ACX_BEACON_FILTER_OPT       = 0x001F,
+        ACX_AP_BEACON_FILTER_OPT    = 0x0020,
        ACX_NOISE_HIST              = 0x0021,
        ACX_HDK_VERSION             = 0x0022, /* ??? */
        ACX_PD_THRESHOLD            = 0x0023,
@@ -1191,6 +1276,7 @@ enum {
        ACX_BCN_DTIM_OPTIONS        = 0x0031,
        ACX_SG_ENABLE               = 0x0032,
        ACX_SG_CFG                  = 0x0033,
+        ACX_FM_COEX_CFG             = 0x0034,
        ACX_BEACON_FILTER_TABLE     = 0x0038,
        ACX_ARP_IP_FILTER           = 0x0039,
        ACX_ROAMING_STATISTICS_TBL  = 0x003B,
@@ -1247,13 +1333,14 @@ int wl1271_acx_slot(struct wl1271 *wl, enum acx_slot_type slot_time);
 int wl1271_acx_group_address_tbl(struct wl1271 *wl, bool enable,
                                 void *mc_list, u32 mc_list_len);
 int wl1271_acx_service_period_timeout(struct wl1271 *wl);
-int wl1271_acx_rts_threshold(struct wl1271 *wl, u16 rts_threshold);
+int wl1271_acx_rts_threshold(struct wl1271 *wl, u32 rts_threshold);
 int wl1271_acx_dco_itrim_params(struct wl1271 *wl);
 int wl1271_acx_beacon_filter_opt(struct wl1271 *wl, bool enable_filter);
 int wl1271_acx_beacon_filter_table(struct wl1271 *wl);
 int wl1271_acx_conn_monit_params(struct wl1271 *wl, bool enable);
 int wl1271_acx_sg_enable(struct wl1271 *wl, bool enable);
-int wl1271_acx_sg_cfg(struct wl1271 *wl);
+int wl1271_acx_sta_sg_cfg(struct wl1271 *wl);
+int wl1271_acx_ap_sg_cfg(struct wl1271 *wl);
 int wl1271_acx_cca_threshold(struct wl1271 *wl);
 int wl1271_acx_bcn_dtim_options(struct wl1271 *wl);
 int wl1271_acx_aid(struct wl1271 *wl, u16 aid);
@@ -1270,11 +1357,12 @@ int wl1271_acx_ac_cfg(struct wl1271 *wl, u8 ac, u8 cw_min, u16 cw_max,
 int wl1271_acx_tid_cfg(struct wl1271 *wl, u8 queue_id, u8 channel_type,
                       u8 tsid, u8 ps_scheme, u8 ack_policy,
                       u32 apsd_conf0, u32 apsd_conf1);
-int wl1271_acx_frag_threshold(struct wl1271 *wl, u16 frag_threshold);
+int wl1271_acx_frag_threshold(struct wl1271 *wl, u32 frag_threshold);
 int wl1271_acx_tx_config_options(struct wl1271 *wl);
 int wl1271_acx_ap_mem_cfg(struct wl1271 *wl);
 int wl1271_acx_sta_mem_cfg(struct wl1271 *wl);
 int wl1271_acx_init_mem_config(struct wl1271 *wl);
+int wl1271_acx_host_if_cfg_bitmap(struct wl1271 *wl, u32 host_cfg_bitmap);
 int wl1271_acx_init_rx_interrupt(struct wl1271 *wl);
 int wl1271_acx_smart_reflex(struct wl1271 *wl);
 int wl1271_acx_bet_enable(struct wl1271 *wl, bool enable);
@@ -1299,5 +1387,7 @@ int wl1271_acx_tsf_info(struct wl1271 *wl, u64 *mactime);
 int wl1271_acx_max_tx_retry(struct wl1271 *wl);
 int wl1271_acx_config_ps(struct wl1271 *wl);
 int wl1271_acx_set_inconnection_sta(struct wl1271 *wl, u8 *addr);
+int wl1271_acx_set_ap_beacon_filter(struct wl1271 *wl, bool enable);
+int wl1271_acx_fm_coex(struct wl1271 *wl);
 #endif /* __WL1271_ACX_H__ */
diff --git a/drivers/net/wireless/wl12xx/boot.c b/drivers/net/wireless/wl12xx/boot.c
index 6934dffd5174..b07f8b7e5f11 100644
--- a/drivers/net/wireless/wl12xx/boot.c
+++ b/drivers/net/wireless/wl12xx/boot.c
@@ -22,6 +22,7 @@
 */
 #include <linux/slab.h>
+#include <linux/wl12xx.h>
 #include "acx.h"
 #include "reg.h"
@@ -243,33 +244,57 @@ static int wl1271_boot_upload_nvs(struct wl1271 *wl)
        if (wl->nvs == NULL)
                return -ENODEV;
-        /*
+        if (wl->chip.id == CHIP_ID_1283_PG20) {
-         * FIXME: the LEGACY NVS image support (NVS's missing the 5GHz band
+                struct wl128x_nvs_file *nvs = (struct wl128x_nvs_file *)wl->nvs;
-         * configurations) can be removed when those NVS files stop floating
-         * around.
+                if (wl->nvs_len == sizeof(struct wl128x_nvs_file)) {
-         */
+                        if (nvs->general_params.dual_mode_select)
-        if (wl->nvs_len == sizeof(struct wl1271_nvs_file) ||
+                                wl->enable_11a = true;
-            wl->nvs_len == WL1271_INI_LEGACY_NVS_FILE_SIZE) {
+                } else {
-                /* for now 11a is unsupported in AP mode */
+                        wl1271_error("nvs size is not as expected: %zu != %zu",
-                if (wl->bss_type != BSS_TYPE_AP_BSS &&
+                                     wl->nvs_len,
-                    wl->nvs->general_params.dual_mode_select)
+                                     sizeof(struct wl128x_nvs_file));
-                        wl->enable_11a = true;
+                        kfree(wl->nvs);
-        }
+                        wl->nvs = NULL;
+                        wl->nvs_len = 0;
+                        return -EILSEQ;
+                }
-        if (wl->nvs_len != sizeof(struct wl1271_nvs_file) &&
+                /* only the first part of the NVS needs to be uploaded */
-            (wl->nvs_len != WL1271_INI_LEGACY_NVS_FILE_SIZE ||
+                nvs_len = sizeof(nvs->nvs);
-             wl->enable_11a)) {
+                nvs_ptr = (u8 *)nvs->nvs;
-                wl1271_error("nvs size is not as expected: %zu != %zu",
-                             wl->nvs_len, sizeof(struct wl1271_nvs_file));
+        } else {
-                kfree(wl->nvs);
+                struct wl1271_nvs_file *nvs =
-                wl->nvs = NULL;
+                        (struct wl1271_nvs_file *)wl->nvs;
-                wl->nvs_len = 0;
+                /*
-                return -EILSEQ;
+                 * FIXME: the LEGACY NVS image support (NVS's missing the 5GHz
-        }
+                 * band configurations) can be removed when those NVS files stop
+                 * floating around.
+                 */
+                if (wl->nvs_len == sizeof(struct wl1271_nvs_file) ||
+                    wl->nvs_len == WL1271_INI_LEGACY_NVS_FILE_SIZE) {
+                        /* for now 11a is unsupported in AP mode */
+                        if (wl->bss_type != BSS_TYPE_AP_BSS &&
+                            nvs->general_params.dual_mode_select)
+                                wl->enable_11a = true;
+                }
-        /* only the first part of the NVS needs to be uploaded */
+                if (wl->nvs_len != sizeof(struct wl1271_nvs_file) &&
-        nvs_len = sizeof(wl->nvs->nvs);
+                    (wl->nvs_len != WL1271_INI_LEGACY_NVS_FILE_SIZE ||
-        nvs_ptr = (u8 *)wl->nvs->nvs;
+                     wl->enable_11a)) {
+                        wl1271_error("nvs size is not as expected: %zu != %zu",
+                                wl->nvs_len, sizeof(struct wl1271_nvs_file));
+                        kfree(wl->nvs);
+                        wl->nvs = NULL;
+                        wl->nvs_len = 0;
+                        return -EILSEQ;
+                }
+                /* only the first part of the NVS needs to be uploaded */
+                nvs_len = sizeof(nvs->nvs);
+                nvs_ptr = (u8 *) nvs->nvs;
+        }
        /* update current MAC address to NVS */
        nvs_ptr[11] = wl->mac_addr[0];
@@ -319,10 +344,13 @@ static int wl1271_boot_upload_nvs(struct wl1271 *wl)
        /*
         * We've reached the first zero length, the first NVS table
         * is located at an aligned offset which is at least 7 bytes further.
+         * NOTE: The wl->nvs->nvs element must be first, in order to
+         * simplify the casting, we assume it is at the beginning of
+         * the wl->nvs structure.
         */
-        nvs_ptr = (u8 *)wl->nvs->nvs +
+        nvs_ptr = (u8 *)wl->nvs +
-                        ALIGN(nvs_ptr - (u8 *)wl->nvs->nvs + 7, 4);
+                        ALIGN(nvs_ptr - (u8 *)wl->nvs + 7, 4);
-        nvs_len -= nvs_ptr - (u8 *)wl->nvs->nvs;
+        nvs_len -= nvs_ptr - (u8 *)wl->nvs;
        /* Now we must set the partition correctly */
        wl1271_set_partition(wl, &part_table[PART_WORK]);
@@ -450,10 +478,14 @@ static int wl1271_boot_run_firmware(struct wl1271 *wl)
                DISCONNECT_EVENT_COMPLETE_ID |
                RSSI_SNR_TRIGGER_0_EVENT_ID |
                PSPOLL_DELIVERY_FAILURE_EVENT_ID |
-                SOFT_GEMINI_SENSE_EVENT_ID;
+                SOFT_GEMINI_SENSE_EVENT_ID |
+                PERIODIC_SCAN_REPORT_EVENT_ID |
+                PERIODIC_SCAN_COMPLETE_EVENT_ID;
        if (wl->bss_type == BSS_TYPE_AP_BSS)
                wl->event_mask |= STA_REMOVE_COMPLETE_EVENT_ID;
+        else
+                wl->event_mask |= DUMMY_PACKET_EVENT_ID;
        ret = wl1271_event_unmask(wl);
        if (ret < 0) {
@@ -493,24 +525,159 @@ static void wl1271_boot_hw_version(struct wl1271 *wl)
                wl->quirks |= WL12XX_QUIRK_END_OF_TRANSACTION;
 }
-/* uploads NVS and firmware */
+static int wl128x_switch_tcxo_to_fref(struct wl1271 *wl)
-int wl1271_load_firmware(struct wl1271 *wl)
 {
-        int ret = 0;
+        u16 spare_reg;
-        u32 tmp, clk, pause;
+        /* Mask bits [2] & [8:4] in the sys_clk_cfg register */
+        spare_reg = wl1271_top_reg_read(wl, WL_SPARE_REG);
+        if (spare_reg == 0xFFFF)
+                return -EFAULT;
+        spare_reg |= (BIT(3) | BIT(5) | BIT(6));
+        wl1271_top_reg_write(wl, WL_SPARE_REG, spare_reg);
+        /* Enable FREF_CLK_REQ & mux MCS and coex PLLs to FREF */
+        wl1271_top_reg_write(wl, SYS_CLK_CFG_REG,
+                             WL_CLK_REQ_TYPE_PG2 | MCS_PLL_CLK_SEL_FREF);
+        /* Delay execution for 15msec, to let the HW settle */
+        mdelay(15);
+        return 0;
+}
+static bool wl128x_is_tcxo_valid(struct wl1271 *wl)
+{
+        u16 tcxo_detection;
+        tcxo_detection = wl1271_top_reg_read(wl, TCXO_CLK_DETECT_REG);
+        if (tcxo_detection & TCXO_DET_FAILED)
+                return false;
+        return true;
+}
+static bool wl128x_is_fref_valid(struct wl1271 *wl)
+{
+        u16 fref_detection;
+        fref_detection = wl1271_top_reg_read(wl, FREF_CLK_DETECT_REG);
+        if (fref_detection & FREF_CLK_DETECT_FAIL)
+                return false;
+        return true;
+}
+static int wl128x_manually_configure_mcs_pll(struct wl1271 *wl)
+{
+        wl1271_top_reg_write(wl, MCS_PLL_M_REG, MCS_PLL_M_REG_VAL);
+        wl1271_top_reg_write(wl, MCS_PLL_N_REG, MCS_PLL_N_REG_VAL);
+        wl1271_top_reg_write(wl, MCS_PLL_CONFIG_REG, MCS_PLL_CONFIG_REG_VAL);
+        return 0;
+}
+static int wl128x_configure_mcs_pll(struct wl1271 *wl, int clk)
+{
+        u16 spare_reg;
+        u16 pll_config;
+        u8 input_freq;
+        /* Mask bits [3:1] in the sys_clk_cfg register */
+        spare_reg = wl1271_top_reg_read(wl, WL_SPARE_REG);
+        if (spare_reg == 0xFFFF)
+                return -EFAULT;
+        spare_reg |= BIT(2);
+        wl1271_top_reg_write(wl, WL_SPARE_REG, spare_reg);
+        /* Handle special cases of the TCXO clock */
+        if (wl->tcxo_clock == WL12XX_TCXOCLOCK_16_8 ||
+            wl->tcxo_clock == WL12XX_TCXOCLOCK_33_6)
+                return wl128x_manually_configure_mcs_pll(wl);
+        /* Set the input frequency according to the selected clock source */
+        input_freq = (clk & 1) + 1;
+        pll_config = wl1271_top_reg_read(wl, MCS_PLL_CONFIG_REG);
+        if (pll_config == 0xFFFF)
+                return -EFAULT;
+        pll_config |= (input_freq << MCS_SEL_IN_FREQ_SHIFT);
+        pll_config |= MCS_PLL_ENABLE_HP;
+        wl1271_top_reg_write(wl, MCS_PLL_CONFIG_REG, pll_config);
+        return 0;
+}
+/*
+ * WL128x has two clocks input - TCXO and FREF.
+ * TCXO is the main clock of the device, while FREF is used to sync
+ * between the GPS and the cellular modem.
+ * In cases where TCXO is 32.736MHz or 16.368MHz, the FREF will be used
+ * as the WLAN/BT main clock.
+ */
+static int wl128x_boot_clk(struct wl1271 *wl, int *selected_clock)
+{
+        u16 sys_clk_cfg;
+        /* For XTAL-only modes, FREF will be used after switching from TCXO */
+        if (wl->ref_clock == WL12XX_REFCLOCK_26_XTAL ||
+            wl->ref_clock == WL12XX_REFCLOCK_38_XTAL) {
+                if (!wl128x_switch_tcxo_to_fref(wl))
+                        return -EINVAL;
+                goto fref_clk;
+        }
+        /* Query the HW, to determine which clock source we should use */
+        sys_clk_cfg = wl1271_top_reg_read(wl, SYS_CLK_CFG_REG);
+        if (sys_clk_cfg == 0xFFFF)
+                return -EINVAL;
+        if (sys_clk_cfg & PRCM_CM_EN_MUX_WLAN_FREF)
+                goto fref_clk;
+        /* If TCXO is either 32.736MHz or 16.368MHz, switch to FREF */
+        if (wl->tcxo_clock == WL12XX_TCXOCLOCK_16_368 ||
+            wl->tcxo_clock == WL12XX_TCXOCLOCK_32_736) {
+                if (!wl128x_switch_tcxo_to_fref(wl))
+                        return -EINVAL;
+                goto fref_clk;
+        }
+        /* TCXO clock is selected */
+        if (!wl128x_is_tcxo_valid(wl))
+                return -EINVAL;
+        *selected_clock = wl->tcxo_clock;
+        goto config_mcs_pll;
+fref_clk:
+        /* FREF clock is selected */
+        if (!wl128x_is_fref_valid(wl))
+                return -EINVAL;
+        *selected_clock = wl->ref_clock;
+config_mcs_pll:
+        return wl128x_configure_mcs_pll(wl, *selected_clock);
+}
+static int wl127x_boot_clk(struct wl1271 *wl)
+{
+        u32 pause;
+        u32 clk;
        wl1271_boot_hw_version(wl);
-        if (wl->ref_clock == 0 || wl->ref_clock == 2 || wl->ref_clock == 4)
+        if (wl->ref_clock == CONF_REF_CLK_19_2_E ||
+            wl->ref_clock == CONF_REF_CLK_38_4_E ||
+            wl->ref_clock == CONF_REF_CLK_38_4_M_XTAL)
                /* ref clk: 19.2/38.4/38.4-XTAL */
                clk = 0x3;
-        else if (wl->ref_clock == 1 || wl->ref_clock == 3)
+        else if (wl->ref_clock == CONF_REF_CLK_26_E ||
+                 wl->ref_clock == CONF_REF_CLK_52_E)
                /* ref clk: 26/52 */
                clk = 0x5;
        else
                return -EINVAL;
-        if (wl->ref_clock != 0) {
+        if (wl->ref_clock != CONF_REF_CLK_19_2_E) {
                u16 val;
                /* Set clock type (open drain) */
                val = wl1271_top_reg_read(wl, OCP_REG_CLK_TYPE);
@@ -540,6 +707,26 @@ int wl1271_load_firmware(struct wl1271 *wl)
        pause |= WU_COUNTER_PAUSE_VAL;
        wl1271_write32(wl, WU_COUNTER_PAUSE, pause);
+        return 0;
+}
+/* uploads NVS and firmware */
+int wl1271_load_firmware(struct wl1271 *wl)
+{
+        int ret = 0;
+        u32 tmp, clk;
+        int selected_clock = -1;
+        if (wl->chip.id == CHIP_ID_1283_PG20) {
+                ret = wl128x_boot_clk(wl, &selected_clock);
+                if (ret < 0)
+                        goto out;
+        } else {
+                ret = wl127x_boot_clk(wl);
+                if (ret < 0)
+                        goto out;
+        }
        /* Continue the ELP wake up sequence */
        wl1271_write32(wl, WELP_ARM_COMMAND, WELP_ARM_COMMAND_VAL);
        udelay(500);
@@ -555,7 +742,12 @@ int wl1271_load_firmware(struct wl1271 *wl)
        wl1271_debug(DEBUG_BOOT, "clk2 0x%x", clk);
-        clk |= (wl->ref_clock << 1) << 4;
+        if (wl->chip.id == CHIP_ID_1283_PG20) {
+                clk |= ((selected_clock & 0x3) << 1) << 4;
+        } else {
+                clk |= (wl->ref_clock << 1) << 4;
+        }
        wl1271_write32(wl, DRPW_SCRATCH_START, clk);
        wl1271_set_partition(wl, &part_table[PART_WORK]);
@@ -585,16 +777,12 @@ int wl1271_load_firmware(struct wl1271 *wl)
        /* 6. read the EEPROM parameters */
        tmp = wl1271_read32(wl, SCR_PAD2);
-        ret = wl1271_boot_write_irq_polarity(wl);
-        if (ret < 0)
-                goto out;
-        wl1271_write32(wl, ACX_REG_INTERRUPT_MASK,
-                       WL1271_ACX_ALL_EVENTS_VECTOR);
        /* WL1271: The reference driver skips steps 7 to 10 (jumps directly
         * to upload_fw) */
+        if (wl->chip.id == CHIP_ID_1283_PG20)
+                wl1271_top_reg_write(wl, SDIO_IO_DS, wl->conf.hci_io_ds);
        ret = wl1271_boot_upload_firmware(wl);
        if (ret < 0)
                goto out;
@@ -618,6 +806,13 @@ int wl1271_boot(struct wl1271 *wl)
        if (ret < 0)
                goto out;
+        ret = wl1271_boot_write_irq_polarity(wl);
+        if (ret < 0)
+                goto out;
+        wl1271_write32(wl, ACX_REG_INTERRUPT_MASK,
+                       WL1271_ACX_ALL_EVENTS_VECTOR);
        /* Enable firmware interrupts now */
        wl1271_boot_enable_interrupts(wl);
diff --git a/drivers/net/wireless/wl12xx/boot.h b/drivers/net/wireless/wl12xx/boot.h
index 17229b86fc71..e8f8255bbabe 100644
--- a/drivers/net/wireless/wl12xx/boot.h
+++ b/drivers/net/wireless/wl12xx/boot.h
@@ -74,4 +74,56 @@ struct wl1271_static_data {
 #define FREF_CLK_POLARITY_BITS 0xfffff8ff
 #define CLK_REQ_OUTN_SEL       0x700
+/* PLL configuration algorithm for wl128x */
+#define SYS_CLK_CFG_REG              0x2200
+/* Bit[0]   -  0-TCXO,  1-FREF */
+#define MCS_PLL_CLK_SEL_FREF         BIT(0)
+/* Bit[3:2] - 01-TCXO, 10-FREF */
+#define WL_CLK_REQ_TYPE_FREF         BIT(3)
+#define WL_CLK_REQ_TYPE_PG2          (BIT(3) | BIT(2))
+/* Bit[4]   -  0-TCXO,  1-FREF */
+#define PRCM_CM_EN_MUX_WLAN_FREF     BIT(4)
+#define TCXO_ILOAD_INT_REG           0x2264
+#define TCXO_CLK_DETECT_REG          0x2266
+#define TCXO_DET_FAILED              BIT(4)
+#define FREF_ILOAD_INT_REG           0x2084
+#define FREF_CLK_DETECT_REG          0x2086
+#define FREF_CLK_DETECT_FAIL         BIT(4)
+/* Use this reg for masking during driver access */
+#define WL_SPARE_REG                 0x2320
+#define WL_SPARE_VAL                 BIT(2)
+/* Bit[6:5:3] -  mask wl write SYS_CLK_CFG[8:5:2:4] */
+#define WL_SPARE_MASK_8526           (BIT(6) | BIT(5) | BIT(3))
+#define PLL_LOCK_COUNTERS_REG        0xD8C
+#define PLL_LOCK_COUNTERS_COEX       0x0F
+#define PLL_LOCK_COUNTERS_MCS        0xF0
+#define MCS_PLL_OVERRIDE_REG         0xD90
+#define MCS_PLL_CONFIG_REG           0xD92
+#define MCS_SEL_IN_FREQ_MASK         0x0070
+#define MCS_SEL_IN_FREQ_SHIFT        4
+#define MCS_PLL_CONFIG_REG_VAL       0x73
+#define MCS_PLL_ENABLE_HP            (BIT(0) | BIT(1))
+#define MCS_PLL_M_REG                0xD94
+#define MCS_PLL_N_REG                0xD96
+#define MCS_PLL_M_REG_VAL            0xC8
+#define MCS_PLL_N_REG_VAL            0x07
+#define SDIO_IO_DS                   0xd14
+/* SDIO/wSPI DS configuration values */
+enum {
+        HCI_IO_DS_8MA = 0,
+        HCI_IO_DS_4MA = 1, /* default */
+        HCI_IO_DS_6MA = 2,
+        HCI_IO_DS_2MA = 3,
+};
+/* end PLL configuration algorithm for wl128x */
 #endif
diff --git a/drivers/net/wireless/wl12xx/cmd.c b/drivers/net/wireless/wl12xx/cmd.c
index 96324336f936..42935ac72663 100644
--- a/drivers/net/wireless/wl12xx/cmd.c
+++ b/drivers/net/wireless/wl12xx/cmd.c
@@ -76,7 +76,7 @@ int wl1271_cmd_send(struct wl1271 *wl, u16 id, void *buf, size_t len,
                if (time_after(jiffies, timeout)) {
                        wl1271_error("command complete timeout");
                        ret = -ETIMEDOUT;
-                        goto out;
+                        goto fail;
                }
                poll_count++;
@@ -96,21 +96,67 @@ int wl1271_cmd_send(struct wl1271 *wl, u16 id, void *buf, size_t len,
        status = le16_to_cpu(cmd->status);
        if (status != CMD_STATUS_SUCCESS) {
                wl1271_error("command execute failure %d", status);
-                ieee80211_queue_work(wl->hw, &wl->recovery_work);
                ret = -EIO;
+                goto fail;
        }
        wl1271_write32(wl, ACX_REG_INTERRUPT_ACK,
                       WL1271_ACX_INTR_CMD_COMPLETE);
+        return 0;
-out:
+fail:
+        WARN_ON(1);
+        ieee80211_queue_work(wl->hw, &wl->recovery_work);
        return ret;
 }
 int wl1271_cmd_general_parms(struct wl1271 *wl)
 {
        struct wl1271_general_parms_cmd *gen_parms;
-        struct wl1271_ini_general_params *gp = &wl->nvs->general_params;
+        struct wl1271_ini_general_params *gp =
+                &((struct wl1271_nvs_file *)wl->nvs)->general_params;
+        bool answer = false;
+        int ret;
+        if (!wl->nvs)
+                return -ENODEV;
+        gen_parms = kzalloc(sizeof(*gen_parms), GFP_KERNEL);
+        if (!gen_parms)
+                return -ENOMEM;
+        gen_parms->test.id = TEST_CMD_INI_FILE_GENERAL_PARAM;
+        memcpy(&gen_parms->general_params, gp, sizeof(*gp));
+        if (gp->tx_bip_fem_auto_detect)
+                answer = true;
+        /* Override the REF CLK from the NVS with the one from platform data */
+        gen_parms->general_params.ref_clock = wl->ref_clock;
+        ret = wl1271_cmd_test(wl, gen_parms, sizeof(*gen_parms), answer);
+        if (ret < 0) {
+                wl1271_warning("CMD_INI_FILE_GENERAL_PARAM failed");
+                goto out;
+        }
+        gp->tx_bip_fem_manufacturer =
+                gen_parms->general_params.tx_bip_fem_manufacturer;
+        wl1271_debug(DEBUG_CMD, "FEM autodetect: %s, manufacturer: %d\n",
+                     answer ? "auto" : "manual", gp->tx_bip_fem_manufacturer);
+out:
+        kfree(gen_parms);
+        return ret;
+}
+int wl128x_cmd_general_parms(struct wl1271 *wl)
+{
+        struct wl128x_general_parms_cmd *gen_parms;
+        struct wl128x_ini_general_params *gp =
+                &((struct wl128x_nvs_file *)wl->nvs)->general_params;
        bool answer = false;
        int ret;
@@ -128,6 +174,10 @@ int wl1271_cmd_general_parms(struct wl1271 *wl)
        if (gp->tx_bip_fem_auto_detect)
                answer = true;
+        /* Replace REF and TCXO CLKs with the ones from platform data */
+        gen_parms->general_params.ref_clock = wl->ref_clock;
+        gen_parms->general_params.tcxo_ref_clock = wl->tcxo_clock;
        ret = wl1271_cmd_test(wl, gen_parms, sizeof(*gen_parms), answer);
        if (ret < 0) {
                wl1271_warning("CMD_INI_FILE_GENERAL_PARAM failed");
@@ -147,8 +197,9 @@ out:
 int wl1271_cmd_radio_parms(struct wl1271 *wl)
 {
+        struct wl1271_nvs_file *nvs = (struct wl1271_nvs_file *)wl->nvs;
        struct wl1271_radio_parms_cmd *radio_parms;
-        struct wl1271_ini_general_params *gp = &wl->nvs->general_params;
+        struct wl1271_ini_general_params *gp = &nvs->general_params;
        int ret;
        if (!wl->nvs)
@@ -161,18 +212,18 @@ int wl1271_cmd_radio_parms(struct wl1271 *wl)
        radio_parms->test.id = TEST_CMD_INI_FILE_RADIO_PARAM;
        /* 2.4GHz parameters */
-        memcpy(&radio_parms->static_params_2, &wl->nvs->stat_radio_params_2,
+        memcpy(&radio_parms->static_params_2, &nvs->stat_radio_params_2,
               sizeof(struct wl1271_ini_band_params_2));
        memcpy(&radio_parms->dyn_params_2,
-               &wl->nvs->dyn_radio_params_2[gp->tx_bip_fem_manufacturer].params,
+               &nvs->dyn_radio_params_2[gp->tx_bip_fem_manufacturer].params,
               sizeof(struct wl1271_ini_fem_params_2));
        /* 5GHz parameters */
        memcpy(&radio_parms->static_params_5,
-               &wl->nvs->stat_radio_params_5,
+               &nvs->stat_radio_params_5,
               sizeof(struct wl1271_ini_band_params_5));
        memcpy(&radio_parms->dyn_params_5,
-               &wl->nvs->dyn_radio_params_5[gp->tx_bip_fem_manufacturer].params,
+               &nvs->dyn_radio_params_5[gp->tx_bip_fem_manufacturer].params,
               sizeof(struct wl1271_ini_fem_params_5));
        wl1271_dump(DEBUG_CMD, "TEST_CMD_INI_FILE_RADIO_PARAM: ",
@@ -186,6 +237,50 @@ int wl1271_cmd_radio_parms(struct wl1271 *wl)
        return ret;
 }
+int wl128x_cmd_radio_parms(struct wl1271 *wl)
+{
+        struct wl128x_nvs_file *nvs = (struct wl128x_nvs_file *)wl->nvs;
+        struct wl128x_radio_parms_cmd *radio_parms;
+        struct wl128x_ini_general_params *gp = &nvs->general_params;
+        int ret;
+        if (!wl->nvs)
+                return -ENODEV;
+        radio_parms = kzalloc(sizeof(*radio_parms), GFP_KERNEL);
+        if (!radio_parms)
+                return -ENOMEM;
+        radio_parms->test.id = TEST_CMD_INI_FILE_RADIO_PARAM;
+        /* 2.4GHz parameters */
+        memcpy(&radio_parms->static_params_2, &nvs->stat_radio_params_2,
+               sizeof(struct wl128x_ini_band_params_2));
+        memcpy(&radio_parms->dyn_params_2,
+               &nvs->dyn_radio_params_2[gp->tx_bip_fem_manufacturer].params,
+               sizeof(struct wl128x_ini_fem_params_2));
+        /* 5GHz parameters */
+        memcpy(&radio_parms->static_params_5,
+               &nvs->stat_radio_params_5,
+               sizeof(struct wl128x_ini_band_params_5));
+        memcpy(&radio_parms->dyn_params_5,
+               &nvs->dyn_radio_params_5[gp->tx_bip_fem_manufacturer].params,
+               sizeof(struct wl128x_ini_fem_params_5));
+        radio_parms->fem_vendor_and_options = nvs->fem_vendor_and_options;
+        wl1271_dump(DEBUG_CMD, "TEST_CMD_INI_FILE_RADIO_PARAM: ",
+                    radio_parms, sizeof(*radio_parms));
+        ret = wl1271_cmd_test(wl, radio_parms, sizeof(*radio_parms), 0);
+        if (ret < 0)
+                wl1271_warning("CMD_INI_FILE_RADIO_PARAM failed");
+        kfree(radio_parms);
+        return ret;
+}
 int wl1271_cmd_ext_radio_parms(struct wl1271 *wl)
 {
        struct wl1271_ext_radio_parms_cmd *ext_radio_parms;
diff --git a/drivers/net/wireless/wl12xx/cmd.h b/drivers/net/wireless/wl12xx/cmd.h
index 54c12e71417e..5cac95d9480c 100644
--- a/drivers/net/wireless/wl12xx/cmd.h
+++ b/drivers/net/wireless/wl12xx/cmd.h
@@ -32,7 +32,9 @@ struct acx_header;
 int wl1271_cmd_send(struct wl1271 *wl, u16 id, void *buf, size_t len,
                    size_t res_len);
 int wl1271_cmd_general_parms(struct wl1271 *wl);
+int wl128x_cmd_general_parms(struct wl1271 *wl);
 int wl1271_cmd_radio_parms(struct wl1271 *wl);
+int wl128x_cmd_radio_parms(struct wl1271 *wl);
 int wl1271_cmd_ext_radio_parms(struct wl1271 *wl);
 int wl1271_cmd_join(struct wl1271 *wl, u8 bss_type);
 int wl1271_cmd_test(struct wl1271 *wl, void *buf, size_t buf_len, u8 answer);
@@ -415,6 +417,21 @@ struct wl1271_general_parms_cmd {
        u8 padding[3];
 } __packed;
+struct wl128x_general_parms_cmd {
+        struct wl1271_cmd_header header;
+        struct wl1271_cmd_test_header test;
+        struct wl128x_ini_general_params general_params;
+        u8 sr_debug_table[WL1271_INI_MAX_SMART_REFLEX_PARAM];
+        u8 sr_sen_n_p;
+        u8 sr_sen_n_p_gain;
+        u8 sr_sen_nrn;
+        u8 sr_sen_prn;
+        u8 padding[3];
+} __packed;
 struct wl1271_radio_parms_cmd {
        struct wl1271_cmd_header header;
@@ -431,6 +448,23 @@ struct wl1271_radio_parms_cmd {
        u8 padding3[2];
 } __packed;
+struct wl128x_radio_parms_cmd {
+        struct wl1271_cmd_header header;
+        struct wl1271_cmd_test_header test;
+        /* Static radio parameters */
+        struct wl128x_ini_band_params_2 static_params_2;
+        struct wl128x_ini_band_params_5 static_params_5;
+        u8 fem_vendor_and_options;
+        /* Dynamic radio parameters */
+        struct wl128x_ini_fem_params_2 dyn_params_2;
+        u8 padding2;
+        struct wl128x_ini_fem_params_5 dyn_params_5;
+} __packed;
 struct wl1271_ext_radio_parms_cmd {
        struct wl1271_cmd_header header;
diff --git a/drivers/net/wireless/wl12xx/conf.h b/drivers/net/wireless/wl12xx/conf.h
index 8a8323896eec..1ab6c86aac40 100644
--- a/drivers/net/wireless/wl12xx/conf.h
+++ b/drivers/net/wireless/wl12xx/conf.h
@@ -396,12 +396,43 @@ enum {
        CONF_SG_TEMP_PARAM_3,
        CONF_SG_TEMP_PARAM_4,
        CONF_SG_TEMP_PARAM_5,
-        CONF_SG_PARAMS_MAX,
+        /*
+         * AP beacon miss
+         *
+         * Range: 0 - 255
+         */
+        CONF_SG_AP_BEACON_MISS_TX,
+        /*
+         * AP RX window length
+         *
+         * Range: 0 - 50
+         */
+        CONF_SG_RX_WINDOW_LENGTH,
+        /*
+         * AP connection protection time
+         *
+         * Range: 0 - 5000
+         */
+        CONF_SG_AP_CONNECTION_PROTECTION_TIME,
+        CONF_SG_TEMP_PARAM_6,
+        CONF_SG_TEMP_PARAM_7,
+        CONF_SG_TEMP_PARAM_8,
+        CONF_SG_TEMP_PARAM_9,
+        CONF_SG_TEMP_PARAM_10,
+        CONF_SG_STA_PARAMS_MAX = CONF_SG_TEMP_PARAM_5 + 1,
+        CONF_SG_AP_PARAMS_MAX = CONF_SG_TEMP_PARAM_10 + 1,
        CONF_SG_PARAMS_ALL = 0xff
 };
 struct conf_sg_settings {
-        u32 params[CONF_SG_PARAMS_MAX];
+        u32 sta_params[CONF_SG_STA_PARAMS_MAX];
+        u32 ap_params[CONF_SG_AP_PARAMS_MAX];
        u8 state;
 };
@@ -509,6 +540,12 @@ struct conf_rx_settings {
        CONF_HW_BIT_RATE_36MBPS | CONF_HW_BIT_RATE_48MBPS |      \
        CONF_HW_BIT_RATE_54MBPS)
+#define CONF_TX_OFDM_RATES (CONF_HW_BIT_RATE_6MBPS |             \
+        CONF_HW_BIT_RATE_12MBPS | CONF_HW_BIT_RATE_24MBPS |      \
+        CONF_HW_BIT_RATE_36MBPS | CONF_HW_BIT_RATE_48MBPS |      \
+        CONF_HW_BIT_RATE_54MBPS)
 /*
 * Default rates for management traffic when operating in AP mode. This
 * should be configured according to the basic rate set of the AP
@@ -516,6 +553,13 @@ struct conf_rx_settings {
 #define CONF_TX_AP_DEFAULT_MGMT_RATES  (CONF_HW_BIT_RATE_1MBPS | \
        CONF_HW_BIT_RATE_2MBPS | CONF_HW_BIT_RATE_5_5MBPS)
+/*
+ * Default rates for working as IBSS. use 11b rates
+ */
+#define CONF_TX_IBSS_DEFAULT_RATES  (CONF_HW_BIT_RATE_1MBPS |       \
+                CONF_HW_BIT_RATE_2MBPS | CONF_HW_BIT_RATE_5_5MBPS | \
+                CONF_HW_BIT_RATE_11MBPS);
 struct conf_tx_rate_class {
        /*
@@ -667,22 +711,6 @@ struct conf_tx_settings {
        struct conf_tx_ac_category ac_conf[CONF_TX_MAX_AC_COUNT];
        /*
-         * Configuration for rate classes in AP-mode. These rate classes
-         * are for the AC TX queues
-         */
-        struct conf_tx_rate_class ap_rc_conf[CONF_TX_MAX_AC_COUNT];
-        /*
-         * Management TX rate class for AP-mode.
-         */
-        struct conf_tx_rate_class ap_mgmt_conf;
-        /*
-         * Broadcast TX rate class for AP-mode.
-         */
-        struct conf_tx_rate_class ap_bcst_conf;
-        /*
         * AP-mode - allow this number of TX retries to a station before an
         * event is triggered from FW.
         */
@@ -1004,7 +1032,9 @@ enum {
        CONF_REF_CLK_19_2_E,
        CONF_REF_CLK_26_E,
        CONF_REF_CLK_38_4_E,
-        CONF_REF_CLK_52_E
+        CONF_REF_CLK_52_E,
+        CONF_REF_CLK_38_4_M_XTAL,
+        CONF_REF_CLK_26_M_XTAL,
 };
 enum single_dual_band_enum {
@@ -1018,15 +1048,6 @@ enum single_dual_band_enum {
 #define CONF_NUMBER_OF_CHANNELS_2_4 14
 #define CONF_NUMBER_OF_CHANNELS_5   35
-struct conf_radio_parms {
-        /*
-         * FEM parameter set to use
-         *
-         * Range: 0 or 1
-         */
-        u8 fem;
-};
 struct conf_itrim_settings {
        /* enable dco itrim */
        u8 enable;
@@ -1126,6 +1147,26 @@ struct conf_scan_settings {
 };
+struct conf_sched_scan_settings {
+        /* minimum time to wait on the channel for active scans (in TUs) */
+        u16 min_dwell_time_active;
+        /* maximum time to wait on the channel for active scans (in TUs) */
+        u16 max_dwell_time_active;
+        /* time to wait on the channel for passive scans (in TUs) */
+        u32 dwell_time_passive;
+        /* number of probe requests to send on each channel in active scans */
+        u8 num_probe_reqs;
+        /* RSSI threshold to be used for filtering */
+        s8 rssi_threshold;
+        /* SNR threshold to be used for filtering */
+        s8 snr_threshold;
+};
 /* these are number of channels on the band divided by two, rounded up */
 #define CONF_TX_PWR_COMPENSATION_LEN_2 7
 #define CONF_TX_PWR_COMPENSATION_LEN_5 18
@@ -1191,6 +1232,19 @@ struct conf_memory_settings {
        u8 tx_min;
 };
+struct conf_fm_coex {
+        u8 enable;
+        u8 swallow_period;
+        u8 n_divider_fref_set_1;
+        u8 n_divider_fref_set_2;
+        u16 m_divider_fref_set_1;
+        u16 m_divider_fref_set_2;
+        u32 coex_pll_stabilization_time;
+        u16 ldo_stabilization_time;
+        u8 fm_disturbed_band_margin;
+        u8 swallow_clk_diff;
+};
 struct conf_drv_settings {
        struct conf_sg_settings sg;
        struct conf_rx_settings rx;
@@ -1200,9 +1254,13 @@ struct conf_drv_settings {
        struct conf_pm_config_settings pm_config;
        struct conf_roam_trigger_settings roam_trigger;
        struct conf_scan_settings scan;
+        struct conf_sched_scan_settings sched_scan;
        struct conf_rf_settings rf;
        struct conf_ht_setting ht;
-        struct conf_memory_settings mem;
+        struct conf_memory_settings mem_wl127x;
+        struct conf_memory_settings mem_wl128x;
+        struct conf_fm_coex fm_coex;
+        u8 hci_io_ds;
 };
 #endif
diff --git a/drivers/net/wireless/wl12xx/debugfs.c b/drivers/net/wireless/wl12xx/debugfs.c
index 8e75b09723b9..f1f8df9b6cd7 100644
--- a/drivers/net/wireless/wl12xx/debugfs.c
+++ b/drivers/net/wireless/wl12xx/debugfs.c
@@ -267,7 +267,7 @@ static ssize_t gpio_power_write(struct file *file,
        }
        buf[len] = '\0';
-        ret = strict_strtoul(buf, 0, &value);
+        ret = kstrtoul(buf, 0, &value);
        if (ret < 0) {
                wl1271_warning("illegal value in gpio_power");
                return -EINVAL;
@@ -291,6 +291,242 @@ static const struct file_operations gpio_power_ops = {
        .llseek = default_llseek,
 };
+static ssize_t start_recovery_write(struct file *file,
+                                    const char __user *user_buf,
+                                    size_t count, loff_t *ppos)
+{
+        struct wl1271 *wl = file->private_data;
+        mutex_lock(&wl->mutex);
+        ieee80211_queue_work(wl->hw, &wl->recovery_work);
+        mutex_unlock(&wl->mutex);
+        return count;
+}
+static const struct file_operations start_recovery_ops = {
+        .write = start_recovery_write,
+        .open = wl1271_open_file_generic,
+        .llseek = default_llseek,
+};
+static ssize_t driver_state_read(struct file *file, char __user *user_buf,
+                                 size_t count, loff_t *ppos)
+{
+        struct wl1271 *wl = file->private_data;
+        int res = 0;
+        char buf[1024];
+        mutex_lock(&wl->mutex);
+#define DRIVER_STATE_PRINT(x, fmt)   \
+        (res += scnprintf(buf + res, sizeof(buf) - res,\
+                          #x " = " fmt "\n", wl->x))
+#define DRIVER_STATE_PRINT_LONG(x) DRIVER_STATE_PRINT(x, "%ld")
+#define DRIVER_STATE_PRINT_INT(x)  DRIVER_STATE_PRINT(x, "%d")
+#define DRIVER_STATE_PRINT_STR(x)  DRIVER_STATE_PRINT(x, "%s")
+#define DRIVER_STATE_PRINT_LHEX(x) DRIVER_STATE_PRINT(x, "0x%lx")
+#define DRIVER_STATE_PRINT_HEX(x)  DRIVER_STATE_PRINT(x, "0x%x")
+        DRIVER_STATE_PRINT_INT(tx_blocks_available);
+        DRIVER_STATE_PRINT_INT(tx_allocated_blocks);
+        DRIVER_STATE_PRINT_INT(tx_frames_cnt);
+        DRIVER_STATE_PRINT_LHEX(tx_frames_map[0]);
+        DRIVER_STATE_PRINT_INT(tx_queue_count);
+        DRIVER_STATE_PRINT_INT(tx_packets_count);
+        DRIVER_STATE_PRINT_INT(tx_results_count);
+        DRIVER_STATE_PRINT_LHEX(flags);
+        DRIVER_STATE_PRINT_INT(tx_blocks_freed[0]);
+        DRIVER_STATE_PRINT_INT(tx_blocks_freed[1]);
+        DRIVER_STATE_PRINT_INT(tx_blocks_freed[2]);
+        DRIVER_STATE_PRINT_INT(tx_blocks_freed[3]);
+        DRIVER_STATE_PRINT_INT(tx_security_last_seq);
+        DRIVER_STATE_PRINT_INT(rx_counter);
+        DRIVER_STATE_PRINT_INT(session_counter);
+        DRIVER_STATE_PRINT_INT(state);
+        DRIVER_STATE_PRINT_INT(bss_type);
+        DRIVER_STATE_PRINT_INT(channel);
+        DRIVER_STATE_PRINT_HEX(rate_set);
+        DRIVER_STATE_PRINT_HEX(basic_rate_set);
+        DRIVER_STATE_PRINT_HEX(basic_rate);
+        DRIVER_STATE_PRINT_INT(band);
+        DRIVER_STATE_PRINT_INT(beacon_int);
+        DRIVER_STATE_PRINT_INT(psm_entry_retry);
+        DRIVER_STATE_PRINT_INT(ps_poll_failures);
+        DRIVER_STATE_PRINT_HEX(filters);
+        DRIVER_STATE_PRINT_HEX(rx_config);
+        DRIVER_STATE_PRINT_HEX(rx_filter);
+        DRIVER_STATE_PRINT_INT(power_level);
+        DRIVER_STATE_PRINT_INT(rssi_thold);
+        DRIVER_STATE_PRINT_INT(last_rssi_event);
+        DRIVER_STATE_PRINT_INT(sg_enabled);
+        DRIVER_STATE_PRINT_INT(enable_11a);
+        DRIVER_STATE_PRINT_INT(noise);
+        DRIVER_STATE_PRINT_LHEX(ap_hlid_map[0]);
+        DRIVER_STATE_PRINT_INT(last_tx_hlid);
+        DRIVER_STATE_PRINT_INT(ba_support);
+        DRIVER_STATE_PRINT_HEX(ba_rx_bitmap);
+        DRIVER_STATE_PRINT_HEX(ap_fw_ps_map);
+        DRIVER_STATE_PRINT_LHEX(ap_ps_map);
+        DRIVER_STATE_PRINT_HEX(quirks);
+        DRIVER_STATE_PRINT_HEX(irq);
+        DRIVER_STATE_PRINT_HEX(ref_clock);
+        DRIVER_STATE_PRINT_HEX(tcxo_clock);
+        DRIVER_STATE_PRINT_HEX(hw_pg_ver);
+        DRIVER_STATE_PRINT_HEX(platform_quirks);
+        DRIVER_STATE_PRINT_HEX(chip.id);
+        DRIVER_STATE_PRINT_STR(chip.fw_ver_str);
+        DRIVER_STATE_PRINT_INT(sched_scanning);
+#undef DRIVER_STATE_PRINT_INT
+#undef DRIVER_STATE_PRINT_LONG
+#undef DRIVER_STATE_PRINT_HEX
+#undef DRIVER_STATE_PRINT_LHEX
+#undef DRIVER_STATE_PRINT_STR
+#undef DRIVER_STATE_PRINT
+        mutex_unlock(&wl->mutex);
+        return simple_read_from_buffer(user_buf, count, ppos, buf, res);
+}
+static const struct file_operations driver_state_ops = {
+        .read = driver_state_read,
+        .open = wl1271_open_file_generic,
+        .llseek = default_llseek,
+};
+static ssize_t dtim_interval_read(struct file *file, char __user *user_buf,
+                                  size_t count, loff_t *ppos)
+{
+        struct wl1271 *wl = file->private_data;
+        u8 value;
+        if (wl->conf.conn.wake_up_event == CONF_WAKE_UP_EVENT_DTIM ||
+            wl->conf.conn.wake_up_event == CONF_WAKE_UP_EVENT_N_DTIM)
+                value = wl->conf.conn.listen_interval;
+        else
+                value = 0;
+        return wl1271_format_buffer(user_buf, count, ppos, "%d\n", value);
+}
+static ssize_t dtim_interval_write(struct file *file,
+                                   const char __user *user_buf,
+                                   size_t count, loff_t *ppos)
+{
+        struct wl1271 *wl = file->private_data;
+        char buf[10];
+        size_t len;
+        unsigned long value;
+        int ret;
+        len = min(count, sizeof(buf) - 1);
+        if (copy_from_user(buf, user_buf, len))
+                return -EFAULT;
+        buf[len] = '\0';
+        ret = kstrtoul(buf, 0, &value);
+        if (ret < 0) {
+                wl1271_warning("illegal value for dtim_interval");
+                return -EINVAL;
+        }
+        if (value < 1 || value > 10) {
+                wl1271_warning("dtim value is not in valid range");
+                return -ERANGE;
+        }
+        mutex_lock(&wl->mutex);
+        wl->conf.conn.listen_interval = value;
+        /* for some reason there are different event types for 1 and >1 */
+        if (value == 1)
+                wl->conf.conn.wake_up_event = CONF_WAKE_UP_EVENT_DTIM;
+        else
+                wl->conf.conn.wake_up_event = CONF_WAKE_UP_EVENT_N_DTIM;
+        /*
+         * we don't reconfigure ACX_WAKE_UP_CONDITIONS now, so it will only
+         * take effect on the next time we enter psm.
+         */
+        mutex_unlock(&wl->mutex);
+        return count;
+}
+static const struct file_operations dtim_interval_ops = {
+        .read = dtim_interval_read,
+        .write = dtim_interval_write,
+        .open = wl1271_open_file_generic,
+        .llseek = default_llseek,
+};
+static ssize_t beacon_interval_read(struct file *file, char __user *user_buf,
+                                    size_t count, loff_t *ppos)
+{
+        struct wl1271 *wl = file->private_data;
+        u8 value;
+        if (wl->conf.conn.wake_up_event == CONF_WAKE_UP_EVENT_BEACON ||
+            wl->conf.conn.wake_up_event == CONF_WAKE_UP_EVENT_N_BEACONS)
+                value = wl->conf.conn.listen_interval;
+        else
+                value = 0;
+        return wl1271_format_buffer(user_buf, count, ppos, "%d\n", value);
+}
+static ssize_t beacon_interval_write(struct file *file,
+                                     const char __user *user_buf,
+                                     size_t count, loff_t *ppos)
+{
+        struct wl1271 *wl = file->private_data;
+        char buf[10];
+        size_t len;
+        unsigned long value;
+        int ret;
+        len = min(count, sizeof(buf) - 1);
+        if (copy_from_user(buf, user_buf, len))
+                return -EFAULT;
+        buf[len] = '\0';
+        ret = kstrtoul(buf, 0, &value);
+        if (ret < 0) {
+                wl1271_warning("illegal value for beacon_interval");
+                return -EINVAL;
+        }
+        if (value < 1 || value > 255) {
+                wl1271_warning("beacon interval value is not in valid range");
+                return -ERANGE;
+        }
+        mutex_lock(&wl->mutex);
+        wl->conf.conn.listen_interval = value;
+        /* for some reason there are different event types for 1 and >1 */
+        if (value == 1)
+                wl->conf.conn.wake_up_event = CONF_WAKE_UP_EVENT_BEACON;
+        else
+                wl->conf.conn.wake_up_event = CONF_WAKE_UP_EVENT_N_BEACONS;
+        /*
+         * we don't reconfigure ACX_WAKE_UP_CONDITIONS now, so it will only
+         * take effect on the next time we enter psm.
+         */
+        mutex_unlock(&wl->mutex);
+        return count;
+}
+static const struct file_operations beacon_interval_ops = {
+        .read = beacon_interval_read,
+        .write = beacon_interval_write,
+        .open = wl1271_open_file_generic,
+        .llseek = default_llseek,
+};
 static int wl1271_debugfs_add_files(struct wl1271 *wl,
                                     struct dentry *rootdir)
 {
@@ -399,6 +635,10 @@ static int wl1271_debugfs_add_files(struct wl1271 *wl,
        DEBUGFS_ADD(excessive_retries, rootdir);
        DEBUGFS_ADD(gpio_power, rootdir);
+        DEBUGFS_ADD(start_recovery, rootdir);
+        DEBUGFS_ADD(driver_state, rootdir);
+        DEBUGFS_ADD(dtim_interval, rootdir);
+        DEBUGFS_ADD(beacon_interval, rootdir);
        return 0;
diff --git a/drivers/net/wireless/wl12xx/event.c b/drivers/net/wireless/wl12xx/event.c
index 1b170c5cc595..c3c554cd6580 100644
--- a/drivers/net/wireless/wl12xx/event.c
+++ b/drivers/net/wireless/wl12xx/event.c
@@ -33,6 +33,7 @@ void wl1271_pspoll_work(struct work_struct *work)
 {
        struct delayed_work *dwork;
        struct wl1271 *wl;
+        int ret;
        dwork = container_of(work, struct delayed_work, work);
        wl = container_of(dwork, struct wl1271, pspoll_work);
@@ -55,8 +56,13 @@ void wl1271_pspoll_work(struct work_struct *work)
         * delivery failure occurred, and no-one changed state since, so
         * we should go back to powersave.
         */
+        ret = wl1271_ps_elp_wakeup(wl);
+        if (ret < 0)
+                goto out;
        wl1271_ps_set_mode(wl, STATION_POWER_SAVE_MODE, wl->basic_rate, true);
+        wl1271_ps_elp_sleep(wl);
 out:
        mutex_unlock(&wl->mutex);
 };
@@ -132,8 +138,10 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
                if (ret < 0)
                        break;
-                /* go to extremely low power mode */
+                if (wl->ps_compl) {
-                wl1271_ps_elp_sleep(wl);
+                        complete(wl->ps_compl);
+                        wl->ps_compl = NULL;
+                }
                break;
        default:
                break;
@@ -187,6 +195,22 @@ static int wl1271_event_process(struct wl1271 *wl, struct event_mailbox *mbox)
                wl1271_scan_stm(wl);
        }
+        if (vector & PERIODIC_SCAN_REPORT_EVENT_ID) {
+                wl1271_debug(DEBUG_EVENT, "PERIODIC_SCAN_REPORT_EVENT "
+                             "(status 0x%0x)", mbox->scheduled_scan_status);
+                wl1271_scan_sched_scan_results(wl);
+        }
+        if (vector & PERIODIC_SCAN_COMPLETE_EVENT_ID) {
+                wl1271_debug(DEBUG_EVENT, "PERIODIC_SCAN_COMPLETE_EVENT "
+                             "(status 0x%0x)", mbox->scheduled_scan_status);
+                if (wl->sched_scanning) {
+                        wl1271_scan_sched_scan_stop(wl);
+                        ieee80211_sched_scan_stopped(wl->hw);
+                }
+        }
        /* disable dynamic PS when requested by the firmware */
        if (vector & SOFT_GEMINI_SENSE_EVENT_ID &&
            wl->bss_type == BSS_TYPE_STA_BSS) {
@@ -228,6 +252,12 @@ static int wl1271_event_process(struct wl1271 *wl, struct event_mailbox *mbox)
                        wl1271_event_rssi_trigger(wl, mbox);
        }
+        if ((vector & DUMMY_PACKET_EVENT_ID) && !is_ap) {
+                wl1271_debug(DEBUG_EVENT, "DUMMY_PACKET_ID_EVENT_ID");
+                if (wl->vif)
+                        wl1271_tx_dummy_packet(wl);
+        }
        if (wl->vif && beacon_loss)
                ieee80211_connection_loss(wl->vif);
diff --git a/drivers/net/wireless/wl12xx/event.h b/drivers/net/wireless/wl12xx/event.h
index 0e80886f3031..b6cf06e565a4 100644
--- a/drivers/net/wireless/wl12xx/event.h
+++ b/drivers/net/wireless/wl12xx/event.h
@@ -59,7 +59,10 @@ enum {
        BSS_LOSE_EVENT_ID                        = BIT(18),
        REGAINED_BSS_EVENT_ID                    = BIT(19),
        ROAMING_TRIGGER_MAX_TX_RETRY_EVENT_ID    = BIT(20),
-        STA_REMOVE_COMPLETE_EVENT_ID             = BIT(21), /* AP */
+        /* STA: dummy paket for dynamic mem blocks */
+        DUMMY_PACKET_EVENT_ID                    = BIT(21),
+        /* AP: STA remove complete */
+        STA_REMOVE_COMPLETE_EVENT_ID             = BIT(21),
        SOFT_GEMINI_SENSE_EVENT_ID               = BIT(22),
        SOFT_GEMINI_PREDICTION_EVENT_ID          = BIT(23),
        SOFT_GEMINI_AVALANCHE_EVENT_ID           = BIT(24),
diff --git a/drivers/net/wireless/wl12xx/ini.h b/drivers/net/wireless/wl12xx/ini.h
index c330a2583dfd..1420c842b8f1 100644
--- a/drivers/net/wireless/wl12xx/ini.h
+++ b/drivers/net/wireless/wl12xx/ini.h
@@ -41,6 +41,28 @@ struct wl1271_ini_general_params {
        u8 srf3[WL1271_INI_MAX_SMART_REFLEX_PARAM];
 } __packed;
+#define WL128X_INI_MAX_SETTINGS_PARAM 4
+struct wl128x_ini_general_params {
+        u8 ref_clock;
+        u8 settling_time;
+        u8 clk_valid_on_wakeup;
+        u8 tcxo_ref_clock;
+        u8 tcxo_settling_time;
+        u8 tcxo_valid_on_wakeup;
+        u8 tcxo_ldo_voltage;
+        u8 xtal_itrim_val;
+        u8 platform_conf;
+        u8 dual_mode_select;
+        u8 tx_bip_fem_auto_detect;
+        u8 tx_bip_fem_manufacturer;
+        u8 general_settings[WL128X_INI_MAX_SETTINGS_PARAM];
+        u8 sr_state;
+        u8 srf1[WL1271_INI_MAX_SMART_REFLEX_PARAM];
+        u8 srf2[WL1271_INI_MAX_SMART_REFLEX_PARAM];
+        u8 srf3[WL1271_INI_MAX_SMART_REFLEX_PARAM];
+} __packed;
 #define WL1271_INI_RSSI_PROCESS_COMPENS_SIZE 15
 struct wl1271_ini_band_params_2 {
@@ -49,9 +71,16 @@ struct wl1271_ini_band_params_2 {
        u8 rx_rssi_process_compens[WL1271_INI_RSSI_PROCESS_COMPENS_SIZE];
 } __packed;
-#define WL1271_INI_RATE_GROUP_COUNT 6
 #define WL1271_INI_CHANNEL_COUNT_2 14
+struct wl128x_ini_band_params_2 {
+        u8 rx_trace_insertion_loss;
+        u8 tx_trace_loss[WL1271_INI_CHANNEL_COUNT_2];
+        u8 rx_rssi_process_compens[WL1271_INI_RSSI_PROCESS_COMPENS_SIZE];
+} __packed;
+#define WL1271_INI_RATE_GROUP_COUNT 6
 struct wl1271_ini_fem_params_2 {
        __le16 tx_bip_ref_pd_voltage;
        u8 tx_bip_ref_power;
@@ -68,6 +97,28 @@ struct wl1271_ini_fem_params_2 {
        u8 normal_to_degraded_high_thr;
 } __packed;
+#define WL128X_INI_RATE_GROUP_COUNT 7
+/* low and high temperatures */
+#define WL128X_INI_PD_VS_TEMPERATURE_RANGES 2
+struct wl128x_ini_fem_params_2 {
+        __le16 tx_bip_ref_pd_voltage;
+        u8 tx_bip_ref_power;
+        u8 tx_bip_ref_offset;
+        u8 tx_per_rate_pwr_limits_normal[WL128X_INI_RATE_GROUP_COUNT];
+        u8 tx_per_rate_pwr_limits_degraded[WL128X_INI_RATE_GROUP_COUNT];
+        u8 tx_per_rate_pwr_limits_extreme[WL128X_INI_RATE_GROUP_COUNT];
+        u8 tx_per_chan_pwr_limits_11b[WL1271_INI_CHANNEL_COUNT_2];
+        u8 tx_per_chan_pwr_limits_ofdm[WL1271_INI_CHANNEL_COUNT_2];
+        u8 tx_pd_vs_rate_offsets[WL128X_INI_RATE_GROUP_COUNT];
+        u8 tx_ibias[WL128X_INI_RATE_GROUP_COUNT + 1];
+        u8 tx_pd_vs_chan_offsets[WL1271_INI_CHANNEL_COUNT_2];
+        u8 tx_pd_vs_temperature[WL128X_INI_PD_VS_TEMPERATURE_RANGES];
+        u8 rx_fem_insertion_loss;
+        u8 degraded_low_to_normal_thr;
+        u8 normal_to_degraded_high_thr;
+} __packed;
 #define WL1271_INI_CHANNEL_COUNT_5 35
 #define WL1271_INI_SUB_BAND_COUNT_5 7
@@ -77,6 +128,12 @@ struct wl1271_ini_band_params_5 {
        u8 rx_rssi_process_compens[WL1271_INI_RSSI_PROCESS_COMPENS_SIZE];
 } __packed;
+struct wl128x_ini_band_params_5 {
+        u8 rx_trace_insertion_loss[WL1271_INI_SUB_BAND_COUNT_5];
+        u8 tx_trace_loss[WL1271_INI_CHANNEL_COUNT_5];
+        u8 rx_rssi_process_compens[WL1271_INI_RSSI_PROCESS_COMPENS_SIZE];
+} __packed;
 struct wl1271_ini_fem_params_5 {
        __le16 tx_bip_ref_pd_voltage[WL1271_INI_SUB_BAND_COUNT_5];
        u8 tx_bip_ref_power[WL1271_INI_SUB_BAND_COUNT_5];
@@ -92,6 +149,23 @@ struct wl1271_ini_fem_params_5 {
        u8 normal_to_degraded_high_thr;
 } __packed;
+struct wl128x_ini_fem_params_5 {
+        __le16 tx_bip_ref_pd_voltage[WL1271_INI_SUB_BAND_COUNT_5];
+        u8 tx_bip_ref_power[WL1271_INI_SUB_BAND_COUNT_5];
+        u8 tx_bip_ref_offset[WL1271_INI_SUB_BAND_COUNT_5];
+        u8 tx_per_rate_pwr_limits_normal[WL128X_INI_RATE_GROUP_COUNT];
+        u8 tx_per_rate_pwr_limits_degraded[WL128X_INI_RATE_GROUP_COUNT];
+        u8 tx_per_rate_pwr_limits_extreme[WL128X_INI_RATE_GROUP_COUNT];
+        u8 tx_per_chan_pwr_limits_ofdm[WL1271_INI_CHANNEL_COUNT_5];
+        u8 tx_pd_vs_rate_offsets[WL128X_INI_RATE_GROUP_COUNT];
+        u8 tx_ibias[WL128X_INI_RATE_GROUP_COUNT];
+        u8 tx_pd_vs_chan_offsets[WL1271_INI_CHANNEL_COUNT_5];
+        u8 tx_pd_vs_temperature[WL1271_INI_SUB_BAND_COUNT_5 *
+                WL128X_INI_PD_VS_TEMPERATURE_RANGES];
+        u8 rx_fem_insertion_loss[WL1271_INI_SUB_BAND_COUNT_5];
+        u8 degraded_low_to_normal_thr;
+        u8 normal_to_degraded_high_thr;
+} __packed;
 /* NVS data structure */
 #define WL1271_INI_NVS_SECTION_SIZE                  468
@@ -100,7 +174,7 @@ struct wl1271_ini_fem_params_5 {
 #define WL1271_INI_LEGACY_NVS_FILE_SIZE              800
 struct wl1271_nvs_file {
-        /* NVS section */
+        /* NVS section - must be first! */
        u8 nvs[WL1271_INI_NVS_SECTION_SIZE];
        /* INI section */
@@ -120,4 +194,24 @@ struct wl1271_nvs_file {
        } dyn_radio_params_5[WL1271_INI_FEM_MODULE_COUNT];
 } __packed;
+struct wl128x_nvs_file {
+        /* NVS section - must be first! */
+        u8 nvs[WL1271_INI_NVS_SECTION_SIZE];
+        /* INI section */
+        struct wl128x_ini_general_params general_params;
+        u8 fem_vendor_and_options;
+        struct wl128x_ini_band_params_2 stat_radio_params_2;
+        u8 padding2;
+        struct {
+                struct wl128x_ini_fem_params_2 params;
+                u8 padding;
+        } dyn_radio_params_2[WL1271_INI_FEM_MODULE_COUNT];
+        struct wl128x_ini_band_params_5 stat_radio_params_5;
+        u8 padding3;
+        struct {
+                struct wl128x_ini_fem_params_5 params;
+                u8 padding;
+        } dyn_radio_params_5[WL1271_INI_FEM_MODULE_COUNT];
+} __packed;
 #endif
diff --git a/drivers/net/wireless/wl12xx/init.c b/drivers/net/wireless/wl12xx/init.c
index 6072fe457135..a8f4f156c055 100644
--- a/drivers/net/wireless/wl12xx/init.c
+++ b/drivers/net/wireless/wl12xx/init.c
@@ -31,6 +31,7 @@
 #include "cmd.h"
 #include "reg.h"
 #include "tx.h"
+#include "io.h"
 int wl1271_sta_init_templates_config(struct wl1271 *wl)
 {
@@ -257,7 +258,7 @@ int wl1271_init_phy_config(struct wl1271 *wl)
        if (ret < 0)
                return ret;
-        ret = wl1271_acx_rts_threshold(wl, wl->conf.rx.rts_threshold);
+        ret = wl1271_acx_rts_threshold(wl, wl->hw->wiphy->rts_threshold);
        if (ret < 0)
                return ret;
@@ -284,7 +285,10 @@ int wl1271_init_pta(struct wl1271 *wl)
 {
        int ret;
-        ret = wl1271_acx_sg_cfg(wl);
+        if (wl->bss_type == BSS_TYPE_AP_BSS)
+                ret = wl1271_acx_ap_sg_cfg(wl);
+        else
+                ret = wl1271_acx_sta_sg_cfg(wl);
        if (ret < 0)
                return ret;
@@ -321,9 +325,11 @@ static int wl1271_sta_hw_init(struct wl1271 *wl)
 {
        int ret;
-        ret = wl1271_cmd_ext_radio_parms(wl);
+        if (wl->chip.id != CHIP_ID_1283_PG20) {
-        if (ret < 0)
+                ret = wl1271_cmd_ext_radio_parms(wl);
-                return ret;
+                if (ret < 0)
+                        return ret;
+        }
        /* PS config */
        ret = wl1271_acx_config_ps(wl);
@@ -348,8 +354,8 @@ static int wl1271_sta_hw_init(struct wl1271 *wl)
        if (ret < 0)
                return ret;
-        /* Bluetooth WLAN coexistence */
+        /* FM WLAN coexistence */
-        ret = wl1271_init_pta(wl);
+        ret = wl1271_acx_fm_coex(wl);
        if (ret < 0)
                return ret;
@@ -407,7 +413,7 @@ static int wl1271_sta_hw_init_post_mem(struct wl1271 *wl)
 static int wl1271_ap_hw_init(struct wl1271 *wl)
 {
-        int ret, i;
+        int ret;
        ret = wl1271_ap_init_templates_config(wl);
        if (ret < 0)
@@ -418,23 +424,7 @@ static int wl1271_ap_hw_init(struct wl1271 *wl)
        if (ret < 0)
                return ret;
-        /* Configure initial TX rate classes */
+        ret = wl1271_init_ap_rates(wl);
-        for (i = 0; i < wl->conf.tx.ac_conf_count; i++) {
-                ret = wl1271_acx_ap_rate_policy(wl,
-                                &wl->conf.tx.ap_rc_conf[i], i);
-                if (ret < 0)
-                        return ret;
-        }
-        ret = wl1271_acx_ap_rate_policy(wl,
-                                        &wl->conf.tx.ap_mgmt_conf,
-                                        ACX_TX_AP_MODE_MGMT_RATE);
-        if (ret < 0)
-                return ret;
-        ret = wl1271_acx_ap_rate_policy(wl,
-                                        &wl->conf.tx.ap_bcst_conf,
-                                        ACX_TX_AP_MODE_BCST_RATE);
        if (ret < 0)
                return ret;
@@ -449,7 +439,7 @@ static int wl1271_ap_hw_init(struct wl1271 *wl)
        return 0;
 }
-static int wl1271_ap_hw_init_post_mem(struct wl1271 *wl)
+int wl1271_ap_init_templates(struct wl1271 *wl)
 {
        int ret;
@@ -465,6 +455,70 @@ static int wl1271_ap_hw_init_post_mem(struct wl1271 *wl)
        if (ret < 0)
                return ret;
+        /*
+         * when operating as AP we want to receive external beacons for
+         * configuring ERP protection.
+         */
+        ret = wl1271_acx_set_ap_beacon_filter(wl, false);
+        if (ret < 0)
+                return ret;
+        return 0;
+}
+static int wl1271_ap_hw_init_post_mem(struct wl1271 *wl)
+{
+        return wl1271_ap_init_templates(wl);
+}
+int wl1271_init_ap_rates(struct wl1271 *wl)
+{
+        int i, ret;
+        struct conf_tx_rate_class rc;
+        u32 supported_rates;
+        wl1271_debug(DEBUG_AP, "AP basic rate set: 0x%x", wl->basic_rate_set);
+        if (wl->basic_rate_set == 0)
+                return -EINVAL;
+        rc.enabled_rates = wl->basic_rate_set;
+        rc.long_retry_limit = 10;
+        rc.short_retry_limit = 10;
+        rc.aflags = 0;
+        ret = wl1271_acx_ap_rate_policy(wl, &rc, ACX_TX_AP_MODE_MGMT_RATE);
+        if (ret < 0)
+                return ret;
+        /* use the min basic rate for AP broadcast/multicast */
+        rc.enabled_rates = wl1271_tx_min_rate_get(wl);
+        rc.short_retry_limit = 10;
+        rc.long_retry_limit = 10;
+        rc.aflags = 0;
+        ret = wl1271_acx_ap_rate_policy(wl, &rc, ACX_TX_AP_MODE_BCST_RATE);
+        if (ret < 0)
+                return ret;
+        /*
+         * If the basic rates contain OFDM rates, use OFDM only
+         * rates for unicast TX as well. Else use all supported rates.
+         */
+        if ((wl->basic_rate_set & CONF_TX_OFDM_RATES))
+                supported_rates = CONF_TX_OFDM_RATES;
+        else
+                supported_rates = CONF_TX_AP_ENABLED_RATES;
+        /* configure unicast TX rate classes */
+        for (i = 0; i < wl->conf.tx.ac_conf_count; i++) {
+                rc.enabled_rates = supported_rates;
+                rc.short_retry_limit = 10;
+                rc.long_retry_limit = 10;
+                rc.aflags = 0;
+                ret = wl1271_acx_ap_rate_policy(wl, &rc, i);
+                if (ret < 0)
+                        return ret;
+        }
        return 0;
 }
@@ -504,6 +558,27 @@ static int wl1271_set_ba_policies(struct wl1271 *wl)
        return ret;
 }
+int wl1271_chip_specific_init(struct wl1271 *wl)
+{
+        int ret = 0;
+        if (wl->chip.id == CHIP_ID_1283_PG20) {
+                u32 host_cfg_bitmap = HOST_IF_CFG_RX_FIFO_ENABLE;
+                if (wl->quirks & WL12XX_QUIRK_BLOCKSIZE_ALIGNMENT)
+                        /* Enable SDIO padding */
+                        host_cfg_bitmap |= HOST_IF_CFG_TX_PAD_TO_SDIO_BLK;
+                /* Must be before wl1271_acx_init_mem_config() */
+                ret = wl1271_acx_host_if_cfg_bitmap(wl, host_cfg_bitmap);
+                if (ret < 0)
+                        goto out;
+        }
+out:
+        return ret;
+}
 int wl1271_hw_init(struct wl1271 *wl)
 {
        struct conf_tx_ac_category *conf_ac;
@@ -511,11 +586,22 @@ int wl1271_hw_init(struct wl1271 *wl)
        int ret, i;
        bool is_ap = (wl->bss_type == BSS_TYPE_AP_BSS);
-        ret = wl1271_cmd_general_parms(wl);
+        if (wl->chip.id == CHIP_ID_1283_PG20)
+                ret = wl128x_cmd_general_parms(wl);
+        else
+                ret = wl1271_cmd_general_parms(wl);
+        if (ret < 0)
+                return ret;
+        if (wl->chip.id == CHIP_ID_1283_PG20)
+                ret = wl128x_cmd_radio_parms(wl);
+        else
+                ret = wl1271_cmd_radio_parms(wl);
        if (ret < 0)
                return ret;
-        ret = wl1271_cmd_radio_parms(wl);
+        /* Chip-specific init */
+        ret = wl1271_chip_specific_init(wl);
        if (ret < 0)
                return ret;
@@ -528,6 +614,11 @@ int wl1271_hw_init(struct wl1271 *wl)
        if (ret < 0)
                return ret;
+        /* Bluetooth WLAN coexistence */
+        ret = wl1271_init_pta(wl);
+        if (ret < 0)
+                return ret;
        /* Default memory configuration */
        ret = wl1271_acx_init_mem_config(wl);
        if (ret < 0)
@@ -567,7 +658,7 @@ int wl1271_hw_init(struct wl1271 *wl)
                goto out_free_memmap;
        /* Default fragmentation threshold */
-        ret = wl1271_acx_frag_threshold(wl, wl->conf.tx.frag_threshold);
+        ret = wl1271_acx_frag_threshold(wl, wl->hw->wiphy->frag_threshold);
        if (ret < 0)
                goto out_free_memmap;
diff --git a/drivers/net/wireless/wl12xx/init.h b/drivers/net/wireless/wl12xx/init.h
index 3a8bd3f426d2..3a3c230fd292 100644
--- a/drivers/net/wireless/wl12xx/init.h
+++ b/drivers/net/wireless/wl12xx/init.h
@@ -31,6 +31,9 @@ int wl1271_sta_init_templates_config(struct wl1271 *wl);
 int wl1271_init_phy_config(struct wl1271 *wl);
 int wl1271_init_pta(struct wl1271 *wl);
 int wl1271_init_energy_detection(struct wl1271 *wl);
+int wl1271_chip_specific_init(struct wl1271 *wl);
 int wl1271_hw_init(struct wl1271 *wl);
+int wl1271_init_ap_rates(struct wl1271 *wl);
+int wl1271_ap_init_templates(struct wl1271 *wl);
 #endif
diff --git a/drivers/net/wireless/wl12xx/io.c b/drivers/net/wireless/wl12xx/io.c
index d557f73e7c19..da5c1ad942a4 100644
--- a/drivers/net/wireless/wl12xx/io.c
+++ b/drivers/net/wireless/wl12xx/io.c
@@ -29,6 +29,7 @@
 #include "wl12xx.h"
 #include "wl12xx_80211.h"
 #include "io.h"
+#include "tx.h"
 #define OCP_CMD_LOOP  32
@@ -43,6 +44,16 @@
 #define OCP_STATUS_REQ_FAILED 0x20000
 #define OCP_STATUS_RESP_ERROR 0x30000
+bool wl1271_set_block_size(struct wl1271 *wl)
+{
+        if (wl->if_ops->set_block_size) {
+                wl->if_ops->set_block_size(wl, WL12XX_BUS_BLOCK_SIZE);
+                return true;
+        }
+        return false;
+}
 void wl1271_disable_interrupts(struct wl1271 *wl)
 {
        wl->if_ops->disable_irq(wl);
diff --git a/drivers/net/wireless/wl12xx/io.h b/drivers/net/wireless/wl12xx/io.h
index 00c771ea70bf..beed621a8ae0 100644
--- a/drivers/net/wireless/wl12xx/io.h
+++ b/drivers/net/wireless/wl12xx/io.h
@@ -169,5 +169,8 @@ int wl1271_init_ieee80211(struct wl1271 *wl);
 struct ieee80211_hw *wl1271_alloc_hw(void);
 int wl1271_free_hw(struct wl1271 *wl);
 irqreturn_t wl1271_irq(int irq, void *data);
+bool wl1271_set_block_size(struct wl1271 *wl);
+int wl1271_tx_dummy_packet(struct wl1271 *wl);
+void wl1271_configure_filters(struct wl1271 *wl, unsigned int filters);
 #endif
diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index 8b3c8d196b03..bc00e52f6445 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -30,6 +30,7 @@
 #include <linux/vmalloc.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
+#include <linux/wl12xx.h>
 #include "wl12xx.h"
 #include "wl12xx_80211.h"
@@ -50,11 +51,11 @@
 static struct conf_drv_settings default_conf = {
        .sg = {
-                .params = {
+                .sta_params = {
                        [CONF_SG_BT_PER_THRESHOLD]                  = 7500,
                        [CONF_SG_HV3_MAX_OVERRIDE]                  = 0,
                        [CONF_SG_BT_NFS_SAMPLE_INTERVAL]            = 400,
-                        [CONF_SG_BT_LOAD_RATIO]                     = 50,
+                        [CONF_SG_BT_LOAD_RATIO]                     = 200,
                        [CONF_SG_AUTO_PS_MODE]                      = 1,
                        [CONF_SG_AUTO_SCAN_PROBE_REQ]               = 170,
                        [CONF_SG_ACTIVE_SCAN_DURATION_FACTOR_HV3]   = 50,
@@ -100,6 +101,61 @@ static struct conf_drv_settings default_conf = {
                        [CONF_SG_DHCP_TIME]                         = 5000,
                        [CONF_SG_ACTIVE_SCAN_DURATION_FACTOR_A2DP]  = 100,
                },
+                .ap_params = {
+                        [CONF_SG_BT_PER_THRESHOLD]                  = 7500,
+                        [CONF_SG_HV3_MAX_OVERRIDE]                  = 0,
+                        [CONF_SG_BT_NFS_SAMPLE_INTERVAL]            = 400,
+                        [CONF_SG_BT_LOAD_RATIO]                     = 50,
+                        [CONF_SG_AUTO_PS_MODE]                      = 1,
+                        [CONF_SG_AUTO_SCAN_PROBE_REQ]               = 170,
+                        [CONF_SG_ACTIVE_SCAN_DURATION_FACTOR_HV3]   = 50,
+                        [CONF_SG_ANTENNA_CONFIGURATION]             = 0,
+                        [CONF_SG_BEACON_MISS_PERCENT]               = 60,
+                        [CONF_SG_RATE_ADAPT_THRESH]                 = 64,
+                        [CONF_SG_RATE_ADAPT_SNR]                    = 1,
+                        [CONF_SG_WLAN_PS_BT_ACL_MASTER_MIN_BR]      = 10,
+                        [CONF_SG_WLAN_PS_BT_ACL_MASTER_MAX_BR]      = 25,
+                        [CONF_SG_WLAN_PS_MAX_BT_ACL_MASTER_BR]      = 25,
+                        [CONF_SG_WLAN_PS_BT_ACL_SLAVE_MIN_BR]       = 20,
+                        [CONF_SG_WLAN_PS_BT_ACL_SLAVE_MAX_BR]       = 25,
+                        [CONF_SG_WLAN_PS_MAX_BT_ACL_SLAVE_BR]       = 25,
+                        [CONF_SG_WLAN_PS_BT_ACL_MASTER_MIN_EDR]     = 7,
+                        [CONF_SG_WLAN_PS_BT_ACL_MASTER_MAX_EDR]     = 25,
+                        [CONF_SG_WLAN_PS_MAX_BT_ACL_MASTER_EDR]     = 25,
+                        [CONF_SG_WLAN_PS_BT_ACL_SLAVE_MIN_EDR]      = 8,
+                        [CONF_SG_WLAN_PS_BT_ACL_SLAVE_MAX_EDR]      = 25,
+                        [CONF_SG_WLAN_PS_MAX_BT_ACL_SLAVE_EDR]      = 25,
+                        [CONF_SG_RXT]                               = 1200,
+                        [CONF_SG_TXT]                               = 1000,
+                        [CONF_SG_ADAPTIVE_RXT_TXT]                  = 1,
+                        [CONF_SG_PS_POLL_TIMEOUT]                   = 10,
+                        [CONF_SG_UPSD_TIMEOUT]                      = 10,
+                        [CONF_SG_WLAN_ACTIVE_BT_ACL_MASTER_MIN_EDR] = 7,
+                        [CONF_SG_WLAN_ACTIVE_BT_ACL_MASTER_MAX_EDR] = 15,
+                        [CONF_SG_WLAN_ACTIVE_MAX_BT_ACL_MASTER_EDR] = 15,
+                        [CONF_SG_WLAN_ACTIVE_BT_ACL_SLAVE_MIN_EDR]  = 8,
+                        [CONF_SG_WLAN_ACTIVE_BT_ACL_SLAVE_MAX_EDR]  = 20,
+                        [CONF_SG_WLAN_ACTIVE_MAX_BT_ACL_SLAVE_EDR]  = 15,
+                        [CONF_SG_WLAN_ACTIVE_BT_ACL_MIN_BR]         = 20,
+                        [CONF_SG_WLAN_ACTIVE_BT_ACL_MAX_BR]         = 50,
+                        [CONF_SG_WLAN_ACTIVE_MAX_BT_ACL_BR]         = 10,
+                        [CONF_SG_PASSIVE_SCAN_DURATION_FACTOR_HV3]  = 200,
+                        [CONF_SG_PASSIVE_SCAN_DURATION_FACTOR_A2DP] = 800,
+                        [CONF_SG_PASSIVE_SCAN_A2DP_BT_TIME]         = 75,
+                        [CONF_SG_PASSIVE_SCAN_A2DP_WLAN_TIME]       = 15,
+                        [CONF_SG_HV3_MAX_SERVED]                    = 6,
+                        [CONF_SG_DHCP_TIME]                         = 5000,
+                        [CONF_SG_ACTIVE_SCAN_DURATION_FACTOR_A2DP]  = 100,
+                        [CONF_SG_TEMP_PARAM_1]                      = 0,
+                        [CONF_SG_TEMP_PARAM_2]                      = 0,
+                        [CONF_SG_TEMP_PARAM_3]                      = 0,
+                        [CONF_SG_TEMP_PARAM_4]                      = 0,
+                        [CONF_SG_TEMP_PARAM_5]                      = 0,
+                        [CONF_SG_AP_BEACON_MISS_TX]                 = 3,
+                        [CONF_SG_RX_WINDOW_LENGTH]                  = 6,
+                        [CONF_SG_AP_CONNECTION_PROTECTION_TIME]     = 50,
+                        [CONF_SG_TEMP_PARAM_6]                      = 1,
+                },
                .state = CONF_SG_PROTECTIVE,
        },
        .rx = {
@@ -107,7 +163,7 @@ static struct conf_drv_settings default_conf = {
                .packet_detection_threshold  = 0,
                .ps_poll_timeout             = 15,
                .upsd_timeout                = 15,
-                .rts_threshold               = 2347,
+                .rts_threshold               = IEEE80211_MAX_RTS_THRESHOLD,
                .rx_cca_threshold            = 0,
                .irq_blk_threshold           = 0xFFFF,
                .irq_pkt_threshold           = 0,
@@ -153,44 +209,6 @@ static struct conf_drv_settings default_conf = {
                                .tx_op_limit = 1504,
                        },
                },
-                .ap_rc_conf                  = {
-                        [0] = {
-                                .enabled_rates = CONF_TX_AP_ENABLED_RATES,
-                                .short_retry_limit = 10,
-                                .long_retry_limit = 10,
-                                .aflags      = 0,
-                        },
-                        [1] = {
-                                .enabled_rates = CONF_TX_AP_ENABLED_RATES,
-                                .short_retry_limit = 10,
-                                .long_retry_limit = 10,
-                                .aflags      = 0,
-                        },
-                        [2] = {
-                                .enabled_rates = CONF_TX_AP_ENABLED_RATES,
-                                .short_retry_limit = 10,
-                                .long_retry_limit = 10,
-                                .aflags      = 0,
-                        },
-                        [3] = {
-                                .enabled_rates = CONF_TX_AP_ENABLED_RATES,
-                                .short_retry_limit = 10,
-                                .long_retry_limit = 10,
-                                .aflags      = 0,
-                        },
-                },
-                .ap_mgmt_conf = {
-                        .enabled_rates       = CONF_TX_AP_DEFAULT_MGMT_RATES,
-                        .short_retry_limit   = 10,
-                        .long_retry_limit    = 10,
-                        .aflags              = 0,
-                },
-                .ap_bcst_conf = {
-                        .enabled_rates       = CONF_HW_BIT_RATE_1MBPS,
-                        .short_retry_limit   = 10,
-                        .long_retry_limit    = 10,
-                        .aflags              = 0,
-                },
                .ap_max_tx_retries = 100,
                .tid_conf_count = 4,
                .tid_conf = {
@@ -239,12 +257,16 @@ static struct conf_drv_settings default_conf = {
                .wake_up_event               = CONF_WAKE_UP_EVENT_DTIM,
                .listen_interval             = 1,
                .bcn_filt_mode               = CONF_BCN_FILT_MODE_ENABLED,
-                .bcn_filt_ie_count           = 1,
+                .bcn_filt_ie_count           = 2,
                .bcn_filt_ie = {
                        [0] = {
                                .ie          = WLAN_EID_CHANNEL_SWITCH,
                                .rule        = CONF_BCN_RULE_PASS_ON_APPEARANCE,
-                        }
+                        },
+                        [1] = {
+                                .ie          = WLAN_EID_HT_INFORMATION,
+                                .rule        = CONF_BCN_RULE_PASS_ON_CHANGE,
+                        },
                },
                .synch_fail_thold            = 10,
                .bss_lose_timeout            = 100,
@@ -254,9 +276,9 @@ static struct conf_drv_settings default_conf = {
                .ps_poll_threshold           = 10,
                .ps_poll_recovery_period     = 700,
                .bet_enable                  = CONF_BET_MODE_ENABLE,
-                .bet_max_consecutive         = 10,
+                .bet_max_consecutive         = 50,
                .psm_entry_retries           = 5,
-                .psm_exit_retries            = 255,
+                .psm_exit_retries            = 16,
                .psm_entry_nullfunc_retries  = 3,
                .psm_entry_hangover_period   = 1,
                .keep_alive_interval         = 55000,
@@ -284,6 +306,15 @@ static struct conf_drv_settings default_conf = {
                .max_dwell_time_passive       = 100000,
                .num_probe_reqs               = 2,
        },
+        .sched_scan = {
+                /* sched_scan requires dwell times in TU instead of TU/1000 */
+                .min_dwell_time_active = 8,
+                .max_dwell_time_active = 30,
+                .dwell_time_passive    = 100,
+                .num_probe_reqs        = 2,
+                .rssi_threshold        = -90,
+                .snr_threshold         = 0,
+        },
        .rf = {
                .tx_per_channel_power_compensation_2 = {
                        0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
@@ -298,19 +329,43 @@ static struct conf_drv_settings default_conf = {
                .tx_ba_win_size = 64,
                .inactivity_timeout = 10000,
        },
-        .mem = {
+        .mem_wl127x = {
                .num_stations                 = 1,
                .ssid_profiles                = 1,
                .rx_block_num                 = 70,
                .tx_min_block_num             = 40,
-                .dynamic_memory               = 0,
+                .dynamic_memory               = 1,
                .min_req_tx_blocks            = 100,
                .min_req_rx_blocks            = 22,
                .tx_min                       = 27,
-        }
+        },
+        .mem_wl128x = {
+                .num_stations                 = 1,
+                .ssid_profiles                = 1,
+                .rx_block_num                 = 40,
+                .tx_min_block_num             = 40,
+                .dynamic_memory               = 1,
+                .min_req_tx_blocks            = 45,
+                .min_req_rx_blocks            = 22,
+                .tx_min                       = 27,
+        },
+        .fm_coex = {
+                .enable                       = true,
+                .swallow_period               = 5,
+                .n_divider_fref_set_1         = 0xff,       /* default */
+                .n_divider_fref_set_2         = 12,
+                .m_divider_fref_set_1         = 148,
+                .m_divider_fref_set_2         = 0xffff,     /* default */
+                .coex_pll_stabilization_time  = 0xffffffff, /* default */
+                .ldo_stabilization_time       = 0xffff,     /* default */
+                .fm_disturbed_band_margin     = 0xff,       /* default */
+                .swallow_clk_diff             = 0xff,       /* default */
+        },
+        .hci_io_ds = HCI_IO_DS_6MA,
 };
-static void __wl1271_op_remove_interface(struct wl1271 *wl);
+static void __wl1271_op_remove_interface(struct wl1271 *wl,
+                                         bool reset_tx_queues);
 static void wl1271_free_ap_keys(struct wl1271 *wl);
@@ -329,6 +384,7 @@ static struct platform_device wl1271_device = {
        },
 };
+static DEFINE_MUTEX(wl_list_mutex);
 static LIST_HEAD(wl_list);
 static int wl1271_dev_notify(struct notifier_block *me, unsigned long what,
@@ -359,10 +415,12 @@ static int wl1271_dev_notify(struct notifier_block *me, unsigned long what,
                return NOTIFY_DONE;
        wl_temp = hw->priv;
+        mutex_lock(&wl_list_mutex);
        list_for_each_entry(wl, &wl_list, list) {
                if (wl == wl_temp)
                        break;
        }
+        mutex_unlock(&wl_list_mutex);
        if (wl != wl_temp)
                return NOTIFY_DONE;
@@ -438,15 +496,30 @@ static int wl1271_plt_init(struct wl1271 *wl)
        struct conf_tx_tid *conf_tid;
        int ret, i;
-        ret = wl1271_cmd_general_parms(wl);
+        if (wl->chip.id == CHIP_ID_1283_PG20)
+                ret = wl128x_cmd_general_parms(wl);
+        else
+                ret = wl1271_cmd_general_parms(wl);
+        if (ret < 0)
+                return ret;
+        if (wl->chip.id == CHIP_ID_1283_PG20)
+                ret = wl128x_cmd_radio_parms(wl);
+        else
+                ret = wl1271_cmd_radio_parms(wl);
        if (ret < 0)
                return ret;
-        ret = wl1271_cmd_radio_parms(wl);
+        if (wl->chip.id != CHIP_ID_1283_PG20) {
+                ret = wl1271_cmd_ext_radio_parms(wl);
+                if (ret < 0)
+                        return ret;
+        }
        if (ret < 0)
                return ret;
-        ret = wl1271_cmd_ext_radio_parms(wl);
+        /* Chip-specific initializations */
+        ret = wl1271_chip_specific_init(wl);
        if (ret < 0)
                return ret;
@@ -477,6 +550,11 @@ static int wl1271_plt_init(struct wl1271 *wl)
        if (ret < 0)
                goto out_free_memmap;
+        /* FM WLAN coexistence */
+        ret = wl1271_acx_fm_coex(wl);
+        if (ret < 0)
+                goto out_free_memmap;
        /* Energy detection */
        ret = wl1271_init_energy_detection(wl);
        if (ret < 0)
@@ -593,15 +671,17 @@ static void wl1271_fw_status(struct wl1271 *wl,
 {
        struct wl1271_fw_common_status *status = &full_status->common;
        struct timespec ts;
-        u32 total = 0;
+        u32 old_tx_blk_count = wl->tx_blocks_available;
+        u32 freed_blocks = 0;
        int i;
-        if (wl->bss_type == BSS_TYPE_AP_BSS)
+        if (wl->bss_type == BSS_TYPE_AP_BSS) {
                wl1271_raw_read(wl, FW_STATUS_ADDR, status,
                                sizeof(struct wl1271_fw_ap_status), false);
-        else
+        } else {
                wl1271_raw_read(wl, FW_STATUS_ADDR, status,
                                sizeof(struct wl1271_fw_sta_status), false);
+        }
        wl1271_debug(DEBUG_IRQ, "intr: 0x%x (fw_rx_counter = %d, "
                     "drv_rx_counter = %d, tx_results_counter = %d)",
@@ -612,22 +692,37 @@ static void wl1271_fw_status(struct wl1271 *wl,
        /* update number of available TX blocks */
        for (i = 0; i < NUM_TX_QUEUES; i++) {
-                u32 cnt = le32_to_cpu(status->tx_released_blks[i]) -
+                freed_blocks += le32_to_cpu(status->tx_released_blks[i]) -
-                        wl->tx_blocks_freed[i];
+                                wl->tx_blocks_freed[i];
                wl->tx_blocks_freed[i] =
                        le32_to_cpu(status->tx_released_blks[i]);
-                wl->tx_blocks_available += cnt;
-                total += cnt;
        }
-        /* if more blocks are available now, tx work can be scheduled */
+        wl->tx_allocated_blocks -= freed_blocks;
-        if (total)
-                clear_bit(WL1271_FLAG_FW_TX_BUSY, &wl->flags);
-        /* for AP update num of allocated TX blocks per link and ps status */
+        if (wl->bss_type == BSS_TYPE_AP_BSS) {
-        if (wl->bss_type == BSS_TYPE_AP_BSS)
+                /* Update num of allocated TX blocks per link and ps status */
                wl1271_irq_update_links_status(wl, &full_status->ap);
+                wl->tx_blocks_available += freed_blocks;
+        } else {
+                int avail = full_status->sta.tx_total - wl->tx_allocated_blocks;
+                /*
+                 * The FW might change the total number of TX memblocks before
+                 * we get a notification about blocks being released. Thus, the
+                 * available blocks calculation might yield a temporary result
+                 * which is lower than the actual available blocks. Keeping in
+                 * mind that only blocks that were allocated can be moved from
+                 * TX to RX, tx_blocks_available should never decrease here.
+                 */
+                wl->tx_blocks_available = max((int)wl->tx_blocks_available,
+                                              avail);
+        }
+        /* if more blocks are available now, tx work can be scheduled */
+        if (wl->tx_blocks_available > old_tx_blk_count)
+                clear_bit(WL1271_FLAG_FW_TX_BUSY, &wl->flags);
        /* update the host-chipset time offset */
        getnstimeofday(&ts);
@@ -674,6 +769,13 @@ irqreturn_t wl1271_irq(int irq, void *cookie)
        set_bit(WL1271_FLAG_TX_PENDING, &wl->flags);
        cancel_work_sync(&wl->tx_work);
+        /*
+         * In case edge triggered interrupt must be used, we cannot iterate
+         * more than once without introducing race conditions with the hardirq.
+         */
+        if (wl->platform_quirks & WL12XX_PLATFORM_QUIRK_EDGE_IRQ)
+                loopcount = 1;
        mutex_lock(&wl->mutex);
        wl1271_debug(DEBUG_IRQ, "IRQ work");
@@ -785,11 +887,17 @@ static int wl1271_fetch_firmware(struct wl1271 *wl)
        switch (wl->bss_type) {
        case BSS_TYPE_AP_BSS:
-                fw_name = WL1271_AP_FW_NAME;
+                if (wl->chip.id == CHIP_ID_1283_PG20)
+                        fw_name = WL128X_AP_FW_NAME;
+                else
+                        fw_name = WL127X_AP_FW_NAME;
                break;
        case BSS_TYPE_IBSS:
        case BSS_TYPE_STA_BSS:
-                fw_name = WL1271_FW_NAME;
+                if (wl->chip.id == CHIP_ID_1283_PG20)
+                        fw_name = WL128X_FW_NAME;
+                else
+                        fw_name = WL1271_FW_NAME;
                break;
        default:
                wl1271_error("no compatible firmware for bss_type %d",
@@ -838,14 +946,14 @@ static int wl1271_fetch_nvs(struct wl1271 *wl)
        const struct firmware *fw;
        int ret;
-        ret = request_firmware(&fw, WL1271_NVS_NAME, wl1271_wl_to_dev(wl));
+        ret = request_firmware(&fw, WL12XX_NVS_NAME, wl1271_wl_to_dev(wl));
        if (ret < 0) {
                wl1271_error("could not get nvs file: %d", ret);
                return ret;
        }
-        wl->nvs = kmemdup(fw->data, sizeof(struct wl1271_nvs_file), GFP_KERNEL);
+        wl->nvs = kmemdup(fw->data, fw->size, GFP_KERNEL);
        if (!wl->nvs) {
                wl1271_error("could not allocate memory for the nvs file");
@@ -871,15 +979,30 @@ static void wl1271_recovery_work(struct work_struct *work)
        if (wl->state != WL1271_STATE_ON)
                goto out;
-        wl1271_info("Hardware recovery in progress.");
+        wl1271_info("Hardware recovery in progress. FW ver: %s pc: 0x%x",
+                    wl->chip.fw_ver_str, wl1271_read32(wl, SCR_PAD4));
        if (test_bit(WL1271_FLAG_STA_ASSOCIATED, &wl->flags))
                ieee80211_connection_loss(wl->vif);
+        /* Prevent spurious TX during FW restart */
+        ieee80211_stop_queues(wl->hw);
+        if (wl->sched_scanning) {
+                ieee80211_sched_scan_stopped(wl->hw);
+                wl->sched_scanning = false;
+        }
        /* reboot the chipset */
-        __wl1271_op_remove_interface(wl);
+        __wl1271_op_remove_interface(wl, false);
        ieee80211_restart_hw(wl->hw);
+        /*
+         * Its safe to enable TX now - the queues are stopped after a request
+         * to restart the HW.
+         */
+        ieee80211_wake_queues(wl->hw);
 out:
        mutex_unlock(&wl->mutex);
 }
@@ -950,10 +1073,25 @@ static int wl1271_chip_wakeup(struct wl1271 *wl)
                wl1271_debug(DEBUG_BOOT, "chip id 0x%x (1271 PG20)",
                             wl->chip.id);
+                /* end-of-transaction flag should be set in wl127x AP mode */
+                if (wl->bss_type == BSS_TYPE_AP_BSS)
+                        wl->quirks |= WL12XX_QUIRK_END_OF_TRANSACTION;
                ret = wl1271_setup(wl);
                if (ret < 0)
                        goto out;
                break;
+        case CHIP_ID_1283_PG20:
+                wl1271_debug(DEBUG_BOOT, "chip id 0x%x (1283 PG20)",
+                             wl->chip.id);
+                ret = wl1271_setup(wl);
+                if (ret < 0)
+                        goto out;
+                if (wl1271_set_block_size(wl))
+                        wl->quirks |= WL12XX_QUIRK_BLOCKSIZE_ALIGNMENT;
+                break;
+        case CHIP_ID_1283_PG10:
        default:
                wl1271_warning("unsupported chip id: 0x%x", wl->chip.id);
                ret = -ENODEV;
@@ -978,6 +1116,24 @@ out:
        return ret;
 }
+static unsigned int wl1271_get_fw_ver_quirks(struct wl1271 *wl)
+{
+        unsigned int quirks = 0;
+        unsigned int *fw_ver = wl->chip.fw_ver;
+        /* Only for wl127x */
+        if ((fw_ver[FW_VER_CHIP] == FW_VER_CHIP_WL127X) &&
+            /* Check STA version */
+            (((fw_ver[FW_VER_IF_TYPE] == FW_VER_IF_TYPE_STA) &&
+              (fw_ver[FW_VER_MINOR] < FW_VER_MINOR_1_SPARE_STA_MIN)) ||
+             /* Check AP version */
+             ((fw_ver[FW_VER_IF_TYPE] == FW_VER_IF_TYPE_AP) &&
+              (fw_ver[FW_VER_MINOR] < FW_VER_MINOR_1_SPARE_AP_MIN))))
+                quirks |= WL12XX_QUIRK_USE_2_SPARE_BLOCKS;
+        return quirks;
+}
 int wl1271_plt_start(struct wl1271 *wl)
 {
        int retries = WL1271_BOOT_RETRIES;
@@ -1013,6 +1169,9 @@ int wl1271_plt_start(struct wl1271 *wl)
                wl->state = WL1271_STATE_PLT;
                wl1271_notice("firmware booted in PLT mode (%s)",
                              wl->chip.fw_ver_str);
+                /* Check if any quirks are needed with older fw versions */
+                wl->quirks |= wl1271_get_fw_ver_quirks(wl);
                goto out;
 irq_disable:
@@ -1040,7 +1199,7 @@ out:
        return ret;
 }
-int __wl1271_plt_stop(struct wl1271 *wl)
+static int __wl1271_plt_stop(struct wl1271 *wl)
 {
        int ret = 0;
@@ -1124,10 +1283,219 @@ static void wl1271_op_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
        spin_unlock_irqrestore(&wl->wl_lock, flags);
 }
+int wl1271_tx_dummy_packet(struct wl1271 *wl)
+{
+        unsigned long flags;
+        spin_lock_irqsave(&wl->wl_lock, flags);
+        set_bit(WL1271_FLAG_DUMMY_PACKET_PENDING, &wl->flags);
+        wl->tx_queue_count++;
+        spin_unlock_irqrestore(&wl->wl_lock, flags);
+        /* The FW is low on RX memory blocks, so send the dummy packet asap */
+        if (!test_bit(WL1271_FLAG_FW_TX_BUSY, &wl->flags))
+                wl1271_tx_work_locked(wl);
+        /*
+         * If the FW TX is busy, TX work will be scheduled by the threaded
+         * interrupt handler function
+         */
+        return 0;
+}
+/*
+ * The size of the dummy packet should be at least 1400 bytes. However, in
+ * order to minimize the number of bus transactions, aligning it to 512 bytes
+ * boundaries could be beneficial, performance wise
+ */
+#define TOTAL_TX_DUMMY_PACKET_SIZE (ALIGN(1400, 512))
+static struct sk_buff *wl12xx_alloc_dummy_packet(struct wl1271 *wl)
+{
+        struct sk_buff *skb;
+        struct ieee80211_hdr_3addr *hdr;
+        unsigned int dummy_packet_size;
+        dummy_packet_size = TOTAL_TX_DUMMY_PACKET_SIZE -
+                            sizeof(struct wl1271_tx_hw_descr) - sizeof(*hdr);
+        skb = dev_alloc_skb(TOTAL_TX_DUMMY_PACKET_SIZE);
+        if (!skb) {
+                wl1271_warning("Failed to allocate a dummy packet skb");
+                return NULL;
+        }
+        skb_reserve(skb, sizeof(struct wl1271_tx_hw_descr));
+        hdr = (struct ieee80211_hdr_3addr *) skb_put(skb, sizeof(*hdr));
+        memset(hdr, 0, sizeof(*hdr));
+        hdr->frame_control = cpu_to_le16(IEEE80211_FTYPE_DATA |
+                                         IEEE80211_STYPE_NULLFUNC |
+                                         IEEE80211_FCTL_TODS);
+        memset(skb_put(skb, dummy_packet_size), 0, dummy_packet_size);
+        /* Dummy packets require the TID to be management */
+        skb->priority = WL1271_TID_MGMT;
+        /* Initialize all fields that might be used */
+        skb_set_queue_mapping(skb, 0);
+        memset(IEEE80211_SKB_CB(skb), 0, sizeof(struct ieee80211_tx_info));
+        return skb;
+}
 static struct notifier_block wl1271_dev_notifier = {
        .notifier_call = wl1271_dev_notify,
 };
+#ifdef CONFIG_PM
+static int wl1271_configure_suspend(struct wl1271 *wl)
+{
+        int ret;
+        if (wl->bss_type != BSS_TYPE_STA_BSS)
+                return 0;
+        mutex_lock(&wl->mutex);
+        ret = wl1271_ps_elp_wakeup(wl);
+        if (ret < 0)
+                goto out_unlock;
+        /* enter psm if needed*/
+        if (!test_bit(WL1271_FLAG_PSM, &wl->flags)) {
+                DECLARE_COMPLETION_ONSTACK(compl);
+                wl->ps_compl = &compl;
+                ret = wl1271_ps_set_mode(wl, STATION_POWER_SAVE_MODE,
+                                   wl->basic_rate, true);
+                if (ret < 0)
+                        goto out_sleep;
+                /* we must unlock here so we will be able to get events */
+                wl1271_ps_elp_sleep(wl);
+                mutex_unlock(&wl->mutex);
+                ret = wait_for_completion_timeout(
+                        &compl, msecs_to_jiffies(WL1271_PS_COMPLETE_TIMEOUT));
+                if (ret <= 0) {
+                        wl1271_warning("couldn't enter ps mode!");
+                        ret = -EBUSY;
+                        goto out;
+                }
+                /* take mutex again, and wakeup */
+                mutex_lock(&wl->mutex);
+                ret = wl1271_ps_elp_wakeup(wl);
+                if (ret < 0)
+                        goto out_unlock;
+        }
+out_sleep:
+        wl1271_ps_elp_sleep(wl);
+out_unlock:
+        mutex_unlock(&wl->mutex);
+out:
+        return ret;
+}
+static void wl1271_configure_resume(struct wl1271 *wl)
+{
+        int ret;
+        if (wl->bss_type != BSS_TYPE_STA_BSS)
+                return;
+        mutex_lock(&wl->mutex);
+        ret = wl1271_ps_elp_wakeup(wl);
+        if (ret < 0)
+                goto out;
+        /* exit psm if it wasn't configured */
+        if (!test_bit(WL1271_FLAG_PSM_REQUESTED, &wl->flags))
+                wl1271_ps_set_mode(wl, STATION_ACTIVE_MODE,
+                                   wl->basic_rate, true);
+        wl1271_ps_elp_sleep(wl);
+out:
+        mutex_unlock(&wl->mutex);
+}
+static int wl1271_op_suspend(struct ieee80211_hw *hw,
+                            struct cfg80211_wowlan *wow)
+{
+        struct wl1271 *wl = hw->priv;
+        wl1271_debug(DEBUG_MAC80211, "mac80211 suspend wow=%d", !!wow);
+        wl->wow_enabled = !!wow;
+        if (wl->wow_enabled) {
+                int ret;
+                ret = wl1271_configure_suspend(wl);
+                if (ret < 0) {
+                        wl1271_warning("couldn't prepare device to suspend");
+                        return ret;
+                }
+                /* flush any remaining work */
+                wl1271_debug(DEBUG_MAC80211, "flushing remaining works");
+                flush_delayed_work(&wl->scan_complete_work);
+                /*
+                 * disable and re-enable interrupts in order to flush
+                 * the threaded_irq
+                 */
+                wl1271_disable_interrupts(wl);
+                /*
+                 * set suspended flag to avoid triggering a new threaded_irq
+                 * work. no need for spinlock as interrupts are disabled.
+                 */
+                set_bit(WL1271_FLAG_SUSPENDED, &wl->flags);
+                wl1271_enable_interrupts(wl);
+                flush_work(&wl->tx_work);
+                flush_delayed_work(&wl->pspoll_work);
+                flush_delayed_work(&wl->elp_work);
+        }
+        return 0;
+}
+static int wl1271_op_resume(struct ieee80211_hw *hw)
+{
+        struct wl1271 *wl = hw->priv;
+        wl1271_debug(DEBUG_MAC80211, "mac80211 resume wow=%d",
+                     wl->wow_enabled);
+        /*
+         * re-enable irq_work enqueuing, and call irq_work directly if
+         * there is a pending work.
+         */
+        if (wl->wow_enabled) {
+                struct wl1271 *wl = hw->priv;
+                unsigned long flags;
+                bool run_irq_work = false;
+                spin_lock_irqsave(&wl->wl_lock, flags);
+                clear_bit(WL1271_FLAG_SUSPENDED, &wl->flags);
+                if (test_and_clear_bit(WL1271_FLAG_PENDING_WORK, &wl->flags))
+                        run_irq_work = true;
+                spin_unlock_irqrestore(&wl->wl_lock, flags);
+                if (run_irq_work) {
+                        wl1271_debug(DEBUG_MAC80211,
+                                     "run postponed irq_work directly");
+                        wl1271_irq(0, wl);
+                        wl1271_enable_interrupts(wl);
+                }
+                wl1271_configure_resume(wl);
+        }
+        return 0;
+}
+#endif
 static int wl1271_op_start(struct ieee80211_hw *hw)
 {
        wl1271_debug(DEBUG_MAC80211, "mac80211 start");
@@ -1174,6 +1542,16 @@ static int wl1271_op_add_interface(struct ieee80211_hw *hw,
                goto out;
        }
+        /*
+         * in some very corner case HW recovery scenarios its possible to
+         * get here before __wl1271_op_remove_interface is complete, so
+         * opt out if that is the case.
+         */
+        if (test_bit(WL1271_FLAG_IF_INITIALIZED, &wl->flags)) {
+                ret = -EBUSY;
+                goto out;
+        }
        switch (vif->type) {
        case NL80211_IFTYPE_STATION:
                wl->bss_type = BSS_TYPE_STA_BSS;
@@ -1242,6 +1620,7 @@ power_off:
        wl->vif = vif;
        wl->state = WL1271_STATE_ON;
+        set_bit(WL1271_FLAG_IF_INITIALIZED, &wl->flags);
        wl1271_info("firmware booted (%s)", wl->chip.fw_ver_str);
        /* update hw/fw version info in wiphy struct */
@@ -1249,6 +1628,9 @@ power_off:
        strncpy(wiphy->fw_version, wl->chip.fw_ver_str,
                sizeof(wiphy->fw_version));
+        /* Check if any quirks are needed with older fw versions */
+        wl->quirks |= wl1271_get_fw_ver_quirks(wl);
        /*
         * Now we know if 11a is supported (info from the NVS), so disable
         * 11a channels if not supported
@@ -1262,23 +1644,30 @@ power_off:
 out:
        mutex_unlock(&wl->mutex);
+        mutex_lock(&wl_list_mutex);
        if (!ret)
                list_add(&wl->list, &wl_list);
+        mutex_unlock(&wl_list_mutex);
        return ret;
 }
-static void __wl1271_op_remove_interface(struct wl1271 *wl)
+static void __wl1271_op_remove_interface(struct wl1271 *wl,
+                                         bool reset_tx_queues)
 {
        int i;
        wl1271_debug(DEBUG_MAC80211, "mac80211 remove interface");
+        /* because of hardware recovery, we may get here twice */
+        if (wl->state != WL1271_STATE_ON)
+                return;
        wl1271_info("down");
+        mutex_lock(&wl_list_mutex);
        list_del(&wl->list);
+        mutex_unlock(&wl_list_mutex);
-        WARN_ON(wl->state != WL1271_STATE_ON);
        /* enable dyn ps just in case (if left on due to fw crash etc) */
        if (wl->bss_type == BSS_TYPE_STA_BSS)
@@ -1286,12 +1675,15 @@ static void __wl1271_op_remove_interface(struct wl1271 *wl)
        if (wl->scan.state != WL1271_SCAN_STATE_IDLE) {
                wl->scan.state = WL1271_SCAN_STATE_IDLE;
-                kfree(wl->scan.scanned_ch);
+                memset(wl->scan.scanned_ch, 0, sizeof(wl->scan.scanned_ch));
-                wl->scan.scanned_ch = NULL;
                wl->scan.req = NULL;
                ieee80211_scan_completed(wl->hw, true);
        }
+        /*
+         * this must be before the cancel_work calls below, so that the work
+         * functions don't perform further work.
+         */
        wl->state = WL1271_STATE_OFF;
        mutex_unlock(&wl->mutex);
@@ -1307,7 +1699,7 @@ static void __wl1271_op_remove_interface(struct wl1271 *wl)
        mutex_lock(&wl->mutex);
        /* let's notify MAC80211 about the remaining pending TX frames */
-        wl1271_tx_reset(wl);
+        wl1271_tx_reset(wl, reset_tx_queues);
        wl1271_power_off(wl);
        memset(wl->bssid, 0, ETH_ALEN);
@@ -1321,6 +1713,7 @@ static void __wl1271_op_remove_interface(struct wl1271 *wl)
        wl->psm_entry_retry = 0;
        wl->power_level = WL1271_DEFAULT_POWER_LEVEL;
        wl->tx_blocks_available = 0;
+        wl->tx_allocated_blocks = 0;
        wl->tx_results_count = 0;
        wl->tx_packets_count = 0;
        wl->tx_security_last_seq = 0;
@@ -1328,13 +1721,20 @@ static void __wl1271_op_remove_interface(struct wl1271 *wl)
        wl->time_offset = 0;
        wl->session_counter = 0;
        wl->rate_set = CONF_TX_RATE_MASK_BASIC;
-        wl->flags = 0;
        wl->vif = NULL;
        wl->filters = 0;
        wl1271_free_ap_keys(wl);
        memset(wl->ap_hlid_map, 0, sizeof(wl->ap_hlid_map));
        wl->ap_fw_ps_map = 0;
        wl->ap_ps_map = 0;
+        wl->sched_scanning = false;
+        /*
+         * this is performed after the cancel_work calls and the associated
+         * mutex_lock, so that wl1271_op_add_interface does not accidentally
+         * get executed before all these vars have been reset.
+         */
+        wl->flags = 0;
        for (i = 0; i < NUM_TX_QUEUES; i++)
                wl->tx_blocks_freed[i] = 0;
@@ -1361,14 +1761,14 @@ static void wl1271_op_remove_interface(struct ieee80211_hw *hw,
         */
        if (wl->vif) {
                WARN_ON(wl->vif != vif);
-                __wl1271_op_remove_interface(wl);
+                __wl1271_op_remove_interface(wl, true);
        }
        mutex_unlock(&wl->mutex);
        cancel_work_sync(&wl->recovery_work);
 }
-static void wl1271_configure_filters(struct wl1271 *wl, unsigned int filters)
+void wl1271_configure_filters(struct wl1271 *wl, unsigned int filters)
 {
        wl1271_set_default_filters(wl);
@@ -1431,10 +1831,10 @@ static int wl1271_join(struct wl1271 *wl, bool set_assoc)
         * One of the side effects of the JOIN command is that is clears
         * WPA/WPA2 keys from the chipset. Performing a JOIN while associated
         * to a WPA/WPA2 access point will therefore kill the data-path.
-         * Currently there is no supported scenario for JOIN during
+         * Currently the only valid scenario for JOIN during association
-         * association - if it becomes a supported scenario, the WPA/WPA2 keys
+         * is on roaming, in which case we will also be given new keys.
-         * must be handled somehow.
+         * Keep the below message for now, unless it starts bothering
-         *
+         * users who really like to roam a lot :)
         */
        if (test_bit(WL1271_FLAG_STA_ASSOCIATED, &wl->flags))
                wl1271_info("JOIN while associated.");
@@ -1490,7 +1890,7 @@ static int wl1271_unjoin(struct wl1271 *wl)
        clear_bit(WL1271_FLAG_JOINED, &wl->flags);
        memset(wl->bssid, 0, ETH_ALEN);
-        /* stop filterting packets based on bssid */
+        /* stop filtering packets based on bssid */
        wl1271_configure_filters(wl, FIF_OTHER_BSS);
 out:
@@ -1530,6 +1930,13 @@ static int wl1271_sta_handle_idle(struct wl1271 *wl, bool idle)
                wl->session_counter++;
                if (wl->session_counter >= SESSION_COUNTER_MAX)
                        wl->session_counter = 0;
+                /* The current firmware only supports sched_scan in idle */
+                if (wl->sched_scanning) {
+                        wl1271_scan_sched_scan_stop(wl);
+                        ieee80211_sched_scan_stopped(wl->hw);
+                }
                ret = wl1271_dummy_join(wl);
                if (ret < 0)
                        goto out;
@@ -1569,7 +1976,12 @@ static int wl1271_op_config(struct ieee80211_hw *hw, u32 changed)
        mutex_lock(&wl->mutex);
        if (unlikely(wl->state == WL1271_STATE_OFF)) {
-                ret = -EAGAIN;
+                /* we support configuring the channel and band while off */
+                if ((changed & IEEE80211_CONF_CHANGE_CHANNEL)) {
+                        wl->band = conf->channel->band;
+                        wl->channel = channel;
+                }
                goto out;
        }
@@ -2077,6 +2489,60 @@ out:
        return ret;
 }
+static int wl1271_op_sched_scan_start(struct ieee80211_hw *hw,
+                                      struct ieee80211_vif *vif,
+                                      struct cfg80211_sched_scan_request *req,
+                                      struct ieee80211_sched_scan_ies *ies)
+{
+        struct wl1271 *wl = hw->priv;
+        int ret;
+        wl1271_debug(DEBUG_MAC80211, "wl1271_op_sched_scan_start");
+        mutex_lock(&wl->mutex);
+        ret = wl1271_ps_elp_wakeup(wl);
+        if (ret < 0)
+                goto out;
+        ret = wl1271_scan_sched_scan_config(wl, req, ies);
+        if (ret < 0)
+                goto out_sleep;
+        ret = wl1271_scan_sched_scan_start(wl);
+        if (ret < 0)
+                goto out_sleep;
+        wl->sched_scanning = true;
+out_sleep:
+        wl1271_ps_elp_sleep(wl);
+out:
+        mutex_unlock(&wl->mutex);
+        return ret;
+}
+static void wl1271_op_sched_scan_stop(struct ieee80211_hw *hw,
+                                      struct ieee80211_vif *vif)
+{
+        struct wl1271 *wl = hw->priv;
+        int ret;
+        wl1271_debug(DEBUG_MAC80211, "wl1271_op_sched_scan_stop");
+        mutex_lock(&wl->mutex);
+        ret = wl1271_ps_elp_wakeup(wl);
+        if (ret < 0)
+                goto out;
+        wl1271_scan_sched_scan_stop(wl);
+        wl1271_ps_elp_sleep(wl);
+out:
+        mutex_unlock(&wl->mutex);
+}
 static int wl1271_op_set_frag_threshold(struct ieee80211_hw *hw, u32 value)
 {
        struct wl1271 *wl = hw->priv;
@@ -2093,7 +2559,7 @@ static int wl1271_op_set_frag_threshold(struct ieee80211_hw *hw, u32 value)
        if (ret < 0)
                goto out;
-        ret = wl1271_acx_frag_threshold(wl, (u16)value);
+        ret = wl1271_acx_frag_threshold(wl, value);
        if (ret < 0)
                wl1271_warning("wl1271_op_set_frag_threshold failed: %d", ret);
@@ -2121,7 +2587,7 @@ static int wl1271_op_set_rts_threshold(struct ieee80211_hw *hw, u32 value)
        if (ret < 0)
                goto out;
-        ret = wl1271_acx_rts_threshold(wl, (u16) value);
+        ret = wl1271_acx_rts_threshold(wl, value);
        if (ret < 0)
                wl1271_warning("wl1271_op_set_rts_threshold failed: %d", ret);
@@ -2136,20 +2602,24 @@ out:
 static int wl1271_ssid_set(struct wl1271 *wl, struct sk_buff *skb,
                            int offset)
 {
-        u8 *ptr = skb->data + offset;
+        u8 ssid_len;
+        const u8 *ptr = cfg80211_find_ie(WLAN_EID_SSID, skb->data + offset,
+                                         skb->len - offset);
-        /* find the location of the ssid in the beacon */
+        if (!ptr) {
-        while (ptr < skb->data + skb->len) {
+                wl1271_error("No SSID in IEs!");
-                if (ptr[0] == WLAN_EID_SSID) {
+                return -ENOENT;
-                        wl->ssid_len = ptr[1];
-                        memcpy(wl->ssid, ptr+2, wl->ssid_len);
-                        return 0;
-                }
-                ptr += (ptr[1] + 2);
        }
-        wl1271_error("No SSID in IEs!\n");
+        ssid_len = ptr[1];
-        return -ENOENT;
+        if (ssid_len > IEEE80211_MAX_SSID_LEN) {
+                wl1271_error("SSID is too long!");
+                return -EINVAL;
+        }
+        wl->ssid_len = ssid_len;
+        memcpy(wl->ssid, ptr+2, ssid_len);
+        return 0;
 }
 static int wl1271_bss_erp_info_changed(struct wl1271 *wl,
@@ -2264,24 +2734,19 @@ static void wl1271_bss_info_changed_ap(struct wl1271 *wl,
        if ((changed & BSS_CHANGED_BASIC_RATES)) {
                u32 rates = bss_conf->basic_rates;
-                struct conf_tx_rate_class mgmt_rc;
                wl->basic_rate_set = wl1271_tx_enabled_rates_get(wl, rates);
                wl->basic_rate = wl1271_tx_min_rate_get(wl);
-                wl1271_debug(DEBUG_AP, "basic rates: 0x%x",
-                             wl->basic_rate_set);
+                ret = wl1271_init_ap_rates(wl);
-                /* update the AP management rate policy with the new rates */
-                mgmt_rc.enabled_rates = wl->basic_rate_set;
-                mgmt_rc.long_retry_limit = 10;
-                mgmt_rc.short_retry_limit = 10;
-                mgmt_rc.aflags = 0;
-                ret = wl1271_acx_ap_rate_policy(wl, &mgmt_rc,
-                                                ACX_TX_AP_MODE_MGMT_RATE);
                if (ret < 0) {
-                        wl1271_error("AP mgmt policy change failed %d", ret);
+                        wl1271_error("AP rate policy change failed %d", ret);
                        goto out;
                }
+                ret = wl1271_ap_init_templates(wl);
+                if (ret < 0)
+                        goto out;
        }
        ret = wl1271_bss_beacon_info_changed(wl, vif, bss_conf, changed);
@@ -2314,6 +2779,24 @@ static void wl1271_bss_info_changed_ap(struct wl1271 *wl,
                }
        }
+        if (changed & BSS_CHANGED_IBSS) {
+                wl1271_debug(DEBUG_ADHOC, "ibss_joined: %d",
+                             bss_conf->ibss_joined);
+                if (bss_conf->ibss_joined) {
+                        u32 rates = bss_conf->basic_rates;
+                        wl->basic_rate_set = wl1271_tx_enabled_rates_get(wl,
+                                                                         rates);
+                        wl->basic_rate = wl1271_tx_min_rate_get(wl);
+                        /* by default, use 11b rates */
+                        wl->rate_set = CONF_TX_IBSS_DEFAULT_RATES;
+                        ret = wl1271_acx_sta_rate_policies(wl);
+                        if (ret < 0)
+                                goto out;
+                }
+        }
        ret = wl1271_bss_erp_info_changed(wl, bss_conf, changed);
        if (ret < 0)
                goto out;
@@ -2503,8 +2986,10 @@ static void wl1271_bss_info_changed_sta(struct wl1271 *wl,
                        }
                } else {
                        /* use defaults when not associated */
+                        bool was_assoc =
+                            !!test_and_clear_bit(WL1271_FLAG_STA_ASSOCIATED,
+                                                 &wl->flags);
                        clear_bit(WL1271_FLAG_STA_STATE_SENT, &wl->flags);
-                        clear_bit(WL1271_FLAG_STA_ASSOCIATED, &wl->flags);
                        wl->aid = 0;
                        /* free probe-request template */
@@ -2530,8 +3015,10 @@ static void wl1271_bss_info_changed_sta(struct wl1271 *wl,
                                goto out;
                        /* restore the bssid filter and go to dummy bssid */
-                        wl1271_unjoin(wl);
+                        if (was_assoc) {
-                        wl1271_dummy_join(wl);
+                                wl1271_unjoin(wl);
+                                wl1271_dummy_join(wl);
+                        }
                }
        }
@@ -2650,32 +3137,31 @@ static int wl1271_op_conf_tx(struct ieee80211_hw *hw, u16 queue,
                conf_tid->ack_policy = CONF_ACK_POLICY_LEGACY;
                conf_tid->apsd_conf[0] = 0;
                conf_tid->apsd_conf[1] = 0;
-        } else {
+                goto out;
-                ret = wl1271_ps_elp_wakeup(wl);
+        }
-                if (ret < 0)
-                        goto out;
-                /*
+        ret = wl1271_ps_elp_wakeup(wl);
-                 * the txop is confed in units of 32us by the mac80211,
+        if (ret < 0)
-                 * we need us
+                goto out;
-                 */
-                ret = wl1271_acx_ac_cfg(wl, wl1271_tx_get_queue(queue),
-                                        params->cw_min, params->cw_max,
-                                        params->aifs, params->txop << 5);
-                if (ret < 0)
-                        goto out_sleep;
-                ret = wl1271_acx_tid_cfg(wl, wl1271_tx_get_queue(queue),
+        /*
-                                         CONF_CHANNEL_TYPE_EDCF,
+         * the txop is confed in units of 32us by the mac80211,
-                                         wl1271_tx_get_queue(queue),
+         * we need us
-                                         ps_scheme, CONF_ACK_POLICY_LEGACY,
+         */
-                                         0, 0);
+        ret = wl1271_acx_ac_cfg(wl, wl1271_tx_get_queue(queue),
-                if (ret < 0)
+                                params->cw_min, params->cw_max,
-                        goto out_sleep;
+                                params->aifs, params->txop << 5);
+        if (ret < 0)
+                goto out_sleep;
+        ret = wl1271_acx_tid_cfg(wl, wl1271_tx_get_queue(queue),
+                                 CONF_CHANNEL_TYPE_EDCF,
+                                 wl1271_tx_get_queue(queue),
+                                 ps_scheme, CONF_ACK_POLICY_LEGACY,
+                                 0, 0);
 out_sleep:
-                wl1271_ps_elp_sleep(wl);
+        wl1271_ps_elp_sleep(wl);
-        }
 out:
        mutex_unlock(&wl->mutex);
@@ -2847,10 +3333,11 @@ out:
        return ret;
 }
-int wl1271_op_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
+static int wl1271_op_ampdu_action(struct ieee80211_hw *hw,
-                           enum ieee80211_ampdu_mlme_action action,
+                                  struct ieee80211_vif *vif,
-                           struct ieee80211_sta *sta, u16 tid, u16 *ssn,
+                                  enum ieee80211_ampdu_mlme_action action,
-                           u8 buf_size)
+                                  struct ieee80211_sta *sta, u16 tid, u16 *ssn,
+                                  u8 buf_size)
 {
        struct wl1271 *wl = hw->priv;
        int ret;
@@ -2907,6 +3394,28 @@ out:
        return ret;
 }
+static bool wl1271_tx_frames_pending(struct ieee80211_hw *hw)
+{
+        struct wl1271 *wl = hw->priv;
+        bool ret = false;
+        mutex_lock(&wl->mutex);
+        if (unlikely(wl->state == WL1271_STATE_OFF))
+                goto out;
+        /* packets are considered pending if in the TX queue or the FW */
+        ret = (wl->tx_queue_count > 0) || (wl->tx_frames_cnt > 0);
+        /* the above is appropriate for STA mode for PS purposes */
+        WARN_ON(wl->bss_type != BSS_TYPE_STA_BSS);
+out:
+        mutex_unlock(&wl->mutex);
+        return ret;
+}
 /* can't be const, mac80211 writes to this */
 static struct ieee80211_rate wl1271_rates[] = {
        { .bitrate = 10,
@@ -3003,7 +3512,8 @@ static const u8 wl1271_rate_to_idx_2ghz[] = {
 #ifdef CONFIG_WL12XX_HT
 #define WL12XX_HT_CAP { \
-        .cap = IEEE80211_HT_CAP_GRN_FLD | IEEE80211_HT_CAP_SGI_20, \
+        .cap = IEEE80211_HT_CAP_GRN_FLD | IEEE80211_HT_CAP_SGI_20 | \
+               (1 << IEEE80211_HT_CAP_RX_STBC_SHIFT), \
        .ht_supported = true, \
        .ampdu_factor = IEEE80211_HT_MAX_AMPDU_8K, \
        .ampdu_density = IEEE80211_HT_MPDU_DENSITY_8, \
@@ -3142,12 +3652,18 @@ static const struct ieee80211_ops wl1271_ops = {
        .stop = wl1271_op_stop,
        .add_interface = wl1271_op_add_interface,
        .remove_interface = wl1271_op_remove_interface,
+#ifdef CONFIG_PM
+        .suspend = wl1271_op_suspend,
+        .resume = wl1271_op_resume,
+#endif
        .config = wl1271_op_config,
        .prepare_multicast = wl1271_op_prepare_multicast,
        .configure_filter = wl1271_op_configure_filter,
        .tx = wl1271_op_tx,
        .set_key = wl1271_op_set_key,
        .hw_scan = wl1271_op_hw_scan,
+        .sched_scan_start = wl1271_op_sched_scan_start,
+        .sched_scan_stop = wl1271_op_sched_scan_stop,
        .bss_info_changed = wl1271_op_bss_info_changed,
        .set_frag_threshold = wl1271_op_set_frag_threshold,
        .set_rts_threshold = wl1271_op_set_rts_threshold,
@@ -3157,6 +3673,7 @@ static const struct ieee80211_ops wl1271_ops = {
        .sta_add = wl1271_op_sta_add,
        .sta_remove = wl1271_op_sta_remove,
        .ampdu_action = wl1271_op_ampdu_action,
+        .tx_frames_pending = wl1271_tx_frames_pending,
        CFG80211_TESTMODE_CMD(wl1271_tm_cmd)
 };
@@ -3207,8 +3724,7 @@ static ssize_t wl1271_sysfs_store_bt_coex_state(struct device *dev,
        unsigned long res;
        int ret;
-        ret = strict_strtoul(buf, 10, &res);
+        ret = kstrtoul(buf, 10, &res);
        if (ret < 0) {
                wl1271_warning("incorrect value written to bt_coex_mode");
                return count;
@@ -3273,7 +3789,11 @@ int wl1271_register_hw(struct wl1271 *wl)
        ret = wl1271_fetch_nvs(wl);
        if (ret == 0) {
-                u8 *nvs_ptr = (u8 *)wl->nvs->nvs;
+                /* NOTE: The wl->nvs->nvs element must be first, in
+                 * order to simplify the casting, we assume it is at
+                 * the beginning of the wl->nvs structure.
+                 */
+                u8 *nvs_ptr = (u8 *)wl->nvs;
                wl->mac_addr[0] = nvs_ptr[11];
                wl->mac_addr[1] = nvs_ptr[10];
@@ -3342,6 +3862,7 @@ int wl1271_init_ieee80211(struct wl1271 *wl)
                IEEE80211_HW_CONNECTION_MONITOR |
                IEEE80211_HW_SUPPORTS_CQM_RSSI |
                IEEE80211_HW_REPORTS_TX_ACK_STATUS |
+                IEEE80211_HW_SPECTRUM_MGMT |
                IEEE80211_HW_AP_LINK_PS;
        wl->hw->wiphy->cipher_suites = cipher_suites;
@@ -3358,6 +3879,10 @@ int wl1271_init_ieee80211(struct wl1271 *wl)
        wl->hw->wiphy->max_scan_ie_len = WL1271_CMD_TEMPL_MAX_SIZE -
                        sizeof(struct ieee80211_header);
+        /* make sure all our channels fit in the scanned_ch bitmask */
+        BUILD_BUG_ON(ARRAY_SIZE(wl1271_channels) +
+                     ARRAY_SIZE(wl1271_channels_5ghz) >
+                     WL1271_MAX_CHANNELS);
        /*
         * We keep local copies of the band structs because we need to
         * modify them on a per-device basis.
@@ -3458,6 +3983,8 @@ struct ieee80211_hw *wl1271_alloc_hw(void)
        wl->ap_ps_map = 0;
        wl->ap_fw_ps_map = 0;
        wl->quirks = 0;
+        wl->platform_quirks = 0;
+        wl->sched_scanning = false;
        memset(wl->tx_frames_map, 0, sizeof(wl->tx_frames_map));
        for (i = 0; i < ACX_TX_DESCRIPTORS; i++)
@@ -3478,11 +4005,17 @@ struct ieee80211_hw *wl1271_alloc_hw(void)
                goto err_hw;
        }
+        wl->dummy_packet = wl12xx_alloc_dummy_packet(wl);
+        if (!wl->dummy_packet) {
+                ret = -ENOMEM;
+                goto err_aggr;
+        }
        /* Register platform device */
        ret = platform_device_register(wl->plat_dev);
        if (ret) {
                wl1271_error("couldn't register platform device");
-                goto err_aggr;
+                goto err_dummy_packet;
        }
        dev_set_drvdata(&wl->plat_dev->dev, wl);
@@ -3508,6 +4041,9 @@ err_bt_coex_state:
 err_platform:
        platform_device_unregister(wl->plat_dev);
+err_dummy_packet:
+        dev_kfree_skb(wl->dummy_packet);
 err_aggr:
        free_pages((unsigned long)wl->aggr_buf, order);
@@ -3527,6 +4063,7 @@ EXPORT_SYMBOL_GPL(wl1271_alloc_hw);
 int wl1271_free_hw(struct wl1271 *wl)
 {
        platform_device_unregister(wl->plat_dev);
+        dev_kfree_skb(wl->dummy_packet);
        free_pages((unsigned long)wl->aggr_buf,
                        get_order(WL1271_AGGR_BUFFER_SIZE));
        kfree(wl->plat_dev);
diff --git a/drivers/net/wireless/wl12xx/ps.c b/drivers/net/wireless/wl12xx/ps.c
index 971f13e792da..b59b67711a17 100644
--- a/drivers/net/wireless/wl12xx/ps.c
+++ b/drivers/net/wireless/wl12xx/ps.c
@@ -43,6 +43,10 @@ void wl1271_elp_work(struct work_struct *work)
        if (unlikely(wl->state == WL1271_STATE_OFF))
                goto out;
+        /* our work might have been already cancelled */
+        if (unlikely(!test_bit(WL1271_FLAG_ELP_REQUESTED, &wl->flags)))
+                goto out;
        if (test_bit(WL1271_FLAG_IN_ELP, &wl->flags) ||
            (!test_bit(WL1271_FLAG_PSM, &wl->flags) &&
             !test_bit(WL1271_FLAG_IDLE, &wl->flags)))
@@ -61,12 +65,16 @@ out:
 /* Routines to toggle sleep mode while in ELP */
 void wl1271_ps_elp_sleep(struct wl1271 *wl)
 {
-        if (test_bit(WL1271_FLAG_PSM, &wl->flags) ||
+        /* we shouldn't get consecutive sleep requests */
-            test_bit(WL1271_FLAG_IDLE, &wl->flags)) {
+        if (WARN_ON(test_and_set_bit(WL1271_FLAG_ELP_REQUESTED, &wl->flags)))
-                cancel_delayed_work(&wl->elp_work);
+                return;
-                ieee80211_queue_delayed_work(wl->hw, &wl->elp_work,
-                                             msecs_to_jiffies(ELP_ENTRY_DELAY));
+        if (!test_bit(WL1271_FLAG_PSM, &wl->flags) &&
-        }
+            !test_bit(WL1271_FLAG_IDLE, &wl->flags))
+                return;
+        ieee80211_queue_delayed_work(wl->hw, &wl->elp_work,
+                                     msecs_to_jiffies(ELP_ENTRY_DELAY));
 }
 int wl1271_ps_elp_wakeup(struct wl1271 *wl)
@@ -77,6 +85,16 @@ int wl1271_ps_elp_wakeup(struct wl1271 *wl)
        u32 start_time = jiffies;
        bool pending = false;
+        /*
+         * we might try to wake up even if we didn't go to sleep
+         * before (e.g. on boot)
+         */
+        if (!test_and_clear_bit(WL1271_FLAG_ELP_REQUESTED, &wl->flags))
+                return 0;
+        /* don't cancel_sync as it might contend for a mutex and deadlock */
+        cancel_delayed_work(&wl->elp_work);
        if (!test_bit(WL1271_FLAG_IN_ELP, &wl->flags))
                return 0;
@@ -149,9 +167,6 @@ int wl1271_ps_set_mode(struct wl1271 *wl, enum wl1271_cmd_ps_mode mode,
        case STATION_ACTIVE_MODE:
        default:
                wl1271_debug(DEBUG_PSM, "leaving psm");
-                ret = wl1271_ps_elp_wakeup(wl);
-                if (ret < 0)
-                        return ret;
                /* disable beacon early termination */
                ret = wl1271_acx_bet_enable(wl, false);
diff --git a/drivers/net/wireless/wl12xx/ps.h b/drivers/net/wireless/wl12xx/ps.h
index c41bd0a711bc..25eb9bc9b628 100644
--- a/drivers/net/wireless/wl12xx/ps.h
+++ b/drivers/net/wireless/wl12xx/ps.h
@@ -35,4 +35,6 @@ void wl1271_elp_work(struct work_struct *work);
 void wl1271_ps_link_start(struct wl1271 *wl, u8 hlid, bool clean_queues);
 void wl1271_ps_link_end(struct wl1271 *wl, u8 hlid);
+#define WL1271_PS_COMPLETE_TIMEOUT 500
 #endif /* __WL1271_PS_H__ */
diff --git a/drivers/net/wireless/wl12xx/reg.h b/drivers/net/wireless/wl12xx/reg.h
index 990960771528..440a4ee9cb42 100644
--- a/drivers/net/wireless/wl12xx/reg.h
+++ b/drivers/net/wireless/wl12xx/reg.h
@@ -207,6 +207,8 @@
 #define CHIP_ID_1271_PG10              (0x4030101)
 #define CHIP_ID_1271_PG20              (0x4030111)
+#define CHIP_ID_1283_PG10              (0x05030101)
+#define CHIP_ID_1283_PG20              (0x05030111)
 #define ENABLE                         (REGISTERS_BASE + 0x5450)
@@ -452,24 +454,11 @@
 #define HI_CFG_UART_TX_OUT_GPIO_14  0x00000200
 #define HI_CFG_UART_TX_OUT_GPIO_7   0x00000400
-/*
- * NOTE: USE_ACTIVE_HIGH compilation flag should be defined in makefile
- *       for platforms using active high interrupt level
- */
-#ifdef USE_ACTIVE_HIGH
 #define HI_CFG_DEF_VAL              \
        (HI_CFG_UART_ENABLE |        \
        HI_CFG_RST232_ENABLE |      \
        HI_CFG_CLOCK_REQ_SELECT |   \
        HI_CFG_HOST_INT_ENABLE)
-#else
-#define HI_CFG_DEF_VAL              \
-        (HI_CFG_UART_ENABLE |        \
-        HI_CFG_RST232_ENABLE |      \
-        HI_CFG_CLOCK_REQ_SELECT |   \
-        HI_CFG_HOST_INT_ENABLE)
-#endif
 #define REF_FREQ_19_2                       0
 #define REF_FREQ_26_0                       1
diff --git a/drivers/net/wireless/wl12xx/rx.c b/drivers/net/wireless/wl12xx/rx.c
index 919b59f00301..70091035e019 100644
--- a/drivers/net/wireless/wl12xx/rx.c
+++ b/drivers/net/wireless/wl12xx/rx.c
@@ -48,18 +48,14 @@ static void wl1271_rx_status(struct wl1271 *wl,
                             struct ieee80211_rx_status *status,
                             u8 beacon)
 {
-        enum ieee80211_band desc_band;
        memset(status, 0, sizeof(struct ieee80211_rx_status));
-        status->band = wl->band;
        if ((desc->flags & WL1271_RX_DESC_BAND_MASK) == WL1271_RX_DESC_BAND_BG)
-                desc_band = IEEE80211_BAND_2GHZ;
+                status->band = IEEE80211_BAND_2GHZ;
        else
-                desc_band = IEEE80211_BAND_5GHZ;
+                status->band = IEEE80211_BAND_5GHZ;
-        status->rate_idx = wl1271_rate_to_idx(desc->rate, desc_band);
+        status->rate_idx = wl1271_rate_to_idx(desc->rate, status->band);
 #ifdef CONFIG_WL12XX_HT
        /* 11n support */
@@ -76,15 +72,19 @@ static void wl1271_rx_status(struct wl1271 *wl,
         */
        wl->noise = desc->rssi - (desc->snr >> 1);
-        status->freq = ieee80211_channel_to_frequency(desc->channel, desc_band);
+        status->freq = ieee80211_channel_to_frequency(desc->channel,
+                                                      status->band);
        if (desc->flags & WL1271_RX_DESC_ENCRYPT_MASK) {
-                status->flag |= RX_FLAG_IV_STRIPPED | RX_FLAG_MMIC_STRIPPED;
+                u8 desc_err_code = desc->status & WL1271_RX_DESC_STATUS_MASK;
+                status->flag |= RX_FLAG_IV_STRIPPED | RX_FLAG_MMIC_STRIPPED |
+                                RX_FLAG_DECRYPTED;
-                if (likely(!(desc->status & WL1271_RX_DESC_DECRYPT_FAIL)))
+                if (unlikely(desc_err_code == WL1271_RX_DESC_MIC_FAIL)) {
-                        status->flag |= RX_FLAG_DECRYPTED;
-                if (unlikely(desc->status & WL1271_RX_DESC_MIC_FAIL))
                        status->flag |= RX_FLAG_MMIC_ERROR;
+                        wl1271_warning("Michael MIC error");
+                }
        }
 }
@@ -103,6 +103,25 @@ static int wl1271_rx_handle_data(struct wl1271 *wl, u8 *data, u32 length)
        if (unlikely(wl->state == WL1271_STATE_PLT))
                return -EINVAL;
+        /* the data read starts with the descriptor */
+        desc = (struct wl1271_rx_descriptor *) data;
+        switch (desc->status & WL1271_RX_DESC_STATUS_MASK) {
+        /* discard corrupted packets */
+        case WL1271_RX_DESC_DRIVER_RX_Q_FAIL:
+        case WL1271_RX_DESC_DECRYPT_FAIL:
+                wl1271_warning("corrupted packet in RX with status: 0x%x",
+                               desc->status & WL1271_RX_DESC_STATUS_MASK);
+                return -EINVAL;
+        case WL1271_RX_DESC_SUCCESS:
+        case WL1271_RX_DESC_MIC_FAIL:
+                break;
+        default:
+                wl1271_error("invalid RX descriptor status: 0x%x",
+                             desc->status & WL1271_RX_DESC_STATUS_MASK);
+                return -EINVAL;
+        }
        skb = __dev_alloc_skb(length, GFP_KERNEL);
        if (!skb) {
                wl1271_error("Couldn't allocate RX frame");
@@ -112,9 +131,6 @@ static int wl1271_rx_handle_data(struct wl1271 *wl, u8 *data, u32 length)
        buf = skb_put(skb, length);
        memcpy(buf, data, length);
-        /* the data read starts with the descriptor */
-        desc = (struct wl1271_rx_descriptor *) buf;
        /* now we pull the descriptor out of the buffer */
        skb_pull(skb, sizeof(*desc));
@@ -124,7 +140,8 @@ static int wl1271_rx_handle_data(struct wl1271 *wl, u8 *data, u32 length)
        wl1271_rx_status(wl, desc, IEEE80211_SKB_RXCB(skb), beacon);
-        wl1271_debug(DEBUG_RX, "rx skb 0x%p: %d B %s", skb, skb->len,
+        wl1271_debug(DEBUG_RX, "rx skb 0x%p: %d B %s", skb,
+                     skb->len - desc->pad_len,
                     beacon ? "beacon" : "");
        skb_trim(skb, skb->len - desc->pad_len);
@@ -163,18 +180,25 @@ void wl1271_rx(struct wl1271 *wl, struct wl1271_fw_common_status *status)
                        break;
                }
-                /*
+                if (wl->chip.id != CHIP_ID_1283_PG20) {
-                 * Choose the block we want to read
+                        /*
-                 * For aggregated packets, only the first memory block should
+                         * Choose the block we want to read
-                 * be retrieved. The FW takes care of the rest.
+                         * For aggregated packets, only the first memory block
-                 */
+                         * should be retrieved. The FW takes care of the rest.
-                mem_block = wl1271_rx_get_mem_block(status, drv_rx_counter);
+                         */
-                wl->rx_mem_pool_addr.addr = (mem_block << 8) +
+                        mem_block = wl1271_rx_get_mem_block(status,
-                        le32_to_cpu(wl_mem_map->packet_memory_pool_start);
+                                                            drv_rx_counter);
-                wl->rx_mem_pool_addr.addr_extra =
-                        wl->rx_mem_pool_addr.addr + 4;
+                        wl->rx_mem_pool_addr.addr = (mem_block << 8) +
-                wl1271_write(wl, WL1271_SLV_REG_DATA, &wl->rx_mem_pool_addr,
+                           le32_to_cpu(wl_mem_map->packet_memory_pool_start);
-                                sizeof(wl->rx_mem_pool_addr), false);
+                        wl->rx_mem_pool_addr.addr_extra =
+                                wl->rx_mem_pool_addr.addr + 4;
+                        wl1271_write(wl, WL1271_SLV_REG_DATA,
+                                     &wl->rx_mem_pool_addr,
+                                     sizeof(wl->rx_mem_pool_addr), false);
+                }
                /* Read all available packets at once */
                wl1271_read(wl, WL1271_SLV_MEM_DATA, wl->aggr_buf,
diff --git a/drivers/net/wireless/wl12xx/scan.c b/drivers/net/wireless/wl12xx/scan.c
index 420653a2859c..f37e5a391976 100644
--- a/drivers/net/wireless/wl12xx/scan.c
+++ b/drivers/net/wireless/wl12xx/scan.c
@@ -48,8 +48,7 @@ void wl1271_scan_complete_work(struct work_struct *work)
                goto out;
        wl->scan.state = WL1271_SCAN_STATE_IDLE;
-        kfree(wl->scan.scanned_ch);
+        memset(wl->scan.scanned_ch, 0, sizeof(wl->scan.scanned_ch));
-        wl->scan.scanned_ch = NULL;
        wl->scan.req = NULL;
        ieee80211_scan_completed(wl->hw, false);
@@ -87,7 +86,7 @@ static int wl1271_get_scan_channels(struct wl1271 *wl,
                flags = req->channels[i]->flags;
-                if (!wl->scan.scanned_ch[i] &&
+                if (!test_bit(i, wl->scan.scanned_ch) &&
                    !(flags & IEEE80211_CHAN_DISABLED) &&
                    ((!!(flags & IEEE80211_CHAN_PASSIVE_SCAN)) == passive) &&
                    (req->channels[i]->band == band)) {
@@ -124,7 +123,7 @@ static int wl1271_get_scan_channels(struct wl1271 *wl,
                        memset(&channels[j].bssid_msb, 0xff, 2);
                        /* Mark the channels we already used */
-                        wl->scan.scanned_ch[i] = true;
+                        set_bit(i, wl->scan.scanned_ch);
                        j++;
                }
@@ -291,6 +290,12 @@ void wl1271_scan_stm(struct wl1271 *wl)
 int wl1271_scan(struct wl1271 *wl, const u8 *ssid, size_t ssid_len,
                struct cfg80211_scan_request *req)
 {
+        /*
+         * cfg80211 should guarantee that we don't get more channels
+         * than what we have registered.
+         */
+        BUG_ON(req->n_channels > WL1271_MAX_CHANNELS);
        if (wl->scan.state != WL1271_SCAN_STATE_IDLE)
                return -EBUSY;
@@ -304,10 +309,8 @@ int wl1271_scan(struct wl1271 *wl, const u8 *ssid, size_t ssid_len,
        }
        wl->scan.req = req;
+        memset(wl->scan.scanned_ch, 0, sizeof(wl->scan.scanned_ch));
-        wl->scan.scanned_ch = kcalloc(req->n_channels,
-                                      sizeof(*wl->scan.scanned_ch),
-                                      GFP_KERNEL);
        /* we assume failure so that timeout scenarios are handled correctly */
        wl->scan.failed = true;
        ieee80211_queue_delayed_work(wl->hw, &wl->scan_complete_work,
@@ -317,3 +320,246 @@ int wl1271_scan(struct wl1271 *wl, const u8 *ssid, size_t ssid_len,
        return 0;
 }
+static int
+wl1271_scan_get_sched_scan_channels(struct wl1271 *wl,
+                                    struct cfg80211_sched_scan_request *req,
+                                    struct conn_scan_ch_params *channels,
+                                    u32 band, bool radar, bool passive,
+                                    int start)
+{
+        struct conf_sched_scan_settings *c = &wl->conf.sched_scan;
+        int i, j;
+        u32 flags;
+        for (i = 0, j = start;
+             i < req->n_channels && j < MAX_CHANNELS_ALL_BANDS;
+             i++) {
+                flags = req->channels[i]->flags;
+                if (!(flags & IEEE80211_CHAN_DISABLED) &&
+                    ((flags & IEEE80211_CHAN_PASSIVE_SCAN) == passive) &&
+                    ((flags & IEEE80211_CHAN_RADAR) == radar) &&
+                    (req->channels[i]->band == band)) {
+                        wl1271_debug(DEBUG_SCAN, "band %d, center_freq %d ",
+                                     req->channels[i]->band,
+                                     req->channels[i]->center_freq);
+                        wl1271_debug(DEBUG_SCAN, "hw_value %d, flags %X",
+                                     req->channels[i]->hw_value,
+                                     req->channels[i]->flags);
+                        wl1271_debug(DEBUG_SCAN, "max_power %d",
+                                     req->channels[i]->max_power);
+                        if (flags & IEEE80211_CHAN_PASSIVE_SCAN) {
+                                channels[j].passive_duration =
+                                        cpu_to_le16(c->dwell_time_passive);
+                        } else {
+                                channels[j].min_duration =
+                                        cpu_to_le16(c->min_dwell_time_active);
+                                channels[j].max_duration =
+                                        cpu_to_le16(c->max_dwell_time_active);
+                        }
+                        channels[j].tx_power_att = req->channels[j]->max_power;
+                        channels[j].channel = req->channels[i]->hw_value;
+                        j++;
+                }
+        }
+        return j - start;
+}
+static int
+wl1271_scan_sched_scan_channels(struct wl1271 *wl,
+                                struct cfg80211_sched_scan_request *req,
+                                struct wl1271_cmd_sched_scan_config *cfg)
+{
+        int idx = 0;
+        cfg->passive[0] =
+                wl1271_scan_get_sched_scan_channels(wl, req, cfg->channels,
+                                                    IEEE80211_BAND_2GHZ,
+                                                    false, true, idx);
+        idx += cfg->passive[0];
+        cfg->active[0] =
+                wl1271_scan_get_sched_scan_channels(wl, req, cfg->channels,
+                                                    IEEE80211_BAND_2GHZ,
+                                                    false, false, idx);
+        idx += cfg->active[0];
+        cfg->passive[1] =
+                wl1271_scan_get_sched_scan_channels(wl, req, cfg->channels,
+                                                    IEEE80211_BAND_5GHZ,
+                                                    false, true, idx);
+        idx += cfg->passive[1];
+        cfg->active[1] =
+                wl1271_scan_get_sched_scan_channels(wl, req, cfg->channels,
+                                                    IEEE80211_BAND_5GHZ,
+                                                    false, false, 14);
+        idx += cfg->active[1];
+        cfg->dfs =
+                wl1271_scan_get_sched_scan_channels(wl, req, cfg->channels,
+                                                    IEEE80211_BAND_5GHZ,
+                                                    true, false, idx);
+        idx += cfg->dfs;
+        wl1271_debug(DEBUG_SCAN, "    2.4GHz: active %d passive %d",
+                     cfg->active[0], cfg->passive[0]);
+        wl1271_debug(DEBUG_SCAN, "    5GHz: active %d passive %d",
+                     cfg->active[1], cfg->passive[1]);
+        return idx;
+}
+int wl1271_scan_sched_scan_config(struct wl1271 *wl,
+                                  struct cfg80211_sched_scan_request *req,
+                                  struct ieee80211_sched_scan_ies *ies)
+{
+        struct wl1271_cmd_sched_scan_config *cfg = NULL;
+        struct conf_sched_scan_settings *c = &wl->conf.sched_scan;
+        int i, total_channels, ret;
+        wl1271_debug(DEBUG_CMD, "cmd sched_scan scan config");
+        cfg = kzalloc(sizeof(*cfg), GFP_KERNEL);
+        if (!cfg)
+                return -ENOMEM;
+        cfg->rssi_threshold = c->rssi_threshold;
+        cfg->snr_threshold  = c->snr_threshold;
+        cfg->n_probe_reqs = c->num_probe_reqs;
+        /* cycles set to 0 it means infinite (until manually stopped) */
+        cfg->cycles = 0;
+        /* report APs when at least 1 is found */
+        cfg->report_after = 1;
+        /* don't stop scanning automatically when something is found */
+        cfg->terminate = 0;
+        cfg->tag = WL1271_SCAN_DEFAULT_TAG;
+        /* don't filter on BSS type */
+        cfg->bss_type = SCAN_BSS_TYPE_ANY;
+        /* currently NL80211 supports only a single interval */
+        for (i = 0; i < SCAN_MAX_CYCLE_INTERVALS; i++)
+                cfg->intervals[i] = cpu_to_le32(req->interval);
+        if (req->ssids[0].ssid_len && req->ssids[0].ssid) {
+                cfg->filter_type = SCAN_SSID_FILTER_SPECIFIC;
+                cfg->ssid_len = req->ssids[0].ssid_len;
+                memcpy(cfg->ssid, req->ssids[0].ssid,
+                       req->ssids[0].ssid_len);
+        } else {
+                cfg->filter_type = SCAN_SSID_FILTER_ANY;
+                cfg->ssid_len = 0;
+        }
+        total_channels = wl1271_scan_sched_scan_channels(wl, req, cfg);
+        if (total_channels == 0) {
+                wl1271_error("scan channel list is empty");
+                ret = -EINVAL;
+                goto out;
+        }
+        if (cfg->active[0]) {
+                ret = wl1271_cmd_build_probe_req(wl, req->ssids[0].ssid,
+                                                 req->ssids[0].ssid_len,
+                                                 ies->ie[IEEE80211_BAND_2GHZ],
+                                                 ies->len[IEEE80211_BAND_2GHZ],
+                                                 IEEE80211_BAND_2GHZ);
+                if (ret < 0) {
+                        wl1271_error("2.4GHz PROBE request template failed");
+                        goto out;
+                }
+        }
+        if (cfg->active[1]) {
+                ret = wl1271_cmd_build_probe_req(wl,  req->ssids[0].ssid,
+                                                 req->ssids[0].ssid_len,
+                                                 ies->ie[IEEE80211_BAND_5GHZ],
+                                                 ies->len[IEEE80211_BAND_5GHZ],
+                                                 IEEE80211_BAND_5GHZ);
+                if (ret < 0) {
+                        wl1271_error("5GHz PROBE request template failed");
+                        goto out;
+                }
+        }
+        wl1271_dump(DEBUG_SCAN, "SCAN_CFG: ", cfg, sizeof(*cfg));
+        ret = wl1271_cmd_send(wl, CMD_CONNECTION_SCAN_CFG, cfg,
+                              sizeof(*cfg), 0);
+        if (ret < 0) {
+                wl1271_error("SCAN configuration failed");
+                goto out;
+        }
+out:
+        kfree(cfg);
+        return ret;
+}
+int wl1271_scan_sched_scan_start(struct wl1271 *wl)
+{
+        struct wl1271_cmd_sched_scan_start *start;
+        int ret = 0;
+        wl1271_debug(DEBUG_CMD, "cmd periodic scan start");
+        if (wl->bss_type != BSS_TYPE_STA_BSS)
+                return -EOPNOTSUPP;
+        if (!test_bit(WL1271_FLAG_IDLE, &wl->flags))
+                return -EBUSY;
+        start = kzalloc(sizeof(*start), GFP_KERNEL);
+        if (!start)
+                return -ENOMEM;
+        start->tag = WL1271_SCAN_DEFAULT_TAG;
+        ret = wl1271_cmd_send(wl, CMD_START_PERIODIC_SCAN, start,
+                              sizeof(*start), 0);
+        if (ret < 0) {
+                wl1271_error("failed to send scan start command");
+                goto out_free;
+        }
+out_free:
+        kfree(start);
+        return ret;
+}
+void wl1271_scan_sched_scan_results(struct wl1271 *wl)
+{
+        wl1271_debug(DEBUG_SCAN, "got periodic scan results");
+        ieee80211_sched_scan_results(wl->hw);
+}
+void wl1271_scan_sched_scan_stop(struct wl1271 *wl)
+{
+        struct wl1271_cmd_sched_scan_stop *stop;
+        int ret = 0;
+        wl1271_debug(DEBUG_CMD, "cmd periodic scan stop");
+        /* FIXME: what to do if alloc'ing to stop fails? */
+        stop = kzalloc(sizeof(*stop), GFP_KERNEL);
+        if (!stop) {
+                wl1271_error("failed to alloc memory to send sched scan stop");
+                return;
+        }
+        stop->tag = WL1271_SCAN_DEFAULT_TAG;
+        ret = wl1271_cmd_send(wl, CMD_STOP_PERIODIC_SCAN, stop,
+                              sizeof(*stop), 0);
+        if (ret < 0) {
+                wl1271_error("failed to send sched scan stop command");
+                goto out_free;
+        }
+        wl->sched_scanning = false;
+out_free:
+        kfree(stop);
+}
diff --git a/drivers/net/wireless/wl12xx/scan.h b/drivers/net/wireless/wl12xx/scan.h
index 421a750add5a..c83319579ca3 100644
--- a/drivers/net/wireless/wl12xx/scan.h
+++ b/drivers/net/wireless/wl12xx/scan.h
@@ -33,6 +33,12 @@ int wl1271_scan_build_probe_req(struct wl1271 *wl,
                                const u8 *ie, size_t ie_len, u8 band);
 void wl1271_scan_stm(struct wl1271 *wl);
 void wl1271_scan_complete_work(struct work_struct *work);
+int wl1271_scan_sched_scan_config(struct wl1271 *wl,
+                                     struct cfg80211_sched_scan_request *req,
+                                     struct ieee80211_sched_scan_ies *ies);
+int wl1271_scan_sched_scan_start(struct wl1271 *wl);
+void wl1271_scan_sched_scan_stop(struct wl1271 *wl);
+void wl1271_scan_sched_scan_results(struct wl1271 *wl);
 #define WL1271_SCAN_MAX_CHANNELS       24
 #define WL1271_SCAN_DEFAULT_TAG        1
@@ -106,4 +112,112 @@ struct wl1271_cmd_trigger_scan_to {
        __le32 timeout;
 } __packed;
+#define MAX_CHANNELS_ALL_BANDS 41
+#define SCAN_MAX_CYCLE_INTERVALS 16
+#define SCAN_MAX_BANDS 3
+enum {
+        SCAN_CHANNEL_TYPE_2GHZ_PASSIVE,
+        SCAN_CHANNEL_TYPE_2GHZ_ACTIVE,
+        SCAN_CHANNEL_TYPE_5GHZ_PASSIVE,
+        SCAN_CHANNEL_TYPE_5GHZ_ACTIVE,
+        SCAN_CHANNEL_TYPE_5GHZ_DFS,
+};
+enum {
+        SCAN_SSID_FILTER_ANY      = 0,
+        SCAN_SSID_FILTER_SPECIFIC = 1,
+        SCAN_SSID_FILTER_LIST     = 2,
+        SCAN_SSID_FILTER_DISABLED = 3
+};
+enum {
+        SCAN_BSS_TYPE_INDEPENDENT,
+        SCAN_BSS_TYPE_INFRASTRUCTURE,
+        SCAN_BSS_TYPE_ANY,
+};
+struct conn_scan_ch_params {
+        __le16 min_duration;
+        __le16 max_duration;
+        __le16 passive_duration;
+        u8  channel;
+        u8  tx_power_att;
+        /* bit 0: DFS channel; bit 1: DFS enabled */
+        u8  flags;
+        u8  padding[3];
+} __packed;
+struct wl1271_cmd_sched_scan_config {
+        struct wl1271_cmd_header header;
+        __le32 intervals[SCAN_MAX_CYCLE_INTERVALS];
+        s8 rssi_threshold; /* for filtering (in dBm) */
+        s8 snr_threshold;  /* for filtering (in dB) */
+        u8 cycles;       /* maximum number of scan cycles */
+        u8 report_after; /* report when this number of results are received */
+        u8 terminate;    /* stop scanning after reporting */
+        u8 tag;
+        u8 bss_type; /* for filtering */
+        u8 filter_type;
+        u8 ssid_len;     /* For SCAN_SSID_FILTER_SPECIFIC */
+        u8 ssid[IW_ESSID_MAX_SIZE];
+        u8 n_probe_reqs; /* Number of probes requests per channel */
+        u8 passive[SCAN_MAX_BANDS];
+        u8 active[SCAN_MAX_BANDS];
+        u8 dfs;
+        u8 padding[3];
+        struct conn_scan_ch_params channels[MAX_CHANNELS_ALL_BANDS];
+} __packed;
+#define SCHED_SCAN_MAX_SSIDS 8
+enum {
+        SCAN_SSID_TYPE_PUBLIC = 0,
+        SCAN_SSID_TYPE_HIDDEN = 1,
+};
+struct wl1271_ssid {
+        u8 type;
+        u8 len;
+        u8 ssid[IW_ESSID_MAX_SIZE];
+        /* u8 padding[2]; */
+} __packed;
+struct wl1271_cmd_sched_scan_ssid_list {
+        struct wl1271_cmd_header header;
+        u8 n_ssids;
+        struct wl1271_ssid ssids[SCHED_SCAN_MAX_SSIDS];
+        u8 padding[3];
+} __packed;
+struct wl1271_cmd_sched_scan_start {
+        struct wl1271_cmd_header header;
+        u8 tag;
+        u8 padding[3];
+} __packed;
+struct wl1271_cmd_sched_scan_stop {
+        struct wl1271_cmd_header header;
+        u8 tag;
+        u8 padding[3];
+} __packed;
 #endif /* __WL1271_SCAN_H__ */
diff --git a/drivers/net/wireless/wl12xx/sdio.c b/drivers/net/wireless/wl12xx/sdio.c
index b1c7d031c391..536e5065454b 100644
--- a/drivers/net/wireless/wl12xx/sdio.c
+++ b/drivers/net/wireless/wl12xx/sdio.c
@@ -51,6 +51,13 @@ static const struct sdio_device_id wl1271_devices[] = {
 };
 MODULE_DEVICE_TABLE(sdio, wl1271_devices);
+static void wl1271_sdio_set_block_size(struct wl1271 *wl, unsigned int blksz)
+{
+        sdio_claim_host(wl->if_priv);
+        sdio_set_block_size(wl->if_priv, blksz);
+        sdio_release_host(wl->if_priv);
+}
 static inline struct sdio_func *wl_to_func(struct wl1271 *wl)
 {
        return wl->if_priv;
@@ -75,6 +82,16 @@ static irqreturn_t wl1271_hardirq(int irq, void *cookie)
                complete(wl->elp_compl);
                wl->elp_compl = NULL;
        }
+        if (test_bit(WL1271_FLAG_SUSPENDED, &wl->flags)) {
+                /* don't enqueue a work right now. mark it as pending */
+                set_bit(WL1271_FLAG_PENDING_WORK, &wl->flags);
+                wl1271_debug(DEBUG_IRQ, "should not enqueue work");
+                disable_irq_nosync(wl->irq);
+                pm_wakeup_event(wl1271_sdio_wl_to_dev(wl), 0);
+                spin_unlock_irqrestore(&wl->wl_lock, flags);
+                return IRQ_HANDLED;
+        }
        spin_unlock_irqrestore(&wl->wl_lock, flags);
        return IRQ_WAKE_THREAD;
@@ -203,7 +220,8 @@ static struct wl1271_if_operations sdio_ops = {
        .power          = wl1271_sdio_set_power,
        .dev            = wl1271_sdio_wl_to_dev,
        .enable_irq     = wl1271_sdio_enable_interrupts,
-        .disable_irq    = wl1271_sdio_disable_interrupts
+        .disable_irq    = wl1271_sdio_disable_interrupts,
+        .set_block_size = wl1271_sdio_set_block_size,
 };
 static int __devinit wl1271_probe(struct sdio_func *func,
@@ -212,6 +230,8 @@ static int __devinit wl1271_probe(struct sdio_func *func,
        struct ieee80211_hw *hw;
        const struct wl12xx_platform_data *wlan_data;
        struct wl1271 *wl;
+        unsigned long irqflags;
+        mmc_pm_flag_t mmcflags;
        int ret;
        /* We are only able to handle the wlan function */
@@ -230,6 +250,9 @@ static int __devinit wl1271_probe(struct sdio_func *func,
        /* Grab access to FN0 for ELP reg. */
        func->card->quirks |= MMC_QUIRK_LENIENT_FN0;
+        /* Use block mode for transferring over one block size of data */
+        func->card->quirks |= MMC_QUIRK_BLKSZ_FOR_BYTE_MODE;
        wlan_data = wl12xx_get_platform_data();
        if (IS_ERR(wlan_data)) {
                ret = PTR_ERR(wlan_data);
@@ -239,17 +262,34 @@ static int __devinit wl1271_probe(struct sdio_func *func,
        wl->irq = wlan_data->irq;
        wl->ref_clock = wlan_data->board_ref_clock;
+        wl->tcxo_clock = wlan_data->board_tcxo_clock;
+        wl->platform_quirks = wlan_data->platform_quirks;
+        if (wl->platform_quirks & WL12XX_PLATFORM_QUIRK_EDGE_IRQ)
+                irqflags = IRQF_TRIGGER_RISING;
+        else
+                irqflags = IRQF_TRIGGER_HIGH | IRQF_ONESHOT;
        ret = request_threaded_irq(wl->irq, wl1271_hardirq, wl1271_irq,
-                                   IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+                                   irqflags,
                                   DRIVER_NAME, wl);
        if (ret < 0) {
                wl1271_error("request_irq() failed: %d", ret);
                goto out_free;
        }
+        enable_irq_wake(wl->irq);
+        device_init_wakeup(wl1271_sdio_wl_to_dev(wl), 1);
        disable_irq(wl->irq);
+        /* if sdio can keep power while host is suspended, enable wow */
+        mmcflags = sdio_get_host_pm_caps(func);
+        wl1271_debug(DEBUG_SDIO, "sdio PM caps = 0x%x", mmcflags);
+        if (mmcflags & MMC_PM_KEEP_POWER)
+                hw->wiphy->wowlan.flags = WIPHY_WOWLAN_ANY;
        ret = wl1271_init_ieee80211(wl);
        if (ret)
                goto out_irq;
@@ -284,19 +324,61 @@ static void __devexit wl1271_remove(struct sdio_func *func)
        pm_runtime_get_noresume(&func->dev);
        wl1271_unregister_hw(wl);
+        device_init_wakeup(wl1271_sdio_wl_to_dev(wl), 0);
+        disable_irq_wake(wl->irq);
        free_irq(wl->irq, wl);
        wl1271_free_hw(wl);
 }
+#ifdef CONFIG_PM
 static int wl1271_suspend(struct device *dev)
 {
        /* Tell MMC/SDIO core it's OK to power down the card
         * (if it isn't already), but not to remove it completely */
-        return 0;
+        struct sdio_func *func = dev_to_sdio_func(dev);
+        struct wl1271 *wl = sdio_get_drvdata(func);
+        mmc_pm_flag_t sdio_flags;
+        int ret = 0;
+        wl1271_debug(DEBUG_MAC80211, "wl1271 suspend. wow_enabled: %d",
+                     wl->wow_enabled);
+        /* check whether sdio should keep power */
+        if (wl->wow_enabled) {
+                sdio_flags = sdio_get_host_pm_caps(func);
+                if (!(sdio_flags & MMC_PM_KEEP_POWER)) {
+                        wl1271_error("can't keep power while host "
+                                     "is suspended");
+                        ret = -EINVAL;
+                        goto out;
+                }
+                /* keep power while host suspended */
+                ret = sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER);
+                if (ret) {
+                        wl1271_error("error while trying to keep power");
+                        goto out;
+                }
+                /* release host */
+                sdio_release_host(func);
+        }
+out:
+        return ret;
 }
 static int wl1271_resume(struct device *dev)
 {
+        struct sdio_func *func = dev_to_sdio_func(dev);
+        struct wl1271 *wl = sdio_get_drvdata(func);
+        wl1271_debug(DEBUG_MAC80211, "wl1271 resume");
+        if (wl->wow_enabled) {
+                /* claim back host */
+                sdio_claim_host(func);
+        }
        return 0;
 }
@@ -304,15 +386,18 @@ static const struct dev_pm_ops wl1271_sdio_pm_ops = {
        .suspend        = wl1271_suspend,
        .resume         = wl1271_resume,
 };
+#endif
 static struct sdio_driver wl1271_sdio_driver = {
        .name           = "wl1271_sdio",
        .id_table       = wl1271_devices,
        .probe          = wl1271_probe,
        .remove         = __devexit_p(wl1271_remove),
+#ifdef CONFIG_PM
        .drv = {
                .pm = &wl1271_sdio_pm_ops,
        },
+#endif
 };
 static int __init wl1271_init(void)
@@ -343,4 +428,6 @@ MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Luciano Coelho <coelho@ti.com>");
 MODULE_AUTHOR("Juuso Oikarinen <juuso.oikarinen@nokia.com>");
 MODULE_FIRMWARE(WL1271_FW_NAME);
-MODULE_FIRMWARE(WL1271_AP_FW_NAME);
+MODULE_FIRMWARE(WL128X_FW_NAME);
+MODULE_FIRMWARE(WL127X_AP_FW_NAME);
+MODULE_FIRMWARE(WL128X_AP_FW_NAME);
diff --git a/drivers/net/wireless/wl12xx/sdio_test.c b/drivers/net/wireless/wl12xx/sdio_test.c
index 9fcbd3dd8490..f28915392877 100644
--- a/drivers/net/wireless/wl12xx/sdio_test.c
+++ b/drivers/net/wireless/wl12xx/sdio_test.c
@@ -189,7 +189,12 @@ static int wl1271_fetch_firmware(struct wl1271 *wl)
        const struct firmware *fw;
        int ret;
-        ret = request_firmware(&fw, WL1271_FW_NAME, wl1271_wl_to_dev(wl));
+        if (wl->chip.id == CHIP_ID_1283_PG20)
+                ret = request_firmware(&fw, WL128X_FW_NAME,
+                                       wl1271_wl_to_dev(wl));
+        else
+                ret = request_firmware(&fw, WL1271_FW_NAME,
+                                       wl1271_wl_to_dev(wl));
        if (ret < 0) {
                wl1271_error("could not get firmware: %d", ret);
@@ -227,14 +232,14 @@ static int wl1271_fetch_nvs(struct wl1271 *wl)
        const struct firmware *fw;
        int ret;
-        ret = request_firmware(&fw, WL1271_NVS_NAME, wl1271_wl_to_dev(wl));
+        ret = request_firmware(&fw, WL12XX_NVS_NAME, wl1271_wl_to_dev(wl));
        if (ret < 0) {
                wl1271_error("could not get nvs file: %d", ret);
                return ret;
        }
-        wl->nvs = kmemdup(fw->data, sizeof(struct wl1271_nvs_file), GFP_KERNEL);
+        wl->nvs = kmemdup(fw->data, fw->size, GFP_KERNEL);
        if (!wl->nvs) {
                wl1271_error("could not allocate memory for the nvs file");
@@ -288,6 +293,11 @@ static int wl1271_chip_wakeup(struct wl1271 *wl)
                wl1271_notice("chip id 0x%x (1271 PG20)",
                                wl->chip.id);
                break;
+        case CHIP_ID_1283_PG20:
+                wl1271_notice("chip id 0x%x (1283 PG20)",
+                                wl->chip.id);
+                break;
+        case CHIP_ID_1283_PG10:
        default:
                wl1271_warning("unsupported chip id: 0x%x", wl->chip.id);
                return -ENODEV;
@@ -407,6 +417,9 @@ static int __devinit wl1271_probe(struct sdio_func *func,
        /* Grab access to FN0 for ELP reg. */
        func->card->quirks |= MMC_QUIRK_LENIENT_FN0;
+        /* Use block mode for transferring over one block size of data */
+        func->card->quirks |= MMC_QUIRK_BLKSZ_FOR_BYTE_MODE;
        wlan_data = wl12xx_get_platform_data();
        if (IS_ERR(wlan_data)) {
                ret = PTR_ERR(wlan_data);
@@ -416,6 +429,7 @@ static int __devinit wl1271_probe(struct sdio_func *func,
        wl->irq = wlan_data->irq;
        wl->ref_clock = wlan_data->board_ref_clock;
+        wl->tcxo_clock = wlan_data->board_tcxo_clock;
        sdio_set_drvdata(func, wl_test);
diff --git a/drivers/net/wireless/wl12xx/spi.c b/drivers/net/wireless/wl12xx/spi.c
index ffc745b17f4d..51662bb68019 100644
--- a/drivers/net/wireless/wl12xx/spi.c
+++ b/drivers/net/wireless/wl12xx/spi.c
@@ -355,7 +355,8 @@ static struct wl1271_if_operations spi_ops = {
        .power          = wl1271_spi_set_power,
        .dev            = wl1271_spi_wl_to_dev,
        .enable_irq     = wl1271_spi_enable_interrupts,
-        .disable_irq    = wl1271_spi_disable_interrupts
+        .disable_irq    = wl1271_spi_disable_interrupts,
+        .set_block_size = NULL,
 };
 static int __devinit wl1271_probe(struct spi_device *spi)
@@ -363,6 +364,7 @@ static int __devinit wl1271_probe(struct spi_device *spi)
        struct wl12xx_platform_data *pdata;
        struct ieee80211_hw *hw;
        struct wl1271 *wl;
+        unsigned long irqflags;
        int ret;
        pdata = spi->dev.platform_data;
@@ -400,6 +402,13 @@ static int __devinit wl1271_probe(struct spi_device *spi)
        }
        wl->ref_clock = pdata->board_ref_clock;
+        wl->tcxo_clock = pdata->board_tcxo_clock;
+        wl->platform_quirks = pdata->platform_quirks;
+        if (wl->platform_quirks & WL12XX_PLATFORM_QUIRK_EDGE_IRQ)
+                irqflags = IRQF_TRIGGER_RISING;
+        else
+                irqflags = IRQF_TRIGGER_HIGH | IRQF_ONESHOT;
        wl->irq = spi->irq;
        if (wl->irq < 0) {
@@ -409,7 +418,7 @@ static int __devinit wl1271_probe(struct spi_device *spi)
        }
        ret = request_threaded_irq(wl->irq, wl1271_hardirq, wl1271_irq,
-                                   IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+                                   irqflags,
                                   DRIVER_NAME, wl);
        if (ret < 0) {
                wl1271_error("request_irq() failed: %d", ret);
@@ -490,5 +499,7 @@ MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Luciano Coelho <coelho@ti.com>");
 MODULE_AUTHOR("Juuso Oikarinen <juuso.oikarinen@nokia.com>");
 MODULE_FIRMWARE(WL1271_FW_NAME);
-MODULE_FIRMWARE(WL1271_AP_FW_NAME);
+MODULE_FIRMWARE(WL128X_FW_NAME);
+MODULE_FIRMWARE(WL127X_AP_FW_NAME);
+MODULE_FIRMWARE(WL128X_AP_FW_NAME);
 MODULE_ALIAS("spi:wl1271");
diff --git a/drivers/net/wireless/wl12xx/testmode.c b/drivers/net/wireless/wl12xx/testmode.c
index 6ec06a4a4c6d..da351d7cd1f2 100644
--- a/drivers/net/wireless/wl12xx/testmode.c
+++ b/drivers/net/wireless/wl12xx/testmode.c
@@ -27,6 +27,7 @@
 #include "wl12xx.h"
 #include "acx.h"
+#include "reg.h"
 #define WL1271_TM_MAX_DATA_LENGTH 1024
@@ -204,7 +205,10 @@ static int wl1271_tm_cmd_nvs_push(struct wl1271 *wl, struct nlattr *tb[])
        kfree(wl->nvs);
-        if (len != sizeof(struct wl1271_nvs_file))
+        if ((wl->chip.id == CHIP_ID_1283_PG20) &&
+            (len != sizeof(struct wl128x_nvs_file)))
+                return -EINVAL;
+        else if (len != sizeof(struct wl1271_nvs_file))
                return -EINVAL;
        wl->nvs = kzalloc(len, GFP_KERNEL);
diff --git a/drivers/net/wireless/wl12xx/tx.c b/drivers/net/wireless/wl12xx/tx.c
index 5e9ef7d53e7e..ca3ab1c1acef 100644
--- a/drivers/net/wireless/wl12xx/tx.c
+++ b/drivers/net/wireless/wl12xx/tx.c
@@ -65,11 +65,36 @@ static int wl1271_alloc_tx_id(struct wl1271 *wl, struct sk_buff *skb)
 static void wl1271_free_tx_id(struct wl1271 *wl, int id)
 {
        if (__test_and_clear_bit(id, wl->tx_frames_map)) {
+                if (unlikely(wl->tx_frames_cnt == ACX_TX_DESCRIPTORS))
+                        clear_bit(WL1271_FLAG_FW_TX_BUSY, &wl->flags);
                wl->tx_frames[id] = NULL;
                wl->tx_frames_cnt--;
        }
 }
+static int wl1271_tx_update_filters(struct wl1271 *wl,
+                                                 struct sk_buff *skb)
+{
+        struct ieee80211_hdr *hdr;
+        hdr = (struct ieee80211_hdr *)(skb->data +
+                                       sizeof(struct wl1271_tx_hw_descr));
+        /*
+         * stop bssid-based filtering before transmitting authentication
+         * requests. this way the hw will never drop authentication
+         * responses coming from BSSIDs it isn't familiar with (e.g. on
+         * roaming)
+         */
+        if (!ieee80211_is_auth(hdr->frame_control))
+                return 0;
+        wl1271_configure_filters(wl, FIF_OTHER_BSS);
+        return wl1271_acx_rx_config(wl, wl->rx_config, wl->rx_filter);
+}
 static void wl1271_tx_ap_update_inconnection_sta(struct wl1271 *wl,
                                                 struct sk_buff *skb)
 {
@@ -127,13 +152,29 @@ u8 wl1271_tx_get_hlid(struct sk_buff *skb)
        }
 }
+static unsigned int wl12xx_calc_packet_alignment(struct wl1271 *wl,
+                                                unsigned int packet_length)
+{
+        if (wl->quirks & WL12XX_QUIRK_BLOCKSIZE_ALIGNMENT)
+                return ALIGN(packet_length, WL12XX_BUS_BLOCK_SIZE);
+        else
+                return ALIGN(packet_length, WL1271_TX_ALIGN_TO);
+}
 static int wl1271_tx_allocate(struct wl1271 *wl, struct sk_buff *skb, u32 extra,
                                u32 buf_offset, u8 hlid)
 {
        struct wl1271_tx_hw_descr *desc;
        u32 total_len = skb->len + sizeof(struct wl1271_tx_hw_descr) + extra;
+        u32 len;
        u32 total_blocks;
        int id, ret = -EBUSY;
+        u32 spare_blocks;
+        if (unlikely(wl->quirks & WL12XX_QUIRK_USE_2_SPARE_BLOCKS))
+                spare_blocks = 2;
+        else
+                spare_blocks = 1;
        if (buf_offset + total_len > WL1271_AGGR_BUFFER_SIZE)
                return -EAGAIN;
@@ -145,17 +186,27 @@ static int wl1271_tx_allocate(struct wl1271 *wl, struct sk_buff *skb, u32 extra,
        /* approximate the number of blocks required for this packet
           in the firmware */
-        total_blocks = total_len + TX_HW_BLOCK_SIZE - 1;
+        len = wl12xx_calc_packet_alignment(wl, total_len);
-        total_blocks = total_blocks / TX_HW_BLOCK_SIZE + TX_HW_BLOCK_SPARE;
+        total_blocks = (len + TX_HW_BLOCK_SIZE - 1) / TX_HW_BLOCK_SIZE +
+                spare_blocks;
        if (total_blocks <= wl->tx_blocks_available) {
                desc = (struct wl1271_tx_hw_descr *)skb_push(
                        skb, total_len - skb->len);
-                desc->extra_mem_blocks = TX_HW_BLOCK_SPARE;
+                /* HW descriptor fields change between wl127x and wl128x */
-                desc->total_mem_blocks = total_blocks;
+                if (wl->chip.id == CHIP_ID_1283_PG20) {
+                        desc->wl128x_mem.total_mem_blocks = total_blocks;
+                } else {
+                        desc->wl127x_mem.extra_blocks = spare_blocks;
+                        desc->wl127x_mem.total_mem_blocks = total_blocks;
+                }
                desc->id = id;
                wl->tx_blocks_available -= total_blocks;
+                wl->tx_allocated_blocks += total_blocks;
                if (wl->bss_type == BSS_TYPE_AP_BSS)
                        wl->links[hlid].allocated_blks += total_blocks;
@@ -172,13 +223,18 @@ static int wl1271_tx_allocate(struct wl1271 *wl, struct sk_buff *skb, u32 extra,
        return ret;
 }
+static bool wl12xx_is_dummy_packet(struct wl1271 *wl, struct sk_buff *skb)
+{
+        return wl->dummy_packet == skb;
+}
 static void wl1271_tx_fill_hdr(struct wl1271 *wl, struct sk_buff *skb,
                              u32 extra, struct ieee80211_tx_info *control,
                              u8 hlid)
 {
        struct timespec ts;
        struct wl1271_tx_hw_descr *desc;
-        int pad, ac, rate_idx;
+        int aligned_len, ac, rate_idx;
        s64 hosttime;
        u16 tx_attr;
@@ -202,12 +258,25 @@ static void wl1271_tx_fill_hdr(struct wl1271 *wl, struct sk_buff *skb,
        else
                desc->life_time = cpu_to_le16(TX_HW_AP_MODE_PKT_LIFETIME_TU);
-        /* configure the tx attributes */
+        /* queue */
-        tx_attr = wl->session_counter << TX_HW_ATTR_OFST_SESSION_COUNTER;
-        /* queue (we use same identifiers for tid's and ac's */
        ac = wl1271_tx_get_queue(skb_get_queue_mapping(skb));
-        desc->tid = ac;
+        desc->tid = skb->priority;
+        if (wl12xx_is_dummy_packet(wl, skb)) {
+                /*
+                 * FW expects the dummy packet to have an invalid session id -
+                 * any session id that is different than the one set in the join
+                 */
+                tx_attr = ((~wl->session_counter) <<
+                           TX_HW_ATTR_OFST_SESSION_COUNTER) &
+                           TX_HW_ATTR_SESSION_COUNTER;
+                tx_attr |= TX_HW_ATTR_TX_DUMMY_REQ;
+        } else {
+                /* configure the tx attributes */
+                tx_attr =
+                        wl->session_counter << TX_HW_ATTR_OFST_SESSION_COUNTER;
+        }
        if (wl->bss_type != BSS_TYPE_AP_BSS) {
                desc->aid = hlid;
@@ -237,20 +306,37 @@ static void wl1271_tx_fill_hdr(struct wl1271 *wl, struct sk_buff *skb,
        tx_attr |= rate_idx << TX_HW_ATTR_OFST_RATE_POLICY;
        desc->reserved = 0;
-        /* align the length (and store in terms of words) */
+        aligned_len = wl12xx_calc_packet_alignment(wl, skb->len);
-        pad = ALIGN(skb->len, WL1271_TX_ALIGN_TO);
-        desc->length = cpu_to_le16(pad >> 2);
-        /* calculate number of padding bytes */
+        if (wl->chip.id == CHIP_ID_1283_PG20) {
-        pad = pad - skb->len;
+                desc->wl128x_mem.extra_bytes = aligned_len - skb->len;
-        tx_attr |= pad << TX_HW_ATTR_OFST_LAST_WORD_PAD;
+                desc->length = cpu_to_le16(aligned_len >> 2);
-        desc->tx_attr = cpu_to_le16(tx_attr);
+                wl1271_debug(DEBUG_TX, "tx_fill_hdr: hlid: %d "
+                             "tx_attr: 0x%x len: %d life: %d mem: %d",
+                             desc->hlid, tx_attr,
+                             le16_to_cpu(desc->length),
+                             le16_to_cpu(desc->life_time),
+                             desc->wl128x_mem.total_mem_blocks);
+        } else {
+                int pad;
-        wl1271_debug(DEBUG_TX, "tx_fill_hdr: pad: %d hlid: %d "
+                /* Store the aligned length in terms of words */
-                "tx_attr: 0x%x len: %d life: %d mem: %d", pad, desc->hlid,
+                desc->length = cpu_to_le16(aligned_len >> 2);
-                le16_to_cpu(desc->tx_attr), le16_to_cpu(desc->length),
-                le16_to_cpu(desc->life_time), desc->total_mem_blocks);
+                /* calculate number of padding bytes */
+                pad = aligned_len - skb->len;
+                tx_attr |= pad << TX_HW_ATTR_OFST_LAST_WORD_PAD;
+                wl1271_debug(DEBUG_TX, "tx_fill_hdr: pad: %d hlid: %d "
+                             "tx_attr: 0x%x len: %d life: %d mem: %d", pad,
+                             desc->hlid, tx_attr,
+                             le16_to_cpu(desc->length),
+                             le16_to_cpu(desc->life_time),
+                             desc->wl127x_mem.total_mem_blocks);
+        }
+        desc->tx_attr = cpu_to_le16(tx_attr);
 }
 /* caller must hold wl->mutex */
@@ -300,19 +386,29 @@ static int wl1271_prepare_tx_frame(struct wl1271 *wl, struct sk_buff *skb,
        if (wl->bss_type == BSS_TYPE_AP_BSS) {
                wl1271_tx_ap_update_inconnection_sta(wl, skb);
                wl1271_tx_regulate_link(wl, hlid);
+        } else {
+                wl1271_tx_update_filters(wl, skb);
        }
        wl1271_tx_fill_hdr(wl, skb, extra, info, hlid);
        /*
-         * The length of each packet is stored in terms of words. Thus, we must
+         * The length of each packet is stored in terms of
-         * pad the skb data to make sure its length is aligned.
+         * words. Thus, we must pad the skb data to make sure its
-         * The number of padding bytes is computed and set in wl1271_tx_fill_hdr
+         * length is aligned.  The number of padding bytes is computed
+         * and set in wl1271_tx_fill_hdr.
+         * In special cases, we want to align to a specific block size
+         * (eg. for wl128x with SDIO we align to 256).
         */
-        total_len = ALIGN(skb->len, WL1271_TX_ALIGN_TO);
+        total_len = wl12xx_calc_packet_alignment(wl, skb->len);
        memcpy(wl->aggr_buf + buf_offset, skb->data, skb->len);
        memset(wl->aggr_buf + buf_offset + skb->len, 0, total_len - skb->len);
+        /* Revert side effects in the dummy packet skb, so it can be reused */
+        if (wl12xx_is_dummy_packet(wl, skb))
+                skb_pull(skb, sizeof(struct wl1271_tx_hw_descr));
        return total_len;
 }
@@ -425,10 +521,23 @@ out:
 static struct sk_buff *wl1271_skb_dequeue(struct wl1271 *wl)
 {
+        unsigned long flags;
+        struct sk_buff *skb = NULL;
        if (wl->bss_type == BSS_TYPE_AP_BSS)
-                return wl1271_ap_skb_dequeue(wl);
+                skb = wl1271_ap_skb_dequeue(wl);
+        else
+                skb = wl1271_sta_skb_dequeue(wl);
-        return wl1271_sta_skb_dequeue(wl);
+        if (!skb &&
+            test_and_clear_bit(WL1271_FLAG_DUMMY_PACKET_PENDING, &wl->flags)) {
+                skb = wl->dummy_packet;
+                spin_lock_irqsave(&wl->wl_lock, flags);
+                wl->tx_queue_count--;
+                spin_unlock_irqrestore(&wl->wl_lock, flags);
+        }
+        return skb;
 }
 static void wl1271_skb_queue_head(struct wl1271 *wl, struct sk_buff *skb)
@@ -436,7 +545,9 @@ static void wl1271_skb_queue_head(struct wl1271 *wl, struct sk_buff *skb)
        unsigned long flags;
        int q = wl1271_tx_get_queue(skb_get_queue_mapping(skb));
-        if (wl->bss_type == BSS_TYPE_AP_BSS) {
+        if (wl12xx_is_dummy_packet(wl, skb)) {
+                set_bit(WL1271_FLAG_DUMMY_PACKET_PENDING, &wl->flags);
+        } else if (wl->bss_type == BSS_TYPE_AP_BSS) {
                u8 hlid = wl1271_tx_get_hlid(skb);
                skb_queue_head(&wl->links[hlid].tx_queue[q], skb);
@@ -454,22 +565,14 @@ static void wl1271_skb_queue_head(struct wl1271 *wl, struct sk_buff *skb)
 void wl1271_tx_work_locked(struct wl1271 *wl)
 {
        struct sk_buff *skb;
-        bool woken_up = false;
        u32 buf_offset = 0;
        bool sent_packets = false;
        int ret;
        if (unlikely(wl->state == WL1271_STATE_OFF))
-                goto out;
+                return;
        while ((skb = wl1271_skb_dequeue(wl))) {
-                if (!woken_up) {
-                        ret = wl1271_ps_elp_wakeup(wl);
-                        if (ret < 0)
-                                goto out_ack;
-                        woken_up = true;
-                }
                ret = wl1271_prepare_tx_frame(wl, skb, buf_offset);
                if (ret == -EAGAIN) {
                        /*
@@ -516,18 +619,22 @@ out_ack:
                wl1271_handle_tx_low_watermark(wl);
        }
-out:
-        if (woken_up)
-                wl1271_ps_elp_sleep(wl);
 }
 void wl1271_tx_work(struct work_struct *work)
 {
        struct wl1271 *wl = container_of(work, struct wl1271, tx_work);
+        int ret;
        mutex_lock(&wl->mutex);
+        ret = wl1271_ps_elp_wakeup(wl);
+        if (ret < 0)
+                goto out;
        wl1271_tx_work_locked(wl);
+        wl1271_ps_elp_sleep(wl);
+out:
        mutex_unlock(&wl->mutex);
 }
@@ -549,6 +656,11 @@ static void wl1271_tx_complete_packet(struct wl1271 *wl,
        skb = wl->tx_frames[id];
        info = IEEE80211_SKB_CB(skb);
+        if (wl12xx_is_dummy_packet(wl, skb)) {
+                wl1271_free_tx_id(wl, id);
+                return;
+        }
        /* update the TX status info */
        if (result->status == TX_SUCCESS) {
                if (!(info->flags & IEEE80211_TX_CTL_NO_ACK))
@@ -657,8 +769,8 @@ void wl1271_tx_reset_link_queues(struct wl1271 *wl, u8 hlid)
        wl1271_handle_tx_low_watermark(wl);
 }
-/* caller must hold wl->mutex */
+/* caller must hold wl->mutex and TX must be stopped */
-void wl1271_tx_reset(struct wl1271 *wl)
+void wl1271_tx_reset(struct wl1271 *wl, bool reset_tx_queues)
 {
        int i;
        struct sk_buff *skb;
@@ -678,10 +790,13 @@ void wl1271_tx_reset(struct wl1271 *wl)
                        while ((skb = skb_dequeue(&wl->tx_queue[i]))) {
                                wl1271_debug(DEBUG_TX, "freeing skb 0x%p",
                                             skb);
-                                info = IEEE80211_SKB_CB(skb);
-                                info->status.rates[0].idx = -1;
+                                if (!wl12xx_is_dummy_packet(wl, skb)) {
-                                info->status.rates[0].count = 0;
+                                        info = IEEE80211_SKB_CB(skb);
-                                ieee80211_tx_status(wl->hw, skb);
+                                        info->status.rates[0].idx = -1;
+                                        info->status.rates[0].count = 0;
+                                        ieee80211_tx_status(wl->hw, skb);
+                                }
                        }
                }
        }
@@ -691,8 +806,10 @@ void wl1271_tx_reset(struct wl1271 *wl)
        /*
         * Make sure the driver is at a consistent state, in case this
         * function is called from a context other than interface removal.
+         * This call will always wake the TX queues.
         */
-        wl1271_handle_tx_low_watermark(wl);
+        if (reset_tx_queues)
+                wl1271_handle_tx_low_watermark(wl);
        for (i = 0; i < ACX_TX_DESCRIPTORS; i++) {
                if (wl->tx_frames[i] == NULL)
@@ -702,21 +819,27 @@ void wl1271_tx_reset(struct wl1271 *wl)
                wl1271_free_tx_id(wl, i);
                wl1271_debug(DEBUG_TX, "freeing skb 0x%p", skb);
-                /* Remove private headers before passing the skb to mac80211 */
+                if (!wl12xx_is_dummy_packet(wl, skb)) {
-                info = IEEE80211_SKB_CB(skb);
+                        /*
-                skb_pull(skb, sizeof(struct wl1271_tx_hw_descr));
+                         * Remove private headers before passing the skb to
-                if (info->control.hw_key &&
+                         * mac80211
-                    info->control.hw_key->cipher == WLAN_CIPHER_SUITE_TKIP) {
+                         */
-                        int hdrlen = ieee80211_get_hdrlen_from_skb(skb);
+                        info = IEEE80211_SKB_CB(skb);
-                        memmove(skb->data + WL1271_TKIP_IV_SPACE, skb->data,
+                        skb_pull(skb, sizeof(struct wl1271_tx_hw_descr));
-                                hdrlen);
+                        if (info->control.hw_key &&
-                        skb_pull(skb, WL1271_TKIP_IV_SPACE);
+                            info->control.hw_key->cipher ==
-                }
+                            WLAN_CIPHER_SUITE_TKIP) {
+                                int hdrlen = ieee80211_get_hdrlen_from_skb(skb);
+                                memmove(skb->data + WL1271_TKIP_IV_SPACE,
+                                        skb->data, hdrlen);
+                                skb_pull(skb, WL1271_TKIP_IV_SPACE);
+                        }
-                info->status.rates[0].idx = -1;
+                        info->status.rates[0].idx = -1;
-                info->status.rates[0].count = 0;
+                        info->status.rates[0].count = 0;
-                ieee80211_tx_status(wl->hw, skb);
+                        ieee80211_tx_status(wl->hw, skb);
+                }
        }
 }
diff --git a/drivers/net/wireless/wl12xx/tx.h b/drivers/net/wireless/wl12xx/tx.h
index 02f07fa66e82..832f9258d675 100644
--- a/drivers/net/wireless/wl12xx/tx.h
+++ b/drivers/net/wireless/wl12xx/tx.h
@@ -25,7 +25,6 @@
 #ifndef __TX_H__
 #define __TX_H__
-#define TX_HW_BLOCK_SPARE                2
 #define TX_HW_BLOCK_SIZE                 252
 #define TX_HW_MGMT_PKT_LIFETIME_TU       2000
@@ -41,6 +40,7 @@
                                          BIT(8) | BIT(9))
 #define TX_HW_ATTR_LAST_WORD_PAD         (BIT(10) | BIT(11))
 #define TX_HW_ATTR_TX_CMPLT_REQ          BIT(12)
+#define TX_HW_ATTR_TX_DUMMY_REQ          BIT(13)
 #define TX_HW_ATTR_OFST_SAVE_RETRIES     0
 #define TX_HW_ATTR_OFST_HEADER_PAD       1
@@ -55,20 +55,60 @@
 #define WL1271_TX_ALIGN_TO 4
 #define WL1271_TKIP_IV_SPACE 4
+/* Used for management frames and dummy packets */
+#define WL1271_TID_MGMT 7
+struct wl127x_tx_mem {
+        /*
+         * Number of extra memory blocks to allocate for this packet
+         * in addition to the number of blocks derived from the packet
+         * length.
+         */
+        u8 extra_blocks;
+        /*
+         * Total number of memory blocks allocated by the host for
+         * this packet. Must be equal or greater than the actual
+         * blocks number allocated by HW.
+         */
+        u8 total_mem_blocks;
+} __packed;
+struct wl128x_tx_mem {
+        /*
+         * Total number of memory blocks allocated by the host for
+         * this packet.
+         */
+        u8 total_mem_blocks;
+        /*
+         * Number of extra bytes, at the end of the frame. the host
+         * uses this padding to complete each frame to integer number
+         * of SDIO blocks.
+         */
+        u8 extra_bytes;
+} __packed;
+/*
+ * On wl128x based devices, when TX packets are aggregated, each packet
+ * size must be aligned to the SDIO block size. The maximum block size
+ * is bounded by the type of the padded bytes field that is sent to the
+ * FW. Currently the type is u8, so the maximum block size is 256 bytes.
+ */
+#define WL12XX_BUS_BLOCK_SIZE min(512u, \
+            (1u << (8 * sizeof(((struct wl128x_tx_mem *) 0)->extra_bytes))))
 struct wl1271_tx_hw_descr {
        /* Length of packet in words, including descriptor+header+data */
        __le16 length;
-        /* Number of extra memory blocks to allocate for this packet in
+        union {
-           addition to the number of blocks derived from the packet length */
+                struct wl127x_tx_mem wl127x_mem;
-        u8 extra_mem_blocks;
+                struct wl128x_tx_mem wl128x_mem;
-        /* Total number of memory blocks allocated by the host for this packet.
+        } __packed;
-           Must be equal or greater than the actual blocks number allocated by
-           HW!! */
-        u8 total_mem_blocks;
        /* Device time (in us) when the packet arrived to the driver */
        __le32 start_time;
-        /* Max delay in TUs until transmission. The last device time the
+        /*
-           packet can be transmitted is: startTime+(1024*LifeTime) */
+         * Max delay in TUs until transmission. The last device time the
+         * packet can be transmitted is: start_time + (1024 * life_time)
+         */
        __le16 life_time;
        /* Bitwise fields - see TX_ATTR... definitions above. */
        __le16 tx_attr;
@@ -145,7 +185,7 @@ static inline int wl1271_tx_get_queue(int queue)
 void wl1271_tx_work(struct work_struct *work);
 void wl1271_tx_work_locked(struct wl1271 *wl);
 void wl1271_tx_complete(struct wl1271 *wl);
-void wl1271_tx_reset(struct wl1271 *wl);
+void wl1271_tx_reset(struct wl1271 *wl, bool reset_tx_queues);
 void wl1271_tx_flush(struct wl1271 *wl);
 u8 wl1271_rate_to_idx(int rate, enum ieee80211_band band);
 u32 wl1271_tx_enabled_rates_get(struct wl1271 *wl, u32 rate_set);
diff --git a/drivers/net/wireless/wl12xx/wl12xx.h b/drivers/net/wireless/wl12xx/wl12xx.h
index 86be83e25ec5..fbe8f46d1232 100644
--- a/drivers/net/wireless/wl12xx/wl12xx.h
+++ b/drivers/net/wireless/wl12xx/wl12xx.h
@@ -131,9 +131,16 @@ extern u32 wl12xx_debug_level;
 #define WL1271_FW_NAME "ti-connectivity/wl1271-fw-2.bin"
-#define WL1271_AP_FW_NAME "ti-connectivity/wl1271-fw-ap.bin"
+#define WL128X_FW_NAME "ti-connectivity/wl128x-fw.bin"
+#define WL127X_AP_FW_NAME "ti-connectivity/wl1271-fw-ap.bin"
+#define WL128X_AP_FW_NAME "ti-connectivity/wl128x-fw-ap.bin"
-#define WL1271_NVS_NAME "ti-connectivity/wl1271-nvs.bin"
+/*
+ * wl127x and wl128x are using the same NVS file name. However, the
+ * ini parameters between them are different.  The driver validates
+ * the correct NVS size in wl1271_boot_upload_nvs().
+ */
+#define WL12XX_NVS_NAME "ti-connectivity/wl1271-nvs.bin"
 #define WL1271_TX_SECURITY_LO16(s) ((u16)((s) & 0xffff))
 #define WL1271_TX_SECURITY_HI32(s) ((u32)(((s) >> 16) & 0xffffffff))
@@ -200,13 +207,29 @@ struct wl1271_partition_set {
 struct wl1271;
-#define WL12XX_NUM_FW_VER 5
+enum {
+        FW_VER_CHIP,
+        FW_VER_IF_TYPE,
+        FW_VER_MAJOR,
+        FW_VER_SUBTYPE,
+        FW_VER_MINOR,
+        NUM_FW_VER
+};
+#define FW_VER_CHIP_WL127X 6
+#define FW_VER_CHIP_WL128X 7
+#define FW_VER_IF_TYPE_STA 1
+#define FW_VER_IF_TYPE_AP  2
+#define FW_VER_MINOR_1_SPARE_STA_MIN 58
+#define FW_VER_MINOR_1_SPARE_AP_MIN  47
-/* FIXME: I'm not sure about this structure name */
 struct wl1271_chip {
        u32 id;
        char fw_ver_str[ETHTOOL_BUSINFO_LEN];
-        unsigned int fw_ver[WL12XX_NUM_FW_VER];
+        unsigned int fw_ver[NUM_FW_VER];
 };
 struct wl1271_stats {
@@ -261,6 +284,8 @@ struct wl1271_fw_sta_status {
        u8  tx_total;
        u8  reserved1;
        __le16 reserved2;
+        /* Total structure size is 68 bytes */
+        u32 padding;
 } __packed;
 struct wl1271_fw_full_status {
@@ -277,9 +302,10 @@ struct wl1271_rx_mem_pool_addr {
        u32 addr_extra;
 };
+#define WL1271_MAX_CHANNELS 64
 struct wl1271_scan {
        struct cfg80211_scan_request *req;
-        bool *scanned_ch;
+        unsigned long scanned_ch[BITS_TO_LONGS(WL1271_MAX_CHANNELS)];
        bool failed;
        u8 state;
        u8 ssid[IW_ESSID_MAX_SIZE+1];
@@ -297,6 +323,7 @@ struct wl1271_if_operations {
        struct device* (*dev)(struct wl1271 *wl);
        void (*enable_irq)(struct wl1271 *wl);
        void (*disable_irq)(struct wl1271 *wl);
+        void (*set_block_size) (struct wl1271 *wl, unsigned int blksz);
 };
 #define MAX_NUM_KEYS 14
@@ -319,15 +346,19 @@ enum wl12xx_flags {
        WL1271_FLAG_TX_QUEUE_STOPPED,
        WL1271_FLAG_TX_PENDING,
        WL1271_FLAG_IN_ELP,
+        WL1271_FLAG_ELP_REQUESTED,
        WL1271_FLAG_PSM,
        WL1271_FLAG_PSM_REQUESTED,
        WL1271_FLAG_IRQ_RUNNING,
        WL1271_FLAG_IDLE,
-        WL1271_FLAG_IDLE_REQUESTED,
        WL1271_FLAG_PSPOLL_FAILURE,
        WL1271_FLAG_STA_STATE_SENT,
        WL1271_FLAG_FW_TX_BUSY,
-        WL1271_FLAG_AP_STARTED
+        WL1271_FLAG_AP_STARTED,
+        WL1271_FLAG_IF_INITIALIZED,
+        WL1271_FLAG_DUMMY_PACKET_PENDING,
+        WL1271_FLAG_SUSPENDED,
+        WL1271_FLAG_PENDING_WORK,
 };
 struct wl1271_link {
@@ -371,7 +402,7 @@ struct wl1271 {
        u8 *fw;
        size_t fw_len;
        u8 fw_bss_type;
-        struct wl1271_nvs_file *nvs;
+        void *nvs;
        size_t nvs_len;
        s8 hw_pg_ver;
@@ -389,6 +420,7 @@ struct wl1271 {
        /* Accounting for allocated / available TX blocks on HW */
        u32 tx_blocks_freed[NUM_TX_QUEUES];
        u32 tx_blocks_available;
+        u32 tx_allocated_blocks;
        u32 tx_results_count;
        /* Transmitted TX packets counter for chipset interface */
@@ -430,6 +462,9 @@ struct wl1271 {
        /* Intermediate buffer, used for packet aggregation */
        u8 *aggr_buf;
+        /* Reusable dummy packet template */
+        struct sk_buff *dummy_packet;
        /* Network stack work  */
        struct work_struct netstack_work;
@@ -446,6 +481,8 @@ struct wl1271 {
        struct wl1271_scan scan;
        struct delayed_work scan_complete_work;
+        bool sched_scanning;
        /* probe-req template for the current AP */
        struct sk_buff *probereq;
@@ -476,6 +513,7 @@ struct wl1271 {
        unsigned int rx_filter;
        struct completion *elp_compl;
+        struct completion *ps_compl;
        struct delayed_work elp_work;
        struct delayed_work pspoll_work;
@@ -527,6 +565,14 @@ struct wl1271 {
        bool ba_support;
        u8 ba_rx_bitmap;
+        int tcxo_clock;
+        /*
+         * wowlan trigger was configured during suspend.
+         * (currently, only "ANY" trigger is supported)
+         */
+        bool wow_enabled;
        /*
         * AP-mode - links indexed by HLID. The global and broadcast links
         * are always active.
@@ -544,6 +590,9 @@ struct wl1271 {
        /* Quirks of specific hardware revisions */
        unsigned int quirks;
+        /* Platform limitations */
+        unsigned int platform_quirks;
 };
 struct wl1271_station {
@@ -576,6 +625,15 @@ int wl1271_plt_stop(struct wl1271 *wl);
 /* Quirks */
 /* Each RX/TX transaction requires an end-of-transaction transfer */
-#define WL12XX_QUIRK_END_OF_TRANSACTION BIT(0)
+#define WL12XX_QUIRK_END_OF_TRANSACTION         BIT(0)
+/*
+ * Older firmwares use 2 spare TX blocks
+ * (for STA < 6.1.3.50.58 or for AP < 6.2.0.0.47)
+ */
+#define WL12XX_QUIRK_USE_2_SPARE_BLOCKS         BIT(1)
+/* WL128X requires aggregated packets to be aligned to the SDIO block size */
+#define WL12XX_QUIRK_BLOCKSIZE_ALIGNMENT        BIT(2)
 #endif
diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c
index a73a305d3cba..ff306d763e37 100644
--- a/drivers/net/wireless/zd1211rw/zd_chip.c
+++ b/drivers/net/wireless/zd1211rw/zd_chip.c
@@ -557,7 +557,7 @@ int zd_chip_unlock_phy_regs(struct zd_chip *chip)
        return r;
 }
-/* CR157 can be optionally patched by the EEPROM for original ZD1211 */
+/* ZD_CR157 can be optionally patched by the EEPROM for original ZD1211 */
 static int patch_cr157(struct zd_chip *chip)
 {
        int r;
@@ -571,7 +571,7 @@ static int patch_cr157(struct zd_chip *chip)
                return r;
        dev_dbg_f(zd_chip_dev(chip), "patching value %x\n", value >> 8);
-        return zd_iowrite32_locked(chip, value >> 8, CR157);
+        return zd_iowrite32_locked(chip, value >> 8, ZD_CR157);
 }
 /*
@@ -593,8 +593,8 @@ static int patch_6m_band_edge(struct zd_chip *chip, u8 channel)
 int zd_chip_generic_patch_6m_band(struct zd_chip *chip, int channel)
 {
        struct zd_ioreq16 ioreqs[] = {
-                { CR128, 0x14 }, { CR129, 0x12 }, { CR130, 0x10 },
+                { ZD_CR128, 0x14 }, { ZD_CR129, 0x12 }, { ZD_CR130, 0x10 },
-                { CR47,  0x1e },
+                { ZD_CR47,  0x1e },
        };
        /* FIXME: Channel 11 is not the edge for all regulatory domains. */
@@ -608,69 +608,69 @@ int zd_chip_generic_patch_6m_band(struct zd_chip *chip, int channel)
 static int zd1211_hw_reset_phy(struct zd_chip *chip)
 {
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR0,   0x0a }, { CR1,   0x06 }, { CR2,   0x26 },
+                { ZD_CR0,   0x0a }, { ZD_CR1,   0x06 }, { ZD_CR2,   0x26 },
-                { CR3,   0x38 }, { CR4,   0x80 }, { CR9,   0xa0 },
+                { ZD_CR3,   0x38 }, { ZD_CR4,   0x80 }, { ZD_CR9,   0xa0 },
-                { CR10,  0x81 }, { CR11,  0x00 }, { CR12,  0x7f },
+                { ZD_CR10,  0x81 }, { ZD_CR11,  0x00 }, { ZD_CR12,  0x7f },
-                { CR13,  0x8c }, { CR14,  0x80 }, { CR15,  0x3d },
+                { ZD_CR13,  0x8c }, { ZD_CR14,  0x80 }, { ZD_CR15,  0x3d },
-                { CR16,  0x20 }, { CR17,  0x1e }, { CR18,  0x0a },
+                { ZD_CR16,  0x20 }, { ZD_CR17,  0x1e }, { ZD_CR18,  0x0a },
-                { CR19,  0x48 }, { CR20,  0x0c }, { CR21,  0x0c },
+                { ZD_CR19,  0x48 }, { ZD_CR20,  0x0c }, { ZD_CR21,  0x0c },
-                { CR22,  0x23 }, { CR23,  0x90 }, { CR24,  0x14 },
+                { ZD_CR22,  0x23 }, { ZD_CR23,  0x90 }, { ZD_CR24,  0x14 },
-                { CR25,  0x40 }, { CR26,  0x10 }, { CR27,  0x19 },
+                { ZD_CR25,  0x40 }, { ZD_CR26,  0x10 }, { ZD_CR27,  0x19 },
-                { CR28,  0x7f }, { CR29,  0x80 }, { CR30,  0x4b },
+                { ZD_CR28,  0x7f }, { ZD_CR29,  0x80 }, { ZD_CR30,  0x4b },
-                { CR31,  0x60 }, { CR32,  0x43 }, { CR33,  0x08 },
+                { ZD_CR31,  0x60 }, { ZD_CR32,  0x43 }, { ZD_CR33,  0x08 },
-                { CR34,  0x06 }, { CR35,  0x0a }, { CR36,  0x00 },
+                { ZD_CR34,  0x06 }, { ZD_CR35,  0x0a }, { ZD_CR36,  0x00 },
-                { CR37,  0x00 }, { CR38,  0x38 }, { CR39,  0x0c },
+                { ZD_CR37,  0x00 }, { ZD_CR38,  0x38 }, { ZD_CR39,  0x0c },
-                { CR40,  0x84 }, { CR41,  0x2a }, { CR42,  0x80 },
+                { ZD_CR40,  0x84 }, { ZD_CR41,  0x2a }, { ZD_CR42,  0x80 },
-                { CR43,  0x10 }, { CR44,  0x12 }, { CR46,  0xff },
+                { ZD_CR43,  0x10 }, { ZD_CR44,  0x12 }, { ZD_CR46,  0xff },
-                { CR47,  0x1E }, { CR48,  0x26 }, { CR49,  0x5b },
+                { ZD_CR47,  0x1E }, { ZD_CR48,  0x26 }, { ZD_CR49,  0x5b },
-                { CR64,  0xd0 }, { CR65,  0x04 }, { CR66,  0x58 },
+                { ZD_CR64,  0xd0 }, { ZD_CR65,  0x04 }, { ZD_CR66,  0x58 },
-                { CR67,  0xc9 }, { CR68,  0x88 }, { CR69,  0x41 },
+                { ZD_CR67,  0xc9 }, { ZD_CR68,  0x88 }, { ZD_CR69,  0x41 },
-                { CR70,  0x23 }, { CR71,  0x10 }, { CR72,  0xff },
+                { ZD_CR70,  0x23 }, { ZD_CR71,  0x10 }, { ZD_CR72,  0xff },
-                { CR73,  0x32 }, { CR74,  0x30 }, { CR75,  0x65 },
+                { ZD_CR73,  0x32 }, { ZD_CR74,  0x30 }, { ZD_CR75,  0x65 },
-                { CR76,  0x41 }, { CR77,  0x1b }, { CR78,  0x30 },
+                { ZD_CR76,  0x41 }, { ZD_CR77,  0x1b }, { ZD_CR78,  0x30 },
-                { CR79,  0x68 }, { CR80,  0x64 }, { CR81,  0x64 },
+                { ZD_CR79,  0x68 }, { ZD_CR80,  0x64 }, { ZD_CR81,  0x64 },
-                { CR82,  0x00 }, { CR83,  0x00 }, { CR84,  0x00 },
+                { ZD_CR82,  0x00 }, { ZD_CR83,  0x00 }, { ZD_CR84,  0x00 },
-                { CR85,  0x02 }, { CR86,  0x00 }, { CR87,  0x00 },
+                { ZD_CR85,  0x02 }, { ZD_CR86,  0x00 }, { ZD_CR87,  0x00 },
-                { CR88,  0xff }, { CR89,  0xfc }, { CR90,  0x00 },
+                { ZD_CR88,  0xff }, { ZD_CR89,  0xfc }, { ZD_CR90,  0x00 },
-                { CR91,  0x00 }, { CR92,  0x00 }, { CR93,  0x08 },
+                { ZD_CR91,  0x00 }, { ZD_CR92,  0x00 }, { ZD_CR93,  0x08 },
-                { CR94,  0x00 }, { CR95,  0x00 }, { CR96,  0xff },
+                { ZD_CR94,  0x00 }, { ZD_CR95,  0x00 }, { ZD_CR96,  0xff },
-                { CR97,  0xe7 }, { CR98,  0x00 }, { CR99,  0x00 },
+                { ZD_CR97,  0xe7 }, { ZD_CR98,  0x00 }, { ZD_CR99,  0x00 },
-                { CR100, 0x00 }, { CR101, 0xae }, { CR102, 0x02 },
+                { ZD_CR100, 0x00 }, { ZD_CR101, 0xae }, { ZD_CR102, 0x02 },
-                { CR103, 0x00 }, { CR104, 0x03 }, { CR105, 0x65 },
+                { ZD_CR103, 0x00 }, { ZD_CR104, 0x03 }, { ZD_CR105, 0x65 },
-                { CR106, 0x04 }, { CR107, 0x00 }, { CR108, 0x0a },
+                { ZD_CR106, 0x04 }, { ZD_CR107, 0x00 }, { ZD_CR108, 0x0a },
-                { CR109, 0xaa }, { CR110, 0xaa }, { CR111, 0x25 },
+                { ZD_CR109, 0xaa }, { ZD_CR110, 0xaa }, { ZD_CR111, 0x25 },
-                { CR112, 0x25 }, { CR113, 0x00 }, { CR119, 0x1e },
+                { ZD_CR112, 0x25 }, { ZD_CR113, 0x00 }, { ZD_CR119, 0x1e },
-                { CR125, 0x90 }, { CR126, 0x00 }, { CR127, 0x00 },
+                { ZD_CR125, 0x90 }, { ZD_CR126, 0x00 }, { ZD_CR127, 0x00 },
                { },
-                { CR5,   0x00 }, { CR6,   0x00 }, { CR7,   0x00 },
+                { ZD_CR5,   0x00 }, { ZD_CR6,   0x00 }, { ZD_CR7,   0x00 },
-                { CR8,   0x00 }, { CR9,   0x20 }, { CR12,  0xf0 },
+                { ZD_CR8,   0x00 }, { ZD_CR9,   0x20 }, { ZD_CR12,  0xf0 },
-                { CR20,  0x0e }, { CR21,  0x0e }, { CR27,  0x10 },
+                { ZD_CR20,  0x0e }, { ZD_CR21,  0x0e }, { ZD_CR27,  0x10 },
-                { CR44,  0x33 }, { CR47,  0x1E }, { CR83,  0x24 },
+                { ZD_CR44,  0x33 }, { ZD_CR47,  0x1E }, { ZD_CR83,  0x24 },
-                { CR84,  0x04 }, { CR85,  0x00 }, { CR86,  0x0C },
+                { ZD_CR84,  0x04 }, { ZD_CR85,  0x00 }, { ZD_CR86,  0x0C },
-                { CR87,  0x12 }, { CR88,  0x0C }, { CR89,  0x00 },
+                { ZD_CR87,  0x12 }, { ZD_CR88,  0x0C }, { ZD_CR89,  0x00 },
-                { CR90,  0x10 }, { CR91,  0x08 }, { CR93,  0x00 },
+                { ZD_CR90,  0x10 }, { ZD_CR91,  0x08 }, { ZD_CR93,  0x00 },
-                { CR94,  0x01 }, { CR95,  0x00 }, { CR96,  0x50 },
+                { ZD_CR94,  0x01 }, { ZD_CR95,  0x00 }, { ZD_CR96,  0x50 },
-                { CR97,  0x37 }, { CR98,  0x35 }, { CR101, 0x13 },
+                { ZD_CR97,  0x37 }, { ZD_CR98,  0x35 }, { ZD_CR101, 0x13 },
-                { CR102, 0x27 }, { CR103, 0x27 }, { CR104, 0x18 },
+                { ZD_CR102, 0x27 }, { ZD_CR103, 0x27 }, { ZD_CR104, 0x18 },
-                { CR105, 0x12 }, { CR109, 0x27 }, { CR110, 0x27 },
+                { ZD_CR105, 0x12 }, { ZD_CR109, 0x27 }, { ZD_CR110, 0x27 },
-                { CR111, 0x27 }, { CR112, 0x27 }, { CR113, 0x27 },
+                { ZD_CR111, 0x27 }, { ZD_CR112, 0x27 }, { ZD_CR113, 0x27 },
-                { CR114, 0x27 }, { CR115, 0x26 }, { CR116, 0x24 },
+                { ZD_CR114, 0x27 }, { ZD_CR115, 0x26 }, { ZD_CR116, 0x24 },
-                { CR117, 0xfc }, { CR118, 0xfa }, { CR120, 0x4f },
+                { ZD_CR117, 0xfc }, { ZD_CR118, 0xfa }, { ZD_CR120, 0x4f },
-                { CR125, 0xaa }, { CR127, 0x03 }, { CR128, 0x14 },
+                { ZD_CR125, 0xaa }, { ZD_CR127, 0x03 }, { ZD_CR128, 0x14 },
-                { CR129, 0x12 }, { CR130, 0x10 }, { CR131, 0x0C },
+                { ZD_CR129, 0x12 }, { ZD_CR130, 0x10 }, { ZD_CR131, 0x0C },
-                { CR136, 0xdf }, { CR137, 0x40 }, { CR138, 0xa0 },
+                { ZD_CR136, 0xdf }, { ZD_CR137, 0x40 }, { ZD_CR138, 0xa0 },
-                { CR139, 0xb0 }, { CR140, 0x99 }, { CR141, 0x82 },
+                { ZD_CR139, 0xb0 }, { ZD_CR140, 0x99 }, { ZD_CR141, 0x82 },
-                { CR142, 0x54 }, { CR143, 0x1c }, { CR144, 0x6c },
+                { ZD_CR142, 0x54 }, { ZD_CR143, 0x1c }, { ZD_CR144, 0x6c },
-                { CR147, 0x07 }, { CR148, 0x4c }, { CR149, 0x50 },
+                { ZD_CR147, 0x07 }, { ZD_CR148, 0x4c }, { ZD_CR149, 0x50 },
-                { CR150, 0x0e }, { CR151, 0x18 }, { CR160, 0xfe },
+                { ZD_CR150, 0x0e }, { ZD_CR151, 0x18 }, { ZD_CR160, 0xfe },
-                { CR161, 0xee }, { CR162, 0xaa }, { CR163, 0xfa },
+                { ZD_CR161, 0xee }, { ZD_CR162, 0xaa }, { ZD_CR163, 0xfa },
-                { CR164, 0xfa }, { CR165, 0xea }, { CR166, 0xbe },
+                { ZD_CR164, 0xfa }, { ZD_CR165, 0xea }, { ZD_CR166, 0xbe },
-                { CR167, 0xbe }, { CR168, 0x6a }, { CR169, 0xba },
+                { ZD_CR167, 0xbe }, { ZD_CR168, 0x6a }, { ZD_CR169, 0xba },
-                { CR170, 0xba }, { CR171, 0xba },
+                { ZD_CR170, 0xba }, { ZD_CR171, 0xba },
-                /* Note: CR204 must lead the CR203 */
+                /* Note: ZD_CR204 must lead the ZD_CR203 */
-                { CR204, 0x7d },
+                { ZD_CR204, 0x7d },
                { },
-                { CR203, 0x30 },
+                { ZD_CR203, 0x30 },
        };
        int r, t;
@@ -697,62 +697,62 @@ out:
 static int zd1211b_hw_reset_phy(struct zd_chip *chip)
 {
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR0,   0x14 }, { CR1,   0x06 }, { CR2,   0x26 },
+                { ZD_CR0,   0x14 }, { ZD_CR1,   0x06 }, { ZD_CR2,   0x26 },
-                { CR3,   0x38 }, { CR4,   0x80 }, { CR9,   0xe0 },
+                { ZD_CR3,   0x38 }, { ZD_CR4,   0x80 }, { ZD_CR9,   0xe0 },
-                { CR10,  0x81 },
+                { ZD_CR10,  0x81 },
-                /* power control { { CR11,  1 << 6 }, */
+                /* power control { { ZD_CR11,  1 << 6 }, */
-                { CR11,  0x00 },
+                { ZD_CR11,  0x00 },
-                { CR12,  0xf0 }, { CR13,  0x8c }, { CR14,  0x80 },
+                { ZD_CR12,  0xf0 }, { ZD_CR13,  0x8c }, { ZD_CR14,  0x80 },
-                { CR15,  0x3d }, { CR16,  0x20 }, { CR17,  0x1e },
+                { ZD_CR15,  0x3d }, { ZD_CR16,  0x20 }, { ZD_CR17,  0x1e },
-                { CR18,  0x0a }, { CR19,  0x48 },
+                { ZD_CR18,  0x0a }, { ZD_CR19,  0x48 },
-                { CR20,  0x10 }, /* Org:0x0E, ComTrend:RalLink AP */
+                { ZD_CR20,  0x10 }, /* Org:0x0E, ComTrend:RalLink AP */
-                { CR21,  0x0e }, { CR22,  0x23 }, { CR23,  0x90 },
+                { ZD_CR21,  0x0e }, { ZD_CR22,  0x23 }, { ZD_CR23,  0x90 },
-                { CR24,  0x14 }, { CR25,  0x40 }, { CR26,  0x10 },
+                { ZD_CR24,  0x14 }, { ZD_CR25,  0x40 }, { ZD_CR26,  0x10 },
-                { CR27,  0x10 }, { CR28,  0x7f }, { CR29,  0x80 },
+                { ZD_CR27,  0x10 }, { ZD_CR28,  0x7f }, { ZD_CR29,  0x80 },
-                { CR30,  0x4b }, /* ASIC/FWT, no jointly decoder */
+                { ZD_CR30,  0x4b }, /* ASIC/FWT, no jointly decoder */
-                { CR31,  0x60 }, { CR32,  0x43 }, { CR33,  0x08 },
+                { ZD_CR31,  0x60 }, { ZD_CR32,  0x43 }, { ZD_CR33,  0x08 },
-                { CR34,  0x06 }, { CR35,  0x0a }, { CR36,  0x00 },
+                { ZD_CR34,  0x06 }, { ZD_CR35,  0x0a }, { ZD_CR36,  0x00 },
-                { CR37,  0x00 }, { CR38,  0x38 }, { CR39,  0x0c },
+                { ZD_CR37,  0x00 }, { ZD_CR38,  0x38 }, { ZD_CR39,  0x0c },
-                { CR40,  0x84 }, { CR41,  0x2a }, { CR42,  0x80 },
+                { ZD_CR40,  0x84 }, { ZD_CR41,  0x2a }, { ZD_CR42,  0x80 },
-                { CR43,  0x10 }, { CR44,  0x33 }, { CR46,  0xff },
+                { ZD_CR43,  0x10 }, { ZD_CR44,  0x33 }, { ZD_CR46,  0xff },
-                { CR47,  0x1E }, { CR48,  0x26 }, { CR49,  0x5b },
+                { ZD_CR47,  0x1E }, { ZD_CR48,  0x26 }, { ZD_CR49,  0x5b },
-                { CR64,  0xd0 }, { CR65,  0x04 }, { CR66,  0x58 },
+                { ZD_CR64,  0xd0 }, { ZD_CR65,  0x04 }, { ZD_CR66,  0x58 },
-                { CR67,  0xc9 }, { CR68,  0x88 }, { CR69,  0x41 },
+                { ZD_CR67,  0xc9 }, { ZD_CR68,  0x88 }, { ZD_CR69,  0x41 },
-                { CR70,  0x23 }, { CR71,  0x10 }, { CR72,  0xff },
+                { ZD_CR70,  0x23 }, { ZD_CR71,  0x10 }, { ZD_CR72,  0xff },
-                { CR73,  0x32 }, { CR74,  0x30 }, { CR75,  0x65 },
+                { ZD_CR73,  0x32 }, { ZD_CR74,  0x30 }, { ZD_CR75,  0x65 },
-                { CR76,  0x41 }, { CR77,  0x1b }, { CR78,  0x30 },
+                { ZD_CR76,  0x41 }, { ZD_CR77,  0x1b }, { ZD_CR78,  0x30 },
-                { CR79,  0xf0 }, { CR80,  0x64 }, { CR81,  0x64 },
+                { ZD_CR79,  0xf0 }, { ZD_CR80,  0x64 }, { ZD_CR81,  0x64 },
-                { CR82,  0x00 }, { CR83,  0x24 }, { CR84,  0x04 },
+                { ZD_CR82,  0x00 }, { ZD_CR83,  0x24 }, { ZD_CR84,  0x04 },
-                { CR85,  0x00 }, { CR86,  0x0c }, { CR87,  0x12 },
+                { ZD_CR85,  0x00 }, { ZD_CR86,  0x0c }, { ZD_CR87,  0x12 },
-                { CR88,  0x0c }, { CR89,  0x00 }, { CR90,  0x58 },
+                { ZD_CR88,  0x0c }, { ZD_CR89,  0x00 }, { ZD_CR90,  0x58 },
-                { CR91,  0x04 }, { CR92,  0x00 }, { CR93,  0x00 },
+                { ZD_CR91,  0x04 }, { ZD_CR92,  0x00 }, { ZD_CR93,  0x00 },
-                { CR94,  0x01 },
+                { ZD_CR94,  0x01 },
-                { CR95,  0x20 }, /* ZD1211B */
+                { ZD_CR95,  0x20 }, /* ZD1211B */
-                { CR96,  0x50 }, { CR97,  0x37 }, { CR98,  0x35 },
+                { ZD_CR96,  0x50 }, { ZD_CR97,  0x37 }, { ZD_CR98,  0x35 },
-                { CR99,  0x00 }, { CR100, 0x01 }, { CR101, 0x13 },
+                { ZD_CR99,  0x00 }, { ZD_CR100, 0x01 }, { ZD_CR101, 0x13 },
-                { CR102, 0x27 }, { CR103, 0x27 }, { CR104, 0x18 },
+                { ZD_CR102, 0x27 }, { ZD_CR103, 0x27 }, { ZD_CR104, 0x18 },
-                { CR105, 0x12 }, { CR106, 0x04 }, { CR107, 0x00 },
+                { ZD_CR105, 0x12 }, { ZD_CR106, 0x04 }, { ZD_CR107, 0x00 },
-                { CR108, 0x0a }, { CR109, 0x27 }, { CR110, 0x27 },
+                { ZD_CR108, 0x0a }, { ZD_CR109, 0x27 }, { ZD_CR110, 0x27 },
-                { CR111, 0x27 }, { CR112, 0x27 }, { CR113, 0x27 },
+                { ZD_CR111, 0x27 }, { ZD_CR112, 0x27 }, { ZD_CR113, 0x27 },
-                { CR114, 0x27 }, { CR115, 0x26 }, { CR116, 0x24 },
+                { ZD_CR114, 0x27 }, { ZD_CR115, 0x26 }, { ZD_CR116, 0x24 },
-                { CR117, 0xfc }, { CR118, 0xfa }, { CR119, 0x1e },
+                { ZD_CR117, 0xfc }, { ZD_CR118, 0xfa }, { ZD_CR119, 0x1e },
-                { CR125, 0x90 }, { CR126, 0x00 }, { CR127, 0x00 },
+                { ZD_CR125, 0x90 }, { ZD_CR126, 0x00 }, { ZD_CR127, 0x00 },
-                { CR128, 0x14 }, { CR129, 0x12 }, { CR130, 0x10 },
+                { ZD_CR128, 0x14 }, { ZD_CR129, 0x12 }, { ZD_CR130, 0x10 },
-                { CR131, 0x0c }, { CR136, 0xdf }, { CR137, 0xa0 },
+                { ZD_CR131, 0x0c }, { ZD_CR136, 0xdf }, { ZD_CR137, 0xa0 },
-                { CR138, 0xa8 }, { CR139, 0xb4 }, { CR140, 0x98 },
+                { ZD_CR138, 0xa8 }, { ZD_CR139, 0xb4 }, { ZD_CR140, 0x98 },
-                { CR141, 0x82 }, { CR142, 0x53 }, { CR143, 0x1c },
+                { ZD_CR141, 0x82 }, { ZD_CR142, 0x53 }, { ZD_CR143, 0x1c },
-                { CR144, 0x6c }, { CR147, 0x07 }, { CR148, 0x40 },
+                { ZD_CR144, 0x6c }, { ZD_CR147, 0x07 }, { ZD_CR148, 0x40 },
-                { CR149, 0x40 }, /* Org:0x50 ComTrend:RalLink AP */
+                { ZD_CR149, 0x40 }, /* Org:0x50 ComTrend:RalLink AP */
-                { CR150, 0x14 }, /* Org:0x0E ComTrend:RalLink AP */
+                { ZD_CR150, 0x14 }, /* Org:0x0E ComTrend:RalLink AP */
-                { CR151, 0x18 }, { CR159, 0x70 }, { CR160, 0xfe },
+                { ZD_CR151, 0x18 }, { ZD_CR159, 0x70 }, { ZD_CR160, 0xfe },
-                { CR161, 0xee }, { CR162, 0xaa }, { CR163, 0xfa },
+                { ZD_CR161, 0xee }, { ZD_CR162, 0xaa }, { ZD_CR163, 0xfa },
-                { CR164, 0xfa }, { CR165, 0xea }, { CR166, 0xbe },
+                { ZD_CR164, 0xfa }, { ZD_CR165, 0xea }, { ZD_CR166, 0xbe },
-                { CR167, 0xbe }, { CR168, 0x6a }, { CR169, 0xba },
+                { ZD_CR167, 0xbe }, { ZD_CR168, 0x6a }, { ZD_CR169, 0xba },
-                { CR170, 0xba }, { CR171, 0xba },
+                { ZD_CR170, 0xba }, { ZD_CR171, 0xba },
-                /* Note: CR204 must lead the CR203 */
+                /* Note: ZD_CR204 must lead the ZD_CR203 */
-                { CR204, 0x7d },
+                { ZD_CR204, 0x7d },
                {},
-                { CR203, 0x30 },
+                { ZD_CR203, 0x30 },
        };
        int r, t;
@@ -1200,24 +1200,24 @@ out:
 static int update_pwr_int(struct zd_chip *chip, u8 channel)
 {
        u8 value = chip->pwr_int_values[channel - 1];
-        return zd_iowrite16_locked(chip, value, CR31);
+        return zd_iowrite16_locked(chip, value, ZD_CR31);
 }
 static int update_pwr_cal(struct zd_chip *chip, u8 channel)
 {
        u8 value = chip->pwr_cal_values[channel-1];
-        return zd_iowrite16_locked(chip, value, CR68);
+        return zd_iowrite16_locked(chip, value, ZD_CR68);
 }
 static int update_ofdm_cal(struct zd_chip *chip, u8 channel)
 {
        struct zd_ioreq16 ioreqs[3];
-        ioreqs[0].addr = CR67;
+        ioreqs[0].addr = ZD_CR67;
        ioreqs[0].value = chip->ofdm_cal_values[OFDM_36M_INDEX][channel-1];
-        ioreqs[1].addr = CR66;
+        ioreqs[1].addr = ZD_CR66;
        ioreqs[1].value = chip->ofdm_cal_values[OFDM_48M_INDEX][channel-1];
-        ioreqs[2].addr = CR65;
+        ioreqs[2].addr = ZD_CR65;
        ioreqs[2].value = chip->ofdm_cal_values[OFDM_54M_INDEX][channel-1];
        return zd_iowrite16a_locked(chip, ioreqs, ARRAY_SIZE(ioreqs));
@@ -1236,9 +1236,9 @@ static int update_channel_integration_and_calibration(struct zd_chip *chip,
                return r;
        if (zd_chip_is_zd1211b(chip)) {
                static const struct zd_ioreq16 ioreqs[] = {
-                        { CR69, 0x28 },
+                        { ZD_CR69, 0x28 },
                        {},
-                        { CR69, 0x2a },
+                        { ZD_CR69, 0x2a },
                };
                r = update_ofdm_cal(chip, channel);
@@ -1269,7 +1269,7 @@ static int patch_cck_gain(struct zd_chip *chip)
        if (r)
                return r;
        dev_dbg_f(zd_chip_dev(chip), "patching value %x\n", value & 0xff);
-        return zd_iowrite16_locked(chip, value & 0xff, CR47);
+        return zd_iowrite16_locked(chip, value & 0xff, ZD_CR47);
 }
 int zd_chip_set_channel(struct zd_chip *chip, u8 channel)
@@ -1505,9 +1505,9 @@ int zd_rfwritev_locked(struct zd_chip *chip,
 int zd_rfwrite_cr_locked(struct zd_chip *chip, u32 value)
 {
        const struct zd_ioreq16 ioreqs[] = {
-                { CR244, (value >> 16) & 0xff },
+                { ZD_CR244, (value >> 16) & 0xff },
-                { CR243, (value >>  8) & 0xff },
+                { ZD_CR243, (value >>  8) & 0xff },
-                { CR242,  value        & 0xff },
+                { ZD_CR242,  value        & 0xff },
        };
        ZD_ASSERT(mutex_is_locked(&chip->mutex));
        return zd_iowrite16a_locked(chip, ioreqs, ARRAY_SIZE(ioreqs));
diff --git a/drivers/net/wireless/zd1211rw/zd_chip.h b/drivers/net/wireless/zd1211rw/zd_chip.h
index 14e4402a6111..4be7c3b5b265 100644
--- a/drivers/net/wireless/zd1211rw/zd_chip.h
+++ b/drivers/net/wireless/zd1211rw/zd_chip.h
@@ -61,277 +61,288 @@ enum {
 #define FWRAW_DATA(offset) ((zd_addr_t)(FW_START + (offset)))
 /* 8-bit hardware registers */
-#define CR0   CTL_REG(0x0000)
+#define ZD_CR0   CTL_REG(0x0000)
-#define CR1   CTL_REG(0x0004)
+#define ZD_CR1   CTL_REG(0x0004)
-#define CR2   CTL_REG(0x0008)
+#define ZD_CR2   CTL_REG(0x0008)
-#define CR3   CTL_REG(0x000C)
+#define ZD_CR3   CTL_REG(0x000C)
-#define CR5   CTL_REG(0x0010)
+#define ZD_CR5   CTL_REG(0x0010)
 /*      bit 5: if set short preamble used
 *      bit 6: filter band - Japan channel 14 on, else off
 */
-#define CR6   CTL_REG(0x0014)
+#define ZD_CR6   CTL_REG(0x0014)
-#define CR7   CTL_REG(0x0018)
+#define ZD_CR7   CTL_REG(0x0018)
-#define CR8   CTL_REG(0x001C)
+#define ZD_CR8   CTL_REG(0x001C)
-#define CR4   CTL_REG(0x0020)
+#define ZD_CR4   CTL_REG(0x0020)
-#define CR9   CTL_REG(0x0024)
+#define ZD_CR9   CTL_REG(0x0024)
-/*      bit 2: antenna switch (together with CR10) */
+/*      bit 2: antenna switch (together with ZD_CR10) */
-#define CR10  CTL_REG(0x0028)
+#define ZD_CR10  CTL_REG(0x0028)
-/*      bit 1: antenna switch (together with CR9)
+/*      bit 1: antenna switch (together with ZD_CR9)
- *      RF2959 controls with CR11 radion on and off
+ *      RF2959 controls with ZD_CR11 radion on and off
 */
-#define CR11  CTL_REG(0x002C)
+#define ZD_CR11  CTL_REG(0x002C)
 /*      bit 6:  TX power control for OFDM
- *      RF2959 controls with CR10 radio on and off
+ *      RF2959 controls with ZD_CR10 radio on and off
 */
-#define CR12  CTL_REG(0x0030)
+#define ZD_CR12  CTL_REG(0x0030)
-#define CR13  CTL_REG(0x0034)
+#define ZD_CR13  CTL_REG(0x0034)
-#define CR14  CTL_REG(0x0038)
+#define ZD_CR14  CTL_REG(0x0038)
-#define CR15  CTL_REG(0x003C)
+#define ZD_CR15  CTL_REG(0x003C)
-#define CR16  CTL_REG(0x0040)
+#define ZD_CR16  CTL_REG(0x0040)
-#define CR17  CTL_REG(0x0044)
+#define ZD_CR17  CTL_REG(0x0044)
-#define CR18  CTL_REG(0x0048)
+#define ZD_CR18  CTL_REG(0x0048)
-#define CR19  CTL_REG(0x004C)
+#define ZD_CR19  CTL_REG(0x004C)
-#define CR20  CTL_REG(0x0050)
+#define ZD_CR20  CTL_REG(0x0050)
-#define CR21  CTL_REG(0x0054)
+#define ZD_CR21  CTL_REG(0x0054)
-#define CR22  CTL_REG(0x0058)
+#define ZD_CR22  CTL_REG(0x0058)
-#define CR23  CTL_REG(0x005C)
+#define ZD_CR23  CTL_REG(0x005C)
-#define CR24  CTL_REG(0x0060)   /* CCA threshold */
+#define ZD_CR24  CTL_REG(0x0060)        /* CCA threshold */
-#define CR25  CTL_REG(0x0064)
+#define ZD_CR25  CTL_REG(0x0064)
-#define CR26  CTL_REG(0x0068)
+#define ZD_CR26  CTL_REG(0x0068)
-#define CR27  CTL_REG(0x006C)
+#define ZD_CR27  CTL_REG(0x006C)
-#define CR28  CTL_REG(0x0070)
+#define ZD_CR28  CTL_REG(0x0070)
-#define CR29  CTL_REG(0x0074)
+#define ZD_CR29  CTL_REG(0x0074)
-#define CR30  CTL_REG(0x0078)
+#define ZD_CR30  CTL_REG(0x0078)
-#define CR31  CTL_REG(0x007C)   /* TX power control for RF in CCK mode */
+#define ZD_CR31  CTL_REG(0x007C)        /* TX power control for RF in
-#define CR32  CTL_REG(0x0080)
+                                         * CCK mode
-#define CR33  CTL_REG(0x0084)
+                                         */
-#define CR34  CTL_REG(0x0088)
+#define ZD_CR32  CTL_REG(0x0080)
-#define CR35  CTL_REG(0x008C)
+#define ZD_CR33  CTL_REG(0x0084)
-#define CR36  CTL_REG(0x0090)
+#define ZD_CR34  CTL_REG(0x0088)
-#define CR37  CTL_REG(0x0094)
+#define ZD_CR35  CTL_REG(0x008C)
-#define CR38  CTL_REG(0x0098)
+#define ZD_CR36  CTL_REG(0x0090)
-#define CR39  CTL_REG(0x009C)
+#define ZD_CR37  CTL_REG(0x0094)
-#define CR40  CTL_REG(0x00A0)
+#define ZD_CR38  CTL_REG(0x0098)
-#define CR41  CTL_REG(0x00A4)
+#define ZD_CR39  CTL_REG(0x009C)
-#define CR42  CTL_REG(0x00A8)
+#define ZD_CR40  CTL_REG(0x00A0)
-#define CR43  CTL_REG(0x00AC)
+#define ZD_CR41  CTL_REG(0x00A4)
-#define CR44  CTL_REG(0x00B0)
+#define ZD_CR42  CTL_REG(0x00A8)
-#define CR45  CTL_REG(0x00B4)
+#define ZD_CR43  CTL_REG(0x00AC)
-#define CR46  CTL_REG(0x00B8)
+#define ZD_CR44  CTL_REG(0x00B0)
-#define CR47  CTL_REG(0x00BC)   /* CCK baseband gain
+#define ZD_CR45  CTL_REG(0x00B4)
-                                 * (patch value might be in EEPROM)
+#define ZD_CR46  CTL_REG(0x00B8)
-                                 */
+#define ZD_CR47  CTL_REG(0x00BC)        /* CCK baseband gain
-#define CR48  CTL_REG(0x00C0)
+                                         * (patch value might be in EEPROM)
-#define CR49  CTL_REG(0x00C4)
+                                         */
-#define CR50  CTL_REG(0x00C8)
+#define ZD_CR48  CTL_REG(0x00C0)
-#define CR51  CTL_REG(0x00CC)   /* TX power control for RF in 6-36M modes */
+#define ZD_CR49  CTL_REG(0x00C4)
-#define CR52  CTL_REG(0x00D0)   /* TX power control for RF in 48M mode */
+#define ZD_CR50  CTL_REG(0x00C8)
-#define CR53  CTL_REG(0x00D4)   /* TX power control for RF in 54M mode */
+#define ZD_CR51  CTL_REG(0x00CC)        /* TX power control for RF in
-#define CR54  CTL_REG(0x00D8)
+                                         * 6-36M modes
-#define CR55  CTL_REG(0x00DC)
+                                         */
-#define CR56  CTL_REG(0x00E0)
+#define ZD_CR52  CTL_REG(0x00D0)        /* TX power control for RF in
-#define CR57  CTL_REG(0x00E4)
+                                         * 48M mode
-#define CR58  CTL_REG(0x00E8)
+                                         */
-#define CR59  CTL_REG(0x00EC)
+#define ZD_CR53  CTL_REG(0x00D4)        /* TX power control for RF in
-#define CR60  CTL_REG(0x00F0)
+                                         * 54M mode
-#define CR61  CTL_REG(0x00F4)
+                                         */
-#define CR62  CTL_REG(0x00F8)
+#define ZD_CR54  CTL_REG(0x00D8)
-#define CR63  CTL_REG(0x00FC)
+#define ZD_CR55  CTL_REG(0x00DC)
-#define CR64  CTL_REG(0x0100)
+#define ZD_CR56  CTL_REG(0x00E0)
-#define CR65  CTL_REG(0x0104) /* OFDM 54M calibration */
+#define ZD_CR57  CTL_REG(0x00E4)
-#define CR66  CTL_REG(0x0108) /* OFDM 48M calibration */
+#define ZD_CR58  CTL_REG(0x00E8)
-#define CR67  CTL_REG(0x010C) /* OFDM 36M calibration */
+#define ZD_CR59  CTL_REG(0x00EC)
-#define CR68  CTL_REG(0x0110) /* CCK calibration */
+#define ZD_CR60  CTL_REG(0x00F0)
-#define CR69  CTL_REG(0x0114)
+#define ZD_CR61  CTL_REG(0x00F4)
-#define CR70  CTL_REG(0x0118)
+#define ZD_CR62  CTL_REG(0x00F8)
-#define CR71  CTL_REG(0x011C)
+#define ZD_CR63  CTL_REG(0x00FC)
-#define CR72  CTL_REG(0x0120)
+#define ZD_CR64  CTL_REG(0x0100)
-#define CR73  CTL_REG(0x0124)
+#define ZD_CR65  CTL_REG(0x0104) /* OFDM 54M calibration */
-#define CR74  CTL_REG(0x0128)
+#define ZD_CR66  CTL_REG(0x0108) /* OFDM 48M calibration */
-#define CR75  CTL_REG(0x012C)
+#define ZD_CR67  CTL_REG(0x010C) /* OFDM 36M calibration */
-#define CR76  CTL_REG(0x0130)
+#define ZD_CR68  CTL_REG(0x0110) /* CCK calibration */
-#define CR77  CTL_REG(0x0134)
+#define ZD_CR69  CTL_REG(0x0114)
-#define CR78  CTL_REG(0x0138)
+#define ZD_CR70  CTL_REG(0x0118)
-#define CR79  CTL_REG(0x013C)
+#define ZD_CR71  CTL_REG(0x011C)
-#define CR80  CTL_REG(0x0140)
+#define ZD_CR72  CTL_REG(0x0120)
-#define CR81  CTL_REG(0x0144)
+#define ZD_CR73  CTL_REG(0x0124)
-#define CR82  CTL_REG(0x0148)
+#define ZD_CR74  CTL_REG(0x0128)
-#define CR83  CTL_REG(0x014C)
+#define ZD_CR75  CTL_REG(0x012C)
-#define CR84  CTL_REG(0x0150)
+#define ZD_CR76  CTL_REG(0x0130)
-#define CR85  CTL_REG(0x0154)
+#define ZD_CR77  CTL_REG(0x0134)
-#define CR86  CTL_REG(0x0158)
+#define ZD_CR78  CTL_REG(0x0138)
-#define CR87  CTL_REG(0x015C)
+#define ZD_CR79  CTL_REG(0x013C)
-#define CR88  CTL_REG(0x0160)
+#define ZD_CR80  CTL_REG(0x0140)
-#define CR89  CTL_REG(0x0164)
+#define ZD_CR81  CTL_REG(0x0144)
-#define CR90  CTL_REG(0x0168)
+#define ZD_CR82  CTL_REG(0x0148)
-#define CR91  CTL_REG(0x016C)
+#define ZD_CR83  CTL_REG(0x014C)
-#define CR92  CTL_REG(0x0170)
+#define ZD_CR84  CTL_REG(0x0150)
-#define CR93  CTL_REG(0x0174)
+#define ZD_CR85  CTL_REG(0x0154)
-#define CR94  CTL_REG(0x0178)
+#define ZD_CR86  CTL_REG(0x0158)
-#define CR95  CTL_REG(0x017C)
+#define ZD_CR87  CTL_REG(0x015C)
-#define CR96  CTL_REG(0x0180)
+#define ZD_CR88  CTL_REG(0x0160)
-#define CR97  CTL_REG(0x0184)
+#define ZD_CR89  CTL_REG(0x0164)
-#define CR98  CTL_REG(0x0188)
+#define ZD_CR90  CTL_REG(0x0168)
-#define CR99  CTL_REG(0x018C)
+#define ZD_CR91  CTL_REG(0x016C)
-#define CR100 CTL_REG(0x0190)
+#define ZD_CR92  CTL_REG(0x0170)
-#define CR101 CTL_REG(0x0194)
+#define ZD_CR93  CTL_REG(0x0174)
-#define CR102 CTL_REG(0x0198)
+#define ZD_CR94  CTL_REG(0x0178)
-#define CR103 CTL_REG(0x019C)
+#define ZD_CR95  CTL_REG(0x017C)
-#define CR104 CTL_REG(0x01A0)
+#define ZD_CR96  CTL_REG(0x0180)
-#define CR105 CTL_REG(0x01A4)
+#define ZD_CR97  CTL_REG(0x0184)
-#define CR106 CTL_REG(0x01A8)
+#define ZD_CR98  CTL_REG(0x0188)
-#define CR107 CTL_REG(0x01AC)
+#define ZD_CR99  CTL_REG(0x018C)
-#define CR108 CTL_REG(0x01B0)
+#define ZD_CR100 CTL_REG(0x0190)
-#define CR109 CTL_REG(0x01B4)
+#define ZD_CR101 CTL_REG(0x0194)
-#define CR110 CTL_REG(0x01B8)
+#define ZD_CR102 CTL_REG(0x0198)
-#define CR111 CTL_REG(0x01BC)
+#define ZD_CR103 CTL_REG(0x019C)
-#define CR112 CTL_REG(0x01C0)
+#define ZD_CR104 CTL_REG(0x01A0)
-#define CR113 CTL_REG(0x01C4)
+#define ZD_CR105 CTL_REG(0x01A4)
-#define CR114 CTL_REG(0x01C8)
+#define ZD_CR106 CTL_REG(0x01A8)
-#define CR115 CTL_REG(0x01CC)
+#define ZD_CR107 CTL_REG(0x01AC)
-#define CR116 CTL_REG(0x01D0)
+#define ZD_CR108 CTL_REG(0x01B0)
-#define CR117 CTL_REG(0x01D4)
+#define ZD_CR109 CTL_REG(0x01B4)
-#define CR118 CTL_REG(0x01D8)
+#define ZD_CR110 CTL_REG(0x01B8)
-#define CR119 CTL_REG(0x01DC)
+#define ZD_CR111 CTL_REG(0x01BC)
-#define CR120 CTL_REG(0x01E0)
+#define ZD_CR112 CTL_REG(0x01C0)
-#define CR121 CTL_REG(0x01E4)
+#define ZD_CR113 CTL_REG(0x01C4)
-#define CR122 CTL_REG(0x01E8)
+#define ZD_CR114 CTL_REG(0x01C8)
-#define CR123 CTL_REG(0x01EC)
+#define ZD_CR115 CTL_REG(0x01CC)
-#define CR124 CTL_REG(0x01F0)
+#define ZD_CR116 CTL_REG(0x01D0)
-#define CR125 CTL_REG(0x01F4)
+#define ZD_CR117 CTL_REG(0x01D4)
-#define CR126 CTL_REG(0x01F8)
+#define ZD_CR118 CTL_REG(0x01D8)
-#define CR127 CTL_REG(0x01FC)
+#define ZD_CR119 CTL_REG(0x01DC)
-#define CR128 CTL_REG(0x0200)
+#define ZD_CR120 CTL_REG(0x01E0)
-#define CR129 CTL_REG(0x0204)
+#define ZD_CR121 CTL_REG(0x01E4)
-#define CR130 CTL_REG(0x0208)
+#define ZD_CR122 CTL_REG(0x01E8)
-#define CR131 CTL_REG(0x020C)
+#define ZD_CR123 CTL_REG(0x01EC)
-#define CR132 CTL_REG(0x0210)
+#define ZD_CR124 CTL_REG(0x01F0)
-#define CR133 CTL_REG(0x0214)
+#define ZD_CR125 CTL_REG(0x01F4)
-#define CR134 CTL_REG(0x0218)
+#define ZD_CR126 CTL_REG(0x01F8)
-#define CR135 CTL_REG(0x021C)
+#define ZD_CR127 CTL_REG(0x01FC)
-#define CR136 CTL_REG(0x0220)
+#define ZD_CR128 CTL_REG(0x0200)
-#define CR137 CTL_REG(0x0224)
+#define ZD_CR129 CTL_REG(0x0204)
-#define CR138 CTL_REG(0x0228)
+#define ZD_CR130 CTL_REG(0x0208)
-#define CR139 CTL_REG(0x022C)
+#define ZD_CR131 CTL_REG(0x020C)
-#define CR140 CTL_REG(0x0230)
+#define ZD_CR132 CTL_REG(0x0210)
-#define CR141 CTL_REG(0x0234)
+#define ZD_CR133 CTL_REG(0x0214)
-#define CR142 CTL_REG(0x0238)
+#define ZD_CR134 CTL_REG(0x0218)
-#define CR143 CTL_REG(0x023C)
+#define ZD_CR135 CTL_REG(0x021C)
-#define CR144 CTL_REG(0x0240)
+#define ZD_CR136 CTL_REG(0x0220)
-#define CR145 CTL_REG(0x0244)
+#define ZD_CR137 CTL_REG(0x0224)
-#define CR146 CTL_REG(0x0248)
+#define ZD_CR138 CTL_REG(0x0228)
-#define CR147 CTL_REG(0x024C)
+#define ZD_CR139 CTL_REG(0x022C)
-#define CR148 CTL_REG(0x0250)
+#define ZD_CR140 CTL_REG(0x0230)
-#define CR149 CTL_REG(0x0254)
+#define ZD_CR141 CTL_REG(0x0234)
-#define CR150 CTL_REG(0x0258)
+#define ZD_CR142 CTL_REG(0x0238)
-#define CR151 CTL_REG(0x025C)
+#define ZD_CR143 CTL_REG(0x023C)
-#define CR152 CTL_REG(0x0260)
+#define ZD_CR144 CTL_REG(0x0240)
-#define CR153 CTL_REG(0x0264)
+#define ZD_CR145 CTL_REG(0x0244)
-#define CR154 CTL_REG(0x0268)
+#define ZD_CR146 CTL_REG(0x0248)
-#define CR155 CTL_REG(0x026C)
+#define ZD_CR147 CTL_REG(0x024C)
-#define CR156 CTL_REG(0x0270)
+#define ZD_CR148 CTL_REG(0x0250)
-#define CR157 CTL_REG(0x0274)
+#define ZD_CR149 CTL_REG(0x0254)
-#define CR158 CTL_REG(0x0278)
+#define ZD_CR150 CTL_REG(0x0258)
-#define CR159 CTL_REG(0x027C)
+#define ZD_CR151 CTL_REG(0x025C)
-#define CR160 CTL_REG(0x0280)
+#define ZD_CR152 CTL_REG(0x0260)
-#define CR161 CTL_REG(0x0284)
+#define ZD_CR153 CTL_REG(0x0264)
-#define CR162 CTL_REG(0x0288)
+#define ZD_CR154 CTL_REG(0x0268)
-#define CR163 CTL_REG(0x028C)
+#define ZD_CR155 CTL_REG(0x026C)
-#define CR164 CTL_REG(0x0290)
+#define ZD_CR156 CTL_REG(0x0270)
-#define CR165 CTL_REG(0x0294)
+#define ZD_CR157 CTL_REG(0x0274)
-#define CR166 CTL_REG(0x0298)
+#define ZD_CR158 CTL_REG(0x0278)
-#define CR167 CTL_REG(0x029C)
+#define ZD_CR159 CTL_REG(0x027C)
-#define CR168 CTL_REG(0x02A0)
+#define ZD_CR160 CTL_REG(0x0280)
-#define CR169 CTL_REG(0x02A4)
+#define ZD_CR161 CTL_REG(0x0284)
-#define CR170 CTL_REG(0x02A8)
+#define ZD_CR162 CTL_REG(0x0288)
-#define CR171 CTL_REG(0x02AC)
+#define ZD_CR163 CTL_REG(0x028C)
-#define CR172 CTL_REG(0x02B0)
+#define ZD_CR164 CTL_REG(0x0290)
-#define CR173 CTL_REG(0x02B4)
+#define ZD_CR165 CTL_REG(0x0294)
-#define CR174 CTL_REG(0x02B8)
+#define ZD_CR166 CTL_REG(0x0298)
-#define CR175 CTL_REG(0x02BC)
+#define ZD_CR167 CTL_REG(0x029C)
-#define CR176 CTL_REG(0x02C0)
+#define ZD_CR168 CTL_REG(0x02A0)
-#define CR177 CTL_REG(0x02C4)
+#define ZD_CR169 CTL_REG(0x02A4)
-#define CR178 CTL_REG(0x02C8)
+#define ZD_CR170 CTL_REG(0x02A8)
-#define CR179 CTL_REG(0x02CC)
+#define ZD_CR171 CTL_REG(0x02AC)
-#define CR180 CTL_REG(0x02D0)
+#define ZD_CR172 CTL_REG(0x02B0)
-#define CR181 CTL_REG(0x02D4)
+#define ZD_CR173 CTL_REG(0x02B4)
-#define CR182 CTL_REG(0x02D8)
+#define ZD_CR174 CTL_REG(0x02B8)
-#define CR183 CTL_REG(0x02DC)
+#define ZD_CR175 CTL_REG(0x02BC)
-#define CR184 CTL_REG(0x02E0)
+#define ZD_CR176 CTL_REG(0x02C0)
-#define CR185 CTL_REG(0x02E4)
+#define ZD_CR177 CTL_REG(0x02C4)
-#define CR186 CTL_REG(0x02E8)
+#define ZD_CR178 CTL_REG(0x02C8)
-#define CR187 CTL_REG(0x02EC)
+#define ZD_CR179 CTL_REG(0x02CC)
-#define CR188 CTL_REG(0x02F0)
+#define ZD_CR180 CTL_REG(0x02D0)
-#define CR189 CTL_REG(0x02F4)
+#define ZD_CR181 CTL_REG(0x02D4)
-#define CR190 CTL_REG(0x02F8)
+#define ZD_CR182 CTL_REG(0x02D8)
-#define CR191 CTL_REG(0x02FC)
+#define ZD_CR183 CTL_REG(0x02DC)
-#define CR192 CTL_REG(0x0300)
+#define ZD_CR184 CTL_REG(0x02E0)
-#define CR193 CTL_REG(0x0304)
+#define ZD_CR185 CTL_REG(0x02E4)
-#define CR194 CTL_REG(0x0308)
+#define ZD_CR186 CTL_REG(0x02E8)
-#define CR195 CTL_REG(0x030C)
+#define ZD_CR187 CTL_REG(0x02EC)
-#define CR196 CTL_REG(0x0310)
+#define ZD_CR188 CTL_REG(0x02F0)
-#define CR197 CTL_REG(0x0314)
+#define ZD_CR189 CTL_REG(0x02F4)
-#define CR198 CTL_REG(0x0318)
+#define ZD_CR190 CTL_REG(0x02F8)
-#define CR199 CTL_REG(0x031C)
+#define ZD_CR191 CTL_REG(0x02FC)
-#define CR200 CTL_REG(0x0320)
+#define ZD_CR192 CTL_REG(0x0300)
-#define CR201 CTL_REG(0x0324)
+#define ZD_CR193 CTL_REG(0x0304)
-#define CR202 CTL_REG(0x0328)
+#define ZD_CR194 CTL_REG(0x0308)
-#define CR203 CTL_REG(0x032C)   /* I2C bus template value & flash control */
+#define ZD_CR195 CTL_REG(0x030C)
-#define CR204 CTL_REG(0x0330)
+#define ZD_CR196 CTL_REG(0x0310)
-#define CR205 CTL_REG(0x0334)
+#define ZD_CR197 CTL_REG(0x0314)
-#define CR206 CTL_REG(0x0338)
+#define ZD_CR198 CTL_REG(0x0318)
-#define CR207 CTL_REG(0x033C)
+#define ZD_CR199 CTL_REG(0x031C)
-#define CR208 CTL_REG(0x0340)
+#define ZD_CR200 CTL_REG(0x0320)
-#define CR209 CTL_REG(0x0344)
+#define ZD_CR201 CTL_REG(0x0324)
-#define CR210 CTL_REG(0x0348)
+#define ZD_CR202 CTL_REG(0x0328)
-#define CR211 CTL_REG(0x034C)
+#define ZD_CR203 CTL_REG(0x032C)        /* I2C bus template value & flash
-#define CR212 CTL_REG(0x0350)
+                                         * control
-#define CR213 CTL_REG(0x0354)
+                                         */
-#define CR214 CTL_REG(0x0358)
+#define ZD_CR204 CTL_REG(0x0330)
-#define CR215 CTL_REG(0x035C)
+#define ZD_CR205 CTL_REG(0x0334)
-#define CR216 CTL_REG(0x0360)
+#define ZD_CR206 CTL_REG(0x0338)
-#define CR217 CTL_REG(0x0364)
+#define ZD_CR207 CTL_REG(0x033C)
-#define CR218 CTL_REG(0x0368)
+#define ZD_CR208 CTL_REG(0x0340)
-#define CR219 CTL_REG(0x036C)
+#define ZD_CR209 CTL_REG(0x0344)
-#define CR220 CTL_REG(0x0370)
+#define ZD_CR210 CTL_REG(0x0348)
-#define CR221 CTL_REG(0x0374)
+#define ZD_CR211 CTL_REG(0x034C)
-#define CR222 CTL_REG(0x0378)
+#define ZD_CR212 CTL_REG(0x0350)
-#define CR223 CTL_REG(0x037C)
+#define ZD_CR213 CTL_REG(0x0354)
-#define CR224 CTL_REG(0x0380)
+#define ZD_CR214 CTL_REG(0x0358)
-#define CR225 CTL_REG(0x0384)
+#define ZD_CR215 CTL_REG(0x035C)
-#define CR226 CTL_REG(0x0388)
+#define ZD_CR216 CTL_REG(0x0360)
-#define CR227 CTL_REG(0x038C)
+#define ZD_CR217 CTL_REG(0x0364)
-#define CR228 CTL_REG(0x0390)
+#define ZD_CR218 CTL_REG(0x0368)
-#define CR229 CTL_REG(0x0394)
+#define ZD_CR219 CTL_REG(0x036C)
-#define CR230 CTL_REG(0x0398)
+#define ZD_CR220 CTL_REG(0x0370)
-#define CR231 CTL_REG(0x039C)
+#define ZD_CR221 CTL_REG(0x0374)
-#define CR232 CTL_REG(0x03A0)
+#define ZD_CR222 CTL_REG(0x0378)
-#define CR233 CTL_REG(0x03A4)
+#define ZD_CR223 CTL_REG(0x037C)
-#define CR234 CTL_REG(0x03A8)
+#define ZD_CR224 CTL_REG(0x0380)
-#define CR235 CTL_REG(0x03AC)
+#define ZD_CR225 CTL_REG(0x0384)
-#define CR236 CTL_REG(0x03B0)
+#define ZD_CR226 CTL_REG(0x0388)
+#define ZD_CR227 CTL_REG(0x038C)
-#define CR240 CTL_REG(0x03C0)
+#define ZD_CR228 CTL_REG(0x0390)
-/*      bit 7:  host-controlled RF register writes
+#define ZD_CR229 CTL_REG(0x0394)
- * CR241-CR245: for hardware controlled writing of RF bits, not needed for
+#define ZD_CR230 CTL_REG(0x0398)
- *              USB
+#define ZD_CR231 CTL_REG(0x039C)
+#define ZD_CR232 CTL_REG(0x03A0)
+#define ZD_CR233 CTL_REG(0x03A4)
+#define ZD_CR234 CTL_REG(0x03A8)
+#define ZD_CR235 CTL_REG(0x03AC)
+#define ZD_CR236 CTL_REG(0x03B0)
+#define ZD_CR240 CTL_REG(0x03C0)
+/*             bit 7: host-controlled RF register writes
+ * ZD_CR241-ZD_CR245: for hardware controlled writing of RF bits, not needed for
+ *                    USB
 */
-#define CR241 CTL_REG(0x03C4)
+#define ZD_CR241 CTL_REG(0x03C4)
-#define CR242 CTL_REG(0x03C8)
+#define ZD_CR242 CTL_REG(0x03C8)
-#define CR243 CTL_REG(0x03CC)
+#define ZD_CR243 CTL_REG(0x03CC)
-#define CR244 CTL_REG(0x03D0)
+#define ZD_CR244 CTL_REG(0x03D0)
-#define CR245 CTL_REG(0x03D4)
+#define ZD_CR245 CTL_REG(0x03D4)
-#define CR251 CTL_REG(0x03EC)   /* only used for activation and deactivation of
+#define ZD_CR251 CTL_REG(0x03EC)        /* only used for activation and
-                                 * Airoha RFs AL2230 and AL7230B
+                                         * deactivation of Airoha RFs AL2230
-                                 */
+                                         * and AL7230B
-#define CR252 CTL_REG(0x03F0)
+                                         */
-#define CR253 CTL_REG(0x03F4)
+#define ZD_CR252 CTL_REG(0x03F0)
-#define CR254 CTL_REG(0x03F8)
+#define ZD_CR253 CTL_REG(0x03F4)
-#define CR255 CTL_REG(0x03FC)
+#define ZD_CR254 CTL_REG(0x03F8)
+#define ZD_CR255 CTL_REG(0x03FC)
 #define CR_MAX_PHY_REG 255
diff --git a/drivers/net/wireless/zd1211rw/zd_rf.h b/drivers/net/wireless/zd1211rw/zd_rf.h
index 79dc1035592d..725b7c99b23d 100644
--- a/drivers/net/wireless/zd1211rw/zd_rf.h
+++ b/drivers/net/wireless/zd1211rw/zd_rf.h
@@ -55,7 +55,7 @@ struct zd_rf {
         * defaults to 1 (yes) */
        u8 update_channel_int:1;
-        /* whether CR47 should be patched from the EEPROM, if the appropriate
+        /* whether ZD_CR47 should be patched from the EEPROM, if the appropriate
         * flag is set in the POD. The vendor driver suggests that this should
         * be done for all RF's, but a bug in their code prevents but their
         * HW_OverWritePhyRegFromE2P() routine from ever taking effect. */
diff --git a/drivers/net/wireless/zd1211rw/zd_rf_al2230.c b/drivers/net/wireless/zd1211rw/zd_rf_al2230.c
index 74a8f7a55591..12babcb633c3 100644
--- a/drivers/net/wireless/zd1211rw/zd_rf_al2230.c
+++ b/drivers/net/wireless/zd1211rw/zd_rf_al2230.c
@@ -61,31 +61,31 @@ static const u32 zd1211b_al2230_table[][3] = {
 };
 static const struct zd_ioreq16 zd1211b_ioreqs_shared_1[] = {
-        { CR240, 0x57 }, { CR9,   0xe0 },
+        { ZD_CR240, 0x57 }, { ZD_CR9,   0xe0 },
 };
 static const struct zd_ioreq16 ioreqs_init_al2230s[] = {
-        { CR47,   0x1e }, /* MARK_002 */
+        { ZD_CR47,   0x1e }, /* MARK_002 */
-        { CR106,  0x22 },
+        { ZD_CR106,  0x22 },
-        { CR107,  0x2a }, /* MARK_002 */
+        { ZD_CR107,  0x2a }, /* MARK_002 */
-        { CR109,  0x13 }, /* MARK_002 */
+        { ZD_CR109,  0x13 }, /* MARK_002 */
-        { CR118,  0xf8 }, /* MARK_002 */
+        { ZD_CR118,  0xf8 }, /* MARK_002 */
-        { CR119,  0x12 }, { CR122,  0xe0 },
+        { ZD_CR119,  0x12 }, { ZD_CR122,  0xe0 },
-        { CR128,  0x10 }, /* MARK_001 from 0xe->0x10 */
+        { ZD_CR128,  0x10 }, /* MARK_001 from 0xe->0x10 */
-        { CR129,  0x0e }, /* MARK_001 from 0xd->0x0e */
+        { ZD_CR129,  0x0e }, /* MARK_001 from 0xd->0x0e */
-        { CR130,  0x10 }, /* MARK_001 from 0xb->0x0d */
+        { ZD_CR130,  0x10 }, /* MARK_001 from 0xb->0x0d */
 };
 static int zd1211b_al2230_finalize_rf(struct zd_chip *chip)
 {
        int r;
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR80,  0x30 }, { CR81,  0x30 }, { CR79,  0x58 },
+                { ZD_CR80,  0x30 }, { ZD_CR81,  0x30 }, { ZD_CR79,  0x58 },
-                { CR12,  0xf0 }, { CR77,  0x1b }, { CR78,  0x58 },
+                { ZD_CR12,  0xf0 }, { ZD_CR77,  0x1b }, { ZD_CR78,  0x58 },
-                { CR203, 0x06 },
+                { ZD_CR203, 0x06 },
                { },
-                { CR240, 0x80 },
+                { ZD_CR240, 0x80 },
        };
        r = zd_iowrite16a_locked(chip, ioreqs, ARRAY_SIZE(ioreqs));
@@ -94,12 +94,12 @@ static int zd1211b_al2230_finalize_rf(struct zd_chip *chip)
        /* related to antenna selection? */
        if (chip->new_phy_layout) {
-                r = zd_iowrite16_locked(chip, 0xe1, CR9);
+                r = zd_iowrite16_locked(chip, 0xe1, ZD_CR9);
                if (r)
                        return r;
        }
-        return zd_iowrite16_locked(chip, 0x06, CR203);
+        return zd_iowrite16_locked(chip, 0x06, ZD_CR203);
 }
 static int zd1211_al2230_init_hw(struct zd_rf *rf)
@@ -108,40 +108,40 @@ static int zd1211_al2230_init_hw(struct zd_rf *rf)
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs_init[] = {
-                { CR15,   0x20 }, { CR23,   0x40 }, { CR24,  0x20 },
+                { ZD_CR15,   0x20 }, { ZD_CR23,   0x40 }, { ZD_CR24,  0x20 },
-                { CR26,   0x11 }, { CR28,   0x3e }, { CR29,  0x00 },
+                { ZD_CR26,   0x11 }, { ZD_CR28,   0x3e }, { ZD_CR29,  0x00 },
-                { CR44,   0x33 }, { CR106,  0x2a }, { CR107, 0x1a },
+                { ZD_CR44,   0x33 }, { ZD_CR106,  0x2a }, { ZD_CR107, 0x1a },
-                { CR109,  0x09 }, { CR110,  0x27 }, { CR111, 0x2b },
+                { ZD_CR109,  0x09 }, { ZD_CR110,  0x27 }, { ZD_CR111, 0x2b },
-                { CR112,  0x2b }, { CR119,  0x0a }, { CR10,  0x89 },
+                { ZD_CR112,  0x2b }, { ZD_CR119,  0x0a }, { ZD_CR10,  0x89 },
                /* for newest (3rd cut) AL2300 */
-                { CR17,   0x28 },
+                { ZD_CR17,   0x28 },
-                { CR26,   0x93 }, { CR34,   0x30 },
+                { ZD_CR26,   0x93 }, { ZD_CR34,   0x30 },
                /* for newest (3rd cut) AL2300 */
-                { CR35,   0x3e },
+                { ZD_CR35,   0x3e },
-                { CR41,   0x24 }, { CR44,   0x32 },
+                { ZD_CR41,   0x24 }, { ZD_CR44,   0x32 },
                /* for newest (3rd cut) AL2300 */
-                { CR46,   0x96 },
+                { ZD_CR46,   0x96 },
-                { CR47,   0x1e }, { CR79,   0x58 }, { CR80,  0x30 },
+                { ZD_CR47,   0x1e }, { ZD_CR79,   0x58 }, { ZD_CR80,  0x30 },
-                { CR81,   0x30 }, { CR87,   0x0a }, { CR89,  0x04 },
+                { ZD_CR81,   0x30 }, { ZD_CR87,   0x0a }, { ZD_CR89,  0x04 },
-                { CR92,   0x0a }, { CR99,   0x28 }, { CR100, 0x00 },
+                { ZD_CR92,   0x0a }, { ZD_CR99,   0x28 }, { ZD_CR100, 0x00 },
-                { CR101,  0x13 }, { CR102,  0x27 }, { CR106, 0x24 },
+                { ZD_CR101,  0x13 }, { ZD_CR102,  0x27 }, { ZD_CR106, 0x24 },
-                { CR107,  0x2a }, { CR109,  0x09 }, { CR110, 0x13 },
+                { ZD_CR107,  0x2a }, { ZD_CR109,  0x09 }, { ZD_CR110, 0x13 },
-                { CR111,  0x1f }, { CR112,  0x1f }, { CR113, 0x27 },
+                { ZD_CR111,  0x1f }, { ZD_CR112,  0x1f }, { ZD_CR113, 0x27 },
-                { CR114,  0x27 },
+                { ZD_CR114,  0x27 },
                /* for newest (3rd cut) AL2300 */
-                { CR115,  0x24 },
+                { ZD_CR115,  0x24 },
-                { CR116,  0x24 }, { CR117,  0xf4 }, { CR118, 0xfc },
+                { ZD_CR116,  0x24 }, { ZD_CR117,  0xf4 }, { ZD_CR118, 0xfc },
-                { CR119,  0x10 }, { CR120,  0x4f }, { CR121, 0x77 },
+                { ZD_CR119,  0x10 }, { ZD_CR120,  0x4f }, { ZD_CR121, 0x77 },
-                { CR122,  0xe0 }, { CR137,  0x88 }, { CR252, 0xff },
+                { ZD_CR122,  0xe0 }, { ZD_CR137,  0x88 }, { ZD_CR252, 0xff },
-                { CR253,  0xff },
+                { ZD_CR253,  0xff },
        };
        static const struct zd_ioreq16 ioreqs_pll[] = {
                /* shdnb(PLL_ON)=0 */
-                { CR251,  0x2f },
+                { ZD_CR251,  0x2f },
                /* shdnb(PLL_ON)=1 */
-                { CR251,  0x3f },
+                { ZD_CR251,  0x3f },
-                { CR138,  0x28 }, { CR203,  0x06 },
+                { ZD_CR138,  0x28 }, { ZD_CR203,  0x06 },
        };
        static const u32 rv1[] = {
@@ -161,7 +161,7 @@ static int zd1211_al2230_init_hw(struct zd_rf *rf)
                0x0805b6,
                0x011687,
                0x000688,
-                0x0403b9, /* external control TX power (CR31) */
+                0x0403b9, /* external control TX power (ZD_CR31) */
                0x00dbba,
                0x00099b,
                0x0bdffc,
@@ -221,52 +221,54 @@ static int zd1211b_al2230_init_hw(struct zd_rf *rf)
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs1[] = {
-                { CR10,  0x89 }, { CR15,  0x20 },
+                { ZD_CR10,  0x89 }, { ZD_CR15,  0x20 },
-                { CR17,  0x2B }, /* for newest(3rd cut) AL2230 */
+                { ZD_CR17,  0x2B }, /* for newest(3rd cut) AL2230 */
-                { CR23,  0x40 }, { CR24,  0x20 }, { CR26,  0x93 },
+                { ZD_CR23,  0x40 }, { ZD_CR24,  0x20 }, { ZD_CR26,  0x93 },
-                { CR28,  0x3e }, { CR29,  0x00 },
+                { ZD_CR28,  0x3e }, { ZD_CR29,  0x00 },
-                { CR33,  0x28 }, /* 5621 */
+                { ZD_CR33,  0x28 }, /* 5621 */
-                { CR34,  0x30 },
+                { ZD_CR34,  0x30 },
-                { CR35,  0x3e }, /* for newest(3rd cut) AL2230 */
+                { ZD_CR35,  0x3e }, /* for newest(3rd cut) AL2230 */
-                { CR41,  0x24 }, { CR44,  0x32 },
+                { ZD_CR41,  0x24 }, { ZD_CR44,  0x32 },
-                { CR46,  0x99 }, /* for newest(3rd cut) AL2230 */
+                { ZD_CR46,  0x99 }, /* for newest(3rd cut) AL2230 */
-                { CR47,  0x1e },
+                { ZD_CR47,  0x1e },
                /* ZD1211B 05.06.10 */
-                { CR48,  0x06 }, { CR49,  0xf9 }, { CR51,  0x01 },
+                { ZD_CR48,  0x06 }, { ZD_CR49,  0xf9 }, { ZD_CR51,  0x01 },
-                { CR52,  0x80 }, { CR53,  0x7e }, { CR65,  0x00 },
+                { ZD_CR52,  0x80 }, { ZD_CR53,  0x7e }, { ZD_CR65,  0x00 },
-                { CR66,  0x00 }, { CR67,  0x00 }, { CR68,  0x00 },
+                { ZD_CR66,  0x00 }, { ZD_CR67,  0x00 }, { ZD_CR68,  0x00 },
-                { CR69,  0x28 },
+                { ZD_CR69,  0x28 },
-                { CR79,  0x58 }, { CR80,  0x30 }, { CR81,  0x30 },
+                { ZD_CR79,  0x58 }, { ZD_CR80,  0x30 }, { ZD_CR81,  0x30 },
-                { CR87,  0x0a }, { CR89,  0x04 },
+                { ZD_CR87,  0x0a }, { ZD_CR89,  0x04 },
-                { CR91,  0x00 }, /* 5621 */
+                { ZD_CR91,  0x00 }, /* 5621 */
-                { CR92,  0x0a },
+                { ZD_CR92,  0x0a },
-                { CR98,  0x8d }, /* 4804,  for 1212 new algorithm */
+                { ZD_CR98,  0x8d }, /* 4804,  for 1212 new algorithm */
-                { CR99,  0x00 }, /* 5621 */
+                { ZD_CR99,  0x00 }, /* 5621 */
-                { CR101, 0x13 }, { CR102, 0x27 },
+                { ZD_CR101, 0x13 }, { ZD_CR102, 0x27 },
-                { CR106, 0x24 }, /* for newest(3rd cut) AL2230 */
+                { ZD_CR106, 0x24 }, /* for newest(3rd cut) AL2230 */
-                { CR107, 0x2a },
+                { ZD_CR107, 0x2a },
-                { CR109, 0x13 }, /* 4804, for 1212 new algorithm */
+                { ZD_CR109, 0x13 }, /* 4804, for 1212 new algorithm */
-                { CR110, 0x1f }, /* 4804, for 1212 new algorithm */
+                { ZD_CR110, 0x1f }, /* 4804, for 1212 new algorithm */
-                { CR111, 0x1f }, { CR112, 0x1f }, { CR113, 0x27 },
+                { ZD_CR111, 0x1f }, { ZD_CR112, 0x1f }, { ZD_CR113, 0x27 },
-                { CR114, 0x27 },
+                { ZD_CR114, 0x27 },
-                { CR115, 0x26 }, /* 24->26 at 4902 for newest(3rd cut) AL2230 */
+                { ZD_CR115, 0x26 }, /* 24->26 at 4902 for newest(3rd cut)
-                { CR116, 0x24 },
+                                     * AL2230
-                { CR117, 0xfa }, /* for 1211b */
+                                     */
-                { CR118, 0xfa }, /* for 1211b */
+                { ZD_CR116, 0x24 },
-                { CR119, 0x10 },
+                { ZD_CR117, 0xfa }, /* for 1211b */
-                { CR120, 0x4f },
+                { ZD_CR118, 0xfa }, /* for 1211b */
-                { CR121, 0x6c }, /* for 1211b */
+                { ZD_CR119, 0x10 },
-                { CR122, 0xfc }, /* E0->FC at 4902 */
+                { ZD_CR120, 0x4f },
-                { CR123, 0x57 }, /* 5623 */
+                { ZD_CR121, 0x6c }, /* for 1211b */
-                { CR125, 0xad }, /* 4804, for 1212 new algorithm */
+                { ZD_CR122, 0xfc }, /* E0->FC at 4902 */
-                { CR126, 0x6c }, /* 5614 */
+                { ZD_CR123, 0x57 }, /* 5623 */
-                { CR127, 0x03 }, /* 4804, for 1212 new algorithm */
+                { ZD_CR125, 0xad }, /* 4804, for 1212 new algorithm */
-                { CR137, 0x50 }, /* 5614 */
+                { ZD_CR126, 0x6c }, /* 5614 */
-                { CR138, 0xa8 },
+                { ZD_CR127, 0x03 }, /* 4804, for 1212 new algorithm */
-                { CR144, 0xac }, /* 5621 */
+                { ZD_CR137, 0x50 }, /* 5614 */
-                { CR150, 0x0d }, { CR252, 0x34 }, { CR253, 0x34 },
+                { ZD_CR138, 0xa8 },
+                { ZD_CR144, 0xac }, /* 5621 */
+                { ZD_CR150, 0x0d }, { ZD_CR252, 0x34 }, { ZD_CR253, 0x34 },
        };
        static const u32 rv1[] = {
@@ -284,7 +286,7 @@ static int zd1211b_al2230_init_hw(struct zd_rf *rf)
                0x6da010, /* Reg6 update for MP versio */
                0xe36280, /* Modified by jxiao for Bor-Chin on 2004/08/02 */
                0x116000,
-                0x9dc020, /* External control TX power (CR31) */
+                0x9dc020, /* External control TX power (ZD_CR31) */
                0x5ddb00, /* RegA update for MP version */
                0xd99000, /* RegB update for MP version */
                0x3ffbd0, /* RegC update for MP version */
@@ -295,8 +297,8 @@ static int zd1211b_al2230_init_hw(struct zd_rf *rf)
        };
        static const struct zd_ioreq16 ioreqs2[] = {
-                { CR251, 0x2f }, /* shdnb(PLL_ON)=0 */
+                { ZD_CR251, 0x2f }, /* shdnb(PLL_ON)=0 */
-                { CR251, 0x7f }, /* shdnb(PLL_ON)=1 */
+                { ZD_CR251, 0x7f }, /* shdnb(PLL_ON)=1 */
        };
        static const u32 rv3[] = {
@@ -308,7 +310,7 @@ static int zd1211b_al2230_init_hw(struct zd_rf *rf)
        static const struct zd_ioreq16 ioreqs3[] = {
                /* related to 6M band edge patching, happens unconditionally */
-                { CR128, 0x14 }, { CR129, 0x12 }, { CR130, 0x10 },
+                { ZD_CR128, 0x14 }, { ZD_CR129, 0x12 }, { ZD_CR130, 0x10 },
        };
        r = zd_iowrite16a_locked(chip, zd1211b_ioreqs_shared_1,
@@ -361,8 +363,8 @@ static int zd1211_al2230_set_channel(struct zd_rf *rf, u8 channel)
        const u32 *rv = zd1211_al2230_table[channel-1];
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR138, 0x28 },
+                { ZD_CR138, 0x28 },
-                { CR203, 0x06 },
+                { ZD_CR203, 0x06 },
        };
        r = zd_rfwritev_locked(chip, rv, 3, RF_RV_BITS);
@@ -393,8 +395,8 @@ static int zd1211_al2230_switch_radio_on(struct zd_rf *rf)
 {
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR11,  0x00 },
+                { ZD_CR11,  0x00 },
-                { CR251, 0x3f },
+                { ZD_CR251, 0x3f },
        };
        return zd_iowrite16a_locked(chip, ioreqs, ARRAY_SIZE(ioreqs));
@@ -404,8 +406,8 @@ static int zd1211b_al2230_switch_radio_on(struct zd_rf *rf)
 {
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR11,  0x00 },
+                { ZD_CR11,  0x00 },
-                { CR251, 0x7f },
+                { ZD_CR251, 0x7f },
        };
        return zd_iowrite16a_locked(chip, ioreqs, ARRAY_SIZE(ioreqs));
@@ -415,8 +417,8 @@ static int al2230_switch_radio_off(struct zd_rf *rf)
 {
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR11,  0x04 },
+                { ZD_CR11,  0x04 },
-                { CR251, 0x2f },
+                { ZD_CR251, 0x2f },
        };
        return zd_iowrite16a_locked(chip, ioreqs, ARRAY_SIZE(ioreqs));
diff --git a/drivers/net/wireless/zd1211rw/zd_rf_al7230b.c b/drivers/net/wireless/zd1211rw/zd_rf_al7230b.c
index 65095d661e6b..385c670d1293 100644
--- a/drivers/net/wireless/zd1211rw/zd_rf_al7230b.c
+++ b/drivers/net/wireless/zd1211rw/zd_rf_al7230b.c
@@ -68,19 +68,19 @@ static const u32 rv_init2[] = {
 };
 static const struct zd_ioreq16 ioreqs_sw[] = {
-        { CR128, 0x14 }, { CR129, 0x12 }, { CR130, 0x10 },
+        { ZD_CR128, 0x14 }, { ZD_CR129, 0x12 }, { ZD_CR130, 0x10 },
-        { CR38,  0x38 }, { CR136, 0xdf },
+        { ZD_CR38,  0x38 }, { ZD_CR136, 0xdf },
 };
 static int zd1211b_al7230b_finalize(struct zd_chip *chip)
 {
        int r;
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR80,  0x30 }, { CR81,  0x30 }, { CR79,  0x58 },
+                { ZD_CR80,  0x30 }, { ZD_CR81,  0x30 }, { ZD_CR79,  0x58 },
-                { CR12,  0xf0 }, { CR77,  0x1b }, { CR78,  0x58 },
+                { ZD_CR12,  0xf0 }, { ZD_CR77,  0x1b }, { ZD_CR78,  0x58 },
-                { CR203, 0x04 },
+                { ZD_CR203, 0x04 },
                { },
-                { CR240, 0x80 },
+                { ZD_CR240, 0x80 },
        };
        r = zd_iowrite16a_locked(chip, ioreqs, ARRAY_SIZE(ioreqs));
@@ -89,12 +89,12 @@ static int zd1211b_al7230b_finalize(struct zd_chip *chip)
        if (chip->new_phy_layout) {
                /* antenna selection? */
-                r = zd_iowrite16_locked(chip, 0xe5, CR9);
+                r = zd_iowrite16_locked(chip, 0xe5, ZD_CR9);
                if (r)
                        return r;
        }
-        return zd_iowrite16_locked(chip, 0x04, CR203);
+        return zd_iowrite16_locked(chip, 0x04, ZD_CR203);
 }
 static int zd1211_al7230b_init_hw(struct zd_rf *rf)
@@ -106,66 +106,66 @@ static int zd1211_al7230b_init_hw(struct zd_rf *rf)
         * specified */
        static const struct zd_ioreq16 ioreqs_1[] = {
                /* This one is 7230-specific, and happens before the rest */
-                { CR240,  0x57 },
+                { ZD_CR240,  0x57 },
                { },
-                { CR15,   0x20 }, { CR23,   0x40 }, { CR24,  0x20 },
+                { ZD_CR15,   0x20 }, { ZD_CR23,   0x40 }, { ZD_CR24,  0x20 },
-                { CR26,   0x11 }, { CR28,   0x3e }, { CR29,  0x00 },
+                { ZD_CR26,   0x11 }, { ZD_CR28,   0x3e }, { ZD_CR29,  0x00 },
-                { CR44,   0x33 },
+                { ZD_CR44,   0x33 },
                /* This value is different for 7230 (was: 0x2a) */
-                { CR106,  0x22 },
+                { ZD_CR106,  0x22 },
-                { CR107,  0x1a }, { CR109,  0x09 }, { CR110,  0x27 },
+                { ZD_CR107,  0x1a }, { ZD_CR109,  0x09 }, { ZD_CR110,  0x27 },
-                { CR111,  0x2b }, { CR112,  0x2b }, { CR119,  0x0a },
+                { ZD_CR111,  0x2b }, { ZD_CR112,  0x2b }, { ZD_CR119,  0x0a },
                /* This happened further down in AL2230,
                 * and the value changed (was: 0xe0) */
-                { CR122,  0xfc },
+                { ZD_CR122,  0xfc },
-                { CR10,   0x89 },
+                { ZD_CR10,   0x89 },
                /* for newest (3rd cut) AL2300 */
-                { CR17,   0x28 },
+                { ZD_CR17,   0x28 },
-                { CR26,   0x93 }, { CR34,   0x30 },
+                { ZD_CR26,   0x93 }, { ZD_CR34,   0x30 },
                /* for newest (3rd cut) AL2300 */
-                { CR35,   0x3e },
+                { ZD_CR35,   0x3e },
-                { CR41,   0x24 }, { CR44,   0x32 },
+                { ZD_CR41,   0x24 }, { ZD_CR44,   0x32 },
                /* for newest (3rd cut) AL2300 */
-                { CR46,   0x96 },
+                { ZD_CR46,   0x96 },
-                { CR47,   0x1e }, { CR79,   0x58 }, { CR80,  0x30 },
+                { ZD_CR47,   0x1e }, { ZD_CR79,   0x58 }, { ZD_CR80,  0x30 },
-                { CR81,   0x30 }, { CR87,   0x0a }, { CR89,  0x04 },
+                { ZD_CR81,   0x30 }, { ZD_CR87,   0x0a }, { ZD_CR89,  0x04 },
-                { CR92,   0x0a }, { CR99,   0x28 },
+                { ZD_CR92,   0x0a }, { ZD_CR99,   0x28 },
                /* This value is different for 7230 (was: 0x00) */
-                { CR100,  0x02 },
+                { ZD_CR100,  0x02 },
-                { CR101,  0x13 }, { CR102,  0x27 },
+                { ZD_CR101,  0x13 }, { ZD_CR102,  0x27 },
                /* This value is different for 7230 (was: 0x24) */
-                { CR106,  0x22 },
+                { ZD_CR106,  0x22 },
                /* This value is different for 7230 (was: 0x2a) */
-                { CR107,  0x3f },
+                { ZD_CR107,  0x3f },
-                { CR109,  0x09 },
+                { ZD_CR109,  0x09 },
                /* This value is different for 7230 (was: 0x13) */
-                { CR110,  0x1f },
+                { ZD_CR110,  0x1f },
-                { CR111,  0x1f }, { CR112,  0x1f }, { CR113, 0x27 },
+                { ZD_CR111,  0x1f }, { ZD_CR112,  0x1f }, { ZD_CR113, 0x27 },
-                { CR114,  0x27 },
+                { ZD_CR114,  0x27 },
                /* for newest (3rd cut) AL2300 */
-                { CR115,  0x24 },
+                { ZD_CR115,  0x24 },
                /* This value is different for 7230 (was: 0x24) */
-                { CR116,  0x3f },
+                { ZD_CR116,  0x3f },
                /* This value is different for 7230 (was: 0xf4) */
-                { CR117,  0xfa },
+                { ZD_CR117,  0xfa },
-                { CR118,  0xfc }, { CR119,  0x10 }, { CR120, 0x4f },
+                { ZD_CR118,  0xfc }, { ZD_CR119,  0x10 }, { ZD_CR120, 0x4f },
-                { CR121,  0x77 }, { CR137,  0x88 },
+                { ZD_CR121,  0x77 }, { ZD_CR137,  0x88 },
                /* This one is 7230-specific */
-                { CR138,  0xa8 },
+                { ZD_CR138,  0xa8 },
                /* This value is different for 7230 (was: 0xff) */
-                { CR252,  0x34 },
+                { ZD_CR252,  0x34 },
                /* This value is different for 7230 (was: 0xff) */
-                { CR253,  0x34 },
+                { ZD_CR253,  0x34 },
                /* PLL_OFF */
-                { CR251, 0x2f },
+                { ZD_CR251, 0x2f },
        };
        static const struct zd_ioreq16 ioreqs_2[] = {
-                { CR251, 0x3f }, /* PLL_ON */
+                { ZD_CR251, 0x3f }, /* PLL_ON */
-                { CR128, 0x14 }, { CR129, 0x12 }, { CR130, 0x10 },
+                { ZD_CR128, 0x14 }, { ZD_CR129, 0x12 }, { ZD_CR130, 0x10 },
-                { CR38,  0x38 }, { CR136, 0xdf },
+                { ZD_CR38,  0x38 }, { ZD_CR136, 0xdf },
        };
        r = zd_iowrite16a_locked(chip, ioreqs_1, ARRAY_SIZE(ioreqs_1));
@@ -192,10 +192,10 @@ static int zd1211_al7230b_init_hw(struct zd_rf *rf)
        if (r)
                return r;
-        r = zd_iowrite16_locked(chip, 0x06, CR203);
+        r = zd_iowrite16_locked(chip, 0x06, ZD_CR203);
        if (r)
                return r;
-        r = zd_iowrite16_locked(chip, 0x80, CR240);
+        r = zd_iowrite16_locked(chip, 0x80, ZD_CR240);
        if (r)
                return r;
@@ -208,79 +208,79 @@ static int zd1211b_al7230b_init_hw(struct zd_rf *rf)
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs_1[] = {
-                { CR240, 0x57 }, { CR9,   0x9 },
+                { ZD_CR240, 0x57 }, { ZD_CR9,   0x9 },
                { },
-                { CR10,  0x8b }, { CR15,  0x20 },
+                { ZD_CR10,  0x8b }, { ZD_CR15,  0x20 },
-                { CR17,  0x2B }, /* for newest (3rd cut) AL2230 */
+                { ZD_CR17,  0x2B }, /* for newest (3rd cut) AL2230 */
-                { CR20,  0x10 }, /* 4N25->Stone Request */
+                { ZD_CR20,  0x10 }, /* 4N25->Stone Request */
-                { CR23,  0x40 }, { CR24,  0x20 }, { CR26,  0x93 },
+                { ZD_CR23,  0x40 }, { ZD_CR24,  0x20 }, { ZD_CR26,  0x93 },
-                { CR28,  0x3e }, { CR29,  0x00 },
+                { ZD_CR28,  0x3e }, { ZD_CR29,  0x00 },
-                { CR33,  0x28 }, /* 5613 */
+                { ZD_CR33,  0x28 }, /* 5613 */
-                { CR34,  0x30 },
+                { ZD_CR34,  0x30 },
-                { CR35,  0x3e }, /* for newest (3rd cut) AL2230 */
+                { ZD_CR35,  0x3e }, /* for newest (3rd cut) AL2230 */
-                { CR41,  0x24 }, { CR44,  0x32 },
+                { ZD_CR41,  0x24 }, { ZD_CR44,  0x32 },
-                { CR46,  0x99 }, /* for newest (3rd cut) AL2230 */
+                { ZD_CR46,  0x99 }, /* for newest (3rd cut) AL2230 */
-                { CR47,  0x1e },
+                { ZD_CR47,  0x1e },
                /* ZD1215 5610 */
-                { CR48,  0x00 }, { CR49,  0x00 }, { CR51,  0x01 },
+                { ZD_CR48,  0x00 }, { ZD_CR49,  0x00 }, { ZD_CR51,  0x01 },
-                { CR52,  0x80 }, { CR53,  0x7e }, { CR65,  0x00 },
+                { ZD_CR52,  0x80 }, { ZD_CR53,  0x7e }, { ZD_CR65,  0x00 },
-                { CR66,  0x00 }, { CR67,  0x00 }, { CR68,  0x00 },
+                { ZD_CR66,  0x00 }, { ZD_CR67,  0x00 }, { ZD_CR68,  0x00 },
-                { CR69,  0x28 },
+                { ZD_CR69,  0x28 },
-                { CR79,  0x58 }, { CR80,  0x30 }, { CR81,  0x30 },
+                { ZD_CR79,  0x58 }, { ZD_CR80,  0x30 }, { ZD_CR81,  0x30 },
-                { CR87,  0x0A }, { CR89,  0x04 },
+                { ZD_CR87,  0x0A }, { ZD_CR89,  0x04 },
-                { CR90,  0x58 }, /* 5112 */
+                { ZD_CR90,  0x58 }, /* 5112 */
-                { CR91,  0x00 }, /* 5613 */
+                { ZD_CR91,  0x00 }, /* 5613 */
-                { CR92,  0x0a },
+                { ZD_CR92,  0x0a },
-                { CR98,  0x8d }, /* 4804, for 1212 new algorithm */
+                { ZD_CR98,  0x8d }, /* 4804, for 1212 new algorithm */
-                { CR99,  0x00 }, { CR100, 0x02 }, { CR101, 0x13 },
+                { ZD_CR99,  0x00 }, { ZD_CR100, 0x02 }, { ZD_CR101, 0x13 },
-                { CR102, 0x27 },
+                { ZD_CR102, 0x27 },
-                { CR106, 0x20 }, /* change to 0x24 for AL7230B */
+                { ZD_CR106, 0x20 }, /* change to 0x24 for AL7230B */
-                { CR109, 0x13 }, /* 4804, for 1212 new algorithm */
+                { ZD_CR109, 0x13 }, /* 4804, for 1212 new algorithm */
-                { CR112, 0x1f },
+                { ZD_CR112, 0x1f },
        };
        static const struct zd_ioreq16 ioreqs_new_phy[] = {
-                { CR107, 0x28 },
+                { ZD_CR107, 0x28 },
-                { CR110, 0x1f }, /* 5127, 0x13->0x1f */
+                { ZD_CR110, 0x1f }, /* 5127, 0x13->0x1f */
-                { CR111, 0x1f }, /* 0x13 to 0x1f for AL7230B */
+                { ZD_CR111, 0x1f }, /* 0x13 to 0x1f for AL7230B */
-                { CR116, 0x2a }, { CR118, 0xfa }, { CR119, 0x12 },
+                { ZD_CR116, 0x2a }, { ZD_CR118, 0xfa }, { ZD_CR119, 0x12 },
-                { CR121, 0x6c }, /* 5613 */
+                { ZD_CR121, 0x6c }, /* 5613 */
        };
        static const struct zd_ioreq16 ioreqs_old_phy[] = {
-                { CR107, 0x24 },
+                { ZD_CR107, 0x24 },
-                { CR110, 0x13 }, /* 5127, 0x13->0x1f */
+                { ZD_CR110, 0x13 }, /* 5127, 0x13->0x1f */
-                { CR111, 0x13 }, /* 0x13 to 0x1f for AL7230B */
+                { ZD_CR111, 0x13 }, /* 0x13 to 0x1f for AL7230B */
-                { CR116, 0x24 }, { CR118, 0xfc }, { CR119, 0x11 },
+                { ZD_CR116, 0x24 }, { ZD_CR118, 0xfc }, { ZD_CR119, 0x11 },
-                { CR121, 0x6a }, /* 5613 */
+                { ZD_CR121, 0x6a }, /* 5613 */
        };
        static const struct zd_ioreq16 ioreqs_2[] = {
-                { CR113, 0x27 }, { CR114, 0x27 }, { CR115, 0x24 },
+                { ZD_CR113, 0x27 }, { ZD_CR114, 0x27 }, { ZD_CR115, 0x24 },
-                { CR117, 0xfa }, { CR120, 0x4f },
+                { ZD_CR117, 0xfa }, { ZD_CR120, 0x4f },
-                { CR122, 0xfc }, /* E0->FCh at 4901 */
+                { ZD_CR122, 0xfc }, /* E0->FCh at 4901 */
-                { CR123, 0x57 }, /* 5613 */
+                { ZD_CR123, 0x57 }, /* 5613 */
-                { CR125, 0xad }, /* 4804, for 1212 new algorithm */
+                { ZD_CR125, 0xad }, /* 4804, for 1212 new algorithm */
-                { CR126, 0x6c }, /* 5613 */
+                { ZD_CR126, 0x6c }, /* 5613 */
-                { CR127, 0x03 }, /* 4804, for 1212 new algorithm */
+                { ZD_CR127, 0x03 }, /* 4804, for 1212 new algorithm */
-                { CR130, 0x10 },
+                { ZD_CR130, 0x10 },
-                { CR131, 0x00 }, /* 5112 */
+                { ZD_CR131, 0x00 }, /* 5112 */
-                { CR137, 0x50 }, /* 5613 */
+                { ZD_CR137, 0x50 }, /* 5613 */
-                { CR138, 0xa8 }, /* 5112 */
+                { ZD_CR138, 0xa8 }, /* 5112 */
-                { CR144, 0xac }, /* 5613 */
+                { ZD_CR144, 0xac }, /* 5613 */
-                { CR148, 0x40 }, /* 5112 */
+                { ZD_CR148, 0x40 }, /* 5112 */
-                { CR149, 0x40 }, /* 4O07, 50->40 */
+                { ZD_CR149, 0x40 }, /* 4O07, 50->40 */
-                { CR150, 0x1a }, /* 5112, 0C->1A */
+                { ZD_CR150, 0x1a }, /* 5112, 0C->1A */
-                { CR252, 0x34 }, { CR253, 0x34 },
+                { ZD_CR252, 0x34 }, { ZD_CR253, 0x34 },
-                { CR251, 0x2f }, /* PLL_OFF */
+                { ZD_CR251, 0x2f }, /* PLL_OFF */
        };
        static const struct zd_ioreq16 ioreqs_3[] = {
-                { CR251, 0x7f }, /* PLL_ON */
+                { ZD_CR251, 0x7f }, /* PLL_ON */
-                { CR128, 0x14 }, { CR129, 0x12 }, { CR130, 0x10 },
+                { ZD_CR128, 0x14 }, { ZD_CR129, 0x12 }, { ZD_CR130, 0x10 },
-                { CR38,  0x38 }, { CR136, 0xdf },
+                { ZD_CR38,  0x38 }, { ZD_CR136, 0xdf },
        };
        r = zd_iowrite16a_locked(chip, ioreqs_1, ARRAY_SIZE(ioreqs_1));
@@ -331,16 +331,16 @@ static int zd1211_al7230b_set_channel(struct zd_rf *rf, u8 channel)
        static const struct zd_ioreq16 ioreqs[] = {
                /* PLL_ON */
-                { CR251, 0x3f },
+                { ZD_CR251, 0x3f },
-                { CR203, 0x06 }, { CR240, 0x08 },
+                { ZD_CR203, 0x06 }, { ZD_CR240, 0x08 },
        };
-        r = zd_iowrite16_locked(chip, 0x57, CR240);
+        r = zd_iowrite16_locked(chip, 0x57, ZD_CR240);
        if (r)
                return r;
        /* PLL_OFF */
-        r = zd_iowrite16_locked(chip, 0x2f, CR251);
+        r = zd_iowrite16_locked(chip, 0x2f, ZD_CR251);
        if (r)
                return r;
@@ -376,15 +376,15 @@ static int zd1211b_al7230b_set_channel(struct zd_rf *rf, u8 channel)
        const u32 *rv = chan_rv[channel-1];
        struct zd_chip *chip = zd_rf_to_chip(rf);
-        r = zd_iowrite16_locked(chip, 0x57, CR240);
+        r = zd_iowrite16_locked(chip, 0x57, ZD_CR240);
        if (r)
                return r;
-        r = zd_iowrite16_locked(chip, 0xe4, CR9);
+        r = zd_iowrite16_locked(chip, 0xe4, ZD_CR9);
        if (r)
                return r;
        /* PLL_OFF */
-        r = zd_iowrite16_locked(chip, 0x2f, CR251);
+        r = zd_iowrite16_locked(chip, 0x2f, ZD_CR251);
        if (r)
                return r;
        r = zd_rfwritev_cr_locked(chip, std_rv, ARRAY_SIZE(std_rv));
@@ -410,7 +410,7 @@ static int zd1211b_al7230b_set_channel(struct zd_rf *rf, u8 channel)
        if (r)
                return r;
-        r = zd_iowrite16_locked(chip, 0x7f, CR251);
+        r = zd_iowrite16_locked(chip, 0x7f, ZD_CR251);
        if (r)
                return r;
@@ -421,8 +421,8 @@ static int zd1211_al7230b_switch_radio_on(struct zd_rf *rf)
 {
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR11,  0x00 },
+                { ZD_CR11,  0x00 },
-                { CR251, 0x3f },
+                { ZD_CR251, 0x3f },
        };
        return zd_iowrite16a_locked(chip, ioreqs, ARRAY_SIZE(ioreqs));
@@ -432,8 +432,8 @@ static int zd1211b_al7230b_switch_radio_on(struct zd_rf *rf)
 {
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR11,  0x00 },
+                { ZD_CR11,  0x00 },
-                { CR251, 0x7f },
+                { ZD_CR251, 0x7f },
        };
        return zd_iowrite16a_locked(chip, ioreqs, ARRAY_SIZE(ioreqs));
@@ -443,8 +443,8 @@ static int al7230b_switch_radio_off(struct zd_rf *rf)
 {
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR11,  0x04 },
+                { ZD_CR11,  0x04 },
-                { CR251, 0x2f },
+                { ZD_CR251, 0x2f },
        };
        return zd_iowrite16a_locked(chip, ioreqs, ARRAY_SIZE(ioreqs));
@@ -456,7 +456,7 @@ static int zd1211b_al7230b_patch_6m(struct zd_rf *rf, u8 channel)
 {
        struct zd_chip *chip = zd_rf_to_chip(rf);
        struct zd_ioreq16 ioreqs[] = {
-                { CR128, 0x14 }, { CR129, 0x12 },
+                { ZD_CR128, 0x14 }, { ZD_CR129, 0x12 },
        };
        /* FIXME: Channel 11 is not the edge for all regulatory domains. */
diff --git a/drivers/net/wireless/zd1211rw/zd_rf_rf2959.c b/drivers/net/wireless/zd1211rw/zd_rf_rf2959.c
index e36117486c91..784d9ccb8fef 100644
--- a/drivers/net/wireless/zd1211rw/zd_rf_rf2959.c
+++ b/drivers/net/wireless/zd1211rw/zd_rf_rf2959.c
@@ -152,44 +152,44 @@ static int rf2959_init_hw(struct zd_rf *rf)
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR2,   0x1E }, { CR9,   0x20 }, { CR10,  0x89 },
+                { ZD_CR2,   0x1E }, { ZD_CR9,   0x20 }, { ZD_CR10,  0x89 },
-                { CR11,  0x00 }, { CR15,  0xD0 }, { CR17,  0x68 },
+                { ZD_CR11,  0x00 }, { ZD_CR15,  0xD0 }, { ZD_CR17,  0x68 },
-                { CR19,  0x4a }, { CR20,  0x0c }, { CR21,  0x0E },
+                { ZD_CR19,  0x4a }, { ZD_CR20,  0x0c }, { ZD_CR21,  0x0E },
-                { CR23,  0x48 },
+                { ZD_CR23,  0x48 },
                /* normal size for cca threshold */
-                { CR24,  0x14 },
+                { ZD_CR24,  0x14 },
-                /* { CR24,  0x20 }, */
+                /* { ZD_CR24,  0x20 }, */
-                { CR26,  0x90 }, { CR27,  0x30 }, { CR29,  0x20 },
+                { ZD_CR26,  0x90 }, { ZD_CR27,  0x30 }, { ZD_CR29,  0x20 },
-                { CR31,  0xb2 }, { CR32,  0x43 }, { CR33,  0x28 },
+                { ZD_CR31,  0xb2 }, { ZD_CR32,  0x43 }, { ZD_CR33,  0x28 },
-                { CR38,  0x30 }, { CR34,  0x0f }, { CR35,  0xF0 },
+                { ZD_CR38,  0x30 }, { ZD_CR34,  0x0f }, { ZD_CR35,  0xF0 },
-                { CR41,  0x2a }, { CR46,  0x7F }, { CR47,  0x1E },
+                { ZD_CR41,  0x2a }, { ZD_CR46,  0x7F }, { ZD_CR47,  0x1E },
-                { CR51,  0xc5 }, { CR52,  0xc5 }, { CR53,  0xc5 },
+                { ZD_CR51,  0xc5 }, { ZD_CR52,  0xc5 }, { ZD_CR53,  0xc5 },
-                { CR79,  0x58 }, { CR80,  0x30 }, { CR81,  0x30 },
+                { ZD_CR79,  0x58 }, { ZD_CR80,  0x30 }, { ZD_CR81,  0x30 },
-                { CR82,  0x00 }, { CR83,  0x24 }, { CR84,  0x04 },
+                { ZD_CR82,  0x00 }, { ZD_CR83,  0x24 }, { ZD_CR84,  0x04 },
-                { CR85,  0x00 }, { CR86,  0x10 }, { CR87,  0x2A },
+                { ZD_CR85,  0x00 }, { ZD_CR86,  0x10 }, { ZD_CR87,  0x2A },
-                { CR88,  0x10 }, { CR89,  0x24 }, { CR90,  0x18 },
+                { ZD_CR88,  0x10 }, { ZD_CR89,  0x24 }, { ZD_CR90,  0x18 },
-                /* { CR91,  0x18 }, */
+                /* { ZD_CR91,  0x18 }, */
                /* should solve continuous CTS frame problems */
-                { CR91,  0x00 },
+                { ZD_CR91,  0x00 },
-                { CR92,  0x0a }, { CR93,  0x00 }, { CR94,  0x01 },
+                { ZD_CR92,  0x0a }, { ZD_CR93,  0x00 }, { ZD_CR94,  0x01 },
-                { CR95,  0x00 }, { CR96,  0x40 }, { CR97,  0x37 },
+                { ZD_CR95,  0x00 }, { ZD_CR96,  0x40 }, { ZD_CR97,  0x37 },
-                { CR98,  0x05 }, { CR99,  0x28 }, { CR100, 0x00 },
+                { ZD_CR98,  0x05 }, { ZD_CR99,  0x28 }, { ZD_CR100, 0x00 },
-                { CR101, 0x13 }, { CR102, 0x27 }, { CR103, 0x27 },
+                { ZD_CR101, 0x13 }, { ZD_CR102, 0x27 }, { ZD_CR103, 0x27 },
-                { CR104, 0x18 }, { CR105, 0x12 },
+                { ZD_CR104, 0x18 }, { ZD_CR105, 0x12 },
                /* normal size */
-                { CR106, 0x1a },
+                { ZD_CR106, 0x1a },
-                /* { CR106, 0x22 }, */
+                /* { ZD_CR106, 0x22 }, */
-                { CR107, 0x24 }, { CR108, 0x0a }, { CR109, 0x13 },
+                { ZD_CR107, 0x24 }, { ZD_CR108, 0x0a }, { ZD_CR109, 0x13 },
-                { CR110, 0x2F }, { CR111, 0x27 }, { CR112, 0x27 },
+                { ZD_CR110, 0x2F }, { ZD_CR111, 0x27 }, { ZD_CR112, 0x27 },
-                { CR113, 0x27 }, { CR114, 0x27 }, { CR115, 0x40 },
+                { ZD_CR113, 0x27 }, { ZD_CR114, 0x27 }, { ZD_CR115, 0x40 },
-                { CR116, 0x40 }, { CR117, 0xF0 }, { CR118, 0xF0 },
+                { ZD_CR116, 0x40 }, { ZD_CR117, 0xF0 }, { ZD_CR118, 0xF0 },
-                { CR119, 0x16 },
+                { ZD_CR119, 0x16 },
                /* no TX continuation */
-                { CR122, 0x00 },
+                { ZD_CR122, 0x00 },
-                /* { CR122, 0xff }, */
+                /* { ZD_CR122, 0xff }, */
-                { CR127, 0x03 }, { CR131, 0x08 }, { CR138, 0x28 },
+                { ZD_CR127, 0x03 }, { ZD_CR131, 0x08 }, { ZD_CR138, 0x28 },
-                { CR148, 0x44 }, { CR150, 0x10 }, { CR169, 0xBB },
+                { ZD_CR148, 0x44 }, { ZD_CR150, 0x10 }, { ZD_CR169, 0xBB },
-                { CR170, 0xBB },
+                { ZD_CR170, 0xBB },
        };
        static const u32 rv[] = {
@@ -210,7 +210,7 @@ static int rf2959_init_hw(struct zd_rf *rf)
                 */
                0x294128, /* internal power */
                /* 0x28252c, */ /* External control TX power */
-                /* CR31_CCK, CR51_6-36M, CR52_48M, CR53_54M */
+                /* ZD_CR31_CCK, ZD_CR51_6-36M, ZD_CR52_48M, ZD_CR53_54M */
                0x2c0000,
                0x300000,
                0x340000,  /* REG13(0xD) */
@@ -245,8 +245,8 @@ static int rf2959_set_channel(struct zd_rf *rf, u8 channel)
 static int rf2959_switch_radio_on(struct zd_rf *rf)
 {
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR10, 0x89 },
+                { ZD_CR10, 0x89 },
-                { CR11, 0x00 },
+                { ZD_CR11, 0x00 },
        };
        struct zd_chip *chip = zd_rf_to_chip(rf);
@@ -256,8 +256,8 @@ static int rf2959_switch_radio_on(struct zd_rf *rf)
 static int rf2959_switch_radio_off(struct zd_rf *rf)
 {
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR10, 0x15 },
+                { ZD_CR10, 0x15 },
-                { CR11, 0x81 },
+                { ZD_CR11, 0x81 },
        };
        struct zd_chip *chip = zd_rf_to_chip(rf);
diff --git a/drivers/net/wireless/zd1211rw/zd_rf_uw2453.c b/drivers/net/wireless/zd1211rw/zd_rf_uw2453.c
index ba0a0ccb1fa0..c4d324e19c24 100644
--- a/drivers/net/wireless/zd1211rw/zd_rf_uw2453.c
+++ b/drivers/net/wireless/zd1211rw/zd_rf_uw2453.c
@@ -314,42 +314,44 @@ static int uw2453_init_hw(struct zd_rf *rf)
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR10,  0x89 }, { CR15,  0x20 },
+                { ZD_CR10,  0x89 }, { ZD_CR15,  0x20 },
-                { CR17,  0x28 }, /* 6112 no change */
+                { ZD_CR17,  0x28 }, /* 6112 no change */
-                { CR23,  0x38 }, { CR24,  0x20 }, { CR26,  0x93 },
+                { ZD_CR23,  0x38 }, { ZD_CR24,  0x20 }, { ZD_CR26,  0x93 },
-                { CR27,  0x15 }, { CR28,  0x3e }, { CR29,  0x00 },
+                { ZD_CR27,  0x15 }, { ZD_CR28,  0x3e }, { ZD_CR29,  0x00 },
-                { CR33,  0x28 }, { CR34,  0x30 },
+                { ZD_CR33,  0x28 }, { ZD_CR34,  0x30 },
-                { CR35,  0x43 }, /* 6112 3e->43 */
+                { ZD_CR35,  0x43 }, /* 6112 3e->43 */
-                { CR41,  0x24 }, { CR44,  0x32 },
+                { ZD_CR41,  0x24 }, { ZD_CR44,  0x32 },
-                { CR46,  0x92 }, /* 6112 96->92 */
+                { ZD_CR46,  0x92 }, /* 6112 96->92 */
-                { CR47,  0x1e },
+                { ZD_CR47,  0x1e },
-                { CR48,  0x04 }, /* 5602 Roger */
+                { ZD_CR48,  0x04 }, /* 5602 Roger */
-                { CR49,  0xfa }, { CR79,  0x58 }, { CR80,  0x30 },
+                { ZD_CR49,  0xfa }, { ZD_CR79,  0x58 }, { ZD_CR80,  0x30 },
-                { CR81,  0x30 }, { CR87,  0x0a }, { CR89,  0x04 },
+                { ZD_CR81,  0x30 }, { ZD_CR87,  0x0a }, { ZD_CR89,  0x04 },
-                { CR91,  0x00 }, { CR92,  0x0a }, { CR98,  0x8d },
+                { ZD_CR91,  0x00 }, { ZD_CR92,  0x0a }, { ZD_CR98,  0x8d },
-                { CR99,  0x28 }, { CR100, 0x02 },
+                { ZD_CR99,  0x28 }, { ZD_CR100, 0x02 },
-                { CR101, 0x09 }, /* 6112 13->1f 6220 1f->13 6407 13->9 */
+                { ZD_CR101, 0x09 }, /* 6112 13->1f 6220 1f->13 6407 13->9 */
-                { CR102, 0x27 },
+                { ZD_CR102, 0x27 },
-                { CR106, 0x1c }, /* 5d07 5112 1f->1c 6220 1c->1f 6221 1f->1c */
+                { ZD_CR106, 0x1c }, /* 5d07 5112 1f->1c 6220 1c->1f
-                { CR107, 0x1c }, /* 6220 1c->1a 5221 1a->1c */
+                                     * 6221 1f->1c
-                { CR109, 0x13 },
+                                     */
-                { CR110, 0x1f }, /* 6112 13->1f 6221 1f->13 6407 13->0x09 */
+                { ZD_CR107, 0x1c }, /* 6220 1c->1a 5221 1a->1c */
-                { CR111, 0x13 }, { CR112, 0x1f }, { CR113, 0x27 },
+                { ZD_CR109, 0x13 },
-                { CR114, 0x23 }, /* 6221 27->23 */
+                { ZD_CR110, 0x1f }, /* 6112 13->1f 6221 1f->13 6407 13->0x09 */
-                { CR115, 0x24 }, /* 6112 24->1c 6220 1c->24 */
+                { ZD_CR111, 0x13 }, { ZD_CR112, 0x1f }, { ZD_CR113, 0x27 },
-                { CR116, 0x24 }, /* 6220 1c->24 */
+                { ZD_CR114, 0x23 }, /* 6221 27->23 */
-                { CR117, 0xfa }, /* 6112 fa->f8 6220 f8->f4 6220 f4->fa */
+                { ZD_CR115, 0x24 }, /* 6112 24->1c 6220 1c->24 */
-                { CR118, 0xf0 }, /* 5d07 6112 f0->f2 6220 f2->f0 */
+                { ZD_CR116, 0x24 }, /* 6220 1c->24 */
-                { CR119, 0x1a }, /* 6112 1a->10 6220 10->14 6220 14->1a */
+                { ZD_CR117, 0xfa }, /* 6112 fa->f8 6220 f8->f4 6220 f4->fa */
-                { CR120, 0x4f },
+                { ZD_CR118, 0xf0 }, /* 5d07 6112 f0->f2 6220 f2->f0 */
-                { CR121, 0x1f }, /* 6220 4f->1f */
+                { ZD_CR119, 0x1a }, /* 6112 1a->10 6220 10->14 6220 14->1a */
-                { CR122, 0xf0 }, { CR123, 0x57 }, { CR125, 0xad },
+                { ZD_CR120, 0x4f },
-                { CR126, 0x6c }, { CR127, 0x03 },
+                { ZD_CR121, 0x1f }, /* 6220 4f->1f */
-                { CR128, 0x14 }, /* 6302 12->11 */
+                { ZD_CR122, 0xf0 }, { ZD_CR123, 0x57 }, { ZD_CR125, 0xad },
-                { CR129, 0x12 }, /* 6301 10->0f */
+                { ZD_CR126, 0x6c }, { ZD_CR127, 0x03 },
-                { CR130, 0x10 }, { CR137, 0x50 }, { CR138, 0xa8 },
+                { ZD_CR128, 0x14 }, /* 6302 12->11 */
-                { CR144, 0xac }, { CR146, 0x20 }, { CR252, 0xff },
+                { ZD_CR129, 0x12 }, /* 6301 10->0f */
-                { CR253, 0xff },
+                { ZD_CR130, 0x10 }, { ZD_CR137, 0x50 }, { ZD_CR138, 0xa8 },
+                { ZD_CR144, 0xac }, { ZD_CR146, 0x20 }, { ZD_CR252, 0xff },
+                { ZD_CR253, 0xff },
        };
        static const u32 rv[] = {
@@ -433,7 +435,7 @@ static int uw2453_init_hw(struct zd_rf *rf)
         * the one that produced a lock. */
        UW2453_PRIV(rf)->config = found_config + 1;
-        return zd_iowrite16_locked(chip, 0x06, CR203);
+        return zd_iowrite16_locked(chip, 0x06, ZD_CR203);
 }
 static int uw2453_set_channel(struct zd_rf *rf, u8 channel)
@@ -445,8 +447,8 @@ static int uw2453_set_channel(struct zd_rf *rf, u8 channel)
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR80,  0x30 }, { CR81,  0x30 }, { CR79,  0x58 },
+                { ZD_CR80,  0x30 }, { ZD_CR81,  0x30 }, { ZD_CR79,  0x58 },
-                { CR12,  0xf0 }, { CR77,  0x1b }, { CR78,  0x58 },
+                { ZD_CR12,  0xf0 }, { ZD_CR77,  0x1b }, { ZD_CR78,  0x58 },
        };
        r = uw2453_synth_set_channel(chip, channel, autocal);
@@ -474,7 +476,7 @@ static int uw2453_set_channel(struct zd_rf *rf, u8 channel)
        if (r)
                return r;
-        return zd_iowrite16_locked(chip, 0x06, CR203);
+        return zd_iowrite16_locked(chip, 0x06, ZD_CR203);
 }
 static int uw2453_switch_radio_on(struct zd_rf *rf)
@@ -482,7 +484,7 @@ static int uw2453_switch_radio_on(struct zd_rf *rf)
        int r;
        struct zd_chip *chip = zd_rf_to_chip(rf);
        struct zd_ioreq16 ioreqs[] = {
-                { CR11,  0x00 }, { CR251, 0x3f },
+                { ZD_CR11,  0x00 }, { ZD_CR251, 0x3f },
        };
        /* enter RXTX mode */
@@ -501,7 +503,7 @@ static int uw2453_switch_radio_off(struct zd_rf *rf)
        int r;
        struct zd_chip *chip = zd_rf_to_chip(rf);
        static const struct zd_ioreq16 ioreqs[] = {
-                { CR11,  0x04 }, { CR251, 0x2f },
+                { ZD_CR11,  0x04 }, { ZD_CR251, 0x2f },
        };
        /* enter IDLE mode */
diff --git a/drivers/net/wireless/zd1211rw/zd_usb.c b/drivers/net/wireless/zd1211rw/zd_usb.c
index ab607bbd6291..0e819943b9e4 100644
--- a/drivers/net/wireless/zd1211rw/zd_usb.c
+++ b/drivers/net/wireless/zd1211rw/zd_usb.c
@@ -1893,10 +1893,10 @@ int zd_usb_rfwrite(struct zd_usb *usb, u32 value, u8 bits)
        dev_dbg_f(zd_usb_dev(usb), "value %#09x bits %d\n", value, bits);
-        r = zd_usb_ioread16(usb, &bit_value_template, CR203);
+        r = zd_usb_ioread16(usb, &bit_value_template, ZD_CR203);
        if (r) {
                dev_dbg_f(zd_usb_dev(usb),
-                        "error %d: Couldn't read CR203\n", r);
+                        "error %d: Couldn't read ZD_CR203\n", r);
                return r;
        }
        bit_value_template &= ~(RF_IF_LE|RF_CLK|RF_DATA);
diff --git a/drivers/net/wireless/zd1211rw/zd_usb.h b/drivers/net/wireless/zd1211rw/zd_usb.h
index 325d0f989257..bf942843b733 100644
--- a/drivers/net/wireless/zd1211rw/zd_usb.h
+++ b/drivers/net/wireless/zd1211rw/zd_usb.h
@@ -109,7 +109,7 @@ struct usb_req_rfwrite {
        __le16 bits;
        /* RF2595: 24 */
        __le16 bit_values[0];
-        /* (CR203 & ~(RF_IF_LE | RF_CLK | RF_DATA)) | (bit ? RF_DATA : 0) */
+        /* (ZD_CR203 & ~(RF_IF_LE | RF_CLK | RF_DATA)) | (bit ? RF_DATA : 0) */
 } __packed;
 /* USB interrupt */
diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h
index 5d7bbf2b2ee7..161f207786a4 100644
--- a/drivers/net/xen-netback/common.h
+++ b/drivers/net/xen-netback/common.h
@@ -73,9 +73,6 @@ struct xenvif {
        struct vm_struct *tx_comms_area;
        struct vm_struct *rx_comms_area;
-        /* Flags that must not be set in dev->features */
-        u32 features_disabled;
        /* Frontend feature information. */
        u8 can_sg:1;
        u8 gso:1;
@@ -109,8 +106,8 @@ struct xenvif {
        wait_queue_head_t waiting_to_free;
 };
-#define XEN_NETIF_TX_RING_SIZE __RING_SIZE((struct xen_netif_tx_sring *)0, PAGE_SIZE)
+#define XEN_NETIF_TX_RING_SIZE __CONST_RING_SIZE(xen_netif_tx, PAGE_SIZE)
-#define XEN_NETIF_RX_RING_SIZE __RING_SIZE((struct xen_netif_rx_sring *)0, PAGE_SIZE)
+#define XEN_NETIF_RX_RING_SIZE __CONST_RING_SIZE(xen_netif_rx, PAGE_SIZE)
 struct xenvif *xenvif_alloc(struct device *parent,
                            domid_t domid,
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index de569cc19da4..0ca86f9ec4ed 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -165,69 +165,18 @@ static int xenvif_change_mtu(struct net_device *dev, int mtu)
        return 0;
 }
-static void xenvif_set_features(struct xenvif *vif)
+static u32 xenvif_fix_features(struct net_device *dev, u32 features)
-{
-        struct net_device *dev = vif->dev;
-        u32 features = dev->features;
-        if (vif->can_sg)
-                features |= NETIF_F_SG;
-        if (vif->gso || vif->gso_prefix)
-                features |= NETIF_F_TSO;
-        if (vif->csum)
-                features |= NETIF_F_IP_CSUM;
-        features &= ~(vif->features_disabled);
-        if (!(features & NETIF_F_SG) && dev->mtu > ETH_DATA_LEN)
-                dev->mtu = ETH_DATA_LEN;
-        dev->features = features;
-}
-static int xenvif_set_tx_csum(struct net_device *dev, u32 data)
-{
-        struct xenvif *vif = netdev_priv(dev);
-        if (data) {
-                if (!vif->csum)
-                        return -EOPNOTSUPP;
-                vif->features_disabled &= ~NETIF_F_IP_CSUM;
-        } else {
-                vif->features_disabled |= NETIF_F_IP_CSUM;
-        }
-        xenvif_set_features(vif);
-        return 0;
-}
-static int xenvif_set_sg(struct net_device *dev, u32 data)
 {
        struct xenvif *vif = netdev_priv(dev);
-        if (data) {
-                if (!vif->can_sg)
-                        return -EOPNOTSUPP;
-                vif->features_disabled &= ~NETIF_F_SG;
-        } else {
-                vif->features_disabled |= NETIF_F_SG;
-        }
-        xenvif_set_features(vif);
+        if (!vif->can_sg)
-        return 0;
+                features &= ~NETIF_F_SG;
-}
+        if (!vif->gso && !vif->gso_prefix)
+                features &= ~NETIF_F_TSO;
+        if (!vif->csum)
+                features &= ~NETIF_F_IP_CSUM;
-static int xenvif_set_tso(struct net_device *dev, u32 data)
+        return features;
-{
-        struct xenvif *vif = netdev_priv(dev);
-        if (data) {
-                if (!vif->gso && !vif->gso_prefix)
-                        return -EOPNOTSUPP;
-                vif->features_disabled &= ~NETIF_F_TSO;
-        } else {
-                vif->features_disabled |= NETIF_F_TSO;
-        }
-        xenvif_set_features(vif);
-        return 0;
 }
 static const struct xenvif_stat {
@@ -274,12 +223,6 @@ static void xenvif_get_strings(struct net_device *dev, u32 stringset, u8 * data)
 }
 static struct ethtool_ops xenvif_ethtool_ops = {
-        .get_tx_csum    = ethtool_op_get_tx_csum,
-        .set_tx_csum    = xenvif_set_tx_csum,
-        .get_sg         = ethtool_op_get_sg,
-        .set_sg         = xenvif_set_sg,
-        .get_tso        = ethtool_op_get_tso,
-        .set_tso        = xenvif_set_tso,
        .get_link       = ethtool_op_get_link,
        .get_sset_count = xenvif_get_sset_count,
@@ -293,6 +236,7 @@ static struct net_device_ops xenvif_netdev_ops = {
        .ndo_open       = xenvif_open,
        .ndo_stop       = xenvif_close,
        .ndo_change_mtu = xenvif_change_mtu,
+        .ndo_fix_features = xenvif_fix_features,
 };
 struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
@@ -331,7 +275,8 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
        vif->credit_timeout.expires = jiffies;
        dev->netdev_ops = &xenvif_netdev_ops;
-        xenvif_set_features(vif);
+        dev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO;
+        dev->features = dev->hw_features;
        SET_ETHTOOL_OPS(dev, &xenvif_ethtool_ops);
        dev->tx_queue_len = XENVIF_QUEUE_LENGTH;
@@ -367,8 +312,6 @@ int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
        if (vif->irq)
                return 0;
-        xenvif_set_features(vif);
        err = xen_netbk_map_frontend_rings(vif, tx_ring_ref, rx_ring_ref);
        if (err < 0)
                goto err;
@@ -384,9 +327,12 @@ int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
        xenvif_get(vif);
        rtnl_lock();
-        netif_carrier_on(vif->dev);
        if (netif_running(vif->dev))
                xenvif_up(vif);
+        if (!vif->can_sg && vif->dev->mtu > ETH_DATA_LEN)
+                dev_set_mtu(vif->dev, ETH_DATA_LEN);
+        netdev_update_features(vif->dev);
+        netif_carrier_on(vif->dev);
        rtnl_unlock();
        return 0;
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index 22b8c3505991..1ce729d6af75 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -26,7 +26,7 @@ struct backend_info {
        struct xenvif *vif;
        enum xenbus_state frontend_state;
        struct xenbus_watch hotplug_status_watch;
-        int have_hotplug_status_watch:1;
+        u8 have_hotplug_status_watch:1;
 };
 static int connect_rings(struct backend_info *);
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 5c8d9c385be0..db9a763aaa7f 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1140,6 +1140,42 @@ static void xennet_uninit(struct net_device *dev)
        gnttab_free_grant_references(np->gref_rx_head);
 }
+static u32 xennet_fix_features(struct net_device *dev, u32 features)
+{
+        struct netfront_info *np = netdev_priv(dev);
+        int val;
+        if (features & NETIF_F_SG) {
+                if (xenbus_scanf(XBT_NIL, np->xbdev->otherend, "feature-sg",
+                                 "%d", &val) < 0)
+                        val = 0;
+                if (!val)
+                        features &= ~NETIF_F_SG;
+        }
+        if (features & NETIF_F_TSO) {
+                if (xenbus_scanf(XBT_NIL, np->xbdev->otherend,
+                                 "feature-gso-tcpv4", "%d", &val) < 0)
+                        val = 0;
+                if (!val)
+                        features &= ~NETIF_F_TSO;
+        }
+        return features;
+}
+static int xennet_set_features(struct net_device *dev, u32 features)
+{
+        if (!(features & NETIF_F_SG) && dev->mtu > ETH_DATA_LEN) {
+                netdev_info(dev, "Reducing MTU because no SG offload");
+                dev->mtu = ETH_DATA_LEN;
+        }
+        return 0;
+}
 static const struct net_device_ops xennet_netdev_ops = {
        .ndo_open            = xennet_open,
        .ndo_uninit          = xennet_uninit,
@@ -1148,6 +1184,8 @@ static const struct net_device_ops xennet_netdev_ops = {
        .ndo_change_mtu      = xennet_change_mtu,
        .ndo_set_mac_address = eth_mac_addr,
        .ndo_validate_addr   = eth_validate_addr,
+        .ndo_fix_features    = xennet_fix_features,
+        .ndo_set_features    = xennet_set_features,
 };
 static struct net_device * __devinit xennet_create_dev(struct xenbus_device *dev)
@@ -1209,7 +1247,17 @@ static struct net_device * __devinit xennet_create_dev(struct xenbus_device *dev
        netdev->netdev_ops      = &xennet_netdev_ops;
        netif_napi_add(netdev, &np->napi, xennet_poll, 64);
-        netdev->features        = NETIF_F_IP_CSUM;
+        netdev->features        = NETIF_F_IP_CSUM | NETIF_F_RXCSUM |
+                                  NETIF_F_GSO_ROBUST;
+        netdev->hw_features     = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO;
+        /*
+         * Assume that all hw features are available for now. This set
+         * will be adjusted by the call to netdev_update_features() in
+         * xennet_connect() which is the earliest point where we can
+         * negotiate with the backend regarding supported features.
+         */
+        netdev->features |= netdev->hw_features;
        SET_ETHTOOL_OPS(netdev, &xennet_ethtool_ops);
        SET_NETDEV_DEV(netdev, &dev->dev);
@@ -1416,8 +1464,7 @@ static int setup_netfront(struct xenbus_device *dev, struct netfront_info *info)
                goto fail;
        err = bind_evtchn_to_irqhandler(info->evtchn, xennet_interrupt,
-                                        IRQF_SAMPLE_RANDOM, netdev->name,
+                                        0, netdev->name, netdev);
-                                        netdev);
        if (err < 0)
                goto fail;
        netdev->irq = err;
@@ -1510,54 +1557,6 @@ again:
        return err;
 }
-static int xennet_set_sg(struct net_device *dev, u32 data)
-{
-        if (data) {
-                struct netfront_info *np = netdev_priv(dev);
-                int val;
-                if (xenbus_scanf(XBT_NIL, np->xbdev->otherend, "feature-sg",
-                                 "%d", &val) < 0)
-                        val = 0;
-                if (!val)
-                        return -ENOSYS;
-        } else if (dev->mtu > ETH_DATA_LEN)
-                dev->mtu = ETH_DATA_LEN;
-        return ethtool_op_set_sg(dev, data);
-}
-static int xennet_set_tso(struct net_device *dev, u32 data)
-{
-        if (data) {
-                struct netfront_info *np = netdev_priv(dev);
-                int val;
-                if (xenbus_scanf(XBT_NIL, np->xbdev->otherend,
-                                 "feature-gso-tcpv4", "%d", &val) < 0)
-                        val = 0;
-                if (!val)
-                        return -ENOSYS;
-        }
-        return ethtool_op_set_tso(dev, data);
-}
-static void xennet_set_features(struct net_device *dev)
-{
-        /* Turn off all GSO bits except ROBUST. */
-        dev->features &= ~NETIF_F_GSO_MASK;
-        dev->features |= NETIF_F_GSO_ROBUST;
-        xennet_set_sg(dev, 0);
-        /* We need checksum offload to enable scatter/gather and TSO. */
-        if (!(dev->features & NETIF_F_IP_CSUM))
-                return;
-        if (!xennet_set_sg(dev, 1))
-                xennet_set_tso(dev, 1);
-}
 static int xennet_connect(struct net_device *dev)
 {
        struct netfront_info *np = netdev_priv(dev);
@@ -1582,7 +1581,7 @@ static int xennet_connect(struct net_device *dev)
        if (err)
                return err;
-        xennet_set_features(dev);
+        netdev_update_features(dev);
        spin_lock_bh(&np->rx_lock);
        spin_lock_irq(&np->tx_lock);
@@ -1710,9 +1709,6 @@ static void xennet_get_strings(struct net_device *dev, u32 stringset, u8 * data)
 static const struct ethtool_ops xennet_ethtool_ops =
 {
-        .set_tx_csum = ethtool_op_set_tx_csum,
-        .set_sg = xennet_set_sg,
-        .set_tso = xennet_set_tso,
        .get_link = ethtool_op_get_link,
        .get_sset_count = xennet_get_sset_count,
diff --git a/drivers/s390/net/claw.c b/drivers/s390/net/claw.c
index da8aa75bb20b..f1fa2483ae6b 100644
--- a/drivers/s390/net/claw.c
+++ b/drivers/s390/net/claw.c
@@ -845,12 +845,10 @@ claw_irq_tasklet ( unsigned long data )
 {
        struct chbk * p_ch;
        struct net_device  *dev;
-        struct claw_privbk *       privptr;
        p_ch = (struct chbk *) data;
        dev = (struct net_device *)p_ch->ndev;
        CLAW_DBF_TEXT(4, trace, "IRQtask");
-        privptr = (struct claw_privbk *)dev->ml_priv;
        unpack_read(dev);
        clear_bit(CLAW_BH_ACTIVE, (void *)&p_ch->flag_a);
        CLAW_DBF_TEXT(4, trace, "TskletXt");
@@ -1026,7 +1024,6 @@ claw_write_next ( struct chbk * p_ch )
        struct net_device  *dev;
        struct claw_privbk *privptr=NULL;
        struct sk_buff *pk_skb;
-        int     rc;
        CLAW_DBF_TEXT(4, trace, "claw_wrt");
        if (p_ch->claw_state == CLAW_STOP)
@@ -1038,7 +1035,7 @@ claw_write_next ( struct chbk * p_ch )
            !skb_queue_empty(&p_ch->collect_queue)) {
                pk_skb = claw_pack_skb(privptr);
                while (pk_skb != NULL) {
-                        rc = claw_hw_tx( pk_skb, dev,1);
+                        claw_hw_tx(pk_skb, dev, 1);
                        if (privptr->write_free_count > 0) {
                                pk_skb = claw_pack_skb(privptr);
                        } else
@@ -1322,15 +1319,12 @@ claw_hw_tx(struct sk_buff *skb, struct net_device *dev, long linkid)
        unsigned char                   *pDataAddress;
        struct endccw                   *pEnd;
        struct ccw1                     tempCCW;
-        struct chbk                     *p_ch;
        struct claw_env                 *p_env;
-        int                             lock;
        struct clawph                   *pk_head;
        struct chbk                     *ch;
        CLAW_DBF_TEXT(4, trace, "hw_tx");
        privptr = (struct claw_privbk *)(dev->ml_priv);
-        p_ch = (struct chbk *)&privptr->channel[WRITE_CHANNEL];
        p_env =privptr->p_env;
        claw_free_wrt_buf(dev); /* Clean up free chain if posible */
        /*  scan the write queue to free any completed write packets   */
@@ -1511,12 +1505,6 @@ claw_hw_tx(struct sk_buff *skb, struct net_device *dev, long linkid)
        } /* endif (p_first_ccw!=NULL)  */
        dev_kfree_skb_any(skb);
-        if (linkid==0) {
-                lock=LOCK_NO;
-        }
-        else  {
-                lock=LOCK_YES;
-        }
        claw_strt_out_IO(dev );
        /*      if write free count is zero , set NOBUFFER       */
        if (privptr->write_free_count==0) {
@@ -2821,15 +2809,11 @@ claw_free_wrt_buf( struct net_device *dev )
 {
        struct claw_privbk *privptr = (struct claw_privbk *)dev->ml_priv;
-        struct ccwbk*p_first_ccw;
-        struct ccwbk*p_last_ccw;
        struct ccwbk*p_this_ccw;
        struct ccwbk*p_next_ccw;
        CLAW_DBF_TEXT(4, trace, "freewrtb");
        /*  scan the write queue to free any completed write packets   */
-        p_first_ccw=NULL;
-        p_last_ccw=NULL;
        p_this_ccw=privptr->p_write_active_first;
        while ( (p_this_ccw!=NULL) && (p_this_ccw->header.flag!=CLAW_PENDING))
        {
@@ -3072,7 +3056,7 @@ claw_shutdown_device(struct ccwgroup_device *cgdev)
 {
        struct claw_privbk *priv;
        struct net_device *ndev;
-        int     ret;
+        int ret = 0;
        CLAW_DBF_TEXT_(2, setup, "%s", dev_name(&cgdev->dev));
        priv = dev_get_drvdata(&cgdev->dev);
@@ -3095,7 +3079,7 @@ claw_shutdown_device(struct ccwgroup_device *cgdev)
        }
        ccw_device_set_offline(cgdev->cdev[1]);
        ccw_device_set_offline(cgdev->cdev[0]);
-        return 0;
+        return ret;
 }
 static void
diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
index c189296763a4..426787efc492 100644
--- a/drivers/s390/net/ctcm_main.c
+++ b/drivers/s390/net/ctcm_main.c
@@ -672,7 +672,6 @@ static int ctcmpc_transmit_skb(struct channel *ch, struct sk_buff *skb)
        int ccw_idx;
        unsigned long hi;
        unsigned long saveflags = 0;    /* avoids compiler warning */
-        __u16 block_len;
        CTCM_PR_DEBUG("Enter %s: %s, cp=%i ch=0x%p id=%s state=%s\n",
                        __func__, dev->name, smp_processor_id(), ch,
@@ -719,7 +718,6 @@ static int ctcmpc_transmit_skb(struct channel *ch, struct sk_buff *skb)
         */
        atomic_inc(&skb->users);
-        block_len = skb->len + TH_HEADER_LENGTH + PDU_HEADER_LENGTH;
        /*
         * IDAL support in CTCM is broken, so we have to
         * care about skb's above 2G ourselves.
diff --git a/drivers/s390/net/ctcm_mpc.c b/drivers/s390/net/ctcm_mpc.c
index b64881f33f23..da4c747335e7 100644
--- a/drivers/s390/net/ctcm_mpc.c
+++ b/drivers/s390/net/ctcm_mpc.c
@@ -653,7 +653,6 @@ static void ctcmpc_send_sweep_resp(struct channel *rch)
        struct net_device *dev = rch->netdev;
        struct ctcm_priv *priv = dev->ml_priv;
        struct mpc_group *grp = priv->mpcg;
-        int rc = 0;
        struct th_sweep *header;
        struct sk_buff *sweep_skb;
        struct channel *ch  = priv->channel[CTCM_WRITE];
@@ -665,16 +664,14 @@ static void ctcmpc_send_sweep_resp(struct channel *rch)
                CTCM_DBF_TEXT_(MPC_ERROR, CTC_DBF_ERROR,
                        "%s(%s): sweep_skb allocation ERROR\n",
                        CTCM_FUNTAIL, rch->id);
-                rc = -ENOMEM;
+                goto done;
-                                goto done;
        }
        header = kmalloc(sizeof(struct th_sweep), gfp_type());
        if (!header) {
                dev_kfree_skb_any(sweep_skb);
-                rc = -ENOMEM;
+                goto done;
-                                goto done;
        }
        header->th.th_seg       = 0x00 ;
@@ -1370,8 +1367,7 @@ static void mpc_action_go_inop(fsm_instance *fi, int event, void *arg)
        struct net_device  *dev = arg;
        struct ctcm_priv    *priv;
        struct mpc_group *grp;
-        int rc = 0;
+        struct channel *wch;
-        struct channel *wch, *rch;
        BUG_ON(dev == NULL);
        CTCM_PR_DEBUG("Enter %s: %s\n", __func__, dev->name);
@@ -1396,7 +1392,6 @@ static void mpc_action_go_inop(fsm_instance *fi, int event, void *arg)
                fsm_deltimer(&priv->restart_timer);
        wch = priv->channel[CTCM_WRITE];
-        rch = priv->channel[CTCM_READ];
        switch (grp->saved_state) {
        case MPCG_STATE_RESET:
@@ -1435,7 +1430,7 @@ static void mpc_action_go_inop(fsm_instance *fi, int event, void *arg)
        if (grp->send_qllc_disc == 1) {
                grp->send_qllc_disc = 0;
-                rc = mpc_send_qllc_discontact(dev);
+                mpc_send_qllc_discontact(dev);
        }
        /* DO NOT issue DEV_EVENT_STOP directly out of this code */
diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
index 49d1cfc3217e..c3b8064a102d 100644
--- a/drivers/s390/net/lcs.c
+++ b/drivers/s390/net/lcs.c
@@ -1483,7 +1483,6 @@ lcs_tasklet(unsigned long data)
        struct lcs_channel *channel;
        struct lcs_buffer *iob;
        int buf_idx;
-        int rc;
        channel = (struct lcs_channel *) data;
        LCS_DBF_TEXT_(5, trace, "tlet%s", dev_name(&channel->ccwdev->dev));
@@ -1500,14 +1499,11 @@ lcs_tasklet(unsigned long data)
        channel->buf_idx = buf_idx;
        if (channel->state == LCS_CH_STATE_STOPPED)
-                // FIXME: what if rc != 0 ??
+                lcs_start_channel(channel);
-                rc = lcs_start_channel(channel);
        spin_lock_irqsave(get_ccwdev_lock(channel->ccwdev), flags);
        if (channel->state == LCS_CH_STATE_SUSPENDED &&
-            channel->iob[channel->io_idx].state == LCS_BUF_STATE_READY) {
+            channel->iob[channel->io_idx].state == LCS_BUF_STATE_READY)
-                // FIXME: what if rc != 0 ??
+                __lcs_resume_channel(channel);
-                rc = __lcs_resume_channel(channel);
-        }
        spin_unlock_irqrestore(get_ccwdev_lock(channel->ccwdev), flags);
        /* Something happened on the channel. Wake up waiters. */
diff --git a/drivers/s390/net/netiucv.c b/drivers/s390/net/netiucv.c
index b6a6356d09b3..3251333a23df 100644
--- a/drivers/s390/net/netiucv.c
+++ b/drivers/s390/net/netiucv.c
@@ -1994,8 +1994,6 @@ static struct net_device *netiucv_init_netdevice(char *username)
                           netiucv_setup_netdevice);
        if (!dev)
                return NULL;
-        if (dev_alloc_name(dev, dev->name) < 0)
-                goto out_netdev;
        privptr = netdev_priv(dev);
        privptr->fsm = init_fsm("netiucvdev", dev_state_names,
diff --git a/drivers/s390/net/qeth_core.h b/drivers/s390/net/qeth_core.h
index af3f7b095647..55c6aa1c9704 100644
--- a/drivers/s390/net/qeth_core.h
+++ b/drivers/s390/net/qeth_core.h
@@ -407,12 +407,6 @@ struct qeth_qdio_q {
        int next_buf_to_init;
 } __attribute__ ((aligned(256)));
-/* possible types of qeth large_send support */
-enum qeth_large_send_types {
-        QETH_LARGE_SEND_NO,
-        QETH_LARGE_SEND_TSO,
-};
 struct qeth_qdio_out_buffer {
        struct qdio_buffer *buffer;
        atomic_t state;
@@ -637,6 +631,8 @@ struct qeth_card_info {
        __u32 csum_mask;
        __u32 tx_csum_mask;
        enum qeth_ipa_promisc_modes promisc_mode;
+        __u32 diagass_support;
+        __u32 hwtrap;
 };
 struct qeth_card_options {
@@ -645,13 +641,11 @@ struct qeth_card_options {
        struct qeth_ipa_info adp; /*Adapter parameters*/
        struct qeth_routing_info route6;
        struct qeth_ipa_info ipa6;
-        enum qeth_checksum_types checksum_type;
        int broadcast_mode;
        int macaddr_mode;
        int fake_broadcast;
        int add_hhlen;
        int layer2;
-        enum qeth_large_send_types large_send;
        int performance_stats;
        int rx_sg_cb;
        enum qeth_ipa_isolation_modes isolation;
@@ -760,6 +754,14 @@ struct qeth_card_list_struct {
        rwlock_t rwlock;
 };
+struct qeth_trap_id {
+        __u16 lparnr;
+        char vmname[8];
+        __u8 chpid;
+        __u8 ssid;
+        __u16 devno;
+} __packed;
 /*some helper functions*/
 #define QETH_CARD_IFNAME(card) (((card)->dev)? (card)->dev->name : "")
@@ -794,6 +796,12 @@ static inline void qeth_put_buffer_pool_entry(struct qeth_card *card,
        list_add_tail(&entry->list, &card->qdio.in_buf_pool.entry_list);
 }
+static inline int qeth_is_diagass_supported(struct qeth_card *card,
+                enum qeth_diags_cmds cmd)
+{
+        return card->info.diagass_support & (__u32)cmd;
+}
 extern struct ccwgroup_driver qeth_l2_ccwgroup_driver;
 extern struct ccwgroup_driver qeth_l3_ccwgroup_driver;
 const char *qeth_get_cardname_short(struct qeth_card *);
@@ -879,6 +887,8 @@ void qeth_dbf_longtext(debug_info_t *id, int level, char *text, ...);
 int qeth_core_ethtool_get_settings(struct net_device *, struct ethtool_cmd *);
 int qeth_set_access_ctrl_online(struct qeth_card *card);
 int qeth_hdr_chk_and_bounce(struct sk_buff *, int);
+int qeth_hw_trap(struct qeth_card *, enum qeth_diags_trap_action);
+int qeth_query_ipassists(struct qeth_card *, enum qeth_prot_versions prot);
 /* exports for OSN */
 int qeth_osn_assist(struct net_device *, void *, int);
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index 85cc53117ea6..503678a30981 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -24,6 +24,7 @@
 #include <asm/ebcdic.h>
 #include <asm/io.h>
+#include <asm/sysinfo.h>
 #include "qeth_core.h"
@@ -349,6 +350,8 @@ static struct qeth_ipa_cmd *qeth_check_ipa_data(struct qeth_card *card,
                                           card->info.chpid);
                                netif_carrier_on(card->dev);
                                card->lan_online = 1;
+                                if (card->info.hwtrap)
+                                        card->info.hwtrap = 2;
                                qeth_schedule_recovery(card);
                                return NULL;
                        case IPA_CMD_MODCCID:
@@ -1039,7 +1042,6 @@ static void qeth_set_intial_options(struct qeth_card *card)
 {
        card->options.route4.type = NO_ROUTER;
        card->options.route6.type = NO_ROUTER;
-        card->options.checksum_type = QETH_CHECKSUM_DEFAULT;
        card->options.broadcast_mode = QETH_TR_BROADCAST_ALLRINGS;
        card->options.macaddr_mode = QETH_TR_MACADDR_NONCANONICAL;
        card->options.fake_broadcast = 0;
@@ -2574,6 +2576,142 @@ int qeth_query_setadapterparms(struct qeth_card *card)
 }
 EXPORT_SYMBOL_GPL(qeth_query_setadapterparms);
+static int qeth_query_ipassists_cb(struct qeth_card *card,
+                struct qeth_reply *reply, unsigned long data)
+{
+        struct qeth_ipa_cmd *cmd;
+        QETH_DBF_TEXT(SETUP, 2, "qipasscb");
+        cmd = (struct qeth_ipa_cmd *) data;
+        if (cmd->hdr.prot_version == QETH_PROT_IPV4) {
+                card->options.ipa4.supported_funcs = cmd->hdr.ipa_supported;
+                card->options.ipa4.enabled_funcs = cmd->hdr.ipa_enabled;
+        } else {
+                card->options.ipa6.supported_funcs = cmd->hdr.ipa_supported;
+                card->options.ipa6.enabled_funcs = cmd->hdr.ipa_enabled;
+        }
+        QETH_DBF_TEXT(SETUP, 2, "suppenbl");
+        QETH_DBF_TEXT_(SETUP, 2, "%x", cmd->hdr.ipa_supported);
+        QETH_DBF_TEXT_(SETUP, 2, "%x", cmd->hdr.ipa_enabled);
+        return 0;
+}
+int qeth_query_ipassists(struct qeth_card *card, enum qeth_prot_versions prot)
+{
+        int rc;
+        struct qeth_cmd_buffer *iob;
+        QETH_DBF_TEXT_(SETUP, 2, "qipassi%i", prot);
+        iob = qeth_get_ipacmd_buffer(card, IPA_CMD_QIPASSIST, prot);
+        rc = qeth_send_ipa_cmd(card, iob, qeth_query_ipassists_cb, NULL);
+        return rc;
+}
+EXPORT_SYMBOL_GPL(qeth_query_ipassists);
+static int qeth_query_setdiagass_cb(struct qeth_card *card,
+                struct qeth_reply *reply, unsigned long data)
+{
+        struct qeth_ipa_cmd *cmd;
+        __u16 rc;
+        cmd = (struct qeth_ipa_cmd *)data;
+        rc = cmd->hdr.return_code;
+        if (rc)
+                QETH_CARD_TEXT_(card, 2, "diagq:%x", rc);
+        else
+                card->info.diagass_support = cmd->data.diagass.ext;
+        return 0;
+}
+static int qeth_query_setdiagass(struct qeth_card *card)
+{
+        struct qeth_cmd_buffer *iob;
+        struct qeth_ipa_cmd    *cmd;
+        QETH_DBF_TEXT(SETUP, 2, "qdiagass");
+        iob = qeth_get_ipacmd_buffer(card, IPA_CMD_SET_DIAG_ASS, 0);
+        cmd = (struct qeth_ipa_cmd *)(iob->data+IPA_PDU_HEADER_SIZE);
+        cmd->data.diagass.subcmd_len = 16;
+        cmd->data.diagass.subcmd = QETH_DIAGS_CMD_QUERY;
+        return qeth_send_ipa_cmd(card, iob, qeth_query_setdiagass_cb, NULL);
+}
+static void qeth_get_trap_id(struct qeth_card *card, struct qeth_trap_id *tid)
+{
+        unsigned long info = get_zeroed_page(GFP_KERNEL);
+        struct sysinfo_2_2_2 *info222 = (struct sysinfo_2_2_2 *)info;
+        struct sysinfo_3_2_2 *info322 = (struct sysinfo_3_2_2 *)info;
+        struct ccw_dev_id ccwid;
+        int level, rc;
+        tid->chpid = card->info.chpid;
+        ccw_device_get_id(CARD_RDEV(card), &ccwid);
+        tid->ssid = ccwid.ssid;
+        tid->devno = ccwid.devno;
+        if (!info)
+                return;
+        rc = stsi(NULL, 0, 0, 0);
+        if (rc == -ENOSYS)
+                level = rc;
+        else
+                level = (((unsigned int) rc) >> 28);
+        if ((level >= 2) && (stsi(info222, 2, 2, 2) != -ENOSYS))
+                tid->lparnr = info222->lpar_number;
+        if ((level >= 3) && (stsi(info322, 3, 2, 2) != -ENOSYS)) {
+                EBCASC(info322->vm[0].name, sizeof(info322->vm[0].name));
+                memcpy(tid->vmname, info322->vm[0].name, sizeof(tid->vmname));
+        }
+        free_page(info);
+        return;
+}
+static int qeth_hw_trap_cb(struct qeth_card *card,
+                struct qeth_reply *reply, unsigned long data)
+{
+        struct qeth_ipa_cmd *cmd;
+        __u16 rc;
+        cmd = (struct qeth_ipa_cmd *)data;
+        rc = cmd->hdr.return_code;
+        if (rc)
+                QETH_CARD_TEXT_(card, 2, "trapc:%x", rc);
+        return 0;
+}
+int qeth_hw_trap(struct qeth_card *card, enum qeth_diags_trap_action action)
+{
+        struct qeth_cmd_buffer *iob;
+        struct qeth_ipa_cmd *cmd;
+        QETH_DBF_TEXT(SETUP, 2, "diagtrap");
+        iob = qeth_get_ipacmd_buffer(card, IPA_CMD_SET_DIAG_ASS, 0);
+        cmd = (struct qeth_ipa_cmd *)(iob->data+IPA_PDU_HEADER_SIZE);
+        cmd->data.diagass.subcmd_len = 80;
+        cmd->data.diagass.subcmd = QETH_DIAGS_CMD_TRAP;
+        cmd->data.diagass.type = 1;
+        cmd->data.diagass.action = action;
+        switch (action) {
+        case QETH_DIAGS_TRAP_ARM:
+                cmd->data.diagass.options = 0x0003;
+                cmd->data.diagass.ext = 0x00010000 +
+                        sizeof(struct qeth_trap_id);
+                qeth_get_trap_id(card,
+                        (struct qeth_trap_id *)cmd->data.diagass.cdata);
+                break;
+        case QETH_DIAGS_TRAP_DISARM:
+                cmd->data.diagass.options = 0x0001;
+                break;
+        case QETH_DIAGS_TRAP_CAPTURE:
+                break;
+        }
+        return qeth_send_ipa_cmd(card, iob, qeth_hw_trap_cb, NULL);
+}
+EXPORT_SYMBOL_GPL(qeth_hw_trap);
 int qeth_check_qdio_errors(struct qeth_card *card, struct qdio_buffer *buf,
                unsigned int qdio_error, const char *dbftext)
 {
@@ -3903,6 +4041,7 @@ MODULE_DEVICE_TABLE(ccw, qeth_ids);
 static struct ccw_driver qeth_ccw_driver = {
        .driver = {
+                .owner = THIS_MODULE,
                .name = "qeth",
        },
        .ids = qeth_ids,
@@ -3984,6 +4123,15 @@ retriable:
                QETH_DBF_TEXT_(SETUP, 2, "5err%d", rc);
                goto out;
        }
+        card->options.ipa4.supported_funcs = 0;
+        card->options.adp.supported_funcs = 0;
+        card->info.diagass_support = 0;
+        qeth_query_ipassists(card, QETH_PROT_IPV4);
+        if (qeth_is_supported(card, IPA_SETADAPTERPARMS))
+                qeth_query_setadapterparms(card);
+        if (qeth_adp_supported(card, IPA_SETADP_SET_DIAG_ASSIST))
+                qeth_query_setdiagass(card);
        return 0;
 out:
        dev_warn(&card->gdev->dev, "The qeth device driver failed to recover "
diff --git a/drivers/s390/net/qeth_core_mpc.h b/drivers/s390/net/qeth_core_mpc.h
index 07d588867b57..e5a9d1c03839 100644
--- a/drivers/s390/net/qeth_core_mpc.h
+++ b/drivers/s390/net/qeth_core_mpc.h
@@ -80,14 +80,6 @@ enum qeth_tr_broadcast_modes {
        QETH_TR_BROADCAST_LOCAL    = 1,
 };
-/* these values match CHECKSUM_* in include/linux/skbuff.h */
-enum qeth_checksum_types {
-        SW_CHECKSUMMING = 0, /* TODO: set to bit flag used in IPA Command */
-        HW_CHECKSUMMING = 1,
-        NO_CHECKSUMMING = 2,
-};
-#define QETH_CHECKSUM_DEFAULT SW_CHECKSUMMING
 /*
 * Routing stuff
 */
@@ -456,6 +448,12 @@ enum qeth_diags_trace_cmds {
        QETH_DIAGS_CMD_TRACE_QUERY      = 0x0010,
 };
+enum qeth_diags_trap_action {
+        QETH_DIAGS_TRAP_ARM     = 0x01,
+        QETH_DIAGS_TRAP_DISARM  = 0x02,
+        QETH_DIAGS_TRAP_CAPTURE = 0x04,
+};
 struct qeth_ipacmd_diagass {
        __u32  host_tod2;
        __u32:32;
@@ -465,7 +463,8 @@ struct qeth_ipacmd_diagass {
        __u8   type;
        __u8   action;
        __u16  options;
-        __u32:32;
+        __u32  ext;
+        __u8   cdata[64];
 } __attribute__ ((packed));
 /* Header for each IPA command */
diff --git a/drivers/s390/net/qeth_core_sys.c b/drivers/s390/net/qeth_core_sys.c
index b5e967cf7e2d..0a8e86c1b0ea 100644
--- a/drivers/s390/net/qeth_core_sys.c
+++ b/drivers/s390/net/qeth_core_sys.c
@@ -530,6 +530,66 @@ out:
 static DEVICE_ATTR(isolation, 0644, qeth_dev_isolation_show,
                   qeth_dev_isolation_store);
+static ssize_t qeth_hw_trap_show(struct device *dev,
+                                struct device_attribute *attr, char *buf)
+{
+        struct qeth_card *card = dev_get_drvdata(dev);
+        if (!card)
+                return -EINVAL;
+        if (card->info.hwtrap)
+                return snprintf(buf, 5, "arm\n");
+        else
+                return snprintf(buf, 8, "disarm\n");
+}
+static ssize_t qeth_hw_trap_store(struct device *dev,
+                struct device_attribute *attr, const char *buf, size_t count)
+{
+        struct qeth_card *card = dev_get_drvdata(dev);
+        int rc = 0;
+        char *tmp, *curtoken;
+        int state = 0;
+        curtoken = (char *)buf;
+        if (!card)
+                return -EINVAL;
+        mutex_lock(&card->conf_mutex);
+        if (card->state == CARD_STATE_SOFTSETUP || card->state == CARD_STATE_UP)
+                state = 1;
+        tmp = strsep(&curtoken, "\n");
+        if (!strcmp(tmp, "arm") && !card->info.hwtrap) {
+                if (state) {
+                        if (qeth_is_diagass_supported(card,
+                            QETH_DIAGS_CMD_TRAP)) {
+                                rc = qeth_hw_trap(card, QETH_DIAGS_TRAP_ARM);
+                                if (!rc)
+                                        card->info.hwtrap = 1;
+                        } else
+                                rc = -EINVAL;
+                } else
+                        card->info.hwtrap = 1;
+        } else if (!strcmp(tmp, "disarm") && card->info.hwtrap) {
+                if (state) {
+                        rc = qeth_hw_trap(card, QETH_DIAGS_TRAP_DISARM);
+                        if (!rc)
+                                card->info.hwtrap = 0;
+                } else
+                        card->info.hwtrap = 0;
+        } else if (!strcmp(tmp, "trap") && state && card->info.hwtrap)
+                rc = qeth_hw_trap(card, QETH_DIAGS_TRAP_CAPTURE);
+        else
+                rc = -EINVAL;
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
+}
+static DEVICE_ATTR(hw_trap, 0644, qeth_hw_trap_show,
+                   qeth_hw_trap_store);
 static ssize_t qeth_dev_blkt_show(char *buf, struct qeth_card *card, int value)
 {
@@ -653,6 +713,7 @@ static struct attribute *qeth_device_attrs[] = {
        &dev_attr_performance_stats.attr,
        &dev_attr_layer2.attr,
        &dev_attr_isolation.attr,
+        &dev_attr_hw_trap.attr,
        NULL,
 };
diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
index 6fbaacb21943..b70b47fbd6cd 100644
--- a/drivers/s390/net/qeth_l2_main.c
+++ b/drivers/s390/net/qeth_l2_main.c
@@ -420,10 +420,7 @@ static int qeth_l2_process_inbound_buffer(struct qeth_card *card,
                case QETH_HEADER_TYPE_LAYER2:
                        skb->pkt_type = PACKET_HOST;
                        skb->protocol = eth_type_trans(skb, skb->dev);
-                        if (card->options.checksum_type == NO_CHECKSUMMING)
+                        skb->ip_summed = CHECKSUM_NONE;
-                                skb->ip_summed = CHECKSUM_UNNECESSARY;
-                        else
-                                skb->ip_summed = CHECKSUM_NONE;
                        if (skb->protocol == htons(ETH_P_802_2))
                                *((__u32 *)skb->cb) = ++card->seqno.pkt_seqno;
                        len = skb->len;
@@ -879,6 +876,7 @@ static int qeth_l2_probe_device(struct ccwgroup_device *gdev)
        INIT_LIST_HEAD(&card->vid_list);
        INIT_LIST_HEAD(&card->mc_list);
        card->options.layer2 = 1;
+        card->info.hwtrap = 0;
        card->discipline.start_poll = qeth_qdio_start_poll;
        card->discipline.input_handler = (qdio_handler_t *)
                qeth_qdio_input_handler;
@@ -997,6 +995,13 @@ static int __qeth_l2_set_online(struct ccwgroup_device *gdev, int recovery_mode)
        if (card->info.type != QETH_CARD_TYPE_OSN)
                qeth_l2_send_setmac(card, &card->dev->dev_addr[0]);
+        if (qeth_is_diagass_supported(card, QETH_DIAGS_CMD_TRAP)) {
+                if (card->info.hwtrap &&
+                    qeth_hw_trap(card, QETH_DIAGS_TRAP_ARM))
+                        card->info.hwtrap = 0;
+        } else
+                card->info.hwtrap = 0;
        card->state = CARD_STATE_HARDSETUP;
        memset(&card->rx, 0, sizeof(struct qeth_rx));
        qeth_print_status_message(card);
@@ -1095,6 +1100,10 @@ static int __qeth_l2_set_offline(struct ccwgroup_device *cgdev,
        if (card->dev && netif_carrier_ok(card->dev))
                netif_carrier_off(card->dev);
        recover_flag = card->state;
+        if ((!recovery_mode && card->info.hwtrap) || card->info.hwtrap == 2) {
+                qeth_hw_trap(card, QETH_DIAGS_TRAP_DISARM);
+                card->info.hwtrap = 1;
+        }
        qeth_l2_stop_card(card, recovery_mode);
        rc  = ccw_device_set_offline(CARD_DDEV(card));
        rc2 = ccw_device_set_offline(CARD_WDEV(card));
@@ -1160,6 +1169,8 @@ static void __exit qeth_l2_exit(void)
 static void qeth_l2_shutdown(struct ccwgroup_device *gdev)
 {
        struct qeth_card *card = dev_get_drvdata(&gdev->dev);
+        if ((gdev->state == CCWGROUP_ONLINE) && card->info.hwtrap)
+                qeth_hw_trap(card, QETH_DIAGS_TRAP_DISARM);
        qeth_qdio_clear_card(card, 0);
        qeth_clear_qdio_buffers(card);
 }
@@ -1175,6 +1186,8 @@ static int qeth_l2_pm_suspend(struct ccwgroup_device *gdev)
        if (gdev->state == CCWGROUP_OFFLINE)
                return 0;
        if (card->state == CARD_STATE_UP) {
+                if (card->info.hwtrap)
+                        qeth_hw_trap(card, QETH_DIAGS_TRAP_DISARM);
                __qeth_l2_set_offline(card->gdev, 1);
        } else
                __qeth_l2_set_offline(card->gdev, 0);
diff --git a/drivers/s390/net/qeth_l3.h b/drivers/s390/net/qeth_l3.h
index e705b27ec7dc..14a43aeb0c2a 100644
--- a/drivers/s390/net/qeth_l3.h
+++ b/drivers/s390/net/qeth_l3.h
@@ -62,8 +62,6 @@ void qeth_l3_del_vipa(struct qeth_card *, enum qeth_prot_versions, const u8 *);
 int qeth_l3_add_rxip(struct qeth_card *, enum qeth_prot_versions, const u8 *);
 void qeth_l3_del_rxip(struct qeth_card *card, enum qeth_prot_versions,
                        const u8 *);
-int qeth_l3_set_large_send(struct qeth_card *, enum qeth_large_send_types);
-int qeth_l3_set_rx_csum(struct qeth_card *, enum qeth_checksum_types);
 int qeth_l3_is_addr_covered_by_ipato(struct qeth_card *, struct qeth_ipaddr *);
 #endif /* __QETH_L3_H__ */
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index 142e5f6ef4f3..fd69da3fa6b4 100644
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -43,33 +43,6 @@ static int qeth_l3_deregister_addr_entry(struct qeth_card *,
 static int __qeth_l3_set_online(struct ccwgroup_device *, int);
 static int __qeth_l3_set_offline(struct ccwgroup_device *, int);
-int qeth_l3_set_large_send(struct qeth_card *card,
-                enum qeth_large_send_types type)
-{
-        int rc = 0;
-        card->options.large_send = type;
-        if (card->dev == NULL)
-                return 0;
-        if (card->options.large_send == QETH_LARGE_SEND_TSO) {
-                if (qeth_is_supported(card, IPA_OUTBOUND_TSO)) {
-                        card->dev->features |= NETIF_F_TSO | NETIF_F_SG |
-                                        NETIF_F_IP_CSUM;
-                } else {
-                        card->dev->features &= ~(NETIF_F_TSO | NETIF_F_SG |
-                                        NETIF_F_IP_CSUM);
-                        card->options.large_send = QETH_LARGE_SEND_NO;
-                        rc = -EOPNOTSUPP;
-                }
-        } else {
-                card->dev->features &= ~(NETIF_F_TSO | NETIF_F_SG |
-                                        NETIF_F_IP_CSUM);
-                card->options.large_send = QETH_LARGE_SEND_NO;
-        }
-        return rc;
-}
 static int qeth_l3_isxdigit(char *buf)
 {
        while (*buf) {
@@ -1304,39 +1277,6 @@ static int qeth_l3_start_ipa_multicast(struct qeth_card *card)
        return rc;
 }
-static int qeth_l3_query_ipassists_cb(struct qeth_card *card,
-                struct qeth_reply *reply, unsigned long data)
-{
-        struct qeth_ipa_cmd *cmd;
-        QETH_DBF_TEXT(SETUP, 2, "qipasscb");
-        cmd = (struct qeth_ipa_cmd *) data;
-        if (cmd->hdr.prot_version == QETH_PROT_IPV4) {
-                card->options.ipa4.supported_funcs = cmd->hdr.ipa_supported;
-                card->options.ipa4.enabled_funcs = cmd->hdr.ipa_enabled;
-        } else {
-                card->options.ipa6.supported_funcs = cmd->hdr.ipa_supported;
-                card->options.ipa6.enabled_funcs = cmd->hdr.ipa_enabled;
-        }
-        QETH_DBF_TEXT(SETUP, 2, "suppenbl");
-        QETH_DBF_TEXT_(SETUP, 2, "%x", cmd->hdr.ipa_supported);
-        QETH_DBF_TEXT_(SETUP, 2, "%x", cmd->hdr.ipa_enabled);
-        return 0;
-}
-static int qeth_l3_query_ipassists(struct qeth_card *card,
-                                enum qeth_prot_versions prot)
-{
-        int rc;
-        struct qeth_cmd_buffer *iob;
-        QETH_DBF_TEXT_(SETUP, 2, "qipassi%i", prot);
-        iob = qeth_get_ipacmd_buffer(card, IPA_CMD_QIPASSIST, prot);
-        rc = qeth_send_ipa_cmd(card, iob, qeth_l3_query_ipassists_cb, NULL);
-        return rc;
-}
 #ifdef CONFIG_QETH_IPV6
 static int qeth_l3_softsetup_ipv6(struct qeth_card *card)
 {
@@ -1347,7 +1287,7 @@ static int qeth_l3_softsetup_ipv6(struct qeth_card *card)
        if (card->info.type == QETH_CARD_TYPE_IQD)
                goto out;
-        rc = qeth_l3_query_ipassists(card, QETH_PROT_IPV6);
+        rc = qeth_query_ipassists(card, QETH_PROT_IPV6);
        if (rc) {
                dev_err(&card->gdev->dev,
                        "Activating IPv6 support for %s failed\n",
@@ -1472,68 +1412,38 @@ static int qeth_l3_send_checksum_command(struct qeth_card *card)
        return 0;
 }
-int qeth_l3_set_rx_csum(struct qeth_card *card,
+int qeth_l3_set_rx_csum(struct qeth_card *card, int on)
-        enum qeth_checksum_types csum_type)
 {
        int rc = 0;
-        if (card->options.checksum_type == HW_CHECKSUMMING) {
+        if (on) {
-                if ((csum_type != HW_CHECKSUMMING) &&
+                rc = qeth_l3_send_checksum_command(card);
-                        (card->state != CARD_STATE_DOWN)) {
+                if (rc)
-                        rc = qeth_l3_send_simple_setassparms(card,
+                        return -EIO;
-                                IPA_INBOUND_CHECKSUM, IPA_CMD_ASS_STOP, 0);
+                dev_info(&card->gdev->dev,
-                        if (rc)
+                        "HW Checksumming (inbound) enabled\n");
-                                return -EIO;
-                }
        } else {
-                if (csum_type == HW_CHECKSUMMING) {
+                rc = qeth_l3_send_simple_setassparms(card,
-                        if (card->state != CARD_STATE_DOWN) {
+                        IPA_INBOUND_CHECKSUM, IPA_CMD_ASS_STOP, 0);
-                                if (!qeth_is_supported(card,
+                if (rc)
-                                    IPA_INBOUND_CHECKSUM))
+                        return -EIO;
-                                        return -EPERM;
-                                rc = qeth_l3_send_checksum_command(card);
-                                if (rc)
-                                        return -EIO;
-                        }
-                }
        }
-        card->options.checksum_type = csum_type;
-        return rc;
+        return 0;
 }
 static int qeth_l3_start_ipa_checksum(struct qeth_card *card)
 {
-        int rc = 0;
        QETH_CARD_TEXT(card, 3, "strtcsum");
-        if (card->options.checksum_type == NO_CHECKSUMMING) {
+        if (card->dev->features & NETIF_F_RXCSUM) {
-                dev_info(&card->gdev->dev,
+                rtnl_lock();
-                        "Using no checksumming on %s.\n",
+                /* force set_features call */
-                        QETH_CARD_IFNAME(card));
+                card->dev->features &= ~NETIF_F_RXCSUM;
-                return 0;
+                netdev_update_features(card->dev);
-        }
+                rtnl_unlock();
-        if (card->options.checksum_type == SW_CHECKSUMMING) {
-                dev_info(&card->gdev->dev,
-                        "Using SW checksumming on %s.\n",
-                        QETH_CARD_IFNAME(card));
-                return 0;
-        }
-        if (!qeth_is_supported(card, IPA_INBOUND_CHECKSUM)) {
-                dev_info(&card->gdev->dev,
-                        "Inbound HW Checksumming not "
-                        "supported on %s,\ncontinuing "
-                        "using Inbound SW Checksumming\n",
-                        QETH_CARD_IFNAME(card));
-                card->options.checksum_type = SW_CHECKSUMMING;
-                return 0;
        }
-        rc = qeth_l3_send_checksum_command(card);
+        return 0;
-        if (!rc)
-                dev_info(&card->gdev->dev,
-                        "HW Checksumming (inbound) enabled\n");
-        return rc;
 }
 static int qeth_l3_start_ipa_tx_checksum(struct qeth_card *card)
@@ -1580,10 +1490,8 @@ static int qeth_l3_start_ipa_tso(struct qeth_card *card)
                        dev_info(&card->gdev->dev,
                                "Outbound TSO enabled\n");
        }
-        if (rc && (card->options.large_send == QETH_LARGE_SEND_TSO)) {
+        if (rc)
-                card->options.large_send = QETH_LARGE_SEND_NO;
+                card->dev->features &= ~NETIF_F_TSO;
-                card->dev->features &= ~(NETIF_F_TSO | NETIF_F_SG);
-        }
        return rc;
 }
@@ -2064,14 +1972,7 @@ static inline int qeth_l3_rebuild_skb(struct qeth_card *card,
                is_vlan = 1;
        }
-        switch (card->options.checksum_type) {
+        if (card->dev->features & NETIF_F_RXCSUM) {
-        case SW_CHECKSUMMING:
-                skb->ip_summed = CHECKSUM_NONE;
-                break;
-        case NO_CHECKSUMMING:
-                skb->ip_summed = CHECKSUM_UNNECESSARY;
-                break;
-        case HW_CHECKSUMMING:
                if ((hdr->hdr.l3.ext_flags &
                    (QETH_HDR_EXT_CSUM_HDR_REQ |
                     QETH_HDR_EXT_CSUM_TRANSP_REQ)) ==
@@ -2080,7 +1981,8 @@ static inline int qeth_l3_rebuild_skb(struct qeth_card *card,
                        skb->ip_summed = CHECKSUM_UNNECESSARY;
                else
                        skb->ip_summed = CHECKSUM_NONE;
-        }
+        } else
+                skb->ip_summed = CHECKSUM_NONE;
        return is_vlan;
 }
@@ -3024,7 +2926,7 @@ static int qeth_l3_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
        struct qeth_qdio_out_q *queue = card->qdio.out_qs
                [qeth_get_priority_queue(card, skb, ipv, cast_type)];
        int tx_bytes = skb->len;
-        enum qeth_large_send_types large_send = QETH_LARGE_SEND_NO;
+        bool large_send;
        int data_offset = -1;
        int nr_frags;
@@ -3046,8 +2948,7 @@ static int qeth_l3_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
                card->perf_stats.outbound_start_time = qeth_get_micros();
        }
-        if (skb_is_gso(skb))
+        large_send = skb_is_gso(skb);
-                large_send = card->options.large_send;
        if ((card->info.type == QETH_CARD_TYPE_IQD) && (!large_send) &&
            (skb_shinfo(skb)->nr_frags == 0)) {
@@ -3096,7 +2997,7 @@ static int qeth_l3_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
        /* fix hardware limitation: as long as we do not have sbal
         * chaining we can not send long frag lists
         */
-        if (large_send == QETH_LARGE_SEND_TSO) {
+        if (large_send) {
                if (qeth_l3_tso_elements(new_skb) + 1 > 16) {
                        if (skb_linearize(new_skb))
                                goto tx_drop;
@@ -3105,8 +3006,7 @@ static int qeth_l3_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
                }
        }
-        if ((large_send == QETH_LARGE_SEND_TSO) &&
+        if (large_send && (cast_type == RTN_UNSPEC)) {
-            (cast_type == RTN_UNSPEC)) {
                hdr = (struct qeth_hdr *)skb_push(new_skb,
                                                sizeof(struct qeth_hdr_tso));
                memset(hdr, 0, sizeof(struct qeth_hdr_tso));
@@ -3141,7 +3041,7 @@ static int qeth_l3_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
        if (card->info.type != QETH_CARD_TYPE_IQD) {
                int len;
-                if (large_send == QETH_LARGE_SEND_TSO)
+                if (large_send)
                        len = ((unsigned long)tcp_hdr(new_skb) +
                                tcp_hdr(new_skb)->doff * 4) -
                                (unsigned long)new_skb->data;
@@ -3162,7 +3062,7 @@ static int qeth_l3_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
                if (new_skb != skb)
                        dev_kfree_skb_any(skb);
                if (card->options.performance_stats) {
-                        if (large_send != QETH_LARGE_SEND_NO) {
+                        if (large_send) {
                                card->perf_stats.large_send_bytes += tx_bytes;
                                card->perf_stats.large_send_cnt++;
                        }
@@ -3248,65 +3148,42 @@ static int qeth_l3_stop(struct net_device *dev)
        return 0;
 }
-static u32 qeth_l3_ethtool_get_rx_csum(struct net_device *dev)
+static u32 qeth_l3_fix_features(struct net_device *dev, u32 features)
 {
        struct qeth_card *card = dev->ml_priv;
-        return (card->options.checksum_type == HW_CHECKSUMMING);
+        if (!qeth_is_supported(card, IPA_OUTBOUND_CHECKSUM))
-}
+                features &= ~NETIF_F_IP_CSUM;
+        if (!qeth_is_supported(card, IPA_OUTBOUND_TSO))
-static int qeth_l3_ethtool_set_rx_csum(struct net_device *dev, u32 data)
+                features &= ~NETIF_F_TSO;
-{
+        if (!qeth_is_supported(card, IPA_INBOUND_CHECKSUM))
-        struct qeth_card *card = dev->ml_priv;
+                features &= ~NETIF_F_RXCSUM;
-        enum qeth_checksum_types csum_type;
-        if (data)
-                csum_type = HW_CHECKSUMMING;
-        else
-                csum_type = SW_CHECKSUMMING;
-        return qeth_l3_set_rx_csum(card, csum_type);
+        return features;
 }
-static int qeth_l3_ethtool_set_tso(struct net_device *dev, u32 data)
+static int qeth_l3_set_features(struct net_device *dev, u32 features)
 {
        struct qeth_card *card = dev->ml_priv;
-        int rc = 0;
+        u32 changed = dev->features ^ features;
+        int err;
-        if (data) {
+        if (!(changed & NETIF_F_RXCSUM))
-                rc = qeth_l3_set_large_send(card, QETH_LARGE_SEND_TSO);
+                return 0;
-        } else {
-                dev->features &= ~NETIF_F_TSO;
-                card->options.large_send = QETH_LARGE_SEND_NO;
-        }
-        return rc;
-}
-static int qeth_l3_ethtool_set_tx_csum(struct net_device *dev, u32 data)
+        if (card->state == CARD_STATE_DOWN ||
-{
+            card->state == CARD_STATE_RECOVER)
-        struct qeth_card *card = dev->ml_priv;
+                return 0;
-        if (data) {
+        err = qeth_l3_set_rx_csum(card, features & NETIF_F_RXCSUM);
-                if (qeth_is_supported(card, IPA_OUTBOUND_CHECKSUM))
+        if (err)
-                        dev->features |= NETIF_F_IP_CSUM;
+                dev->features = features ^ NETIF_F_RXCSUM;
-                else
-                        return -EPERM;
-        } else
-                dev->features &= ~NETIF_F_IP_CSUM;
-        return 0;
+        return err;
 }
 static const struct ethtool_ops qeth_l3_ethtool_ops = {
        .get_link = ethtool_op_get_link,
-        .get_tx_csum = ethtool_op_get_tx_csum,
-        .set_tx_csum = qeth_l3_ethtool_set_tx_csum,
-        .get_rx_csum = qeth_l3_ethtool_get_rx_csum,
-        .set_rx_csum = qeth_l3_ethtool_set_rx_csum,
-        .get_sg      = ethtool_op_get_sg,
-        .set_sg      = ethtool_op_set_sg,
-        .get_tso     = ethtool_op_get_tso,
-        .set_tso     = qeth_l3_ethtool_set_tso,
        .get_strings = qeth_core_get_strings,
        .get_ethtool_stats = qeth_core_get_ethtool_stats,
        .get_sset_count = qeth_core_get_sset_count,
@@ -3347,6 +3224,8 @@ static const struct net_device_ops qeth_l3_netdev_ops = {
        .ndo_set_multicast_list = qeth_l3_set_multicast_list,
        .ndo_do_ioctl           = qeth_l3_do_ioctl,
        .ndo_change_mtu         = qeth_change_mtu,
+        .ndo_fix_features       = qeth_l3_fix_features,
+        .ndo_set_features       = qeth_l3_set_features,
        .ndo_vlan_rx_register   = qeth_l3_vlan_rx_register,
        .ndo_vlan_rx_add_vid    = qeth_l3_vlan_rx_add_vid,
        .ndo_vlan_rx_kill_vid   = qeth_l3_vlan_rx_kill_vid,
@@ -3362,6 +3241,8 @@ static const struct net_device_ops qeth_l3_osa_netdev_ops = {
        .ndo_set_multicast_list = qeth_l3_set_multicast_list,
        .ndo_do_ioctl           = qeth_l3_do_ioctl,
        .ndo_change_mtu         = qeth_change_mtu,
+        .ndo_fix_features       = qeth_l3_fix_features,
+        .ndo_set_features       = qeth_l3_set_features,
        .ndo_vlan_rx_register   = qeth_l3_vlan_rx_register,
        .ndo_vlan_rx_add_vid    = qeth_l3_vlan_rx_add_vid,
        .ndo_vlan_rx_kill_vid   = qeth_l3_vlan_rx_kill_vid,
@@ -3392,8 +3273,12 @@ static int qeth_l3_setup_netdev(struct qeth_card *card)
                        if (!(card->info.unique_id & UNIQUE_ID_NOT_BY_CARD))
                                card->dev->dev_id = card->info.unique_id &
                                                         0xffff;
-                        if (!card->info.guestlan)
+                        if (!card->info.guestlan) {
-                                card->dev->features |= NETIF_F_GRO;
+                                card->dev->hw_features = NETIF_F_SG |
+                                        NETIF_F_RXCSUM | NETIF_F_IP_CSUM |
+                                        NETIF_F_TSO;
+                                card->dev->features = NETIF_F_RXCSUM;
+                        }
                }
        } else if (card->info.type == QETH_CARD_TYPE_IQD) {
                card->dev = alloc_netdev(0, "hsi%d", ether_setup);
@@ -3426,15 +3311,13 @@ static int qeth_l3_probe_device(struct ccwgroup_device *gdev)
        qeth_l3_create_device_attributes(&gdev->dev);
        card->options.layer2 = 0;
+        card->info.hwtrap = 0;
        card->discipline.start_poll = qeth_qdio_start_poll;
        card->discipline.input_handler = (qdio_handler_t *)
                qeth_qdio_input_handler;
        card->discipline.output_handler = (qdio_handler_t *)
                qeth_qdio_output_handler;
        card->discipline.recover = qeth_l3_recover;
-        if ((card->info.type == QETH_CARD_TYPE_OSD) ||
-            (card->info.type == QETH_CARD_TYPE_OSX))
-                card->options.checksum_type = HW_CHECKSUMMING;
        return 0;
 }
@@ -3480,13 +3363,18 @@ static int __qeth_l3_set_online(struct ccwgroup_device *gdev, int recovery_mode)
                goto out_remove;
        }
-        qeth_l3_query_ipassists(card, QETH_PROT_IPV4);
        if (!card->dev && qeth_l3_setup_netdev(card)) {
                rc = -ENODEV;
                goto out_remove;
        }
+        if (qeth_is_diagass_supported(card, QETH_DIAGS_CMD_TRAP)) {
+                if (card->info.hwtrap &&
+                    qeth_hw_trap(card, QETH_DIAGS_TRAP_ARM))
+                        card->info.hwtrap = 0;
+        } else
+                card->info.hwtrap = 0;
        card->state = CARD_STATE_HARDSETUP;
        memset(&card->rx, 0, sizeof(struct qeth_rx));
        qeth_print_status_message(card);
@@ -3516,7 +3404,6 @@ contin:
                rc = qeth_l3_start_ipassists(card);
                if (rc)
                        QETH_DBF_TEXT_(SETUP, 2, "3err%d", rc);
-                qeth_l3_set_large_send(card, card->options.large_send);
                rc = qeth_l3_setrouting_v4(card);
                if (rc)
                        QETH_DBF_TEXT_(SETUP, 2, "4err%d", rc);
@@ -3589,6 +3476,10 @@ static int __qeth_l3_set_offline(struct ccwgroup_device *cgdev,
        if (card->dev && netif_carrier_ok(card->dev))
                netif_carrier_off(card->dev);
        recover_flag = card->state;
+        if ((!recovery_mode && card->info.hwtrap) || card->info.hwtrap == 2) {
+                qeth_hw_trap(card, QETH_DIAGS_TRAP_DISARM);
+                card->info.hwtrap = 1;
+        }
        qeth_l3_stop_card(card, recovery_mode);
        rc  = ccw_device_set_offline(CARD_DDEV(card));
        rc2 = ccw_device_set_offline(CARD_WDEV(card));
@@ -3644,6 +3535,8 @@ static int qeth_l3_recover(void *ptr)
 static void qeth_l3_shutdown(struct ccwgroup_device *gdev)
 {
        struct qeth_card *card = dev_get_drvdata(&gdev->dev);
+        if ((gdev->state == CCWGROUP_ONLINE) && card->info.hwtrap)
+                qeth_hw_trap(card, QETH_DIAGS_TRAP_DISARM);
        qeth_qdio_clear_card(card, 0);
        qeth_clear_qdio_buffers(card);
 }
@@ -3659,6 +3552,8 @@ static int qeth_l3_pm_suspend(struct ccwgroup_device *gdev)
        if (gdev->state == CCWGROUP_OFFLINE)
                return 0;
        if (card->state == CARD_STATE_UP) {
+                if (card->info.hwtrap)
+                        qeth_hw_trap(card, QETH_DIAGS_TRAP_DISARM);
                __qeth_l3_set_offline(card->gdev, 1);
        } else
                __qeth_l3_set_offline(card->gdev, 0);
diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c
index 67cfa68dcf1b..cd99210296e2 100644
--- a/drivers/s390/net/qeth_l3_sys.c
+++ b/drivers/s390/net/qeth_l3_sys.c
@@ -15,16 +15,6 @@
 #define QETH_DEVICE_ATTR(_id, _name, _mode, _show, _store) \
 struct device_attribute dev_attr_##_id = __ATTR(_name, _mode, _show, _store)
-static const char *qeth_l3_get_checksum_str(struct qeth_card *card)
-{
-        if (card->options.checksum_type == SW_CHECKSUMMING)
-                return "sw";
-        else if (card->options.checksum_type == HW_CHECKSUMMING)
-                return "hw";
-        else
-                return "no";
-}
 static ssize_t qeth_l3_dev_route_show(struct qeth_card *card,
                        struct qeth_routing_info *route, char *buf)
 {
@@ -295,51 +285,6 @@ out:
 static DEVICE_ATTR(canonical_macaddr, 0644, qeth_l3_dev_canonical_macaddr_show,
                   qeth_l3_dev_canonical_macaddr_store);
-static ssize_t qeth_l3_dev_checksum_show(struct device *dev,
-                        struct device_attribute *attr, char *buf)
-{
-        struct qeth_card *card = dev_get_drvdata(dev);
-        if (!card)
-                return -EINVAL;
-        return sprintf(buf, "%s checksumming\n",
-                        qeth_l3_get_checksum_str(card));
-}
-static ssize_t qeth_l3_dev_checksum_store(struct device *dev,
-                struct device_attribute *attr, const char *buf, size_t count)
-{
-        struct qeth_card *card = dev_get_drvdata(dev);
-        enum qeth_checksum_types csum_type;
-        char *tmp;
-        int rc = 0;
-        if (!card)
-                return -EINVAL;
-        mutex_lock(&card->conf_mutex);
-        tmp = strsep((char **) &buf, "\n");
-        if (!strcmp(tmp, "sw_checksumming"))
-                csum_type = SW_CHECKSUMMING;
-        else if (!strcmp(tmp, "hw_checksumming"))
-                csum_type = HW_CHECKSUMMING;
-        else if (!strcmp(tmp, "no_checksumming"))
-                csum_type = NO_CHECKSUMMING;
-        else {
-                rc = -EINVAL;
-                goto out;
-        }
-        rc = qeth_l3_set_rx_csum(card, csum_type);
-out:
-        mutex_unlock(&card->conf_mutex);
-        return rc ? rc : count;
-}
-static DEVICE_ATTR(checksumming, 0644, qeth_l3_dev_checksum_show,
-                qeth_l3_dev_checksum_store);
 static ssize_t qeth_l3_dev_sniffer_show(struct device *dev,
                struct device_attribute *attr, char *buf)
 {
@@ -402,61 +347,13 @@ out:
 static DEVICE_ATTR(sniffer, 0644, qeth_l3_dev_sniffer_show,
                qeth_l3_dev_sniffer_store);
-static ssize_t qeth_l3_dev_large_send_show(struct device *dev,
-                                struct device_attribute *attr, char *buf)
-{
-        struct qeth_card *card = dev_get_drvdata(dev);
-        if (!card)
-                return -EINVAL;
-        switch (card->options.large_send) {
-        case QETH_LARGE_SEND_NO:
-                return sprintf(buf, "%s\n", "no");
-        case QETH_LARGE_SEND_TSO:
-                return sprintf(buf, "%s\n", "TSO");
-        default:
-                return sprintf(buf, "%s\n", "N/A");
-        }
-}
-static ssize_t qeth_l3_dev_large_send_store(struct device *dev,
-                struct device_attribute *attr, const char *buf, size_t count)
-{
-        struct qeth_card *card = dev_get_drvdata(dev);
-        enum qeth_large_send_types type;
-        int rc = 0;
-        char *tmp;
-        if (!card)
-                return -EINVAL;
-        tmp = strsep((char **) &buf, "\n");
-        if (!strcmp(tmp, "no"))
-                type = QETH_LARGE_SEND_NO;
-        else if (!strcmp(tmp, "TSO"))
-                type = QETH_LARGE_SEND_TSO;
-        else
-                return -EINVAL;
-        mutex_lock(&card->conf_mutex);
-        if (card->options.large_send != type)
-                rc = qeth_l3_set_large_send(card, type);
-        mutex_unlock(&card->conf_mutex);
-        return rc ? rc : count;
-}
-static DEVICE_ATTR(large_send, 0644, qeth_l3_dev_large_send_show,
-                   qeth_l3_dev_large_send_store);
 static struct attribute *qeth_l3_device_attrs[] = {
        &dev_attr_route4.attr,
        &dev_attr_route6.attr,
        &dev_attr_fake_broadcast.attr,
        &dev_attr_broadcast_mode.attr,
        &dev_attr_canonical_macaddr.attr,
-        &dev_attr_checksumming.attr,
        &dev_attr_sniffer.attr,
-        &dev_attr_large_send.attr,
        NULL,
 };
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 662365676689..ab255fbc7f36 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -664,7 +664,7 @@ static void bnx2fc_link_speed_update(struct fc_lport *lport)
        struct fcoe_port *port = lport_priv(lport);
        struct bnx2fc_hba *hba = port->priv;
        struct net_device *netdev = hba->netdev;
-        struct ethtool_cmd ecmd = { ETHTOOL_GSET };
+        struct ethtool_cmd ecmd;
        if (!dev_ethtool_get_settings(netdev, &ecmd)) {
                lport->link_supported_speeds &=
@@ -675,12 +675,15 @@ static void bnx2fc_link_speed_update(struct fc_lport *lport)
                if (ecmd.supported & SUPPORTED_10000baseT_Full)
                        lport->link_supported_speeds |= FC_PORTSPEED_10GBIT;
-                if (ecmd.speed == SPEED_1000)
+                switch (ethtool_cmd_speed(&ecmd)) {
+                case SPEED_1000:
                        lport->link_speed = FC_PORTSPEED_1GBIT;
-                if (ecmd.speed == SPEED_10000)
+                        break;
+                case SPEED_10000:
                        lport->link_speed = FC_PORTSPEED_10GBIT;
+                        break;
+                }
        }
-        return;
 }
 static int bnx2fc_link_ok(struct fc_lport *lport)
 {
diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index de764ea7419d..a2a9c7c6c643 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -450,12 +450,13 @@ static struct cxgbi_sock *cxgbi_sock_create(struct cxgbi_device *cdev)
        return csk;
 }
-static struct rtable *find_route_ipv4(__be32 saddr, __be32 daddr,
+static struct rtable *find_route_ipv4(struct flowi4 *fl4,
+                                      __be32 saddr, __be32 daddr,
                                      __be16 sport, __be16 dport, u8 tos)
 {
        struct rtable *rt;
-        rt = ip_route_output_ports(&init_net, NULL, daddr, saddr,
+        rt = ip_route_output_ports(&init_net, fl4, NULL, daddr, saddr,
                                   dport, sport, IPPROTO_TCP, tos, 0);
        if (IS_ERR(rt))
                return NULL;
@@ -470,6 +471,7 @@ static struct cxgbi_sock *cxgbi_check_route(struct sockaddr *dst_addr)
        struct net_device *ndev;
        struct cxgbi_device *cdev;
        struct rtable *rt = NULL;
+        struct flowi4 fl4;
        struct cxgbi_sock *csk = NULL;
        unsigned int mtu = 0;
        int port = 0xFFFF;
@@ -482,7 +484,7 @@ static struct cxgbi_sock *cxgbi_check_route(struct sockaddr *dst_addr)
                goto err_out;
        }
-        rt = find_route_ipv4(0, daddr->sin_addr.s_addr, 0, daddr->sin_port, 0);
+        rt = find_route_ipv4(&fl4, 0, daddr->sin_addr.s_addr, 0, daddr->sin_port, 0);
        if (!rt) {
                pr_info("no route to ipv4 0x%x, port %u.\n",
                        daddr->sin_addr.s_addr, daddr->sin_port);
@@ -531,7 +533,7 @@ static struct cxgbi_sock *cxgbi_check_route(struct sockaddr *dst_addr)
        csk->daddr.sin_addr.s_addr = daddr->sin_addr.s_addr;
        csk->daddr.sin_port = daddr->sin_port;
        csk->daddr.sin_family = daddr->sin_family;
-        csk->saddr.sin_addr.s_addr = rt->rt_src;
+        csk->saddr.sin_addr.s_addr = fl4.saddr;
        return csk;
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 5d3700dc6f8c..cc23bd9480b2 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1952,7 +1952,7 @@ out_nodev:
 int fcoe_link_speed_update(struct fc_lport *lport)
 {
        struct net_device *netdev = fcoe_netdev(lport);
-        struct ethtool_cmd ecmd = { ETHTOOL_GSET };
+        struct ethtool_cmd ecmd;
        if (!dev_ethtool_get_settings(netdev, &ecmd)) {
                lport->link_supported_speeds &=
@@ -1963,11 +1963,14 @@ int fcoe_link_speed_update(struct fc_lport *lport)
                if (ecmd.supported & SUPPORTED_10000baseT_Full)
                        lport->link_supported_speeds |=
                                FC_PORTSPEED_10GBIT;
-                if (ecmd.speed == SPEED_1000)
+                switch (ethtool_cmd_speed(&ecmd)) {
+                case SPEED_1000:
                        lport->link_speed = FC_PORTSPEED_1GBIT;
-                if (ecmd.speed == SPEED_10000)
+                        break;
+                case SPEED_10000:
                        lport->link_speed = FC_PORTSPEED_10GBIT;
+                        break;
+                }
                return 0;
        }
        return -1;
diff --git a/drivers/ssb/driver_chipcommon.c b/drivers/ssb/driver_chipcommon.c
index 7c031fdc8205..06d15b6f2215 100644
--- a/drivers/ssb/driver_chipcommon.c
+++ b/drivers/ssb/driver_chipcommon.c
@@ -46,40 +46,66 @@ void ssb_chipco_set_clockmode(struct ssb_chipcommon *cc,
        if (!ccdev)
                return;
        bus = ccdev->bus;
+        /* We support SLOW only on 6..9 */
+        if (ccdev->id.revision >= 10 && mode == SSB_CLKMODE_SLOW)
+                mode = SSB_CLKMODE_DYNAMIC;
+        if (cc->capabilities & SSB_CHIPCO_CAP_PMU)
+                return; /* PMU controls clockmode, separated function needed */
+        SSB_WARN_ON(ccdev->id.revision >= 20);
        /* chipcommon cores prior to rev6 don't support dynamic clock control */
        if (ccdev->id.revision < 6)
                return;
-        /* chipcommon cores rev10 are a whole new ball game */
+        /* ChipCommon cores rev10+ need testing */
        if (ccdev->id.revision >= 10)
                return;
        if (!(cc->capabilities & SSB_CHIPCO_CAP_PCTL))
                return;
        switch (mode) {
-        case SSB_CLKMODE_SLOW:
+        case SSB_CLKMODE_SLOW: /* For revs 6..9 only */
                tmp = chipco_read32(cc, SSB_CHIPCO_SLOWCLKCTL);
                tmp |= SSB_CHIPCO_SLOWCLKCTL_FSLOW;
                chipco_write32(cc, SSB_CHIPCO_SLOWCLKCTL, tmp);
                break;
        case SSB_CLKMODE_FAST:
-                ssb_pci_xtal(bus, SSB_GPIO_XTAL, 1); /* Force crystal on */
+                if (ccdev->id.revision < 10) {
-                tmp = chipco_read32(cc, SSB_CHIPCO_SLOWCLKCTL);
+                        ssb_pci_xtal(bus, SSB_GPIO_XTAL, 1); /* Force crystal on */
-                tmp &= ~SSB_CHIPCO_SLOWCLKCTL_FSLOW;
+                        tmp = chipco_read32(cc, SSB_CHIPCO_SLOWCLKCTL);
-                tmp |= SSB_CHIPCO_SLOWCLKCTL_IPLL;
+                        tmp &= ~SSB_CHIPCO_SLOWCLKCTL_FSLOW;
-                chipco_write32(cc, SSB_CHIPCO_SLOWCLKCTL, tmp);
+                        tmp |= SSB_CHIPCO_SLOWCLKCTL_IPLL;
+                        chipco_write32(cc, SSB_CHIPCO_SLOWCLKCTL, tmp);
+                } else {
+                        chipco_write32(cc, SSB_CHIPCO_SYSCLKCTL,
+                                (chipco_read32(cc, SSB_CHIPCO_SYSCLKCTL) |
+                                 SSB_CHIPCO_SYSCLKCTL_FORCEHT));
+                        /* udelay(150); TODO: not available in early init */
+                }
                break;
        case SSB_CLKMODE_DYNAMIC:
-                tmp = chipco_read32(cc, SSB_CHIPCO_SLOWCLKCTL);
+                if (ccdev->id.revision < 10) {
-                tmp &= ~SSB_CHIPCO_SLOWCLKCTL_FSLOW;
+                        tmp = chipco_read32(cc, SSB_CHIPCO_SLOWCLKCTL);
-                tmp &= ~SSB_CHIPCO_SLOWCLKCTL_IPLL;
+                        tmp &= ~SSB_CHIPCO_SLOWCLKCTL_FSLOW;
-                tmp &= ~SSB_CHIPCO_SLOWCLKCTL_ENXTAL;
+                        tmp &= ~SSB_CHIPCO_SLOWCLKCTL_IPLL;
-                if ((tmp & SSB_CHIPCO_SLOWCLKCTL_SRC) != SSB_CHIPCO_SLOWCLKCTL_SRC_XTAL)
+                        tmp &= ~SSB_CHIPCO_SLOWCLKCTL_ENXTAL;
-                        tmp |= SSB_CHIPCO_SLOWCLKCTL_ENXTAL;
+                        if ((tmp & SSB_CHIPCO_SLOWCLKCTL_SRC) !=
-                chipco_write32(cc, SSB_CHIPCO_SLOWCLKCTL, tmp);
+                            SSB_CHIPCO_SLOWCLKCTL_SRC_XTAL)
+                                tmp |= SSB_CHIPCO_SLOWCLKCTL_ENXTAL;
-                /* for dynamic control, we have to release our xtal_pu "force on" */
+                        chipco_write32(cc, SSB_CHIPCO_SLOWCLKCTL, tmp);
-                if (tmp & SSB_CHIPCO_SLOWCLKCTL_ENXTAL)
-                        ssb_pci_xtal(bus, SSB_GPIO_XTAL, 0);
+                        /* For dynamic control, we have to release our xtal_pu
+                         * "force on" */
+                        if (tmp & SSB_CHIPCO_SLOWCLKCTL_ENXTAL)
+                                ssb_pci_xtal(bus, SSB_GPIO_XTAL, 0);
+                } else {
+                        chipco_write32(cc, SSB_CHIPCO_SYSCLKCTL,
+                                (chipco_read32(cc, SSB_CHIPCO_SYSCLKCTL) &
+                                 ~SSB_CHIPCO_SYSCLKCTL_FORCEHT));
+                }
                break;
        default:
                SSB_WARN_ON(1);
@@ -260,6 +286,12 @@ void ssb_chipcommon_init(struct ssb_chipcommon *cc)
        if (cc->dev->id.revision >= 11)
                cc->status = chipco_read32(cc, SSB_CHIPCO_CHIPSTAT);
        ssb_dprintk(KERN_INFO PFX "chipcommon status is 0x%x\n", cc->status);
+        if (cc->dev->id.revision >= 20) {
+                chipco_write32(cc, SSB_CHIPCO_GPIOPULLUP, 0);
+                chipco_write32(cc, SSB_CHIPCO_GPIOPULLDOWN, 0);
+        }
        ssb_pmu_init(cc);
        chipco_powercontrol_init(cc);
        ssb_chipco_set_clockmode(cc, SSB_CLKMODE_FAST);
diff --git a/drivers/ssb/driver_chipcommon_pmu.c b/drivers/ssb/driver_chipcommon_pmu.c
index 5732bb2c3578..305ade7825f7 100644
--- a/drivers/ssb/driver_chipcommon_pmu.c
+++ b/drivers/ssb/driver_chipcommon_pmu.c
@@ -423,6 +423,8 @@ static void ssb_pmu_resources_init(struct ssb_chipcommon *cc)
        switch (bus->chip_id) {
        case 0x4312:
+                 min_msk = 0xCBB;
+                 break;
        case 0x4322:
                /* We keep the default settings:
                 * min_msk = 0xCBB
diff --git a/drivers/ssb/driver_pcicore.c b/drivers/ssb/driver_pcicore.c
index 0e8d35224614..82feb348c8bb 100644
--- a/drivers/ssb/driver_pcicore.c
+++ b/drivers/ssb/driver_pcicore.c
@@ -15,6 +15,11 @@
 #include "ssb_private.h"
+static u32 ssb_pcie_read(struct ssb_pcicore *pc, u32 address);
+static void ssb_pcie_write(struct ssb_pcicore *pc, u32 address, u32 data);
+static u16 ssb_pcie_mdio_read(struct ssb_pcicore *pc, u8 device, u8 address);
+static void ssb_pcie_mdio_write(struct ssb_pcicore *pc, u8 device,
+                                u8 address, u16 data);
 static inline
 u32 pcicore_read32(struct ssb_pcicore *pc, u16 offset)
@@ -403,6 +408,107 @@ static int pcicore_is_in_hostmode(struct ssb_pcicore *pc)
 }
 #endif /* CONFIG_SSB_PCICORE_HOSTMODE */
+/**************************************************
+ * Workarounds.
+ **************************************************/
+static void ssb_pcicore_fix_sprom_core_index(struct ssb_pcicore *pc)
+{
+        u16 tmp = pcicore_read16(pc, SSB_PCICORE_SPROM(0));
+        if (((tmp & 0xF000) >> 12) != pc->dev->core_index) {
+                tmp &= ~0xF000;
+                tmp |= (pc->dev->core_index << 12);
+                pcicore_write16(pc, SSB_PCICORE_SPROM(0), tmp);
+        }
+}
+static u8 ssb_pcicore_polarity_workaround(struct ssb_pcicore *pc)
+{
+        return (ssb_pcie_read(pc, 0x204) & 0x10) ? 0xC0 : 0x80;
+}
+static void ssb_pcicore_serdes_workaround(struct ssb_pcicore *pc)
+{
+        const u8 serdes_pll_device = 0x1D;
+        const u8 serdes_rx_device = 0x1F;
+        u16 tmp;
+        ssb_pcie_mdio_write(pc, serdes_rx_device, 1 /* Control */,
+                            ssb_pcicore_polarity_workaround(pc));
+        tmp = ssb_pcie_mdio_read(pc, serdes_pll_device, 1 /* Control */);
+        if (tmp & 0x4000)
+                ssb_pcie_mdio_write(pc, serdes_pll_device, 1, tmp & ~0x4000);
+}
+static void ssb_pcicore_pci_setup_workarounds(struct ssb_pcicore *pc)
+{
+        struct ssb_device *pdev = pc->dev;
+        struct ssb_bus *bus = pdev->bus;
+        u32 tmp;
+        tmp = pcicore_read32(pc, SSB_PCICORE_SBTOPCI2);
+        tmp |= SSB_PCICORE_SBTOPCI_PREF;
+        tmp |= SSB_PCICORE_SBTOPCI_BURST;
+        pcicore_write32(pc, SSB_PCICORE_SBTOPCI2, tmp);
+        if (pdev->id.revision < 5) {
+                tmp = ssb_read32(pdev, SSB_IMCFGLO);
+                tmp &= ~SSB_IMCFGLO_SERTO;
+                tmp |= 2;
+                tmp &= ~SSB_IMCFGLO_REQTO;
+                tmp |= 3 << SSB_IMCFGLO_REQTO_SHIFT;
+                ssb_write32(pdev, SSB_IMCFGLO, tmp);
+                ssb_commit_settings(bus);
+        } else if (pdev->id.revision >= 11) {
+                tmp = pcicore_read32(pc, SSB_PCICORE_SBTOPCI2);
+                tmp |= SSB_PCICORE_SBTOPCI_MRM;
+                pcicore_write32(pc, SSB_PCICORE_SBTOPCI2, tmp);
+        }
+}
+static void ssb_pcicore_pcie_setup_workarounds(struct ssb_pcicore *pc)
+{
+        u32 tmp;
+        u8 rev = pc->dev->id.revision;
+        if (rev == 0 || rev == 1) {
+                /* TLP Workaround register. */
+                tmp = ssb_pcie_read(pc, 0x4);
+                tmp |= 0x8;
+                ssb_pcie_write(pc, 0x4, tmp);
+        }
+        if (rev == 1) {
+                /* DLLP Link Control register. */
+                tmp = ssb_pcie_read(pc, 0x100);
+                tmp |= 0x40;
+                ssb_pcie_write(pc, 0x100, tmp);
+        }
+        if (rev == 0) {
+                const u8 serdes_rx_device = 0x1F;
+                ssb_pcie_mdio_write(pc, serdes_rx_device,
+                                        2 /* Timer */, 0x8128);
+                ssb_pcie_mdio_write(pc, serdes_rx_device,
+                                        6 /* CDR */, 0x0100);
+                ssb_pcie_mdio_write(pc, serdes_rx_device,
+                                        7 /* CDR BW */, 0x1466);
+        } else if (rev == 3 || rev == 4 || rev == 5) {
+                /* TODO: DLLP Power Management Threshold */
+                ssb_pcicore_serdes_workaround(pc);
+                /* TODO: ASPM */
+        } else if (rev == 7) {
+                /* TODO: No PLL down */
+        }
+        if (rev >= 6) {
+                /* Miscellaneous Configuration Fixup */
+                tmp = pcicore_read16(pc, SSB_PCICORE_SPROM(5));
+                if (!(tmp & 0x8000))
+                        pcicore_write16(pc, SSB_PCICORE_SPROM(5),
+                                        tmp | 0x8000);
+        }
+}
 /**************************************************
 * Generic and Clientmode operation code.
@@ -417,14 +523,14 @@ static void ssb_pcicore_init_clientmode(struct ssb_pcicore *pc)
 void ssb_pcicore_init(struct ssb_pcicore *pc)
 {
        struct ssb_device *dev = pc->dev;
-        struct ssb_bus *bus;
        if (!dev)
                return;
-        bus = dev->bus;
        if (!ssb_device_is_enabled(dev))
                ssb_device_enable(dev, 0);
+        ssb_pcicore_fix_sprom_core_index(pc);
 #ifdef CONFIG_SSB_PCICORE_HOSTMODE
        pc->hostmode = pcicore_is_in_hostmode(pc);
        if (pc->hostmode)
@@ -432,6 +538,11 @@ void ssb_pcicore_init(struct ssb_pcicore *pc)
 #endif /* CONFIG_SSB_PCICORE_HOSTMODE */
        if (!pc->hostmode)
                ssb_pcicore_init_clientmode(pc);
+        /* Additional always once-executed workarounds */
+        ssb_pcicore_serdes_workaround(pc);
+        /* TODO: ASPM */
+        /* TODO: Clock Request Update */
 }
 static u32 ssb_pcie_read(struct ssb_pcicore *pc, u32 address)
@@ -446,58 +557,104 @@ static void ssb_pcie_write(struct ssb_pcicore *pc, u32 address, u32 data)
        pcicore_write32(pc, 0x134, data);
 }
-static void ssb_pcie_mdio_write(struct ssb_pcicore *pc, u8 device,
+static void ssb_pcie_mdio_set_phy(struct ssb_pcicore *pc, u8 phy)
-                                u8 address, u16 data)
 {
        const u16 mdio_control = 0x128;
        const u16 mdio_data = 0x12C;
        u32 v;
        int i;
+        v = (1 << 30); /* Start of Transaction */
+        v |= (1 << 28); /* Write Transaction */
+        v |= (1 << 17); /* Turnaround */
+        v |= (0x1F << 18);
+        v |= (phy << 4);
+        pcicore_write32(pc, mdio_data, v);
+        udelay(10);
+        for (i = 0; i < 200; i++) {
+                v = pcicore_read32(pc, mdio_control);
+                if (v & 0x100 /* Trans complete */)
+                        break;
+                msleep(1);
+        }
+}
+static u16 ssb_pcie_mdio_read(struct ssb_pcicore *pc, u8 device, u8 address)
+{
+        const u16 mdio_control = 0x128;
+        const u16 mdio_data = 0x12C;
+        int max_retries = 10;
+        u16 ret = 0;
+        u32 v;
+        int i;
        v = 0x80; /* Enable Preamble Sequence */
        v |= 0x2; /* MDIO Clock Divisor */
        pcicore_write32(pc, mdio_control, v);
+        if (pc->dev->id.revision >= 10) {
+                max_retries = 200;
+                ssb_pcie_mdio_set_phy(pc, device);
+        }
        v = (1 << 30); /* Start of Transaction */
-        v |= (1 << 28); /* Write Transaction */
+        v |= (1 << 29); /* Read Transaction */
        v |= (1 << 17); /* Turnaround */
-        v |= (u32)device << 22;
+        if (pc->dev->id.revision < 10)
+                v |= (u32)device << 22;
        v |= (u32)address << 18;
-        v |= data;
        pcicore_write32(pc, mdio_data, v);
        /* Wait for the device to complete the transaction */
        udelay(10);
-        for (i = 0; i < 10; i++) {
+        for (i = 0; i < max_retries; i++) {
                v = pcicore_read32(pc, mdio_control);
-                if (v & 0x100 /* Trans complete */)
+                if (v & 0x100 /* Trans complete */) {
+                        udelay(10);
+                        ret = pcicore_read32(pc, mdio_data);
                        break;
+                }
                msleep(1);
        }
        pcicore_write32(pc, mdio_control, 0);
+        return ret;
 }
-static void ssb_broadcast_value(struct ssb_device *dev,
+static void ssb_pcie_mdio_write(struct ssb_pcicore *pc, u8 device,
-                                u32 address, u32 data)
+                                u8 address, u16 data)
 {
-        /* This is used for both, PCI and ChipCommon core, so be careful. */
+        const u16 mdio_control = 0x128;
-        BUILD_BUG_ON(SSB_PCICORE_BCAST_ADDR != SSB_CHIPCO_BCAST_ADDR);
+        const u16 mdio_data = 0x12C;
-        BUILD_BUG_ON(SSB_PCICORE_BCAST_DATA != SSB_CHIPCO_BCAST_DATA);
+        int max_retries = 10;
+        u32 v;
-        ssb_write32(dev, SSB_PCICORE_BCAST_ADDR, address);
+        int i;
-        ssb_read32(dev, SSB_PCICORE_BCAST_ADDR); /* flush */
-        ssb_write32(dev, SSB_PCICORE_BCAST_DATA, data);
-        ssb_read32(dev, SSB_PCICORE_BCAST_DATA); /* flush */
-}
-static void ssb_commit_settings(struct ssb_bus *bus)
+        v = 0x80; /* Enable Preamble Sequence */
-{
+        v |= 0x2; /* MDIO Clock Divisor */
-        struct ssb_device *dev;
+        pcicore_write32(pc, mdio_control, v);
-        dev = bus->chipco.dev ? bus->chipco.dev : bus->pcicore.dev;
+        if (pc->dev->id.revision >= 10) {
-        if (WARN_ON(!dev))
+                max_retries = 200;
-                return;
+                ssb_pcie_mdio_set_phy(pc, device);
-        /* This forces an update of the cached registers. */
+        }
-        ssb_broadcast_value(dev, 0xFD8, 0);
+        v = (1 << 30); /* Start of Transaction */
+        v |= (1 << 28); /* Write Transaction */
+        v |= (1 << 17); /* Turnaround */
+        if (pc->dev->id.revision < 10)
+                v |= (u32)device << 22;
+        v |= (u32)address << 18;
+        v |= data;
+        pcicore_write32(pc, mdio_data, v);
+        /* Wait for the device to complete the transaction */
+        udelay(10);
+        for (i = 0; i < max_retries; i++) {
+                v = pcicore_read32(pc, mdio_control);
+                if (v & 0x100 /* Trans complete */)
+                        break;
+                msleep(1);
+        }
+        pcicore_write32(pc, mdio_control, 0);
 }
 int ssb_pcicore_dev_irqvecs_enable(struct ssb_pcicore *pc,
@@ -550,48 +707,10 @@ int ssb_pcicore_dev_irqvecs_enable(struct ssb_pcicore *pc,
        if (pc->setup_done)
                goto out;
        if (pdev->id.coreid == SSB_DEV_PCI) {
-                tmp = pcicore_read32(pc, SSB_PCICORE_SBTOPCI2);
+                ssb_pcicore_pci_setup_workarounds(pc);
-                tmp |= SSB_PCICORE_SBTOPCI_PREF;
-                tmp |= SSB_PCICORE_SBTOPCI_BURST;
-                pcicore_write32(pc, SSB_PCICORE_SBTOPCI2, tmp);
-                if (pdev->id.revision < 5) {
-                        tmp = ssb_read32(pdev, SSB_IMCFGLO);
-                        tmp &= ~SSB_IMCFGLO_SERTO;
-                        tmp |= 2;
-                        tmp &= ~SSB_IMCFGLO_REQTO;
-                        tmp |= 3 << SSB_IMCFGLO_REQTO_SHIFT;
-                        ssb_write32(pdev, SSB_IMCFGLO, tmp);
-                        ssb_commit_settings(bus);
-                } else if (pdev->id.revision >= 11) {
-                        tmp = pcicore_read32(pc, SSB_PCICORE_SBTOPCI2);
-                        tmp |= SSB_PCICORE_SBTOPCI_MRM;
-                        pcicore_write32(pc, SSB_PCICORE_SBTOPCI2, tmp);
-                }
        } else {
                WARN_ON(pdev->id.coreid != SSB_DEV_PCIE);
-                //TODO: Better make defines for all these magic PCIE values.
+                ssb_pcicore_pcie_setup_workarounds(pc);
-                if ((pdev->id.revision == 0) || (pdev->id.revision == 1)) {
-                        /* TLP Workaround register. */
-                        tmp = ssb_pcie_read(pc, 0x4);
-                        tmp |= 0x8;
-                        ssb_pcie_write(pc, 0x4, tmp);
-                }
-                if (pdev->id.revision == 0) {
-                        const u8 serdes_rx_device = 0x1F;
-                        ssb_pcie_mdio_write(pc, serdes_rx_device,
-                                            2 /* Timer */, 0x8128);
-                        ssb_pcie_mdio_write(pc, serdes_rx_device,
-                                            6 /* CDR */, 0x0100);
-                        ssb_pcie_mdio_write(pc, serdes_rx_device,
-                                            7 /* CDR BW */, 0x1466);
-                } else if (pdev->id.revision == 1) {
-                        /* DLLP Link Control register. */
-                        tmp = ssb_pcie_read(pc, 0x100);
-                        tmp |= 0x40;
-                        ssb_pcie_write(pc, 0x100, tmp);
-                }
        }
        pc->setup_done = 1;
 out:
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index e05ba6eefc7e..f8a13f863217 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1117,23 +1117,22 @@ static u32 ssb_tmslow_reject_bitmask(struct ssb_device *dev)
 {
        u32 rev = ssb_read32(dev, SSB_IDLOW) & SSB_IDLOW_SSBREV;
-        /* The REJECT bit changed position in TMSLOW between
+        /* The REJECT bit seems to be different for Backplane rev 2.3 */
-         * Backplane revisions. */
        switch (rev) {
        case SSB_IDLOW_SSBREV_22:
-                return SSB_TMSLOW_REJECT_22;
+        case SSB_IDLOW_SSBREV_24:
+        case SSB_IDLOW_SSBREV_26:
+                return SSB_TMSLOW_REJECT;
        case SSB_IDLOW_SSBREV_23:
                return SSB_TMSLOW_REJECT_23;
-        case SSB_IDLOW_SSBREV_24:     /* TODO - find the proper REJECT bits */
+        case SSB_IDLOW_SSBREV_25:     /* TODO - find the proper REJECT bit */
-        case SSB_IDLOW_SSBREV_25:     /* same here */
-        case SSB_IDLOW_SSBREV_26:     /* same here */
        case SSB_IDLOW_SSBREV_27:     /* same here */
-                return SSB_TMSLOW_REJECT_23;    /* this is a guess */
+                return SSB_TMSLOW_REJECT;       /* this is a guess */
        default:
                printk(KERN_INFO "ssb: Backplane Revision 0x%.8X\n", rev);
                WARN_ON(1);
        }
-        return (SSB_TMSLOW_REJECT_22 | SSB_TMSLOW_REJECT_23);
+        return (SSB_TMSLOW_REJECT | SSB_TMSLOW_REJECT_23);
 }
 int ssb_device_is_enabled(struct ssb_device *dev)
@@ -1309,20 +1308,20 @@ EXPORT_SYMBOL(ssb_bus_may_powerdown);
 int ssb_bus_powerup(struct ssb_bus *bus, bool dynamic_pctl)
 {
-        struct ssb_chipcommon *cc;
        int err;
        enum ssb_clkmode mode;
        err = ssb_pci_xtal(bus, SSB_GPIO_XTAL | SSB_GPIO_PLL, 1);
        if (err)
                goto error;
-        cc = &bus->chipco;
-        mode = dynamic_pctl ? SSB_CLKMODE_DYNAMIC : SSB_CLKMODE_FAST;
-        ssb_chipco_set_clockmode(cc, mode);
 #ifdef CONFIG_SSB_DEBUG
        bus->powered_up = 1;
 #endif
+        mode = dynamic_pctl ? SSB_CLKMODE_DYNAMIC : SSB_CLKMODE_FAST;
+        ssb_chipco_set_clockmode(&bus->chipco, mode);
        return 0;
 error:
        ssb_printk(KERN_ERR PFX "Bus powerup failed\n");
@@ -1330,6 +1329,37 @@ error:
 }
 EXPORT_SYMBOL(ssb_bus_powerup);
+static void ssb_broadcast_value(struct ssb_device *dev,
+                                u32 address, u32 data)
+{
+#ifdef CONFIG_SSB_DRIVER_PCICORE
+        /* This is used for both, PCI and ChipCommon core, so be careful. */
+        BUILD_BUG_ON(SSB_PCICORE_BCAST_ADDR != SSB_CHIPCO_BCAST_ADDR);
+        BUILD_BUG_ON(SSB_PCICORE_BCAST_DATA != SSB_CHIPCO_BCAST_DATA);
+#endif
+        ssb_write32(dev, SSB_CHIPCO_BCAST_ADDR, address);
+        ssb_read32(dev, SSB_CHIPCO_BCAST_ADDR); /* flush */
+        ssb_write32(dev, SSB_CHIPCO_BCAST_DATA, data);
+        ssb_read32(dev, SSB_CHIPCO_BCAST_DATA); /* flush */
+}
+void ssb_commit_settings(struct ssb_bus *bus)
+{
+        struct ssb_device *dev;
+#ifdef CONFIG_SSB_DRIVER_PCICORE
+        dev = bus->chipco.dev ? bus->chipco.dev : bus->pcicore.dev;
+#else
+        dev = bus->chipco.dev;
+#endif
+        if (WARN_ON(!dev))
+                return;
+        /* This forces an update of the cached registers. */
+        ssb_broadcast_value(dev, 0xFD8, 0);
+}
+EXPORT_SYMBOL(ssb_commit_settings);
 u32 ssb_admatch_base(u32 adm)
 {
        u32 base = 0;
diff --git a/drivers/ssb/scan.c b/drivers/ssb/scan.c
index 29884c00c4d5..45e5babd3961 100644
--- a/drivers/ssb/scan.c
+++ b/drivers/ssb/scan.c
@@ -258,7 +258,10 @@ static int we_support_multiple_80211_cores(struct ssb_bus *bus)
 #ifdef CONFIG_SSB_PCIHOST
        if (bus->bustype == SSB_BUSTYPE_PCI) {
                if (bus->host_pci->vendor == PCI_VENDOR_ID_BROADCOM &&
-                    bus->host_pci->device == 0x4324)
+                    ((bus->host_pci->device == 0x4313) ||
+                     (bus->host_pci->device == 0x431A) ||
+                     (bus->host_pci->device == 0x4321) ||
+                     (bus->host_pci->device == 0x4324)))
                        return 1;
        }
 #endif /* CONFIG_SSB_PCIHOST */
@@ -307,7 +310,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
        } else {
                if (bus->bustype == SSB_BUSTYPE_PCI) {
                        bus->chip_id = pcidev_to_chipid(bus->host_pci);
-                        pci_read_config_word(bus->host_pci, PCI_REVISION_ID,
+                        pci_read_config_byte(bus->host_pci, PCI_REVISION_ID,
                                             &bus->chip_rev);
                        bus->chip_package = 0;
                } else {
diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c
index 33973568214f..aaa81883f0ad 100644
--- a/drivers/staging/hv/netvsc_drv.c
+++ b/drivers/staging/hv/netvsc_drv.c
@@ -317,8 +317,6 @@ static void netvsc_get_drvinfo(struct net_device *net,
 static const struct ethtool_ops ethtool_ops = {
        .get_drvinfo    = netvsc_get_drvinfo,
-        .get_sg         = ethtool_op_get_sg,
-        .set_sg         = ethtool_op_set_sg,
        .get_link       = ethtool_op_get_link,
 };
@@ -406,6 +404,7 @@ static int netvsc_probe(struct device *device)
        net->netdev_ops = &device_ops;
        /* TODO: Add GSO and Checksum offload */
+        net->hw_features = NETIF_F_SG;
        net->features = NETIF_F_SG;
        SET_ETHTOOL_OPS(net, &ethtool_ops);
author	Linus Torvalds <torvalds@linux-foundation.org>	2011-05-20 16:43:21 -0400
committer	Linus Torvalds <torvalds@linux-foundation.org>	2011-05-20 16:43:21 -0400
commit	06f4e926d256d902dd9a53dcb400fd74974ce087 (patch)
tree	0b438b67f5f0eff6fd617bc497a9dace6164a488 /drivers
parent	8e7bfcbab3825d1b404d615cb1b54f44ff81f981 (diff)
parent	d93515611bbc70c2fe4db232e5feb448ed8e4cc9 (diff)