5 files changed, 86 insertions, 116 deletions

diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c
index eb518f0c5e01..cd22a54b2f14 100644
--- a/sound/soc/jz4740/jz4740-i2s.c
+++ b/sound/soc/jz4740/jz4740-i2s.c
@@ -28,7 +28,6 @@
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include <sound/soc.h>
-#include <sound/soc-dapm.h>
 #include <sound/initval.h>
 
 #include "jz4740-i2s.h"
@@ -106,15 +105,10 @@ static inline void jz4740_i2s_write(const struct jz4740_i2s *i2s,
         writel(value, i2s->base + reg);
 }
 
-static inline struct jz4740_i2s *jz4740_dai_to_i2s(struct snd_soc_dai *dai)
-{
-        return dai->private_data;
-}
-
 static int jz4740_i2s_startup(struct snd_pcm_substream *substream,
         struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         uint32_t conf, ctrl;
 
         if (dai->active)
@@ -136,10 +130,10 @@ static int jz4740_i2s_startup(struct snd_pcm_substream *substream,
 static void jz4740_i2s_shutdown(struct snd_pcm_substream *substream,
         struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         uint32_t conf;
 
-        if (!dai->active)
+        if (dai->active)
                 return;
 
         conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
@@ -152,7 +146,7 @@ static void jz4740_i2s_shutdown(struct snd_pcm_substream *substream,
 static int jz4740_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
         struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
 
         uint32_t ctrl;
         uint32_t mask;
@@ -186,7 +180,7 @@ static int jz4740_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
 
 static int jz4740_i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
 
         uint32_t format = 0;
         uint32_t conf;
@@ -238,7 +232,7 @@ static int jz4740_i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 static int jz4740_i2s_hw_params(struct snd_pcm_substream *substream,
         struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         enum jz4740_dma_width dma_width;
         struct jz4740_pcm_config *pcm_config;
         unsigned int sample_size;
@@ -288,7 +282,7 @@ static int jz4740_i2s_hw_params(struct snd_pcm_substream *substream,
 static int jz4740_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id,
         unsigned int freq, int dir)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         struct clk *parent;
         int ret = 0;
 
@@ -312,7 +306,7 @@ static int jz4740_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id,
 
 static int jz4740_i2s_suspend(struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         uint32_t conf;
 
         if (dai->active) {
@@ -330,7 +324,7 @@ static int jz4740_i2s_suspend(struct snd_soc_dai *dai)
 
 static int jz4740_i2s_resume(struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         uint32_t conf;
 
         clk_enable(i2s->clk_aic);
@@ -346,11 +340,38 @@ static int jz4740_i2s_resume(struct snd_soc_dai *dai)
         return 0;
 }
 
-static int jz4740_i2s_probe(struct platform_device *pdev, struct snd_soc_dai *dai)
+static void jz4740_i2c_init_pcm_config(struct jz4740_i2s *i2s)
+{
+        struct jz4740_dma_config *dma_config;
+
+        /* Playback */
+        dma_config = &i2s->pcm_config_playback.dma_config;
+        dma_config->src_width = JZ4740_DMA_WIDTH_32BIT,
+        dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
+        dma_config->request_type = JZ4740_DMA_TYPE_AIC_TRANSMIT;
+        dma_config->flags = JZ4740_DMA_SRC_AUTOINC;
+        dma_config->mode = JZ4740_DMA_MODE_SINGLE;
+        i2s->pcm_config_playback.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
+
+        /* Capture */
+        dma_config = &i2s->pcm_config_capture.dma_config;
+        dma_config->dst_width = JZ4740_DMA_WIDTH_32BIT,
+        dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
+        dma_config->request_type = JZ4740_DMA_TYPE_AIC_RECEIVE;
+        dma_config->flags = JZ4740_DMA_DST_AUTOINC;
+        dma_config->mode = JZ4740_DMA_MODE_SINGLE;
+        i2s->pcm_config_capture.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
+}
+
+static int jz4740_i2s_dai_probe(struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         uint32_t conf;
 
+        clk_enable(i2s->clk_aic);
+
+        jz4740_i2c_init_pcm_config(i2s);
+
         conf = (7 << JZ_AIC_CONF_FIFO_RX_THRESHOLD_OFFSET) |
                 (8 << JZ_AIC_CONF_FIFO_TX_THRESHOLD_OFFSET) |
                 JZ_AIC_CONF_OVERFLOW_PLAY_LAST |
@@ -363,6 +384,14 @@ static int jz4740_i2s_probe(struct platform_device *pdev, struct snd_soc_dai *da
         return 0;
 }
 
+static int jz4740_i2s_dai_remove(struct snd_soc_dai *dai)
+{
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
+
+        clk_disable(i2s->clk_aic);
+        return 0;
+}
+
 static struct snd_soc_dai_ops jz4740_i2s_dai_ops = {
         .startup = jz4740_i2s_startup,
         .shutdown = jz4740_i2s_shutdown,
@@ -375,9 +404,9 @@ static struct snd_soc_dai_ops jz4740_i2s_dai_ops = {
 #define JZ4740_I2S_FMTS (SNDRV_PCM_FMTBIT_S8 | \
                 SNDRV_PCM_FMTBIT_S16_LE)
 
-struct snd_soc_dai jz4740_i2s_dai = {
-        .name = "jz4740-i2s",
-        .probe = jz4740_i2s_probe,
+static struct snd_soc_dai_driver jz4740_i2s_dai = {
+        .probe = jz4740_i2s_dai_probe,
+        .remove = jz4740_i2s_dai_remove,
         .playback = {
                 .channels_min = 1,
                 .channels_max = 2,
@@ -395,30 +424,6 @@ struct snd_soc_dai jz4740_i2s_dai = {
         .suspend = jz4740_i2s_suspend,
         .resume = jz4740_i2s_resume,
 };
-EXPORT_SYMBOL_GPL(jz4740_i2s_dai);
-
-static void __devinit jz4740_i2c_init_pcm_config(struct jz4740_i2s *i2s)
-{
-        struct jz4740_dma_config *dma_config;
-
-        /* Playback */
-        dma_config = &i2s->pcm_config_playback.dma_config;
-        dma_config->src_width = JZ4740_DMA_WIDTH_32BIT,
-        dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
-        dma_config->request_type = JZ4740_DMA_TYPE_AIC_TRANSMIT;
-        dma_config->flags = JZ4740_DMA_SRC_AUTOINC;
-        dma_config->mode = JZ4740_DMA_MODE_SINGLE;
-        i2s->pcm_config_playback.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
-
-        /* Capture */
-        dma_config = &i2s->pcm_config_capture.dma_config;
-        dma_config->dst_width = JZ4740_DMA_WIDTH_32BIT,
-        dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
-        dma_config->request_type = JZ4740_DMA_TYPE_AIC_RECEIVE;
-        dma_config->flags = JZ4740_DMA_DST_AUTOINC;
-        dma_config->mode = JZ4740_DMA_MODE_SINGLE;
-        i2s->pcm_config_capture.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
-}
 
 static int __devinit jz4740_i2s_dev_probe(struct platform_device *pdev)
 {
@@ -463,24 +468,17 @@ static int __devinit jz4740_i2s_dev_probe(struct platform_device *pdev)
                 goto err_clk_put_aic;
         }
 
-        clk_enable(i2s->clk_aic);
-
-        jz4740_i2c_init_pcm_config(i2s);
-
-        jz4740_i2s_dai.private_data = i2s;
-        ret = snd_soc_register_dai(&jz4740_i2s_dai);
+        platform_set_drvdata(pdev, i2s);
+        ret = snd_soc_register_dai(&pdev->dev, &jz4740_i2s_dai);
 
         if (ret) {
                 dev_err(&pdev->dev, "Failed to register DAI\n");
                 goto err_clk_put_i2s;
         }
 
-        platform_set_drvdata(pdev, i2s);
-
         return 0;
 
 err_clk_put_i2s:
-        clk_disable(i2s->clk_aic);
         clk_put(i2s->clk_i2s);
 err_clk_put_aic:
         clk_put(i2s->clk_aic);
@@ -498,9 +496,8 @@ static int __devexit jz4740_i2s_dev_remove(struct platform_device *pdev)
 {
         struct jz4740_i2s *i2s = platform_get_drvdata(pdev);
 
-        snd_soc_unregister_dai(&jz4740_i2s_dai);
+        snd_soc_unregister_dai(&pdev->dev);
 
-        clk_disable(i2s->clk_aic);
         clk_put(i2s->clk_i2s);
         clk_put(i2s->clk_aic);
 
diff --git a/sound/soc/jz4740/jz4740-i2s.h b/sound/soc/jz4740/jz4740-i2s.h
index da22ed88a589..5e49339d8b93 100644
--- a/sound/soc/jz4740/jz4740-i2s.h
+++ b/sound/soc/jz4740/jz4740-i2s.h
@@ -13,6 +13,4 @@
 
 #define JZ4740_I2S_BIT_CLK              0
 
-extern struct snd_soc_dai jz4740_i2s_dai;
-
 #endif
diff --git a/sound/soc/jz4740/jz4740-pcm.c b/sound/soc/jz4740/jz4740-pcm.c
index ee68d850c8dd..fb1483f7c966 100644
--- a/sound/soc/jz4740/jz4740-pcm.c
+++ b/sound/soc/jz4740/jz4740-pcm.c
@@ -109,7 +109,7 @@ static int jz4740_pcm_hw_params(struct snd_pcm_substream *substream,
         struct snd_soc_pcm_runtime *rtd = substream->private_data;
         struct jz4740_pcm_config *config;
 
-        config = snd_soc_dai_get_dma_data(rtd->dai->cpu_dai, substream);
+        config = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream);
 
         if (!config)
                 return 0;
@@ -310,14 +310,14 @@ int jz4740_pcm_new(struct snd_card *card, struct snd_soc_dai *dai,
         if (!card->dev->coherent_dma_mask)
                 card->dev->coherent_dma_mask = DMA_BIT_MASK(32);
 
-        if (dai->playback.channels_min) {
+        if (dai->driver->playback.channels_min) {
                 ret = jz4740_pcm_preallocate_dma_buffer(pcm,
                         SNDRV_PCM_STREAM_PLAYBACK);
                 if (ret)
                         goto err;
         }
 
-        if (dai->capture.channels_min) {
+        if (dai->driver->capture.channels_min) {
                 ret = jz4740_pcm_preallocate_dma_buffer(pcm,
                         SNDRV_PCM_STREAM_CAPTURE);
                 if (ret)
@@ -328,22 +328,20 @@ err:
         return ret;
 }
 
-struct snd_soc_platform jz4740_soc_platform = {
-                .name           = "jz4740-pcm",
-                .pcm_ops        = &jz4740_pcm_ops,
+static struct snd_soc_platform_driver jz4740_soc_platform = {
+                .ops            = &jz4740_pcm_ops,
                 .pcm_new        = jz4740_pcm_new,
                 .pcm_free       = jz4740_pcm_free,
 };
-EXPORT_SYMBOL_GPL(jz4740_soc_platform);
 
 static int __devinit jz4740_pcm_probe(struct platform_device *pdev)
 {
-        return snd_soc_register_platform(&jz4740_soc_platform);
+        return snd_soc_register_platform(&pdev->dev, &jz4740_soc_platform);
 }
 
 static int __devexit jz4740_pcm_remove(struct platform_device *pdev)
 {
-        snd_soc_unregister_platform(&jz4740_soc_platform);
+        snd_soc_unregister_platform(&pdev->dev);
         return 0;
 }
 
@@ -351,7 +349,7 @@ static struct platform_driver jz4740_pcm_driver = {
         .probe = jz4740_pcm_probe,
         .remove = __devexit_p(jz4740_pcm_remove),
         .driver = {
-                .name = "jz4740-pcm",
+                .name = "jz4740-pcm-audio",
                 .owner = THIS_MODULE,
         },
 };
diff --git a/sound/soc/jz4740/jz4740-pcm.h b/sound/soc/jz4740/jz4740-pcm.h
index e3f221e2779c..1220cbb4382c 100644
--- a/sound/soc/jz4740/jz4740-pcm.h
+++ b/sound/soc/jz4740/jz4740-pcm.h
@@ -11,8 +11,6 @@
 #include <linux/dma-mapping.h>
 #include <asm/mach-jz4740/dma.h>
 
-/* platform data */
-extern struct snd_soc_platform jz4740_soc_platform;
 
 struct jz4740_pcm_config {
         struct jz4740_dma_config dma_config;
diff --git a/sound/soc/jz4740/qi_lb60.c b/sound/soc/jz4740/qi_lb60.c
index f15f4918f15f..c5fc339f68f1 100644
--- a/sound/soc/jz4740/qi_lb60.c
+++ b/sound/soc/jz4740/qi_lb60.c
@@ -19,25 +19,15 @@
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/soc.h>
-#include <sound/soc-dapm.h>
 #include <linux/gpio.h>
 
-#include "../codecs/jz4740.h"
-#include "jz4740-pcm.h"
-#include "jz4740-i2s.h"
-
-
 #define QI_LB60_SND_GPIO JZ_GPIO_PORTB(29)
 #define QI_LB60_AMP_GPIO JZ_GPIO_PORTD(4)
 
 static int qi_lb60_spk_event(struct snd_soc_dapm_widget *widget,
                              struct snd_kcontrol *ctrl, int event)
 {
-        int on = 0;
-        if (event & SND_SOC_DAPM_POST_PMU)
-                on = 1;
-        else if (event & SND_SOC_DAPM_PRE_PMD)
-                on = 0;
+        int on = !SND_SOC_DAPM_EVENT_OFF(event);
 
         gpio_set_value(QI_LB60_SND_GPIO, on);
         gpio_set_value(QI_LB60_AMP_GPIO, on);
@@ -60,13 +50,15 @@ static const struct snd_soc_dapm_route qi_lb60_routes[] = {
                         SND_SOC_DAIFMT_NB_NF | \
                         SND_SOC_DAIFMT_CBM_CFM)
 
-static int qi_lb60_codec_init(struct snd_soc_codec *codec)
+static int qi_lb60_codec_init(struct snd_soc_pcm_runtime *rtd)
 {
+        struct snd_soc_codec *codec = rtd->codec;
+        struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
+        struct snd_soc_dapm_context *dapm = &codec->dapm;
         int ret;
-        struct snd_soc_dai *cpu_dai = codec->socdev->card->dai_link->cpu_dai;
 
-        snd_soc_dapm_nc_pin(codec, "LIN");
-        snd_soc_dapm_nc_pin(codec, "RIN");
+        snd_soc_dapm_nc_pin(dapm, "LIN");
+        snd_soc_dapm_nc_pin(dapm, "RIN");
 
         ret = snd_soc_dai_set_fmt(cpu_dai, QI_LB60_DAIFMT);
         if (ret < 0) {
@@ -74,18 +66,16 @@ static int qi_lb60_codec_init(struct snd_soc_codec *codec)
                 return ret;
         }
 
-        snd_soc_dapm_new_controls(codec, qi_lb60_widgets, ARRAY_SIZE(qi_lb60_widgets));
-        snd_soc_dapm_add_routes(codec, qi_lb60_routes, ARRAY_SIZE(qi_lb60_routes));
-        snd_soc_dapm_sync(codec);
-
         return 0;
 }
 
 static struct snd_soc_dai_link qi_lb60_dai = {
         .name = "jz4740",
         .stream_name = "jz4740",
-        .cpu_dai = &jz4740_i2s_dai,
-        .codec_dai = &jz4740_codec_dai,
+        .cpu_dai_name = "jz4740-i2s",
+        .platform_name = "jz4740-pcm-audio",
+        .codec_dai_name = "jz4740-hifi",
+        .codec_name = "jz4740-codec",
         .init = qi_lb60_codec_init,
 };
 
@@ -93,16 +83,20 @@ static struct snd_soc_card qi_lb60 = {
         .name = "QI LB60",
         .dai_link = &qi_lb60_dai,
         .num_links = 1,
-        .platform = &jz4740_soc_platform,
-};
 
-static struct snd_soc_device qi_lb60_snd_devdata = {
-        .card = &qi_lb60,
-        .codec_dev = &soc_codec_dev_jz4740_codec,
+        .dapm_widgets = qi_lb60_widgets,
+        .num_dapm_widgets = ARRAY_SIZE(qi_lb60_widgets),
+        .dapm_routes = qi_lb60_routes,
+        .num_dapm_routes = ARRAY_SIZE(qi_lb60_routes),
 };
 
 static struct platform_device *qi_lb60_snd_device;
 
+static const struct gpio qi_lb60_gpios[] = {
+        { QI_LB60_SND_GPIO, GPIOF_OUT_INIT_LOW, "SND" },
+        { QI_LB60_AMP_GPIO, GPIOF_OUT_INIT_LOW, "AMP" },
+};
+
 static int __init qi_lb60_init(void)
 {
         int ret;
@@ -112,25 +106,13 @@ static int __init qi_lb60_init(void)
         if (!qi_lb60_snd_device)
                 return -ENOMEM;
 
-        ret = gpio_request(QI_LB60_SND_GPIO, "SND");
+        ret = gpio_request_array(qi_lb60_gpios, ARRAY_SIZE(qi_lb60_gpios));
         if (ret) {
-                pr_err("qi_lb60 snd: Failed to request SND GPIO(%d): %d\n",
-                                QI_LB60_SND_GPIO, ret);
+                pr_err("qi_lb60 snd: Failed to request gpios: %d\n", ret);
                 goto err_device_put;
         }
 
-        ret = gpio_request(QI_LB60_AMP_GPIO, "AMP");
-        if (ret) {
-                pr_err("qi_lb60 snd: Failed to request AMP GPIO(%d): %d\n",
-                                QI_LB60_AMP_GPIO, ret);
-                goto err_gpio_free_snd;
-        }
-
-        gpio_direction_output(QI_LB60_SND_GPIO, 0);
-        gpio_direction_output(QI_LB60_AMP_GPIO, 0);
-
-        platform_set_drvdata(qi_lb60_snd_device, &qi_lb60_snd_devdata);
-        qi_lb60_snd_devdata.dev = &qi_lb60_snd_device->dev;
+        platform_set_drvdata(qi_lb60_snd_device, &qi_lb60);
 
         ret = platform_device_add(qi_lb60_snd_device);
         if (ret) {
@@ -142,10 +124,8 @@ static int __init qi_lb60_init(void)
 
 err_unset_pdata:
         platform_set_drvdata(qi_lb60_snd_device, NULL);
-/*err_gpio_free_amp:*/
-        gpio_free(QI_LB60_AMP_GPIO);
-err_gpio_free_snd:
-        gpio_free(QI_LB60_SND_GPIO);
+/*err_gpio_free_array:*/
+        gpio_free_array(qi_lb60_gpios, ARRAY_SIZE(qi_lb60_gpios));
 err_device_put:
         platform_device_put(qi_lb60_snd_device);
 
@@ -155,9 +135,8 @@ module_init(qi_lb60_init);
 
 static void __exit qi_lb60_exit(void)
 {
-        gpio_free(QI_LB60_AMP_GPIO);
-        gpio_free(QI_LB60_SND_GPIO);
         platform_device_unregister(qi_lb60_snd_device);
+        gpio_free_array(qi_lb60_gpios, ARRAY_SIZE(qi_lb60_gpios));
 }
 module_exit(qi_lb60_exit);