1 files changed, 52 insertions, 55 deletions

diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c
index eb518f0c5e01..cd22a54b2f14 100644
--- a/sound/soc/jz4740/jz4740-i2s.c
+++ b/sound/soc/jz4740/jz4740-i2s.c
@@ -28,7 +28,6 @@
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include <sound/soc.h>
-#include <sound/soc-dapm.h>
 #include <sound/initval.h>
 
 #include "jz4740-i2s.h"
@@ -106,15 +105,10 @@ static inline void jz4740_i2s_write(const struct jz4740_i2s *i2s,
         writel(value, i2s->base + reg);
 }
 
-static inline struct jz4740_i2s *jz4740_dai_to_i2s(struct snd_soc_dai *dai)
-{
-        return dai->private_data;
-}
-
 static int jz4740_i2s_startup(struct snd_pcm_substream *substream,
         struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         uint32_t conf, ctrl;
 
         if (dai->active)
@@ -136,10 +130,10 @@ static int jz4740_i2s_startup(struct snd_pcm_substream *substream,
 static void jz4740_i2s_shutdown(struct snd_pcm_substream *substream,
         struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         uint32_t conf;
 
-        if (!dai->active)
+        if (dai->active)
                 return;
 
         conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
@@ -152,7 +146,7 @@ static void jz4740_i2s_shutdown(struct snd_pcm_substream *substream,
 static int jz4740_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
         struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
 
         uint32_t ctrl;
         uint32_t mask;
@@ -186,7 +180,7 @@ static int jz4740_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
 
 static int jz4740_i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
 
         uint32_t format = 0;
         uint32_t conf;
@@ -238,7 +232,7 @@ static int jz4740_i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 static int jz4740_i2s_hw_params(struct snd_pcm_substream *substream,
         struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         enum jz4740_dma_width dma_width;
         struct jz4740_pcm_config *pcm_config;
         unsigned int sample_size;
@@ -288,7 +282,7 @@ static int jz4740_i2s_hw_params(struct snd_pcm_substream *substream,
 static int jz4740_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id,
         unsigned int freq, int dir)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         struct clk *parent;
         int ret = 0;
 
@@ -312,7 +306,7 @@ static int jz4740_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id,
 
 static int jz4740_i2s_suspend(struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         uint32_t conf;
 
         if (dai->active) {
@@ -330,7 +324,7 @@ static int jz4740_i2s_suspend(struct snd_soc_dai *dai)
 
 static int jz4740_i2s_resume(struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         uint32_t conf;
 
         clk_enable(i2s->clk_aic);
@@ -346,11 +340,38 @@ static int jz4740_i2s_resume(struct snd_soc_dai *dai)
         return 0;
 }
 
-static int jz4740_i2s_probe(struct platform_device *pdev, struct snd_soc_dai *dai)
+static void jz4740_i2c_init_pcm_config(struct jz4740_i2s *i2s)
+{
+        struct jz4740_dma_config *dma_config;
+
+        /* Playback */
+        dma_config = &i2s->pcm_config_playback.dma_config;
+        dma_config->src_width = JZ4740_DMA_WIDTH_32BIT,
+        dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
+        dma_config->request_type = JZ4740_DMA_TYPE_AIC_TRANSMIT;
+        dma_config->flags = JZ4740_DMA_SRC_AUTOINC;
+        dma_config->mode = JZ4740_DMA_MODE_SINGLE;
+        i2s->pcm_config_playback.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
+
+        /* Capture */
+        dma_config = &i2s->pcm_config_capture.dma_config;
+        dma_config->dst_width = JZ4740_DMA_WIDTH_32BIT,
+        dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
+        dma_config->request_type = JZ4740_DMA_TYPE_AIC_RECEIVE;
+        dma_config->flags = JZ4740_DMA_DST_AUTOINC;
+        dma_config->mode = JZ4740_DMA_MODE_SINGLE;
+        i2s->pcm_config_capture.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
+}
+
+static int jz4740_i2s_dai_probe(struct snd_soc_dai *dai)
 {
-        struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
         uint32_t conf;
 
+        clk_enable(i2s->clk_aic);
+
+        jz4740_i2c_init_pcm_config(i2s);
+
         conf = (7 << JZ_AIC_CONF_FIFO_RX_THRESHOLD_OFFSET) |
                 (8 << JZ_AIC_CONF_FIFO_TX_THRESHOLD_OFFSET) |
                 JZ_AIC_CONF_OVERFLOW_PLAY_LAST |
@@ -363,6 +384,14 @@ static int jz4740_i2s_probe(struct platform_device *pdev, struct snd_soc_dai *da
         return 0;
 }
 
+static int jz4740_i2s_dai_remove(struct snd_soc_dai *dai)
+{
+        struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
+
+        clk_disable(i2s->clk_aic);
+        return 0;
+}
+
 static struct snd_soc_dai_ops jz4740_i2s_dai_ops = {
         .startup = jz4740_i2s_startup,
         .shutdown = jz4740_i2s_shutdown,
@@ -375,9 +404,9 @@ static struct snd_soc_dai_ops jz4740_i2s_dai_ops = {
 #define JZ4740_I2S_FMTS (SNDRV_PCM_FMTBIT_S8 | \
                 SNDRV_PCM_FMTBIT_S16_LE)
 
-struct snd_soc_dai jz4740_i2s_dai = {
-        .name = "jz4740-i2s",
-        .probe = jz4740_i2s_probe,
+static struct snd_soc_dai_driver jz4740_i2s_dai = {
+        .probe = jz4740_i2s_dai_probe,
+        .remove = jz4740_i2s_dai_remove,
         .playback = {
                 .channels_min = 1,
                 .channels_max = 2,
@@ -395,30 +424,6 @@ struct snd_soc_dai jz4740_i2s_dai = {
         .suspend = jz4740_i2s_suspend,
         .resume = jz4740_i2s_resume,
 };
-EXPORT_SYMBOL_GPL(jz4740_i2s_dai);
-
-static void __devinit jz4740_i2c_init_pcm_config(struct jz4740_i2s *i2s)
-{
-        struct jz4740_dma_config *dma_config;
-
-        /* Playback */
-        dma_config = &i2s->pcm_config_playback.dma_config;
-        dma_config->src_width = JZ4740_DMA_WIDTH_32BIT,
-        dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
-        dma_config->request_type = JZ4740_DMA_TYPE_AIC_TRANSMIT;
-        dma_config->flags = JZ4740_DMA_SRC_AUTOINC;
-        dma_config->mode = JZ4740_DMA_MODE_SINGLE;
-        i2s->pcm_config_playback.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
-
-        /* Capture */
-        dma_config = &i2s->pcm_config_capture.dma_config;
-        dma_config->dst_width = JZ4740_DMA_WIDTH_32BIT,
-        dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
-        dma_config->request_type = JZ4740_DMA_TYPE_AIC_RECEIVE;
-        dma_config->flags = JZ4740_DMA_DST_AUTOINC;
-        dma_config->mode = JZ4740_DMA_MODE_SINGLE;
-        i2s->pcm_config_capture.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
-}
 
 static int __devinit jz4740_i2s_dev_probe(struct platform_device *pdev)
 {
@@ -463,24 +468,17 @@ static int __devinit jz4740_i2s_dev_probe(struct platform_device *pdev)
                 goto err_clk_put_aic;
         }
 
-        clk_enable(i2s->clk_aic);
-
-        jz4740_i2c_init_pcm_config(i2s);
-
-        jz4740_i2s_dai.private_data = i2s;
-        ret = snd_soc_register_dai(&jz4740_i2s_dai);
+        platform_set_drvdata(pdev, i2s);
+        ret = snd_soc_register_dai(&pdev->dev, &jz4740_i2s_dai);
 
         if (ret) {
                 dev_err(&pdev->dev, "Failed to register DAI\n");
                 goto err_clk_put_i2s;
         }
 
-        platform_set_drvdata(pdev, i2s);
-
         return 0;
 
 err_clk_put_i2s:
-        clk_disable(i2s->clk_aic);
         clk_put(i2s->clk_i2s);
 err_clk_put_aic:
         clk_put(i2s->clk_aic);
@@ -498,9 +496,8 @@ static int __devexit jz4740_i2s_dev_remove(struct platform_device *pdev)
 {
         struct jz4740_i2s *i2s = platform_get_drvdata(pdev);
 
-        snd_soc_unregister_dai(&jz4740_i2s_dai);
+        snd_soc_unregister_dai(&pdev->dev);
 
-        clk_disable(i2s->clk_aic);
         clk_put(i2s->clk_i2s);
         clk_put(i2s->clk_aic);