diff options
Diffstat (limited to 'drivers/ata/pata_ali.c')
-rw-r--r-- | drivers/ata/pata_ali.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c index 1432dc9d0ab8..dc61b72f751c 100644 --- a/drivers/ata/pata_ali.c +++ b/drivers/ata/pata_ali.c | |||
@@ -159,8 +159,7 @@ static void ali_fifo_control(struct ata_port *ap, struct ata_device *adev, int o | |||
159 | * ali_program_modes - load mode registers | 159 | * ali_program_modes - load mode registers |
160 | * @ap: ALi channel to load | 160 | * @ap: ALi channel to load |
161 | * @adev: Device the timing is for | 161 | * @adev: Device the timing is for |
162 | * @cmd: Command timing | 162 | * @t: timing data |
163 | * @data: Data timing | ||
164 | * @ultra: UDMA timing or zero for off | 163 | * @ultra: UDMA timing or zero for off |
165 | * | 164 | * |
166 | * Loads the timing registers for cmd/data and disable UDMA if | 165 | * Loads the timing registers for cmd/data and disable UDMA if |
@@ -202,8 +201,7 @@ static void ali_program_modes(struct ata_port *ap, struct ata_device *adev, stru | |||
202 | * @ap: ATA interface | 201 | * @ap: ATA interface |
203 | * @adev: ATA device | 202 | * @adev: ATA device |
204 | * | 203 | * |
205 | * Program the ALi registers for PIO mode. FIXME: add timings for | 204 | * Program the ALi registers for PIO mode. |
206 | * PIO5. | ||
207 | */ | 205 | */ |
208 | 206 | ||
209 | static void ali_set_piomode(struct ata_port *ap, struct ata_device *adev) | 207 | static void ali_set_piomode(struct ata_port *ap, struct ata_device *adev) |
@@ -237,7 +235,7 @@ static void ali_set_piomode(struct ata_port *ap, struct ata_device *adev) | |||
237 | * @ap: ATA interface | 235 | * @ap: ATA interface |
238 | * @adev: ATA device | 236 | * @adev: ATA device |
239 | * | 237 | * |
240 | * FIXME: MWDMA timings | 238 | * Program the ALi registers for DMA mode. |
241 | */ | 239 | */ |
242 | 240 | ||
243 | static void ali_set_dmamode(struct ata_port *ap, struct ata_device *adev) | 241 | static void ali_set_dmamode(struct ata_port *ap, struct ata_device *adev) |
@@ -453,7 +451,9 @@ static void ali_init_chipset(struct pci_dev *pdev) | |||
453 | /* Clear CD-ROM DMA write bit */ | 451 | /* Clear CD-ROM DMA write bit */ |
454 | tmp &= 0x7F; | 452 | tmp &= 0x7F; |
455 | /* Cable and UDMA */ | 453 | /* Cable and UDMA */ |
456 | pci_write_config_byte(pdev, 0x4B, tmp | 0x09); | 454 | if (pdev->revision >= 0xc2) |
455 | tmp |= 0x01; | ||
456 | pci_write_config_byte(pdev, 0x4B, tmp | 0x08); | ||
457 | /* | 457 | /* |
458 | * CD_ROM DMA on (0x53 bit 0). Enable this even if we want | 458 | * CD_ROM DMA on (0x53 bit 0). Enable this even if we want |
459 | * to use PIO. 0x53 bit 1 (rev 20 only) - enable FIFO control | 459 | * to use PIO. 0x53 bit 1 (rev 20 only) - enable FIFO control |
@@ -583,7 +583,7 @@ static int ali_init_one(struct pci_dev *pdev, const struct pci_device_id *id) | |||
583 | ppi[0] = &info_20_udma; | 583 | ppi[0] = &info_20_udma; |
584 | } | 584 | } |
585 | 585 | ||
586 | return ata_pci_sff_init_one(pdev, ppi, &ali_sht, NULL); | 586 | return ata_pci_sff_init_one(pdev, ppi, &ali_sht, NULL, 0); |
587 | } | 587 | } |
588 | 588 | ||
589 | #ifdef CONFIG_PM | 589 | #ifdef CONFIG_PM |