diff options
author | Yunlong Song <yunlong.song@huawei.com> | 2015-03-18 09:35:55 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-03-19 12:52:54 -0400 |
commit | 1f9975f14ce4f7258db1cb0eea8fba17482e331e (patch) | |
tree | cf395a9723e615678fe018062c2c47fccda331df /tools | |
parent | 40cae2b779f2826f3d82674027299332c2007716 (diff) |
perf tools: Add the bash completion for listing subsubcommands of perf test
The bash completion does not support listing subsubcommands for 'perf
test <TAB>', so fix it.
Example:
Before this patch:
$ perf test <TAB>
$
As shown above, the subsubcommands of perf test does not come out.
After this patch:
$ perf test <TAB>
list
As shown above, the subsubcommands of perf test can come out now.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1426685758-25488-11-git-send-email-yunlong.song@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/perf/perf-completion.sh | 2 | ||||
-rw-r--r-- | tools/perf/tests/builtin-test.c | 5 |
2 files changed, 4 insertions, 3 deletions
diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh index 8739a1345017..35f43fd7a38b 100644 --- a/tools/perf/perf-completion.sh +++ b/tools/perf/perf-completion.sh | |||
@@ -143,7 +143,7 @@ __perf_main () | |||
143 | __perfcomp_colon "$evts" "$cur" | 143 | __perfcomp_colon "$evts" "$cur" |
144 | else | 144 | else |
145 | # List subcommands for perf commands | 145 | # List subcommands for perf commands |
146 | if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched|data|help|script) ]]; then | 146 | if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched|data|help|script|test) ]]; then |
147 | subcmds=$($cmd $prev_skip_opts --list-cmds) | 147 | subcmds=$($cmd $prev_skip_opts --list-cmds) |
148 | __perfcomp_colon "$subcmds" "$cur" | 148 | __perfcomp_colon "$subcmds" "$cur" |
149 | fi | 149 | fi |
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c index 4b7d9ab0f049..ed8e05c6839a 100644 --- a/tools/perf/tests/builtin-test.c +++ b/tools/perf/tests/builtin-test.c | |||
@@ -291,7 +291,7 @@ static int perf_test__list(int argc, const char **argv) | |||
291 | 291 | ||
292 | int cmd_test(int argc, const char **argv, const char *prefix __maybe_unused) | 292 | int cmd_test(int argc, const char **argv, const char *prefix __maybe_unused) |
293 | { | 293 | { |
294 | const char * const test_usage[] = { | 294 | const char *test_usage[] = { |
295 | "perf test [<options>] [{list <test-name-fragment>|[<test-name-fragments>|<test-numbers>]}]", | 295 | "perf test [<options>] [{list <test-name-fragment>|[<test-name-fragments>|<test-numbers>]}]", |
296 | NULL, | 296 | NULL, |
297 | }; | 297 | }; |
@@ -302,13 +302,14 @@ int cmd_test(int argc, const char **argv, const char *prefix __maybe_unused) | |||
302 | "be more verbose (show symbol address, etc)"), | 302 | "be more verbose (show symbol address, etc)"), |
303 | OPT_END() | 303 | OPT_END() |
304 | }; | 304 | }; |
305 | const char * const test_subcommands[] = { "list", NULL }; | ||
305 | struct intlist *skiplist = NULL; | 306 | struct intlist *skiplist = NULL; |
306 | int ret = hists__init(); | 307 | int ret = hists__init(); |
307 | 308 | ||
308 | if (ret < 0) | 309 | if (ret < 0) |
309 | return ret; | 310 | return ret; |
310 | 311 | ||
311 | argc = parse_options(argc, argv, test_options, test_usage, 0); | 312 | argc = parse_options_subcommand(argc, argv, test_options, test_subcommands, test_usage, 0); |
312 | if (argc >= 1 && !strcmp(argv[0], "list")) | 313 | if (argc >= 1 && !strcmp(argv[0], "list")) |
313 | return perf_test__list(argc, argv); | 314 | return perf_test__list(argc, argv); |
314 | 315 | ||