diff options
author | Yunlong Song <yunlong.song@huawei.com> | 2015-03-18 09:35:54 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-03-19 12:49:39 -0400 |
commit | 40cae2b779f2826f3d82674027299332c2007716 (patch) | |
tree | 70017d81bf4c993aeb0eb211c8e8d7538cf42212 /tools | |
parent | e24a110882949c609c5fb7625b71d8e77264257b (diff) |
perf tools: Add the bash completion for listing subsubcommands of perf script
The bash completion does not support listing subsubcommands for 'perf
script <TAB>', so fix it.
Example:
Before this patch:
$ perf script <TAB>
$
As shown above, the subsubcommands of perf script does not come out.
After this patch:
$ perf script <TAB>
record report
As shown above, the subsubcommands of perf script can come out now.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1426685758-25488-10-git-send-email-yunlong.song@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/perf/builtin-script.c | 5 | ||||
-rw-r--r-- | tools/perf/perf-completion.sh | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index c7e6750923ef..f2a348b57b8f 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c | |||
@@ -1572,7 +1572,8 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused) | |||
1572 | "Show the mmap events"), | 1572 | "Show the mmap events"), |
1573 | OPT_END() | 1573 | OPT_END() |
1574 | }; | 1574 | }; |
1575 | const char * const script_usage[] = { | 1575 | const char * const script_subcommands[] = { "record", "report", NULL }; |
1576 | const char *script_usage[] = { | ||
1576 | "perf script [<options>]", | 1577 | "perf script [<options>]", |
1577 | "perf script [<options>] record <script> [<record-options>] <command>", | 1578 | "perf script [<options>] record <script> [<record-options>] <command>", |
1578 | "perf script [<options>] report <script> [script-args]", | 1579 | "perf script [<options>] report <script> [script-args]", |
@@ -1586,7 +1587,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused) | |||
1586 | 1587 | ||
1587 | setup_scripting(); | 1588 | setup_scripting(); |
1588 | 1589 | ||
1589 | argc = parse_options(argc, argv, options, script_usage, | 1590 | argc = parse_options_subcommand(argc, argv, options, script_subcommands, script_usage, |
1590 | PARSE_OPT_STOP_AT_NON_OPTION); | 1591 | PARSE_OPT_STOP_AT_NON_OPTION); |
1591 | 1592 | ||
1592 | file.path = input_name; | 1593 | file.path = input_name; |
diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh index dbca6a66f401..8739a1345017 100644 --- a/tools/perf/perf-completion.sh +++ b/tools/perf/perf-completion.sh | |||
@@ -143,7 +143,7 @@ __perf_main () | |||
143 | __perfcomp_colon "$evts" "$cur" | 143 | __perfcomp_colon "$evts" "$cur" |
144 | else | 144 | else |
145 | # List subcommands for perf commands | 145 | # List subcommands for perf commands |
146 | if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched|data|help) ]]; then | 146 | if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched|data|help|script) ]]; then |
147 | subcmds=$($cmd $prev_skip_opts --list-cmds) | 147 | subcmds=$($cmd $prev_skip_opts --list-cmds) |
148 | __perfcomp_colon "$subcmds" "$cur" | 148 | __perfcomp_colon "$subcmds" "$cur" |
149 | fi | 149 | fi |