diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2010-03-02 17:51:53 -0500 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2012-11-19 08:59:09 -0500 |
commit | 17cf22c33e1f1b5e435469c84e43872579497653 (patch) | |
tree | c5cec307c06f7e4ddc26e04e73c8833897b67113 /kernel/cgroup.c | |
parent | 49f4d8b93ccf9454284b6f524b96c66d8d7fbccc (diff) |
pidns: Use task_active_pid_ns where appropriate
The expressions tsk->nsproxy->pid_ns and task_active_pid_ns
aka ns_of_pid(task_pid(tsk)) should have the same number of
cache line misses with the practical difference that
ns_of_pid(task_pid(tsk)) is released later in a processes life.
Furthermore by using task_active_pid_ns it becomes trivial
to write an unshare implementation for the the pid namespace.
So I have used task_active_pid_ns everywhere I can.
In fork since the pid has not yet been attached to the
process I use ns_of_pid, to achieve the same effect.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Diffstat (limited to 'kernel/cgroup.c')
-rw-r--r-- | kernel/cgroup.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/cgroup.c b/kernel/cgroup.c index f24f724620dd..0dbfba2efa77 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c | |||
@@ -3390,7 +3390,7 @@ static struct cgroup_pidlist *cgroup_pidlist_find(struct cgroup *cgrp, | |||
3390 | { | 3390 | { |
3391 | struct cgroup_pidlist *l; | 3391 | struct cgroup_pidlist *l; |
3392 | /* don't need task_nsproxy() if we're looking at ourself */ | 3392 | /* don't need task_nsproxy() if we're looking at ourself */ |
3393 | struct pid_namespace *ns = current->nsproxy->pid_ns; | 3393 | struct pid_namespace *ns = task_active_pid_ns(current); |
3394 | 3394 | ||
3395 | /* | 3395 | /* |
3396 | * We can't drop the pidlist_mutex before taking the l->mutex in case | 3396 | * We can't drop the pidlist_mutex before taking the l->mutex in case |