aboutsummaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorRobert Richter <robert.richter@amd.com>2012-04-02 14:19:17 -0400
committerIngo Molnar <mingo@kernel.org>2012-05-09 09:23:16 -0400
commitfc5fb2b5e1874e5894e2ac503bfb744220db89a1 (patch)
tree9f4f3913a971b5a7acb990038dc661da40ecc13b /arch
parentc9574fe0bdb9ac9a2698e02a712088ce8431e9f8 (diff)
perf/x86-ibs: Catch spurious interrupts after stopping IBS
After disabling IBS there could be still incomming NMIs with samples that even have the valid bit cleared. Mark all this NMIs as handled to avoid spurious interrupt messages. Signed-off-by: Robert Richter <robert.richter@amd.com> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1333390758-10893-12-git-send-email-robert.richter@amd.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch')
-rw-r--r--arch/x86/kernel/cpu/perf_event_amd_ibs.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/arch/x86/kernel/cpu/perf_event_amd_ibs.c b/arch/x86/kernel/cpu/perf_event_amd_ibs.c
index b14e71127c82..5a9f95b5cc26 100644
--- a/arch/x86/kernel/cpu/perf_event_amd_ibs.c
+++ b/arch/x86/kernel/cpu/perf_event_amd_ibs.c
@@ -473,11 +473,13 @@ static int perf_ibs_handle_irq(struct perf_ibs *perf_ibs, struct pt_regs *iregs)
473 u64 *buf, *config, period; 473 u64 *buf, *config, period;
474 474
475 if (!test_bit(IBS_STARTED, pcpu->state)) { 475 if (!test_bit(IBS_STARTED, pcpu->state)) {
476 /* Catch spurious interrupts after stopping IBS: */ 476 /*
477 if (!test_and_clear_bit(IBS_STOPPING, pcpu->state)) 477 * Catch spurious interrupts after stopping IBS: After
478 return 0; 478 * disabling IBS there could be still incomming NMIs
479 rdmsrl(perf_ibs->msr, *ibs_data.regs); 479 * with samples that even have the valid bit cleared.
480 return (*ibs_data.regs & perf_ibs->valid_mask) ? 1 : 0; 480 * Mark all this NMIs as handled.
481 */
482 return test_and_clear_bit(IBS_STOPPING, pcpu->state) ? 1 : 0;
481 } 483 }
482 484
483 msr = hwc->config_base; 485 msr = hwc->config_base;