diff options
author | Markus Elfring <elfring@users.sourceforge.net> | 2014-11-21 09:20:12 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-11-24 20:24:31 -0500 |
commit | f910b6cba27af4c5e1b0de1225a268448c2e82be (patch) | |
tree | 3d48cc9c85e7c822db8a9891a63063e75ff1c70c | |
parent | bb2d43e0919ad89077dc756167c2bcc3e4cc97ab (diff) |
USB: PCI-quirks: Deletion of unnecessary checks before the function call "pci_dev_put"
The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/usb/host/pci-quirks.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c index 2f3acebb577a..dd483c13565b 100644 --- a/drivers/usb/host/pci-quirks.c +++ b/drivers/usb/host/pci-quirks.c | |||
@@ -233,10 +233,8 @@ commit: | |||
233 | 233 | ||
234 | spin_unlock_irqrestore(&amd_lock, flags); | 234 | spin_unlock_irqrestore(&amd_lock, flags); |
235 | 235 | ||
236 | if (info.nb_dev) | 236 | pci_dev_put(info.nb_dev); |
237 | pci_dev_put(info.nb_dev); | 237 | pci_dev_put(info.smbus_dev); |
238 | if (info.smbus_dev) | ||
239 | pci_dev_put(info.smbus_dev); | ||
240 | 238 | ||
241 | } else { | 239 | } else { |
242 | /* no race - commit the result */ | 240 | /* no race - commit the result */ |
@@ -447,10 +445,8 @@ void usb_amd_dev_put(void) | |||
447 | 445 | ||
448 | spin_unlock_irqrestore(&amd_lock, flags); | 446 | spin_unlock_irqrestore(&amd_lock, flags); |
449 | 447 | ||
450 | if (nb) | 448 | pci_dev_put(nb); |
451 | pci_dev_put(nb); | 449 | pci_dev_put(smbus); |
452 | if (smbus) | ||
453 | pci_dev_put(smbus); | ||
454 | } | 450 | } |
455 | EXPORT_SYMBOL_GPL(usb_amd_dev_put); | 451 | EXPORT_SYMBOL_GPL(usb_amd_dev_put); |
456 | 452 | ||