aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-21 09:50:44 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-11-24 20:24:31 -0500
commitbb2d43e0919ad89077dc756167c2bcc3e4cc97ab (patch)
tree67ec25e287a1be5e92407607dad6d25767a5bbb4
parent03f3df817dd3bf988c6d56e10e99b5b4553f5044 (diff)
USB-SIS: Deletion of an unnecessary check before the function call "usb_put_dev"
The usb_put_dev() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/misc/sisusbvga/sisusb.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index 633caf643122..022dc0008f2a 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -2472,8 +2472,7 @@ sisusb_delete(struct kref *kref)
2472 if (!sisusb) 2472 if (!sisusb)
2473 return; 2473 return;
2474 2474
2475 if (sisusb->sisusb_dev) 2475 usb_put_dev(sisusb->sisusb_dev);
2476 usb_put_dev(sisusb->sisusb_dev);
2477 2476
2478 sisusb->sisusb_dev = NULL; 2477 sisusb->sisusb_dev = NULL;
2479 sisusb_free_buffers(sisusb); 2478 sisusb_free_buffers(sisusb);