diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-06-28 14:41:43 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-06-28 14:41:43 -0400 |
| commit | 9a7c6b73c40e916861eb852dc5855ffb3d58a3cd (patch) | |
| tree | fff050488cb58ff8540e41f29bbcb1c487220c14 | |
| parent | 4a9c46978d9a7e8f2b41f757eb24bd190b1a3b7b (diff) | |
| parent | 903e0e4ef9120c3d7693599acb95e76e8263fb35 (diff) | |
Merge tag 'upstream-3.5-rc5' of git://git.infradead.org/linux-ubifs
Pull ubi/ubifs fixes from Artem Bityutskiy:
"Fix the debugfs regression - we never enable it because incorrect
'IS_ENABLED()' macro usage: should be 'IS_ENABLED(CONFIG_DEBUG_FS)',
but we had 'IS_ENABLED(DEBUG_FS)'. Also fix incorrect assertion."
* tag 'upstream-3.5-rc5' of git://git.infradead.org/linux-ubifs:
UBI: correct usage of IS_ENABLED()
UBIFS: correct usage of IS_ENABLED()
UBIFS: fix assertion
| -rw-r--r-- | drivers/mtd/ubi/debug.c | 8 | ||||
| -rw-r--r-- | fs/ubifs/debug.c | 8 | ||||
| -rw-r--r-- | fs/ubifs/find.c | 4 |
3 files changed, 10 insertions, 10 deletions
diff --git a/drivers/mtd/ubi/debug.c b/drivers/mtd/ubi/debug.c index 09d4f8d9d592..7c1380305219 100644 --- a/drivers/mtd/ubi/debug.c +++ b/drivers/mtd/ubi/debug.c | |||
| @@ -264,7 +264,7 @@ static struct dentry *dfs_rootdir; | |||
| 264 | */ | 264 | */ |
| 265 | int ubi_debugfs_init(void) | 265 | int ubi_debugfs_init(void) |
| 266 | { | 266 | { |
| 267 | if (!IS_ENABLED(DEBUG_FS)) | 267 | if (!IS_ENABLED(CONFIG_DEBUG_FS)) |
| 268 | return 0; | 268 | return 0; |
| 269 | 269 | ||
| 270 | dfs_rootdir = debugfs_create_dir("ubi", NULL); | 270 | dfs_rootdir = debugfs_create_dir("ubi", NULL); |
| @@ -284,7 +284,7 @@ int ubi_debugfs_init(void) | |||
| 284 | */ | 284 | */ |
| 285 | void ubi_debugfs_exit(void) | 285 | void ubi_debugfs_exit(void) |
| 286 | { | 286 | { |
| 287 | if (IS_ENABLED(DEBUG_FS)) | 287 | if (IS_ENABLED(CONFIG_DEBUG_FS)) |
| 288 | debugfs_remove(dfs_rootdir); | 288 | debugfs_remove(dfs_rootdir); |
| 289 | } | 289 | } |
| 290 | 290 | ||
| @@ -407,7 +407,7 @@ int ubi_debugfs_init_dev(struct ubi_device *ubi) | |||
| 407 | struct dentry *dent; | 407 | struct dentry *dent; |
| 408 | struct ubi_debug_info *d = ubi->dbg; | 408 | struct ubi_debug_info *d = ubi->dbg; |
| 409 | 409 | ||
| 410 | if (!IS_ENABLED(DEBUG_FS)) | 410 | if (!IS_ENABLED(CONFIG_DEBUG_FS)) |
| 411 | return 0; | 411 | return 0; |
| 412 | 412 | ||
| 413 | n = snprintf(d->dfs_dir_name, UBI_DFS_DIR_LEN + 1, UBI_DFS_DIR_NAME, | 413 | n = snprintf(d->dfs_dir_name, UBI_DFS_DIR_LEN + 1, UBI_DFS_DIR_NAME, |
| @@ -477,6 +477,6 @@ out: | |||
| 477 | */ | 477 | */ |
| 478 | void ubi_debugfs_exit_dev(struct ubi_device *ubi) | 478 | void ubi_debugfs_exit_dev(struct ubi_device *ubi) |
| 479 | { | 479 | { |
| 480 | if (IS_ENABLED(DEBUG_FS)) | 480 | if (IS_ENABLED(CONFIG_DEBUG_FS)) |
| 481 | debugfs_remove_recursive(ubi->dbg->dfs_dir); | 481 | debugfs_remove_recursive(ubi->dbg->dfs_dir); |
| 482 | } | 482 | } |
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index 84a7e6f3c046..92df3b081539 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c | |||
| @@ -2918,7 +2918,7 @@ int dbg_debugfs_init_fs(struct ubifs_info *c) | |||
| 2918 | struct dentry *dent; | 2918 | struct dentry *dent; |
| 2919 | struct ubifs_debug_info *d = c->dbg; | 2919 | struct ubifs_debug_info *d = c->dbg; |
| 2920 | 2920 | ||
| 2921 | if (!IS_ENABLED(DEBUG_FS)) | 2921 | if (!IS_ENABLED(CONFIG_DEBUG_FS)) |
| 2922 | return 0; | 2922 | return 0; |
| 2923 | 2923 | ||
| 2924 | n = snprintf(d->dfs_dir_name, UBIFS_DFS_DIR_LEN + 1, UBIFS_DFS_DIR_NAME, | 2924 | n = snprintf(d->dfs_dir_name, UBIFS_DFS_DIR_LEN + 1, UBIFS_DFS_DIR_NAME, |
| @@ -3013,7 +3013,7 @@ out: | |||
| 3013 | */ | 3013 | */ |
| 3014 | void dbg_debugfs_exit_fs(struct ubifs_info *c) | 3014 | void dbg_debugfs_exit_fs(struct ubifs_info *c) |
| 3015 | { | 3015 | { |
| 3016 | if (IS_ENABLED(DEBUG_FS)) | 3016 | if (IS_ENABLED(CONFIG_DEBUG_FS)) |
| 3017 | debugfs_remove_recursive(c->dbg->dfs_dir); | 3017 | debugfs_remove_recursive(c->dbg->dfs_dir); |
| 3018 | } | 3018 | } |
| 3019 | 3019 | ||
| @@ -3099,7 +3099,7 @@ int dbg_debugfs_init(void) | |||
| 3099 | const char *fname; | 3099 | const char *fname; |
| 3100 | struct dentry *dent; | 3100 | struct dentry *dent; |
| 3101 | 3101 | ||
| 3102 | if (!IS_ENABLED(DEBUG_FS)) | 3102 | if (!IS_ENABLED(CONFIG_DEBUG_FS)) |
| 3103 | return 0; | 3103 | return 0; |
| 3104 | 3104 | ||
| 3105 | fname = "ubifs"; | 3105 | fname = "ubifs"; |
| @@ -3166,7 +3166,7 @@ out: | |||
| 3166 | */ | 3166 | */ |
| 3167 | void dbg_debugfs_exit(void) | 3167 | void dbg_debugfs_exit(void) |
| 3168 | { | 3168 | { |
| 3169 | if (IS_ENABLED(DEBUG_FS)) | 3169 | if (IS_ENABLED(CONFIG_DEBUG_FS)) |
| 3170 | debugfs_remove_recursive(dfs_rootdir); | 3170 | debugfs_remove_recursive(dfs_rootdir); |
| 3171 | } | 3171 | } |
| 3172 | 3172 | ||
diff --git a/fs/ubifs/find.c b/fs/ubifs/find.c index 2559d174e004..28ec13af28d9 100644 --- a/fs/ubifs/find.c +++ b/fs/ubifs/find.c | |||
| @@ -939,8 +939,8 @@ static int find_dirtiest_idx_leb(struct ubifs_info *c) | |||
| 939 | } | 939 | } |
| 940 | dbg_find("LEB %d, dirty %d and free %d flags %#x", lp->lnum, lp->dirty, | 940 | dbg_find("LEB %d, dirty %d and free %d flags %#x", lp->lnum, lp->dirty, |
| 941 | lp->free, lp->flags); | 941 | lp->free, lp->flags); |
| 942 | ubifs_assert(lp->flags | LPROPS_TAKEN); | 942 | ubifs_assert(lp->flags & LPROPS_TAKEN); |
| 943 | ubifs_assert(lp->flags | LPROPS_INDEX); | 943 | ubifs_assert(lp->flags & LPROPS_INDEX); |
| 944 | return lnum; | 944 | return lnum; |
| 945 | } | 945 | } |
| 946 | 946 | ||
