drm/nouveau/fifo: remove all the "special" engine hooks

All the places this stuff is actually needed tends to be chipset-specific
anyway, so we're able to just inline the register bashing instead.

The parts of the common code that still directly touch PFIFO temporarily
have conditionals, these will be removed in subsequent commits that will
refactor the fifo modules into engine modules like graph/mpeg etc.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

13 files changed, 62 insertions, 187 deletions

diff --git a/drivers/gpu/drm/nouveau/nouveau_channel.c b/drivers/gpu/drm/nouveau/nouveau_channel.c
index 5762547ed8af..9f4a5c5d5903 100644
--- a/drivers/gpu/drm/nouveau/nouveau_channel.c
+++ b/drivers/gpu/drm/nouveau/nouveau_channel.c
@@ -190,7 +190,8 @@ nouveau_channel_alloc(struct drm_device *dev, struct nouveau_channel **chan_ret,
                 chan->user_get_hi = 0x60;
 
         /* disable the fifo caches */
-        pfifo->reassign(dev, false);
+        if (dev_priv->card_type < NV_C0)
+                nv_wr32(dev, NV03_PFIFO_CACHES, 0);
 
         /* Construct initial RAMFC for new channel */
         ret = pfifo->create_context(chan);
@@ -199,7 +200,8 @@ nouveau_channel_alloc(struct drm_device *dev, struct nouveau_channel **chan_ret,
                 return ret;
         }
 
-        pfifo->reassign(dev, true);
+        if (dev_priv->card_type < NV_C0)
+                nv_wr32(dev, NV03_PFIFO_CACHES, 1);
 
         /* Insert NOPs for NOUVEAU_DMA_SKIPS */
         ret = RING_SPACE(chan, NOUVEAU_DMA_SKIPS);
@@ -304,7 +306,8 @@ nouveau_channel_put_unlocked(struct nouveau_channel **pchan)
         nouveau_channel_idle(chan);
 
         /* boot it off the hardware */
-        pfifo->reassign(dev, false);
+        if (dev_priv->card_type < NV_C0)
+                nv_wr32(dev, NV03_PFIFO_CACHES, 0);
 
         /* destroy the engine specific contexts */
         for (i = NVOBJ_ENGINE_NR - 1; i >= 0; i--) {
@@ -315,7 +318,8 @@ nouveau_channel_put_unlocked(struct nouveau_channel **pchan)
                         pfifo->destroy_context(chan);
         }
 
-        pfifo->reassign(dev, true);
+        if (dev_priv->card_type < NV_C0)
+                nv_wr32(dev, NV03_PFIFO_CACHES, 1);
 
         /* aside from its resources, the channel should now be dead,
          * remove it from the channel list
diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c
index b394ecf787f6..adc6502d296c 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drv.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drv.c
@@ -221,8 +221,12 @@ nouveau_pci_suspend(struct pci_dev *pdev, pm_message_t pm_state)
                         nouveau_channel_idle(chan);
         }
 
-        pfifo->reassign(dev, false);
-        pfifo->disable(dev);
+        if (dev_priv->card_type < NV_C0) {
+                nv_wr32(dev, NV03_PFIFO_CACHES, 0);
+                nv_mask(dev, NV04_PFIFO_CACHE1_DMA_PUSH, 0x00000001, 0);
+                nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 0);
+                nv_mask(dev, NV04_PFIFO_CACHE1_PULL0, 0x00000001, 0);
+        }
         pfifo->unload_context(dev);
 
         for (e = NVOBJ_ENGINE_NR - 1; e >= 0; e--) {
@@ -265,8 +269,11 @@ out_abort:
                 if (dev_priv->eng[e])
                         dev_priv->eng[e]->init(dev, e);
         }
-        pfifo->enable(dev);
-        pfifo->reassign(dev, true);
+        if (dev_priv->card_type < NV_C0) {
+                nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 1);
+                nv_wr32(dev, NV04_PFIFO_CACHE1_PULL0, 1);
+                nv_wr32(dev, NV03_PFIFO_CACHES, 1);
+        }
         return ret;
 }
 
diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.h b/drivers/gpu/drm/nouveau/nouveau_drv.h
index 79eecf53ef2a..9943ccf764ce 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drv.h
+++ b/drivers/gpu/drm/nouveau/nouveau_drv.h
@@ -357,13 +357,6 @@ struct nouveau_fifo_engine {
         int  (*init)(struct drm_device *);
         void (*takedown)(struct drm_device *);
 
-        void (*disable)(struct drm_device *);
-        void (*enable)(struct drm_device *);
-        bool (*reassign)(struct drm_device *, bool enable);
-        bool (*cache_pull)(struct drm_device *dev, bool enable);
-
-        int  (*channel_id)(struct drm_device *);
-
         int  (*create_context)(struct nouveau_channel *);
         void (*destroy_context)(struct nouveau_channel *);
         int  (*load_context)(struct nouveau_channel *);
@@ -1193,20 +1186,15 @@ extern void nvc0_fb_takedown(struct drm_device *);
 /* nv04_fifo.c */
 extern int  nv04_fifo_init(struct drm_device *);
 extern void nv04_fifo_fini(struct drm_device *);
-extern void nv04_fifo_disable(struct drm_device *);
-extern void nv04_fifo_enable(struct drm_device *);
-extern bool nv04_fifo_reassign(struct drm_device *, bool);
-extern bool nv04_fifo_cache_pull(struct drm_device *, bool);
-extern int  nv04_fifo_channel_id(struct drm_device *);
 extern int  nv04_fifo_create_context(struct nouveau_channel *);
 extern void nv04_fifo_destroy_context(struct nouveau_channel *);
 extern int  nv04_fifo_load_context(struct nouveau_channel *);
 extern int  nv04_fifo_unload_context(struct drm_device *);
 extern void nv04_fifo_isr(struct drm_device *);
+bool nv04_fifo_cache_pull(struct drm_device *, bool enable);
 
 /* nv10_fifo.c */
 extern int  nv10_fifo_init(struct drm_device *);
-extern int  nv10_fifo_channel_id(struct drm_device *);
 extern int  nv10_fifo_create_context(struct nouveau_channel *);
 extern int  nv10_fifo_load_context(struct nouveau_channel *);
 extern int  nv10_fifo_unload_context(struct drm_device *);
@@ -1220,7 +1208,6 @@ extern int  nv40_fifo_unload_context(struct drm_device *);
 /* nv50_fifo.c */
 extern int  nv50_fifo_init(struct drm_device *);
 extern void nv50_fifo_takedown(struct drm_device *);
-extern int  nv50_fifo_channel_id(struct drm_device *);
 extern int  nv50_fifo_create_context(struct nouveau_channel *);
 extern void nv50_fifo_destroy_context(struct nouveau_channel *);
 extern int  nv50_fifo_load_context(struct nouveau_channel *);
@@ -1230,11 +1217,6 @@ extern void nv50_fifo_tlb_flush(struct drm_device *dev);
 /* nvc0_fifo.c */
 extern int  nvc0_fifo_init(struct drm_device *);
 extern void nvc0_fifo_takedown(struct drm_device *);
-extern void nvc0_fifo_disable(struct drm_device *);
-extern void nvc0_fifo_enable(struct drm_device *);
-extern bool nvc0_fifo_reassign(struct drm_device *, bool);
-extern bool nvc0_fifo_cache_pull(struct drm_device *, bool);
-extern int  nvc0_fifo_channel_id(struct drm_device *);
 extern int  nvc0_fifo_create_context(struct nouveau_channel *);
 extern void nvc0_fifo_destroy_context(struct nouveau_channel *);
 extern int  nvc0_fifo_load_context(struct nouveau_channel *);
@@ -1243,7 +1225,6 @@ extern int  nvc0_fifo_unload_context(struct drm_device *);
 /* nve0_fifo.c */
 extern int  nve0_fifo_init(struct drm_device *);
 extern void nve0_fifo_takedown(struct drm_device *);
-extern int  nve0_fifo_channel_id(struct drm_device *);
 extern int  nve0_fifo_create_context(struct nouveau_channel *);
 extern void nve0_fifo_destroy_context(struct nouveau_channel *);
 extern int  nve0_fifo_unload_context(struct drm_device *);
diff --git a/drivers/gpu/drm/nouveau/nouveau_mem.c b/drivers/gpu/drm/nouveau/nouveau_mem.c
index 193521251773..fd7273459ad6 100644
--- a/drivers/gpu/drm/nouveau/nouveau_mem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_mem.c
@@ -51,7 +51,6 @@ nv10_mem_update_tile_region(struct drm_device *dev,
                             uint32_t size, uint32_t pitch, uint32_t flags)
 {
         struct drm_nouveau_private *dev_priv = dev->dev_private;
-        struct nouveau_fifo_engine *pfifo = &dev_priv->engine.fifo;
         struct nouveau_fb_engine *pfb = &dev_priv->engine.fb;
         int i = tile - dev_priv->tile.reg, j;
         unsigned long save;
@@ -65,8 +64,8 @@ nv10_mem_update_tile_region(struct drm_device *dev,
                 pfb->init_tile_region(dev, i, addr, size, pitch, flags);
 
         spin_lock_irqsave(&dev_priv->context_switch_lock, save);
-        pfifo->reassign(dev, false);
-        pfifo->cache_pull(dev, false);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 0);
+        nv04_fifo_cache_pull(dev, false);
 
         nouveau_wait_for_idle(dev);
 
@@ -76,8 +75,8 @@ nv10_mem_update_tile_region(struct drm_device *dev,
                         dev_priv->eng[j]->set_tile_region(dev, i);
         }
 
-        pfifo->cache_pull(dev, true);
-        pfifo->reassign(dev, true);
+        nv04_fifo_cache_pull(dev, true);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 1);
         spin_unlock_irqrestore(&dev_priv->context_switch_lock, save);
 }
 
diff --git a/drivers/gpu/drm/nouveau/nouveau_state.c b/drivers/gpu/drm/nouveau/nouveau_state.c
index 1039e57d0aef..660a033b6ddf 100644
--- a/drivers/gpu/drm/nouveau/nouveau_state.c
+++ b/drivers/gpu/drm/nouveau/nouveau_state.c
@@ -71,11 +71,6 @@ static int nouveau_init_engine_ptrs(struct drm_device *dev)
                 engine->fifo.channels           = 16;
                 engine->fifo.init               = nv04_fifo_init;
                 engine->fifo.takedown           = nv04_fifo_fini;
-                engine->fifo.disable            = nv04_fifo_disable;
-                engine->fifo.enable             = nv04_fifo_enable;
-                engine->fifo.reassign           = nv04_fifo_reassign;
-                engine->fifo.cache_pull         = nv04_fifo_cache_pull;
-                engine->fifo.channel_id         = nv04_fifo_channel_id;
                 engine->fifo.create_context     = nv04_fifo_create_context;
                 engine->fifo.destroy_context    = nv04_fifo_destroy_context;
                 engine->fifo.load_context       = nv04_fifo_load_context;
@@ -116,11 +111,6 @@ static int nouveau_init_engine_ptrs(struct drm_device *dev)
                 engine->fifo.channels           = 32;
                 engine->fifo.init               = nv10_fifo_init;
                 engine->fifo.takedown           = nv04_fifo_fini;
-                engine->fifo.disable            = nv04_fifo_disable;
-                engine->fifo.enable             = nv04_fifo_enable;
-                engine->fifo.reassign           = nv04_fifo_reassign;
-                engine->fifo.cache_pull         = nv04_fifo_cache_pull;
-                engine->fifo.channel_id         = nv10_fifo_channel_id;
                 engine->fifo.create_context     = nv10_fifo_create_context;
                 engine->fifo.destroy_context    = nv04_fifo_destroy_context;
                 engine->fifo.load_context       = nv10_fifo_load_context;
@@ -167,11 +157,6 @@ static int nouveau_init_engine_ptrs(struct drm_device *dev)
                 engine->fifo.channels           = 32;
                 engine->fifo.init               = nv10_fifo_init;
                 engine->fifo.takedown           = nv04_fifo_fini;
-                engine->fifo.disable            = nv04_fifo_disable;
-                engine->fifo.enable             = nv04_fifo_enable;
-                engine->fifo.reassign           = nv04_fifo_reassign;
-                engine->fifo.cache_pull         = nv04_fifo_cache_pull;
-                engine->fifo.channel_id         = nv10_fifo_channel_id;
                 engine->fifo.create_context     = nv10_fifo_create_context;
                 engine->fifo.destroy_context    = nv04_fifo_destroy_context;
                 engine->fifo.load_context       = nv10_fifo_load_context;
@@ -214,11 +199,6 @@ static int nouveau_init_engine_ptrs(struct drm_device *dev)
                 engine->fifo.channels           = 32;
                 engine->fifo.init               = nv10_fifo_init;
                 engine->fifo.takedown           = nv04_fifo_fini;
-                engine->fifo.disable            = nv04_fifo_disable;
-                engine->fifo.enable             = nv04_fifo_enable;
-                engine->fifo.reassign           = nv04_fifo_reassign;
-                engine->fifo.cache_pull         = nv04_fifo_cache_pull;
-                engine->fifo.channel_id         = nv10_fifo_channel_id;
                 engine->fifo.create_context     = nv10_fifo_create_context;
                 engine->fifo.destroy_context    = nv04_fifo_destroy_context;
                 engine->fifo.load_context       = nv10_fifo_load_context;
@@ -264,11 +244,6 @@ static int nouveau_init_engine_ptrs(struct drm_device *dev)
                 engine->fifo.channels           = 32;
                 engine->fifo.init               = nv40_fifo_init;
                 engine->fifo.takedown           = nv04_fifo_fini;
-                engine->fifo.disable            = nv04_fifo_disable;
-                engine->fifo.enable             = nv04_fifo_enable;
-                engine->fifo.reassign           = nv04_fifo_reassign;
-                engine->fifo.cache_pull         = nv04_fifo_cache_pull;
-                engine->fifo.channel_id         = nv10_fifo_channel_id;
                 engine->fifo.create_context     = nv40_fifo_create_context;
                 engine->fifo.destroy_context    = nv04_fifo_destroy_context;
                 engine->fifo.load_context       = nv40_fifo_load_context;
@@ -322,10 +297,6 @@ static int nouveau_init_engine_ptrs(struct drm_device *dev)
                 engine->fifo.channels           = 128;
                 engine->fifo.init               = nv50_fifo_init;
                 engine->fifo.takedown           = nv50_fifo_takedown;
-                engine->fifo.disable            = nv04_fifo_disable;
-                engine->fifo.enable             = nv04_fifo_enable;
-                engine->fifo.reassign           = nv04_fifo_reassign;
-                engine->fifo.channel_id         = nv50_fifo_channel_id;
                 engine->fifo.create_context     = nv50_fifo_create_context;
                 engine->fifo.destroy_context    = nv50_fifo_destroy_context;
                 engine->fifo.load_context       = nv50_fifo_load_context;
@@ -397,10 +368,6 @@ static int nouveau_init_engine_ptrs(struct drm_device *dev)
                 engine->fifo.channels           = 128;
                 engine->fifo.init               = nvc0_fifo_init;
                 engine->fifo.takedown           = nvc0_fifo_takedown;
-                engine->fifo.disable            = nvc0_fifo_disable;
-                engine->fifo.enable             = nvc0_fifo_enable;
-                engine->fifo.reassign           = nvc0_fifo_reassign;
-                engine->fifo.channel_id         = nvc0_fifo_channel_id;
                 engine->fifo.create_context     = nvc0_fifo_create_context;
                 engine->fifo.destroy_context    = nvc0_fifo_destroy_context;
                 engine->fifo.load_context       = nvc0_fifo_load_context;
@@ -450,10 +417,6 @@ static int nouveau_init_engine_ptrs(struct drm_device *dev)
                 engine->fifo.channels           = 128;
                 engine->fifo.init               = nvc0_fifo_init;
                 engine->fifo.takedown           = nvc0_fifo_takedown;
-                engine->fifo.disable            = nvc0_fifo_disable;
-                engine->fifo.enable             = nvc0_fifo_enable;
-                engine->fifo.reassign           = nvc0_fifo_reassign;
-                engine->fifo.channel_id         = nvc0_fifo_channel_id;
                 engine->fifo.create_context     = nvc0_fifo_create_context;
                 engine->fifo.destroy_context    = nvc0_fifo_destroy_context;
                 engine->fifo.load_context       = nvc0_fifo_load_context;
@@ -501,10 +464,6 @@ static int nouveau_init_engine_ptrs(struct drm_device *dev)
                 engine->fifo.channels           = 4096;
                 engine->fifo.init               = nve0_fifo_init;
                 engine->fifo.takedown           = nve0_fifo_takedown;
-                engine->fifo.disable            = nvc0_fifo_disable;
-                engine->fifo.enable             = nvc0_fifo_enable;
-                engine->fifo.reassign           = nvc0_fifo_reassign;
-                engine->fifo.channel_id         = nve0_fifo_channel_id;
                 engine->fifo.create_context     = nve0_fifo_create_context;
                 engine->fifo.destroy_context    = nve0_fifo_destroy_context;
                 engine->fifo.load_context       = nvc0_fifo_load_context;
diff --git a/drivers/gpu/drm/nouveau/nv04_fifo.c b/drivers/gpu/drm/nouveau/nv04_fifo.c
index db465a3ee1b2..584c24d457f0 100644
--- a/drivers/gpu/drm/nouveau/nv04_fifo.c
+++ b/drivers/gpu/drm/nouveau/nv04_fifo.c
@@ -43,34 +43,6 @@
 #define RAMFC_WR(offset, val) nv_wo32(chan->ramfc, NV04_RAMFC_##offset, (val))
 #define RAMFC_RD(offset)      nv_ro32(chan->ramfc, NV04_RAMFC_##offset)
 
-void
-nv04_fifo_disable(struct drm_device *dev)
-{
-        uint32_t tmp;
-
-        tmp = nv_rd32(dev, NV04_PFIFO_CACHE1_DMA_PUSH);
-        nv_wr32(dev, NV04_PFIFO_CACHE1_DMA_PUSH, tmp & ~1);
-        nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 0);
-        tmp = nv_rd32(dev, NV03_PFIFO_CACHE1_PULL1);
-        nv_wr32(dev, NV04_PFIFO_CACHE1_PULL0, tmp & ~1);
-}
-
-void
-nv04_fifo_enable(struct drm_device *dev)
-{
-        nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 1);
-        nv_wr32(dev, NV04_PFIFO_CACHE1_PULL0, 1);
-}
-
-bool
-nv04_fifo_reassign(struct drm_device *dev, bool enable)
-{
-        uint32_t reassign = nv_rd32(dev, NV03_PFIFO_CACHES);
-
-        nv_wr32(dev, NV03_PFIFO_CACHES, enable ? 1 : 0);
-        return (reassign == 1);
-}
-
 bool
 nv04_fifo_cache_pull(struct drm_device *dev, bool enable)
 {
@@ -100,13 +72,6 @@ nv04_fifo_cache_pull(struct drm_device *dev, bool enable)
         return pull & 1;
 }
 
-int
-nv04_fifo_channel_id(struct drm_device *dev)
-{
-        return nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1) &
-                        NV03_PFIFO_CACHE1_PUSH1_CHID_MASK;
-}
-
 #ifdef __BIG_ENDIAN
 #define DMA_FETCH_ENDIANNESS NV_PFIFO_CACHE1_BIG_ENDIAN
 #else
@@ -162,19 +127,21 @@ nv04_fifo_destroy_context(struct nouveau_channel *chan)
         unsigned long flags;
 
         spin_lock_irqsave(&dev_priv->context_switch_lock, flags);
-        pfifo->reassign(dev, false);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 0);
 
         /* Unload the context if it's the currently active one */
-        if (pfifo->channel_id(dev) == chan->id) {
-                pfifo->disable(dev);
+        if ((nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1) & 0xf) == chan->id) {
+                nv_mask(dev, NV04_PFIFO_CACHE1_DMA_PUSH, 0x00000001, 0);
+                nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 0);
+                nv_mask(dev, NV04_PFIFO_CACHE1_PULL0, 0x00000001, 0);
                 pfifo->unload_context(dev);
-                pfifo->enable(dev);
+                nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 1);
+                nv_wr32(dev, NV04_PFIFO_CACHE1_PULL0, 1);
         }
 
         /* Keep it from being rescheduled */
         nv_mask(dev, NV04_PFIFO_MODE, 1 << chan->id, 0);
-
-        pfifo->reassign(dev, true);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 1);
         spin_unlock_irqrestore(&dev_priv->context_switch_lock, flags);
 
         /* Free the channel resources */
@@ -231,7 +198,7 @@ nv04_fifo_unload_context(struct drm_device *dev)
         uint32_t tmp;
         int chid;
 
-        chid = pfifo->channel_id(dev);
+        chid = nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1) & 0xf;
         if (chid < 0 || chid >= dev_priv->engine.fifo.channels)
                 return 0;
 
@@ -313,8 +280,9 @@ nv04_fifo_init(struct drm_device *dev)
         nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH1, pfifo->channels - 1);
 
         nv04_fifo_init_intr(dev);
-        pfifo->enable(dev);
-        pfifo->reassign(dev, true);
+        nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 1);
+        nv_wr32(dev, NV04_PFIFO_CACHE1_PULL0, 1);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 1);
 
         for (i = 0; i < dev_priv->engine.fifo.channels; i++) {
                 if (dev_priv->channels.ptr[i]) {
@@ -392,7 +360,6 @@ void
 nv04_fifo_isr(struct drm_device *dev)
 {
         struct drm_nouveau_private *dev_priv = dev->dev_private;
-        struct nouveau_engine *engine = &dev_priv->engine;
         uint32_t status, reassign;
         int cnt = 0;
 
@@ -402,7 +369,8 @@ nv04_fifo_isr(struct drm_device *dev)
 
                 nv_wr32(dev, NV03_PFIFO_CACHES, 0);
 
-                chid = engine->fifo.channel_id(dev);
+                chid  = nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1);
+                chid &= dev_priv->engine.fifo.channels - 1;
                 get  = nv_rd32(dev, NV03_PFIFO_CACHE1_GET);
 
                 if (status & NV_PFIFO_INTR_CACHE_ERROR) {
diff --git a/drivers/gpu/drm/nouveau/nv04_graph.c b/drivers/gpu/drm/nouveau/nv04_graph.c
index 442b4df44fad..5b5f3ba85f5c 100644
--- a/drivers/gpu/drm/nouveau/nv04_graph.c
+++ b/drivers/gpu/drm/nouveau/nv04_graph.c
@@ -998,7 +998,8 @@ nv04_graph_context_switch(struct drm_device *dev)
         nv04_graph_unload_context(dev);
 
         /* Load context for next channel */
-        chid = dev_priv->engine.fifo.channel_id(dev);
+        chid = nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1) &
+                            NV03_PFIFO_CACHE1_PUSH1_CHID_MASK;
         chan = dev_priv->channels.ptr[chid];
         if (chan)
                 nv04_graph_load_context(chan);
diff --git a/drivers/gpu/drm/nouveau/nv10_fifo.c b/drivers/gpu/drm/nouveau/nv10_fifo.c
index d2ecbff4bee1..476451c6f961 100644
--- a/drivers/gpu/drm/nouveau/nv10_fifo.c
+++ b/drivers/gpu/drm/nouveau/nv10_fifo.c
@@ -33,13 +33,6 @@
 #define NV10_RAMFC__SIZE ((dev_priv->chipset) >= 0x17 ? 64 : 32)
 
 int
-nv10_fifo_channel_id(struct drm_device *dev)
-{
-        return nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1) &
-                        NV10_PFIFO_CACHE1_PUSH1_CHID_MASK;
-}
-
-int
 nv10_fifo_create_context(struct nouveau_channel *chan)
 {
         struct drm_nouveau_private *dev_priv = chan->dev->dev_private;
@@ -139,7 +132,7 @@ nv10_fifo_unload_context(struct drm_device *dev)
         uint32_t fc, tmp;
         int chid;
 
-        chid = pfifo->channel_id(dev);
+        chid = nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1) & 0x1f;
         if (chid < 0 || chid >= dev_priv->engine.fifo.channels)
                 return 0;
         fc = NV10_RAMFC(chid);
@@ -232,8 +225,9 @@ nv10_fifo_init(struct drm_device *dev)
         nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH1, pfifo->channels - 1);
 
         nv10_fifo_init_intr(dev);
-        pfifo->enable(dev);
-        pfifo->reassign(dev, true);
+        nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 1);
+        nv_wr32(dev, NV04_PFIFO_CACHE1_PULL0, 1);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 1);
 
         for (i = 0; i < dev_priv->engine.fifo.channels; i++) {
                 if (dev_priv->channels.ptr[i]) {
diff --git a/drivers/gpu/drm/nouveau/nv40_fifo.c b/drivers/gpu/drm/nouveau/nv40_fifo.c
index 68cb2d991c88..8d346617f55f 100644
--- a/drivers/gpu/drm/nouveau/nv40_fifo.c
+++ b/drivers/gpu/drm/nouveau/nv40_fifo.c
@@ -149,7 +149,7 @@ nv40_fifo_unload_context(struct drm_device *dev)
         uint32_t fc, tmp;
         int chid;
 
-        chid = pfifo->channel_id(dev);
+        chid = nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1) & 0x1f;
         if (chid < 0 || chid >= dev_priv->engine.fifo.channels)
                 return 0;
         fc = NV40_RAMFC(chid);
@@ -293,8 +293,9 @@ nv40_fifo_init(struct drm_device *dev)
         nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH1, pfifo->channels - 1);
 
         nv40_fifo_init_intr(dev);
-        pfifo->enable(dev);
-        pfifo->reassign(dev, true);
+        nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 1);
+        nv_wr32(dev, NV04_PFIFO_CACHE1_PULL0, 1);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 1);
 
         for (i = 0; i < dev_priv->engine.fifo.channels; i++) {
                 if (dev_priv->channels.ptr[i]) {
diff --git a/drivers/gpu/drm/nouveau/nv50_fifo.c b/drivers/gpu/drm/nouveau/nv50_fifo.c
index 3bc2a565c20b..3961c8778780 100644
--- a/drivers/gpu/drm/nouveau/nv50_fifo.c
+++ b/drivers/gpu/drm/nouveau/nv50_fifo.c
@@ -193,8 +193,9 @@ just_reset:
         nv50_fifo_init_context_table(dev);
         nv50_fifo_init_regs__nv(dev);
         nv50_fifo_init_regs(dev);
-        dev_priv->engine.fifo.enable(dev);
-        dev_priv->engine.fifo.reassign(dev, true);
+        nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 1);
+        nv_wr32(dev, NV04_PFIFO_CACHE1_PULL0, 1);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 1);
 
         return 0;
 }
@@ -218,13 +219,6 @@ nv50_fifo_takedown(struct drm_device *dev)
 }
 
 int
-nv50_fifo_channel_id(struct drm_device *dev)
-{
-        return nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1) &
-                        NV50_PFIFO_CACHE1_PUSH1_CHID_MASK;
-}
-
-int
 nv50_fifo_create_context(struct nouveau_channel *chan)
 {
         struct drm_device *dev = chan->dev;
@@ -313,13 +307,16 @@ nv50_fifo_destroy_context(struct nouveau_channel *chan)
         NV_DEBUG(dev, "ch%d\n", chan->id);
 
         spin_lock_irqsave(&dev_priv->context_switch_lock, flags);
-        pfifo->reassign(dev, false);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 0);
 
         /* Unload the context if it's the currently active one */
-        if (pfifo->channel_id(dev) == chan->id) {
-                pfifo->disable(dev);
+        if ((nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1) & 0x7f) == chan->id) {
+                nv_mask(dev, NV04_PFIFO_CACHE1_DMA_PUSH, 0x00000001, 0);
+                nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 0);
+                nv_mask(dev, NV04_PFIFO_CACHE1_PULL0, 0x00000001, 0);
                 pfifo->unload_context(dev);
-                pfifo->enable(dev);
+                nv_wr32(dev, NV03_PFIFO_CACHE1_PUSH0, 1);
+                nv_wr32(dev, NV04_PFIFO_CACHE1_PULL0, 1);
         }
 
         /* This will ensure the channel is seen as disabled. */
@@ -332,7 +329,7 @@ nv50_fifo_destroy_context(struct nouveau_channel *chan)
                 nv50_fifo_channel_disable(dev, 127);
         nv50_fifo_playlist_update(dev);
 
-        pfifo->reassign(dev, true);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 1);
         spin_unlock_irqrestore(&dev_priv->context_switch_lock, flags);
 
         /* Free the channel resources */
@@ -416,14 +413,13 @@ int
 nv50_fifo_unload_context(struct drm_device *dev)
 {
         struct drm_nouveau_private *dev_priv = dev->dev_private;
-        struct nouveau_fifo_engine *pfifo = &dev_priv->engine.fifo;
         struct nouveau_gpuobj *ramfc, *cache;
         struct nouveau_channel *chan = NULL;
         int chid, get, put, ptr;
 
         NV_DEBUG(dev, "\n");
 
-        chid = pfifo->channel_id(dev);
+        chid = nv_rd32(dev, NV03_PFIFO_CACHE1_PUSH1) & 0x7f;
         if (chid < 1 || chid >= dev_priv->engine.fifo.channels - 1)
                 return 0;
 
diff --git a/drivers/gpu/drm/nouveau/nv50_graph.c b/drivers/gpu/drm/nouveau/nv50_graph.c
index a46e060eb399..d262e31c2830 100644
--- a/drivers/gpu/drm/nouveau/nv50_graph.c
+++ b/drivers/gpu/drm/nouveau/nv50_graph.c
@@ -262,7 +262,6 @@ nv50_graph_context_del(struct nouveau_channel *chan, int engine)
         struct nouveau_gpuobj *grctx = chan->engctx[engine];
         struct drm_device *dev = chan->dev;
         struct drm_nouveau_private *dev_priv = dev->dev_private;
-        struct nouveau_fifo_engine *pfifo = &dev_priv->engine.fifo;
         int i, hdr = (dev_priv->chipset == 0x50) ? 0x200 : 0x20;
         unsigned long flags;
 
@@ -272,7 +271,7 @@ nv50_graph_context_del(struct nouveau_channel *chan, int engine)
                 return;
 
         spin_lock_irqsave(&dev_priv->context_switch_lock, flags);
-        pfifo->reassign(dev, false);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 0);
         nv50_graph_fifo_access(dev, false);
 
         if (nv50_graph_channel(dev) == chan)
@@ -283,7 +282,7 @@ nv50_graph_context_del(struct nouveau_channel *chan, int engine)
         dev_priv->engine.instmem.flush(dev);
 
         nv50_graph_fifo_access(dev, true);
-        pfifo->reassign(dev, true);
+        nv_wr32(dev, NV03_PFIFO_CACHES, 1);
         spin_unlock_irqrestore(&dev_priv->context_switch_lock, flags);
 
         nouveau_gpuobj_ref(NULL, &grctx);
diff --git a/drivers/gpu/drm/nouveau/nvc0_fifo.c b/drivers/gpu/drm/nouveau/nvc0_fifo.c
index f47f39645c3e..471723eaf8ad 100644
--- a/drivers/gpu/drm/nouveau/nvc0_fifo.c
+++ b/drivers/gpu/drm/nouveau/nvc0_fifo.c
@@ -69,34 +69,6 @@ nvc0_fifo_playlist_update(struct drm_device *dev)
                 NV_ERROR(dev, "PFIFO - playlist update failed\n");
 }
 
-void
-nvc0_fifo_disable(struct drm_device *dev)
-{
-}
-
-void
-nvc0_fifo_enable(struct drm_device *dev)
-{
-}
-
-bool
-nvc0_fifo_reassign(struct drm_device *dev, bool enable)
-{
-        return false;
-}
-
-bool
-nvc0_fifo_cache_pull(struct drm_device *dev, bool enable)
-{
-        return false;
-}
-
-int
-nvc0_fifo_channel_id(struct drm_device *dev)
-{
-        return 127;
-}
-
 int
 nvc0_fifo_create_context(struct nouveau_channel *chan)
 {
diff --git a/drivers/gpu/drm/nouveau/nve0_fifo.c b/drivers/gpu/drm/nouveau/nve0_fifo.c
index 82ad47cdeab9..52c54e0fdcee 100644
--- a/drivers/gpu/drm/nouveau/nve0_fifo.c
+++ b/drivers/gpu/drm/nouveau/nve0_fifo.c
@@ -92,12 +92,6 @@ nve0_fifo_playlist_update(struct drm_device *dev, u32 engine)
 }
 
 int
-nve0_fifo_channel_id(struct drm_device *dev)
-{
-        return 4095;
-}
-
-int
 nve0_fifo_create_context(struct nouveau_channel *chan)
 {
         struct drm_device *dev = chan->dev;