aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKevin Hao <haokexin@gmail.com>2015-02-04 01:33:53 -0500
committerUlf Hansson <ulf.hansson@linaro.org>2015-03-23 09:13:44 -0400
commit5ec358201eceaf599b0f35bd60ed8be3c4752e37 (patch)
tree17514bfb493d4e10e6f517a2998fdc1bcb1aceec
parent01df7ecd90e94186f9a736a1c58b56e23830f061 (diff)
mmc: sdhci-pltfm: remove the unneeded check of disabled device
Since commit cd1e65044d44 ("of/device: Don't register disabled devices"), the disabled device will not be registered at all. So we don't need to do the check again in the platform device driver. And the check in the current code is useless even if we really run into a disabled device. In this case, it just doesn't parse the dtb for the infos such as quirks or clock, but it will continue to try to init the disabled device after that check. So just remove it. Signed-off-by: Kevin Hao <haokexin@gmail.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
-rw-r--r--drivers/mmc/host/sdhci-pltfm.c54
1 files changed, 26 insertions, 28 deletions
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index 74c58d9a4fc8..a207f5aaf62f 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -75,43 +75,41 @@ void sdhci_get_of_property(struct platform_device *pdev)
75 u32 bus_width; 75 u32 bus_width;
76 int size; 76 int size;
77 77
78 if (of_device_is_available(np)) { 78 if (of_get_property(np, "sdhci,auto-cmd12", NULL))
79 if (of_get_property(np, "sdhci,auto-cmd12", NULL)) 79 host->quirks |= SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12;
80 host->quirks |= SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12;
81 80
82 if (of_get_property(np, "sdhci,1-bit-only", NULL) || 81 if (of_get_property(np, "sdhci,1-bit-only", NULL) ||
83 (of_property_read_u32(np, "bus-width", &bus_width) == 0 && 82 (of_property_read_u32(np, "bus-width", &bus_width) == 0 &&
84 bus_width == 1)) 83 bus_width == 1))
85 host->quirks |= SDHCI_QUIRK_FORCE_1_BIT_DATA; 84 host->quirks |= SDHCI_QUIRK_FORCE_1_BIT_DATA;
86 85
87 if (sdhci_of_wp_inverted(np)) 86 if (sdhci_of_wp_inverted(np))
88 host->quirks |= SDHCI_QUIRK_INVERTED_WRITE_PROTECT; 87 host->quirks |= SDHCI_QUIRK_INVERTED_WRITE_PROTECT;
89 88
90 if (of_get_property(np, "broken-cd", NULL)) 89 if (of_get_property(np, "broken-cd", NULL))
91 host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; 90 host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
92 91
93 if (of_get_property(np, "no-1-8-v", NULL)) 92 if (of_get_property(np, "no-1-8-v", NULL))
94 host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; 93 host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
95 94
96 if (of_device_is_compatible(np, "fsl,p2020-rev1-esdhc")) 95 if (of_device_is_compatible(np, "fsl,p2020-rev1-esdhc"))
97 host->quirks |= SDHCI_QUIRK_BROKEN_DMA; 96 host->quirks |= SDHCI_QUIRK_BROKEN_DMA;
98 97
99 if (of_device_is_compatible(np, "fsl,p2020-esdhc") || 98 if (of_device_is_compatible(np, "fsl,p2020-esdhc") ||
100 of_device_is_compatible(np, "fsl,p1010-esdhc") || 99 of_device_is_compatible(np, "fsl,p1010-esdhc") ||
101 of_device_is_compatible(np, "fsl,t4240-esdhc") || 100 of_device_is_compatible(np, "fsl,t4240-esdhc") ||
102 of_device_is_compatible(np, "fsl,mpc8536-esdhc")) 101 of_device_is_compatible(np, "fsl,mpc8536-esdhc"))
103 host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; 102 host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
104 103
105 clk = of_get_property(np, "clock-frequency", &size); 104 clk = of_get_property(np, "clock-frequency", &size);
106 if (clk && size == sizeof(*clk) && *clk) 105 if (clk && size == sizeof(*clk) && *clk)
107 pltfm_host->clock = be32_to_cpup(clk); 106 pltfm_host->clock = be32_to_cpup(clk);
108 107
109 if (of_find_property(np, "keep-power-in-suspend", NULL)) 108 if (of_find_property(np, "keep-power-in-suspend", NULL))
110 host->mmc->pm_caps |= MMC_PM_KEEP_POWER; 109 host->mmc->pm_caps |= MMC_PM_KEEP_POWER;
111 110
112 if (of_find_property(np, "enable-sdio-wakeup", NULL)) 111 if (of_find_property(np, "enable-sdio-wakeup", NULL))
113 host->mmc->pm_caps |= MMC_PM_WAKE_SDIO_IRQ; 112 host->mmc->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
114 }
115} 113}
116#else 114#else
117void sdhci_get_of_property(struct platform_device *pdev) {} 115void sdhci_get_of_property(struct platform_device *pdev) {}