aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdrian Hunter <adrian.hunter@intel.com>2013-08-08 07:32:27 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2013-08-12 09:31:12 -0400
commit326f59bf645ea6c99709c67d9712df46019fa7a8 (patch)
tree462e4956f64ce38fb123bf253c6da35c2f21dddb
parent61710bdee324aab1c148c8573ee49cea59d05874 (diff)
perf tools: Remove filter parameter of thread__find_addr_map()
Now that the symbol filter is recorded on the machine there is no need to pass it to thread__find_addr_map(). So remove it. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/r/1375961547-30267-9-git-send-email-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/builtin-inject.c2
-rw-r--r--tools/perf/builtin-script.c4
-rw-r--r--tools/perf/tests/code-reading.c2
-rw-r--r--tools/perf/util/build-id.c2
-rw-r--r--tools/perf/util/event.c9
-rw-r--r--tools/perf/util/thread.h2
-rw-r--r--tools/perf/util/unwind.c4
7 files changed, 12 insertions, 13 deletions
diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
index f012a98c726c..1d8de2e4a407 100644
--- a/tools/perf/builtin-inject.c
+++ b/tools/perf/builtin-inject.c
@@ -206,7 +206,7 @@ static int perf_event__inject_buildid(struct perf_tool *tool,
206 } 206 }
207 207
208 thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION, 208 thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION,
209 event->ip.ip, &al, NULL); 209 event->ip.ip, &al);
210 210
211 if (al.map != NULL) { 211 if (al.map != NULL) {
212 if (!al.map->dso->hit) { 212 if (!al.map->dso->hit) {
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index a7d623f39c46..2ad9d5b6fb3c 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -361,10 +361,10 @@ static void print_sample_addr(union perf_event *event,
361 return; 361 return;
362 362
363 thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION, 363 thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION,
364 sample->addr, &al, NULL); 364 sample->addr, &al);
365 if (!al.map) 365 if (!al.map)
366 thread__find_addr_map(thread, machine, cpumode, MAP__VARIABLE, 366 thread__find_addr_map(thread, machine, cpumode, MAP__VARIABLE,
367 sample->addr, &al, NULL); 367 sample->addr, &al);
368 368
369 al.cpu = sample->cpu; 369 al.cpu = sample->cpu;
370 al.sym = NULL; 370 al.sym = NULL;
diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c
index 8e0943b966d7..eec1421a7e6b 100644
--- a/tools/perf/tests/code-reading.c
+++ b/tools/perf/tests/code-reading.c
@@ -147,7 +147,7 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode,
147 pr_debug("Reading object code for memory address: %#"PRIx64"\n", addr); 147 pr_debug("Reading object code for memory address: %#"PRIx64"\n", addr);
148 148
149 thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION, addr, 149 thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION, addr,
150 &al, NULL); 150 &al);
151 if (!al.map || !al.map->dso) { 151 if (!al.map || !al.map->dso) {
152 pr_debug("thread__find_addr_map failed\n"); 152 pr_debug("thread__find_addr_map failed\n");
153 return -1; 153 return -1;
diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
index 3a0f5089379c..5295625c0c00 100644
--- a/tools/perf/util/build-id.c
+++ b/tools/perf/util/build-id.c
@@ -33,7 +33,7 @@ int build_id__mark_dso_hit(struct perf_tool *tool __maybe_unused,
33 } 33 }
34 34
35 thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION, 35 thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION,
36 event->ip.ip, &al, NULL); 36 event->ip.ip, &al);
37 37
38 if (al.map != NULL) 38 if (al.map != NULL)
39 al.map->dso->hit = 1; 39 al.map->dso->hit = 1;
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 9d301c923108..49713ae46551 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -592,7 +592,7 @@ int perf_event__process(struct perf_tool *tool __maybe_unused,
592void thread__find_addr_map(struct thread *self, 592void thread__find_addr_map(struct thread *self,
593 struct machine *machine, u8 cpumode, 593 struct machine *machine, u8 cpumode,
594 enum map_type type, u64 addr, 594 enum map_type type, u64 addr,
595 struct addr_location *al, symbol_filter_t filter) 595 struct addr_location *al)
596{ 596{
597 struct map_groups *mg = &self->mg; 597 struct map_groups *mg = &self->mg;
598 bool load_map = false; 598 bool load_map = false;
@@ -663,7 +663,7 @@ try_again:
663 * must be done prior to using kernel maps. 663 * must be done prior to using kernel maps.
664 */ 664 */
665 if (load_map) 665 if (load_map)
666 map__load(al->map, filter); 666 map__load(al->map, machine->symbol_filter);
667 al->addr = al->map->map_ip(al->map, al->addr); 667 al->addr = al->map->map_ip(al->map, al->addr);
668 } 668 }
669} 669}
@@ -672,8 +672,7 @@ void thread__find_addr_location(struct thread *thread, struct machine *machine,
672 u8 cpumode, enum map_type type, u64 addr, 672 u8 cpumode, enum map_type type, u64 addr,
673 struct addr_location *al) 673 struct addr_location *al)
674{ 674{
675 thread__find_addr_map(thread, machine, cpumode, type, addr, al, 675 thread__find_addr_map(thread, machine, cpumode, type, addr, al);
676 machine->symbol_filter);
677 if (al->map != NULL) 676 if (al->map != NULL)
678 al->sym = map__find_symbol(al->map, al->addr, 677 al->sym = map__find_symbol(al->map, al->addr,
679 machine->symbol_filter); 678 machine->symbol_filter);
@@ -709,7 +708,7 @@ int perf_event__preprocess_sample(const union perf_event *event,
709 machine__create_kernel_maps(machine); 708 machine__create_kernel_maps(machine);
710 709
711 thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION, 710 thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION,
712 event->ip.ip, al, machine->symbol_filter); 711 event->ip.ip, al);
713 dump_printf(" ...... dso: %s\n", 712 dump_printf(" ...... dso: %s\n",
714 al->map ? al->map->dso->long_name : 713 al->map ? al->map->dso->long_name :
715 al->level == 'H' ? "[hypervisor]" : "<not found>"); 714 al->level == 'H' ? "[hypervisor]" : "<not found>");
diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
index 0ab47d860d41..13c62c909392 100644
--- a/tools/perf/util/thread.h
+++ b/tools/perf/util/thread.h
@@ -41,7 +41,7 @@ static inline struct map *thread__find_map(struct thread *self,
41 41
42void thread__find_addr_map(struct thread *thread, struct machine *machine, 42void thread__find_addr_map(struct thread *thread, struct machine *machine,
43 u8 cpumode, enum map_type type, u64 addr, 43 u8 cpumode, enum map_type type, u64 addr,
44 struct addr_location *al, symbol_filter_t filter); 44 struct addr_location *al);
45 45
46void thread__find_addr_location(struct thread *thread, struct machine *machine, 46void thread__find_addr_location(struct thread *thread, struct machine *machine,
47 u8 cpumode, enum map_type type, u64 addr, 47 u8 cpumode, enum map_type type, u64 addr,
diff --git a/tools/perf/util/unwind.c b/tools/perf/util/unwind.c
index abac3f97d95d..2f891f7e70bf 100644
--- a/tools/perf/util/unwind.c
+++ b/tools/perf/util/unwind.c
@@ -272,7 +272,7 @@ static struct map *find_map(unw_word_t ip, struct unwind_info *ui)
272 struct addr_location al; 272 struct addr_location al;
273 273
274 thread__find_addr_map(ui->thread, ui->machine, PERF_RECORD_MISC_USER, 274 thread__find_addr_map(ui->thread, ui->machine, PERF_RECORD_MISC_USER,
275 MAP__FUNCTION, ip, &al, NULL); 275 MAP__FUNCTION, ip, &al);
276 return al.map; 276 return al.map;
277} 277}
278 278
@@ -349,7 +349,7 @@ static int access_dso_mem(struct unwind_info *ui, unw_word_t addr,
349 ssize_t size; 349 ssize_t size;
350 350
351 thread__find_addr_map(ui->thread, ui->machine, PERF_RECORD_MISC_USER, 351 thread__find_addr_map(ui->thread, ui->machine, PERF_RECORD_MISC_USER,
352 MAP__FUNCTION, addr, &al, NULL); 352 MAP__FUNCTION, addr, &al);
353 if (!al.map) { 353 if (!al.map) {
354 pr_debug("unwind: no map for %lx\n", (unsigned long)addr); 354 pr_debug("unwind: no map for %lx\n", (unsigned long)addr);
355 return -1; 355 return -1;