diff options
author | Adrian Hunter <adrian.hunter@intel.com> | 2013-08-08 07:32:26 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-08-12 09:31:12 -0400 |
commit | 61710bdee324aab1c148c8573ee49cea59d05874 (patch) | |
tree | 5f543006be3640b0d771b236b1f0ee9b8a83e9b9 | |
parent | e44baa3ea1eaa09d7d247a9b245fcff06561bf96 (diff) |
perf tools: Remove filter parameter of thread__find_addr_location()
Now that the symbol filter is recorded on the machine there is no need
to pass it to thread__find_addr_location(). So remove it.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1375961547-30267-8-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/util/event.c | 9 | ||||
-rw-r--r-- | tools/perf/util/machine.c | 8 | ||||
-rw-r--r-- | tools/perf/util/thread.h | 3 | ||||
-rw-r--r-- | tools/perf/util/unwind.c | 2 |
4 files changed, 11 insertions, 11 deletions
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c index f3cf771d362e..9d301c923108 100644 --- a/tools/perf/util/event.c +++ b/tools/perf/util/event.c | |||
@@ -670,12 +670,13 @@ try_again: | |||
670 | 670 | ||
671 | void thread__find_addr_location(struct thread *thread, struct machine *machine, | 671 | void thread__find_addr_location(struct thread *thread, struct machine *machine, |
672 | u8 cpumode, enum map_type type, u64 addr, | 672 | u8 cpumode, enum map_type type, u64 addr, |
673 | struct addr_location *al, | 673 | struct addr_location *al) |
674 | symbol_filter_t filter) | ||
675 | { | 674 | { |
676 | thread__find_addr_map(thread, machine, cpumode, type, addr, al, filter); | 675 | thread__find_addr_map(thread, machine, cpumode, type, addr, al, |
676 | machine->symbol_filter); | ||
677 | if (al->map != NULL) | 677 | if (al->map != NULL) |
678 | al->sym = map__find_symbol(al->map, al->addr, filter); | 678 | al->sym = map__find_symbol(al->map, al->addr, |
679 | machine->symbol_filter); | ||
679 | else | 680 | else |
680 | al->sym = NULL; | 681 | al->sym = NULL; |
681 | } | 682 | } |
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 4c7e0a28bf3d..4514e7e9b659 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c | |||
@@ -1130,7 +1130,7 @@ static void ip__resolve_ams(struct machine *machine, struct thread *thread, | |||
1130 | * or else, the symbol is unknown | 1130 | * or else, the symbol is unknown |
1131 | */ | 1131 | */ |
1132 | thread__find_addr_location(thread, machine, m, MAP__FUNCTION, | 1132 | thread__find_addr_location(thread, machine, m, MAP__FUNCTION, |
1133 | ip, &al, NULL); | 1133 | ip, &al); |
1134 | if (al.sym) | 1134 | if (al.sym) |
1135 | goto found; | 1135 | goto found; |
1136 | } | 1136 | } |
@@ -1148,8 +1148,8 @@ static void ip__resolve_data(struct machine *machine, struct thread *thread, | |||
1148 | 1148 | ||
1149 | memset(&al, 0, sizeof(al)); | 1149 | memset(&al, 0, sizeof(al)); |
1150 | 1150 | ||
1151 | thread__find_addr_location(thread, machine, m, MAP__VARIABLE, addr, &al, | 1151 | thread__find_addr_location(thread, machine, m, MAP__VARIABLE, addr, |
1152 | NULL); | 1152 | &al); |
1153 | ams->addr = addr; | 1153 | ams->addr = addr; |
1154 | ams->al_addr = al.addr; | 1154 | ams->al_addr = al.addr; |
1155 | ams->sym = al.sym; | 1155 | ams->sym = al.sym; |
@@ -1244,7 +1244,7 @@ static int machine__resolve_callchain_sample(struct machine *machine, | |||
1244 | 1244 | ||
1245 | al.filtered = false; | 1245 | al.filtered = false; |
1246 | thread__find_addr_location(thread, machine, cpumode, | 1246 | thread__find_addr_location(thread, machine, cpumode, |
1247 | MAP__FUNCTION, ip, &al, NULL); | 1247 | MAP__FUNCTION, ip, &al); |
1248 | if (al.sym != NULL) { | 1248 | if (al.sym != NULL) { |
1249 | if (sort__has_parent && !*parent && | 1249 | if (sort__has_parent && !*parent && |
1250 | symbol__match_regex(al.sym, &parent_regex)) | 1250 | symbol__match_regex(al.sym, &parent_regex)) |
diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h index f98d1d983547..0ab47d860d41 100644 --- a/tools/perf/util/thread.h +++ b/tools/perf/util/thread.h | |||
@@ -45,8 +45,7 @@ void thread__find_addr_map(struct thread *thread, struct machine *machine, | |||
45 | 45 | ||
46 | void thread__find_addr_location(struct thread *thread, struct machine *machine, | 46 | void thread__find_addr_location(struct thread *thread, struct machine *machine, |
47 | u8 cpumode, enum map_type type, u64 addr, | 47 | u8 cpumode, enum map_type type, u64 addr, |
48 | struct addr_location *al, | 48 | struct addr_location *al); |
49 | symbol_filter_t filter); | ||
50 | 49 | ||
51 | static inline void *thread__priv(struct thread *thread) | 50 | static inline void *thread__priv(struct thread *thread) |
52 | { | 51 | { |
diff --git a/tools/perf/util/unwind.c b/tools/perf/util/unwind.c index 5bbd4947c27d..abac3f97d95d 100644 --- a/tools/perf/util/unwind.c +++ b/tools/perf/util/unwind.c | |||
@@ -473,7 +473,7 @@ static int entry(u64 ip, struct thread *thread, struct machine *machine, | |||
473 | 473 | ||
474 | thread__find_addr_location(thread, machine, | 474 | thread__find_addr_location(thread, machine, |
475 | PERF_RECORD_MISC_USER, | 475 | PERF_RECORD_MISC_USER, |
476 | MAP__FUNCTION, ip, &al, NULL); | 476 | MAP__FUNCTION, ip, &al); |
477 | 477 | ||
478 | e.ip = ip; | 478 | e.ip = ip; |
479 | e.map = al.map; | 479 | e.map = al.map; |