diff options
Diffstat (limited to 'drivers/media/video/marvell-ccic/mcam-core.c')
-rw-r--r-- | drivers/media/video/marvell-ccic/mcam-core.c | 36 |
1 files changed, 29 insertions, 7 deletions
diff --git a/drivers/media/video/marvell-ccic/mcam-core.c b/drivers/media/video/marvell-ccic/mcam-core.c index 2c8fc0f6d69..37d20e73908 100644 --- a/drivers/media/video/marvell-ccic/mcam-core.c +++ b/drivers/media/video/marvell-ccic/mcam-core.c | |||
@@ -522,6 +522,15 @@ static void mcam_sg_next_buffer(struct mcam_camera *cam) | |||
522 | */ | 522 | */ |
523 | static void mcam_ctlr_dma_sg(struct mcam_camera *cam) | 523 | static void mcam_ctlr_dma_sg(struct mcam_camera *cam) |
524 | { | 524 | { |
525 | /* | ||
526 | * The list-empty condition can hit us at resume time | ||
527 | * if the buffer list was empty when the system was suspended. | ||
528 | */ | ||
529 | if (list_empty(&cam->buffers)) { | ||
530 | set_bit(CF_SG_RESTART, &cam->flags); | ||
531 | return; | ||
532 | } | ||
533 | |||
525 | mcam_reg_clear_bit(cam, REG_CTRL1, C1_DESC_3WORD); | 534 | mcam_reg_clear_bit(cam, REG_CTRL1, C1_DESC_3WORD); |
526 | mcam_sg_next_buffer(cam); | 535 | mcam_sg_next_buffer(cam); |
527 | mcam_reg_set_bit(cam, REG_CTRL1, C1_DESC_ENA); | 536 | mcam_reg_set_bit(cam, REG_CTRL1, C1_DESC_ENA); |
@@ -566,6 +575,7 @@ static void mcam_dma_sg_done(struct mcam_camera *cam, int frame) | |||
566 | } else { | 575 | } else { |
567 | set_bit(CF_SG_RESTART, &cam->flags); | 576 | set_bit(CF_SG_RESTART, &cam->flags); |
568 | singles++; | 577 | singles++; |
578 | cam->vb_bufs[0] = NULL; | ||
569 | } | 579 | } |
570 | /* | 580 | /* |
571 | * Now we can give the completed frame back to user space. | 581 | * Now we can give the completed frame back to user space. |
@@ -661,10 +671,10 @@ static int mcam_ctlr_configure(struct mcam_camera *cam) | |||
661 | unsigned long flags; | 671 | unsigned long flags; |
662 | 672 | ||
663 | spin_lock_irqsave(&cam->dev_lock, flags); | 673 | spin_lock_irqsave(&cam->dev_lock, flags); |
674 | clear_bit(CF_SG_RESTART, &cam->flags); | ||
664 | cam->dma_setup(cam); | 675 | cam->dma_setup(cam); |
665 | mcam_ctlr_image(cam); | 676 | mcam_ctlr_image(cam); |
666 | mcam_set_config_needed(cam, 0); | 677 | mcam_set_config_needed(cam, 0); |
667 | clear_bit(CF_SG_RESTART, &cam->flags); | ||
668 | spin_unlock_irqrestore(&cam->dev_lock, flags); | 678 | spin_unlock_irqrestore(&cam->dev_lock, flags); |
669 | return 0; | 679 | return 0; |
670 | } | 680 | } |
@@ -873,7 +883,8 @@ static int mcam_read_setup(struct mcam_camera *cam) | |||
873 | mcam_reset_buffers(cam); | 883 | mcam_reset_buffers(cam); |
874 | mcam_ctlr_irq_enable(cam); | 884 | mcam_ctlr_irq_enable(cam); |
875 | cam->state = S_STREAMING; | 885 | cam->state = S_STREAMING; |
876 | mcam_ctlr_start(cam); | 886 | if (!test_bit(CF_SG_RESTART, &cam->flags)) |
887 | mcam_ctlr_start(cam); | ||
877 | spin_unlock_irqrestore(&cam->dev_lock, flags); | 888 | spin_unlock_irqrestore(&cam->dev_lock, flags); |
878 | return 0; | 889 | return 0; |
879 | } | 890 | } |
@@ -1818,11 +1829,15 @@ void mccic_shutdown(struct mcam_camera *cam) | |||
1818 | 1829 | ||
1819 | void mccic_suspend(struct mcam_camera *cam) | 1830 | void mccic_suspend(struct mcam_camera *cam) |
1820 | { | 1831 | { |
1821 | enum mcam_state cstate = cam->state; | 1832 | mutex_lock(&cam->s_mutex); |
1833 | if (cam->users > 0) { | ||
1834 | enum mcam_state cstate = cam->state; | ||
1822 | 1835 | ||
1823 | mcam_ctlr_stop_dma(cam); | 1836 | mcam_ctlr_stop_dma(cam); |
1824 | mcam_ctlr_power_down(cam); | 1837 | mcam_ctlr_power_down(cam); |
1825 | cam->state = cstate; | 1838 | cam->state = cstate; |
1839 | } | ||
1840 | mutex_unlock(&cam->s_mutex); | ||
1826 | } | 1841 | } |
1827 | 1842 | ||
1828 | int mccic_resume(struct mcam_camera *cam) | 1843 | int mccic_resume(struct mcam_camera *cam) |
@@ -1839,8 +1854,15 @@ int mccic_resume(struct mcam_camera *cam) | |||
1839 | mutex_unlock(&cam->s_mutex); | 1854 | mutex_unlock(&cam->s_mutex); |
1840 | 1855 | ||
1841 | set_bit(CF_CONFIG_NEEDED, &cam->flags); | 1856 | set_bit(CF_CONFIG_NEEDED, &cam->flags); |
1842 | if (cam->state == S_STREAMING) | 1857 | if (cam->state == S_STREAMING) { |
1858 | /* | ||
1859 | * If there was a buffer in the DMA engine at suspend | ||
1860 | * time, put it back on the queue or we'll forget about it. | ||
1861 | */ | ||
1862 | if (cam->buffer_mode == B_DMA_sg && cam->vb_bufs[0]) | ||
1863 | list_add(&cam->vb_bufs[0]->queue, &cam->buffers); | ||
1843 | ret = mcam_read_setup(cam); | 1864 | ret = mcam_read_setup(cam); |
1865 | } | ||
1844 | return ret; | 1866 | return ret; |
1845 | } | 1867 | } |
1846 | #endif /* CONFIG_PM */ | 1868 | #endif /* CONFIG_PM */ |