diff options
author | Mel Gorman <mgorman@suse.de> | 2012-01-12 20:19:43 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-08-01 15:27:18 -0400 |
commit | f869774c37710ef2b773d167d184b9936988d07f (patch) | |
tree | 6cb482ccf2bc641c5b7c9cc324af2e5f877b2887 /fs/btrfs/disk-io.c | |
parent | 9203b3fa57cc16bf1ad1be7c64b01b5e45cc6151 (diff) |
mm: compaction: introduce sync-light migration for use by compaction
commit a6bc32b899223a877f595ef9ddc1e89ead5072b8 upstream.
Stable note: Not tracked in Buzilla. This was part of a series that
reduced interactivity stalls experienced when THP was enabled.
These stalls were particularly noticable when copying data
to a USB stick but the experiences for users varied a lot.
This patch adds a lightweight sync migrate operation MIGRATE_SYNC_LIGHT
mode that avoids writing back pages to backing storage. Async compaction
maps to MIGRATE_ASYNC while sync compaction maps to MIGRATE_SYNC_LIGHT.
For other migrate_pages users such as memory hotplug, MIGRATE_SYNC is
used.
This avoids sync compaction stalling for an excessive length of time,
particularly when copying files to a USB stick where there might be a
large number of dirty pages backed by a filesystem that does not support
->writepages.
[aarcange@redhat.com: This patch is heavily based on Andrea's work]
[akpm@linux-foundation.org: fix fs/nfs/write.c build]
[akpm@linux-foundation.org: fix fs/btrfs/disk-io.c build]
Signed-off-by: Mel Gorman <mgorman@suse.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
Cc: Dave Jones <davej@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Andy Isaacson <adi@hexapodia.org>
Cc: Nai Xia <nai.xia@gmail.com>
Cc: Johannes Weiner <jweiner@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Mel Gorman <mgorman@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/btrfs/disk-io.c')
-rw-r--r-- | fs/btrfs/disk-io.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 522cb2a6cb1..57106a99b52 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c | |||
@@ -801,7 +801,8 @@ static int btree_submit_bio_hook(struct inode *inode, int rw, struct bio *bio, | |||
801 | 801 | ||
802 | #ifdef CONFIG_MIGRATION | 802 | #ifdef CONFIG_MIGRATION |
803 | static int btree_migratepage(struct address_space *mapping, | 803 | static int btree_migratepage(struct address_space *mapping, |
804 | struct page *newpage, struct page *page, bool sync) | 804 | struct page *newpage, struct page *page, |
805 | enum migrate_mode mode) | ||
805 | { | 806 | { |
806 | /* | 807 | /* |
807 | * we can't safely write a btree page from here, | 808 | * we can't safely write a btree page from here, |
@@ -816,7 +817,7 @@ static int btree_migratepage(struct address_space *mapping, | |||
816 | if (page_has_private(page) && | 817 | if (page_has_private(page) && |
817 | !try_to_release_page(page, GFP_KERNEL)) | 818 | !try_to_release_page(page, GFP_KERNEL)) |
818 | return -EAGAIN; | 819 | return -EAGAIN; |
819 | return migrate_page(mapping, newpage, page, sync); | 820 | return migrate_page(mapping, newpage, page, mode); |
820 | } | 821 | } |
821 | #endif | 822 | #endif |
822 | 823 | ||