aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorMel Gorman <mgorman@suse.de>2012-01-12 20:19:43 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-08-01 15:27:18 -0400
commitf869774c37710ef2b773d167d184b9936988d07f (patch)
tree6cb482ccf2bc641c5b7c9cc324af2e5f877b2887 /fs
parent9203b3fa57cc16bf1ad1be7c64b01b5e45cc6151 (diff)
mm: compaction: introduce sync-light migration for use by compaction
commit a6bc32b899223a877f595ef9ddc1e89ead5072b8 upstream. Stable note: Not tracked in Buzilla. This was part of a series that reduced interactivity stalls experienced when THP was enabled. These stalls were particularly noticable when copying data to a USB stick but the experiences for users varied a lot. This patch adds a lightweight sync migrate operation MIGRATE_SYNC_LIGHT mode that avoids writing back pages to backing storage. Async compaction maps to MIGRATE_ASYNC while sync compaction maps to MIGRATE_SYNC_LIGHT. For other migrate_pages users such as memory hotplug, MIGRATE_SYNC is used. This avoids sync compaction stalling for an excessive length of time, particularly when copying files to a USB stick where there might be a large number of dirty pages backed by a filesystem that does not support ->writepages. [aarcange@redhat.com: This patch is heavily based on Andrea's work] [akpm@linux-foundation.org: fix fs/nfs/write.c build] [akpm@linux-foundation.org: fix fs/btrfs/disk-io.c build] Signed-off-by: Mel Gorman <mgorman@suse.de> Reviewed-by: Rik van Riel <riel@redhat.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Cc: Minchan Kim <minchan.kim@gmail.com> Cc: Dave Jones <davej@redhat.com> Cc: Jan Kara <jack@suse.cz> Cc: Andy Isaacson <adi@hexapodia.org> Cc: Nai Xia <nai.xia@gmail.com> Cc: Johannes Weiner <jweiner@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Mel Gorman <mgorman@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/btrfs/disk-io.c5
-rw-r--r--fs/hugetlbfs/inode.c2
-rw-r--r--fs/nfs/internal.h2
-rw-r--r--fs/nfs/write.c4
4 files changed, 7 insertions, 6 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 522cb2a6cb1..57106a99b52 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -801,7 +801,8 @@ static int btree_submit_bio_hook(struct inode *inode, int rw, struct bio *bio,
801 801
802#ifdef CONFIG_MIGRATION 802#ifdef CONFIG_MIGRATION
803static int btree_migratepage(struct address_space *mapping, 803static int btree_migratepage(struct address_space *mapping,
804 struct page *newpage, struct page *page, bool sync) 804 struct page *newpage, struct page *page,
805 enum migrate_mode mode)
805{ 806{
806 /* 807 /*
807 * we can't safely write a btree page from here, 808 * we can't safely write a btree page from here,
@@ -816,7 +817,7 @@ static int btree_migratepage(struct address_space *mapping,
816 if (page_has_private(page) && 817 if (page_has_private(page) &&
817 !try_to_release_page(page, GFP_KERNEL)) 818 !try_to_release_page(page, GFP_KERNEL))
818 return -EAGAIN; 819 return -EAGAIN;
819 return migrate_page(mapping, newpage, page, sync); 820 return migrate_page(mapping, newpage, page, mode);
820} 821}
821#endif 822#endif
822 823
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 6ca608bbc8b..6327a069d83 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -569,7 +569,7 @@ static int hugetlbfs_set_page_dirty(struct page *page)
569 569
570static int hugetlbfs_migrate_page(struct address_space *mapping, 570static int hugetlbfs_migrate_page(struct address_space *mapping,
571 struct page *newpage, struct page *page, 571 struct page *newpage, struct page *page,
572 bool sync) 572 enum migrate_mode mode)
573{ 573{
574 int rc; 574 int rc;
575 575
diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
index a74442ae688..4f10d8188ab 100644
--- a/fs/nfs/internal.h
+++ b/fs/nfs/internal.h
@@ -315,7 +315,7 @@ void nfs_commit_release_pages(struct nfs_write_data *data);
315 315
316#ifdef CONFIG_MIGRATION 316#ifdef CONFIG_MIGRATION
317extern int nfs_migrate_page(struct address_space *, 317extern int nfs_migrate_page(struct address_space *,
318 struct page *, struct page *, bool); 318 struct page *, struct page *, enum migrate_mode);
319#else 319#else
320#define nfs_migrate_page NULL 320#define nfs_migrate_page NULL
321#endif 321#endif
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 22a48fdee3c..58bb9994b94 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -1662,7 +1662,7 @@ out_error:
1662 1662
1663#ifdef CONFIG_MIGRATION 1663#ifdef CONFIG_MIGRATION
1664int nfs_migrate_page(struct address_space *mapping, struct page *newpage, 1664int nfs_migrate_page(struct address_space *mapping, struct page *newpage,
1665 struct page *page, bool sync) 1665 struct page *page, enum migrate_mode mode)
1666{ 1666{
1667 /* 1667 /*
1668 * If PagePrivate is set, then the page is currently associated with 1668 * If PagePrivate is set, then the page is currently associated with
@@ -1677,7 +1677,7 @@ int nfs_migrate_page(struct address_space *mapping, struct page *newpage,
1677 1677
1678 nfs_fscache_release_page(page, GFP_KERNEL); 1678 nfs_fscache_release_page(page, GFP_KERNEL);
1679 1679
1680 return migrate_page(mapping, newpage, page, sync); 1680 return migrate_page(mapping, newpage, page, mode);
1681} 1681}
1682#endif 1682#endif
1683 1683