diff options
author | Jiang Liu <jiang.liu@linux.intel.com> | 2015-06-23 13:47:29 -0400 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2015-07-11 17:14:24 -0400 |
commit | a1ff541a40e90df05f586bf6b157083b351c4a0c (patch) | |
tree | d35b764ca2dc369848efa5d08c43f3fe04e93fe7 /kernel/irq/manage.c | |
parent | 0798abeb7eec37dcc20f252c2195fc31c41561f9 (diff) |
genirq: Remove irq arg from __irq_set_trigger()
It's only required for debug output and can be retrieved from the irq
descriptor if necessary.
[ tglx: Split out from combo patch ]
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/irq/manage.c')
-rw-r--r-- | kernel/irq/manage.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index c2e835d19bca..0559d9c0f658 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c | |||
@@ -637,8 +637,7 @@ int can_request_irq(unsigned int irq, unsigned long irqflags) | |||
637 | return canrequest; | 637 | return canrequest; |
638 | } | 638 | } |
639 | 639 | ||
640 | int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, | 640 | int __irq_set_trigger(struct irq_desc *desc, unsigned long flags) |
641 | unsigned long flags) | ||
642 | { | 641 | { |
643 | struct irq_chip *chip = desc->irq_data.chip; | 642 | struct irq_chip *chip = desc->irq_data.chip; |
644 | int ret, unmask = 0; | 643 | int ret, unmask = 0; |
@@ -648,7 +647,8 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, | |||
648 | * IRQF_TRIGGER_* but the PIC does not support multiple | 647 | * IRQF_TRIGGER_* but the PIC does not support multiple |
649 | * flow-types? | 648 | * flow-types? |
650 | */ | 649 | */ |
651 | pr_debug("No set_type function for IRQ %d (%s)\n", irq, | 650 | pr_debug("No set_type function for IRQ %d (%s)\n", |
651 | irq_desc_get_irq(desc), | ||
652 | chip ? (chip->name ? : "unknown") : "unknown"); | 652 | chip ? (chip->name ? : "unknown") : "unknown"); |
653 | return 0; | 653 | return 0; |
654 | } | 654 | } |
@@ -685,7 +685,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, | |||
685 | break; | 685 | break; |
686 | default: | 686 | default: |
687 | pr_err("Setting trigger mode %lu for irq %u failed (%pF)\n", | 687 | pr_err("Setting trigger mode %lu for irq %u failed (%pF)\n", |
688 | flags, irq, chip->irq_set_type); | 688 | flags, irq_desc_get_irq(desc), chip->irq_set_type); |
689 | } | 689 | } |
690 | if (unmask) | 690 | if (unmask) |
691 | unmask_irq(desc); | 691 | unmask_irq(desc); |
@@ -1221,8 +1221,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) | |||
1221 | 1221 | ||
1222 | /* Setup the type (level, edge polarity) if configured: */ | 1222 | /* Setup the type (level, edge polarity) if configured: */ |
1223 | if (new->flags & IRQF_TRIGGER_MASK) { | 1223 | if (new->flags & IRQF_TRIGGER_MASK) { |
1224 | ret = __irq_set_trigger(desc, irq, | 1224 | ret = __irq_set_trigger(desc, |
1225 | new->flags & IRQF_TRIGGER_MASK); | 1225 | new->flags & IRQF_TRIGGER_MASK); |
1226 | 1226 | ||
1227 | if (ret) | 1227 | if (ret) |
1228 | goto out_mask; | 1228 | goto out_mask; |
@@ -1650,7 +1650,7 @@ void enable_percpu_irq(unsigned int irq, unsigned int type) | |||
1650 | if (type != IRQ_TYPE_NONE) { | 1650 | if (type != IRQ_TYPE_NONE) { |
1651 | int ret; | 1651 | int ret; |
1652 | 1652 | ||
1653 | ret = __irq_set_trigger(desc, irq, type); | 1653 | ret = __irq_set_trigger(desc, type); |
1654 | 1654 | ||
1655 | if (ret) { | 1655 | if (ret) { |
1656 | WARN(1, "failed to set type for IRQ%d\n", irq); | 1656 | WARN(1, "failed to set type for IRQ%d\n", irq); |