diff options
-rw-r--r-- | kernel/irq/chip.c | 2 | ||||
-rw-r--r-- | kernel/irq/internals.h | 3 | ||||
-rw-r--r-- | kernel/irq/manage.c | 14 |
3 files changed, 9 insertions, 10 deletions
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 0cfbd1506e35..310d65885440 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c | |||
@@ -63,7 +63,7 @@ int irq_set_irq_type(unsigned int irq, unsigned int type) | |||
63 | return -EINVAL; | 63 | return -EINVAL; |
64 | 64 | ||
65 | type &= IRQ_TYPE_SENSE_MASK; | 65 | type &= IRQ_TYPE_SENSE_MASK; |
66 | ret = __irq_set_trigger(desc, irq, type); | 66 | ret = __irq_set_trigger(desc, type); |
67 | irq_put_desc_busunlock(desc, flags); | 67 | irq_put_desc_busunlock(desc, flags); |
68 | return ret; | 68 | return ret; |
69 | } | 69 | } |
diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h index 7054947e368e..429c5e34d619 100644 --- a/kernel/irq/internals.h +++ b/kernel/irq/internals.h | |||
@@ -59,8 +59,7 @@ enum { | |||
59 | #include "debug.h" | 59 | #include "debug.h" |
60 | #include "settings.h" | 60 | #include "settings.h" |
61 | 61 | ||
62 | extern int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, | 62 | extern int __irq_set_trigger(struct irq_desc *desc, unsigned long flags); |
63 | unsigned long flags); | ||
64 | extern void __disable_irq(struct irq_desc *desc, unsigned int irq); | 63 | extern void __disable_irq(struct irq_desc *desc, unsigned int irq); |
65 | extern void __enable_irq(struct irq_desc *desc, unsigned int irq); | 64 | extern void __enable_irq(struct irq_desc *desc, unsigned int irq); |
66 | 65 | ||
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index c2e835d19bca..0559d9c0f658 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c | |||
@@ -637,8 +637,7 @@ int can_request_irq(unsigned int irq, unsigned long irqflags) | |||
637 | return canrequest; | 637 | return canrequest; |
638 | } | 638 | } |
639 | 639 | ||
640 | int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, | 640 | int __irq_set_trigger(struct irq_desc *desc, unsigned long flags) |
641 | unsigned long flags) | ||
642 | { | 641 | { |
643 | struct irq_chip *chip = desc->irq_data.chip; | 642 | struct irq_chip *chip = desc->irq_data.chip; |
644 | int ret, unmask = 0; | 643 | int ret, unmask = 0; |
@@ -648,7 +647,8 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, | |||
648 | * IRQF_TRIGGER_* but the PIC does not support multiple | 647 | * IRQF_TRIGGER_* but the PIC does not support multiple |
649 | * flow-types? | 648 | * flow-types? |
650 | */ | 649 | */ |
651 | pr_debug("No set_type function for IRQ %d (%s)\n", irq, | 650 | pr_debug("No set_type function for IRQ %d (%s)\n", |
651 | irq_desc_get_irq(desc), | ||
652 | chip ? (chip->name ? : "unknown") : "unknown"); | 652 | chip ? (chip->name ? : "unknown") : "unknown"); |
653 | return 0; | 653 | return 0; |
654 | } | 654 | } |
@@ -685,7 +685,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, | |||
685 | break; | 685 | break; |
686 | default: | 686 | default: |
687 | pr_err("Setting trigger mode %lu for irq %u failed (%pF)\n", | 687 | pr_err("Setting trigger mode %lu for irq %u failed (%pF)\n", |
688 | flags, irq, chip->irq_set_type); | 688 | flags, irq_desc_get_irq(desc), chip->irq_set_type); |
689 | } | 689 | } |
690 | if (unmask) | 690 | if (unmask) |
691 | unmask_irq(desc); | 691 | unmask_irq(desc); |
@@ -1221,8 +1221,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) | |||
1221 | 1221 | ||
1222 | /* Setup the type (level, edge polarity) if configured: */ | 1222 | /* Setup the type (level, edge polarity) if configured: */ |
1223 | if (new->flags & IRQF_TRIGGER_MASK) { | 1223 | if (new->flags & IRQF_TRIGGER_MASK) { |
1224 | ret = __irq_set_trigger(desc, irq, | 1224 | ret = __irq_set_trigger(desc, |
1225 | new->flags & IRQF_TRIGGER_MASK); | 1225 | new->flags & IRQF_TRIGGER_MASK); |
1226 | 1226 | ||
1227 | if (ret) | 1227 | if (ret) |
1228 | goto out_mask; | 1228 | goto out_mask; |
@@ -1650,7 +1650,7 @@ void enable_percpu_irq(unsigned int irq, unsigned int type) | |||
1650 | if (type != IRQ_TYPE_NONE) { | 1650 | if (type != IRQ_TYPE_NONE) { |
1651 | int ret; | 1651 | int ret; |
1652 | 1652 | ||
1653 | ret = __irq_set_trigger(desc, irq, type); | 1653 | ret = __irq_set_trigger(desc, type); |
1654 | 1654 | ||
1655 | if (ret) { | 1655 | if (ret) { |
1656 | WARN(1, "failed to set type for IRQ%d\n", irq); | 1656 | WARN(1, "failed to set type for IRQ%d\n", irq); |