aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pwm/pwm-tegra.c
diff options
context:
space:
mode:
authorLaxman Dewangan <ldewangan@nvidia.com>2017-04-07 05:34:00 -0400
committerThierry Reding <thierry.reding@gmail.com>2017-04-12 10:08:15 -0400
commit250b76f43f57d578ebff5e7211eb2c73aa5cd6ca (patch)
treee0635c1349f94e77e02ade5103052124b7d75f5e /drivers/pwm/pwm-tegra.c
parent90241fb9b55a36edd9dafb8de679f66836e84369 (diff)
pwm: tegra: Increase precision in PWM rate calculation
The rate of the PWM calculated as follows: hz = NSEC_PER_SEC / period_ns; rate = (rate + (hz / 2)) / hz; This has the precision loss in lower PWM rate. Change this to have more precision as: hz = DIV_ROUND_CLOSEST_ULL(NSEC_PER_SEC * 100, period_ns); rate = DIV_ROUND_CLOSEST(rate * 100, hz) Example: 1. period_ns = 16672000, PWM clock rate is 200 KHz. Based on old formula hz = NSEC_PER_SEC / period_ns = 1000000000ul/16672000 = 59 (59.98) rate = (200K + 59/2)/59 = 3390 Based on new method: hz = 5998 rate = DIV_ROUND_CLOSE(200000*100, 5998) = 3334 If we measure the PWM signal rate, we will get more accurate period with rate value of 3334 instead of 3390. 2. period_ns = 16803898, PWM clock rate is 200 KHz. Based on old formula: hz = 59, rate = 3390 Based on new formula: hz = 5951, rate = 3360 The PWM signal rate of 3360 is more near to requested period than 3333. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm/pwm-tegra.c')
-rw-r--r--drivers/pwm/pwm-tegra.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
index 0a688dabd670..21518bea00c6 100644
--- a/drivers/pwm/pwm-tegra.c
+++ b/drivers/pwm/pwm-tegra.c
@@ -76,6 +76,7 @@ static int tegra_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
76 struct tegra_pwm_chip *pc = to_tegra_pwm_chip(chip); 76 struct tegra_pwm_chip *pc = to_tegra_pwm_chip(chip);
77 unsigned long long c = duty_ns; 77 unsigned long long c = duty_ns;
78 unsigned long rate, hz; 78 unsigned long rate, hz;
79 unsigned long long ns100 = NSEC_PER_SEC;
79 u32 val = 0; 80 u32 val = 0;
80 int err; 81 int err;
81 82
@@ -94,9 +95,11 @@ static int tegra_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
94 * cycles at the PWM clock rate will take period_ns nanoseconds. 95 * cycles at the PWM clock rate will take period_ns nanoseconds.
95 */ 96 */
96 rate = clk_get_rate(pc->clk) >> PWM_DUTY_WIDTH; 97 rate = clk_get_rate(pc->clk) >> PWM_DUTY_WIDTH;
97 hz = NSEC_PER_SEC / period_ns;
98 98
99 rate = (rate + (hz / 2)) / hz; 99 /* Consider precision in PWM_SCALE_WIDTH rate calculation */
100 ns100 *= 100;
101 hz = DIV_ROUND_CLOSEST_ULL(ns100, period_ns);
102 rate = DIV_ROUND_CLOSEST(rate * 100, hz);
100 103
101 /* 104 /*
102 * Since the actual PWM divider is the register's frequency divider 105 * Since the actual PWM divider is the register's frequency divider