diff options
author | Ivan Vecera <ivecera@redhat.com> | 2015-10-15 15:28:52 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-10-16 03:24:10 -0400 |
commit | 47ea0325337b166c1c8695119aa6e83cdc035ef5 (patch) | |
tree | 98d31ead764ef2c3b71843fd8926f90115a690a6 /drivers/net/ethernet/ibm | |
parent | ae23051820461bdc960b76d766e7c1e92dee2ee1 (diff) |
drivers/net: get rid of unnecessary initializations in .get_drvinfo()
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().
v2: removed unused variable
v3: removed another unused variable
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/ibm')
-rw-r--r-- | drivers/net/ethernet/ibm/emac/core.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c index b60a34d982a9..5d7db6c01c46 100644 --- a/drivers/net/ethernet/ibm/emac/core.c +++ b/drivers/net/ethernet/ibm/emac/core.c | |||
@@ -2204,7 +2204,6 @@ static void emac_ethtool_get_drvinfo(struct net_device *ndev, | |||
2204 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); | 2204 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); |
2205 | snprintf(info->bus_info, sizeof(info->bus_info), "PPC 4xx EMAC-%d %s", | 2205 | snprintf(info->bus_info, sizeof(info->bus_info), "PPC 4xx EMAC-%d %s", |
2206 | dev->cell_index, dev->ofdev->dev.of_node->full_name); | 2206 | dev->cell_index, dev->ofdev->dev.of_node->full_name); |
2207 | info->regdump_len = emac_ethtool_get_regs_len(ndev); | ||
2208 | } | 2207 | } |
2209 | 2208 | ||
2210 | static const struct ethtool_ops emac_ethtool_ops = { | 2209 | static const struct ethtool_ops emac_ethtool_ops = { |