diff options
author | Ivan Vecera <ivecera@redhat.com> | 2015-10-15 15:28:52 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-10-16 03:24:10 -0400 |
commit | 47ea0325337b166c1c8695119aa6e83cdc035ef5 (patch) | |
tree | 98d31ead764ef2c3b71843fd8926f90115a690a6 | |
parent | ae23051820461bdc960b76d766e7c1e92dee2ee1 (diff) |
drivers/net: get rid of unnecessary initializations in .get_drvinfo()
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().
v2: removed unused variable
v3: removed another unused variable
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
50 files changed, 0 insertions, 113 deletions
diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c index 70acda91eb2a..6a0bdfa0ce2e 100644 --- a/drivers/infiniband/hw/nes/nes_nic.c +++ b/drivers/infiniband/hw/nes/nes_nic.c | |||
@@ -1325,9 +1325,6 @@ static void nes_netdev_get_drvinfo(struct net_device *netdev, | |||
1325 | "%u.%u", nesadapter->firmware_version >> 16, | 1325 | "%u.%u", nesadapter->firmware_version >> 16, |
1326 | nesadapter->firmware_version & 0x000000ff); | 1326 | nesadapter->firmware_version & 0x000000ff); |
1327 | strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version)); | 1327 | strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version)); |
1328 | drvinfo->testinfo_len = 0; | ||
1329 | drvinfo->eedump_len = 0; | ||
1330 | drvinfo->regdump_len = 0; | ||
1331 | } | 1328 | } |
1332 | 1329 | ||
1333 | 1330 | ||
diff --git a/drivers/net/ethernet/aeroflex/greth.c b/drivers/net/ethernet/aeroflex/greth.c index ae89de7deb13..20bf55dbd76f 100644 --- a/drivers/net/ethernet/aeroflex/greth.c +++ b/drivers/net/ethernet/aeroflex/greth.c | |||
@@ -1141,8 +1141,6 @@ static void greth_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *in | |||
1141 | strlcpy(info->version, "revision: 1.0", sizeof(info->version)); | 1141 | strlcpy(info->version, "revision: 1.0", sizeof(info->version)); |
1142 | strlcpy(info->bus_info, greth->dev->bus->name, sizeof(info->bus_info)); | 1142 | strlcpy(info->bus_info, greth->dev->bus->name, sizeof(info->bus_info)); |
1143 | strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); | 1143 | strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); |
1144 | info->eedump_len = 0; | ||
1145 | info->regdump_len = sizeof(struct greth_regs); | ||
1146 | } | 1144 | } |
1147 | 1145 | ||
1148 | static void greth_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *p) | 1146 | static void greth_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *p) |
diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c index cb367cc59e0b..5330bcb8a944 100644 --- a/drivers/net/ethernet/amd/au1000_eth.c +++ b/drivers/net/ethernet/amd/au1000_eth.c | |||
@@ -714,7 +714,6 @@ au1000_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) | |||
714 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); | 714 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); |
715 | snprintf(info->bus_info, sizeof(info->bus_info), "%s %d", DRV_NAME, | 715 | snprintf(info->bus_info, sizeof(info->bus_info), "%s %d", DRV_NAME, |
716 | aup->mac_id); | 716 | aup->mac_id); |
717 | info->regdump_len = 0; | ||
718 | } | 717 | } |
719 | 718 | ||
720 | static void au1000_set_msglevel(struct net_device *dev, u32 value) | 719 | static void au1000_set_msglevel(struct net_device *dev, u32 value) |
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c index 204fb3afb182..6040293db9c1 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c | |||
@@ -375,7 +375,6 @@ static void xgbe_get_drvinfo(struct net_device *netdev, | |||
375 | XGMAC_GET_BITS(hw_feat->version, MAC_VR, USERVER), | 375 | XGMAC_GET_BITS(hw_feat->version, MAC_VR, USERVER), |
376 | XGMAC_GET_BITS(hw_feat->version, MAC_VR, DEVID), | 376 | XGMAC_GET_BITS(hw_feat->version, MAC_VR, DEVID), |
377 | XGMAC_GET_BITS(hw_feat->version, MAC_VR, SNPSVER)); | 377 | XGMAC_GET_BITS(hw_feat->version, MAC_VR, SNPSVER)); |
378 | drvinfo->n_stats = XGBE_STATS_COUNT; | ||
379 | } | 378 | } |
380 | 379 | ||
381 | static u32 xgbe_get_msglevel(struct net_device *netdev) | 380 | static u32 xgbe_get_msglevel(struct net_device *netdev) |
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c b/drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c index 48694c239d5c..872b7abb0196 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c | |||
@@ -233,10 +233,6 @@ static void atl1c_get_drvinfo(struct net_device *netdev, | |||
233 | sizeof(drvinfo->version)); | 233 | sizeof(drvinfo->version)); |
234 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 234 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
235 | sizeof(drvinfo->bus_info)); | 235 | sizeof(drvinfo->bus_info)); |
236 | drvinfo->n_stats = 0; | ||
237 | drvinfo->testinfo_len = 0; | ||
238 | drvinfo->regdump_len = atl1c_get_regs_len(netdev); | ||
239 | drvinfo->eedump_len = atl1c_get_eeprom_len(netdev); | ||
240 | } | 236 | } |
241 | 237 | ||
242 | static void atl1c_get_wol(struct net_device *netdev, | 238 | static void atl1c_get_wol(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.c b/drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.c index 1be072f4afc2..8e3dbd4d9f79 100644 --- a/drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.c +++ b/drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.c | |||
@@ -316,10 +316,6 @@ static void atl1e_get_drvinfo(struct net_device *netdev, | |||
316 | strlcpy(drvinfo->fw_version, "L1e", sizeof(drvinfo->fw_version)); | 316 | strlcpy(drvinfo->fw_version, "L1e", sizeof(drvinfo->fw_version)); |
317 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 317 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
318 | sizeof(drvinfo->bus_info)); | 318 | sizeof(drvinfo->bus_info)); |
319 | drvinfo->n_stats = 0; | ||
320 | drvinfo->testinfo_len = 0; | ||
321 | drvinfo->regdump_len = atl1e_get_regs_len(netdev); | ||
322 | drvinfo->eedump_len = atl1e_get_eeprom_len(netdev); | ||
323 | } | 319 | } |
324 | 320 | ||
325 | static void atl1e_get_wol(struct net_device *netdev, | 321 | static void atl1e_get_wol(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c index eca1d113fee1..529bca718334 100644 --- a/drivers/net/ethernet/atheros/atlx/atl1.c +++ b/drivers/net/ethernet/atheros/atlx/atl1.c | |||
@@ -3388,7 +3388,6 @@ static void atl1_get_drvinfo(struct net_device *netdev, | |||
3388 | sizeof(drvinfo->version)); | 3388 | sizeof(drvinfo->version)); |
3389 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 3389 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
3390 | sizeof(drvinfo->bus_info)); | 3390 | sizeof(drvinfo->bus_info)); |
3391 | drvinfo->eedump_len = ATL1_EEDUMP_LEN; | ||
3392 | } | 3391 | } |
3393 | 3392 | ||
3394 | static void atl1_get_wol(struct net_device *netdev, | 3393 | static void atl1_get_wol(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c index 46a535318c7a..8f76f4558a88 100644 --- a/drivers/net/ethernet/atheros/atlx/atl2.c +++ b/drivers/net/ethernet/atheros/atlx/atl2.c | |||
@@ -2030,10 +2030,6 @@ static void atl2_get_drvinfo(struct net_device *netdev, | |||
2030 | strlcpy(drvinfo->fw_version, "L2", sizeof(drvinfo->fw_version)); | 2030 | strlcpy(drvinfo->fw_version, "L2", sizeof(drvinfo->fw_version)); |
2031 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 2031 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
2032 | sizeof(drvinfo->bus_info)); | 2032 | sizeof(drvinfo->bus_info)); |
2033 | drvinfo->n_stats = 0; | ||
2034 | drvinfo->testinfo_len = 0; | ||
2035 | drvinfo->regdump_len = atl2_get_regs_len(netdev); | ||
2036 | drvinfo->eedump_len = atl2_get_eeprom_len(netdev); | ||
2037 | } | 2033 | } |
2038 | 2034 | ||
2039 | static void atl2_get_wol(struct net_device *netdev, | 2035 | static void atl2_get_wol(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c index a7f2cc3e485e..95af75d35bc5 100644 --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c | |||
@@ -1333,7 +1333,6 @@ static void bcm_enet_get_drvinfo(struct net_device *netdev, | |||
1333 | sizeof(drvinfo->version)); | 1333 | sizeof(drvinfo->version)); |
1334 | strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); | 1334 | strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); |
1335 | strlcpy(drvinfo->bus_info, "bcm63xx", sizeof(drvinfo->bus_info)); | 1335 | strlcpy(drvinfo->bus_info, "bcm63xx", sizeof(drvinfo->bus_info)); |
1336 | drvinfo->n_stats = BCM_ENET_STATS_LEN; | ||
1337 | } | 1336 | } |
1338 | 1337 | ||
1339 | static int bcm_enet_get_sset_count(struct net_device *netdev, | 1338 | static int bcm_enet_get_sset_count(struct net_device *netdev, |
@@ -2597,7 +2596,6 @@ static void bcm_enetsw_get_drvinfo(struct net_device *netdev, | |||
2597 | strncpy(drvinfo->version, bcm_enet_driver_version, 32); | 2596 | strncpy(drvinfo->version, bcm_enet_driver_version, 32); |
2598 | strncpy(drvinfo->fw_version, "N/A", 32); | 2597 | strncpy(drvinfo->fw_version, "N/A", 32); |
2599 | strncpy(drvinfo->bus_info, "bcm63xx", 32); | 2598 | strncpy(drvinfo->bus_info, "bcm63xx", 32); |
2600 | drvinfo->n_stats = BCM_ENETSW_STATS_LEN; | ||
2601 | } | 2599 | } |
2602 | 2600 | ||
2603 | static void bcm_enetsw_get_ethtool_stats(struct net_device *netdev, | 2601 | static void bcm_enetsw_get_ethtool_stats(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index f1b5364f3521..858106352ce9 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c | |||
@@ -287,7 +287,6 @@ static void bcm_sysport_get_drvinfo(struct net_device *dev, | |||
287 | strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver)); | 287 | strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver)); |
288 | strlcpy(info->version, "0.1", sizeof(info->version)); | 288 | strlcpy(info->version, "0.1", sizeof(info->version)); |
289 | strlcpy(info->bus_info, "platform", sizeof(info->bus_info)); | 289 | strlcpy(info->bus_info, "platform", sizeof(info->bus_info)); |
290 | info->n_stats = BCM_SYSPORT_STATS_LEN; | ||
291 | } | 290 | } |
292 | 291 | ||
293 | static u32 bcm_sysport_get_msglvl(struct net_device *dev) | 292 | static u32 bcm_sysport_get_msglvl(struct net_device *dev) |
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c index aeb7ce64452e..a2bc5314a62b 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | |||
@@ -1090,10 +1090,6 @@ static void bnx2x_get_drvinfo(struct net_device *dev, | |||
1090 | bnx2x_fill_fw_str(bp, info->fw_version, sizeof(info->fw_version)); | 1090 | bnx2x_fill_fw_str(bp, info->fw_version, sizeof(info->fw_version)); |
1091 | 1091 | ||
1092 | strlcpy(info->bus_info, pci_name(bp->pdev), sizeof(info->bus_info)); | 1092 | strlcpy(info->bus_info, pci_name(bp->pdev), sizeof(info->bus_info)); |
1093 | info->n_stats = BNX2X_NUM_STATS; | ||
1094 | info->testinfo_len = BNX2X_NUM_TESTS(bp); | ||
1095 | info->eedump_len = bp->common.flash_size; | ||
1096 | info->regdump_len = bnx2x_get_regs_len(dev); | ||
1097 | } | 1093 | } |
1098 | 1094 | ||
1099 | static void bnx2x_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol) | 1095 | static void bnx2x_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol) |
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 1a3988f51305..410995cd7ea4 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c | |||
@@ -793,7 +793,6 @@ static void bcmgenet_get_drvinfo(struct net_device *dev, | |||
793 | { | 793 | { |
794 | strlcpy(info->driver, "bcmgenet", sizeof(info->driver)); | 794 | strlcpy(info->driver, "bcmgenet", sizeof(info->driver)); |
795 | strlcpy(info->version, "v2.0", sizeof(info->version)); | 795 | strlcpy(info->version, "v2.0", sizeof(info->version)); |
796 | info->n_stats = BCMGENET_STATS_LEN; | ||
797 | } | 796 | } |
798 | 797 | ||
799 | static int bcmgenet_get_sset_count(struct net_device *dev, int string_set) | 798 | static int bcmgenet_get_sset_count(struct net_device *dev, int string_set) |
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c index 29f330831784..245c063ed4db 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | |||
@@ -153,7 +153,6 @@ lio_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) | |||
153 | strncpy(drvinfo->fw_version, oct->fw_info.liquidio_firmware_version, | 153 | strncpy(drvinfo->fw_version, oct->fw_info.liquidio_firmware_version, |
154 | ETHTOOL_FWVERS_LEN); | 154 | ETHTOOL_FWVERS_LEN); |
155 | strncpy(drvinfo->bus_info, pci_name(oct->pci_dev), 32); | 155 | strncpy(drvinfo->bus_info, pci_name(oct->pci_dev), 32); |
156 | drvinfo->regdump_len = OCT_ETHTOOL_REGDUMP_LEN; | ||
157 | } | 156 | } |
158 | 157 | ||
159 | static void | 158 | static void |
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c index a02ecc4f9002..cadcee645f74 100644 --- a/drivers/net/ethernet/dec/tulip/de2104x.c +++ b/drivers/net/ethernet/dec/tulip/de2104x.c | |||
@@ -1597,7 +1597,6 @@ static void de_get_drvinfo (struct net_device *dev,struct ethtool_drvinfo *info) | |||
1597 | strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); | 1597 | strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); |
1598 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); | 1598 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); |
1599 | strlcpy(info->bus_info, pci_name(de->pdev), sizeof(info->bus_info)); | 1599 | strlcpy(info->bus_info, pci_name(de->pdev), sizeof(info->bus_info)); |
1600 | info->eedump_len = DE_EEPROM_SIZE; | ||
1601 | } | 1600 | } |
1602 | 1601 | ||
1603 | static int de_get_regs_len(struct net_device *dev) | 1602 | static int de_get_regs_len(struct net_device *dev) |
diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c index 2c9ed1710ba6..f4cb8e425853 100644 --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c | |||
@@ -234,9 +234,6 @@ static void be_get_drvinfo(struct net_device *netdev, | |||
234 | 234 | ||
235 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 235 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
236 | sizeof(drvinfo->bus_info)); | 236 | sizeof(drvinfo->bus_info)); |
237 | drvinfo->testinfo_len = 0; | ||
238 | drvinfo->regdump_len = 0; | ||
239 | drvinfo->eedump_len = 0; | ||
240 | } | 237 | } |
241 | 238 | ||
242 | static u32 lancer_cmd_get_file_len(struct be_adapter *adapter, u8 *file_name) | 239 | static u32 lancer_cmd_get_file_len(struct be_adapter *adapter, u8 *file_name) |
diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index fb7f8d67aef4..928ca2bdd238 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c | |||
@@ -182,8 +182,6 @@ static void gfar_gdrvinfo(struct net_device *dev, | |||
182 | sizeof(drvinfo->version)); | 182 | sizeof(drvinfo->version)); |
183 | strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); | 183 | strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); |
184 | strlcpy(drvinfo->bus_info, "N/A", sizeof(drvinfo->bus_info)); | 184 | strlcpy(drvinfo->bus_info, "N/A", sizeof(drvinfo->bus_info)); |
185 | drvinfo->regdump_len = 0; | ||
186 | drvinfo->eedump_len = 0; | ||
187 | } | 185 | } |
188 | 186 | ||
189 | 187 | ||
diff --git a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c index cc83350d56ba..89714f5e0dfc 100644 --- a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c +++ b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c | |||
@@ -351,8 +351,6 @@ uec_get_drvinfo(struct net_device *netdev, | |||
351 | strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version)); | 351 | strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version)); |
352 | strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); | 352 | strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); |
353 | strlcpy(drvinfo->bus_info, "QUICC ENGINE", sizeof(drvinfo->bus_info)); | 353 | strlcpy(drvinfo->bus_info, "QUICC ENGINE", sizeof(drvinfo->bus_info)); |
354 | drvinfo->eedump_len = 0; | ||
355 | drvinfo->regdump_len = uec_get_regs_len(netdev); | ||
356 | } | 354 | } |
357 | 355 | ||
358 | #ifdef CONFIG_PM | 356 | #ifdef CONFIG_PM |
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c index 2550208cb22e..7d58918abb78 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | |||
@@ -682,7 +682,6 @@ static void hns_nic_get_drvinfo(struct net_device *net_dev, | |||
682 | drvinfo->bus_info[ETHTOOL_BUSINFO_LEN - 1] = '\0'; | 682 | drvinfo->bus_info[ETHTOOL_BUSINFO_LEN - 1] = '\0'; |
683 | 683 | ||
684 | strncpy(drvinfo->fw_version, "N/A", ETHTOOL_FWVERS_LEN); | 684 | strncpy(drvinfo->fw_version, "N/A", ETHTOOL_FWVERS_LEN); |
685 | drvinfo->eedump_len = 0; | ||
686 | } | 685 | } |
687 | 686 | ||
688 | /** | 687 | /** |
diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c index b60a34d982a9..5d7db6c01c46 100644 --- a/drivers/net/ethernet/ibm/emac/core.c +++ b/drivers/net/ethernet/ibm/emac/core.c | |||
@@ -2204,7 +2204,6 @@ static void emac_ethtool_get_drvinfo(struct net_device *ndev, | |||
2204 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); | 2204 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); |
2205 | snprintf(info->bus_info, sizeof(info->bus_info), "PPC 4xx EMAC-%d %s", | 2205 | snprintf(info->bus_info, sizeof(info->bus_info), "PPC 4xx EMAC-%d %s", |
2206 | dev->cell_index, dev->ofdev->dev.of_node->full_name); | 2206 | dev->cell_index, dev->ofdev->dev.of_node->full_name); |
2207 | info->regdump_len = emac_ethtool_get_regs_len(ndev); | ||
2208 | } | 2207 | } |
2209 | 2208 | ||
2210 | static const struct ethtool_ops emac_ethtool_ops = { | 2209 | static const struct ethtool_ops emac_ethtool_ops = { |
diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c index 4270ad2d4ddf..83e557c7f279 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c +++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c | |||
@@ -559,8 +559,6 @@ static void e1000_get_drvinfo(struct net_device *netdev, | |||
559 | 559 | ||
560 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 560 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
561 | sizeof(drvinfo->bus_info)); | 561 | sizeof(drvinfo->bus_info)); |
562 | drvinfo->regdump_len = e1000_get_regs_len(netdev); | ||
563 | drvinfo->eedump_len = e1000_get_eeprom_len(netdev); | ||
564 | } | 562 | } |
565 | 563 | ||
566 | static void e1000_get_ringparam(struct net_device *netdev, | 564 | static void e1000_get_ringparam(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index ad6daa656d3e..6cab1f30d41e 100644 --- a/drivers/net/ethernet/intel/e1000e/ethtool.c +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c | |||
@@ -648,8 +648,6 @@ static void e1000_get_drvinfo(struct net_device *netdev, | |||
648 | 648 | ||
649 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 649 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
650 | sizeof(drvinfo->bus_info)); | 650 | sizeof(drvinfo->bus_info)); |
651 | drvinfo->regdump_len = e1000_get_regs_len(netdev); | ||
652 | drvinfo->eedump_len = e1000_get_eeprom_len(netdev); | ||
653 | } | 651 | } |
654 | 652 | ||
655 | static void e1000_get_ringparam(struct net_device *netdev, | 653 | static void e1000_get_ringparam(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c index 447a5f8da42f..2ce0eba5e040 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | |||
@@ -515,10 +515,6 @@ static void fm10k_get_drvinfo(struct net_device *dev, | |||
515 | sizeof(info->version) - 1); | 515 | sizeof(info->version) - 1); |
516 | strncpy(info->bus_info, pci_name(interface->pdev), | 516 | strncpy(info->bus_info, pci_name(interface->pdev), |
517 | sizeof(info->bus_info) - 1); | 517 | sizeof(info->bus_info) - 1); |
518 | |||
519 | info->n_stats = fm10k_get_sset_count(dev, ETH_SS_STATS); | ||
520 | |||
521 | info->regdump_len = fm10k_get_regs_len(dev); | ||
522 | } | 518 | } |
523 | 519 | ||
524 | static void fm10k_get_pauseparam(struct net_device *dev, | 520 | static void fm10k_get_pauseparam(struct net_device *dev, |
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index ed70a3f18815..e7fd84c5b9f3 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c | |||
@@ -1126,7 +1126,6 @@ static void i40e_get_drvinfo(struct net_device *netdev, | |||
1126 | sizeof(drvinfo->fw_version)); | 1126 | sizeof(drvinfo->fw_version)); |
1127 | strlcpy(drvinfo->bus_info, pci_name(pf->pdev), | 1127 | strlcpy(drvinfo->bus_info, pci_name(pf->pdev), |
1128 | sizeof(drvinfo->bus_info)); | 1128 | sizeof(drvinfo->bus_info)); |
1129 | drvinfo->n_priv_flags = I40E_PRIV_FLAGS_STR_LEN; | ||
1130 | } | 1129 | } |
1131 | 1130 | ||
1132 | static void i40e_get_ringparam(struct net_device *netdev, | 1131 | static void i40e_get_ringparam(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c index 74262768b09b..2529bc625de4 100644 --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c | |||
@@ -842,10 +842,6 @@ static void igb_get_drvinfo(struct net_device *netdev, | |||
842 | sizeof(drvinfo->fw_version)); | 842 | sizeof(drvinfo->fw_version)); |
843 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 843 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
844 | sizeof(drvinfo->bus_info)); | 844 | sizeof(drvinfo->bus_info)); |
845 | drvinfo->n_stats = IGB_STATS_LEN; | ||
846 | drvinfo->testinfo_len = IGB_TEST_LEN; | ||
847 | drvinfo->regdump_len = igb_get_regs_len(netdev); | ||
848 | drvinfo->eedump_len = igb_get_eeprom_len(netdev); | ||
849 | } | 845 | } |
850 | 846 | ||
851 | static void igb_get_ringparam(struct net_device *netdev, | 847 | static void igb_get_ringparam(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c index c6996feb1cb4..b74ce53d7b52 100644 --- a/drivers/net/ethernet/intel/igbvf/ethtool.c +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c | |||
@@ -196,8 +196,6 @@ static void igbvf_get_drvinfo(struct net_device *netdev, | |||
196 | sizeof(drvinfo->version)); | 196 | sizeof(drvinfo->version)); |
197 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 197 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
198 | sizeof(drvinfo->bus_info)); | 198 | sizeof(drvinfo->bus_info)); |
199 | drvinfo->regdump_len = igbvf_get_regs_len(netdev); | ||
200 | drvinfo->eedump_len = igbvf_get_eeprom_len(netdev); | ||
201 | } | 199 | } |
202 | 200 | ||
203 | static void igbvf_get_ringparam(struct net_device *netdev, | 201 | static void igbvf_get_ringparam(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c b/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c index b311e9e710d2..d2b29b490ae0 100644 --- a/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c +++ b/drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c | |||
@@ -479,9 +479,6 @@ ixgb_get_drvinfo(struct net_device *netdev, | |||
479 | sizeof(drvinfo->version)); | 479 | sizeof(drvinfo->version)); |
480 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 480 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
481 | sizeof(drvinfo->bus_info)); | 481 | sizeof(drvinfo->bus_info)); |
482 | drvinfo->n_stats = IXGB_STATS_LEN; | ||
483 | drvinfo->regdump_len = ixgb_get_regs_len(netdev); | ||
484 | drvinfo->eedump_len = ixgb_get_eeprom_len(netdev); | ||
485 | } | 482 | } |
486 | 483 | ||
487 | static void | 484 | static void |
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c index 94c4912b2330..d681273bd39d 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | |||
@@ -943,9 +943,6 @@ static void ixgbe_get_drvinfo(struct net_device *netdev, | |||
943 | 943 | ||
944 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 944 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
945 | sizeof(drvinfo->bus_info)); | 945 | sizeof(drvinfo->bus_info)); |
946 | drvinfo->n_stats = IXGBE_STATS_LEN; | ||
947 | drvinfo->testinfo_len = IXGBE_TEST_LEN; | ||
948 | drvinfo->regdump_len = ixgbe_get_regs_len(netdev); | ||
949 | } | 946 | } |
950 | 947 | ||
951 | static void ixgbe_get_ringparam(struct net_device *netdev, | 948 | static void ixgbe_get_ringparam(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index c78ae1868097..603d29df5832 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c | |||
@@ -1586,7 +1586,6 @@ static void mv643xx_eth_get_drvinfo(struct net_device *dev, | |||
1586 | sizeof(drvinfo->version)); | 1586 | sizeof(drvinfo->version)); |
1587 | strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); | 1587 | strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); |
1588 | strlcpy(drvinfo->bus_info, "platform", sizeof(drvinfo->bus_info)); | 1588 | strlcpy(drvinfo->bus_info, "platform", sizeof(drvinfo->bus_info)); |
1589 | drvinfo->n_stats = ARRAY_SIZE(mv643xx_eth_stats); | ||
1590 | } | 1589 | } |
1591 | 1590 | ||
1592 | static int mv643xx_eth_nway_reset(struct net_device *dev) | 1591 | static int mv643xx_eth_nway_reset(struct net_device *dev) |
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c index f79d8124321e..ddb5541882f5 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | |||
@@ -95,9 +95,6 @@ mlx4_en_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo) | |||
95 | (u16) (mdev->dev->caps.fw_ver & 0xffff)); | 95 | (u16) (mdev->dev->caps.fw_ver & 0xffff)); |
96 | strlcpy(drvinfo->bus_info, pci_name(mdev->dev->persist->pdev), | 96 | strlcpy(drvinfo->bus_info, pci_name(mdev->dev->persist->pdev), |
97 | sizeof(drvinfo->bus_info)); | 97 | sizeof(drvinfo->bus_info)); |
98 | drvinfo->n_stats = 0; | ||
99 | drvinfo->regdump_len = 0; | ||
100 | drvinfo->eedump_len = 0; | ||
101 | } | 98 | } |
102 | 99 | ||
103 | static const char mlx4_en_priv_flags[][ETH_GSTRING_LEN] = { | 100 | static const char mlx4_en_priv_flags[][ETH_GSTRING_LEN] = { |
diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index 2d1b94274079..9ba975853ec6 100644 --- a/drivers/net/ethernet/neterion/s2io.c +++ b/drivers/net/ethernet/neterion/s2io.c | |||
@@ -5389,8 +5389,6 @@ static void s2io_ethtool_gdrvinfo(struct net_device *dev, | |||
5389 | strlcpy(info->driver, s2io_driver_name, sizeof(info->driver)); | 5389 | strlcpy(info->driver, s2io_driver_name, sizeof(info->driver)); |
5390 | strlcpy(info->version, s2io_driver_version, sizeof(info->version)); | 5390 | strlcpy(info->version, s2io_driver_version, sizeof(info->version)); |
5391 | strlcpy(info->bus_info, pci_name(sp->pdev), sizeof(info->bus_info)); | 5391 | strlcpy(info->bus_info, pci_name(sp->pdev), sizeof(info->bus_info)); |
5392 | info->regdump_len = XENA_REG_SPACE; | ||
5393 | info->eedump_len = XENA_EEPROM_SPACE; | ||
5394 | } | 5392 | } |
5395 | 5393 | ||
5396 | /** | 5394 | /** |
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c index be916eb2f2e7..9a2967016c18 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c | |||
@@ -105,10 +105,6 @@ static void vxge_ethtool_gdrvinfo(struct net_device *dev, | |||
105 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); | 105 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); |
106 | strlcpy(info->fw_version, vdev->fw_version, sizeof(info->fw_version)); | 106 | strlcpy(info->fw_version, vdev->fw_version, sizeof(info->fw_version)); |
107 | strlcpy(info->bus_info, pci_name(vdev->pdev), sizeof(info->bus_info)); | 107 | strlcpy(info->bus_info, pci_name(vdev->pdev), sizeof(info->bus_info)); |
108 | info->regdump_len = sizeof(struct vxge_hw_vpath_reg) | ||
109 | * vdev->no_of_vpath; | ||
110 | |||
111 | info->n_stats = STAT_LEN; | ||
112 | } | 108 | } |
113 | 109 | ||
114 | /** | 110 | /** |
diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c index 7bf9c028d8d7..c177c7cec13b 100644 --- a/drivers/net/ethernet/octeon/octeon_mgmt.c +++ b/drivers/net/ethernet/octeon/octeon_mgmt.c | |||
@@ -1344,10 +1344,6 @@ static void octeon_mgmt_get_drvinfo(struct net_device *netdev, | |||
1344 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); | 1344 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); |
1345 | strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); | 1345 | strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); |
1346 | strlcpy(info->bus_info, "N/A", sizeof(info->bus_info)); | 1346 | strlcpy(info->bus_info, "N/A", sizeof(info->bus_info)); |
1347 | info->n_stats = 0; | ||
1348 | info->testinfo_len = 0; | ||
1349 | info->regdump_len = 0; | ||
1350 | info->eedump_len = 0; | ||
1351 | } | 1347 | } |
1352 | 1348 | ||
1353 | static int octeon_mgmt_get_settings(struct net_device *netdev, | 1349 | static int octeon_mgmt_get_settings(struct net_device *netdev, |
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c index f6fcf7450352..b19be7c6c1f4 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | |||
@@ -164,7 +164,6 @@ static void pch_gbe_get_drvinfo(struct net_device *netdev, | |||
164 | strlcpy(drvinfo->version, pch_driver_version, sizeof(drvinfo->version)); | 164 | strlcpy(drvinfo->version, pch_driver_version, sizeof(drvinfo->version)); |
165 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 165 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
166 | sizeof(drvinfo->bus_info)); | 166 | sizeof(drvinfo->bus_info)); |
167 | drvinfo->regdump_len = pch_gbe_get_regs_len(netdev); | ||
168 | } | 167 | } |
169 | 168 | ||
170 | /** | 169 | /** |
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c index 87e073c6e291..f9034467736c 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c | |||
@@ -93,8 +93,6 @@ netxen_nic_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo) | |||
93 | 93 | ||
94 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 94 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
95 | sizeof(drvinfo->bus_info)); | 95 | sizeof(drvinfo->bus_info)); |
96 | drvinfo->regdump_len = NETXEN_NIC_REGS_LEN; | ||
97 | drvinfo->eedump_len = netxen_nic_get_eeprom_len(dev); | ||
98 | } | 96 | } |
99 | 97 | ||
100 | static int | 98 | static int |
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c index 4847713211ca..b09a6b80d107 100644 --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c | |||
@@ -1736,8 +1736,6 @@ static void ql_get_drvinfo(struct net_device *ndev, | |||
1736 | sizeof(drvinfo->version)); | 1736 | sizeof(drvinfo->version)); |
1737 | strlcpy(drvinfo->bus_info, pci_name(qdev->pdev), | 1737 | strlcpy(drvinfo->bus_info, pci_name(qdev->pdev), |
1738 | sizeof(drvinfo->bus_info)); | 1738 | sizeof(drvinfo->bus_info)); |
1739 | drvinfo->regdump_len = 0; | ||
1740 | drvinfo->eedump_len = 0; | ||
1741 | } | 1739 | } |
1742 | 1740 | ||
1743 | static u32 ql_get_msglevel(struct net_device *ndev) | 1741 | static u32 ql_get_msglevel(struct net_device *ndev) |
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c index c3c514e332b5..5dade1fd08b8 100644 --- a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c | |||
@@ -415,13 +415,6 @@ static void ql_get_drvinfo(struct net_device *ndev, | |||
415 | (qdev->fw_rev_id & 0x000000ff)); | 415 | (qdev->fw_rev_id & 0x000000ff)); |
416 | strlcpy(drvinfo->bus_info, pci_name(qdev->pdev), | 416 | strlcpy(drvinfo->bus_info, pci_name(qdev->pdev), |
417 | sizeof(drvinfo->bus_info)); | 417 | sizeof(drvinfo->bus_info)); |
418 | drvinfo->n_stats = 0; | ||
419 | drvinfo->testinfo_len = 0; | ||
420 | if (!test_bit(QL_FRC_COREDUMP, &qdev->flags)) | ||
421 | drvinfo->regdump_len = sizeof(struct ql_mpi_coredump); | ||
422 | else | ||
423 | drvinfo->regdump_len = sizeof(struct ql_reg_dump); | ||
424 | drvinfo->eedump_len = 0; | ||
425 | } | 418 | } |
426 | 419 | ||
427 | static void ql_get_wol(struct net_device *ndev, struct ethtool_wolinfo *wol) | 420 | static void ql_get_wol(struct net_device *ndev, struct ethtool_wolinfo *wol) |
diff --git a/drivers/net/ethernet/realtek/8139too.c b/drivers/net/ethernet/realtek/8139too.c index 78bb4ceb1cdd..ef668d300800 100644 --- a/drivers/net/ethernet/realtek/8139too.c +++ b/drivers/net/ethernet/realtek/8139too.c | |||
@@ -2388,7 +2388,6 @@ static void rtl8139_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo * | |||
2388 | strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); | 2388 | strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); |
2389 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); | 2389 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); |
2390 | strlcpy(info->bus_info, pci_name(tp->pci_dev), sizeof(info->bus_info)); | 2390 | strlcpy(info->bus_info, pci_name(tp->pci_dev), sizeof(info->bus_info)); |
2391 | info->regdump_len = tp->regs_len; | ||
2392 | } | 2391 | } |
2393 | 2392 | ||
2394 | static int rtl8139_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) | 2393 | static int rtl8139_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) |
diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index 6ce973187225..062bce9acde6 100644 --- a/drivers/net/ethernet/sun/cassini.c +++ b/drivers/net/ethernet/sun/cassini.c | |||
@@ -4529,9 +4529,6 @@ static void cas_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info | |||
4529 | strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver)); | 4529 | strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver)); |
4530 | strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version)); | 4530 | strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version)); |
4531 | strlcpy(info->bus_info, pci_name(cp->pdev), sizeof(info->bus_info)); | 4531 | strlcpy(info->bus_info, pci_name(cp->pdev), sizeof(info->bus_info)); |
4532 | info->regdump_len = cp->casreg_len < CAS_MAX_REGS ? | ||
4533 | cp->casreg_len : CAS_MAX_REGS; | ||
4534 | info->n_stats = CAS_NUM_STAT_KEYS; | ||
4535 | } | 4532 | } |
4536 | 4533 | ||
4537 | static int cas_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) | 4534 | static int cas_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) |
diff --git a/drivers/net/ethernet/tehuti/tehuti.c b/drivers/net/ethernet/tehuti/tehuti.c index a9cac8413e49..14c9d1baa85c 100644 --- a/drivers/net/ethernet/tehuti/tehuti.c +++ b/drivers/net/ethernet/tehuti/tehuti.c | |||
@@ -2182,11 +2182,6 @@ bdx_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) | |||
2182 | strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); | 2182 | strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); |
2183 | strlcpy(drvinfo->bus_info, pci_name(priv->pdev), | 2183 | strlcpy(drvinfo->bus_info, pci_name(priv->pdev), |
2184 | sizeof(drvinfo->bus_info)); | 2184 | sizeof(drvinfo->bus_info)); |
2185 | |||
2186 | drvinfo->n_stats = ((priv->stats_flag) ? ARRAY_SIZE(bdx_stat_names) : 0); | ||
2187 | drvinfo->testinfo_len = 0; | ||
2188 | drvinfo->regdump_len = 0; | ||
2189 | drvinfo->eedump_len = 0; | ||
2190 | } | 2185 | } |
2191 | 2186 | ||
2192 | /* | 2187 | /* |
diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c index cba3d9fcb465..77d26fe286c0 100644 --- a/drivers/net/ethernet/ti/cpmac.c +++ b/drivers/net/ethernet/ti/cpmac.c | |||
@@ -899,7 +899,6 @@ static void cpmac_get_drvinfo(struct net_device *dev, | |||
899 | strlcpy(info->driver, "cpmac", sizeof(info->driver)); | 899 | strlcpy(info->driver, "cpmac", sizeof(info->driver)); |
900 | strlcpy(info->version, CPMAC_VERSION, sizeof(info->version)); | 900 | strlcpy(info->version, CPMAC_VERSION, sizeof(info->version)); |
901 | snprintf(info->bus_info, sizeof(info->bus_info), "%s", "cpmac"); | 901 | snprintf(info->bus_info, sizeof(info->bus_info), "%s", "cpmac"); |
902 | info->regdump_len = 0; | ||
903 | } | 902 | } |
904 | 903 | ||
905 | static const struct ethtool_ops cpmac_ethtool_ops = { | 904 | static const struct ethtool_ops cpmac_ethtool_ops = { |
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 75584cc36339..3b75adfb3f37 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c | |||
@@ -1784,7 +1784,6 @@ static void cpsw_get_drvinfo(struct net_device *ndev, | |||
1784 | strlcpy(info->driver, "cpsw", sizeof(info->driver)); | 1784 | strlcpy(info->driver, "cpsw", sizeof(info->driver)); |
1785 | strlcpy(info->version, "1.0", sizeof(info->version)); | 1785 | strlcpy(info->version, "1.0", sizeof(info->version)); |
1786 | strlcpy(info->bus_info, priv->pdev->name, sizeof(info->bus_info)); | 1786 | strlcpy(info->bus_info, priv->pdev->name, sizeof(info->bus_info)); |
1787 | info->regdump_len = cpsw_get_regs_len(ndev); | ||
1788 | } | 1787 | } |
1789 | 1788 | ||
1790 | static u32 cpsw_get_msglevel(struct net_device *ndev) | 1789 | static u32 cpsw_get_msglevel(struct net_device *ndev) |
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c index 691ec936e88d..a274cd49afe9 100644 --- a/drivers/net/ethernet/ti/tlan.c +++ b/drivers/net/ethernet/ti/tlan.c | |||
@@ -791,7 +791,6 @@ static void tlan_get_drvinfo(struct net_device *dev, | |||
791 | sizeof(info->bus_info)); | 791 | sizeof(info->bus_info)); |
792 | else | 792 | else |
793 | strlcpy(info->bus_info, "EISA", sizeof(info->bus_info)); | 793 | strlcpy(info->bus_info, "EISA", sizeof(info->bus_info)); |
794 | info->eedump_len = TLAN_EEPROM_SIZE; | ||
795 | } | 794 | } |
796 | 795 | ||
797 | static int tlan_get_eeprom_len(struct net_device *dev) | 796 | static int tlan_get_eeprom_len(struct net_device *dev) |
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index d95f9aae95e7..4684644703cc 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c | |||
@@ -1135,7 +1135,6 @@ static void axienet_ethtools_get_drvinfo(struct net_device *ndev, | |||
1135 | { | 1135 | { |
1136 | strlcpy(ed->driver, DRIVER_NAME, sizeof(ed->driver)); | 1136 | strlcpy(ed->driver, DRIVER_NAME, sizeof(ed->driver)); |
1137 | strlcpy(ed->version, DRIVER_VERSION, sizeof(ed->version)); | 1137 | strlcpy(ed->version, DRIVER_VERSION, sizeof(ed->version)); |
1138 | ed->regdump_len = sizeof(u32) * AXIENET_REGS_N; | ||
1139 | } | 1138 | } |
1140 | 1139 | ||
1141 | /** | 1140 | /** |
diff --git a/drivers/net/fjes/fjes_ethtool.c b/drivers/net/fjes/fjes_ethtool.c index 0119dd199276..9c218e140c41 100644 --- a/drivers/net/fjes/fjes_ethtool.c +++ b/drivers/net/fjes/fjes_ethtool.c | |||
@@ -105,8 +105,6 @@ static void fjes_get_drvinfo(struct net_device *netdev, | |||
105 | strlcpy(drvinfo->fw_version, "none", sizeof(drvinfo->fw_version)); | 105 | strlcpy(drvinfo->fw_version, "none", sizeof(drvinfo->fw_version)); |
106 | snprintf(drvinfo->bus_info, sizeof(drvinfo->bus_info), | 106 | snprintf(drvinfo->bus_info, sizeof(drvinfo->bus_info), |
107 | "platform:%s", plat_dev->name); | 107 | "platform:%s", plat_dev->name); |
108 | drvinfo->regdump_len = 0; | ||
109 | drvinfo->eedump_len = 0; | ||
110 | } | 108 | } |
111 | 109 | ||
112 | static int fjes_get_settings(struct net_device *netdev, | 110 | static int fjes_get_settings(struct net_device *netdev, |
diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index a186b0a12d50..bd9acff1eb7b 100644 --- a/drivers/net/usb/asix_common.c +++ b/drivers/net/usb/asix_common.c | |||
@@ -588,7 +588,6 @@ void asix_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *info) | |||
588 | usbnet_get_drvinfo(net, info); | 588 | usbnet_get_drvinfo(net, info); |
589 | strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver)); | 589 | strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver)); |
590 | strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); | 590 | strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); |
591 | info->eedump_len = AX_EEPROM_LEN; | ||
592 | } | 591 | } |
593 | 592 | ||
594 | int asix_set_mac_address(struct net_device *net, void *p) | 593 | int asix_set_mac_address(struct net_device *net, void *p) |
diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c index 6e9c344c7a20..0b4bdd39106b 100644 --- a/drivers/net/usb/dm9601.c +++ b/drivers/net/usb/dm9601.c | |||
@@ -258,7 +258,6 @@ static void dm9601_get_drvinfo(struct net_device *net, | |||
258 | { | 258 | { |
259 | /* Inherit standard device info */ | 259 | /* Inherit standard device info */ |
260 | usbnet_get_drvinfo(net, info); | 260 | usbnet_get_drvinfo(net, info); |
261 | info->eedump_len = DM_EEPROM_LEN; | ||
262 | } | 261 | } |
263 | 262 | ||
264 | static u32 dm9601_get_link(struct net_device *net) | 263 | static u32 dm9601_get_link(struct net_device *net) |
diff --git a/drivers/net/usb/mcs7830.c b/drivers/net/usb/mcs7830.c index 82d844a8ebd0..4f345bd4e6e2 100644 --- a/drivers/net/usb/mcs7830.c +++ b/drivers/net/usb/mcs7830.c | |||
@@ -445,7 +445,6 @@ static int mcs7830_get_regs_len(struct net_device *net) | |||
445 | static void mcs7830_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *drvinfo) | 445 | static void mcs7830_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *drvinfo) |
446 | { | 446 | { |
447 | usbnet_get_drvinfo(net, drvinfo); | 447 | usbnet_get_drvinfo(net, drvinfo); |
448 | drvinfo->regdump_len = mcs7830_get_regs_len(net); | ||
449 | } | 448 | } |
450 | 449 | ||
451 | static void mcs7830_get_regs(struct net_device *net, struct ethtool_regs *regs, void *data) | 450 | static void mcs7830_get_regs(struct net_device *net, struct ethtool_regs *regs, void *data) |
diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c index 953de13267df..a50df0d8fb9a 100644 --- a/drivers/net/usb/sr9800.c +++ b/drivers/net/usb/sr9800.c | |||
@@ -470,14 +470,10 @@ static int sr_get_eeprom(struct net_device *net, | |||
470 | static void sr_get_drvinfo(struct net_device *net, | 470 | static void sr_get_drvinfo(struct net_device *net, |
471 | struct ethtool_drvinfo *info) | 471 | struct ethtool_drvinfo *info) |
472 | { | 472 | { |
473 | struct usbnet *dev = netdev_priv(net); | ||
474 | struct sr_data *data = (struct sr_data *)&dev->data; | ||
475 | |||
476 | /* Inherit standard device info */ | 473 | /* Inherit standard device info */ |
477 | usbnet_get_drvinfo(net, info); | 474 | usbnet_get_drvinfo(net, info); |
478 | strncpy(info->driver, DRIVER_NAME, sizeof(info->driver)); | 475 | strncpy(info->driver, DRIVER_NAME, sizeof(info->driver)); |
479 | strncpy(info->version, DRIVER_VERSION, sizeof(info->version)); | 476 | strncpy(info->version, DRIVER_VERSION, sizeof(info->version)); |
480 | info->eedump_len = data->eeprom_len; | ||
481 | } | 477 | } |
482 | 478 | ||
483 | static u32 sr_get_link(struct net_device *net) | 479 | static u32 sr_get_link(struct net_device *net) |
diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c index a681569ae0b5..9ba11d737753 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethtool.c +++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c | |||
@@ -214,10 +214,6 @@ vmxnet3_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) | |||
214 | 214 | ||
215 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), | 215 | strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), |
216 | sizeof(drvinfo->bus_info)); | 216 | sizeof(drvinfo->bus_info)); |
217 | drvinfo->n_stats = vmxnet3_get_sset_count(netdev, ETH_SS_STATS); | ||
218 | drvinfo->testinfo_len = 0; | ||
219 | drvinfo->eedump_len = 0; | ||
220 | drvinfo->regdump_len = vmxnet3_get_regs_len(netdev); | ||
221 | } | 217 | } |
222 | 218 | ||
223 | 219 | ||
diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c index 39f3e6f5cbcd..ed0adaf1eec4 100644 --- a/drivers/net/wireless/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/ipw2x00/ipw2200.c | |||
@@ -10470,7 +10470,6 @@ static void ipw_ethtool_get_drvinfo(struct net_device *dev, | |||
10470 | vers, date); | 10470 | vers, date); |
10471 | strlcpy(info->bus_info, pci_name(p->pci_dev), | 10471 | strlcpy(info->bus_info, pci_name(p->pci_dev), |
10472 | sizeof(info->bus_info)); | 10472 | sizeof(info->bus_info)); |
10473 | info->eedump_len = IPW_EEPROM_IMAGE_SIZE; | ||
10474 | } | 10473 | } |
10475 | 10474 | ||
10476 | static u32 ipw_ethtool_get_link(struct net_device *dev) | 10475 | static u32 ipw_ethtool_get_link(struct net_device *dev) |