diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-12-11 05:34:38 -0500 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2013-12-17 20:24:39 -0500 |
commit | 4efafebe709b8daa90b2f34a6e242eec7df98f25 (patch) | |
tree | d887c5e4d4693527c88eb9d6fee89c5091094ac0 /drivers/gpu/drm/drm_pci.c | |
parent | d6e4b28b60c5dae660aebe5cd731b21d02ca285e (diff) |
drm: kill the ->agp_destroy callback
Call drm_pci_agp_destroy directly, there's no point in the
indirection. Long term we want to shuffle this into each driver's
unload logic, but that needs cleared-up drm lifetime rules first.
v2: Add a dummy function for !CONFIG_PCI, spotted my David Herrmann.
v3: Fixup for the coding style police.
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Cc: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/drm_pci.c')
-rw-r--r-- | drivers/gpu/drm/drm_pci.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c index f710e3d9d847..6dfae6b3c0bc 100644 --- a/drivers/gpu/drm/drm_pci.c +++ b/drivers/gpu/drm/drm_pci.c | |||
@@ -276,7 +276,7 @@ static void drm_pci_agp_init(struct drm_device *dev) | |||
276 | } | 276 | } |
277 | } | 277 | } |
278 | 278 | ||
279 | static void drm_pci_agp_destroy(struct drm_device *dev) | 279 | void drm_pci_agp_destroy(struct drm_device *dev) |
280 | { | 280 | { |
281 | if (dev->agp) { | 281 | if (dev->agp) { |
282 | arch_phys_wc_del(dev->agp->agp_mtrr); | 282 | arch_phys_wc_del(dev->agp->agp_mtrr); |
@@ -293,7 +293,6 @@ static struct drm_bus drm_pci_bus = { | |||
293 | .set_busid = drm_pci_set_busid, | 293 | .set_busid = drm_pci_set_busid, |
294 | .set_unique = drm_pci_set_unique, | 294 | .set_unique = drm_pci_set_unique, |
295 | .irq_by_busid = drm_pci_irq_by_busid, | 295 | .irq_by_busid = drm_pci_irq_by_busid, |
296 | .agp_destroy = drm_pci_agp_destroy, | ||
297 | }; | 296 | }; |
298 | 297 | ||
299 | /** | 298 | /** |
@@ -457,6 +456,7 @@ int drm_pci_init(struct drm_driver *driver, struct pci_driver *pdriver) | |||
457 | return -1; | 456 | return -1; |
458 | } | 457 | } |
459 | 458 | ||
459 | void drm_pci_agp_destroy(struct drm_device *dev) {} | ||
460 | #endif | 460 | #endif |
461 | 461 | ||
462 | EXPORT_SYMBOL(drm_pci_init); | 462 | EXPORT_SYMBOL(drm_pci_init); |