diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-12-11 05:34:37 -0500 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2013-12-17 20:23:46 -0500 |
commit | d6e4b28b60c5dae660aebe5cd731b21d02ca285e (patch) | |
tree | 8dbd4ad61de18f5d2f0354d9b82f1c9c3dc713e0 /drivers/gpu/drm/drm_pci.c | |
parent | 2c695fa0444273c7139a3ca4c324c95498a0bfed (diff) |
drm: inline drm_agp_destroy
Wrapping a kfree is pointless.
v2: Add a comment to the kerneldoc for drm_agp_init to explain where
the kfree happens as requested by David. Note that for modeset drivers
agp cleanup is fairly complicated anyway: The drm_agp_clear is a noop
and drivers must call drm_agp_release on their own. Which they all
seem to do properly.
Cc: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/drm_pci.c')
-rw-r--r-- | drivers/gpu/drm/drm_pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c index 2211c4d70c2d..f710e3d9d847 100644 --- a/drivers/gpu/drm/drm_pci.c +++ b/drivers/gpu/drm/drm_pci.c | |||
@@ -281,7 +281,7 @@ static void drm_pci_agp_destroy(struct drm_device *dev) | |||
281 | if (dev->agp) { | 281 | if (dev->agp) { |
282 | arch_phys_wc_del(dev->agp->agp_mtrr); | 282 | arch_phys_wc_del(dev->agp->agp_mtrr); |
283 | drm_agp_clear(dev); | 283 | drm_agp_clear(dev); |
284 | drm_agp_destroy(dev->agp); | 284 | kfree(dev->agp); |
285 | dev->agp = NULL; | 285 | dev->agp = NULL; |
286 | } | 286 | } |
287 | } | 287 | } |