aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd/amdgpu/vi.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-11-17 17:34:42 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2017-11-17 17:34:42 -0500
commitf6705bf959efac87bca76d40050d342f1d212587 (patch)
treee199b124c6067a92be7f4727538ffc721670fc28 /drivers/gpu/drm/amd/amdgpu/vi.c
parentbec04432cb9036dedf89140c102b5ac03e4b3626 (diff)
parent49e37ba07a3ae697086c0a1a32c113a1f177d138 (diff)
Merge tag 'drm-for-v4.15-amd-dc' of git://people.freedesktop.org/~airlied/linux
Pull amdgpu DC display code for Vega from Dave Airlie: "This is the pull request for the AMD DC (display code) layer which is a requirement to program the display engines on the new Vega and Raven based GPUs. It also contains support for all amdgpu supported GPUs (CIK, VI, Polaris), which has to be enabled. It is also a kms atomic modesetting compatible driver (unlike the current in-tree display code). I've kept it separate from drm-next because it may have some things that cause you to reject it. Background story: AMD have an internal team creating a shared OS codebase for display at hw bring up time using information from their hardware teams. This process doesn't lead to the most Linux friendly/looking code but we have worked together on cleaning a lot of it up and dealing with sparse/smatch/checkpatch, and having their team internally adhere to Linux coding standards. This tree is a complete history rebased since they started opening it, we decided not to squash it down as the history may have some value. Some of the commits therefore might not reach kernel standards, and we are steadily training people in AMD to better write commit msgs. There is a major bunch of generated bandwidth calculation and verification code that comes from their hardware team. On Vega and before this is float calculations, on Raven (DCN10) this is double based. They do the required things to do FP in the kernel, and I could understand this might raise some issues. Rewriting the bandwidth would be a major undertaken in reverification, it's non-trivial to work out if a display can handle the complete set of mode information thrown at it. Future story: There is a TODO list with this, and it address most of the remaining things that would be nice to refine/remove. The DCN10 code is still under development internally and they push out a lot of patches quite regularly and are supporting this code base with their display team. I think we've reached the point where keeping it out of tree is going to motivate distributions to start carrying the code, so I'd prefer we get it in tree. I think this code is slightly better than STAGING quality but not massively so, I'd really like to see that float/double magic gone and fixed point used, but AMD don't seem to think the accuracy and revalidation of the code is worth the effort" * tag 'drm-for-v4.15-amd-dc' of git://people.freedesktop.org/~airlied/linux: (1110 commits) drm/amd/display: fix MST link training fail division by 0 drm/amd/display: Fix formatting for null pointer dereference fix drm/amd/display: Remove dangling planes on dc commit state drm/amd/display: add flip_immediate to commit update for stream drm/amd/display: Miss register MST encoder cbs drm/amd/display: Fix warnings on S3 resume drm/amd/display: use num_timing_generator instead of pipe_count drm/amd/display: use configurable FBC option in dm drm/amd/display: fix AZ clock not enabled before program AZ endpoint amdgpu/dm: Don't use DRM_ERROR in amdgpu_dm_atomic_check amd/display: Fix potential null dereference in dce_calcs.c amdgpu/dm: Remove unused forward declaration drm/amdgpu: Remove unused dc_stream from amdgpu_crtc amdgpu/dc: Fix double unlock in amdgpu_dm_commit_planes amdgpu/dc: Fix missing null checks in amdgpu_dm.c amdgpu/dc: Fix potential null dereferences in amdgpu_dm.c amdgpu/dc: fix more indentation warnings amdgpu/dc: handle allocation failures in dc_commit_planes_to_stream. amdgpu/dc: fix indentation warning from smatch. amdgpu/dc: fix non-ansi function decls. ...
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/vi.c')
-rw-r--r--drivers/gpu/drm/amd/amdgpu/vi.c21
1 files changed, 21 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index f3cfef48aa99..3a4c2fa7e36d 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -77,6 +77,7 @@
77#endif 77#endif
78#include "dce_virtual.h" 78#include "dce_virtual.h"
79#include "mxgpu_vi.h" 79#include "mxgpu_vi.h"
80#include "amdgpu_dm.h"
80 81
81/* 82/*
82 * Indirect registers accessor 83 * Indirect registers accessor
@@ -1502,6 +1503,10 @@ int vi_set_ip_blocks(struct amdgpu_device *adev)
1502 amdgpu_ip_block_add(adev, &amdgpu_pp_ip_block); 1503 amdgpu_ip_block_add(adev, &amdgpu_pp_ip_block);
1503 if (adev->enable_virtual_display || amdgpu_sriov_vf(adev)) 1504 if (adev->enable_virtual_display || amdgpu_sriov_vf(adev))
1504 amdgpu_ip_block_add(adev, &dce_virtual_ip_block); 1505 amdgpu_ip_block_add(adev, &dce_virtual_ip_block);
1506#if defined(CONFIG_DRM_AMD_DC)
1507 else if (amdgpu_device_has_dc_support(adev))
1508 amdgpu_ip_block_add(adev, &dm_ip_block);
1509#endif
1505 else 1510 else
1506 amdgpu_ip_block_add(adev, &dce_v10_1_ip_block); 1511 amdgpu_ip_block_add(adev, &dce_v10_1_ip_block);
1507 amdgpu_ip_block_add(adev, &gfx_v8_0_ip_block); 1512 amdgpu_ip_block_add(adev, &gfx_v8_0_ip_block);
@@ -1518,6 +1523,10 @@ int vi_set_ip_blocks(struct amdgpu_device *adev)
1518 amdgpu_ip_block_add(adev, &amdgpu_pp_ip_block); 1523 amdgpu_ip_block_add(adev, &amdgpu_pp_ip_block);
1519 if (adev->enable_virtual_display || amdgpu_sriov_vf(adev)) 1524 if (adev->enable_virtual_display || amdgpu_sriov_vf(adev))
1520 amdgpu_ip_block_add(adev, &dce_virtual_ip_block); 1525 amdgpu_ip_block_add(adev, &dce_virtual_ip_block);
1526#if defined(CONFIG_DRM_AMD_DC)
1527 else if (amdgpu_device_has_dc_support(adev))
1528 amdgpu_ip_block_add(adev, &dm_ip_block);
1529#endif
1521 else 1530 else
1522 amdgpu_ip_block_add(adev, &dce_v10_0_ip_block); 1531 amdgpu_ip_block_add(adev, &dce_v10_0_ip_block);
1523 amdgpu_ip_block_add(adev, &gfx_v8_0_ip_block); 1532 amdgpu_ip_block_add(adev, &gfx_v8_0_ip_block);
@@ -1536,6 +1545,10 @@ int vi_set_ip_blocks(struct amdgpu_device *adev)
1536 amdgpu_ip_block_add(adev, &amdgpu_pp_ip_block); 1545 amdgpu_ip_block_add(adev, &amdgpu_pp_ip_block);
1537 if (adev->enable_virtual_display) 1546 if (adev->enable_virtual_display)
1538 amdgpu_ip_block_add(adev, &dce_virtual_ip_block); 1547 amdgpu_ip_block_add(adev, &dce_virtual_ip_block);
1548#if defined(CONFIG_DRM_AMD_DC)
1549 else if (amdgpu_device_has_dc_support(adev))
1550 amdgpu_ip_block_add(adev, &dm_ip_block);
1551#endif
1539 else 1552 else
1540 amdgpu_ip_block_add(adev, &dce_v11_2_ip_block); 1553 amdgpu_ip_block_add(adev, &dce_v11_2_ip_block);
1541 amdgpu_ip_block_add(adev, &gfx_v8_0_ip_block); 1554 amdgpu_ip_block_add(adev, &gfx_v8_0_ip_block);
@@ -1550,6 +1563,10 @@ int vi_set_ip_blocks(struct amdgpu_device *adev)
1550 amdgpu_ip_block_add(adev, &amdgpu_pp_ip_block); 1563 amdgpu_ip_block_add(adev, &amdgpu_pp_ip_block);
1551 if (adev->enable_virtual_display) 1564 if (adev->enable_virtual_display)
1552 amdgpu_ip_block_add(adev, &dce_virtual_ip_block); 1565 amdgpu_ip_block_add(adev, &dce_virtual_ip_block);
1566#if defined(CONFIG_DRM_AMD_DC)
1567 else if (amdgpu_device_has_dc_support(adev))
1568 amdgpu_ip_block_add(adev, &dm_ip_block);
1569#endif
1553 else 1570 else
1554 amdgpu_ip_block_add(adev, &dce_v11_0_ip_block); 1571 amdgpu_ip_block_add(adev, &dce_v11_0_ip_block);
1555 amdgpu_ip_block_add(adev, &gfx_v8_0_ip_block); 1572 amdgpu_ip_block_add(adev, &gfx_v8_0_ip_block);
@@ -1567,6 +1584,10 @@ int vi_set_ip_blocks(struct amdgpu_device *adev)
1567 amdgpu_ip_block_add(adev, &amdgpu_pp_ip_block); 1584 amdgpu_ip_block_add(adev, &amdgpu_pp_ip_block);
1568 if (adev->enable_virtual_display) 1585 if (adev->enable_virtual_display)
1569 amdgpu_ip_block_add(adev, &dce_virtual_ip_block); 1586 amdgpu_ip_block_add(adev, &dce_virtual_ip_block);
1587#if defined(CONFIG_DRM_AMD_DC)
1588 else if (amdgpu_device_has_dc_support(adev))
1589 amdgpu_ip_block_add(adev, &dm_ip_block);
1590#endif
1570 else 1591 else
1571 amdgpu_ip_block_add(adev, &dce_v11_0_ip_block); 1592 amdgpu_ip_block_add(adev, &dce_v11_0_ip_block);
1572 amdgpu_ip_block_add(adev, &gfx_v8_1_ip_block); 1593 amdgpu_ip_block_add(adev, &gfx_v8_1_ip_block);