drm/amdgpu/gfx: fix MEC interrupt enablement for pipes != 0

The interrupt registers are not indexed.

Fixes: 763a47b8e (drm/amdgpu: teach amdgpu how to enable interrupts for any pipe v3)
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

1 files changed, 41 insertions, 16 deletions

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 6e541af0e899..1a75ab1d1823 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -6610,26 +6610,51 @@ static void gfx_v8_0_set_compute_eop_interrupt_state(struct amdgpu_device *adev,
                                                      int me, int pipe,
                                                      enum amdgpu_interrupt_state state)
 {
-        /* Me 0 is reserved for graphics */
-        if (me < 1 || me > adev->gfx.mec.num_mec) {
-                DRM_ERROR("Ignoring request to enable interrupts for invalid me:%d\n", me);
-                return;
-        }
+        u32 mec_int_cntl, mec_int_cntl_reg;
 
-        if (pipe >= adev->gfx.mec.num_pipe_per_mec) {
-                DRM_ERROR("Ignoring request to enable interrupts for invalid "
-                                "me:%d pipe:%d\n", pipe, me);
+        /*
+         * amdgpu controls only the first MEC. That's why this function only
+         * handles the setting of interrupts for this specific MEC. All other
+         * pipes' interrupts are set by amdkfd.
+         */
+
+        if (me == 1) {
+                switch (pipe) {
+                case 0:
+                        mec_int_cntl_reg = mmCP_ME1_PIPE0_INT_CNTL;
+                        break;
+                case 1:
+                        mec_int_cntl_reg = mmCP_ME1_PIPE1_INT_CNTL;
+                        break;
+                case 2:
+                        mec_int_cntl_reg = mmCP_ME1_PIPE2_INT_CNTL;
+                        break;
+                case 3:
+                        mec_int_cntl_reg = mmCP_ME1_PIPE3_INT_CNTL;
+                        break;
+                default:
+                        DRM_DEBUG("invalid pipe %d\n", pipe);
+                        return;
+                }
+        } else {
+                DRM_DEBUG("invalid me %d\n", me);
                 return;
         }
 
-        mutex_lock(&adev->srbm_mutex);
-        vi_srbm_select(adev, me, pipe, 0, 0);
-
-        WREG32_FIELD(CPC_INT_CNTL, TIME_STAMP_INT_ENABLE,
-                        state == AMDGPU_IRQ_STATE_DISABLE ? 0 : 1);
-
-        vi_srbm_select(adev, 0, 0, 0, 0);
-        mutex_unlock(&adev->srbm_mutex);
+        switch (state) {
+        case AMDGPU_IRQ_STATE_DISABLE:
+                mec_int_cntl = RREG32(mec_int_cntl_reg);
+                mec_int_cntl &= ~CP_INT_CNTL_RING0__TIME_STAMP_INT_ENABLE_MASK;
+                WREG32(mec_int_cntl_reg, mec_int_cntl);
+                break;
+        case AMDGPU_IRQ_STATE_ENABLE:
+                mec_int_cntl = RREG32(mec_int_cntl_reg);
+                mec_int_cntl |= CP_INT_CNTL_RING0__TIME_STAMP_INT_ENABLE_MASK;
+                WREG32(mec_int_cntl_reg, mec_int_cntl);
+                break;
+        default:
+                break;
+        }
 }
 
 static int gfx_v8_0_set_priv_reg_fault_state(struct amdgpu_device *adev,