diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-01-25 16:16:52 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-02-08 03:55:51 -0500 |
commit | e37fb79db7b989d08f52ab2b25daa9e3aaa3830f (patch) | |
tree | 05b38e39e7c245672a918402a0b10e371e538b5e | |
parent | 0a346629f5304a8390004a91e8d4f1206b87792b (diff) |
drm/shmob: Nuke preclose hook
Again since the drm core takes care of event unlinking/disarming this
is now just needless code.
v2: Fixup misplaced hunk.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com> (v1)
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1453756616-28942-11-git-send-email-daniel.vetter@ffwll.ch
-rw-r--r-- | drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 20 | ||||
-rw-r--r-- | drivers/gpu/drm/shmobile/shmob_drm_crtc.h | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/shmobile/shmob_drm_drv.c | 8 |
3 files changed, 0 insertions, 30 deletions
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c index db0763794edc..27342fd76e90 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c | |||
@@ -438,26 +438,6 @@ static const struct drm_crtc_helper_funcs crtc_helper_funcs = { | |||
438 | .mode_set_base = shmob_drm_crtc_mode_set_base, | 438 | .mode_set_base = shmob_drm_crtc_mode_set_base, |
439 | }; | 439 | }; |
440 | 440 | ||
441 | void shmob_drm_crtc_cancel_page_flip(struct shmob_drm_crtc *scrtc, | ||
442 | struct drm_file *file) | ||
443 | { | ||
444 | struct drm_pending_vblank_event *event; | ||
445 | struct drm_device *dev = scrtc->crtc.dev; | ||
446 | unsigned long flags; | ||
447 | |||
448 | /* Destroy the pending vertical blanking event associated with the | ||
449 | * pending page flip, if any, and disable vertical blanking interrupts. | ||
450 | */ | ||
451 | spin_lock_irqsave(&dev->event_lock, flags); | ||
452 | event = scrtc->event; | ||
453 | if (event && event->base.file_priv == file) { | ||
454 | scrtc->event = NULL; | ||
455 | event->base.destroy(&event->base); | ||
456 | drm_vblank_put(dev, 0); | ||
457 | } | ||
458 | spin_unlock_irqrestore(&dev->event_lock, flags); | ||
459 | } | ||
460 | |||
461 | void shmob_drm_crtc_finish_page_flip(struct shmob_drm_crtc *scrtc) | 441 | void shmob_drm_crtc_finish_page_flip(struct shmob_drm_crtc *scrtc) |
462 | { | 442 | { |
463 | struct drm_pending_vblank_event *event; | 443 | struct drm_pending_vblank_event *event; |
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.h b/drivers/gpu/drm/shmobile/shmob_drm_crtc.h index eddad6dcc88a..38ed4ff8aaf2 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.h +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.h | |||
@@ -47,8 +47,6 @@ struct shmob_drm_connector { | |||
47 | 47 | ||
48 | int shmob_drm_crtc_create(struct shmob_drm_device *sdev); | 48 | int shmob_drm_crtc_create(struct shmob_drm_device *sdev); |
49 | void shmob_drm_crtc_enable_vblank(struct shmob_drm_device *sdev, bool enable); | 49 | void shmob_drm_crtc_enable_vblank(struct shmob_drm_device *sdev, bool enable); |
50 | void shmob_drm_crtc_cancel_page_flip(struct shmob_drm_crtc *scrtc, | ||
51 | struct drm_file *file); | ||
52 | void shmob_drm_crtc_finish_page_flip(struct shmob_drm_crtc *scrtc); | 50 | void shmob_drm_crtc_finish_page_flip(struct shmob_drm_crtc *scrtc); |
53 | void shmob_drm_crtc_suspend(struct shmob_drm_crtc *scrtc); | 51 | void shmob_drm_crtc_suspend(struct shmob_drm_crtc *scrtc); |
54 | void shmob_drm_crtc_resume(struct shmob_drm_crtc *scrtc); | 52 | void shmob_drm_crtc_resume(struct shmob_drm_crtc *scrtc); |
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index 04e66e3751b4..7700ff172079 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c | |||
@@ -200,13 +200,6 @@ done: | |||
200 | return ret; | 200 | return ret; |
201 | } | 201 | } |
202 | 202 | ||
203 | static void shmob_drm_preclose(struct drm_device *dev, struct drm_file *file) | ||
204 | { | ||
205 | struct shmob_drm_device *sdev = dev->dev_private; | ||
206 | |||
207 | shmob_drm_crtc_cancel_page_flip(&sdev->crtc, file); | ||
208 | } | ||
209 | |||
210 | static irqreturn_t shmob_drm_irq(int irq, void *arg) | 203 | static irqreturn_t shmob_drm_irq(int irq, void *arg) |
211 | { | 204 | { |
212 | struct drm_device *dev = arg; | 205 | struct drm_device *dev = arg; |
@@ -266,7 +259,6 @@ static struct drm_driver shmob_drm_driver = { | |||
266 | | DRIVER_PRIME, | 259 | | DRIVER_PRIME, |
267 | .load = shmob_drm_load, | 260 | .load = shmob_drm_load, |
268 | .unload = shmob_drm_unload, | 261 | .unload = shmob_drm_unload, |
269 | .preclose = shmob_drm_preclose, | ||
270 | .set_busid = drm_platform_set_busid, | 262 | .set_busid = drm_platform_set_busid, |
271 | .irq_handler = shmob_drm_irq, | 263 | .irq_handler = shmob_drm_irq, |
272 | .get_vblank_counter = drm_vblank_no_hw_counter, | 264 | .get_vblank_counter = drm_vblank_no_hw_counter, |