diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-01-25 16:16:51 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-02-08 03:55:51 -0500 |
commit | 0a346629f5304a8390004a91e8d4f1206b87792b (patch) | |
tree | 83a64cfc8b2c91b5a49efb0fbd313bb1df32bc45 | |
parent | 8c04fdeef343a18617968b672f212d1634add14d (diff) |
drm/rcar: Nuke preclose hook
Again since the drm core takes care of event unlinking/disarming this
is now just needless code.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1453756616-28942-10-git-send-email-daniel.vetter@ffwll.ch
-rw-r--r-- | drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 20 | ||||
-rw-r--r-- | drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/rcar-du/rcar_du_drv.c | 10 |
3 files changed, 0 insertions, 32 deletions
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 88a4b706be16..4ec80ae1fa99 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c | |||
@@ -282,26 +282,6 @@ static void rcar_du_crtc_update_planes(struct rcar_du_crtc *rcrtc) | |||
282 | * Page Flip | 282 | * Page Flip |
283 | */ | 283 | */ |
284 | 284 | ||
285 | void rcar_du_crtc_cancel_page_flip(struct rcar_du_crtc *rcrtc, | ||
286 | struct drm_file *file) | ||
287 | { | ||
288 | struct drm_pending_vblank_event *event; | ||
289 | struct drm_device *dev = rcrtc->crtc.dev; | ||
290 | unsigned long flags; | ||
291 | |||
292 | /* Destroy the pending vertical blanking event associated with the | ||
293 | * pending page flip, if any, and disable vertical blanking interrupts. | ||
294 | */ | ||
295 | spin_lock_irqsave(&dev->event_lock, flags); | ||
296 | event = rcrtc->event; | ||
297 | if (event && event->base.file_priv == file) { | ||
298 | rcrtc->event = NULL; | ||
299 | event->base.destroy(&event->base); | ||
300 | drm_crtc_vblank_put(&rcrtc->crtc); | ||
301 | } | ||
302 | spin_unlock_irqrestore(&dev->event_lock, flags); | ||
303 | } | ||
304 | |||
305 | static void rcar_du_crtc_finish_page_flip(struct rcar_du_crtc *rcrtc) | 285 | static void rcar_du_crtc_finish_page_flip(struct rcar_du_crtc *rcrtc) |
306 | { | 286 | { |
307 | struct drm_pending_vblank_event *event; | 287 | struct drm_pending_vblank_event *event; |
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h index 4b95d9d08c49..2bbe3f5aab65 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h | |||
@@ -67,8 +67,6 @@ enum rcar_du_output { | |||
67 | 67 | ||
68 | int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int index); | 68 | int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int index); |
69 | void rcar_du_crtc_enable_vblank(struct rcar_du_crtc *rcrtc, bool enable); | 69 | void rcar_du_crtc_enable_vblank(struct rcar_du_crtc *rcrtc, bool enable); |
70 | void rcar_du_crtc_cancel_page_flip(struct rcar_du_crtc *rcrtc, | ||
71 | struct drm_file *file); | ||
72 | void rcar_du_crtc_suspend(struct rcar_du_crtc *rcrtc); | 70 | void rcar_du_crtc_suspend(struct rcar_du_crtc *rcrtc); |
73 | void rcar_du_crtc_resume(struct rcar_du_crtc *rcrtc); | 71 | void rcar_du_crtc_resume(struct rcar_du_crtc *rcrtc); |
74 | 72 | ||
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 40422f6b645e..0bb2b31555bf 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c | |||
@@ -220,15 +220,6 @@ done: | |||
220 | return ret; | 220 | return ret; |
221 | } | 221 | } |
222 | 222 | ||
223 | static void rcar_du_preclose(struct drm_device *dev, struct drm_file *file) | ||
224 | { | ||
225 | struct rcar_du_device *rcdu = dev->dev_private; | ||
226 | unsigned int i; | ||
227 | |||
228 | for (i = 0; i < rcdu->num_crtcs; ++i) | ||
229 | rcar_du_crtc_cancel_page_flip(&rcdu->crtcs[i], file); | ||
230 | } | ||
231 | |||
232 | static void rcar_du_lastclose(struct drm_device *dev) | 223 | static void rcar_du_lastclose(struct drm_device *dev) |
233 | { | 224 | { |
234 | struct rcar_du_device *rcdu = dev->dev_private; | 225 | struct rcar_du_device *rcdu = dev->dev_private; |
@@ -271,7 +262,6 @@ static struct drm_driver rcar_du_driver = { | |||
271 | | DRIVER_ATOMIC, | 262 | | DRIVER_ATOMIC, |
272 | .load = rcar_du_load, | 263 | .load = rcar_du_load, |
273 | .unload = rcar_du_unload, | 264 | .unload = rcar_du_unload, |
274 | .preclose = rcar_du_preclose, | ||
275 | .lastclose = rcar_du_lastclose, | 265 | .lastclose = rcar_du_lastclose, |
276 | .set_busid = drm_platform_set_busid, | 266 | .set_busid = drm_platform_set_busid, |
277 | .get_vblank_counter = drm_vblank_no_hw_counter, | 267 | .get_vblank_counter = drm_vblank_no_hw_counter, |