diff options
author | Jiri Pirko <jiri@mellanox.com> | 2015-10-14 13:40:54 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-10-15 09:09:51 -0400 |
commit | d33eeb645d59ffd14bbc6db977c3783af42dd700 (patch) | |
tree | ca69c2202148eeb5b4a5f48603b285c765342808 | |
parent | 56607386e80cc7ce923592e115a3492485b47c72 (diff) |
rocker: remove nowait from switchdev callbacks.
No need to avoid sleeping in switchdev callbacks now, as the switchdev
core allows it.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/rocker/rocker.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c index 2cd7435b2316..32a80d2df7ff 100644 --- a/drivers/net/ethernet/rocker/rocker.c +++ b/drivers/net/ethernet/rocker/rocker.c | |||
@@ -3672,7 +3672,7 @@ static int rocker_port_fdb_flush(struct rocker_port *rocker_port, | |||
3672 | rocker_port->stp_state == BR_STATE_FORWARDING) | 3672 | rocker_port->stp_state == BR_STATE_FORWARDING) |
3673 | return 0; | 3673 | return 0; |
3674 | 3674 | ||
3675 | flags |= ROCKER_OP_FLAG_REMOVE; | 3675 | flags |= ROCKER_OP_FLAG_NOWAIT | ROCKER_OP_FLAG_REMOVE; |
3676 | 3676 | ||
3677 | spin_lock_irqsave(&rocker->fdb_tbl_lock, lock_flags); | 3677 | spin_lock_irqsave(&rocker->fdb_tbl_lock, lock_flags); |
3678 | 3678 | ||
@@ -4382,8 +4382,7 @@ static int rocker_port_attr_set(struct net_device *dev, | |||
4382 | 4382 | ||
4383 | switch (attr->id) { | 4383 | switch (attr->id) { |
4384 | case SWITCHDEV_ATTR_ID_PORT_STP_STATE: | 4384 | case SWITCHDEV_ATTR_ID_PORT_STP_STATE: |
4385 | err = rocker_port_stp_update(rocker_port, trans, | 4385 | err = rocker_port_stp_update(rocker_port, trans, 0, |
4386 | ROCKER_OP_FLAG_NOWAIT, | ||
4387 | attr->u.stp_state); | 4386 | attr->u.stp_state); |
4388 | break; | 4387 | break; |
4389 | case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS: | 4388 | case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS: |
@@ -4517,7 +4516,7 @@ static int rocker_port_fdb_del(struct rocker_port *rocker_port, | |||
4517 | const struct switchdev_obj_port_fdb *fdb) | 4516 | const struct switchdev_obj_port_fdb *fdb) |
4518 | { | 4517 | { |
4519 | __be16 vlan_id = rocker_port_vid_to_vlan(rocker_port, fdb->vid, NULL); | 4518 | __be16 vlan_id = rocker_port_vid_to_vlan(rocker_port, fdb->vid, NULL); |
4520 | int flags = ROCKER_OP_FLAG_NOWAIT | ROCKER_OP_FLAG_REMOVE; | 4519 | int flags = ROCKER_OP_FLAG_REMOVE; |
4521 | 4520 | ||
4522 | if (!rocker_port_is_bridged(rocker_port)) | 4521 | if (!rocker_port_is_bridged(rocker_port)) |
4523 | return -EINVAL; | 4522 | return -EINVAL; |