diff options
author | Jiri Pirko <jiri@mellanox.com> | 2015-10-14 13:40:53 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-10-15 09:09:50 -0400 |
commit | 56607386e80cc7ce923592e115a3492485b47c72 (patch) | |
tree | 7d6cce62e322c0926cde33503de35f4ede539328 | |
parent | 4d429c5ddc5128fccd3048059ae26bb39f0d8284 (diff) |
bridge: defer switchdev fdb del call in fdb_del_external_learn
Since spinlock is held here, defer the switchdev operation. Also, ensure
that defered switchdev ops are processed before port master device
is unlinked.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/bridge/br_fdb.c | 5 | ||||
-rw-r--r-- | net/bridge/br_if.c | 3 |
2 files changed, 7 insertions, 1 deletions
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index f5e7da0fe93b..c88bd8e8937e 100644 --- a/net/bridge/br_fdb.c +++ b/net/bridge/br_fdb.c | |||
@@ -134,7 +134,10 @@ static void fdb_del_hw_addr(struct net_bridge *br, const unsigned char *addr) | |||
134 | static void fdb_del_external_learn(struct net_bridge_fdb_entry *f) | 134 | static void fdb_del_external_learn(struct net_bridge_fdb_entry *f) |
135 | { | 135 | { |
136 | struct switchdev_obj_port_fdb fdb = { | 136 | struct switchdev_obj_port_fdb fdb = { |
137 | .obj.id = SWITCHDEV_OBJ_ID_PORT_FDB, | 137 | .obj = { |
138 | .id = SWITCHDEV_OBJ_ID_PORT_FDB, | ||
139 | .flags = SWITCHDEV_F_DEFER, | ||
140 | }, | ||
138 | .vid = f->vlan_id, | 141 | .vid = f->vlan_id, |
139 | }; | 142 | }; |
140 | 143 | ||
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 45e4757c6fd2..ec02f5869a78 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c | |||
@@ -24,6 +24,7 @@ | |||
24 | #include <linux/slab.h> | 24 | #include <linux/slab.h> |
25 | #include <net/sock.h> | 25 | #include <net/sock.h> |
26 | #include <linux/if_vlan.h> | 26 | #include <linux/if_vlan.h> |
27 | #include <net/switchdev.h> | ||
27 | 28 | ||
28 | #include "br_private.h" | 29 | #include "br_private.h" |
29 | 30 | ||
@@ -250,6 +251,8 @@ static void del_nbp(struct net_bridge_port *p) | |||
250 | 251 | ||
251 | nbp_vlan_flush(p); | 252 | nbp_vlan_flush(p); |
252 | br_fdb_delete_by_port(br, p, 0, 1); | 253 | br_fdb_delete_by_port(br, p, 0, 1); |
254 | switchdev_deferred_process(); | ||
255 | |||
253 | nbp_update_port_count(br); | 256 | nbp_update_port_count(br); |
254 | 257 | ||
255 | netdev_upper_dev_unlink(dev, br->dev); | 258 | netdev_upper_dev_unlink(dev, br->dev); |