diff options
| author | H Hartley Sweeten <hsweeten@visionengravers.com> | 2017-08-08 16:51:30 -0400 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2017-08-09 12:53:06 -0400 |
| commit | c7a909cf25c6e1198f5a261d2af0503985871e1a (patch) | |
| tree | f4a643fed5eebf734ff6c39a5a1c0d368d355c00 | |
| parent | 48738831018003c80f1131e77a25b8e832bec6f1 (diff) | |
spi: spi-ep93xx: remove private data 'current_msg'
The currently in-flight message can be found from the spi master.
Use that instead and remove the private data pointer.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-ep93xx.c | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index 2d80e36f5015..cf7d8175bf79 100644 --- a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c | |||
| @@ -74,7 +74,6 @@ | |||
| 74 | * @mmio: pointer to ioremap()'d registers | 74 | * @mmio: pointer to ioremap()'d registers |
| 75 | * @sspdr_phys: physical address of the SSPDR register | 75 | * @sspdr_phys: physical address of the SSPDR register |
| 76 | * @wait: wait here until given transfer is completed | 76 | * @wait: wait here until given transfer is completed |
| 77 | * @current_msg: message that is currently processed (or %NULL if none) | ||
| 78 | * @tx: current byte in transfer to transmit | 77 | * @tx: current byte in transfer to transmit |
| 79 | * @rx: current byte in transfer to receive | 78 | * @rx: current byte in transfer to receive |
| 80 | * @fifo_level: how full is FIFO (%0..%SPI_FIFO_SIZE - %1). Receiving one | 79 | * @fifo_level: how full is FIFO (%0..%SPI_FIFO_SIZE - %1). Receiving one |
| @@ -93,7 +92,6 @@ struct ep93xx_spi { | |||
| 93 | void __iomem *mmio; | 92 | void __iomem *mmio; |
| 94 | unsigned long sspdr_phys; | 93 | unsigned long sspdr_phys; |
| 95 | struct completion wait; | 94 | struct completion wait; |
| 96 | struct spi_message *current_msg; | ||
| 97 | size_t tx; | 95 | size_t tx; |
| 98 | size_t rx; | 96 | size_t rx; |
| 99 | size_t fifo_level; | 97 | size_t fifo_level; |
| @@ -236,8 +234,7 @@ static void ep93xx_do_read(struct ep93xx_spi *espi, struct spi_transfer *t) | |||
| 236 | static int ep93xx_spi_read_write(struct spi_master *master) | 234 | static int ep93xx_spi_read_write(struct spi_master *master) |
| 237 | { | 235 | { |
| 238 | struct ep93xx_spi *espi = spi_master_get_devdata(master); | 236 | struct ep93xx_spi *espi = spi_master_get_devdata(master); |
| 239 | struct spi_message *msg = espi->current_msg; | 237 | struct spi_transfer *t = master->cur_msg->state; |
| 240 | struct spi_transfer *t = msg->state; | ||
| 241 | 238 | ||
| 242 | /* read as long as RX FIFO has frames in it */ | 239 | /* read as long as RX FIFO has frames in it */ |
| 243 | while ((readl(espi->mmio + SSPSR) & SSPSR_RNE)) { | 240 | while ((readl(espi->mmio + SSPSR) & SSPSR_RNE)) { |
| @@ -290,7 +287,7 @@ ep93xx_spi_dma_prepare(struct spi_master *master, | |||
| 290 | enum dma_transfer_direction dir) | 287 | enum dma_transfer_direction dir) |
| 291 | { | 288 | { |
| 292 | struct ep93xx_spi *espi = spi_master_get_devdata(master); | 289 | struct ep93xx_spi *espi = spi_master_get_devdata(master); |
| 293 | struct spi_transfer *t = espi->current_msg->state; | 290 | struct spi_transfer *t = master->cur_msg->state; |
| 294 | struct dma_async_tx_descriptor *txd; | 291 | struct dma_async_tx_descriptor *txd; |
| 295 | enum dma_slave_buswidth buswidth; | 292 | enum dma_slave_buswidth buswidth; |
| 296 | struct dma_slave_config conf; | 293 | struct dma_slave_config conf; |
| @@ -415,13 +412,12 @@ static void ep93xx_spi_dma_callback(void *callback_param) | |||
| 415 | static void ep93xx_spi_dma_transfer(struct spi_master *master) | 412 | static void ep93xx_spi_dma_transfer(struct spi_master *master) |
| 416 | { | 413 | { |
| 417 | struct ep93xx_spi *espi = spi_master_get_devdata(master); | 414 | struct ep93xx_spi *espi = spi_master_get_devdata(master); |
| 418 | struct spi_message *msg = espi->current_msg; | ||
| 419 | struct dma_async_tx_descriptor *rxd, *txd; | 415 | struct dma_async_tx_descriptor *rxd, *txd; |
| 420 | 416 | ||
| 421 | rxd = ep93xx_spi_dma_prepare(master, DMA_DEV_TO_MEM); | 417 | rxd = ep93xx_spi_dma_prepare(master, DMA_DEV_TO_MEM); |
| 422 | if (IS_ERR(rxd)) { | 418 | if (IS_ERR(rxd)) { |
| 423 | dev_err(&master->dev, "DMA RX failed: %ld\n", PTR_ERR(rxd)); | 419 | dev_err(&master->dev, "DMA RX failed: %ld\n", PTR_ERR(rxd)); |
| 424 | msg->status = PTR_ERR(rxd); | 420 | master->cur_msg->status = PTR_ERR(rxd); |
| 425 | return; | 421 | return; |
| 426 | } | 422 | } |
| 427 | 423 | ||
| @@ -429,7 +425,7 @@ static void ep93xx_spi_dma_transfer(struct spi_master *master) | |||
| 429 | if (IS_ERR(txd)) { | 425 | if (IS_ERR(txd)) { |
| 430 | ep93xx_spi_dma_finish(master, DMA_DEV_TO_MEM); | 426 | ep93xx_spi_dma_finish(master, DMA_DEV_TO_MEM); |
| 431 | dev_err(&master->dev, "DMA TX failed: %ld\n", PTR_ERR(txd)); | 427 | dev_err(&master->dev, "DMA TX failed: %ld\n", PTR_ERR(txd)); |
| 432 | msg->status = PTR_ERR(txd); | 428 | master->cur_msg->status = PTR_ERR(txd); |
| 433 | return; | 429 | return; |
| 434 | } | 430 | } |
| 435 | 431 | ||
| @@ -587,9 +583,7 @@ static int ep93xx_spi_transfer_one_message(struct spi_master *master, | |||
| 587 | msg->status = 0; | 583 | msg->status = 0; |
| 588 | msg->actual_length = 0; | 584 | msg->actual_length = 0; |
| 589 | 585 | ||
| 590 | espi->current_msg = msg; | ||
| 591 | ep93xx_spi_process_message(master, msg); | 586 | ep93xx_spi_process_message(master, msg); |
| 592 | espi->current_msg = NULL; | ||
| 593 | 587 | ||
| 594 | spi_finalize_current_message(master); | 588 | spi_finalize_current_message(master); |
| 595 | 589 | ||
| @@ -611,7 +605,7 @@ static irqreturn_t ep93xx_spi_interrupt(int irq, void *dev_id) | |||
| 611 | writel(0, espi->mmio + SSPICR); | 605 | writel(0, espi->mmio + SSPICR); |
| 612 | dev_warn(&master->dev, | 606 | dev_warn(&master->dev, |
| 613 | "receive overrun, aborting the message\n"); | 607 | "receive overrun, aborting the message\n"); |
| 614 | espi->current_msg->status = -EIO; | 608 | master->cur_msg->status = -EIO; |
| 615 | } else { | 609 | } else { |
| 616 | /* | 610 | /* |
| 617 | * Interrupt is either RX (RIS) or TX (TIS). For both cases we | 611 | * Interrupt is either RX (RIS) or TX (TIS). For both cases we |
