diff options
| author | Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> | 2018-10-08 13:16:31 -0400 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2018-10-15 13:09:16 -0400 |
| commit | a3e403161fe1cc87bdbcfb8a4a4eab7aa6ac1a96 (patch) | |
| tree | 8d9807c62f95767171e6d2508515079331b3a644 | |
| parent | d64e1b3f5cce41dd878a3ea008dd696a4d7d07d9 (diff) | |
dmaengine: owl: Fix warnings generated during build
Following warnings are generated when compiled with W=1,
drivers/dma/owl-dma.c:170: warning: Function parameter or member 'cyclic'
not described in 'owl_dma_txd'
drivers/dma/owl-dma.c:198: warning: Function parameter or member 'cfg' not
described in 'owl_dma_vchan'
drivers/dma/owl-dma.c:198: warning: Function parameter or member 'drq' not
described in 'owl_dma_vchan'
drivers/dma/owl-dma.c:225: warning: Function parameter or member 'irq' not
described in 'owl_dma'
Fix this by adding comments for relevant struct members to appear in
kernel-doc.
Fixes: d64e1b3f5cce ("dmaengine: owl: Add Slave and Cyclic mode support for
Actions Semi Owl S900 SoC")
Reported-by: Vinod Koul <vinod.koul@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/owl-dma.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c index 1d26db4c9229..90bbcef99ef8 100644 --- a/drivers/dma/owl-dma.c +++ b/drivers/dma/owl-dma.c | |||
| @@ -162,6 +162,7 @@ struct owl_dma_lli { | |||
| 162 | * struct owl_dma_txd - Wrapper for struct dma_async_tx_descriptor | 162 | * struct owl_dma_txd - Wrapper for struct dma_async_tx_descriptor |
| 163 | * @vd: virtual DMA descriptor | 163 | * @vd: virtual DMA descriptor |
| 164 | * @lli_list: link list of lli nodes | 164 | * @lli_list: link list of lli nodes |
| 165 | * @cyclic: flag to indicate cyclic transfers | ||
| 165 | */ | 166 | */ |
| 166 | struct owl_dma_txd { | 167 | struct owl_dma_txd { |
| 167 | struct virt_dma_desc vd; | 168 | struct virt_dma_desc vd; |
| @@ -188,6 +189,8 @@ struct owl_dma_pchan { | |||
| 188 | * @vc: wrappped virtual channel | 189 | * @vc: wrappped virtual channel |
| 189 | * @pchan: the physical channel utilized by this channel | 190 | * @pchan: the physical channel utilized by this channel |
| 190 | * @txd: active transaction on this channel | 191 | * @txd: active transaction on this channel |
| 192 | * @cfg: slave configuration for this channel | ||
| 193 | * @drq: physical DMA request ID for this channel | ||
| 191 | */ | 194 | */ |
| 192 | struct owl_dma_vchan { | 195 | struct owl_dma_vchan { |
| 193 | struct virt_dma_chan vc; | 196 | struct virt_dma_chan vc; |
| @@ -204,6 +207,7 @@ struct owl_dma_vchan { | |||
| 204 | * @clk: clock for the DMA controller | 207 | * @clk: clock for the DMA controller |
| 205 | * @lock: a lock to use when change DMA controller global register | 208 | * @lock: a lock to use when change DMA controller global register |
| 206 | * @lli_pool: a pool for the LLI descriptors | 209 | * @lli_pool: a pool for the LLI descriptors |
| 210 | * @irq: interrupt ID for the DMA controller | ||
| 207 | * @nr_pchans: the number of physical channels | 211 | * @nr_pchans: the number of physical channels |
| 208 | * @pchans: array of data for the physical channels | 212 | * @pchans: array of data for the physical channels |
| 209 | * @nr_vchans: the number of physical channels | 213 | * @nr_vchans: the number of physical channels |
