diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2018-07-28 18:43:14 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-07-28 18:43:14 -0400 |
commit | 2ffb57dfa793ca2932c524a1e91d403b28bd84b9 (patch) | |
tree | 825484cf73473bc2424af70aa572ec9060948d7c | |
parent | 7648c44680de90a0b656a55813fed5f6621512c5 (diff) | |
parent | bbfbf04c2d4ef673f657175456f6693c9225748a (diff) |
Merge tag 'gpio-v4.18-2' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio
Pull GPIO fixes from Linus Walleij:
"Just a smallish OF fix and a driver fix:
- OF flag fix for special regulator flags
- fix up the Uniphier IRQ callback"
* tag 'gpio-v4.18-2' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio:
gpio: uniphier: set legitimate irq trigger type in .to_irq hook
gpio: of: Handle fixed regulator flags properly
-rw-r--r-- | drivers/gpio/gpio-uniphier.c | 6 | ||||
-rw-r--r-- | drivers/gpio/gpiolib-of.c | 3 |
2 files changed, 7 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c index d3cf9502e7e7..58faeb1cef63 100644 --- a/drivers/gpio/gpio-uniphier.c +++ b/drivers/gpio/gpio-uniphier.c | |||
@@ -181,7 +181,11 @@ static int uniphier_gpio_to_irq(struct gpio_chip *chip, unsigned int offset) | |||
181 | fwspec.fwnode = of_node_to_fwnode(chip->parent->of_node); | 181 | fwspec.fwnode = of_node_to_fwnode(chip->parent->of_node); |
182 | fwspec.param_count = 2; | 182 | fwspec.param_count = 2; |
183 | fwspec.param[0] = offset - UNIPHIER_GPIO_IRQ_OFFSET; | 183 | fwspec.param[0] = offset - UNIPHIER_GPIO_IRQ_OFFSET; |
184 | fwspec.param[1] = IRQ_TYPE_NONE; | 184 | /* |
185 | * IRQ_TYPE_NONE is rejected by the parent irq domain. Set LEVEL_HIGH | ||
186 | * temporarily. Anyway, ->irq_set_type() will override it later. | ||
187 | */ | ||
188 | fwspec.param[1] = IRQ_TYPE_LEVEL_HIGH; | ||
185 | 189 | ||
186 | return irq_create_fwspec_mapping(&fwspec); | 190 | return irq_create_fwspec_mapping(&fwspec); |
187 | } | 191 | } |
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 28d968088131..53a14ee8ad6d 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c | |||
@@ -64,7 +64,8 @@ static void of_gpio_flags_quirks(struct device_node *np, | |||
64 | * Note that active low is the default. | 64 | * Note that active low is the default. |
65 | */ | 65 | */ |
66 | if (IS_ENABLED(CONFIG_REGULATOR) && | 66 | if (IS_ENABLED(CONFIG_REGULATOR) && |
67 | (of_device_is_compatible(np, "reg-fixed-voltage") || | 67 | (of_device_is_compatible(np, "regulator-fixed") || |
68 | of_device_is_compatible(np, "reg-fixed-voltage") || | ||
68 | of_device_is_compatible(np, "regulator-gpio"))) { | 69 | of_device_is_compatible(np, "regulator-gpio"))) { |
69 | /* | 70 | /* |
70 | * The regulator GPIO handles are specified such that the | 71 | * The regulator GPIO handles are specified such that the |