drm/nouveau/nvif: simplify and tidy library interfaces

A variety of tweaks to the NVIF library interfaces, mostly ripping out
things that turned out to be not so useful.

- Removed refcounting from nvif_object, callers are expected to not be
  stupid instead.
- nvif_client is directly reachable from anything derived from nvif_object,
  removing the need for heuristics to locate it
- _new() versions of interfaces, that allocate memory for the object
  they construct, have been removed.  The vast majority of callers used
  the embedded _init() interfaces.
- No longer storing constructor arguments (and the data returned from
  nvkm) inside nvif_object, it's more or less unused and just wastes
  memory.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/drivers/gpu/drm/nouveau/nv17_fence.c b/drivers/gpu/drm/nouveau/nv17_fence.c
index 57860cfa1de5..80b6eb8b3d02 100644
--- a/drivers/gpu/drm/nouveau/nv17_fence.c
+++ b/drivers/gpu/drm/nouveau/nv17_fence.c
@@ -33,7 +33,7 @@ int
 nv17_fence_sync(struct nouveau_fence *fence,
                 struct nouveau_channel *prev, struct nouveau_channel *chan)
 {
-        struct nouveau_cli *cli = (void *)nvif_client(&prev->device->base);
+        struct nouveau_cli *cli = (void *)prev->user.client;
         struct nv10_fence_priv *priv = chan->drm->fence;
         struct nv10_fence_chan *fctx = chan->fence;
         u32 value;
@@ -89,7 +89,7 @@ nv17_fence_context_new(struct nouveau_channel *chan)
         fctx->base.read = nv10_fence_read;
         fctx->base.sync = nv17_fence_sync;
 
-        ret = nvif_object_init(chan->object, NULL, NvSema, NV_DMA_FROM_MEMORY,
+        ret = nvif_object_init(&chan->user, NvSema, NV_DMA_FROM_MEMORY,
                                &(struct nv_dma_v0) {
                                         .target = NV_DMA_V0_TARGET_VRAM,
                                         .access = NV_DMA_V0_ACCESS_RDWR,