diff options
author | Sylvain Lemieux <slemieux@tycoint.com> | 2016-02-23 14:56:09 -0500 |
---|---|---|
committer | Stephen Boyd <sboyd@codeaurora.org> | 2016-03-03 14:41:43 -0500 |
commit | 8626556f259331aac23c0e274aed24420f0e5403 (patch) | |
tree | 24e0d15dfc717e775b2e1edc524267312af2d75b | |
parent | 0f4c7a138dfefb0ebdbaf56e3ba2acd2958a6605 (diff) |
clk: lpc32xx: fix compilation warning
Remove the following false positives compilation warning:
- drivers/clk/nxp/clk-lpc32xx.c: In function 'lpc32xx_clk_register':
warning: 'hw' may be used uninitialized in this function [-Wmaybe-uninitialized]
- drivers/clk/nxp/clk-lpc32xx.c: In function 'clk_hclk_pll_round_rate':
warning: 'p' may be used uninitialized in this function [-Wmaybe-uninitialized]
warning: 'n' may be used uninitialized in this function [-Wmaybe-uninitialized]
warning: 'm' may be used uninitialized in this function [-Wmaybe-uninitialized]
Tested using gcc version 4.7.3.
Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
[sboyd@codeaurora.org: Drop assignment of hw to NULL as return
silences it and is less likely to lead to hiding problems later]
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
-rw-r--r-- | drivers/clk/nxp/clk-lpc32xx.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c index 48b3a11aa09a..481b2646b496 100644 --- a/drivers/clk/nxp/clk-lpc32xx.c +++ b/drivers/clk/nxp/clk-lpc32xx.c | |||
@@ -588,7 +588,8 @@ static long clk_hclk_pll_round_rate(struct clk_hw *hw, unsigned long rate, | |||
588 | unsigned long *parent_rate) | 588 | unsigned long *parent_rate) |
589 | { | 589 | { |
590 | struct lpc32xx_pll_clk *clk = to_lpc32xx_pll_clk(hw); | 590 | struct lpc32xx_pll_clk *clk = to_lpc32xx_pll_clk(hw); |
591 | u64 m_i, m, n, p, o = rate, i = *parent_rate, d = (u64)rate << 6; | 591 | u64 m_i, o = rate, i = *parent_rate, d = (u64)rate << 6; |
592 | u64 m = 0, n = 0, p = 0; | ||
592 | int p_i, n_i; | 593 | int p_i, n_i; |
593 | 594 | ||
594 | pr_debug("%s: %lu/%lu\n", clk_hw_get_name(hw), *parent_rate, rate); | 595 | pr_debug("%s: %lu/%lu\n", clk_hw_get_name(hw), *parent_rate, rate); |
@@ -1428,6 +1429,8 @@ static struct clk * __init lpc32xx_clk_register(u32 id) | |||
1428 | hw = &clk_hw->hw0.div.hw; | 1429 | hw = &clk_hw->hw0.div.hw; |
1429 | else if (clk_hw->type == CLK_GATE) | 1430 | else if (clk_hw->type == CLK_GATE) |
1430 | hw = &clk_hw->hw0.gate.hw; | 1431 | hw = &clk_hw->hw0.gate.hw; |
1432 | else | ||
1433 | return ERR_PTR(-EINVAL); | ||
1431 | 1434 | ||
1432 | hw->init = &clk_init; | 1435 | hw->init = &clk_init; |
1433 | clk = clk_register(NULL, hw); | 1436 | clk = clk_register(NULL, hw); |