| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
Add the function trace_graph_refresh_filters that redraws the graph
after the filters are updated.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
Allow trace_graph_update_filters have the ginfo filters passed to
it. This will give a way to let external users to refresh the graph
filters.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
Use gtk_dialog_run() and examine the results instead of having
to create a helper structure that is allocated and passed back to
signals.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
Use gtk_dialog_run() and examine the results instead of having
to create a helper structure that is allocated and passed back to
signals.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
Use gtk_dialog_run() and examine the results instead of having
to create a helper structure that is allocated and passed back to
signals.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
Use gtk_dialog_run() and examine the results instead of having
to create a helper structure that is allocated and passed back to
signals.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
To make the task filters more like the event filters, allow the
list and graph to have their own filtering.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
The pop up said "Hide task to filter" which does not make any sense.
Change it to just "Hide task".
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
The code that cleaned up parsing the printk_format file never registered
the formats to the pevent code. Any trace_printk() that used bprint()
was not able to be parsed.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
| |
The document is inconsistent with its use of time stamp and timestamp
as well as time line and timeline. This patch changes them all to
be single words, except when referencing the GUI labels which have
the space.
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
| |
Reported-by: Darren Hart <dvhltc@us.ibm.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
| |
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Install the HTML document on "make install_doc" and have the
kernelshark executable be able to reference that location.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
| |
Add documentation on how to use kernelshark.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
When selecting a cursor with the double click, the zoom tip does
not go away. Clear it on double click.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
Add a function to handle old gtk libs that do not implement
gtk_widget_set_tooltip_text(). But this compat function only works
with widgets with windows, so there's not much we can do.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
| |
Show tip window to explain how to zoom in and out on the graph.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
| |
Add tooltips to give some information on the markers.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Remove the printf statements that was used for debugging in
trace-filter.c.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
When a warning happens, show it with a dialog instead of printing
to the console.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
Move the util functions used by parse-events into a separate file
and compile it with the libparsevents library. Also add "__die()"
equivalent functions that are always available.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Move the code for the status bar to trace-dialog.c and have
trace-view and trace-graph have access to it too.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
| |
Add a status bar at the bottom of the window and show an info icon
when status exists.
Left mouse button will produce a popup to let the user display
the status information.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The popup menu for removing a task said:
Remove task to filter
when it should be saying:
Remove task from filter
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
Make the xml doc under <KernelShark>...</KernelShark> for trace-view
and trace-graph. Also pull out the task filters since the view
and graph in kernelshark share the same filters.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Hooked to the trace-view and trace-graph code to load and save
event and task filters.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
Add the filter loading and saving to trace-graph. Most of the work
was done already to get trace-view working. This just hooks into
that framework.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Include saving of the task filters to the filter file as well as
the ability to load them.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Add pop-up menu over the rows that will allow to filter on tasks
in trace-view.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Add "Load filters" to trace-view that loads the event filters
saved with a "Save filters".
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Add "Save filters" to "File" menu, where it will allow the user to save
the filters to a file in XML format.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Added shortcut trace_get_file_dialog() to simplify the asking for
a file name.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Add help content and about to menu options. Still need to write
the help content, right now it just points to google.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Add trace-dialog.c to include a trace_show_help() and trace_dialog()
helpers.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
To remove the trace.dat man page "SYNOPSIS" section, the lines
from: .SH "SYNOPSIS" to .sp are removed. But some systems do not
add a .sp after the SYNOPSIS, so they remove the entire rest of
the document.
Instead of testing for .sp, test for "ignore" since that is in the
document and is known to be there.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keep kernelshark from segfaulting when there is no open trace file.
It segfaults in:
Filter->graph events
Filter->graph advanced event
Filter->list CPUs
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
LKML-Reference: <20100408155736.3d12af4f.randy.dunlap@oracle.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
Typo/grammo corrections to trace-cmd.dat.5.txt:
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
LKML-Reference: <20100408155718.8673c823.randy.dunlap@oracle.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
Add the option '-r' to the trace-cmd record that will set the
trace capture threads to that real-time FIFO priority.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adjust Makefile to allow cross-compilation (using CROSS_COMPILE variable)
To use, do something like: 'make CROSS_COMPILE=arm-eabi-linux-'
and make sure 'arm-eabi-linux-gcc' and friends on on your PATH
You can also just set CROSS_COMPILE in your environment variable
before calling 'make'.
Signed-off-by: Tim Bird <tim.bird@am.sony.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes an error in the mac80211 plugin
when it parses flags, seems we never noticed
because I ordered the flags properly.
Also add the new QOS flag.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
| |
The parent arg in process_value() may not be changed on error.
If we pass in an argument, then it needs to be initialized to NULL
if we plan on freeing it on failure.
Reported-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
| |
The process_not() filter parsing did not assign an arg to the parent arg,
and the entire expression was ignored.
Reported-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seeing in the Buffer statistics:
entries: 0
Makes it look like nothing was recorded when the opposite is true.
Add a note that explains what this value means.
Reported-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The parenthesis filter parsing was a bit broken and needed a rewrite.
This redesigns the filter parsing to be a bit more sane when it comes
to parenthesis. It lets the parenthesis be treated as what they resolve
to be.
Funny, the example used by kernelshark failed because of this bug:
"next_prio < 100 && (prev_prio > 100 && prev_pid != 0)"
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
|
| |
If the ring buffer in the kernel sends information via the commit
field of the sub buffer header. Than this patch will display
where events were lost.
If the sub buffer has space and can store the count of dropped events,
this patch will show the count as well.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The while loop that copies pages from one dat file ot the next
breaks after it copies the last page that it is expected to.
But after the while loop (for other split types) there is also a checkt
if a page is not finished and should be copied. But this always copies
the page again with the page count option, and causes a duplict page
at the end of the trace.
The fix is simply to break out of the loop before copying the data
when the page count is hit. Then the copy after the while loop will
copy the last page needed.
Reported-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is a common mistake to do:
trace-cmd split my-trace.dat
Expecting to be splitting the file my-trace.dat. But this is taken
as the starting value and the user will not know that the command
ran the split against trace.dat (if it exists).
This patch checks to make sure that the start and end values passed
in are indeed floating point (or integer) values.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
| |
If a output file is specified, always append a '.1' to it.
This removes the confusion of where the output file is written to
and it could cause data to be overwritten that was not expected.
Reported-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
|
|
| |
If a directory is specified in the output file for trace-cmd split,
then it would fault because of the adding of the prefix ".tmp"
to the output name. This patch fixes the issues by parsing out the
directory name and basename from the output path.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|
|
|
|
|
|
|
| |
The loop after getaddrinfo() needs to test connect() against -1, not 1.
Reported-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
|