trace-view: Added saving of filters

Add "Save filters" to "File" menu, where it will allow the user to save
the filters to a file in XML format.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

8 files changed, 323 insertions, 5 deletions

diff --git a/Makefile b/Makefile
index 7402ae1..cd4db4a 100644
--- a/Makefile
+++ b/Makefile
@@ -96,7 +96,7 @@ plugin_dir_SQ = $(subst ','\'',$(plugin_dir))
 LIBS = -L. -ltracecmd -ldl
 LIB_FILE = libtracecmd.a
 
-PACKAGES= gtk+-2.0
+PACKAGES= gtk+-2.0 libxml-2.0
 
 ifndef BUILDGUI
  BUILDGUI = 0
@@ -213,13 +213,15 @@ $(obj)/%.o: $(src)/%.c
 %.o: $(src)/%.c
         $(Q)$(call check_gui)
 
-TRACE_GUI_OBJS = trace-filter.o trace-compat.o trace-hash.o trace-dialog.o
+TRACE_GUI_OBJS = trace-filter.o trace-compat.o trace-hash.o trace-dialog.o \
+                trace-xml.o
 TRACE_CMD_OBJS = trace-cmd.o trace-usage.o trace-read.o trace-split.o trace-listen.o
 TRACE_VIEW_OBJS = trace-view.o trace-view-store.o
 TRACE_GRAPH_OBJS = trace-graph.o trace-plot.o trace-plot-cpu.o trace-plot-task.o
 TRACE_VIEW_MAIN_OBJS = trace-view-main.o $(TRACE_VIEW_OBJS) $(TRACE_GUI_OBJS)
 TRACE_GRAPH_MAIN_OBJS = trace-graph-main.o $(TRACE_GRAPH_OBJS) $(TRACE_GUI_OBJS)
-KERNEL_SHARK_OBJS = $(TRACE_VIEW_OBJS) $(TRACE_GRAPH_OBJS) $(TRACE_GUI_OBJS) kernel-shark.o
+KERNEL_SHARK_OBJS = $(TRACE_VIEW_OBJS) $(TRACE_GRAPH_OBJS) $(TRACE_GUI_OBJS) \
+        kernel-shark.o
 
 PEVENT_LIB_OBJS = parse-events.o trace-seq.o parse-filter.o
 TCMD_LIB_OBJS = $(PEVENT_LIB_OBJS) trace-util.o trace-input.o trace-ftrace.o \
diff --git a/trace-filter.c b/trace-filter.c
index 15d59c0..904c9cb 100644
--- a/trace-filter.c
+++ b/trace-filter.c
@@ -2158,3 +2158,54 @@ void trace_filter_convert_char_to_filter(struct event_filter *filter,
 
         pevent_filter_free(copy);
 }
+
+int trace_filter_save_events(struct tracecmd_xml_handle *handle,
+                             struct event_filter *filter)
+{
+        struct event_format *event;
+        char **systems;
+        gint *event_ids;
+        char *str;
+        int i;
+
+        trace_filter_convert_filter_to_names(filter, &systems,
+                                             &event_ids);
+
+        for (i = 0; systems && systems[i]; i++)
+                tracecmd_xml_write_element(handle, "System", systems[i]);
+
+        for (i = 0; event_ids && event_ids[i] > 0; i++) {
+                str = pevent_filter_make_string(filter, event_ids[i]);
+                if (!str)
+                        continue;
+
+                event = pevent_find_event(filter->pevent, event_ids[i]);
+                if (event) {
+
+                        /* skip not filtered items */
+                        if (strcmp(str, "FALSE") == 0) {
+                                free(str);
+                                continue;
+                        }
+
+                        tracecmd_xml_start_sub_system(handle, "Event");
+                        tracecmd_xml_write_element(handle, "System", event->system);
+                        tracecmd_xml_write_element(handle, "Name", event->name);
+                        /* If this is has an advanced filter, include that too */
+                        if (strcmp(str, "TRUE") != 0) {
+                                tracecmd_xml_write_element(handle, "Advanced",
+                                                           str);
+                        }
+                        tracecmd_xml_end_sub_system(handle);
+                }
+                free(str);
+        }
+
+        return 0;
+}
+
+int trace_filter_save_tasks(struct tracecmd_xml_handle *handle,
+                            struct filter_task *filter)
+{
+        return 0;
+}
diff --git a/trace-filter.h b/trace-filter.h
index c68e8f0..7575244 100644
--- a/trace-filter.h
+++ b/trace-filter.h
@@ -23,6 +23,8 @@
 
 #include <gtk/gtk.h>
 
+#include "trace-xml.h"
+
 struct event_filter_list {
         struct event_filter_list        *next;
         struct event                    *event;
@@ -140,4 +142,9 @@ int id_cmp(const void *a, const void *b);
 
 void trace_array_add(gint **array, gint *count, gint val);
 
+int trace_filter_save_events(struct tracecmd_xml_handle *handle,
+                             struct event_filter *filter);
+int trace_filter_save_tasks(struct tracecmd_xml_handle *handle,
+                            struct filter_task *filter);
+
 #endif /* _TRACE_FILTER_H */
diff --git a/trace-view-main.c b/trace-view-main.c
index 7f1461b..52fb4f8 100644
--- a/trace-view-main.c
+++ b/trace-view-main.c
@@ -28,6 +28,7 @@
 
 #include "trace-cmd.h"
 #include "trace-view.h"
+#include "trace-xml.h"
 #include "trace-gui.h"
 
 #define version "0.1.1"
@@ -71,6 +72,29 @@ load_clicked (gpointer data)
         g_free(filename);
 }
 
+/* Callback for the clicked signal of the Save State button */
+static void
+save_filters_clicked (gpointer data)
+{
+        struct trace_tree_info *info = data;
+        GtkTreeView *trace_tree = GTK_TREE_VIEW(info->trace_tree);
+        struct tracecmd_xml_handle *handle;
+        gchar *filename;
+
+        filename = trace_get_file_dialog("Save State");
+        if (!filename)
+                return;
+
+        handle = tracecmd_xml_create(filename);
+        if (!handle)
+                warning("Could not create save state %s", filename);
+        g_free(filename);
+
+        trace_view_save_filters(handle, trace_tree);
+
+        tracecmd_xml_close(handle);
+}
+
 /* Callback for the clicked signal of the Exit button */
 static void
 exit_clicked (GtkWidget *widget, gpointer data)
@@ -249,12 +273,11 @@ void trace_view(int argc, char **argv)
 
         /* --- File - Load Option --- */
 
-        sub_item = gtk_menu_item_new_with_label("Load info");
+        sub_item = gtk_menu_item_new_with_label("Load data");
 
         /* Add them to the menu */
         gtk_menu_shell_append(GTK_MENU_SHELL (menu), sub_item);
 
-        /* We can attach the Quit menu item to our exit function */
         g_signal_connect_swapped (G_OBJECT (sub_item), "activate",
                                   G_CALLBACK (load_clicked),
                                   (gpointer) &tree_info);
@@ -263,6 +286,21 @@ void trace_view(int argc, char **argv)
         gtk_widget_show(sub_item);
 
 
+        /* --- File - Save State Option --- */
+
+        sub_item = gtk_menu_item_new_with_label("Save filters");
+
+        /* Add them to the menu */
+        gtk_menu_shell_append(GTK_MENU_SHELL (menu), sub_item);
+
+        g_signal_connect_swapped (G_OBJECT (sub_item), "activate",
+                                  G_CALLBACK (save_filters_clicked),
+                                  (gpointer) &tree_info);
+
+        /* We do need to show menu items */
+        gtk_widget_show(sub_item);
+
+
         /* --- File - Quit Option --- */
 
         sub_item = gtk_menu_item_new_with_label("Quit");
diff --git a/trace-view.c b/trace-view.c
index 59e7e1a..c183b19 100644
--- a/trace-view.c
+++ b/trace-view.c
@@ -29,6 +29,7 @@
 #include "trace-local.h"
 #include "trace-view.h"
 #include "trace-compat.h"
+#include "version.h"
 #include "cpu.h"
 #include "util.h"
 
@@ -870,3 +871,50 @@ void trace_view_search_setup(GtkBox *box, GtkTreeView *treeview)
                                   G_CALLBACK (search_tree),