diff options
Diffstat (limited to 'trace-graph.c')
-rw-r--r-- | trace-graph.c | 38 |
1 files changed, 20 insertions, 18 deletions
diff --git a/trace-graph.c b/trace-graph.c index 69f5069..0aa8137 100644 --- a/trace-graph.c +++ b/trace-graph.c | |||
@@ -1852,14 +1852,16 @@ static void draw_plot(struct graph_info *ginfo, struct graph_plot *plot, | |||
1852 | } | 1852 | } |
1853 | 1853 | ||
1854 | /* | 1854 | /* |
1855 | * TODO: this method needs refactoring and splitting | 1855 | * TODO: this method needs refactoring and splitting. |
1856 | * Containers currently aren't using hashing, which can significantly affect | ||
1857 | * performance if enough containers are being rendered. | ||
1856 | */ | 1858 | */ |
1857 | static void draw_hashed_plots(struct graph_info *ginfo) | 1859 | static void draw_hashed_plots(struct graph_info *ginfo) |
1858 | { | 1860 | { |
1859 | gint cpu, pid, clean; | 1861 | gint cpu, pid, clean; |
1860 | struct record *record; | 1862 | struct record *record; |
1861 | struct plot_hash *hash; | ||
1862 | struct plot_list *list; | 1863 | struct plot_list *list; |
1864 | struct plot_hash *hash; | ||
1863 | unsigned long long max_time, min_time; | 1865 | unsigned long long max_time, min_time; |
1864 | gdouble start, duration; | 1866 | gdouble start, duration; |
1865 | 1867 | ||
@@ -1940,19 +1942,19 @@ static void draw_hashed_plots(struct graph_info *ginfo) | |||
1940 | } | 1942 | } |
1941 | 1943 | ||
1942 | 1944 | ||
1943 | /* hash = trace_graph_plot_find_cpu(ginfo, cpu); */ | 1945 | hash = trace_graph_plot_find_cpu(ginfo, cpu); |
1944 | /* if (hash) { */ | 1946 | if (hash) { |
1945 | /* for (list = hash->plots; list; list = list->next) { */ | 1947 | for (list = hash->plots; list; list = list->next) { |
1946 | /* draw_plot(ginfo, list->plot, record); */ | 1948 | draw_plot(ginfo, list->plot, record); |
1947 | /* } */ | 1949 | } |
1948 | /* } */ | 1950 | } |
1949 | /* pid = pevent_data_pid(ginfo->pevent, record); */ | 1951 | pid = pevent_data_pid(ginfo->pevent, record); |
1950 | /* hash = trace_graph_plot_find_task(ginfo, pid); */ | 1952 | hash = trace_graph_plot_find_task(ginfo, pid); |
1951 | /* if (hash) { */ | 1953 | if (hash) { |
1952 | /* for (list = hash->plots; list; list = list->next) { */ | 1954 | for (list = hash->plots; list; list = list->next) { |
1953 | /* draw_plot(ginfo, list->plot, record); */ | 1955 | draw_plot(ginfo, list->plot, record); |
1954 | /* } */ | 1956 | } |
1955 | /* } */ | 1957 | } |
1956 | for (list = ginfo->all_recs; list; list = list->next) { | 1958 | for (list = ginfo->all_recs; list; list = list->next) { |
1957 | /* TODO: hacky assumption that everything else can be | 1959 | /* TODO: hacky assumption that everything else can be |
1958 | * reached via previous hashes | 1960 | * reached via previous hashes |
@@ -1960,10 +1962,10 @@ static void draw_hashed_plots(struct graph_info *ginfo) | |||
1960 | * added with arbitrary numbers, and a pevent_other_id | 1962 | * added with arbitrary numbers, and a pevent_other_id |
1961 | * which uses id ranges x < . < y to parse cids or lids | 1963 | * which uses id ranges x < . < y to parse cids or lids |
1962 | */ | 1964 | */ |
1963 | /* if (list->plot->type == PLOT_TYPE_SERVER_TASK || */ | 1965 | if (list->plot->type == PLOT_TYPE_SERVER_TASK || |
1964 | /* list->plot->type == PLOT_TYPE_SERVER_CPU) { */ | 1966 | list->plot->type == PLOT_TYPE_SERVER_CPU) { |
1965 | draw_plot(ginfo, list->plot, record); | 1967 | draw_plot(ginfo, list->plot, record); |
1966 | /* } */ | 1968 | } |
1967 | } | 1969 | } |
1968 | free_record(record); | 1970 | free_record(record); |
1969 | } | 1971 | } |