diff options
author | Steven Rostedt <srostedt@redhat.com> | 2010-02-17 20:19:22 -0500 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2010-02-17 20:25:02 -0500 |
commit | 667fae1868c7d94c290e74aaaeed1a0f265f830e (patch) | |
tree | a251169af4f349d65c581675a156d388d18aa07e | |
parent | a79e7a9311de8b43f07aa7c92d332ac920b70eda (diff) |
kernelshark/trace-graph: Convert to use trace_filter_event_filter_dialog()
Use the event_filter dialog instead of the system and event names.
trace-view already does this, this patch converts kernelshark and
trace-graph.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
-rw-r--r-- | kernel-shark.c | 29 | ||||
-rw-r--r-- | trace-graph-main.c | 12 | ||||
-rw-r--r-- | trace-graph.c | 4 |
3 files changed, 16 insertions, 29 deletions
diff --git a/kernel-shark.c b/kernel-shark.c index fc90443..92eea8e 100644 --- a/kernel-shark.c +++ b/kernel-shark.c | |||
@@ -197,8 +197,6 @@ list_events_clicked (gpointer data) | |||
197 | GtkTreeModel *model; | 197 | GtkTreeModel *model; |
198 | TraceViewStore *store; | 198 | TraceViewStore *store; |
199 | gboolean all_events; | 199 | gboolean all_events; |
200 | gchar **systems; | ||
201 | gint *events; | ||
202 | 200 | ||
203 | model = gtk_tree_view_get_model(trace_tree); | 201 | model = gtk_tree_view_get_model(trace_tree); |
204 | if (!model) | 202 | if (!model) |
@@ -209,14 +207,10 @@ list_events_clicked (gpointer data) | |||
209 | all_events = trace_view_store_get_all_events_enabled(store); | 207 | all_events = trace_view_store_get_all_events_enabled(store); |
210 | event_filter = trace_view_store_get_event_filter(store); | 208 | event_filter = trace_view_store_get_event_filter(store); |
211 | 209 | ||
212 | trace_filter_convert_filter_to_names(event_filter, | 210 | trace_filter_event_filter_dialog(store->handle, event_filter, |
213 | &systems, &events); | 211 | all_events, |
214 | 212 | trace_view_event_filter_callback, | |
215 | trace_filter_event_dialog(store->handle, all_events, | 213 | info->treeview); |
216 | systems, events, | ||
217 | trace_view_event_filter_callback, info->treeview); | ||
218 | free(systems); | ||
219 | free(events); | ||
220 | } | 214 | } |
221 | 215 | ||
222 | static void | 216 | static void |
@@ -225,17 +219,14 @@ graph_events_clicked (gpointer data) | |||
225 | struct shark_info *info = data; | 219 | struct shark_info *info = data; |
226 | struct graph_info *ginfo = info->ginfo; | 220 | struct graph_info *ginfo = info->ginfo; |
227 | gboolean all_events; | 221 | gboolean all_events; |
228 | gchar **systems; | ||
229 | gint *events; | ||
230 | 222 | ||
231 | all_events = ginfo->all_events; | 223 | all_events = ginfo->all_events; |
232 | trace_filter_convert_filter_to_names(ginfo->event_filter, | 224 | |
233 | &systems, &events); | 225 | trace_filter_event_filter_dialog(info->handle, |
234 | trace_filter_event_dialog(info->handle, all_events, | 226 | ginfo->event_filter, |
235 | systems, events, | 227 | all_events, |
236 | trace_graph_event_filter_callback, ginfo); | 228 | trace_graph_event_filter_callback, |
237 | free(systems); | 229 | ginfo); |
238 | free(events); | ||
239 | } | 230 | } |
240 | 231 | ||
241 | static void | 232 | static void |
diff --git a/trace-graph-main.c b/trace-graph-main.c index b31e118..e6fca6b 100644 --- a/trace-graph-main.c +++ b/trace-graph-main.c | |||
@@ -99,21 +99,15 @@ events_clicked (gpointer data) | |||
99 | { | 99 | { |
100 | struct graph_info *ginfo = data; | 100 | struct graph_info *ginfo = data; |
101 | gboolean all_events = TRUE; | 101 | gboolean all_events = TRUE; |
102 | gchar **systems = NULL; | ||
103 | gint *events = NULL; | ||
104 | 102 | ||
105 | if (!ginfo->handle) | 103 | if (!ginfo->handle) |
106 | return; | 104 | return; |
107 | 105 | ||
108 | all_events = ginfo->all_events; | 106 | all_events = ginfo->all_events; |
109 | 107 | ||
110 | trace_filter_convert_filter_to_names(ginfo->event_filter, | 108 | trace_filter_event_filter_dialog(ginfo->handle, ginfo->event_filter, |
111 | &systems, &events); | 109 | all_events, |
112 | trace_filter_event_dialog(ginfo->handle, all_events, | 110 | trace_graph_event_filter_callback, ginfo); |
113 | systems, events, | ||
114 | trace_graph_event_filter_callback, ginfo); | ||
115 | free(systems); | ||
116 | free(events); | ||
117 | } | 111 | } |
118 | 112 | ||
119 | void trace_graph(int argc, char **argv) | 113 | void trace_graph(int argc, char **argv) |
diff --git a/trace-graph.c b/trace-graph.c index a440602..8283824 100644 --- a/trace-graph.c +++ b/trace-graph.c | |||
@@ -1736,13 +1736,15 @@ void trace_graph_event_filter_callback(gboolean accept, | |||
1736 | 1736 | ||
1737 | if (all_events) { | 1737 | if (all_events) { |
1738 | ginfo->all_events = TRUE; | 1738 | ginfo->all_events = TRUE; |
1739 | /* filter is no longer used */ | ||
1740 | pevent_filter_reset(ginfo->event_filter); | ||
1739 | redraw_graph(ginfo); | 1741 | redraw_graph(ginfo); |
1740 | return; | 1742 | return; |
1741 | } | 1743 | } |
1742 | 1744 | ||
1743 | ginfo->all_events = FALSE; | 1745 | ginfo->all_events = FALSE; |
1744 | 1746 | ||
1745 | pevent_filter_reset(ginfo->event_filter); | 1747 | pevent_filter_clear_trivial(ginfo->event_filter, FILTER_TRIVIAL_BOTH); |
1746 | 1748 | ||
1747 | trace_filter_convert_char_to_filter(ginfo->event_filter, | 1749 | trace_filter_convert_char_to_filter(ginfo->event_filter, |
1748 | systems, events); | 1750 | systems, events); |