trace-cmd: Fix freeing on error in tracecmd_attach_cpu_data_fd()

tracecmd_attach_cpu_data_fd() had a few error paths that did not properly
free memory.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

1 files changed, 3 insertions, 4 deletions

diff --git a/trace-output.c b/trace-output.c
index 9df5394..46afe48 100644
--- a/trace-output.c
+++ b/trace-output.c
@@ -1032,7 +1032,7 @@ int tracecmd_attach_cpu_data_fd(int fd, int cpus, char * const *cpu_data_files)
 
         handle = malloc(sizeof(*handle));
         if (!handle)
-                return -1;
+                goto out_free;
         memset(handle, 0, sizeof(*handle));
 
         handle->fd = fd;
@@ -1044,10 +1044,9 @@ int tracecmd_attach_cpu_data_fd(int fd, int cpus, char * const *cpu_data_files)
         pevent_ref(pevent);
         handle->page_size = tracecmd_page_size(ihandle);
 
-        if (tracecmd_append_cpu_data(handle, cpus, cpu_data_files) < 0)
-                goto out_free;
+        if (tracecmd_append_cpu_data(handle, cpus, cpu_data_files) >= 0)
+                ret = 0;
 
-        ret = 0;
         tracecmd_output_close(handle);
  out_free:
         tracecmd_close(ihandle);