Precision fix: user deliberate rounding in LP result conversion

Use proper rounding when converting blocking terms to avoid rounding
issues.  This could cause some (very rare) off-by-one bugs when
incorrectly truncating an objective result very close to the next
largest integer.

4 files changed, 15 insertions, 11 deletions

diff --git a/native/src/blocking/linprog/lp_dflp.cpp b/native/src/blocking/linprog/lp_dflp.cpp
index 0370358..a022d7b 100644
--- a/native/src/blocking/linprog/lp_dflp.cpp
+++ b/native/src/blocking/linprog/lp_dflp.cpp
@@ -1,4 +1,5 @@
 #include <iostream>
+#include <cmath>
 
 #include "lp_common.h"
 #include "stl-hashmap.h"
@@ -167,8 +168,8 @@ static BlockingBounds* _lp_dflp_bounds(const ResourceSharingInfo& info,
         {
                 Interference total, remote, local;
 
-                local.total_length = sol->evaluate(local_obj[i]);
-                remote.total_length = sol->evaluate(remote_obj[i]);
+                local.total_length = lrint(sol->evaluate(local_obj[i]));
+                remote.total_length = lrint(sol->evaluate(remote_obj[i]));
                 total.total_length = local.total_length + remote.total_length;
 
                 (*results)[i] = total;
diff --git a/native/src/blocking/linprog/lp_dpcp.cpp b/native/src/blocking/linprog/lp_dpcp.cpp
index bec131b..50d38c5 100644
--- a/native/src/blocking/linprog/lp_dpcp.cpp
+++ b/native/src/blocking/linprog/lp_dpcp.cpp
@@ -1,6 +1,7 @@
 #include <iostream>
 #include <set>
 #include <algorithm>
+#include <cmath>
 
 #include "lp_common.h"
 #include "blocking.h"
@@ -385,8 +386,8 @@ static BlockingBounds* _lp_dpcp_bounds(const ResourceSharingInfo& info,
         {
                 Interference total, remote, local;
 
-                local.total_length = sol->evaluate(local_obj[i]);
-                remote.total_length = sol->evaluate(remote_obj[i]);
+                local.total_length = lrint(sol->evaluate(local_obj[i]));
+                remote.total_length = lrint(sol->evaluate(remote_obj[i]));
                 total.total_length = local.total_length + remote.total_length;
 
                 (*results)[i] = total;
@@ -455,8 +456,8 @@ static void apply_dpcp_bounds_for_task(
 
         Interference total, remote, local;
 
-        total.total_length = sol->evaluate(*lp.get_objective());
-        local.total_length = sol->evaluate(*local_obj);
+        total.total_length = lrint(sol->evaluate(*lp.get_objective()));
+        local.total_length = lrint(sol->evaluate(*local_obj));
         remote.total_length = total.total_length - local.total_length;
 
         bounds[i] = total;
diff --git a/native/src/blocking/linprog/lp_fmlp.cpp b/native/src/blocking/linprog/lp_fmlp.cpp
index 75e2186..3f2ff94 100644
--- a/native/src/blocking/linprog/lp_fmlp.cpp
+++ b/native/src/blocking/linprog/lp_fmlp.cpp
@@ -1,6 +1,7 @@
 #include <iostream>
 #include <set>
 #include <algorithm>
+#include <cmath>
 
 #include "lp_common.h"
 #include "blocking.h"
@@ -244,8 +245,8 @@ static void apply_fmlp_bounds_for_task(
 
         Interference total, remote, local;
 
-        total.total_length = sol->evaluate(*lp.get_objective());
-        local.total_length = sol->evaluate(*local_obj);
+        total.total_length = lrint(sol->evaluate(*lp.get_objective()));
+        local.total_length = lrint(sol->evaluate(*local_obj));
         remote.total_length = total.total_length - local.total_length;
 
         bounds[i] = total;
diff --git a/native/src/blocking/linprog/lp_mpcp.cpp b/native/src/blocking/linprog/lp_mpcp.cpp
index bccea5d..6037c3d 100644
--- a/native/src/blocking/linprog/lp_mpcp.cpp
+++ b/native/src/blocking/linprog/lp_mpcp.cpp
@@ -1,6 +1,7 @@
 #include <iostream>
 #include <set>
 #include <algorithm>
+#include <cmath>
 
 #include "lp_common.h"
 #include "blocking.h"
@@ -527,8 +528,8 @@ static void apply_mpcp_bounds_for_task(
 
         Interference total, remote, local;
 
-        total.total_length = sol->evaluate(*lp.get_objective());
-        local.total_length = sol->evaluate(*local_obj);
+        total.total_length = lrint(sol->evaluate(*lp.get_objective()));
+        local.total_length = lrint(sol->evaluate(*local_obj));
 
         bounds[i] = total;
         bounds.set_local_blocking(i, local);
@@ -546,7 +547,7 @@ static void apply_mpcp_bounds_for_task(
 
         assert(sol != NULL);
 
-        remote.total_length = sol->evaluate(*lp.get_objective());
+        remote.total_length = lrint(sol->evaluate(*lp.get_objective()));
         bounds.set_remote_blocking(i, remote);
 
 #if DEBUG_LP_OVERHEADS >= 2