diff options
author | Vijayakumar <vsubbu@nvidia.com> | 2017-05-01 02:56:14 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2017-05-02 11:04:28 -0400 |
commit | ed60c25d3840c9d198e7b4b5f852382b02ed64bd (patch) | |
tree | 1f93d2837fc7500329749d8682e40dbd6e3b406a /drivers/gpu/nvgpu/pmgr/pmgrpmu.c | |
parent | 3c44df6c98b0242cacba94d97a893d57eb46bb00 (diff) |
gpu: nvgpu: fix error for static code analysis
use memset to fill structures with zero instead of
assigning zero.
mark functions local to the file as static
fixing errors in clk, perf and therm modules.
Bug 200299572
Change-Id: I0470298803c35b6faed2edc2a0c1dbf0e47e842e
Signed-off-by: Vijayakumar <vsubbu@nvidia.com>
Reviewed-on: http://git-master/r/1472940
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: svccoveritychecker <svccoveritychecker@nvidia.com>
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/pmgr/pmgrpmu.c')
-rw-r--r-- | drivers/gpu/nvgpu/pmgr/pmgrpmu.c | 20 |
1 files changed, 14 insertions, 6 deletions
diff --git a/drivers/gpu/nvgpu/pmgr/pmgrpmu.c b/drivers/gpu/nvgpu/pmgr/pmgrpmu.c index d09becd6..b30dccca 100644 --- a/drivers/gpu/nvgpu/pmgr/pmgrpmu.c +++ b/drivers/gpu/nvgpu/pmgr/pmgrpmu.c | |||
@@ -81,12 +81,16 @@ static u32 pmgr_pmu_set_object(struct gk20a *g, | |||
81 | u16 fb_size, | 81 | u16 fb_size, |
82 | void *pobj) | 82 | void *pobj) |
83 | { | 83 | { |
84 | struct pmu_cmd cmd = { {0} }; | 84 | struct pmu_cmd cmd; |
85 | struct pmu_payload payload = { {0} }; | 85 | struct pmu_payload payload; |
86 | struct nv_pmu_pmgr_cmd_set_object *pcmd; | 86 | struct nv_pmu_pmgr_cmd_set_object *pcmd; |
87 | u32 status; | 87 | u32 status; |
88 | u32 seqdesc; | 88 | u32 seqdesc; |
89 | struct pmgr_pmucmdhandler_params handlerparams = {0}; | 89 | struct pmgr_pmucmdhandler_params handlerparams; |
90 | |||
91 | memset(&payload, 0, sizeof(struct pmu_payload)); | ||
92 | memset(&cmd, 0, sizeof(struct pmu_cmd)); | ||
93 | memset(&handlerparams, 0, sizeof(struct pmgr_pmucmdhandler_params)); | ||
90 | 94 | ||
91 | cmd.hdr.unit_id = PMU_UNIT_PMGR; | 95 | cmd.hdr.unit_id = PMU_UNIT_PMGR; |
92 | cmd.hdr.size = (u32)sizeof(struct nv_pmu_pmgr_cmd_set_object) + | 96 | cmd.hdr.size = (u32)sizeof(struct nv_pmu_pmgr_cmd_set_object) + |
@@ -360,12 +364,16 @@ u32 pmgr_pmu_pwr_devices_query_blocking( | |||
360 | u32 pwr_dev_mask, | 364 | u32 pwr_dev_mask, |
361 | struct nv_pmu_pmgr_pwr_devices_query_payload *ppayload) | 365 | struct nv_pmu_pmgr_pwr_devices_query_payload *ppayload) |
362 | { | 366 | { |
363 | struct pmu_cmd cmd = { {0} }; | 367 | struct pmu_cmd cmd; |
364 | struct pmu_payload payload = { {0} }; | 368 | struct pmu_payload payload; |
365 | struct nv_pmu_pmgr_cmd_pwr_devices_query *pcmd; | 369 | struct nv_pmu_pmgr_cmd_pwr_devices_query *pcmd; |
366 | u32 status; | 370 | u32 status; |
367 | u32 seqdesc; | 371 | u32 seqdesc; |
368 | struct pmgr_pmucmdhandler_params handlerparams = {0}; | 372 | struct pmgr_pmucmdhandler_params handlerparams; |
373 | |||
374 | memset(&payload, 0, sizeof(struct pmu_payload)); | ||
375 | memset(&cmd, 0, sizeof(struct pmu_cmd)); | ||
376 | memset(&handlerparams, 0, sizeof(struct pmgr_pmucmdhandler_params)); | ||
369 | 377 | ||
370 | cmd.hdr.unit_id = PMU_UNIT_PMGR; | 378 | cmd.hdr.unit_id = PMU_UNIT_PMGR; |
371 | cmd.hdr.size = (u32)sizeof(struct nv_pmu_pmgr_cmd_pwr_devices_query) + | 379 | cmd.hdr.size = (u32)sizeof(struct nv_pmu_pmgr_cmd_pwr_devices_query) + |