From ed60c25d3840c9d198e7b4b5f852382b02ed64bd Mon Sep 17 00:00:00 2001 From: Vijayakumar Date: Mon, 1 May 2017 12:26:14 +0530 Subject: gpu: nvgpu: fix error for static code analysis use memset to fill structures with zero instead of assigning zero. mark functions local to the file as static fixing errors in clk, perf and therm modules. Bug 200299572 Change-Id: I0470298803c35b6faed2edc2a0c1dbf0e47e842e Signed-off-by: Vijayakumar Reviewed-on: http://git-master/r/1472940 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: svccoveritychecker Reviewed-by: Sachin Nikam GVS: Gerrit_Virtual_Submit Reviewed-by: Terje Bergstrom --- drivers/gpu/nvgpu/pmgr/pmgrpmu.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) (limited to 'drivers/gpu/nvgpu/pmgr/pmgrpmu.c') diff --git a/drivers/gpu/nvgpu/pmgr/pmgrpmu.c b/drivers/gpu/nvgpu/pmgr/pmgrpmu.c index d09becd6..b30dccca 100644 --- a/drivers/gpu/nvgpu/pmgr/pmgrpmu.c +++ b/drivers/gpu/nvgpu/pmgr/pmgrpmu.c @@ -81,12 +81,16 @@ static u32 pmgr_pmu_set_object(struct gk20a *g, u16 fb_size, void *pobj) { - struct pmu_cmd cmd = { {0} }; - struct pmu_payload payload = { {0} }; + struct pmu_cmd cmd; + struct pmu_payload payload; struct nv_pmu_pmgr_cmd_set_object *pcmd; u32 status; u32 seqdesc; - struct pmgr_pmucmdhandler_params handlerparams = {0}; + struct pmgr_pmucmdhandler_params handlerparams; + + memset(&payload, 0, sizeof(struct pmu_payload)); + memset(&cmd, 0, sizeof(struct pmu_cmd)); + memset(&handlerparams, 0, sizeof(struct pmgr_pmucmdhandler_params)); cmd.hdr.unit_id = PMU_UNIT_PMGR; cmd.hdr.size = (u32)sizeof(struct nv_pmu_pmgr_cmd_set_object) + @@ -360,12 +364,16 @@ u32 pmgr_pmu_pwr_devices_query_blocking( u32 pwr_dev_mask, struct nv_pmu_pmgr_pwr_devices_query_payload *ppayload) { - struct pmu_cmd cmd = { {0} }; - struct pmu_payload payload = { {0} }; + struct pmu_cmd cmd; + struct pmu_payload payload; struct nv_pmu_pmgr_cmd_pwr_devices_query *pcmd; u32 status; u32 seqdesc; - struct pmgr_pmucmdhandler_params handlerparams = {0}; + struct pmgr_pmucmdhandler_params handlerparams; + + memset(&payload, 0, sizeof(struct pmu_payload)); + memset(&cmd, 0, sizeof(struct pmu_cmd)); + memset(&handlerparams, 0, sizeof(struct pmgr_pmucmdhandler_params)); cmd.hdr.unit_id = PMU_UNIT_PMGR; cmd.hdr.size = (u32)sizeof(struct nv_pmu_pmgr_cmd_pwr_devices_query) + -- cgit v1.2.2