summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/nvgpu/gp10b
diff options
context:
space:
mode:
authorScott Long <scottl@nvidia.com>2018-08-08 21:30:09 -0400
committermobile promotions <svcmobile_promotions@nvidia.com>2018-08-22 20:31:42 -0400
commit07f6739285140d7c5335ddcb8996450966bfc175 (patch)
treec7f1b3a73d519e44e4fe0d29516e6516740edb26 /drivers/gpu/nvgpu/gp10b
parent1c13da1d29c344cb60953eabeca56b601446c64a (diff)
gpu: nvgpu: switch gk20a nonstall ops to #defines
Fix MISRA rule 10.1 violations involving gk20a_nonstall_ops enums by replacing them with with corresponding #defines. Because these values can be used in expressions that require unsigned values (e.g. bitwise OR) we cannot use enums. The g->ce2.isr_nonstall() function was previously returning an int that was a combination of gk20a_nonstall_ops enum bits which led to the violations. JIRA NVGPU-650 Change-Id: I6210aacec8829b3c8d339c5fe3db2f3069c67406 Signed-off-by: Scott Long <scottl@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1796242 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/gp10b')
-rw-r--r--drivers/gpu/nvgpu/gp10b/ce_gp10b.c8
-rw-r--r--drivers/gpu/nvgpu/gp10b/ce_gp10b.h4
2 files changed, 6 insertions, 6 deletions
diff --git a/drivers/gpu/nvgpu/gp10b/ce_gp10b.c b/drivers/gpu/nvgpu/gp10b/ce_gp10b.c
index 048a9ba0..76179b78 100644
--- a/drivers/gpu/nvgpu/gp10b/ce_gp10b.c
+++ b/drivers/gpu/nvgpu/gp10b/ce_gp10b.c
@@ -61,9 +61,9 @@ void gp10b_ce_isr(struct gk20a *g, u32 inst_id, u32 pri_base)
61 return; 61 return;
62} 62}
63 63
64int gp10b_ce_nonstall_isr(struct gk20a *g, u32 inst_id, u32 pri_base) 64u32 gp10b_ce_nonstall_isr(struct gk20a *g, u32 inst_id, u32 pri_base)
65{ 65{
66 int ops = 0; 66 u32 ops = 0;
67 u32 ce_intr = gk20a_readl(g, ce_intr_status_r(inst_id)); 67 u32 ce_intr = gk20a_readl(g, ce_intr_status_r(inst_id));
68 68
69 nvgpu_log(g, gpu_dbg_intr, "ce nonstall isr %08x %08x\n", ce_intr, inst_id); 69 nvgpu_log(g, gpu_dbg_intr, "ce nonstall isr %08x %08x\n", ce_intr, inst_id);
@@ -71,8 +71,8 @@ int gp10b_ce_nonstall_isr(struct gk20a *g, u32 inst_id, u32 pri_base)
71 if (ce_intr & ce_intr_status_nonblockpipe_pending_f()) { 71 if (ce_intr & ce_intr_status_nonblockpipe_pending_f()) {
72 gk20a_writel(g, ce_intr_status_r(inst_id), 72 gk20a_writel(g, ce_intr_status_r(inst_id),
73 ce_intr_status_nonblockpipe_pending_f()); 73 ce_intr_status_nonblockpipe_pending_f());
74 ops |= (gk20a_nonstall_ops_wakeup_semaphore | 74 ops |= (GK20A_NONSTALL_OPS_WAKEUP_SEMAPHORE |
75 gk20a_nonstall_ops_post_events); 75 GK20A_NONSTALL_OPS_POST_EVENTS);
76 } 76 }
77 77
78 return ops; 78 return ops;
diff --git a/drivers/gpu/nvgpu/gp10b/ce_gp10b.h b/drivers/gpu/nvgpu/gp10b/ce_gp10b.h
index 7b747751..fbf5e6f8 100644
--- a/drivers/gpu/nvgpu/gp10b/ce_gp10b.h
+++ b/drivers/gpu/nvgpu/gp10b/ce_gp10b.h
@@ -1,7 +1,7 @@
1/* 1/*
2 * Pascal GPU series Copy Engine. 2 * Pascal GPU series Copy Engine.
3 * 3 *
4 * Copyright (c) 2011-2017, NVIDIA CORPORATION. All rights reserved. 4 * Copyright (c) 2011-2018, NVIDIA CORPORATION. All rights reserved.
5 * 5 *
6 * Permission is hereby granted, free of charge, to any person obtaining a 6 * Permission is hereby granted, free of charge, to any person obtaining a
7 * copy of this software and associated documentation files (the "Software"), 7 * copy of this software and associated documentation files (the "Software"),
@@ -28,6 +28,6 @@
28#include "gk20a/tsg_gk20a.h" 28#include "gk20a/tsg_gk20a.h"
29 29
30void gp10b_ce_isr(struct gk20a *g, u32 inst_id, u32 pri_base); 30void gp10b_ce_isr(struct gk20a *g, u32 inst_id, u32 pri_base);
31int gp10b_ce_nonstall_isr(struct gk20a *g, u32 inst_id, u32 pri_base); 31u32 gp10b_ce_nonstall_isr(struct gk20a *g, u32 inst_id, u32 pri_base);
32 32
33#endif /*__CE2_GP10B_H__*/ 33#endif /*__CE2_GP10B_H__*/