diff options
author | Sai Nikhil <snikhil@nvidia.com> | 2018-08-30 04:05:00 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2018-09-27 02:35:29 -0400 |
commit | d77785800b2ae4c27354500305303c395a18acf4 (patch) | |
tree | 1adc96ba310572d8b63dd2284fb801439616a4c1 /drivers/gpu/nvgpu/ctrl/ctrlboardobj.h | |
parent | 34732a14b22f09d8f9d52f756612178f0313f120 (diff) |
gpu: nvgpu: volt: fix MISRA Rule 10.4 Violations
MISRA Rule 10.4 only allows the usage of arithmetic operations on
operands of the same essential type category.
Adding "U" at the end of the integer literals to have same type of
operands when an arithmetic operation is performed.
This fixes violation where an arithmetic operation is performed on
signed and unsigned int types.
JIRA NVGPU-992
Change-Id: Ic9a911beb6d161df950ca85eb4813547603a8743
Signed-off-by: Sai Nikhil <snikhil@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1809751
Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Adeel Raza <araza@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/ctrl/ctrlboardobj.h')
-rw-r--r-- | drivers/gpu/nvgpu/ctrl/ctrlboardobj.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/gpu/nvgpu/ctrl/ctrlboardobj.h b/drivers/gpu/nvgpu/ctrl/ctrlboardobj.h index 9e4402a5..8f57e880 100644 --- a/drivers/gpu/nvgpu/ctrl/ctrlboardobj.h +++ b/drivers/gpu/nvgpu/ctrl/ctrlboardobj.h | |||
@@ -27,20 +27,20 @@ struct ctrl_boardobj { | |||
27 | u8 type; | 27 | u8 type; |
28 | }; | 28 | }; |
29 | 29 | ||
30 | #define CTRL_BOARDOBJGRP_TYPE_INVALID 0x00 | 30 | #define CTRL_BOARDOBJGRP_TYPE_INVALID 0x00U |
31 | #define CTRL_BOARDOBJGRP_TYPE_E32 0x01 | 31 | #define CTRL_BOARDOBJGRP_TYPE_E32 0x01U |
32 | #define CTRL_BOARDOBJGRP_TYPE_E255 0x02 | 32 | #define CTRL_BOARDOBJGRP_TYPE_E255 0x02U |
33 | 33 | ||
34 | #define CTRL_BOARDOBJGRP_E32_MAX_OBJECTS 32 | 34 | #define CTRL_BOARDOBJGRP_E32_MAX_OBJECTS 32U |
35 | 35 | ||
36 | #define CTRL_BOARDOBJGRP_E255_MAX_OBJECTS 255 | 36 | #define CTRL_BOARDOBJGRP_E255_MAX_OBJECTS 255U |
37 | 37 | ||
38 | #define CTRL_BOARDOBJ_MAX_BOARD_OBJECTS \ | 38 | #define CTRL_BOARDOBJ_MAX_BOARD_OBJECTS \ |
39 | CTRL_BOARDOBJGRP_E32_MAX_OBJECTS | 39 | CTRL_BOARDOBJGRP_E32_MAX_OBJECTS |
40 | 40 | ||
41 | #define CTRL_BOARDOBJ_IDX_INVALID 255 | 41 | #define CTRL_BOARDOBJ_IDX_INVALID 255U |
42 | 42 | ||
43 | #define CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_BIT_SIZE 32 | 43 | #define CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_BIT_SIZE 32U |
44 | 44 | ||
45 | #define CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(_bit) \ | 45 | #define CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(_bit) \ |
46 | ((_bit) / CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_BIT_SIZE) | 46 | ((_bit) / CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_BIT_SIZE) |
@@ -49,10 +49,10 @@ struct ctrl_boardobj { | |||
49 | ((_bit) % CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_BIT_SIZE) | 49 | ((_bit) % CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_BIT_SIZE) |
50 | 50 | ||
51 | #define CTRL_BOARDOBJGRP_MASK_DATA_SIZE(_bits) \ | 51 | #define CTRL_BOARDOBJGRP_MASK_DATA_SIZE(_bits) \ |
52 | (CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX((_bits) - 1) + 1) | 52 | (CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX((_bits) - 1U) + 1U) |
53 | 53 | ||
54 | 54 | ||
55 | #define CTRL_BOARDOBJGRP_MASK_ARRAY_START_SIZE 1 | 55 | #define CTRL_BOARDOBJGRP_MASK_ARRAY_START_SIZE 1U |
56 | #define CTRL_BOARDOBJGRP_MASK_ARRAY_EXTENSION_SIZE(_bits) \ | 56 | #define CTRL_BOARDOBJGRP_MASK_ARRAY_EXTENSION_SIZE(_bits) \ |
57 | (CTRL_BOARDOBJGRP_MASK_DATA_SIZE(_bits) - \ | 57 | (CTRL_BOARDOBJGRP_MASK_DATA_SIZE(_bits) - \ |
58 | CTRL_BOARDOBJGRP_MASK_ARRAY_START_SIZE) | 58 | CTRL_BOARDOBJGRP_MASK_ARRAY_START_SIZE) |