From d77785800b2ae4c27354500305303c395a18acf4 Mon Sep 17 00:00:00 2001 From: Sai Nikhil Date: Thu, 30 Aug 2018 13:35:00 +0530 Subject: gpu: nvgpu: volt: fix MISRA Rule 10.4 Violations MISRA Rule 10.4 only allows the usage of arithmetic operations on operands of the same essential type category. Adding "U" at the end of the integer literals to have same type of operands when an arithmetic operation is performed. This fixes violation where an arithmetic operation is performed on signed and unsigned int types. JIRA NVGPU-992 Change-Id: Ic9a911beb6d161df950ca85eb4813547603a8743 Signed-off-by: Sai Nikhil Reviewed-on: https://git-master.nvidia.com/r/1809751 Reviewed-by: svc-misra-checker GVS: Gerrit_Virtual_Submit Reviewed-by: Adeel Raza Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/ctrl/ctrlboardobj.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'drivers/gpu/nvgpu/ctrl/ctrlboardobj.h') diff --git a/drivers/gpu/nvgpu/ctrl/ctrlboardobj.h b/drivers/gpu/nvgpu/ctrl/ctrlboardobj.h index 9e4402a5..8f57e880 100644 --- a/drivers/gpu/nvgpu/ctrl/ctrlboardobj.h +++ b/drivers/gpu/nvgpu/ctrl/ctrlboardobj.h @@ -27,20 +27,20 @@ struct ctrl_boardobj { u8 type; }; -#define CTRL_BOARDOBJGRP_TYPE_INVALID 0x00 -#define CTRL_BOARDOBJGRP_TYPE_E32 0x01 -#define CTRL_BOARDOBJGRP_TYPE_E255 0x02 +#define CTRL_BOARDOBJGRP_TYPE_INVALID 0x00U +#define CTRL_BOARDOBJGRP_TYPE_E32 0x01U +#define CTRL_BOARDOBJGRP_TYPE_E255 0x02U -#define CTRL_BOARDOBJGRP_E32_MAX_OBJECTS 32 +#define CTRL_BOARDOBJGRP_E32_MAX_OBJECTS 32U -#define CTRL_BOARDOBJGRP_E255_MAX_OBJECTS 255 +#define CTRL_BOARDOBJGRP_E255_MAX_OBJECTS 255U #define CTRL_BOARDOBJ_MAX_BOARD_OBJECTS \ CTRL_BOARDOBJGRP_E32_MAX_OBJECTS -#define CTRL_BOARDOBJ_IDX_INVALID 255 +#define CTRL_BOARDOBJ_IDX_INVALID 255U -#define CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_BIT_SIZE 32 +#define CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_BIT_SIZE 32U #define CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(_bit) \ ((_bit) / CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_BIT_SIZE) @@ -49,10 +49,10 @@ struct ctrl_boardobj { ((_bit) % CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_BIT_SIZE) #define CTRL_BOARDOBJGRP_MASK_DATA_SIZE(_bits) \ - (CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX((_bits) - 1) + 1) + (CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX((_bits) - 1U) + 1U) -#define CTRL_BOARDOBJGRP_MASK_ARRAY_START_SIZE 1 +#define CTRL_BOARDOBJGRP_MASK_ARRAY_START_SIZE 1U #define CTRL_BOARDOBJGRP_MASK_ARRAY_EXTENSION_SIZE(_bits) \ (CTRL_BOARDOBJGRP_MASK_DATA_SIZE(_bits) - \ CTRL_BOARDOBJGRP_MASK_ARRAY_START_SIZE) -- cgit v1.2.2