summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/nvgpu/common
diff options
context:
space:
mode:
authorDavid Nieto <dmartineznie@nvidia.com>2017-04-19 00:56:09 -0400
committermobile promotions <svcmobile_promotions@nvidia.com>2017-09-22 18:47:01 -0400
commit90568a2ce58c03f457bdd4fab6675cd327ed13fd (patch)
tree4095b7599083ac478dbfbb522f1abcc585dc2801 /drivers/gpu/nvgpu/common
parent7134e9e852116f86745cd23312bbfba34100bf6d (diff)
gpu: nvgpu: allow bind to be interrupted
This change solves two problems: (*) the possibility of a crash due to interrupting the gpu initialization following a bind (*) a IOVA memory leak that could prevent the GPU from binding after about 200 bind/unbind cycles A detailed list of fixes: - chek that arbiter is initialized before freeing it. - do not re-enable interrupts when MSI is enabled on unbind. - free the semaphore sea on unbind. - ensure we dont double load the vbios. - check return value of nvgpu_mutex_init for semaphores. - add corresponding nvgpu_mutex_destroy calls. bug 1816516 Change-Id: Ia8af73019e0e1183998855d55bb3eea09672a8b7 Signed-off-by: David Nieto <dmartineznie@nvidia.com> Reviewed-on: http://git-master/r/1465302 Reviewed-by: Alex Waterman <alexw@nvidia.com> Reviewed-by: Thomas Fleury <tfleury@nvidia.com> Reviewed-by: David Jarrett <djarrett@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1563019 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/common')
-rw-r--r--drivers/gpu/nvgpu/common/semaphore.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/nvgpu/common/semaphore.c b/drivers/gpu/nvgpu/common/semaphore.c
index 5496f5ec..0d512e8f 100644
--- a/drivers/gpu/nvgpu/common/semaphore.c
+++ b/drivers/gpu/nvgpu/common/semaphore.c
@@ -66,11 +66,12 @@ out:
66 return ret; 66 return ret;
67} 67}
68 68
69void gk20a_semaphore_sea_destroy(struct gk20a *g) 69void nvgpu_semaphore_sea_destroy(struct gk20a *g)
70{ 70{
71 if (!g->sema_sea) 71 if (!g->sema_sea)
72 return; 72 return;
73 73
74 nvgpu_dma_free(g, &g->sema_sea->sea_mem);
74 nvgpu_mutex_destroy(&g->sema_sea->sea_lock); 75 nvgpu_mutex_destroy(&g->sema_sea->sea_lock);
75 nvgpu_kfree(g, g->sema_sea); 76 nvgpu_kfree(g, g->sema_sea);
76 g->sema_sea = NULL; 77 g->sema_sea = NULL;