From 90568a2ce58c03f457bdd4fab6675cd327ed13fd Mon Sep 17 00:00:00 2001 From: David Nieto Date: Tue, 18 Apr 2017 21:56:09 -0700 Subject: gpu: nvgpu: allow bind to be interrupted This change solves two problems: (*) the possibility of a crash due to interrupting the gpu initialization following a bind (*) a IOVA memory leak that could prevent the GPU from binding after about 200 bind/unbind cycles A detailed list of fixes: - chek that arbiter is initialized before freeing it. - do not re-enable interrupts when MSI is enabled on unbind. - free the semaphore sea on unbind. - ensure we dont double load the vbios. - check return value of nvgpu_mutex_init for semaphores. - add corresponding nvgpu_mutex_destroy calls. bug 1816516 Change-Id: Ia8af73019e0e1183998855d55bb3eea09672a8b7 Signed-off-by: David Nieto Reviewed-on: http://git-master/r/1465302 Reviewed-by: Alex Waterman Reviewed-by: Thomas Fleury Reviewed-by: David Jarrett Reviewed-on: https://git-master.nvidia.com/r/1563019 Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/semaphore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'drivers/gpu/nvgpu/common') diff --git a/drivers/gpu/nvgpu/common/semaphore.c b/drivers/gpu/nvgpu/common/semaphore.c index 5496f5ec..0d512e8f 100644 --- a/drivers/gpu/nvgpu/common/semaphore.c +++ b/drivers/gpu/nvgpu/common/semaphore.c @@ -66,11 +66,12 @@ out: return ret; } -void gk20a_semaphore_sea_destroy(struct gk20a *g) +void nvgpu_semaphore_sea_destroy(struct gk20a *g) { if (!g->sema_sea) return; + nvgpu_dma_free(g, &g->sema_sea->sea_mem); nvgpu_mutex_destroy(&g->sema_sea->sea_lock); nvgpu_kfree(g, g->sema_sea); g->sema_sea = NULL; -- cgit v1.2.2