5 files changed, 181 insertions, 115 deletions

diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c
index 4e614ac39f..627de9525a 100644
--- a/sound/usb/usbaudio.c
+++ b/sound/usb/usbaudio.c
@@ -2138,7 +2138,7 @@ static void proc_pcm_format_add(struct snd_usb_stream *stream)
 
         sprintf(name, "stream%d", stream->pcm_index);
         if (! snd_card_proc_new(card, name, &entry))
-                snd_info_set_text_ops(entry, stream, 1024, proc_pcm_format_read);
+                snd_info_set_text_ops(entry, stream, proc_pcm_format_read);
 }
 
 #else
@@ -2627,9 +2627,10 @@ static int parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no)
                 if (!csep && altsd->bNumEndpoints >= 2)
                         csep = snd_usb_find_desc(alts->endpoint[1].extra, alts->endpoint[1].extralen, NULL, USB_DT_CS_ENDPOINT);
                 if (!csep || csep[0] < 7 || csep[2] != EP_GENERAL) {
-                        snd_printk(KERN_ERR "%d:%u:%d : no or invalid class specific endpoint descriptor\n",
+                        snd_printk(KERN_WARNING "%d:%u:%d : no or invalid"
+                                   " class specific endpoint descriptor\n",
                                    dev->devnum, iface_no, altno);
-                        continue;
+                        csep = NULL;
                 }
 
                 fp = kmalloc(sizeof(*fp), GFP_KERNEL);
@@ -2648,7 +2649,7 @@ static int parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no)
                 if (snd_usb_get_speed(dev) == USB_SPEED_HIGH)
                         fp->maxpacksize = (((fp->maxpacksize >> 11) & 3) + 1)
                                         * (fp->maxpacksize & 0x7ff);
-                fp->attributes = csep[3];
+                fp->attributes = csep ? csep[3] : 0;
 
                 /* some quirks for attributes here */
 
@@ -2980,7 +2981,7 @@ static int create_ua1000_quirk(struct snd_usb_audio *chip,
                 return -ENXIO;
         alts = &iface->altsetting[1];
         altsd = get_iface_desc(alts);
-        if (alts->extralen != 11 || alts->extra[1] != CS_AUDIO_INTERFACE ||
+        if (alts->extralen != 11 || alts->extra[1] != USB_DT_CS_INTERFACE ||
             altsd->bNumEndpoints != 1)
                 return -ENXIO;
 
@@ -3197,9 +3198,9 @@ static void snd_usb_audio_create_proc(struct snd_usb_audio *chip)
 {
         struct snd_info_entry *entry;
         if (! snd_card_proc_new(chip->card, "usbbus", &entry))
-                snd_info_set_text_ops(entry, chip, 1024, proc_audio_usbbus_read);
+                snd_info_set_text_ops(entry, chip, proc_audio_usbbus_read);
         if (! snd_card_proc_new(chip->card, "usbid", &entry))
-                snd_info_set_text_ops(entry, chip, 1024, proc_audio_usbid_read);
+                snd_info_set_text_ops(entry, chip, proc_audio_usbid_read);
 }
 
 /*
diff --git a/sound/usb/usbaudio.h b/sound/usb/usbaudio.h
index 88733524d0..0f4b2b8541 100644
--- a/sound/usb/usbaudio.h
+++ b/sound/usb/usbaudio.h
@@ -30,13 +30,6 @@
 #define USB_SUBCLASS_MIDI_STREAMING     0x03
 #define USB_SUBCLASS_VENDOR_SPEC        0xff
 
-#define CS_AUDIO_UNDEFINED              0x20
-#define CS_AUDIO_DEVICE                 0x21
-#define CS_AUDIO_CONFIGURATION          0x22
-#define CS_AUDIO_STRING                 0x23
-#define CS_AUDIO_INTERFACE              0x24
-#define CS_AUDIO_ENDPOINT               0x25
-
 #define HEADER                          0x01
 #define INPUT_TERMINAL                  0x02
 #define OUTPUT_TERMINAL                 0x03
diff --git a/sound/usb/usbmidi.c b/sound/usb/usbmidi.c
index 2b9d940c80..5105b6b057 100644
--- a/sound/usb/usbmidi.c
+++ b/sound/usb/usbmidi.c
@@ -48,6 +48,7 @@
 #include <linux/usb.h>
 #include <sound/core.h>
 #include <sound/rawmidi.h>
+#include <sound/asequencer.h>
 #include "usbaudio.h"
 
 
@@ -1010,97 +1011,157 @@ static struct snd_rawmidi_substream *snd_usbmidi_find_substream(struct snd_usb_m
  * "(product) MIDI (n)" schema because they aren't external MIDI ports,
  * such as internal control or synthesizer ports.
  */
-static struct {
+static struct port_info {
         u32 id;
-        int port;
-        const char *name_format;
-} snd_usbmidi_port_names[] = {
+        short int port;
+        short int voices;
+        const char *name;
+        unsigned int seq_flags;
+} snd_usbmidi_port_info[] = {
+#define PORT_INFO(vendor, product, num, name_, voices_, flags) \
+        { .id = USB_ID(vendor, product), \
+          .port = num, .voices = voices_, \
+          .name = name_, .seq_flags = flags }
+#define EXTERNAL_PORT(vendor, product, num, name) \
+        PORT_INFO(vendor, product, num, name, 0, \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_GENERIC | \
+                  SNDRV_SEQ_PORT_TYPE_HARDWARE | \
+                  SNDRV_SEQ_PORT_TYPE_PORT)
+#define CONTROL_PORT(vendor, product, num, name) \
+        PORT_INFO(vendor, product, num, name, 0, \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_GENERIC | \
+                  SNDRV_SEQ_PORT_TYPE_HARDWARE)
+#define ROLAND_SYNTH_PORT(vendor, product, num, name, voices) \
+        PORT_INFO(vendor, product, num, name, voices, \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_GENERIC | \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_GM | \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_GM2 | \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_GS | \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_XG | \
+                  SNDRV_SEQ_PORT_TYPE_HARDWARE | \
+                  SNDRV_SEQ_PORT_TYPE_SYNTHESIZER)
+#define SOUNDCANVAS_PORT(vendor, product, num, name, voices) \
+        PORT_INFO(vendor, product, num, name, voices, \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_GENERIC | \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_GM | \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_GM2 | \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_GS | \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_XG | \
+                  SNDRV_SEQ_PORT_TYPE_MIDI_MT32 | \
+                  SNDRV_SEQ_PORT_TYPE_HARDWARE | \
+                  SNDRV_SEQ_PORT_TYPE_SYNTHESIZER)
         /* Roland UA-100 */
-        { USB_ID(0x0582, 0x0000), 2, "%s Control" },
+        CONTROL_PORT(0x0582, 0x0000, 2, "%s Control"),
         /* Roland SC-8850 */
-        { USB_ID(0x0582, 0x0003), 0, "%s Part A" },
-        { USB_ID(0x0582, 0x0003), 1, "%s Part B" },
-        { USB_ID(0x0582, 0x0003), 2, "%s Part C" },
-        { USB_ID(0x0582, 0x0003), 3, "%s Part D" },
-        { USB_ID(0x0582, 0x0003), 4, "%s MIDI 1" },
-        { USB_ID(0x0582, 0x0003), 5, "%s MIDI 2" },
+        SOUNDCANVAS_PORT(0x0582, 0x0003, 0, "%s Part A", 128),
+        SOUNDCANVAS_PORT(0x0582, 0x0003, 1, "%s Part B", 128),
+        SOUNDCANVAS_PORT(0x0582, 0x0003, 2, "%s Part C", 128),
+        SOUNDCANVAS_PORT(0x0582, 0x0003, 3, "%s Part D", 128),
+        EXTERNAL_PORT(0x0582, 0x0003, 4, "%s MIDI 1"),
+        EXTERNAL_PORT(0x0582, 0x0003, 5, "%s MIDI 2"),
         /* Roland U-8 */
-        { USB_ID(0x0582, 0x0004), 0, "%s MIDI" },
-        { USB_ID(0x0582, 0x0004), 1, "%s Control" },
+        EXTERNAL_PORT(0x0582, 0x0004, 0, "%s MIDI"),
+        CONTROL_PORT(0x0582, 0x0004, 1, "%s Control"),
         /* Roland SC-8820 */
-        { USB_ID(0x0582, 0x0007), 0, "%s Part A" },
-        { USB_ID(0x0582, 0x0007), 1, "%s Part B" },
-        { USB_ID(0x0582, 0x0007), 2, "%s MIDI" },
+        SOUNDCANVAS_PORT(0x0582, 0x0007, 0, "%s Part A", 64),
+        SOUNDCANVAS_PORT(0x0582, 0x0007, 1, "%s Part B", 64),
+        EXTERNAL_PORT(0x0582, 0x0007, 2, "%s MIDI"),
         /* Roland SK-500 */
-        { USB_ID(0x0582, 0x000b), 0, "%s Part A" },
-        { USB_ID(0x0582, 0x000b), 1, "%s Part B" },
-        { USB_ID(0x0582, 0x000b), 2, "%s MIDI" },
+        SOUNDCANVAS_PORT(0x0582, 0x000b, 0, "%s Part A", 64),
+        SOUNDCANVAS_PORT(0x0582, 0x000b, 1, "%s Part B", 64),
+        EXTERNAL_PORT(0x0582, 0x000b, 2, "%s MIDI"),
         /* Roland SC-D70 */
-        { USB_ID(0x0582, 0x000c), 0, "%s Part A" },
-        { USB_ID(0x0582, 0x000c), 1, "%s Part B" },
-        { USB_ID(0x0582, 0x000c), 2, "%s MIDI" },
+        SOUNDCANVAS_PORT(0x0582, 0x000c, 0, "%s Part A", 64),
+        SOUNDCANVAS_PORT(0x0582, 0x000c, 1, "%s Part B", 64),
+        EXTERNAL_PORT(0x0582, 0x000c, 2, "%s MIDI"),
         /* Edirol UM-880 */
-        { USB_ID(0x0582, 0x0014), 8, "%s Control" },
+        CONTROL_PORT(0x0582, 0x0014, 8, "%s Control"),
         /* Edirol SD-90 */
-        { USB_ID(0x0582, 0x0016), 0, "%s Part A" },
-        { USB_ID(0x0582, 0x0016), 1, "%s Part B" },
-        { USB_ID(0x0582, 0x0016), 2, "%s MIDI 1" },
-        { USB_ID(0x0582, 0x0016), 3, "%s MIDI 2" },
+        ROLAND_SYNTH_PORT(0x0582, 0x0016, 0, "%s Part A", 128),
+        ROLAND_SYNTH_PORT(0x0582, 0x0016, 1, "%s Part B", 128),
+        EXTERNAL_PORT(0x0582, 0x0016, 2, "%s MIDI 1"),
+        EXTERNAL_PORT(0x0582, 0x0016, 3, "%s MIDI 2"),
         /* Edirol UM-550 */
-        { USB_ID(0x0582, 0x0023), 5, "%s Control" },
+        CONTROL_PORT(0x0582, 0x0023, 5, "%s Control"),
         /* Edirol SD-20 */
-        { USB_ID(0x0582, 0x0027), 0, "%s Part A" },
-        { USB_ID(0x0582, 0x0027), 1, "%s Part B" },
-        { USB_ID(0x0582, 0x0027), 2, "%s MIDI" },
+        ROLAND_SYNTH_PORT(0x0582, 0x0027, 0, "%s Part A", 64),
+        ROLAND_SYNTH_PORT(0x0582, 0x0027, 1, "%s Part B", 64),
+        EXTERNAL_PORT(0x0582, 0x0027, 2, "%s MIDI"),
         /* Edirol SD-80 */
-        { USB_ID(0x0582, 0x0029), 0, "%s Part A" },
-        { USB_ID(0x0582, 0x0029), 1, "%s Part B" },
-        { USB_ID(0x0582, 0x0029), 2, "%s MIDI 1" },
-        { USB_ID(0x0582, 0x0029), 3, "%s MIDI 2" },
+        ROLAND_SYNTH_PORT(0x0582, 0x0029, 0, "%s Part A", 128),
+        ROLAND_SYNTH_PORT(0x0582, 0x0029, 1, "%s Part B", 128),
+        EXTERNAL_PORT(0x0582, 0x0029, 2, "%s MIDI 1"),
+        EXTERNAL_PORT(0x0582, 0x0029, 3, "%s MIDI 2"),
         /* Edirol UA-700 */
-        { USB_ID(0x0582, 0x002b), 0, "%s MIDI" },
-        { USB_ID(0x0582, 0x002b), 1, "%s Control" },
+        EXTERNAL_PORT(0x0582, 0x002b, 0, "%s MIDI"),
+        CONTROL_PORT(0x0582, 0x002b, 1, "%s Control"),
         /* Roland VariOS */
-        { USB_ID(0x0582, 0x002f), 0, "%s MIDI" },
-        { USB_ID(0x0582, 0x002f), 1, "%s External MIDI" },
-        { USB_ID(0x0582, 0x002f), 2, "%s Sync" },
+        EXTERNAL_PORT(0x0582, 0x002f, 0, "%s MIDI"),
+        EXTERNAL_PORT(0x0582, 0x002f, 1, "%s External MIDI"),
+        EXTERNAL_PORT(0x0582, 0x002f, 2, "%s Sync"),
         /* Edirol PCR */
-        { USB_ID(0x0582, 0x0033), 0, "%s MIDI" },
-        { USB_ID(0x0582, 0x0033), 1, "%s 1" },
-        { USB_ID(0x0582, 0x0033), 2, "%s 2" },
+        EXTERNAL_PORT(0x0582, 0x0033, 0, "%s MIDI"),
+        EXTERNAL_PORT(0x0582, 0x0033, 1, "%s 1"),
+        EXTERNAL_PORT(0x0582, 0x0033, 2, "%s 2"),
         /* BOSS GS-10 */
-        { USB_ID(0x0582, 0x003b), 0, "%s MIDI" },
-        { USB_ID(0x0582, 0x003b), 1, "%s Control" },
+        EXTERNAL_PORT(0x0582, 0x003b, 0, "%s MIDI"),
+        CONTROL_PORT(0x0582, 0x003b, 1, "%s Control"),
         /* Edirol UA-1000 */
-        { USB_ID(0x0582, 0x0044), 0, "%s MIDI" },
-        { USB_ID(0x0582, 0x0044), 1, "%s Control" },
+        EXTERNAL_PORT(0x0582, 0x0044, 0, "%s MIDI"),
+        CONTROL_PORT(0x0582, 0x0044, 1, "%s Control"),
         /* Edirol UR-80 */
-        { USB_ID(0x0582, 0x0048), 0, "%s MIDI" },
-        { USB_ID(0x0582, 0x0048), 1, "%s 1" },
-        { USB_ID(0x0582, 0x0048), 2, "%s 2" },
+        EXTERNAL_PORT(0x0582, 0x0048, 0, "%s MIDI"),
+        EXTERNAL_PORT(0x0582, 0x0048, 1, "%s 1"),
+        EXTERNAL_PORT(0x0582, 0x0048, 2, "%s 2"),
         /* Edirol PCR-A */
-        { USB_ID(0x0582, 0x004d), 0, "%s MIDI" },
-        { USB_ID(0x0582, 0x004d), 1, "%s 1" },
-        { USB_ID(0x0582, 0x004d), 2, "%s 2" },
+        EXTERNAL_PORT(0x0582, 0x004d, 0, "%s MIDI"),
+        EXTERNAL_PORT(0x0582, 0x004d, 1, "%s 1"),
+        EXTERNAL_PORT(0x0582, 0x004d, 2, "%s 2"),
         /* Edirol UM-3EX */
-        { USB_ID(0x0582, 0x009a), 3, "%s Control" },
+        CONTROL_PORT(0x0582, 0x009a, 3, "%s Control"),
         /* M-Audio MidiSport 8x8 */
-        { USB_ID(0x0763, 0x1031), 8, "%s Control" },
-        { USB_ID(0x0763, 0x1033), 8, "%s Control" },
+        CONTROL_PORT(0x0763, 0x1031, 8, "%s Control"),
+        CONTROL_PORT(0x0763, 0x1033, 8, "%s Control"),
         /* MOTU Fastlane */
-        { USB_ID(0x07fd, 0x0001), 0, "%s MIDI A" },
-        { USB_ID(0x07fd, 0x0001), 1, "%s MIDI B" },
+        EXTERNAL_PORT(0x07fd, 0x0001, 0, "%s MIDI A"),
+        EXTERNAL_PORT(0x07fd, 0x0001, 1, "%s MIDI B"),
         /* Emagic Unitor8/AMT8/MT4 */
-        { USB_ID(0x086a, 0x0001), 8, "%s Broadcast" },
-        { USB_ID(0x086a, 0x0002), 8, "%s Broadcast" },
-        { USB_ID(0x086a, 0x0003), 4, "%s Broadcast" },
+        EXTERNAL_PORT(0x086a, 0x0001, 8, "%s Broadcast"),
+        EXTERNAL_PORT(0x086a, 0x0002, 8, "%s Broadcast"),
+        EXTERNAL_PORT(0x086a, 0x0003, 4, "%s Broadcast"),
 };
 
+static struct port_info *find_port_info(struct snd_usb_midi* umidi, int number)
+{
+        int i;
+
+        for (i = 0; i < ARRAY_SIZE(snd_usbmidi_port_info); ++i) {
+                if (snd_usbmidi_port_info[i].id == umidi->chip->usb_id &&
+                    snd_usbmidi_port_info[i].port == number)
+                        return &snd_usbmidi_port_info[i];
+        }
+        return NULL;
+}
+
+static void snd_usbmidi_get_port_info(struct snd_rawmidi *rmidi, int number,
+                                      struct snd_seq_port_info *seq_port_info)
+{
+        struct snd_usb_midi *umidi = rmidi->private_data;
+        struct port_info *port_info;
+
+        /* TODO: read port flags from descriptors */
+        port_info = find_port_info(umidi, number);
+        if (port_info) {
+                seq_port_info->type = port_info->seq_flags;
+                seq_port_info->midi_voices = port_info->voices;
+        }
+}
+
 static void snd_usbmidi_init_substream(struct snd_usb_midi* umidi,
                                        int stream, int number,
                                        struct snd_rawmidi_substream ** rsubstream)
 {
-        int i;
+        struct port_info *port_info;
         const char *name_format;
 
         struct snd_rawmidi_substream *substream = snd_usbmidi_find_substream(umidi, stream, number);
@@ -1110,14 +1171,8 @@ static void snd_usbmidi_init_substream(struct snd_usb_midi* umidi,
         }
 
         /* TODO: read port name from jack descriptor */
-        name_format = "%s MIDI %d";
-        for (i = 0; i < ARRAY_SIZE(snd_usbmidi_port_names); ++i) {
-                if (snd_usbmidi_port_names[i].id == umidi->chip->usb_id &&
-                    snd_usbmidi_port_names[i].port == number) {
-                        name_format = snd_usbmidi_port_names[i].name_format;
-                        break;
-                }
-        }
+        port_info = find_port_info(umidi, number);
+        name_format = port_info ? port_info->name : "%s MIDI %d";
         snprintf(substream->name, sizeof(substream->name),
                  name_format, umidi->chip->card->shortname, number + 1);
 
@@ -1358,7 +1413,7 @@ static int snd_usbmidi_detect_yamaha(struct snd_usb_midi* umidi,
         for (cs_desc = hostif->extra;
              cs_desc < hostif->extra + hostif->extralen && cs_desc[0] >= 2;
              cs_desc += cs_desc[0]) {
-                if (cs_desc[1] == CS_AUDIO_INTERFACE) {
+                if (cs_desc[1] == USB_DT_CS_INTERFACE) {
                         if (cs_desc[2] == MIDI_IN_JACK)
                                 endpoint->in_cables = (endpoint->in_cables << 1) | 1;
                         else if (cs_desc[2] == MIDI_OUT_JACK)
@@ -1457,6 +1512,10 @@ static int snd_usbmidi_create_endpoints_midiman(struct snd_usb_midi* umidi,
         return 0;
 }
 
+static struct snd_rawmidi_global_ops snd_usbmidi_ops = {
+        .get_port_info = snd_usbmidi_get_port_info,
+};
+
 static int snd_usbmidi_create_rawmidi(struct snd_usb_midi* umidi,
                                       int out_ports, int in_ports)
 {
@@ -1472,6 +1531,7 @@ static int snd_usbmidi_create_rawmidi(struct snd_usb_midi* umidi,
         rmidi->info_flags = SNDRV_RAWMIDI_INFO_OUTPUT |
                             SNDRV_RAWMIDI_INFO_INPUT |
                             SNDRV_RAWMIDI_INFO_DUPLEX;
+        rmidi->ops = &snd_usbmidi_ops;
         rmidi->private_data = umidi;
         rmidi->private_free = snd_usbmidi_rawmidi_free;
         snd_rawmidi_set_ops(rmidi, SNDRV_RAWMIDI_STREAM_OUTPUT, &snd_usbmidi_output_ops);
diff --git a/sound/usb/usbmixer.c b/sound/usb/usbmixer.c
index ce86283ee0..491e975a0c 100644
--- a/sound/usb/usbmixer.c
+++ b/sound/usb/usbmixer.c
@@ -46,6 +46,27 @@
 /* ignore error from controls - for debugging */
 /* #define IGNORE_CTL_ERROR */
 
+/*
+ * Sound Blaster remote control configuration
+ *
+ * format of remote control data:
+ * Extigy:       xx 00
+ * Audigy 2 NX:  06 80 xx 00 00 00
+ * Live! 24-bit: 06 80 xx yy 22 83
+ */
+static const struct rc_config {
+        u32 usb_id;
+        u8  offset;
+        u8  length;
+        u8  packet_length;
+        u8  mute_mixer_id;
+        u32 mute_code;
+} rc_configs[] = {
+        { USB_ID(0x041e, 0x3000), 0, 1, 2,  18, 0x0013 }, /* Extigy       */
+        { USB_ID(0x041e, 0x3020), 2, 1, 6,  18, 0x0013 }, /* Audigy 2 NX  */
+        { USB_ID(0x041e, 0x3040), 2, 2, 6,  2,  0x6e91 }, /* Live! 24-bit */
+};
+
 struct usb_mixer_interface {
         struct snd_usb_audio *chip;
         unsigned int ctrlif;
@@ -55,11 +76,7 @@ struct usb_mixer_interface {
         struct usb_mixer_elem_info **id_elems; /* array[256], indexed by unit id */
 
         /* Sound Blaster remote control stuff */
-        enum {
-                RC_NONE,
-                RC_EXTIGY,
-                RC_AUDIGY2NX,
-        } rc_type;
+        const struct rc_config *rc_cfg;
         unsigned long rc_hwdep_open;
         u32 rc_code;
         wait_queue_head_t rc_waitq;
@@ -1647,7 +1664,7 @@ static void snd_usb_mixer_notify_id(struct usb_mixer_interface *mixer,
 static void snd_usb_mixer_memory_change(struct usb_mixer_interface *mixer,
                                         int unitid)
 {
-        if (mixer->rc_type == RC_NONE)
+        if (!mixer->rc_cfg)
                 return;
         /* unit ids specific to Extigy/Audigy 2 NX: */
         switch (unitid) {
@@ -1732,20 +1749,19 @@ static void snd_usb_soundblaster_remote_complete(struct urb *urb,
                                                  struct pt_regs *regs)
 {
         struct usb_mixer_interface *mixer = urb->context;
-        /*
-         * format of remote control data:
-         * Extigy:      xx 00
-         * Audigy 2 NX: 06 80 xx 00 00 00
-         */
-        int offset = mixer->rc_type == RC_EXTIGY ? 0 : 2;
+        const struct rc_config *rc = mixer->rc_cfg;
         u32 code;
 
-        if (urb->status < 0 || urb->actual_length <= offset)
+        if (urb->status < 0 || urb->actual_length < rc->packet_length)
                 return;
-        code = mixer->rc_buffer[offset];
+
+        code = mixer->rc_buffer[rc->offset];
+        if (rc->length == 2)
+                code |= mixer->rc_buffer[rc->offset + 1] << 8;
+
         /* the Mute button actually changes the mixer control */
-        if (code == 13)
-                snd_usb_mixer_notify_id(mixer, 18);
+        if (code == rc->mute_code)
+                snd_usb_mixer_notify_id(mixer, rc->mute_mixer_id);
         mixer->rc_code = code;
         wmb();
         wake_up(&mixer->rc_waitq);
@@ -1801,21 +1817,17 @@ static unsigned int snd_usb_sbrc_hwdep_poll(struct snd_hwdep *hw, struct file *f
 static int snd_usb_soundblaster_remote_init(struct usb_mixer_interface *mixer)
 {
         struct snd_hwdep *hwdep;
-        int err, len;
+        int err, len, i;
 
-        switch (mixer->chip->usb_id) {
-        case USB_ID(0x041e, 0x3000):
-                mixer->rc_type = RC_EXTIGY;
-                len = 2;
-                break;
-        case USB_ID(0x041e, 0x3020):
-                mixer->rc_type = RC_AUDIGY2NX;
-                len = 6;
-                break;
-        default:
+        for (i = 0; i < ARRAY_SIZE(rc_configs); ++i)
+                if (rc_configs[i].usb_id == mixer->chip->usb_id)
+                        break;
+        if (i >= ARRAY_SIZE(rc_configs))
                 return 0;
-        }
+        mixer->rc_cfg = &rc_configs[i];
 
+        len = mixer->rc_cfg->packet_length;
+        
         init_waitqueue_head(&mixer->rc_waitq);
         err = snd_hwdep_new(mixer->chip->card, "SB remote control", 0, &hwdep);
         if (err < 0)
@@ -1998,7 +2010,7 @@ int snd_usb_create_mixer(struct snd_usb_audio *chip, int ctrlif)
                 if ((err = snd_audigy2nx_controls_create(mixer)) < 0)
                         goto _error;
                 if (!snd_card_proc_new(chip->card, "audigy2nx", &entry))
-                        snd_info_set_text_ops(entry, mixer, 1024,
+                        snd_info_set_text_ops(entry, mixer,
                                               snd_audigy2nx_proc_read);
         }
 
diff --git a/sound/usb/usx2y/usx2yhwdeppcm.c b/sound/usb/usx2y/usx2yhwdeppcm.c
index fe67a92e2a..88b72b5259 100644
--- a/sound/usb/usx2y/usx2yhwdeppcm.c
+++ b/sound/usb/usx2y/usx2yhwdeppcm.c
@@ -632,7 +632,7 @@ static int usX2Y_pcms_lock_check(struct snd_card *card)
                 for (s = 0; s < 2; ++s) {
                         struct snd_pcm_substream *substream;
                         substream = pcm->streams[s].substream;
-                        if (substream && substream->ffile != NULL)
+                        if (SUBSTREAM_BUSY(substream))
                                 err = -EBUSY;
                 }
         }